Use Ref<> as much as possible
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2
3         Use Ref<> as much as possible
4         https://bugs.webkit.org/show_bug.cgi?id=192808
5
6         Reviewed by Alex Christensen.
7
8         * Plugins/PluginDatabase.cpp:
9         (WebCore::PluginDatabase::refresh):
10         * Plugins/PluginView.cpp:
11         (WebCore::PluginView::mediaCanStart):
12         (WebCore::PluginView::performRequest):
13         (WebCore::PluginView::bindingInstance):
14         * Plugins/PluginView.h:
15         * WebCoreSupport/WebFrameLoaderClient.cpp:
16         (WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
17         (WebFrameLoaderClient::createPlugin):
18         (WebFrameLoaderClient::createJavaAppletWidget):
19         * WebCoreSupport/WebFrameLoaderClient.h:
20         * WebFrame.cpp:
21         (WebFrame::loadData):
22         (WebFrame::loadPlainTextString):
23         (WebFrame::loadHTMLString):
24         * WebFrame.h:
25         * WebKitQuartzCoreAdditions/CAView.cpp:
26         (WKQCA::CAView::create):
27         * WebKitQuartzCoreAdditions/CAView.h:
28         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
29         (WKQCA::CVDisplayLink::create):
30         * WebKitQuartzCoreAdditions/CVDisplayLink.h:
31         * WebKitQuartzCoreAdditions/ImageConversion.cpp:
32         (WKQCA::getImageCopy):
33         * WebView.cpp:
34         (WebView::addUserScriptToGroup):
35         (WebView::addUserStyleSheetToGroup):
36
37 2018-12-20  Chris Dumez  <cdumez@apple.com>
38
39         Use Optional::valueOr() instead of Optional::value_or()
40         https://bugs.webkit.org/show_bug.cgi?id=192933
41
42         Reviewed by Geoffrey Garen.
43
44         * WebSecurityOrigin.cpp:
45         (WebSecurityOrigin::port):
46
47 2018-12-19  Chris Dumez  <cdumez@apple.com>
48
49         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
50         https://bugs.webkit.org/show_bug.cgi?id=192728
51         <rdar://problem/46746779>
52
53         Reviewed by Geoff Garen.
54
55         * Plugins/*:
56         * WebCoreSupport/*:
57
58 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
59
60         [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag
61         https://bugs.webkit.org/show_bug.cgi?id=192617
62
63         Reviewed by Alex Christensen.
64
65         * COMEnumVariant.h:
66         (COMEnumVariant<ContainerType>::adopt): Removed 'typename' from non dependent names.
67         (COMEnumVariant<ContainerType>::createInstance): Ditto.
68         (COMEnumVariant<ContainerType>::Next): Prepend 'typename' for dependent names.
69         * COMPropertyBag.h:
70         (HashType>::createInstance): Removed 'typename' from non dependent names.
71         (HashType>::adopt): Ditto.
72         (HashType>::Read): Replaced dependent name 'HashMapType::const_iterator' with 'auto'.
73         (HashType>::GetPropertyInfo): Ditto.
74
75 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
76
77         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
78         https://bugs.webkit.org/show_bug.cgi?id=192618
79
80         Reviewed by Alex Christensen.
81
82         Classes which implement COM interface usually doesn't need the
83         virtual destructor because it has Release() virtual method to
84         destruct itself.
85
86         Marked 'final' such classes to suppress clang-cl's compilation
87         warnings.
88
89         * COMEnumVariant.h:
90         * COMPropertyBag.h:
91         * DefaultDownloadDelegate.h:
92         * DefaultPolicyDelegate.h:
93         * MemoryStream.h:
94         * WebActionPropertyBag.h:
95         * WebApplicationCache.h:
96         * WebArchive.h:
97         * WebBackForwardList.h:
98         * WebCache.h:
99         * WebCoreStatistics.h:
100         * WebCoreSupport/WebEditorClient.cpp:
101         * WebCoreSupport/WebInspectorDelegate.h:
102         * WebDataSource.h:
103         * WebDatabaseManager.cpp:
104         * WebDatabaseManager.h:
105         * WebDownload.h:
106         * WebDropSource.h:
107         * WebElementPropertyBag.h:
108         * WebError.h:
109         * WebFrame.cpp:
110         * WebFrame.h:
111         * WebFramePolicyListener.h:
112         * WebGeolocationPolicyListener.h:
113         * WebGeolocationPosition.h:
114         * WebHTMLRepresentation.h:
115         * WebHistory.h:
116         * WebHistoryItem.h:
117         * WebInspector.h:
118         * WebJavaScriptCollector.h:
119         * WebKitClassFactory.h:
120         * WebKitMessageLoop.h:
121         * WebKitStatistics.h:
122         * WebMutableURLRequest.h:
123         * WebNavigationData.h:
124         * WebNotification.h:
125         * WebNotificationCenter.h:
126         * WebPreferences.h:
127         * WebResource.h:
128         * WebScriptWorld.h:
129         * WebSecurityOrigin.h:
130         * WebSerializedJSValue.h:
131         * WebTextRenderer.h:
132         * WebURLAuthenticationChallenge.h:
133         * WebURLAuthenticationChallengeSender.h:
134         * WebURLCredential.h:
135         * WebURLProtectionSpace.h:
136         * WebURLResponse.h:
137         * WebUserContentURLPattern.h:
138         * WebView.cpp:
139         * WebView.h:
140         * WebWorkersPrivate.h:
141
142 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
143
144         [Win][Clang] Fix warning -Wmissing-field-initializers
145         https://bugs.webkit.org/show_bug.cgi?id=192584
146
147         Reviewed by Yusuke Suzuki.
148
149         Initialize a struct with '{ }' instead of '= {0}'.
150
151         * WebKitMessageLoop.cpp:
152         (WebKitMessageLoop::run):
153         * WebView.cpp:
154         (WebView::onMenuCommand):
155         (WebView::gesture):
156         (WebView::setShouldInvertColors):
157         (WebView::initializeToolTipWindow):
158         (WebView::setToolTip):
159         (WebView::fullScreenClientForceRepaint):
160
161 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
162
163         Turn WritingDirection into an enum class
164         https://bugs.webkit.org/show_bug.cgi?id=192401
165         Work towards <rdar://problem/42075638>
166
167         Reviewed by Dan Bernstein.
168
169         Change WritingDirection from an enum to an enum class. No change in behavior.
170
171         * WebFrame.cpp:
172         (WebFrame::setTextDirection):
173
174 2018-12-03  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
175
176         Use WallTime for file time
177         https://bugs.webkit.org/show_bug.cgi?id=192287
178
179         Reviewed by Darin Adler.
180
181         * Plugins/PluginDatabase.cpp:
182         (WebCore::PluginDatabase::refresh):
183
184 2018-11-30  Alex Christensen  <achristensen@webkit.org>
185
186         Fix Windows build.
187
188         * WebView.cpp:
189
190 2018-11-30  Alex Christensen  <achristensen@webkit.org>
191
192         Fix Windows build.
193
194         * WebCoreSupport/WebFrameLoaderClient.h:
195
196 2018-11-30  Alex Christensen  <achristensen@webkit.org>
197
198         Fix Windows build.
199
200         * WebCoreSupport/WebFrameLoaderClient.h:
201
202 2018-11-30  Alex Christensen  <achristensen@webkit.org>
203
204         Move URL from WebCore to WTF
205         https://bugs.webkit.org/show_bug.cgi?id=190234
206
207         Reviewed by Keith Miller.
208
209         * MarshallingHelpers.cpp:
210         * MarshallingHelpers.h:
211         * Plugins/PluginDatabase.cpp:
212         * Plugins/PluginDatabase.h:
213         * Plugins/PluginDatabaseWin.cpp:
214         * Plugins/PluginStream.h:
215         * Plugins/PluginView.h:
216         * WebCoreSupport/WebContextMenuClient.h:
217         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
218         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
219         * WebCoreSupport/WebFrameLoaderClient.h:
220         * WebCoreSupport/WebPlatformStrategies.h:
221         * WebCoreSupport/WebPluginInfoProvider.cpp:
222         (WebPluginInfoProvider::webVisiblePluginInfo):
223         * WebCoreSupport/WebPluginInfoProvider.h:
224         * WebCoreSupport/WebVisitedLinkStore.h:
225         * WebDataSource.cpp:
226         * WebDownload.h:
227         * WebElementPropertyBag.cpp:
228         * WebFrame.h:
229         * WebHistory.cpp:
230         * WebHistory.h:
231         * WebHistoryItem.cpp:
232         * WebResource.cpp:
233         (WebResource::WebResource):
234         * WebResource.h:
235         * WebSecurityOrigin.cpp:
236         * WebURLResponse.cpp:
237         (WebURLResponse::createInstance):
238         * WebUserContentURLPattern.cpp:
239         * WebView.h:
240
241 2018-11-28  Alex Christensen  <achristensen@webkit.org>
242
243         Remove dead code from an earlier attempt at implementing safe browsing
244         https://bugs.webkit.org/show_bug.cgi?id=192067
245
246         Reviewed by Chris Dumez.
247
248         * WebCoreSupport/WebFrameLoaderClient.cpp:
249         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
250         * WebCoreSupport/WebFrameLoaderClient.h:
251
252 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
253
254         [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
255         https://bugs.webkit.org/show_bug.cgi?id=191959
256
257         Reviewed by Alex Christensen.
258
259         * MarshallingHelpers.h: Removed extra "MarshallingHelpers::" of windowsEpochAbsoluteTime declaration.
260
261 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
262
263         [Win] Reduce the use of WKSI library calls: CoreAnimation
264         https://bugs.webkit.org/show_bug.cgi?id=191777
265         <rdar://problem/46140542>
266
267         Reviewed by Zalan Bujtas.
268
269         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
270         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
271         directives for WebKitSystemInterface.lib.
272
273         * FullscreenVideoController.cpp:
274         * WebKitGraphics.cpp:
275         * WebPreferences.cpp:
276
277 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
278
279         Address post-review feedback after r238438
280         https://bugs.webkit.org/show_bug.cgi?id=191913
281
282         Reviewed by Ryosuke Niwa.
283
284         * AccessibleTextImpl.cpp:
285         (AccessibleText::replaceText):
286
287 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
288
289         Web Inspector: "Reload Web Inspector" button no longer partially works
290         https://bugs.webkit.org/show_bug.cgi?id=191773
291         <rdar://problem/46139932>
292
293         Reviewed by Devin Rousso.
294
295         * WebCoreSupport/WebInspectorClient.cpp:
296         (WebInspectorFrontendClient::reopen):
297         * WebCoreSupport/WebInspectorClient.h:
298
299 2018-11-17  Devin Rousso  <drousso@apple.com>
300
301         Web Inspector: Network: add button to show system certificate dialog
302         https://bugs.webkit.org/show_bug.cgi?id=191458
303         <rdar://problem/45977019>
304
305         Reviewed by Joseph Pecoraro.
306
307         * WebCoreSupport/WebInspectorClient.h:
308         * WebCoreSupport/WebInspectorClient.cpp:
309         (WebInspectorFrontendClient::showCertificate): Added.
310
311 2018-11-16  Brent Fulgham  <bfulgham@apple.com>
312
313         [Win] Reduce the use of WKSI library calls: CFNetwork
314         https://bugs.webkit.org/show_bug.cgi?id=191718
315         <rdar://problem/46108732>
316
317         Reviewed by Alex Christensen.
318
319         Remove custom WKSI CFNetwork calls, since the SPI is already documented in PAL. Just
320         make the same calls on Windows, like we did for iOS and macOS back in 2017.
321
322         * WebCache.cpp:
323         (WebCache::cacheFolder):
324         * WebCoreSupport/WebFrameNetworkingContext.cpp:
325         * WebCoreSupport/WebPlatformStrategies.cpp:
326         * WebError.cpp:
327         (WebError::localizedDescription):
328         (WebError::sslPeerCertificate):
329         * WebURLResponse.cpp:
330         (WebURLResponse::sslPeerCertificate):
331         (WebURLResponse::certificateDictionary const):
332         * WebView.cpp:
333         (WebView::setCacheModel):
334
335 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
336
337         [Win] Reduce the use of WKSI library calls: Font Handling
338         https://bugs.webkit.org/show_bug.cgi?id=191701
339         <rdar://problem/46104809>
340
341         Reviewed by Myles C. Maxfield.
342
343         Update to use the old font handling routines moved from WKSI to FontCascade.
344
345         * WebPreferences.cpp:
346         (WebPreferences::setFontSmoothing):
347         (WebPreferences::setFontSmoothingContrast):
348         * WebView.cpp:
349         (systemParameterChanged):
350
351 2018-11-14  Timothy Hatcher  <timothy@apple.com>
352
353         Default the view background color and text color to different values when in dark mode.
354         https://bugs.webkit.org/show_bug.cgi?id=191607
355         rdar://problem/46045854
356
357         Reviewed by Dean Jackson.
358
359         * WebFrame.cpp:
360         (WebFrame::updateBackground): Drop backgroundColor.
361         * WebCoreSupport/WebFrameLoaderClient.cpp:
362         (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor.
363
364 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
365
366         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
367         https://bugs.webkit.org/show_bug.cgi?id=191612
368
369         Reviewed by Matt Baker.
370
371         * WebCoreSupport/WebInspectorClient.cpp:
372         (WebInspectorFrontendClient::destroyInspectorView):
373
374 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
375
376         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
377         https://bugs.webkit.org/show_bug.cgi?id=189230
378         <rdar://problem/44050379>
379
380         Reviewed by Joseph Pecoraro.
381
382         Runs all png images through zopflipng. This results in a smaller file
383         size and takes care of this issue as a byproduct.
384
385         * WebKit.resources/deleteButton.png:
386         * WebKit.resources/deleteButtonPressed.png:
387         * WebKit.resources/fsVideoAudioVolumeHigh.png:
388         * WebKit.resources/fsVideoAudioVolumeLow.png:
389         * WebKit.resources/fsVideoExitFullscreen.png:
390         * WebKit.resources/fsVideoPause.png:
391         * WebKit.resources/fsVideoPlay.png:
392         * WebKit.resources/missingImage.png:
393         * WebKit.resources/nullplugin.png:
394         * WebKit.resources/panEastCursor.png:
395         * WebKit.resources/panIcon.png:
396         * WebKit.resources/panNorthCursor.png:
397         * WebKit.resources/panNorthEastCursor.png:
398         * WebKit.resources/panNorthWestCursor.png:
399         * WebKit.resources/panSouthCursor.png:
400         * WebKit.resources/panSouthEastCursor.png:
401         * WebKit.resources/panSouthWestCursor.png:
402         * WebKit.resources/panWestCursor.png:
403         * WebKit.resources/searchCancel.png:
404         * WebKit.resources/searchCancelPressed.png:
405         * WebKit.resources/searchMagnifier.png:
406         * WebKit.resources/searchMagnifierResults.png:
407         * WebKit.resources/textAreaResizeCorner.png:
408         * WebKit.resources/verticalTextCursor.png:
409         * WebKit.resources/zoomInCursor.png:
410         * WebKit.resources/zoomOutCursor.png:
411
412 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
413
414         Unreviewed Windows build fix for r238049.
415
416         * WebView.cpp:
417         (WebView::initWithFrame):
418
419 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
420
421         Unreviewed MSVC build fix after r238039 (and r238046).
422
423         * WebDocumentLoader.h:
424         * WebView.cpp:
425         (WebView::setShouldApplyMacFontAscentHack):
426
427 2018-11-09  Antti Koivisto  <antti@apple.com>
428
429         Use OptionSet for layout milestones
430         https://bugs.webkit.org/show_bug.cgi?id=191470
431
432         Reviewed by Dean Jackson.
433
434         * WebCoreSupport/WebFrameLoaderClient.cpp:
435         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
436         * WebCoreSupport/WebFrameLoaderClient.h:
437
438 2018-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
439
440         WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
441         https://bugs.webkit.org/show_bug.cgi?id=191455
442
443         Reviewed by Brent Fulgham.
444
445         * WebHistory.h: Marked with 'override' and removed 'virtual'.
446
447 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
448
449         Add a storage limit for IndexedDB
450         https://bugs.webkit.org/show_bug.cgi?id=190598
451         <rdar://problem/44654715>
452
453         Reviewed by Chris Dumez.
454
455         * Interfaces/IWebDatabaseManager.idl:
456         * WebDatabaseManager.cpp:
457         (WebDatabaseManager::setIDBPerOriginQuota):
458         * WebDatabaseManager.h:
459
460 2018-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
461
462         [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
463         https://bugs.webkit.org/show_bug.cgi?id=191105
464
465         Reviewed by Brent Fulgham.
466
467         * DOMHTMLClasses.h:
468         (DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
469         instead of own setNodeValue.
470
471 2018-10-25  Antoine Quint  <graouts@apple.com>
472
473         [Web Animations] Turn Web Animations CSS Integration off by default
474         https://bugs.webkit.org/show_bug.cgi?id=190901
475
476         Reviewed by Dean Jackson.
477
478         * WebPreferences.cpp:
479         (WebPreferences::initializeDefaultSettings):
480
481 2018-10-21  Fujii Hironori  <Hironori.Fujii@sony.com>
482
483         [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
484         https://bugs.webkit.org/show_bug.cgi?id=190744
485
486         Reviewed by Alex Christensen.
487
488         clang-cl reports compilation warnings for inconsistent 'override'
489         keyword usage.
490
491         WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
492         This can't be marked 'override' if !USE(CA).
493
494         * WebView.cpp:
495         (WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).
496         * WebView.h: Marked all overriding member function declarations of WebView 'override'.
497         Declare flushPendingGraphicsLayerChanges only if USE(CA).
498
499 2018-10-18  Alex Christensen  <achristensen@webkit.org>
500
501         Clean up FrameLoader two-state enums
502         https://bugs.webkit.org/show_bug.cgi?id=190731
503
504         Reviewed by Chris Dumez.
505
506         * WebCoreSupport/WebFrameLoaderClient.cpp:
507         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
508         * WebCoreSupport/WebFrameLoaderClient.h:
509
510 2018-10-17  Alex Christensen  <achristensen@webkit.org>
511
512         BackForwardClient needs to be able to support UIProcess-only back/forward lists
513         https://bugs.webkit.org/show_bug.cgi?id=190675
514
515         Reviewed by Chris Dumez.
516
517         * BackForwardList.cpp:
518         (BackForwardList::backItem):
519         (BackForwardList::currentItem):
520         (BackForwardList::forwardItem):
521         (BackForwardList::backListCount const):
522         (BackForwardList::forwardListCount const):
523         (BackForwardList::itemAtIndex):
524         * BackForwardList.h:
525
526 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
527
528         Unreviewed attempt to fix the Windows build after r237112.
529
530         * Plugins/PluginView.cpp:
531         (WebCore::PluginView::performRequest):
532
533 2018-10-16  Alex Christensen  <achristensen@webkit.org>
534
535         Replace HistoryItem* with HistoryItem& where possible
536         https://bugs.webkit.org/show_bug.cgi?id=190617
537
538         Reviewed by Chris Dumez.
539
540         * BackForwardList.cpp:
541         (BackForwardList::goToItem):
542         * BackForwardList.h:
543         * WebBackForwardList.cpp:
544         (WebBackForwardList::goToItem):
545
546 2018-10-15  Alex Christensen  <achristensen@webkit.org>
547
548         Fix Windows build.
549
550         * WebView.cpp:
551         (WebView::loadBackForwardListFromOtherView):
552
553 2018-10-15  Alex Christensen  <achristensen@webkit.org>
554
555         Fix WinCairo build.
556
557         * WebView.cpp:
558         (WebView::backForwardList):
559
560 2018-10-15  Alex Christensen  <achristensen@webkit.org>
561
562         Modernize BackForwardClient.h
563         https://bugs.webkit.org/show_bug.cgi?id=190610
564
565         Reviewed by Chris Dumez.
566
567         * BackForwardList.cpp:
568         (BackForwardList::backListCount const):
569         (BackForwardList::forwardListCount const):
570         (BackForwardList::backListCount): Deleted.
571         (BackForwardList::forwardListCount): Deleted.
572         * BackForwardList.h:
573         * WebView.cpp:
574         (WebView::initWithFrame):
575         (WebView::backForwardList):
576
577 2018-10-15  Alex Christensen  <achristensen@webkit.org>
578
579         Remove unused WebView._globalHistoryItem
580         https://bugs.webkit.org/show_bug.cgi?id=190601
581
582         Reviewed by Chris Dumez.
583
584         * WebCoreSupport/WebFrameLoaderClient.cpp:
585         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
586         * WebCoreSupport/WebFrameLoaderClient.h:
587         * WebView.cpp:
588         (WebView::globalHistoryItem):
589         (WebView::setGlobalHistoryItem): Deleted.
590         * WebView.h:
591
592 2018-10-15  Alex Christensen  <achristensen@webkit.org>
593
594         Remove unused parameters from FrameLoaderClient::createFrame
595         https://bugs.webkit.org/show_bug.cgi?id=190587
596
597         Reviewed by Chris Dumez.
598
599         * WebCoreSupport/WebFrameLoaderClient.cpp:
600         (WebFrameLoaderClient::createFrame):
601         * WebCoreSupport/WebFrameLoaderClient.h:
602
603 2018-10-15  Chris Dumez  <cdumez@apple.com>
604
605         Unreviewed Windows build fix after r237112.
606
607         * Plugins/PluginView.cpp:
608         (WebCore::PluginView::performRequest):
609         (WebCore::PluginView::load):
610
611 2018-10-15  Alex Christensen  <achristensen@webkit.org>
612
613         Remove InjectedBundle processing of back/forward lists
614         https://bugs.webkit.org/show_bug.cgi?id=190459
615
616         Reviewed by Chris Dumez.
617
618         * WebCoreSupport/WebFrameLoaderClient.cpp:
619         (WebFrameLoaderClient::shouldGoToHistoryItem const):
620         * WebCoreSupport/WebFrameLoaderClient.h:
621
622 2018-10-02  Alex Christensen  <achristensen@webkit.org>
623
624         Remove ParsedURLString
625         https://bugs.webkit.org/show_bug.cgi?id=190154
626
627         Reviewed by Chris Dumez.
628
629         * WebDownloadCurl.cpp:
630         (WebDownload::initWithRequest):
631         * WebURLResponse.cpp:
632         (WebURLResponse::createInstance):
633
634 2018-09-28  Chris Dumez  <cdumez@apple.com>
635
636         Drop support for cross-origin-window-policy header
637         https://bugs.webkit.org/show_bug.cgi?id=190081
638
639         Reviewed by Ryosuke Niwa.
640
641         * WebPreferenceKeysPrivate.h:
642         * WebPreferences.cpp:
643         (WebPreferences::initializeDefaultSettings):
644         (WebPreferences::crossOriginWindowPolicySupportEnabled):
645         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
646         * WebView.cpp:
647         (WebView::notifyPreferencesChanged):
648
649 2018-09-27  Antoine Quint  <graouts@apple.com>
650
651         [Web Animations] Turn Web Animations with CSS integration on
652         https://bugs.webkit.org/show_bug.cgi?id=184819
653         <rdar://problem/39597337>
654
655         Reviewed by Dean Jackson.
656
657         * WebPreferences.cpp:
658         (WebPreferences::initializeDefaultSettings):
659
660 2018-09-21  Alex Christensen  <achristensen@webkit.org>
661
662         Use a Variant for FormDataElement
663         https://bugs.webkit.org/show_bug.cgi?id=189777
664
665         Reviewed by Chris Dumez.
666
667         * WebMutableURLRequest.cpp:
668         (WebMutableURLRequest::setHTTPBody):
669
670 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
671
672         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
673         https://bugs.webkit.org/show_bug.cgi?id=189612
674
675         Reviewed by Alex Christensen.
676
677         Non-trivial types can't be used as aruguments of LOG_ERROR and
678         ASSERT_WITH_MESSAGE.
679
680         * DefaultPolicyDelegate.cpp:
681         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
682         static_cast<BSTR> to convert BString.
683         * WebLocalizableStrings.cpp:
684         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
685         char* by using 'key.utf8().data()'.
686
687 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
688
689         Unreviewed, rolling out r235953.
690
691         Caused layout test crashes under GuardMalloc.
692
693         Reverted changeset:
694
695         "Make GraphicsLayers ref-counted, so their tree can persist
696         when disconnected from RenderLayerBackings"
697         https://bugs.webkit.org/show_bug.cgi?id=189521
698         https://trac.webkit.org/changeset/235953
699
700 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
701
702         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
703         https://bugs.webkit.org/show_bug.cgi?id=189538
704
705         Reviewed by Per Arne Vollan.
706
707         * WebPreferences.cpp:
708         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
709         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
710         Apply static_cast to the result of OR-ed CFPropertyListFormat.
711         (WebPreferences::screenFontSubstitutionEnabled):
712         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
713
714 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
715
716         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
717         https://bugs.webkit.org/show_bug.cgi?id=189539
718
719         Reviewed by Alex Christensen.
720
721         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
722         * WebCoreSupport/WebInspectorClient.cpp:
723         (WebInspectorWndProc): Ditto.
724         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
725         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
726
727 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
728
729         Refactor WebCore::EditAction to be an 8-bit enum class
730         https://bugs.webkit.org/show_bug.cgi?id=189383
731
732         Reviewed by Dan Bernstein.
733
734         * WebCoreSupport/WebEditorClient.cpp:
735         (undoNameForEditAction):
736
737 2018-09-04  Frederic Wang  <fwang@igalia.com>
738
739         Add basic support for ScrollIntoViewOptions
740         https://bugs.webkit.org/show_bug.cgi?id=189258
741
742         Reviewed by Simon Fraser.
743
744         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
745         can build despite the new scrollIntoView function.
746
747 2018-08-31  Chris Dumez  <cdumez@apple.com>
748
749         Unreviewed Windows build fix after r235562.
750
751         * WebCoreSupport/WebFrameLoaderClient.cpp:
752         (WebFrameLoaderClient::dispatchWillSubmitForm):
753
754 2018-08-31  Chris Dumez  <cdumez@apple.com>
755
756         Assertion hit in ~CompletionHandler() from ~WebFrame()
757         https://bugs.webkit.org/show_bug.cgi?id=189199
758         <rdar://problem/42657233>
759
760         Reviewed by Youenn Fablet.
761
762         * WebCoreSupport/WebFrameLoaderClient.cpp:
763         (WebFrameLoaderClient::dispatchWillSubmitForm):
764         * WebCoreSupport/WebFrameLoaderClient.h:
765
766 2018-08-31  Frederic Wang  <fwang@igalia.com>
767
768         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
769         https://bugs.webkit.org/show_bug.cgi?id=182053
770
771         Reviewed by Simon Fraser.
772
773         Add developer flag to use standard behavior for scrolling* attributes.
774
775         * Interfaces/IWebPreferencesPrivate.idl:
776         * WebPreferenceKeysPrivate.h:
777         * WebPreferences.cpp:
778         (WebPreferences::initializeDefaultSettings):
779         (WebPreferences::CSSOMViewScrollingAPIEnabled):
780         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
781         * WebPreferences.h:
782         * WebView.cpp:
783         (WebView::notifyPreferencesChanged):
784
785 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
786
787         [CMake] Replace AVFoundationSupport.py using CMake
788         https://bugs.webkit.org/show_bug.cgi?id=182891
789
790         Reviewed by Per Arne Vollan.
791
792         Remove references to the config.h contained in WebCore as it should
793         not be accessible from outside of WebCore.
794
795         * WebKitPrefix.h:
796
797 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
798
799         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
800         https://bugs.webkit.org/show_bug.cgi?id=188496
801         <rdar://problem/43216836>
802
803         Reviewed by Tim Horton.
804
805         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
806         header directly.
807
808         * WebCoreSupport/WebDragClient.cpp:
809
810 2018-08-17  Alex Christensen  <achristensen@webkit.org>
811
812         Add some plumbing for safe browsing
813         https://bugs.webkit.org/show_bug.cgi?id=188709
814
815         Reviewed by Tim Horton.
816
817         * WebCoreSupport/WebFrameLoaderClient.cpp:
818         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
819         * WebCoreSupport/WebFrameLoaderClient.h:
820
821 2018-08-02  David Fenton  <david_fenton@apple.com>
822
823         Unreviewed, rolling out r234489.
824
825         Caused 50+ crashes and 60+ API failures on iOS
826
827         Reverted changeset:
828
829         "[WTF] Rename String::format to String::deprecatedFormat"
830         https://bugs.webkit.org/show_bug.cgi?id=188191
831         https://trac.webkit.org/changeset/234489
832
833 2018-08-01  Tomas Popela  <tpopela@redhat.com>
834
835         [WTF] Rename String::format to String::deprecatedFormat
836         https://bugs.webkit.org/show_bug.cgi?id=188191
837
838         Reviewed by Darin Adler.
839
840         It should be replaced with string concatenation.
841
842         * FullscreenVideoController.cpp:
843         (timeToString):
844         * WebView.cpp:
845         (webKitVersionString):
846
847 2018-07-30  Rob Buis  <rbuis@igalia.com>
848
849         https://bugs.webkit.org/show_bug.cgi?id=188137
850         Merge PlatformCookieJar functions into NetworkStorageSession
851
852         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
853
854         Reviewed by Alex Christensen.
855
856         * WebCoreSupport/WebPlatformStrategies.cpp:
857         (WebPlatformStrategies::cookiesForDOM):
858         (WebPlatformStrategies::setCookiesFromDOM):
859         (WebPlatformStrategies::cookiesEnabled):
860         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
861         (WebPlatformStrategies::getRawCookies):
862         (WebPlatformStrategies::deleteCookie):
863         * WebPreferences.cpp:
864         (WebPreferences::clearNetworkLoaderSession):
865
866 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
867
868         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
869         https://bugs.webkit.org/show_bug.cgi?id=187963
870
871         Reviewed by Alex Christensen.
872
873         * Plugins/PluginPackageWin.cpp:
874         (WebCore::PluginPackage::fetchInfo):
875         Update split/splitAllowingEmptyEntries usage.
876
877 2018-07-18  Antoine Quint  <graouts@apple.com>
878
879         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
880         https://bugs.webkit.org/show_bug.cgi?id=187722
881
882         Reviewed by Myles Maxfield.
883
884         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
885
886         * DOMCoreClasses.cpp:
887         (DOMElement::font):
888
889 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
890
891         Disable cross-origin-window-policy by default
892         https://bugs.webkit.org/show_bug.cgi?id=187509
893
894         Reviewed by Chris Dumez.
895
896         * WebPreferences.cpp:
897         (WebPreferences::initializeDefaultSettings):
898
899 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
900
901         [WTF] Add user-defined literal for ASCIILiteral
902         https://bugs.webkit.org/show_bug.cgi?id=186839
903
904         Reviewed by Darin Adler.
905
906         * Plugins/PluginStream.cpp:
907         (WebCore::PluginStream::startStream):
908         * WebCoreSupport/WebContextMenuClient.cpp:
909         (WebContextMenuClient::searchWithGoogle):
910
911 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
912
913         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
914         https://bugs.webkit.org/show_bug.cgi?id=186623
915
916         Reviewed by Youenn Fablet.
917
918         * WebCoreSupport/WebPluginInfoProvider.cpp:
919         (WebPluginInfoProvider::pluginInfo):
920         (WebPluginInfoProvider::webVisiblePluginInfo):
921         * WebCoreSupport/WebPluginInfoProvider.h:
922
923 2018-06-13  Chris Dumez  <cdumez@apple.com>
924
925         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
926         https://bugs.webkit.org/show_bug.cgi?id=186545
927
928         Reviewed by Brady Eidson.
929
930         Update client delegate now that parameter type has changed.
931
932         * WebCoreSupport/WebFrameLoaderClient.cpp:
933         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
934         * WebCoreSupport/WebFrameLoaderClient.h:
935
936 2018-06-11  Chris Dumez  <cdumez@apple.com>
937
938         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
939         https://bugs.webkit.org/show_bug.cgi?id=186441
940
941         Reviewed by Brady Eidson.
942
943         Rename existing flag to something a bit more generic, now that it is used for
944         more things than bypassing the navigation policy check.
945
946         * WebView.cpp:
947         (WebView::goToBackForwardItem):
948         (WebView::loadBackForwardListFromOtherView):
949
950 2018-06-04  Chris Dumez  <cdumez@apple.com>
951
952         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
953         https://bugs.webkit.org/show_bug.cgi?id=186287
954         <rdar://problem/40783352>
955
956         Reviewed by Youenn Fablet.
957
958         * Interfaces/IWebPreferencesPrivate.idl:
959         * WebPreferenceKeysPrivate.h:
960         * WebPreferences.cpp:
961         (WebPreferences::initializeDefaultSettings):
962         (WebPreferences::crossOriginWindowPolicySupportEnabled):
963         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
964         * WebPreferences.h:
965         * WebView.cpp:
966         (WebView::notifyPreferencesChanged):
967
968 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
969
970         [JSC] Pass VM& parameter as much as possible
971         https://bugs.webkit.org/show_bug.cgi?id=186085
972
973         Reviewed by Saam Barati.
974
975         * Plugins/PluginPackage.cpp:
976         (WebCore::NPN_Invoke):
977
978 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
979
980         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
981         https://bugs.webkit.org/show_bug.cgi?id=186125
982
983         Unreviewed build fix
984
985         * WebActionPropertyBag.cpp:
986         (WebActionPropertyBag::Read):
987         (findMouseEvent): Deleted.
988
989 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
990
991         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
992         https://bugs.webkit.org/show_bug.cgi?id=186027
993
994         Unreviewed build fix
995
996         * WebMutableURLRequest.cpp:
997         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
998         (WebMutableURLRequest::setClientCertificate):
999
1000 2018-05-25  Chris Dumez  <cdumez@apple.com>
1001
1002         Minor ApplicationCacheStorage clean up
1003         https://bugs.webkit.org/show_bug.cgi?id=185984
1004
1005         Reviewed by Youenn Fablet.
1006
1007         * WebApplicationCache.cpp:
1008         (WebApplicationCache::originsWithCache):
1009
1010 2018-05-24  Chris Dumez  <cdumez@apple.com>
1011
1012         Reduce copying of FontCascadeDescription objects by moving them around
1013         https://bugs.webkit.org/show_bug.cgi?id=185963
1014
1015         Reviewed by Simon Fraser.
1016
1017         Reduce copying of FontCascadeDescription objects by moving them around when possible.
1018
1019         * FullscreenVideoController.cpp:
1020         (FullscreenVideoController::draw):
1021
1022 2018-05-15  Antoine Quint  <graouts@apple.com>
1023
1024         [Web Animations] Expose Web Animations CSS integration as an experimental feature
1025         https://bugs.webkit.org/show_bug.cgi?id=185647
1026
1027         Reviewed by Dean Jackson.
1028
1029         Rename the Web Animations CSS integration flag.
1030
1031         * Interfaces/IWebPreferencesPrivate.idl:
1032         * WebPreferenceKeysPrivate.h:
1033         * WebPreferences.cpp:
1034         (WebPreferences::initializeDefaultSettings):
1035         (WebPreferences::webAnimationsCSSIntegrationEnabled):
1036         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
1037         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1038         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1039         * WebPreferences.h:
1040         * WebView.cpp:
1041         (WebView::notifyPreferencesChanged):
1042
1043 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1044
1045         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
1046         https://bugs.webkit.org/show_bug.cgi?id=185505
1047
1048         Unreviewed serious crash fix
1049
1050         Windows port crashes soon since Bug 184996.
1051
1052         * WebPreferences.cpp:
1053         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
1054         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
1055
1056 2018-05-07  Daniel Bates  <dabates@apple.com>
1057
1058         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
1059         https://bugs.webkit.org/show_bug.cgi?id=185170
1060
1061         Reviewed by Per Arne Vollan.
1062
1063         * WebCache.cpp:
1064         (WebCache::empty):
1065
1066 2018-04-27  Chris Dumez  <cdumez@apple.com>
1067
1068         Use WindowProxy instead of DOMWindow in our IDL
1069         https://bugs.webkit.org/show_bug.cgi?id=185022
1070
1071         Reviewed by Sam Weinig.
1072
1073         * DOMCoreClasses.cpp:
1074         (DOMDocument::getComputedStyle):
1075
1076 2018-04-23  Daniel Bates  <dabates@apple.com>
1077
1078         Implement Same-Site cookies
1079         https://bugs.webkit.org/show_bug.cgi?id=159464
1080         <rdar://problem/27196358>
1081
1082         Reviewed by Brent Fulgham.
1083
1084         Pass the Same-Site info through the strategy.
1085
1086         * WebCoreSupport/WebPlatformStrategies.cpp:
1087         (WebPlatformStrategies::cookiesForDOM):
1088         (WebPlatformStrategies::setCookiesFromDOM):
1089         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1090         (WebPlatformStrategies::getRawCookies):
1091         * WebCoreSupport/WebPlatformStrategies.h:
1092
1093 2018-04-23  Daniel Bates  <dabates@apple.com>
1094
1095         Implement Same-Site cookies
1096         https://bugs.webkit.org/show_bug.cgi?id=159464
1097         <rdar://problem/27196358>
1098
1099         Reviewed by Brent Fulgham.
1100
1101         Pass the Same-Site info through the strategy.
1102
1103         * WebCoreSupport/WebPlatformStrategies.cpp:
1104         (WebPlatformStrategies::cookiesForDOM):
1105         (WebPlatformStrategies::setCookiesFromDOM):
1106         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1107         (WebPlatformStrategies::getRawCookies):
1108         * WebCoreSupport/WebPlatformStrategies.h:
1109
1110 2018-04-20  Youenn Fablet  <youenn@apple.com>
1111
1112         Make PluginData cache its web visible plugins
1113         https://bugs.webkit.org/show_bug.cgi?id=184421
1114
1115         Reviewed by Chris Dumez.
1116
1117         * WebCoreSupport/WebPluginInfoProvider.cpp:
1118         (WebPluginInfoProvider::pluginInfo):
1119         (WebPluginInfoProvider::webVisiblePluginInfo):
1120         * WebCoreSupport/WebPluginInfoProvider.h:
1121
1122 2018-04-19  Chris Dumez  <cdumez@apple.com>
1123
1124         Rename JSDOMWindowProxy to JSWindowProxy
1125         https://bugs.webkit.org/show_bug.cgi?id=184797
1126
1127         Reviewed by Sam Weinig.
1128
1129         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
1130
1131         * WebFrame.cpp:
1132         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
1133
1134 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
1135
1136         Unreviewed rollout of r230632. Regression in memory usage.
1137
1138         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
1139
1140         * WebPreferences.cpp:
1141         (WebPreferences::initializeDefaultSettings):
1142
1143 2018-04-17  Chris Dumez  <cdumez@apple.com>
1144
1145         Unreviewed attempt to fix the Windows build after r230721
1146
1147         * WebCoreSupport/WebFrameLoaderClient.cpp:
1148         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1149
1150 2018-04-17  Chris Dumez  <cdumez@apple.com>
1151
1152         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
1153         https://bugs.webkit.org/show_bug.cgi?id=184678
1154         <rdar://problem/39422122>
1155
1156         Reviewed by Alex Christensen.
1157
1158         Add new parameter to dispatchDecidePolicyForNavigationAction.
1159
1160         * WebCoreSupport/WebFrameLoaderClient.cpp:
1161         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1162         * WebCoreSupport/WebFrameLoaderClient.h:
1163
1164 2018-04-12  Antoine Quint  <graouts@apple.com>
1165
1166         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
1167         https://bugs.webkit.org/show_bug.cgi?id=184569
1168         <rdar://problem/38671301>
1169
1170         Reviewed by Jon Lee.
1171
1172         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
1173
1174         * WebPreferences.cpp:
1175
1176 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1177
1178         [WTF] Remove StaticLock
1179         https://bugs.webkit.org/show_bug.cgi?id=184332
1180
1181         Reviewed by Mark Lam.
1182
1183         * WebKitQuartzCoreAdditions/CAView.cpp:
1184         (WKQCA::CAView::releaseAllD3DResources):
1185         * WebLocalizableStrings.cpp:
1186
1187 2018-04-03  Chris Dumez  <cdumez@apple.com>
1188
1189         Drop MainFrame class
1190         https://bugs.webkit.org/show_bug.cgi?id=184191
1191
1192         Reviewed by Darin Adler.
1193
1194         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
1195         relationship between the Page and the MainFrame.
1196
1197         This is ground work for introducing LocalFrame / RemoteFrame concepts.
1198
1199         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1200         * WebCoreSupport/WebContextMenuClient.cpp:
1201         * WebCoreSupport/WebDragClient.cpp:
1202         * WebDropSource.cpp:
1203         * WebFrame.cpp:
1204         * WebView.cpp:
1205
1206 2018-03-26  Chris Dumez  <cdumez@apple.com>
1207
1208         Use SecurityOriginData more consistently in Service Worker code
1209         https://bugs.webkit.org/show_bug.cgi?id=183969
1210
1211         Reviewed by Darin Adler.
1212
1213         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
1214
1215         * WebDatabaseManager.cpp:
1216         (WebDatabaseManager::databasesWithOrigin):
1217         (WebDatabaseManager::deleteOrigin):
1218         (WebDatabaseManager::deleteDatabase):
1219         (WebDatabaseManager::setQuota):
1220         * WebSecurityOrigin.cpp:
1221         (WebSecurityOrigin::usage):
1222         (WebSecurityOrigin::quota):
1223         (WebSecurityOrigin::setQuota):
1224
1225 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
1226
1227         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
1228         https://bugs.webkit.org/show_bug.cgi?id=183911
1229         <rdar://problem/38762306>
1230
1231         Reviewed by Youenn Fablet.
1232
1233         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
1234
1235         * WebView.cpp:
1236         (WebView::WebView):
1237
1238 2018-03-25  Commit Queue  <commit-queue@webkit.org>
1239
1240         Unreviewed, rolling out r229954.
1241         https://bugs.webkit.org/show_bug.cgi?id=184000
1242
1243         Caused many layout tests to crash on Apple High Sierra,
1244         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
1245         by dydz on #webkit).
1246
1247         Reverted changeset:
1248
1249         "Use SecurityOriginData more consistently in Service Worker
1250         code"
1251         https://bugs.webkit.org/show_bug.cgi?id=183969
1252         https://trac.webkit.org/changeset/229954
1253
1254 2018-03-24  Chris Dumez  <cdumez@apple.com>
1255
1256         Use SecurityOriginData more consistently in Service Worker code
1257         https://bugs.webkit.org/show_bug.cgi?id=183969
1258
1259         Reviewed by Darin Adler.
1260
1261         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
1262
1263         * WebDatabaseManager.cpp:
1264         (WebDatabaseManager::databasesWithOrigin):
1265         (WebDatabaseManager::deleteOrigin):
1266         (WebDatabaseManager::deleteDatabase):
1267         (WebDatabaseManager::setQuota):
1268         * WebSecurityOrigin.cpp:
1269         (WebSecurityOrigin::usage):
1270         (WebSecurityOrigin::quota):
1271         (WebSecurityOrigin::setQuota):
1272
1273 2018-03-23  Chris Dumez  <cdumez@apple.com>
1274
1275         Unreviewed attempt to fix Windows build after r229926.
1276
1277         * WebView.cpp:
1278
1279 2018-03-23  Brady Eidson  <beidson@apple.com>
1280
1281         Go to back/forward list items after a process-swapped navigation.
1282         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
1283
1284         Reviewed by Andy Estes.
1285
1286         * WebView.cpp:
1287         (WebView::goToBackForwardItem):
1288         (WebView::loadBackForwardListFromOtherView):
1289
1290 2018-03-23  Miguel Gomez  <magomez@igalia.com>
1291
1292         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
1293         https://bugs.webkit.org/show_bug.cgi?id=183892
1294
1295         Remove the UpdateContentsFlag parameter as it's not used anymore.
1296
1297         Reviewed by Žan Doberšek.
1298
1299         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1300         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
1301
1302 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
1303
1304         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
1305         https://bugs.webkit.org/show_bug.cgi?id=183335
1306
1307         Reviewed by Alex Christensen.
1308
1309         * Plugins/PluginDatabaseWin.cpp:
1310         * Plugins/PluginMessageThrottlerWin.cpp:
1311         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
1312         * Plugins/PluginPackageWin.cpp:
1313         (WebCore::PluginPackage::load):
1314         * Plugins/PluginView.h:
1315         * Plugins/PluginViewWin.cpp:
1316         * Plugins/npapi.cpp:
1317         * WebCoreSupport/WebFrameLoaderClient.cpp:
1318         (WebFrameLoaderClient::createPlugin):
1319         (WebFrameLoaderClient::createJavaAppletWidget):
1320         * WebView.cpp:
1321         (WebView::WebViewWndProc):
1322
1323 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
1324
1325         [Win] Layout Test fast/html/menuitem-element.html is failing.
1326         https://bugs.webkit.org/show_bug.cgi?id=179299
1327
1328         Reviewed by Per Arne Vollan.
1329
1330         * Interfaces/IWebPreferencesPrivate.idl:
1331         * WebPreferenceKeysPrivate.h:
1332         * WebPreferences.cpp:
1333         (WebPreferences::menuItemElementEnabled):
1334         (WebPreferences::setMenuItemElementEnabled):
1335         * WebPreferences.h:
1336         * WebView.cpp:
1337         (WebView::notifyPreferencesChanged):
1338         Add private web preference "menuItemElementEnabled".
1339
1340 2018-03-12  Antoine Quint  <graouts@apple.com>
1341
1342         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
1343         https://bugs.webkit.org/show_bug.cgi?id=183504
1344         <rdar://problem/38372965>
1345
1346         Reviewed by Dean Jackson and Jon Lee.
1347
1348         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
1349         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
1350
1351         * Interfaces/IWebPreferencesPrivate.idl:
1352         * WebPreferences.cpp:
1353         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
1354         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
1355         * WebPreferenceKeysPrivate.h
1356         * WebPreferences.h:
1357         * WebView.cpp:
1358         (WebView::notifyPreferencesChanged):
1359
1360 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1361
1362         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
1363         https://bugs.webkit.org/show_bug.cgi?id=183429
1364
1365         Reviewed by Mark Lam.
1366
1367         * WebFrame.cpp:
1368         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
1369
1370 2018-03-08  Tim Horton  <timothy_horton@apple.com>
1371
1372         Stop linking ApplicationServices directly
1373         https://bugs.webkit.org/show_bug.cgi?id=182867
1374         <rdar://problem/38252142>
1375
1376         Reviewed by Alex Christensen.
1377
1378         The frameworks that we use that live inside ApplicationServices
1379         have mostly moved out, so import them directly.
1380
1381         * FullscreenVideoController.cpp:
1382
1383 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1384
1385         Fix std::make_unique / new[] using system malloc
1386         https://bugs.webkit.org/show_bug.cgi?id=182975
1387
1388         Reviewed by JF Bastien.
1389
1390         Use Vector instead.
1391
1392         * MarshallingHelpers.cpp:
1393         (MarshallingHelpers::safeArrayToStringArray):
1394         (MarshallingHelpers::safeArrayToIntArray):
1395         * Plugins/PluginPackageWin.cpp:
1396         (WebCore::PluginPackage::fetchInfo):
1397         * WebPreferences.cpp:
1398         (WebPreferences::copyWebKitPreferencesToCFPreferences):
1399         * WebView.cpp:
1400         (WebView::onMenuCommand):
1401
1402 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1403
1404         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
1405         https://bugs.webkit.org/show_bug.cgi?id=183312
1406
1407         Reviewed by Mark Lam.
1408
1409         Remove wtf/CurrentTime.h include pragma.
1410
1411         * WebDownload.cpp:
1412         * WebDownloadCFNet.cpp:
1413         * WebDropSource.cpp:
1414
1415 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1416
1417         Remove monotonicallyIncreasingTime
1418         https://bugs.webkit.org/show_bug.cgi?id=182911
1419
1420         Reviewed by Michael Catanzaro.
1421
1422         * FullscreenVideoController.cpp:
1423         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
1424         * Plugins/PluginMessageThrottlerWin.cpp:
1425         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
1426         (WebCore::PluginMessageThrottlerWin::appendMessage):
1427         * Plugins/PluginMessageThrottlerWin.h:
1428         * WebView.cpp:
1429         (WebView::notifyAnimationStarted):
1430         * WebView.h:
1431
1432 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
1433
1434         [Win][DRT] Implement setSpatialNavigationEnabled.
1435         https://bugs.webkit.org/show_bug.cgi?id=183166
1436
1437         Reviewed by Per Arne Vollan.
1438
1439         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
1440
1441         * Interfaces/IWebPreferencesPrivate.idl:
1442         * WebPreferenceKeysPrivate.h:
1443         * WebPreferences.cpp:
1444         (WebPreferences::initializeDefaultSettings):
1445         (WebPreferences::spatialNavigationEnabled):
1446         (WebPreferences::setSpatialNavigationEnabled):
1447         * WebPreferences.h:
1448         * WebView.cpp:
1449         (WebView::notifyPreferencesChanged):
1450
1451 2018-02-28  Alex Christensen  <achristensen@webkit.org>
1452
1453         Reduce use of NetworkingContext in WebKit
1454         https://bugs.webkit.org/show_bug.cgi?id=183213
1455
1456         Reviewed by Brady Eidson.
1457
1458         * Plugins/PluginView.cpp:
1459         (WebCore::PluginView::getValueForURL):
1460
1461 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
1462
1463         Fix WebCore includes within WebKitLegacy
1464         https://bugs.webkit.org/show_bug.cgi?id=183147
1465
1466         Reviewed by Tim Horton.
1467
1468         * Plugins/PluginDatabase.cpp:
1469         * Plugins/PluginDatabaseWin.cpp:
1470         * Plugins/PluginDebug.cpp:
1471         * Plugins/PluginDebug.h:
1472         * Plugins/PluginMainThreadScheduler.cpp:
1473         * Plugins/PluginMessageThrottlerWin.cpp:
1474         * Plugins/PluginMessageThrottlerWin.h:
1475         * Plugins/PluginPackage.cpp:
1476         * Plugins/PluginPackage.h:
1477         * Plugins/PluginPackageWin.cpp:
1478         * Plugins/PluginStream.cpp:
1479         * Plugins/PluginStream.h:
1480         * Plugins/PluginView.cpp:
1481         * Plugins/PluginView.h:
1482         * Plugins/PluginViewWin.cpp:
1483         * Plugins/npapi.cpp:
1484         * WebCoreSupport/WebChromeClient.cpp:
1485         * WebCoreSupport/WebContextMenuClient.cpp:
1486         * WebCoreSupport/WebFrameLoaderClient.cpp:
1487         * WebCoreSupport/WebInspectorClient.cpp:
1488         * WebCoreSupport/WebPlatformStrategies.cpp:
1489         * WebFrame.cpp:
1490         * WebKitMessageLoop.cpp:
1491         * WebView.cpp:
1492         * storage/WebDatabaseProvider.cpp:
1493
1494 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1495
1496         Remove currentTime() / currentTimeMS()
1497         https://bugs.webkit.org/show_bug.cgi?id=183052
1498
1499         Reviewed by Mark Lam.
1500
1501         * WebCoreSupport/WebFrameLoaderClient.cpp:
1502         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1503         * WebCoreSupport/WebFrameLoaderClient.h:
1504         * WebDownload.h:
1505         * WebDownloadCFNet.cpp:
1506         (WebDownload::didStart):
1507         (WebDownload::didReceiveData):
1508         (WebDownload::didFinish):
1509
1510 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
1511
1512         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
1513         https://bugs.webkit.org/show_bug.cgi?id=182883
1514
1515         Reviewed by Per Arne Vollan.
1516
1517         * WebKitPrefix.h:
1518
1519 2018-02-16  Dean Jackson  <dino@apple.com>
1520
1521         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
1522         https://bugs.webkit.org/show_bug.cgi?id=182894
1523
1524         Reviewed by Tim Horton.
1525
1526         Rename OPENGL_ES_2 to OPENGL_ES.
1527
1528         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1529
1530 2018-02-16  Youenn Fablet  <youenn@apple.com>
1531
1532         Allow specifying which plug-ins are supported
1533         https://bugs.webkit.org/show_bug.cgi?id=182748
1534
1535         Reviewed by Chris Dumez.
1536
1537         * WebCoreSupport/WebPluginInfoProvider.cpp:
1538         (WebPluginInfoProvider::getPluginInfo):
1539         * WebCoreSupport/WebPluginInfoProvider.h:
1540
1541 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
1542
1543         WebCore headers should not be included relatively within dependent projects
1544         https://bugs.webkit.org/show_bug.cgi?id=182805
1545
1546         Reviewed by Chris Dumez.
1547
1548         * FullscreenVideoController.h:
1549
1550 2018-02-13  Commit Queue  <commit-queue@webkit.org>
1551
1552         Unreviewed, rolling out r228431.
1553         https://bugs.webkit.org/show_bug.cgi?id=182766
1554
1555         Regressed CMake build stability (Requested by dolmstead on
1556         #webkit).
1557
1558         Reverted changeset:
1559
1560         "[CMake] Make WebCore headers copies"
1561         https://bugs.webkit.org/show_bug.cgi?id=182512
1562         https://trac.webkit.org/changeset/228431
1563
1564 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
1565
1566         [CMake] Make WebCore headers copies
1567         https://bugs.webkit.org/show_bug.cgi?id=182512
1568
1569         Reviewed by Keith Miller.
1570
1571         * FullscreenVideoController.h:
1572         * Plugins/PluginDatabase.cpp:
1573         * Plugins/PluginDatabaseWin.cpp:
1574         * Plugins/PluginDebug.cpp:
1575         * Plugins/PluginMainThreadScheduler.cpp:
1576         * Plugins/PluginMessageThrottlerWin.cpp:
1577         * Plugins/PluginPackage.cpp:
1578         * Plugins/PluginPackageWin.cpp:
1579         * Plugins/PluginStream.cpp:
1580         * Plugins/PluginView.cpp:
1581         * Plugins/PluginViewWin.cpp:
1582         * Plugins/npapi.cpp:
1583         * WebKitMessageLoop.cpp:
1584         * WebKitPrefix.h:
1585         * storage/WebDatabaseProvider.cpp:
1586
1587 2018-01-13  Darin Adler  <darin@apple.com>
1588
1589         Event improvements
1590         https://bugs.webkit.org/show_bug.cgi?id=179591
1591
1592         Reviewed by Chris Dumez.
1593
1594         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
1595         * WebFrame.cpp: Ditto.
1596
1597         * WebScriptWorld.cpp:
1598         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
1599
1600         * WebView.cpp: Removed include of ScriptValue.h.
1601         (WebView::handleEditingKeyboardEvent): Updated for name change from
1602         keyEvent to underlyingPlatformEvent.
1603
1604 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1605
1606         Remove WebCore/ForwardingHeaders directory
1607         https://bugs.webkit.org/show_bug.cgi?id=182347
1608
1609         Reviewed by Keith Miller.
1610
1611         * Plugins/PluginView.cpp:
1612         * Plugins/PluginViewWin.cpp:
1613         * WebCoreSupport/WebInspectorClient.cpp:
1614         * WebCoreSupport/WebInspectorClient.h:
1615         * WebFrame.cpp:
1616         * WebJavaScriptCollector.cpp:
1617         * WebView.cpp:
1618
1619 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1620
1621         Unreviewed, another attempt to fix the Windows build after r227479.
1622
1623         * WebFrame.cpp:
1624         (WebFrame::elementWithName):
1625
1626 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1627
1628         Unreviewed, try to fix the Windows build after r227479.
1629
1630         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
1631
1632         * WebFrame.cpp:
1633         (WebFrame::elementWithName):
1634         (WebFrame::controlsInForm):
1635
1636 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
1637
1638         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
1639         https://bugs.webkit.org/show_bug.cgi?id=181859
1640         <rdar://problem/36659886>
1641
1642         Reviewed by Alex Christensen.
1643         
1644         Use local include patch.
1645
1646         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
1647         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
1648         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
1649
1650 2018-01-17  Youenn Fablet  <youenn@apple.com>
1651
1652         Put fetch Request.keepalive behind a runtime flag
1653         https://bugs.webkit.org/show_bug.cgi?id=181592
1654
1655         Reviewed by Chris Dumez.
1656
1657         * WebPreferences.cpp:
1658         (WebPreferences::fetchAPIKeepAliveEnabled):
1659         (WebPreferences::setFetchAPIKeepAliveEnabled):
1660         * WebPreferences.h:
1661         * WebView.cpp:
1662         (WebView::notifyPreferencesChanged):
1663
1664 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1665
1666         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1667         https://bugs.webkit.org/show_bug.cgi?id=181637
1668         <rdar://problem/36508471>
1669
1670         Reviewed by Tim Horton.
1671
1672         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1673
1674         * WebCoreSupport/WebEditorClient.cpp:
1675         (WebEditorClient::replacementURLForResource):
1676         * WebCoreSupport/WebEditorClient.h:
1677
1678 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1679
1680         Remove std::chrono completely
1681         https://bugs.webkit.org/show_bug.cgi?id=181186
1682
1683         Reviewed by Alex Christensen.
1684
1685         * Plugins/PluginStream.cpp:
1686         (WebCore::lastModifiedDateMS):
1687
1688 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1689
1690         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
1691         https://bugs.webkit.org/show_bug.cgi?id=181173
1692
1693         Reviewed by Alex Christensen.
1694
1695         * WebNodeHighlight.cpp:
1696         (WebNodeHighlight::update): Scale the GraphicsContext.
1697
1698 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1699
1700         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
1701         https://bugs.webkit.org/show_bug.cgi?id=181160
1702
1703         Reviewed by Myles C. Maxfield.
1704
1705         * Plugins/PluginView.cpp:
1706         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
1707
1708 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1709
1710         Enable picture-in-picture from inline element on suspend.
1711         https://bugs.webkit.org/show_bug.cgi?id=180942
1712         rdar://problem/34745234
1713
1714         Reviewed by Jer Noble.
1715
1716         Update signature of enterVideoFullscreenForVideoElement.
1717
1718         * WebCoreSupport/WebChromeClient.cpp:
1719         (WebChromeClient::enterVideoFullscreenForVideoElement):
1720         * WebCoreSupport/WebChromeClient.h:
1721
1722 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1723
1724         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
1725         https://bugs.webkit.org/show_bug.cgi?id=180926
1726
1727         Reviewed by Tim Horton.
1728
1729         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
1730         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
1731
1732         * WebCoreSupport/WebFrameLoaderClient.cpp:
1733         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
1734         (WebFrameLoaderClient::pageID const): Ditto.
1735
1736 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1737
1738         Remove unnecessary boolean result of start() functions
1739         https://bugs.webkit.org/show_bug.cgi?id=180856
1740
1741         Reviewed by Darin Adler.
1742
1743         It always returns true.
1744
1745         * WebDownloadCurl.cpp:
1746         (WebDownload::start):
1747
1748 2017-12-14  John Wilander  <wilander@apple.com>
1749
1750         Storage Access API: Implement frame-specific access in the document.cookie layer
1751         https://bugs.webkit.org/show_bug.cgi?id=180682
1752         <rdar://problem/35982257>
1753
1754         Reviewed by Alex Christensen.
1755
1756         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1757         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1758         CookiesStrategy::getRawCookies() now take optional parameters for
1759         frameID and pageID to allow frame-specific scoping of cookies.
1760
1761         This change makes the return values of FrameLoaderClient::frameID()
1762         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1763         WebCore can call those getters and get the right return values in
1764         WebKit and std:nullopt in WebKitLegacy.
1765
1766         * WebCoreSupport/WebFrameLoaderClient.cpp:
1767         (WebFrameLoaderClient::pageID const):
1768         (WebFrameLoaderClient::frameID const):
1769             Now return an optional.
1770         * WebCoreSupport/WebFrameLoaderClient.h:
1771         * WebCoreSupport/WebPlatformStrategies.cpp:
1772         (WebPlatformStrategies::cookiesForDOM):
1773         (WebPlatformStrategies::setCookiesFromDOM):
1774         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1775         (WebPlatformStrategies::getRawCookies):
1776         * WebCoreSupport/WebPlatformStrategies.h:
1777
1778 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1779
1780         [WTF] Thread::create should have Thread::tryCreate
1781         https://bugs.webkit.org/show_bug.cgi?id=180333
1782
1783         Reviewed by Darin Adler.
1784
1785         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
1786         (WKQCA::CVDisplayLink::start):
1787
1788 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1789
1790         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
1791         https://bugs.webkit.org/show_bug.cgi?id=180572
1792
1793         Reviewed by Mark Lam.
1794
1795         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
1796         Also we use Lock instead of Mutex.
1797
1798         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
1799         (WKQCA::CAD3DRenderer::swapChain):
1800         (WKQCA::CAD3DRenderer::renderAndPresent):
1801         (WKQCA::CAD3DRenderer::renderToImage):
1802         (WKQCA::CAD3DRenderer::setDeviceIsLost):
1803         (WKQCA::CAD3DRenderer::renderInternal):
1804         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
1805         * WebKitQuartzCoreAdditions/CAView.cpp:
1806         (WKQCA::CAView::Handle::create):
1807         Return Ref<Handle> instead of RefPtr<>.
1808
1809         (WKQCA::CAView::Handle::lock):
1810         (WKQCA::CAView::Handle::view const):
1811         (WKQCA::CAView::Handle::clear):
1812         (WKQCA::views):
1813         (WKQCA::viewsNeedingUpdate):
1814         (WKQCA::CAView::releaseAllD3DResources):
1815         (WKQCA::CAView::CAView):
1816         (WKQCA::CAView::~CAView):
1817         (WKQCA::CAView::setLayer):
1818         (WKQCA::CAView::update):
1819         (WKQCA::CAView::drawToWindow):
1820         (WKQCA::CAView::drawToWindowInternal):
1821         (WKQCA::CAView::drawToImage):
1822         (WKQCA::CAView::willDraw):
1823         (WKQCA::CAView::drawIntoDC):
1824         (WKQCA::CAView::setShouldInvertColors):
1825         (WKQCA::CAView::scheduleNextDraw):
1826         (WKQCA::CAView::displayLinkReachedCAMediaTime):
1827         (WKQCA::CAView::contextDidChange):
1828         (WKQCA::CAView::updateSoon):
1829         (WKQCA::CAView::updateViewsNow):
1830         (WKQCA::CAView::d3dDevice9):
1831         (WKQCA::CAView::Handle::mutex): Deleted.
1832         (WKQCA::globalStateMutex): Deleted.
1833         (): Deleted.
1834         * WebKitQuartzCoreAdditions/CAView.h:
1835
1836 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1837
1838         Use StaticLock instead of NeverDestroyed<Lock>
1839         https://bugs.webkit.org/show_bug.cgi?id=180507
1840
1841         Reviewed by Saam Barati.
1842
1843         * WebLocalizableStrings.cpp:
1844         (findCachedString):
1845         (cacheString):
1846         (mainBundleLocStrings): Deleted.
1847         (frameworkLocStringsMutex): Deleted.
1848
1849 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
1850
1851         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
1852         https://bugs.webkit.org/show_bug.cgi?id=180431
1853         <rdar://problem/34531264>
1854
1855         Reviewed by Simon Fraser.
1856
1857         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
1858         'override' to make sure this doesn't break in the future.
1859
1860         * WebView.cpp:
1861         (WebView::notifyAnimationStarted):
1862         (WebView::paintContents):
1863         * WebView.h:
1864
1865 2017-11-23  Darin Adler  <darin@apple.com>
1866
1867         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1868         https://bugs.webkit.org/show_bug.cgi?id=179981
1869
1870         Reviewed by Sam Weinig.
1871
1872         * WebView.cpp:
1873         (WebView::searchFor): Use |= instead of | to build FindOptions.
1874         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
1875         (WebView::findString): Create FindOptions with |=; the old code just passed a
1876         WebKit FindOptions through without converting to WebCore::FindOptions.
1877
1878 2017-11-23  Darin Adler  <darin@apple.com>
1879
1880         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1881         https://bugs.webkit.org/show_bug.cgi?id=179907
1882
1883         Reviewed by Sam Weinig.
1884
1885         * Plugins/PluginDatabaseWin.cpp:
1886         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
1887         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
1888         * WebDownloadCFNet.cpp:
1889         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
1890
1891         * WebView.cpp:
1892         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
1893         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
1894         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
1895         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
1896         the code does not cause any change in behavior.
1897
1898 2017-11-22  Ali Juma  <ajuma@chromium.org>
1899
1900         Implement VisualViewport API attributes
1901         https://bugs.webkit.org/show_bug.cgi?id=179385
1902
1903         Reviewed by Frédéric Wang.
1904
1905         Add a VisualViewportAPI preference.
1906
1907         * Interfaces/IWebPreferencesPrivate.idl:
1908         * WebPreferenceKeysPrivate.h:
1909         * WebPreferences.cpp:
1910         (WebPreferences::initializeDefaultSettings):
1911         (WebPreferences::visualViewportAPIEnabled):
1912         (WebPreferences::setVisualViewportAPIEnabled):
1913         * WebPreferences.h:
1914         * WebView.cpp:
1915         (WebView::notifyPreferencesChanged):
1916
1917 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1918
1919         Unreviewed, rolling out r225093.
1920         https://bugs.webkit.org/show_bug.cgi?id=179938
1921
1922         Compilation failed on WinCairo 64-bit Release (Requested by
1923         fredw on #webkit).
1924
1925         Reverted changeset:
1926
1927         "Implement VisualViewport API attributes"
1928         https://bugs.webkit.org/show_bug.cgi?id=179385
1929         https://trac.webkit.org/changeset/225093
1930
1931 2017-11-21  Ali Juma  <ajuma@chromium.org>
1932
1933         Implement VisualViewport API attributes
1934         https://bugs.webkit.org/show_bug.cgi?id=179385
1935
1936         Reviewed by Frédéric Wang.
1937
1938         Add a VisualViewportAPI preference.
1939
1940         * Interfaces/IWebPreferencesPrivate.idl:
1941         * WebPreferenceKeysPrivate.h:
1942         * WebPreferences.cpp:
1943         (WebPreferences::initializeDefaultSettings):
1944         (WebPreferences::visualViewportAPIEnabled):
1945         (WebPreferences::setVisualViewportAPIEnabled):
1946         * WebPreferences.h:
1947         * WebView.cpp:
1948         (WebView::notifyPreferencesChanged):
1949
1950 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1951
1952         Clean up old URL parser remnants
1953         https://bugs.webkit.org/show_bug.cgi?id=179573
1954
1955         Reviewed by Darin Adler.
1956
1957         * WebCoreSupport/WebContextMenuClient.cpp:
1958         (WebContextMenuClient::searchWithGoogle):
1959         Use https if we do end up searching with google.
1960
1961 2017-11-12  Darin Adler  <darin@apple.com>
1962
1963         More is<> and downcast<>, less static_cast<>
1964         https://bugs.webkit.org/show_bug.cgi?id=179600
1965
1966         Reviewed by Chris Dumez.
1967
1968         * WebView.cpp:
1969         (WebView::handleEditingKeyboardEvent): Use downcast.
1970
1971 2017-11-09  Christopher Reid  <chris.reid@sony.com>
1972
1973         Use enum classes within FileSystem
1974         https://bugs.webkit.org/show_bug.cgi?id=175172
1975
1976         Reviewed by Darin Adler.
1977
1978         * Plugins/PluginDatabase.cpp:
1979
1980 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
1981
1982         [Win] Add WebKitQuartzCoreAdditions library.
1983         https://bugs.webkit.org/show_bug.cgi?id=179331
1984
1985         Reviewed by Alex Christensen.
1986
1987         * WebKitQuartzCoreAdditions: Added.
1988         * WebKitQuartzCoreAdditions/API: Added.
1989         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
1990         (toImage):
1991         (WKCACFImageGetWidth):
1992         (WKCACFImageGetHeight):
1993         (WKCACFImageCopyFileMapping):
1994         (WKCACFImageCreateWithImage):
1995         (WKCACFImageFinalize):
1996         (WKCACFImageCopyFormattingDescription):
1997         (WKCACFImageCopyDebugDescription):
1998         (WKCACFImageGetTypeID):
1999         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
2000         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
2001         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
2002         (toView):
2003         (toImpl):
2004         (WKCACFViewCreate):
2005         (WKCACFViewSetLayer):
2006         (WKCACFViewUpdate):
2007         (WKCACFViewFlushContext):
2008         (WKCACFViewInvalidateRects):
2009         (WKCACFViewCanDraw):
2010         (WKCACFViewDraw):
2011         (WKCACFViewCopyDrawnImage):
2012         (WKCACFViewDrawIntoDC):
2013         (contextDidChangeCallback):
2014         (WKCACFViewSetContextDidChangeCallback):
2015         (WKCACFViewGetLastCommitTime):
2016         (WKCACFViewSetContextUserData):
2017         (WKCACFViewGetContext):
2018         (WKCACFViewFinalize):
2019         (WKCACFViewCopyFormattingDescription):
2020         (WKCACFViewCopyDebugDescription):
2021         (WKCACFViewGetTypeID):
2022         (WKCACFViewSetShouldInvertColors):
2023         (WKCACFViewGetD3DDevice9):
2024         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
2025         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
2026         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
2027         (WKQCA::dllInstance):
2028         (DllMain):
2029         (WKCACFShutDown):
2030         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
2031         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
2032         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
2033         (WKQCA::d3d):
2034         (WKQCA::initialPresentationParameters):
2035         (WKQCA::CAD3DRenderer::shared):
2036         (WKQCA::CAD3DRenderer::CAD3DRenderer):
2037         (WKQCA::CAD3DRenderer::swapChain):
2038         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
2039         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
2040         (WKQCA::CAD3DRenderer::initialize):
2041         (WKQCA::D3DMatrixOrthoOffCenterRH):
2042         (WKQCA::prepareDevice):
2043         (WKQCA::updateBounds):
2044         (WKQCA::CAD3DRenderer::renderAndPresent):
2045         (WKQCA::CAD3DRenderer::renderToImage):
2046         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2047         (WKQCA::CAD3DRenderer::renderInternal):
2048         (WKQCA::CAD3DRenderer::postProcess):
2049         (WKQCA::CAD3DRenderer::resetD3DDevice):
2050         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
2051         (WKQCA::CAD3DRenderer::release):
2052         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
2053         (WKQCA::D3DPostProcessingContext::sceneTexture const):
2054         (WKQCA::D3DPostProcessingContext::overlayQuad const):
2055         (WKQCA::CAD3DRenderer::d3dDevice9 const):
2056         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
2057         (WKQCA::CAView::Handle::create):
2058         (WKQCA::CAView::Handle::~Handle):
2059         (WKQCA::CAView::Handle::mutex):
2060         (WKQCA::CAView::Handle::view const):
2061         (WKQCA::CAView::Handle::clear):
2062         (WKQCA::CAView::Handle::Handle):
2063         (WKQCA::globalStateMutex):
2064         (WKQCA::registerMessageWindowClass):
2065         (WKQCA::createMessageWindow):
2066         (WKQCA::CAView::releaseAllD3DResources):
2067         (WKQCA::CAView::CAView):
2068         (WKQCA::CAView::~CAView):
2069         (WKQCA::CAView::create):
2070         (WKQCA::CAView::setContextDidChangeCallback):
2071         (WKQCA::CAView::setLayer):
2072         (WKQCA::CAView::update):
2073         (WKQCA::CAView::invalidateRects):
2074         (WKQCA::CAView::drawToWindow):
2075         (WKQCA::CAView::drawToWindowInternal):
2076         (WKQCA::CAView::drawToImage):
2077         (WKQCA::CAView::willDraw):
2078         (WKQCA::CAView::didDraw):
2079         (WKQCA::CAView::drawIntoDC):
2080         (WKQCA::CAView::setShouldInvertColors):
2081         (WKQCA::CAView::scheduleNextDraw):
2082         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2083         (WKQCA::CAView::contextDidChangeCallback):
2084         (WKQCA::CAView::contextDidChange):
2085         (WKQCA::CAView::updateSoon):
2086         (WKQCA::CAView::updateViewsNow):
2087         (WKQCA::CAView::d3dDevice9):
2088         * WebKitQuartzCoreAdditions/CAView.h: Added.
2089         (WKQCA::CAView::context const):
2090         (WKQCA::CAView::canDraw const):
2091         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
2092         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
2093         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
2094         (WKQCA::CVDisplayLink::CVDisplayLink):
2095         (WKQCA::CVDisplayLink::~CVDisplayLink):
2096         (WKQCA::CVDisplayLink::create):
2097         (WKQCA::CVDisplayLink::start):
2098         (WKQCA::CVDisplayLink::stop):
2099         (WKQCA::CVDisplayLink::setPaused):
2100         (WKQCA::CVDisplayLink::runIOThread):
2101         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
2102         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
2103         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
2104         * WebKitQuartzCoreAdditions/Image.cpp: Added.
2105         (WKQCA::numBytesForSize):
2106         (WKQCA::Image::create):
2107         (WKQCA::Image::Image):
2108         (WKQCA::Image::~Image):
2109         (WKQCA::bitmapInfo):
2110         (WKQCA::Image::createDIB const):
2111         (WKQCA::Image::copyFileMapping):
2112         * WebKitQuartzCoreAdditions/Image.h: Added.
2113         (WKQCA::Image::size const):
2114         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
2115         (WKQCA::getBackBufferRectAsRenderTarget):
2116         (WKQCA::getSystemMemoryCopy):
2117         (WKQCA::copyRectToBitmap):
2118         (WKQCA::getImageCopy):
2119         (WKQCA::getBackBufferRectAsImage):
2120         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
2121         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
2122         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
2123         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
2124         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
2125
2126 2017-11-06  Christopher Reid  <chris.reid@sony.com>
2127
2128         Use enum classes within FileSystem
2129         https://bugs.webkit.org/show_bug.cgi?id=175172
2130
2131         Reviewed by Myles C. Maxfield.
2132
2133         * Plugins/PluginDatabase.cpp:
2134
2135 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
2136
2137         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
2138         https://bugs.webkit.org/show_bug.cgi?id=178333
2139
2140         Reviewed by Darin Adler.
2141
2142         * WebCoreSupport/WebFrameLoaderClient.cpp:
2143         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
2144
2145 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2146
2147         Use CompletionHandlers for redirects
2148         https://bugs.webkit.org/show_bug.cgi?id=179163
2149
2150         Reviewed by Tim Horton.
2151
2152         * Plugins/PluginStream.cpp:
2153         (WebCore::PluginStream::willSendRequest):
2154         * Plugins/PluginStream.h:
2155         (WebCore::PluginStreamClient::~PluginStreamClient):
2156         (WebCore::PluginStreamClient::streamDidFinishLoading):
2157         (WebCore::PluginStream::create):
2158         (WebCore::PluginStream::setLoadManually):
2159
2160 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2161
2162         Add a FileSystem namespace to FileSystem.cpp
2163         https://bugs.webkit.org/show_bug.cgi?id=179063
2164
2165         Reviewed by Darin Adler.
2166
2167         * Plugins/PluginDatabase.cpp:
2168         * Plugins/PluginPackage.cpp:
2169         * Plugins/PluginStream.cpp:
2170         * Plugins/PluginStream.h:
2171         * WebApplicationCache.cpp:
2172         * WebDatabaseManager.cpp:
2173         * WebDownloadCurl.cpp:
2174         * WebPreferences.cpp:
2175         * WebView.cpp:
2176
2177 2017-10-31  Alex Christensen  <achristensen@webkit.org>
2178
2179         Fix Windows build after r224260
2180
2181         * WebView.cpp:
2182         (WebView::gesture):
2183
2184 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2185
2186         [FrameView::layout cleanup] Move core layout logic to a separate class.
2187         https://bugs.webkit.org/show_bug.cgi?id=178771
2188         <rdar://problem/35166542>
2189
2190         Reviewed by Simon Fraser.
2191
2192         Move layout code out from FrameView to LayoutContext.
2193
2194         * WebFrame.cpp:
2195         (WebFrame::layout):
2196
2197 2017-10-26  Alex Christensen  <achristensen@webkit.org>
2198
2199         Fix Windows build
2200         https://bugs.webkit.org/show_bug.cgi?id=178892
2201
2202         * AccessibleBase.cpp:
2203         (MSAARole):
2204
2205 2017-10-26  Alex Christensen  <achristensen@webkit.org>
2206
2207         Fix Windows build
2208         https://bugs.webkit.org/show_bug.cgi?id=178892
2209
2210         * AccessibleBase.cpp:
2211         (AccessibleBase::state const):
2212         (MSAARole):
2213
2214 2017-10-25  Youenn Fablet  <youenn@apple.com>
2215
2216         Enable ServiceWorker to fetch resources
2217         https://bugs.webkit.org/show_bug.cgi?id=178673
2218
2219         Reviewed by Brady Eidson.
2220
2221         Added implementation to the new getters.
2222         They are noop in the context of WK1.
2223
2224         * WebCoreSupport/WebFrameLoaderClient.cpp:
2225         (WebFrameLoaderClient::pageID const):
2226         (WebFrameLoaderClient::frameID const):
2227         (WebFrameLoaderClient::sessionID const):
2228         * WebCoreSupport/WebFrameLoaderClient.h:
2229
2230 2017-10-20  Antoine Quint  <graouts@apple.com>
2231
2232         [Web Animations] Provide basic timeline and animation interfaces
2233         https://bugs.webkit.org/show_bug.cgi?id=178526
2234
2235         Reviewed by Dean Jackson.
2236
2237         Remove the WEB_ANIMATIONS compile-time flag.
2238
2239         * WebView.cpp:
2240         (WebView::notifyPreferencesChanged):
2241
2242 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2243
2244         [Curl] Clean up old style code in old curl files.
2245         https://bugs.webkit.org/show_bug.cgi?id=178569
2246
2247         Reviewed by Ryosuke Niwa.
2248
2249         * WebCache.cpp:
2250         (WebCache::cacheFolder):
2251         (WebCache::setCacheFolder):
2252         * WebView.cpp:
2253         (WebView::setCacheModel):
2254
2255 2017-10-19  Sam Weinig  <sam@webkit.org>
2256
2257         [Settings] Move global settings into their own file
2258         https://bugs.webkit.org/show_bug.cgi?id=178512
2259
2260         Reviewed by Darin Adler.
2261
2262         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2263
2264         * WebView.cpp:
2265         (WebView::initWithFrame):
2266
2267 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2268
2269         Replace some stack raw pointers with RefPtrs within WebCore/html
2270         https://bugs.webkit.org/show_bug.cgi?id=178201
2271         <rdar://problem/34841692>
2272
2273         Reviewed by Ryosuke Niwa.
2274
2275         * WebView.cpp:
2276         (WebView::handleEditingKeyboardEvent):
2277         Change the type of node as toNode() is changed to return RefPtr.
2278
2279 2017-10-16  Sam Weinig  <sam@webkit.org>
2280
2281         [Settings] Remove all custom code from Settings.h/cpp
2282         https://bugs.webkit.org/show_bug.cgi?id=178330
2283
2284         Reviewed by Simon Fraser.
2285
2286         * WebView.cpp:
2287         (WebView::notifyPreferencesChanged):
2288             
2289             Update for naming changes of FrameFlattening now that it is an enum class.
2290
2291 2017-10-11  Chris Dumez  <cdumez@apple.com>
2292
2293         Modernize Geolocation code
2294         https://bugs.webkit.org/show_bug.cgi?id=178148
2295
2296         Reviewed by Ryosuke Niwa.
2297
2298         * WebCoreSupport/WebGeolocationClient.cpp:
2299         (WebGeolocationClient::lastPosition):
2300         * WebCoreSupport/WebGeolocationClient.h:
2301         * WebGeolocationPosition.cpp:
2302         (WebGeolocationPosition::initWithTimestamp):
2303         (core):
2304         * WebGeolocationPosition.h:
2305         (WebGeolocationPosition::impl const):
2306
2307 2017-10-05  Chris Dumez  <cdumez@apple.com>
2308
2309         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2310         https://bugs.webkit.org/show_bug.cgi?id=177957
2311
2312         Reviewed by Alex Christensen.
2313
2314         * WebCoreSupport/WebPlatformStrategies.cpp:
2315         (WebPlatformStrategies::cookiesEnabled):
2316         * WebCoreSupport/WebPlatformStrategies.h:
2317
2318 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2319
2320         [Curl] Reimplement CurlDownload with CurlRequest
2321         https://bugs.webkit.org/show_bug.cgi?id=177779
2322
2323         Reviewed by Alex Christensen.
2324
2325         * WebDownload.h:
2326         * WebDownloadCurl.cpp:
2327         (WebDownload::init):
2328         (WebDownload::didReceiveResponse):
2329
2330 2017-09-29  Chris Dumez  <cdumez@apple.com>
2331
2332         Split some logic out of VisitedLinkStore and make it reusable
2333         https://bugs.webkit.org/show_bug.cgi?id=177575
2334
2335         Reviewed by Alex Christensen.
2336
2337         * WebCoreSupport/WebVisitedLinkStore.cpp:
2338         (WebVisitedLinkStore::addVisitedLink):
2339         (WebVisitedLinkStore::isLinkVisited):
2340         (WebVisitedLinkStore::addVisitedLinkHash):
2341         * WebCoreSupport/WebVisitedLinkStore.h:
2342
2343 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2344
2345         Make PolicyAction an encodable enum class
2346         https://bugs.webkit.org/show_bug.cgi?id=177480
2347
2348         Reviewed by Antti Koivisto.
2349
2350         * WebCoreSupport/WebFrameLoaderClient.cpp:
2351         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2352         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2353         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2354         * WebFramePolicyListener.cpp:
2355         (WebFramePolicyListener::use):
2356         (WebFramePolicyListener::download):
2357         (WebFramePolicyListener::ignore):
2358         (WebFramePolicyListener::continueSubmit):
2359
2360 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
2361
2362         [Win] fast/canvas/2d.getPath.modification.html is failing.
2363         https://bugs.webkit.org/show_bug.cgi?id=176534
2364
2365         Reviewed by Alex Christensen.
2366
2367         We need to enable Inspector additions at runtime in order to expose the getPath function.
2368
2369         * Interfaces/IWebPreferencesPrivate.idl:
2370         * WebPreferenceKeysPrivate.h:
2371         * WebPreferences.cpp:
2372         (WebPreferences::initializeDefaultSettings):
2373         (WebPreferences::setDataTransferItemsEnabled):
2374         (WebPreferences::inspectorAdditionsEnabled):
2375         (WebPreferences::setInspectorAdditionsEnabled):
2376         * WebPreferences.h:
2377         * WebView.cpp:
2378         (WebView::notifyPreferencesChanged):
2379
2380 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2381
2382         Modernize Geolocation code
2383         https://bugs.webkit.org/show_bug.cgi?id=176496
2384
2385         Reviewed by Andy Estes.
2386
2387         * WebCoreSupport/WebGeolocationClient.cpp:
2388         (WebGeolocationClient::requestPermission):
2389         * WebCoreSupport/WebGeolocationClient.h:
2390         (WebGeolocationClient::setEnableHighAccuracy): Deleted.
2391         (WebGeolocationClient::cancelPermissionRequest): Deleted.
2392         * WebGeolocationPolicyListener.h:
2393         * WebView.cpp:
2394         (WebView::initWithFrame):
2395         (WebView::geolocationDidFailWithError):
2396
2397 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
2398
2399         [Win] Enable DatatransferItems in DRT.
2400         https://bugs.webkit.org/show_bug.cgi?id=176424
2401
2402         Reviewed by Brent Fulgham.
2403
2404         * Interfaces/IWebPreferencesPrivate.idl:
2405         * WebPreferenceKeysPrivate.h:
2406         * WebPreferences.cpp:
2407         (WebPreferences::initializeDefaultSettings):
2408         (WebPreferences::QueryInterface):
2409         (WebPreferences::isSecureContextAttributeEnabled):
2410         (WebPreferences::dataTransferItemsEnabled):
2411         (WebPreferences::setDataTransferItemsEnabled):
2412         * WebPreferences.h:
2413         * WebView.cpp:
2414         (WebView::notifyPreferencesChanged):
2415
2416 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2417
2418         Unreviewed build fix #2 after r221275.
2419
2420         * WebCoreSupport/WebPlatformStrategies.cpp:
2421         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
2422         to match new API.
2423         * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
2424
2425 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2426
2427         Unreviewed build fix after r221275.
2428
2429         * WebCoreSupport/WebPlatformStrategies.cpp:
2430         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
2431         to match new API.
2432
2433 2017-08-28  Per Arne Vollan  <pvollan@apple.com>
2434
2435         [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
2436         https://bugs.webkit.org/show_bug.cgi?id=176031
2437
2438         Reviewed by Brent Fulgham.
2439
2440         When the function in the FramePolicyFunction parameter is called, it has already been moved
2441         to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
2442         function by using the stored member instead.
2443
2444         * WebCoreSupport/WebFrameLoaderClient.cpp:
2445         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2446         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2447         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2448
2449 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2450
2451         Unreviewed, try to fix the Windows build after r221064
2452
2453         didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
2454
2455         * WebCoreSupport/WebEditorClient.h:
2456
2457 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2458
2459         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2460         https://bugs.webkit.org/show_bug.cgi?id=175370
2461         <rdar://problem/33799806>
2462
2463         Reviewed by Ryosuke Niwa.
2464
2465         Adjust WebEditorClient for interface changes.
2466
2467         * WebCoreSupport/WebEditorClient.h:
2468
2469 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
2470
2471         Unreviewed build fix after r221017.
2472
2473         Correct copy/paste error.
2474
2475         * WebCoreSupport/WebPlatformStrategies.cpp:
2476         (WebPlatformStrategies::cookiesForDOM):
2477
2478 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
2479
2480         Unreviewed build fix after r221017.
2481
2482         * WebCoreSupport/WebPlatformStrategies.cpp:
2483         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
2484         * WebCoreSupport/WebPlatformStrategies.h:
2485
2486 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2487
2488         Remove ChromeClient::scrollbarsModeDidChange
2489         https://bugs.webkit.org/show_bug.cgi?id=175805
2490
2491         Reviewed by Daniel Bates.
2492
2493         * WebCoreSupport/WebChromeClient.h:
2494
2495 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2496
2497         Remove ChromeClient::hasOpenedPopup
2498         https://bugs.webkit.org/show_bug.cgi?id=175804
2499
2500         Reviewed by Sam Weinig.
2501
2502         * WebCoreSupport/WebChromeClient.cpp:
2503         (WebChromeClient::hasOpenedPopup const): Deleted.
2504         * WebCoreSupport/WebChromeClient.h:
2505
2506 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
2507
2508         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
2509         https://bugs.webkit.org/show_bug.cgi?id=173536
2510
2511         Reviewed by Brent Fulgham.
2512
2513         If the tree state is dirty, accessible objects are deleted while iterating over children
2514         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
2515         style is updated before this method is called.
2516
2517         * AccessibleBase.cpp:
2518         (AccessibleBase::getAccessibilityObjectForChild):
2519
2520 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2521
2522         [PAL] Move SessionID into PAL
2523         https://bugs.webkit.org/show_bug.cgi?id=174192
2524
2525         Reviewed by Antti Koivisto.
2526
2527         * WebCoreSupport/WebFrameLoaderClient.cpp:
2528         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2529         * WebCoreSupport/WebFrameLoaderClient.h:
2530         * WebCoreSupport/WebFrameNetworkingContext.cpp:
2531         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
2532         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2533         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2534         (WebFrameNetworkingContext::storageSession const):
2535         * WebCoreSupport/WebPlatformStrategies.cpp:
2536         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2537         * WebCoreSupport/WebPlatformStrategies.h:
2538
2539 2017-08-15  Youenn Fablet  <youenn@apple.com>
2540
2541         [Cache API] Adding generic support for CacheStorage and Cache methods
2542         https://bugs.webkit.org/show_bug.cgi?id=175455
2543
2544         Reviewed by Chris Dumez.
2545
2546         * WebView.cpp:
2547         (WebView::initWithFrame):
2548
2549 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2550
2551         Composition underline color is always black
2552         https://bugs.webkit.org/show_bug.cgi?id=174675
2553
2554         Reviewed by Ryosuke Niwa.
2555
2556         * WebView.cpp:
2557         (WebView::setCompositionForTesting): Use text color for
2558         composition underline.
2559
2560 2017-08-09  Daniel Bates  <dabates@apple.com>
2561
2562         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2563         https://bugs.webkit.org/show_bug.cgi?id=175247
2564         <rdar://problem/33679804>
2565
2566         Reviewed by Brady Eidson.
2567
2568         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2569         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2570         clients that need to make use of this information at this time. If such a needs comes up
2571         then we can expose API/SPI similar to what we do for WebKit.
2572
2573         * WebCoreSupport/WebFrameLoaderClient.cpp:
2574         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2575         * WebCoreSupport/WebFrameLoaderClient.h:
2576
2577 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
2578
2579         Async image decoding for large images should be disabled after the first time a tile is painted
2580         https://bugs.webkit.org/show_bug.cgi?id=174451
2581         <rdar://problem/31246421>
2582
2583         Reviewed by Simon Fraser.
2584
2585         * FullscreenVideoController.cpp:
2586         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
2587         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2588         (AcceleratedCompositingContext::paintContents):
2589         * WebCoreSupport/AcceleratedCompositingContext.h:
2590
2591 2017-07-23  Darin Adler  <darin@apple.com>
2592
2593         More NeverDestroyed and related cleanup
2594         https://bugs.webkit.org/show_bug.cgi?id=174745
2595
2596         Reviewed by Alex Christensen.
2597
2598         * Plugins/PluginDatabase.cpp:
2599         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
2600         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
2601         * Plugins/PluginMainThreadScheduler.cpp:
2602         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
2603         * Plugins/PluginMainThreadScheduler.h: Ditto.
2604         * WebCoreSupport/WebPlatformStrategies.cpp:
2605         (WebPlatformStrategies::initialize): Ditto.
2606         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
2607         * WebHistory.cpp:
2608         (sharedHistoryStorage): Ditto.
2609         * WebLocalizableStrings.cpp:
2610         (mainBundleLocStrings): Ditto.
2611         (frameworkLocStringsMutex): Ditto.
2612         (frameworkLocStrings): Ditto.
2613         * WebView.cpp:
2614         (WebView::standardUserAgentWithApplicationName): Ditto.
2615         Also changed to keep one global string with the prefix of the user agent string
2616         instead of keeping two globals with pieces of that prefix.
2617
2618 2017-07-24  Chris Dumez  <cdumez@apple.com>
2619
2620         Make ExceptionCode a proper enumeration
2621         https://bugs.webkit.org/show_bug.cgi?id=174771
2622
2623         Reviewed by Sam Weinig.
2624
2625         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
2626
2627         * DOMCoreClasses.cpp:
2628         (DOMDocument::createEvent):
2629         * WebView.cpp:
2630         (WebView::prepareCandidateWindow):
2631
2632 2017-07-21  Andreas Kling  <akling@apple.com>
2633
2634         Use more references in event dispatch code
2635         https://bugs.webkit.org/show_bug.cgi?id=174681
2636
2637         Reviewed by Geoffrey Garen.
2638
2639         * DOMEventsClasses.cpp:
2640         (WebEventListener::handleEvent):
2641         * DOMEventsClasses.h:
2642         * Plugins/PluginView.cpp:
2643         (WebCore::PluginView::handleEvent):
2644         * Plugins/PluginView.h:
2645
2646 2017-07-20  Brady Eidson  <beidson@apple.com>
2647
2648         Remove WebIconDatabase from WebKitLegacy/win.
2649         https://bugs.webkit.org/show_bug.cgi?id=174608
2650
2651         Reviewed by Alex Christensen.
2652
2653         It is unused.
2654         
2655         * ForEachCoClass.h:
2656
2657         * Interfaces/IWebIconDatabase.idl: Removed.
2658
2659         * Interfaces/WebKit.idl:
2660
2661         * WebCoreStatistics.cpp:
2662         (WebCoreStatistics::iconPageURLMappingCount):
2663         (WebCoreStatistics::iconRetainedPageURLCount):
2664         (WebCoreStatistics::iconRecordCount):
2665         (WebCoreStatistics::iconsWithDataCount):
2666
2667         * WebIconDatabase.cpp: Removed.
2668         * WebIconDatabase.h: Removed.
2669         * WebKitClassFactory.cpp:
2670
2671         * WebKitDLL.cpp:
2672         (shutDownWebKit):
2673
2674         * WebKitLogging.h:
2675
2676         * WebView.cpp:
2677         (WebView::close):
2678         (WebView::notifyDidAddIcon):
2679         (WebView::registerForIconNotification):
2680         (WebView::dispatchDidReceiveIconFromWebFrame):
2681         (WebView::onNotify):
2682
2683 2017-07-18  Matt Lewis  <jlewis3@apple.com>
2684
2685         Unreviewed, rolling out r219610.
2686
2687         This caused an api failure on all platforms for the test
2688         SnapshotImageLargeAsyncDecoding
2689
2690         Reverted changeset:
2691
2692         "Async image decoding for large images should be disabled
2693         after the first time a tile is painted"
2694         https://bugs.webkit.org/show_bug.cgi?id=174451
2695         http://trac.webkit.org/changeset/219610
2696
2697 2017-07-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
2698
2699         Async image decoding for large images should be disabled after the first time a tile is painted
2700         https://bugs.webkit.org/show_bug.cgi?id=174451
2701
2702         Reviewed by Simon Fraser.
2703
2704         * FullscreenVideoController.cpp:
2705         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
2706         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2707         (AcceleratedCompositingContext::paintContents):
2708         * WebCoreSupport/AcceleratedCompositingContext.h:
2709
2710 2017-07-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2711
2712         [Curl] Don't start downloading more than once for same request
2713         https://bugs.webkit.org/show_bug.cgi?id=174172
2714
2715         Reviewed by Alex Christensen.
2716
2717         * WebDownloadCurl.cpp:
2718         (WebDownload::init):
2719
2720 2017-07-12  Daniel Bates  <dabates@apple.com>
2721
2722         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
2723         https://bugs.webkit.org/show_bug.cgi?id=174427
2724
2725         Rubber-stamped by Brady Eidson.
2726
2727         * Plugins/PluginView.cpp:
2728         (WebCore::PluginView::start):
2729         (WebCore::PluginView::getURLNotify):
2730         (WebCore::PluginView::getURL):
2731         (WebCore::PluginView::handlePost):
2732
2733 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2734
2735         [WTF] Move SoftLinking.h into WTF
2736         https://bugs.webkit.org/show_bug.cgi?id=174000
2737
2738         Reviewed by Alex Christensen.
2739
2740         * WebKitClassFactory.cpp:
2741         * WebView.cpp:
2742
2743 2017-07-05  Brady Eidson  <beidson@apple.com>
2744
2745         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
2746         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
2747
2748         Reviewed by Alex Christensen.
2749
2750         Adopt to the new constructor for FrameLoadRequest.
2751
2752         * Plugins/PluginView.cpp:
2753         (WebCore::PluginView::start):
2754         (WebCore::PluginView::getURLNotify):
2755         (WebCore::PluginView::getURL):
2756         (WebCore::PluginView::handlePost):
2757
2758 2017-07-03  Brady Eidson  <beidson@apple.com>
2759
2760         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2761         https://bugs.webkit.org/show_bug.cgi?id=174073
2762
2763         Reviewed by Andy Estes.
2764
2765         * WebCoreSupport/WebFrameLoaderClient.cpp:
2766         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
2767         (WebFrameLoaderClient::registerForIconNotification): Deleted.
2768         * WebCoreSupport/WebFrameLoaderClient.h:
2769
2770 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
2771
2772         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
2773         https://bugs.webkit.org/show_bug.cgi?id=174004
2774
2775         Reviewed by Simon Fraser.
2776
2777         * WebCoreSupport/WebFrameLoaderClient.cpp:
2778         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2779
2780 2017-06-30  Daniel Bates  <dabates@apple.com>
2781
2782         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2783         https://bugs.webkit.org/show_bug.cgi?id=165160
2784         <rdar://problem/29451999>
2785
2786         Reviewed by Brady Eidson.
2787
2788         Pass the document that is requesting the load to the loader.
2789
2790         * Plugins/PluginView.cpp:
2791         (WebCore::PluginView::start):
2792         (WebCore::PluginView::getURLNotify):
2793         (WebCore::PluginView::getURL):
2794         (WebCore::PluginView::handlePost):
2795
2796 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2797
2798         Refactor drag start codepaths to plumb a DragItem to client layers
2799         https://bugs.webkit.org/show_bug.cgi?id=173832
2800         Work towards <rdar://problem/32236827>
2801
2802         Reviewed by Ryosuke Niwa and Tim Horton.
2803
2804         Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
2805
2806         * WebCoreSupport/WebDragClient.cpp:
2807         (WebDragClient::startDrag):
2808         * WebCoreSupport/WebDragClient.h:
2809
2810 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
2811
2812         Remove excessive headers from JavaScriptCore
2813         https://bugs.webkit.org/show_bug.cgi?id=173812
2814
2815         Reviewed by Darin Adler.
2816
2817         * Plugins/PluginPackage.cpp:
2818
2819 2017-06-22  Daniel Bates  <dabates@apple.com>
2820
2821         Make FrameLoadRequest a move-only type
2822         https://bugs.webkit.org/show_bug.cgi?id=173682
2823
2824         Reviewed by Alex Christensen and Darin Adler.
2825
2826         A FrameLoadRequest groups together the information to perform a load into a single object
2827         that is more manageable to pass around than its constituent parts. Code that receives a
2828         FrameLoadRequest is expected to extract out the information it needs to complete its task.
2829         And it does not make sense to re-use the same FrameLoadRequest object for more than one
2830         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
2831
2832         * Plugins/PluginView.cpp:
2833         (WebCore::PluginView::start):
2834         (WebCore::PluginView::performRequest):
2835         (WebCore::PluginView::load):
2836         (WebCore::PluginView::getURLNotify):
2837         (WebCore::PluginView::getURL):
2838         (WebCore::PluginView::handlePost):
2839         * Plugins/PluginView.h:
2840         (WebCore::PluginRequest::PluginRequest):
2841
2842 2017-06-22  Daniel Bates  <dabates@apple.com>
2843
2844         [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
2845         https://bugs.webkit.org/show_bug.cgi?id=173683
2846
2847         Reviewed by Alex Christensen.
2848
2849         Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
2850         header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
2851         by including PluginView.h. The latter does not make use of the functionality
2852         provided by FrameLoadRequest.h.
2853
2854         * Plugins/PluginViewWin.cpp:
2855         * WebCoreSupport/WebContextMenuClient.cpp:
2856
2857 2017-06-21  Daniel Bates  <dabates@apple.com>
2858
2859         Cleanup FrameLoadRequest
2860         https://bugs.webkit.org/show_bug.cgi?id=173564
2861         <rdar://problem/32903570>
2862
2863         Reviewed by Brent Fulgham.
2864
2865         * Plugins/PluginView.cpp:
2866         (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
2867         we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
2868         we do not have one. Use C++11 brace initialization syntax.
2869         (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
2870         name as we do not have one. Use C++11 brace initialization syntax.
2871         (WebCore::PluginView::getURL): Ditto.
2872         (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
2873         function to closer to where it is actually used. Explicitly pass the null-string for the target
2874         frame name as we do not have one. Use C++11 brace initialization syntax.
2875
2876 2017-06-20  Daniel Bates  <dabates@apple.com>
2877
2878         Have FrameLoadRequest takes a Frame& instead of a Frame*
2879         https://bugs.webkit.org/show_bug.cgi?id=173614
2880         <rdar://problem/32884890>
2881
2882         Reviewed by Brent Fulgham.
2883
2884         * Plugins/PluginView.cpp:
2885         (WebCore::PluginView::performRequest):
2886         * WebFrame.cpp:
2887         (WebFrame::loadRequest):
2888
2889 2017-06-19  Chris Dumez  <cdumez@apple.com>
2890
2891         Use WTF::Function instead of std::function in more places in WebCore/
2892         https://bugs.webkit.org/show_bug.cgi?id=173535
2893
2894         Reviewed by Antti Koivisto.
2895
2896         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
2897
2898         * WebCoreSupport/WebFrameLoaderClient.cpp:
2899         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2900         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2901         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2902         (WebFrameLoaderClient::dispatchWillSubmitForm):
2903         (WebFrameLoaderClient::setUpPolicyListener):
2904         (WebFrameLoaderClient::receivedPolicyDecision):
2905         * WebCoreSupport/WebFrameLoaderClient.h:
2906
2907 2017-05-14 Frederic Wang  <fwang@igalia.com>
2908
2909         Add heuristic to avoid flattening "fullscreen" iframes
2910         https://bugs.webkit.org/show_bug.cgi?id=171914
2911
2912         Reviewed by Simon Fraser.
2913
2914         This commit ajusts the window port to internally use the new preference type for frame flattening.
2915         However, the "partial frame flattening" value is not exposed yet.
2916
2917         * WebView.cpp:
2918         (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
2919
2920 2017-06-17  Chris Dumez  <cdumez@apple.com>
2921
2922         Use WTF::Function instead of std::function in WebKit2/
2923         https://bugs.webkit.org/show_bug.cgi?id=173504
2924
2925         Reviewed by Darin Adler.
2926
2927         Use WTF::Function instead of std::function in WebKit2/ to avoid
2928         unnecessary copying.
2929
2930         * Plugins/PluginStream.cpp:
2931         (WebCore::PluginStream::willSendRequest):
2932         * Plugins/PluginStream.h:
2933
2934 2017-06-16  Sam Weinig  <sam@webkit.org>
2935
2936         [WebIDL] Remove custom bindings for HTMLDocument
2937         https://bugs.webkit.org/show_bug.cgi?id=173444
2938
2939         Reviewed by Darin Adler.
2940
2941         * DOMHTMLClasses.cpp:
2942         (DOMHTMLDocument::write):
2943         (DOMHTMLDocument::writeln):
2944         Update for new signature of write/writeln.
2945
2946 2017-06-16  Daniel Bates  <dabates@apple.com>
2947
2948         Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
2949         instead of URL { ParsedURLString, ... }
2950         https://bugs.webkit.org/show_bug.cgi?id=173495
2951         <rdar://problem/32827445>
2952
2953         Reviewed by Alex Christensen.
2954
2955         URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
2956         Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
2957         Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
2958         would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
2959         parse an arbitrary string that looks like a URL.
2960
2961         Also modernize the code using C++14 idioms.
2962
2963         * WebCoreSupport/WebContextMenuClient.cpp:
2964         (WebContextMenuClient::searchWithGoogle):
2965
2966 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
2967
2968         [Win] WebKit shouldn't include the forwarding header of WebKit itself
2969         https://bugs.webkit.org/show_bug.cgi?id=173352
2970
2971         Reviewed by Alex Christensen.
2972
2973         * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
2974
2975 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
2976
2977         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
2978         https://bugs.webkit.org/show_bug.cgi?id=173318
2979
2980         Reviewed by Darin Adler.
2981
2982         The logical frame size is currently calculated by scaling the frame size in pixels,
2983         and rounding the coordinates to the nearest integers. The computed logical frame
2984         size will in some cases be smaller than the scaled frame size in pixels, since it is
2985         represented as an IntSize. In these cases, the bottom line will not be painted.
2986         Instead of calculating the logical frame size by rounding the scaled frame in
2987         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
2988
2989         * WebCoreSupport/WebFrameLoaderClient.cpp:
2990         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2991
2992 2017-06-13  Daniel Bates  <dabates@apple.com>
2993
2994         Implement W3C Secure Contexts Draft Specification
2995         https://bugs.webkit.org/show_bug.cgi?id=158121
2996         <rdar://problem/26012994>
2997
2998         Reviewed by Brent Fulgham.
2999
3000         Part 4
3001
3002         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3003
3004         * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
3005         * WebPreferenceKeysPrivate.h:
3006         * WebPreferences.cpp:
3007         (WebPreferences::initializeDefaultSettings):
3008         (WebPreferences::QueryInterface):
3009         (WebPreferences::setIsSecureContextAttributeEnabled):
3010         (WebPreferences::isSecureContextAttributeEnabled):
3011         * WebPreferences.h:
3012         * WebView.cpp:
3013         (WebView::notifyPreferencesChanged):
3014
3015 2017-06-13  Per Arne Vollan  <pvollan@apple.com>
3016
3017         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
3018         https://bugs.webkit.org/show_bug.cgi?id=173318
3019
3020         Reviewed by Alex Christensen.
3021
3022         The logical frame size is currently calculated by scaling the frame size in pixels,
3023         and rounding the coordinates to the nearest integers. The computed logical frame
3024         size will in some cases be smaller than the scaled frame size in pixels, since it is
3025         represented as an IntSize. In these cases, the bottom line will not be painted.
3026         Instead of calculating the logical frame size by rounding the scaled frame in
3027         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
3028  
3029         * WebView.cpp:
3030         (WebView::sizeChanged):
3031
3032 2017-06-13  Sam Weinig  <sam@webkit.org>
3033
3034         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
3035         https://bugs.webkit.org/show_bug.cgi?id=80733
3036
3037         Reviewed by Chris Dumez.
3038
3039         * WebFrame.cpp:
3040         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
3041
3042 2017-06-12  Daewoong Jang  <daewoong.jang@navercorp.com>
3043
3044         Remove WebCore::unloadModule and related data types
3045         https://bugs.webkit.org/show_bug.cgi?id=173231
3046
3047         Reviewed by Darin Adler.
3048
3049         * Plugins/PlatformModule.h: Added.
3050         (WebCore::PlatformModuleVersion::PlatformModuleVersion):
3051         * Plugins/PluginPackage.cpp:
3052         (WebCore::PluginPackage::freeLibraryTimerFired):
3053         * Plugins/PluginPackage.h:
3054
3055 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3056
3057         [iOS DnD] Add a hook to perform two-step drops in editable content
3058         https://bugs.webkit.org/show_bug.cgi?id=172992
3059         <rdar://problem/32590174>
3060
3061         Reviewed by Tim Horton.
3062
3063         Add a stub implementation for performTwoStepDrop on Windows.
3064
3065         * WebCoreSupport/WebEditorClient.h:
3066
3067 2017-06-04  Konstantin Tokarev  <annulen@yandex.ru>
3068
3069         Fix build of Windows-specific code with ICU 59.1
3070         https://bugs.webkit.org/show_bug.cgi?id=172729
3071
3072         Reviewed by Darin Adler.
3073
3074         Fix conversions from WTF::String to wchar_t* and vice versa.
3075
3076         * Plugins/PluginDatabaseWin.cpp:
3077         (WebCore::addPluginPathsFromRegistry):
3078         (WebCore::PluginDatabase::getPluginPathsInDirectories):
3079         (WebCore::addMozillaPluginDirectories):
3080         (WebCore::addWindowsMediaPlayerPluginDirectory):
3081         (WebCore::addAdobeAcrobatPluginDirectory):
3082         (WebCore::addJavaPluginDirectory):
3083         (WebCore::safariPluginsDirectory):
3084         (WebCore::addMacromediaPluginDirectories):
3085         * Plugins/PluginPackageWin.cpp:
3086         (WebCore::getVersionInfo):
3087         (WebCore::PluginPackage::fetchInfo):
3088         (WebCore::PluginPackage::load):
3089         * Plugins/PluginViewWin.cpp:
3090         (WebCore::PluginView::handlePostReadFile):
3091
3092 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
3093
3094         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
3095         https://bugs.webkit.org/show_bug.cgi?id=172709
3096
3097         Reviewed by Brent Fulgham.
3098
3099         Add method to exit fullscreen mode.
3100
3101         * Interfaces/IWebViewPrivate.idl:
3102         * WebView.cpp:
3103         (WebView::exitFullscreenIfNeeded):
3104         * WebView.h:
3105
3106 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
3107
3108         [Win] Create unique network storage session for each DRT.
3109         https://bugs.webkit.org/show_bug.cgi?id=172540
3110
3111         Reviewed by Brent Fulgham.
3112
3113         During layout testing, each DRT instance should have its own network storage session.
3114
3115         * Interfaces/IWebPreferencesPrivate.idl:
3116         * WebPreferences.cpp:
3117         (WebPreferences::switchNetworkLoaderToNewTestingSession):
3118         * WebPreferences.h:
3119
3120 2017-05-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3121
3122         [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
3123         https://bugs.webkit.org/show_bug.cgi?id=172535
3124
3125         Reviewed by Konstantin Tokarev.
3126
3127         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3128         (AcceleratedCompositingContext::paintContents): Append the fifth argument.
3129         * WebCoreSupport/AcceleratedCompositingContext.h: Ditto.
3130
3131 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
3132
3133         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
3134         https://bugs.webkit.org/show_bug.cgi?id=172071
3135
3136         Reviewed by Alexey Proskuryakov.
3137
3138         We need to delete all cookies after each test.
3139
3140         * Interfaces/IWebPreferencesPrivate.idl:
3141         * WebPreferences.cpp:
3142         (WebPreferences::linkPreloadEnabled):
3143         (WebPreferences::clearNetworkLoaderSession):
3144         * WebPreferences.h:
3145
3146 2017-05-13  Chris Dumez  <cdumez@apple.com>
3147
3148         Stop using RefPtr::release()
3149         https://bugs.webkit.org/show_bug.cgi?id=172074
3150
3151         Reviewed by Geoffrey Garen.
3152
3153         * WebFrame.cpp:
3154         (WebFrame::loadPlainTextString):
3155         (WebFrame::loadHTMLString):
3156         * WebFramePolicyListener.cpp:
3157         (WebFramePolicyListener::receivedPolicyDecision):
3158
3159 2017-05-13  Chris Dumez  <cdumez@apple.com>
3160
3161         Drop uses of PassRefPtr in WebKit/win
3162         https://bugs.webkit.org/show_bug.cgi?id=172067
3163
3164         Reviewed by Yusuke Suzuki.
3165
3166         * DOMEventsClasses.cpp:
3167         (DOMEvent::DOMEvent):
3168         (DOMEvent::createInstance):
3169         * DOMEventsClasses.h:
3170         (DOMUIEvent::DOMUIEvent):
3171         (DOMKeyboardEvent::DOMKeyboardEvent):
3172         (DOMMouseEvent::DOMMouseEvent):
3173         (DOMMutationEvent::DOMMutationEvent):
3174         (DOMOverflowEvent::DOMOverflowEvent):
3175         (DOMWheelEvent::DOMWheelEvent):
3176         * MemoryStream.cpp:
3177         (MemoryStream::MemoryStream):
3178         (MemoryStream::createInstance):
3179         * MemoryStream.h:
3180         * Plugins/PluginDatabase.cpp:
3181         (WebCore::PluginDatabase::refresh):
3182         (WebCore::PluginDatabase::add):
3183         (WebCore::PluginDatabase::loadPersistentMetadataCache):
3184         * Plugins/PluginDatabase.h:
3185         * Plugins/PluginPackage.cpp:
3186         (WebCore::PluginPackage::createPackage):
3187         (WebCore::PluginPackage::createPackageFromCache):
3188         * Plugins/PluginPackage.h:
3189         * Plugins/PluginStream.h:
3190         (WebCore::PluginStream::create):
3191         * WebActionPropertyBag.cpp:
3192         (WebActionPropertyBag::WebActionPropertyBag):
3193         (WebActionPropertyBag::createInstance):
3194         * WebActionPropertyBag.h:
3195         * WebArchive.cpp:
3196         (WebArchive::createInstance):
3197         (WebArchive::WebArchive):
3198         * WebArchive.h:
3199         * WebBackForwardList.cpp:
3200         (WebBackForwardList::WebBackForwardList):
3201         (WebBackForwardList::createInstance):
3202         * WebBackForwardList.h:
3203         * WebCoreSupport/EmbeddedWidget.cpp:
3204         (EmbeddedWidget::create):
3205         * WebCoreSupport/EmbeddedWidget.h:
3206         * WebCoreSupport/WebChromeClient.h:
3207         * WebFrame.cpp:
3208         (WebFrame::loadData):
3209         (WebFrame::createSubframeWithOwnerElement):
3210         * WebFrame.h:
3211         * WebFramePolicyListener.cpp:
3212         (WebFramePolicyListener::WebFramePolicyListener):
3213         (WebFramePolicyListener::createInstance):
3214         * WebFramePolicyListener.h:
3215         * WebGeolocationPolicyListener.cpp:
3216         (WebGeolocationPolicyListener::createInstance):
3217         (WebGeolocationPolicyListener::WebGeolocationPolicyListener):
3218         * WebGeolocationPolicyListener.h:
3219         * WebHistoryItem.cpp:
3220         (WebHistoryItem::WebHistoryItem):
3221         (WebHistoryItem::createInstance):
3222         * WebHistoryItem.h:
3223         * WebMutableURLRequest.cpp:
3224         (WebMutableURLRequest::setFormData):
3225         (WebMutableURLRequest::formData):
3226         * WebMutableURLRequest.h:
3227         * WebResource.cpp:
3228         (WebResource::createInstance):
3229         * WebResource.h:
3230         * WebScriptWorld.cpp:
3231         (WebScriptWorld::WebScriptWorld):
3232         (WebScriptWorld::createInstance):
3233         * WebScriptWorld.h:
3234         * WebURLAuthenticationChallengeSender.cpp:
3235         (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
3236         (WebURLAuthenticationChallengeSender::createInstance):
3237         * WebURLAuthenticationChallengeSender.h:
3238         * WebView.cpp:
3239         (WebView::setFullScreenElement):
3240         * WebView.h:
3241
3242 2017-05-11  Chris Dumez  <cdumez@apple.com>
3243
3244         Drop remaining uses of PassRefPtr in WebCore
3245         https://bugs.webkit.org/show_bug.cgi?id=172013
3246
3247         Reviewed by Yusuke Suzuki.
3248
3249         * Plugins/PluginView.cpp:
3250         (WebCore::PluginView::bindingInstance):
3251
3252 2017-05-11  Chris Dumez  <cdumez@apple.com>
3253
3254         Stop using PassRefPtr in platform/graphics
3255         https://bugs.webkit.org/show_bug.cgi?id=171977
3256
3257         Reviewed by Alex Christensen.
3258
3259         Build fix.
3260
3261         * FullscreenVideoController.cpp:
3262         (FullscreenVideoController::enterFullscreen):
3263         * WebKitDLL.cpp:
3264         (loadResourceIntoBuffer):
3265
3266 2017-05-09  Sam Weinig  <sam@webkit.org>
3267
3268         Remove support for legacy Notifications
3269         https://bugs.webkit.org/show_bug.cgi?id=171487
3270
3271         Reviewed by Jon Lee.
3272
3273         * WebCoreSupport/WebChromeClient.cpp:
3274         (WebChromeClient::WebChromeClient):
3275         * WebCoreSupport/WebChromeClient.h:
3276         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
3277         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
3278         Remove legacy notification specific code.
3279
3280 2017-05-09  Dean Jackson  <dino@apple.com>
3281
3282         Fix Windows build.
3283
3284         * Plugins/PluginView.h:
3285         * Plugins/PluginViewWin.cpp:
3286         (WebCore::PluginView::paint):
3287
3288 2017-05-06  Alexey Proskuryakov  <ap@apple.com>
3289
3290         REGRESSION (r216294): The new test fails on WebKit1
3291         https://bugs.webkit.org/show_bug.cgi?id=171780
3292
3293         Rolling back https://trac.webkit.org/r216294, https://trac.webkit.org/r216296,
3294         https://trac.webkit.org/216299, https://trac.webkit.org/216330
3295
3296         * Plugins/PluginView.h:
3297         * Plugins/PluginViewWin.cpp:
3298         (WebCore::PluginView::paint):
3299
3300 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
3301
3302         Fix Windows build after r216294.
3303
3304         * Plugins/PluginView.h:
3305         * Plugins/PluginViewWin.cpp:
3306         (WebCore::PluginView::paint):
3307
3308 2017-05-04  Commit Queue  <commit-queue@webkit.org>
3309
3310         Unreviewed, rolling out r216206.
3311         https://bugs.webkit.org/show_bug.cgi?id=171714
3312
3313         Multiple LayoutTests crashing in Document::page() (Requested
3314         by ap on #webkit).
3315
3316         Reverted changeset:
3317
3318         "Remove support for legacy Notifications"
3319         https://bugs.webkit.org/show_bug.cgi?id=171487
3320         http://trac.webkit.org/changeset/216206
3321
3322 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
3323
3324         [Win] Remove redundant macros that are set in the CMake config
3325         https://bugs.webkit.org/show_bug.cgi?id=171571
3326
3327         Reviewed by Brent Fulgham.
3328
3329         * COMEnumVariant.h:
3330         * COMPropertyBag.h:
3331         * WebKitPrefix.h:
3332
3333 2017-05-04  Sam Weinig  <sam@webkit.org>
3334
3335         Remove support for legacy Notifications
3336         https://bugs.webkit.org/show_bug.cgi?id=171487
3337
3338         Reviewed by Jon Lee.
3339
3340         * WebCoreSupport/WebChromeClient.cpp:
3341         (WebChromeClient::WebChromeClient):
3342         * WebCoreSupport/WebChromeClient.h:
3343         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
3344         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
3345         Remove legacy notification specific code.
3346
3347 2017-04-27  Alex Christensen  <achristensen@webkit.org>
3348
3349         Modernize Frame.h
3350         https://bugs.webkit.org/show_bug.cgi?id=171357
3351
3352         Reviewed by Andy Estes.
3353
3354         * WebCoreSupport/WebEditorClient.cpp:
3355         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
3356         * WebCoreSupport/WebEditorClient.h:
3357
3358 2017-04-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3359
3360         [WinCairo] Fix build break after updating ANGLE
3361         https://bugs.webkit.org/show_bug.cgi?id=170980
3362
3363         Reviewed by Brent Fulgham.
3364
3365         * WebCoreSupport/AcceleratedCompositingContext.cpp: Define GL_GLEXT_PROTOTYPES.
3366
3367 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
3368
3369         [Win] REGRESSION(r215486): Windows Release build is broken
3370         https://bugs.webkit.org/show_bug.cgi?id=171024
3371         <rdar://problem/31722618>
3372
3373         Reviewed by Mark Lam.
3374
3375         Windows WebKit refers to a handful of JSC methods that are always
3376         inline. We need to include 'HeapInlines.h' to get the implementation
3377         of these methods.
3378
3379         * Plugins/PluginPackage.cpp:
3380         * WebFrame.cpp:
3381         * WebView.cpp:
3382
3383 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3384
3385         Unreviewed, fix the Windows build after r215385
3386
3387         r215385 introduced a new virtual method on ChromeClient that needs to be implemented in WebChromeClient for
3388         Windows in WebKit1.
3389
3390         * WebCoreSupport/WebChromeClient.cpp:
3391         (WebChromeClient::createIconForFiles):
3392         * WebCoreSupport/WebChromeClient.h:
3393
3394 2017-04-10  Chris Dumez  <cdumez@apple.com>
3395
3396         Drop Timer::startOneShot() overload taking a double
3397         https://bugs.webkit.org/show_bug.cgi?id=170659
3398
3399         Reviewed by Yusuke Suzuki.
3400
3401         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
3402
3403         * Plugins/PluginMessageThrottlerWin.cpp:
3404         (WebCore::PluginMessageThrottlerWin::appendMessage):
3405         (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
3406         * Plugins/PluginViewWin.cpp:
3407         (WebCore::PluginView::invalidateRect):
3408         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3409         (AcceleratedCompositingContext::scheduleLayerFlush):
3410
3411 2017-04-09  Chris Dumez  <cdumez@apple.com>
3412
3413         Drop Timer::startRepeating() overload taking a double
3414         https://bugs.webkit.org/show_bug.cgi?id=170656
3415
3416         Reviewed by Yusuke Suzuki.
3417
3418         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
3419
3420         * FullscreenVideoController.cpp:
3421
3422 2017-04-09  Chris Dumez  <cdumez@apple.com>
3423
3424         Start dropping Timer API dealing with double
3425         https://bugs.webkit.org/show_bug.cgi?id=170649
3426
3427         Reviewed by Yusuke Suzuki.
3428
3429         Start dropping Timer API dealing with double as people should use Seconds now.
3430
3431         * Plugins/PluginPackage.cpp:
3432         (WebCore::PluginPackage::freeLibrarySoon):
3433         * Plugins/PluginStream.cpp:
3434         (WebCore::PluginStream::deliverData):
3435         * Plugins/PluginView.cpp:
3436         (WebCore::PluginView::requestTimerFired):
3437         (WebCore::PluginView::scheduleRequest):
3438         (WebCore::PluginView::setJavaScriptPaused):
3439         (WebCore::PluginView::keepAlive):
3440         * Plugins/PluginViewWin.cpp:
3441         (WebCore::PluginView::wndProc):
3442         * WebView.cpp:
3443         (WebView::closeWindowSoon):
3444
3445 2017-04-08  Chris Dumez  <cdumez@apple.com>
3446
3447         Drop std::chrono support from Timer class
3448         https://bugs.webkit.org/show_bug.cgi?id=170645
3449
3450         Reviewed by Sam Weinig.
3451
3452         Drop std::chrono support from Timer class now that we prefer using Seconds type.
3453
3454         * WebView.cpp:
3455         (WebView::setCacheModel):
3456
3457 2017-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3458
3459         [WinCairo] WebCore::PlatformDisplay::terminateEGLDisplay causes a crash in libGLESv2.dll while processing atexit
3460         https://bugs.webkit.org/show_bug.cgi?id=170331
3461
3462         Reviewed by Michael Catanzaro.
3463
3464         * WebKitDLL.cpp:
3465         (shutDownWebKit): Call PlatformDisplay::shutDownEglDisplays in shutDownWebKit.
3466
3467 2017-03-30  James Craig  <jcraig@apple.com>
3468
3469         AX: Expose a new AXSubrole for explicit ARIA "group" role
3470         https://bugs.webkit.org/show_bug.cgi?id=169810
3471         <rdar://problem/31039693>
3472
3473         Reviewed by Chris Fleizach.
3474
3475         Account for Windows platform role mapping.
3476
3477         * AccessibleBase.cpp:
3478         (MSAARole):
3479
3480 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3481
3482         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
3483         https://bugs.webkit.org/show_bug.cgi?id=169168
3484         <rdar://problem/30688374>
3485
3486         Reviewed by Tim Horton.
3487
3488         Minor tweak to adjust for a changed interface. See WebKit and WebCore ChangeLogs for more information.
3489
3490         * WebCoreSupport/WebDragClient.cpp:
3491         (WebDragClient::actionMaskForDrag):
3492         * WebCoreSupport/WebDragClient.h:
3493
3494 2017-03-13  Per Arne Vollan  <pvollan@apple.com>
3495
3496         [Win] Compile fix.
3497         https://bugs.webkit.org/show_bug.cgi?id=169545
3498
3499         Reviewed by Brent Fulgham.
3500
3501         Fix inconsistent dll linkage warnings.
3502  
3503         * WebKitDLL.cpp:
3504         * WebKitDLL.h:
3505
3506 2017-03-13  Per Arne Vollan  <pvollan@apple.com>
3507
3508         Unreviewed Win build fix.
3509         
3510         WebCore::CookiesStrategy::addCookie has been removed, we should also remove the override.
3511
3512         * WebCoreSupport/WebPlatformStrategies.cpp:
3513         (WebPlatformStrategies::addCookie): Deleted.
3514         (WebPlatformStrategies::addCookie): Deleted.
3515         * WebCoreSupport/WebPlatformStrategies.h:
3516
3517 2017-03-10  Brent Fulgham  <bfulgham@apple.com>
3518
3519         [Win] Re-export a few symbols for backwards compatibility
3520         https://bugs.webkit.org/show_bug.cgi?id=169490
3521         <rdar://problem/30983623>
3522
3523         Reviewed by Dean Jackson.
3524
3525         Re-introduce a workaround that re-exports a few JavaScriptCore functions
3526         that had been erroneously exported by WebKit in older builds. This
3527         is needed so that we do not break certain old software still being used.
3528
3529         * WebKitDLL.cpp:
3530         (DllMain): Bind functions at startup.
3531         (bindJavaScriptTrampoline): Find JavaScriptCore library functions and
3532         re-export them from WebKit.dll.
3533         * WebKitDLL.h: Only advertise these functions when building WebKt itself.
3534
3535 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
3536
3537         Expand font-weight and font-stretch to take any number
3538         https://bugs.webkit.org/show_bug.cgi?id=168889
3539
3540         Reviewed by Simon Fraser.
3541
3542         Migrate off old enum types.
3543
3544         * WebKitGraphics.cpp:
3545         (makeFont):
3546
3547 2017-03-02  Sam Weinig  <sam@webkit.org>
3548
3549         Rename htmlediting.h/cpp to Editing.h/cpp
3550         https://bugs.webkit.org/show_bug.cgi?id=169103
3551
3552         Reviewed by Alex Christensen.
3553
3554         * AccessibleTextImpl.cpp:
3555
3556 2017-03-01  Alex Christensen  <achristensen@webkit.org>
3557
3558         Actually fix Windows build.
3559
3560         * WebFrame.cpp:
3561         (WebFrame::invalidate):
3562         r213266 changed Style::Force to ResolveStyleType::Rebuild, so I did so here.
3563
3564 2017-03-01  Alex Christensen  <achristensen@webkit.org>
3565
3566         Fix Windows build after r213266
3567         https://bugs.webkit.org/show_bug.cgi?id=169049
3568
3569         * WebFrame.cpp:
3570         (WebFrame::invalidate):
3571
3572 2017-02-27  Per Arne Vollan  <pvollan@apple.com>
3573
3574         [Win] Http preload tests are failing.
3575         https://bugs.webkit.org/show_bug.cgi?id=168910
3576
3577         Reviewed by Alex Christensen.
3578
3579         The feature is not enabled.
3580
3581         * WebView.cpp:
3582         (WebView::notifyPreferencesChanged):
3583
3584 2017-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3585
3586         Better handle Thread and RunLoop initialization
3587         https://bugs.webkit.org/show_bug.cgi?id=167828
3588
3589         Reviewed by Yusuke Suzuki.
3590
3591         Remove unnecessary call to WTF::initializeMainThread().
3592
3593         * WebView.cpp:
3594         (WebView::WebView):
3595
3596 2017-02-20  Per Arne Vollan  <pvollan@apple.com>
3597
3598         [Win] Custom scale factor is not applied in all cases.
3599         https://bugs.webkit.org/show_bug.cgi?id=168117
3600
3601         Reviewed by Brent Fulgham.
3602
3603         We should not call the function deviceScaleFactorForWindow directly, since this
3604         will return the system scale factor, and ignore the custom scale factor.
3605
3606         * WebView.cpp:
3607         (WebView::handleContextMenuEvent):
3608         (WebView::handleMouseEvent):
3609         (WebView::setAcceleratedCompositing):
3610
3611 2017-02-16  Daniel Bates  <dabates@apple.com>
3612
3613         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
3614         https://bugs.webkit.org/show_bug.cgi?id=168417
3615         <rdar://problem/30541748>
3616
3617         Reviewed by Brent Fulgham.
3618
3619         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
3620         Widget* as it is always called with a valid Widget.
3621
3622         * WebCoreSupport/WebFrameLoaderClient.cpp:
3623         (WebFrameLoaderClient::redirectDataToPlugin):
3624         * WebCoreSupport/WebFrameLoaderClient.h:
3625
3626 2017-02-15  Anders Carlsson  <andersca@apple.com>
3627
3628         Another attempt at fixing the Windows build.
3629
3630         * WebCoreSupport/WebDragClient.cpp:
3631         (WebDragClient::startDrag):
3632
3633 2017-02-15  Anders Carlsson  <andersca@apple.com>
3634
3635         Try to fix the Windows build.
3636
3637         * WebCoreSupport/WebDragClient.h:
3638
3639 2017-02-15  Anders Carlsson  <andersca@apple.com>
3640
3641         Modernize DragClient::startDrag somewhat
3642         https://bugs.webkit.org/show_bug.cgi?id=168379
3643
3644         Reviewed by Tim Horton.
3645
3646         Update for WebCore changes.
3647
3648         * WebCoreSupport/WebDragClient.cpp:
3649         (WebDragClient::startDrag):
3650
3651 2017-02-10  Daniel Bates  <dabates@apple.com>
3652
3653         Attempt to fix the WinCairo 64-Bit Release build following <https://trac.webkit.org/changeset/212173>
3654         (https://bugs.webkit.org/show_bug.cgi?id=166774)
3655
3656         Touch WebKit.idl in the hopes that it will cause CMake to regenerate the COM interface files.
3657
3658         * Interfaces/WebKit.idl:
3659
3660 2017-02-10  Daniel Bates  <dabates@apple.com>
3661
3662         Detach frame from document when entering page cache
3663         https://bugs.webkit.org/show_bug.cgi?id=166774
3664         <rdar://problem/29904368>
3665
3666         Reviewed by Chris Dumez.
3667
3668         * Interfaces/IWebPreferencesPrivate.idl:
3669         * WebPreferenceKeysPrivate.h:
3670         * WebPreferences.cpp:
3671         (WebPreferences::initializeDefaultSettings):
3672         (WebPreferences::setAllowsPageCacheWithWindowOpener): Deleted.
3673         (WebPreferences::allowsPageCacheWithWindowOpener): Deleted.
3674         * WebPreferences.h:
3675         * WebView.cpp:
3676         (WebView::notifyPreferencesChanged):
3677
3678 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
3679
3680         [Resource Timing] Enable Resource Timing by default in Tests
3681         https://bugs.webkit.org/show_bug.cgi?id=168145
3682
3683         Reviewed by Ryosuke Niwa.
3684
3685         * Interfaces/IWebPreferencesPrivate.idl:
3686         * WebPreferenceKeysPrivate.h:
3687         * WebPreferences.cpp:
3688         (WebPreferences::initializeDefaultSettings):
3689         (WebPreferences::setResourceTimingEnabled):
3690         (WebPreferences::resourceTimingEnabled):
3691         * WebPreferences.h:
3692         * WebView.cpp:
3693         (WebView::notifyPreferencesChanged):
3694
3695 2017-02-06  Alex Christensen  <achristensen@webkit.org>
3696
3697         More build fixes after r211751
3698         https://bugs.webkit.org/show_bug.cgi?id=166998
3699
3700         * WebDownloadCFNet.cpp:
3701         (WebDownload::didReceiveAuthenticationChallenge):
3702
3703 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3704
3705         Rename AnimationController to CSSAnimationController
3706         https://bugs.webkit.org/show_bug.cgi?id=167829
3707
3708         Reviewed by Simon Fraser.
3709
3710         * WebFrame.cpp:
3711
3712 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3713
3714         Drag images should be anchored to the mouse location
3715         https://bugs.webkit.org/show_bug.cgi?id=167690
3716         <rdar://problem/30295261>
3717
3718         Reviewed by Enrica Casucci.
3719
3720         Adds some plumbing for the anchor point in the WK1 client layer.
3721
3722         * WebCoreSupport/WebDragClient.cpp:
3723         (WebDragClient::startDrag):
3724         * WebCoreSupport/WebDragClient.h:
3725
3726 2017-02-02  Per Arne Vollan  <pvollan@apple.com>
3727
3728         [Win][HiDPI] Scale factor is applied twice in accelerated compositing mode.
3729         https://bugs.webkit.org/show_bug.cgi?id=167732
3730
3731         Reviewed by Brent Fulgham.
3732
3733         Backing layer should not be scaled when CACFLayerSetContentsScale is used for scaling.
3734
3735         * WebView.cpp:
3736         (WebView::setAcceleratedCompositing):
3737
3738 2017-02-02  Chris Dumez  <cdumez@apple.com>
3739
3740         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
3741         https://bugs.webkit.org/show_bug.cgi?id=167738
3742         <rdar://problem/30229990>
3743
3744         Reviewed by Andreas Kling.
3745
3746         The BackForwardClient no longer needs to worry about removing HistoryItems
3747         from the PageCache now that WebCore takes care of it.
3748
3749         * BackForwardList.cpp:
3750         (BackForwardList::close):
3751
3752 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
3753
3754         Add Link Preload as an off-by-default experimental feature menu item.
3755         https://bugs.webkit.org/show_bug.cgi?id=167201
3756
3757         Reviewed by Ryosuke Niwa.
3758
3759         * WebPreferenceKeysPrivate.h:
3760         * WebPreferences.cpp:
3761         (WebPreferences::initializeDefaultSettings):
3762         (WebPreferences::valueForKey):
3763         (WebPreferences::setLinkPreloadEnabled):
3764         (WebPreferences::linkPreloadEnabled):
3765         * WebPreferences.h:
3766         * Interfaces/IWebPreferencesPrivate.idl:
3767
3768 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
3769
3770         Add User Timing Experimental Feature
3771         https://bugs.webkit.org/show_bug.cgi?id=167542
3772         <rdar://problem/22746307>
3773
3774         Reviewed by Ryosuke Niwa.
3775
3776         * Interfaces/IWebPreferencesPrivate.idl:
3777         * WebPreferenceKeysPrivate.h:
3778         * WebPreferences.cpp:
3779         (WebPreferences::initializeDefaultSettings):
3780         (WebPreferences::setUserTimingEnabled):
3781         (WebPreferences::userTimingEnabled):
3782         * WebPreferences.h:
3783         * WebView.cpp:
3784         (WebView::notifyPreferencesChanged):
3785         Add setting for User Timing runtime enabled feature.
3786
3787 2017-01-26  Chris Dumez  <cdumez@apple.com>
3788
3789         Crash when navigating back to a page in PacheCache when one of its frames has been removed
3790         https://bugs.webkit.org/show_bug.cgi?id=167421
3791         <rdar://problem/30188490>
3792
3793         Reviewed by Darin Adler.
3794
3795         Add a new setting allowing layout tests to enable PageCache in a window
3796         that has an opener, for convenience.
3797
3798         * WebPreferenceKeysPrivate.h:
3799         * WebPreferences.cpp:
3800         (WebPreferences::initializeDefaultSettings):
3801         * WebPreferences.h:
3802
3803 2017-01-26  Keith Miller  <keith_miller@apple.com>
3804
3805         classInfo should take a VM so it is not materialized from the object on each call
3806         https://bugs.webkit.org/show_bug.cgi?id=167424
3807
3808         Rubber Stamped by Michael Saboff.
3809
3810         Previously, classInfo() would get the VM from the target's
3811         MarkedBlock.  Most callers already have a VM on hand, so it is
3812         wasteful to compute the VM from the marked block every time. This
3813         patch refactors some of the most common callers of classInfo(),
3814         jsDynamicCast and inherits to take a VM as well.
3815
3816         * WebFrame.cpp:
3817         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
3818         * WebView.cpp:
3819         (WebView::elementFromJS):
3820
3821 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
3822
3823         Crash when setting custom scale factor.
3824         https://bugs.webkit.org/show_bug.cgi?id=167369
3825
3826         Reviewed by Sam Weinig.
3827
3828         Add null pointer check.
3829
3830         * WebView.cpp:
3831         (WebView::setCustomBackingScaleFactor):
3832
3833 2017-01-24  Youenn Fablet  <youennf@gmail.com>
3834
3835         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
3836         https://bugs.webkit.org/show_bug.cgi?id=167294
3837
3838         Reviewed by Alex Christensen.
3839
3840         * WebView.cpp:
3841         (WebView::initWithFrame):
3842
3843 2017-01-23  Chris Dumez  <cdumez@apple.com>
3844
3845         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
3846         https://bugs.webkit.org/show_bug.cgi?id=167308
3847         <rdar://problem/30144964>
3848
3849         Unreviewed, do a partial revert of r211033 to fix assertion.
3850
3851         * WebCoreSupport/WebChromeClient.cpp:
3852         (WebChromeClient::exitFullScreenForElement):
3853
3854 2017-01-20  Darin Adler  <darin@apple.com>
3855
3856         Remove PassRefPtr from "page" directory of WebCore, also deploy references
3857         https://bugs.webkit.org/show_bug.cgi?id=167224
3858
3859         Reviewed by Chris Dumez.
3860
3861         * Plugins/PluginView.cpp:
3862         (WebCore::PluginView::status): Pass reference.
3863         (WebCore::PluginView::focusPluginElement): Ditto.
3864
3865         * WebCoreSupport/WebChromeClient.cpp:
3866         (WebChromeClient::createWindow): Updated for change to ChromeClient.
3867         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
3868         (WebChromeClient::runJavaScriptAlert): Ditto.
3869         (WebChromeClient::runJavaScriptConfirm): Ditto.
3870         (WebChromeClient::runJavaScriptPrompt): Ditto.
3871         (WebChromeClient::contentsSizeChanged): Ditto.
3872         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
3873         (WebChromeClient::print): Ditto.
3874         (WebChromeClient::exceededDatabaseQuota): Ditto.
3875         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
3876         (WebChromeClient::attachRootGraphicsLayer): Ditto.
3877         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
3878         (WebChromeClient::enterVideoFullscreenForVideoElement): Ditto.
3879         (WebChromeClient::createPopupMenu): Ditto.
3880         (WebChromeClient::createSearchPopupMenu): Ditto.
3881         (WebChromeClient::supportsFullScreenForElement): Ditto.
3882         (WebChromeClient::enterFullScreenForElement): Ditto.
3883         (WebChromeClient::exitFullScreenForElement): Ditto.
3884         (WebChromeClient::shouldUseTiledBackingForFrameView): Ditto.
3885         * WebCoreSupport/WebChromeClient.h: Ditto.
3886
3887 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3888
3889         Remove never changing IndexedDB RuntimeEnabledFeature
3890         https://bugs.webkit.org/show_bug.cgi?id=167278
3891
3892         Reviewed by Darin Adler.
3893
3894         * WebView.cpp:
3895         (WebView::notifyPreferencesChanged):
3896
3897 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3898
3899         Cleanup RuntimeEnabledFeatures
3900         https://bugs.webkit.org/show_bug.cgi?id=167228
3901
3902         Reviewed by Simon Fraser.
3903
3904         * WebView.cpp:
3905         (WebView::notifyPreferencesChanged):
3906
3907 2017-01-20  Alex Christensen  <achristensen@webkit.org>
3908
3909         Build Fix for Windows DumpRenderTree after r210976
3910         https://bugs.webkit.org/show_bug.cgi?id=167115
3911
3912         * WebPreferences.h:
3913         Remove extra space.
3914         * IWebPreferencesPrivate.idl:
3915         Add new interface functions.
3916         * WebView.cpp:
3917         We use new functions that are only in IWebPreferencesPrivate4,
3918         so instantiate that COM object instead of version 3.
3919
3920 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3921
3922         Build Fix for Windows DumpRenderTree after r210976
3923
3924         * WebPreferenceKeysPrivate.h:
3925         * WebPreferences.cpp:
3926         (WebPreferences::initializeDefaultSettings):
3927         (WebPreferences::setWebAnimationsEnabled):
3928         (WebPreferences::webAnimationsEnabled):
3929         * WebPreferences.h:
3930         * WebView.cpp:
3931         Add toggle APIs for WebAnimations.
3932
3933 2017-01-19  Chris Dumez  <cdumez@apple.com>
3934
3935         iterable<> should be enabled on WK1
3936         https://bugs.webkit.org/show_bug.cgi?id=167221
3937         <rdar://problem/30108531>
3938
3939         Reviewed by Youenn Fablet.
3940
3941         * Interfaces/IWebPreferencesPrivate.idl:
3942         * WebPreferenceKeysPrivate.h:
3943         * WebPreferences.cpp:
3944         (WebPreferences::setDOMIteratorEnabled): Deleted.
3945         (WebPreferences::domIteratorEnabled): Deleted.
3946         * WebPreferences.h:
3947         * WebView.cpp:
3948         (WebView::notifyPreferencesChanged):
3949
3950 2017-01-18  Alex Christensen  <achristensen@webkit.org>
3951
3952         Fix WinCairo build after r210845.
3953         https://bugs.webkit.org/show_bug.cgi?id=167055
3954
3955         * WebCoreSupport/WebFrameLoaderClient.cpp:
3956         * WebCoreSupport/WebFrameLoaderClient.h:
3957         shouldCacheResponse isn't used when loading with libcurl.
3958         It was dead code before Darin added "override".
3959         WebCore/FrameLoaderClient.h has this inside of USE(CFURLCONNECTION) macros, now we have them here, too.
3960
3961 2017-01-18  Andreas Kling  <akling@apple.com>
3962
3963         Document::securityOrigin() should return a reference.
3964         <https://webkit.org/b/167124>
3965
3966         Reviewed by Sam Weinig.
3967
3968         * Plugins/PluginView.cpp:
3969         (WebCore::PluginView::load):
3970         * WebCoreSupport/WebChromeClient.cpp:
3971         (WebChromeClient::exceededDatabaseQuota):
3972         * WebCoreSupport/WebFrameLoaderClient.cpp:
3973         (WebFrameLoaderClient::didRunInsecureContent):
3974         * WebCoreSupport/WebFrameLoaderClient.h:
3975         * WebCoreSupport/WebGeolocationClient.cpp:
3976         (WebGeolocationClient::requestPermission):
3977         * WebFrame.cpp:
3978         (WebFrame::allowsFollowingLink):
3979
3980 2017-01-15  Darin Adler  <darin@apple.com>
3981
3982         Remove PassRefPtr from "loader" directory of WebCore
3983         https://bugs.webkit.org/show_bug.cgi?id=167055
3984
3985         Reviewed by Alex Christensen.
3986
3987         * Plugins/PluginView.cpp:
3988         (WebCore::PluginView::mediaCanStart): Fix call to dispatchDidFailToStartPlugin
3989         by calling it directly on WebFrameLoaderClient. If my theory is correct, the old
3990         call has been broken and doing nothing since r177941, two years ago, which made
3991         the argument types different between FrameLoaderClient and WebFrameLoaderClient,
3992         leaving WebFrameLoaderClient::dispatchDidFailToStartPlugin as dead code.
3993
3994         * WebCoreSupport/WebChromeClient.cpp:
3995         (WebChromeClient::runOpenPanel): Updated for change to ChromeClient.
3996         * WebCoreSupport/WebChromeClient.h: Ditto.
3997
3998         * WebCoreSupport/WebEditorClient.cpp:
3999         (WebEditorUndoCommand::WebEditorUndoCommand): Take a reference instead of
4000         a PassRefPtr. Also use Ref instead of RefPtr.
4001         (WebEditorClient::shouldChangeTypingStyle): Deleted. Empty function that was
4002         never called.
4003         (WebEditorClient::webViewDidChangeTypingStyle): Ditto.
4004         (WebEditorClient::webViewDidChangeSelection): Ditto.
4005         (WebEditorClient::registerUndoStep):  Take reference instead of PassRefPtr.
4006         (WebEditorClient::registerRedoStep): Ditto.
4007         * WebCoreSupport/WebEditorClient.h: Updated for the above. Also marked the
4008         class and member functions final and made them all private, which will
4009         help us catch if there are any that don't correctly match WebCore.
4010
4011         * WebCoreSupport/WebFrameLoaderClient.cpp:
4012         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Updated
4013         for change to ChromeClient.
4014         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
4015         (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Ditto.
4016         (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto.
4017         (WebFrameLoaderClient::createFrame): Ditto. Also merged two functions into
4018         one because one was private and only called by the other.
4019         (WebFrameLoaderClient::createPlugin): Ditto.
4020         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
4021         (WebFrameLoaderClient::createNetworkingContext): Ditto.
4022         * WebCoreSupport/WebFrameLoaderClient.h: Ditto.
4023
4024         * WebCoreSupport/WebFrameNetworkingContext.h:
4025         (WebFrameNetworkingContext::create): Return a Ref instead of a PassRefPtr.
4026
4027 2017-01-12  Joseph Pecoraro  <pecoraro@apple.com>
4028
4029         Remove unnecessary includes of Page.h
4030         https://bugs.webkit.org/show_bug.cgi?id=166996
4031
4032         Reviewed by Yusuke Suzuki.
4033
4034         * AccessibleTextImpl.cpp:
4035         * BackForwardList.cpp:
4036
4037 2017-01-06  Darin Adler  <darin@apple.com>
4038
4039         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
4040         https://bugs.webkit.org/show_bug.cgi?id=166797
4041
4042         Reviewed by Alex Christensen.
4043
4044         * WebCoreSupport/WebEditorClient.h: Update argument to take a reference
4045         instead of a PassRefPtr.
4046
4047 2017-01-05  Andreas Kling  <akling@apple.com>
4048
4049         Remove ChromeClient::needTouchEvents().
4050         <https://webkit.org/b/166723>
4051
4052         Rubber-stamped by Antti Koivisto.
4053
4054         * WebCoreSupport/WebChromeClient.h:
4055
4056 2017-01-04  Darin Adler  <darin@apple.com>
4057
4058         Remove PassRefPtr use from the "html" directory, other improvements
4059         https://bugs.webkit.org/show_bug.cgi?id=166635
4060
4061         Reviewed by Alex Christensen.
4062
4063         * WebCoreSupport/WebChromeClient.cpp:
4064         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
4065         * WebCoreSupport/WebChromeClient.h: Updated for the above.
4066
4067 2016-12-30  Darin Adler  <darin@apple.com>
4068
4069         Remove PassRefPtr use from the "dom" directory, related cleanup
4070         https://bugs.webkit.org/show_bug.cgi?id=166569
4071
4072         Reviewed by Alex Christensen.
4073
4074         * WebCoreSupport/WebFrameLoaderClient.cpp:
4075         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated since StringWithDirection::title
4076         is now a data member, not a function member.
4077         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
4078         (WebFrameLoaderClient::setTitle): Ditto.
4079         * WebDataSource.cpp:
4080         (WebDataSource::pageTitle): Ditto.
4081
4082 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
4083
4084         Propagate the source origin as much as possible
4085         https://bugs.webkit.org/show_bug.cgi?id=166348
4086
4087         Reviewed by Darin Adler.
4088
4089         * Plugins/PluginPackage.cpp:
4090         (WebCore::NPN_Evaluate):
4091         (WebCore::makeSource): Deleted.
4092
4093 2016-12-22  Andy Estes  <aestes@apple.com>
4094
4095         Make WebCore::EditorInsertAction an enum class
4096         https://bugs.webkit.org/show_bug.cgi?id=166424
4097
4098         Reviewed by Brent Fulgham.
4099
4100         * WebCoreSupport/WebEditorClient.cpp:
4101         (kit):
4102         (WebEditorClient::shouldInsertNode):
4103         (WebEditorClient::shouldInsertText):
4104
4105 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
4106
4107         [ES6] Enable ES6 Modules
4108         https://bugs.webkit.org/show_bug.cgi?id=165849
4109
4110         Reviewed by Geoffrey Garen.
4111
4112         * Interfaces/IWebPreferencesPrivate.idl:
4113         * WebPreferenceKeysPrivate.h:
4114         * WebPreferences.cpp:
4115         (WebPreferences::setES6ModulesEnabled): Deleted.
4116         (WebPreferences::es6ModulesEnabled): Deleted.
4117         * WebPreferences.h:
4118         * WebView.cpp:
4119         (WebView::notifyPreferencesChanged):
4120
4121 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
4122
4123         The DOM should have an advancing wavefront opaque root barrier
4124         https://bugs.webkit.org/show_bug.cgi?id=165712
4125
4126         Reviewed by Yusuke Suzuki.
4127         
4128         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
4129
4130         * Plugins/PluginView.cpp:
4131         (WebCore::PluginView::start):
4132         (WebCore::PluginView::stop):
4133         (WebCore::PluginView::performRequest):
4134         (WebCore::PluginView::npObject):
4135         (WebCore::PluginView::privateBrowsingStateChanged):
4136         * Plugins/PluginViewWin.cpp:
4137         (WebCore::PluginView::dispatchNPEvent):
4138         (WebCore::PluginView::handleKeyboardEvent):
4139         (WebCore::PluginView::handleMouseEvent):
4140         (WebCore::PluginView::setNPWindowRect):
4141         * WebCoreStatistics.cpp:
4142         (WebCoreStatistics::javaScriptObjectsCount):
4143         (WebCoreStatistics::javaScriptGlobalObjectsCount):
4144         (WebCoreStatistics::javaScriptProtectedObjectsCount):
4145         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
4146         (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
4147         (WebCoreStatistics::javaScriptObjectTypeCounts):
4148         (WebCoreStatistics::shouldPrintExceptions):
4149         (WebCoreStatistics::setShouldPrintExceptions):
4150         (WebCoreStatistics::memoryStatistics):
4151         * WebJavaScriptCollector.cpp:
4152         (WebJavaScriptCollector::objectCount):
4153
4154 2016-12-09  Geoffrey Garen  <ggaren@apple.com>
4155
4156         TextPosition and OrdinalNumber should be more like idiomatic numbers
4157         https://bugs.webkit.org/show_bug.cgi?id=165678
4158