Standardize on ControlKey instead of CtrlKey
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2019-02-06  Daniel Bates  <dabates@apple.com>
2
3         Standardize on ControlKey instead of CtrlKey
4         https://bugs.webkit.org/show_bug.cgi?id=194317
5
6         Reviewed by Tim Horton.
7
8         * AccessibleBase.cpp:
9         (AccessibleBase::get_accKeyboardShortcut):
10         * WebView.cpp:
11         (WebView::keyDown):
12
13 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
14
15         PageOverlayController's layers should be created lazily
16         https://bugs.webkit.org/show_bug.cgi?id=194199
17         rdar://problem/46571593
18
19         Reviewed by Tim Horton.
20
21         Expose PageOverlayController::hasDocumentOverlays() and hasViewOverlays()
22         and use them to only parent the overlay-hosting layers when necessary.
23
24         For document overlays, RenderLayerCompositor::appendDocumentOverlayLayers() can
25         simply do nothing if there are none. Updates are triggered via Page::installedPageOverlaysChanged(),
26         which calls FrameView::setNeedsCompositingConfigurationUpdate() to trigger the root layer
27         compositing updates that parents the layerWithDocumentOverlays().
28
29         View overlays are added to the layer tree via the DrawingArea. When we go between having
30         none and some view overlays, Page::installedPageOverlaysChanged() calls attachViewOverlayGraphicsLayer()
31         on the ChromeClient, and the DrawingArea responds by calling updateRootLayers() and scheduling a
32         compositing flush (this has to be done manually because view overlay layers are outside the
33         subtree managed by RenderLayerCompositor).
34         
35         Now that GraphicsLayers are ref-counted, we can let the DrawingArea simply retain its m_viewOverlayRootLayer;
36         there is no need for RenderLayerCompositor::attachRootLayer()/detachRootLayer() to do anything with view
37         overlay layers. This implies that a page can navigate (new FrameView) and view overlays will persist, without
38         having to be manually removed and re-added. We can also remove the Frame argument to attachViewOverlayGraphicsLayer().
39
40         * WebCoreSupport/WebChromeClient.cpp:
41         (WebChromeClient::attachViewOverlayGraphicsLayer):
42         * WebCoreSupport/WebChromeClient.h:
43
44 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
45
46         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
47         https://bugs.webkit.org/show_bug.cgi?id=194189
48
49         Reviewed by Geoffrey Garen.
50
51         Pass the policy check identifier around functions and store it in WebFramePolicyListener
52         so that we can send it back to WebCore with the navigation policy decision.
53
54         * WebCoreSupport/WebFrameLoaderClient.cpp:
55         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
56         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
57         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
58         (WebFrameLoaderClient::dispatchWillSubmitForm):
59         (WebFrameLoaderClient::setUpPolicyListener):
60         * WebCoreSupport/WebFrameLoaderClient.h:
61
62 2019-01-31  Alex Christensen  <achristensen@webkit.org>
63
64         Revert r238819 which is unneeded and caused a performance regression.
65         https://bugs.webkit.org/show_bug.cgi?id=192272
66         <rdar://problem/46664625>
67
68         * WebCoreSupport/WebFrameLoaderClient.cpp:
69         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
70         * WebCoreSupport/WebFrameLoaderClient.h:
71
72 2019-01-31  Takashi Komori  <Takashi.Komori@sony.com>
73
74         [Curl] Fix DRT crash related to private browsing.
75         https://bugs.webkit.org/show_bug.cgi?id=193816
76
77         Reviewed by Alex Christensen.
78
79         * WebCoreSupport/WebFrameNetworkingContext.cpp:
80         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
81
82 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
83
84         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
85         https://bugs.webkit.org/show_bug.cgi?id=193941
86
87         Reviewed by Alex Christensen.
88
89         * Plugins/PluginMessageThrottlerWin.cpp:
90         * Plugins/PluginView.cpp:
91         * Plugins/PluginViewWin.cpp:
92
93 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
94
95         Move FileSystem to WTF
96         https://bugs.webkit.org/show_bug.cgi?id=193602
97
98         Reviewed by Yusuke Suzuki.
99
100         * Plugins/PluginDatabase.cpp:
101         * Plugins/PluginPackage.h:
102         * Plugins/PluginStream.h:
103         * WebApplicationCache.cpp:
104         * WebDatabaseManager.cpp:
105         * WebDownloadCurl.cpp:
106         * WebPreferences.cpp:
107         * WebView.cpp:
108
109 2019-01-22  Alex Christensen  <achristensen@webkit.org>
110
111         Move NetworkStorageSession ownership to NetworkProcess
112         https://bugs.webkit.org/show_bug.cgi?id=193580
113
114         Reviewed by Geoff Garen.
115
116         * WebCoreSupport/WebFrameNetworkingContext.cpp:
117         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
118         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
119         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
120         (WebFrameNetworkingContext::storageSession const):
121         * WebDownloadCFNet.cpp:
122         (WebDownload::didReceiveAuthenticationChallenge):
123         * WebPreferences.cpp:
124         (WebPreferences::clearNetworkLoaderSession):
125         (WebPreferences::switchNetworkLoaderToNewTestingSession):
126
127 2019-01-15  Darin Adler  <darin@apple.com>
128
129         Use references rather than pointers for register/unregister functions, and more
130         https://bugs.webkit.org/show_bug.cgi?id=175028
131
132         Reviewed by Daniel Bates.
133
134         * Plugins/PluginView.cpp:
135         (WebCore::PluginView::startOrAddToUnstartedList): Pass a reference.
136         (WebCore::PluginView::~PluginView): Ditto.
137         * WebView.cpp:
138         (WebView::fullScreenClientWillEnterFullScreen): Ditto.
139         (WebView::fullScreenClientDidEnterFullScreen): Ditto.
140         (WebView::fullScreenClientDidExitFullScreen): Ditto.
141
142 2019-01-17  Per Arne Vollan  <pvollan@apple.com>
143
144         [Win][HighDPI] Repaint glitches when scrolling.
145         https://bugs.webkit.org/show_bug.cgi?id=173152
146         <rdar://problem/45269953>
147
148         Reviewed by Brent Fulgham.
149
150         Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
151         delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
152         Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
153
154         * WebView.cpp:
155         (WebView::scrollBackingStore):
156
157 2019-01-17  Alex Christensen  <achristensen@webkit.org>
158
159         Stop using NetworkStorageSession::storageSession in WebCore
160         https://bugs.webkit.org/show_bug.cgi?id=193529
161
162         Reviewed by Tim Horton.
163
164         * WebView.cpp:
165         (WebView::initWithFrame):
166
167 2019-01-15  Alex Christensen  <achristensen@webkit.org>
168
169         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
170         https://bugs.webkit.org/show_bug.cgi?id=193368
171
172         Reviewed by Geoff Garen.
173
174         * WebDownloadCFNet.cpp:
175         (WebDownload::didReceiveAuthenticationChallenge):
176
177 2019-01-15  Alex Christensen  <achristensen@webkit.org>
178
179         Fix Windows build after r240014
180         https://bugs.webkit.org/show_bug.cgi?id=161106
181
182         * WebView.cpp:
183
184 2019-01-15  Alex Christensen  <achristensen@webkit.org>
185
186         Stop using CookiesStrategy
187         https://bugs.webkit.org/show_bug.cgi?id=161106
188
189         Reviewed by Don Olmstead and Antti Koivisto.
190
191         * Plugins/PluginView.cpp:
192         (WebCore::PluginView::getValueForURL):
193         (WebCore::PluginView::setValueForURL):
194         * WebCoreSupport/WebPlatformStrategies.cpp:
195         (WebPlatformStrategies::createBlobRegistry):
196         (WebPlatformStrategies::createCookiesStrategy): Deleted.
197         (WebPlatformStrategies::cookiesForDOM): Deleted.
198         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
199         (WebPlatformStrategies::cookiesEnabled): Deleted.
200         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
201         (WebPlatformStrategies::getRawCookies): Deleted.
202         (WebPlatformStrategies::deleteCookie): Deleted.
203         * WebCoreSupport/WebPlatformStrategies.h:
204         * WebView.cpp:
205         (WebView::initWithFrame):
206
207 2019-01-08  Alex Christensen  <achristensen@webkit.org>
208
209         Stop using NetworkStorageSession in WebProcess
210         https://bugs.webkit.org/show_bug.cgi?id=193236
211
212         Reviewed by Don Olmstead.
213
214         * WebCoreSupport/WebFrameNetworkingContext.cpp:
215         (WebFrameNetworkingContext::storageSession const):
216         * WebCoreSupport/WebFrameNetworkingContext.h:
217         * WebCoreSupport/WebPlatformStrategies.cpp:
218         (WebPlatformStrategies::cookiesForDOM):
219         (WebPlatformStrategies::setCookiesFromDOM):
220         (WebPlatformStrategies::cookiesEnabled):
221         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
222         (WebPlatformStrategies::getRawCookies):
223         (WebPlatformStrategies::deleteCookie):
224         * WebCoreSupport/WebPlatformStrategies.h:
225
226 2019-01-08  Alex Christensen  <achristensen@webkit.org>
227
228         Unreviewed, rolling out r239727.
229
230         Broke API tests
231
232         Reverted changeset:
233
234         "Stop using NetworkStorageSession in WebProcess"
235         https://bugs.webkit.org/show_bug.cgi?id=193236
236         https://trac.webkit.org/changeset/239727
237
238 2018-12-24  Fujii Hironori  <Hironori.Fujii@sony.com>
239
240         Remove "using namespace std;"
241         https://bugs.webkit.org/show_bug.cgi?id=192973
242
243         Reviewed by Alex Christensen.
244
245         * FullscreenVideoController.cpp:
246         * WebFrame.cpp:
247         (WebFrame::drawFooter):
248         * WebHistory.cpp:
249         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
250         * WebKitQuartzCoreAdditions/CAView.cpp:
251         * WebView.cpp:
252         (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
253         (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
254         (WebView::setCacheModel):
255         (WebView::maxCacheModelInAnyInstance):
256
257 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
258
259         Use Ref<> as much as possible
260         https://bugs.webkit.org/show_bug.cgi?id=192808
261
262         Reviewed by Alex Christensen.
263
264         * Plugins/PluginDatabase.cpp:
265         (WebCore::PluginDatabase::refresh):
266         * Plugins/PluginView.cpp:
267         (WebCore::PluginView::mediaCanStart):
268         (WebCore::PluginView::performRequest):
269         (WebCore::PluginView::bindingInstance):
270         * Plugins/PluginView.h:
271         * WebCoreSupport/WebFrameLoaderClient.cpp:
272         (WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
273         (WebFrameLoaderClient::createPlugin):
274         (WebFrameLoaderClient::createJavaAppletWidget):
275         * WebCoreSupport/WebFrameLoaderClient.h:
276         * WebFrame.cpp:
277         (WebFrame::loadData):
278         (WebFrame::loadPlainTextString):
279         (WebFrame::loadHTMLString):
280         * WebFrame.h:
281         * WebKitQuartzCoreAdditions/CAView.cpp:
282         (WKQCA::CAView::create):
283         * WebKitQuartzCoreAdditions/CAView.h:
284         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
285         (WKQCA::CVDisplayLink::create):
286         * WebKitQuartzCoreAdditions/CVDisplayLink.h:
287         * WebKitQuartzCoreAdditions/ImageConversion.cpp:
288         (WKQCA::getImageCopy):
289         * WebView.cpp:
290         (WebView::addUserScriptToGroup):
291         (WebView::addUserStyleSheetToGroup):
292
293 2018-12-20  Chris Dumez  <cdumez@apple.com>
294
295         Use Optional::valueOr() instead of Optional::value_or()
296         https://bugs.webkit.org/show_bug.cgi?id=192933
297
298         Reviewed by Geoffrey Garen.
299
300         * WebSecurityOrigin.cpp:
301         (WebSecurityOrigin::port):
302
303 2018-12-19  Chris Dumez  <cdumez@apple.com>
304
305         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
306         https://bugs.webkit.org/show_bug.cgi?id=192728
307         <rdar://problem/46746779>
308
309         Reviewed by Geoff Garen.
310
311         * Plugins/*:
312         * WebCoreSupport/*:
313
314 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
315
316         [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag
317         https://bugs.webkit.org/show_bug.cgi?id=192617
318
319         Reviewed by Alex Christensen.
320
321         * COMEnumVariant.h:
322         (COMEnumVariant<ContainerType>::adopt): Removed 'typename' from non dependent names.
323         (COMEnumVariant<ContainerType>::createInstance): Ditto.
324         (COMEnumVariant<ContainerType>::Next): Prepend 'typename' for dependent names.
325         * COMPropertyBag.h:
326         (HashType>::createInstance): Removed 'typename' from non dependent names.
327         (HashType>::adopt): Ditto.
328         (HashType>::Read): Replaced dependent name 'HashMapType::const_iterator' with 'auto'.
329         (HashType>::GetPropertyInfo): Ditto.
330
331 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
332
333         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
334         https://bugs.webkit.org/show_bug.cgi?id=192618
335
336         Reviewed by Alex Christensen.
337
338         Classes which implement COM interface usually doesn't need the
339         virtual destructor because it has Release() virtual method to
340         destruct itself.
341
342         Marked 'final' such classes to suppress clang-cl's compilation
343         warnings.
344
345         * COMEnumVariant.h:
346         * COMPropertyBag.h:
347         * DefaultDownloadDelegate.h:
348         * DefaultPolicyDelegate.h:
349         * MemoryStream.h:
350         * WebActionPropertyBag.h:
351         * WebApplicationCache.h:
352         * WebArchive.h:
353         * WebBackForwardList.h:
354         * WebCache.h:
355         * WebCoreStatistics.h:
356         * WebCoreSupport/WebEditorClient.cpp:
357         * WebCoreSupport/WebInspectorDelegate.h:
358         * WebDataSource.h:
359         * WebDatabaseManager.cpp:
360         * WebDatabaseManager.h:
361         * WebDownload.h:
362         * WebDropSource.h:
363         * WebElementPropertyBag.h:
364         * WebError.h:
365         * WebFrame.cpp:
366         * WebFrame.h:
367         * WebFramePolicyListener.h:
368         * WebGeolocationPolicyListener.h:
369         * WebGeolocationPosition.h:
370         * WebHTMLRepresentation.h:
371         * WebHistory.h:
372         * WebHistoryItem.h:
373         * WebInspector.h:
374         * WebJavaScriptCollector.h:
375         * WebKitClassFactory.h:
376         * WebKitMessageLoop.h:
377         * WebKitStatistics.h:
378         * WebMutableURLRequest.h:
379         * WebNavigationData.h:
380         * WebNotification.h:
381         * WebNotificationCenter.h:
382         * WebPreferences.h:
383         * WebResource.h:
384         * WebScriptWorld.h:
385         * WebSecurityOrigin.h:
386         * WebSerializedJSValue.h:
387         * WebTextRenderer.h:
388         * WebURLAuthenticationChallenge.h:
389         * WebURLAuthenticationChallengeSender.h:
390         * WebURLCredential.h:
391         * WebURLProtectionSpace.h:
392         * WebURLResponse.h:
393         * WebUserContentURLPattern.h:
394         * WebView.cpp:
395         * WebView.h:
396         * WebWorkersPrivate.h:
397
398 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
399
400         [Win][Clang] Fix warning -Wmissing-field-initializers
401         https://bugs.webkit.org/show_bug.cgi?id=192584
402
403         Reviewed by Yusuke Suzuki.
404
405         Initialize a struct with '{ }' instead of '= {0}'.
406
407         * WebKitMessageLoop.cpp:
408         (WebKitMessageLoop::run):
409         * WebView.cpp:
410         (WebView::onMenuCommand):
411         (WebView::gesture):
412         (WebView::setShouldInvertColors):
413         (WebView::initializeToolTipWindow):
414         (WebView::setToolTip):
415         (WebView::fullScreenClientForceRepaint):
416
417 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
418
419         Turn WritingDirection into an enum class
420         https://bugs.webkit.org/show_bug.cgi?id=192401
421         Work towards <rdar://problem/42075638>
422
423         Reviewed by Dan Bernstein.
424
425         Change WritingDirection from an enum to an enum class. No change in behavior.
426
427         * WebFrame.cpp:
428         (WebFrame::setTextDirection):
429
430 2018-12-03  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
431
432         Use WallTime for file time
433         https://bugs.webkit.org/show_bug.cgi?id=192287
434
435         Reviewed by Darin Adler.
436
437         * Plugins/PluginDatabase.cpp:
438         (WebCore::PluginDatabase::refresh):
439
440 2018-11-30  Alex Christensen  <achristensen@webkit.org>
441
442         Fix Windows build.
443
444         * WebView.cpp:
445
446 2018-11-30  Alex Christensen  <achristensen@webkit.org>
447
448         Fix Windows build.
449
450         * WebCoreSupport/WebFrameLoaderClient.h:
451
452 2018-11-30  Alex Christensen  <achristensen@webkit.org>
453
454         Fix Windows build.
455
456         * WebCoreSupport/WebFrameLoaderClient.h:
457
458 2018-11-30  Alex Christensen  <achristensen@webkit.org>
459
460         Move URL from WebCore to WTF
461         https://bugs.webkit.org/show_bug.cgi?id=190234
462
463         Reviewed by Keith Miller.
464
465         * MarshallingHelpers.cpp:
466         * MarshallingHelpers.h:
467         * Plugins/PluginDatabase.cpp:
468         * Plugins/PluginDatabase.h:
469         * Plugins/PluginDatabaseWin.cpp:
470         * Plugins/PluginStream.h:
471         * Plugins/PluginView.h:
472         * WebCoreSupport/WebContextMenuClient.h:
473         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
474         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
475         * WebCoreSupport/WebFrameLoaderClient.h:
476         * WebCoreSupport/WebPlatformStrategies.h:
477         * WebCoreSupport/WebPluginInfoProvider.cpp:
478         (WebPluginInfoProvider::webVisiblePluginInfo):
479         * WebCoreSupport/WebPluginInfoProvider.h:
480         * WebCoreSupport/WebVisitedLinkStore.h:
481         * WebDataSource.cpp:
482         * WebDownload.h:
483         * WebElementPropertyBag.cpp:
484         * WebFrame.h:
485         * WebHistory.cpp:
486         * WebHistory.h:
487         * WebHistoryItem.cpp:
488         * WebResource.cpp:
489         (WebResource::WebResource):
490         * WebResource.h:
491         * WebSecurityOrigin.cpp:
492         * WebURLResponse.cpp:
493         (WebURLResponse::createInstance):
494         * WebUserContentURLPattern.cpp:
495         * WebView.h:
496
497 2018-11-28  Alex Christensen  <achristensen@webkit.org>
498
499         Remove dead code from an earlier attempt at implementing safe browsing
500         https://bugs.webkit.org/show_bug.cgi?id=192067
501
502         Reviewed by Chris Dumez.
503
504         * WebCoreSupport/WebFrameLoaderClient.cpp:
505         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
506         * WebCoreSupport/WebFrameLoaderClient.h:
507
508 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
509
510         [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
511         https://bugs.webkit.org/show_bug.cgi?id=191959
512
513         Reviewed by Alex Christensen.
514
515         * MarshallingHelpers.h: Removed extra "MarshallingHelpers::" of windowsEpochAbsoluteTime declaration.
516
517 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
518
519         [Win] Reduce the use of WKSI library calls: CoreAnimation
520         https://bugs.webkit.org/show_bug.cgi?id=191777
521         <rdar://problem/46140542>
522
523         Reviewed by Zalan Bujtas.
524
525         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
526         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
527         directives for WebKitSystemInterface.lib.
528
529         * FullscreenVideoController.cpp:
530         * WebKitGraphics.cpp:
531         * WebPreferences.cpp:
532
533 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
534
535         Address post-review feedback after r238438
536         https://bugs.webkit.org/show_bug.cgi?id=191913
537
538         Reviewed by Ryosuke Niwa.
539
540         * AccessibleTextImpl.cpp:
541         (AccessibleText::replaceText):
542
543 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
544
545         Web Inspector: "Reload Web Inspector" button no longer partially works
546         https://bugs.webkit.org/show_bug.cgi?id=191773
547         <rdar://problem/46139932>
548
549         Reviewed by Devin Rousso.
550
551         * WebCoreSupport/WebInspectorClient.cpp:
552         (WebInspectorFrontendClient::reopen):
553         * WebCoreSupport/WebInspectorClient.h:
554
555 2018-11-17  Devin Rousso  <drousso@apple.com>
556
557         Web Inspector: Network: add button to show system certificate dialog
558         https://bugs.webkit.org/show_bug.cgi?id=191458
559         <rdar://problem/45977019>
560
561         Reviewed by Joseph Pecoraro.
562
563         * WebCoreSupport/WebInspectorClient.h:
564         * WebCoreSupport/WebInspectorClient.cpp:
565         (WebInspectorFrontendClient::showCertificate): Added.
566
567 2018-11-16  Brent Fulgham  <bfulgham@apple.com>
568
569         [Win] Reduce the use of WKSI library calls: CFNetwork
570         https://bugs.webkit.org/show_bug.cgi?id=191718
571         <rdar://problem/46108732>
572
573         Reviewed by Alex Christensen.
574
575         Remove custom WKSI CFNetwork calls, since the SPI is already documented in PAL. Just
576         make the same calls on Windows, like we did for iOS and macOS back in 2017.
577
578         * WebCache.cpp:
579         (WebCache::cacheFolder):
580         * WebCoreSupport/WebFrameNetworkingContext.cpp:
581         * WebCoreSupport/WebPlatformStrategies.cpp:
582         * WebError.cpp:
583         (WebError::localizedDescription):
584         (WebError::sslPeerCertificate):
585         * WebURLResponse.cpp:
586         (WebURLResponse::sslPeerCertificate):
587         (WebURLResponse::certificateDictionary const):
588         * WebView.cpp:
589         (WebView::setCacheModel):
590
591 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
592
593         [Win] Reduce the use of WKSI library calls: Font Handling
594         https://bugs.webkit.org/show_bug.cgi?id=191701
595         <rdar://problem/46104809>
596
597         Reviewed by Myles C. Maxfield.
598
599         Update to use the old font handling routines moved from WKSI to FontCascade.
600
601         * WebPreferences.cpp:
602         (WebPreferences::setFontSmoothing):
603         (WebPreferences::setFontSmoothingContrast):
604         * WebView.cpp:
605         (systemParameterChanged):
606
607 2018-11-14  Timothy Hatcher  <timothy@apple.com>
608
609         Default the view background color and text color to different values when in dark mode.
610         https://bugs.webkit.org/show_bug.cgi?id=191607
611         rdar://problem/46045854
612
613         Reviewed by Dean Jackson.
614
615         * WebFrame.cpp:
616         (WebFrame::updateBackground): Drop backgroundColor.
617         * WebCoreSupport/WebFrameLoaderClient.cpp:
618         (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor.
619
620 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
621
622         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
623         https://bugs.webkit.org/show_bug.cgi?id=191612
624
625         Reviewed by Matt Baker.
626
627         * WebCoreSupport/WebInspectorClient.cpp:
628         (WebInspectorFrontendClient::destroyInspectorView):
629
630 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
631
632         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
633         https://bugs.webkit.org/show_bug.cgi?id=189230
634         <rdar://problem/44050379>
635
636         Reviewed by Joseph Pecoraro.
637
638         Runs all png images through zopflipng. This results in a smaller file
639         size and takes care of this issue as a byproduct.
640
641         * WebKit.resources/deleteButton.png:
642         * WebKit.resources/deleteButtonPressed.png:
643         * WebKit.resources/fsVideoAudioVolumeHigh.png:
644         * WebKit.resources/fsVideoAudioVolumeLow.png:
645         * WebKit.resources/fsVideoExitFullscreen.png:
646         * WebKit.resources/fsVideoPause.png:
647         * WebKit.resources/fsVideoPlay.png:
648         * WebKit.resources/missingImage.png:
649         * WebKit.resources/nullplugin.png:
650         * WebKit.resources/panEastCursor.png:
651         * WebKit.resources/panIcon.png:
652         * WebKit.resources/panNorthCursor.png:
653         * WebKit.resources/panNorthEastCursor.png:
654         * WebKit.resources/panNorthWestCursor.png:
655         * WebKit.resources/panSouthCursor.png:
656         * WebKit.resources/panSouthEastCursor.png:
657         * WebKit.resources/panSouthWestCursor.png:
658         * WebKit.resources/panWestCursor.png:
659         * WebKit.resources/searchCancel.png:
660         * WebKit.resources/searchCancelPressed.png:
661         * WebKit.resources/searchMagnifier.png:
662         * WebKit.resources/searchMagnifierResults.png:
663         * WebKit.resources/textAreaResizeCorner.png:
664         * WebKit.resources/verticalTextCursor.png:
665         * WebKit.resources/zoomInCursor.png:
666         * WebKit.resources/zoomOutCursor.png:
667
668 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
669
670         Unreviewed Windows build fix for r238049.
671
672         * WebView.cpp:
673         (WebView::initWithFrame):
674
675 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
676
677         Unreviewed MSVC build fix after r238039 (and r238046).
678
679         * WebDocumentLoader.h:
680         * WebView.cpp:
681         (WebView::setShouldApplyMacFontAscentHack):
682
683 2018-11-09  Antti Koivisto  <antti@apple.com>
684
685         Use OptionSet for layout milestones
686         https://bugs.webkit.org/show_bug.cgi?id=191470
687
688         Reviewed by Dean Jackson.
689
690         * WebCoreSupport/WebFrameLoaderClient.cpp:
691         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
692         * WebCoreSupport/WebFrameLoaderClient.h:
693
694 2018-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
695
696         WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
697         https://bugs.webkit.org/show_bug.cgi?id=191455
698
699         Reviewed by Brent Fulgham.
700
701         * WebHistory.h: Marked with 'override' and removed 'virtual'.
702
703 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
704
705         Add a storage limit for IndexedDB
706         https://bugs.webkit.org/show_bug.cgi?id=190598
707         <rdar://problem/44654715>
708
709         Reviewed by Chris Dumez.
710
711         * Interfaces/IWebDatabaseManager.idl:
712         * WebDatabaseManager.cpp:
713         (WebDatabaseManager::setIDBPerOriginQuota):
714         * WebDatabaseManager.h:
715
716 2018-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
717
718         [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
719         https://bugs.webkit.org/show_bug.cgi?id=191105
720
721         Reviewed by Brent Fulgham.
722
723         * DOMHTMLClasses.h:
724         (DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
725         instead of own setNodeValue.
726
727 2018-10-25  Antoine Quint  <graouts@apple.com>
728
729         [Web Animations] Turn Web Animations CSS Integration off by default
730         https://bugs.webkit.org/show_bug.cgi?id=190901
731
732         Reviewed by Dean Jackson.
733
734         * WebPreferences.cpp:
735         (WebPreferences::initializeDefaultSettings):
736
737 2018-10-21  Fujii Hironori  <Hironori.Fujii@sony.com>
738
739         [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
740         https://bugs.webkit.org/show_bug.cgi?id=190744
741
742         Reviewed by Alex Christensen.
743
744         clang-cl reports compilation warnings for inconsistent 'override'
745         keyword usage.
746
747         WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
748         This can't be marked 'override' if !USE(CA).
749
750         * WebView.cpp:
751         (WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).
752         * WebView.h: Marked all overriding member function declarations of WebView 'override'.
753         Declare flushPendingGraphicsLayerChanges only if USE(CA).
754
755 2018-10-18  Alex Christensen  <achristensen@webkit.org>
756
757         Clean up FrameLoader two-state enums
758         https://bugs.webkit.org/show_bug.cgi?id=190731
759
760         Reviewed by Chris Dumez.
761
762         * WebCoreSupport/WebFrameLoaderClient.cpp:
763         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
764         * WebCoreSupport/WebFrameLoaderClient.h:
765
766 2018-10-17  Alex Christensen  <achristensen@webkit.org>
767
768         BackForwardClient needs to be able to support UIProcess-only back/forward lists
769         https://bugs.webkit.org/show_bug.cgi?id=190675
770
771         Reviewed by Chris Dumez.
772
773         * BackForwardList.cpp:
774         (BackForwardList::backItem):
775         (BackForwardList::currentItem):
776         (BackForwardList::forwardItem):
777         (BackForwardList::backListCount const):
778         (BackForwardList::forwardListCount const):
779         (BackForwardList::itemAtIndex):
780         * BackForwardList.h:
781
782 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
783
784         Unreviewed attempt to fix the Windows build after r237112.
785
786         * Plugins/PluginView.cpp:
787         (WebCore::PluginView::performRequest):
788
789 2018-10-16  Alex Christensen  <achristensen@webkit.org>
790
791         Replace HistoryItem* with HistoryItem& where possible
792         https://bugs.webkit.org/show_bug.cgi?id=190617
793
794         Reviewed by Chris Dumez.
795
796         * BackForwardList.cpp:
797         (BackForwardList::goToItem):
798         * BackForwardList.h:
799         * WebBackForwardList.cpp:
800         (WebBackForwardList::goToItem):
801
802 2018-10-15  Alex Christensen  <achristensen@webkit.org>
803
804         Fix Windows build.
805
806         * WebView.cpp:
807         (WebView::loadBackForwardListFromOtherView):
808
809 2018-10-15  Alex Christensen  <achristensen@webkit.org>
810
811         Fix WinCairo build.
812
813         * WebView.cpp:
814         (WebView::backForwardList):
815
816 2018-10-15  Alex Christensen  <achristensen@webkit.org>
817
818         Modernize BackForwardClient.h
819         https://bugs.webkit.org/show_bug.cgi?id=190610
820
821         Reviewed by Chris Dumez.
822
823         * BackForwardList.cpp:
824         (BackForwardList::backListCount const):
825         (BackForwardList::forwardListCount const):
826         (BackForwardList::backListCount): Deleted.
827         (BackForwardList::forwardListCount): Deleted.
828         * BackForwardList.h:
829         * WebView.cpp:
830         (WebView::initWithFrame):
831         (WebView::backForwardList):
832
833 2018-10-15  Alex Christensen  <achristensen@webkit.org>
834
835         Remove unused WebView._globalHistoryItem
836         https://bugs.webkit.org/show_bug.cgi?id=190601
837
838         Reviewed by Chris Dumez.
839
840         * WebCoreSupport/WebFrameLoaderClient.cpp:
841         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
842         * WebCoreSupport/WebFrameLoaderClient.h:
843         * WebView.cpp:
844         (WebView::globalHistoryItem):
845         (WebView::setGlobalHistoryItem): Deleted.
846         * WebView.h:
847
848 2018-10-15  Alex Christensen  <achristensen@webkit.org>
849
850         Remove unused parameters from FrameLoaderClient::createFrame
851         https://bugs.webkit.org/show_bug.cgi?id=190587
852
853         Reviewed by Chris Dumez.
854
855         * WebCoreSupport/WebFrameLoaderClient.cpp:
856         (WebFrameLoaderClient::createFrame):
857         * WebCoreSupport/WebFrameLoaderClient.h:
858
859 2018-10-15  Chris Dumez  <cdumez@apple.com>
860
861         Unreviewed Windows build fix after r237112.
862
863         * Plugins/PluginView.cpp:
864         (WebCore::PluginView::performRequest):
865         (WebCore::PluginView::load):
866
867 2018-10-15  Alex Christensen  <achristensen@webkit.org>
868
869         Remove InjectedBundle processing of back/forward lists
870         https://bugs.webkit.org/show_bug.cgi?id=190459
871
872         Reviewed by Chris Dumez.
873
874         * WebCoreSupport/WebFrameLoaderClient.cpp:
875         (WebFrameLoaderClient::shouldGoToHistoryItem const):
876         * WebCoreSupport/WebFrameLoaderClient.h:
877
878 2018-10-02  Alex Christensen  <achristensen@webkit.org>
879
880         Remove ParsedURLString
881         https://bugs.webkit.org/show_bug.cgi?id=190154
882
883         Reviewed by Chris Dumez.
884
885         * WebDownloadCurl.cpp:
886         (WebDownload::initWithRequest):
887         * WebURLResponse.cpp:
888         (WebURLResponse::createInstance):
889
890 2018-09-28  Chris Dumez  <cdumez@apple.com>
891
892         Drop support for cross-origin-window-policy header
893         https://bugs.webkit.org/show_bug.cgi?id=190081
894
895         Reviewed by Ryosuke Niwa.
896
897         * WebPreferenceKeysPrivate.h:
898         * WebPreferences.cpp:
899         (WebPreferences::initializeDefaultSettings):
900         (WebPreferences::crossOriginWindowPolicySupportEnabled):
901         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
902         * WebView.cpp:
903         (WebView::notifyPreferencesChanged):
904
905 2018-09-27  Antoine Quint  <graouts@apple.com>
906
907         [Web Animations] Turn Web Animations with CSS integration on
908         https://bugs.webkit.org/show_bug.cgi?id=184819
909         <rdar://problem/39597337>
910
911         Reviewed by Dean Jackson.
912
913         * WebPreferences.cpp:
914         (WebPreferences::initializeDefaultSettings):
915
916 2018-09-21  Alex Christensen  <achristensen@webkit.org>
917
918         Use a Variant for FormDataElement
919         https://bugs.webkit.org/show_bug.cgi?id=189777
920
921         Reviewed by Chris Dumez.
922
923         * WebMutableURLRequest.cpp:
924         (WebMutableURLRequest::setHTTPBody):
925
926 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
927
928         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
929         https://bugs.webkit.org/show_bug.cgi?id=189612
930
931         Reviewed by Alex Christensen.
932
933         Non-trivial types can't be used as aruguments of LOG_ERROR and
934         ASSERT_WITH_MESSAGE.
935
936         * DefaultPolicyDelegate.cpp:
937         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
938         static_cast<BSTR> to convert BString.
939         * WebLocalizableStrings.cpp:
940         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
941         char* by using 'key.utf8().data()'.
942
943 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
944
945         Unreviewed, rolling out r235953.
946
947         Caused layout test crashes under GuardMalloc.
948
949         Reverted changeset:
950
951         "Make GraphicsLayers ref-counted, so their tree can persist
952         when disconnected from RenderLayerBackings"
953         https://bugs.webkit.org/show_bug.cgi?id=189521
954         https://trac.webkit.org/changeset/235953
955
956 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
957
958         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
959         https://bugs.webkit.org/show_bug.cgi?id=189538
960
961         Reviewed by Per Arne Vollan.
962
963         * WebPreferences.cpp:
964         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
965         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
966         Apply static_cast to the result of OR-ed CFPropertyListFormat.
967         (WebPreferences::screenFontSubstitutionEnabled):
968         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
969
970 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
971
972         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
973         https://bugs.webkit.org/show_bug.cgi?id=189539
974
975         Reviewed by Alex Christensen.
976
977         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
978         * WebCoreSupport/WebInspectorClient.cpp:
979         (WebInspectorWndProc): Ditto.
980         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
981         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
982
983 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
984
985         Refactor WebCore::EditAction to be an 8-bit enum class
986         https://bugs.webkit.org/show_bug.cgi?id=189383
987
988         Reviewed by Dan Bernstein.
989
990         * WebCoreSupport/WebEditorClient.cpp:
991         (undoNameForEditAction):
992
993 2018-09-04  Frederic Wang  <fwang@igalia.com>
994
995         Add basic support for ScrollIntoViewOptions
996         https://bugs.webkit.org/show_bug.cgi?id=189258
997
998         Reviewed by Simon Fraser.
999
1000         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
1001         can build despite the new scrollIntoView function.
1002
1003 2018-08-31  Chris Dumez  <cdumez@apple.com>
1004
1005         Unreviewed Windows build fix after r235562.
1006
1007         * WebCoreSupport/WebFrameLoaderClient.cpp:
1008         (WebFrameLoaderClient::dispatchWillSubmitForm):
1009
1010 2018-08-31  Chris Dumez  <cdumez@apple.com>
1011
1012         Assertion hit in ~CompletionHandler() from ~WebFrame()
1013         https://bugs.webkit.org/show_bug.cgi?id=189199
1014         <rdar://problem/42657233>
1015
1016         Reviewed by Youenn Fablet.
1017
1018         * WebCoreSupport/WebFrameLoaderClient.cpp:
1019         (WebFrameLoaderClient::dispatchWillSubmitForm):
1020         * WebCoreSupport/WebFrameLoaderClient.h:
1021
1022 2018-08-31  Frederic Wang  <fwang@igalia.com>
1023
1024         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1025         https://bugs.webkit.org/show_bug.cgi?id=182053
1026
1027         Reviewed by Simon Fraser.
1028
1029         Add developer flag to use standard behavior for scrolling* attributes.
1030
1031         * Interfaces/IWebPreferencesPrivate.idl:
1032         * WebPreferenceKeysPrivate.h:
1033         * WebPreferences.cpp:
1034         (WebPreferences::initializeDefaultSettings):
1035         (WebPreferences::CSSOMViewScrollingAPIEnabled):
1036         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
1037         * WebPreferences.h:
1038         * WebView.cpp:
1039         (WebView::notifyPreferencesChanged):
1040
1041 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
1042
1043         [CMake] Replace AVFoundationSupport.py using CMake
1044         https://bugs.webkit.org/show_bug.cgi?id=182891
1045
1046         Reviewed by Per Arne Vollan.
1047
1048         Remove references to the config.h contained in WebCore as it should
1049         not be accessible from outside of WebCore.
1050
1051         * WebKitPrefix.h:
1052
1053 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1054
1055         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
1056         https://bugs.webkit.org/show_bug.cgi?id=188496
1057         <rdar://problem/43216836>
1058
1059         Reviewed by Tim Horton.
1060
1061         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
1062         header directly.
1063
1064         * WebCoreSupport/WebDragClient.cpp:
1065
1066 2018-08-17  Alex Christensen  <achristensen@webkit.org>
1067
1068         Add some plumbing for safe browsing
1069         https://bugs.webkit.org/show_bug.cgi?id=188709
1070
1071         Reviewed by Tim Horton.
1072
1073         * WebCoreSupport/WebFrameLoaderClient.cpp:
1074         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1075         * WebCoreSupport/WebFrameLoaderClient.h:
1076
1077 2018-08-02  David Fenton  <david_fenton@apple.com>
1078
1079         Unreviewed, rolling out r234489.
1080
1081         Caused 50+ crashes and 60+ API failures on iOS
1082
1083         Reverted changeset:
1084
1085         "[WTF] Rename String::format to String::deprecatedFormat"
1086         https://bugs.webkit.org/show_bug.cgi?id=188191
1087         https://trac.webkit.org/changeset/234489
1088
1089 2018-08-01  Tomas Popela  <tpopela@redhat.com>
1090
1091         [WTF] Rename String::format to String::deprecatedFormat
1092         https://bugs.webkit.org/show_bug.cgi?id=188191
1093
1094         Reviewed by Darin Adler.
1095
1096         It should be replaced with string concatenation.
1097
1098         * FullscreenVideoController.cpp:
1099         (timeToString):
1100         * WebView.cpp:
1101         (webKitVersionString):
1102
1103 2018-07-30  Rob Buis  <rbuis@igalia.com>
1104
1105         https://bugs.webkit.org/show_bug.cgi?id=188137
1106         Merge PlatformCookieJar functions into NetworkStorageSession
1107
1108         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1109
1110         Reviewed by Alex Christensen.
1111
1112         * WebCoreSupport/WebPlatformStrategies.cpp:
1113         (WebPlatformStrategies::cookiesForDOM):
1114         (WebPlatformStrategies::setCookiesFromDOM):
1115         (WebPlatformStrategies::cookiesEnabled):
1116         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1117         (WebPlatformStrategies::getRawCookies):
1118         (WebPlatformStrategies::deleteCookie):
1119         * WebPreferences.cpp:
1120         (WebPreferences::clearNetworkLoaderSession):
1121
1122 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
1123
1124         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
1125         https://bugs.webkit.org/show_bug.cgi?id=187963
1126
1127         Reviewed by Alex Christensen.
1128
1129         * Plugins/PluginPackageWin.cpp:
1130         (WebCore::PluginPackage::fetchInfo):
1131         Update split/splitAllowingEmptyEntries usage.
1132
1133 2018-07-18  Antoine Quint  <graouts@apple.com>
1134
1135         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
1136         https://bugs.webkit.org/show_bug.cgi?id=187722
1137
1138         Reviewed by Myles Maxfield.
1139
1140         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
1141
1142         * DOMCoreClasses.cpp:
1143         (DOMElement::font):
1144
1145 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1146
1147         Disable cross-origin-window-policy by default
1148         https://bugs.webkit.org/show_bug.cgi?id=187509
1149
1150         Reviewed by Chris Dumez.
1151
1152         * WebPreferences.cpp:
1153         (WebPreferences::initializeDefaultSettings):
1154
1155 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1156
1157         [WTF] Add user-defined literal for ASCIILiteral
1158         https://bugs.webkit.org/show_bug.cgi?id=186839
1159
1160         Reviewed by Darin Adler.
1161
1162         * Plugins/PluginStream.cpp:
1163         (WebCore::PluginStream::startStream):
1164         * WebCoreSupport/WebContextMenuClient.cpp:
1165         (WebContextMenuClient::searchWithGoogle):
1166
1167 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1168
1169         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
1170         https://bugs.webkit.org/show_bug.cgi?id=186623
1171
1172         Reviewed by Youenn Fablet.
1173
1174         * WebCoreSupport/WebPluginInfoProvider.cpp:
1175         (WebPluginInfoProvider::pluginInfo):
1176         (WebPluginInfoProvider::webVisiblePluginInfo):
1177         * WebCoreSupport/WebPluginInfoProvider.h:
1178
1179 2018-06-13  Chris Dumez  <cdumez@apple.com>
1180
1181         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1182         https://bugs.webkit.org/show_bug.cgi?id=186545
1183
1184         Reviewed by Brady Eidson.
1185
1186         Update client delegate now that parameter type has changed.
1187
1188         * WebCoreSupport/WebFrameLoaderClient.cpp:
1189         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1190         * WebCoreSupport/WebFrameLoaderClient.h:
1191
1192 2018-06-11  Chris Dumez  <cdumez@apple.com>
1193
1194         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
1195         https://bugs.webkit.org/show_bug.cgi?id=186441
1196
1197         Reviewed by Brady Eidson.
1198
1199         Rename existing flag to something a bit more generic, now that it is used for
1200         more things than bypassing the navigation policy check.
1201
1202         * WebView.cpp:
1203         (WebView::goToBackForwardItem):
1204         (WebView::loadBackForwardListFromOtherView):
1205
1206 2018-06-04  Chris Dumez  <cdumez@apple.com>
1207
1208         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
1209         https://bugs.webkit.org/show_bug.cgi?id=186287
1210         <rdar://problem/40783352>
1211
1212         Reviewed by Youenn Fablet.
1213
1214         * Interfaces/IWebPreferencesPrivate.idl:
1215         * WebPreferenceKeysPrivate.h:
1216         * WebPreferences.cpp:
1217         (WebPreferences::initializeDefaultSettings):
1218         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1219         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1220         * WebPreferences.h:
1221         * WebView.cpp:
1222         (WebView::notifyPreferencesChanged):
1223
1224 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1225
1226         [JSC] Pass VM& parameter as much as possible
1227         https://bugs.webkit.org/show_bug.cgi?id=186085
1228
1229         Reviewed by Saam Barati.
1230
1231         * Plugins/PluginPackage.cpp:
1232         (WebCore::NPN_Invoke):
1233
1234 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1235
1236         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
1237         https://bugs.webkit.org/show_bug.cgi?id=186125
1238
1239         Unreviewed build fix
1240
1241         * WebActionPropertyBag.cpp:
1242         (WebActionPropertyBag::Read):
1243         (findMouseEvent): Deleted.
1244
1245 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1246
1247         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
1248         https://bugs.webkit.org/show_bug.cgi?id=186027
1249
1250         Unreviewed build fix
1251
1252         * WebMutableURLRequest.cpp:
1253         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
1254         (WebMutableURLRequest::setClientCertificate):
1255
1256 2018-05-25  Chris Dumez  <cdumez@apple.com>
1257
1258         Minor ApplicationCacheStorage clean up
1259         https://bugs.webkit.org/show_bug.cgi?id=185984
1260
1261         Reviewed by Youenn Fablet.
1262
1263         * WebApplicationCache.cpp:
1264         (WebApplicationCache::originsWithCache):
1265
1266 2018-05-24  Chris Dumez  <cdumez@apple.com>
1267
1268         Reduce copying of FontCascadeDescription objects by moving them around
1269         https://bugs.webkit.org/show_bug.cgi?id=185963
1270
1271         Reviewed by Simon Fraser.
1272
1273         Reduce copying of FontCascadeDescription objects by moving them around when possible.
1274
1275         * FullscreenVideoController.cpp:
1276         (FullscreenVideoController::draw):
1277
1278 2018-05-15  Antoine Quint  <graouts@apple.com>
1279
1280         [Web Animations] Expose Web Animations CSS integration as an experimental feature
1281         https://bugs.webkit.org/show_bug.cgi?id=185647
1282
1283         Reviewed by Dean Jackson.
1284
1285         Rename the Web Animations CSS integration flag.
1286
1287         * Interfaces/IWebPreferencesPrivate.idl:
1288         * WebPreferenceKeysPrivate.h:
1289         * WebPreferences.cpp:
1290         (WebPreferences::initializeDefaultSettings):
1291         (WebPreferences::webAnimationsCSSIntegrationEnabled):
1292         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
1293         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1294         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1295         * WebPreferences.h:
1296         * WebView.cpp:
1297         (WebView::notifyPreferencesChanged):
1298
1299 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1300
1301         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
1302         https://bugs.webkit.org/show_bug.cgi?id=185505
1303
1304         Unreviewed serious crash fix
1305
1306         Windows port crashes soon since Bug 184996.
1307
1308         * WebPreferences.cpp:
1309         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
1310         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
1311
1312 2018-05-07  Daniel Bates  <dabates@apple.com>
1313
1314         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
1315         https://bugs.webkit.org/show_bug.cgi?id=185170
1316
1317         Reviewed by Per Arne Vollan.
1318
1319         * WebCache.cpp:
1320         (WebCache::empty):
1321
1322 2018-04-27  Chris Dumez  <cdumez@apple.com>
1323
1324         Use WindowProxy instead of DOMWindow in our IDL
1325         https://bugs.webkit.org/show_bug.cgi?id=185022
1326
1327         Reviewed by Sam Weinig.
1328
1329         * DOMCoreClasses.cpp:
1330         (DOMDocument::getComputedStyle):
1331
1332 2018-04-23  Daniel Bates  <dabates@apple.com>
1333
1334         Implement Same-Site cookies
1335         https://bugs.webkit.org/show_bug.cgi?id=159464
1336         <rdar://problem/27196358>
1337
1338         Reviewed by Brent Fulgham.
1339
1340         Pass the Same-Site info through the strategy.
1341
1342         * WebCoreSupport/WebPlatformStrategies.cpp:
1343         (WebPlatformStrategies::cookiesForDOM):
1344         (WebPlatformStrategies::setCookiesFromDOM):
1345         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1346         (WebPlatformStrategies::getRawCookies):
1347         * WebCoreSupport/WebPlatformStrategies.h:
1348
1349 2018-04-23  Daniel Bates  <dabates@apple.com>
1350
1351         Implement Same-Site cookies
1352         https://bugs.webkit.org/show_bug.cgi?id=159464
1353         <rdar://problem/27196358>
1354
1355         Reviewed by Brent Fulgham.
1356
1357         Pass the Same-Site info through the strategy.
1358
1359         * WebCoreSupport/WebPlatformStrategies.cpp:
1360         (WebPlatformStrategies::cookiesForDOM):
1361         (WebPlatformStrategies::setCookiesFromDOM):
1362         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1363         (WebPlatformStrategies::getRawCookies):
1364         * WebCoreSupport/WebPlatformStrategies.h:
1365
1366 2018-04-20  Youenn Fablet  <youenn@apple.com>
1367
1368         Make PluginData cache its web visible plugins
1369         https://bugs.webkit.org/show_bug.cgi?id=184421
1370
1371         Reviewed by Chris Dumez.
1372
1373         * WebCoreSupport/WebPluginInfoProvider.cpp:
1374         (WebPluginInfoProvider::pluginInfo):
1375         (WebPluginInfoProvider::webVisiblePluginInfo):
1376         * WebCoreSupport/WebPluginInfoProvider.h:
1377
1378 2018-04-19  Chris Dumez  <cdumez@apple.com>
1379
1380         Rename JSDOMWindowProxy to JSWindowProxy
1381         https://bugs.webkit.org/show_bug.cgi?id=184797
1382
1383         Reviewed by Sam Weinig.
1384
1385         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
1386
1387         * WebFrame.cpp:
1388         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
1389
1390 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
1391
1392         Unreviewed rollout of r230632. Regression in memory usage.
1393
1394         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
1395
1396         * WebPreferences.cpp:
1397         (WebPreferences::initializeDefaultSettings):
1398
1399 2018-04-17  Chris Dumez  <cdumez@apple.com>
1400
1401         Unreviewed attempt to fix the Windows build after r230721
1402
1403         * WebCoreSupport/WebFrameLoaderClient.cpp:
1404         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1405
1406 2018-04-17  Chris Dumez  <cdumez@apple.com>
1407
1408         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
1409         https://bugs.webkit.org/show_bug.cgi?id=184678
1410         <rdar://problem/39422122>
1411
1412         Reviewed by Alex Christensen.
1413
1414         Add new parameter to dispatchDecidePolicyForNavigationAction.
1415
1416         * WebCoreSupport/WebFrameLoaderClient.cpp:
1417         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1418         * WebCoreSupport/WebFrameLoaderClient.h:
1419
1420 2018-04-12  Antoine Quint  <graouts@apple.com>
1421
1422         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
1423         https://bugs.webkit.org/show_bug.cgi?id=184569
1424         <rdar://problem/38671301>
1425
1426         Reviewed by Jon Lee.
1427
1428         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
1429
1430         * WebPreferences.cpp:
1431
1432 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1433
1434         [WTF] Remove StaticLock
1435         https://bugs.webkit.org/show_bug.cgi?id=184332
1436
1437         Reviewed by Mark Lam.
1438
1439         * WebKitQuartzCoreAdditions/CAView.cpp:
1440         (WKQCA::CAView::releaseAllD3DResources):
1441         * WebLocalizableStrings.cpp:
1442
1443 2018-04-03  Chris Dumez  <cdumez@apple.com>
1444
1445         Drop MainFrame class
1446         https://bugs.webkit.org/show_bug.cgi?id=184191
1447
1448         Reviewed by Darin Adler.
1449
1450         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
1451         relationship between the Page and the MainFrame.
1452
1453         This is ground work for introducing LocalFrame / RemoteFrame concepts.
1454
1455         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1456         * WebCoreSupport/WebContextMenuClient.cpp:
1457         * WebCoreSupport/WebDragClient.cpp:
1458         * WebDropSource.cpp:
1459         * WebFrame.cpp:
1460         * WebView.cpp:
1461
1462 2018-03-26  Chris Dumez  <cdumez@apple.com>
1463
1464         Use SecurityOriginData more consistently in Service Worker code
1465         https://bugs.webkit.org/show_bug.cgi?id=183969
1466
1467         Reviewed by Darin Adler.
1468
1469         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
1470
1471         * WebDatabaseManager.cpp:
1472         (WebDatabaseManager::databasesWithOrigin):
1473         (WebDatabaseManager::deleteOrigin):
1474         (WebDatabaseManager::deleteDatabase):
1475         (WebDatabaseManager::setQuota):
1476         * WebSecurityOrigin.cpp:
1477         (WebSecurityOrigin::usage):
1478         (WebSecurityOrigin::quota):
1479         (WebSecurityOrigin::setQuota):
1480
1481 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
1482
1483         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
1484         https://bugs.webkit.org/show_bug.cgi?id=183911
1485         <rdar://problem/38762306>
1486
1487         Reviewed by Youenn Fablet.
1488
1489         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
1490
1491         * WebView.cpp:
1492         (WebView::WebView):
1493
1494 2018-03-25  Commit Queue  <commit-queue@webkit.org>
1495
1496         Unreviewed, rolling out r229954.
1497         https://bugs.webkit.org/show_bug.cgi?id=184000
1498
1499         Caused many layout tests to crash on Apple High Sierra,
1500         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
1501         by dydz on #webkit).
1502
1503         Reverted changeset:
1504
1505         "Use SecurityOriginData more consistently in Service Worker
1506         code"
1507         https://bugs.webkit.org/show_bug.cgi?id=183969
1508         https://trac.webkit.org/changeset/229954
1509
1510 2018-03-24  Chris Dumez  <cdumez@apple.com>
1511
1512         Use SecurityOriginData more consistently in Service Worker code
1513         https://bugs.webkit.org/show_bug.cgi?id=183969
1514
1515         Reviewed by Darin Adler.
1516
1517         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
1518
1519         * WebDatabaseManager.cpp:
1520         (WebDatabaseManager::databasesWithOrigin):
1521         (WebDatabaseManager::deleteOrigin):
1522         (WebDatabaseManager::deleteDatabase):
1523         (WebDatabaseManager::setQuota):
1524         * WebSecurityOrigin.cpp:
1525         (WebSecurityOrigin::usage):
1526         (WebSecurityOrigin::quota):
1527         (WebSecurityOrigin::setQuota):
1528
1529 2018-03-23  Chris Dumez  <cdumez@apple.com>
1530
1531         Unreviewed attempt to fix Windows build after r229926.
1532
1533         * WebView.cpp:
1534
1535 2018-03-23  Brady Eidson  <beidson@apple.com>
1536
1537         Go to back/forward list items after a process-swapped navigation.
1538         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
1539
1540         Reviewed by Andy Estes.
1541
1542         * WebView.cpp:
1543         (WebView::goToBackForwardItem):
1544         (WebView::loadBackForwardListFromOtherView):
1545
1546 2018-03-23  Miguel Gomez  <magomez@igalia.com>
1547
1548         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
1549         https://bugs.webkit.org/show_bug.cgi?id=183892
1550
1551         Remove the UpdateContentsFlag parameter as it's not used anymore.
1552
1553         Reviewed by Žan Doberšek.
1554
1555         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1556         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
1557
1558 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
1559
1560         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
1561         https://bugs.webkit.org/show_bug.cgi?id=183335
1562
1563         Reviewed by Alex Christensen.
1564
1565         * Plugins/PluginDatabaseWin.cpp:
1566         * Plugins/PluginMessageThrottlerWin.cpp:
1567         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
1568         * Plugins/PluginPackageWin.cpp:
1569         (WebCore::PluginPackage::load):
1570         * Plugins/PluginView.h:
1571         * Plugins/PluginViewWin.cpp:
1572         * Plugins/npapi.cpp:
1573         * WebCoreSupport/WebFrameLoaderClient.cpp:
1574         (WebFrameLoaderClient::createPlugin):
1575         (WebFrameLoaderClient::createJavaAppletWidget):
1576         * WebView.cpp:
1577         (WebView::WebViewWndProc):
1578
1579 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
1580
1581         [Win] Layout Test fast/html/menuitem-element.html is failing.
1582         https://bugs.webkit.org/show_bug.cgi?id=179299
1583
1584         Reviewed by Per Arne Vollan.
1585
1586         * Interfaces/IWebPreferencesPrivate.idl:
1587         * WebPreferenceKeysPrivate.h:
1588         * WebPreferences.cpp:
1589         (WebPreferences::menuItemElementEnabled):
1590         (WebPreferences::setMenuItemElementEnabled):
1591         * WebPreferences.h:
1592         * WebView.cpp:
1593         (WebView::notifyPreferencesChanged):
1594         Add private web preference "menuItemElementEnabled".
1595
1596 2018-03-12  Antoine Quint  <graouts@apple.com>
1597
1598         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
1599         https://bugs.webkit.org/show_bug.cgi?id=183504
1600         <rdar://problem/38372965>
1601
1602         Reviewed by Dean Jackson and Jon Lee.
1603
1604         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
1605         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
1606
1607         * Interfaces/IWebPreferencesPrivate.idl:
1608         * WebPreferences.cpp:
1609         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
1610         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
1611         * WebPreferenceKeysPrivate.h
1612         * WebPreferences.h:
1613         * WebView.cpp:
1614         (WebView::notifyPreferencesChanged):
1615
1616 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1617
1618         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
1619         https://bugs.webkit.org/show_bug.cgi?id=183429
1620
1621         Reviewed by Mark Lam.
1622
1623         * WebFrame.cpp:
1624         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
1625
1626 2018-03-08  Tim Horton  <timothy_horton@apple.com>
1627
1628         Stop linking ApplicationServices directly
1629         https://bugs.webkit.org/show_bug.cgi?id=182867
1630         <rdar://problem/38252142>
1631
1632         Reviewed by Alex Christensen.
1633
1634         The frameworks that we use that live inside ApplicationServices
1635         have mostly moved out, so import them directly.
1636
1637         * FullscreenVideoController.cpp:
1638
1639 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1640
1641         Fix std::make_unique / new[] using system malloc
1642         https://bugs.webkit.org/show_bug.cgi?id=182975
1643
1644         Reviewed by JF Bastien.
1645
1646         Use Vector instead.
1647
1648         * MarshallingHelpers.cpp:
1649         (MarshallingHelpers::safeArrayToStringArray):
1650         (MarshallingHelpers::safeArrayToIntArray):
1651         * Plugins/PluginPackageWin.cpp:
1652         (WebCore::PluginPackage::fetchInfo):
1653         * WebPreferences.cpp:
1654         (WebPreferences::copyWebKitPreferencesToCFPreferences):
1655         * WebView.cpp:
1656         (WebView::onMenuCommand):
1657
1658 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1659
1660         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
1661         https://bugs.webkit.org/show_bug.cgi?id=183312
1662
1663         Reviewed by Mark Lam.
1664
1665         Remove wtf/CurrentTime.h include pragma.
1666
1667         * WebDownload.cpp:
1668         * WebDownloadCFNet.cpp:
1669         * WebDropSource.cpp:
1670
1671 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1672
1673         Remove monotonicallyIncreasingTime
1674         https://bugs.webkit.org/show_bug.cgi?id=182911
1675
1676         Reviewed by Michael Catanzaro.
1677
1678         * FullscreenVideoController.cpp:
1679         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
1680         * Plugins/PluginMessageThrottlerWin.cpp:
1681         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
1682         (WebCore::PluginMessageThrottlerWin::appendMessage):
1683         * Plugins/PluginMessageThrottlerWin.h:
1684         * WebView.cpp:
1685         (WebView::notifyAnimationStarted):
1686         * WebView.h:
1687
1688 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
1689
1690         [Win][DRT] Implement setSpatialNavigationEnabled.
1691         https://bugs.webkit.org/show_bug.cgi?id=183166
1692
1693         Reviewed by Per Arne Vollan.
1694
1695         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
1696
1697         * Interfaces/IWebPreferencesPrivate.idl:
1698         * WebPreferenceKeysPrivate.h:
1699         * WebPreferences.cpp:
1700         (WebPreferences::initializeDefaultSettings):
1701         (WebPreferences::spatialNavigationEnabled):
1702         (WebPreferences::setSpatialNavigationEnabled):
1703         * WebPreferences.h:
1704         * WebView.cpp:
1705         (WebView::notifyPreferencesChanged):
1706
1707 2018-02-28  Alex Christensen  <achristensen@webkit.org>
1708
1709         Reduce use of NetworkingContext in WebKit
1710         https://bugs.webkit.org/show_bug.cgi?id=183213
1711
1712         Reviewed by Brady Eidson.
1713
1714         * Plugins/PluginView.cpp:
1715         (WebCore::PluginView::getValueForURL):
1716
1717 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
1718
1719         Fix WebCore includes within WebKitLegacy
1720         https://bugs.webkit.org/show_bug.cgi?id=183147
1721
1722         Reviewed by Tim Horton.
1723
1724         * Plugins/PluginDatabase.cpp:
1725         * Plugins/PluginDatabaseWin.cpp:
1726         * Plugins/PluginDebug.cpp:
1727         * Plugins/PluginDebug.h:
1728         * Plugins/PluginMainThreadScheduler.cpp:
1729         * Plugins/PluginMessageThrottlerWin.cpp:
1730         * Plugins/PluginMessageThrottlerWin.h:
1731         * Plugins/PluginPackage.cpp:
1732         * Plugins/PluginPackage.h:
1733         * Plugins/PluginPackageWin.cpp:
1734         * Plugins/PluginStream.cpp:
1735         * Plugins/PluginStream.h:
1736         * Plugins/PluginView.cpp:
1737         * Plugins/PluginView.h:
1738         * Plugins/PluginViewWin.cpp:
1739         * Plugins/npapi.cpp:
1740         * WebCoreSupport/WebChromeClient.cpp:
1741         * WebCoreSupport/WebContextMenuClient.cpp:
1742         * WebCoreSupport/WebFrameLoaderClient.cpp:
1743         * WebCoreSupport/WebInspectorClient.cpp:
1744         * WebCoreSupport/WebPlatformStrategies.cpp:
1745         * WebFrame.cpp:
1746         * WebKitMessageLoop.cpp:
1747         * WebView.cpp:
1748         * storage/WebDatabaseProvider.cpp:
1749
1750 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1751
1752         Remove currentTime() / currentTimeMS()
1753         https://bugs.webkit.org/show_bug.cgi?id=183052
1754
1755         Reviewed by Mark Lam.
1756
1757         * WebCoreSupport/WebFrameLoaderClient.cpp:
1758         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1759         * WebCoreSupport/WebFrameLoaderClient.h:
1760         * WebDownload.h:
1761         * WebDownloadCFNet.cpp:
1762         (WebDownload::didStart):
1763         (WebDownload::didReceiveData):
1764         (WebDownload::didFinish):
1765
1766 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
1767
1768         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
1769         https://bugs.webkit.org/show_bug.cgi?id=182883
1770
1771         Reviewed by Per Arne Vollan.
1772
1773         * WebKitPrefix.h:
1774
1775 2018-02-16  Dean Jackson  <dino@apple.com>
1776
1777         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
1778         https://bugs.webkit.org/show_bug.cgi?id=182894
1779
1780         Reviewed by Tim Horton.
1781
1782         Rename OPENGL_ES_2 to OPENGL_ES.
1783
1784         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1785
1786 2018-02-16  Youenn Fablet  <youenn@apple.com>
1787
1788         Allow specifying which plug-ins are supported
1789         https://bugs.webkit.org/show_bug.cgi?id=182748
1790
1791         Reviewed by Chris Dumez.
1792
1793         * WebCoreSupport/WebPluginInfoProvider.cpp:
1794         (WebPluginInfoProvider::getPluginInfo):
1795         * WebCoreSupport/WebPluginInfoProvider.h:
1796
1797 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
1798
1799         WebCore headers should not be included relatively within dependent projects
1800         https://bugs.webkit.org/show_bug.cgi?id=182805
1801
1802         Reviewed by Chris Dumez.
1803
1804         * FullscreenVideoController.h:
1805
1806 2018-02-13  Commit Queue  <commit-queue@webkit.org>
1807
1808         Unreviewed, rolling out r228431.
1809         https://bugs.webkit.org/show_bug.cgi?id=182766
1810
1811         Regressed CMake build stability (Requested by dolmstead on
1812         #webkit).
1813
1814         Reverted changeset:
1815
1816         "[CMake] Make WebCore headers copies"
1817         https://bugs.webkit.org/show_bug.cgi?id=182512
1818         https://trac.webkit.org/changeset/228431
1819
1820 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
1821
1822         [CMake] Make WebCore headers copies
1823         https://bugs.webkit.org/show_bug.cgi?id=182512
1824
1825         Reviewed by Keith Miller.
1826
1827         * FullscreenVideoController.h:
1828         * Plugins/PluginDatabase.cpp:
1829         * Plugins/PluginDatabaseWin.cpp:
1830         * Plugins/PluginDebug.cpp:
1831         * Plugins/PluginMainThreadScheduler.cpp:
1832         * Plugins/PluginMessageThrottlerWin.cpp:
1833         * Plugins/PluginPackage.cpp:
1834         * Plugins/PluginPackageWin.cpp:
1835         * Plugins/PluginStream.cpp:
1836         * Plugins/PluginView.cpp:
1837         * Plugins/PluginViewWin.cpp:
1838         * Plugins/npapi.cpp:
1839         * WebKitMessageLoop.cpp:
1840         * WebKitPrefix.h:
1841         * storage/WebDatabaseProvider.cpp:
1842
1843 2018-01-13  Darin Adler  <darin@apple.com>
1844
1845         Event improvements
1846         https://bugs.webkit.org/show_bug.cgi?id=179591
1847
1848         Reviewed by Chris Dumez.
1849
1850         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
1851         * WebFrame.cpp: Ditto.
1852
1853         * WebScriptWorld.cpp:
1854         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
1855
1856         * WebView.cpp: Removed include of ScriptValue.h.
1857         (WebView::handleEditingKeyboardEvent): Updated for name change from
1858         keyEvent to underlyingPlatformEvent.
1859
1860 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1861
1862         Remove WebCore/ForwardingHeaders directory
1863         https://bugs.webkit.org/show_bug.cgi?id=182347
1864
1865         Reviewed by Keith Miller.
1866
1867         * Plugins/PluginView.cpp:
1868         * Plugins/PluginViewWin.cpp:
1869         * WebCoreSupport/WebInspectorClient.cpp:
1870         * WebCoreSupport/WebInspectorClient.h:
1871         * WebFrame.cpp:
1872         * WebJavaScriptCollector.cpp:
1873         * WebView.cpp:
1874
1875 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1876
1877         Unreviewed, another attempt to fix the Windows build after r227479.
1878
1879         * WebFrame.cpp:
1880         (WebFrame::elementWithName):
1881
1882 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1883
1884         Unreviewed, try to fix the Windows build after r227479.
1885
1886         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
1887
1888         * WebFrame.cpp:
1889         (WebFrame::elementWithName):
1890         (WebFrame::controlsInForm):
1891
1892 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
1893
1894         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
1895         https://bugs.webkit.org/show_bug.cgi?id=181859
1896         <rdar://problem/36659886>
1897
1898         Reviewed by Alex Christensen.
1899         
1900         Use local include patch.
1901
1902         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
1903         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
1904         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
1905
1906 2018-01-17  Youenn Fablet  <youenn@apple.com>
1907
1908         Put fetch Request.keepalive behind a runtime flag
1909         https://bugs.webkit.org/show_bug.cgi?id=181592
1910
1911         Reviewed by Chris Dumez.
1912
1913         * WebPreferences.cpp:
1914         (WebPreferences::fetchAPIKeepAliveEnabled):
1915         (WebPreferences::setFetchAPIKeepAliveEnabled):
1916         * WebPreferences.h:
1917         * WebView.cpp:
1918         (WebView::notifyPreferencesChanged):
1919
1920 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1921
1922         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1923         https://bugs.webkit.org/show_bug.cgi?id=181637
1924         <rdar://problem/36508471>
1925
1926         Reviewed by Tim Horton.
1927
1928         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1929
1930         * WebCoreSupport/WebEditorClient.cpp:
1931         (WebEditorClient::replacementURLForResource):
1932         * WebCoreSupport/WebEditorClient.h:
1933
1934 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1935
1936         Remove std::chrono completely
1937         https://bugs.webkit.org/show_bug.cgi?id=181186
1938
1939         Reviewed by Alex Christensen.
1940
1941         * Plugins/PluginStream.cpp:
1942         (WebCore::lastModifiedDateMS):
1943
1944 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1945
1946         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
1947         https://bugs.webkit.org/show_bug.cgi?id=181173
1948
1949         Reviewed by Alex Christensen.
1950
1951         * WebNodeHighlight.cpp:
1952         (WebNodeHighlight::update): Scale the GraphicsContext.
1953
1954 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1955
1956         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
1957         https://bugs.webkit.org/show_bug.cgi?id=181160
1958
1959         Reviewed by Myles C. Maxfield.
1960
1961         * Plugins/PluginView.cpp:
1962         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
1963
1964 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1965
1966         Enable picture-in-picture from inline element on suspend.
1967         https://bugs.webkit.org/show_bug.cgi?id=180942
1968         rdar://problem/34745234
1969
1970         Reviewed by Jer Noble.
1971
1972         Update signature of enterVideoFullscreenForVideoElement.
1973
1974         * WebCoreSupport/WebChromeClient.cpp:
1975         (WebChromeClient::enterVideoFullscreenForVideoElement):
1976         * WebCoreSupport/WebChromeClient.h:
1977
1978 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1979
1980         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
1981         https://bugs.webkit.org/show_bug.cgi?id=180926
1982
1983         Reviewed by Tim Horton.
1984
1985         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
1986         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
1987
1988         * WebCoreSupport/WebFrameLoaderClient.cpp:
1989         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
1990         (WebFrameLoaderClient::pageID const): Ditto.
1991
1992 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1993
1994         Remove unnecessary boolean result of start() functions
1995         https://bugs.webkit.org/show_bug.cgi?id=180856
1996
1997         Reviewed by Darin Adler.
1998
1999         It always returns true.
2000
2001         * WebDownloadCurl.cpp:
2002         (WebDownload::start):
2003
2004 2017-12-14  John Wilander  <wilander@apple.com>
2005
2006         Storage Access API: Implement frame-specific access in the document.cookie layer
2007         https://bugs.webkit.org/show_bug.cgi?id=180682
2008         <rdar://problem/35982257>
2009
2010         Reviewed by Alex Christensen.
2011
2012         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
2013         CookiesStrategy::cookieRequestHeaderFieldValue(), and
2014         CookiesStrategy::getRawCookies() now take optional parameters for
2015         frameID and pageID to allow frame-specific scoping of cookies.
2016
2017         This change makes the return values of FrameLoaderClient::frameID()
2018         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
2019         WebCore can call those getters and get the right return values in
2020         WebKit and std:nullopt in WebKitLegacy.
2021
2022         * WebCoreSupport/WebFrameLoaderClient.cpp:
2023         (WebFrameLoaderClient::pageID const):
2024         (WebFrameLoaderClient::frameID const):
2025             Now return an optional.
2026         * WebCoreSupport/WebFrameLoaderClient.h:
2027         * WebCoreSupport/WebPlatformStrategies.cpp:
2028         (WebPlatformStrategies::cookiesForDOM):
2029         (WebPlatformStrategies::setCookiesFromDOM):
2030         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2031         (WebPlatformStrategies::getRawCookies):
2032         * WebCoreSupport/WebPlatformStrategies.h:
2033
2034 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2035
2036         [WTF] Thread::create should have Thread::tryCreate
2037         https://bugs.webkit.org/show_bug.cgi?id=180333
2038
2039         Reviewed by Darin Adler.
2040
2041         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
2042         (WKQCA::CVDisplayLink::start):
2043
2044 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2045
2046         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
2047         https://bugs.webkit.org/show_bug.cgi?id=180572
2048
2049         Reviewed by Mark Lam.
2050
2051         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
2052         Also we use Lock instead of Mutex.
2053
2054         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
2055         (WKQCA::CAD3DRenderer::swapChain):
2056         (WKQCA::CAD3DRenderer::renderAndPresent):
2057         (WKQCA::CAD3DRenderer::renderToImage):
2058         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2059         (WKQCA::CAD3DRenderer::renderInternal):
2060         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
2061         * WebKitQuartzCoreAdditions/CAView.cpp:
2062         (WKQCA::CAView::Handle::create):
2063         Return Ref<Handle> instead of RefPtr<>.
2064
2065         (WKQCA::CAView::Handle::lock):
2066         (WKQCA::CAView::Handle::view const):
2067         (WKQCA::CAView::Handle::clear):
2068         (WKQCA::views):
2069         (WKQCA::viewsNeedingUpdate):
2070         (WKQCA::CAView::releaseAllD3DResources):
2071         (WKQCA::CAView::CAView):
2072         (WKQCA::CAView::~CAView):
2073         (WKQCA::CAView::setLayer):
2074         (WKQCA::CAView::update):
2075         (WKQCA::CAView::drawToWindow):
2076         (WKQCA::CAView::drawToWindowInternal):
2077         (WKQCA::CAView::drawToImage):
2078         (WKQCA::CAView::willDraw):
2079         (WKQCA::CAView::drawIntoDC):
2080         (WKQCA::CAView::setShouldInvertColors):
2081         (WKQCA::CAView::scheduleNextDraw):
2082         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2083         (WKQCA::CAView::contextDidChange):
2084         (WKQCA::CAView::updateSoon):
2085         (WKQCA::CAView::updateViewsNow):
2086         (WKQCA::CAView::d3dDevice9):
2087         (WKQCA::CAView::Handle::mutex): Deleted.
2088         (WKQCA::globalStateMutex): Deleted.
2089         (): Deleted.
2090         * WebKitQuartzCoreAdditions/CAView.h:
2091
2092 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2093
2094         Use StaticLock instead of NeverDestroyed<Lock>
2095         https://bugs.webkit.org/show_bug.cgi?id=180507
2096
2097         Reviewed by Saam Barati.
2098
2099         * WebLocalizableStrings.cpp:
2100         (findCachedString):
2101         (cacheString):
2102         (mainBundleLocStrings): Deleted.
2103         (frameworkLocStringsMutex): Deleted.
2104
2105 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
2106
2107         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
2108         https://bugs.webkit.org/show_bug.cgi?id=180431
2109         <rdar://problem/34531264>
2110
2111         Reviewed by Simon Fraser.
2112
2113         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
2114         'override' to make sure this doesn't break in the future.
2115
2116         * WebView.cpp:
2117         (WebView::notifyAnimationStarted):
2118         (WebView::paintContents):
2119         * WebView.h:
2120
2121 2017-11-23  Darin Adler  <darin@apple.com>
2122
2123         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2124         https://bugs.webkit.org/show_bug.cgi?id=179981
2125
2126         Reviewed by Sam Weinig.
2127
2128         * WebView.cpp:
2129         (WebView::searchFor): Use |= instead of | to build FindOptions.
2130         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
2131         (WebView::findString): Create FindOptions with |=; the old code just passed a
2132         WebKit FindOptions through without converting to WebCore::FindOptions.
2133
2134 2017-11-23  Darin Adler  <darin@apple.com>
2135
2136         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2137         https://bugs.webkit.org/show_bug.cgi?id=179907
2138
2139         Reviewed by Sam Weinig.
2140
2141         * Plugins/PluginDatabaseWin.cpp:
2142         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
2143         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
2144         * WebDownloadCFNet.cpp:
2145         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
2146
2147         * WebView.cpp:
2148         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
2149         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
2150         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
2151         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
2152         the code does not cause any change in behavior.
2153
2154 2017-11-22  Ali Juma  <ajuma@chromium.org>
2155
2156         Implement VisualViewport API attributes
2157         https://bugs.webkit.org/show_bug.cgi?id=179385
2158
2159         Reviewed by Frédéric Wang.
2160
2161         Add a VisualViewportAPI preference.
2162
2163         * Interfaces/IWebPreferencesPrivate.idl:
2164         * WebPreferenceKeysPrivate.h:
2165         * WebPreferences.cpp:
2166         (WebPreferences::initializeDefaultSettings):
2167         (WebPreferences::visualViewportAPIEnabled):
2168         (WebPreferences::setVisualViewportAPIEnabled):
2169         * WebPreferences.h:
2170         * WebView.cpp:
2171         (WebView::notifyPreferencesChanged):
2172
2173 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2174
2175         Unreviewed, rolling out r225093.
2176         https://bugs.webkit.org/show_bug.cgi?id=179938
2177
2178         Compilation failed on WinCairo 64-bit Release (Requested by
2179         fredw on #webkit).
2180
2181         Reverted changeset:
2182
2183         "Implement VisualViewport API attributes"
2184         https://bugs.webkit.org/show_bug.cgi?id=179385
2185         https://trac.webkit.org/changeset/225093
2186
2187 2017-11-21  Ali Juma  <ajuma@chromium.org>
2188
2189         Implement VisualViewport API attributes
2190         https://bugs.webkit.org/show_bug.cgi?id=179385
2191
2192         Reviewed by Frédéric Wang.
2193
2194         Add a VisualViewportAPI preference.
2195
2196         * Interfaces/IWebPreferencesPrivate.idl:
2197         * WebPreferenceKeysPrivate.h:
2198         * WebPreferences.cpp:
2199         (WebPreferences::initializeDefaultSettings):
2200         (WebPreferences::visualViewportAPIEnabled):
2201         (WebPreferences::setVisualViewportAPIEnabled):
2202         * WebPreferences.h:
2203         * WebView.cpp:
2204         (WebView::notifyPreferencesChanged):
2205
2206 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2207
2208         Clean up old URL parser remnants
2209         https://bugs.webkit.org/show_bug.cgi?id=179573
2210
2211         Reviewed by Darin Adler.
2212
2213         * WebCoreSupport/WebContextMenuClient.cpp:
2214         (WebContextMenuClient::searchWithGoogle):
2215         Use https if we do end up searching with google.
2216
2217 2017-11-12  Darin Adler  <darin@apple.com>
2218
2219         More is<> and downcast<>, less static_cast<>
2220         https://bugs.webkit.org/show_bug.cgi?id=179600
2221
2222         Reviewed by Chris Dumez.
2223
2224         * WebView.cpp:
2225         (WebView::handleEditingKeyboardEvent): Use downcast.
2226
2227 2017-11-09  Christopher Reid  <chris.reid@sony.com>
2228
2229         Use enum classes within FileSystem
2230         https://bugs.webkit.org/show_bug.cgi?id=175172
2231
2232         Reviewed by Darin Adler.
2233
2234         * Plugins/PluginDatabase.cpp:
2235
2236 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
2237
2238         [Win] Add WebKitQuartzCoreAdditions library.
2239         https://bugs.webkit.org/show_bug.cgi?id=179331
2240
2241         Reviewed by Alex Christensen.
2242
2243         * WebKitQuartzCoreAdditions: Added.
2244         * WebKitQuartzCoreAdditions/API: Added.
2245         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
2246         (toImage):
2247         (WKCACFImageGetWidth):
2248         (WKCACFImageGetHeight):
2249         (WKCACFImageCopyFileMapping):
2250         (WKCACFImageCreateWithImage):
2251         (WKCACFImageFinalize):
2252         (WKCACFImageCopyFormattingDescription):
2253         (WKCACFImageCopyDebugDescription):
2254         (WKCACFImageGetTypeID):
2255         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
2256         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
2257         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
2258         (toView):
2259         (toImpl):
2260         (WKCACFViewCreate):
2261         (WKCACFViewSetLayer):
2262         (WKCACFViewUpdate):
2263         (WKCACFViewFlushContext):
2264         (WKCACFViewInvalidateRects):
2265         (WKCACFViewCanDraw):
2266         (WKCACFViewDraw):
2267         (WKCACFViewCopyDrawnImage):
2268         (WKCACFViewDrawIntoDC):
2269         (contextDidChangeCallback):
2270         (WKCACFViewSetContextDidChangeCallback):
2271         (WKCACFViewGetLastCommitTime):
2272         (WKCACFViewSetContextUserData):
2273         (WKCACFViewGetContext):
2274         (WKCACFViewFinalize):
2275         (WKCACFViewCopyFormattingDescription):
2276         (WKCACFViewCopyDebugDescription):
2277         (WKCACFViewGetTypeID):
2278         (WKCACFViewSetShouldInvertColors):
2279         (WKCACFViewGetD3DDevice9):
2280         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
2281         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
2282         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
2283         (WKQCA::dllInstance):
2284         (DllMain):
2285         (WKCACFShutDown):
2286         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
2287         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
2288         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
2289         (WKQCA::d3d):
2290         (WKQCA::initialPresentationParameters):
2291         (WKQCA::CAD3DRenderer::shared):
2292         (WKQCA::CAD3DRenderer::CAD3DRenderer):
2293         (WKQCA::CAD3DRenderer::swapChain):
2294         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
2295         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
2296         (WKQCA::CAD3DRenderer::initialize):
2297         (WKQCA::D3DMatrixOrthoOffCenterRH):
2298         (WKQCA::prepareDevice):
2299         (WKQCA::updateBounds):
2300         (WKQCA::CAD3DRenderer::renderAndPresent):
2301         (WKQCA::CAD3DRenderer::renderToImage):
2302         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2303         (WKQCA::CAD3DRenderer::renderInternal):
2304         (WKQCA::CAD3DRenderer::postProcess):
2305         (WKQCA::CAD3DRenderer::resetD3DDevice):
2306         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
2307         (WKQCA::CAD3DRenderer::release):
2308         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
2309         (WKQCA::D3DPostProcessingContext::sceneTexture const):
2310         (WKQCA::D3DPostProcessingContext::overlayQuad const):
2311         (WKQCA::CAD3DRenderer::d3dDevice9 const):
2312         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
2313         (WKQCA::CAView::Handle::create):
2314         (WKQCA::CAView::Handle::~Handle):
2315         (WKQCA::CAView::Handle::mutex):
2316         (WKQCA::CAView::Handle::view const):
2317         (WKQCA::CAView::Handle::clear):
2318         (WKQCA::CAView::Handle::Handle):
2319         (WKQCA::globalStateMutex):
2320         (WKQCA::registerMessageWindowClass):
2321         (WKQCA::createMessageWindow):
2322         (WKQCA::CAView::releaseAllD3DResources):
2323         (WKQCA::CAView::CAView):
2324         (WKQCA::CAView::~CAView):
2325         (WKQCA::CAView::create):
2326         (WKQCA::CAView::setContextDidChangeCallback):
2327         (WKQCA::CAView::setLayer):
2328         (WKQCA::CAView::update):
2329         (WKQCA::CAView::invalidateRects):
2330         (WKQCA::CAView::drawToWindow):
2331         (WKQCA::CAView::drawToWindowInternal):
2332         (WKQCA::CAView::drawToImage):
2333         (WKQCA::CAView::willDraw):
2334         (WKQCA::CAView::didDraw):
2335         (WKQCA::CAView::drawIntoDC):
2336         (WKQCA::CAView::setShouldInvertColors):
2337         (WKQCA::CAView::scheduleNextDraw):
2338         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2339         (WKQCA::CAView::contextDidChangeCallback):
2340         (WKQCA::CAView::contextDidChange):
2341         (WKQCA::CAView::updateSoon):
2342         (WKQCA::CAView::updateViewsNow):
2343         (WKQCA::CAView::d3dDevice9):
2344         * WebKitQuartzCoreAdditions/CAView.h: Added.
2345         (WKQCA::CAView::context const):
2346         (WKQCA::CAView::canDraw const):
2347         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
2348         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
2349         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
2350         (WKQCA::CVDisplayLink::CVDisplayLink):
2351         (WKQCA::CVDisplayLink::~CVDisplayLink):
2352         (WKQCA::CVDisplayLink::create):
2353         (WKQCA::CVDisplayLink::start):
2354         (WKQCA::CVDisplayLink::stop):
2355         (WKQCA::CVDisplayLink::setPaused):
2356         (WKQCA::CVDisplayLink::runIOThread):
2357         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
2358         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
2359         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
2360         * WebKitQuartzCoreAdditions/Image.cpp: Added.
2361         (WKQCA::numBytesForSize):
2362         (WKQCA::Image::create):
2363         (WKQCA::Image::Image):
2364         (WKQCA::Image::~Image):
2365         (WKQCA::bitmapInfo):
2366         (WKQCA::Image::createDIB const):
2367         (WKQCA::Image::copyFileMapping):
2368         * WebKitQuartzCoreAdditions/Image.h: Added.
2369         (WKQCA::Image::size const):
2370         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
2371         (WKQCA::getBackBufferRectAsRenderTarget):
2372         (WKQCA::getSystemMemoryCopy):
2373         (WKQCA::copyRectToBitmap):
2374         (WKQCA::getImageCopy):
2375         (WKQCA::getBackBufferRectAsImage):
2376         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
2377         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
2378         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
2379         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
2380         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
2381
2382 2017-11-06  Christopher Reid  <chris.reid@sony.com>
2383
2384         Use enum classes within FileSystem
2385         https://bugs.webkit.org/show_bug.cgi?id=175172
2386
2387         Reviewed by Myles C. Maxfield.
2388
2389         * Plugins/PluginDatabase.cpp:
2390
2391 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
2392
2393         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
2394         https://bugs.webkit.org/show_bug.cgi?id=178333
2395
2396         Reviewed by Darin Adler.
2397
2398         * WebCoreSupport/WebFrameLoaderClient.cpp:
2399         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
2400
2401 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2402
2403         Use CompletionHandlers for redirects
2404         https://bugs.webkit.org/show_bug.cgi?id=179163
2405
2406         Reviewed by Tim Horton.
2407
2408         * Plugins/PluginStream.cpp:
2409         (WebCore::PluginStream::willSendRequest):
2410         * Plugins/PluginStream.h:
2411         (WebCore::PluginStreamClient::~PluginStreamClient):
2412         (WebCore::PluginStreamClient::streamDidFinishLoading):
2413         (WebCore::PluginStream::create):
2414         (WebCore::PluginStream::setLoadManually):
2415
2416 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2417
2418         Add a FileSystem namespace to FileSystem.cpp
2419         https://bugs.webkit.org/show_bug.cgi?id=179063
2420
2421         Reviewed by Darin Adler.
2422
2423         * Plugins/PluginDatabase.cpp:
2424         * Plugins/PluginPackage.cpp:
2425         * Plugins/PluginStream.cpp:
2426         * Plugins/PluginStream.h:
2427         * WebApplicationCache.cpp:
2428         * WebDatabaseManager.cpp:
2429         * WebDownloadCurl.cpp:
2430         * WebPreferences.cpp:
2431         * WebView.cpp:
2432
2433 2017-10-31  Alex Christensen  <achristensen@webkit.org>
2434
2435         Fix Windows build after r224260
2436
2437         * WebView.cpp:
2438         (WebView::gesture):
2439
2440 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2441
2442         [FrameView::layout cleanup] Move core layout logic to a separate class.
2443         https://bugs.webkit.org/show_bug.cgi?id=178771
2444         <rdar://problem/35166542>
2445
2446         Reviewed by Simon Fraser.
2447
2448         Move layout code out from FrameView to LayoutContext.
2449
2450         * WebFrame.cpp:
2451         (WebFrame::layout):
2452
2453 2017-10-26  Alex Christensen  <achristensen@webkit.org>
2454
2455         Fix Windows build
2456         https://bugs.webkit.org/show_bug.cgi?id=178892
2457
2458         * AccessibleBase.cpp:
2459         (MSAARole):
2460
2461 2017-10-26  Alex Christensen  <achristensen@webkit.org>
2462
2463         Fix Windows build
2464         https://bugs.webkit.org/show_bug.cgi?id=178892
2465
2466         * AccessibleBase.cpp:
2467         (AccessibleBase::state const):
2468         (MSAARole):
2469
2470 2017-10-25  Youenn Fablet  <youenn@apple.com>
2471
2472         Enable ServiceWorker to fetch resources
2473         https://bugs.webkit.org/show_bug.cgi?id=178673
2474
2475         Reviewed by Brady Eidson.
2476
2477         Added implementation to the new getters.
2478         They are noop in the context of WK1.
2479
2480         * WebCoreSupport/WebFrameLoaderClient.cpp:
2481         (WebFrameLoaderClient::pageID const):
2482         (WebFrameLoaderClient::frameID const):
2483         (WebFrameLoaderClient::sessionID const):
2484         * WebCoreSupport/WebFrameLoaderClient.h:
2485
2486 2017-10-20  Antoine Quint  <graouts@apple.com>
2487
2488         [Web Animations] Provide basic timeline and animation interfaces
2489         https://bugs.webkit.org/show_bug.cgi?id=178526
2490
2491         Reviewed by Dean Jackson.
2492
2493         Remove the WEB_ANIMATIONS compile-time flag.
2494
2495         * WebView.cpp:
2496         (WebView::notifyPreferencesChanged):
2497
2498 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2499
2500         [Curl] Clean up old style code in old curl files.
2501         https://bugs.webkit.org/show_bug.cgi?id=178569
2502
2503         Reviewed by Ryosuke Niwa.
2504
2505         * WebCache.cpp:
2506         (WebCache::cacheFolder):
2507         (WebCache::setCacheFolder):
2508         * WebView.cpp:
2509         (WebView::setCacheModel):
2510
2511 2017-10-19  Sam Weinig  <sam@webkit.org>
2512
2513         [Settings] Move global settings into their own file
2514         https://bugs.webkit.org/show_bug.cgi?id=178512
2515
2516         Reviewed by Darin Adler.
2517
2518         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2519
2520         * WebView.cpp:
2521         (WebView::initWithFrame):
2522
2523 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2524
2525         Replace some stack raw pointers with RefPtrs within WebCore/html
2526         https://bugs.webkit.org/show_bug.cgi?id=178201
2527         <rdar://problem/34841692>
2528
2529         Reviewed by Ryosuke Niwa.
2530
2531         * WebView.cpp:
2532         (WebView::handleEditingKeyboardEvent):
2533         Change the type of node as toNode() is changed to return RefPtr.
2534
2535 2017-10-16  Sam Weinig  <sam@webkit.org>
2536
2537         [Settings] Remove all custom code from Settings.h/cpp
2538         https://bugs.webkit.org/show_bug.cgi?id=178330
2539
2540         Reviewed by Simon Fraser.
2541
2542         * WebView.cpp:
2543         (WebView::notifyPreferencesChanged):
2544             
2545             Update for naming changes of FrameFlattening now that it is an enum class.
2546
2547 2017-10-11  Chris Dumez  <cdumez@apple.com>
2548
2549         Modernize Geolocation code
2550         https://bugs.webkit.org/show_bug.cgi?id=178148
2551
2552         Reviewed by Ryosuke Niwa.
2553
2554         * WebCoreSupport/WebGeolocationClient.cpp:
2555         (WebGeolocationClient::lastPosition):
2556         * WebCoreSupport/WebGeolocationClient.h:
2557         * WebGeolocationPosition.cpp:
2558         (WebGeolocationPosition::initWithTimestamp):
2559         (core):
2560         * WebGeolocationPosition.h:
2561         (WebGeolocationPosition::impl const):
2562
2563 2017-10-05  Chris Dumez  <cdumez@apple.com>
2564
2565         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2566         https://bugs.webkit.org/show_bug.cgi?id=177957
2567
2568         Reviewed by Alex Christensen.
2569
2570         * WebCoreSupport/WebPlatformStrategies.cpp:
2571         (WebPlatformStrategies::cookiesEnabled):
2572         * WebCoreSupport/WebPlatformStrategies.h:
2573
2574 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2575
2576         [Curl] Reimplement CurlDownload with CurlRequest
2577         https://bugs.webkit.org/show_bug.cgi?id=177779
2578
2579         Reviewed by Alex Christensen.
2580
2581         * WebDownload.h:
2582         * WebDownloadCurl.cpp:
2583         (WebDownload::init):
2584         (WebDownload::didReceiveResponse):
2585
2586 2017-09-29  Chris Dumez  <cdumez@apple.com>
2587
2588         Split some logic out of VisitedLinkStore and make it reusable
2589         https://bugs.webkit.org/show_bug.cgi?id=177575
2590
2591         Reviewed by Alex Christensen.
2592
2593         * WebCoreSupport/WebVisitedLinkStore.cpp:
2594         (WebVisitedLinkStore::addVisitedLink):
2595         (WebVisitedLinkStore::isLinkVisited):
2596         (WebVisitedLinkStore::addVisitedLinkHash):
2597         * WebCoreSupport/WebVisitedLinkStore.h:
2598
2599 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2600
2601         Make PolicyAction an encodable enum class
2602         https://bugs.webkit.org/show_bug.cgi?id=177480
2603
2604         Reviewed by Antti Koivisto.
2605
2606         * WebCoreSupport/WebFrameLoaderClient.cpp:
2607         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2608         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2609         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2610         * WebFramePolicyListener.cpp:
2611         (WebFramePolicyListener::use):
2612         (WebFramePolicyListener::download):
2613         (WebFramePolicyListener::ignore):
2614         (WebFramePolicyListener::continueSubmit):
2615
2616 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
2617
2618         [Win] fast/canvas/2d.getPath.modification.html is failing.
2619         https://bugs.webkit.org/show_bug.cgi?id=176534
2620
2621         Reviewed by Alex Christensen.
2622
2623         We need to enable Inspector additions at runtime in order to expose the getPath function.
2624
2625         * Interfaces/IWebPreferencesPrivate.idl:
2626         * WebPreferenceKeysPrivate.h:
2627         * WebPreferences.cpp:
2628         (WebPreferences::initializeDefaultSettings):
2629         (WebPreferences::setDataTransferItemsEnabled):
2630         (WebPreferences::inspectorAdditionsEnabled):
2631         (WebPreferences::setInspectorAdditionsEnabled):
2632         * WebPreferences.h:
2633         * WebView.cpp:
2634         (WebView::notifyPreferencesChanged):
2635
2636 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2637
2638         Modernize Geolocation code
2639         https://bugs.webkit.org/show_bug.cgi?id=176496
2640
2641         Reviewed by Andy Estes.
2642
2643         * WebCoreSupport/WebGeolocationClient.cpp:
2644         (WebGeolocationClient::requestPermission):
2645         * WebCoreSupport/WebGeolocationClient.h:
2646         (WebGeolocationClient::setEnableHighAccuracy): Deleted.
2647         (WebGeolocationClient::cancelPermissionRequest): Deleted.
2648         * WebGeolocationPolicyListener.h:
2649         * WebView.cpp:
2650         (WebView::initWithFrame):
2651         (WebView::geolocationDidFailWithError):
2652
2653 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
2654
2655         [Win] Enable DatatransferItems in DRT.
2656         https://bugs.webkit.org/show_bug.cgi?id=176424
2657
2658         Reviewed by Brent Fulgham.
2659
2660         * Interfaces/IWebPreferencesPrivate.idl:
2661         * WebPreferenceKeysPrivate.h:
2662         * WebPreferences.cpp:
2663         (WebPreferences::initializeDefaultSettings):
2664         (WebPreferences::QueryInterface):
2665         (WebPreferences::isSecureContextAttributeEnabled):
2666         (WebPreferences::dataTransferItemsEnabled):
2667         (WebPreferences::setDataTransferItemsEnabled):
2668         * WebPreferences.h:
2669         * WebView.cpp:
2670         (WebView::notifyPreferencesChanged):
2671
2672 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2673
2674         Unreviewed build fix #2 after r221275.
2675
2676         * WebCoreSupport/WebPlatformStrategies.cpp:
2677         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
2678         to match new API.
2679         * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
2680
2681 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2682
2683         Unreviewed build fix after r221275.
2684
2685         * WebCoreSupport/WebPlatformStrategies.cpp:
2686         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
2687         to match new API.
2688
2689 2017-08-28  Per Arne Vollan  <pvollan@apple.com>
2690
2691         [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
2692         https://bugs.webkit.org/show_bug.cgi?id=176031
2693
2694         Reviewed by Brent Fulgham.
2695
2696         When the function in the FramePolicyFunction parameter is called, it has already been moved
2697         to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
2698         function by using the stored member instead.
2699
2700         * WebCoreSupport/WebFrameLoaderClient.cpp:
2701         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2702         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2703         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2704
2705 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2706
2707         Unreviewed, try to fix the Windows build after r221064
2708
2709         didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
2710
2711         * WebCoreSupport/WebEditorClient.h:
2712
2713 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2714
2715         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2716         https://bugs.webkit.org/show_bug.cgi?id=175370
2717         <rdar://problem/33799806>
2718
2719         Reviewed by Ryosuke Niwa.
2720
2721         Adjust WebEditorClient for interface changes.
2722
2723         * WebCoreSupport/WebEditorClient.h:
2724
2725 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
2726
2727         Unreviewed build fix after r221017.
2728
2729         Correct copy/paste error.
2730
2731         * WebCoreSupport/WebPlatformStrategies.cpp:
2732         (WebPlatformStrategies::cookiesForDOM):
2733
2734 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
2735
2736         Unreviewed build fix after r221017.
2737
2738         * WebCoreSupport/WebPlatformStrategies.cpp:
2739         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
2740         * WebCoreSupport/WebPlatformStrategies.h:
2741
2742 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2743
2744         Remove ChromeClient::scrollbarsModeDidChange
2745         https://bugs.webkit.org/show_bug.cgi?id=175805
2746
2747         Reviewed by Daniel Bates.
2748
2749         * WebCoreSupport/WebChromeClient.h:
2750
2751 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2752
2753         Remove ChromeClient::hasOpenedPopup
2754         https://bugs.webkit.org/show_bug.cgi?id=175804
2755
2756         Reviewed by Sam Weinig.
2757
2758         * WebCoreSupport/WebChromeClient.cpp:
2759         (WebChromeClient::hasOpenedPopup const): Deleted.
2760         * WebCoreSupport/WebChromeClient.h:
2761
2762 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
2763
2764         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
2765         https://bugs.webkit.org/show_bug.cgi?id=173536
2766
2767         Reviewed by Brent Fulgham.
2768
2769         If the tree state is dirty, accessible objects are deleted while iterating over children
2770         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
2771         style is updated before this method is called.
2772
2773         * AccessibleBase.cpp:
2774         (AccessibleBase::getAccessibilityObjectForChild):
2775
2776 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2777
2778         [PAL] Move SessionID into PAL
2779         https://bugs.webkit.org/show_bug.cgi?id=174192
2780
2781         Reviewed by Antti Koivisto.
2782
2783         * WebCoreSupport/WebFrameLoaderClient.cpp:
2784         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2785         * WebCoreSupport/WebFrameLoaderClient.h:
2786         * WebCoreSupport/WebFrameNetworkingContext.cpp:
2787         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
2788         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2789         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2790         (WebFrameNetworkingContext::storageSession const):
2791         * WebCoreSupport/WebPlatformStrategies.cpp:
2792         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2793         * WebCoreSupport/WebPlatformStrategies.h:
2794
2795 2017-08-15  Youenn Fablet  <youenn@apple.com>
2796
2797         [Cache API] Adding generic support for CacheStorage and Cache methods
2798         https://bugs.webkit.org/show_bug.cgi?id=175455
2799
2800         Reviewed by Chris Dumez.
2801
2802         * WebView.cpp:
2803         (WebView::initWithFrame):
2804
2805 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2806
2807         Composition underline color is always black
2808         https://bugs.webkit.org/show_bug.cgi?id=174675
2809
2810         Reviewed by Ryosuke Niwa.
2811
2812         * WebView.cpp:
2813         (WebView::setCompositionForTesting): Use text color for
2814         composition underline.
2815
2816 2017-08-09  Daniel Bates  <dabates@apple.com>
2817
2818         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2819         https://bugs.webkit.org/show_bug.cgi?id=175247
2820         <rdar://problem/33679804>
2821
2822         Reviewed by Brady Eidson.
2823
2824         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2825         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2826         clients that need to make use of this information at this time. If such a needs comes up
2827         then we can expose API/SPI similar to what we do for WebKit.
2828
2829         * WebCoreSupport/WebFrameLoaderClient.cpp:
2830         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2831         * WebCoreSupport/WebFrameLoaderClient.h:
2832
2833 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
2834
2835         Async image decoding for large images should be disabled after the first time a tile is painted
2836         https://bugs.webkit.org/show_bug.cgi?id=174451
2837         <rdar://problem/31246421>
2838
2839         Reviewed by Simon Fraser.
2840
2841         * FullscreenVideoController.cpp:
2842         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
2843         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2844         (AcceleratedCompositingContext::paintContents):
2845         * WebCoreSupport/AcceleratedCompositingContext.h:
2846
2847 2017-07-23  Darin Adler  <darin@apple.com>
2848
2849         More NeverDestroyed and related cleanup
2850         https://bugs.webkit.org/show_bug.cgi?id=174745
2851
2852         Reviewed by Alex Christensen.
2853
2854         * Plugins/PluginDatabase.cpp:
2855         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
2856         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
2857         * Plugins/PluginMainThreadScheduler.cpp:
2858         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
2859         * Plugins/PluginMainThreadScheduler.h: Ditto.
2860         * WebCoreSupport/WebPlatformStrategies.cpp:
2861         (WebPlatformStrategies::initialize): Ditto.
2862         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
2863         * WebHistory.cpp:
2864         (sharedHistoryStorage): Ditto.
2865         * WebLocalizableStrings.cpp:
2866         (mainBundleLocStrings): Ditto.
2867         (frameworkLocStringsMutex): Ditto.
2868         (frameworkLocStrings): Ditto.
2869         * WebView.cpp:
2870         (WebView::standardUserAgentWithApplicationName): Ditto.
2871         Also changed to keep one global string with the prefix of the user agent string
2872         instead of keeping two globals with pieces of that prefix.
2873
2874 2017-07-24  Chris Dumez  <cdumez@apple.com>
2875
2876         Make ExceptionCode a proper enumeration
2877         https://bugs.webkit.org/show_bug.cgi?id=174771
2878
2879         Reviewed by Sam Weinig.
2880
2881         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
2882
2883         * DOMCoreClasses.cpp:
2884         (DOMDocument::createEvent):
2885         * WebView.cpp:
2886         (WebView::prepareCandidateWindow):
2887
2888 2017-07-21  Andreas Kling  <akling@apple.com>
2889
2890         Use more references in event dispatch code
2891         https://bugs.webkit.org/show_bug.cgi?id=174681
2892
2893         Reviewed by Geoffrey Garen.
2894
2895         * DOMEventsClasses.cpp:
2896         (WebEventListener::handleEvent):
2897         * DOMEventsClasses.h:
2898         * Plugins/PluginView.cpp:
2899         (WebCore::PluginView::handleEvent):
2900         * Plugins/PluginView.h:
2901
2902 2017-07-20  Brady Eidson  <beidson@apple.com>
2903
2904         Remove WebIconDatabase from WebKitLegacy/win.
2905         https://bugs.webkit.org/show_bug.cgi?id=174608
2906
2907         Reviewed by Alex Christensen.
2908
2909         It is unused.
2910         
2911         * ForEachCoClass.h:
2912
2913         * Interfaces/IWebIconDatabase.idl: Removed.
2914
2915         * Interfaces/WebKit.idl:
2916
2917         * WebCoreStatistics.cpp:
2918         (WebCoreStatistics::iconPageURLMappingCount):
2919         (WebCoreStatistics::iconRetainedPageURLCount):
2920         (WebCoreStatistics::iconRecordCount):
2921         (WebCoreStatistics::iconsWithDataCount):
2922
2923         * WebIconDatabase.cpp: Removed.
2924         * WebIconDatabase.h: Removed.
2925         * WebKitClassFactory.cpp:
2926
2927         * WebKitDLL.cpp:
2928         (shutDownWebKit):
2929
2930         * WebKitLogging.h:
2931
2932         * WebView.cpp:
2933         (WebView::close):
2934         (WebView::notifyDidAddIcon):
2935         (WebView::registerForIconNotification):
2936         (WebView::dispatchDidReceiveIconFromWebFrame):
2937         (WebView::onNotify):
2938
2939 2017-07-18  Matt Lewis  <jlewis3@apple.com>
2940
2941         Unreviewed, rolling out r219610.
2942
2943         This caused an api failure on all platforms for the test
2944         SnapshotImageLargeAsyncDecoding
2945
2946         Reverted changeset:
2947
2948         "Async image decoding for large images should be disabled
2949         after the first time a tile is painted"
2950         https://bugs.webkit.org/show_bug.cgi?id=174451
2951         http://trac.webkit.org/changeset/219610
2952
2953 2017-07-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
2954
2955         Async image decoding for large images should be disabled after the first time a tile is painted
2956         https://bugs.webkit.org/show_bug.cgi?id=174451
2957
2958         Reviewed by Simon Fraser.
2959
2960         * FullscreenVideoController.cpp:
2961         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
2962         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2963         (AcceleratedCompositingContext::paintContents):
2964         * WebCoreSupport/AcceleratedCompositingContext.h:
2965
2966 2017-07-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2967
2968         [Curl] Don't start downloading more than once for same request
2969         https://bugs.webkit.org/show_bug.cgi?id=174172
2970
2971         Reviewed by Alex Christensen.
2972
2973         * WebDownloadCurl.cpp:
2974         (WebDownload::init):
2975
2976 2017-07-12  Daniel Bates  <dabates@apple.com>
2977
2978         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
2979         https://bugs.webkit.org/show_bug.cgi?id=174427
2980
2981         Rubber-stamped by Brady Eidson.
2982
2983         * Plugins/PluginView.cpp:
2984         (WebCore::PluginView::start):
2985         (WebCore::PluginView::getURLNotify):
2986         (WebCore::PluginView::getURL):
2987         (WebCore::PluginView::handlePost):
2988
2989 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2990
2991         [WTF] Move SoftLinking.h into WTF
2992         https://bugs.webkit.org/show_bug.cgi?id=174000
2993
2994         Reviewed by Alex Christensen.
2995
2996         * WebKitClassFactory.cpp:
2997         * WebView.cpp:
2998
2999 2017-07-05  Brady Eidson  <beidson@apple.com>
3000
3001         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3002         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3003
3004         Reviewed by Alex Christensen.
3005
3006         Adopt to the new constructor for FrameLoadRequest.
3007
3008         * Plugins/PluginView.cpp:
3009         (WebCore::PluginView::start):
3010         (WebCore::PluginView::getURLNotify):
3011         (WebCore::PluginView::getURL):
3012         (WebCore::PluginView::handlePost):
3013
3014 2017-07-03  Brady Eidson  <beidson@apple.com>
3015
3016         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3017         https://bugs.webkit.org/show_bug.cgi?id=174073
3018
3019         Reviewed by Andy Estes.
3020
3021         * WebCoreSupport/WebFrameLoaderClient.cpp:
3022         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3023         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3024         * WebCoreSupport/WebFrameLoaderClient.h:
3025
3026 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3027
3028         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3029         https://bugs.webkit.org/show_bug.cgi?id=174004
3030
3031         Reviewed by Simon Fraser.
3032
3033         * WebCoreSupport/WebFrameLoaderClient.cpp:
3034         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3035
3036 2017-06-30  Daniel Bates  <dabates@apple.com>
3037
3038         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3039         https://bugs.webkit.org/show_bug.cgi?id=165160
3040         <rdar://problem/29451999>
3041
3042         Reviewed by Brady Eidson.
3043
3044         Pass the document that is requesting the load to the loader.
3045
3046         * Plugins/PluginView.cpp:
3047         (WebCore::PluginView::start):
3048         (WebCore::PluginView::getURLNotify):
3049         (WebCore::PluginView::getURL):
3050         (WebCore::PluginView::handlePost):
3051
3052 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3053
3054         Refactor drag start codepaths to plumb a DragItem to client layers
3055         https://bugs.webkit.org/show_bug.cgi?id=173832
3056         Work towards <rdar://problem/32236827>
3057
3058         Reviewed by Ryosuke Niwa and Tim Horton.
3059
3060         Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
3061
3062         * WebCoreSupport/WebDragClient.cpp:
3063         (WebDragClient::startDrag):
3064         * WebCoreSupport/WebDragClient.h:
3065
3066 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3067
3068         Remove excessive headers from JavaScriptCore
3069         https://bugs.webkit.org/show_bug.cgi?id=173812
3070
3071         Reviewed by Darin Adler.
3072
3073         * Plugins/PluginPackage.cpp:
3074
3075 2017-06-22  Daniel Bates  <dabates@apple.com>
3076
3077         Make FrameLoadRequest a move-only type
3078         https://bugs.webkit.org/show_bug.cgi?id=173682
3079
3080         Reviewed by Alex Christensen and Darin Adler.
3081
3082         A FrameLoadRequest groups together the information to perform a load into a single object
3083         that is more manageable to pass around than its constituent parts. Code that receives a
3084         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3085         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3086         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
3087
3088         * Plugins/PluginView.cpp:
3089         (WebCore::PluginView::start):
3090         (WebCore::PluginView::performRequest):
3091         (WebCore::PluginView::load):
3092         (WebCore::PluginView::getURLNotify):
3093         (WebCore::PluginView::getURL):
3094         (WebCore::PluginView::handlePost):
3095         * Plugins/PluginView.h:
3096         (WebCore::PluginRequest::PluginRequest):
3097
3098 2017-06-22  Daniel Bates  <dabates@apple.com>
3099
3100         [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
3101         https://bugs.webkit.org/show_bug.cgi?id=173683
3102
3103         Reviewed by Alex Christensen.
3104
3105         Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
3106         header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
3107         by including PluginView.h. The latter does not make use of the functionality
3108         provided by FrameLoadRequest.h.
3109
3110         * Plugins/PluginViewWin.cpp:
3111         * WebCoreSupport/WebContextMenuClient.cpp:
3112
3113 2017-06-21  Daniel Bates  <dabates@apple.com>
3114
3115         Cleanup FrameLoadRequest
3116         https://bugs.webkit.org/show_bug.cgi?id=173564
3117         <rdar://problem/32903570>
3118
3119         Reviewed by Brent Fulgham.
3120
3121         * Plugins/PluginView.cpp:
3122         (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
3123         we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
3124         we do not have one. Use C++11 brace initialization syntax.
3125         (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
3126         name as we do not have one. Use C++11 brace initialization syntax.
3127         (WebCore::PluginView::getURL): Ditto.
3128         (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
3129         function to closer to where it is actually used. Explicitly pass the null-string for the target
3130         frame name as we do not have one. Use C++11 brace initialization syntax.
3131
3132 2017-06-20  Daniel Bates  <dabates@apple.com>
3133
3134         Have FrameLoadRequest takes a Frame& instead of a Frame*
3135         https://bugs.webkit.org/show_bug.cgi?id=173614
3136         <rdar://problem/32884890>
3137
3138         Reviewed by Brent Fulgham.
3139
3140         * Plugins/PluginView.cpp:
3141         (WebCore::PluginView::performRequest):
3142         * WebFrame.cpp:
3143         (WebFrame::loadRequest):
3144
3145 2017-06-19  Chris Dumez  <cdumez@apple.com>
3146
3147         Use WTF::Function instead of std::function in more places in WebCore/
3148         https://bugs.webkit.org/show_bug.cgi?id=173535
3149
3150         Reviewed by Antti Koivisto.
3151
3152         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
3153
3154         * WebCoreSupport/WebFrameLoaderClient.cpp:
3155         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3156         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3157         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3158         (WebFrameLoaderClient::dispatchWillSubmitForm):
3159         (WebFrameLoaderClient::setUpPolicyListener):
3160         (WebFrameLoaderClient::receivedPolicyDecision):
3161         * WebCoreSupport/WebFrameLoaderClient.h:
3162
3163 2017-05-14 Frederic Wang  <fwang@igalia.com>
3164
3165         Add heuristic to avoid flattening "fullscreen" iframes
3166         https://bugs.webkit.org/show_bug.cgi?id=171914
3167
3168         Reviewed by Simon Fraser.
3169
3170         This commit ajusts the window port to internally use the new preference type for frame flattening.
3171         However, the "partial frame flattening" value is not exposed yet.
3172
3173         * WebView.cpp:
3174         (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
3175
3176 2017-06-17  Chris Dumez  <cdumez@apple.com>
3177
3178         Use WTF::Function instead of std::function in WebKit2/
3179         https://bugs.webkit.org/show_bug.cgi?id=173504
3180
3181         Reviewed by Darin Adler.
3182
3183         Use WTF::Function instead of std::function in WebKit2/ to avoid
3184         unnecessary copying.
3185
3186         * Plugins/PluginStream.cpp:
3187         (WebCore::PluginStream::willSendRequest):
3188         * Plugins/PluginStream.h:
3189
3190 2017-06-16  Sam Weinig  <sam@webkit.org>
3191
3192         [WebIDL] Remove custom bindings for HTMLDocument
3193         https://bugs.webkit.org/show_bug.cgi?id=173444
3194
3195         Reviewed by Darin Adler.
3196
3197         * DOMHTMLClasses.cpp:
3198         (DOMHTMLDocument::write):
3199         (DOMHTMLDocument::writeln):
3200         Update for new signature of write/writeln.
3201
3202 2017-06-16  Daniel Bates  <dabates@apple.com>
3203
3204         Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
3205         instead of URL { ParsedURLString, ... }
3206         https://bugs.webkit.org/show_bug.cgi?id=173495
3207         <rdar://problem/32827445>
3208
3209         Reviewed by Alex Christensen.
3210
3211         URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
3212         Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
3213         Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
3214         would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
3215         parse an arbitrary string that looks like a URL.
3216
3217         Also modernize the code using C++14 idioms.
3218
3219         * WebCoreSupport/WebContextMenuClient.cpp:
3220         (WebContextMenuClient::searchWithGoogle):
3221
3222 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
3223
3224         [Win] WebKit shouldn't include the forwarding header of WebKit itself
3225         https://bugs.webkit.org/show_bug.cgi?id=173352
3226
3227         Reviewed by Alex Christensen.
3228
3229         * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
3230
3231 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
3232
3233         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
3234         https://bugs.webkit.org/show_bug.cgi?id=173318
3235
3236         Reviewed by Darin Adler.
3237
3238         The logical frame size is currently calculated by scaling the frame size in pixels,
3239         and rounding the coordinates to the nearest integers. The computed logical frame
3240         size will in some cases be smaller than the scaled frame size in pixels, since it is
3241         represented as an IntSize. In these cases, the bottom line will not be painted.
3242         Instead of calculating the logical frame size by rounding the scaled frame in
3243         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
3244
3245         * WebCoreSupport/WebFrameLoaderClient.cpp:
3246         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3247
3248 2017-06-13  Daniel Bates  <dabates@apple.com>
3249
3250         Implement W3C Secure Contexts Draft Specification
3251         https://bugs.webkit.org/show_bug.cgi?id=158121
3252         <rdar://problem/26012994>
3253
3254         Reviewed by Brent Fulgham.
3255
3256         Part 4
3257
3258         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3259
3260         * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
3261         * WebPreferenceKeysPrivate.h:
3262         * WebPreferences.cpp:
3263         (WebPreferences::initializeDefaultSettings):
3264         (WebPreferences::QueryInterface):
3265         (WebPreferences::setIsSecureContextAttributeEnabled):
3266         (WebPreferences::isSecureContextAttributeEnabled):
3267         * WebPreferences.h:
3268         * WebView.cpp:
3269         (WebView::notifyPreferencesChanged):
3270
3271 2017-06-13  Per Arne Vollan  <pvollan@apple.com>
3272
3273         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
3274         https://bugs.webkit.org/show_bug.cgi?id=173318
3275
3276         Reviewed by Alex Christensen.
3277
3278         The logical frame size is currently calculated by scaling the frame size in pixels,
3279         and rounding the coordinates to the nearest integers. The computed logical frame
3280         size will in some cases be smaller than the scaled frame size in pixels, since it is
3281         represented as an IntSize. In these cases, the bottom line will not be painted.
3282         Instead of calculating the logical frame size by rounding the scaled frame in
3283         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
3284  
3285         * WebView.cpp:
3286         (WebView::sizeChanged):
3287
3288 2017-06-13  Sam Weinig  <sam@webkit.org>
3289
3290         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
3291         https://bugs.webkit.org/show_bug.cgi?id=80733
3292
3293         Reviewed by Chris Dumez.
3294
3295         * WebFrame.cpp:
3296         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
3297
3298 2017-06-12  Daewoong Jang  <daewoong.jang@navercorp.com>
3299
3300         Remove WebCore::unloadModule and related data types
3301         https://bugs.webkit.org/show_bug.cgi?id=173231
3302
3303         Reviewed by Darin Adler.
3304
3305         * Plugins/PlatformModule.h: Added.
3306         (WebCore::PlatformModuleVersion::PlatformModuleVersion):
3307         * Plugins/PluginPackage.cpp:
3308         (WebCore::PluginPackage::freeLibraryTimerFired):
3309         * Plugins/PluginPackage.h:
3310
3311 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3312
3313         [iOS DnD] Add a hook to perform two-step drops in editable content
3314         https://bugs.webkit.org/show_bug.cgi?id=172992
3315         <rdar://problem/32590174>
3316
3317         Reviewed by Tim Horton.
3318
3319         Add a stub implementation for performTwoStepDrop on Windows.
3320
3321         * WebCoreSupport/WebEditorClient.h:
3322
3323 2017-06-04  Konstantin Tokarev  <annulen@yandex.ru>
3324
3325         Fix build of Windows-specific code with ICU 59.1
3326         https://bugs.webkit.org/show_bug.cgi?id=172729
3327
3328         Reviewed by Darin Adler.
3329
3330         Fix conversions from WTF::String to wchar_t* and vice versa.
3331
3332         * Plugins/PluginDatabaseWin.cpp:
3333         (WebCore::addPluginPathsFromRegistry):
3334         (WebCore::PluginDatabase::getPluginPathsInDirectories):
3335         (WebCore::addMozillaPluginDirectories):
3336         (WebCore::addWindowsMediaPlayerPluginDirectory):
3337         (WebCore::addAdobeAcrobatPluginDirectory):
3338         (WebCore::addJavaPluginDirectory):
3339         (WebCore::safariPluginsDirectory):
3340         (WebCore::addMacromediaPluginDirectories):
3341         * Plugins/PluginPackageWin.cpp:
3342         (WebCore::getVersionInfo):
3343         (WebCore::PluginPackage::fetchInfo):
3344         (WebCore::PluginPackage::load):
3345         * Plugins/PluginViewWin.cpp:
3346         (WebCore::PluginView::handlePostReadFile):
3347
3348 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
3349
3350         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
3351         https://bugs.webkit.org/show_bug.cgi?id=172709
3352
3353         Reviewed by Brent Fulgham.
3354
3355         Add method to exit fullscreen mode.
3356
3357         * Interfaces/IWebViewPrivate.idl:
3358         * WebView.cpp:
3359         (WebView::exitFullscreenIfNeeded):
3360         * WebView.h:
3361
3362 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
3363
3364         [Win] Create unique network storage session for each DRT.
3365         https://bugs.webkit.org/show_bug.cgi?id=172540
3366
3367         Reviewed by Brent Fulgham.
3368
3369         During layout testing, each DRT instance should have its own network storage session.
3370
3371         * Interfaces/IWebPreferencesPrivate.idl:
3372         * WebPreferences.cpp:
3373         (WebPreferences::switchNetworkLoaderToNewTestingSession):
3374         * WebPreferences.h:
3375
3376 2017-05-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3377
3378         [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
3379         https://bugs.webkit.org/show_bug.cgi?id=172535
3380
3381         Reviewed by Konstantin Tokarev.
3382
3383         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3384         (AcceleratedCompositingContext::paintContents): Append the fifth argument.
3385         * WebCoreSupport/AcceleratedCompositingContext.h: Ditto.
3386
3387 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
3388
3389         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
3390         https://bugs.webkit.org/show_bug.cgi?id=172071
3391
3392         Reviewed by Alexey Proskuryakov.
3393
3394         We need to delete all cookies after each test.
3395
3396         * Interfaces/IWebPreferencesPrivate.idl:
3397         * WebPreferences.cpp:
3398         (WebPreferences::linkPreloadEnabled):
3399         (WebPreferences::clearNetworkLoaderSession):
3400         * WebPreferences.h:
3401
3402 2017-05-13  Chris Dumez  <cdumez@apple.com>
3403
3404         Stop using RefPtr::release()
3405         https://bugs.webkit.org/show_bug.cgi?id=172074
3406
3407         Reviewed by Geoffrey Garen.
3408
3409         * WebFrame.cpp:
3410         (WebFrame::loadPlainTextString):
3411         (WebFrame::loadHTMLString):
3412         * WebFramePolicyListener.cpp:
3413         (WebFramePolicyListener::receivedPolicyDecision):
3414
3415 2017-05-13  Chris Dumez  <cdumez@apple.com>
3416
3417         Drop uses of PassRefPtr in WebKit/win
3418         https://bugs.webkit.org/show_bug.cgi?id=172067
3419
3420         Reviewed by Yusuke Suzuki.
3421
3422         * DOMEventsClasses.cpp:
3423         (DOMEvent::DOMEvent):
3424         (DOMEvent::createInstance):
3425         * DOMEventsClasses.h:
3426         (DOMUIEvent::DOMUIEvent):
3427         (DOMKeyboardEvent::DOMKeyboardEvent):
3428         (DOMMouseEvent::DOMMouseEvent):
3429         (DOMMutationEvent::DOMMutationEvent):
3430         (DOMOverflowEvent::DOMOverflowEvent):
3431         (DOMWheelEvent::DOMWheelEvent):
3432         * MemoryStream.cpp:
3433         (MemoryStream::MemoryStream):
3434         (MemoryStream::createInstance):
3435         * MemoryStream.h:
3436         * Plugins/PluginDatabase.cpp:
3437         (WebCore::PluginDatabase::refresh):
3438         (WebCore::PluginDatabase::add):
3439         (WebCore::PluginDatabase::loadPersistentMetadataCache):
3440         * Plugins/PluginDatabase.h:
3441         * Plugins/PluginPackage.cpp:
3442         (WebCore::PluginPackage::createPackage):
3443         (WebCore::PluginPackage::createPackageFromCache):
3444         * Plugins/PluginPackage.h:
3445         * Plugins/PluginStream.h:
3446         (WebCore::PluginStream::create):
3447         * WebActionPropertyBag.cpp:
3448         (WebActionPropertyBag::WebActionPropertyBag):
3449         (WebActionPropertyBag::createInstance):
3450         * WebActionPropertyBag.h:
3451         * WebArchive.cpp:
3452         (WebArchive::createInstance):
3453         (WebArchive::WebArchive):
3454         * WebArchive.h:
3455         * WebBackForwardList.cpp:
3456         (WebBackForwardList::WebBackForwardList):
3457         (WebBackForwardList::createInstance):
3458         * WebBackForwardList.h:
3459         * WebCoreSupport/EmbeddedWidget.cpp:
3460         (EmbeddedWidget::create):
3461         * WebCoreSupport/EmbeddedWidget.h:
3462         * WebCoreSupport/WebChromeClient.h:
3463         * WebFrame.cpp:
3464         (WebFrame::loadData):
3465         (WebFrame::createSubframeWithOwnerElement):
3466         * WebFrame.h:
3467         * WebFramePolicyListener.cpp:
3468         (WebFramePolicyListener::WebFramePolicyListener):
3469         (WebFramePolicyListener::createInstance):
3470         * WebFramePolicyListener.h:
3471         * WebGeolocationPolicyListener.cpp:
3472         (WebGeolocationPolicyListener::createInstance):
3473         (WebGeolocationPolicyListener::WebGeolocationPolicyListener):
3474         * WebGeolocationPolicyListener.h:
3475         * WebHistoryItem.cpp:
3476         (WebHistoryItem::WebHistoryItem):
3477         (WebHistoryItem::createInstance):
3478         * WebHistoryItem.h:
3479         * WebMutableURLRequest.cpp:
3480         (WebMutableURLRequest::setFormData):
3481         (WebMutableURLRequest::formData):
3482         * WebMutableURLRequest.h:
3483         * WebResource.cpp:
3484         (WebResource::createInstance):
3485         * WebResource.h:
3486         * WebScriptWorld.cpp:
3487         (WebScriptWorld::WebScriptWorld):
3488         (WebScriptWorld::createInstance):
3489         * WebScriptWorld.h:
3490         * WebURLAuthenticationChallengeSender.cpp:
3491         (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
3492         (WebURLAuthenticationChallengeSender::createInstance):
3493         * WebURLAuthenticationChallengeSender.h:
3494         * WebView.cpp:
3495         (WebView::setFullScreenElement):
3496         * WebView.h:
3497
3498 2017-05-11  Chris Dumez  <cdumez@apple.com>
3499
3500         Drop remaining uses of PassRefPtr in WebCore
3501         https://bugs.webkit.org/show_bug.cgi?id=172013
3502
3503         Reviewed by Yusuke Suzuki.
3504
3505         * Plugins/PluginView.cpp:
3506         (WebCore::PluginView::bindingInstance):
3507
3508 2017-05-11  Chris Dumez  <cdumez@apple.com>
3509
3510         Stop using PassRefPtr in platform/graphics
3511         https://bugs.webkit.org/show_bug.cgi?id=171977
3512
3513         Reviewed by Alex Christensen.
3514
3515         Build fix.
3516
3517         * FullscreenVideoController.cpp:
3518         (FullscreenVideoController::enterFullscreen):
3519         * WebKitDLL.cpp:
3520         (loadResourceIntoBuffer):
3521
3522 2017-05-09  Sam Weinig  <sam@webkit.org>
3523
3524         Remove support for legacy Notifications
3525         https://bugs.webkit.org/show_bug.cgi?id=171487
3526
3527         Reviewed by Jon Lee.
3528
3529         * WebCoreSupport/WebChromeClient.cpp:
3530         (WebChromeClient::WebChromeClient):
3531         * WebCoreSupport/WebChromeClient.h:
3532         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
3533         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
3534         Remove legacy notification specific code.
3535
3536 2017-05-09  Dean Jackson  <dino@apple.com>
3537
3538         Fix Windows build.
3539
3540         * Plugins/PluginView.h:
3541         * Plugins/PluginViewWin.cpp:
3542         (WebCore::PluginView::paint):
3543
3544 2017-05-06  Alexey Proskuryakov  <ap@apple.com>
3545
3546         REGRESSION (r216294): The new test fails on WebKit1
3547         https://bugs.webkit.org/show_bug.cgi?id=171780
3548
3549         Rolling back https://trac.webkit.org/r216294, https://trac.webkit.org/r216296,
3550         https://trac.webkit.org/216299, https://trac.webkit.org/216330
3551
3552         * Plugins/PluginView.h:
3553         * Plugins/PluginViewWin.cpp:
3554         (WebCore::PluginView::paint):
3555
3556 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
3557
3558         Fix Windows build after r216294.
3559
3560         * Plugins/PluginView.h:
3561         * Plugins/PluginViewWin.cpp:
3562         (WebCore::PluginView::paint):
3563
3564 2017-05-04  Commit Queue  <commit-queue@webkit.org>
3565
3566         Unreviewed, rolling out r216206.
3567         https://bugs.webkit.org/show_bug.cgi?id=171714
3568
3569         Multiple LayoutTests crashing in Document::page() (Requested
3570         by ap on #webkit).
3571
3572         Reverted changeset:
3573
3574         "Remove support for legacy Notifications"
3575         https://bugs.webkit.org/show_bug.cgi?id=171487
3576         http://trac.webkit.org/changeset/216206
3577
3578 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
3579
3580         [Win] Remove redundant macros that are set in the CMake config
3581         https://bugs.webkit.org/show_bug.cgi?id=171571
3582
3583         Reviewed by Brent Fulgham.
3584
3585         * COMEnumVariant.h:
3586         * COMPropertyBag.h:
3587         * WebKitPrefix.h:
3588
3589 2017-05-04  Sam Weinig  <sam@webkit.org>
3590
3591         Remove support for legacy Notifications
3592         https://bugs.webkit.org/show_bug.cgi?id=171487
3593
3594         Reviewed by Jon Lee.
3595
3596         * WebCoreSupport/WebChromeClient.cpp:
3597         (WebChromeClient::WebChromeClient):
3598         * WebCoreSupport/WebChromeClient.h:
3599         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
3600         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
3601         Remove legacy notification specific code.
3602
3603 2017-04-27  Alex Christensen  <achristensen@webkit.org>
3604
3605         Modernize Frame.h
3606         https://bugs.webkit.org/show_bug.cgi?id=171357
3607
3608         Reviewed by Andy Estes.
3609
3610         * WebCoreSupport/WebEditorClient.cpp:
3611         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
3612         * WebCoreSupport/WebEditorClient.h:
3613
3614 2017-04-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3615
3616         [WinCairo] Fix build break after updating ANGLE
3617         https://bugs.webkit.org/show_bug.cgi?id=170980
3618
3619         Reviewed by Brent Fulgham.
3620
3621         * WebCoreSupport/AcceleratedCompositingContext.cpp: Define GL_GLEXT_PROTOTYPES.
3622
3623 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
3624
3625         [Win] REGRESSION(r215486): Windows Release build is broken
3626         https://bugs.webkit.org/show_bug.cgi?id=171024
3627         <rdar://problem/31722618>
3628
3629         Reviewed by Mark Lam.
3630
3631         Windows WebKit refers to a handful of JSC methods that are always
3632         inline. We need to include 'HeapInlines.h' to get the implementation
3633         of these methods.
3634
3635         * Plugins/PluginPackage.cpp:
3636         * WebFrame.cpp:
3637         * WebView.cpp:
3638
3639 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3640
3641         Unreviewed, fix the Windows build after r215385
3642
3643         r215385 introduced a new virtual method on ChromeClient that needs to be implemented in WebChromeClient for
3644         Windows in WebKit1.
3645
3646         * WebCoreSupport/WebChromeClient.cpp:
3647         (WebChromeClient::createIconForFiles):
3648         * WebCoreSupport/WebChromeClient.h:
3649
3650 2017-04-10  Chris Dumez  <cdumez@apple.com>
3651
3652         Drop Timer::startOneShot() overload taking a double
3653         https://bugs.webkit.org/show_bug.cgi?id=170659
3654
3655         Reviewed by Yusuke Suzuki.
3656
3657         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
3658
3659         * Plugins/PluginMessageThrottlerWin.cpp:
3660         (WebCore::PluginMessageThrottlerWin::appendMessage):
3661         (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
3662         * Plugins/PluginViewWin.cpp:
3663         (WebCore::PluginView::invalidateRect):
3664         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3665         (AcceleratedCompositingContext::scheduleLayerFlush):
3666
3667 2017-04-09  Chris Dumez  <cdumez@apple.com>
3668
3669         Drop Timer::startRepeating() overload taking a double
3670         https://bugs.webkit.org/show_bug.cgi?id=170656
3671
3672         Reviewed by Yusuke Suzuki.
3673
3674         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
3675
3676         * FullscreenVideoController.cpp:
3677
3678 2017-04-09  Chris Dumez  <cdumez@apple.com>
3679
3680         Start dropping Timer API dealing with double
3681         https://bugs.webkit.org/show_bug.cgi?id=170649
3682
3683         Reviewed by Yusuke Suzuki.
3684
3685         Start dropping Timer API dealing with double as people should use Seconds now.
3686
3687         * Plugins/PluginPackage.cpp:
3688         (WebCore::PluginPackage::freeLibrarySoon):
3689         * Plugins/PluginStream.cpp:
3690         (WebCore::PluginStream::deliverData):
3691         * Plugins/PluginView.cpp:
3692         (WebCore::PluginView::requestTimerFired):
3693         (WebCore::PluginView::scheduleRequest):
3694         (WebCore::PluginView::setJavaScriptPaused):
3695         (WebCore::PluginView::keepAlive):
3696         * Plugins/PluginViewWin.cpp:
3697         (WebCore::PluginView::wndProc):
3698         * WebView.cpp:
3699         (WebView::closeWindowSoon):
3700
3701 2017-04-08  Chris Dumez  <cdumez@apple.com>
3702
3703         Drop std::chrono support from Timer class
3704         https://bugs.webkit.org/show_bug.cgi?id=170645
3705
3706         Reviewed by Sam Weinig.
3707
3708         Drop std::chrono support from Timer class now that we prefer using Seconds type.
3709
3710         * WebView.cpp:
3711         (WebView::setCacheModel):
3712
3713 2017-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3714
3715         [WinCairo] WebCore::PlatformDisplay::terminateEGLDisplay causes a crash in libGLESv2.dll while processing atexit
3716         https://bugs.webkit.org/show_bug.cgi?id=170331
3717
3718         Reviewed by Michael Catanzaro.
3719
3720         * WebKitDLL.cpp:
3721         (shutDownWebKit): Call PlatformDisplay::shutDownEglDisplays in shutDownWebKit.
3722
3723 2017-03-30  James Craig  <jcraig@apple.com>
3724
3725         AX: Expose a new AXSubrole for explicit ARIA "group" role
3726         https://bugs.webkit.org/show_bug.cgi?id=169810
3727         <rdar://problem/31039693>
3728
3729         Reviewed by Chris Fleizach.
3730
3731         Account for Windows platform role mapping.
3732
3733         * AccessibleBase.cpp:
3734         (MSAARole):
3735
3736 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3737
3738         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
3739         https://bugs.webkit.org/show_bug.cgi?id=169168
3740         <rdar://problem/30688374>
3741
3742         Reviewed by Tim Horton.
3743
3744         Minor tweak to adjust for a changed interface. See WebKit and WebCore ChangeLogs for more information.
3745
3746         * WebCoreSupport/WebDragClient.cpp:
3747         (WebDragClient::actionMaskForDrag):
3748         * WebCoreSupport/WebDragClient.h:
3749
3750 2017-03-13  Per Arne Vollan  <pvollan@apple.com>
3751
3752         [Win] Compile fix.
3753         https://bugs.webkit.org/show_bug.cgi?id=169545
3754
3755         Reviewed by Brent Fulgham.
3756
3757         Fix inconsistent dll linkage warnings.
3758  
3759         * WebKitDLL.cpp:
3760         * WebKitDLL.h:
3761
3762 2017-03-13  Per Arne Vollan  <pvollan@apple.com>
3763
3764         Unreviewed Win build fix.
3765         
3766         WebCore::CookiesStrategy::addCookie has been removed, we should also remove the override.
3767
3768         * WebCoreSupport/WebPlatformStrategies.cpp:
3769         (WebPlatformStrategies::addCookie): Deleted.
3770         (WebPlatformStrategies::addCookie): Deleted.
3771         * WebCoreSupport/WebPlatformStrategies.h:
3772
3773 2017-03-10  Brent Fulgham  <bfulgham@apple.com>
3774
3775         [Win] Re-export a few symbols for backwards compatibility
3776         https://bugs.webkit.org/show_bug.cgi?id=169490
3777         <rdar://problem/30983623>
3778
3779         Reviewed by Dean Jackson.
3780
3781         Re-introduce a workaround that re-exports a few JavaScriptCore functions
3782         that had been erroneously exported by WebKit in older builds. This
3783         is needed so that we do not break certain old software still being used.
3784
3785         * WebKitDLL.cpp:
3786         (DllMain): Bind functions at startup.
3787         (bindJavaScriptTrampoline): Find JavaScriptCore library functions and
3788         re-export them from WebKit.dll.
3789         * WebKitDLL.h: Only advertise these functions when building WebKt itself.
3790
3791 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
3792
3793         Expand font-weight and font-stretch to take any number
3794         https://bugs.webkit.org/show_bug.cgi?id=168889
3795
3796         Reviewed by Simon Fraser.
3797
3798         Migrate off old enum types.
3799
3800         * WebKitGraphics.cpp:
3801         (makeFont):
3802
3803 2017-03-02  Sam Weinig  <sam@webkit.org>
3804
3805         Rename htmlediting.h/cpp to Editing.h/cpp
3806         https://bugs.webkit.org/show_bug.cgi?id=169103
3807
3808         Reviewed by Alex Christensen.
3809
3810         * AccessibleTextImpl.cpp:
3811
3812 2017-03-01  Alex Christensen  <achristensen@webkit.org>
3813
3814         Actually fix Windows build.
3815
3816         * WebFrame.cpp:
3817         (WebFrame::invalidate):
3818         r213266 changed Style::Force to ResolveStyleType::Rebuild, so I did so here.
3819
3820 2017-03-01  Alex Christensen  <achristensen@webkit.org>
3821
3822         Fix Windows build after r213266
3823         https://bugs.webkit.org/show_bug.cgi?id=169049
3824
3825         * WebFrame.cpp:
3826         (WebFrame::invalidate):
3827
3828 2017-02-27  Per Arne Vollan  <pvollan@apple.com>
3829
3830         [Win] Http preload tests are failing.
3831         https://bugs.webkit.org/show_bug.cgi?id=168910
3832
3833         Reviewed by Alex Christensen.
3834
3835         The feature is not enabled.
3836
3837         * WebView.cpp:
3838         (WebView::notifyPreferencesChanged):
3839
3840 2017-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3841
3842         Better handle Thread and RunLoop initialization
3843         https://bugs.webkit.org/show_bug.cgi?id=167828
3844
3845         Reviewed by Yusuke Suzuki.
3846
3847         Remove unnecessary call to WTF::initializeMainThread().
3848
3849         * WebView.cpp:
3850         (WebView::WebView):
3851
3852 2017-02-20  Per Arne Vollan  <pvollan@apple.com>
3853
3854         [Win] Custom scale factor is not applied in all cases.
3855         https://bugs.webkit.org/show_bug.cgi?id=168117
3856
3857         Reviewed by Brent Fulgham.
3858
3859         We should not call the function deviceScaleFactorForWindow directly, since this
3860         will return the system scale factor, and ignore the custom scale factor.
3861
3862         * WebView.cpp:
3863         (WebView::handleContextMenuEvent):
3864         (WebView::handleMouseEvent):
3865         (WebView::setAcceleratedCompositing):
3866
3867 2017-02-16  Daniel Bates  <dabates@apple.com>
3868
3869         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
3870         https://bugs.webkit.org/show_bug.cgi?id=168417
3871         <rdar://problem/30541748>
3872
3873         Reviewed by Brent Fulgham.
3874
3875         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
3876         Widget* as it is always called with a valid Widget.
3877
3878         * WebCoreSupport/WebFrameLoaderClient.cpp:
3879         (WebFrameLoaderClient::redirectDataToPlugin):
3880         * WebCoreSupport/WebFrameLoaderClient.h:
3881
3882 2017-02-15  Anders Carlsson  <andersca@apple.com>
3883
3884         Another attempt at fixing the Windows build.
3885
3886         * WebCoreSupport/WebDragClient.cpp:
3887         (WebDragClient::startDrag):
3888
3889 2017-02-15  Anders Carlsson  <andersca@apple.com>
3890
3891         Try to fix the Windows build.
3892
3893         * WebCoreSupport/WebDragClient.h:
3894
3895 2017-02-15  Anders Carlsson  <andersca@apple.com>
3896
3897         Modernize DragClient::startDrag somewhat
3898         https://bugs.webkit.org/show_bug.cgi?id=168379
3899
3900         Reviewed by Tim Horton.
3901
3902         Update for WebCore changes.
3903
3904         * WebCoreSupport/WebDragClient.cpp:
3905         (WebDragClient::startDrag):
3906
3907 2017-02-10  Daniel Bates  <dabates@apple.com>
3908
3909         Attempt to fix the WinCairo 64-Bit Release build following <https://trac.webkit.org/changeset/212173>
3910         (https://bugs.webkit.org/show_bug.cgi?id=166774)
3911
3912         Touch WebKit.idl in the hopes that it will cause CMake to regenerate the COM interface files.
3913
3914         * Interfaces/WebKit.idl:
3915
3916 2017-02-10  Daniel Bates  <dabates@apple.com>
3917
3918         Detach frame from document when entering page cache
3919         https://bugs.webkit.org/show_bug.cgi?id=166774
3920         <rdar://problem/29904368>
3921
3922         Reviewed by Chris Dumez.
3923
3924         * Interfaces/IWebPreferencesPrivate.idl:
3925         * WebPreferenceKeysPrivate.h:
3926         * WebPreferences.cpp:
3927         (WebPreferences::initializeDefaultSettings):
3928         (WebPreferences::setAllowsPageCacheWithWindowOpener): Deleted.
3929         (WebPreferences::allowsPageCacheWithWindowOpener): Deleted.
3930         * WebPreferences.h:
3931         * WebView.cpp:
3932         (WebView::notifyPreferencesChanged):
3933
3934 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
3935
3936         [Resource Timing] Enable Resource Timing by default in Tests
3937         https://bugs.webkit.org/show_bug.cgi?id=168145
3938
3939         Reviewed by Ryosuke Niwa.
3940
3941         * Interfaces/IWebPreferencesPrivate.idl:
3942         * WebPreferenceKeysPrivate.h:
3943         * WebPreferences.cpp:
3944         (WebPreferences::initializeDefaultSettings):
3945         (WebPreferences::setResourceTimingEnabled):
3946         (WebPreferences::resourceTimingEnabled):
3947         * WebPreferences.h:
3948         * WebView.cpp:
3949         (WebView::notifyPreferencesChanged):
3950
3951 2017-02-06  Alex Christensen  <achristensen@webkit.org>
3952
3953         More build fixes after r211751
3954         https://bugs.webkit.org/show_bug.cgi?id=166998
3955
3956         * WebDownloadCFNet.cpp:
3957         (WebDownload::didReceiveAuthenticationChallenge):
3958
3959 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3960
3961         Rename AnimationController to CSSAnimationController
3962         https://bugs.webkit.org/show_bug.cgi?id=167829
3963
3964         Reviewed by Simon Fraser.
3965
3966         * WebFrame.cpp:
3967
3968 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3969
3970         Drag images should be anchored to the mouse location
3971         https://bugs.webkit.org/show_bug.cgi?id=167690
3972         <rdar://problem/30295261>
3973
3974         Reviewed by Enrica Casucci.
3975
3976         Adds some plumbing for the anchor point in the WK1 client layer.
3977
3978         * WebCoreSupport/WebDragClient.cpp:
3979         (WebDragClient::startDrag):
3980         * WebCoreSupport/WebDragClient.h:
3981
3982 2017-02-02  Per Arne Vollan  <pvollan@apple.com>
3983
3984         [Win][HiDPI] Scale factor is applied twice in accelerated compositing mode.
3985         https://bugs.webkit.org/show_bug.cgi?id=167732
3986
3987         Reviewed by Brent Fulgham.
3988
3989         Backing layer should not be scaled when CACFLayerSetContentsScale is used for scaling.
3990
3991         * WebView.cpp:
3992         (WebView::setAcceleratedCompositing):
3993
3994 2017-02-02  Chris Dumez  <cdumez@apple.com>
3995
3996         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
3997         https://bugs.webkit.org/show_bug.cgi?id=167738
3998         <rdar://problem/30229990>
3999
4000         Reviewed by Andreas Kling.
4001
4002         The BackForwardClient no longer needs to worry about removing HistoryItems
4003         from the PageCache now that WebCore takes care of it.
4004
4005         * BackForwardList.cpp:
4006         (BackForwardList::close):
4007
4008 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
4009
4010         Add Link Preload as an off-by-default experimental feature menu item.
4011         https://bugs.webkit.org/show_bug.cgi?id=167201
4012
4013         Reviewed by Ryosuke Niwa.
4014
4015         * WebPreferenceKeysPrivate.h:
4016         * WebPreferences.cpp:
4017         (WebPreferences::initializeDefaultSettings):
4018         (WebPreferences::valueForKey):
4019         (WebPreferences::setLinkPreloadEnabled):
4020         (WebPreferences::linkPreloadEnabled):
4021         * WebPreferences.h:
4022         * Interfaces/IWebPreferencesPrivate.idl:
4023
4024 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
4025
4026         Add User Timing Experimental Feature
4027         https://bugs.webkit.org/show_bug.cgi?id=167542
4028         <rdar://problem/22746307>
4029
4030         Reviewed by Ryosuke Niwa.
4031
4032         * Interfaces/IWebPreferencesPrivate.idl:
4033         * WebPreferenceKeysPrivate.h:
4034         * WebPreferences.cpp:
4035         (WebPreferences::initializeDefaultSettings):
4036         (WebPreferences::setUserTimingEnabled):
4037         (WebPreferences::userTimingEnabled):
4038         * WebPreferences.h:
4039         * WebView.cpp:
4040         (WebView::notifyPreferencesChanged):
4041         Add setting for User Timing runtime enabled feature.
4042
4043 2017-01-26  Chris Dumez  <cdumez@apple.com>
4044
4045         Crash when navigating back to a page in PacheCache when one of its frames has been removed
4046         https://bugs.webkit.org/show_bug.cgi?id=167421
4047         <rdar://problem/30188490>
4048
4049         Reviewed by Darin Adler.
4050
4051         Add a new setting allowing layout tests to enable PageCache in a window
4052         that has an opener, for convenience.
4053
4054         * WebPreferenceKeysPrivate.h:
4055         * WebPreferences.cpp:
4056         (WebPreferences::initializeDefaultSettings):
4057         * WebPreferences.h:
4058
4059 2017-01-26  Keith Miller  <keith_miller@apple.com>
4060
4061         classInfo should take a VM so it is not materialized from the object on each call
4062         https://bugs.webkit.org/show_bug.cgi?id=167424
4063
4064         Rubber Stamped by Michael Saboff.
4065
4066         Previously, classInfo() would get the VM from the target's
4067         MarkedBlock.  Most callers already have a VM on hand, so it is
4068         wasteful to compute the VM from the marked block every time. This
4069         patch refactors some of the most common callers of classInfo(),
4070         jsDynamicCast and inherits to take a VM as well.
4071
4072         * WebFrame.cpp:
4073         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
4074         * WebView.cpp:
4075         (WebView::elementFromJS):
4076
4077 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
4078
4079         Crash when setting custom scale factor.
4080         https://bugs.webkit.org/show_bug.cgi?id=167369
4081
4082         Reviewed by Sam Weinig.
4083
4084         Add null pointer check.
4085
4086         * WebView.cpp:
4087         (WebView::setCustomBackingScaleFactor):
4088
4089 2017-01-24  Youenn Fablet  <youennf@gmail.com>
4090
4091         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
4092         https://bugs.webkit.org/show_bug.cgi?id=167294
4093
4094         Reviewed by Alex Christensen.
4095
4096         * WebView.cpp:
4097         (WebView::initWithFrame):
4098
4099 2017-01-23  Chris Dumez  <cdumez@apple.com>
4100
4101         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
4102         https://bugs.webkit.org/show_bug.cgi?id=167308
4103         <rdar://problem/30144964>
4104
4105         Unreviewed, do a partial revert of r211033 to fix assertion.
4106
4107         * WebCoreSupport/WebChromeClient.cpp:
4108         (WebChromeClient::exitFullScreenForElement):
4109
4110 2017-01-20  Darin Adler  <darin@apple.com>
4111
4112         Remove PassRefPtr from "page" directory of WebCore, also deploy references
4113         https://bugs.webkit.org/show_bug.cgi?id=167224
4114
4115         Reviewed by Chris Dumez.
4116
4117         * Plugins/PluginView.cpp:
4118         (WebCore::PluginView::status): Pass reference.
4119         (WebCore::PluginView::focusPluginElement): Ditto.
4120
4121         * WebCoreSupport/WebChromeClient.cpp:
4122         (WebChromeClient::createWindow): Updated for change to ChromeClient.
4123         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
4124         (WebChromeClient::runJavaScriptAlert): Ditto.
4125         (WebChromeClient::runJavaScriptConfirm): Ditto.
4126         (WebChromeClient::runJavaScriptPrompt): Ditto.
4127         (WebChromeClient::contentsSizeChanged): Ditto.
4128         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
4129         (WebChromeClient::print): Ditto.
4130         (WebChromeClient::exceededDatabaseQuota): Ditto.
4131         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
4132         (WebChromeClient::attachRootGraphicsLayer): Ditto.
4133         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
4134         (WebChromeClient::enterVideoFullscreenForVideoElement): Ditto.
4135         (WebChromeClient::createPopupMenu): Ditto.
4136         (WebChromeClient::createSearchPopupMenu): Ditto.
4137         (WebChromeClient::supportsFullScreenForElement): Ditto.
4138         (WebChromeClient::enterFullScreenForElement): Ditto.
4139         (WebChromeClient::exitFullScreenForElement): Ditto.
4140         (WebChromeClient::shouldUseTiledBackingForFrameView): Ditto.
4141         * WebCoreSupport/WebChromeClient.h: Ditto.
4142
4143 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
4144
4145         Remove never changing IndexedDB RuntimeEnabledFeature
4146         https://bugs.webkit.org/show_bug.cgi?id=167278
4147
4148         Reviewed by Darin Adler.
4149
4150         * WebView.cpp:
4151         (WebView::notifyPreferencesChanged):
4152
4153 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
4154
4155         Cleanup RuntimeEnabledFeatures
4156         https://bugs.webkit.org/show_bug.cgi?id=167228
4157
4158         Reviewed by Simon Fraser.