Remove IDB-specific quota
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
2
3         Remove IDB-specific quota
4         https://bugs.webkit.org/show_bug.cgi?id=196545
5         <rdar://problem/54201783>
6
7         Reviewed by Youenn Fablet.
8
9         * Interfaces/IWebDatabaseManager.idl:
10         * WebDatabaseManager.cpp:
11         (WebDatabaseManager::setIDBPerOriginQuota): Deleted.
12         * WebDatabaseManager.h:
13
14 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
15
16         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
17         https://bugs.webkit.org/show_bug.cgi?id=200620
18
19         Reviewed by Geoffrey Garen.
20
21         * FullscreenVideoController.cpp:
22         (FullscreenVideoController::FullscreenVideoController):
23         * Plugins/PluginStream.cpp:
24         (WebCore::PluginStream::didReceiveData):
25         * Plugins/PluginView.cpp:
26         (WebCore::PluginView::load):
27         * Plugins/PluginViewWin.cpp:
28         (WebCore::PluginView::wndProc):
29         * WebCoreSupport/WebChromeClient.cpp:
30         (WebChromeClient::WebChromeClient):
31         * WebCoreSupport/WebFrameLoaderClient.cpp:
32         (WebFrameLoaderClient::WebFrameLoaderClient):
33         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
34         * WebCoreSupport/WebInspectorClient.cpp:
35         (WebInspectorClient::openLocalFrontend):
36         (WebInspectorClient::highlight):
37         * WebElementPropertyBag.cpp:
38         (WebElementPropertyBag::WebElementPropertyBag):
39         * WebHistoryItem.cpp:
40         (WebHistoryItem::initFromDictionaryRepresentation):
41         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
42         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
43         * WebNotificationCenter.cpp:
44         (WebNotificationCenter::WebNotificationCenter):
45         * WebView.cpp:
46         (WebView::handleMouseEvent):
47         (WebView::registerEmbeddedViewMIMEType):
48         (WebView::enterVideoFullscreenForVideoElement):
49         (WebView::addUserScriptToGroup):
50         (WebView::addUserStyleSheetToGroup):
51         (WebView::setAcceleratedCompositing):
52
53 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
54
55         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
56         https://bugs.webkit.org/show_bug.cgi?id=200620
57
58         Reviewed by Geoffrey Garen.
59
60         * FullscreenVideoController.cpp:
61         * FullscreenVideoController.h:
62         * Plugins/PluginMessageThrottlerWin.h:
63         * WebCachedFramePlatformData.h:
64         * WebCoreSupport/AcceleratedCompositingContext.h:
65         * WebCoreSupport/WebChromeClient.h:
66         * WebCoreSupport/WebContextMenuClient.h:
67         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
68         * WebCoreSupport/WebDragClient.h:
69         * WebCoreSupport/WebEditorClient.h:
70         * WebCoreSupport/WebFrameLoaderClient.cpp:
71         * WebCoreSupport/WebGeolocationClient.h:
72         * WebCoreSupport/WebInspectorClient.h:
73         * WebDatabaseManager.cpp:
74         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
75         * WebNodeHighlight.h:
76         * WebNotificationCenter.cpp:
77         * WebNotificationCenter.h:
78
79 2019-08-15  Brent Fulgham  <bfulgham@apple.com>
80
81         [FTW] Enable CoreFoundation use if building for Apple target
82         https://bugs.webkit.org/show_bug.cgi?id=200799
83
84         Reviewed by Alex Christensen.
85
86         * FullscreenVideoController.cpp:
87         (FullscreenVideoController::FullscreenVideoController):
88         (FullscreenVideoController::enterFullscreen):
89         (FullscreenVideoController::exitFullscreen):
90         (FullscreenVideoController::createHUDWindow):
91         * FullscreenVideoController.h:
92         * WebView.cpp:
93         (WebView::exitFullscreenIfNeeded):
94
95 2019-08-15  Youenn Fablet  <youenn@apple.com>
96
97         Always create a Document with a valid SessionID
98         https://bugs.webkit.org/show_bug.cgi?id=200727
99
100         Reviewed by Alex Christensen.
101
102         Implement WebKit1 sessionID getter like done for WebKit2.
103         Either the loader client has a page in which case the page session ID is used
104         or the client has no page, in which case the default session ID is used.
105         This is the same behavior as CachedResourceLoader.
106
107         * WebCoreSupport/WebFrameLoaderClient.cpp:
108         (WebFrameLoaderClient::sessionID const):
109
110 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
111
112         Unreviewed, rolling out r248526.
113
114         Caused two IndexedDB perf tests to fail
115
116         Reverted changeset:
117
118         "Remove IDB-specific quota"
119         https://bugs.webkit.org/show_bug.cgi?id=196545
120         https://trac.webkit.org/changeset/248526
121
122 2019-08-14  Youenn Fablet  <youenn@apple.com>
123
124         ThreadableBlobRegistry::blobSize should take a SessionID as parameter
125         https://bugs.webkit.org/show_bug.cgi?id=200671
126
127         Reviewed by Alex Christensen.
128
129         * WebCoreSupport/WebPlatformStrategies.cpp:
130
131 2019-08-13  Youenn Fablet  <youenn@apple.com>
132
133         Blob registries should be keyed by session IDs
134         https://bugs.webkit.org/show_bug.cgi?id=200567
135         <rdar://problem/54120212>
136
137         Reviewed by Alex Christensen.
138
139         * WebCoreSupport/WebPlatformStrategies.cpp:
140         (WebPlatformStrategies::createBlobRegistry):
141
142 2019-08-12  Youenn Fablet  <youenn@apple.com>
143
144         Remove IDB-specific quota
145         https://bugs.webkit.org/show_bug.cgi?id=196545
146
147         Reviewed by Alex Christensen.
148
149         * Interfaces/IWebDatabaseManager.idl:
150         * WebDatabaseManager.cpp:
151         (WebDatabaseManager::setIDBPerOriginQuota): Deleted.
152         * WebDatabaseManager.h:
153
154 2019-08-09  Per Arne Vollan  <pvollan@apple.com>
155
156         [Win] Remove compiler workaround for VS2013
157         https://bugs.webkit.org/show_bug.cgi?id=200582
158
159         Reviewed by Don Olmstead.
160
161         A VS2013 compiler workaround can be removed now.
162
163         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp:
164         (DllMain):
165
166 2019-08-08  Per Arne Vollan  <pvollan@apple.com>
167
168         [Win] Fix internal build
169         https://bugs.webkit.org/show_bug.cgi?id=200519
170
171         Reviewed by Alex Christensen.
172
173         Switch to the String::wideCharacers method, since its return type is compatible with the Win32 api.
174
175         * WebDownloadCFNet.cpp:
176         (WebDownload::didFinish):
177
178 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
179
180         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
181         https://bugs.webkit.org/show_bug.cgi?id=200539
182         <rdar://problem/54082550>
183
184         Reviewed by Dean Jackson.
185
186         * AccessibleBase.cpp:
187         (AccessibleBase::get_locale):
188         * CFDictionaryPropertyBag.cpp:
189         (ConvertCFTypeToVariant):
190         (CFDictionaryPropertyBag::Read):
191         (CFDictionaryPropertyBag::Write):
192         * CFDictionaryPropertyBag.h:
193         * COMPropertyBag.h:
194         (HashType>::Read):
195         (HashType>::GetPropertyInfo):
196         * MarshallingHelpers.cpp:
197         * MarshallingHelpers.h:
198         * WebApplicationCache.cpp:
199         * WebArchive.cpp:
200         * WebArchive.h:
201         * WebCache.cpp:
202         * WebCoreSupport/WebFrameLoaderClient.cpp:
203         * WebDatabaseManager.cpp:
204         * WebHistory.cpp:
205         * WebHistoryItem.cpp:
206         * WebKitCOMAPI.cpp:
207         * WebKitCOMAPI.h:
208         * WebKitDLL.cpp:
209         * WebLocalizableStrings.cpp:
210         * WebLocalizableStrings.h:
211         * WebMutableURLRequest.cpp:
212         * WebPreferences.cpp:
213         * WebPreferences.h:
214         * WebView.cpp:
215         * WebView.h:
216
217 2019-08-08  Rob Buis  <rbuis@igalia.com>
218
219         Add runtime flag for lazy image loading
220         https://bugs.webkit.org/show_bug.cgi?id=199794
221
222         Reviewed by Darin Adler.
223
224         Set lazyImageLoading runtime flag if preference is set.
225
226         * Interfaces/IWebPreferencesPrivate.idl:
227         * WebPreferenceKeysPrivate.h:
228         * WebPreferences.cpp:
229         (WebPreferences::initializeDefaultSettings):
230         (WebPreferences::lazyImageLoadingEnabled):
231         (WebPreferences::setLazyImageLoadingEnabled):
232         * WebPreferences.h:
233         * WebView.cpp:
234         (WebView::notifyPreferencesChanged):
235
236 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
237
238         [Win][WK1] Can't change Web Inspector frontend height in high DPI
239         https://bugs.webkit.org/show_bug.cgi?id=200153
240
241         Reviewed by Don Olmstead.
242
243         * WebCoreSupport/WebInspectorClient.cpp:
244         (WebInspectorFrontendClient::setAttachedWindowHeight):
245         Applied deviceScaleFactor to the argument height.
246
247 2019-07-26  Konstantin Tokarev  <annulen@yandex.ru>
248
249         [Win] Remove unused methods from WebPluginInfoProvider
250         https://bugs.webkit.org/show_bug.cgi?id=200178
251
252         Reviewed by Brent Fulgham.
253
254         These methods are guarded with PLATFORM(MAC) and have no definitions.
255         Also remove unused friend declaration.
256
257         * WebCoreSupport/WebPluginInfoProvider.h:
258
259 2019-07-25  Fujii Hironori  <Hironori.Fujii@sony.com>
260
261         [Win][WK1] The inspected webview window is misplaced after changing Web Inspector frontend window height
262         https://bugs.webkit.org/show_bug.cgi?id=200152
263
264         Reviewed by Brent Fulgham.
265
266         In WebInspectorFrontendClient::setAttachedWindowHeight, the size
267         of m_inspectedWebViewHwnd was changed to the whole host window
268         size. But, it's too tall because MiniBrowser's host window has a
269         toolbar. The toolbar height should be taken into account.
270
271         Change to the height of m_inspectedWebViewHwnd to the sum of
272         inspected WebView and inspector frontend WebView heights.
273
274         * WebCoreSupport/WebInspectorClient.cpp:
275         (WebInspectorFrontendClient::setAttachedWindowHeight):
276
277 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
278
279         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
280         https://bugs.webkit.org/show_bug.cgi?id=200021
281         <rdar://problem/53301325>
282
283         Reviewed by Ryosuke Niwa.
284
285         Implement a new editing client hook.
286
287         * WebCoreSupport/WebEditorClient.h:
288
289 2019-07-13  Zalan Bujtas  <zalan@apple.com>
290
291         Cannot bring up custom media controls at all on v.youku.com
292         https://bugs.webkit.org/show_bug.cgi?id=199699
293         <rdar://problem/51835327>
294
295         Reviewed by Simon Fraser.
296
297         * WebActionPropertyBag.cpp:
298         (WebActionPropertyBag::Read):
299         * WebView.cpp:
300         (WebView::handleContextMenuEvent):
301         (WebView::elementAtPoint):
302
303 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
304
305         [WinCairo] ASSERTION FAILED: info.bmBitsPixel == 32 in createCairoContextWithHDC
306         https://bugs.webkit.org/show_bug.cgi?id=198323
307
308         Reviewed by Per Arne Vollan.
309
310         WebView::paint binds m_backingStoreBitmap to a DC by using
311         SelectObject. WebView::paint can be called recursively, but
312         m_backingStoreBitmap can't be bound to multiple DCs at the same
313         time. Then, SelectObject was failing in such case.
314
315         Call WebCore::Page::updateRendering before binding
316         m_backingStoreBitmap instead of after it.
317
318         Reverted r202744 change which won't be needed since this change.
319
320         * WebView.cpp:
321         (WebView::scrollBackingStore): Removed r202744's change.
322         (WebView::updateBackingStore): Removed m_page->updateRendering().
323         (WebView::paint): Do m_page->updateRendering() before binding m_backingStoreBitmap.
324         * WebView.h: Removed unused WebView::isPainting.
325
326 2019-07-02  Devin Rousso  <drousso@apple.com>
327
328         Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
329         https://bugs.webkit.org/show_bug.cgi?id=198956
330
331         Reviewed by Matt Baker.
332
333         * WebCoreSupport/WebInspectorClient.h:
334         * WebCoreSupport/WebInspectorClient.cpp:
335         (WebInspectorFrontendClient::resetWindowState): Added.
336
337 2019-06-30  Fujii Hironori  <Hironori.Fujii@sony.com>
338
339         [Win] Multiline mode of tooltip control does word-wrapping very slowly
340         https://bugs.webkit.org/show_bug.cgi?id=198989
341
342         Reviewed by Ross Kirsling.
343
344         * WebView.cpp:
345         (truncatedString): Added.
346         (WebView::setToolTip): Use truncatedString.
347
348 2019-06-16  Darin Adler  <darin@apple.com>
349
350         Rename AtomicString to AtomString
351         https://bugs.webkit.org/show_bug.cgi?id=195276
352
353         Reviewed by Michael Catanzaro.
354
355         * many files: Let do-webcore-rename do the renaming.
356
357 2019-05-31  Don Olmstead  <don.olmstead@sony.com>
358
359         [CMake] Add WebKit::WTF target
360         https://bugs.webkit.org/show_bug.cgi?id=198400
361
362         Reviewed by Konstantin Tokarev.
363
364         Use the WebKit::WTF target.
365
366         * WebKitQuartzCoreAdditions/CMakeLists.txt:
367
368 2019-05-30  Simon Fraser  <simon.fraser@apple.com>
369
370         Use an OptionSet<> for GraphicsLayerPaintingPhase
371         https://bugs.webkit.org/show_bug.cgi?id=198404
372
373         Reviewed by Tim Horton.
374
375         Replace GraphicsLayerPaintingPhase with OptionSet<GraphicsLayerPaintingPhase>.
376
377         No behavior change.
378
379         * WebCoreSupport/AcceleratedCompositingContext.cpp:
380         (AcceleratedCompositingContext::paintContents):
381         * WebCoreSupport/AcceleratedCompositingContext.h:
382         * WebView.cpp:
383         (WebView::paintContents):
384         * WebView.h:
385
386 2019-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
387
388         [iOS] Dropped text, attachments, and images should animate into place
389         https://bugs.webkit.org/show_bug.cgi?id=198243
390         <rdar://problem/35205373>
391
392         Reviewed by Tim Horton.
393
394         * WebCoreSupport/WebChromeClient.cpp:
395         (WebChromeClient::didFinishLoadingImageForElement):
396         * WebCoreSupport/WebChromeClient.h:
397
398 2019-05-03  Daniel Bates  <dabates@apple.com>
399
400         Pass KeyboardEvent by reference in more places
401         https://bugs.webkit.org/show_bug.cgi?id=197480
402
403         Reviewed by Wenson Hsieh.
404
405         * WebCoreSupport/WebEditorClient.cpp:
406         (WebEditorClient::handleKeyboardEvent):
407         (WebEditorClient::handleInputMethodKeydown):
408         * WebCoreSupport/WebEditorClient.h:
409         * WebView.cpp:
410         (WebView::handleEditingKeyboardEvent):
411         * WebView.h:
412
413 2019-05-02  Frederic Wang  <fwang@igalia.com>
414
415         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
416         https://bugs.webkit.org/show_bug.cgi?id=196142
417
418         This patch introduces some experimental runtime flag to let users
419         disable MathML features that are removed from MathML Core [1]. For now,
420         these features are only disabled on GTK and WPE ports.
421
422         [1] https://mathml-refresh.github.io/mathml-core/
423
424         Reviewed by Rob Buis.
425
426         * Interfaces/IWebPreferencesPrivate.idl:
427         * WebPreferenceKeysPrivate.h:
428         * WebPreferences.cpp:
429         (WebPreferences::initializeDefaultSettings):
430         (WebPreferences::coreMathMLEnabled):
431         (WebPreferences::setCoreMathMLEnabled):
432         * WebPreferences.h:
433         * WebView.cpp:
434         (WebView::notifyPreferencesChanged):
435
436 2019-04-24  Zalan Bujtas  <zalan@apple.com>
437
438         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
439         https://bugs.webkit.org/show_bug.cgi?id=196948
440         <rdar://problem/49927131>
441
442         Reviewed by Tim Horton.
443
444         * WebCoreSupport/WebChromeClient.cpp:
445         (WebChromeClient::intrinsicContentsSizeChanged const):
446         * WebCoreSupport/WebChromeClient.h:
447
448 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
449
450         Make it possible to control the renderTreeAsText output by setting options on testRunner
451         https://bugs.webkit.org/show_bug.cgi?id=197133
452
453         Reviewed by Sam Weinig.
454
455         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
456         that make sense in testing (those that don't dump unstable data like addresses), and plumb
457         these flags through the various framework layers.
458
459         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
460
461         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
462         and hand-code DumpRenderTree bindings.
463
464         Some cleanup of the TestRunners, using member initializers.
465
466         * Interfaces/IWebFramePrivate.idl:
467         * WebFrame.cpp:
468         (toRenderAsTextFlags):
469         (WebFrame::renderTreeAsExternalRepresentation):
470         (WebFrame::renderTreeAsExternalRepresentationForPrinting):
471         * WebFrame.h:
472
473 2019-04-23  Chris Dumez  <cdumez@apple.com>
474
475         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
476         https://bugs.webkit.org/show_bug.cgi?id=197097
477         <rdar://problem/50048318>
478
479         Reviewed by Alex Christensen.
480
481         * WebCoreSupport/WebFrameLoaderClient.cpp:
482         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
483         * WebCoreSupport/WebFrameLoaderClient.h:
484
485 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
486
487         [CMake][Win] Use target oriented design for WebKitLegacy
488         https://bugs.webkit.org/show_bug.cgi?id=197112
489
490         Reviewed by Konstantin Tokarev.
491
492         Fix an include directory.
493
494         * WebKitQuartzCoreAdditions/CMakeLists.txt:
495
496 2019-04-18  Jer Noble  <jer.noble@apple.com>
497
498         Refactoring: Pull all fullscreen code out of Document and into its own helper class
499         https://bugs.webkit.org/show_bug.cgi?id=197017
500
501         Reviewed by Eric Carlson.
502
503         * WebCoreSupport/WebChromeClient.cpp:
504         (WebChromeClient::createWindow):
505         * WebView.cpp:
506         (WebView::fullScreenClientWillEnterFullScreen):
507         (WebView::fullScreenClientDidEnterFullScreen):
508         (WebView::fullScreenClientWillExitFullScreen):
509         (WebView::fullScreenClientDidExitFullScreen):
510
511 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
512
513         requestAnimationFrame should execute before the next frame
514         https://bugs.webkit.org/show_bug.cgi?id=177484
515
516         Reviewed by Simon Fraser.
517
518         * WebView.cpp:
519         (WebView::updateBackingStore):
520         (WebView::flushPendingGraphicsLayerChangesSoon):
521         (WebView::flushPendingGraphicsLayerChanges):
522         Call Page::updateRendering() which implements "Update the rendering"
523         step of the HTML Event Loop specification.
524
525 2019-04-10  Devin Rousso  <drousso@apple.com>
526
527         Web Inspector: save sheet should be anchored underneath the tab bar when detached
528         https://bugs.webkit.org/show_bug.cgi?id=196722
529         <rdar://problem/49613280>
530
531         Reviewed by Timothy Hatcher.
532
533         * WebCoreSupport/WebInspectorClient.h:
534         * WebCoreSupport/WebInspectorClient.cpp:
535         (WebInspectorFrontendClient::setSheetRect): Added.
536
537 2019-04-10  Alex Christensen  <achristensen@webkit.org>
538
539         Add SPI WKNavigationResponse._downloadAttribute
540         https://bugs.webkit.org/show_bug.cgi?id=196755
541         <rdar://49587365>
542
543         Reviewed by Brady Eidson.
544
545         * WebCoreSupport/WebFrameLoaderClient.cpp:
546         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
547         * WebCoreSupport/WebFrameLoaderClient.h:
548
549 2019-04-05  Commit Queue  <commit-queue@webkit.org>
550
551         Unreviewed, rolling out r243833.
552         https://bugs.webkit.org/show_bug.cgi?id=196645
553
554         This change breaks build of WPE and GTK ports (Requested by
555         annulen on #webkit).
556
557         Reverted changeset:
558
559         "[CMake][WTF] Mirror XCode header directories"
560         https://bugs.webkit.org/show_bug.cgi?id=191662
561         https://trac.webkit.org/changeset/243833
562
563 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
564
565         [CMake][WTF] Mirror XCode header directories
566         https://bugs.webkit.org/show_bug.cgi?id=191662
567
568         Reviewed by Konstantin Tokarev.
569
570         * WebKitQuartzCoreAdditions/CMakeLists.txt:
571
572 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
573
574         Implement ResizeObserver.
575         https://bugs.webkit.org/show_bug.cgi?id=157743
576
577         Reviewed by Simon Fraser.
578
579         * Interfaces/IWebPreferencesPrivate.idl:
580         * WebPreferenceKeysPrivate.h:
581         * WebPreferences.cpp:
582         (WebPreferences::initializeDefaultSettings):
583         (WebPreferences::resizeObserverEnabled):
584         (WebPreferences::setResizeObserverEnabled):
585         * WebPreferences.h:
586         * WebView.cpp:
587         (WebView::notifyPreferencesChanged):
588
589 2019-03-17  Fujii Hironori  <Hironori.Fujii@sony.com>
590
591         [Win][WK1] Null dereference in WebFrameNetworkingContext::storageSession
592         https://bugs.webkit.org/show_bug.cgi?id=195741
593
594         Reviewed by Ross Kirsling.
595
596         * WebCoreSupport/WebFrameNetworkingContext.cpp:
597         (WebFrameNetworkingContext::storageSession const): Added a null check of frame()->page() as well as Mac port does (Bug 183455).
598
599 2019-03-13  Ryan Haddad  <ryanhaddad@apple.com>
600
601         Unreviewed attempt to fix the Windows build after r242920.
602
603         * WebCoreSupport/WebFrameLoaderClient.h:
604
605 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
606
607         [Win] Fix a slew of simple clang-cl warnings.
608         https://bugs.webkit.org/show_bug.cgi?id=195652
609
610         Reviewed by Don Olmstead.
611
612         * Interfaces/AccessibleComparable.idl: -Wmissing-braces
613         * Plugins/PluginDatabaseWin.cpp: -Wunused-function
614         (WebCore::addJavaPluginDirectory): Deleted.
615         * WebCoreSupport/AcceleratedCompositingContext.cpp:
616         (AcceleratedCompositingContext::AcceleratedCompositingContext): -Wreorder
617         * WebCoreSupport/WebEditorClient.cpp:
618         (WebEditorUndoCommand::WebEditorUndoCommand): -Wreorder
619         (undoNameForEditAction): -Wswitch
620         * WebCoreSupport/WebFrameLoaderClient.cpp:
621         (WebFrameLoaderClient::WebFrameLoaderClient): -Wswitch
622         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): -Wunused-variable
623         * WebCoreSupport/WebInspectorClient.cpp:
624         (WebInspectorFrontendClient::WebInspectorFrontendClient): -Wreorder
625         * WebCoreSupport/WebInspectorClient.h: -Winconsistent-missing-override
626         * WebError.cpp:
627         (WebError::WebError): -Wreorder
628         * WebFrame.cpp:
629         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): -Wlogical-op-parentheses
630         * WebHistory.cpp: -Wunused-function (x5)
631         (areEqualOrClose): Deleted.
632         (addDayToSystemTime): Deleted.
633         (getDayBoundaries): Deleted.
634         (beginningOfDay): Deleted.
635         (dateKey): Deleted.
636         * WebNotificationCenter.cpp:
637         (WebNotificationCenter::removeObserver): -Wunused-variable
638         * WebView.cpp: -Wunused-function, -Wreorder
639         (WebView::addVisitedLinks): -Wunused-variable
640
641 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
642
643         Unreviewed, rolling out r242688, r242643, r242624.
644
645         Caused multiple layout test failures and crashes on iOS and macOS.
646
647         Reverted changeset:
648
649         "requestAnimationFrame should execute before the next frame"
650         https://bugs.webkit.org/show_bug.cgi?id=177484
651         https://trac.webkit.org/changeset/242624/webkit
652
653         * WebView.cpp:
654         (WebView::updateBackingStore):
655         (WebView::flushPendingGraphicsLayerChangesSoon):
656         (WebView::flushPendingGraphicsLayerChanges):
657
658 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
659
660         requestAnimationFrame should execute before the next frame
661         https://bugs.webkit.org/show_bug.cgi?id=177484
662
663         Reviewed by Simon Fraser.
664
665         * WebView.cpp:
666         (WebView::updateBackingStore):
667         (WebView::flushPendingGraphicsLayerChangesSoon):
668         (WebView::flushPendingGraphicsLayerChanges):
669         Call Page::renderingUpdate() which implements  "Update the rendering"
670         step of the HTML Event Loop specification.
671
672 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
673
674         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
675         https://bugs.webkit.org/show_bug.cgi?id=195346
676
677         Reviewed by Fujii Hironori.
678
679         * COMPropertyBag.h:
680         (HashType>::GetPropertyInfo):
681         (HashType>::LoadObject):
682         * DOMCoreClasses.cpp:
683         (DOMNode::addEventListener):
684         (DOMNode::removeEventListener):
685         (DOMWindow::addEventListener):
686         (DOMWindow::removeEventListener):
687         (DOMElement::font):
688         * DOMHTMLClasses.cpp:
689         (DOMHTMLInputElement::setValueForUser):
690         (DOMHTMLInputElement::replaceCharactersInRange):
691         * Plugins/PluginDatabaseWin.cpp:
692         (WebCore::addPluginPathsFromRegistry):
693         (WebCore::PluginDatabase::getPluginPathsInDirectories const):
694         (WebCore::addMozillaPluginDirectories):
695         (WebCore::addWindowsMediaPlayerPluginDirectory):
696         (WebCore::addAdobeAcrobatPluginDirectory):
697         (WebCore::addJavaPluginDirectory):
698         (WebCore::safariPluginsDirectory):
699         (WebCore::addMacromediaPluginDirectories):
700         * Plugins/PluginPackageWin.cpp:
701         (WebCore::getVersionInfo):
702         (WebCore::PluginPackage::fetchInfo):
703         (WebCore::PluginPackage::load):
704         * Plugins/PluginViewWin.cpp:
705         (WebCore::PluginView::handlePostReadFile):
706         * WebCoreSupport/WebChromeClient.cpp:
707         (WebChromeClient::runOpenPanel):
708         * WebCoreSupport/WebEditorClient.cpp:
709         (WebEditorClient::checkSpellingOfString):
710         (WebEditorClient::checkGrammarOfString):
711         * WebCoreSupport/WebInspectorClient.cpp:
712         (WebInspectorFrontendClient::updateWindowTitle):
713         * WebLocalizableStrings.cpp:
714         (LocalizedString::operator LPCTSTR const):
715         * WebView.cpp:
716         (createContextMenuFromItems):
717         (WebView::setToolTip):
718         Use wchar helpers as needed.
719
720 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
721
722         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
723         https://bugs.webkit.org/show_bug.cgi?id=195053
724         <rdar://problem/48134710>
725
726         Reviewed by Ryosuke Niwa.
727
728         * WebCoreSupport/WebEditorClient.h:
729
730 2019-02-20  Darin Adler  <darin@apple.com>
731
732         Finish removing String::format
733         https://bugs.webkit.org/show_bug.cgi?id=194893
734
735         Reviewed by Daniel Bates.
736
737         * FullscreenVideoController.cpp:
738         (timeToString): Use makeString and pad.
739
740 2019-02-27  Simon Fraser  <simon.fraser@apple.com>
741
742         Roll out r242014; it caused crashes in compositing logging (webkit.org/b/195141)
743
744         * FullscreenVideoController.cpp:
745         (timeToString):
746
747 2019-02-26  Philippe Normand  <pnormand@igalia.com>
748
749         [WPE] Add API for webview background color configuration
750         https://bugs.webkit.org/show_bug.cgi?id=192305
751
752         Reviewed by Michael Catanzaro.
753
754         * WebCoreSupport/WebFrameLoaderClient.cpp:
755         (WebFrameLoaderClient::transitionToCommittedForNewPage): Create
756         FrameView with background color.
757
758 2019-02-20  Darin Adler  <darin@apple.com>
759
760         Finish removing String::format
761         https://bugs.webkit.org/show_bug.cgi?id=194893
762
763         Reviewed by Daniel Bates.
764
765         * FullscreenVideoController.cpp:
766         (timeToString): Use makeString and pad.
767
768 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
769
770         Input type "formatSetInlineTextDirection" is dispatched when changing paragraph-level text direction
771         https://bugs.webkit.org/show_bug.cgi?id=194703
772         <rdar://problem/48111775>
773
774         Reviewed by Ryosuke Niwa.
775
776         * WebCoreSupport/WebEditorClient.cpp:
777         (undoNameForEditAction):
778
779 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
780
781         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
782         https://bugs.webkit.org/show_bug.cgi?id=194670
783         <rdar://problem/39066529>
784
785         Reviewed by Tim Horton.
786
787         * WebCoreSupport/WebEditorClient.cpp:
788         (WebEditorClient::replacementURLForResource): Deleted.
789         * WebCoreSupport/WebEditorClient.h:
790
791 2019-02-10  Darin Adler  <darin@apple.com>
792
793         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
794         https://bugs.webkit.org/show_bug.cgi?id=194487
795
796         Reviewed by Daniel Bates.
797
798         * WebView.cpp:
799         (webKitVersionString): Use makeString instead of String::format.
800
801 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
802
803         Allow pages to trigger programmatic paste from script on iOS
804         https://bugs.webkit.org/show_bug.cgi?id=194271
805         <rdar://problem/47808810>
806
807         Reviewed by Ryosuke Niwa.
808
809         * WebCoreSupport/WebEditorClient.h:
810
811 2019-02-06  Daniel Bates  <dabates@apple.com>
812
813         Standardize on ControlKey instead of CtrlKey
814         https://bugs.webkit.org/show_bug.cgi?id=194317
815
816         Reviewed by Tim Horton.
817
818         * AccessibleBase.cpp:
819         (AccessibleBase::get_accKeyboardShortcut):
820         * WebView.cpp:
821         (WebView::keyDown):
822
823 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
824
825         PageOverlayController's layers should be created lazily
826         https://bugs.webkit.org/show_bug.cgi?id=194199
827         rdar://problem/46571593
828
829         Reviewed by Tim Horton.
830
831         Expose PageOverlayController::hasDocumentOverlays() and hasViewOverlays()
832         and use them to only parent the overlay-hosting layers when necessary.
833
834         For document overlays, RenderLayerCompositor::appendDocumentOverlayLayers() can
835         simply do nothing if there are none. Updates are triggered via Page::installedPageOverlaysChanged(),
836         which calls FrameView::setNeedsCompositingConfigurationUpdate() to trigger the root layer
837         compositing updates that parents the layerWithDocumentOverlays().
838
839         View overlays are added to the layer tree via the DrawingArea. When we go between having
840         none and some view overlays, Page::installedPageOverlaysChanged() calls attachViewOverlayGraphicsLayer()
841         on the ChromeClient, and the DrawingArea responds by calling updateRootLayers() and scheduling a
842         compositing flush (this has to be done manually because view overlay layers are outside the
843         subtree managed by RenderLayerCompositor).
844         
845         Now that GraphicsLayers are ref-counted, we can let the DrawingArea simply retain its m_viewOverlayRootLayer;
846         there is no need for RenderLayerCompositor::attachRootLayer()/detachRootLayer() to do anything with view
847         overlay layers. This implies that a page can navigate (new FrameView) and view overlays will persist, without
848         having to be manually removed and re-added. We can also remove the Frame argument to attachViewOverlayGraphicsLayer().
849
850         * WebCoreSupport/WebChromeClient.cpp:
851         (WebChromeClient::attachViewOverlayGraphicsLayer):
852         * WebCoreSupport/WebChromeClient.h:
853
854 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
855
856         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
857         https://bugs.webkit.org/show_bug.cgi?id=194189
858
859         Reviewed by Geoffrey Garen.
860
861         Pass the policy check identifier around functions and store it in WebFramePolicyListener
862         so that we can send it back to WebCore with the navigation policy decision.
863
864         * WebCoreSupport/WebFrameLoaderClient.cpp:
865         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
866         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
867         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
868         (WebFrameLoaderClient::dispatchWillSubmitForm):
869         (WebFrameLoaderClient::setUpPolicyListener):
870         * WebCoreSupport/WebFrameLoaderClient.h:
871
872 2019-01-31  Alex Christensen  <achristensen@webkit.org>
873
874         Revert r238819 which is unneeded and caused a performance regression.
875         https://bugs.webkit.org/show_bug.cgi?id=192272
876         <rdar://problem/46664625>
877
878         * WebCoreSupport/WebFrameLoaderClient.cpp:
879         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
880         * WebCoreSupport/WebFrameLoaderClient.h:
881
882 2019-01-31  Takashi Komori  <Takashi.Komori@sony.com>
883
884         [Curl] Fix DRT crash related to private browsing.
885         https://bugs.webkit.org/show_bug.cgi?id=193816
886
887         Reviewed by Alex Christensen.
888
889         * WebCoreSupport/WebFrameNetworkingContext.cpp:
890         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
891
892 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
893
894         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
895         https://bugs.webkit.org/show_bug.cgi?id=193941
896
897         Reviewed by Alex Christensen.
898
899         * Plugins/PluginMessageThrottlerWin.cpp:
900         * Plugins/PluginView.cpp:
901         * Plugins/PluginViewWin.cpp:
902
903 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
904
905         Move FileSystem to WTF
906         https://bugs.webkit.org/show_bug.cgi?id=193602
907
908         Reviewed by Yusuke Suzuki.
909
910         * Plugins/PluginDatabase.cpp:
911         * Plugins/PluginPackage.h:
912         * Plugins/PluginStream.h:
913         * WebApplicationCache.cpp:
914         * WebDatabaseManager.cpp:
915         * WebDownloadCurl.cpp:
916         * WebPreferences.cpp:
917         * WebView.cpp:
918
919 2019-01-22  Alex Christensen  <achristensen@webkit.org>
920
921         Move NetworkStorageSession ownership to NetworkProcess
922         https://bugs.webkit.org/show_bug.cgi?id=193580
923
924         Reviewed by Geoff Garen.
925
926         * WebCoreSupport/WebFrameNetworkingContext.cpp:
927         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
928         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
929         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
930         (WebFrameNetworkingContext::storageSession const):
931         * WebDownloadCFNet.cpp:
932         (WebDownload::didReceiveAuthenticationChallenge):
933         * WebPreferences.cpp:
934         (WebPreferences::clearNetworkLoaderSession):
935         (WebPreferences::switchNetworkLoaderToNewTestingSession):
936
937 2019-01-15  Darin Adler  <darin@apple.com>
938
939         Use references rather than pointers for register/unregister functions, and more
940         https://bugs.webkit.org/show_bug.cgi?id=175028
941
942         Reviewed by Daniel Bates.
943
944         * Plugins/PluginView.cpp:
945         (WebCore::PluginView::startOrAddToUnstartedList): Pass a reference.
946         (WebCore::PluginView::~PluginView): Ditto.
947         * WebView.cpp:
948         (WebView::fullScreenClientWillEnterFullScreen): Ditto.
949         (WebView::fullScreenClientDidEnterFullScreen): Ditto.
950         (WebView::fullScreenClientDidExitFullScreen): Ditto.
951
952 2019-01-17  Per Arne Vollan  <pvollan@apple.com>
953
954         [Win][HighDPI] Repaint glitches when scrolling.
955         https://bugs.webkit.org/show_bug.cgi?id=173152
956         <rdar://problem/45269953>
957
958         Reviewed by Brent Fulgham.
959
960         Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
961         delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
962         Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
963
964         * WebView.cpp:
965         (WebView::scrollBackingStore):
966
967 2019-01-17  Alex Christensen  <achristensen@webkit.org>
968
969         Stop using NetworkStorageSession::storageSession in WebCore
970         https://bugs.webkit.org/show_bug.cgi?id=193529
971
972         Reviewed by Tim Horton.
973
974         * WebView.cpp:
975         (WebView::initWithFrame):
976
977 2019-01-15  Alex Christensen  <achristensen@webkit.org>
978
979         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
980         https://bugs.webkit.org/show_bug.cgi?id=193368
981
982         Reviewed by Geoff Garen.
983
984         * WebDownloadCFNet.cpp:
985         (WebDownload::didReceiveAuthenticationChallenge):
986
987 2019-01-15  Alex Christensen  <achristensen@webkit.org>
988
989         Fix Windows build after r240014
990         https://bugs.webkit.org/show_bug.cgi?id=161106
991
992         * WebView.cpp:
993
994 2019-01-15  Alex Christensen  <achristensen@webkit.org>
995
996         Stop using CookiesStrategy
997         https://bugs.webkit.org/show_bug.cgi?id=161106
998
999         Reviewed by Don Olmstead and Antti Koivisto.
1000
1001         * Plugins/PluginView.cpp:
1002         (WebCore::PluginView::getValueForURL):
1003         (WebCore::PluginView::setValueForURL):
1004         * WebCoreSupport/WebPlatformStrategies.cpp:
1005         (WebPlatformStrategies::createBlobRegistry):
1006         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1007         (WebPlatformStrategies::cookiesForDOM): Deleted.
1008         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1009         (WebPlatformStrategies::cookiesEnabled): Deleted.
1010         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1011         (WebPlatformStrategies::getRawCookies): Deleted.
1012         (WebPlatformStrategies::deleteCookie): Deleted.
1013         * WebCoreSupport/WebPlatformStrategies.h:
1014         * WebView.cpp:
1015         (WebView::initWithFrame):
1016
1017 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1018
1019         Stop using NetworkStorageSession in WebProcess
1020         https://bugs.webkit.org/show_bug.cgi?id=193236
1021
1022         Reviewed by Don Olmstead.
1023
1024         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1025         (WebFrameNetworkingContext::storageSession const):
1026         * WebCoreSupport/WebFrameNetworkingContext.h:
1027         * WebCoreSupport/WebPlatformStrategies.cpp:
1028         (WebPlatformStrategies::cookiesForDOM):
1029         (WebPlatformStrategies::setCookiesFromDOM):
1030         (WebPlatformStrategies::cookiesEnabled):
1031         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1032         (WebPlatformStrategies::getRawCookies):
1033         (WebPlatformStrategies::deleteCookie):
1034         * WebCoreSupport/WebPlatformStrategies.h:
1035
1036 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1037
1038         Unreviewed, rolling out r239727.
1039
1040         Broke API tests
1041
1042         Reverted changeset:
1043
1044         "Stop using NetworkStorageSession in WebProcess"
1045         https://bugs.webkit.org/show_bug.cgi?id=193236
1046         https://trac.webkit.org/changeset/239727
1047
1048 2018-12-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1049
1050         Remove "using namespace std;"
1051         https://bugs.webkit.org/show_bug.cgi?id=192973
1052
1053         Reviewed by Alex Christensen.
1054
1055         * FullscreenVideoController.cpp:
1056         * WebFrame.cpp:
1057         (WebFrame::drawFooter):
1058         * WebHistory.cpp:
1059         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
1060         * WebKitQuartzCoreAdditions/CAView.cpp:
1061         * WebView.cpp:
1062         (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
1063         (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
1064         (WebView::setCacheModel):
1065         (WebView::maxCacheModelInAnyInstance):
1066
1067 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1068
1069         Use Ref<> as much as possible
1070         https://bugs.webkit.org/show_bug.cgi?id=192808
1071
1072         Reviewed by Alex Christensen.
1073
1074         * Plugins/PluginDatabase.cpp:
1075         (WebCore::PluginDatabase::refresh):
1076         * Plugins/PluginView.cpp:
1077         (WebCore::PluginView::mediaCanStart):
1078         (WebCore::PluginView::performRequest):
1079         (WebCore::PluginView::bindingInstance):
1080         * Plugins/PluginView.h:
1081         * WebCoreSupport/WebFrameLoaderClient.cpp:
1082         (WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
1083         (WebFrameLoaderClient::createPlugin):
1084         (WebFrameLoaderClient::createJavaAppletWidget):
1085         * WebCoreSupport/WebFrameLoaderClient.h:
1086         * WebFrame.cpp:
1087         (WebFrame::loadData):
1088         (WebFrame::loadPlainTextString):
1089         (WebFrame::loadHTMLString):
1090         * WebFrame.h:
1091         * WebKitQuartzCoreAdditions/CAView.cpp:
1092         (WKQCA::CAView::create):
1093         * WebKitQuartzCoreAdditions/CAView.h:
1094         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
1095         (WKQCA::CVDisplayLink::create):
1096         * WebKitQuartzCoreAdditions/CVDisplayLink.h:
1097         * WebKitQuartzCoreAdditions/ImageConversion.cpp:
1098         (WKQCA::getImageCopy):
1099         * WebView.cpp:
1100         (WebView::addUserScriptToGroup):
1101         (WebView::addUserStyleSheetToGroup):
1102
1103 2018-12-20  Chris Dumez  <cdumez@apple.com>
1104
1105         Use Optional::valueOr() instead of Optional::value_or()
1106         https://bugs.webkit.org/show_bug.cgi?id=192933
1107
1108         Reviewed by Geoffrey Garen.
1109
1110         * WebSecurityOrigin.cpp:
1111         (WebSecurityOrigin::port):
1112
1113 2018-12-19  Chris Dumez  <cdumez@apple.com>
1114
1115         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1116         https://bugs.webkit.org/show_bug.cgi?id=192728
1117         <rdar://problem/46746779>
1118
1119         Reviewed by Geoff Garen.
1120
1121         * Plugins/*:
1122         * WebCoreSupport/*:
1123
1124 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1125
1126         [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag
1127         https://bugs.webkit.org/show_bug.cgi?id=192617
1128
1129         Reviewed by Alex Christensen.
1130
1131         * COMEnumVariant.h:
1132         (COMEnumVariant<ContainerType>::adopt): Removed 'typename' from non dependent names.
1133         (COMEnumVariant<ContainerType>::createInstance): Ditto.
1134         (COMEnumVariant<ContainerType>::Next): Prepend 'typename' for dependent names.
1135         * COMPropertyBag.h:
1136         (HashType>::createInstance): Removed 'typename' from non dependent names.
1137         (HashType>::adopt): Ditto.
1138         (HashType>::Read): Replaced dependent name 'HashMapType::const_iterator' with 'auto'.
1139         (HashType>::GetPropertyInfo): Ditto.
1140
1141 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1142
1143         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
1144         https://bugs.webkit.org/show_bug.cgi?id=192618
1145
1146         Reviewed by Alex Christensen.
1147
1148         Classes which implement COM interface usually doesn't need the
1149         virtual destructor because it has Release() virtual method to
1150         destruct itself.
1151
1152         Marked 'final' such classes to suppress clang-cl's compilation
1153         warnings.
1154
1155         * COMEnumVariant.h:
1156         * COMPropertyBag.h:
1157         * DefaultDownloadDelegate.h:
1158         * DefaultPolicyDelegate.h:
1159         * MemoryStream.h:
1160         * WebActionPropertyBag.h:
1161         * WebApplicationCache.h:
1162         * WebArchive.h:
1163         * WebBackForwardList.h:
1164         * WebCache.h:
1165         * WebCoreStatistics.h:
1166         * WebCoreSupport/WebEditorClient.cpp:
1167         * WebCoreSupport/WebInspectorDelegate.h:
1168         * WebDataSource.h:
1169         * WebDatabaseManager.cpp:
1170         * WebDatabaseManager.h:
1171         * WebDownload.h:
1172         * WebDropSource.h:
1173         * WebElementPropertyBag.h:
1174         * WebError.h:
1175         * WebFrame.cpp:
1176         * WebFrame.h:
1177         * WebFramePolicyListener.h:
1178         * WebGeolocationPolicyListener.h:
1179         * WebGeolocationPosition.h:
1180         * WebHTMLRepresentation.h:
1181         * WebHistory.h:
1182         * WebHistoryItem.h:
1183         * WebInspector.h:
1184         * WebJavaScriptCollector.h:
1185         * WebKitClassFactory.h:
1186         * WebKitMessageLoop.h:
1187         * WebKitStatistics.h:
1188         * WebMutableURLRequest.h:
1189         * WebNavigationData.h:
1190         * WebNotification.h:
1191         * WebNotificationCenter.h:
1192         * WebPreferences.h:
1193         * WebResource.h:
1194         * WebScriptWorld.h:
1195         * WebSecurityOrigin.h:
1196         * WebSerializedJSValue.h:
1197         * WebTextRenderer.h:
1198         * WebURLAuthenticationChallenge.h:
1199         * WebURLAuthenticationChallengeSender.h:
1200         * WebURLCredential.h:
1201         * WebURLProtectionSpace.h:
1202         * WebURLResponse.h:
1203         * WebUserContentURLPattern.h:
1204         * WebView.cpp:
1205         * WebView.h:
1206         * WebWorkersPrivate.h:
1207
1208 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1209
1210         [Win][Clang] Fix warning -Wmissing-field-initializers
1211         https://bugs.webkit.org/show_bug.cgi?id=192584
1212
1213         Reviewed by Yusuke Suzuki.
1214
1215         Initialize a struct with '{ }' instead of '= {0}'.
1216
1217         * WebKitMessageLoop.cpp:
1218         (WebKitMessageLoop::run):
1219         * WebView.cpp:
1220         (WebView::onMenuCommand):
1221         (WebView::gesture):
1222         (WebView::setShouldInvertColors):
1223         (WebView::initializeToolTipWindow):
1224         (WebView::setToolTip):
1225         (WebView::fullScreenClientForceRepaint):
1226
1227 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1228
1229         Turn WritingDirection into an enum class
1230         https://bugs.webkit.org/show_bug.cgi?id=192401
1231         Work towards <rdar://problem/42075638>
1232
1233         Reviewed by Dan Bernstein.
1234
1235         Change WritingDirection from an enum to an enum class. No change in behavior.
1236
1237         * WebFrame.cpp:
1238         (WebFrame::setTextDirection):
1239
1240 2018-12-03  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1241
1242         Use WallTime for file time
1243         https://bugs.webkit.org/show_bug.cgi?id=192287
1244
1245         Reviewed by Darin Adler.
1246
1247         * Plugins/PluginDatabase.cpp:
1248         (WebCore::PluginDatabase::refresh):
1249
1250 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1251
1252         Fix Windows build.
1253
1254         * WebView.cpp:
1255
1256 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1257
1258         Fix Windows build.
1259
1260         * WebCoreSupport/WebFrameLoaderClient.h:
1261
1262 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1263
1264         Fix Windows build.
1265
1266         * WebCoreSupport/WebFrameLoaderClient.h:
1267
1268 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1269
1270         Move URL from WebCore to WTF
1271         https://bugs.webkit.org/show_bug.cgi?id=190234
1272
1273         Reviewed by Keith Miller.
1274
1275         * MarshallingHelpers.cpp:
1276         * MarshallingHelpers.h:
1277         * Plugins/PluginDatabase.cpp:
1278         * Plugins/PluginDatabase.h:
1279         * Plugins/PluginDatabaseWin.cpp:
1280         * Plugins/PluginStream.h:
1281         * Plugins/PluginView.h:
1282         * WebCoreSupport/WebContextMenuClient.h:
1283         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
1284         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
1285         * WebCoreSupport/WebFrameLoaderClient.h:
1286         * WebCoreSupport/WebPlatformStrategies.h:
1287         * WebCoreSupport/WebPluginInfoProvider.cpp:
1288         (WebPluginInfoProvider::webVisiblePluginInfo):
1289         * WebCoreSupport/WebPluginInfoProvider.h:
1290         * WebCoreSupport/WebVisitedLinkStore.h:
1291         * WebDataSource.cpp:
1292         * WebDownload.h:
1293         * WebElementPropertyBag.cpp:
1294         * WebFrame.h:
1295         * WebHistory.cpp:
1296         * WebHistory.h:
1297         * WebHistoryItem.cpp:
1298         * WebResource.cpp:
1299         (WebResource::WebResource):
1300         * WebResource.h:
1301         * WebSecurityOrigin.cpp:
1302         * WebURLResponse.cpp:
1303         (WebURLResponse::createInstance):
1304         * WebUserContentURLPattern.cpp:
1305         * WebView.h:
1306
1307 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1308
1309         Remove dead code from an earlier attempt at implementing safe browsing
1310         https://bugs.webkit.org/show_bug.cgi?id=192067
1311
1312         Reviewed by Chris Dumez.
1313
1314         * WebCoreSupport/WebFrameLoaderClient.cpp:
1315         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1316         * WebCoreSupport/WebFrameLoaderClient.h:
1317
1318 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
1319
1320         [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
1321         https://bugs.webkit.org/show_bug.cgi?id=191959
1322
1323         Reviewed by Alex Christensen.
1324
1325         * MarshallingHelpers.h: Removed extra "MarshallingHelpers::" of windowsEpochAbsoluteTime declaration.
1326
1327 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
1328
1329         [Win] Reduce the use of WKSI library calls: CoreAnimation
1330         https://bugs.webkit.org/show_bug.cgi?id=191777
1331         <rdar://problem/46140542>
1332
1333         Reviewed by Zalan Bujtas.
1334
1335         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
1336         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
1337         directives for WebKitSystemInterface.lib.
1338
1339         * FullscreenVideoController.cpp:
1340         * WebKitGraphics.cpp:
1341         * WebPreferences.cpp:
1342
1343 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1344
1345         Address post-review feedback after r238438
1346         https://bugs.webkit.org/show_bug.cgi?id=191913
1347
1348         Reviewed by Ryosuke Niwa.
1349
1350         * AccessibleTextImpl.cpp:
1351         (AccessibleText::replaceText):
1352
1353 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1354
1355         Web Inspector: "Reload Web Inspector" button no longer partially works
1356         https://bugs.webkit.org/show_bug.cgi?id=191773
1357         <rdar://problem/46139932>
1358
1359         Reviewed by Devin Rousso.
1360
1361         * WebCoreSupport/WebInspectorClient.cpp:
1362         (WebInspectorFrontendClient::reopen):
1363         * WebCoreSupport/WebInspectorClient.h:
1364
1365 2018-11-17  Devin Rousso  <drousso@apple.com>
1366
1367         Web Inspector: Network: add button to show system certificate dialog
1368         https://bugs.webkit.org/show_bug.cgi?id=191458
1369         <rdar://problem/45977019>
1370
1371         Reviewed by Joseph Pecoraro.
1372
1373         * WebCoreSupport/WebInspectorClient.h:
1374         * WebCoreSupport/WebInspectorClient.cpp:
1375         (WebInspectorFrontendClient::showCertificate): Added.
1376
1377 2018-11-16  Brent Fulgham  <bfulgham@apple.com>
1378
1379         [Win] Reduce the use of WKSI library calls: CFNetwork
1380         https://bugs.webkit.org/show_bug.cgi?id=191718
1381         <rdar://problem/46108732>
1382
1383         Reviewed by Alex Christensen.
1384
1385         Remove custom WKSI CFNetwork calls, since the SPI is already documented in PAL. Just
1386         make the same calls on Windows, like we did for iOS and macOS back in 2017.
1387
1388         * WebCache.cpp:
1389         (WebCache::cacheFolder):
1390         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1391         * WebCoreSupport/WebPlatformStrategies.cpp:
1392         * WebError.cpp:
1393         (WebError::localizedDescription):
1394         (WebError::sslPeerCertificate):
1395         * WebURLResponse.cpp:
1396         (WebURLResponse::sslPeerCertificate):
1397         (WebURLResponse::certificateDictionary const):
1398         * WebView.cpp:
1399         (WebView::setCacheModel):
1400
1401 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
1402
1403         [Win] Reduce the use of WKSI library calls: Font Handling
1404         https://bugs.webkit.org/show_bug.cgi?id=191701
1405         <rdar://problem/46104809>
1406
1407         Reviewed by Myles C. Maxfield.
1408
1409         Update to use the old font handling routines moved from WKSI to FontCascade.
1410
1411         * WebPreferences.cpp:
1412         (WebPreferences::setFontSmoothing):
1413         (WebPreferences::setFontSmoothingContrast):
1414         * WebView.cpp:
1415         (systemParameterChanged):
1416
1417 2018-11-14  Timothy Hatcher  <timothy@apple.com>
1418
1419         Default the view background color and text color to different values when in dark mode.
1420         https://bugs.webkit.org/show_bug.cgi?id=191607
1421         rdar://problem/46045854
1422
1423         Reviewed by Dean Jackson.
1424
1425         * WebFrame.cpp:
1426         (WebFrame::updateBackground): Drop backgroundColor.
1427         * WebCoreSupport/WebFrameLoaderClient.cpp:
1428         (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor.
1429
1430 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1431
1432         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1433         https://bugs.webkit.org/show_bug.cgi?id=191612
1434
1435         Reviewed by Matt Baker.
1436
1437         * WebCoreSupport/WebInspectorClient.cpp:
1438         (WebInspectorFrontendClient::destroyInspectorView):
1439
1440 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
1441
1442         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
1443         https://bugs.webkit.org/show_bug.cgi?id=189230
1444         <rdar://problem/44050379>
1445
1446         Reviewed by Joseph Pecoraro.
1447
1448         Runs all png images through zopflipng. This results in a smaller file
1449         size and takes care of this issue as a byproduct.
1450
1451         * WebKit.resources/deleteButton.png:
1452         * WebKit.resources/deleteButtonPressed.png:
1453         * WebKit.resources/fsVideoAudioVolumeHigh.png:
1454         * WebKit.resources/fsVideoAudioVolumeLow.png:
1455         * WebKit.resources/fsVideoExitFullscreen.png:
1456         * WebKit.resources/fsVideoPause.png:
1457         * WebKit.resources/fsVideoPlay.png:
1458         * WebKit.resources/missingImage.png:
1459         * WebKit.resources/nullplugin.png:
1460         * WebKit.resources/panEastCursor.png:
1461         * WebKit.resources/panIcon.png:
1462         * WebKit.resources/panNorthCursor.png:
1463         * WebKit.resources/panNorthEastCursor.png:
1464         * WebKit.resources/panNorthWestCursor.png:
1465         * WebKit.resources/panSouthCursor.png:
1466         * WebKit.resources/panSouthEastCursor.png:
1467         * WebKit.resources/panSouthWestCursor.png:
1468         * WebKit.resources/panWestCursor.png:
1469         * WebKit.resources/searchCancel.png:
1470         * WebKit.resources/searchCancelPressed.png:
1471         * WebKit.resources/searchMagnifier.png:
1472         * WebKit.resources/searchMagnifierResults.png:
1473         * WebKit.resources/textAreaResizeCorner.png:
1474         * WebKit.resources/verticalTextCursor.png:
1475         * WebKit.resources/zoomInCursor.png:
1476         * WebKit.resources/zoomOutCursor.png:
1477
1478 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1479
1480         Unreviewed Windows build fix for r238049.
1481
1482         * WebView.cpp:
1483         (WebView::initWithFrame):
1484
1485 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1486
1487         Unreviewed MSVC build fix after r238039 (and r238046).
1488
1489         * WebDocumentLoader.h:
1490         * WebView.cpp:
1491         (WebView::setShouldApplyMacFontAscentHack):
1492
1493 2018-11-09  Antti Koivisto  <antti@apple.com>
1494
1495         Use OptionSet for layout milestones
1496         https://bugs.webkit.org/show_bug.cgi?id=191470
1497
1498         Reviewed by Dean Jackson.
1499
1500         * WebCoreSupport/WebFrameLoaderClient.cpp:
1501         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1502         * WebCoreSupport/WebFrameLoaderClient.h:
1503
1504 2018-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1505
1506         WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1507         https://bugs.webkit.org/show_bug.cgi?id=191455
1508
1509         Reviewed by Brent Fulgham.
1510
1511         * WebHistory.h: Marked with 'override' and removed 'virtual'.
1512
1513 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1514
1515         Add a storage limit for IndexedDB
1516         https://bugs.webkit.org/show_bug.cgi?id=190598
1517         <rdar://problem/44654715>
1518
1519         Reviewed by Chris Dumez.
1520
1521         * Interfaces/IWebDatabaseManager.idl:
1522         * WebDatabaseManager.cpp:
1523         (WebDatabaseManager::setIDBPerOriginQuota):
1524         * WebDatabaseManager.h:
1525
1526 2018-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1527
1528         [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
1529         https://bugs.webkit.org/show_bug.cgi?id=191105
1530
1531         Reviewed by Brent Fulgham.
1532
1533         * DOMHTMLClasses.h:
1534         (DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
1535         instead of own setNodeValue.
1536
1537 2018-10-25  Antoine Quint  <graouts@apple.com>
1538
1539         [Web Animations] Turn Web Animations CSS Integration off by default
1540         https://bugs.webkit.org/show_bug.cgi?id=190901
1541
1542         Reviewed by Dean Jackson.
1543
1544         * WebPreferences.cpp:
1545         (WebPreferences::initializeDefaultSettings):
1546
1547 2018-10-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1548
1549         [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1550         https://bugs.webkit.org/show_bug.cgi?id=190744
1551
1552         Reviewed by Alex Christensen.
1553
1554         clang-cl reports compilation warnings for inconsistent 'override'
1555         keyword usage.
1556
1557         WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
1558         This can't be marked 'override' if !USE(CA).
1559
1560         * WebView.cpp:
1561         (WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).
1562         * WebView.h: Marked all overriding member function declarations of WebView 'override'.
1563         Declare flushPendingGraphicsLayerChanges only if USE(CA).
1564
1565 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1566
1567         Clean up FrameLoader two-state enums
1568         https://bugs.webkit.org/show_bug.cgi?id=190731
1569
1570         Reviewed by Chris Dumez.
1571
1572         * WebCoreSupport/WebFrameLoaderClient.cpp:
1573         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1574         * WebCoreSupport/WebFrameLoaderClient.h:
1575
1576 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1577
1578         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1579         https://bugs.webkit.org/show_bug.cgi?id=190675
1580
1581         Reviewed by Chris Dumez.
1582
1583         * BackForwardList.cpp:
1584         (BackForwardList::backItem):
1585         (BackForwardList::currentItem):
1586         (BackForwardList::forwardItem):
1587         (BackForwardList::backListCount const):
1588         (BackForwardList::forwardListCount const):
1589         (BackForwardList::itemAtIndex):
1590         * BackForwardList.h:
1591
1592 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
1593
1594         Unreviewed attempt to fix the Windows build after r237112.
1595
1596         * Plugins/PluginView.cpp:
1597         (WebCore::PluginView::performRequest):
1598
1599 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1600
1601         Replace HistoryItem* with HistoryItem& where possible
1602         https://bugs.webkit.org/show_bug.cgi?id=190617
1603
1604         Reviewed by Chris Dumez.
1605
1606         * BackForwardList.cpp:
1607         (BackForwardList::goToItem):
1608         * BackForwardList.h:
1609         * WebBackForwardList.cpp:
1610         (WebBackForwardList::goToItem):
1611
1612 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1613
1614         Fix Windows build.
1615
1616         * WebView.cpp:
1617         (WebView::loadBackForwardListFromOtherView):
1618
1619 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1620
1621         Fix WinCairo build.
1622
1623         * WebView.cpp:
1624         (WebView::backForwardList):
1625
1626 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1627
1628         Modernize BackForwardClient.h
1629         https://bugs.webkit.org/show_bug.cgi?id=190610
1630
1631         Reviewed by Chris Dumez.
1632
1633         * BackForwardList.cpp:
1634         (BackForwardList::backListCount const):
1635         (BackForwardList::forwardListCount const):
1636         (BackForwardList::backListCount): Deleted.
1637         (BackForwardList::forwardListCount): Deleted.
1638         * BackForwardList.h:
1639         * WebView.cpp:
1640         (WebView::initWithFrame):
1641         (WebView::backForwardList):
1642
1643 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1644
1645         Remove unused WebView._globalHistoryItem
1646         https://bugs.webkit.org/show_bug.cgi?id=190601
1647
1648         Reviewed by Chris Dumez.
1649
1650         * WebCoreSupport/WebFrameLoaderClient.cpp:
1651         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1652         * WebCoreSupport/WebFrameLoaderClient.h:
1653         * WebView.cpp:
1654         (WebView::globalHistoryItem):
1655         (WebView::setGlobalHistoryItem): Deleted.
1656         * WebView.h:
1657
1658 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1659
1660         Remove unused parameters from FrameLoaderClient::createFrame
1661         https://bugs.webkit.org/show_bug.cgi?id=190587
1662
1663         Reviewed by Chris Dumez.
1664
1665         * WebCoreSupport/WebFrameLoaderClient.cpp:
1666         (WebFrameLoaderClient::createFrame):
1667         * WebCoreSupport/WebFrameLoaderClient.h:
1668
1669 2018-10-15  Chris Dumez  <cdumez@apple.com>
1670
1671         Unreviewed Windows build fix after r237112.
1672
1673         * Plugins/PluginView.cpp:
1674         (WebCore::PluginView::performRequest):
1675         (WebCore::PluginView::load):
1676
1677 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1678
1679         Remove InjectedBundle processing of back/forward lists
1680         https://bugs.webkit.org/show_bug.cgi?id=190459
1681
1682         Reviewed by Chris Dumez.
1683
1684         * WebCoreSupport/WebFrameLoaderClient.cpp:
1685         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1686         * WebCoreSupport/WebFrameLoaderClient.h:
1687
1688 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1689
1690         Remove ParsedURLString
1691         https://bugs.webkit.org/show_bug.cgi?id=190154
1692
1693         Reviewed by Chris Dumez.
1694
1695         * WebDownloadCurl.cpp:
1696         (WebDownload::initWithRequest):
1697         * WebURLResponse.cpp:
1698         (WebURLResponse::createInstance):
1699
1700 2018-09-28  Chris Dumez  <cdumez@apple.com>
1701
1702         Drop support for cross-origin-window-policy header
1703         https://bugs.webkit.org/show_bug.cgi?id=190081
1704
1705         Reviewed by Ryosuke Niwa.
1706
1707         * WebPreferenceKeysPrivate.h:
1708         * WebPreferences.cpp:
1709         (WebPreferences::initializeDefaultSettings):
1710         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1711         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1712         * WebView.cpp:
1713         (WebView::notifyPreferencesChanged):
1714
1715 2018-09-27  Antoine Quint  <graouts@apple.com>
1716
1717         [Web Animations] Turn Web Animations with CSS integration on
1718         https://bugs.webkit.org/show_bug.cgi?id=184819
1719         <rdar://problem/39597337>
1720
1721         Reviewed by Dean Jackson.
1722
1723         * WebPreferences.cpp:
1724         (WebPreferences::initializeDefaultSettings):
1725
1726 2018-09-21  Alex Christensen  <achristensen@webkit.org>
1727
1728         Use a Variant for FormDataElement
1729         https://bugs.webkit.org/show_bug.cgi?id=189777
1730
1731         Reviewed by Chris Dumez.
1732
1733         * WebMutableURLRequest.cpp:
1734         (WebMutableURLRequest::setHTTPBody):
1735
1736 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1737
1738         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
1739         https://bugs.webkit.org/show_bug.cgi?id=189612
1740
1741         Reviewed by Alex Christensen.
1742
1743         Non-trivial types can't be used as aruguments of LOG_ERROR and
1744         ASSERT_WITH_MESSAGE.
1745
1746         * DefaultPolicyDelegate.cpp:
1747         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
1748         static_cast<BSTR> to convert BString.
1749         * WebLocalizableStrings.cpp:
1750         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
1751         char* by using 'key.utf8().data()'.
1752
1753 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
1754
1755         Unreviewed, rolling out r235953.
1756
1757         Caused layout test crashes under GuardMalloc.
1758
1759         Reverted changeset:
1760
1761         "Make GraphicsLayers ref-counted, so their tree can persist
1762         when disconnected from RenderLayerBackings"
1763         https://bugs.webkit.org/show_bug.cgi?id=189521
1764         https://trac.webkit.org/changeset/235953
1765
1766 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1767
1768         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
1769         https://bugs.webkit.org/show_bug.cgi?id=189538
1770
1771         Reviewed by Per Arne Vollan.
1772
1773         * WebPreferences.cpp:
1774         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
1775         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
1776         Apply static_cast to the result of OR-ed CFPropertyListFormat.
1777         (WebPreferences::screenFontSubstitutionEnabled):
1778         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
1779
1780 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1781
1782         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
1783         https://bugs.webkit.org/show_bug.cgi?id=189539
1784
1785         Reviewed by Alex Christensen.
1786
1787         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
1788         * WebCoreSupport/WebInspectorClient.cpp:
1789         (WebInspectorWndProc): Ditto.
1790         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
1791         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
1792
1793 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1794
1795         Refactor WebCore::EditAction to be an 8-bit enum class
1796         https://bugs.webkit.org/show_bug.cgi?id=189383
1797
1798         Reviewed by Dan Bernstein.
1799
1800         * WebCoreSupport/WebEditorClient.cpp:
1801         (undoNameForEditAction):
1802
1803 2018-09-04  Frederic Wang  <fwang@igalia.com>
1804
1805         Add basic support for ScrollIntoViewOptions
1806         https://bugs.webkit.org/show_bug.cgi?id=189258
1807
1808         Reviewed by Simon Fraser.
1809
1810         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
1811         can build despite the new scrollIntoView function.
1812
1813 2018-08-31  Chris Dumez  <cdumez@apple.com>
1814
1815         Unreviewed Windows build fix after r235562.
1816
1817         * WebCoreSupport/WebFrameLoaderClient.cpp:
1818         (WebFrameLoaderClient::dispatchWillSubmitForm):
1819
1820 2018-08-31  Chris Dumez  <cdumez@apple.com>
1821
1822         Assertion hit in ~CompletionHandler() from ~WebFrame()
1823         https://bugs.webkit.org/show_bug.cgi?id=189199
1824         <rdar://problem/42657233>
1825
1826         Reviewed by Youenn Fablet.
1827
1828         * WebCoreSupport/WebFrameLoaderClient.cpp:
1829         (WebFrameLoaderClient::dispatchWillSubmitForm):
1830         * WebCoreSupport/WebFrameLoaderClient.h:
1831
1832 2018-08-31  Frederic Wang  <fwang@igalia.com>
1833
1834         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1835         https://bugs.webkit.org/show_bug.cgi?id=182053
1836
1837         Reviewed by Simon Fraser.
1838
1839         Add developer flag to use standard behavior for scrolling* attributes.
1840
1841         * Interfaces/IWebPreferencesPrivate.idl:
1842         * WebPreferenceKeysPrivate.h:
1843         * WebPreferences.cpp:
1844         (WebPreferences::initializeDefaultSettings):
1845         (WebPreferences::CSSOMViewScrollingAPIEnabled):
1846         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
1847         * WebPreferences.h:
1848         * WebView.cpp:
1849         (WebView::notifyPreferencesChanged):
1850
1851 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
1852
1853         [CMake] Replace AVFoundationSupport.py using CMake
1854         https://bugs.webkit.org/show_bug.cgi?id=182891
1855
1856         Reviewed by Per Arne Vollan.
1857
1858         Remove references to the config.h contained in WebCore as it should
1859         not be accessible from outside of WebCore.
1860
1861         * WebKitPrefix.h:
1862
1863 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1864
1865         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
1866         https://bugs.webkit.org/show_bug.cgi?id=188496
1867         <rdar://problem/43216836>
1868
1869         Reviewed by Tim Horton.
1870
1871         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
1872         header directly.
1873
1874         * WebCoreSupport/WebDragClient.cpp:
1875
1876 2018-08-17  Alex Christensen  <achristensen@webkit.org>
1877
1878         Add some plumbing for safe browsing
1879         https://bugs.webkit.org/show_bug.cgi?id=188709
1880
1881         Reviewed by Tim Horton.
1882
1883         * WebCoreSupport/WebFrameLoaderClient.cpp:
1884         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1885         * WebCoreSupport/WebFrameLoaderClient.h:
1886
1887 2018-08-02  David Fenton  <david_fenton@apple.com>
1888
1889         Unreviewed, rolling out r234489.
1890
1891         Caused 50+ crashes and 60+ API failures on iOS
1892
1893         Reverted changeset:
1894
1895         "[WTF] Rename String::format to String::deprecatedFormat"
1896         https://bugs.webkit.org/show_bug.cgi?id=188191
1897         https://trac.webkit.org/changeset/234489
1898
1899 2018-08-01  Tomas Popela  <tpopela@redhat.com>
1900
1901         [WTF] Rename String::format to String::deprecatedFormat
1902         https://bugs.webkit.org/show_bug.cgi?id=188191
1903
1904         Reviewed by Darin Adler.
1905
1906         It should be replaced with string concatenation.
1907
1908         * FullscreenVideoController.cpp:
1909         (timeToString):
1910         * WebView.cpp:
1911         (webKitVersionString):
1912
1913 2018-07-30  Rob Buis  <rbuis@igalia.com>
1914
1915         https://bugs.webkit.org/show_bug.cgi?id=188137
1916         Merge PlatformCookieJar functions into NetworkStorageSession
1917
1918         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1919
1920         Reviewed by Alex Christensen.
1921
1922         * WebCoreSupport/WebPlatformStrategies.cpp:
1923         (WebPlatformStrategies::cookiesForDOM):
1924         (WebPlatformStrategies::setCookiesFromDOM):
1925         (WebPlatformStrategies::cookiesEnabled):
1926         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1927         (WebPlatformStrategies::getRawCookies):
1928         (WebPlatformStrategies::deleteCookie):
1929         * WebPreferences.cpp:
1930         (WebPreferences::clearNetworkLoaderSession):
1931
1932 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
1933
1934         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
1935         https://bugs.webkit.org/show_bug.cgi?id=187963
1936
1937         Reviewed by Alex Christensen.
1938
1939         * Plugins/PluginPackageWin.cpp:
1940         (WebCore::PluginPackage::fetchInfo):
1941         Update split/splitAllowingEmptyEntries usage.
1942
1943 2018-07-18  Antoine Quint  <graouts@apple.com>
1944
1945         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
1946         https://bugs.webkit.org/show_bug.cgi?id=187722
1947
1948         Reviewed by Myles Maxfield.
1949
1950         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
1951
1952         * DOMCoreClasses.cpp:
1953         (DOMElement::font):
1954
1955 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1956
1957         Disable cross-origin-window-policy by default
1958         https://bugs.webkit.org/show_bug.cgi?id=187509
1959
1960         Reviewed by Chris Dumez.
1961
1962         * WebPreferences.cpp:
1963         (WebPreferences::initializeDefaultSettings):
1964
1965 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1966
1967         [WTF] Add user-defined literal for ASCIILiteral
1968         https://bugs.webkit.org/show_bug.cgi?id=186839
1969
1970         Reviewed by Darin Adler.
1971
1972         * Plugins/PluginStream.cpp:
1973         (WebCore::PluginStream::startStream):
1974         * WebCoreSupport/WebContextMenuClient.cpp:
1975         (WebContextMenuClient::searchWithGoogle):
1976
1977 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1978
1979         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
1980         https://bugs.webkit.org/show_bug.cgi?id=186623
1981
1982         Reviewed by Youenn Fablet.
1983
1984         * WebCoreSupport/WebPluginInfoProvider.cpp:
1985         (WebPluginInfoProvider::pluginInfo):
1986         (WebPluginInfoProvider::webVisiblePluginInfo):
1987         * WebCoreSupport/WebPluginInfoProvider.h:
1988
1989 2018-06-13  Chris Dumez  <cdumez@apple.com>
1990
1991         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1992         https://bugs.webkit.org/show_bug.cgi?id=186545
1993
1994         Reviewed by Brady Eidson.
1995
1996         Update client delegate now that parameter type has changed.
1997
1998         * WebCoreSupport/WebFrameLoaderClient.cpp:
1999         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2000         * WebCoreSupport/WebFrameLoaderClient.h:
2001
2002 2018-06-11  Chris Dumez  <cdumez@apple.com>
2003
2004         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
2005         https://bugs.webkit.org/show_bug.cgi?id=186441
2006
2007         Reviewed by Brady Eidson.
2008
2009         Rename existing flag to something a bit more generic, now that it is used for
2010         more things than bypassing the navigation policy check.
2011
2012         * WebView.cpp:
2013         (WebView::goToBackForwardItem):
2014         (WebView::loadBackForwardListFromOtherView):
2015
2016 2018-06-04  Chris Dumez  <cdumez@apple.com>
2017
2018         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
2019         https://bugs.webkit.org/show_bug.cgi?id=186287
2020         <rdar://problem/40783352>
2021
2022         Reviewed by Youenn Fablet.
2023
2024         * Interfaces/IWebPreferencesPrivate.idl:
2025         * WebPreferenceKeysPrivate.h:
2026         * WebPreferences.cpp:
2027         (WebPreferences::initializeDefaultSettings):
2028         (WebPreferences::crossOriginWindowPolicySupportEnabled):
2029         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
2030         * WebPreferences.h:
2031         * WebView.cpp:
2032         (WebView::notifyPreferencesChanged):
2033
2034 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2035
2036         [JSC] Pass VM& parameter as much as possible
2037         https://bugs.webkit.org/show_bug.cgi?id=186085
2038
2039         Reviewed by Saam Barati.
2040
2041         * Plugins/PluginPackage.cpp:
2042         (WebCore::NPN_Invoke):
2043
2044 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2045
2046         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
2047         https://bugs.webkit.org/show_bug.cgi?id=186125
2048
2049         Unreviewed build fix
2050
2051         * WebActionPropertyBag.cpp:
2052         (WebActionPropertyBag::Read):
2053         (findMouseEvent): Deleted.
2054
2055 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
2056
2057         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
2058         https://bugs.webkit.org/show_bug.cgi?id=186027
2059
2060         Unreviewed build fix
2061
2062         * WebMutableURLRequest.cpp:
2063         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
2064         (WebMutableURLRequest::setClientCertificate):
2065
2066 2018-05-25  Chris Dumez  <cdumez@apple.com>
2067
2068         Minor ApplicationCacheStorage clean up
2069         https://bugs.webkit.org/show_bug.cgi?id=185984
2070
2071         Reviewed by Youenn Fablet.
2072
2073         * WebApplicationCache.cpp:
2074         (WebApplicationCache::originsWithCache):
2075
2076 2018-05-24  Chris Dumez  <cdumez@apple.com>
2077
2078         Reduce copying of FontCascadeDescription objects by moving them around
2079         https://bugs.webkit.org/show_bug.cgi?id=185963
2080
2081         Reviewed by Simon Fraser.
2082
2083         Reduce copying of FontCascadeDescription objects by moving them around when possible.
2084
2085         * FullscreenVideoController.cpp:
2086         (FullscreenVideoController::draw):
2087
2088 2018-05-15  Antoine Quint  <graouts@apple.com>
2089
2090         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2091         https://bugs.webkit.org/show_bug.cgi?id=185647
2092
2093         Reviewed by Dean Jackson.
2094
2095         Rename the Web Animations CSS integration flag.
2096
2097         * Interfaces/IWebPreferencesPrivate.idl:
2098         * WebPreferenceKeysPrivate.h:
2099         * WebPreferences.cpp:
2100         (WebPreferences::initializeDefaultSettings):
2101         (WebPreferences::webAnimationsCSSIntegrationEnabled):
2102         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
2103         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
2104         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
2105         * WebPreferences.h:
2106         * WebView.cpp:
2107         (WebView::notifyPreferencesChanged):
2108
2109 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2110
2111         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
2112         https://bugs.webkit.org/show_bug.cgi?id=185505
2113
2114         Unreviewed serious crash fix
2115
2116         Windows port crashes soon since Bug 184996.
2117
2118         * WebPreferences.cpp:
2119         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
2120         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
2121
2122 2018-05-07  Daniel Bates  <dabates@apple.com>
2123
2124         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
2125         https://bugs.webkit.org/show_bug.cgi?id=185170
2126
2127         Reviewed by Per Arne Vollan.
2128
2129         * WebCache.cpp:
2130         (WebCache::empty):
2131
2132 2018-04-27  Chris Dumez  <cdumez@apple.com>
2133
2134         Use WindowProxy instead of DOMWindow in our IDL
2135         https://bugs.webkit.org/show_bug.cgi?id=185022
2136
2137         Reviewed by Sam Weinig.
2138
2139         * DOMCoreClasses.cpp:
2140         (DOMDocument::getComputedStyle):
2141
2142 2018-04-23  Daniel Bates  <dabates@apple.com>
2143
2144         Implement Same-Site cookies
2145         https://bugs.webkit.org/show_bug.cgi?id=159464
2146         <rdar://problem/27196358>
2147
2148         Reviewed by Brent Fulgham.
2149
2150         Pass the Same-Site info through the strategy.
2151
2152         * WebCoreSupport/WebPlatformStrategies.cpp:
2153         (WebPlatformStrategies::cookiesForDOM):
2154         (WebPlatformStrategies::setCookiesFromDOM):
2155         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2156         (WebPlatformStrategies::getRawCookies):
2157         * WebCoreSupport/WebPlatformStrategies.h:
2158
2159 2018-04-23  Daniel Bates  <dabates@apple.com>
2160
2161         Implement Same-Site cookies
2162         https://bugs.webkit.org/show_bug.cgi?id=159464
2163         <rdar://problem/27196358>
2164
2165         Reviewed by Brent Fulgham.
2166
2167         Pass the Same-Site info through the strategy.
2168
2169         * WebCoreSupport/WebPlatformStrategies.cpp:
2170         (WebPlatformStrategies::cookiesForDOM):
2171         (WebPlatformStrategies::setCookiesFromDOM):
2172         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2173         (WebPlatformStrategies::getRawCookies):
2174         * WebCoreSupport/WebPlatformStrategies.h:
2175
2176 2018-04-20  Youenn Fablet  <youenn@apple.com>
2177
2178         Make PluginData cache its web visible plugins
2179         https://bugs.webkit.org/show_bug.cgi?id=184421
2180
2181         Reviewed by Chris Dumez.
2182
2183         * WebCoreSupport/WebPluginInfoProvider.cpp:
2184         (WebPluginInfoProvider::pluginInfo):
2185         (WebPluginInfoProvider::webVisiblePluginInfo):
2186         * WebCoreSupport/WebPluginInfoProvider.h:
2187
2188 2018-04-19  Chris Dumez  <cdumez@apple.com>
2189
2190         Rename JSDOMWindowProxy to JSWindowProxy
2191         https://bugs.webkit.org/show_bug.cgi?id=184797
2192
2193         Reviewed by Sam Weinig.
2194
2195         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
2196
2197         * WebFrame.cpp:
2198         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2199
2200 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2201
2202         Unreviewed rollout of r230632. Regression in memory usage.
2203
2204         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2205
2206         * WebPreferences.cpp:
2207         (WebPreferences::initializeDefaultSettings):
2208
2209 2018-04-17  Chris Dumez  <cdumez@apple.com>
2210
2211         Unreviewed attempt to fix the Windows build after r230721
2212
2213         * WebCoreSupport/WebFrameLoaderClient.cpp:
2214         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2215
2216 2018-04-17  Chris Dumez  <cdumez@apple.com>
2217
2218         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
2219         https://bugs.webkit.org/show_bug.cgi?id=184678
2220         <rdar://problem/39422122>
2221
2222         Reviewed by Alex Christensen.
2223
2224         Add new parameter to dispatchDecidePolicyForNavigationAction.
2225
2226         * WebCoreSupport/WebFrameLoaderClient.cpp:
2227         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2228         * WebCoreSupport/WebFrameLoaderClient.h:
2229
2230 2018-04-12  Antoine Quint  <graouts@apple.com>
2231
2232         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
2233         https://bugs.webkit.org/show_bug.cgi?id=184569
2234         <rdar://problem/38671301>
2235
2236         Reviewed by Jon Lee.
2237
2238         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
2239
2240         * WebPreferences.cpp:
2241
2242 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2243
2244         [WTF] Remove StaticLock
2245         https://bugs.webkit.org/show_bug.cgi?id=184332
2246
2247         Reviewed by Mark Lam.
2248
2249         * WebKitQuartzCoreAdditions/CAView.cpp:
2250         (WKQCA::CAView::releaseAllD3DResources):
2251         * WebLocalizableStrings.cpp:
2252
2253 2018-04-03  Chris Dumez  <cdumez@apple.com>
2254
2255         Drop MainFrame class
2256         https://bugs.webkit.org/show_bug.cgi?id=184191
2257
2258         Reviewed by Darin Adler.
2259
2260         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
2261         relationship between the Page and the MainFrame.
2262
2263         This is ground work for introducing LocalFrame / RemoteFrame concepts.
2264
2265         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2266         * WebCoreSupport/WebContextMenuClient.cpp:
2267         * WebCoreSupport/WebDragClient.cpp:
2268         * WebDropSource.cpp:
2269         * WebFrame.cpp:
2270         * WebView.cpp:
2271
2272 2018-03-26  Chris Dumez  <cdumez@apple.com>
2273
2274         Use SecurityOriginData more consistently in Service Worker code
2275         https://bugs.webkit.org/show_bug.cgi?id=183969
2276
2277         Reviewed by Darin Adler.
2278
2279         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2280
2281         * WebDatabaseManager.cpp:
2282         (WebDatabaseManager::databasesWithOrigin):
2283         (WebDatabaseManager::deleteOrigin):
2284         (WebDatabaseManager::deleteDatabase):
2285         (WebDatabaseManager::setQuota):
2286         * WebSecurityOrigin.cpp:
2287         (WebSecurityOrigin::usage):
2288         (WebSecurityOrigin::quota):
2289         (WebSecurityOrigin::setQuota):
2290
2291 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
2292
2293         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
2294         https://bugs.webkit.org/show_bug.cgi?id=183911
2295         <rdar://problem/38762306>
2296
2297         Reviewed by Youenn Fablet.
2298
2299         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
2300
2301         * WebView.cpp:
2302         (WebView::WebView):
2303
2304 2018-03-25  Commit Queue  <commit-queue@webkit.org>
2305
2306         Unreviewed, rolling out r229954.
2307         https://bugs.webkit.org/show_bug.cgi?id=184000
2308
2309         Caused many layout tests to crash on Apple High Sierra,
2310         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
2311         by dydz on #webkit).
2312
2313         Reverted changeset:
2314
2315         "Use SecurityOriginData more consistently in Service Worker
2316         code"
2317         https://bugs.webkit.org/show_bug.cgi?id=183969
2318         https://trac.webkit.org/changeset/229954
2319
2320 2018-03-24  Chris Dumez  <cdumez@apple.com>
2321
2322         Use SecurityOriginData more consistently in Service Worker code
2323         https://bugs.webkit.org/show_bug.cgi?id=183969
2324
2325         Reviewed by Darin Adler.
2326
2327         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2328
2329         * WebDatabaseManager.cpp:
2330         (WebDatabaseManager::databasesWithOrigin):
2331         (WebDatabaseManager::deleteOrigin):
2332         (WebDatabaseManager::deleteDatabase):
2333         (WebDatabaseManager::setQuota):
2334         * WebSecurityOrigin.cpp:
2335         (WebSecurityOrigin::usage):
2336         (WebSecurityOrigin::quota):
2337         (WebSecurityOrigin::setQuota):
2338
2339 2018-03-23  Chris Dumez  <cdumez@apple.com>
2340
2341         Unreviewed attempt to fix Windows build after r229926.
2342
2343         * WebView.cpp:
2344
2345 2018-03-23  Brady Eidson  <beidson@apple.com>
2346
2347         Go to back/forward list items after a process-swapped navigation.
2348         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
2349
2350         Reviewed by Andy Estes.
2351
2352         * WebView.cpp:
2353         (WebView::goToBackForwardItem):
2354         (WebView::loadBackForwardListFromOtherView):
2355
2356 2018-03-23  Miguel Gomez  <magomez@igalia.com>
2357
2358         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
2359         https://bugs.webkit.org/show_bug.cgi?id=183892
2360
2361         Remove the UpdateContentsFlag parameter as it's not used anymore.
2362
2363         Reviewed by Žan Doberšek.
2364
2365         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2366         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
2367
2368 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
2369
2370         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
2371         https://bugs.webkit.org/show_bug.cgi?id=183335
2372
2373         Reviewed by Alex Christensen.
2374
2375         * Plugins/PluginDatabaseWin.cpp:
2376         * Plugins/PluginMessageThrottlerWin.cpp:
2377         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
2378         * Plugins/PluginPackageWin.cpp:
2379         (WebCore::PluginPackage::load):
2380         * Plugins/PluginView.h:
2381         * Plugins/PluginViewWin.cpp:
2382         * Plugins/npapi.cpp:
2383         * WebCoreSupport/WebFrameLoaderClient.cpp:
2384         (WebFrameLoaderClient::createPlugin):
2385         (WebFrameLoaderClient::createJavaAppletWidget):
2386         * WebView.cpp:
2387         (WebView::WebViewWndProc):
2388
2389 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
2390
2391         [Win] Layout Test fast/html/menuitem-element.html is failing.
2392         https://bugs.webkit.org/show_bug.cgi?id=179299
2393
2394         Reviewed by Per Arne Vollan.
2395
2396         * Interfaces/IWebPreferencesPrivate.idl:
2397         * WebPreferenceKeysPrivate.h:
2398         * WebPreferences.cpp:
2399         (WebPreferences::menuItemElementEnabled):
2400         (WebPreferences::setMenuItemElementEnabled):
2401         * WebPreferences.h:
2402         * WebView.cpp:
2403         (WebView::notifyPreferencesChanged):
2404         Add private web preference "menuItemElementEnabled".
2405
2406 2018-03-12  Antoine Quint  <graouts@apple.com>
2407
2408         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
2409         https://bugs.webkit.org/show_bug.cgi?id=183504
2410         <rdar://problem/38372965>
2411
2412         Reviewed by Dean Jackson and Jon Lee.
2413
2414         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
2415         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
2416
2417         * Interfaces/IWebPreferencesPrivate.idl:
2418         * WebPreferences.cpp:
2419         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2420         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2421         * WebPreferenceKeysPrivate.h
2422         * WebPreferences.h:
2423         * WebView.cpp:
2424         (WebView::notifyPreferencesChanged):
2425
2426 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2427
2428         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
2429         https://bugs.webkit.org/show_bug.cgi?id=183429
2430
2431         Reviewed by Mark Lam.
2432
2433         * WebFrame.cpp:
2434         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2435
2436 2018-03-08  Tim Horton  <timothy_horton@apple.com>
2437
2438         Stop linking ApplicationServices directly
2439         https://bugs.webkit.org/show_bug.cgi?id=182867
2440         <rdar://problem/38252142>
2441
2442         Reviewed by Alex Christensen.
2443
2444         The frameworks that we use that live inside ApplicationServices
2445         have mostly moved out, so import them directly.
2446
2447         * FullscreenVideoController.cpp:
2448
2449 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2450
2451         Fix std::make_unique / new[] using system malloc
2452         https://bugs.webkit.org/show_bug.cgi?id=182975
2453
2454         Reviewed by JF Bastien.
2455
2456         Use Vector instead.
2457
2458         * MarshallingHelpers.cpp:
2459         (MarshallingHelpers::safeArrayToStringArray):
2460         (MarshallingHelpers::safeArrayToIntArray):
2461         * Plugins/PluginPackageWin.cpp:
2462         (WebCore::PluginPackage::fetchInfo):
2463         * WebPreferences.cpp:
2464         (WebPreferences::copyWebKitPreferencesToCFPreferences):
2465         * WebView.cpp:
2466         (WebView::onMenuCommand):
2467
2468 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2469
2470         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
2471         https://bugs.webkit.org/show_bug.cgi?id=183312
2472
2473         Reviewed by Mark Lam.
2474
2475         Remove wtf/CurrentTime.h include pragma.
2476
2477         * WebDownload.cpp:
2478         * WebDownloadCFNet.cpp:
2479         * WebDropSource.cpp:
2480
2481 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2482
2483         Remove monotonicallyIncreasingTime
2484         https://bugs.webkit.org/show_bug.cgi?id=182911
2485
2486         Reviewed by Michael Catanzaro.
2487
2488         * FullscreenVideoController.cpp:
2489         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
2490         * Plugins/PluginMessageThrottlerWin.cpp:
2491         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
2492         (WebCore::PluginMessageThrottlerWin::appendMessage):
2493         * Plugins/PluginMessageThrottlerWin.h:
2494         * WebView.cpp:
2495         (WebView::notifyAnimationStarted):
2496         * WebView.h:
2497
2498 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2499
2500         [Win][DRT] Implement setSpatialNavigationEnabled.
2501         https://bugs.webkit.org/show_bug.cgi?id=183166
2502
2503         Reviewed by Per Arne Vollan.
2504
2505         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
2506
2507         * Interfaces/IWebPreferencesPrivate.idl:
2508         * WebPreferenceKeysPrivate.h:
2509         * WebPreferences.cpp:
2510         (WebPreferences::initializeDefaultSettings):
2511         (WebPreferences::spatialNavigationEnabled):
2512         (WebPreferences::setSpatialNavigationEnabled):
2513         * WebPreferences.h:
2514         * WebView.cpp:
2515         (WebView::notifyPreferencesChanged):
2516
2517 2018-02-28  Alex Christensen  <achristensen@webkit.org>
2518
2519         Reduce use of NetworkingContext in WebKit
2520         https://bugs.webkit.org/show_bug.cgi?id=183213
2521
2522         Reviewed by Brady Eidson.
2523
2524         * Plugins/PluginView.cpp:
2525         (WebCore::PluginView::getValueForURL):
2526
2527 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
2528
2529         Fix WebCore includes within WebKitLegacy
2530         https://bugs.webkit.org/show_bug.cgi?id=183147
2531
2532         Reviewed by Tim Horton.
2533
2534         * Plugins/PluginDatabase.cpp:
2535         * Plugins/PluginDatabaseWin.cpp:
2536         * Plugins/PluginDebug.cpp:
2537         * Plugins/PluginDebug.h:
2538         * Plugins/PluginMainThreadScheduler.cpp:
2539         * Plugins/PluginMessageThrottlerWin.cpp:
2540         * Plugins/PluginMessageThrottlerWin.h:
2541         * Plugins/PluginPackage.cpp:
2542         * Plugins/PluginPackage.h:
2543         * Plugins/PluginPackageWin.cpp:
2544         * Plugins/PluginStream.cpp:
2545         * Plugins/PluginStream.h:
2546         * Plugins/PluginView.cpp:
2547         * Plugins/PluginView.h:
2548         * Plugins/PluginViewWin.cpp:
2549         * Plugins/npapi.cpp:
2550         * WebCoreSupport/WebChromeClient.cpp:
2551         * WebCoreSupport/WebContextMenuClient.cpp:
2552         * WebCoreSupport/WebFrameLoaderClient.cpp:
2553         * WebCoreSupport/WebInspectorClient.cpp:
2554         * WebCoreSupport/WebPlatformStrategies.cpp:
2555         * WebFrame.cpp:
2556         * WebKitMessageLoop.cpp:
2557         * WebView.cpp:
2558         * storage/WebDatabaseProvider.cpp:
2559
2560 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2561
2562         Remove currentTime() / currentTimeMS()
2563         https://bugs.webkit.org/show_bug.cgi?id=183052
2564
2565         Reviewed by Mark Lam.
2566
2567         * WebCoreSupport/WebFrameLoaderClient.cpp:
2568         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2569         * WebCoreSupport/WebFrameLoaderClient.h:
2570         * WebDownload.h:
2571         * WebDownloadCFNet.cpp:
2572         (WebDownload::didStart):
2573         (WebDownload::didReceiveData):
2574         (WebDownload::didFinish):
2575
2576 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
2577
2578         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
2579         https://bugs.webkit.org/show_bug.cgi?id=182883
2580
2581         Reviewed by Per Arne Vollan.
2582
2583         * WebKitPrefix.h:
2584
2585 2018-02-16  Dean Jackson  <dino@apple.com>
2586
2587         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
2588         https://bugs.webkit.org/show_bug.cgi?id=182894
2589
2590         Reviewed by Tim Horton.
2591
2592         Rename OPENGL_ES_2 to OPENGL_ES.
2593
2594         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2595
2596 2018-02-16  Youenn Fablet  <youenn@apple.com>
2597
2598         Allow specifying which plug-ins are supported
2599         https://bugs.webkit.org/show_bug.cgi?id=182748
2600
2601         Reviewed by Chris Dumez.
2602
2603         * WebCoreSupport/WebPluginInfoProvider.cpp:
2604         (WebPluginInfoProvider::getPluginInfo):
2605         * WebCoreSupport/WebPluginInfoProvider.h:
2606
2607 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
2608
2609         WebCore headers should not be included relatively within dependent projects
2610         https://bugs.webkit.org/show_bug.cgi?id=182805
2611
2612         Reviewed by Chris Dumez.
2613
2614         * FullscreenVideoController.h:
2615
2616 2018-02-13  Commit Queue  <commit-queue@webkit.org>
2617
2618         Unreviewed, rolling out r228431.
2619         https://bugs.webkit.org/show_bug.cgi?id=182766
2620
2621         Regressed CMake build stability (Requested by dolmstead on
2622         #webkit).
2623
2624         Reverted changeset:
2625
2626         "[CMake] Make WebCore headers copies"
2627         https://bugs.webkit.org/show_bug.cgi?id=182512
2628         https://trac.webkit.org/changeset/228431
2629
2630 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
2631
2632         [CMake] Make WebCore headers copies
2633         https://bugs.webkit.org/show_bug.cgi?id=182512
2634
2635         Reviewed by Keith Miller.
2636
2637         * FullscreenVideoController.h:
2638         * Plugins/PluginDatabase.cpp:
2639         * Plugins/PluginDatabaseWin.cpp:
2640         * Plugins/PluginDebug.cpp:
2641         * Plugins/PluginMainThreadScheduler.cpp:
2642         * Plugins/PluginMessageThrottlerWin.cpp:
2643         * Plugins/PluginPackage.cpp:
2644         * Plugins/PluginPackageWin.cpp:
2645         * Plugins/PluginStream.cpp:
2646         * Plugins/PluginView.cpp:
2647         * Plugins/PluginViewWin.cpp:
2648         * Plugins/npapi.cpp:
2649         * WebKitMessageLoop.cpp:
2650         * WebKitPrefix.h:
2651         * storage/WebDatabaseProvider.cpp:
2652
2653 2018-01-13  Darin Adler  <darin@apple.com>
2654
2655         Event improvements
2656         https://bugs.webkit.org/show_bug.cgi?id=179591
2657
2658         Reviewed by Chris Dumez.
2659
2660         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
2661         * WebFrame.cpp: Ditto.
2662
2663         * WebScriptWorld.cpp:
2664         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
2665
2666         * WebView.cpp: Removed include of ScriptValue.h.
2667         (WebView::handleEditingKeyboardEvent): Updated for name change from
2668         keyEvent to underlyingPlatformEvent.
2669
2670 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
2671
2672         Remove WebCore/ForwardingHeaders directory
2673         https://bugs.webkit.org/show_bug.cgi?id=182347
2674
2675         Reviewed by Keith Miller.
2676
2677         * Plugins/PluginView.cpp:
2678         * Plugins/PluginViewWin.cpp:
2679         * WebCoreSupport/WebInspectorClient.cpp:
2680         * WebCoreSupport/WebInspectorClient.h:
2681         * WebFrame.cpp:
2682         * WebJavaScriptCollector.cpp:
2683         * WebView.cpp:
2684
2685 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2686
2687         Unreviewed, another attempt to fix the Windows build after r227479.
2688
2689         * WebFrame.cpp:
2690         (WebFrame::elementWithName):
2691
2692 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2693
2694         Unreviewed, try to fix the Windows build after r227479.
2695
2696         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
2697
2698         * WebFrame.cpp:
2699         (WebFrame::elementWithName):
2700         (WebFrame::controlsInForm):
2701
2702 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
2703
2704         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
2705         https://bugs.webkit.org/show_bug.cgi?id=181859
2706         <rdar://problem/36659886>
2707
2708         Reviewed by Alex Christensen.
2709         
2710         Use local include patch.
2711
2712         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
2713         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
2714         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
2715
2716 2018-01-17  Youenn Fablet  <youenn@apple.com>
2717
2718         Put fetch Request.keepalive behind a runtime flag
2719         https://bugs.webkit.org/show_bug.cgi?id=181592
2720
2721         Reviewed by Chris Dumez.
2722
2723         * WebPreferences.cpp:
2724         (WebPreferences::fetchAPIKeepAliveEnabled):
2725         (WebPreferences::setFetchAPIKeepAliveEnabled):
2726         * WebPreferences.h:
2727         * WebView.cpp:
2728         (WebView::notifyPreferencesChanged):
2729
2730 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2731
2732         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2733         https://bugs.webkit.org/show_bug.cgi?id=181637
2734         <rdar://problem/36508471>
2735
2736         Reviewed by Tim Horton.
2737
2738         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
2739
2740         * WebCoreSupport/WebEditorClient.cpp:
2741         (WebEditorClient::replacementURLForResource):
2742         * WebCoreSupport/WebEditorClient.h:
2743
2744 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2745
2746         Remove std::chrono completely
2747         https://bugs.webkit.org/show_bug.cgi?id=181186
2748
2749         Reviewed by Alex Christensen.
2750
2751         * Plugins/PluginStream.cpp:
2752         (WebCore::lastModifiedDateMS):
2753
2754 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2755
2756         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
2757         https://bugs.webkit.org/show_bug.cgi?id=181173
2758
2759         Reviewed by Alex Christensen.
2760
2761         * WebNodeHighlight.cpp:
2762         (WebNodeHighlight::update): Scale the GraphicsContext.
2763
2764 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2765
2766         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
2767         https://bugs.webkit.org/show_bug.cgi?id=181160
2768
2769         Reviewed by Myles C. Maxfield.
2770
2771         * Plugins/PluginView.cpp:
2772         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
2773
2774 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2775
2776         Enable picture-in-picture from inline element on suspend.
2777         https://bugs.webkit.org/show_bug.cgi?id=180942
2778         rdar://problem/34745234
2779
2780         Reviewed by Jer Noble.
2781
2782         Update signature of enterVideoFullscreenForVideoElement.
2783
2784         * WebCoreSupport/WebChromeClient.cpp:
2785         (WebChromeClient::enterVideoFullscreenForVideoElement):
2786         * WebCoreSupport/WebChromeClient.h:
2787
2788 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2789
2790         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
2791         https://bugs.webkit.org/show_bug.cgi?id=180926
2792
2793         Reviewed by Tim Horton.
2794
2795         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
2796         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
2797
2798         * WebCoreSupport/WebFrameLoaderClient.cpp:
2799         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
2800         (WebFrameLoaderClient::pageID const): Ditto.
2801
2802 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2803
2804         Remove unnecessary boolean result of start() functions
2805         https://bugs.webkit.org/show_bug.cgi?id=180856
2806
2807         Reviewed by Darin Adler.
2808
2809         It always returns true.
2810
2811         * WebDownloadCurl.cpp:
2812         (WebDownload::start):
2813
2814 2017-12-14  John Wilander  <wilander@apple.com>
2815
2816         Storage Access API: Implement frame-specific access in the document.cookie layer
2817         https://bugs.webkit.org/show_bug.cgi?id=180682
2818         <rdar://problem/35982257>
2819
2820         Reviewed by Alex Christensen.
2821
2822         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
2823         CookiesStrategy::cookieRequestHeaderFieldValue(), and
2824         CookiesStrategy::getRawCookies() now take optional parameters for
2825         frameID and pageID to allow frame-specific scoping of cookies.
2826
2827         This change makes the return values of FrameLoaderClient::frameID()
2828         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
2829         WebCore can call those getters and get the right return values in
2830         WebKit and std:nullopt in WebKitLegacy.
2831
2832         * WebCoreSupport/WebFrameLoaderClient.cpp:
2833         (WebFrameLoaderClient::pageID const):
2834         (WebFrameLoaderClient::frameID const):
2835             Now return an optional.
2836         * WebCoreSupport/WebFrameLoaderClient.h:
2837         * WebCoreSupport/WebPlatformStrategies.cpp:
2838         (WebPlatformStrategies::cookiesForDOM):
2839         (WebPlatformStrategies::setCookiesFromDOM):
2840         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2841         (WebPlatformStrategies::getRawCookies):
2842         * WebCoreSupport/WebPlatformStrategies.h:
2843
2844 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2845
2846         [WTF] Thread::create should have Thread::tryCreate
2847         https://bugs.webkit.org/show_bug.cgi?id=180333
2848
2849         Reviewed by Darin Adler.
2850
2851         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
2852         (WKQCA::CVDisplayLink::start):
2853
2854 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2855
2856         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
2857         https://bugs.webkit.org/show_bug.cgi?id=180572
2858
2859         Reviewed by Mark Lam.
2860
2861         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
2862         Also we use Lock instead of Mutex.
2863
2864         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
2865         (WKQCA::CAD3DRenderer::swapChain):
2866         (WKQCA::CAD3DRenderer::renderAndPresent):
2867         (WKQCA::CAD3DRenderer::renderToImage):
2868         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2869         (WKQCA::CAD3DRenderer::renderInternal):
2870         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
2871         * WebKitQuartzCoreAdditions/CAView.cpp:
2872         (WKQCA::CAView::Handle::create):
2873         Return Ref<Handle> instead of RefPtr<>.
2874
2875         (WKQCA::CAView::Handle::lock):
2876         (WKQCA::CAView::Handle::view const):
2877         (WKQCA::CAView::Handle::clear):
2878         (WKQCA::views):
2879         (WKQCA::viewsNeedingUpdate):
2880         (WKQCA::CAView::releaseAllD3DResources):
2881         (WKQCA::CAView::CAView):
2882         (WKQCA::CAView::~CAView):
2883         (WKQCA::CAView::setLayer):
2884         (WKQCA::CAView::update):
2885         (WKQCA::CAView::drawToWindow):
2886         (WKQCA::CAView::drawToWindowInternal):
2887         (WKQCA::CAView::drawToImage):
2888         (WKQCA::CAView::willDraw):
2889         (WKQCA::CAView::drawIntoDC):
2890         (WKQCA::CAView::setShouldInvertColors):
2891         (WKQCA::CAView::scheduleNextDraw):
2892         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2893         (WKQCA::CAView::contextDidChange):
2894         (WKQCA::CAView::updateSoon):
2895         (WKQCA::CAView::updateViewsNow):
2896         (WKQCA::CAView::d3dDevice9):
2897         (WKQCA::CAView::Handle::mutex): Deleted.
2898         (WKQCA::globalStateMutex): Deleted.
2899         (): Deleted.
2900         * WebKitQuartzCoreAdditions/CAView.h:
2901
2902 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2903
2904         Use StaticLock instead of NeverDestroyed<Lock>
2905         https://bugs.webkit.org/show_bug.cgi?id=180507
2906
2907         Reviewed by Saam Barati.
2908
2909         * WebLocalizableStrings.cpp:
2910         (findCachedString):
2911         (cacheString):
2912         (mainBundleLocStrings): Deleted.
2913         (frameworkLocStringsMutex): Deleted.
2914
2915 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
2916
2917         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
2918         https://bugs.webkit.org/show_bug.cgi?id=180431
2919         <rdar://problem/34531264>
2920
2921         Reviewed by Simon Fraser.
2922
2923         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
2924         'override' to make sure this doesn't break in the future.
2925
2926         * WebView.cpp:
2927         (WebView::notifyAnimationStarted):
2928         (WebView::paintContents):
2929         * WebView.h:
2930
2931 2017-11-23  Darin Adler  <darin@apple.com>
2932
2933         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2934         https://bugs.webkit.org/show_bug.cgi?id=179981
2935
2936         Reviewed by Sam Weinig.
2937
2938         * WebView.cpp:
2939         (WebView::searchFor): Use |= instead of | to build FindOptions.
2940         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
2941         (WebView::findString): Create FindOptions with |=; the old code just passed a
2942         WebKit FindOptions through without converting to WebCore::FindOptions.
2943
2944 2017-11-23  Darin Adler  <darin@apple.com>
2945
2946         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2947         https://bugs.webkit.org/show_bug.cgi?id=179907
2948
2949         Reviewed by Sam Weinig.
2950
2951         * Plugins/PluginDatabaseWin.cpp:
2952         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
2953         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
2954         * WebDownloadCFNet.cpp:
2955         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
2956
2957         * WebView.cpp:
2958         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
2959         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
2960         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
2961         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
2962         the code does not cause any change in behavior.
2963
2964 2017-11-22  Ali Juma  <ajuma@chromium.org>
2965
2966         Implement VisualViewport API attributes
2967         https://bugs.webkit.org/show_bug.cgi?id=179385
2968
2969         Reviewed by Frédéric Wang.
2970
2971         Add a VisualViewportAPI preference.
2972
2973         * Interfaces/IWebPreferencesPrivate.idl:
2974         * WebPreferenceKeysPrivate.h:
2975         * WebPreferences.cpp:
2976         (WebPreferences::initializeDefaultSettings):
2977         (WebPreferences::visualViewportAPIEnabled):
2978         (WebPreferences::setVisualViewportAPIEnabled):
2979         * WebPreferences.h:
2980         * WebView.cpp:
2981         (WebView::notifyPreferencesChanged):
2982
2983 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2984
2985         Unreviewed, rolling out r225093.
2986         https://bugs.webkit.org/show_bug.cgi?id=179938
2987
2988         Compilation failed on WinCairo 64-bit Release (Requested by
2989         fredw on #webkit).
2990
2991         Reverted changeset:
2992
2993         "Implement VisualViewport API attributes"
2994         https://bugs.webkit.org/show_bug.cgi?id=179385
2995         https://trac.webkit.org/changeset/225093
2996
2997 2017-11-21  Ali Juma  <ajuma@chromium.org>
2998
2999         Implement VisualViewport API attributes
3000         https://bugs.webkit.org/show_bug.cgi?id=179385
3001
3002         Reviewed by Frédéric Wang.
3003
3004         Add a VisualViewportAPI preference.
3005
3006         * Interfaces/IWebPreferencesPrivate.idl:
3007         * WebPreferenceKeysPrivate.h:
3008         * WebPreferences.cpp:
3009         (WebPreferences::initializeDefaultSettings):
3010         (WebPreferences::visualViewportAPIEnabled):
3011         (WebPreferences::setVisualViewportAPIEnabled):
3012         * WebPreferences.h:
3013         * WebView.cpp:
3014         (WebView::notifyPreferencesChanged):
3015
3016 2017-11-14  Alex Christensen  <achristensen@webkit.org>
3017
3018         Clean up old URL parser remnants
3019         https://bugs.webkit.org/show_bug.cgi?id=179573
3020
3021         Reviewed by Darin Adler.
3022
3023         * WebCoreSupport/WebContextMenuClient.cpp:
3024         (WebContextMenuClient::searchWithGoogle):
3025         Use https if we do end up searching with google.
3026
3027 2017-11-12  Darin Adler  <darin@apple.com>
3028
3029         More is<> and downcast<>, less static_cast<>
3030         https://bugs.webkit.org/show_bug.cgi?id=179600
3031
3032         Reviewed by Chris Dumez.
3033
3034         * WebView.cpp:
3035         (WebView::handleEditingKeyboardEvent): Use downcast.
3036
3037 2017-11-09  Christopher Reid  <chris.reid@sony.com>
3038
3039         Use enum classes within FileSystem
3040         https://bugs.webkit.org/show_bug.cgi?id=175172
3041
3042         Reviewed by Darin Adler.
3043
3044         * Plugins/PluginDatabase.cpp:
3045
3046 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
3047
3048         [Win] Add WebKitQuartzCoreAdditions library.
3049         https://bugs.webkit.org/show_bug.cgi?id=179331
3050
3051         Reviewed by Alex Christensen.
3052
3053         * WebKitQuartzCoreAdditions: Added.
3054         * WebKitQuartzCoreAdditions/API: Added.
3055         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
3056         (toImage):
3057         (WKCACFImageGetWidth):
3058         (WKCACFImageGetHeight):
3059         (WKCACFImageCopyFileMapping):
3060         (WKCACFImageCreateWithImage):
3061         (WKCACFImageFinalize):
3062         (WKCACFImageCopyFormattingDescription):
3063         (WKCACFImageCopyDebugDescription):
3064         (WKCACFImageGetTypeID):
3065         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
3066         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
3067         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
3068         (toView):
3069         (toImpl):
3070         (WKCACFViewCreate):
3071         (WKCACFViewSetLayer):
3072         (WKCACFViewUpdate):
3073         (WKCACFViewFlushContext):
3074         (WKCACFViewInvalidateRects):
3075         (WKCACFViewCanDraw):
3076         (WKCACFViewDraw):
3077         (WKCACFViewCopyDrawnImage):
3078         (WKCACFViewDrawIntoDC):
3079         (contextDidChangeCallback):
3080         (WKCACFViewSetContextDidChangeCallback):
3081         (WKCACFViewGetLastCommitTime):
3082         (WKCACFViewSetContextUserData):
3083         (WKCACFViewGetContext):
3084         (WKCACFViewFinalize):
3085         (WKCACFViewCopyFormattingDescription):
3086         (WKCACFViewCopyDebugDescription):
3087         (WKCACFViewGetTypeID):
3088         (WKCACFViewSetShouldInvertColors):
3089         (WKCACFViewGetD3DDevice9):
3090         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
3091         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
3092         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
3093         (WKQCA::dllInstance):
3094         (DllMain):
3095         (WKCACFShutDown):
3096         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
3097         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
3098         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
3099         (WKQCA::d3d):
3100         (WKQCA::initialPresentationParameters):
3101         (WKQCA::CAD3DRenderer::shared):
3102         (WKQCA::CAD3DRenderer::CAD3DRenderer):
3103         (WKQCA::CAD3DRenderer::swapChain):
3104         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
3105         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
3106         (WKQCA::CAD3DRenderer::initialize):
3107         (WKQCA::D3DMatrixOrthoOffCenterRH):
3108         (WKQCA::prepareDevice):
3109         (WKQCA::updateBounds):
3110         (WKQCA::CAD3DRenderer::renderAndPresent):
3111         (WKQCA::CAD3DRenderer::renderToImage):
3112         (WKQCA::CAD3DRenderer::setDeviceIsLost):
3113         (WKQCA::CAD3DRenderer::renderInternal):
3114         (WKQCA::CAD3DRenderer::postProcess):
3115         (WKQCA::CAD3DRenderer::resetD3DDevice):
3116         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
3117         (WKQCA::CAD3DRenderer::release):
3118         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
3119         (WKQCA::D3DPostProcessingContext::sceneTexture const):
3120         (WKQCA::D3DPostProcessingContext::overlayQuad const):
3121         (WKQCA::CAD3DRenderer::d3dDevice9 const):
3122         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
3123         (WKQCA::CAView::Handle::create):
3124         (WKQCA::CAView::Handle::~Handle):
3125         (WKQCA::CAView::Handle::mutex):
3126         (WKQCA::CAView::Handle::view const):
3127         (WKQCA::CAView::Handle::clear):
3128         (WKQCA::CAView::Handle::Handle):
3129         (WKQCA::globalStateMutex):
3130         (WKQCA::registerMessageWindowClass):
3131         (WKQCA::createMessageWindow):
3132         (WKQCA::CAView::releaseAllD3DResources):
3133         (WKQCA::CAView::CAView):
3134         (WKQCA::CAView::~CAView):
3135         (WKQCA::CAView::create):
3136         (WKQCA::CAView::setContextDidChangeCallback):
3137         (WKQCA::CAView::setLayer):
3138         (WKQCA::CAView::update):
3139         (WKQCA::CAView::invalidateRects):
3140         (WKQCA::CAView::drawToWindow):
3141         (WKQCA::CAView::drawToWindowInternal):
3142         (WKQCA::CAView::drawToImage):
3143         (WKQCA::CAView::willDraw):
3144         (WKQCA::CAView::didDraw):
3145         (WKQCA::CAView::drawIntoDC):
3146         (WKQCA::CAView::setShouldInvertColors):
3147         (WKQCA::CAView::scheduleNextDraw):
3148         (WKQCA::CAView::displayLinkReachedCAMediaTime):
3149         (WKQCA::CAView::contextDidChangeCallback):
3150         (WKQCA::CAView::contextDidChange):
3151         (WKQCA::CAView::updateSoon):
3152         (WKQCA::CAView::updateViewsNow):
3153         (WKQCA::CAView::d3dDevice9):
3154         * WebKitQuartzCoreAdditions/CAView.h: Added.
3155         (WKQCA::CAView::context const):
3156         (WKQCA::CAView::canDraw const):
3157         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
3158         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
3159         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
3160         (WKQCA::CVDisplayLink::CVDisplayLink):
3161         (WKQCA::CVDisplayLink::~CVDisplayLink):
3162         (WKQCA::CVDisplayLink::create):
3163         (WKQCA::CVDisplayLink::start):
3164         (WKQCA::CVDisplayLink::stop):
3165         (WKQCA::CVDisplayLink::setPaused):
3166         (WKQCA::CVDisplayLink::runIOThread):
3167         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
3168         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
3169         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
3170         * WebKitQuartzCoreAdditions/Image.cpp: Added.
3171         (WKQCA::numBytesForSize):
3172         (WKQCA::Image::create):
3173         (WKQCA::Image::Image):
3174         (WKQCA::Image::~Image):
3175         (WKQCA::bitmapInfo):
3176         (WKQCA::Image::createDIB const):
3177         (WKQCA::Image::copyFileMapping):
3178         * WebKitQuartzCoreAdditions/Image.h: Added.
3179         (WKQCA::Image::size const):
3180         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
3181         (WKQCA::getBackBufferRectAsRenderTarget):
3182         (WKQCA::getSystemMemoryCopy):
3183         (WKQCA::copyRectToBitmap):
3184         (WKQCA::getImageCopy):
3185         (WKQCA::getBackBufferRectAsImage):
3186         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
3187         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
3188         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
3189         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
3190         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
3191
3192 2017-11-06  Christopher Reid  <chris.reid@sony.com>
3193
3194         Use enum classes within FileSystem
3195         https://bugs.webkit.org/show_bug.cgi?id=175172
3196
3197         Reviewed by Myles C. Maxfield.
3198
3199         * Plugins/PluginDatabase.cpp:
3200
3201 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
3202
3203         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
3204         https://bugs.webkit.org/show_bug.cgi?id=178333
3205
3206         Reviewed by Darin Adler.
3207
3208         * WebCoreSupport/WebFrameLoaderClient.cpp:
3209         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
3210
3211 2017-11-02  Alex Christensen  <achristensen@webkit.org>
3212
3213         Use CompletionHandlers for redirects
3214         https://bugs.webkit.org/show_bug.cgi?id=179163
3215
3216         Reviewed by Tim Horton.
3217
3218         * Plugins/PluginStream.cpp:
3219         (WebCore::PluginStream::willSendRequest):
3220         * Plugins/PluginStream.h:
3221         (WebCore::PluginStreamClient::~PluginStreamClient):
3222         (WebCore::PluginStreamClient::streamDidFinishLoading):
3223         (WebCore::PluginStream::create):
3224         (WebCore::PluginStream::setLoadManually):
3225
3226 2017-11-02  Christopher Reid  <chris.reid@sony.com>
3227
3228         Add a FileSystem namespace to FileSystem.cpp
3229         https://bugs.webkit.org/show_bug.cgi?id=179063
3230
3231         Reviewed by Darin Adler.
3232
3233         * Plugins/PluginDatabase.cpp:
3234         * Plugins/PluginPackage.cpp:
3235         * Plugins/PluginStream.cpp:
3236         * Plugins/PluginStream.h:
3237         * WebApplicationCache.cpp:
3238         * WebDatabaseManager.cpp:
3239         * WebDownloadCurl.cpp:
3240         * WebPreferences.cpp:
3241         * WebView.cpp:
3242
3243 2017-10-31  Alex Christensen  <achristensen@webkit.org>
3244
3245         Fix Windows build after r224260
3246
3247         * WebView.cpp:
3248         (WebView::gesture):
3249
3250 2017-10-28  Zalan Bujtas  <zalan@apple.com>
3251
3252         [FrameView::layout cleanup] Move core layout logic to a separate class.
3253         https://bugs.webkit.org/show_bug.cgi?id=178771
3254         <rdar://problem/35166542>
3255
3256         Reviewed by Simon Fraser.
3257
3258         Move layout code out from FrameView to LayoutContext.
3259
3260         * WebFrame.cpp:
3261         (WebFrame::layout):
3262
3263 2017-10-26  Alex Christensen  <achristensen@webkit.org>
3264
3265         Fix Windows build
3266         https://bugs.webkit.org/show_bug.cgi?id=178892
3267
3268         * AccessibleBase.cpp:
3269         (MSAARole):
3270
3271 2017-10-26  Alex Christensen  <achristensen@webkit.org>
3272
3273         Fix Windows build
3274         https://bugs.webkit.org/show_bug.cgi?id=178892
3275
3276         * AccessibleBase.cpp:
3277         (AccessibleBase::state const):
3278         (MSAARole):
3279
3280 2017-10-25  Youenn Fablet  <youenn@apple.com>
3281
3282         Enable ServiceWorker to fetch resources
3283         https://bugs.webkit.org/show_bug.cgi?id=178673
3284
3285         Reviewed by Brady Eidson.
3286
3287         Added implementation to the new getters.
3288         They are noop in the context of WK1.
3289
3290         * WebCoreSupport/WebFrameLoaderClient.cpp:
3291         (WebFrameLoaderClient::pageID const):
3292         (WebFrameLoaderClient::frameID const):
3293         (WebFrameLoaderClient::sessionID const):
3294         * WebCoreSupport/WebFrameLoaderClient.h:
3295
3296 2017-10-20  Antoine Quint  <graouts@apple.com>
3297
3298         [Web Animations] Provide basic timeline and animation interfaces
3299         https://bugs.webkit.org/show_bug.cgi?id=178526
3300
3301         Reviewed by Dean Jackson.
3302
3303         Remove the WEB_ANIMATIONS compile-time flag.
3304
3305         * WebView.cpp:
3306         (WebView::notifyPreferencesChanged):
3307
3308 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3309
3310         [Curl] Clean up old style code in old curl files.
3311         https://bugs.webkit.org/show_bug.cgi?id=178569
3312
3313         Reviewed by Ryosuke Niwa.
3314
3315         * WebCache.cpp:
3316         (WebCache::cacheFolder):
3317         (WebCache::setCacheFolder):
3318         * WebView.cpp:
3319         (WebView::setCacheModel):
3320
3321 2017-10-19  Sam Weinig  <sam@webkit.org>
3322
3323         [Settings] Move global settings into their own file
3324         https://bugs.webkit.org/show_bug.cgi?id=178512
3325
3326         Reviewed by Darin Adler.
3327
3328         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
3329
3330         * WebView.cpp:
3331         (WebView::initWithFrame):
3332
3333 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
3334
3335         Replace some stack raw pointers with RefPtrs within WebCore/html
3336         https://bugs.webkit.org/show_bug.cgi?id=178201
3337         <rdar://problem/34841692>
3338
3339         Reviewed by Ryosuke Niwa.
3340
3341         * WebView.cpp:
3342         (WebView::handleEditingKeyboardEvent):
3343         Change the type of node as toNode() is changed to return RefPtr.
3344
3345 2017-10-16  Sam Weinig  <sam@webkit.org>
3346
3347         [Settings] Remove all custom code from Settings.h/cpp
3348         https://bugs.webkit.org/show_bug.cgi?id=178330
3349
3350         Reviewed by Simon Fraser.
3351
3352         * WebView.cpp:
3353         (WebView::notifyPreferencesChanged):
3354             
3355             Update for naming changes of FrameFlattening now that it is an enum class.
3356
3357 2017-10-11  Chris Dumez  <cdumez@apple.com>
3358
3359         Modernize Geolocation code
3360         https://bugs.webkit.org/show_bug.cgi?id=178148
3361
3362         Reviewed by Ryosuke Niwa.
3363
3364         * WebCoreSupport/WebGeolocationClient.cpp:
3365         (WebGeolocationClient::lastPosition):
3366         * WebCoreSupport/WebGeolocationClient.h:
3367         * WebGeolocationPosition.cpp:
3368         (WebGeolocationPosition::initWithTimestamp):
3369         (core):
3370         * WebGeolocationPosition.h:
3371         (WebGeolocationPosition::impl const):
3372
3373 2017-10-05  Chris Dumez  <cdumez@apple.com>
3374
3375         Drop unused parameters for CookiesStrategy::cookiesEnabled()
3376         https://bugs.webkit.org/show_bug.cgi?id=177957
3377
3378         Reviewed by Alex Christensen.
3379
3380         * WebCoreSupport/WebPlatformStrategies.cpp:
3381         (WebPlatformStrategies::cookiesEnabled):
3382         * WebCoreSupport/WebPlatformStrategies.h:
3383
3384 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3385
3386         [Curl] Reimplement CurlDownload with CurlRequest
3387         https://bugs.webkit.org/show_bug.cgi?id=177779
3388
3389         Reviewed by Alex Christensen.
3390
3391         * WebDownload.h:
3392         * WebDownloadCurl.cpp:
3393         (WebDownload::init):
3394         (WebDownload::didReceiveResponse):
3395
3396 2017-09-29  Chris Dumez  <cdumez@apple.com>
3397
3398         Split some logic out of VisitedLinkStore and make it reusable
3399         https://bugs.webkit.org/show_bug.cgi?id=177575
3400
3401         Reviewed by Alex Christensen.
3402
3403         * WebCoreSupport/WebVisitedLinkStore.cpp:
3404         (WebVisitedLinkStore::addVisitedLink):
3405         (WebVisitedLinkStore::isLinkVisited):
3406         (WebVisitedLinkStore::addVisitedLinkHash):
3407         * WebCoreSupport/WebVisitedLinkStore.h:
3408
3409 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3410
3411         Make PolicyAction an encodable enum class
3412         https://bugs.webkit.org/show_bug.cgi?id=177480
3413
3414         Reviewed by Antti Koivisto.
3415
3416         * WebCoreSupport/WebFrameLoaderClient.cpp:
3417         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3418         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3419         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3420         * WebFramePolicyListener.cpp:
3421         (WebFramePolicyListener::use):
3422         (WebFramePolicyListener::download):
3423         (WebFramePolicyListener::ignore):
3424         (WebFramePolicyListener::continueSubmit):
3425
3426 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
3427
3428         [Win] fast/canvas/2d.getPath.modification.html is failing.
3429         https://bugs.webkit.org/show_bug.cgi?id=176534
3430
3431         Reviewed by Alex Christensen.
3432
3433         We need to enable Inspector additions at runtime in order to expose the getPath function.
3434
3435         * Interfaces/IWebPreferencesPrivate.idl:
3436         * WebPreferenceKeysPrivate.h:
3437         * WebPreferences.cpp:
3438         (WebPreferences::initializeDefaultSettings):
3439         (WebPreferences::setDataTransferItemsEnabled):
3440         (WebPreferences::inspectorAdditionsEnabled):
3441         (WebPreferences::setInspectorAdditionsEnabled):
3442         * WebPreferences.h:
3443         * WebView.cpp:
3444         (WebView::notifyPreferencesChanged):
3445
3446 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3447
3448         Modernize Geolocation code
3449         https://bugs.webkit.org/show_bug.cgi?id=176496
3450
3451         Reviewed by Andy Estes.
3452
3453         * WebCoreSupport/WebGeolocationClient.cpp:
3454         (WebGeolocationClient::requestPermission):
3455         * WebCoreSupport/WebGeolocationClient.h:
3456         (WebGeolocationClient::setEnableHighAccuracy): Deleted.
3457         (WebGeolocationClient::cancelPermissionRequest): Deleted.
3458         * WebGeolocationPolicyListener.h:
3459         * WebView.cpp:
3460         (WebView::initWithFrame):
3461         (WebView::geolocationDidFailWithError):
3462
3463 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
3464
3465         [Win] Enable DatatransferItems in DRT.
3466         https://bugs.webkit.org/show_bug.cgi?id=176424
3467
3468         Reviewed by Brent Fulgham.
3469
3470         * Interfaces/IWebPreferencesPrivate.idl:
3471         * WebPreferenceKeysPrivate.h:
3472         * WebPreferences.cpp:
3473         (WebPreferences::initializeDefaultSettings):
3474         (WebPreferences::QueryInterface):
3475         (WebPreferences::isSecureContextAttributeEnabled):
3476         (WebPreferences::dataTransferItemsEnabled):
3477         (WebPreferences::setDataTransferItemsEnabled):
3478         * WebPreferences.h:
3479         * WebView.cpp:
3480         (WebView::notifyPreferencesChanged):
3481
3482 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3483
3484         Unreviewed build fix #2 after r221275.
3485
3486         * WebCoreSupport/WebPlatformStrategies.cpp:
3487         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
3488         to match new API.
3489         * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
3490
3491 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3492
3493         Unreviewed build fix after r221275.
3494
3495         * WebCoreSupport/WebPlatformStrategies.cpp:
3496         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
3497         to match new API.
3498
3499 2017-08-28  Per Arne Vollan  <pvollan@apple.com>
3500
3501         [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
3502         https://bugs.webkit.org/show_bug.cgi?id=176031
3503
3504         Reviewed by Brent Fulgham.
3505
3506         When the function in the FramePolicyFunction parameter is called, it has already been moved
3507         to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
3508         function by using the stored member instead.
3509
3510         * WebCoreSupport/WebFrameLoaderClient.cpp:
3511         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3512         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3513         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3514
3515 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3516
3517         Unreviewed, try to fix the Windows build after r221064
3518
3519         didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
3520
3521         * WebCoreSupport/WebEditorClient.h:
3522
3523 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3524
3525         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3526         https://bugs.webkit.org/show_bug.cgi?id=175370
3527         <rdar://problem/33799806>
3528
3529         Reviewed by Ryosuke Niwa.
3530
3531         Adjust WebEditorClient for interface changes.
3532
3533         * WebCoreSupport/WebEditorClient.h:
3534
3535 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
3536
3537         Unreviewed build fix after r221017.
3538
3539         Correct copy/paste error.
3540
3541         * WebCoreSupport/WebPlatformStrategies.cpp:
3542         (WebPlatformStrategies::cookiesForDOM):
3543
3544 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
3545
3546         Unreviewed build fix after r221017.
3547
3548         * WebCoreSupport/WebPlatformStrategies.cpp:
3549         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
3550         * WebCoreSupport/WebPlatformStrategies.h:
3551
3552 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3553
3554         Remove ChromeClient::scrollbarsModeDidChange
3555         https://bugs.webkit.org/show_bug.cgi?id=175805
3556
3557         Reviewed by Daniel Bates.
3558
3559         * WebCoreSupport/WebChromeClient.h:
3560
3561 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3562
3563         Remove ChromeClient::hasOpenedPopup
3564         https://bugs.webkit.org/show_bug.cgi?id=175804
3565
3566         Reviewed by Sam Weinig.
3567
3568         * WebCoreSupport/WebChromeClient.cpp:
3569         (WebChromeClient::hasOpenedPopup const): Deleted.
3570         * WebCoreSupport/WebChromeClient.h:
3571
3572 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
3573
3574         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
3575         https://bugs.webkit.org/show_bug.cgi?id=173536
3576
3577         Reviewed by Brent Fulgham.
3578
3579         If the tree state is dirty, accessible objects are deleted while iterating over children
3580         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
3581         style is updated before this method is called.
3582
3583         * AccessibleBase.cpp:
3584         (AccessibleBase::getAccessibilityObjectForChild):
3585
3586 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3587
3588         [PAL] Move SessionID into PAL
3589         https://bugs.webkit.org/show_bug.cgi?id=174192
3590
3591         Reviewed by Antti Koivisto.
3592
3593         * WebCoreSupport/WebFrameLoaderClient.cpp:
3594         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3595         * WebCoreSupport/WebFrameLoaderClient.h:
3596         * WebCoreSupport/WebFrameNetworkingContext.cpp:
3597         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
3598         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3599         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3600         (WebFrameNetworkingContext::storageSession const):
3601         * WebCoreSupport/WebPlatformStrategies.cpp:
3602         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3603         * WebCoreSupport/WebPlatformStrategies.h:
3604
3605 2017-08-15  Youenn Fablet  <youenn@apple.com>
3606
3607         [Cache API] Adding generic support for CacheStorage and Cache methods
3608         https://bugs.webkit.org/show_bug.cgi?id=175455
3609
3610         Reviewed by Chris Dumez.
3611
3612         * WebView.cpp:
3613         (WebView::initWithFrame):
3614
3615 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3616
3617         Composition underline color is always black
3618         https://bugs.webkit.org/show_bug.cgi?id=174675
3619
3620         Reviewed by Ryosuke Niwa.
3621
3622         * WebView.cpp:
3623         (WebView::setCompositionForTesting): Use text color for
3624         composition underline.
3625
3626 2017-08-09  Daniel Bates  <dabates@apple.com>
3627
3628         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3629         https://bugs.webkit.org/show_bug.cgi?id=175247
3630         <rdar://problem/33679804>
3631
3632         Reviewed by Brady Eidson.
3633
3634         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3635         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3636         clients that need to make use of this information at this time. If such a needs comes up
3637         then we can expose API/SPI similar to what we do for WebKit.
3638
3639         * WebCoreSupport/WebFrameLoaderClient.cpp:
3640         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3641         * WebCoreSupport/WebFrameLoaderClient.h:
3642
3643 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3644
3645         Async image decoding for large images should be disabled after the first time a tile is painted
3646         https://bugs.webkit.org/show_bug.cgi?id=174451
3647         <rdar://problem/31246421>
3648
3649         Reviewed by Simon Fraser.
3650
3651         * FullscreenVideoController.cpp:
3652         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3653         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3654         (AcceleratedCompositingContext::paintContents):
3655         * WebCoreSupport/AcceleratedCompositingContext.h:
3656
3657 2017-07-23  Darin Adler  <darin@apple.com>
3658
3659         More NeverDestroyed and related cleanup
3660         https://bugs.webkit.org/show_bug.cgi?id=174745
3661
3662         Reviewed by Alex Christensen.
3663
3664         * Plugins/PluginDatabase.cpp:
3665         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
3666         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
3667         * Plugins/PluginMainThreadScheduler.cpp:
3668         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
3669         * Plugins/PluginMainThreadScheduler.h: Ditto.
3670         * WebCoreSupport/WebPlatformStrategies.cpp:
3671         (WebPlatformStrategies::initialize): Ditto.
3672         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
3673         * WebHistory.cpp:
3674         (sharedHistoryStorage): Ditto.
3675         * WebLocalizableStrings.cpp:
3676         (mainBundleLocStrings): Ditto.
3677         (frameworkLocStringsMutex): Ditto.
3678         (frameworkLocStrings): Ditto.
3679         * WebView.cpp:
3680         (WebView::standardUserAgentWithApplicationName): Ditto.
3681         Also changed to keep one global string with the prefix of the user agent string
3682         instead of keeping two globals with pieces of that prefix.
3683
3684 2017-07-24  Chris Dumez  <cdumez@apple.com>
3685
3686         Make ExceptionCode a proper enumeration
3687         https://bugs.webkit.org/show_bug.cgi?id=174771
3688
3689         Reviewed by Sam Weinig.
3690
3691         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
3692
3693         * DOMCoreClasses.cpp:
3694         (DOMDocument::createEvent):
3695         * WebView.cpp:
3696         (WebView::prepareCandidateWindow):
3697
3698 2017-07-21  Andreas Kling  <akling@apple.com>
3699
3700         Use more references in event dispatch code
3701         https://bugs.webkit.org/show_bug.cgi?id=174681
3702
3703         Reviewed by Geoffrey Garen.
3704
3705         * DOMEventsClasses.cpp:
3706         (WebEventListener::handleEvent):
3707         * DOMEventsClasses.h:
3708         * Plugins/PluginView.cpp:
3709         (WebCore::PluginView::handleEvent):
3710         * Plugins/PluginView.h:
3711
3712 2017-07-20  Brady Eidson  <beidson@apple.com>
3713
3714         Remove WebIconDatabase from WebKitLegacy/win.
3715         https://bugs.webkit.org/show_bug.cgi?id=174608
3716
3717         Reviewed by Alex Christensen.
3718
3719         It is unused.
3720         
3721         * ForEachCoClass.h:
3722
3723         * Interfaces/IWebIconDatabase.idl: Removed.
3724
3725         * Interfaces/WebKit.idl:
3726
3727         * WebCoreStatistics.cpp:
3728         (WebCoreStatistics::iconPageURLMappingCount):
3729         (WebCoreStatistics::iconRetainedPageURLCount):
3730         (WebCoreStatistics::iconRecordCount):
3731         (WebCoreStatistics::iconsWithDataCount):
3732
3733         * WebIconDatabase.cpp: Removed.
3734         * WebIconDatabase.h: Removed.
3735         * WebKitClassFactory.cpp:
3736
3737         * WebKitDLL.cpp:
3738         (shutDownWebKit):
3739
3740         * WebKitLogging.h:
3741
3742         * WebView.cpp:
3743         (WebView::close):
3744         (WebView::notifyDidAddIcon):
3745         (WebView::registerForIconNotification):
3746         (WebView::dispatchDidReceiveIconFromWebFrame):
3747         (WebView::onNotify):
3748
3749 2017-07-18  Matt Lewis  <jlewis3@apple.com>
3750
3751         Unreviewed, rolling out r219610.
3752
3753         This caused an api failure on all platforms for the test
3754         SnapshotImageLargeAsyncDecoding
3755
3756         Reverted changeset:
3757
3758         "Async image decoding for large images should be disabled
3759         after the first time a tile is painted"
3760         https://bugs.webkit.org/show_bug.cgi?id=174451
3761         http://trac.webkit.org/changeset/219610
3762
3763 2017-07-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
3764
3765         Async image decoding for large images should be disabled after the first time a tile is painted
3766         https://bugs.webkit.org/show_bug.cgi?id=174451
3767
3768         Reviewed by Simon Fraser.
3769
3770         * FullscreenVideoController.cpp:
3771         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3772         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3773         (AcceleratedCompositingContext::paintContents):
3774         * WebCoreSupport/AcceleratedCompositingContext.h:
3775
3776 2017-07-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3777
3778         [Curl] Don't start downloading more than once for same request
3779         https://bugs.webkit.org/show_bug.cgi?id=174172
3780
3781         Reviewed by Alex Christensen.
3782
3783         * WebDownloadCurl.cpp:
3784         (WebDownload::init):
3785
3786 2017-07-12  Daniel Bates  <dabates@apple.com>
3787
3788         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3789         https://bugs.webkit.org/show_bug.cgi?id=174427
3790
3791         Rubber-stamped by Brady Eidson.
3792
3793         * Plugins/PluginView.cpp:
3794         (WebCore::PluginView::start):
3795         (WebCore::PluginView::getURLNotify):
3796         (WebCore::PluginView::getURL):
3797         (WebCore::PluginView::handlePost):
3798
3799 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3800
3801         [WTF] Move SoftLinking.h into WTF
3802         https://bugs.webkit.org/show_bug.cgi?id=174000
3803
3804         Reviewed by Alex Christensen.
3805
3806         * WebKitClassFactory.cpp:
3807         * WebView.cpp:
3808
3809 2017-07-05  Brady Eidson  <beidson@apple.com>
3810
3811         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3812         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3813
3814         Reviewed by Alex Christensen.
3815
3816         Adopt to the new constructor for FrameLoadRequest.
3817
3818         * Plugins/PluginView.cpp:
3819         (WebCore::PluginView::start):
3820         (WebCore::PluginView::getURLNotify):
3821         (WebCore::PluginView::getURL):
3822         (WebCore::PluginView::handlePost):
3823
3824 2017-07-03  Brady Eidson  <beidson@apple.com>
3825
3826         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3827         https://bugs.webkit.org/show_bug.cgi?id=174073
3828
3829         Reviewed by Andy Estes.
3830
3831         * WebCoreSupport/WebFrameLoaderClient.cpp:
3832         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3833         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3834         * WebCoreSupport/WebFrameLoaderClient.h:
3835
3836 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3837
3838         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3839         https://bugs.webkit.org/show_bug.cgi?id=174004
3840
3841         Reviewed by Simon Fraser.
3842
3843         * WebCoreSupport/WebFrameLoaderClient.cpp:
3844         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3845
3846 2017-06-30  Daniel Bates  <dabates@apple.com>
3847
3848         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3849         https://bugs.webkit.org/show_bug.cgi?id=165160
3850         <rdar://problem/29451999>
3851
3852         Reviewed by Brady Eidson.
3853
3854         Pass the document that is requesting the load to the loader.
3855
3856         * Plugins/PluginView.cpp:
3857         (WebCore::PluginView::start):
3858         (WebCore::PluginView::getURLNotify):
3859         (WebCore::PluginView::getURL):
3860         (WebCore::PluginView::handlePost):
3861
3862 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3863
3864         Refactor drag start codepaths to plumb a DragItem to client layers
3865         https://bugs.webkit.org/show_bug.cgi?id=173832
3866         Work towards <rdar://problem/32236827>
3867
3868         Reviewed by Ryosuke Niwa and Tim Horton.
3869
3870         Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
3871
3872         * WebCoreSupport/WebDragClient.cpp:
3873         (WebDragClient::startDrag):
3874         * WebCoreSupport/WebDragClient.h:
3875
3876 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3877
3878         Remove excessive headers from JavaScriptCore
3879         https://bugs.webkit.org/show_bug.cgi?id=173812
3880
3881         Reviewed by Darin Adler.
3882
3883         * Plugins/PluginPackage.cpp:
3884
3885 2017-06-22  Daniel Bates  <dabates@apple.com>
3886
3887         Make FrameLoadRequest a move-only type
3888         https://bugs.webkit.org/show_bug.cgi?id=173682
3889
3890         Reviewed by Alex Christensen and Darin Adler.
3891
3892         A FrameLoadRequest groups together the information to perform a load into a single object
3893         that is more manageable to pass around than its constituent parts. Code that receives a
3894         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3895         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3896         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
3897
3898         * Plugins/PluginView.cpp:
3899         (WebCore::PluginView::start):
3900         (WebCore::PluginView::performRequest):
3901         (WebCore::PluginView::load):
3902         (WebCore::PluginView::getURLNotify):
3903         (WebCore::PluginView::getURL):
3904         (WebCore::PluginView::handlePost):
3905         * Plugins/PluginView.h:
3906         (WebCore::PluginRequest::PluginRequest):
3907
3908 2017-06-22  Daniel Bates  <dabates@apple.com>
3909
3910         [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
3911         https://bugs.webkit.org/show_bug.cgi?id=173683
3912
3913         Reviewed by Alex Christensen.
3914
3915         Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
3916         header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
3917         by including PluginView.h. The latter does not make use of the functionality
3918         provided by FrameLoadRequest.h.
3919
3920         * Plugins/PluginViewWin.cpp:
3921         * WebCoreSupport/WebContextMenuClient.cpp:
3922
3923 2017-06-21  Daniel Bates  <dabates@apple.com>
3924
3925         Cleanup FrameLoadRequest
3926         https://bugs.webkit.org/show_bug.cgi?id=173564
3927         <rdar://problem/32903570>
3928
3929         Reviewed by Brent Fulgham.
3930
3931         * Plugins/PluginView.cpp:
3932         (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
3933         we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
3934         we do not have one. Use C++11 brace initialization syntax.
3935         (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
3936         name as we do not have one. Use C++11 brace initialization syntax.
3937         (WebCore::PluginView::getURL): Ditto.
3938         (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
3939         function to closer to where it is actually used. Explicitly pass the null-string for the target
3940         frame name as we do not have one. Use C++11 brace initialization syntax.
3941
3942 2017-06-20  Daniel Bates  <dabates@apple.com>
3943
3944         Have FrameLoadRequest takes a Frame& instead of a Frame*
3945         https://bugs.webkit.org/show_bug.cgi?id=173614
3946         <rdar://problem/32884890>
3947
3948         Reviewed by Brent Fulgham.
3949
3950         * Plugins/PluginView.cpp:
3951         (WebCore::PluginView::performRequest):
3952         * WebFrame.cpp:
3953         (WebFrame::loadRequest):
3954
3955 2017-06-19  Chris Dumez  <cdumez@apple.com>
3956
3957         Use WTF::Function instead of std::function in more places in WebCore/
3958         https://bugs.webkit.org/show_bug.cgi?id=173535
3959
3960         Reviewed by Antti Koivisto.
3961
3962         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
3963
3964         * WebCoreSupport/WebFrameLoaderClient.cpp:
3965         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3966         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3967         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3968         (WebFrameLoaderClient::dispatchWillSubmitForm):
3969         (WebFrameLoaderClient::setUpPolicyListener):
3970         (WebFrameLoaderClient::receivedPolicyDecision):
3971         * WebCoreSupport/WebFrameLoaderClient.h:
3972
3973 2017-05-14 Frederic Wang  <fwang@igalia.com>
3974
3975         Add heuristic to avoid flattening "fullscreen" iframes
3976         https://bugs.webkit.org/show_bug.cgi?id=171914
3977
3978         Reviewed by Simon Fraser.
3979
3980         This commit ajusts the window port to internally use the new preference type for frame flattening.
3981         However, the "partial frame flattening" value is not exposed yet.
3982
3983         * WebView.cpp:
3984         (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
3985
3986 2017-06-17  Chris Dumez  <cdumez@apple.com>
3987
3988         Use WTF::Function instead of std::function in WebKit2/
3989         https://bugs.webkit.org/show_bug.cgi?id=173504
3990
3991         Reviewed by Darin Adler.
3992
3993         Use WTF::Function instead of std::function in WebKit2/ to avoid
3994         unnecessary copying.
3995
3996         * Plugins/PluginStream.cpp:
3997         (WebCore::PluginStream::willSendRequest):
3998         * Plugins/PluginStream.h:
3999
4000 2017-06-16  Sam Weinig  <sam@webkit.org>
4001
4002         [WebIDL] Remove custom bindings for HTMLDocument
4003         https://bugs.webkit.org/show_bug.cgi?id=173444
4004
4005         Reviewed by Darin Adler.
4006
4007         * DOMHTMLClasses.cpp:
4008         (DOMHTMLDocument::write):
4009         (DOMHTMLDocument::writeln):
4010         Update for new signature of write/writeln.
4011
4012 2017-06-16  Daniel Bates  <dabates@apple.com>
4013
4014         Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
4015         instead of URL { ParsedURLString, ... }
4016         https://bugs.webkit.org/show_bug.cgi?id=173495
4017         <rdar://problem/32827445>
4018
4019         Reviewed by Alex Christensen.
4020
4021         URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
4022         Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
4023         Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
4024         would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
4025         parse an arbitrary string that looks like a URL.
4026
4027         Also modernize the code using C++14 idioms.
4028
4029         * WebCoreSupport/WebContextMenuClient.cpp:
4030         (WebContextMenuClient::searchWithGoogle):
4031
4032 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
4033
4034         [Win] WebKit shouldn't include the forwarding header of WebKit itself
4035         https://bugs.webkit.org/show_bug.cgi?id=173352
4036
4037         Reviewed by Alex Christensen.
4038
4039         * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
4040
4041 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
4042
4043         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
4044         https://bugs.webkit.org/show_bug.cgi?id=173318
4045
4046         Reviewed by Darin Adler.
4047
4048         The logical frame size is currently calculated by scaling the frame size in pixels,
4049         and rounding the coordinates to the nearest integers. The computed logical frame
4050         size will in some cases be smaller than the scaled frame size in pixels, since it is
4051         represented as an IntSize. In these cases, the bottom line will not be painted.
4052         Instead of calculating the logical frame size by rounding the scaled frame in
4053         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
4054
4055         * WebCoreSupport/WebFrameLoaderClient.cpp:
4056         (WebFrameLoaderClient::transitionToCommittedForNewPage):
4057
4058 2017-06-13  Daniel Bates  <dabates@apple.com>
4059
4060         Implement W3C Secure Contexts Draft Specification
4061         https://bugs.webkit.org/show_bug.cgi?id=158121
4062         <rdar://problem/26012994>
4063
4064         Reviewed by Brent Fulgham.
4065
4066         Part 4
4067
4068         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
4069
4070         * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
4071         * WebPreferenceKeysPrivate.h:
4072         * WebPreferences.cpp:
4073         (WebPreferences::initializeDefaultSettings):
4074         (WebPreferences::QueryInterface):
4075         (WebPreferences::setIsSecureContextAttributeEnabled):
4076         (WebPreferences::isSecureContextAttributeEnabled):
4077         * WebPreferences.h:
4078         * WebView.cpp:
4079         (WebView::notifyPreferencesChanged):
4080
4081 2017-06-13  Per Arne Vollan  <pvollan@apple.com>
4082
4083         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
4084         https://bugs.webkit.org/show_bug.cgi?id=173318
4085
4086         Reviewed by Alex Christensen.
4087
4088         The logical frame size is currently calculated by scaling the frame size in pixels,
4089         and rounding the coordinates to the nearest integers. The computed logical frame
4090         size will in some cases be smaller than the scaled frame size in pixels, since it is
4091         represented as an IntSize. In these cases, the bottom line will not be painted.
4092         Instead of calculating the logical frame size by rounding the scaled frame in
4093         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
4094  
4095         * WebView.cpp:
4096         (WebView::sizeChanged):
4097
4098 2017-06-13  Sam Weinig  <sam@webkit.org>
4099
4100         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
4101         https://bugs.webkit.org/show_bug.cgi?id=80733
4102
4103         Reviewed by Chris Dumez.
4104
4105         * WebFrame.cpp:
4106         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
4107
4108 2017-06-12  Daewoong Jang  <daewoong.jang@navercorp.com>
4109
4110         Remove WebCore::unloadModule and related data types
4111         https://bugs.webkit.org/show_bug.cgi?id=173231
4112
4113         Reviewed by Darin Adler.
4114
4115         * Plugins/PlatformModule.h: Added.
4116         (WebCore::PlatformModuleVersion::PlatformModuleVersion):
4117         * Plugins/PluginPackage.cpp:
4118         (WebCore::PluginPackage::freeLibraryTimerFired):
4119         * Plugins/PluginPackage.h:
4120
4121 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
4122
4123         [iOS DnD] Add a hook to perform two-step drops in editable content
4124         https://bugs.webkit.org/show_bug.cgi?id=172992
4125         <rdar://problem/32590174>
4126
4127         Reviewed by Tim Horton.
4128
4129         Add a stub implementation for performTwoStepDrop on Windows.
4130
4131         * WebCoreSupport/WebEditorClient.h:
4132
4133 2017-06-04  Konstantin Tokarev  <annulen@yandex.ru>
4134
4135         Fix build of Windows-specific code with ICU 59.1
4136         https://bugs.webkit.org/show_bug.cgi?id=172729
4137
4138         Reviewed by Darin Adler.
4139
4140         Fix conversions from WTF::String to wchar_t* and vice versa.
4141
4142         * Plugins/PluginDatabaseWin.cpp:
4143         (WebCore::addPluginPathsFromRegistry):
4144         (WebCore::PluginDatabase::getPluginPathsInDirectories):
4145         (WebCore::addMozillaPluginDirectories):
4146         (WebCore::addWindowsMediaPlayerPluginDirectory):
4147         (WebCore::addAdobeAcrobatPluginDirectory):
4148         (WebCore::addJavaPluginDirectory):
4149         (WebCore::safariPluginsDirectory):