Unreviewed attempt to fix the Windows build after r237112.
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
2
3         Unreviewed attempt to fix the Windows build after r237112.
4
5         * Plugins/PluginView.cpp:
6         (WebCore::PluginView::performRequest):
7
8 2018-10-16  Alex Christensen  <achristensen@webkit.org>
9
10         Replace HistoryItem* with HistoryItem& where possible
11         https://bugs.webkit.org/show_bug.cgi?id=190617
12
13         Reviewed by Chris Dumez.
14
15         * BackForwardList.cpp:
16         (BackForwardList::goToItem):
17         * BackForwardList.h:
18         * WebBackForwardList.cpp:
19         (WebBackForwardList::goToItem):
20
21 2018-10-15  Alex Christensen  <achristensen@webkit.org>
22
23         Fix Windows build.
24
25         * WebView.cpp:
26         (WebView::loadBackForwardListFromOtherView):
27
28 2018-10-15  Alex Christensen  <achristensen@webkit.org>
29
30         Fix WinCairo build.
31
32         * WebView.cpp:
33         (WebView::backForwardList):
34
35 2018-10-15  Alex Christensen  <achristensen@webkit.org>
36
37         Modernize BackForwardClient.h
38         https://bugs.webkit.org/show_bug.cgi?id=190610
39
40         Reviewed by Chris Dumez.
41
42         * BackForwardList.cpp:
43         (BackForwardList::backListCount const):
44         (BackForwardList::forwardListCount const):
45         (BackForwardList::backListCount): Deleted.
46         (BackForwardList::forwardListCount): Deleted.
47         * BackForwardList.h:
48         * WebView.cpp:
49         (WebView::initWithFrame):
50         (WebView::backForwardList):
51
52 2018-10-15  Alex Christensen  <achristensen@webkit.org>
53
54         Remove unused WebView._globalHistoryItem
55         https://bugs.webkit.org/show_bug.cgi?id=190601
56
57         Reviewed by Chris Dumez.
58
59         * WebCoreSupport/WebFrameLoaderClient.cpp:
60         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
61         * WebCoreSupport/WebFrameLoaderClient.h:
62         * WebView.cpp:
63         (WebView::globalHistoryItem):
64         (WebView::setGlobalHistoryItem): Deleted.
65         * WebView.h:
66
67 2018-10-15  Alex Christensen  <achristensen@webkit.org>
68
69         Remove unused parameters from FrameLoaderClient::createFrame
70         https://bugs.webkit.org/show_bug.cgi?id=190587
71
72         Reviewed by Chris Dumez.
73
74         * WebCoreSupport/WebFrameLoaderClient.cpp:
75         (WebFrameLoaderClient::createFrame):
76         * WebCoreSupport/WebFrameLoaderClient.h:
77
78 2018-10-15  Chris Dumez  <cdumez@apple.com>
79
80         Unreviewed Windows build fix after r237112.
81
82         * Plugins/PluginView.cpp:
83         (WebCore::PluginView::performRequest):
84         (WebCore::PluginView::load):
85
86 2018-10-15  Alex Christensen  <achristensen@webkit.org>
87
88         Remove InjectedBundle processing of back/forward lists
89         https://bugs.webkit.org/show_bug.cgi?id=190459
90
91         Reviewed by Chris Dumez.
92
93         * WebCoreSupport/WebFrameLoaderClient.cpp:
94         (WebFrameLoaderClient::shouldGoToHistoryItem const):
95         * WebCoreSupport/WebFrameLoaderClient.h:
96
97 2018-10-02  Alex Christensen  <achristensen@webkit.org>
98
99         Remove ParsedURLString
100         https://bugs.webkit.org/show_bug.cgi?id=190154
101
102         Reviewed by Chris Dumez.
103
104         * WebDownloadCurl.cpp:
105         (WebDownload::initWithRequest):
106         * WebURLResponse.cpp:
107         (WebURLResponse::createInstance):
108
109 2018-09-28  Chris Dumez  <cdumez@apple.com>
110
111         Drop support for cross-origin-window-policy header
112         https://bugs.webkit.org/show_bug.cgi?id=190081
113
114         Reviewed by Ryosuke Niwa.
115
116         * WebPreferenceKeysPrivate.h:
117         * WebPreferences.cpp:
118         (WebPreferences::initializeDefaultSettings):
119         (WebPreferences::crossOriginWindowPolicySupportEnabled):
120         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
121         * WebView.cpp:
122         (WebView::notifyPreferencesChanged):
123
124 2018-09-27  Antoine Quint  <graouts@apple.com>
125
126         [Web Animations] Turn Web Animations with CSS integration on
127         https://bugs.webkit.org/show_bug.cgi?id=184819
128         <rdar://problem/39597337>
129
130         Reviewed by Dean Jackson.
131
132         * WebPreferences.cpp:
133         (WebPreferences::initializeDefaultSettings):
134
135 2018-09-21  Alex Christensen  <achristensen@webkit.org>
136
137         Use a Variant for FormDataElement
138         https://bugs.webkit.org/show_bug.cgi?id=189777
139
140         Reviewed by Chris Dumez.
141
142         * WebMutableURLRequest.cpp:
143         (WebMutableURLRequest::setHTTPBody):
144
145 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
146
147         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
148         https://bugs.webkit.org/show_bug.cgi?id=189612
149
150         Reviewed by Alex Christensen.
151
152         Non-trivial types can't be used as aruguments of LOG_ERROR and
153         ASSERT_WITH_MESSAGE.
154
155         * DefaultPolicyDelegate.cpp:
156         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
157         static_cast<BSTR> to convert BString.
158         * WebLocalizableStrings.cpp:
159         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
160         char* by using 'key.utf8().data()'.
161
162 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
163
164         Unreviewed, rolling out r235953.
165
166         Caused layout test crashes under GuardMalloc.
167
168         Reverted changeset:
169
170         "Make GraphicsLayers ref-counted, so their tree can persist
171         when disconnected from RenderLayerBackings"
172         https://bugs.webkit.org/show_bug.cgi?id=189521
173         https://trac.webkit.org/changeset/235953
174
175 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
176
177         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
178         https://bugs.webkit.org/show_bug.cgi?id=189538
179
180         Reviewed by Per Arne Vollan.
181
182         * WebPreferences.cpp:
183         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
184         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
185         Apply static_cast to the result of OR-ed CFPropertyListFormat.
186         (WebPreferences::screenFontSubstitutionEnabled):
187         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
188
189 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
190
191         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
192         https://bugs.webkit.org/show_bug.cgi?id=189539
193
194         Reviewed by Alex Christensen.
195
196         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
197         * WebCoreSupport/WebInspectorClient.cpp:
198         (WebInspectorWndProc): Ditto.
199         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
200         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
201
202 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
203
204         Refactor WebCore::EditAction to be an 8-bit enum class
205         https://bugs.webkit.org/show_bug.cgi?id=189383
206
207         Reviewed by Dan Bernstein.
208
209         * WebCoreSupport/WebEditorClient.cpp:
210         (undoNameForEditAction):
211
212 2018-09-04  Frederic Wang  <fwang@igalia.com>
213
214         Add basic support for ScrollIntoViewOptions
215         https://bugs.webkit.org/show_bug.cgi?id=189258
216
217         Reviewed by Simon Fraser.
218
219         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
220         can build despite the new scrollIntoView function.
221
222 2018-08-31  Chris Dumez  <cdumez@apple.com>
223
224         Unreviewed Windows build fix after r235562.
225
226         * WebCoreSupport/WebFrameLoaderClient.cpp:
227         (WebFrameLoaderClient::dispatchWillSubmitForm):
228
229 2018-08-31  Chris Dumez  <cdumez@apple.com>
230
231         Assertion hit in ~CompletionHandler() from ~WebFrame()
232         https://bugs.webkit.org/show_bug.cgi?id=189199
233         <rdar://problem/42657233>
234
235         Reviewed by Youenn Fablet.
236
237         * WebCoreSupport/WebFrameLoaderClient.cpp:
238         (WebFrameLoaderClient::dispatchWillSubmitForm):
239         * WebCoreSupport/WebFrameLoaderClient.h:
240
241 2018-08-31  Frederic Wang  <fwang@igalia.com>
242
243         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
244         https://bugs.webkit.org/show_bug.cgi?id=182053
245
246         Reviewed by Simon Fraser.
247
248         Add developer flag to use standard behavior for scrolling* attributes.
249
250         * Interfaces/IWebPreferencesPrivate.idl:
251         * WebPreferenceKeysPrivate.h:
252         * WebPreferences.cpp:
253         (WebPreferences::initializeDefaultSettings):
254         (WebPreferences::CSSOMViewScrollingAPIEnabled):
255         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
256         * WebPreferences.h:
257         * WebView.cpp:
258         (WebView::notifyPreferencesChanged):
259
260 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
261
262         [CMake] Replace AVFoundationSupport.py using CMake
263         https://bugs.webkit.org/show_bug.cgi?id=182891
264
265         Reviewed by Per Arne Vollan.
266
267         Remove references to the config.h contained in WebCore as it should
268         not be accessible from outside of WebCore.
269
270         * WebKitPrefix.h:
271
272 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
273
274         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
275         https://bugs.webkit.org/show_bug.cgi?id=188496
276         <rdar://problem/43216836>
277
278         Reviewed by Tim Horton.
279
280         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
281         header directly.
282
283         * WebCoreSupport/WebDragClient.cpp:
284
285 2018-08-17  Alex Christensen  <achristensen@webkit.org>
286
287         Add some plumbing for safe browsing
288         https://bugs.webkit.org/show_bug.cgi?id=188709
289
290         Reviewed by Tim Horton.
291
292         * WebCoreSupport/WebFrameLoaderClient.cpp:
293         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
294         * WebCoreSupport/WebFrameLoaderClient.h:
295
296 2018-08-02  David Fenton  <david_fenton@apple.com>
297
298         Unreviewed, rolling out r234489.
299
300         Caused 50+ crashes and 60+ API failures on iOS
301
302         Reverted changeset:
303
304         "[WTF] Rename String::format to String::deprecatedFormat"
305         https://bugs.webkit.org/show_bug.cgi?id=188191
306         https://trac.webkit.org/changeset/234489
307
308 2018-08-01  Tomas Popela  <tpopela@redhat.com>
309
310         [WTF] Rename String::format to String::deprecatedFormat
311         https://bugs.webkit.org/show_bug.cgi?id=188191
312
313         Reviewed by Darin Adler.
314
315         It should be replaced with string concatenation.
316
317         * FullscreenVideoController.cpp:
318         (timeToString):
319         * WebView.cpp:
320         (webKitVersionString):
321
322 2018-07-30  Rob Buis  <rbuis@igalia.com>
323
324         https://bugs.webkit.org/show_bug.cgi?id=188137
325         Merge PlatformCookieJar functions into NetworkStorageSession
326
327         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
328
329         Reviewed by Alex Christensen.
330
331         * WebCoreSupport/WebPlatformStrategies.cpp:
332         (WebPlatformStrategies::cookiesForDOM):
333         (WebPlatformStrategies::setCookiesFromDOM):
334         (WebPlatformStrategies::cookiesEnabled):
335         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
336         (WebPlatformStrategies::getRawCookies):
337         (WebPlatformStrategies::deleteCookie):
338         * WebPreferences.cpp:
339         (WebPreferences::clearNetworkLoaderSession):
340
341 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
342
343         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
344         https://bugs.webkit.org/show_bug.cgi?id=187963
345
346         Reviewed by Alex Christensen.
347
348         * Plugins/PluginPackageWin.cpp:
349         (WebCore::PluginPackage::fetchInfo):
350         Update split/splitAllowingEmptyEntries usage.
351
352 2018-07-18  Antoine Quint  <graouts@apple.com>
353
354         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
355         https://bugs.webkit.org/show_bug.cgi?id=187722
356
357         Reviewed by Myles Maxfield.
358
359         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
360
361         * DOMCoreClasses.cpp:
362         (DOMElement::font):
363
364 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
365
366         Disable cross-origin-window-policy by default
367         https://bugs.webkit.org/show_bug.cgi?id=187509
368
369         Reviewed by Chris Dumez.
370
371         * WebPreferences.cpp:
372         (WebPreferences::initializeDefaultSettings):
373
374 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
375
376         [WTF] Add user-defined literal for ASCIILiteral
377         https://bugs.webkit.org/show_bug.cgi?id=186839
378
379         Reviewed by Darin Adler.
380
381         * Plugins/PluginStream.cpp:
382         (WebCore::PluginStream::startStream):
383         * WebCoreSupport/WebContextMenuClient.cpp:
384         (WebContextMenuClient::searchWithGoogle):
385
386 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
387
388         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
389         https://bugs.webkit.org/show_bug.cgi?id=186623
390
391         Reviewed by Youenn Fablet.
392
393         * WebCoreSupport/WebPluginInfoProvider.cpp:
394         (WebPluginInfoProvider::pluginInfo):
395         (WebPluginInfoProvider::webVisiblePluginInfo):
396         * WebCoreSupport/WebPluginInfoProvider.h:
397
398 2018-06-13  Chris Dumez  <cdumez@apple.com>
399
400         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
401         https://bugs.webkit.org/show_bug.cgi?id=186545
402
403         Reviewed by Brady Eidson.
404
405         Update client delegate now that parameter type has changed.
406
407         * WebCoreSupport/WebFrameLoaderClient.cpp:
408         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
409         * WebCoreSupport/WebFrameLoaderClient.h:
410
411 2018-06-11  Chris Dumez  <cdumez@apple.com>
412
413         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
414         https://bugs.webkit.org/show_bug.cgi?id=186441
415
416         Reviewed by Brady Eidson.
417
418         Rename existing flag to something a bit more generic, now that it is used for
419         more things than bypassing the navigation policy check.
420
421         * WebView.cpp:
422         (WebView::goToBackForwardItem):
423         (WebView::loadBackForwardListFromOtherView):
424
425 2018-06-04  Chris Dumez  <cdumez@apple.com>
426
427         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
428         https://bugs.webkit.org/show_bug.cgi?id=186287
429         <rdar://problem/40783352>
430
431         Reviewed by Youenn Fablet.
432
433         * Interfaces/IWebPreferencesPrivate.idl:
434         * WebPreferenceKeysPrivate.h:
435         * WebPreferences.cpp:
436         (WebPreferences::initializeDefaultSettings):
437         (WebPreferences::crossOriginWindowPolicySupportEnabled):
438         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
439         * WebPreferences.h:
440         * WebView.cpp:
441         (WebView::notifyPreferencesChanged):
442
443 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
444
445         [JSC] Pass VM& parameter as much as possible
446         https://bugs.webkit.org/show_bug.cgi?id=186085
447
448         Reviewed by Saam Barati.
449
450         * Plugins/PluginPackage.cpp:
451         (WebCore::NPN_Invoke):
452
453 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
454
455         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
456         https://bugs.webkit.org/show_bug.cgi?id=186125
457
458         Unreviewed build fix
459
460         * WebActionPropertyBag.cpp:
461         (WebActionPropertyBag::Read):
462         (findMouseEvent): Deleted.
463
464 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
465
466         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
467         https://bugs.webkit.org/show_bug.cgi?id=186027
468
469         Unreviewed build fix
470
471         * WebMutableURLRequest.cpp:
472         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
473         (WebMutableURLRequest::setClientCertificate):
474
475 2018-05-25  Chris Dumez  <cdumez@apple.com>
476
477         Minor ApplicationCacheStorage clean up
478         https://bugs.webkit.org/show_bug.cgi?id=185984
479
480         Reviewed by Youenn Fablet.
481
482         * WebApplicationCache.cpp:
483         (WebApplicationCache::originsWithCache):
484
485 2018-05-24  Chris Dumez  <cdumez@apple.com>
486
487         Reduce copying of FontCascadeDescription objects by moving them around
488         https://bugs.webkit.org/show_bug.cgi?id=185963
489
490         Reviewed by Simon Fraser.
491
492         Reduce copying of FontCascadeDescription objects by moving them around when possible.
493
494         * FullscreenVideoController.cpp:
495         (FullscreenVideoController::draw):
496
497 2018-05-15  Antoine Quint  <graouts@apple.com>
498
499         [Web Animations] Expose Web Animations CSS integration as an experimental feature
500         https://bugs.webkit.org/show_bug.cgi?id=185647
501
502         Reviewed by Dean Jackson.
503
504         Rename the Web Animations CSS integration flag.
505
506         * Interfaces/IWebPreferencesPrivate.idl:
507         * WebPreferenceKeysPrivate.h:
508         * WebPreferences.cpp:
509         (WebPreferences::initializeDefaultSettings):
510         (WebPreferences::webAnimationsCSSIntegrationEnabled):
511         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
512         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
513         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
514         * WebPreferences.h:
515         * WebView.cpp:
516         (WebView::notifyPreferencesChanged):
517
518 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
519
520         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
521         https://bugs.webkit.org/show_bug.cgi?id=185505
522
523         Unreviewed serious crash fix
524
525         Windows port crashes soon since Bug 184996.
526
527         * WebPreferences.cpp:
528         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
529         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
530
531 2018-05-07  Daniel Bates  <dabates@apple.com>
532
533         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
534         https://bugs.webkit.org/show_bug.cgi?id=185170
535
536         Reviewed by Per Arne Vollan.
537
538         * WebCache.cpp:
539         (WebCache::empty):
540
541 2018-04-27  Chris Dumez  <cdumez@apple.com>
542
543         Use WindowProxy instead of DOMWindow in our IDL
544         https://bugs.webkit.org/show_bug.cgi?id=185022
545
546         Reviewed by Sam Weinig.
547
548         * DOMCoreClasses.cpp:
549         (DOMDocument::getComputedStyle):
550
551 2018-04-23  Daniel Bates  <dabates@apple.com>
552
553         Implement Same-Site cookies
554         https://bugs.webkit.org/show_bug.cgi?id=159464
555         <rdar://problem/27196358>
556
557         Reviewed by Brent Fulgham.
558
559         Pass the Same-Site info through the strategy.
560
561         * WebCoreSupport/WebPlatformStrategies.cpp:
562         (WebPlatformStrategies::cookiesForDOM):
563         (WebPlatformStrategies::setCookiesFromDOM):
564         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
565         (WebPlatformStrategies::getRawCookies):
566         * WebCoreSupport/WebPlatformStrategies.h:
567
568 2018-04-23  Daniel Bates  <dabates@apple.com>
569
570         Implement Same-Site cookies
571         https://bugs.webkit.org/show_bug.cgi?id=159464
572         <rdar://problem/27196358>
573
574         Reviewed by Brent Fulgham.
575
576         Pass the Same-Site info through the strategy.
577
578         * WebCoreSupport/WebPlatformStrategies.cpp:
579         (WebPlatformStrategies::cookiesForDOM):
580         (WebPlatformStrategies::setCookiesFromDOM):
581         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
582         (WebPlatformStrategies::getRawCookies):
583         * WebCoreSupport/WebPlatformStrategies.h:
584
585 2018-04-20  Youenn Fablet  <youenn@apple.com>
586
587         Make PluginData cache its web visible plugins
588         https://bugs.webkit.org/show_bug.cgi?id=184421
589
590         Reviewed by Chris Dumez.
591
592         * WebCoreSupport/WebPluginInfoProvider.cpp:
593         (WebPluginInfoProvider::pluginInfo):
594         (WebPluginInfoProvider::webVisiblePluginInfo):
595         * WebCoreSupport/WebPluginInfoProvider.h:
596
597 2018-04-19  Chris Dumez  <cdumez@apple.com>
598
599         Rename JSDOMWindowProxy to JSWindowProxy
600         https://bugs.webkit.org/show_bug.cgi?id=184797
601
602         Reviewed by Sam Weinig.
603
604         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
605
606         * WebFrame.cpp:
607         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
608
609 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
610
611         Unreviewed rollout of r230632. Regression in memory usage.
612
613         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
614
615         * WebPreferences.cpp:
616         (WebPreferences::initializeDefaultSettings):
617
618 2018-04-17  Chris Dumez  <cdumez@apple.com>
619
620         Unreviewed attempt to fix the Windows build after r230721
621
622         * WebCoreSupport/WebFrameLoaderClient.cpp:
623         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
624
625 2018-04-17  Chris Dumez  <cdumez@apple.com>
626
627         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
628         https://bugs.webkit.org/show_bug.cgi?id=184678
629         <rdar://problem/39422122>
630
631         Reviewed by Alex Christensen.
632
633         Add new parameter to dispatchDecidePolicyForNavigationAction.
634
635         * WebCoreSupport/WebFrameLoaderClient.cpp:
636         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
637         * WebCoreSupport/WebFrameLoaderClient.h:
638
639 2018-04-12  Antoine Quint  <graouts@apple.com>
640
641         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
642         https://bugs.webkit.org/show_bug.cgi?id=184569
643         <rdar://problem/38671301>
644
645         Reviewed by Jon Lee.
646
647         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
648
649         * WebPreferences.cpp:
650
651 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
652
653         [WTF] Remove StaticLock
654         https://bugs.webkit.org/show_bug.cgi?id=184332
655
656         Reviewed by Mark Lam.
657
658         * WebKitQuartzCoreAdditions/CAView.cpp:
659         (WKQCA::CAView::releaseAllD3DResources):
660         * WebLocalizableStrings.cpp:
661
662 2018-04-03  Chris Dumez  <cdumez@apple.com>
663
664         Drop MainFrame class
665         https://bugs.webkit.org/show_bug.cgi?id=184191
666
667         Reviewed by Darin Adler.
668
669         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
670         relationship between the Page and the MainFrame.
671
672         This is ground work for introducing LocalFrame / RemoteFrame concepts.
673
674         * WebCoreSupport/AcceleratedCompositingContext.cpp:
675         * WebCoreSupport/WebContextMenuClient.cpp:
676         * WebCoreSupport/WebDragClient.cpp:
677         * WebDropSource.cpp:
678         * WebFrame.cpp:
679         * WebView.cpp:
680
681 2018-03-26  Chris Dumez  <cdumez@apple.com>
682
683         Use SecurityOriginData more consistently in Service Worker code
684         https://bugs.webkit.org/show_bug.cgi?id=183969
685
686         Reviewed by Darin Adler.
687
688         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
689
690         * WebDatabaseManager.cpp:
691         (WebDatabaseManager::databasesWithOrigin):
692         (WebDatabaseManager::deleteOrigin):
693         (WebDatabaseManager::deleteDatabase):
694         (WebDatabaseManager::setQuota):
695         * WebSecurityOrigin.cpp:
696         (WebSecurityOrigin::usage):
697         (WebSecurityOrigin::quota):
698         (WebSecurityOrigin::setQuota):
699
700 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
701
702         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
703         https://bugs.webkit.org/show_bug.cgi?id=183911
704         <rdar://problem/38762306>
705
706         Reviewed by Youenn Fablet.
707
708         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
709
710         * WebView.cpp:
711         (WebView::WebView):
712
713 2018-03-25  Commit Queue  <commit-queue@webkit.org>
714
715         Unreviewed, rolling out r229954.
716         https://bugs.webkit.org/show_bug.cgi?id=184000
717
718         Caused many layout tests to crash on Apple High Sierra,
719         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
720         by dydz on #webkit).
721
722         Reverted changeset:
723
724         "Use SecurityOriginData more consistently in Service Worker
725         code"
726         https://bugs.webkit.org/show_bug.cgi?id=183969
727         https://trac.webkit.org/changeset/229954
728
729 2018-03-24  Chris Dumez  <cdumez@apple.com>
730
731         Use SecurityOriginData more consistently in Service Worker code
732         https://bugs.webkit.org/show_bug.cgi?id=183969
733
734         Reviewed by Darin Adler.
735
736         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
737
738         * WebDatabaseManager.cpp:
739         (WebDatabaseManager::databasesWithOrigin):
740         (WebDatabaseManager::deleteOrigin):
741         (WebDatabaseManager::deleteDatabase):
742         (WebDatabaseManager::setQuota):
743         * WebSecurityOrigin.cpp:
744         (WebSecurityOrigin::usage):
745         (WebSecurityOrigin::quota):
746         (WebSecurityOrigin::setQuota):
747
748 2018-03-23  Chris Dumez  <cdumez@apple.com>
749
750         Unreviewed attempt to fix Windows build after r229926.
751
752         * WebView.cpp:
753
754 2018-03-23  Brady Eidson  <beidson@apple.com>
755
756         Go to back/forward list items after a process-swapped navigation.
757         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
758
759         Reviewed by Andy Estes.
760
761         * WebView.cpp:
762         (WebView::goToBackForwardItem):
763         (WebView::loadBackForwardListFromOtherView):
764
765 2018-03-23  Miguel Gomez  <magomez@igalia.com>
766
767         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
768         https://bugs.webkit.org/show_bug.cgi?id=183892
769
770         Remove the UpdateContentsFlag parameter as it's not used anymore.
771
772         Reviewed by Žan Doberšek.
773
774         * WebCoreSupport/AcceleratedCompositingContext.cpp:
775         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
776
777 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
778
779         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
780         https://bugs.webkit.org/show_bug.cgi?id=183335
781
782         Reviewed by Alex Christensen.
783
784         * Plugins/PluginDatabaseWin.cpp:
785         * Plugins/PluginMessageThrottlerWin.cpp:
786         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
787         * Plugins/PluginPackageWin.cpp:
788         (WebCore::PluginPackage::load):
789         * Plugins/PluginView.h:
790         * Plugins/PluginViewWin.cpp:
791         * Plugins/npapi.cpp:
792         * WebCoreSupport/WebFrameLoaderClient.cpp:
793         (WebFrameLoaderClient::createPlugin):
794         (WebFrameLoaderClient::createJavaAppletWidget):
795         * WebView.cpp:
796         (WebView::WebViewWndProc):
797
798 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
799
800         [Win] Layout Test fast/html/menuitem-element.html is failing.
801         https://bugs.webkit.org/show_bug.cgi?id=179299
802
803         Reviewed by Per Arne Vollan.
804
805         * Interfaces/IWebPreferencesPrivate.idl:
806         * WebPreferenceKeysPrivate.h:
807         * WebPreferences.cpp:
808         (WebPreferences::menuItemElementEnabled):
809         (WebPreferences::setMenuItemElementEnabled):
810         * WebPreferences.h:
811         * WebView.cpp:
812         (WebView::notifyPreferencesChanged):
813         Add private web preference "menuItemElementEnabled".
814
815 2018-03-12  Antoine Quint  <graouts@apple.com>
816
817         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
818         https://bugs.webkit.org/show_bug.cgi?id=183504
819         <rdar://problem/38372965>
820
821         Reviewed by Dean Jackson and Jon Lee.
822
823         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
824         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
825
826         * Interfaces/IWebPreferencesPrivate.idl:
827         * WebPreferences.cpp:
828         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
829         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
830         * WebPreferenceKeysPrivate.h
831         * WebPreferences.h:
832         * WebView.cpp:
833         (WebView::notifyPreferencesChanged):
834
835 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
836
837         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
838         https://bugs.webkit.org/show_bug.cgi?id=183429
839
840         Reviewed by Mark Lam.
841
842         * WebFrame.cpp:
843         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
844
845 2018-03-08  Tim Horton  <timothy_horton@apple.com>
846
847         Stop linking ApplicationServices directly
848         https://bugs.webkit.org/show_bug.cgi?id=182867
849         <rdar://problem/38252142>
850
851         Reviewed by Alex Christensen.
852
853         The frameworks that we use that live inside ApplicationServices
854         have mostly moved out, so import them directly.
855
856         * FullscreenVideoController.cpp:
857
858 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
859
860         Fix std::make_unique / new[] using system malloc
861         https://bugs.webkit.org/show_bug.cgi?id=182975
862
863         Reviewed by JF Bastien.
864
865         Use Vector instead.
866
867         * MarshallingHelpers.cpp:
868         (MarshallingHelpers::safeArrayToStringArray):
869         (MarshallingHelpers::safeArrayToIntArray):
870         * Plugins/PluginPackageWin.cpp:
871         (WebCore::PluginPackage::fetchInfo):
872         * WebPreferences.cpp:
873         (WebPreferences::copyWebKitPreferencesToCFPreferences):
874         * WebView.cpp:
875         (WebView::onMenuCommand):
876
877 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
878
879         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
880         https://bugs.webkit.org/show_bug.cgi?id=183312
881
882         Reviewed by Mark Lam.
883
884         Remove wtf/CurrentTime.h include pragma.
885
886         * WebDownload.cpp:
887         * WebDownloadCFNet.cpp:
888         * WebDropSource.cpp:
889
890 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
891
892         Remove monotonicallyIncreasingTime
893         https://bugs.webkit.org/show_bug.cgi?id=182911
894
895         Reviewed by Michael Catanzaro.
896
897         * FullscreenVideoController.cpp:
898         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
899         * Plugins/PluginMessageThrottlerWin.cpp:
900         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
901         (WebCore::PluginMessageThrottlerWin::appendMessage):
902         * Plugins/PluginMessageThrottlerWin.h:
903         * WebView.cpp:
904         (WebView::notifyAnimationStarted):
905         * WebView.h:
906
907 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
908
909         [Win][DRT] Implement setSpatialNavigationEnabled.
910         https://bugs.webkit.org/show_bug.cgi?id=183166
911
912         Reviewed by Per Arne Vollan.
913
914         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
915
916         * Interfaces/IWebPreferencesPrivate.idl:
917         * WebPreferenceKeysPrivate.h:
918         * WebPreferences.cpp:
919         (WebPreferences::initializeDefaultSettings):
920         (WebPreferences::spatialNavigationEnabled):
921         (WebPreferences::setSpatialNavigationEnabled):
922         * WebPreferences.h:
923         * WebView.cpp:
924         (WebView::notifyPreferencesChanged):
925
926 2018-02-28  Alex Christensen  <achristensen@webkit.org>
927
928         Reduce use of NetworkingContext in WebKit
929         https://bugs.webkit.org/show_bug.cgi?id=183213
930
931         Reviewed by Brady Eidson.
932
933         * Plugins/PluginView.cpp:
934         (WebCore::PluginView::getValueForURL):
935
936 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
937
938         Fix WebCore includes within WebKitLegacy
939         https://bugs.webkit.org/show_bug.cgi?id=183147
940
941         Reviewed by Tim Horton.
942
943         * Plugins/PluginDatabase.cpp:
944         * Plugins/PluginDatabaseWin.cpp:
945         * Plugins/PluginDebug.cpp:
946         * Plugins/PluginDebug.h:
947         * Plugins/PluginMainThreadScheduler.cpp:
948         * Plugins/PluginMessageThrottlerWin.cpp:
949         * Plugins/PluginMessageThrottlerWin.h:
950         * Plugins/PluginPackage.cpp:
951         * Plugins/PluginPackage.h:
952         * Plugins/PluginPackageWin.cpp:
953         * Plugins/PluginStream.cpp:
954         * Plugins/PluginStream.h:
955         * Plugins/PluginView.cpp:
956         * Plugins/PluginView.h:
957         * Plugins/PluginViewWin.cpp:
958         * Plugins/npapi.cpp:
959         * WebCoreSupport/WebChromeClient.cpp:
960         * WebCoreSupport/WebContextMenuClient.cpp:
961         * WebCoreSupport/WebFrameLoaderClient.cpp:
962         * WebCoreSupport/WebInspectorClient.cpp:
963         * WebCoreSupport/WebPlatformStrategies.cpp:
964         * WebFrame.cpp:
965         * WebKitMessageLoop.cpp:
966         * WebView.cpp:
967         * storage/WebDatabaseProvider.cpp:
968
969 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
970
971         Remove currentTime() / currentTimeMS()
972         https://bugs.webkit.org/show_bug.cgi?id=183052
973
974         Reviewed by Mark Lam.
975
976         * WebCoreSupport/WebFrameLoaderClient.cpp:
977         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
978         * WebCoreSupport/WebFrameLoaderClient.h:
979         * WebDownload.h:
980         * WebDownloadCFNet.cpp:
981         (WebDownload::didStart):
982         (WebDownload::didReceiveData):
983         (WebDownload::didFinish):
984
985 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
986
987         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
988         https://bugs.webkit.org/show_bug.cgi?id=182883
989
990         Reviewed by Per Arne Vollan.
991
992         * WebKitPrefix.h:
993
994 2018-02-16  Dean Jackson  <dino@apple.com>
995
996         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
997         https://bugs.webkit.org/show_bug.cgi?id=182894
998
999         Reviewed by Tim Horton.
1000
1001         Rename OPENGL_ES_2 to OPENGL_ES.
1002
1003         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1004
1005 2018-02-16  Youenn Fablet  <youenn@apple.com>
1006
1007         Allow specifying which plug-ins are supported
1008         https://bugs.webkit.org/show_bug.cgi?id=182748
1009
1010         Reviewed by Chris Dumez.
1011
1012         * WebCoreSupport/WebPluginInfoProvider.cpp:
1013         (WebPluginInfoProvider::getPluginInfo):
1014         * WebCoreSupport/WebPluginInfoProvider.h:
1015
1016 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
1017
1018         WebCore headers should not be included relatively within dependent projects
1019         https://bugs.webkit.org/show_bug.cgi?id=182805
1020
1021         Reviewed by Chris Dumez.
1022
1023         * FullscreenVideoController.h:
1024
1025 2018-02-13  Commit Queue  <commit-queue@webkit.org>
1026
1027         Unreviewed, rolling out r228431.
1028         https://bugs.webkit.org/show_bug.cgi?id=182766
1029
1030         Regressed CMake build stability (Requested by dolmstead on
1031         #webkit).
1032
1033         Reverted changeset:
1034
1035         "[CMake] Make WebCore headers copies"
1036         https://bugs.webkit.org/show_bug.cgi?id=182512
1037         https://trac.webkit.org/changeset/228431
1038
1039 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
1040
1041         [CMake] Make WebCore headers copies
1042         https://bugs.webkit.org/show_bug.cgi?id=182512
1043
1044         Reviewed by Keith Miller.
1045
1046         * FullscreenVideoController.h:
1047         * Plugins/PluginDatabase.cpp:
1048         * Plugins/PluginDatabaseWin.cpp:
1049         * Plugins/PluginDebug.cpp:
1050         * Plugins/PluginMainThreadScheduler.cpp:
1051         * Plugins/PluginMessageThrottlerWin.cpp:
1052         * Plugins/PluginPackage.cpp:
1053         * Plugins/PluginPackageWin.cpp:
1054         * Plugins/PluginStream.cpp:
1055         * Plugins/PluginView.cpp:
1056         * Plugins/PluginViewWin.cpp:
1057         * Plugins/npapi.cpp:
1058         * WebKitMessageLoop.cpp:
1059         * WebKitPrefix.h:
1060         * storage/WebDatabaseProvider.cpp:
1061
1062 2018-01-13  Darin Adler  <darin@apple.com>
1063
1064         Event improvements
1065         https://bugs.webkit.org/show_bug.cgi?id=179591
1066
1067         Reviewed by Chris Dumez.
1068
1069         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
1070         * WebFrame.cpp: Ditto.
1071
1072         * WebScriptWorld.cpp:
1073         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
1074
1075         * WebView.cpp: Removed include of ScriptValue.h.
1076         (WebView::handleEditingKeyboardEvent): Updated for name change from
1077         keyEvent to underlyingPlatformEvent.
1078
1079 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1080
1081         Remove WebCore/ForwardingHeaders directory
1082         https://bugs.webkit.org/show_bug.cgi?id=182347
1083
1084         Reviewed by Keith Miller.
1085
1086         * Plugins/PluginView.cpp:
1087         * Plugins/PluginViewWin.cpp:
1088         * WebCoreSupport/WebInspectorClient.cpp:
1089         * WebCoreSupport/WebInspectorClient.h:
1090         * WebFrame.cpp:
1091         * WebJavaScriptCollector.cpp:
1092         * WebView.cpp:
1093
1094 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1095
1096         Unreviewed, another attempt to fix the Windows build after r227479.
1097
1098         * WebFrame.cpp:
1099         (WebFrame::elementWithName):
1100
1101 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1102
1103         Unreviewed, try to fix the Windows build after r227479.
1104
1105         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
1106
1107         * WebFrame.cpp:
1108         (WebFrame::elementWithName):
1109         (WebFrame::controlsInForm):
1110
1111 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
1112
1113         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
1114         https://bugs.webkit.org/show_bug.cgi?id=181859
1115         <rdar://problem/36659886>
1116
1117         Reviewed by Alex Christensen.
1118         
1119         Use local include patch.
1120
1121         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
1122         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
1123         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
1124
1125 2018-01-17  Youenn Fablet  <youenn@apple.com>
1126
1127         Put fetch Request.keepalive behind a runtime flag
1128         https://bugs.webkit.org/show_bug.cgi?id=181592
1129
1130         Reviewed by Chris Dumez.
1131
1132         * WebPreferences.cpp:
1133         (WebPreferences::fetchAPIKeepAliveEnabled):
1134         (WebPreferences::setFetchAPIKeepAliveEnabled):
1135         * WebPreferences.h:
1136         * WebView.cpp:
1137         (WebView::notifyPreferencesChanged):
1138
1139 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1140
1141         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1142         https://bugs.webkit.org/show_bug.cgi?id=181637
1143         <rdar://problem/36508471>
1144
1145         Reviewed by Tim Horton.
1146
1147         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1148
1149         * WebCoreSupport/WebEditorClient.cpp:
1150         (WebEditorClient::replacementURLForResource):
1151         * WebCoreSupport/WebEditorClient.h:
1152
1153 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1154
1155         Remove std::chrono completely
1156         https://bugs.webkit.org/show_bug.cgi?id=181186
1157
1158         Reviewed by Alex Christensen.
1159
1160         * Plugins/PluginStream.cpp:
1161         (WebCore::lastModifiedDateMS):
1162
1163 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1164
1165         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
1166         https://bugs.webkit.org/show_bug.cgi?id=181173
1167
1168         Reviewed by Alex Christensen.
1169
1170         * WebNodeHighlight.cpp:
1171         (WebNodeHighlight::update): Scale the GraphicsContext.
1172
1173 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1174
1175         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
1176         https://bugs.webkit.org/show_bug.cgi?id=181160
1177
1178         Reviewed by Myles C. Maxfield.
1179
1180         * Plugins/PluginView.cpp:
1181         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
1182
1183 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1184
1185         Enable picture-in-picture from inline element on suspend.
1186         https://bugs.webkit.org/show_bug.cgi?id=180942
1187         rdar://problem/34745234
1188
1189         Reviewed by Jer Noble.
1190
1191         Update signature of enterVideoFullscreenForVideoElement.
1192
1193         * WebCoreSupport/WebChromeClient.cpp:
1194         (WebChromeClient::enterVideoFullscreenForVideoElement):
1195         * WebCoreSupport/WebChromeClient.h:
1196
1197 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1198
1199         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
1200         https://bugs.webkit.org/show_bug.cgi?id=180926
1201
1202         Reviewed by Tim Horton.
1203
1204         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
1205         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
1206
1207         * WebCoreSupport/WebFrameLoaderClient.cpp:
1208         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
1209         (WebFrameLoaderClient::pageID const): Ditto.
1210
1211 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1212
1213         Remove unnecessary boolean result of start() functions
1214         https://bugs.webkit.org/show_bug.cgi?id=180856
1215
1216         Reviewed by Darin Adler.
1217
1218         It always returns true.
1219
1220         * WebDownloadCurl.cpp:
1221         (WebDownload::start):
1222
1223 2017-12-14  John Wilander  <wilander@apple.com>
1224
1225         Storage Access API: Implement frame-specific access in the document.cookie layer
1226         https://bugs.webkit.org/show_bug.cgi?id=180682
1227         <rdar://problem/35982257>
1228
1229         Reviewed by Alex Christensen.
1230
1231         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1232         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1233         CookiesStrategy::getRawCookies() now take optional parameters for
1234         frameID and pageID to allow frame-specific scoping of cookies.
1235
1236         This change makes the return values of FrameLoaderClient::frameID()
1237         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1238         WebCore can call those getters and get the right return values in
1239         WebKit and std:nullopt in WebKitLegacy.
1240
1241         * WebCoreSupport/WebFrameLoaderClient.cpp:
1242         (WebFrameLoaderClient::pageID const):
1243         (WebFrameLoaderClient::frameID const):
1244             Now return an optional.
1245         * WebCoreSupport/WebFrameLoaderClient.h:
1246         * WebCoreSupport/WebPlatformStrategies.cpp:
1247         (WebPlatformStrategies::cookiesForDOM):
1248         (WebPlatformStrategies::setCookiesFromDOM):
1249         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1250         (WebPlatformStrategies::getRawCookies):
1251         * WebCoreSupport/WebPlatformStrategies.h:
1252
1253 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1254
1255         [WTF] Thread::create should have Thread::tryCreate
1256         https://bugs.webkit.org/show_bug.cgi?id=180333
1257
1258         Reviewed by Darin Adler.
1259
1260         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
1261         (WKQCA::CVDisplayLink::start):
1262
1263 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1264
1265         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
1266         https://bugs.webkit.org/show_bug.cgi?id=180572
1267
1268         Reviewed by Mark Lam.
1269
1270         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
1271         Also we use Lock instead of Mutex.
1272
1273         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
1274         (WKQCA::CAD3DRenderer::swapChain):
1275         (WKQCA::CAD3DRenderer::renderAndPresent):
1276         (WKQCA::CAD3DRenderer::renderToImage):
1277         (WKQCA::CAD3DRenderer::setDeviceIsLost):
1278         (WKQCA::CAD3DRenderer::renderInternal):
1279         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
1280         * WebKitQuartzCoreAdditions/CAView.cpp:
1281         (WKQCA::CAView::Handle::create):
1282         Return Ref<Handle> instead of RefPtr<>.
1283
1284         (WKQCA::CAView::Handle::lock):
1285         (WKQCA::CAView::Handle::view const):
1286         (WKQCA::CAView::Handle::clear):
1287         (WKQCA::views):
1288         (WKQCA::viewsNeedingUpdate):
1289         (WKQCA::CAView::releaseAllD3DResources):
1290         (WKQCA::CAView::CAView):
1291         (WKQCA::CAView::~CAView):
1292         (WKQCA::CAView::setLayer):
1293         (WKQCA::CAView::update):
1294         (WKQCA::CAView::drawToWindow):
1295         (WKQCA::CAView::drawToWindowInternal):
1296         (WKQCA::CAView::drawToImage):
1297         (WKQCA::CAView::willDraw):
1298         (WKQCA::CAView::drawIntoDC):
1299         (WKQCA::CAView::setShouldInvertColors):
1300         (WKQCA::CAView::scheduleNextDraw):
1301         (WKQCA::CAView::displayLinkReachedCAMediaTime):
1302         (WKQCA::CAView::contextDidChange):
1303         (WKQCA::CAView::updateSoon):
1304         (WKQCA::CAView::updateViewsNow):
1305         (WKQCA::CAView::d3dDevice9):
1306         (WKQCA::CAView::Handle::mutex): Deleted.
1307         (WKQCA::globalStateMutex): Deleted.
1308         (): Deleted.
1309         * WebKitQuartzCoreAdditions/CAView.h:
1310
1311 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1312
1313         Use StaticLock instead of NeverDestroyed<Lock>
1314         https://bugs.webkit.org/show_bug.cgi?id=180507
1315
1316         Reviewed by Saam Barati.
1317
1318         * WebLocalizableStrings.cpp:
1319         (findCachedString):
1320         (cacheString):
1321         (mainBundleLocStrings): Deleted.
1322         (frameworkLocStringsMutex): Deleted.
1323
1324 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
1325
1326         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
1327         https://bugs.webkit.org/show_bug.cgi?id=180431
1328         <rdar://problem/34531264>
1329
1330         Reviewed by Simon Fraser.
1331
1332         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
1333         'override' to make sure this doesn't break in the future.
1334
1335         * WebView.cpp:
1336         (WebView::notifyAnimationStarted):
1337         (WebView::paintContents):
1338         * WebView.h:
1339
1340 2017-11-23  Darin Adler  <darin@apple.com>
1341
1342         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1343         https://bugs.webkit.org/show_bug.cgi?id=179981
1344
1345         Reviewed by Sam Weinig.
1346
1347         * WebView.cpp:
1348         (WebView::searchFor): Use |= instead of | to build FindOptions.
1349         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
1350         (WebView::findString): Create FindOptions with |=; the old code just passed a
1351         WebKit FindOptions through without converting to WebCore::FindOptions.
1352
1353 2017-11-23  Darin Adler  <darin@apple.com>
1354
1355         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1356         https://bugs.webkit.org/show_bug.cgi?id=179907
1357
1358         Reviewed by Sam Weinig.
1359
1360         * Plugins/PluginDatabaseWin.cpp:
1361         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
1362         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
1363         * WebDownloadCFNet.cpp:
1364         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
1365
1366         * WebView.cpp:
1367         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
1368         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
1369         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
1370         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
1371         the code does not cause any change in behavior.
1372
1373 2017-11-22  Ali Juma  <ajuma@chromium.org>
1374
1375         Implement VisualViewport API attributes
1376         https://bugs.webkit.org/show_bug.cgi?id=179385
1377
1378         Reviewed by Frédéric Wang.
1379
1380         Add a VisualViewportAPI preference.
1381
1382         * Interfaces/IWebPreferencesPrivate.idl:
1383         * WebPreferenceKeysPrivate.h:
1384         * WebPreferences.cpp:
1385         (WebPreferences::initializeDefaultSettings):
1386         (WebPreferences::visualViewportAPIEnabled):
1387         (WebPreferences::setVisualViewportAPIEnabled):
1388         * WebPreferences.h:
1389         * WebView.cpp:
1390         (WebView::notifyPreferencesChanged):
1391
1392 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1393
1394         Unreviewed, rolling out r225093.
1395         https://bugs.webkit.org/show_bug.cgi?id=179938
1396
1397         Compilation failed on WinCairo 64-bit Release (Requested by
1398         fredw on #webkit).
1399
1400         Reverted changeset:
1401
1402         "Implement VisualViewport API attributes"
1403         https://bugs.webkit.org/show_bug.cgi?id=179385
1404         https://trac.webkit.org/changeset/225093
1405
1406 2017-11-21  Ali Juma  <ajuma@chromium.org>
1407
1408         Implement VisualViewport API attributes
1409         https://bugs.webkit.org/show_bug.cgi?id=179385
1410
1411         Reviewed by Frédéric Wang.
1412
1413         Add a VisualViewportAPI preference.
1414
1415         * Interfaces/IWebPreferencesPrivate.idl:
1416         * WebPreferenceKeysPrivate.h:
1417         * WebPreferences.cpp:
1418         (WebPreferences::initializeDefaultSettings):
1419         (WebPreferences::visualViewportAPIEnabled):
1420         (WebPreferences::setVisualViewportAPIEnabled):
1421         * WebPreferences.h:
1422         * WebView.cpp:
1423         (WebView::notifyPreferencesChanged):
1424
1425 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1426
1427         Clean up old URL parser remnants
1428         https://bugs.webkit.org/show_bug.cgi?id=179573
1429
1430         Reviewed by Darin Adler.
1431
1432         * WebCoreSupport/WebContextMenuClient.cpp:
1433         (WebContextMenuClient::searchWithGoogle):
1434         Use https if we do end up searching with google.
1435
1436 2017-11-12  Darin Adler  <darin@apple.com>
1437
1438         More is<> and downcast<>, less static_cast<>
1439         https://bugs.webkit.org/show_bug.cgi?id=179600
1440
1441         Reviewed by Chris Dumez.
1442
1443         * WebView.cpp:
1444         (WebView::handleEditingKeyboardEvent): Use downcast.
1445
1446 2017-11-09  Christopher Reid  <chris.reid@sony.com>
1447
1448         Use enum classes within FileSystem
1449         https://bugs.webkit.org/show_bug.cgi?id=175172
1450
1451         Reviewed by Darin Adler.
1452
1453         * Plugins/PluginDatabase.cpp:
1454
1455 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
1456
1457         [Win] Add WebKitQuartzCoreAdditions library.
1458         https://bugs.webkit.org/show_bug.cgi?id=179331
1459
1460         Reviewed by Alex Christensen.
1461
1462         * WebKitQuartzCoreAdditions: Added.
1463         * WebKitQuartzCoreAdditions/API: Added.
1464         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
1465         (toImage):
1466         (WKCACFImageGetWidth):
1467         (WKCACFImageGetHeight):
1468         (WKCACFImageCopyFileMapping):
1469         (WKCACFImageCreateWithImage):
1470         (WKCACFImageFinalize):
1471         (WKCACFImageCopyFormattingDescription):
1472         (WKCACFImageCopyDebugDescription):
1473         (WKCACFImageGetTypeID):
1474         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
1475         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
1476         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
1477         (toView):
1478         (toImpl):
1479         (WKCACFViewCreate):
1480         (WKCACFViewSetLayer):
1481         (WKCACFViewUpdate):
1482         (WKCACFViewFlushContext):
1483         (WKCACFViewInvalidateRects):
1484         (WKCACFViewCanDraw):
1485         (WKCACFViewDraw):
1486         (WKCACFViewCopyDrawnImage):
1487         (WKCACFViewDrawIntoDC):
1488         (contextDidChangeCallback):
1489         (WKCACFViewSetContextDidChangeCallback):
1490         (WKCACFViewGetLastCommitTime):
1491         (WKCACFViewSetContextUserData):
1492         (WKCACFViewGetContext):
1493         (WKCACFViewFinalize):
1494         (WKCACFViewCopyFormattingDescription):
1495         (WKCACFViewCopyDebugDescription):
1496         (WKCACFViewGetTypeID):
1497         (WKCACFViewSetShouldInvertColors):
1498         (WKCACFViewGetD3DDevice9):
1499         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
1500         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
1501         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
1502         (WKQCA::dllInstance):
1503         (DllMain):
1504         (WKCACFShutDown):
1505         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
1506         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
1507         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
1508         (WKQCA::d3d):
1509         (WKQCA::initialPresentationParameters):
1510         (WKQCA::CAD3DRenderer::shared):
1511         (WKQCA::CAD3DRenderer::CAD3DRenderer):
1512         (WKQCA::CAD3DRenderer::swapChain):
1513         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
1514         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
1515         (WKQCA::CAD3DRenderer::initialize):
1516         (WKQCA::D3DMatrixOrthoOffCenterRH):
1517         (WKQCA::prepareDevice):
1518         (WKQCA::updateBounds):
1519         (WKQCA::CAD3DRenderer::renderAndPresent):
1520         (WKQCA::CAD3DRenderer::renderToImage):
1521         (WKQCA::CAD3DRenderer::setDeviceIsLost):
1522         (WKQCA::CAD3DRenderer::renderInternal):
1523         (WKQCA::CAD3DRenderer::postProcess):
1524         (WKQCA::CAD3DRenderer::resetD3DDevice):
1525         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
1526         (WKQCA::CAD3DRenderer::release):
1527         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
1528         (WKQCA::D3DPostProcessingContext::sceneTexture const):
1529         (WKQCA::D3DPostProcessingContext::overlayQuad const):
1530         (WKQCA::CAD3DRenderer::d3dDevice9 const):
1531         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
1532         (WKQCA::CAView::Handle::create):
1533         (WKQCA::CAView::Handle::~Handle):
1534         (WKQCA::CAView::Handle::mutex):
1535         (WKQCA::CAView::Handle::view const):
1536         (WKQCA::CAView::Handle::clear):
1537         (WKQCA::CAView::Handle::Handle):
1538         (WKQCA::globalStateMutex):
1539         (WKQCA::registerMessageWindowClass):
1540         (WKQCA::createMessageWindow):
1541         (WKQCA::CAView::releaseAllD3DResources):
1542         (WKQCA::CAView::CAView):
1543         (WKQCA::CAView::~CAView):
1544         (WKQCA::CAView::create):
1545         (WKQCA::CAView::setContextDidChangeCallback):
1546         (WKQCA::CAView::setLayer):
1547         (WKQCA::CAView::update):
1548         (WKQCA::CAView::invalidateRects):
1549         (WKQCA::CAView::drawToWindow):
1550         (WKQCA::CAView::drawToWindowInternal):
1551         (WKQCA::CAView::drawToImage):
1552         (WKQCA::CAView::willDraw):
1553         (WKQCA::CAView::didDraw):
1554         (WKQCA::CAView::drawIntoDC):
1555         (WKQCA::CAView::setShouldInvertColors):
1556         (WKQCA::CAView::scheduleNextDraw):
1557         (WKQCA::CAView::displayLinkReachedCAMediaTime):
1558         (WKQCA::CAView::contextDidChangeCallback):
1559         (WKQCA::CAView::contextDidChange):
1560         (WKQCA::CAView::updateSoon):
1561         (WKQCA::CAView::updateViewsNow):
1562         (WKQCA::CAView::d3dDevice9):
1563         * WebKitQuartzCoreAdditions/CAView.h: Added.
1564         (WKQCA::CAView::context const):
1565         (WKQCA::CAView::canDraw const):
1566         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
1567         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
1568         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
1569         (WKQCA::CVDisplayLink::CVDisplayLink):
1570         (WKQCA::CVDisplayLink::~CVDisplayLink):
1571         (WKQCA::CVDisplayLink::create):
1572         (WKQCA::CVDisplayLink::start):
1573         (WKQCA::CVDisplayLink::stop):
1574         (WKQCA::CVDisplayLink::setPaused):
1575         (WKQCA::CVDisplayLink::runIOThread):
1576         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
1577         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
1578         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
1579         * WebKitQuartzCoreAdditions/Image.cpp: Added.
1580         (WKQCA::numBytesForSize):
1581         (WKQCA::Image::create):
1582         (WKQCA::Image::Image):
1583         (WKQCA::Image::~Image):
1584         (WKQCA::bitmapInfo):
1585         (WKQCA::Image::createDIB const):
1586         (WKQCA::Image::copyFileMapping):
1587         * WebKitQuartzCoreAdditions/Image.h: Added.
1588         (WKQCA::Image::size const):
1589         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
1590         (WKQCA::getBackBufferRectAsRenderTarget):
1591         (WKQCA::getSystemMemoryCopy):
1592         (WKQCA::copyRectToBitmap):
1593         (WKQCA::getImageCopy):
1594         (WKQCA::getBackBufferRectAsImage):
1595         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
1596         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
1597         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
1598         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
1599         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
1600
1601 2017-11-06  Christopher Reid  <chris.reid@sony.com>
1602
1603         Use enum classes within FileSystem
1604         https://bugs.webkit.org/show_bug.cgi?id=175172
1605
1606         Reviewed by Myles C. Maxfield.
1607
1608         * Plugins/PluginDatabase.cpp:
1609
1610 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
1611
1612         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
1613         https://bugs.webkit.org/show_bug.cgi?id=178333
1614
1615         Reviewed by Darin Adler.
1616
1617         * WebCoreSupport/WebFrameLoaderClient.cpp:
1618         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
1619
1620 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1621
1622         Use CompletionHandlers for redirects
1623         https://bugs.webkit.org/show_bug.cgi?id=179163
1624
1625         Reviewed by Tim Horton.
1626
1627         * Plugins/PluginStream.cpp:
1628         (WebCore::PluginStream::willSendRequest):
1629         * Plugins/PluginStream.h:
1630         (WebCore::PluginStreamClient::~PluginStreamClient):
1631         (WebCore::PluginStreamClient::streamDidFinishLoading):
1632         (WebCore::PluginStream::create):
1633         (WebCore::PluginStream::setLoadManually):
1634
1635 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1636
1637         Add a FileSystem namespace to FileSystem.cpp
1638         https://bugs.webkit.org/show_bug.cgi?id=179063
1639
1640         Reviewed by Darin Adler.
1641
1642         * Plugins/PluginDatabase.cpp:
1643         * Plugins/PluginPackage.cpp:
1644         * Plugins/PluginStream.cpp:
1645         * Plugins/PluginStream.h:
1646         * WebApplicationCache.cpp:
1647         * WebDatabaseManager.cpp:
1648         * WebDownloadCurl.cpp:
1649         * WebPreferences.cpp:
1650         * WebView.cpp:
1651
1652 2017-10-31  Alex Christensen  <achristensen@webkit.org>
1653
1654         Fix Windows build after r224260
1655
1656         * WebView.cpp:
1657         (WebView::gesture):
1658
1659 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1660
1661         [FrameView::layout cleanup] Move core layout logic to a separate class.
1662         https://bugs.webkit.org/show_bug.cgi?id=178771
1663         <rdar://problem/35166542>
1664
1665         Reviewed by Simon Fraser.
1666
1667         Move layout code out from FrameView to LayoutContext.
1668
1669         * WebFrame.cpp:
1670         (WebFrame::layout):
1671
1672 2017-10-26  Alex Christensen  <achristensen@webkit.org>
1673
1674         Fix Windows build
1675         https://bugs.webkit.org/show_bug.cgi?id=178892
1676
1677         * AccessibleBase.cpp:
1678         (MSAARole):
1679
1680 2017-10-26  Alex Christensen  <achristensen@webkit.org>
1681
1682         Fix Windows build
1683         https://bugs.webkit.org/show_bug.cgi?id=178892
1684
1685         * AccessibleBase.cpp:
1686         (AccessibleBase::state const):
1687         (MSAARole):
1688
1689 2017-10-25  Youenn Fablet  <youenn@apple.com>
1690
1691         Enable ServiceWorker to fetch resources
1692         https://bugs.webkit.org/show_bug.cgi?id=178673
1693
1694         Reviewed by Brady Eidson.
1695
1696         Added implementation to the new getters.
1697         They are noop in the context of WK1.
1698
1699         * WebCoreSupport/WebFrameLoaderClient.cpp:
1700         (WebFrameLoaderClient::pageID const):
1701         (WebFrameLoaderClient::frameID const):
1702         (WebFrameLoaderClient::sessionID const):
1703         * WebCoreSupport/WebFrameLoaderClient.h:
1704
1705 2017-10-20  Antoine Quint  <graouts@apple.com>
1706
1707         [Web Animations] Provide basic timeline and animation interfaces
1708         https://bugs.webkit.org/show_bug.cgi?id=178526
1709
1710         Reviewed by Dean Jackson.
1711
1712         Remove the WEB_ANIMATIONS compile-time flag.
1713
1714         * WebView.cpp:
1715         (WebView::notifyPreferencesChanged):
1716
1717 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1718
1719         [Curl] Clean up old style code in old curl files.
1720         https://bugs.webkit.org/show_bug.cgi?id=178569
1721
1722         Reviewed by Ryosuke Niwa.
1723
1724         * WebCache.cpp:
1725         (WebCache::cacheFolder):
1726         (WebCache::setCacheFolder):
1727         * WebView.cpp:
1728         (WebView::setCacheModel):
1729
1730 2017-10-19  Sam Weinig  <sam@webkit.org>
1731
1732         [Settings] Move global settings into their own file
1733         https://bugs.webkit.org/show_bug.cgi?id=178512
1734
1735         Reviewed by Darin Adler.
1736
1737         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1738
1739         * WebView.cpp:
1740         (WebView::initWithFrame):
1741
1742 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1743
1744         Replace some stack raw pointers with RefPtrs within WebCore/html
1745         https://bugs.webkit.org/show_bug.cgi?id=178201
1746         <rdar://problem/34841692>
1747
1748         Reviewed by Ryosuke Niwa.
1749
1750         * WebView.cpp:
1751         (WebView::handleEditingKeyboardEvent):
1752         Change the type of node as toNode() is changed to return RefPtr.
1753
1754 2017-10-16  Sam Weinig  <sam@webkit.org>
1755
1756         [Settings] Remove all custom code from Settings.h/cpp
1757         https://bugs.webkit.org/show_bug.cgi?id=178330
1758
1759         Reviewed by Simon Fraser.
1760
1761         * WebView.cpp:
1762         (WebView::notifyPreferencesChanged):
1763             
1764             Update for naming changes of FrameFlattening now that it is an enum class.
1765
1766 2017-10-11  Chris Dumez  <cdumez@apple.com>
1767
1768         Modernize Geolocation code
1769         https://bugs.webkit.org/show_bug.cgi?id=178148
1770
1771         Reviewed by Ryosuke Niwa.
1772
1773         * WebCoreSupport/WebGeolocationClient.cpp:
1774         (WebGeolocationClient::lastPosition):
1775         * WebCoreSupport/WebGeolocationClient.h:
1776         * WebGeolocationPosition.cpp:
1777         (WebGeolocationPosition::initWithTimestamp):
1778         (core):
1779         * WebGeolocationPosition.h:
1780         (WebGeolocationPosition::impl const):
1781
1782 2017-10-05  Chris Dumez  <cdumez@apple.com>
1783
1784         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1785         https://bugs.webkit.org/show_bug.cgi?id=177957
1786
1787         Reviewed by Alex Christensen.
1788
1789         * WebCoreSupport/WebPlatformStrategies.cpp:
1790         (WebPlatformStrategies::cookiesEnabled):
1791         * WebCoreSupport/WebPlatformStrategies.h:
1792
1793 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1794
1795         [Curl] Reimplement CurlDownload with CurlRequest
1796         https://bugs.webkit.org/show_bug.cgi?id=177779
1797
1798         Reviewed by Alex Christensen.
1799
1800         * WebDownload.h:
1801         * WebDownloadCurl.cpp:
1802         (WebDownload::init):
1803         (WebDownload::didReceiveResponse):
1804
1805 2017-09-29  Chris Dumez  <cdumez@apple.com>
1806
1807         Split some logic out of VisitedLinkStore and make it reusable
1808         https://bugs.webkit.org/show_bug.cgi?id=177575
1809
1810         Reviewed by Alex Christensen.
1811
1812         * WebCoreSupport/WebVisitedLinkStore.cpp:
1813         (WebVisitedLinkStore::addVisitedLink):
1814         (WebVisitedLinkStore::isLinkVisited):
1815         (WebVisitedLinkStore::addVisitedLinkHash):
1816         * WebCoreSupport/WebVisitedLinkStore.h:
1817
1818 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1819
1820         Make PolicyAction an encodable enum class
1821         https://bugs.webkit.org/show_bug.cgi?id=177480
1822
1823         Reviewed by Antti Koivisto.
1824
1825         * WebCoreSupport/WebFrameLoaderClient.cpp:
1826         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1827         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1828         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1829         * WebFramePolicyListener.cpp:
1830         (WebFramePolicyListener::use):
1831         (WebFramePolicyListener::download):
1832         (WebFramePolicyListener::ignore):
1833         (WebFramePolicyListener::continueSubmit):
1834
1835 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
1836
1837         [Win] fast/canvas/2d.getPath.modification.html is failing.
1838         https://bugs.webkit.org/show_bug.cgi?id=176534
1839
1840         Reviewed by Alex Christensen.
1841
1842         We need to enable Inspector additions at runtime in order to expose the getPath function.
1843
1844         * Interfaces/IWebPreferencesPrivate.idl:
1845         * WebPreferenceKeysPrivate.h:
1846         * WebPreferences.cpp:
1847         (WebPreferences::initializeDefaultSettings):
1848         (WebPreferences::setDataTransferItemsEnabled):
1849         (WebPreferences::inspectorAdditionsEnabled):
1850         (WebPreferences::setInspectorAdditionsEnabled):
1851         * WebPreferences.h:
1852         * WebView.cpp:
1853         (WebView::notifyPreferencesChanged):
1854
1855 2017-09-07  Alex Christensen  <achristensen@webkit.org>
1856
1857         Modernize Geolocation code
1858         https://bugs.webkit.org/show_bug.cgi?id=176496
1859
1860         Reviewed by Andy Estes.
1861
1862         * WebCoreSupport/WebGeolocationClient.cpp:
1863         (WebGeolocationClient::requestPermission):
1864         * WebCoreSupport/WebGeolocationClient.h:
1865         (WebGeolocationClient::setEnableHighAccuracy): Deleted.
1866         (WebGeolocationClient::cancelPermissionRequest): Deleted.
1867         * WebGeolocationPolicyListener.h:
1868         * WebView.cpp:
1869         (WebView::initWithFrame):
1870         (WebView::geolocationDidFailWithError):
1871
1872 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
1873
1874         [Win] Enable DatatransferItems in DRT.
1875         https://bugs.webkit.org/show_bug.cgi?id=176424
1876
1877         Reviewed by Brent Fulgham.
1878
1879         * Interfaces/IWebPreferencesPrivate.idl:
1880         * WebPreferenceKeysPrivate.h:
1881         * WebPreferences.cpp:
1882         (WebPreferences::initializeDefaultSettings):
1883         (WebPreferences::QueryInterface):
1884         (WebPreferences::isSecureContextAttributeEnabled):
1885         (WebPreferences::dataTransferItemsEnabled):
1886         (WebPreferences::setDataTransferItemsEnabled):
1887         * WebPreferences.h:
1888         * WebView.cpp:
1889         (WebView::notifyPreferencesChanged):
1890
1891 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
1892
1893         Unreviewed build fix #2 after r221275.
1894
1895         * WebCoreSupport/WebPlatformStrategies.cpp:
1896         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
1897         to match new API.
1898         * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
1899
1900 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
1901
1902         Unreviewed build fix after r221275.
1903
1904         * WebCoreSupport/WebPlatformStrategies.cpp:
1905         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
1906         to match new API.
1907
1908 2017-08-28  Per Arne Vollan  <pvollan@apple.com>
1909
1910         [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
1911         https://bugs.webkit.org/show_bug.cgi?id=176031
1912
1913         Reviewed by Brent Fulgham.
1914
1915         When the function in the FramePolicyFunction parameter is called, it has already been moved
1916         to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
1917         function by using the stored member instead.
1918
1919         * WebCoreSupport/WebFrameLoaderClient.cpp:
1920         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1921         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1922         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1923
1924 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1925
1926         Unreviewed, try to fix the Windows build after r221064
1927
1928         didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
1929
1930         * WebCoreSupport/WebEditorClient.h:
1931
1932 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1933
1934         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
1935         https://bugs.webkit.org/show_bug.cgi?id=175370
1936         <rdar://problem/33799806>
1937
1938         Reviewed by Ryosuke Niwa.
1939
1940         Adjust WebEditorClient for interface changes.
1941
1942         * WebCoreSupport/WebEditorClient.h:
1943
1944 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
1945
1946         Unreviewed build fix after r221017.
1947
1948         Correct copy/paste error.
1949
1950         * WebCoreSupport/WebPlatformStrategies.cpp:
1951         (WebPlatformStrategies::cookiesForDOM):
1952
1953 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
1954
1955         Unreviewed build fix after r221017.
1956
1957         * WebCoreSupport/WebPlatformStrategies.cpp:
1958         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
1959         * WebCoreSupport/WebPlatformStrategies.h:
1960
1961 2017-08-22  Alex Christensen  <achristensen@webkit.org>
1962
1963         Remove ChromeClient::scrollbarsModeDidChange
1964         https://bugs.webkit.org/show_bug.cgi?id=175805
1965
1966         Reviewed by Daniel Bates.
1967
1968         * WebCoreSupport/WebChromeClient.h:
1969
1970 2017-08-22  Alex Christensen  <achristensen@webkit.org>
1971
1972         Remove ChromeClient::hasOpenedPopup
1973         https://bugs.webkit.org/show_bug.cgi?id=175804
1974
1975         Reviewed by Sam Weinig.
1976
1977         * WebCoreSupport/WebChromeClient.cpp:
1978         (WebChromeClient::hasOpenedPopup const): Deleted.
1979         * WebCoreSupport/WebChromeClient.h:
1980
1981 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
1982
1983         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
1984         https://bugs.webkit.org/show_bug.cgi?id=173536
1985
1986         Reviewed by Brent Fulgham.
1987
1988         If the tree state is dirty, accessible objects are deleted while iterating over children
1989         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
1990         style is updated before this method is called.
1991
1992         * AccessibleBase.cpp:
1993         (AccessibleBase::getAccessibilityObjectForChild):
1994
1995 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
1996
1997         [PAL] Move SessionID into PAL
1998         https://bugs.webkit.org/show_bug.cgi?id=174192
1999
2000         Reviewed by Antti Koivisto.
2001
2002         * WebCoreSupport/WebFrameLoaderClient.cpp:
2003         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2004         * WebCoreSupport/WebFrameLoaderClient.h:
2005         * WebCoreSupport/WebFrameNetworkingContext.cpp:
2006         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
2007         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2008         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2009         (WebFrameNetworkingContext::storageSession const):
2010         * WebCoreSupport/WebPlatformStrategies.cpp:
2011         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2012         * WebCoreSupport/WebPlatformStrategies.h:
2013
2014 2017-08-15  Youenn Fablet  <youenn@apple.com>
2015
2016         [Cache API] Adding generic support for CacheStorage and Cache methods
2017         https://bugs.webkit.org/show_bug.cgi?id=175455
2018
2019         Reviewed by Chris Dumez.
2020
2021         * WebView.cpp:
2022         (WebView::initWithFrame):
2023
2024 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2025
2026         Composition underline color is always black
2027         https://bugs.webkit.org/show_bug.cgi?id=174675
2028
2029         Reviewed by Ryosuke Niwa.
2030
2031         * WebView.cpp:
2032         (WebView::setCompositionForTesting): Use text color for
2033         composition underline.
2034
2035 2017-08-09  Daniel Bates  <dabates@apple.com>
2036
2037         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2038         https://bugs.webkit.org/show_bug.cgi?id=175247
2039         <rdar://problem/33679804>
2040
2041         Reviewed by Brady Eidson.
2042
2043         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2044         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2045         clients that need to make use of this information at this time. If such a needs comes up
2046         then we can expose API/SPI similar to what we do for WebKit.
2047
2048         * WebCoreSupport/WebFrameLoaderClient.cpp:
2049         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2050         * WebCoreSupport/WebFrameLoaderClient.h:
2051
2052 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
2053
2054         Async image decoding for large images should be disabled after the first time a tile is painted
2055         https://bugs.webkit.org/show_bug.cgi?id=174451
2056         <rdar://problem/31246421>
2057
2058         Reviewed by Simon Fraser.
2059
2060         * FullscreenVideoController.cpp:
2061         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
2062         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2063         (AcceleratedCompositingContext::paintContents):
2064         * WebCoreSupport/AcceleratedCompositingContext.h:
2065
2066 2017-07-23  Darin Adler  <darin@apple.com>
2067
2068         More NeverDestroyed and related cleanup
2069         https://bugs.webkit.org/show_bug.cgi?id=174745
2070
2071         Reviewed by Alex Christensen.
2072
2073         * Plugins/PluginDatabase.cpp:
2074         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
2075         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
2076         * Plugins/PluginMainThreadScheduler.cpp:
2077         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
2078         * Plugins/PluginMainThreadScheduler.h: Ditto.
2079         * WebCoreSupport/WebPlatformStrategies.cpp:
2080         (WebPlatformStrategies::initialize): Ditto.
2081         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
2082         * WebHistory.cpp:
2083         (sharedHistoryStorage): Ditto.
2084         * WebLocalizableStrings.cpp:
2085         (mainBundleLocStrings): Ditto.
2086         (frameworkLocStringsMutex): Ditto.
2087         (frameworkLocStrings): Ditto.
2088         * WebView.cpp:
2089         (WebView::standardUserAgentWithApplicationName): Ditto.
2090         Also changed to keep one global string with the prefix of the user agent string
2091         instead of keeping two globals with pieces of that prefix.
2092
2093 2017-07-24  Chris Dumez  <cdumez@apple.com>
2094
2095         Make ExceptionCode a proper enumeration
2096         https://bugs.webkit.org/show_bug.cgi?id=174771
2097
2098         Reviewed by Sam Weinig.
2099
2100         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
2101
2102         * DOMCoreClasses.cpp:
2103         (DOMDocument::createEvent):
2104         * WebView.cpp:
2105         (WebView::prepareCandidateWindow):
2106
2107 2017-07-21  Andreas Kling  <akling@apple.com>
2108
2109         Use more references in event dispatch code
2110         https://bugs.webkit.org/show_bug.cgi?id=174681
2111
2112         Reviewed by Geoffrey Garen.
2113
2114         * DOMEventsClasses.cpp:
2115         (WebEventListener::handleEvent):
2116         * DOMEventsClasses.h:
2117         * Plugins/PluginView.cpp:
2118         (WebCore::PluginView::handleEvent):
2119         * Plugins/PluginView.h:
2120
2121 2017-07-20  Brady Eidson  <beidson@apple.com>
2122
2123         Remove WebIconDatabase from WebKitLegacy/win.
2124         https://bugs.webkit.org/show_bug.cgi?id=174608
2125
2126         Reviewed by Alex Christensen.
2127
2128         It is unused.
2129         
2130         * ForEachCoClass.h:
2131
2132         * Interfaces/IWebIconDatabase.idl: Removed.
2133
2134         * Interfaces/WebKit.idl:
2135
2136         * WebCoreStatistics.cpp:
2137         (WebCoreStatistics::iconPageURLMappingCount):
2138         (WebCoreStatistics::iconRetainedPageURLCount):
2139         (WebCoreStatistics::iconRecordCount):
2140         (WebCoreStatistics::iconsWithDataCount):
2141
2142         * WebIconDatabase.cpp: Removed.
2143         * WebIconDatabase.h: Removed.
2144         * WebKitClassFactory.cpp:
2145
2146         * WebKitDLL.cpp:
2147         (shutDownWebKit):
2148
2149         * WebKitLogging.h:
2150
2151         * WebView.cpp:
2152         (WebView::close):
2153         (WebView::notifyDidAddIcon):
2154         (WebView::registerForIconNotification):
2155         (WebView::dispatchDidReceiveIconFromWebFrame):
2156         (WebView::onNotify):
2157
2158 2017-07-18  Matt Lewis  <jlewis3@apple.com>
2159
2160         Unreviewed, rolling out r219610.
2161
2162         This caused an api failure on all platforms for the test
2163         SnapshotImageLargeAsyncDecoding
2164
2165         Reverted changeset:
2166
2167         "Async image decoding for large images should be disabled
2168         after the first time a tile is painted"
2169         https://bugs.webkit.org/show_bug.cgi?id=174451
2170         http://trac.webkit.org/changeset/219610
2171
2172 2017-07-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
2173
2174         Async image decoding for large images should be disabled after the first time a tile is painted
2175         https://bugs.webkit.org/show_bug.cgi?id=174451
2176
2177         Reviewed by Simon Fraser.
2178
2179         * FullscreenVideoController.cpp:
2180         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
2181         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2182         (AcceleratedCompositingContext::paintContents):
2183         * WebCoreSupport/AcceleratedCompositingContext.h:
2184
2185 2017-07-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2186
2187         [Curl] Don't start downloading more than once for same request
2188         https://bugs.webkit.org/show_bug.cgi?id=174172
2189
2190         Reviewed by Alex Christensen.
2191
2192         * WebDownloadCurl.cpp:
2193         (WebDownload::init):
2194
2195 2017-07-12  Daniel Bates  <dabates@apple.com>
2196
2197         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
2198         https://bugs.webkit.org/show_bug.cgi?id=174427
2199
2200         Rubber-stamped by Brady Eidson.
2201
2202         * Plugins/PluginView.cpp:
2203         (WebCore::PluginView::start):
2204         (WebCore::PluginView::getURLNotify):
2205         (WebCore::PluginView::getURL):
2206         (WebCore::PluginView::handlePost):
2207
2208 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2209
2210         [WTF] Move SoftLinking.h into WTF
2211         https://bugs.webkit.org/show_bug.cgi?id=174000
2212
2213         Reviewed by Alex Christensen.
2214
2215         * WebKitClassFactory.cpp:
2216         * WebView.cpp:
2217
2218 2017-07-05  Brady Eidson  <beidson@apple.com>
2219
2220         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
2221         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
2222
2223         Reviewed by Alex Christensen.
2224
2225         Adopt to the new constructor for FrameLoadRequest.
2226
2227         * Plugins/PluginView.cpp:
2228         (WebCore::PluginView::start):
2229         (WebCore::PluginView::getURLNotify):
2230         (WebCore::PluginView::getURL):
2231         (WebCore::PluginView::handlePost):
2232
2233 2017-07-03  Brady Eidson  <beidson@apple.com>
2234
2235         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2236         https://bugs.webkit.org/show_bug.cgi?id=174073
2237
2238         Reviewed by Andy Estes.
2239
2240         * WebCoreSupport/WebFrameLoaderClient.cpp:
2241         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
2242         (WebFrameLoaderClient::registerForIconNotification): Deleted.
2243         * WebCoreSupport/WebFrameLoaderClient.h:
2244
2245 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
2246
2247         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
2248         https://bugs.webkit.org/show_bug.cgi?id=174004
2249
2250         Reviewed by Simon Fraser.
2251
2252         * WebCoreSupport/WebFrameLoaderClient.cpp:
2253         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2254
2255 2017-06-30  Daniel Bates  <dabates@apple.com>
2256
2257         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2258         https://bugs.webkit.org/show_bug.cgi?id=165160
2259         <rdar://problem/29451999>
2260
2261         Reviewed by Brady Eidson.
2262
2263         Pass the document that is requesting the load to the loader.
2264
2265         * Plugins/PluginView.cpp:
2266         (WebCore::PluginView::start):
2267         (WebCore::PluginView::getURLNotify):
2268         (WebCore::PluginView::getURL):
2269         (WebCore::PluginView::handlePost):
2270
2271 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2272
2273         Refactor drag start codepaths to plumb a DragItem to client layers
2274         https://bugs.webkit.org/show_bug.cgi?id=173832
2275         Work towards <rdar://problem/32236827>
2276
2277         Reviewed by Ryosuke Niwa and Tim Horton.
2278
2279         Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
2280
2281         * WebCoreSupport/WebDragClient.cpp:
2282         (WebDragClient::startDrag):
2283         * WebCoreSupport/WebDragClient.h:
2284
2285 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
2286
2287         Remove excessive headers from JavaScriptCore
2288         https://bugs.webkit.org/show_bug.cgi?id=173812
2289
2290         Reviewed by Darin Adler.
2291
2292         * Plugins/PluginPackage.cpp:
2293
2294 2017-06-22  Daniel Bates  <dabates@apple.com>
2295
2296         Make FrameLoadRequest a move-only type
2297         https://bugs.webkit.org/show_bug.cgi?id=173682
2298
2299         Reviewed by Alex Christensen and Darin Adler.
2300
2301         A FrameLoadRequest groups together the information to perform a load into a single object
2302         that is more manageable to pass around than its constituent parts. Code that receives a
2303         FrameLoadRequest is expected to extract out the information it needs to complete its task.
2304         And it does not make sense to re-use the same FrameLoadRequest object for more than one
2305         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
2306
2307         * Plugins/PluginView.cpp:
2308         (WebCore::PluginView::start):
2309         (WebCore::PluginView::performRequest):
2310         (WebCore::PluginView::load):
2311         (WebCore::PluginView::getURLNotify):
2312         (WebCore::PluginView::getURL):
2313         (WebCore::PluginView::handlePost):
2314         * Plugins/PluginView.h:
2315         (WebCore::PluginRequest::PluginRequest):
2316
2317 2017-06-22  Daniel Bates  <dabates@apple.com>
2318
2319         [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
2320         https://bugs.webkit.org/show_bug.cgi?id=173683
2321
2322         Reviewed by Alex Christensen.
2323
2324         Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
2325         header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
2326         by including PluginView.h. The latter does not make use of the functionality
2327         provided by FrameLoadRequest.h.
2328
2329         * Plugins/PluginViewWin.cpp:
2330         * WebCoreSupport/WebContextMenuClient.cpp:
2331
2332 2017-06-21  Daniel Bates  <dabates@apple.com>
2333
2334         Cleanup FrameLoadRequest
2335         https://bugs.webkit.org/show_bug.cgi?id=173564
2336         <rdar://problem/32903570>
2337
2338         Reviewed by Brent Fulgham.
2339
2340         * Plugins/PluginView.cpp:
2341         (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
2342         we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
2343         we do not have one. Use C++11 brace initialization syntax.
2344         (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
2345         name as we do not have one. Use C++11 brace initialization syntax.
2346         (WebCore::PluginView::getURL): Ditto.
2347         (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
2348         function to closer to where it is actually used. Explicitly pass the null-string for the target
2349         frame name as we do not have one. Use C++11 brace initialization syntax.
2350
2351 2017-06-20  Daniel Bates  <dabates@apple.com>
2352
2353         Have FrameLoadRequest takes a Frame& instead of a Frame*
2354         https://bugs.webkit.org/show_bug.cgi?id=173614
2355         <rdar://problem/32884890>
2356
2357         Reviewed by Brent Fulgham.
2358
2359         * Plugins/PluginView.cpp:
2360         (WebCore::PluginView::performRequest):
2361         * WebFrame.cpp:
2362         (WebFrame::loadRequest):
2363
2364 2017-06-19  Chris Dumez  <cdumez@apple.com>
2365
2366         Use WTF::Function instead of std::function in more places in WebCore/
2367         https://bugs.webkit.org/show_bug.cgi?id=173535
2368
2369         Reviewed by Antti Koivisto.
2370
2371         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
2372
2373         * WebCoreSupport/WebFrameLoaderClient.cpp:
2374         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2375         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2376         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2377         (WebFrameLoaderClient::dispatchWillSubmitForm):
2378         (WebFrameLoaderClient::setUpPolicyListener):
2379         (WebFrameLoaderClient::receivedPolicyDecision):
2380         * WebCoreSupport/WebFrameLoaderClient.h:
2381
2382 2017-05-14 Frederic Wang  <fwang@igalia.com>
2383
2384         Add heuristic to avoid flattening "fullscreen" iframes
2385         https://bugs.webkit.org/show_bug.cgi?id=171914
2386
2387         Reviewed by Simon Fraser.
2388
2389         This commit ajusts the window port to internally use the new preference type for frame flattening.
2390         However, the "partial frame flattening" value is not exposed yet.
2391
2392         * WebView.cpp:
2393         (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
2394
2395 2017-06-17  Chris Dumez  <cdumez@apple.com>
2396
2397         Use WTF::Function instead of std::function in WebKit2/
2398         https://bugs.webkit.org/show_bug.cgi?id=173504
2399
2400         Reviewed by Darin Adler.
2401
2402         Use WTF::Function instead of std::function in WebKit2/ to avoid
2403         unnecessary copying.
2404
2405         * Plugins/PluginStream.cpp:
2406         (WebCore::PluginStream::willSendRequest):
2407         * Plugins/PluginStream.h:
2408
2409 2017-06-16  Sam Weinig  <sam@webkit.org>
2410
2411         [WebIDL] Remove custom bindings for HTMLDocument
2412         https://bugs.webkit.org/show_bug.cgi?id=173444
2413
2414         Reviewed by Darin Adler.
2415
2416         * DOMHTMLClasses.cpp:
2417         (DOMHTMLDocument::write):
2418         (DOMHTMLDocument::writeln):
2419         Update for new signature of write/writeln.
2420
2421 2017-06-16  Daniel Bates  <dabates@apple.com>
2422
2423         Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
2424         instead of URL { ParsedURLString, ... }
2425         https://bugs.webkit.org/show_bug.cgi?id=173495
2426         <rdar://problem/32827445>
2427
2428         Reviewed by Alex Christensen.
2429
2430         URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
2431         Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
2432         Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
2433         would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
2434         parse an arbitrary string that looks like a URL.
2435
2436         Also modernize the code using C++14 idioms.
2437
2438         * WebCoreSupport/WebContextMenuClient.cpp:
2439         (WebContextMenuClient::searchWithGoogle):
2440
2441 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
2442
2443         [Win] WebKit shouldn't include the forwarding header of WebKit itself
2444         https://bugs.webkit.org/show_bug.cgi?id=173352
2445
2446         Reviewed by Alex Christensen.
2447
2448         * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
2449
2450 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
2451
2452         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
2453         https://bugs.webkit.org/show_bug.cgi?id=173318
2454
2455         Reviewed by Darin Adler.
2456
2457         The logical frame size is currently calculated by scaling the frame size in pixels,
2458         and rounding the coordinates to the nearest integers. The computed logical frame
2459         size will in some cases be smaller than the scaled frame size in pixels, since it is
2460         represented as an IntSize. In these cases, the bottom line will not be painted.
2461         Instead of calculating the logical frame size by rounding the scaled frame in
2462         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
2463
2464         * WebCoreSupport/WebFrameLoaderClient.cpp:
2465         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2466
2467 2017-06-13  Daniel Bates  <dabates@apple.com>
2468
2469         Implement W3C Secure Contexts Draft Specification
2470         https://bugs.webkit.org/show_bug.cgi?id=158121
2471         <rdar://problem/26012994>
2472
2473         Reviewed by Brent Fulgham.
2474
2475         Part 4
2476
2477         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
2478
2479         * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
2480         * WebPreferenceKeysPrivate.h:
2481         * WebPreferences.cpp:
2482         (WebPreferences::initializeDefaultSettings):
2483         (WebPreferences::QueryInterface):
2484         (WebPreferences::setIsSecureContextAttributeEnabled):
2485         (WebPreferences::isSecureContextAttributeEnabled):
2486         * WebPreferences.h:
2487         * WebView.cpp:
2488         (WebView::notifyPreferencesChanged):
2489
2490 2017-06-13  Per Arne Vollan  <pvollan@apple.com>
2491
2492         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
2493         https://bugs.webkit.org/show_bug.cgi?id=173318
2494
2495         Reviewed by Alex Christensen.
2496
2497         The logical frame size is currently calculated by scaling the frame size in pixels,
2498         and rounding the coordinates to the nearest integers. The computed logical frame
2499         size will in some cases be smaller than the scaled frame size in pixels, since it is
2500         represented as an IntSize. In these cases, the bottom line will not be painted.
2501         Instead of calculating the logical frame size by rounding the scaled frame in
2502         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
2503  
2504         * WebView.cpp:
2505         (WebView::sizeChanged):
2506
2507 2017-06-13  Sam Weinig  <sam@webkit.org>
2508
2509         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
2510         https://bugs.webkit.org/show_bug.cgi?id=80733
2511
2512         Reviewed by Chris Dumez.
2513
2514         * WebFrame.cpp:
2515         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2516
2517 2017-06-12  Daewoong Jang  <daewoong.jang@navercorp.com>
2518
2519         Remove WebCore::unloadModule and related data types
2520         https://bugs.webkit.org/show_bug.cgi?id=173231
2521
2522         Reviewed by Darin Adler.
2523
2524         * Plugins/PlatformModule.h: Added.
2525         (WebCore::PlatformModuleVersion::PlatformModuleVersion):
2526         * Plugins/PluginPackage.cpp:
2527         (WebCore::PluginPackage::freeLibraryTimerFired):
2528         * Plugins/PluginPackage.h:
2529
2530 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2531
2532         [iOS DnD] Add a hook to perform two-step drops in editable content
2533         https://bugs.webkit.org/show_bug.cgi?id=172992
2534         <rdar://problem/32590174>
2535
2536         Reviewed by Tim Horton.
2537
2538         Add a stub implementation for performTwoStepDrop on Windows.
2539
2540         * WebCoreSupport/WebEditorClient.h:
2541
2542 2017-06-04  Konstantin Tokarev  <annulen@yandex.ru>
2543
2544         Fix build of Windows-specific code with ICU 59.1
2545         https://bugs.webkit.org/show_bug.cgi?id=172729
2546
2547         Reviewed by Darin Adler.
2548
2549         Fix conversions from WTF::String to wchar_t* and vice versa.
2550
2551         * Plugins/PluginDatabaseWin.cpp:
2552         (WebCore::addPluginPathsFromRegistry):
2553         (WebCore::PluginDatabase::getPluginPathsInDirectories):
2554         (WebCore::addMozillaPluginDirectories):
2555         (WebCore::addWindowsMediaPlayerPluginDirectory):
2556         (WebCore::addAdobeAcrobatPluginDirectory):
2557         (WebCore::addJavaPluginDirectory):
2558         (WebCore::safariPluginsDirectory):
2559         (WebCore::addMacromediaPluginDirectories):
2560         * Plugins/PluginPackageWin.cpp:
2561         (WebCore::getVersionInfo):
2562         (WebCore::PluginPackage::fetchInfo):
2563         (WebCore::PluginPackage::load):
2564         * Plugins/PluginViewWin.cpp:
2565         (WebCore::PluginView::handlePostReadFile):
2566
2567 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
2568
2569         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
2570         https://bugs.webkit.org/show_bug.cgi?id=172709
2571
2572         Reviewed by Brent Fulgham.
2573
2574         Add method to exit fullscreen mode.
2575
2576         * Interfaces/IWebViewPrivate.idl:
2577         * WebView.cpp:
2578         (WebView::exitFullscreenIfNeeded):
2579         * WebView.h:
2580
2581 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
2582
2583         [Win] Create unique network storage session for each DRT.
2584         https://bugs.webkit.org/show_bug.cgi?id=172540
2585
2586         Reviewed by Brent Fulgham.
2587
2588         During layout testing, each DRT instance should have its own network storage session.
2589
2590         * Interfaces/IWebPreferencesPrivate.idl:
2591         * WebPreferences.cpp:
2592         (WebPreferences::switchNetworkLoaderToNewTestingSession):
2593         * WebPreferences.h:
2594
2595 2017-05-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2596
2597         [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
2598         https://bugs.webkit.org/show_bug.cgi?id=172535
2599
2600         Reviewed by Konstantin Tokarev.
2601
2602         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2603         (AcceleratedCompositingContext::paintContents): Append the fifth argument.
2604         * WebCoreSupport/AcceleratedCompositingContext.h: Ditto.
2605
2606 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
2607
2608         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
2609         https://bugs.webkit.org/show_bug.cgi?id=172071
2610
2611         Reviewed by Alexey Proskuryakov.
2612
2613         We need to delete all cookies after each test.
2614
2615         * Interfaces/IWebPreferencesPrivate.idl:
2616         * WebPreferences.cpp:
2617         (WebPreferences::linkPreloadEnabled):
2618         (WebPreferences::clearNetworkLoaderSession):
2619         * WebPreferences.h:
2620
2621 2017-05-13  Chris Dumez  <cdumez@apple.com>
2622
2623         Stop using RefPtr::release()
2624         https://bugs.webkit.org/show_bug.cgi?id=172074
2625
2626         Reviewed by Geoffrey Garen.
2627
2628         * WebFrame.cpp:
2629         (WebFrame::loadPlainTextString):
2630         (WebFrame::loadHTMLString):
2631         * WebFramePolicyListener.cpp:
2632         (WebFramePolicyListener::receivedPolicyDecision):
2633
2634 2017-05-13  Chris Dumez  <cdumez@apple.com>
2635
2636         Drop uses of PassRefPtr in WebKit/win
2637         https://bugs.webkit.org/show_bug.cgi?id=172067
2638
2639         Reviewed by Yusuke Suzuki.
2640
2641         * DOMEventsClasses.cpp:
2642         (DOMEvent::DOMEvent):
2643         (DOMEvent::createInstance):
2644         * DOMEventsClasses.h:
2645         (DOMUIEvent::DOMUIEvent):
2646         (DOMKeyboardEvent::DOMKeyboardEvent):
2647         (DOMMouseEvent::DOMMouseEvent):
2648         (DOMMutationEvent::DOMMutationEvent):
2649         (DOMOverflowEvent::DOMOverflowEvent):
2650         (DOMWheelEvent::DOMWheelEvent):
2651         * MemoryStream.cpp:
2652         (MemoryStream::MemoryStream):
2653         (MemoryStream::createInstance):
2654         * MemoryStream.h:
2655         * Plugins/PluginDatabase.cpp:
2656         (WebCore::PluginDatabase::refresh):
2657         (WebCore::PluginDatabase::add):
2658         (WebCore::PluginDatabase::loadPersistentMetadataCache):
2659         * Plugins/PluginDatabase.h:
2660         * Plugins/PluginPackage.cpp:
2661         (WebCore::PluginPackage::createPackage):
2662         (WebCore::PluginPackage::createPackageFromCache):
2663         * Plugins/PluginPackage.h:
2664         * Plugins/PluginStream.h:
2665         (WebCore::PluginStream::create):
2666         * WebActionPropertyBag.cpp:
2667         (WebActionPropertyBag::WebActionPropertyBag):
2668         (WebActionPropertyBag::createInstance):
2669         * WebActionPropertyBag.h:
2670         * WebArchive.cpp:
2671         (WebArchive::createInstance):
2672         (WebArchive::WebArchive):
2673         * WebArchive.h:
2674         * WebBackForwardList.cpp:
2675         (WebBackForwardList::WebBackForwardList):
2676         (WebBackForwardList::createInstance):
2677         * WebBackForwardList.h:
2678         * WebCoreSupport/EmbeddedWidget.cpp:
2679         (EmbeddedWidget::create):
2680         * WebCoreSupport/EmbeddedWidget.h:
2681         * WebCoreSupport/WebChromeClient.h:
2682         * WebFrame.cpp:
2683         (WebFrame::loadData):
2684         (WebFrame::createSubframeWithOwnerElement):
2685         * WebFrame.h:
2686         * WebFramePolicyListener.cpp:
2687         (WebFramePolicyListener::WebFramePolicyListener):
2688         (WebFramePolicyListener::createInstance):
2689         * WebFramePolicyListener.h:
2690         * WebGeolocationPolicyListener.cpp:
2691         (WebGeolocationPolicyListener::createInstance):
2692         (WebGeolocationPolicyListener::WebGeolocationPolicyListener):
2693         * WebGeolocationPolicyListener.h:
2694         * WebHistoryItem.cpp:
2695         (WebHistoryItem::WebHistoryItem):
2696         (WebHistoryItem::createInstance):
2697         * WebHistoryItem.h:
2698         * WebMutableURLRequest.cpp:
2699         (WebMutableURLRequest::setFormData):
2700         (WebMutableURLRequest::formData):
2701         * WebMutableURLRequest.h:
2702         * WebResource.cpp:
2703         (WebResource::createInstance):
2704         * WebResource.h:
2705         * WebScriptWorld.cpp:
2706         (WebScriptWorld::WebScriptWorld):
2707         (WebScriptWorld::createInstance):
2708         * WebScriptWorld.h:
2709         * WebURLAuthenticationChallengeSender.cpp:
2710         (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
2711         (WebURLAuthenticationChallengeSender::createInstance):
2712         * WebURLAuthenticationChallengeSender.h:
2713         * WebView.cpp:
2714         (WebView::setFullScreenElement):
2715         * WebView.h:
2716
2717 2017-05-11  Chris Dumez  <cdumez@apple.com>
2718
2719         Drop remaining uses of PassRefPtr in WebCore
2720         https://bugs.webkit.org/show_bug.cgi?id=172013
2721
2722         Reviewed by Yusuke Suzuki.
2723
2724         * Plugins/PluginView.cpp:
2725         (WebCore::PluginView::bindingInstance):
2726
2727 2017-05-11  Chris Dumez  <cdumez@apple.com>
2728
2729         Stop using PassRefPtr in platform/graphics
2730         https://bugs.webkit.org/show_bug.cgi?id=171977
2731
2732         Reviewed by Alex Christensen.
2733
2734         Build fix.
2735
2736         * FullscreenVideoController.cpp:
2737         (FullscreenVideoController::enterFullscreen):
2738         * WebKitDLL.cpp:
2739         (loadResourceIntoBuffer):
2740
2741 2017-05-09  Sam Weinig  <sam@webkit.org>
2742
2743         Remove support for legacy Notifications
2744         https://bugs.webkit.org/show_bug.cgi?id=171487
2745
2746         Reviewed by Jon Lee.
2747
2748         * WebCoreSupport/WebChromeClient.cpp:
2749         (WebChromeClient::WebChromeClient):
2750         * WebCoreSupport/WebChromeClient.h:
2751         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
2752         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
2753         Remove legacy notification specific code.
2754
2755 2017-05-09  Dean Jackson  <dino@apple.com>
2756
2757         Fix Windows build.
2758
2759         * Plugins/PluginView.h:
2760         * Plugins/PluginViewWin.cpp:
2761         (WebCore::PluginView::paint):
2762
2763 2017-05-06  Alexey Proskuryakov  <ap@apple.com>
2764
2765         REGRESSION (r216294): The new test fails on WebKit1
2766         https://bugs.webkit.org/show_bug.cgi?id=171780
2767
2768         Rolling back https://trac.webkit.org/r216294, https://trac.webkit.org/r216296,
2769         https://trac.webkit.org/216299, https://trac.webkit.org/216330
2770
2771         * Plugins/PluginView.h:
2772         * Plugins/PluginViewWin.cpp:
2773         (WebCore::PluginView::paint):
2774
2775 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
2776
2777         Fix Windows build after r216294.
2778
2779         * Plugins/PluginView.h:
2780         * Plugins/PluginViewWin.cpp:
2781         (WebCore::PluginView::paint):
2782
2783 2017-05-04  Commit Queue  <commit-queue@webkit.org>
2784
2785         Unreviewed, rolling out r216206.
2786         https://bugs.webkit.org/show_bug.cgi?id=171714
2787
2788         Multiple LayoutTests crashing in Document::page() (Requested
2789         by ap on #webkit).
2790
2791         Reverted changeset:
2792
2793         "Remove support for legacy Notifications"
2794         https://bugs.webkit.org/show_bug.cgi?id=171487
2795         http://trac.webkit.org/changeset/216206
2796
2797 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
2798
2799         [Win] Remove redundant macros that are set in the CMake config
2800         https://bugs.webkit.org/show_bug.cgi?id=171571
2801
2802         Reviewed by Brent Fulgham.
2803
2804         * COMEnumVariant.h:
2805         * COMPropertyBag.h:
2806         * WebKitPrefix.h:
2807
2808 2017-05-04  Sam Weinig  <sam@webkit.org>
2809
2810         Remove support for legacy Notifications
2811         https://bugs.webkit.org/show_bug.cgi?id=171487
2812
2813         Reviewed by Jon Lee.
2814
2815         * WebCoreSupport/WebChromeClient.cpp:
2816         (WebChromeClient::WebChromeClient):
2817         * WebCoreSupport/WebChromeClient.h:
2818         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
2819         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
2820         Remove legacy notification specific code.
2821
2822 2017-04-27  Alex Christensen  <achristensen@webkit.org>
2823
2824         Modernize Frame.h
2825         https://bugs.webkit.org/show_bug.cgi?id=171357
2826
2827         Reviewed by Andy Estes.
2828
2829         * WebCoreSupport/WebEditorClient.cpp:
2830         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
2831         * WebCoreSupport/WebEditorClient.h:
2832
2833 2017-04-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2834
2835         [WinCairo] Fix build break after updating ANGLE
2836         https://bugs.webkit.org/show_bug.cgi?id=170980
2837
2838         Reviewed by Brent Fulgham.
2839
2840         * WebCoreSupport/AcceleratedCompositingContext.cpp: Define GL_GLEXT_PROTOTYPES.
2841
2842 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
2843
2844         [Win] REGRESSION(r215486): Windows Release build is broken
2845         https://bugs.webkit.org/show_bug.cgi?id=171024
2846         <rdar://problem/31722618>
2847
2848         Reviewed by Mark Lam.
2849
2850         Windows WebKit refers to a handful of JSC methods that are always
2851         inline. We need to include 'HeapInlines.h' to get the implementation
2852         of these methods.
2853
2854         * Plugins/PluginPackage.cpp:
2855         * WebFrame.cpp:
2856         * WebView.cpp:
2857
2858 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2859
2860         Unreviewed, fix the Windows build after r215385
2861
2862         r215385 introduced a new virtual method on ChromeClient that needs to be implemented in WebChromeClient for
2863         Windows in WebKit1.
2864
2865         * WebCoreSupport/WebChromeClient.cpp:
2866         (WebChromeClient::createIconForFiles):
2867         * WebCoreSupport/WebChromeClient.h:
2868
2869 2017-04-10  Chris Dumez  <cdumez@apple.com>
2870
2871         Drop Timer::startOneShot() overload taking a double
2872         https://bugs.webkit.org/show_bug.cgi?id=170659
2873
2874         Reviewed by Yusuke Suzuki.
2875
2876         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
2877
2878         * Plugins/PluginMessageThrottlerWin.cpp:
2879         (WebCore::PluginMessageThrottlerWin::appendMessage):
2880         (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
2881         * Plugins/PluginViewWin.cpp:
2882         (WebCore::PluginView::invalidateRect):
2883         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2884         (AcceleratedCompositingContext::scheduleLayerFlush):
2885
2886 2017-04-09  Chris Dumez  <cdumez@apple.com>
2887
2888         Drop Timer::startRepeating() overload taking a double
2889         https://bugs.webkit.org/show_bug.cgi?id=170656
2890
2891         Reviewed by Yusuke Suzuki.
2892
2893         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
2894
2895         * FullscreenVideoController.cpp:
2896
2897 2017-04-09  Chris Dumez  <cdumez@apple.com>
2898
2899         Start dropping Timer API dealing with double
2900         https://bugs.webkit.org/show_bug.cgi?id=170649
2901
2902         Reviewed by Yusuke Suzuki.
2903
2904         Start dropping Timer API dealing with double as people should use Seconds now.
2905
2906         * Plugins/PluginPackage.cpp:
2907         (WebCore::PluginPackage::freeLibrarySoon):
2908         * Plugins/PluginStream.cpp:
2909         (WebCore::PluginStream::deliverData):
2910         * Plugins/PluginView.cpp:
2911         (WebCore::PluginView::requestTimerFired):
2912         (WebCore::PluginView::scheduleRequest):
2913         (WebCore::PluginView::setJavaScriptPaused):
2914         (WebCore::PluginView::keepAlive):
2915         * Plugins/PluginViewWin.cpp:
2916         (WebCore::PluginView::wndProc):
2917         * WebView.cpp:
2918         (WebView::closeWindowSoon):
2919
2920 2017-04-08  Chris Dumez  <cdumez@apple.com>
2921
2922         Drop std::chrono support from Timer class
2923         https://bugs.webkit.org/show_bug.cgi?id=170645
2924
2925         Reviewed by Sam Weinig.
2926
2927         Drop std::chrono support from Timer class now that we prefer using Seconds type.
2928
2929         * WebView.cpp:
2930         (WebView::setCacheModel):
2931
2932 2017-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2933
2934         [WinCairo] WebCore::PlatformDisplay::terminateEGLDisplay causes a crash in libGLESv2.dll while processing atexit
2935         https://bugs.webkit.org/show_bug.cgi?id=170331
2936
2937         Reviewed by Michael Catanzaro.
2938
2939         * WebKitDLL.cpp:
2940         (shutDownWebKit): Call PlatformDisplay::shutDownEglDisplays in shutDownWebKit.
2941
2942 2017-03-30  James Craig  <jcraig@apple.com>
2943
2944         AX: Expose a new AXSubrole for explicit ARIA "group" role
2945         https://bugs.webkit.org/show_bug.cgi?id=169810
2946         <rdar://problem/31039693>
2947
2948         Reviewed by Chris Fleizach.
2949
2950         Account for Windows platform role mapping.
2951
2952         * AccessibleBase.cpp:
2953         (MSAARole):
2954
2955 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2956
2957         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
2958         https://bugs.webkit.org/show_bug.cgi?id=169168
2959         <rdar://problem/30688374>
2960
2961         Reviewed by Tim Horton.
2962
2963         Minor tweak to adjust for a changed interface. See WebKit and WebCore ChangeLogs for more information.
2964
2965         * WebCoreSupport/WebDragClient.cpp:
2966         (WebDragClient::actionMaskForDrag):
2967         * WebCoreSupport/WebDragClient.h:
2968
2969 2017-03-13  Per Arne Vollan  <pvollan@apple.com>
2970
2971         [Win] Compile fix.
2972         https://bugs.webkit.org/show_bug.cgi?id=169545
2973
2974         Reviewed by Brent Fulgham.
2975
2976         Fix inconsistent dll linkage warnings.
2977  
2978         * WebKitDLL.cpp:
2979         * WebKitDLL.h:
2980
2981 2017-03-13  Per Arne Vollan  <pvollan@apple.com>
2982
2983         Unreviewed Win build fix.
2984         
2985         WebCore::CookiesStrategy::addCookie has been removed, we should also remove the override.
2986
2987         * WebCoreSupport/WebPlatformStrategies.cpp:
2988         (WebPlatformStrategies::addCookie): Deleted.
2989         (WebPlatformStrategies::addCookie): Deleted.
2990         * WebCoreSupport/WebPlatformStrategies.h:
2991
2992 2017-03-10  Brent Fulgham  <bfulgham@apple.com>
2993
2994         [Win] Re-export a few symbols for backwards compatibility
2995         https://bugs.webkit.org/show_bug.cgi?id=169490
2996         <rdar://problem/30983623>
2997
2998         Reviewed by Dean Jackson.
2999
3000         Re-introduce a workaround that re-exports a few JavaScriptCore functions
3001         that had been erroneously exported by WebKit in older builds. This
3002         is needed so that we do not break certain old software still being used.
3003
3004         * WebKitDLL.cpp:
3005         (DllMain): Bind functions at startup.
3006         (bindJavaScriptTrampoline): Find JavaScriptCore library functions and
3007         re-export them from WebKit.dll.
3008         * WebKitDLL.h: Only advertise these functions when building WebKt itself.
3009
3010 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
3011
3012         Expand font-weight and font-stretch to take any number
3013         https://bugs.webkit.org/show_bug.cgi?id=168889
3014
3015         Reviewed by Simon Fraser.
3016
3017         Migrate off old enum types.
3018
3019         * WebKitGraphics.cpp:
3020         (makeFont):
3021
3022 2017-03-02  Sam Weinig  <sam@webkit.org>
3023
3024         Rename htmlediting.h/cpp to Editing.h/cpp
3025         https://bugs.webkit.org/show_bug.cgi?id=169103
3026
3027         Reviewed by Alex Christensen.
3028
3029         * AccessibleTextImpl.cpp:
3030
3031 2017-03-01  Alex Christensen  <achristensen@webkit.org>
3032
3033         Actually fix Windows build.
3034
3035         * WebFrame.cpp:
3036         (WebFrame::invalidate):
3037         r213266 changed Style::Force to ResolveStyleType::Rebuild, so I did so here.
3038
3039 2017-03-01  Alex Christensen  <achristensen@webkit.org>
3040
3041         Fix Windows build after r213266
3042         https://bugs.webkit.org/show_bug.cgi?id=169049
3043
3044         * WebFrame.cpp:
3045         (WebFrame::invalidate):
3046
3047 2017-02-27  Per Arne Vollan  <pvollan@apple.com>
3048
3049         [Win] Http preload tests are failing.
3050         https://bugs.webkit.org/show_bug.cgi?id=168910
3051
3052         Reviewed by Alex Christensen.
3053
3054         The feature is not enabled.
3055
3056         * WebView.cpp:
3057         (WebView::notifyPreferencesChanged):
3058
3059 2017-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3060
3061         Better handle Thread and RunLoop initialization
3062         https://bugs.webkit.org/show_bug.cgi?id=167828
3063
3064         Reviewed by Yusuke Suzuki.
3065
3066         Remove unnecessary call to WTF::initializeMainThread().
3067
3068         * WebView.cpp:
3069         (WebView::WebView):
3070
3071 2017-02-20  Per Arne Vollan  <pvollan@apple.com>
3072
3073         [Win] Custom scale factor is not applied in all cases.
3074         https://bugs.webkit.org/show_bug.cgi?id=168117
3075
3076         Reviewed by Brent Fulgham.
3077
3078         We should not call the function deviceScaleFactorForWindow directly, since this
3079         will return the system scale factor, and ignore the custom scale factor.
3080
3081         * WebView.cpp:
3082         (WebView::handleContextMenuEvent):
3083         (WebView::handleMouseEvent):
3084         (WebView::setAcceleratedCompositing):
3085
3086 2017-02-16  Daniel Bates  <dabates@apple.com>
3087
3088         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
3089         https://bugs.webkit.org/show_bug.cgi?id=168417
3090         <rdar://problem/30541748>
3091
3092         Reviewed by Brent Fulgham.
3093
3094         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
3095         Widget* as it is always called with a valid Widget.
3096
3097         * WebCoreSupport/WebFrameLoaderClient.cpp:
3098         (WebFrameLoaderClient::redirectDataToPlugin):
3099         * WebCoreSupport/WebFrameLoaderClient.h:
3100
3101 2017-02-15  Anders Carlsson  <andersca@apple.com>
3102
3103         Another attempt at fixing the Windows build.
3104
3105         * WebCoreSupport/WebDragClient.cpp:
3106         (WebDragClient::startDrag):
3107
3108 2017-02-15  Anders Carlsson  <andersca@apple.com>
3109
3110         Try to fix the Windows build.
3111
3112         * WebCoreSupport/WebDragClient.h:
3113
3114 2017-02-15  Anders Carlsson  <andersca@apple.com>
3115
3116         Modernize DragClient::startDrag somewhat
3117         https://bugs.webkit.org/show_bug.cgi?id=168379
3118
3119         Reviewed by Tim Horton.
3120
3121         Update for WebCore changes.
3122
3123         * WebCoreSupport/WebDragClient.cpp:
3124         (WebDragClient::startDrag):
3125
3126 2017-02-10  Daniel Bates  <dabates@apple.com>
3127
3128         Attempt to fix the WinCairo 64-Bit Release build following <https://trac.webkit.org/changeset/212173>
3129         (https://bugs.webkit.org/show_bug.cgi?id=166774)
3130
3131         Touch WebKit.idl in the hopes that it will cause CMake to regenerate the COM interface files.
3132
3133         * Interfaces/WebKit.idl:
3134
3135 2017-02-10  Daniel Bates  <dabates@apple.com>
3136
3137         Detach frame from document when entering page cache
3138         https://bugs.webkit.org/show_bug.cgi?id=166774
3139         <rdar://problem/29904368>
3140
3141         Reviewed by Chris Dumez.
3142
3143         * Interfaces/IWebPreferencesPrivate.idl:
3144         * WebPreferenceKeysPrivate.h:
3145         * WebPreferences.cpp:
3146         (WebPreferences::initializeDefaultSettings):
3147         (WebPreferences::setAllowsPageCacheWithWindowOpener): Deleted.
3148         (WebPreferences::allowsPageCacheWithWindowOpener): Deleted.
3149         * WebPreferences.h:
3150         * WebView.cpp:
3151         (WebView::notifyPreferencesChanged):
3152
3153 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
3154
3155         [Resource Timing] Enable Resource Timing by default in Tests
3156         https://bugs.webkit.org/show_bug.cgi?id=168145
3157
3158         Reviewed by Ryosuke Niwa.
3159
3160         * Interfaces/IWebPreferencesPrivate.idl:
3161         * WebPreferenceKeysPrivate.h:
3162         * WebPreferences.cpp:
3163         (WebPreferences::initializeDefaultSettings):
3164         (WebPreferences::setResourceTimingEnabled):
3165         (WebPreferences::resourceTimingEnabled):
3166         * WebPreferences.h:
3167         * WebView.cpp:
3168         (WebView::notifyPreferencesChanged):
3169
3170 2017-02-06  Alex Christensen  <achristensen@webkit.org>
3171
3172         More build fixes after r211751
3173         https://bugs.webkit.org/show_bug.cgi?id=166998
3174
3175         * WebDownloadCFNet.cpp:
3176         (WebDownload::didReceiveAuthenticationChallenge):
3177
3178 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3179
3180         Rename AnimationController to CSSAnimationController
3181         https://bugs.webkit.org/show_bug.cgi?id=167829
3182
3183         Reviewed by Simon Fraser.
3184
3185         * WebFrame.cpp:
3186
3187 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3188
3189         Drag images should be anchored to the mouse location
3190         https://bugs.webkit.org/show_bug.cgi?id=167690
3191         <rdar://problem/30295261>
3192
3193         Reviewed by Enrica Casucci.
3194
3195         Adds some plumbing for the anchor point in the WK1 client layer.
3196
3197         * WebCoreSupport/WebDragClient.cpp:
3198         (WebDragClient::startDrag):
3199         * WebCoreSupport/WebDragClient.h:
3200
3201 2017-02-02  Per Arne Vollan  <pvollan@apple.com>
3202
3203         [Win][HiDPI] Scale factor is applied twice in accelerated compositing mode.
3204         https://bugs.webkit.org/show_bug.cgi?id=167732
3205
3206         Reviewed by Brent Fulgham.
3207
3208         Backing layer should not be scaled when CACFLayerSetContentsScale is used for scaling.
3209
3210         * WebView.cpp:
3211         (WebView::setAcceleratedCompositing):
3212
3213 2017-02-02  Chris Dumez  <cdumez@apple.com>
3214
3215         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
3216         https://bugs.webkit.org/show_bug.cgi?id=167738
3217         <rdar://problem/30229990>
3218
3219         Reviewed by Andreas Kling.
3220
3221         The BackForwardClient no longer needs to worry about removing HistoryItems
3222         from the PageCache now that WebCore takes care of it.
3223
3224         * BackForwardList.cpp:
3225         (BackForwardList::close):
3226
3227 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
3228
3229         Add Link Preload as an off-by-default experimental feature menu item.
3230         https://bugs.webkit.org/show_bug.cgi?id=167201
3231
3232         Reviewed by Ryosuke Niwa.
3233
3234         * WebPreferenceKeysPrivate.h:
3235         * WebPreferences.cpp:
3236         (WebPreferences::initializeDefaultSettings):
3237         (WebPreferences::valueForKey):
3238         (WebPreferences::setLinkPreloadEnabled):
3239         (WebPreferences::linkPreloadEnabled):
3240         * WebPreferences.h:
3241         * Interfaces/IWebPreferencesPrivate.idl:
3242
3243 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
3244
3245         Add User Timing Experimental Feature
3246         https://bugs.webkit.org/show_bug.cgi?id=167542
3247         <rdar://problem/22746307>
3248
3249         Reviewed by Ryosuke Niwa.
3250
3251         * Interfaces/IWebPreferencesPrivate.idl:
3252         * WebPreferenceKeysPrivate.h:
3253         * WebPreferences.cpp:
3254         (WebPreferences::initializeDefaultSettings):
3255         (WebPreferences::setUserTimingEnabled):
3256         (WebPreferences::userTimingEnabled):
3257         * WebPreferences.h:
3258         * WebView.cpp:
3259         (WebView::notifyPreferencesChanged):
3260         Add setting for User Timing runtime enabled feature.
3261
3262 2017-01-26  Chris Dumez  <cdumez@apple.com>
3263
3264         Crash when navigating back to a page in PacheCache when one of its frames has been removed
3265         https://bugs.webkit.org/show_bug.cgi?id=167421
3266         <rdar://problem/30188490>
3267
3268         Reviewed by Darin Adler.
3269
3270         Add a new setting allowing layout tests to enable PageCache in a window
3271         that has an opener, for convenience.
3272
3273         * WebPreferenceKeysPrivate.h:
3274         * WebPreferences.cpp:
3275         (WebPreferences::initializeDefaultSettings):
3276         * WebPreferences.h:
3277
3278 2017-01-26  Keith Miller  <keith_miller@apple.com>
3279
3280         classInfo should take a VM so it is not materialized from the object on each call
3281         https://bugs.webkit.org/show_bug.cgi?id=167424
3282
3283         Rubber Stamped by Michael Saboff.
3284
3285         Previously, classInfo() would get the VM from the target's
3286         MarkedBlock.  Most callers already have a VM on hand, so it is
3287         wasteful to compute the VM from the marked block every time. This
3288         patch refactors some of the most common callers of classInfo(),
3289         jsDynamicCast and inherits to take a VM as well.
3290
3291         * WebFrame.cpp:
3292         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
3293         * WebView.cpp:
3294         (WebView::elementFromJS):
3295
3296 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
3297
3298         Crash when setting custom scale factor.
3299         https://bugs.webkit.org/show_bug.cgi?id=167369
3300
3301         Reviewed by Sam Weinig.
3302
3303         Add null pointer check.
3304
3305         * WebView.cpp:
3306         (WebView::setCustomBackingScaleFactor):
3307
3308 2017-01-24  Youenn Fablet  <youennf@gmail.com>
3309
3310         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
3311         https://bugs.webkit.org/show_bug.cgi?id=167294
3312
3313         Reviewed by Alex Christensen.
3314
3315         * WebView.cpp:
3316         (WebView::initWithFrame):
3317
3318 2017-01-23  Chris Dumez  <cdumez@apple.com>
3319
3320         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
3321         https://bugs.webkit.org/show_bug.cgi?id=167308
3322         <rdar://problem/30144964>
3323
3324         Unreviewed, do a partial revert of r211033 to fix assertion.
3325
3326         * WebCoreSupport/WebChromeClient.cpp:
3327         (WebChromeClient::exitFullScreenForElement):
3328
3329 2017-01-20  Darin Adler  <darin@apple.com>
3330
3331         Remove PassRefPtr from "page" directory of WebCore, also deploy references
3332         https://bugs.webkit.org/show_bug.cgi?id=167224
3333
3334         Reviewed by Chris Dumez.
3335
3336         * Plugins/PluginView.cpp:
3337         (WebCore::PluginView::status): Pass reference.
3338         (WebCore::PluginView::focusPluginElement): Ditto.
3339
3340         * WebCoreSupport/WebChromeClient.cpp:
3341         (WebChromeClient::createWindow): Updated for change to ChromeClient.
3342         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
3343         (WebChromeClient::runJavaScriptAlert): Ditto.
3344         (WebChromeClient::runJavaScriptConfirm): Ditto.
3345         (WebChromeClient::runJavaScriptPrompt): Ditto.
3346         (WebChromeClient::contentsSizeChanged): Ditto.
3347         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
3348         (WebChromeClient::print): Ditto.
3349         (WebChromeClient::exceededDatabaseQuota): Ditto.
3350         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
3351         (WebChromeClient::attachRootGraphicsLayer): Ditto.
3352         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
3353         (WebChromeClient::enterVideoFullscreenForVideoElement): Ditto.
3354         (WebChromeClient::createPopupMenu): Ditto.
3355         (WebChromeClient::createSearchPopupMenu): Ditto.
3356         (WebChromeClient::supportsFullScreenForElement): Ditto.
3357         (WebChromeClient::enterFullScreenForElement): Ditto.
3358         (WebChromeClient::exitFullScreenForElement): Ditto.
3359         (WebChromeClient::shouldUseTiledBackingForFrameView): Ditto.
3360         * WebCoreSupport/WebChromeClient.h: Ditto.
3361
3362 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3363
3364         Remove never changing IndexedDB RuntimeEnabledFeature
3365         https://bugs.webkit.org/show_bug.cgi?id=167278
3366
3367         Reviewed by Darin Adler.
3368
3369         * WebView.cpp:
3370         (WebView::notifyPreferencesChanged):
3371
3372 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3373
3374         Cleanup RuntimeEnabledFeatures
3375         https://bugs.webkit.org/show_bug.cgi?id=167228
3376
3377         Reviewed by Simon Fraser.
3378
3379         * WebView.cpp:
3380         (WebView::notifyPreferencesChanged):
3381
3382 2017-01-20  Alex Christensen  <achristensen@webkit.org>
3383
3384         Build Fix for Windows DumpRenderTree after r210976
3385         https://bugs.webkit.org/show_bug.cgi?id=167115
3386
3387         * WebPreferences.h:
3388         Remove extra space.
3389         * IWebPreferencesPrivate.idl:
3390         Add new interface functions.
3391         * WebView.cpp:
3392         We use new functions that are only in IWebPreferencesPrivate4,
3393         so instantiate that COM object instead of version 3.
3394
3395 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3396
3397         Build Fix for Windows DumpRenderTree after r210976
3398
3399         * WebPreferenceKeysPrivate.h:
3400         * WebPreferences.cpp:
3401         (WebPreferences::initializeDefaultSettings):
3402         (WebPreferences::setWebAnimationsEnabled):
3403         (WebPreferences::webAnimationsEnabled):
3404         * WebPreferences.h:
3405         * WebView.cpp:
3406         Add toggle APIs for WebAnimations.
3407
3408 2017-01-19  Chris Dumez  <cdumez@apple.com>
3409
3410         iterable<> should be enabled on WK1
3411         https://bugs.webkit.org/show_bug.cgi?id=167221
3412         <rdar://problem/30108531>
3413
3414         Reviewed by Youenn Fablet.
3415
3416         * Interfaces/IWebPreferencesPrivate.idl:
3417         * WebPreferenceKeysPrivate.h:
3418         * WebPreferences.cpp:
3419         (WebPreferences::setDOMIteratorEnabled): Deleted.
3420         (WebPreferences::domIteratorEnabled): Deleted.
3421         * WebPreferences.h:
3422         * WebView.cpp:
3423         (WebView::notifyPreferencesChanged):
3424
3425 2017-01-18  Alex Christensen  <achristensen@webkit.org>
3426
3427         Fix WinCairo build after r210845.
3428         https://bugs.webkit.org/show_bug.cgi?id=167055
3429
3430         * WebCoreSupport/WebFrameLoaderClient.cpp:
3431         * WebCoreSupport/WebFrameLoaderClient.h:
3432         shouldCacheResponse isn't used when loading with libcurl.
3433         It was dead code before Darin added "override".
3434         WebCore/FrameLoaderClient.h has this inside of USE(CFURLCONNECTION) macros, now we have them here, too.
3435
3436 2017-01-18  Andreas Kling  <akling@apple.com>
3437
3438         Document::securityOrigin() should return a reference.
3439         <https://webkit.org/b/167124>
3440
3441         Reviewed by Sam Weinig.
3442
3443         * Plugins/PluginView.cpp:
3444         (WebCore::PluginView::load):
3445         * WebCoreSupport/WebChromeClient.cpp:
3446         (WebChromeClient::exceededDatabaseQuota):
3447         * WebCoreSupport/WebFrameLoaderClient.cpp:
3448         (WebFrameLoaderClient::didRunInsecureContent):
3449         * WebCoreSupport/WebFrameLoaderClient.h:
3450         * WebCoreSupport/WebGeolocationClient.cpp:
3451         (WebGeolocationClient::requestPermission):
3452         * WebFrame.cpp:
3453         (WebFrame::allowsFollowingLink):
3454
3455 2017-01-15  Darin Adler  <darin@apple.com>
3456
3457         Remove PassRefPtr from "loader" directory of WebCore
3458         https://bugs.webkit.org/show_bug.cgi?id=167055
3459
3460         Reviewed by Alex Christensen.
3461
3462         * Plugins/PluginView.cpp:
3463         (WebCore::PluginView::mediaCanStart): Fix call to dispatchDidFailToStartPlugin
3464         by calling it directly on WebFrameLoaderClient. If my theory is correct, the old
3465         call has been broken and doing nothing since r177941, two years ago, which made
3466         the argument types different between FrameLoaderClient and WebFrameLoaderClient,
3467         leaving WebFrameLoaderClient::dispatchDidFailToStartPlugin as dead code.
3468
3469         * WebCoreSupport/WebChromeClient.cpp:
3470         (WebChromeClient::runOpenPanel): Updated for change to ChromeClient.
3471         * WebCoreSupport/WebChromeClient.h: Ditto.
3472
3473         * WebCoreSupport/WebEditorClient.cpp:
3474         (WebEditorUndoCommand::WebEditorUndoCommand): Take a reference instead of
3475         a PassRefPtr. Also use Ref instead of RefPtr.
3476         (WebEditorClient::shouldChangeTypingStyle): Deleted. Empty function that was
3477         never called.
3478         (WebEditorClient::webViewDidChangeTypingStyle): Ditto.
3479         (WebEditorClient::webViewDidChangeSelection): Ditto.
3480         (WebEditorClient::registerUndoStep):  Take reference instead of PassRefPtr.
3481         (WebEditorClient::registerRedoStep): Ditto.
3482         * WebCoreSupport/WebEditorClient.h: Updated for the above. Also marked the
3483         class and member functions final and made them all private, which will
3484         help us catch if there are any that don't correctly match WebCore.
3485
3486         * WebCoreSupport/WebFrameLoaderClient.cpp:
3487         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Updated
3488         for change to ChromeClient.
3489         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
3490         (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Ditto.
3491         (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto.
3492         (WebFrameLoaderClient::createFrame): Ditto. Also merged two functions into
3493         one because one was private and only called by the other.
3494         (WebFrameLoaderClient::createPlugin): Ditto.
3495         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
3496         (WebFrameLoaderClient::createNetworkingContext): Ditto.
3497         * WebCoreSupport/WebFrameLoaderClient.h: Ditto.
3498
3499         * WebCoreSupport/WebFrameNetworkingContext.h:
3500         (WebFrameNetworkingContext::create): Return a Ref instead of a PassRefPtr.
3501
3502 2017-01-12  Joseph Pecoraro  <pecoraro@apple.com>
3503
3504         Remove unnecessary includes of Page.h
3505         https://bugs.webkit.org/show_bug.cgi?id=166996
3506
3507         Reviewed by Yusuke Suzuki.
3508
3509         * AccessibleTextImpl.cpp:
3510         * BackForwardList.cpp:
3511
3512 2017-01-06  Darin Adler  <darin@apple.com>
3513
3514         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
3515         https://bugs.webkit.org/show_bug.cgi?id=166797
3516
3517         Reviewed by Alex Christensen.
3518
3519         * WebCoreSupport/WebEditorClient.h: Update argument to take a reference
3520         instead of a PassRefPtr.
3521
3522 2017-01-05  Andreas Kling  <akling@apple.com>
3523
3524         Remove ChromeClient::needTouchEvents().
3525         <https://webkit.org/b/166723>
3526
3527         Rubber-stamped by Antti Koivisto.
3528
3529         * WebCoreSupport/WebChromeClient.h:
3530
3531 2017-01-04  Darin Adler  <darin@apple.com>
3532
3533         Remove PassRefPtr use from the "html" directory, other improvements
3534         https://bugs.webkit.org/show_bug.cgi?id=166635
3535
3536         Reviewed by Alex Christensen.
3537
3538         * WebCoreSupport/WebChromeClient.cpp:
3539         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
3540         * WebCoreSupport/WebChromeClient.h: Updated for the above.
3541
3542 2016-12-30  Darin Adler  <darin@apple.com>
3543
3544         Remove PassRefPtr use from the "dom" directory, related cleanup
3545         https://bugs.webkit.org/show_bug.cgi?id=166569
3546
3547         Reviewed by Alex Christensen.
3548
3549         * WebCoreSupport/WebFrameLoaderClient.cpp:
3550         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated since StringWithDirection::title
3551         is now a data member, not a function member.
3552         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
3553         (WebFrameLoaderClient::setTitle): Ditto.
3554         * WebDataSource.cpp:
3555         (WebDataSource::pageTitle): Ditto.
3556
3557 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
3558
3559         Propagate the source origin as much as possible
3560         https://bugs.webkit.org/show_bug.cgi?id=166348
3561
3562         Reviewed by Darin Adler.
3563
3564         * Plugins/PluginPackage.cpp:
3565         (WebCore::NPN_Evaluate):
3566         (WebCore::makeSource): Deleted.
3567
3568 2016-12-22  Andy Estes  <aestes@apple.com>
3569
3570         Make WebCore::EditorInsertAction an enum class
3571         https://bugs.webkit.org/show_bug.cgi?id=166424
3572
3573         Reviewed by Brent Fulgham.
3574
3575         * WebCoreSupport/WebEditorClient.cpp:
3576         (kit):
3577         (WebEditorClient::shouldInsertNode):
3578         (WebEditorClient::shouldInsertText):
3579
3580 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3581
3582         [ES6] Enable ES6 Modules
3583         https://bugs.webkit.org/show_bug.cgi?id=165849
3584
3585         Reviewed by Geoffrey Garen.
3586
3587         * Interfaces/IWebPreferencesPrivate.idl:
3588         * WebPreferenceKeysPrivate.h:
3589         * WebPreferences.cpp:
3590         (WebPreferences::setES6ModulesEnabled): Deleted.
3591         (WebPreferences::es6ModulesEnabled): Deleted.
3592         * WebPreferences.h:
3593         * WebView.cpp:
3594         (WebView::notifyPreferencesChanged):
3595
3596 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
3597
3598         The DOM should have an advancing wavefront opaque root barrier
3599         https://bugs.webkit.org/show_bug.cgi?id=165712
3600
3601         Reviewed by Yusuke Suzuki.
3602         
3603         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
3604
3605         * Plugins/PluginView.cpp:
3606         (WebCore::PluginView::start):
3607         (WebCore::PluginView::stop):
3608         (WebCore::PluginView::performRequest):
3609         (WebCore::PluginView::npObject):
3610         (WebCore::PluginView::privateBrowsingStateChanged):
3611         * Plugins/PluginViewWin.cpp:
3612         (WebCore::PluginView::dispatchNPEvent):
3613         (WebCore::PluginView::handleKeyboardEvent):
3614         (WebCore::PluginView::handleMouseEvent):
3615         (WebCore::PluginView::setNPWindowRect):
3616         * WebCoreStatistics.cpp:
3617         (WebCoreStatistics::javaScriptObjectsCount):
3618         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3619         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3620         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3621         (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
3622         (WebCoreStatistics::javaScriptObjectTypeCounts):
3623         (WebCoreStatistics::shouldPrintExceptions):
3624         (WebCoreStatistics::setShouldPrintExceptions):
3625         (WebCoreStatistics::memoryStatistics):
3626         * WebJavaScriptCollector.cpp:
3627         (WebJavaScriptCollector::objectCount):
3628
3629 2016-12-09  Geoffrey Garen  <ggaren@apple.com>
3630
3631         TextPosition and OrdinalNumber should be more like idiomatic numbers
3632         https://bugs.webkit.org/show_bug.cgi?id=165678
3633
3634         Reviewed by Filip Pizlo.
3635
3636         Adopt default constructor.
3637
3638         * Plugins/PluginPackage.cpp:
3639         (WebCore::makeSource):
3640
3641 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3642
3643         Enable SharedArrayBuffer, remove the flag
3644         https://bugs.webkit.org/show_bug.cgi?id=165614
3645
3646         Rubber stamped by Geoffrey Garen.
3647
3648         * Interfaces/IWebPreferencesPrivate.idl:
3649
3650 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3651
3652         [WTF] Import std::optional reference implementation as WTF::Optional
3653         https://bugs.webkit.org/show_bug.cgi?id=164199
3654
3655         Reviewed by Saam Barati and Sam Weinig.
3656
3657         Use WTF::Optional::value_or.
3658
3659         * Plugins/PluginView.cpp:
3660         (WebCore::PluginView::performRequest):
3661         * WebCoreSupport/WebFrameLoaderClient.cpp:
3662         (WebFrameLoaderClient::dispatchDidCommitLoad):
3663         * WebCoreSupport/WebFrameLoaderClient.h:
3664         * WebSecurityOrigin.cpp:
3665         (WebSecurityOrigin::port):
3666
3667 2016-11-19  Simon Fraser  <simon.fraser@apple.com>
3668
3669         [iOS WK2] When zoomed in and panning on pages with fixed bars, parts of the bars are sometimes missing
3670         https://bugs.webkit.org/show_bug.cgi?id=164855
3671
3672         Reviewed by Sam Weinig.
3673         
3674         Remove the "inStableState" parameter from flushCompositingState() etc.
3675
3676         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3677         (AcceleratedCompositingContext::flushPendingLayerChanges):
3678         * WebView.cpp:
3679         (WebView::flushPendingGraphicsLayerChanges):
3680
3681 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
3682
3683         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
3684         https://bugs.webkit.org/show_bug.cgi?id=164827
3685
3686         Reviewed by Ryosuke Niwa.
3687
3688         * Interfaces/IWebPreferencesPrivate.idl:
3689         * WebPreferenceKeysPrivate.h:
3690         * WebPreferences.cpp:
3691         (WebPreferences::setES6ModulesEnabled):
3692         (WebPreferences::es6ModulesEnabled):
3693         * WebPreferences.h:
3694         * WebView.cpp:
3695         (WebView::notifyPreferencesChanged):
3696
3697 2016-11-14  Alex Christensen  <achristensen@webkit.org>
3698
3699         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
3700         https://bugs.webkit.org/show_bug.cgi?id=164720
3701
3702         Reviewed by Brady Eidson.
3703
3704         * WebDatabaseManager.cpp:
3705         (DidModifyOriginData::dispatchToMainThread):
3706         (DidModifyOriginData::DidModifyOriginData):
3707         (WebDatabaseManager::dispatchDidModifyOrigin):
3708         (WebDatabaseManager::dispatchDidModifyDatabase):
3709         * WebDatabaseManager.h:
3710         * WebSecurityOrigin.cpp:
3711         (WebSecurityOrigin::usage):
3712         (WebSecurityOrigin::quota):
3713         (WebSecurityOrigin::setQuota):
3714
3715 2016-11-13  Darin Adler  <darin@apple.com>
3716
3717         Fix exception handling in SQL database code, streamline and update code
3718         https://bugs.webkit.org/show_bug.cgi?id=164685
3719
3720         Reviewed by Sam Weinig.
3721
3722         * WebDatabaseManager.cpp:
3723         (WebDatabaseManager::origins): Use DatabaseTracker.
3724         (WebDatabaseManager::databasesWithOrigin): Ditto.
3725         (WebDatabaseManager::detailsForDatabase): Use reference.
3726         (WebDatabaseManager::deleteAllDatabases): Use DatabaseTracker.
3727         (WebDatabaseManager::deleteOrigin): Ditto.
3728         (WebDatabaseManager::deleteDatabase): Ditto.
3729         (WebDatabaseManager::dispatchDidModifyOrigin): Use reference
3730         and DatabaseTracker.
3731         (WebDatabaseManager::setQuota): Ditto.
3732         (WebDatabaseManager::dispatchDidModifyDatabase): Ditto.
3733         * WebDatabaseManager.h: Updated client functions to take a reference.
3734
3735         * WebSecurityOrigin.cpp:
3736         (WebSecurityOrigin::usage): Update to use DatabaseTracker.
3737         (WebSecurityOrigin::quota): Ditto.
3738         (WebSecurityOrigin::setQuota): Ditto.
3739
3740 2016-11-11  Eric Carlson  <eric.carlson@apple.com>
3741
3742         [MediaStream] defer resolution of getUserMedia promise made in a background tab
3743         https://bugs.webkit.org/show_bug.cgi?id=164643
3744         <rdar://problem/29048317>
3745
3746         Unreviewed build fix after r208606.
3747
3748         * Plugins/PluginView.cpp:
3749         (WebCore::PluginView::mediaCanStart):
3750         * Plugins/PluginView.h:
3751
3752 2016-11-11  Darin Adler  <darin@apple.com>
3753
3754         Move Node from ExceptionCode to ExceptionOr
3755         https://bugs.webkit.org/show_bug.cgi?id=164515
3756
3757         Reviewed by Sam Weinig.
3758
3759         * DOMCoreClasses.cpp:
3760         (DOMNode::insertBefore): Update exception handling.
3761         (DOMNode::removeChild): Ditto.
3762
3763 2016-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3764
3765         MemoryPressureHandler shouldn't know how to release WebCore memory
3766         https://bugs.webkit.org/show_bug.cgi?id=160497
3767
3768         Reviewed by Michael Catanzaro.
3769
3770         Set the low memory handler before installing the memory pressure handler.
3771
3772         * WebView.cpp:
3773         (WebView::initWithFrame):
3774
3775 2016-11-09  Alex Christensen  <achristensen@webkit.org>
3776
3777         Fix Windows build after r208499
3778         https://bugs.webkit.org/show_bug.cgi?id=164562
3779
3780         * WebKitDLL.cpp:
3781         (shutDownWebKit):
3782
3783 2016-11-09  Darin Adler  <darin@apple.com>
3784
3785         Move Range from ExceptionCode to ExceptionOr
3786         https://bugs.webkit.org/show_bug.cgi?id=164457
3787
3788         Reviewed by Alex Christensen.
3789
3790         * WebView.cpp:
3791         (WebView::onIMERequestCharPosition): Updated for new exception handling.
3792
3793 2016-11-09  Darin Adler  <darin@apple.com>
3794
3795         Move EventTarget from ExceptionCode to ExceptionOr
3796         https://bugs.webkit.org/show_bug.cgi?id=164465
3797
3798         Reviewed by Youenn Fablet.
3799
3800         * DOMCoreClasses.cpp:
3801         (DOMNode::dispatchEvent): Updated exception handling.
3802         (DOMWindow::dispatchEvent): Ditto.
3803
3804 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3805
3806         Safari does not emit composition end if blurred for dead key / Japanese IME
3807         https://bugs.webkit.org/show_bug.cgi?id=164369
3808         <rdar://problem/29050439>
3809
3810         Reviewed by Ryosuke Niwa.
3811
3812         Add a stub implementation of canceledComposition.
3813
3814         * WebCoreSupport/WebEditorClient.cpp:
3815         (WebEditorClient::canceledComposition):
3816         * WebCoreSupport/WebEditorClient.h:
3817
3818 2016-11-04  Per Arne Vollan  <pvollan@apple.com>
3819
3820         [Win] Page visibility tests are timing out.
3821         https://bugs.webkit.org/show_bug.cgi?id=164363
3822
3823         Reviewed by Brent Fulgham.
3824
3825         Add method to set page visibility.
3826
3827         * Interfaces/IWebViewPrivate.idl:
3828         * WebView.cpp:
3829         (WebView::QueryInterface):
3830         (WebView::findString):
3831         (WebView::setVisibilityState):
3832         * WebView.h:
3833
3834 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
3835
3836         Remove CUSTOM_ELEMENTS build flag
3837         https://bugs.webkit.org/show_bug.cgi?id=164267
3838
3839         Reviewed by Antti Koivisto.
3840
3841         Removed the build flag.
3842
3843         * WebView.cpp:
3844         (WebView::notifyPreferencesChanged):
3845
3846 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
3847
3848         JSC should support SharedArrayBuffer
3849         https://bugs.webkit.org/show_bug.cgi?id=163986
3850
3851         Reviewed by Keith Miller.
3852
3853         Support the RuntimeFlag.
3854
3855         * Interfaces/IWebPreferencesPrivate.idl:
3856
3857 2016-10-31  Joseph Pecoraro  <pecoraro@apple.com>
3858
3859         Use #pragma once in WebCore
3860         https://bugs.webkit.org/show_bug.cgi?id=164194
3861
3862         Rubber-stamped by Sam Weinig.
3863
3864         * WebCoreSupport/WebContextMenuClient.cpp:
3865         (WebContextMenuClient::isSpeaking):
3866         (WebContextMenuClient::shareMenuItem): Deleted.
3867         * WebCoreSupport/WebContextMenuClient.h:
3868         Remove this dead code since r192333.
3869
3870 2016-10-31  Darin Adler  <darin@apple.com>
3871
3872         Convert Document from ExceptionCode to Exception
3873         https://bugs.webkit.org/show_bug.cgi?id=164212
3874
3875         Reviewed by Alex Christensen.
3876
3877         * DOMCoreClasses.cpp:
3878         (DOMDocument::createElement): Updated exception handling.
3879         (DOMDocument::createEvent): Ditto.
3880
3881 2016-10-30  Darin Adler  <darin@apple.com>
3882
3883         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
3884         https://bugs.webkit.org/show_bug.cgi?id=164206
3885
3886         Reviewed by Chris Dumez.
3887
3888         * DOMCoreClasses.cpp:
3889         (DOMElement::setAttribute): Updated exception handling.
3890         * DOMHTMLClasses.cpp:
3891         (DOMHTMLElement::setInnerHTML): Ditto.
3892
3893 2016-10-30  Brent Fulgham  <bfulgham@apple.com>
3894
3895         Unreviewed build fix (Direct2D)
3896
3897         * WebView.cpp:
3898         (WebView::paintWithDirect2D): Update for revised GraphicsContext
3899         begin/end draw behavior.
3900
3901 2016-10-28  Darin Adler  <darin@apple.com>
3902
3903         Move all classes in the HTML directory from ExceptionCode to Exception
3904         https://bugs.webkit.org/show_bug.cgi?id=163876
3905
3906         Reviewed by Sam Weinig.
3907
3908         * DOMHTMLClasses.cpp:
3909         (DOMHTMLElement::setInnerText): Update exception handling.
3910         * FullscreenVideoController.cpp:
3911         (FullscreenVideoController::setVolume): Ditto.
3912
3913 2016-10-27  Brent Fulgham  <bfulgham@apple.com>
3914
3915         Unreviewed build fix.
3916
3917         * WebView.cpp:
3918         (WebView::paintWithDirect2D): Correct merge error.
3919
3920 2016-10-25  Brent Fulgham  <bfulgham@apple.com>
3921
3922         [Win][Direct2D] Create a RAII Helper Class for the Render Target
3923         https://bugs.webkit.org/show_bug.cgi?id=164005
3924
3925         Reviewed by Alex Christensen.
3926
3927         * WebView.cpp:
3928         (WebView::sizeChanged): Construct RenderTarget with higher-resolution display timer.
3929         (WebView::paintWithDirect2D): Revise to use new RenderTargetHelper class.
3930
3931 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3932
3933         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
3934         https://bugs.webkit.org/show_bug.cgi?id=163948
3935         <rdar://problem/28921433>
3936
3937         Reviewed by Darin Adler.
3938
3939         Add support for new drag and drop-related EditAction enum values.
3940
3941         * WebCoreSupport/WebEditorClient.cpp:
3942         (undoNameForEditAction):
3943
3944 2016-10-26  Brian Burg  <bburg@apple.com>
3945
3946         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
3947         https://bugs.webkit.org/show_bug.cgi?id=164046
3948
3949         Reviewed by Joseph Pecoraro.
3950
3951         * WebCoreSupport/WebInspectorClient.h:
3952
3953 2016-10-19  Alex Christensen  <achristensen@webkit.org>
3954
3955         Revert r207151
3956         https://bugs.webkit.org/show_bug.cgi?id=163675
3957
3958         Reviewed by Brent Fulgham.
3959
3960         * DefaultDownloadDelegate.h:
3961         * WebCoreSupport/WebFrameLoaderClient.cpp:
3962         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
3963         * WebCoreSupport/WebFrameNetworkingContext.cpp:
3964         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3965         * WebCoreSupport/WebFrameNetworkingContext.h:
3966         * WebCoreSupport/WebPlatformStrategies.cpp:
3967         * WebDownload.h:
3968         * WebError.cpp:
3969         (WebError::localizedDescription):
3970         (WebError::sslPeerCertificate):
3971         * WebError.h:
3972         * WebMutableURLRequest.cpp:
3973         (WebMutableURLRequest::mutableCopy):
3974         * WebURLAuthenticationChallenge.cpp:
3975         (WebURLAuthenticationChallenge::initWithProtectionSpace):
3976         (WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
3977         * WebURLResponse.cpp:
3978         (WebURLResponse::sslPeerCertificate):
3979         * WebURLResponse.h:
3980         * WebView.cpp:
3981         (WebView::setCacheModel):
3982         (WebView::canHandleRequest):
3983         (WebView::notifyPreferencesChanged):
3984         (updateSharedSettingsFromPreferencesIfNeeded):
3985
3986 2016-10-18  Darin Adler  <darin@apple.com>
3987
3988         Move many miscellaneous classes from ExceptionCode to Exception
3989         https://bugs.webkit.org/show_bug.cgi?id=163645
3990
3991         Reviewed by Ryosuke Niwa.
3992
3993         * DOMCoreClasses.cpp:
3994         (DOMDocument::getComputedStyle): Use ptr instead of get since the return
3995         value is now Ref instead of RefPtr.
3996
3997 2016-10-18  Anders Carlsson  <andersca@apple.com>
3998
3999         Try to fix the Windows build.
4000
4001         * WebHistoryItem.cpp:
4002         (WebHistoryItem::redirectURLs):
4003
4004 2016-10-18  Anders Carlsson  <andersca@apple.com>
4005
4006         Move some history specific HistoryItem code to WebHistoryItem
4007         https://bugs.webkit.org/show_bug.cgi?id=163567
4008
4009         Reviewed by Tim Horton.
4010
4011         Remove these, they aren't used.
4012
4013         * WebCoreSupport/WebFrameLoaderClient.cpp:
4014         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
4015         * WebHistory.cpp:
4016         (WebHistory::visitedURL):
4017         * WebHistoryItem.cpp:
4018         (WebHistoryItem::initFromDictionaryRepresentation):
4019         (WebHistoryItem::dictionaryRepresentation):
4020
4021 2016-10-16  Darin Adler  <darin@apple.com>
4022
4023         Move CSS classes from ExceptionCode to Exception
4024         https://bugs.webkit.org/show_bug.cgi?id=163494
4025
4026         Reviewed by Sam Weinig.
4027
4028         * DOMCSSClasses.cpp:
4029         (DOMCSSStyleDeclaration::setCssText): Remove ExceptionCode handling.
4030         (DOMCSSStyleDeclaration::setProperty): Ditto.
4031
4032 2016-10-12  Anders Carlsson  <andersca@apple.com>
4033
4034         Copy BackForwardList from WebCore to WebKit/win
4035         https://bugs.webkit.org/show_bug.cgi?id=163360
4036
4037         Reviewed by Alex Christensen.
4038
4039         Use our local BackForwardList class instead of WebCore::BackForwardList.
4040
4041         * BackForwardList.cpp: Added.
4042         * BackForwardList.h: Added.
4043         * WebBackForwardList.h:
4044         * WebView.cpp:
4045         (WebView::initWithFrame):
4046         (WebView::backForwardList):
4047
4048 2016-10-13  Anders Carlsson  <andersca@apple.com>
4049
4050         Get rid of the HistoryItemVector typedef
4051         https://bugs.webkit.org/show_bug.cgi?id=163398
4052
4053         Reviewed by Beth Dakin.
4054
4055         Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
4056
4057         * WebBackForwardList.cpp:
4058         (WebBackForwardList::backListWithLimit):
4059         (WebBackForwardList::forwardListWithLimit):
4060         * WebHistoryItem.cpp:
4061         (WebHistoryItem::children):
4062
4063 2016-10-12  Brent Fulgham  <bfulgham@apple.com>
4064
4065         [Win] Unreviewed build fix after r207218.
4066
4067         The CQ-landed patch used the old USE(CFNETWORK) compiler guard.
4068         It should be using USE(CFURLCONNECTION).
4069
4070         * WebCache.cpp: Missed one!
4071
4072 2016-10-12  Brent Fulgham  <bfulgham@apple.com>
4073
4074         [Win] Unreviewed build fix after r207218.
4075
4076         The CQ-landed patch used the old USE(CFNETWORK) compiler guard.
4077         It should be using USE(CFURLCONNECTION).
4078
4079         * WebCache.cpp:
4080         (WebCache::cacheFolder):
4081         (WebCache::setCacheFolder):
4082
4083 2016-10-12  Per Arne Vollan  <pvollan@apple.com>
4084
4085         [Win] Parallel DRTs are sharing preferences and cache.
4086         https://bugs.webkit.org/show_bug.cgi?id=163013
4087
4088         Reviewed by Brent Fulgham.
4089
4090         Make it possible for a WebKit client to use separate preferences and cache.
4091
4092         * Interfaces/IWebPreferencesPrivate.idl:
4093         * WebApplicationCache.cpp:
4094         (applicationCachePath):
4095         * WebCache.cpp:
4096         (WebCache::cacheFolder):
4097         (WebCache::setCacheFolder):
4098         * WebDatabaseManager.cpp:
4099         (databasesDirectory):
4100         * WebPreferences.cpp:
4101         (WebPreferences::applicationId):
4102         (WebPreferences::valueForKey):
4103         (WebPreferences::setValueForKey):
4104         (WebPreferences::save):
4105         (WebPreferences::QueryInterface):
4106         (WebPreferences::modernMediaControlsEnabled):
4107         (WebPreferences::setApplicationId):
4108         * WebPreferences.h:
4109         * WebView.cpp:
4110         (WebView::setCacheModel):
4111
4112 2016-10-11  Alex Christensen  <achristensen@webkit.org>
4113
4114         Remove dead networking code
4115         https://bugs.webkit.org/show_bug.cgi?id=163263
4116
4117         Reviewed by Daniel Bates.
4118
4119         * DefaultDownloadDelegate.h:
4120         * WebCoreSupport/WebFrameLoaderClient.cpp:
4121         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
4122         * WebCoreSupport/WebFrameNetworkingContext.cpp:
4123         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
4124         * WebCoreSupport/WebFrameNetworkingContext.h:
4125         * WebCoreSupport/WebPlatformStrategies.cpp:
4126         * WebDownload.h:
4127         * WebError.cpp:
4128         (WebError::localizedDescription):
4129         (WebError::sslPeerCertificate):
4130         * WebError.h:
4131         * WebMutableURLRequest.cpp:
4132         (WebMutableURLRequest::mutableCopy):
4133         * WebURLAuthenticationChallenge.cpp:
4134         (WebURLAuthenticationChallenge::initWithProtectionSpace):
4135         (WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
4136         * WebURLResponse.cpp:
4137         (WebURLResponse::sslPeerCertificate):
4138         * WebURLResponse.h:
4139         * WebView.cpp:
4140         (WebView::setCacheModel):
4141         (WebView::canHandleRequest):
4142         (WebView::notifyPreferencesChanged):
4143         (updateSharedSettingsFromPreferencesIfNeeded):
4144
4145 2016-10-11  Ryan Haddad  <ryanhaddad@apple.com>
4146
4147         Unreviewed, rolling out r207067.
4148
4149         This change caused webkitpy test failures.
4150
4151         Reverted changeset:
4152
4153         "[Win] Parallel DRTs are sharing preferences and cache."
4154         https://bugs.webkit.org/show_bug.cgi?id=163013
4155         http://trac.webkit.org/changeset/207067
4156
4157 2016-10-11  Per Arne Vollan  <pvollan@apple.com>
4158
4159         [Win] Parallel DRTs are sharing preferences and cache.
4160         https://bugs.webkit.org/show_bug.cgi?id=163013
4161
4162         Reviewed by Brent Fulgham.
4163
4164         Make it possible for a WebKit client to use separate preferences and cache.
4165
4166         * Interfaces/IWebPreferencesPrivate.idl:
4167         * WebApplicationCache.cpp:
4168         (applicationCachePath):