Remove redundant painting phase arguments from GraphicsLayerClient functions
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2019-09-03  Antti Koivisto  <antti@apple.com>
2
3         Remove redundant painting phase arguments from GraphicsLayerClient functions
4         https://bugs.webkit.org/show_bug.cgi?id=201443
5
6         Reviewed by Simon Fraser.
7
8         * WebView.cpp:
9         (WebView::paintContents):
10         * WebView.h:
11
12 2019-08-27  Mark Lam  <mark.lam@apple.com>
13
14         Refactor to use VM& instead of VM* at as many places as possible.
15         https://bugs.webkit.org/show_bug.cgi?id=201172
16
17         Reviewed by Yusuke Suzuki.
18
19         * WebFrame.cpp:
20         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
21
22 2019-08-21  Ryosuke Niwa  <rniwa@webkit.org>
23
24         Put keygen element behind a runtime flag and disable it by default
25         https://bugs.webkit.org/show_bug.cgi?id=200850
26
27         Reviewed by Antti Koivisto.
28
29         * Interfaces/IWebPreferencesPrivate.idl:
30         * WebPreferenceKeysPrivate.h:
31         * WebPreferences.cpp:
32         (WebPreferences::keygenElementEnabled):
33         (WebPreferences::setKeygenElementEnabled):
34         * WebPreferences.h:
35         * WebView.cpp:
36         (WebView::notifyPreferencesChanged):
37
38 2019-08-19  Fujii Hironori  <Hironori.Fujii@sony.com>
39
40         [WinCairo][WK1] A browser window starts as an inactive window because AcceleratedCompositingContext::acceleratedCompositingAvailable creates temporary window
41         https://bugs.webkit.org/show_bug.cgi?id=200493
42
43         Reviewed by Ross Kirsling.
44
45         Reverted r179962.
46
47         * WebCoreSupport/AcceleratedCompositingContext.cpp:
48         (AcceleratedCompositingContext::acceleratedCompositingAvailable): Deleted.
49         * WebCoreSupport/AcceleratedCompositingContext.h:
50         * WebView.cpp:
51         (WebView::notifyPreferencesChanged):
52
53 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
54
55         Remove IDB-specific quota
56         https://bugs.webkit.org/show_bug.cgi?id=196545
57         <rdar://problem/54201783>
58
59         Reviewed by Youenn Fablet.
60
61         * Interfaces/IWebDatabaseManager.idl:
62         * WebDatabaseManager.cpp:
63         (WebDatabaseManager::setIDBPerOriginQuota): Deleted.
64         * WebDatabaseManager.h:
65
66 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
67
68         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
69         https://bugs.webkit.org/show_bug.cgi?id=200620
70
71         Reviewed by Geoffrey Garen.
72
73         * FullscreenVideoController.cpp:
74         (FullscreenVideoController::FullscreenVideoController):
75         * Plugins/PluginStream.cpp:
76         (WebCore::PluginStream::didReceiveData):
77         * Plugins/PluginView.cpp:
78         (WebCore::PluginView::load):
79         * Plugins/PluginViewWin.cpp:
80         (WebCore::PluginView::wndProc):
81         * WebCoreSupport/WebChromeClient.cpp:
82         (WebChromeClient::WebChromeClient):
83         * WebCoreSupport/WebFrameLoaderClient.cpp:
84         (WebFrameLoaderClient::WebFrameLoaderClient):
85         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
86         * WebCoreSupport/WebInspectorClient.cpp:
87         (WebInspectorClient::openLocalFrontend):
88         (WebInspectorClient::highlight):
89         * WebElementPropertyBag.cpp:
90         (WebElementPropertyBag::WebElementPropertyBag):
91         * WebHistoryItem.cpp:
92         (WebHistoryItem::initFromDictionaryRepresentation):
93         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
94         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
95         * WebNotificationCenter.cpp:
96         (WebNotificationCenter::WebNotificationCenter):
97         * WebView.cpp:
98         (WebView::handleMouseEvent):
99         (WebView::registerEmbeddedViewMIMEType):
100         (WebView::enterVideoFullscreenForVideoElement):
101         (WebView::addUserScriptToGroup):
102         (WebView::addUserStyleSheetToGroup):
103         (WebView::setAcceleratedCompositing):
104
105 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
106
107         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
108         https://bugs.webkit.org/show_bug.cgi?id=200620
109
110         Reviewed by Geoffrey Garen.
111
112         * FullscreenVideoController.cpp:
113         * FullscreenVideoController.h:
114         * Plugins/PluginMessageThrottlerWin.h:
115         * WebCachedFramePlatformData.h:
116         * WebCoreSupport/AcceleratedCompositingContext.h:
117         * WebCoreSupport/WebChromeClient.h:
118         * WebCoreSupport/WebContextMenuClient.h:
119         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
120         * WebCoreSupport/WebDragClient.h:
121         * WebCoreSupport/WebEditorClient.h:
122         * WebCoreSupport/WebFrameLoaderClient.cpp:
123         * WebCoreSupport/WebGeolocationClient.h:
124         * WebCoreSupport/WebInspectorClient.h:
125         * WebDatabaseManager.cpp:
126         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
127         * WebNodeHighlight.h:
128         * WebNotificationCenter.cpp:
129         * WebNotificationCenter.h:
130
131 2019-08-15  Brent Fulgham  <bfulgham@apple.com>
132
133         [FTW] Enable CoreFoundation use if building for Apple target
134         https://bugs.webkit.org/show_bug.cgi?id=200799
135
136         Reviewed by Alex Christensen.
137
138         * FullscreenVideoController.cpp:
139         (FullscreenVideoController::FullscreenVideoController):
140         (FullscreenVideoController::enterFullscreen):
141         (FullscreenVideoController::exitFullscreen):
142         (FullscreenVideoController::createHUDWindow):
143         * FullscreenVideoController.h:
144         * WebView.cpp:
145         (WebView::exitFullscreenIfNeeded):
146
147 2019-08-15  Youenn Fablet  <youenn@apple.com>
148
149         Always create a Document with a valid SessionID
150         https://bugs.webkit.org/show_bug.cgi?id=200727
151
152         Reviewed by Alex Christensen.
153
154         Implement WebKit1 sessionID getter like done for WebKit2.
155         Either the loader client has a page in which case the page session ID is used
156         or the client has no page, in which case the default session ID is used.
157         This is the same behavior as CachedResourceLoader.
158
159         * WebCoreSupport/WebFrameLoaderClient.cpp:
160         (WebFrameLoaderClient::sessionID const):
161
162 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
163
164         Unreviewed, rolling out r248526.
165
166         Caused two IndexedDB perf tests to fail
167
168         Reverted changeset:
169
170         "Remove IDB-specific quota"
171         https://bugs.webkit.org/show_bug.cgi?id=196545
172         https://trac.webkit.org/changeset/248526
173
174 2019-08-14  Youenn Fablet  <youenn@apple.com>
175
176         ThreadableBlobRegistry::blobSize should take a SessionID as parameter
177         https://bugs.webkit.org/show_bug.cgi?id=200671
178
179         Reviewed by Alex Christensen.
180
181         * WebCoreSupport/WebPlatformStrategies.cpp:
182
183 2019-08-13  Youenn Fablet  <youenn@apple.com>
184
185         Blob registries should be keyed by session IDs
186         https://bugs.webkit.org/show_bug.cgi?id=200567
187         <rdar://problem/54120212>
188
189         Reviewed by Alex Christensen.
190
191         * WebCoreSupport/WebPlatformStrategies.cpp:
192         (WebPlatformStrategies::createBlobRegistry):
193
194 2019-08-12  Youenn Fablet  <youenn@apple.com>
195
196         Remove IDB-specific quota
197         https://bugs.webkit.org/show_bug.cgi?id=196545
198
199         Reviewed by Alex Christensen.
200
201         * Interfaces/IWebDatabaseManager.idl:
202         * WebDatabaseManager.cpp:
203         (WebDatabaseManager::setIDBPerOriginQuota): Deleted.
204         * WebDatabaseManager.h:
205
206 2019-08-09  Per Arne Vollan  <pvollan@apple.com>
207
208         [Win] Remove compiler workaround for VS2013
209         https://bugs.webkit.org/show_bug.cgi?id=200582
210
211         Reviewed by Don Olmstead.
212
213         A VS2013 compiler workaround can be removed now.
214
215         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp:
216         (DllMain):
217
218 2019-08-08  Per Arne Vollan  <pvollan@apple.com>
219
220         [Win] Fix internal build
221         https://bugs.webkit.org/show_bug.cgi?id=200519
222
223         Reviewed by Alex Christensen.
224
225         Switch to the String::wideCharacers method, since its return type is compatible with the Win32 api.
226
227         * WebDownloadCFNet.cpp:
228         (WebDownload::didFinish):
229
230 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
231
232         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
233         https://bugs.webkit.org/show_bug.cgi?id=200539
234         <rdar://problem/54082550>
235
236         Reviewed by Dean Jackson.
237
238         * AccessibleBase.cpp:
239         (AccessibleBase::get_locale):
240         * CFDictionaryPropertyBag.cpp:
241         (ConvertCFTypeToVariant):
242         (CFDictionaryPropertyBag::Read):
243         (CFDictionaryPropertyBag::Write):
244         * CFDictionaryPropertyBag.h:
245         * COMPropertyBag.h:
246         (HashType>::Read):
247         (HashType>::GetPropertyInfo):
248         * MarshallingHelpers.cpp:
249         * MarshallingHelpers.h:
250         * WebApplicationCache.cpp:
251         * WebArchive.cpp:
252         * WebArchive.h:
253         * WebCache.cpp:
254         * WebCoreSupport/WebFrameLoaderClient.cpp:
255         * WebDatabaseManager.cpp:
256         * WebHistory.cpp:
257         * WebHistoryItem.cpp:
258         * WebKitCOMAPI.cpp:
259         * WebKitCOMAPI.h:
260         * WebKitDLL.cpp:
261         * WebLocalizableStrings.cpp:
262         * WebLocalizableStrings.h:
263         * WebMutableURLRequest.cpp:
264         * WebPreferences.cpp:
265         * WebPreferences.h:
266         * WebView.cpp:
267         * WebView.h:
268
269 2019-08-08  Rob Buis  <rbuis@igalia.com>
270
271         Add runtime flag for lazy image loading
272         https://bugs.webkit.org/show_bug.cgi?id=199794
273
274         Reviewed by Darin Adler.
275
276         Set lazyImageLoading runtime flag if preference is set.
277
278         * Interfaces/IWebPreferencesPrivate.idl:
279         * WebPreferenceKeysPrivate.h:
280         * WebPreferences.cpp:
281         (WebPreferences::initializeDefaultSettings):
282         (WebPreferences::lazyImageLoadingEnabled):
283         (WebPreferences::setLazyImageLoadingEnabled):
284         * WebPreferences.h:
285         * WebView.cpp:
286         (WebView::notifyPreferencesChanged):
287
288 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
289
290         [Win][WK1] Can't change Web Inspector frontend height in high DPI
291         https://bugs.webkit.org/show_bug.cgi?id=200153
292
293         Reviewed by Don Olmstead.
294
295         * WebCoreSupport/WebInspectorClient.cpp:
296         (WebInspectorFrontendClient::setAttachedWindowHeight):
297         Applied deviceScaleFactor to the argument height.
298
299 2019-07-26  Konstantin Tokarev  <annulen@yandex.ru>
300
301         [Win] Remove unused methods from WebPluginInfoProvider
302         https://bugs.webkit.org/show_bug.cgi?id=200178
303
304         Reviewed by Brent Fulgham.
305
306         These methods are guarded with PLATFORM(MAC) and have no definitions.
307         Also remove unused friend declaration.
308
309         * WebCoreSupport/WebPluginInfoProvider.h:
310
311 2019-07-25  Fujii Hironori  <Hironori.Fujii@sony.com>
312
313         [Win][WK1] The inspected webview window is misplaced after changing Web Inspector frontend window height
314         https://bugs.webkit.org/show_bug.cgi?id=200152
315
316         Reviewed by Brent Fulgham.
317
318         In WebInspectorFrontendClient::setAttachedWindowHeight, the size
319         of m_inspectedWebViewHwnd was changed to the whole host window
320         size. But, it's too tall because MiniBrowser's host window has a
321         toolbar. The toolbar height should be taken into account.
322
323         Change to the height of m_inspectedWebViewHwnd to the sum of
324         inspected WebView and inspector frontend WebView heights.
325
326         * WebCoreSupport/WebInspectorClient.cpp:
327         (WebInspectorFrontendClient::setAttachedWindowHeight):
328
329 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
330
331         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
332         https://bugs.webkit.org/show_bug.cgi?id=200021
333         <rdar://problem/53301325>
334
335         Reviewed by Ryosuke Niwa.
336
337         Implement a new editing client hook.
338
339         * WebCoreSupport/WebEditorClient.h:
340
341 2019-07-13  Zalan Bujtas  <zalan@apple.com>
342
343         Cannot bring up custom media controls at all on v.youku.com
344         https://bugs.webkit.org/show_bug.cgi?id=199699
345         <rdar://problem/51835327>
346
347         Reviewed by Simon Fraser.
348
349         * WebActionPropertyBag.cpp:
350         (WebActionPropertyBag::Read):
351         * WebView.cpp:
352         (WebView::handleContextMenuEvent):
353         (WebView::elementAtPoint):
354
355 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
356
357         [WinCairo] ASSERTION FAILED: info.bmBitsPixel == 32 in createCairoContextWithHDC
358         https://bugs.webkit.org/show_bug.cgi?id=198323
359
360         Reviewed by Per Arne Vollan.
361
362         WebView::paint binds m_backingStoreBitmap to a DC by using
363         SelectObject. WebView::paint can be called recursively, but
364         m_backingStoreBitmap can't be bound to multiple DCs at the same
365         time. Then, SelectObject was failing in such case.
366
367         Call WebCore::Page::updateRendering before binding
368         m_backingStoreBitmap instead of after it.
369
370         Reverted r202744 change which won't be needed since this change.
371
372         * WebView.cpp:
373         (WebView::scrollBackingStore): Removed r202744's change.
374         (WebView::updateBackingStore): Removed m_page->updateRendering().
375         (WebView::paint): Do m_page->updateRendering() before binding m_backingStoreBitmap.
376         * WebView.h: Removed unused WebView::isPainting.
377
378 2019-07-02  Devin Rousso  <drousso@apple.com>
379
380         Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
381         https://bugs.webkit.org/show_bug.cgi?id=198956
382
383         Reviewed by Matt Baker.
384
385         * WebCoreSupport/WebInspectorClient.h:
386         * WebCoreSupport/WebInspectorClient.cpp:
387         (WebInspectorFrontendClient::resetWindowState): Added.
388
389 2019-06-30  Fujii Hironori  <Hironori.Fujii@sony.com>
390
391         [Win] Multiline mode of tooltip control does word-wrapping very slowly
392         https://bugs.webkit.org/show_bug.cgi?id=198989
393
394         Reviewed by Ross Kirsling.
395
396         * WebView.cpp:
397         (truncatedString): Added.
398         (WebView::setToolTip): Use truncatedString.
399
400 2019-06-16  Darin Adler  <darin@apple.com>
401
402         Rename AtomicString to AtomString
403         https://bugs.webkit.org/show_bug.cgi?id=195276
404
405         Reviewed by Michael Catanzaro.
406
407         * many files: Let do-webcore-rename do the renaming.
408
409 2019-05-31  Don Olmstead  <don.olmstead@sony.com>
410
411         [CMake] Add WebKit::WTF target
412         https://bugs.webkit.org/show_bug.cgi?id=198400
413
414         Reviewed by Konstantin Tokarev.
415
416         Use the WebKit::WTF target.
417
418         * WebKitQuartzCoreAdditions/CMakeLists.txt:
419
420 2019-05-30  Simon Fraser  <simon.fraser@apple.com>
421
422         Use an OptionSet<> for GraphicsLayerPaintingPhase
423         https://bugs.webkit.org/show_bug.cgi?id=198404
424
425         Reviewed by Tim Horton.
426
427         Replace GraphicsLayerPaintingPhase with OptionSet<GraphicsLayerPaintingPhase>.
428
429         No behavior change.
430
431         * WebCoreSupport/AcceleratedCompositingContext.cpp:
432         (AcceleratedCompositingContext::paintContents):
433         * WebCoreSupport/AcceleratedCompositingContext.h:
434         * WebView.cpp:
435         (WebView::paintContents):
436         * WebView.h:
437
438 2019-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
439
440         [iOS] Dropped text, attachments, and images should animate into place
441         https://bugs.webkit.org/show_bug.cgi?id=198243
442         <rdar://problem/35205373>
443
444         Reviewed by Tim Horton.
445
446         * WebCoreSupport/WebChromeClient.cpp:
447         (WebChromeClient::didFinishLoadingImageForElement):
448         * WebCoreSupport/WebChromeClient.h:
449
450 2019-05-03  Daniel Bates  <dabates@apple.com>
451
452         Pass KeyboardEvent by reference in more places
453         https://bugs.webkit.org/show_bug.cgi?id=197480
454
455         Reviewed by Wenson Hsieh.
456
457         * WebCoreSupport/WebEditorClient.cpp:
458         (WebEditorClient::handleKeyboardEvent):
459         (WebEditorClient::handleInputMethodKeydown):
460         * WebCoreSupport/WebEditorClient.h:
461         * WebView.cpp:
462         (WebView::handleEditingKeyboardEvent):
463         * WebView.h:
464
465 2019-05-02  Frederic Wang  <fwang@igalia.com>
466
467         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
468         https://bugs.webkit.org/show_bug.cgi?id=196142
469
470         This patch introduces some experimental runtime flag to let users
471         disable MathML features that are removed from MathML Core [1]. For now,
472         these features are only disabled on GTK and WPE ports.
473
474         [1] https://mathml-refresh.github.io/mathml-core/
475
476         Reviewed by Rob Buis.
477
478         * Interfaces/IWebPreferencesPrivate.idl:
479         * WebPreferenceKeysPrivate.h:
480         * WebPreferences.cpp:
481         (WebPreferences::initializeDefaultSettings):
482         (WebPreferences::coreMathMLEnabled):
483         (WebPreferences::setCoreMathMLEnabled):
484         * WebPreferences.h:
485         * WebView.cpp:
486         (WebView::notifyPreferencesChanged):
487
488 2019-04-24  Zalan Bujtas  <zalan@apple.com>
489
490         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
491         https://bugs.webkit.org/show_bug.cgi?id=196948
492         <rdar://problem/49927131>
493
494         Reviewed by Tim Horton.
495
496         * WebCoreSupport/WebChromeClient.cpp:
497         (WebChromeClient::intrinsicContentsSizeChanged const):
498         * WebCoreSupport/WebChromeClient.h:
499
500 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
501
502         Make it possible to control the renderTreeAsText output by setting options on testRunner
503         https://bugs.webkit.org/show_bug.cgi?id=197133
504
505         Reviewed by Sam Weinig.
506
507         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
508         that make sense in testing (those that don't dump unstable data like addresses), and plumb
509         these flags through the various framework layers.
510
511         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
512
513         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
514         and hand-code DumpRenderTree bindings.
515
516         Some cleanup of the TestRunners, using member initializers.
517
518         * Interfaces/IWebFramePrivate.idl:
519         * WebFrame.cpp:
520         (toRenderAsTextFlags):
521         (WebFrame::renderTreeAsExternalRepresentation):
522         (WebFrame::renderTreeAsExternalRepresentationForPrinting):
523         * WebFrame.h:
524
525 2019-04-23  Chris Dumez  <cdumez@apple.com>
526
527         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
528         https://bugs.webkit.org/show_bug.cgi?id=197097
529         <rdar://problem/50048318>
530
531         Reviewed by Alex Christensen.
532
533         * WebCoreSupport/WebFrameLoaderClient.cpp:
534         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
535         * WebCoreSupport/WebFrameLoaderClient.h:
536
537 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
538
539         [CMake][Win] Use target oriented design for WebKitLegacy
540         https://bugs.webkit.org/show_bug.cgi?id=197112
541
542         Reviewed by Konstantin Tokarev.
543
544         Fix an include directory.
545
546         * WebKitQuartzCoreAdditions/CMakeLists.txt:
547
548 2019-04-18  Jer Noble  <jer.noble@apple.com>
549
550         Refactoring: Pull all fullscreen code out of Document and into its own helper class
551         https://bugs.webkit.org/show_bug.cgi?id=197017
552
553         Reviewed by Eric Carlson.
554
555         * WebCoreSupport/WebChromeClient.cpp:
556         (WebChromeClient::createWindow):
557         * WebView.cpp:
558         (WebView::fullScreenClientWillEnterFullScreen):
559         (WebView::fullScreenClientDidEnterFullScreen):
560         (WebView::fullScreenClientWillExitFullScreen):
561         (WebView::fullScreenClientDidExitFullScreen):
562
563 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
564
565         requestAnimationFrame should execute before the next frame
566         https://bugs.webkit.org/show_bug.cgi?id=177484
567
568         Reviewed by Simon Fraser.
569
570         * WebView.cpp:
571         (WebView::updateBackingStore):
572         (WebView::flushPendingGraphicsLayerChangesSoon):
573         (WebView::flushPendingGraphicsLayerChanges):
574         Call Page::updateRendering() which implements "Update the rendering"
575         step of the HTML Event Loop specification.
576
577 2019-04-10  Devin Rousso  <drousso@apple.com>
578
579         Web Inspector: save sheet should be anchored underneath the tab bar when detached
580         https://bugs.webkit.org/show_bug.cgi?id=196722
581         <rdar://problem/49613280>
582
583         Reviewed by Timothy Hatcher.
584
585         * WebCoreSupport/WebInspectorClient.h:
586         * WebCoreSupport/WebInspectorClient.cpp:
587         (WebInspectorFrontendClient::setSheetRect): Added.
588
589 2019-04-10  Alex Christensen  <achristensen@webkit.org>
590
591         Add SPI WKNavigationResponse._downloadAttribute
592         https://bugs.webkit.org/show_bug.cgi?id=196755
593         <rdar://49587365>
594
595         Reviewed by Brady Eidson.
596
597         * WebCoreSupport/WebFrameLoaderClient.cpp:
598         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
599         * WebCoreSupport/WebFrameLoaderClient.h:
600
601 2019-04-05  Commit Queue  <commit-queue@webkit.org>
602
603         Unreviewed, rolling out r243833.
604         https://bugs.webkit.org/show_bug.cgi?id=196645
605
606         This change breaks build of WPE and GTK ports (Requested by
607         annulen on #webkit).
608
609         Reverted changeset:
610
611         "[CMake][WTF] Mirror XCode header directories"
612         https://bugs.webkit.org/show_bug.cgi?id=191662
613         https://trac.webkit.org/changeset/243833
614
615 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
616
617         [CMake][WTF] Mirror XCode header directories
618         https://bugs.webkit.org/show_bug.cgi?id=191662
619
620         Reviewed by Konstantin Tokarev.
621
622         * WebKitQuartzCoreAdditions/CMakeLists.txt:
623
624 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
625
626         Implement ResizeObserver.
627         https://bugs.webkit.org/show_bug.cgi?id=157743
628
629         Reviewed by Simon Fraser.
630
631         * Interfaces/IWebPreferencesPrivate.idl:
632         * WebPreferenceKeysPrivate.h:
633         * WebPreferences.cpp:
634         (WebPreferences::initializeDefaultSettings):
635         (WebPreferences::resizeObserverEnabled):
636         (WebPreferences::setResizeObserverEnabled):
637         * WebPreferences.h:
638         * WebView.cpp:
639         (WebView::notifyPreferencesChanged):
640
641 2019-03-17  Fujii Hironori  <Hironori.Fujii@sony.com>
642
643         [Win][WK1] Null dereference in WebFrameNetworkingContext::storageSession
644         https://bugs.webkit.org/show_bug.cgi?id=195741
645
646         Reviewed by Ross Kirsling.
647
648         * WebCoreSupport/WebFrameNetworkingContext.cpp:
649         (WebFrameNetworkingContext::storageSession const): Added a null check of frame()->page() as well as Mac port does (Bug 183455).
650
651 2019-03-13  Ryan Haddad  <ryanhaddad@apple.com>
652
653         Unreviewed attempt to fix the Windows build after r242920.
654
655         * WebCoreSupport/WebFrameLoaderClient.h:
656
657 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
658
659         [Win] Fix a slew of simple clang-cl warnings.
660         https://bugs.webkit.org/show_bug.cgi?id=195652
661
662         Reviewed by Don Olmstead.
663
664         * Interfaces/AccessibleComparable.idl: -Wmissing-braces
665         * Plugins/PluginDatabaseWin.cpp: -Wunused-function
666         (WebCore::addJavaPluginDirectory): Deleted.
667         * WebCoreSupport/AcceleratedCompositingContext.cpp:
668         (AcceleratedCompositingContext::AcceleratedCompositingContext): -Wreorder
669         * WebCoreSupport/WebEditorClient.cpp:
670         (WebEditorUndoCommand::WebEditorUndoCommand): -Wreorder
671         (undoNameForEditAction): -Wswitch
672         * WebCoreSupport/WebFrameLoaderClient.cpp:
673         (WebFrameLoaderClient::WebFrameLoaderClient): -Wswitch
674         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): -Wunused-variable
675         * WebCoreSupport/WebInspectorClient.cpp:
676         (WebInspectorFrontendClient::WebInspectorFrontendClient): -Wreorder
677         * WebCoreSupport/WebInspectorClient.h: -Winconsistent-missing-override
678         * WebError.cpp:
679         (WebError::WebError): -Wreorder
680         * WebFrame.cpp:
681         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): -Wlogical-op-parentheses
682         * WebHistory.cpp: -Wunused-function (x5)
683         (areEqualOrClose): Deleted.
684         (addDayToSystemTime): Deleted.
685         (getDayBoundaries): Deleted.
686         (beginningOfDay): Deleted.
687         (dateKey): Deleted.
688         * WebNotificationCenter.cpp:
689         (WebNotificationCenter::removeObserver): -Wunused-variable
690         * WebView.cpp: -Wunused-function, -Wreorder
691         (WebView::addVisitedLinks): -Wunused-variable
692
693 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
694
695         Unreviewed, rolling out r242688, r242643, r242624.
696
697         Caused multiple layout test failures and crashes on iOS and macOS.
698
699         Reverted changeset:
700
701         "requestAnimationFrame should execute before the next frame"
702         https://bugs.webkit.org/show_bug.cgi?id=177484
703         https://trac.webkit.org/changeset/242624/webkit
704
705         * WebView.cpp:
706         (WebView::updateBackingStore):
707         (WebView::flushPendingGraphicsLayerChangesSoon):
708         (WebView::flushPendingGraphicsLayerChanges):
709
710 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
711
712         requestAnimationFrame should execute before the next frame
713         https://bugs.webkit.org/show_bug.cgi?id=177484
714
715         Reviewed by Simon Fraser.
716
717         * WebView.cpp:
718         (WebView::updateBackingStore):
719         (WebView::flushPendingGraphicsLayerChangesSoon):
720         (WebView::flushPendingGraphicsLayerChanges):
721         Call Page::renderingUpdate() which implements  "Update the rendering"
722         step of the HTML Event Loop specification.
723
724 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
725
726         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
727         https://bugs.webkit.org/show_bug.cgi?id=195346
728
729         Reviewed by Fujii Hironori.
730
731         * COMPropertyBag.h:
732         (HashType>::GetPropertyInfo):
733         (HashType>::LoadObject):
734         * DOMCoreClasses.cpp:
735         (DOMNode::addEventListener):
736         (DOMNode::removeEventListener):
737         (DOMWindow::addEventListener):
738         (DOMWindow::removeEventListener):
739         (DOMElement::font):
740         * DOMHTMLClasses.cpp:
741         (DOMHTMLInputElement::setValueForUser):
742         (DOMHTMLInputElement::replaceCharactersInRange):
743         * Plugins/PluginDatabaseWin.cpp:
744         (WebCore::addPluginPathsFromRegistry):
745         (WebCore::PluginDatabase::getPluginPathsInDirectories const):
746         (WebCore::addMozillaPluginDirectories):
747         (WebCore::addWindowsMediaPlayerPluginDirectory):
748         (WebCore::addAdobeAcrobatPluginDirectory):
749         (WebCore::addJavaPluginDirectory):
750         (WebCore::safariPluginsDirectory):
751         (WebCore::addMacromediaPluginDirectories):
752         * Plugins/PluginPackageWin.cpp:
753         (WebCore::getVersionInfo):
754         (WebCore::PluginPackage::fetchInfo):
755         (WebCore::PluginPackage::load):
756         * Plugins/PluginViewWin.cpp:
757         (WebCore::PluginView::handlePostReadFile):
758         * WebCoreSupport/WebChromeClient.cpp:
759         (WebChromeClient::runOpenPanel):
760         * WebCoreSupport/WebEditorClient.cpp:
761         (WebEditorClient::checkSpellingOfString):
762         (WebEditorClient::checkGrammarOfString):
763         * WebCoreSupport/WebInspectorClient.cpp:
764         (WebInspectorFrontendClient::updateWindowTitle):
765         * WebLocalizableStrings.cpp:
766         (LocalizedString::operator LPCTSTR const):
767         * WebView.cpp:
768         (createContextMenuFromItems):
769         (WebView::setToolTip):
770         Use wchar helpers as needed.
771
772 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
773
774         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
775         https://bugs.webkit.org/show_bug.cgi?id=195053
776         <rdar://problem/48134710>
777
778         Reviewed by Ryosuke Niwa.
779
780         * WebCoreSupport/WebEditorClient.h:
781
782 2019-02-20  Darin Adler  <darin@apple.com>
783
784         Finish removing String::format
785         https://bugs.webkit.org/show_bug.cgi?id=194893
786
787         Reviewed by Daniel Bates.
788
789         * FullscreenVideoController.cpp:
790         (timeToString): Use makeString and pad.
791
792 2019-02-27  Simon Fraser  <simon.fraser@apple.com>
793
794         Roll out r242014; it caused crashes in compositing logging (webkit.org/b/195141)
795
796         * FullscreenVideoController.cpp:
797         (timeToString):
798
799 2019-02-26  Philippe Normand  <pnormand@igalia.com>
800
801         [WPE] Add API for webview background color configuration
802         https://bugs.webkit.org/show_bug.cgi?id=192305
803
804         Reviewed by Michael Catanzaro.
805
806         * WebCoreSupport/WebFrameLoaderClient.cpp:
807         (WebFrameLoaderClient::transitionToCommittedForNewPage): Create
808         FrameView with background color.
809
810 2019-02-20  Darin Adler  <darin@apple.com>
811
812         Finish removing String::format
813         https://bugs.webkit.org/show_bug.cgi?id=194893
814
815         Reviewed by Daniel Bates.
816
817         * FullscreenVideoController.cpp:
818         (timeToString): Use makeString and pad.
819
820 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
821
822         Input type "formatSetInlineTextDirection" is dispatched when changing paragraph-level text direction
823         https://bugs.webkit.org/show_bug.cgi?id=194703
824         <rdar://problem/48111775>
825
826         Reviewed by Ryosuke Niwa.
827
828         * WebCoreSupport/WebEditorClient.cpp:
829         (undoNameForEditAction):
830
831 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
832
833         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
834         https://bugs.webkit.org/show_bug.cgi?id=194670
835         <rdar://problem/39066529>
836
837         Reviewed by Tim Horton.
838
839         * WebCoreSupport/WebEditorClient.cpp:
840         (WebEditorClient::replacementURLForResource): Deleted.
841         * WebCoreSupport/WebEditorClient.h:
842
843 2019-02-10  Darin Adler  <darin@apple.com>
844
845         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
846         https://bugs.webkit.org/show_bug.cgi?id=194487
847
848         Reviewed by Daniel Bates.
849
850         * WebView.cpp:
851         (webKitVersionString): Use makeString instead of String::format.
852
853 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
854
855         Allow pages to trigger programmatic paste from script on iOS
856         https://bugs.webkit.org/show_bug.cgi?id=194271
857         <rdar://problem/47808810>
858
859         Reviewed by Ryosuke Niwa.
860
861         * WebCoreSupport/WebEditorClient.h:
862
863 2019-02-06  Daniel Bates  <dabates@apple.com>
864
865         Standardize on ControlKey instead of CtrlKey
866         https://bugs.webkit.org/show_bug.cgi?id=194317
867
868         Reviewed by Tim Horton.
869
870         * AccessibleBase.cpp:
871         (AccessibleBase::get_accKeyboardShortcut):
872         * WebView.cpp:
873         (WebView::keyDown):
874
875 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
876
877         PageOverlayController's layers should be created lazily
878         https://bugs.webkit.org/show_bug.cgi?id=194199
879         rdar://problem/46571593
880
881         Reviewed by Tim Horton.
882
883         Expose PageOverlayController::hasDocumentOverlays() and hasViewOverlays()
884         and use them to only parent the overlay-hosting layers when necessary.
885
886         For document overlays, RenderLayerCompositor::appendDocumentOverlayLayers() can
887         simply do nothing if there are none. Updates are triggered via Page::installedPageOverlaysChanged(),
888         which calls FrameView::setNeedsCompositingConfigurationUpdate() to trigger the root layer
889         compositing updates that parents the layerWithDocumentOverlays().
890
891         View overlays are added to the layer tree via the DrawingArea. When we go between having
892         none and some view overlays, Page::installedPageOverlaysChanged() calls attachViewOverlayGraphicsLayer()
893         on the ChromeClient, and the DrawingArea responds by calling updateRootLayers() and scheduling a
894         compositing flush (this has to be done manually because view overlay layers are outside the
895         subtree managed by RenderLayerCompositor).
896         
897         Now that GraphicsLayers are ref-counted, we can let the DrawingArea simply retain its m_viewOverlayRootLayer;
898         there is no need for RenderLayerCompositor::attachRootLayer()/detachRootLayer() to do anything with view
899         overlay layers. This implies that a page can navigate (new FrameView) and view overlays will persist, without
900         having to be manually removed and re-added. We can also remove the Frame argument to attachViewOverlayGraphicsLayer().
901
902         * WebCoreSupport/WebChromeClient.cpp:
903         (WebChromeClient::attachViewOverlayGraphicsLayer):
904         * WebCoreSupport/WebChromeClient.h:
905
906 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
907
908         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
909         https://bugs.webkit.org/show_bug.cgi?id=194189
910
911         Reviewed by Geoffrey Garen.
912
913         Pass the policy check identifier around functions and store it in WebFramePolicyListener
914         so that we can send it back to WebCore with the navigation policy decision.
915
916         * WebCoreSupport/WebFrameLoaderClient.cpp:
917         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
918         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
919         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
920         (WebFrameLoaderClient::dispatchWillSubmitForm):
921         (WebFrameLoaderClient::setUpPolicyListener):
922         * WebCoreSupport/WebFrameLoaderClient.h:
923
924 2019-01-31  Alex Christensen  <achristensen@webkit.org>
925
926         Revert r238819 which is unneeded and caused a performance regression.
927         https://bugs.webkit.org/show_bug.cgi?id=192272
928         <rdar://problem/46664625>
929
930         * WebCoreSupport/WebFrameLoaderClient.cpp:
931         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
932         * WebCoreSupport/WebFrameLoaderClient.h:
933
934 2019-01-31  Takashi Komori  <Takashi.Komori@sony.com>
935
936         [Curl] Fix DRT crash related to private browsing.
937         https://bugs.webkit.org/show_bug.cgi?id=193816
938
939         Reviewed by Alex Christensen.
940
941         * WebCoreSupport/WebFrameNetworkingContext.cpp:
942         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
943
944 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
945
946         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
947         https://bugs.webkit.org/show_bug.cgi?id=193941
948
949         Reviewed by Alex Christensen.
950
951         * Plugins/PluginMessageThrottlerWin.cpp:
952         * Plugins/PluginView.cpp:
953         * Plugins/PluginViewWin.cpp:
954
955 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
956
957         Move FileSystem to WTF
958         https://bugs.webkit.org/show_bug.cgi?id=193602
959
960         Reviewed by Yusuke Suzuki.
961
962         * Plugins/PluginDatabase.cpp:
963         * Plugins/PluginPackage.h:
964         * Plugins/PluginStream.h:
965         * WebApplicationCache.cpp:
966         * WebDatabaseManager.cpp:
967         * WebDownloadCurl.cpp:
968         * WebPreferences.cpp:
969         * WebView.cpp:
970
971 2019-01-22  Alex Christensen  <achristensen@webkit.org>
972
973         Move NetworkStorageSession ownership to NetworkProcess
974         https://bugs.webkit.org/show_bug.cgi?id=193580
975
976         Reviewed by Geoff Garen.
977
978         * WebCoreSupport/WebFrameNetworkingContext.cpp:
979         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
980         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
981         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
982         (WebFrameNetworkingContext::storageSession const):
983         * WebDownloadCFNet.cpp:
984         (WebDownload::didReceiveAuthenticationChallenge):
985         * WebPreferences.cpp:
986         (WebPreferences::clearNetworkLoaderSession):
987         (WebPreferences::switchNetworkLoaderToNewTestingSession):
988
989 2019-01-15  Darin Adler  <darin@apple.com>
990
991         Use references rather than pointers for register/unregister functions, and more
992         https://bugs.webkit.org/show_bug.cgi?id=175028
993
994         Reviewed by Daniel Bates.
995
996         * Plugins/PluginView.cpp:
997         (WebCore::PluginView::startOrAddToUnstartedList): Pass a reference.
998         (WebCore::PluginView::~PluginView): Ditto.
999         * WebView.cpp:
1000         (WebView::fullScreenClientWillEnterFullScreen): Ditto.
1001         (WebView::fullScreenClientDidEnterFullScreen): Ditto.
1002         (WebView::fullScreenClientDidExitFullScreen): Ditto.
1003
1004 2019-01-17  Per Arne Vollan  <pvollan@apple.com>
1005
1006         [Win][HighDPI] Repaint glitches when scrolling.
1007         https://bugs.webkit.org/show_bug.cgi?id=173152
1008         <rdar://problem/45269953>
1009
1010         Reviewed by Brent Fulgham.
1011
1012         Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
1013         delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
1014         Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
1015
1016         * WebView.cpp:
1017         (WebView::scrollBackingStore):
1018
1019 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1020
1021         Stop using NetworkStorageSession::storageSession in WebCore
1022         https://bugs.webkit.org/show_bug.cgi?id=193529
1023
1024         Reviewed by Tim Horton.
1025
1026         * WebView.cpp:
1027         (WebView::initWithFrame):
1028
1029 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1030
1031         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1032         https://bugs.webkit.org/show_bug.cgi?id=193368
1033
1034         Reviewed by Geoff Garen.
1035
1036         * WebDownloadCFNet.cpp:
1037         (WebDownload::didReceiveAuthenticationChallenge):
1038
1039 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1040
1041         Fix Windows build after r240014
1042         https://bugs.webkit.org/show_bug.cgi?id=161106
1043
1044         * WebView.cpp:
1045
1046 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1047
1048         Stop using CookiesStrategy
1049         https://bugs.webkit.org/show_bug.cgi?id=161106
1050
1051         Reviewed by Don Olmstead and Antti Koivisto.
1052
1053         * Plugins/PluginView.cpp:
1054         (WebCore::PluginView::getValueForURL):
1055         (WebCore::PluginView::setValueForURL):
1056         * WebCoreSupport/WebPlatformStrategies.cpp:
1057         (WebPlatformStrategies::createBlobRegistry):
1058         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1059         (WebPlatformStrategies::cookiesForDOM): Deleted.
1060         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1061         (WebPlatformStrategies::cookiesEnabled): Deleted.
1062         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1063         (WebPlatformStrategies::getRawCookies): Deleted.
1064         (WebPlatformStrategies::deleteCookie): Deleted.
1065         * WebCoreSupport/WebPlatformStrategies.h:
1066         * WebView.cpp:
1067         (WebView::initWithFrame):
1068
1069 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1070
1071         Stop using NetworkStorageSession in WebProcess
1072         https://bugs.webkit.org/show_bug.cgi?id=193236
1073
1074         Reviewed by Don Olmstead.
1075
1076         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1077         (WebFrameNetworkingContext::storageSession const):
1078         * WebCoreSupport/WebFrameNetworkingContext.h:
1079         * WebCoreSupport/WebPlatformStrategies.cpp:
1080         (WebPlatformStrategies::cookiesForDOM):
1081         (WebPlatformStrategies::setCookiesFromDOM):
1082         (WebPlatformStrategies::cookiesEnabled):
1083         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1084         (WebPlatformStrategies::getRawCookies):
1085         (WebPlatformStrategies::deleteCookie):
1086         * WebCoreSupport/WebPlatformStrategies.h:
1087
1088 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1089
1090         Unreviewed, rolling out r239727.
1091
1092         Broke API tests
1093
1094         Reverted changeset:
1095
1096         "Stop using NetworkStorageSession in WebProcess"
1097         https://bugs.webkit.org/show_bug.cgi?id=193236
1098         https://trac.webkit.org/changeset/239727
1099
1100 2018-12-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1101
1102         Remove "using namespace std;"
1103         https://bugs.webkit.org/show_bug.cgi?id=192973
1104
1105         Reviewed by Alex Christensen.
1106
1107         * FullscreenVideoController.cpp:
1108         * WebFrame.cpp:
1109         (WebFrame::drawFooter):
1110         * WebHistory.cpp:
1111         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
1112         * WebKitQuartzCoreAdditions/CAView.cpp:
1113         * WebView.cpp:
1114         (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
1115         (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
1116         (WebView::setCacheModel):
1117         (WebView::maxCacheModelInAnyInstance):
1118
1119 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1120
1121         Use Ref<> as much as possible
1122         https://bugs.webkit.org/show_bug.cgi?id=192808
1123
1124         Reviewed by Alex Christensen.
1125
1126         * Plugins/PluginDatabase.cpp:
1127         (WebCore::PluginDatabase::refresh):
1128         * Plugins/PluginView.cpp:
1129         (WebCore::PluginView::mediaCanStart):
1130         (WebCore::PluginView::performRequest):
1131         (WebCore::PluginView::bindingInstance):
1132         * Plugins/PluginView.h:
1133         * WebCoreSupport/WebFrameLoaderClient.cpp:
1134         (WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
1135         (WebFrameLoaderClient::createPlugin):
1136         (WebFrameLoaderClient::createJavaAppletWidget):
1137         * WebCoreSupport/WebFrameLoaderClient.h:
1138         * WebFrame.cpp:
1139         (WebFrame::loadData):
1140         (WebFrame::loadPlainTextString):
1141         (WebFrame::loadHTMLString):
1142         * WebFrame.h:
1143         * WebKitQuartzCoreAdditions/CAView.cpp:
1144         (WKQCA::CAView::create):
1145         * WebKitQuartzCoreAdditions/CAView.h:
1146         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
1147         (WKQCA::CVDisplayLink::create):
1148         * WebKitQuartzCoreAdditions/CVDisplayLink.h:
1149         * WebKitQuartzCoreAdditions/ImageConversion.cpp:
1150         (WKQCA::getImageCopy):
1151         * WebView.cpp:
1152         (WebView::addUserScriptToGroup):
1153         (WebView::addUserStyleSheetToGroup):
1154
1155 2018-12-20  Chris Dumez  <cdumez@apple.com>
1156
1157         Use Optional::valueOr() instead of Optional::value_or()
1158         https://bugs.webkit.org/show_bug.cgi?id=192933
1159
1160         Reviewed by Geoffrey Garen.
1161
1162         * WebSecurityOrigin.cpp:
1163         (WebSecurityOrigin::port):
1164
1165 2018-12-19  Chris Dumez  <cdumez@apple.com>
1166
1167         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1168         https://bugs.webkit.org/show_bug.cgi?id=192728
1169         <rdar://problem/46746779>
1170
1171         Reviewed by Geoff Garen.
1172
1173         * Plugins/*:
1174         * WebCoreSupport/*:
1175
1176 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1177
1178         [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag
1179         https://bugs.webkit.org/show_bug.cgi?id=192617
1180
1181         Reviewed by Alex Christensen.
1182
1183         * COMEnumVariant.h:
1184         (COMEnumVariant<ContainerType>::adopt): Removed 'typename' from non dependent names.
1185         (COMEnumVariant<ContainerType>::createInstance): Ditto.
1186         (COMEnumVariant<ContainerType>::Next): Prepend 'typename' for dependent names.
1187         * COMPropertyBag.h:
1188         (HashType>::createInstance): Removed 'typename' from non dependent names.
1189         (HashType>::adopt): Ditto.
1190         (HashType>::Read): Replaced dependent name 'HashMapType::const_iterator' with 'auto'.
1191         (HashType>::GetPropertyInfo): Ditto.
1192
1193 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1194
1195         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
1196         https://bugs.webkit.org/show_bug.cgi?id=192618
1197
1198         Reviewed by Alex Christensen.
1199
1200         Classes which implement COM interface usually doesn't need the
1201         virtual destructor because it has Release() virtual method to
1202         destruct itself.
1203
1204         Marked 'final' such classes to suppress clang-cl's compilation
1205         warnings.
1206
1207         * COMEnumVariant.h:
1208         * COMPropertyBag.h:
1209         * DefaultDownloadDelegate.h:
1210         * DefaultPolicyDelegate.h:
1211         * MemoryStream.h:
1212         * WebActionPropertyBag.h:
1213         * WebApplicationCache.h:
1214         * WebArchive.h:
1215         * WebBackForwardList.h:
1216         * WebCache.h:
1217         * WebCoreStatistics.h:
1218         * WebCoreSupport/WebEditorClient.cpp:
1219         * WebCoreSupport/WebInspectorDelegate.h:
1220         * WebDataSource.h:
1221         * WebDatabaseManager.cpp:
1222         * WebDatabaseManager.h:
1223         * WebDownload.h:
1224         * WebDropSource.h:
1225         * WebElementPropertyBag.h:
1226         * WebError.h:
1227         * WebFrame.cpp:
1228         * WebFrame.h:
1229         * WebFramePolicyListener.h:
1230         * WebGeolocationPolicyListener.h:
1231         * WebGeolocationPosition.h:
1232         * WebHTMLRepresentation.h:
1233         * WebHistory.h:
1234         * WebHistoryItem.h:
1235         * WebInspector.h:
1236         * WebJavaScriptCollector.h:
1237         * WebKitClassFactory.h:
1238         * WebKitMessageLoop.h:
1239         * WebKitStatistics.h:
1240         * WebMutableURLRequest.h:
1241         * WebNavigationData.h:
1242         * WebNotification.h:
1243         * WebNotificationCenter.h:
1244         * WebPreferences.h:
1245         * WebResource.h:
1246         * WebScriptWorld.h:
1247         * WebSecurityOrigin.h:
1248         * WebSerializedJSValue.h:
1249         * WebTextRenderer.h:
1250         * WebURLAuthenticationChallenge.h:
1251         * WebURLAuthenticationChallengeSender.h:
1252         * WebURLCredential.h:
1253         * WebURLProtectionSpace.h:
1254         * WebURLResponse.h:
1255         * WebUserContentURLPattern.h:
1256         * WebView.cpp:
1257         * WebView.h:
1258         * WebWorkersPrivate.h:
1259
1260 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1261
1262         [Win][Clang] Fix warning -Wmissing-field-initializers
1263         https://bugs.webkit.org/show_bug.cgi?id=192584
1264
1265         Reviewed by Yusuke Suzuki.
1266
1267         Initialize a struct with '{ }' instead of '= {0}'.
1268
1269         * WebKitMessageLoop.cpp:
1270         (WebKitMessageLoop::run):
1271         * WebView.cpp:
1272         (WebView::onMenuCommand):
1273         (WebView::gesture):
1274         (WebView::setShouldInvertColors):
1275         (WebView::initializeToolTipWindow):
1276         (WebView::setToolTip):
1277         (WebView::fullScreenClientForceRepaint):
1278
1279 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1280
1281         Turn WritingDirection into an enum class
1282         https://bugs.webkit.org/show_bug.cgi?id=192401
1283         Work towards <rdar://problem/42075638>
1284
1285         Reviewed by Dan Bernstein.
1286
1287         Change WritingDirection from an enum to an enum class. No change in behavior.
1288
1289         * WebFrame.cpp:
1290         (WebFrame::setTextDirection):
1291
1292 2018-12-03  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1293
1294         Use WallTime for file time
1295         https://bugs.webkit.org/show_bug.cgi?id=192287
1296
1297         Reviewed by Darin Adler.
1298
1299         * Plugins/PluginDatabase.cpp:
1300         (WebCore::PluginDatabase::refresh):
1301
1302 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1303
1304         Fix Windows build.
1305
1306         * WebView.cpp:
1307
1308 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1309
1310         Fix Windows build.
1311
1312         * WebCoreSupport/WebFrameLoaderClient.h:
1313
1314 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1315
1316         Fix Windows build.
1317
1318         * WebCoreSupport/WebFrameLoaderClient.h:
1319
1320 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1321
1322         Move URL from WebCore to WTF
1323         https://bugs.webkit.org/show_bug.cgi?id=190234
1324
1325         Reviewed by Keith Miller.
1326
1327         * MarshallingHelpers.cpp:
1328         * MarshallingHelpers.h:
1329         * Plugins/PluginDatabase.cpp:
1330         * Plugins/PluginDatabase.h:
1331         * Plugins/PluginDatabaseWin.cpp:
1332         * Plugins/PluginStream.h:
1333         * Plugins/PluginView.h:
1334         * WebCoreSupport/WebContextMenuClient.h:
1335         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
1336         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
1337         * WebCoreSupport/WebFrameLoaderClient.h:
1338         * WebCoreSupport/WebPlatformStrategies.h:
1339         * WebCoreSupport/WebPluginInfoProvider.cpp:
1340         (WebPluginInfoProvider::webVisiblePluginInfo):
1341         * WebCoreSupport/WebPluginInfoProvider.h:
1342         * WebCoreSupport/WebVisitedLinkStore.h:
1343         * WebDataSource.cpp:
1344         * WebDownload.h:
1345         * WebElementPropertyBag.cpp:
1346         * WebFrame.h:
1347         * WebHistory.cpp:
1348         * WebHistory.h:
1349         * WebHistoryItem.cpp:
1350         * WebResource.cpp:
1351         (WebResource::WebResource):
1352         * WebResource.h:
1353         * WebSecurityOrigin.cpp:
1354         * WebURLResponse.cpp:
1355         (WebURLResponse::createInstance):
1356         * WebUserContentURLPattern.cpp:
1357         * WebView.h:
1358
1359 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1360
1361         Remove dead code from an earlier attempt at implementing safe browsing
1362         https://bugs.webkit.org/show_bug.cgi?id=192067
1363
1364         Reviewed by Chris Dumez.
1365
1366         * WebCoreSupport/WebFrameLoaderClient.cpp:
1367         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1368         * WebCoreSupport/WebFrameLoaderClient.h:
1369
1370 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
1371
1372         [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
1373         https://bugs.webkit.org/show_bug.cgi?id=191959
1374
1375         Reviewed by Alex Christensen.
1376
1377         * MarshallingHelpers.h: Removed extra "MarshallingHelpers::" of windowsEpochAbsoluteTime declaration.
1378
1379 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
1380
1381         [Win] Reduce the use of WKSI library calls: CoreAnimation
1382         https://bugs.webkit.org/show_bug.cgi?id=191777
1383         <rdar://problem/46140542>
1384
1385         Reviewed by Zalan Bujtas.
1386
1387         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
1388         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
1389         directives for WebKitSystemInterface.lib.
1390
1391         * FullscreenVideoController.cpp:
1392         * WebKitGraphics.cpp:
1393         * WebPreferences.cpp:
1394
1395 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1396
1397         Address post-review feedback after r238438
1398         https://bugs.webkit.org/show_bug.cgi?id=191913
1399
1400         Reviewed by Ryosuke Niwa.
1401
1402         * AccessibleTextImpl.cpp:
1403         (AccessibleText::replaceText):
1404
1405 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1406
1407         Web Inspector: "Reload Web Inspector" button no longer partially works
1408         https://bugs.webkit.org/show_bug.cgi?id=191773
1409         <rdar://problem/46139932>
1410
1411         Reviewed by Devin Rousso.
1412
1413         * WebCoreSupport/WebInspectorClient.cpp:
1414         (WebInspectorFrontendClient::reopen):
1415         * WebCoreSupport/WebInspectorClient.h:
1416
1417 2018-11-17  Devin Rousso  <drousso@apple.com>
1418
1419         Web Inspector: Network: add button to show system certificate dialog
1420         https://bugs.webkit.org/show_bug.cgi?id=191458
1421         <rdar://problem/45977019>
1422
1423         Reviewed by Joseph Pecoraro.
1424
1425         * WebCoreSupport/WebInspectorClient.h:
1426         * WebCoreSupport/WebInspectorClient.cpp:
1427         (WebInspectorFrontendClient::showCertificate): Added.
1428
1429 2018-11-16  Brent Fulgham  <bfulgham@apple.com>
1430
1431         [Win] Reduce the use of WKSI library calls: CFNetwork
1432         https://bugs.webkit.org/show_bug.cgi?id=191718
1433         <rdar://problem/46108732>
1434
1435         Reviewed by Alex Christensen.
1436
1437         Remove custom WKSI CFNetwork calls, since the SPI is already documented in PAL. Just
1438         make the same calls on Windows, like we did for iOS and macOS back in 2017.
1439
1440         * WebCache.cpp:
1441         (WebCache::cacheFolder):
1442         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1443         * WebCoreSupport/WebPlatformStrategies.cpp:
1444         * WebError.cpp:
1445         (WebError::localizedDescription):
1446         (WebError::sslPeerCertificate):
1447         * WebURLResponse.cpp:
1448         (WebURLResponse::sslPeerCertificate):
1449         (WebURLResponse::certificateDictionary const):
1450         * WebView.cpp:
1451         (WebView::setCacheModel):
1452
1453 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
1454
1455         [Win] Reduce the use of WKSI library calls: Font Handling
1456         https://bugs.webkit.org/show_bug.cgi?id=191701
1457         <rdar://problem/46104809>
1458
1459         Reviewed by Myles C. Maxfield.
1460
1461         Update to use the old font handling routines moved from WKSI to FontCascade.
1462
1463         * WebPreferences.cpp:
1464         (WebPreferences::setFontSmoothing):
1465         (WebPreferences::setFontSmoothingContrast):
1466         * WebView.cpp:
1467         (systemParameterChanged):
1468
1469 2018-11-14  Timothy Hatcher  <timothy@apple.com>
1470
1471         Default the view background color and text color to different values when in dark mode.
1472         https://bugs.webkit.org/show_bug.cgi?id=191607
1473         rdar://problem/46045854
1474
1475         Reviewed by Dean Jackson.
1476
1477         * WebFrame.cpp:
1478         (WebFrame::updateBackground): Drop backgroundColor.
1479         * WebCoreSupport/WebFrameLoaderClient.cpp:
1480         (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor.
1481
1482 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1483
1484         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1485         https://bugs.webkit.org/show_bug.cgi?id=191612
1486
1487         Reviewed by Matt Baker.
1488
1489         * WebCoreSupport/WebInspectorClient.cpp:
1490         (WebInspectorFrontendClient::destroyInspectorView):
1491
1492 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
1493
1494         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
1495         https://bugs.webkit.org/show_bug.cgi?id=189230
1496         <rdar://problem/44050379>
1497
1498         Reviewed by Joseph Pecoraro.
1499
1500         Runs all png images through zopflipng. This results in a smaller file
1501         size and takes care of this issue as a byproduct.
1502
1503         * WebKit.resources/deleteButton.png:
1504         * WebKit.resources/deleteButtonPressed.png:
1505         * WebKit.resources/fsVideoAudioVolumeHigh.png:
1506         * WebKit.resources/fsVideoAudioVolumeLow.png:
1507         * WebKit.resources/fsVideoExitFullscreen.png:
1508         * WebKit.resources/fsVideoPause.png:
1509         * WebKit.resources/fsVideoPlay.png:
1510         * WebKit.resources/missingImage.png:
1511         * WebKit.resources/nullplugin.png:
1512         * WebKit.resources/panEastCursor.png:
1513         * WebKit.resources/panIcon.png:
1514         * WebKit.resources/panNorthCursor.png:
1515         * WebKit.resources/panNorthEastCursor.png:
1516         * WebKit.resources/panNorthWestCursor.png:
1517         * WebKit.resources/panSouthCursor.png:
1518         * WebKit.resources/panSouthEastCursor.png:
1519         * WebKit.resources/panSouthWestCursor.png:
1520         * WebKit.resources/panWestCursor.png:
1521         * WebKit.resources/searchCancel.png:
1522         * WebKit.resources/searchCancelPressed.png:
1523         * WebKit.resources/searchMagnifier.png:
1524         * WebKit.resources/searchMagnifierResults.png:
1525         * WebKit.resources/textAreaResizeCorner.png:
1526         * WebKit.resources/verticalTextCursor.png:
1527         * WebKit.resources/zoomInCursor.png:
1528         * WebKit.resources/zoomOutCursor.png:
1529
1530 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1531
1532         Unreviewed Windows build fix for r238049.
1533
1534         * WebView.cpp:
1535         (WebView::initWithFrame):
1536
1537 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1538
1539         Unreviewed MSVC build fix after r238039 (and r238046).
1540
1541         * WebDocumentLoader.h:
1542         * WebView.cpp:
1543         (WebView::setShouldApplyMacFontAscentHack):
1544
1545 2018-11-09  Antti Koivisto  <antti@apple.com>
1546
1547         Use OptionSet for layout milestones
1548         https://bugs.webkit.org/show_bug.cgi?id=191470
1549
1550         Reviewed by Dean Jackson.
1551
1552         * WebCoreSupport/WebFrameLoaderClient.cpp:
1553         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1554         * WebCoreSupport/WebFrameLoaderClient.h:
1555
1556 2018-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1557
1558         WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1559         https://bugs.webkit.org/show_bug.cgi?id=191455
1560
1561         Reviewed by Brent Fulgham.
1562
1563         * WebHistory.h: Marked with 'override' and removed 'virtual'.
1564
1565 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1566
1567         Add a storage limit for IndexedDB
1568         https://bugs.webkit.org/show_bug.cgi?id=190598
1569         <rdar://problem/44654715>
1570
1571         Reviewed by Chris Dumez.
1572
1573         * Interfaces/IWebDatabaseManager.idl:
1574         * WebDatabaseManager.cpp:
1575         (WebDatabaseManager::setIDBPerOriginQuota):
1576         * WebDatabaseManager.h:
1577
1578 2018-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1579
1580         [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
1581         https://bugs.webkit.org/show_bug.cgi?id=191105
1582
1583         Reviewed by Brent Fulgham.
1584
1585         * DOMHTMLClasses.h:
1586         (DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
1587         instead of own setNodeValue.
1588
1589 2018-10-25  Antoine Quint  <graouts@apple.com>
1590
1591         [Web Animations] Turn Web Animations CSS Integration off by default
1592         https://bugs.webkit.org/show_bug.cgi?id=190901
1593
1594         Reviewed by Dean Jackson.
1595
1596         * WebPreferences.cpp:
1597         (WebPreferences::initializeDefaultSettings):
1598
1599 2018-10-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1600
1601         [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1602         https://bugs.webkit.org/show_bug.cgi?id=190744
1603
1604         Reviewed by Alex Christensen.
1605
1606         clang-cl reports compilation warnings for inconsistent 'override'
1607         keyword usage.
1608
1609         WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
1610         This can't be marked 'override' if !USE(CA).
1611
1612         * WebView.cpp:
1613         (WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).
1614         * WebView.h: Marked all overriding member function declarations of WebView 'override'.
1615         Declare flushPendingGraphicsLayerChanges only if USE(CA).
1616
1617 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1618
1619         Clean up FrameLoader two-state enums
1620         https://bugs.webkit.org/show_bug.cgi?id=190731
1621
1622         Reviewed by Chris Dumez.
1623
1624         * WebCoreSupport/WebFrameLoaderClient.cpp:
1625         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1626         * WebCoreSupport/WebFrameLoaderClient.h:
1627
1628 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1629
1630         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1631         https://bugs.webkit.org/show_bug.cgi?id=190675
1632
1633         Reviewed by Chris Dumez.
1634
1635         * BackForwardList.cpp:
1636         (BackForwardList::backItem):
1637         (BackForwardList::currentItem):
1638         (BackForwardList::forwardItem):
1639         (BackForwardList::backListCount const):
1640         (BackForwardList::forwardListCount const):
1641         (BackForwardList::itemAtIndex):
1642         * BackForwardList.h:
1643
1644 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
1645
1646         Unreviewed attempt to fix the Windows build after r237112.
1647
1648         * Plugins/PluginView.cpp:
1649         (WebCore::PluginView::performRequest):
1650
1651 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1652
1653         Replace HistoryItem* with HistoryItem& where possible
1654         https://bugs.webkit.org/show_bug.cgi?id=190617
1655
1656         Reviewed by Chris Dumez.
1657
1658         * BackForwardList.cpp:
1659         (BackForwardList::goToItem):
1660         * BackForwardList.h:
1661         * WebBackForwardList.cpp:
1662         (WebBackForwardList::goToItem):
1663
1664 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1665
1666         Fix Windows build.
1667
1668         * WebView.cpp:
1669         (WebView::loadBackForwardListFromOtherView):
1670
1671 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1672
1673         Fix WinCairo build.
1674
1675         * WebView.cpp:
1676         (WebView::backForwardList):
1677
1678 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1679
1680         Modernize BackForwardClient.h
1681         https://bugs.webkit.org/show_bug.cgi?id=190610
1682
1683         Reviewed by Chris Dumez.
1684
1685         * BackForwardList.cpp:
1686         (BackForwardList::backListCount const):
1687         (BackForwardList::forwardListCount const):
1688         (BackForwardList::backListCount): Deleted.
1689         (BackForwardList::forwardListCount): Deleted.
1690         * BackForwardList.h:
1691         * WebView.cpp:
1692         (WebView::initWithFrame):
1693         (WebView::backForwardList):
1694
1695 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1696
1697         Remove unused WebView._globalHistoryItem
1698         https://bugs.webkit.org/show_bug.cgi?id=190601
1699
1700         Reviewed by Chris Dumez.
1701
1702         * WebCoreSupport/WebFrameLoaderClient.cpp:
1703         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1704         * WebCoreSupport/WebFrameLoaderClient.h:
1705         * WebView.cpp:
1706         (WebView::globalHistoryItem):
1707         (WebView::setGlobalHistoryItem): Deleted.
1708         * WebView.h:
1709
1710 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1711
1712         Remove unused parameters from FrameLoaderClient::createFrame
1713         https://bugs.webkit.org/show_bug.cgi?id=190587
1714
1715         Reviewed by Chris Dumez.
1716
1717         * WebCoreSupport/WebFrameLoaderClient.cpp:
1718         (WebFrameLoaderClient::createFrame):
1719         * WebCoreSupport/WebFrameLoaderClient.h:
1720
1721 2018-10-15  Chris Dumez  <cdumez@apple.com>
1722
1723         Unreviewed Windows build fix after r237112.
1724
1725         * Plugins/PluginView.cpp:
1726         (WebCore::PluginView::performRequest):
1727         (WebCore::PluginView::load):
1728
1729 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1730
1731         Remove InjectedBundle processing of back/forward lists
1732         https://bugs.webkit.org/show_bug.cgi?id=190459
1733
1734         Reviewed by Chris Dumez.
1735
1736         * WebCoreSupport/WebFrameLoaderClient.cpp:
1737         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1738         * WebCoreSupport/WebFrameLoaderClient.h:
1739
1740 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1741
1742         Remove ParsedURLString
1743         https://bugs.webkit.org/show_bug.cgi?id=190154
1744
1745         Reviewed by Chris Dumez.
1746
1747         * WebDownloadCurl.cpp:
1748         (WebDownload::initWithRequest):
1749         * WebURLResponse.cpp:
1750         (WebURLResponse::createInstance):
1751
1752 2018-09-28  Chris Dumez  <cdumez@apple.com>
1753
1754         Drop support for cross-origin-window-policy header
1755         https://bugs.webkit.org/show_bug.cgi?id=190081
1756
1757         Reviewed by Ryosuke Niwa.
1758
1759         * WebPreferenceKeysPrivate.h:
1760         * WebPreferences.cpp:
1761         (WebPreferences::initializeDefaultSettings):
1762         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1763         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1764         * WebView.cpp:
1765         (WebView::notifyPreferencesChanged):
1766
1767 2018-09-27  Antoine Quint  <graouts@apple.com>
1768
1769         [Web Animations] Turn Web Animations with CSS integration on
1770         https://bugs.webkit.org/show_bug.cgi?id=184819
1771         <rdar://problem/39597337>
1772
1773         Reviewed by Dean Jackson.
1774
1775         * WebPreferences.cpp:
1776         (WebPreferences::initializeDefaultSettings):
1777
1778 2018-09-21  Alex Christensen  <achristensen@webkit.org>
1779
1780         Use a Variant for FormDataElement
1781         https://bugs.webkit.org/show_bug.cgi?id=189777
1782
1783         Reviewed by Chris Dumez.
1784
1785         * WebMutableURLRequest.cpp:
1786         (WebMutableURLRequest::setHTTPBody):
1787
1788 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1789
1790         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
1791         https://bugs.webkit.org/show_bug.cgi?id=189612
1792
1793         Reviewed by Alex Christensen.
1794
1795         Non-trivial types can't be used as aruguments of LOG_ERROR and
1796         ASSERT_WITH_MESSAGE.
1797
1798         * DefaultPolicyDelegate.cpp:
1799         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
1800         static_cast<BSTR> to convert BString.
1801         * WebLocalizableStrings.cpp:
1802         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
1803         char* by using 'key.utf8().data()'.
1804
1805 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
1806
1807         Unreviewed, rolling out r235953.
1808
1809         Caused layout test crashes under GuardMalloc.
1810
1811         Reverted changeset:
1812
1813         "Make GraphicsLayers ref-counted, so their tree can persist
1814         when disconnected from RenderLayerBackings"
1815         https://bugs.webkit.org/show_bug.cgi?id=189521
1816         https://trac.webkit.org/changeset/235953
1817
1818 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1819
1820         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
1821         https://bugs.webkit.org/show_bug.cgi?id=189538
1822
1823         Reviewed by Per Arne Vollan.
1824
1825         * WebPreferences.cpp:
1826         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
1827         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
1828         Apply static_cast to the result of OR-ed CFPropertyListFormat.
1829         (WebPreferences::screenFontSubstitutionEnabled):
1830         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
1831
1832 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1833
1834         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
1835         https://bugs.webkit.org/show_bug.cgi?id=189539
1836
1837         Reviewed by Alex Christensen.
1838
1839         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
1840         * WebCoreSupport/WebInspectorClient.cpp:
1841         (WebInspectorWndProc): Ditto.
1842         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
1843         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
1844
1845 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1846
1847         Refactor WebCore::EditAction to be an 8-bit enum class
1848         https://bugs.webkit.org/show_bug.cgi?id=189383
1849
1850         Reviewed by Dan Bernstein.
1851
1852         * WebCoreSupport/WebEditorClient.cpp:
1853         (undoNameForEditAction):
1854
1855 2018-09-04  Frederic Wang  <fwang@igalia.com>
1856
1857         Add basic support for ScrollIntoViewOptions
1858         https://bugs.webkit.org/show_bug.cgi?id=189258
1859
1860         Reviewed by Simon Fraser.
1861
1862         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
1863         can build despite the new scrollIntoView function.
1864
1865 2018-08-31  Chris Dumez  <cdumez@apple.com>
1866
1867         Unreviewed Windows build fix after r235562.
1868
1869         * WebCoreSupport/WebFrameLoaderClient.cpp:
1870         (WebFrameLoaderClient::dispatchWillSubmitForm):
1871
1872 2018-08-31  Chris Dumez  <cdumez@apple.com>
1873
1874         Assertion hit in ~CompletionHandler() from ~WebFrame()
1875         https://bugs.webkit.org/show_bug.cgi?id=189199
1876         <rdar://problem/42657233>
1877
1878         Reviewed by Youenn Fablet.
1879
1880         * WebCoreSupport/WebFrameLoaderClient.cpp:
1881         (WebFrameLoaderClient::dispatchWillSubmitForm):
1882         * WebCoreSupport/WebFrameLoaderClient.h:
1883
1884 2018-08-31  Frederic Wang  <fwang@igalia.com>
1885
1886         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1887         https://bugs.webkit.org/show_bug.cgi?id=182053
1888
1889         Reviewed by Simon Fraser.
1890
1891         Add developer flag to use standard behavior for scrolling* attributes.
1892
1893         * Interfaces/IWebPreferencesPrivate.idl:
1894         * WebPreferenceKeysPrivate.h:
1895         * WebPreferences.cpp:
1896         (WebPreferences::initializeDefaultSettings):
1897         (WebPreferences::CSSOMViewScrollingAPIEnabled):
1898         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
1899         * WebPreferences.h:
1900         * WebView.cpp:
1901         (WebView::notifyPreferencesChanged):
1902
1903 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
1904
1905         [CMake] Replace AVFoundationSupport.py using CMake
1906         https://bugs.webkit.org/show_bug.cgi?id=182891
1907
1908         Reviewed by Per Arne Vollan.
1909
1910         Remove references to the config.h contained in WebCore as it should
1911         not be accessible from outside of WebCore.
1912
1913         * WebKitPrefix.h:
1914
1915 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1916
1917         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
1918         https://bugs.webkit.org/show_bug.cgi?id=188496
1919         <rdar://problem/43216836>
1920
1921         Reviewed by Tim Horton.
1922
1923         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
1924         header directly.
1925
1926         * WebCoreSupport/WebDragClient.cpp:
1927
1928 2018-08-17  Alex Christensen  <achristensen@webkit.org>
1929
1930         Add some plumbing for safe browsing
1931         https://bugs.webkit.org/show_bug.cgi?id=188709
1932
1933         Reviewed by Tim Horton.
1934
1935         * WebCoreSupport/WebFrameLoaderClient.cpp:
1936         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1937         * WebCoreSupport/WebFrameLoaderClient.h:
1938
1939 2018-08-02  David Fenton  <david_fenton@apple.com>
1940
1941         Unreviewed, rolling out r234489.
1942
1943         Caused 50+ crashes and 60+ API failures on iOS
1944
1945         Reverted changeset:
1946
1947         "[WTF] Rename String::format to String::deprecatedFormat"
1948         https://bugs.webkit.org/show_bug.cgi?id=188191
1949         https://trac.webkit.org/changeset/234489
1950
1951 2018-08-01  Tomas Popela  <tpopela@redhat.com>
1952
1953         [WTF] Rename String::format to String::deprecatedFormat
1954         https://bugs.webkit.org/show_bug.cgi?id=188191
1955
1956         Reviewed by Darin Adler.
1957
1958         It should be replaced with string concatenation.
1959
1960         * FullscreenVideoController.cpp:
1961         (timeToString):
1962         * WebView.cpp:
1963         (webKitVersionString):
1964
1965 2018-07-30  Rob Buis  <rbuis@igalia.com>
1966
1967         https://bugs.webkit.org/show_bug.cgi?id=188137
1968         Merge PlatformCookieJar functions into NetworkStorageSession
1969
1970         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1971
1972         Reviewed by Alex Christensen.
1973
1974         * WebCoreSupport/WebPlatformStrategies.cpp:
1975         (WebPlatformStrategies::cookiesForDOM):
1976         (WebPlatformStrategies::setCookiesFromDOM):
1977         (WebPlatformStrategies::cookiesEnabled):
1978         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1979         (WebPlatformStrategies::getRawCookies):
1980         (WebPlatformStrategies::deleteCookie):
1981         * WebPreferences.cpp:
1982         (WebPreferences::clearNetworkLoaderSession):
1983
1984 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
1985
1986         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
1987         https://bugs.webkit.org/show_bug.cgi?id=187963
1988
1989         Reviewed by Alex Christensen.
1990
1991         * Plugins/PluginPackageWin.cpp:
1992         (WebCore::PluginPackage::fetchInfo):
1993         Update split/splitAllowingEmptyEntries usage.
1994
1995 2018-07-18  Antoine Quint  <graouts@apple.com>
1996
1997         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
1998         https://bugs.webkit.org/show_bug.cgi?id=187722
1999
2000         Reviewed by Myles Maxfield.
2001
2002         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
2003
2004         * DOMCoreClasses.cpp:
2005         (DOMElement::font):
2006
2007 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
2008
2009         Disable cross-origin-window-policy by default
2010         https://bugs.webkit.org/show_bug.cgi?id=187509
2011
2012         Reviewed by Chris Dumez.
2013
2014         * WebPreferences.cpp:
2015         (WebPreferences::initializeDefaultSettings):
2016
2017 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2018
2019         [WTF] Add user-defined literal for ASCIILiteral
2020         https://bugs.webkit.org/show_bug.cgi?id=186839
2021
2022         Reviewed by Darin Adler.
2023
2024         * Plugins/PluginStream.cpp:
2025         (WebCore::PluginStream::startStream):
2026         * WebCoreSupport/WebContextMenuClient.cpp:
2027         (WebContextMenuClient::searchWithGoogle):
2028
2029 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2030
2031         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
2032         https://bugs.webkit.org/show_bug.cgi?id=186623
2033
2034         Reviewed by Youenn Fablet.
2035
2036         * WebCoreSupport/WebPluginInfoProvider.cpp:
2037         (WebPluginInfoProvider::pluginInfo):
2038         (WebPluginInfoProvider::webVisiblePluginInfo):
2039         * WebCoreSupport/WebPluginInfoProvider.h:
2040
2041 2018-06-13  Chris Dumez  <cdumez@apple.com>
2042
2043         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
2044         https://bugs.webkit.org/show_bug.cgi?id=186545
2045
2046         Reviewed by Brady Eidson.
2047
2048         Update client delegate now that parameter type has changed.
2049
2050         * WebCoreSupport/WebFrameLoaderClient.cpp:
2051         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2052         * WebCoreSupport/WebFrameLoaderClient.h:
2053
2054 2018-06-11  Chris Dumez  <cdumez@apple.com>
2055
2056         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
2057         https://bugs.webkit.org/show_bug.cgi?id=186441
2058
2059         Reviewed by Brady Eidson.
2060
2061         Rename existing flag to something a bit more generic, now that it is used for
2062         more things than bypassing the navigation policy check.
2063
2064         * WebView.cpp:
2065         (WebView::goToBackForwardItem):
2066         (WebView::loadBackForwardListFromOtherView):
2067
2068 2018-06-04  Chris Dumez  <cdumez@apple.com>
2069
2070         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
2071         https://bugs.webkit.org/show_bug.cgi?id=186287
2072         <rdar://problem/40783352>
2073
2074         Reviewed by Youenn Fablet.
2075
2076         * Interfaces/IWebPreferencesPrivate.idl:
2077         * WebPreferenceKeysPrivate.h:
2078         * WebPreferences.cpp:
2079         (WebPreferences::initializeDefaultSettings):
2080         (WebPreferences::crossOriginWindowPolicySupportEnabled):
2081         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
2082         * WebPreferences.h:
2083         * WebView.cpp:
2084         (WebView::notifyPreferencesChanged):
2085
2086 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2087
2088         [JSC] Pass VM& parameter as much as possible
2089         https://bugs.webkit.org/show_bug.cgi?id=186085
2090
2091         Reviewed by Saam Barati.
2092
2093         * Plugins/PluginPackage.cpp:
2094         (WebCore::NPN_Invoke):
2095
2096 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2097
2098         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
2099         https://bugs.webkit.org/show_bug.cgi?id=186125
2100
2101         Unreviewed build fix
2102
2103         * WebActionPropertyBag.cpp:
2104         (WebActionPropertyBag::Read):
2105         (findMouseEvent): Deleted.
2106
2107 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
2108
2109         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
2110         https://bugs.webkit.org/show_bug.cgi?id=186027
2111
2112         Unreviewed build fix
2113
2114         * WebMutableURLRequest.cpp:
2115         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
2116         (WebMutableURLRequest::setClientCertificate):
2117
2118 2018-05-25  Chris Dumez  <cdumez@apple.com>
2119
2120         Minor ApplicationCacheStorage clean up
2121         https://bugs.webkit.org/show_bug.cgi?id=185984
2122
2123         Reviewed by Youenn Fablet.
2124
2125         * WebApplicationCache.cpp:
2126         (WebApplicationCache::originsWithCache):
2127
2128 2018-05-24  Chris Dumez  <cdumez@apple.com>
2129
2130         Reduce copying of FontCascadeDescription objects by moving them around
2131         https://bugs.webkit.org/show_bug.cgi?id=185963
2132
2133         Reviewed by Simon Fraser.
2134
2135         Reduce copying of FontCascadeDescription objects by moving them around when possible.
2136
2137         * FullscreenVideoController.cpp:
2138         (FullscreenVideoController::draw):
2139
2140 2018-05-15  Antoine Quint  <graouts@apple.com>
2141
2142         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2143         https://bugs.webkit.org/show_bug.cgi?id=185647
2144
2145         Reviewed by Dean Jackson.
2146
2147         Rename the Web Animations CSS integration flag.
2148
2149         * Interfaces/IWebPreferencesPrivate.idl:
2150         * WebPreferenceKeysPrivate.h:
2151         * WebPreferences.cpp:
2152         (WebPreferences::initializeDefaultSettings):
2153         (WebPreferences::webAnimationsCSSIntegrationEnabled):
2154         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
2155         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
2156         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
2157         * WebPreferences.h:
2158         * WebView.cpp:
2159         (WebView::notifyPreferencesChanged):
2160
2161 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2162
2163         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
2164         https://bugs.webkit.org/show_bug.cgi?id=185505
2165
2166         Unreviewed serious crash fix
2167
2168         Windows port crashes soon since Bug 184996.
2169
2170         * WebPreferences.cpp:
2171         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
2172         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
2173
2174 2018-05-07  Daniel Bates  <dabates@apple.com>
2175
2176         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
2177         https://bugs.webkit.org/show_bug.cgi?id=185170
2178
2179         Reviewed by Per Arne Vollan.
2180
2181         * WebCache.cpp:
2182         (WebCache::empty):
2183
2184 2018-04-27  Chris Dumez  <cdumez@apple.com>
2185
2186         Use WindowProxy instead of DOMWindow in our IDL
2187         https://bugs.webkit.org/show_bug.cgi?id=185022
2188
2189         Reviewed by Sam Weinig.
2190
2191         * DOMCoreClasses.cpp:
2192         (DOMDocument::getComputedStyle):
2193
2194 2018-04-23  Daniel Bates  <dabates@apple.com>
2195
2196         Implement Same-Site cookies
2197         https://bugs.webkit.org/show_bug.cgi?id=159464
2198         <rdar://problem/27196358>
2199
2200         Reviewed by Brent Fulgham.
2201
2202         Pass the Same-Site info through the strategy.
2203
2204         * WebCoreSupport/WebPlatformStrategies.cpp:
2205         (WebPlatformStrategies::cookiesForDOM):
2206         (WebPlatformStrategies::setCookiesFromDOM):
2207         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2208         (WebPlatformStrategies::getRawCookies):
2209         * WebCoreSupport/WebPlatformStrategies.h:
2210
2211 2018-04-23  Daniel Bates  <dabates@apple.com>
2212
2213         Implement Same-Site cookies
2214         https://bugs.webkit.org/show_bug.cgi?id=159464
2215         <rdar://problem/27196358>
2216
2217         Reviewed by Brent Fulgham.
2218
2219         Pass the Same-Site info through the strategy.
2220
2221         * WebCoreSupport/WebPlatformStrategies.cpp:
2222         (WebPlatformStrategies::cookiesForDOM):
2223         (WebPlatformStrategies::setCookiesFromDOM):
2224         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2225         (WebPlatformStrategies::getRawCookies):
2226         * WebCoreSupport/WebPlatformStrategies.h:
2227
2228 2018-04-20  Youenn Fablet  <youenn@apple.com>
2229
2230         Make PluginData cache its web visible plugins
2231         https://bugs.webkit.org/show_bug.cgi?id=184421
2232
2233         Reviewed by Chris Dumez.
2234
2235         * WebCoreSupport/WebPluginInfoProvider.cpp:
2236         (WebPluginInfoProvider::pluginInfo):
2237         (WebPluginInfoProvider::webVisiblePluginInfo):
2238         * WebCoreSupport/WebPluginInfoProvider.h:
2239
2240 2018-04-19  Chris Dumez  <cdumez@apple.com>
2241
2242         Rename JSDOMWindowProxy to JSWindowProxy
2243         https://bugs.webkit.org/show_bug.cgi?id=184797
2244
2245         Reviewed by Sam Weinig.
2246
2247         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
2248
2249         * WebFrame.cpp:
2250         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2251
2252 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2253
2254         Unreviewed rollout of r230632. Regression in memory usage.
2255
2256         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2257
2258         * WebPreferences.cpp:
2259         (WebPreferences::initializeDefaultSettings):
2260
2261 2018-04-17  Chris Dumez  <cdumez@apple.com>
2262
2263         Unreviewed attempt to fix the Windows build after r230721
2264
2265         * WebCoreSupport/WebFrameLoaderClient.cpp:
2266         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2267
2268 2018-04-17  Chris Dumez  <cdumez@apple.com>
2269
2270         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
2271         https://bugs.webkit.org/show_bug.cgi?id=184678
2272         <rdar://problem/39422122>
2273
2274         Reviewed by Alex Christensen.
2275
2276         Add new parameter to dispatchDecidePolicyForNavigationAction.
2277
2278         * WebCoreSupport/WebFrameLoaderClient.cpp:
2279         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2280         * WebCoreSupport/WebFrameLoaderClient.h:
2281
2282 2018-04-12  Antoine Quint  <graouts@apple.com>
2283
2284         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
2285         https://bugs.webkit.org/show_bug.cgi?id=184569
2286         <rdar://problem/38671301>
2287
2288         Reviewed by Jon Lee.
2289
2290         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
2291
2292         * WebPreferences.cpp:
2293
2294 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2295
2296         [WTF] Remove StaticLock
2297         https://bugs.webkit.org/show_bug.cgi?id=184332
2298
2299         Reviewed by Mark Lam.
2300
2301         * WebKitQuartzCoreAdditions/CAView.cpp:
2302         (WKQCA::CAView::releaseAllD3DResources):
2303         * WebLocalizableStrings.cpp:
2304
2305 2018-04-03  Chris Dumez  <cdumez@apple.com>
2306
2307         Drop MainFrame class
2308         https://bugs.webkit.org/show_bug.cgi?id=184191
2309
2310         Reviewed by Darin Adler.
2311
2312         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
2313         relationship between the Page and the MainFrame.
2314
2315         This is ground work for introducing LocalFrame / RemoteFrame concepts.
2316
2317         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2318         * WebCoreSupport/WebContextMenuClient.cpp:
2319         * WebCoreSupport/WebDragClient.cpp:
2320         * WebDropSource.cpp:
2321         * WebFrame.cpp:
2322         * WebView.cpp:
2323
2324 2018-03-26  Chris Dumez  <cdumez@apple.com>
2325
2326         Use SecurityOriginData more consistently in Service Worker code
2327         https://bugs.webkit.org/show_bug.cgi?id=183969
2328
2329         Reviewed by Darin Adler.
2330
2331         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2332
2333         * WebDatabaseManager.cpp:
2334         (WebDatabaseManager::databasesWithOrigin):
2335         (WebDatabaseManager::deleteOrigin):
2336         (WebDatabaseManager::deleteDatabase):
2337         (WebDatabaseManager::setQuota):
2338         * WebSecurityOrigin.cpp:
2339         (WebSecurityOrigin::usage):
2340         (WebSecurityOrigin::quota):
2341         (WebSecurityOrigin::setQuota):
2342
2343 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
2344
2345         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
2346         https://bugs.webkit.org/show_bug.cgi?id=183911
2347         <rdar://problem/38762306>
2348
2349         Reviewed by Youenn Fablet.
2350
2351         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
2352
2353         * WebView.cpp:
2354         (WebView::WebView):
2355
2356 2018-03-25  Commit Queue  <commit-queue@webkit.org>
2357
2358         Unreviewed, rolling out r229954.
2359         https://bugs.webkit.org/show_bug.cgi?id=184000
2360
2361         Caused many layout tests to crash on Apple High Sierra,
2362         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
2363         by dydz on #webkit).
2364
2365         Reverted changeset:
2366
2367         "Use SecurityOriginData more consistently in Service Worker
2368         code"
2369         https://bugs.webkit.org/show_bug.cgi?id=183969
2370         https://trac.webkit.org/changeset/229954
2371
2372 2018-03-24  Chris Dumez  <cdumez@apple.com>
2373
2374         Use SecurityOriginData more consistently in Service Worker code
2375         https://bugs.webkit.org/show_bug.cgi?id=183969
2376
2377         Reviewed by Darin Adler.
2378
2379         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2380
2381         * WebDatabaseManager.cpp:
2382         (WebDatabaseManager::databasesWithOrigin):
2383         (WebDatabaseManager::deleteOrigin):
2384         (WebDatabaseManager::deleteDatabase):
2385         (WebDatabaseManager::setQuota):
2386         * WebSecurityOrigin.cpp:
2387         (WebSecurityOrigin::usage):
2388         (WebSecurityOrigin::quota):
2389         (WebSecurityOrigin::setQuota):
2390
2391 2018-03-23  Chris Dumez  <cdumez@apple.com>
2392
2393         Unreviewed attempt to fix Windows build after r229926.
2394
2395         * WebView.cpp:
2396
2397 2018-03-23  Brady Eidson  <beidson@apple.com>
2398
2399         Go to back/forward list items after a process-swapped navigation.
2400         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
2401
2402         Reviewed by Andy Estes.
2403
2404         * WebView.cpp:
2405         (WebView::goToBackForwardItem):
2406         (WebView::loadBackForwardListFromOtherView):
2407
2408 2018-03-23  Miguel Gomez  <magomez@igalia.com>
2409
2410         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
2411         https://bugs.webkit.org/show_bug.cgi?id=183892
2412
2413         Remove the UpdateContentsFlag parameter as it's not used anymore.
2414
2415         Reviewed by Žan Doberšek.
2416
2417         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2418         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
2419
2420 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
2421
2422         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
2423         https://bugs.webkit.org/show_bug.cgi?id=183335
2424
2425         Reviewed by Alex Christensen.
2426
2427         * Plugins/PluginDatabaseWin.cpp:
2428         * Plugins/PluginMessageThrottlerWin.cpp:
2429         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
2430         * Plugins/PluginPackageWin.cpp:
2431         (WebCore::PluginPackage::load):
2432         * Plugins/PluginView.h:
2433         * Plugins/PluginViewWin.cpp:
2434         * Plugins/npapi.cpp:
2435         * WebCoreSupport/WebFrameLoaderClient.cpp:
2436         (WebFrameLoaderClient::createPlugin):
2437         (WebFrameLoaderClient::createJavaAppletWidget):
2438         * WebView.cpp:
2439         (WebView::WebViewWndProc):
2440
2441 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
2442
2443         [Win] Layout Test fast/html/menuitem-element.html is failing.
2444         https://bugs.webkit.org/show_bug.cgi?id=179299
2445
2446         Reviewed by Per Arne Vollan.
2447
2448         * Interfaces/IWebPreferencesPrivate.idl:
2449         * WebPreferenceKeysPrivate.h:
2450         * WebPreferences.cpp:
2451         (WebPreferences::menuItemElementEnabled):
2452         (WebPreferences::setMenuItemElementEnabled):
2453         * WebPreferences.h:
2454         * WebView.cpp:
2455         (WebView::notifyPreferencesChanged):
2456         Add private web preference "menuItemElementEnabled".
2457
2458 2018-03-12  Antoine Quint  <graouts@apple.com>
2459
2460         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
2461         https://bugs.webkit.org/show_bug.cgi?id=183504
2462         <rdar://problem/38372965>
2463
2464         Reviewed by Dean Jackson and Jon Lee.
2465
2466         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
2467         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
2468
2469         * Interfaces/IWebPreferencesPrivate.idl:
2470         * WebPreferences.cpp:
2471         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2472         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2473         * WebPreferenceKeysPrivate.h
2474         * WebPreferences.h:
2475         * WebView.cpp:
2476         (WebView::notifyPreferencesChanged):
2477
2478 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2479
2480         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
2481         https://bugs.webkit.org/show_bug.cgi?id=183429
2482
2483         Reviewed by Mark Lam.
2484
2485         * WebFrame.cpp:
2486         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2487
2488 2018-03-08  Tim Horton  <timothy_horton@apple.com>
2489
2490         Stop linking ApplicationServices directly
2491         https://bugs.webkit.org/show_bug.cgi?id=182867
2492         <rdar://problem/38252142>
2493
2494         Reviewed by Alex Christensen.
2495
2496         The frameworks that we use that live inside ApplicationServices
2497         have mostly moved out, so import them directly.
2498
2499         * FullscreenVideoController.cpp:
2500
2501 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2502
2503         Fix std::make_unique / new[] using system malloc
2504         https://bugs.webkit.org/show_bug.cgi?id=182975
2505
2506         Reviewed by JF Bastien.
2507
2508         Use Vector instead.
2509
2510         * MarshallingHelpers.cpp:
2511         (MarshallingHelpers::safeArrayToStringArray):
2512         (MarshallingHelpers::safeArrayToIntArray):
2513         * Plugins/PluginPackageWin.cpp:
2514         (WebCore::PluginPackage::fetchInfo):
2515         * WebPreferences.cpp:
2516         (WebPreferences::copyWebKitPreferencesToCFPreferences):
2517         * WebView.cpp:
2518         (WebView::onMenuCommand):
2519
2520 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2521
2522         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
2523         https://bugs.webkit.org/show_bug.cgi?id=183312
2524
2525         Reviewed by Mark Lam.
2526
2527         Remove wtf/CurrentTime.h include pragma.
2528
2529         * WebDownload.cpp:
2530         * WebDownloadCFNet.cpp:
2531         * WebDropSource.cpp:
2532
2533 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2534
2535         Remove monotonicallyIncreasingTime
2536         https://bugs.webkit.org/show_bug.cgi?id=182911
2537
2538         Reviewed by Michael Catanzaro.
2539
2540         * FullscreenVideoController.cpp:
2541         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
2542         * Plugins/PluginMessageThrottlerWin.cpp:
2543         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
2544         (WebCore::PluginMessageThrottlerWin::appendMessage):
2545         * Plugins/PluginMessageThrottlerWin.h:
2546         * WebView.cpp:
2547         (WebView::notifyAnimationStarted):
2548         * WebView.h:
2549
2550 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2551
2552         [Win][DRT] Implement setSpatialNavigationEnabled.
2553         https://bugs.webkit.org/show_bug.cgi?id=183166
2554
2555         Reviewed by Per Arne Vollan.
2556
2557         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
2558
2559         * Interfaces/IWebPreferencesPrivate.idl:
2560         * WebPreferenceKeysPrivate.h:
2561         * WebPreferences.cpp:
2562         (WebPreferences::initializeDefaultSettings):
2563         (WebPreferences::spatialNavigationEnabled):
2564         (WebPreferences::setSpatialNavigationEnabled):
2565         * WebPreferences.h:
2566         * WebView.cpp:
2567         (WebView::notifyPreferencesChanged):
2568
2569 2018-02-28  Alex Christensen  <achristensen@webkit.org>
2570
2571         Reduce use of NetworkingContext in WebKit
2572         https://bugs.webkit.org/show_bug.cgi?id=183213
2573
2574         Reviewed by Brady Eidson.
2575
2576         * Plugins/PluginView.cpp:
2577         (WebCore::PluginView::getValueForURL):
2578
2579 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
2580
2581         Fix WebCore includes within WebKitLegacy
2582         https://bugs.webkit.org/show_bug.cgi?id=183147
2583
2584         Reviewed by Tim Horton.
2585
2586         * Plugins/PluginDatabase.cpp:
2587         * Plugins/PluginDatabaseWin.cpp:
2588         * Plugins/PluginDebug.cpp:
2589         * Plugins/PluginDebug.h:
2590         * Plugins/PluginMainThreadScheduler.cpp:
2591         * Plugins/PluginMessageThrottlerWin.cpp:
2592         * Plugins/PluginMessageThrottlerWin.h:
2593         * Plugins/PluginPackage.cpp:
2594         * Plugins/PluginPackage.h:
2595         * Plugins/PluginPackageWin.cpp:
2596         * Plugins/PluginStream.cpp:
2597         * Plugins/PluginStream.h:
2598         * Plugins/PluginView.cpp:
2599         * Plugins/PluginView.h:
2600         * Plugins/PluginViewWin.cpp:
2601         * Plugins/npapi.cpp:
2602         * WebCoreSupport/WebChromeClient.cpp:
2603         * WebCoreSupport/WebContextMenuClient.cpp:
2604         * WebCoreSupport/WebFrameLoaderClient.cpp:
2605         * WebCoreSupport/WebInspectorClient.cpp:
2606         * WebCoreSupport/WebPlatformStrategies.cpp:
2607         * WebFrame.cpp:
2608         * WebKitMessageLoop.cpp:
2609         * WebView.cpp:
2610         * storage/WebDatabaseProvider.cpp:
2611
2612 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2613
2614         Remove currentTime() / currentTimeMS()
2615         https://bugs.webkit.org/show_bug.cgi?id=183052
2616
2617         Reviewed by Mark Lam.
2618
2619         * WebCoreSupport/WebFrameLoaderClient.cpp:
2620         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2621         * WebCoreSupport/WebFrameLoaderClient.h:
2622         * WebDownload.h:
2623         * WebDownloadCFNet.cpp:
2624         (WebDownload::didStart):
2625         (WebDownload::didReceiveData):
2626         (WebDownload::didFinish):
2627
2628 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
2629
2630         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
2631         https://bugs.webkit.org/show_bug.cgi?id=182883
2632
2633         Reviewed by Per Arne Vollan.
2634
2635         * WebKitPrefix.h:
2636
2637 2018-02-16  Dean Jackson  <dino@apple.com>
2638
2639         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
2640         https://bugs.webkit.org/show_bug.cgi?id=182894
2641
2642         Reviewed by Tim Horton.
2643
2644         Rename OPENGL_ES_2 to OPENGL_ES.
2645
2646         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2647
2648 2018-02-16  Youenn Fablet  <youenn@apple.com>
2649
2650         Allow specifying which plug-ins are supported
2651         https://bugs.webkit.org/show_bug.cgi?id=182748
2652
2653         Reviewed by Chris Dumez.
2654
2655         * WebCoreSupport/WebPluginInfoProvider.cpp:
2656         (WebPluginInfoProvider::getPluginInfo):
2657         * WebCoreSupport/WebPluginInfoProvider.h:
2658
2659 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
2660
2661         WebCore headers should not be included relatively within dependent projects
2662         https://bugs.webkit.org/show_bug.cgi?id=182805
2663
2664         Reviewed by Chris Dumez.
2665
2666         * FullscreenVideoController.h:
2667
2668 2018-02-13  Commit Queue  <commit-queue@webkit.org>
2669
2670         Unreviewed, rolling out r228431.
2671         https://bugs.webkit.org/show_bug.cgi?id=182766
2672
2673         Regressed CMake build stability (Requested by dolmstead on
2674         #webkit).
2675
2676         Reverted changeset:
2677
2678         "[CMake] Make WebCore headers copies"
2679         https://bugs.webkit.org/show_bug.cgi?id=182512
2680         https://trac.webkit.org/changeset/228431
2681
2682 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
2683
2684         [CMake] Make WebCore headers copies
2685         https://bugs.webkit.org/show_bug.cgi?id=182512
2686
2687         Reviewed by Keith Miller.
2688
2689         * FullscreenVideoController.h:
2690         * Plugins/PluginDatabase.cpp:
2691         * Plugins/PluginDatabaseWin.cpp:
2692         * Plugins/PluginDebug.cpp:
2693         * Plugins/PluginMainThreadScheduler.cpp:
2694         * Plugins/PluginMessageThrottlerWin.cpp:
2695         * Plugins/PluginPackage.cpp:
2696         * Plugins/PluginPackageWin.cpp:
2697         * Plugins/PluginStream.cpp:
2698         * Plugins/PluginView.cpp:
2699         * Plugins/PluginViewWin.cpp:
2700         * Plugins/npapi.cpp:
2701         * WebKitMessageLoop.cpp:
2702         * WebKitPrefix.h:
2703         * storage/WebDatabaseProvider.cpp:
2704
2705 2018-01-13  Darin Adler  <darin@apple.com>
2706
2707         Event improvements
2708         https://bugs.webkit.org/show_bug.cgi?id=179591
2709
2710         Reviewed by Chris Dumez.
2711
2712         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
2713         * WebFrame.cpp: Ditto.
2714
2715         * WebScriptWorld.cpp:
2716         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
2717
2718         * WebView.cpp: Removed include of ScriptValue.h.
2719         (WebView::handleEditingKeyboardEvent): Updated for name change from
2720         keyEvent to underlyingPlatformEvent.
2721
2722 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
2723
2724         Remove WebCore/ForwardingHeaders directory
2725         https://bugs.webkit.org/show_bug.cgi?id=182347
2726
2727         Reviewed by Keith Miller.
2728
2729         * Plugins/PluginView.cpp:
2730         * Plugins/PluginViewWin.cpp:
2731         * WebCoreSupport/WebInspectorClient.cpp:
2732         * WebCoreSupport/WebInspectorClient.h:
2733         * WebFrame.cpp:
2734         * WebJavaScriptCollector.cpp:
2735         * WebView.cpp:
2736
2737 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2738
2739         Unreviewed, another attempt to fix the Windows build after r227479.
2740
2741         * WebFrame.cpp:
2742         (WebFrame::elementWithName):
2743
2744 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2745
2746         Unreviewed, try to fix the Windows build after r227479.
2747
2748         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
2749
2750         * WebFrame.cpp:
2751         (WebFrame::elementWithName):
2752         (WebFrame::controlsInForm):
2753
2754 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
2755
2756         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
2757         https://bugs.webkit.org/show_bug.cgi?id=181859
2758         <rdar://problem/36659886>
2759
2760         Reviewed by Alex Christensen.
2761         
2762         Use local include patch.
2763
2764         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
2765         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
2766         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
2767
2768 2018-01-17  Youenn Fablet  <youenn@apple.com>
2769
2770         Put fetch Request.keepalive behind a runtime flag
2771         https://bugs.webkit.org/show_bug.cgi?id=181592
2772
2773         Reviewed by Chris Dumez.
2774
2775         * WebPreferences.cpp:
2776         (WebPreferences::fetchAPIKeepAliveEnabled):
2777         (WebPreferences::setFetchAPIKeepAliveEnabled):
2778         * WebPreferences.h:
2779         * WebView.cpp:
2780         (WebView::notifyPreferencesChanged):
2781
2782 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2783
2784         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2785         https://bugs.webkit.org/show_bug.cgi?id=181637
2786         <rdar://problem/36508471>
2787
2788         Reviewed by Tim Horton.
2789
2790         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
2791
2792         * WebCoreSupport/WebEditorClient.cpp:
2793         (WebEditorClient::replacementURLForResource):
2794         * WebCoreSupport/WebEditorClient.h:
2795
2796 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2797
2798         Remove std::chrono completely
2799         https://bugs.webkit.org/show_bug.cgi?id=181186
2800
2801         Reviewed by Alex Christensen.
2802
2803         * Plugins/PluginStream.cpp:
2804         (WebCore::lastModifiedDateMS):
2805
2806 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2807
2808         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
2809         https://bugs.webkit.org/show_bug.cgi?id=181173
2810
2811         Reviewed by Alex Christensen.
2812
2813         * WebNodeHighlight.cpp:
2814         (WebNodeHighlight::update): Scale the GraphicsContext.
2815
2816 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2817
2818         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
2819         https://bugs.webkit.org/show_bug.cgi?id=181160
2820
2821         Reviewed by Myles C. Maxfield.
2822
2823         * Plugins/PluginView.cpp:
2824         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
2825
2826 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2827
2828         Enable picture-in-picture from inline element on suspend.
2829         https://bugs.webkit.org/show_bug.cgi?id=180942
2830         rdar://problem/34745234
2831
2832         Reviewed by Jer Noble.
2833
2834         Update signature of enterVideoFullscreenForVideoElement.
2835
2836         * WebCoreSupport/WebChromeClient.cpp:
2837         (WebChromeClient::enterVideoFullscreenForVideoElement):
2838         * WebCoreSupport/WebChromeClient.h:
2839
2840 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2841
2842         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
2843         https://bugs.webkit.org/show_bug.cgi?id=180926
2844
2845         Reviewed by Tim Horton.
2846
2847         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
2848         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
2849
2850         * WebCoreSupport/WebFrameLoaderClient.cpp:
2851         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
2852         (WebFrameLoaderClient::pageID const): Ditto.
2853
2854 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2855
2856         Remove unnecessary boolean result of start() functions
2857         https://bugs.webkit.org/show_bug.cgi?id=180856
2858
2859         Reviewed by Darin Adler.
2860
2861         It always returns true.
2862
2863         * WebDownloadCurl.cpp:
2864         (WebDownload::start):
2865
2866 2017-12-14  John Wilander  <wilander@apple.com>
2867
2868         Storage Access API: Implement frame-specific access in the document.cookie layer
2869         https://bugs.webkit.org/show_bug.cgi?id=180682
2870         <rdar://problem/35982257>
2871
2872         Reviewed by Alex Christensen.
2873
2874         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
2875         CookiesStrategy::cookieRequestHeaderFieldValue(), and
2876         CookiesStrategy::getRawCookies() now take optional parameters for
2877         frameID and pageID to allow frame-specific scoping of cookies.
2878
2879         This change makes the return values of FrameLoaderClient::frameID()
2880         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
2881         WebCore can call those getters and get the right return values in
2882         WebKit and std:nullopt in WebKitLegacy.
2883
2884         * WebCoreSupport/WebFrameLoaderClient.cpp:
2885         (WebFrameLoaderClient::pageID const):
2886         (WebFrameLoaderClient::frameID const):
2887             Now return an optional.
2888         * WebCoreSupport/WebFrameLoaderClient.h:
2889         * WebCoreSupport/WebPlatformStrategies.cpp:
2890         (WebPlatformStrategies::cookiesForDOM):
2891         (WebPlatformStrategies::setCookiesFromDOM):
2892         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2893         (WebPlatformStrategies::getRawCookies):
2894         * WebCoreSupport/WebPlatformStrategies.h:
2895
2896 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2897
2898         [WTF] Thread::create should have Thread::tryCreate
2899         https://bugs.webkit.org/show_bug.cgi?id=180333
2900
2901         Reviewed by Darin Adler.
2902
2903         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
2904         (WKQCA::CVDisplayLink::start):
2905
2906 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2907
2908         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
2909         https://bugs.webkit.org/show_bug.cgi?id=180572
2910
2911         Reviewed by Mark Lam.
2912
2913         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
2914         Also we use Lock instead of Mutex.
2915
2916         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
2917         (WKQCA::CAD3DRenderer::swapChain):
2918         (WKQCA::CAD3DRenderer::renderAndPresent):
2919         (WKQCA::CAD3DRenderer::renderToImage):
2920         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2921         (WKQCA::CAD3DRenderer::renderInternal):
2922         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
2923         * WebKitQuartzCoreAdditions/CAView.cpp:
2924         (WKQCA::CAView::Handle::create):
2925         Return Ref<Handle> instead of RefPtr<>.
2926
2927         (WKQCA::CAView::Handle::lock):
2928         (WKQCA::CAView::Handle::view const):
2929         (WKQCA::CAView::Handle::clear):
2930         (WKQCA::views):
2931         (WKQCA::viewsNeedingUpdate):
2932         (WKQCA::CAView::releaseAllD3DResources):
2933         (WKQCA::CAView::CAView):
2934         (WKQCA::CAView::~CAView):
2935         (WKQCA::CAView::setLayer):
2936         (WKQCA::CAView::update):
2937         (WKQCA::CAView::drawToWindow):
2938         (WKQCA::CAView::drawToWindowInternal):
2939         (WKQCA::CAView::drawToImage):
2940         (WKQCA::CAView::willDraw):
2941         (WKQCA::CAView::drawIntoDC):
2942         (WKQCA::CAView::setShouldInvertColors):
2943         (WKQCA::CAView::scheduleNextDraw):
2944         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2945         (WKQCA::CAView::contextDidChange):
2946         (WKQCA::CAView::updateSoon):
2947         (WKQCA::CAView::updateViewsNow):
2948         (WKQCA::CAView::d3dDevice9):
2949         (WKQCA::CAView::Handle::mutex): Deleted.
2950         (WKQCA::globalStateMutex): Deleted.
2951         (): Deleted.
2952         * WebKitQuartzCoreAdditions/CAView.h:
2953
2954 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2955
2956         Use StaticLock instead of NeverDestroyed<Lock>
2957         https://bugs.webkit.org/show_bug.cgi?id=180507
2958
2959         Reviewed by Saam Barati.
2960
2961         * WebLocalizableStrings.cpp:
2962         (findCachedString):
2963         (cacheString):
2964         (mainBundleLocStrings): Deleted.
2965         (frameworkLocStringsMutex): Deleted.
2966
2967 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
2968
2969         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
2970         https://bugs.webkit.org/show_bug.cgi?id=180431
2971         <rdar://problem/34531264>
2972
2973         Reviewed by Simon Fraser.
2974
2975         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
2976         'override' to make sure this doesn't break in the future.
2977
2978         * WebView.cpp:
2979         (WebView::notifyAnimationStarted):
2980         (WebView::paintContents):
2981         * WebView.h:
2982
2983 2017-11-23  Darin Adler  <darin@apple.com>
2984
2985         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2986         https://bugs.webkit.org/show_bug.cgi?id=179981
2987
2988         Reviewed by Sam Weinig.
2989
2990         * WebView.cpp:
2991         (WebView::searchFor): Use |= instead of | to build FindOptions.
2992         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
2993         (WebView::findString): Create FindOptions with |=; the old code just passed a
2994         WebKit FindOptions through without converting to WebCore::FindOptions.
2995
2996 2017-11-23  Darin Adler  <darin@apple.com>
2997
2998         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2999         https://bugs.webkit.org/show_bug.cgi?id=179907
3000
3001         Reviewed by Sam Weinig.
3002
3003         * Plugins/PluginDatabaseWin.cpp:
3004         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
3005         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
3006         * WebDownloadCFNet.cpp:
3007         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
3008
3009         * WebView.cpp:
3010         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
3011         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
3012         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
3013         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
3014         the code does not cause any change in behavior.
3015
3016 2017-11-22  Ali Juma  <ajuma@chromium.org>
3017
3018         Implement VisualViewport API attributes
3019         https://bugs.webkit.org/show_bug.cgi?id=179385
3020
3021         Reviewed by Frédéric Wang.
3022
3023         Add a VisualViewportAPI preference.
3024
3025         * Interfaces/IWebPreferencesPrivate.idl:
3026         * WebPreferenceKeysPrivate.h:
3027         * WebPreferences.cpp:
3028         (WebPreferences::initializeDefaultSettings):
3029         (WebPreferences::visualViewportAPIEnabled):
3030         (WebPreferences::setVisualViewportAPIEnabled):
3031         * WebPreferences.h:
3032         * WebView.cpp:
3033         (WebView::notifyPreferencesChanged):
3034
3035 2017-11-22  Commit Queue  <commit-queue@webkit.org>
3036
3037         Unreviewed, rolling out r225093.
3038         https://bugs.webkit.org/show_bug.cgi?id=179938
3039
3040         Compilation failed on WinCairo 64-bit Release (Requested by
3041         fredw on #webkit).
3042
3043         Reverted changeset:
3044
3045         "Implement VisualViewport API attributes"
3046         https://bugs.webkit.org/show_bug.cgi?id=179385
3047         https://trac.webkit.org/changeset/225093
3048
3049 2017-11-21  Ali Juma  <ajuma@chromium.org>
3050
3051         Implement VisualViewport API attributes
3052         https://bugs.webkit.org/show_bug.cgi?id=179385
3053
3054         Reviewed by Frédéric Wang.
3055
3056         Add a VisualViewportAPI preference.
3057
3058         * Interfaces/IWebPreferencesPrivate.idl:
3059         * WebPreferenceKeysPrivate.h:
3060         * WebPreferences.cpp:
3061         (WebPreferences::initializeDefaultSettings):
3062         (WebPreferences::visualViewportAPIEnabled):
3063         (WebPreferences::setVisualViewportAPIEnabled):
3064         * WebPreferences.h:
3065         * WebView.cpp:
3066         (WebView::notifyPreferencesChanged):
3067
3068 2017-11-14  Alex Christensen  <achristensen@webkit.org>
3069
3070         Clean up old URL parser remnants
3071         https://bugs.webkit.org/show_bug.cgi?id=179573
3072
3073         Reviewed by Darin Adler.
3074
3075         * WebCoreSupport/WebContextMenuClient.cpp:
3076         (WebContextMenuClient::searchWithGoogle):
3077         Use https if we do end up searching with google.
3078
3079 2017-11-12  Darin Adler  <darin@apple.com>
3080
3081         More is<> and downcast<>, less static_cast<>
3082         https://bugs.webkit.org/show_bug.cgi?id=179600
3083
3084         Reviewed by Chris Dumez.
3085
3086         * WebView.cpp:
3087         (WebView::handleEditingKeyboardEvent): Use downcast.
3088
3089 2017-11-09  Christopher Reid  <chris.reid@sony.com>
3090
3091         Use enum classes within FileSystem
3092         https://bugs.webkit.org/show_bug.cgi?id=175172
3093
3094         Reviewed by Darin Adler.
3095
3096         * Plugins/PluginDatabase.cpp:
3097
3098 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
3099
3100         [Win] Add WebKitQuartzCoreAdditions library.
3101         https://bugs.webkit.org/show_bug.cgi?id=179331
3102
3103         Reviewed by Alex Christensen.
3104
3105         * WebKitQuartzCoreAdditions: Added.
3106         * WebKitQuartzCoreAdditions/API: Added.
3107         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
3108         (toImage):
3109         (WKCACFImageGetWidth):
3110         (WKCACFImageGetHeight):
3111         (WKCACFImageCopyFileMapping):
3112         (WKCACFImageCreateWithImage):
3113         (WKCACFImageFinalize):
3114         (WKCACFImageCopyFormattingDescription):
3115         (WKCACFImageCopyDebugDescription):
3116         (WKCACFImageGetTypeID):
3117         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
3118         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
3119         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
3120         (toView):
3121         (toImpl):
3122         (WKCACFViewCreate):
3123         (WKCACFViewSetLayer):
3124         (WKCACFViewUpdate):
3125         (WKCACFViewFlushContext):
3126         (WKCACFViewInvalidateRects):
3127         (WKCACFViewCanDraw):
3128         (WKCACFViewDraw):
3129         (WKCACFViewCopyDrawnImage):
3130         (WKCACFViewDrawIntoDC):
3131         (contextDidChangeCallback):
3132         (WKCACFViewSetContextDidChangeCallback):
3133         (WKCACFViewGetLastCommitTime):
3134         (WKCACFViewSetContextUserData):
3135         (WKCACFViewGetContext):
3136         (WKCACFViewFinalize):
3137         (WKCACFViewCopyFormattingDescription):
3138         (WKCACFViewCopyDebugDescription):
3139         (WKCACFViewGetTypeID):
3140         (WKCACFViewSetShouldInvertColors):
3141         (WKCACFViewGetD3DDevice9):
3142         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
3143         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
3144         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
3145         (WKQCA::dllInstance):
3146         (DllMain):
3147         (WKCACFShutDown):
3148         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
3149         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
3150         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
3151         (WKQCA::d3d):
3152         (WKQCA::initialPresentationParameters):
3153         (WKQCA::CAD3DRenderer::shared):
3154         (WKQCA::CAD3DRenderer::CAD3DRenderer):
3155         (WKQCA::CAD3DRenderer::swapChain):
3156         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
3157         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
3158         (WKQCA::CAD3DRenderer::initialize):
3159         (WKQCA::D3DMatrixOrthoOffCenterRH):
3160         (WKQCA::prepareDevice):
3161         (WKQCA::updateBounds):
3162         (WKQCA::CAD3DRenderer::renderAndPresent):
3163         (WKQCA::CAD3DRenderer::renderToImage):
3164         (WKQCA::CAD3DRenderer::setDeviceIsLost):
3165         (WKQCA::CAD3DRenderer::renderInternal):
3166         (WKQCA::CAD3DRenderer::postProcess):
3167         (WKQCA::CAD3DRenderer::resetD3DDevice):
3168         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
3169         (WKQCA::CAD3DRenderer::release):
3170         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
3171         (WKQCA::D3DPostProcessingContext::sceneTexture const):
3172         (WKQCA::D3DPostProcessingContext::overlayQuad const):
3173         (WKQCA::CAD3DRenderer::d3dDevice9 const):
3174         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
3175         (WKQCA::CAView::Handle::create):
3176         (WKQCA::CAView::Handle::~Handle):
3177         (WKQCA::CAView::Handle::mutex):
3178         (WKQCA::CAView::Handle::view const):
3179         (WKQCA::CAView::Handle::clear):
3180         (WKQCA::CAView::Handle::Handle):
3181         (WKQCA::globalStateMutex):
3182         (WKQCA::registerMessageWindowClass):
3183         (WKQCA::createMessageWindow):
3184         (WKQCA::CAView::releaseAllD3DResources):
3185         (WKQCA::CAView::CAView):
3186         (WKQCA::CAView::~CAView):
3187         (WKQCA::CAView::create):
3188         (WKQCA::CAView::setContextDidChangeCallback):
3189         (WKQCA::CAView::setLayer):
3190         (WKQCA::CAView::update):
3191         (WKQCA::CAView::invalidateRects):
3192         (WKQCA::CAView::drawToWindow):
3193         (WKQCA::CAView::drawToWindowInternal):
3194         (WKQCA::CAView::drawToImage):
3195         (WKQCA::CAView::willDraw):
3196         (WKQCA::CAView::didDraw):
3197         (WKQCA::CAView::drawIntoDC):
3198         (WKQCA::CAView::setShouldInvertColors):
3199         (WKQCA::CAView::scheduleNextDraw):
3200         (WKQCA::CAView::displayLinkReachedCAMediaTime):
3201         (WKQCA::CAView::contextDidChangeCallback):
3202         (WKQCA::CAView::contextDidChange):
3203         (WKQCA::CAView::updateSoon):
3204         (WKQCA::CAView::updateViewsNow):
3205         (WKQCA::CAView::d3dDevice9):
3206         * WebKitQuartzCoreAdditions/CAView.h: Added.
3207         (WKQCA::CAView::context const):
3208         (WKQCA::CAView::canDraw const):
3209         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
3210         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
3211         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
3212         (WKQCA::CVDisplayLink::CVDisplayLink):
3213         (WKQCA::CVDisplayLink::~CVDisplayLink):
3214         (WKQCA::CVDisplayLink::create):
3215         (WKQCA::CVDisplayLink::start):
3216         (WKQCA::CVDisplayLink::stop):
3217         (WKQCA::CVDisplayLink::setPaused):
3218         (WKQCA::CVDisplayLink::runIOThread):
3219         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
3220         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
3221         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
3222         * WebKitQuartzCoreAdditions/Image.cpp: Added.
3223         (WKQCA::numBytesForSize):
3224         (WKQCA::Image::create):
3225         (WKQCA::Image::Image):
3226         (WKQCA::Image::~Image):
3227         (WKQCA::bitmapInfo):
3228         (WKQCA::Image::createDIB const):
3229         (WKQCA::Image::copyFileMapping):
3230         * WebKitQuartzCoreAdditions/Image.h: Added.
3231         (WKQCA::Image::size const):
3232         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
3233         (WKQCA::getBackBufferRectAsRenderTarget):
3234         (WKQCA::getSystemMemoryCopy):
3235         (WKQCA::copyRectToBitmap):
3236         (WKQCA::getImageCopy):
3237         (WKQCA::getBackBufferRectAsImage):
3238         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
3239         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
3240         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
3241         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
3242         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
3243
3244 2017-11-06  Christopher Reid  <chris.reid@sony.com>
3245
3246         Use enum classes within FileSystem
3247         https://bugs.webkit.org/show_bug.cgi?id=175172
3248
3249         Reviewed by Myles C. Maxfield.
3250
3251         * Plugins/PluginDatabase.cpp:
3252
3253 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
3254
3255         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
3256         https://bugs.webkit.org/show_bug.cgi?id=178333
3257
3258         Reviewed by Darin Adler.
3259
3260         * WebCoreSupport/WebFrameLoaderClient.cpp:
3261         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
3262
3263 2017-11-02  Alex Christensen  <achristensen@webkit.org>
3264
3265         Use CompletionHandlers for redirects
3266         https://bugs.webkit.org/show_bug.cgi?id=179163
3267
3268         Reviewed by Tim Horton.
3269
3270         * Plugins/PluginStream.cpp:
3271         (WebCore::PluginStream::willSendRequest):
3272         * Plugins/PluginStream.h:
3273         (WebCore::PluginStreamClient::~PluginStreamClient):
3274         (WebCore::PluginStreamClient::streamDidFinishLoading):
3275         (WebCore::PluginStream::create):
3276         (WebCore::PluginStream::setLoadManually):
3277
3278 2017-11-02  Christopher Reid  <chris.reid@sony.com>
3279
3280         Add a FileSystem namespace to FileSystem.cpp
3281         https://bugs.webkit.org/show_bug.cgi?id=179063
3282
3283         Reviewed by Darin Adler.
3284
3285         * Plugins/PluginDatabase.cpp:
3286         * Plugins/PluginPackage.cpp:
3287         * Plugins/PluginStream.cpp:
3288         * Plugins/PluginStream.h:
3289         * WebApplicationCache.cpp:
3290         * WebDatabaseManager.cpp:
3291         * WebDownloadCurl.cpp:
3292         * WebPreferences.cpp:
3293         * WebView.cpp:
3294
3295 2017-10-31  Alex Christensen  <achristensen@webkit.org>
3296
3297         Fix Windows build after r224260
3298
3299         * WebView.cpp:
3300         (WebView::gesture):
3301
3302 2017-10-28  Zalan Bujtas  <zalan@apple.com>
3303
3304         [FrameView::layout cleanup] Move core layout logic to a separate class.
3305         https://bugs.webkit.org/show_bug.cgi?id=178771
3306         <rdar://problem/35166542>
3307
3308         Reviewed by Simon Fraser.
3309
3310         Move layout code out from FrameView to LayoutContext.
3311
3312         * WebFrame.cpp:
3313         (WebFrame::layout):
3314
3315 2017-10-26  Alex Christensen  <achristensen@webkit.org>
3316
3317         Fix Windows build
3318         https://bugs.webkit.org/show_bug.cgi?id=178892
3319
3320         * AccessibleBase.cpp:
3321         (MSAARole):
3322
3323 2017-10-26  Alex Christensen  <achristensen@webkit.org>
3324
3325         Fix Windows build
3326         https://bugs.webkit.org/show_bug.cgi?id=178892
3327
3328         * AccessibleBase.cpp:
3329         (AccessibleBase::state const):
3330         (MSAARole):
3331
3332 2017-10-25  Youenn Fablet  <youenn@apple.com>
3333
3334         Enable ServiceWorker to fetch resources
3335         https://bugs.webkit.org/show_bug.cgi?id=178673
3336
3337         Reviewed by Brady Eidson.
3338
3339         Added implementation to the new getters.
3340         They are noop in the context of WK1.
3341
3342         * WebCoreSupport/WebFrameLoaderClient.cpp:
3343         (WebFrameLoaderClient::pageID const):
3344         (WebFrameLoaderClient::frameID const):
3345         (WebFrameLoaderClient::sessionID const):
3346         * WebCoreSupport/WebFrameLoaderClient.h:
3347
3348 2017-10-20  Antoine Quint  <graouts@apple.com>
3349
3350         [Web Animations] Provide basic timeline and animation interfaces
3351         https://bugs.webkit.org/show_bug.cgi?id=178526
3352
3353         Reviewed by Dean Jackson.
3354
3355         Remove the WEB_ANIMATIONS compile-time flag.
3356
3357         * WebView.cpp:
3358         (WebView::notifyPreferencesChanged):
3359
3360 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3361
3362         [Curl] Clean up old style code in old curl files.
3363         https://bugs.webkit.org/show_bug.cgi?id=178569
3364
3365         Reviewed by Ryosuke Niwa.
3366
3367         * WebCache.cpp:
3368         (WebCache::cacheFolder):
3369         (WebCache::setCacheFolder):
3370         * WebView.cpp:
3371         (WebView::setCacheModel):
3372
3373 2017-10-19  Sam Weinig  <sam@webkit.org>
3374
3375         [Settings] Move global settings into their own file
3376         https://bugs.webkit.org/show_bug.cgi?id=178512
3377
3378         Reviewed by Darin Adler.
3379
3380         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
3381
3382         * WebView.cpp:
3383         (WebView::initWithFrame):
3384
3385 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
3386
3387         Replace some stack raw pointers with RefPtrs within WebCore/html
3388         https://bugs.webkit.org/show_bug.cgi?id=178201
3389         <rdar://problem/34841692>
3390
3391         Reviewed by Ryosuke Niwa.
3392
3393         * WebView.cpp:
3394         (WebView::handleEditingKeyboardEvent):
3395         Change the type of node as toNode() is changed to return RefPtr.
3396
3397 2017-10-16  Sam Weinig  <sam@webkit.org>
3398
3399         [Settings] Remove all custom code from Settings.h/cpp
3400         https://bugs.webkit.org/show_bug.cgi?id=178330
3401
3402         Reviewed by Simon Fraser.
3403
3404         * WebView.cpp:
3405         (WebView::notifyPreferencesChanged):
3406             
3407             Update for naming changes of FrameFlattening now that it is an enum class.
3408
3409 2017-10-11  Chris Dumez  <cdumez@apple.com>
3410
3411         Modernize Geolocation code
3412         https://bugs.webkit.org/show_bug.cgi?id=178148
3413
3414         Reviewed by Ryosuke Niwa.
3415
3416         * WebCoreSupport/WebGeolocationClient.cpp:
3417         (WebGeolocationClient::lastPosition):
3418         * WebCoreSupport/WebGeolocationClient.h:
3419         * WebGeolocationPosition.cpp:
3420         (WebGeolocationPosition::initWithTimestamp):
3421         (core):
3422         * WebGeolocationPosition.h:
3423         (WebGeolocationPosition::impl const):
3424
3425 2017-10-05  Chris Dumez  <cdumez@apple.com>
3426
3427         Drop unused parameters for CookiesStrategy::cookiesEnabled()
3428         https://bugs.webkit.org/show_bug.cgi?id=177957
3429
3430         Reviewed by Alex Christensen.
3431
3432         * WebCoreSupport/WebPlatformStrategies.cpp:
3433         (WebPlatformStrategies::cookiesEnabled):
3434         * WebCoreSupport/WebPlatformStrategies.h:
3435
3436 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3437
3438         [Curl] Reimplement CurlDownload with CurlRequest
3439         https://bugs.webkit.org/show_bug.cgi?id=177779
3440
3441         Reviewed by Alex Christensen.
3442
3443         * WebDownload.h:
3444         * WebDownloadCurl.cpp:
3445         (WebDownload::init):
3446         (WebDownload::didReceiveResponse):
3447
3448 2017-09-29  Chris Dumez  <cdumez@apple.com>
3449
3450         Split some logic out of VisitedLinkStore and make it reusable
3451         https://bugs.webkit.org/show_bug.cgi?id=177575
3452
3453         Reviewed by Alex Christensen.
3454
3455         * WebCoreSupport/WebVisitedLinkStore.cpp:
3456         (WebVisitedLinkStore::addVisitedLink):
3457         (WebVisitedLinkStore::isLinkVisited):
3458         (WebVisitedLinkStore::addVisitedLinkHash):
3459         * WebCoreSupport/WebVisitedLinkStore.h:
3460
3461 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3462
3463         Make PolicyAction an encodable enum class
3464         https://bugs.webkit.org/show_bug.cgi?id=177480
3465
3466         Reviewed by Antti Koivisto.
3467
3468         * WebCoreSupport/WebFrameLoaderClient.cpp:
3469         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3470         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3471         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3472         * WebFramePolicyListener.cpp:
3473         (WebFramePolicyListener::use):
3474         (WebFramePolicyListener::download):
3475         (WebFramePolicyListener::ignore):
3476         (WebFramePolicyListener::continueSubmit):
3477
3478 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
3479
3480         [Win] fast/canvas/2d.getPath.modification.html is failing.
3481         https://bugs.webkit.org/show_bug.cgi?id=176534
3482
3483         Reviewed by Alex Christensen.
3484
3485         We need to enable Inspector additions at runtime in order to expose the getPath function.
3486
3487         * Interfaces/IWebPreferencesPrivate.idl:
3488         * WebPreferenceKeysPrivate.h:
3489         * WebPreferences.cpp:
3490         (WebPreferences::initializeDefaultSettings):
3491         (WebPreferences::setDataTransferItemsEnabled):
3492         (WebPreferences::inspectorAdditionsEnabled):
3493         (WebPreferences::setInspectorAdditionsEnabled):
3494         * WebPreferences.h:
3495         * WebView.cpp:
3496         (WebView::notifyPreferencesChanged):
3497
3498 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3499
3500         Modernize Geolocation code
3501         https://bugs.webkit.org/show_bug.cgi?id=176496
3502
3503         Reviewed by Andy Estes.
3504
3505         * WebCoreSupport/WebGeolocationClient.cpp:
3506         (WebGeolocationClient::requestPermission):
3507         * WebCoreSupport/WebGeolocationClient.h:
3508         (WebGeolocationClient::setEnableHighAccuracy): Deleted.
3509         (WebGeolocationClient::cancelPermissionRequest): Deleted.
3510         * WebGeolocationPolicyListener.h:
3511         * WebView.cpp:
3512         (WebView::initWithFrame):
3513         (WebView::geolocationDidFailWithError):
3514
3515 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
3516
3517         [Win] Enable DatatransferItems in DRT.
3518         https://bugs.webkit.org/show_bug.cgi?id=176424
3519
3520         Reviewed by Brent Fulgham.
3521
3522         * Interfaces/IWebPreferencesPrivate.idl:
3523         * WebPreferenceKeysPrivate.h:
3524         * WebPreferences.cpp:
3525         (WebPreferences::initializeDefaultSettings):
3526         (WebPreferences::QueryInterface):
3527         (WebPreferences::isSecureContextAttributeEnabled):
3528         (WebPreferences::dataTransferItemsEnabled):
3529         (WebPreferences::setDataTransferItemsEnabled):
3530         * WebPreferences.h:
3531         * WebView.cpp:
3532         (WebView::notifyPreferencesChanged):
3533
3534 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3535
3536         Unreviewed build fix #2 after r221275.
3537
3538         * WebCoreSupport/WebPlatformStrategies.cpp:
3539         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
3540         to match new API.
3541         * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
3542
3543 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3544
3545         Unreviewed build fix after r221275.
3546
3547         * WebCoreSupport/WebPlatformStrategies.cpp:
3548         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
3549         to match new API.
3550
3551 2017-08-28  Per Arne Vollan  <pvollan@apple.com>
3552
3553         [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
3554         https://bugs.webkit.org/show_bug.cgi?id=176031
3555
3556         Reviewed by Brent Fulgham.
3557
3558         When the function in the FramePolicyFunction parameter is called, it has already been moved
3559         to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
3560         function by using the stored member instead.
3561
3562         * WebCoreSupport/WebFrameLoaderClient.cpp:
3563         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3564         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3565         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3566
3567 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3568
3569         Unreviewed, try to fix the Windows build after r221064
3570
3571         didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
3572
3573         * WebCoreSupport/WebEditorClient.h:
3574
3575 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3576
3577         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3578         https://bugs.webkit.org/show_bug.cgi?id=175370
3579         <rdar://problem/33799806>
3580
3581         Reviewed by Ryosuke Niwa.
3582
3583         Adjust WebEditorClient for interface changes.
3584
3585         * WebCoreSupport/WebEditorClient.h:
3586
3587 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
3588
3589         Unreviewed build fix after r221017.
3590
3591         Correct copy/paste error.
3592
3593         * WebCoreSupport/WebPlatformStrategies.cpp:
3594         (WebPlatformStrategies::cookiesForDOM):
3595
3596 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
3597
3598         Unreviewed build fix after r221017.
3599
3600         * WebCoreSupport/WebPlatformStrategies.cpp:
3601         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
3602         * WebCoreSupport/WebPlatformStrategies.h:
3603
3604 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3605
3606         Remove ChromeClient::scrollbarsModeDidChange
3607         https://bugs.webkit.org/show_bug.cgi?id=175805
3608
3609         Reviewed by Daniel Bates.
3610
3611         * WebCoreSupport/WebChromeClient.h:
3612
3613 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3614
3615         Remove ChromeClient::hasOpenedPopup
3616         https://bugs.webkit.org/show_bug.cgi?id=175804
3617
3618         Reviewed by Sam Weinig.
3619
3620         * WebCoreSupport/WebChromeClient.cpp:
3621         (WebChromeClient::hasOpenedPopup const): Deleted.
3622         * WebCoreSupport/WebChromeClient.h:
3623
3624 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
3625
3626         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
3627         https://bugs.webkit.org/show_bug.cgi?id=173536
3628
3629         Reviewed by Brent Fulgham.
3630
3631         If the tree state is dirty, accessible objects are deleted while iterating over children
3632         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
3633         style is updated before this method is called.
3634
3635         * AccessibleBase.cpp:
3636         (AccessibleBase::getAccessibilityObjectForChild):
3637
3638 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3639
3640         [PAL] Move SessionID into PAL
3641         https://bugs.webkit.org/show_bug.cgi?id=174192
3642
3643         Reviewed by Antti Koivisto.
3644
3645         * WebCoreSupport/WebFrameLoaderClient.cpp:
3646         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3647         * WebCoreSupport/WebFrameLoaderClient.h:
3648         * WebCoreSupport/WebFrameNetworkingContext.cpp:
3649         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
3650         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3651         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3652         (WebFrameNetworkingContext::storageSession const):
3653         * WebCoreSupport/WebPlatformStrategies.cpp:
3654         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3655         * WebCoreSupport/WebPlatformStrategies.h:
3656
3657 2017-08-15  Youenn Fablet  <youenn@apple.com>
3658
3659         [Cache API] Adding generic support for CacheStorage and Cache methods
3660         https://bugs.webkit.org/show_bug.cgi?id=175455
3661
3662         Reviewed by Chris Dumez.
3663
3664         * WebView.cpp:
3665         (WebView::initWithFrame):
3666
3667 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3668
3669         Composition underline color is always black
3670         https://bugs.webkit.org/show_bug.cgi?id=174675
3671
3672         Reviewed by Ryosuke Niwa.
3673
3674         * WebView.cpp:
3675         (WebView::setCompositionForTesting): Use text color for
3676         composition underline.
3677
3678 2017-08-09  Daniel Bates  <dabates@apple.com>
3679
3680         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3681         https://bugs.webkit.org/show_bug.cgi?id=175247
3682         <rdar://problem/33679804>
3683
3684         Reviewed by Brady Eidson.
3685
3686         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3687         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3688         clients that need to make use of this information at this time. If such a needs comes up
3689         then we can expose API/SPI similar to what we do for WebKit.
3690
3691         * WebCoreSupport/WebFrameLoaderClient.cpp:
3692         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3693         * WebCoreSupport/WebFrameLoaderClient.h:
3694
3695 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3696
3697         Async image decoding for large images should be disabled after the first time a tile is painted
3698         https://bugs.webkit.org/show_bug.cgi?id=174451
3699         <rdar://problem/31246421>
3700
3701         Reviewed by Simon Fraser.
3702
3703         * FullscreenVideoController.cpp:
3704         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3705         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3706         (AcceleratedCompositingContext::paintContents):
3707         * WebCoreSupport/AcceleratedCompositingContext.h:
3708
3709 2017-07-23  Darin Adler  <darin@apple.com>
3710
3711         More NeverDestroyed and related cleanup
3712         https://bugs.webkit.org/show_bug.cgi?id=174745
3713
3714         Reviewed by Alex Christensen.
3715
3716         * Plugins/PluginDatabase.cpp:
3717         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
3718         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
3719         * Plugins/PluginMainThreadScheduler.cpp:
3720         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
3721         * Plugins/PluginMainThreadScheduler.h: Ditto.
3722         * WebCoreSupport/WebPlatformStrategies.cpp:
3723         (WebPlatformStrategies::initialize): Ditto.
3724         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
3725         * WebHistory.cpp:
3726         (sharedHistoryStorage): Ditto.
3727         * WebLocalizableStrings.cpp:
3728         (mainBundleLocStrings): Ditto.
3729         (frameworkLocStringsMutex): Ditto.
3730         (frameworkLocStrings): Ditto.
3731         * WebView.cpp:
3732         (WebView::standardUserAgentWithApplicationName): Ditto.
3733         Also changed to keep one global string with the prefix of the user agent string
3734         instead of keeping two globals with pieces of that prefix.
3735
3736 2017-07-24  Chris Dumez  <cdumez@apple.com>
3737
3738         Make ExceptionCode a proper enumeration
3739         https://bugs.webkit.org/show_bug.cgi?id=174771
3740
3741         Reviewed by Sam Weinig.
3742
3743         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
3744
3745         * DOMCoreClasses.cpp:
3746         (DOMDocument::createEvent):
3747         * WebView.cpp:
3748         (WebView::prepareCandidateWindow):
3749
3750 2017-07-21  Andreas Kling  <akling@apple.com>
3751
3752         Use more references in event dispatch code
3753         https://bugs.webkit.org/show_bug.cgi?id=174681
3754
3755         Reviewed by Geoffrey Garen.
3756
3757         * DOMEventsClasses.cpp:
3758         (WebEventListener::handleEvent):
3759         * DOMEventsClasses.h:
3760         * Plugins/PluginView.cpp:
3761         (WebCore::PluginView::handleEvent):
3762         * Plugins/PluginView.h:
3763
3764 2017-07-20  Brady Eidson  <beidson@apple.com>
3765
3766         Remove WebIconDatabase from WebKitLegacy/win.
3767         https://bugs.webkit.org/show_bug.cgi?id=174608
3768
3769         Reviewed by Alex Christensen.
3770
3771         It is unused.
3772         
3773         * ForEachCoClass.h:
3774
3775         * Interfaces/IWebIconDatabase.idl: Removed.
3776
3777         * Interfaces/WebKit.idl:
3778
3779         * WebCoreStatistics.cpp:
3780         (WebCoreStatistics::iconPageURLMappingCount):
3781         (WebCoreStatistics::iconRetainedPageURLCount):
3782         (WebCoreStatistics::iconRecordCount):
3783         (WebCoreStatistics::iconsWithDataCount):
3784
3785         * WebIconDatabase.cpp: Removed.
3786         * WebIconDatabase.h: Removed.
3787         * WebKitClassFactory.cpp:
3788
3789         * WebKitDLL.cpp:
3790         (shutDownWebKit):
3791
3792         * WebKitLogging.h:
3793
3794         * WebView.cpp:
3795         (WebView::close):
3796         (WebView::notifyDidAddIcon):
3797         (WebView::registerForIconNotification):
3798         (WebView::dispatchDidReceiveIconFromWebFrame):
3799         (WebView::onNotify):
3800
3801 2017-07-18  Matt Lewis  <jlewis3@apple.com>
3802
3803         Unreviewed, rolling out r219610.
3804
3805         This caused an api failure on all platforms for the test
3806         SnapshotImageLargeAsyncDecoding
3807
3808         Reverted changeset:
3809
3810         "Async image decoding for large images should be disabled
3811         after the first time a tile is painted"
3812         https://bugs.webkit.org/show_bug.cgi?id=174451
3813         http://trac.webkit.org/changeset/219610
3814
3815 2017-07-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
3816
3817         Async image decoding for large images should be disabled after the first time a tile is painted
3818         https://bugs.webkit.org/show_bug.cgi?id=174451
3819
3820         Reviewed by Simon Fraser.
3821
3822         * FullscreenVideoController.cpp:
3823         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3824         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3825         (AcceleratedCompositingContext::paintContents):
3826         * WebCoreSupport/AcceleratedCompositingContext.h:
3827
3828 2017-07-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3829
3830         [Curl] Don't start downloading more than once for same request
3831         https://bugs.webkit.org/show_bug.cgi?id=174172
3832
3833         Reviewed by Alex Christensen.
3834
3835         * WebDownloadCurl.cpp:
3836         (WebDownload::init):
3837
3838 2017-07-12  Daniel Bates  <dabates@apple.com>
3839
3840         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3841         https://bugs.webkit.org/show_bug.cgi?id=174427
3842
3843         Rubber-stamped by Brady Eidson.
3844
3845         * Plugins/PluginView.cpp:
3846         (WebCore::PluginView::start):
3847         (WebCore::PluginView::getURLNotify):
3848         (WebCore::PluginView::getURL):
3849         (WebCore::PluginView::handlePost):
3850
3851 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3852
3853         [WTF] Move SoftLinking.h into WTF
3854         https://bugs.webkit.org/show_bug.cgi?id=174000
3855
3856         Reviewed by Alex Christensen.
3857
3858         * WebKitClassFactory.cpp:
3859         * WebView.cpp:
3860
3861 2017-07-05  Brady Eidson  <beidson@apple.com>
3862
3863         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3864         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3865
3866         Reviewed by Alex Christensen.
3867
3868         Adopt to the new constructor for FrameLoadRequest.
3869
3870         * Plugins/PluginView.cpp:
3871         (WebCore::PluginView::start):
3872         (WebCore::PluginView::getURLNotify):
3873         (WebCore::PluginView::getURL):
3874         (WebCore::PluginView::handlePost):
3875
3876 2017-07-03  Brady Eidson  <beidson@apple.com>
3877
3878         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3879         https://bugs.webkit.org/show_bug.cgi?id=174073
3880
3881         Reviewed by Andy Estes.
3882
3883         * WebCoreSupport/WebFrameLoaderClient.cpp:
3884         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3885         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3886         * WebCoreSupport/WebFrameLoaderClient.h:
3887
3888 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3889
3890         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3891         https://bugs.webkit.org/show_bug.cgi?id=174004
3892
3893         Reviewed by Simon Fraser.
3894
3895         * WebCoreSupport/WebFrameLoaderClient.cpp:
3896         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3897
3898 2017-06-30  Daniel Bates  <dabates@apple.com>
3899
3900         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3901         https://bugs.webkit.org/show_bug.cgi?id=165160
3902         <rdar://problem/29451999>
3903
3904         Reviewed by Brady Eidson.
3905
3906         Pass the document that is requesting the load to the loader.
3907
3908         * Plugins/PluginView.cpp:
3909         (WebCore::PluginView::start):
3910         (WebCore::PluginView::getURLNotify):
3911         (WebCore::PluginView::getURL):
3912         (WebCore::PluginView::handlePost):
3913
3914 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3915
3916         Refactor drag start codepaths to plumb a DragItem to client layers
3917         https://bugs.webkit.org/show_bug.cgi?id=173832
3918         Work towards <rdar://problem/32236827>
3919
3920         Reviewed by Ryosuke Niwa and Tim Horton.
3921
3922         Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
3923
3924         * WebCoreSupport/WebDragClient.cpp:
3925         (WebDragClient::startDrag):
3926         * WebCoreSupport/WebDragClient.h:
3927
3928 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3929
3930         Remove excessive headers from JavaScriptCore
3931         https://bugs.webkit.org/show_bug.cgi?id=173812
3932
3933         Reviewed by Darin Adler.
3934
3935         * Plugins/PluginPackage.cpp:
3936
3937 2017-06-22  Daniel Bates  <dabates@apple.com>
3938
3939         Make FrameLoadRequest a move-only type
3940         https://bugs.webkit.org/show_bug.cgi?id=173682
3941
3942         Reviewed by Alex Christensen and Darin Adler.
3943
3944         A FrameLoadRequest groups together the information to perform a load into a single object
3945         that is more manageable to pass around than its constituent parts. Code that receives a
3946         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3947         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3948         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
3949
3950         * Plugins/PluginView.cpp:
3951         (WebCore::PluginView::start):
3952         (WebCore::PluginView::performRequest):
3953         (WebCore::PluginView::load):
3954         (WebCore::PluginView::getURLNotify):
3955         (WebCore::PluginView::getURL):
3956         (WebCore::PluginView::handlePost):
3957         * Plugins/PluginView.h:
3958         (WebCore::PluginRequest::PluginRequest):
3959
3960 2017-06-22  Daniel Bates  <dabates@apple.com>
3961
3962         [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
3963         https://bugs.webkit.org/show_bug.cgi?id=173683
3964
3965         Reviewed by Alex Christensen.
3966
3967         Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
3968         header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
3969         by including PluginView.h. The latter does not make use of the functionality
3970         provided by FrameLoadRequest.h.
3971
3972         * Plugins/PluginViewWin.cpp:
3973         * WebCoreSupport/WebContextMenuClient.cpp:
3974
3975 2017-06-21  Daniel Bates  <dabates@apple.com>
3976
3977         Cleanup FrameLoadRequest
3978         https://bugs.webkit.org/show_bug.cgi?id=173564
3979         <rdar://problem/32903570>
3980
3981         Reviewed by Brent Fulgham.
3982
3983         * Plugins/PluginView.cpp:
3984         (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
3985         we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
3986         we do not have one. Use C++11 brace initialization syntax.
3987         (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
3988         name as we do not have one. Use C++11 brace initialization syntax.
3989         (WebCore::PluginView::getURL): Ditto.
3990         (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
3991         function to closer to where it is actually used. Explicitly pass the null-string for the target
3992         frame name as we do not have one. Use C++11 brace initialization syntax.
3993
3994 2017-06-20  Daniel Bates  <dabates@apple.com>
3995
3996         Have FrameLoadRequest takes a Frame& instead of a Frame*
3997         https://bugs.webkit.org/show_bug.cgi?id=173614
3998         <rdar://problem/32884890>
3999
4000         Reviewed by Brent Fulgham.
4001
4002         * Plugins/PluginView.cpp:
4003         (WebCore::PluginView::performRequest):
4004         * WebFrame.cpp:
4005         (WebFrame::loadRequest):
4006
4007 2017-06-19  Chris Dumez  <cdumez@apple.com>
4008
4009         Use WTF::Function instead of std::function in more places in WebCore/
4010         https://bugs.webkit.org/show_bug.cgi?id=173535
4011
4012         Reviewed by Antti Koivisto.
4013
4014         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
4015
4016         * WebCoreSupport/WebFrameLoaderClient.cpp:
4017         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
4018         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
4019         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
4020         (WebFrameLoaderClient::dispatchWillSubmitForm):
4021         (WebFrameLoaderClient::setUpPolicyListener):
4022         (WebFrameLoaderClient::receivedPolicyDecision):
4023         * WebCoreSupport/WebFrameLoaderClient.h:
4024
4025 2017-05-14 Frederic Wang  <fwang@igalia.com>
4026
4027         Add heuristic to avoid flattening "fullscreen" iframes
4028         https://bugs.webkit.org/show_bug.cgi?id=171914
4029
4030         Reviewed by Simon Fraser.
4031
4032         This commit ajusts the window port to internally use the new preference type for frame flattening.
4033         However, the "partial frame flattening" value is not exposed yet.
4034
4035         * WebView.cpp:
4036         (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
4037
4038 2017-06-17  Chris Dumez  <cdumez@apple.com>
4039
4040         Use WTF::Function instead of std::function in WebKit2/
4041         https://bugs.webkit.org/show_bug.cgi?id=173504
4042
4043         Reviewed by Darin Adler.
4044
4045         Use WTF::Function instead of std::function in WebKit2/ to avoid
4046         unnecessary copying.
4047
4048         * Plugins/PluginStream.cpp:
4049         (WebCore::PluginStream::willSendRequest):
4050         * Plugins/PluginStream.h:
4051
4052 2017-06-16  Sam Weinig  <sam@webkit.org>
4053
4054         [WebIDL] Remove custom bindings for HTMLDocument
4055         https://bugs.webkit.org/show_bug.cgi?id=173444
4056
4057         Reviewed by Darin Adler.
4058
4059         * DOMHTMLClasses.cpp:
4060         (DOMHTMLDocument::write):
4061         (DOMHTMLDocument::writeln):
4062         Update for new signature of write/writeln.
4063
4064 2017-06-16  Daniel Bates  <dabates@apple.com>
4065
4066         Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
4067         instead of URL { ParsedURLString, ... }
4068         https://bugs.webkit.org/show_bug.cgi?id=173495
4069         <rdar://problem/32827445>
4070
4071         Reviewed by Alex Christensen.
4072
4073         URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
4074         Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
4075         Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
4076         would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
4077         parse an arbitrary string that looks like a URL.
4078
4079         Also modernize the code using C++14 idioms.
4080
4081         * WebCoreSupport/WebContextMenuClient.cpp:
4082         (WebContextMenuClient::searchWithGoogle):
4083
4084 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
4085
4086         [Win] WebKit shouldn't include the forwarding header of WebKit itself
4087         https://bugs.webkit.org/show_bug.cgi?id=173352
4088
4089         Reviewed by Alex Christensen.
4090
4091         * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
4092
4093 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
4094
4095         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
4096         https://bugs.webkit.org/show_bug.cgi?id=173318
4097
4098         Reviewed by Darin Adler.
4099
4100         The logical frame size is currently calculated by scaling the frame size in pixels,
4101         and rounding the coordinates to the nearest integers. The computed logical frame
4102         size will in some cases be smaller than the scaled frame size in pixels, since it is
4103         represented as an IntSize. In these cases, the bottom line will not be painted.
4104         Instead of calculating the logical frame size by rounding the scaled frame in
4105         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
4106
4107         * WebCoreSupport/WebFrameLoaderClient.cpp:
4108         (WebFrameLoaderClient::transitionToCommittedForNewPage):
4109
4110 2017-06-13  Daniel Bates  <dabates@apple.com>
4111
4112         Implement W3C Secure Contexts Draft Specification
4113         https://bugs.webkit.org/show_bug.cgi?id=158121
4114         <rdar://problem/26012994>
4115
4116         Reviewed by Brent Fulgham.
4117
4118         Part 4
4119
4120         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
4121
4122         * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
4123         * WebPreferenceKeysPrivate.h:
4124         * WebPreferences.cpp:
4125         (WebPreferences::initializeDefaultSettings):
4126         (WebPreferences::QueryInterface):
4127         (WebPreferences::setIsSecureContextAttributeEnabled):
4128         (WebPreferences::isSecureContextAttributeEnabled):
4129         * WebPreferences.h:
4130         * WebView.cpp:
4131         (WebView::notifyPreferencesChanged):
4132
4133 2017-06-13  Per Arne Vollan  <pvollan@apple.com>
4134
4135         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
4136         https://bugs.webkit.org/show_bug.cgi?id=173318
4137
4138         Reviewed by Alex Christensen.
4139
4140         The logical frame size is currently calculated by scaling the frame size in pixels,
4141         and rounding the coordinates to the nearest integers. The computed logical frame
4142         size will in some cases be smaller than the scaled frame size in pixels, since it is
4143         represented as an IntSize. In these cases, the bottom line will not be painted.
4144         Instead of calculating the logical frame size by rounding the scaled frame in
4145         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
4146  
4147         * WebView.cpp:
4148         (WebView::sizeChanged):
4149