Blob registries should be keyed by session IDs
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2019-08-13  Youenn Fablet  <youenn@apple.com>
2
3         Blob registries should be keyed by session IDs
4         https://bugs.webkit.org/show_bug.cgi?id=200567
5         <rdar://problem/54120212>
6
7         Reviewed by Alex Christensen.
8
9         * WebCoreSupport/WebPlatformStrategies.cpp:
10         (WebPlatformStrategies::createBlobRegistry):
11
12 2019-08-12  Youenn Fablet  <youenn@apple.com>
13
14         Remove IDB-specific quota
15         https://bugs.webkit.org/show_bug.cgi?id=196545
16
17         Reviewed by Alex Christensen.
18
19         * Interfaces/IWebDatabaseManager.idl:
20         * WebDatabaseManager.cpp:
21         (WebDatabaseManager::setIDBPerOriginQuota): Deleted.
22         * WebDatabaseManager.h:
23
24 2019-08-09  Per Arne Vollan  <pvollan@apple.com>
25
26         [Win] Remove compiler workaround for VS2013
27         https://bugs.webkit.org/show_bug.cgi?id=200582
28
29         Reviewed by Don Olmstead.
30
31         A VS2013 compiler workaround can be removed now.
32
33         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp:
34         (DllMain):
35
36 2019-08-08  Per Arne Vollan  <pvollan@apple.com>
37
38         [Win] Fix internal build
39         https://bugs.webkit.org/show_bug.cgi?id=200519
40
41         Reviewed by Alex Christensen.
42
43         Switch to the String::wideCharacers method, since its return type is compatible with the Win32 api.
44
45         * WebDownloadCFNet.cpp:
46         (WebDownload::didFinish):
47
48 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
49
50         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
51         https://bugs.webkit.org/show_bug.cgi?id=200539
52         <rdar://problem/54082550>
53
54         Reviewed by Dean Jackson.
55
56         * AccessibleBase.cpp:
57         (AccessibleBase::get_locale):
58         * CFDictionaryPropertyBag.cpp:
59         (ConvertCFTypeToVariant):
60         (CFDictionaryPropertyBag::Read):
61         (CFDictionaryPropertyBag::Write):
62         * CFDictionaryPropertyBag.h:
63         * COMPropertyBag.h:
64         (HashType>::Read):
65         (HashType>::GetPropertyInfo):
66         * MarshallingHelpers.cpp:
67         * MarshallingHelpers.h:
68         * WebApplicationCache.cpp:
69         * WebArchive.cpp:
70         * WebArchive.h:
71         * WebCache.cpp:
72         * WebCoreSupport/WebFrameLoaderClient.cpp:
73         * WebDatabaseManager.cpp:
74         * WebHistory.cpp:
75         * WebHistoryItem.cpp:
76         * WebKitCOMAPI.cpp:
77         * WebKitCOMAPI.h:
78         * WebKitDLL.cpp:
79         * WebLocalizableStrings.cpp:
80         * WebLocalizableStrings.h:
81         * WebMutableURLRequest.cpp:
82         * WebPreferences.cpp:
83         * WebPreferences.h:
84         * WebView.cpp:
85         * WebView.h:
86
87 2019-08-08  Rob Buis  <rbuis@igalia.com>
88
89         Add runtime flag for lazy image loading
90         https://bugs.webkit.org/show_bug.cgi?id=199794
91
92         Reviewed by Darin Adler.
93
94         Set lazyImageLoading runtime flag if preference is set.
95
96         * Interfaces/IWebPreferencesPrivate.idl:
97         * WebPreferenceKeysPrivate.h:
98         * WebPreferences.cpp:
99         (WebPreferences::initializeDefaultSettings):
100         (WebPreferences::lazyImageLoadingEnabled):
101         (WebPreferences::setLazyImageLoadingEnabled):
102         * WebPreferences.h:
103         * WebView.cpp:
104         (WebView::notifyPreferencesChanged):
105
106 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
107
108         [Win][WK1] Can't change Web Inspector frontend height in high DPI
109         https://bugs.webkit.org/show_bug.cgi?id=200153
110
111         Reviewed by Don Olmstead.
112
113         * WebCoreSupport/WebInspectorClient.cpp:
114         (WebInspectorFrontendClient::setAttachedWindowHeight):
115         Applied deviceScaleFactor to the argument height.
116
117 2019-07-26  Konstantin Tokarev  <annulen@yandex.ru>
118
119         [Win] Remove unused methods from WebPluginInfoProvider
120         https://bugs.webkit.org/show_bug.cgi?id=200178
121
122         Reviewed by Brent Fulgham.
123
124         These methods are guarded with PLATFORM(MAC) and have no definitions.
125         Also remove unused friend declaration.
126
127         * WebCoreSupport/WebPluginInfoProvider.h:
128
129 2019-07-25  Fujii Hironori  <Hironori.Fujii@sony.com>
130
131         [Win][WK1] The inspected webview window is misplaced after changing Web Inspector frontend window height
132         https://bugs.webkit.org/show_bug.cgi?id=200152
133
134         Reviewed by Brent Fulgham.
135
136         In WebInspectorFrontendClient::setAttachedWindowHeight, the size
137         of m_inspectedWebViewHwnd was changed to the whole host window
138         size. But, it's too tall because MiniBrowser's host window has a
139         toolbar. The toolbar height should be taken into account.
140
141         Change to the height of m_inspectedWebViewHwnd to the sum of
142         inspected WebView and inspector frontend WebView heights.
143
144         * WebCoreSupport/WebInspectorClient.cpp:
145         (WebInspectorFrontendClient::setAttachedWindowHeight):
146
147 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
148
149         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
150         https://bugs.webkit.org/show_bug.cgi?id=200021
151         <rdar://problem/53301325>
152
153         Reviewed by Ryosuke Niwa.
154
155         Implement a new editing client hook.
156
157         * WebCoreSupport/WebEditorClient.h:
158
159 2019-07-13  Zalan Bujtas  <zalan@apple.com>
160
161         Cannot bring up custom media controls at all on v.youku.com
162         https://bugs.webkit.org/show_bug.cgi?id=199699
163         <rdar://problem/51835327>
164
165         Reviewed by Simon Fraser.
166
167         * WebActionPropertyBag.cpp:
168         (WebActionPropertyBag::Read):
169         * WebView.cpp:
170         (WebView::handleContextMenuEvent):
171         (WebView::elementAtPoint):
172
173 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
174
175         [WinCairo] ASSERTION FAILED: info.bmBitsPixel == 32 in createCairoContextWithHDC
176         https://bugs.webkit.org/show_bug.cgi?id=198323
177
178         Reviewed by Per Arne Vollan.
179
180         WebView::paint binds m_backingStoreBitmap to a DC by using
181         SelectObject. WebView::paint can be called recursively, but
182         m_backingStoreBitmap can't be bound to multiple DCs at the same
183         time. Then, SelectObject was failing in such case.
184
185         Call WebCore::Page::updateRendering before binding
186         m_backingStoreBitmap instead of after it.
187
188         Reverted r202744 change which won't be needed since this change.
189
190         * WebView.cpp:
191         (WebView::scrollBackingStore): Removed r202744's change.
192         (WebView::updateBackingStore): Removed m_page->updateRendering().
193         (WebView::paint): Do m_page->updateRendering() before binding m_backingStoreBitmap.
194         * WebView.h: Removed unused WebView::isPainting.
195
196 2019-07-02  Devin Rousso  <drousso@apple.com>
197
198         Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
199         https://bugs.webkit.org/show_bug.cgi?id=198956
200
201         Reviewed by Matt Baker.
202
203         * WebCoreSupport/WebInspectorClient.h:
204         * WebCoreSupport/WebInspectorClient.cpp:
205         (WebInspectorFrontendClient::resetWindowState): Added.
206
207 2019-06-30  Fujii Hironori  <Hironori.Fujii@sony.com>
208
209         [Win] Multiline mode of tooltip control does word-wrapping very slowly
210         https://bugs.webkit.org/show_bug.cgi?id=198989
211
212         Reviewed by Ross Kirsling.
213
214         * WebView.cpp:
215         (truncatedString): Added.
216         (WebView::setToolTip): Use truncatedString.
217
218 2019-06-16  Darin Adler  <darin@apple.com>
219
220         Rename AtomicString to AtomString
221         https://bugs.webkit.org/show_bug.cgi?id=195276
222
223         Reviewed by Michael Catanzaro.
224
225         * many files: Let do-webcore-rename do the renaming.
226
227 2019-05-31  Don Olmstead  <don.olmstead@sony.com>
228
229         [CMake] Add WebKit::WTF target
230         https://bugs.webkit.org/show_bug.cgi?id=198400
231
232         Reviewed by Konstantin Tokarev.
233
234         Use the WebKit::WTF target.
235
236         * WebKitQuartzCoreAdditions/CMakeLists.txt:
237
238 2019-05-30  Simon Fraser  <simon.fraser@apple.com>
239
240         Use an OptionSet<> for GraphicsLayerPaintingPhase
241         https://bugs.webkit.org/show_bug.cgi?id=198404
242
243         Reviewed by Tim Horton.
244
245         Replace GraphicsLayerPaintingPhase with OptionSet<GraphicsLayerPaintingPhase>.
246
247         No behavior change.
248
249         * WebCoreSupport/AcceleratedCompositingContext.cpp:
250         (AcceleratedCompositingContext::paintContents):
251         * WebCoreSupport/AcceleratedCompositingContext.h:
252         * WebView.cpp:
253         (WebView::paintContents):
254         * WebView.h:
255
256 2019-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
257
258         [iOS] Dropped text, attachments, and images should animate into place
259         https://bugs.webkit.org/show_bug.cgi?id=198243
260         <rdar://problem/35205373>
261
262         Reviewed by Tim Horton.
263
264         * WebCoreSupport/WebChromeClient.cpp:
265         (WebChromeClient::didFinishLoadingImageForElement):
266         * WebCoreSupport/WebChromeClient.h:
267
268 2019-05-03  Daniel Bates  <dabates@apple.com>
269
270         Pass KeyboardEvent by reference in more places
271         https://bugs.webkit.org/show_bug.cgi?id=197480
272
273         Reviewed by Wenson Hsieh.
274
275         * WebCoreSupport/WebEditorClient.cpp:
276         (WebEditorClient::handleKeyboardEvent):
277         (WebEditorClient::handleInputMethodKeydown):
278         * WebCoreSupport/WebEditorClient.h:
279         * WebView.cpp:
280         (WebView::handleEditingKeyboardEvent):
281         * WebView.h:
282
283 2019-05-02  Frederic Wang  <fwang@igalia.com>
284
285         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
286         https://bugs.webkit.org/show_bug.cgi?id=196142
287
288         This patch introduces some experimental runtime flag to let users
289         disable MathML features that are removed from MathML Core [1]. For now,
290         these features are only disabled on GTK and WPE ports.
291
292         [1] https://mathml-refresh.github.io/mathml-core/
293
294         Reviewed by Rob Buis.
295
296         * Interfaces/IWebPreferencesPrivate.idl:
297         * WebPreferenceKeysPrivate.h:
298         * WebPreferences.cpp:
299         (WebPreferences::initializeDefaultSettings):
300         (WebPreferences::coreMathMLEnabled):
301         (WebPreferences::setCoreMathMLEnabled):
302         * WebPreferences.h:
303         * WebView.cpp:
304         (WebView::notifyPreferencesChanged):
305
306 2019-04-24  Zalan Bujtas  <zalan@apple.com>
307
308         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
309         https://bugs.webkit.org/show_bug.cgi?id=196948
310         <rdar://problem/49927131>
311
312         Reviewed by Tim Horton.
313
314         * WebCoreSupport/WebChromeClient.cpp:
315         (WebChromeClient::intrinsicContentsSizeChanged const):
316         * WebCoreSupport/WebChromeClient.h:
317
318 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
319
320         Make it possible to control the renderTreeAsText output by setting options on testRunner
321         https://bugs.webkit.org/show_bug.cgi?id=197133
322
323         Reviewed by Sam Weinig.
324
325         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
326         that make sense in testing (those that don't dump unstable data like addresses), and plumb
327         these flags through the various framework layers.
328
329         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
330
331         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
332         and hand-code DumpRenderTree bindings.
333
334         Some cleanup of the TestRunners, using member initializers.
335
336         * Interfaces/IWebFramePrivate.idl:
337         * WebFrame.cpp:
338         (toRenderAsTextFlags):
339         (WebFrame::renderTreeAsExternalRepresentation):
340         (WebFrame::renderTreeAsExternalRepresentationForPrinting):
341         * WebFrame.h:
342
343 2019-04-23  Chris Dumez  <cdumez@apple.com>
344
345         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
346         https://bugs.webkit.org/show_bug.cgi?id=197097
347         <rdar://problem/50048318>
348
349         Reviewed by Alex Christensen.
350
351         * WebCoreSupport/WebFrameLoaderClient.cpp:
352         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
353         * WebCoreSupport/WebFrameLoaderClient.h:
354
355 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
356
357         [CMake][Win] Use target oriented design for WebKitLegacy
358         https://bugs.webkit.org/show_bug.cgi?id=197112
359
360         Reviewed by Konstantin Tokarev.
361
362         Fix an include directory.
363
364         * WebKitQuartzCoreAdditions/CMakeLists.txt:
365
366 2019-04-18  Jer Noble  <jer.noble@apple.com>
367
368         Refactoring: Pull all fullscreen code out of Document and into its own helper class
369         https://bugs.webkit.org/show_bug.cgi?id=197017
370
371         Reviewed by Eric Carlson.
372
373         * WebCoreSupport/WebChromeClient.cpp:
374         (WebChromeClient::createWindow):
375         * WebView.cpp:
376         (WebView::fullScreenClientWillEnterFullScreen):
377         (WebView::fullScreenClientDidEnterFullScreen):
378         (WebView::fullScreenClientWillExitFullScreen):
379         (WebView::fullScreenClientDidExitFullScreen):
380
381 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
382
383         requestAnimationFrame should execute before the next frame
384         https://bugs.webkit.org/show_bug.cgi?id=177484
385
386         Reviewed by Simon Fraser.
387
388         * WebView.cpp:
389         (WebView::updateBackingStore):
390         (WebView::flushPendingGraphicsLayerChangesSoon):
391         (WebView::flushPendingGraphicsLayerChanges):
392         Call Page::updateRendering() which implements "Update the rendering"
393         step of the HTML Event Loop specification.
394
395 2019-04-10  Devin Rousso  <drousso@apple.com>
396
397         Web Inspector: save sheet should be anchored underneath the tab bar when detached
398         https://bugs.webkit.org/show_bug.cgi?id=196722
399         <rdar://problem/49613280>
400
401         Reviewed by Timothy Hatcher.
402
403         * WebCoreSupport/WebInspectorClient.h:
404         * WebCoreSupport/WebInspectorClient.cpp:
405         (WebInspectorFrontendClient::setSheetRect): Added.
406
407 2019-04-10  Alex Christensen  <achristensen@webkit.org>
408
409         Add SPI WKNavigationResponse._downloadAttribute
410         https://bugs.webkit.org/show_bug.cgi?id=196755
411         <rdar://49587365>
412
413         Reviewed by Brady Eidson.
414
415         * WebCoreSupport/WebFrameLoaderClient.cpp:
416         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
417         * WebCoreSupport/WebFrameLoaderClient.h:
418
419 2019-04-05  Commit Queue  <commit-queue@webkit.org>
420
421         Unreviewed, rolling out r243833.
422         https://bugs.webkit.org/show_bug.cgi?id=196645
423
424         This change breaks build of WPE and GTK ports (Requested by
425         annulen on #webkit).
426
427         Reverted changeset:
428
429         "[CMake][WTF] Mirror XCode header directories"
430         https://bugs.webkit.org/show_bug.cgi?id=191662
431         https://trac.webkit.org/changeset/243833
432
433 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
434
435         [CMake][WTF] Mirror XCode header directories
436         https://bugs.webkit.org/show_bug.cgi?id=191662
437
438         Reviewed by Konstantin Tokarev.
439
440         * WebKitQuartzCoreAdditions/CMakeLists.txt:
441
442 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
443
444         Implement ResizeObserver.
445         https://bugs.webkit.org/show_bug.cgi?id=157743
446
447         Reviewed by Simon Fraser.
448
449         * Interfaces/IWebPreferencesPrivate.idl:
450         * WebPreferenceKeysPrivate.h:
451         * WebPreferences.cpp:
452         (WebPreferences::initializeDefaultSettings):
453         (WebPreferences::resizeObserverEnabled):
454         (WebPreferences::setResizeObserverEnabled):
455         * WebPreferences.h:
456         * WebView.cpp:
457         (WebView::notifyPreferencesChanged):
458
459 2019-03-17  Fujii Hironori  <Hironori.Fujii@sony.com>
460
461         [Win][WK1] Null dereference in WebFrameNetworkingContext::storageSession
462         https://bugs.webkit.org/show_bug.cgi?id=195741
463
464         Reviewed by Ross Kirsling.
465
466         * WebCoreSupport/WebFrameNetworkingContext.cpp:
467         (WebFrameNetworkingContext::storageSession const): Added a null check of frame()->page() as well as Mac port does (Bug 183455).
468
469 2019-03-13  Ryan Haddad  <ryanhaddad@apple.com>
470
471         Unreviewed attempt to fix the Windows build after r242920.
472
473         * WebCoreSupport/WebFrameLoaderClient.h:
474
475 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
476
477         [Win] Fix a slew of simple clang-cl warnings.
478         https://bugs.webkit.org/show_bug.cgi?id=195652
479
480         Reviewed by Don Olmstead.
481
482         * Interfaces/AccessibleComparable.idl: -Wmissing-braces
483         * Plugins/PluginDatabaseWin.cpp: -Wunused-function
484         (WebCore::addJavaPluginDirectory): Deleted.
485         * WebCoreSupport/AcceleratedCompositingContext.cpp:
486         (AcceleratedCompositingContext::AcceleratedCompositingContext): -Wreorder
487         * WebCoreSupport/WebEditorClient.cpp:
488         (WebEditorUndoCommand::WebEditorUndoCommand): -Wreorder
489         (undoNameForEditAction): -Wswitch
490         * WebCoreSupport/WebFrameLoaderClient.cpp:
491         (WebFrameLoaderClient::WebFrameLoaderClient): -Wswitch
492         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): -Wunused-variable
493         * WebCoreSupport/WebInspectorClient.cpp:
494         (WebInspectorFrontendClient::WebInspectorFrontendClient): -Wreorder
495         * WebCoreSupport/WebInspectorClient.h: -Winconsistent-missing-override
496         * WebError.cpp:
497         (WebError::WebError): -Wreorder
498         * WebFrame.cpp:
499         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): -Wlogical-op-parentheses
500         * WebHistory.cpp: -Wunused-function (x5)
501         (areEqualOrClose): Deleted.
502         (addDayToSystemTime): Deleted.
503         (getDayBoundaries): Deleted.
504         (beginningOfDay): Deleted.
505         (dateKey): Deleted.
506         * WebNotificationCenter.cpp:
507         (WebNotificationCenter::removeObserver): -Wunused-variable
508         * WebView.cpp: -Wunused-function, -Wreorder
509         (WebView::addVisitedLinks): -Wunused-variable
510
511 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
512
513         Unreviewed, rolling out r242688, r242643, r242624.
514
515         Caused multiple layout test failures and crashes on iOS and macOS.
516
517         Reverted changeset:
518
519         "requestAnimationFrame should execute before the next frame"
520         https://bugs.webkit.org/show_bug.cgi?id=177484
521         https://trac.webkit.org/changeset/242624/webkit
522
523         * WebView.cpp:
524         (WebView::updateBackingStore):
525         (WebView::flushPendingGraphicsLayerChangesSoon):
526         (WebView::flushPendingGraphicsLayerChanges):
527
528 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
529
530         requestAnimationFrame should execute before the next frame
531         https://bugs.webkit.org/show_bug.cgi?id=177484
532
533         Reviewed by Simon Fraser.
534
535         * WebView.cpp:
536         (WebView::updateBackingStore):
537         (WebView::flushPendingGraphicsLayerChangesSoon):
538         (WebView::flushPendingGraphicsLayerChanges):
539         Call Page::renderingUpdate() which implements  "Update the rendering"
540         step of the HTML Event Loop specification.
541
542 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
543
544         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
545         https://bugs.webkit.org/show_bug.cgi?id=195346
546
547         Reviewed by Fujii Hironori.
548
549         * COMPropertyBag.h:
550         (HashType>::GetPropertyInfo):
551         (HashType>::LoadObject):
552         * DOMCoreClasses.cpp:
553         (DOMNode::addEventListener):
554         (DOMNode::removeEventListener):
555         (DOMWindow::addEventListener):
556         (DOMWindow::removeEventListener):
557         (DOMElement::font):
558         * DOMHTMLClasses.cpp:
559         (DOMHTMLInputElement::setValueForUser):
560         (DOMHTMLInputElement::replaceCharactersInRange):
561         * Plugins/PluginDatabaseWin.cpp:
562         (WebCore::addPluginPathsFromRegistry):
563         (WebCore::PluginDatabase::getPluginPathsInDirectories const):
564         (WebCore::addMozillaPluginDirectories):
565         (WebCore::addWindowsMediaPlayerPluginDirectory):
566         (WebCore::addAdobeAcrobatPluginDirectory):
567         (WebCore::addJavaPluginDirectory):
568         (WebCore::safariPluginsDirectory):
569         (WebCore::addMacromediaPluginDirectories):
570         * Plugins/PluginPackageWin.cpp:
571         (WebCore::getVersionInfo):
572         (WebCore::PluginPackage::fetchInfo):
573         (WebCore::PluginPackage::load):
574         * Plugins/PluginViewWin.cpp:
575         (WebCore::PluginView::handlePostReadFile):
576         * WebCoreSupport/WebChromeClient.cpp:
577         (WebChromeClient::runOpenPanel):
578         * WebCoreSupport/WebEditorClient.cpp:
579         (WebEditorClient::checkSpellingOfString):
580         (WebEditorClient::checkGrammarOfString):
581         * WebCoreSupport/WebInspectorClient.cpp:
582         (WebInspectorFrontendClient::updateWindowTitle):
583         * WebLocalizableStrings.cpp:
584         (LocalizedString::operator LPCTSTR const):
585         * WebView.cpp:
586         (createContextMenuFromItems):
587         (WebView::setToolTip):
588         Use wchar helpers as needed.
589
590 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
591
592         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
593         https://bugs.webkit.org/show_bug.cgi?id=195053
594         <rdar://problem/48134710>
595
596         Reviewed by Ryosuke Niwa.
597
598         * WebCoreSupport/WebEditorClient.h:
599
600 2019-02-20  Darin Adler  <darin@apple.com>
601
602         Finish removing String::format
603         https://bugs.webkit.org/show_bug.cgi?id=194893
604
605         Reviewed by Daniel Bates.
606
607         * FullscreenVideoController.cpp:
608         (timeToString): Use makeString and pad.
609
610 2019-02-27  Simon Fraser  <simon.fraser@apple.com>
611
612         Roll out r242014; it caused crashes in compositing logging (webkit.org/b/195141)
613
614         * FullscreenVideoController.cpp:
615         (timeToString):
616
617 2019-02-26  Philippe Normand  <pnormand@igalia.com>
618
619         [WPE] Add API for webview background color configuration
620         https://bugs.webkit.org/show_bug.cgi?id=192305
621
622         Reviewed by Michael Catanzaro.
623
624         * WebCoreSupport/WebFrameLoaderClient.cpp:
625         (WebFrameLoaderClient::transitionToCommittedForNewPage): Create
626         FrameView with background color.
627
628 2019-02-20  Darin Adler  <darin@apple.com>
629
630         Finish removing String::format
631         https://bugs.webkit.org/show_bug.cgi?id=194893
632
633         Reviewed by Daniel Bates.
634
635         * FullscreenVideoController.cpp:
636         (timeToString): Use makeString and pad.
637
638 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
639
640         Input type "formatSetInlineTextDirection" is dispatched when changing paragraph-level text direction
641         https://bugs.webkit.org/show_bug.cgi?id=194703
642         <rdar://problem/48111775>
643
644         Reviewed by Ryosuke Niwa.
645
646         * WebCoreSupport/WebEditorClient.cpp:
647         (undoNameForEditAction):
648
649 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
650
651         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
652         https://bugs.webkit.org/show_bug.cgi?id=194670
653         <rdar://problem/39066529>
654
655         Reviewed by Tim Horton.
656
657         * WebCoreSupport/WebEditorClient.cpp:
658         (WebEditorClient::replacementURLForResource): Deleted.
659         * WebCoreSupport/WebEditorClient.h:
660
661 2019-02-10  Darin Adler  <darin@apple.com>
662
663         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
664         https://bugs.webkit.org/show_bug.cgi?id=194487
665
666         Reviewed by Daniel Bates.
667
668         * WebView.cpp:
669         (webKitVersionString): Use makeString instead of String::format.
670
671 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
672
673         Allow pages to trigger programmatic paste from script on iOS
674         https://bugs.webkit.org/show_bug.cgi?id=194271
675         <rdar://problem/47808810>
676
677         Reviewed by Ryosuke Niwa.
678
679         * WebCoreSupport/WebEditorClient.h:
680
681 2019-02-06  Daniel Bates  <dabates@apple.com>
682
683         Standardize on ControlKey instead of CtrlKey
684         https://bugs.webkit.org/show_bug.cgi?id=194317
685
686         Reviewed by Tim Horton.
687
688         * AccessibleBase.cpp:
689         (AccessibleBase::get_accKeyboardShortcut):
690         * WebView.cpp:
691         (WebView::keyDown):
692
693 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
694
695         PageOverlayController's layers should be created lazily
696         https://bugs.webkit.org/show_bug.cgi?id=194199
697         rdar://problem/46571593
698
699         Reviewed by Tim Horton.
700
701         Expose PageOverlayController::hasDocumentOverlays() and hasViewOverlays()
702         and use them to only parent the overlay-hosting layers when necessary.
703
704         For document overlays, RenderLayerCompositor::appendDocumentOverlayLayers() can
705         simply do nothing if there are none. Updates are triggered via Page::installedPageOverlaysChanged(),
706         which calls FrameView::setNeedsCompositingConfigurationUpdate() to trigger the root layer
707         compositing updates that parents the layerWithDocumentOverlays().
708
709         View overlays are added to the layer tree via the DrawingArea. When we go between having
710         none and some view overlays, Page::installedPageOverlaysChanged() calls attachViewOverlayGraphicsLayer()
711         on the ChromeClient, and the DrawingArea responds by calling updateRootLayers() and scheduling a
712         compositing flush (this has to be done manually because view overlay layers are outside the
713         subtree managed by RenderLayerCompositor).
714         
715         Now that GraphicsLayers are ref-counted, we can let the DrawingArea simply retain its m_viewOverlayRootLayer;
716         there is no need for RenderLayerCompositor::attachRootLayer()/detachRootLayer() to do anything with view
717         overlay layers. This implies that a page can navigate (new FrameView) and view overlays will persist, without
718         having to be manually removed and re-added. We can also remove the Frame argument to attachViewOverlayGraphicsLayer().
719
720         * WebCoreSupport/WebChromeClient.cpp:
721         (WebChromeClient::attachViewOverlayGraphicsLayer):
722         * WebCoreSupport/WebChromeClient.h:
723
724 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
725
726         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
727         https://bugs.webkit.org/show_bug.cgi?id=194189
728
729         Reviewed by Geoffrey Garen.
730
731         Pass the policy check identifier around functions and store it in WebFramePolicyListener
732         so that we can send it back to WebCore with the navigation policy decision.
733
734         * WebCoreSupport/WebFrameLoaderClient.cpp:
735         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
736         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
737         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
738         (WebFrameLoaderClient::dispatchWillSubmitForm):
739         (WebFrameLoaderClient::setUpPolicyListener):
740         * WebCoreSupport/WebFrameLoaderClient.h:
741
742 2019-01-31  Alex Christensen  <achristensen@webkit.org>
743
744         Revert r238819 which is unneeded and caused a performance regression.
745         https://bugs.webkit.org/show_bug.cgi?id=192272
746         <rdar://problem/46664625>
747
748         * WebCoreSupport/WebFrameLoaderClient.cpp:
749         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
750         * WebCoreSupport/WebFrameLoaderClient.h:
751
752 2019-01-31  Takashi Komori  <Takashi.Komori@sony.com>
753
754         [Curl] Fix DRT crash related to private browsing.
755         https://bugs.webkit.org/show_bug.cgi?id=193816
756
757         Reviewed by Alex Christensen.
758
759         * WebCoreSupport/WebFrameNetworkingContext.cpp:
760         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
761
762 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
763
764         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
765         https://bugs.webkit.org/show_bug.cgi?id=193941
766
767         Reviewed by Alex Christensen.
768
769         * Plugins/PluginMessageThrottlerWin.cpp:
770         * Plugins/PluginView.cpp:
771         * Plugins/PluginViewWin.cpp:
772
773 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
774
775         Move FileSystem to WTF
776         https://bugs.webkit.org/show_bug.cgi?id=193602
777
778         Reviewed by Yusuke Suzuki.
779
780         * Plugins/PluginDatabase.cpp:
781         * Plugins/PluginPackage.h:
782         * Plugins/PluginStream.h:
783         * WebApplicationCache.cpp:
784         * WebDatabaseManager.cpp:
785         * WebDownloadCurl.cpp:
786         * WebPreferences.cpp:
787         * WebView.cpp:
788
789 2019-01-22  Alex Christensen  <achristensen@webkit.org>
790
791         Move NetworkStorageSession ownership to NetworkProcess
792         https://bugs.webkit.org/show_bug.cgi?id=193580
793
794         Reviewed by Geoff Garen.
795
796         * WebCoreSupport/WebFrameNetworkingContext.cpp:
797         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
798         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
799         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
800         (WebFrameNetworkingContext::storageSession const):
801         * WebDownloadCFNet.cpp:
802         (WebDownload::didReceiveAuthenticationChallenge):
803         * WebPreferences.cpp:
804         (WebPreferences::clearNetworkLoaderSession):
805         (WebPreferences::switchNetworkLoaderToNewTestingSession):
806
807 2019-01-15  Darin Adler  <darin@apple.com>
808
809         Use references rather than pointers for register/unregister functions, and more
810         https://bugs.webkit.org/show_bug.cgi?id=175028
811
812         Reviewed by Daniel Bates.
813
814         * Plugins/PluginView.cpp:
815         (WebCore::PluginView::startOrAddToUnstartedList): Pass a reference.
816         (WebCore::PluginView::~PluginView): Ditto.
817         * WebView.cpp:
818         (WebView::fullScreenClientWillEnterFullScreen): Ditto.
819         (WebView::fullScreenClientDidEnterFullScreen): Ditto.
820         (WebView::fullScreenClientDidExitFullScreen): Ditto.
821
822 2019-01-17  Per Arne Vollan  <pvollan@apple.com>
823
824         [Win][HighDPI] Repaint glitches when scrolling.
825         https://bugs.webkit.org/show_bug.cgi?id=173152
826         <rdar://problem/45269953>
827
828         Reviewed by Brent Fulgham.
829
830         Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
831         delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
832         Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
833
834         * WebView.cpp:
835         (WebView::scrollBackingStore):
836
837 2019-01-17  Alex Christensen  <achristensen@webkit.org>
838
839         Stop using NetworkStorageSession::storageSession in WebCore
840         https://bugs.webkit.org/show_bug.cgi?id=193529
841
842         Reviewed by Tim Horton.
843
844         * WebView.cpp:
845         (WebView::initWithFrame):
846
847 2019-01-15  Alex Christensen  <achristensen@webkit.org>
848
849         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
850         https://bugs.webkit.org/show_bug.cgi?id=193368
851
852         Reviewed by Geoff Garen.
853
854         * WebDownloadCFNet.cpp:
855         (WebDownload::didReceiveAuthenticationChallenge):
856
857 2019-01-15  Alex Christensen  <achristensen@webkit.org>
858
859         Fix Windows build after r240014
860         https://bugs.webkit.org/show_bug.cgi?id=161106
861
862         * WebView.cpp:
863
864 2019-01-15  Alex Christensen  <achristensen@webkit.org>
865
866         Stop using CookiesStrategy
867         https://bugs.webkit.org/show_bug.cgi?id=161106
868
869         Reviewed by Don Olmstead and Antti Koivisto.
870
871         * Plugins/PluginView.cpp:
872         (WebCore::PluginView::getValueForURL):
873         (WebCore::PluginView::setValueForURL):
874         * WebCoreSupport/WebPlatformStrategies.cpp:
875         (WebPlatformStrategies::createBlobRegistry):
876         (WebPlatformStrategies::createCookiesStrategy): Deleted.
877         (WebPlatformStrategies::cookiesForDOM): Deleted.
878         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
879         (WebPlatformStrategies::cookiesEnabled): Deleted.
880         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
881         (WebPlatformStrategies::getRawCookies): Deleted.
882         (WebPlatformStrategies::deleteCookie): Deleted.
883         * WebCoreSupport/WebPlatformStrategies.h:
884         * WebView.cpp:
885         (WebView::initWithFrame):
886
887 2019-01-08  Alex Christensen  <achristensen@webkit.org>
888
889         Stop using NetworkStorageSession in WebProcess
890         https://bugs.webkit.org/show_bug.cgi?id=193236
891
892         Reviewed by Don Olmstead.
893
894         * WebCoreSupport/WebFrameNetworkingContext.cpp:
895         (WebFrameNetworkingContext::storageSession const):
896         * WebCoreSupport/WebFrameNetworkingContext.h:
897         * WebCoreSupport/WebPlatformStrategies.cpp:
898         (WebPlatformStrategies::cookiesForDOM):
899         (WebPlatformStrategies::setCookiesFromDOM):
900         (WebPlatformStrategies::cookiesEnabled):
901         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
902         (WebPlatformStrategies::getRawCookies):
903         (WebPlatformStrategies::deleteCookie):
904         * WebCoreSupport/WebPlatformStrategies.h:
905
906 2019-01-08  Alex Christensen  <achristensen@webkit.org>
907
908         Unreviewed, rolling out r239727.
909
910         Broke API tests
911
912         Reverted changeset:
913
914         "Stop using NetworkStorageSession in WebProcess"
915         https://bugs.webkit.org/show_bug.cgi?id=193236
916         https://trac.webkit.org/changeset/239727
917
918 2018-12-24  Fujii Hironori  <Hironori.Fujii@sony.com>
919
920         Remove "using namespace std;"
921         https://bugs.webkit.org/show_bug.cgi?id=192973
922
923         Reviewed by Alex Christensen.
924
925         * FullscreenVideoController.cpp:
926         * WebFrame.cpp:
927         (WebFrame::drawFooter):
928         * WebHistory.cpp:
929         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
930         * WebKitQuartzCoreAdditions/CAView.cpp:
931         * WebView.cpp:
932         (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
933         (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
934         (WebView::setCacheModel):
935         (WebView::maxCacheModelInAnyInstance):
936
937 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
938
939         Use Ref<> as much as possible
940         https://bugs.webkit.org/show_bug.cgi?id=192808
941
942         Reviewed by Alex Christensen.
943
944         * Plugins/PluginDatabase.cpp:
945         (WebCore::PluginDatabase::refresh):
946         * Plugins/PluginView.cpp:
947         (WebCore::PluginView::mediaCanStart):
948         (WebCore::PluginView::performRequest):
949         (WebCore::PluginView::bindingInstance):
950         * Plugins/PluginView.h:
951         * WebCoreSupport/WebFrameLoaderClient.cpp:
952         (WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
953         (WebFrameLoaderClient::createPlugin):
954         (WebFrameLoaderClient::createJavaAppletWidget):
955         * WebCoreSupport/WebFrameLoaderClient.h:
956         * WebFrame.cpp:
957         (WebFrame::loadData):
958         (WebFrame::loadPlainTextString):
959         (WebFrame::loadHTMLString):
960         * WebFrame.h:
961         * WebKitQuartzCoreAdditions/CAView.cpp:
962         (WKQCA::CAView::create):
963         * WebKitQuartzCoreAdditions/CAView.h:
964         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
965         (WKQCA::CVDisplayLink::create):
966         * WebKitQuartzCoreAdditions/CVDisplayLink.h:
967         * WebKitQuartzCoreAdditions/ImageConversion.cpp:
968         (WKQCA::getImageCopy):
969         * WebView.cpp:
970         (WebView::addUserScriptToGroup):
971         (WebView::addUserStyleSheetToGroup):
972
973 2018-12-20  Chris Dumez  <cdumez@apple.com>
974
975         Use Optional::valueOr() instead of Optional::value_or()
976         https://bugs.webkit.org/show_bug.cgi?id=192933
977
978         Reviewed by Geoffrey Garen.
979
980         * WebSecurityOrigin.cpp:
981         (WebSecurityOrigin::port):
982
983 2018-12-19  Chris Dumez  <cdumez@apple.com>
984
985         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
986         https://bugs.webkit.org/show_bug.cgi?id=192728
987         <rdar://problem/46746779>
988
989         Reviewed by Geoff Garen.
990
991         * Plugins/*:
992         * WebCoreSupport/*:
993
994 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
995
996         [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag
997         https://bugs.webkit.org/show_bug.cgi?id=192617
998
999         Reviewed by Alex Christensen.
1000
1001         * COMEnumVariant.h:
1002         (COMEnumVariant<ContainerType>::adopt): Removed 'typename' from non dependent names.
1003         (COMEnumVariant<ContainerType>::createInstance): Ditto.
1004         (COMEnumVariant<ContainerType>::Next): Prepend 'typename' for dependent names.
1005         * COMPropertyBag.h:
1006         (HashType>::createInstance): Removed 'typename' from non dependent names.
1007         (HashType>::adopt): Ditto.
1008         (HashType>::Read): Replaced dependent name 'HashMapType::const_iterator' with 'auto'.
1009         (HashType>::GetPropertyInfo): Ditto.
1010
1011 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1012
1013         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
1014         https://bugs.webkit.org/show_bug.cgi?id=192618
1015
1016         Reviewed by Alex Christensen.
1017
1018         Classes which implement COM interface usually doesn't need the
1019         virtual destructor because it has Release() virtual method to
1020         destruct itself.
1021
1022         Marked 'final' such classes to suppress clang-cl's compilation
1023         warnings.
1024
1025         * COMEnumVariant.h:
1026         * COMPropertyBag.h:
1027         * DefaultDownloadDelegate.h:
1028         * DefaultPolicyDelegate.h:
1029         * MemoryStream.h:
1030         * WebActionPropertyBag.h:
1031         * WebApplicationCache.h:
1032         * WebArchive.h:
1033         * WebBackForwardList.h:
1034         * WebCache.h:
1035         * WebCoreStatistics.h:
1036         * WebCoreSupport/WebEditorClient.cpp:
1037         * WebCoreSupport/WebInspectorDelegate.h:
1038         * WebDataSource.h:
1039         * WebDatabaseManager.cpp:
1040         * WebDatabaseManager.h:
1041         * WebDownload.h:
1042         * WebDropSource.h:
1043         * WebElementPropertyBag.h:
1044         * WebError.h:
1045         * WebFrame.cpp:
1046         * WebFrame.h:
1047         * WebFramePolicyListener.h:
1048         * WebGeolocationPolicyListener.h:
1049         * WebGeolocationPosition.h:
1050         * WebHTMLRepresentation.h:
1051         * WebHistory.h:
1052         * WebHistoryItem.h:
1053         * WebInspector.h:
1054         * WebJavaScriptCollector.h:
1055         * WebKitClassFactory.h:
1056         * WebKitMessageLoop.h:
1057         * WebKitStatistics.h:
1058         * WebMutableURLRequest.h:
1059         * WebNavigationData.h:
1060         * WebNotification.h:
1061         * WebNotificationCenter.h:
1062         * WebPreferences.h:
1063         * WebResource.h:
1064         * WebScriptWorld.h:
1065         * WebSecurityOrigin.h:
1066         * WebSerializedJSValue.h:
1067         * WebTextRenderer.h:
1068         * WebURLAuthenticationChallenge.h:
1069         * WebURLAuthenticationChallengeSender.h:
1070         * WebURLCredential.h:
1071         * WebURLProtectionSpace.h:
1072         * WebURLResponse.h:
1073         * WebUserContentURLPattern.h:
1074         * WebView.cpp:
1075         * WebView.h:
1076         * WebWorkersPrivate.h:
1077
1078 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1079
1080         [Win][Clang] Fix warning -Wmissing-field-initializers
1081         https://bugs.webkit.org/show_bug.cgi?id=192584
1082
1083         Reviewed by Yusuke Suzuki.
1084
1085         Initialize a struct with '{ }' instead of '= {0}'.
1086
1087         * WebKitMessageLoop.cpp:
1088         (WebKitMessageLoop::run):
1089         * WebView.cpp:
1090         (WebView::onMenuCommand):
1091         (WebView::gesture):
1092         (WebView::setShouldInvertColors):
1093         (WebView::initializeToolTipWindow):
1094         (WebView::setToolTip):
1095         (WebView::fullScreenClientForceRepaint):
1096
1097 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1098
1099         Turn WritingDirection into an enum class
1100         https://bugs.webkit.org/show_bug.cgi?id=192401
1101         Work towards <rdar://problem/42075638>
1102
1103         Reviewed by Dan Bernstein.
1104
1105         Change WritingDirection from an enum to an enum class. No change in behavior.
1106
1107         * WebFrame.cpp:
1108         (WebFrame::setTextDirection):
1109
1110 2018-12-03  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1111
1112         Use WallTime for file time
1113         https://bugs.webkit.org/show_bug.cgi?id=192287
1114
1115         Reviewed by Darin Adler.
1116
1117         * Plugins/PluginDatabase.cpp:
1118         (WebCore::PluginDatabase::refresh):
1119
1120 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1121
1122         Fix Windows build.
1123
1124         * WebView.cpp:
1125
1126 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1127
1128         Fix Windows build.
1129
1130         * WebCoreSupport/WebFrameLoaderClient.h:
1131
1132 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1133
1134         Fix Windows build.
1135
1136         * WebCoreSupport/WebFrameLoaderClient.h:
1137
1138 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1139
1140         Move URL from WebCore to WTF
1141         https://bugs.webkit.org/show_bug.cgi?id=190234
1142
1143         Reviewed by Keith Miller.
1144
1145         * MarshallingHelpers.cpp:
1146         * MarshallingHelpers.h:
1147         * Plugins/PluginDatabase.cpp:
1148         * Plugins/PluginDatabase.h:
1149         * Plugins/PluginDatabaseWin.cpp:
1150         * Plugins/PluginStream.h:
1151         * Plugins/PluginView.h:
1152         * WebCoreSupport/WebContextMenuClient.h:
1153         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
1154         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
1155         * WebCoreSupport/WebFrameLoaderClient.h:
1156         * WebCoreSupport/WebPlatformStrategies.h:
1157         * WebCoreSupport/WebPluginInfoProvider.cpp:
1158         (WebPluginInfoProvider::webVisiblePluginInfo):
1159         * WebCoreSupport/WebPluginInfoProvider.h:
1160         * WebCoreSupport/WebVisitedLinkStore.h:
1161         * WebDataSource.cpp:
1162         * WebDownload.h:
1163         * WebElementPropertyBag.cpp:
1164         * WebFrame.h:
1165         * WebHistory.cpp:
1166         * WebHistory.h:
1167         * WebHistoryItem.cpp:
1168         * WebResource.cpp:
1169         (WebResource::WebResource):
1170         * WebResource.h:
1171         * WebSecurityOrigin.cpp:
1172         * WebURLResponse.cpp:
1173         (WebURLResponse::createInstance):
1174         * WebUserContentURLPattern.cpp:
1175         * WebView.h:
1176
1177 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1178
1179         Remove dead code from an earlier attempt at implementing safe browsing
1180         https://bugs.webkit.org/show_bug.cgi?id=192067
1181
1182         Reviewed by Chris Dumez.
1183
1184         * WebCoreSupport/WebFrameLoaderClient.cpp:
1185         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1186         * WebCoreSupport/WebFrameLoaderClient.h:
1187
1188 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
1189
1190         [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
1191         https://bugs.webkit.org/show_bug.cgi?id=191959
1192
1193         Reviewed by Alex Christensen.
1194
1195         * MarshallingHelpers.h: Removed extra "MarshallingHelpers::" of windowsEpochAbsoluteTime declaration.
1196
1197 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
1198
1199         [Win] Reduce the use of WKSI library calls: CoreAnimation
1200         https://bugs.webkit.org/show_bug.cgi?id=191777
1201         <rdar://problem/46140542>
1202
1203         Reviewed by Zalan Bujtas.
1204
1205         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
1206         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
1207         directives for WebKitSystemInterface.lib.
1208
1209         * FullscreenVideoController.cpp:
1210         * WebKitGraphics.cpp:
1211         * WebPreferences.cpp:
1212
1213 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1214
1215         Address post-review feedback after r238438
1216         https://bugs.webkit.org/show_bug.cgi?id=191913
1217
1218         Reviewed by Ryosuke Niwa.
1219
1220         * AccessibleTextImpl.cpp:
1221         (AccessibleText::replaceText):
1222
1223 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1224
1225         Web Inspector: "Reload Web Inspector" button no longer partially works
1226         https://bugs.webkit.org/show_bug.cgi?id=191773
1227         <rdar://problem/46139932>
1228
1229         Reviewed by Devin Rousso.
1230
1231         * WebCoreSupport/WebInspectorClient.cpp:
1232         (WebInspectorFrontendClient::reopen):
1233         * WebCoreSupport/WebInspectorClient.h:
1234
1235 2018-11-17  Devin Rousso  <drousso@apple.com>
1236
1237         Web Inspector: Network: add button to show system certificate dialog
1238         https://bugs.webkit.org/show_bug.cgi?id=191458
1239         <rdar://problem/45977019>
1240
1241         Reviewed by Joseph Pecoraro.
1242
1243         * WebCoreSupport/WebInspectorClient.h:
1244         * WebCoreSupport/WebInspectorClient.cpp:
1245         (WebInspectorFrontendClient::showCertificate): Added.
1246
1247 2018-11-16  Brent Fulgham  <bfulgham@apple.com>
1248
1249         [Win] Reduce the use of WKSI library calls: CFNetwork
1250         https://bugs.webkit.org/show_bug.cgi?id=191718
1251         <rdar://problem/46108732>
1252
1253         Reviewed by Alex Christensen.
1254
1255         Remove custom WKSI CFNetwork calls, since the SPI is already documented in PAL. Just
1256         make the same calls on Windows, like we did for iOS and macOS back in 2017.
1257
1258         * WebCache.cpp:
1259         (WebCache::cacheFolder):
1260         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1261         * WebCoreSupport/WebPlatformStrategies.cpp:
1262         * WebError.cpp:
1263         (WebError::localizedDescription):
1264         (WebError::sslPeerCertificate):
1265         * WebURLResponse.cpp:
1266         (WebURLResponse::sslPeerCertificate):
1267         (WebURLResponse::certificateDictionary const):
1268         * WebView.cpp:
1269         (WebView::setCacheModel):
1270
1271 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
1272
1273         [Win] Reduce the use of WKSI library calls: Font Handling
1274         https://bugs.webkit.org/show_bug.cgi?id=191701
1275         <rdar://problem/46104809>
1276
1277         Reviewed by Myles C. Maxfield.
1278
1279         Update to use the old font handling routines moved from WKSI to FontCascade.
1280
1281         * WebPreferences.cpp:
1282         (WebPreferences::setFontSmoothing):
1283         (WebPreferences::setFontSmoothingContrast):
1284         * WebView.cpp:
1285         (systemParameterChanged):
1286
1287 2018-11-14  Timothy Hatcher  <timothy@apple.com>
1288
1289         Default the view background color and text color to different values when in dark mode.
1290         https://bugs.webkit.org/show_bug.cgi?id=191607
1291         rdar://problem/46045854
1292
1293         Reviewed by Dean Jackson.
1294
1295         * WebFrame.cpp:
1296         (WebFrame::updateBackground): Drop backgroundColor.
1297         * WebCoreSupport/WebFrameLoaderClient.cpp:
1298         (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor.
1299
1300 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1301
1302         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1303         https://bugs.webkit.org/show_bug.cgi?id=191612
1304
1305         Reviewed by Matt Baker.
1306
1307         * WebCoreSupport/WebInspectorClient.cpp:
1308         (WebInspectorFrontendClient::destroyInspectorView):
1309
1310 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
1311
1312         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
1313         https://bugs.webkit.org/show_bug.cgi?id=189230
1314         <rdar://problem/44050379>
1315
1316         Reviewed by Joseph Pecoraro.
1317
1318         Runs all png images through zopflipng. This results in a smaller file
1319         size and takes care of this issue as a byproduct.
1320
1321         * WebKit.resources/deleteButton.png:
1322         * WebKit.resources/deleteButtonPressed.png:
1323         * WebKit.resources/fsVideoAudioVolumeHigh.png:
1324         * WebKit.resources/fsVideoAudioVolumeLow.png:
1325         * WebKit.resources/fsVideoExitFullscreen.png:
1326         * WebKit.resources/fsVideoPause.png:
1327         * WebKit.resources/fsVideoPlay.png:
1328         * WebKit.resources/missingImage.png:
1329         * WebKit.resources/nullplugin.png:
1330         * WebKit.resources/panEastCursor.png:
1331         * WebKit.resources/panIcon.png:
1332         * WebKit.resources/panNorthCursor.png:
1333         * WebKit.resources/panNorthEastCursor.png:
1334         * WebKit.resources/panNorthWestCursor.png:
1335         * WebKit.resources/panSouthCursor.png:
1336         * WebKit.resources/panSouthEastCursor.png:
1337         * WebKit.resources/panSouthWestCursor.png:
1338         * WebKit.resources/panWestCursor.png:
1339         * WebKit.resources/searchCancel.png:
1340         * WebKit.resources/searchCancelPressed.png:
1341         * WebKit.resources/searchMagnifier.png:
1342         * WebKit.resources/searchMagnifierResults.png:
1343         * WebKit.resources/textAreaResizeCorner.png:
1344         * WebKit.resources/verticalTextCursor.png:
1345         * WebKit.resources/zoomInCursor.png:
1346         * WebKit.resources/zoomOutCursor.png:
1347
1348 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1349
1350         Unreviewed Windows build fix for r238049.
1351
1352         * WebView.cpp:
1353         (WebView::initWithFrame):
1354
1355 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1356
1357         Unreviewed MSVC build fix after r238039 (and r238046).
1358
1359         * WebDocumentLoader.h:
1360         * WebView.cpp:
1361         (WebView::setShouldApplyMacFontAscentHack):
1362
1363 2018-11-09  Antti Koivisto  <antti@apple.com>
1364
1365         Use OptionSet for layout milestones
1366         https://bugs.webkit.org/show_bug.cgi?id=191470
1367
1368         Reviewed by Dean Jackson.
1369
1370         * WebCoreSupport/WebFrameLoaderClient.cpp:
1371         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1372         * WebCoreSupport/WebFrameLoaderClient.h:
1373
1374 2018-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1375
1376         WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1377         https://bugs.webkit.org/show_bug.cgi?id=191455
1378
1379         Reviewed by Brent Fulgham.
1380
1381         * WebHistory.h: Marked with 'override' and removed 'virtual'.
1382
1383 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1384
1385         Add a storage limit for IndexedDB
1386         https://bugs.webkit.org/show_bug.cgi?id=190598
1387         <rdar://problem/44654715>
1388
1389         Reviewed by Chris Dumez.
1390
1391         * Interfaces/IWebDatabaseManager.idl:
1392         * WebDatabaseManager.cpp:
1393         (WebDatabaseManager::setIDBPerOriginQuota):
1394         * WebDatabaseManager.h:
1395
1396 2018-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1397
1398         [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
1399         https://bugs.webkit.org/show_bug.cgi?id=191105
1400
1401         Reviewed by Brent Fulgham.
1402
1403         * DOMHTMLClasses.h:
1404         (DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
1405         instead of own setNodeValue.
1406
1407 2018-10-25  Antoine Quint  <graouts@apple.com>
1408
1409         [Web Animations] Turn Web Animations CSS Integration off by default
1410         https://bugs.webkit.org/show_bug.cgi?id=190901
1411
1412         Reviewed by Dean Jackson.
1413
1414         * WebPreferences.cpp:
1415         (WebPreferences::initializeDefaultSettings):
1416
1417 2018-10-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1418
1419         [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1420         https://bugs.webkit.org/show_bug.cgi?id=190744
1421
1422         Reviewed by Alex Christensen.
1423
1424         clang-cl reports compilation warnings for inconsistent 'override'
1425         keyword usage.
1426
1427         WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
1428         This can't be marked 'override' if !USE(CA).
1429
1430         * WebView.cpp:
1431         (WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).
1432         * WebView.h: Marked all overriding member function declarations of WebView 'override'.
1433         Declare flushPendingGraphicsLayerChanges only if USE(CA).
1434
1435 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1436
1437         Clean up FrameLoader two-state enums
1438         https://bugs.webkit.org/show_bug.cgi?id=190731
1439
1440         Reviewed by Chris Dumez.
1441
1442         * WebCoreSupport/WebFrameLoaderClient.cpp:
1443         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1444         * WebCoreSupport/WebFrameLoaderClient.h:
1445
1446 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1447
1448         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1449         https://bugs.webkit.org/show_bug.cgi?id=190675
1450
1451         Reviewed by Chris Dumez.
1452
1453         * BackForwardList.cpp:
1454         (BackForwardList::backItem):
1455         (BackForwardList::currentItem):
1456         (BackForwardList::forwardItem):
1457         (BackForwardList::backListCount const):
1458         (BackForwardList::forwardListCount const):
1459         (BackForwardList::itemAtIndex):
1460         * BackForwardList.h:
1461
1462 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
1463
1464         Unreviewed attempt to fix the Windows build after r237112.
1465
1466         * Plugins/PluginView.cpp:
1467         (WebCore::PluginView::performRequest):
1468
1469 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1470
1471         Replace HistoryItem* with HistoryItem& where possible
1472         https://bugs.webkit.org/show_bug.cgi?id=190617
1473
1474         Reviewed by Chris Dumez.
1475
1476         * BackForwardList.cpp:
1477         (BackForwardList::goToItem):
1478         * BackForwardList.h:
1479         * WebBackForwardList.cpp:
1480         (WebBackForwardList::goToItem):
1481
1482 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1483
1484         Fix Windows build.
1485
1486         * WebView.cpp:
1487         (WebView::loadBackForwardListFromOtherView):
1488
1489 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1490
1491         Fix WinCairo build.
1492
1493         * WebView.cpp:
1494         (WebView::backForwardList):
1495
1496 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1497
1498         Modernize BackForwardClient.h
1499         https://bugs.webkit.org/show_bug.cgi?id=190610
1500
1501         Reviewed by Chris Dumez.
1502
1503         * BackForwardList.cpp:
1504         (BackForwardList::backListCount const):
1505         (BackForwardList::forwardListCount const):
1506         (BackForwardList::backListCount): Deleted.
1507         (BackForwardList::forwardListCount): Deleted.
1508         * BackForwardList.h:
1509         * WebView.cpp:
1510         (WebView::initWithFrame):
1511         (WebView::backForwardList):
1512
1513 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1514
1515         Remove unused WebView._globalHistoryItem
1516         https://bugs.webkit.org/show_bug.cgi?id=190601
1517
1518         Reviewed by Chris Dumez.
1519
1520         * WebCoreSupport/WebFrameLoaderClient.cpp:
1521         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1522         * WebCoreSupport/WebFrameLoaderClient.h:
1523         * WebView.cpp:
1524         (WebView::globalHistoryItem):
1525         (WebView::setGlobalHistoryItem): Deleted.
1526         * WebView.h:
1527
1528 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1529
1530         Remove unused parameters from FrameLoaderClient::createFrame
1531         https://bugs.webkit.org/show_bug.cgi?id=190587
1532
1533         Reviewed by Chris Dumez.
1534
1535         * WebCoreSupport/WebFrameLoaderClient.cpp:
1536         (WebFrameLoaderClient::createFrame):
1537         * WebCoreSupport/WebFrameLoaderClient.h:
1538
1539 2018-10-15  Chris Dumez  <cdumez@apple.com>
1540
1541         Unreviewed Windows build fix after r237112.
1542
1543         * Plugins/PluginView.cpp:
1544         (WebCore::PluginView::performRequest):
1545         (WebCore::PluginView::load):
1546
1547 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1548
1549         Remove InjectedBundle processing of back/forward lists
1550         https://bugs.webkit.org/show_bug.cgi?id=190459
1551
1552         Reviewed by Chris Dumez.
1553
1554         * WebCoreSupport/WebFrameLoaderClient.cpp:
1555         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1556         * WebCoreSupport/WebFrameLoaderClient.h:
1557
1558 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1559
1560         Remove ParsedURLString
1561         https://bugs.webkit.org/show_bug.cgi?id=190154
1562
1563         Reviewed by Chris Dumez.
1564
1565         * WebDownloadCurl.cpp:
1566         (WebDownload::initWithRequest):
1567         * WebURLResponse.cpp:
1568         (WebURLResponse::createInstance):
1569
1570 2018-09-28  Chris Dumez  <cdumez@apple.com>
1571
1572         Drop support for cross-origin-window-policy header
1573         https://bugs.webkit.org/show_bug.cgi?id=190081
1574
1575         Reviewed by Ryosuke Niwa.
1576
1577         * WebPreferenceKeysPrivate.h:
1578         * WebPreferences.cpp:
1579         (WebPreferences::initializeDefaultSettings):
1580         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1581         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1582         * WebView.cpp:
1583         (WebView::notifyPreferencesChanged):
1584
1585 2018-09-27  Antoine Quint  <graouts@apple.com>
1586
1587         [Web Animations] Turn Web Animations with CSS integration on
1588         https://bugs.webkit.org/show_bug.cgi?id=184819
1589         <rdar://problem/39597337>
1590
1591         Reviewed by Dean Jackson.
1592
1593         * WebPreferences.cpp:
1594         (WebPreferences::initializeDefaultSettings):
1595
1596 2018-09-21  Alex Christensen  <achristensen@webkit.org>
1597
1598         Use a Variant for FormDataElement
1599         https://bugs.webkit.org/show_bug.cgi?id=189777
1600
1601         Reviewed by Chris Dumez.
1602
1603         * WebMutableURLRequest.cpp:
1604         (WebMutableURLRequest::setHTTPBody):
1605
1606 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1607
1608         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
1609         https://bugs.webkit.org/show_bug.cgi?id=189612
1610
1611         Reviewed by Alex Christensen.
1612
1613         Non-trivial types can't be used as aruguments of LOG_ERROR and
1614         ASSERT_WITH_MESSAGE.
1615
1616         * DefaultPolicyDelegate.cpp:
1617         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
1618         static_cast<BSTR> to convert BString.
1619         * WebLocalizableStrings.cpp:
1620         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
1621         char* by using 'key.utf8().data()'.
1622
1623 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
1624
1625         Unreviewed, rolling out r235953.
1626
1627         Caused layout test crashes under GuardMalloc.
1628
1629         Reverted changeset:
1630
1631         "Make GraphicsLayers ref-counted, so their tree can persist
1632         when disconnected from RenderLayerBackings"
1633         https://bugs.webkit.org/show_bug.cgi?id=189521
1634         https://trac.webkit.org/changeset/235953
1635
1636 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1637
1638         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
1639         https://bugs.webkit.org/show_bug.cgi?id=189538
1640
1641         Reviewed by Per Arne Vollan.
1642
1643         * WebPreferences.cpp:
1644         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
1645         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
1646         Apply static_cast to the result of OR-ed CFPropertyListFormat.
1647         (WebPreferences::screenFontSubstitutionEnabled):
1648         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
1649
1650 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1651
1652         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
1653         https://bugs.webkit.org/show_bug.cgi?id=189539
1654
1655         Reviewed by Alex Christensen.
1656
1657         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
1658         * WebCoreSupport/WebInspectorClient.cpp:
1659         (WebInspectorWndProc): Ditto.
1660         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
1661         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
1662
1663 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1664
1665         Refactor WebCore::EditAction to be an 8-bit enum class
1666         https://bugs.webkit.org/show_bug.cgi?id=189383
1667
1668         Reviewed by Dan Bernstein.
1669
1670         * WebCoreSupport/WebEditorClient.cpp:
1671         (undoNameForEditAction):
1672
1673 2018-09-04  Frederic Wang  <fwang@igalia.com>
1674
1675         Add basic support for ScrollIntoViewOptions
1676         https://bugs.webkit.org/show_bug.cgi?id=189258
1677
1678         Reviewed by Simon Fraser.
1679
1680         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
1681         can build despite the new scrollIntoView function.
1682
1683 2018-08-31  Chris Dumez  <cdumez@apple.com>
1684
1685         Unreviewed Windows build fix after r235562.
1686
1687         * WebCoreSupport/WebFrameLoaderClient.cpp:
1688         (WebFrameLoaderClient::dispatchWillSubmitForm):
1689
1690 2018-08-31  Chris Dumez  <cdumez@apple.com>
1691
1692         Assertion hit in ~CompletionHandler() from ~WebFrame()
1693         https://bugs.webkit.org/show_bug.cgi?id=189199
1694         <rdar://problem/42657233>
1695
1696         Reviewed by Youenn Fablet.
1697
1698         * WebCoreSupport/WebFrameLoaderClient.cpp:
1699         (WebFrameLoaderClient::dispatchWillSubmitForm):
1700         * WebCoreSupport/WebFrameLoaderClient.h:
1701
1702 2018-08-31  Frederic Wang  <fwang@igalia.com>
1703
1704         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1705         https://bugs.webkit.org/show_bug.cgi?id=182053
1706
1707         Reviewed by Simon Fraser.
1708
1709         Add developer flag to use standard behavior for scrolling* attributes.
1710
1711         * Interfaces/IWebPreferencesPrivate.idl:
1712         * WebPreferenceKeysPrivate.h:
1713         * WebPreferences.cpp:
1714         (WebPreferences::initializeDefaultSettings):
1715         (WebPreferences::CSSOMViewScrollingAPIEnabled):
1716         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
1717         * WebPreferences.h:
1718         * WebView.cpp:
1719         (WebView::notifyPreferencesChanged):
1720
1721 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
1722
1723         [CMake] Replace AVFoundationSupport.py using CMake
1724         https://bugs.webkit.org/show_bug.cgi?id=182891
1725
1726         Reviewed by Per Arne Vollan.
1727
1728         Remove references to the config.h contained in WebCore as it should
1729         not be accessible from outside of WebCore.
1730
1731         * WebKitPrefix.h:
1732
1733 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1734
1735         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
1736         https://bugs.webkit.org/show_bug.cgi?id=188496
1737         <rdar://problem/43216836>
1738
1739         Reviewed by Tim Horton.
1740
1741         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
1742         header directly.
1743
1744         * WebCoreSupport/WebDragClient.cpp:
1745
1746 2018-08-17  Alex Christensen  <achristensen@webkit.org>
1747
1748         Add some plumbing for safe browsing
1749         https://bugs.webkit.org/show_bug.cgi?id=188709
1750
1751         Reviewed by Tim Horton.
1752
1753         * WebCoreSupport/WebFrameLoaderClient.cpp:
1754         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1755         * WebCoreSupport/WebFrameLoaderClient.h:
1756
1757 2018-08-02  David Fenton  <david_fenton@apple.com>
1758
1759         Unreviewed, rolling out r234489.
1760
1761         Caused 50+ crashes and 60+ API failures on iOS
1762
1763         Reverted changeset:
1764
1765         "[WTF] Rename String::format to String::deprecatedFormat"
1766         https://bugs.webkit.org/show_bug.cgi?id=188191
1767         https://trac.webkit.org/changeset/234489
1768
1769 2018-08-01  Tomas Popela  <tpopela@redhat.com>
1770
1771         [WTF] Rename String::format to String::deprecatedFormat
1772         https://bugs.webkit.org/show_bug.cgi?id=188191
1773
1774         Reviewed by Darin Adler.
1775
1776         It should be replaced with string concatenation.
1777
1778         * FullscreenVideoController.cpp:
1779         (timeToString):
1780         * WebView.cpp:
1781         (webKitVersionString):
1782
1783 2018-07-30  Rob Buis  <rbuis@igalia.com>
1784
1785         https://bugs.webkit.org/show_bug.cgi?id=188137
1786         Merge PlatformCookieJar functions into NetworkStorageSession
1787
1788         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1789
1790         Reviewed by Alex Christensen.
1791
1792         * WebCoreSupport/WebPlatformStrategies.cpp:
1793         (WebPlatformStrategies::cookiesForDOM):
1794         (WebPlatformStrategies::setCookiesFromDOM):
1795         (WebPlatformStrategies::cookiesEnabled):
1796         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1797         (WebPlatformStrategies::getRawCookies):
1798         (WebPlatformStrategies::deleteCookie):
1799         * WebPreferences.cpp:
1800         (WebPreferences::clearNetworkLoaderSession):
1801
1802 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
1803
1804         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
1805         https://bugs.webkit.org/show_bug.cgi?id=187963
1806
1807         Reviewed by Alex Christensen.
1808
1809         * Plugins/PluginPackageWin.cpp:
1810         (WebCore::PluginPackage::fetchInfo):
1811         Update split/splitAllowingEmptyEntries usage.
1812
1813 2018-07-18  Antoine Quint  <graouts@apple.com>
1814
1815         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
1816         https://bugs.webkit.org/show_bug.cgi?id=187722
1817
1818         Reviewed by Myles Maxfield.
1819
1820         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
1821
1822         * DOMCoreClasses.cpp:
1823         (DOMElement::font):
1824
1825 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1826
1827         Disable cross-origin-window-policy by default
1828         https://bugs.webkit.org/show_bug.cgi?id=187509
1829
1830         Reviewed by Chris Dumez.
1831
1832         * WebPreferences.cpp:
1833         (WebPreferences::initializeDefaultSettings):
1834
1835 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1836
1837         [WTF] Add user-defined literal for ASCIILiteral
1838         https://bugs.webkit.org/show_bug.cgi?id=186839
1839
1840         Reviewed by Darin Adler.
1841
1842         * Plugins/PluginStream.cpp:
1843         (WebCore::PluginStream::startStream):
1844         * WebCoreSupport/WebContextMenuClient.cpp:
1845         (WebContextMenuClient::searchWithGoogle):
1846
1847 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1848
1849         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
1850         https://bugs.webkit.org/show_bug.cgi?id=186623
1851
1852         Reviewed by Youenn Fablet.
1853
1854         * WebCoreSupport/WebPluginInfoProvider.cpp:
1855         (WebPluginInfoProvider::pluginInfo):
1856         (WebPluginInfoProvider::webVisiblePluginInfo):
1857         * WebCoreSupport/WebPluginInfoProvider.h:
1858
1859 2018-06-13  Chris Dumez  <cdumez@apple.com>
1860
1861         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1862         https://bugs.webkit.org/show_bug.cgi?id=186545
1863
1864         Reviewed by Brady Eidson.
1865
1866         Update client delegate now that parameter type has changed.
1867
1868         * WebCoreSupport/WebFrameLoaderClient.cpp:
1869         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1870         * WebCoreSupport/WebFrameLoaderClient.h:
1871
1872 2018-06-11  Chris Dumez  <cdumez@apple.com>
1873
1874         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
1875         https://bugs.webkit.org/show_bug.cgi?id=186441
1876
1877         Reviewed by Brady Eidson.
1878
1879         Rename existing flag to something a bit more generic, now that it is used for
1880         more things than bypassing the navigation policy check.
1881
1882         * WebView.cpp:
1883         (WebView::goToBackForwardItem):
1884         (WebView::loadBackForwardListFromOtherView):
1885
1886 2018-06-04  Chris Dumez  <cdumez@apple.com>
1887
1888         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
1889         https://bugs.webkit.org/show_bug.cgi?id=186287
1890         <rdar://problem/40783352>
1891
1892         Reviewed by Youenn Fablet.
1893
1894         * Interfaces/IWebPreferencesPrivate.idl:
1895         * WebPreferenceKeysPrivate.h:
1896         * WebPreferences.cpp:
1897         (WebPreferences::initializeDefaultSettings):
1898         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1899         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1900         * WebPreferences.h:
1901         * WebView.cpp:
1902         (WebView::notifyPreferencesChanged):
1903
1904 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1905
1906         [JSC] Pass VM& parameter as much as possible
1907         https://bugs.webkit.org/show_bug.cgi?id=186085
1908
1909         Reviewed by Saam Barati.
1910
1911         * Plugins/PluginPackage.cpp:
1912         (WebCore::NPN_Invoke):
1913
1914 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1915
1916         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
1917         https://bugs.webkit.org/show_bug.cgi?id=186125
1918
1919         Unreviewed build fix
1920
1921         * WebActionPropertyBag.cpp:
1922         (WebActionPropertyBag::Read):
1923         (findMouseEvent): Deleted.
1924
1925 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1926
1927         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
1928         https://bugs.webkit.org/show_bug.cgi?id=186027
1929
1930         Unreviewed build fix
1931
1932         * WebMutableURLRequest.cpp:
1933         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
1934         (WebMutableURLRequest::setClientCertificate):
1935
1936 2018-05-25  Chris Dumez  <cdumez@apple.com>
1937
1938         Minor ApplicationCacheStorage clean up
1939         https://bugs.webkit.org/show_bug.cgi?id=185984
1940
1941         Reviewed by Youenn Fablet.
1942
1943         * WebApplicationCache.cpp:
1944         (WebApplicationCache::originsWithCache):
1945
1946 2018-05-24  Chris Dumez  <cdumez@apple.com>
1947
1948         Reduce copying of FontCascadeDescription objects by moving them around
1949         https://bugs.webkit.org/show_bug.cgi?id=185963
1950
1951         Reviewed by Simon Fraser.
1952
1953         Reduce copying of FontCascadeDescription objects by moving them around when possible.
1954
1955         * FullscreenVideoController.cpp:
1956         (FullscreenVideoController::draw):
1957
1958 2018-05-15  Antoine Quint  <graouts@apple.com>
1959
1960         [Web Animations] Expose Web Animations CSS integration as an experimental feature
1961         https://bugs.webkit.org/show_bug.cgi?id=185647
1962
1963         Reviewed by Dean Jackson.
1964
1965         Rename the Web Animations CSS integration flag.
1966
1967         * Interfaces/IWebPreferencesPrivate.idl:
1968         * WebPreferenceKeysPrivate.h:
1969         * WebPreferences.cpp:
1970         (WebPreferences::initializeDefaultSettings):
1971         (WebPreferences::webAnimationsCSSIntegrationEnabled):
1972         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
1973         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1974         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1975         * WebPreferences.h:
1976         * WebView.cpp:
1977         (WebView::notifyPreferencesChanged):
1978
1979 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1980
1981         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
1982         https://bugs.webkit.org/show_bug.cgi?id=185505
1983
1984         Unreviewed serious crash fix
1985
1986         Windows port crashes soon since Bug 184996.
1987
1988         * WebPreferences.cpp:
1989         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
1990         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
1991
1992 2018-05-07  Daniel Bates  <dabates@apple.com>
1993
1994         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
1995         https://bugs.webkit.org/show_bug.cgi?id=185170
1996
1997         Reviewed by Per Arne Vollan.
1998
1999         * WebCache.cpp:
2000         (WebCache::empty):
2001
2002 2018-04-27  Chris Dumez  <cdumez@apple.com>
2003
2004         Use WindowProxy instead of DOMWindow in our IDL
2005         https://bugs.webkit.org/show_bug.cgi?id=185022
2006
2007         Reviewed by Sam Weinig.
2008
2009         * DOMCoreClasses.cpp:
2010         (DOMDocument::getComputedStyle):
2011
2012 2018-04-23  Daniel Bates  <dabates@apple.com>
2013
2014         Implement Same-Site cookies
2015         https://bugs.webkit.org/show_bug.cgi?id=159464
2016         <rdar://problem/27196358>
2017
2018         Reviewed by Brent Fulgham.
2019
2020         Pass the Same-Site info through the strategy.
2021
2022         * WebCoreSupport/WebPlatformStrategies.cpp:
2023         (WebPlatformStrategies::cookiesForDOM):
2024         (WebPlatformStrategies::setCookiesFromDOM):
2025         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2026         (WebPlatformStrategies::getRawCookies):
2027         * WebCoreSupport/WebPlatformStrategies.h:
2028
2029 2018-04-23  Daniel Bates  <dabates@apple.com>
2030
2031         Implement Same-Site cookies
2032         https://bugs.webkit.org/show_bug.cgi?id=159464
2033         <rdar://problem/27196358>
2034
2035         Reviewed by Brent Fulgham.
2036
2037         Pass the Same-Site info through the strategy.
2038
2039         * WebCoreSupport/WebPlatformStrategies.cpp:
2040         (WebPlatformStrategies::cookiesForDOM):
2041         (WebPlatformStrategies::setCookiesFromDOM):
2042         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2043         (WebPlatformStrategies::getRawCookies):
2044         * WebCoreSupport/WebPlatformStrategies.h:
2045
2046 2018-04-20  Youenn Fablet  <youenn@apple.com>
2047
2048         Make PluginData cache its web visible plugins
2049         https://bugs.webkit.org/show_bug.cgi?id=184421
2050
2051         Reviewed by Chris Dumez.
2052
2053         * WebCoreSupport/WebPluginInfoProvider.cpp:
2054         (WebPluginInfoProvider::pluginInfo):
2055         (WebPluginInfoProvider::webVisiblePluginInfo):
2056         * WebCoreSupport/WebPluginInfoProvider.h:
2057
2058 2018-04-19  Chris Dumez  <cdumez@apple.com>
2059
2060         Rename JSDOMWindowProxy to JSWindowProxy
2061         https://bugs.webkit.org/show_bug.cgi?id=184797
2062
2063         Reviewed by Sam Weinig.
2064
2065         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
2066
2067         * WebFrame.cpp:
2068         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2069
2070 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2071
2072         Unreviewed rollout of r230632. Regression in memory usage.
2073
2074         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2075
2076         * WebPreferences.cpp:
2077         (WebPreferences::initializeDefaultSettings):
2078
2079 2018-04-17  Chris Dumez  <cdumez@apple.com>
2080
2081         Unreviewed attempt to fix the Windows build after r230721
2082
2083         * WebCoreSupport/WebFrameLoaderClient.cpp:
2084         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2085
2086 2018-04-17  Chris Dumez  <cdumez@apple.com>
2087
2088         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
2089         https://bugs.webkit.org/show_bug.cgi?id=184678
2090         <rdar://problem/39422122>
2091
2092         Reviewed by Alex Christensen.
2093
2094         Add new parameter to dispatchDecidePolicyForNavigationAction.
2095
2096         * WebCoreSupport/WebFrameLoaderClient.cpp:
2097         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2098         * WebCoreSupport/WebFrameLoaderClient.h:
2099
2100 2018-04-12  Antoine Quint  <graouts@apple.com>
2101
2102         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
2103         https://bugs.webkit.org/show_bug.cgi?id=184569
2104         <rdar://problem/38671301>
2105
2106         Reviewed by Jon Lee.
2107
2108         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
2109
2110         * WebPreferences.cpp:
2111
2112 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2113
2114         [WTF] Remove StaticLock
2115         https://bugs.webkit.org/show_bug.cgi?id=184332
2116
2117         Reviewed by Mark Lam.
2118
2119         * WebKitQuartzCoreAdditions/CAView.cpp:
2120         (WKQCA::CAView::releaseAllD3DResources):
2121         * WebLocalizableStrings.cpp:
2122
2123 2018-04-03  Chris Dumez  <cdumez@apple.com>
2124
2125         Drop MainFrame class
2126         https://bugs.webkit.org/show_bug.cgi?id=184191
2127
2128         Reviewed by Darin Adler.
2129
2130         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
2131         relationship between the Page and the MainFrame.
2132
2133         This is ground work for introducing LocalFrame / RemoteFrame concepts.
2134
2135         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2136         * WebCoreSupport/WebContextMenuClient.cpp:
2137         * WebCoreSupport/WebDragClient.cpp:
2138         * WebDropSource.cpp:
2139         * WebFrame.cpp:
2140         * WebView.cpp:
2141
2142 2018-03-26  Chris Dumez  <cdumez@apple.com>
2143
2144         Use SecurityOriginData more consistently in Service Worker code
2145         https://bugs.webkit.org/show_bug.cgi?id=183969
2146
2147         Reviewed by Darin Adler.
2148
2149         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2150
2151         * WebDatabaseManager.cpp:
2152         (WebDatabaseManager::databasesWithOrigin):
2153         (WebDatabaseManager::deleteOrigin):
2154         (WebDatabaseManager::deleteDatabase):
2155         (WebDatabaseManager::setQuota):
2156         * WebSecurityOrigin.cpp:
2157         (WebSecurityOrigin::usage):
2158         (WebSecurityOrigin::quota):
2159         (WebSecurityOrigin::setQuota):
2160
2161 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
2162
2163         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
2164         https://bugs.webkit.org/show_bug.cgi?id=183911
2165         <rdar://problem/38762306>
2166
2167         Reviewed by Youenn Fablet.
2168
2169         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
2170
2171         * WebView.cpp:
2172         (WebView::WebView):
2173
2174 2018-03-25  Commit Queue  <commit-queue@webkit.org>
2175
2176         Unreviewed, rolling out r229954.
2177         https://bugs.webkit.org/show_bug.cgi?id=184000
2178
2179         Caused many layout tests to crash on Apple High Sierra,
2180         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
2181         by dydz on #webkit).
2182
2183         Reverted changeset:
2184
2185         "Use SecurityOriginData more consistently in Service Worker
2186         code"
2187         https://bugs.webkit.org/show_bug.cgi?id=183969
2188         https://trac.webkit.org/changeset/229954
2189
2190 2018-03-24  Chris Dumez  <cdumez@apple.com>
2191
2192         Use SecurityOriginData more consistently in Service Worker code
2193         https://bugs.webkit.org/show_bug.cgi?id=183969
2194
2195         Reviewed by Darin Adler.
2196
2197         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2198
2199         * WebDatabaseManager.cpp:
2200         (WebDatabaseManager::databasesWithOrigin):
2201         (WebDatabaseManager::deleteOrigin):
2202         (WebDatabaseManager::deleteDatabase):
2203         (WebDatabaseManager::setQuota):
2204         * WebSecurityOrigin.cpp:
2205         (WebSecurityOrigin::usage):
2206         (WebSecurityOrigin::quota):
2207         (WebSecurityOrigin::setQuota):
2208
2209 2018-03-23  Chris Dumez  <cdumez@apple.com>
2210
2211         Unreviewed attempt to fix Windows build after r229926.
2212
2213         * WebView.cpp:
2214
2215 2018-03-23  Brady Eidson  <beidson@apple.com>
2216
2217         Go to back/forward list items after a process-swapped navigation.
2218         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
2219
2220         Reviewed by Andy Estes.
2221
2222         * WebView.cpp:
2223         (WebView::goToBackForwardItem):
2224         (WebView::loadBackForwardListFromOtherView):
2225
2226 2018-03-23  Miguel Gomez  <magomez@igalia.com>
2227
2228         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
2229         https://bugs.webkit.org/show_bug.cgi?id=183892
2230
2231         Remove the UpdateContentsFlag parameter as it's not used anymore.
2232
2233         Reviewed by Žan Doberšek.
2234
2235         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2236         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
2237
2238 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
2239
2240         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
2241         https://bugs.webkit.org/show_bug.cgi?id=183335
2242
2243         Reviewed by Alex Christensen.
2244
2245         * Plugins/PluginDatabaseWin.cpp:
2246         * Plugins/PluginMessageThrottlerWin.cpp:
2247         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
2248         * Plugins/PluginPackageWin.cpp:
2249         (WebCore::PluginPackage::load):
2250         * Plugins/PluginView.h:
2251         * Plugins/PluginViewWin.cpp:
2252         * Plugins/npapi.cpp:
2253         * WebCoreSupport/WebFrameLoaderClient.cpp:
2254         (WebFrameLoaderClient::createPlugin):
2255         (WebFrameLoaderClient::createJavaAppletWidget):
2256         * WebView.cpp:
2257         (WebView::WebViewWndProc):
2258
2259 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
2260
2261         [Win] Layout Test fast/html/menuitem-element.html is failing.
2262         https://bugs.webkit.org/show_bug.cgi?id=179299
2263
2264         Reviewed by Per Arne Vollan.
2265
2266         * Interfaces/IWebPreferencesPrivate.idl:
2267         * WebPreferenceKeysPrivate.h:
2268         * WebPreferences.cpp:
2269         (WebPreferences::menuItemElementEnabled):
2270         (WebPreferences::setMenuItemElementEnabled):
2271         * WebPreferences.h:
2272         * WebView.cpp:
2273         (WebView::notifyPreferencesChanged):
2274         Add private web preference "menuItemElementEnabled".
2275
2276 2018-03-12  Antoine Quint  <graouts@apple.com>
2277
2278         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
2279         https://bugs.webkit.org/show_bug.cgi?id=183504
2280         <rdar://problem/38372965>
2281
2282         Reviewed by Dean Jackson and Jon Lee.
2283
2284         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
2285         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
2286
2287         * Interfaces/IWebPreferencesPrivate.idl:
2288         * WebPreferences.cpp:
2289         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2290         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2291         * WebPreferenceKeysPrivate.h
2292         * WebPreferences.h:
2293         * WebView.cpp:
2294         (WebView::notifyPreferencesChanged):
2295
2296 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2297
2298         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
2299         https://bugs.webkit.org/show_bug.cgi?id=183429
2300
2301         Reviewed by Mark Lam.
2302
2303         * WebFrame.cpp:
2304         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2305
2306 2018-03-08  Tim Horton  <timothy_horton@apple.com>
2307
2308         Stop linking ApplicationServices directly
2309         https://bugs.webkit.org/show_bug.cgi?id=182867
2310         <rdar://problem/38252142>
2311
2312         Reviewed by Alex Christensen.
2313
2314         The frameworks that we use that live inside ApplicationServices
2315         have mostly moved out, so import them directly.
2316
2317         * FullscreenVideoController.cpp:
2318
2319 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2320
2321         Fix std::make_unique / new[] using system malloc
2322         https://bugs.webkit.org/show_bug.cgi?id=182975
2323
2324         Reviewed by JF Bastien.
2325
2326         Use Vector instead.
2327
2328         * MarshallingHelpers.cpp:
2329         (MarshallingHelpers::safeArrayToStringArray):
2330         (MarshallingHelpers::safeArrayToIntArray):
2331         * Plugins/PluginPackageWin.cpp:
2332         (WebCore::PluginPackage::fetchInfo):
2333         * WebPreferences.cpp:
2334         (WebPreferences::copyWebKitPreferencesToCFPreferences):
2335         * WebView.cpp:
2336         (WebView::onMenuCommand):
2337
2338 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2339
2340         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
2341         https://bugs.webkit.org/show_bug.cgi?id=183312
2342
2343         Reviewed by Mark Lam.
2344
2345         Remove wtf/CurrentTime.h include pragma.
2346
2347         * WebDownload.cpp:
2348         * WebDownloadCFNet.cpp:
2349         * WebDropSource.cpp:
2350
2351 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2352
2353         Remove monotonicallyIncreasingTime
2354         https://bugs.webkit.org/show_bug.cgi?id=182911
2355
2356         Reviewed by Michael Catanzaro.
2357
2358         * FullscreenVideoController.cpp:
2359         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
2360         * Plugins/PluginMessageThrottlerWin.cpp:
2361         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
2362         (WebCore::PluginMessageThrottlerWin::appendMessage):
2363         * Plugins/PluginMessageThrottlerWin.h:
2364         * WebView.cpp:
2365         (WebView::notifyAnimationStarted):
2366         * WebView.h:
2367
2368 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2369
2370         [Win][DRT] Implement setSpatialNavigationEnabled.
2371         https://bugs.webkit.org/show_bug.cgi?id=183166
2372
2373         Reviewed by Per Arne Vollan.
2374
2375         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
2376
2377         * Interfaces/IWebPreferencesPrivate.idl:
2378         * WebPreferenceKeysPrivate.h:
2379         * WebPreferences.cpp:
2380         (WebPreferences::initializeDefaultSettings):
2381         (WebPreferences::spatialNavigationEnabled):
2382         (WebPreferences::setSpatialNavigationEnabled):
2383         * WebPreferences.h:
2384         * WebView.cpp:
2385         (WebView::notifyPreferencesChanged):
2386
2387 2018-02-28  Alex Christensen  <achristensen@webkit.org>
2388
2389         Reduce use of NetworkingContext in WebKit
2390         https://bugs.webkit.org/show_bug.cgi?id=183213
2391
2392         Reviewed by Brady Eidson.
2393
2394         * Plugins/PluginView.cpp:
2395         (WebCore::PluginView::getValueForURL):
2396
2397 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
2398
2399         Fix WebCore includes within WebKitLegacy
2400         https://bugs.webkit.org/show_bug.cgi?id=183147
2401
2402         Reviewed by Tim Horton.
2403
2404         * Plugins/PluginDatabase.cpp:
2405         * Plugins/PluginDatabaseWin.cpp:
2406         * Plugins/PluginDebug.cpp:
2407         * Plugins/PluginDebug.h:
2408         * Plugins/PluginMainThreadScheduler.cpp:
2409         * Plugins/PluginMessageThrottlerWin.cpp:
2410         * Plugins/PluginMessageThrottlerWin.h:
2411         * Plugins/PluginPackage.cpp:
2412         * Plugins/PluginPackage.h:
2413         * Plugins/PluginPackageWin.cpp:
2414         * Plugins/PluginStream.cpp:
2415         * Plugins/PluginStream.h:
2416         * Plugins/PluginView.cpp:
2417         * Plugins/PluginView.h:
2418         * Plugins/PluginViewWin.cpp:
2419         * Plugins/npapi.cpp:
2420         * WebCoreSupport/WebChromeClient.cpp:
2421         * WebCoreSupport/WebContextMenuClient.cpp:
2422         * WebCoreSupport/WebFrameLoaderClient.cpp:
2423         * WebCoreSupport/WebInspectorClient.cpp:
2424         * WebCoreSupport/WebPlatformStrategies.cpp:
2425         * WebFrame.cpp:
2426         * WebKitMessageLoop.cpp:
2427         * WebView.cpp:
2428         * storage/WebDatabaseProvider.cpp:
2429
2430 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2431
2432         Remove currentTime() / currentTimeMS()
2433         https://bugs.webkit.org/show_bug.cgi?id=183052
2434
2435         Reviewed by Mark Lam.
2436
2437         * WebCoreSupport/WebFrameLoaderClient.cpp:
2438         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2439         * WebCoreSupport/WebFrameLoaderClient.h:
2440         * WebDownload.h:
2441         * WebDownloadCFNet.cpp:
2442         (WebDownload::didStart):
2443         (WebDownload::didReceiveData):
2444         (WebDownload::didFinish):
2445
2446 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
2447
2448         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
2449         https://bugs.webkit.org/show_bug.cgi?id=182883
2450
2451         Reviewed by Per Arne Vollan.
2452
2453         * WebKitPrefix.h:
2454
2455 2018-02-16  Dean Jackson  <dino@apple.com>
2456
2457         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
2458         https://bugs.webkit.org/show_bug.cgi?id=182894
2459
2460         Reviewed by Tim Horton.
2461
2462         Rename OPENGL_ES_2 to OPENGL_ES.
2463
2464         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2465
2466 2018-02-16  Youenn Fablet  <youenn@apple.com>
2467
2468         Allow specifying which plug-ins are supported
2469         https://bugs.webkit.org/show_bug.cgi?id=182748
2470
2471         Reviewed by Chris Dumez.
2472
2473         * WebCoreSupport/WebPluginInfoProvider.cpp:
2474         (WebPluginInfoProvider::getPluginInfo):
2475         * WebCoreSupport/WebPluginInfoProvider.h:
2476
2477 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
2478
2479         WebCore headers should not be included relatively within dependent projects
2480         https://bugs.webkit.org/show_bug.cgi?id=182805
2481
2482         Reviewed by Chris Dumez.
2483
2484         * FullscreenVideoController.h:
2485
2486 2018-02-13  Commit Queue  <commit-queue@webkit.org>
2487
2488         Unreviewed, rolling out r228431.
2489         https://bugs.webkit.org/show_bug.cgi?id=182766
2490
2491         Regressed CMake build stability (Requested by dolmstead on
2492         #webkit).
2493
2494         Reverted changeset:
2495
2496         "[CMake] Make WebCore headers copies"
2497         https://bugs.webkit.org/show_bug.cgi?id=182512
2498         https://trac.webkit.org/changeset/228431
2499
2500 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
2501
2502         [CMake] Make WebCore headers copies
2503         https://bugs.webkit.org/show_bug.cgi?id=182512
2504
2505         Reviewed by Keith Miller.
2506
2507         * FullscreenVideoController.h:
2508         * Plugins/PluginDatabase.cpp:
2509         * Plugins/PluginDatabaseWin.cpp:
2510         * Plugins/PluginDebug.cpp:
2511         * Plugins/PluginMainThreadScheduler.cpp:
2512         * Plugins/PluginMessageThrottlerWin.cpp:
2513         * Plugins/PluginPackage.cpp:
2514         * Plugins/PluginPackageWin.cpp:
2515         * Plugins/PluginStream.cpp:
2516         * Plugins/PluginView.cpp:
2517         * Plugins/PluginViewWin.cpp:
2518         * Plugins/npapi.cpp:
2519         * WebKitMessageLoop.cpp:
2520         * WebKitPrefix.h:
2521         * storage/WebDatabaseProvider.cpp:
2522
2523 2018-01-13  Darin Adler  <darin@apple.com>
2524
2525         Event improvements
2526         https://bugs.webkit.org/show_bug.cgi?id=179591
2527
2528         Reviewed by Chris Dumez.
2529
2530         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
2531         * WebFrame.cpp: Ditto.
2532
2533         * WebScriptWorld.cpp:
2534         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
2535
2536         * WebView.cpp: Removed include of ScriptValue.h.
2537         (WebView::handleEditingKeyboardEvent): Updated for name change from
2538         keyEvent to underlyingPlatformEvent.
2539
2540 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
2541
2542         Remove WebCore/ForwardingHeaders directory
2543         https://bugs.webkit.org/show_bug.cgi?id=182347
2544
2545         Reviewed by Keith Miller.
2546
2547         * Plugins/PluginView.cpp:
2548         * Plugins/PluginViewWin.cpp:
2549         * WebCoreSupport/WebInspectorClient.cpp:
2550         * WebCoreSupport/WebInspectorClient.h:
2551         * WebFrame.cpp:
2552         * WebJavaScriptCollector.cpp:
2553         * WebView.cpp:
2554
2555 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2556
2557         Unreviewed, another attempt to fix the Windows build after r227479.
2558
2559         * WebFrame.cpp:
2560         (WebFrame::elementWithName):
2561
2562 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2563
2564         Unreviewed, try to fix the Windows build after r227479.
2565
2566         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
2567
2568         * WebFrame.cpp:
2569         (WebFrame::elementWithName):
2570         (WebFrame::controlsInForm):
2571
2572 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
2573
2574         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
2575         https://bugs.webkit.org/show_bug.cgi?id=181859
2576         <rdar://problem/36659886>
2577
2578         Reviewed by Alex Christensen.
2579         
2580         Use local include patch.
2581
2582         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
2583         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
2584         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
2585
2586 2018-01-17  Youenn Fablet  <youenn@apple.com>
2587
2588         Put fetch Request.keepalive behind a runtime flag
2589         https://bugs.webkit.org/show_bug.cgi?id=181592
2590
2591         Reviewed by Chris Dumez.
2592
2593         * WebPreferences.cpp:
2594         (WebPreferences::fetchAPIKeepAliveEnabled):
2595         (WebPreferences::setFetchAPIKeepAliveEnabled):
2596         * WebPreferences.h:
2597         * WebView.cpp:
2598         (WebView::notifyPreferencesChanged):
2599
2600 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2601
2602         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2603         https://bugs.webkit.org/show_bug.cgi?id=181637
2604         <rdar://problem/36508471>
2605
2606         Reviewed by Tim Horton.
2607
2608         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
2609
2610         * WebCoreSupport/WebEditorClient.cpp:
2611         (WebEditorClient::replacementURLForResource):
2612         * WebCoreSupport/WebEditorClient.h:
2613
2614 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2615
2616         Remove std::chrono completely
2617         https://bugs.webkit.org/show_bug.cgi?id=181186
2618
2619         Reviewed by Alex Christensen.
2620
2621         * Plugins/PluginStream.cpp:
2622         (WebCore::lastModifiedDateMS):
2623
2624 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2625
2626         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
2627         https://bugs.webkit.org/show_bug.cgi?id=181173
2628
2629         Reviewed by Alex Christensen.
2630
2631         * WebNodeHighlight.cpp:
2632         (WebNodeHighlight::update): Scale the GraphicsContext.
2633
2634 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2635
2636         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
2637         https://bugs.webkit.org/show_bug.cgi?id=181160
2638
2639         Reviewed by Myles C. Maxfield.
2640
2641         * Plugins/PluginView.cpp:
2642         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
2643
2644 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2645
2646         Enable picture-in-picture from inline element on suspend.
2647         https://bugs.webkit.org/show_bug.cgi?id=180942
2648         rdar://problem/34745234
2649
2650         Reviewed by Jer Noble.
2651
2652         Update signature of enterVideoFullscreenForVideoElement.
2653
2654         * WebCoreSupport/WebChromeClient.cpp:
2655         (WebChromeClient::enterVideoFullscreenForVideoElement):
2656         * WebCoreSupport/WebChromeClient.h:
2657
2658 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2659
2660         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
2661         https://bugs.webkit.org/show_bug.cgi?id=180926
2662
2663         Reviewed by Tim Horton.
2664
2665         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
2666         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
2667
2668         * WebCoreSupport/WebFrameLoaderClient.cpp:
2669         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
2670         (WebFrameLoaderClient::pageID const): Ditto.
2671
2672 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2673
2674         Remove unnecessary boolean result of start() functions
2675         https://bugs.webkit.org/show_bug.cgi?id=180856
2676
2677         Reviewed by Darin Adler.
2678
2679         It always returns true.
2680
2681         * WebDownloadCurl.cpp:
2682         (WebDownload::start):
2683
2684 2017-12-14  John Wilander  <wilander@apple.com>
2685
2686         Storage Access API: Implement frame-specific access in the document.cookie layer
2687         https://bugs.webkit.org/show_bug.cgi?id=180682
2688         <rdar://problem/35982257>
2689
2690         Reviewed by Alex Christensen.
2691
2692         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
2693         CookiesStrategy::cookieRequestHeaderFieldValue(), and
2694         CookiesStrategy::getRawCookies() now take optional parameters for
2695         frameID and pageID to allow frame-specific scoping of cookies.
2696
2697         This change makes the return values of FrameLoaderClient::frameID()
2698         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
2699         WebCore can call those getters and get the right return values in
2700         WebKit and std:nullopt in WebKitLegacy.
2701
2702         * WebCoreSupport/WebFrameLoaderClient.cpp:
2703         (WebFrameLoaderClient::pageID const):
2704         (WebFrameLoaderClient::frameID const):
2705             Now return an optional.
2706         * WebCoreSupport/WebFrameLoaderClient.h:
2707         * WebCoreSupport/WebPlatformStrategies.cpp:
2708         (WebPlatformStrategies::cookiesForDOM):
2709         (WebPlatformStrategies::setCookiesFromDOM):
2710         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2711         (WebPlatformStrategies::getRawCookies):
2712         * WebCoreSupport/WebPlatformStrategies.h:
2713
2714 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2715
2716         [WTF] Thread::create should have Thread::tryCreate
2717         https://bugs.webkit.org/show_bug.cgi?id=180333
2718
2719         Reviewed by Darin Adler.
2720
2721         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
2722         (WKQCA::CVDisplayLink::start):
2723
2724 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2725
2726         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
2727         https://bugs.webkit.org/show_bug.cgi?id=180572
2728
2729         Reviewed by Mark Lam.
2730
2731         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
2732         Also we use Lock instead of Mutex.
2733
2734         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
2735         (WKQCA::CAD3DRenderer::swapChain):
2736         (WKQCA::CAD3DRenderer::renderAndPresent):
2737         (WKQCA::CAD3DRenderer::renderToImage):
2738         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2739         (WKQCA::CAD3DRenderer::renderInternal):
2740         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
2741         * WebKitQuartzCoreAdditions/CAView.cpp:
2742         (WKQCA::CAView::Handle::create):
2743         Return Ref<Handle> instead of RefPtr<>.
2744
2745         (WKQCA::CAView::Handle::lock):
2746         (WKQCA::CAView::Handle::view const):
2747         (WKQCA::CAView::Handle::clear):
2748         (WKQCA::views):
2749         (WKQCA::viewsNeedingUpdate):
2750         (WKQCA::CAView::releaseAllD3DResources):
2751         (WKQCA::CAView::CAView):
2752         (WKQCA::CAView::~CAView):
2753         (WKQCA::CAView::setLayer):
2754         (WKQCA::CAView::update):
2755         (WKQCA::CAView::drawToWindow):
2756         (WKQCA::CAView::drawToWindowInternal):
2757         (WKQCA::CAView::drawToImage):
2758         (WKQCA::CAView::willDraw):
2759         (WKQCA::CAView::drawIntoDC):
2760         (WKQCA::CAView::setShouldInvertColors):
2761         (WKQCA::CAView::scheduleNextDraw):
2762         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2763         (WKQCA::CAView::contextDidChange):
2764         (WKQCA::CAView::updateSoon):
2765         (WKQCA::CAView::updateViewsNow):
2766         (WKQCA::CAView::d3dDevice9):
2767         (WKQCA::CAView::Handle::mutex): Deleted.
2768         (WKQCA::globalStateMutex): Deleted.
2769         (): Deleted.
2770         * WebKitQuartzCoreAdditions/CAView.h:
2771
2772 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2773
2774         Use StaticLock instead of NeverDestroyed<Lock>
2775         https://bugs.webkit.org/show_bug.cgi?id=180507
2776
2777         Reviewed by Saam Barati.
2778
2779         * WebLocalizableStrings.cpp:
2780         (findCachedString):
2781         (cacheString):
2782         (mainBundleLocStrings): Deleted.
2783         (frameworkLocStringsMutex): Deleted.
2784
2785 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
2786
2787         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
2788         https://bugs.webkit.org/show_bug.cgi?id=180431
2789         <rdar://problem/34531264>
2790
2791         Reviewed by Simon Fraser.
2792
2793         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
2794         'override' to make sure this doesn't break in the future.
2795
2796         * WebView.cpp:
2797         (WebView::notifyAnimationStarted):
2798         (WebView::paintContents):
2799         * WebView.h:
2800
2801 2017-11-23  Darin Adler  <darin@apple.com>
2802
2803         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2804         https://bugs.webkit.org/show_bug.cgi?id=179981
2805
2806         Reviewed by Sam Weinig.
2807
2808         * WebView.cpp:
2809         (WebView::searchFor): Use |= instead of | to build FindOptions.
2810         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
2811         (WebView::findString): Create FindOptions with |=; the old code just passed a
2812         WebKit FindOptions through without converting to WebCore::FindOptions.
2813
2814 2017-11-23  Darin Adler  <darin@apple.com>
2815
2816         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2817         https://bugs.webkit.org/show_bug.cgi?id=179907
2818
2819         Reviewed by Sam Weinig.
2820
2821         * Plugins/PluginDatabaseWin.cpp:
2822         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
2823         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
2824         * WebDownloadCFNet.cpp:
2825         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
2826
2827         * WebView.cpp:
2828         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
2829         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
2830         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
2831         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
2832         the code does not cause any change in behavior.
2833
2834 2017-11-22  Ali Juma  <ajuma@chromium.org>
2835
2836         Implement VisualViewport API attributes
2837         https://bugs.webkit.org/show_bug.cgi?id=179385
2838
2839         Reviewed by Frédéric Wang.
2840
2841         Add a VisualViewportAPI preference.
2842
2843         * Interfaces/IWebPreferencesPrivate.idl:
2844         * WebPreferenceKeysPrivate.h:
2845         * WebPreferences.cpp:
2846         (WebPreferences::initializeDefaultSettings):
2847         (WebPreferences::visualViewportAPIEnabled):
2848         (WebPreferences::setVisualViewportAPIEnabled):
2849         * WebPreferences.h:
2850         * WebView.cpp:
2851         (WebView::notifyPreferencesChanged):
2852
2853 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2854
2855         Unreviewed, rolling out r225093.
2856         https://bugs.webkit.org/show_bug.cgi?id=179938
2857
2858         Compilation failed on WinCairo 64-bit Release (Requested by
2859         fredw on #webkit).
2860
2861         Reverted changeset:
2862
2863         "Implement VisualViewport API attributes"
2864         https://bugs.webkit.org/show_bug.cgi?id=179385
2865         https://trac.webkit.org/changeset/225093
2866
2867 2017-11-21  Ali Juma  <ajuma@chromium.org>
2868
2869         Implement VisualViewport API attributes
2870         https://bugs.webkit.org/show_bug.cgi?id=179385
2871
2872         Reviewed by Frédéric Wang.
2873
2874         Add a VisualViewportAPI preference.
2875
2876         * Interfaces/IWebPreferencesPrivate.idl:
2877         * WebPreferenceKeysPrivate.h:
2878         * WebPreferences.cpp:
2879         (WebPreferences::initializeDefaultSettings):
2880         (WebPreferences::visualViewportAPIEnabled):
2881         (WebPreferences::setVisualViewportAPIEnabled):
2882         * WebPreferences.h:
2883         * WebView.cpp:
2884         (WebView::notifyPreferencesChanged):
2885
2886 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2887
2888         Clean up old URL parser remnants
2889         https://bugs.webkit.org/show_bug.cgi?id=179573
2890
2891         Reviewed by Darin Adler.
2892
2893         * WebCoreSupport/WebContextMenuClient.cpp:
2894         (WebContextMenuClient::searchWithGoogle):
2895         Use https if we do end up searching with google.
2896
2897 2017-11-12  Darin Adler  <darin@apple.com>
2898
2899         More is<> and downcast<>, less static_cast<>
2900         https://bugs.webkit.org/show_bug.cgi?id=179600
2901
2902         Reviewed by Chris Dumez.
2903
2904         * WebView.cpp:
2905         (WebView::handleEditingKeyboardEvent): Use downcast.
2906
2907 2017-11-09  Christopher Reid  <chris.reid@sony.com>
2908
2909         Use enum classes within FileSystem
2910         https://bugs.webkit.org/show_bug.cgi?id=175172
2911
2912         Reviewed by Darin Adler.
2913
2914         * Plugins/PluginDatabase.cpp:
2915
2916 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
2917
2918         [Win] Add WebKitQuartzCoreAdditions library.
2919         https://bugs.webkit.org/show_bug.cgi?id=179331
2920
2921         Reviewed by Alex Christensen.
2922
2923         * WebKitQuartzCoreAdditions: Added.
2924         * WebKitQuartzCoreAdditions/API: Added.
2925         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
2926         (toImage):
2927         (WKCACFImageGetWidth):
2928         (WKCACFImageGetHeight):
2929         (WKCACFImageCopyFileMapping):
2930         (WKCACFImageCreateWithImage):
2931         (WKCACFImageFinalize):
2932         (WKCACFImageCopyFormattingDescription):
2933         (WKCACFImageCopyDebugDescription):
2934         (WKCACFImageGetTypeID):
2935         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
2936         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
2937         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
2938         (toView):
2939         (toImpl):
2940         (WKCACFViewCreate):
2941         (WKCACFViewSetLayer):
2942         (WKCACFViewUpdate):
2943         (WKCACFViewFlushContext):
2944         (WKCACFViewInvalidateRects):
2945         (WKCACFViewCanDraw):
2946         (WKCACFViewDraw):
2947         (WKCACFViewCopyDrawnImage):
2948         (WKCACFViewDrawIntoDC):
2949         (contextDidChangeCallback):
2950         (WKCACFViewSetContextDidChangeCallback):
2951         (WKCACFViewGetLastCommitTime):
2952         (WKCACFViewSetContextUserData):
2953         (WKCACFViewGetContext):
2954         (WKCACFViewFinalize):
2955         (WKCACFViewCopyFormattingDescription):
2956         (WKCACFViewCopyDebugDescription):
2957         (WKCACFViewGetTypeID):
2958         (WKCACFViewSetShouldInvertColors):
2959         (WKCACFViewGetD3DDevice9):
2960         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
2961         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
2962         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
2963         (WKQCA::dllInstance):
2964         (DllMain):
2965         (WKCACFShutDown):
2966         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
2967         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
2968         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
2969         (WKQCA::d3d):
2970         (WKQCA::initialPresentationParameters):
2971         (WKQCA::CAD3DRenderer::shared):
2972         (WKQCA::CAD3DRenderer::CAD3DRenderer):
2973         (WKQCA::CAD3DRenderer::swapChain):
2974         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
2975         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
2976         (WKQCA::CAD3DRenderer::initialize):
2977         (WKQCA::D3DMatrixOrthoOffCenterRH):
2978         (WKQCA::prepareDevice):
2979         (WKQCA::updateBounds):
2980         (WKQCA::CAD3DRenderer::renderAndPresent):
2981         (WKQCA::CAD3DRenderer::renderToImage):
2982         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2983         (WKQCA::CAD3DRenderer::renderInternal):
2984         (WKQCA::CAD3DRenderer::postProcess):
2985         (WKQCA::CAD3DRenderer::resetD3DDevice):
2986         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
2987         (WKQCA::CAD3DRenderer::release):
2988         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
2989         (WKQCA::D3DPostProcessingContext::sceneTexture const):
2990         (WKQCA::D3DPostProcessingContext::overlayQuad const):
2991         (WKQCA::CAD3DRenderer::d3dDevice9 const):
2992         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
2993         (WKQCA::CAView::Handle::create):
2994         (WKQCA::CAView::Handle::~Handle):
2995         (WKQCA::CAView::Handle::mutex):
2996         (WKQCA::CAView::Handle::view const):
2997         (WKQCA::CAView::Handle::clear):
2998         (WKQCA::CAView::Handle::Handle):
2999         (WKQCA::globalStateMutex):
3000         (WKQCA::registerMessageWindowClass):
3001         (WKQCA::createMessageWindow):
3002         (WKQCA::CAView::releaseAllD3DResources):
3003         (WKQCA::CAView::CAView):
3004         (WKQCA::CAView::~CAView):
3005         (WKQCA::CAView::create):
3006         (WKQCA::CAView::setContextDidChangeCallback):
3007         (WKQCA::CAView::setLayer):
3008         (WKQCA::CAView::update):
3009         (WKQCA::CAView::invalidateRects):
3010         (WKQCA::CAView::drawToWindow):
3011         (WKQCA::CAView::drawToWindowInternal):
3012         (WKQCA::CAView::drawToImage):
3013         (WKQCA::CAView::willDraw):
3014         (WKQCA::CAView::didDraw):
3015         (WKQCA::CAView::drawIntoDC):
3016         (WKQCA::CAView::setShouldInvertColors):
3017         (WKQCA::CAView::scheduleNextDraw):
3018         (WKQCA::CAView::displayLinkReachedCAMediaTime):
3019         (WKQCA::CAView::contextDidChangeCallback):
3020         (WKQCA::CAView::contextDidChange):
3021         (WKQCA::CAView::updateSoon):
3022         (WKQCA::CAView::updateViewsNow):
3023         (WKQCA::CAView::d3dDevice9):
3024         * WebKitQuartzCoreAdditions/CAView.h: Added.
3025         (WKQCA::CAView::context const):
3026         (WKQCA::CAView::canDraw const):
3027         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
3028         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
3029         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
3030         (WKQCA::CVDisplayLink::CVDisplayLink):
3031         (WKQCA::CVDisplayLink::~CVDisplayLink):
3032         (WKQCA::CVDisplayLink::create):
3033         (WKQCA::CVDisplayLink::start):
3034         (WKQCA::CVDisplayLink::stop):
3035         (WKQCA::CVDisplayLink::setPaused):
3036         (WKQCA::CVDisplayLink::runIOThread):
3037         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
3038         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
3039         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
3040         * WebKitQuartzCoreAdditions/Image.cpp: Added.
3041         (WKQCA::numBytesForSize):
3042         (WKQCA::Image::create):
3043         (WKQCA::Image::Image):
3044         (WKQCA::Image::~Image):
3045         (WKQCA::bitmapInfo):
3046         (WKQCA::Image::createDIB const):
3047         (WKQCA::Image::copyFileMapping):
3048         * WebKitQuartzCoreAdditions/Image.h: Added.
3049         (WKQCA::Image::size const):
3050         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
3051         (WKQCA::getBackBufferRectAsRenderTarget):
3052         (WKQCA::getSystemMemoryCopy):
3053         (WKQCA::copyRectToBitmap):
3054         (WKQCA::getImageCopy):
3055         (WKQCA::getBackBufferRectAsImage):
3056         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
3057         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
3058         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
3059         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
3060         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
3061
3062 2017-11-06  Christopher Reid  <chris.reid@sony.com>
3063
3064         Use enum classes within FileSystem
3065         https://bugs.webkit.org/show_bug.cgi?id=175172
3066
3067         Reviewed by Myles C. Maxfield.
3068
3069         * Plugins/PluginDatabase.cpp:
3070
3071 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
3072
3073         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
3074         https://bugs.webkit.org/show_bug.cgi?id=178333
3075
3076         Reviewed by Darin Adler.
3077
3078         * WebCoreSupport/WebFrameLoaderClient.cpp:
3079         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
3080
3081 2017-11-02  Alex Christensen  <achristensen@webkit.org>
3082
3083         Use CompletionHandlers for redirects
3084         https://bugs.webkit.org/show_bug.cgi?id=179163
3085
3086         Reviewed by Tim Horton.
3087
3088         * Plugins/PluginStream.cpp:
3089         (WebCore::PluginStream::willSendRequest):
3090         * Plugins/PluginStream.h:
3091         (WebCore::PluginStreamClient::~PluginStreamClient):
3092         (WebCore::PluginStreamClient::streamDidFinishLoading):
3093         (WebCore::PluginStream::create):
3094         (WebCore::PluginStream::setLoadManually):
3095
3096 2017-11-02  Christopher Reid  <chris.reid@sony.com>
3097
3098         Add a FileSystem namespace to FileSystem.cpp
3099         https://bugs.webkit.org/show_bug.cgi?id=179063
3100
3101         Reviewed by Darin Adler.
3102
3103         * Plugins/PluginDatabase.cpp:
3104         * Plugins/PluginPackage.cpp:
3105         * Plugins/PluginStream.cpp:
3106         * Plugins/PluginStream.h:
3107         * WebApplicationCache.cpp:
3108         * WebDatabaseManager.cpp:
3109         * WebDownloadCurl.cpp:
3110         * WebPreferences.cpp:
3111         * WebView.cpp:
3112
3113 2017-10-31  Alex Christensen  <achristensen@webkit.org>
3114
3115         Fix Windows build after r224260
3116
3117         * WebView.cpp:
3118         (WebView::gesture):
3119
3120 2017-10-28  Zalan Bujtas  <zalan@apple.com>
3121
3122         [FrameView::layout cleanup] Move core layout logic to a separate class.
3123         https://bugs.webkit.org/show_bug.cgi?id=178771
3124         <rdar://problem/35166542>
3125
3126         Reviewed by Simon Fraser.
3127
3128         Move layout code out from FrameView to LayoutContext.
3129
3130         * WebFrame.cpp:
3131         (WebFrame::layout):
3132
3133 2017-10-26  Alex Christensen  <achristensen@webkit.org>
3134
3135         Fix Windows build
3136         https://bugs.webkit.org/show_bug.cgi?id=178892
3137
3138         * AccessibleBase.cpp:
3139         (MSAARole):
3140
3141 2017-10-26  Alex Christensen  <achristensen@webkit.org>
3142
3143         Fix Windows build
3144         https://bugs.webkit.org/show_bug.cgi?id=178892
3145
3146         * AccessibleBase.cpp:
3147         (AccessibleBase::state const):
3148         (MSAARole):
3149
3150 2017-10-25  Youenn Fablet  <youenn@apple.com>
3151
3152         Enable ServiceWorker to fetch resources
3153         https://bugs.webkit.org/show_bug.cgi?id=178673
3154
3155         Reviewed by Brady Eidson.
3156
3157         Added implementation to the new getters.
3158         They are noop in the context of WK1.
3159
3160         * WebCoreSupport/WebFrameLoaderClient.cpp:
3161         (WebFrameLoaderClient::pageID const):
3162         (WebFrameLoaderClient::frameID const):
3163         (WebFrameLoaderClient::sessionID const):
3164         * WebCoreSupport/WebFrameLoaderClient.h:
3165
3166 2017-10-20  Antoine Quint  <graouts@apple.com>
3167
3168         [Web Animations] Provide basic timeline and animation interfaces
3169         https://bugs.webkit.org/show_bug.cgi?id=178526
3170
3171         Reviewed by Dean Jackson.
3172
3173         Remove the WEB_ANIMATIONS compile-time flag.
3174
3175         * WebView.cpp:
3176         (WebView::notifyPreferencesChanged):
3177
3178 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3179
3180         [Curl] Clean up old style code in old curl files.
3181         https://bugs.webkit.org/show_bug.cgi?id=178569
3182
3183         Reviewed by Ryosuke Niwa.
3184
3185         * WebCache.cpp:
3186         (WebCache::cacheFolder):
3187         (WebCache::setCacheFolder):
3188         * WebView.cpp:
3189         (WebView::setCacheModel):
3190
3191 2017-10-19  Sam Weinig  <sam@webkit.org>
3192
3193         [Settings] Move global settings into their own file
3194         https://bugs.webkit.org/show_bug.cgi?id=178512
3195
3196         Reviewed by Darin Adler.
3197
3198         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
3199
3200         * WebView.cpp:
3201         (WebView::initWithFrame):
3202
3203 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
3204
3205         Replace some stack raw pointers with RefPtrs within WebCore/html
3206         https://bugs.webkit.org/show_bug.cgi?id=178201
3207         <rdar://problem/34841692>
3208
3209         Reviewed by Ryosuke Niwa.
3210
3211         * WebView.cpp:
3212         (WebView::handleEditingKeyboardEvent):
3213         Change the type of node as toNode() is changed to return RefPtr.
3214
3215 2017-10-16  Sam Weinig  <sam@webkit.org>
3216
3217         [Settings] Remove all custom code from Settings.h/cpp
3218         https://bugs.webkit.org/show_bug.cgi?id=178330
3219
3220         Reviewed by Simon Fraser.
3221
3222         * WebView.cpp:
3223         (WebView::notifyPreferencesChanged):
3224             
3225             Update for naming changes of FrameFlattening now that it is an enum class.
3226
3227 2017-10-11  Chris Dumez  <cdumez@apple.com>
3228
3229         Modernize Geolocation code
3230         https://bugs.webkit.org/show_bug.cgi?id=178148
3231
3232         Reviewed by Ryosuke Niwa.
3233
3234         * WebCoreSupport/WebGeolocationClient.cpp:
3235         (WebGeolocationClient::lastPosition):
3236         * WebCoreSupport/WebGeolocationClient.h:
3237         * WebGeolocationPosition.cpp:
3238         (WebGeolocationPosition::initWithTimestamp):
3239         (core):
3240         * WebGeolocationPosition.h:
3241         (WebGeolocationPosition::impl const):
3242
3243 2017-10-05  Chris Dumez  <cdumez@apple.com>
3244
3245         Drop unused parameters for CookiesStrategy::cookiesEnabled()
3246         https://bugs.webkit.org/show_bug.cgi?id=177957
3247
3248         Reviewed by Alex Christensen.
3249
3250         * WebCoreSupport/WebPlatformStrategies.cpp:
3251         (WebPlatformStrategies::cookiesEnabled):
3252         * WebCoreSupport/WebPlatformStrategies.h:
3253
3254 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3255
3256         [Curl] Reimplement CurlDownload with CurlRequest
3257         https://bugs.webkit.org/show_bug.cgi?id=177779
3258
3259         Reviewed by Alex Christensen.
3260
3261         * WebDownload.h:
3262         * WebDownloadCurl.cpp:
3263         (WebDownload::init):
3264         (WebDownload::didReceiveResponse):
3265
3266 2017-09-29  Chris Dumez  <cdumez@apple.com>
3267
3268         Split some logic out of VisitedLinkStore and make it reusable
3269         https://bugs.webkit.org/show_bug.cgi?id=177575
3270
3271         Reviewed by Alex Christensen.
3272
3273         * WebCoreSupport/WebVisitedLinkStore.cpp:
3274         (WebVisitedLinkStore::addVisitedLink):
3275         (WebVisitedLinkStore::isLinkVisited):
3276         (WebVisitedLinkStore::addVisitedLinkHash):
3277         * WebCoreSupport/WebVisitedLinkStore.h:
3278
3279 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3280
3281         Make PolicyAction an encodable enum class
3282         https://bugs.webkit.org/show_bug.cgi?id=177480
3283
3284         Reviewed by Antti Koivisto.
3285
3286         * WebCoreSupport/WebFrameLoaderClient.cpp:
3287         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3288         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3289         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3290         * WebFramePolicyListener.cpp:
3291         (WebFramePolicyListener::use):
3292         (WebFramePolicyListener::download):
3293         (WebFramePolicyListener::ignore):
3294         (WebFramePolicyListener::continueSubmit):
3295
3296 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
3297
3298         [Win] fast/canvas/2d.getPath.modification.html is failing.
3299         https://bugs.webkit.org/show_bug.cgi?id=176534
3300
3301         Reviewed by Alex Christensen.
3302
3303         We need to enable Inspector additions at runtime in order to expose the getPath function.
3304
3305         * Interfaces/IWebPreferencesPrivate.idl:
3306         * WebPreferenceKeysPrivate.h:
3307         * WebPreferences.cpp:
3308         (WebPreferences::initializeDefaultSettings):
3309         (WebPreferences::setDataTransferItemsEnabled):
3310         (WebPreferences::inspectorAdditionsEnabled):
3311         (WebPreferences::setInspectorAdditionsEnabled):
3312         * WebPreferences.h:
3313         * WebView.cpp:
3314         (WebView::notifyPreferencesChanged):
3315
3316 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3317
3318         Modernize Geolocation code
3319         https://bugs.webkit.org/show_bug.cgi?id=176496
3320
3321         Reviewed by Andy Estes.
3322
3323         * WebCoreSupport/WebGeolocationClient.cpp:
3324         (WebGeolocationClient::requestPermission):
3325         * WebCoreSupport/WebGeolocationClient.h:
3326         (WebGeolocationClient::setEnableHighAccuracy): Deleted.
3327         (WebGeolocationClient::cancelPermissionRequest): Deleted.
3328         * WebGeolocationPolicyListener.h:
3329         * WebView.cpp:
3330         (WebView::initWithFrame):
3331         (WebView::geolocationDidFailWithError):
3332
3333 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
3334
3335         [Win] Enable DatatransferItems in DRT.
3336         https://bugs.webkit.org/show_bug.cgi?id=176424
3337
3338         Reviewed by Brent Fulgham.
3339
3340         * Interfaces/IWebPreferencesPrivate.idl:
3341         * WebPreferenceKeysPrivate.h:
3342         * WebPreferences.cpp:
3343         (WebPreferences::initializeDefaultSettings):
3344         (WebPreferences::QueryInterface):
3345         (WebPreferences::isSecureContextAttributeEnabled):
3346         (WebPreferences::dataTransferItemsEnabled):
3347         (WebPreferences::setDataTransferItemsEnabled):
3348         * WebPreferences.h:
3349         * WebView.cpp:
3350         (WebView::notifyPreferencesChanged):
3351
3352 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3353
3354         Unreviewed build fix #2 after r221275.
3355
3356         * WebCoreSupport/WebPlatformStrategies.cpp:
3357         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
3358         to match new API.
3359         * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
3360
3361 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3362
3363         Unreviewed build fix after r221275.
3364
3365         * WebCoreSupport/WebPlatformStrategies.cpp:
3366         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
3367         to match new API.
3368
3369 2017-08-28  Per Arne Vollan  <pvollan@apple.com>
3370
3371         [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
3372         https://bugs.webkit.org/show_bug.cgi?id=176031
3373
3374         Reviewed by Brent Fulgham.
3375
3376         When the function in the FramePolicyFunction parameter is called, it has already been moved
3377         to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
3378         function by using the stored member instead.
3379
3380         * WebCoreSupport/WebFrameLoaderClient.cpp:
3381         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3382         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3383         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3384
3385 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3386
3387         Unreviewed, try to fix the Windows build after r221064
3388
3389         didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
3390
3391         * WebCoreSupport/WebEditorClient.h:
3392
3393 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3394
3395         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3396         https://bugs.webkit.org/show_bug.cgi?id=175370
3397         <rdar://problem/33799806>
3398
3399         Reviewed by Ryosuke Niwa.
3400
3401         Adjust WebEditorClient for interface changes.
3402
3403         * WebCoreSupport/WebEditorClient.h:
3404
3405 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
3406
3407         Unreviewed build fix after r221017.
3408
3409         Correct copy/paste error.
3410
3411         * WebCoreSupport/WebPlatformStrategies.cpp:
3412         (WebPlatformStrategies::cookiesForDOM):
3413
3414 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
3415
3416         Unreviewed build fix after r221017.
3417
3418         * WebCoreSupport/WebPlatformStrategies.cpp:
3419         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
3420         * WebCoreSupport/WebPlatformStrategies.h:
3421
3422 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3423
3424         Remove ChromeClient::scrollbarsModeDidChange
3425         https://bugs.webkit.org/show_bug.cgi?id=175805
3426
3427         Reviewed by Daniel Bates.
3428
3429         * WebCoreSupport/WebChromeClient.h:
3430
3431 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3432
3433         Remove ChromeClient::hasOpenedPopup
3434         https://bugs.webkit.org/show_bug.cgi?id=175804
3435
3436         Reviewed by Sam Weinig.
3437
3438         * WebCoreSupport/WebChromeClient.cpp:
3439         (WebChromeClient::hasOpenedPopup const): Deleted.
3440         * WebCoreSupport/WebChromeClient.h:
3441
3442 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
3443
3444         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
3445         https://bugs.webkit.org/show_bug.cgi?id=173536
3446
3447         Reviewed by Brent Fulgham.
3448
3449         If the tree state is dirty, accessible objects are deleted while iterating over children
3450         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
3451         style is updated before this method is called.
3452
3453         * AccessibleBase.cpp:
3454         (AccessibleBase::getAccessibilityObjectForChild):
3455
3456 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3457
3458         [PAL] Move SessionID into PAL
3459         https://bugs.webkit.org/show_bug.cgi?id=174192
3460
3461         Reviewed by Antti Koivisto.
3462
3463         * WebCoreSupport/WebFrameLoaderClient.cpp:
3464         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3465         * WebCoreSupport/WebFrameLoaderClient.h:
3466         * WebCoreSupport/WebFrameNetworkingContext.cpp:
3467         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
3468         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3469         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3470         (WebFrameNetworkingContext::storageSession const):
3471         * WebCoreSupport/WebPlatformStrategies.cpp:
3472         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3473         * WebCoreSupport/WebPlatformStrategies.h:
3474
3475 2017-08-15  Youenn Fablet  <youenn@apple.com>
3476
3477         [Cache API] Adding generic support for CacheStorage and Cache methods
3478         https://bugs.webkit.org/show_bug.cgi?id=175455
3479
3480         Reviewed by Chris Dumez.
3481
3482         * WebView.cpp:
3483         (WebView::initWithFrame):
3484
3485 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3486
3487         Composition underline color is always black
3488         https://bugs.webkit.org/show_bug.cgi?id=174675
3489
3490         Reviewed by Ryosuke Niwa.
3491
3492         * WebView.cpp:
3493         (WebView::setCompositionForTesting): Use text color for
3494         composition underline.
3495
3496 2017-08-09  Daniel Bates  <dabates@apple.com>
3497
3498         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3499         https://bugs.webkit.org/show_bug.cgi?id=175247
3500         <rdar://problem/33679804>
3501
3502         Reviewed by Brady Eidson.
3503
3504         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3505         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3506         clients that need to make use of this information at this time. If such a needs comes up
3507         then we can expose API/SPI similar to what we do for WebKit.
3508
3509         * WebCoreSupport/WebFrameLoaderClient.cpp:
3510         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3511         * WebCoreSupport/WebFrameLoaderClient.h:
3512
3513 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3514
3515         Async image decoding for large images should be disabled after the first time a tile is painted
3516         https://bugs.webkit.org/show_bug.cgi?id=174451
3517         <rdar://problem/31246421>
3518
3519         Reviewed by Simon Fraser.
3520
3521         * FullscreenVideoController.cpp:
3522         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3523         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3524         (AcceleratedCompositingContext::paintContents):
3525         * WebCoreSupport/AcceleratedCompositingContext.h:
3526
3527 2017-07-23  Darin Adler  <darin@apple.com>
3528
3529         More NeverDestroyed and related cleanup
3530         https://bugs.webkit.org/show_bug.cgi?id=174745
3531
3532         Reviewed by Alex Christensen.
3533
3534         * Plugins/PluginDatabase.cpp:
3535         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
3536         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
3537         * Plugins/PluginMainThreadScheduler.cpp:
3538         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
3539         * Plugins/PluginMainThreadScheduler.h: Ditto.
3540         * WebCoreSupport/WebPlatformStrategies.cpp:
3541         (WebPlatformStrategies::initialize): Ditto.
3542         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
3543         * WebHistory.cpp:
3544         (sharedHistoryStorage): Ditto.
3545         * WebLocalizableStrings.cpp:
3546         (mainBundleLocStrings): Ditto.
3547         (frameworkLocStringsMutex): Ditto.
3548         (frameworkLocStrings): Ditto.
3549         * WebView.cpp:
3550         (WebView::standardUserAgentWithApplicationName): Ditto.
3551         Also changed to keep one global string with the prefix of the user agent string
3552         instead of keeping two globals with pieces of that prefix.
3553
3554 2017-07-24  Chris Dumez  <cdumez@apple.com>
3555
3556         Make ExceptionCode a proper enumeration
3557         https://bugs.webkit.org/show_bug.cgi?id=174771
3558
3559         Reviewed by Sam Weinig.
3560
3561         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
3562
3563         * DOMCoreClasses.cpp:
3564         (DOMDocument::createEvent):
3565         * WebView.cpp:
3566         (WebView::prepareCandidateWindow):
3567
3568 2017-07-21  Andreas Kling  <akling@apple.com>
3569
3570         Use more references in event dispatch code
3571         https://bugs.webkit.org/show_bug.cgi?id=174681
3572
3573         Reviewed by Geoffrey Garen.
3574
3575         * DOMEventsClasses.cpp:
3576         (WebEventListener::handleEvent):
3577         * DOMEventsClasses.h:
3578         * Plugins/PluginView.cpp:
3579         (WebCore::PluginView::handleEvent):
3580         * Plugins/PluginView.h:
3581
3582 2017-07-20  Brady Eidson  <beidson@apple.com>
3583
3584         Remove WebIconDatabase from WebKitLegacy/win.
3585         https://bugs.webkit.org/show_bug.cgi?id=174608
3586
3587         Reviewed by Alex Christensen.
3588
3589         It is unused.
3590         
3591         * ForEachCoClass.h:
3592
3593         * Interfaces/IWebIconDatabase.idl: Removed.
3594
3595         * Interfaces/WebKit.idl:
3596
3597         * WebCoreStatistics.cpp:
3598         (WebCoreStatistics::iconPageURLMappingCount):
3599         (WebCoreStatistics::iconRetainedPageURLCount):
3600         (WebCoreStatistics::iconRecordCount):
3601         (WebCoreStatistics::iconsWithDataCount):
3602
3603         * WebIconDatabase.cpp: Removed.
3604         * WebIconDatabase.h: Removed.
3605         * WebKitClassFactory.cpp:
3606
3607         * WebKitDLL.cpp:
3608         (shutDownWebKit):
3609
3610         * WebKitLogging.h:
3611
3612         * WebView.cpp:
3613         (WebView::close):
3614         (WebView::notifyDidAddIcon):
3615         (WebView::registerForIconNotification):
3616         (WebView::dispatchDidReceiveIconFromWebFrame):
3617         (WebView::onNotify):
3618
3619 2017-07-18  Matt Lewis  <jlewis3@apple.com>
3620
3621         Unreviewed, rolling out r219610.
3622
3623         This caused an api failure on all platforms for the test
3624         SnapshotImageLargeAsyncDecoding
3625
3626         Reverted changeset:
3627
3628         "Async image decoding for large images should be disabled
3629         after the first time a tile is painted"
3630         https://bugs.webkit.org/show_bug.cgi?id=174451
3631         http://trac.webkit.org/changeset/219610
3632
3633 2017-07-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
3634
3635         Async image decoding for large images should be disabled after the first time a tile is painted
3636         https://bugs.webkit.org/show_bug.cgi?id=174451
3637
3638         Reviewed by Simon Fraser.
3639
3640         * FullscreenVideoController.cpp:
3641         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3642         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3643         (AcceleratedCompositingContext::paintContents):
3644         * WebCoreSupport/AcceleratedCompositingContext.h:
3645
3646 2017-07-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3647
3648         [Curl] Don't start downloading more than once for same request
3649         https://bugs.webkit.org/show_bug.cgi?id=174172
3650
3651         Reviewed by Alex Christensen.
3652
3653         * WebDownloadCurl.cpp:
3654         (WebDownload::init):
3655
3656 2017-07-12  Daniel Bates  <dabates@apple.com>
3657
3658         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3659         https://bugs.webkit.org/show_bug.cgi?id=174427
3660
3661         Rubber-stamped by Brady Eidson.
3662
3663         * Plugins/PluginView.cpp:
3664         (WebCore::PluginView::start):
3665         (WebCore::PluginView::getURLNotify):
3666         (WebCore::PluginView::getURL):
3667         (WebCore::PluginView::handlePost):
3668
3669 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3670
3671         [WTF] Move SoftLinking.h into WTF
3672         https://bugs.webkit.org/show_bug.cgi?id=174000
3673
3674         Reviewed by Alex Christensen.
3675
3676         * WebKitClassFactory.cpp:
3677         * WebView.cpp:
3678
3679 2017-07-05  Brady Eidson  <beidson@apple.com>
3680
3681         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3682         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3683
3684         Reviewed by Alex Christensen.
3685
3686         Adopt to the new constructor for FrameLoadRequest.
3687
3688         * Plugins/PluginView.cpp:
3689         (WebCore::PluginView::start):
3690         (WebCore::PluginView::getURLNotify):
3691         (WebCore::PluginView::getURL):
3692         (WebCore::PluginView::handlePost):
3693
3694 2017-07-03  Brady Eidson  <beidson@apple.com>
3695
3696         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3697         https://bugs.webkit.org/show_bug.cgi?id=174073
3698
3699         Reviewed by Andy Estes.
3700
3701         * WebCoreSupport/WebFrameLoaderClient.cpp:
3702         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3703         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3704         * WebCoreSupport/WebFrameLoaderClient.h:
3705
3706 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3707
3708         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3709         https://bugs.webkit.org/show_bug.cgi?id=174004
3710
3711         Reviewed by Simon Fraser.
3712
3713         * WebCoreSupport/WebFrameLoaderClient.cpp:
3714         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3715
3716 2017-06-30  Daniel Bates  <dabates@apple.com>
3717
3718         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3719         https://bugs.webkit.org/show_bug.cgi?id=165160
3720         <rdar://problem/29451999>
3721
3722         Reviewed by Brady Eidson.
3723
3724         Pass the document that is requesting the load to the loader.
3725
3726         * Plugins/PluginView.cpp:
3727         (WebCore::PluginView::start):
3728         (WebCore::PluginView::getURLNotify):
3729         (WebCore::PluginView::getURL):
3730         (WebCore::PluginView::handlePost):
3731
3732 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3733
3734         Refactor drag start codepaths to plumb a DragItem to client layers
3735         https://bugs.webkit.org/show_bug.cgi?id=173832
3736         Work towards <rdar://problem/32236827>
3737
3738         Reviewed by Ryosuke Niwa and Tim Horton.
3739
3740         Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
3741
3742         * WebCoreSupport/WebDragClient.cpp:
3743         (WebDragClient::startDrag):
3744         * WebCoreSupport/WebDragClient.h:
3745
3746 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3747
3748         Remove excessive headers from JavaScriptCore
3749         https://bugs.webkit.org/show_bug.cgi?id=173812
3750
3751         Reviewed by Darin Adler.
3752
3753         * Plugins/PluginPackage.cpp:
3754
3755 2017-06-22  Daniel Bates  <dabates@apple.com>
3756
3757         Make FrameLoadRequest a move-only type
3758         https://bugs.webkit.org/show_bug.cgi?id=173682
3759
3760         Reviewed by Alex Christensen and Darin Adler.
3761
3762         A FrameLoadRequest groups together the information to perform a load into a single object
3763         that is more manageable to pass around than its constituent parts. Code that receives a
3764         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3765         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3766         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
3767
3768         * Plugins/PluginView.cpp:
3769         (WebCore::PluginView::start):
3770         (WebCore::PluginView::performRequest):
3771         (WebCore::PluginView::load):
3772         (WebCore::PluginView::getURLNotify):
3773         (WebCore::PluginView::getURL):
3774         (WebCore::PluginView::handlePost):
3775         * Plugins/PluginView.h:
3776         (WebCore::PluginRequest::PluginRequest):
3777
3778 2017-06-22  Daniel Bates  <dabates@apple.com>
3779
3780         [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
3781         https://bugs.webkit.org/show_bug.cgi?id=173683
3782
3783         Reviewed by Alex Christensen.
3784
3785         Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
3786         header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
3787         by including PluginView.h. The latter does not make use of the functionality
3788         provided by FrameLoadRequest.h.
3789
3790         * Plugins/PluginViewWin.cpp:
3791         * WebCoreSupport/WebContextMenuClient.cpp:
3792
3793 2017-06-21  Daniel Bates  <dabates@apple.com>
3794
3795         Cleanup FrameLoadRequest
3796         https://bugs.webkit.org/show_bug.cgi?id=173564
3797         <rdar://problem/32903570>
3798
3799         Reviewed by Brent Fulgham.
3800
3801         * Plugins/PluginView.cpp:
3802         (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
3803         we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
3804         we do not have one. Use C++11 brace initialization syntax.
3805         (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
3806         name as we do not have one. Use C++11 brace initialization syntax.
3807         (WebCore::PluginView::getURL): Ditto.
3808         (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
3809         function to closer to where it is actually used. Explicitly pass the null-string for the target
3810         frame name as we do not have one. Use C++11 brace initialization syntax.
3811
3812 2017-06-20  Daniel Bates  <dabates@apple.com>
3813
3814         Have FrameLoadRequest takes a Frame& instead of a Frame*
3815         https://bugs.webkit.org/show_bug.cgi?id=173614
3816         <rdar://problem/32884890>
3817
3818         Reviewed by Brent Fulgham.
3819
3820         * Plugins/PluginView.cpp:
3821         (WebCore::PluginView::performRequest):
3822         * WebFrame.cpp:
3823         (WebFrame::loadRequest):
3824
3825 2017-06-19  Chris Dumez  <cdumez@apple.com>
3826
3827         Use WTF::Function instead of std::function in more places in WebCore/
3828         https://bugs.webkit.org/show_bug.cgi?id=173535
3829
3830         Reviewed by Antti Koivisto.
3831
3832         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
3833
3834         * WebCoreSupport/WebFrameLoaderClient.cpp:
3835         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3836         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3837         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3838         (WebFrameLoaderClient::dispatchWillSubmitForm):
3839         (WebFrameLoaderClient::setUpPolicyListener):
3840         (WebFrameLoaderClient::receivedPolicyDecision):
3841         * WebCoreSupport/WebFrameLoaderClient.h:
3842
3843 2017-05-14 Frederic Wang  <fwang@igalia.com>
3844
3845         Add heuristic to avoid flattening "fullscreen" iframes
3846         https://bugs.webkit.org/show_bug.cgi?id=171914
3847
3848         Reviewed by Simon Fraser.
3849
3850         This commit ajusts the window port to internally use the new preference type for frame flattening.
3851         However, the "partial frame flattening" value is not exposed yet.
3852
3853         * WebView.cpp:
3854         (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
3855
3856 2017-06-17  Chris Dumez  <cdumez@apple.com>
3857
3858         Use WTF::Function instead of std::function in WebKit2/
3859         https://bugs.webkit.org/show_bug.cgi?id=173504
3860
3861         Reviewed by Darin Adler.
3862
3863         Use WTF::Function instead of std::function in WebKit2/ to avoid
3864         unnecessary copying.
3865
3866         * Plugins/PluginStream.cpp:
3867         (WebCore::PluginStream::willSendRequest):
3868         * Plugins/PluginStream.h:
3869
3870 2017-06-16  Sam Weinig  <sam@webkit.org>
3871
3872         [WebIDL] Remove custom bindings for HTMLDocument
3873         https://bugs.webkit.org/show_bug.cgi?id=173444
3874
3875         Reviewed by Darin Adler.
3876
3877         * DOMHTMLClasses.cpp:
3878         (DOMHTMLDocument::write):
3879         (DOMHTMLDocument::writeln):
3880         Update for new signature of write/writeln.
3881
3882 2017-06-16  Daniel Bates  <dabates@apple.com>
3883
3884         Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
3885         instead of URL { ParsedURLString, ... }
3886         https://bugs.webkit.org/show_bug.cgi?id=173495
3887         <rdar://problem/32827445>
3888
3889         Reviewed by Alex Christensen.
3890
3891         URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
3892         Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
3893         Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
3894         would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
3895         parse an arbitrary string that looks like a URL.
3896
3897         Also modernize the code using C++14 idioms.
3898
3899         * WebCoreSupport/WebContextMenuClient.cpp:
3900         (WebContextMenuClient::searchWithGoogle):
3901
3902 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
3903
3904         [Win] WebKit shouldn't include the forwarding header of WebKit itself
3905         https://bugs.webkit.org/show_bug.cgi?id=173352
3906
3907         Reviewed by Alex Christensen.
3908
3909         * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
3910
3911 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
3912
3913         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
3914         https://bugs.webkit.org/show_bug.cgi?id=173318
3915
3916         Reviewed by Darin Adler.
3917
3918         The logical frame size is currently calculated by scaling the frame size in pixels,
3919         and rounding the coordinates to the nearest integers. The computed logical frame
3920         size will in some cases be smaller than the scaled frame size in pixels, since it is
3921         represented as an IntSize. In these cases, the bottom line will not be painted.
3922         Instead of calculating the logical frame size by rounding the scaled frame in
3923         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
3924
3925         * WebCoreSupport/WebFrameLoaderClient.cpp:
3926         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3927
3928 2017-06-13  Daniel Bates  <dabates@apple.com>
3929
3930         Implement W3C Secure Contexts Draft Specification
3931         https://bugs.webkit.org/show_bug.cgi?id=158121
3932         <rdar://problem/26012994>
3933
3934         Reviewed by Brent Fulgham.
3935
3936         Part 4
3937
3938         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3939
3940         * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
3941         * WebPreferenceKeysPrivate.h:
3942         * WebPreferences.cpp:
3943         (WebPreferences::initializeDefaultSettings):
3944         (WebPreferences::QueryInterface):
3945         (WebPreferences::setIsSecureContextAttributeEnabled):
3946         (WebPreferences::isSecureContextAttributeEnabled):
3947         * WebPreferences.h:
3948         * WebView.cpp:
3949         (WebView::notifyPreferencesChanged):
3950
3951 2017-06-13  Per Arne Vollan  <pvollan@apple.com>
3952
3953         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
3954         https://bugs.webkit.org/show_bug.cgi?id=173318
3955
3956         Reviewed by Alex Christensen.
3957
3958         The logical frame size is currently calculated by scaling the frame size in pixels,
3959         and rounding the coordinates to the nearest integers. The computed logical frame
3960         size will in some cases be smaller than the scaled frame size in pixels, since it is
3961         represented as an IntSize. In these cases, the bottom line will not be painted.
3962         Instead of calculating the logical frame size by rounding the scaled frame in
3963         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
3964  
3965         * WebView.cpp:
3966         (WebView::sizeChanged):
3967
3968 2017-06-13  Sam Weinig  <sam@webkit.org>
3969
3970         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
3971         https://bugs.webkit.org/show_bug.cgi?id=80733
3972
3973         Reviewed by Chris Dumez.
3974
3975         * WebFrame.cpp:
3976         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
3977
3978 2017-06-12  Daewoong Jang  <daewoong.jang@navercorp.com>
3979
3980         Remove WebCore::unloadModule and related data types
3981         https://bugs.webkit.org/show_bug.cgi?id=173231
3982
3983         Reviewed by Darin Adler.
3984
3985         * Plugins/PlatformModule.h: Added.
3986         (WebCore::PlatformModuleVersion::PlatformModuleVersion):
3987         * Plugins/PluginPackage.cpp:
3988         (WebCore::PluginPackage::freeLibraryTimerFired):
3989         * Plugins/PluginPackage.h:
3990
3991 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3992
3993         [iOS DnD] Add a hook to perform two-step drops in editable content
3994         https://bugs.webkit.org/show_bug.cgi?id=172992
3995         <rdar://problem/32590174>
3996
3997         Reviewed by Tim Horton.
3998
3999         Add a stub implementation for performTwoStepDrop on Windows.
4000
4001         * WebCoreSupport/WebEditorClient.h:
4002
4003 2017-06-04  Konstantin Tokarev  <annulen@yandex.ru>
4004
4005         Fix build of Windows-specific code with ICU 59.1
4006         https://bugs.webkit.org/show_bug.cgi?id=172729
4007
4008         Reviewed by Darin Adler.
4009
4010         Fix conversions from WTF::String to wchar_t* and vice versa.
4011
4012         * Plugins/PluginDatabaseWin.cpp:
4013         (WebCore::addPluginPathsFromRegistry):
4014         (WebCore::PluginDatabase::getPluginPathsInDirectories):
4015         (WebCore::addMozillaPluginDirectories):
4016         (WebCore::addWindowsMediaPlayerPluginDirectory):
4017         (WebCore::addAdobeAcrobatPluginDirectory):
4018         (WebCore::addJavaPluginDirectory):
4019         (WebCore::safariPluginsDirectory):
4020         (WebCore::addMacromediaPluginDirectories):
4021         * Plugins/PluginPackageWin.cpp:
4022         (WebCore::getVersionInfo):
4023         (WebCore::PluginPackage::fetchInfo):
4024         (WebCore::PluginPackage::load):
4025         * Plugins/PluginViewWin.cpp:
4026         (WebCore::PluginView::handlePostReadFile):
4027
4028 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
4029
4030         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
4031         https://bugs.webkit.org/show_bug.cgi?id=172709
4032
4033         Reviewed by Brent Fulgham.
4034
4035         Add method to exit fullscreen mode.
4036
4037         * Interfaces/IWebViewPrivate.idl:
4038         * WebView.cpp:
4039         (WebView::exitFullscreenIfNeeded):
4040         * WebView.h:
4041
4042 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
4043
4044         [Win] Create unique network storage session for each DRT.
4045         https://bugs.webkit.org/show_bug.cgi?id=172540
4046
4047         Reviewed by Brent Fulgham.
4048
4049         During layout testing, each DRT instance should have its own network storage session.
4050
4051         * Interfaces/IWebPreferencesPrivate.idl:
4052         * WebPreferences.cpp:
4053         (WebPreferences::switchNetworkLoaderToNewTestingSession):
4054         * WebPreferences.h:
4055
4056 2017-05-24  Fujii Hironori  <Hironori.Fujii@sony.com>
4057
4058         [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
4059         https://bugs.webkit.org/show_bug.cgi?id=172535
4060
4061         Reviewed by Konstantin Tokarev.
4062
4063         * WebCoreSupport/AcceleratedCompositingContext.cpp:
4064         (AcceleratedCompositingContext::paintContents): Append the fifth argument.
4065         * WebCoreSupport/AcceleratedCompositingContext.h: Ditto.
4066
4067 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
4068
4069         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
4070         https://bugs.webkit.org/show_bug.cgi?id=172071
4071
4072         Reviewed by Alexey Proskuryakov.
4073
4074         We need to delete all cookies after each test.
4075
4076         * Interfaces/IWebPreferencesPrivate.idl:
4077         * WebPreferences.cpp:
4078         (WebPreferences::linkPreloadEnabled):
4079         (WebPreferences::clearNetworkLoaderSession):
4080         * WebPreferences.h:
4081
4082 2017-05-13  Chris Dumez  <cdumez@apple.com>
4083
4084         Stop using RefPtr::release()
4085         https://bugs.webkit.org/show_bug.cgi?id=172074
4086
4087         Reviewed by Geoffrey Garen.
4088
4089         * WebFrame.cpp:
4090         (WebFrame::loadPlainTextString):
4091         (WebFrame::loadHTMLString):
4092         * WebFramePolicyListener.cpp:
4093         (WebFramePolicyListener::receivedPolicyDecision):
4094
4095 2017-05-13  Chris Dumez  <cdumez@apple.com>
4096
4097         Drop uses of PassRefPtr in WebKit/win
4098         https://bugs.webkit.org/show_bug.cgi?id=172067
4099
4100         Reviewed by Yusuke Suzuki.
4101
4102         * DOMEventsClasses.cpp:
4103         (DOMEvent::DOMEvent):
4104         (DOMEvent::createInstance):
4105         * DOMEventsClasses.h:
4106         (DOMUIEvent::DOMUIEvent):
4107         (DOMKeyboardEvent::DOMKeyboardEvent):
4108         (DOMMouseEvent::DOMMouseEvent):
4109         (DOMMutationEvent::DOMMutationEvent):
4110         (DOMOverflowEvent::DOMOverflowEvent):
4111         (DOMWheelEvent::DOMWheelEvent):
4112         * MemoryStream.cpp:
4113         (MemoryStream::MemoryStream):
4114         (MemoryStream::createInstance):
4115         * MemoryStream.h:
4116         * Plugins/PluginDatabase.cpp:
4117         (WebCore::PluginDatabase::refresh):
4118         (WebCore::PluginDatabase::add):
4119         (WebCore::PluginDatabase::loadPersistentMetadataCache):
4120         * Plugins/PluginDatabase.h:
4121         * Plugins/PluginPackage.cpp:
4122         (WebCore::PluginPackage::createPackage):
4123         (WebCore::PluginPackage::createPackageFromCache):
4124         * Plugins/PluginPackage.h:
4125         * Plugins/PluginStream.h:
4126         (WebCore::PluginStream::create):
4127         * WebActionPropertyBag.cpp:
4128         (WebActionPropertyBag::WebActionPropertyBag):
4129         (WebActionPropertyBag::createInstance):
4130         * WebActionPropertyBag.h:
4131         * WebArchive.cpp:
4132         (WebArchive::createInstance):
4133         (WebArchive::WebArchive):
4134         * WebArchive.h:
4135         * WebBackForwardList.cpp:
4136         (WebBackForwardList::WebBackForwardList):
4137         (WebBackForwardList::createInstance):
4138         * WebBackForwardList.h:
4139         * WebCoreSupport/EmbeddedWidget.cpp:
4140         (EmbeddedWidget::create):
4141         * WebCoreSupport/EmbeddedWidget.h:
4142         * WebCoreSupport/WebChromeClient.h:
4143         * WebFrame.cpp:
4144         (WebFrame::loadData):
4145         (WebFrame::createSubframeWithOwnerElement):
4146         * WebFrame.h:
4147         * WebFramePolicyListener.cpp:
4148         (WebFramePolicyListener::WebFramePolicyListener):
4149         (WebFramePolicyListener::createInstance):
4150         * WebFramePolicyListener.h: