Rename JSDOMWindowProxy to JSWindowProxy
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2018-04-19  Chris Dumez  <cdumez@apple.com>
2
3         Rename JSDOMWindowProxy to JSWindowProxy
4         https://bugs.webkit.org/show_bug.cgi?id=184797
5
6         Reviewed by Sam Weinig.
7
8         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
9
10         * WebFrame.cpp:
11         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
12
13 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
14
15         Unreviewed rollout of r230632. Regression in memory usage.
16
17         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
18
19         * WebPreferences.cpp:
20         (WebPreferences::initializeDefaultSettings):
21
22 2018-04-17  Chris Dumez  <cdumez@apple.com>
23
24         Unreviewed attempt to fix the Windows build after r230721
25
26         * WebCoreSupport/WebFrameLoaderClient.cpp:
27         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
28
29 2018-04-17  Chris Dumez  <cdumez@apple.com>
30
31         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
32         https://bugs.webkit.org/show_bug.cgi?id=184678
33         <rdar://problem/39422122>
34
35         Reviewed by Alex Christensen.
36
37         Add new parameter to dispatchDecidePolicyForNavigationAction.
38
39         * WebCoreSupport/WebFrameLoaderClient.cpp:
40         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
41         * WebCoreSupport/WebFrameLoaderClient.h:
42
43 2018-04-12  Antoine Quint  <graouts@apple.com>
44
45         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
46         https://bugs.webkit.org/show_bug.cgi?id=184569
47         <rdar://problem/38671301>
48
49         Reviewed by Jon Lee.
50
51         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
52
53         * WebPreferences.cpp:
54
55 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
56
57         [WTF] Remove StaticLock
58         https://bugs.webkit.org/show_bug.cgi?id=184332
59
60         Reviewed by Mark Lam.
61
62         * WebKitQuartzCoreAdditions/CAView.cpp:
63         (WKQCA::CAView::releaseAllD3DResources):
64         * WebLocalizableStrings.cpp:
65
66 2018-04-03  Chris Dumez  <cdumez@apple.com>
67
68         Drop MainFrame class
69         https://bugs.webkit.org/show_bug.cgi?id=184191
70
71         Reviewed by Darin Adler.
72
73         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
74         relationship between the Page and the MainFrame.
75
76         This is ground work for introducing LocalFrame / RemoteFrame concepts.
77
78         * WebCoreSupport/AcceleratedCompositingContext.cpp:
79         * WebCoreSupport/WebContextMenuClient.cpp:
80         * WebCoreSupport/WebDragClient.cpp:
81         * WebDropSource.cpp:
82         * WebFrame.cpp:
83         * WebView.cpp:
84
85 2018-03-26  Chris Dumez  <cdumez@apple.com>
86
87         Use SecurityOriginData more consistently in Service Worker code
88         https://bugs.webkit.org/show_bug.cgi?id=183969
89
90         Reviewed by Darin Adler.
91
92         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
93
94         * WebDatabaseManager.cpp:
95         (WebDatabaseManager::databasesWithOrigin):
96         (WebDatabaseManager::deleteOrigin):
97         (WebDatabaseManager::deleteDatabase):
98         (WebDatabaseManager::setQuota):
99         * WebSecurityOrigin.cpp:
100         (WebSecurityOrigin::usage):
101         (WebSecurityOrigin::quota):
102         (WebSecurityOrigin::setQuota):
103
104 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
105
106         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
107         https://bugs.webkit.org/show_bug.cgi?id=183911
108         <rdar://problem/38762306>
109
110         Reviewed by Youenn Fablet.
111
112         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
113
114         * WebView.cpp:
115         (WebView::WebView):
116
117 2018-03-25  Commit Queue  <commit-queue@webkit.org>
118
119         Unreviewed, rolling out r229954.
120         https://bugs.webkit.org/show_bug.cgi?id=184000
121
122         Caused many layout tests to crash on Apple High Sierra,
123         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
124         by dydz on #webkit).
125
126         Reverted changeset:
127
128         "Use SecurityOriginData more consistently in Service Worker
129         code"
130         https://bugs.webkit.org/show_bug.cgi?id=183969
131         https://trac.webkit.org/changeset/229954
132
133 2018-03-24  Chris Dumez  <cdumez@apple.com>
134
135         Use SecurityOriginData more consistently in Service Worker code
136         https://bugs.webkit.org/show_bug.cgi?id=183969
137
138         Reviewed by Darin Adler.
139
140         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
141
142         * WebDatabaseManager.cpp:
143         (WebDatabaseManager::databasesWithOrigin):
144         (WebDatabaseManager::deleteOrigin):
145         (WebDatabaseManager::deleteDatabase):
146         (WebDatabaseManager::setQuota):
147         * WebSecurityOrigin.cpp:
148         (WebSecurityOrigin::usage):
149         (WebSecurityOrigin::quota):
150         (WebSecurityOrigin::setQuota):
151
152 2018-03-23  Chris Dumez  <cdumez@apple.com>
153
154         Unreviewed attempt to fix Windows build after r229926.
155
156         * WebView.cpp:
157
158 2018-03-23  Brady Eidson  <beidson@apple.com>
159
160         Go to back/forward list items after a process-swapped navigation.
161         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
162
163         Reviewed by Andy Estes.
164
165         * WebView.cpp:
166         (WebView::goToBackForwardItem):
167         (WebView::loadBackForwardListFromOtherView):
168
169 2018-03-23  Miguel Gomez  <magomez@igalia.com>
170
171         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
172         https://bugs.webkit.org/show_bug.cgi?id=183892
173
174         Remove the UpdateContentsFlag parameter as it's not used anymore.
175
176         Reviewed by Žan Doberšek.
177
178         * WebCoreSupport/AcceleratedCompositingContext.cpp:
179         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
180
181 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
182
183         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
184         https://bugs.webkit.org/show_bug.cgi?id=183335
185
186         Reviewed by Alex Christensen.
187
188         * Plugins/PluginDatabaseWin.cpp:
189         * Plugins/PluginMessageThrottlerWin.cpp:
190         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
191         * Plugins/PluginPackageWin.cpp:
192         (WebCore::PluginPackage::load):
193         * Plugins/PluginView.h:
194         * Plugins/PluginViewWin.cpp:
195         * Plugins/npapi.cpp:
196         * WebCoreSupport/WebFrameLoaderClient.cpp:
197         (WebFrameLoaderClient::createPlugin):
198         (WebFrameLoaderClient::createJavaAppletWidget):
199         * WebView.cpp:
200         (WebView::WebViewWndProc):
201
202 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
203
204         [Win] Layout Test fast/html/menuitem-element.html is failing.
205         https://bugs.webkit.org/show_bug.cgi?id=179299
206
207         Reviewed by Per Arne Vollan.
208
209         * Interfaces/IWebPreferencesPrivate.idl:
210         * WebPreferenceKeysPrivate.h:
211         * WebPreferences.cpp:
212         (WebPreferences::menuItemElementEnabled):
213         (WebPreferences::setMenuItemElementEnabled):
214         * WebPreferences.h:
215         * WebView.cpp:
216         (WebView::notifyPreferencesChanged):
217         Add private web preference "menuItemElementEnabled".
218
219 2018-03-12  Antoine Quint  <graouts@apple.com>
220
221         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
222         https://bugs.webkit.org/show_bug.cgi?id=183504
223         <rdar://problem/38372965>
224
225         Reviewed by Dean Jackson and Jon Lee.
226
227         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
228         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
229
230         * Interfaces/IWebPreferencesPrivate.idl:
231         * WebPreferences.cpp:
232         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
233         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
234         * WebPreferenceKeysPrivate.h
235         * WebPreferences.h:
236         * WebView.cpp:
237         (WebView::notifyPreferencesChanged):
238
239 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
240
241         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
242         https://bugs.webkit.org/show_bug.cgi?id=183429
243
244         Reviewed by Mark Lam.
245
246         * WebFrame.cpp:
247         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
248
249 2018-03-08  Tim Horton  <timothy_horton@apple.com>
250
251         Stop linking ApplicationServices directly
252         https://bugs.webkit.org/show_bug.cgi?id=182867
253         <rdar://problem/38252142>
254
255         Reviewed by Alex Christensen.
256
257         The frameworks that we use that live inside ApplicationServices
258         have mostly moved out, so import them directly.
259
260         * FullscreenVideoController.cpp:
261
262 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
263
264         Fix std::make_unique / new[] using system malloc
265         https://bugs.webkit.org/show_bug.cgi?id=182975
266
267         Reviewed by JF Bastien.
268
269         Use Vector instead.
270
271         * MarshallingHelpers.cpp:
272         (MarshallingHelpers::safeArrayToStringArray):
273         (MarshallingHelpers::safeArrayToIntArray):
274         * Plugins/PluginPackageWin.cpp:
275         (WebCore::PluginPackage::fetchInfo):
276         * WebPreferences.cpp:
277         (WebPreferences::copyWebKitPreferencesToCFPreferences):
278         * WebView.cpp:
279         (WebView::onMenuCommand):
280
281 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
282
283         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
284         https://bugs.webkit.org/show_bug.cgi?id=183312
285
286         Reviewed by Mark Lam.
287
288         Remove wtf/CurrentTime.h include pragma.
289
290         * WebDownload.cpp:
291         * WebDownloadCFNet.cpp:
292         * WebDropSource.cpp:
293
294 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
295
296         Remove monotonicallyIncreasingTime
297         https://bugs.webkit.org/show_bug.cgi?id=182911
298
299         Reviewed by Michael Catanzaro.
300
301         * FullscreenVideoController.cpp:
302         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
303         * Plugins/PluginMessageThrottlerWin.cpp:
304         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
305         (WebCore::PluginMessageThrottlerWin::appendMessage):
306         * Plugins/PluginMessageThrottlerWin.h:
307         * WebView.cpp:
308         (WebView::notifyAnimationStarted):
309         * WebView.h:
310
311 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
312
313         [Win][DRT] Implement setSpatialNavigationEnabled.
314         https://bugs.webkit.org/show_bug.cgi?id=183166
315
316         Reviewed by Per Arne Vollan.
317
318         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
319
320         * Interfaces/IWebPreferencesPrivate.idl:
321         * WebPreferenceKeysPrivate.h:
322         * WebPreferences.cpp:
323         (WebPreferences::initializeDefaultSettings):
324         (WebPreferences::spatialNavigationEnabled):
325         (WebPreferences::setSpatialNavigationEnabled):
326         * WebPreferences.h:
327         * WebView.cpp:
328         (WebView::notifyPreferencesChanged):
329
330 2018-02-28  Alex Christensen  <achristensen@webkit.org>
331
332         Reduce use of NetworkingContext in WebKit
333         https://bugs.webkit.org/show_bug.cgi?id=183213
334
335         Reviewed by Brady Eidson.
336
337         * Plugins/PluginView.cpp:
338         (WebCore::PluginView::getValueForURL):
339
340 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
341
342         Fix WebCore includes within WebKitLegacy
343         https://bugs.webkit.org/show_bug.cgi?id=183147
344
345         Reviewed by Tim Horton.
346
347         * Plugins/PluginDatabase.cpp:
348         * Plugins/PluginDatabaseWin.cpp:
349         * Plugins/PluginDebug.cpp:
350         * Plugins/PluginDebug.h:
351         * Plugins/PluginMainThreadScheduler.cpp:
352         * Plugins/PluginMessageThrottlerWin.cpp:
353         * Plugins/PluginMessageThrottlerWin.h:
354         * Plugins/PluginPackage.cpp:
355         * Plugins/PluginPackage.h:
356         * Plugins/PluginPackageWin.cpp:
357         * Plugins/PluginStream.cpp:
358         * Plugins/PluginStream.h:
359         * Plugins/PluginView.cpp:
360         * Plugins/PluginView.h:
361         * Plugins/PluginViewWin.cpp:
362         * Plugins/npapi.cpp:
363         * WebCoreSupport/WebChromeClient.cpp:
364         * WebCoreSupport/WebContextMenuClient.cpp:
365         * WebCoreSupport/WebFrameLoaderClient.cpp:
366         * WebCoreSupport/WebInspectorClient.cpp:
367         * WebCoreSupport/WebPlatformStrategies.cpp:
368         * WebFrame.cpp:
369         * WebKitMessageLoop.cpp:
370         * WebView.cpp:
371         * storage/WebDatabaseProvider.cpp:
372
373 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
374
375         Remove currentTime() / currentTimeMS()
376         https://bugs.webkit.org/show_bug.cgi?id=183052
377
378         Reviewed by Mark Lam.
379
380         * WebCoreSupport/WebFrameLoaderClient.cpp:
381         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
382         * WebCoreSupport/WebFrameLoaderClient.h:
383         * WebDownload.h:
384         * WebDownloadCFNet.cpp:
385         (WebDownload::didStart):
386         (WebDownload::didReceiveData):
387         (WebDownload::didFinish):
388
389 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
390
391         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
392         https://bugs.webkit.org/show_bug.cgi?id=182883
393
394         Reviewed by Per Arne Vollan.
395
396         * WebKitPrefix.h:
397
398 2018-02-16  Dean Jackson  <dino@apple.com>
399
400         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
401         https://bugs.webkit.org/show_bug.cgi?id=182894
402
403         Reviewed by Tim Horton.
404
405         Rename OPENGL_ES_2 to OPENGL_ES.
406
407         * WebCoreSupport/AcceleratedCompositingContext.cpp:
408
409 2018-02-16  Youenn Fablet  <youenn@apple.com>
410
411         Allow specifying which plug-ins are supported
412         https://bugs.webkit.org/show_bug.cgi?id=182748
413
414         Reviewed by Chris Dumez.
415
416         * WebCoreSupport/WebPluginInfoProvider.cpp:
417         (WebPluginInfoProvider::getPluginInfo):
418         * WebCoreSupport/WebPluginInfoProvider.h:
419
420 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
421
422         WebCore headers should not be included relatively within dependent projects
423         https://bugs.webkit.org/show_bug.cgi?id=182805
424
425         Reviewed by Chris Dumez.
426
427         * FullscreenVideoController.h:
428
429 2018-02-13  Commit Queue  <commit-queue@webkit.org>
430
431         Unreviewed, rolling out r228431.
432         https://bugs.webkit.org/show_bug.cgi?id=182766
433
434         Regressed CMake build stability (Requested by dolmstead on
435         #webkit).
436
437         Reverted changeset:
438
439         "[CMake] Make WebCore headers copies"
440         https://bugs.webkit.org/show_bug.cgi?id=182512
441         https://trac.webkit.org/changeset/228431
442
443 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
444
445         [CMake] Make WebCore headers copies
446         https://bugs.webkit.org/show_bug.cgi?id=182512
447
448         Reviewed by Keith Miller.
449
450         * FullscreenVideoController.h:
451         * Plugins/PluginDatabase.cpp:
452         * Plugins/PluginDatabaseWin.cpp:
453         * Plugins/PluginDebug.cpp:
454         * Plugins/PluginMainThreadScheduler.cpp:
455         * Plugins/PluginMessageThrottlerWin.cpp:
456         * Plugins/PluginPackage.cpp:
457         * Plugins/PluginPackageWin.cpp:
458         * Plugins/PluginStream.cpp:
459         * Plugins/PluginView.cpp:
460         * Plugins/PluginViewWin.cpp:
461         * Plugins/npapi.cpp:
462         * WebKitMessageLoop.cpp:
463         * WebKitPrefix.h:
464         * storage/WebDatabaseProvider.cpp:
465
466 2018-01-13  Darin Adler  <darin@apple.com>
467
468         Event improvements
469         https://bugs.webkit.org/show_bug.cgi?id=179591
470
471         Reviewed by Chris Dumez.
472
473         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
474         * WebFrame.cpp: Ditto.
475
476         * WebScriptWorld.cpp:
477         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
478
479         * WebView.cpp: Removed include of ScriptValue.h.
480         (WebView::handleEditingKeyboardEvent): Updated for name change from
481         keyEvent to underlyingPlatformEvent.
482
483 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
484
485         Remove WebCore/ForwardingHeaders directory
486         https://bugs.webkit.org/show_bug.cgi?id=182347
487
488         Reviewed by Keith Miller.
489
490         * Plugins/PluginView.cpp:
491         * Plugins/PluginViewWin.cpp:
492         * WebCoreSupport/WebInspectorClient.cpp:
493         * WebCoreSupport/WebInspectorClient.h:
494         * WebFrame.cpp:
495         * WebJavaScriptCollector.cpp:
496         * WebView.cpp:
497
498 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
499
500         Unreviewed, another attempt to fix the Windows build after r227479.
501
502         * WebFrame.cpp:
503         (WebFrame::elementWithName):
504
505 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
506
507         Unreviewed, try to fix the Windows build after r227479.
508
509         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
510
511         * WebFrame.cpp:
512         (WebFrame::elementWithName):
513         (WebFrame::controlsInForm):
514
515 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
516
517         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
518         https://bugs.webkit.org/show_bug.cgi?id=181859
519         <rdar://problem/36659886>
520
521         Reviewed by Alex Christensen.
522         
523         Use local include patch.
524
525         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
526         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
527         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
528
529 2018-01-17  Youenn Fablet  <youenn@apple.com>
530
531         Put fetch Request.keepalive behind a runtime flag
532         https://bugs.webkit.org/show_bug.cgi?id=181592
533
534         Reviewed by Chris Dumez.
535
536         * WebPreferences.cpp:
537         (WebPreferences::fetchAPIKeepAliveEnabled):
538         (WebPreferences::setFetchAPIKeepAliveEnabled):
539         * WebPreferences.h:
540         * WebView.cpp:
541         (WebView::notifyPreferencesChanged):
542
543 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
544
545         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
546         https://bugs.webkit.org/show_bug.cgi?id=181637
547         <rdar://problem/36508471>
548
549         Reviewed by Tim Horton.
550
551         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
552
553         * WebCoreSupport/WebEditorClient.cpp:
554         (WebEditorClient::replacementURLForResource):
555         * WebCoreSupport/WebEditorClient.h:
556
557 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
558
559         Remove std::chrono completely
560         https://bugs.webkit.org/show_bug.cgi?id=181186
561
562         Reviewed by Alex Christensen.
563
564         * Plugins/PluginStream.cpp:
565         (WebCore::lastModifiedDateMS):
566
567 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
568
569         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
570         https://bugs.webkit.org/show_bug.cgi?id=181173
571
572         Reviewed by Alex Christensen.
573
574         * WebNodeHighlight.cpp:
575         (WebNodeHighlight::update): Scale the GraphicsContext.
576
577 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
578
579         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
580         https://bugs.webkit.org/show_bug.cgi?id=181160
581
582         Reviewed by Myles C. Maxfield.
583
584         * Plugins/PluginView.cpp:
585         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
586
587 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
588
589         Enable picture-in-picture from inline element on suspend.
590         https://bugs.webkit.org/show_bug.cgi?id=180942
591         rdar://problem/34745234
592
593         Reviewed by Jer Noble.
594
595         Update signature of enterVideoFullscreenForVideoElement.
596
597         * WebCoreSupport/WebChromeClient.cpp:
598         (WebChromeClient::enterVideoFullscreenForVideoElement):
599         * WebCoreSupport/WebChromeClient.h:
600
601 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
602
603         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
604         https://bugs.webkit.org/show_bug.cgi?id=180926
605
606         Reviewed by Tim Horton.
607
608         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
609         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
610
611         * WebCoreSupport/WebFrameLoaderClient.cpp:
612         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
613         (WebFrameLoaderClient::pageID const): Ditto.
614
615 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
616
617         Remove unnecessary boolean result of start() functions
618         https://bugs.webkit.org/show_bug.cgi?id=180856
619
620         Reviewed by Darin Adler.
621
622         It always returns true.
623
624         * WebDownloadCurl.cpp:
625         (WebDownload::start):
626
627 2017-12-14  John Wilander  <wilander@apple.com>
628
629         Storage Access API: Implement frame-specific access in the document.cookie layer
630         https://bugs.webkit.org/show_bug.cgi?id=180682
631         <rdar://problem/35982257>
632
633         Reviewed by Alex Christensen.
634
635         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
636         CookiesStrategy::cookieRequestHeaderFieldValue(), and
637         CookiesStrategy::getRawCookies() now take optional parameters for
638         frameID and pageID to allow frame-specific scoping of cookies.
639
640         This change makes the return values of FrameLoaderClient::frameID()
641         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
642         WebCore can call those getters and get the right return values in
643         WebKit and std:nullopt in WebKitLegacy.
644
645         * WebCoreSupport/WebFrameLoaderClient.cpp:
646         (WebFrameLoaderClient::pageID const):
647         (WebFrameLoaderClient::frameID const):
648             Now return an optional.
649         * WebCoreSupport/WebFrameLoaderClient.h:
650         * WebCoreSupport/WebPlatformStrategies.cpp:
651         (WebPlatformStrategies::cookiesForDOM):
652         (WebPlatformStrategies::setCookiesFromDOM):
653         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
654         (WebPlatformStrategies::getRawCookies):
655         * WebCoreSupport/WebPlatformStrategies.h:
656
657 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
658
659         [WTF] Thread::create should have Thread::tryCreate
660         https://bugs.webkit.org/show_bug.cgi?id=180333
661
662         Reviewed by Darin Adler.
663
664         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
665         (WKQCA::CVDisplayLink::start):
666
667 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
668
669         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
670         https://bugs.webkit.org/show_bug.cgi?id=180572
671
672         Reviewed by Mark Lam.
673
674         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
675         Also we use Lock instead of Mutex.
676
677         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
678         (WKQCA::CAD3DRenderer::swapChain):
679         (WKQCA::CAD3DRenderer::renderAndPresent):
680         (WKQCA::CAD3DRenderer::renderToImage):
681         (WKQCA::CAD3DRenderer::setDeviceIsLost):
682         (WKQCA::CAD3DRenderer::renderInternal):
683         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
684         * WebKitQuartzCoreAdditions/CAView.cpp:
685         (WKQCA::CAView::Handle::create):
686         Return Ref<Handle> instead of RefPtr<>.
687
688         (WKQCA::CAView::Handle::lock):
689         (WKQCA::CAView::Handle::view const):
690         (WKQCA::CAView::Handle::clear):
691         (WKQCA::views):
692         (WKQCA::viewsNeedingUpdate):
693         (WKQCA::CAView::releaseAllD3DResources):
694         (WKQCA::CAView::CAView):
695         (WKQCA::CAView::~CAView):
696         (WKQCA::CAView::setLayer):
697         (WKQCA::CAView::update):
698         (WKQCA::CAView::drawToWindow):
699         (WKQCA::CAView::drawToWindowInternal):
700         (WKQCA::CAView::drawToImage):
701         (WKQCA::CAView::willDraw):
702         (WKQCA::CAView::drawIntoDC):
703         (WKQCA::CAView::setShouldInvertColors):
704         (WKQCA::CAView::scheduleNextDraw):
705         (WKQCA::CAView::displayLinkReachedCAMediaTime):
706         (WKQCA::CAView::contextDidChange):
707         (WKQCA::CAView::updateSoon):
708         (WKQCA::CAView::updateViewsNow):
709         (WKQCA::CAView::d3dDevice9):
710         (WKQCA::CAView::Handle::mutex): Deleted.
711         (WKQCA::globalStateMutex): Deleted.
712         (): Deleted.
713         * WebKitQuartzCoreAdditions/CAView.h:
714
715 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
716
717         Use StaticLock instead of NeverDestroyed<Lock>
718         https://bugs.webkit.org/show_bug.cgi?id=180507
719
720         Reviewed by Saam Barati.
721
722         * WebLocalizableStrings.cpp:
723         (findCachedString):
724         (cacheString):
725         (mainBundleLocStrings): Deleted.
726         (frameworkLocStringsMutex): Deleted.
727
728 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
729
730         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
731         https://bugs.webkit.org/show_bug.cgi?id=180431
732         <rdar://problem/34531264>
733
734         Reviewed by Simon Fraser.
735
736         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
737         'override' to make sure this doesn't break in the future.
738
739         * WebView.cpp:
740         (WebView::notifyAnimationStarted):
741         (WebView::paintContents):
742         * WebView.h:
743
744 2017-11-23  Darin Adler  <darin@apple.com>
745
746         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
747         https://bugs.webkit.org/show_bug.cgi?id=179981
748
749         Reviewed by Sam Weinig.
750
751         * WebView.cpp:
752         (WebView::searchFor): Use |= instead of | to build FindOptions.
753         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
754         (WebView::findString): Create FindOptions with |=; the old code just passed a
755         WebKit FindOptions through without converting to WebCore::FindOptions.
756
757 2017-11-23  Darin Adler  <darin@apple.com>
758
759         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
760         https://bugs.webkit.org/show_bug.cgi?id=179907
761
762         Reviewed by Sam Weinig.
763
764         * Plugins/PluginDatabaseWin.cpp:
765         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
766         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
767         * WebDownloadCFNet.cpp:
768         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
769
770         * WebView.cpp:
771         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
772         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
773         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
774         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
775         the code does not cause any change in behavior.
776
777 2017-11-22  Ali Juma  <ajuma@chromium.org>
778
779         Implement VisualViewport API attributes
780         https://bugs.webkit.org/show_bug.cgi?id=179385
781
782         Reviewed by Frédéric Wang.
783
784         Add a VisualViewportAPI preference.
785
786         * Interfaces/IWebPreferencesPrivate.idl:
787         * WebPreferenceKeysPrivate.h:
788         * WebPreferences.cpp:
789         (WebPreferences::initializeDefaultSettings):
790         (WebPreferences::visualViewportAPIEnabled):
791         (WebPreferences::setVisualViewportAPIEnabled):
792         * WebPreferences.h:
793         * WebView.cpp:
794         (WebView::notifyPreferencesChanged):
795
796 2017-11-22  Commit Queue  <commit-queue@webkit.org>
797
798         Unreviewed, rolling out r225093.
799         https://bugs.webkit.org/show_bug.cgi?id=179938
800
801         Compilation failed on WinCairo 64-bit Release (Requested by
802         fredw on #webkit).
803
804         Reverted changeset:
805
806         "Implement VisualViewport API attributes"
807         https://bugs.webkit.org/show_bug.cgi?id=179385
808         https://trac.webkit.org/changeset/225093
809
810 2017-11-21  Ali Juma  <ajuma@chromium.org>
811
812         Implement VisualViewport API attributes
813         https://bugs.webkit.org/show_bug.cgi?id=179385
814
815         Reviewed by Frédéric Wang.
816
817         Add a VisualViewportAPI preference.
818
819         * Interfaces/IWebPreferencesPrivate.idl:
820         * WebPreferenceKeysPrivate.h:
821         * WebPreferences.cpp:
822         (WebPreferences::initializeDefaultSettings):
823         (WebPreferences::visualViewportAPIEnabled):
824         (WebPreferences::setVisualViewportAPIEnabled):
825         * WebPreferences.h:
826         * WebView.cpp:
827         (WebView::notifyPreferencesChanged):
828
829 2017-11-14  Alex Christensen  <achristensen@webkit.org>
830
831         Clean up old URL parser remnants
832         https://bugs.webkit.org/show_bug.cgi?id=179573
833
834         Reviewed by Darin Adler.
835
836         * WebCoreSupport/WebContextMenuClient.cpp:
837         (WebContextMenuClient::searchWithGoogle):
838         Use https if we do end up searching with google.
839
840 2017-11-12  Darin Adler  <darin@apple.com>
841
842         More is<> and downcast<>, less static_cast<>
843         https://bugs.webkit.org/show_bug.cgi?id=179600
844
845         Reviewed by Chris Dumez.
846
847         * WebView.cpp:
848         (WebView::handleEditingKeyboardEvent): Use downcast.
849
850 2017-11-09  Christopher Reid  <chris.reid@sony.com>
851
852         Use enum classes within FileSystem
853         https://bugs.webkit.org/show_bug.cgi?id=175172
854
855         Reviewed by Darin Adler.
856
857         * Plugins/PluginDatabase.cpp:
858
859 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
860
861         [Win] Add WebKitQuartzCoreAdditions library.
862         https://bugs.webkit.org/show_bug.cgi?id=179331
863
864         Reviewed by Alex Christensen.
865
866         * WebKitQuartzCoreAdditions: Added.
867         * WebKitQuartzCoreAdditions/API: Added.
868         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
869         (toImage):
870         (WKCACFImageGetWidth):
871         (WKCACFImageGetHeight):
872         (WKCACFImageCopyFileMapping):
873         (WKCACFImageCreateWithImage):
874         (WKCACFImageFinalize):
875         (WKCACFImageCopyFormattingDescription):
876         (WKCACFImageCopyDebugDescription):
877         (WKCACFImageGetTypeID):
878         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
879         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
880         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
881         (toView):
882         (toImpl):
883         (WKCACFViewCreate):
884         (WKCACFViewSetLayer):
885         (WKCACFViewUpdate):
886         (WKCACFViewFlushContext):
887         (WKCACFViewInvalidateRects):
888         (WKCACFViewCanDraw):
889         (WKCACFViewDraw):
890         (WKCACFViewCopyDrawnImage):
891         (WKCACFViewDrawIntoDC):
892         (contextDidChangeCallback):
893         (WKCACFViewSetContextDidChangeCallback):
894         (WKCACFViewGetLastCommitTime):
895         (WKCACFViewSetContextUserData):
896         (WKCACFViewGetContext):
897         (WKCACFViewFinalize):
898         (WKCACFViewCopyFormattingDescription):
899         (WKCACFViewCopyDebugDescription):
900         (WKCACFViewGetTypeID):
901         (WKCACFViewSetShouldInvertColors):
902         (WKCACFViewGetD3DDevice9):
903         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
904         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
905         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
906         (WKQCA::dllInstance):
907         (DllMain):
908         (WKCACFShutDown):
909         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
910         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
911         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
912         (WKQCA::d3d):
913         (WKQCA::initialPresentationParameters):
914         (WKQCA::CAD3DRenderer::shared):
915         (WKQCA::CAD3DRenderer::CAD3DRenderer):
916         (WKQCA::CAD3DRenderer::swapChain):
917         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
918         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
919         (WKQCA::CAD3DRenderer::initialize):
920         (WKQCA::D3DMatrixOrthoOffCenterRH):
921         (WKQCA::prepareDevice):
922         (WKQCA::updateBounds):
923         (WKQCA::CAD3DRenderer::renderAndPresent):
924         (WKQCA::CAD3DRenderer::renderToImage):
925         (WKQCA::CAD3DRenderer::setDeviceIsLost):
926         (WKQCA::CAD3DRenderer::renderInternal):
927         (WKQCA::CAD3DRenderer::postProcess):
928         (WKQCA::CAD3DRenderer::resetD3DDevice):
929         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
930         (WKQCA::CAD3DRenderer::release):
931         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
932         (WKQCA::D3DPostProcessingContext::sceneTexture const):
933         (WKQCA::D3DPostProcessingContext::overlayQuad const):
934         (WKQCA::CAD3DRenderer::d3dDevice9 const):
935         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
936         (WKQCA::CAView::Handle::create):
937         (WKQCA::CAView::Handle::~Handle):
938         (WKQCA::CAView::Handle::mutex):
939         (WKQCA::CAView::Handle::view const):
940         (WKQCA::CAView::Handle::clear):
941         (WKQCA::CAView::Handle::Handle):
942         (WKQCA::globalStateMutex):
943         (WKQCA::registerMessageWindowClass):
944         (WKQCA::createMessageWindow):
945         (WKQCA::CAView::releaseAllD3DResources):
946         (WKQCA::CAView::CAView):
947         (WKQCA::CAView::~CAView):
948         (WKQCA::CAView::create):
949         (WKQCA::CAView::setContextDidChangeCallback):
950         (WKQCA::CAView::setLayer):
951         (WKQCA::CAView::update):
952         (WKQCA::CAView::invalidateRects):
953         (WKQCA::CAView::drawToWindow):
954         (WKQCA::CAView::drawToWindowInternal):
955         (WKQCA::CAView::drawToImage):
956         (WKQCA::CAView::willDraw):
957         (WKQCA::CAView::didDraw):
958         (WKQCA::CAView::drawIntoDC):
959         (WKQCA::CAView::setShouldInvertColors):
960         (WKQCA::CAView::scheduleNextDraw):
961         (WKQCA::CAView::displayLinkReachedCAMediaTime):
962         (WKQCA::CAView::contextDidChangeCallback):
963         (WKQCA::CAView::contextDidChange):
964         (WKQCA::CAView::updateSoon):
965         (WKQCA::CAView::updateViewsNow):
966         (WKQCA::CAView::d3dDevice9):
967         * WebKitQuartzCoreAdditions/CAView.h: Added.
968         (WKQCA::CAView::context const):
969         (WKQCA::CAView::canDraw const):
970         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
971         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
972         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
973         (WKQCA::CVDisplayLink::CVDisplayLink):
974         (WKQCA::CVDisplayLink::~CVDisplayLink):
975         (WKQCA::CVDisplayLink::create):
976         (WKQCA::CVDisplayLink::start):
977         (WKQCA::CVDisplayLink::stop):
978         (WKQCA::CVDisplayLink::setPaused):
979         (WKQCA::CVDisplayLink::runIOThread):
980         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
981         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
982         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
983         * WebKitQuartzCoreAdditions/Image.cpp: Added.
984         (WKQCA::numBytesForSize):
985         (WKQCA::Image::create):
986         (WKQCA::Image::Image):
987         (WKQCA::Image::~Image):
988         (WKQCA::bitmapInfo):
989         (WKQCA::Image::createDIB const):
990         (WKQCA::Image::copyFileMapping):
991         * WebKitQuartzCoreAdditions/Image.h: Added.
992         (WKQCA::Image::size const):
993         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
994         (WKQCA::getBackBufferRectAsRenderTarget):
995         (WKQCA::getSystemMemoryCopy):
996         (WKQCA::copyRectToBitmap):
997         (WKQCA::getImageCopy):
998         (WKQCA::getBackBufferRectAsImage):
999         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
1000         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
1001         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
1002         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
1003         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
1004
1005 2017-11-06  Christopher Reid  <chris.reid@sony.com>
1006
1007         Use enum classes within FileSystem
1008         https://bugs.webkit.org/show_bug.cgi?id=175172
1009
1010         Reviewed by Myles C. Maxfield.
1011
1012         * Plugins/PluginDatabase.cpp:
1013
1014 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
1015
1016         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
1017         https://bugs.webkit.org/show_bug.cgi?id=178333
1018
1019         Reviewed by Darin Adler.
1020
1021         * WebCoreSupport/WebFrameLoaderClient.cpp:
1022         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
1023
1024 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1025
1026         Use CompletionHandlers for redirects
1027         https://bugs.webkit.org/show_bug.cgi?id=179163
1028
1029         Reviewed by Tim Horton.
1030
1031         * Plugins/PluginStream.cpp:
1032         (WebCore::PluginStream::willSendRequest):
1033         * Plugins/PluginStream.h:
1034         (WebCore::PluginStreamClient::~PluginStreamClient):
1035         (WebCore::PluginStreamClient::streamDidFinishLoading):
1036         (WebCore::PluginStream::create):
1037         (WebCore::PluginStream::setLoadManually):
1038
1039 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1040
1041         Add a FileSystem namespace to FileSystem.cpp
1042         https://bugs.webkit.org/show_bug.cgi?id=179063
1043
1044         Reviewed by Darin Adler.
1045
1046         * Plugins/PluginDatabase.cpp:
1047         * Plugins/PluginPackage.cpp:
1048         * Plugins/PluginStream.cpp:
1049         * Plugins/PluginStream.h:
1050         * WebApplicationCache.cpp:
1051         * WebDatabaseManager.cpp:
1052         * WebDownloadCurl.cpp:
1053         * WebPreferences.cpp:
1054         * WebView.cpp:
1055
1056 2017-10-31  Alex Christensen  <achristensen@webkit.org>
1057
1058         Fix Windows build after r224260
1059
1060         * WebView.cpp:
1061         (WebView::gesture):
1062
1063 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1064
1065         [FrameView::layout cleanup] Move core layout logic to a separate class.
1066         https://bugs.webkit.org/show_bug.cgi?id=178771
1067         <rdar://problem/35166542>
1068
1069         Reviewed by Simon Fraser.
1070
1071         Move layout code out from FrameView to LayoutContext.
1072
1073         * WebFrame.cpp:
1074         (WebFrame::layout):
1075
1076 2017-10-26  Alex Christensen  <achristensen@webkit.org>
1077
1078         Fix Windows build
1079         https://bugs.webkit.org/show_bug.cgi?id=178892
1080
1081         * AccessibleBase.cpp:
1082         (MSAARole):
1083
1084 2017-10-26  Alex Christensen  <achristensen@webkit.org>
1085
1086         Fix Windows build
1087         https://bugs.webkit.org/show_bug.cgi?id=178892
1088
1089         * AccessibleBase.cpp:
1090         (AccessibleBase::state const):
1091         (MSAARole):
1092
1093 2017-10-25  Youenn Fablet  <youenn@apple.com>
1094
1095         Enable ServiceWorker to fetch resources
1096         https://bugs.webkit.org/show_bug.cgi?id=178673
1097
1098         Reviewed by Brady Eidson.
1099
1100         Added implementation to the new getters.
1101         They are noop in the context of WK1.
1102
1103         * WebCoreSupport/WebFrameLoaderClient.cpp:
1104         (WebFrameLoaderClient::pageID const):
1105         (WebFrameLoaderClient::frameID const):
1106         (WebFrameLoaderClient::sessionID const):
1107         * WebCoreSupport/WebFrameLoaderClient.h:
1108
1109 2017-10-20  Antoine Quint  <graouts@apple.com>
1110
1111         [Web Animations] Provide basic timeline and animation interfaces
1112         https://bugs.webkit.org/show_bug.cgi?id=178526
1113
1114         Reviewed by Dean Jackson.
1115
1116         Remove the WEB_ANIMATIONS compile-time flag.
1117
1118         * WebView.cpp:
1119         (WebView::notifyPreferencesChanged):
1120
1121 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1122
1123         [Curl] Clean up old style code in old curl files.
1124         https://bugs.webkit.org/show_bug.cgi?id=178569
1125
1126         Reviewed by Ryosuke Niwa.
1127
1128         * WebCache.cpp:
1129         (WebCache::cacheFolder):
1130         (WebCache::setCacheFolder):
1131         * WebView.cpp:
1132         (WebView::setCacheModel):
1133
1134 2017-10-19  Sam Weinig  <sam@webkit.org>
1135
1136         [Settings] Move global settings into their own file
1137         https://bugs.webkit.org/show_bug.cgi?id=178512
1138
1139         Reviewed by Darin Adler.
1140
1141         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1142
1143         * WebView.cpp:
1144         (WebView::initWithFrame):
1145
1146 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1147
1148         Replace some stack raw pointers with RefPtrs within WebCore/html
1149         https://bugs.webkit.org/show_bug.cgi?id=178201
1150         <rdar://problem/34841692>
1151
1152         Reviewed by Ryosuke Niwa.
1153
1154         * WebView.cpp:
1155         (WebView::handleEditingKeyboardEvent):
1156         Change the type of node as toNode() is changed to return RefPtr.
1157
1158 2017-10-16  Sam Weinig  <sam@webkit.org>
1159
1160         [Settings] Remove all custom code from Settings.h/cpp
1161         https://bugs.webkit.org/show_bug.cgi?id=178330
1162
1163         Reviewed by Simon Fraser.
1164
1165         * WebView.cpp:
1166         (WebView::notifyPreferencesChanged):
1167             
1168             Update for naming changes of FrameFlattening now that it is an enum class.
1169
1170 2017-10-11  Chris Dumez  <cdumez@apple.com>
1171
1172         Modernize Geolocation code
1173         https://bugs.webkit.org/show_bug.cgi?id=178148
1174
1175         Reviewed by Ryosuke Niwa.
1176
1177         * WebCoreSupport/WebGeolocationClient.cpp:
1178         (WebGeolocationClient::lastPosition):
1179         * WebCoreSupport/WebGeolocationClient.h:
1180         * WebGeolocationPosition.cpp:
1181         (WebGeolocationPosition::initWithTimestamp):
1182         (core):
1183         * WebGeolocationPosition.h:
1184         (WebGeolocationPosition::impl const):
1185
1186 2017-10-05  Chris Dumez  <cdumez@apple.com>
1187
1188         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1189         https://bugs.webkit.org/show_bug.cgi?id=177957
1190
1191         Reviewed by Alex Christensen.
1192
1193         * WebCoreSupport/WebPlatformStrategies.cpp:
1194         (WebPlatformStrategies::cookiesEnabled):
1195         * WebCoreSupport/WebPlatformStrategies.h:
1196
1197 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1198
1199         [Curl] Reimplement CurlDownload with CurlRequest
1200         https://bugs.webkit.org/show_bug.cgi?id=177779
1201
1202         Reviewed by Alex Christensen.
1203
1204         * WebDownload.h:
1205         * WebDownloadCurl.cpp:
1206         (WebDownload::init):
1207         (WebDownload::didReceiveResponse):
1208
1209 2017-09-29  Chris Dumez  <cdumez@apple.com>
1210
1211         Split some logic out of VisitedLinkStore and make it reusable
1212         https://bugs.webkit.org/show_bug.cgi?id=177575
1213
1214         Reviewed by Alex Christensen.
1215
1216         * WebCoreSupport/WebVisitedLinkStore.cpp:
1217         (WebVisitedLinkStore::addVisitedLink):
1218         (WebVisitedLinkStore::isLinkVisited):
1219         (WebVisitedLinkStore::addVisitedLinkHash):
1220         * WebCoreSupport/WebVisitedLinkStore.h:
1221
1222 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1223
1224         Make PolicyAction an encodable enum class
1225         https://bugs.webkit.org/show_bug.cgi?id=177480
1226
1227         Reviewed by Antti Koivisto.
1228
1229         * WebCoreSupport/WebFrameLoaderClient.cpp:
1230         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1231         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1232         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1233         * WebFramePolicyListener.cpp:
1234         (WebFramePolicyListener::use):
1235         (WebFramePolicyListener::download):
1236         (WebFramePolicyListener::ignore):
1237         (WebFramePolicyListener::continueSubmit):
1238
1239 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
1240
1241         [Win] fast/canvas/2d.getPath.modification.html is failing.
1242         https://bugs.webkit.org/show_bug.cgi?id=176534
1243
1244         Reviewed by Alex Christensen.
1245
1246         We need to enable Inspector additions at runtime in order to expose the getPath function.
1247
1248         * Interfaces/IWebPreferencesPrivate.idl:
1249         * WebPreferenceKeysPrivate.h:
1250         * WebPreferences.cpp:
1251         (WebPreferences::initializeDefaultSettings):
1252         (WebPreferences::setDataTransferItemsEnabled):
1253         (WebPreferences::inspectorAdditionsEnabled):
1254         (WebPreferences::setInspectorAdditionsEnabled):
1255         * WebPreferences.h:
1256         * WebView.cpp:
1257         (WebView::notifyPreferencesChanged):
1258
1259 2017-09-07  Alex Christensen  <achristensen@webkit.org>
1260
1261         Modernize Geolocation code
1262         https://bugs.webkit.org/show_bug.cgi?id=176496
1263
1264         Reviewed by Andy Estes.
1265
1266         * WebCoreSupport/WebGeolocationClient.cpp:
1267         (WebGeolocationClient::requestPermission):
1268         * WebCoreSupport/WebGeolocationClient.h:
1269         (WebGeolocationClient::setEnableHighAccuracy): Deleted.
1270         (WebGeolocationClient::cancelPermissionRequest): Deleted.
1271         * WebGeolocationPolicyListener.h:
1272         * WebView.cpp:
1273         (WebView::initWithFrame):
1274         (WebView::geolocationDidFailWithError):
1275
1276 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
1277
1278         [Win] Enable DatatransferItems in DRT.
1279         https://bugs.webkit.org/show_bug.cgi?id=176424
1280
1281         Reviewed by Brent Fulgham.
1282
1283         * Interfaces/IWebPreferencesPrivate.idl:
1284         * WebPreferenceKeysPrivate.h:
1285         * WebPreferences.cpp:
1286         (WebPreferences::initializeDefaultSettings):
1287         (WebPreferences::QueryInterface):
1288         (WebPreferences::isSecureContextAttributeEnabled):
1289         (WebPreferences::dataTransferItemsEnabled):
1290         (WebPreferences::setDataTransferItemsEnabled):
1291         * WebPreferences.h:
1292         * WebView.cpp:
1293         (WebView::notifyPreferencesChanged):
1294
1295 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
1296
1297         Unreviewed build fix #2 after r221275.
1298
1299         * WebCoreSupport/WebPlatformStrategies.cpp:
1300         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
1301         to match new API.
1302         * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
1303
1304 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
1305
1306         Unreviewed build fix after r221275.
1307
1308         * WebCoreSupport/WebPlatformStrategies.cpp:
1309         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
1310         to match new API.
1311
1312 2017-08-28  Per Arne Vollan  <pvollan@apple.com>
1313
1314         [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
1315         https://bugs.webkit.org/show_bug.cgi?id=176031
1316
1317         Reviewed by Brent Fulgham.
1318
1319         When the function in the FramePolicyFunction parameter is called, it has already been moved
1320         to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
1321         function by using the stored member instead.
1322
1323         * WebCoreSupport/WebFrameLoaderClient.cpp:
1324         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1325         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1326         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1327
1328 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1329
1330         Unreviewed, try to fix the Windows build after r221064
1331
1332         didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
1333
1334         * WebCoreSupport/WebEditorClient.h:
1335
1336 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1337
1338         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
1339         https://bugs.webkit.org/show_bug.cgi?id=175370
1340         <rdar://problem/33799806>
1341
1342         Reviewed by Ryosuke Niwa.
1343
1344         Adjust WebEditorClient for interface changes.
1345
1346         * WebCoreSupport/WebEditorClient.h:
1347
1348 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
1349
1350         Unreviewed build fix after r221017.
1351
1352         Correct copy/paste error.
1353
1354         * WebCoreSupport/WebPlatformStrategies.cpp:
1355         (WebPlatformStrategies::cookiesForDOM):
1356
1357 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
1358
1359         Unreviewed build fix after r221017.
1360
1361         * WebCoreSupport/WebPlatformStrategies.cpp:
1362         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
1363         * WebCoreSupport/WebPlatformStrategies.h:
1364
1365 2017-08-22  Alex Christensen  <achristensen@webkit.org>
1366
1367         Remove ChromeClient::scrollbarsModeDidChange
1368         https://bugs.webkit.org/show_bug.cgi?id=175805
1369
1370         Reviewed by Daniel Bates.
1371
1372         * WebCoreSupport/WebChromeClient.h:
1373
1374 2017-08-22  Alex Christensen  <achristensen@webkit.org>
1375
1376         Remove ChromeClient::hasOpenedPopup
1377         https://bugs.webkit.org/show_bug.cgi?id=175804
1378
1379         Reviewed by Sam Weinig.
1380
1381         * WebCoreSupport/WebChromeClient.cpp:
1382         (WebChromeClient::hasOpenedPopup const): Deleted.
1383         * WebCoreSupport/WebChromeClient.h:
1384
1385 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
1386
1387         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
1388         https://bugs.webkit.org/show_bug.cgi?id=173536
1389
1390         Reviewed by Brent Fulgham.
1391
1392         If the tree state is dirty, accessible objects are deleted while iterating over children
1393         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
1394         style is updated before this method is called.
1395
1396         * AccessibleBase.cpp:
1397         (AccessibleBase::getAccessibilityObjectForChild):
1398
1399 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
1400
1401         [PAL] Move SessionID into PAL
1402         https://bugs.webkit.org/show_bug.cgi?id=174192
1403
1404         Reviewed by Antti Koivisto.
1405
1406         * WebCoreSupport/WebFrameLoaderClient.cpp:
1407         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1408         * WebCoreSupport/WebFrameLoaderClient.h:
1409         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1410         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
1411         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1412         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
1413         (WebFrameNetworkingContext::storageSession const):
1414         * WebCoreSupport/WebPlatformStrategies.cpp:
1415         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1416         * WebCoreSupport/WebPlatformStrategies.h:
1417
1418 2017-08-15  Youenn Fablet  <youenn@apple.com>
1419
1420         [Cache API] Adding generic support for CacheStorage and Cache methods
1421         https://bugs.webkit.org/show_bug.cgi?id=175455
1422
1423         Reviewed by Chris Dumez.
1424
1425         * WebView.cpp:
1426         (WebView::initWithFrame):
1427
1428 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
1429
1430         Composition underline color is always black
1431         https://bugs.webkit.org/show_bug.cgi?id=174675
1432
1433         Reviewed by Ryosuke Niwa.
1434
1435         * WebView.cpp:
1436         (WebView::setCompositionForTesting): Use text color for
1437         composition underline.
1438
1439 2017-08-09  Daniel Bates  <dabates@apple.com>
1440
1441         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
1442         https://bugs.webkit.org/show_bug.cgi?id=175247
1443         <rdar://problem/33679804>
1444
1445         Reviewed by Brady Eidson.
1446
1447         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
1448         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
1449         clients that need to make use of this information at this time. If such a needs comes up
1450         then we can expose API/SPI similar to what we do for WebKit.
1451
1452         * WebCoreSupport/WebFrameLoaderClient.cpp:
1453         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1454         * WebCoreSupport/WebFrameLoaderClient.h:
1455
1456 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
1457
1458         Async image decoding for large images should be disabled after the first time a tile is painted
1459         https://bugs.webkit.org/show_bug.cgi?id=174451
1460         <rdar://problem/31246421>
1461
1462         Reviewed by Simon Fraser.
1463
1464         * FullscreenVideoController.cpp:
1465         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
1466         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1467         (AcceleratedCompositingContext::paintContents):
1468         * WebCoreSupport/AcceleratedCompositingContext.h:
1469
1470 2017-07-23  Darin Adler  <darin@apple.com>
1471
1472         More NeverDestroyed and related cleanup
1473         https://bugs.webkit.org/show_bug.cgi?id=174745
1474
1475         Reviewed by Alex Christensen.
1476
1477         * Plugins/PluginDatabase.cpp:
1478         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
1479         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
1480         * Plugins/PluginMainThreadScheduler.cpp:
1481         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
1482         * Plugins/PluginMainThreadScheduler.h: Ditto.
1483         * WebCoreSupport/WebPlatformStrategies.cpp:
1484         (WebPlatformStrategies::initialize): Ditto.
1485         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
1486         * WebHistory.cpp:
1487         (sharedHistoryStorage): Ditto.
1488         * WebLocalizableStrings.cpp:
1489         (mainBundleLocStrings): Ditto.
1490         (frameworkLocStringsMutex): Ditto.
1491         (frameworkLocStrings): Ditto.
1492         * WebView.cpp:
1493         (WebView::standardUserAgentWithApplicationName): Ditto.
1494         Also changed to keep one global string with the prefix of the user agent string
1495         instead of keeping two globals with pieces of that prefix.
1496
1497 2017-07-24  Chris Dumez  <cdumez@apple.com>
1498
1499         Make ExceptionCode a proper enumeration
1500         https://bugs.webkit.org/show_bug.cgi?id=174771
1501
1502         Reviewed by Sam Weinig.
1503
1504         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
1505
1506         * DOMCoreClasses.cpp:
1507         (DOMDocument::createEvent):
1508         * WebView.cpp:
1509         (WebView::prepareCandidateWindow):
1510
1511 2017-07-21  Andreas Kling  <akling@apple.com>
1512
1513         Use more references in event dispatch code
1514         https://bugs.webkit.org/show_bug.cgi?id=174681
1515
1516         Reviewed by Geoffrey Garen.
1517
1518         * DOMEventsClasses.cpp:
1519         (WebEventListener::handleEvent):
1520         * DOMEventsClasses.h:
1521         * Plugins/PluginView.cpp:
1522         (WebCore::PluginView::handleEvent):
1523         * Plugins/PluginView.h:
1524
1525 2017-07-20  Brady Eidson  <beidson@apple.com>
1526
1527         Remove WebIconDatabase from WebKitLegacy/win.
1528         https://bugs.webkit.org/show_bug.cgi?id=174608
1529
1530         Reviewed by Alex Christensen.
1531
1532         It is unused.
1533         
1534         * ForEachCoClass.h:
1535
1536         * Interfaces/IWebIconDatabase.idl: Removed.
1537
1538         * Interfaces/WebKit.idl:
1539
1540         * WebCoreStatistics.cpp:
1541         (WebCoreStatistics::iconPageURLMappingCount):
1542         (WebCoreStatistics::iconRetainedPageURLCount):
1543         (WebCoreStatistics::iconRecordCount):
1544         (WebCoreStatistics::iconsWithDataCount):
1545
1546         * WebIconDatabase.cpp: Removed.
1547         * WebIconDatabase.h: Removed.
1548         * WebKitClassFactory.cpp:
1549
1550         * WebKitDLL.cpp:
1551         (shutDownWebKit):
1552
1553         * WebKitLogging.h:
1554
1555         * WebView.cpp:
1556         (WebView::close):
1557         (WebView::notifyDidAddIcon):
1558         (WebView::registerForIconNotification):
1559         (WebView::dispatchDidReceiveIconFromWebFrame):
1560         (WebView::onNotify):
1561
1562 2017-07-18  Matt Lewis  <jlewis3@apple.com>
1563
1564         Unreviewed, rolling out r219610.
1565
1566         This caused an api failure on all platforms for the test
1567         SnapshotImageLargeAsyncDecoding
1568
1569         Reverted changeset:
1570
1571         "Async image decoding for large images should be disabled
1572         after the first time a tile is painted"
1573         https://bugs.webkit.org/show_bug.cgi?id=174451
1574         http://trac.webkit.org/changeset/219610
1575
1576 2017-07-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
1577
1578         Async image decoding for large images should be disabled after the first time a tile is painted
1579         https://bugs.webkit.org/show_bug.cgi?id=174451
1580
1581         Reviewed by Simon Fraser.
1582
1583         * FullscreenVideoController.cpp:
1584         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
1585         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1586         (AcceleratedCompositingContext::paintContents):
1587         * WebCoreSupport/AcceleratedCompositingContext.h:
1588
1589 2017-07-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1590
1591         [Curl] Don't start downloading more than once for same request
1592         https://bugs.webkit.org/show_bug.cgi?id=174172
1593
1594         Reviewed by Alex Christensen.
1595
1596         * WebDownloadCurl.cpp:
1597         (WebDownload::init):
1598
1599 2017-07-12  Daniel Bates  <dabates@apple.com>
1600
1601         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
1602         https://bugs.webkit.org/show_bug.cgi?id=174427
1603
1604         Rubber-stamped by Brady Eidson.
1605
1606         * Plugins/PluginView.cpp:
1607         (WebCore::PluginView::start):
1608         (WebCore::PluginView::getURLNotify):
1609         (WebCore::PluginView::getURL):
1610         (WebCore::PluginView::handlePost):
1611
1612 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
1613
1614         [WTF] Move SoftLinking.h into WTF
1615         https://bugs.webkit.org/show_bug.cgi?id=174000
1616
1617         Reviewed by Alex Christensen.
1618
1619         * WebKitClassFactory.cpp:
1620         * WebView.cpp:
1621
1622 2017-07-05  Brady Eidson  <beidson@apple.com>
1623
1624         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
1625         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
1626
1627         Reviewed by Alex Christensen.
1628
1629         Adopt to the new constructor for FrameLoadRequest.
1630
1631         * Plugins/PluginView.cpp:
1632         (WebCore::PluginView::start):
1633         (WebCore::PluginView::getURLNotify):
1634         (WebCore::PluginView::getURL):
1635         (WebCore::PluginView::handlePost):
1636
1637 2017-07-03  Brady Eidson  <beidson@apple.com>
1638
1639         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
1640         https://bugs.webkit.org/show_bug.cgi?id=174073
1641
1642         Reviewed by Andy Estes.
1643
1644         * WebCoreSupport/WebFrameLoaderClient.cpp:
1645         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
1646         (WebFrameLoaderClient::registerForIconNotification): Deleted.
1647         * WebCoreSupport/WebFrameLoaderClient.h:
1648
1649 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
1650
1651         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
1652         https://bugs.webkit.org/show_bug.cgi?id=174004
1653
1654         Reviewed by Simon Fraser.
1655
1656         * WebCoreSupport/WebFrameLoaderClient.cpp:
1657         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1658
1659 2017-06-30  Daniel Bates  <dabates@apple.com>
1660
1661         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
1662         https://bugs.webkit.org/show_bug.cgi?id=165160
1663         <rdar://problem/29451999>
1664
1665         Reviewed by Brady Eidson.
1666
1667         Pass the document that is requesting the load to the loader.
1668
1669         * Plugins/PluginView.cpp:
1670         (WebCore::PluginView::start):
1671         (WebCore::PluginView::getURLNotify):
1672         (WebCore::PluginView::getURL):
1673         (WebCore::PluginView::handlePost):
1674
1675 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1676
1677         Refactor drag start codepaths to plumb a DragItem to client layers
1678         https://bugs.webkit.org/show_bug.cgi?id=173832
1679         Work towards <rdar://problem/32236827>
1680
1681         Reviewed by Ryosuke Niwa and Tim Horton.
1682
1683         Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
1684
1685         * WebCoreSupport/WebDragClient.cpp:
1686         (WebDragClient::startDrag):
1687         * WebCoreSupport/WebDragClient.h:
1688
1689 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
1690
1691         Remove excessive headers from JavaScriptCore
1692         https://bugs.webkit.org/show_bug.cgi?id=173812
1693
1694         Reviewed by Darin Adler.
1695
1696         * Plugins/PluginPackage.cpp:
1697
1698 2017-06-22  Daniel Bates  <dabates@apple.com>
1699
1700         Make FrameLoadRequest a move-only type
1701         https://bugs.webkit.org/show_bug.cgi?id=173682
1702
1703         Reviewed by Alex Christensen and Darin Adler.
1704
1705         A FrameLoadRequest groups together the information to perform a load into a single object
1706         that is more manageable to pass around than its constituent parts. Code that receives a
1707         FrameLoadRequest is expected to extract out the information it needs to complete its task.
1708         And it does not make sense to re-use the same FrameLoadRequest object for more than one
1709         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
1710
1711         * Plugins/PluginView.cpp:
1712         (WebCore::PluginView::start):
1713         (WebCore::PluginView::performRequest):
1714         (WebCore::PluginView::load):
1715         (WebCore::PluginView::getURLNotify):
1716         (WebCore::PluginView::getURL):
1717         (WebCore::PluginView::handlePost):
1718         * Plugins/PluginView.h:
1719         (WebCore::PluginRequest::PluginRequest):
1720
1721 2017-06-22  Daniel Bates  <dabates@apple.com>
1722
1723         [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
1724         https://bugs.webkit.org/show_bug.cgi?id=173683
1725
1726         Reviewed by Alex Christensen.
1727
1728         Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
1729         header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
1730         by including PluginView.h. The latter does not make use of the functionality
1731         provided by FrameLoadRequest.h.
1732
1733         * Plugins/PluginViewWin.cpp:
1734         * WebCoreSupport/WebContextMenuClient.cpp:
1735
1736 2017-06-21  Daniel Bates  <dabates@apple.com>
1737
1738         Cleanup FrameLoadRequest
1739         https://bugs.webkit.org/show_bug.cgi?id=173564
1740         <rdar://problem/32903570>
1741
1742         Reviewed by Brent Fulgham.
1743
1744         * Plugins/PluginView.cpp:
1745         (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
1746         we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
1747         we do not have one. Use C++11 brace initialization syntax.
1748         (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
1749         name as we do not have one. Use C++11 brace initialization syntax.
1750         (WebCore::PluginView::getURL): Ditto.
1751         (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
1752         function to closer to where it is actually used. Explicitly pass the null-string for the target
1753         frame name as we do not have one. Use C++11 brace initialization syntax.
1754
1755 2017-06-20  Daniel Bates  <dabates@apple.com>
1756
1757         Have FrameLoadRequest takes a Frame& instead of a Frame*
1758         https://bugs.webkit.org/show_bug.cgi?id=173614
1759         <rdar://problem/32884890>
1760
1761         Reviewed by Brent Fulgham.
1762
1763         * Plugins/PluginView.cpp:
1764         (WebCore::PluginView::performRequest):
1765         * WebFrame.cpp:
1766         (WebFrame::loadRequest):
1767
1768 2017-06-19  Chris Dumez  <cdumez@apple.com>
1769
1770         Use WTF::Function instead of std::function in more places in WebCore/
1771         https://bugs.webkit.org/show_bug.cgi?id=173535
1772
1773         Reviewed by Antti Koivisto.
1774
1775         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
1776
1777         * WebCoreSupport/WebFrameLoaderClient.cpp:
1778         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1779         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1780         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1781         (WebFrameLoaderClient::dispatchWillSubmitForm):
1782         (WebFrameLoaderClient::setUpPolicyListener):
1783         (WebFrameLoaderClient::receivedPolicyDecision):
1784         * WebCoreSupport/WebFrameLoaderClient.h:
1785
1786 2017-05-14 Frederic Wang  <fwang@igalia.com>
1787
1788         Add heuristic to avoid flattening "fullscreen" iframes
1789         https://bugs.webkit.org/show_bug.cgi?id=171914
1790
1791         Reviewed by Simon Fraser.
1792
1793         This commit ajusts the window port to internally use the new preference type for frame flattening.
1794         However, the "partial frame flattening" value is not exposed yet.
1795
1796         * WebView.cpp:
1797         (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
1798
1799 2017-06-17  Chris Dumez  <cdumez@apple.com>
1800
1801         Use WTF::Function instead of std::function in WebKit2/
1802         https://bugs.webkit.org/show_bug.cgi?id=173504
1803
1804         Reviewed by Darin Adler.
1805
1806         Use WTF::Function instead of std::function in WebKit2/ to avoid
1807         unnecessary copying.
1808
1809         * Plugins/PluginStream.cpp:
1810         (WebCore::PluginStream::willSendRequest):
1811         * Plugins/PluginStream.h:
1812
1813 2017-06-16  Sam Weinig  <sam@webkit.org>
1814
1815         [WebIDL] Remove custom bindings for HTMLDocument
1816         https://bugs.webkit.org/show_bug.cgi?id=173444
1817
1818         Reviewed by Darin Adler.
1819
1820         * DOMHTMLClasses.cpp:
1821         (DOMHTMLDocument::write):
1822         (DOMHTMLDocument::writeln):
1823         Update for new signature of write/writeln.
1824
1825 2017-06-16  Daniel Bates  <dabates@apple.com>
1826
1827         Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
1828         instead of URL { ParsedURLString, ... }
1829         https://bugs.webkit.org/show_bug.cgi?id=173495
1830         <rdar://problem/32827445>
1831
1832         Reviewed by Alex Christensen.
1833
1834         URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
1835         Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
1836         Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
1837         would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
1838         parse an arbitrary string that looks like a URL.
1839
1840         Also modernize the code using C++14 idioms.
1841
1842         * WebCoreSupport/WebContextMenuClient.cpp:
1843         (WebContextMenuClient::searchWithGoogle):
1844
1845 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
1846
1847         [Win] WebKit shouldn't include the forwarding header of WebKit itself
1848         https://bugs.webkit.org/show_bug.cgi?id=173352
1849
1850         Reviewed by Alex Christensen.
1851
1852         * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
1853
1854 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
1855
1856         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
1857         https://bugs.webkit.org/show_bug.cgi?id=173318
1858
1859         Reviewed by Darin Adler.
1860
1861         The logical frame size is currently calculated by scaling the frame size in pixels,
1862         and rounding the coordinates to the nearest integers. The computed logical frame
1863         size will in some cases be smaller than the scaled frame size in pixels, since it is
1864         represented as an IntSize. In these cases, the bottom line will not be painted.
1865         Instead of calculating the logical frame size by rounding the scaled frame in
1866         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
1867
1868         * WebCoreSupport/WebFrameLoaderClient.cpp:
1869         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1870
1871 2017-06-13  Daniel Bates  <dabates@apple.com>
1872
1873         Implement W3C Secure Contexts Draft Specification
1874         https://bugs.webkit.org/show_bug.cgi?id=158121
1875         <rdar://problem/26012994>
1876
1877         Reviewed by Brent Fulgham.
1878
1879         Part 4
1880
1881         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
1882
1883         * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
1884         * WebPreferenceKeysPrivate.h:
1885         * WebPreferences.cpp:
1886         (WebPreferences::initializeDefaultSettings):
1887         (WebPreferences::QueryInterface):
1888         (WebPreferences::setIsSecureContextAttributeEnabled):
1889         (WebPreferences::isSecureContextAttributeEnabled):
1890         * WebPreferences.h:
1891         * WebView.cpp:
1892         (WebView::notifyPreferencesChanged):
1893
1894 2017-06-13  Per Arne Vollan  <pvollan@apple.com>
1895
1896         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
1897         https://bugs.webkit.org/show_bug.cgi?id=173318
1898
1899         Reviewed by Alex Christensen.
1900
1901         The logical frame size is currently calculated by scaling the frame size in pixels,
1902         and rounding the coordinates to the nearest integers. The computed logical frame
1903         size will in some cases be smaller than the scaled frame size in pixels, since it is
1904         represented as an IntSize. In these cases, the bottom line will not be painted.
1905         Instead of calculating the logical frame size by rounding the scaled frame in
1906         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
1907  
1908         * WebView.cpp:
1909         (WebView::sizeChanged):
1910
1911 2017-06-13  Sam Weinig  <sam@webkit.org>
1912
1913         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
1914         https://bugs.webkit.org/show_bug.cgi?id=80733
1915
1916         Reviewed by Chris Dumez.
1917
1918         * WebFrame.cpp:
1919         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
1920
1921 2017-06-12  Daewoong Jang  <daewoong.jang@navercorp.com>
1922
1923         Remove WebCore::unloadModule and related data types
1924         https://bugs.webkit.org/show_bug.cgi?id=173231
1925
1926         Reviewed by Darin Adler.
1927
1928         * Plugins/PlatformModule.h: Added.
1929         (WebCore::PlatformModuleVersion::PlatformModuleVersion):
1930         * Plugins/PluginPackage.cpp:
1931         (WebCore::PluginPackage::freeLibraryTimerFired):
1932         * Plugins/PluginPackage.h:
1933
1934 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1935
1936         [iOS DnD] Add a hook to perform two-step drops in editable content
1937         https://bugs.webkit.org/show_bug.cgi?id=172992
1938         <rdar://problem/32590174>
1939
1940         Reviewed by Tim Horton.
1941
1942         Add a stub implementation for performTwoStepDrop on Windows.
1943
1944         * WebCoreSupport/WebEditorClient.h:
1945
1946 2017-06-04  Konstantin Tokarev  <annulen@yandex.ru>
1947
1948         Fix build of Windows-specific code with ICU 59.1
1949         https://bugs.webkit.org/show_bug.cgi?id=172729
1950
1951         Reviewed by Darin Adler.
1952
1953         Fix conversions from WTF::String to wchar_t* and vice versa.
1954
1955         * Plugins/PluginDatabaseWin.cpp:
1956         (WebCore::addPluginPathsFromRegistry):
1957         (WebCore::PluginDatabase::getPluginPathsInDirectories):
1958         (WebCore::addMozillaPluginDirectories):
1959         (WebCore::addWindowsMediaPlayerPluginDirectory):
1960         (WebCore::addAdobeAcrobatPluginDirectory):
1961         (WebCore::addJavaPluginDirectory):
1962         (WebCore::safariPluginsDirectory):
1963         (WebCore::addMacromediaPluginDirectories):
1964         * Plugins/PluginPackageWin.cpp:
1965         (WebCore::getVersionInfo):
1966         (WebCore::PluginPackage::fetchInfo):
1967         (WebCore::PluginPackage::load):
1968         * Plugins/PluginViewWin.cpp:
1969         (WebCore::PluginView::handlePostReadFile):
1970
1971 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
1972
1973         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
1974         https://bugs.webkit.org/show_bug.cgi?id=172709
1975
1976         Reviewed by Brent Fulgham.
1977
1978         Add method to exit fullscreen mode.
1979
1980         * Interfaces/IWebViewPrivate.idl:
1981         * WebView.cpp:
1982         (WebView::exitFullscreenIfNeeded):
1983         * WebView.h:
1984
1985 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
1986
1987         [Win] Create unique network storage session for each DRT.
1988         https://bugs.webkit.org/show_bug.cgi?id=172540
1989
1990         Reviewed by Brent Fulgham.
1991
1992         During layout testing, each DRT instance should have its own network storage session.
1993
1994         * Interfaces/IWebPreferencesPrivate.idl:
1995         * WebPreferences.cpp:
1996         (WebPreferences::switchNetworkLoaderToNewTestingSession):
1997         * WebPreferences.h:
1998
1999 2017-05-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2000
2001         [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
2002         https://bugs.webkit.org/show_bug.cgi?id=172535
2003
2004         Reviewed by Konstantin Tokarev.
2005
2006         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2007         (AcceleratedCompositingContext::paintContents): Append the fifth argument.
2008         * WebCoreSupport/AcceleratedCompositingContext.h: Ditto.
2009
2010 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
2011
2012         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
2013         https://bugs.webkit.org/show_bug.cgi?id=172071
2014
2015         Reviewed by Alexey Proskuryakov.
2016
2017         We need to delete all cookies after each test.
2018
2019         * Interfaces/IWebPreferencesPrivate.idl:
2020         * WebPreferences.cpp:
2021         (WebPreferences::linkPreloadEnabled):
2022         (WebPreferences::clearNetworkLoaderSession):
2023         * WebPreferences.h:
2024
2025 2017-05-13  Chris Dumez  <cdumez@apple.com>
2026
2027         Stop using RefPtr::release()
2028         https://bugs.webkit.org/show_bug.cgi?id=172074
2029
2030         Reviewed by Geoffrey Garen.
2031
2032         * WebFrame.cpp:
2033         (WebFrame::loadPlainTextString):
2034         (WebFrame::loadHTMLString):
2035         * WebFramePolicyListener.cpp:
2036         (WebFramePolicyListener::receivedPolicyDecision):
2037
2038 2017-05-13  Chris Dumez  <cdumez@apple.com>
2039
2040         Drop uses of PassRefPtr in WebKit/win
2041         https://bugs.webkit.org/show_bug.cgi?id=172067
2042
2043         Reviewed by Yusuke Suzuki.
2044
2045         * DOMEventsClasses.cpp:
2046         (DOMEvent::DOMEvent):
2047         (DOMEvent::createInstance):
2048         * DOMEventsClasses.h:
2049         (DOMUIEvent::DOMUIEvent):
2050         (DOMKeyboardEvent::DOMKeyboardEvent):
2051         (DOMMouseEvent::DOMMouseEvent):
2052         (DOMMutationEvent::DOMMutationEvent):
2053         (DOMOverflowEvent::DOMOverflowEvent):
2054         (DOMWheelEvent::DOMWheelEvent):
2055         * MemoryStream.cpp:
2056         (MemoryStream::MemoryStream):
2057         (MemoryStream::createInstance):
2058         * MemoryStream.h:
2059         * Plugins/PluginDatabase.cpp:
2060         (WebCore::PluginDatabase::refresh):
2061         (WebCore::PluginDatabase::add):
2062         (WebCore::PluginDatabase::loadPersistentMetadataCache):
2063         * Plugins/PluginDatabase.h:
2064         * Plugins/PluginPackage.cpp:
2065         (WebCore::PluginPackage::createPackage):
2066         (WebCore::PluginPackage::createPackageFromCache):
2067         * Plugins/PluginPackage.h:
2068         * Plugins/PluginStream.h:
2069         (WebCore::PluginStream::create):
2070         * WebActionPropertyBag.cpp:
2071         (WebActionPropertyBag::WebActionPropertyBag):
2072         (WebActionPropertyBag::createInstance):
2073         * WebActionPropertyBag.h:
2074         * WebArchive.cpp:
2075         (WebArchive::createInstance):
2076         (WebArchive::WebArchive):
2077         * WebArchive.h:
2078         * WebBackForwardList.cpp:
2079         (WebBackForwardList::WebBackForwardList):
2080         (WebBackForwardList::createInstance):
2081         * WebBackForwardList.h:
2082         * WebCoreSupport/EmbeddedWidget.cpp:
2083         (EmbeddedWidget::create):
2084         * WebCoreSupport/EmbeddedWidget.h:
2085         * WebCoreSupport/WebChromeClient.h:
2086         * WebFrame.cpp:
2087         (WebFrame::loadData):
2088         (WebFrame::createSubframeWithOwnerElement):
2089         * WebFrame.h:
2090         * WebFramePolicyListener.cpp:
2091         (WebFramePolicyListener::WebFramePolicyListener):
2092         (WebFramePolicyListener::createInstance):
2093         * WebFramePolicyListener.h:
2094         * WebGeolocationPolicyListener.cpp:
2095         (WebGeolocationPolicyListener::createInstance):
2096         (WebGeolocationPolicyListener::WebGeolocationPolicyListener):
2097         * WebGeolocationPolicyListener.h:
2098         * WebHistoryItem.cpp:
2099         (WebHistoryItem::WebHistoryItem):
2100         (WebHistoryItem::createInstance):
2101         * WebHistoryItem.h:
2102         * WebMutableURLRequest.cpp:
2103         (WebMutableURLRequest::setFormData):
2104         (WebMutableURLRequest::formData):
2105         * WebMutableURLRequest.h:
2106         * WebResource.cpp:
2107         (WebResource::createInstance):
2108         * WebResource.h:
2109         * WebScriptWorld.cpp:
2110         (WebScriptWorld::WebScriptWorld):
2111         (WebScriptWorld::createInstance):
2112         * WebScriptWorld.h:
2113         * WebURLAuthenticationChallengeSender.cpp:
2114         (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
2115         (WebURLAuthenticationChallengeSender::createInstance):
2116         * WebURLAuthenticationChallengeSender.h:
2117         * WebView.cpp:
2118         (WebView::setFullScreenElement):
2119         * WebView.h:
2120
2121 2017-05-11  Chris Dumez  <cdumez@apple.com>
2122
2123         Drop remaining uses of PassRefPtr in WebCore
2124         https://bugs.webkit.org/show_bug.cgi?id=172013
2125
2126         Reviewed by Yusuke Suzuki.
2127
2128         * Plugins/PluginView.cpp:
2129         (WebCore::PluginView::bindingInstance):
2130
2131 2017-05-11  Chris Dumez  <cdumez@apple.com>
2132
2133         Stop using PassRefPtr in platform/graphics
2134         https://bugs.webkit.org/show_bug.cgi?id=171977
2135
2136         Reviewed by Alex Christensen.
2137
2138         Build fix.
2139
2140         * FullscreenVideoController.cpp:
2141         (FullscreenVideoController::enterFullscreen):
2142         * WebKitDLL.cpp:
2143         (loadResourceIntoBuffer):
2144
2145 2017-05-09  Sam Weinig  <sam@webkit.org>
2146
2147         Remove support for legacy Notifications
2148         https://bugs.webkit.org/show_bug.cgi?id=171487
2149
2150         Reviewed by Jon Lee.
2151
2152         * WebCoreSupport/WebChromeClient.cpp:
2153         (WebChromeClient::WebChromeClient):
2154         * WebCoreSupport/WebChromeClient.h:
2155         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
2156         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
2157         Remove legacy notification specific code.
2158
2159 2017-05-09  Dean Jackson  <dino@apple.com>
2160
2161         Fix Windows build.
2162
2163         * Plugins/PluginView.h:
2164         * Plugins/PluginViewWin.cpp:
2165         (WebCore::PluginView::paint):
2166
2167 2017-05-06  Alexey Proskuryakov  <ap@apple.com>
2168
2169         REGRESSION (r216294): The new test fails on WebKit1
2170         https://bugs.webkit.org/show_bug.cgi?id=171780
2171
2172         Rolling back https://trac.webkit.org/r216294, https://trac.webkit.org/r216296,
2173         https://trac.webkit.org/216299, https://trac.webkit.org/216330
2174
2175         * Plugins/PluginView.h:
2176         * Plugins/PluginViewWin.cpp:
2177         (WebCore::PluginView::paint):
2178
2179 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
2180
2181         Fix Windows build after r216294.
2182
2183         * Plugins/PluginView.h:
2184         * Plugins/PluginViewWin.cpp:
2185         (WebCore::PluginView::paint):
2186
2187 2017-05-04  Commit Queue  <commit-queue@webkit.org>
2188
2189         Unreviewed, rolling out r216206.
2190         https://bugs.webkit.org/show_bug.cgi?id=171714
2191
2192         Multiple LayoutTests crashing in Document::page() (Requested
2193         by ap on #webkit).
2194
2195         Reverted changeset:
2196
2197         "Remove support for legacy Notifications"
2198         https://bugs.webkit.org/show_bug.cgi?id=171487
2199         http://trac.webkit.org/changeset/216206
2200
2201 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
2202
2203         [Win] Remove redundant macros that are set in the CMake config
2204         https://bugs.webkit.org/show_bug.cgi?id=171571
2205
2206         Reviewed by Brent Fulgham.
2207
2208         * COMEnumVariant.h:
2209         * COMPropertyBag.h:
2210         * WebKitPrefix.h:
2211
2212 2017-05-04  Sam Weinig  <sam@webkit.org>
2213
2214         Remove support for legacy Notifications
2215         https://bugs.webkit.org/show_bug.cgi?id=171487
2216
2217         Reviewed by Jon Lee.
2218
2219         * WebCoreSupport/WebChromeClient.cpp:
2220         (WebChromeClient::WebChromeClient):
2221         * WebCoreSupport/WebChromeClient.h:
2222         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
2223         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
2224         Remove legacy notification specific code.
2225
2226 2017-04-27  Alex Christensen  <achristensen@webkit.org>
2227
2228         Modernize Frame.h
2229         https://bugs.webkit.org/show_bug.cgi?id=171357
2230
2231         Reviewed by Andy Estes.
2232
2233         * WebCoreSupport/WebEditorClient.cpp:
2234         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
2235         * WebCoreSupport/WebEditorClient.h:
2236
2237 2017-04-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2238
2239         [WinCairo] Fix build break after updating ANGLE
2240         https://bugs.webkit.org/show_bug.cgi?id=170980
2241
2242         Reviewed by Brent Fulgham.
2243
2244         * WebCoreSupport/AcceleratedCompositingContext.cpp: Define GL_GLEXT_PROTOTYPES.
2245
2246 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
2247
2248         [Win] REGRESSION(r215486): Windows Release build is broken
2249         https://bugs.webkit.org/show_bug.cgi?id=171024
2250         <rdar://problem/31722618>
2251
2252         Reviewed by Mark Lam.
2253
2254         Windows WebKit refers to a handful of JSC methods that are always
2255         inline. We need to include 'HeapInlines.h' to get the implementation
2256         of these methods.
2257
2258         * Plugins/PluginPackage.cpp:
2259         * WebFrame.cpp:
2260         * WebView.cpp:
2261
2262 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2263
2264         Unreviewed, fix the Windows build after r215385
2265
2266         r215385 introduced a new virtual method on ChromeClient that needs to be implemented in WebChromeClient for
2267         Windows in WebKit1.
2268
2269         * WebCoreSupport/WebChromeClient.cpp:
2270         (WebChromeClient::createIconForFiles):
2271         * WebCoreSupport/WebChromeClient.h:
2272
2273 2017-04-10  Chris Dumez  <cdumez@apple.com>
2274
2275         Drop Timer::startOneShot() overload taking a double
2276         https://bugs.webkit.org/show_bug.cgi?id=170659
2277
2278         Reviewed by Yusuke Suzuki.
2279
2280         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
2281
2282         * Plugins/PluginMessageThrottlerWin.cpp:
2283         (WebCore::PluginMessageThrottlerWin::appendMessage):
2284         (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
2285         * Plugins/PluginViewWin.cpp:
2286         (WebCore::PluginView::invalidateRect):
2287         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2288         (AcceleratedCompositingContext::scheduleLayerFlush):
2289
2290 2017-04-09  Chris Dumez  <cdumez@apple.com>
2291
2292         Drop Timer::startRepeating() overload taking a double
2293         https://bugs.webkit.org/show_bug.cgi?id=170656
2294
2295         Reviewed by Yusuke Suzuki.
2296
2297         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
2298
2299         * FullscreenVideoController.cpp:
2300
2301 2017-04-09  Chris Dumez  <cdumez@apple.com>
2302
2303         Start dropping Timer API dealing with double
2304         https://bugs.webkit.org/show_bug.cgi?id=170649
2305
2306         Reviewed by Yusuke Suzuki.
2307
2308         Start dropping Timer API dealing with double as people should use Seconds now.
2309
2310         * Plugins/PluginPackage.cpp:
2311         (WebCore::PluginPackage::freeLibrarySoon):
2312         * Plugins/PluginStream.cpp:
2313         (WebCore::PluginStream::deliverData):
2314         * Plugins/PluginView.cpp:
2315         (WebCore::PluginView::requestTimerFired):
2316         (WebCore::PluginView::scheduleRequest):
2317         (WebCore::PluginView::setJavaScriptPaused):
2318         (WebCore::PluginView::keepAlive):
2319         * Plugins/PluginViewWin.cpp:
2320         (WebCore::PluginView::wndProc):
2321         * WebView.cpp:
2322         (WebView::closeWindowSoon):
2323
2324 2017-04-08  Chris Dumez  <cdumez@apple.com>
2325
2326         Drop std::chrono support from Timer class
2327         https://bugs.webkit.org/show_bug.cgi?id=170645
2328
2329         Reviewed by Sam Weinig.
2330
2331         Drop std::chrono support from Timer class now that we prefer using Seconds type.
2332
2333         * WebView.cpp:
2334         (WebView::setCacheModel):
2335
2336 2017-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2337
2338         [WinCairo] WebCore::PlatformDisplay::terminateEGLDisplay causes a crash in libGLESv2.dll while processing atexit
2339         https://bugs.webkit.org/show_bug.cgi?id=170331
2340
2341         Reviewed by Michael Catanzaro.
2342
2343         * WebKitDLL.cpp:
2344         (shutDownWebKit): Call PlatformDisplay::shutDownEglDisplays in shutDownWebKit.
2345
2346 2017-03-30  James Craig  <jcraig@apple.com>
2347
2348         AX: Expose a new AXSubrole for explicit ARIA "group" role
2349         https://bugs.webkit.org/show_bug.cgi?id=169810
2350         <rdar://problem/31039693>
2351
2352         Reviewed by Chris Fleizach.
2353
2354         Account for Windows platform role mapping.
2355
2356         * AccessibleBase.cpp:
2357         (MSAARole):
2358
2359 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2360
2361         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
2362         https://bugs.webkit.org/show_bug.cgi?id=169168
2363         <rdar://problem/30688374>
2364
2365         Reviewed by Tim Horton.
2366
2367         Minor tweak to adjust for a changed interface. See WebKit and WebCore ChangeLogs for more information.
2368
2369         * WebCoreSupport/WebDragClient.cpp:
2370         (WebDragClient::actionMaskForDrag):
2371         * WebCoreSupport/WebDragClient.h:
2372
2373 2017-03-13  Per Arne Vollan  <pvollan@apple.com>
2374
2375         [Win] Compile fix.
2376         https://bugs.webkit.org/show_bug.cgi?id=169545
2377
2378         Reviewed by Brent Fulgham.
2379
2380         Fix inconsistent dll linkage warnings.
2381  
2382         * WebKitDLL.cpp:
2383         * WebKitDLL.h:
2384
2385 2017-03-13  Per Arne Vollan  <pvollan@apple.com>
2386
2387         Unreviewed Win build fix.
2388         
2389         WebCore::CookiesStrategy::addCookie has been removed, we should also remove the override.
2390
2391         * WebCoreSupport/WebPlatformStrategies.cpp:
2392         (WebPlatformStrategies::addCookie): Deleted.
2393         (WebPlatformStrategies::addCookie): Deleted.
2394         * WebCoreSupport/WebPlatformStrategies.h:
2395
2396 2017-03-10  Brent Fulgham  <bfulgham@apple.com>
2397
2398         [Win] Re-export a few symbols for backwards compatibility
2399         https://bugs.webkit.org/show_bug.cgi?id=169490
2400         <rdar://problem/30983623>
2401
2402         Reviewed by Dean Jackson.
2403
2404         Re-introduce a workaround that re-exports a few JavaScriptCore functions
2405         that had been erroneously exported by WebKit in older builds. This
2406         is needed so that we do not break certain old software still being used.
2407
2408         * WebKitDLL.cpp:
2409         (DllMain): Bind functions at startup.
2410         (bindJavaScriptTrampoline): Find JavaScriptCore library functions and
2411         re-export them from WebKit.dll.
2412         * WebKitDLL.h: Only advertise these functions when building WebKt itself.
2413
2414 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
2415
2416         Expand font-weight and font-stretch to take any number
2417         https://bugs.webkit.org/show_bug.cgi?id=168889
2418
2419         Reviewed by Simon Fraser.
2420
2421         Migrate off old enum types.
2422
2423         * WebKitGraphics.cpp:
2424         (makeFont):
2425
2426 2017-03-02  Sam Weinig  <sam@webkit.org>
2427
2428         Rename htmlediting.h/cpp to Editing.h/cpp
2429         https://bugs.webkit.org/show_bug.cgi?id=169103
2430
2431         Reviewed by Alex Christensen.
2432
2433         * AccessibleTextImpl.cpp:
2434
2435 2017-03-01  Alex Christensen  <achristensen@webkit.org>
2436
2437         Actually fix Windows build.
2438
2439         * WebFrame.cpp:
2440         (WebFrame::invalidate):
2441         r213266 changed Style::Force to ResolveStyleType::Rebuild, so I did so here.
2442
2443 2017-03-01  Alex Christensen  <achristensen@webkit.org>
2444
2445         Fix Windows build after r213266
2446         https://bugs.webkit.org/show_bug.cgi?id=169049
2447
2448         * WebFrame.cpp:
2449         (WebFrame::invalidate):
2450
2451 2017-02-27  Per Arne Vollan  <pvollan@apple.com>
2452
2453         [Win] Http preload tests are failing.
2454         https://bugs.webkit.org/show_bug.cgi?id=168910
2455
2456         Reviewed by Alex Christensen.
2457
2458         The feature is not enabled.
2459
2460         * WebView.cpp:
2461         (WebView::notifyPreferencesChanged):
2462
2463 2017-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2464
2465         Better handle Thread and RunLoop initialization
2466         https://bugs.webkit.org/show_bug.cgi?id=167828
2467
2468         Reviewed by Yusuke Suzuki.
2469
2470         Remove unnecessary call to WTF::initializeMainThread().
2471
2472         * WebView.cpp:
2473         (WebView::WebView):
2474
2475 2017-02-20  Per Arne Vollan  <pvollan@apple.com>
2476
2477         [Win] Custom scale factor is not applied in all cases.
2478         https://bugs.webkit.org/show_bug.cgi?id=168117
2479
2480         Reviewed by Brent Fulgham.
2481
2482         We should not call the function deviceScaleFactorForWindow directly, since this
2483         will return the system scale factor, and ignore the custom scale factor.
2484
2485         * WebView.cpp:
2486         (WebView::handleContextMenuEvent):
2487         (WebView::handleMouseEvent):
2488         (WebView::setAcceleratedCompositing):
2489
2490 2017-02-16  Daniel Bates  <dabates@apple.com>
2491
2492         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
2493         https://bugs.webkit.org/show_bug.cgi?id=168417
2494         <rdar://problem/30541748>
2495
2496         Reviewed by Brent Fulgham.
2497
2498         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
2499         Widget* as it is always called with a valid Widget.
2500
2501         * WebCoreSupport/WebFrameLoaderClient.cpp:
2502         (WebFrameLoaderClient::redirectDataToPlugin):
2503         * WebCoreSupport/WebFrameLoaderClient.h:
2504
2505 2017-02-15  Anders Carlsson  <andersca@apple.com>
2506
2507         Another attempt at fixing the Windows build.
2508
2509         * WebCoreSupport/WebDragClient.cpp:
2510         (WebDragClient::startDrag):
2511
2512 2017-02-15  Anders Carlsson  <andersca@apple.com>
2513
2514         Try to fix the Windows build.
2515
2516         * WebCoreSupport/WebDragClient.h:
2517
2518 2017-02-15  Anders Carlsson  <andersca@apple.com>
2519
2520         Modernize DragClient::startDrag somewhat
2521         https://bugs.webkit.org/show_bug.cgi?id=168379
2522
2523         Reviewed by Tim Horton.
2524
2525         Update for WebCore changes.
2526
2527         * WebCoreSupport/WebDragClient.cpp:
2528         (WebDragClient::startDrag):
2529
2530 2017-02-10  Daniel Bates  <dabates@apple.com>
2531
2532         Attempt to fix the WinCairo 64-Bit Release build following <https://trac.webkit.org/changeset/212173>
2533         (https://bugs.webkit.org/show_bug.cgi?id=166774)
2534
2535         Touch WebKit.idl in the hopes that it will cause CMake to regenerate the COM interface files.
2536
2537         * Interfaces/WebKit.idl:
2538
2539 2017-02-10  Daniel Bates  <dabates@apple.com>
2540
2541         Detach frame from document when entering page cache
2542         https://bugs.webkit.org/show_bug.cgi?id=166774
2543         <rdar://problem/29904368>
2544
2545         Reviewed by Chris Dumez.
2546
2547         * Interfaces/IWebPreferencesPrivate.idl:
2548         * WebPreferenceKeysPrivate.h:
2549         * WebPreferences.cpp:
2550         (WebPreferences::initializeDefaultSettings):
2551         (WebPreferences::setAllowsPageCacheWithWindowOpener): Deleted.
2552         (WebPreferences::allowsPageCacheWithWindowOpener): Deleted.
2553         * WebPreferences.h:
2554         * WebView.cpp:
2555         (WebView::notifyPreferencesChanged):
2556
2557 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
2558
2559         [Resource Timing] Enable Resource Timing by default in Tests
2560         https://bugs.webkit.org/show_bug.cgi?id=168145
2561
2562         Reviewed by Ryosuke Niwa.
2563
2564         * Interfaces/IWebPreferencesPrivate.idl:
2565         * WebPreferenceKeysPrivate.h:
2566         * WebPreferences.cpp:
2567         (WebPreferences::initializeDefaultSettings):
2568         (WebPreferences::setResourceTimingEnabled):
2569         (WebPreferences::resourceTimingEnabled):
2570         * WebPreferences.h:
2571         * WebView.cpp:
2572         (WebView::notifyPreferencesChanged):
2573
2574 2017-02-06  Alex Christensen  <achristensen@webkit.org>
2575
2576         More build fixes after r211751
2577         https://bugs.webkit.org/show_bug.cgi?id=166998
2578
2579         * WebDownloadCFNet.cpp:
2580         (WebDownload::didReceiveAuthenticationChallenge):
2581
2582 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
2583
2584         Rename AnimationController to CSSAnimationController
2585         https://bugs.webkit.org/show_bug.cgi?id=167829
2586
2587         Reviewed by Simon Fraser.
2588
2589         * WebFrame.cpp:
2590
2591 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2592
2593         Drag images should be anchored to the mouse location
2594         https://bugs.webkit.org/show_bug.cgi?id=167690
2595         <rdar://problem/30295261>
2596
2597         Reviewed by Enrica Casucci.
2598
2599         Adds some plumbing for the anchor point in the WK1 client layer.
2600
2601         * WebCoreSupport/WebDragClient.cpp:
2602         (WebDragClient::startDrag):
2603         * WebCoreSupport/WebDragClient.h:
2604
2605 2017-02-02  Per Arne Vollan  <pvollan@apple.com>
2606
2607         [Win][HiDPI] Scale factor is applied twice in accelerated compositing mode.
2608         https://bugs.webkit.org/show_bug.cgi?id=167732
2609
2610         Reviewed by Brent Fulgham.
2611
2612         Backing layer should not be scaled when CACFLayerSetContentsScale is used for scaling.
2613
2614         * WebView.cpp:
2615         (WebView::setAcceleratedCompositing):
2616
2617 2017-02-02  Chris Dumez  <cdumez@apple.com>
2618
2619         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
2620         https://bugs.webkit.org/show_bug.cgi?id=167738
2621         <rdar://problem/30229990>
2622
2623         Reviewed by Andreas Kling.
2624
2625         The BackForwardClient no longer needs to worry about removing HistoryItems
2626         from the PageCache now that WebCore takes care of it.
2627
2628         * BackForwardList.cpp:
2629         (BackForwardList::close):
2630
2631 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
2632
2633         Add Link Preload as an off-by-default experimental feature menu item.
2634         https://bugs.webkit.org/show_bug.cgi?id=167201
2635
2636         Reviewed by Ryosuke Niwa.
2637
2638         * WebPreferenceKeysPrivate.h:
2639         * WebPreferences.cpp:
2640         (WebPreferences::initializeDefaultSettings):
2641         (WebPreferences::valueForKey):
2642         (WebPreferences::setLinkPreloadEnabled):
2643         (WebPreferences::linkPreloadEnabled):
2644         * WebPreferences.h:
2645         * Interfaces/IWebPreferencesPrivate.idl:
2646
2647 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2648
2649         Add User Timing Experimental Feature
2650         https://bugs.webkit.org/show_bug.cgi?id=167542
2651         <rdar://problem/22746307>
2652
2653         Reviewed by Ryosuke Niwa.
2654
2655         * Interfaces/IWebPreferencesPrivate.idl:
2656         * WebPreferenceKeysPrivate.h:
2657         * WebPreferences.cpp:
2658         (WebPreferences::initializeDefaultSettings):
2659         (WebPreferences::setUserTimingEnabled):
2660         (WebPreferences::userTimingEnabled):
2661         * WebPreferences.h:
2662         * WebView.cpp:
2663         (WebView::notifyPreferencesChanged):
2664         Add setting for User Timing runtime enabled feature.
2665
2666 2017-01-26  Chris Dumez  <cdumez@apple.com>
2667
2668         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2669         https://bugs.webkit.org/show_bug.cgi?id=167421
2670         <rdar://problem/30188490>
2671
2672         Reviewed by Darin Adler.
2673
2674         Add a new setting allowing layout tests to enable PageCache in a window
2675         that has an opener, for convenience.
2676
2677         * WebPreferenceKeysPrivate.h:
2678         * WebPreferences.cpp:
2679         (WebPreferences::initializeDefaultSettings):
2680         * WebPreferences.h:
2681
2682 2017-01-26  Keith Miller  <keith_miller@apple.com>
2683
2684         classInfo should take a VM so it is not materialized from the object on each call
2685         https://bugs.webkit.org/show_bug.cgi?id=167424
2686
2687         Rubber Stamped by Michael Saboff.
2688
2689         Previously, classInfo() would get the VM from the target's
2690         MarkedBlock.  Most callers already have a VM on hand, so it is
2691         wasteful to compute the VM from the marked block every time. This
2692         patch refactors some of the most common callers of classInfo(),
2693         jsDynamicCast and inherits to take a VM as well.
2694
2695         * WebFrame.cpp:
2696         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2697         * WebView.cpp:
2698         (WebView::elementFromJS):
2699
2700 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2701
2702         Crash when setting custom scale factor.
2703         https://bugs.webkit.org/show_bug.cgi?id=167369
2704
2705         Reviewed by Sam Weinig.
2706
2707         Add null pointer check.
2708
2709         * WebView.cpp:
2710         (WebView::setCustomBackingScaleFactor):
2711
2712 2017-01-24  Youenn Fablet  <youennf@gmail.com>
2713
2714         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
2715         https://bugs.webkit.org/show_bug.cgi?id=167294
2716
2717         Reviewed by Alex Christensen.
2718
2719         * WebView.cpp:
2720         (WebView::initWithFrame):
2721
2722 2017-01-23  Chris Dumez  <cdumez@apple.com>
2723
2724         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
2725         https://bugs.webkit.org/show_bug.cgi?id=167308
2726         <rdar://problem/30144964>
2727
2728         Unreviewed, do a partial revert of r211033 to fix assertion.
2729
2730         * WebCoreSupport/WebChromeClient.cpp:
2731         (WebChromeClient::exitFullScreenForElement):
2732
2733 2017-01-20  Darin Adler  <darin@apple.com>
2734
2735         Remove PassRefPtr from "page" directory of WebCore, also deploy references
2736         https://bugs.webkit.org/show_bug.cgi?id=167224
2737
2738         Reviewed by Chris Dumez.
2739
2740         * Plugins/PluginView.cpp:
2741         (WebCore::PluginView::status): Pass reference.
2742         (WebCore::PluginView::focusPluginElement): Ditto.
2743
2744         * WebCoreSupport/WebChromeClient.cpp:
2745         (WebChromeClient::createWindow): Updated for change to ChromeClient.
2746         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
2747         (WebChromeClient::runJavaScriptAlert): Ditto.
2748         (WebChromeClient::runJavaScriptConfirm): Ditto.
2749         (WebChromeClient::runJavaScriptPrompt): Ditto.
2750         (WebChromeClient::contentsSizeChanged): Ditto.
2751         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
2752         (WebChromeClient::print): Ditto.
2753         (WebChromeClient::exceededDatabaseQuota): Ditto.
2754         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
2755         (WebChromeClient::attachRootGraphicsLayer): Ditto.
2756         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
2757         (WebChromeClient::enterVideoFullscreenForVideoElement): Ditto.
2758         (WebChromeClient::createPopupMenu): Ditto.
2759         (WebChromeClient::createSearchPopupMenu): Ditto.
2760         (WebChromeClient::supportsFullScreenForElement): Ditto.
2761         (WebChromeClient::enterFullScreenForElement): Ditto.
2762         (WebChromeClient::exitFullScreenForElement): Ditto.
2763         (WebChromeClient::shouldUseTiledBackingForFrameView): Ditto.
2764         * WebCoreSupport/WebChromeClient.h: Ditto.
2765
2766 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2767
2768         Remove never changing IndexedDB RuntimeEnabledFeature
2769         https://bugs.webkit.org/show_bug.cgi?id=167278
2770
2771         Reviewed by Darin Adler.
2772
2773         * WebView.cpp:
2774         (WebView::notifyPreferencesChanged):
2775
2776 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2777
2778         Cleanup RuntimeEnabledFeatures
2779         https://bugs.webkit.org/show_bug.cgi?id=167228
2780
2781         Reviewed by Simon Fraser.
2782
2783         * WebView.cpp:
2784         (WebView::notifyPreferencesChanged):
2785
2786 2017-01-20  Alex Christensen  <achristensen@webkit.org>
2787
2788         Build Fix for Windows DumpRenderTree after r210976
2789         https://bugs.webkit.org/show_bug.cgi?id=167115
2790
2791         * WebPreferences.h:
2792         Remove extra space.
2793         * IWebPreferencesPrivate.idl:
2794         Add new interface functions.
2795         * WebView.cpp:
2796         We use new functions that are only in IWebPreferencesPrivate4,
2797         so instantiate that COM object instead of version 3.
2798
2799 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
2800
2801         Build Fix for Windows DumpRenderTree after r210976
2802
2803         * WebPreferenceKeysPrivate.h:
2804         * WebPreferences.cpp:
2805         (WebPreferences::initializeDefaultSettings):
2806         (WebPreferences::setWebAnimationsEnabled):
2807         (WebPreferences::webAnimationsEnabled):
2808         * WebPreferences.h:
2809         * WebView.cpp:
2810         Add toggle APIs for WebAnimations.
2811
2812 2017-01-19  Chris Dumez  <cdumez@apple.com>
2813
2814         iterable<> should be enabled on WK1
2815         https://bugs.webkit.org/show_bug.cgi?id=167221
2816         <rdar://problem/30108531>
2817
2818         Reviewed by Youenn Fablet.
2819
2820         * Interfaces/IWebPreferencesPrivate.idl:
2821         * WebPreferenceKeysPrivate.h:
2822         * WebPreferences.cpp:
2823         (WebPreferences::setDOMIteratorEnabled): Deleted.
2824         (WebPreferences::domIteratorEnabled): Deleted.
2825         * WebPreferences.h:
2826         * WebView.cpp:
2827         (WebView::notifyPreferencesChanged):
2828
2829 2017-01-18  Alex Christensen  <achristensen@webkit.org>
2830
2831         Fix WinCairo build after r210845.
2832         https://bugs.webkit.org/show_bug.cgi?id=167055
2833
2834         * WebCoreSupport/WebFrameLoaderClient.cpp:
2835         * WebCoreSupport/WebFrameLoaderClient.h:
2836         shouldCacheResponse isn't used when loading with libcurl.
2837         It was dead code before Darin added "override".
2838         WebCore/FrameLoaderClient.h has this inside of USE(CFURLCONNECTION) macros, now we have them here, too.
2839
2840 2017-01-18  Andreas Kling  <akling@apple.com>
2841
2842         Document::securityOrigin() should return a reference.
2843         <https://webkit.org/b/167124>
2844
2845         Reviewed by Sam Weinig.
2846
2847         * Plugins/PluginView.cpp:
2848         (WebCore::PluginView::load):
2849         * WebCoreSupport/WebChromeClient.cpp:
2850         (WebChromeClient::exceededDatabaseQuota):
2851         * WebCoreSupport/WebFrameLoaderClient.cpp:
2852         (WebFrameLoaderClient::didRunInsecureContent):
2853         * WebCoreSupport/WebFrameLoaderClient.h:
2854         * WebCoreSupport/WebGeolocationClient.cpp:
2855         (WebGeolocationClient::requestPermission):
2856         * WebFrame.cpp:
2857         (WebFrame::allowsFollowingLink):
2858
2859 2017-01-15  Darin Adler  <darin@apple.com>
2860
2861         Remove PassRefPtr from "loader" directory of WebCore
2862         https://bugs.webkit.org/show_bug.cgi?id=167055
2863
2864         Reviewed by Alex Christensen.
2865
2866         * Plugins/PluginView.cpp:
2867         (WebCore::PluginView::mediaCanStart): Fix call to dispatchDidFailToStartPlugin
2868         by calling it directly on WebFrameLoaderClient. If my theory is correct, the old
2869         call has been broken and doing nothing since r177941, two years ago, which made
2870         the argument types different between FrameLoaderClient and WebFrameLoaderClient,
2871         leaving WebFrameLoaderClient::dispatchDidFailToStartPlugin as dead code.
2872
2873         * WebCoreSupport/WebChromeClient.cpp:
2874         (WebChromeClient::runOpenPanel): Updated for change to ChromeClient.
2875         * WebCoreSupport/WebChromeClient.h: Ditto.
2876
2877         * WebCoreSupport/WebEditorClient.cpp:
2878         (WebEditorUndoCommand::WebEditorUndoCommand): Take a reference instead of
2879         a PassRefPtr. Also use Ref instead of RefPtr.
2880         (WebEditorClient::shouldChangeTypingStyle): Deleted. Empty function that was
2881         never called.
2882         (WebEditorClient::webViewDidChangeTypingStyle): Ditto.
2883         (WebEditorClient::webViewDidChangeSelection): Ditto.
2884         (WebEditorClient::registerUndoStep):  Take reference instead of PassRefPtr.
2885         (WebEditorClient::registerRedoStep): Ditto.
2886         * WebCoreSupport/WebEditorClient.h: Updated for the above. Also marked the
2887         class and member functions final and made them all private, which will
2888         help us catch if there are any that don't correctly match WebCore.
2889
2890         * WebCoreSupport/WebFrameLoaderClient.cpp:
2891         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Updated
2892         for change to ChromeClient.
2893         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
2894         (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Ditto.
2895         (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto.
2896         (WebFrameLoaderClient::createFrame): Ditto. Also merged two functions into
2897         one because one was private and only called by the other.
2898         (WebFrameLoaderClient::createPlugin): Ditto.
2899         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
2900         (WebFrameLoaderClient::createNetworkingContext): Ditto.
2901         * WebCoreSupport/WebFrameLoaderClient.h: Ditto.
2902
2903         * WebCoreSupport/WebFrameNetworkingContext.h:
2904         (WebFrameNetworkingContext::create): Return a Ref instead of a PassRefPtr.
2905
2906 2017-01-12  Joseph Pecoraro  <pecoraro@apple.com>
2907
2908         Remove unnecessary includes of Page.h
2909         https://bugs.webkit.org/show_bug.cgi?id=166996
2910
2911         Reviewed by Yusuke Suzuki.
2912
2913         * AccessibleTextImpl.cpp:
2914         * BackForwardList.cpp:
2915
2916 2017-01-06  Darin Adler  <darin@apple.com>
2917
2918         Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
2919         https://bugs.webkit.org/show_bug.cgi?id=166797
2920
2921         Reviewed by Alex Christensen.
2922
2923         * WebCoreSupport/WebEditorClient.h: Update argument to take a reference
2924         instead of a PassRefPtr.
2925
2926 2017-01-05  Andreas Kling  <akling@apple.com>
2927
2928         Remove ChromeClient::needTouchEvents().
2929         <https://webkit.org/b/166723>
2930
2931         Rubber-stamped by Antti Koivisto.
2932
2933         * WebCoreSupport/WebChromeClient.h:
2934
2935 2017-01-04  Darin Adler  <darin@apple.com>
2936
2937         Remove PassRefPtr use from the "html" directory, other improvements
2938         https://bugs.webkit.org/show_bug.cgi?id=166635
2939
2940         Reviewed by Alex Christensen.
2941
2942         * WebCoreSupport/WebChromeClient.cpp:
2943         (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
2944         * WebCoreSupport/WebChromeClient.h: Updated for the above.
2945
2946 2016-12-30  Darin Adler  <darin@apple.com>
2947
2948         Remove PassRefPtr use from the "dom" directory, related cleanup
2949         https://bugs.webkit.org/show_bug.cgi?id=166569
2950
2951         Reviewed by Alex Christensen.
2952
2953         * WebCoreSupport/WebFrameLoaderClient.cpp:
2954         (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated since StringWithDirection::title
2955         is now a data member, not a function member.
2956         (WebFrameLoaderClient::updateGlobalHistory): Ditto.
2957         (WebFrameLoaderClient::setTitle): Ditto.
2958         * WebDataSource.cpp:
2959         (WebDataSource::pageTitle): Ditto.
2960
2961 2016-12-25  Yusuke Suzuki  <utatane.tea@gmail.com>
2962
2963         Propagate the source origin as much as possible
2964         https://bugs.webkit.org/show_bug.cgi?id=166348
2965
2966         Reviewed by Darin Adler.
2967
2968         * Plugins/PluginPackage.cpp:
2969         (WebCore::NPN_Evaluate):
2970         (WebCore::makeSource): Deleted.
2971
2972 2016-12-22  Andy Estes  <aestes@apple.com>
2973
2974         Make WebCore::EditorInsertAction an enum class
2975         https://bugs.webkit.org/show_bug.cgi?id=166424
2976
2977         Reviewed by Brent Fulgham.
2978
2979         * WebCoreSupport/WebEditorClient.cpp:
2980         (kit):
2981         (WebEditorClient::shouldInsertNode):
2982         (WebEditorClient::shouldInsertText):
2983
2984 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2985
2986         [ES6] Enable ES6 Modules
2987         https://bugs.webkit.org/show_bug.cgi?id=165849
2988
2989         Reviewed by Geoffrey Garen.
2990
2991         * Interfaces/IWebPreferencesPrivate.idl:
2992         * WebPreferenceKeysPrivate.h:
2993         * WebPreferences.cpp:
2994         (WebPreferences::setES6ModulesEnabled): Deleted.
2995         (WebPreferences::es6ModulesEnabled): Deleted.
2996         * WebPreferences.h:
2997         * WebView.cpp:
2998         (WebView::notifyPreferencesChanged):
2999
3000 2016-12-10  Filip Pizlo  <fpizlo@apple.com>
3001
3002         The DOM should have an advancing wavefront opaque root barrier
3003         https://bugs.webkit.org/show_bug.cgi?id=165712
3004
3005         Reviewed by Yusuke Suzuki.
3006         
3007         Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
3008
3009         * Plugins/PluginView.cpp:
3010         (WebCore::PluginView::start):
3011         (WebCore::PluginView::stop):
3012         (WebCore::PluginView::performRequest):
3013         (WebCore::PluginView::npObject):
3014         (WebCore::PluginView::privateBrowsingStateChanged):
3015         * Plugins/PluginViewWin.cpp:
3016         (WebCore::PluginView::dispatchNPEvent):
3017         (WebCore::PluginView::handleKeyboardEvent):
3018         (WebCore::PluginView::handleMouseEvent):
3019         (WebCore::PluginView::setNPWindowRect):
3020         * WebCoreStatistics.cpp:
3021         (WebCoreStatistics::javaScriptObjectsCount):
3022         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3023         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3024         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3025         (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
3026         (WebCoreStatistics::javaScriptObjectTypeCounts):
3027         (WebCoreStatistics::shouldPrintExceptions):
3028         (WebCoreStatistics::setShouldPrintExceptions):
3029         (WebCoreStatistics::memoryStatistics):
3030         * WebJavaScriptCollector.cpp:
3031         (WebJavaScriptCollector::objectCount):
3032
3033 2016-12-09  Geoffrey Garen  <ggaren@apple.com>
3034
3035         TextPosition and OrdinalNumber should be more like idiomatic numbers
3036         https://bugs.webkit.org/show_bug.cgi?id=165678
3037
3038         Reviewed by Filip Pizlo.
3039
3040         Adopt default constructor.
3041
3042         * Plugins/PluginPackage.cpp:
3043         (WebCore::makeSource):
3044
3045 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3046
3047         Enable SharedArrayBuffer, remove the flag
3048         https://bugs.webkit.org/show_bug.cgi?id=165614
3049
3050         Rubber stamped by Geoffrey Garen.
3051
3052         * Interfaces/IWebPreferencesPrivate.idl:
3053
3054 2016-11-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3055
3056         [WTF] Import std::optional reference implementation as WTF::Optional
3057         https://bugs.webkit.org/show_bug.cgi?id=164199
3058
3059         Reviewed by Saam Barati and Sam Weinig.
3060
3061         Use WTF::Optional::value_or.
3062
3063         * Plugins/PluginView.cpp:
3064         (WebCore::PluginView::performRequest):
3065         * WebCoreSupport/WebFrameLoaderClient.cpp:
3066         (WebFrameLoaderClient::dispatchDidCommitLoad):
3067         * WebCoreSupport/WebFrameLoaderClient.h:
3068         * WebSecurityOrigin.cpp:
3069         (WebSecurityOrigin::port):
3070
3071 2016-11-19  Simon Fraser  <simon.fraser@apple.com>
3072
3073         [iOS WK2] When zoomed in and panning on pages with fixed bars, parts of the bars are sometimes missing
3074         https://bugs.webkit.org/show_bug.cgi?id=164855
3075
3076         Reviewed by Sam Weinig.
3077         
3078         Remove the "inStableState" parameter from flushCompositingState() etc.
3079
3080         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3081         (AcceleratedCompositingContext::flushPendingLayerChanges):
3082         * WebView.cpp:
3083         (WebView::flushPendingGraphicsLayerChanges):
3084
3085 2016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
3086
3087         [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
3088         https://bugs.webkit.org/show_bug.cgi?id=164827
3089
3090         Reviewed by Ryosuke Niwa.
3091
3092         * Interfaces/IWebPreferencesPrivate.idl:
3093         * WebPreferenceKeysPrivate.h:
3094         * WebPreferences.cpp:
3095         (WebPreferences::setES6ModulesEnabled):
3096         (WebPreferences::es6ModulesEnabled):
3097         * WebPreferences.h:
3098         * WebView.cpp:
3099         (WebView::notifyPreferencesChanged):
3100
3101 2016-11-14  Alex Christensen  <achristensen@webkit.org>
3102
3103         Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
3104         https://bugs.webkit.org/show_bug.cgi?id=164720
3105
3106         Reviewed by Brady Eidson.
3107
3108         * WebDatabaseManager.cpp:
3109         (DidModifyOriginData::dispatchToMainThread):
3110         (DidModifyOriginData::DidModifyOriginData):
3111         (WebDatabaseManager::dispatchDidModifyOrigin):
3112         (WebDatabaseManager::dispatchDidModifyDatabase):
3113         * WebDatabaseManager.h:
3114         * WebSecurityOrigin.cpp:
3115         (WebSecurityOrigin::usage):
3116         (WebSecurityOrigin::quota):
3117         (WebSecurityOrigin::setQuota):
3118
3119 2016-11-13  Darin Adler  <darin@apple.com>
3120
3121         Fix exception handling in SQL database code, streamline and update code
3122         https://bugs.webkit.org/show_bug.cgi?id=164685
3123
3124         Reviewed by Sam Weinig.
3125
3126         * WebDatabaseManager.cpp:
3127         (WebDatabaseManager::origins): Use DatabaseTracker.
3128         (WebDatabaseManager::databasesWithOrigin): Ditto.
3129         (WebDatabaseManager::detailsForDatabase): Use reference.
3130         (WebDatabaseManager::deleteAllDatabases): Use DatabaseTracker.
3131         (WebDatabaseManager::deleteOrigin): Ditto.
3132         (WebDatabaseManager::deleteDatabase): Ditto.
3133         (WebDatabaseManager::dispatchDidModifyOrigin): Use reference
3134         and DatabaseTracker.
3135         (WebDatabaseManager::setQuota): Ditto.
3136         (WebDatabaseManager::dispatchDidModifyDatabase): Ditto.
3137         * WebDatabaseManager.h: Updated client functions to take a reference.
3138
3139         * WebSecurityOrigin.cpp:
3140         (WebSecurityOrigin::usage): Update to use DatabaseTracker.
3141         (WebSecurityOrigin::quota): Ditto.
3142         (WebSecurityOrigin::setQuota): Ditto.
3143
3144 2016-11-11  Eric Carlson  <eric.carlson@apple.com>
3145
3146         [MediaStream] defer resolution of getUserMedia promise made in a background tab
3147         https://bugs.webkit.org/show_bug.cgi?id=164643
3148         <rdar://problem/29048317>
3149
3150         Unreviewed build fix after r208606.
3151
3152         * Plugins/PluginView.cpp:
3153         (WebCore::PluginView::mediaCanStart):
3154         * Plugins/PluginView.h:
3155
3156 2016-11-11  Darin Adler  <darin@apple.com>
3157
3158         Move Node from ExceptionCode to ExceptionOr
3159         https://bugs.webkit.org/show_bug.cgi?id=164515
3160
3161         Reviewed by Sam Weinig.
3162
3163         * DOMCoreClasses.cpp:
3164         (DOMNode::insertBefore): Update exception handling.
3165         (DOMNode::removeChild): Ditto.
3166
3167 2016-10-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3168
3169         MemoryPressureHandler shouldn't know how to release WebCore memory
3170         https://bugs.webkit.org/show_bug.cgi?id=160497
3171
3172         Reviewed by Michael Catanzaro.
3173
3174         Set the low memory handler before installing the memory pressure handler.
3175
3176         * WebView.cpp:
3177         (WebView::initWithFrame):
3178
3179 2016-11-09  Alex Christensen  <achristensen@webkit.org>
3180
3181         Fix Windows build after r208499
3182         https://bugs.webkit.org/show_bug.cgi?id=164562
3183
3184         * WebKitDLL.cpp:
3185         (shutDownWebKit):
3186
3187 2016-11-09  Darin Adler  <darin@apple.com>
3188
3189         Move Range from ExceptionCode to ExceptionOr
3190         https://bugs.webkit.org/show_bug.cgi?id=164457
3191
3192         Reviewed by Alex Christensen.
3193
3194         * WebView.cpp:
3195         (WebView::onIMERequestCharPosition): Updated for new exception handling.
3196
3197 2016-11-09  Darin Adler  <darin@apple.com>
3198
3199         Move EventTarget from ExceptionCode to ExceptionOr
3200         https://bugs.webkit.org/show_bug.cgi?id=164465
3201
3202         Reviewed by Youenn Fablet.
3203
3204         * DOMCoreClasses.cpp:
3205         (DOMNode::dispatchEvent): Updated exception handling.
3206         (DOMWindow::dispatchEvent): Ditto.
3207
3208 2016-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3209
3210         Safari does not emit composition end if blurred for dead key / Japanese IME
3211         https://bugs.webkit.org/show_bug.cgi?id=164369
3212         <rdar://problem/29050439>
3213
3214         Reviewed by Ryosuke Niwa.
3215
3216         Add a stub implementation of canceledComposition.
3217
3218         * WebCoreSupport/WebEditorClient.cpp:
3219         (WebEditorClient::canceledComposition):
3220         * WebCoreSupport/WebEditorClient.h:
3221
3222 2016-11-04  Per Arne Vollan  <pvollan@apple.com>
3223
3224         [Win] Page visibility tests are timing out.
3225         https://bugs.webkit.org/show_bug.cgi?id=164363
3226
3227         Reviewed by Brent Fulgham.
3228
3229         Add method to set page visibility.
3230
3231         * Interfaces/IWebViewPrivate.idl:
3232         * WebView.cpp:
3233         (WebView::QueryInterface):
3234         (WebView::findString):
3235         (WebView::setVisibilityState):
3236         * WebView.h:
3237
3238 2016-11-01  Ryosuke Niwa  <rniwa@webkit.org>
3239
3240         Remove CUSTOM_ELEMENTS build flag
3241         https://bugs.webkit.org/show_bug.cgi?id=164267
3242
3243         Reviewed by Antti Koivisto.
3244
3245         Removed the build flag.
3246
3247         * WebView.cpp:
3248         (WebView::notifyPreferencesChanged):
3249
3250 2016-10-29  Filip Pizlo  <fpizlo@apple.com>
3251
3252         JSC should support SharedArrayBuffer
3253         https://bugs.webkit.org/show_bug.cgi?id=163986
3254
3255         Reviewed by Keith Miller.
3256
3257         Support the RuntimeFlag.
3258
3259         * Interfaces/IWebPreferencesPrivate.idl:
3260
3261 2016-10-31  Joseph Pecoraro  <pecoraro@apple.com>
3262
3263         Use #pragma once in WebCore
3264         https://bugs.webkit.org/show_bug.cgi?id=164194
3265
3266         Rubber-stamped by Sam Weinig.
3267
3268         * WebCoreSupport/WebContextMenuClient.cpp:
3269         (WebContextMenuClient::isSpeaking):
3270         (WebContextMenuClient::shareMenuItem): Deleted.
3271         * WebCoreSupport/WebContextMenuClient.h:
3272         Remove this dead code since r192333.
3273
3274 2016-10-31  Darin Adler  <darin@apple.com>
3275
3276         Convert Document from ExceptionCode to Exception
3277         https://bugs.webkit.org/show_bug.cgi?id=164212
3278
3279         Reviewed by Alex Christensen.
3280
3281         * DOMCoreClasses.cpp:
3282         (DOMDocument::createElement): Updated exception handling.
3283         (DOMDocument::createEvent): Ditto.
3284
3285 2016-10-30  Darin Adler  <darin@apple.com>
3286
3287         Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
3288         https://bugs.webkit.org/show_bug.cgi?id=164206
3289
3290         Reviewed by Chris Dumez.
3291
3292         * DOMCoreClasses.cpp:
3293         (DOMElement::setAttribute): Updated exception handling.
3294         * DOMHTMLClasses.cpp:
3295         (DOMHTMLElement::setInnerHTML): Ditto.
3296
3297 2016-10-30  Brent Fulgham  <bfulgham@apple.com>
3298
3299         Unreviewed build fix (Direct2D)
3300
3301         * WebView.cpp:
3302         (WebView::paintWithDirect2D): Update for revised GraphicsContext
3303         begin/end draw behavior.
3304
3305 2016-10-28  Darin Adler  <darin@apple.com>
3306
3307         Move all classes in the HTML directory from ExceptionCode to Exception
3308         https://bugs.webkit.org/show_bug.cgi?id=163876
3309
3310         Reviewed by Sam Weinig.
3311
3312         * DOMHTMLClasses.cpp:
3313         (DOMHTMLElement::setInnerText): Update exception handling.
3314         * FullscreenVideoController.cpp:
3315         (FullscreenVideoController::setVolume): Ditto.
3316
3317 2016-10-27  Brent Fulgham  <bfulgham@apple.com>
3318
3319         Unreviewed build fix.
3320
3321         * WebView.cpp:
3322         (WebView::paintWithDirect2D): Correct merge error.
3323
3324 2016-10-25  Brent Fulgham  <bfulgham@apple.com>
3325
3326         [Win][Direct2D] Create a RAII Helper Class for the Render Target
3327         https://bugs.webkit.org/show_bug.cgi?id=164005
3328
3329         Reviewed by Alex Christensen.
3330
3331         * WebView.cpp:
3332         (WebView::sizeChanged): Construct RenderTarget with higher-resolution display timer.
3333         (WebView::paintWithDirect2D): Revise to use new RenderTargetHelper class.
3334
3335 2016-10-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3336
3337         Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
3338         https://bugs.webkit.org/show_bug.cgi?id=163948
3339         <rdar://problem/28921433>
3340
3341         Reviewed by Darin Adler.
3342
3343         Add support for new drag and drop-related EditAction enum values.
3344
3345         * WebCoreSupport/WebEditorClient.cpp:
3346         (undoNameForEditAction):
3347
3348 2016-10-26  Brian Burg  <bburg@apple.com>
3349
3350         Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
3351         https://bugs.webkit.org/show_bug.cgi?id=164046
3352
3353         Reviewed by Joseph Pecoraro.
3354
3355         * WebCoreSupport/WebInspectorClient.h:
3356
3357 2016-10-19  Alex Christensen  <achristensen@webkit.org>
3358
3359         Revert r207151
3360         https://bugs.webkit.org/show_bug.cgi?id=163675
3361
3362         Reviewed by Brent Fulgham.
3363
3364         * DefaultDownloadDelegate.h:
3365         * WebCoreSupport/WebFrameLoaderClient.cpp:
3366         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
3367         * WebCoreSupport/WebFrameNetworkingContext.cpp:
3368         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3369         * WebCoreSupport/WebFrameNetworkingContext.h:
3370         * WebCoreSupport/WebPlatformStrategies.cpp:
3371         * WebDownload.h:
3372         * WebError.cpp:
3373         (WebError::localizedDescription):
3374         (WebError::sslPeerCertificate):
3375         * WebError.h:
3376         * WebMutableURLRequest.cpp:
3377         (WebMutableURLRequest::mutableCopy):
3378         * WebURLAuthenticationChallenge.cpp:
3379         (WebURLAuthenticationChallenge::initWithProtectionSpace):
3380         (WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
3381         * WebURLResponse.cpp:
3382         (WebURLResponse::sslPeerCertificate):
3383         * WebURLResponse.h:
3384         * WebView.cpp:
3385         (WebView::setCacheModel):
3386         (WebView::canHandleRequest):
3387         (WebView::notifyPreferencesChanged):
3388         (updateSharedSettingsFromPreferencesIfNeeded):
3389
3390 2016-10-18  Darin Adler  <darin@apple.com>
3391
3392         Move many miscellaneous classes from ExceptionCode to Exception
3393         https://bugs.webkit.org/show_bug.cgi?id=163645
3394
3395         Reviewed by Ryosuke Niwa.
3396
3397         * DOMCoreClasses.cpp:
3398         (DOMDocument::getComputedStyle): Use ptr instead of get since the return
3399         value is now Ref instead of RefPtr.
3400
3401 2016-10-18  Anders Carlsson  <andersca@apple.com>
3402
3403         Try to fix the Windows build.
3404
3405         * WebHistoryItem.cpp:
3406         (WebHistoryItem::redirectURLs):
3407
3408 2016-10-18  Anders Carlsson  <andersca@apple.com>
3409
3410         Move some history specific HistoryItem code to WebHistoryItem
3411         https://bugs.webkit.org/show_bug.cgi?id=163567
3412
3413         Reviewed by Tim Horton.
3414
3415         Remove these, they aren't used.
3416
3417         * WebCoreSupport/WebFrameLoaderClient.cpp:
3418         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
3419         * WebHistory.cpp:
3420         (WebHistory::visitedURL):
3421         * WebHistoryItem.cpp:
3422         (WebHistoryItem::initFromDictionaryRepresentation):
3423         (WebHistoryItem::dictionaryRepresentation):
3424
3425 2016-10-16  Darin Adler  <darin@apple.com>
3426
3427         Move CSS classes from ExceptionCode to Exception
3428         https://bugs.webkit.org/show_bug.cgi?id=163494
3429
3430         Reviewed by Sam Weinig.
3431
3432         * DOMCSSClasses.cpp:
3433         (DOMCSSStyleDeclaration::setCssText): Remove ExceptionCode handling.
3434         (DOMCSSStyleDeclaration::setProperty): Ditto.
3435
3436 2016-10-12  Anders Carlsson  <andersca@apple.com>
3437
3438         Copy BackForwardList from WebCore to WebKit/win
3439         https://bugs.webkit.org/show_bug.cgi?id=163360
3440
3441         Reviewed by Alex Christensen.
3442
3443         Use our local BackForwardList class instead of WebCore::BackForwardList.
3444
3445         * BackForwardList.cpp: Added.
3446         * BackForwardList.h: Added.
3447         * WebBackForwardList.h:
3448         * WebView.cpp:
3449         (WebView::initWithFrame):
3450         (WebView::backForwardList):
3451
3452 2016-10-13  Anders Carlsson  <andersca@apple.com>
3453
3454         Get rid of the HistoryItemVector typedef
3455         https://bugs.webkit.org/show_bug.cgi?id=163398
3456
3457         Reviewed by Beth Dakin.
3458
3459         Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
3460
3461         * WebBackForwardList.cpp:
3462         (WebBackForwardList::backListWithLimit):
3463         (WebBackForwardList::forwardListWithLimit):
3464         * WebHistoryItem.cpp:
3465         (WebHistoryItem::children):
3466
3467 2016-10-12  Brent Fulgham  <bfulgham@apple.com>
3468
3469         [Win] Unreviewed build fix after r207218.
3470
3471         The CQ-landed patch used the old USE(CFNETWORK) compiler guard.
3472         It should be using USE(CFURLCONNECTION).
3473
3474         * WebCache.cpp: Missed one!
3475
3476 2016-10-12  Brent Fulgham  <bfulgham@apple.com>
3477
3478         [Win] Unreviewed build fix after r207218.
3479
3480         The CQ-landed patch used the old USE(CFNETWORK) compiler guard.
3481         It should be using USE(CFURLCONNECTION).
3482
3483         * WebCache.cpp:
3484         (WebCache::cacheFolder):
3485         (WebCache::setCacheFolder):
3486
3487 2016-10-12  Per Arne Vollan  <pvollan@apple.com>
3488
3489         [Win] Parallel DRTs are sharing preferences and cache.
3490         https://bugs.webkit.org/show_bug.cgi?id=163013
3491
3492         Reviewed by Brent Fulgham.
3493
3494         Make it possible for a WebKit client to use separate preferences and cache.
3495
3496         * Interfaces/IWebPreferencesPrivate.idl:
3497         * WebApplicationCache.cpp:
3498         (applicationCachePath):
3499         * WebCache.cpp:
3500         (WebCache::cacheFolder):
3501         (WebCache::setCacheFolder):
3502         * WebDatabaseManager.cpp:
3503         (databasesDirectory):
3504         * WebPreferences.cpp:
3505         (WebPreferences::applicationId):
3506         (WebPreferences::valueForKey):
3507         (WebPreferences::setValueForKey):
3508         (WebPreferences::save):
3509         (WebPreferences::QueryInterface):
3510         (WebPreferences::modernMediaControlsEnabled):
3511         (WebPreferences::setApplicationId):
3512         * WebPreferences.h:
3513         * WebView.cpp:
3514         (WebView::setCacheModel):
3515
3516 2016-10-11  Alex Christensen  <achristensen@webkit.org>
3517
3518         Remove dead networking code
3519         https://bugs.webkit.org/show_bug.cgi?id=163263
3520
3521         Reviewed by Daniel Bates.
3522
3523         * DefaultDownloadDelegate.h:
3524         * WebCoreSupport/WebFrameLoaderClient.cpp:
3525         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
3526         * WebCoreSupport/WebFrameNetworkingContext.cpp:
3527         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3528         * WebCoreSupport/WebFrameNetworkingContext.h:
3529         * WebCoreSupport/WebPlatformStrategies.cpp:
3530         * WebDownload.h:
3531         * WebError.cpp:
3532         (WebError::localizedDescription):
3533         (WebError::sslPeerCertificate):
3534         * WebError.h:
3535         * WebMutableURLRequest.cpp:
3536         (WebMutableURLRequest::mutableCopy):
3537         * WebURLAuthenticationChallenge.cpp:
3538         (WebURLAuthenticationChallenge::initWithProtectionSpace):
3539         (WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
3540         * WebURLResponse.cpp:
3541         (WebURLResponse::sslPeerCertificate):
3542         * WebURLResponse.h:
3543         * WebView.cpp:
3544         (WebView::setCacheModel):
3545         (WebView::canHandleRequest):
3546         (WebView::notifyPreferencesChanged):
3547         (updateSharedSettingsFromPreferencesIfNeeded):
3548
3549 2016-10-11  Ryan Haddad  <ryanhaddad@apple.com>
3550
3551         Unreviewed, rolling out r207067.
3552
3553         This change caused webkitpy test failures.
3554
3555         Reverted changeset:
3556
3557         "[Win] Parallel DRTs are sharing preferences and cache."
3558         https://bugs.webkit.org/show_bug.cgi?id=163013
3559         http://trac.webkit.org/changeset/207067
3560
3561 2016-10-11  Per Arne Vollan  <pvollan@apple.com>
3562
3563         [Win] Parallel DRTs are sharing preferences and cache.
3564         https://bugs.webkit.org/show_bug.cgi?id=163013
3565
3566         Reviewed by Brent Fulgham.
3567
3568         Make it possible for a WebKit client to use separate preferences and cache.
3569
3570         * Interfaces/IWebPreferencesPrivate.idl:
3571         * WebApplicationCache.cpp:
3572         (applicationCachePath):
3573         * WebCache.cpp:
3574         (WebCache::cacheFolder):
3575         (WebCache::setCacheFolder):
3576         * WebDatabaseManager.cpp:
3577         (databasesDirectory):
3578         * WebPreferences.cpp:
3579         (WebPreferences::applicationId):
3580         (WebPreferences::valueForKey):
3581         (WebPreferences::setValueForKey):
3582         (WebPreferences::save):
3583         (WebPreferences::QueryInterface):
3584         (WebPreferences::modernMediaControlsEnabled):
3585         (WebPreferences::setApplicationId):
3586         * WebPreferences.h:
3587         * WebView.cpp:
3588         (WebView::setCacheModel):
3589
3590 2016-10-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3591
3592         Support InputEvent.inputType for the new InputEvent spec
3593         https://bugs.webkit.org/show_bug.cgi?id=163025
3594         <rdar://problem/28658092>
3595
3596         Reviewed by Darin Adler.
3597
3598         * WebCoreSupport/WebEditorClient.cpp:
3599         (undoNameForEditAction):
3600
3601 2016-10-04  Brent Fulgham  <bfulgham@apple.com>
3602
3603         [Win][Direct2D] Connect WebCore/WebKit Drawing
3604         https://bugs.webkit.org/show_bug.cgi?id=162924
3605
3606         Reviewed by Alex Christensen.
3607
3608         Update the Windows WebKit layer to optionally use the Direct2D
3609         backend.
3610
3611         * FullscreenVideoController.cpp: Disable some CoreAnimation-based
3612         accelerated compositing logic.
3613         * FullscreenVideoController.h:
3614         * WebFrame.cpp:
3615         (WebFrame::spoolPages): Disable in Direct2D.
3616         * WebView.cpp:
3617         (WebView::ensureBackingStore): Add Direct2D logic.
3618         (WebView::scrollBackingStore): Ditto.
3619         (WebView::sizeChanged): Ditto.
3620         (WebView::paintWithDirect2D): Added.
3621         (WebView::WebViewWndProc): Call Direct2D paint routine.
3622         * WebView.h:
3623
3624 2016-10-02  Darin Adler  <darin@apple.com>
3625
3626         Rename ExceptionCode-based exception handling to "legacy"
3627         https://bugs.webkit.org/show_bug.cgi?id=162859
3628
3629         Reviewed by Chris Dumez.
3630
3631         * Interfaces/DOMEvents.idl: Let the script rename here (in a comment).
3632
3633 2016-09-29  Konstantin Tokarev  <annulen@yandex.ru>
3634
3635         Fixed compilation of PluginView when NETSCAPE_PLUGIN_API is disabled
3636         https://bugs.webkit.org/show_bug.cgi?id=162725
3637
3638         Reviewed by Alex Christensen.
3639
3640         Fix for r206460, streamDidFinishLoading() does not override anything
3641         when NETSCAPE_PLUGIN_API is disabled because PlugivView does not
3642         inherit PluginStreamClient in this case.
3643
3644         * Plugins/PluginView.h:
3645
3646 2016-09-27  Konstantin Tokarev  <annulen@yandex.ru>
3647
3648         Use override specifiers in PluginView
3649         https://bugs.webkit.org/show_bug.cgi?id=162628
3650
3651         Reviewed by Alex Christensen.
3652
3653         * Plugins/PluginView.h:
3654
3655 2016-09-23  Antoine Quint  <graouts@apple.com>
3656
3657         Add a new runtime flag for work on modern media controls (off by default)
3658         https://bugs.webkit.org/show_bug.cgi?id=162420
3659         <rdar://problem/27989489>
3660
3661         Reviewed by Eric Carlson.
3662
3663         * Interfaces/IWebPreferencesPrivate.idl:
3664         * WebPreferenceKeysPrivate.h:
3665         * WebPreferences.cpp:
3666         (WebPreferences::setModernMediaControlsEnabled):
3667         (WebPreferences::modernMediaControlsEnabled):
3668         (WebPreferences::setCustomElementsEnabled): Deleted.
3669         * WebPreferences.h:
3670         * WebView.cpp:
3671         (WebView::notifyPreferencesChanged):
3672
3673 2016-09-15  Brady Eidson  <beidson@apple.com>
3674
3675         WKWebView.hasOnlySecureContent always returns "YES" after going back to a CachedPage (even if it has http resources).
3676         <rdar://problem/27681261> and https://bugs.webkit.org/show_bug.cgi?id=162043
3677
3678         Reviewed by Brent Fulgham. 
3679
3680         * WebCoreSupport/WebFrameLoaderClient.cpp:
3681         (WebFrameLoaderClient::dispatchDidCommitLoad):
3682         * WebCoreSupport/WebFrameLoaderClient.h:
3683
3684 2016-09-07  Mark Lam  <mark.lam@apple.com>
3685
3686         Add CatchScope and force all exception checks to be via ThrowScope or CatchScope.
3687         https://bugs.webkit.org/show_bug.cgi?id=161498
3688
3689         Reviewed by Geoffrey Garen.
3690
3691         * Plugins/PluginPackage.cpp:
3692         (WebCore::NPN_Evaluate):
3693         (WebCore::NPN_Invoke):
3694
3695 2016-09-06  Per Arne Vollan  <pvollan@apple.com>
3696
3697         [Win] Null pointer crash under WebView::scrollOffset.
3698         https://bugs.webkit.org/show_bug.cgi?id=161620
3699
3700         Reviewed by Darin Adler.
3701
3702         Added null pointer checks.
3703
3704         * WebView.cpp:
3705         (WebView::scrollOffset):
3706         (WebView::scrollBy):
3707         (WebView::visibleContentRect):
3708
3709 2016-09-03  Darin Adler  <darin@apple.com>
3710
3711         Streamline DOMImplementation, and move it to our new DOM exception system
3712         https://bugs.webkit.org/show_bug.cgi?id=161295
3713
3714         Reviewed by Ryosuke Niwa.
3715
3716         * WebFrame.cpp:
3717         (WebFrame::canProvideDocumentSource): Updated to use isXMLMIMEType in its new
3718         location in MIMETypeRegistry instead of in DOMImplementation.
3719
3720 2016-09-02  Ryosuke Niwa  <rniwa@webkit.org>
3721
3722         Build fix attempt after r205381.
3723
3724         * WebCoreSupport/WebEditorClient.h:
3725
3726 2016-08-31  Keith Rollin  <krollin@apple.com>
3727
3728         WebKit should set a subsystem for os_log so it's easier to filter for WebKit log messages
3729         https://bugs.webkit.org/show_bug.cgi?id=160969
3730         <rdar://problem/26068734>
3731
3732         Reviewed by Simon Fraser.
3733
3734         Enable subsystem- and channel-related data and functions when using
3735         RELEASE_LOG macros. Use the DECLARE_LOG_CHANNEL, DEFINE_LOG_CHANNEL,
3736         and LOG_CHANNEL_ADDRESS macros that are now defined in WTF.
3737
3738         * WebKitLogging.cpp:
3739         * WebKitLogging.h:
3740         * WebView.cpp:
3741         (WebView::initWithFrame):
3742
3743 2016-08-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3744
3745         [GTK] Accelerated compositing does not work in Wayland
3746         https://bugs.webkit.org/show_bug.cgi?id=115803
3747
3748         Reviewed by Michael Catanzaro.
3749
3750         Update to the new GLContext API.
3751
3752         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3753         (AcceleratedCompositingContext::initialize):
3754         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
3755
3756 2016-08-21  Alex Christensen  <achristensen@webkit.org>
3757
3758         Use Document& instead of Document* when getting cookies
3759         https://bugs.webkit.org/show_bug.cgi?id=161011
3760
3761         Reviewed by Darin Adler.
3762
3763         * Plugins/PluginView.cpp:
3764         (WebCore::PluginView::getValueForURL):
3765
3766 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
3767
3768         Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
3769         https://bugs.webkit.org/show_bug.cgi?id=160923
3770
3771         Reviewed by Tim Horton.
3772
3773         didLayout(LayoutMilestones) -> didReachLayoutMilestone(LayoutMilestones)
3774         dispatchDidLayout(LayoutMilestones) -> dispatchDidReachLayoutMilestone(LayoutMilestones)
3775
3776         * WebCoreSupport/WebFrameLoaderClient.cpp:
3777         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
3778         (WebFrameLoaderClient::dispatchDidLayout): Deleted.
3779         * WebCoreSupport/WebFrameLoaderClient.h:
3780
3781 2016-08-18  Anders Carlsson  <andersca@apple.com>
3782
3783         Move an NPAPI-only function from WebCore to WebKit
3784         https://bugs.webkit.org/show_bug.cgi?id=160967
3785
3786         Reviewed by Sam Weinig.
3787
3788         * Plugins/PluginView.cpp:
3789         (WebCore::PluginView::~PluginView):
3790         (WebCore::PluginView::PluginView):
3791         (WebCore::PluginView::getValue):
3792         * Plugins/PluginView.h:
3793
3794 2016-08-15  Joseph Pecoraro  <pecoraro@apple.com>
3795
3796         Remove unused includes of wtf headers
3797         https://bugs.webkit.org/show_bug.cgi?id=160839
3798
3799         Reviewed by Alex Christensen.
3800
3801         * WebFrame.h:
3802
3803 2016-08-09  Alex Christensen  <achristensen@webkit.org>
3804
3805         Move NetworkStorageSession management to WebCore
3806         https://bugs.webkit.org/show_bug.cgi?id=160173
3807
3808         Reviewed by Brady Eidson.
3809
3810         * WebCoreSupport/WebFrameNetworkingContext.cpp:
3811         (identifierBase):
3812         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
3813         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3814         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3815         (WebFrameNetworkingContext::blockedError):
3816         (WebFrameNetworkingContext::storageSession):
3817         (privateSession): Deleted.
3818         * WebCoreSupport/WebPlatformStrategies.cpp:
3819         (WebPlatformStrategies::createPasteboardStrategy):
3820         (WebPlatformStrategies::createBlobRegistry):
3821
3822 2016-08-09  Anders Carlsson  <andersca@apple.com>
3823
3824         Instantiate WebKit plug-ins at layout time, instead of at style resolution time
3825         https://bugs.webkit.org/show_bug.cgi?id=160715
3826
3827         Reviewed by Tim Horton.
3828
3829         * WebCoreSupport/WebFrameLoaderClient.cpp:
3830         (WebFrameLoaderClient::objectContentType):
3831
3832 2016-08-09  Per Arne Vollan  <pvollan@apple.com>
3833
3834         [Win] Crash in MiniBrowser.
3835         https://bugs.webkit.org/show_bug.cgi?id=160686
3836
3837         Reviewed by Sam Weinig.
3838
3839         We need to specify a plugin info provider object in the page configuration.
3840
3841         * WebView.cpp:
3842         (WebView::initWithFrame):
3843
3844 2016-08-09  Anders Carlsson  <andersca@apple.com>
3845
3846         Fix build.
3847
3848         * WebCoreSupport/WebPlatformStrategies.h:
3849
3850 2016-08-09  Anders Carlsson  <andersca@apple.com>
3851
3852         Get rid of PluginStrategy
3853         https://bugs.webkit.org/show_bug.cgi?id=160696
3854
3855         Reviewed by Dan Bernstein.
3856
3857         * WebCoreSupport/WebPlatformStrategies.cpp:
3858         (WebPlatformStrategies::createPluginStrategy): Deleted.
3859
3860 2016-08-09  Anders Carlsson  <andersca@apple.com>
3861
3862         Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
3863         https://bugs.webkit.org/show_bug.cgi?id=160694
3864
3865         Reviewed by Dan Bernstein.
3866
3867         * WebCoreSupport/WebPlatformStrategies.cpp:
3868         (WebPlatformStrategies::createPluginStrategy):
3869         (WebPlatformStrategies::refreshPlugins): Deleted.
3870         (WebPlatformStrategies::getPluginInfo): Deleted.
3871         (WebPlatformStrategies::getWebVisiblePluginInfo): Deleted.
3872         * WebCoreSupport/WebPlatformStrategies.h:
3873         * WebCoreSupport/WebPluginInfoProvider.cpp:
3874         (WebPluginInfoProvider::refreshPlugins):
3875         (WebPluginInfoProvider::getPluginInfo):
3876         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3877
3878 2016-08-08  Anders Carlsson  <andersca@apple.com>
3879
3880         Add a new PluginInfoProvider class, to replace PluginStrategy
3881         https://bugs.webkit.org/show_bug.cgi?id=160670
3882
3883         Reviewed by Sam Weinig.
3884
3885         Add a new WebPluginInfoProvider - it just calls through to the plug-in strategy for now.
3886
3887         * WebCoreSupport/WebPluginInfoProvider.cpp: Added.
3888         (WebPluginInfoProvider::singleton):
3889         (WebPluginInfoProvider::WebPluginInfoProvider):
3890         (WebPluginInfoProvider::~WebPluginInfoProvider):
3891         (WebPluginInfoProvider::refreshPlugins):
3892         (WebPluginInfoProvider::getPluginInfo):
3893         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3894         * WebCoreSupport/WebPluginInfoProvider.h: Added.
3895
3896 2016-07-29  Csaba Osztrogonác  <ossy@webkit.org>
3897
3898         Remove PassRef.h after r177259
3899         https://bugs.webkit.org/show_bug.cgi?id=160348
3900
3901         Reviewed by Andreas Kling.
3902
3903         * WebCoreSupport/WebVisitedLinkStore.h:
3904
3905 2016-07-27  Alex Christensen  <achristensen@webkit.org>
3906
3907         Fix Win debug build after r203749.
3908
3909         * WebView.cpp:
3910
3911 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
3912
3913         Allow LOG macros to be used outside the namespace, and other logging cleanup
3914         https://bugs.webkit.org/show_bug.cgi?id=160216
3915
3916         Reviewed by Anders Carlsson.
3917
3918         Fix some issues with the LOG macros.
3919         
3920         First, they were not usable outside the WebKit namespace in WebKit2 code. Fix by moving
3921         its log channels outside of the namespace (they are protected by a unique prefix anyway).
3922         
3923         Second, allow LOG_WITH_STREAM to be used in WebKit2 by moving that and a helper macro
3924         into LogMacros.h, which is exported from WebCore as a private header.
3925         
3926         Third, split the Logging.h header into two. Logging.h remains for framework-internal
3927         log channels and log macros. Add LogInitialization.h which is external, and used to
3928         initialize the channels.
3929         
3930         Finally unify "initializeLogChannels" and "initializeLoggingChannels" terminology everywhere.
3931
3932         * WebKitLogging.cpp:
3933         * WebKitLogging.h:
3934         * WebView.cpp:
3935         (WebView::initWithFrame):
3936
3937 2016-07-23  Chris Dumez  <cdumez@apple.com>
3938
3939         Unreviewed, fix Windows build after r203623.
3940
3941         * DOMCoreClasses.cpp:
3942         (DOMDocument::getComputedStyle):
3943
3944 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
3945
3946         IWebView::mainFrame crashes if called after IWebView::close
3947         https://bugs.webkit.org/show_bug.cgi?id=32868
3948
3949         Reviewed by Brent Fulgham.
3950
3951         After deleting the page in WebView::close the mainframe object may be deleted. 
3952          
3953         Test: Tools/TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp (CloseThenGetMainFrame).
3954
3955         * WebView.cpp:
3956         (WebView::close): set mainframe pointer member to null. 
3957
3958 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
3959
3960         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
3961         https://bugs.webkit.org/show_bug.cgi?id=159342
3962
3963         Reviewed by Darin Adler.
3964
3965         * WebFrame.h: Link fix. 
3966
3967 2016-07-17  Sam Weinig  <sam@webkit.org>
3968
3969         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
3970         <rdar://problem/26554137>
3971         https://bugs.webkit.org/show_bug.cgi?id=159856
3972
3973         Reviewed by Dan Bernstein.
3974
3975         * Plugins/PluginView.cpp:
3976         (WebCore::PluginView::performRequest):
3977         * WebCoreSupport/WebContextMenuClient.cpp:
3978         (WebContextMenuClient::searchWithGoogle):
3979         Update for new UserGestureIndicator interface.
3980
3981 2016-07-16  Ryosuke Niwa  <rniwa@webkit.org>
3982
3983         Rename fastGetAttribute to attributeWithoutSynchronization
3984         https://bugs.webkit.org/show_bug.cgi?id=159852
3985
3986         Reviewed by Darin Adler.
3987
3988         * DOMHTMLClasses.cpp:
3989         (DOMHTMLElement::idName):
3990
3991 2016-07-15  Chris Dumez  <cdumez@apple.com>
3992
3993         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible
3994         https://bugs.webkit.org/show_bug.cgi?id=159793
3995
3996         Reviewed by Ryosuke Niwa.
3997
3998         Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible, for performance.
3999
4000         * DOMHTMLClasses.cpp:
4001         (DOMHTMLElement::idName):
4002
4003 2016-07-14  Chris Dumez  <cdumez@apple.com>
4004
4005         Use emptyString() instead of "" when possible
4006         https://bugs.webkit.org/show_bug.cgi?id=159789
4007
4008         Reviewed by Alex Christensen.
4009
4010         Use emptyString() instead of "" when possible to reduce String allocations.
4011
4012         * Plugins/PluginView.cpp:
4013         (WebCore::parseRFC822HeaderFields):
4014
4015 2016-07-14  Alex Christensen  <achristensen@webkit.org>
4016
4017         Use SocketProvider to create SocketStreamHandles
4018         https://bugs.webkit.org/show_bug.cgi?id=159774
4019
4020         Reviewed by Brady Eidson.
4021
4022         * WebSocketProvider.cpp: Removed.
4023         * WebSocketProvider.h: Removed.
4024         * WebView.cpp: Replaced WebSocketProvider with SocketProvider as we did in WebCore.
4025
4026 2016-07-14  Csaba Osztrogonác  <ossy@webkit.org>
4027
4028         Fix the !ENABLE(WEB_SOCKETS) build after r202930
4029         https://bugs.webkit.org/show_bug.cgi?id=159768
4030
4031         Reviewed by Alex Christensen.
4032
4033         * WebSocketProvider.h:
4034
4035 2016-07-11  Enrica Casucci  <enrica@apple.com>
4036
4037         Build fix.
4038
4039         Unreviewed.
4040
4041         * WebDropSource.cpp:
4042         (generateMouseEvent):
4043
4044 2016-07-11  Enrica Casucci  <enrica@apple.com>
4045
4046         Add synthetic click origin to WKNavigationAction.
4047         https://bugs.webkit.org/show_bug.cgi?id=159584
4048         rdar://problem/25610422
4049
4050         Reviewed by Tim Horton.
4051
4052         * WebDropSource.cpp:
4053         (generateMouseEvent):
4054
4055 2016-07-07  Alex Christensen  <achristensen@webkit.org>
4056
4057         Fix Windows build after r202930.
4058         https://bugs.webkit.org/show_bug.cgi?id=158776
4059
4060         * WebView.cpp:
4061         (WebView::initWithFrame):
4062
4063 2016-07-07  Alex Christensen  <achristensen@webkit.org>
4064
4065         Use SocketProvider to create WebSocketChannels
4066         https://bugs.webkit.org/show_bug.cgi?id=158776
4067
4068         Reviewed by Brent Fulgham.
4069
4070         * WebSocketProvider.cpp: Copied from Source/WebCore/Modules/websockets/ThreadableWebSocketChannel.cpp.
4071         (WebSocketProvider::createWebSocketChannel):
4072         (WebCore::ThreadableWebSocketChannel::create): Deleted.
4073         * WebSocketProvider.h:
4074
4075 2016-07-06  Per Arne Vollan  <pvollan@apple.com>
4076
4077         [Win] Add null pointer check in gesture handling.
4078         https://bugs.webkit.org/show_bug.cgi?id=159454
4079
4080         Reviewed by Brent Fulgham.
4081
4082         * WebView.cpp:
4083         (WebView::gesture):
4084
4085 2016-07-01  Per Arne Vollan  <pvollan@apple.com>
4086
4087         ASSERTION FAILED: info.bmBitsPixel == 32
4088         https://bugs.webkit.org/show_bug.cgi?id=17737
4089
4090         Reviewed by Brent Fulgham.
4091
4092         The ::SelectObject call will fail if m_backingStoreBitmap is already selected into a device context.
4093         This happens when this method is called indirectly from WebView::updateBackingStore during normal
4094         painting. There is no point continuing, since we would just be scrolling a 1x1 bitmap which is
4095         selected into the device context by default. We can just scroll by repainting the scroll rectangle.
4096
4097         * WebView.cpp:
4098         (WebView::scrollBackingStore): Invalidate the scroll rectangle if the ::SelectObject call fails.
4099
4100 2016-07-01  Youenn Fablet  <youennf@gmail.com>
4101
4102         Add a runtime flag for DOM iterators
4103         https://bugs.webkit.org/show_bug.cgi?id=159300
4104
4105         Reviewed by Alex Christensen.
4106
4107         * WebPreferenceKeysPrivate.h:
4108         * WebPreferences.cpp:
4109         (WebPreferences::domIteratorEnabled):
4110         (WebPreferences::setDOMIteratorEnabled):
4111         (WebView::notifyPreferencesChanged):
4112         * WebPreferencesreferences.h:
4113         * WebView.cpp:
4114         (WebView::notifyPreferencesChanged):
4115
4116 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
4117
4118         [Win] Custom elements tests are failing.
4119         https://bugs.webkit.org/show_bug.cgi?id=159139
4120
4121         Reviewed by Alex Christensen.
4122
4123         Add preference for enabling custom element API.
4124
4125         * Interfaces/IWebPreferencesPrivate.idl:
4126         * WebPreferenceKeysPrivate.h:
4127         * WebPreferences.cpp:
4128         (WebPreferences::initializeDefaultSettings):
4129         (WebPreferences::customElementsEnabled):
4130         (WebPreferences::setCustomElementsEnabled):
4131         * WebPreferences.h:
4132         * WebView.cpp:
4133         (WebView::notifyPreferencesChanged):
4134
4135 2016-06-23  Per Arne Vollan  <pvollan@apple.com>
4136
4137         [Win] The test accessibility/aria-labelledby-overrides-label.html is failing.
4138         https://bugs.webkit.org/show_bug.cgi?id=159057
4139
4140         Reviewed by Brent Fulgham.
4141
4142         The test expects the label to have a static text role, but currently it has a
4143         group role.
4144  
4145         * AccessibleBase.cpp:
4146         (MSAARole): Change the role of labels to static text.
4147
4148 2016-06-23  Alex Christensen  <achristensen@webkit.org>
4149
4150         Remove unused didCancelAuthenticationChallenge
4151         https://bugs.webkit.org/show_bug.cgi?id=158819
4152
4153         Reviewed by David Kilzer.
4154
4155         * WebCoreSupport/WebFrameLoaderClient.cpp:
4156         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.
4157         * WebCoreSupport/WebFrameLoaderClient.h:
4158
4159 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
4160
4161         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
4162         https://bugs.webkit.org/show_bug.cgi?id=158934
4163
4164         Reviewed by Brent Fulgham.