Pass KeyboardEvent by reference in more places
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2019-05-03  Daniel Bates  <dabates@apple.com>
2
3         Pass KeyboardEvent by reference in more places
4         https://bugs.webkit.org/show_bug.cgi?id=197480
5
6         Reviewed by Wenson Hsieh.
7
8         * WebCoreSupport/WebEditorClient.cpp:
9         (WebEditorClient::handleKeyboardEvent):
10         (WebEditorClient::handleInputMethodKeydown):
11         * WebCoreSupport/WebEditorClient.h:
12         * WebView.cpp:
13         (WebView::handleEditingKeyboardEvent):
14         * WebView.h:
15
16 2019-05-02  Frederic Wang  <fwang@igalia.com>
17
18         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
19         https://bugs.webkit.org/show_bug.cgi?id=196142
20
21         This patch introduces some experimental runtime flag to let users
22         disable MathML features that are removed from MathML Core [1]. For now,
23         these features are only disabled on GTK and WPE ports.
24
25         [1] https://mathml-refresh.github.io/mathml-core/
26
27         Reviewed by Rob Buis.
28
29         * Interfaces/IWebPreferencesPrivate.idl:
30         * WebPreferenceKeysPrivate.h:
31         * WebPreferences.cpp:
32         (WebPreferences::initializeDefaultSettings):
33         (WebPreferences::coreMathMLEnabled):
34         (WebPreferences::setCoreMathMLEnabled):
35         * WebPreferences.h:
36         * WebView.cpp:
37         (WebView::notifyPreferencesChanged):
38
39 2019-04-24  Zalan Bujtas  <zalan@apple.com>
40
41         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
42         https://bugs.webkit.org/show_bug.cgi?id=196948
43         <rdar://problem/49927131>
44
45         Reviewed by Tim Horton.
46
47         * WebCoreSupport/WebChromeClient.cpp:
48         (WebChromeClient::intrinsicContentsSizeChanged const):
49         * WebCoreSupport/WebChromeClient.h:
50
51 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
52
53         Make it possible to control the renderTreeAsText output by setting options on testRunner
54         https://bugs.webkit.org/show_bug.cgi?id=197133
55
56         Reviewed by Sam Weinig.
57
58         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
59         that make sense in testing (those that don't dump unstable data like addresses), and plumb
60         these flags through the various framework layers.
61
62         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
63
64         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
65         and hand-code DumpRenderTree bindings.
66
67         Some cleanup of the TestRunners, using member initializers.
68
69         * Interfaces/IWebFramePrivate.idl:
70         * WebFrame.cpp:
71         (toRenderAsTextFlags):
72         (WebFrame::renderTreeAsExternalRepresentation):
73         (WebFrame::renderTreeAsExternalRepresentationForPrinting):
74         * WebFrame.h:
75
76 2019-04-23  Chris Dumez  <cdumez@apple.com>
77
78         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
79         https://bugs.webkit.org/show_bug.cgi?id=197097
80         <rdar://problem/50048318>
81
82         Reviewed by Alex Christensen.
83
84         * WebCoreSupport/WebFrameLoaderClient.cpp:
85         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
86         * WebCoreSupport/WebFrameLoaderClient.h:
87
88 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
89
90         [CMake][Win] Use target oriented design for WebKitLegacy
91         https://bugs.webkit.org/show_bug.cgi?id=197112
92
93         Reviewed by Konstantin Tokarev.
94
95         Fix an include directory.
96
97         * WebKitQuartzCoreAdditions/CMakeLists.txt:
98
99 2019-04-18  Jer Noble  <jer.noble@apple.com>
100
101         Refactoring: Pull all fullscreen code out of Document and into its own helper class
102         https://bugs.webkit.org/show_bug.cgi?id=197017
103
104         Reviewed by Eric Carlson.
105
106         * WebCoreSupport/WebChromeClient.cpp:
107         (WebChromeClient::createWindow):
108         * WebView.cpp:
109         (WebView::fullScreenClientWillEnterFullScreen):
110         (WebView::fullScreenClientDidEnterFullScreen):
111         (WebView::fullScreenClientWillExitFullScreen):
112         (WebView::fullScreenClientDidExitFullScreen):
113
114 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
115
116         requestAnimationFrame should execute before the next frame
117         https://bugs.webkit.org/show_bug.cgi?id=177484
118
119         Reviewed by Simon Fraser.
120
121         * WebView.cpp:
122         (WebView::updateBackingStore):
123         (WebView::flushPendingGraphicsLayerChangesSoon):
124         (WebView::flushPendingGraphicsLayerChanges):
125         Call Page::updateRendering() which implements "Update the rendering"
126         step of the HTML Event Loop specification.
127
128 2019-04-10  Devin Rousso  <drousso@apple.com>
129
130         Web Inspector: save sheet should be anchored underneath the tab bar when detached
131         https://bugs.webkit.org/show_bug.cgi?id=196722
132         <rdar://problem/49613280>
133
134         Reviewed by Timothy Hatcher.
135
136         * WebCoreSupport/WebInspectorClient.h:
137         * WebCoreSupport/WebInspectorClient.cpp:
138         (WebInspectorFrontendClient::setSheetRect): Added.
139
140 2019-04-10  Alex Christensen  <achristensen@webkit.org>
141
142         Add SPI WKNavigationResponse._downloadAttribute
143         https://bugs.webkit.org/show_bug.cgi?id=196755
144         <rdar://49587365>
145
146         Reviewed by Brady Eidson.
147
148         * WebCoreSupport/WebFrameLoaderClient.cpp:
149         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
150         * WebCoreSupport/WebFrameLoaderClient.h:
151
152 2019-04-05  Commit Queue  <commit-queue@webkit.org>
153
154         Unreviewed, rolling out r243833.
155         https://bugs.webkit.org/show_bug.cgi?id=196645
156
157         This change breaks build of WPE and GTK ports (Requested by
158         annulen on #webkit).
159
160         Reverted changeset:
161
162         "[CMake][WTF] Mirror XCode header directories"
163         https://bugs.webkit.org/show_bug.cgi?id=191662
164         https://trac.webkit.org/changeset/243833
165
166 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
167
168         [CMake][WTF] Mirror XCode header directories
169         https://bugs.webkit.org/show_bug.cgi?id=191662
170
171         Reviewed by Konstantin Tokarev.
172
173         * WebKitQuartzCoreAdditions/CMakeLists.txt:
174
175 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
176
177         Implement ResizeObserver.
178         https://bugs.webkit.org/show_bug.cgi?id=157743
179
180         Reviewed by Simon Fraser.
181
182         * Interfaces/IWebPreferencesPrivate.idl:
183         * WebPreferenceKeysPrivate.h:
184         * WebPreferences.cpp:
185         (WebPreferences::initializeDefaultSettings):
186         (WebPreferences::resizeObserverEnabled):
187         (WebPreferences::setResizeObserverEnabled):
188         * WebPreferences.h:
189         * WebView.cpp:
190         (WebView::notifyPreferencesChanged):
191
192 2019-03-17  Fujii Hironori  <Hironori.Fujii@sony.com>
193
194         [Win][WK1] Null dereference in WebFrameNetworkingContext::storageSession
195         https://bugs.webkit.org/show_bug.cgi?id=195741
196
197         Reviewed by Ross Kirsling.
198
199         * WebCoreSupport/WebFrameNetworkingContext.cpp:
200         (WebFrameNetworkingContext::storageSession const): Added a null check of frame()->page() as well as Mac port does (Bug 183455).
201
202 2019-03-13  Ryan Haddad  <ryanhaddad@apple.com>
203
204         Unreviewed attempt to fix the Windows build after r242920.
205
206         * WebCoreSupport/WebFrameLoaderClient.h:
207
208 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
209
210         [Win] Fix a slew of simple clang-cl warnings.
211         https://bugs.webkit.org/show_bug.cgi?id=195652
212
213         Reviewed by Don Olmstead.
214
215         * Interfaces/AccessibleComparable.idl: -Wmissing-braces
216         * Plugins/PluginDatabaseWin.cpp: -Wunused-function
217         (WebCore::addJavaPluginDirectory): Deleted.
218         * WebCoreSupport/AcceleratedCompositingContext.cpp:
219         (AcceleratedCompositingContext::AcceleratedCompositingContext): -Wreorder
220         * WebCoreSupport/WebEditorClient.cpp:
221         (WebEditorUndoCommand::WebEditorUndoCommand): -Wreorder
222         (undoNameForEditAction): -Wswitch
223         * WebCoreSupport/WebFrameLoaderClient.cpp:
224         (WebFrameLoaderClient::WebFrameLoaderClient): -Wswitch
225         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): -Wunused-variable
226         * WebCoreSupport/WebInspectorClient.cpp:
227         (WebInspectorFrontendClient::WebInspectorFrontendClient): -Wreorder
228         * WebCoreSupport/WebInspectorClient.h: -Winconsistent-missing-override
229         * WebError.cpp:
230         (WebError::WebError): -Wreorder
231         * WebFrame.cpp:
232         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): -Wlogical-op-parentheses
233         * WebHistory.cpp: -Wunused-function (x5)
234         (areEqualOrClose): Deleted.
235         (addDayToSystemTime): Deleted.
236         (getDayBoundaries): Deleted.
237         (beginningOfDay): Deleted.
238         (dateKey): Deleted.
239         * WebNotificationCenter.cpp:
240         (WebNotificationCenter::removeObserver): -Wunused-variable
241         * WebView.cpp: -Wunused-function, -Wreorder
242         (WebView::addVisitedLinks): -Wunused-variable
243
244 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
245
246         Unreviewed, rolling out r242688, r242643, r242624.
247
248         Caused multiple layout test failures and crashes on iOS and macOS.
249
250         Reverted changeset:
251
252         "requestAnimationFrame should execute before the next frame"
253         https://bugs.webkit.org/show_bug.cgi?id=177484
254         https://trac.webkit.org/changeset/242624/webkit
255
256         * WebView.cpp:
257         (WebView::updateBackingStore):
258         (WebView::flushPendingGraphicsLayerChangesSoon):
259         (WebView::flushPendingGraphicsLayerChanges):
260
261 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
262
263         requestAnimationFrame should execute before the next frame
264         https://bugs.webkit.org/show_bug.cgi?id=177484
265
266         Reviewed by Simon Fraser.
267
268         * WebView.cpp:
269         (WebView::updateBackingStore):
270         (WebView::flushPendingGraphicsLayerChangesSoon):
271         (WebView::flushPendingGraphicsLayerChanges):
272         Call Page::renderingUpdate() which implements  "Update the rendering"
273         step of the HTML Event Loop specification.
274
275 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
276
277         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
278         https://bugs.webkit.org/show_bug.cgi?id=195346
279
280         Reviewed by Fujii Hironori.
281
282         * COMPropertyBag.h:
283         (HashType>::GetPropertyInfo):
284         (HashType>::LoadObject):
285         * DOMCoreClasses.cpp:
286         (DOMNode::addEventListener):
287         (DOMNode::removeEventListener):
288         (DOMWindow::addEventListener):
289         (DOMWindow::removeEventListener):
290         (DOMElement::font):
291         * DOMHTMLClasses.cpp:
292         (DOMHTMLInputElement::setValueForUser):
293         (DOMHTMLInputElement::replaceCharactersInRange):
294         * Plugins/PluginDatabaseWin.cpp:
295         (WebCore::addPluginPathsFromRegistry):
296         (WebCore::PluginDatabase::getPluginPathsInDirectories const):
297         (WebCore::addMozillaPluginDirectories):
298         (WebCore::addWindowsMediaPlayerPluginDirectory):
299         (WebCore::addAdobeAcrobatPluginDirectory):
300         (WebCore::addJavaPluginDirectory):
301         (WebCore::safariPluginsDirectory):
302         (WebCore::addMacromediaPluginDirectories):
303         * Plugins/PluginPackageWin.cpp:
304         (WebCore::getVersionInfo):
305         (WebCore::PluginPackage::fetchInfo):
306         (WebCore::PluginPackage::load):
307         * Plugins/PluginViewWin.cpp:
308         (WebCore::PluginView::handlePostReadFile):
309         * WebCoreSupport/WebChromeClient.cpp:
310         (WebChromeClient::runOpenPanel):
311         * WebCoreSupport/WebEditorClient.cpp:
312         (WebEditorClient::checkSpellingOfString):
313         (WebEditorClient::checkGrammarOfString):
314         * WebCoreSupport/WebInspectorClient.cpp:
315         (WebInspectorFrontendClient::updateWindowTitle):
316         * WebLocalizableStrings.cpp:
317         (LocalizedString::operator LPCTSTR const):
318         * WebView.cpp:
319         (createContextMenuFromItems):
320         (WebView::setToolTip):
321         Use wchar helpers as needed.
322
323 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
324
325         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
326         https://bugs.webkit.org/show_bug.cgi?id=195053
327         <rdar://problem/48134710>
328
329         Reviewed by Ryosuke Niwa.
330
331         * WebCoreSupport/WebEditorClient.h:
332
333 2019-02-20  Darin Adler  <darin@apple.com>
334
335         Finish removing String::format
336         https://bugs.webkit.org/show_bug.cgi?id=194893
337
338         Reviewed by Daniel Bates.
339
340         * FullscreenVideoController.cpp:
341         (timeToString): Use makeString and pad.
342
343 2019-02-27  Simon Fraser  <simon.fraser@apple.com>
344
345         Roll out r242014; it caused crashes in compositing logging (webkit.org/b/195141)
346
347         * FullscreenVideoController.cpp:
348         (timeToString):
349
350 2019-02-26  Philippe Normand  <pnormand@igalia.com>
351
352         [WPE] Add API for webview background color configuration
353         https://bugs.webkit.org/show_bug.cgi?id=192305
354
355         Reviewed by Michael Catanzaro.
356
357         * WebCoreSupport/WebFrameLoaderClient.cpp:
358         (WebFrameLoaderClient::transitionToCommittedForNewPage): Create
359         FrameView with background color.
360
361 2019-02-20  Darin Adler  <darin@apple.com>
362
363         Finish removing String::format
364         https://bugs.webkit.org/show_bug.cgi?id=194893
365
366         Reviewed by Daniel Bates.
367
368         * FullscreenVideoController.cpp:
369         (timeToString): Use makeString and pad.
370
371 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
372
373         Input type "formatSetInlineTextDirection" is dispatched when changing paragraph-level text direction
374         https://bugs.webkit.org/show_bug.cgi?id=194703
375         <rdar://problem/48111775>
376
377         Reviewed by Ryosuke Niwa.
378
379         * WebCoreSupport/WebEditorClient.cpp:
380         (undoNameForEditAction):
381
382 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
383
384         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
385         https://bugs.webkit.org/show_bug.cgi?id=194670
386         <rdar://problem/39066529>
387
388         Reviewed by Tim Horton.
389
390         * WebCoreSupport/WebEditorClient.cpp:
391         (WebEditorClient::replacementURLForResource): Deleted.
392         * WebCoreSupport/WebEditorClient.h:
393
394 2019-02-10  Darin Adler  <darin@apple.com>
395
396         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
397         https://bugs.webkit.org/show_bug.cgi?id=194487
398
399         Reviewed by Daniel Bates.
400
401         * WebView.cpp:
402         (webKitVersionString): Use makeString instead of String::format.
403
404 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
405
406         Allow pages to trigger programmatic paste from script on iOS
407         https://bugs.webkit.org/show_bug.cgi?id=194271
408         <rdar://problem/47808810>
409
410         Reviewed by Ryosuke Niwa.
411
412         * WebCoreSupport/WebEditorClient.h:
413
414 2019-02-06  Daniel Bates  <dabates@apple.com>
415
416         Standardize on ControlKey instead of CtrlKey
417         https://bugs.webkit.org/show_bug.cgi?id=194317
418
419         Reviewed by Tim Horton.
420
421         * AccessibleBase.cpp:
422         (AccessibleBase::get_accKeyboardShortcut):
423         * WebView.cpp:
424         (WebView::keyDown):
425
426 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
427
428         PageOverlayController's layers should be created lazily
429         https://bugs.webkit.org/show_bug.cgi?id=194199
430         rdar://problem/46571593
431
432         Reviewed by Tim Horton.
433
434         Expose PageOverlayController::hasDocumentOverlays() and hasViewOverlays()
435         and use them to only parent the overlay-hosting layers when necessary.
436
437         For document overlays, RenderLayerCompositor::appendDocumentOverlayLayers() can
438         simply do nothing if there are none. Updates are triggered via Page::installedPageOverlaysChanged(),
439         which calls FrameView::setNeedsCompositingConfigurationUpdate() to trigger the root layer
440         compositing updates that parents the layerWithDocumentOverlays().
441
442         View overlays are added to the layer tree via the DrawingArea. When we go between having
443         none and some view overlays, Page::installedPageOverlaysChanged() calls attachViewOverlayGraphicsLayer()
444         on the ChromeClient, and the DrawingArea responds by calling updateRootLayers() and scheduling a
445         compositing flush (this has to be done manually because view overlay layers are outside the
446         subtree managed by RenderLayerCompositor).
447         
448         Now that GraphicsLayers are ref-counted, we can let the DrawingArea simply retain its m_viewOverlayRootLayer;
449         there is no need for RenderLayerCompositor::attachRootLayer()/detachRootLayer() to do anything with view
450         overlay layers. This implies that a page can navigate (new FrameView) and view overlays will persist, without
451         having to be manually removed and re-added. We can also remove the Frame argument to attachViewOverlayGraphicsLayer().
452
453         * WebCoreSupport/WebChromeClient.cpp:
454         (WebChromeClient::attachViewOverlayGraphicsLayer):
455         * WebCoreSupport/WebChromeClient.h:
456
457 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
458
459         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
460         https://bugs.webkit.org/show_bug.cgi?id=194189
461
462         Reviewed by Geoffrey Garen.
463
464         Pass the policy check identifier around functions and store it in WebFramePolicyListener
465         so that we can send it back to WebCore with the navigation policy decision.
466
467         * WebCoreSupport/WebFrameLoaderClient.cpp:
468         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
469         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
470         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
471         (WebFrameLoaderClient::dispatchWillSubmitForm):
472         (WebFrameLoaderClient::setUpPolicyListener):
473         * WebCoreSupport/WebFrameLoaderClient.h:
474
475 2019-01-31  Alex Christensen  <achristensen@webkit.org>
476
477         Revert r238819 which is unneeded and caused a performance regression.
478         https://bugs.webkit.org/show_bug.cgi?id=192272
479         <rdar://problem/46664625>
480
481         * WebCoreSupport/WebFrameLoaderClient.cpp:
482         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
483         * WebCoreSupport/WebFrameLoaderClient.h:
484
485 2019-01-31  Takashi Komori  <Takashi.Komori@sony.com>
486
487         [Curl] Fix DRT crash related to private browsing.
488         https://bugs.webkit.org/show_bug.cgi?id=193816
489
490         Reviewed by Alex Christensen.
491
492         * WebCoreSupport/WebFrameNetworkingContext.cpp:
493         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
494
495 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
496
497         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
498         https://bugs.webkit.org/show_bug.cgi?id=193941
499
500         Reviewed by Alex Christensen.
501
502         * Plugins/PluginMessageThrottlerWin.cpp:
503         * Plugins/PluginView.cpp:
504         * Plugins/PluginViewWin.cpp:
505
506 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
507
508         Move FileSystem to WTF
509         https://bugs.webkit.org/show_bug.cgi?id=193602
510
511         Reviewed by Yusuke Suzuki.
512
513         * Plugins/PluginDatabase.cpp:
514         * Plugins/PluginPackage.h:
515         * Plugins/PluginStream.h:
516         * WebApplicationCache.cpp:
517         * WebDatabaseManager.cpp:
518         * WebDownloadCurl.cpp:
519         * WebPreferences.cpp:
520         * WebView.cpp:
521
522 2019-01-22  Alex Christensen  <achristensen@webkit.org>
523
524         Move NetworkStorageSession ownership to NetworkProcess
525         https://bugs.webkit.org/show_bug.cgi?id=193580
526
527         Reviewed by Geoff Garen.
528
529         * WebCoreSupport/WebFrameNetworkingContext.cpp:
530         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
531         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
532         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
533         (WebFrameNetworkingContext::storageSession const):
534         * WebDownloadCFNet.cpp:
535         (WebDownload::didReceiveAuthenticationChallenge):
536         * WebPreferences.cpp:
537         (WebPreferences::clearNetworkLoaderSession):
538         (WebPreferences::switchNetworkLoaderToNewTestingSession):
539
540 2019-01-15  Darin Adler  <darin@apple.com>
541
542         Use references rather than pointers for register/unregister functions, and more
543         https://bugs.webkit.org/show_bug.cgi?id=175028
544
545         Reviewed by Daniel Bates.
546
547         * Plugins/PluginView.cpp:
548         (WebCore::PluginView::startOrAddToUnstartedList): Pass a reference.
549         (WebCore::PluginView::~PluginView): Ditto.
550         * WebView.cpp:
551         (WebView::fullScreenClientWillEnterFullScreen): Ditto.
552         (WebView::fullScreenClientDidEnterFullScreen): Ditto.
553         (WebView::fullScreenClientDidExitFullScreen): Ditto.
554
555 2019-01-17  Per Arne Vollan  <pvollan@apple.com>
556
557         [Win][HighDPI] Repaint glitches when scrolling.
558         https://bugs.webkit.org/show_bug.cgi?id=173152
559         <rdar://problem/45269953>
560
561         Reviewed by Brent Fulgham.
562
563         Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
564         delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
565         Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
566
567         * WebView.cpp:
568         (WebView::scrollBackingStore):
569
570 2019-01-17  Alex Christensen  <achristensen@webkit.org>
571
572         Stop using NetworkStorageSession::storageSession in WebCore
573         https://bugs.webkit.org/show_bug.cgi?id=193529
574
575         Reviewed by Tim Horton.
576
577         * WebView.cpp:
578         (WebView::initWithFrame):
579
580 2019-01-15  Alex Christensen  <achristensen@webkit.org>
581
582         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
583         https://bugs.webkit.org/show_bug.cgi?id=193368
584
585         Reviewed by Geoff Garen.
586
587         * WebDownloadCFNet.cpp:
588         (WebDownload::didReceiveAuthenticationChallenge):
589
590 2019-01-15  Alex Christensen  <achristensen@webkit.org>
591
592         Fix Windows build after r240014
593         https://bugs.webkit.org/show_bug.cgi?id=161106
594
595         * WebView.cpp:
596
597 2019-01-15  Alex Christensen  <achristensen@webkit.org>
598
599         Stop using CookiesStrategy
600         https://bugs.webkit.org/show_bug.cgi?id=161106
601
602         Reviewed by Don Olmstead and Antti Koivisto.
603
604         * Plugins/PluginView.cpp:
605         (WebCore::PluginView::getValueForURL):
606         (WebCore::PluginView::setValueForURL):
607         * WebCoreSupport/WebPlatformStrategies.cpp:
608         (WebPlatformStrategies::createBlobRegistry):
609         (WebPlatformStrategies::createCookiesStrategy): Deleted.
610         (WebPlatformStrategies::cookiesForDOM): Deleted.
611         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
612         (WebPlatformStrategies::cookiesEnabled): Deleted.
613         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
614         (WebPlatformStrategies::getRawCookies): Deleted.
615         (WebPlatformStrategies::deleteCookie): Deleted.
616         * WebCoreSupport/WebPlatformStrategies.h:
617         * WebView.cpp:
618         (WebView::initWithFrame):
619
620 2019-01-08  Alex Christensen  <achristensen@webkit.org>
621
622         Stop using NetworkStorageSession in WebProcess
623         https://bugs.webkit.org/show_bug.cgi?id=193236
624
625         Reviewed by Don Olmstead.
626
627         * WebCoreSupport/WebFrameNetworkingContext.cpp:
628         (WebFrameNetworkingContext::storageSession const):
629         * WebCoreSupport/WebFrameNetworkingContext.h:
630         * WebCoreSupport/WebPlatformStrategies.cpp:
631         (WebPlatformStrategies::cookiesForDOM):
632         (WebPlatformStrategies::setCookiesFromDOM):
633         (WebPlatformStrategies::cookiesEnabled):
634         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
635         (WebPlatformStrategies::getRawCookies):
636         (WebPlatformStrategies::deleteCookie):
637         * WebCoreSupport/WebPlatformStrategies.h:
638
639 2019-01-08  Alex Christensen  <achristensen@webkit.org>
640
641         Unreviewed, rolling out r239727.
642
643         Broke API tests
644
645         Reverted changeset:
646
647         "Stop using NetworkStorageSession in WebProcess"
648         https://bugs.webkit.org/show_bug.cgi?id=193236
649         https://trac.webkit.org/changeset/239727
650
651 2018-12-24  Fujii Hironori  <Hironori.Fujii@sony.com>
652
653         Remove "using namespace std;"
654         https://bugs.webkit.org/show_bug.cgi?id=192973
655
656         Reviewed by Alex Christensen.
657
658         * FullscreenVideoController.cpp:
659         * WebFrame.cpp:
660         (WebFrame::drawFooter):
661         * WebHistory.cpp:
662         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
663         * WebKitQuartzCoreAdditions/CAView.cpp:
664         * WebView.cpp:
665         (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
666         (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
667         (WebView::setCacheModel):
668         (WebView::maxCacheModelInAnyInstance):
669
670 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
671
672         Use Ref<> as much as possible
673         https://bugs.webkit.org/show_bug.cgi?id=192808
674
675         Reviewed by Alex Christensen.
676
677         * Plugins/PluginDatabase.cpp:
678         (WebCore::PluginDatabase::refresh):
679         * Plugins/PluginView.cpp:
680         (WebCore::PluginView::mediaCanStart):
681         (WebCore::PluginView::performRequest):
682         (WebCore::PluginView::bindingInstance):
683         * Plugins/PluginView.h:
684         * WebCoreSupport/WebFrameLoaderClient.cpp:
685         (WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
686         (WebFrameLoaderClient::createPlugin):
687         (WebFrameLoaderClient::createJavaAppletWidget):
688         * WebCoreSupport/WebFrameLoaderClient.h:
689         * WebFrame.cpp:
690         (WebFrame::loadData):
691         (WebFrame::loadPlainTextString):
692         (WebFrame::loadHTMLString):
693         * WebFrame.h:
694         * WebKitQuartzCoreAdditions/CAView.cpp:
695         (WKQCA::CAView::create):
696         * WebKitQuartzCoreAdditions/CAView.h:
697         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
698         (WKQCA::CVDisplayLink::create):
699         * WebKitQuartzCoreAdditions/CVDisplayLink.h:
700         * WebKitQuartzCoreAdditions/ImageConversion.cpp:
701         (WKQCA::getImageCopy):
702         * WebView.cpp:
703         (WebView::addUserScriptToGroup):
704         (WebView::addUserStyleSheetToGroup):
705
706 2018-12-20  Chris Dumez  <cdumez@apple.com>
707
708         Use Optional::valueOr() instead of Optional::value_or()
709         https://bugs.webkit.org/show_bug.cgi?id=192933
710
711         Reviewed by Geoffrey Garen.
712
713         * WebSecurityOrigin.cpp:
714         (WebSecurityOrigin::port):
715
716 2018-12-19  Chris Dumez  <cdumez@apple.com>
717
718         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
719         https://bugs.webkit.org/show_bug.cgi?id=192728
720         <rdar://problem/46746779>
721
722         Reviewed by Geoff Garen.
723
724         * Plugins/*:
725         * WebCoreSupport/*:
726
727 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
728
729         [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag
730         https://bugs.webkit.org/show_bug.cgi?id=192617
731
732         Reviewed by Alex Christensen.
733
734         * COMEnumVariant.h:
735         (COMEnumVariant<ContainerType>::adopt): Removed 'typename' from non dependent names.
736         (COMEnumVariant<ContainerType>::createInstance): Ditto.
737         (COMEnumVariant<ContainerType>::Next): Prepend 'typename' for dependent names.
738         * COMPropertyBag.h:
739         (HashType>::createInstance): Removed 'typename' from non dependent names.
740         (HashType>::adopt): Ditto.
741         (HashType>::Read): Replaced dependent name 'HashMapType::const_iterator' with 'auto'.
742         (HashType>::GetPropertyInfo): Ditto.
743
744 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
745
746         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
747         https://bugs.webkit.org/show_bug.cgi?id=192618
748
749         Reviewed by Alex Christensen.
750
751         Classes which implement COM interface usually doesn't need the
752         virtual destructor because it has Release() virtual method to
753         destruct itself.
754
755         Marked 'final' such classes to suppress clang-cl's compilation
756         warnings.
757
758         * COMEnumVariant.h:
759         * COMPropertyBag.h:
760         * DefaultDownloadDelegate.h:
761         * DefaultPolicyDelegate.h:
762         * MemoryStream.h:
763         * WebActionPropertyBag.h:
764         * WebApplicationCache.h:
765         * WebArchive.h:
766         * WebBackForwardList.h:
767         * WebCache.h:
768         * WebCoreStatistics.h:
769         * WebCoreSupport/WebEditorClient.cpp:
770         * WebCoreSupport/WebInspectorDelegate.h:
771         * WebDataSource.h:
772         * WebDatabaseManager.cpp:
773         * WebDatabaseManager.h:
774         * WebDownload.h:
775         * WebDropSource.h:
776         * WebElementPropertyBag.h:
777         * WebError.h:
778         * WebFrame.cpp:
779         * WebFrame.h:
780         * WebFramePolicyListener.h:
781         * WebGeolocationPolicyListener.h:
782         * WebGeolocationPosition.h:
783         * WebHTMLRepresentation.h:
784         * WebHistory.h:
785         * WebHistoryItem.h:
786         * WebInspector.h:
787         * WebJavaScriptCollector.h:
788         * WebKitClassFactory.h:
789         * WebKitMessageLoop.h:
790         * WebKitStatistics.h:
791         * WebMutableURLRequest.h:
792         * WebNavigationData.h:
793         * WebNotification.h:
794         * WebNotificationCenter.h:
795         * WebPreferences.h:
796         * WebResource.h:
797         * WebScriptWorld.h:
798         * WebSecurityOrigin.h:
799         * WebSerializedJSValue.h:
800         * WebTextRenderer.h:
801         * WebURLAuthenticationChallenge.h:
802         * WebURLAuthenticationChallengeSender.h:
803         * WebURLCredential.h:
804         * WebURLProtectionSpace.h:
805         * WebURLResponse.h:
806         * WebUserContentURLPattern.h:
807         * WebView.cpp:
808         * WebView.h:
809         * WebWorkersPrivate.h:
810
811 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
812
813         [Win][Clang] Fix warning -Wmissing-field-initializers
814         https://bugs.webkit.org/show_bug.cgi?id=192584
815
816         Reviewed by Yusuke Suzuki.
817
818         Initialize a struct with '{ }' instead of '= {0}'.
819
820         * WebKitMessageLoop.cpp:
821         (WebKitMessageLoop::run):
822         * WebView.cpp:
823         (WebView::onMenuCommand):
824         (WebView::gesture):
825         (WebView::setShouldInvertColors):
826         (WebView::initializeToolTipWindow):
827         (WebView::setToolTip):
828         (WebView::fullScreenClientForceRepaint):
829
830 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
831
832         Turn WritingDirection into an enum class
833         https://bugs.webkit.org/show_bug.cgi?id=192401
834         Work towards <rdar://problem/42075638>
835
836         Reviewed by Dan Bernstein.
837
838         Change WritingDirection from an enum to an enum class. No change in behavior.
839
840         * WebFrame.cpp:
841         (WebFrame::setTextDirection):
842
843 2018-12-03  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
844
845         Use WallTime for file time
846         https://bugs.webkit.org/show_bug.cgi?id=192287
847
848         Reviewed by Darin Adler.
849
850         * Plugins/PluginDatabase.cpp:
851         (WebCore::PluginDatabase::refresh):
852
853 2018-11-30  Alex Christensen  <achristensen@webkit.org>
854
855         Fix Windows build.
856
857         * WebView.cpp:
858
859 2018-11-30  Alex Christensen  <achristensen@webkit.org>
860
861         Fix Windows build.
862
863         * WebCoreSupport/WebFrameLoaderClient.h:
864
865 2018-11-30  Alex Christensen  <achristensen@webkit.org>
866
867         Fix Windows build.
868
869         * WebCoreSupport/WebFrameLoaderClient.h:
870
871 2018-11-30  Alex Christensen  <achristensen@webkit.org>
872
873         Move URL from WebCore to WTF
874         https://bugs.webkit.org/show_bug.cgi?id=190234
875
876         Reviewed by Keith Miller.
877
878         * MarshallingHelpers.cpp:
879         * MarshallingHelpers.h:
880         * Plugins/PluginDatabase.cpp:
881         * Plugins/PluginDatabase.h:
882         * Plugins/PluginDatabaseWin.cpp:
883         * Plugins/PluginStream.h:
884         * Plugins/PluginView.h:
885         * WebCoreSupport/WebContextMenuClient.h:
886         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
887         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
888         * WebCoreSupport/WebFrameLoaderClient.h:
889         * WebCoreSupport/WebPlatformStrategies.h:
890         * WebCoreSupport/WebPluginInfoProvider.cpp:
891         (WebPluginInfoProvider::webVisiblePluginInfo):
892         * WebCoreSupport/WebPluginInfoProvider.h:
893         * WebCoreSupport/WebVisitedLinkStore.h:
894         * WebDataSource.cpp:
895         * WebDownload.h:
896         * WebElementPropertyBag.cpp:
897         * WebFrame.h:
898         * WebHistory.cpp:
899         * WebHistory.h:
900         * WebHistoryItem.cpp:
901         * WebResource.cpp:
902         (WebResource::WebResource):
903         * WebResource.h:
904         * WebSecurityOrigin.cpp:
905         * WebURLResponse.cpp:
906         (WebURLResponse::createInstance):
907         * WebUserContentURLPattern.cpp:
908         * WebView.h:
909
910 2018-11-28  Alex Christensen  <achristensen@webkit.org>
911
912         Remove dead code from an earlier attempt at implementing safe browsing
913         https://bugs.webkit.org/show_bug.cgi?id=192067
914
915         Reviewed by Chris Dumez.
916
917         * WebCoreSupport/WebFrameLoaderClient.cpp:
918         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
919         * WebCoreSupport/WebFrameLoaderClient.h:
920
921 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
922
923         [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
924         https://bugs.webkit.org/show_bug.cgi?id=191959
925
926         Reviewed by Alex Christensen.
927
928         * MarshallingHelpers.h: Removed extra "MarshallingHelpers::" of windowsEpochAbsoluteTime declaration.
929
930 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
931
932         [Win] Reduce the use of WKSI library calls: CoreAnimation
933         https://bugs.webkit.org/show_bug.cgi?id=191777
934         <rdar://problem/46140542>
935
936         Reviewed by Zalan Bujtas.
937
938         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
939         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
940         directives for WebKitSystemInterface.lib.
941
942         * FullscreenVideoController.cpp:
943         * WebKitGraphics.cpp:
944         * WebPreferences.cpp:
945
946 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
947
948         Address post-review feedback after r238438
949         https://bugs.webkit.org/show_bug.cgi?id=191913
950
951         Reviewed by Ryosuke Niwa.
952
953         * AccessibleTextImpl.cpp:
954         (AccessibleText::replaceText):
955
956 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
957
958         Web Inspector: "Reload Web Inspector" button no longer partially works
959         https://bugs.webkit.org/show_bug.cgi?id=191773
960         <rdar://problem/46139932>
961
962         Reviewed by Devin Rousso.
963
964         * WebCoreSupport/WebInspectorClient.cpp:
965         (WebInspectorFrontendClient::reopen):
966         * WebCoreSupport/WebInspectorClient.h:
967
968 2018-11-17  Devin Rousso  <drousso@apple.com>
969
970         Web Inspector: Network: add button to show system certificate dialog
971         https://bugs.webkit.org/show_bug.cgi?id=191458
972         <rdar://problem/45977019>
973
974         Reviewed by Joseph Pecoraro.
975
976         * WebCoreSupport/WebInspectorClient.h:
977         * WebCoreSupport/WebInspectorClient.cpp:
978         (WebInspectorFrontendClient::showCertificate): Added.
979
980 2018-11-16  Brent Fulgham  <bfulgham@apple.com>
981
982         [Win] Reduce the use of WKSI library calls: CFNetwork
983         https://bugs.webkit.org/show_bug.cgi?id=191718
984         <rdar://problem/46108732>
985
986         Reviewed by Alex Christensen.
987
988         Remove custom WKSI CFNetwork calls, since the SPI is already documented in PAL. Just
989         make the same calls on Windows, like we did for iOS and macOS back in 2017.
990
991         * WebCache.cpp:
992         (WebCache::cacheFolder):
993         * WebCoreSupport/WebFrameNetworkingContext.cpp:
994         * WebCoreSupport/WebPlatformStrategies.cpp:
995         * WebError.cpp:
996         (WebError::localizedDescription):
997         (WebError::sslPeerCertificate):
998         * WebURLResponse.cpp:
999         (WebURLResponse::sslPeerCertificate):
1000         (WebURLResponse::certificateDictionary const):
1001         * WebView.cpp:
1002         (WebView::setCacheModel):
1003
1004 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
1005
1006         [Win] Reduce the use of WKSI library calls: Font Handling
1007         https://bugs.webkit.org/show_bug.cgi?id=191701
1008         <rdar://problem/46104809>
1009
1010         Reviewed by Myles C. Maxfield.
1011
1012         Update to use the old font handling routines moved from WKSI to FontCascade.
1013
1014         * WebPreferences.cpp:
1015         (WebPreferences::setFontSmoothing):
1016         (WebPreferences::setFontSmoothingContrast):
1017         * WebView.cpp:
1018         (systemParameterChanged):
1019
1020 2018-11-14  Timothy Hatcher  <timothy@apple.com>
1021
1022         Default the view background color and text color to different values when in dark mode.
1023         https://bugs.webkit.org/show_bug.cgi?id=191607
1024         rdar://problem/46045854
1025
1026         Reviewed by Dean Jackson.
1027
1028         * WebFrame.cpp:
1029         (WebFrame::updateBackground): Drop backgroundColor.
1030         * WebCoreSupport/WebFrameLoaderClient.cpp:
1031         (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor.
1032
1033 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1034
1035         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1036         https://bugs.webkit.org/show_bug.cgi?id=191612
1037
1038         Reviewed by Matt Baker.
1039
1040         * WebCoreSupport/WebInspectorClient.cpp:
1041         (WebInspectorFrontendClient::destroyInspectorView):
1042
1043 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
1044
1045         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
1046         https://bugs.webkit.org/show_bug.cgi?id=189230
1047         <rdar://problem/44050379>
1048
1049         Reviewed by Joseph Pecoraro.
1050
1051         Runs all png images through zopflipng. This results in a smaller file
1052         size and takes care of this issue as a byproduct.
1053
1054         * WebKit.resources/deleteButton.png:
1055         * WebKit.resources/deleteButtonPressed.png:
1056         * WebKit.resources/fsVideoAudioVolumeHigh.png:
1057         * WebKit.resources/fsVideoAudioVolumeLow.png:
1058         * WebKit.resources/fsVideoExitFullscreen.png:
1059         * WebKit.resources/fsVideoPause.png:
1060         * WebKit.resources/fsVideoPlay.png:
1061         * WebKit.resources/missingImage.png:
1062         * WebKit.resources/nullplugin.png:
1063         * WebKit.resources/panEastCursor.png:
1064         * WebKit.resources/panIcon.png:
1065         * WebKit.resources/panNorthCursor.png:
1066         * WebKit.resources/panNorthEastCursor.png:
1067         * WebKit.resources/panNorthWestCursor.png:
1068         * WebKit.resources/panSouthCursor.png:
1069         * WebKit.resources/panSouthEastCursor.png:
1070         * WebKit.resources/panSouthWestCursor.png:
1071         * WebKit.resources/panWestCursor.png:
1072         * WebKit.resources/searchCancel.png:
1073         * WebKit.resources/searchCancelPressed.png:
1074         * WebKit.resources/searchMagnifier.png:
1075         * WebKit.resources/searchMagnifierResults.png:
1076         * WebKit.resources/textAreaResizeCorner.png:
1077         * WebKit.resources/verticalTextCursor.png:
1078         * WebKit.resources/zoomInCursor.png:
1079         * WebKit.resources/zoomOutCursor.png:
1080
1081 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1082
1083         Unreviewed Windows build fix for r238049.
1084
1085         * WebView.cpp:
1086         (WebView::initWithFrame):
1087
1088 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1089
1090         Unreviewed MSVC build fix after r238039 (and r238046).
1091
1092         * WebDocumentLoader.h:
1093         * WebView.cpp:
1094         (WebView::setShouldApplyMacFontAscentHack):
1095
1096 2018-11-09  Antti Koivisto  <antti@apple.com>
1097
1098         Use OptionSet for layout milestones
1099         https://bugs.webkit.org/show_bug.cgi?id=191470
1100
1101         Reviewed by Dean Jackson.
1102
1103         * WebCoreSupport/WebFrameLoaderClient.cpp:
1104         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1105         * WebCoreSupport/WebFrameLoaderClient.h:
1106
1107 2018-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1108
1109         WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1110         https://bugs.webkit.org/show_bug.cgi?id=191455
1111
1112         Reviewed by Brent Fulgham.
1113
1114         * WebHistory.h: Marked with 'override' and removed 'virtual'.
1115
1116 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1117
1118         Add a storage limit for IndexedDB
1119         https://bugs.webkit.org/show_bug.cgi?id=190598
1120         <rdar://problem/44654715>
1121
1122         Reviewed by Chris Dumez.
1123
1124         * Interfaces/IWebDatabaseManager.idl:
1125         * WebDatabaseManager.cpp:
1126         (WebDatabaseManager::setIDBPerOriginQuota):
1127         * WebDatabaseManager.h:
1128
1129 2018-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1130
1131         [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
1132         https://bugs.webkit.org/show_bug.cgi?id=191105
1133
1134         Reviewed by Brent Fulgham.
1135
1136         * DOMHTMLClasses.h:
1137         (DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
1138         instead of own setNodeValue.
1139
1140 2018-10-25  Antoine Quint  <graouts@apple.com>
1141
1142         [Web Animations] Turn Web Animations CSS Integration off by default
1143         https://bugs.webkit.org/show_bug.cgi?id=190901
1144
1145         Reviewed by Dean Jackson.
1146
1147         * WebPreferences.cpp:
1148         (WebPreferences::initializeDefaultSettings):
1149
1150 2018-10-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1151
1152         [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1153         https://bugs.webkit.org/show_bug.cgi?id=190744
1154
1155         Reviewed by Alex Christensen.
1156
1157         clang-cl reports compilation warnings for inconsistent 'override'
1158         keyword usage.
1159
1160         WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
1161         This can't be marked 'override' if !USE(CA).
1162
1163         * WebView.cpp:
1164         (WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).
1165         * WebView.h: Marked all overriding member function declarations of WebView 'override'.
1166         Declare flushPendingGraphicsLayerChanges only if USE(CA).
1167
1168 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1169
1170         Clean up FrameLoader two-state enums
1171         https://bugs.webkit.org/show_bug.cgi?id=190731
1172
1173         Reviewed by Chris Dumez.
1174
1175         * WebCoreSupport/WebFrameLoaderClient.cpp:
1176         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1177         * WebCoreSupport/WebFrameLoaderClient.h:
1178
1179 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1180
1181         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1182         https://bugs.webkit.org/show_bug.cgi?id=190675
1183
1184         Reviewed by Chris Dumez.
1185
1186         * BackForwardList.cpp:
1187         (BackForwardList::backItem):
1188         (BackForwardList::currentItem):
1189         (BackForwardList::forwardItem):
1190         (BackForwardList::backListCount const):
1191         (BackForwardList::forwardListCount const):
1192         (BackForwardList::itemAtIndex):
1193         * BackForwardList.h:
1194
1195 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
1196
1197         Unreviewed attempt to fix the Windows build after r237112.
1198
1199         * Plugins/PluginView.cpp:
1200         (WebCore::PluginView::performRequest):
1201
1202 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1203
1204         Replace HistoryItem* with HistoryItem& where possible
1205         https://bugs.webkit.org/show_bug.cgi?id=190617
1206
1207         Reviewed by Chris Dumez.
1208
1209         * BackForwardList.cpp:
1210         (BackForwardList::goToItem):
1211         * BackForwardList.h:
1212         * WebBackForwardList.cpp:
1213         (WebBackForwardList::goToItem):
1214
1215 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1216
1217         Fix Windows build.
1218
1219         * WebView.cpp:
1220         (WebView::loadBackForwardListFromOtherView):
1221
1222 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1223
1224         Fix WinCairo build.
1225
1226         * WebView.cpp:
1227         (WebView::backForwardList):
1228
1229 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1230
1231         Modernize BackForwardClient.h
1232         https://bugs.webkit.org/show_bug.cgi?id=190610
1233
1234         Reviewed by Chris Dumez.
1235
1236         * BackForwardList.cpp:
1237         (BackForwardList::backListCount const):
1238         (BackForwardList::forwardListCount const):
1239         (BackForwardList::backListCount): Deleted.
1240         (BackForwardList::forwardListCount): Deleted.
1241         * BackForwardList.h:
1242         * WebView.cpp:
1243         (WebView::initWithFrame):
1244         (WebView::backForwardList):
1245
1246 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1247
1248         Remove unused WebView._globalHistoryItem
1249         https://bugs.webkit.org/show_bug.cgi?id=190601
1250
1251         Reviewed by Chris Dumez.
1252
1253         * WebCoreSupport/WebFrameLoaderClient.cpp:
1254         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1255         * WebCoreSupport/WebFrameLoaderClient.h:
1256         * WebView.cpp:
1257         (WebView::globalHistoryItem):
1258         (WebView::setGlobalHistoryItem): Deleted.
1259         * WebView.h:
1260
1261 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1262
1263         Remove unused parameters from FrameLoaderClient::createFrame
1264         https://bugs.webkit.org/show_bug.cgi?id=190587
1265
1266         Reviewed by Chris Dumez.
1267
1268         * WebCoreSupport/WebFrameLoaderClient.cpp:
1269         (WebFrameLoaderClient::createFrame):
1270         * WebCoreSupport/WebFrameLoaderClient.h:
1271
1272 2018-10-15  Chris Dumez  <cdumez@apple.com>
1273
1274         Unreviewed Windows build fix after r237112.
1275
1276         * Plugins/PluginView.cpp:
1277         (WebCore::PluginView::performRequest):
1278         (WebCore::PluginView::load):
1279
1280 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1281
1282         Remove InjectedBundle processing of back/forward lists
1283         https://bugs.webkit.org/show_bug.cgi?id=190459
1284
1285         Reviewed by Chris Dumez.
1286
1287         * WebCoreSupport/WebFrameLoaderClient.cpp:
1288         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1289         * WebCoreSupport/WebFrameLoaderClient.h:
1290
1291 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1292
1293         Remove ParsedURLString
1294         https://bugs.webkit.org/show_bug.cgi?id=190154
1295
1296         Reviewed by Chris Dumez.
1297
1298         * WebDownloadCurl.cpp:
1299         (WebDownload::initWithRequest):
1300         * WebURLResponse.cpp:
1301         (WebURLResponse::createInstance):
1302
1303 2018-09-28  Chris Dumez  <cdumez@apple.com>
1304
1305         Drop support for cross-origin-window-policy header
1306         https://bugs.webkit.org/show_bug.cgi?id=190081
1307
1308         Reviewed by Ryosuke Niwa.
1309
1310         * WebPreferenceKeysPrivate.h:
1311         * WebPreferences.cpp:
1312         (WebPreferences::initializeDefaultSettings):
1313         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1314         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1315         * WebView.cpp:
1316         (WebView::notifyPreferencesChanged):
1317
1318 2018-09-27  Antoine Quint  <graouts@apple.com>
1319
1320         [Web Animations] Turn Web Animations with CSS integration on
1321         https://bugs.webkit.org/show_bug.cgi?id=184819
1322         <rdar://problem/39597337>
1323
1324         Reviewed by Dean Jackson.
1325
1326         * WebPreferences.cpp:
1327         (WebPreferences::initializeDefaultSettings):
1328
1329 2018-09-21  Alex Christensen  <achristensen@webkit.org>
1330
1331         Use a Variant for FormDataElement
1332         https://bugs.webkit.org/show_bug.cgi?id=189777
1333
1334         Reviewed by Chris Dumez.
1335
1336         * WebMutableURLRequest.cpp:
1337         (WebMutableURLRequest::setHTTPBody):
1338
1339 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1340
1341         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
1342         https://bugs.webkit.org/show_bug.cgi?id=189612
1343
1344         Reviewed by Alex Christensen.
1345
1346         Non-trivial types can't be used as aruguments of LOG_ERROR and
1347         ASSERT_WITH_MESSAGE.
1348
1349         * DefaultPolicyDelegate.cpp:
1350         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
1351         static_cast<BSTR> to convert BString.
1352         * WebLocalizableStrings.cpp:
1353         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
1354         char* by using 'key.utf8().data()'.
1355
1356 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
1357
1358         Unreviewed, rolling out r235953.
1359
1360         Caused layout test crashes under GuardMalloc.
1361
1362         Reverted changeset:
1363
1364         "Make GraphicsLayers ref-counted, so their tree can persist
1365         when disconnected from RenderLayerBackings"
1366         https://bugs.webkit.org/show_bug.cgi?id=189521
1367         https://trac.webkit.org/changeset/235953
1368
1369 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1370
1371         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
1372         https://bugs.webkit.org/show_bug.cgi?id=189538
1373
1374         Reviewed by Per Arne Vollan.
1375
1376         * WebPreferences.cpp:
1377         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
1378         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
1379         Apply static_cast to the result of OR-ed CFPropertyListFormat.
1380         (WebPreferences::screenFontSubstitutionEnabled):
1381         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
1382
1383 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1384
1385         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
1386         https://bugs.webkit.org/show_bug.cgi?id=189539
1387
1388         Reviewed by Alex Christensen.
1389
1390         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
1391         * WebCoreSupport/WebInspectorClient.cpp:
1392         (WebInspectorWndProc): Ditto.
1393         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
1394         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
1395
1396 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1397
1398         Refactor WebCore::EditAction to be an 8-bit enum class
1399         https://bugs.webkit.org/show_bug.cgi?id=189383
1400
1401         Reviewed by Dan Bernstein.
1402
1403         * WebCoreSupport/WebEditorClient.cpp:
1404         (undoNameForEditAction):
1405
1406 2018-09-04  Frederic Wang  <fwang@igalia.com>
1407
1408         Add basic support for ScrollIntoViewOptions
1409         https://bugs.webkit.org/show_bug.cgi?id=189258
1410
1411         Reviewed by Simon Fraser.
1412
1413         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
1414         can build despite the new scrollIntoView function.
1415
1416 2018-08-31  Chris Dumez  <cdumez@apple.com>
1417
1418         Unreviewed Windows build fix after r235562.
1419
1420         * WebCoreSupport/WebFrameLoaderClient.cpp:
1421         (WebFrameLoaderClient::dispatchWillSubmitForm):
1422
1423 2018-08-31  Chris Dumez  <cdumez@apple.com>
1424
1425         Assertion hit in ~CompletionHandler() from ~WebFrame()
1426         https://bugs.webkit.org/show_bug.cgi?id=189199
1427         <rdar://problem/42657233>
1428
1429         Reviewed by Youenn Fablet.
1430
1431         * WebCoreSupport/WebFrameLoaderClient.cpp:
1432         (WebFrameLoaderClient::dispatchWillSubmitForm):
1433         * WebCoreSupport/WebFrameLoaderClient.h:
1434
1435 2018-08-31  Frederic Wang  <fwang@igalia.com>
1436
1437         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1438         https://bugs.webkit.org/show_bug.cgi?id=182053
1439
1440         Reviewed by Simon Fraser.
1441
1442         Add developer flag to use standard behavior for scrolling* attributes.
1443
1444         * Interfaces/IWebPreferencesPrivate.idl:
1445         * WebPreferenceKeysPrivate.h:
1446         * WebPreferences.cpp:
1447         (WebPreferences::initializeDefaultSettings):
1448         (WebPreferences::CSSOMViewScrollingAPIEnabled):
1449         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
1450         * WebPreferences.h:
1451         * WebView.cpp:
1452         (WebView::notifyPreferencesChanged):
1453
1454 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
1455
1456         [CMake] Replace AVFoundationSupport.py using CMake
1457         https://bugs.webkit.org/show_bug.cgi?id=182891
1458
1459         Reviewed by Per Arne Vollan.
1460
1461         Remove references to the config.h contained in WebCore as it should
1462         not be accessible from outside of WebCore.
1463
1464         * WebKitPrefix.h:
1465
1466 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1467
1468         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
1469         https://bugs.webkit.org/show_bug.cgi?id=188496
1470         <rdar://problem/43216836>
1471
1472         Reviewed by Tim Horton.
1473
1474         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
1475         header directly.
1476
1477         * WebCoreSupport/WebDragClient.cpp:
1478
1479 2018-08-17  Alex Christensen  <achristensen@webkit.org>
1480
1481         Add some plumbing for safe browsing
1482         https://bugs.webkit.org/show_bug.cgi?id=188709
1483
1484         Reviewed by Tim Horton.
1485
1486         * WebCoreSupport/WebFrameLoaderClient.cpp:
1487         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1488         * WebCoreSupport/WebFrameLoaderClient.h:
1489
1490 2018-08-02  David Fenton  <david_fenton@apple.com>
1491
1492         Unreviewed, rolling out r234489.
1493
1494         Caused 50+ crashes and 60+ API failures on iOS
1495
1496         Reverted changeset:
1497
1498         "[WTF] Rename String::format to String::deprecatedFormat"
1499         https://bugs.webkit.org/show_bug.cgi?id=188191
1500         https://trac.webkit.org/changeset/234489
1501
1502 2018-08-01  Tomas Popela  <tpopela@redhat.com>
1503
1504         [WTF] Rename String::format to String::deprecatedFormat
1505         https://bugs.webkit.org/show_bug.cgi?id=188191
1506
1507         Reviewed by Darin Adler.
1508
1509         It should be replaced with string concatenation.
1510
1511         * FullscreenVideoController.cpp:
1512         (timeToString):
1513         * WebView.cpp:
1514         (webKitVersionString):
1515
1516 2018-07-30  Rob Buis  <rbuis@igalia.com>
1517
1518         https://bugs.webkit.org/show_bug.cgi?id=188137
1519         Merge PlatformCookieJar functions into NetworkStorageSession
1520
1521         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1522
1523         Reviewed by Alex Christensen.
1524
1525         * WebCoreSupport/WebPlatformStrategies.cpp:
1526         (WebPlatformStrategies::cookiesForDOM):
1527         (WebPlatformStrategies::setCookiesFromDOM):
1528         (WebPlatformStrategies::cookiesEnabled):
1529         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1530         (WebPlatformStrategies::getRawCookies):
1531         (WebPlatformStrategies::deleteCookie):
1532         * WebPreferences.cpp:
1533         (WebPreferences::clearNetworkLoaderSession):
1534
1535 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
1536
1537         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
1538         https://bugs.webkit.org/show_bug.cgi?id=187963
1539
1540         Reviewed by Alex Christensen.
1541
1542         * Plugins/PluginPackageWin.cpp:
1543         (WebCore::PluginPackage::fetchInfo):
1544         Update split/splitAllowingEmptyEntries usage.
1545
1546 2018-07-18  Antoine Quint  <graouts@apple.com>
1547
1548         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
1549         https://bugs.webkit.org/show_bug.cgi?id=187722
1550
1551         Reviewed by Myles Maxfield.
1552
1553         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
1554
1555         * DOMCoreClasses.cpp:
1556         (DOMElement::font):
1557
1558 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1559
1560         Disable cross-origin-window-policy by default
1561         https://bugs.webkit.org/show_bug.cgi?id=187509
1562
1563         Reviewed by Chris Dumez.
1564
1565         * WebPreferences.cpp:
1566         (WebPreferences::initializeDefaultSettings):
1567
1568 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1569
1570         [WTF] Add user-defined literal for ASCIILiteral
1571         https://bugs.webkit.org/show_bug.cgi?id=186839
1572
1573         Reviewed by Darin Adler.
1574
1575         * Plugins/PluginStream.cpp:
1576         (WebCore::PluginStream::startStream):
1577         * WebCoreSupport/WebContextMenuClient.cpp:
1578         (WebContextMenuClient::searchWithGoogle):
1579
1580 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1581
1582         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
1583         https://bugs.webkit.org/show_bug.cgi?id=186623
1584
1585         Reviewed by Youenn Fablet.
1586
1587         * WebCoreSupport/WebPluginInfoProvider.cpp:
1588         (WebPluginInfoProvider::pluginInfo):
1589         (WebPluginInfoProvider::webVisiblePluginInfo):
1590         * WebCoreSupport/WebPluginInfoProvider.h:
1591
1592 2018-06-13  Chris Dumez  <cdumez@apple.com>
1593
1594         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1595         https://bugs.webkit.org/show_bug.cgi?id=186545
1596
1597         Reviewed by Brady Eidson.
1598
1599         Update client delegate now that parameter type has changed.
1600
1601         * WebCoreSupport/WebFrameLoaderClient.cpp:
1602         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1603         * WebCoreSupport/WebFrameLoaderClient.h:
1604
1605 2018-06-11  Chris Dumez  <cdumez@apple.com>
1606
1607         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
1608         https://bugs.webkit.org/show_bug.cgi?id=186441
1609
1610         Reviewed by Brady Eidson.
1611
1612         Rename existing flag to something a bit more generic, now that it is used for
1613         more things than bypassing the navigation policy check.
1614
1615         * WebView.cpp:
1616         (WebView::goToBackForwardItem):
1617         (WebView::loadBackForwardListFromOtherView):
1618
1619 2018-06-04  Chris Dumez  <cdumez@apple.com>
1620
1621         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
1622         https://bugs.webkit.org/show_bug.cgi?id=186287
1623         <rdar://problem/40783352>
1624
1625         Reviewed by Youenn Fablet.
1626
1627         * Interfaces/IWebPreferencesPrivate.idl:
1628         * WebPreferenceKeysPrivate.h:
1629         * WebPreferences.cpp:
1630         (WebPreferences::initializeDefaultSettings):
1631         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1632         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1633         * WebPreferences.h:
1634         * WebView.cpp:
1635         (WebView::notifyPreferencesChanged):
1636
1637 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1638
1639         [JSC] Pass VM& parameter as much as possible
1640         https://bugs.webkit.org/show_bug.cgi?id=186085
1641
1642         Reviewed by Saam Barati.
1643
1644         * Plugins/PluginPackage.cpp:
1645         (WebCore::NPN_Invoke):
1646
1647 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1648
1649         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
1650         https://bugs.webkit.org/show_bug.cgi?id=186125
1651
1652         Unreviewed build fix
1653
1654         * WebActionPropertyBag.cpp:
1655         (WebActionPropertyBag::Read):
1656         (findMouseEvent): Deleted.
1657
1658 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1659
1660         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
1661         https://bugs.webkit.org/show_bug.cgi?id=186027
1662
1663         Unreviewed build fix
1664
1665         * WebMutableURLRequest.cpp:
1666         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
1667         (WebMutableURLRequest::setClientCertificate):
1668
1669 2018-05-25  Chris Dumez  <cdumez@apple.com>
1670
1671         Minor ApplicationCacheStorage clean up
1672         https://bugs.webkit.org/show_bug.cgi?id=185984
1673
1674         Reviewed by Youenn Fablet.
1675
1676         * WebApplicationCache.cpp:
1677         (WebApplicationCache::originsWithCache):
1678
1679 2018-05-24  Chris Dumez  <cdumez@apple.com>
1680
1681         Reduce copying of FontCascadeDescription objects by moving them around
1682         https://bugs.webkit.org/show_bug.cgi?id=185963
1683
1684         Reviewed by Simon Fraser.
1685
1686         Reduce copying of FontCascadeDescription objects by moving them around when possible.
1687
1688         * FullscreenVideoController.cpp:
1689         (FullscreenVideoController::draw):
1690
1691 2018-05-15  Antoine Quint  <graouts@apple.com>
1692
1693         [Web Animations] Expose Web Animations CSS integration as an experimental feature
1694         https://bugs.webkit.org/show_bug.cgi?id=185647
1695
1696         Reviewed by Dean Jackson.
1697
1698         Rename the Web Animations CSS integration flag.
1699
1700         * Interfaces/IWebPreferencesPrivate.idl:
1701         * WebPreferenceKeysPrivate.h:
1702         * WebPreferences.cpp:
1703         (WebPreferences::initializeDefaultSettings):
1704         (WebPreferences::webAnimationsCSSIntegrationEnabled):
1705         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
1706         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1707         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1708         * WebPreferences.h:
1709         * WebView.cpp:
1710         (WebView::notifyPreferencesChanged):
1711
1712 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1713
1714         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
1715         https://bugs.webkit.org/show_bug.cgi?id=185505
1716
1717         Unreviewed serious crash fix
1718
1719         Windows port crashes soon since Bug 184996.
1720
1721         * WebPreferences.cpp:
1722         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
1723         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
1724
1725 2018-05-07  Daniel Bates  <dabates@apple.com>
1726
1727         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
1728         https://bugs.webkit.org/show_bug.cgi?id=185170
1729
1730         Reviewed by Per Arne Vollan.
1731
1732         * WebCache.cpp:
1733         (WebCache::empty):
1734
1735 2018-04-27  Chris Dumez  <cdumez@apple.com>
1736
1737         Use WindowProxy instead of DOMWindow in our IDL
1738         https://bugs.webkit.org/show_bug.cgi?id=185022
1739
1740         Reviewed by Sam Weinig.
1741
1742         * DOMCoreClasses.cpp:
1743         (DOMDocument::getComputedStyle):
1744
1745 2018-04-23  Daniel Bates  <dabates@apple.com>
1746
1747         Implement Same-Site cookies
1748         https://bugs.webkit.org/show_bug.cgi?id=159464
1749         <rdar://problem/27196358>
1750
1751         Reviewed by Brent Fulgham.
1752
1753         Pass the Same-Site info through the strategy.
1754
1755         * WebCoreSupport/WebPlatformStrategies.cpp:
1756         (WebPlatformStrategies::cookiesForDOM):
1757         (WebPlatformStrategies::setCookiesFromDOM):
1758         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1759         (WebPlatformStrategies::getRawCookies):
1760         * WebCoreSupport/WebPlatformStrategies.h:
1761
1762 2018-04-23  Daniel Bates  <dabates@apple.com>
1763
1764         Implement Same-Site cookies
1765         https://bugs.webkit.org/show_bug.cgi?id=159464
1766         <rdar://problem/27196358>
1767
1768         Reviewed by Brent Fulgham.
1769
1770         Pass the Same-Site info through the strategy.
1771
1772         * WebCoreSupport/WebPlatformStrategies.cpp:
1773         (WebPlatformStrategies::cookiesForDOM):
1774         (WebPlatformStrategies::setCookiesFromDOM):
1775         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1776         (WebPlatformStrategies::getRawCookies):
1777         * WebCoreSupport/WebPlatformStrategies.h:
1778
1779 2018-04-20  Youenn Fablet  <youenn@apple.com>
1780
1781         Make PluginData cache its web visible plugins
1782         https://bugs.webkit.org/show_bug.cgi?id=184421
1783
1784         Reviewed by Chris Dumez.
1785
1786         * WebCoreSupport/WebPluginInfoProvider.cpp:
1787         (WebPluginInfoProvider::pluginInfo):
1788         (WebPluginInfoProvider::webVisiblePluginInfo):
1789         * WebCoreSupport/WebPluginInfoProvider.h:
1790
1791 2018-04-19  Chris Dumez  <cdumez@apple.com>
1792
1793         Rename JSDOMWindowProxy to JSWindowProxy
1794         https://bugs.webkit.org/show_bug.cgi?id=184797
1795
1796         Reviewed by Sam Weinig.
1797
1798         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
1799
1800         * WebFrame.cpp:
1801         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
1802
1803 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
1804
1805         Unreviewed rollout of r230632. Regression in memory usage.
1806
1807         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
1808
1809         * WebPreferences.cpp:
1810         (WebPreferences::initializeDefaultSettings):
1811
1812 2018-04-17  Chris Dumez  <cdumez@apple.com>
1813
1814         Unreviewed attempt to fix the Windows build after r230721
1815
1816         * WebCoreSupport/WebFrameLoaderClient.cpp:
1817         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1818
1819 2018-04-17  Chris Dumez  <cdumez@apple.com>
1820
1821         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
1822         https://bugs.webkit.org/show_bug.cgi?id=184678
1823         <rdar://problem/39422122>
1824
1825         Reviewed by Alex Christensen.
1826
1827         Add new parameter to dispatchDecidePolicyForNavigationAction.
1828
1829         * WebCoreSupport/WebFrameLoaderClient.cpp:
1830         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1831         * WebCoreSupport/WebFrameLoaderClient.h:
1832
1833 2018-04-12  Antoine Quint  <graouts@apple.com>
1834
1835         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
1836         https://bugs.webkit.org/show_bug.cgi?id=184569
1837         <rdar://problem/38671301>
1838
1839         Reviewed by Jon Lee.
1840
1841         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
1842
1843         * WebPreferences.cpp:
1844
1845 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1846
1847         [WTF] Remove StaticLock
1848         https://bugs.webkit.org/show_bug.cgi?id=184332
1849
1850         Reviewed by Mark Lam.
1851
1852         * WebKitQuartzCoreAdditions/CAView.cpp:
1853         (WKQCA::CAView::releaseAllD3DResources):
1854         * WebLocalizableStrings.cpp:
1855
1856 2018-04-03  Chris Dumez  <cdumez@apple.com>
1857
1858         Drop MainFrame class
1859         https://bugs.webkit.org/show_bug.cgi?id=184191
1860
1861         Reviewed by Darin Adler.
1862
1863         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
1864         relationship between the Page and the MainFrame.
1865
1866         This is ground work for introducing LocalFrame / RemoteFrame concepts.
1867
1868         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1869         * WebCoreSupport/WebContextMenuClient.cpp:
1870         * WebCoreSupport/WebDragClient.cpp:
1871         * WebDropSource.cpp:
1872         * WebFrame.cpp:
1873         * WebView.cpp:
1874
1875 2018-03-26  Chris Dumez  <cdumez@apple.com>
1876
1877         Use SecurityOriginData more consistently in Service Worker code
1878         https://bugs.webkit.org/show_bug.cgi?id=183969
1879
1880         Reviewed by Darin Adler.
1881
1882         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
1883
1884         * WebDatabaseManager.cpp:
1885         (WebDatabaseManager::databasesWithOrigin):
1886         (WebDatabaseManager::deleteOrigin):
1887         (WebDatabaseManager::deleteDatabase):
1888         (WebDatabaseManager::setQuota):
1889         * WebSecurityOrigin.cpp:
1890         (WebSecurityOrigin::usage):
1891         (WebSecurityOrigin::quota):
1892         (WebSecurityOrigin::setQuota):
1893
1894 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
1895
1896         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
1897         https://bugs.webkit.org/show_bug.cgi?id=183911
1898         <rdar://problem/38762306>
1899
1900         Reviewed by Youenn Fablet.
1901
1902         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
1903
1904         * WebView.cpp:
1905         (WebView::WebView):
1906
1907 2018-03-25  Commit Queue  <commit-queue@webkit.org>
1908
1909         Unreviewed, rolling out r229954.
1910         https://bugs.webkit.org/show_bug.cgi?id=184000
1911
1912         Caused many layout tests to crash on Apple High Sierra,
1913         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
1914         by dydz on #webkit).
1915
1916         Reverted changeset:
1917
1918         "Use SecurityOriginData more consistently in Service Worker
1919         code"
1920         https://bugs.webkit.org/show_bug.cgi?id=183969
1921         https://trac.webkit.org/changeset/229954
1922
1923 2018-03-24  Chris Dumez  <cdumez@apple.com>
1924
1925         Use SecurityOriginData more consistently in Service Worker code
1926         https://bugs.webkit.org/show_bug.cgi?id=183969
1927
1928         Reviewed by Darin Adler.
1929
1930         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
1931
1932         * WebDatabaseManager.cpp:
1933         (WebDatabaseManager::databasesWithOrigin):
1934         (WebDatabaseManager::deleteOrigin):
1935         (WebDatabaseManager::deleteDatabase):
1936         (WebDatabaseManager::setQuota):
1937         * WebSecurityOrigin.cpp:
1938         (WebSecurityOrigin::usage):
1939         (WebSecurityOrigin::quota):
1940         (WebSecurityOrigin::setQuota):
1941
1942 2018-03-23  Chris Dumez  <cdumez@apple.com>
1943
1944         Unreviewed attempt to fix Windows build after r229926.
1945
1946         * WebView.cpp:
1947
1948 2018-03-23  Brady Eidson  <beidson@apple.com>
1949
1950         Go to back/forward list items after a process-swapped navigation.
1951         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
1952
1953         Reviewed by Andy Estes.
1954
1955         * WebView.cpp:
1956         (WebView::goToBackForwardItem):
1957         (WebView::loadBackForwardListFromOtherView):
1958
1959 2018-03-23  Miguel Gomez  <magomez@igalia.com>
1960
1961         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
1962         https://bugs.webkit.org/show_bug.cgi?id=183892
1963
1964         Remove the UpdateContentsFlag parameter as it's not used anymore.
1965
1966         Reviewed by Žan Doberšek.
1967
1968         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1969         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
1970
1971 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
1972
1973         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
1974         https://bugs.webkit.org/show_bug.cgi?id=183335
1975
1976         Reviewed by Alex Christensen.
1977
1978         * Plugins/PluginDatabaseWin.cpp:
1979         * Plugins/PluginMessageThrottlerWin.cpp:
1980         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
1981         * Plugins/PluginPackageWin.cpp:
1982         (WebCore::PluginPackage::load):
1983         * Plugins/PluginView.h:
1984         * Plugins/PluginViewWin.cpp:
1985         * Plugins/npapi.cpp:
1986         * WebCoreSupport/WebFrameLoaderClient.cpp:
1987         (WebFrameLoaderClient::createPlugin):
1988         (WebFrameLoaderClient::createJavaAppletWidget):
1989         * WebView.cpp:
1990         (WebView::WebViewWndProc):
1991
1992 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
1993
1994         [Win] Layout Test fast/html/menuitem-element.html is failing.
1995         https://bugs.webkit.org/show_bug.cgi?id=179299
1996
1997         Reviewed by Per Arne Vollan.
1998
1999         * Interfaces/IWebPreferencesPrivate.idl:
2000         * WebPreferenceKeysPrivate.h:
2001         * WebPreferences.cpp:
2002         (WebPreferences::menuItemElementEnabled):
2003         (WebPreferences::setMenuItemElementEnabled):
2004         * WebPreferences.h:
2005         * WebView.cpp:
2006         (WebView::notifyPreferencesChanged):
2007         Add private web preference "menuItemElementEnabled".
2008
2009 2018-03-12  Antoine Quint  <graouts@apple.com>
2010
2011         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
2012         https://bugs.webkit.org/show_bug.cgi?id=183504
2013         <rdar://problem/38372965>
2014
2015         Reviewed by Dean Jackson and Jon Lee.
2016
2017         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
2018         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
2019
2020         * Interfaces/IWebPreferencesPrivate.idl:
2021         * WebPreferences.cpp:
2022         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2023         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2024         * WebPreferenceKeysPrivate.h
2025         * WebPreferences.h:
2026         * WebView.cpp:
2027         (WebView::notifyPreferencesChanged):
2028
2029 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2030
2031         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
2032         https://bugs.webkit.org/show_bug.cgi?id=183429
2033
2034         Reviewed by Mark Lam.
2035
2036         * WebFrame.cpp:
2037         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2038
2039 2018-03-08  Tim Horton  <timothy_horton@apple.com>
2040
2041         Stop linking ApplicationServices directly
2042         https://bugs.webkit.org/show_bug.cgi?id=182867
2043         <rdar://problem/38252142>
2044
2045         Reviewed by Alex Christensen.
2046
2047         The frameworks that we use that live inside ApplicationServices
2048         have mostly moved out, so import them directly.
2049
2050         * FullscreenVideoController.cpp:
2051
2052 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2053
2054         Fix std::make_unique / new[] using system malloc
2055         https://bugs.webkit.org/show_bug.cgi?id=182975
2056
2057         Reviewed by JF Bastien.
2058
2059         Use Vector instead.
2060
2061         * MarshallingHelpers.cpp:
2062         (MarshallingHelpers::safeArrayToStringArray):
2063         (MarshallingHelpers::safeArrayToIntArray):
2064         * Plugins/PluginPackageWin.cpp:
2065         (WebCore::PluginPackage::fetchInfo):
2066         * WebPreferences.cpp:
2067         (WebPreferences::copyWebKitPreferencesToCFPreferences):
2068         * WebView.cpp:
2069         (WebView::onMenuCommand):
2070
2071 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2072
2073         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
2074         https://bugs.webkit.org/show_bug.cgi?id=183312
2075
2076         Reviewed by Mark Lam.
2077
2078         Remove wtf/CurrentTime.h include pragma.
2079
2080         * WebDownload.cpp:
2081         * WebDownloadCFNet.cpp:
2082         * WebDropSource.cpp:
2083
2084 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2085
2086         Remove monotonicallyIncreasingTime
2087         https://bugs.webkit.org/show_bug.cgi?id=182911
2088
2089         Reviewed by Michael Catanzaro.
2090
2091         * FullscreenVideoController.cpp:
2092         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
2093         * Plugins/PluginMessageThrottlerWin.cpp:
2094         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
2095         (WebCore::PluginMessageThrottlerWin::appendMessage):
2096         * Plugins/PluginMessageThrottlerWin.h:
2097         * WebView.cpp:
2098         (WebView::notifyAnimationStarted):
2099         * WebView.h:
2100
2101 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2102
2103         [Win][DRT] Implement setSpatialNavigationEnabled.
2104         https://bugs.webkit.org/show_bug.cgi?id=183166
2105
2106         Reviewed by Per Arne Vollan.
2107
2108         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
2109
2110         * Interfaces/IWebPreferencesPrivate.idl:
2111         * WebPreferenceKeysPrivate.h:
2112         * WebPreferences.cpp:
2113         (WebPreferences::initializeDefaultSettings):
2114         (WebPreferences::spatialNavigationEnabled):
2115         (WebPreferences::setSpatialNavigationEnabled):
2116         * WebPreferences.h:
2117         * WebView.cpp:
2118         (WebView::notifyPreferencesChanged):
2119
2120 2018-02-28  Alex Christensen  <achristensen@webkit.org>
2121
2122         Reduce use of NetworkingContext in WebKit
2123         https://bugs.webkit.org/show_bug.cgi?id=183213
2124
2125         Reviewed by Brady Eidson.
2126
2127         * Plugins/PluginView.cpp:
2128         (WebCore::PluginView::getValueForURL):
2129
2130 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
2131
2132         Fix WebCore includes within WebKitLegacy
2133         https://bugs.webkit.org/show_bug.cgi?id=183147
2134
2135         Reviewed by Tim Horton.
2136
2137         * Plugins/PluginDatabase.cpp:
2138         * Plugins/PluginDatabaseWin.cpp:
2139         * Plugins/PluginDebug.cpp:
2140         * Plugins/PluginDebug.h:
2141         * Plugins/PluginMainThreadScheduler.cpp:
2142         * Plugins/PluginMessageThrottlerWin.cpp:
2143         * Plugins/PluginMessageThrottlerWin.h:
2144         * Plugins/PluginPackage.cpp:
2145         * Plugins/PluginPackage.h:
2146         * Plugins/PluginPackageWin.cpp:
2147         * Plugins/PluginStream.cpp:
2148         * Plugins/PluginStream.h:
2149         * Plugins/PluginView.cpp:
2150         * Plugins/PluginView.h:
2151         * Plugins/PluginViewWin.cpp:
2152         * Plugins/npapi.cpp:
2153         * WebCoreSupport/WebChromeClient.cpp:
2154         * WebCoreSupport/WebContextMenuClient.cpp:
2155         * WebCoreSupport/WebFrameLoaderClient.cpp:
2156         * WebCoreSupport/WebInspectorClient.cpp:
2157         * WebCoreSupport/WebPlatformStrategies.cpp:
2158         * WebFrame.cpp:
2159         * WebKitMessageLoop.cpp:
2160         * WebView.cpp:
2161         * storage/WebDatabaseProvider.cpp:
2162
2163 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2164
2165         Remove currentTime() / currentTimeMS()
2166         https://bugs.webkit.org/show_bug.cgi?id=183052
2167
2168         Reviewed by Mark Lam.
2169
2170         * WebCoreSupport/WebFrameLoaderClient.cpp:
2171         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2172         * WebCoreSupport/WebFrameLoaderClient.h:
2173         * WebDownload.h:
2174         * WebDownloadCFNet.cpp:
2175         (WebDownload::didStart):
2176         (WebDownload::didReceiveData):
2177         (WebDownload::didFinish):
2178
2179 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
2180
2181         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
2182         https://bugs.webkit.org/show_bug.cgi?id=182883
2183
2184         Reviewed by Per Arne Vollan.
2185
2186         * WebKitPrefix.h:
2187
2188 2018-02-16  Dean Jackson  <dino@apple.com>
2189
2190         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
2191         https://bugs.webkit.org/show_bug.cgi?id=182894
2192
2193         Reviewed by Tim Horton.
2194
2195         Rename OPENGL_ES_2 to OPENGL_ES.
2196
2197         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2198
2199 2018-02-16  Youenn Fablet  <youenn@apple.com>
2200
2201         Allow specifying which plug-ins are supported
2202         https://bugs.webkit.org/show_bug.cgi?id=182748
2203
2204         Reviewed by Chris Dumez.
2205
2206         * WebCoreSupport/WebPluginInfoProvider.cpp:
2207         (WebPluginInfoProvider::getPluginInfo):
2208         * WebCoreSupport/WebPluginInfoProvider.h:
2209
2210 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
2211
2212         WebCore headers should not be included relatively within dependent projects
2213         https://bugs.webkit.org/show_bug.cgi?id=182805
2214
2215         Reviewed by Chris Dumez.
2216
2217         * FullscreenVideoController.h:
2218
2219 2018-02-13  Commit Queue  <commit-queue@webkit.org>
2220
2221         Unreviewed, rolling out r228431.
2222         https://bugs.webkit.org/show_bug.cgi?id=182766
2223
2224         Regressed CMake build stability (Requested by dolmstead on
2225         #webkit).
2226
2227         Reverted changeset:
2228
2229         "[CMake] Make WebCore headers copies"
2230         https://bugs.webkit.org/show_bug.cgi?id=182512
2231         https://trac.webkit.org/changeset/228431
2232
2233 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
2234
2235         [CMake] Make WebCore headers copies
2236         https://bugs.webkit.org/show_bug.cgi?id=182512
2237
2238         Reviewed by Keith Miller.
2239
2240         * FullscreenVideoController.h:
2241         * Plugins/PluginDatabase.cpp:
2242         * Plugins/PluginDatabaseWin.cpp:
2243         * Plugins/PluginDebug.cpp:
2244         * Plugins/PluginMainThreadScheduler.cpp:
2245         * Plugins/PluginMessageThrottlerWin.cpp:
2246         * Plugins/PluginPackage.cpp:
2247         * Plugins/PluginPackageWin.cpp:
2248         * Plugins/PluginStream.cpp:
2249         * Plugins/PluginView.cpp:
2250         * Plugins/PluginViewWin.cpp:
2251         * Plugins/npapi.cpp:
2252         * WebKitMessageLoop.cpp:
2253         * WebKitPrefix.h:
2254         * storage/WebDatabaseProvider.cpp:
2255
2256 2018-01-13  Darin Adler  <darin@apple.com>
2257
2258         Event improvements
2259         https://bugs.webkit.org/show_bug.cgi?id=179591
2260
2261         Reviewed by Chris Dumez.
2262
2263         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
2264         * WebFrame.cpp: Ditto.
2265
2266         * WebScriptWorld.cpp:
2267         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
2268
2269         * WebView.cpp: Removed include of ScriptValue.h.
2270         (WebView::handleEditingKeyboardEvent): Updated for name change from
2271         keyEvent to underlyingPlatformEvent.
2272
2273 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
2274
2275         Remove WebCore/ForwardingHeaders directory
2276         https://bugs.webkit.org/show_bug.cgi?id=182347
2277
2278         Reviewed by Keith Miller.
2279
2280         * Plugins/PluginView.cpp:
2281         * Plugins/PluginViewWin.cpp:
2282         * WebCoreSupport/WebInspectorClient.cpp:
2283         * WebCoreSupport/WebInspectorClient.h:
2284         * WebFrame.cpp:
2285         * WebJavaScriptCollector.cpp:
2286         * WebView.cpp:
2287
2288 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2289
2290         Unreviewed, another attempt to fix the Windows build after r227479.
2291
2292         * WebFrame.cpp:
2293         (WebFrame::elementWithName):
2294
2295 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2296
2297         Unreviewed, try to fix the Windows build after r227479.
2298
2299         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
2300
2301         * WebFrame.cpp:
2302         (WebFrame::elementWithName):
2303         (WebFrame::controlsInForm):
2304
2305 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
2306
2307         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
2308         https://bugs.webkit.org/show_bug.cgi?id=181859
2309         <rdar://problem/36659886>
2310
2311         Reviewed by Alex Christensen.
2312         
2313         Use local include patch.
2314
2315         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
2316         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
2317         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
2318
2319 2018-01-17  Youenn Fablet  <youenn@apple.com>
2320
2321         Put fetch Request.keepalive behind a runtime flag
2322         https://bugs.webkit.org/show_bug.cgi?id=181592
2323
2324         Reviewed by Chris Dumez.
2325
2326         * WebPreferences.cpp:
2327         (WebPreferences::fetchAPIKeepAliveEnabled):
2328         (WebPreferences::setFetchAPIKeepAliveEnabled):
2329         * WebPreferences.h:
2330         * WebView.cpp:
2331         (WebView::notifyPreferencesChanged):
2332
2333 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2334
2335         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2336         https://bugs.webkit.org/show_bug.cgi?id=181637
2337         <rdar://problem/36508471>
2338
2339         Reviewed by Tim Horton.
2340
2341         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
2342
2343         * WebCoreSupport/WebEditorClient.cpp:
2344         (WebEditorClient::replacementURLForResource):
2345         * WebCoreSupport/WebEditorClient.h:
2346
2347 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2348
2349         Remove std::chrono completely
2350         https://bugs.webkit.org/show_bug.cgi?id=181186
2351
2352         Reviewed by Alex Christensen.
2353
2354         * Plugins/PluginStream.cpp:
2355         (WebCore::lastModifiedDateMS):
2356
2357 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2358
2359         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
2360         https://bugs.webkit.org/show_bug.cgi?id=181173
2361
2362         Reviewed by Alex Christensen.
2363
2364         * WebNodeHighlight.cpp:
2365         (WebNodeHighlight::update): Scale the GraphicsContext.
2366
2367 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2368
2369         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
2370         https://bugs.webkit.org/show_bug.cgi?id=181160
2371
2372         Reviewed by Myles C. Maxfield.
2373
2374         * Plugins/PluginView.cpp:
2375         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
2376
2377 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2378
2379         Enable picture-in-picture from inline element on suspend.
2380         https://bugs.webkit.org/show_bug.cgi?id=180942
2381         rdar://problem/34745234
2382
2383         Reviewed by Jer Noble.
2384
2385         Update signature of enterVideoFullscreenForVideoElement.
2386
2387         * WebCoreSupport/WebChromeClient.cpp:
2388         (WebChromeClient::enterVideoFullscreenForVideoElement):
2389         * WebCoreSupport/WebChromeClient.h:
2390
2391 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2392
2393         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
2394         https://bugs.webkit.org/show_bug.cgi?id=180926
2395
2396         Reviewed by Tim Horton.
2397
2398         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
2399         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
2400
2401         * WebCoreSupport/WebFrameLoaderClient.cpp:
2402         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
2403         (WebFrameLoaderClient::pageID const): Ditto.
2404
2405 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2406
2407         Remove unnecessary boolean result of start() functions
2408         https://bugs.webkit.org/show_bug.cgi?id=180856
2409
2410         Reviewed by Darin Adler.
2411
2412         It always returns true.
2413
2414         * WebDownloadCurl.cpp:
2415         (WebDownload::start):
2416
2417 2017-12-14  John Wilander  <wilander@apple.com>
2418
2419         Storage Access API: Implement frame-specific access in the document.cookie layer
2420         https://bugs.webkit.org/show_bug.cgi?id=180682
2421         <rdar://problem/35982257>
2422
2423         Reviewed by Alex Christensen.
2424
2425         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
2426         CookiesStrategy::cookieRequestHeaderFieldValue(), and
2427         CookiesStrategy::getRawCookies() now take optional parameters for
2428         frameID and pageID to allow frame-specific scoping of cookies.
2429
2430         This change makes the return values of FrameLoaderClient::frameID()
2431         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
2432         WebCore can call those getters and get the right return values in
2433         WebKit and std:nullopt in WebKitLegacy.
2434
2435         * WebCoreSupport/WebFrameLoaderClient.cpp:
2436         (WebFrameLoaderClient::pageID const):
2437         (WebFrameLoaderClient::frameID const):
2438             Now return an optional.
2439         * WebCoreSupport/WebFrameLoaderClient.h:
2440         * WebCoreSupport/WebPlatformStrategies.cpp:
2441         (WebPlatformStrategies::cookiesForDOM):
2442         (WebPlatformStrategies::setCookiesFromDOM):
2443         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2444         (WebPlatformStrategies::getRawCookies):
2445         * WebCoreSupport/WebPlatformStrategies.h:
2446
2447 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2448
2449         [WTF] Thread::create should have Thread::tryCreate
2450         https://bugs.webkit.org/show_bug.cgi?id=180333
2451
2452         Reviewed by Darin Adler.
2453
2454         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
2455         (WKQCA::CVDisplayLink::start):
2456
2457 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2458
2459         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
2460         https://bugs.webkit.org/show_bug.cgi?id=180572
2461
2462         Reviewed by Mark Lam.
2463
2464         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
2465         Also we use Lock instead of Mutex.
2466
2467         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
2468         (WKQCA::CAD3DRenderer::swapChain):
2469         (WKQCA::CAD3DRenderer::renderAndPresent):
2470         (WKQCA::CAD3DRenderer::renderToImage):
2471         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2472         (WKQCA::CAD3DRenderer::renderInternal):
2473         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
2474         * WebKitQuartzCoreAdditions/CAView.cpp:
2475         (WKQCA::CAView::Handle::create):
2476         Return Ref<Handle> instead of RefPtr<>.
2477
2478         (WKQCA::CAView::Handle::lock):
2479         (WKQCA::CAView::Handle::view const):
2480         (WKQCA::CAView::Handle::clear):
2481         (WKQCA::views):
2482         (WKQCA::viewsNeedingUpdate):
2483         (WKQCA::CAView::releaseAllD3DResources):
2484         (WKQCA::CAView::CAView):
2485         (WKQCA::CAView::~CAView):
2486         (WKQCA::CAView::setLayer):
2487         (WKQCA::CAView::update):
2488         (WKQCA::CAView::drawToWindow):
2489         (WKQCA::CAView::drawToWindowInternal):
2490         (WKQCA::CAView::drawToImage):
2491         (WKQCA::CAView::willDraw):
2492         (WKQCA::CAView::drawIntoDC):
2493         (WKQCA::CAView::setShouldInvertColors):
2494         (WKQCA::CAView::scheduleNextDraw):
2495         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2496         (WKQCA::CAView::contextDidChange):
2497         (WKQCA::CAView::updateSoon):
2498         (WKQCA::CAView::updateViewsNow):
2499         (WKQCA::CAView::d3dDevice9):
2500         (WKQCA::CAView::Handle::mutex): Deleted.
2501         (WKQCA::globalStateMutex): Deleted.
2502         (): Deleted.
2503         * WebKitQuartzCoreAdditions/CAView.h:
2504
2505 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2506
2507         Use StaticLock instead of NeverDestroyed<Lock>
2508         https://bugs.webkit.org/show_bug.cgi?id=180507
2509
2510         Reviewed by Saam Barati.
2511
2512         * WebLocalizableStrings.cpp:
2513         (findCachedString):
2514         (cacheString):
2515         (mainBundleLocStrings): Deleted.
2516         (frameworkLocStringsMutex): Deleted.
2517
2518 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
2519
2520         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
2521         https://bugs.webkit.org/show_bug.cgi?id=180431
2522         <rdar://problem/34531264>
2523
2524         Reviewed by Simon Fraser.
2525
2526         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
2527         'override' to make sure this doesn't break in the future.
2528
2529         * WebView.cpp:
2530         (WebView::notifyAnimationStarted):
2531         (WebView::paintContents):
2532         * WebView.h:
2533
2534 2017-11-23  Darin Adler  <darin@apple.com>
2535
2536         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2537         https://bugs.webkit.org/show_bug.cgi?id=179981
2538
2539         Reviewed by Sam Weinig.
2540
2541         * WebView.cpp:
2542         (WebView::searchFor): Use |= instead of | to build FindOptions.
2543         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
2544         (WebView::findString): Create FindOptions with |=; the old code just passed a
2545         WebKit FindOptions through without converting to WebCore::FindOptions.
2546
2547 2017-11-23  Darin Adler  <darin@apple.com>
2548
2549         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2550         https://bugs.webkit.org/show_bug.cgi?id=179907
2551
2552         Reviewed by Sam Weinig.
2553
2554         * Plugins/PluginDatabaseWin.cpp:
2555         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
2556         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
2557         * WebDownloadCFNet.cpp:
2558         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
2559
2560         * WebView.cpp:
2561         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
2562         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
2563         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
2564         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
2565         the code does not cause any change in behavior.
2566
2567 2017-11-22  Ali Juma  <ajuma@chromium.org>
2568
2569         Implement VisualViewport API attributes
2570         https://bugs.webkit.org/show_bug.cgi?id=179385
2571
2572         Reviewed by Frédéric Wang.
2573
2574         Add a VisualViewportAPI preference.
2575
2576         * Interfaces/IWebPreferencesPrivate.idl:
2577         * WebPreferenceKeysPrivate.h:
2578         * WebPreferences.cpp:
2579         (WebPreferences::initializeDefaultSettings):
2580         (WebPreferences::visualViewportAPIEnabled):
2581         (WebPreferences::setVisualViewportAPIEnabled):
2582         * WebPreferences.h:
2583         * WebView.cpp:
2584         (WebView::notifyPreferencesChanged):
2585
2586 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2587
2588         Unreviewed, rolling out r225093.
2589         https://bugs.webkit.org/show_bug.cgi?id=179938
2590
2591         Compilation failed on WinCairo 64-bit Release (Requested by
2592         fredw on #webkit).
2593
2594         Reverted changeset:
2595
2596         "Implement VisualViewport API attributes"
2597         https://bugs.webkit.org/show_bug.cgi?id=179385
2598         https://trac.webkit.org/changeset/225093
2599
2600 2017-11-21  Ali Juma  <ajuma@chromium.org>
2601
2602         Implement VisualViewport API attributes
2603         https://bugs.webkit.org/show_bug.cgi?id=179385
2604
2605         Reviewed by Frédéric Wang.
2606
2607         Add a VisualViewportAPI preference.
2608
2609         * Interfaces/IWebPreferencesPrivate.idl:
2610         * WebPreferenceKeysPrivate.h:
2611         * WebPreferences.cpp:
2612         (WebPreferences::initializeDefaultSettings):
2613         (WebPreferences::visualViewportAPIEnabled):
2614         (WebPreferences::setVisualViewportAPIEnabled):
2615         * WebPreferences.h:
2616         * WebView.cpp:
2617         (WebView::notifyPreferencesChanged):
2618
2619 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2620
2621         Clean up old URL parser remnants
2622         https://bugs.webkit.org/show_bug.cgi?id=179573
2623
2624         Reviewed by Darin Adler.
2625
2626         * WebCoreSupport/WebContextMenuClient.cpp:
2627         (WebContextMenuClient::searchWithGoogle):
2628         Use https if we do end up searching with google.
2629
2630 2017-11-12  Darin Adler  <darin@apple.com>
2631
2632         More is<> and downcast<>, less static_cast<>
2633         https://bugs.webkit.org/show_bug.cgi?id=179600
2634
2635         Reviewed by Chris Dumez.
2636
2637         * WebView.cpp:
2638         (WebView::handleEditingKeyboardEvent): Use downcast.
2639
2640 2017-11-09  Christopher Reid  <chris.reid@sony.com>
2641
2642         Use enum classes within FileSystem
2643         https://bugs.webkit.org/show_bug.cgi?id=175172
2644
2645         Reviewed by Darin Adler.
2646
2647         * Plugins/PluginDatabase.cpp:
2648
2649 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
2650
2651         [Win] Add WebKitQuartzCoreAdditions library.
2652         https://bugs.webkit.org/show_bug.cgi?id=179331
2653
2654         Reviewed by Alex Christensen.
2655
2656         * WebKitQuartzCoreAdditions: Added.
2657         * WebKitQuartzCoreAdditions/API: Added.
2658         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
2659         (toImage):
2660         (WKCACFImageGetWidth):
2661         (WKCACFImageGetHeight):
2662         (WKCACFImageCopyFileMapping):
2663         (WKCACFImageCreateWithImage):
2664         (WKCACFImageFinalize):
2665         (WKCACFImageCopyFormattingDescription):
2666         (WKCACFImageCopyDebugDescription):
2667         (WKCACFImageGetTypeID):
2668         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
2669         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
2670         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
2671         (toView):
2672         (toImpl):
2673         (WKCACFViewCreate):
2674         (WKCACFViewSetLayer):
2675         (WKCACFViewUpdate):
2676         (WKCACFViewFlushContext):
2677         (WKCACFViewInvalidateRects):
2678         (WKCACFViewCanDraw):
2679         (WKCACFViewDraw):
2680         (WKCACFViewCopyDrawnImage):
2681         (WKCACFViewDrawIntoDC):
2682         (contextDidChangeCallback):
2683         (WKCACFViewSetContextDidChangeCallback):
2684         (WKCACFViewGetLastCommitTime):
2685         (WKCACFViewSetContextUserData):
2686         (WKCACFViewGetContext):
2687         (WKCACFViewFinalize):
2688         (WKCACFViewCopyFormattingDescription):
2689         (WKCACFViewCopyDebugDescription):
2690         (WKCACFViewGetTypeID):
2691         (WKCACFViewSetShouldInvertColors):
2692         (WKCACFViewGetD3DDevice9):
2693         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
2694         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
2695         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
2696         (WKQCA::dllInstance):
2697         (DllMain):
2698         (WKCACFShutDown):
2699         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
2700         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
2701         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
2702         (WKQCA::d3d):
2703         (WKQCA::initialPresentationParameters):
2704         (WKQCA::CAD3DRenderer::shared):
2705         (WKQCA::CAD3DRenderer::CAD3DRenderer):
2706         (WKQCA::CAD3DRenderer::swapChain):
2707         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
2708         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
2709         (WKQCA::CAD3DRenderer::initialize):
2710         (WKQCA::D3DMatrixOrthoOffCenterRH):
2711         (WKQCA::prepareDevice):
2712         (WKQCA::updateBounds):
2713         (WKQCA::CAD3DRenderer::renderAndPresent):
2714         (WKQCA::CAD3DRenderer::renderToImage):
2715         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2716         (WKQCA::CAD3DRenderer::renderInternal):
2717         (WKQCA::CAD3DRenderer::postProcess):
2718         (WKQCA::CAD3DRenderer::resetD3DDevice):
2719         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
2720         (WKQCA::CAD3DRenderer::release):
2721         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
2722         (WKQCA::D3DPostProcessingContext::sceneTexture const):
2723         (WKQCA::D3DPostProcessingContext::overlayQuad const):
2724         (WKQCA::CAD3DRenderer::d3dDevice9 const):
2725         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
2726         (WKQCA::CAView::Handle::create):
2727         (WKQCA::CAView::Handle::~Handle):
2728         (WKQCA::CAView::Handle::mutex):
2729         (WKQCA::CAView::Handle::view const):
2730         (WKQCA::CAView::Handle::clear):
2731         (WKQCA::CAView::Handle::Handle):
2732         (WKQCA::globalStateMutex):
2733         (WKQCA::registerMessageWindowClass):
2734         (WKQCA::createMessageWindow):
2735         (WKQCA::CAView::releaseAllD3DResources):
2736         (WKQCA::CAView::CAView):
2737         (WKQCA::CAView::~CAView):
2738         (WKQCA::CAView::create):
2739         (WKQCA::CAView::setContextDidChangeCallback):
2740         (WKQCA::CAView::setLayer):
2741         (WKQCA::CAView::update):
2742         (WKQCA::CAView::invalidateRects):
2743         (WKQCA::CAView::drawToWindow):
2744         (WKQCA::CAView::drawToWindowInternal):
2745         (WKQCA::CAView::drawToImage):
2746         (WKQCA::CAView::willDraw):
2747         (WKQCA::CAView::didDraw):
2748         (WKQCA::CAView::drawIntoDC):
2749         (WKQCA::CAView::setShouldInvertColors):
2750         (WKQCA::CAView::scheduleNextDraw):
2751         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2752         (WKQCA::CAView::contextDidChangeCallback):
2753         (WKQCA::CAView::contextDidChange):
2754         (WKQCA::CAView::updateSoon):
2755         (WKQCA::CAView::updateViewsNow):
2756         (WKQCA::CAView::d3dDevice9):
2757         * WebKitQuartzCoreAdditions/CAView.h: Added.
2758         (WKQCA::CAView::context const):
2759         (WKQCA::CAView::canDraw const):
2760         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
2761         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
2762         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
2763         (WKQCA::CVDisplayLink::CVDisplayLink):
2764         (WKQCA::CVDisplayLink::~CVDisplayLink):
2765         (WKQCA::CVDisplayLink::create):
2766         (WKQCA::CVDisplayLink::start):
2767         (WKQCA::CVDisplayLink::stop):
2768         (WKQCA::CVDisplayLink::setPaused):
2769         (WKQCA::CVDisplayLink::runIOThread):
2770         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
2771         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
2772         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
2773         * WebKitQuartzCoreAdditions/Image.cpp: Added.
2774         (WKQCA::numBytesForSize):
2775         (WKQCA::Image::create):
2776         (WKQCA::Image::Image):
2777         (WKQCA::Image::~Image):
2778         (WKQCA::bitmapInfo):
2779         (WKQCA::Image::createDIB const):
2780         (WKQCA::Image::copyFileMapping):
2781         * WebKitQuartzCoreAdditions/Image.h: Added.
2782         (WKQCA::Image::size const):
2783         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
2784         (WKQCA::getBackBufferRectAsRenderTarget):
2785         (WKQCA::getSystemMemoryCopy):
2786         (WKQCA::copyRectToBitmap):
2787         (WKQCA::getImageCopy):
2788         (WKQCA::getBackBufferRectAsImage):
2789         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
2790         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
2791         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
2792         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
2793         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
2794
2795 2017-11-06  Christopher Reid  <chris.reid@sony.com>
2796
2797         Use enum classes within FileSystem
2798         https://bugs.webkit.org/show_bug.cgi?id=175172
2799
2800         Reviewed by Myles C. Maxfield.
2801
2802         * Plugins/PluginDatabase.cpp:
2803
2804 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
2805
2806         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
2807         https://bugs.webkit.org/show_bug.cgi?id=178333
2808
2809         Reviewed by Darin Adler.
2810
2811         * WebCoreSupport/WebFrameLoaderClient.cpp:
2812         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
2813
2814 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2815
2816         Use CompletionHandlers for redirects
2817         https://bugs.webkit.org/show_bug.cgi?id=179163
2818
2819         Reviewed by Tim Horton.
2820
2821         * Plugins/PluginStream.cpp:
2822         (WebCore::PluginStream::willSendRequest):
2823         * Plugins/PluginStream.h:
2824         (WebCore::PluginStreamClient::~PluginStreamClient):
2825         (WebCore::PluginStreamClient::streamDidFinishLoading):
2826         (WebCore::PluginStream::create):
2827         (WebCore::PluginStream::setLoadManually):
2828
2829 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2830
2831         Add a FileSystem namespace to FileSystem.cpp
2832         https://bugs.webkit.org/show_bug.cgi?id=179063
2833
2834         Reviewed by Darin Adler.
2835
2836         * Plugins/PluginDatabase.cpp:
2837         * Plugins/PluginPackage.cpp:
2838         * Plugins/PluginStream.cpp:
2839         * Plugins/PluginStream.h:
2840         * WebApplicationCache.cpp:
2841         * WebDatabaseManager.cpp:
2842         * WebDownloadCurl.cpp:
2843         * WebPreferences.cpp:
2844         * WebView.cpp:
2845
2846 2017-10-31  Alex Christensen  <achristensen@webkit.org>
2847
2848         Fix Windows build after r224260
2849
2850         * WebView.cpp:
2851         (WebView::gesture):
2852
2853 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2854
2855         [FrameView::layout cleanup] Move core layout logic to a separate class.
2856         https://bugs.webkit.org/show_bug.cgi?id=178771
2857         <rdar://problem/35166542>
2858
2859         Reviewed by Simon Fraser.
2860
2861         Move layout code out from FrameView to LayoutContext.
2862
2863         * WebFrame.cpp:
2864         (WebFrame::layout):
2865
2866 2017-10-26  Alex Christensen  <achristensen@webkit.org>
2867
2868         Fix Windows build
2869         https://bugs.webkit.org/show_bug.cgi?id=178892
2870
2871         * AccessibleBase.cpp:
2872         (MSAARole):
2873
2874 2017-10-26  Alex Christensen  <achristensen@webkit.org>
2875
2876         Fix Windows build
2877         https://bugs.webkit.org/show_bug.cgi?id=178892
2878
2879         * AccessibleBase.cpp:
2880         (AccessibleBase::state const):
2881         (MSAARole):
2882
2883 2017-10-25  Youenn Fablet  <youenn@apple.com>
2884
2885         Enable ServiceWorker to fetch resources
2886         https://bugs.webkit.org/show_bug.cgi?id=178673
2887
2888         Reviewed by Brady Eidson.
2889
2890         Added implementation to the new getters.
2891         They are noop in the context of WK1.
2892
2893         * WebCoreSupport/WebFrameLoaderClient.cpp:
2894         (WebFrameLoaderClient::pageID const):
2895         (WebFrameLoaderClient::frameID const):
2896         (WebFrameLoaderClient::sessionID const):
2897         * WebCoreSupport/WebFrameLoaderClient.h:
2898
2899 2017-10-20  Antoine Quint  <graouts@apple.com>
2900
2901         [Web Animations] Provide basic timeline and animation interfaces
2902         https://bugs.webkit.org/show_bug.cgi?id=178526
2903
2904         Reviewed by Dean Jackson.
2905
2906         Remove the WEB_ANIMATIONS compile-time flag.
2907
2908         * WebView.cpp:
2909         (WebView::notifyPreferencesChanged):
2910
2911 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2912
2913         [Curl] Clean up old style code in old curl files.
2914         https://bugs.webkit.org/show_bug.cgi?id=178569
2915
2916         Reviewed by Ryosuke Niwa.
2917
2918         * WebCache.cpp:
2919         (WebCache::cacheFolder):
2920         (WebCache::setCacheFolder):
2921         * WebView.cpp:
2922         (WebView::setCacheModel):
2923
2924 2017-10-19  Sam Weinig  <sam@webkit.org>
2925
2926         [Settings] Move global settings into their own file
2927         https://bugs.webkit.org/show_bug.cgi?id=178512
2928
2929         Reviewed by Darin Adler.
2930
2931         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2932
2933         * WebView.cpp:
2934         (WebView::initWithFrame):
2935
2936 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2937
2938         Replace some stack raw pointers with RefPtrs within WebCore/html
2939         https://bugs.webkit.org/show_bug.cgi?id=178201
2940         <rdar://problem/34841692>
2941
2942         Reviewed by Ryosuke Niwa.
2943
2944         * WebView.cpp:
2945         (WebView::handleEditingKeyboardEvent):
2946         Change the type of node as toNode() is changed to return RefPtr.
2947
2948 2017-10-16  Sam Weinig  <sam@webkit.org>
2949
2950         [Settings] Remove all custom code from Settings.h/cpp
2951         https://bugs.webkit.org/show_bug.cgi?id=178330
2952
2953         Reviewed by Simon Fraser.
2954
2955         * WebView.cpp:
2956         (WebView::notifyPreferencesChanged):
2957             
2958             Update for naming changes of FrameFlattening now that it is an enum class.
2959
2960 2017-10-11  Chris Dumez  <cdumez@apple.com>
2961
2962         Modernize Geolocation code
2963         https://bugs.webkit.org/show_bug.cgi?id=178148
2964
2965         Reviewed by Ryosuke Niwa.
2966
2967         * WebCoreSupport/WebGeolocationClient.cpp:
2968         (WebGeolocationClient::lastPosition):
2969         * WebCoreSupport/WebGeolocationClient.h:
2970         * WebGeolocationPosition.cpp:
2971         (WebGeolocationPosition::initWithTimestamp):
2972         (core):
2973         * WebGeolocationPosition.h:
2974         (WebGeolocationPosition::impl const):
2975
2976 2017-10-05  Chris Dumez  <cdumez@apple.com>
2977
2978         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2979         https://bugs.webkit.org/show_bug.cgi?id=177957
2980
2981         Reviewed by Alex Christensen.
2982
2983         * WebCoreSupport/WebPlatformStrategies.cpp:
2984         (WebPlatformStrategies::cookiesEnabled):
2985         * WebCoreSupport/WebPlatformStrategies.h:
2986
2987 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2988
2989         [Curl] Reimplement CurlDownload with CurlRequest
2990         https://bugs.webkit.org/show_bug.cgi?id=177779
2991
2992         Reviewed by Alex Christensen.
2993
2994         * WebDownload.h:
2995         * WebDownloadCurl.cpp:
2996         (WebDownload::init):
2997         (WebDownload::didReceiveResponse):
2998
2999 2017-09-29  Chris Dumez  <cdumez@apple.com>
3000
3001         Split some logic out of VisitedLinkStore and make it reusable
3002         https://bugs.webkit.org/show_bug.cgi?id=177575
3003
3004         Reviewed by Alex Christensen.
3005
3006         * WebCoreSupport/WebVisitedLinkStore.cpp:
3007         (WebVisitedLinkStore::addVisitedLink):
3008         (WebVisitedLinkStore::isLinkVisited):
3009         (WebVisitedLinkStore::addVisitedLinkHash):
3010         * WebCoreSupport/WebVisitedLinkStore.h:
3011
3012 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3013
3014         Make PolicyAction an encodable enum class
3015         https://bugs.webkit.org/show_bug.cgi?id=177480
3016
3017         Reviewed by Antti Koivisto.
3018
3019         * WebCoreSupport/WebFrameLoaderClient.cpp:
3020         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3021         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3022         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3023         * WebFramePolicyListener.cpp:
3024         (WebFramePolicyListener::use):
3025         (WebFramePolicyListener::download):
3026         (WebFramePolicyListener::ignore):
3027         (WebFramePolicyListener::continueSubmit):
3028
3029 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
3030
3031         [Win] fast/canvas/2d.getPath.modification.html is failing.
3032         https://bugs.webkit.org/show_bug.cgi?id=176534
3033
3034         Reviewed by Alex Christensen.
3035
3036         We need to enable Inspector additions at runtime in order to expose the getPath function.
3037
3038         * Interfaces/IWebPreferencesPrivate.idl:
3039         * WebPreferenceKeysPrivate.h:
3040         * WebPreferences.cpp:
3041         (WebPreferences::initializeDefaultSettings):
3042         (WebPreferences::setDataTransferItemsEnabled):
3043         (WebPreferences::inspectorAdditionsEnabled):
3044         (WebPreferences::setInspectorAdditionsEnabled):
3045         * WebPreferences.h:
3046         * WebView.cpp:
3047         (WebView::notifyPreferencesChanged):
3048
3049 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3050
3051         Modernize Geolocation code
3052         https://bugs.webkit.org/show_bug.cgi?id=176496
3053
3054         Reviewed by Andy Estes.
3055
3056         * WebCoreSupport/WebGeolocationClient.cpp:
3057         (WebGeolocationClient::requestPermission):
3058         * WebCoreSupport/WebGeolocationClient.h:
3059         (WebGeolocationClient::setEnableHighAccuracy): Deleted.
3060         (WebGeolocationClient::cancelPermissionRequest): Deleted.
3061         * WebGeolocationPolicyListener.h:
3062         * WebView.cpp:
3063         (WebView::initWithFrame):
3064         (WebView::geolocationDidFailWithError):
3065
3066 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
3067
3068         [Win] Enable DatatransferItems in DRT.
3069         https://bugs.webkit.org/show_bug.cgi?id=176424
3070
3071         Reviewed by Brent Fulgham.
3072
3073         * Interfaces/IWebPreferencesPrivate.idl:
3074         * WebPreferenceKeysPrivate.h:
3075         * WebPreferences.cpp:
3076         (WebPreferences::initializeDefaultSettings):
3077         (WebPreferences::QueryInterface):
3078         (WebPreferences::isSecureContextAttributeEnabled):
3079         (WebPreferences::dataTransferItemsEnabled):
3080         (WebPreferences::setDataTransferItemsEnabled):
3081         * WebPreferences.h:
3082         * WebView.cpp:
3083         (WebView::notifyPreferencesChanged):
3084
3085 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3086
3087         Unreviewed build fix #2 after r221275.
3088
3089         * WebCoreSupport/WebPlatformStrategies.cpp:
3090         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
3091         to match new API.
3092         * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
3093
3094 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3095
3096         Unreviewed build fix after r221275.
3097
3098         * WebCoreSupport/WebPlatformStrategies.cpp:
3099         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
3100         to match new API.
3101
3102 2017-08-28  Per Arne Vollan  <pvollan@apple.com>
3103
3104         [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
3105         https://bugs.webkit.org/show_bug.cgi?id=176031
3106
3107         Reviewed by Brent Fulgham.
3108
3109         When the function in the FramePolicyFunction parameter is called, it has already been moved
3110         to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
3111         function by using the stored member instead.
3112
3113         * WebCoreSupport/WebFrameLoaderClient.cpp:
3114         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3115         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3116         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3117
3118 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3119
3120         Unreviewed, try to fix the Windows build after r221064
3121
3122         didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
3123
3124         * WebCoreSupport/WebEditorClient.h:
3125
3126 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3127
3128         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3129         https://bugs.webkit.org/show_bug.cgi?id=175370
3130         <rdar://problem/33799806>
3131
3132         Reviewed by Ryosuke Niwa.
3133
3134         Adjust WebEditorClient for interface changes.
3135
3136         * WebCoreSupport/WebEditorClient.h:
3137
3138 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
3139
3140         Unreviewed build fix after r221017.
3141
3142         Correct copy/paste error.
3143
3144         * WebCoreSupport/WebPlatformStrategies.cpp:
3145         (WebPlatformStrategies::cookiesForDOM):
3146
3147 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
3148
3149         Unreviewed build fix after r221017.
3150
3151         * WebCoreSupport/WebPlatformStrategies.cpp:
3152         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
3153         * WebCoreSupport/WebPlatformStrategies.h:
3154
3155 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3156
3157         Remove ChromeClient::scrollbarsModeDidChange
3158         https://bugs.webkit.org/show_bug.cgi?id=175805
3159
3160         Reviewed by Daniel Bates.
3161
3162         * WebCoreSupport/WebChromeClient.h:
3163
3164 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3165
3166         Remove ChromeClient::hasOpenedPopup
3167         https://bugs.webkit.org/show_bug.cgi?id=175804
3168
3169         Reviewed by Sam Weinig.
3170
3171         * WebCoreSupport/WebChromeClient.cpp:
3172         (WebChromeClient::hasOpenedPopup const): Deleted.
3173         * WebCoreSupport/WebChromeClient.h:
3174
3175 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
3176
3177         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
3178         https://bugs.webkit.org/show_bug.cgi?id=173536
3179
3180         Reviewed by Brent Fulgham.
3181
3182         If the tree state is dirty, accessible objects are deleted while iterating over children
3183         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
3184         style is updated before this method is called.
3185
3186         * AccessibleBase.cpp:
3187         (AccessibleBase::getAccessibilityObjectForChild):
3188
3189 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3190
3191         [PAL] Move SessionID into PAL
3192         https://bugs.webkit.org/show_bug.cgi?id=174192
3193
3194         Reviewed by Antti Koivisto.
3195
3196         * WebCoreSupport/WebFrameLoaderClient.cpp:
3197         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3198         * WebCoreSupport/WebFrameLoaderClient.h:
3199         * WebCoreSupport/WebFrameNetworkingContext.cpp:
3200         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
3201         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3202         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3203         (WebFrameNetworkingContext::storageSession const):
3204         * WebCoreSupport/WebPlatformStrategies.cpp:
3205         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3206         * WebCoreSupport/WebPlatformStrategies.h:
3207
3208 2017-08-15  Youenn Fablet  <youenn@apple.com>
3209
3210         [Cache API] Adding generic support for CacheStorage and Cache methods
3211         https://bugs.webkit.org/show_bug.cgi?id=175455
3212
3213         Reviewed by Chris Dumez.
3214
3215         * WebView.cpp:
3216         (WebView::initWithFrame):
3217
3218 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3219
3220         Composition underline color is always black
3221         https://bugs.webkit.org/show_bug.cgi?id=174675
3222
3223         Reviewed by Ryosuke Niwa.
3224
3225         * WebView.cpp:
3226         (WebView::setCompositionForTesting): Use text color for
3227         composition underline.
3228
3229 2017-08-09  Daniel Bates  <dabates@apple.com>
3230
3231         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3232         https://bugs.webkit.org/show_bug.cgi?id=175247
3233         <rdar://problem/33679804>
3234
3235         Reviewed by Brady Eidson.
3236
3237         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3238         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3239         clients that need to make use of this information at this time. If such a needs comes up
3240         then we can expose API/SPI similar to what we do for WebKit.
3241
3242         * WebCoreSupport/WebFrameLoaderClient.cpp:
3243         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3244         * WebCoreSupport/WebFrameLoaderClient.h:
3245
3246 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3247
3248         Async image decoding for large images should be disabled after the first time a tile is painted
3249         https://bugs.webkit.org/show_bug.cgi?id=174451
3250         <rdar://problem/31246421>
3251
3252         Reviewed by Simon Fraser.
3253
3254         * FullscreenVideoController.cpp:
3255         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3256         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3257         (AcceleratedCompositingContext::paintContents):
3258         * WebCoreSupport/AcceleratedCompositingContext.h:
3259
3260 2017-07-23  Darin Adler  <darin@apple.com>
3261
3262         More NeverDestroyed and related cleanup
3263         https://bugs.webkit.org/show_bug.cgi?id=174745
3264
3265         Reviewed by Alex Christensen.
3266
3267         * Plugins/PluginDatabase.cpp:
3268         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
3269         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
3270         * Plugins/PluginMainThreadScheduler.cpp:
3271         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
3272         * Plugins/PluginMainThreadScheduler.h: Ditto.
3273         * WebCoreSupport/WebPlatformStrategies.cpp:
3274         (WebPlatformStrategies::initialize): Ditto.
3275         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
3276         * WebHistory.cpp:
3277         (sharedHistoryStorage): Ditto.
3278         * WebLocalizableStrings.cpp:
3279         (mainBundleLocStrings): Ditto.
3280         (frameworkLocStringsMutex): Ditto.
3281         (frameworkLocStrings): Ditto.
3282         * WebView.cpp:
3283         (WebView::standardUserAgentWithApplicationName): Ditto.
3284         Also changed to keep one global string with the prefix of the user agent string
3285         instead of keeping two globals with pieces of that prefix.
3286
3287 2017-07-24  Chris Dumez  <cdumez@apple.com>
3288
3289         Make ExceptionCode a proper enumeration
3290         https://bugs.webkit.org/show_bug.cgi?id=174771
3291
3292         Reviewed by Sam Weinig.
3293
3294         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
3295
3296         * DOMCoreClasses.cpp:
3297         (DOMDocument::createEvent):
3298         * WebView.cpp:
3299         (WebView::prepareCandidateWindow):
3300
3301 2017-07-21  Andreas Kling  <akling@apple.com>
3302
3303         Use more references in event dispatch code
3304         https://bugs.webkit.org/show_bug.cgi?id=174681
3305
3306         Reviewed by Geoffrey Garen.
3307
3308         * DOMEventsClasses.cpp:
3309         (WebEventListener::handleEvent):
3310         * DOMEventsClasses.h:
3311         * Plugins/PluginView.cpp:
3312         (WebCore::PluginView::handleEvent):
3313         * Plugins/PluginView.h:
3314
3315 2017-07-20  Brady Eidson  <beidson@apple.com>
3316
3317         Remove WebIconDatabase from WebKitLegacy/win.
3318         https://bugs.webkit.org/show_bug.cgi?id=174608
3319
3320         Reviewed by Alex Christensen.
3321
3322         It is unused.
3323         
3324         * ForEachCoClass.h:
3325
3326         * Interfaces/IWebIconDatabase.idl: Removed.
3327
3328         * Interfaces/WebKit.idl:
3329
3330         * WebCoreStatistics.cpp:
3331         (WebCoreStatistics::iconPageURLMappingCount):
3332         (WebCoreStatistics::iconRetainedPageURLCount):
3333         (WebCoreStatistics::iconRecordCount):
3334         (WebCoreStatistics::iconsWithDataCount):
3335
3336         * WebIconDatabase.cpp: Removed.
3337         * WebIconDatabase.h: Removed.
3338         * WebKitClassFactory.cpp:
3339
3340         * WebKitDLL.cpp:
3341         (shutDownWebKit):
3342
3343         * WebKitLogging.h:
3344
3345         * WebView.cpp:
3346         (WebView::close):
3347         (WebView::notifyDidAddIcon):
3348         (WebView::registerForIconNotification):
3349         (WebView::dispatchDidReceiveIconFromWebFrame):
3350         (WebView::onNotify):
3351
3352 2017-07-18  Matt Lewis  <jlewis3@apple.com>
3353
3354         Unreviewed, rolling out r219610.
3355
3356         This caused an api failure on all platforms for the test
3357         SnapshotImageLargeAsyncDecoding
3358
3359         Reverted changeset:
3360
3361         "Async image decoding for large images should be disabled
3362         after the first time a tile is painted"
3363         https://bugs.webkit.org/show_bug.cgi?id=174451
3364         http://trac.webkit.org/changeset/219610
3365
3366 2017-07-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
3367
3368         Async image decoding for large images should be disabled after the first time a tile is painted
3369         https://bugs.webkit.org/show_bug.cgi?id=174451
3370
3371         Reviewed by Simon Fraser.
3372
3373         * FullscreenVideoController.cpp:
3374         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3375         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3376         (AcceleratedCompositingContext::paintContents):
3377         * WebCoreSupport/AcceleratedCompositingContext.h:
3378
3379 2017-07-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3380
3381         [Curl] Don't start downloading more than once for same request
3382         https://bugs.webkit.org/show_bug.cgi?id=174172
3383
3384         Reviewed by Alex Christensen.
3385
3386         * WebDownloadCurl.cpp:
3387         (WebDownload::init):
3388
3389 2017-07-12  Daniel Bates  <dabates@apple.com>
3390
3391         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3392         https://bugs.webkit.org/show_bug.cgi?id=174427
3393
3394         Rubber-stamped by Brady Eidson.
3395
3396         * Plugins/PluginView.cpp:
3397         (WebCore::PluginView::start):
3398         (WebCore::PluginView::getURLNotify):
3399         (WebCore::PluginView::getURL):
3400         (WebCore::PluginView::handlePost):
3401
3402 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3403
3404         [WTF] Move SoftLinking.h into WTF
3405         https://bugs.webkit.org/show_bug.cgi?id=174000
3406
3407         Reviewed by Alex Christensen.
3408
3409         * WebKitClassFactory.cpp:
3410         * WebView.cpp:
3411
3412 2017-07-05  Brady Eidson  <beidson@apple.com>
3413
3414         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3415         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3416
3417         Reviewed by Alex Christensen.
3418
3419         Adopt to the new constructor for FrameLoadRequest.
3420
3421         * Plugins/PluginView.cpp:
3422         (WebCore::PluginView::start):
3423         (WebCore::PluginView::getURLNotify):
3424         (WebCore::PluginView::getURL):
3425         (WebCore::PluginView::handlePost):
3426
3427 2017-07-03  Brady Eidson  <beidson@apple.com>
3428
3429         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3430         https://bugs.webkit.org/show_bug.cgi?id=174073
3431
3432         Reviewed by Andy Estes.
3433
3434         * WebCoreSupport/WebFrameLoaderClient.cpp:
3435         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3436         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3437         * WebCoreSupport/WebFrameLoaderClient.h:
3438
3439 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3440
3441         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3442         https://bugs.webkit.org/show_bug.cgi?id=174004
3443
3444         Reviewed by Simon Fraser.
3445
3446         * WebCoreSupport/WebFrameLoaderClient.cpp:
3447         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3448
3449 2017-06-30  Daniel Bates  <dabates@apple.com>
3450
3451         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3452         https://bugs.webkit.org/show_bug.cgi?id=165160
3453         <rdar://problem/29451999>
3454
3455         Reviewed by Brady Eidson.
3456
3457         Pass the document that is requesting the load to the loader.
3458
3459         * Plugins/PluginView.cpp:
3460         (WebCore::PluginView::start):
3461         (WebCore::PluginView::getURLNotify):
3462         (WebCore::PluginView::getURL):
3463         (WebCore::PluginView::handlePost):
3464
3465 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3466
3467         Refactor drag start codepaths to plumb a DragItem to client layers
3468         https://bugs.webkit.org/show_bug.cgi?id=173832
3469         Work towards <rdar://problem/32236827>
3470
3471         Reviewed by Ryosuke Niwa and Tim Horton.
3472
3473         Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
3474
3475         * WebCoreSupport/WebDragClient.cpp:
3476         (WebDragClient::startDrag):
3477         * WebCoreSupport/WebDragClient.h:
3478
3479 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3480
3481         Remove excessive headers from JavaScriptCore
3482         https://bugs.webkit.org/show_bug.cgi?id=173812
3483
3484         Reviewed by Darin Adler.
3485
3486         * Plugins/PluginPackage.cpp:
3487
3488 2017-06-22  Daniel Bates  <dabates@apple.com>
3489
3490         Make FrameLoadRequest a move-only type
3491         https://bugs.webkit.org/show_bug.cgi?id=173682
3492
3493         Reviewed by Alex Christensen and Darin Adler.
3494
3495         A FrameLoadRequest groups together the information to perform a load into a single object
3496         that is more manageable to pass around than its constituent parts. Code that receives a
3497         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3498         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3499         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
3500
3501         * Plugins/PluginView.cpp:
3502         (WebCore::PluginView::start):
3503         (WebCore::PluginView::performRequest):
3504         (WebCore::PluginView::load):
3505         (WebCore::PluginView::getURLNotify):
3506         (WebCore::PluginView::getURL):
3507         (WebCore::PluginView::handlePost):
3508         * Plugins/PluginView.h:
3509         (WebCore::PluginRequest::PluginRequest):
3510
3511 2017-06-22  Daniel Bates  <dabates@apple.com>
3512
3513         [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
3514         https://bugs.webkit.org/show_bug.cgi?id=173683
3515
3516         Reviewed by Alex Christensen.
3517
3518         Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
3519         header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
3520         by including PluginView.h. The latter does not make use of the functionality
3521         provided by FrameLoadRequest.h.
3522
3523         * Plugins/PluginViewWin.cpp:
3524         * WebCoreSupport/WebContextMenuClient.cpp:
3525
3526 2017-06-21  Daniel Bates  <dabates@apple.com>
3527
3528         Cleanup FrameLoadRequest
3529         https://bugs.webkit.org/show_bug.cgi?id=173564
3530         <rdar://problem/32903570>
3531
3532         Reviewed by Brent Fulgham.
3533
3534         * Plugins/PluginView.cpp:
3535         (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
3536         we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
3537         we do not have one. Use C++11 brace initialization syntax.
3538         (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
3539         name as we do not have one. Use C++11 brace initialization syntax.
3540         (WebCore::PluginView::getURL): Ditto.
3541         (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
3542         function to closer to where it is actually used. Explicitly pass the null-string for the target
3543         frame name as we do not have one. Use C++11 brace initialization syntax.
3544
3545 2017-06-20  Daniel Bates  <dabates@apple.com>
3546
3547         Have FrameLoadRequest takes a Frame& instead of a Frame*
3548         https://bugs.webkit.org/show_bug.cgi?id=173614
3549         <rdar://problem/32884890>
3550
3551         Reviewed by Brent Fulgham.
3552
3553         * Plugins/PluginView.cpp:
3554         (WebCore::PluginView::performRequest):
3555         * WebFrame.cpp:
3556         (WebFrame::loadRequest):
3557
3558 2017-06-19  Chris Dumez  <cdumez@apple.com>
3559
3560         Use WTF::Function instead of std::function in more places in WebCore/
3561         https://bugs.webkit.org/show_bug.cgi?id=173535
3562
3563         Reviewed by Antti Koivisto.
3564
3565         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
3566
3567         * WebCoreSupport/WebFrameLoaderClient.cpp:
3568         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3569         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3570         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3571         (WebFrameLoaderClient::dispatchWillSubmitForm):
3572         (WebFrameLoaderClient::setUpPolicyListener):
3573         (WebFrameLoaderClient::receivedPolicyDecision):
3574         * WebCoreSupport/WebFrameLoaderClient.h:
3575
3576 2017-05-14 Frederic Wang  <fwang@igalia.com>
3577
3578         Add heuristic to avoid flattening "fullscreen" iframes
3579         https://bugs.webkit.org/show_bug.cgi?id=171914
3580
3581         Reviewed by Simon Fraser.
3582
3583         This commit ajusts the window port to internally use the new preference type for frame flattening.
3584         However, the "partial frame flattening" value is not exposed yet.
3585
3586         * WebView.cpp:
3587         (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
3588
3589 2017-06-17  Chris Dumez  <cdumez@apple.com>
3590
3591         Use WTF::Function instead of std::function in WebKit2/
3592         https://bugs.webkit.org/show_bug.cgi?id=173504
3593
3594         Reviewed by Darin Adler.
3595
3596         Use WTF::Function instead of std::function in WebKit2/ to avoid
3597         unnecessary copying.
3598
3599         * Plugins/PluginStream.cpp:
3600         (WebCore::PluginStream::willSendRequest):
3601         * Plugins/PluginStream.h:
3602
3603 2017-06-16  Sam Weinig  <sam@webkit.org>
3604
3605         [WebIDL] Remove custom bindings for HTMLDocument
3606         https://bugs.webkit.org/show_bug.cgi?id=173444
3607
3608         Reviewed by Darin Adler.
3609
3610         * DOMHTMLClasses.cpp:
3611         (DOMHTMLDocument::write):
3612         (DOMHTMLDocument::writeln):
3613         Update for new signature of write/writeln.
3614
3615 2017-06-16  Daniel Bates  <dabates@apple.com>
3616
3617         Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
3618         instead of URL { ParsedURLString, ... }
3619         https://bugs.webkit.org/show_bug.cgi?id=173495
3620         <rdar://problem/32827445>
3621
3622         Reviewed by Alex Christensen.
3623
3624         URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
3625         Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
3626         Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
3627         would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
3628         parse an arbitrary string that looks like a URL.
3629
3630         Also modernize the code using C++14 idioms.
3631
3632         * WebCoreSupport/WebContextMenuClient.cpp:
3633         (WebContextMenuClient::searchWithGoogle):
3634
3635 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
3636
3637         [Win] WebKit shouldn't include the forwarding header of WebKit itself
3638         https://bugs.webkit.org/show_bug.cgi?id=173352
3639
3640         Reviewed by Alex Christensen.
3641
3642         * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
3643
3644 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
3645
3646         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
3647         https://bugs.webkit.org/show_bug.cgi?id=173318
3648
3649         Reviewed by Darin Adler.
3650
3651         The logical frame size is currently calculated by scaling the frame size in pixels,
3652         and rounding the coordinates to the nearest integers. The computed logical frame
3653         size will in some cases be smaller than the scaled frame size in pixels, since it is
3654         represented as an IntSize. In these cases, the bottom line will not be painted.
3655         Instead of calculating the logical frame size by rounding the scaled frame in
3656         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
3657
3658         * WebCoreSupport/WebFrameLoaderClient.cpp:
3659         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3660
3661 2017-06-13  Daniel Bates  <dabates@apple.com>
3662
3663         Implement W3C Secure Contexts Draft Specification
3664         https://bugs.webkit.org/show_bug.cgi?id=158121
3665         <rdar://problem/26012994>
3666
3667         Reviewed by Brent Fulgham.
3668
3669         Part 4
3670
3671         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3672
3673         * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
3674         * WebPreferenceKeysPrivate.h:
3675         * WebPreferences.cpp:
3676         (WebPreferences::initializeDefaultSettings):
3677         (WebPreferences::QueryInterface):
3678         (WebPreferences::setIsSecureContextAttributeEnabled):
3679         (WebPreferences::isSecureContextAttributeEnabled):
3680         * WebPreferences.h:
3681         * WebView.cpp:
3682         (WebView::notifyPreferencesChanged):
3683
3684 2017-06-13  Per Arne Vollan  <pvollan@apple.com>
3685
3686         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
3687         https://bugs.webkit.org/show_bug.cgi?id=173318
3688
3689         Reviewed by Alex Christensen.
3690
3691         The logical frame size is currently calculated by scaling the frame size in pixels,
3692         and rounding the coordinates to the nearest integers. The computed logical frame
3693         size will in some cases be smaller than the scaled frame size in pixels, since it is
3694         represented as an IntSize. In these cases, the bottom line will not be painted.
3695         Instead of calculating the logical frame size by rounding the scaled frame in
3696         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
3697  
3698         * WebView.cpp:
3699         (WebView::sizeChanged):
3700
3701 2017-06-13  Sam Weinig  <sam@webkit.org>
3702
3703         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
3704         https://bugs.webkit.org/show_bug.cgi?id=80733
3705
3706         Reviewed by Chris Dumez.
3707
3708         * WebFrame.cpp:
3709         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
3710
3711 2017-06-12  Daewoong Jang  <daewoong.jang@navercorp.com>
3712
3713         Remove WebCore::unloadModule and related data types
3714         https://bugs.webkit.org/show_bug.cgi?id=173231
3715
3716         Reviewed by Darin Adler.
3717
3718         * Plugins/PlatformModule.h: Added.
3719         (WebCore::PlatformModuleVersion::PlatformModuleVersion):
3720         * Plugins/PluginPackage.cpp:
3721         (WebCore::PluginPackage::freeLibraryTimerFired):
3722         * Plugins/PluginPackage.h:
3723
3724 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3725
3726         [iOS DnD] Add a hook to perform two-step drops in editable content
3727         https://bugs.webkit.org/show_bug.cgi?id=172992
3728         <rdar://problem/32590174>
3729
3730         Reviewed by Tim Horton.
3731
3732         Add a stub implementation for performTwoStepDrop on Windows.
3733
3734         * WebCoreSupport/WebEditorClient.h:
3735
3736 2017-06-04  Konstantin Tokarev  <annulen@yandex.ru>
3737
3738         Fix build of Windows-specific code with ICU 59.1
3739         https://bugs.webkit.org/show_bug.cgi?id=172729
3740
3741         Reviewed by Darin Adler.
3742
3743         Fix conversions from WTF::String to wchar_t* and vice versa.
3744
3745         * Plugins/PluginDatabaseWin.cpp:
3746         (WebCore::addPluginPathsFromRegistry):
3747         (WebCore::PluginDatabase::getPluginPathsInDirectories):
3748         (WebCore::addMozillaPluginDirectories):
3749         (WebCore::addWindowsMediaPlayerPluginDirectory):
3750         (WebCore::addAdobeAcrobatPluginDirectory):
3751         (WebCore::addJavaPluginDirectory):
3752         (WebCore::safariPluginsDirectory):
3753         (WebCore::addMacromediaPluginDirectories):
3754         * Plugins/PluginPackageWin.cpp:
3755         (WebCore::getVersionInfo):
3756         (WebCore::PluginPackage::fetchInfo):
3757         (WebCore::PluginPackage::load):
3758         * Plugins/PluginViewWin.cpp:
3759         (WebCore::PluginView::handlePostReadFile):
3760
3761 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
3762
3763         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
3764         https://bugs.webkit.org/show_bug.cgi?id=172709
3765
3766         Reviewed by Brent Fulgham.
3767
3768         Add method to exit fullscreen mode.
3769
3770         * Interfaces/IWebViewPrivate.idl:
3771         * WebView.cpp:
3772         (WebView::exitFullscreenIfNeeded):
3773         * WebView.h:
3774
3775 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
3776
3777         [Win] Create unique network storage session for each DRT.
3778         https://bugs.webkit.org/show_bug.cgi?id=172540
3779
3780         Reviewed by Brent Fulgham.
3781
3782         During layout testing, each DRT instance should have its own network storage session.
3783
3784         * Interfaces/IWebPreferencesPrivate.idl:
3785         * WebPreferences.cpp:
3786         (WebPreferences::switchNetworkLoaderToNewTestingSession):
3787         * WebPreferences.h:
3788
3789 2017-05-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3790
3791         [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
3792         https://bugs.webkit.org/show_bug.cgi?id=172535
3793
3794         Reviewed by Konstantin Tokarev.
3795
3796         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3797         (AcceleratedCompositingContext::paintContents): Append the fifth argument.
3798         * WebCoreSupport/AcceleratedCompositingContext.h: Ditto.
3799
3800 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
3801
3802         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
3803         https://bugs.webkit.org/show_bug.cgi?id=172071
3804
3805         Reviewed by Alexey Proskuryakov.
3806
3807         We need to delete all cookies after each test.
3808
3809         * Interfaces/IWebPreferencesPrivate.idl:
3810         * WebPreferences.cpp:
3811         (WebPreferences::linkPreloadEnabled):
3812         (WebPreferences::clearNetworkLoaderSession):
3813         * WebPreferences.h:
3814
3815 2017-05-13  Chris Dumez  <cdumez@apple.com>
3816
3817         Stop using RefPtr::release()
3818         https://bugs.webkit.org/show_bug.cgi?id=172074
3819
3820         Reviewed by Geoffrey Garen.
3821
3822         * WebFrame.cpp:
3823         (WebFrame::loadPlainTextString):
3824         (WebFrame::loadHTMLString):
3825         * WebFramePolicyListener.cpp:
3826         (WebFramePolicyListener::receivedPolicyDecision):
3827
3828 2017-05-13  Chris Dumez  <cdumez@apple.com>
3829
3830         Drop uses of PassRefPtr in WebKit/win
3831         https://bugs.webkit.org/show_bug.cgi?id=172067
3832
3833         Reviewed by Yusuke Suzuki.
3834
3835         * DOMEventsClasses.cpp:
3836         (DOMEvent::DOMEvent):
3837         (DOMEvent::createInstance):
3838         * DOMEventsClasses.h:
3839         (DOMUIEvent::DOMUIEvent):
3840         (DOMKeyboardEvent::DOMKeyboardEvent):
3841         (DOMMouseEvent::DOMMouseEvent):
3842         (DOMMutationEvent::DOMMutationEvent):
3843         (DOMOverflowEvent::DOMOverflowEvent):
3844         (DOMWheelEvent::DOMWheelEvent):
3845         * MemoryStream.cpp:
3846         (MemoryStream::MemoryStream):
3847         (MemoryStream::createInstance):
3848         * MemoryStream.h:
3849         * Plugins/PluginDatabase.cpp:
3850         (WebCore::PluginDatabase::refresh):
3851         (WebCore::PluginDatabase::add):
3852         (WebCore::PluginDatabase::loadPersistentMetadataCache):
3853         * Plugins/PluginDatabase.h:
3854         * Plugins/PluginPackage.cpp:
3855         (WebCore::PluginPackage::createPackage):
3856         (WebCore::PluginPackage::createPackageFromCache):
3857         * Plugins/PluginPackage.h:
3858         * Plugins/PluginStream.h:
3859         (WebCore::PluginStream::create):
3860         * WebActionPropertyBag.cpp:
3861         (WebActionPropertyBag::WebActionPropertyBag):
3862         (WebActionPropertyBag::createInstance):
3863         * WebActionPropertyBag.h:
3864         * WebArchive.cpp:
3865         (WebArchive::createInstance):
3866         (WebArchive::WebArchive):
3867         * WebArchive.h:
3868         * WebBackForwardList.cpp:
3869         (WebBackForwardList::WebBackForwardList):
3870         (WebBackForwardList::createInstance):
3871         * WebBackForwardList.h:
3872         * WebCoreSupport/EmbeddedWidget.cpp:
3873         (EmbeddedWidget::create):
3874         * WebCoreSupport/EmbeddedWidget.h:
3875         * WebCoreSupport/WebChromeClient.h:
3876         * WebFrame.cpp:
3877         (WebFrame::loadData):
3878         (WebFrame::createSubframeWithOwnerElement):
3879         * WebFrame.h:
3880         * WebFramePolicyListener.cpp:
3881         (WebFramePolicyListener::WebFramePolicyListener):
3882         (WebFramePolicyListener::createInstance):
3883         * WebFramePolicyListener.h:
3884         * WebGeolocationPolicyListener.cpp:
3885         (WebGeolocationPolicyListener::createInstance):
3886         (WebGeolocationPolicyListener::WebGeolocationPolicyListener):
3887         * WebGeolocationPolicyListener.h:
3888         * WebHistoryItem.cpp:
3889         (WebHistoryItem::WebHistoryItem):
3890         (WebHistoryItem::createInstance):
3891         * WebHistoryItem.h:
3892         * WebMutableURLRequest.cpp:
3893         (WebMutableURLRequest::setFormData):
3894         (WebMutableURLRequest::formData):
3895         * WebMutableURLRequest.h:
3896         * WebResource.cpp:
3897         (WebResource::createInstance):
3898         * WebResource.h:
3899         * WebScriptWorld.cpp:
3900         (WebScriptWorld::WebScriptWorld):
3901         (WebScriptWorld::createInstance):
3902         * WebScriptWorld.h:
3903         * WebURLAuthenticationChallengeSender.cpp:
3904         (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
3905         (WebURLAuthenticationChallengeSender::createInstance):
3906         * WebURLAuthenticationChallengeSender.h:
3907         * WebView.cpp:
3908         (WebView::setFullScreenElement):
3909         * WebView.h:
3910
3911 2017-05-11  Chris Dumez  <cdumez@apple.com>
3912
3913         Drop remaining uses of PassRefPtr in WebCore
3914         https://bugs.webkit.org/show_bug.cgi?id=172013
3915
3916         Reviewed by Yusuke Suzuki.
3917
3918         * Plugins/PluginView.cpp:
3919         (WebCore::PluginView::bindingInstance):
3920
3921 2017-05-11  Chris Dumez  <cdumez@apple.com>
3922
3923         Stop using PassRefPtr in platform/graphics
3924         https://bugs.webkit.org/show_bug.cgi?id=171977
3925
3926         Reviewed by Alex Christensen.
3927
3928         Build fix.
3929
3930         * FullscreenVideoController.cpp:
3931         (FullscreenVideoController::enterFullscreen):
3932         * WebKitDLL.cpp:
3933         (loadResourceIntoBuffer):
3934
3935 2017-05-09  Sam Weinig  <sam@webkit.org>
3936
3937         Remove support for legacy Notifications
3938         https://bugs.webkit.org/show_bug.cgi?id=171487
3939
3940         Reviewed by Jon Lee.
3941
3942         * WebCoreSupport/WebChromeClient.cpp:
3943         (WebChromeClient::WebChromeClient):
3944         * WebCoreSupport/WebChromeClient.h:
3945         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
3946         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
3947         Remove legacy notification specific code.
3948
3949 2017-05-09  Dean Jackson  <dino@apple.com>
3950
3951         Fix Windows build.
3952
3953         * Plugins/PluginView.h:
3954         * Plugins/PluginViewWin.cpp:
3955         (WebCore::PluginView::paint):
3956
3957 2017-05-06  Alexey Proskuryakov  <ap@apple.com>
3958
3959         REGRESSION (r216294): The new test fails on WebKit1
3960         https://bugs.webkit.org/show_bug.cgi?id=171780
3961
3962         Rolling back https://trac.webkit.org/r216294, https://trac.webkit.org/r216296,
3963         https://trac.webkit.org/216299, https://trac.webkit.org/216330
3964
3965         * Plugins/PluginView.h:
3966         * Plugins/PluginViewWin.cpp:
3967         (WebCore::PluginView::paint):
3968
3969 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
3970
3971         Fix Windows build after r216294.
3972
3973         * Plugins/PluginView.h:
3974         * Plugins/PluginViewWin.cpp:
3975         (WebCore::PluginView::paint):
3976
3977 2017-05-04  Commit Queue  <commit-queue@webkit.org>
3978
3979         Unreviewed, rolling out r216206.
3980         https://bugs.webkit.org/show_bug.cgi?id=171714
3981
3982         Multiple LayoutTests crashing in Document::page() (Requested
3983         by ap on #webkit).
3984
3985         Reverted changeset:
3986
3987         "Remove support for legacy Notifications"
3988         https://bugs.webkit.org/show_bug.cgi?id=171487
3989         http://trac.webkit.org/changeset/216206
3990
3991 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
3992
3993         [Win] Remove redundant macros that are set in the CMake config
3994         https://bugs.webkit.org/show_bug.cgi?id=171571
3995
3996         Reviewed by Brent Fulgham.
3997
3998         * COMEnumVariant.h:
3999         * COMPropertyBag.h:
4000         * WebKitPrefix.h:
4001
4002 2017-05-04  Sam Weinig  <sam@webkit.org>
4003
4004         Remove support for legacy Notifications
4005         https://bugs.webkit.org/show_bug.cgi?id=171487
4006
4007         Reviewed by Jon Lee.
4008
4009         * WebCoreSupport/WebChromeClient.cpp:
4010         (WebChromeClient::WebChromeClient):
4011         * WebCoreSupport/WebChromeClient.h:
4012         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
4013         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
4014         Remove legacy notification specific code.
4015
4016 2017-04-27  Alex Christensen  <achristensen@webkit.org>
4017
4018         Modernize Frame.h
4019         https://bugs.webkit.org/show_bug.cgi?id=171357
4020
4021         Reviewed by Andy Estes.
4022
4023         * WebCoreSupport/WebEditorClient.cpp:
4024         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
4025         * WebCoreSupport/WebEditorClient.h:
4026
4027 2017-04-20  Fujii Hironori  <Hironori.Fujii@sony.com>
4028
4029         [WinCairo] Fix build break after updating ANGLE
4030         https://bugs.webkit.org/show_bug.cgi?id=170980
4031
4032         Reviewed by Brent Fulgham.
4033
4034         * WebCoreSupport/AcceleratedCompositingContext.cpp: Define GL_GLEXT_PROTOTYPES.
4035
4036 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
4037
4038         [Win] REGRESSION(r215486): Windows Release build is broken
4039         https://bugs.webkit.org/show_bug.cgi?id=171024
4040         <rdar://problem/31722618>
4041
4042         Reviewed by Mark Lam.
4043
4044         Windows WebKit refers to a handful of JSC methods that are always
4045         inline. We need to include 'HeapInlines.h' to get the implementation
4046         of these methods.
4047
4048         * Plugins/PluginPackage.cpp:
4049         * WebFrame.cpp:
4050         * WebView.cpp:
4051
4052 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4053
4054         Unreviewed, fix the Windows build after r215385
4055
4056         r215385 introduced a new virtual method on ChromeClient that needs to be implemented in WebChromeClient for
4057         Windows in WebKit1.
4058
4059         * WebCoreSupport/WebChromeClient.cpp:
4060         (WebChromeClient::createIconForFiles):
4061         * WebCoreSupport/WebChromeClient.h:
4062
4063 2017-04-10  Chris Dumez  <cdumez@apple.com>
4064
4065         Drop Timer::startOneShot() overload taking a double
4066         https://bugs.webkit.org/show_bug.cgi?id=170659
4067
4068         Reviewed by Yusuke Suzuki.
4069
4070         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
4071
4072         * Plugins/PluginMessageThrottlerWin.cpp:
4073         (WebCore::PluginMessageThrottlerWin::appendMessage):
4074         (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
4075         * Plugins/PluginViewWin.cpp:
4076         (WebCore::PluginView::invalidateRect):
4077         * WebCoreSupport/AcceleratedCompositingContext.cpp:
4078         (AcceleratedCompositingContext::scheduleLayerFlush):
4079
4080 2017-04-09  Chris Dumez  <cdumez@apple.com>
4081
4082         Drop Timer::startRepeating() overload taking a double
4083         https://bugs.webkit.org/show_bug.cgi?id=170656
4084
4085         Reviewed by Yusuke Suzuki.
4086
4087         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
4088
4089         * FullscreenVideoController.cpp:
4090
4091 2017-04-09  Chris Dumez  <cdumez@apple.com>
4092
4093         Start dropping Timer API dealing with double
4094         https://bugs.webkit.org/show_bug.cgi?id=170649
4095
4096         Reviewed by Yusuke Suzuki.
4097
4098         Start dropping Timer API dealing with double as people should use Seconds now.
4099
4100         * Plugins/PluginPackage.cpp:
4101         (WebCore::PluginPackage::freeLibrarySoon):
4102         * Plugins/PluginStream.cpp:
4103         (WebCore::PluginStream::deliverData):
4104         * Plugins/PluginView.cpp:
4105         (WebCore::PluginView::requestTimerFired):
4106         (WebCore::PluginView::scheduleRequest):
4107         (WebCore::PluginView::setJavaScriptPaused):
4108         (WebCore::PluginView::keepAlive):
4109         * Plugins/PluginViewWin.cpp:
4110         (WebCore::PluginView::wndProc):
4111         * WebView.cpp:
4112         (WebView::closeWindowSoon):
4113
4114 2017-04-08  Chris Dumez  <cdumez@apple.com>
4115
4116         Drop std::chrono support from Timer class
4117         https://bugs.webkit.org/show_bug.cgi?id=170645
4118
4119         Reviewed by Sam Weinig.
4120
4121         Drop std::chrono support from Timer class now that we prefer using Seconds type.
4122
4123         * WebView.cpp:
4124         (WebView::setCacheModel):
4125
4126 2017-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
4127
4128         [WinCairo] WebCore::PlatformDisplay::terminateEGLDisplay causes a crash in libGLESv2.dll while processing atexit
4129         https://bugs.webkit.org/show_bug.cgi?id=170331
4130
4131         Reviewed by Michael Catanzaro.
4132
4133         * WebKitDLL.cpp:
4134         (shutDownWebKit): Call PlatformDisplay::shutDownEglDisplays in shutDownWebKit.
4135
4136 2017-03-30  James Craig  <jcraig@apple.com>
4137
4138         AX: Expose a new AXSubrole for explicit ARIA "group" role
4139         https://bugs.webkit.org/show_bug.cgi?id=169810
4140         <rdar://problem/31039693>
4141
4142         Reviewed by Chris Fleizach.
4143
4144         Account for Windows platform role mapping.
4145
4146         * AccessibleBase.cpp:
4147         (MSAARole):
4148
4149 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
4150
4151         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
4152         https://bugs.webkit.org/show_bug.cgi?id=169168