f51e0442e56bf723a01b30de88fbc81583184409
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2019-08-12  Youenn Fablet  <youenn@apple.com>
2
3         Remove IDB-specific quota
4         https://bugs.webkit.org/show_bug.cgi?id=196545
5
6         Reviewed by Alex Christensen.
7
8         * Interfaces/IWebDatabaseManager.idl:
9         * WebDatabaseManager.cpp:
10         (WebDatabaseManager::setIDBPerOriginQuota): Deleted.
11         * WebDatabaseManager.h:
12
13 2019-08-09  Per Arne Vollan  <pvollan@apple.com>
14
15         [Win] Remove compiler workaround for VS2013
16         https://bugs.webkit.org/show_bug.cgi?id=200582
17
18         Reviewed by Don Olmstead.
19
20         A VS2013 compiler workaround can be removed now.
21
22         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp:
23         (DllMain):
24
25 2019-08-08  Per Arne Vollan  <pvollan@apple.com>
26
27         [Win] Fix internal build
28         https://bugs.webkit.org/show_bug.cgi?id=200519
29
30         Reviewed by Alex Christensen.
31
32         Switch to the String::wideCharacers method, since its return type is compatible with the Win32 api.
33
34         * WebDownloadCFNet.cpp:
35         (WebDownload::didFinish):
36
37 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
38
39         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
40         https://bugs.webkit.org/show_bug.cgi?id=200539
41         <rdar://problem/54082550>
42
43         Reviewed by Dean Jackson.
44
45         * AccessibleBase.cpp:
46         (AccessibleBase::get_locale):
47         * CFDictionaryPropertyBag.cpp:
48         (ConvertCFTypeToVariant):
49         (CFDictionaryPropertyBag::Read):
50         (CFDictionaryPropertyBag::Write):
51         * CFDictionaryPropertyBag.h:
52         * COMPropertyBag.h:
53         (HashType>::Read):
54         (HashType>::GetPropertyInfo):
55         * MarshallingHelpers.cpp:
56         * MarshallingHelpers.h:
57         * WebApplicationCache.cpp:
58         * WebArchive.cpp:
59         * WebArchive.h:
60         * WebCache.cpp:
61         * WebCoreSupport/WebFrameLoaderClient.cpp:
62         * WebDatabaseManager.cpp:
63         * WebHistory.cpp:
64         * WebHistoryItem.cpp:
65         * WebKitCOMAPI.cpp:
66         * WebKitCOMAPI.h:
67         * WebKitDLL.cpp:
68         * WebLocalizableStrings.cpp:
69         * WebLocalizableStrings.h:
70         * WebMutableURLRequest.cpp:
71         * WebPreferences.cpp:
72         * WebPreferences.h:
73         * WebView.cpp:
74         * WebView.h:
75
76 2019-08-08  Rob Buis  <rbuis@igalia.com>
77
78         Add runtime flag for lazy image loading
79         https://bugs.webkit.org/show_bug.cgi?id=199794
80
81         Reviewed by Darin Adler.
82
83         Set lazyImageLoading runtime flag if preference is set.
84
85         * Interfaces/IWebPreferencesPrivate.idl:
86         * WebPreferenceKeysPrivate.h:
87         * WebPreferences.cpp:
88         (WebPreferences::initializeDefaultSettings):
89         (WebPreferences::lazyImageLoadingEnabled):
90         (WebPreferences::setLazyImageLoadingEnabled):
91         * WebPreferences.h:
92         * WebView.cpp:
93         (WebView::notifyPreferencesChanged):
94
95 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
96
97         [Win][WK1] Can't change Web Inspector frontend height in high DPI
98         https://bugs.webkit.org/show_bug.cgi?id=200153
99
100         Reviewed by Don Olmstead.
101
102         * WebCoreSupport/WebInspectorClient.cpp:
103         (WebInspectorFrontendClient::setAttachedWindowHeight):
104         Applied deviceScaleFactor to the argument height.
105
106 2019-07-26  Konstantin Tokarev  <annulen@yandex.ru>
107
108         [Win] Remove unused methods from WebPluginInfoProvider
109         https://bugs.webkit.org/show_bug.cgi?id=200178
110
111         Reviewed by Brent Fulgham.
112
113         These methods are guarded with PLATFORM(MAC) and have no definitions.
114         Also remove unused friend declaration.
115
116         * WebCoreSupport/WebPluginInfoProvider.h:
117
118 2019-07-25  Fujii Hironori  <Hironori.Fujii@sony.com>
119
120         [Win][WK1] The inspected webview window is misplaced after changing Web Inspector frontend window height
121         https://bugs.webkit.org/show_bug.cgi?id=200152
122
123         Reviewed by Brent Fulgham.
124
125         In WebInspectorFrontendClient::setAttachedWindowHeight, the size
126         of m_inspectedWebViewHwnd was changed to the whole host window
127         size. But, it's too tall because MiniBrowser's host window has a
128         toolbar. The toolbar height should be taken into account.
129
130         Change to the height of m_inspectedWebViewHwnd to the sum of
131         inspected WebView and inspector frontend WebView heights.
132
133         * WebCoreSupport/WebInspectorClient.cpp:
134         (WebInspectorFrontendClient::setAttachedWindowHeight):
135
136 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
137
138         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
139         https://bugs.webkit.org/show_bug.cgi?id=200021
140         <rdar://problem/53301325>
141
142         Reviewed by Ryosuke Niwa.
143
144         Implement a new editing client hook.
145
146         * WebCoreSupport/WebEditorClient.h:
147
148 2019-07-13  Zalan Bujtas  <zalan@apple.com>
149
150         Cannot bring up custom media controls at all on v.youku.com
151         https://bugs.webkit.org/show_bug.cgi?id=199699
152         <rdar://problem/51835327>
153
154         Reviewed by Simon Fraser.
155
156         * WebActionPropertyBag.cpp:
157         (WebActionPropertyBag::Read):
158         * WebView.cpp:
159         (WebView::handleContextMenuEvent):
160         (WebView::elementAtPoint):
161
162 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
163
164         [WinCairo] ASSERTION FAILED: info.bmBitsPixel == 32 in createCairoContextWithHDC
165         https://bugs.webkit.org/show_bug.cgi?id=198323
166
167         Reviewed by Per Arne Vollan.
168
169         WebView::paint binds m_backingStoreBitmap to a DC by using
170         SelectObject. WebView::paint can be called recursively, but
171         m_backingStoreBitmap can't be bound to multiple DCs at the same
172         time. Then, SelectObject was failing in such case.
173
174         Call WebCore::Page::updateRendering before binding
175         m_backingStoreBitmap instead of after it.
176
177         Reverted r202744 change which won't be needed since this change.
178
179         * WebView.cpp:
180         (WebView::scrollBackingStore): Removed r202744's change.
181         (WebView::updateBackingStore): Removed m_page->updateRendering().
182         (WebView::paint): Do m_page->updateRendering() before binding m_backingStoreBitmap.
183         * WebView.h: Removed unused WebView::isPainting.
184
185 2019-07-02  Devin Rousso  <drousso@apple.com>
186
187         Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
188         https://bugs.webkit.org/show_bug.cgi?id=198956
189
190         Reviewed by Matt Baker.
191
192         * WebCoreSupport/WebInspectorClient.h:
193         * WebCoreSupport/WebInspectorClient.cpp:
194         (WebInspectorFrontendClient::resetWindowState): Added.
195
196 2019-06-30  Fujii Hironori  <Hironori.Fujii@sony.com>
197
198         [Win] Multiline mode of tooltip control does word-wrapping very slowly
199         https://bugs.webkit.org/show_bug.cgi?id=198989
200
201         Reviewed by Ross Kirsling.
202
203         * WebView.cpp:
204         (truncatedString): Added.
205         (WebView::setToolTip): Use truncatedString.
206
207 2019-06-16  Darin Adler  <darin@apple.com>
208
209         Rename AtomicString to AtomString
210         https://bugs.webkit.org/show_bug.cgi?id=195276
211
212         Reviewed by Michael Catanzaro.
213
214         * many files: Let do-webcore-rename do the renaming.
215
216 2019-05-31  Don Olmstead  <don.olmstead@sony.com>
217
218         [CMake] Add WebKit::WTF target
219         https://bugs.webkit.org/show_bug.cgi?id=198400
220
221         Reviewed by Konstantin Tokarev.
222
223         Use the WebKit::WTF target.
224
225         * WebKitQuartzCoreAdditions/CMakeLists.txt:
226
227 2019-05-30  Simon Fraser  <simon.fraser@apple.com>
228
229         Use an OptionSet<> for GraphicsLayerPaintingPhase
230         https://bugs.webkit.org/show_bug.cgi?id=198404
231
232         Reviewed by Tim Horton.
233
234         Replace GraphicsLayerPaintingPhase with OptionSet<GraphicsLayerPaintingPhase>.
235
236         No behavior change.
237
238         * WebCoreSupport/AcceleratedCompositingContext.cpp:
239         (AcceleratedCompositingContext::paintContents):
240         * WebCoreSupport/AcceleratedCompositingContext.h:
241         * WebView.cpp:
242         (WebView::paintContents):
243         * WebView.h:
244
245 2019-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
246
247         [iOS] Dropped text, attachments, and images should animate into place
248         https://bugs.webkit.org/show_bug.cgi?id=198243
249         <rdar://problem/35205373>
250
251         Reviewed by Tim Horton.
252
253         * WebCoreSupport/WebChromeClient.cpp:
254         (WebChromeClient::didFinishLoadingImageForElement):
255         * WebCoreSupport/WebChromeClient.h:
256
257 2019-05-03  Daniel Bates  <dabates@apple.com>
258
259         Pass KeyboardEvent by reference in more places
260         https://bugs.webkit.org/show_bug.cgi?id=197480
261
262         Reviewed by Wenson Hsieh.
263
264         * WebCoreSupport/WebEditorClient.cpp:
265         (WebEditorClient::handleKeyboardEvent):
266         (WebEditorClient::handleInputMethodKeydown):
267         * WebCoreSupport/WebEditorClient.h:
268         * WebView.cpp:
269         (WebView::handleEditingKeyboardEvent):
270         * WebView.h:
271
272 2019-05-02  Frederic Wang  <fwang@igalia.com>
273
274         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
275         https://bugs.webkit.org/show_bug.cgi?id=196142
276
277         This patch introduces some experimental runtime flag to let users
278         disable MathML features that are removed from MathML Core [1]. For now,
279         these features are only disabled on GTK and WPE ports.
280
281         [1] https://mathml-refresh.github.io/mathml-core/
282
283         Reviewed by Rob Buis.
284
285         * Interfaces/IWebPreferencesPrivate.idl:
286         * WebPreferenceKeysPrivate.h:
287         * WebPreferences.cpp:
288         (WebPreferences::initializeDefaultSettings):
289         (WebPreferences::coreMathMLEnabled):
290         (WebPreferences::setCoreMathMLEnabled):
291         * WebPreferences.h:
292         * WebView.cpp:
293         (WebView::notifyPreferencesChanged):
294
295 2019-04-24  Zalan Bujtas  <zalan@apple.com>
296
297         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
298         https://bugs.webkit.org/show_bug.cgi?id=196948
299         <rdar://problem/49927131>
300
301         Reviewed by Tim Horton.
302
303         * WebCoreSupport/WebChromeClient.cpp:
304         (WebChromeClient::intrinsicContentsSizeChanged const):
305         * WebCoreSupport/WebChromeClient.h:
306
307 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
308
309         Make it possible to control the renderTreeAsText output by setting options on testRunner
310         https://bugs.webkit.org/show_bug.cgi?id=197133
311
312         Reviewed by Sam Weinig.
313
314         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
315         that make sense in testing (those that don't dump unstable data like addresses), and plumb
316         these flags through the various framework layers.
317
318         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
319
320         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
321         and hand-code DumpRenderTree bindings.
322
323         Some cleanup of the TestRunners, using member initializers.
324
325         * Interfaces/IWebFramePrivate.idl:
326         * WebFrame.cpp:
327         (toRenderAsTextFlags):
328         (WebFrame::renderTreeAsExternalRepresentation):
329         (WebFrame::renderTreeAsExternalRepresentationForPrinting):
330         * WebFrame.h:
331
332 2019-04-23  Chris Dumez  <cdumez@apple.com>
333
334         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
335         https://bugs.webkit.org/show_bug.cgi?id=197097
336         <rdar://problem/50048318>
337
338         Reviewed by Alex Christensen.
339
340         * WebCoreSupport/WebFrameLoaderClient.cpp:
341         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
342         * WebCoreSupport/WebFrameLoaderClient.h:
343
344 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
345
346         [CMake][Win] Use target oriented design for WebKitLegacy
347         https://bugs.webkit.org/show_bug.cgi?id=197112
348
349         Reviewed by Konstantin Tokarev.
350
351         Fix an include directory.
352
353         * WebKitQuartzCoreAdditions/CMakeLists.txt:
354
355 2019-04-18  Jer Noble  <jer.noble@apple.com>
356
357         Refactoring: Pull all fullscreen code out of Document and into its own helper class
358         https://bugs.webkit.org/show_bug.cgi?id=197017
359
360         Reviewed by Eric Carlson.
361
362         * WebCoreSupport/WebChromeClient.cpp:
363         (WebChromeClient::createWindow):
364         * WebView.cpp:
365         (WebView::fullScreenClientWillEnterFullScreen):
366         (WebView::fullScreenClientDidEnterFullScreen):
367         (WebView::fullScreenClientWillExitFullScreen):
368         (WebView::fullScreenClientDidExitFullScreen):
369
370 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
371
372         requestAnimationFrame should execute before the next frame
373         https://bugs.webkit.org/show_bug.cgi?id=177484
374
375         Reviewed by Simon Fraser.
376
377         * WebView.cpp:
378         (WebView::updateBackingStore):
379         (WebView::flushPendingGraphicsLayerChangesSoon):
380         (WebView::flushPendingGraphicsLayerChanges):
381         Call Page::updateRendering() which implements "Update the rendering"
382         step of the HTML Event Loop specification.
383
384 2019-04-10  Devin Rousso  <drousso@apple.com>
385
386         Web Inspector: save sheet should be anchored underneath the tab bar when detached
387         https://bugs.webkit.org/show_bug.cgi?id=196722
388         <rdar://problem/49613280>
389
390         Reviewed by Timothy Hatcher.
391
392         * WebCoreSupport/WebInspectorClient.h:
393         * WebCoreSupport/WebInspectorClient.cpp:
394         (WebInspectorFrontendClient::setSheetRect): Added.
395
396 2019-04-10  Alex Christensen  <achristensen@webkit.org>
397
398         Add SPI WKNavigationResponse._downloadAttribute
399         https://bugs.webkit.org/show_bug.cgi?id=196755
400         <rdar://49587365>
401
402         Reviewed by Brady Eidson.
403
404         * WebCoreSupport/WebFrameLoaderClient.cpp:
405         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
406         * WebCoreSupport/WebFrameLoaderClient.h:
407
408 2019-04-05  Commit Queue  <commit-queue@webkit.org>
409
410         Unreviewed, rolling out r243833.
411         https://bugs.webkit.org/show_bug.cgi?id=196645
412
413         This change breaks build of WPE and GTK ports (Requested by
414         annulen on #webkit).
415
416         Reverted changeset:
417
418         "[CMake][WTF] Mirror XCode header directories"
419         https://bugs.webkit.org/show_bug.cgi?id=191662
420         https://trac.webkit.org/changeset/243833
421
422 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
423
424         [CMake][WTF] Mirror XCode header directories
425         https://bugs.webkit.org/show_bug.cgi?id=191662
426
427         Reviewed by Konstantin Tokarev.
428
429         * WebKitQuartzCoreAdditions/CMakeLists.txt:
430
431 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
432
433         Implement ResizeObserver.
434         https://bugs.webkit.org/show_bug.cgi?id=157743
435
436         Reviewed by Simon Fraser.
437
438         * Interfaces/IWebPreferencesPrivate.idl:
439         * WebPreferenceKeysPrivate.h:
440         * WebPreferences.cpp:
441         (WebPreferences::initializeDefaultSettings):
442         (WebPreferences::resizeObserverEnabled):
443         (WebPreferences::setResizeObserverEnabled):
444         * WebPreferences.h:
445         * WebView.cpp:
446         (WebView::notifyPreferencesChanged):
447
448 2019-03-17  Fujii Hironori  <Hironori.Fujii@sony.com>
449
450         [Win][WK1] Null dereference in WebFrameNetworkingContext::storageSession
451         https://bugs.webkit.org/show_bug.cgi?id=195741
452
453         Reviewed by Ross Kirsling.
454
455         * WebCoreSupport/WebFrameNetworkingContext.cpp:
456         (WebFrameNetworkingContext::storageSession const): Added a null check of frame()->page() as well as Mac port does (Bug 183455).
457
458 2019-03-13  Ryan Haddad  <ryanhaddad@apple.com>
459
460         Unreviewed attempt to fix the Windows build after r242920.
461
462         * WebCoreSupport/WebFrameLoaderClient.h:
463
464 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
465
466         [Win] Fix a slew of simple clang-cl warnings.
467         https://bugs.webkit.org/show_bug.cgi?id=195652
468
469         Reviewed by Don Olmstead.
470
471         * Interfaces/AccessibleComparable.idl: -Wmissing-braces
472         * Plugins/PluginDatabaseWin.cpp: -Wunused-function
473         (WebCore::addJavaPluginDirectory): Deleted.
474         * WebCoreSupport/AcceleratedCompositingContext.cpp:
475         (AcceleratedCompositingContext::AcceleratedCompositingContext): -Wreorder
476         * WebCoreSupport/WebEditorClient.cpp:
477         (WebEditorUndoCommand::WebEditorUndoCommand): -Wreorder
478         (undoNameForEditAction): -Wswitch
479         * WebCoreSupport/WebFrameLoaderClient.cpp:
480         (WebFrameLoaderClient::WebFrameLoaderClient): -Wswitch
481         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): -Wunused-variable
482         * WebCoreSupport/WebInspectorClient.cpp:
483         (WebInspectorFrontendClient::WebInspectorFrontendClient): -Wreorder
484         * WebCoreSupport/WebInspectorClient.h: -Winconsistent-missing-override
485         * WebError.cpp:
486         (WebError::WebError): -Wreorder
487         * WebFrame.cpp:
488         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): -Wlogical-op-parentheses
489         * WebHistory.cpp: -Wunused-function (x5)
490         (areEqualOrClose): Deleted.
491         (addDayToSystemTime): Deleted.
492         (getDayBoundaries): Deleted.
493         (beginningOfDay): Deleted.
494         (dateKey): Deleted.
495         * WebNotificationCenter.cpp:
496         (WebNotificationCenter::removeObserver): -Wunused-variable
497         * WebView.cpp: -Wunused-function, -Wreorder
498         (WebView::addVisitedLinks): -Wunused-variable
499
500 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
501
502         Unreviewed, rolling out r242688, r242643, r242624.
503
504         Caused multiple layout test failures and crashes on iOS and macOS.
505
506         Reverted changeset:
507
508         "requestAnimationFrame should execute before the next frame"
509         https://bugs.webkit.org/show_bug.cgi?id=177484
510         https://trac.webkit.org/changeset/242624/webkit
511
512         * WebView.cpp:
513         (WebView::updateBackingStore):
514         (WebView::flushPendingGraphicsLayerChangesSoon):
515         (WebView::flushPendingGraphicsLayerChanges):
516
517 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
518
519         requestAnimationFrame should execute before the next frame
520         https://bugs.webkit.org/show_bug.cgi?id=177484
521
522         Reviewed by Simon Fraser.
523
524         * WebView.cpp:
525         (WebView::updateBackingStore):
526         (WebView::flushPendingGraphicsLayerChangesSoon):
527         (WebView::flushPendingGraphicsLayerChanges):
528         Call Page::renderingUpdate() which implements  "Update the rendering"
529         step of the HTML Event Loop specification.
530
531 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
532
533         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
534         https://bugs.webkit.org/show_bug.cgi?id=195346
535
536         Reviewed by Fujii Hironori.
537
538         * COMPropertyBag.h:
539         (HashType>::GetPropertyInfo):
540         (HashType>::LoadObject):
541         * DOMCoreClasses.cpp:
542         (DOMNode::addEventListener):
543         (DOMNode::removeEventListener):
544         (DOMWindow::addEventListener):
545         (DOMWindow::removeEventListener):
546         (DOMElement::font):
547         * DOMHTMLClasses.cpp:
548         (DOMHTMLInputElement::setValueForUser):
549         (DOMHTMLInputElement::replaceCharactersInRange):
550         * Plugins/PluginDatabaseWin.cpp:
551         (WebCore::addPluginPathsFromRegistry):
552         (WebCore::PluginDatabase::getPluginPathsInDirectories const):
553         (WebCore::addMozillaPluginDirectories):
554         (WebCore::addWindowsMediaPlayerPluginDirectory):
555         (WebCore::addAdobeAcrobatPluginDirectory):
556         (WebCore::addJavaPluginDirectory):
557         (WebCore::safariPluginsDirectory):
558         (WebCore::addMacromediaPluginDirectories):
559         * Plugins/PluginPackageWin.cpp:
560         (WebCore::getVersionInfo):
561         (WebCore::PluginPackage::fetchInfo):
562         (WebCore::PluginPackage::load):
563         * Plugins/PluginViewWin.cpp:
564         (WebCore::PluginView::handlePostReadFile):
565         * WebCoreSupport/WebChromeClient.cpp:
566         (WebChromeClient::runOpenPanel):
567         * WebCoreSupport/WebEditorClient.cpp:
568         (WebEditorClient::checkSpellingOfString):
569         (WebEditorClient::checkGrammarOfString):
570         * WebCoreSupport/WebInspectorClient.cpp:
571         (WebInspectorFrontendClient::updateWindowTitle):
572         * WebLocalizableStrings.cpp:
573         (LocalizedString::operator LPCTSTR const):
574         * WebView.cpp:
575         (createContextMenuFromItems):
576         (WebView::setToolTip):
577         Use wchar helpers as needed.
578
579 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
580
581         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
582         https://bugs.webkit.org/show_bug.cgi?id=195053
583         <rdar://problem/48134710>
584
585         Reviewed by Ryosuke Niwa.
586
587         * WebCoreSupport/WebEditorClient.h:
588
589 2019-02-20  Darin Adler  <darin@apple.com>
590
591         Finish removing String::format
592         https://bugs.webkit.org/show_bug.cgi?id=194893
593
594         Reviewed by Daniel Bates.
595
596         * FullscreenVideoController.cpp:
597         (timeToString): Use makeString and pad.
598
599 2019-02-27  Simon Fraser  <simon.fraser@apple.com>
600
601         Roll out r242014; it caused crashes in compositing logging (webkit.org/b/195141)
602
603         * FullscreenVideoController.cpp:
604         (timeToString):
605
606 2019-02-26  Philippe Normand  <pnormand@igalia.com>
607
608         [WPE] Add API for webview background color configuration
609         https://bugs.webkit.org/show_bug.cgi?id=192305
610
611         Reviewed by Michael Catanzaro.
612
613         * WebCoreSupport/WebFrameLoaderClient.cpp:
614         (WebFrameLoaderClient::transitionToCommittedForNewPage): Create
615         FrameView with background color.
616
617 2019-02-20  Darin Adler  <darin@apple.com>
618
619         Finish removing String::format
620         https://bugs.webkit.org/show_bug.cgi?id=194893
621
622         Reviewed by Daniel Bates.
623
624         * FullscreenVideoController.cpp:
625         (timeToString): Use makeString and pad.
626
627 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
628
629         Input type "formatSetInlineTextDirection" is dispatched when changing paragraph-level text direction
630         https://bugs.webkit.org/show_bug.cgi?id=194703
631         <rdar://problem/48111775>
632
633         Reviewed by Ryosuke Niwa.
634
635         * WebCoreSupport/WebEditorClient.cpp:
636         (undoNameForEditAction):
637
638 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
639
640         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
641         https://bugs.webkit.org/show_bug.cgi?id=194670
642         <rdar://problem/39066529>
643
644         Reviewed by Tim Horton.
645
646         * WebCoreSupport/WebEditorClient.cpp:
647         (WebEditorClient::replacementURLForResource): Deleted.
648         * WebCoreSupport/WebEditorClient.h:
649
650 2019-02-10  Darin Adler  <darin@apple.com>
651
652         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
653         https://bugs.webkit.org/show_bug.cgi?id=194487
654
655         Reviewed by Daniel Bates.
656
657         * WebView.cpp:
658         (webKitVersionString): Use makeString instead of String::format.
659
660 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
661
662         Allow pages to trigger programmatic paste from script on iOS
663         https://bugs.webkit.org/show_bug.cgi?id=194271
664         <rdar://problem/47808810>
665
666         Reviewed by Ryosuke Niwa.
667
668         * WebCoreSupport/WebEditorClient.h:
669
670 2019-02-06  Daniel Bates  <dabates@apple.com>
671
672         Standardize on ControlKey instead of CtrlKey
673         https://bugs.webkit.org/show_bug.cgi?id=194317
674
675         Reviewed by Tim Horton.
676
677         * AccessibleBase.cpp:
678         (AccessibleBase::get_accKeyboardShortcut):
679         * WebView.cpp:
680         (WebView::keyDown):
681
682 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
683
684         PageOverlayController's layers should be created lazily
685         https://bugs.webkit.org/show_bug.cgi?id=194199
686         rdar://problem/46571593
687
688         Reviewed by Tim Horton.
689
690         Expose PageOverlayController::hasDocumentOverlays() and hasViewOverlays()
691         and use them to only parent the overlay-hosting layers when necessary.
692
693         For document overlays, RenderLayerCompositor::appendDocumentOverlayLayers() can
694         simply do nothing if there are none. Updates are triggered via Page::installedPageOverlaysChanged(),
695         which calls FrameView::setNeedsCompositingConfigurationUpdate() to trigger the root layer
696         compositing updates that parents the layerWithDocumentOverlays().
697
698         View overlays are added to the layer tree via the DrawingArea. When we go between having
699         none and some view overlays, Page::installedPageOverlaysChanged() calls attachViewOverlayGraphicsLayer()
700         on the ChromeClient, and the DrawingArea responds by calling updateRootLayers() and scheduling a
701         compositing flush (this has to be done manually because view overlay layers are outside the
702         subtree managed by RenderLayerCompositor).
703         
704         Now that GraphicsLayers are ref-counted, we can let the DrawingArea simply retain its m_viewOverlayRootLayer;
705         there is no need for RenderLayerCompositor::attachRootLayer()/detachRootLayer() to do anything with view
706         overlay layers. This implies that a page can navigate (new FrameView) and view overlays will persist, without
707         having to be manually removed and re-added. We can also remove the Frame argument to attachViewOverlayGraphicsLayer().
708
709         * WebCoreSupport/WebChromeClient.cpp:
710         (WebChromeClient::attachViewOverlayGraphicsLayer):
711         * WebCoreSupport/WebChromeClient.h:
712
713 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
714
715         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
716         https://bugs.webkit.org/show_bug.cgi?id=194189
717
718         Reviewed by Geoffrey Garen.
719
720         Pass the policy check identifier around functions and store it in WebFramePolicyListener
721         so that we can send it back to WebCore with the navigation policy decision.
722
723         * WebCoreSupport/WebFrameLoaderClient.cpp:
724         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
725         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
726         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
727         (WebFrameLoaderClient::dispatchWillSubmitForm):
728         (WebFrameLoaderClient::setUpPolicyListener):
729         * WebCoreSupport/WebFrameLoaderClient.h:
730
731 2019-01-31  Alex Christensen  <achristensen@webkit.org>
732
733         Revert r238819 which is unneeded and caused a performance regression.
734         https://bugs.webkit.org/show_bug.cgi?id=192272
735         <rdar://problem/46664625>
736
737         * WebCoreSupport/WebFrameLoaderClient.cpp:
738         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
739         * WebCoreSupport/WebFrameLoaderClient.h:
740
741 2019-01-31  Takashi Komori  <Takashi.Komori@sony.com>
742
743         [Curl] Fix DRT crash related to private browsing.
744         https://bugs.webkit.org/show_bug.cgi?id=193816
745
746         Reviewed by Alex Christensen.
747
748         * WebCoreSupport/WebFrameNetworkingContext.cpp:
749         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
750
751 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
752
753         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
754         https://bugs.webkit.org/show_bug.cgi?id=193941
755
756         Reviewed by Alex Christensen.
757
758         * Plugins/PluginMessageThrottlerWin.cpp:
759         * Plugins/PluginView.cpp:
760         * Plugins/PluginViewWin.cpp:
761
762 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
763
764         Move FileSystem to WTF
765         https://bugs.webkit.org/show_bug.cgi?id=193602
766
767         Reviewed by Yusuke Suzuki.
768
769         * Plugins/PluginDatabase.cpp:
770         * Plugins/PluginPackage.h:
771         * Plugins/PluginStream.h:
772         * WebApplicationCache.cpp:
773         * WebDatabaseManager.cpp:
774         * WebDownloadCurl.cpp:
775         * WebPreferences.cpp:
776         * WebView.cpp:
777
778 2019-01-22  Alex Christensen  <achristensen@webkit.org>
779
780         Move NetworkStorageSession ownership to NetworkProcess
781         https://bugs.webkit.org/show_bug.cgi?id=193580
782
783         Reviewed by Geoff Garen.
784
785         * WebCoreSupport/WebFrameNetworkingContext.cpp:
786         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
787         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
788         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
789         (WebFrameNetworkingContext::storageSession const):
790         * WebDownloadCFNet.cpp:
791         (WebDownload::didReceiveAuthenticationChallenge):
792         * WebPreferences.cpp:
793         (WebPreferences::clearNetworkLoaderSession):
794         (WebPreferences::switchNetworkLoaderToNewTestingSession):
795
796 2019-01-15  Darin Adler  <darin@apple.com>
797
798         Use references rather than pointers for register/unregister functions, and more
799         https://bugs.webkit.org/show_bug.cgi?id=175028
800
801         Reviewed by Daniel Bates.
802
803         * Plugins/PluginView.cpp:
804         (WebCore::PluginView::startOrAddToUnstartedList): Pass a reference.
805         (WebCore::PluginView::~PluginView): Ditto.
806         * WebView.cpp:
807         (WebView::fullScreenClientWillEnterFullScreen): Ditto.
808         (WebView::fullScreenClientDidEnterFullScreen): Ditto.
809         (WebView::fullScreenClientDidExitFullScreen): Ditto.
810
811 2019-01-17  Per Arne Vollan  <pvollan@apple.com>
812
813         [Win][HighDPI] Repaint glitches when scrolling.
814         https://bugs.webkit.org/show_bug.cgi?id=173152
815         <rdar://problem/45269953>
816
817         Reviewed by Brent Fulgham.
818
819         Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
820         delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
821         Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
822
823         * WebView.cpp:
824         (WebView::scrollBackingStore):
825
826 2019-01-17  Alex Christensen  <achristensen@webkit.org>
827
828         Stop using NetworkStorageSession::storageSession in WebCore
829         https://bugs.webkit.org/show_bug.cgi?id=193529
830
831         Reviewed by Tim Horton.
832
833         * WebView.cpp:
834         (WebView::initWithFrame):
835
836 2019-01-15  Alex Christensen  <achristensen@webkit.org>
837
838         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
839         https://bugs.webkit.org/show_bug.cgi?id=193368
840
841         Reviewed by Geoff Garen.
842
843         * WebDownloadCFNet.cpp:
844         (WebDownload::didReceiveAuthenticationChallenge):
845
846 2019-01-15  Alex Christensen  <achristensen@webkit.org>
847
848         Fix Windows build after r240014
849         https://bugs.webkit.org/show_bug.cgi?id=161106
850
851         * WebView.cpp:
852
853 2019-01-15  Alex Christensen  <achristensen@webkit.org>
854
855         Stop using CookiesStrategy
856         https://bugs.webkit.org/show_bug.cgi?id=161106
857
858         Reviewed by Don Olmstead and Antti Koivisto.
859
860         * Plugins/PluginView.cpp:
861         (WebCore::PluginView::getValueForURL):
862         (WebCore::PluginView::setValueForURL):
863         * WebCoreSupport/WebPlatformStrategies.cpp:
864         (WebPlatformStrategies::createBlobRegistry):
865         (WebPlatformStrategies::createCookiesStrategy): Deleted.
866         (WebPlatformStrategies::cookiesForDOM): Deleted.
867         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
868         (WebPlatformStrategies::cookiesEnabled): Deleted.
869         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
870         (WebPlatformStrategies::getRawCookies): Deleted.
871         (WebPlatformStrategies::deleteCookie): Deleted.
872         * WebCoreSupport/WebPlatformStrategies.h:
873         * WebView.cpp:
874         (WebView::initWithFrame):
875
876 2019-01-08  Alex Christensen  <achristensen@webkit.org>
877
878         Stop using NetworkStorageSession in WebProcess
879         https://bugs.webkit.org/show_bug.cgi?id=193236
880
881         Reviewed by Don Olmstead.
882
883         * WebCoreSupport/WebFrameNetworkingContext.cpp:
884         (WebFrameNetworkingContext::storageSession const):
885         * WebCoreSupport/WebFrameNetworkingContext.h:
886         * WebCoreSupport/WebPlatformStrategies.cpp:
887         (WebPlatformStrategies::cookiesForDOM):
888         (WebPlatformStrategies::setCookiesFromDOM):
889         (WebPlatformStrategies::cookiesEnabled):
890         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
891         (WebPlatformStrategies::getRawCookies):
892         (WebPlatformStrategies::deleteCookie):
893         * WebCoreSupport/WebPlatformStrategies.h:
894
895 2019-01-08  Alex Christensen  <achristensen@webkit.org>
896
897         Unreviewed, rolling out r239727.
898
899         Broke API tests
900
901         Reverted changeset:
902
903         "Stop using NetworkStorageSession in WebProcess"
904         https://bugs.webkit.org/show_bug.cgi?id=193236
905         https://trac.webkit.org/changeset/239727
906
907 2018-12-24  Fujii Hironori  <Hironori.Fujii@sony.com>
908
909         Remove "using namespace std;"
910         https://bugs.webkit.org/show_bug.cgi?id=192973
911
912         Reviewed by Alex Christensen.
913
914         * FullscreenVideoController.cpp:
915         * WebFrame.cpp:
916         (WebFrame::drawFooter):
917         * WebHistory.cpp:
918         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
919         * WebKitQuartzCoreAdditions/CAView.cpp:
920         * WebView.cpp:
921         (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
922         (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
923         (WebView::setCacheModel):
924         (WebView::maxCacheModelInAnyInstance):
925
926 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
927
928         Use Ref<> as much as possible
929         https://bugs.webkit.org/show_bug.cgi?id=192808
930
931         Reviewed by Alex Christensen.
932
933         * Plugins/PluginDatabase.cpp:
934         (WebCore::PluginDatabase::refresh):
935         * Plugins/PluginView.cpp:
936         (WebCore::PluginView::mediaCanStart):
937         (WebCore::PluginView::performRequest):
938         (WebCore::PluginView::bindingInstance):
939         * Plugins/PluginView.h:
940         * WebCoreSupport/WebFrameLoaderClient.cpp:
941         (WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
942         (WebFrameLoaderClient::createPlugin):
943         (WebFrameLoaderClient::createJavaAppletWidget):
944         * WebCoreSupport/WebFrameLoaderClient.h:
945         * WebFrame.cpp:
946         (WebFrame::loadData):
947         (WebFrame::loadPlainTextString):
948         (WebFrame::loadHTMLString):
949         * WebFrame.h:
950         * WebKitQuartzCoreAdditions/CAView.cpp:
951         (WKQCA::CAView::create):
952         * WebKitQuartzCoreAdditions/CAView.h:
953         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
954         (WKQCA::CVDisplayLink::create):
955         * WebKitQuartzCoreAdditions/CVDisplayLink.h:
956         * WebKitQuartzCoreAdditions/ImageConversion.cpp:
957         (WKQCA::getImageCopy):
958         * WebView.cpp:
959         (WebView::addUserScriptToGroup):
960         (WebView::addUserStyleSheetToGroup):
961
962 2018-12-20  Chris Dumez  <cdumez@apple.com>
963
964         Use Optional::valueOr() instead of Optional::value_or()
965         https://bugs.webkit.org/show_bug.cgi?id=192933
966
967         Reviewed by Geoffrey Garen.
968
969         * WebSecurityOrigin.cpp:
970         (WebSecurityOrigin::port):
971
972 2018-12-19  Chris Dumez  <cdumez@apple.com>
973
974         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
975         https://bugs.webkit.org/show_bug.cgi?id=192728
976         <rdar://problem/46746779>
977
978         Reviewed by Geoff Garen.
979
980         * Plugins/*:
981         * WebCoreSupport/*:
982
983 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
984
985         [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag
986         https://bugs.webkit.org/show_bug.cgi?id=192617
987
988         Reviewed by Alex Christensen.
989
990         * COMEnumVariant.h:
991         (COMEnumVariant<ContainerType>::adopt): Removed 'typename' from non dependent names.
992         (COMEnumVariant<ContainerType>::createInstance): Ditto.
993         (COMEnumVariant<ContainerType>::Next): Prepend 'typename' for dependent names.
994         * COMPropertyBag.h:
995         (HashType>::createInstance): Removed 'typename' from non dependent names.
996         (HashType>::adopt): Ditto.
997         (HashType>::Read): Replaced dependent name 'HashMapType::const_iterator' with 'auto'.
998         (HashType>::GetPropertyInfo): Ditto.
999
1000 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1001
1002         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
1003         https://bugs.webkit.org/show_bug.cgi?id=192618
1004
1005         Reviewed by Alex Christensen.
1006
1007         Classes which implement COM interface usually doesn't need the
1008         virtual destructor because it has Release() virtual method to
1009         destruct itself.
1010
1011         Marked 'final' such classes to suppress clang-cl's compilation
1012         warnings.
1013
1014         * COMEnumVariant.h:
1015         * COMPropertyBag.h:
1016         * DefaultDownloadDelegate.h:
1017         * DefaultPolicyDelegate.h:
1018         * MemoryStream.h:
1019         * WebActionPropertyBag.h:
1020         * WebApplicationCache.h:
1021         * WebArchive.h:
1022         * WebBackForwardList.h:
1023         * WebCache.h:
1024         * WebCoreStatistics.h:
1025         * WebCoreSupport/WebEditorClient.cpp:
1026         * WebCoreSupport/WebInspectorDelegate.h:
1027         * WebDataSource.h:
1028         * WebDatabaseManager.cpp:
1029         * WebDatabaseManager.h:
1030         * WebDownload.h:
1031         * WebDropSource.h:
1032         * WebElementPropertyBag.h:
1033         * WebError.h:
1034         * WebFrame.cpp:
1035         * WebFrame.h:
1036         * WebFramePolicyListener.h:
1037         * WebGeolocationPolicyListener.h:
1038         * WebGeolocationPosition.h:
1039         * WebHTMLRepresentation.h:
1040         * WebHistory.h:
1041         * WebHistoryItem.h:
1042         * WebInspector.h:
1043         * WebJavaScriptCollector.h:
1044         * WebKitClassFactory.h:
1045         * WebKitMessageLoop.h:
1046         * WebKitStatistics.h:
1047         * WebMutableURLRequest.h:
1048         * WebNavigationData.h:
1049         * WebNotification.h:
1050         * WebNotificationCenter.h:
1051         * WebPreferences.h:
1052         * WebResource.h:
1053         * WebScriptWorld.h:
1054         * WebSecurityOrigin.h:
1055         * WebSerializedJSValue.h:
1056         * WebTextRenderer.h:
1057         * WebURLAuthenticationChallenge.h:
1058         * WebURLAuthenticationChallengeSender.h:
1059         * WebURLCredential.h:
1060         * WebURLProtectionSpace.h:
1061         * WebURLResponse.h:
1062         * WebUserContentURLPattern.h:
1063         * WebView.cpp:
1064         * WebView.h:
1065         * WebWorkersPrivate.h:
1066
1067 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1068
1069         [Win][Clang] Fix warning -Wmissing-field-initializers
1070         https://bugs.webkit.org/show_bug.cgi?id=192584
1071
1072         Reviewed by Yusuke Suzuki.
1073
1074         Initialize a struct with '{ }' instead of '= {0}'.
1075
1076         * WebKitMessageLoop.cpp:
1077         (WebKitMessageLoop::run):
1078         * WebView.cpp:
1079         (WebView::onMenuCommand):
1080         (WebView::gesture):
1081         (WebView::setShouldInvertColors):
1082         (WebView::initializeToolTipWindow):
1083         (WebView::setToolTip):
1084         (WebView::fullScreenClientForceRepaint):
1085
1086 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1087
1088         Turn WritingDirection into an enum class
1089         https://bugs.webkit.org/show_bug.cgi?id=192401
1090         Work towards <rdar://problem/42075638>
1091
1092         Reviewed by Dan Bernstein.
1093
1094         Change WritingDirection from an enum to an enum class. No change in behavior.
1095
1096         * WebFrame.cpp:
1097         (WebFrame::setTextDirection):
1098
1099 2018-12-03  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1100
1101         Use WallTime for file time
1102         https://bugs.webkit.org/show_bug.cgi?id=192287
1103
1104         Reviewed by Darin Adler.
1105
1106         * Plugins/PluginDatabase.cpp:
1107         (WebCore::PluginDatabase::refresh):
1108
1109 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1110
1111         Fix Windows build.
1112
1113         * WebView.cpp:
1114
1115 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1116
1117         Fix Windows build.
1118
1119         * WebCoreSupport/WebFrameLoaderClient.h:
1120
1121 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1122
1123         Fix Windows build.
1124
1125         * WebCoreSupport/WebFrameLoaderClient.h:
1126
1127 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1128
1129         Move URL from WebCore to WTF
1130         https://bugs.webkit.org/show_bug.cgi?id=190234
1131
1132         Reviewed by Keith Miller.
1133
1134         * MarshallingHelpers.cpp:
1135         * MarshallingHelpers.h:
1136         * Plugins/PluginDatabase.cpp:
1137         * Plugins/PluginDatabase.h:
1138         * Plugins/PluginDatabaseWin.cpp:
1139         * Plugins/PluginStream.h:
1140         * Plugins/PluginView.h:
1141         * WebCoreSupport/WebContextMenuClient.h:
1142         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
1143         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
1144         * WebCoreSupport/WebFrameLoaderClient.h:
1145         * WebCoreSupport/WebPlatformStrategies.h:
1146         * WebCoreSupport/WebPluginInfoProvider.cpp:
1147         (WebPluginInfoProvider::webVisiblePluginInfo):
1148         * WebCoreSupport/WebPluginInfoProvider.h:
1149         * WebCoreSupport/WebVisitedLinkStore.h:
1150         * WebDataSource.cpp:
1151         * WebDownload.h:
1152         * WebElementPropertyBag.cpp:
1153         * WebFrame.h:
1154         * WebHistory.cpp:
1155         * WebHistory.h:
1156         * WebHistoryItem.cpp:
1157         * WebResource.cpp:
1158         (WebResource::WebResource):
1159         * WebResource.h:
1160         * WebSecurityOrigin.cpp:
1161         * WebURLResponse.cpp:
1162         (WebURLResponse::createInstance):
1163         * WebUserContentURLPattern.cpp:
1164         * WebView.h:
1165
1166 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1167
1168         Remove dead code from an earlier attempt at implementing safe browsing
1169         https://bugs.webkit.org/show_bug.cgi?id=192067
1170
1171         Reviewed by Chris Dumez.
1172
1173         * WebCoreSupport/WebFrameLoaderClient.cpp:
1174         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1175         * WebCoreSupport/WebFrameLoaderClient.h:
1176
1177 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
1178
1179         [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
1180         https://bugs.webkit.org/show_bug.cgi?id=191959
1181
1182         Reviewed by Alex Christensen.
1183
1184         * MarshallingHelpers.h: Removed extra "MarshallingHelpers::" of windowsEpochAbsoluteTime declaration.
1185
1186 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
1187
1188         [Win] Reduce the use of WKSI library calls: CoreAnimation
1189         https://bugs.webkit.org/show_bug.cgi?id=191777
1190         <rdar://problem/46140542>
1191
1192         Reviewed by Zalan Bujtas.
1193
1194         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
1195         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
1196         directives for WebKitSystemInterface.lib.
1197
1198         * FullscreenVideoController.cpp:
1199         * WebKitGraphics.cpp:
1200         * WebPreferences.cpp:
1201
1202 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1203
1204         Address post-review feedback after r238438
1205         https://bugs.webkit.org/show_bug.cgi?id=191913
1206
1207         Reviewed by Ryosuke Niwa.
1208
1209         * AccessibleTextImpl.cpp:
1210         (AccessibleText::replaceText):
1211
1212 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1213
1214         Web Inspector: "Reload Web Inspector" button no longer partially works
1215         https://bugs.webkit.org/show_bug.cgi?id=191773
1216         <rdar://problem/46139932>
1217
1218         Reviewed by Devin Rousso.
1219
1220         * WebCoreSupport/WebInspectorClient.cpp:
1221         (WebInspectorFrontendClient::reopen):
1222         * WebCoreSupport/WebInspectorClient.h:
1223
1224 2018-11-17  Devin Rousso  <drousso@apple.com>
1225
1226         Web Inspector: Network: add button to show system certificate dialog
1227         https://bugs.webkit.org/show_bug.cgi?id=191458
1228         <rdar://problem/45977019>
1229
1230         Reviewed by Joseph Pecoraro.
1231
1232         * WebCoreSupport/WebInspectorClient.h:
1233         * WebCoreSupport/WebInspectorClient.cpp:
1234         (WebInspectorFrontendClient::showCertificate): Added.
1235
1236 2018-11-16  Brent Fulgham  <bfulgham@apple.com>
1237
1238         [Win] Reduce the use of WKSI library calls: CFNetwork
1239         https://bugs.webkit.org/show_bug.cgi?id=191718
1240         <rdar://problem/46108732>
1241
1242         Reviewed by Alex Christensen.
1243
1244         Remove custom WKSI CFNetwork calls, since the SPI is already documented in PAL. Just
1245         make the same calls on Windows, like we did for iOS and macOS back in 2017.
1246
1247         * WebCache.cpp:
1248         (WebCache::cacheFolder):
1249         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1250         * WebCoreSupport/WebPlatformStrategies.cpp:
1251         * WebError.cpp:
1252         (WebError::localizedDescription):
1253         (WebError::sslPeerCertificate):
1254         * WebURLResponse.cpp:
1255         (WebURLResponse::sslPeerCertificate):
1256         (WebURLResponse::certificateDictionary const):
1257         * WebView.cpp:
1258         (WebView::setCacheModel):
1259
1260 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
1261
1262         [Win] Reduce the use of WKSI library calls: Font Handling
1263         https://bugs.webkit.org/show_bug.cgi?id=191701
1264         <rdar://problem/46104809>
1265
1266         Reviewed by Myles C. Maxfield.
1267
1268         Update to use the old font handling routines moved from WKSI to FontCascade.
1269
1270         * WebPreferences.cpp:
1271         (WebPreferences::setFontSmoothing):
1272         (WebPreferences::setFontSmoothingContrast):
1273         * WebView.cpp:
1274         (systemParameterChanged):
1275
1276 2018-11-14  Timothy Hatcher  <timothy@apple.com>
1277
1278         Default the view background color and text color to different values when in dark mode.
1279         https://bugs.webkit.org/show_bug.cgi?id=191607
1280         rdar://problem/46045854
1281
1282         Reviewed by Dean Jackson.
1283
1284         * WebFrame.cpp:
1285         (WebFrame::updateBackground): Drop backgroundColor.
1286         * WebCoreSupport/WebFrameLoaderClient.cpp:
1287         (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor.
1288
1289 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1290
1291         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1292         https://bugs.webkit.org/show_bug.cgi?id=191612
1293
1294         Reviewed by Matt Baker.
1295
1296         * WebCoreSupport/WebInspectorClient.cpp:
1297         (WebInspectorFrontendClient::destroyInspectorView):
1298
1299 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
1300
1301         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
1302         https://bugs.webkit.org/show_bug.cgi?id=189230
1303         <rdar://problem/44050379>
1304
1305         Reviewed by Joseph Pecoraro.
1306
1307         Runs all png images through zopflipng. This results in a smaller file
1308         size and takes care of this issue as a byproduct.
1309
1310         * WebKit.resources/deleteButton.png:
1311         * WebKit.resources/deleteButtonPressed.png:
1312         * WebKit.resources/fsVideoAudioVolumeHigh.png:
1313         * WebKit.resources/fsVideoAudioVolumeLow.png:
1314         * WebKit.resources/fsVideoExitFullscreen.png:
1315         * WebKit.resources/fsVideoPause.png:
1316         * WebKit.resources/fsVideoPlay.png:
1317         * WebKit.resources/missingImage.png:
1318         * WebKit.resources/nullplugin.png:
1319         * WebKit.resources/panEastCursor.png:
1320         * WebKit.resources/panIcon.png:
1321         * WebKit.resources/panNorthCursor.png:
1322         * WebKit.resources/panNorthEastCursor.png:
1323         * WebKit.resources/panNorthWestCursor.png:
1324         * WebKit.resources/panSouthCursor.png:
1325         * WebKit.resources/panSouthEastCursor.png:
1326         * WebKit.resources/panSouthWestCursor.png:
1327         * WebKit.resources/panWestCursor.png:
1328         * WebKit.resources/searchCancel.png:
1329         * WebKit.resources/searchCancelPressed.png:
1330         * WebKit.resources/searchMagnifier.png:
1331         * WebKit.resources/searchMagnifierResults.png:
1332         * WebKit.resources/textAreaResizeCorner.png:
1333         * WebKit.resources/verticalTextCursor.png:
1334         * WebKit.resources/zoomInCursor.png:
1335         * WebKit.resources/zoomOutCursor.png:
1336
1337 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1338
1339         Unreviewed Windows build fix for r238049.
1340
1341         * WebView.cpp:
1342         (WebView::initWithFrame):
1343
1344 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1345
1346         Unreviewed MSVC build fix after r238039 (and r238046).
1347
1348         * WebDocumentLoader.h:
1349         * WebView.cpp:
1350         (WebView::setShouldApplyMacFontAscentHack):
1351
1352 2018-11-09  Antti Koivisto  <antti@apple.com>
1353
1354         Use OptionSet for layout milestones
1355         https://bugs.webkit.org/show_bug.cgi?id=191470
1356
1357         Reviewed by Dean Jackson.
1358
1359         * WebCoreSupport/WebFrameLoaderClient.cpp:
1360         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1361         * WebCoreSupport/WebFrameLoaderClient.h:
1362
1363 2018-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1364
1365         WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1366         https://bugs.webkit.org/show_bug.cgi?id=191455
1367
1368         Reviewed by Brent Fulgham.
1369
1370         * WebHistory.h: Marked with 'override' and removed 'virtual'.
1371
1372 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1373
1374         Add a storage limit for IndexedDB
1375         https://bugs.webkit.org/show_bug.cgi?id=190598
1376         <rdar://problem/44654715>
1377
1378         Reviewed by Chris Dumez.
1379
1380         * Interfaces/IWebDatabaseManager.idl:
1381         * WebDatabaseManager.cpp:
1382         (WebDatabaseManager::setIDBPerOriginQuota):
1383         * WebDatabaseManager.h:
1384
1385 2018-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1386
1387         [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
1388         https://bugs.webkit.org/show_bug.cgi?id=191105
1389
1390         Reviewed by Brent Fulgham.
1391
1392         * DOMHTMLClasses.h:
1393         (DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
1394         instead of own setNodeValue.
1395
1396 2018-10-25  Antoine Quint  <graouts@apple.com>
1397
1398         [Web Animations] Turn Web Animations CSS Integration off by default
1399         https://bugs.webkit.org/show_bug.cgi?id=190901
1400
1401         Reviewed by Dean Jackson.
1402
1403         * WebPreferences.cpp:
1404         (WebPreferences::initializeDefaultSettings):
1405
1406 2018-10-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1407
1408         [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1409         https://bugs.webkit.org/show_bug.cgi?id=190744
1410
1411         Reviewed by Alex Christensen.
1412
1413         clang-cl reports compilation warnings for inconsistent 'override'
1414         keyword usage.
1415
1416         WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
1417         This can't be marked 'override' if !USE(CA).
1418
1419         * WebView.cpp:
1420         (WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).
1421         * WebView.h: Marked all overriding member function declarations of WebView 'override'.
1422         Declare flushPendingGraphicsLayerChanges only if USE(CA).
1423
1424 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1425
1426         Clean up FrameLoader two-state enums
1427         https://bugs.webkit.org/show_bug.cgi?id=190731
1428
1429         Reviewed by Chris Dumez.
1430
1431         * WebCoreSupport/WebFrameLoaderClient.cpp:
1432         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1433         * WebCoreSupport/WebFrameLoaderClient.h:
1434
1435 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1436
1437         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1438         https://bugs.webkit.org/show_bug.cgi?id=190675
1439
1440         Reviewed by Chris Dumez.
1441
1442         * BackForwardList.cpp:
1443         (BackForwardList::backItem):
1444         (BackForwardList::currentItem):
1445         (BackForwardList::forwardItem):
1446         (BackForwardList::backListCount const):
1447         (BackForwardList::forwardListCount const):
1448         (BackForwardList::itemAtIndex):
1449         * BackForwardList.h:
1450
1451 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
1452
1453         Unreviewed attempt to fix the Windows build after r237112.
1454
1455         * Plugins/PluginView.cpp:
1456         (WebCore::PluginView::performRequest):
1457
1458 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1459
1460         Replace HistoryItem* with HistoryItem& where possible
1461         https://bugs.webkit.org/show_bug.cgi?id=190617
1462
1463         Reviewed by Chris Dumez.
1464
1465         * BackForwardList.cpp:
1466         (BackForwardList::goToItem):
1467         * BackForwardList.h:
1468         * WebBackForwardList.cpp:
1469         (WebBackForwardList::goToItem):
1470
1471 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1472
1473         Fix Windows build.
1474
1475         * WebView.cpp:
1476         (WebView::loadBackForwardListFromOtherView):
1477
1478 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1479
1480         Fix WinCairo build.
1481
1482         * WebView.cpp:
1483         (WebView::backForwardList):
1484
1485 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1486
1487         Modernize BackForwardClient.h
1488         https://bugs.webkit.org/show_bug.cgi?id=190610
1489
1490         Reviewed by Chris Dumez.
1491
1492         * BackForwardList.cpp:
1493         (BackForwardList::backListCount const):
1494         (BackForwardList::forwardListCount const):
1495         (BackForwardList::backListCount): Deleted.
1496         (BackForwardList::forwardListCount): Deleted.
1497         * BackForwardList.h:
1498         * WebView.cpp:
1499         (WebView::initWithFrame):
1500         (WebView::backForwardList):
1501
1502 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1503
1504         Remove unused WebView._globalHistoryItem
1505         https://bugs.webkit.org/show_bug.cgi?id=190601
1506
1507         Reviewed by Chris Dumez.
1508
1509         * WebCoreSupport/WebFrameLoaderClient.cpp:
1510         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1511         * WebCoreSupport/WebFrameLoaderClient.h:
1512         * WebView.cpp:
1513         (WebView::globalHistoryItem):
1514         (WebView::setGlobalHistoryItem): Deleted.
1515         * WebView.h:
1516
1517 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1518
1519         Remove unused parameters from FrameLoaderClient::createFrame
1520         https://bugs.webkit.org/show_bug.cgi?id=190587
1521
1522         Reviewed by Chris Dumez.
1523
1524         * WebCoreSupport/WebFrameLoaderClient.cpp:
1525         (WebFrameLoaderClient::createFrame):
1526         * WebCoreSupport/WebFrameLoaderClient.h:
1527
1528 2018-10-15  Chris Dumez  <cdumez@apple.com>
1529
1530         Unreviewed Windows build fix after r237112.
1531
1532         * Plugins/PluginView.cpp:
1533         (WebCore::PluginView::performRequest):
1534         (WebCore::PluginView::load):
1535
1536 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1537
1538         Remove InjectedBundle processing of back/forward lists
1539         https://bugs.webkit.org/show_bug.cgi?id=190459
1540
1541         Reviewed by Chris Dumez.
1542
1543         * WebCoreSupport/WebFrameLoaderClient.cpp:
1544         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1545         * WebCoreSupport/WebFrameLoaderClient.h:
1546
1547 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1548
1549         Remove ParsedURLString
1550         https://bugs.webkit.org/show_bug.cgi?id=190154
1551
1552         Reviewed by Chris Dumez.
1553
1554         * WebDownloadCurl.cpp:
1555         (WebDownload::initWithRequest):
1556         * WebURLResponse.cpp:
1557         (WebURLResponse::createInstance):
1558
1559 2018-09-28  Chris Dumez  <cdumez@apple.com>
1560
1561         Drop support for cross-origin-window-policy header
1562         https://bugs.webkit.org/show_bug.cgi?id=190081
1563
1564         Reviewed by Ryosuke Niwa.
1565
1566         * WebPreferenceKeysPrivate.h:
1567         * WebPreferences.cpp:
1568         (WebPreferences::initializeDefaultSettings):
1569         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1570         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1571         * WebView.cpp:
1572         (WebView::notifyPreferencesChanged):
1573
1574 2018-09-27  Antoine Quint  <graouts@apple.com>
1575
1576         [Web Animations] Turn Web Animations with CSS integration on
1577         https://bugs.webkit.org/show_bug.cgi?id=184819
1578         <rdar://problem/39597337>
1579
1580         Reviewed by Dean Jackson.
1581
1582         * WebPreferences.cpp:
1583         (WebPreferences::initializeDefaultSettings):
1584
1585 2018-09-21  Alex Christensen  <achristensen@webkit.org>
1586
1587         Use a Variant for FormDataElement
1588         https://bugs.webkit.org/show_bug.cgi?id=189777
1589
1590         Reviewed by Chris Dumez.
1591
1592         * WebMutableURLRequest.cpp:
1593         (WebMutableURLRequest::setHTTPBody):
1594
1595 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1596
1597         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
1598         https://bugs.webkit.org/show_bug.cgi?id=189612
1599
1600         Reviewed by Alex Christensen.
1601
1602         Non-trivial types can't be used as aruguments of LOG_ERROR and
1603         ASSERT_WITH_MESSAGE.
1604
1605         * DefaultPolicyDelegate.cpp:
1606         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
1607         static_cast<BSTR> to convert BString.
1608         * WebLocalizableStrings.cpp:
1609         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
1610         char* by using 'key.utf8().data()'.
1611
1612 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
1613
1614         Unreviewed, rolling out r235953.
1615
1616         Caused layout test crashes under GuardMalloc.
1617
1618         Reverted changeset:
1619
1620         "Make GraphicsLayers ref-counted, so their tree can persist
1621         when disconnected from RenderLayerBackings"
1622         https://bugs.webkit.org/show_bug.cgi?id=189521
1623         https://trac.webkit.org/changeset/235953
1624
1625 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1626
1627         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
1628         https://bugs.webkit.org/show_bug.cgi?id=189538
1629
1630         Reviewed by Per Arne Vollan.
1631
1632         * WebPreferences.cpp:
1633         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
1634         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
1635         Apply static_cast to the result of OR-ed CFPropertyListFormat.
1636         (WebPreferences::screenFontSubstitutionEnabled):
1637         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
1638
1639 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1640
1641         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
1642         https://bugs.webkit.org/show_bug.cgi?id=189539
1643
1644         Reviewed by Alex Christensen.
1645
1646         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
1647         * WebCoreSupport/WebInspectorClient.cpp:
1648         (WebInspectorWndProc): Ditto.
1649         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
1650         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
1651
1652 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1653
1654         Refactor WebCore::EditAction to be an 8-bit enum class
1655         https://bugs.webkit.org/show_bug.cgi?id=189383
1656
1657         Reviewed by Dan Bernstein.
1658
1659         * WebCoreSupport/WebEditorClient.cpp:
1660         (undoNameForEditAction):
1661
1662 2018-09-04  Frederic Wang  <fwang@igalia.com>
1663
1664         Add basic support for ScrollIntoViewOptions
1665         https://bugs.webkit.org/show_bug.cgi?id=189258
1666
1667         Reviewed by Simon Fraser.
1668
1669         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
1670         can build despite the new scrollIntoView function.
1671
1672 2018-08-31  Chris Dumez  <cdumez@apple.com>
1673
1674         Unreviewed Windows build fix after r235562.
1675
1676         * WebCoreSupport/WebFrameLoaderClient.cpp:
1677         (WebFrameLoaderClient::dispatchWillSubmitForm):
1678
1679 2018-08-31  Chris Dumez  <cdumez@apple.com>
1680
1681         Assertion hit in ~CompletionHandler() from ~WebFrame()
1682         https://bugs.webkit.org/show_bug.cgi?id=189199
1683         <rdar://problem/42657233>
1684
1685         Reviewed by Youenn Fablet.
1686
1687         * WebCoreSupport/WebFrameLoaderClient.cpp:
1688         (WebFrameLoaderClient::dispatchWillSubmitForm):
1689         * WebCoreSupport/WebFrameLoaderClient.h:
1690
1691 2018-08-31  Frederic Wang  <fwang@igalia.com>
1692
1693         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1694         https://bugs.webkit.org/show_bug.cgi?id=182053
1695
1696         Reviewed by Simon Fraser.
1697
1698         Add developer flag to use standard behavior for scrolling* attributes.
1699
1700         * Interfaces/IWebPreferencesPrivate.idl:
1701         * WebPreferenceKeysPrivate.h:
1702         * WebPreferences.cpp:
1703         (WebPreferences::initializeDefaultSettings):
1704         (WebPreferences::CSSOMViewScrollingAPIEnabled):
1705         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
1706         * WebPreferences.h:
1707         * WebView.cpp:
1708         (WebView::notifyPreferencesChanged):
1709
1710 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
1711
1712         [CMake] Replace AVFoundationSupport.py using CMake
1713         https://bugs.webkit.org/show_bug.cgi?id=182891
1714
1715         Reviewed by Per Arne Vollan.
1716
1717         Remove references to the config.h contained in WebCore as it should
1718         not be accessible from outside of WebCore.
1719
1720         * WebKitPrefix.h:
1721
1722 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1723
1724         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
1725         https://bugs.webkit.org/show_bug.cgi?id=188496
1726         <rdar://problem/43216836>
1727
1728         Reviewed by Tim Horton.
1729
1730         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
1731         header directly.
1732
1733         * WebCoreSupport/WebDragClient.cpp:
1734
1735 2018-08-17  Alex Christensen  <achristensen@webkit.org>
1736
1737         Add some plumbing for safe browsing
1738         https://bugs.webkit.org/show_bug.cgi?id=188709
1739
1740         Reviewed by Tim Horton.
1741
1742         * WebCoreSupport/WebFrameLoaderClient.cpp:
1743         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1744         * WebCoreSupport/WebFrameLoaderClient.h:
1745
1746 2018-08-02  David Fenton  <david_fenton@apple.com>
1747
1748         Unreviewed, rolling out r234489.
1749
1750         Caused 50+ crashes and 60+ API failures on iOS
1751
1752         Reverted changeset:
1753
1754         "[WTF] Rename String::format to String::deprecatedFormat"
1755         https://bugs.webkit.org/show_bug.cgi?id=188191
1756         https://trac.webkit.org/changeset/234489
1757
1758 2018-08-01  Tomas Popela  <tpopela@redhat.com>
1759
1760         [WTF] Rename String::format to String::deprecatedFormat
1761         https://bugs.webkit.org/show_bug.cgi?id=188191
1762
1763         Reviewed by Darin Adler.
1764
1765         It should be replaced with string concatenation.
1766
1767         * FullscreenVideoController.cpp:
1768         (timeToString):
1769         * WebView.cpp:
1770         (webKitVersionString):
1771
1772 2018-07-30  Rob Buis  <rbuis@igalia.com>
1773
1774         https://bugs.webkit.org/show_bug.cgi?id=188137
1775         Merge PlatformCookieJar functions into NetworkStorageSession
1776
1777         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1778
1779         Reviewed by Alex Christensen.
1780
1781         * WebCoreSupport/WebPlatformStrategies.cpp:
1782         (WebPlatformStrategies::cookiesForDOM):
1783         (WebPlatformStrategies::setCookiesFromDOM):
1784         (WebPlatformStrategies::cookiesEnabled):
1785         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1786         (WebPlatformStrategies::getRawCookies):
1787         (WebPlatformStrategies::deleteCookie):
1788         * WebPreferences.cpp:
1789         (WebPreferences::clearNetworkLoaderSession):
1790
1791 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
1792
1793         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
1794         https://bugs.webkit.org/show_bug.cgi?id=187963
1795
1796         Reviewed by Alex Christensen.
1797
1798         * Plugins/PluginPackageWin.cpp:
1799         (WebCore::PluginPackage::fetchInfo):
1800         Update split/splitAllowingEmptyEntries usage.
1801
1802 2018-07-18  Antoine Quint  <graouts@apple.com>
1803
1804         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
1805         https://bugs.webkit.org/show_bug.cgi?id=187722
1806
1807         Reviewed by Myles Maxfield.
1808
1809         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
1810
1811         * DOMCoreClasses.cpp:
1812         (DOMElement::font):
1813
1814 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1815
1816         Disable cross-origin-window-policy by default
1817         https://bugs.webkit.org/show_bug.cgi?id=187509
1818
1819         Reviewed by Chris Dumez.
1820
1821         * WebPreferences.cpp:
1822         (WebPreferences::initializeDefaultSettings):
1823
1824 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1825
1826         [WTF] Add user-defined literal for ASCIILiteral
1827         https://bugs.webkit.org/show_bug.cgi?id=186839
1828
1829         Reviewed by Darin Adler.
1830
1831         * Plugins/PluginStream.cpp:
1832         (WebCore::PluginStream::startStream):
1833         * WebCoreSupport/WebContextMenuClient.cpp:
1834         (WebContextMenuClient::searchWithGoogle):
1835
1836 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1837
1838         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
1839         https://bugs.webkit.org/show_bug.cgi?id=186623
1840
1841         Reviewed by Youenn Fablet.
1842
1843         * WebCoreSupport/WebPluginInfoProvider.cpp:
1844         (WebPluginInfoProvider::pluginInfo):
1845         (WebPluginInfoProvider::webVisiblePluginInfo):
1846         * WebCoreSupport/WebPluginInfoProvider.h:
1847
1848 2018-06-13  Chris Dumez  <cdumez@apple.com>
1849
1850         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1851         https://bugs.webkit.org/show_bug.cgi?id=186545
1852
1853         Reviewed by Brady Eidson.
1854
1855         Update client delegate now that parameter type has changed.
1856
1857         * WebCoreSupport/WebFrameLoaderClient.cpp:
1858         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1859         * WebCoreSupport/WebFrameLoaderClient.h:
1860
1861 2018-06-11  Chris Dumez  <cdumez@apple.com>
1862
1863         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
1864         https://bugs.webkit.org/show_bug.cgi?id=186441
1865
1866         Reviewed by Brady Eidson.
1867
1868         Rename existing flag to something a bit more generic, now that it is used for
1869         more things than bypassing the navigation policy check.
1870
1871         * WebView.cpp:
1872         (WebView::goToBackForwardItem):
1873         (WebView::loadBackForwardListFromOtherView):
1874
1875 2018-06-04  Chris Dumez  <cdumez@apple.com>
1876
1877         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
1878         https://bugs.webkit.org/show_bug.cgi?id=186287
1879         <rdar://problem/40783352>
1880
1881         Reviewed by Youenn Fablet.
1882
1883         * Interfaces/IWebPreferencesPrivate.idl:
1884         * WebPreferenceKeysPrivate.h:
1885         * WebPreferences.cpp:
1886         (WebPreferences::initializeDefaultSettings):
1887         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1888         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1889         * WebPreferences.h:
1890         * WebView.cpp:
1891         (WebView::notifyPreferencesChanged):
1892
1893 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1894
1895         [JSC] Pass VM& parameter as much as possible
1896         https://bugs.webkit.org/show_bug.cgi?id=186085
1897
1898         Reviewed by Saam Barati.
1899
1900         * Plugins/PluginPackage.cpp:
1901         (WebCore::NPN_Invoke):
1902
1903 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1904
1905         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
1906         https://bugs.webkit.org/show_bug.cgi?id=186125
1907
1908         Unreviewed build fix
1909
1910         * WebActionPropertyBag.cpp:
1911         (WebActionPropertyBag::Read):
1912         (findMouseEvent): Deleted.
1913
1914 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1915
1916         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
1917         https://bugs.webkit.org/show_bug.cgi?id=186027
1918
1919         Unreviewed build fix
1920
1921         * WebMutableURLRequest.cpp:
1922         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
1923         (WebMutableURLRequest::setClientCertificate):
1924
1925 2018-05-25  Chris Dumez  <cdumez@apple.com>
1926
1927         Minor ApplicationCacheStorage clean up
1928         https://bugs.webkit.org/show_bug.cgi?id=185984
1929
1930         Reviewed by Youenn Fablet.
1931
1932         * WebApplicationCache.cpp:
1933         (WebApplicationCache::originsWithCache):
1934
1935 2018-05-24  Chris Dumez  <cdumez@apple.com>
1936
1937         Reduce copying of FontCascadeDescription objects by moving them around
1938         https://bugs.webkit.org/show_bug.cgi?id=185963
1939
1940         Reviewed by Simon Fraser.
1941
1942         Reduce copying of FontCascadeDescription objects by moving them around when possible.
1943
1944         * FullscreenVideoController.cpp:
1945         (FullscreenVideoController::draw):
1946
1947 2018-05-15  Antoine Quint  <graouts@apple.com>
1948
1949         [Web Animations] Expose Web Animations CSS integration as an experimental feature
1950         https://bugs.webkit.org/show_bug.cgi?id=185647
1951
1952         Reviewed by Dean Jackson.
1953
1954         Rename the Web Animations CSS integration flag.
1955
1956         * Interfaces/IWebPreferencesPrivate.idl:
1957         * WebPreferenceKeysPrivate.h:
1958         * WebPreferences.cpp:
1959         (WebPreferences::initializeDefaultSettings):
1960         (WebPreferences::webAnimationsCSSIntegrationEnabled):
1961         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
1962         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1963         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1964         * WebPreferences.h:
1965         * WebView.cpp:
1966         (WebView::notifyPreferencesChanged):
1967
1968 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1969
1970         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
1971         https://bugs.webkit.org/show_bug.cgi?id=185505
1972
1973         Unreviewed serious crash fix
1974
1975         Windows port crashes soon since Bug 184996.
1976
1977         * WebPreferences.cpp:
1978         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
1979         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
1980
1981 2018-05-07  Daniel Bates  <dabates@apple.com>
1982
1983         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
1984         https://bugs.webkit.org/show_bug.cgi?id=185170
1985
1986         Reviewed by Per Arne Vollan.
1987
1988         * WebCache.cpp:
1989         (WebCache::empty):
1990
1991 2018-04-27  Chris Dumez  <cdumez@apple.com>
1992
1993         Use WindowProxy instead of DOMWindow in our IDL
1994         https://bugs.webkit.org/show_bug.cgi?id=185022
1995
1996         Reviewed by Sam Weinig.
1997
1998         * DOMCoreClasses.cpp:
1999         (DOMDocument::getComputedStyle):
2000
2001 2018-04-23  Daniel Bates  <dabates@apple.com>
2002
2003         Implement Same-Site cookies
2004         https://bugs.webkit.org/show_bug.cgi?id=159464
2005         <rdar://problem/27196358>
2006
2007         Reviewed by Brent Fulgham.
2008
2009         Pass the Same-Site info through the strategy.
2010
2011         * WebCoreSupport/WebPlatformStrategies.cpp:
2012         (WebPlatformStrategies::cookiesForDOM):
2013         (WebPlatformStrategies::setCookiesFromDOM):
2014         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2015         (WebPlatformStrategies::getRawCookies):
2016         * WebCoreSupport/WebPlatformStrategies.h:
2017
2018 2018-04-23  Daniel Bates  <dabates@apple.com>
2019
2020         Implement Same-Site cookies
2021         https://bugs.webkit.org/show_bug.cgi?id=159464
2022         <rdar://problem/27196358>
2023
2024         Reviewed by Brent Fulgham.
2025
2026         Pass the Same-Site info through the strategy.
2027
2028         * WebCoreSupport/WebPlatformStrategies.cpp:
2029         (WebPlatformStrategies::cookiesForDOM):
2030         (WebPlatformStrategies::setCookiesFromDOM):
2031         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2032         (WebPlatformStrategies::getRawCookies):
2033         * WebCoreSupport/WebPlatformStrategies.h:
2034
2035 2018-04-20  Youenn Fablet  <youenn@apple.com>
2036
2037         Make PluginData cache its web visible plugins
2038         https://bugs.webkit.org/show_bug.cgi?id=184421
2039
2040         Reviewed by Chris Dumez.
2041
2042         * WebCoreSupport/WebPluginInfoProvider.cpp:
2043         (WebPluginInfoProvider::pluginInfo):
2044         (WebPluginInfoProvider::webVisiblePluginInfo):
2045         * WebCoreSupport/WebPluginInfoProvider.h:
2046
2047 2018-04-19  Chris Dumez  <cdumez@apple.com>
2048
2049         Rename JSDOMWindowProxy to JSWindowProxy
2050         https://bugs.webkit.org/show_bug.cgi?id=184797
2051
2052         Reviewed by Sam Weinig.
2053
2054         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
2055
2056         * WebFrame.cpp:
2057         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2058
2059 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2060
2061         Unreviewed rollout of r230632. Regression in memory usage.
2062
2063         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2064
2065         * WebPreferences.cpp:
2066         (WebPreferences::initializeDefaultSettings):
2067
2068 2018-04-17  Chris Dumez  <cdumez@apple.com>
2069
2070         Unreviewed attempt to fix the Windows build after r230721
2071
2072         * WebCoreSupport/WebFrameLoaderClient.cpp:
2073         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2074
2075 2018-04-17  Chris Dumez  <cdumez@apple.com>
2076
2077         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
2078         https://bugs.webkit.org/show_bug.cgi?id=184678
2079         <rdar://problem/39422122>
2080
2081         Reviewed by Alex Christensen.
2082
2083         Add new parameter to dispatchDecidePolicyForNavigationAction.
2084
2085         * WebCoreSupport/WebFrameLoaderClient.cpp:
2086         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2087         * WebCoreSupport/WebFrameLoaderClient.h:
2088
2089 2018-04-12  Antoine Quint  <graouts@apple.com>
2090
2091         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
2092         https://bugs.webkit.org/show_bug.cgi?id=184569
2093         <rdar://problem/38671301>
2094
2095         Reviewed by Jon Lee.
2096
2097         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
2098
2099         * WebPreferences.cpp:
2100
2101 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2102
2103         [WTF] Remove StaticLock
2104         https://bugs.webkit.org/show_bug.cgi?id=184332
2105
2106         Reviewed by Mark Lam.
2107
2108         * WebKitQuartzCoreAdditions/CAView.cpp:
2109         (WKQCA::CAView::releaseAllD3DResources):
2110         * WebLocalizableStrings.cpp:
2111
2112 2018-04-03  Chris Dumez  <cdumez@apple.com>
2113
2114         Drop MainFrame class
2115         https://bugs.webkit.org/show_bug.cgi?id=184191
2116
2117         Reviewed by Darin Adler.
2118
2119         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
2120         relationship between the Page and the MainFrame.
2121
2122         This is ground work for introducing LocalFrame / RemoteFrame concepts.
2123
2124         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2125         * WebCoreSupport/WebContextMenuClient.cpp:
2126         * WebCoreSupport/WebDragClient.cpp:
2127         * WebDropSource.cpp:
2128         * WebFrame.cpp:
2129         * WebView.cpp:
2130
2131 2018-03-26  Chris Dumez  <cdumez@apple.com>
2132
2133         Use SecurityOriginData more consistently in Service Worker code
2134         https://bugs.webkit.org/show_bug.cgi?id=183969
2135
2136         Reviewed by Darin Adler.
2137
2138         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2139
2140         * WebDatabaseManager.cpp:
2141         (WebDatabaseManager::databasesWithOrigin):
2142         (WebDatabaseManager::deleteOrigin):
2143         (WebDatabaseManager::deleteDatabase):
2144         (WebDatabaseManager::setQuota):
2145         * WebSecurityOrigin.cpp:
2146         (WebSecurityOrigin::usage):
2147         (WebSecurityOrigin::quota):
2148         (WebSecurityOrigin::setQuota):
2149
2150 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
2151
2152         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
2153         https://bugs.webkit.org/show_bug.cgi?id=183911
2154         <rdar://problem/38762306>
2155
2156         Reviewed by Youenn Fablet.
2157
2158         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
2159
2160         * WebView.cpp:
2161         (WebView::WebView):
2162
2163 2018-03-25  Commit Queue  <commit-queue@webkit.org>
2164
2165         Unreviewed, rolling out r229954.
2166         https://bugs.webkit.org/show_bug.cgi?id=184000
2167
2168         Caused many layout tests to crash on Apple High Sierra,
2169         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
2170         by dydz on #webkit).
2171
2172         Reverted changeset:
2173
2174         "Use SecurityOriginData more consistently in Service Worker
2175         code"
2176         https://bugs.webkit.org/show_bug.cgi?id=183969
2177         https://trac.webkit.org/changeset/229954
2178
2179 2018-03-24  Chris Dumez  <cdumez@apple.com>
2180
2181         Use SecurityOriginData more consistently in Service Worker code
2182         https://bugs.webkit.org/show_bug.cgi?id=183969
2183
2184         Reviewed by Darin Adler.
2185
2186         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2187
2188         * WebDatabaseManager.cpp:
2189         (WebDatabaseManager::databasesWithOrigin):
2190         (WebDatabaseManager::deleteOrigin):
2191         (WebDatabaseManager::deleteDatabase):
2192         (WebDatabaseManager::setQuota):
2193         * WebSecurityOrigin.cpp:
2194         (WebSecurityOrigin::usage):
2195         (WebSecurityOrigin::quota):
2196         (WebSecurityOrigin::setQuota):
2197
2198 2018-03-23  Chris Dumez  <cdumez@apple.com>
2199
2200         Unreviewed attempt to fix Windows build after r229926.
2201
2202         * WebView.cpp:
2203
2204 2018-03-23  Brady Eidson  <beidson@apple.com>
2205
2206         Go to back/forward list items after a process-swapped navigation.
2207         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
2208
2209         Reviewed by Andy Estes.
2210
2211         * WebView.cpp:
2212         (WebView::goToBackForwardItem):
2213         (WebView::loadBackForwardListFromOtherView):
2214
2215 2018-03-23  Miguel Gomez  <magomez@igalia.com>
2216
2217         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
2218         https://bugs.webkit.org/show_bug.cgi?id=183892
2219
2220         Remove the UpdateContentsFlag parameter as it's not used anymore.
2221
2222         Reviewed by Žan Doberšek.
2223
2224         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2225         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
2226
2227 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
2228
2229         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
2230         https://bugs.webkit.org/show_bug.cgi?id=183335
2231
2232         Reviewed by Alex Christensen.
2233
2234         * Plugins/PluginDatabaseWin.cpp:
2235         * Plugins/PluginMessageThrottlerWin.cpp:
2236         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
2237         * Plugins/PluginPackageWin.cpp:
2238         (WebCore::PluginPackage::load):
2239         * Plugins/PluginView.h:
2240         * Plugins/PluginViewWin.cpp:
2241         * Plugins/npapi.cpp:
2242         * WebCoreSupport/WebFrameLoaderClient.cpp:
2243         (WebFrameLoaderClient::createPlugin):
2244         (WebFrameLoaderClient::createJavaAppletWidget):
2245         * WebView.cpp:
2246         (WebView::WebViewWndProc):
2247
2248 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
2249
2250         [Win] Layout Test fast/html/menuitem-element.html is failing.
2251         https://bugs.webkit.org/show_bug.cgi?id=179299
2252
2253         Reviewed by Per Arne Vollan.
2254
2255         * Interfaces/IWebPreferencesPrivate.idl:
2256         * WebPreferenceKeysPrivate.h:
2257         * WebPreferences.cpp:
2258         (WebPreferences::menuItemElementEnabled):
2259         (WebPreferences::setMenuItemElementEnabled):
2260         * WebPreferences.h:
2261         * WebView.cpp:
2262         (WebView::notifyPreferencesChanged):
2263         Add private web preference "menuItemElementEnabled".
2264
2265 2018-03-12  Antoine Quint  <graouts@apple.com>
2266
2267         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
2268         https://bugs.webkit.org/show_bug.cgi?id=183504
2269         <rdar://problem/38372965>
2270
2271         Reviewed by Dean Jackson and Jon Lee.
2272
2273         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
2274         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
2275
2276         * Interfaces/IWebPreferencesPrivate.idl:
2277         * WebPreferences.cpp:
2278         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2279         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2280         * WebPreferenceKeysPrivate.h
2281         * WebPreferences.h:
2282         * WebView.cpp:
2283         (WebView::notifyPreferencesChanged):
2284
2285 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2286
2287         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
2288         https://bugs.webkit.org/show_bug.cgi?id=183429
2289
2290         Reviewed by Mark Lam.
2291
2292         * WebFrame.cpp:
2293         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2294
2295 2018-03-08  Tim Horton  <timothy_horton@apple.com>
2296
2297         Stop linking ApplicationServices directly
2298         https://bugs.webkit.org/show_bug.cgi?id=182867
2299         <rdar://problem/38252142>
2300
2301         Reviewed by Alex Christensen.
2302
2303         The frameworks that we use that live inside ApplicationServices
2304         have mostly moved out, so import them directly.
2305
2306         * FullscreenVideoController.cpp:
2307
2308 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2309
2310         Fix std::make_unique / new[] using system malloc
2311         https://bugs.webkit.org/show_bug.cgi?id=182975
2312
2313         Reviewed by JF Bastien.
2314
2315         Use Vector instead.
2316
2317         * MarshallingHelpers.cpp:
2318         (MarshallingHelpers::safeArrayToStringArray):
2319         (MarshallingHelpers::safeArrayToIntArray):
2320         * Plugins/PluginPackageWin.cpp:
2321         (WebCore::PluginPackage::fetchInfo):
2322         * WebPreferences.cpp:
2323         (WebPreferences::copyWebKitPreferencesToCFPreferences):
2324         * WebView.cpp:
2325         (WebView::onMenuCommand):
2326
2327 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2328
2329         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
2330         https://bugs.webkit.org/show_bug.cgi?id=183312
2331
2332         Reviewed by Mark Lam.
2333
2334         Remove wtf/CurrentTime.h include pragma.
2335
2336         * WebDownload.cpp:
2337         * WebDownloadCFNet.cpp:
2338         * WebDropSource.cpp:
2339
2340 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2341
2342         Remove monotonicallyIncreasingTime
2343         https://bugs.webkit.org/show_bug.cgi?id=182911
2344
2345         Reviewed by Michael Catanzaro.
2346
2347         * FullscreenVideoController.cpp:
2348         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
2349         * Plugins/PluginMessageThrottlerWin.cpp:
2350         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
2351         (WebCore::PluginMessageThrottlerWin::appendMessage):
2352         * Plugins/PluginMessageThrottlerWin.h:
2353         * WebView.cpp:
2354         (WebView::notifyAnimationStarted):
2355         * WebView.h:
2356
2357 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2358
2359         [Win][DRT] Implement setSpatialNavigationEnabled.
2360         https://bugs.webkit.org/show_bug.cgi?id=183166
2361
2362         Reviewed by Per Arne Vollan.
2363
2364         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
2365
2366         * Interfaces/IWebPreferencesPrivate.idl:
2367         * WebPreferenceKeysPrivate.h:
2368         * WebPreferences.cpp:
2369         (WebPreferences::initializeDefaultSettings):
2370         (WebPreferences::spatialNavigationEnabled):
2371         (WebPreferences::setSpatialNavigationEnabled):
2372         * WebPreferences.h:
2373         * WebView.cpp:
2374         (WebView::notifyPreferencesChanged):
2375
2376 2018-02-28  Alex Christensen  <achristensen@webkit.org>
2377
2378         Reduce use of NetworkingContext in WebKit
2379         https://bugs.webkit.org/show_bug.cgi?id=183213
2380
2381         Reviewed by Brady Eidson.
2382
2383         * Plugins/PluginView.cpp:
2384         (WebCore::PluginView::getValueForURL):
2385
2386 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
2387
2388         Fix WebCore includes within WebKitLegacy
2389         https://bugs.webkit.org/show_bug.cgi?id=183147
2390
2391         Reviewed by Tim Horton.
2392
2393         * Plugins/PluginDatabase.cpp:
2394         * Plugins/PluginDatabaseWin.cpp:
2395         * Plugins/PluginDebug.cpp:
2396         * Plugins/PluginDebug.h:
2397         * Plugins/PluginMainThreadScheduler.cpp:
2398         * Plugins/PluginMessageThrottlerWin.cpp:
2399         * Plugins/PluginMessageThrottlerWin.h:
2400         * Plugins/PluginPackage.cpp:
2401         * Plugins/PluginPackage.h:
2402         * Plugins/PluginPackageWin.cpp:
2403         * Plugins/PluginStream.cpp:
2404         * Plugins/PluginStream.h:
2405         * Plugins/PluginView.cpp:
2406         * Plugins/PluginView.h:
2407         * Plugins/PluginViewWin.cpp:
2408         * Plugins/npapi.cpp:
2409         * WebCoreSupport/WebChromeClient.cpp:
2410         * WebCoreSupport/WebContextMenuClient.cpp:
2411         * WebCoreSupport/WebFrameLoaderClient.cpp:
2412         * WebCoreSupport/WebInspectorClient.cpp:
2413         * WebCoreSupport/WebPlatformStrategies.cpp:
2414         * WebFrame.cpp:
2415         * WebKitMessageLoop.cpp:
2416         * WebView.cpp:
2417         * storage/WebDatabaseProvider.cpp:
2418
2419 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2420
2421         Remove currentTime() / currentTimeMS()
2422         https://bugs.webkit.org/show_bug.cgi?id=183052
2423
2424         Reviewed by Mark Lam.
2425
2426         * WebCoreSupport/WebFrameLoaderClient.cpp:
2427         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2428         * WebCoreSupport/WebFrameLoaderClient.h:
2429         * WebDownload.h:
2430         * WebDownloadCFNet.cpp:
2431         (WebDownload::didStart):
2432         (WebDownload::didReceiveData):
2433         (WebDownload::didFinish):
2434
2435 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
2436
2437         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
2438         https://bugs.webkit.org/show_bug.cgi?id=182883
2439
2440         Reviewed by Per Arne Vollan.
2441
2442         * WebKitPrefix.h:
2443
2444 2018-02-16  Dean Jackson  <dino@apple.com>
2445
2446         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
2447         https://bugs.webkit.org/show_bug.cgi?id=182894
2448
2449         Reviewed by Tim Horton.
2450
2451         Rename OPENGL_ES_2 to OPENGL_ES.
2452
2453         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2454
2455 2018-02-16  Youenn Fablet  <youenn@apple.com>
2456
2457         Allow specifying which plug-ins are supported
2458         https://bugs.webkit.org/show_bug.cgi?id=182748
2459
2460         Reviewed by Chris Dumez.
2461
2462         * WebCoreSupport/WebPluginInfoProvider.cpp:
2463         (WebPluginInfoProvider::getPluginInfo):
2464         * WebCoreSupport/WebPluginInfoProvider.h:
2465
2466 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
2467
2468         WebCore headers should not be included relatively within dependent projects
2469         https://bugs.webkit.org/show_bug.cgi?id=182805
2470
2471         Reviewed by Chris Dumez.
2472
2473         * FullscreenVideoController.h:
2474
2475 2018-02-13  Commit Queue  <commit-queue@webkit.org>
2476
2477         Unreviewed, rolling out r228431.
2478         https://bugs.webkit.org/show_bug.cgi?id=182766
2479
2480         Regressed CMake build stability (Requested by dolmstead on
2481         #webkit).
2482
2483         Reverted changeset:
2484
2485         "[CMake] Make WebCore headers copies"
2486         https://bugs.webkit.org/show_bug.cgi?id=182512
2487         https://trac.webkit.org/changeset/228431
2488
2489 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
2490
2491         [CMake] Make WebCore headers copies
2492         https://bugs.webkit.org/show_bug.cgi?id=182512
2493
2494         Reviewed by Keith Miller.
2495
2496         * FullscreenVideoController.h:
2497         * Plugins/PluginDatabase.cpp:
2498         * Plugins/PluginDatabaseWin.cpp:
2499         * Plugins/PluginDebug.cpp:
2500         * Plugins/PluginMainThreadScheduler.cpp:
2501         * Plugins/PluginMessageThrottlerWin.cpp:
2502         * Plugins/PluginPackage.cpp:
2503         * Plugins/PluginPackageWin.cpp:
2504         * Plugins/PluginStream.cpp:
2505         * Plugins/PluginView.cpp:
2506         * Plugins/PluginViewWin.cpp:
2507         * Plugins/npapi.cpp:
2508         * WebKitMessageLoop.cpp:
2509         * WebKitPrefix.h:
2510         * storage/WebDatabaseProvider.cpp:
2511
2512 2018-01-13  Darin Adler  <darin@apple.com>
2513
2514         Event improvements
2515         https://bugs.webkit.org/show_bug.cgi?id=179591
2516
2517         Reviewed by Chris Dumez.
2518
2519         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
2520         * WebFrame.cpp: Ditto.
2521
2522         * WebScriptWorld.cpp:
2523         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
2524
2525         * WebView.cpp: Removed include of ScriptValue.h.
2526         (WebView::handleEditingKeyboardEvent): Updated for name change from
2527         keyEvent to underlyingPlatformEvent.
2528
2529 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
2530
2531         Remove WebCore/ForwardingHeaders directory
2532         https://bugs.webkit.org/show_bug.cgi?id=182347
2533
2534         Reviewed by Keith Miller.
2535
2536         * Plugins/PluginView.cpp:
2537         * Plugins/PluginViewWin.cpp:
2538         * WebCoreSupport/WebInspectorClient.cpp:
2539         * WebCoreSupport/WebInspectorClient.h:
2540         * WebFrame.cpp:
2541         * WebJavaScriptCollector.cpp:
2542         * WebView.cpp:
2543
2544 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2545
2546         Unreviewed, another attempt to fix the Windows build after r227479.
2547
2548         * WebFrame.cpp:
2549         (WebFrame::elementWithName):
2550
2551 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2552
2553         Unreviewed, try to fix the Windows build after r227479.
2554
2555         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
2556
2557         * WebFrame.cpp:
2558         (WebFrame::elementWithName):
2559         (WebFrame::controlsInForm):
2560
2561 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
2562
2563         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
2564         https://bugs.webkit.org/show_bug.cgi?id=181859
2565         <rdar://problem/36659886>
2566
2567         Reviewed by Alex Christensen.
2568         
2569         Use local include patch.
2570
2571         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
2572         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
2573         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
2574
2575 2018-01-17  Youenn Fablet  <youenn@apple.com>
2576
2577         Put fetch Request.keepalive behind a runtime flag
2578         https://bugs.webkit.org/show_bug.cgi?id=181592
2579
2580         Reviewed by Chris Dumez.
2581
2582         * WebPreferences.cpp:
2583         (WebPreferences::fetchAPIKeepAliveEnabled):
2584         (WebPreferences::setFetchAPIKeepAliveEnabled):
2585         * WebPreferences.h:
2586         * WebView.cpp:
2587         (WebView::notifyPreferencesChanged):
2588
2589 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2590
2591         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2592         https://bugs.webkit.org/show_bug.cgi?id=181637
2593         <rdar://problem/36508471>
2594
2595         Reviewed by Tim Horton.
2596
2597         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
2598
2599         * WebCoreSupport/WebEditorClient.cpp:
2600         (WebEditorClient::replacementURLForResource):
2601         * WebCoreSupport/WebEditorClient.h:
2602
2603 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2604
2605         Remove std::chrono completely
2606         https://bugs.webkit.org/show_bug.cgi?id=181186
2607
2608         Reviewed by Alex Christensen.
2609
2610         * Plugins/PluginStream.cpp:
2611         (WebCore::lastModifiedDateMS):
2612
2613 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2614
2615         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
2616         https://bugs.webkit.org/show_bug.cgi?id=181173
2617
2618         Reviewed by Alex Christensen.
2619
2620         * WebNodeHighlight.cpp:
2621         (WebNodeHighlight::update): Scale the GraphicsContext.
2622
2623 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2624
2625         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
2626         https://bugs.webkit.org/show_bug.cgi?id=181160
2627
2628         Reviewed by Myles C. Maxfield.
2629
2630         * Plugins/PluginView.cpp:
2631         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
2632
2633 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2634
2635         Enable picture-in-picture from inline element on suspend.
2636         https://bugs.webkit.org/show_bug.cgi?id=180942
2637         rdar://problem/34745234
2638
2639         Reviewed by Jer Noble.
2640
2641         Update signature of enterVideoFullscreenForVideoElement.
2642
2643         * WebCoreSupport/WebChromeClient.cpp:
2644         (WebChromeClient::enterVideoFullscreenForVideoElement):
2645         * WebCoreSupport/WebChromeClient.h:
2646
2647 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2648
2649         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
2650         https://bugs.webkit.org/show_bug.cgi?id=180926
2651
2652         Reviewed by Tim Horton.
2653
2654         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
2655         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
2656
2657         * WebCoreSupport/WebFrameLoaderClient.cpp:
2658         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
2659         (WebFrameLoaderClient::pageID const): Ditto.
2660
2661 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2662
2663         Remove unnecessary boolean result of start() functions
2664         https://bugs.webkit.org/show_bug.cgi?id=180856
2665
2666         Reviewed by Darin Adler.
2667
2668         It always returns true.
2669
2670         * WebDownloadCurl.cpp:
2671         (WebDownload::start):
2672
2673 2017-12-14  John Wilander  <wilander@apple.com>
2674
2675         Storage Access API: Implement frame-specific access in the document.cookie layer
2676         https://bugs.webkit.org/show_bug.cgi?id=180682
2677         <rdar://problem/35982257>
2678
2679         Reviewed by Alex Christensen.
2680
2681         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
2682         CookiesStrategy::cookieRequestHeaderFieldValue(), and
2683         CookiesStrategy::getRawCookies() now take optional parameters for
2684         frameID and pageID to allow frame-specific scoping of cookies.
2685
2686         This change makes the return values of FrameLoaderClient::frameID()
2687         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
2688         WebCore can call those getters and get the right return values in
2689         WebKit and std:nullopt in WebKitLegacy.
2690
2691         * WebCoreSupport/WebFrameLoaderClient.cpp:
2692         (WebFrameLoaderClient::pageID const):
2693         (WebFrameLoaderClient::frameID const):
2694             Now return an optional.
2695         * WebCoreSupport/WebFrameLoaderClient.h:
2696         * WebCoreSupport/WebPlatformStrategies.cpp:
2697         (WebPlatformStrategies::cookiesForDOM):
2698         (WebPlatformStrategies::setCookiesFromDOM):
2699         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2700         (WebPlatformStrategies::getRawCookies):
2701         * WebCoreSupport/WebPlatformStrategies.h:
2702
2703 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2704
2705         [WTF] Thread::create should have Thread::tryCreate
2706         https://bugs.webkit.org/show_bug.cgi?id=180333
2707
2708         Reviewed by Darin Adler.
2709
2710         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
2711         (WKQCA::CVDisplayLink::start):
2712
2713 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2714
2715         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
2716         https://bugs.webkit.org/show_bug.cgi?id=180572
2717
2718         Reviewed by Mark Lam.
2719
2720         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
2721         Also we use Lock instead of Mutex.
2722
2723         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
2724         (WKQCA::CAD3DRenderer::swapChain):
2725         (WKQCA::CAD3DRenderer::renderAndPresent):
2726         (WKQCA::CAD3DRenderer::renderToImage):
2727         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2728         (WKQCA::CAD3DRenderer::renderInternal):
2729         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
2730         * WebKitQuartzCoreAdditions/CAView.cpp:
2731         (WKQCA::CAView::Handle::create):
2732         Return Ref<Handle> instead of RefPtr<>.
2733
2734         (WKQCA::CAView::Handle::lock):
2735         (WKQCA::CAView::Handle::view const):
2736         (WKQCA::CAView::Handle::clear):
2737         (WKQCA::views):
2738         (WKQCA::viewsNeedingUpdate):
2739         (WKQCA::CAView::releaseAllD3DResources):
2740         (WKQCA::CAView::CAView):
2741         (WKQCA::CAView::~CAView):
2742         (WKQCA::CAView::setLayer):
2743         (WKQCA::CAView::update):
2744         (WKQCA::CAView::drawToWindow):
2745         (WKQCA::CAView::drawToWindowInternal):
2746         (WKQCA::CAView::drawToImage):
2747         (WKQCA::CAView::willDraw):
2748         (WKQCA::CAView::drawIntoDC):
2749         (WKQCA::CAView::setShouldInvertColors):
2750         (WKQCA::CAView::scheduleNextDraw):
2751         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2752         (WKQCA::CAView::contextDidChange):
2753         (WKQCA::CAView::updateSoon):
2754         (WKQCA::CAView::updateViewsNow):
2755         (WKQCA::CAView::d3dDevice9):
2756         (WKQCA::CAView::Handle::mutex): Deleted.
2757         (WKQCA::globalStateMutex): Deleted.
2758         (): Deleted.
2759         * WebKitQuartzCoreAdditions/CAView.h:
2760
2761 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2762
2763         Use StaticLock instead of NeverDestroyed<Lock>
2764         https://bugs.webkit.org/show_bug.cgi?id=180507
2765
2766         Reviewed by Saam Barati.
2767
2768         * WebLocalizableStrings.cpp:
2769         (findCachedString):
2770         (cacheString):
2771         (mainBundleLocStrings): Deleted.
2772         (frameworkLocStringsMutex): Deleted.
2773
2774 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
2775
2776         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
2777         https://bugs.webkit.org/show_bug.cgi?id=180431
2778         <rdar://problem/34531264>
2779
2780         Reviewed by Simon Fraser.
2781
2782         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
2783         'override' to make sure this doesn't break in the future.
2784
2785         * WebView.cpp:
2786         (WebView::notifyAnimationStarted):
2787         (WebView::paintContents):
2788         * WebView.h:
2789
2790 2017-11-23  Darin Adler  <darin@apple.com>
2791
2792         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2793         https://bugs.webkit.org/show_bug.cgi?id=179981
2794
2795         Reviewed by Sam Weinig.
2796
2797         * WebView.cpp:
2798         (WebView::searchFor): Use |= instead of | to build FindOptions.
2799         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
2800         (WebView::findString): Create FindOptions with |=; the old code just passed a
2801         WebKit FindOptions through without converting to WebCore::FindOptions.
2802
2803 2017-11-23  Darin Adler  <darin@apple.com>
2804
2805         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2806         https://bugs.webkit.org/show_bug.cgi?id=179907
2807
2808         Reviewed by Sam Weinig.
2809
2810         * Plugins/PluginDatabaseWin.cpp:
2811         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
2812         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
2813         * WebDownloadCFNet.cpp:
2814         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
2815
2816         * WebView.cpp:
2817         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
2818         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
2819         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
2820         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
2821         the code does not cause any change in behavior.
2822
2823 2017-11-22  Ali Juma  <ajuma@chromium.org>
2824
2825         Implement VisualViewport API attributes
2826         https://bugs.webkit.org/show_bug.cgi?id=179385
2827
2828         Reviewed by Frédéric Wang.
2829
2830         Add a VisualViewportAPI preference.
2831
2832         * Interfaces/IWebPreferencesPrivate.idl:
2833         * WebPreferenceKeysPrivate.h:
2834         * WebPreferences.cpp:
2835         (WebPreferences::initializeDefaultSettings):
2836         (WebPreferences::visualViewportAPIEnabled):
2837         (WebPreferences::setVisualViewportAPIEnabled):
2838         * WebPreferences.h:
2839         * WebView.cpp:
2840         (WebView::notifyPreferencesChanged):
2841
2842 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2843
2844         Unreviewed, rolling out r225093.
2845         https://bugs.webkit.org/show_bug.cgi?id=179938
2846
2847         Compilation failed on WinCairo 64-bit Release (Requested by
2848         fredw on #webkit).
2849
2850         Reverted changeset:
2851
2852         "Implement VisualViewport API attributes"
2853         https://bugs.webkit.org/show_bug.cgi?id=179385
2854         https://trac.webkit.org/changeset/225093
2855
2856 2017-11-21  Ali Juma  <ajuma@chromium.org>
2857
2858         Implement VisualViewport API attributes
2859         https://bugs.webkit.org/show_bug.cgi?id=179385
2860
2861         Reviewed by Frédéric Wang.
2862
2863         Add a VisualViewportAPI preference.
2864
2865         * Interfaces/IWebPreferencesPrivate.idl:
2866         * WebPreferenceKeysPrivate.h:
2867         * WebPreferences.cpp:
2868         (WebPreferences::initializeDefaultSettings):
2869         (WebPreferences::visualViewportAPIEnabled):
2870         (WebPreferences::setVisualViewportAPIEnabled):
2871         * WebPreferences.h:
2872         * WebView.cpp:
2873         (WebView::notifyPreferencesChanged):
2874
2875 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2876
2877         Clean up old URL parser remnants
2878         https://bugs.webkit.org/show_bug.cgi?id=179573
2879
2880         Reviewed by Darin Adler.
2881
2882         * WebCoreSupport/WebContextMenuClient.cpp:
2883         (WebContextMenuClient::searchWithGoogle):
2884         Use https if we do end up searching with google.
2885
2886 2017-11-12  Darin Adler  <darin@apple.com>
2887
2888         More is<> and downcast<>, less static_cast<>
2889         https://bugs.webkit.org/show_bug.cgi?id=179600
2890
2891         Reviewed by Chris Dumez.
2892
2893         * WebView.cpp:
2894         (WebView::handleEditingKeyboardEvent): Use downcast.
2895
2896 2017-11-09  Christopher Reid  <chris.reid@sony.com>
2897
2898         Use enum classes within FileSystem
2899         https://bugs.webkit.org/show_bug.cgi?id=175172
2900
2901         Reviewed by Darin Adler.
2902
2903         * Plugins/PluginDatabase.cpp:
2904
2905 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
2906
2907         [Win] Add WebKitQuartzCoreAdditions library.
2908         https://bugs.webkit.org/show_bug.cgi?id=179331
2909
2910         Reviewed by Alex Christensen.
2911
2912         * WebKitQuartzCoreAdditions: Added.
2913         * WebKitQuartzCoreAdditions/API: Added.
2914         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
2915         (toImage):
2916         (WKCACFImageGetWidth):
2917         (WKCACFImageGetHeight):
2918         (WKCACFImageCopyFileMapping):
2919         (WKCACFImageCreateWithImage):
2920         (WKCACFImageFinalize):
2921         (WKCACFImageCopyFormattingDescription):
2922         (WKCACFImageCopyDebugDescription):
2923         (WKCACFImageGetTypeID):
2924         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
2925         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
2926         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
2927         (toView):
2928         (toImpl):
2929         (WKCACFViewCreate):
2930         (WKCACFViewSetLayer):
2931         (WKCACFViewUpdate):
2932         (WKCACFViewFlushContext):
2933         (WKCACFViewInvalidateRects):
2934         (WKCACFViewCanDraw):
2935         (WKCACFViewDraw):
2936         (WKCACFViewCopyDrawnImage):
2937         (WKCACFViewDrawIntoDC):
2938         (contextDidChangeCallback):
2939         (WKCACFViewSetContextDidChangeCallback):
2940         (WKCACFViewGetLastCommitTime):
2941         (WKCACFViewSetContextUserData):
2942         (WKCACFViewGetContext):
2943         (WKCACFViewFinalize):
2944         (WKCACFViewCopyFormattingDescription):
2945         (WKCACFViewCopyDebugDescription):
2946         (WKCACFViewGetTypeID):
2947         (WKCACFViewSetShouldInvertColors):
2948         (WKCACFViewGetD3DDevice9):
2949         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
2950         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
2951         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
2952         (WKQCA::dllInstance):
2953         (DllMain):
2954         (WKCACFShutDown):
2955         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
2956         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
2957         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
2958         (WKQCA::d3d):
2959         (WKQCA::initialPresentationParameters):
2960         (WKQCA::CAD3DRenderer::shared):
2961         (WKQCA::CAD3DRenderer::CAD3DRenderer):
2962         (WKQCA::CAD3DRenderer::swapChain):
2963         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
2964         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
2965         (WKQCA::CAD3DRenderer::initialize):
2966         (WKQCA::D3DMatrixOrthoOffCenterRH):
2967         (WKQCA::prepareDevice):
2968         (WKQCA::updateBounds):
2969         (WKQCA::CAD3DRenderer::renderAndPresent):
2970         (WKQCA::CAD3DRenderer::renderToImage):
2971         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2972         (WKQCA::CAD3DRenderer::renderInternal):
2973         (WKQCA::CAD3DRenderer::postProcess):
2974         (WKQCA::CAD3DRenderer::resetD3DDevice):
2975         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
2976         (WKQCA::CAD3DRenderer::release):
2977         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
2978         (WKQCA::D3DPostProcessingContext::sceneTexture const):
2979         (WKQCA::D3DPostProcessingContext::overlayQuad const):
2980         (WKQCA::CAD3DRenderer::d3dDevice9 const):
2981         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
2982         (WKQCA::CAView::Handle::create):
2983         (WKQCA::CAView::Handle::~Handle):
2984         (WKQCA::CAView::Handle::mutex):
2985         (WKQCA::CAView::Handle::view const):
2986         (WKQCA::CAView::Handle::clear):
2987         (WKQCA::CAView::Handle::Handle):
2988         (WKQCA::globalStateMutex):
2989         (WKQCA::registerMessageWindowClass):
2990         (WKQCA::createMessageWindow):
2991         (WKQCA::CAView::releaseAllD3DResources):
2992         (WKQCA::CAView::CAView):
2993         (WKQCA::CAView::~CAView):
2994         (WKQCA::CAView::create):
2995         (WKQCA::CAView::setContextDidChangeCallback):
2996         (WKQCA::CAView::setLayer):
2997         (WKQCA::CAView::update):
2998         (WKQCA::CAView::invalidateRects):
2999         (WKQCA::CAView::drawToWindow):
3000         (WKQCA::CAView::drawToWindowInternal):
3001         (WKQCA::CAView::drawToImage):
3002         (WKQCA::CAView::willDraw):
3003         (WKQCA::CAView::didDraw):
3004         (WKQCA::CAView::drawIntoDC):
3005         (WKQCA::CAView::setShouldInvertColors):
3006         (WKQCA::CAView::scheduleNextDraw):
3007         (WKQCA::CAView::displayLinkReachedCAMediaTime):
3008         (WKQCA::CAView::contextDidChangeCallback):
3009         (WKQCA::CAView::contextDidChange):
3010         (WKQCA::CAView::updateSoon):
3011         (WKQCA::CAView::updateViewsNow):
3012         (WKQCA::CAView::d3dDevice9):
3013         * WebKitQuartzCoreAdditions/CAView.h: Added.
3014         (WKQCA::CAView::context const):
3015         (WKQCA::CAView::canDraw const):
3016         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
3017         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
3018         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
3019         (WKQCA::CVDisplayLink::CVDisplayLink):
3020         (WKQCA::CVDisplayLink::~CVDisplayLink):
3021         (WKQCA::CVDisplayLink::create):
3022         (WKQCA::CVDisplayLink::start):
3023         (WKQCA::CVDisplayLink::stop):
3024         (WKQCA::CVDisplayLink::setPaused):
3025         (WKQCA::CVDisplayLink::runIOThread):
3026         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
3027         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
3028         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
3029         * WebKitQuartzCoreAdditions/Image.cpp: Added.
3030         (WKQCA::numBytesForSize):
3031         (WKQCA::Image::create):
3032         (WKQCA::Image::Image):
3033         (WKQCA::Image::~Image):
3034         (WKQCA::bitmapInfo):
3035         (WKQCA::Image::createDIB const):
3036         (WKQCA::Image::copyFileMapping):
3037         * WebKitQuartzCoreAdditions/Image.h: Added.
3038         (WKQCA::Image::size const):
3039         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
3040         (WKQCA::getBackBufferRectAsRenderTarget):
3041         (WKQCA::getSystemMemoryCopy):
3042         (WKQCA::copyRectToBitmap):
3043         (WKQCA::getImageCopy):
3044         (WKQCA::getBackBufferRectAsImage):
3045         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
3046         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
3047         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
3048         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
3049         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
3050
3051 2017-11-06  Christopher Reid  <chris.reid@sony.com>
3052
3053         Use enum classes within FileSystem
3054         https://bugs.webkit.org/show_bug.cgi?id=175172
3055
3056         Reviewed by Myles C. Maxfield.
3057
3058         * Plugins/PluginDatabase.cpp:
3059
3060 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
3061
3062         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
3063         https://bugs.webkit.org/show_bug.cgi?id=178333
3064
3065         Reviewed by Darin Adler.
3066
3067         * WebCoreSupport/WebFrameLoaderClient.cpp:
3068         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
3069
3070 2017-11-02  Alex Christensen  <achristensen@webkit.org>
3071
3072         Use CompletionHandlers for redirects
3073         https://bugs.webkit.org/show_bug.cgi?id=179163
3074
3075         Reviewed by Tim Horton.
3076
3077         * Plugins/PluginStream.cpp:
3078         (WebCore::PluginStream::willSendRequest):
3079         * Plugins/PluginStream.h:
3080         (WebCore::PluginStreamClient::~PluginStreamClient):
3081         (WebCore::PluginStreamClient::streamDidFinishLoading):
3082         (WebCore::PluginStream::create):
3083         (WebCore::PluginStream::setLoadManually):
3084
3085 2017-11-02  Christopher Reid  <chris.reid@sony.com>
3086
3087         Add a FileSystem namespace to FileSystem.cpp
3088         https://bugs.webkit.org/show_bug.cgi?id=179063
3089
3090         Reviewed by Darin Adler.
3091
3092         * Plugins/PluginDatabase.cpp:
3093         * Plugins/PluginPackage.cpp:
3094         * Plugins/PluginStream.cpp:
3095         * Plugins/PluginStream.h:
3096         * WebApplicationCache.cpp:
3097         * WebDatabaseManager.cpp:
3098         * WebDownloadCurl.cpp:
3099         * WebPreferences.cpp:
3100         * WebView.cpp:
3101
3102 2017-10-31  Alex Christensen  <achristensen@webkit.org>
3103
3104         Fix Windows build after r224260
3105
3106         * WebView.cpp:
3107         (WebView::gesture):
3108
3109 2017-10-28  Zalan Bujtas  <zalan@apple.com>
3110
3111         [FrameView::layout cleanup] Move core layout logic to a separate class.
3112         https://bugs.webkit.org/show_bug.cgi?id=178771
3113         <rdar://problem/35166542>
3114
3115         Reviewed by Simon Fraser.
3116
3117         Move layout code out from FrameView to LayoutContext.
3118
3119         * WebFrame.cpp:
3120         (WebFrame::layout):
3121
3122 2017-10-26  Alex Christensen  <achristensen@webkit.org>
3123
3124         Fix Windows build
3125         https://bugs.webkit.org/show_bug.cgi?id=178892
3126
3127         * AccessibleBase.cpp:
3128         (MSAARole):
3129
3130 2017-10-26  Alex Christensen  <achristensen@webkit.org>
3131
3132         Fix Windows build
3133         https://bugs.webkit.org/show_bug.cgi?id=178892
3134
3135         * AccessibleBase.cpp:
3136         (AccessibleBase::state const):
3137         (MSAARole):
3138
3139 2017-10-25  Youenn Fablet  <youenn@apple.com>
3140
3141         Enable ServiceWorker to fetch resources
3142         https://bugs.webkit.org/show_bug.cgi?id=178673
3143
3144         Reviewed by Brady Eidson.
3145
3146         Added implementation to the new getters.
3147         They are noop in the context of WK1.
3148
3149         * WebCoreSupport/WebFrameLoaderClient.cpp:
3150         (WebFrameLoaderClient::pageID const):
3151         (WebFrameLoaderClient::frameID const):
3152         (WebFrameLoaderClient::sessionID const):
3153         * WebCoreSupport/WebFrameLoaderClient.h:
3154
3155 2017-10-20  Antoine Quint  <graouts@apple.com>
3156
3157         [Web Animations] Provide basic timeline and animation interfaces
3158         https://bugs.webkit.org/show_bug.cgi?id=178526
3159
3160         Reviewed by Dean Jackson.
3161
3162         Remove the WEB_ANIMATIONS compile-time flag.
3163
3164         * WebView.cpp:
3165         (WebView::notifyPreferencesChanged):
3166
3167 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3168
3169         [Curl] Clean up old style code in old curl files.
3170         https://bugs.webkit.org/show_bug.cgi?id=178569
3171
3172         Reviewed by Ryosuke Niwa.
3173
3174         * WebCache.cpp:
3175         (WebCache::cacheFolder):
3176         (WebCache::setCacheFolder):
3177         * WebView.cpp:
3178         (WebView::setCacheModel):
3179
3180 2017-10-19  Sam Weinig  <sam@webkit.org>
3181
3182         [Settings] Move global settings into their own file
3183         https://bugs.webkit.org/show_bug.cgi?id=178512
3184
3185         Reviewed by Darin Adler.
3186
3187         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
3188
3189         * WebView.cpp:
3190         (WebView::initWithFrame):
3191
3192 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
3193
3194         Replace some stack raw pointers with RefPtrs within WebCore/html
3195         https://bugs.webkit.org/show_bug.cgi?id=178201
3196         <rdar://problem/34841692>
3197
3198         Reviewed by Ryosuke Niwa.
3199
3200         * WebView.cpp:
3201         (WebView::handleEditingKeyboardEvent):
3202         Change the type of node as toNode() is changed to return RefPtr.
3203
3204 2017-10-16  Sam Weinig  <sam@webkit.org>
3205
3206         [Settings] Remove all custom code from Settings.h/cpp
3207         https://bugs.webkit.org/show_bug.cgi?id=178330
3208
3209         Reviewed by Simon Fraser.
3210
3211         * WebView.cpp:
3212         (WebView::notifyPreferencesChanged):
3213             
3214             Update for naming changes of FrameFlattening now that it is an enum class.
3215
3216 2017-10-11  Chris Dumez  <cdumez@apple.com>
3217
3218         Modernize Geolocation code
3219         https://bugs.webkit.org/show_bug.cgi?id=178148
3220
3221         Reviewed by Ryosuke Niwa.
3222
3223         * WebCoreSupport/WebGeolocationClient.cpp:
3224         (WebGeolocationClient::lastPosition):
3225         * WebCoreSupport/WebGeolocationClient.h:
3226         * WebGeolocationPosition.cpp:
3227         (WebGeolocationPosition::initWithTimestamp):
3228         (core):
3229         * WebGeolocationPosition.h:
3230         (WebGeolocationPosition::impl const):
3231
3232 2017-10-05  Chris Dumez  <cdumez@apple.com>
3233
3234         Drop unused parameters for CookiesStrategy::cookiesEnabled()
3235         https://bugs.webkit.org/show_bug.cgi?id=177957
3236
3237         Reviewed by Alex Christensen.
3238
3239         * WebCoreSupport/WebPlatformStrategies.cpp:
3240         (WebPlatformStrategies::cookiesEnabled):
3241         * WebCoreSupport/WebPlatformStrategies.h:
3242
3243 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3244
3245         [Curl] Reimplement CurlDownload with CurlRequest
3246         https://bugs.webkit.org/show_bug.cgi?id=177779
3247
3248         Reviewed by Alex Christensen.
3249
3250         * WebDownload.h:
3251         * WebDownloadCurl.cpp:
3252         (WebDownload::init):
3253         (WebDownload::didReceiveResponse):
3254
3255 2017-09-29  Chris Dumez  <cdumez@apple.com>
3256
3257         Split some logic out of VisitedLinkStore and make it reusable
3258         https://bugs.webkit.org/show_bug.cgi?id=177575
3259
3260         Reviewed by Alex Christensen.
3261
3262         * WebCoreSupport/WebVisitedLinkStore.cpp:
3263         (WebVisitedLinkStore::addVisitedLink):
3264         (WebVisitedLinkStore::isLinkVisited):
3265         (WebVisitedLinkStore::addVisitedLinkHash):
3266         * WebCoreSupport/WebVisitedLinkStore.h:
3267
3268 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3269
3270         Make PolicyAction an encodable enum class
3271         https://bugs.webkit.org/show_bug.cgi?id=177480
3272
3273         Reviewed by Antti Koivisto.
3274
3275         * WebCoreSupport/WebFrameLoaderClient.cpp:
3276         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3277         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3278         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3279         * WebFramePolicyListener.cpp:
3280         (WebFramePolicyListener::use):
3281         (WebFramePolicyListener::download):
3282         (WebFramePolicyListener::ignore):
3283         (WebFramePolicyListener::continueSubmit):
3284
3285 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
3286
3287         [Win] fast/canvas/2d.getPath.modification.html is failing.
3288         https://bugs.webkit.org/show_bug.cgi?id=176534
3289
3290         Reviewed by Alex Christensen.
3291
3292         We need to enable Inspector additions at runtime in order to expose the getPath function.
3293
3294         * Interfaces/IWebPreferencesPrivate.idl:
3295         * WebPreferenceKeysPrivate.h:
3296         * WebPreferences.cpp:
3297         (WebPreferences::initializeDefaultSettings):
3298         (WebPreferences::setDataTransferItemsEnabled):
3299         (WebPreferences::inspectorAdditionsEnabled):
3300         (WebPreferences::setInspectorAdditionsEnabled):
3301         * WebPreferences.h:
3302         * WebView.cpp:
3303         (WebView::notifyPreferencesChanged):
3304
3305 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3306
3307         Modernize Geolocation code
3308         https://bugs.webkit.org/show_bug.cgi?id=176496
3309
3310         Reviewed by Andy Estes.
3311
3312         * WebCoreSupport/WebGeolocationClient.cpp:
3313         (WebGeolocationClient::requestPermission):
3314         * WebCoreSupport/WebGeolocationClient.h:
3315         (WebGeolocationClient::setEnableHighAccuracy): Deleted.
3316         (WebGeolocationClient::cancelPermissionRequest): Deleted.
3317         * WebGeolocationPolicyListener.h:
3318         * WebView.cpp:
3319         (WebView::initWithFrame):
3320         (WebView::geolocationDidFailWithError):
3321
3322 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
3323
3324         [Win] Enable DatatransferItems in DRT.
3325         https://bugs.webkit.org/show_bug.cgi?id=176424
3326
3327         Reviewed by Brent Fulgham.
3328
3329         * Interfaces/IWebPreferencesPrivate.idl:
3330         * WebPreferenceKeysPrivate.h:
3331         * WebPreferences.cpp:
3332         (WebPreferences::initializeDefaultSettings):
3333         (WebPreferences::QueryInterface):
3334         (WebPreferences::isSecureContextAttributeEnabled):
3335         (WebPreferences::dataTransferItemsEnabled):
3336         (WebPreferences::setDataTransferItemsEnabled):
3337         * WebPreferences.h:
3338         * WebView.cpp:
3339         (WebView::notifyPreferencesChanged):
3340
3341 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3342
3343         Unreviewed build fix #2 after r221275.
3344
3345         * WebCoreSupport/WebPlatformStrategies.cpp:
3346         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
3347         to match new API.
3348         * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
3349
3350 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3351
3352         Unreviewed build fix after r221275.
3353
3354         * WebCoreSupport/WebPlatformStrategies.cpp:
3355         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
3356         to match new API.
3357
3358 2017-08-28  Per Arne Vollan  <pvollan@apple.com>
3359
3360         [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
3361         https://bugs.webkit.org/show_bug.cgi?id=176031
3362
3363         Reviewed by Brent Fulgham.
3364
3365         When the function in the FramePolicyFunction parameter is called, it has already been moved
3366         to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
3367         function by using the stored member instead.
3368
3369         * WebCoreSupport/WebFrameLoaderClient.cpp:
3370         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3371         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3372         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3373
3374 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3375
3376         Unreviewed, try to fix the Windows build after r221064
3377
3378         didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
3379
3380         * WebCoreSupport/WebEditorClient.h:
3381
3382 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3383
3384         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3385         https://bugs.webkit.org/show_bug.cgi?id=175370
3386         <rdar://problem/33799806>
3387
3388         Reviewed by Ryosuke Niwa.
3389
3390         Adjust WebEditorClient for interface changes.
3391
3392         * WebCoreSupport/WebEditorClient.h:
3393
3394 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
3395
3396         Unreviewed build fix after r221017.
3397
3398         Correct copy/paste error.
3399
3400         * WebCoreSupport/WebPlatformStrategies.cpp:
3401         (WebPlatformStrategies::cookiesForDOM):
3402
3403 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
3404
3405         Unreviewed build fix after r221017.
3406
3407         * WebCoreSupport/WebPlatformStrategies.cpp:
3408         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
3409         * WebCoreSupport/WebPlatformStrategies.h:
3410
3411 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3412
3413         Remove ChromeClient::scrollbarsModeDidChange
3414         https://bugs.webkit.org/show_bug.cgi?id=175805
3415
3416         Reviewed by Daniel Bates.
3417
3418         * WebCoreSupport/WebChromeClient.h:
3419
3420 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3421
3422         Remove ChromeClient::hasOpenedPopup
3423         https://bugs.webkit.org/show_bug.cgi?id=175804
3424
3425         Reviewed by Sam Weinig.
3426
3427         * WebCoreSupport/WebChromeClient.cpp:
3428         (WebChromeClient::hasOpenedPopup const): Deleted.
3429         * WebCoreSupport/WebChromeClient.h:
3430
3431 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
3432
3433         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
3434         https://bugs.webkit.org/show_bug.cgi?id=173536
3435
3436         Reviewed by Brent Fulgham.
3437
3438         If the tree state is dirty, accessible objects are deleted while iterating over children
3439         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
3440         style is updated before this method is called.
3441
3442         * AccessibleBase.cpp:
3443         (AccessibleBase::getAccessibilityObjectForChild):
3444
3445 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3446
3447         [PAL] Move SessionID into PAL
3448         https://bugs.webkit.org/show_bug.cgi?id=174192
3449
3450         Reviewed by Antti Koivisto.
3451
3452         * WebCoreSupport/WebFrameLoaderClient.cpp:
3453         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3454         * WebCoreSupport/WebFrameLoaderClient.h:
3455         * WebCoreSupport/WebFrameNetworkingContext.cpp:
3456         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
3457         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3458         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3459         (WebFrameNetworkingContext::storageSession const):
3460         * WebCoreSupport/WebPlatformStrategies.cpp:
3461         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3462         * WebCoreSupport/WebPlatformStrategies.h:
3463
3464 2017-08-15  Youenn Fablet  <youenn@apple.com>
3465
3466         [Cache API] Adding generic support for CacheStorage and Cache methods
3467         https://bugs.webkit.org/show_bug.cgi?id=175455
3468
3469         Reviewed by Chris Dumez.
3470
3471         * WebView.cpp:
3472         (WebView::initWithFrame):
3473
3474 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3475
3476         Composition underline color is always black
3477         https://bugs.webkit.org/show_bug.cgi?id=174675
3478
3479         Reviewed by Ryosuke Niwa.
3480
3481         * WebView.cpp:
3482         (WebView::setCompositionForTesting): Use text color for
3483         composition underline.
3484
3485 2017-08-09  Daniel Bates  <dabates@apple.com>
3486
3487         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3488         https://bugs.webkit.org/show_bug.cgi?id=175247
3489         <rdar://problem/33679804>
3490
3491         Reviewed by Brady Eidson.
3492
3493         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3494         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3495         clients that need to make use of this information at this time. If such a needs comes up
3496         then we can expose API/SPI similar to what we do for WebKit.
3497
3498         * WebCoreSupport/WebFrameLoaderClient.cpp:
3499         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3500         * WebCoreSupport/WebFrameLoaderClient.h:
3501
3502 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3503
3504         Async image decoding for large images should be disabled after the first time a tile is painted
3505         https://bugs.webkit.org/show_bug.cgi?id=174451
3506         <rdar://problem/31246421>
3507
3508         Reviewed by Simon Fraser.
3509
3510         * FullscreenVideoController.cpp:
3511         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3512         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3513         (AcceleratedCompositingContext::paintContents):
3514         * WebCoreSupport/AcceleratedCompositingContext.h:
3515
3516 2017-07-23  Darin Adler  <darin@apple.com>
3517
3518         More NeverDestroyed and related cleanup
3519         https://bugs.webkit.org/show_bug.cgi?id=174745
3520
3521         Reviewed by Alex Christensen.
3522
3523         * Plugins/PluginDatabase.cpp:
3524         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
3525         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
3526         * Plugins/PluginMainThreadScheduler.cpp:
3527         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
3528         * Plugins/PluginMainThreadScheduler.h: Ditto.
3529         * WebCoreSupport/WebPlatformStrategies.cpp:
3530         (WebPlatformStrategies::initialize): Ditto.
3531         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
3532         * WebHistory.cpp:
3533         (sharedHistoryStorage): Ditto.
3534         * WebLocalizableStrings.cpp:
3535         (mainBundleLocStrings): Ditto.
3536         (frameworkLocStringsMutex): Ditto.
3537         (frameworkLocStrings): Ditto.
3538         * WebView.cpp:
3539         (WebView::standardUserAgentWithApplicationName): Ditto.
3540         Also changed to keep one global string with the prefix of the user agent string
3541         instead of keeping two globals with pieces of that prefix.
3542
3543 2017-07-24  Chris Dumez  <cdumez@apple.com>
3544
3545         Make ExceptionCode a proper enumeration
3546         https://bugs.webkit.org/show_bug.cgi?id=174771
3547
3548         Reviewed by Sam Weinig.
3549
3550         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
3551
3552         * DOMCoreClasses.cpp:
3553         (DOMDocument::createEvent):
3554         * WebView.cpp:
3555         (WebView::prepareCandidateWindow):