[Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode...
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2019-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2
3         [Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
4         https://bugs.webkit.org/show_bug.cgi?id=192581
5         <rdar://problem/46651605>
6
7         Reviewed by Alex Christensen.
8
9         WebKitLegacy COM interfaces have same name methods within the old
10         and new interfaces. For example, both IWebEditingDelegate and
11         IWebEditingDelegate2 interfaces have 'shouldInsertNode' method.
12         This is a part of public API, can't be renamed.
13
14         * Interfaces/IWebEditingDelegate.idl:
15         * Interfaces/IWebViewPrivate.idl:
16         Added #pragma to ignore the warning.
17
18 2019-09-09  Fujii Hironori  <Hironori.Fujii@sony.com>
19
20         [Win][WebKitLegacy] WebKitDLL.h(53,37): warning: 'gClassNameCount' has C-linkage specified, but returns user-defined type 'HashCountedSet<WTF::String> &' which is incompatible with C [-Wreturn-type-c-linkage]
21         https://bugs.webkit.org/show_bug.cgi?id=201601
22
23         Reviewed by Ross Kirsling.
24
25         Fixed a clang-cl warning. Names which aren't dllexport-ed don't
26         need to be in a extern "C" scope because they aren't exported to
27         other DLLs.
28
29         * WebKitDLL.h: Moved some variables and gClassNameCount() out of extern "C" scope.
30
31 2019-09-06  Alex Christensen  <achristensen@webkit.org>
32
33         When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID
34         https://bugs.webkit.org/show_bug.cgi?id=201480
35
36         Reviewed by Youenn Fablet.
37
38         * WebView.cpp:
39         (WebView::notifyPreferencesChanged):
40
41 2019-09-06  Rob Buis  <rbuis@igalia.com>
42
43         Add runtime flag for lazy image loading
44         https://bugs.webkit.org/show_bug.cgi?id=199794
45
46         Reviewed by Frédéric Wang.
47
48         Remove parts of r248409 that were meant for WK1 since
49         lazy image loading is WK2 only.
50
51         * Interfaces/IWebPreferencesPrivate.idl:
52         * WebPreferenceKeysPrivate.h:
53         * WebPreferences.cpp:
54         (WebPreferences::initializeDefaultSettings):
55         (WebPreferences::setResizeObserverEnabled):
56         (WebPreferences::lazyImageLoadingEnabled): Deleted.
57         (WebPreferences::setLazyImageLoadingEnabled): Deleted.
58         * WebPreferences.h:
59         * WebView.cpp:
60         (WebView::notifyPreferencesChanged):
61
62 2019-09-05  Fujii Hironori  <Hironori.Fujii@sony.com>
63
64         [WinCairo][WK1] ASSERTION FAILED: !isAcceleratedCompositing() in WebView::updateBackingStore
65         https://bugs.webkit.org/show_bug.cgi?id=201493
66
67         Reviewed by Don Olmstead.
68
69         WebView::paint switches painting code path by checking accelerated
70         compositing enabled. However, accelerated compositing could be
71         enabled after the checking.
72
73         WebView::paint called WebView::paintCompositedContentToHDC and
74         WebCore::Page::updateRendering.
75         WebView::paintCompositedContentToHDC checks accelerated
76         compositing enabled. Then, WebCore::Page::updateRendering executes
77         JavaScript and accelerated compositing could be enabled.
78
79         * WebView.cpp:
80         (WebView::paint): Call WebCore::Page::updateRendering the
81         beginning of the function.
82
83 2019-09-03  Antti Koivisto  <antti@apple.com>
84
85         Remove redundant painting phase arguments from GraphicsLayerClient functions
86         https://bugs.webkit.org/show_bug.cgi?id=201443
87
88         Reviewed by Simon Fraser.
89
90         * WebView.cpp:
91         (WebView::paintContents):
92         * WebView.h:
93
94 2019-08-27  Mark Lam  <mark.lam@apple.com>
95
96         Refactor to use VM& instead of VM* at as many places as possible.
97         https://bugs.webkit.org/show_bug.cgi?id=201172
98
99         Reviewed by Yusuke Suzuki.
100
101         * WebFrame.cpp:
102         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
103
104 2019-08-21  Ryosuke Niwa  <rniwa@webkit.org>
105
106         Put keygen element behind a runtime flag and disable it by default
107         https://bugs.webkit.org/show_bug.cgi?id=200850
108
109         Reviewed by Antti Koivisto.
110
111         * Interfaces/IWebPreferencesPrivate.idl:
112         * WebPreferenceKeysPrivate.h:
113         * WebPreferences.cpp:
114         (WebPreferences::keygenElementEnabled):
115         (WebPreferences::setKeygenElementEnabled):
116         * WebPreferences.h:
117         * WebView.cpp:
118         (WebView::notifyPreferencesChanged):
119
120 2019-08-19  Fujii Hironori  <Hironori.Fujii@sony.com>
121
122         [WinCairo][WK1] A browser window starts as an inactive window because AcceleratedCompositingContext::acceleratedCompositingAvailable creates temporary window
123         https://bugs.webkit.org/show_bug.cgi?id=200493
124
125         Reviewed by Ross Kirsling.
126
127         Reverted r179962.
128
129         * WebCoreSupport/AcceleratedCompositingContext.cpp:
130         (AcceleratedCompositingContext::acceleratedCompositingAvailable): Deleted.
131         * WebCoreSupport/AcceleratedCompositingContext.h:
132         * WebView.cpp:
133         (WebView::notifyPreferencesChanged):
134
135 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
136
137         Remove IDB-specific quota
138         https://bugs.webkit.org/show_bug.cgi?id=196545
139         <rdar://problem/54201783>
140
141         Reviewed by Youenn Fablet.
142
143         * Interfaces/IWebDatabaseManager.idl:
144         * WebDatabaseManager.cpp:
145         (WebDatabaseManager::setIDBPerOriginQuota): Deleted.
146         * WebDatabaseManager.h:
147
148 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
149
150         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
151         https://bugs.webkit.org/show_bug.cgi?id=200620
152
153         Reviewed by Geoffrey Garen.
154
155         * FullscreenVideoController.cpp:
156         (FullscreenVideoController::FullscreenVideoController):
157         * Plugins/PluginStream.cpp:
158         (WebCore::PluginStream::didReceiveData):
159         * Plugins/PluginView.cpp:
160         (WebCore::PluginView::load):
161         * Plugins/PluginViewWin.cpp:
162         (WebCore::PluginView::wndProc):
163         * WebCoreSupport/WebChromeClient.cpp:
164         (WebChromeClient::WebChromeClient):
165         * WebCoreSupport/WebFrameLoaderClient.cpp:
166         (WebFrameLoaderClient::WebFrameLoaderClient):
167         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
168         * WebCoreSupport/WebInspectorClient.cpp:
169         (WebInspectorClient::openLocalFrontend):
170         (WebInspectorClient::highlight):
171         * WebElementPropertyBag.cpp:
172         (WebElementPropertyBag::WebElementPropertyBag):
173         * WebHistoryItem.cpp:
174         (WebHistoryItem::initFromDictionaryRepresentation):
175         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
176         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
177         * WebNotificationCenter.cpp:
178         (WebNotificationCenter::WebNotificationCenter):
179         * WebView.cpp:
180         (WebView::handleMouseEvent):
181         (WebView::registerEmbeddedViewMIMEType):
182         (WebView::enterVideoFullscreenForVideoElement):
183         (WebView::addUserScriptToGroup):
184         (WebView::addUserStyleSheetToGroup):
185         (WebView::setAcceleratedCompositing):
186
187 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
188
189         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
190         https://bugs.webkit.org/show_bug.cgi?id=200620
191
192         Reviewed by Geoffrey Garen.
193
194         * FullscreenVideoController.cpp:
195         * FullscreenVideoController.h:
196         * Plugins/PluginMessageThrottlerWin.h:
197         * WebCachedFramePlatformData.h:
198         * WebCoreSupport/AcceleratedCompositingContext.h:
199         * WebCoreSupport/WebChromeClient.h:
200         * WebCoreSupport/WebContextMenuClient.h:
201         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
202         * WebCoreSupport/WebDragClient.h:
203         * WebCoreSupport/WebEditorClient.h:
204         * WebCoreSupport/WebFrameLoaderClient.cpp:
205         * WebCoreSupport/WebGeolocationClient.h:
206         * WebCoreSupport/WebInspectorClient.h:
207         * WebDatabaseManager.cpp:
208         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
209         * WebNodeHighlight.h:
210         * WebNotificationCenter.cpp:
211         * WebNotificationCenter.h:
212
213 2019-08-15  Brent Fulgham  <bfulgham@apple.com>
214
215         [FTW] Enable CoreFoundation use if building for Apple target
216         https://bugs.webkit.org/show_bug.cgi?id=200799
217
218         Reviewed by Alex Christensen.
219
220         * FullscreenVideoController.cpp:
221         (FullscreenVideoController::FullscreenVideoController):
222         (FullscreenVideoController::enterFullscreen):
223         (FullscreenVideoController::exitFullscreen):
224         (FullscreenVideoController::createHUDWindow):
225         * FullscreenVideoController.h:
226         * WebView.cpp:
227         (WebView::exitFullscreenIfNeeded):
228
229 2019-08-15  Youenn Fablet  <youenn@apple.com>
230
231         Always create a Document with a valid SessionID
232         https://bugs.webkit.org/show_bug.cgi?id=200727
233
234         Reviewed by Alex Christensen.
235
236         Implement WebKit1 sessionID getter like done for WebKit2.
237         Either the loader client has a page in which case the page session ID is used
238         or the client has no page, in which case the default session ID is used.
239         This is the same behavior as CachedResourceLoader.
240
241         * WebCoreSupport/WebFrameLoaderClient.cpp:
242         (WebFrameLoaderClient::sessionID const):
243
244 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
245
246         Unreviewed, rolling out r248526.
247
248         Caused two IndexedDB perf tests to fail
249
250         Reverted changeset:
251
252         "Remove IDB-specific quota"
253         https://bugs.webkit.org/show_bug.cgi?id=196545
254         https://trac.webkit.org/changeset/248526
255
256 2019-08-14  Youenn Fablet  <youenn@apple.com>
257
258         ThreadableBlobRegistry::blobSize should take a SessionID as parameter
259         https://bugs.webkit.org/show_bug.cgi?id=200671
260
261         Reviewed by Alex Christensen.
262
263         * WebCoreSupport/WebPlatformStrategies.cpp:
264
265 2019-08-13  Youenn Fablet  <youenn@apple.com>
266
267         Blob registries should be keyed by session IDs
268         https://bugs.webkit.org/show_bug.cgi?id=200567
269         <rdar://problem/54120212>
270
271         Reviewed by Alex Christensen.
272
273         * WebCoreSupport/WebPlatformStrategies.cpp:
274         (WebPlatformStrategies::createBlobRegistry):
275
276 2019-08-12  Youenn Fablet  <youenn@apple.com>
277
278         Remove IDB-specific quota
279         https://bugs.webkit.org/show_bug.cgi?id=196545
280
281         Reviewed by Alex Christensen.
282
283         * Interfaces/IWebDatabaseManager.idl:
284         * WebDatabaseManager.cpp:
285         (WebDatabaseManager::setIDBPerOriginQuota): Deleted.
286         * WebDatabaseManager.h:
287
288 2019-08-09  Per Arne Vollan  <pvollan@apple.com>
289
290         [Win] Remove compiler workaround for VS2013
291         https://bugs.webkit.org/show_bug.cgi?id=200582
292
293         Reviewed by Don Olmstead.
294
295         A VS2013 compiler workaround can be removed now.
296
297         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp:
298         (DllMain):
299
300 2019-08-08  Per Arne Vollan  <pvollan@apple.com>
301
302         [Win] Fix internal build
303         https://bugs.webkit.org/show_bug.cgi?id=200519
304
305         Reviewed by Alex Christensen.
306
307         Switch to the String::wideCharacers method, since its return type is compatible with the Win32 api.
308
309         * WebDownloadCFNet.cpp:
310         (WebDownload::didFinish):
311
312 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
313
314         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
315         https://bugs.webkit.org/show_bug.cgi?id=200539
316         <rdar://problem/54082550>
317
318         Reviewed by Dean Jackson.
319
320         * AccessibleBase.cpp:
321         (AccessibleBase::get_locale):
322         * CFDictionaryPropertyBag.cpp:
323         (ConvertCFTypeToVariant):
324         (CFDictionaryPropertyBag::Read):
325         (CFDictionaryPropertyBag::Write):
326         * CFDictionaryPropertyBag.h:
327         * COMPropertyBag.h:
328         (HashType>::Read):
329         (HashType>::GetPropertyInfo):
330         * MarshallingHelpers.cpp:
331         * MarshallingHelpers.h:
332         * WebApplicationCache.cpp:
333         * WebArchive.cpp:
334         * WebArchive.h:
335         * WebCache.cpp:
336         * WebCoreSupport/WebFrameLoaderClient.cpp:
337         * WebDatabaseManager.cpp:
338         * WebHistory.cpp:
339         * WebHistoryItem.cpp:
340         * WebKitCOMAPI.cpp:
341         * WebKitCOMAPI.h:
342         * WebKitDLL.cpp:
343         * WebLocalizableStrings.cpp:
344         * WebLocalizableStrings.h:
345         * WebMutableURLRequest.cpp:
346         * WebPreferences.cpp:
347         * WebPreferences.h:
348         * WebView.cpp:
349         * WebView.h:
350
351 2019-08-08  Rob Buis  <rbuis@igalia.com>
352
353         Add runtime flag for lazy image loading
354         https://bugs.webkit.org/show_bug.cgi?id=199794
355
356         Reviewed by Darin Adler.
357
358         Set lazyImageLoading runtime flag if preference is set.
359
360         * Interfaces/IWebPreferencesPrivate.idl:
361         * WebPreferenceKeysPrivate.h:
362         * WebPreferences.cpp:
363         (WebPreferences::initializeDefaultSettings):
364         (WebPreferences::lazyImageLoadingEnabled):
365         (WebPreferences::setLazyImageLoadingEnabled):
366         * WebPreferences.h:
367         * WebView.cpp:
368         (WebView::notifyPreferencesChanged):
369
370 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
371
372         [Win][WK1] Can't change Web Inspector frontend height in high DPI
373         https://bugs.webkit.org/show_bug.cgi?id=200153
374
375         Reviewed by Don Olmstead.
376
377         * WebCoreSupport/WebInspectorClient.cpp:
378         (WebInspectorFrontendClient::setAttachedWindowHeight):
379         Applied deviceScaleFactor to the argument height.
380
381 2019-07-26  Konstantin Tokarev  <annulen@yandex.ru>
382
383         [Win] Remove unused methods from WebPluginInfoProvider
384         https://bugs.webkit.org/show_bug.cgi?id=200178
385
386         Reviewed by Brent Fulgham.
387
388         These methods are guarded with PLATFORM(MAC) and have no definitions.
389         Also remove unused friend declaration.
390
391         * WebCoreSupport/WebPluginInfoProvider.h:
392
393 2019-07-25  Fujii Hironori  <Hironori.Fujii@sony.com>
394
395         [Win][WK1] The inspected webview window is misplaced after changing Web Inspector frontend window height
396         https://bugs.webkit.org/show_bug.cgi?id=200152
397
398         Reviewed by Brent Fulgham.
399
400         In WebInspectorFrontendClient::setAttachedWindowHeight, the size
401         of m_inspectedWebViewHwnd was changed to the whole host window
402         size. But, it's too tall because MiniBrowser's host window has a
403         toolbar. The toolbar height should be taken into account.
404
405         Change to the height of m_inspectedWebViewHwnd to the sum of
406         inspected WebView and inspector frontend WebView heights.
407
408         * WebCoreSupport/WebInspectorClient.cpp:
409         (WebInspectorFrontendClient::setAttachedWindowHeight):
410
411 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
412
413         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
414         https://bugs.webkit.org/show_bug.cgi?id=200021
415         <rdar://problem/53301325>
416
417         Reviewed by Ryosuke Niwa.
418
419         Implement a new editing client hook.
420
421         * WebCoreSupport/WebEditorClient.h:
422
423 2019-07-13  Zalan Bujtas  <zalan@apple.com>
424
425         Cannot bring up custom media controls at all on v.youku.com
426         https://bugs.webkit.org/show_bug.cgi?id=199699
427         <rdar://problem/51835327>
428
429         Reviewed by Simon Fraser.
430
431         * WebActionPropertyBag.cpp:
432         (WebActionPropertyBag::Read):
433         * WebView.cpp:
434         (WebView::handleContextMenuEvent):
435         (WebView::elementAtPoint):
436
437 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
438
439         [WinCairo] ASSERTION FAILED: info.bmBitsPixel == 32 in createCairoContextWithHDC
440         https://bugs.webkit.org/show_bug.cgi?id=198323
441
442         Reviewed by Per Arne Vollan.
443
444         WebView::paint binds m_backingStoreBitmap to a DC by using
445         SelectObject. WebView::paint can be called recursively, but
446         m_backingStoreBitmap can't be bound to multiple DCs at the same
447         time. Then, SelectObject was failing in such case.
448
449         Call WebCore::Page::updateRendering before binding
450         m_backingStoreBitmap instead of after it.
451
452         Reverted r202744 change which won't be needed since this change.
453
454         * WebView.cpp:
455         (WebView::scrollBackingStore): Removed r202744's change.
456         (WebView::updateBackingStore): Removed m_page->updateRendering().
457         (WebView::paint): Do m_page->updateRendering() before binding m_backingStoreBitmap.
458         * WebView.h: Removed unused WebView::isPainting.
459
460 2019-07-02  Devin Rousso  <drousso@apple.com>
461
462         Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
463         https://bugs.webkit.org/show_bug.cgi?id=198956
464
465         Reviewed by Matt Baker.
466
467         * WebCoreSupport/WebInspectorClient.h:
468         * WebCoreSupport/WebInspectorClient.cpp:
469         (WebInspectorFrontendClient::resetWindowState): Added.
470
471 2019-06-30  Fujii Hironori  <Hironori.Fujii@sony.com>
472
473         [Win] Multiline mode of tooltip control does word-wrapping very slowly
474         https://bugs.webkit.org/show_bug.cgi?id=198989
475
476         Reviewed by Ross Kirsling.
477
478         * WebView.cpp:
479         (truncatedString): Added.
480         (WebView::setToolTip): Use truncatedString.
481
482 2019-06-16  Darin Adler  <darin@apple.com>
483
484         Rename AtomicString to AtomString
485         https://bugs.webkit.org/show_bug.cgi?id=195276
486
487         Reviewed by Michael Catanzaro.
488
489         * many files: Let do-webcore-rename do the renaming.
490
491 2019-05-31  Don Olmstead  <don.olmstead@sony.com>
492
493         [CMake] Add WebKit::WTF target
494         https://bugs.webkit.org/show_bug.cgi?id=198400
495
496         Reviewed by Konstantin Tokarev.
497
498         Use the WebKit::WTF target.
499
500         * WebKitQuartzCoreAdditions/CMakeLists.txt:
501
502 2019-05-30  Simon Fraser  <simon.fraser@apple.com>
503
504         Use an OptionSet<> for GraphicsLayerPaintingPhase
505         https://bugs.webkit.org/show_bug.cgi?id=198404
506
507         Reviewed by Tim Horton.
508
509         Replace GraphicsLayerPaintingPhase with OptionSet<GraphicsLayerPaintingPhase>.
510
511         No behavior change.
512
513         * WebCoreSupport/AcceleratedCompositingContext.cpp:
514         (AcceleratedCompositingContext::paintContents):
515         * WebCoreSupport/AcceleratedCompositingContext.h:
516         * WebView.cpp:
517         (WebView::paintContents):
518         * WebView.h:
519
520 2019-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
521
522         [iOS] Dropped text, attachments, and images should animate into place
523         https://bugs.webkit.org/show_bug.cgi?id=198243
524         <rdar://problem/35205373>
525
526         Reviewed by Tim Horton.
527
528         * WebCoreSupport/WebChromeClient.cpp:
529         (WebChromeClient::didFinishLoadingImageForElement):
530         * WebCoreSupport/WebChromeClient.h:
531
532 2019-05-03  Daniel Bates  <dabates@apple.com>
533
534         Pass KeyboardEvent by reference in more places
535         https://bugs.webkit.org/show_bug.cgi?id=197480
536
537         Reviewed by Wenson Hsieh.
538
539         * WebCoreSupport/WebEditorClient.cpp:
540         (WebEditorClient::handleKeyboardEvent):
541         (WebEditorClient::handleInputMethodKeydown):
542         * WebCoreSupport/WebEditorClient.h:
543         * WebView.cpp:
544         (WebView::handleEditingKeyboardEvent):
545         * WebView.h:
546
547 2019-05-02  Frederic Wang  <fwang@igalia.com>
548
549         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
550         https://bugs.webkit.org/show_bug.cgi?id=196142
551
552         This patch introduces some experimental runtime flag to let users
553         disable MathML features that are removed from MathML Core [1]. For now,
554         these features are only disabled on GTK and WPE ports.
555
556         [1] https://mathml-refresh.github.io/mathml-core/
557
558         Reviewed by Rob Buis.
559
560         * Interfaces/IWebPreferencesPrivate.idl:
561         * WebPreferenceKeysPrivate.h:
562         * WebPreferences.cpp:
563         (WebPreferences::initializeDefaultSettings):
564         (WebPreferences::coreMathMLEnabled):
565         (WebPreferences::setCoreMathMLEnabled):
566         * WebPreferences.h:
567         * WebView.cpp:
568         (WebView::notifyPreferencesChanged):
569
570 2019-04-24  Zalan Bujtas  <zalan@apple.com>
571
572         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
573         https://bugs.webkit.org/show_bug.cgi?id=196948
574         <rdar://problem/49927131>
575
576         Reviewed by Tim Horton.
577
578         * WebCoreSupport/WebChromeClient.cpp:
579         (WebChromeClient::intrinsicContentsSizeChanged const):
580         * WebCoreSupport/WebChromeClient.h:
581
582 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
583
584         Make it possible to control the renderTreeAsText output by setting options on testRunner
585         https://bugs.webkit.org/show_bug.cgi?id=197133
586
587         Reviewed by Sam Weinig.
588
589         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
590         that make sense in testing (those that don't dump unstable data like addresses), and plumb
591         these flags through the various framework layers.
592
593         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
594
595         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
596         and hand-code DumpRenderTree bindings.
597
598         Some cleanup of the TestRunners, using member initializers.
599
600         * Interfaces/IWebFramePrivate.idl:
601         * WebFrame.cpp:
602         (toRenderAsTextFlags):
603         (WebFrame::renderTreeAsExternalRepresentation):
604         (WebFrame::renderTreeAsExternalRepresentationForPrinting):
605         * WebFrame.h:
606
607 2019-04-23  Chris Dumez  <cdumez@apple.com>
608
609         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
610         https://bugs.webkit.org/show_bug.cgi?id=197097
611         <rdar://problem/50048318>
612
613         Reviewed by Alex Christensen.
614
615         * WebCoreSupport/WebFrameLoaderClient.cpp:
616         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
617         * WebCoreSupport/WebFrameLoaderClient.h:
618
619 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
620
621         [CMake][Win] Use target oriented design for WebKitLegacy
622         https://bugs.webkit.org/show_bug.cgi?id=197112
623
624         Reviewed by Konstantin Tokarev.
625
626         Fix an include directory.
627
628         * WebKitQuartzCoreAdditions/CMakeLists.txt:
629
630 2019-04-18  Jer Noble  <jer.noble@apple.com>
631
632         Refactoring: Pull all fullscreen code out of Document and into its own helper class
633         https://bugs.webkit.org/show_bug.cgi?id=197017
634
635         Reviewed by Eric Carlson.
636
637         * WebCoreSupport/WebChromeClient.cpp:
638         (WebChromeClient::createWindow):
639         * WebView.cpp:
640         (WebView::fullScreenClientWillEnterFullScreen):
641         (WebView::fullScreenClientDidEnterFullScreen):
642         (WebView::fullScreenClientWillExitFullScreen):
643         (WebView::fullScreenClientDidExitFullScreen):
644
645 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
646
647         requestAnimationFrame should execute before the next frame
648         https://bugs.webkit.org/show_bug.cgi?id=177484
649
650         Reviewed by Simon Fraser.
651
652         * WebView.cpp:
653         (WebView::updateBackingStore):
654         (WebView::flushPendingGraphicsLayerChangesSoon):
655         (WebView::flushPendingGraphicsLayerChanges):
656         Call Page::updateRendering() which implements "Update the rendering"
657         step of the HTML Event Loop specification.
658
659 2019-04-10  Devin Rousso  <drousso@apple.com>
660
661         Web Inspector: save sheet should be anchored underneath the tab bar when detached
662         https://bugs.webkit.org/show_bug.cgi?id=196722
663         <rdar://problem/49613280>
664
665         Reviewed by Timothy Hatcher.
666
667         * WebCoreSupport/WebInspectorClient.h:
668         * WebCoreSupport/WebInspectorClient.cpp:
669         (WebInspectorFrontendClient::setSheetRect): Added.
670
671 2019-04-10  Alex Christensen  <achristensen@webkit.org>
672
673         Add SPI WKNavigationResponse._downloadAttribute
674         https://bugs.webkit.org/show_bug.cgi?id=196755
675         <rdar://49587365>
676
677         Reviewed by Brady Eidson.
678
679         * WebCoreSupport/WebFrameLoaderClient.cpp:
680         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
681         * WebCoreSupport/WebFrameLoaderClient.h:
682
683 2019-04-05  Commit Queue  <commit-queue@webkit.org>
684
685         Unreviewed, rolling out r243833.
686         https://bugs.webkit.org/show_bug.cgi?id=196645
687
688         This change breaks build of WPE and GTK ports (Requested by
689         annulen on #webkit).
690
691         Reverted changeset:
692
693         "[CMake][WTF] Mirror XCode header directories"
694         https://bugs.webkit.org/show_bug.cgi?id=191662
695         https://trac.webkit.org/changeset/243833
696
697 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
698
699         [CMake][WTF] Mirror XCode header directories
700         https://bugs.webkit.org/show_bug.cgi?id=191662
701
702         Reviewed by Konstantin Tokarev.
703
704         * WebKitQuartzCoreAdditions/CMakeLists.txt:
705
706 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
707
708         Implement ResizeObserver.
709         https://bugs.webkit.org/show_bug.cgi?id=157743
710
711         Reviewed by Simon Fraser.
712
713         * Interfaces/IWebPreferencesPrivate.idl:
714         * WebPreferenceKeysPrivate.h:
715         * WebPreferences.cpp:
716         (WebPreferences::initializeDefaultSettings):
717         (WebPreferences::resizeObserverEnabled):
718         (WebPreferences::setResizeObserverEnabled):
719         * WebPreferences.h:
720         * WebView.cpp:
721         (WebView::notifyPreferencesChanged):
722
723 2019-03-17  Fujii Hironori  <Hironori.Fujii@sony.com>
724
725         [Win][WK1] Null dereference in WebFrameNetworkingContext::storageSession
726         https://bugs.webkit.org/show_bug.cgi?id=195741
727
728         Reviewed by Ross Kirsling.
729
730         * WebCoreSupport/WebFrameNetworkingContext.cpp:
731         (WebFrameNetworkingContext::storageSession const): Added a null check of frame()->page() as well as Mac port does (Bug 183455).
732
733 2019-03-13  Ryan Haddad  <ryanhaddad@apple.com>
734
735         Unreviewed attempt to fix the Windows build after r242920.
736
737         * WebCoreSupport/WebFrameLoaderClient.h:
738
739 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
740
741         [Win] Fix a slew of simple clang-cl warnings.
742         https://bugs.webkit.org/show_bug.cgi?id=195652
743
744         Reviewed by Don Olmstead.
745
746         * Interfaces/AccessibleComparable.idl: -Wmissing-braces
747         * Plugins/PluginDatabaseWin.cpp: -Wunused-function
748         (WebCore::addJavaPluginDirectory): Deleted.
749         * WebCoreSupport/AcceleratedCompositingContext.cpp:
750         (AcceleratedCompositingContext::AcceleratedCompositingContext): -Wreorder
751         * WebCoreSupport/WebEditorClient.cpp:
752         (WebEditorUndoCommand::WebEditorUndoCommand): -Wreorder
753         (undoNameForEditAction): -Wswitch
754         * WebCoreSupport/WebFrameLoaderClient.cpp:
755         (WebFrameLoaderClient::WebFrameLoaderClient): -Wswitch
756         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): -Wunused-variable
757         * WebCoreSupport/WebInspectorClient.cpp:
758         (WebInspectorFrontendClient::WebInspectorFrontendClient): -Wreorder
759         * WebCoreSupport/WebInspectorClient.h: -Winconsistent-missing-override
760         * WebError.cpp:
761         (WebError::WebError): -Wreorder
762         * WebFrame.cpp:
763         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): -Wlogical-op-parentheses
764         * WebHistory.cpp: -Wunused-function (x5)
765         (areEqualOrClose): Deleted.
766         (addDayToSystemTime): Deleted.
767         (getDayBoundaries): Deleted.
768         (beginningOfDay): Deleted.
769         (dateKey): Deleted.
770         * WebNotificationCenter.cpp:
771         (WebNotificationCenter::removeObserver): -Wunused-variable
772         * WebView.cpp: -Wunused-function, -Wreorder
773         (WebView::addVisitedLinks): -Wunused-variable
774
775 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
776
777         Unreviewed, rolling out r242688, r242643, r242624.
778
779         Caused multiple layout test failures and crashes on iOS and macOS.
780
781         Reverted changeset:
782
783         "requestAnimationFrame should execute before the next frame"
784         https://bugs.webkit.org/show_bug.cgi?id=177484
785         https://trac.webkit.org/changeset/242624/webkit
786
787         * WebView.cpp:
788         (WebView::updateBackingStore):
789         (WebView::flushPendingGraphicsLayerChangesSoon):
790         (WebView::flushPendingGraphicsLayerChanges):
791
792 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
793
794         requestAnimationFrame should execute before the next frame
795         https://bugs.webkit.org/show_bug.cgi?id=177484
796
797         Reviewed by Simon Fraser.
798
799         * WebView.cpp:
800         (WebView::updateBackingStore):
801         (WebView::flushPendingGraphicsLayerChangesSoon):
802         (WebView::flushPendingGraphicsLayerChanges):
803         Call Page::renderingUpdate() which implements  "Update the rendering"
804         step of the HTML Event Loop specification.
805
806 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
807
808         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
809         https://bugs.webkit.org/show_bug.cgi?id=195346
810
811         Reviewed by Fujii Hironori.
812
813         * COMPropertyBag.h:
814         (HashType>::GetPropertyInfo):
815         (HashType>::LoadObject):
816         * DOMCoreClasses.cpp:
817         (DOMNode::addEventListener):
818         (DOMNode::removeEventListener):
819         (DOMWindow::addEventListener):
820         (DOMWindow::removeEventListener):
821         (DOMElement::font):
822         * DOMHTMLClasses.cpp:
823         (DOMHTMLInputElement::setValueForUser):
824         (DOMHTMLInputElement::replaceCharactersInRange):
825         * Plugins/PluginDatabaseWin.cpp:
826         (WebCore::addPluginPathsFromRegistry):
827         (WebCore::PluginDatabase::getPluginPathsInDirectories const):
828         (WebCore::addMozillaPluginDirectories):
829         (WebCore::addWindowsMediaPlayerPluginDirectory):
830         (WebCore::addAdobeAcrobatPluginDirectory):
831         (WebCore::addJavaPluginDirectory):
832         (WebCore::safariPluginsDirectory):
833         (WebCore::addMacromediaPluginDirectories):
834         * Plugins/PluginPackageWin.cpp:
835         (WebCore::getVersionInfo):
836         (WebCore::PluginPackage::fetchInfo):
837         (WebCore::PluginPackage::load):
838         * Plugins/PluginViewWin.cpp:
839         (WebCore::PluginView::handlePostReadFile):
840         * WebCoreSupport/WebChromeClient.cpp:
841         (WebChromeClient::runOpenPanel):
842         * WebCoreSupport/WebEditorClient.cpp:
843         (WebEditorClient::checkSpellingOfString):
844         (WebEditorClient::checkGrammarOfString):
845         * WebCoreSupport/WebInspectorClient.cpp:
846         (WebInspectorFrontendClient::updateWindowTitle):
847         * WebLocalizableStrings.cpp:
848         (LocalizedString::operator LPCTSTR const):
849         * WebView.cpp:
850         (createContextMenuFromItems):
851         (WebView::setToolTip):
852         Use wchar helpers as needed.
853
854 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
855
856         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
857         https://bugs.webkit.org/show_bug.cgi?id=195053
858         <rdar://problem/48134710>
859
860         Reviewed by Ryosuke Niwa.
861
862         * WebCoreSupport/WebEditorClient.h:
863
864 2019-02-20  Darin Adler  <darin@apple.com>
865
866         Finish removing String::format
867         https://bugs.webkit.org/show_bug.cgi?id=194893
868
869         Reviewed by Daniel Bates.
870
871         * FullscreenVideoController.cpp:
872         (timeToString): Use makeString and pad.
873
874 2019-02-27  Simon Fraser  <simon.fraser@apple.com>
875
876         Roll out r242014; it caused crashes in compositing logging (webkit.org/b/195141)
877
878         * FullscreenVideoController.cpp:
879         (timeToString):
880
881 2019-02-26  Philippe Normand  <pnormand@igalia.com>
882
883         [WPE] Add API for webview background color configuration
884         https://bugs.webkit.org/show_bug.cgi?id=192305
885
886         Reviewed by Michael Catanzaro.
887
888         * WebCoreSupport/WebFrameLoaderClient.cpp:
889         (WebFrameLoaderClient::transitionToCommittedForNewPage): Create
890         FrameView with background color.
891
892 2019-02-20  Darin Adler  <darin@apple.com>
893
894         Finish removing String::format
895         https://bugs.webkit.org/show_bug.cgi?id=194893
896
897         Reviewed by Daniel Bates.
898
899         * FullscreenVideoController.cpp:
900         (timeToString): Use makeString and pad.
901
902 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
903
904         Input type "formatSetInlineTextDirection" is dispatched when changing paragraph-level text direction
905         https://bugs.webkit.org/show_bug.cgi?id=194703
906         <rdar://problem/48111775>
907
908         Reviewed by Ryosuke Niwa.
909
910         * WebCoreSupport/WebEditorClient.cpp:
911         (undoNameForEditAction):
912
913 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
914
915         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
916         https://bugs.webkit.org/show_bug.cgi?id=194670
917         <rdar://problem/39066529>
918
919         Reviewed by Tim Horton.
920
921         * WebCoreSupport/WebEditorClient.cpp:
922         (WebEditorClient::replacementURLForResource): Deleted.
923         * WebCoreSupport/WebEditorClient.h:
924
925 2019-02-10  Darin Adler  <darin@apple.com>
926
927         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
928         https://bugs.webkit.org/show_bug.cgi?id=194487
929
930         Reviewed by Daniel Bates.
931
932         * WebView.cpp:
933         (webKitVersionString): Use makeString instead of String::format.
934
935 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
936
937         Allow pages to trigger programmatic paste from script on iOS
938         https://bugs.webkit.org/show_bug.cgi?id=194271
939         <rdar://problem/47808810>
940
941         Reviewed by Ryosuke Niwa.
942
943         * WebCoreSupport/WebEditorClient.h:
944
945 2019-02-06  Daniel Bates  <dabates@apple.com>
946
947         Standardize on ControlKey instead of CtrlKey
948         https://bugs.webkit.org/show_bug.cgi?id=194317
949
950         Reviewed by Tim Horton.
951
952         * AccessibleBase.cpp:
953         (AccessibleBase::get_accKeyboardShortcut):
954         * WebView.cpp:
955         (WebView::keyDown):
956
957 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
958
959         PageOverlayController's layers should be created lazily
960         https://bugs.webkit.org/show_bug.cgi?id=194199
961         rdar://problem/46571593
962
963         Reviewed by Tim Horton.
964
965         Expose PageOverlayController::hasDocumentOverlays() and hasViewOverlays()
966         and use them to only parent the overlay-hosting layers when necessary.
967
968         For document overlays, RenderLayerCompositor::appendDocumentOverlayLayers() can
969         simply do nothing if there are none. Updates are triggered via Page::installedPageOverlaysChanged(),
970         which calls FrameView::setNeedsCompositingConfigurationUpdate() to trigger the root layer
971         compositing updates that parents the layerWithDocumentOverlays().
972
973         View overlays are added to the layer tree via the DrawingArea. When we go between having
974         none and some view overlays, Page::installedPageOverlaysChanged() calls attachViewOverlayGraphicsLayer()
975         on the ChromeClient, and the DrawingArea responds by calling updateRootLayers() and scheduling a
976         compositing flush (this has to be done manually because view overlay layers are outside the
977         subtree managed by RenderLayerCompositor).
978         
979         Now that GraphicsLayers are ref-counted, we can let the DrawingArea simply retain its m_viewOverlayRootLayer;
980         there is no need for RenderLayerCompositor::attachRootLayer()/detachRootLayer() to do anything with view
981         overlay layers. This implies that a page can navigate (new FrameView) and view overlays will persist, without
982         having to be manually removed and re-added. We can also remove the Frame argument to attachViewOverlayGraphicsLayer().
983
984         * WebCoreSupport/WebChromeClient.cpp:
985         (WebChromeClient::attachViewOverlayGraphicsLayer):
986         * WebCoreSupport/WebChromeClient.h:
987
988 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
989
990         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
991         https://bugs.webkit.org/show_bug.cgi?id=194189
992
993         Reviewed by Geoffrey Garen.
994
995         Pass the policy check identifier around functions and store it in WebFramePolicyListener
996         so that we can send it back to WebCore with the navigation policy decision.
997
998         * WebCoreSupport/WebFrameLoaderClient.cpp:
999         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1000         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1001         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1002         (WebFrameLoaderClient::dispatchWillSubmitForm):
1003         (WebFrameLoaderClient::setUpPolicyListener):
1004         * WebCoreSupport/WebFrameLoaderClient.h:
1005
1006 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1007
1008         Revert r238819 which is unneeded and caused a performance regression.
1009         https://bugs.webkit.org/show_bug.cgi?id=192272
1010         <rdar://problem/46664625>
1011
1012         * WebCoreSupport/WebFrameLoaderClient.cpp:
1013         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1014         * WebCoreSupport/WebFrameLoaderClient.h:
1015
1016 2019-01-31  Takashi Komori  <Takashi.Komori@sony.com>
1017
1018         [Curl] Fix DRT crash related to private browsing.
1019         https://bugs.webkit.org/show_bug.cgi?id=193816
1020
1021         Reviewed by Alex Christensen.
1022
1023         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1024         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1025
1026 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1027
1028         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1029         https://bugs.webkit.org/show_bug.cgi?id=193941
1030
1031         Reviewed by Alex Christensen.
1032
1033         * Plugins/PluginMessageThrottlerWin.cpp:
1034         * Plugins/PluginView.cpp:
1035         * Plugins/PluginViewWin.cpp:
1036
1037 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1038
1039         Move FileSystem to WTF
1040         https://bugs.webkit.org/show_bug.cgi?id=193602
1041
1042         Reviewed by Yusuke Suzuki.
1043
1044         * Plugins/PluginDatabase.cpp:
1045         * Plugins/PluginPackage.h:
1046         * Plugins/PluginStream.h:
1047         * WebApplicationCache.cpp:
1048         * WebDatabaseManager.cpp:
1049         * WebDownloadCurl.cpp:
1050         * WebPreferences.cpp:
1051         * WebView.cpp:
1052
1053 2019-01-22  Alex Christensen  <achristensen@webkit.org>
1054
1055         Move NetworkStorageSession ownership to NetworkProcess
1056         https://bugs.webkit.org/show_bug.cgi?id=193580
1057
1058         Reviewed by Geoff Garen.
1059
1060         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1061         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
1062         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1063         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
1064         (WebFrameNetworkingContext::storageSession const):
1065         * WebDownloadCFNet.cpp:
1066         (WebDownload::didReceiveAuthenticationChallenge):
1067         * WebPreferences.cpp:
1068         (WebPreferences::clearNetworkLoaderSession):
1069         (WebPreferences::switchNetworkLoaderToNewTestingSession):
1070
1071 2019-01-15  Darin Adler  <darin@apple.com>
1072
1073         Use references rather than pointers for register/unregister functions, and more
1074         https://bugs.webkit.org/show_bug.cgi?id=175028
1075
1076         Reviewed by Daniel Bates.
1077
1078         * Plugins/PluginView.cpp:
1079         (WebCore::PluginView::startOrAddToUnstartedList): Pass a reference.
1080         (WebCore::PluginView::~PluginView): Ditto.
1081         * WebView.cpp:
1082         (WebView::fullScreenClientWillEnterFullScreen): Ditto.
1083         (WebView::fullScreenClientDidEnterFullScreen): Ditto.
1084         (WebView::fullScreenClientDidExitFullScreen): Ditto.
1085
1086 2019-01-17  Per Arne Vollan  <pvollan@apple.com>
1087
1088         [Win][HighDPI] Repaint glitches when scrolling.
1089         https://bugs.webkit.org/show_bug.cgi?id=173152
1090         <rdar://problem/45269953>
1091
1092         Reviewed by Brent Fulgham.
1093
1094         Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
1095         delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
1096         Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
1097
1098         * WebView.cpp:
1099         (WebView::scrollBackingStore):
1100
1101 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1102
1103         Stop using NetworkStorageSession::storageSession in WebCore
1104         https://bugs.webkit.org/show_bug.cgi?id=193529
1105
1106         Reviewed by Tim Horton.
1107
1108         * WebView.cpp:
1109         (WebView::initWithFrame):
1110
1111 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1112
1113         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1114         https://bugs.webkit.org/show_bug.cgi?id=193368
1115
1116         Reviewed by Geoff Garen.
1117
1118         * WebDownloadCFNet.cpp:
1119         (WebDownload::didReceiveAuthenticationChallenge):
1120
1121 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1122
1123         Fix Windows build after r240014
1124         https://bugs.webkit.org/show_bug.cgi?id=161106
1125
1126         * WebView.cpp:
1127
1128 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1129
1130         Stop using CookiesStrategy
1131         https://bugs.webkit.org/show_bug.cgi?id=161106
1132
1133         Reviewed by Don Olmstead and Antti Koivisto.
1134
1135         * Plugins/PluginView.cpp:
1136         (WebCore::PluginView::getValueForURL):
1137         (WebCore::PluginView::setValueForURL):
1138         * WebCoreSupport/WebPlatformStrategies.cpp:
1139         (WebPlatformStrategies::createBlobRegistry):
1140         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1141         (WebPlatformStrategies::cookiesForDOM): Deleted.
1142         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1143         (WebPlatformStrategies::cookiesEnabled): Deleted.
1144         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1145         (WebPlatformStrategies::getRawCookies): Deleted.
1146         (WebPlatformStrategies::deleteCookie): Deleted.
1147         * WebCoreSupport/WebPlatformStrategies.h:
1148         * WebView.cpp:
1149         (WebView::initWithFrame):
1150
1151 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1152
1153         Stop using NetworkStorageSession in WebProcess
1154         https://bugs.webkit.org/show_bug.cgi?id=193236
1155
1156         Reviewed by Don Olmstead.
1157
1158         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1159         (WebFrameNetworkingContext::storageSession const):
1160         * WebCoreSupport/WebFrameNetworkingContext.h:
1161         * WebCoreSupport/WebPlatformStrategies.cpp:
1162         (WebPlatformStrategies::cookiesForDOM):
1163         (WebPlatformStrategies::setCookiesFromDOM):
1164         (WebPlatformStrategies::cookiesEnabled):
1165         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1166         (WebPlatformStrategies::getRawCookies):
1167         (WebPlatformStrategies::deleteCookie):
1168         * WebCoreSupport/WebPlatformStrategies.h:
1169
1170 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1171
1172         Unreviewed, rolling out r239727.
1173
1174         Broke API tests
1175
1176         Reverted changeset:
1177
1178         "Stop using NetworkStorageSession in WebProcess"
1179         https://bugs.webkit.org/show_bug.cgi?id=193236
1180         https://trac.webkit.org/changeset/239727
1181
1182 2018-12-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1183
1184         Remove "using namespace std;"
1185         https://bugs.webkit.org/show_bug.cgi?id=192973
1186
1187         Reviewed by Alex Christensen.
1188
1189         * FullscreenVideoController.cpp:
1190         * WebFrame.cpp:
1191         (WebFrame::drawFooter):
1192         * WebHistory.cpp:
1193         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
1194         * WebKitQuartzCoreAdditions/CAView.cpp:
1195         * WebView.cpp:
1196         (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
1197         (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
1198         (WebView::setCacheModel):
1199         (WebView::maxCacheModelInAnyInstance):
1200
1201 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1202
1203         Use Ref<> as much as possible
1204         https://bugs.webkit.org/show_bug.cgi?id=192808
1205
1206         Reviewed by Alex Christensen.
1207
1208         * Plugins/PluginDatabase.cpp:
1209         (WebCore::PluginDatabase::refresh):
1210         * Plugins/PluginView.cpp:
1211         (WebCore::PluginView::mediaCanStart):
1212         (WebCore::PluginView::performRequest):
1213         (WebCore::PluginView::bindingInstance):
1214         * Plugins/PluginView.h:
1215         * WebCoreSupport/WebFrameLoaderClient.cpp:
1216         (WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
1217         (WebFrameLoaderClient::createPlugin):
1218         (WebFrameLoaderClient::createJavaAppletWidget):
1219         * WebCoreSupport/WebFrameLoaderClient.h:
1220         * WebFrame.cpp:
1221         (WebFrame::loadData):
1222         (WebFrame::loadPlainTextString):
1223         (WebFrame::loadHTMLString):
1224         * WebFrame.h:
1225         * WebKitQuartzCoreAdditions/CAView.cpp:
1226         (WKQCA::CAView::create):
1227         * WebKitQuartzCoreAdditions/CAView.h:
1228         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
1229         (WKQCA::CVDisplayLink::create):
1230         * WebKitQuartzCoreAdditions/CVDisplayLink.h:
1231         * WebKitQuartzCoreAdditions/ImageConversion.cpp:
1232         (WKQCA::getImageCopy):
1233         * WebView.cpp:
1234         (WebView::addUserScriptToGroup):
1235         (WebView::addUserStyleSheetToGroup):
1236
1237 2018-12-20  Chris Dumez  <cdumez@apple.com>
1238
1239         Use Optional::valueOr() instead of Optional::value_or()
1240         https://bugs.webkit.org/show_bug.cgi?id=192933
1241
1242         Reviewed by Geoffrey Garen.
1243
1244         * WebSecurityOrigin.cpp:
1245         (WebSecurityOrigin::port):
1246
1247 2018-12-19  Chris Dumez  <cdumez@apple.com>
1248
1249         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1250         https://bugs.webkit.org/show_bug.cgi?id=192728
1251         <rdar://problem/46746779>
1252
1253         Reviewed by Geoff Garen.
1254
1255         * Plugins/*:
1256         * WebCoreSupport/*:
1257
1258 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1259
1260         [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag
1261         https://bugs.webkit.org/show_bug.cgi?id=192617
1262
1263         Reviewed by Alex Christensen.
1264
1265         * COMEnumVariant.h:
1266         (COMEnumVariant<ContainerType>::adopt): Removed 'typename' from non dependent names.
1267         (COMEnumVariant<ContainerType>::createInstance): Ditto.
1268         (COMEnumVariant<ContainerType>::Next): Prepend 'typename' for dependent names.
1269         * COMPropertyBag.h:
1270         (HashType>::createInstance): Removed 'typename' from non dependent names.
1271         (HashType>::adopt): Ditto.
1272         (HashType>::Read): Replaced dependent name 'HashMapType::const_iterator' with 'auto'.
1273         (HashType>::GetPropertyInfo): Ditto.
1274
1275 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1276
1277         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
1278         https://bugs.webkit.org/show_bug.cgi?id=192618
1279
1280         Reviewed by Alex Christensen.
1281
1282         Classes which implement COM interface usually doesn't need the
1283         virtual destructor because it has Release() virtual method to
1284         destruct itself.
1285
1286         Marked 'final' such classes to suppress clang-cl's compilation
1287         warnings.
1288
1289         * COMEnumVariant.h:
1290         * COMPropertyBag.h:
1291         * DefaultDownloadDelegate.h:
1292         * DefaultPolicyDelegate.h:
1293         * MemoryStream.h:
1294         * WebActionPropertyBag.h:
1295         * WebApplicationCache.h:
1296         * WebArchive.h:
1297         * WebBackForwardList.h:
1298         * WebCache.h:
1299         * WebCoreStatistics.h:
1300         * WebCoreSupport/WebEditorClient.cpp:
1301         * WebCoreSupport/WebInspectorDelegate.h:
1302         * WebDataSource.h:
1303         * WebDatabaseManager.cpp:
1304         * WebDatabaseManager.h:
1305         * WebDownload.h:
1306         * WebDropSource.h:
1307         * WebElementPropertyBag.h:
1308         * WebError.h:
1309         * WebFrame.cpp:
1310         * WebFrame.h:
1311         * WebFramePolicyListener.h:
1312         * WebGeolocationPolicyListener.h:
1313         * WebGeolocationPosition.h:
1314         * WebHTMLRepresentation.h:
1315         * WebHistory.h:
1316         * WebHistoryItem.h:
1317         * WebInspector.h:
1318         * WebJavaScriptCollector.h:
1319         * WebKitClassFactory.h:
1320         * WebKitMessageLoop.h:
1321         * WebKitStatistics.h:
1322         * WebMutableURLRequest.h:
1323         * WebNavigationData.h:
1324         * WebNotification.h:
1325         * WebNotificationCenter.h:
1326         * WebPreferences.h:
1327         * WebResource.h:
1328         * WebScriptWorld.h:
1329         * WebSecurityOrigin.h:
1330         * WebSerializedJSValue.h:
1331         * WebTextRenderer.h:
1332         * WebURLAuthenticationChallenge.h:
1333         * WebURLAuthenticationChallengeSender.h:
1334         * WebURLCredential.h:
1335         * WebURLProtectionSpace.h:
1336         * WebURLResponse.h:
1337         * WebUserContentURLPattern.h:
1338         * WebView.cpp:
1339         * WebView.h:
1340         * WebWorkersPrivate.h:
1341
1342 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1343
1344         [Win][Clang] Fix warning -Wmissing-field-initializers
1345         https://bugs.webkit.org/show_bug.cgi?id=192584
1346
1347         Reviewed by Yusuke Suzuki.
1348
1349         Initialize a struct with '{ }' instead of '= {0}'.
1350
1351         * WebKitMessageLoop.cpp:
1352         (WebKitMessageLoop::run):
1353         * WebView.cpp:
1354         (WebView::onMenuCommand):
1355         (WebView::gesture):
1356         (WebView::setShouldInvertColors):
1357         (WebView::initializeToolTipWindow):
1358         (WebView::setToolTip):
1359         (WebView::fullScreenClientForceRepaint):
1360
1361 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1362
1363         Turn WritingDirection into an enum class
1364         https://bugs.webkit.org/show_bug.cgi?id=192401
1365         Work towards <rdar://problem/42075638>
1366
1367         Reviewed by Dan Bernstein.
1368
1369         Change WritingDirection from an enum to an enum class. No change in behavior.
1370
1371         * WebFrame.cpp:
1372         (WebFrame::setTextDirection):
1373
1374 2018-12-03  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1375
1376         Use WallTime for file time
1377         https://bugs.webkit.org/show_bug.cgi?id=192287
1378
1379         Reviewed by Darin Adler.
1380
1381         * Plugins/PluginDatabase.cpp:
1382         (WebCore::PluginDatabase::refresh):
1383
1384 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1385
1386         Fix Windows build.
1387
1388         * WebView.cpp:
1389
1390 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1391
1392         Fix Windows build.
1393
1394         * WebCoreSupport/WebFrameLoaderClient.h:
1395
1396 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1397
1398         Fix Windows build.
1399
1400         * WebCoreSupport/WebFrameLoaderClient.h:
1401
1402 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1403
1404         Move URL from WebCore to WTF
1405         https://bugs.webkit.org/show_bug.cgi?id=190234
1406
1407         Reviewed by Keith Miller.
1408
1409         * MarshallingHelpers.cpp:
1410         * MarshallingHelpers.h:
1411         * Plugins/PluginDatabase.cpp:
1412         * Plugins/PluginDatabase.h:
1413         * Plugins/PluginDatabaseWin.cpp:
1414         * Plugins/PluginStream.h:
1415         * Plugins/PluginView.h:
1416         * WebCoreSupport/WebContextMenuClient.h:
1417         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
1418         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
1419         * WebCoreSupport/WebFrameLoaderClient.h:
1420         * WebCoreSupport/WebPlatformStrategies.h:
1421         * WebCoreSupport/WebPluginInfoProvider.cpp:
1422         (WebPluginInfoProvider::webVisiblePluginInfo):
1423         * WebCoreSupport/WebPluginInfoProvider.h:
1424         * WebCoreSupport/WebVisitedLinkStore.h:
1425         * WebDataSource.cpp:
1426         * WebDownload.h:
1427         * WebElementPropertyBag.cpp:
1428         * WebFrame.h:
1429         * WebHistory.cpp:
1430         * WebHistory.h:
1431         * WebHistoryItem.cpp:
1432         * WebResource.cpp:
1433         (WebResource::WebResource):
1434         * WebResource.h:
1435         * WebSecurityOrigin.cpp:
1436         * WebURLResponse.cpp:
1437         (WebURLResponse::createInstance):
1438         * WebUserContentURLPattern.cpp:
1439         * WebView.h:
1440
1441 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1442
1443         Remove dead code from an earlier attempt at implementing safe browsing
1444         https://bugs.webkit.org/show_bug.cgi?id=192067
1445
1446         Reviewed by Chris Dumez.
1447
1448         * WebCoreSupport/WebFrameLoaderClient.cpp:
1449         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1450         * WebCoreSupport/WebFrameLoaderClient.h:
1451
1452 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
1453
1454         [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
1455         https://bugs.webkit.org/show_bug.cgi?id=191959
1456
1457         Reviewed by Alex Christensen.
1458
1459         * MarshallingHelpers.h: Removed extra "MarshallingHelpers::" of windowsEpochAbsoluteTime declaration.
1460
1461 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
1462
1463         [Win] Reduce the use of WKSI library calls: CoreAnimation
1464         https://bugs.webkit.org/show_bug.cgi?id=191777
1465         <rdar://problem/46140542>
1466
1467         Reviewed by Zalan Bujtas.
1468
1469         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
1470         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
1471         directives for WebKitSystemInterface.lib.
1472
1473         * FullscreenVideoController.cpp:
1474         * WebKitGraphics.cpp:
1475         * WebPreferences.cpp:
1476
1477 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1478
1479         Address post-review feedback after r238438
1480         https://bugs.webkit.org/show_bug.cgi?id=191913
1481
1482         Reviewed by Ryosuke Niwa.
1483
1484         * AccessibleTextImpl.cpp:
1485         (AccessibleText::replaceText):
1486
1487 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1488
1489         Web Inspector: "Reload Web Inspector" button no longer partially works
1490         https://bugs.webkit.org/show_bug.cgi?id=191773
1491         <rdar://problem/46139932>
1492
1493         Reviewed by Devin Rousso.
1494
1495         * WebCoreSupport/WebInspectorClient.cpp:
1496         (WebInspectorFrontendClient::reopen):
1497         * WebCoreSupport/WebInspectorClient.h:
1498
1499 2018-11-17  Devin Rousso  <drousso@apple.com>
1500
1501         Web Inspector: Network: add button to show system certificate dialog
1502         https://bugs.webkit.org/show_bug.cgi?id=191458
1503         <rdar://problem/45977019>
1504
1505         Reviewed by Joseph Pecoraro.
1506
1507         * WebCoreSupport/WebInspectorClient.h:
1508         * WebCoreSupport/WebInspectorClient.cpp:
1509         (WebInspectorFrontendClient::showCertificate): Added.
1510
1511 2018-11-16  Brent Fulgham  <bfulgham@apple.com>
1512
1513         [Win] Reduce the use of WKSI library calls: CFNetwork
1514         https://bugs.webkit.org/show_bug.cgi?id=191718
1515         <rdar://problem/46108732>
1516
1517         Reviewed by Alex Christensen.
1518
1519         Remove custom WKSI CFNetwork calls, since the SPI is already documented in PAL. Just
1520         make the same calls on Windows, like we did for iOS and macOS back in 2017.
1521
1522         * WebCache.cpp:
1523         (WebCache::cacheFolder):
1524         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1525         * WebCoreSupport/WebPlatformStrategies.cpp:
1526         * WebError.cpp:
1527         (WebError::localizedDescription):
1528         (WebError::sslPeerCertificate):
1529         * WebURLResponse.cpp:
1530         (WebURLResponse::sslPeerCertificate):
1531         (WebURLResponse::certificateDictionary const):
1532         * WebView.cpp:
1533         (WebView::setCacheModel):
1534
1535 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
1536
1537         [Win] Reduce the use of WKSI library calls: Font Handling
1538         https://bugs.webkit.org/show_bug.cgi?id=191701
1539         <rdar://problem/46104809>
1540
1541         Reviewed by Myles C. Maxfield.
1542
1543         Update to use the old font handling routines moved from WKSI to FontCascade.
1544
1545         * WebPreferences.cpp:
1546         (WebPreferences::setFontSmoothing):
1547         (WebPreferences::setFontSmoothingContrast):
1548         * WebView.cpp:
1549         (systemParameterChanged):
1550
1551 2018-11-14  Timothy Hatcher  <timothy@apple.com>
1552
1553         Default the view background color and text color to different values when in dark mode.
1554         https://bugs.webkit.org/show_bug.cgi?id=191607
1555         rdar://problem/46045854
1556
1557         Reviewed by Dean Jackson.
1558
1559         * WebFrame.cpp:
1560         (WebFrame::updateBackground): Drop backgroundColor.
1561         * WebCoreSupport/WebFrameLoaderClient.cpp:
1562         (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor.
1563
1564 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1565
1566         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1567         https://bugs.webkit.org/show_bug.cgi?id=191612
1568
1569         Reviewed by Matt Baker.
1570
1571         * WebCoreSupport/WebInspectorClient.cpp:
1572         (WebInspectorFrontendClient::destroyInspectorView):
1573
1574 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
1575
1576         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
1577         https://bugs.webkit.org/show_bug.cgi?id=189230
1578         <rdar://problem/44050379>
1579
1580         Reviewed by Joseph Pecoraro.
1581
1582         Runs all png images through zopflipng. This results in a smaller file
1583         size and takes care of this issue as a byproduct.
1584
1585         * WebKit.resources/deleteButton.png:
1586         * WebKit.resources/deleteButtonPressed.png:
1587         * WebKit.resources/fsVideoAudioVolumeHigh.png:
1588         * WebKit.resources/fsVideoAudioVolumeLow.png:
1589         * WebKit.resources/fsVideoExitFullscreen.png:
1590         * WebKit.resources/fsVideoPause.png:
1591         * WebKit.resources/fsVideoPlay.png:
1592         * WebKit.resources/missingImage.png:
1593         * WebKit.resources/nullplugin.png:
1594         * WebKit.resources/panEastCursor.png:
1595         * WebKit.resources/panIcon.png:
1596         * WebKit.resources/panNorthCursor.png:
1597         * WebKit.resources/panNorthEastCursor.png:
1598         * WebKit.resources/panNorthWestCursor.png:
1599         * WebKit.resources/panSouthCursor.png:
1600         * WebKit.resources/panSouthEastCursor.png:
1601         * WebKit.resources/panSouthWestCursor.png:
1602         * WebKit.resources/panWestCursor.png:
1603         * WebKit.resources/searchCancel.png:
1604         * WebKit.resources/searchCancelPressed.png:
1605         * WebKit.resources/searchMagnifier.png:
1606         * WebKit.resources/searchMagnifierResults.png:
1607         * WebKit.resources/textAreaResizeCorner.png:
1608         * WebKit.resources/verticalTextCursor.png:
1609         * WebKit.resources/zoomInCursor.png:
1610         * WebKit.resources/zoomOutCursor.png:
1611
1612 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1613
1614         Unreviewed Windows build fix for r238049.
1615
1616         * WebView.cpp:
1617         (WebView::initWithFrame):
1618
1619 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1620
1621         Unreviewed MSVC build fix after r238039 (and r238046).
1622
1623         * WebDocumentLoader.h:
1624         * WebView.cpp:
1625         (WebView::setShouldApplyMacFontAscentHack):
1626
1627 2018-11-09  Antti Koivisto  <antti@apple.com>
1628
1629         Use OptionSet for layout milestones
1630         https://bugs.webkit.org/show_bug.cgi?id=191470
1631
1632         Reviewed by Dean Jackson.
1633
1634         * WebCoreSupport/WebFrameLoaderClient.cpp:
1635         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1636         * WebCoreSupport/WebFrameLoaderClient.h:
1637
1638 2018-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1639
1640         WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1641         https://bugs.webkit.org/show_bug.cgi?id=191455
1642
1643         Reviewed by Brent Fulgham.
1644
1645         * WebHistory.h: Marked with 'override' and removed 'virtual'.
1646
1647 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1648
1649         Add a storage limit for IndexedDB
1650         https://bugs.webkit.org/show_bug.cgi?id=190598
1651         <rdar://problem/44654715>
1652
1653         Reviewed by Chris Dumez.
1654
1655         * Interfaces/IWebDatabaseManager.idl:
1656         * WebDatabaseManager.cpp:
1657         (WebDatabaseManager::setIDBPerOriginQuota):
1658         * WebDatabaseManager.h:
1659
1660 2018-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1661
1662         [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
1663         https://bugs.webkit.org/show_bug.cgi?id=191105
1664
1665         Reviewed by Brent Fulgham.
1666
1667         * DOMHTMLClasses.h:
1668         (DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
1669         instead of own setNodeValue.
1670
1671 2018-10-25  Antoine Quint  <graouts@apple.com>
1672
1673         [Web Animations] Turn Web Animations CSS Integration off by default
1674         https://bugs.webkit.org/show_bug.cgi?id=190901
1675
1676         Reviewed by Dean Jackson.
1677
1678         * WebPreferences.cpp:
1679         (WebPreferences::initializeDefaultSettings):
1680
1681 2018-10-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1682
1683         [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1684         https://bugs.webkit.org/show_bug.cgi?id=190744
1685
1686         Reviewed by Alex Christensen.
1687
1688         clang-cl reports compilation warnings for inconsistent 'override'
1689         keyword usage.
1690
1691         WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
1692         This can't be marked 'override' if !USE(CA).
1693
1694         * WebView.cpp:
1695         (WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).
1696         * WebView.h: Marked all overriding member function declarations of WebView 'override'.
1697         Declare flushPendingGraphicsLayerChanges only if USE(CA).
1698
1699 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1700
1701         Clean up FrameLoader two-state enums
1702         https://bugs.webkit.org/show_bug.cgi?id=190731
1703
1704         Reviewed by Chris Dumez.
1705
1706         * WebCoreSupport/WebFrameLoaderClient.cpp:
1707         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1708         * WebCoreSupport/WebFrameLoaderClient.h:
1709
1710 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1711
1712         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1713         https://bugs.webkit.org/show_bug.cgi?id=190675
1714
1715         Reviewed by Chris Dumez.
1716
1717         * BackForwardList.cpp:
1718         (BackForwardList::backItem):
1719         (BackForwardList::currentItem):
1720         (BackForwardList::forwardItem):
1721         (BackForwardList::backListCount const):
1722         (BackForwardList::forwardListCount const):
1723         (BackForwardList::itemAtIndex):
1724         * BackForwardList.h:
1725
1726 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
1727
1728         Unreviewed attempt to fix the Windows build after r237112.
1729
1730         * Plugins/PluginView.cpp:
1731         (WebCore::PluginView::performRequest):
1732
1733 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1734
1735         Replace HistoryItem* with HistoryItem& where possible
1736         https://bugs.webkit.org/show_bug.cgi?id=190617
1737
1738         Reviewed by Chris Dumez.
1739
1740         * BackForwardList.cpp:
1741         (BackForwardList::goToItem):
1742         * BackForwardList.h:
1743         * WebBackForwardList.cpp:
1744         (WebBackForwardList::goToItem):
1745
1746 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1747
1748         Fix Windows build.
1749
1750         * WebView.cpp:
1751         (WebView::loadBackForwardListFromOtherView):
1752
1753 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1754
1755         Fix WinCairo build.
1756
1757         * WebView.cpp:
1758         (WebView::backForwardList):
1759
1760 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1761
1762         Modernize BackForwardClient.h
1763         https://bugs.webkit.org/show_bug.cgi?id=190610
1764
1765         Reviewed by Chris Dumez.
1766
1767         * BackForwardList.cpp:
1768         (BackForwardList::backListCount const):
1769         (BackForwardList::forwardListCount const):
1770         (BackForwardList::backListCount): Deleted.
1771         (BackForwardList::forwardListCount): Deleted.
1772         * BackForwardList.h:
1773         * WebView.cpp:
1774         (WebView::initWithFrame):
1775         (WebView::backForwardList):
1776
1777 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1778
1779         Remove unused WebView._globalHistoryItem
1780         https://bugs.webkit.org/show_bug.cgi?id=190601
1781
1782         Reviewed by Chris Dumez.
1783
1784         * WebCoreSupport/WebFrameLoaderClient.cpp:
1785         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1786         * WebCoreSupport/WebFrameLoaderClient.h:
1787         * WebView.cpp:
1788         (WebView::globalHistoryItem):
1789         (WebView::setGlobalHistoryItem): Deleted.
1790         * WebView.h:
1791
1792 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1793
1794         Remove unused parameters from FrameLoaderClient::createFrame
1795         https://bugs.webkit.org/show_bug.cgi?id=190587
1796
1797         Reviewed by Chris Dumez.
1798
1799         * WebCoreSupport/WebFrameLoaderClient.cpp:
1800         (WebFrameLoaderClient::createFrame):
1801         * WebCoreSupport/WebFrameLoaderClient.h:
1802
1803 2018-10-15  Chris Dumez  <cdumez@apple.com>
1804
1805         Unreviewed Windows build fix after r237112.
1806
1807         * Plugins/PluginView.cpp:
1808         (WebCore::PluginView::performRequest):
1809         (WebCore::PluginView::load):
1810
1811 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1812
1813         Remove InjectedBundle processing of back/forward lists
1814         https://bugs.webkit.org/show_bug.cgi?id=190459
1815
1816         Reviewed by Chris Dumez.
1817
1818         * WebCoreSupport/WebFrameLoaderClient.cpp:
1819         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1820         * WebCoreSupport/WebFrameLoaderClient.h:
1821
1822 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1823
1824         Remove ParsedURLString
1825         https://bugs.webkit.org/show_bug.cgi?id=190154
1826
1827         Reviewed by Chris Dumez.
1828
1829         * WebDownloadCurl.cpp:
1830         (WebDownload::initWithRequest):
1831         * WebURLResponse.cpp:
1832         (WebURLResponse::createInstance):
1833
1834 2018-09-28  Chris Dumez  <cdumez@apple.com>
1835
1836         Drop support for cross-origin-window-policy header
1837         https://bugs.webkit.org/show_bug.cgi?id=190081
1838
1839         Reviewed by Ryosuke Niwa.
1840
1841         * WebPreferenceKeysPrivate.h:
1842         * WebPreferences.cpp:
1843         (WebPreferences::initializeDefaultSettings):
1844         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1845         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1846         * WebView.cpp:
1847         (WebView::notifyPreferencesChanged):
1848
1849 2018-09-27  Antoine Quint  <graouts@apple.com>
1850
1851         [Web Animations] Turn Web Animations with CSS integration on
1852         https://bugs.webkit.org/show_bug.cgi?id=184819
1853         <rdar://problem/39597337>
1854
1855         Reviewed by Dean Jackson.
1856
1857         * WebPreferences.cpp:
1858         (WebPreferences::initializeDefaultSettings):
1859
1860 2018-09-21  Alex Christensen  <achristensen@webkit.org>
1861
1862         Use a Variant for FormDataElement
1863         https://bugs.webkit.org/show_bug.cgi?id=189777
1864
1865         Reviewed by Chris Dumez.
1866
1867         * WebMutableURLRequest.cpp:
1868         (WebMutableURLRequest::setHTTPBody):
1869
1870 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1871
1872         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
1873         https://bugs.webkit.org/show_bug.cgi?id=189612
1874
1875         Reviewed by Alex Christensen.
1876
1877         Non-trivial types can't be used as aruguments of LOG_ERROR and
1878         ASSERT_WITH_MESSAGE.
1879
1880         * DefaultPolicyDelegate.cpp:
1881         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
1882         static_cast<BSTR> to convert BString.
1883         * WebLocalizableStrings.cpp:
1884         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
1885         char* by using 'key.utf8().data()'.
1886
1887 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
1888
1889         Unreviewed, rolling out r235953.
1890
1891         Caused layout test crashes under GuardMalloc.
1892
1893         Reverted changeset:
1894
1895         "Make GraphicsLayers ref-counted, so their tree can persist
1896         when disconnected from RenderLayerBackings"
1897         https://bugs.webkit.org/show_bug.cgi?id=189521
1898         https://trac.webkit.org/changeset/235953
1899
1900 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1901
1902         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
1903         https://bugs.webkit.org/show_bug.cgi?id=189538
1904
1905         Reviewed by Per Arne Vollan.
1906
1907         * WebPreferences.cpp:
1908         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
1909         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
1910         Apply static_cast to the result of OR-ed CFPropertyListFormat.
1911         (WebPreferences::screenFontSubstitutionEnabled):
1912         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
1913
1914 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1915
1916         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
1917         https://bugs.webkit.org/show_bug.cgi?id=189539
1918
1919         Reviewed by Alex Christensen.
1920
1921         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
1922         * WebCoreSupport/WebInspectorClient.cpp:
1923         (WebInspectorWndProc): Ditto.
1924         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
1925         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
1926
1927 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1928
1929         Refactor WebCore::EditAction to be an 8-bit enum class
1930         https://bugs.webkit.org/show_bug.cgi?id=189383
1931
1932         Reviewed by Dan Bernstein.
1933
1934         * WebCoreSupport/WebEditorClient.cpp:
1935         (undoNameForEditAction):
1936
1937 2018-09-04  Frederic Wang  <fwang@igalia.com>
1938
1939         Add basic support for ScrollIntoViewOptions
1940         https://bugs.webkit.org/show_bug.cgi?id=189258
1941
1942         Reviewed by Simon Fraser.
1943
1944         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
1945         can build despite the new scrollIntoView function.
1946
1947 2018-08-31  Chris Dumez  <cdumez@apple.com>
1948
1949         Unreviewed Windows build fix after r235562.
1950
1951         * WebCoreSupport/WebFrameLoaderClient.cpp:
1952         (WebFrameLoaderClient::dispatchWillSubmitForm):
1953
1954 2018-08-31  Chris Dumez  <cdumez@apple.com>
1955
1956         Assertion hit in ~CompletionHandler() from ~WebFrame()
1957         https://bugs.webkit.org/show_bug.cgi?id=189199
1958         <rdar://problem/42657233>
1959
1960         Reviewed by Youenn Fablet.
1961
1962         * WebCoreSupport/WebFrameLoaderClient.cpp:
1963         (WebFrameLoaderClient::dispatchWillSubmitForm):
1964         * WebCoreSupport/WebFrameLoaderClient.h:
1965
1966 2018-08-31  Frederic Wang  <fwang@igalia.com>
1967
1968         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1969         https://bugs.webkit.org/show_bug.cgi?id=182053
1970
1971         Reviewed by Simon Fraser.
1972
1973         Add developer flag to use standard behavior for scrolling* attributes.
1974
1975         * Interfaces/IWebPreferencesPrivate.idl:
1976         * WebPreferenceKeysPrivate.h:
1977         * WebPreferences.cpp:
1978         (WebPreferences::initializeDefaultSettings):
1979         (WebPreferences::CSSOMViewScrollingAPIEnabled):
1980         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
1981         * WebPreferences.h:
1982         * WebView.cpp:
1983         (WebView::notifyPreferencesChanged):
1984
1985 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
1986
1987         [CMake] Replace AVFoundationSupport.py using CMake
1988         https://bugs.webkit.org/show_bug.cgi?id=182891
1989
1990         Reviewed by Per Arne Vollan.
1991
1992         Remove references to the config.h contained in WebCore as it should
1993         not be accessible from outside of WebCore.
1994
1995         * WebKitPrefix.h:
1996
1997 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1998
1999         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
2000         https://bugs.webkit.org/show_bug.cgi?id=188496
2001         <rdar://problem/43216836>
2002
2003         Reviewed by Tim Horton.
2004
2005         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
2006         header directly.
2007
2008         * WebCoreSupport/WebDragClient.cpp:
2009
2010 2018-08-17  Alex Christensen  <achristensen@webkit.org>
2011
2012         Add some plumbing for safe browsing
2013         https://bugs.webkit.org/show_bug.cgi?id=188709
2014
2015         Reviewed by Tim Horton.
2016
2017         * WebCoreSupport/WebFrameLoaderClient.cpp:
2018         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2019         * WebCoreSupport/WebFrameLoaderClient.h:
2020
2021 2018-08-02  David Fenton  <david_fenton@apple.com>
2022
2023         Unreviewed, rolling out r234489.
2024
2025         Caused 50+ crashes and 60+ API failures on iOS
2026
2027         Reverted changeset:
2028
2029         "[WTF] Rename String::format to String::deprecatedFormat"
2030         https://bugs.webkit.org/show_bug.cgi?id=188191
2031         https://trac.webkit.org/changeset/234489
2032
2033 2018-08-01  Tomas Popela  <tpopela@redhat.com>
2034
2035         [WTF] Rename String::format to String::deprecatedFormat
2036         https://bugs.webkit.org/show_bug.cgi?id=188191
2037
2038         Reviewed by Darin Adler.
2039
2040         It should be replaced with string concatenation.
2041
2042         * FullscreenVideoController.cpp:
2043         (timeToString):
2044         * WebView.cpp:
2045         (webKitVersionString):
2046
2047 2018-07-30  Rob Buis  <rbuis@igalia.com>
2048
2049         https://bugs.webkit.org/show_bug.cgi?id=188137
2050         Merge PlatformCookieJar functions into NetworkStorageSession
2051
2052         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
2053
2054         Reviewed by Alex Christensen.
2055
2056         * WebCoreSupport/WebPlatformStrategies.cpp:
2057         (WebPlatformStrategies::cookiesForDOM):
2058         (WebPlatformStrategies::setCookiesFromDOM):
2059         (WebPlatformStrategies::cookiesEnabled):
2060         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2061         (WebPlatformStrategies::getRawCookies):
2062         (WebPlatformStrategies::deleteCookie):
2063         * WebPreferences.cpp:
2064         (WebPreferences::clearNetworkLoaderSession):
2065
2066 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
2067
2068         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
2069         https://bugs.webkit.org/show_bug.cgi?id=187963
2070
2071         Reviewed by Alex Christensen.
2072
2073         * Plugins/PluginPackageWin.cpp:
2074         (WebCore::PluginPackage::fetchInfo):
2075         Update split/splitAllowingEmptyEntries usage.
2076
2077 2018-07-18  Antoine Quint  <graouts@apple.com>
2078
2079         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
2080         https://bugs.webkit.org/show_bug.cgi?id=187722
2081
2082         Reviewed by Myles Maxfield.
2083
2084         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
2085
2086         * DOMCoreClasses.cpp:
2087         (DOMElement::font):
2088
2089 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
2090
2091         Disable cross-origin-window-policy by default
2092         https://bugs.webkit.org/show_bug.cgi?id=187509
2093
2094         Reviewed by Chris Dumez.
2095
2096         * WebPreferences.cpp:
2097         (WebPreferences::initializeDefaultSettings):
2098
2099 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2100
2101         [WTF] Add user-defined literal for ASCIILiteral
2102         https://bugs.webkit.org/show_bug.cgi?id=186839
2103
2104         Reviewed by Darin Adler.
2105
2106         * Plugins/PluginStream.cpp:
2107         (WebCore::PluginStream::startStream):
2108         * WebCoreSupport/WebContextMenuClient.cpp:
2109         (WebContextMenuClient::searchWithGoogle):
2110
2111 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2112
2113         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
2114         https://bugs.webkit.org/show_bug.cgi?id=186623
2115
2116         Reviewed by Youenn Fablet.
2117
2118         * WebCoreSupport/WebPluginInfoProvider.cpp:
2119         (WebPluginInfoProvider::pluginInfo):
2120         (WebPluginInfoProvider::webVisiblePluginInfo):
2121         * WebCoreSupport/WebPluginInfoProvider.h:
2122
2123 2018-06-13  Chris Dumez  <cdumez@apple.com>
2124
2125         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
2126         https://bugs.webkit.org/show_bug.cgi?id=186545
2127
2128         Reviewed by Brady Eidson.
2129
2130         Update client delegate now that parameter type has changed.
2131
2132         * WebCoreSupport/WebFrameLoaderClient.cpp:
2133         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2134         * WebCoreSupport/WebFrameLoaderClient.h:
2135
2136 2018-06-11  Chris Dumez  <cdumez@apple.com>
2137
2138         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
2139         https://bugs.webkit.org/show_bug.cgi?id=186441
2140
2141         Reviewed by Brady Eidson.
2142
2143         Rename existing flag to something a bit more generic, now that it is used for
2144         more things than bypassing the navigation policy check.
2145
2146         * WebView.cpp:
2147         (WebView::goToBackForwardItem):
2148         (WebView::loadBackForwardListFromOtherView):
2149
2150 2018-06-04  Chris Dumez  <cdumez@apple.com>
2151
2152         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
2153         https://bugs.webkit.org/show_bug.cgi?id=186287
2154         <rdar://problem/40783352>
2155
2156         Reviewed by Youenn Fablet.
2157
2158         * Interfaces/IWebPreferencesPrivate.idl:
2159         * WebPreferenceKeysPrivate.h:
2160         * WebPreferences.cpp:
2161         (WebPreferences::initializeDefaultSettings):
2162         (WebPreferences::crossOriginWindowPolicySupportEnabled):
2163         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
2164         * WebPreferences.h:
2165         * WebView.cpp:
2166         (WebView::notifyPreferencesChanged):
2167
2168 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2169
2170         [JSC] Pass VM& parameter as much as possible
2171         https://bugs.webkit.org/show_bug.cgi?id=186085
2172
2173         Reviewed by Saam Barati.
2174
2175         * Plugins/PluginPackage.cpp:
2176         (WebCore::NPN_Invoke):
2177
2178 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2179
2180         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
2181         https://bugs.webkit.org/show_bug.cgi?id=186125
2182
2183         Unreviewed build fix
2184
2185         * WebActionPropertyBag.cpp:
2186         (WebActionPropertyBag::Read):
2187         (findMouseEvent): Deleted.
2188
2189 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
2190
2191         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
2192         https://bugs.webkit.org/show_bug.cgi?id=186027
2193
2194         Unreviewed build fix
2195
2196         * WebMutableURLRequest.cpp:
2197         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
2198         (WebMutableURLRequest::setClientCertificate):
2199
2200 2018-05-25  Chris Dumez  <cdumez@apple.com>
2201
2202         Minor ApplicationCacheStorage clean up
2203         https://bugs.webkit.org/show_bug.cgi?id=185984
2204
2205         Reviewed by Youenn Fablet.
2206
2207         * WebApplicationCache.cpp:
2208         (WebApplicationCache::originsWithCache):
2209
2210 2018-05-24  Chris Dumez  <cdumez@apple.com>
2211
2212         Reduce copying of FontCascadeDescription objects by moving them around
2213         https://bugs.webkit.org/show_bug.cgi?id=185963
2214
2215         Reviewed by Simon Fraser.
2216
2217         Reduce copying of FontCascadeDescription objects by moving them around when possible.
2218
2219         * FullscreenVideoController.cpp:
2220         (FullscreenVideoController::draw):
2221
2222 2018-05-15  Antoine Quint  <graouts@apple.com>
2223
2224         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2225         https://bugs.webkit.org/show_bug.cgi?id=185647
2226
2227         Reviewed by Dean Jackson.
2228
2229         Rename the Web Animations CSS integration flag.
2230
2231         * Interfaces/IWebPreferencesPrivate.idl:
2232         * WebPreferenceKeysPrivate.h:
2233         * WebPreferences.cpp:
2234         (WebPreferences::initializeDefaultSettings):
2235         (WebPreferences::webAnimationsCSSIntegrationEnabled):
2236         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
2237         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
2238         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
2239         * WebPreferences.h:
2240         * WebView.cpp:
2241         (WebView::notifyPreferencesChanged):
2242
2243 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2244
2245         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
2246         https://bugs.webkit.org/show_bug.cgi?id=185505
2247
2248         Unreviewed serious crash fix
2249
2250         Windows port crashes soon since Bug 184996.
2251
2252         * WebPreferences.cpp:
2253         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
2254         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
2255
2256 2018-05-07  Daniel Bates  <dabates@apple.com>
2257
2258         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
2259         https://bugs.webkit.org/show_bug.cgi?id=185170
2260
2261         Reviewed by Per Arne Vollan.
2262
2263         * WebCache.cpp:
2264         (WebCache::empty):
2265
2266 2018-04-27  Chris Dumez  <cdumez@apple.com>
2267
2268         Use WindowProxy instead of DOMWindow in our IDL
2269         https://bugs.webkit.org/show_bug.cgi?id=185022
2270
2271         Reviewed by Sam Weinig.
2272
2273         * DOMCoreClasses.cpp:
2274         (DOMDocument::getComputedStyle):
2275
2276 2018-04-23  Daniel Bates  <dabates@apple.com>
2277
2278         Implement Same-Site cookies
2279         https://bugs.webkit.org/show_bug.cgi?id=159464
2280         <rdar://problem/27196358>
2281
2282         Reviewed by Brent Fulgham.
2283
2284         Pass the Same-Site info through the strategy.
2285
2286         * WebCoreSupport/WebPlatformStrategies.cpp:
2287         (WebPlatformStrategies::cookiesForDOM):
2288         (WebPlatformStrategies::setCookiesFromDOM):
2289         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2290         (WebPlatformStrategies::getRawCookies):
2291         * WebCoreSupport/WebPlatformStrategies.h:
2292
2293 2018-04-23  Daniel Bates  <dabates@apple.com>
2294
2295         Implement Same-Site cookies
2296         https://bugs.webkit.org/show_bug.cgi?id=159464
2297         <rdar://problem/27196358>
2298
2299         Reviewed by Brent Fulgham.
2300
2301         Pass the Same-Site info through the strategy.
2302
2303         * WebCoreSupport/WebPlatformStrategies.cpp:
2304         (WebPlatformStrategies::cookiesForDOM):
2305         (WebPlatformStrategies::setCookiesFromDOM):
2306         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2307         (WebPlatformStrategies::getRawCookies):
2308         * WebCoreSupport/WebPlatformStrategies.h:
2309
2310 2018-04-20  Youenn Fablet  <youenn@apple.com>
2311
2312         Make PluginData cache its web visible plugins
2313         https://bugs.webkit.org/show_bug.cgi?id=184421
2314
2315         Reviewed by Chris Dumez.
2316
2317         * WebCoreSupport/WebPluginInfoProvider.cpp:
2318         (WebPluginInfoProvider::pluginInfo):
2319         (WebPluginInfoProvider::webVisiblePluginInfo):
2320         * WebCoreSupport/WebPluginInfoProvider.h:
2321
2322 2018-04-19  Chris Dumez  <cdumez@apple.com>
2323
2324         Rename JSDOMWindowProxy to JSWindowProxy
2325         https://bugs.webkit.org/show_bug.cgi?id=184797
2326
2327         Reviewed by Sam Weinig.
2328
2329         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
2330
2331         * WebFrame.cpp:
2332         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2333
2334 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2335
2336         Unreviewed rollout of r230632. Regression in memory usage.
2337
2338         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2339
2340         * WebPreferences.cpp:
2341         (WebPreferences::initializeDefaultSettings):
2342
2343 2018-04-17  Chris Dumez  <cdumez@apple.com>
2344
2345         Unreviewed attempt to fix the Windows build after r230721
2346
2347         * WebCoreSupport/WebFrameLoaderClient.cpp:
2348         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2349
2350 2018-04-17  Chris Dumez  <cdumez@apple.com>
2351
2352         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
2353         https://bugs.webkit.org/show_bug.cgi?id=184678
2354         <rdar://problem/39422122>
2355
2356         Reviewed by Alex Christensen.
2357
2358         Add new parameter to dispatchDecidePolicyForNavigationAction.
2359
2360         * WebCoreSupport/WebFrameLoaderClient.cpp:
2361         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2362         * WebCoreSupport/WebFrameLoaderClient.h:
2363
2364 2018-04-12  Antoine Quint  <graouts@apple.com>
2365
2366         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
2367         https://bugs.webkit.org/show_bug.cgi?id=184569
2368         <rdar://problem/38671301>
2369
2370         Reviewed by Jon Lee.
2371
2372         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
2373
2374         * WebPreferences.cpp:
2375
2376 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2377
2378         [WTF] Remove StaticLock
2379         https://bugs.webkit.org/show_bug.cgi?id=184332
2380
2381         Reviewed by Mark Lam.
2382
2383         * WebKitQuartzCoreAdditions/CAView.cpp:
2384         (WKQCA::CAView::releaseAllD3DResources):
2385         * WebLocalizableStrings.cpp:
2386
2387 2018-04-03  Chris Dumez  <cdumez@apple.com>
2388
2389         Drop MainFrame class
2390         https://bugs.webkit.org/show_bug.cgi?id=184191
2391
2392         Reviewed by Darin Adler.
2393
2394         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
2395         relationship between the Page and the MainFrame.
2396
2397         This is ground work for introducing LocalFrame / RemoteFrame concepts.
2398
2399         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2400         * WebCoreSupport/WebContextMenuClient.cpp:
2401         * WebCoreSupport/WebDragClient.cpp:
2402         * WebDropSource.cpp:
2403         * WebFrame.cpp:
2404         * WebView.cpp:
2405
2406 2018-03-26  Chris Dumez  <cdumez@apple.com>
2407
2408         Use SecurityOriginData more consistently in Service Worker code
2409         https://bugs.webkit.org/show_bug.cgi?id=183969
2410
2411         Reviewed by Darin Adler.
2412
2413         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2414
2415         * WebDatabaseManager.cpp:
2416         (WebDatabaseManager::databasesWithOrigin):
2417         (WebDatabaseManager::deleteOrigin):
2418         (WebDatabaseManager::deleteDatabase):
2419         (WebDatabaseManager::setQuota):
2420         * WebSecurityOrigin.cpp:
2421         (WebSecurityOrigin::usage):
2422         (WebSecurityOrigin::quota):
2423         (WebSecurityOrigin::setQuota):
2424
2425 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
2426
2427         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
2428         https://bugs.webkit.org/show_bug.cgi?id=183911
2429         <rdar://problem/38762306>
2430
2431         Reviewed by Youenn Fablet.
2432
2433         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
2434
2435         * WebView.cpp:
2436         (WebView::WebView):
2437
2438 2018-03-25  Commit Queue  <commit-queue@webkit.org>
2439
2440         Unreviewed, rolling out r229954.
2441         https://bugs.webkit.org/show_bug.cgi?id=184000
2442
2443         Caused many layout tests to crash on Apple High Sierra,
2444         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
2445         by dydz on #webkit).
2446
2447         Reverted changeset:
2448
2449         "Use SecurityOriginData more consistently in Service Worker
2450         code"
2451         https://bugs.webkit.org/show_bug.cgi?id=183969
2452         https://trac.webkit.org/changeset/229954
2453
2454 2018-03-24  Chris Dumez  <cdumez@apple.com>
2455
2456         Use SecurityOriginData more consistently in Service Worker code
2457         https://bugs.webkit.org/show_bug.cgi?id=183969
2458
2459         Reviewed by Darin Adler.
2460
2461         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2462
2463         * WebDatabaseManager.cpp:
2464         (WebDatabaseManager::databasesWithOrigin):
2465         (WebDatabaseManager::deleteOrigin):
2466         (WebDatabaseManager::deleteDatabase):
2467         (WebDatabaseManager::setQuota):
2468         * WebSecurityOrigin.cpp:
2469         (WebSecurityOrigin::usage):
2470         (WebSecurityOrigin::quota):
2471         (WebSecurityOrigin::setQuota):
2472
2473 2018-03-23  Chris Dumez  <cdumez@apple.com>
2474
2475         Unreviewed attempt to fix Windows build after r229926.
2476
2477         * WebView.cpp:
2478
2479 2018-03-23  Brady Eidson  <beidson@apple.com>
2480
2481         Go to back/forward list items after a process-swapped navigation.
2482         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
2483
2484         Reviewed by Andy Estes.
2485
2486         * WebView.cpp:
2487         (WebView::goToBackForwardItem):
2488         (WebView::loadBackForwardListFromOtherView):
2489
2490 2018-03-23  Miguel Gomez  <magomez@igalia.com>
2491
2492         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
2493         https://bugs.webkit.org/show_bug.cgi?id=183892
2494
2495         Remove the UpdateContentsFlag parameter as it's not used anymore.
2496
2497         Reviewed by Žan Doberšek.
2498
2499         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2500         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
2501
2502 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
2503
2504         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
2505         https://bugs.webkit.org/show_bug.cgi?id=183335
2506
2507         Reviewed by Alex Christensen.
2508
2509         * Plugins/PluginDatabaseWin.cpp:
2510         * Plugins/PluginMessageThrottlerWin.cpp:
2511         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
2512         * Plugins/PluginPackageWin.cpp:
2513         (WebCore::PluginPackage::load):
2514         * Plugins/PluginView.h:
2515         * Plugins/PluginViewWin.cpp:
2516         * Plugins/npapi.cpp:
2517         * WebCoreSupport/WebFrameLoaderClient.cpp:
2518         (WebFrameLoaderClient::createPlugin):
2519         (WebFrameLoaderClient::createJavaAppletWidget):
2520         * WebView.cpp:
2521         (WebView::WebViewWndProc):
2522
2523 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
2524
2525         [Win] Layout Test fast/html/menuitem-element.html is failing.
2526         https://bugs.webkit.org/show_bug.cgi?id=179299
2527
2528         Reviewed by Per Arne Vollan.
2529
2530         * Interfaces/IWebPreferencesPrivate.idl:
2531         * WebPreferenceKeysPrivate.h:
2532         * WebPreferences.cpp:
2533         (WebPreferences::menuItemElementEnabled):
2534         (WebPreferences::setMenuItemElementEnabled):
2535         * WebPreferences.h:
2536         * WebView.cpp:
2537         (WebView::notifyPreferencesChanged):
2538         Add private web preference "menuItemElementEnabled".
2539
2540 2018-03-12  Antoine Quint  <graouts@apple.com>
2541
2542         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
2543         https://bugs.webkit.org/show_bug.cgi?id=183504
2544         <rdar://problem/38372965>
2545
2546         Reviewed by Dean Jackson and Jon Lee.
2547
2548         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
2549         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
2550
2551         * Interfaces/IWebPreferencesPrivate.idl:
2552         * WebPreferences.cpp:
2553         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2554         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2555         * WebPreferenceKeysPrivate.h
2556         * WebPreferences.h:
2557         * WebView.cpp:
2558         (WebView::notifyPreferencesChanged):
2559
2560 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2561
2562         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
2563         https://bugs.webkit.org/show_bug.cgi?id=183429
2564
2565         Reviewed by Mark Lam.
2566
2567         * WebFrame.cpp:
2568         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2569
2570 2018-03-08  Tim Horton  <timothy_horton@apple.com>
2571
2572         Stop linking ApplicationServices directly
2573         https://bugs.webkit.org/show_bug.cgi?id=182867
2574         <rdar://problem/38252142>
2575
2576         Reviewed by Alex Christensen.
2577
2578         The frameworks that we use that live inside ApplicationServices
2579         have mostly moved out, so import them directly.
2580
2581         * FullscreenVideoController.cpp:
2582
2583 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2584
2585         Fix std::make_unique / new[] using system malloc
2586         https://bugs.webkit.org/show_bug.cgi?id=182975
2587
2588         Reviewed by JF Bastien.
2589
2590         Use Vector instead.
2591
2592         * MarshallingHelpers.cpp:
2593         (MarshallingHelpers::safeArrayToStringArray):
2594         (MarshallingHelpers::safeArrayToIntArray):
2595         * Plugins/PluginPackageWin.cpp:
2596         (WebCore::PluginPackage::fetchInfo):
2597         * WebPreferences.cpp:
2598         (WebPreferences::copyWebKitPreferencesToCFPreferences):
2599         * WebView.cpp:
2600         (WebView::onMenuCommand):
2601
2602 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2603
2604         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
2605         https://bugs.webkit.org/show_bug.cgi?id=183312
2606
2607         Reviewed by Mark Lam.
2608
2609         Remove wtf/CurrentTime.h include pragma.
2610
2611         * WebDownload.cpp:
2612         * WebDownloadCFNet.cpp:
2613         * WebDropSource.cpp:
2614
2615 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2616
2617         Remove monotonicallyIncreasingTime
2618         https://bugs.webkit.org/show_bug.cgi?id=182911
2619
2620         Reviewed by Michael Catanzaro.
2621
2622         * FullscreenVideoController.cpp:
2623         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
2624         * Plugins/PluginMessageThrottlerWin.cpp:
2625         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
2626         (WebCore::PluginMessageThrottlerWin::appendMessage):
2627         * Plugins/PluginMessageThrottlerWin.h:
2628         * WebView.cpp:
2629         (WebView::notifyAnimationStarted):
2630         * WebView.h:
2631
2632 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2633
2634         [Win][DRT] Implement setSpatialNavigationEnabled.
2635         https://bugs.webkit.org/show_bug.cgi?id=183166
2636
2637         Reviewed by Per Arne Vollan.
2638
2639         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
2640
2641         * Interfaces/IWebPreferencesPrivate.idl:
2642         * WebPreferenceKeysPrivate.h:
2643         * WebPreferences.cpp:
2644         (WebPreferences::initializeDefaultSettings):
2645         (WebPreferences::spatialNavigationEnabled):
2646         (WebPreferences::setSpatialNavigationEnabled):
2647         * WebPreferences.h:
2648         * WebView.cpp:
2649         (WebView::notifyPreferencesChanged):
2650
2651 2018-02-28  Alex Christensen  <achristensen@webkit.org>
2652
2653         Reduce use of NetworkingContext in WebKit
2654         https://bugs.webkit.org/show_bug.cgi?id=183213
2655
2656         Reviewed by Brady Eidson.
2657
2658         * Plugins/PluginView.cpp:
2659         (WebCore::PluginView::getValueForURL):
2660
2661 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
2662
2663         Fix WebCore includes within WebKitLegacy
2664         https://bugs.webkit.org/show_bug.cgi?id=183147
2665
2666         Reviewed by Tim Horton.
2667
2668         * Plugins/PluginDatabase.cpp:
2669         * Plugins/PluginDatabaseWin.cpp:
2670         * Plugins/PluginDebug.cpp:
2671         * Plugins/PluginDebug.h:
2672         * Plugins/PluginMainThreadScheduler.cpp:
2673         * Plugins/PluginMessageThrottlerWin.cpp:
2674         * Plugins/PluginMessageThrottlerWin.h:
2675         * Plugins/PluginPackage.cpp:
2676         * Plugins/PluginPackage.h:
2677         * Plugins/PluginPackageWin.cpp:
2678         * Plugins/PluginStream.cpp:
2679         * Plugins/PluginStream.h:
2680         * Plugins/PluginView.cpp:
2681         * Plugins/PluginView.h:
2682         * Plugins/PluginViewWin.cpp:
2683         * Plugins/npapi.cpp:
2684         * WebCoreSupport/WebChromeClient.cpp:
2685         * WebCoreSupport/WebContextMenuClient.cpp:
2686         * WebCoreSupport/WebFrameLoaderClient.cpp:
2687         * WebCoreSupport/WebInspectorClient.cpp:
2688         * WebCoreSupport/WebPlatformStrategies.cpp:
2689         * WebFrame.cpp:
2690         * WebKitMessageLoop.cpp:
2691         * WebView.cpp:
2692         * storage/WebDatabaseProvider.cpp:
2693
2694 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2695
2696         Remove currentTime() / currentTimeMS()
2697         https://bugs.webkit.org/show_bug.cgi?id=183052
2698
2699         Reviewed by Mark Lam.
2700
2701         * WebCoreSupport/WebFrameLoaderClient.cpp:
2702         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2703         * WebCoreSupport/WebFrameLoaderClient.h:
2704         * WebDownload.h:
2705         * WebDownloadCFNet.cpp:
2706         (WebDownload::didStart):
2707         (WebDownload::didReceiveData):
2708         (WebDownload::didFinish):
2709
2710 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
2711
2712         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
2713         https://bugs.webkit.org/show_bug.cgi?id=182883
2714
2715         Reviewed by Per Arne Vollan.
2716
2717         * WebKitPrefix.h:
2718
2719 2018-02-16  Dean Jackson  <dino@apple.com>
2720
2721         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
2722         https://bugs.webkit.org/show_bug.cgi?id=182894
2723
2724         Reviewed by Tim Horton.
2725
2726         Rename OPENGL_ES_2 to OPENGL_ES.
2727
2728         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2729
2730 2018-02-16  Youenn Fablet  <youenn@apple.com>
2731
2732         Allow specifying which plug-ins are supported
2733         https://bugs.webkit.org/show_bug.cgi?id=182748
2734
2735         Reviewed by Chris Dumez.
2736
2737         * WebCoreSupport/WebPluginInfoProvider.cpp:
2738         (WebPluginInfoProvider::getPluginInfo):
2739         * WebCoreSupport/WebPluginInfoProvider.h:
2740
2741 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
2742
2743         WebCore headers should not be included relatively within dependent projects
2744         https://bugs.webkit.org/show_bug.cgi?id=182805
2745
2746         Reviewed by Chris Dumez.
2747
2748         * FullscreenVideoController.h:
2749
2750 2018-02-13  Commit Queue  <commit-queue@webkit.org>
2751
2752         Unreviewed, rolling out r228431.
2753         https://bugs.webkit.org/show_bug.cgi?id=182766
2754
2755         Regressed CMake build stability (Requested by dolmstead on
2756         #webkit).
2757
2758         Reverted changeset:
2759
2760         "[CMake] Make WebCore headers copies"
2761         https://bugs.webkit.org/show_bug.cgi?id=182512
2762         https://trac.webkit.org/changeset/228431
2763
2764 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
2765
2766         [CMake] Make WebCore headers copies
2767         https://bugs.webkit.org/show_bug.cgi?id=182512
2768
2769         Reviewed by Keith Miller.
2770
2771         * FullscreenVideoController.h:
2772         * Plugins/PluginDatabase.cpp:
2773         * Plugins/PluginDatabaseWin.cpp:
2774         * Plugins/PluginDebug.cpp:
2775         * Plugins/PluginMainThreadScheduler.cpp:
2776         * Plugins/PluginMessageThrottlerWin.cpp:
2777         * Plugins/PluginPackage.cpp:
2778         * Plugins/PluginPackageWin.cpp:
2779         * Plugins/PluginStream.cpp:
2780         * Plugins/PluginView.cpp:
2781         * Plugins/PluginViewWin.cpp:
2782         * Plugins/npapi.cpp:
2783         * WebKitMessageLoop.cpp:
2784         * WebKitPrefix.h:
2785         * storage/WebDatabaseProvider.cpp:
2786
2787 2018-01-13  Darin Adler  <darin@apple.com>
2788
2789         Event improvements
2790         https://bugs.webkit.org/show_bug.cgi?id=179591
2791
2792         Reviewed by Chris Dumez.
2793
2794         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
2795         * WebFrame.cpp: Ditto.
2796
2797         * WebScriptWorld.cpp:
2798         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
2799
2800         * WebView.cpp: Removed include of ScriptValue.h.
2801         (WebView::handleEditingKeyboardEvent): Updated for name change from
2802         keyEvent to underlyingPlatformEvent.
2803
2804 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
2805
2806         Remove WebCore/ForwardingHeaders directory
2807         https://bugs.webkit.org/show_bug.cgi?id=182347
2808
2809         Reviewed by Keith Miller.
2810
2811         * Plugins/PluginView.cpp:
2812         * Plugins/PluginViewWin.cpp:
2813         * WebCoreSupport/WebInspectorClient.cpp:
2814         * WebCoreSupport/WebInspectorClient.h:
2815         * WebFrame.cpp:
2816         * WebJavaScriptCollector.cpp:
2817         * WebView.cpp:
2818
2819 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2820
2821         Unreviewed, another attempt to fix the Windows build after r227479.
2822
2823         * WebFrame.cpp:
2824         (WebFrame::elementWithName):
2825
2826 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2827
2828         Unreviewed, try to fix the Windows build after r227479.
2829
2830         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
2831
2832         * WebFrame.cpp:
2833         (WebFrame::elementWithName):
2834         (WebFrame::controlsInForm):
2835
2836 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
2837
2838         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
2839         https://bugs.webkit.org/show_bug.cgi?id=181859
2840         <rdar://problem/36659886>
2841
2842         Reviewed by Alex Christensen.
2843         
2844         Use local include patch.
2845
2846         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
2847         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
2848         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
2849
2850 2018-01-17  Youenn Fablet  <youenn@apple.com>
2851
2852         Put fetch Request.keepalive behind a runtime flag
2853         https://bugs.webkit.org/show_bug.cgi?id=181592
2854
2855         Reviewed by Chris Dumez.
2856
2857         * WebPreferences.cpp:
2858         (WebPreferences::fetchAPIKeepAliveEnabled):
2859         (WebPreferences::setFetchAPIKeepAliveEnabled):
2860         * WebPreferences.h:
2861         * WebView.cpp:
2862         (WebView::notifyPreferencesChanged):
2863
2864 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2865
2866         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2867         https://bugs.webkit.org/show_bug.cgi?id=181637
2868         <rdar://problem/36508471>
2869
2870         Reviewed by Tim Horton.
2871
2872         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
2873
2874         * WebCoreSupport/WebEditorClient.cpp:
2875         (WebEditorClient::replacementURLForResource):
2876         * WebCoreSupport/WebEditorClient.h:
2877
2878 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2879
2880         Remove std::chrono completely
2881         https://bugs.webkit.org/show_bug.cgi?id=181186
2882
2883         Reviewed by Alex Christensen.
2884
2885         * Plugins/PluginStream.cpp:
2886         (WebCore::lastModifiedDateMS):
2887
2888 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2889
2890         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
2891         https://bugs.webkit.org/show_bug.cgi?id=181173
2892
2893         Reviewed by Alex Christensen.
2894
2895         * WebNodeHighlight.cpp:
2896         (WebNodeHighlight::update): Scale the GraphicsContext.
2897
2898 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2899
2900         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
2901         https://bugs.webkit.org/show_bug.cgi?id=181160
2902
2903         Reviewed by Myles C. Maxfield.
2904
2905         * Plugins/PluginView.cpp:
2906         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
2907
2908 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2909
2910         Enable picture-in-picture from inline element on suspend.
2911         https://bugs.webkit.org/show_bug.cgi?id=180942
2912         rdar://problem/34745234
2913
2914         Reviewed by Jer Noble.
2915
2916         Update signature of enterVideoFullscreenForVideoElement.
2917
2918         * WebCoreSupport/WebChromeClient.cpp:
2919         (WebChromeClient::enterVideoFullscreenForVideoElement):
2920         * WebCoreSupport/WebChromeClient.h:
2921
2922 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2923
2924         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
2925         https://bugs.webkit.org/show_bug.cgi?id=180926
2926
2927         Reviewed by Tim Horton.
2928
2929         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
2930         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
2931
2932         * WebCoreSupport/WebFrameLoaderClient.cpp:
2933         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
2934         (WebFrameLoaderClient::pageID const): Ditto.
2935
2936 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2937
2938         Remove unnecessary boolean result of start() functions
2939         https://bugs.webkit.org/show_bug.cgi?id=180856
2940
2941         Reviewed by Darin Adler.
2942
2943         It always returns true.
2944
2945         * WebDownloadCurl.cpp:
2946         (WebDownload::start):
2947
2948 2017-12-14  John Wilander  <wilander@apple.com>
2949
2950         Storage Access API: Implement frame-specific access in the document.cookie layer
2951         https://bugs.webkit.org/show_bug.cgi?id=180682
2952         <rdar://problem/35982257>
2953
2954         Reviewed by Alex Christensen.
2955
2956         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
2957         CookiesStrategy::cookieRequestHeaderFieldValue(), and
2958         CookiesStrategy::getRawCookies() now take optional parameters for
2959         frameID and pageID to allow frame-specific scoping of cookies.
2960
2961         This change makes the return values of FrameLoaderClient::frameID()
2962         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
2963         WebCore can call those getters and get the right return values in
2964         WebKit and std:nullopt in WebKitLegacy.
2965
2966         * WebCoreSupport/WebFrameLoaderClient.cpp:
2967         (WebFrameLoaderClient::pageID const):
2968         (WebFrameLoaderClient::frameID const):
2969             Now return an optional.
2970         * WebCoreSupport/WebFrameLoaderClient.h:
2971         * WebCoreSupport/WebPlatformStrategies.cpp:
2972         (WebPlatformStrategies::cookiesForDOM):
2973         (WebPlatformStrategies::setCookiesFromDOM):
2974         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2975         (WebPlatformStrategies::getRawCookies):
2976         * WebCoreSupport/WebPlatformStrategies.h:
2977
2978 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2979
2980         [WTF] Thread::create should have Thread::tryCreate
2981         https://bugs.webkit.org/show_bug.cgi?id=180333
2982
2983         Reviewed by Darin Adler.
2984
2985         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
2986         (WKQCA::CVDisplayLink::start):
2987
2988 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2989
2990         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
2991         https://bugs.webkit.org/show_bug.cgi?id=180572
2992
2993         Reviewed by Mark Lam.
2994
2995         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
2996         Also we use Lock instead of Mutex.
2997
2998         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
2999         (WKQCA::CAD3DRenderer::swapChain):
3000         (WKQCA::CAD3DRenderer::renderAndPresent):
3001         (WKQCA::CAD3DRenderer::renderToImage):
3002         (WKQCA::CAD3DRenderer::setDeviceIsLost):
3003         (WKQCA::CAD3DRenderer::renderInternal):
3004         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
3005         * WebKitQuartzCoreAdditions/CAView.cpp:
3006         (WKQCA::CAView::Handle::create):
3007         Return Ref<Handle> instead of RefPtr<>.
3008
3009         (WKQCA::CAView::Handle::lock):
3010         (WKQCA::CAView::Handle::view const):
3011         (WKQCA::CAView::Handle::clear):
3012         (WKQCA::views):
3013         (WKQCA::viewsNeedingUpdate):
3014         (WKQCA::CAView::releaseAllD3DResources):
3015         (WKQCA::CAView::CAView):
3016         (WKQCA::CAView::~CAView):
3017         (WKQCA::CAView::setLayer):
3018         (WKQCA::CAView::update):
3019         (WKQCA::CAView::drawToWindow):
3020         (WKQCA::CAView::drawToWindowInternal):
3021         (WKQCA::CAView::drawToImage):
3022         (WKQCA::CAView::willDraw):
3023         (WKQCA::CAView::drawIntoDC):
3024         (WKQCA::CAView::setShouldInvertColors):
3025         (WKQCA::CAView::scheduleNextDraw):
3026         (WKQCA::CAView::displayLinkReachedCAMediaTime):
3027         (WKQCA::CAView::contextDidChange):
3028         (WKQCA::CAView::updateSoon):
3029         (WKQCA::CAView::updateViewsNow):
3030         (WKQCA::CAView::d3dDevice9):
3031         (WKQCA::CAView::Handle::mutex): Deleted.
3032         (WKQCA::globalStateMutex): Deleted.
3033         (): Deleted.
3034         * WebKitQuartzCoreAdditions/CAView.h:
3035
3036 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
3037
3038         Use StaticLock instead of NeverDestroyed<Lock>
3039         https://bugs.webkit.org/show_bug.cgi?id=180507
3040
3041         Reviewed by Saam Barati.
3042
3043         * WebLocalizableStrings.cpp:
3044         (findCachedString):
3045         (cacheString):
3046         (mainBundleLocStrings): Deleted.
3047         (frameworkLocStringsMutex): Deleted.
3048
3049 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
3050
3051         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
3052         https://bugs.webkit.org/show_bug.cgi?id=180431
3053         <rdar://problem/34531264>
3054
3055         Reviewed by Simon Fraser.
3056
3057         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
3058         'override' to make sure this doesn't break in the future.
3059
3060         * WebView.cpp:
3061         (WebView::notifyAnimationStarted):
3062         (WebView::paintContents):
3063         * WebView.h:
3064
3065 2017-11-23  Darin Adler  <darin@apple.com>
3066
3067         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
3068         https://bugs.webkit.org/show_bug.cgi?id=179981
3069
3070         Reviewed by Sam Weinig.
3071
3072         * WebView.cpp:
3073         (WebView::searchFor): Use |= instead of | to build FindOptions.
3074         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
3075         (WebView::findString): Create FindOptions with |=; the old code just passed a
3076         WebKit FindOptions through without converting to WebCore::FindOptions.
3077
3078 2017-11-23  Darin Adler  <darin@apple.com>
3079
3080         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
3081         https://bugs.webkit.org/show_bug.cgi?id=179907
3082
3083         Reviewed by Sam Weinig.
3084
3085         * Plugins/PluginDatabaseWin.cpp:
3086         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
3087         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
3088         * WebDownloadCFNet.cpp:
3089         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
3090
3091         * WebView.cpp:
3092         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
3093         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
3094         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
3095         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
3096         the code does not cause any change in behavior.
3097
3098 2017-11-22  Ali Juma  <ajuma@chromium.org>
3099
3100         Implement VisualViewport API attributes
3101         https://bugs.webkit.org/show_bug.cgi?id=179385
3102
3103         Reviewed by Frédéric Wang.
3104
3105         Add a VisualViewportAPI preference.
3106
3107         * Interfaces/IWebPreferencesPrivate.idl:
3108         * WebPreferenceKeysPrivate.h:
3109         * WebPreferences.cpp:
3110         (WebPreferences::initializeDefaultSettings):
3111         (WebPreferences::visualViewportAPIEnabled):
3112         (WebPreferences::setVisualViewportAPIEnabled):
3113         * WebPreferences.h:
3114         * WebView.cpp:
3115         (WebView::notifyPreferencesChanged):
3116
3117 2017-11-22  Commit Queue  <commit-queue@webkit.org>
3118
3119         Unreviewed, rolling out r225093.
3120         https://bugs.webkit.org/show_bug.cgi?id=179938
3121
3122         Compilation failed on WinCairo 64-bit Release (Requested by
3123         fredw on #webkit).
3124
3125         Reverted changeset:
3126
3127         "Implement VisualViewport API attributes"
3128         https://bugs.webkit.org/show_bug.cgi?id=179385
3129         https://trac.webkit.org/changeset/225093
3130
3131 2017-11-21  Ali Juma  <ajuma@chromium.org>
3132
3133         Implement VisualViewport API attributes
3134         https://bugs.webkit.org/show_bug.cgi?id=179385
3135
3136         Reviewed by Frédéric Wang.
3137
3138         Add a VisualViewportAPI preference.
3139
3140         * Interfaces/IWebPreferencesPrivate.idl:
3141         * WebPreferenceKeysPrivate.h:
3142         * WebPreferences.cpp:
3143         (WebPreferences::initializeDefaultSettings):
3144         (WebPreferences::visualViewportAPIEnabled):
3145         (WebPreferences::setVisualViewportAPIEnabled):
3146         * WebPreferences.h:
3147         * WebView.cpp:
3148         (WebView::notifyPreferencesChanged):
3149
3150 2017-11-14  Alex Christensen  <achristensen@webkit.org>
3151
3152         Clean up old URL parser remnants
3153         https://bugs.webkit.org/show_bug.cgi?id=179573
3154
3155         Reviewed by Darin Adler.
3156
3157         * WebCoreSupport/WebContextMenuClient.cpp:
3158         (WebContextMenuClient::searchWithGoogle):
3159         Use https if we do end up searching with google.
3160
3161 2017-11-12  Darin Adler  <darin@apple.com>
3162
3163         More is<> and downcast<>, less static_cast<>
3164         https://bugs.webkit.org/show_bug.cgi?id=179600
3165
3166         Reviewed by Chris Dumez.
3167
3168         * WebView.cpp:
3169         (WebView::handleEditingKeyboardEvent): Use downcast.
3170
3171 2017-11-09  Christopher Reid  <chris.reid@sony.com>
3172
3173         Use enum classes within FileSystem
3174         https://bugs.webkit.org/show_bug.cgi?id=175172
3175
3176         Reviewed by Darin Adler.
3177
3178         * Plugins/PluginDatabase.cpp:
3179
3180 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
3181
3182         [Win] Add WebKitQuartzCoreAdditions library.
3183         https://bugs.webkit.org/show_bug.cgi?id=179331
3184
3185         Reviewed by Alex Christensen.
3186
3187         * WebKitQuartzCoreAdditions: Added.
3188         * WebKitQuartzCoreAdditions/API: Added.
3189         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
3190         (toImage):
3191         (WKCACFImageGetWidth):
3192         (WKCACFImageGetHeight):
3193         (WKCACFImageCopyFileMapping):
3194         (WKCACFImageCreateWithImage):
3195         (WKCACFImageFinalize):
3196         (WKCACFImageCopyFormattingDescription):
3197         (WKCACFImageCopyDebugDescription):
3198         (WKCACFImageGetTypeID):
3199         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
3200         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
3201         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
3202         (toView):
3203         (toImpl):
3204         (WKCACFViewCreate):
3205         (WKCACFViewSetLayer):
3206         (WKCACFViewUpdate):
3207         (WKCACFViewFlushContext):
3208         (WKCACFViewInvalidateRects):
3209         (WKCACFViewCanDraw):
3210         (WKCACFViewDraw):
3211         (WKCACFViewCopyDrawnImage):
3212         (WKCACFViewDrawIntoDC):
3213         (contextDidChangeCallback):
3214         (WKCACFViewSetContextDidChangeCallback):
3215         (WKCACFViewGetLastCommitTime):
3216         (WKCACFViewSetContextUserData):
3217         (WKCACFViewGetContext):
3218         (WKCACFViewFinalize):
3219         (WKCACFViewCopyFormattingDescription):
3220         (WKCACFViewCopyDebugDescription):
3221         (WKCACFViewGetTypeID):
3222         (WKCACFViewSetShouldInvertColors):
3223         (WKCACFViewGetD3DDevice9):
3224         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
3225         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
3226         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
3227         (WKQCA::dllInstance):
3228         (DllMain):
3229         (WKCACFShutDown):
3230         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
3231         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
3232         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
3233         (WKQCA::d3d):
3234         (WKQCA::initialPresentationParameters):
3235         (WKQCA::CAD3DRenderer::shared):
3236         (WKQCA::CAD3DRenderer::CAD3DRenderer):
3237         (WKQCA::CAD3DRenderer::swapChain):
3238         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
3239         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
3240         (WKQCA::CAD3DRenderer::initialize):
3241         (WKQCA::D3DMatrixOrthoOffCenterRH):
3242         (WKQCA::prepareDevice):
3243         (WKQCA::updateBounds):
3244         (WKQCA::CAD3DRenderer::renderAndPresent):
3245         (WKQCA::CAD3DRenderer::renderToImage):
3246         (WKQCA::CAD3DRenderer::setDeviceIsLost):
3247         (WKQCA::CAD3DRenderer::renderInternal):
3248         (WKQCA::CAD3DRenderer::postProcess):
3249         (WKQCA::CAD3DRenderer::resetD3DDevice):
3250         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
3251         (WKQCA::CAD3DRenderer::release):
3252         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
3253         (WKQCA::D3DPostProcessingContext::sceneTexture const):
3254         (WKQCA::D3DPostProcessingContext::overlayQuad const):
3255         (WKQCA::CAD3DRenderer::d3dDevice9 const):
3256         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
3257         (WKQCA::CAView::Handle::create):
3258         (WKQCA::CAView::Handle::~Handle):
3259         (WKQCA::CAView::Handle::mutex):
3260         (WKQCA::CAView::Handle::view const):
3261         (WKQCA::CAView::Handle::clear):
3262         (WKQCA::CAView::Handle::Handle):
3263         (WKQCA::globalStateMutex):
3264         (WKQCA::registerMessageWindowClass):
3265         (WKQCA::createMessageWindow):
3266         (WKQCA::CAView::releaseAllD3DResources):
3267         (WKQCA::CAView::CAView):
3268         (WKQCA::CAView::~CAView):
3269         (WKQCA::CAView::create):
3270         (WKQCA::CAView::setContextDidChangeCallback):
3271         (WKQCA::CAView::setLayer):
3272         (WKQCA::CAView::update):
3273         (WKQCA::CAView::invalidateRects):
3274         (WKQCA::CAView::drawToWindow):
3275         (WKQCA::CAView::drawToWindowInternal):
3276         (WKQCA::CAView::drawToImage):
3277         (WKQCA::CAView::willDraw):
3278         (WKQCA::CAView::didDraw):
3279         (WKQCA::CAView::drawIntoDC):
3280         (WKQCA::CAView::setShouldInvertColors):
3281         (WKQCA::CAView::scheduleNextDraw):
3282         (WKQCA::CAView::displayLinkReachedCAMediaTime):
3283         (WKQCA::CAView::contextDidChangeCallback):
3284         (WKQCA::CAView::contextDidChange):
3285         (WKQCA::CAView::updateSoon):
3286         (WKQCA::CAView::updateViewsNow):
3287         (WKQCA::CAView::d3dDevice9):
3288         * WebKitQuartzCoreAdditions/CAView.h: Added.
3289         (WKQCA::CAView::context const):
3290         (WKQCA::CAView::canDraw const):
3291         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
3292         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
3293         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
3294         (WKQCA::CVDisplayLink::CVDisplayLink):
3295         (WKQCA::CVDisplayLink::~CVDisplayLink):
3296         (WKQCA::CVDisplayLink::create):
3297         (WKQCA::CVDisplayLink::start):
3298         (WKQCA::CVDisplayLink::stop):
3299         (WKQCA::CVDisplayLink::setPaused):
3300         (WKQCA::CVDisplayLink::runIOThread):
3301         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
3302         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
3303         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
3304         * WebKitQuartzCoreAdditions/Image.cpp: Added.
3305         (WKQCA::numBytesForSize):
3306         (WKQCA::Image::create):
3307         (WKQCA::Image::Image):
3308         (WKQCA::Image::~Image):
3309         (WKQCA::bitmapInfo):
3310         (WKQCA::Image::createDIB const):
3311         (WKQCA::Image::copyFileMapping):
3312         * WebKitQuartzCoreAdditions/Image.h: Added.
3313         (WKQCA::Image::size const):
3314         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
3315         (WKQCA::getBackBufferRectAsRenderTarget):
3316         (WKQCA::getSystemMemoryCopy):
3317         (WKQCA::copyRectToBitmap):
3318         (WKQCA::getImageCopy):
3319         (WKQCA::getBackBufferRectAsImage):
3320         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
3321         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
3322         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
3323         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
3324         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
3325
3326 2017-11-06  Christopher Reid  <chris.reid@sony.com>
3327
3328         Use enum classes within FileSystem
3329         https://bugs.webkit.org/show_bug.cgi?id=175172
3330
3331         Reviewed by Myles C. Maxfield.
3332
3333         * Plugins/PluginDatabase.cpp:
3334
3335 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
3336
3337         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
3338         https://bugs.webkit.org/show_bug.cgi?id=178333
3339
3340         Reviewed by Darin Adler.
3341
3342         * WebCoreSupport/WebFrameLoaderClient.cpp:
3343         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
3344
3345 2017-11-02  Alex Christensen  <achristensen@webkit.org>
3346
3347         Use CompletionHandlers for redirects
3348         https://bugs.webkit.org/show_bug.cgi?id=179163
3349
3350         Reviewed by Tim Horton.
3351
3352         * Plugins/PluginStream.cpp:
3353         (WebCore::PluginStream::willSendRequest):
3354         * Plugins/PluginStream.h:
3355         (WebCore::PluginStreamClient::~PluginStreamClient):
3356         (WebCore::PluginStreamClient::streamDidFinishLoading):
3357         (WebCore::PluginStream::create):
3358         (WebCore::PluginStream::setLoadManually):
3359
3360 2017-11-02  Christopher Reid  <chris.reid@sony.com>
3361
3362         Add a FileSystem namespace to FileSystem.cpp
3363         https://bugs.webkit.org/show_bug.cgi?id=179063
3364
3365         Reviewed by Darin Adler.
3366
3367         * Plugins/PluginDatabase.cpp:
3368         * Plugins/PluginPackage.cpp:
3369         * Plugins/PluginStream.cpp:
3370         * Plugins/PluginStream.h:
3371         * WebApplicationCache.cpp:
3372         * WebDatabaseManager.cpp:
3373         * WebDownloadCurl.cpp:
3374         * WebPreferences.cpp:
3375         * WebView.cpp:
3376
3377 2017-10-31  Alex Christensen  <achristensen@webkit.org>
3378
3379         Fix Windows build after r224260
3380
3381         * WebView.cpp:
3382         (WebView::gesture):
3383
3384 2017-10-28  Zalan Bujtas  <zalan@apple.com>
3385
3386         [FrameView::layout cleanup] Move core layout logic to a separate class.
3387         https://bugs.webkit.org/show_bug.cgi?id=178771
3388         <rdar://problem/35166542>
3389
3390         Reviewed by Simon Fraser.
3391
3392         Move layout code out from FrameView to LayoutContext.
3393
3394         * WebFrame.cpp:
3395         (WebFrame::layout):
3396
3397 2017-10-26  Alex Christensen  <achristensen@webkit.org>
3398
3399         Fix Windows build
3400         https://bugs.webkit.org/show_bug.cgi?id=178892
3401
3402         * AccessibleBase.cpp:
3403         (MSAARole):
3404
3405 2017-10-26  Alex Christensen  <achristensen@webkit.org>
3406
3407         Fix Windows build
3408         https://bugs.webkit.org/show_bug.cgi?id=178892
3409
3410         * AccessibleBase.cpp:
3411         (AccessibleBase::state const):
3412         (MSAARole):
3413
3414 2017-10-25  Youenn Fablet  <youenn@apple.com>
3415
3416         Enable ServiceWorker to fetch resources
3417         https://bugs.webkit.org/show_bug.cgi?id=178673
3418
3419         Reviewed by Brady Eidson.
3420
3421         Added implementation to the new getters.
3422         They are noop in the context of WK1.
3423
3424         * WebCoreSupport/WebFrameLoaderClient.cpp:
3425         (WebFrameLoaderClient::pageID const):
3426         (WebFrameLoaderClient::frameID const):
3427         (WebFrameLoaderClient::sessionID const):
3428         * WebCoreSupport/WebFrameLoaderClient.h:
3429
3430 2017-10-20  Antoine Quint  <graouts@apple.com>
3431
3432         [Web Animations] Provide basic timeline and animation interfaces
3433         https://bugs.webkit.org/show_bug.cgi?id=178526
3434
3435         Reviewed by Dean Jackson.
3436
3437         Remove the WEB_ANIMATIONS compile-time flag.
3438
3439         * WebView.cpp:
3440         (WebView::notifyPreferencesChanged):
3441
3442 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3443
3444         [Curl] Clean up old style code in old curl files.
3445         https://bugs.webkit.org/show_bug.cgi?id=178569
3446
3447         Reviewed by Ryosuke Niwa.
3448
3449         * WebCache.cpp:
3450         (WebCache::cacheFolder):
3451         (WebCache::setCacheFolder):
3452         * WebView.cpp:
3453         (WebView::setCacheModel):
3454
3455 2017-10-19  Sam Weinig  <sam@webkit.org>
3456
3457         [Settings] Move global settings into their own file
3458         https://bugs.webkit.org/show_bug.cgi?id=178512
3459
3460         Reviewed by Darin Adler.
3461
3462         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
3463
3464         * WebView.cpp:
3465         (WebView::initWithFrame):
3466
3467 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
3468
3469         Replace some stack raw pointers with RefPtrs within WebCore/html
3470         https://bugs.webkit.org/show_bug.cgi?id=178201
3471         <rdar://problem/34841692>
3472
3473         Reviewed by Ryosuke Niwa.
3474
3475         * WebView.cpp:
3476         (WebView::handleEditingKeyboardEvent):
3477         Change the type of node as toNode() is changed to return RefPtr.
3478
3479 2017-10-16  Sam Weinig  <sam@webkit.org>
3480
3481         [Settings] Remove all custom code from Settings.h/cpp
3482         https://bugs.webkit.org/show_bug.cgi?id=178330
3483
3484         Reviewed by Simon Fraser.
3485
3486         * WebView.cpp:
3487         (WebView::notifyPreferencesChanged):
3488             
3489             Update for naming changes of FrameFlattening now that it is an enum class.
3490
3491 2017-10-11  Chris Dumez  <cdumez@apple.com>
3492
3493         Modernize Geolocation code
3494         https://bugs.webkit.org/show_bug.cgi?id=178148
3495
3496         Reviewed by Ryosuke Niwa.
3497
3498         * WebCoreSupport/WebGeolocationClient.cpp:
3499         (WebGeolocationClient::lastPosition):
3500         * WebCoreSupport/WebGeolocationClient.h:
3501         * WebGeolocationPosition.cpp:
3502         (WebGeolocationPosition::initWithTimestamp):
3503         (core):
3504         * WebGeolocationPosition.h:
3505         (WebGeolocationPosition::impl const):
3506
3507 2017-10-05  Chris Dumez  <cdumez@apple.com>
3508
3509         Drop unused parameters for CookiesStrategy::cookiesEnabled()
3510         https://bugs.webkit.org/show_bug.cgi?id=177957
3511
3512         Reviewed by Alex Christensen.
3513
3514         * WebCoreSupport/WebPlatformStrategies.cpp:
3515         (WebPlatformStrategies::cookiesEnabled):
3516         * WebCoreSupport/WebPlatformStrategies.h:
3517
3518 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3519
3520         [Curl] Reimplement CurlDownload with CurlRequest
3521         https://bugs.webkit.org/show_bug.cgi?id=177779
3522
3523         Reviewed by Alex Christensen.
3524
3525         * WebDownload.h:
3526         * WebDownloadCurl.cpp:
3527         (WebDownload::init):
3528         (WebDownload::didReceiveResponse):
3529
3530 2017-09-29  Chris Dumez  <cdumez@apple.com>
3531
3532         Split some logic out of VisitedLinkStore and make it reusable
3533         https://bugs.webkit.org/show_bug.cgi?id=177575
3534
3535         Reviewed by Alex Christensen.
3536
3537         * WebCoreSupport/WebVisitedLinkStore.cpp:
3538         (WebVisitedLinkStore::addVisitedLink):
3539         (WebVisitedLinkStore::isLinkVisited):
3540         (WebVisitedLinkStore::addVisitedLinkHash):
3541         * WebCoreSupport/WebVisitedLinkStore.h:
3542
3543 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3544
3545         Make PolicyAction an encodable enum class
3546         https://bugs.webkit.org/show_bug.cgi?id=177480
3547
3548         Reviewed by Antti Koivisto.
3549
3550         * WebCoreSupport/WebFrameLoaderClient.cpp: