Add a storage limit for IndexedDB
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2
3         Add a storage limit for IndexedDB
4         https://bugs.webkit.org/show_bug.cgi?id=190598
5         <rdar://problem/44654715>
6
7         Reviewed by Chris Dumez.
8
9         * Interfaces/IWebDatabaseManager.idl:
10         * WebDatabaseManager.cpp:
11         (WebDatabaseManager::setIDBPerOriginQuota):
12         * WebDatabaseManager.h:
13
14 2018-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
15
16         [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
17         https://bugs.webkit.org/show_bug.cgi?id=191105
18
19         Reviewed by Brent Fulgham.
20
21         * DOMHTMLClasses.h:
22         (DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
23         instead of own setNodeValue.
24
25 2018-10-25  Antoine Quint  <graouts@apple.com>
26
27         [Web Animations] Turn Web Animations CSS Integration off by default
28         https://bugs.webkit.org/show_bug.cgi?id=190901
29
30         Reviewed by Dean Jackson.
31
32         * WebPreferences.cpp:
33         (WebPreferences::initializeDefaultSettings):
34
35 2018-10-21  Fujii Hironori  <Hironori.Fujii@sony.com>
36
37         [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
38         https://bugs.webkit.org/show_bug.cgi?id=190744
39
40         Reviewed by Alex Christensen.
41
42         clang-cl reports compilation warnings for inconsistent 'override'
43         keyword usage.
44
45         WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
46         This can't be marked 'override' if !USE(CA).
47
48         * WebView.cpp:
49         (WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).
50         * WebView.h: Marked all overriding member function declarations of WebView 'override'.
51         Declare flushPendingGraphicsLayerChanges only if USE(CA).
52
53 2018-10-18  Alex Christensen  <achristensen@webkit.org>
54
55         Clean up FrameLoader two-state enums
56         https://bugs.webkit.org/show_bug.cgi?id=190731
57
58         Reviewed by Chris Dumez.
59
60         * WebCoreSupport/WebFrameLoaderClient.cpp:
61         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
62         * WebCoreSupport/WebFrameLoaderClient.h:
63
64 2018-10-17  Alex Christensen  <achristensen@webkit.org>
65
66         BackForwardClient needs to be able to support UIProcess-only back/forward lists
67         https://bugs.webkit.org/show_bug.cgi?id=190675
68
69         Reviewed by Chris Dumez.
70
71         * BackForwardList.cpp:
72         (BackForwardList::backItem):
73         (BackForwardList::currentItem):
74         (BackForwardList::forwardItem):
75         (BackForwardList::backListCount const):
76         (BackForwardList::forwardListCount const):
77         (BackForwardList::itemAtIndex):
78         * BackForwardList.h:
79
80 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
81
82         Unreviewed attempt to fix the Windows build after r237112.
83
84         * Plugins/PluginView.cpp:
85         (WebCore::PluginView::performRequest):
86
87 2018-10-16  Alex Christensen  <achristensen@webkit.org>
88
89         Replace HistoryItem* with HistoryItem& where possible
90         https://bugs.webkit.org/show_bug.cgi?id=190617
91
92         Reviewed by Chris Dumez.
93
94         * BackForwardList.cpp:
95         (BackForwardList::goToItem):
96         * BackForwardList.h:
97         * WebBackForwardList.cpp:
98         (WebBackForwardList::goToItem):
99
100 2018-10-15  Alex Christensen  <achristensen@webkit.org>
101
102         Fix Windows build.
103
104         * WebView.cpp:
105         (WebView::loadBackForwardListFromOtherView):
106
107 2018-10-15  Alex Christensen  <achristensen@webkit.org>
108
109         Fix WinCairo build.
110
111         * WebView.cpp:
112         (WebView::backForwardList):
113
114 2018-10-15  Alex Christensen  <achristensen@webkit.org>
115
116         Modernize BackForwardClient.h
117         https://bugs.webkit.org/show_bug.cgi?id=190610
118
119         Reviewed by Chris Dumez.
120
121         * BackForwardList.cpp:
122         (BackForwardList::backListCount const):
123         (BackForwardList::forwardListCount const):
124         (BackForwardList::backListCount): Deleted.
125         (BackForwardList::forwardListCount): Deleted.
126         * BackForwardList.h:
127         * WebView.cpp:
128         (WebView::initWithFrame):
129         (WebView::backForwardList):
130
131 2018-10-15  Alex Christensen  <achristensen@webkit.org>
132
133         Remove unused WebView._globalHistoryItem
134         https://bugs.webkit.org/show_bug.cgi?id=190601
135
136         Reviewed by Chris Dumez.
137
138         * WebCoreSupport/WebFrameLoaderClient.cpp:
139         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
140         * WebCoreSupport/WebFrameLoaderClient.h:
141         * WebView.cpp:
142         (WebView::globalHistoryItem):
143         (WebView::setGlobalHistoryItem): Deleted.
144         * WebView.h:
145
146 2018-10-15  Alex Christensen  <achristensen@webkit.org>
147
148         Remove unused parameters from FrameLoaderClient::createFrame
149         https://bugs.webkit.org/show_bug.cgi?id=190587
150
151         Reviewed by Chris Dumez.
152
153         * WebCoreSupport/WebFrameLoaderClient.cpp:
154         (WebFrameLoaderClient::createFrame):
155         * WebCoreSupport/WebFrameLoaderClient.h:
156
157 2018-10-15  Chris Dumez  <cdumez@apple.com>
158
159         Unreviewed Windows build fix after r237112.
160
161         * Plugins/PluginView.cpp:
162         (WebCore::PluginView::performRequest):
163         (WebCore::PluginView::load):
164
165 2018-10-15  Alex Christensen  <achristensen@webkit.org>
166
167         Remove InjectedBundle processing of back/forward lists
168         https://bugs.webkit.org/show_bug.cgi?id=190459
169
170         Reviewed by Chris Dumez.
171
172         * WebCoreSupport/WebFrameLoaderClient.cpp:
173         (WebFrameLoaderClient::shouldGoToHistoryItem const):
174         * WebCoreSupport/WebFrameLoaderClient.h:
175
176 2018-10-02  Alex Christensen  <achristensen@webkit.org>
177
178         Remove ParsedURLString
179         https://bugs.webkit.org/show_bug.cgi?id=190154
180
181         Reviewed by Chris Dumez.
182
183         * WebDownloadCurl.cpp:
184         (WebDownload::initWithRequest):
185         * WebURLResponse.cpp:
186         (WebURLResponse::createInstance):
187
188 2018-09-28  Chris Dumez  <cdumez@apple.com>
189
190         Drop support for cross-origin-window-policy header
191         https://bugs.webkit.org/show_bug.cgi?id=190081
192
193         Reviewed by Ryosuke Niwa.
194
195         * WebPreferenceKeysPrivate.h:
196         * WebPreferences.cpp:
197         (WebPreferences::initializeDefaultSettings):
198         (WebPreferences::crossOriginWindowPolicySupportEnabled):
199         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
200         * WebView.cpp:
201         (WebView::notifyPreferencesChanged):
202
203 2018-09-27  Antoine Quint  <graouts@apple.com>
204
205         [Web Animations] Turn Web Animations with CSS integration on
206         https://bugs.webkit.org/show_bug.cgi?id=184819
207         <rdar://problem/39597337>
208
209         Reviewed by Dean Jackson.
210
211         * WebPreferences.cpp:
212         (WebPreferences::initializeDefaultSettings):
213
214 2018-09-21  Alex Christensen  <achristensen@webkit.org>
215
216         Use a Variant for FormDataElement
217         https://bugs.webkit.org/show_bug.cgi?id=189777
218
219         Reviewed by Chris Dumez.
220
221         * WebMutableURLRequest.cpp:
222         (WebMutableURLRequest::setHTTPBody):
223
224 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
225
226         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
227         https://bugs.webkit.org/show_bug.cgi?id=189612
228
229         Reviewed by Alex Christensen.
230
231         Non-trivial types can't be used as aruguments of LOG_ERROR and
232         ASSERT_WITH_MESSAGE.
233
234         * DefaultPolicyDelegate.cpp:
235         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
236         static_cast<BSTR> to convert BString.
237         * WebLocalizableStrings.cpp:
238         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
239         char* by using 'key.utf8().data()'.
240
241 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
242
243         Unreviewed, rolling out r235953.
244
245         Caused layout test crashes under GuardMalloc.
246
247         Reverted changeset:
248
249         "Make GraphicsLayers ref-counted, so their tree can persist
250         when disconnected from RenderLayerBackings"
251         https://bugs.webkit.org/show_bug.cgi?id=189521
252         https://trac.webkit.org/changeset/235953
253
254 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
255
256         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
257         https://bugs.webkit.org/show_bug.cgi?id=189538
258
259         Reviewed by Per Arne Vollan.
260
261         * WebPreferences.cpp:
262         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
263         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
264         Apply static_cast to the result of OR-ed CFPropertyListFormat.
265         (WebPreferences::screenFontSubstitutionEnabled):
266         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
267
268 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
269
270         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
271         https://bugs.webkit.org/show_bug.cgi?id=189539
272
273         Reviewed by Alex Christensen.
274
275         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
276         * WebCoreSupport/WebInspectorClient.cpp:
277         (WebInspectorWndProc): Ditto.
278         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
279         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
280
281 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
282
283         Refactor WebCore::EditAction to be an 8-bit enum class
284         https://bugs.webkit.org/show_bug.cgi?id=189383
285
286         Reviewed by Dan Bernstein.
287
288         * WebCoreSupport/WebEditorClient.cpp:
289         (undoNameForEditAction):
290
291 2018-09-04  Frederic Wang  <fwang@igalia.com>
292
293         Add basic support for ScrollIntoViewOptions
294         https://bugs.webkit.org/show_bug.cgi?id=189258
295
296         Reviewed by Simon Fraser.
297
298         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
299         can build despite the new scrollIntoView function.
300
301 2018-08-31  Chris Dumez  <cdumez@apple.com>
302
303         Unreviewed Windows build fix after r235562.
304
305         * WebCoreSupport/WebFrameLoaderClient.cpp:
306         (WebFrameLoaderClient::dispatchWillSubmitForm):
307
308 2018-08-31  Chris Dumez  <cdumez@apple.com>
309
310         Assertion hit in ~CompletionHandler() from ~WebFrame()
311         https://bugs.webkit.org/show_bug.cgi?id=189199
312         <rdar://problem/42657233>
313
314         Reviewed by Youenn Fablet.
315
316         * WebCoreSupport/WebFrameLoaderClient.cpp:
317         (WebFrameLoaderClient::dispatchWillSubmitForm):
318         * WebCoreSupport/WebFrameLoaderClient.h:
319
320 2018-08-31  Frederic Wang  <fwang@igalia.com>
321
322         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
323         https://bugs.webkit.org/show_bug.cgi?id=182053
324
325         Reviewed by Simon Fraser.
326
327         Add developer flag to use standard behavior for scrolling* attributes.
328
329         * Interfaces/IWebPreferencesPrivate.idl:
330         * WebPreferenceKeysPrivate.h:
331         * WebPreferences.cpp:
332         (WebPreferences::initializeDefaultSettings):
333         (WebPreferences::CSSOMViewScrollingAPIEnabled):
334         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
335         * WebPreferences.h:
336         * WebView.cpp:
337         (WebView::notifyPreferencesChanged):
338
339 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
340
341         [CMake] Replace AVFoundationSupport.py using CMake
342         https://bugs.webkit.org/show_bug.cgi?id=182891
343
344         Reviewed by Per Arne Vollan.
345
346         Remove references to the config.h contained in WebCore as it should
347         not be accessible from outside of WebCore.
348
349         * WebKitPrefix.h:
350
351 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
352
353         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
354         https://bugs.webkit.org/show_bug.cgi?id=188496
355         <rdar://problem/43216836>
356
357         Reviewed by Tim Horton.
358
359         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
360         header directly.
361
362         * WebCoreSupport/WebDragClient.cpp:
363
364 2018-08-17  Alex Christensen  <achristensen@webkit.org>
365
366         Add some plumbing for safe browsing
367         https://bugs.webkit.org/show_bug.cgi?id=188709
368
369         Reviewed by Tim Horton.
370
371         * WebCoreSupport/WebFrameLoaderClient.cpp:
372         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
373         * WebCoreSupport/WebFrameLoaderClient.h:
374
375 2018-08-02  David Fenton  <david_fenton@apple.com>
376
377         Unreviewed, rolling out r234489.
378
379         Caused 50+ crashes and 60+ API failures on iOS
380
381         Reverted changeset:
382
383         "[WTF] Rename String::format to String::deprecatedFormat"
384         https://bugs.webkit.org/show_bug.cgi?id=188191
385         https://trac.webkit.org/changeset/234489
386
387 2018-08-01  Tomas Popela  <tpopela@redhat.com>
388
389         [WTF] Rename String::format to String::deprecatedFormat
390         https://bugs.webkit.org/show_bug.cgi?id=188191
391
392         Reviewed by Darin Adler.
393
394         It should be replaced with string concatenation.
395
396         * FullscreenVideoController.cpp:
397         (timeToString):
398         * WebView.cpp:
399         (webKitVersionString):
400
401 2018-07-30  Rob Buis  <rbuis@igalia.com>
402
403         https://bugs.webkit.org/show_bug.cgi?id=188137
404         Merge PlatformCookieJar functions into NetworkStorageSession
405
406         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
407
408         Reviewed by Alex Christensen.
409
410         * WebCoreSupport/WebPlatformStrategies.cpp:
411         (WebPlatformStrategies::cookiesForDOM):
412         (WebPlatformStrategies::setCookiesFromDOM):
413         (WebPlatformStrategies::cookiesEnabled):
414         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
415         (WebPlatformStrategies::getRawCookies):
416         (WebPlatformStrategies::deleteCookie):
417         * WebPreferences.cpp:
418         (WebPreferences::clearNetworkLoaderSession):
419
420 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
421
422         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
423         https://bugs.webkit.org/show_bug.cgi?id=187963
424
425         Reviewed by Alex Christensen.
426
427         * Plugins/PluginPackageWin.cpp:
428         (WebCore::PluginPackage::fetchInfo):
429         Update split/splitAllowingEmptyEntries usage.
430
431 2018-07-18  Antoine Quint  <graouts@apple.com>
432
433         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
434         https://bugs.webkit.org/show_bug.cgi?id=187722
435
436         Reviewed by Myles Maxfield.
437
438         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
439
440         * DOMCoreClasses.cpp:
441         (DOMElement::font):
442
443 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
444
445         Disable cross-origin-window-policy by default
446         https://bugs.webkit.org/show_bug.cgi?id=187509
447
448         Reviewed by Chris Dumez.
449
450         * WebPreferences.cpp:
451         (WebPreferences::initializeDefaultSettings):
452
453 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
454
455         [WTF] Add user-defined literal for ASCIILiteral
456         https://bugs.webkit.org/show_bug.cgi?id=186839
457
458         Reviewed by Darin Adler.
459
460         * Plugins/PluginStream.cpp:
461         (WebCore::PluginStream::startStream):
462         * WebCoreSupport/WebContextMenuClient.cpp:
463         (WebContextMenuClient::searchWithGoogle):
464
465 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
466
467         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
468         https://bugs.webkit.org/show_bug.cgi?id=186623
469
470         Reviewed by Youenn Fablet.
471
472         * WebCoreSupport/WebPluginInfoProvider.cpp:
473         (WebPluginInfoProvider::pluginInfo):
474         (WebPluginInfoProvider::webVisiblePluginInfo):
475         * WebCoreSupport/WebPluginInfoProvider.h:
476
477 2018-06-13  Chris Dumez  <cdumez@apple.com>
478
479         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
480         https://bugs.webkit.org/show_bug.cgi?id=186545
481
482         Reviewed by Brady Eidson.
483
484         Update client delegate now that parameter type has changed.
485
486         * WebCoreSupport/WebFrameLoaderClient.cpp:
487         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
488         * WebCoreSupport/WebFrameLoaderClient.h:
489
490 2018-06-11  Chris Dumez  <cdumez@apple.com>
491
492         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
493         https://bugs.webkit.org/show_bug.cgi?id=186441
494
495         Reviewed by Brady Eidson.
496
497         Rename existing flag to something a bit more generic, now that it is used for
498         more things than bypassing the navigation policy check.
499
500         * WebView.cpp:
501         (WebView::goToBackForwardItem):
502         (WebView::loadBackForwardListFromOtherView):
503
504 2018-06-04  Chris Dumez  <cdumez@apple.com>
505
506         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
507         https://bugs.webkit.org/show_bug.cgi?id=186287
508         <rdar://problem/40783352>
509
510         Reviewed by Youenn Fablet.
511
512         * Interfaces/IWebPreferencesPrivate.idl:
513         * WebPreferenceKeysPrivate.h:
514         * WebPreferences.cpp:
515         (WebPreferences::initializeDefaultSettings):
516         (WebPreferences::crossOriginWindowPolicySupportEnabled):
517         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
518         * WebPreferences.h:
519         * WebView.cpp:
520         (WebView::notifyPreferencesChanged):
521
522 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
523
524         [JSC] Pass VM& parameter as much as possible
525         https://bugs.webkit.org/show_bug.cgi?id=186085
526
527         Reviewed by Saam Barati.
528
529         * Plugins/PluginPackage.cpp:
530         (WebCore::NPN_Invoke):
531
532 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
533
534         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
535         https://bugs.webkit.org/show_bug.cgi?id=186125
536
537         Unreviewed build fix
538
539         * WebActionPropertyBag.cpp:
540         (WebActionPropertyBag::Read):
541         (findMouseEvent): Deleted.
542
543 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
544
545         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
546         https://bugs.webkit.org/show_bug.cgi?id=186027
547
548         Unreviewed build fix
549
550         * WebMutableURLRequest.cpp:
551         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
552         (WebMutableURLRequest::setClientCertificate):
553
554 2018-05-25  Chris Dumez  <cdumez@apple.com>
555
556         Minor ApplicationCacheStorage clean up
557         https://bugs.webkit.org/show_bug.cgi?id=185984
558
559         Reviewed by Youenn Fablet.
560
561         * WebApplicationCache.cpp:
562         (WebApplicationCache::originsWithCache):
563
564 2018-05-24  Chris Dumez  <cdumez@apple.com>
565
566         Reduce copying of FontCascadeDescription objects by moving them around
567         https://bugs.webkit.org/show_bug.cgi?id=185963
568
569         Reviewed by Simon Fraser.
570
571         Reduce copying of FontCascadeDescription objects by moving them around when possible.
572
573         * FullscreenVideoController.cpp:
574         (FullscreenVideoController::draw):
575
576 2018-05-15  Antoine Quint  <graouts@apple.com>
577
578         [Web Animations] Expose Web Animations CSS integration as an experimental feature
579         https://bugs.webkit.org/show_bug.cgi?id=185647
580
581         Reviewed by Dean Jackson.
582
583         Rename the Web Animations CSS integration flag.
584
585         * Interfaces/IWebPreferencesPrivate.idl:
586         * WebPreferenceKeysPrivate.h:
587         * WebPreferences.cpp:
588         (WebPreferences::initializeDefaultSettings):
589         (WebPreferences::webAnimationsCSSIntegrationEnabled):
590         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
591         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
592         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
593         * WebPreferences.h:
594         * WebView.cpp:
595         (WebView::notifyPreferencesChanged):
596
597 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
598
599         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
600         https://bugs.webkit.org/show_bug.cgi?id=185505
601
602         Unreviewed serious crash fix
603
604         Windows port crashes soon since Bug 184996.
605
606         * WebPreferences.cpp:
607         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
608         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
609
610 2018-05-07  Daniel Bates  <dabates@apple.com>
611
612         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
613         https://bugs.webkit.org/show_bug.cgi?id=185170
614
615         Reviewed by Per Arne Vollan.
616
617         * WebCache.cpp:
618         (WebCache::empty):
619
620 2018-04-27  Chris Dumez  <cdumez@apple.com>
621
622         Use WindowProxy instead of DOMWindow in our IDL
623         https://bugs.webkit.org/show_bug.cgi?id=185022
624
625         Reviewed by Sam Weinig.
626
627         * DOMCoreClasses.cpp:
628         (DOMDocument::getComputedStyle):
629
630 2018-04-23  Daniel Bates  <dabates@apple.com>
631
632         Implement Same-Site cookies
633         https://bugs.webkit.org/show_bug.cgi?id=159464
634         <rdar://problem/27196358>
635
636         Reviewed by Brent Fulgham.
637
638         Pass the Same-Site info through the strategy.
639
640         * WebCoreSupport/WebPlatformStrategies.cpp:
641         (WebPlatformStrategies::cookiesForDOM):
642         (WebPlatformStrategies::setCookiesFromDOM):
643         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
644         (WebPlatformStrategies::getRawCookies):
645         * WebCoreSupport/WebPlatformStrategies.h:
646
647 2018-04-23  Daniel Bates  <dabates@apple.com>
648
649         Implement Same-Site cookies
650         https://bugs.webkit.org/show_bug.cgi?id=159464
651         <rdar://problem/27196358>
652
653         Reviewed by Brent Fulgham.
654
655         Pass the Same-Site info through the strategy.
656
657         * WebCoreSupport/WebPlatformStrategies.cpp:
658         (WebPlatformStrategies::cookiesForDOM):
659         (WebPlatformStrategies::setCookiesFromDOM):
660         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
661         (WebPlatformStrategies::getRawCookies):
662         * WebCoreSupport/WebPlatformStrategies.h:
663
664 2018-04-20  Youenn Fablet  <youenn@apple.com>
665
666         Make PluginData cache its web visible plugins
667         https://bugs.webkit.org/show_bug.cgi?id=184421
668
669         Reviewed by Chris Dumez.
670
671         * WebCoreSupport/WebPluginInfoProvider.cpp:
672         (WebPluginInfoProvider::pluginInfo):
673         (WebPluginInfoProvider::webVisiblePluginInfo):
674         * WebCoreSupport/WebPluginInfoProvider.h:
675
676 2018-04-19  Chris Dumez  <cdumez@apple.com>
677
678         Rename JSDOMWindowProxy to JSWindowProxy
679         https://bugs.webkit.org/show_bug.cgi?id=184797
680
681         Reviewed by Sam Weinig.
682
683         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
684
685         * WebFrame.cpp:
686         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
687
688 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
689
690         Unreviewed rollout of r230632. Regression in memory usage.
691
692         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
693
694         * WebPreferences.cpp:
695         (WebPreferences::initializeDefaultSettings):
696
697 2018-04-17  Chris Dumez  <cdumez@apple.com>
698
699         Unreviewed attempt to fix the Windows build after r230721
700
701         * WebCoreSupport/WebFrameLoaderClient.cpp:
702         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
703
704 2018-04-17  Chris Dumez  <cdumez@apple.com>
705
706         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
707         https://bugs.webkit.org/show_bug.cgi?id=184678
708         <rdar://problem/39422122>
709
710         Reviewed by Alex Christensen.
711
712         Add new parameter to dispatchDecidePolicyForNavigationAction.
713
714         * WebCoreSupport/WebFrameLoaderClient.cpp:
715         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
716         * WebCoreSupport/WebFrameLoaderClient.h:
717
718 2018-04-12  Antoine Quint  <graouts@apple.com>
719
720         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
721         https://bugs.webkit.org/show_bug.cgi?id=184569
722         <rdar://problem/38671301>
723
724         Reviewed by Jon Lee.
725
726         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
727
728         * WebPreferences.cpp:
729
730 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
731
732         [WTF] Remove StaticLock
733         https://bugs.webkit.org/show_bug.cgi?id=184332
734
735         Reviewed by Mark Lam.
736
737         * WebKitQuartzCoreAdditions/CAView.cpp:
738         (WKQCA::CAView::releaseAllD3DResources):
739         * WebLocalizableStrings.cpp:
740
741 2018-04-03  Chris Dumez  <cdumez@apple.com>
742
743         Drop MainFrame class
744         https://bugs.webkit.org/show_bug.cgi?id=184191
745
746         Reviewed by Darin Adler.
747
748         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
749         relationship between the Page and the MainFrame.
750
751         This is ground work for introducing LocalFrame / RemoteFrame concepts.
752
753         * WebCoreSupport/AcceleratedCompositingContext.cpp:
754         * WebCoreSupport/WebContextMenuClient.cpp:
755         * WebCoreSupport/WebDragClient.cpp:
756         * WebDropSource.cpp:
757         * WebFrame.cpp:
758         * WebView.cpp:
759
760 2018-03-26  Chris Dumez  <cdumez@apple.com>
761
762         Use SecurityOriginData more consistently in Service Worker code
763         https://bugs.webkit.org/show_bug.cgi?id=183969
764
765         Reviewed by Darin Adler.
766
767         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
768
769         * WebDatabaseManager.cpp:
770         (WebDatabaseManager::databasesWithOrigin):
771         (WebDatabaseManager::deleteOrigin):
772         (WebDatabaseManager::deleteDatabase):
773         (WebDatabaseManager::setQuota):
774         * WebSecurityOrigin.cpp:
775         (WebSecurityOrigin::usage):
776         (WebSecurityOrigin::quota):
777         (WebSecurityOrigin::setQuota):
778
779 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
780
781         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
782         https://bugs.webkit.org/show_bug.cgi?id=183911
783         <rdar://problem/38762306>
784
785         Reviewed by Youenn Fablet.
786
787         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
788
789         * WebView.cpp:
790         (WebView::WebView):
791
792 2018-03-25  Commit Queue  <commit-queue@webkit.org>
793
794         Unreviewed, rolling out r229954.
795         https://bugs.webkit.org/show_bug.cgi?id=184000
796
797         Caused many layout tests to crash on Apple High Sierra,
798         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
799         by dydz on #webkit).
800
801         Reverted changeset:
802
803         "Use SecurityOriginData more consistently in Service Worker
804         code"
805         https://bugs.webkit.org/show_bug.cgi?id=183969
806         https://trac.webkit.org/changeset/229954
807
808 2018-03-24  Chris Dumez  <cdumez@apple.com>
809
810         Use SecurityOriginData more consistently in Service Worker code
811         https://bugs.webkit.org/show_bug.cgi?id=183969
812
813         Reviewed by Darin Adler.
814
815         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
816
817         * WebDatabaseManager.cpp:
818         (WebDatabaseManager::databasesWithOrigin):
819         (WebDatabaseManager::deleteOrigin):
820         (WebDatabaseManager::deleteDatabase):
821         (WebDatabaseManager::setQuota):
822         * WebSecurityOrigin.cpp:
823         (WebSecurityOrigin::usage):
824         (WebSecurityOrigin::quota):
825         (WebSecurityOrigin::setQuota):
826
827 2018-03-23  Chris Dumez  <cdumez@apple.com>
828
829         Unreviewed attempt to fix Windows build after r229926.
830
831         * WebView.cpp:
832
833 2018-03-23  Brady Eidson  <beidson@apple.com>
834
835         Go to back/forward list items after a process-swapped navigation.
836         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
837
838         Reviewed by Andy Estes.
839
840         * WebView.cpp:
841         (WebView::goToBackForwardItem):
842         (WebView::loadBackForwardListFromOtherView):
843
844 2018-03-23  Miguel Gomez  <magomez@igalia.com>
845
846         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
847         https://bugs.webkit.org/show_bug.cgi?id=183892
848
849         Remove the UpdateContentsFlag parameter as it's not used anymore.
850
851         Reviewed by Žan Doberšek.
852
853         * WebCoreSupport/AcceleratedCompositingContext.cpp:
854         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
855
856 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
857
858         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
859         https://bugs.webkit.org/show_bug.cgi?id=183335
860
861         Reviewed by Alex Christensen.
862
863         * Plugins/PluginDatabaseWin.cpp:
864         * Plugins/PluginMessageThrottlerWin.cpp:
865         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
866         * Plugins/PluginPackageWin.cpp:
867         (WebCore::PluginPackage::load):
868         * Plugins/PluginView.h:
869         * Plugins/PluginViewWin.cpp:
870         * Plugins/npapi.cpp:
871         * WebCoreSupport/WebFrameLoaderClient.cpp:
872         (WebFrameLoaderClient::createPlugin):
873         (WebFrameLoaderClient::createJavaAppletWidget):
874         * WebView.cpp:
875         (WebView::WebViewWndProc):
876
877 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
878
879         [Win] Layout Test fast/html/menuitem-element.html is failing.
880         https://bugs.webkit.org/show_bug.cgi?id=179299
881
882         Reviewed by Per Arne Vollan.
883
884         * Interfaces/IWebPreferencesPrivate.idl:
885         * WebPreferenceKeysPrivate.h:
886         * WebPreferences.cpp:
887         (WebPreferences::menuItemElementEnabled):
888         (WebPreferences::setMenuItemElementEnabled):
889         * WebPreferences.h:
890         * WebView.cpp:
891         (WebView::notifyPreferencesChanged):
892         Add private web preference "menuItemElementEnabled".
893
894 2018-03-12  Antoine Quint  <graouts@apple.com>
895
896         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
897         https://bugs.webkit.org/show_bug.cgi?id=183504
898         <rdar://problem/38372965>
899
900         Reviewed by Dean Jackson and Jon Lee.
901
902         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
903         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
904
905         * Interfaces/IWebPreferencesPrivate.idl:
906         * WebPreferences.cpp:
907         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
908         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
909         * WebPreferenceKeysPrivate.h
910         * WebPreferences.h:
911         * WebView.cpp:
912         (WebView::notifyPreferencesChanged):
913
914 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
915
916         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
917         https://bugs.webkit.org/show_bug.cgi?id=183429
918
919         Reviewed by Mark Lam.
920
921         * WebFrame.cpp:
922         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
923
924 2018-03-08  Tim Horton  <timothy_horton@apple.com>
925
926         Stop linking ApplicationServices directly
927         https://bugs.webkit.org/show_bug.cgi?id=182867
928         <rdar://problem/38252142>
929
930         Reviewed by Alex Christensen.
931
932         The frameworks that we use that live inside ApplicationServices
933         have mostly moved out, so import them directly.
934
935         * FullscreenVideoController.cpp:
936
937 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
938
939         Fix std::make_unique / new[] using system malloc
940         https://bugs.webkit.org/show_bug.cgi?id=182975
941
942         Reviewed by JF Bastien.
943
944         Use Vector instead.
945
946         * MarshallingHelpers.cpp:
947         (MarshallingHelpers::safeArrayToStringArray):
948         (MarshallingHelpers::safeArrayToIntArray):
949         * Plugins/PluginPackageWin.cpp:
950         (WebCore::PluginPackage::fetchInfo):
951         * WebPreferences.cpp:
952         (WebPreferences::copyWebKitPreferencesToCFPreferences):
953         * WebView.cpp:
954         (WebView::onMenuCommand):
955
956 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
957
958         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
959         https://bugs.webkit.org/show_bug.cgi?id=183312
960
961         Reviewed by Mark Lam.
962
963         Remove wtf/CurrentTime.h include pragma.
964
965         * WebDownload.cpp:
966         * WebDownloadCFNet.cpp:
967         * WebDropSource.cpp:
968
969 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
970
971         Remove monotonicallyIncreasingTime
972         https://bugs.webkit.org/show_bug.cgi?id=182911
973
974         Reviewed by Michael Catanzaro.
975
976         * FullscreenVideoController.cpp:
977         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
978         * Plugins/PluginMessageThrottlerWin.cpp:
979         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
980         (WebCore::PluginMessageThrottlerWin::appendMessage):
981         * Plugins/PluginMessageThrottlerWin.h:
982         * WebView.cpp:
983         (WebView::notifyAnimationStarted):
984         * WebView.h:
985
986 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
987
988         [Win][DRT] Implement setSpatialNavigationEnabled.
989         https://bugs.webkit.org/show_bug.cgi?id=183166
990
991         Reviewed by Per Arne Vollan.
992
993         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
994
995         * Interfaces/IWebPreferencesPrivate.idl:
996         * WebPreferenceKeysPrivate.h:
997         * WebPreferences.cpp:
998         (WebPreferences::initializeDefaultSettings):
999         (WebPreferences::spatialNavigationEnabled):
1000         (WebPreferences::setSpatialNavigationEnabled):
1001         * WebPreferences.h:
1002         * WebView.cpp:
1003         (WebView::notifyPreferencesChanged):
1004
1005 2018-02-28  Alex Christensen  <achristensen@webkit.org>
1006
1007         Reduce use of NetworkingContext in WebKit
1008         https://bugs.webkit.org/show_bug.cgi?id=183213
1009
1010         Reviewed by Brady Eidson.
1011
1012         * Plugins/PluginView.cpp:
1013         (WebCore::PluginView::getValueForURL):
1014
1015 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
1016
1017         Fix WebCore includes within WebKitLegacy
1018         https://bugs.webkit.org/show_bug.cgi?id=183147
1019
1020         Reviewed by Tim Horton.
1021
1022         * Plugins/PluginDatabase.cpp:
1023         * Plugins/PluginDatabaseWin.cpp:
1024         * Plugins/PluginDebug.cpp:
1025         * Plugins/PluginDebug.h:
1026         * Plugins/PluginMainThreadScheduler.cpp:
1027         * Plugins/PluginMessageThrottlerWin.cpp:
1028         * Plugins/PluginMessageThrottlerWin.h:
1029         * Plugins/PluginPackage.cpp:
1030         * Plugins/PluginPackage.h:
1031         * Plugins/PluginPackageWin.cpp:
1032         * Plugins/PluginStream.cpp:
1033         * Plugins/PluginStream.h:
1034         * Plugins/PluginView.cpp:
1035         * Plugins/PluginView.h:
1036         * Plugins/PluginViewWin.cpp:
1037         * Plugins/npapi.cpp:
1038         * WebCoreSupport/WebChromeClient.cpp:
1039         * WebCoreSupport/WebContextMenuClient.cpp:
1040         * WebCoreSupport/WebFrameLoaderClient.cpp:
1041         * WebCoreSupport/WebInspectorClient.cpp:
1042         * WebCoreSupport/WebPlatformStrategies.cpp:
1043         * WebFrame.cpp:
1044         * WebKitMessageLoop.cpp:
1045         * WebView.cpp:
1046         * storage/WebDatabaseProvider.cpp:
1047
1048 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1049
1050         Remove currentTime() / currentTimeMS()
1051         https://bugs.webkit.org/show_bug.cgi?id=183052
1052
1053         Reviewed by Mark Lam.
1054
1055         * WebCoreSupport/WebFrameLoaderClient.cpp:
1056         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1057         * WebCoreSupport/WebFrameLoaderClient.h:
1058         * WebDownload.h:
1059         * WebDownloadCFNet.cpp:
1060         (WebDownload::didStart):
1061         (WebDownload::didReceiveData):
1062         (WebDownload::didFinish):
1063
1064 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
1065
1066         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
1067         https://bugs.webkit.org/show_bug.cgi?id=182883
1068
1069         Reviewed by Per Arne Vollan.
1070
1071         * WebKitPrefix.h:
1072
1073 2018-02-16  Dean Jackson  <dino@apple.com>
1074
1075         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
1076         https://bugs.webkit.org/show_bug.cgi?id=182894
1077
1078         Reviewed by Tim Horton.
1079
1080         Rename OPENGL_ES_2 to OPENGL_ES.
1081
1082         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1083
1084 2018-02-16  Youenn Fablet  <youenn@apple.com>
1085
1086         Allow specifying which plug-ins are supported
1087         https://bugs.webkit.org/show_bug.cgi?id=182748
1088
1089         Reviewed by Chris Dumez.
1090
1091         * WebCoreSupport/WebPluginInfoProvider.cpp:
1092         (WebPluginInfoProvider::getPluginInfo):
1093         * WebCoreSupport/WebPluginInfoProvider.h:
1094
1095 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
1096
1097         WebCore headers should not be included relatively within dependent projects
1098         https://bugs.webkit.org/show_bug.cgi?id=182805
1099
1100         Reviewed by Chris Dumez.
1101
1102         * FullscreenVideoController.h:
1103
1104 2018-02-13  Commit Queue  <commit-queue@webkit.org>
1105
1106         Unreviewed, rolling out r228431.
1107         https://bugs.webkit.org/show_bug.cgi?id=182766
1108
1109         Regressed CMake build stability (Requested by dolmstead on
1110         #webkit).
1111
1112         Reverted changeset:
1113
1114         "[CMake] Make WebCore headers copies"
1115         https://bugs.webkit.org/show_bug.cgi?id=182512
1116         https://trac.webkit.org/changeset/228431
1117
1118 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
1119
1120         [CMake] Make WebCore headers copies
1121         https://bugs.webkit.org/show_bug.cgi?id=182512
1122
1123         Reviewed by Keith Miller.
1124
1125         * FullscreenVideoController.h:
1126         * Plugins/PluginDatabase.cpp:
1127         * Plugins/PluginDatabaseWin.cpp:
1128         * Plugins/PluginDebug.cpp:
1129         * Plugins/PluginMainThreadScheduler.cpp:
1130         * Plugins/PluginMessageThrottlerWin.cpp:
1131         * Plugins/PluginPackage.cpp:
1132         * Plugins/PluginPackageWin.cpp:
1133         * Plugins/PluginStream.cpp:
1134         * Plugins/PluginView.cpp:
1135         * Plugins/PluginViewWin.cpp:
1136         * Plugins/npapi.cpp:
1137         * WebKitMessageLoop.cpp:
1138         * WebKitPrefix.h:
1139         * storage/WebDatabaseProvider.cpp:
1140
1141 2018-01-13  Darin Adler  <darin@apple.com>
1142
1143         Event improvements
1144         https://bugs.webkit.org/show_bug.cgi?id=179591
1145
1146         Reviewed by Chris Dumez.
1147
1148         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
1149         * WebFrame.cpp: Ditto.
1150
1151         * WebScriptWorld.cpp:
1152         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
1153
1154         * WebView.cpp: Removed include of ScriptValue.h.
1155         (WebView::handleEditingKeyboardEvent): Updated for name change from
1156         keyEvent to underlyingPlatformEvent.
1157
1158 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1159
1160         Remove WebCore/ForwardingHeaders directory
1161         https://bugs.webkit.org/show_bug.cgi?id=182347
1162
1163         Reviewed by Keith Miller.
1164
1165         * Plugins/PluginView.cpp:
1166         * Plugins/PluginViewWin.cpp:
1167         * WebCoreSupport/WebInspectorClient.cpp:
1168         * WebCoreSupport/WebInspectorClient.h:
1169         * WebFrame.cpp:
1170         * WebJavaScriptCollector.cpp:
1171         * WebView.cpp:
1172
1173 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1174
1175         Unreviewed, another attempt to fix the Windows build after r227479.
1176
1177         * WebFrame.cpp:
1178         (WebFrame::elementWithName):
1179
1180 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1181
1182         Unreviewed, try to fix the Windows build after r227479.
1183
1184         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
1185
1186         * WebFrame.cpp:
1187         (WebFrame::elementWithName):
1188         (WebFrame::controlsInForm):
1189
1190 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
1191
1192         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
1193         https://bugs.webkit.org/show_bug.cgi?id=181859
1194         <rdar://problem/36659886>
1195
1196         Reviewed by Alex Christensen.
1197         
1198         Use local include patch.
1199
1200         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
1201         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
1202         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
1203
1204 2018-01-17  Youenn Fablet  <youenn@apple.com>
1205
1206         Put fetch Request.keepalive behind a runtime flag
1207         https://bugs.webkit.org/show_bug.cgi?id=181592
1208
1209         Reviewed by Chris Dumez.
1210
1211         * WebPreferences.cpp:
1212         (WebPreferences::fetchAPIKeepAliveEnabled):
1213         (WebPreferences::setFetchAPIKeepAliveEnabled):
1214         * WebPreferences.h:
1215         * WebView.cpp:
1216         (WebView::notifyPreferencesChanged):
1217
1218 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1219
1220         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1221         https://bugs.webkit.org/show_bug.cgi?id=181637
1222         <rdar://problem/36508471>
1223
1224         Reviewed by Tim Horton.
1225
1226         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1227
1228         * WebCoreSupport/WebEditorClient.cpp:
1229         (WebEditorClient::replacementURLForResource):
1230         * WebCoreSupport/WebEditorClient.h:
1231
1232 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1233
1234         Remove std::chrono completely
1235         https://bugs.webkit.org/show_bug.cgi?id=181186
1236
1237         Reviewed by Alex Christensen.
1238
1239         * Plugins/PluginStream.cpp:
1240         (WebCore::lastModifiedDateMS):
1241
1242 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1243
1244         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
1245         https://bugs.webkit.org/show_bug.cgi?id=181173
1246
1247         Reviewed by Alex Christensen.
1248
1249         * WebNodeHighlight.cpp:
1250         (WebNodeHighlight::update): Scale the GraphicsContext.
1251
1252 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1253
1254         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
1255         https://bugs.webkit.org/show_bug.cgi?id=181160
1256
1257         Reviewed by Myles C. Maxfield.
1258
1259         * Plugins/PluginView.cpp:
1260         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
1261
1262 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1263
1264         Enable picture-in-picture from inline element on suspend.
1265         https://bugs.webkit.org/show_bug.cgi?id=180942
1266         rdar://problem/34745234
1267
1268         Reviewed by Jer Noble.
1269
1270         Update signature of enterVideoFullscreenForVideoElement.
1271
1272         * WebCoreSupport/WebChromeClient.cpp:
1273         (WebChromeClient::enterVideoFullscreenForVideoElement):
1274         * WebCoreSupport/WebChromeClient.h:
1275
1276 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1277
1278         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
1279         https://bugs.webkit.org/show_bug.cgi?id=180926
1280
1281         Reviewed by Tim Horton.
1282
1283         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
1284         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
1285
1286         * WebCoreSupport/WebFrameLoaderClient.cpp:
1287         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
1288         (WebFrameLoaderClient::pageID const): Ditto.
1289
1290 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1291
1292         Remove unnecessary boolean result of start() functions
1293         https://bugs.webkit.org/show_bug.cgi?id=180856
1294
1295         Reviewed by Darin Adler.
1296
1297         It always returns true.
1298
1299         * WebDownloadCurl.cpp:
1300         (WebDownload::start):
1301
1302 2017-12-14  John Wilander  <wilander@apple.com>
1303
1304         Storage Access API: Implement frame-specific access in the document.cookie layer
1305         https://bugs.webkit.org/show_bug.cgi?id=180682
1306         <rdar://problem/35982257>
1307
1308         Reviewed by Alex Christensen.
1309
1310         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1311         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1312         CookiesStrategy::getRawCookies() now take optional parameters for
1313         frameID and pageID to allow frame-specific scoping of cookies.
1314
1315         This change makes the return values of FrameLoaderClient::frameID()
1316         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1317         WebCore can call those getters and get the right return values in
1318         WebKit and std:nullopt in WebKitLegacy.
1319
1320         * WebCoreSupport/WebFrameLoaderClient.cpp:
1321         (WebFrameLoaderClient::pageID const):
1322         (WebFrameLoaderClient::frameID const):
1323             Now return an optional.
1324         * WebCoreSupport/WebFrameLoaderClient.h:
1325         * WebCoreSupport/WebPlatformStrategies.cpp:
1326         (WebPlatformStrategies::cookiesForDOM):
1327         (WebPlatformStrategies::setCookiesFromDOM):
1328         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1329         (WebPlatformStrategies::getRawCookies):
1330         * WebCoreSupport/WebPlatformStrategies.h:
1331
1332 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1333
1334         [WTF] Thread::create should have Thread::tryCreate
1335         https://bugs.webkit.org/show_bug.cgi?id=180333
1336
1337         Reviewed by Darin Adler.
1338
1339         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
1340         (WKQCA::CVDisplayLink::start):
1341
1342 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1343
1344         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
1345         https://bugs.webkit.org/show_bug.cgi?id=180572
1346
1347         Reviewed by Mark Lam.
1348
1349         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
1350         Also we use Lock instead of Mutex.
1351
1352         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
1353         (WKQCA::CAD3DRenderer::swapChain):
1354         (WKQCA::CAD3DRenderer::renderAndPresent):
1355         (WKQCA::CAD3DRenderer::renderToImage):
1356         (WKQCA::CAD3DRenderer::setDeviceIsLost):
1357         (WKQCA::CAD3DRenderer::renderInternal):
1358         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
1359         * WebKitQuartzCoreAdditions/CAView.cpp:
1360         (WKQCA::CAView::Handle::create):
1361         Return Ref<Handle> instead of RefPtr<>.
1362
1363         (WKQCA::CAView::Handle::lock):
1364         (WKQCA::CAView::Handle::view const):
1365         (WKQCA::CAView::Handle::clear):
1366         (WKQCA::views):
1367         (WKQCA::viewsNeedingUpdate):
1368         (WKQCA::CAView::releaseAllD3DResources):
1369         (WKQCA::CAView::CAView):
1370         (WKQCA::CAView::~CAView):
1371         (WKQCA::CAView::setLayer):
1372         (WKQCA::CAView::update):
1373         (WKQCA::CAView::drawToWindow):
1374         (WKQCA::CAView::drawToWindowInternal):
1375         (WKQCA::CAView::drawToImage):
1376         (WKQCA::CAView::willDraw):
1377         (WKQCA::CAView::drawIntoDC):
1378         (WKQCA::CAView::setShouldInvertColors):
1379         (WKQCA::CAView::scheduleNextDraw):
1380         (WKQCA::CAView::displayLinkReachedCAMediaTime):
1381         (WKQCA::CAView::contextDidChange):
1382         (WKQCA::CAView::updateSoon):
1383         (WKQCA::CAView::updateViewsNow):
1384         (WKQCA::CAView::d3dDevice9):
1385         (WKQCA::CAView::Handle::mutex): Deleted.
1386         (WKQCA::globalStateMutex): Deleted.
1387         (): Deleted.
1388         * WebKitQuartzCoreAdditions/CAView.h:
1389
1390 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1391
1392         Use StaticLock instead of NeverDestroyed<Lock>
1393         https://bugs.webkit.org/show_bug.cgi?id=180507
1394
1395         Reviewed by Saam Barati.
1396
1397         * WebLocalizableStrings.cpp:
1398         (findCachedString):
1399         (cacheString):
1400         (mainBundleLocStrings): Deleted.
1401         (frameworkLocStringsMutex): Deleted.
1402
1403 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
1404
1405         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
1406         https://bugs.webkit.org/show_bug.cgi?id=180431
1407         <rdar://problem/34531264>
1408
1409         Reviewed by Simon Fraser.
1410
1411         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
1412         'override' to make sure this doesn't break in the future.
1413
1414         * WebView.cpp:
1415         (WebView::notifyAnimationStarted):
1416         (WebView::paintContents):
1417         * WebView.h:
1418
1419 2017-11-23  Darin Adler  <darin@apple.com>
1420
1421         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1422         https://bugs.webkit.org/show_bug.cgi?id=179981
1423
1424         Reviewed by Sam Weinig.
1425
1426         * WebView.cpp:
1427         (WebView::searchFor): Use |= instead of | to build FindOptions.
1428         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
1429         (WebView::findString): Create FindOptions with |=; the old code just passed a
1430         WebKit FindOptions through without converting to WebCore::FindOptions.
1431
1432 2017-11-23  Darin Adler  <darin@apple.com>
1433
1434         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1435         https://bugs.webkit.org/show_bug.cgi?id=179907
1436
1437         Reviewed by Sam Weinig.
1438
1439         * Plugins/PluginDatabaseWin.cpp:
1440         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
1441         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
1442         * WebDownloadCFNet.cpp:
1443         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
1444
1445         * WebView.cpp:
1446         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
1447         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
1448         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
1449         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
1450         the code does not cause any change in behavior.
1451
1452 2017-11-22  Ali Juma  <ajuma@chromium.org>
1453
1454         Implement VisualViewport API attributes
1455         https://bugs.webkit.org/show_bug.cgi?id=179385
1456
1457         Reviewed by Frédéric Wang.
1458
1459         Add a VisualViewportAPI preference.
1460
1461         * Interfaces/IWebPreferencesPrivate.idl:
1462         * WebPreferenceKeysPrivate.h:
1463         * WebPreferences.cpp:
1464         (WebPreferences::initializeDefaultSettings):
1465         (WebPreferences::visualViewportAPIEnabled):
1466         (WebPreferences::setVisualViewportAPIEnabled):
1467         * WebPreferences.h:
1468         * WebView.cpp:
1469         (WebView::notifyPreferencesChanged):
1470
1471 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1472
1473         Unreviewed, rolling out r225093.
1474         https://bugs.webkit.org/show_bug.cgi?id=179938
1475
1476         Compilation failed on WinCairo 64-bit Release (Requested by
1477         fredw on #webkit).
1478
1479         Reverted changeset:
1480
1481         "Implement VisualViewport API attributes"
1482         https://bugs.webkit.org/show_bug.cgi?id=179385
1483         https://trac.webkit.org/changeset/225093
1484
1485 2017-11-21  Ali Juma  <ajuma@chromium.org>
1486
1487         Implement VisualViewport API attributes
1488         https://bugs.webkit.org/show_bug.cgi?id=179385
1489
1490         Reviewed by Frédéric Wang.
1491
1492         Add a VisualViewportAPI preference.
1493
1494         * Interfaces/IWebPreferencesPrivate.idl:
1495         * WebPreferenceKeysPrivate.h:
1496         * WebPreferences.cpp:
1497         (WebPreferences::initializeDefaultSettings):
1498         (WebPreferences::visualViewportAPIEnabled):
1499         (WebPreferences::setVisualViewportAPIEnabled):
1500         * WebPreferences.h:
1501         * WebView.cpp:
1502         (WebView::notifyPreferencesChanged):
1503
1504 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1505
1506         Clean up old URL parser remnants
1507         https://bugs.webkit.org/show_bug.cgi?id=179573
1508
1509         Reviewed by Darin Adler.
1510
1511         * WebCoreSupport/WebContextMenuClient.cpp:
1512         (WebContextMenuClient::searchWithGoogle):
1513         Use https if we do end up searching with google.
1514
1515 2017-11-12  Darin Adler  <darin@apple.com>
1516
1517         More is<> and downcast<>, less static_cast<>
1518         https://bugs.webkit.org/show_bug.cgi?id=179600
1519
1520         Reviewed by Chris Dumez.
1521
1522         * WebView.cpp:
1523         (WebView::handleEditingKeyboardEvent): Use downcast.
1524
1525 2017-11-09  Christopher Reid  <chris.reid@sony.com>
1526
1527         Use enum classes within FileSystem
1528         https://bugs.webkit.org/show_bug.cgi?id=175172
1529
1530         Reviewed by Darin Adler.
1531
1532         * Plugins/PluginDatabase.cpp:
1533
1534 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
1535
1536         [Win] Add WebKitQuartzCoreAdditions library.
1537         https://bugs.webkit.org/show_bug.cgi?id=179331
1538
1539         Reviewed by Alex Christensen.
1540
1541         * WebKitQuartzCoreAdditions: Added.
1542         * WebKitQuartzCoreAdditions/API: Added.
1543         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
1544         (toImage):
1545         (WKCACFImageGetWidth):
1546         (WKCACFImageGetHeight):
1547         (WKCACFImageCopyFileMapping):
1548         (WKCACFImageCreateWithImage):
1549         (WKCACFImageFinalize):
1550         (WKCACFImageCopyFormattingDescription):
1551         (WKCACFImageCopyDebugDescription):
1552         (WKCACFImageGetTypeID):
1553         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
1554         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
1555         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
1556         (toView):
1557         (toImpl):
1558         (WKCACFViewCreate):
1559         (WKCACFViewSetLayer):
1560         (WKCACFViewUpdate):
1561         (WKCACFViewFlushContext):
1562         (WKCACFViewInvalidateRects):
1563         (WKCACFViewCanDraw):
1564         (WKCACFViewDraw):
1565         (WKCACFViewCopyDrawnImage):
1566         (WKCACFViewDrawIntoDC):
1567         (contextDidChangeCallback):
1568         (WKCACFViewSetContextDidChangeCallback):
1569         (WKCACFViewGetLastCommitTime):
1570         (WKCACFViewSetContextUserData):
1571         (WKCACFViewGetContext):
1572         (WKCACFViewFinalize):
1573         (WKCACFViewCopyFormattingDescription):
1574         (WKCACFViewCopyDebugDescription):
1575         (WKCACFViewGetTypeID):
1576         (WKCACFViewSetShouldInvertColors):
1577         (WKCACFViewGetD3DDevice9):
1578         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
1579         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
1580         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
1581         (WKQCA::dllInstance):
1582         (DllMain):
1583         (WKCACFShutDown):
1584         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
1585         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
1586         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
1587         (WKQCA::d3d):
1588         (WKQCA::initialPresentationParameters):
1589         (WKQCA::CAD3DRenderer::shared):
1590         (WKQCA::CAD3DRenderer::CAD3DRenderer):
1591         (WKQCA::CAD3DRenderer::swapChain):
1592         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
1593         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
1594         (WKQCA::CAD3DRenderer::initialize):
1595         (WKQCA::D3DMatrixOrthoOffCenterRH):
1596         (WKQCA::prepareDevice):
1597         (WKQCA::updateBounds):
1598         (WKQCA::CAD3DRenderer::renderAndPresent):
1599         (WKQCA::CAD3DRenderer::renderToImage):
1600         (WKQCA::CAD3DRenderer::setDeviceIsLost):
1601         (WKQCA::CAD3DRenderer::renderInternal):
1602         (WKQCA::CAD3DRenderer::postProcess):
1603         (WKQCA::CAD3DRenderer::resetD3DDevice):
1604         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
1605         (WKQCA::CAD3DRenderer::release):
1606         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
1607         (WKQCA::D3DPostProcessingContext::sceneTexture const):
1608         (WKQCA::D3DPostProcessingContext::overlayQuad const):
1609         (WKQCA::CAD3DRenderer::d3dDevice9 const):
1610         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
1611         (WKQCA::CAView::Handle::create):
1612         (WKQCA::CAView::Handle::~Handle):
1613         (WKQCA::CAView::Handle::mutex):
1614         (WKQCA::CAView::Handle::view const):
1615         (WKQCA::CAView::Handle::clear):
1616         (WKQCA::CAView::Handle::Handle):
1617         (WKQCA::globalStateMutex):
1618         (WKQCA::registerMessageWindowClass):
1619         (WKQCA::createMessageWindow):
1620         (WKQCA::CAView::releaseAllD3DResources):
1621         (WKQCA::CAView::CAView):
1622         (WKQCA::CAView::~CAView):
1623         (WKQCA::CAView::create):
1624         (WKQCA::CAView::setContextDidChangeCallback):
1625         (WKQCA::CAView::setLayer):
1626         (WKQCA::CAView::update):
1627         (WKQCA::CAView::invalidateRects):
1628         (WKQCA::CAView::drawToWindow):
1629         (WKQCA::CAView::drawToWindowInternal):
1630         (WKQCA::CAView::drawToImage):
1631         (WKQCA::CAView::willDraw):
1632         (WKQCA::CAView::didDraw):
1633         (WKQCA::CAView::drawIntoDC):
1634         (WKQCA::CAView::setShouldInvertColors):
1635         (WKQCA::CAView::scheduleNextDraw):
1636         (WKQCA::CAView::displayLinkReachedCAMediaTime):
1637         (WKQCA::CAView::contextDidChangeCallback):
1638         (WKQCA::CAView::contextDidChange):
1639         (WKQCA::CAView::updateSoon):
1640         (WKQCA::CAView::updateViewsNow):
1641         (WKQCA::CAView::d3dDevice9):
1642         * WebKitQuartzCoreAdditions/CAView.h: Added.
1643         (WKQCA::CAView::context const):
1644         (WKQCA::CAView::canDraw const):
1645         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
1646         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
1647         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
1648         (WKQCA::CVDisplayLink::CVDisplayLink):
1649         (WKQCA::CVDisplayLink::~CVDisplayLink):
1650         (WKQCA::CVDisplayLink::create):
1651         (WKQCA::CVDisplayLink::start):
1652         (WKQCA::CVDisplayLink::stop):
1653         (WKQCA::CVDisplayLink::setPaused):
1654         (WKQCA::CVDisplayLink::runIOThread):
1655         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
1656         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
1657         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
1658         * WebKitQuartzCoreAdditions/Image.cpp: Added.
1659         (WKQCA::numBytesForSize):
1660         (WKQCA::Image::create):
1661         (WKQCA::Image::Image):
1662         (WKQCA::Image::~Image):
1663         (WKQCA::bitmapInfo):
1664         (WKQCA::Image::createDIB const):
1665         (WKQCA::Image::copyFileMapping):
1666         * WebKitQuartzCoreAdditions/Image.h: Added.
1667         (WKQCA::Image::size const):
1668         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
1669         (WKQCA::getBackBufferRectAsRenderTarget):
1670         (WKQCA::getSystemMemoryCopy):
1671         (WKQCA::copyRectToBitmap):
1672         (WKQCA::getImageCopy):
1673         (WKQCA::getBackBufferRectAsImage):
1674         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
1675         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
1676         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
1677         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
1678         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
1679
1680 2017-11-06  Christopher Reid  <chris.reid@sony.com>
1681
1682         Use enum classes within FileSystem
1683         https://bugs.webkit.org/show_bug.cgi?id=175172
1684
1685         Reviewed by Myles C. Maxfield.
1686
1687         * Plugins/PluginDatabase.cpp:
1688
1689 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
1690
1691         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
1692         https://bugs.webkit.org/show_bug.cgi?id=178333
1693
1694         Reviewed by Darin Adler.
1695
1696         * WebCoreSupport/WebFrameLoaderClient.cpp:
1697         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
1698
1699 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1700
1701         Use CompletionHandlers for redirects
1702         https://bugs.webkit.org/show_bug.cgi?id=179163
1703
1704         Reviewed by Tim Horton.
1705
1706         * Plugins/PluginStream.cpp:
1707         (WebCore::PluginStream::willSendRequest):
1708         * Plugins/PluginStream.h:
1709         (WebCore::PluginStreamClient::~PluginStreamClient):
1710         (WebCore::PluginStreamClient::streamDidFinishLoading):
1711         (WebCore::PluginStream::create):
1712         (WebCore::PluginStream::setLoadManually):
1713
1714 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1715
1716         Add a FileSystem namespace to FileSystem.cpp
1717         https://bugs.webkit.org/show_bug.cgi?id=179063
1718
1719         Reviewed by Darin Adler.
1720
1721         * Plugins/PluginDatabase.cpp:
1722         * Plugins/PluginPackage.cpp:
1723         * Plugins/PluginStream.cpp:
1724         * Plugins/PluginStream.h:
1725         * WebApplicationCache.cpp:
1726         * WebDatabaseManager.cpp:
1727         * WebDownloadCurl.cpp:
1728         * WebPreferences.cpp:
1729         * WebView.cpp:
1730
1731 2017-10-31  Alex Christensen  <achristensen@webkit.org>
1732
1733         Fix Windows build after r224260
1734
1735         * WebView.cpp:
1736         (WebView::gesture):
1737
1738 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1739
1740         [FrameView::layout cleanup] Move core layout logic to a separate class.
1741         https://bugs.webkit.org/show_bug.cgi?id=178771
1742         <rdar://problem/35166542>
1743
1744         Reviewed by Simon Fraser.
1745
1746         Move layout code out from FrameView to LayoutContext.
1747
1748         * WebFrame.cpp:
1749         (WebFrame::layout):
1750
1751 2017-10-26  Alex Christensen  <achristensen@webkit.org>
1752
1753         Fix Windows build
1754         https://bugs.webkit.org/show_bug.cgi?id=178892
1755
1756         * AccessibleBase.cpp:
1757         (MSAARole):
1758
1759 2017-10-26  Alex Christensen  <achristensen@webkit.org>
1760
1761         Fix Windows build
1762         https://bugs.webkit.org/show_bug.cgi?id=178892
1763
1764         * AccessibleBase.cpp:
1765         (AccessibleBase::state const):
1766         (MSAARole):
1767
1768 2017-10-25  Youenn Fablet  <youenn@apple.com>
1769
1770         Enable ServiceWorker to fetch resources
1771         https://bugs.webkit.org/show_bug.cgi?id=178673
1772
1773         Reviewed by Brady Eidson.
1774
1775         Added implementation to the new getters.
1776         They are noop in the context of WK1.
1777
1778         * WebCoreSupport/WebFrameLoaderClient.cpp:
1779         (WebFrameLoaderClient::pageID const):
1780         (WebFrameLoaderClient::frameID const):
1781         (WebFrameLoaderClient::sessionID const):
1782         * WebCoreSupport/WebFrameLoaderClient.h:
1783
1784 2017-10-20  Antoine Quint  <graouts@apple.com>
1785
1786         [Web Animations] Provide basic timeline and animation interfaces
1787         https://bugs.webkit.org/show_bug.cgi?id=178526
1788
1789         Reviewed by Dean Jackson.
1790
1791         Remove the WEB_ANIMATIONS compile-time flag.
1792
1793         * WebView.cpp:
1794         (WebView::notifyPreferencesChanged):
1795
1796 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1797
1798         [Curl] Clean up old style code in old curl files.
1799         https://bugs.webkit.org/show_bug.cgi?id=178569
1800
1801         Reviewed by Ryosuke Niwa.
1802
1803         * WebCache.cpp:
1804         (WebCache::cacheFolder):
1805         (WebCache::setCacheFolder):
1806         * WebView.cpp:
1807         (WebView::setCacheModel):
1808
1809 2017-10-19  Sam Weinig  <sam@webkit.org>
1810
1811         [Settings] Move global settings into their own file
1812         https://bugs.webkit.org/show_bug.cgi?id=178512
1813
1814         Reviewed by Darin Adler.
1815
1816         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1817
1818         * WebView.cpp:
1819         (WebView::initWithFrame):
1820
1821 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1822
1823         Replace some stack raw pointers with RefPtrs within WebCore/html
1824         https://bugs.webkit.org/show_bug.cgi?id=178201
1825         <rdar://problem/34841692>
1826
1827         Reviewed by Ryosuke Niwa.
1828
1829         * WebView.cpp:
1830         (WebView::handleEditingKeyboardEvent):
1831         Change the type of node as toNode() is changed to return RefPtr.
1832
1833 2017-10-16  Sam Weinig  <sam@webkit.org>
1834
1835         [Settings] Remove all custom code from Settings.h/cpp
1836         https://bugs.webkit.org/show_bug.cgi?id=178330
1837
1838         Reviewed by Simon Fraser.
1839
1840         * WebView.cpp:
1841         (WebView::notifyPreferencesChanged):
1842             
1843             Update for naming changes of FrameFlattening now that it is an enum class.
1844
1845 2017-10-11  Chris Dumez  <cdumez@apple.com>
1846
1847         Modernize Geolocation code
1848         https://bugs.webkit.org/show_bug.cgi?id=178148
1849
1850         Reviewed by Ryosuke Niwa.
1851
1852         * WebCoreSupport/WebGeolocationClient.cpp:
1853         (WebGeolocationClient::lastPosition):
1854         * WebCoreSupport/WebGeolocationClient.h:
1855         * WebGeolocationPosition.cpp:
1856         (WebGeolocationPosition::initWithTimestamp):
1857         (core):
1858         * WebGeolocationPosition.h:
1859         (WebGeolocationPosition::impl const):
1860
1861 2017-10-05  Chris Dumez  <cdumez@apple.com>
1862
1863         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1864         https://bugs.webkit.org/show_bug.cgi?id=177957
1865
1866         Reviewed by Alex Christensen.
1867
1868         * WebCoreSupport/WebPlatformStrategies.cpp:
1869         (WebPlatformStrategies::cookiesEnabled):
1870         * WebCoreSupport/WebPlatformStrategies.h:
1871
1872 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1873
1874         [Curl] Reimplement CurlDownload with CurlRequest
1875         https://bugs.webkit.org/show_bug.cgi?id=177779
1876
1877         Reviewed by Alex Christensen.
1878
1879         * WebDownload.h:
1880         * WebDownloadCurl.cpp:
1881         (WebDownload::init):
1882         (WebDownload::didReceiveResponse):
1883
1884 2017-09-29  Chris Dumez  <cdumez@apple.com>
1885
1886         Split some logic out of VisitedLinkStore and make it reusable
1887         https://bugs.webkit.org/show_bug.cgi?id=177575
1888
1889         Reviewed by Alex Christensen.
1890
1891         * WebCoreSupport/WebVisitedLinkStore.cpp:
1892         (WebVisitedLinkStore::addVisitedLink):
1893         (WebVisitedLinkStore::isLinkVisited):
1894         (WebVisitedLinkStore::addVisitedLinkHash):
1895         * WebCoreSupport/WebVisitedLinkStore.h:
1896
1897 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1898
1899         Make PolicyAction an encodable enum class
1900         https://bugs.webkit.org/show_bug.cgi?id=177480
1901
1902         Reviewed by Antti Koivisto.
1903
1904         * WebCoreSupport/WebFrameLoaderClient.cpp:
1905         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1906         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1907         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1908         * WebFramePolicyListener.cpp:
1909         (WebFramePolicyListener::use):
1910         (WebFramePolicyListener::download):
1911         (WebFramePolicyListener::ignore):
1912         (WebFramePolicyListener::continueSubmit):
1913
1914 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
1915
1916         [Win] fast/canvas/2d.getPath.modification.html is failing.
1917         https://bugs.webkit.org/show_bug.cgi?id=176534
1918
1919         Reviewed by Alex Christensen.
1920
1921         We need to enable Inspector additions at runtime in order to expose the getPath function.
1922
1923         * Interfaces/IWebPreferencesPrivate.idl:
1924         * WebPreferenceKeysPrivate.h:
1925         * WebPreferences.cpp:
1926         (WebPreferences::initializeDefaultSettings):
1927         (WebPreferences::setDataTransferItemsEnabled):
1928         (WebPreferences::inspectorAdditionsEnabled):
1929         (WebPreferences::setInspectorAdditionsEnabled):
1930         * WebPreferences.h:
1931         * WebView.cpp:
1932         (WebView::notifyPreferencesChanged):
1933
1934 2017-09-07  Alex Christensen  <achristensen@webkit.org>
1935
1936         Modernize Geolocation code
1937         https://bugs.webkit.org/show_bug.cgi?id=176496
1938
1939         Reviewed by Andy Estes.
1940
1941         * WebCoreSupport/WebGeolocationClient.cpp:
1942         (WebGeolocationClient::requestPermission):
1943         * WebCoreSupport/WebGeolocationClient.h:
1944         (WebGeolocationClient::setEnableHighAccuracy): Deleted.
1945         (WebGeolocationClient::cancelPermissionRequest): Deleted.
1946         * WebGeolocationPolicyListener.h:
1947         * WebView.cpp:
1948         (WebView::initWithFrame):
1949         (WebView::geolocationDidFailWithError):
1950
1951 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
1952
1953         [Win] Enable DatatransferItems in DRT.
1954         https://bugs.webkit.org/show_bug.cgi?id=176424
1955
1956         Reviewed by Brent Fulgham.
1957
1958         * Interfaces/IWebPreferencesPrivate.idl:
1959         * WebPreferenceKeysPrivate.h:
1960         * WebPreferences.cpp:
1961         (WebPreferences::initializeDefaultSettings):
1962         (WebPreferences::QueryInterface):
1963         (WebPreferences::isSecureContextAttributeEnabled):
1964         (WebPreferences::dataTransferItemsEnabled):
1965         (WebPreferences::setDataTransferItemsEnabled):
1966         * WebPreferences.h:
1967         * WebView.cpp:
1968         (WebView::notifyPreferencesChanged):
1969
1970 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
1971
1972         Unreviewed build fix #2 after r221275.
1973
1974         * WebCoreSupport/WebPlatformStrategies.cpp:
1975         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
1976         to match new API.
1977         * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
1978
1979 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
1980
1981         Unreviewed build fix after r221275.
1982
1983         * WebCoreSupport/WebPlatformStrategies.cpp:
1984         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
1985         to match new API.
1986
1987 2017-08-28  Per Arne Vollan  <pvollan@apple.com>
1988
1989         [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
1990         https://bugs.webkit.org/show_bug.cgi?id=176031
1991
1992         Reviewed by Brent Fulgham.
1993
1994         When the function in the FramePolicyFunction parameter is called, it has already been moved
1995         to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
1996         function by using the stored member instead.
1997
1998         * WebCoreSupport/WebFrameLoaderClient.cpp:
1999         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2000         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2001         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2002
2003 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2004
2005         Unreviewed, try to fix the Windows build after r221064
2006
2007         didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
2008
2009         * WebCoreSupport/WebEditorClient.h:
2010
2011 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2012
2013         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2014         https://bugs.webkit.org/show_bug.cgi?id=175370
2015         <rdar://problem/33799806>
2016
2017         Reviewed by Ryosuke Niwa.
2018
2019         Adjust WebEditorClient for interface changes.
2020
2021         * WebCoreSupport/WebEditorClient.h:
2022
2023 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
2024
2025         Unreviewed build fix after r221017.
2026
2027         Correct copy/paste error.
2028
2029         * WebCoreSupport/WebPlatformStrategies.cpp:
2030         (WebPlatformStrategies::cookiesForDOM):
2031
2032 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
2033
2034         Unreviewed build fix after r221017.
2035
2036         * WebCoreSupport/WebPlatformStrategies.cpp:
2037         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
2038         * WebCoreSupport/WebPlatformStrategies.h:
2039
2040 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2041
2042         Remove ChromeClient::scrollbarsModeDidChange
2043         https://bugs.webkit.org/show_bug.cgi?id=175805
2044
2045         Reviewed by Daniel Bates.
2046
2047         * WebCoreSupport/WebChromeClient.h:
2048
2049 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2050
2051         Remove ChromeClient::hasOpenedPopup
2052         https://bugs.webkit.org/show_bug.cgi?id=175804
2053
2054         Reviewed by Sam Weinig.
2055
2056         * WebCoreSupport/WebChromeClient.cpp:
2057         (WebChromeClient::hasOpenedPopup const): Deleted.
2058         * WebCoreSupport/WebChromeClient.h:
2059
2060 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
2061
2062         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
2063         https://bugs.webkit.org/show_bug.cgi?id=173536
2064
2065         Reviewed by Brent Fulgham.
2066
2067         If the tree state is dirty, accessible objects are deleted while iterating over children
2068         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
2069         style is updated before this method is called.
2070
2071         * AccessibleBase.cpp:
2072         (AccessibleBase::getAccessibilityObjectForChild):
2073
2074 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2075
2076         [PAL] Move SessionID into PAL
2077         https://bugs.webkit.org/show_bug.cgi?id=174192
2078
2079         Reviewed by Antti Koivisto.
2080
2081         * WebCoreSupport/WebFrameLoaderClient.cpp:
2082         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2083         * WebCoreSupport/WebFrameLoaderClient.h:
2084         * WebCoreSupport/WebFrameNetworkingContext.cpp:
2085         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
2086         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2087         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2088         (WebFrameNetworkingContext::storageSession const):
2089         * WebCoreSupport/WebPlatformStrategies.cpp:
2090         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2091         * WebCoreSupport/WebPlatformStrategies.h:
2092
2093 2017-08-15  Youenn Fablet  <youenn@apple.com>
2094
2095         [Cache API] Adding generic support for CacheStorage and Cache methods
2096         https://bugs.webkit.org/show_bug.cgi?id=175455
2097
2098         Reviewed by Chris Dumez.
2099
2100         * WebView.cpp:
2101         (WebView::initWithFrame):
2102
2103 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2104
2105         Composition underline color is always black
2106         https://bugs.webkit.org/show_bug.cgi?id=174675
2107
2108         Reviewed by Ryosuke Niwa.
2109
2110         * WebView.cpp:
2111         (WebView::setCompositionForTesting): Use text color for
2112         composition underline.
2113
2114 2017-08-09  Daniel Bates  <dabates@apple.com>
2115
2116         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2117         https://bugs.webkit.org/show_bug.cgi?id=175247
2118         <rdar://problem/33679804>
2119
2120         Reviewed by Brady Eidson.
2121
2122         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2123         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2124         clients that need to make use of this information at this time. If such a needs comes up
2125         then we can expose API/SPI similar to what we do for WebKit.
2126
2127         * WebCoreSupport/WebFrameLoaderClient.cpp:
2128         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2129         * WebCoreSupport/WebFrameLoaderClient.h:
2130
2131 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
2132
2133         Async image decoding for large images should be disabled after the first time a tile is painted
2134         https://bugs.webkit.org/show_bug.cgi?id=174451
2135         <rdar://problem/31246421>
2136
2137         Reviewed by Simon Fraser.
2138
2139         * FullscreenVideoController.cpp:
2140         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
2141         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2142         (AcceleratedCompositingContext::paintContents):
2143         * WebCoreSupport/AcceleratedCompositingContext.h:
2144
2145 2017-07-23  Darin Adler  <darin@apple.com>
2146
2147         More NeverDestroyed and related cleanup
2148         https://bugs.webkit.org/show_bug.cgi?id=174745
2149
2150         Reviewed by Alex Christensen.
2151
2152         * Plugins/PluginDatabase.cpp:
2153         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
2154         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
2155         * Plugins/PluginMainThreadScheduler.cpp:
2156         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
2157         * Plugins/PluginMainThreadScheduler.h: Ditto.
2158         * WebCoreSupport/WebPlatformStrategies.cpp:
2159         (WebPlatformStrategies::initialize): Ditto.
2160         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
2161         * WebHistory.cpp:
2162         (sharedHistoryStorage): Ditto.
2163         * WebLocalizableStrings.cpp:
2164         (mainBundleLocStrings): Ditto.
2165         (frameworkLocStringsMutex): Ditto.
2166         (frameworkLocStrings): Ditto.
2167         * WebView.cpp:
2168         (WebView::standardUserAgentWithApplicationName): Ditto.
2169         Also changed to keep one global string with the prefix of the user agent string
2170         instead of keeping two globals with pieces of that prefix.
2171
2172 2017-07-24  Chris Dumez  <cdumez@apple.com>
2173
2174         Make ExceptionCode a proper enumeration
2175         https://bugs.webkit.org/show_bug.cgi?id=174771
2176
2177         Reviewed by Sam Weinig.
2178
2179         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
2180
2181         * DOMCoreClasses.cpp:
2182         (DOMDocument::createEvent):
2183         * WebView.cpp:
2184         (WebView::prepareCandidateWindow):
2185
2186 2017-07-21  Andreas Kling  <akling@apple.com>
2187
2188         Use more references in event dispatch code
2189         https://bugs.webkit.org/show_bug.cgi?id=174681
2190
2191         Reviewed by Geoffrey Garen.
2192
2193         * DOMEventsClasses.cpp:
2194         (WebEventListener::handleEvent):
2195         * DOMEventsClasses.h:
2196         * Plugins/PluginView.cpp:
2197         (WebCore::PluginView::handleEvent):
2198         * Plugins/PluginView.h:
2199
2200 2017-07-20  Brady Eidson  <beidson@apple.com>
2201
2202         Remove WebIconDatabase from WebKitLegacy/win.
2203         https://bugs.webkit.org/show_bug.cgi?id=174608
2204
2205         Reviewed by Alex Christensen.
2206
2207         It is unused.
2208         
2209         * ForEachCoClass.h:
2210
2211         * Interfaces/IWebIconDatabase.idl: Removed.
2212
2213         * Interfaces/WebKit.idl:
2214
2215         * WebCoreStatistics.cpp:
2216         (WebCoreStatistics::iconPageURLMappingCount):
2217         (WebCoreStatistics::iconRetainedPageURLCount):
2218         (WebCoreStatistics::iconRecordCount):
2219         (WebCoreStatistics::iconsWithDataCount):
2220
2221         * WebIconDatabase.cpp: Removed.
2222         * WebIconDatabase.h: Removed.
2223         * WebKitClassFactory.cpp:
2224
2225         * WebKitDLL.cpp:
2226         (shutDownWebKit):
2227
2228         * WebKitLogging.h:
2229
2230         * WebView.cpp:
2231         (WebView::close):
2232         (WebView::notifyDidAddIcon):
2233         (WebView::registerForIconNotification):
2234         (WebView::dispatchDidReceiveIconFromWebFrame):
2235         (WebView::onNotify):
2236
2237 2017-07-18  Matt Lewis  <jlewis3@apple.com>
2238
2239         Unreviewed, rolling out r219610.
2240
2241         This caused an api failure on all platforms for the test
2242         SnapshotImageLargeAsyncDecoding
2243
2244         Reverted changeset:
2245
2246         "Async image decoding for large images should be disabled
2247         after the first time a tile is painted"
2248         https://bugs.webkit.org/show_bug.cgi?id=174451
2249         http://trac.webkit.org/changeset/219610
2250
2251 2017-07-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
2252
2253         Async image decoding for large images should be disabled after the first time a tile is painted
2254         https://bugs.webkit.org/show_bug.cgi?id=174451
2255
2256         Reviewed by Simon Fraser.
2257
2258         * FullscreenVideoController.cpp:
2259         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
2260         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2261         (AcceleratedCompositingContext::paintContents):
2262         * WebCoreSupport/AcceleratedCompositingContext.h:
2263
2264 2017-07-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2265
2266         [Curl] Don't start downloading more than once for same request
2267         https://bugs.webkit.org/show_bug.cgi?id=174172
2268
2269         Reviewed by Alex Christensen.
2270
2271         * WebDownloadCurl.cpp:
2272         (WebDownload::init):
2273
2274 2017-07-12  Daniel Bates  <dabates@apple.com>
2275
2276         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
2277         https://bugs.webkit.org/show_bug.cgi?id=174427
2278
2279         Rubber-stamped by Brady Eidson.
2280
2281         * Plugins/PluginView.cpp:
2282         (WebCore::PluginView::start):
2283         (WebCore::PluginView::getURLNotify):
2284         (WebCore::PluginView::getURL):
2285         (WebCore::PluginView::handlePost):
2286
2287 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2288
2289         [WTF] Move SoftLinking.h into WTF
2290         https://bugs.webkit.org/show_bug.cgi?id=174000
2291
2292         Reviewed by Alex Christensen.
2293
2294         * WebKitClassFactory.cpp:
2295         * WebView.cpp:
2296
2297 2017-07-05  Brady Eidson  <beidson@apple.com>
2298
2299         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
2300         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
2301
2302         Reviewed by Alex Christensen.
2303
2304         Adopt to the new constructor for FrameLoadRequest.
2305
2306         * Plugins/PluginView.cpp:
2307         (WebCore::PluginView::start):
2308         (WebCore::PluginView::getURLNotify):
2309         (WebCore::PluginView::getURL):
2310         (WebCore::PluginView::handlePost):
2311
2312 2017-07-03  Brady Eidson  <beidson@apple.com>
2313
2314         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2315         https://bugs.webkit.org/show_bug.cgi?id=174073
2316
2317         Reviewed by Andy Estes.
2318
2319         * WebCoreSupport/WebFrameLoaderClient.cpp:
2320         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
2321         (WebFrameLoaderClient::registerForIconNotification): Deleted.
2322         * WebCoreSupport/WebFrameLoaderClient.h:
2323
2324 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
2325
2326         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
2327         https://bugs.webkit.org/show_bug.cgi?id=174004
2328
2329         Reviewed by Simon Fraser.
2330
2331         * WebCoreSupport/WebFrameLoaderClient.cpp:
2332         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2333
2334 2017-06-30  Daniel Bates  <dabates@apple.com>
2335
2336         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2337         https://bugs.webkit.org/show_bug.cgi?id=165160
2338         <rdar://problem/29451999>
2339
2340         Reviewed by Brady Eidson.
2341
2342         Pass the document that is requesting the load to the loader.
2343
2344         * Plugins/PluginView.cpp:
2345         (WebCore::PluginView::start):
2346         (WebCore::PluginView::getURLNotify):
2347         (WebCore::PluginView::getURL):
2348         (WebCore::PluginView::handlePost):
2349
2350 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2351
2352         Refactor drag start codepaths to plumb a DragItem to client layers
2353         https://bugs.webkit.org/show_bug.cgi?id=173832
2354         Work towards <rdar://problem/32236827>
2355
2356         Reviewed by Ryosuke Niwa and Tim Horton.
2357
2358         Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
2359
2360         * WebCoreSupport/WebDragClient.cpp:
2361         (WebDragClient::startDrag):
2362         * WebCoreSupport/WebDragClient.h:
2363
2364 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
2365
2366         Remove excessive headers from JavaScriptCore
2367         https://bugs.webkit.org/show_bug.cgi?id=173812
2368
2369         Reviewed by Darin Adler.
2370
2371         * Plugins/PluginPackage.cpp:
2372
2373 2017-06-22  Daniel Bates  <dabates@apple.com>
2374
2375         Make FrameLoadRequest a move-only type
2376         https://bugs.webkit.org/show_bug.cgi?id=173682
2377
2378         Reviewed by Alex Christensen and Darin Adler.
2379
2380         A FrameLoadRequest groups together the information to perform a load into a single object
2381         that is more manageable to pass around than its constituent parts. Code that receives a
2382         FrameLoadRequest is expected to extract out the information it needs to complete its task.
2383         And it does not make sense to re-use the same FrameLoadRequest object for more than one
2384         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
2385
2386         * Plugins/PluginView.cpp:
2387         (WebCore::PluginView::start):
2388         (WebCore::PluginView::performRequest):
2389         (WebCore::PluginView::load):
2390         (WebCore::PluginView::getURLNotify):
2391         (WebCore::PluginView::getURL):
2392         (WebCore::PluginView::handlePost):
2393         * Plugins/PluginView.h:
2394         (WebCore::PluginRequest::PluginRequest):
2395
2396 2017-06-22  Daniel Bates  <dabates@apple.com>
2397
2398         [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
2399         https://bugs.webkit.org/show_bug.cgi?id=173683
2400
2401         Reviewed by Alex Christensen.
2402
2403         Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
2404         header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
2405         by including PluginView.h. The latter does not make use of the functionality
2406         provided by FrameLoadRequest.h.
2407
2408         * Plugins/PluginViewWin.cpp:
2409         * WebCoreSupport/WebContextMenuClient.cpp:
2410
2411 2017-06-21  Daniel Bates  <dabates@apple.com>
2412
2413         Cleanup FrameLoadRequest
2414         https://bugs.webkit.org/show_bug.cgi?id=173564
2415         <rdar://problem/32903570>
2416
2417         Reviewed by Brent Fulgham.
2418
2419         * Plugins/PluginView.cpp:
2420         (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
2421         we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
2422         we do not have one. Use C++11 brace initialization syntax.
2423         (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
2424         name as we do not have one. Use C++11 brace initialization syntax.
2425         (WebCore::PluginView::getURL): Ditto.
2426         (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
2427         function to closer to where it is actually used. Explicitly pass the null-string for the target
2428         frame name as we do not have one. Use C++11 brace initialization syntax.
2429
2430 2017-06-20  Daniel Bates  <dabates@apple.com>
2431
2432         Have FrameLoadRequest takes a Frame& instead of a Frame*
2433         https://bugs.webkit.org/show_bug.cgi?id=173614
2434         <rdar://problem/32884890>
2435
2436         Reviewed by Brent Fulgham.
2437
2438         * Plugins/PluginView.cpp:
2439         (WebCore::PluginView::performRequest):
2440         * WebFrame.cpp:
2441         (WebFrame::loadRequest):
2442
2443 2017-06-19  Chris Dumez  <cdumez@apple.com>
2444
2445         Use WTF::Function instead of std::function in more places in WebCore/
2446         https://bugs.webkit.org/show_bug.cgi?id=173535
2447
2448         Reviewed by Antti Koivisto.
2449
2450         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
2451
2452         * WebCoreSupport/WebFrameLoaderClient.cpp:
2453         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2454         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2455         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2456         (WebFrameLoaderClient::dispatchWillSubmitForm):
2457         (WebFrameLoaderClient::setUpPolicyListener):
2458         (WebFrameLoaderClient::receivedPolicyDecision):
2459         * WebCoreSupport/WebFrameLoaderClient.h:
2460
2461 2017-05-14 Frederic Wang  <fwang@igalia.com>
2462
2463         Add heuristic to avoid flattening "fullscreen" iframes
2464         https://bugs.webkit.org/show_bug.cgi?id=171914
2465
2466         Reviewed by Simon Fraser.
2467
2468         This commit ajusts the window port to internally use the new preference type for frame flattening.
2469         However, the "partial frame flattening" value is not exposed yet.
2470
2471         * WebView.cpp:
2472         (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
2473
2474 2017-06-17  Chris Dumez  <cdumez@apple.com>
2475
2476         Use WTF::Function instead of std::function in WebKit2/
2477         https://bugs.webkit.org/show_bug.cgi?id=173504
2478
2479         Reviewed by Darin Adler.
2480
2481         Use WTF::Function instead of std::function in WebKit2/ to avoid
2482         unnecessary copying.
2483
2484         * Plugins/PluginStream.cpp:
2485         (WebCore::PluginStream::willSendRequest):
2486         * Plugins/PluginStream.h:
2487
2488 2017-06-16  Sam Weinig  <sam@webkit.org>
2489
2490         [WebIDL] Remove custom bindings for HTMLDocument
2491         https://bugs.webkit.org/show_bug.cgi?id=173444
2492
2493         Reviewed by Darin Adler.
2494
2495         * DOMHTMLClasses.cpp:
2496         (DOMHTMLDocument::write):
2497         (DOMHTMLDocument::writeln):
2498         Update for new signature of write/writeln.
2499
2500 2017-06-16  Daniel Bates  <dabates@apple.com>
2501
2502         Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
2503         instead of URL { ParsedURLString, ... }
2504         https://bugs.webkit.org/show_bug.cgi?id=173495
2505         <rdar://problem/32827445>
2506
2507         Reviewed by Alex Christensen.
2508
2509         URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
2510         Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
2511         Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
2512         would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
2513         parse an arbitrary string that looks like a URL.
2514
2515         Also modernize the code using C++14 idioms.
2516
2517         * WebCoreSupport/WebContextMenuClient.cpp:
2518         (WebContextMenuClient::searchWithGoogle):
2519
2520 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
2521
2522         [Win] WebKit shouldn't include the forwarding header of WebKit itself
2523         https://bugs.webkit.org/show_bug.cgi?id=173352
2524
2525         Reviewed by Alex Christensen.
2526
2527         * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
2528
2529 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
2530
2531         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
2532         https://bugs.webkit.org/show_bug.cgi?id=173318
2533
2534         Reviewed by Darin Adler.
2535
2536         The logical frame size is currently calculated by scaling the frame size in pixels,
2537         and rounding the coordinates to the nearest integers. The computed logical frame
2538         size will in some cases be smaller than the scaled frame size in pixels, since it is
2539         represented as an IntSize. In these cases, the bottom line will not be painted.
2540         Instead of calculating the logical frame size by rounding the scaled frame in
2541         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
2542
2543         * WebCoreSupport/WebFrameLoaderClient.cpp:
2544         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2545
2546 2017-06-13  Daniel Bates  <dabates@apple.com>
2547
2548         Implement W3C Secure Contexts Draft Specification
2549         https://bugs.webkit.org/show_bug.cgi?id=158121
2550         <rdar://problem/26012994>
2551
2552         Reviewed by Brent Fulgham.
2553
2554         Part 4
2555
2556         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
2557
2558         * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
2559         * WebPreferenceKeysPrivate.h:
2560         * WebPreferences.cpp:
2561         (WebPreferences::initializeDefaultSettings):
2562         (WebPreferences::QueryInterface):
2563         (WebPreferences::setIsSecureContextAttributeEnabled):
2564         (WebPreferences::isSecureContextAttributeEnabled):
2565         * WebPreferences.h:
2566         * WebView.cpp:
2567         (WebView::notifyPreferencesChanged):
2568
2569 2017-06-13  Per Arne Vollan  <pvollan@apple.com>
2570
2571         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
2572         https://bugs.webkit.org/show_bug.cgi?id=173318
2573
2574         Reviewed by Alex Christensen.
2575
2576         The logical frame size is currently calculated by scaling the frame size in pixels,
2577         and rounding the coordinates to the nearest integers. The computed logical frame
2578         size will in some cases be smaller than the scaled frame size in pixels, since it is
2579         represented as an IntSize. In these cases, the bottom line will not be painted.
2580         Instead of calculating the logical frame size by rounding the scaled frame in
2581         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
2582  
2583         * WebView.cpp:
2584         (WebView::sizeChanged):
2585
2586 2017-06-13  Sam Weinig  <sam@webkit.org>
2587
2588         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
2589         https://bugs.webkit.org/show_bug.cgi?id=80733
2590
2591         Reviewed by Chris Dumez.
2592
2593         * WebFrame.cpp:
2594         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2595
2596 2017-06-12  Daewoong Jang  <daewoong.jang@navercorp.com>
2597
2598         Remove WebCore::unloadModule and related data types
2599         https://bugs.webkit.org/show_bug.cgi?id=173231
2600
2601         Reviewed by Darin Adler.
2602
2603         * Plugins/PlatformModule.h: Added.
2604         (WebCore::PlatformModuleVersion::PlatformModuleVersion):
2605         * Plugins/PluginPackage.cpp:
2606         (WebCore::PluginPackage::freeLibraryTimerFired):
2607         * Plugins/PluginPackage.h:
2608
2609 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2610
2611         [iOS DnD] Add a hook to perform two-step drops in editable content
2612         https://bugs.webkit.org/show_bug.cgi?id=172992
2613         <rdar://problem/32590174>
2614
2615         Reviewed by Tim Horton.
2616
2617         Add a stub implementation for performTwoStepDrop on Windows.
2618
2619         * WebCoreSupport/WebEditorClient.h:
2620
2621 2017-06-04  Konstantin Tokarev  <annulen@yandex.ru>
2622
2623         Fix build of Windows-specific code with ICU 59.1
2624         https://bugs.webkit.org/show_bug.cgi?id=172729
2625
2626         Reviewed by Darin Adler.
2627
2628         Fix conversions from WTF::String to wchar_t* and vice versa.
2629
2630         * Plugins/PluginDatabaseWin.cpp:
2631         (WebCore::addPluginPathsFromRegistry):
2632         (WebCore::PluginDatabase::getPluginPathsInDirectories):
2633         (WebCore::addMozillaPluginDirectories):
2634         (WebCore::addWindowsMediaPlayerPluginDirectory):
2635         (WebCore::addAdobeAcrobatPluginDirectory):
2636         (WebCore::addJavaPluginDirectory):
2637         (WebCore::safariPluginsDirectory):
2638         (WebCore::addMacromediaPluginDirectories):
2639         * Plugins/PluginPackageWin.cpp:
2640         (WebCore::getVersionInfo):
2641         (WebCore::PluginPackage::fetchInfo):
2642         (WebCore::PluginPackage::load):
2643         * Plugins/PluginViewWin.cpp:
2644         (WebCore::PluginView::handlePostReadFile):
2645
2646 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
2647
2648         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
2649         https://bugs.webkit.org/show_bug.cgi?id=172709
2650
2651         Reviewed by Brent Fulgham.
2652
2653         Add method to exit fullscreen mode.
2654
2655         * Interfaces/IWebViewPrivate.idl:
2656         * WebView.cpp:
2657         (WebView::exitFullscreenIfNeeded):
2658         * WebView.h:
2659
2660 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
2661
2662         [Win] Create unique network storage session for each DRT.
2663         https://bugs.webkit.org/show_bug.cgi?id=172540
2664
2665         Reviewed by Brent Fulgham.
2666
2667         During layout testing, each DRT instance should have its own network storage session.
2668
2669         * Interfaces/IWebPreferencesPrivate.idl:
2670         * WebPreferences.cpp:
2671         (WebPreferences::switchNetworkLoaderToNewTestingSession):
2672         * WebPreferences.h:
2673
2674 2017-05-24  Fujii Hironori  <Hironori.Fujii@sony.com>
2675
2676         [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
2677         https://bugs.webkit.org/show_bug.cgi?id=172535
2678
2679         Reviewed by Konstantin Tokarev.
2680
2681         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2682         (AcceleratedCompositingContext::paintContents): Append the fifth argument.
2683         * WebCoreSupport/AcceleratedCompositingContext.h: Ditto.
2684
2685 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
2686
2687         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
2688         https://bugs.webkit.org/show_bug.cgi?id=172071
2689
2690         Reviewed by Alexey Proskuryakov.
2691
2692         We need to delete all cookies after each test.
2693
2694         * Interfaces/IWebPreferencesPrivate.idl:
2695         * WebPreferences.cpp:
2696         (WebPreferences::linkPreloadEnabled):
2697         (WebPreferences::clearNetworkLoaderSession):
2698         * WebPreferences.h:
2699
2700 2017-05-13  Chris Dumez  <cdumez@apple.com>
2701
2702         Stop using RefPtr::release()
2703         https://bugs.webkit.org/show_bug.cgi?id=172074
2704
2705         Reviewed by Geoffrey Garen.
2706
2707         * WebFrame.cpp:
2708         (WebFrame::loadPlainTextString):
2709         (WebFrame::loadHTMLString):
2710         * WebFramePolicyListener.cpp:
2711         (WebFramePolicyListener::receivedPolicyDecision):
2712
2713 2017-05-13  Chris Dumez  <cdumez@apple.com>
2714
2715         Drop uses of PassRefPtr in WebKit/win
2716         https://bugs.webkit.org/show_bug.cgi?id=172067
2717
2718         Reviewed by Yusuke Suzuki.
2719
2720         * DOMEventsClasses.cpp:
2721         (DOMEvent::DOMEvent):
2722         (DOMEvent::createInstance):
2723         * DOMEventsClasses.h:
2724         (DOMUIEvent::DOMUIEvent):
2725         (DOMKeyboardEvent::DOMKeyboardEvent):
2726         (DOMMouseEvent::DOMMouseEvent):
2727         (DOMMutationEvent::DOMMutationEvent):
2728         (DOMOverflowEvent::DOMOverflowEvent):
2729         (DOMWheelEvent::DOMWheelEvent):
2730         * MemoryStream.cpp:
2731         (MemoryStream::MemoryStream):
2732         (MemoryStream::createInstance):
2733         * MemoryStream.h:
2734         * Plugins/PluginDatabase.cpp:
2735         (WebCore::PluginDatabase::refresh):
2736         (WebCore::PluginDatabase::add):
2737         (WebCore::PluginDatabase::loadPersistentMetadataCache):
2738         * Plugins/PluginDatabase.h:
2739         * Plugins/PluginPackage.cpp:
2740         (WebCore::PluginPackage::createPackage):
2741         (WebCore::PluginPackage::createPackageFromCache):
2742         * Plugins/PluginPackage.h:
2743         * Plugins/PluginStream.h:
2744         (WebCore::PluginStream::create):
2745         * WebActionPropertyBag.cpp:
2746         (WebActionPropertyBag::WebActionPropertyBag):
2747         (WebActionPropertyBag::createInstance):
2748         * WebActionPropertyBag.h:
2749         * WebArchive.cpp:
2750         (WebArchive::createInstance):
2751         (WebArchive::WebArchive):
2752         * WebArchive.h:
2753         * WebBackForwardList.cpp:
2754         (WebBackForwardList::WebBackForwardList):
2755         (WebBackForwardList::createInstance):
2756         * WebBackForwardList.h:
2757         * WebCoreSupport/EmbeddedWidget.cpp:
2758         (EmbeddedWidget::create):
2759         * WebCoreSupport/EmbeddedWidget.h:
2760         * WebCoreSupport/WebChromeClient.h:
2761         * WebFrame.cpp:
2762         (WebFrame::loadData):
2763         (WebFrame::createSubframeWithOwnerElement):
2764         * WebFrame.h:
2765         * WebFramePolicyListener.cpp:
2766         (WebFramePolicyListener::WebFramePolicyListener):
2767         (WebFramePolicyListener::createInstance):
2768         * WebFramePolicyListener.h:
2769         * WebGeolocationPolicyListener.cpp:
2770         (WebGeolocationPolicyListener::createInstance):
2771         (WebGeolocationPolicyListener::WebGeolocationPolicyListener):
2772         * WebGeolocationPolicyListener.h:
2773         * WebHistoryItem.cpp:
2774         (WebHistoryItem::WebHistoryItem):
2775         (WebHistoryItem::createInstance):
2776         * WebHistoryItem.h:
2777         * WebMutableURLRequest.cpp:
2778         (WebMutableURLRequest::setFormData):
2779         (WebMutableURLRequest::formData):
2780         * WebMutableURLRequest.h:
2781         * WebResource.cpp:
2782         (WebResource::createInstance):
2783         * WebResource.h:
2784         * WebScriptWorld.cpp:
2785         (WebScriptWorld::WebScriptWorld):
2786         (WebScriptWorld::createInstance):
2787         * WebScriptWorld.h:
2788         * WebURLAuthenticationChallengeSender.cpp:
2789         (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
2790         (WebURLAuthenticationChallengeSender::createInstance):
2791         * WebURLAuthenticationChallengeSender.h:
2792         * WebView.cpp:
2793         (WebView::setFullScreenElement):
2794         * WebView.h:
2795
2796 2017-05-11  Chris Dumez  <cdumez@apple.com>
2797
2798         Drop remaining uses of PassRefPtr in WebCore
2799         https://bugs.webkit.org/show_bug.cgi?id=172013
2800
2801         Reviewed by Yusuke Suzuki.
2802
2803         * Plugins/PluginView.cpp:
2804         (WebCore::PluginView::bindingInstance):
2805
2806 2017-05-11  Chris Dumez  <cdumez@apple.com>
2807
2808         Stop using PassRefPtr in platform/graphics
2809         https://bugs.webkit.org/show_bug.cgi?id=171977
2810
2811         Reviewed by Alex Christensen.
2812
2813         Build fix.
2814
2815         * FullscreenVideoController.cpp:
2816         (FullscreenVideoController::enterFullscreen):
2817         * WebKitDLL.cpp:
2818         (loadResourceIntoBuffer):
2819
2820 2017-05-09  Sam Weinig  <sam@webkit.org>
2821
2822         Remove support for legacy Notifications
2823         https://bugs.webkit.org/show_bug.cgi?id=171487
2824
2825         Reviewed by Jon Lee.
2826
2827         * WebCoreSupport/WebChromeClient.cpp:
2828         (WebChromeClient::WebChromeClient):
2829         * WebCoreSupport/WebChromeClient.h:
2830         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
2831         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
2832         Remove legacy notification specific code.
2833
2834 2017-05-09  Dean Jackson  <dino@apple.com>
2835
2836         Fix Windows build.
2837
2838         * Plugins/PluginView.h:
2839         * Plugins/PluginViewWin.cpp:
2840         (WebCore::PluginView::paint):
2841
2842 2017-05-06  Alexey Proskuryakov  <ap@apple.com>
2843
2844         REGRESSION (r216294): The new test fails on WebKit1
2845         https://bugs.webkit.org/show_bug.cgi?id=171780
2846
2847         Rolling back https://trac.webkit.org/r216294, https://trac.webkit.org/r216296,
2848         https://trac.webkit.org/216299, https://trac.webkit.org/216330
2849
2850         * Plugins/PluginView.h:
2851         * Plugins/PluginViewWin.cpp:
2852         (WebCore::PluginView::paint):
2853
2854 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
2855
2856         Fix Windows build after r216294.
2857
2858         * Plugins/PluginView.h:
2859         * Plugins/PluginViewWin.cpp:
2860         (WebCore::PluginView::paint):
2861
2862 2017-05-04  Commit Queue  <commit-queue@webkit.org>
2863
2864         Unreviewed, rolling out r216206.
2865         https://bugs.webkit.org/show_bug.cgi?id=171714
2866
2867         Multiple LayoutTests crashing in Document::page() (Requested
2868         by ap on #webkit).
2869
2870         Reverted changeset:
2871
2872         "Remove support for legacy Notifications"
2873         https://bugs.webkit.org/show_bug.cgi?id=171487
2874         http://trac.webkit.org/changeset/216206
2875
2876 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
2877
2878         [Win] Remove redundant macros that are set in the CMake config
2879         https://bugs.webkit.org/show_bug.cgi?id=171571
2880
2881         Reviewed by Brent Fulgham.
2882
2883         * COMEnumVariant.h:
2884         * COMPropertyBag.h:
2885         * WebKitPrefix.h:
2886
2887 2017-05-04  Sam Weinig  <sam@webkit.org>
2888
2889         Remove support for legacy Notifications
2890         https://bugs.webkit.org/show_bug.cgi?id=171487
2891
2892         Reviewed by Jon Lee.
2893
2894         * WebCoreSupport/WebChromeClient.cpp:
2895         (WebChromeClient::WebChromeClient):
2896         * WebCoreSupport/WebChromeClient.h:
2897         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
2898         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
2899         Remove legacy notification specific code.
2900
2901 2017-04-27  Alex Christensen  <achristensen@webkit.org>
2902
2903         Modernize Frame.h
2904         https://bugs.webkit.org/show_bug.cgi?id=171357
2905
2906         Reviewed by Andy Estes.
2907
2908         * WebCoreSupport/WebEditorClient.cpp:
2909         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
2910         * WebCoreSupport/WebEditorClient.h:
2911
2912 2017-04-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2913
2914         [WinCairo] Fix build break after updating ANGLE
2915         https://bugs.webkit.org/show_bug.cgi?id=170980
2916
2917         Reviewed by Brent Fulgham.
2918
2919         * WebCoreSupport/AcceleratedCompositingContext.cpp: Define GL_GLEXT_PROTOTYPES.
2920
2921 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
2922
2923         [Win] REGRESSION(r215486): Windows Release build is broken
2924         https://bugs.webkit.org/show_bug.cgi?id=171024
2925         <rdar://problem/31722618>
2926
2927         Reviewed by Mark Lam.
2928
2929         Windows WebKit refers to a handful of JSC methods that are always
2930         inline. We need to include 'HeapInlines.h' to get the implementation
2931         of these methods.
2932
2933         * Plugins/PluginPackage.cpp:
2934         * WebFrame.cpp:
2935         * WebView.cpp:
2936
2937 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2938
2939         Unreviewed, fix the Windows build after r215385
2940
2941         r215385 introduced a new virtual method on ChromeClient that needs to be implemented in WebChromeClient for
2942         Windows in WebKit1.
2943
2944         * WebCoreSupport/WebChromeClient.cpp:
2945         (WebChromeClient::createIconForFiles):
2946         * WebCoreSupport/WebChromeClient.h:
2947
2948 2017-04-10  Chris Dumez  <cdumez@apple.com>
2949
2950         Drop Timer::startOneShot() overload taking a double
2951         https://bugs.webkit.org/show_bug.cgi?id=170659
2952
2953         Reviewed by Yusuke Suzuki.
2954
2955         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
2956
2957         * Plugins/PluginMessageThrottlerWin.cpp:
2958         (WebCore::PluginMessageThrottlerWin::appendMessage):
2959         (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
2960         * Plugins/PluginViewWin.cpp:
2961         (WebCore::PluginView::invalidateRect):
2962         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2963         (AcceleratedCompositingContext::scheduleLayerFlush):
2964
2965 2017-04-09  Chris Dumez  <cdumez@apple.com>
2966
2967         Drop Timer::startRepeating() overload taking a double
2968         https://bugs.webkit.org/show_bug.cgi?id=170656
2969
2970         Reviewed by Yusuke Suzuki.
2971
2972         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
2973
2974         * FullscreenVideoController.cpp:
2975
2976 2017-04-09  Chris Dumez  <cdumez@apple.com>
2977
2978         Start dropping Timer API dealing with double
2979         https://bugs.webkit.org/show_bug.cgi?id=170649
2980
2981         Reviewed by Yusuke Suzuki.
2982
2983         Start dropping Timer API dealing with double as people should use Seconds now.
2984
2985         * Plugins/PluginPackage.cpp:
2986         (WebCore::PluginPackage::freeLibrarySoon):
2987         * Plugins/PluginStream.cpp:
2988         (WebCore::PluginStream::deliverData):
2989         * Plugins/PluginView.cpp:
2990         (WebCore::PluginView::requestTimerFired):
2991         (WebCore::PluginView::scheduleRequest):
2992         (WebCore::PluginView::setJavaScriptPaused):
2993         (WebCore::PluginView::keepAlive):
2994         * Plugins/PluginViewWin.cpp:
2995         (WebCore::PluginView::wndProc):
2996         * WebView.cpp:
2997         (WebView::closeWindowSoon):
2998
2999 2017-04-08  Chris Dumez  <cdumez@apple.com>
3000
3001         Drop std::chrono support from Timer class
3002         https://bugs.webkit.org/show_bug.cgi?id=170645
3003
3004         Reviewed by Sam Weinig.
3005
3006         Drop std::chrono support from Timer class now that we prefer using Seconds type.
3007
3008         * WebView.cpp:
3009         (WebView::setCacheModel):
3010
3011 2017-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3012
3013         [WinCairo] WebCore::PlatformDisplay::terminateEGLDisplay causes a crash in libGLESv2.dll while processing atexit
3014         https://bugs.webkit.org/show_bug.cgi?id=170331
3015
3016         Reviewed by Michael Catanzaro.
3017
3018         * WebKitDLL.cpp:
3019         (shutDownWebKit): Call PlatformDisplay::shutDownEglDisplays in shutDownWebKit.
3020
3021 2017-03-30  James Craig  <jcraig@apple.com>
3022
3023         AX: Expose a new AXSubrole for explicit ARIA "group" role
3024         https://bugs.webkit.org/show_bug.cgi?id=169810
3025         <rdar://problem/31039693>
3026
3027         Reviewed by Chris Fleizach.
3028
3029         Account for Windows platform role mapping.
3030
3031         * AccessibleBase.cpp:
3032         (MSAARole):
3033
3034 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3035
3036         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
3037         https://bugs.webkit.org/show_bug.cgi?id=169168
3038         <rdar://problem/30688374>
3039
3040         Reviewed by Tim Horton.
3041
3042         Minor tweak to adjust for a changed interface. See WebKit and WebCore ChangeLogs for more information.
3043
3044         * WebCoreSupport/WebDragClient.cpp:
3045         (WebDragClient::actionMaskForDrag):
3046         * WebCoreSupport/WebDragClient.h:
3047
3048 2017-03-13  Per Arne Vollan  <pvollan@apple.com>
3049
3050         [Win] Compile fix.
3051         https://bugs.webkit.org/show_bug.cgi?id=169545
3052
3053         Reviewed by Brent Fulgham.
3054
3055         Fix inconsistent dll linkage warnings.
3056  
3057         * WebKitDLL.cpp:
3058         * WebKitDLL.h:
3059
3060 2017-03-13  Per Arne Vollan  <pvollan@apple.com>
3061
3062         Unreviewed Win build fix.
3063         
3064         WebCore::CookiesStrategy::addCookie has been removed, we should also remove the override.
3065
3066         * WebCoreSupport/WebPlatformStrategies.cpp:
3067         (WebPlatformStrategies::addCookie): Deleted.
3068         (WebPlatformStrategies::addCookie): Deleted.
3069         * WebCoreSupport/WebPlatformStrategies.h:
3070
3071 2017-03-10  Brent Fulgham  <bfulgham@apple.com>
3072
3073         [Win] Re-export a few symbols for backwards compatibility
3074         https://bugs.webkit.org/show_bug.cgi?id=169490
3075         <rdar://problem/30983623>
3076
3077         Reviewed by Dean Jackson.
3078
3079         Re-introduce a workaround that re-exports a few JavaScriptCore functions
3080         that had been erroneously exported by WebKit in older builds. This
3081         is needed so that we do not break certain old software still being used.
3082
3083         * WebKitDLL.cpp:
3084         (DllMain): Bind functions at startup.
3085         (bindJavaScriptTrampoline): Find JavaScriptCore library functions and
3086         re-export them from WebKit.dll.
3087         * WebKitDLL.h: Only advertise these functions when building WebKt itself.
3088
3089 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
3090
3091         Expand font-weight and font-stretch to take any number
3092         https://bugs.webkit.org/show_bug.cgi?id=168889
3093
3094         Reviewed by Simon Fraser.
3095
3096         Migrate off old enum types.
3097
3098         * WebKitGraphics.cpp:
3099         (makeFont):
3100
3101 2017-03-02  Sam Weinig  <sam@webkit.org>
3102
3103         Rename htmlediting.h/cpp to Editing.h/cpp
3104         https://bugs.webkit.org/show_bug.cgi?id=169103
3105
3106         Reviewed by Alex Christensen.
3107
3108         * AccessibleTextImpl.cpp:
3109
3110 2017-03-01  Alex Christensen  <achristensen@webkit.org>
3111
3112         Actually fix Windows build.
3113
3114         * WebFrame.cpp:
3115         (WebFrame::invalidate):
3116         r213266 changed Style::Force to ResolveStyleType::Rebuild, so I did so here.
3117
3118 2017-03-01  Alex Christensen  <achristensen@webkit.org>
3119
3120         Fix Windows build after r213266
3121         https://bugs.webkit.org/show_bug.cgi?id=169049
3122
3123         * WebFrame.cpp:
3124         (WebFrame::invalidate):
3125
3126 2017-02-27  Per Arne Vollan  <pvollan@apple.com>
3127
3128         [Win] Http preload tests are failing.
3129         https://bugs.webkit.org/show_bug.cgi?id=168910
3130
3131         Reviewed by Alex Christensen.
3132
3133         The feature is not enabled.
3134
3135         * WebView.cpp:
3136         (WebView::notifyPreferencesChanged):
3137
3138 2017-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3139
3140         Better handle Thread and RunLoop initialization
3141         https://bugs.webkit.org/show_bug.cgi?id=167828
3142
3143         Reviewed by Yusuke Suzuki.
3144
3145         Remove unnecessary call to WTF::initializeMainThread().
3146
3147         * WebView.cpp:
3148         (WebView::WebView):
3149
3150 2017-02-20  Per Arne Vollan  <pvollan@apple.com>
3151
3152         [Win] Custom scale factor is not applied in all cases.
3153         https://bugs.webkit.org/show_bug.cgi?id=168117
3154
3155         Reviewed by Brent Fulgham.
3156
3157         We should not call the function deviceScaleFactorForWindow directly, since this
3158         will return the system scale factor, and ignore the custom scale factor.
3159
3160         * WebView.cpp:
3161         (WebView::handleContextMenuEvent):
3162         (WebView::handleMouseEvent):
3163         (WebView::setAcceleratedCompositing):
3164
3165 2017-02-16  Daniel Bates  <dabates@apple.com>
3166
3167         Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
3168         https://bugs.webkit.org/show_bug.cgi?id=168417
3169         <rdar://problem/30541748>
3170
3171         Reviewed by Brent Fulgham.
3172
3173         Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
3174         Widget* as it is always called with a valid Widget.
3175
3176         * WebCoreSupport/WebFrameLoaderClient.cpp:
3177         (WebFrameLoaderClient::redirectDataToPlugin):
3178         * WebCoreSupport/WebFrameLoaderClient.h:
3179
3180 2017-02-15  Anders Carlsson  <andersca@apple.com>
3181
3182         Another attempt at fixing the Windows build.
3183
3184         * WebCoreSupport/WebDragClient.cpp:
3185         (WebDragClient::startDrag):
3186
3187 2017-02-15  Anders Carlsson  <andersca@apple.com>
3188
3189         Try to fix the Windows build.
3190
3191         * WebCoreSupport/WebDragClient.h:
3192
3193 2017-02-15  Anders Carlsson  <andersca@apple.com>
3194
3195         Modernize DragClient::startDrag somewhat
3196         https://bugs.webkit.org/show_bug.cgi?id=168379
3197
3198         Reviewed by Tim Horton.
3199
3200         Update for WebCore changes.
3201
3202         * WebCoreSupport/WebDragClient.cpp:
3203         (WebDragClient::startDrag):
3204
3205 2017-02-10  Daniel Bates  <dabates@apple.com>
3206
3207         Attempt to fix the WinCairo 64-Bit Release build following <https://trac.webkit.org/changeset/212173>
3208         (https://bugs.webkit.org/show_bug.cgi?id=166774)
3209
3210         Touch WebKit.idl in the hopes that it will cause CMake to regenerate the COM interface files.
3211
3212         * Interfaces/WebKit.idl:
3213
3214 2017-02-10  Daniel Bates  <dabates@apple.com>
3215
3216         Detach frame from document when entering page cache
3217         https://bugs.webkit.org/show_bug.cgi?id=166774
3218         <rdar://problem/29904368>
3219
3220         Reviewed by Chris Dumez.
3221
3222         * Interfaces/IWebPreferencesPrivate.idl:
3223         * WebPreferenceKeysPrivate.h:
3224         * WebPreferences.cpp:
3225         (WebPreferences::initializeDefaultSettings):
3226         (WebPreferences::setAllowsPageCacheWithWindowOpener): Deleted.
3227         (WebPreferences::allowsPageCacheWithWindowOpener): Deleted.
3228         * WebPreferences.h:
3229         * WebView.cpp:
3230         (WebView::notifyPreferencesChanged):
3231
3232 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
3233
3234         [Resource Timing] Enable Resource Timing by default in Tests
3235         https://bugs.webkit.org/show_bug.cgi?id=168145
3236
3237         Reviewed by Ryosuke Niwa.
3238
3239         * Interfaces/IWebPreferencesPrivate.idl:
3240         * WebPreferenceKeysPrivate.h:
3241         * WebPreferences.cpp:
3242         (WebPreferences::initializeDefaultSettings):
3243         (WebPreferences::setResourceTimingEnabled):
3244         (WebPreferences::resourceTimingEnabled):
3245         * WebPreferences.h:
3246         * WebView.cpp:
3247         (WebView::notifyPreferencesChanged):
3248
3249 2017-02-06  Alex Christensen  <achristensen@webkit.org>
3250
3251         More build fixes after r211751
3252         https://bugs.webkit.org/show_bug.cgi?id=166998
3253
3254         * WebDownloadCFNet.cpp:
3255         (WebDownload::didReceiveAuthenticationChallenge):
3256
3257 2017-02-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
3258
3259         Rename AnimationController to CSSAnimationController
3260         https://bugs.webkit.org/show_bug.cgi?id=167829
3261
3262         Reviewed by Simon Fraser.
3263
3264         * WebFrame.cpp:
3265
3266 2017-02-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3267
3268         Drag images should be anchored to the mouse location
3269         https://bugs.webkit.org/show_bug.cgi?id=167690
3270         <rdar://problem/30295261>
3271
3272         Reviewed by Enrica Casucci.
3273
3274         Adds some plumbing for the anchor point in the WK1 client layer.
3275
3276         * WebCoreSupport/WebDragClient.cpp:
3277         (WebDragClient::startDrag):
3278         * WebCoreSupport/WebDragClient.h:
3279
3280 2017-02-02  Per Arne Vollan  <pvollan@apple.com>
3281
3282         [Win][HiDPI] Scale factor is applied twice in accelerated compositing mode.
3283         https://bugs.webkit.org/show_bug.cgi?id=167732
3284
3285         Reviewed by Brent Fulgham.
3286
3287         Backing layer should not be scaled when CACFLayerSetContentsScale is used for scaling.
3288
3289         * WebView.cpp:
3290         (WebView::setAcceleratedCompositing):
3291
3292 2017-02-02  Chris Dumez  <cdumez@apple.com>
3293
3294         [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
3295         https://bugs.webkit.org/show_bug.cgi?id=167738
3296         <rdar://problem/30229990>
3297
3298         Reviewed by Andreas Kling.
3299
3300         The BackForwardClient no longer needs to worry about removing HistoryItems
3301         from the PageCache now that WebCore takes care of it.
3302
3303         * BackForwardList.cpp:
3304         (BackForwardList::close):
3305
3306 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
3307
3308         Add Link Preload as an off-by-default experimental feature menu item.
3309         https://bugs.webkit.org/show_bug.cgi?id=167201
3310
3311         Reviewed by Ryosuke Niwa.
3312
3313         * WebPreferenceKeysPrivate.h:
3314         * WebPreferences.cpp:
3315         (WebPreferences::initializeDefaultSettings):
3316         (WebPreferences::valueForKey):
3317         (WebPreferences::setLinkPreloadEnabled):
3318         (WebPreferences::linkPreloadEnabled):
3319         * WebPreferences.h:
3320         * Interfaces/IWebPreferencesPrivate.idl:
3321
3322 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
3323
3324         Add User Timing Experimental Feature
3325         https://bugs.webkit.org/show_bug.cgi?id=167542
3326         <rdar://problem/22746307>
3327
3328         Reviewed by Ryosuke Niwa.
3329
3330         * Interfaces/IWebPreferencesPrivate.idl:
3331         * WebPreferenceKeysPrivate.h:
3332         * WebPreferences.cpp:
3333         (WebPreferences::initializeDefaultSettings):
3334         (WebPreferences::setUserTimingEnabled):
3335         (WebPreferences::userTimingEnabled):
3336         * WebPreferences.h:
3337         * WebView.cpp:
3338         (WebView::notifyPreferencesChanged):
3339         Add setting for User Timing runtime enabled feature.
3340
3341 2017-01-26  Chris Dumez  <cdumez@apple.com>
3342
3343         Crash when navigating back to a page in PacheCache when one of its frames has been removed
3344         https://bugs.webkit.org/show_bug.cgi?id=167421
3345         <rdar://problem/30188490>
3346
3347         Reviewed by Darin Adler.
3348
3349         Add a new setting allowing layout tests to enable PageCache in a window
3350         that has an opener, for convenience.
3351
3352         * WebPreferenceKeysPrivate.h:
3353         * WebPreferences.cpp:
3354         (WebPreferences::initializeDefaultSettings):
3355         * WebPreferences.h:
3356
3357 2017-01-26  Keith Miller  <keith_miller@apple.com>
3358
3359         classInfo should take a VM so it is not materialized from the object on each call
3360         https://bugs.webkit.org/show_bug.cgi?id=167424
3361
3362         Rubber Stamped by Michael Saboff.
3363
3364         Previously, classInfo() would get the VM from the target's
3365         MarkedBlock.  Most callers already have a VM on hand, so it is
3366         wasteful to compute the VM from the marked block every time. This
3367         patch refactors some of the most common callers of classInfo(),
3368         jsDynamicCast and inherits to take a VM as well.
3369
3370         * WebFrame.cpp:
3371         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
3372         * WebView.cpp:
3373         (WebView::elementFromJS):
3374
3375 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
3376
3377         Crash when setting custom scale factor.
3378         https://bugs.webkit.org/show_bug.cgi?id=167369
3379
3380         Reviewed by Sam Weinig.
3381
3382         Add null pointer check.
3383
3384         * WebView.cpp:
3385         (WebView::setCustomBackingScaleFactor):
3386
3387 2017-01-24  Youenn Fablet  <youennf@gmail.com>
3388
3389         [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
3390         https://bugs.webkit.org/show_bug.cgi?id=167294
3391
3392         Reviewed by Alex Christensen.
3393
3394         * WebView.cpp:
3395         (WebView::initWithFrame):
3396
3397 2017-01-23  Chris Dumez  <cdumez@apple.com>
3398
3399         REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
3400         https://bugs.webkit.org/show_bug.cgi?id=167308
3401         <rdar://problem/30144964>
3402
3403         Unreviewed, do a partial revert of r211033 to fix assertion.
3404
3405         * WebCoreSupport/WebChromeClient.cpp:
3406         (WebChromeClient::exitFullScreenForElement):
3407
3408 2017-01-20  Darin Adler  <darin@apple.com>
3409
3410         Remove PassRefPtr from "page" directory of WebCore, also deploy references
3411         https://bugs.webkit.org/show_bug.cgi?id=167224
3412
3413         Reviewed by Chris Dumez.
3414
3415         * Plugins/PluginView.cpp:
3416         (WebCore::PluginView::status): Pass reference.
3417         (WebCore::PluginView::focusPluginElement): Ditto.
3418
3419         * WebCoreSupport/WebChromeClient.cpp:
3420         (WebChromeClient::createWindow): Updated for change to ChromeClient.
3421         (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
3422         (WebChromeClient::runJavaScriptAlert): Ditto.
3423         (WebChromeClient::runJavaScriptConfirm): Ditto.
3424         (WebChromeClient::runJavaScriptPrompt): Ditto.
3425         (WebChromeClient::contentsSizeChanged): Ditto.
3426         (WebChromeClient::unavailablePluginButtonClicked): Ditto.
3427         (WebChromeClient::print): Ditto.
3428         (WebChromeClient::exceededDatabaseQuota): Ditto.
3429         (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
3430         (WebChromeClient::attachRootGraphicsLayer): Ditto.
3431         (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
3432         (WebChromeClient::enterVideoFullscreenForVideoElement): Ditto.
3433         (WebChromeClient::createPopupMenu): Ditto.
3434         (WebChromeClient::createSearchPopupMenu): Ditto.
3435         (WebChromeClient::supportsFullScreenForElement): Ditto.
3436         (WebChromeClient::enterFullScreenForElement): Ditto.
3437         (WebChromeClient::exitFullScreenForElement): Ditto.
3438         (WebChromeClient::shouldUseTiledBackingForFrameView): Ditto.
3439         * WebCoreSupport/WebChromeClient.h: Ditto.
3440
3441 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3442
3443         Remove never changing IndexedDB RuntimeEnabledFeature
3444         https://bugs.webkit.org/show_bug.cgi?id=167278
3445
3446         Reviewed by Darin Adler.
3447
3448         * WebView.cpp:
3449         (WebView::notifyPreferencesChanged):
3450
3451 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3452
3453         Cleanup RuntimeEnabledFeatures
3454         https://bugs.webkit.org/show_bug.cgi?id=167228
3455
3456         Reviewed by Simon Fraser.
3457
3458         * WebView.cpp:
3459         (WebView::notifyPreferencesChanged):
3460
3461 2017-01-20  Alex Christensen  <achristensen@webkit.org>
3462
3463         Build Fix for Windows DumpRenderTree after r210976
3464         https://bugs.webkit.org/show_bug.cgi?id=167115
3465
3466         * WebPreferences.h:
3467         Remove extra space.
3468         * IWebPreferencesPrivate.idl:
3469         Add new interface functions.
3470         * WebView.cpp:
3471         We use new functions that are only in IWebPreferencesPrivate4,
3472         so instantiate that COM object instead of version 3.
3473
3474 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3475
3476         Build Fix for Windows DumpRenderTree after r210976
3477
3478         * WebPreferenceKeysPrivate.h:
3479         * WebPreferences.cpp:
3480         (WebPreferences::initializeDefaultSettings):
3481         (WebPreferences::setWebAnimationsEnabled):
3482         (WebPreferences::webAnimationsEnabled):
3483         * WebPreferences.h:
3484         * WebView.cpp:
3485         Add toggle APIs for WebAnimations.
3486
3487 2017-01-19  Chris Dumez  <cdumez@apple.com>
3488
3489         iterable<> should be enabled on WK1
3490         https://bugs.webkit.org/show_bug.cgi?id=167221
3491         <rdar://problem/30108531>
3492
3493         Reviewed by Youenn Fablet.
3494
3495         * Interfaces/IWebPreferencesPrivate.idl:
3496         * WebPreferenceKeysPrivate.h:
3497         * WebPreferences.cpp:
3498         (WebPreferences::setDOMIteratorEnabled): Deleted.
3499         (WebPreferences::domIteratorEnabled): Deleted.
3500         * WebPreferences.h:
3501         * WebView.cpp:
3502         (WebView::notifyPreferencesChanged):
3503
3504 2017-01-18  Alex Christensen  <achristensen@webkit.org>
3505
3506         Fix WinCairo build after r210845.
3507         https://bugs.webkit.org/show_bug.cgi?id=167055
3508
3509         * WebCoreSupport/WebFrameLoaderClient.cpp:
3510         * WebCoreSupport/WebFrameLoaderClient.h:
3511         shouldCacheResponse isn't used when loading with libcurl.
3512         It was dead code before Darin added "override".
3513         WebCore/FrameLoaderClient.h has this inside of USE(CFURLCONNECTION) macros, now we have them here, too.
3514
3515 2017-01-18  Andreas Kling  <akling@apple.com>
3516
3517         Document::securityOrigin() should return a reference.
3518         <https://webkit.org/b/167124>
3519
3520         Reviewed by Sam Weinig.
3521
3522         * Plugins/PluginView.cpp:
3523         (WebCore::PluginView::load):
3524         * WebCoreSupport/WebChromeClient.cpp:
3525         (WebChromeClient::exceededDatabaseQuota):
3526         * WebCoreSupport/WebFrameLoaderClient.cpp:
3527         (WebFrameLoaderClient::didRunInsecureContent):
3528         * WebCoreSupport/WebFrameLoaderClient.h:
3529         * WebCoreSupport/WebGeolocationClient.cpp:
3530         (WebGeolocationClient::requestPermission):
3531         * WebFrame.cpp:
3532         (WebFrame::allowsFollowingLink):
3533
3534 2017-01-15  Darin Adler  <darin@apple.com>
3535
3536         Remove PassRefPtr from "loader" directory of WebCore
3537         https://bugs.webkit.org/show_bug.cgi?id=167055
3538
3539         Reviewed by Alex Christensen.
3540
3541         * Plugins/PluginView.cpp:
3542         (WebCore::PluginView::mediaCanStart): Fix call to dispatchDidFailToStartPlugin
3543         by calling it directly on WebFrameLoaderClient. If my theory is correct, the old
3544         call has been broken and doing nothing since r177941, two years ago, which made
3545         the argument types different between FrameLoaderClient and WebFrameLoaderClient,
3546         leaving WebFrameLoaderClient::dispatchDidFailToStartPlugin as dead code.
3547
3548         * WebCoreSupport/WebChromeClient.cpp:
3549         (WebChromeClient::runOpenPanel): Updated for change to ChromeClient.
3550         * WebCoreSupport/WebChromeClient.h: Ditto.
3551
3552         * WebCoreSupport/WebEditorClient.cpp:
3553         (WebEditorUndoCommand::WebEditorUndoCommand): Take a reference instead of
3554         a PassRefPtr. Also use Ref instead of RefPtr.
3555         (WebEditorClient::shouldChangeTypingStyle): Deleted. Empty function that was
3556         never c