ae080a823a7c25635ce46c1179578db17fee8d97
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
2
3         Make it possible to control the renderTreeAsText output by setting options on testRunner
4         https://bugs.webkit.org/show_bug.cgi?id=197133
5
6         Reviewed by Sam Weinig.
7
8         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
9         that make sense in testing (those that don't dump unstable data like addresses), and plumb
10         these flags through the various framework layers.
11
12         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
13
14         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
15         and hand-code DumpRenderTree bindings.
16
17         Some cleanup of the TestRunners, using member initializers.
18
19         * Interfaces/IWebFramePrivate.idl:
20         * WebFrame.cpp:
21         (toRenderAsTextFlags):
22         (WebFrame::renderTreeAsExternalRepresentation):
23         (WebFrame::renderTreeAsExternalRepresentationForPrinting):
24         * WebFrame.h:
25
26 2019-04-23  Chris Dumez  <cdumez@apple.com>
27
28         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
29         https://bugs.webkit.org/show_bug.cgi?id=197097
30         <rdar://problem/50048318>
31
32         Reviewed by Alex Christensen.
33
34         * WebCoreSupport/WebFrameLoaderClient.cpp:
35         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
36         * WebCoreSupport/WebFrameLoaderClient.h:
37
38 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
39
40         [CMake][Win] Use target oriented design for WebKitLegacy
41         https://bugs.webkit.org/show_bug.cgi?id=197112
42
43         Reviewed by Konstantin Tokarev.
44
45         Fix an include directory.
46
47         * WebKitQuartzCoreAdditions/CMakeLists.txt:
48
49 2019-04-18  Jer Noble  <jer.noble@apple.com>
50
51         Refactoring: Pull all fullscreen code out of Document and into its own helper class
52         https://bugs.webkit.org/show_bug.cgi?id=197017
53
54         Reviewed by Eric Carlson.
55
56         * WebCoreSupport/WebChromeClient.cpp:
57         (WebChromeClient::createWindow):
58         * WebView.cpp:
59         (WebView::fullScreenClientWillEnterFullScreen):
60         (WebView::fullScreenClientDidEnterFullScreen):
61         (WebView::fullScreenClientWillExitFullScreen):
62         (WebView::fullScreenClientDidExitFullScreen):
63
64 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
65
66         requestAnimationFrame should execute before the next frame
67         https://bugs.webkit.org/show_bug.cgi?id=177484
68
69         Reviewed by Simon Fraser.
70
71         * WebView.cpp:
72         (WebView::updateBackingStore):
73         (WebView::flushPendingGraphicsLayerChangesSoon):
74         (WebView::flushPendingGraphicsLayerChanges):
75         Call Page::updateRendering() which implements "Update the rendering"
76         step of the HTML Event Loop specification.
77
78 2019-04-10  Devin Rousso  <drousso@apple.com>
79
80         Web Inspector: save sheet should be anchored underneath the tab bar when detached
81         https://bugs.webkit.org/show_bug.cgi?id=196722
82         <rdar://problem/49613280>
83
84         Reviewed by Timothy Hatcher.
85
86         * WebCoreSupport/WebInspectorClient.h:
87         * WebCoreSupport/WebInspectorClient.cpp:
88         (WebInspectorFrontendClient::setSheetRect): Added.
89
90 2019-04-10  Alex Christensen  <achristensen@webkit.org>
91
92         Add SPI WKNavigationResponse._downloadAttribute
93         https://bugs.webkit.org/show_bug.cgi?id=196755
94         <rdar://49587365>
95
96         Reviewed by Brady Eidson.
97
98         * WebCoreSupport/WebFrameLoaderClient.cpp:
99         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
100         * WebCoreSupport/WebFrameLoaderClient.h:
101
102 2019-04-05  Commit Queue  <commit-queue@webkit.org>
103
104         Unreviewed, rolling out r243833.
105         https://bugs.webkit.org/show_bug.cgi?id=196645
106
107         This change breaks build of WPE and GTK ports (Requested by
108         annulen on #webkit).
109
110         Reverted changeset:
111
112         "[CMake][WTF] Mirror XCode header directories"
113         https://bugs.webkit.org/show_bug.cgi?id=191662
114         https://trac.webkit.org/changeset/243833
115
116 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
117
118         [CMake][WTF] Mirror XCode header directories
119         https://bugs.webkit.org/show_bug.cgi?id=191662
120
121         Reviewed by Konstantin Tokarev.
122
123         * WebKitQuartzCoreAdditions/CMakeLists.txt:
124
125 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
126
127         Implement ResizeObserver.
128         https://bugs.webkit.org/show_bug.cgi?id=157743
129
130         Reviewed by Simon Fraser.
131
132         * Interfaces/IWebPreferencesPrivate.idl:
133         * WebPreferenceKeysPrivate.h:
134         * WebPreferences.cpp:
135         (WebPreferences::initializeDefaultSettings):
136         (WebPreferences::resizeObserverEnabled):
137         (WebPreferences::setResizeObserverEnabled):
138         * WebPreferences.h:
139         * WebView.cpp:
140         (WebView::notifyPreferencesChanged):
141
142 2019-03-17  Fujii Hironori  <Hironori.Fujii@sony.com>
143
144         [Win][WK1] Null dereference in WebFrameNetworkingContext::storageSession
145         https://bugs.webkit.org/show_bug.cgi?id=195741
146
147         Reviewed by Ross Kirsling.
148
149         * WebCoreSupport/WebFrameNetworkingContext.cpp:
150         (WebFrameNetworkingContext::storageSession const): Added a null check of frame()->page() as well as Mac port does (Bug 183455).
151
152 2019-03-13  Ryan Haddad  <ryanhaddad@apple.com>
153
154         Unreviewed attempt to fix the Windows build after r242920.
155
156         * WebCoreSupport/WebFrameLoaderClient.h:
157
158 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
159
160         [Win] Fix a slew of simple clang-cl warnings.
161         https://bugs.webkit.org/show_bug.cgi?id=195652
162
163         Reviewed by Don Olmstead.
164
165         * Interfaces/AccessibleComparable.idl: -Wmissing-braces
166         * Plugins/PluginDatabaseWin.cpp: -Wunused-function
167         (WebCore::addJavaPluginDirectory): Deleted.
168         * WebCoreSupport/AcceleratedCompositingContext.cpp:
169         (AcceleratedCompositingContext::AcceleratedCompositingContext): -Wreorder
170         * WebCoreSupport/WebEditorClient.cpp:
171         (WebEditorUndoCommand::WebEditorUndoCommand): -Wreorder
172         (undoNameForEditAction): -Wswitch
173         * WebCoreSupport/WebFrameLoaderClient.cpp:
174         (WebFrameLoaderClient::WebFrameLoaderClient): -Wswitch
175         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): -Wunused-variable
176         * WebCoreSupport/WebInspectorClient.cpp:
177         (WebInspectorFrontendClient::WebInspectorFrontendClient): -Wreorder
178         * WebCoreSupport/WebInspectorClient.h: -Winconsistent-missing-override
179         * WebError.cpp:
180         (WebError::WebError): -Wreorder
181         * WebFrame.cpp:
182         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): -Wlogical-op-parentheses
183         * WebHistory.cpp: -Wunused-function (x5)
184         (areEqualOrClose): Deleted.
185         (addDayToSystemTime): Deleted.
186         (getDayBoundaries): Deleted.
187         (beginningOfDay): Deleted.
188         (dateKey): Deleted.
189         * WebNotificationCenter.cpp:
190         (WebNotificationCenter::removeObserver): -Wunused-variable
191         * WebView.cpp: -Wunused-function, -Wreorder
192         (WebView::addVisitedLinks): -Wunused-variable
193
194 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
195
196         Unreviewed, rolling out r242688, r242643, r242624.
197
198         Caused multiple layout test failures and crashes on iOS and macOS.
199
200         Reverted changeset:
201
202         "requestAnimationFrame should execute before the next frame"
203         https://bugs.webkit.org/show_bug.cgi?id=177484
204         https://trac.webkit.org/changeset/242624/webkit
205
206         * WebView.cpp:
207         (WebView::updateBackingStore):
208         (WebView::flushPendingGraphicsLayerChangesSoon):
209         (WebView::flushPendingGraphicsLayerChanges):
210
211 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
212
213         requestAnimationFrame should execute before the next frame
214         https://bugs.webkit.org/show_bug.cgi?id=177484
215
216         Reviewed by Simon Fraser.
217
218         * WebView.cpp:
219         (WebView::updateBackingStore):
220         (WebView::flushPendingGraphicsLayerChangesSoon):
221         (WebView::flushPendingGraphicsLayerChanges):
222         Call Page::renderingUpdate() which implements  "Update the rendering"
223         step of the HTML Event Loop specification.
224
225 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
226
227         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
228         https://bugs.webkit.org/show_bug.cgi?id=195346
229
230         Reviewed by Fujii Hironori.
231
232         * COMPropertyBag.h:
233         (HashType>::GetPropertyInfo):
234         (HashType>::LoadObject):
235         * DOMCoreClasses.cpp:
236         (DOMNode::addEventListener):
237         (DOMNode::removeEventListener):
238         (DOMWindow::addEventListener):
239         (DOMWindow::removeEventListener):
240         (DOMElement::font):
241         * DOMHTMLClasses.cpp:
242         (DOMHTMLInputElement::setValueForUser):
243         (DOMHTMLInputElement::replaceCharactersInRange):
244         * Plugins/PluginDatabaseWin.cpp:
245         (WebCore::addPluginPathsFromRegistry):
246         (WebCore::PluginDatabase::getPluginPathsInDirectories const):
247         (WebCore::addMozillaPluginDirectories):
248         (WebCore::addWindowsMediaPlayerPluginDirectory):
249         (WebCore::addAdobeAcrobatPluginDirectory):
250         (WebCore::addJavaPluginDirectory):
251         (WebCore::safariPluginsDirectory):
252         (WebCore::addMacromediaPluginDirectories):
253         * Plugins/PluginPackageWin.cpp:
254         (WebCore::getVersionInfo):
255         (WebCore::PluginPackage::fetchInfo):
256         (WebCore::PluginPackage::load):
257         * Plugins/PluginViewWin.cpp:
258         (WebCore::PluginView::handlePostReadFile):
259         * WebCoreSupport/WebChromeClient.cpp:
260         (WebChromeClient::runOpenPanel):
261         * WebCoreSupport/WebEditorClient.cpp:
262         (WebEditorClient::checkSpellingOfString):
263         (WebEditorClient::checkGrammarOfString):
264         * WebCoreSupport/WebInspectorClient.cpp:
265         (WebInspectorFrontendClient::updateWindowTitle):
266         * WebLocalizableStrings.cpp:
267         (LocalizedString::operator LPCTSTR const):
268         * WebView.cpp:
269         (createContextMenuFromItems):
270         (WebView::setToolTip):
271         Use wchar helpers as needed.
272
273 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
274
275         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
276         https://bugs.webkit.org/show_bug.cgi?id=195053
277         <rdar://problem/48134710>
278
279         Reviewed by Ryosuke Niwa.
280
281         * WebCoreSupport/WebEditorClient.h:
282
283 2019-02-20  Darin Adler  <darin@apple.com>
284
285         Finish removing String::format
286         https://bugs.webkit.org/show_bug.cgi?id=194893
287
288         Reviewed by Daniel Bates.
289
290         * FullscreenVideoController.cpp:
291         (timeToString): Use makeString and pad.
292
293 2019-02-27  Simon Fraser  <simon.fraser@apple.com>
294
295         Roll out r242014; it caused crashes in compositing logging (webkit.org/b/195141)
296
297         * FullscreenVideoController.cpp:
298         (timeToString):
299
300 2019-02-26  Philippe Normand  <pnormand@igalia.com>
301
302         [WPE] Add API for webview background color configuration
303         https://bugs.webkit.org/show_bug.cgi?id=192305
304
305         Reviewed by Michael Catanzaro.
306
307         * WebCoreSupport/WebFrameLoaderClient.cpp:
308         (WebFrameLoaderClient::transitionToCommittedForNewPage): Create
309         FrameView with background color.
310
311 2019-02-20  Darin Adler  <darin@apple.com>
312
313         Finish removing String::format
314         https://bugs.webkit.org/show_bug.cgi?id=194893
315
316         Reviewed by Daniel Bates.
317
318         * FullscreenVideoController.cpp:
319         (timeToString): Use makeString and pad.
320
321 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
322
323         Input type "formatSetInlineTextDirection" is dispatched when changing paragraph-level text direction
324         https://bugs.webkit.org/show_bug.cgi?id=194703
325         <rdar://problem/48111775>
326
327         Reviewed by Ryosuke Niwa.
328
329         * WebCoreSupport/WebEditorClient.cpp:
330         (undoNameForEditAction):
331
332 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
333
334         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
335         https://bugs.webkit.org/show_bug.cgi?id=194670
336         <rdar://problem/39066529>
337
338         Reviewed by Tim Horton.
339
340         * WebCoreSupport/WebEditorClient.cpp:
341         (WebEditorClient::replacementURLForResource): Deleted.
342         * WebCoreSupport/WebEditorClient.h:
343
344 2019-02-10  Darin Adler  <darin@apple.com>
345
346         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
347         https://bugs.webkit.org/show_bug.cgi?id=194487
348
349         Reviewed by Daniel Bates.
350
351         * WebView.cpp:
352         (webKitVersionString): Use makeString instead of String::format.
353
354 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
355
356         Allow pages to trigger programmatic paste from script on iOS
357         https://bugs.webkit.org/show_bug.cgi?id=194271
358         <rdar://problem/47808810>
359
360         Reviewed by Ryosuke Niwa.
361
362         * WebCoreSupport/WebEditorClient.h:
363
364 2019-02-06  Daniel Bates  <dabates@apple.com>
365
366         Standardize on ControlKey instead of CtrlKey
367         https://bugs.webkit.org/show_bug.cgi?id=194317
368
369         Reviewed by Tim Horton.
370
371         * AccessibleBase.cpp:
372         (AccessibleBase::get_accKeyboardShortcut):
373         * WebView.cpp:
374         (WebView::keyDown):
375
376 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
377
378         PageOverlayController's layers should be created lazily
379         https://bugs.webkit.org/show_bug.cgi?id=194199
380         rdar://problem/46571593
381
382         Reviewed by Tim Horton.
383
384         Expose PageOverlayController::hasDocumentOverlays() and hasViewOverlays()
385         and use them to only parent the overlay-hosting layers when necessary.
386
387         For document overlays, RenderLayerCompositor::appendDocumentOverlayLayers() can
388         simply do nothing if there are none. Updates are triggered via Page::installedPageOverlaysChanged(),
389         which calls FrameView::setNeedsCompositingConfigurationUpdate() to trigger the root layer
390         compositing updates that parents the layerWithDocumentOverlays().
391
392         View overlays are added to the layer tree via the DrawingArea. When we go between having
393         none and some view overlays, Page::installedPageOverlaysChanged() calls attachViewOverlayGraphicsLayer()
394         on the ChromeClient, and the DrawingArea responds by calling updateRootLayers() and scheduling a
395         compositing flush (this has to be done manually because view overlay layers are outside the
396         subtree managed by RenderLayerCompositor).
397         
398         Now that GraphicsLayers are ref-counted, we can let the DrawingArea simply retain its m_viewOverlayRootLayer;
399         there is no need for RenderLayerCompositor::attachRootLayer()/detachRootLayer() to do anything with view
400         overlay layers. This implies that a page can navigate (new FrameView) and view overlays will persist, without
401         having to be manually removed and re-added. We can also remove the Frame argument to attachViewOverlayGraphicsLayer().
402
403         * WebCoreSupport/WebChromeClient.cpp:
404         (WebChromeClient::attachViewOverlayGraphicsLayer):
405         * WebCoreSupport/WebChromeClient.h:
406
407 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
408
409         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
410         https://bugs.webkit.org/show_bug.cgi?id=194189
411
412         Reviewed by Geoffrey Garen.
413
414         Pass the policy check identifier around functions and store it in WebFramePolicyListener
415         so that we can send it back to WebCore with the navigation policy decision.
416
417         * WebCoreSupport/WebFrameLoaderClient.cpp:
418         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
419         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
420         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
421         (WebFrameLoaderClient::dispatchWillSubmitForm):
422         (WebFrameLoaderClient::setUpPolicyListener):
423         * WebCoreSupport/WebFrameLoaderClient.h:
424
425 2019-01-31  Alex Christensen  <achristensen@webkit.org>
426
427         Revert r238819 which is unneeded and caused a performance regression.
428         https://bugs.webkit.org/show_bug.cgi?id=192272
429         <rdar://problem/46664625>
430
431         * WebCoreSupport/WebFrameLoaderClient.cpp:
432         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
433         * WebCoreSupport/WebFrameLoaderClient.h:
434
435 2019-01-31  Takashi Komori  <Takashi.Komori@sony.com>
436
437         [Curl] Fix DRT crash related to private browsing.
438         https://bugs.webkit.org/show_bug.cgi?id=193816
439
440         Reviewed by Alex Christensen.
441
442         * WebCoreSupport/WebFrameNetworkingContext.cpp:
443         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
444
445 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
446
447         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
448         https://bugs.webkit.org/show_bug.cgi?id=193941
449
450         Reviewed by Alex Christensen.
451
452         * Plugins/PluginMessageThrottlerWin.cpp:
453         * Plugins/PluginView.cpp:
454         * Plugins/PluginViewWin.cpp:
455
456 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
457
458         Move FileSystem to WTF
459         https://bugs.webkit.org/show_bug.cgi?id=193602
460
461         Reviewed by Yusuke Suzuki.
462
463         * Plugins/PluginDatabase.cpp:
464         * Plugins/PluginPackage.h:
465         * Plugins/PluginStream.h:
466         * WebApplicationCache.cpp:
467         * WebDatabaseManager.cpp:
468         * WebDownloadCurl.cpp:
469         * WebPreferences.cpp:
470         * WebView.cpp:
471
472 2019-01-22  Alex Christensen  <achristensen@webkit.org>
473
474         Move NetworkStorageSession ownership to NetworkProcess
475         https://bugs.webkit.org/show_bug.cgi?id=193580
476
477         Reviewed by Geoff Garen.
478
479         * WebCoreSupport/WebFrameNetworkingContext.cpp:
480         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
481         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
482         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
483         (WebFrameNetworkingContext::storageSession const):
484         * WebDownloadCFNet.cpp:
485         (WebDownload::didReceiveAuthenticationChallenge):
486         * WebPreferences.cpp:
487         (WebPreferences::clearNetworkLoaderSession):
488         (WebPreferences::switchNetworkLoaderToNewTestingSession):
489
490 2019-01-15  Darin Adler  <darin@apple.com>
491
492         Use references rather than pointers for register/unregister functions, and more
493         https://bugs.webkit.org/show_bug.cgi?id=175028
494
495         Reviewed by Daniel Bates.
496
497         * Plugins/PluginView.cpp:
498         (WebCore::PluginView::startOrAddToUnstartedList): Pass a reference.
499         (WebCore::PluginView::~PluginView): Ditto.
500         * WebView.cpp:
501         (WebView::fullScreenClientWillEnterFullScreen): Ditto.
502         (WebView::fullScreenClientDidEnterFullScreen): Ditto.
503         (WebView::fullScreenClientDidExitFullScreen): Ditto.
504
505 2019-01-17  Per Arne Vollan  <pvollan@apple.com>
506
507         [Win][HighDPI] Repaint glitches when scrolling.
508         https://bugs.webkit.org/show_bug.cgi?id=173152
509         <rdar://problem/45269953>
510
511         Reviewed by Brent Fulgham.
512
513         Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
514         delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
515         Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
516
517         * WebView.cpp:
518         (WebView::scrollBackingStore):
519
520 2019-01-17  Alex Christensen  <achristensen@webkit.org>
521
522         Stop using NetworkStorageSession::storageSession in WebCore
523         https://bugs.webkit.org/show_bug.cgi?id=193529
524
525         Reviewed by Tim Horton.
526
527         * WebView.cpp:
528         (WebView::initWithFrame):
529
530 2019-01-15  Alex Christensen  <achristensen@webkit.org>
531
532         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
533         https://bugs.webkit.org/show_bug.cgi?id=193368
534
535         Reviewed by Geoff Garen.
536
537         * WebDownloadCFNet.cpp:
538         (WebDownload::didReceiveAuthenticationChallenge):
539
540 2019-01-15  Alex Christensen  <achristensen@webkit.org>
541
542         Fix Windows build after r240014
543         https://bugs.webkit.org/show_bug.cgi?id=161106
544
545         * WebView.cpp:
546
547 2019-01-15  Alex Christensen  <achristensen@webkit.org>
548
549         Stop using CookiesStrategy
550         https://bugs.webkit.org/show_bug.cgi?id=161106
551
552         Reviewed by Don Olmstead and Antti Koivisto.
553
554         * Plugins/PluginView.cpp:
555         (WebCore::PluginView::getValueForURL):
556         (WebCore::PluginView::setValueForURL):
557         * WebCoreSupport/WebPlatformStrategies.cpp:
558         (WebPlatformStrategies::createBlobRegistry):
559         (WebPlatformStrategies::createCookiesStrategy): Deleted.
560         (WebPlatformStrategies::cookiesForDOM): Deleted.
561         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
562         (WebPlatformStrategies::cookiesEnabled): Deleted.
563         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
564         (WebPlatformStrategies::getRawCookies): Deleted.
565         (WebPlatformStrategies::deleteCookie): Deleted.
566         * WebCoreSupport/WebPlatformStrategies.h:
567         * WebView.cpp:
568         (WebView::initWithFrame):
569
570 2019-01-08  Alex Christensen  <achristensen@webkit.org>
571
572         Stop using NetworkStorageSession in WebProcess
573         https://bugs.webkit.org/show_bug.cgi?id=193236
574
575         Reviewed by Don Olmstead.
576
577         * WebCoreSupport/WebFrameNetworkingContext.cpp:
578         (WebFrameNetworkingContext::storageSession const):
579         * WebCoreSupport/WebFrameNetworkingContext.h:
580         * WebCoreSupport/WebPlatformStrategies.cpp:
581         (WebPlatformStrategies::cookiesForDOM):
582         (WebPlatformStrategies::setCookiesFromDOM):
583         (WebPlatformStrategies::cookiesEnabled):
584         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
585         (WebPlatformStrategies::getRawCookies):
586         (WebPlatformStrategies::deleteCookie):
587         * WebCoreSupport/WebPlatformStrategies.h:
588
589 2019-01-08  Alex Christensen  <achristensen@webkit.org>
590
591         Unreviewed, rolling out r239727.
592
593         Broke API tests
594
595         Reverted changeset:
596
597         "Stop using NetworkStorageSession in WebProcess"
598         https://bugs.webkit.org/show_bug.cgi?id=193236
599         https://trac.webkit.org/changeset/239727
600
601 2018-12-24  Fujii Hironori  <Hironori.Fujii@sony.com>
602
603         Remove "using namespace std;"
604         https://bugs.webkit.org/show_bug.cgi?id=192973
605
606         Reviewed by Alex Christensen.
607
608         * FullscreenVideoController.cpp:
609         * WebFrame.cpp:
610         (WebFrame::drawFooter):
611         * WebHistory.cpp:
612         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
613         * WebKitQuartzCoreAdditions/CAView.cpp:
614         * WebView.cpp:
615         (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
616         (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
617         (WebView::setCacheModel):
618         (WebView::maxCacheModelInAnyInstance):
619
620 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
621
622         Use Ref<> as much as possible
623         https://bugs.webkit.org/show_bug.cgi?id=192808
624
625         Reviewed by Alex Christensen.
626
627         * Plugins/PluginDatabase.cpp:
628         (WebCore::PluginDatabase::refresh):
629         * Plugins/PluginView.cpp:
630         (WebCore::PluginView::mediaCanStart):
631         (WebCore::PluginView::performRequest):
632         (WebCore::PluginView::bindingInstance):
633         * Plugins/PluginView.h:
634         * WebCoreSupport/WebFrameLoaderClient.cpp:
635         (WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
636         (WebFrameLoaderClient::createPlugin):
637         (WebFrameLoaderClient::createJavaAppletWidget):
638         * WebCoreSupport/WebFrameLoaderClient.h:
639         * WebFrame.cpp:
640         (WebFrame::loadData):
641         (WebFrame::loadPlainTextString):
642         (WebFrame::loadHTMLString):
643         * WebFrame.h:
644         * WebKitQuartzCoreAdditions/CAView.cpp:
645         (WKQCA::CAView::create):
646         * WebKitQuartzCoreAdditions/CAView.h:
647         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
648         (WKQCA::CVDisplayLink::create):
649         * WebKitQuartzCoreAdditions/CVDisplayLink.h:
650         * WebKitQuartzCoreAdditions/ImageConversion.cpp:
651         (WKQCA::getImageCopy):
652         * WebView.cpp:
653         (WebView::addUserScriptToGroup):
654         (WebView::addUserStyleSheetToGroup):
655
656 2018-12-20  Chris Dumez  <cdumez@apple.com>
657
658         Use Optional::valueOr() instead of Optional::value_or()
659         https://bugs.webkit.org/show_bug.cgi?id=192933
660
661         Reviewed by Geoffrey Garen.
662
663         * WebSecurityOrigin.cpp:
664         (WebSecurityOrigin::port):
665
666 2018-12-19  Chris Dumez  <cdumez@apple.com>
667
668         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
669         https://bugs.webkit.org/show_bug.cgi?id=192728
670         <rdar://problem/46746779>
671
672         Reviewed by Geoff Garen.
673
674         * Plugins/*:
675         * WebCoreSupport/*:
676
677 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
678
679         [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag
680         https://bugs.webkit.org/show_bug.cgi?id=192617
681
682         Reviewed by Alex Christensen.
683
684         * COMEnumVariant.h:
685         (COMEnumVariant<ContainerType>::adopt): Removed 'typename' from non dependent names.
686         (COMEnumVariant<ContainerType>::createInstance): Ditto.
687         (COMEnumVariant<ContainerType>::Next): Prepend 'typename' for dependent names.
688         * COMPropertyBag.h:
689         (HashType>::createInstance): Removed 'typename' from non dependent names.
690         (HashType>::adopt): Ditto.
691         (HashType>::Read): Replaced dependent name 'HashMapType::const_iterator' with 'auto'.
692         (HashType>::GetPropertyInfo): Ditto.
693
694 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
695
696         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
697         https://bugs.webkit.org/show_bug.cgi?id=192618
698
699         Reviewed by Alex Christensen.
700
701         Classes which implement COM interface usually doesn't need the
702         virtual destructor because it has Release() virtual method to
703         destruct itself.
704
705         Marked 'final' such classes to suppress clang-cl's compilation
706         warnings.
707
708         * COMEnumVariant.h:
709         * COMPropertyBag.h:
710         * DefaultDownloadDelegate.h:
711         * DefaultPolicyDelegate.h:
712         * MemoryStream.h:
713         * WebActionPropertyBag.h:
714         * WebApplicationCache.h:
715         * WebArchive.h:
716         * WebBackForwardList.h:
717         * WebCache.h:
718         * WebCoreStatistics.h:
719         * WebCoreSupport/WebEditorClient.cpp:
720         * WebCoreSupport/WebInspectorDelegate.h:
721         * WebDataSource.h:
722         * WebDatabaseManager.cpp:
723         * WebDatabaseManager.h:
724         * WebDownload.h:
725         * WebDropSource.h:
726         * WebElementPropertyBag.h:
727         * WebError.h:
728         * WebFrame.cpp:
729         * WebFrame.h:
730         * WebFramePolicyListener.h:
731         * WebGeolocationPolicyListener.h:
732         * WebGeolocationPosition.h:
733         * WebHTMLRepresentation.h:
734         * WebHistory.h:
735         * WebHistoryItem.h:
736         * WebInspector.h:
737         * WebJavaScriptCollector.h:
738         * WebKitClassFactory.h:
739         * WebKitMessageLoop.h:
740         * WebKitStatistics.h:
741         * WebMutableURLRequest.h:
742         * WebNavigationData.h:
743         * WebNotification.h:
744         * WebNotificationCenter.h:
745         * WebPreferences.h:
746         * WebResource.h:
747         * WebScriptWorld.h:
748         * WebSecurityOrigin.h:
749         * WebSerializedJSValue.h:
750         * WebTextRenderer.h:
751         * WebURLAuthenticationChallenge.h:
752         * WebURLAuthenticationChallengeSender.h:
753         * WebURLCredential.h:
754         * WebURLProtectionSpace.h:
755         * WebURLResponse.h:
756         * WebUserContentURLPattern.h:
757         * WebView.cpp:
758         * WebView.h:
759         * WebWorkersPrivate.h:
760
761 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
762
763         [Win][Clang] Fix warning -Wmissing-field-initializers
764         https://bugs.webkit.org/show_bug.cgi?id=192584
765
766         Reviewed by Yusuke Suzuki.
767
768         Initialize a struct with '{ }' instead of '= {0}'.
769
770         * WebKitMessageLoop.cpp:
771         (WebKitMessageLoop::run):
772         * WebView.cpp:
773         (WebView::onMenuCommand):
774         (WebView::gesture):
775         (WebView::setShouldInvertColors):
776         (WebView::initializeToolTipWindow):
777         (WebView::setToolTip):
778         (WebView::fullScreenClientForceRepaint):
779
780 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
781
782         Turn WritingDirection into an enum class
783         https://bugs.webkit.org/show_bug.cgi?id=192401
784         Work towards <rdar://problem/42075638>
785
786         Reviewed by Dan Bernstein.
787
788         Change WritingDirection from an enum to an enum class. No change in behavior.
789
790         * WebFrame.cpp:
791         (WebFrame::setTextDirection):
792
793 2018-12-03  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
794
795         Use WallTime for file time
796         https://bugs.webkit.org/show_bug.cgi?id=192287
797
798         Reviewed by Darin Adler.
799
800         * Plugins/PluginDatabase.cpp:
801         (WebCore::PluginDatabase::refresh):
802
803 2018-11-30  Alex Christensen  <achristensen@webkit.org>
804
805         Fix Windows build.
806
807         * WebView.cpp:
808
809 2018-11-30  Alex Christensen  <achristensen@webkit.org>
810
811         Fix Windows build.
812
813         * WebCoreSupport/WebFrameLoaderClient.h:
814
815 2018-11-30  Alex Christensen  <achristensen@webkit.org>
816
817         Fix Windows build.
818
819         * WebCoreSupport/WebFrameLoaderClient.h:
820
821 2018-11-30  Alex Christensen  <achristensen@webkit.org>
822
823         Move URL from WebCore to WTF
824         https://bugs.webkit.org/show_bug.cgi?id=190234
825
826         Reviewed by Keith Miller.
827
828         * MarshallingHelpers.cpp:
829         * MarshallingHelpers.h:
830         * Plugins/PluginDatabase.cpp:
831         * Plugins/PluginDatabase.h:
832         * Plugins/PluginDatabaseWin.cpp:
833         * Plugins/PluginStream.h:
834         * Plugins/PluginView.h:
835         * WebCoreSupport/WebContextMenuClient.h:
836         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
837         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
838         * WebCoreSupport/WebFrameLoaderClient.h:
839         * WebCoreSupport/WebPlatformStrategies.h:
840         * WebCoreSupport/WebPluginInfoProvider.cpp:
841         (WebPluginInfoProvider::webVisiblePluginInfo):
842         * WebCoreSupport/WebPluginInfoProvider.h:
843         * WebCoreSupport/WebVisitedLinkStore.h:
844         * WebDataSource.cpp:
845         * WebDownload.h:
846         * WebElementPropertyBag.cpp:
847         * WebFrame.h:
848         * WebHistory.cpp:
849         * WebHistory.h:
850         * WebHistoryItem.cpp:
851         * WebResource.cpp:
852         (WebResource::WebResource):
853         * WebResource.h:
854         * WebSecurityOrigin.cpp:
855         * WebURLResponse.cpp:
856         (WebURLResponse::createInstance):
857         * WebUserContentURLPattern.cpp:
858         * WebView.h:
859
860 2018-11-28  Alex Christensen  <achristensen@webkit.org>
861
862         Remove dead code from an earlier attempt at implementing safe browsing
863         https://bugs.webkit.org/show_bug.cgi?id=192067
864
865         Reviewed by Chris Dumez.
866
867         * WebCoreSupport/WebFrameLoaderClient.cpp:
868         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
869         * WebCoreSupport/WebFrameLoaderClient.h:
870
871 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
872
873         [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
874         https://bugs.webkit.org/show_bug.cgi?id=191959
875
876         Reviewed by Alex Christensen.
877
878         * MarshallingHelpers.h: Removed extra "MarshallingHelpers::" of windowsEpochAbsoluteTime declaration.
879
880 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
881
882         [Win] Reduce the use of WKSI library calls: CoreAnimation
883         https://bugs.webkit.org/show_bug.cgi?id=191777
884         <rdar://problem/46140542>
885
886         Reviewed by Zalan Bujtas.
887
888         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
889         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
890         directives for WebKitSystemInterface.lib.
891
892         * FullscreenVideoController.cpp:
893         * WebKitGraphics.cpp:
894         * WebPreferences.cpp:
895
896 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
897
898         Address post-review feedback after r238438
899         https://bugs.webkit.org/show_bug.cgi?id=191913
900
901         Reviewed by Ryosuke Niwa.
902
903         * AccessibleTextImpl.cpp:
904         (AccessibleText::replaceText):
905
906 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
907
908         Web Inspector: "Reload Web Inspector" button no longer partially works
909         https://bugs.webkit.org/show_bug.cgi?id=191773
910         <rdar://problem/46139932>
911
912         Reviewed by Devin Rousso.
913
914         * WebCoreSupport/WebInspectorClient.cpp:
915         (WebInspectorFrontendClient::reopen):
916         * WebCoreSupport/WebInspectorClient.h:
917
918 2018-11-17  Devin Rousso  <drousso@apple.com>
919
920         Web Inspector: Network: add button to show system certificate dialog
921         https://bugs.webkit.org/show_bug.cgi?id=191458
922         <rdar://problem/45977019>
923
924         Reviewed by Joseph Pecoraro.
925
926         * WebCoreSupport/WebInspectorClient.h:
927         * WebCoreSupport/WebInspectorClient.cpp:
928         (WebInspectorFrontendClient::showCertificate): Added.
929
930 2018-11-16  Brent Fulgham  <bfulgham@apple.com>
931
932         [Win] Reduce the use of WKSI library calls: CFNetwork
933         https://bugs.webkit.org/show_bug.cgi?id=191718
934         <rdar://problem/46108732>
935
936         Reviewed by Alex Christensen.
937
938         Remove custom WKSI CFNetwork calls, since the SPI is already documented in PAL. Just
939         make the same calls on Windows, like we did for iOS and macOS back in 2017.
940
941         * WebCache.cpp:
942         (WebCache::cacheFolder):
943         * WebCoreSupport/WebFrameNetworkingContext.cpp:
944         * WebCoreSupport/WebPlatformStrategies.cpp:
945         * WebError.cpp:
946         (WebError::localizedDescription):
947         (WebError::sslPeerCertificate):
948         * WebURLResponse.cpp:
949         (WebURLResponse::sslPeerCertificate):
950         (WebURLResponse::certificateDictionary const):
951         * WebView.cpp:
952         (WebView::setCacheModel):
953
954 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
955
956         [Win] Reduce the use of WKSI library calls: Font Handling
957         https://bugs.webkit.org/show_bug.cgi?id=191701
958         <rdar://problem/46104809>
959
960         Reviewed by Myles C. Maxfield.
961
962         Update to use the old font handling routines moved from WKSI to FontCascade.
963
964         * WebPreferences.cpp:
965         (WebPreferences::setFontSmoothing):
966         (WebPreferences::setFontSmoothingContrast):
967         * WebView.cpp:
968         (systemParameterChanged):
969
970 2018-11-14  Timothy Hatcher  <timothy@apple.com>
971
972         Default the view background color and text color to different values when in dark mode.
973         https://bugs.webkit.org/show_bug.cgi?id=191607
974         rdar://problem/46045854
975
976         Reviewed by Dean Jackson.
977
978         * WebFrame.cpp:
979         (WebFrame::updateBackground): Drop backgroundColor.
980         * WebCoreSupport/WebFrameLoaderClient.cpp:
981         (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor.
982
983 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
984
985         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
986         https://bugs.webkit.org/show_bug.cgi?id=191612
987
988         Reviewed by Matt Baker.
989
990         * WebCoreSupport/WebInspectorClient.cpp:
991         (WebInspectorFrontendClient::destroyInspectorView):
992
993 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
994
995         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
996         https://bugs.webkit.org/show_bug.cgi?id=189230
997         <rdar://problem/44050379>
998
999         Reviewed by Joseph Pecoraro.
1000
1001         Runs all png images through zopflipng. This results in a smaller file
1002         size and takes care of this issue as a byproduct.
1003
1004         * WebKit.resources/deleteButton.png:
1005         * WebKit.resources/deleteButtonPressed.png:
1006         * WebKit.resources/fsVideoAudioVolumeHigh.png:
1007         * WebKit.resources/fsVideoAudioVolumeLow.png:
1008         * WebKit.resources/fsVideoExitFullscreen.png:
1009         * WebKit.resources/fsVideoPause.png:
1010         * WebKit.resources/fsVideoPlay.png:
1011         * WebKit.resources/missingImage.png:
1012         * WebKit.resources/nullplugin.png:
1013         * WebKit.resources/panEastCursor.png:
1014         * WebKit.resources/panIcon.png:
1015         * WebKit.resources/panNorthCursor.png:
1016         * WebKit.resources/panNorthEastCursor.png:
1017         * WebKit.resources/panNorthWestCursor.png:
1018         * WebKit.resources/panSouthCursor.png:
1019         * WebKit.resources/panSouthEastCursor.png:
1020         * WebKit.resources/panSouthWestCursor.png:
1021         * WebKit.resources/panWestCursor.png:
1022         * WebKit.resources/searchCancel.png:
1023         * WebKit.resources/searchCancelPressed.png:
1024         * WebKit.resources/searchMagnifier.png:
1025         * WebKit.resources/searchMagnifierResults.png:
1026         * WebKit.resources/textAreaResizeCorner.png:
1027         * WebKit.resources/verticalTextCursor.png:
1028         * WebKit.resources/zoomInCursor.png:
1029         * WebKit.resources/zoomOutCursor.png:
1030
1031 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1032
1033         Unreviewed Windows build fix for r238049.
1034
1035         * WebView.cpp:
1036         (WebView::initWithFrame):
1037
1038 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1039
1040         Unreviewed MSVC build fix after r238039 (and r238046).
1041
1042         * WebDocumentLoader.h:
1043         * WebView.cpp:
1044         (WebView::setShouldApplyMacFontAscentHack):
1045
1046 2018-11-09  Antti Koivisto  <antti@apple.com>
1047
1048         Use OptionSet for layout milestones
1049         https://bugs.webkit.org/show_bug.cgi?id=191470
1050
1051         Reviewed by Dean Jackson.
1052
1053         * WebCoreSupport/WebFrameLoaderClient.cpp:
1054         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1055         * WebCoreSupport/WebFrameLoaderClient.h:
1056
1057 2018-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1058
1059         WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1060         https://bugs.webkit.org/show_bug.cgi?id=191455
1061
1062         Reviewed by Brent Fulgham.
1063
1064         * WebHistory.h: Marked with 'override' and removed 'virtual'.
1065
1066 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1067
1068         Add a storage limit for IndexedDB
1069         https://bugs.webkit.org/show_bug.cgi?id=190598
1070         <rdar://problem/44654715>
1071
1072         Reviewed by Chris Dumez.
1073
1074         * Interfaces/IWebDatabaseManager.idl:
1075         * WebDatabaseManager.cpp:
1076         (WebDatabaseManager::setIDBPerOriginQuota):
1077         * WebDatabaseManager.h:
1078
1079 2018-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1080
1081         [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
1082         https://bugs.webkit.org/show_bug.cgi?id=191105
1083
1084         Reviewed by Brent Fulgham.
1085
1086         * DOMHTMLClasses.h:
1087         (DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
1088         instead of own setNodeValue.
1089
1090 2018-10-25  Antoine Quint  <graouts@apple.com>
1091
1092         [Web Animations] Turn Web Animations CSS Integration off by default
1093         https://bugs.webkit.org/show_bug.cgi?id=190901
1094
1095         Reviewed by Dean Jackson.
1096
1097         * WebPreferences.cpp:
1098         (WebPreferences::initializeDefaultSettings):
1099
1100 2018-10-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1101
1102         [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1103         https://bugs.webkit.org/show_bug.cgi?id=190744
1104
1105         Reviewed by Alex Christensen.
1106
1107         clang-cl reports compilation warnings for inconsistent 'override'
1108         keyword usage.
1109
1110         WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
1111         This can't be marked 'override' if !USE(CA).
1112
1113         * WebView.cpp:
1114         (WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).
1115         * WebView.h: Marked all overriding member function declarations of WebView 'override'.
1116         Declare flushPendingGraphicsLayerChanges only if USE(CA).
1117
1118 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1119
1120         Clean up FrameLoader two-state enums
1121         https://bugs.webkit.org/show_bug.cgi?id=190731
1122
1123         Reviewed by Chris Dumez.
1124
1125         * WebCoreSupport/WebFrameLoaderClient.cpp:
1126         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1127         * WebCoreSupport/WebFrameLoaderClient.h:
1128
1129 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1130
1131         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1132         https://bugs.webkit.org/show_bug.cgi?id=190675
1133
1134         Reviewed by Chris Dumez.
1135
1136         * BackForwardList.cpp:
1137         (BackForwardList::backItem):
1138         (BackForwardList::currentItem):
1139         (BackForwardList::forwardItem):
1140         (BackForwardList::backListCount const):
1141         (BackForwardList::forwardListCount const):
1142         (BackForwardList::itemAtIndex):
1143         * BackForwardList.h:
1144
1145 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
1146
1147         Unreviewed attempt to fix the Windows build after r237112.
1148
1149         * Plugins/PluginView.cpp:
1150         (WebCore::PluginView::performRequest):
1151
1152 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1153
1154         Replace HistoryItem* with HistoryItem& where possible
1155         https://bugs.webkit.org/show_bug.cgi?id=190617
1156
1157         Reviewed by Chris Dumez.
1158
1159         * BackForwardList.cpp:
1160         (BackForwardList::goToItem):
1161         * BackForwardList.h:
1162         * WebBackForwardList.cpp:
1163         (WebBackForwardList::goToItem):
1164
1165 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1166
1167         Fix Windows build.
1168
1169         * WebView.cpp:
1170         (WebView::loadBackForwardListFromOtherView):
1171
1172 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1173
1174         Fix WinCairo build.
1175
1176         * WebView.cpp:
1177         (WebView::backForwardList):
1178
1179 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1180
1181         Modernize BackForwardClient.h
1182         https://bugs.webkit.org/show_bug.cgi?id=190610
1183
1184         Reviewed by Chris Dumez.
1185
1186         * BackForwardList.cpp:
1187         (BackForwardList::backListCount const):
1188         (BackForwardList::forwardListCount const):
1189         (BackForwardList::backListCount): Deleted.
1190         (BackForwardList::forwardListCount): Deleted.
1191         * BackForwardList.h:
1192         * WebView.cpp:
1193         (WebView::initWithFrame):
1194         (WebView::backForwardList):
1195
1196 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1197
1198         Remove unused WebView._globalHistoryItem
1199         https://bugs.webkit.org/show_bug.cgi?id=190601
1200
1201         Reviewed by Chris Dumez.
1202
1203         * WebCoreSupport/WebFrameLoaderClient.cpp:
1204         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1205         * WebCoreSupport/WebFrameLoaderClient.h:
1206         * WebView.cpp:
1207         (WebView::globalHistoryItem):
1208         (WebView::setGlobalHistoryItem): Deleted.
1209         * WebView.h:
1210
1211 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1212
1213         Remove unused parameters from FrameLoaderClient::createFrame
1214         https://bugs.webkit.org/show_bug.cgi?id=190587
1215
1216         Reviewed by Chris Dumez.
1217
1218         * WebCoreSupport/WebFrameLoaderClient.cpp:
1219         (WebFrameLoaderClient::createFrame):
1220         * WebCoreSupport/WebFrameLoaderClient.h:
1221
1222 2018-10-15  Chris Dumez  <cdumez@apple.com>
1223
1224         Unreviewed Windows build fix after r237112.
1225
1226         * Plugins/PluginView.cpp:
1227         (WebCore::PluginView::performRequest):
1228         (WebCore::PluginView::load):
1229
1230 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1231
1232         Remove InjectedBundle processing of back/forward lists
1233         https://bugs.webkit.org/show_bug.cgi?id=190459
1234
1235         Reviewed by Chris Dumez.
1236
1237         * WebCoreSupport/WebFrameLoaderClient.cpp:
1238         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1239         * WebCoreSupport/WebFrameLoaderClient.h:
1240
1241 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1242
1243         Remove ParsedURLString
1244         https://bugs.webkit.org/show_bug.cgi?id=190154
1245
1246         Reviewed by Chris Dumez.
1247
1248         * WebDownloadCurl.cpp:
1249         (WebDownload::initWithRequest):
1250         * WebURLResponse.cpp:
1251         (WebURLResponse::createInstance):
1252
1253 2018-09-28  Chris Dumez  <cdumez@apple.com>
1254
1255         Drop support for cross-origin-window-policy header
1256         https://bugs.webkit.org/show_bug.cgi?id=190081
1257
1258         Reviewed by Ryosuke Niwa.
1259
1260         * WebPreferenceKeysPrivate.h:
1261         * WebPreferences.cpp:
1262         (WebPreferences::initializeDefaultSettings):
1263         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1264         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1265         * WebView.cpp:
1266         (WebView::notifyPreferencesChanged):
1267
1268 2018-09-27  Antoine Quint  <graouts@apple.com>
1269
1270         [Web Animations] Turn Web Animations with CSS integration on
1271         https://bugs.webkit.org/show_bug.cgi?id=184819
1272         <rdar://problem/39597337>
1273
1274         Reviewed by Dean Jackson.
1275
1276         * WebPreferences.cpp:
1277         (WebPreferences::initializeDefaultSettings):
1278
1279 2018-09-21  Alex Christensen  <achristensen@webkit.org>
1280
1281         Use a Variant for FormDataElement
1282         https://bugs.webkit.org/show_bug.cgi?id=189777
1283
1284         Reviewed by Chris Dumez.
1285
1286         * WebMutableURLRequest.cpp:
1287         (WebMutableURLRequest::setHTTPBody):
1288
1289 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1290
1291         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
1292         https://bugs.webkit.org/show_bug.cgi?id=189612
1293
1294         Reviewed by Alex Christensen.
1295
1296         Non-trivial types can't be used as aruguments of LOG_ERROR and
1297         ASSERT_WITH_MESSAGE.
1298
1299         * DefaultPolicyDelegate.cpp:
1300         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
1301         static_cast<BSTR> to convert BString.
1302         * WebLocalizableStrings.cpp:
1303         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
1304         char* by using 'key.utf8().data()'.
1305
1306 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
1307
1308         Unreviewed, rolling out r235953.
1309
1310         Caused layout test crashes under GuardMalloc.
1311
1312         Reverted changeset:
1313
1314         "Make GraphicsLayers ref-counted, so their tree can persist
1315         when disconnected from RenderLayerBackings"
1316         https://bugs.webkit.org/show_bug.cgi?id=189521
1317         https://trac.webkit.org/changeset/235953
1318
1319 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1320
1321         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
1322         https://bugs.webkit.org/show_bug.cgi?id=189538
1323
1324         Reviewed by Per Arne Vollan.
1325
1326         * WebPreferences.cpp:
1327         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
1328         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
1329         Apply static_cast to the result of OR-ed CFPropertyListFormat.
1330         (WebPreferences::screenFontSubstitutionEnabled):
1331         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
1332
1333 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1334
1335         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
1336         https://bugs.webkit.org/show_bug.cgi?id=189539
1337
1338         Reviewed by Alex Christensen.
1339
1340         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
1341         * WebCoreSupport/WebInspectorClient.cpp:
1342         (WebInspectorWndProc): Ditto.
1343         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
1344         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
1345
1346 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1347
1348         Refactor WebCore::EditAction to be an 8-bit enum class
1349         https://bugs.webkit.org/show_bug.cgi?id=189383
1350
1351         Reviewed by Dan Bernstein.
1352
1353         * WebCoreSupport/WebEditorClient.cpp:
1354         (undoNameForEditAction):
1355
1356 2018-09-04  Frederic Wang  <fwang@igalia.com>
1357
1358         Add basic support for ScrollIntoViewOptions
1359         https://bugs.webkit.org/show_bug.cgi?id=189258
1360
1361         Reviewed by Simon Fraser.
1362
1363         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
1364         can build despite the new scrollIntoView function.
1365
1366 2018-08-31  Chris Dumez  <cdumez@apple.com>
1367
1368         Unreviewed Windows build fix after r235562.
1369
1370         * WebCoreSupport/WebFrameLoaderClient.cpp:
1371         (WebFrameLoaderClient::dispatchWillSubmitForm):
1372
1373 2018-08-31  Chris Dumez  <cdumez@apple.com>
1374
1375         Assertion hit in ~CompletionHandler() from ~WebFrame()
1376         https://bugs.webkit.org/show_bug.cgi?id=189199
1377         <rdar://problem/42657233>
1378
1379         Reviewed by Youenn Fablet.
1380
1381         * WebCoreSupport/WebFrameLoaderClient.cpp:
1382         (WebFrameLoaderClient::dispatchWillSubmitForm):
1383         * WebCoreSupport/WebFrameLoaderClient.h:
1384
1385 2018-08-31  Frederic Wang  <fwang@igalia.com>
1386
1387         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1388         https://bugs.webkit.org/show_bug.cgi?id=182053
1389
1390         Reviewed by Simon Fraser.
1391
1392         Add developer flag to use standard behavior for scrolling* attributes.
1393
1394         * Interfaces/IWebPreferencesPrivate.idl:
1395         * WebPreferenceKeysPrivate.h:
1396         * WebPreferences.cpp:
1397         (WebPreferences::initializeDefaultSettings):
1398         (WebPreferences::CSSOMViewScrollingAPIEnabled):
1399         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
1400         * WebPreferences.h:
1401         * WebView.cpp:
1402         (WebView::notifyPreferencesChanged):
1403
1404 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
1405
1406         [CMake] Replace AVFoundationSupport.py using CMake
1407         https://bugs.webkit.org/show_bug.cgi?id=182891
1408
1409         Reviewed by Per Arne Vollan.
1410
1411         Remove references to the config.h contained in WebCore as it should
1412         not be accessible from outside of WebCore.
1413
1414         * WebKitPrefix.h:
1415
1416 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1417
1418         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
1419         https://bugs.webkit.org/show_bug.cgi?id=188496
1420         <rdar://problem/43216836>
1421
1422         Reviewed by Tim Horton.
1423
1424         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
1425         header directly.
1426
1427         * WebCoreSupport/WebDragClient.cpp:
1428
1429 2018-08-17  Alex Christensen  <achristensen@webkit.org>
1430
1431         Add some plumbing for safe browsing
1432         https://bugs.webkit.org/show_bug.cgi?id=188709
1433
1434         Reviewed by Tim Horton.
1435
1436         * WebCoreSupport/WebFrameLoaderClient.cpp:
1437         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1438         * WebCoreSupport/WebFrameLoaderClient.h:
1439
1440 2018-08-02  David Fenton  <david_fenton@apple.com>
1441
1442         Unreviewed, rolling out r234489.
1443
1444         Caused 50+ crashes and 60+ API failures on iOS
1445
1446         Reverted changeset:
1447
1448         "[WTF] Rename String::format to String::deprecatedFormat"
1449         https://bugs.webkit.org/show_bug.cgi?id=188191
1450         https://trac.webkit.org/changeset/234489
1451
1452 2018-08-01  Tomas Popela  <tpopela@redhat.com>
1453
1454         [WTF] Rename String::format to String::deprecatedFormat
1455         https://bugs.webkit.org/show_bug.cgi?id=188191
1456
1457         Reviewed by Darin Adler.
1458
1459         It should be replaced with string concatenation.
1460
1461         * FullscreenVideoController.cpp:
1462         (timeToString):
1463         * WebView.cpp:
1464         (webKitVersionString):
1465
1466 2018-07-30  Rob Buis  <rbuis@igalia.com>
1467
1468         https://bugs.webkit.org/show_bug.cgi?id=188137
1469         Merge PlatformCookieJar functions into NetworkStorageSession
1470
1471         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1472
1473         Reviewed by Alex Christensen.
1474
1475         * WebCoreSupport/WebPlatformStrategies.cpp:
1476         (WebPlatformStrategies::cookiesForDOM):
1477         (WebPlatformStrategies::setCookiesFromDOM):
1478         (WebPlatformStrategies::cookiesEnabled):
1479         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1480         (WebPlatformStrategies::getRawCookies):
1481         (WebPlatformStrategies::deleteCookie):
1482         * WebPreferences.cpp:
1483         (WebPreferences::clearNetworkLoaderSession):
1484
1485 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
1486
1487         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
1488         https://bugs.webkit.org/show_bug.cgi?id=187963
1489
1490         Reviewed by Alex Christensen.
1491
1492         * Plugins/PluginPackageWin.cpp:
1493         (WebCore::PluginPackage::fetchInfo):
1494         Update split/splitAllowingEmptyEntries usage.
1495
1496 2018-07-18  Antoine Quint  <graouts@apple.com>
1497
1498         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
1499         https://bugs.webkit.org/show_bug.cgi?id=187722
1500
1501         Reviewed by Myles Maxfield.
1502
1503         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
1504
1505         * DOMCoreClasses.cpp:
1506         (DOMElement::font):
1507
1508 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1509
1510         Disable cross-origin-window-policy by default
1511         https://bugs.webkit.org/show_bug.cgi?id=187509
1512
1513         Reviewed by Chris Dumez.
1514
1515         * WebPreferences.cpp:
1516         (WebPreferences::initializeDefaultSettings):
1517
1518 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1519
1520         [WTF] Add user-defined literal for ASCIILiteral
1521         https://bugs.webkit.org/show_bug.cgi?id=186839
1522
1523         Reviewed by Darin Adler.
1524
1525         * Plugins/PluginStream.cpp:
1526         (WebCore::PluginStream::startStream):
1527         * WebCoreSupport/WebContextMenuClient.cpp:
1528         (WebContextMenuClient::searchWithGoogle):
1529
1530 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1531
1532         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
1533         https://bugs.webkit.org/show_bug.cgi?id=186623
1534
1535         Reviewed by Youenn Fablet.
1536
1537         * WebCoreSupport/WebPluginInfoProvider.cpp:
1538         (WebPluginInfoProvider::pluginInfo):
1539         (WebPluginInfoProvider::webVisiblePluginInfo):
1540         * WebCoreSupport/WebPluginInfoProvider.h:
1541
1542 2018-06-13  Chris Dumez  <cdumez@apple.com>
1543
1544         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1545         https://bugs.webkit.org/show_bug.cgi?id=186545
1546
1547         Reviewed by Brady Eidson.
1548
1549         Update client delegate now that parameter type has changed.
1550
1551         * WebCoreSupport/WebFrameLoaderClient.cpp:
1552         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1553         * WebCoreSupport/WebFrameLoaderClient.h:
1554
1555 2018-06-11  Chris Dumez  <cdumez@apple.com>
1556
1557         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
1558         https://bugs.webkit.org/show_bug.cgi?id=186441
1559
1560         Reviewed by Brady Eidson.
1561
1562         Rename existing flag to something a bit more generic, now that it is used for
1563         more things than bypassing the navigation policy check.
1564
1565         * WebView.cpp:
1566         (WebView::goToBackForwardItem):
1567         (WebView::loadBackForwardListFromOtherView):
1568
1569 2018-06-04  Chris Dumez  <cdumez@apple.com>
1570
1571         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
1572         https://bugs.webkit.org/show_bug.cgi?id=186287
1573         <rdar://problem/40783352>
1574
1575         Reviewed by Youenn Fablet.
1576
1577         * Interfaces/IWebPreferencesPrivate.idl:
1578         * WebPreferenceKeysPrivate.h:
1579         * WebPreferences.cpp:
1580         (WebPreferences::initializeDefaultSettings):
1581         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1582         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1583         * WebPreferences.h:
1584         * WebView.cpp:
1585         (WebView::notifyPreferencesChanged):
1586
1587 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1588
1589         [JSC] Pass VM& parameter as much as possible
1590         https://bugs.webkit.org/show_bug.cgi?id=186085
1591
1592         Reviewed by Saam Barati.
1593
1594         * Plugins/PluginPackage.cpp:
1595         (WebCore::NPN_Invoke):
1596
1597 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1598
1599         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
1600         https://bugs.webkit.org/show_bug.cgi?id=186125
1601
1602         Unreviewed build fix
1603
1604         * WebActionPropertyBag.cpp:
1605         (WebActionPropertyBag::Read):
1606         (findMouseEvent): Deleted.
1607
1608 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1609
1610         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
1611         https://bugs.webkit.org/show_bug.cgi?id=186027
1612
1613         Unreviewed build fix
1614
1615         * WebMutableURLRequest.cpp:
1616         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
1617         (WebMutableURLRequest::setClientCertificate):
1618
1619 2018-05-25  Chris Dumez  <cdumez@apple.com>
1620
1621         Minor ApplicationCacheStorage clean up
1622         https://bugs.webkit.org/show_bug.cgi?id=185984
1623
1624         Reviewed by Youenn Fablet.
1625
1626         * WebApplicationCache.cpp:
1627         (WebApplicationCache::originsWithCache):
1628
1629 2018-05-24  Chris Dumez  <cdumez@apple.com>
1630
1631         Reduce copying of FontCascadeDescription objects by moving them around
1632         https://bugs.webkit.org/show_bug.cgi?id=185963
1633
1634         Reviewed by Simon Fraser.
1635
1636         Reduce copying of FontCascadeDescription objects by moving them around when possible.
1637
1638         * FullscreenVideoController.cpp:
1639         (FullscreenVideoController::draw):
1640
1641 2018-05-15  Antoine Quint  <graouts@apple.com>
1642
1643         [Web Animations] Expose Web Animations CSS integration as an experimental feature
1644         https://bugs.webkit.org/show_bug.cgi?id=185647
1645
1646         Reviewed by Dean Jackson.
1647
1648         Rename the Web Animations CSS integration flag.
1649
1650         * Interfaces/IWebPreferencesPrivate.idl:
1651         * WebPreferenceKeysPrivate.h:
1652         * WebPreferences.cpp:
1653         (WebPreferences::initializeDefaultSettings):
1654         (WebPreferences::webAnimationsCSSIntegrationEnabled):
1655         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
1656         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1657         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1658         * WebPreferences.h:
1659         * WebView.cpp:
1660         (WebView::notifyPreferencesChanged):
1661
1662 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1663
1664         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
1665         https://bugs.webkit.org/show_bug.cgi?id=185505
1666
1667         Unreviewed serious crash fix
1668
1669         Windows port crashes soon since Bug 184996.
1670
1671         * WebPreferences.cpp:
1672         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
1673         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
1674
1675 2018-05-07  Daniel Bates  <dabates@apple.com>
1676
1677         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
1678         https://bugs.webkit.org/show_bug.cgi?id=185170
1679
1680         Reviewed by Per Arne Vollan.
1681
1682         * WebCache.cpp:
1683         (WebCache::empty):
1684
1685 2018-04-27  Chris Dumez  <cdumez@apple.com>
1686
1687         Use WindowProxy instead of DOMWindow in our IDL
1688         https://bugs.webkit.org/show_bug.cgi?id=185022
1689
1690         Reviewed by Sam Weinig.
1691
1692         * DOMCoreClasses.cpp:
1693         (DOMDocument::getComputedStyle):
1694
1695 2018-04-23  Daniel Bates  <dabates@apple.com>
1696
1697         Implement Same-Site cookies
1698         https://bugs.webkit.org/show_bug.cgi?id=159464
1699         <rdar://problem/27196358>
1700
1701         Reviewed by Brent Fulgham.
1702
1703         Pass the Same-Site info through the strategy.
1704
1705         * WebCoreSupport/WebPlatformStrategies.cpp:
1706         (WebPlatformStrategies::cookiesForDOM):
1707         (WebPlatformStrategies::setCookiesFromDOM):
1708         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1709         (WebPlatformStrategies::getRawCookies):
1710         * WebCoreSupport/WebPlatformStrategies.h:
1711
1712 2018-04-23  Daniel Bates  <dabates@apple.com>
1713
1714         Implement Same-Site cookies
1715         https://bugs.webkit.org/show_bug.cgi?id=159464
1716         <rdar://problem/27196358>
1717
1718         Reviewed by Brent Fulgham.
1719
1720         Pass the Same-Site info through the strategy.
1721
1722         * WebCoreSupport/WebPlatformStrategies.cpp:
1723         (WebPlatformStrategies::cookiesForDOM):
1724         (WebPlatformStrategies::setCookiesFromDOM):
1725         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1726         (WebPlatformStrategies::getRawCookies):
1727         * WebCoreSupport/WebPlatformStrategies.h:
1728
1729 2018-04-20  Youenn Fablet  <youenn@apple.com>
1730
1731         Make PluginData cache its web visible plugins
1732         https://bugs.webkit.org/show_bug.cgi?id=184421
1733
1734         Reviewed by Chris Dumez.
1735
1736         * WebCoreSupport/WebPluginInfoProvider.cpp:
1737         (WebPluginInfoProvider::pluginInfo):
1738         (WebPluginInfoProvider::webVisiblePluginInfo):
1739         * WebCoreSupport/WebPluginInfoProvider.h:
1740
1741 2018-04-19  Chris Dumez  <cdumez@apple.com>
1742
1743         Rename JSDOMWindowProxy to JSWindowProxy
1744         https://bugs.webkit.org/show_bug.cgi?id=184797
1745
1746         Reviewed by Sam Weinig.
1747
1748         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
1749
1750         * WebFrame.cpp:
1751         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
1752
1753 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
1754
1755         Unreviewed rollout of r230632. Regression in memory usage.
1756
1757         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
1758
1759         * WebPreferences.cpp:
1760         (WebPreferences::initializeDefaultSettings):
1761
1762 2018-04-17  Chris Dumez  <cdumez@apple.com>
1763
1764         Unreviewed attempt to fix the Windows build after r230721
1765
1766         * WebCoreSupport/WebFrameLoaderClient.cpp:
1767         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1768
1769 2018-04-17  Chris Dumez  <cdumez@apple.com>
1770
1771         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
1772         https://bugs.webkit.org/show_bug.cgi?id=184678
1773         <rdar://problem/39422122>
1774
1775         Reviewed by Alex Christensen.
1776
1777         Add new parameter to dispatchDecidePolicyForNavigationAction.
1778
1779         * WebCoreSupport/WebFrameLoaderClient.cpp:
1780         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1781         * WebCoreSupport/WebFrameLoaderClient.h:
1782
1783 2018-04-12  Antoine Quint  <graouts@apple.com>
1784
1785         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
1786         https://bugs.webkit.org/show_bug.cgi?id=184569
1787         <rdar://problem/38671301>
1788
1789         Reviewed by Jon Lee.
1790
1791         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
1792
1793         * WebPreferences.cpp:
1794
1795 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1796
1797         [WTF] Remove StaticLock
1798         https://bugs.webkit.org/show_bug.cgi?id=184332
1799
1800         Reviewed by Mark Lam.
1801
1802         * WebKitQuartzCoreAdditions/CAView.cpp:
1803         (WKQCA::CAView::releaseAllD3DResources):
1804         * WebLocalizableStrings.cpp:
1805
1806 2018-04-03  Chris Dumez  <cdumez@apple.com>
1807
1808         Drop MainFrame class
1809         https://bugs.webkit.org/show_bug.cgi?id=184191
1810
1811         Reviewed by Darin Adler.
1812
1813         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
1814         relationship between the Page and the MainFrame.
1815
1816         This is ground work for introducing LocalFrame / RemoteFrame concepts.
1817
1818         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1819         * WebCoreSupport/WebContextMenuClient.cpp:
1820         * WebCoreSupport/WebDragClient.cpp:
1821         * WebDropSource.cpp:
1822         * WebFrame.cpp:
1823         * WebView.cpp:
1824
1825 2018-03-26  Chris Dumez  <cdumez@apple.com>
1826
1827         Use SecurityOriginData more consistently in Service Worker code
1828         https://bugs.webkit.org/show_bug.cgi?id=183969
1829
1830         Reviewed by Darin Adler.
1831
1832         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
1833
1834         * WebDatabaseManager.cpp:
1835         (WebDatabaseManager::databasesWithOrigin):
1836         (WebDatabaseManager::deleteOrigin):
1837         (WebDatabaseManager::deleteDatabase):
1838         (WebDatabaseManager::setQuota):
1839         * WebSecurityOrigin.cpp:
1840         (WebSecurityOrigin::usage):
1841         (WebSecurityOrigin::quota):
1842         (WebSecurityOrigin::setQuota):
1843
1844 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
1845
1846         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
1847         https://bugs.webkit.org/show_bug.cgi?id=183911
1848         <rdar://problem/38762306>
1849
1850         Reviewed by Youenn Fablet.
1851
1852         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
1853
1854         * WebView.cpp:
1855         (WebView::WebView):
1856
1857 2018-03-25  Commit Queue  <commit-queue@webkit.org>
1858
1859         Unreviewed, rolling out r229954.
1860         https://bugs.webkit.org/show_bug.cgi?id=184000
1861
1862         Caused many layout tests to crash on Apple High Sierra,
1863         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
1864         by dydz on #webkit).
1865
1866         Reverted changeset:
1867
1868         "Use SecurityOriginData more consistently in Service Worker
1869         code"
1870         https://bugs.webkit.org/show_bug.cgi?id=183969
1871         https://trac.webkit.org/changeset/229954
1872
1873 2018-03-24  Chris Dumez  <cdumez@apple.com>
1874
1875         Use SecurityOriginData more consistently in Service Worker code
1876         https://bugs.webkit.org/show_bug.cgi?id=183969
1877
1878         Reviewed by Darin Adler.
1879
1880         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
1881
1882         * WebDatabaseManager.cpp:
1883         (WebDatabaseManager::databasesWithOrigin):
1884         (WebDatabaseManager::deleteOrigin):
1885         (WebDatabaseManager::deleteDatabase):
1886         (WebDatabaseManager::setQuota):
1887         * WebSecurityOrigin.cpp:
1888         (WebSecurityOrigin::usage):
1889         (WebSecurityOrigin::quota):
1890         (WebSecurityOrigin::setQuota):
1891
1892 2018-03-23  Chris Dumez  <cdumez@apple.com>
1893
1894         Unreviewed attempt to fix Windows build after r229926.
1895
1896         * WebView.cpp:
1897
1898 2018-03-23  Brady Eidson  <beidson@apple.com>
1899
1900         Go to back/forward list items after a process-swapped navigation.
1901         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
1902
1903         Reviewed by Andy Estes.
1904
1905         * WebView.cpp:
1906         (WebView::goToBackForwardItem):
1907         (WebView::loadBackForwardListFromOtherView):
1908
1909 2018-03-23  Miguel Gomez  <magomez@igalia.com>
1910
1911         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
1912         https://bugs.webkit.org/show_bug.cgi?id=183892
1913
1914         Remove the UpdateContentsFlag parameter as it's not used anymore.
1915
1916         Reviewed by Žan Doberšek.
1917
1918         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1919         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
1920
1921 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
1922
1923         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
1924         https://bugs.webkit.org/show_bug.cgi?id=183335
1925
1926         Reviewed by Alex Christensen.
1927
1928         * Plugins/PluginDatabaseWin.cpp:
1929         * Plugins/PluginMessageThrottlerWin.cpp:
1930         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
1931         * Plugins/PluginPackageWin.cpp:
1932         (WebCore::PluginPackage::load):
1933         * Plugins/PluginView.h:
1934         * Plugins/PluginViewWin.cpp:
1935         * Plugins/npapi.cpp:
1936         * WebCoreSupport/WebFrameLoaderClient.cpp:
1937         (WebFrameLoaderClient::createPlugin):
1938         (WebFrameLoaderClient::createJavaAppletWidget):
1939         * WebView.cpp:
1940         (WebView::WebViewWndProc):
1941
1942 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
1943
1944         [Win] Layout Test fast/html/menuitem-element.html is failing.
1945         https://bugs.webkit.org/show_bug.cgi?id=179299
1946
1947         Reviewed by Per Arne Vollan.
1948
1949         * Interfaces/IWebPreferencesPrivate.idl:
1950         * WebPreferenceKeysPrivate.h:
1951         * WebPreferences.cpp:
1952         (WebPreferences::menuItemElementEnabled):
1953         (WebPreferences::setMenuItemElementEnabled):
1954         * WebPreferences.h:
1955         * WebView.cpp:
1956         (WebView::notifyPreferencesChanged):
1957         Add private web preference "menuItemElementEnabled".
1958
1959 2018-03-12  Antoine Quint  <graouts@apple.com>
1960
1961         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
1962         https://bugs.webkit.org/show_bug.cgi?id=183504
1963         <rdar://problem/38372965>
1964
1965         Reviewed by Dean Jackson and Jon Lee.
1966
1967         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
1968         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
1969
1970         * Interfaces/IWebPreferencesPrivate.idl:
1971         * WebPreferences.cpp:
1972         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
1973         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
1974         * WebPreferenceKeysPrivate.h
1975         * WebPreferences.h:
1976         * WebView.cpp:
1977         (WebView::notifyPreferencesChanged):
1978
1979 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1980
1981         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
1982         https://bugs.webkit.org/show_bug.cgi?id=183429
1983
1984         Reviewed by Mark Lam.
1985
1986         * WebFrame.cpp:
1987         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
1988
1989 2018-03-08  Tim Horton  <timothy_horton@apple.com>
1990
1991         Stop linking ApplicationServices directly
1992         https://bugs.webkit.org/show_bug.cgi?id=182867
1993         <rdar://problem/38252142>
1994
1995         Reviewed by Alex Christensen.
1996
1997         The frameworks that we use that live inside ApplicationServices
1998         have mostly moved out, so import them directly.
1999
2000         * FullscreenVideoController.cpp:
2001
2002 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2003
2004         Fix std::make_unique / new[] using system malloc
2005         https://bugs.webkit.org/show_bug.cgi?id=182975
2006
2007         Reviewed by JF Bastien.
2008
2009         Use Vector instead.
2010
2011         * MarshallingHelpers.cpp:
2012         (MarshallingHelpers::safeArrayToStringArray):
2013         (MarshallingHelpers::safeArrayToIntArray):
2014         * Plugins/PluginPackageWin.cpp:
2015         (WebCore::PluginPackage::fetchInfo):
2016         * WebPreferences.cpp:
2017         (WebPreferences::copyWebKitPreferencesToCFPreferences):
2018         * WebView.cpp:
2019         (WebView::onMenuCommand):
2020
2021 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2022
2023         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
2024         https://bugs.webkit.org/show_bug.cgi?id=183312
2025
2026         Reviewed by Mark Lam.
2027
2028         Remove wtf/CurrentTime.h include pragma.
2029
2030         * WebDownload.cpp:
2031         * WebDownloadCFNet.cpp:
2032         * WebDropSource.cpp:
2033
2034 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2035
2036         Remove monotonicallyIncreasingTime
2037         https://bugs.webkit.org/show_bug.cgi?id=182911
2038
2039         Reviewed by Michael Catanzaro.
2040
2041         * FullscreenVideoController.cpp:
2042         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
2043         * Plugins/PluginMessageThrottlerWin.cpp:
2044         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
2045         (WebCore::PluginMessageThrottlerWin::appendMessage):
2046         * Plugins/PluginMessageThrottlerWin.h:
2047         * WebView.cpp:
2048         (WebView::notifyAnimationStarted):
2049         * WebView.h:
2050
2051 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2052
2053         [Win][DRT] Implement setSpatialNavigationEnabled.
2054         https://bugs.webkit.org/show_bug.cgi?id=183166
2055
2056         Reviewed by Per Arne Vollan.
2057
2058         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
2059
2060         * Interfaces/IWebPreferencesPrivate.idl:
2061         * WebPreferenceKeysPrivate.h:
2062         * WebPreferences.cpp:
2063         (WebPreferences::initializeDefaultSettings):
2064         (WebPreferences::spatialNavigationEnabled):
2065         (WebPreferences::setSpatialNavigationEnabled):
2066         * WebPreferences.h:
2067         * WebView.cpp:
2068         (WebView::notifyPreferencesChanged):
2069
2070 2018-02-28  Alex Christensen  <achristensen@webkit.org>
2071
2072         Reduce use of NetworkingContext in WebKit
2073         https://bugs.webkit.org/show_bug.cgi?id=183213
2074
2075         Reviewed by Brady Eidson.
2076
2077         * Plugins/PluginView.cpp:
2078         (WebCore::PluginView::getValueForURL):
2079
2080 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
2081
2082         Fix WebCore includes within WebKitLegacy
2083         https://bugs.webkit.org/show_bug.cgi?id=183147
2084
2085         Reviewed by Tim Horton.
2086
2087         * Plugins/PluginDatabase.cpp:
2088         * Plugins/PluginDatabaseWin.cpp:
2089         * Plugins/PluginDebug.cpp:
2090         * Plugins/PluginDebug.h:
2091         * Plugins/PluginMainThreadScheduler.cpp:
2092         * Plugins/PluginMessageThrottlerWin.cpp:
2093         * Plugins/PluginMessageThrottlerWin.h:
2094         * Plugins/PluginPackage.cpp:
2095         * Plugins/PluginPackage.h:
2096         * Plugins/PluginPackageWin.cpp:
2097         * Plugins/PluginStream.cpp:
2098         * Plugins/PluginStream.h:
2099         * Plugins/PluginView.cpp:
2100         * Plugins/PluginView.h:
2101         * Plugins/PluginViewWin.cpp:
2102         * Plugins/npapi.cpp:
2103         * WebCoreSupport/WebChromeClient.cpp:
2104         * WebCoreSupport/WebContextMenuClient.cpp:
2105         * WebCoreSupport/WebFrameLoaderClient.cpp:
2106         * WebCoreSupport/WebInspectorClient.cpp:
2107         * WebCoreSupport/WebPlatformStrategies.cpp:
2108         * WebFrame.cpp:
2109         * WebKitMessageLoop.cpp:
2110         * WebView.cpp:
2111         * storage/WebDatabaseProvider.cpp:
2112
2113 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2114
2115         Remove currentTime() / currentTimeMS()
2116         https://bugs.webkit.org/show_bug.cgi?id=183052
2117
2118         Reviewed by Mark Lam.
2119
2120         * WebCoreSupport/WebFrameLoaderClient.cpp:
2121         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2122         * WebCoreSupport/WebFrameLoaderClient.h:
2123         * WebDownload.h:
2124         * WebDownloadCFNet.cpp:
2125         (WebDownload::didStart):
2126         (WebDownload::didReceiveData):
2127         (WebDownload::didFinish):
2128
2129 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
2130
2131         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
2132         https://bugs.webkit.org/show_bug.cgi?id=182883
2133
2134         Reviewed by Per Arne Vollan.
2135
2136         * WebKitPrefix.h:
2137
2138 2018-02-16  Dean Jackson  <dino@apple.com>
2139
2140         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
2141         https://bugs.webkit.org/show_bug.cgi?id=182894
2142
2143         Reviewed by Tim Horton.
2144
2145         Rename OPENGL_ES_2 to OPENGL_ES.
2146
2147         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2148
2149 2018-02-16  Youenn Fablet  <youenn@apple.com>
2150
2151         Allow specifying which plug-ins are supported
2152         https://bugs.webkit.org/show_bug.cgi?id=182748
2153
2154         Reviewed by Chris Dumez.
2155
2156         * WebCoreSupport/WebPluginInfoProvider.cpp:
2157         (WebPluginInfoProvider::getPluginInfo):
2158         * WebCoreSupport/WebPluginInfoProvider.h:
2159
2160 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
2161
2162         WebCore headers should not be included relatively within dependent projects
2163         https://bugs.webkit.org/show_bug.cgi?id=182805
2164
2165         Reviewed by Chris Dumez.
2166
2167         * FullscreenVideoController.h:
2168
2169 2018-02-13  Commit Queue  <commit-queue@webkit.org>
2170
2171         Unreviewed, rolling out r228431.
2172         https://bugs.webkit.org/show_bug.cgi?id=182766
2173
2174         Regressed CMake build stability (Requested by dolmstead on
2175         #webkit).
2176
2177         Reverted changeset:
2178
2179         "[CMake] Make WebCore headers copies"
2180         https://bugs.webkit.org/show_bug.cgi?id=182512
2181         https://trac.webkit.org/changeset/228431
2182
2183 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
2184
2185         [CMake] Make WebCore headers copies
2186         https://bugs.webkit.org/show_bug.cgi?id=182512
2187
2188         Reviewed by Keith Miller.
2189
2190         * FullscreenVideoController.h:
2191         * Plugins/PluginDatabase.cpp:
2192         * Plugins/PluginDatabaseWin.cpp:
2193         * Plugins/PluginDebug.cpp:
2194         * Plugins/PluginMainThreadScheduler.cpp:
2195         * Plugins/PluginMessageThrottlerWin.cpp:
2196         * Plugins/PluginPackage.cpp:
2197         * Plugins/PluginPackageWin.cpp:
2198         * Plugins/PluginStream.cpp:
2199         * Plugins/PluginView.cpp:
2200         * Plugins/PluginViewWin.cpp:
2201         * Plugins/npapi.cpp:
2202         * WebKitMessageLoop.cpp:
2203         * WebKitPrefix.h:
2204         * storage/WebDatabaseProvider.cpp:
2205
2206 2018-01-13  Darin Adler  <darin@apple.com>
2207
2208         Event improvements
2209         https://bugs.webkit.org/show_bug.cgi?id=179591
2210
2211         Reviewed by Chris Dumez.
2212
2213         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
2214         * WebFrame.cpp: Ditto.
2215
2216         * WebScriptWorld.cpp:
2217         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
2218
2219         * WebView.cpp: Removed include of ScriptValue.h.
2220         (WebView::handleEditingKeyboardEvent): Updated for name change from
2221         keyEvent to underlyingPlatformEvent.
2222
2223 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
2224
2225         Remove WebCore/ForwardingHeaders directory
2226         https://bugs.webkit.org/show_bug.cgi?id=182347
2227
2228         Reviewed by Keith Miller.
2229
2230         * Plugins/PluginView.cpp:
2231         * Plugins/PluginViewWin.cpp:
2232         * WebCoreSupport/WebInspectorClient.cpp:
2233         * WebCoreSupport/WebInspectorClient.h:
2234         * WebFrame.cpp:
2235         * WebJavaScriptCollector.cpp:
2236         * WebView.cpp:
2237
2238 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2239
2240         Unreviewed, another attempt to fix the Windows build after r227479.
2241
2242         * WebFrame.cpp:
2243         (WebFrame::elementWithName):
2244
2245 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2246
2247         Unreviewed, try to fix the Windows build after r227479.
2248
2249         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
2250
2251         * WebFrame.cpp:
2252         (WebFrame::elementWithName):
2253         (WebFrame::controlsInForm):
2254
2255 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
2256
2257         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
2258         https://bugs.webkit.org/show_bug.cgi?id=181859
2259         <rdar://problem/36659886>
2260
2261         Reviewed by Alex Christensen.
2262         
2263         Use local include patch.
2264
2265         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
2266         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
2267         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
2268
2269 2018-01-17  Youenn Fablet  <youenn@apple.com>
2270
2271         Put fetch Request.keepalive behind a runtime flag
2272         https://bugs.webkit.org/show_bug.cgi?id=181592
2273
2274         Reviewed by Chris Dumez.
2275
2276         * WebPreferences.cpp:
2277         (WebPreferences::fetchAPIKeepAliveEnabled):
2278         (WebPreferences::setFetchAPIKeepAliveEnabled):
2279         * WebPreferences.h:
2280         * WebView.cpp:
2281         (WebView::notifyPreferencesChanged):
2282
2283 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2284
2285         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2286         https://bugs.webkit.org/show_bug.cgi?id=181637
2287         <rdar://problem/36508471>
2288
2289         Reviewed by Tim Horton.
2290
2291         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
2292
2293         * WebCoreSupport/WebEditorClient.cpp:
2294         (WebEditorClient::replacementURLForResource):
2295         * WebCoreSupport/WebEditorClient.h:
2296
2297 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2298
2299         Remove std::chrono completely
2300         https://bugs.webkit.org/show_bug.cgi?id=181186
2301
2302         Reviewed by Alex Christensen.
2303
2304         * Plugins/PluginStream.cpp:
2305         (WebCore::lastModifiedDateMS):
2306
2307 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2308
2309         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
2310         https://bugs.webkit.org/show_bug.cgi?id=181173
2311
2312         Reviewed by Alex Christensen.
2313
2314         * WebNodeHighlight.cpp:
2315         (WebNodeHighlight::update): Scale the GraphicsContext.
2316
2317 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2318
2319         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
2320         https://bugs.webkit.org/show_bug.cgi?id=181160
2321
2322         Reviewed by Myles C. Maxfield.
2323
2324         * Plugins/PluginView.cpp:
2325         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
2326
2327 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2328
2329         Enable picture-in-picture from inline element on suspend.
2330         https://bugs.webkit.org/show_bug.cgi?id=180942
2331         rdar://problem/34745234
2332
2333         Reviewed by Jer Noble.
2334
2335         Update signature of enterVideoFullscreenForVideoElement.
2336
2337         * WebCoreSupport/WebChromeClient.cpp:
2338         (WebChromeClient::enterVideoFullscreenForVideoElement):
2339         * WebCoreSupport/WebChromeClient.h:
2340
2341 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2342
2343         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
2344         https://bugs.webkit.org/show_bug.cgi?id=180926
2345
2346         Reviewed by Tim Horton.
2347
2348         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
2349         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
2350
2351         * WebCoreSupport/WebFrameLoaderClient.cpp:
2352         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
2353         (WebFrameLoaderClient::pageID const): Ditto.
2354
2355 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2356
2357         Remove unnecessary boolean result of start() functions
2358         https://bugs.webkit.org/show_bug.cgi?id=180856
2359
2360         Reviewed by Darin Adler.
2361
2362         It always returns true.
2363
2364         * WebDownloadCurl.cpp:
2365         (WebDownload::start):
2366
2367 2017-12-14  John Wilander  <wilander@apple.com>
2368
2369         Storage Access API: Implement frame-specific access in the document.cookie layer
2370         https://bugs.webkit.org/show_bug.cgi?id=180682
2371         <rdar://problem/35982257>
2372
2373         Reviewed by Alex Christensen.
2374
2375         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
2376         CookiesStrategy::cookieRequestHeaderFieldValue(), and
2377         CookiesStrategy::getRawCookies() now take optional parameters for
2378         frameID and pageID to allow frame-specific scoping of cookies.
2379
2380         This change makes the return values of FrameLoaderClient::frameID()
2381         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
2382         WebCore can call those getters and get the right return values in
2383         WebKit and std:nullopt in WebKitLegacy.
2384
2385         * WebCoreSupport/WebFrameLoaderClient.cpp:
2386         (WebFrameLoaderClient::pageID const):
2387         (WebFrameLoaderClient::frameID const):
2388             Now return an optional.
2389         * WebCoreSupport/WebFrameLoaderClient.h:
2390         * WebCoreSupport/WebPlatformStrategies.cpp:
2391         (WebPlatformStrategies::cookiesForDOM):
2392         (WebPlatformStrategies::setCookiesFromDOM):
2393         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2394         (WebPlatformStrategies::getRawCookies):
2395         * WebCoreSupport/WebPlatformStrategies.h:
2396
2397 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2398
2399         [WTF] Thread::create should have Thread::tryCreate
2400         https://bugs.webkit.org/show_bug.cgi?id=180333
2401
2402         Reviewed by Darin Adler.
2403
2404         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
2405         (WKQCA::CVDisplayLink::start):
2406
2407 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2408
2409         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
2410         https://bugs.webkit.org/show_bug.cgi?id=180572
2411
2412         Reviewed by Mark Lam.
2413
2414         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
2415         Also we use Lock instead of Mutex.
2416
2417         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
2418         (WKQCA::CAD3DRenderer::swapChain):
2419         (WKQCA::CAD3DRenderer::renderAndPresent):
2420         (WKQCA::CAD3DRenderer::renderToImage):
2421         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2422         (WKQCA::CAD3DRenderer::renderInternal):
2423         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
2424         * WebKitQuartzCoreAdditions/CAView.cpp:
2425         (WKQCA::CAView::Handle::create):
2426         Return Ref<Handle> instead of RefPtr<>.
2427
2428         (WKQCA::CAView::Handle::lock):
2429         (WKQCA::CAView::Handle::view const):
2430         (WKQCA::CAView::Handle::clear):
2431         (WKQCA::views):
2432         (WKQCA::viewsNeedingUpdate):
2433         (WKQCA::CAView::releaseAllD3DResources):
2434         (WKQCA::CAView::CAView):
2435         (WKQCA::CAView::~CAView):
2436         (WKQCA::CAView::setLayer):
2437         (WKQCA::CAView::update):
2438         (WKQCA::CAView::drawToWindow):
2439         (WKQCA::CAView::drawToWindowInternal):
2440         (WKQCA::CAView::drawToImage):
2441         (WKQCA::CAView::willDraw):
2442         (WKQCA::CAView::drawIntoDC):
2443         (WKQCA::CAView::setShouldInvertColors):
2444         (WKQCA::CAView::scheduleNextDraw):
2445         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2446         (WKQCA::CAView::contextDidChange):
2447         (WKQCA::CAView::updateSoon):
2448         (WKQCA::CAView::updateViewsNow):
2449         (WKQCA::CAView::d3dDevice9):
2450         (WKQCA::CAView::Handle::mutex): Deleted.
2451         (WKQCA::globalStateMutex): Deleted.
2452         (): Deleted.
2453         * WebKitQuartzCoreAdditions/CAView.h:
2454
2455 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2456
2457         Use StaticLock instead of NeverDestroyed<Lock>
2458         https://bugs.webkit.org/show_bug.cgi?id=180507
2459
2460         Reviewed by Saam Barati.
2461
2462         * WebLocalizableStrings.cpp:
2463         (findCachedString):
2464         (cacheString):
2465         (mainBundleLocStrings): Deleted.
2466         (frameworkLocStringsMutex): Deleted.
2467
2468 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
2469
2470         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
2471         https://bugs.webkit.org/show_bug.cgi?id=180431
2472         <rdar://problem/34531264>
2473
2474         Reviewed by Simon Fraser.
2475
2476         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
2477         'override' to make sure this doesn't break in the future.
2478
2479         * WebView.cpp:
2480         (WebView::notifyAnimationStarted):
2481         (WebView::paintContents):
2482         * WebView.h:
2483
2484 2017-11-23  Darin Adler  <darin@apple.com>
2485
2486         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2487         https://bugs.webkit.org/show_bug.cgi?id=179981
2488
2489         Reviewed by Sam Weinig.
2490
2491         * WebView.cpp:
2492         (WebView::searchFor): Use |= instead of | to build FindOptions.
2493         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
2494         (WebView::findString): Create FindOptions with |=; the old code just passed a
2495         WebKit FindOptions through without converting to WebCore::FindOptions.
2496
2497 2017-11-23  Darin Adler  <darin@apple.com>
2498
2499         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2500         https://bugs.webkit.org/show_bug.cgi?id=179907
2501
2502         Reviewed by Sam Weinig.
2503
2504         * Plugins/PluginDatabaseWin.cpp:
2505         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
2506         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
2507         * WebDownloadCFNet.cpp:
2508         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
2509
2510         * WebView.cpp:
2511         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
2512         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
2513         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
2514         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
2515         the code does not cause any change in behavior.
2516
2517 2017-11-22  Ali Juma  <ajuma@chromium.org>
2518
2519         Implement VisualViewport API attributes
2520         https://bugs.webkit.org/show_bug.cgi?id=179385
2521
2522         Reviewed by Frédéric Wang.
2523
2524         Add a VisualViewportAPI preference.
2525
2526         * Interfaces/IWebPreferencesPrivate.idl:
2527         * WebPreferenceKeysPrivate.h:
2528         * WebPreferences.cpp:
2529         (WebPreferences::initializeDefaultSettings):
2530         (WebPreferences::visualViewportAPIEnabled):
2531         (WebPreferences::setVisualViewportAPIEnabled):
2532         * WebPreferences.h:
2533         * WebView.cpp:
2534         (WebView::notifyPreferencesChanged):
2535
2536 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2537
2538         Unreviewed, rolling out r225093.
2539         https://bugs.webkit.org/show_bug.cgi?id=179938
2540
2541         Compilation failed on WinCairo 64-bit Release (Requested by
2542         fredw on #webkit).
2543
2544         Reverted changeset:
2545
2546         "Implement VisualViewport API attributes"
2547         https://bugs.webkit.org/show_bug.cgi?id=179385
2548         https://trac.webkit.org/changeset/225093
2549
2550 2017-11-21  Ali Juma  <ajuma@chromium.org>
2551
2552         Implement VisualViewport API attributes
2553         https://bugs.webkit.org/show_bug.cgi?id=179385
2554
2555         Reviewed by Frédéric Wang.
2556
2557         Add a VisualViewportAPI preference.
2558
2559         * Interfaces/IWebPreferencesPrivate.idl:
2560         * WebPreferenceKeysPrivate.h:
2561         * WebPreferences.cpp:
2562         (WebPreferences::initializeDefaultSettings):
2563         (WebPreferences::visualViewportAPIEnabled):
2564         (WebPreferences::setVisualViewportAPIEnabled):
2565         * WebPreferences.h:
2566         * WebView.cpp:
2567         (WebView::notifyPreferencesChanged):
2568
2569 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2570
2571         Clean up old URL parser remnants
2572         https://bugs.webkit.org/show_bug.cgi?id=179573
2573
2574         Reviewed by Darin Adler.
2575
2576         * WebCoreSupport/WebContextMenuClient.cpp:
2577         (WebContextMenuClient::searchWithGoogle):
2578         Use https if we do end up searching with google.
2579
2580 2017-11-12  Darin Adler  <darin@apple.com>
2581
2582         More is<> and downcast<>, less static_cast<>
2583         https://bugs.webkit.org/show_bug.cgi?id=179600
2584
2585         Reviewed by Chris Dumez.
2586
2587         * WebView.cpp:
2588         (WebView::handleEditingKeyboardEvent): Use downcast.
2589
2590 2017-11-09  Christopher Reid  <chris.reid@sony.com>
2591
2592         Use enum classes within FileSystem
2593         https://bugs.webkit.org/show_bug.cgi?id=175172
2594
2595         Reviewed by Darin Adler.
2596
2597         * Plugins/PluginDatabase.cpp:
2598
2599 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
2600
2601         [Win] Add WebKitQuartzCoreAdditions library.
2602         https://bugs.webkit.org/show_bug.cgi?id=179331
2603
2604         Reviewed by Alex Christensen.
2605
2606         * WebKitQuartzCoreAdditions: Added.
2607         * WebKitQuartzCoreAdditions/API: Added.
2608         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
2609         (toImage):
2610         (WKCACFImageGetWidth):
2611         (WKCACFImageGetHeight):
2612         (WKCACFImageCopyFileMapping):
2613         (WKCACFImageCreateWithImage):
2614         (WKCACFImageFinalize):
2615         (WKCACFImageCopyFormattingDescription):
2616         (WKCACFImageCopyDebugDescription):
2617         (WKCACFImageGetTypeID):
2618         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
2619         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
2620         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
2621         (toView):
2622         (toImpl):
2623         (WKCACFViewCreate):
2624         (WKCACFViewSetLayer):
2625         (WKCACFViewUpdate):
2626         (WKCACFViewFlushContext):
2627         (WKCACFViewInvalidateRects):
2628         (WKCACFViewCanDraw):
2629         (WKCACFViewDraw):
2630         (WKCACFViewCopyDrawnImage):
2631         (WKCACFViewDrawIntoDC):
2632         (contextDidChangeCallback):
2633         (WKCACFViewSetContextDidChangeCallback):
2634         (WKCACFViewGetLastCommitTime):
2635         (WKCACFViewSetContextUserData):
2636         (WKCACFViewGetContext):
2637         (WKCACFViewFinalize):
2638         (WKCACFViewCopyFormattingDescription):
2639         (WKCACFViewCopyDebugDescription):
2640         (WKCACFViewGetTypeID):
2641         (WKCACFViewSetShouldInvertColors):
2642         (WKCACFViewGetD3DDevice9):
2643         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
2644         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
2645         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
2646         (WKQCA::dllInstance):
2647         (DllMain):
2648         (WKCACFShutDown):
2649         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
2650         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
2651         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
2652         (WKQCA::d3d):
2653         (WKQCA::initialPresentationParameters):
2654         (WKQCA::CAD3DRenderer::shared):
2655         (WKQCA::CAD3DRenderer::CAD3DRenderer):
2656         (WKQCA::CAD3DRenderer::swapChain):
2657         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
2658         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
2659         (WKQCA::CAD3DRenderer::initialize):
2660         (WKQCA::D3DMatrixOrthoOffCenterRH):
2661         (WKQCA::prepareDevice):
2662         (WKQCA::updateBounds):
2663         (WKQCA::CAD3DRenderer::renderAndPresent):
2664         (WKQCA::CAD3DRenderer::renderToImage):
2665         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2666         (WKQCA::CAD3DRenderer::renderInternal):
2667         (WKQCA::CAD3DRenderer::postProcess):
2668         (WKQCA::CAD3DRenderer::resetD3DDevice):
2669         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
2670         (WKQCA::CAD3DRenderer::release):
2671         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
2672         (WKQCA::D3DPostProcessingContext::sceneTexture const):
2673         (WKQCA::D3DPostProcessingContext::overlayQuad const):
2674         (WKQCA::CAD3DRenderer::d3dDevice9 const):
2675         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
2676         (WKQCA::CAView::Handle::create):
2677         (WKQCA::CAView::Handle::~Handle):
2678         (WKQCA::CAView::Handle::mutex):
2679         (WKQCA::CAView::Handle::view const):
2680         (WKQCA::CAView::Handle::clear):
2681         (WKQCA::CAView::Handle::Handle):
2682         (WKQCA::globalStateMutex):
2683         (WKQCA::registerMessageWindowClass):
2684         (WKQCA::createMessageWindow):
2685         (WKQCA::CAView::releaseAllD3DResources):
2686         (WKQCA::CAView::CAView):
2687         (WKQCA::CAView::~CAView):
2688         (WKQCA::CAView::create):
2689         (WKQCA::CAView::setContextDidChangeCallback):
2690         (WKQCA::CAView::setLayer):
2691         (WKQCA::CAView::update):
2692         (WKQCA::CAView::invalidateRects):
2693         (WKQCA::CAView::drawToWindow):
2694         (WKQCA::CAView::drawToWindowInternal):
2695         (WKQCA::CAView::drawToImage):
2696         (WKQCA::CAView::willDraw):
2697         (WKQCA::CAView::didDraw):
2698         (WKQCA::CAView::drawIntoDC):
2699         (WKQCA::CAView::setShouldInvertColors):
2700         (WKQCA::CAView::scheduleNextDraw):
2701         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2702         (WKQCA::CAView::contextDidChangeCallback):
2703         (WKQCA::CAView::contextDidChange):
2704         (WKQCA::CAView::updateSoon):
2705         (WKQCA::CAView::updateViewsNow):
2706         (WKQCA::CAView::d3dDevice9):
2707         * WebKitQuartzCoreAdditions/CAView.h: Added.
2708         (WKQCA::CAView::context const):
2709         (WKQCA::CAView::canDraw const):
2710         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
2711         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
2712         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
2713         (WKQCA::CVDisplayLink::CVDisplayLink):
2714         (WKQCA::CVDisplayLink::~CVDisplayLink):
2715         (WKQCA::CVDisplayLink::create):
2716         (WKQCA::CVDisplayLink::start):
2717         (WKQCA::CVDisplayLink::stop):
2718         (WKQCA::CVDisplayLink::setPaused):
2719         (WKQCA::CVDisplayLink::runIOThread):
2720         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
2721         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
2722         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
2723         * WebKitQuartzCoreAdditions/Image.cpp: Added.
2724         (WKQCA::numBytesForSize):
2725         (WKQCA::Image::create):
2726         (WKQCA::Image::Image):
2727         (WKQCA::Image::~Image):
2728         (WKQCA::bitmapInfo):
2729         (WKQCA::Image::createDIB const):
2730         (WKQCA::Image::copyFileMapping):
2731         * WebKitQuartzCoreAdditions/Image.h: Added.
2732         (WKQCA::Image::size const):
2733         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
2734         (WKQCA::getBackBufferRectAsRenderTarget):
2735         (WKQCA::getSystemMemoryCopy):
2736         (WKQCA::copyRectToBitmap):
2737         (WKQCA::getImageCopy):
2738         (WKQCA::getBackBufferRectAsImage):
2739         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
2740         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
2741         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
2742         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
2743         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
2744
2745 2017-11-06  Christopher Reid  <chris.reid@sony.com>
2746
2747         Use enum classes within FileSystem
2748         https://bugs.webkit.org/show_bug.cgi?id=175172
2749
2750         Reviewed by Myles C. Maxfield.
2751
2752         * Plugins/PluginDatabase.cpp:
2753
2754 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
2755
2756         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
2757         https://bugs.webkit.org/show_bug.cgi?id=178333
2758
2759         Reviewed by Darin Adler.
2760
2761         * WebCoreSupport/WebFrameLoaderClient.cpp:
2762         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
2763
2764 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2765
2766         Use CompletionHandlers for redirects
2767         https://bugs.webkit.org/show_bug.cgi?id=179163
2768
2769         Reviewed by Tim Horton.
2770
2771         * Plugins/PluginStream.cpp:
2772         (WebCore::PluginStream::willSendRequest):
2773         * Plugins/PluginStream.h:
2774         (WebCore::PluginStreamClient::~PluginStreamClient):
2775         (WebCore::PluginStreamClient::streamDidFinishLoading):
2776         (WebCore::PluginStream::create):
2777         (WebCore::PluginStream::setLoadManually):
2778
2779 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2780
2781         Add a FileSystem namespace to FileSystem.cpp
2782         https://bugs.webkit.org/show_bug.cgi?id=179063
2783
2784         Reviewed by Darin Adler.
2785
2786         * Plugins/PluginDatabase.cpp:
2787         * Plugins/PluginPackage.cpp:
2788         * Plugins/PluginStream.cpp:
2789         * Plugins/PluginStream.h:
2790         * WebApplicationCache.cpp:
2791         * WebDatabaseManager.cpp:
2792         * WebDownloadCurl.cpp:
2793         * WebPreferences.cpp:
2794         * WebView.cpp:
2795
2796 2017-10-31  Alex Christensen  <achristensen@webkit.org>
2797
2798         Fix Windows build after r224260
2799
2800         * WebView.cpp:
2801         (WebView::gesture):
2802
2803 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2804
2805         [FrameView::layout cleanup] Move core layout logic to a separate class.
2806         https://bugs.webkit.org/show_bug.cgi?id=178771
2807         <rdar://problem/35166542>
2808
2809         Reviewed by Simon Fraser.
2810
2811         Move layout code out from FrameView to LayoutContext.
2812
2813         * WebFrame.cpp:
2814         (WebFrame::layout):
2815
2816 2017-10-26  Alex Christensen  <achristensen@webkit.org>
2817
2818         Fix Windows build
2819         https://bugs.webkit.org/show_bug.cgi?id=178892
2820
2821         * AccessibleBase.cpp:
2822         (MSAARole):
2823
2824 2017-10-26  Alex Christensen  <achristensen@webkit.org>
2825
2826         Fix Windows build
2827         https://bugs.webkit.org/show_bug.cgi?id=178892
2828
2829         * AccessibleBase.cpp:
2830         (AccessibleBase::state const):
2831         (MSAARole):
2832
2833 2017-10-25  Youenn Fablet  <youenn@apple.com>
2834
2835         Enable ServiceWorker to fetch resources
2836         https://bugs.webkit.org/show_bug.cgi?id=178673
2837
2838         Reviewed by Brady Eidson.
2839
2840         Added implementation to the new getters.
2841         They are noop in the context of WK1.
2842
2843         * WebCoreSupport/WebFrameLoaderClient.cpp:
2844         (WebFrameLoaderClient::pageID const):
2845         (WebFrameLoaderClient::frameID const):
2846         (WebFrameLoaderClient::sessionID const):
2847         * WebCoreSupport/WebFrameLoaderClient.h:
2848
2849 2017-10-20  Antoine Quint  <graouts@apple.com>
2850
2851         [Web Animations] Provide basic timeline and animation interfaces
2852         https://bugs.webkit.org/show_bug.cgi?id=178526
2853
2854         Reviewed by Dean Jackson.
2855
2856         Remove the WEB_ANIMATIONS compile-time flag.
2857
2858         * WebView.cpp:
2859         (WebView::notifyPreferencesChanged):
2860
2861 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2862
2863         [Curl] Clean up old style code in old curl files.
2864         https://bugs.webkit.org/show_bug.cgi?id=178569
2865
2866         Reviewed by Ryosuke Niwa.
2867
2868         * WebCache.cpp:
2869         (WebCache::cacheFolder):
2870         (WebCache::setCacheFolder):
2871         * WebView.cpp:
2872         (WebView::setCacheModel):
2873
2874 2017-10-19  Sam Weinig  <sam@webkit.org>
2875
2876         [Settings] Move global settings into their own file
2877         https://bugs.webkit.org/show_bug.cgi?id=178512
2878
2879         Reviewed by Darin Adler.
2880
2881         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2882
2883         * WebView.cpp:
2884         (WebView::initWithFrame):
2885
2886 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2887
2888         Replace some stack raw pointers with RefPtrs within WebCore/html
2889         https://bugs.webkit.org/show_bug.cgi?id=178201
2890         <rdar://problem/34841692>
2891
2892         Reviewed by Ryosuke Niwa.
2893
2894         * WebView.cpp:
2895         (WebView::handleEditingKeyboardEvent):
2896         Change the type of node as toNode() is changed to return RefPtr.
2897
2898 2017-10-16  Sam Weinig  <sam@webkit.org>
2899
2900         [Settings] Remove all custom code from Settings.h/cpp
2901         https://bugs.webkit.org/show_bug.cgi?id=178330
2902
2903         Reviewed by Simon Fraser.
2904
2905         * WebView.cpp:
2906         (WebView::notifyPreferencesChanged):
2907             
2908             Update for naming changes of FrameFlattening now that it is an enum class.
2909
2910 2017-10-11  Chris Dumez  <cdumez@apple.com>
2911
2912         Modernize Geolocation code
2913         https://bugs.webkit.org/show_bug.cgi?id=178148
2914
2915         Reviewed by Ryosuke Niwa.
2916
2917         * WebCoreSupport/WebGeolocationClient.cpp:
2918         (WebGeolocationClient::lastPosition):
2919         * WebCoreSupport/WebGeolocationClient.h:
2920         * WebGeolocationPosition.cpp:
2921         (WebGeolocationPosition::initWithTimestamp):
2922         (core):
2923         * WebGeolocationPosition.h:
2924         (WebGeolocationPosition::impl const):
2925
2926 2017-10-05  Chris Dumez  <cdumez@apple.com>
2927
2928         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2929         https://bugs.webkit.org/show_bug.cgi?id=177957
2930
2931         Reviewed by Alex Christensen.
2932
2933         * WebCoreSupport/WebPlatformStrategies.cpp:
2934         (WebPlatformStrategies::cookiesEnabled):
2935         * WebCoreSupport/WebPlatformStrategies.h:
2936
2937 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2938
2939         [Curl] Reimplement CurlDownload with CurlRequest
2940         https://bugs.webkit.org/show_bug.cgi?id=177779
2941
2942         Reviewed by Alex Christensen.
2943
2944         * WebDownload.h:
2945         * WebDownloadCurl.cpp:
2946         (WebDownload::init):
2947         (WebDownload::didReceiveResponse):
2948
2949 2017-09-29  Chris Dumez  <cdumez@apple.com>
2950
2951         Split some logic out of VisitedLinkStore and make it reusable
2952         https://bugs.webkit.org/show_bug.cgi?id=177575
2953
2954         Reviewed by Alex Christensen.
2955
2956         * WebCoreSupport/WebVisitedLinkStore.cpp:
2957         (WebVisitedLinkStore::addVisitedLink):
2958         (WebVisitedLinkStore::isLinkVisited):
2959         (WebVisitedLinkStore::addVisitedLinkHash):
2960         * WebCoreSupport/WebVisitedLinkStore.h:
2961
2962 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2963
2964         Make PolicyAction an encodable enum class
2965         https://bugs.webkit.org/show_bug.cgi?id=177480
2966
2967         Reviewed by Antti Koivisto.
2968
2969         * WebCoreSupport/WebFrameLoaderClient.cpp:
2970         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2971         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2972         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2973         * WebFramePolicyListener.cpp:
2974         (WebFramePolicyListener::use):
2975         (WebFramePolicyListener::download):
2976         (WebFramePolicyListener::ignore):
2977         (WebFramePolicyListener::continueSubmit):
2978
2979 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
2980
2981         [Win] fast/canvas/2d.getPath.modification.html is failing.
2982         https://bugs.webkit.org/show_bug.cgi?id=176534
2983
2984         Reviewed by Alex Christensen.
2985
2986         We need to enable Inspector additions at runtime in order to expose the getPath function.
2987
2988         * Interfaces/IWebPreferencesPrivate.idl:
2989         * WebPreferenceKeysPrivate.h:
2990         * WebPreferences.cpp:
2991         (WebPreferences::initializeDefaultSettings):
2992         (WebPreferences::setDataTransferItemsEnabled):
2993         (WebPreferences::inspectorAdditionsEnabled):
2994         (WebPreferences::setInspectorAdditionsEnabled):
2995         * WebPreferences.h:
2996         * WebView.cpp:
2997         (WebView::notifyPreferencesChanged):
2998
2999 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3000
3001         Modernize Geolocation code
3002         https://bugs.webkit.org/show_bug.cgi?id=176496
3003
3004         Reviewed by Andy Estes.
3005
3006         * WebCoreSupport/WebGeolocationClient.cpp:
3007         (WebGeolocationClient::requestPermission):
3008         * WebCoreSupport/WebGeolocationClient.h:
3009         (WebGeolocationClient::setEnableHighAccuracy): Deleted.
3010         (WebGeolocationClient::cancelPermissionRequest): Deleted.
3011         * WebGeolocationPolicyListener.h:
3012         * WebView.cpp:
3013         (WebView::initWithFrame):
3014         (WebView::geolocationDidFailWithError):
3015
3016 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
3017
3018         [Win] Enable DatatransferItems in DRT.
3019         https://bugs.webkit.org/show_bug.cgi?id=176424
3020
3021         Reviewed by Brent Fulgham.
3022
3023         * Interfaces/IWebPreferencesPrivate.idl:
3024         * WebPreferenceKeysPrivate.h:
3025         * WebPreferences.cpp:
3026         (WebPreferences::initializeDefaultSettings):
3027         (WebPreferences::QueryInterface):
3028         (WebPreferences::isSecureContextAttributeEnabled):
3029         (WebPreferences::dataTransferItemsEnabled):
3030         (WebPreferences::setDataTransferItemsEnabled):
3031         * WebPreferences.h:
3032         * WebView.cpp:
3033         (WebView::notifyPreferencesChanged):
3034
3035 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3036
3037         Unreviewed build fix #2 after r221275.
3038
3039         * WebCoreSupport/WebPlatformStrategies.cpp:
3040         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
3041         to match new API.
3042         * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
3043
3044 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3045
3046         Unreviewed build fix after r221275.
3047
3048         * WebCoreSupport/WebPlatformStrategies.cpp:
3049         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
3050         to match new API.
3051
3052 2017-08-28  Per Arne Vollan  <pvollan@apple.com>
3053
3054         [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
3055         https://bugs.webkit.org/show_bug.cgi?id=176031
3056
3057         Reviewed by Brent Fulgham.
3058
3059         When the function in the FramePolicyFunction parameter is called, it has already been moved
3060         to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
3061         function by using the stored member instead.
3062
3063         * WebCoreSupport/WebFrameLoaderClient.cpp:
3064         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3065         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3066         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3067
3068 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3069
3070         Unreviewed, try to fix the Windows build after r221064
3071
3072         didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
3073
3074         * WebCoreSupport/WebEditorClient.h:
3075
3076 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3077
3078         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3079         https://bugs.webkit.org/show_bug.cgi?id=175370
3080         <rdar://problem/33799806>
3081
3082         Reviewed by Ryosuke Niwa.
3083
3084         Adjust WebEditorClient for interface changes.
3085
3086         * WebCoreSupport/WebEditorClient.h:
3087
3088 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
3089
3090         Unreviewed build fix after r221017.
3091
3092         Correct copy/paste error.
3093
3094         * WebCoreSupport/WebPlatformStrategies.cpp:
3095         (WebPlatformStrategies::cookiesForDOM):
3096
3097 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
3098
3099         Unreviewed build fix after r221017.
3100
3101         * WebCoreSupport/WebPlatformStrategies.cpp:
3102         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
3103         * WebCoreSupport/WebPlatformStrategies.h:
3104
3105 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3106
3107         Remove ChromeClient::scrollbarsModeDidChange
3108         https://bugs.webkit.org/show_bug.cgi?id=175805
3109
3110         Reviewed by Daniel Bates.
3111
3112         * WebCoreSupport/WebChromeClient.h:
3113
3114 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3115
3116         Remove ChromeClient::hasOpenedPopup
3117         https://bugs.webkit.org/show_bug.cgi?id=175804
3118
3119         Reviewed by Sam Weinig.
3120
3121         * WebCoreSupport/WebChromeClient.cpp:
3122         (WebChromeClient::hasOpenedPopup const): Deleted.
3123         * WebCoreSupport/WebChromeClient.h:
3124
3125 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
3126
3127         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
3128         https://bugs.webkit.org/show_bug.cgi?id=173536
3129
3130         Reviewed by Brent Fulgham.
3131
3132         If the tree state is dirty, accessible objects are deleted while iterating over children
3133         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
3134         style is updated before this method is called.
3135
3136         * AccessibleBase.cpp:
3137         (AccessibleBase::getAccessibilityObjectForChild):
3138
3139 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3140
3141         [PAL] Move SessionID into PAL
3142         https://bugs.webkit.org/show_bug.cgi?id=174192
3143
3144         Reviewed by Antti Koivisto.
3145
3146         * WebCoreSupport/WebFrameLoaderClient.cpp:
3147         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3148         * WebCoreSupport/WebFrameLoaderClient.h:
3149         * WebCoreSupport/WebFrameNetworkingContext.cpp:
3150         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
3151         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3152         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3153         (WebFrameNetworkingContext::storageSession const):
3154         * WebCoreSupport/WebPlatformStrategies.cpp:
3155         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3156         * WebCoreSupport/WebPlatformStrategies.h:
3157
3158 2017-08-15  Youenn Fablet  <youenn@apple.com>
3159
3160         [Cache API] Adding generic support for CacheStorage and Cache methods
3161         https://bugs.webkit.org/show_bug.cgi?id=175455
3162
3163         Reviewed by Chris Dumez.
3164
3165         * WebView.cpp:
3166         (WebView::initWithFrame):
3167
3168 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3169
3170         Composition underline color is always black
3171         https://bugs.webkit.org/show_bug.cgi?id=174675
3172
3173         Reviewed by Ryosuke Niwa.
3174
3175         * WebView.cpp:
3176         (WebView::setCompositionForTesting): Use text color for
3177         composition underline.
3178
3179 2017-08-09  Daniel Bates  <dabates@apple.com>
3180
3181         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3182         https://bugs.webkit.org/show_bug.cgi?id=175247
3183         <rdar://problem/33679804>
3184
3185         Reviewed by Brady Eidson.
3186
3187         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3188         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3189         clients that need to make use of this information at this time. If such a needs comes up
3190         then we can expose API/SPI similar to what we do for WebKit.
3191
3192         * WebCoreSupport/WebFrameLoaderClient.cpp:
3193         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3194         * WebCoreSupport/WebFrameLoaderClient.h:
3195
3196 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3197
3198         Async image decoding for large images should be disabled after the first time a tile is painted
3199         https://bugs.webkit.org/show_bug.cgi?id=174451
3200         <rdar://problem/31246421>
3201
3202         Reviewed by Simon Fraser.
3203
3204         * FullscreenVideoController.cpp:
3205         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3206         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3207         (AcceleratedCompositingContext::paintContents):
3208         * WebCoreSupport/AcceleratedCompositingContext.h:
3209
3210 2017-07-23  Darin Adler  <darin@apple.com>
3211
3212         More NeverDestroyed and related cleanup
3213         https://bugs.webkit.org/show_bug.cgi?id=174745
3214
3215         Reviewed by Alex Christensen.
3216
3217         * Plugins/PluginDatabase.cpp:
3218         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
3219         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
3220         * Plugins/PluginMainThreadScheduler.cpp:
3221         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
3222         * Plugins/PluginMainThreadScheduler.h: Ditto.
3223         * WebCoreSupport/WebPlatformStrategies.cpp:
3224         (WebPlatformStrategies::initialize): Ditto.
3225         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
3226         * WebHistory.cpp:
3227         (sharedHistoryStorage): Ditto.
3228         * WebLocalizableStrings.cpp:
3229         (mainBundleLocStrings): Ditto.
3230         (frameworkLocStringsMutex): Ditto.
3231         (frameworkLocStrings): Ditto.
3232         * WebView.cpp:
3233         (WebView::standardUserAgentWithApplicationName): Ditto.
3234         Also changed to keep one global string with the prefix of the user agent string
3235         instead of keeping two globals with pieces of that prefix.
3236
3237 2017-07-24  Chris Dumez  <cdumez@apple.com>
3238
3239         Make ExceptionCode a proper enumeration
3240         https://bugs.webkit.org/show_bug.cgi?id=174771
3241
3242         Reviewed by Sam Weinig.
3243
3244         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
3245
3246         * DOMCoreClasses.cpp:
3247         (DOMDocument::createEvent):
3248         * WebView.cpp:
3249         (WebView::prepareCandidateWindow):
3250
3251 2017-07-21  Andreas Kling  <akling@apple.com>
3252
3253         Use more references in event dispatch code
3254         https://bugs.webkit.org/show_bug.cgi?id=174681
3255
3256         Reviewed by Geoffrey Garen.
3257
3258         * DOMEventsClasses.cpp:
3259         (WebEventListener::handleEvent):
3260         * DOMEventsClasses.h:
3261         * Plugins/PluginView.cpp:
3262         (WebCore::PluginView::handleEvent):
3263         * Plugins/PluginView.h:
3264
3265 2017-07-20  Brady Eidson  <beidson@apple.com>
3266
3267         Remove WebIconDatabase from WebKitLegacy/win.
3268         https://bugs.webkit.org/show_bug.cgi?id=174608
3269
3270         Reviewed by Alex Christensen.
3271
3272         It is unused.
3273         
3274         * ForEachCoClass.h:
3275
3276         * Interfaces/IWebIconDatabase.idl: Removed.
3277
3278         * Interfaces/WebKit.idl:
3279
3280         * WebCoreStatistics.cpp:
3281         (WebCoreStatistics::iconPageURLMappingCount):
3282         (WebCoreStatistics::iconRetainedPageURLCount):
3283         (WebCoreStatistics::iconRecordCount):
3284         (WebCoreStatistics::iconsWithDataCount):
3285
3286         * WebIconDatabase.cpp: Removed.
3287         * WebIconDatabase.h: Removed.
3288         * WebKitClassFactory.cpp:
3289
3290         * WebKitDLL.cpp:
3291         (shutDownWebKit):
3292
3293         * WebKitLogging.h:
3294
3295         * WebView.cpp:
3296         (WebView::close):
3297         (WebView::notifyDidAddIcon):
3298         (WebView::registerForIconNotification):
3299         (WebView::dispatchDidReceiveIconFromWebFrame):
3300         (WebView::onNotify):
3301
3302 2017-07-18  Matt Lewis  <jlewis3@apple.com>
3303
3304         Unreviewed, rolling out r219610.
3305
3306         This caused an api failure on all platforms for the test
3307         SnapshotImageLargeAsyncDecoding
3308
3309         Reverted changeset:
3310
3311         "Async image decoding for large images should be disabled
3312         after the first time a tile is painted"
3313         https://bugs.webkit.org/show_bug.cgi?id=174451
3314         http://trac.webkit.org/changeset/219610
3315
3316 2017-07-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
3317
3318         Async image decoding for large images should be disabled after the first time a tile is painted
3319         https://bugs.webkit.org/show_bug.cgi?id=174451
3320
3321         Reviewed by Simon Fraser.
3322
3323         * FullscreenVideoController.cpp:
3324         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3325         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3326         (AcceleratedCompositingContext::paintContents):
3327         * WebCoreSupport/AcceleratedCompositingContext.h:
3328
3329 2017-07-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3330
3331         [Curl] Don't start downloading more than once for same request
3332         https://bugs.webkit.org/show_bug.cgi?id=174172
3333
3334         Reviewed by Alex Christensen.
3335
3336         * WebDownloadCurl.cpp:
3337         (WebDownload::init):
3338
3339 2017-07-12  Daniel Bates  <dabates@apple.com>
3340
3341         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3342         https://bugs.webkit.org/show_bug.cgi?id=174427
3343
3344         Rubber-stamped by Brady Eidson.
3345
3346         * Plugins/PluginView.cpp:
3347         (WebCore::PluginView::start):
3348         (WebCore::PluginView::getURLNotify):
3349         (WebCore::PluginView::getURL):
3350         (WebCore::PluginView::handlePost):
3351
3352 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3353
3354         [WTF] Move SoftLinking.h into WTF
3355         https://bugs.webkit.org/show_bug.cgi?id=174000
3356
3357         Reviewed by Alex Christensen.
3358
3359         * WebKitClassFactory.cpp:
3360         * WebView.cpp:
3361
3362 2017-07-05  Brady Eidson  <beidson@apple.com>
3363
3364         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3365         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3366
3367         Reviewed by Alex Christensen.
3368
3369         Adopt to the new constructor for FrameLoadRequest.
3370
3371         * Plugins/PluginView.cpp:
3372         (WebCore::PluginView::start):
3373         (WebCore::PluginView::getURLNotify):
3374         (WebCore::PluginView::getURL):
3375         (WebCore::PluginView::handlePost):
3376
3377 2017-07-03  Brady Eidson  <beidson@apple.com>
3378
3379         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3380         https://bugs.webkit.org/show_bug.cgi?id=174073
3381
3382         Reviewed by Andy Estes.
3383
3384         * WebCoreSupport/WebFrameLoaderClient.cpp:
3385         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3386         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3387         * WebCoreSupport/WebFrameLoaderClient.h:
3388
3389 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3390
3391         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3392         https://bugs.webkit.org/show_bug.cgi?id=174004
3393
3394         Reviewed by Simon Fraser.
3395
3396         * WebCoreSupport/WebFrameLoaderClient.cpp:
3397         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3398
3399 2017-06-30  Daniel Bates  <dabates@apple.com>
3400
3401         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3402         https://bugs.webkit.org/show_bug.cgi?id=165160
3403         <rdar://problem/29451999>
3404
3405         Reviewed by Brady Eidson.
3406
3407         Pass the document that is requesting the load to the loader.
3408
3409         * Plugins/PluginView.cpp:
3410         (WebCore::PluginView::start):
3411         (WebCore::PluginView::getURLNotify):
3412         (WebCore::PluginView::getURL):
3413         (WebCore::PluginView::handlePost):
3414
3415 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3416
3417         Refactor drag start codepaths to plumb a DragItem to client layers
3418         https://bugs.webkit.org/show_bug.cgi?id=173832
3419         Work towards <rdar://problem/32236827>
3420
3421         Reviewed by Ryosuke Niwa and Tim Horton.
3422
3423         Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
3424
3425         * WebCoreSupport/WebDragClient.cpp:
3426         (WebDragClient::startDrag):
3427         * WebCoreSupport/WebDragClient.h:
3428
3429 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3430
3431         Remove excessive headers from JavaScriptCore
3432         https://bugs.webkit.org/show_bug.cgi?id=173812
3433
3434         Reviewed by Darin Adler.
3435
3436         * Plugins/PluginPackage.cpp:
3437
3438 2017-06-22  Daniel Bates  <dabates@apple.com>
3439
3440         Make FrameLoadRequest a move-only type
3441         https://bugs.webkit.org/show_bug.cgi?id=173682
3442
3443         Reviewed by Alex Christensen and Darin Adler.
3444
3445         A FrameLoadRequest groups together the information to perform a load into a single object
3446         that is more manageable to pass around than its constituent parts. Code that receives a
3447         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3448         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3449         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
3450
3451         * Plugins/PluginView.cpp:
3452         (WebCore::PluginView::start):
3453         (WebCore::PluginView::performRequest):
3454         (WebCore::PluginView::load):
3455         (WebCore::PluginView::getURLNotify):
3456         (WebCore::PluginView::getURL):
3457         (WebCore::PluginView::handlePost):
3458         * Plugins/PluginView.h:
3459         (WebCore::PluginRequest::PluginRequest):
3460
3461 2017-06-22  Daniel Bates  <dabates@apple.com>
3462
3463         [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
3464         https://bugs.webkit.org/show_bug.cgi?id=173683
3465
3466         Reviewed by Alex Christensen.
3467
3468         Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
3469         header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
3470         by including PluginView.h. The latter does not make use of the functionality
3471         provided by FrameLoadRequest.h.
3472
3473         * Plugins/PluginViewWin.cpp:
3474         * WebCoreSupport/WebContextMenuClient.cpp:
3475
3476 2017-06-21  Daniel Bates  <dabates@apple.com>
3477
3478         Cleanup FrameLoadRequest
3479         https://bugs.webkit.org/show_bug.cgi?id=173564
3480         <rdar://problem/32903570>
3481
3482         Reviewed by Brent Fulgham.
3483
3484         * Plugins/PluginView.cpp:
3485         (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
3486         we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
3487         we do not have one. Use C++11 brace initialization syntax.
3488         (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
3489         name as we do not have one. Use C++11 brace initialization syntax.
3490         (WebCore::PluginView::getURL): Ditto.
3491         (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
3492         function to closer to where it is actually used. Explicitly pass the null-string for the target
3493         frame name as we do not have one. Use C++11 brace initialization syntax.
3494
3495 2017-06-20  Daniel Bates  <dabates@apple.com>
3496
3497         Have FrameLoadRequest takes a Frame& instead of a Frame*
3498         https://bugs.webkit.org/show_bug.cgi?id=173614
3499         <rdar://problem/32884890>
3500
3501         Reviewed by Brent Fulgham.
3502
3503         * Plugins/PluginView.cpp:
3504         (WebCore::PluginView::performRequest):
3505         * WebFrame.cpp:
3506         (WebFrame::loadRequest):
3507
3508 2017-06-19  Chris Dumez  <cdumez@apple.com>
3509
3510         Use WTF::Function instead of std::function in more places in WebCore/
3511         https://bugs.webkit.org/show_bug.cgi?id=173535
3512
3513         Reviewed by Antti Koivisto.
3514
3515         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
3516
3517         * WebCoreSupport/WebFrameLoaderClient.cpp:
3518         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3519         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3520         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3521         (WebFrameLoaderClient::dispatchWillSubmitForm):
3522         (WebFrameLoaderClient::setUpPolicyListener):
3523         (WebFrameLoaderClient::receivedPolicyDecision):
3524         * WebCoreSupport/WebFrameLoaderClient.h:
3525
3526 2017-05-14 Frederic Wang  <fwang@igalia.com>
3527
3528         Add heuristic to avoid flattening "fullscreen" iframes
3529         https://bugs.webkit.org/show_bug.cgi?id=171914
3530
3531         Reviewed by Simon Fraser.
3532
3533         This commit ajusts the window port to internally use the new preference type for frame flattening.
3534         However, the "partial frame flattening" value is not exposed yet.
3535
3536         * WebView.cpp:
3537         (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
3538
3539 2017-06-17  Chris Dumez  <cdumez@apple.com>
3540
3541         Use WTF::Function instead of std::function in WebKit2/
3542         https://bugs.webkit.org/show_bug.cgi?id=173504
3543
3544         Reviewed by Darin Adler.
3545
3546         Use WTF::Function instead of std::function in WebKit2/ to avoid
3547         unnecessary copying.
3548
3549         * Plugins/PluginStream.cpp:
3550         (WebCore::PluginStream::willSendRequest):
3551         * Plugins/PluginStream.h:
3552
3553 2017-06-16  Sam Weinig  <sam@webkit.org>
3554
3555         [WebIDL] Remove custom bindings for HTMLDocument
3556         https://bugs.webkit.org/show_bug.cgi?id=173444
3557
3558         Reviewed by Darin Adler.
3559
3560         * DOMHTMLClasses.cpp:
3561         (DOMHTMLDocument::write):
3562         (DOMHTMLDocument::writeln):
3563         Update for new signature of write/writeln.
3564
3565 2017-06-16  Daniel Bates  <dabates@apple.com>
3566
3567         Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
3568         instead of URL { ParsedURLString, ... }
3569         https://bugs.webkit.org/show_bug.cgi?id=173495
3570         <rdar://problem/32827445>
3571
3572         Reviewed by Alex Christensen.
3573
3574         URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
3575         Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
3576         Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
3577         would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
3578         parse an arbitrary string that looks like a URL.
3579
3580         Also modernize the code using C++14 idioms.
3581
3582         * WebCoreSupport/WebContextMenuClient.cpp:
3583         (WebContextMenuClient::searchWithGoogle):
3584
3585 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
3586
3587         [Win] WebKit shouldn't include the forwarding header of WebKit itself
3588         https://bugs.webkit.org/show_bug.cgi?id=173352
3589
3590         Reviewed by Alex Christensen.
3591
3592         * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
3593
3594 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
3595
3596         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
3597         https://bugs.webkit.org/show_bug.cgi?id=173318
3598
3599         Reviewed by Darin Adler.
3600
3601         The logical frame size is currently calculated by scaling the frame size in pixels,
3602         and rounding the coordinates to the nearest integers. The computed logical frame
3603         size will in some cases be smaller than the scaled frame size in pixels, since it is
3604         represented as an IntSize. In these cases, the bottom line will not be painted.
3605         Instead of calculating the logical frame size by rounding the scaled frame in
3606         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
3607
3608         * WebCoreSupport/WebFrameLoaderClient.cpp:
3609         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3610
3611 2017-06-13  Daniel Bates  <dabates@apple.com>
3612
3613         Implement W3C Secure Contexts Draft Specification
3614         https://bugs.webkit.org/show_bug.cgi?id=158121
3615         <rdar://problem/26012994>
3616
3617         Reviewed by Brent Fulgham.
3618
3619         Part 4
3620
3621         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3622
3623         * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
3624         * WebPreferenceKeysPrivate.h:
3625         * WebPreferences.cpp:
3626         (WebPreferences::initializeDefaultSettings):
3627         (WebPreferences::QueryInterface):
3628         (WebPreferences::setIsSecureContextAttributeEnabled):
3629         (WebPreferences::isSecureContextAttributeEnabled):
3630         * WebPreferences.h:
3631         * WebView.cpp:
3632         (WebView::notifyPreferencesChanged):
3633
3634 2017-06-13  Per Arne Vollan  <pvollan@apple.com>
3635
3636         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
3637         https://bugs.webkit.org/show_bug.cgi?id=173318
3638
3639         Reviewed by Alex Christensen.
3640
3641         The logical frame size is currently calculated by scaling the frame size in pixels,
3642         and rounding the coordinates to the nearest integers. The computed logical frame
3643         size will in some cases be smaller than the scaled frame size in pixels, since it is
3644         represented as an IntSize. In these cases, the bottom line will not be painted.
3645         Instead of calculating the logical frame size by rounding the scaled frame in
3646         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
3647  
3648         * WebView.cpp:
3649         (WebView::sizeChanged):
3650
3651 2017-06-13  Sam Weinig  <sam@webkit.org>
3652
3653         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
3654         https://bugs.webkit.org/show_bug.cgi?id=80733
3655
3656         Reviewed by Chris Dumez.
3657
3658         * WebFrame.cpp:
3659         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
3660
3661 2017-06-12  Daewoong Jang  <daewoong.jang@navercorp.com>
3662
3663         Remove WebCore::unloadModule and related data types
3664         https://bugs.webkit.org/show_bug.cgi?id=173231
3665
3666         Reviewed by Darin Adler.
3667
3668         * Plugins/PlatformModule.h: Added.
3669         (WebCore::PlatformModuleVersion::PlatformModuleVersion):
3670         * Plugins/PluginPackage.cpp:
3671         (WebCore::PluginPackage::freeLibraryTimerFired):
3672         * Plugins/PluginPackage.h:
3673
3674 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3675
3676         [iOS DnD] Add a hook to perform two-step drops in editable content
3677         https://bugs.webkit.org/show_bug.cgi?id=172992
3678         <rdar://problem/32590174>
3679
3680         Reviewed by Tim Horton.
3681
3682         Add a stub implementation for performTwoStepDrop on Windows.
3683
3684         * WebCoreSupport/WebEditorClient.h:
3685
3686 2017-06-04  Konstantin Tokarev  <annulen@yandex.ru>
3687
3688         Fix build of Windows-specific code with ICU 59.1
3689         https://bugs.webkit.org/show_bug.cgi?id=172729
3690
3691         Reviewed by Darin Adler.
3692
3693         Fix conversions from WTF::String to wchar_t* and vice versa.
3694
3695         * Plugins/PluginDatabaseWin.cpp:
3696         (WebCore::addPluginPathsFromRegistry):
3697         (WebCore::PluginDatabase::getPluginPathsInDirectories):
3698         (WebCore::addMozillaPluginDirectories):
3699         (WebCore::addWindowsMediaPlayerPluginDirectory):
3700         (WebCore::addAdobeAcrobatPluginDirectory):
3701         (WebCore::addJavaPluginDirectory):
3702         (WebCore::safariPluginsDirectory):
3703         (WebCore::addMacromediaPluginDirectories):
3704         * Plugins/PluginPackageWin.cpp:
3705         (WebCore::getVersionInfo):
3706         (WebCore::PluginPackage::fetchInfo):
3707         (WebCore::PluginPackage::load):
3708         * Plugins/PluginViewWin.cpp:
3709         (WebCore::PluginView::handlePostReadFile):
3710
3711 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
3712
3713         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
3714         https://bugs.webkit.org/show_bug.cgi?id=172709
3715
3716         Reviewed by Brent Fulgham.
3717
3718         Add method to exit fullscreen mode.
3719
3720         * Interfaces/IWebViewPrivate.idl:
3721         * WebView.cpp:
3722         (WebView::exitFullscreenIfNeeded):
3723         * WebView.h:
3724
3725 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
3726
3727         [Win] Create unique network storage session for each DRT.
3728         https://bugs.webkit.org/show_bug.cgi?id=172540
3729
3730         Reviewed by Brent Fulgham.
3731
3732         During layout testing, each DRT instance should have its own network storage session.
3733
3734         * Interfaces/IWebPreferencesPrivate.idl:
3735         * WebPreferences.cpp:
3736         (WebPreferences::switchNetworkLoaderToNewTestingSession):
3737         * WebPreferences.h:
3738
3739 2017-05-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3740
3741         [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
3742         https://bugs.webkit.org/show_bug.cgi?id=172535
3743
3744         Reviewed by Konstantin Tokarev.
3745
3746         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3747         (AcceleratedCompositingContext::paintContents): Append the fifth argument.
3748         * WebCoreSupport/AcceleratedCompositingContext.h: Ditto.
3749
3750 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
3751
3752         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
3753         https://bugs.webkit.org/show_bug.cgi?id=172071
3754
3755         Reviewed by Alexey Proskuryakov.
3756
3757         We need to delete all cookies after each test.
3758
3759         * Interfaces/IWebPreferencesPrivate.idl:
3760         * WebPreferences.cpp:
3761         (WebPreferences::linkPreloadEnabled):
3762         (WebPreferences::clearNetworkLoaderSession):
3763         * WebPreferences.h:
3764
3765 2017-05-13  Chris Dumez  <cdumez@apple.com>
3766
3767         Stop using RefPtr::release()
3768         https://bugs.webkit.org/show_bug.cgi?id=172074
3769
3770         Reviewed by Geoffrey Garen.
3771
3772         * WebFrame.cpp:
3773         (WebFrame::loadPlainTextString):
3774         (WebFrame::loadHTMLString):
3775         * WebFramePolicyListener.cpp:
3776         (WebFramePolicyListener::receivedPolicyDecision):
3777
3778 2017-05-13  Chris Dumez  <cdumez@apple.com>
3779
3780         Drop uses of PassRefPtr in WebKit/win
3781         https://bugs.webkit.org/show_bug.cgi?id=172067
3782
3783         Reviewed by Yusuke Suzuki.
3784
3785         * DOMEventsClasses.cpp:
3786         (DOMEvent::DOMEvent):
3787         (DOMEvent::createInstance):
3788         * DOMEventsClasses.h:
3789         (DOMUIEvent::DOMUIEvent):
3790         (DOMKeyboardEvent::DOMKeyboardEvent):
3791         (DOMMouseEvent::DOMMouseEvent):
3792         (DOMMutationEvent::DOMMutationEvent):
3793         (DOMOverflowEvent::DOMOverflowEvent):
3794         (DOMWheelEvent::DOMWheelEvent):
3795         * MemoryStream.cpp:
3796         (MemoryStream::MemoryStream):
3797         (MemoryStream::createInstance):
3798         * MemoryStream.h:
3799         * Plugins/PluginDatabase.cpp:
3800         (WebCore::PluginDatabase::refresh):
3801         (WebCore::PluginDatabase::add):
3802         (WebCore::PluginDatabase::loadPersistentMetadataCache):
3803         * Plugins/PluginDatabase.h:
3804         * Plugins/PluginPackage.cpp:
3805         (WebCore::PluginPackage::createPackage):
3806         (WebCore::PluginPackage::createPackageFromCache):
3807         * Plugins/PluginPackage.h:
3808         * Plugins/PluginStream.h:
3809         (WebCore::PluginStream::create):
3810         * WebActionPropertyBag.cpp:
3811         (WebActionPropertyBag::WebActionPropertyBag):
3812         (WebActionPropertyBag::createInstance):
3813         * WebActionPropertyBag.h:
3814         * WebArchive.cpp:
3815         (WebArchive::createInstance):
3816         (WebArchive::WebArchive):
3817         * WebArchive.h:
3818         * WebBackForwardList.cpp:
3819         (WebBackForwardList::WebBackForwardList):
3820         (WebBackForwardList::createInstance):
3821         * WebBackForwardList.h:
3822         * WebCoreSupport/EmbeddedWidget.cpp:
3823         (EmbeddedWidget::create):
3824         * WebCoreSupport/EmbeddedWidget.h:
3825         * WebCoreSupport/WebChromeClient.h:
3826         * WebFrame.cpp:
3827         (WebFrame::loadData):
3828         (WebFrame::createSubframeWithOwnerElement):
3829         * WebFrame.h:
3830         * WebFramePolicyListener.cpp:
3831         (WebFramePolicyListener::WebFramePolicyListener):
3832         (WebFramePolicyListener::createInstance):
3833         * WebFramePolicyListener.h:
3834         * WebGeolocationPolicyListener.cpp:
3835         (WebGeolocationPolicyListener::createInstance):
3836         (WebGeolocationPolicyListener::WebGeolocationPolicyListener):
3837         * WebGeolocationPolicyListener.h:
3838         * WebHistoryItem.cpp:
3839         (WebHistoryItem::WebHistoryItem):
3840         (WebHistoryItem::createInstance):
3841         * WebHistoryItem.h:
3842         * WebMutableURLRequest.cpp:
3843         (WebMutableURLRequest::setFormData):
3844         (WebMutableURLRequest::formData):
3845         * WebMutableURLRequest.h:
3846         * WebResource.cpp:
3847         (WebResource::createInstance):
3848         * WebResource.h:
3849         * WebScriptWorld.cpp:
3850         (WebScriptWorld::WebScriptWorld):
3851         (WebScriptWorld::createInstance):
3852         * WebScriptWorld.h:
3853         * WebURLAuthenticationChallengeSender.cpp:
3854         (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
3855         (WebURLAuthenticationChallengeSender::createInstance):
3856         * WebURLAuthenticationChallengeSender.h:
3857         * WebView.cpp:
3858         (WebView::setFullScreenElement):
3859         * WebView.h:
3860
3861 2017-05-11  Chris Dumez  <cdumez@apple.com>
3862
3863         Drop remaining uses of PassRefPtr in WebCore
3864         https://bugs.webkit.org/show_bug.cgi?id=172013
3865
3866         Reviewed by Yusuke Suzuki.
3867
3868         * Plugins/PluginView.cpp:
3869         (WebCore::PluginView::bindingInstance):
3870
3871 2017-05-11  Chris Dumez  <cdumez@apple.com>
3872
3873         Stop using PassRefPtr in platform/graphics
3874         https://bugs.webkit.org/show_bug.cgi?id=171977
3875
3876         Reviewed by Alex Christensen.
3877
3878         Build fix.
3879
3880         * FullscreenVideoController.cpp:
3881         (FullscreenVideoController::enterFullscreen):
3882         * WebKitDLL.cpp:
3883         (loadResourceIntoBuffer):
3884
3885 2017-05-09  Sam Weinig  <sam@webkit.org>
3886
3887         Remove support for legacy Notifications
3888         https://bugs.webkit.org/show_bug.cgi?id=171487
3889
3890         Reviewed by Jon Lee.
3891
3892         * WebCoreSupport/WebChromeClient.cpp:
3893         (WebChromeClient::WebChromeClient):
3894         * WebCoreSupport/WebChromeClient.h:
3895         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
3896         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
3897         Remove legacy notification specific code.
3898
3899 2017-05-09  Dean Jackson  <dino@apple.com>
3900
3901         Fix Windows build.
3902
3903         * Plugins/PluginView.h:
3904         * Plugins/PluginViewWin.cpp:
3905         (WebCore::PluginView::paint):
3906
3907 2017-05-06  Alexey Proskuryakov  <ap@apple.com>
3908
3909         REGRESSION (r216294): The new test fails on WebKit1
3910         https://bugs.webkit.org/show_bug.cgi?id=171780
3911
3912         Rolling back https://trac.webkit.org/r216294, https://trac.webkit.org/r216296,
3913         https://trac.webkit.org/216299, https://trac.webkit.org/216330
3914
3915         * Plugins/PluginView.h:
3916         * Plugins/PluginViewWin.cpp:
3917         (WebCore::PluginView::paint):
3918
3919 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
3920
3921         Fix Windows build after r216294.
3922
3923         * Plugins/PluginView.h:
3924         * Plugins/PluginViewWin.cpp:
3925         (WebCore::PluginView::paint):
3926
3927 2017-05-04  Commit Queue  <commit-queue@webkit.org>
3928
3929         Unreviewed, rolling out r216206.
3930         https://bugs.webkit.org/show_bug.cgi?id=171714
3931
3932         Multiple LayoutTests crashing in Document::page() (Requested
3933         by ap on #webkit).
3934
3935         Reverted changeset:
3936
3937         "Remove support for legacy Notifications"
3938         https://bugs.webkit.org/show_bug.cgi?id=171487
3939         http://trac.webkit.org/changeset/216206
3940
3941 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
3942
3943         [Win] Remove redundant macros that are set in the CMake config
3944         https://bugs.webkit.org/show_bug.cgi?id=171571
3945
3946         Reviewed by Brent Fulgham.
3947
3948         * COMEnumVariant.h:
3949         * COMPropertyBag.h:
3950         * WebKitPrefix.h:
3951
3952 2017-05-04  Sam Weinig  <sam@webkit.org>
3953
3954         Remove support for legacy Notifications
3955         https://bugs.webkit.org/show_bug.cgi?id=171487
3956
3957         Reviewed by Jon Lee.
3958
3959         * WebCoreSupport/WebChromeClient.cpp:
3960         (WebChromeClient::WebChromeClient):
3961         * WebCoreSupport/WebChromeClient.h:
3962         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
3963         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
3964         Remove legacy notification specific code.
3965
3966 2017-04-27  Alex Christensen  <achristensen@webkit.org>
3967
3968         Modernize Frame.h
3969         https://bugs.webkit.org/show_bug.cgi?id=171357
3970
3971         Reviewed by Andy Estes.
3972
3973         * WebCoreSupport/WebEditorClient.cpp:
3974         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
3975         * WebCoreSupport/WebEditorClient.h:
3976
3977 2017-04-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3978
3979         [WinCairo] Fix build break after updating ANGLE
3980         https://bugs.webkit.org/show_bug.cgi?id=170980
3981
3982         Reviewed by Brent Fulgham.
3983
3984         * WebCoreSupport/AcceleratedCompositingContext.cpp: Define GL_GLEXT_PROTOTYPES.
3985
3986 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
3987
3988         [Win] REGRESSION(r215486): Windows Release build is broken
3989         https://bugs.webkit.org/show_bug.cgi?id=171024
3990         <rdar://problem/31722618>
3991
3992         Reviewed by Mark Lam.
3993
3994         Windows WebKit refers to a handful of JSC methods that are always
3995         inline. We need to include 'HeapInlines.h' to get the implementation
3996         of these methods.
3997
3998         * Plugins/PluginPackage.cpp:
3999         * WebFrame.cpp:
4000         * WebView.cpp:
4001
4002 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
4003
4004         Unreviewed, fix the Windows build after r215385
4005
4006         r215385 introduced a new virtual method on ChromeClient that needs to be implemented in WebChromeClient for
4007         Windows in WebKit1.
4008
4009         * WebCoreSupport/WebChromeClient.cpp:
4010         (WebChromeClient::createIconForFiles):
4011         * WebCoreSupport/WebChromeClient.h:
4012
4013 2017-04-10  Chris Dumez  <cdumez@apple.com>
4014
4015         Drop Timer::startOneShot() overload taking a double
4016         https://bugs.webkit.org/show_bug.cgi?id=170659
4017
4018         Reviewed by Yusuke Suzuki.
4019
4020         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
4021
4022         * Plugins/PluginMessageThrottlerWin.cpp:
4023         (WebCore::PluginMessageThrottlerWin::appendMessage):
4024         (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
4025         * Plugins/PluginViewWin.cpp:
4026         (WebCore::PluginView::invalidateRect):
4027         * WebCoreSupport/AcceleratedCompositingContext.cpp:
4028         (AcceleratedCompositingContext::scheduleLayerFlush):
4029
4030 2017-04-09  Chris Dumez  <cdumez@apple.com>
4031
4032         Drop Timer::startRepeating() overload taking a double
4033         https://bugs.webkit.org/show_bug.cgi?id=170656
4034
4035         Reviewed by Yusuke Suzuki.
4036
4037         Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
4038
4039         * FullscreenVideoController.cpp:
4040
4041 2017-04-09  Chris Dumez  <cdumez@apple.com>
4042
4043         Start dropping Timer API dealing with double
4044         https://bugs.webkit.org/show_bug.cgi?id=170649
4045
4046         Reviewed by Yusuke Suzuki.
4047
4048         Start dropping Timer API dealing with double as people should use Seconds now.
4049
4050         * Plugins/PluginPackage.cpp:
4051         (WebCore::PluginPackage::freeLibrarySoon):
4052         * Plugins/PluginStream.cpp:
4053         (WebCore::PluginStream::deliverData):
4054         * Plugins/PluginView.cpp:
4055         (WebCore::PluginView::requestTimerFired):
4056         (WebCore::PluginView::scheduleRequest):
4057         (WebCore::PluginView::setJavaScriptPaused):
4058         (WebCore::PluginView::keepAlive):
4059         * Plugins/PluginViewWin.cpp:
4060         (WebCore::PluginView::wndProc):
4061         * WebView.cpp:
4062         (WebView::closeWindowSoon):
4063
4064 2017-04-08  Chris Dumez  <cdumez@apple.com>
4065
4066         Drop std::chrono support from Timer class
4067         https://bugs.webkit.org/show_bug.cgi?id=170645
4068
4069         Reviewed by Sam Weinig.
4070
4071         Drop std::chrono support from Timer class now that we prefer using Seconds type.
4072
4073         * WebView.cpp:
4074         (WebView::setCacheModel):
4075
4076 2017-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
4077
4078         [WinCairo] WebCore::PlatformDisplay::terminateEGLDisplay causes a crash in libGLESv2.dll while processing atexit
4079         https://bugs.webkit.org/show_bug.cgi?id=170331
4080
4081         Reviewed by Michael Catanzaro.
4082
4083         * WebKitDLL.cpp:
4084         (shutDownWebKit): Call PlatformDisplay::shutDownEglDisplays in shutDownWebKit.
4085
4086 2017-03-30  James Craig  <jcraig@apple.com>
4087
4088         AX: Expose a new AXSubrole for explicit ARIA "group" role
4089         https://bugs.webkit.org/show_bug.cgi?id=169810
4090         <rdar://problem/31039693>
4091
4092         Reviewed by Chris Fleizach.
4093
4094         Account for Windows platform role mapping.
4095
4096         * AccessibleBase.cpp:
4097         (MSAARole):
4098
4099 2017-03-24  Wenson Hsieh  <wenson_hsieh@apple.com>
4100
4101         [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
4102         https://bugs.webkit.org/show_bug.cgi?id=169168
4103         <rdar://problem/30688374>
4104
4105         Reviewed by Tim Horton.
4106
4107         Minor tweak to adjust for a changed interface. See WebKit and WebCore ChangeLogs for more information.
4108
4109         * WebCoreSupport/WebDragClient.cpp:
4110         (WebDragClient::actionMaskForDrag):
4111         * WebCoreSupport/WebDragClient.h:
4112
4113 2017-03-13  Per Arne Vollan  <pvollan@apple.com>
4114
4115         [Win] Compile fix.
4116         https://bugs.webkit.org/show_bug.cgi?id=169545
4117
4118         Reviewed by Brent Fulgham.
4119
4120         Fix inconsistent dll linkage warnings.
4121  
4122         * WebKitDLL.cpp:
4123         * WebKitDLL.h:
4124
4125 2017-03-13  Per Arne Vollan  <pvollan@apple.com>
4126
4127         Unreviewed Win build fix.
4128         
4129         WebCore::CookiesStrategy::addCookie has been removed, we should also remove the override.
4130
4131         * WebCoreSupport/WebPlatformStrategies.cpp:
4132         (WebPlatformStrategies::addCookie): Deleted.
4133         (WebPlatformStrategies::addCookie): Deleted.
4134         * WebCoreSupport/WebPlatformStrategies.h:
4135
4136 2017-03-10  Brent Fulgham  <bfulgham@apple.com>
4137
4138         [Win] Re-export a few symbols for backwards compatibility
4139         https://bugs.webkit.org/show_bug.cgi?id=169490
4140         <rdar://problem/30983623>
4141
4142         Reviewed by Dean Jackson.
4143
4144         Re-introduce a workaround that re-exports a few JavaScriptCore functions
4145         that had been erroneously exported by WebKit in older builds. This
4146         is needed so that we do not break certain old software still being used.
4147
4148         * WebKitDLL.cpp:
4149         (DllMain): Bind functions at startup.
4150         (bindJavaScriptTrampoline): Find JavaScriptCore library functions and
4151         re-export them from WebKit.dll.
4152         * WebKitDLL.h: Only advertise these functions when building WebKt itself.
4153
4154 2017-03-06  Myles C. Maxfield  <mmaxfield@apple.com>
4155
4156         Expand font-weight and font-stretch to take any number
4157         https://bugs.webkit.org/show_bug.cgi?id=168889
4158
4159         Reviewed by Simon Fraser.
4160
4161         Migrate off old enum types.
4162
4163         * WebKitGraphics.cpp:
4164         (makeFont):
4165
4166 2017-03-02  Sam Weinig  <sam@webkit.org>
4167
4168         Rename htmlediting.h/cpp to Editing.h/cpp
4169         https://bugs.webkit.org/show_bug.cgi?id=169103
4170
4171         Reviewed by Alex Christensen.
4172
4173         * AccessibleTextImpl.cpp:
4174
4175 2017-03-01  Alex Christensen  <achristensen