1 2018-05-10 Fujii Hironori <Hironori.Fujii@sony.com>
3 REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
4 https://bugs.webkit.org/show_bug.cgi?id=185505
6 Unreviewed serious crash fix
8 Windows port crashes soon since Bug 184996.
11 (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
12 * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
14 2018-05-07 Daniel Bates <dabates@apple.com>
16 Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
17 https://bugs.webkit.org/show_bug.cgi?id=185170
19 Reviewed by Per Arne Vollan.
24 2018-04-27 Chris Dumez <cdumez@apple.com>
26 Use WindowProxy instead of DOMWindow in our IDL
27 https://bugs.webkit.org/show_bug.cgi?id=185022
29 Reviewed by Sam Weinig.
32 (DOMDocument::getComputedStyle):
34 2018-04-23 Daniel Bates <dabates@apple.com>
36 Implement Same-Site cookies
37 https://bugs.webkit.org/show_bug.cgi?id=159464
38 <rdar://problem/27196358>
40 Reviewed by Brent Fulgham.
42 Pass the Same-Site info through the strategy.
44 * WebCoreSupport/WebPlatformStrategies.cpp:
45 (WebPlatformStrategies::cookiesForDOM):
46 (WebPlatformStrategies::setCookiesFromDOM):
47 (WebPlatformStrategies::cookieRequestHeaderFieldValue):
48 (WebPlatformStrategies::getRawCookies):
49 * WebCoreSupport/WebPlatformStrategies.h:
51 2018-04-23 Daniel Bates <dabates@apple.com>
53 Implement Same-Site cookies
54 https://bugs.webkit.org/show_bug.cgi?id=159464
55 <rdar://problem/27196358>
57 Reviewed by Brent Fulgham.
59 Pass the Same-Site info through the strategy.
61 * WebCoreSupport/WebPlatformStrategies.cpp:
62 (WebPlatformStrategies::cookiesForDOM):
63 (WebPlatformStrategies::setCookiesFromDOM):
64 (WebPlatformStrategies::cookieRequestHeaderFieldValue):
65 (WebPlatformStrategies::getRawCookies):
66 * WebCoreSupport/WebPlatformStrategies.h:
68 2018-04-20 Youenn Fablet <youenn@apple.com>
70 Make PluginData cache its web visible plugins
71 https://bugs.webkit.org/show_bug.cgi?id=184421
73 Reviewed by Chris Dumez.
75 * WebCoreSupport/WebPluginInfoProvider.cpp:
76 (WebPluginInfoProvider::pluginInfo):
77 (WebPluginInfoProvider::webVisiblePluginInfo):
78 * WebCoreSupport/WebPluginInfoProvider.h:
80 2018-04-19 Chris Dumez <cdumez@apple.com>
82 Rename JSDOMWindowProxy to JSWindowProxy
83 https://bugs.webkit.org/show_bug.cgi?id=184797
85 Reviewed by Sam Weinig.
87 Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
90 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
92 2018-04-17 Jonathan Bedard <jbedard@apple.com>
94 Unreviewed rollout of r230632. Regression in memory usage.
96 That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
99 (WebPreferences::initializeDefaultSettings):
101 2018-04-17 Chris Dumez <cdumez@apple.com>
103 Unreviewed attempt to fix the Windows build after r230721
105 * WebCoreSupport/WebFrameLoaderClient.cpp:
106 (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
108 2018-04-17 Chris Dumez <cdumez@apple.com>
110 REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
111 https://bugs.webkit.org/show_bug.cgi?id=184678
112 <rdar://problem/39422122>
114 Reviewed by Alex Christensen.
116 Add new parameter to dispatchDecidePolicyForNavigationAction.
118 * WebCoreSupport/WebFrameLoaderClient.cpp:
119 (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
120 * WebCoreSupport/WebFrameLoaderClient.h:
122 2018-04-12 Antoine Quint <graouts@apple.com>
124 [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
125 https://bugs.webkit.org/show_bug.cgi?id=184569
126 <rdar://problem/38671301>
130 Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
132 * WebPreferences.cpp:
134 2018-04-05 Yusuke Suzuki <utatane.tea@gmail.com>
136 [WTF] Remove StaticLock
137 https://bugs.webkit.org/show_bug.cgi?id=184332
139 Reviewed by Mark Lam.
141 * WebKitQuartzCoreAdditions/CAView.cpp:
142 (WKQCA::CAView::releaseAllD3DResources):
143 * WebLocalizableStrings.cpp:
145 2018-04-03 Chris Dumez <cdumez@apple.com>
148 https://bugs.webkit.org/show_bug.cgi?id=184191
150 Reviewed by Darin Adler.
152 Drop MainFrame class and move contents into Page / Frame since there is a 1:1
153 relationship between the Page and the MainFrame.
155 This is ground work for introducing LocalFrame / RemoteFrame concepts.
157 * WebCoreSupport/AcceleratedCompositingContext.cpp:
158 * WebCoreSupport/WebContextMenuClient.cpp:
159 * WebCoreSupport/WebDragClient.cpp:
164 2018-03-26 Chris Dumez <cdumez@apple.com>
166 Use SecurityOriginData more consistently in Service Worker code
167 https://bugs.webkit.org/show_bug.cgi?id=183969
169 Reviewed by Darin Adler.
171 Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
173 * WebDatabaseManager.cpp:
174 (WebDatabaseManager::databasesWithOrigin):
175 (WebDatabaseManager::deleteOrigin):
176 (WebDatabaseManager::deleteDatabase):
177 (WebDatabaseManager::setQuota):
178 * WebSecurityOrigin.cpp:
179 (WebSecurityOrigin::usage):
180 (WebSecurityOrigin::quota):
181 (WebSecurityOrigin::setQuota):
183 2018-03-26 Brent Fulgham <bfulgham@apple.com>
185 Warn against cookie access in the WebContent process using ProcessPrivilege assertions
186 https://bugs.webkit.org/show_bug.cgi?id=183911
187 <rdar://problem/38762306>
189 Reviewed by Youenn Fablet.
191 Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
196 2018-03-25 Commit Queue <commit-queue@webkit.org>
198 Unreviewed, rolling out r229954.
199 https://bugs.webkit.org/show_bug.cgi?id=184000
201 Caused many layout tests to crash on Apple High Sierra,
202 Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
207 "Use SecurityOriginData more consistently in Service Worker
209 https://bugs.webkit.org/show_bug.cgi?id=183969
210 https://trac.webkit.org/changeset/229954
212 2018-03-24 Chris Dumez <cdumez@apple.com>
214 Use SecurityOriginData more consistently in Service Worker code
215 https://bugs.webkit.org/show_bug.cgi?id=183969
217 Reviewed by Darin Adler.
219 Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
221 * WebDatabaseManager.cpp:
222 (WebDatabaseManager::databasesWithOrigin):
223 (WebDatabaseManager::deleteOrigin):
224 (WebDatabaseManager::deleteDatabase):
225 (WebDatabaseManager::setQuota):
226 * WebSecurityOrigin.cpp:
227 (WebSecurityOrigin::usage):
228 (WebSecurityOrigin::quota):
229 (WebSecurityOrigin::setQuota):
231 2018-03-23 Chris Dumez <cdumez@apple.com>
233 Unreviewed attempt to fix Windows build after r229926.
237 2018-03-23 Brady Eidson <beidson@apple.com>
239 Go to back/forward list items after a process-swapped navigation.
240 <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
242 Reviewed by Andy Estes.
245 (WebView::goToBackForwardItem):
246 (WebView::loadBackForwardListFromOtherView):
248 2018-03-23 Miguel Gomez <magomez@igalia.com>
250 [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
251 https://bugs.webkit.org/show_bug.cgi?id=183892
253 Remove the UpdateContentsFlag parameter as it's not used anymore.
255 Reviewed by Žan Doberšek.
257 * WebCoreSupport/AcceleratedCompositingContext.cpp:
258 (AcceleratedCompositingContext::acceleratedCompositingAvailable):
260 2018-03-15 Yousuke Kimoto <yousuke.kimoto@sony.com>
262 [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
263 https://bugs.webkit.org/show_bug.cgi?id=183335
265 Reviewed by Alex Christensen.
267 * Plugins/PluginDatabaseWin.cpp:
268 * Plugins/PluginMessageThrottlerWin.cpp:
269 (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
270 * Plugins/PluginPackageWin.cpp:
271 (WebCore::PluginPackage::load):
272 * Plugins/PluginView.h:
273 * Plugins/PluginViewWin.cpp:
275 * WebCoreSupport/WebFrameLoaderClient.cpp:
276 (WebFrameLoaderClient::createPlugin):
277 (WebFrameLoaderClient::createJavaAppletWidget):
279 (WebView::WebViewWndProc):
281 2018-03-13 Ross Kirsling <ross.kirsling@sony.com>
283 [Win] Layout Test fast/html/menuitem-element.html is failing.
284 https://bugs.webkit.org/show_bug.cgi?id=179299
286 Reviewed by Per Arne Vollan.
288 * Interfaces/IWebPreferencesPrivate.idl:
289 * WebPreferenceKeysPrivate.h:
290 * WebPreferences.cpp:
291 (WebPreferences::menuItemElementEnabled):
292 (WebPreferences::setMenuItemElementEnabled):
295 (WebView::notifyPreferencesChanged):
296 Add private web preference "menuItemElementEnabled".
298 2018-03-12 Antoine Quint <graouts@apple.com>
300 [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
301 https://bugs.webkit.org/show_bug.cgi?id=183504
302 <rdar://problem/38372965>
304 Reviewed by Dean Jackson and Jon Lee.
306 Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
307 which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
309 * Interfaces/IWebPreferencesPrivate.idl:
310 * WebPreferences.cpp:
311 (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
312 (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
313 * WebPreferenceKeysPrivate.h
316 (WebView::notifyPreferencesChanged):
318 2018-03-08 Yusuke Suzuki <utatane.tea@gmail.com>
320 [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
321 https://bugs.webkit.org/show_bug.cgi?id=183429
323 Reviewed by Mark Lam.
326 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
328 2018-03-08 Tim Horton <timothy_horton@apple.com>
330 Stop linking ApplicationServices directly
331 https://bugs.webkit.org/show_bug.cgi?id=182867
332 <rdar://problem/38252142>
334 Reviewed by Alex Christensen.
336 The frameworks that we use that live inside ApplicationServices
337 have mostly moved out, so import them directly.
339 * FullscreenVideoController.cpp:
341 2018-03-05 Yusuke Suzuki <utatane.tea@gmail.com>
343 Fix std::make_unique / new[] using system malloc
344 https://bugs.webkit.org/show_bug.cgi?id=182975
346 Reviewed by JF Bastien.
350 * MarshallingHelpers.cpp:
351 (MarshallingHelpers::safeArrayToStringArray):
352 (MarshallingHelpers::safeArrayToIntArray):
353 * Plugins/PluginPackageWin.cpp:
354 (WebCore::PluginPackage::fetchInfo):
355 * WebPreferences.cpp:
356 (WebPreferences::copyWebKitPreferencesToCFPreferences):
358 (WebView::onMenuCommand):
360 2018-03-04 Yusuke Suzuki <utatane.tea@gmail.com>
362 [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
363 https://bugs.webkit.org/show_bug.cgi?id=183312
365 Reviewed by Mark Lam.
367 Remove wtf/CurrentTime.h include pragma.
370 * WebDownloadCFNet.cpp:
373 2018-03-01 Yusuke Suzuki <utatane.tea@gmail.com>
375 Remove monotonicallyIncreasingTime
376 https://bugs.webkit.org/show_bug.cgi?id=182911
378 Reviewed by Michael Catanzaro.
380 * FullscreenVideoController.cpp:
381 (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
382 * Plugins/PluginMessageThrottlerWin.cpp:
383 (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
384 (WebCore::PluginMessageThrottlerWin::appendMessage):
385 * Plugins/PluginMessageThrottlerWin.h:
387 (WebView::notifyAnimationStarted):
390 2018-03-01 Ross Kirsling <ross.kirsling@sony.com>
392 [Win][DRT] Implement setSpatialNavigationEnabled.
393 https://bugs.webkit.org/show_bug.cgi?id=183166
395 Reviewed by Per Arne Vollan.
397 Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
399 * Interfaces/IWebPreferencesPrivate.idl:
400 * WebPreferenceKeysPrivate.h:
401 * WebPreferences.cpp:
402 (WebPreferences::initializeDefaultSettings):
403 (WebPreferences::spatialNavigationEnabled):
404 (WebPreferences::setSpatialNavigationEnabled):
407 (WebView::notifyPreferencesChanged):
409 2018-02-28 Alex Christensen <achristensen@webkit.org>
411 Reduce use of NetworkingContext in WebKit
412 https://bugs.webkit.org/show_bug.cgi?id=183213
414 Reviewed by Brady Eidson.
416 * Plugins/PluginView.cpp:
417 (WebCore::PluginView::getValueForURL):
419 2018-02-26 Don Olmstead <don.olmstead@sony.com>
421 Fix WebCore includes within WebKitLegacy
422 https://bugs.webkit.org/show_bug.cgi?id=183147
424 Reviewed by Tim Horton.
426 * Plugins/PluginDatabase.cpp:
427 * Plugins/PluginDatabaseWin.cpp:
428 * Plugins/PluginDebug.cpp:
429 * Plugins/PluginDebug.h:
430 * Plugins/PluginMainThreadScheduler.cpp:
431 * Plugins/PluginMessageThrottlerWin.cpp:
432 * Plugins/PluginMessageThrottlerWin.h:
433 * Plugins/PluginPackage.cpp:
434 * Plugins/PluginPackage.h:
435 * Plugins/PluginPackageWin.cpp:
436 * Plugins/PluginStream.cpp:
437 * Plugins/PluginStream.h:
438 * Plugins/PluginView.cpp:
439 * Plugins/PluginView.h:
440 * Plugins/PluginViewWin.cpp:
442 * WebCoreSupport/WebChromeClient.cpp:
443 * WebCoreSupport/WebContextMenuClient.cpp:
444 * WebCoreSupport/WebFrameLoaderClient.cpp:
445 * WebCoreSupport/WebInspectorClient.cpp:
446 * WebCoreSupport/WebPlatformStrategies.cpp:
448 * WebKitMessageLoop.cpp:
450 * storage/WebDatabaseProvider.cpp:
452 2018-02-22 Yusuke Suzuki <utatane.tea@gmail.com>
454 Remove currentTime() / currentTimeMS()
455 https://bugs.webkit.org/show_bug.cgi?id=183052
457 Reviewed by Mark Lam.
459 * WebCoreSupport/WebFrameLoaderClient.cpp:
460 (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
461 * WebCoreSupport/WebFrameLoaderClient.h:
463 * WebDownloadCFNet.cpp:
464 (WebDownload::didStart):
465 (WebDownload::didReceiveData):
466 (WebDownload::didFinish):
468 2018-02-21 Don Olmstead <don.olmstead@sony.com>
470 [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
471 https://bugs.webkit.org/show_bug.cgi?id=182883
473 Reviewed by Per Arne Vollan.
477 2018-02-16 Dean Jackson <dino@apple.com>
479 Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
480 https://bugs.webkit.org/show_bug.cgi?id=182894
482 Reviewed by Tim Horton.
484 Rename OPENGL_ES_2 to OPENGL_ES.
486 * WebCoreSupport/AcceleratedCompositingContext.cpp:
488 2018-02-16 Youenn Fablet <youenn@apple.com>
490 Allow specifying which plug-ins are supported
491 https://bugs.webkit.org/show_bug.cgi?id=182748
493 Reviewed by Chris Dumez.
495 * WebCoreSupport/WebPluginInfoProvider.cpp:
496 (WebPluginInfoProvider::getPluginInfo):
497 * WebCoreSupport/WebPluginInfoProvider.h:
499 2018-02-15 Don Olmstead <don.olmstead@sony.com>
501 WebCore headers should not be included relatively within dependent projects
502 https://bugs.webkit.org/show_bug.cgi?id=182805
504 Reviewed by Chris Dumez.
506 * FullscreenVideoController.h:
508 2018-02-13 Commit Queue <commit-queue@webkit.org>
510 Unreviewed, rolling out r228431.
511 https://bugs.webkit.org/show_bug.cgi?id=182766
513 Regressed CMake build stability (Requested by dolmstead on
518 "[CMake] Make WebCore headers copies"
519 https://bugs.webkit.org/show_bug.cgi?id=182512
520 https://trac.webkit.org/changeset/228431
522 2018-02-13 Don Olmstead <don.olmstead@sony.com>
524 [CMake] Make WebCore headers copies
525 https://bugs.webkit.org/show_bug.cgi?id=182512
527 Reviewed by Keith Miller.
529 * FullscreenVideoController.h:
530 * Plugins/PluginDatabase.cpp:
531 * Plugins/PluginDatabaseWin.cpp:
532 * Plugins/PluginDebug.cpp:
533 * Plugins/PluginMainThreadScheduler.cpp:
534 * Plugins/PluginMessageThrottlerWin.cpp:
535 * Plugins/PluginPackage.cpp:
536 * Plugins/PluginPackageWin.cpp:
537 * Plugins/PluginStream.cpp:
538 * Plugins/PluginView.cpp:
539 * Plugins/PluginViewWin.cpp:
541 * WebKitMessageLoop.cpp:
543 * storage/WebDatabaseProvider.cpp:
545 2018-01-13 Darin Adler <darin@apple.com>
548 https://bugs.webkit.org/show_bug.cgi?id=179591
550 Reviewed by Chris Dumez.
552 * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
553 * WebFrame.cpp: Ditto.
555 * WebScriptWorld.cpp:
556 (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
558 * WebView.cpp: Removed include of ScriptValue.h.
559 (WebView::handleEditingKeyboardEvent): Updated for name change from
560 keyEvent to underlyingPlatformEvent.
562 2018-02-06 Don Olmstead <don.olmstead@sony.com>
564 Remove WebCore/ForwardingHeaders directory
565 https://bugs.webkit.org/show_bug.cgi?id=182347
567 Reviewed by Keith Miller.
569 * Plugins/PluginView.cpp:
570 * Plugins/PluginViewWin.cpp:
571 * WebCoreSupport/WebInspectorClient.cpp:
572 * WebCoreSupport/WebInspectorClient.h:
574 * WebJavaScriptCollector.cpp:
577 2018-01-24 Wenson Hsieh <wenson_hsieh@apple.com>
579 Unreviewed, another attempt to fix the Windows build after r227479.
582 (WebFrame::elementWithName):
584 2018-01-24 Wenson Hsieh <wenson_hsieh@apple.com>
586 Unreviewed, try to fix the Windows build after r227479.
588 Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
591 (WebFrame::elementWithName):
592 (WebFrame::controlsInForm):
594 2018-01-19 Per Arne Vollan <pvollan@apple.com>
596 [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
597 https://bugs.webkit.org/show_bug.cgi?id=181859
598 <rdar://problem/36659886>
600 Reviewed by Alex Christensen.
602 Use local include patch.
604 * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
605 * WebKitQuartzCoreAdditions/API/WKCACFView.h:
606 * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
608 2018-01-17 Youenn Fablet <youenn@apple.com>
610 Put fetch Request.keepalive behind a runtime flag
611 https://bugs.webkit.org/show_bug.cgi?id=181592
613 Reviewed by Chris Dumez.
615 * WebPreferences.cpp:
616 (WebPreferences::fetchAPIKeepAliveEnabled):
617 (WebPreferences::setFetchAPIKeepAliveEnabled):
620 (WebView::notifyPreferencesChanged):
622 2018-01-17 Wenson Hsieh <wenson_hsieh@apple.com>
624 Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
625 https://bugs.webkit.org/show_bug.cgi?id=181637
626 <rdar://problem/36508471>
628 Reviewed by Tim Horton.
630 Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
632 * WebCoreSupport/WebEditorClient.cpp:
633 (WebEditorClient::replacementURLForResource):
634 * WebCoreSupport/WebEditorClient.h:
636 2017-12-28 Yusuke Suzuki <utatane.tea@gmail.com>
638 Remove std::chrono completely
639 https://bugs.webkit.org/show_bug.cgi?id=181186
641 Reviewed by Alex Christensen.
643 * Plugins/PluginStream.cpp:
644 (WebCore::lastModifiedDateMS):
646 2018-01-02 Fujii Hironori <Hironori.Fujii@sony.com>
648 [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
649 https://bugs.webkit.org/show_bug.cgi?id=181173
651 Reviewed by Alex Christensen.
653 * WebNodeHighlight.cpp:
654 (WebNodeHighlight::update): Scale the GraphicsContext.
656 2017-12-26 Carlos Alberto Lopez Perez <clopez@igalia.com>
658 REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
659 https://bugs.webkit.org/show_bug.cgi?id=181160
661 Reviewed by Myles C. Maxfield.
663 * Plugins/PluginView.cpp:
664 (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
666 2017-12-21 Jeremy Jones <jeremyj@apple.com>
668 Enable picture-in-picture from inline element on suspend.
669 https://bugs.webkit.org/show_bug.cgi?id=180942
670 rdar://problem/34745234
672 Reviewed by Jer Noble.
674 Update signature of enterVideoFullscreenForVideoElement.
676 * WebCoreSupport/WebChromeClient.cpp:
677 (WebChromeClient::enterVideoFullscreenForVideoElement):
678 * WebCoreSupport/WebChromeClient.h:
680 2017-12-18 Fujii Hironori <Hironori.Fujii@sony.com>
682 [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
683 https://bugs.webkit.org/show_bug.cgi?id=180926
685 Reviewed by Tim Horton.
687 Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
688 of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
690 * WebCoreSupport/WebFrameLoaderClient.cpp:
691 (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
692 (WebFrameLoaderClient::pageID const): Ditto.
694 2017-12-16 Yusuke Suzuki <utatane.tea@gmail.com>
696 Remove unnecessary boolean result of start() functions
697 https://bugs.webkit.org/show_bug.cgi?id=180856
699 Reviewed by Darin Adler.
701 It always returns true.
703 * WebDownloadCurl.cpp:
704 (WebDownload::start):
706 2017-12-14 John Wilander <wilander@apple.com>
708 Storage Access API: Implement frame-specific access in the document.cookie layer
709 https://bugs.webkit.org/show_bug.cgi?id=180682
710 <rdar://problem/35982257>
712 Reviewed by Alex Christensen.
714 CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
715 CookiesStrategy::cookieRequestHeaderFieldValue(), and
716 CookiesStrategy::getRawCookies() now take optional parameters for
717 frameID and pageID to allow frame-specific scoping of cookies.
719 This change makes the return values of FrameLoaderClient::frameID()
720 and FrameLoaderClient::pageID() std::optional<uint64_t> so that
721 WebCore can call those getters and get the right return values in
722 WebKit and std:nullopt in WebKitLegacy.
724 * WebCoreSupport/WebFrameLoaderClient.cpp:
725 (WebFrameLoaderClient::pageID const):
726 (WebFrameLoaderClient::frameID const):
727 Now return an optional.
728 * WebCoreSupport/WebFrameLoaderClient.h:
729 * WebCoreSupport/WebPlatformStrategies.cpp:
730 (WebPlatformStrategies::cookiesForDOM):
731 (WebPlatformStrategies::setCookiesFromDOM):
732 (WebPlatformStrategies::cookieRequestHeaderFieldValue):
733 (WebPlatformStrategies::getRawCookies):
734 * WebCoreSupport/WebPlatformStrategies.h:
736 2017-12-12 Yusuke Suzuki <utatane.tea@gmail.com>
738 [WTF] Thread::create should have Thread::tryCreate
739 https://bugs.webkit.org/show_bug.cgi?id=180333
741 Reviewed by Darin Adler.
743 * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
744 (WKQCA::CVDisplayLink::start):
746 2017-12-08 Yusuke Suzuki <utatane.tea@gmail.com>
748 Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
749 https://bugs.webkit.org/show_bug.cgi?id=180572
751 Reviewed by Mark Lam.
753 Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
754 Also we use Lock instead of Mutex.
756 * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
757 (WKQCA::CAD3DRenderer::swapChain):
758 (WKQCA::CAD3DRenderer::renderAndPresent):
759 (WKQCA::CAD3DRenderer::renderToImage):
760 (WKQCA::CAD3DRenderer::setDeviceIsLost):
761 (WKQCA::CAD3DRenderer::renderInternal):
762 * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
763 * WebKitQuartzCoreAdditions/CAView.cpp:
764 (WKQCA::CAView::Handle::create):
765 Return Ref<Handle> instead of RefPtr<>.
767 (WKQCA::CAView::Handle::lock):
768 (WKQCA::CAView::Handle::view const):
769 (WKQCA::CAView::Handle::clear):
771 (WKQCA::viewsNeedingUpdate):
772 (WKQCA::CAView::releaseAllD3DResources):
773 (WKQCA::CAView::CAView):
774 (WKQCA::CAView::~CAView):
775 (WKQCA::CAView::setLayer):
776 (WKQCA::CAView::update):
777 (WKQCA::CAView::drawToWindow):
778 (WKQCA::CAView::drawToWindowInternal):
779 (WKQCA::CAView::drawToImage):
780 (WKQCA::CAView::willDraw):
781 (WKQCA::CAView::drawIntoDC):
782 (WKQCA::CAView::setShouldInvertColors):
783 (WKQCA::CAView::scheduleNextDraw):
784 (WKQCA::CAView::displayLinkReachedCAMediaTime):
785 (WKQCA::CAView::contextDidChange):
786 (WKQCA::CAView::updateSoon):
787 (WKQCA::CAView::updateViewsNow):
788 (WKQCA::CAView::d3dDevice9):
789 (WKQCA::CAView::Handle::mutex): Deleted.
790 (WKQCA::globalStateMutex): Deleted.
792 * WebKitQuartzCoreAdditions/CAView.h:
794 2017-12-07 Yusuke Suzuki <utatane.tea@gmail.com>
796 Use StaticLock instead of NeverDestroyed<Lock>
797 https://bugs.webkit.org/show_bug.cgi?id=180507
799 Reviewed by Saam Barati.
801 * WebLocalizableStrings.cpp:
804 (mainBundleLocStrings): Deleted.
805 (frameworkLocStringsMutex): Deleted.
807 2017-12-05 Per Arne Vollan <pvollan@apple.com>
809 [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
810 https://bugs.webkit.org/show_bug.cgi?id=180431
811 <rdar://problem/34531264>
813 Reviewed by Simon Fraser.
815 Fix the signatures of GraphicsLayerClient that should have been overridden, and use
816 'override' to make sure this doesn't break in the future.
819 (WebView::notifyAnimationStarted):
820 (WebView::paintContents):
823 2017-11-23 Darin Adler <darin@apple.com>
825 Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
826 https://bugs.webkit.org/show_bug.cgi?id=179981
828 Reviewed by Sam Weinig.
831 (WebView::searchFor): Use |= instead of | to build FindOptions.
832 (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
833 (WebView::findString): Create FindOptions with |=; the old code just passed a
834 WebKit FindOptions through without converting to WebCore::FindOptions.
836 2017-11-23 Darin Adler <darin@apple.com>
838 Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
839 https://bugs.webkit.org/show_bug.cgi?id=179907
841 Reviewed by Sam Weinig.
843 * Plugins/PluginDatabaseWin.cpp:
844 (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
845 startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
846 * WebDownloadCFNet.cpp:
847 (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
850 (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
851 to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
852 be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
853 happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
854 the code does not cause any change in behavior.
856 2017-11-22 Ali Juma <ajuma@chromium.org>
858 Implement VisualViewport API attributes
859 https://bugs.webkit.org/show_bug.cgi?id=179385
861 Reviewed by Frédéric Wang.
863 Add a VisualViewportAPI preference.
865 * Interfaces/IWebPreferencesPrivate.idl:
866 * WebPreferenceKeysPrivate.h:
867 * WebPreferences.cpp:
868 (WebPreferences::initializeDefaultSettings):
869 (WebPreferences::visualViewportAPIEnabled):
870 (WebPreferences::setVisualViewportAPIEnabled):
873 (WebView::notifyPreferencesChanged):
875 2017-11-22 Commit Queue <commit-queue@webkit.org>
877 Unreviewed, rolling out r225093.
878 https://bugs.webkit.org/show_bug.cgi?id=179938
880 Compilation failed on WinCairo 64-bit Release (Requested by
885 "Implement VisualViewport API attributes"
886 https://bugs.webkit.org/show_bug.cgi?id=179385
887 https://trac.webkit.org/changeset/225093
889 2017-11-21 Ali Juma <ajuma@chromium.org>
891 Implement VisualViewport API attributes
892 https://bugs.webkit.org/show_bug.cgi?id=179385
894 Reviewed by Frédéric Wang.
896 Add a VisualViewportAPI preference.
898 * Interfaces/IWebPreferencesPrivate.idl:
899 * WebPreferenceKeysPrivate.h:
900 * WebPreferences.cpp:
901 (WebPreferences::initializeDefaultSettings):
902 (WebPreferences::visualViewportAPIEnabled):
903 (WebPreferences::setVisualViewportAPIEnabled):
906 (WebView::notifyPreferencesChanged):
908 2017-11-14 Alex Christensen <achristensen@webkit.org>
910 Clean up old URL parser remnants
911 https://bugs.webkit.org/show_bug.cgi?id=179573
913 Reviewed by Darin Adler.
915 * WebCoreSupport/WebContextMenuClient.cpp:
916 (WebContextMenuClient::searchWithGoogle):
917 Use https if we do end up searching with google.
919 2017-11-12 Darin Adler <darin@apple.com>
921 More is<> and downcast<>, less static_cast<>
922 https://bugs.webkit.org/show_bug.cgi?id=179600
924 Reviewed by Chris Dumez.
927 (WebView::handleEditingKeyboardEvent): Use downcast.
929 2017-11-09 Christopher Reid <chris.reid@sony.com>
931 Use enum classes within FileSystem
932 https://bugs.webkit.org/show_bug.cgi?id=175172
934 Reviewed by Darin Adler.
936 * Plugins/PluginDatabase.cpp:
938 2017-11-06 Per Arne Vollan <pvollan@apple.com>
940 [Win] Add WebKitQuartzCoreAdditions library.
941 https://bugs.webkit.org/show_bug.cgi?id=179331
943 Reviewed by Alex Christensen.
945 * WebKitQuartzCoreAdditions: Added.
946 * WebKitQuartzCoreAdditions/API: Added.
947 * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
949 (WKCACFImageGetWidth):
950 (WKCACFImageGetHeight):
951 (WKCACFImageCopyFileMapping):
952 (WKCACFImageCreateWithImage):
953 (WKCACFImageFinalize):
954 (WKCACFImageCopyFormattingDescription):
955 (WKCACFImageCopyDebugDescription):
956 (WKCACFImageGetTypeID):
957 * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
958 * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
959 * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
963 (WKCACFViewSetLayer):
965 (WKCACFViewFlushContext):
966 (WKCACFViewInvalidateRects):
969 (WKCACFViewCopyDrawnImage):
970 (WKCACFViewDrawIntoDC):
971 (contextDidChangeCallback):
972 (WKCACFViewSetContextDidChangeCallback):
973 (WKCACFViewGetLastCommitTime):
974 (WKCACFViewSetContextUserData):
975 (WKCACFViewGetContext):
976 (WKCACFViewFinalize):
977 (WKCACFViewCopyFormattingDescription):
978 (WKCACFViewCopyDebugDescription):
979 (WKCACFViewGetTypeID):
980 (WKCACFViewSetShouldInvertColors):
981 (WKCACFViewGetD3DDevice9):
982 * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
983 * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
984 * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
985 (WKQCA::dllInstance):
988 * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
989 * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
990 (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
992 (WKQCA::initialPresentationParameters):
993 (WKQCA::CAD3DRenderer::shared):
994 (WKQCA::CAD3DRenderer::CAD3DRenderer):
995 (WKQCA::CAD3DRenderer::swapChain):
996 (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
997 (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
998 (WKQCA::CAD3DRenderer::initialize):
999 (WKQCA::D3DMatrixOrthoOffCenterRH):
1000 (WKQCA::prepareDevice):
1001 (WKQCA::updateBounds):
1002 (WKQCA::CAD3DRenderer::renderAndPresent):
1003 (WKQCA::CAD3DRenderer::renderToImage):
1004 (WKQCA::CAD3DRenderer::setDeviceIsLost):
1005 (WKQCA::CAD3DRenderer::renderInternal):
1006 (WKQCA::CAD3DRenderer::postProcess):
1007 (WKQCA::CAD3DRenderer::resetD3DDevice):
1008 (WKQCA::CAD3DRenderer::createShaderIfNeeded):
1009 (WKQCA::CAD3DRenderer::release):
1010 * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
1011 (WKQCA::D3DPostProcessingContext::sceneTexture const):
1012 (WKQCA::D3DPostProcessingContext::overlayQuad const):
1013 (WKQCA::CAD3DRenderer::d3dDevice9 const):
1014 * WebKitQuartzCoreAdditions/CAView.cpp: Added.
1015 (WKQCA::CAView::Handle::create):
1016 (WKQCA::CAView::Handle::~Handle):
1017 (WKQCA::CAView::Handle::mutex):
1018 (WKQCA::CAView::Handle::view const):
1019 (WKQCA::CAView::Handle::clear):
1020 (WKQCA::CAView::Handle::Handle):
1021 (WKQCA::globalStateMutex):
1022 (WKQCA::registerMessageWindowClass):
1023 (WKQCA::createMessageWindow):
1024 (WKQCA::CAView::releaseAllD3DResources):
1025 (WKQCA::CAView::CAView):
1026 (WKQCA::CAView::~CAView):
1027 (WKQCA::CAView::create):
1028 (WKQCA::CAView::setContextDidChangeCallback):
1029 (WKQCA::CAView::setLayer):
1030 (WKQCA::CAView::update):
1031 (WKQCA::CAView::invalidateRects):
1032 (WKQCA::CAView::drawToWindow):
1033 (WKQCA::CAView::drawToWindowInternal):
1034 (WKQCA::CAView::drawToImage):
1035 (WKQCA::CAView::willDraw):
1036 (WKQCA::CAView::didDraw):
1037 (WKQCA::CAView::drawIntoDC):
1038 (WKQCA::CAView::setShouldInvertColors):
1039 (WKQCA::CAView::scheduleNextDraw):
1040 (WKQCA::CAView::displayLinkReachedCAMediaTime):
1041 (WKQCA::CAView::contextDidChangeCallback):
1042 (WKQCA::CAView::contextDidChange):
1043 (WKQCA::CAView::updateSoon):
1044 (WKQCA::CAView::updateViewsNow):
1045 (WKQCA::CAView::d3dDevice9):
1046 * WebKitQuartzCoreAdditions/CAView.h: Added.
1047 (WKQCA::CAView::context const):
1048 (WKQCA::CAView::canDraw const):
1049 (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
1050 * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
1051 * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
1052 (WKQCA::CVDisplayLink::CVDisplayLink):
1053 (WKQCA::CVDisplayLink::~CVDisplayLink):
1054 (WKQCA::CVDisplayLink::create):
1055 (WKQCA::CVDisplayLink::start):
1056 (WKQCA::CVDisplayLink::stop):
1057 (WKQCA::CVDisplayLink::setPaused):
1058 (WKQCA::CVDisplayLink::runIOThread):
1059 * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
1060 * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
1061 (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
1062 * WebKitQuartzCoreAdditions/Image.cpp: Added.
1063 (WKQCA::numBytesForSize):
1064 (WKQCA::Image::create):
1065 (WKQCA::Image::Image):
1066 (WKQCA::Image::~Image):
1067 (WKQCA::bitmapInfo):
1068 (WKQCA::Image::createDIB const):
1069 (WKQCA::Image::copyFileMapping):
1070 * WebKitQuartzCoreAdditions/Image.h: Added.
1071 (WKQCA::Image::size const):
1072 * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
1073 (WKQCA::getBackBufferRectAsRenderTarget):
1074 (WKQCA::getSystemMemoryCopy):
1075 (WKQCA::copyRectToBitmap):
1076 (WKQCA::getImageCopy):
1077 (WKQCA::getBackBufferRectAsImage):
1078 * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
1079 * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
1080 * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
1081 * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
1082 * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
1084 2017-11-06 Christopher Reid <chris.reid@sony.com>
1086 Use enum classes within FileSystem
1087 https://bugs.webkit.org/show_bug.cgi?id=175172
1089 Reviewed by Myles C. Maxfield.
1091 * Plugins/PluginDatabase.cpp:
1093 2017-11-02 Maciej Stachowiak <mjs@apple.com>
1095 Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
1096 https://bugs.webkit.org/show_bug.cgi?id=178333
1098 Reviewed by Darin Adler.
1100 * WebCoreSupport/WebFrameLoaderClient.cpp:
1101 (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
1103 2017-11-02 Alex Christensen <achristensen@webkit.org>
1105 Use CompletionHandlers for redirects
1106 https://bugs.webkit.org/show_bug.cgi?id=179163
1108 Reviewed by Tim Horton.
1110 * Plugins/PluginStream.cpp:
1111 (WebCore::PluginStream::willSendRequest):
1112 * Plugins/PluginStream.h:
1113 (WebCore::PluginStreamClient::~PluginStreamClient):
1114 (WebCore::PluginStreamClient::streamDidFinishLoading):
1115 (WebCore::PluginStream::create):
1116 (WebCore::PluginStream::setLoadManually):
1118 2017-11-02 Christopher Reid <chris.reid@sony.com>
1120 Add a FileSystem namespace to FileSystem.cpp
1121 https://bugs.webkit.org/show_bug.cgi?id=179063
1123 Reviewed by Darin Adler.
1125 * Plugins/PluginDatabase.cpp:
1126 * Plugins/PluginPackage.cpp:
1127 * Plugins/PluginStream.cpp:
1128 * Plugins/PluginStream.h:
1129 * WebApplicationCache.cpp:
1130 * WebDatabaseManager.cpp:
1131 * WebDownloadCurl.cpp:
1132 * WebPreferences.cpp:
1135 2017-10-31 Alex Christensen <achristensen@webkit.org>
1137 Fix Windows build after r224260
1142 2017-10-28 Zalan Bujtas <zalan@apple.com>
1144 [FrameView::layout cleanup] Move core layout logic to a separate class.
1145 https://bugs.webkit.org/show_bug.cgi?id=178771
1146 <rdar://problem/35166542>
1148 Reviewed by Simon Fraser.
1150 Move layout code out from FrameView to LayoutContext.
1155 2017-10-26 Alex Christensen <achristensen@webkit.org>
1158 https://bugs.webkit.org/show_bug.cgi?id=178892
1160 * AccessibleBase.cpp:
1163 2017-10-26 Alex Christensen <achristensen@webkit.org>
1166 https://bugs.webkit.org/show_bug.cgi?id=178892
1168 * AccessibleBase.cpp:
1169 (AccessibleBase::state const):
1172 2017-10-25 Youenn Fablet <youenn@apple.com>
1174 Enable ServiceWorker to fetch resources
1175 https://bugs.webkit.org/show_bug.cgi?id=178673
1177 Reviewed by Brady Eidson.
1179 Added implementation to the new getters.
1180 They are noop in the context of WK1.
1182 * WebCoreSupport/WebFrameLoaderClient.cpp:
1183 (WebFrameLoaderClient::pageID const):
1184 (WebFrameLoaderClient::frameID const):
1185 (WebFrameLoaderClient::sessionID const):
1186 * WebCoreSupport/WebFrameLoaderClient.h:
1188 2017-10-20 Antoine Quint <graouts@apple.com>
1190 [Web Animations] Provide basic timeline and animation interfaces
1191 https://bugs.webkit.org/show_bug.cgi?id=178526
1193 Reviewed by Dean Jackson.
1195 Remove the WEB_ANIMATIONS compile-time flag.
1198 (WebView::notifyPreferencesChanged):
1200 2017-10-20 Basuke Suzuki <Basuke.Suzuki@sony.com>
1202 [Curl] Clean up old style code in old curl files.
1203 https://bugs.webkit.org/show_bug.cgi?id=178569
1205 Reviewed by Ryosuke Niwa.
1208 (WebCache::cacheFolder):
1209 (WebCache::setCacheFolder):
1211 (WebView::setCacheModel):
1213 2017-10-19 Sam Weinig <sam@webkit.org>
1215 [Settings] Move global settings into their own file
1216 https://bugs.webkit.org/show_bug.cgi?id=178512
1218 Reviewed by Darin Adler.
1220 Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1223 (WebView::initWithFrame):
1225 2017-10-17 Jiewen Tan <jiewen_tan@apple.com>
1227 Replace some stack raw pointers with RefPtrs within WebCore/html
1228 https://bugs.webkit.org/show_bug.cgi?id=178201
1229 <rdar://problem/34841692>
1231 Reviewed by Ryosuke Niwa.
1234 (WebView::handleEditingKeyboardEvent):
1235 Change the type of node as toNode() is changed to return RefPtr.
1237 2017-10-16 Sam Weinig <sam@webkit.org>
1239 [Settings] Remove all custom code from Settings.h/cpp
1240 https://bugs.webkit.org/show_bug.cgi?id=178330
1242 Reviewed by Simon Fraser.
1245 (WebView::notifyPreferencesChanged):
1247 Update for naming changes of FrameFlattening now that it is an enum class.
1249 2017-10-11 Chris Dumez <cdumez@apple.com>
1251 Modernize Geolocation code
1252 https://bugs.webkit.org/show_bug.cgi?id=178148
1254 Reviewed by Ryosuke Niwa.
1256 * WebCoreSupport/WebGeolocationClient.cpp:
1257 (WebGeolocationClient::lastPosition):
1258 * WebCoreSupport/WebGeolocationClient.h:
1259 * WebGeolocationPosition.cpp:
1260 (WebGeolocationPosition::initWithTimestamp):
1262 * WebGeolocationPosition.h:
1263 (WebGeolocationPosition::impl const):
1265 2017-10-05 Chris Dumez <cdumez@apple.com>
1267 Drop unused parameters for CookiesStrategy::cookiesEnabled()
1268 https://bugs.webkit.org/show_bug.cgi?id=177957
1270 Reviewed by Alex Christensen.
1272 * WebCoreSupport/WebPlatformStrategies.cpp:
1273 (WebPlatformStrategies::cookiesEnabled):
1274 * WebCoreSupport/WebPlatformStrategies.h:
1276 2017-10-03 Basuke Suzuki <Basuke.Suzuki@sony.com>
1278 [Curl] Reimplement CurlDownload with CurlRequest
1279 https://bugs.webkit.org/show_bug.cgi?id=177779
1281 Reviewed by Alex Christensen.
1284 * WebDownloadCurl.cpp:
1285 (WebDownload::init):
1286 (WebDownload::didReceiveResponse):
1288 2017-09-29 Chris Dumez <cdumez@apple.com>
1290 Split some logic out of VisitedLinkStore and make it reusable
1291 https://bugs.webkit.org/show_bug.cgi?id=177575
1293 Reviewed by Alex Christensen.
1295 * WebCoreSupport/WebVisitedLinkStore.cpp:
1296 (WebVisitedLinkStore::addVisitedLink):
1297 (WebVisitedLinkStore::isLinkVisited):
1298 (WebVisitedLinkStore::addVisitedLinkHash):
1299 * WebCoreSupport/WebVisitedLinkStore.h:
1301 2017-09-25 Alex Christensen <achristensen@webkit.org>
1303 Make PolicyAction an encodable enum class
1304 https://bugs.webkit.org/show_bug.cgi?id=177480
1306 Reviewed by Antti Koivisto.
1308 * WebCoreSupport/WebFrameLoaderClient.cpp:
1309 (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1310 (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1311 (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1312 * WebFramePolicyListener.cpp:
1313 (WebFramePolicyListener::use):
1314 (WebFramePolicyListener::download):
1315 (WebFramePolicyListener::ignore):
1316 (WebFramePolicyListener::continueSubmit):
1318 2017-09-07 Per Arne Vollan <pvollan@apple.com>
1320 [Win] fast/canvas/2d.getPath.modification.html is failing.
1321 https://bugs.webkit.org/show_bug.cgi?id=176534
1323 Reviewed by Alex Christensen.
1325 We need to enable Inspector additions at runtime in order to expose the getPath function.
1327 * Interfaces/IWebPreferencesPrivate.idl:
1328 * WebPreferenceKeysPrivate.h:
1329 * WebPreferences.cpp:
1330 (WebPreferences::initializeDefaultSettings):
1331 (WebPreferences::setDataTransferItemsEnabled):
1332 (WebPreferences::inspectorAdditionsEnabled):
1333 (WebPreferences::setInspectorAdditionsEnabled):
1336 (WebView::notifyPreferencesChanged):
1338 2017-09-07 Alex Christensen <achristensen@webkit.org>
1340 Modernize Geolocation code
1341 https://bugs.webkit.org/show_bug.cgi?id=176496
1343 Reviewed by Andy Estes.
1345 * WebCoreSupport/WebGeolocationClient.cpp:
1346 (WebGeolocationClient::requestPermission):
1347 * WebCoreSupport/WebGeolocationClient.h:
1348 (WebGeolocationClient::setEnableHighAccuracy): Deleted.
1349 (WebGeolocationClient::cancelPermissionRequest): Deleted.
1350 * WebGeolocationPolicyListener.h:
1352 (WebView::initWithFrame):
1353 (WebView::geolocationDidFailWithError):
1355 2017-09-07 Per Arne Vollan <pvollan@apple.com>
1357 [Win] Enable DatatransferItems in DRT.
1358 https://bugs.webkit.org/show_bug.cgi?id=176424
1360 Reviewed by Brent Fulgham.
1362 * Interfaces/IWebPreferencesPrivate.idl:
1363 * WebPreferenceKeysPrivate.h:
1364 * WebPreferences.cpp:
1365 (WebPreferences::initializeDefaultSettings):
1366 (WebPreferences::QueryInterface):
1367 (WebPreferences::isSecureContextAttributeEnabled):
1368 (WebPreferences::dataTransferItemsEnabled):
1369 (WebPreferences::setDataTransferItemsEnabled):
1372 (WebView::notifyPreferencesChanged):
1374 2017-08-28 Brent Fulgham <bfulgham@apple.com>
1376 Unreviewed build fix #2 after r221275.
1378 * WebCoreSupport/WebPlatformStrategies.cpp:
1379 (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
1381 * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
1383 2017-08-28 Brent Fulgham <bfulgham@apple.com>
1385 Unreviewed build fix after r221275.
1387 * WebCoreSupport/WebPlatformStrategies.cpp:
1388 (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
1391 2017-08-28 Per Arne Vollan <pvollan@apple.com>
1393 [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
1394 https://bugs.webkit.org/show_bug.cgi?id=176031
1396 Reviewed by Brent Fulgham.
1398 When the function in the FramePolicyFunction parameter is called, it has already been moved
1399 to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
1400 function by using the stored member instead.
1402 * WebCoreSupport/WebFrameLoaderClient.cpp:
1403 (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1404 (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1405 (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1407 2017-08-22 Wenson Hsieh <wenson_hsieh@apple.com>
1409 Unreviewed, try to fix the Windows build after r221064
1411 didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
1413 * WebCoreSupport/WebEditorClient.h:
1415 2017-08-22 Wenson Hsieh <wenson_hsieh@apple.com>
1417 [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
1418 https://bugs.webkit.org/show_bug.cgi?id=175370
1419 <rdar://problem/33799806>
1421 Reviewed by Ryosuke Niwa.
1423 Adjust WebEditorClient for interface changes.
1425 * WebCoreSupport/WebEditorClient.h:
1427 2017-08-22 Brent Fulgham <bfulgham@apple.com>
1429 Unreviewed build fix after r221017.
1431 Correct copy/paste error.
1433 * WebCoreSupport/WebPlatformStrategies.cpp:
1434 (WebPlatformStrategies::cookiesForDOM):
1436 2017-08-22 Brent Fulgham <bfulgham@apple.com>
1438 Unreviewed build fix after r221017.
1440 * WebCoreSupport/WebPlatformStrategies.cpp:
1441 (WebPlatformStrategies::cookiesForDOM): Update for new signature.
1442 * WebCoreSupport/WebPlatformStrategies.h:
1444 2017-08-22 Alex Christensen <achristensen@webkit.org>
1446 Remove ChromeClient::scrollbarsModeDidChange
1447 https://bugs.webkit.org/show_bug.cgi?id=175805
1449 Reviewed by Daniel Bates.
1451 * WebCoreSupport/WebChromeClient.h:
1453 2017-08-22 Alex Christensen <achristensen@webkit.org>
1455 Remove ChromeClient::hasOpenedPopup
1456 https://bugs.webkit.org/show_bug.cgi?id=175804
1458 Reviewed by Sam Weinig.
1460 * WebCoreSupport/WebChromeClient.cpp:
1461 (WebChromeClient::hasOpenedPopup const): Deleted.
1462 * WebCoreSupport/WebChromeClient.h:
1464 2017-08-18 Per Arne Vollan <pvollan@apple.com>
1466 [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
1467 https://bugs.webkit.org/show_bug.cgi?id=173536
1469 Reviewed by Brent Fulgham.
1471 If the tree state is dirty, accessible objects are deleted while iterating over children
1472 under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
1473 style is updated before this method is called.
1475 * AccessibleBase.cpp:
1476 (AccessibleBase::getAccessibilityObjectForChild):
1478 2017-08-17 Don Olmstead <don.olmstead@sony.com>
1480 [PAL] Move SessionID into PAL
1481 https://bugs.webkit.org/show_bug.cgi?id=174192
1483 Reviewed by Antti Koivisto.
1485 * WebCoreSupport/WebFrameLoaderClient.cpp:
1486 (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1487 * WebCoreSupport/WebFrameLoaderClient.h:
1488 * WebCoreSupport/WebFrameNetworkingContext.cpp:
1489 (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
1490 (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1491 (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
1492 (WebFrameNetworkingContext::storageSession const):
1493 * WebCoreSupport/WebPlatformStrategies.cpp:
1494 (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1495 * WebCoreSupport/WebPlatformStrategies.h:
1497 2017-08-15 Youenn Fablet <youenn@apple.com>
1499 [Cache API] Adding generic support for CacheStorage and Cache methods
1500 https://bugs.webkit.org/show_bug.cgi?id=175455
1502 Reviewed by Chris Dumez.
1505 (WebView::initWithFrame):
1507 2017-08-13 Manuel Rego Casasnovas <rego@igalia.com>
1509 Composition underline color is always black
1510 https://bugs.webkit.org/show_bug.cgi?id=174675
1512 Reviewed by Ryosuke Niwa.
1515 (WebView::setCompositionForTesting): Use text color for
1516 composition underline.
1518 2017-08-09 Daniel Bates <dabates@apple.com>
1520 REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
1521 https://bugs.webkit.org/show_bug.cgi?id=175247
1522 <rdar://problem/33679804>
1524 Reviewed by Brady Eidson.
1526 Plumb knowledge of whether a navigation was in response to receiving a redirect response.
1527 We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
1528 clients that need to make use of this information at this time. If such a needs comes up
1529 then we can expose API/SPI similar to what we do for WebKit.
1531 * WebCoreSupport/WebFrameLoaderClient.cpp:
1532 (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1533 * WebCoreSupport/WebFrameLoaderClient.h:
1535 2017-07-25 Said Abou-Hallawa <sabouhallawa@apple.com>
1537 Async image decoding for large images should be disabled after the first time a tile is painted
1538 https://bugs.webkit.org/show_bug.cgi?id=174451
1539 <rdar://problem/31246421>
1541 Reviewed by Simon Fraser.
1543 * FullscreenVideoController.cpp:
1544 (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
1545 * WebCoreSupport/AcceleratedCompositingContext.cpp:
1546 (AcceleratedCompositingContext::paintContents):
1547 * WebCoreSupport/AcceleratedCompositingContext.h:
1549 2017-07-23 Darin Adler <darin@apple.com>
1551 More NeverDestroyed and related cleanup
1552 https://bugs.webkit.org/show_bug.cgi?id=174745
1554 Reviewed by Alex Christensen.
1556 * Plugins/PluginDatabase.cpp:
1557 (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
1558 instead of DEPRECATED_DEFINE_STATIC_LOCAL.
1559 * Plugins/PluginMainThreadScheduler.cpp:
1560 (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
1561 * Plugins/PluginMainThreadScheduler.h: Ditto.
1562 * WebCoreSupport/WebPlatformStrategies.cpp:
1563 (WebPlatformStrategies::initialize): Ditto.
1564 * WebCoreSupport/WebPlatformStrategies.h: Ditto.
1566 (sharedHistoryStorage): Ditto.
1567 * WebLocalizableStrings.cpp:
1568 (mainBundleLocStrings): Ditto.
1569 (frameworkLocStringsMutex): Ditto.
1570 (frameworkLocStrings): Ditto.
1572 (WebView::standardUserAgentWithApplicationName): Ditto.
1573 Also changed to keep one global string with the prefix of the user agent string
1574 instead of keeping two globals with pieces of that prefix.
1576 2017-07-24 Chris Dumez <cdumez@apple.com>
1578 Make ExceptionCode a proper enumeration
1579 https://bugs.webkit.org/show_bug.cgi?id=174771
1581 Reviewed by Sam Weinig.
1583 Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
1585 * DOMCoreClasses.cpp:
1586 (DOMDocument::createEvent):
1588 (WebView::prepareCandidateWindow):
1590 2017-07-21 Andreas Kling <akling@apple.com>
1592 Use more references in event dispatch code
1593 https://bugs.webkit.org/show_bug.cgi?id=174681
1595 Reviewed by Geoffrey Garen.
1597 * DOMEventsClasses.cpp:
1598 (WebEventListener::handleEvent):
1599 * DOMEventsClasses.h:
1600 * Plugins/PluginView.cpp:
1601 (WebCore::PluginView::handleEvent):
1602 * Plugins/PluginView.h:
1604 2017-07-20 Brady Eidson <beidson@apple.com>
1606 Remove WebIconDatabase from WebKitLegacy/win.
1607 https://bugs.webkit.org/show_bug.cgi?id=174608
1609 Reviewed by Alex Christensen.
1615 * Interfaces/IWebIconDatabase.idl: Removed.
1617 * Interfaces/WebKit.idl:
1619 * WebCoreStatistics.cpp:
1620 (WebCoreStatistics::iconPageURLMappingCount):
1621 (WebCoreStatistics::iconRetainedPageURLCount):
1622 (WebCoreStatistics::iconRecordCount):
1623 (WebCoreStatistics::iconsWithDataCount):
1625 * WebIconDatabase.cpp: Removed.
1626 * WebIconDatabase.h: Removed.
1627 * WebKitClassFactory.cpp:
1636 (WebView::notifyDidAddIcon):
1637 (WebView::registerForIconNotification):
1638 (WebView::dispatchDidReceiveIconFromWebFrame):
1639 (WebView::onNotify):
1641 2017-07-18 Matt Lewis <jlewis3@apple.com>
1643 Unreviewed, rolling out r219610.
1645 This caused an api failure on all platforms for the test
1646 SnapshotImageLargeAsyncDecoding
1650 "Async image decoding for large images should be disabled
1651 after the first time a tile is painted"
1652 https://bugs.webkit.org/show_bug.cgi?id=174451
1653 http://trac.webkit.org/changeset/219610
1655 2017-07-18 Said Abou-Hallawa <sabouhallawa@apple.com>
1657 Async image decoding for large images should be disabled after the first time a tile is painted
1658 https://bugs.webkit.org/show_bug.cgi?id=174451
1660 Reviewed by Simon Fraser.
1662 * FullscreenVideoController.cpp:
1663 (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
1664 * WebCoreSupport/AcceleratedCompositingContext.cpp:
1665 (AcceleratedCompositingContext::paintContents):
1666 * WebCoreSupport/AcceleratedCompositingContext.h:
1668 2017-07-14 Basuke Suzuki <Basuke.Suzuki@sony.com>
1670 [Curl] Don't start downloading more than once for same request
1671 https://bugs.webkit.org/show_bug.cgi?id=174172
1673 Reviewed by Alex Christensen.
1675 * WebDownloadCurl.cpp:
1676 (WebDownload::init):
1678 2017-07-12 Daniel Bates <dabates@apple.com>
1680 Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
1681 https://bugs.webkit.org/show_bug.cgi?id=174427
1683 Rubber-stamped by Brady Eidson.
1685 * Plugins/PluginView.cpp:
1686 (WebCore::PluginView::start):
1687 (WebCore::PluginView::getURLNotify):
1688 (WebCore::PluginView::getURL):
1689 (WebCore::PluginView::handlePost):
1691 2017-07-05 Don Olmstead <don.olmstead@sony.com>
1693 [WTF] Move SoftLinking.h into WTF
1694 https://bugs.webkit.org/show_bug.cgi?id=174000
1696 Reviewed by Alex Christensen.
1698 * WebKitClassFactory.cpp:
1701 2017-07-05 Brady Eidson <beidson@apple.com>
1703 Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
1704 <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
1706 Reviewed by Alex Christensen.
1708 Adopt to the new constructor for FrameLoadRequest.
1710 * Plugins/PluginView.cpp:
1711 (WebCore::PluginView::start):
1712 (WebCore::PluginView::getURLNotify):
1713 (WebCore::PluginView::getURL):
1714 (WebCore::PluginView::handlePost):
1716 2017-07-03 Brady Eidson <beidson@apple.com>
1718 Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
1719 https://bugs.webkit.org/show_bug.cgi?id=174073
1721 Reviewed by Andy Estes.
1723 * WebCoreSupport/WebFrameLoaderClient.cpp:
1724 (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
1725 (WebFrameLoaderClient::registerForIconNotification): Deleted.
1726 * WebCoreSupport/WebFrameLoaderClient.h:
1728 2017-07-01 Ryosuke Niwa <rniwa@webkit.org>
1730 Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
1731 https://bugs.webkit.org/show_bug.cgi?id=174004
1733 Reviewed by Simon Fraser.
1735 * WebCoreSupport/WebFrameLoaderClient.cpp:
1736 (WebFrameLoaderClient::transitionToCommittedForNewPage):
1738 2017-06-30 Daniel Bates <dabates@apple.com>
1740 API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
1741 https://bugs.webkit.org/show_bug.cgi?id=165160
1742 <rdar://problem/29451999>
1744 Reviewed by Brady Eidson.
1746 Pass the document that is requesting the load to the loader.
1748 * Plugins/PluginView.cpp:
1749 (WebCore::PluginView::start):
1750 (WebCore::PluginView::getURLNotify):
1751 (WebCore::PluginView::getURL):
1752 (WebCore::PluginView::handlePost):
1754 2017-06-27 Wenson Hsieh <wenson_hsieh@apple.com>
1756 Refactor drag start codepaths to plumb a DragItem to client layers
1757 https://bugs.webkit.org/show_bug.cgi?id=173832
1758 Work towards <rdar://problem/32236827>
1760 Reviewed by Ryosuke Niwa and Tim Horton.
1762 Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
1764 * WebCoreSupport/WebDragClient.cpp:
1765 (WebDragClient::startDrag):
1766 * WebCoreSupport/WebDragClient.h:
1768 2017-06-25 Konstantin Tokarev <annulen@yandex.ru>
1770 Remove excessive headers from JavaScriptCore
1771 https://bugs.webkit.org/show_bug.cgi?id=173812
1773 Reviewed by Darin Adler.
1775 * Plugins/PluginPackage.cpp:
1777 2017-06-22 Daniel Bates <dabates@apple.com>
1779 Make FrameLoadRequest a move-only type
1780 https://bugs.webkit.org/show_bug.cgi?id=173682
1782 Reviewed by Alex Christensen and Darin Adler.
1784 A FrameLoadRequest groups together the information to perform a load into a single object
1785 that is more manageable to pass around than its constituent parts. Code that receives a
1786 FrameLoadRequest is expected to extract out the information it needs to complete its task.
1787 And it does not make sense to re-use the same FrameLoadRequest object for more than one
1788 load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
1790 * Plugins/PluginView.cpp:
1791 (WebCore::PluginView::start):
1792 (WebCore::PluginView::performRequest):
1793 (WebCore::PluginView::load):
1794 (WebCore::PluginView::getURLNotify):
1795 (WebCore::PluginView::getURL):
1796 (WebCore::PluginView::handlePost):
1797 * Plugins/PluginView.h:
1798 (WebCore::PluginRequest::PluginRequest):
1800 2017-06-22 Daniel Bates <dabates@apple.com>
1802 [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
1803 https://bugs.webkit.org/show_bug.cgi?id=173683
1805 Reviewed by Alex Christensen.
1807 Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
1808 header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
1809 by including PluginView.h. The latter does not make use of the functionality
1810 provided by FrameLoadRequest.h.
1812 * Plugins/PluginViewWin.cpp:
1813 * WebCoreSupport/WebContextMenuClient.cpp:
1815 2017-06-21 Daniel Bates <dabates@apple.com>
1817 Cleanup FrameLoadRequest
1818 https://bugs.webkit.org/show_bug.cgi?id=173564
1819 <rdar://problem/32903570>
1821 Reviewed by Brent Fulgham.
1823 * Plugins/PluginView.cpp:
1824 (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
1825 we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
1826 we do not have one. Use C++11 brace initialization syntax.
1827 (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
1828 name as we do not have one. Use C++11 brace initialization syntax.
1829 (WebCore::PluginView::getURL): Ditto.
1830 (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
1831 function to closer to where it is actually used. Explicitly pass the null-string for the target
1832 frame name as we do not have one. Use C++11 brace initialization syntax.
1834 2017-06-20 Daniel Bates <dabates@apple.com>
1836 Have FrameLoadRequest takes a Frame& instead of a Frame*
1837 https://bugs.webkit.org/show_bug.cgi?id=173614
1838 <rdar://problem/32884890>
1840 Reviewed by Brent Fulgham.
1842 * Plugins/PluginView.cpp:
1843 (WebCore::PluginView::performRequest):
1845 (WebFrame::loadRequest):
1847 2017-06-19 Chris Dumez <cdumez@apple.com>
1849 Use WTF::Function instead of std::function in more places in WebCore/
1850 https://bugs.webkit.org/show_bug.cgi?id=173535
1852 Reviewed by Antti Koivisto.
1854 Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
1856 * WebCoreSupport/WebFrameLoaderClient.cpp:
1857 (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1858 (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1859 (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1860 (WebFrameLoaderClient::dispatchWillSubmitForm):
1861 (WebFrameLoaderClient::setUpPolicyListener):
1862 (WebFrameLoaderClient::receivedPolicyDecision):
1863 * WebCoreSupport/WebFrameLoaderClient.h:
1865 2017-05-14 Frederic Wang <fwang@igalia.com>
1867 Add heuristic to avoid flattening "fullscreen" iframes
1868 https://bugs.webkit.org/show_bug.cgi?id=171914
1870 Reviewed by Simon Fraser.
1872 This commit ajusts the window port to internally use the new preference type for frame flattening.
1873 However, the "partial frame flattening" value is not exposed yet.
1876 (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
1878 2017-06-17 Chris Dumez <cdumez@apple.com>
1880 Use WTF::Function instead of std::function in WebKit2/
1881 https://bugs.webkit.org/show_bug.cgi?id=173504
1883 Reviewed by Darin Adler.
1885 Use WTF::Function instead of std::function in WebKit2/ to avoid
1886 unnecessary copying.
1888 * Plugins/PluginStream.cpp:
1889 (WebCore::PluginStream::willSendRequest):
1890 * Plugins/PluginStream.h:
1892 2017-06-16 Sam Weinig <sam@webkit.org>
1894 [WebIDL] Remove custom bindings for HTMLDocument
1895 https://bugs.webkit.org/show_bug.cgi?id=173444
1897 Reviewed by Darin Adler.
1899 * DOMHTMLClasses.cpp:
1900 (DOMHTMLDocument::write):
1901 (DOMHTMLDocument::writeln):
1902 Update for new signature of write/writeln.
1904 2017-06-16 Daniel Bates <dabates@apple.com>
1906 Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
1907 instead of URL { ParsedURLString, ... }
1908 https://bugs.webkit.org/show_bug.cgi?id=173495
1909 <rdar://problem/32827445>
1911 Reviewed by Alex Christensen.
1913 URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
1914 Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
1915 Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
1916 would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
1917 parse an arbitrary string that looks like a URL.
1919 Also modernize the code using C++14 idioms.
1921 * WebCoreSupport/WebContextMenuClient.cpp:
1922 (WebContextMenuClient::searchWithGoogle):
1924 2017-06-15 Fujii Hironori <Hironori.Fujii@sony.com>
1926 [Win] WebKit shouldn't include the forwarding header of WebKit itself
1927 https://bugs.webkit.org/show_bug.cgi?id=173352
1929 Reviewed by Alex Christensen.
1931 * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
1933 2017-06-14 Per Arne Vollan <pvollan@apple.com>
1935 [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
1936 https://bugs.webkit.org/show_bug.cgi?id=173318
1938 Reviewed by Darin Adler.
1940 The logical frame size is currently calculated by scaling the frame size in pixels,
1941 and rounding the coordinates to the nearest integers. The computed logical frame
1942 size will in some cases be smaller than the scaled frame size in pixels, since it is
1943 represented as an IntSize. In these cases, the bottom line will not be painted.
1944 Instead of calculating the logical frame size by rounding the scaled frame in
1945 pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
1947 * WebCoreSupport/WebFrameLoaderClient.cpp:
1948 (WebFrameLoaderClient::transitionToCommittedForNewPage):
1950 2017-06-13 Daniel Bates <dabates@apple.com>
1952 Implement W3C Secure Contexts Draft Specification
1953 https://bugs.webkit.org/show_bug.cgi?id=158121
1954 <rdar://problem/26012994>
1956 Reviewed by Brent Fulgham.
1960 Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
1962 * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
1963 * WebPreferenceKeysPrivate.h:
1964 * WebPreferences.cpp:
1965 (WebPreferences::initializeDefaultSettings):
1966 (WebPreferences::QueryInterface):
1967 (WebPreferences::setIsSecureContextAttributeEnabled):
1968 (WebPreferences::isSecureContextAttributeEnabled):
1971 (WebView::notifyPreferencesChanged):
1973 2017-06-13 Per Arne Vollan <pvollan@apple.com>
1975 [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
1976 https://bugs.webkit.org/show_bug.cgi?id=173318
1978 Reviewed by Alex Christensen.
1980 The logical frame size is currently calculated by scaling the frame size in pixels,
1981 and rounding the coordinates to the nearest integers. The computed logical frame
1982 size will in some cases be smaller than the scaled frame size in pixels, since it is
1983 represented as an IntSize. In these cases, the bottom line will not be painted.
1984 Instead of calculating the logical frame size by rounding the scaled frame in
1985 pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
1988 (WebView::sizeChanged):
1990 2017-06-13 Sam Weinig <sam@webkit.org>
1992 Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
1993 https://bugs.webkit.org/show_bug.cgi?id=80733
1995 Reviewed by Chris Dumez.
1998 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2000 2017-06-12 Daewoong Jang <daewoong.jang@navercorp.com>
2002 Remove WebCore::unloadModule and related data types
2003 https://bugs.webkit.org/show_bug.cgi?id=173231
2005 Reviewed by Darin Adler.
2007 * Plugins/PlatformModule.h: Added.
2008 (WebCore::PlatformModuleVersion::PlatformModuleVersion):
2009 * Plugins/PluginPackage.cpp:
2010 (WebCore::PluginPackage::freeLibraryTimerFired):
2011 * Plugins/PluginPackage.h:
2013 2017-06-09 Wenson Hsieh <wenson_hsieh@apple.com>
2015 [iOS DnD] Add a hook to perform two-step drops in editable content
2016 https://bugs.webkit.org/show_bug.cgi?id=172992
2017 <rdar://problem/32590174>
2019 Reviewed by Tim Horton.
2021 Add a stub implementation for performTwoStepDrop on Windows.
2023 * WebCoreSupport/WebEditorClient.h:
2025 2017-06-04 Konstantin Tokarev <annulen@yandex.ru>
2027 Fix build of Windows-specific code with ICU 59.1
2028 https://bugs.webkit.org/show_bug.cgi?id=172729
2030 Reviewed by Darin Adler.
2032 Fix conversions from WTF::String to wchar_t* and vice versa.
2034 * Plugins/PluginDatabaseWin.cpp:
2035 (WebCore::addPluginPathsFromRegistry):
2036 (WebCore::PluginDatabase::getPluginPathsInDirectories):
2037 (WebCore::addMozillaPluginDirectories):
2038 (WebCore::addWindowsMediaPlayerPluginDirectory):
2039 (WebCore::addAdobeAcrobatPluginDirectory):
2040 (WebCore::addJavaPluginDirectory):
2041 (WebCore::safariPluginsDirectory):
2042 (WebCore::addMacromediaPluginDirectories):
2043 * Plugins/PluginPackageWin.cpp:
2044 (WebCore::getVersionInfo):
2045 (WebCore::PluginPackage::fetchInfo):
2046 (WebCore::PluginPackage::load):
2047 * Plugins/PluginViewWin.cpp:
2048 (WebCore::PluginView::handlePostReadFile):
2050 2017-05-30 Per Arne Vollan <pvollan@apple.com>
2052 [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
2053 https://bugs.webkit.org/show_bug.cgi?id=172709
2055 Reviewed by Brent Fulgham.
2057 Add method to exit fullscreen mode.
2059 * Interfaces/IWebViewPrivate.idl:
2061 (WebView::exitFullscreenIfNeeded):
2064 2017-05-24 Per Arne Vollan <pvollan@apple.com>
2066 [Win] Create unique network storage session for each DRT.
2067 https://bugs.webkit.org/show_bug.cgi?id=172540
2069 Reviewed by Brent Fulgham.
2071 During layout testing, each DRT instance should have its own network storage session.
2073 * Interfaces/IWebPreferencesPrivate.idl:
2074 * WebPreferences.cpp:
2075 (WebPreferences::switchNetworkLoaderToNewTestingSession):
2078 2017-05-24 Fujii Hironori <Hironori.Fujii@sony.com>
2080 [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
2081 https://bugs.webkit.org/show_bug.cgi?id=172535
2083 Reviewed by Konstantin Tokarev.
2085 * WebCoreSupport/AcceleratedCompositingContext.cpp:
2086 (AcceleratedCompositingContext::paintContents): Append the fifth argument.
2087 * WebCoreSupport/AcceleratedCompositingContext.h: Ditto.
2089 2017-05-14 Per Arne Vollan <pvollan@apple.com>
2091 [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
2092 https://bugs.webkit.org/show_bug.cgi?id=172071
2094 Reviewed by Alexey Proskuryakov.
2096 We need to delete all cookies after each test.
2098 * Interfaces/IWebPreferencesPrivate.idl:
2099 * WebPreferences.cpp:
2100 (WebPreferences::linkPreloadEnabled):
2101 (WebPreferences::clearNetworkLoaderSession):
2104 2017-05-13 Chris Dumez <cdumez@apple.com>
2106 Stop using RefPtr::release()
2107 https://bugs.webkit.org/show_bug.cgi?id=172074
2109 Reviewed by Geoffrey Garen.
2112 (WebFrame::loadPlainTextString):
2113 (WebFrame::loadHTMLString):
2114 * WebFramePolicyListener.cpp:
2115 (WebFramePolicyListener::receivedPolicyDecision):
2117 2017-05-13 Chris Dumez <cdumez@apple.com>
2119 Drop uses of PassRefPtr in WebKit/win
2120 https://bugs.webkit.org/show_bug.cgi?id=172067
2122 Reviewed by Yusuke Suzuki.
2124 * DOMEventsClasses.cpp:
2125 (DOMEvent::DOMEvent):
2126 (DOMEvent::createInstance):
2127 * DOMEventsClasses.h:
2128 (DOMUIEvent::DOMUIEvent):
2129 (DOMKeyboardEvent::DOMKeyboardEvent):
2130 (DOMMouseEvent::DOMMouseEvent):
2131 (DOMMutationEvent::DOMMutationEvent):
2132 (DOMOverflowEvent::DOMOverflowEvent):
2133 (DOMWheelEvent::DOMWheelEvent):
2135 (MemoryStream::MemoryStream):
2136 (MemoryStream::createInstance):
2138 * Plugins/PluginDatabase.cpp:
2139 (WebCore::PluginDatabase::refresh):
2140 (WebCore::PluginDatabase::add):
2141 (WebCore::PluginDatabase::loadPersistentMetadataCache):
2142 * Plugins/PluginDatabase.h:
2143 * Plugins/PluginPackage.cpp:
2144 (WebCore::PluginPackage::createPackage):
2145 (WebCore::PluginPackage::createPackageFromCache):
2146 * Plugins/PluginPackage.h:
2147 * Plugins/PluginStream.h:
2148 (WebCore::PluginStream::create):
2149 * WebActionPropertyBag.cpp:
2150 (WebActionPropertyBag::WebActionPropertyBag):
2151 (WebActionPropertyBag::createInstance):
2152 * WebActionPropertyBag.h:
2154 (WebArchive::createInstance):
2155 (WebArchive::WebArchive):
2157 * WebBackForwardList.cpp:
2158 (WebBackForwardList::WebBackForwardList):
2159 (WebBackForwardList::createInstance):
2160 * WebBackForwardList.h:
2161 * WebCoreSupport/EmbeddedWidget.cpp:
2162 (EmbeddedWidget::create):
2163 * WebCoreSupport/EmbeddedWidget.h:
2164 * WebCoreSupport/WebChromeClient.h:
2166 (WebFrame::loadData):
2167 (WebFrame::createSubframeWithOwnerElement):
2169 * WebFramePolicyListener.cpp:
2170 (WebFramePolicyListener::WebFramePolicyListener):
2171 (WebFramePolicyListener::createInstance):
2172 * WebFramePolicyListener.h:
2173 * WebGeolocationPolicyListener.cpp:
2174 (WebGeolocationPolicyListener::createInstance):
2175 (WebGeolocationPolicyListener::WebGeolocationPolicyListener):
2176 * WebGeolocationPolicyListener.h:
2177 * WebHistoryItem.cpp:
2178 (WebHistoryItem::WebHistoryItem):
2179 (WebHistoryItem::createInstance):
2181 * WebMutableURLRequest.cpp:
2182 (WebMutableURLRequest::setFormData):
2183 (WebMutableURLRequest::formData):
2184 * WebMutableURLRequest.h:
2186 (WebResource::createInstance):
2188 * WebScriptWorld.cpp:
2189 (WebScriptWorld::WebScriptWorld):
2190 (WebScriptWorld::createInstance):
2192 * WebURLAuthenticationChallengeSender.cpp:
2193 (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
2194 (WebURLAuthenticationChallengeSender::createInstance):
2195 * WebURLAuthenticationChallengeSender.h:
2197 (WebView::setFullScreenElement):
2200 2017-05-11 Chris Dumez <cdumez@apple.com>
2202 Drop remaining uses of PassRefPtr in WebCore
2203 https://bugs.webkit.org/show_bug.cgi?id=172013
2205 Reviewed by Yusuke Suzuki.
2207 * Plugins/PluginView.cpp:
2208 (WebCore::PluginView::bindingInstance):
2210 2017-05-11 Chris Dumez <cdumez@apple.com>
2212 Stop using PassRefPtr in platform/graphics
2213 https://bugs.webkit.org/show_bug.cgi?id=171977
2215 Reviewed by Alex Christensen.
2219 * FullscreenVideoController.cpp:
2220 (FullscreenVideoController::enterFullscreen):
2222 (loadResourceIntoBuffer):
2224 2017-05-09 Sam Weinig <sam@webkit.org>
2226 Remove support for legacy Notifications
2227 https://bugs.webkit.org/show_bug.cgi?id=171487
2229 Reviewed by Jon Lee.
2231 * WebCoreSupport/WebChromeClient.cpp:
2232 (WebChromeClient::WebChromeClient):
2233 * WebCoreSupport/WebChromeClient.h:
2234 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
2235 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
2236 Remove legacy notification specific code.
2238 2017-05-09 Dean Jackson <dino@apple.com>
2242 * Plugins/PluginView.h:
2243 * Plugins/PluginViewWin.cpp:
2244 (WebCore::PluginView::paint):
2246 2017-05-06 Alexey Proskuryakov <ap@apple.com>
2248 REGRESSION (r216294): The new test fails on WebKit1
2249 https://bugs.webkit.org/show_bug.cgi?id=171780
2251 Rolling back https://trac.webkit.org/r216294, https://trac.webkit.org/r216296,
2252 https://trac.webkit.org/216299, https://trac.webkit.org/216330
2254 * Plugins/PluginView.h:
2255 * Plugins/PluginViewWin.cpp:
2256 (WebCore::PluginView::paint):
2258 2017-05-06 Simon Fraser <simon.fraser@apple.com>
2260 Fix Windows build after r216294.
2262 * Plugins/PluginView.h:
2263 * Plugins/PluginViewWin.cpp:
2264 (WebCore::PluginView::paint):
2266 2017-05-04 Commit Queue <commit-queue@webkit.org>
2268 Unreviewed, rolling out r216206.
2269 https://bugs.webkit.org/show_bug.cgi?id=171714
2271 Multiple LayoutTests crashing in Document::page() (Requested
2276 "Remove support for legacy Notifications"
2277 https://bugs.webkit.org/show_bug.cgi?id=171487
2278 http://trac.webkit.org/changeset/216206
2280 2017-05-04 Don Olmstead <don.olmstead@am.sony.com>
2282 [Win] Remove redundant macros that are set in the CMake config
2283 https://bugs.webkit.org/show_bug.cgi?id=171571
2285 Reviewed by Brent Fulgham.
2291 2017-05-04 Sam Weinig <sam@webkit.org>
2293 Remove support for legacy Notifications
2294 https://bugs.webkit.org/show_bug.cgi?id=171487
2296 Reviewed by Jon Lee.
2298 * WebCoreSupport/WebChromeClient.cpp:
2299 (WebChromeClient::WebChromeClient):
2300 * WebCoreSupport/WebChromeClient.h:
2301 * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
2302 * WebCoreSupport/WebDesktopNotificationsDelegate.h:
2303 Remove legacy notification specific code.
2305 2017-04-27 Alex Christensen <achristensen@webkit.org>
2308 https://bugs.webkit.org/show_bug.cgi?id=171357
2310 Reviewed by Andy Estes.
2312 * WebCoreSupport/WebEditorClient.cpp:
2313 (WebEditorClient::isSelectTrailingWhitespaceEnabled):
2314 * WebCoreSupport/WebEditorClient.h:
2316 2017-04-20 Fujii Hironori <Hironori.Fujii@sony.com>
2318 [WinCairo] Fix build break after updating ANGLE
2319 https://bugs.webkit.org/show_bug.cgi?id=170980
2321 Reviewed by Brent Fulgham.
2323 * WebCoreSupport/AcceleratedCompositingContext.cpp: Define GL_GLEXT_PROTOTYPES.
2325 2017-04-19 Brent Fulgham <bfulgham@apple.com>
2327 [Win] REGRESSION(r215486): Windows Release build is broken
2328 https://bugs.webkit.org/show_bug.cgi?id=171024
2329 <rdar://problem/31722618>
2331 Reviewed by Mark Lam.
2333 Windows WebKit refers to a handful of JSC methods that are always
2334 inline. We need to include 'HeapInlines.h' to get the implementation
2337 * Plugins/PluginPackage.cpp:
2341 2017-04-15 Wenson Hsieh <wenson_hsieh@apple.com>
2343 Unreviewed, fix the Windows build after r215385
2345 r215385 introduced a new virtual method on ChromeClient that needs to be implemented in WebChromeClient for
2348 * WebCoreSupport/WebChromeClient.cpp:
2349 (WebChromeClient::createIconForFiles):
2350 * WebCoreSupport/WebChromeClient.h:
2352 2017-04-10 Chris Dumez <cdumez@apple.com>
2354 Drop Timer::startOneShot() overload taking a double
2355 https://bugs.webkit.org/show_bug.cgi?id=170659
2357 Reviewed by Yusuke Suzuki.
2359 Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
2361 * Plugins/PluginMessageThrottlerWin.cpp:
2362 (WebCore::PluginMessageThrottlerWin::appendMessage):
2363 (WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
2364 * Plugins/PluginViewWin.cpp:
2365 (WebCore::PluginView::invalidateRect):
2366 * WebCoreSupport/AcceleratedCompositingContext.cpp:
2367 (AcceleratedCompositingContext::scheduleLayerFlush):
2369 2017-04-09 Chris Dumez <cdumez@apple.com>
2371 Drop Timer::startRepeating() overload taking a double
2372 https://bugs.webkit.org/show_bug.cgi?id=170656
2374 Reviewed by Yusuke Suzuki.
2376 Drop Timer::startRepeating() overload taking a double as people should use Seconds type now.
2378 * FullscreenVideoController.cpp:
2380 2017-04-09 Chris Dumez <cdumez@apple.com>
2382 Start dropping Timer API dealing with double
2383 https://bugs.webkit.org/show_bug.cgi?id=170649
2385 Reviewed by Yusuke Suzuki.
2387 Start dropping Timer API dealing with double as people should use Seconds now.
2389 * Plugins/PluginPackage.cpp:
2390 (WebCore::PluginPackage::freeLibrarySoon):
2391 * Plugins/PluginStream.cpp:
2392 (WebCore::PluginStream::deliverData):
2393 * Plugins/PluginView.cpp:
2394 (WebCore::PluginView::requestTimerFired):
2395 (WebCore::PluginView::scheduleRequest):
2396 (WebCore::PluginView::setJavaScriptPaused):
2397 (WebCore::PluginView::keepAlive):
2398 * Plugins/PluginViewWin.cpp:
2399 (WebCore::PluginView::wndProc):
2401 (WebView::closeWindowSoon):
2403 2017-04-08 Chris Dumez <cdumez@apple.com>
2405 Drop std::chrono support from Timer class
2406 https://bugs.webkit.org/show_bug.cgi?id=170645
2408 Reviewed by Sam Weinig.
2410 Drop std::chrono support from Timer class now that we prefer using Seconds type.
2413 (WebView::setCacheModel):
2415 2017-03-31 Fujii Hironori <Hironori.Fujii@sony.com>
2417 [WinCairo] WebCore::PlatformDisplay::terminateEGLDisplay causes a crash in libGLESv2.dll while processing atexit
2418 https://bugs.webkit.org/show_bug.cgi?id=170331
2420 Reviewed by Michael Catanzaro.
2423 (shutDownWebKit): Call PlatformDisplay::shutDownEglDisplays in shutDownWebKit.
2425 2017-03-30 James Craig <jcraig@apple.com>
2427 AX: Expose a new AXSubrole for explicit ARIA "group" role
2428 https://bugs.webkit.org/show_bug.cgi?id=169810
2429 <rdar://problem/31039693>
2431 Reviewed by Chris Fleizach.
2433 Account for Windows platform role mapping.
2435 * AccessibleBase.cpp:
2438 2017-03-24 Wenson Hsieh <wenson_hsieh@apple.com>
2440 [WK2] Add a UI delegate SPI hook to enable or disable navigation on drop
2441 https://bugs.webkit.org/show_bug.cgi?id=169168
2442 <rdar://problem/30688374>
2444 Reviewed by Tim Horton.
2446 Minor tweak to adjust for a changed interface. See WebKit and WebCore ChangeLogs for more information.
2448 * WebCoreSupport/WebDragClient.cpp:
2449 (WebDragClient::actionMaskForDrag):
2450 * WebCoreSupport/WebDragClient.h:
2452 2017-03-13 Per Arne Vollan <pvollan@apple.com>
2455 https://bugs.webkit.org/show_bug.cgi?id=169545
2457 Reviewed by Brent Fulgham.
2459 Fix inconsistent dll linkage warnings.
2464 2017-03-13 Per Arne Vollan <pvollan@apple.com>
2466 Unreviewed Win build fix.
2468 WebCore::CookiesStrategy::addCookie has been removed, we should also remove the override.
2470 * WebCoreSupport/WebPlatformStrategies.cpp:
2471 (WebPlatformStrategies::addCookie): Deleted.
2472 (WebPlatformStrategies::addCookie): Deleted.
2473 * WebCoreSupport/WebPlatformStrategies.h:
2475 2017-03-10 Brent Fulgham <bfulgham@apple.com>
2477 [Win] Re-export a few symbols for backwards compatibility
2478 https://bugs.webkit.org/show_bug.cgi?id=169490
2479 <rdar://problem/30983623>
2481 Reviewed by Dean Jackson.
2483 Re-introduce a workaround that re-exports a few JavaScriptCore functions
2484 that had been erroneously exported by WebKit in older builds. This
2485 is needed so that we do not break certain old software still being used.
2488 (DllMain): Bind functions at startup.
2489 (bindJavaScriptTrampoline): Find JavaScriptCore library functions and
2490 re-export them from WebKit.dll.
2491 * WebKitDLL.h: Only advertise these functions when building WebKt itself.
2493 2017-03-06 Myles C. Maxfield <mmaxfield@apple.com>
2495 Expand font-weight and font-stretch to take any number
2496 https://bugs.webkit.org/show_bug.cgi?id=168889
2498 Reviewed by Simon Fraser.
2500 Migrate off old enum types.
2502 * WebKitGraphics.cpp:
2505 2017-03-02 Sam Weinig <sam@webkit.org>
2507 Rename htmlediting.h/cpp to Editing.h/cpp
2508 https://bugs.webkit.org/show_bug.cgi?id=169103
2510 Reviewed by Alex Christensen.
2512 * AccessibleTextImpl.cpp:
2514 2017-03-01 Alex Christensen <achristensen@webkit.org>
2516 Actually fix Windows build.
2519 (WebFrame::invalidate):
2520 r213266 changed Style::Force to ResolveStyleType::Rebuild, so I did so here.
2522 2017-03-01 Alex Christensen <achristensen@webkit.org>
2524 Fix Windows build after r213266
2525 https://bugs.webkit.org/show_bug.cgi?id=169049
2528 (WebFrame::invalidate):
2530 2017-02-27 Per Arne Vollan <pvollan@apple.com>
2532 [Win] Http preload tests are failing.
2533 https://bugs.webkit.org/show_bug.cgi?id=168910
2535 Reviewed by Alex Christensen.
2537 The feature is not enabled.
2540 (WebView::notifyPreferencesChanged):
2542 2017-02-22 Carlos Garcia Campos <cgarcia@igalia.com>
2544 Better handle Thread and RunLoop initialization
2545 https://bugs.webkit.org/show_bug.cgi?id=167828
2547 Reviewed by Yusuke Suzuki.
2549 Remove unnecessary call to WTF::initializeMainThread().
2554 2017-02-20 Per Arne Vollan <pvollan@apple.com>
2556 [Win] Custom scale factor is not applied in all cases.
2557 https://bugs.webkit.org/show_bug.cgi?id=168117
2559 Reviewed by Brent Fulgham.
2561 We should not call the function deviceScaleFactorForWindow directly, since this
2562 will return the system scale factor, and ignore the custom scale factor.
2565 (WebView::handleContextMenuEvent):
2566 (WebView::handleMouseEvent):
2567 (WebView::setAcceleratedCompositing):
2569 2017-02-16 Daniel Bates <dabates@apple.com>
2571 Remove Chromium-specific code to call FrameLoaderClient::redirectDataToPlugin(nullptr)
2572 https://bugs.webkit.org/show_bug.cgi?id=168417
2573 <rdar://problem/30541748>
2575 Reviewed by Brent Fulgham.
2577 Update override of FrameLoaderClient::redirectDataToPlugin() to take a Widget& instead of a
2578 Widget* as it is always called with a valid Widget.
2580 * WebCoreSupport/WebFrameLoaderClient.cpp:
2581 (WebFrameLoaderClient::redirectDataToPlugin):
2582 * WebCoreSupport/WebFrameLoaderClient.h:
2584 2017-02-15 Anders Carlsson <andersca@apple.com>
2586 Another attempt at fixing the Windows build.
2588 * WebCoreSupport/WebDragClient.cpp:
2589 (WebDragClient::startDrag):
2591 2017-02-15 Anders Carlsson <andersca@apple.com>
2593 Try to fix the Windows build.
2595 * WebCoreSupport/WebDragClient.h:
2597 2017-02-15 Anders Carlsson <andersca@apple.com>
2599 Modernize DragClient::startDrag somewhat
2600 https://bugs.webkit.org/show_bug.cgi?id=168379
2602 Reviewed by Tim Horton.
2604 Update for WebCore changes.
2606 * WebCoreSupport/WebDragClient.cpp:
2607 (WebDragClient::startDrag):
2609 2017-02-10 Daniel Bates <dabates@apple.com>
2611 Attempt to fix the WinCairo 64-Bit Release build following <https://trac.webkit.org/changeset/212173>
2612 (https://bugs.webkit.org/show_bug.cgi?id=166774)
2614 Touch WebKit.idl in the hopes that it will cause CMake to regenerate the COM interface files.
2616 * Interfaces/WebKit.idl:
2618 2017-02-10 Daniel Bates <dabates@apple.com>
2620 Detach frame from document when entering page cache
2621 https://bugs.webkit.org/show_bug.cgi?id=166774
2622 <rdar://problem/29904368>
2624 Reviewed by Chris Dumez.
2626 * Interfaces/IWebPreferencesPrivate.idl:
2627 * WebPreferenceKeysPrivate.h:
2628 * WebPreferences.cpp:
2629 (WebPreferences::initializeDefaultSettings):
2630 (WebPreferences::setAllowsPageCacheWithWindowOpener): Deleted.
2631 (WebPreferences::allowsPageCacheWithWindowOpener): Deleted.
2634 (WebView::notifyPreferencesChanged):
2636 2017-02-10 Joseph Pecoraro <pecoraro@apple.com>
2638 [Resource Timing] Enable Resource Timing by default in Tests
2639 https://bugs.webkit.org/show_bug.cgi?id=168145
2641 Reviewed by Ryosuke Niwa.
2643 * Interfaces/IWebPreferencesPrivate.idl:
2644 * WebPreferenceKeysPrivate.h:
2645 * WebPreferences.cpp:
2646 (WebPreferences::initializeDefaultSettings):
2647 (WebPreferences::setResourceTimingEnabled):
2648 (WebPreferences::resourceTimingEnabled):
2651 (WebView::notifyPreferencesChanged):
2653 2017-02-06 Alex Christensen <achristensen@webkit.org>
2655 More build fixes after r211751
2656 https://bugs.webkit.org/show_bug.cgi?id=166998
2658 * WebDownloadCFNet.cpp:
2659 (WebDownload::didReceiveAuthenticationChallenge):
2661 2017-02-06 Said Abou-Hallawa <sabouhallawa@apple.com>
2663 Rename AnimationController to CSSAnimationController
2664 https://bugs.webkit.org/show_bug.cgi?id=167829
2666 Reviewed by Simon Fraser.
2670 2017-02-02 Wenson Hsieh <wenson_hsieh@apple.com>
2672 Drag images should be anchored to the mouse location
2673 https://bugs.webkit.org/show_bug.cgi?id=167690
2674 <rdar://problem/30295261>
2676 Reviewed by Enrica Casucci.
2678 Adds some plumbing for the anchor point in the WK1 client layer.
2680 * WebCoreSupport/WebDragClient.cpp:
2681 (WebDragClient::startDrag):
2682 * WebCoreSupport/WebDragClient.h:
2684 2017-02-02 Per Arne Vollan <pvollan@apple.com>
2686 [Win][HiDPI] Scale factor is applied twice in accelerated compositing mode.
2687 https://bugs.webkit.org/show_bug.cgi?id=167732
2689 Reviewed by Brent Fulgham.
2691 Backing layer should not be scaled when CACFLayerSetContentsScale is used for scaling.
2694 (WebView::setAcceleratedCompositing):
2696 2017-02-02 Chris Dumez <cdumez@apple.com>
2698 [Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
2699 https://bugs.webkit.org/show_bug.cgi?id=167738
2700 <rdar://problem/30229990>
2702 Reviewed by Andreas Kling.
2704 The BackForwardClient no longer needs to worry about removing HistoryItems
2705 from the PageCache now that WebCore takes care of it.
2707 * BackForwardList.cpp:
2708 (BackForwardList::close):
2710 2017-01-28 Yoav Weiss <yoav@yoav.ws>
2712 Add Link Preload as an off-by-default experimental feature menu item.
2713 https://bugs.webkit.org/show_bug.cgi?id=167201
2715 Reviewed by Ryosuke Niwa.
2717 * WebPreferenceKeysPrivate.h:
2718 * WebPreferences.cpp:
2719 (WebPreferences::initializeDefaultSettings):
2720 (WebPreferences::valueForKey):
2721 (WebPreferences::setLinkPreloadEnabled):
2722 (WebPreferences::linkPreloadEnabled):
2724 * Interfaces/IWebPreferencesPrivate.idl:
2726 2017-01-28 Joseph Pecoraro <pecoraro@apple.com>
2728 Add User Timing Experimental Feature
2729 https://bugs.webkit.org/show_bug.cgi?id=167542
2730 <rdar://problem/22746307>
2732 Reviewed by Ryosuke Niwa.
2734 * Interfaces/IWebPreferencesPrivate.idl:
2735 * WebPreferenceKeysPrivate.h:
2736 * WebPreferences.cpp:
2737 (WebPreferences::initializeDefaultSettings):
2738 (WebPreferences::setUserTimingEnabled):
2739 (WebPreferences::userTimingEnabled):
2742 (WebView::notifyPreferencesChanged):
2743 Add setting for User Timing runtime enabled feature.
2745 2017-01-26 Chris Dumez <cdumez@apple.com>
2747 Crash when navigating back to a page in PacheCache when one of its frames has been removed
2748 https://bugs.webkit.org/show_bug.cgi?id=167421
2749 <rdar://problem/30188490>
2751 Reviewed by Darin Adler.
2753 Add a new setting allowing layout tests to enable PageCache in a window
2754 that has an opener, for convenience.
2756 * WebPreferenceKeysPrivate.h:
2757 * WebPreferences.cpp:
2758 (WebPreferences::initializeDefaultSettings):
2761 2017-01-26 Keith Miller <keith_miller@apple.com>
2763 classInfo should take a VM so it is not materialized from the object on each call
2764 https://bugs.webkit.org/show_bug.cgi?id=167424
2766 Rubber Stamped by Michael Saboff.
2768 Previously, classInfo() would get the VM from the target's
2769 MarkedBlock. Most callers already have a VM on hand, so it is
2770 wasteful to compute the VM from the marked block every time. This
2771 patch refactors some of the most common callers of classInfo(),
2772 jsDynamicCast and inherits to take a VM as well.
2775 (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2777 (WebView::elementFromJS):
2779 2017-01-26 Per Arne Vollan <pvollan@apple.com>
2781 Crash when setting custom scale factor.
2782 https://bugs.webkit.org/show_bug.cgi?id=167369
2784 Reviewed by Sam Weinig.
2786 Add null pointer check.
2789 (WebView::setCustomBackingScaleFactor):
2791 2017-01-24 Youenn Fablet <youennf@gmail.com>
2793 [WebRTC] Introduce libwebrtc abstraction for WK1/WK2 implementations
2794 https://bugs.webkit.org/show_bug.cgi?id=167294
2796 Reviewed by Alex Christensen.
2799 (WebView::initWithFrame):
2801 2017-01-23 Chris Dumez <cdumez@apple.com>
2803 REGRESSION (r211033): ASSERTION FAILED: m_ptr in com.apple.WebCore: WTF::RefPtr<WebCore::Element>::operator* const + 70
2804 https://bugs.webkit.org/show_bug.cgi?id=167308
2805 <rdar://problem/30144964>
2807 Unreviewed, do a partial revert of r211033 to fix assertion.
2809 * WebCoreSupport/WebChromeClient.cpp:
2810 (WebChromeClient::exitFullScreenForElement):
2812 2017-01-20 Darin Adler <darin@apple.com>
2814 Remove PassRefPtr from "page" directory of WebCore, also deploy references
2815 https://bugs.webkit.org/show_bug.cgi?id=167224
2817 Reviewed by Chris Dumez.
2819 * Plugins/PluginView.cpp:
2820 (WebCore::PluginView::status): Pass reference.
2821 (WebCore::PluginView::focusPluginElement): Ditto.
2823 * WebCoreSupport/WebChromeClient.cpp:
2824 (WebChromeClient::createWindow): Updated for change to ChromeClient.
2825 (WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
2826 (WebChromeClient::runJavaScriptAlert): Ditto.
2827 (WebChromeClient::runJavaScriptConfirm): Ditto.
2828 (WebChromeClient::runJavaScriptPrompt): Ditto.
2829 (WebChromeClient::contentsSizeChanged): Ditto.
2830 (WebChromeClient::unavailablePluginButtonClicked): Ditto.
2831 (WebChromeClient::print): Ditto.
2832 (WebChromeClient::exceededDatabaseQuota): Ditto.
2833 (WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
2834 (WebChromeClient::attachRootGraphicsLayer): Ditto.
2835 (WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
2836 (WebChromeClient::enterVideoFullscreenForVideoElement): Ditto.
2837 (WebChromeClient::createPopupMenu): Ditto.
2838 (WebChromeClient::createSearchPopupMenu): Ditto.
2839 (WebChromeClient::supportsFullScreenForElement): Ditto.
2840 (WebChromeClient::enterFullScreenForElement): Ditto.
2841 (WebChromeClient::exitFullScreenForElement): Ditto.
2842 (WebChromeClient::shouldUseTiledBackingForFrameView): Ditto.
2843 * WebCoreSupport/WebChromeClient.h: Ditto.
2845 2017-01-20 Joseph Pecoraro <pecoraro@apple.com>
2847 Remove never changing IndexedDB RuntimeEnabledFeature
2848 https://bugs.webkit.org/show_bug.cgi?id=167278
2850 Reviewed by Darin Adler.
2853 (WebView::notifyPreferencesChanged):
2855 2017-01-20 Joseph Pecoraro <pecoraro@apple.com>
2857 Cleanup RuntimeEnabledFeatures
2858 https://bugs.webkit.org/show_bug.cgi?id=167228
2860 Reviewed by Simon Fraser.
2863 (WebView::notifyPreferencesChanged):
2865 2017-01-20 Alex Christensen <achristensen@webkit.org>
2867 Build Fix for Windows DumpRenderTree after r210976
2868 https://bugs.webkit.org/show_bug.cgi?id=167115
2872 * IWebPreferencesPrivate.idl:
2873 Add new interface functions.
2875 We use new functions that are only in IWebPreferencesPrivate4,
2876 so instantiate that COM object instead of version 3.
2878 2017-01-20 Joseph Pecoraro <pecoraro@apple.com>
2880 Build Fix for Windows DumpRenderTree after r210976
2882 * WebPreferenceKeysPrivate.h:
2883 * WebPreferences.cpp:
2884 (WebPreferences::initializeDefaultSettings):
2885 (WebPreferences::setWebAnimationsEnabled):
2886 (WebPreferences::webAnimationsEnabled):
2889 Add toggle APIs for WebAnimations.
2891 2017-01-19 Chris Dumez <cdumez@apple.com>
2893 iterable<> should be enabled on WK1
2894 https://bugs.webkit.org/show_bug.cgi?id=167221
2895 <rdar://problem/30108531>
2897 Reviewed by Youenn Fablet.
2899 * Interfaces/IWebPreferencesPrivate.idl:
2900 * WebPreferenceKeysPrivate.h:
2901 * WebPreferences.cpp:
2902 (WebPreferences::setDOMIteratorEnabled): Deleted.
2903 (WebPreferences::domIteratorEnabled): Deleted.
2906 (WebView::notifyPreferencesChanged):
2908 2017-01-18 Alex Christensen <achristensen@webkit.org>
2910 Fix WinCairo build after r210845.
2911 https://bugs.webkit.org/show_bug.cgi?id=167055
2913 * WebCoreSupport/WebFrameLoaderClient.cpp:
2914 * WebCoreSupport/WebFrameLoaderClient.h:
2915 shouldCacheResponse isn't used when loading with libcurl.
2916 It was dead code before Darin added "override".
2917 WebCore/FrameLoaderClient.h has this inside of USE(CFURLCONNECTION) macros, now we have them here, too.
2919 2017-01-18 Andreas Kling <akling@apple.com>
2921 Document::securityOrigin() should return a reference.
2922 <https://webkit.org/b/167124>
2924 Reviewed by Sam Weinig.
2926 * Plugins/PluginView.cpp:
2927 (WebCore::PluginView::load):
2928 * WebCoreSupport/WebChromeClient.cpp:
2929 (WebChromeClient::exceededDatabaseQuota):
2930 * WebCoreSupport/WebFrameLoaderClient.cpp:
2931 (WebFrameLoaderClient::didRunInsecureContent):
2932 * WebCoreSupport/WebFrameLoaderClient.h:
2933 * WebCoreSupport/WebGeolocationClient.cpp:
2934 (WebGeolocationClient::requestPermission):
2936 (WebFrame::allowsFollowingLink):
2938 2017-01-15 Darin Adler <darin@apple.com>
2940 Remove PassRefPtr from "loader" directory of WebCore
2941 https://bugs.webkit.org/show_bug.cgi?id=167055
2943 Reviewed by Alex Christensen.
2945 * Plugins/PluginView.cpp:
2946 (WebCore::PluginView::mediaCanStart): Fix call to dispatchDidFailToStartPlugin
2947 by calling it directly on WebFrameLoaderClient. If my theory is correct, the old
2948 call has been broken and doing nothing since r177941, two years ago, which made
2949 the argument types different between FrameLoaderClient and WebFrameLoaderClient,
2950 leaving WebFrameLoaderClient::dispatchDidFailToStartPlugin as dead code.
2952 * WebCoreSupport/WebChromeClient.cpp:
2953 (WebChromeClient::runOpenPanel): Updated for change to ChromeClient.
2954 * WebCoreSupport/WebChromeClient.h: Ditto.
2956 * WebCoreSupport/WebEditorClient.cpp:
2957 (WebEditorUndoCommand::WebEditorUndoCommand): Take a reference instead of
2958 a PassRefPtr. Also use Ref instead of RefPtr.
2959 (WebEditorClient::shouldChangeTypingStyle): Deleted. Empty function that was
2961 (WebEditorClient::webViewDidChangeTypingStyle): Ditto.
2962 (WebEditorClient::webViewDidChangeSelection): Ditto.
2963 (WebEditorClient::registerUndoStep): Take reference instead of PassRefPtr.
2964 (WebEditorClient::registerRedoStep): Ditto.
2965 * WebCoreSupport/WebEditorClient.h: Updated for the above. Also marked the
2966 class and member functions final and made them all private, which will
2967 help us catch if there are any that don't correctly match WebCore.
2969 * WebCoreSupport/WebFrameLoaderClient.cpp:
2970 (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Updated
2971 for change to ChromeClient.
2972 (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
2973 (WebFrameLoaderClient::dispatchWillSendSubmitEvent): Ditto.
2974 (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto.
2975 (WebFrameLoaderClient::createFrame): Ditto. Also merged two functions into
2976 one because one was private and only called by the other.
2977 (WebFrameLoaderClient::createPlugin): Ditto.
2978 (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
2979 (WebFrameLoaderClient::createNetworkingContext): Ditto.
2980 * WebCoreSupport/WebFrameLoaderClient.h: Ditto.
2982 * WebCoreSupport/WebFrameNetworkingContext.h:
2983 (WebFrameNetworkingContext::create): Return a Ref instead of a PassRefPtr.
2985 2017-01-12 Joseph Pecoraro <pecoraro@apple.com>
2987 Remove unnecessary includes of Page.h
2988 https://bugs.webkit.org/show_bug.cgi?id=166996
2990 Reviewed by Yusuke Suzuki.
2992 * AccessibleTextImpl.cpp:
2993 * BackForwardList.cpp:
2995 2017-01-06 Darin Adler <darin@apple.com>
2997 Remove PassRefPtr use from "inspector", "platform/sql", and "platform/text"
2998 https://bugs.webkit.org/show_bug.cgi?id=166797
3000 Reviewed by Alex Christensen.
3002 * WebCoreSupport/WebEditorClient.h: Update argument to take a reference
3003 instead of a PassRefPtr.
3005 2017-01-05 Andreas Kling <akling@apple.com>
3007 Remove ChromeClient::needTouchEvents().
3008 <https://webkit.org/b/166723>
3010 Rubber-stamped by Antti Koivisto.
3012 * WebCoreSupport/WebChromeClient.h:
3014 2017-01-04 Darin Adler <darin@apple.com>
3016 Remove PassRefPtr use from the "html" directory, other improvements
3017 https://bugs.webkit.org/show_bug.cgi?id=166635
3019 Reviewed by Alex Christensen.
3021 * WebCoreSupport/WebChromeClient.cpp:
3022 (WebChromeClient::loadIconForFiles): Take a reference instead of a pointer.
3023 * WebCoreSupport/WebChromeClient.h: Updated for the above.
3025 2016-12-30 Darin Adler <darin@apple.com>
3027 Remove PassRefPtr use from the "dom" directory, related cleanup
3028 https://bugs.webkit.org/show_bug.cgi?id=166569
3030 Reviewed by Alex Christensen.
3032 * WebCoreSupport/WebFrameLoaderClient.cpp:
3033 (WebFrameLoaderClient::dispatchDidReceiveTitle): Updated since StringWithDirection::title
3034 is now a data member, not a function member.
3035 (WebFrameLoaderClient::updateGlobalHistory): Ditto.
3036 (WebFrameLoaderClient::setTitle): Ditto.
3037 * WebDataSource.cpp:
3038 (WebDataSource::pageTitle): Ditto.
3040 2016-12-25 Yusuke Suzuki <utatane.tea@gmail.com>
3042 Propagate the source origin as much as possible
3043 https://bugs.webkit.org/show_bug.cgi?id=166348
3045 Reviewed by Darin Adler.
3047 * Plugins/PluginPackage.cpp:
3048 (WebCore::NPN_Evaluate):
3049 (WebCore::makeSource): Deleted.
3051 2016-12-22 Andy Estes <aestes@apple.com>
3053 Make WebCore::EditorInsertAction an enum class
3054 https://bugs.webkit.org/show_bug.cgi?id=166424
3056 Reviewed by Brent Fulgham.
3058 * WebCoreSupport/WebEditorClient.cpp:
3060 (WebEditorClient::shouldInsertNode):
3061 (WebEditorClient::shouldInsertText):
3063 2016-12-19 Yusuke Suzuki <utatane.tea@gmail.com>
3065 [ES6] Enable ES6 Modules
3066 https://bugs.webkit.org/show_bug.cgi?id=165849
3068 Reviewed by Geoffrey Garen.
3070 * Interfaces/IWebPreferencesPrivate.idl:
3071 * WebPreferenceKeysPrivate.h:
3072 * WebPreferences.cpp:
3073 (WebPreferences::setES6ModulesEnabled): Deleted.
3074 (WebPreferences::es6ModulesEnabled): Deleted.
3077 (WebView::notifyPreferencesChanged):
3079 2016-12-10 Filip Pizlo <fpizlo@apple.com>
3081 The DOM should have an advancing wavefront opaque root barrier
3082 https://bugs.webkit.org/show_bug.cgi?id=165712
3084 Reviewed by Yusuke Suzuki.
3086 Propagate the JSDOMWindowBase::commonVM() -> commonVM() change.
3088 * Plugins/PluginView.cpp:
3089 (WebCore::PluginView::start):
3090 (WebCore::PluginView::stop):
3091 (WebCore::PluginView::performRequest):
3092 (WebCore::PluginView::npObject):
3093 (WebCore::PluginView::privateBrowsingStateChanged):
3094 * Plugins/PluginViewWin.cpp:
3095 (WebCore::PluginView::dispatchNPEvent):
3096 (WebCore::PluginView::handleKeyboardEvent):
3097 (WebCore::PluginView::handleMouseEvent):
3098 (WebCore::PluginView::setNPWindowRect):
3099 * WebCoreStatistics.cpp:
3100 (WebCoreStatistics::javaScriptObjectsCount):
3101 (WebCoreStatistics::javaScriptGlobalObjectsCount):
3102 (WebCoreStatistics::javaScriptProtectedObjectsCount):
3103 (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3104 (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
3105 (WebCoreStatistics::javaScriptObjectTypeCounts):
3106 (WebCoreStatistics::shouldPrintExceptions):
3107 (WebCoreStatistics::setShouldPrintExceptions):
3108 (WebCoreStatistics::memoryStatistics):
3109 * WebJavaScriptCollector.cpp:
3110 (WebJavaScriptCollector::objectCount):
3112 2016-12-09 Geoffrey Garen <ggaren@apple.com>
3114 TextPosition and OrdinalNumber should be more like idiomatic numbers
3115 https://bugs.webkit.org/show_bug.cgi?id=165678
3117 Reviewed by Filip Pizlo.
3119 Adopt default constructor.
3121 * Plugins/PluginPackage.cpp:
3122 (WebCore::makeSource):
3124 2016-12-08 Filip Pizlo <fpizlo@apple.com>
3126 Enable SharedArrayBuffer, remove the flag
3127 https://bugs.webkit.org/show_bug.cgi?id=165614
3129 Rubber stamped by Geoffrey Garen.
3131 * Interfaces/IWebPreferencesPrivate.idl:
3133 2016-11-26 Yusuke Suzuki <utatane.tea@gmail.com>
3135 [WTF] Import std::optional reference implementation as WTF::Optional
3136 https://bugs.webkit.org/show_bug.cgi?id=164199
3138 Reviewed by Saam Barati and Sam Weinig.
3140 Use WTF::Optional::value_or.
3142 * Plugins/PluginView.cpp:
3143 (WebCore::PluginView::performRequest):
3144 * WebCoreSupport/WebFrameLoaderClient.cpp:
3145 (WebFrameLoaderClient::dispatchDidCommitLoad):
3146 * WebCoreSupport/WebFrameLoaderClient.h:
3147 * WebSecurityOrigin.cpp:
3148 (WebSecurityOrigin::port):
3150 2016-11-19 Simon Fraser <simon.fraser@apple.com>
3152 [iOS WK2] When zoomed in and panning on pages with fixed bars, parts of the bars are sometimes missing
3153 https://bugs.webkit.org/show_bug.cgi?id=164855
3155 Reviewed by Sam Weinig.
3157 Remove the "inStableState" parameter from flushCompositingState() etc.
3159 * WebCoreSupport/AcceleratedCompositingContext.cpp:
3160 (AcceleratedCompositingContext::flushPendingLayerChanges):
3162 (WebView::flushPendingGraphicsLayerChanges):
3164 2016-11-16 Yusuke Suzuki <utatane.tea@gmail.com>
3166 [ES6][WebCore] Change ES6_MODULES compile time flag to runtime flag
3167 https://bugs.webkit.org/show_bug.cgi?id=164827
3169 Reviewed by Ryosuke Niwa.
3171 * Interfaces/IWebPreferencesPrivate.idl:
3172 * WebPreferenceKeysPrivate.h:
3173 * WebPreferences.cpp:
3174 (WebPreferences::setES6ModulesEnabled):
3175 (WebPreferences::es6ModulesEnabled):
3178 (WebView::notifyPreferencesChanged):
3180 2016-11-14 Alex Christensen <achristensen@webkit.org>
3182 Move SecurityOrigin::createFromDatabaseIdentifier to SecurityOriginData
3183 https://bugs.webkit.org/show_bug.cgi?id=164720
3185 Reviewed by Brady Eidson.
3187 * WebDatabaseManager.cpp:
3188 (DidModifyOriginData::dispatchToMainThread):
3189 (DidModifyOriginData::DidModifyOriginData):
3190 (WebDatabaseManager::dispatchDidModifyOrigin):
3191 (WebDatabaseManager::dispatchDidModifyDatabase):
3192 * WebDatabaseManager.h:
3193 * WebSecurityOrigin.cpp:
3194 (WebSecurityOrigin::usage):
3195 (WebSecurityOrigin::quota):
3196 (WebSecurityOrigin::setQuota):
3198 2016-11-13 Darin Adler <darin@apple.com>
3200 Fix exception handling in SQL database code, streamline and update code
3201 https://bugs.webkit.org/show_bug.cgi?id=164685
3203 Reviewed by Sam Weinig.
3205 * WebDatabaseManager.cpp:
3206 (WebDatabaseManager::origins): Use DatabaseTracker.
3207 (WebDatabaseManager::databasesWithOrigin): Ditto.
3208 (WebDatabaseManager::detailsForDatabase): Use reference.
3209 (WebDatabaseManager::deleteAllDatabases): Use DatabaseTracker.
3210 (WebDatabaseManager::deleteOrigin): Ditto.
3211 (WebDatabaseManager::deleteDatabase): Ditto.
3212 (WebDatabaseManager::dispatchDidModifyOrigin): Use reference
3213 and DatabaseTracker.
3214 (WebDatabaseManager::setQuota): Ditto.
3215 (WebDatabaseManager::dispatchDidModifyDatabase): Ditto.
3216 * WebDatabaseManager.h: Updated client functions to take a reference.
3218 * WebSecurityOrigin.cpp:
3219 (WebSecurityOrigin::usage): Update to use DatabaseTracker.
3220 (WebSecurityOrigin::quota): Ditto.
3221 (WebSecurityOrigin::setQuota): Ditto.
3223 2016-11-11 Eric Carlson <eric.carlson@apple.com>
3225 [MediaStream] defer resolution of getUserMedia promise made in a background tab
3226 https://bugs.webkit.org/show_bug.cgi?id=164643
3227 <rdar://problem/29048317>
3229 Unreviewed build fix after r208606.
3231 * Plugins/PluginView.cpp:
3232 (WebCore::PluginView::mediaCanStart):
3233 * Plugins/PluginView.h:
3235 2016-11-11 Darin Adler <darin@apple.com>
3237 Move Node from ExceptionCode to ExceptionOr
3238 https://bugs.webkit.org/show_bug.cgi?id=164515
3240 Reviewed by Sam Weinig.
3242 * DOMCoreClasses.cpp:
3243 (DOMNode::insertBefore): Update exception handling.
3244 (DOMNode::removeChild): Ditto.
3246 2016-10-14 Carlos Garcia Campos <cgarcia@igalia.com>
3248 MemoryPressureHandler shouldn't know how to release WebCore memory
3249 https://bugs.webkit.org/show_bug.cgi?id=160497
3251 Reviewed by Michael Catanzaro.
3253 Set the low memory handler before installing the memory pressure handler.
3256 (WebView::initWithFrame):
3258 2016-11-09 Alex Christensen <achristensen@webkit.org>
3260 Fix Windows build after r208499
3261 https://bugs.webkit.org/show_bug.cgi?id=164562
3266 2016-11-09 Darin Adler <darin@apple.com>
3268 Move Range from ExceptionCode to ExceptionOr
3269 https://bugs.webkit.org/show_bug.cgi?id=164457
3271 Reviewed by Alex Christensen.
3274 (WebView::onIMERequestCharPosition): Updated for new exception handling.
3276 2016-11-09 Darin Adler <darin@apple.com>
3278 Move EventTarget from ExceptionCode to ExceptionOr
3279 https://bugs.webkit.org/show_bug.cgi?id=164465
3281 Reviewed by Youenn Fablet.
3283 * DOMCoreClasses.cpp:
3284 (DOMNode::dispatchEvent): Updated exception handling.
3285 (DOMWindow::dispatchEvent): Ditto.
3287 2016-11-04 Wenson Hsieh <wenson_hsieh@apple.com>
3289 Safari does not emit composition end if blurred for dead key / Japanese IME
3290 https://bugs.webkit.org/show_bug.cgi?id=164369
3291 <rdar://problem/29050439>
3293 Reviewed by Ryosuke Niwa.
3295 Add a stub implementation of canceledComposition.
3297 * WebCoreSupport/WebEditorClient.cpp:
3298 (WebEditorClient::canceledComposition):
3299 * WebCoreSupport/WebEditorClient.h:
3301 2016-11-04 Per Arne Vollan <pvollan@apple.com>
3303 [Win] Page visibility tests are timing out.
3304 https://bugs.webkit.org/show_bug.cgi?id=164363
3306 Reviewed by Brent Fulgham.
3308 Add method to set page visibility.
3310 * Interfaces/IWebViewPrivate.idl:
3312 (WebView::QueryInterface):
3313 (WebView::findString):
3314 (WebView::setVisibilityState):
3317 2016-11-01 Ryosuke Niwa <rniwa@webkit.org>
3319 Remove CUSTOM_ELEMENTS build flag
3320 https://bugs.webkit.org/show_bug.cgi?id=164267
3322 Reviewed by Antti Koivisto.
3324 Removed the build flag.
3327 (WebView::notifyPreferencesChanged):
3329 2016-10-29 Filip Pizlo <fpizlo@apple.com>
3331 JSC should support SharedArrayBuffer
3332 https://bugs.webkit.org/show_bug.cgi?id=163986
3334 Reviewed by Keith Miller.
3336 Support the RuntimeFlag.
3338 * Interfaces/IWebPreferencesPrivate.idl:
3340 2016-10-31 Joseph Pecoraro <pecoraro@apple.com>
3342 Use #pragma once in WebCore
3343 https://bugs.webkit.org/show_bug.cgi?id=164194
3345 Rubber-stamped by Sam Weinig.
3347 * WebCoreSupport/WebContextMenuClient.cpp:
3348 (WebContextMenuClient::isSpeaking):
3349 (WebContextMenuClient::shareMenuItem): Deleted.
3350 * WebCoreSupport/WebContextMenuClient.h:
3351 Remove this dead code since r192333.
3353 2016-10-31 Darin Adler <darin@apple.com>
3355 Convert Document from ExceptionCode to Exception
3356 https://bugs.webkit.org/show_bug.cgi?id=164212
3358 Reviewed by Alex Christensen.
3360 * DOMCoreClasses.cpp:
3361 (DOMDocument::createElement): Updated exception handling.
3362 (DOMDocument::createEvent): Ditto.
3364 2016-10-30 Darin Adler <darin@apple.com>
3366 Move Element, NamedNodeMap, and DOMStringMap from ExceptionCode to Exception
3367 https://bugs.webkit.org/show_bug.cgi?id=164206
3369 Reviewed by Chris Dumez.
3371 * DOMCoreClasses.cpp:
3372 (DOMElement::setAttribute): Updated exception handling.
3373 * DOMHTMLClasses.cpp:
3374 (DOMHTMLElement::setInnerHTML): Ditto.
3376 2016-10-30 Brent Fulgham <bfulgham@apple.com>
3378 Unreviewed build fix (Direct2D)
3381 (WebView::paintWithDirect2D): Update for revised GraphicsContext
3382 begin/end draw behavior.
3384 2016-10-28 Darin Adler <darin@apple.com>
3386 Move all classes in the HTML directory from ExceptionCode to Exception
3387 https://bugs.webkit.org/show_bug.cgi?id=163876
3389 Reviewed by Sam Weinig.
3391 * DOMHTMLClasses.cpp:
3392 (DOMHTMLElement::setInnerText): Update exception handling.
3393 * FullscreenVideoController.cpp:
3394 (FullscreenVideoController::setVolume): Ditto.
3396 2016-10-27 Brent Fulgham <bfulgham@apple.com>
3398 Unreviewed build fix.
3401 (WebView::paintWithDirect2D): Correct merge error.
3403 2016-10-25 Brent Fulgham <bfulgham@apple.com>
3405 [Win][Direct2D] Create a RAII Helper Class for the Render Target
3406 https://bugs.webkit.org/show_bug.cgi?id=164005
3408 Reviewed by Alex Christensen.
3411 (WebView::sizeChanged): Construct RenderTarget with higher-resolution display timer.
3412 (WebView::paintWithDirect2D): Revise to use new RenderTargetHelper class.
3414 2016-10-27 Wenson Hsieh <wenson_hsieh@apple.com>
3416 Support "insertFromDrop" and "deleteByDrag" for the InputEvent spec
3417 https://bugs.webkit.org/show_bug.cgi?id=163948
3418 <rdar://problem/28921433>
3420 Reviewed by Darin Adler.
3422 Add support for new drag and drop-related EditAction enum values.
3424 * WebCoreSupport/WebEditorClient.cpp:
3425 (undoNameForEditAction):
3427 2016-10-26 Brian Burg <bburg@apple.com>
3429 Web Inspector: remove unused bool return value from FrontendChannel::sendMessageToFrontend
3430 https://bugs.webkit.org/show_bug.cgi?id=164046
3432 Reviewed by Joseph Pecoraro.
3434 * WebCoreSupport/WebInspectorClient.h:
3436 2016-10-19 Alex Christensen <achristensen@webkit.org>
3439 https://bugs.webkit.org/show_bug.cgi?id=163675
3441 Reviewed by Brent Fulgham.
3443 * DefaultDownloadDelegate.h:
3444 * WebCoreSupport/WebFrameLoaderClient.cpp:
3445 (WebFrameLoaderClient::savePlatformDataToCachedFrame):
3446 * WebCoreSupport/WebFrameNetworkingContext.cpp:
3447 (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3448 * WebCoreSupport/WebFrameNetworkingContext.h:
3449 * WebCoreSupport/WebPlatformStrategies.cpp:
3452 (WebError::localizedDescription):
3453 (WebError::sslPeerCertificate):
3455 * WebMutableURLRequest.cpp:
3456 (WebMutableURLRequest::mutableCopy):
3457 * WebURLAuthenticationChallenge.cpp:
3458 (WebURLAuthenticationChallenge::initWithProtectionSpace):
3459 (WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
3460 * WebURLResponse.cpp:
3461 (WebURLResponse::sslPeerCertificate):
3464 (WebView::setCacheModel):
3465 (WebView::canHandleRequest):
3466 (WebView::notifyPreferencesChanged):
3467 (updateSharedSettingsFromPreferencesIfNeeded):
3469 2016-10-18 Darin Adler <darin@apple.com>
3471 Move many miscellaneous classes from ExceptionCode to Exception
3472 https://bugs.webkit.org/show_bug.cgi?id=163645
3474 Reviewed by Ryosuke Niwa.
3476 * DOMCoreClasses.cpp:
3477 (DOMDocument::getComputedStyle): Use ptr instead of get since the return
3478 value is now Ref instead of RefPtr.
3480 2016-10-18 Anders Carlsson <andersca@apple.com>
3482 Try to fix the Windows build.
3484 * WebHistoryItem.cpp:
3485 (WebHistoryItem::redirectURLs):
3487 2016-10-18 Anders Carlsson <andersca@apple.com>
3489 Move some history specific HistoryItem code to WebHistoryItem
3490 https://bugs.webkit.org/show_bug.cgi?id=163567
3492 Reviewed by Tim Horton.
3494 Remove these, they aren't used.
3496 * WebCoreSupport/WebFrameLoaderClient.cpp:
3497 (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
3499 (WebHistory::visitedURL):
3500 * WebHistoryItem.cpp:
3501 (WebHistoryItem::initFromDictionaryRepresentation):
3502 (WebHistoryItem::dictionaryRepresentation):
3504 2016-10-16 Darin Adler <darin@apple.com>
3506 Move CSS classes from ExceptionCode to Exception
3507 https://bugs.webkit.org/show_bug.cgi?id=163494
3509 Reviewed by Sam Weinig.
3511 * DOMCSSClasses.cpp:
3512 (DOMCSSStyleDeclaration::setCssText): Remove ExceptionCode handling.
3513 (DOMCSSStyleDeclaration::setProperty): Ditto.
3515 2016-10-12 Anders Carlsson <andersca@apple.com>
3517 Copy BackForwardList from WebCore to WebKit/win
3518 https://bugs.webkit.org/show_bug.cgi?id=163360
3520 Reviewed by Alex Christensen.
3522 Use our local BackForwardList class instead of WebCore::BackForwardList.
3524 * BackForwardList.cpp: Added.
3525 * BackForwardList.h: Added.
3526 * WebBackForwardList.h:
3528 (WebView::initWithFrame):
3529 (WebView::backForwardList):
3531 2016-10-13 Anders Carlsson <andersca@apple.com>
3533 Get rid of the HistoryItemVector typedef
3534 https://bugs.webkit.org/show_bug.cgi?id=163398
3536 Reviewed by Beth Dakin.
3538 Expand the HistoryitemVector typedef instead to make it more clear what types we are dealing with.
3540 * WebBackForwardList.cpp:
3541 (WebBackForwardList::backListWithLimit):
3542 (WebBackForwardList::forwardListWithLimit):
3543 * WebHistoryItem.cpp:
3544 (WebHistoryItem::children):
3546 2016-10-12 Brent Fulgham <bfulgham@apple.com>
3548 [Win] Unreviewed build fix after r207218.
3550 The CQ-landed patch used the old USE(CFNETWORK) compiler guard.
3551 It should be using USE(CFURLCONNECTION).