Move NetworkStorageSession ownership to NetworkProcess
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2019-01-22  Alex Christensen  <achristensen@webkit.org>
2
3         Move NetworkStorageSession ownership to NetworkProcess
4         https://bugs.webkit.org/show_bug.cgi?id=193580
5
6         Reviewed by Geoff Garen.
7
8         * WebCoreSupport/WebFrameNetworkingContext.cpp:
9         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
10         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
11         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
12         (WebFrameNetworkingContext::storageSession const):
13         * WebDownloadCFNet.cpp:
14         (WebDownload::didReceiveAuthenticationChallenge):
15         * WebPreferences.cpp:
16         (WebPreferences::clearNetworkLoaderSession):
17         (WebPreferences::switchNetworkLoaderToNewTestingSession):
18
19 2019-01-15  Darin Adler  <darin@apple.com>
20
21         Use references rather than pointers for register/unregister functions, and more
22         https://bugs.webkit.org/show_bug.cgi?id=175028
23
24         Reviewed by Daniel Bates.
25
26         * Plugins/PluginView.cpp:
27         (WebCore::PluginView::startOrAddToUnstartedList): Pass a reference.
28         (WebCore::PluginView::~PluginView): Ditto.
29         * WebView.cpp:
30         (WebView::fullScreenClientWillEnterFullScreen): Ditto.
31         (WebView::fullScreenClientDidEnterFullScreen): Ditto.
32         (WebView::fullScreenClientDidExitFullScreen): Ditto.
33
34 2019-01-17  Per Arne Vollan  <pvollan@apple.com>
35
36         [Win][HighDPI] Repaint glitches when scrolling.
37         https://bugs.webkit.org/show_bug.cgi?id=173152
38         <rdar://problem/45269953>
39
40         Reviewed by Brent Fulgham.
41
42         Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
43         delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
44         Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
45
46         * WebView.cpp:
47         (WebView::scrollBackingStore):
48
49 2019-01-17  Alex Christensen  <achristensen@webkit.org>
50
51         Stop using NetworkStorageSession::storageSession in WebCore
52         https://bugs.webkit.org/show_bug.cgi?id=193529
53
54         Reviewed by Tim Horton.
55
56         * WebView.cpp:
57         (WebView::initWithFrame):
58
59 2019-01-15  Alex Christensen  <achristensen@webkit.org>
60
61         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
62         https://bugs.webkit.org/show_bug.cgi?id=193368
63
64         Reviewed by Geoff Garen.
65
66         * WebDownloadCFNet.cpp:
67         (WebDownload::didReceiveAuthenticationChallenge):
68
69 2019-01-15  Alex Christensen  <achristensen@webkit.org>
70
71         Fix Windows build after r240014
72         https://bugs.webkit.org/show_bug.cgi?id=161106
73
74         * WebView.cpp:
75
76 2019-01-15  Alex Christensen  <achristensen@webkit.org>
77
78         Stop using CookiesStrategy
79         https://bugs.webkit.org/show_bug.cgi?id=161106
80
81         Reviewed by Don Olmstead and Antti Koivisto.
82
83         * Plugins/PluginView.cpp:
84         (WebCore::PluginView::getValueForURL):
85         (WebCore::PluginView::setValueForURL):
86         * WebCoreSupport/WebPlatformStrategies.cpp:
87         (WebPlatformStrategies::createBlobRegistry):
88         (WebPlatformStrategies::createCookiesStrategy): Deleted.
89         (WebPlatformStrategies::cookiesForDOM): Deleted.
90         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
91         (WebPlatformStrategies::cookiesEnabled): Deleted.
92         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
93         (WebPlatformStrategies::getRawCookies): Deleted.
94         (WebPlatformStrategies::deleteCookie): Deleted.
95         * WebCoreSupport/WebPlatformStrategies.h:
96         * WebView.cpp:
97         (WebView::initWithFrame):
98
99 2019-01-08  Alex Christensen  <achristensen@webkit.org>
100
101         Stop using NetworkStorageSession in WebProcess
102         https://bugs.webkit.org/show_bug.cgi?id=193236
103
104         Reviewed by Don Olmstead.
105
106         * WebCoreSupport/WebFrameNetworkingContext.cpp:
107         (WebFrameNetworkingContext::storageSession const):
108         * WebCoreSupport/WebFrameNetworkingContext.h:
109         * WebCoreSupport/WebPlatformStrategies.cpp:
110         (WebPlatformStrategies::cookiesForDOM):
111         (WebPlatformStrategies::setCookiesFromDOM):
112         (WebPlatformStrategies::cookiesEnabled):
113         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
114         (WebPlatformStrategies::getRawCookies):
115         (WebPlatformStrategies::deleteCookie):
116         * WebCoreSupport/WebPlatformStrategies.h:
117
118 2019-01-08  Alex Christensen  <achristensen@webkit.org>
119
120         Unreviewed, rolling out r239727.
121
122         Broke API tests
123
124         Reverted changeset:
125
126         "Stop using NetworkStorageSession in WebProcess"
127         https://bugs.webkit.org/show_bug.cgi?id=193236
128         https://trac.webkit.org/changeset/239727
129
130 2018-12-24  Fujii Hironori  <Hironori.Fujii@sony.com>
131
132         Remove "using namespace std;"
133         https://bugs.webkit.org/show_bug.cgi?id=192973
134
135         Reviewed by Alex Christensen.
136
137         * FullscreenVideoController.cpp:
138         * WebFrame.cpp:
139         (WebFrame::drawFooter):
140         * WebHistory.cpp:
141         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
142         * WebKitQuartzCoreAdditions/CAView.cpp:
143         * WebView.cpp:
144         (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
145         (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
146         (WebView::setCacheModel):
147         (WebView::maxCacheModelInAnyInstance):
148
149 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
150
151         Use Ref<> as much as possible
152         https://bugs.webkit.org/show_bug.cgi?id=192808
153
154         Reviewed by Alex Christensen.
155
156         * Plugins/PluginDatabase.cpp:
157         (WebCore::PluginDatabase::refresh):
158         * Plugins/PluginView.cpp:
159         (WebCore::PluginView::mediaCanStart):
160         (WebCore::PluginView::performRequest):
161         (WebCore::PluginView::bindingInstance):
162         * Plugins/PluginView.h:
163         * WebCoreSupport/WebFrameLoaderClient.cpp:
164         (WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
165         (WebFrameLoaderClient::createPlugin):
166         (WebFrameLoaderClient::createJavaAppletWidget):
167         * WebCoreSupport/WebFrameLoaderClient.h:
168         * WebFrame.cpp:
169         (WebFrame::loadData):
170         (WebFrame::loadPlainTextString):
171         (WebFrame::loadHTMLString):
172         * WebFrame.h:
173         * WebKitQuartzCoreAdditions/CAView.cpp:
174         (WKQCA::CAView::create):
175         * WebKitQuartzCoreAdditions/CAView.h:
176         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
177         (WKQCA::CVDisplayLink::create):
178         * WebKitQuartzCoreAdditions/CVDisplayLink.h:
179         * WebKitQuartzCoreAdditions/ImageConversion.cpp:
180         (WKQCA::getImageCopy):
181         * WebView.cpp:
182         (WebView::addUserScriptToGroup):
183         (WebView::addUserStyleSheetToGroup):
184
185 2018-12-20  Chris Dumez  <cdumez@apple.com>
186
187         Use Optional::valueOr() instead of Optional::value_or()
188         https://bugs.webkit.org/show_bug.cgi?id=192933
189
190         Reviewed by Geoffrey Garen.
191
192         * WebSecurityOrigin.cpp:
193         (WebSecurityOrigin::port):
194
195 2018-12-19  Chris Dumez  <cdumez@apple.com>
196
197         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
198         https://bugs.webkit.org/show_bug.cgi?id=192728
199         <rdar://problem/46746779>
200
201         Reviewed by Geoff Garen.
202
203         * Plugins/*:
204         * WebCoreSupport/*:
205
206 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
207
208         [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag
209         https://bugs.webkit.org/show_bug.cgi?id=192617
210
211         Reviewed by Alex Christensen.
212
213         * COMEnumVariant.h:
214         (COMEnumVariant<ContainerType>::adopt): Removed 'typename' from non dependent names.
215         (COMEnumVariant<ContainerType>::createInstance): Ditto.
216         (COMEnumVariant<ContainerType>::Next): Prepend 'typename' for dependent names.
217         * COMPropertyBag.h:
218         (HashType>::createInstance): Removed 'typename' from non dependent names.
219         (HashType>::adopt): Ditto.
220         (HashType>::Read): Replaced dependent name 'HashMapType::const_iterator' with 'auto'.
221         (HashType>::GetPropertyInfo): Ditto.
222
223 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
224
225         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
226         https://bugs.webkit.org/show_bug.cgi?id=192618
227
228         Reviewed by Alex Christensen.
229
230         Classes which implement COM interface usually doesn't need the
231         virtual destructor because it has Release() virtual method to
232         destruct itself.
233
234         Marked 'final' such classes to suppress clang-cl's compilation
235         warnings.
236
237         * COMEnumVariant.h:
238         * COMPropertyBag.h:
239         * DefaultDownloadDelegate.h:
240         * DefaultPolicyDelegate.h:
241         * MemoryStream.h:
242         * WebActionPropertyBag.h:
243         * WebApplicationCache.h:
244         * WebArchive.h:
245         * WebBackForwardList.h:
246         * WebCache.h:
247         * WebCoreStatistics.h:
248         * WebCoreSupport/WebEditorClient.cpp:
249         * WebCoreSupport/WebInspectorDelegate.h:
250         * WebDataSource.h:
251         * WebDatabaseManager.cpp:
252         * WebDatabaseManager.h:
253         * WebDownload.h:
254         * WebDropSource.h:
255         * WebElementPropertyBag.h:
256         * WebError.h:
257         * WebFrame.cpp:
258         * WebFrame.h:
259         * WebFramePolicyListener.h:
260         * WebGeolocationPolicyListener.h:
261         * WebGeolocationPosition.h:
262         * WebHTMLRepresentation.h:
263         * WebHistory.h:
264         * WebHistoryItem.h:
265         * WebInspector.h:
266         * WebJavaScriptCollector.h:
267         * WebKitClassFactory.h:
268         * WebKitMessageLoop.h:
269         * WebKitStatistics.h:
270         * WebMutableURLRequest.h:
271         * WebNavigationData.h:
272         * WebNotification.h:
273         * WebNotificationCenter.h:
274         * WebPreferences.h:
275         * WebResource.h:
276         * WebScriptWorld.h:
277         * WebSecurityOrigin.h:
278         * WebSerializedJSValue.h:
279         * WebTextRenderer.h:
280         * WebURLAuthenticationChallenge.h:
281         * WebURLAuthenticationChallengeSender.h:
282         * WebURLCredential.h:
283         * WebURLProtectionSpace.h:
284         * WebURLResponse.h:
285         * WebUserContentURLPattern.h:
286         * WebView.cpp:
287         * WebView.h:
288         * WebWorkersPrivate.h:
289
290 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
291
292         [Win][Clang] Fix warning -Wmissing-field-initializers
293         https://bugs.webkit.org/show_bug.cgi?id=192584
294
295         Reviewed by Yusuke Suzuki.
296
297         Initialize a struct with '{ }' instead of '= {0}'.
298
299         * WebKitMessageLoop.cpp:
300         (WebKitMessageLoop::run):
301         * WebView.cpp:
302         (WebView::onMenuCommand):
303         (WebView::gesture):
304         (WebView::setShouldInvertColors):
305         (WebView::initializeToolTipWindow):
306         (WebView::setToolTip):
307         (WebView::fullScreenClientForceRepaint):
308
309 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
310
311         Turn WritingDirection into an enum class
312         https://bugs.webkit.org/show_bug.cgi?id=192401
313         Work towards <rdar://problem/42075638>
314
315         Reviewed by Dan Bernstein.
316
317         Change WritingDirection from an enum to an enum class. No change in behavior.
318
319         * WebFrame.cpp:
320         (WebFrame::setTextDirection):
321
322 2018-12-03  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
323
324         Use WallTime for file time
325         https://bugs.webkit.org/show_bug.cgi?id=192287
326
327         Reviewed by Darin Adler.
328
329         * Plugins/PluginDatabase.cpp:
330         (WebCore::PluginDatabase::refresh):
331
332 2018-11-30  Alex Christensen  <achristensen@webkit.org>
333
334         Fix Windows build.
335
336         * WebView.cpp:
337
338 2018-11-30  Alex Christensen  <achristensen@webkit.org>
339
340         Fix Windows build.
341
342         * WebCoreSupport/WebFrameLoaderClient.h:
343
344 2018-11-30  Alex Christensen  <achristensen@webkit.org>
345
346         Fix Windows build.
347
348         * WebCoreSupport/WebFrameLoaderClient.h:
349
350 2018-11-30  Alex Christensen  <achristensen@webkit.org>
351
352         Move URL from WebCore to WTF
353         https://bugs.webkit.org/show_bug.cgi?id=190234
354
355         Reviewed by Keith Miller.
356
357         * MarshallingHelpers.cpp:
358         * MarshallingHelpers.h:
359         * Plugins/PluginDatabase.cpp:
360         * Plugins/PluginDatabase.h:
361         * Plugins/PluginDatabaseWin.cpp:
362         * Plugins/PluginStream.h:
363         * Plugins/PluginView.h:
364         * WebCoreSupport/WebContextMenuClient.h:
365         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
366         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
367         * WebCoreSupport/WebFrameLoaderClient.h:
368         * WebCoreSupport/WebPlatformStrategies.h:
369         * WebCoreSupport/WebPluginInfoProvider.cpp:
370         (WebPluginInfoProvider::webVisiblePluginInfo):
371         * WebCoreSupport/WebPluginInfoProvider.h:
372         * WebCoreSupport/WebVisitedLinkStore.h:
373         * WebDataSource.cpp:
374         * WebDownload.h:
375         * WebElementPropertyBag.cpp:
376         * WebFrame.h:
377         * WebHistory.cpp:
378         * WebHistory.h:
379         * WebHistoryItem.cpp:
380         * WebResource.cpp:
381         (WebResource::WebResource):
382         * WebResource.h:
383         * WebSecurityOrigin.cpp:
384         * WebURLResponse.cpp:
385         (WebURLResponse::createInstance):
386         * WebUserContentURLPattern.cpp:
387         * WebView.h:
388
389 2018-11-28  Alex Christensen  <achristensen@webkit.org>
390
391         Remove dead code from an earlier attempt at implementing safe browsing
392         https://bugs.webkit.org/show_bug.cgi?id=192067
393
394         Reviewed by Chris Dumez.
395
396         * WebCoreSupport/WebFrameLoaderClient.cpp:
397         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
398         * WebCoreSupport/WebFrameLoaderClient.h:
399
400 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
401
402         [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
403         https://bugs.webkit.org/show_bug.cgi?id=191959
404
405         Reviewed by Alex Christensen.
406
407         * MarshallingHelpers.h: Removed extra "MarshallingHelpers::" of windowsEpochAbsoluteTime declaration.
408
409 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
410
411         [Win] Reduce the use of WKSI library calls: CoreAnimation
412         https://bugs.webkit.org/show_bug.cgi?id=191777
413         <rdar://problem/46140542>
414
415         Reviewed by Zalan Bujtas.
416
417         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
418         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
419         directives for WebKitSystemInterface.lib.
420
421         * FullscreenVideoController.cpp:
422         * WebKitGraphics.cpp:
423         * WebPreferences.cpp:
424
425 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
426
427         Address post-review feedback after r238438
428         https://bugs.webkit.org/show_bug.cgi?id=191913
429
430         Reviewed by Ryosuke Niwa.
431
432         * AccessibleTextImpl.cpp:
433         (AccessibleText::replaceText):
434
435 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
436
437         Web Inspector: "Reload Web Inspector" button no longer partially works
438         https://bugs.webkit.org/show_bug.cgi?id=191773
439         <rdar://problem/46139932>
440
441         Reviewed by Devin Rousso.
442
443         * WebCoreSupport/WebInspectorClient.cpp:
444         (WebInspectorFrontendClient::reopen):
445         * WebCoreSupport/WebInspectorClient.h:
446
447 2018-11-17  Devin Rousso  <drousso@apple.com>
448
449         Web Inspector: Network: add button to show system certificate dialog
450         https://bugs.webkit.org/show_bug.cgi?id=191458
451         <rdar://problem/45977019>
452
453         Reviewed by Joseph Pecoraro.
454
455         * WebCoreSupport/WebInspectorClient.h:
456         * WebCoreSupport/WebInspectorClient.cpp:
457         (WebInspectorFrontendClient::showCertificate): Added.
458
459 2018-11-16  Brent Fulgham  <bfulgham@apple.com>
460
461         [Win] Reduce the use of WKSI library calls: CFNetwork
462         https://bugs.webkit.org/show_bug.cgi?id=191718
463         <rdar://problem/46108732>
464
465         Reviewed by Alex Christensen.
466
467         Remove custom WKSI CFNetwork calls, since the SPI is already documented in PAL. Just
468         make the same calls on Windows, like we did for iOS and macOS back in 2017.
469
470         * WebCache.cpp:
471         (WebCache::cacheFolder):
472         * WebCoreSupport/WebFrameNetworkingContext.cpp:
473         * WebCoreSupport/WebPlatformStrategies.cpp:
474         * WebError.cpp:
475         (WebError::localizedDescription):
476         (WebError::sslPeerCertificate):
477         * WebURLResponse.cpp:
478         (WebURLResponse::sslPeerCertificate):
479         (WebURLResponse::certificateDictionary const):
480         * WebView.cpp:
481         (WebView::setCacheModel):
482
483 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
484
485         [Win] Reduce the use of WKSI library calls: Font Handling
486         https://bugs.webkit.org/show_bug.cgi?id=191701
487         <rdar://problem/46104809>
488
489         Reviewed by Myles C. Maxfield.
490
491         Update to use the old font handling routines moved from WKSI to FontCascade.
492
493         * WebPreferences.cpp:
494         (WebPreferences::setFontSmoothing):
495         (WebPreferences::setFontSmoothingContrast):
496         * WebView.cpp:
497         (systemParameterChanged):
498
499 2018-11-14  Timothy Hatcher  <timothy@apple.com>
500
501         Default the view background color and text color to different values when in dark mode.
502         https://bugs.webkit.org/show_bug.cgi?id=191607
503         rdar://problem/46045854
504
505         Reviewed by Dean Jackson.
506
507         * WebFrame.cpp:
508         (WebFrame::updateBackground): Drop backgroundColor.
509         * WebCoreSupport/WebFrameLoaderClient.cpp:
510         (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor.
511
512 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
513
514         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
515         https://bugs.webkit.org/show_bug.cgi?id=191612
516
517         Reviewed by Matt Baker.
518
519         * WebCoreSupport/WebInspectorClient.cpp:
520         (WebInspectorFrontendClient::destroyInspectorView):
521
522 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
523
524         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
525         https://bugs.webkit.org/show_bug.cgi?id=189230
526         <rdar://problem/44050379>
527
528         Reviewed by Joseph Pecoraro.
529
530         Runs all png images through zopflipng. This results in a smaller file
531         size and takes care of this issue as a byproduct.
532
533         * WebKit.resources/deleteButton.png:
534         * WebKit.resources/deleteButtonPressed.png:
535         * WebKit.resources/fsVideoAudioVolumeHigh.png:
536         * WebKit.resources/fsVideoAudioVolumeLow.png:
537         * WebKit.resources/fsVideoExitFullscreen.png:
538         * WebKit.resources/fsVideoPause.png:
539         * WebKit.resources/fsVideoPlay.png:
540         * WebKit.resources/missingImage.png:
541         * WebKit.resources/nullplugin.png:
542         * WebKit.resources/panEastCursor.png:
543         * WebKit.resources/panIcon.png:
544         * WebKit.resources/panNorthCursor.png:
545         * WebKit.resources/panNorthEastCursor.png:
546         * WebKit.resources/panNorthWestCursor.png:
547         * WebKit.resources/panSouthCursor.png:
548         * WebKit.resources/panSouthEastCursor.png:
549         * WebKit.resources/panSouthWestCursor.png:
550         * WebKit.resources/panWestCursor.png:
551         * WebKit.resources/searchCancel.png:
552         * WebKit.resources/searchCancelPressed.png:
553         * WebKit.resources/searchMagnifier.png:
554         * WebKit.resources/searchMagnifierResults.png:
555         * WebKit.resources/textAreaResizeCorner.png:
556         * WebKit.resources/verticalTextCursor.png:
557         * WebKit.resources/zoomInCursor.png:
558         * WebKit.resources/zoomOutCursor.png:
559
560 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
561
562         Unreviewed Windows build fix for r238049.
563
564         * WebView.cpp:
565         (WebView::initWithFrame):
566
567 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
568
569         Unreviewed MSVC build fix after r238039 (and r238046).
570
571         * WebDocumentLoader.h:
572         * WebView.cpp:
573         (WebView::setShouldApplyMacFontAscentHack):
574
575 2018-11-09  Antti Koivisto  <antti@apple.com>
576
577         Use OptionSet for layout milestones
578         https://bugs.webkit.org/show_bug.cgi?id=191470
579
580         Reviewed by Dean Jackson.
581
582         * WebCoreSupport/WebFrameLoaderClient.cpp:
583         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
584         * WebCoreSupport/WebFrameLoaderClient.h:
585
586 2018-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
587
588         WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
589         https://bugs.webkit.org/show_bug.cgi?id=191455
590
591         Reviewed by Brent Fulgham.
592
593         * WebHistory.h: Marked with 'override' and removed 'virtual'.
594
595 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
596
597         Add a storage limit for IndexedDB
598         https://bugs.webkit.org/show_bug.cgi?id=190598
599         <rdar://problem/44654715>
600
601         Reviewed by Chris Dumez.
602
603         * Interfaces/IWebDatabaseManager.idl:
604         * WebDatabaseManager.cpp:
605         (WebDatabaseManager::setIDBPerOriginQuota):
606         * WebDatabaseManager.h:
607
608 2018-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
609
610         [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
611         https://bugs.webkit.org/show_bug.cgi?id=191105
612
613         Reviewed by Brent Fulgham.
614
615         * DOMHTMLClasses.h:
616         (DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
617         instead of own setNodeValue.
618
619 2018-10-25  Antoine Quint  <graouts@apple.com>
620
621         [Web Animations] Turn Web Animations CSS Integration off by default
622         https://bugs.webkit.org/show_bug.cgi?id=190901
623
624         Reviewed by Dean Jackson.
625
626         * WebPreferences.cpp:
627         (WebPreferences::initializeDefaultSettings):
628
629 2018-10-21  Fujii Hironori  <Hironori.Fujii@sony.com>
630
631         [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
632         https://bugs.webkit.org/show_bug.cgi?id=190744
633
634         Reviewed by Alex Christensen.
635
636         clang-cl reports compilation warnings for inconsistent 'override'
637         keyword usage.
638
639         WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
640         This can't be marked 'override' if !USE(CA).
641
642         * WebView.cpp:
643         (WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).
644         * WebView.h: Marked all overriding member function declarations of WebView 'override'.
645         Declare flushPendingGraphicsLayerChanges only if USE(CA).
646
647 2018-10-18  Alex Christensen  <achristensen@webkit.org>
648
649         Clean up FrameLoader two-state enums
650         https://bugs.webkit.org/show_bug.cgi?id=190731
651
652         Reviewed by Chris Dumez.
653
654         * WebCoreSupport/WebFrameLoaderClient.cpp:
655         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
656         * WebCoreSupport/WebFrameLoaderClient.h:
657
658 2018-10-17  Alex Christensen  <achristensen@webkit.org>
659
660         BackForwardClient needs to be able to support UIProcess-only back/forward lists
661         https://bugs.webkit.org/show_bug.cgi?id=190675
662
663         Reviewed by Chris Dumez.
664
665         * BackForwardList.cpp:
666         (BackForwardList::backItem):
667         (BackForwardList::currentItem):
668         (BackForwardList::forwardItem):
669         (BackForwardList::backListCount const):
670         (BackForwardList::forwardListCount const):
671         (BackForwardList::itemAtIndex):
672         * BackForwardList.h:
673
674 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
675
676         Unreviewed attempt to fix the Windows build after r237112.
677
678         * Plugins/PluginView.cpp:
679         (WebCore::PluginView::performRequest):
680
681 2018-10-16  Alex Christensen  <achristensen@webkit.org>
682
683         Replace HistoryItem* with HistoryItem& where possible
684         https://bugs.webkit.org/show_bug.cgi?id=190617
685
686         Reviewed by Chris Dumez.
687
688         * BackForwardList.cpp:
689         (BackForwardList::goToItem):
690         * BackForwardList.h:
691         * WebBackForwardList.cpp:
692         (WebBackForwardList::goToItem):
693
694 2018-10-15  Alex Christensen  <achristensen@webkit.org>
695
696         Fix Windows build.
697
698         * WebView.cpp:
699         (WebView::loadBackForwardListFromOtherView):
700
701 2018-10-15  Alex Christensen  <achristensen@webkit.org>
702
703         Fix WinCairo build.
704
705         * WebView.cpp:
706         (WebView::backForwardList):
707
708 2018-10-15  Alex Christensen  <achristensen@webkit.org>
709
710         Modernize BackForwardClient.h
711         https://bugs.webkit.org/show_bug.cgi?id=190610
712
713         Reviewed by Chris Dumez.
714
715         * BackForwardList.cpp:
716         (BackForwardList::backListCount const):
717         (BackForwardList::forwardListCount const):
718         (BackForwardList::backListCount): Deleted.
719         (BackForwardList::forwardListCount): Deleted.
720         * BackForwardList.h:
721         * WebView.cpp:
722         (WebView::initWithFrame):
723         (WebView::backForwardList):
724
725 2018-10-15  Alex Christensen  <achristensen@webkit.org>
726
727         Remove unused WebView._globalHistoryItem
728         https://bugs.webkit.org/show_bug.cgi?id=190601
729
730         Reviewed by Chris Dumez.
731
732         * WebCoreSupport/WebFrameLoaderClient.cpp:
733         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
734         * WebCoreSupport/WebFrameLoaderClient.h:
735         * WebView.cpp:
736         (WebView::globalHistoryItem):
737         (WebView::setGlobalHistoryItem): Deleted.
738         * WebView.h:
739
740 2018-10-15  Alex Christensen  <achristensen@webkit.org>
741
742         Remove unused parameters from FrameLoaderClient::createFrame
743         https://bugs.webkit.org/show_bug.cgi?id=190587
744
745         Reviewed by Chris Dumez.
746
747         * WebCoreSupport/WebFrameLoaderClient.cpp:
748         (WebFrameLoaderClient::createFrame):
749         * WebCoreSupport/WebFrameLoaderClient.h:
750
751 2018-10-15  Chris Dumez  <cdumez@apple.com>
752
753         Unreviewed Windows build fix after r237112.
754
755         * Plugins/PluginView.cpp:
756         (WebCore::PluginView::performRequest):
757         (WebCore::PluginView::load):
758
759 2018-10-15  Alex Christensen  <achristensen@webkit.org>
760
761         Remove InjectedBundle processing of back/forward lists
762         https://bugs.webkit.org/show_bug.cgi?id=190459
763
764         Reviewed by Chris Dumez.
765
766         * WebCoreSupport/WebFrameLoaderClient.cpp:
767         (WebFrameLoaderClient::shouldGoToHistoryItem const):
768         * WebCoreSupport/WebFrameLoaderClient.h:
769
770 2018-10-02  Alex Christensen  <achristensen@webkit.org>
771
772         Remove ParsedURLString
773         https://bugs.webkit.org/show_bug.cgi?id=190154
774
775         Reviewed by Chris Dumez.
776
777         * WebDownloadCurl.cpp:
778         (WebDownload::initWithRequest):
779         * WebURLResponse.cpp:
780         (WebURLResponse::createInstance):
781
782 2018-09-28  Chris Dumez  <cdumez@apple.com>
783
784         Drop support for cross-origin-window-policy header
785         https://bugs.webkit.org/show_bug.cgi?id=190081
786
787         Reviewed by Ryosuke Niwa.
788
789         * WebPreferenceKeysPrivate.h:
790         * WebPreferences.cpp:
791         (WebPreferences::initializeDefaultSettings):
792         (WebPreferences::crossOriginWindowPolicySupportEnabled):
793         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
794         * WebView.cpp:
795         (WebView::notifyPreferencesChanged):
796
797 2018-09-27  Antoine Quint  <graouts@apple.com>
798
799         [Web Animations] Turn Web Animations with CSS integration on
800         https://bugs.webkit.org/show_bug.cgi?id=184819
801         <rdar://problem/39597337>
802
803         Reviewed by Dean Jackson.
804
805         * WebPreferences.cpp:
806         (WebPreferences::initializeDefaultSettings):
807
808 2018-09-21  Alex Christensen  <achristensen@webkit.org>
809
810         Use a Variant for FormDataElement
811         https://bugs.webkit.org/show_bug.cgi?id=189777
812
813         Reviewed by Chris Dumez.
814
815         * WebMutableURLRequest.cpp:
816         (WebMutableURLRequest::setHTTPBody):
817
818 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
819
820         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
821         https://bugs.webkit.org/show_bug.cgi?id=189612
822
823         Reviewed by Alex Christensen.
824
825         Non-trivial types can't be used as aruguments of LOG_ERROR and
826         ASSERT_WITH_MESSAGE.
827
828         * DefaultPolicyDelegate.cpp:
829         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
830         static_cast<BSTR> to convert BString.
831         * WebLocalizableStrings.cpp:
832         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
833         char* by using 'key.utf8().data()'.
834
835 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
836
837         Unreviewed, rolling out r235953.
838
839         Caused layout test crashes under GuardMalloc.
840
841         Reverted changeset:
842
843         "Make GraphicsLayers ref-counted, so their tree can persist
844         when disconnected from RenderLayerBackings"
845         https://bugs.webkit.org/show_bug.cgi?id=189521
846         https://trac.webkit.org/changeset/235953
847
848 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
849
850         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
851         https://bugs.webkit.org/show_bug.cgi?id=189538
852
853         Reviewed by Per Arne Vollan.
854
855         * WebPreferences.cpp:
856         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
857         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
858         Apply static_cast to the result of OR-ed CFPropertyListFormat.
859         (WebPreferences::screenFontSubstitutionEnabled):
860         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
861
862 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
863
864         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
865         https://bugs.webkit.org/show_bug.cgi?id=189539
866
867         Reviewed by Alex Christensen.
868
869         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
870         * WebCoreSupport/WebInspectorClient.cpp:
871         (WebInspectorWndProc): Ditto.
872         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
873         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
874
875 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
876
877         Refactor WebCore::EditAction to be an 8-bit enum class
878         https://bugs.webkit.org/show_bug.cgi?id=189383
879
880         Reviewed by Dan Bernstein.
881
882         * WebCoreSupport/WebEditorClient.cpp:
883         (undoNameForEditAction):
884
885 2018-09-04  Frederic Wang  <fwang@igalia.com>
886
887         Add basic support for ScrollIntoViewOptions
888         https://bugs.webkit.org/show_bug.cgi?id=189258
889
890         Reviewed by Simon Fraser.
891
892         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
893         can build despite the new scrollIntoView function.
894
895 2018-08-31  Chris Dumez  <cdumez@apple.com>
896
897         Unreviewed Windows build fix after r235562.
898
899         * WebCoreSupport/WebFrameLoaderClient.cpp:
900         (WebFrameLoaderClient::dispatchWillSubmitForm):
901
902 2018-08-31  Chris Dumez  <cdumez@apple.com>
903
904         Assertion hit in ~CompletionHandler() from ~WebFrame()
905         https://bugs.webkit.org/show_bug.cgi?id=189199
906         <rdar://problem/42657233>
907
908         Reviewed by Youenn Fablet.
909
910         * WebCoreSupport/WebFrameLoaderClient.cpp:
911         (WebFrameLoaderClient::dispatchWillSubmitForm):
912         * WebCoreSupport/WebFrameLoaderClient.h:
913
914 2018-08-31  Frederic Wang  <fwang@igalia.com>
915
916         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
917         https://bugs.webkit.org/show_bug.cgi?id=182053
918
919         Reviewed by Simon Fraser.
920
921         Add developer flag to use standard behavior for scrolling* attributes.
922
923         * Interfaces/IWebPreferencesPrivate.idl:
924         * WebPreferenceKeysPrivate.h:
925         * WebPreferences.cpp:
926         (WebPreferences::initializeDefaultSettings):
927         (WebPreferences::CSSOMViewScrollingAPIEnabled):
928         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
929         * WebPreferences.h:
930         * WebView.cpp:
931         (WebView::notifyPreferencesChanged):
932
933 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
934
935         [CMake] Replace AVFoundationSupport.py using CMake
936         https://bugs.webkit.org/show_bug.cgi?id=182891
937
938         Reviewed by Per Arne Vollan.
939
940         Remove references to the config.h contained in WebCore as it should
941         not be accessible from outside of WebCore.
942
943         * WebKitPrefix.h:
944
945 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
946
947         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
948         https://bugs.webkit.org/show_bug.cgi?id=188496
949         <rdar://problem/43216836>
950
951         Reviewed by Tim Horton.
952
953         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
954         header directly.
955
956         * WebCoreSupport/WebDragClient.cpp:
957
958 2018-08-17  Alex Christensen  <achristensen@webkit.org>
959
960         Add some plumbing for safe browsing
961         https://bugs.webkit.org/show_bug.cgi?id=188709
962
963         Reviewed by Tim Horton.
964
965         * WebCoreSupport/WebFrameLoaderClient.cpp:
966         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
967         * WebCoreSupport/WebFrameLoaderClient.h:
968
969 2018-08-02  David Fenton  <david_fenton@apple.com>
970
971         Unreviewed, rolling out r234489.
972
973         Caused 50+ crashes and 60+ API failures on iOS
974
975         Reverted changeset:
976
977         "[WTF] Rename String::format to String::deprecatedFormat"
978         https://bugs.webkit.org/show_bug.cgi?id=188191
979         https://trac.webkit.org/changeset/234489
980
981 2018-08-01  Tomas Popela  <tpopela@redhat.com>
982
983         [WTF] Rename String::format to String::deprecatedFormat
984         https://bugs.webkit.org/show_bug.cgi?id=188191
985
986         Reviewed by Darin Adler.
987
988         It should be replaced with string concatenation.
989
990         * FullscreenVideoController.cpp:
991         (timeToString):
992         * WebView.cpp:
993         (webKitVersionString):
994
995 2018-07-30  Rob Buis  <rbuis@igalia.com>
996
997         https://bugs.webkit.org/show_bug.cgi?id=188137
998         Merge PlatformCookieJar functions into NetworkStorageSession
999
1000         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1001
1002         Reviewed by Alex Christensen.
1003
1004         * WebCoreSupport/WebPlatformStrategies.cpp:
1005         (WebPlatformStrategies::cookiesForDOM):
1006         (WebPlatformStrategies::setCookiesFromDOM):
1007         (WebPlatformStrategies::cookiesEnabled):
1008         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1009         (WebPlatformStrategies::getRawCookies):
1010         (WebPlatformStrategies::deleteCookie):
1011         * WebPreferences.cpp:
1012         (WebPreferences::clearNetworkLoaderSession):
1013
1014 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
1015
1016         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
1017         https://bugs.webkit.org/show_bug.cgi?id=187963
1018
1019         Reviewed by Alex Christensen.
1020
1021         * Plugins/PluginPackageWin.cpp:
1022         (WebCore::PluginPackage::fetchInfo):
1023         Update split/splitAllowingEmptyEntries usage.
1024
1025 2018-07-18  Antoine Quint  <graouts@apple.com>
1026
1027         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
1028         https://bugs.webkit.org/show_bug.cgi?id=187722
1029
1030         Reviewed by Myles Maxfield.
1031
1032         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
1033
1034         * DOMCoreClasses.cpp:
1035         (DOMElement::font):
1036
1037 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1038
1039         Disable cross-origin-window-policy by default
1040         https://bugs.webkit.org/show_bug.cgi?id=187509
1041
1042         Reviewed by Chris Dumez.
1043
1044         * WebPreferences.cpp:
1045         (WebPreferences::initializeDefaultSettings):
1046
1047 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1048
1049         [WTF] Add user-defined literal for ASCIILiteral
1050         https://bugs.webkit.org/show_bug.cgi?id=186839
1051
1052         Reviewed by Darin Adler.
1053
1054         * Plugins/PluginStream.cpp:
1055         (WebCore::PluginStream::startStream):
1056         * WebCoreSupport/WebContextMenuClient.cpp:
1057         (WebContextMenuClient::searchWithGoogle):
1058
1059 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1060
1061         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
1062         https://bugs.webkit.org/show_bug.cgi?id=186623
1063
1064         Reviewed by Youenn Fablet.
1065
1066         * WebCoreSupport/WebPluginInfoProvider.cpp:
1067         (WebPluginInfoProvider::pluginInfo):
1068         (WebPluginInfoProvider::webVisiblePluginInfo):
1069         * WebCoreSupport/WebPluginInfoProvider.h:
1070
1071 2018-06-13  Chris Dumez  <cdumez@apple.com>
1072
1073         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1074         https://bugs.webkit.org/show_bug.cgi?id=186545
1075
1076         Reviewed by Brady Eidson.
1077
1078         Update client delegate now that parameter type has changed.
1079
1080         * WebCoreSupport/WebFrameLoaderClient.cpp:
1081         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1082         * WebCoreSupport/WebFrameLoaderClient.h:
1083
1084 2018-06-11  Chris Dumez  <cdumez@apple.com>
1085
1086         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
1087         https://bugs.webkit.org/show_bug.cgi?id=186441
1088
1089         Reviewed by Brady Eidson.
1090
1091         Rename existing flag to something a bit more generic, now that it is used for
1092         more things than bypassing the navigation policy check.
1093
1094         * WebView.cpp:
1095         (WebView::goToBackForwardItem):
1096         (WebView::loadBackForwardListFromOtherView):
1097
1098 2018-06-04  Chris Dumez  <cdumez@apple.com>
1099
1100         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
1101         https://bugs.webkit.org/show_bug.cgi?id=186287
1102         <rdar://problem/40783352>
1103
1104         Reviewed by Youenn Fablet.
1105
1106         * Interfaces/IWebPreferencesPrivate.idl:
1107         * WebPreferenceKeysPrivate.h:
1108         * WebPreferences.cpp:
1109         (WebPreferences::initializeDefaultSettings):
1110         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1111         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1112         * WebPreferences.h:
1113         * WebView.cpp:
1114         (WebView::notifyPreferencesChanged):
1115
1116 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1117
1118         [JSC] Pass VM& parameter as much as possible
1119         https://bugs.webkit.org/show_bug.cgi?id=186085
1120
1121         Reviewed by Saam Barati.
1122
1123         * Plugins/PluginPackage.cpp:
1124         (WebCore::NPN_Invoke):
1125
1126 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1127
1128         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
1129         https://bugs.webkit.org/show_bug.cgi?id=186125
1130
1131         Unreviewed build fix
1132
1133         * WebActionPropertyBag.cpp:
1134         (WebActionPropertyBag::Read):
1135         (findMouseEvent): Deleted.
1136
1137 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1138
1139         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
1140         https://bugs.webkit.org/show_bug.cgi?id=186027
1141
1142         Unreviewed build fix
1143
1144         * WebMutableURLRequest.cpp:
1145         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
1146         (WebMutableURLRequest::setClientCertificate):
1147
1148 2018-05-25  Chris Dumez  <cdumez@apple.com>
1149
1150         Minor ApplicationCacheStorage clean up
1151         https://bugs.webkit.org/show_bug.cgi?id=185984
1152
1153         Reviewed by Youenn Fablet.
1154
1155         * WebApplicationCache.cpp:
1156         (WebApplicationCache::originsWithCache):
1157
1158 2018-05-24  Chris Dumez  <cdumez@apple.com>
1159
1160         Reduce copying of FontCascadeDescription objects by moving them around
1161         https://bugs.webkit.org/show_bug.cgi?id=185963
1162
1163         Reviewed by Simon Fraser.
1164
1165         Reduce copying of FontCascadeDescription objects by moving them around when possible.
1166
1167         * FullscreenVideoController.cpp:
1168         (FullscreenVideoController::draw):
1169
1170 2018-05-15  Antoine Quint  <graouts@apple.com>
1171
1172         [Web Animations] Expose Web Animations CSS integration as an experimental feature
1173         https://bugs.webkit.org/show_bug.cgi?id=185647
1174
1175         Reviewed by Dean Jackson.
1176
1177         Rename the Web Animations CSS integration flag.
1178
1179         * Interfaces/IWebPreferencesPrivate.idl:
1180         * WebPreferenceKeysPrivate.h:
1181         * WebPreferences.cpp:
1182         (WebPreferences::initializeDefaultSettings):
1183         (WebPreferences::webAnimationsCSSIntegrationEnabled):
1184         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
1185         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1186         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1187         * WebPreferences.h:
1188         * WebView.cpp:
1189         (WebView::notifyPreferencesChanged):
1190
1191 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1192
1193         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
1194         https://bugs.webkit.org/show_bug.cgi?id=185505
1195
1196         Unreviewed serious crash fix
1197
1198         Windows port crashes soon since Bug 184996.
1199
1200         * WebPreferences.cpp:
1201         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
1202         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
1203
1204 2018-05-07  Daniel Bates  <dabates@apple.com>
1205
1206         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
1207         https://bugs.webkit.org/show_bug.cgi?id=185170
1208
1209         Reviewed by Per Arne Vollan.
1210
1211         * WebCache.cpp:
1212         (WebCache::empty):
1213
1214 2018-04-27  Chris Dumez  <cdumez@apple.com>
1215
1216         Use WindowProxy instead of DOMWindow in our IDL
1217         https://bugs.webkit.org/show_bug.cgi?id=185022
1218
1219         Reviewed by Sam Weinig.
1220
1221         * DOMCoreClasses.cpp:
1222         (DOMDocument::getComputedStyle):
1223
1224 2018-04-23  Daniel Bates  <dabates@apple.com>
1225
1226         Implement Same-Site cookies
1227         https://bugs.webkit.org/show_bug.cgi?id=159464
1228         <rdar://problem/27196358>
1229
1230         Reviewed by Brent Fulgham.
1231
1232         Pass the Same-Site info through the strategy.
1233
1234         * WebCoreSupport/WebPlatformStrategies.cpp:
1235         (WebPlatformStrategies::cookiesForDOM):
1236         (WebPlatformStrategies::setCookiesFromDOM):
1237         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1238         (WebPlatformStrategies::getRawCookies):
1239         * WebCoreSupport/WebPlatformStrategies.h:
1240
1241 2018-04-23  Daniel Bates  <dabates@apple.com>
1242
1243         Implement Same-Site cookies
1244         https://bugs.webkit.org/show_bug.cgi?id=159464
1245         <rdar://problem/27196358>
1246
1247         Reviewed by Brent Fulgham.
1248
1249         Pass the Same-Site info through the strategy.
1250
1251         * WebCoreSupport/WebPlatformStrategies.cpp:
1252         (WebPlatformStrategies::cookiesForDOM):
1253         (WebPlatformStrategies::setCookiesFromDOM):
1254         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1255         (WebPlatformStrategies::getRawCookies):
1256         * WebCoreSupport/WebPlatformStrategies.h:
1257
1258 2018-04-20  Youenn Fablet  <youenn@apple.com>
1259
1260         Make PluginData cache its web visible plugins
1261         https://bugs.webkit.org/show_bug.cgi?id=184421
1262
1263         Reviewed by Chris Dumez.
1264
1265         * WebCoreSupport/WebPluginInfoProvider.cpp:
1266         (WebPluginInfoProvider::pluginInfo):
1267         (WebPluginInfoProvider::webVisiblePluginInfo):
1268         * WebCoreSupport/WebPluginInfoProvider.h:
1269
1270 2018-04-19  Chris Dumez  <cdumez@apple.com>
1271
1272         Rename JSDOMWindowProxy to JSWindowProxy
1273         https://bugs.webkit.org/show_bug.cgi?id=184797
1274
1275         Reviewed by Sam Weinig.
1276
1277         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
1278
1279         * WebFrame.cpp:
1280         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
1281
1282 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
1283
1284         Unreviewed rollout of r230632. Regression in memory usage.
1285
1286         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
1287
1288         * WebPreferences.cpp:
1289         (WebPreferences::initializeDefaultSettings):
1290
1291 2018-04-17  Chris Dumez  <cdumez@apple.com>
1292
1293         Unreviewed attempt to fix the Windows build after r230721
1294
1295         * WebCoreSupport/WebFrameLoaderClient.cpp:
1296         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1297
1298 2018-04-17  Chris Dumez  <cdumez@apple.com>
1299
1300         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
1301         https://bugs.webkit.org/show_bug.cgi?id=184678
1302         <rdar://problem/39422122>
1303
1304         Reviewed by Alex Christensen.
1305
1306         Add new parameter to dispatchDecidePolicyForNavigationAction.
1307
1308         * WebCoreSupport/WebFrameLoaderClient.cpp:
1309         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1310         * WebCoreSupport/WebFrameLoaderClient.h:
1311
1312 2018-04-12  Antoine Quint  <graouts@apple.com>
1313
1314         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
1315         https://bugs.webkit.org/show_bug.cgi?id=184569
1316         <rdar://problem/38671301>
1317
1318         Reviewed by Jon Lee.
1319
1320         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
1321
1322         * WebPreferences.cpp:
1323
1324 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1325
1326         [WTF] Remove StaticLock
1327         https://bugs.webkit.org/show_bug.cgi?id=184332
1328
1329         Reviewed by Mark Lam.
1330
1331         * WebKitQuartzCoreAdditions/CAView.cpp:
1332         (WKQCA::CAView::releaseAllD3DResources):
1333         * WebLocalizableStrings.cpp:
1334
1335 2018-04-03  Chris Dumez  <cdumez@apple.com>
1336
1337         Drop MainFrame class
1338         https://bugs.webkit.org/show_bug.cgi?id=184191
1339
1340         Reviewed by Darin Adler.
1341
1342         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
1343         relationship between the Page and the MainFrame.
1344
1345         This is ground work for introducing LocalFrame / RemoteFrame concepts.
1346
1347         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1348         * WebCoreSupport/WebContextMenuClient.cpp:
1349         * WebCoreSupport/WebDragClient.cpp:
1350         * WebDropSource.cpp:
1351         * WebFrame.cpp:
1352         * WebView.cpp:
1353
1354 2018-03-26  Chris Dumez  <cdumez@apple.com>
1355
1356         Use SecurityOriginData more consistently in Service Worker code
1357         https://bugs.webkit.org/show_bug.cgi?id=183969
1358
1359         Reviewed by Darin Adler.
1360
1361         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
1362
1363         * WebDatabaseManager.cpp:
1364         (WebDatabaseManager::databasesWithOrigin):
1365         (WebDatabaseManager::deleteOrigin):
1366         (WebDatabaseManager::deleteDatabase):
1367         (WebDatabaseManager::setQuota):
1368         * WebSecurityOrigin.cpp:
1369         (WebSecurityOrigin::usage):
1370         (WebSecurityOrigin::quota):
1371         (WebSecurityOrigin::setQuota):
1372
1373 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
1374
1375         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
1376         https://bugs.webkit.org/show_bug.cgi?id=183911
1377         <rdar://problem/38762306>
1378
1379         Reviewed by Youenn Fablet.
1380
1381         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
1382
1383         * WebView.cpp:
1384         (WebView::WebView):
1385
1386 2018-03-25  Commit Queue  <commit-queue@webkit.org>
1387
1388         Unreviewed, rolling out r229954.
1389         https://bugs.webkit.org/show_bug.cgi?id=184000
1390
1391         Caused many layout tests to crash on Apple High Sierra,
1392         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
1393         by dydz on #webkit).
1394
1395         Reverted changeset:
1396
1397         "Use SecurityOriginData more consistently in Service Worker
1398         code"
1399         https://bugs.webkit.org/show_bug.cgi?id=183969
1400         https://trac.webkit.org/changeset/229954
1401
1402 2018-03-24  Chris Dumez  <cdumez@apple.com>
1403
1404         Use SecurityOriginData more consistently in Service Worker code
1405         https://bugs.webkit.org/show_bug.cgi?id=183969
1406
1407         Reviewed by Darin Adler.
1408
1409         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
1410
1411         * WebDatabaseManager.cpp:
1412         (WebDatabaseManager::databasesWithOrigin):
1413         (WebDatabaseManager::deleteOrigin):
1414         (WebDatabaseManager::deleteDatabase):
1415         (WebDatabaseManager::setQuota):
1416         * WebSecurityOrigin.cpp:
1417         (WebSecurityOrigin::usage):
1418         (WebSecurityOrigin::quota):
1419         (WebSecurityOrigin::setQuota):
1420
1421 2018-03-23  Chris Dumez  <cdumez@apple.com>
1422
1423         Unreviewed attempt to fix Windows build after r229926.
1424
1425         * WebView.cpp:
1426
1427 2018-03-23  Brady Eidson  <beidson@apple.com>
1428
1429         Go to back/forward list items after a process-swapped navigation.
1430         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
1431
1432         Reviewed by Andy Estes.
1433
1434         * WebView.cpp:
1435         (WebView::goToBackForwardItem):
1436         (WebView::loadBackForwardListFromOtherView):
1437
1438 2018-03-23  Miguel Gomez  <magomez@igalia.com>
1439
1440         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
1441         https://bugs.webkit.org/show_bug.cgi?id=183892
1442
1443         Remove the UpdateContentsFlag parameter as it's not used anymore.
1444
1445         Reviewed by Žan Doberšek.
1446
1447         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1448         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
1449
1450 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
1451
1452         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
1453         https://bugs.webkit.org/show_bug.cgi?id=183335
1454
1455         Reviewed by Alex Christensen.
1456
1457         * Plugins/PluginDatabaseWin.cpp:
1458         * Plugins/PluginMessageThrottlerWin.cpp:
1459         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
1460         * Plugins/PluginPackageWin.cpp:
1461         (WebCore::PluginPackage::load):
1462         * Plugins/PluginView.h:
1463         * Plugins/PluginViewWin.cpp:
1464         * Plugins/npapi.cpp:
1465         * WebCoreSupport/WebFrameLoaderClient.cpp:
1466         (WebFrameLoaderClient::createPlugin):
1467         (WebFrameLoaderClient::createJavaAppletWidget):
1468         * WebView.cpp:
1469         (WebView::WebViewWndProc):
1470
1471 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
1472
1473         [Win] Layout Test fast/html/menuitem-element.html is failing.
1474         https://bugs.webkit.org/show_bug.cgi?id=179299
1475
1476         Reviewed by Per Arne Vollan.
1477
1478         * Interfaces/IWebPreferencesPrivate.idl:
1479         * WebPreferenceKeysPrivate.h:
1480         * WebPreferences.cpp:
1481         (WebPreferences::menuItemElementEnabled):
1482         (WebPreferences::setMenuItemElementEnabled):
1483         * WebPreferences.h:
1484         * WebView.cpp:
1485         (WebView::notifyPreferencesChanged):
1486         Add private web preference "menuItemElementEnabled".
1487
1488 2018-03-12  Antoine Quint  <graouts@apple.com>
1489
1490         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
1491         https://bugs.webkit.org/show_bug.cgi?id=183504
1492         <rdar://problem/38372965>
1493
1494         Reviewed by Dean Jackson and Jon Lee.
1495
1496         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
1497         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
1498
1499         * Interfaces/IWebPreferencesPrivate.idl:
1500         * WebPreferences.cpp:
1501         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
1502         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
1503         * WebPreferenceKeysPrivate.h
1504         * WebPreferences.h:
1505         * WebView.cpp:
1506         (WebView::notifyPreferencesChanged):
1507
1508 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1509
1510         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
1511         https://bugs.webkit.org/show_bug.cgi?id=183429
1512
1513         Reviewed by Mark Lam.
1514
1515         * WebFrame.cpp:
1516         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
1517
1518 2018-03-08  Tim Horton  <timothy_horton@apple.com>
1519
1520         Stop linking ApplicationServices directly
1521         https://bugs.webkit.org/show_bug.cgi?id=182867
1522         <rdar://problem/38252142>
1523
1524         Reviewed by Alex Christensen.
1525
1526         The frameworks that we use that live inside ApplicationServices
1527         have mostly moved out, so import them directly.
1528
1529         * FullscreenVideoController.cpp:
1530
1531 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1532
1533         Fix std::make_unique / new[] using system malloc
1534         https://bugs.webkit.org/show_bug.cgi?id=182975
1535
1536         Reviewed by JF Bastien.
1537
1538         Use Vector instead.
1539
1540         * MarshallingHelpers.cpp:
1541         (MarshallingHelpers::safeArrayToStringArray):
1542         (MarshallingHelpers::safeArrayToIntArray):
1543         * Plugins/PluginPackageWin.cpp:
1544         (WebCore::PluginPackage::fetchInfo):
1545         * WebPreferences.cpp:
1546         (WebPreferences::copyWebKitPreferencesToCFPreferences):
1547         * WebView.cpp:
1548         (WebView::onMenuCommand):
1549
1550 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1551
1552         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
1553         https://bugs.webkit.org/show_bug.cgi?id=183312
1554
1555         Reviewed by Mark Lam.
1556
1557         Remove wtf/CurrentTime.h include pragma.
1558
1559         * WebDownload.cpp:
1560         * WebDownloadCFNet.cpp:
1561         * WebDropSource.cpp:
1562
1563 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1564
1565         Remove monotonicallyIncreasingTime
1566         https://bugs.webkit.org/show_bug.cgi?id=182911
1567
1568         Reviewed by Michael Catanzaro.
1569
1570         * FullscreenVideoController.cpp:
1571         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
1572         * Plugins/PluginMessageThrottlerWin.cpp:
1573         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
1574         (WebCore::PluginMessageThrottlerWin::appendMessage):
1575         * Plugins/PluginMessageThrottlerWin.h:
1576         * WebView.cpp:
1577         (WebView::notifyAnimationStarted):
1578         * WebView.h:
1579
1580 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
1581
1582         [Win][DRT] Implement setSpatialNavigationEnabled.
1583         https://bugs.webkit.org/show_bug.cgi?id=183166
1584
1585         Reviewed by Per Arne Vollan.
1586
1587         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
1588
1589         * Interfaces/IWebPreferencesPrivate.idl:
1590         * WebPreferenceKeysPrivate.h:
1591         * WebPreferences.cpp:
1592         (WebPreferences::initializeDefaultSettings):
1593         (WebPreferences::spatialNavigationEnabled):
1594         (WebPreferences::setSpatialNavigationEnabled):
1595         * WebPreferences.h:
1596         * WebView.cpp:
1597         (WebView::notifyPreferencesChanged):
1598
1599 2018-02-28  Alex Christensen  <achristensen@webkit.org>
1600
1601         Reduce use of NetworkingContext in WebKit
1602         https://bugs.webkit.org/show_bug.cgi?id=183213
1603
1604         Reviewed by Brady Eidson.
1605
1606         * Plugins/PluginView.cpp:
1607         (WebCore::PluginView::getValueForURL):
1608
1609 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
1610
1611         Fix WebCore includes within WebKitLegacy
1612         https://bugs.webkit.org/show_bug.cgi?id=183147
1613
1614         Reviewed by Tim Horton.
1615
1616         * Plugins/PluginDatabase.cpp:
1617         * Plugins/PluginDatabaseWin.cpp:
1618         * Plugins/PluginDebug.cpp:
1619         * Plugins/PluginDebug.h:
1620         * Plugins/PluginMainThreadScheduler.cpp:
1621         * Plugins/PluginMessageThrottlerWin.cpp:
1622         * Plugins/PluginMessageThrottlerWin.h:
1623         * Plugins/PluginPackage.cpp:
1624         * Plugins/PluginPackage.h:
1625         * Plugins/PluginPackageWin.cpp:
1626         * Plugins/PluginStream.cpp:
1627         * Plugins/PluginStream.h:
1628         * Plugins/PluginView.cpp:
1629         * Plugins/PluginView.h:
1630         * Plugins/PluginViewWin.cpp:
1631         * Plugins/npapi.cpp:
1632         * WebCoreSupport/WebChromeClient.cpp:
1633         * WebCoreSupport/WebContextMenuClient.cpp:
1634         * WebCoreSupport/WebFrameLoaderClient.cpp:
1635         * WebCoreSupport/WebInspectorClient.cpp:
1636         * WebCoreSupport/WebPlatformStrategies.cpp:
1637         * WebFrame.cpp:
1638         * WebKitMessageLoop.cpp:
1639         * WebView.cpp:
1640         * storage/WebDatabaseProvider.cpp:
1641
1642 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1643
1644         Remove currentTime() / currentTimeMS()
1645         https://bugs.webkit.org/show_bug.cgi?id=183052
1646
1647         Reviewed by Mark Lam.
1648
1649         * WebCoreSupport/WebFrameLoaderClient.cpp:
1650         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1651         * WebCoreSupport/WebFrameLoaderClient.h:
1652         * WebDownload.h:
1653         * WebDownloadCFNet.cpp:
1654         (WebDownload::didStart):
1655         (WebDownload::didReceiveData):
1656         (WebDownload::didFinish):
1657
1658 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
1659
1660         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
1661         https://bugs.webkit.org/show_bug.cgi?id=182883
1662
1663         Reviewed by Per Arne Vollan.
1664
1665         * WebKitPrefix.h:
1666
1667 2018-02-16  Dean Jackson  <dino@apple.com>
1668
1669         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
1670         https://bugs.webkit.org/show_bug.cgi?id=182894
1671
1672         Reviewed by Tim Horton.
1673
1674         Rename OPENGL_ES_2 to OPENGL_ES.
1675
1676         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1677
1678 2018-02-16  Youenn Fablet  <youenn@apple.com>
1679
1680         Allow specifying which plug-ins are supported
1681         https://bugs.webkit.org/show_bug.cgi?id=182748
1682
1683         Reviewed by Chris Dumez.
1684
1685         * WebCoreSupport/WebPluginInfoProvider.cpp:
1686         (WebPluginInfoProvider::getPluginInfo):
1687         * WebCoreSupport/WebPluginInfoProvider.h:
1688
1689 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
1690
1691         WebCore headers should not be included relatively within dependent projects
1692         https://bugs.webkit.org/show_bug.cgi?id=182805
1693
1694         Reviewed by Chris Dumez.
1695
1696         * FullscreenVideoController.h:
1697
1698 2018-02-13  Commit Queue  <commit-queue@webkit.org>
1699
1700         Unreviewed, rolling out r228431.
1701         https://bugs.webkit.org/show_bug.cgi?id=182766
1702
1703         Regressed CMake build stability (Requested by dolmstead on
1704         #webkit).
1705
1706         Reverted changeset:
1707
1708         "[CMake] Make WebCore headers copies"
1709         https://bugs.webkit.org/show_bug.cgi?id=182512
1710         https://trac.webkit.org/changeset/228431
1711
1712 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
1713
1714         [CMake] Make WebCore headers copies
1715         https://bugs.webkit.org/show_bug.cgi?id=182512
1716
1717         Reviewed by Keith Miller.
1718
1719         * FullscreenVideoController.h:
1720         * Plugins/PluginDatabase.cpp:
1721         * Plugins/PluginDatabaseWin.cpp:
1722         * Plugins/PluginDebug.cpp:
1723         * Plugins/PluginMainThreadScheduler.cpp:
1724         * Plugins/PluginMessageThrottlerWin.cpp:
1725         * Plugins/PluginPackage.cpp:
1726         * Plugins/PluginPackageWin.cpp:
1727         * Plugins/PluginStream.cpp:
1728         * Plugins/PluginView.cpp:
1729         * Plugins/PluginViewWin.cpp:
1730         * Plugins/npapi.cpp:
1731         * WebKitMessageLoop.cpp:
1732         * WebKitPrefix.h:
1733         * storage/WebDatabaseProvider.cpp:
1734
1735 2018-01-13  Darin Adler  <darin@apple.com>
1736
1737         Event improvements
1738         https://bugs.webkit.org/show_bug.cgi?id=179591
1739
1740         Reviewed by Chris Dumez.
1741
1742         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
1743         * WebFrame.cpp: Ditto.
1744
1745         * WebScriptWorld.cpp:
1746         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
1747
1748         * WebView.cpp: Removed include of ScriptValue.h.
1749         (WebView::handleEditingKeyboardEvent): Updated for name change from
1750         keyEvent to underlyingPlatformEvent.
1751
1752 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1753
1754         Remove WebCore/ForwardingHeaders directory
1755         https://bugs.webkit.org/show_bug.cgi?id=182347
1756
1757         Reviewed by Keith Miller.
1758
1759         * Plugins/PluginView.cpp:
1760         * Plugins/PluginViewWin.cpp:
1761         * WebCoreSupport/WebInspectorClient.cpp:
1762         * WebCoreSupport/WebInspectorClient.h:
1763         * WebFrame.cpp:
1764         * WebJavaScriptCollector.cpp:
1765         * WebView.cpp:
1766
1767 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1768
1769         Unreviewed, another attempt to fix the Windows build after r227479.
1770
1771         * WebFrame.cpp:
1772         (WebFrame::elementWithName):
1773
1774 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1775
1776         Unreviewed, try to fix the Windows build after r227479.
1777
1778         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
1779
1780         * WebFrame.cpp:
1781         (WebFrame::elementWithName):
1782         (WebFrame::controlsInForm):
1783
1784 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
1785
1786         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
1787         https://bugs.webkit.org/show_bug.cgi?id=181859
1788         <rdar://problem/36659886>
1789
1790         Reviewed by Alex Christensen.
1791         
1792         Use local include patch.
1793
1794         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
1795         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
1796         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
1797
1798 2018-01-17  Youenn Fablet  <youenn@apple.com>
1799
1800         Put fetch Request.keepalive behind a runtime flag
1801         https://bugs.webkit.org/show_bug.cgi?id=181592
1802
1803         Reviewed by Chris Dumez.
1804
1805         * WebPreferences.cpp:
1806         (WebPreferences::fetchAPIKeepAliveEnabled):
1807         (WebPreferences::setFetchAPIKeepAliveEnabled):
1808         * WebPreferences.h:
1809         * WebView.cpp:
1810         (WebView::notifyPreferencesChanged):
1811
1812 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1813
1814         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1815         https://bugs.webkit.org/show_bug.cgi?id=181637
1816         <rdar://problem/36508471>
1817
1818         Reviewed by Tim Horton.
1819
1820         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1821
1822         * WebCoreSupport/WebEditorClient.cpp:
1823         (WebEditorClient::replacementURLForResource):
1824         * WebCoreSupport/WebEditorClient.h:
1825
1826 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1827
1828         Remove std::chrono completely
1829         https://bugs.webkit.org/show_bug.cgi?id=181186
1830
1831         Reviewed by Alex Christensen.
1832
1833         * Plugins/PluginStream.cpp:
1834         (WebCore::lastModifiedDateMS):
1835
1836 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
1837
1838         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
1839         https://bugs.webkit.org/show_bug.cgi?id=181173
1840
1841         Reviewed by Alex Christensen.
1842
1843         * WebNodeHighlight.cpp:
1844         (WebNodeHighlight::update): Scale the GraphicsContext.
1845
1846 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1847
1848         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
1849         https://bugs.webkit.org/show_bug.cgi?id=181160
1850
1851         Reviewed by Myles C. Maxfield.
1852
1853         * Plugins/PluginView.cpp:
1854         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
1855
1856 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1857
1858         Enable picture-in-picture from inline element on suspend.
1859         https://bugs.webkit.org/show_bug.cgi?id=180942
1860         rdar://problem/34745234
1861
1862         Reviewed by Jer Noble.
1863
1864         Update signature of enterVideoFullscreenForVideoElement.
1865
1866         * WebCoreSupport/WebChromeClient.cpp:
1867         (WebChromeClient::enterVideoFullscreenForVideoElement):
1868         * WebCoreSupport/WebChromeClient.h:
1869
1870 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1871
1872         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
1873         https://bugs.webkit.org/show_bug.cgi?id=180926
1874
1875         Reviewed by Tim Horton.
1876
1877         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
1878         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
1879
1880         * WebCoreSupport/WebFrameLoaderClient.cpp:
1881         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
1882         (WebFrameLoaderClient::pageID const): Ditto.
1883
1884 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1885
1886         Remove unnecessary boolean result of start() functions
1887         https://bugs.webkit.org/show_bug.cgi?id=180856
1888
1889         Reviewed by Darin Adler.
1890
1891         It always returns true.
1892
1893         * WebDownloadCurl.cpp:
1894         (WebDownload::start):
1895
1896 2017-12-14  John Wilander  <wilander@apple.com>
1897
1898         Storage Access API: Implement frame-specific access in the document.cookie layer
1899         https://bugs.webkit.org/show_bug.cgi?id=180682
1900         <rdar://problem/35982257>
1901
1902         Reviewed by Alex Christensen.
1903
1904         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1905         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1906         CookiesStrategy::getRawCookies() now take optional parameters for
1907         frameID and pageID to allow frame-specific scoping of cookies.
1908
1909         This change makes the return values of FrameLoaderClient::frameID()
1910         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1911         WebCore can call those getters and get the right return values in
1912         WebKit and std:nullopt in WebKitLegacy.
1913
1914         * WebCoreSupport/WebFrameLoaderClient.cpp:
1915         (WebFrameLoaderClient::pageID const):
1916         (WebFrameLoaderClient::frameID const):
1917             Now return an optional.
1918         * WebCoreSupport/WebFrameLoaderClient.h:
1919         * WebCoreSupport/WebPlatformStrategies.cpp:
1920         (WebPlatformStrategies::cookiesForDOM):
1921         (WebPlatformStrategies::setCookiesFromDOM):
1922         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1923         (WebPlatformStrategies::getRawCookies):
1924         * WebCoreSupport/WebPlatformStrategies.h:
1925
1926 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
1927
1928         [WTF] Thread::create should have Thread::tryCreate
1929         https://bugs.webkit.org/show_bug.cgi?id=180333
1930
1931         Reviewed by Darin Adler.
1932
1933         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
1934         (WKQCA::CVDisplayLink::start):
1935
1936 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1937
1938         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
1939         https://bugs.webkit.org/show_bug.cgi?id=180572
1940
1941         Reviewed by Mark Lam.
1942
1943         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
1944         Also we use Lock instead of Mutex.
1945
1946         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
1947         (WKQCA::CAD3DRenderer::swapChain):
1948         (WKQCA::CAD3DRenderer::renderAndPresent):
1949         (WKQCA::CAD3DRenderer::renderToImage):
1950         (WKQCA::CAD3DRenderer::setDeviceIsLost):
1951         (WKQCA::CAD3DRenderer::renderInternal):
1952         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
1953         * WebKitQuartzCoreAdditions/CAView.cpp:
1954         (WKQCA::CAView::Handle::create):
1955         Return Ref<Handle> instead of RefPtr<>.
1956
1957         (WKQCA::CAView::Handle::lock):
1958         (WKQCA::CAView::Handle::view const):
1959         (WKQCA::CAView::Handle::clear):
1960         (WKQCA::views):
1961         (WKQCA::viewsNeedingUpdate):
1962         (WKQCA::CAView::releaseAllD3DResources):
1963         (WKQCA::CAView::CAView):
1964         (WKQCA::CAView::~CAView):
1965         (WKQCA::CAView::setLayer):
1966         (WKQCA::CAView::update):
1967         (WKQCA::CAView::drawToWindow):
1968         (WKQCA::CAView::drawToWindowInternal):
1969         (WKQCA::CAView::drawToImage):
1970         (WKQCA::CAView::willDraw):
1971         (WKQCA::CAView::drawIntoDC):
1972         (WKQCA::CAView::setShouldInvertColors):
1973         (WKQCA::CAView::scheduleNextDraw):
1974         (WKQCA::CAView::displayLinkReachedCAMediaTime):
1975         (WKQCA::CAView::contextDidChange):
1976         (WKQCA::CAView::updateSoon):
1977         (WKQCA::CAView::updateViewsNow):
1978         (WKQCA::CAView::d3dDevice9):
1979         (WKQCA::CAView::Handle::mutex): Deleted.
1980         (WKQCA::globalStateMutex): Deleted.
1981         (): Deleted.
1982         * WebKitQuartzCoreAdditions/CAView.h:
1983
1984 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
1985
1986         Use StaticLock instead of NeverDestroyed<Lock>
1987         https://bugs.webkit.org/show_bug.cgi?id=180507
1988
1989         Reviewed by Saam Barati.
1990
1991         * WebLocalizableStrings.cpp:
1992         (findCachedString):
1993         (cacheString):
1994         (mainBundleLocStrings): Deleted.
1995         (frameworkLocStringsMutex): Deleted.
1996
1997 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
1998
1999         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
2000         https://bugs.webkit.org/show_bug.cgi?id=180431
2001         <rdar://problem/34531264>
2002
2003         Reviewed by Simon Fraser.
2004
2005         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
2006         'override' to make sure this doesn't break in the future.
2007
2008         * WebView.cpp:
2009         (WebView::notifyAnimationStarted):
2010         (WebView::paintContents):
2011         * WebView.h:
2012
2013 2017-11-23  Darin Adler  <darin@apple.com>
2014
2015         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2016         https://bugs.webkit.org/show_bug.cgi?id=179981
2017
2018         Reviewed by Sam Weinig.
2019
2020         * WebView.cpp:
2021         (WebView::searchFor): Use |= instead of | to build FindOptions.
2022         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
2023         (WebView::findString): Create FindOptions with |=; the old code just passed a
2024         WebKit FindOptions through without converting to WebCore::FindOptions.
2025
2026 2017-11-23  Darin Adler  <darin@apple.com>
2027
2028         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2029         https://bugs.webkit.org/show_bug.cgi?id=179907
2030
2031         Reviewed by Sam Weinig.
2032
2033         * Plugins/PluginDatabaseWin.cpp:
2034         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
2035         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
2036         * WebDownloadCFNet.cpp:
2037         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
2038
2039         * WebView.cpp:
2040         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
2041         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
2042         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
2043         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
2044         the code does not cause any change in behavior.
2045
2046 2017-11-22  Ali Juma  <ajuma@chromium.org>
2047
2048         Implement VisualViewport API attributes
2049         https://bugs.webkit.org/show_bug.cgi?id=179385
2050
2051         Reviewed by Frédéric Wang.
2052
2053         Add a VisualViewportAPI preference.
2054
2055         * Interfaces/IWebPreferencesPrivate.idl:
2056         * WebPreferenceKeysPrivate.h:
2057         * WebPreferences.cpp:
2058         (WebPreferences::initializeDefaultSettings):
2059         (WebPreferences::visualViewportAPIEnabled):
2060         (WebPreferences::setVisualViewportAPIEnabled):
2061         * WebPreferences.h:
2062         * WebView.cpp:
2063         (WebView::notifyPreferencesChanged):
2064
2065 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2066
2067         Unreviewed, rolling out r225093.
2068         https://bugs.webkit.org/show_bug.cgi?id=179938
2069
2070         Compilation failed on WinCairo 64-bit Release (Requested by
2071         fredw on #webkit).
2072
2073         Reverted changeset:
2074
2075         "Implement VisualViewport API attributes"
2076         https://bugs.webkit.org/show_bug.cgi?id=179385
2077         https://trac.webkit.org/changeset/225093
2078
2079 2017-11-21  Ali Juma  <ajuma@chromium.org>
2080
2081         Implement VisualViewport API attributes
2082         https://bugs.webkit.org/show_bug.cgi?id=179385
2083
2084         Reviewed by Frédéric Wang.
2085
2086         Add a VisualViewportAPI preference.
2087
2088         * Interfaces/IWebPreferencesPrivate.idl:
2089         * WebPreferenceKeysPrivate.h:
2090         * WebPreferences.cpp:
2091         (WebPreferences::initializeDefaultSettings):
2092         (WebPreferences::visualViewportAPIEnabled):
2093         (WebPreferences::setVisualViewportAPIEnabled):
2094         * WebPreferences.h:
2095         * WebView.cpp:
2096         (WebView::notifyPreferencesChanged):
2097
2098 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2099
2100         Clean up old URL parser remnants
2101         https://bugs.webkit.org/show_bug.cgi?id=179573
2102
2103         Reviewed by Darin Adler.
2104
2105         * WebCoreSupport/WebContextMenuClient.cpp:
2106         (WebContextMenuClient::searchWithGoogle):
2107         Use https if we do end up searching with google.
2108
2109 2017-11-12  Darin Adler  <darin@apple.com>
2110
2111         More is<> and downcast<>, less static_cast<>
2112         https://bugs.webkit.org/show_bug.cgi?id=179600
2113
2114         Reviewed by Chris Dumez.
2115
2116         * WebView.cpp:
2117         (WebView::handleEditingKeyboardEvent): Use downcast.
2118
2119 2017-11-09  Christopher Reid  <chris.reid@sony.com>
2120
2121         Use enum classes within FileSystem
2122         https://bugs.webkit.org/show_bug.cgi?id=175172
2123
2124         Reviewed by Darin Adler.
2125
2126         * Plugins/PluginDatabase.cpp:
2127
2128 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
2129
2130         [Win] Add WebKitQuartzCoreAdditions library.
2131         https://bugs.webkit.org/show_bug.cgi?id=179331
2132
2133         Reviewed by Alex Christensen.
2134
2135         * WebKitQuartzCoreAdditions: Added.
2136         * WebKitQuartzCoreAdditions/API: Added.
2137         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
2138         (toImage):
2139         (WKCACFImageGetWidth):
2140         (WKCACFImageGetHeight):
2141         (WKCACFImageCopyFileMapping):
2142         (WKCACFImageCreateWithImage):
2143         (WKCACFImageFinalize):
2144         (WKCACFImageCopyFormattingDescription):
2145         (WKCACFImageCopyDebugDescription):
2146         (WKCACFImageGetTypeID):
2147         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
2148         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
2149         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
2150         (toView):
2151         (toImpl):
2152         (WKCACFViewCreate):
2153         (WKCACFViewSetLayer):
2154         (WKCACFViewUpdate):
2155         (WKCACFViewFlushContext):
2156         (WKCACFViewInvalidateRects):
2157         (WKCACFViewCanDraw):
2158         (WKCACFViewDraw):
2159         (WKCACFViewCopyDrawnImage):
2160         (WKCACFViewDrawIntoDC):
2161         (contextDidChangeCallback):
2162         (WKCACFViewSetContextDidChangeCallback):
2163         (WKCACFViewGetLastCommitTime):
2164         (WKCACFViewSetContextUserData):
2165         (WKCACFViewGetContext):
2166         (WKCACFViewFinalize):
2167         (WKCACFViewCopyFormattingDescription):
2168         (WKCACFViewCopyDebugDescription):
2169         (WKCACFViewGetTypeID):
2170         (WKCACFViewSetShouldInvertColors):
2171         (WKCACFViewGetD3DDevice9):
2172         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
2173         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
2174         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
2175         (WKQCA::dllInstance):
2176         (DllMain):
2177         (WKCACFShutDown):
2178         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
2179         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
2180         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
2181         (WKQCA::d3d):
2182         (WKQCA::initialPresentationParameters):
2183         (WKQCA::CAD3DRenderer::shared):
2184         (WKQCA::CAD3DRenderer::CAD3DRenderer):
2185         (WKQCA::CAD3DRenderer::swapChain):
2186         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
2187         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
2188         (WKQCA::CAD3DRenderer::initialize):
2189         (WKQCA::D3DMatrixOrthoOffCenterRH):
2190         (WKQCA::prepareDevice):
2191         (WKQCA::updateBounds):
2192         (WKQCA::CAD3DRenderer::renderAndPresent):
2193         (WKQCA::CAD3DRenderer::renderToImage):
2194         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2195         (WKQCA::CAD3DRenderer::renderInternal):
2196         (WKQCA::CAD3DRenderer::postProcess):
2197         (WKQCA::CAD3DRenderer::resetD3DDevice):
2198         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
2199         (WKQCA::CAD3DRenderer::release):
2200         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
2201         (WKQCA::D3DPostProcessingContext::sceneTexture const):
2202         (WKQCA::D3DPostProcessingContext::overlayQuad const):
2203         (WKQCA::CAD3DRenderer::d3dDevice9 const):
2204         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
2205         (WKQCA::CAView::Handle::create):
2206         (WKQCA::CAView::Handle::~Handle):
2207         (WKQCA::CAView::Handle::mutex):
2208         (WKQCA::CAView::Handle::view const):
2209         (WKQCA::CAView::Handle::clear):
2210         (WKQCA::CAView::Handle::Handle):
2211         (WKQCA::globalStateMutex):
2212         (WKQCA::registerMessageWindowClass):
2213         (WKQCA::createMessageWindow):
2214         (WKQCA::CAView::releaseAllD3DResources):
2215         (WKQCA::CAView::CAView):
2216         (WKQCA::CAView::~CAView):
2217         (WKQCA::CAView::create):
2218         (WKQCA::CAView::setContextDidChangeCallback):
2219         (WKQCA::CAView::setLayer):
2220         (WKQCA::CAView::update):
2221         (WKQCA::CAView::invalidateRects):
2222         (WKQCA::CAView::drawToWindow):
2223         (WKQCA::CAView::drawToWindowInternal):
2224         (WKQCA::CAView::drawToImage):
2225         (WKQCA::CAView::willDraw):
2226         (WKQCA::CAView::didDraw):
2227         (WKQCA::CAView::drawIntoDC):
2228         (WKQCA::CAView::setShouldInvertColors):
2229         (WKQCA::CAView::scheduleNextDraw):
2230         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2231         (WKQCA::CAView::contextDidChangeCallback):
2232         (WKQCA::CAView::contextDidChange):
2233         (WKQCA::CAView::updateSoon):
2234         (WKQCA::CAView::updateViewsNow):
2235         (WKQCA::CAView::d3dDevice9):
2236         * WebKitQuartzCoreAdditions/CAView.h: Added.
2237         (WKQCA::CAView::context const):
2238         (WKQCA::CAView::canDraw const):
2239         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
2240         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
2241         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
2242         (WKQCA::CVDisplayLink::CVDisplayLink):
2243         (WKQCA::CVDisplayLink::~CVDisplayLink):
2244         (WKQCA::CVDisplayLink::create):
2245         (WKQCA::CVDisplayLink::start):
2246         (WKQCA::CVDisplayLink::stop):
2247         (WKQCA::CVDisplayLink::setPaused):
2248         (WKQCA::CVDisplayLink::runIOThread):
2249         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
2250         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
2251         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
2252         * WebKitQuartzCoreAdditions/Image.cpp: Added.
2253         (WKQCA::numBytesForSize):
2254         (WKQCA::Image::create):
2255         (WKQCA::Image::Image):
2256         (WKQCA::Image::~Image):
2257         (WKQCA::bitmapInfo):
2258         (WKQCA::Image::createDIB const):
2259         (WKQCA::Image::copyFileMapping):
2260         * WebKitQuartzCoreAdditions/Image.h: Added.
2261         (WKQCA::Image::size const):
2262         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
2263         (WKQCA::getBackBufferRectAsRenderTarget):
2264         (WKQCA::getSystemMemoryCopy):
2265         (WKQCA::copyRectToBitmap):
2266         (WKQCA::getImageCopy):
2267         (WKQCA::getBackBufferRectAsImage):
2268         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
2269         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
2270         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
2271         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
2272         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
2273
2274 2017-11-06  Christopher Reid  <chris.reid@sony.com>
2275
2276         Use enum classes within FileSystem
2277         https://bugs.webkit.org/show_bug.cgi?id=175172
2278
2279         Reviewed by Myles C. Maxfield.
2280
2281         * Plugins/PluginDatabase.cpp:
2282
2283 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
2284
2285         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
2286         https://bugs.webkit.org/show_bug.cgi?id=178333
2287
2288         Reviewed by Darin Adler.
2289
2290         * WebCoreSupport/WebFrameLoaderClient.cpp:
2291         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
2292
2293 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2294
2295         Use CompletionHandlers for redirects
2296         https://bugs.webkit.org/show_bug.cgi?id=179163
2297
2298         Reviewed by Tim Horton.
2299
2300         * Plugins/PluginStream.cpp:
2301         (WebCore::PluginStream::willSendRequest):
2302         * Plugins/PluginStream.h:
2303         (WebCore::PluginStreamClient::~PluginStreamClient):
2304         (WebCore::PluginStreamClient::streamDidFinishLoading):
2305         (WebCore::PluginStream::create):
2306         (WebCore::PluginStream::setLoadManually):
2307
2308 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2309
2310         Add a FileSystem namespace to FileSystem.cpp
2311         https://bugs.webkit.org/show_bug.cgi?id=179063
2312
2313         Reviewed by Darin Adler.
2314
2315         * Plugins/PluginDatabase.cpp:
2316         * Plugins/PluginPackage.cpp:
2317         * Plugins/PluginStream.cpp:
2318         * Plugins/PluginStream.h:
2319         * WebApplicationCache.cpp:
2320         * WebDatabaseManager.cpp:
2321         * WebDownloadCurl.cpp:
2322         * WebPreferences.cpp:
2323         * WebView.cpp:
2324
2325 2017-10-31  Alex Christensen  <achristensen@webkit.org>
2326
2327         Fix Windows build after r224260
2328
2329         * WebView.cpp:
2330         (WebView::gesture):
2331
2332 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2333
2334         [FrameView::layout cleanup] Move core layout logic to a separate class.
2335         https://bugs.webkit.org/show_bug.cgi?id=178771
2336         <rdar://problem/35166542>
2337
2338         Reviewed by Simon Fraser.
2339
2340         Move layout code out from FrameView to LayoutContext.
2341
2342         * WebFrame.cpp:
2343         (WebFrame::layout):
2344
2345 2017-10-26  Alex Christensen  <achristensen@webkit.org>
2346
2347         Fix Windows build
2348         https://bugs.webkit.org/show_bug.cgi?id=178892
2349
2350         * AccessibleBase.cpp:
2351         (MSAARole):
2352
2353 2017-10-26  Alex Christensen  <achristensen@webkit.org>
2354
2355         Fix Windows build
2356         https://bugs.webkit.org/show_bug.cgi?id=178892
2357
2358         * AccessibleBase.cpp:
2359         (AccessibleBase::state const):
2360         (MSAARole):
2361
2362 2017-10-25  Youenn Fablet  <youenn@apple.com>
2363
2364         Enable ServiceWorker to fetch resources
2365         https://bugs.webkit.org/show_bug.cgi?id=178673
2366
2367         Reviewed by Brady Eidson.
2368
2369         Added implementation to the new getters.
2370         They are noop in the context of WK1.
2371
2372         * WebCoreSupport/WebFrameLoaderClient.cpp:
2373         (WebFrameLoaderClient::pageID const):
2374         (WebFrameLoaderClient::frameID const):
2375         (WebFrameLoaderClient::sessionID const):
2376         * WebCoreSupport/WebFrameLoaderClient.h:
2377
2378 2017-10-20  Antoine Quint  <graouts@apple.com>
2379
2380         [Web Animations] Provide basic timeline and animation interfaces
2381         https://bugs.webkit.org/show_bug.cgi?id=178526
2382
2383         Reviewed by Dean Jackson.
2384
2385         Remove the WEB_ANIMATIONS compile-time flag.
2386
2387         * WebView.cpp:
2388         (WebView::notifyPreferencesChanged):
2389
2390 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2391
2392         [Curl] Clean up old style code in old curl files.
2393         https://bugs.webkit.org/show_bug.cgi?id=178569
2394
2395         Reviewed by Ryosuke Niwa.
2396
2397         * WebCache.cpp:
2398         (WebCache::cacheFolder):
2399         (WebCache::setCacheFolder):
2400         * WebView.cpp:
2401         (WebView::setCacheModel):
2402
2403 2017-10-19  Sam Weinig  <sam@webkit.org>
2404
2405         [Settings] Move global settings into their own file
2406         https://bugs.webkit.org/show_bug.cgi?id=178512
2407
2408         Reviewed by Darin Adler.
2409
2410         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2411
2412         * WebView.cpp:
2413         (WebView::initWithFrame):
2414
2415 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2416
2417         Replace some stack raw pointers with RefPtrs within WebCore/html
2418         https://bugs.webkit.org/show_bug.cgi?id=178201
2419         <rdar://problem/34841692>
2420
2421         Reviewed by Ryosuke Niwa.
2422
2423         * WebView.cpp:
2424         (WebView::handleEditingKeyboardEvent):
2425         Change the type of node as toNode() is changed to return RefPtr.
2426
2427 2017-10-16  Sam Weinig  <sam@webkit.org>
2428
2429         [Settings] Remove all custom code from Settings.h/cpp
2430         https://bugs.webkit.org/show_bug.cgi?id=178330
2431
2432         Reviewed by Simon Fraser.
2433
2434         * WebView.cpp:
2435         (WebView::notifyPreferencesChanged):
2436             
2437             Update for naming changes of FrameFlattening now that it is an enum class.
2438
2439 2017-10-11  Chris Dumez  <cdumez@apple.com>
2440
2441         Modernize Geolocation code
2442         https://bugs.webkit.org/show_bug.cgi?id=178148
2443
2444         Reviewed by Ryosuke Niwa.
2445
2446         * WebCoreSupport/WebGeolocationClient.cpp:
2447         (WebGeolocationClient::lastPosition):
2448         * WebCoreSupport/WebGeolocationClient.h:
2449         * WebGeolocationPosition.cpp:
2450         (WebGeolocationPosition::initWithTimestamp):
2451         (core):
2452         * WebGeolocationPosition.h:
2453         (WebGeolocationPosition::impl const):
2454
2455 2017-10-05  Chris Dumez  <cdumez@apple.com>
2456
2457         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2458         https://bugs.webkit.org/show_bug.cgi?id=177957
2459
2460         Reviewed by Alex Christensen.
2461
2462         * WebCoreSupport/WebPlatformStrategies.cpp:
2463         (WebPlatformStrategies::cookiesEnabled):
2464         * WebCoreSupport/WebPlatformStrategies.h:
2465
2466 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2467
2468         [Curl] Reimplement CurlDownload with CurlRequest
2469         https://bugs.webkit.org/show_bug.cgi?id=177779
2470
2471         Reviewed by Alex Christensen.
2472
2473         * WebDownload.h:
2474         * WebDownloadCurl.cpp:
2475         (WebDownload::init):
2476         (WebDownload::didReceiveResponse):
2477
2478 2017-09-29  Chris Dumez  <cdumez@apple.com>
2479
2480         Split some logic out of VisitedLinkStore and make it reusable
2481         https://bugs.webkit.org/show_bug.cgi?id=177575
2482
2483         Reviewed by Alex Christensen.
2484
2485         * WebCoreSupport/WebVisitedLinkStore.cpp:
2486         (WebVisitedLinkStore::addVisitedLink):
2487         (WebVisitedLinkStore::isLinkVisited):
2488         (WebVisitedLinkStore::addVisitedLinkHash):
2489         * WebCoreSupport/WebVisitedLinkStore.h:
2490
2491 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2492
2493         Make PolicyAction an encodable enum class
2494         https://bugs.webkit.org/show_bug.cgi?id=177480
2495
2496         Reviewed by Antti Koivisto.
2497
2498         * WebCoreSupport/WebFrameLoaderClient.cpp:
2499         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2500         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2501         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2502         * WebFramePolicyListener.cpp:
2503         (WebFramePolicyListener::use):
2504         (WebFramePolicyListener::download):
2505         (WebFramePolicyListener::ignore):
2506         (WebFramePolicyListener::continueSubmit):
2507
2508 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
2509
2510         [Win] fast/canvas/2d.getPath.modification.html is failing.
2511         https://bugs.webkit.org/show_bug.cgi?id=176534
2512
2513         Reviewed by Alex Christensen.
2514
2515         We need to enable Inspector additions at runtime in order to expose the getPath function.
2516
2517         * Interfaces/IWebPreferencesPrivate.idl:
2518         * WebPreferenceKeysPrivate.h:
2519         * WebPreferences.cpp:
2520         (WebPreferences::initializeDefaultSettings):
2521         (WebPreferences::setDataTransferItemsEnabled):
2522         (WebPreferences::inspectorAdditionsEnabled):
2523         (WebPreferences::setInspectorAdditionsEnabled):
2524         * WebPreferences.h:
2525         * WebView.cpp:
2526         (WebView::notifyPreferencesChanged):
2527
2528 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2529
2530         Modernize Geolocation code
2531         https://bugs.webkit.org/show_bug.cgi?id=176496
2532
2533         Reviewed by Andy Estes.
2534
2535         * WebCoreSupport/WebGeolocationClient.cpp:
2536         (WebGeolocationClient::requestPermission):
2537         * WebCoreSupport/WebGeolocationClient.h:
2538         (WebGeolocationClient::setEnableHighAccuracy): Deleted.
2539         (WebGeolocationClient::cancelPermissionRequest): Deleted.
2540         * WebGeolocationPolicyListener.h:
2541         * WebView.cpp:
2542         (WebView::initWithFrame):
2543         (WebView::geolocationDidFailWithError):
2544
2545 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
2546
2547         [Win] Enable DatatransferItems in DRT.
2548         https://bugs.webkit.org/show_bug.cgi?id=176424
2549
2550         Reviewed by Brent Fulgham.
2551
2552         * Interfaces/IWebPreferencesPrivate.idl:
2553         * WebPreferenceKeysPrivate.h:
2554         * WebPreferences.cpp:
2555         (WebPreferences::initializeDefaultSettings):
2556         (WebPreferences::QueryInterface):
2557         (WebPreferences::isSecureContextAttributeEnabled):
2558         (WebPreferences::dataTransferItemsEnabled):
2559         (WebPreferences::setDataTransferItemsEnabled):
2560         * WebPreferences.h:
2561         * WebView.cpp:
2562         (WebView::notifyPreferencesChanged):
2563
2564 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2565
2566         Unreviewed build fix #2 after r221275.
2567
2568         * WebCoreSupport/WebPlatformStrategies.cpp:
2569         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
2570         to match new API.
2571         * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
2572
2573 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2574
2575         Unreviewed build fix after r221275.
2576
2577         * WebCoreSupport/WebPlatformStrategies.cpp:
2578         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
2579         to match new API.
2580
2581 2017-08-28  Per Arne Vollan  <pvollan@apple.com>
2582
2583         [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
2584         https://bugs.webkit.org/show_bug.cgi?id=176031
2585
2586         Reviewed by Brent Fulgham.
2587
2588         When the function in the FramePolicyFunction parameter is called, it has already been moved
2589         to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
2590         function by using the stored member instead.
2591
2592         * WebCoreSupport/WebFrameLoaderClient.cpp:
2593         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2594         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2595         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2596
2597 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2598
2599         Unreviewed, try to fix the Windows build after r221064
2600
2601         didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
2602
2603         * WebCoreSupport/WebEditorClient.h:
2604
2605 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2606
2607         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2608         https://bugs.webkit.org/show_bug.cgi?id=175370
2609         <rdar://problem/33799806>
2610
2611         Reviewed by Ryosuke Niwa.
2612
2613         Adjust WebEditorClient for interface changes.
2614
2615         * WebCoreSupport/WebEditorClient.h:
2616
2617 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
2618
2619         Unreviewed build fix after r221017.
2620
2621         Correct copy/paste error.
2622
2623         * WebCoreSupport/WebPlatformStrategies.cpp:
2624         (WebPlatformStrategies::cookiesForDOM):
2625
2626 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
2627
2628         Unreviewed build fix after r221017.
2629
2630         * WebCoreSupport/WebPlatformStrategies.cpp:
2631         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
2632         * WebCoreSupport/WebPlatformStrategies.h:
2633
2634 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2635
2636         Remove ChromeClient::scrollbarsModeDidChange
2637         https://bugs.webkit.org/show_bug.cgi?id=175805
2638
2639         Reviewed by Daniel Bates.
2640
2641         * WebCoreSupport/WebChromeClient.h:
2642
2643 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2644
2645         Remove ChromeClient::hasOpenedPopup
2646         https://bugs.webkit.org/show_bug.cgi?id=175804
2647
2648         Reviewed by Sam Weinig.
2649
2650         * WebCoreSupport/WebChromeClient.cpp:
2651         (WebChromeClient::hasOpenedPopup const): Deleted.
2652         * WebCoreSupport/WebChromeClient.h:
2653
2654 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
2655
2656         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
2657         https://bugs.webkit.org/show_bug.cgi?id=173536
2658
2659         Reviewed by Brent Fulgham.
2660
2661         If the tree state is dirty, accessible objects are deleted while iterating over children
2662         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
2663         style is updated before this method is called.
2664
2665         * AccessibleBase.cpp:
2666         (AccessibleBase::getAccessibilityObjectForChild):
2667
2668 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2669
2670         [PAL] Move SessionID into PAL
2671         https://bugs.webkit.org/show_bug.cgi?id=174192
2672
2673         Reviewed by Antti Koivisto.
2674
2675         * WebCoreSupport/WebFrameLoaderClient.cpp:
2676         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2677         * WebCoreSupport/WebFrameLoaderClient.h:
2678         * WebCoreSupport/WebFrameNetworkingContext.cpp:
2679         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
2680         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2681         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2682         (WebFrameNetworkingContext::storageSession const):
2683         * WebCoreSupport/WebPlatformStrategies.cpp:
2684         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2685         * WebCoreSupport/WebPlatformStrategies.h:
2686
2687 2017-08-15  Youenn Fablet  <youenn@apple.com>
2688
2689         [Cache API] Adding generic support for CacheStorage and Cache methods
2690         https://bugs.webkit.org/show_bug.cgi?id=175455
2691
2692         Reviewed by Chris Dumez.
2693
2694         * WebView.cpp:
2695         (WebView::initWithFrame):
2696
2697 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2698
2699         Composition underline color is always black
2700         https://bugs.webkit.org/show_bug.cgi?id=174675
2701
2702         Reviewed by Ryosuke Niwa.
2703
2704         * WebView.cpp:
2705         (WebView::setCompositionForTesting): Use text color for
2706         composition underline.
2707
2708 2017-08-09  Daniel Bates  <dabates@apple.com>
2709
2710         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2711         https://bugs.webkit.org/show_bug.cgi?id=175247
2712         <rdar://problem/33679804>
2713
2714         Reviewed by Brady Eidson.
2715
2716         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2717         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2718         clients that need to make use of this information at this time. If such a needs comes up
2719         then we can expose API/SPI similar to what we do for WebKit.
2720
2721         * WebCoreSupport/WebFrameLoaderClient.cpp:
2722         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2723         * WebCoreSupport/WebFrameLoaderClient.h:
2724
2725 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
2726
2727         Async image decoding for large images should be disabled after the first time a tile is painted
2728         https://bugs.webkit.org/show_bug.cgi?id=174451
2729         <rdar://problem/31246421>
2730
2731         Reviewed by Simon Fraser.
2732
2733         * FullscreenVideoController.cpp:
2734         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
2735         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2736         (AcceleratedCompositingContext::paintContents):
2737         * WebCoreSupport/AcceleratedCompositingContext.h:
2738
2739 2017-07-23  Darin Adler  <darin@apple.com>
2740
2741         More NeverDestroyed and related cleanup
2742         https://bugs.webkit.org/show_bug.cgi?id=174745
2743
2744         Reviewed by Alex Christensen.
2745
2746         * Plugins/PluginDatabase.cpp:
2747         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
2748         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
2749         * Plugins/PluginMainThreadScheduler.cpp:
2750         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
2751         * Plugins/PluginMainThreadScheduler.h: Ditto.
2752         * WebCoreSupport/WebPlatformStrategies.cpp:
2753         (WebPlatformStrategies::initialize): Ditto.
2754         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
2755         * WebHistory.cpp:
2756         (sharedHistoryStorage): Ditto.
2757         * WebLocalizableStrings.cpp:
2758         (mainBundleLocStrings): Ditto.
2759         (frameworkLocStringsMutex): Ditto.
2760         (frameworkLocStrings): Ditto.
2761         * WebView.cpp:
2762         (WebView::standardUserAgentWithApplicationName): Ditto.
2763         Also changed to keep one global string with the prefix of the user agent string
2764         instead of keeping two globals with pieces of that prefix.
2765
2766 2017-07-24  Chris Dumez  <cdumez@apple.com>
2767
2768         Make ExceptionCode a proper enumeration
2769         https://bugs.webkit.org/show_bug.cgi?id=174771
2770
2771         Reviewed by Sam Weinig.
2772
2773         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
2774
2775         * DOMCoreClasses.cpp:
2776         (DOMDocument::createEvent):
2777         * WebView.cpp:
2778         (WebView::prepareCandidateWindow):
2779
2780 2017-07-21  Andreas Kling  <akling@apple.com>
2781
2782         Use more references in event dispatch code
2783         https://bugs.webkit.org/show_bug.cgi?id=174681
2784
2785         Reviewed by Geoffrey Garen.
2786
2787         * DOMEventsClasses.cpp:
2788         (WebEventListener::handleEvent):
2789         * DOMEventsClasses.h:
2790         * Plugins/PluginView.cpp:
2791         (WebCore::PluginView::handleEvent):
2792         * Plugins/PluginView.h:
2793
2794 2017-07-20  Brady Eidson  <beidson@apple.com>
2795
2796         Remove WebIconDatabase from WebKitLegacy/win.
2797         https://bugs.webkit.org/show_bug.cgi?id=174608
2798
2799         Reviewed by Alex Christensen.
2800
2801         It is unused.
2802         
2803         * ForEachCoClass.h:
2804
2805         * Interfaces/IWebIconDatabase.idl: Removed.
2806
2807         * Interfaces/WebKit.idl:
2808
2809         * WebCoreStatistics.cpp:
2810         (WebCoreStatistics::iconPageURLMappingCount):
2811         (WebCoreStatistics::iconRetainedPageURLCount):
2812         (WebCoreStatistics::iconRecordCount):
2813         (WebCoreStatistics::iconsWithDataCount):
2814
2815         * WebIconDatabase.cpp: Removed.
2816         * WebIconDatabase.h: Removed.
2817         * WebKitClassFactory.cpp:
2818
2819         * WebKitDLL.cpp:
2820         (shutDownWebKit):
2821
2822         * WebKitLogging.h:
2823
2824         * WebView.cpp:
2825         (WebView::close):
2826         (WebView::notifyDidAddIcon):
2827         (WebView::registerForIconNotification):
2828         (WebView::dispatchDidReceiveIconFromWebFrame):
2829         (WebView::onNotify):
2830
2831 2017-07-18  Matt Lewis  <jlewis3@apple.com>
2832
2833         Unreviewed, rolling out r219610.
2834
2835         This caused an api failure on all platforms for the test
2836         SnapshotImageLargeAsyncDecoding
2837
2838         Reverted changeset:
2839
2840         "Async image decoding for large images should be disabled
2841         after the first time a tile is painted"
2842         https://bugs.webkit.org/show_bug.cgi?id=174451
2843         http://trac.webkit.org/changeset/219610
2844
2845 2017-07-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
2846
2847         Async image decoding for large images should be disabled after the first time a tile is painted
2848         https://bugs.webkit.org/show_bug.cgi?id=174451
2849
2850         Reviewed by Simon Fraser.
2851
2852         * FullscreenVideoController.cpp:
2853         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
2854         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2855         (AcceleratedCompositingContext::paintContents):
2856         * WebCoreSupport/AcceleratedCompositingContext.h:
2857
2858 2017-07-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2859
2860         [Curl] Don't start downloading more than once for same request
2861         https://bugs.webkit.org/show_bug.cgi?id=174172
2862
2863         Reviewed by Alex Christensen.
2864
2865         * WebDownloadCurl.cpp:
2866         (WebDownload::init):
2867
2868 2017-07-12  Daniel Bates  <dabates@apple.com>
2869
2870         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
2871         https://bugs.webkit.org/show_bug.cgi?id=174427
2872
2873         Rubber-stamped by Brady Eidson.
2874
2875         * Plugins/PluginView.cpp:
2876         (WebCore::PluginView::start):
2877         (WebCore::PluginView::getURLNotify):
2878         (WebCore::PluginView::getURL):
2879         (WebCore::PluginView::handlePost):
2880
2881 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2882
2883         [WTF] Move SoftLinking.h into WTF
2884         https://bugs.webkit.org/show_bug.cgi?id=174000
2885
2886         Reviewed by Alex Christensen.
2887
2888         * WebKitClassFactory.cpp:
2889         * WebView.cpp:
2890
2891 2017-07-05  Brady Eidson  <beidson@apple.com>
2892
2893         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
2894         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
2895
2896         Reviewed by Alex Christensen.
2897
2898         Adopt to the new constructor for FrameLoadRequest.
2899
2900         * Plugins/PluginView.cpp:
2901         (WebCore::PluginView::start):
2902         (WebCore::PluginView::getURLNotify):
2903         (WebCore::PluginView::getURL):
2904         (WebCore::PluginView::handlePost):
2905
2906 2017-07-03  Brady Eidson  <beidson@apple.com>
2907
2908         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2909         https://bugs.webkit.org/show_bug.cgi?id=174073
2910
2911         Reviewed by Andy Estes.
2912
2913         * WebCoreSupport/WebFrameLoaderClient.cpp:
2914         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
2915         (WebFrameLoaderClient::registerForIconNotification): Deleted.
2916         * WebCoreSupport/WebFrameLoaderClient.h:
2917
2918 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
2919
2920         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
2921         https://bugs.webkit.org/show_bug.cgi?id=174004
2922
2923         Reviewed by Simon Fraser.
2924
2925         * WebCoreSupport/WebFrameLoaderClient.cpp:
2926         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2927
2928 2017-06-30  Daniel Bates  <dabates@apple.com>
2929
2930         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2931         https://bugs.webkit.org/show_bug.cgi?id=165160
2932         <rdar://problem/29451999>
2933
2934         Reviewed by Brady Eidson.
2935
2936         Pass the document that is requesting the load to the loader.
2937
2938         * Plugins/PluginView.cpp:
2939         (WebCore::PluginView::start):
2940         (WebCore::PluginView::getURLNotify):
2941         (WebCore::PluginView::getURL):
2942         (WebCore::PluginView::handlePost):
2943
2944 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2945
2946         Refactor drag start codepaths to plumb a DragItem to client layers
2947         https://bugs.webkit.org/show_bug.cgi?id=173832
2948         Work towards <rdar://problem/32236827>
2949
2950         Reviewed by Ryosuke Niwa and Tim Horton.
2951
2952         Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
2953
2954         * WebCoreSupport/WebDragClient.cpp:
2955         (WebDragClient::startDrag):
2956         * WebCoreSupport/WebDragClient.h:
2957
2958 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
2959
2960         Remove excessive headers from JavaScriptCore
2961         https://bugs.webkit.org/show_bug.cgi?id=173812
2962
2963         Reviewed by Darin Adler.
2964
2965         * Plugins/PluginPackage.cpp:
2966
2967 2017-06-22  Daniel Bates  <dabates@apple.com>
2968
2969         Make FrameLoadRequest a move-only type
2970         https://bugs.webkit.org/show_bug.cgi?id=173682
2971
2972         Reviewed by Alex Christensen and Darin Adler.
2973
2974         A FrameLoadRequest groups together the information to perform a load into a single object
2975         that is more manageable to pass around than its constituent parts. Code that receives a
2976         FrameLoadRequest is expected to extract out the information it needs to complete its task.
2977         And it does not make sense to re-use the same FrameLoadRequest object for more than one
2978         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
2979
2980         * Plugins/PluginView.cpp:
2981         (WebCore::PluginView::start):
2982         (WebCore::PluginView::performRequest):
2983         (WebCore::PluginView::load):
2984         (WebCore::PluginView::getURLNotify):
2985         (WebCore::PluginView::getURL):
2986         (WebCore::PluginView::handlePost):
2987         * Plugins/PluginView.h:
2988         (WebCore::PluginRequest::PluginRequest):
2989
2990 2017-06-22  Daniel Bates  <dabates@apple.com>
2991
2992         [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
2993         https://bugs.webkit.org/show_bug.cgi?id=173683
2994
2995         Reviewed by Alex Christensen.
2996
2997         Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
2998         header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
2999         by including PluginView.h. The latter does not make use of the functionality
3000         provided by FrameLoadRequest.h.
3001
3002         * Plugins/PluginViewWin.cpp:
3003         * WebCoreSupport/WebContextMenuClient.cpp:
3004
3005 2017-06-21  Daniel Bates  <dabates@apple.com>
3006
3007         Cleanup FrameLoadRequest
3008         https://bugs.webkit.org/show_bug.cgi?id=173564
3009         <rdar://problem/32903570>
3010
3011         Reviewed by Brent Fulgham.
3012
3013         * Plugins/PluginView.cpp:
3014         (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
3015         we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
3016         we do not have one. Use C++11 brace initialization syntax.
3017         (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
3018         name as we do not have one. Use C++11 brace initialization syntax.
3019         (WebCore::PluginView::getURL): Ditto.
3020         (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
3021         function to closer to where it is actually used. Explicitly pass the null-string for the target
3022         frame name as we do not have one. Use C++11 brace initialization syntax.
3023
3024 2017-06-20  Daniel Bates  <dabates@apple.com>
3025
3026         Have FrameLoadRequest takes a Frame& instead of a Frame*
3027         https://bugs.webkit.org/show_bug.cgi?id=173614
3028         <rdar://problem/32884890>
3029
3030         Reviewed by Brent Fulgham.
3031
3032         * Plugins/PluginView.cpp:
3033         (WebCore::PluginView::performRequest):
3034         * WebFrame.cpp:
3035         (WebFrame::loadRequest):
3036
3037 2017-06-19  Chris Dumez  <cdumez@apple.com>
3038
3039         Use WTF::Function instead of std::function in more places in WebCore/
3040         https://bugs.webkit.org/show_bug.cgi?id=173535
3041
3042         Reviewed by Antti Koivisto.
3043
3044         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
3045
3046         * WebCoreSupport/WebFrameLoaderClient.cpp:
3047         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3048         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3049         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3050         (WebFrameLoaderClient::dispatchWillSubmitForm):
3051         (WebFrameLoaderClient::setUpPolicyListener):
3052         (WebFrameLoaderClient::receivedPolicyDecision):
3053         * WebCoreSupport/WebFrameLoaderClient.h:
3054
3055 2017-05-14 Frederic Wang  <fwang@igalia.com>
3056
3057         Add heuristic to avoid flattening "fullscreen" iframes
3058         https://bugs.webkit.org/show_bug.cgi?id=171914
3059
3060         Reviewed by Simon Fraser.
3061
3062         This commit ajusts the window port to internally use the new preference type for frame flattening.
3063         However, the "partial frame flattening" value is not exposed yet.
3064
3065         * WebView.cpp:
3066         (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
3067
3068 2017-06-17  Chris Dumez  <cdumez@apple.com>
3069
3070         Use WTF::Function instead of std::function in WebKit2/
3071         https://bugs.webkit.org/show_bug.cgi?id=173504
3072
3073         Reviewed by Darin Adler.
3074
3075         Use WTF::Function instead of std::function in WebKit2/ to avoid
3076         unnecessary copying.
3077
3078         * Plugins/PluginStream.cpp:
3079         (WebCore::PluginStream::willSendRequest):
3080         * Plugins/PluginStream.h:
3081
3082 2017-06-16  Sam Weinig  <sam@webkit.org>
3083
3084         [WebIDL] Remove custom bindings for HTMLDocument
3085         https://bugs.webkit.org/show_bug.cgi?id=173444
3086
3087         Reviewed by Darin Adler.
3088
3089         * DOMHTMLClasses.cpp:
3090         (DOMHTMLDocument::write):
3091         (DOMHTMLDocument::writeln):
3092         Update for new signature of write/writeln.
3093
3094 2017-06-16  Daniel Bates  <dabates@apple.com>
3095
3096         Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
3097         instead of URL { ParsedURLString, ... }
3098         https://bugs.webkit.org/show_bug.cgi?id=173495
3099         <rdar://problem/32827445>
3100
3101         Reviewed by Alex Christensen.
3102
3103         URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
3104         Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
3105         Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
3106         would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
3107         parse an arbitrary string that looks like a URL.
3108
3109         Also modernize the code using C++14 idioms.
3110
3111         * WebCoreSupport/WebContextMenuClient.cpp:
3112         (WebContextMenuClient::searchWithGoogle):
3113
3114 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
3115
3116         [Win] WebKit shouldn't include the forwarding header of WebKit itself
3117         https://bugs.webkit.org/show_bug.cgi?id=173352
3118
3119         Reviewed by Alex Christensen.
3120
3121         * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
3122
3123 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
3124
3125         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
3126         https://bugs.webkit.org/show_bug.cgi?id=173318
3127
3128         Reviewed by Darin Adler.
3129
3130         The logical frame size is currently calculated by scaling the frame size in pixels,
3131         and rounding the coordinates to the nearest integers. The computed logical frame
3132         size will in some cases be smaller than the scaled frame size in pixels, since it is
3133         represented as an IntSize. In these cases, the bottom line will not be painted.
3134         Instead of calculating the logical frame size by rounding the scaled frame in
3135         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
3136
3137         * WebCoreSupport/WebFrameLoaderClient.cpp:
3138         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3139
3140 2017-06-13  Daniel Bates  <dabates@apple.com>
3141
3142         Implement W3C Secure Contexts Draft Specification
3143         https://bugs.webkit.org/show_bug.cgi?id=158121
3144         <rdar://problem/26012994>
3145
3146         Reviewed by Brent Fulgham.
3147
3148         Part 4
3149
3150         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3151
3152         * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
3153         * WebPreferenceKeysPrivate.h:
3154         * WebPreferences.cpp:
3155         (WebPreferences::initializeDefaultSettings):
3156         (WebPreferences::QueryInterface):
3157         (WebPreferences::setIsSecureContextAttributeEnabled):
3158         (WebPreferences::isSecureContextAttributeEnabled):
3159         * WebPreferences.h:
3160         * WebView.cpp:
3161         (WebView::notifyPreferencesChanged):
3162
3163 2017-06-13  Per Arne Vollan  <pvollan@apple.com>
3164
3165         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
3166         https://bugs.webkit.org/show_bug.cgi?id=173318
3167
3168         Reviewed by Alex Christensen.
3169
3170         The logical frame size is currently calculated by scaling the frame size in pixels,
3171         and rounding the coordinates to the nearest integers. The computed logical frame
3172         size will in some cases be smaller than the scaled frame size in pixels, since it is
3173         represented as an IntSize. In these cases, the bottom line will not be painted.
3174         Instead of calculating the logical frame size by rounding the scaled frame in
3175         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
3176  
3177         * WebView.cpp:
3178         (WebView::sizeChanged):
3179
3180 2017-06-13  Sam Weinig  <sam@webkit.org>
3181
3182         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
3183         https://bugs.webkit.org/show_bug.cgi?id=80733
3184
3185         Reviewed by Chris Dumez.
3186
3187         * WebFrame.cpp:
3188         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
3189
3190 2017-06-12  Daewoong Jang  <daewoong.jang@navercorp.com>
3191
3192         Remove WebCore::unloadModule and related data types
3193         https://bugs.webkit.org/show_bug.cgi?id=173231
3194
3195         Reviewed by Darin Adler.
3196
3197         * Plugins/PlatformModule.h: Added.
3198         (WebCore::PlatformModuleVersion::PlatformModuleVersion):
3199         * Plugins/PluginPackage.cpp:
3200         (WebCore::PluginPackage::freeLibraryTimerFired):
3201         * Plugins/PluginPackage.h:
3202
3203 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3204
3205         [iOS DnD] Add a hook to perform two-step drops in editable content
3206         https://bugs.webkit.org/show_bug.cgi?id=172992
3207         <rdar://problem/32590174>
3208
3209         Reviewed by Tim Horton.
3210
3211         Add a stub implementation for performTwoStepDrop on Windows.
3212
3213         * WebCoreSupport/WebEditorClient.h:
3214
3215 2017-06-04  Konstantin Tokarev  <annulen@yandex.ru>
3216
3217         Fix build of Windows-specific code with ICU 59.1
3218         https://bugs.webkit.org/show_bug.cgi?id=172729
3219
3220         Reviewed by Darin Adler.
3221
3222         Fix conversions from WTF::String to wchar_t* and vice versa.
3223
3224         * Plugins/PluginDatabaseWin.cpp:
3225         (WebCore::addPluginPathsFromRegistry):
3226         (WebCore::PluginDatabase::getPluginPathsInDirectories):
3227         (WebCore::addMozillaPluginDirectories):
3228         (WebCore::addWindowsMediaPlayerPluginDirectory):
3229         (WebCore::addAdobeAcrobatPluginDirectory):
3230         (WebCore::addJavaPluginDirectory):
3231         (WebCore::safariPluginsDirectory):
3232         (WebCore::addMacromediaPluginDirectories):
3233         * Plugins/PluginPackageWin.cpp:
3234         (WebCore::getVersionInfo):
3235         (WebCore::PluginPackage::fetchInfo):
3236         (WebCore::PluginPackage::load):
3237         * Plugins/PluginViewWin.cpp:
3238         (WebCore::PluginView::handlePostReadFile):
3239
3240 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
3241
3242         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
3243         https://bugs.webkit.org/show_bug.cgi?id=172709
3244
3245         Reviewed by Brent Fulgham.
3246
3247         Add method to exit fullscreen mode.
3248
3249         * Interfaces/IWebViewPrivate.idl:
3250         * WebView.cpp:
3251         (WebView::exitFullscreenIfNeeded):
3252         * WebView.h:
3253
3254 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
3255
3256         [Win] Create unique network storage session for each DRT.
3257         https://bugs.webkit.org/show_bug.cgi?id=172540
3258
3259         Reviewed by Brent Fulgham.
3260
3261         During layout testing, each DRT instance should have its own network storage session.
3262
3263         * Interfaces/IWebPreferencesPrivate.idl:
3264         * WebPreferences.cpp:
3265         (WebPreferences::switchNetworkLoaderToNewTestingSession):
3266         * WebPreferences.h:
3267
3268 2017-05-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3269
3270         [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
3271         https://bugs.webkit.org/show_bug.cgi?id=172535
3272
3273         Reviewed by Konstantin Tokarev.
3274
3275         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3276         (AcceleratedCompositingContext::paintContents): Append the fifth argument.
3277         * WebCoreSupport/AcceleratedCompositingContext.h: Ditto.
3278
3279 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
3280
3281         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
3282         https://bugs.webkit.org/show_bug.cgi?id=172071
3283
3284         Reviewed by Alexey Proskuryakov.
3285
3286         We need to delete all cookies after each test.
3287
3288         * Interfaces/IWebPreferencesPrivate.idl:
3289         * WebPreferences.cpp:
3290         (WebPreferences::linkPreloadEnabled):
3291         (WebPreferences::clearNetworkLoaderSession):
3292         * WebPreferences.h:
3293
3294 2017-05-13  Chris Dumez  <cdumez@apple.com>
3295
3296         Stop using RefPtr::release()
3297         https://bugs.webkit.org/show_bug.cgi?id=172074
3298
3299         Reviewed by Geoffrey Garen.
3300
3301         * WebFrame.cpp:
3302         (WebFrame::loadPlainTextString):
3303         (WebFrame::loadHTMLString):
3304         * WebFramePolicyListener.cpp:
3305         (WebFramePolicyListener::receivedPolicyDecision):
3306
3307 2017-05-13  Chris Dumez  <cdumez@apple.com>
3308
3309         Drop uses of PassRefPtr in WebKit/win
3310         https://bugs.webkit.org/show_bug.cgi?id=172067
3311
3312         Reviewed by Yusuke Suzuki.
3313
3314         * DOMEventsClasses.cpp:
3315         (DOMEvent::DOMEvent):
3316         (DOMEvent::createInstance):
3317         * DOMEventsClasses.h:
3318         (DOMUIEvent::DOMUIEvent):
3319         (DOMKeyboardEvent::DOMKeyboardEvent):
3320         (DOMMouseEvent::DOMMouseEvent):
3321         (DOMMutationEvent::DOMMutationEvent):
3322         (DOMOverflowEvent::DOMOverflowEvent):
3323         (DOMWheelEvent::DOMWheelEvent):
3324         * MemoryStream.cpp:
3325         (MemoryStream::MemoryStream):
3326         (MemoryStream::createInstance):
3327         * MemoryStream.h:
3328         * Plugins/PluginDatabase.cpp:
3329         (WebCore::PluginDatabase::refresh):
3330         (WebCore::PluginDatabase::add):
3331         (WebCore::PluginDatabase::loadPersistentMetadataCache):
3332         * Plugins/PluginDatabase.h:
3333         * Plugins/PluginPackage.cpp:
3334         (WebCore::PluginPackage::createPackage):
3335         (WebCore::PluginPackage::createPackageFromCache):
3336         * Plugins/PluginPackage.h:
3337         * Plugins/PluginStream.h:
3338         (WebCore::PluginStream::create):
3339         * WebActionPropertyBag.cpp:
3340         (WebActionPropertyBag::WebActionPropertyBag):
3341         (WebActionPropertyBag::createInstance):
3342         * WebActionPropertyBag.h:
3343         * WebArchive.cpp:
3344         (WebArchive::createInstance):
3345         (WebArchive::WebArchive):
3346         * WebArchive.h:
3347         * WebBackForwardList.cpp:
3348         (WebBackForwardList::WebBackForwardList):
3349         (WebBackForwardList::createInstance):
3350         * WebBackForwardList.h:
3351         * WebCoreSupport/EmbeddedWidget.cpp:
3352         (EmbeddedWidget::create):
3353         * WebCoreSupport/EmbeddedWidget.h:
3354         * WebCoreSupport/WebChromeClient.h:
3355         * WebFrame.cpp:
3356         (WebFrame::loadData):
3357         (WebFrame::createSubframeWithOwnerElement):
3358         * WebFrame.h:
3359         * WebFramePolicyListener.cpp:
3360         (WebFramePolicyListener::WebFramePolicyListener):
3361         (WebFramePolicyListener::createInstance):
3362         * WebFramePolicyListener.h:
3363         * WebGeolocationPolicyListener.cpp:
3364         (WebGeolocationPolicyListener::createInstance):
3365         (WebGeolocationPolicyListener::WebGeolocationPolicyListener):
3366         * WebGeolocationPolicyListener.h:
3367         * WebHistoryItem.cpp:
3368         (WebHistoryItem::WebHistoryItem):
3369         (WebHistoryItem::createInstance):
3370         * WebHistoryItem.h:
3371         * WebMutableURLRequest.cpp:
3372         (WebMutableURLRequest::setFormData):
3373         (WebMutableURLRequest::formData):
3374         * WebMutableURLRequest.h:
3375         * WebResource.cpp:
3376         (WebResource::createInstance):
3377         * WebResource.h:
3378         * WebScriptWorld.cpp:
3379         (WebScriptWorld::WebScriptWorld):
3380         (WebScriptWorld::createInstance):
3381         * WebScriptWorld.h:
3382         * WebURLAuthenticationChallengeSender.cpp:
3383         (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
3384         (WebURLAuthenticationChallengeSender::createInstance):
3385         * WebURLAuthenticationChallengeSender.h:
3386         * WebView.cpp:
3387         (WebView::setFullScreenElement):
3388         * WebView.h:
3389
3390 2017-05-11  Chris Dumez  <cdumez@apple.com>
3391
3392         Drop remaining uses of PassRefPtr in WebCore
3393         https://bugs.webkit.org/show_bug.cgi?id=172013
3394
3395         Reviewed by Yusuke Suzuki.
3396
3397         * Plugins/PluginView.cpp:
3398         (WebCore::PluginView::bindingInstance):
3399
3400 2017-05-11  Chris Dumez  <cdumez@apple.com>
3401
3402         Stop using PassRefPtr in platform/graphics
3403         https://bugs.webkit.org/show_bug.cgi?id=171977
3404
3405         Reviewed by Alex Christensen.
3406
3407         Build fix.
3408
3409         * FullscreenVideoController.cpp:
3410         (FullscreenVideoController::enterFullscreen):
3411         * WebKitDLL.cpp:
3412         (loadResourceIntoBuffer):
3413
3414 2017-05-09  Sam Weinig  <sam@webkit.org>
3415
3416         Remove support for legacy Notifications
3417         https://bugs.webkit.org/show_bug.cgi?id=171487
3418
3419         Reviewed by Jon Lee.
3420
3421         * WebCoreSupport/WebChromeClient.cpp:
3422         (WebChromeClient::WebChromeClient):
3423         * WebCoreSupport/WebChromeClient.h:
3424         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
3425         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
3426         Remove legacy notification specific code.
3427
3428 2017-05-09  Dean Jackson  <dino@apple.com>
3429
3430         Fix Windows build.
3431
3432         * Plugins/PluginView.h:
3433         * Plugins/PluginViewWin.cpp:
3434         (WebCore::PluginView::paint):
3435
3436 2017-05-06  Alexey Proskuryakov  <ap@apple.com>
3437
3438         REGRESSION (r216294): The new test fails on WebKit1
3439         https://bugs.webkit.org/show_bug.cgi?id=171780
3440
3441         Rolling back https://trac.webkit.org/r216294, https://trac.webkit.org/r216296,
3442         https://trac.webkit.org/216299, https://trac.webkit.org/216330
3443
3444         * Plugins/PluginView.h:
3445         * Plugins/PluginViewWin.cpp:
3446         (WebCore::PluginView::paint):
3447
3448 2017-05-06  Simon Fraser  <simon.fraser@apple.com>
3449
3450         Fix Windows build after r216294.
3451
3452         * Plugins/PluginView.h:
3453         * Plugins/PluginViewWin.cpp:
3454         (WebCore::PluginView::paint):
3455
3456 2017-05-04  Commit Queue  <commit-queue@webkit.org>
3457
3458         Unreviewed, rolling out r216206.
3459         https://bugs.webkit.org/show_bug.cgi?id=171714
3460
3461         Multiple LayoutTests crashing in Document::page() (Requested
3462         by ap on #webkit).
3463
3464         Reverted changeset:
3465
3466         "Remove support for legacy Notifications"
3467         https://bugs.webkit.org/show_bug.cgi?id=171487
3468         http://trac.webkit.org/changeset/216206
3469
3470 2017-05-04  Don Olmstead  <don.olmstead@am.sony.com>
3471
3472         [Win] Remove redundant macros that are set in the CMake config
3473         https://bugs.webkit.org/show_bug.cgi?id=171571
3474
3475         Reviewed by Brent Fulgham.
3476
3477         * COMEnumVariant.h:
3478         * COMPropertyBag.h:
3479         * WebKitPrefix.h:
3480
3481 2017-05-04  Sam Weinig  <sam@webkit.org>
3482
3483         Remove support for legacy Notifications
3484         https://bugs.webkit.org/show_bug.cgi?id=171487
3485
3486         Reviewed by Jon Lee.
3487
3488         * WebCoreSupport/WebChromeClient.cpp:
3489         (WebChromeClient::WebChromeClient):
3490         * WebCoreSupport/WebChromeClient.h:
3491         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
3492         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
3493         Remove legacy notification specific code.
3494
3495 2017-04-27  Alex Christensen  <achristensen@webkit.org>
3496
3497         Modernize Frame.h
3498         https://bugs.webkit.org/show_bug.cgi?id=171357
3499
3500         Reviewed by Andy Estes.
3501
3502         * WebCoreSupport/WebEditorClient.cpp:
3503         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
3504         * WebCoreSupport/WebEditorClient.h:
3505
3506 2017-04-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3507
3508         [WinCairo] Fix build break after updating ANGLE
3509         https://bugs.webkit.org/show_bug.cgi?id=170980
3510
3511         Reviewed by Brent Fulgham.
3512
3513         * WebCoreSupport/AcceleratedCompositingContext.cpp: Define GL_GLEXT_PROTOTYPES.
3514
3515 2017-04-19  Brent Fulgham  <bfulgham@apple.com>
3516
3517         [Win] REGRESSION(r215486): Windows Release build is broken
3518         https://bugs.webkit.org/show_bug.cgi?id=171024
3519         <rdar://problem/31722618>
3520
3521         Reviewed by Mark Lam.
3522
3523         Windows WebKit refers to a handful of JSC methods that are always
3524         inline. We need to include 'HeapInlines.h' to get the implementation
3525         of these methods.
3526
3527         * Plugins/PluginPackage.cpp:
3528         * WebFrame.cpp:
3529         * WebView.cpp:
3530
3531 2017-04-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3532
3533         Unreviewed, fix the Windows build after r215385
3534
3535         r215385 introduced a new virtual method on ChromeClient that needs to be implemented in WebChromeClient for
3536         Windows in WebKit1.
3537
3538         * WebCoreSupport/WebChromeClient.cpp:
3539         (WebChromeClient::createIconForFiles):
3540         * WebCoreSupport/WebChromeClient.h:
3541
3542 2017-04-10  Chris Dumez  <cdumez@apple.com>
3543
3544         Drop Timer::startOneShot() overload taking a double
3545         https://bugs.webkit.org/show_bug.cgi?id=170659
3546
3547         Reviewed by Yusuke Suzuki.
3548
3549         Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.
3550
3551         * Plugins/PluginMessageThrottlerWin.cpp: