[Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2
3         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
4         https://bugs.webkit.org/show_bug.cgi?id=195346
5
6         Reviewed by Fujii Hironori.
7
8         * COMPropertyBag.h:
9         (HashType>::GetPropertyInfo):
10         (HashType>::LoadObject):
11         * DOMCoreClasses.cpp:
12         (DOMNode::addEventListener):
13         (DOMNode::removeEventListener):
14         (DOMWindow::addEventListener):
15         (DOMWindow::removeEventListener):
16         (DOMElement::font):
17         * DOMHTMLClasses.cpp:
18         (DOMHTMLInputElement::setValueForUser):
19         (DOMHTMLInputElement::replaceCharactersInRange):
20         * Plugins/PluginDatabaseWin.cpp:
21         (WebCore::addPluginPathsFromRegistry):
22         (WebCore::PluginDatabase::getPluginPathsInDirectories const):
23         (WebCore::addMozillaPluginDirectories):
24         (WebCore::addWindowsMediaPlayerPluginDirectory):
25         (WebCore::addAdobeAcrobatPluginDirectory):
26         (WebCore::addJavaPluginDirectory):
27         (WebCore::safariPluginsDirectory):
28         (WebCore::addMacromediaPluginDirectories):
29         * Plugins/PluginPackageWin.cpp:
30         (WebCore::getVersionInfo):
31         (WebCore::PluginPackage::fetchInfo):
32         (WebCore::PluginPackage::load):
33         * Plugins/PluginViewWin.cpp:
34         (WebCore::PluginView::handlePostReadFile):
35         * WebCoreSupport/WebChromeClient.cpp:
36         (WebChromeClient::runOpenPanel):
37         * WebCoreSupport/WebEditorClient.cpp:
38         (WebEditorClient::checkSpellingOfString):
39         (WebEditorClient::checkGrammarOfString):
40         * WebCoreSupport/WebInspectorClient.cpp:
41         (WebInspectorFrontendClient::updateWindowTitle):
42         * WebLocalizableStrings.cpp:
43         (LocalizedString::operator LPCTSTR const):
44         * WebView.cpp:
45         (createContextMenuFromItems):
46         (WebView::setToolTip):
47         Use wchar helpers as needed.
48
49 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
50
51         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
52         https://bugs.webkit.org/show_bug.cgi?id=195053
53         <rdar://problem/48134710>
54
55         Reviewed by Ryosuke Niwa.
56
57         * WebCoreSupport/WebEditorClient.h:
58
59 2019-02-20  Darin Adler  <darin@apple.com>
60
61         Finish removing String::format
62         https://bugs.webkit.org/show_bug.cgi?id=194893
63
64         Reviewed by Daniel Bates.
65
66         * FullscreenVideoController.cpp:
67         (timeToString): Use makeString and pad.
68
69 2019-02-27  Simon Fraser  <simon.fraser@apple.com>
70
71         Roll out r242014; it caused crashes in compositing logging (webkit.org/b/195141)
72
73         * FullscreenVideoController.cpp:
74         (timeToString):
75
76 2019-02-26  Philippe Normand  <pnormand@igalia.com>
77
78         [WPE] Add API for webview background color configuration
79         https://bugs.webkit.org/show_bug.cgi?id=192305
80
81         Reviewed by Michael Catanzaro.
82
83         * WebCoreSupport/WebFrameLoaderClient.cpp:
84         (WebFrameLoaderClient::transitionToCommittedForNewPage): Create
85         FrameView with background color.
86
87 2019-02-20  Darin Adler  <darin@apple.com>
88
89         Finish removing String::format
90         https://bugs.webkit.org/show_bug.cgi?id=194893
91
92         Reviewed by Daniel Bates.
93
94         * FullscreenVideoController.cpp:
95         (timeToString): Use makeString and pad.
96
97 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
98
99         Input type "formatSetInlineTextDirection" is dispatched when changing paragraph-level text direction
100         https://bugs.webkit.org/show_bug.cgi?id=194703
101         <rdar://problem/48111775>
102
103         Reviewed by Ryosuke Niwa.
104
105         * WebCoreSupport/WebEditorClient.cpp:
106         (undoNameForEditAction):
107
108 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
109
110         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
111         https://bugs.webkit.org/show_bug.cgi?id=194670
112         <rdar://problem/39066529>
113
114         Reviewed by Tim Horton.
115
116         * WebCoreSupport/WebEditorClient.cpp:
117         (WebEditorClient::replacementURLForResource): Deleted.
118         * WebCoreSupport/WebEditorClient.h:
119
120 2019-02-10  Darin Adler  <darin@apple.com>
121
122         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
123         https://bugs.webkit.org/show_bug.cgi?id=194487
124
125         Reviewed by Daniel Bates.
126
127         * WebView.cpp:
128         (webKitVersionString): Use makeString instead of String::format.
129
130 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
131
132         Allow pages to trigger programmatic paste from script on iOS
133         https://bugs.webkit.org/show_bug.cgi?id=194271
134         <rdar://problem/47808810>
135
136         Reviewed by Ryosuke Niwa.
137
138         * WebCoreSupport/WebEditorClient.h:
139
140 2019-02-06  Daniel Bates  <dabates@apple.com>
141
142         Standardize on ControlKey instead of CtrlKey
143         https://bugs.webkit.org/show_bug.cgi?id=194317
144
145         Reviewed by Tim Horton.
146
147         * AccessibleBase.cpp:
148         (AccessibleBase::get_accKeyboardShortcut):
149         * WebView.cpp:
150         (WebView::keyDown):
151
152 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
153
154         PageOverlayController's layers should be created lazily
155         https://bugs.webkit.org/show_bug.cgi?id=194199
156         rdar://problem/46571593
157
158         Reviewed by Tim Horton.
159
160         Expose PageOverlayController::hasDocumentOverlays() and hasViewOverlays()
161         and use them to only parent the overlay-hosting layers when necessary.
162
163         For document overlays, RenderLayerCompositor::appendDocumentOverlayLayers() can
164         simply do nothing if there are none. Updates are triggered via Page::installedPageOverlaysChanged(),
165         which calls FrameView::setNeedsCompositingConfigurationUpdate() to trigger the root layer
166         compositing updates that parents the layerWithDocumentOverlays().
167
168         View overlays are added to the layer tree via the DrawingArea. When we go between having
169         none and some view overlays, Page::installedPageOverlaysChanged() calls attachViewOverlayGraphicsLayer()
170         on the ChromeClient, and the DrawingArea responds by calling updateRootLayers() and scheduling a
171         compositing flush (this has to be done manually because view overlay layers are outside the
172         subtree managed by RenderLayerCompositor).
173         
174         Now that GraphicsLayers are ref-counted, we can let the DrawingArea simply retain its m_viewOverlayRootLayer;
175         there is no need for RenderLayerCompositor::attachRootLayer()/detachRootLayer() to do anything with view
176         overlay layers. This implies that a page can navigate (new FrameView) and view overlays will persist, without
177         having to be manually removed and re-added. We can also remove the Frame argument to attachViewOverlayGraphicsLayer().
178
179         * WebCoreSupport/WebChromeClient.cpp:
180         (WebChromeClient::attachViewOverlayGraphicsLayer):
181         * WebCoreSupport/WebChromeClient.h:
182
183 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
184
185         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
186         https://bugs.webkit.org/show_bug.cgi?id=194189
187
188         Reviewed by Geoffrey Garen.
189
190         Pass the policy check identifier around functions and store it in WebFramePolicyListener
191         so that we can send it back to WebCore with the navigation policy decision.
192
193         * WebCoreSupport/WebFrameLoaderClient.cpp:
194         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
195         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
196         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
197         (WebFrameLoaderClient::dispatchWillSubmitForm):
198         (WebFrameLoaderClient::setUpPolicyListener):
199         * WebCoreSupport/WebFrameLoaderClient.h:
200
201 2019-01-31  Alex Christensen  <achristensen@webkit.org>
202
203         Revert r238819 which is unneeded and caused a performance regression.
204         https://bugs.webkit.org/show_bug.cgi?id=192272
205         <rdar://problem/46664625>
206
207         * WebCoreSupport/WebFrameLoaderClient.cpp:
208         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
209         * WebCoreSupport/WebFrameLoaderClient.h:
210
211 2019-01-31  Takashi Komori  <Takashi.Komori@sony.com>
212
213         [Curl] Fix DRT crash related to private browsing.
214         https://bugs.webkit.org/show_bug.cgi?id=193816
215
216         Reviewed by Alex Christensen.
217
218         * WebCoreSupport/WebFrameNetworkingContext.cpp:
219         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
220
221 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
222
223         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
224         https://bugs.webkit.org/show_bug.cgi?id=193941
225
226         Reviewed by Alex Christensen.
227
228         * Plugins/PluginMessageThrottlerWin.cpp:
229         * Plugins/PluginView.cpp:
230         * Plugins/PluginViewWin.cpp:
231
232 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
233
234         Move FileSystem to WTF
235         https://bugs.webkit.org/show_bug.cgi?id=193602
236
237         Reviewed by Yusuke Suzuki.
238
239         * Plugins/PluginDatabase.cpp:
240         * Plugins/PluginPackage.h:
241         * Plugins/PluginStream.h:
242         * WebApplicationCache.cpp:
243         * WebDatabaseManager.cpp:
244         * WebDownloadCurl.cpp:
245         * WebPreferences.cpp:
246         * WebView.cpp:
247
248 2019-01-22  Alex Christensen  <achristensen@webkit.org>
249
250         Move NetworkStorageSession ownership to NetworkProcess
251         https://bugs.webkit.org/show_bug.cgi?id=193580
252
253         Reviewed by Geoff Garen.
254
255         * WebCoreSupport/WebFrameNetworkingContext.cpp:
256         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
257         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
258         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
259         (WebFrameNetworkingContext::storageSession const):
260         * WebDownloadCFNet.cpp:
261         (WebDownload::didReceiveAuthenticationChallenge):
262         * WebPreferences.cpp:
263         (WebPreferences::clearNetworkLoaderSession):
264         (WebPreferences::switchNetworkLoaderToNewTestingSession):
265
266 2019-01-15  Darin Adler  <darin@apple.com>
267
268         Use references rather than pointers for register/unregister functions, and more
269         https://bugs.webkit.org/show_bug.cgi?id=175028
270
271         Reviewed by Daniel Bates.
272
273         * Plugins/PluginView.cpp:
274         (WebCore::PluginView::startOrAddToUnstartedList): Pass a reference.
275         (WebCore::PluginView::~PluginView): Ditto.
276         * WebView.cpp:
277         (WebView::fullScreenClientWillEnterFullScreen): Ditto.
278         (WebView::fullScreenClientDidEnterFullScreen): Ditto.
279         (WebView::fullScreenClientDidExitFullScreen): Ditto.
280
281 2019-01-17  Per Arne Vollan  <pvollan@apple.com>
282
283         [Win][HighDPI] Repaint glitches when scrolling.
284         https://bugs.webkit.org/show_bug.cgi?id=173152
285         <rdar://problem/45269953>
286
287         Reviewed by Brent Fulgham.
288
289         Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
290         delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
291         Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
292
293         * WebView.cpp:
294         (WebView::scrollBackingStore):
295
296 2019-01-17  Alex Christensen  <achristensen@webkit.org>
297
298         Stop using NetworkStorageSession::storageSession in WebCore
299         https://bugs.webkit.org/show_bug.cgi?id=193529
300
301         Reviewed by Tim Horton.
302
303         * WebView.cpp:
304         (WebView::initWithFrame):
305
306 2019-01-15  Alex Christensen  <achristensen@webkit.org>
307
308         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
309         https://bugs.webkit.org/show_bug.cgi?id=193368
310
311         Reviewed by Geoff Garen.
312
313         * WebDownloadCFNet.cpp:
314         (WebDownload::didReceiveAuthenticationChallenge):
315
316 2019-01-15  Alex Christensen  <achristensen@webkit.org>
317
318         Fix Windows build after r240014
319         https://bugs.webkit.org/show_bug.cgi?id=161106
320
321         * WebView.cpp:
322
323 2019-01-15  Alex Christensen  <achristensen@webkit.org>
324
325         Stop using CookiesStrategy
326         https://bugs.webkit.org/show_bug.cgi?id=161106
327
328         Reviewed by Don Olmstead and Antti Koivisto.
329
330         * Plugins/PluginView.cpp:
331         (WebCore::PluginView::getValueForURL):
332         (WebCore::PluginView::setValueForURL):
333         * WebCoreSupport/WebPlatformStrategies.cpp:
334         (WebPlatformStrategies::createBlobRegistry):
335         (WebPlatformStrategies::createCookiesStrategy): Deleted.
336         (WebPlatformStrategies::cookiesForDOM): Deleted.
337         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
338         (WebPlatformStrategies::cookiesEnabled): Deleted.
339         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
340         (WebPlatformStrategies::getRawCookies): Deleted.
341         (WebPlatformStrategies::deleteCookie): Deleted.
342         * WebCoreSupport/WebPlatformStrategies.h:
343         * WebView.cpp:
344         (WebView::initWithFrame):
345
346 2019-01-08  Alex Christensen  <achristensen@webkit.org>
347
348         Stop using NetworkStorageSession in WebProcess
349         https://bugs.webkit.org/show_bug.cgi?id=193236
350
351         Reviewed by Don Olmstead.
352
353         * WebCoreSupport/WebFrameNetworkingContext.cpp:
354         (WebFrameNetworkingContext::storageSession const):
355         * WebCoreSupport/WebFrameNetworkingContext.h:
356         * WebCoreSupport/WebPlatformStrategies.cpp:
357         (WebPlatformStrategies::cookiesForDOM):
358         (WebPlatformStrategies::setCookiesFromDOM):
359         (WebPlatformStrategies::cookiesEnabled):
360         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
361         (WebPlatformStrategies::getRawCookies):
362         (WebPlatformStrategies::deleteCookie):
363         * WebCoreSupport/WebPlatformStrategies.h:
364
365 2019-01-08  Alex Christensen  <achristensen@webkit.org>
366
367         Unreviewed, rolling out r239727.
368
369         Broke API tests
370
371         Reverted changeset:
372
373         "Stop using NetworkStorageSession in WebProcess"
374         https://bugs.webkit.org/show_bug.cgi?id=193236
375         https://trac.webkit.org/changeset/239727
376
377 2018-12-24  Fujii Hironori  <Hironori.Fujii@sony.com>
378
379         Remove "using namespace std;"
380         https://bugs.webkit.org/show_bug.cgi?id=192973
381
382         Reviewed by Alex Christensen.
383
384         * FullscreenVideoController.cpp:
385         * WebFrame.cpp:
386         (WebFrame::drawFooter):
387         * WebHistory.cpp:
388         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
389         * WebKitQuartzCoreAdditions/CAView.cpp:
390         * WebView.cpp:
391         (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
392         (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
393         (WebView::setCacheModel):
394         (WebView::maxCacheModelInAnyInstance):
395
396 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
397
398         Use Ref<> as much as possible
399         https://bugs.webkit.org/show_bug.cgi?id=192808
400
401         Reviewed by Alex Christensen.
402
403         * Plugins/PluginDatabase.cpp:
404         (WebCore::PluginDatabase::refresh):
405         * Plugins/PluginView.cpp:
406         (WebCore::PluginView::mediaCanStart):
407         (WebCore::PluginView::performRequest):
408         (WebCore::PluginView::bindingInstance):
409         * Plugins/PluginView.h:
410         * WebCoreSupport/WebFrameLoaderClient.cpp:
411         (WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
412         (WebFrameLoaderClient::createPlugin):
413         (WebFrameLoaderClient::createJavaAppletWidget):
414         * WebCoreSupport/WebFrameLoaderClient.h:
415         * WebFrame.cpp:
416         (WebFrame::loadData):
417         (WebFrame::loadPlainTextString):
418         (WebFrame::loadHTMLString):
419         * WebFrame.h:
420         * WebKitQuartzCoreAdditions/CAView.cpp:
421         (WKQCA::CAView::create):
422         * WebKitQuartzCoreAdditions/CAView.h:
423         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
424         (WKQCA::CVDisplayLink::create):
425         * WebKitQuartzCoreAdditions/CVDisplayLink.h:
426         * WebKitQuartzCoreAdditions/ImageConversion.cpp:
427         (WKQCA::getImageCopy):
428         * WebView.cpp:
429         (WebView::addUserScriptToGroup):
430         (WebView::addUserStyleSheetToGroup):
431
432 2018-12-20  Chris Dumez  <cdumez@apple.com>
433
434         Use Optional::valueOr() instead of Optional::value_or()
435         https://bugs.webkit.org/show_bug.cgi?id=192933
436
437         Reviewed by Geoffrey Garen.
438
439         * WebSecurityOrigin.cpp:
440         (WebSecurityOrigin::port):
441
442 2018-12-19  Chris Dumez  <cdumez@apple.com>
443
444         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
445         https://bugs.webkit.org/show_bug.cgi?id=192728
446         <rdar://problem/46746779>
447
448         Reviewed by Geoff Garen.
449
450         * Plugins/*:
451         * WebCoreSupport/*:
452
453 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
454
455         [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag
456         https://bugs.webkit.org/show_bug.cgi?id=192617
457
458         Reviewed by Alex Christensen.
459
460         * COMEnumVariant.h:
461         (COMEnumVariant<ContainerType>::adopt): Removed 'typename' from non dependent names.
462         (COMEnumVariant<ContainerType>::createInstance): Ditto.
463         (COMEnumVariant<ContainerType>::Next): Prepend 'typename' for dependent names.
464         * COMPropertyBag.h:
465         (HashType>::createInstance): Removed 'typename' from non dependent names.
466         (HashType>::adopt): Ditto.
467         (HashType>::Read): Replaced dependent name 'HashMapType::const_iterator' with 'auto'.
468         (HashType>::GetPropertyInfo): Ditto.
469
470 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
471
472         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
473         https://bugs.webkit.org/show_bug.cgi?id=192618
474
475         Reviewed by Alex Christensen.
476
477         Classes which implement COM interface usually doesn't need the
478         virtual destructor because it has Release() virtual method to
479         destruct itself.
480
481         Marked 'final' such classes to suppress clang-cl's compilation
482         warnings.
483
484         * COMEnumVariant.h:
485         * COMPropertyBag.h:
486         * DefaultDownloadDelegate.h:
487         * DefaultPolicyDelegate.h:
488         * MemoryStream.h:
489         * WebActionPropertyBag.h:
490         * WebApplicationCache.h:
491         * WebArchive.h:
492         * WebBackForwardList.h:
493         * WebCache.h:
494         * WebCoreStatistics.h:
495         * WebCoreSupport/WebEditorClient.cpp:
496         * WebCoreSupport/WebInspectorDelegate.h:
497         * WebDataSource.h:
498         * WebDatabaseManager.cpp:
499         * WebDatabaseManager.h:
500         * WebDownload.h:
501         * WebDropSource.h:
502         * WebElementPropertyBag.h:
503         * WebError.h:
504         * WebFrame.cpp:
505         * WebFrame.h:
506         * WebFramePolicyListener.h:
507         * WebGeolocationPolicyListener.h:
508         * WebGeolocationPosition.h:
509         * WebHTMLRepresentation.h:
510         * WebHistory.h:
511         * WebHistoryItem.h:
512         * WebInspector.h:
513         * WebJavaScriptCollector.h:
514         * WebKitClassFactory.h:
515         * WebKitMessageLoop.h:
516         * WebKitStatistics.h:
517         * WebMutableURLRequest.h:
518         * WebNavigationData.h:
519         * WebNotification.h:
520         * WebNotificationCenter.h:
521         * WebPreferences.h:
522         * WebResource.h:
523         * WebScriptWorld.h:
524         * WebSecurityOrigin.h:
525         * WebSerializedJSValue.h:
526         * WebTextRenderer.h:
527         * WebURLAuthenticationChallenge.h:
528         * WebURLAuthenticationChallengeSender.h:
529         * WebURLCredential.h:
530         * WebURLProtectionSpace.h:
531         * WebURLResponse.h:
532         * WebUserContentURLPattern.h:
533         * WebView.cpp:
534         * WebView.h:
535         * WebWorkersPrivate.h:
536
537 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
538
539         [Win][Clang] Fix warning -Wmissing-field-initializers
540         https://bugs.webkit.org/show_bug.cgi?id=192584
541
542         Reviewed by Yusuke Suzuki.
543
544         Initialize a struct with '{ }' instead of '= {0}'.
545
546         * WebKitMessageLoop.cpp:
547         (WebKitMessageLoop::run):
548         * WebView.cpp:
549         (WebView::onMenuCommand):
550         (WebView::gesture):
551         (WebView::setShouldInvertColors):
552         (WebView::initializeToolTipWindow):
553         (WebView::setToolTip):
554         (WebView::fullScreenClientForceRepaint):
555
556 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
557
558         Turn WritingDirection into an enum class
559         https://bugs.webkit.org/show_bug.cgi?id=192401
560         Work towards <rdar://problem/42075638>
561
562         Reviewed by Dan Bernstein.
563
564         Change WritingDirection from an enum to an enum class. No change in behavior.
565
566         * WebFrame.cpp:
567         (WebFrame::setTextDirection):
568
569 2018-12-03  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
570
571         Use WallTime for file time
572         https://bugs.webkit.org/show_bug.cgi?id=192287
573
574         Reviewed by Darin Adler.
575
576         * Plugins/PluginDatabase.cpp:
577         (WebCore::PluginDatabase::refresh):
578
579 2018-11-30  Alex Christensen  <achristensen@webkit.org>
580
581         Fix Windows build.
582
583         * WebView.cpp:
584
585 2018-11-30  Alex Christensen  <achristensen@webkit.org>
586
587         Fix Windows build.
588
589         * WebCoreSupport/WebFrameLoaderClient.h:
590
591 2018-11-30  Alex Christensen  <achristensen@webkit.org>
592
593         Fix Windows build.
594
595         * WebCoreSupport/WebFrameLoaderClient.h:
596
597 2018-11-30  Alex Christensen  <achristensen@webkit.org>
598
599         Move URL from WebCore to WTF
600         https://bugs.webkit.org/show_bug.cgi?id=190234
601
602         Reviewed by Keith Miller.
603
604         * MarshallingHelpers.cpp:
605         * MarshallingHelpers.h:
606         * Plugins/PluginDatabase.cpp:
607         * Plugins/PluginDatabase.h:
608         * Plugins/PluginDatabaseWin.cpp:
609         * Plugins/PluginStream.h:
610         * Plugins/PluginView.h:
611         * WebCoreSupport/WebContextMenuClient.h:
612         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
613         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
614         * WebCoreSupport/WebFrameLoaderClient.h:
615         * WebCoreSupport/WebPlatformStrategies.h:
616         * WebCoreSupport/WebPluginInfoProvider.cpp:
617         (WebPluginInfoProvider::webVisiblePluginInfo):
618         * WebCoreSupport/WebPluginInfoProvider.h:
619         * WebCoreSupport/WebVisitedLinkStore.h:
620         * WebDataSource.cpp:
621         * WebDownload.h:
622         * WebElementPropertyBag.cpp:
623         * WebFrame.h:
624         * WebHistory.cpp:
625         * WebHistory.h:
626         * WebHistoryItem.cpp:
627         * WebResource.cpp:
628         (WebResource::WebResource):
629         * WebResource.h:
630         * WebSecurityOrigin.cpp:
631         * WebURLResponse.cpp:
632         (WebURLResponse::createInstance):
633         * WebUserContentURLPattern.cpp:
634         * WebView.h:
635
636 2018-11-28  Alex Christensen  <achristensen@webkit.org>
637
638         Remove dead code from an earlier attempt at implementing safe browsing
639         https://bugs.webkit.org/show_bug.cgi?id=192067
640
641         Reviewed by Chris Dumez.
642
643         * WebCoreSupport/WebFrameLoaderClient.cpp:
644         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
645         * WebCoreSupport/WebFrameLoaderClient.h:
646
647 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
648
649         [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
650         https://bugs.webkit.org/show_bug.cgi?id=191959
651
652         Reviewed by Alex Christensen.
653
654         * MarshallingHelpers.h: Removed extra "MarshallingHelpers::" of windowsEpochAbsoluteTime declaration.
655
656 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
657
658         [Win] Reduce the use of WKSI library calls: CoreAnimation
659         https://bugs.webkit.org/show_bug.cgi?id=191777
660         <rdar://problem/46140542>
661
662         Reviewed by Zalan Bujtas.
663
664         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
665         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
666         directives for WebKitSystemInterface.lib.
667
668         * FullscreenVideoController.cpp:
669         * WebKitGraphics.cpp:
670         * WebPreferences.cpp:
671
672 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
673
674         Address post-review feedback after r238438
675         https://bugs.webkit.org/show_bug.cgi?id=191913
676
677         Reviewed by Ryosuke Niwa.
678
679         * AccessibleTextImpl.cpp:
680         (AccessibleText::replaceText):
681
682 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
683
684         Web Inspector: "Reload Web Inspector" button no longer partially works
685         https://bugs.webkit.org/show_bug.cgi?id=191773
686         <rdar://problem/46139932>
687
688         Reviewed by Devin Rousso.
689
690         * WebCoreSupport/WebInspectorClient.cpp:
691         (WebInspectorFrontendClient::reopen):
692         * WebCoreSupport/WebInspectorClient.h:
693
694 2018-11-17  Devin Rousso  <drousso@apple.com>
695
696         Web Inspector: Network: add button to show system certificate dialog
697         https://bugs.webkit.org/show_bug.cgi?id=191458
698         <rdar://problem/45977019>
699
700         Reviewed by Joseph Pecoraro.
701
702         * WebCoreSupport/WebInspectorClient.h:
703         * WebCoreSupport/WebInspectorClient.cpp:
704         (WebInspectorFrontendClient::showCertificate): Added.
705
706 2018-11-16  Brent Fulgham  <bfulgham@apple.com>
707
708         [Win] Reduce the use of WKSI library calls: CFNetwork
709         https://bugs.webkit.org/show_bug.cgi?id=191718
710         <rdar://problem/46108732>
711
712         Reviewed by Alex Christensen.
713
714         Remove custom WKSI CFNetwork calls, since the SPI is already documented in PAL. Just
715         make the same calls on Windows, like we did for iOS and macOS back in 2017.
716
717         * WebCache.cpp:
718         (WebCache::cacheFolder):
719         * WebCoreSupport/WebFrameNetworkingContext.cpp:
720         * WebCoreSupport/WebPlatformStrategies.cpp:
721         * WebError.cpp:
722         (WebError::localizedDescription):
723         (WebError::sslPeerCertificate):
724         * WebURLResponse.cpp:
725         (WebURLResponse::sslPeerCertificate):
726         (WebURLResponse::certificateDictionary const):
727         * WebView.cpp:
728         (WebView::setCacheModel):
729
730 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
731
732         [Win] Reduce the use of WKSI library calls: Font Handling
733         https://bugs.webkit.org/show_bug.cgi?id=191701
734         <rdar://problem/46104809>
735
736         Reviewed by Myles C. Maxfield.
737
738         Update to use the old font handling routines moved from WKSI to FontCascade.
739
740         * WebPreferences.cpp:
741         (WebPreferences::setFontSmoothing):
742         (WebPreferences::setFontSmoothingContrast):
743         * WebView.cpp:
744         (systemParameterChanged):
745
746 2018-11-14  Timothy Hatcher  <timothy@apple.com>
747
748         Default the view background color and text color to different values when in dark mode.
749         https://bugs.webkit.org/show_bug.cgi?id=191607
750         rdar://problem/46045854
751
752         Reviewed by Dean Jackson.
753
754         * WebFrame.cpp:
755         (WebFrame::updateBackground): Drop backgroundColor.
756         * WebCoreSupport/WebFrameLoaderClient.cpp:
757         (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor.
758
759 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
760
761         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
762         https://bugs.webkit.org/show_bug.cgi?id=191612
763
764         Reviewed by Matt Baker.
765
766         * WebCoreSupport/WebInspectorClient.cpp:
767         (WebInspectorFrontendClient::destroyInspectorView):
768
769 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
770
771         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
772         https://bugs.webkit.org/show_bug.cgi?id=189230
773         <rdar://problem/44050379>
774
775         Reviewed by Joseph Pecoraro.
776
777         Runs all png images through zopflipng. This results in a smaller file
778         size and takes care of this issue as a byproduct.
779
780         * WebKit.resources/deleteButton.png:
781         * WebKit.resources/deleteButtonPressed.png:
782         * WebKit.resources/fsVideoAudioVolumeHigh.png:
783         * WebKit.resources/fsVideoAudioVolumeLow.png:
784         * WebKit.resources/fsVideoExitFullscreen.png:
785         * WebKit.resources/fsVideoPause.png:
786         * WebKit.resources/fsVideoPlay.png:
787         * WebKit.resources/missingImage.png:
788         * WebKit.resources/nullplugin.png:
789         * WebKit.resources/panEastCursor.png:
790         * WebKit.resources/panIcon.png:
791         * WebKit.resources/panNorthCursor.png:
792         * WebKit.resources/panNorthEastCursor.png:
793         * WebKit.resources/panNorthWestCursor.png:
794         * WebKit.resources/panSouthCursor.png:
795         * WebKit.resources/panSouthEastCursor.png:
796         * WebKit.resources/panSouthWestCursor.png:
797         * WebKit.resources/panWestCursor.png:
798         * WebKit.resources/searchCancel.png:
799         * WebKit.resources/searchCancelPressed.png:
800         * WebKit.resources/searchMagnifier.png:
801         * WebKit.resources/searchMagnifierResults.png:
802         * WebKit.resources/textAreaResizeCorner.png:
803         * WebKit.resources/verticalTextCursor.png:
804         * WebKit.resources/zoomInCursor.png:
805         * WebKit.resources/zoomOutCursor.png:
806
807 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
808
809         Unreviewed Windows build fix for r238049.
810
811         * WebView.cpp:
812         (WebView::initWithFrame):
813
814 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
815
816         Unreviewed MSVC build fix after r238039 (and r238046).
817
818         * WebDocumentLoader.h:
819         * WebView.cpp:
820         (WebView::setShouldApplyMacFontAscentHack):
821
822 2018-11-09  Antti Koivisto  <antti@apple.com>
823
824         Use OptionSet for layout milestones
825         https://bugs.webkit.org/show_bug.cgi?id=191470
826
827         Reviewed by Dean Jackson.
828
829         * WebCoreSupport/WebFrameLoaderClient.cpp:
830         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
831         * WebCoreSupport/WebFrameLoaderClient.h:
832
833 2018-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
834
835         WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
836         https://bugs.webkit.org/show_bug.cgi?id=191455
837
838         Reviewed by Brent Fulgham.
839
840         * WebHistory.h: Marked with 'override' and removed 'virtual'.
841
842 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
843
844         Add a storage limit for IndexedDB
845         https://bugs.webkit.org/show_bug.cgi?id=190598
846         <rdar://problem/44654715>
847
848         Reviewed by Chris Dumez.
849
850         * Interfaces/IWebDatabaseManager.idl:
851         * WebDatabaseManager.cpp:
852         (WebDatabaseManager::setIDBPerOriginQuota):
853         * WebDatabaseManager.h:
854
855 2018-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
856
857         [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
858         https://bugs.webkit.org/show_bug.cgi?id=191105
859
860         Reviewed by Brent Fulgham.
861
862         * DOMHTMLClasses.h:
863         (DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
864         instead of own setNodeValue.
865
866 2018-10-25  Antoine Quint  <graouts@apple.com>
867
868         [Web Animations] Turn Web Animations CSS Integration off by default
869         https://bugs.webkit.org/show_bug.cgi?id=190901
870
871         Reviewed by Dean Jackson.
872
873         * WebPreferences.cpp:
874         (WebPreferences::initializeDefaultSettings):
875
876 2018-10-21  Fujii Hironori  <Hironori.Fujii@sony.com>
877
878         [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
879         https://bugs.webkit.org/show_bug.cgi?id=190744
880
881         Reviewed by Alex Christensen.
882
883         clang-cl reports compilation warnings for inconsistent 'override'
884         keyword usage.
885
886         WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
887         This can't be marked 'override' if !USE(CA).
888
889         * WebView.cpp:
890         (WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).
891         * WebView.h: Marked all overriding member function declarations of WebView 'override'.
892         Declare flushPendingGraphicsLayerChanges only if USE(CA).
893
894 2018-10-18  Alex Christensen  <achristensen@webkit.org>
895
896         Clean up FrameLoader two-state enums
897         https://bugs.webkit.org/show_bug.cgi?id=190731
898
899         Reviewed by Chris Dumez.
900
901         * WebCoreSupport/WebFrameLoaderClient.cpp:
902         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
903         * WebCoreSupport/WebFrameLoaderClient.h:
904
905 2018-10-17  Alex Christensen  <achristensen@webkit.org>
906
907         BackForwardClient needs to be able to support UIProcess-only back/forward lists
908         https://bugs.webkit.org/show_bug.cgi?id=190675
909
910         Reviewed by Chris Dumez.
911
912         * BackForwardList.cpp:
913         (BackForwardList::backItem):
914         (BackForwardList::currentItem):
915         (BackForwardList::forwardItem):
916         (BackForwardList::backListCount const):
917         (BackForwardList::forwardListCount const):
918         (BackForwardList::itemAtIndex):
919         * BackForwardList.h:
920
921 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
922
923         Unreviewed attempt to fix the Windows build after r237112.
924
925         * Plugins/PluginView.cpp:
926         (WebCore::PluginView::performRequest):
927
928 2018-10-16  Alex Christensen  <achristensen@webkit.org>
929
930         Replace HistoryItem* with HistoryItem& where possible
931         https://bugs.webkit.org/show_bug.cgi?id=190617
932
933         Reviewed by Chris Dumez.
934
935         * BackForwardList.cpp:
936         (BackForwardList::goToItem):
937         * BackForwardList.h:
938         * WebBackForwardList.cpp:
939         (WebBackForwardList::goToItem):
940
941 2018-10-15  Alex Christensen  <achristensen@webkit.org>
942
943         Fix Windows build.
944
945         * WebView.cpp:
946         (WebView::loadBackForwardListFromOtherView):
947
948 2018-10-15  Alex Christensen  <achristensen@webkit.org>
949
950         Fix WinCairo build.
951
952         * WebView.cpp:
953         (WebView::backForwardList):
954
955 2018-10-15  Alex Christensen  <achristensen@webkit.org>
956
957         Modernize BackForwardClient.h
958         https://bugs.webkit.org/show_bug.cgi?id=190610
959
960         Reviewed by Chris Dumez.
961
962         * BackForwardList.cpp:
963         (BackForwardList::backListCount const):
964         (BackForwardList::forwardListCount const):
965         (BackForwardList::backListCount): Deleted.
966         (BackForwardList::forwardListCount): Deleted.
967         * BackForwardList.h:
968         * WebView.cpp:
969         (WebView::initWithFrame):
970         (WebView::backForwardList):
971
972 2018-10-15  Alex Christensen  <achristensen@webkit.org>
973
974         Remove unused WebView._globalHistoryItem
975         https://bugs.webkit.org/show_bug.cgi?id=190601
976
977         Reviewed by Chris Dumez.
978
979         * WebCoreSupport/WebFrameLoaderClient.cpp:
980         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
981         * WebCoreSupport/WebFrameLoaderClient.h:
982         * WebView.cpp:
983         (WebView::globalHistoryItem):
984         (WebView::setGlobalHistoryItem): Deleted.
985         * WebView.h:
986
987 2018-10-15  Alex Christensen  <achristensen@webkit.org>
988
989         Remove unused parameters from FrameLoaderClient::createFrame
990         https://bugs.webkit.org/show_bug.cgi?id=190587
991
992         Reviewed by Chris Dumez.
993
994         * WebCoreSupport/WebFrameLoaderClient.cpp:
995         (WebFrameLoaderClient::createFrame):
996         * WebCoreSupport/WebFrameLoaderClient.h:
997
998 2018-10-15  Chris Dumez  <cdumez@apple.com>
999
1000         Unreviewed Windows build fix after r237112.
1001
1002         * Plugins/PluginView.cpp:
1003         (WebCore::PluginView::performRequest):
1004         (WebCore::PluginView::load):
1005
1006 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1007
1008         Remove InjectedBundle processing of back/forward lists
1009         https://bugs.webkit.org/show_bug.cgi?id=190459
1010
1011         Reviewed by Chris Dumez.
1012
1013         * WebCoreSupport/WebFrameLoaderClient.cpp:
1014         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1015         * WebCoreSupport/WebFrameLoaderClient.h:
1016
1017 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1018
1019         Remove ParsedURLString
1020         https://bugs.webkit.org/show_bug.cgi?id=190154
1021
1022         Reviewed by Chris Dumez.
1023
1024         * WebDownloadCurl.cpp:
1025         (WebDownload::initWithRequest):
1026         * WebURLResponse.cpp:
1027         (WebURLResponse::createInstance):
1028
1029 2018-09-28  Chris Dumez  <cdumez@apple.com>
1030
1031         Drop support for cross-origin-window-policy header
1032         https://bugs.webkit.org/show_bug.cgi?id=190081
1033
1034         Reviewed by Ryosuke Niwa.
1035
1036         * WebPreferenceKeysPrivate.h:
1037         * WebPreferences.cpp:
1038         (WebPreferences::initializeDefaultSettings):
1039         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1040         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1041         * WebView.cpp:
1042         (WebView::notifyPreferencesChanged):
1043
1044 2018-09-27  Antoine Quint  <graouts@apple.com>
1045
1046         [Web Animations] Turn Web Animations with CSS integration on
1047         https://bugs.webkit.org/show_bug.cgi?id=184819
1048         <rdar://problem/39597337>
1049
1050         Reviewed by Dean Jackson.
1051
1052         * WebPreferences.cpp:
1053         (WebPreferences::initializeDefaultSettings):
1054
1055 2018-09-21  Alex Christensen  <achristensen@webkit.org>
1056
1057         Use a Variant for FormDataElement
1058         https://bugs.webkit.org/show_bug.cgi?id=189777
1059
1060         Reviewed by Chris Dumez.
1061
1062         * WebMutableURLRequest.cpp:
1063         (WebMutableURLRequest::setHTTPBody):
1064
1065 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1066
1067         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
1068         https://bugs.webkit.org/show_bug.cgi?id=189612
1069
1070         Reviewed by Alex Christensen.
1071
1072         Non-trivial types can't be used as aruguments of LOG_ERROR and
1073         ASSERT_WITH_MESSAGE.
1074
1075         * DefaultPolicyDelegate.cpp:
1076         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
1077         static_cast<BSTR> to convert BString.
1078         * WebLocalizableStrings.cpp:
1079         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
1080         char* by using 'key.utf8().data()'.
1081
1082 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
1083
1084         Unreviewed, rolling out r235953.
1085
1086         Caused layout test crashes under GuardMalloc.
1087
1088         Reverted changeset:
1089
1090         "Make GraphicsLayers ref-counted, so their tree can persist
1091         when disconnected from RenderLayerBackings"
1092         https://bugs.webkit.org/show_bug.cgi?id=189521
1093         https://trac.webkit.org/changeset/235953
1094
1095 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1096
1097         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
1098         https://bugs.webkit.org/show_bug.cgi?id=189538
1099
1100         Reviewed by Per Arne Vollan.
1101
1102         * WebPreferences.cpp:
1103         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
1104         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
1105         Apply static_cast to the result of OR-ed CFPropertyListFormat.
1106         (WebPreferences::screenFontSubstitutionEnabled):
1107         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
1108
1109 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1110
1111         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
1112         https://bugs.webkit.org/show_bug.cgi?id=189539
1113
1114         Reviewed by Alex Christensen.
1115
1116         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
1117         * WebCoreSupport/WebInspectorClient.cpp:
1118         (WebInspectorWndProc): Ditto.
1119         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
1120         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
1121
1122 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1123
1124         Refactor WebCore::EditAction to be an 8-bit enum class
1125         https://bugs.webkit.org/show_bug.cgi?id=189383
1126
1127         Reviewed by Dan Bernstein.
1128
1129         * WebCoreSupport/WebEditorClient.cpp:
1130         (undoNameForEditAction):
1131
1132 2018-09-04  Frederic Wang  <fwang@igalia.com>
1133
1134         Add basic support for ScrollIntoViewOptions
1135         https://bugs.webkit.org/show_bug.cgi?id=189258
1136
1137         Reviewed by Simon Fraser.
1138
1139         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
1140         can build despite the new scrollIntoView function.
1141
1142 2018-08-31  Chris Dumez  <cdumez@apple.com>
1143
1144         Unreviewed Windows build fix after r235562.
1145
1146         * WebCoreSupport/WebFrameLoaderClient.cpp:
1147         (WebFrameLoaderClient::dispatchWillSubmitForm):
1148
1149 2018-08-31  Chris Dumez  <cdumez@apple.com>
1150
1151         Assertion hit in ~CompletionHandler() from ~WebFrame()
1152         https://bugs.webkit.org/show_bug.cgi?id=189199
1153         <rdar://problem/42657233>
1154
1155         Reviewed by Youenn Fablet.
1156
1157         * WebCoreSupport/WebFrameLoaderClient.cpp:
1158         (WebFrameLoaderClient::dispatchWillSubmitForm):
1159         * WebCoreSupport/WebFrameLoaderClient.h:
1160
1161 2018-08-31  Frederic Wang  <fwang@igalia.com>
1162
1163         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1164         https://bugs.webkit.org/show_bug.cgi?id=182053
1165
1166         Reviewed by Simon Fraser.
1167
1168         Add developer flag to use standard behavior for scrolling* attributes.
1169
1170         * Interfaces/IWebPreferencesPrivate.idl:
1171         * WebPreferenceKeysPrivate.h:
1172         * WebPreferences.cpp:
1173         (WebPreferences::initializeDefaultSettings):
1174         (WebPreferences::CSSOMViewScrollingAPIEnabled):
1175         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
1176         * WebPreferences.h:
1177         * WebView.cpp:
1178         (WebView::notifyPreferencesChanged):
1179
1180 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
1181
1182         [CMake] Replace AVFoundationSupport.py using CMake
1183         https://bugs.webkit.org/show_bug.cgi?id=182891
1184
1185         Reviewed by Per Arne Vollan.
1186
1187         Remove references to the config.h contained in WebCore as it should
1188         not be accessible from outside of WebCore.
1189
1190         * WebKitPrefix.h:
1191
1192 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1193
1194         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
1195         https://bugs.webkit.org/show_bug.cgi?id=188496
1196         <rdar://problem/43216836>
1197
1198         Reviewed by Tim Horton.
1199
1200         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
1201         header directly.
1202
1203         * WebCoreSupport/WebDragClient.cpp:
1204
1205 2018-08-17  Alex Christensen  <achristensen@webkit.org>
1206
1207         Add some plumbing for safe browsing
1208         https://bugs.webkit.org/show_bug.cgi?id=188709
1209
1210         Reviewed by Tim Horton.
1211
1212         * WebCoreSupport/WebFrameLoaderClient.cpp:
1213         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1214         * WebCoreSupport/WebFrameLoaderClient.h:
1215
1216 2018-08-02  David Fenton  <david_fenton@apple.com>
1217
1218         Unreviewed, rolling out r234489.
1219
1220         Caused 50+ crashes and 60+ API failures on iOS
1221
1222         Reverted changeset:
1223
1224         "[WTF] Rename String::format to String::deprecatedFormat"
1225         https://bugs.webkit.org/show_bug.cgi?id=188191
1226         https://trac.webkit.org/changeset/234489
1227
1228 2018-08-01  Tomas Popela  <tpopela@redhat.com>
1229
1230         [WTF] Rename String::format to String::deprecatedFormat
1231         https://bugs.webkit.org/show_bug.cgi?id=188191
1232
1233         Reviewed by Darin Adler.
1234
1235         It should be replaced with string concatenation.
1236
1237         * FullscreenVideoController.cpp:
1238         (timeToString):
1239         * WebView.cpp:
1240         (webKitVersionString):
1241
1242 2018-07-30  Rob Buis  <rbuis@igalia.com>
1243
1244         https://bugs.webkit.org/show_bug.cgi?id=188137
1245         Merge PlatformCookieJar functions into NetworkStorageSession
1246
1247         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1248
1249         Reviewed by Alex Christensen.
1250
1251         * WebCoreSupport/WebPlatformStrategies.cpp:
1252         (WebPlatformStrategies::cookiesForDOM):
1253         (WebPlatformStrategies::setCookiesFromDOM):
1254         (WebPlatformStrategies::cookiesEnabled):
1255         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1256         (WebPlatformStrategies::getRawCookies):
1257         (WebPlatformStrategies::deleteCookie):
1258         * WebPreferences.cpp:
1259         (WebPreferences::clearNetworkLoaderSession):
1260
1261 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
1262
1263         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
1264         https://bugs.webkit.org/show_bug.cgi?id=187963
1265
1266         Reviewed by Alex Christensen.
1267
1268         * Plugins/PluginPackageWin.cpp:
1269         (WebCore::PluginPackage::fetchInfo):
1270         Update split/splitAllowingEmptyEntries usage.
1271
1272 2018-07-18  Antoine Quint  <graouts@apple.com>
1273
1274         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
1275         https://bugs.webkit.org/show_bug.cgi?id=187722
1276
1277         Reviewed by Myles Maxfield.
1278
1279         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
1280
1281         * DOMCoreClasses.cpp:
1282         (DOMElement::font):
1283
1284 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1285
1286         Disable cross-origin-window-policy by default
1287         https://bugs.webkit.org/show_bug.cgi?id=187509
1288
1289         Reviewed by Chris Dumez.
1290
1291         * WebPreferences.cpp:
1292         (WebPreferences::initializeDefaultSettings):
1293
1294 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1295
1296         [WTF] Add user-defined literal for ASCIILiteral
1297         https://bugs.webkit.org/show_bug.cgi?id=186839
1298
1299         Reviewed by Darin Adler.
1300
1301         * Plugins/PluginStream.cpp:
1302         (WebCore::PluginStream::startStream):
1303         * WebCoreSupport/WebContextMenuClient.cpp:
1304         (WebContextMenuClient::searchWithGoogle):
1305
1306 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1307
1308         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
1309         https://bugs.webkit.org/show_bug.cgi?id=186623
1310
1311         Reviewed by Youenn Fablet.
1312
1313         * WebCoreSupport/WebPluginInfoProvider.cpp:
1314         (WebPluginInfoProvider::pluginInfo):
1315         (WebPluginInfoProvider::webVisiblePluginInfo):
1316         * WebCoreSupport/WebPluginInfoProvider.h:
1317
1318 2018-06-13  Chris Dumez  <cdumez@apple.com>
1319
1320         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1321         https://bugs.webkit.org/show_bug.cgi?id=186545
1322
1323         Reviewed by Brady Eidson.
1324
1325         Update client delegate now that parameter type has changed.
1326
1327         * WebCoreSupport/WebFrameLoaderClient.cpp:
1328         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1329         * WebCoreSupport/WebFrameLoaderClient.h:
1330
1331 2018-06-11  Chris Dumez  <cdumez@apple.com>
1332
1333         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
1334         https://bugs.webkit.org/show_bug.cgi?id=186441
1335
1336         Reviewed by Brady Eidson.
1337
1338         Rename existing flag to something a bit more generic, now that it is used for
1339         more things than bypassing the navigation policy check.
1340
1341         * WebView.cpp:
1342         (WebView::goToBackForwardItem):
1343         (WebView::loadBackForwardListFromOtherView):
1344
1345 2018-06-04  Chris Dumez  <cdumez@apple.com>
1346
1347         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
1348         https://bugs.webkit.org/show_bug.cgi?id=186287
1349         <rdar://problem/40783352>
1350
1351         Reviewed by Youenn Fablet.
1352
1353         * Interfaces/IWebPreferencesPrivate.idl:
1354         * WebPreferenceKeysPrivate.h:
1355         * WebPreferences.cpp:
1356         (WebPreferences::initializeDefaultSettings):
1357         (WebPreferences::crossOriginWindowPolicySupportEnabled):
1358         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
1359         * WebPreferences.h:
1360         * WebView.cpp:
1361         (WebView::notifyPreferencesChanged):
1362
1363 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1364
1365         [JSC] Pass VM& parameter as much as possible
1366         https://bugs.webkit.org/show_bug.cgi?id=186085
1367
1368         Reviewed by Saam Barati.
1369
1370         * Plugins/PluginPackage.cpp:
1371         (WebCore::NPN_Invoke):
1372
1373 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1374
1375         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
1376         https://bugs.webkit.org/show_bug.cgi?id=186125
1377
1378         Unreviewed build fix
1379
1380         * WebActionPropertyBag.cpp:
1381         (WebActionPropertyBag::Read):
1382         (findMouseEvent): Deleted.
1383
1384 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
1385
1386         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
1387         https://bugs.webkit.org/show_bug.cgi?id=186027
1388
1389         Unreviewed build fix
1390
1391         * WebMutableURLRequest.cpp:
1392         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
1393         (WebMutableURLRequest::setClientCertificate):
1394
1395 2018-05-25  Chris Dumez  <cdumez@apple.com>
1396
1397         Minor ApplicationCacheStorage clean up
1398         https://bugs.webkit.org/show_bug.cgi?id=185984
1399
1400         Reviewed by Youenn Fablet.
1401
1402         * WebApplicationCache.cpp:
1403         (WebApplicationCache::originsWithCache):
1404
1405 2018-05-24  Chris Dumez  <cdumez@apple.com>
1406
1407         Reduce copying of FontCascadeDescription objects by moving them around
1408         https://bugs.webkit.org/show_bug.cgi?id=185963
1409
1410         Reviewed by Simon Fraser.
1411
1412         Reduce copying of FontCascadeDescription objects by moving them around when possible.
1413
1414         * FullscreenVideoController.cpp:
1415         (FullscreenVideoController::draw):
1416
1417 2018-05-15  Antoine Quint  <graouts@apple.com>
1418
1419         [Web Animations] Expose Web Animations CSS integration as an experimental feature
1420         https://bugs.webkit.org/show_bug.cgi?id=185647
1421
1422         Reviewed by Dean Jackson.
1423
1424         Rename the Web Animations CSS integration flag.
1425
1426         * Interfaces/IWebPreferencesPrivate.idl:
1427         * WebPreferenceKeysPrivate.h:
1428         * WebPreferences.cpp:
1429         (WebPreferences::initializeDefaultSettings):
1430         (WebPreferences::webAnimationsCSSIntegrationEnabled):
1431         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
1432         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1433         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
1434         * WebPreferences.h:
1435         * WebView.cpp:
1436         (WebView::notifyPreferencesChanged):
1437
1438 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1439
1440         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
1441         https://bugs.webkit.org/show_bug.cgi?id=185505
1442
1443         Unreviewed serious crash fix
1444
1445         Windows port crashes soon since Bug 184996.
1446
1447         * WebPreferences.cpp:
1448         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
1449         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
1450
1451 2018-05-07  Daniel Bates  <dabates@apple.com>
1452
1453         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
1454         https://bugs.webkit.org/show_bug.cgi?id=185170
1455
1456         Reviewed by Per Arne Vollan.
1457
1458         * WebCache.cpp:
1459         (WebCache::empty):
1460
1461 2018-04-27  Chris Dumez  <cdumez@apple.com>
1462
1463         Use WindowProxy instead of DOMWindow in our IDL
1464         https://bugs.webkit.org/show_bug.cgi?id=185022
1465
1466         Reviewed by Sam Weinig.
1467
1468         * DOMCoreClasses.cpp:
1469         (DOMDocument::getComputedStyle):
1470
1471 2018-04-23  Daniel Bates  <dabates@apple.com>
1472
1473         Implement Same-Site cookies
1474         https://bugs.webkit.org/show_bug.cgi?id=159464
1475         <rdar://problem/27196358>
1476
1477         Reviewed by Brent Fulgham.
1478
1479         Pass the Same-Site info through the strategy.
1480
1481         * WebCoreSupport/WebPlatformStrategies.cpp:
1482         (WebPlatformStrategies::cookiesForDOM):
1483         (WebPlatformStrategies::setCookiesFromDOM):
1484         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1485         (WebPlatformStrategies::getRawCookies):
1486         * WebCoreSupport/WebPlatformStrategies.h:
1487
1488 2018-04-23  Daniel Bates  <dabates@apple.com>
1489
1490         Implement Same-Site cookies
1491         https://bugs.webkit.org/show_bug.cgi?id=159464
1492         <rdar://problem/27196358>
1493
1494         Reviewed by Brent Fulgham.
1495
1496         Pass the Same-Site info through the strategy.
1497
1498         * WebCoreSupport/WebPlatformStrategies.cpp:
1499         (WebPlatformStrategies::cookiesForDOM):
1500         (WebPlatformStrategies::setCookiesFromDOM):
1501         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1502         (WebPlatformStrategies::getRawCookies):
1503         * WebCoreSupport/WebPlatformStrategies.h:
1504
1505 2018-04-20  Youenn Fablet  <youenn@apple.com>
1506
1507         Make PluginData cache its web visible plugins
1508         https://bugs.webkit.org/show_bug.cgi?id=184421
1509
1510         Reviewed by Chris Dumez.
1511
1512         * WebCoreSupport/WebPluginInfoProvider.cpp:
1513         (WebPluginInfoProvider::pluginInfo):
1514         (WebPluginInfoProvider::webVisiblePluginInfo):
1515         * WebCoreSupport/WebPluginInfoProvider.h:
1516
1517 2018-04-19  Chris Dumez  <cdumez@apple.com>
1518
1519         Rename JSDOMWindowProxy to JSWindowProxy
1520         https://bugs.webkit.org/show_bug.cgi?id=184797
1521
1522         Reviewed by Sam Weinig.
1523
1524         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
1525
1526         * WebFrame.cpp:
1527         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
1528
1529 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
1530
1531         Unreviewed rollout of r230632. Regression in memory usage.
1532
1533         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
1534
1535         * WebPreferences.cpp:
1536         (WebPreferences::initializeDefaultSettings):
1537
1538 2018-04-17  Chris Dumez  <cdumez@apple.com>
1539
1540         Unreviewed attempt to fix the Windows build after r230721
1541
1542         * WebCoreSupport/WebFrameLoaderClient.cpp:
1543         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1544
1545 2018-04-17  Chris Dumez  <cdumez@apple.com>
1546
1547         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
1548         https://bugs.webkit.org/show_bug.cgi?id=184678
1549         <rdar://problem/39422122>
1550
1551         Reviewed by Alex Christensen.
1552
1553         Add new parameter to dispatchDecidePolicyForNavigationAction.
1554
1555         * WebCoreSupport/WebFrameLoaderClient.cpp:
1556         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1557         * WebCoreSupport/WebFrameLoaderClient.h:
1558
1559 2018-04-12  Antoine Quint  <graouts@apple.com>
1560
1561         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
1562         https://bugs.webkit.org/show_bug.cgi?id=184569
1563         <rdar://problem/38671301>
1564
1565         Reviewed by Jon Lee.
1566
1567         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
1568
1569         * WebPreferences.cpp:
1570
1571 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1572
1573         [WTF] Remove StaticLock
1574         https://bugs.webkit.org/show_bug.cgi?id=184332
1575
1576         Reviewed by Mark Lam.
1577
1578         * WebKitQuartzCoreAdditions/CAView.cpp:
1579         (WKQCA::CAView::releaseAllD3DResources):
1580         * WebLocalizableStrings.cpp:
1581
1582 2018-04-03  Chris Dumez  <cdumez@apple.com>
1583
1584         Drop MainFrame class
1585         https://bugs.webkit.org/show_bug.cgi?id=184191
1586
1587         Reviewed by Darin Adler.
1588
1589         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
1590         relationship between the Page and the MainFrame.
1591
1592         This is ground work for introducing LocalFrame / RemoteFrame concepts.
1593
1594         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1595         * WebCoreSupport/WebContextMenuClient.cpp:
1596         * WebCoreSupport/WebDragClient.cpp:
1597         * WebDropSource.cpp:
1598         * WebFrame.cpp:
1599         * WebView.cpp:
1600
1601 2018-03-26  Chris Dumez  <cdumez@apple.com>
1602
1603         Use SecurityOriginData more consistently in Service Worker code
1604         https://bugs.webkit.org/show_bug.cgi?id=183969
1605
1606         Reviewed by Darin Adler.
1607
1608         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
1609
1610         * WebDatabaseManager.cpp:
1611         (WebDatabaseManager::databasesWithOrigin):
1612         (WebDatabaseManager::deleteOrigin):
1613         (WebDatabaseManager::deleteDatabase):
1614         (WebDatabaseManager::setQuota):
1615         * WebSecurityOrigin.cpp:
1616         (WebSecurityOrigin::usage):
1617         (WebSecurityOrigin::quota):
1618         (WebSecurityOrigin::setQuota):
1619
1620 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
1621
1622         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
1623         https://bugs.webkit.org/show_bug.cgi?id=183911
1624         <rdar://problem/38762306>
1625
1626         Reviewed by Youenn Fablet.
1627
1628         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
1629
1630         * WebView.cpp:
1631         (WebView::WebView):
1632
1633 2018-03-25  Commit Queue  <commit-queue@webkit.org>
1634
1635         Unreviewed, rolling out r229954.
1636         https://bugs.webkit.org/show_bug.cgi?id=184000
1637
1638         Caused many layout tests to crash on Apple High Sierra,
1639         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
1640         by dydz on #webkit).
1641
1642         Reverted changeset:
1643
1644         "Use SecurityOriginData more consistently in Service Worker
1645         code"
1646         https://bugs.webkit.org/show_bug.cgi?id=183969
1647         https://trac.webkit.org/changeset/229954
1648
1649 2018-03-24  Chris Dumez  <cdumez@apple.com>
1650
1651         Use SecurityOriginData more consistently in Service Worker code
1652         https://bugs.webkit.org/show_bug.cgi?id=183969
1653
1654         Reviewed by Darin Adler.
1655
1656         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
1657
1658         * WebDatabaseManager.cpp:
1659         (WebDatabaseManager::databasesWithOrigin):
1660         (WebDatabaseManager::deleteOrigin):
1661         (WebDatabaseManager::deleteDatabase):
1662         (WebDatabaseManager::setQuota):
1663         * WebSecurityOrigin.cpp:
1664         (WebSecurityOrigin::usage):
1665         (WebSecurityOrigin::quota):
1666         (WebSecurityOrigin::setQuota):
1667
1668 2018-03-23  Chris Dumez  <cdumez@apple.com>
1669
1670         Unreviewed attempt to fix Windows build after r229926.
1671
1672         * WebView.cpp:
1673
1674 2018-03-23  Brady Eidson  <beidson@apple.com>
1675
1676         Go to back/forward list items after a process-swapped navigation.
1677         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
1678
1679         Reviewed by Andy Estes.
1680
1681         * WebView.cpp:
1682         (WebView::goToBackForwardItem):
1683         (WebView::loadBackForwardListFromOtherView):
1684
1685 2018-03-23  Miguel Gomez  <magomez@igalia.com>
1686
1687         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
1688         https://bugs.webkit.org/show_bug.cgi?id=183892
1689
1690         Remove the UpdateContentsFlag parameter as it's not used anymore.
1691
1692         Reviewed by Žan Doberšek.
1693
1694         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1695         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
1696
1697 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
1698
1699         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
1700         https://bugs.webkit.org/show_bug.cgi?id=183335
1701
1702         Reviewed by Alex Christensen.
1703
1704         * Plugins/PluginDatabaseWin.cpp:
1705         * Plugins/PluginMessageThrottlerWin.cpp:
1706         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
1707         * Plugins/PluginPackageWin.cpp:
1708         (WebCore::PluginPackage::load):
1709         * Plugins/PluginView.h:
1710         * Plugins/PluginViewWin.cpp:
1711         * Plugins/npapi.cpp:
1712         * WebCoreSupport/WebFrameLoaderClient.cpp:
1713         (WebFrameLoaderClient::createPlugin):
1714         (WebFrameLoaderClient::createJavaAppletWidget):
1715         * WebView.cpp:
1716         (WebView::WebViewWndProc):
1717
1718 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
1719
1720         [Win] Layout Test fast/html/menuitem-element.html is failing.
1721         https://bugs.webkit.org/show_bug.cgi?id=179299
1722
1723         Reviewed by Per Arne Vollan.
1724
1725         * Interfaces/IWebPreferencesPrivate.idl:
1726         * WebPreferenceKeysPrivate.h:
1727         * WebPreferences.cpp:
1728         (WebPreferences::menuItemElementEnabled):
1729         (WebPreferences::setMenuItemElementEnabled):
1730         * WebPreferences.h:
1731         * WebView.cpp:
1732         (WebView::notifyPreferencesChanged):
1733         Add private web preference "menuItemElementEnabled".
1734
1735 2018-03-12  Antoine Quint  <graouts@apple.com>
1736
1737         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
1738         https://bugs.webkit.org/show_bug.cgi?id=183504
1739         <rdar://problem/38372965>
1740
1741         Reviewed by Dean Jackson and Jon Lee.
1742
1743         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
1744         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
1745
1746         * Interfaces/IWebPreferencesPrivate.idl:
1747         * WebPreferences.cpp:
1748         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
1749         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
1750         * WebPreferenceKeysPrivate.h
1751         * WebPreferences.h:
1752         * WebView.cpp:
1753         (WebView::notifyPreferencesChanged):
1754
1755 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1756
1757         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
1758         https://bugs.webkit.org/show_bug.cgi?id=183429
1759
1760         Reviewed by Mark Lam.
1761
1762         * WebFrame.cpp:
1763         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
1764
1765 2018-03-08  Tim Horton  <timothy_horton@apple.com>
1766
1767         Stop linking ApplicationServices directly
1768         https://bugs.webkit.org/show_bug.cgi?id=182867
1769         <rdar://problem/38252142>
1770
1771         Reviewed by Alex Christensen.
1772
1773         The frameworks that we use that live inside ApplicationServices
1774         have mostly moved out, so import them directly.
1775
1776         * FullscreenVideoController.cpp:
1777
1778 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1779
1780         Fix std::make_unique / new[] using system malloc
1781         https://bugs.webkit.org/show_bug.cgi?id=182975
1782
1783         Reviewed by JF Bastien.
1784
1785         Use Vector instead.
1786
1787         * MarshallingHelpers.cpp:
1788         (MarshallingHelpers::safeArrayToStringArray):
1789         (MarshallingHelpers::safeArrayToIntArray):
1790         * Plugins/PluginPackageWin.cpp:
1791         (WebCore::PluginPackage::fetchInfo):
1792         * WebPreferences.cpp:
1793         (WebPreferences::copyWebKitPreferencesToCFPreferences):
1794         * WebView.cpp:
1795         (WebView::onMenuCommand):
1796
1797 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
1798
1799         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
1800         https://bugs.webkit.org/show_bug.cgi?id=183312
1801
1802         Reviewed by Mark Lam.
1803
1804         Remove wtf/CurrentTime.h include pragma.
1805
1806         * WebDownload.cpp:
1807         * WebDownloadCFNet.cpp:
1808         * WebDropSource.cpp:
1809
1810 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
1811
1812         Remove monotonicallyIncreasingTime
1813         https://bugs.webkit.org/show_bug.cgi?id=182911
1814
1815         Reviewed by Michael Catanzaro.
1816
1817         * FullscreenVideoController.cpp:
1818         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
1819         * Plugins/PluginMessageThrottlerWin.cpp:
1820         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
1821         (WebCore::PluginMessageThrottlerWin::appendMessage):
1822         * Plugins/PluginMessageThrottlerWin.h:
1823         * WebView.cpp:
1824         (WebView::notifyAnimationStarted):
1825         * WebView.h:
1826
1827 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
1828
1829         [Win][DRT] Implement setSpatialNavigationEnabled.
1830         https://bugs.webkit.org/show_bug.cgi?id=183166
1831
1832         Reviewed by Per Arne Vollan.
1833
1834         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
1835
1836         * Interfaces/IWebPreferencesPrivate.idl:
1837         * WebPreferenceKeysPrivate.h:
1838         * WebPreferences.cpp:
1839         (WebPreferences::initializeDefaultSettings):
1840         (WebPreferences::spatialNavigationEnabled):
1841         (WebPreferences::setSpatialNavigationEnabled):
1842         * WebPreferences.h:
1843         * WebView.cpp:
1844         (WebView::notifyPreferencesChanged):
1845
1846 2018-02-28  Alex Christensen  <achristensen@webkit.org>
1847
1848         Reduce use of NetworkingContext in WebKit
1849         https://bugs.webkit.org/show_bug.cgi?id=183213
1850
1851         Reviewed by Brady Eidson.
1852
1853         * Plugins/PluginView.cpp:
1854         (WebCore::PluginView::getValueForURL):
1855
1856 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
1857
1858         Fix WebCore includes within WebKitLegacy
1859         https://bugs.webkit.org/show_bug.cgi?id=183147
1860
1861         Reviewed by Tim Horton.
1862
1863         * Plugins/PluginDatabase.cpp:
1864         * Plugins/PluginDatabaseWin.cpp:
1865         * Plugins/PluginDebug.cpp:
1866         * Plugins/PluginDebug.h:
1867         * Plugins/PluginMainThreadScheduler.cpp:
1868         * Plugins/PluginMessageThrottlerWin.cpp:
1869         * Plugins/PluginMessageThrottlerWin.h:
1870         * Plugins/PluginPackage.cpp:
1871         * Plugins/PluginPackage.h:
1872         * Plugins/PluginPackageWin.cpp:
1873         * Plugins/PluginStream.cpp:
1874         * Plugins/PluginStream.h:
1875         * Plugins/PluginView.cpp:
1876         * Plugins/PluginView.h:
1877         * Plugins/PluginViewWin.cpp:
1878         * Plugins/npapi.cpp:
1879         * WebCoreSupport/WebChromeClient.cpp:
1880         * WebCoreSupport/WebContextMenuClient.cpp:
1881         * WebCoreSupport/WebFrameLoaderClient.cpp:
1882         * WebCoreSupport/WebInspectorClient.cpp:
1883         * WebCoreSupport/WebPlatformStrategies.cpp:
1884         * WebFrame.cpp:
1885         * WebKitMessageLoop.cpp:
1886         * WebView.cpp:
1887         * storage/WebDatabaseProvider.cpp:
1888
1889 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
1890
1891         Remove currentTime() / currentTimeMS()
1892         https://bugs.webkit.org/show_bug.cgi?id=183052
1893
1894         Reviewed by Mark Lam.
1895
1896         * WebCoreSupport/WebFrameLoaderClient.cpp:
1897         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1898         * WebCoreSupport/WebFrameLoaderClient.h:
1899         * WebDownload.h:
1900         * WebDownloadCFNet.cpp:
1901         (WebDownload::didStart):
1902         (WebDownload::didReceiveData):
1903         (WebDownload::didFinish):
1904
1905 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
1906
1907         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
1908         https://bugs.webkit.org/show_bug.cgi?id=182883
1909
1910         Reviewed by Per Arne Vollan.
1911
1912         * WebKitPrefix.h:
1913
1914 2018-02-16  Dean Jackson  <dino@apple.com>
1915
1916         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
1917         https://bugs.webkit.org/show_bug.cgi?id=182894
1918
1919         Reviewed by Tim Horton.
1920
1921         Rename OPENGL_ES_2 to OPENGL_ES.
1922
1923         * WebCoreSupport/AcceleratedCompositingContext.cpp:
1924
1925 2018-02-16  Youenn Fablet  <youenn@apple.com>
1926
1927         Allow specifying which plug-ins are supported
1928         https://bugs.webkit.org/show_bug.cgi?id=182748
1929
1930         Reviewed by Chris Dumez.
1931
1932         * WebCoreSupport/WebPluginInfoProvider.cpp:
1933         (WebPluginInfoProvider::getPluginInfo):
1934         * WebCoreSupport/WebPluginInfoProvider.h:
1935
1936 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
1937
1938         WebCore headers should not be included relatively within dependent projects
1939         https://bugs.webkit.org/show_bug.cgi?id=182805
1940
1941         Reviewed by Chris Dumez.
1942
1943         * FullscreenVideoController.h:
1944
1945 2018-02-13  Commit Queue  <commit-queue@webkit.org>
1946
1947         Unreviewed, rolling out r228431.
1948         https://bugs.webkit.org/show_bug.cgi?id=182766
1949
1950         Regressed CMake build stability (Requested by dolmstead on
1951         #webkit).
1952
1953         Reverted changeset:
1954
1955         "[CMake] Make WebCore headers copies"
1956         https://bugs.webkit.org/show_bug.cgi?id=182512
1957         https://trac.webkit.org/changeset/228431
1958
1959 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
1960
1961         [CMake] Make WebCore headers copies
1962         https://bugs.webkit.org/show_bug.cgi?id=182512
1963
1964         Reviewed by Keith Miller.
1965
1966         * FullscreenVideoController.h:
1967         * Plugins/PluginDatabase.cpp:
1968         * Plugins/PluginDatabaseWin.cpp:
1969         * Plugins/PluginDebug.cpp:
1970         * Plugins/PluginMainThreadScheduler.cpp:
1971         * Plugins/PluginMessageThrottlerWin.cpp:
1972         * Plugins/PluginPackage.cpp:
1973         * Plugins/PluginPackageWin.cpp:
1974         * Plugins/PluginStream.cpp:
1975         * Plugins/PluginView.cpp:
1976         * Plugins/PluginViewWin.cpp:
1977         * Plugins/npapi.cpp:
1978         * WebKitMessageLoop.cpp:
1979         * WebKitPrefix.h:
1980         * storage/WebDatabaseProvider.cpp:
1981
1982 2018-01-13  Darin Adler  <darin@apple.com>
1983
1984         Event improvements
1985         https://bugs.webkit.org/show_bug.cgi?id=179591
1986
1987         Reviewed by Chris Dumez.
1988
1989         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
1990         * WebFrame.cpp: Ditto.
1991
1992         * WebScriptWorld.cpp:
1993         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
1994
1995         * WebView.cpp: Removed include of ScriptValue.h.
1996         (WebView::handleEditingKeyboardEvent): Updated for name change from
1997         keyEvent to underlyingPlatformEvent.
1998
1999 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
2000
2001         Remove WebCore/ForwardingHeaders directory
2002         https://bugs.webkit.org/show_bug.cgi?id=182347
2003
2004         Reviewed by Keith Miller.
2005
2006         * Plugins/PluginView.cpp:
2007         * Plugins/PluginViewWin.cpp:
2008         * WebCoreSupport/WebInspectorClient.cpp:
2009         * WebCoreSupport/WebInspectorClient.h:
2010         * WebFrame.cpp:
2011         * WebJavaScriptCollector.cpp:
2012         * WebView.cpp:
2013
2014 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2015
2016         Unreviewed, another attempt to fix the Windows build after r227479.
2017
2018         * WebFrame.cpp:
2019         (WebFrame::elementWithName):
2020
2021 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2022
2023         Unreviewed, try to fix the Windows build after r227479.
2024
2025         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
2026
2027         * WebFrame.cpp:
2028         (WebFrame::elementWithName):
2029         (WebFrame::controlsInForm):
2030
2031 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
2032
2033         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
2034         https://bugs.webkit.org/show_bug.cgi?id=181859
2035         <rdar://problem/36659886>
2036
2037         Reviewed by Alex Christensen.
2038         
2039         Use local include patch.
2040
2041         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
2042         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
2043         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
2044
2045 2018-01-17  Youenn Fablet  <youenn@apple.com>
2046
2047         Put fetch Request.keepalive behind a runtime flag
2048         https://bugs.webkit.org/show_bug.cgi?id=181592
2049
2050         Reviewed by Chris Dumez.
2051
2052         * WebPreferences.cpp:
2053         (WebPreferences::fetchAPIKeepAliveEnabled):
2054         (WebPreferences::setFetchAPIKeepAliveEnabled):
2055         * WebPreferences.h:
2056         * WebView.cpp:
2057         (WebView::notifyPreferencesChanged):
2058
2059 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2060
2061         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
2062         https://bugs.webkit.org/show_bug.cgi?id=181637
2063         <rdar://problem/36508471>
2064
2065         Reviewed by Tim Horton.
2066
2067         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
2068
2069         * WebCoreSupport/WebEditorClient.cpp:
2070         (WebEditorClient::replacementURLForResource):
2071         * WebCoreSupport/WebEditorClient.h:
2072
2073 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
2074
2075         Remove std::chrono completely
2076         https://bugs.webkit.org/show_bug.cgi?id=181186
2077
2078         Reviewed by Alex Christensen.
2079
2080         * Plugins/PluginStream.cpp:
2081         (WebCore::lastModifiedDateMS):
2082
2083 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2084
2085         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
2086         https://bugs.webkit.org/show_bug.cgi?id=181173
2087
2088         Reviewed by Alex Christensen.
2089
2090         * WebNodeHighlight.cpp:
2091         (WebNodeHighlight::update): Scale the GraphicsContext.
2092
2093 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2094
2095         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
2096         https://bugs.webkit.org/show_bug.cgi?id=181160
2097
2098         Reviewed by Myles C. Maxfield.
2099
2100         * Plugins/PluginView.cpp:
2101         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
2102
2103 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
2104
2105         Enable picture-in-picture from inline element on suspend.
2106         https://bugs.webkit.org/show_bug.cgi?id=180942
2107         rdar://problem/34745234
2108
2109         Reviewed by Jer Noble.
2110
2111         Update signature of enterVideoFullscreenForVideoElement.
2112
2113         * WebCoreSupport/WebChromeClient.cpp:
2114         (WebChromeClient::enterVideoFullscreenForVideoElement):
2115         * WebCoreSupport/WebChromeClient.h:
2116
2117 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2118
2119         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
2120         https://bugs.webkit.org/show_bug.cgi?id=180926
2121
2122         Reviewed by Tim Horton.
2123
2124         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
2125         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
2126
2127         * WebCoreSupport/WebFrameLoaderClient.cpp:
2128         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
2129         (WebFrameLoaderClient::pageID const): Ditto.
2130
2131 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
2132
2133         Remove unnecessary boolean result of start() functions
2134         https://bugs.webkit.org/show_bug.cgi?id=180856
2135
2136         Reviewed by Darin Adler.
2137
2138         It always returns true.
2139
2140         * WebDownloadCurl.cpp:
2141         (WebDownload::start):
2142
2143 2017-12-14  John Wilander  <wilander@apple.com>
2144
2145         Storage Access API: Implement frame-specific access in the document.cookie layer
2146         https://bugs.webkit.org/show_bug.cgi?id=180682
2147         <rdar://problem/35982257>
2148
2149         Reviewed by Alex Christensen.
2150
2151         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
2152         CookiesStrategy::cookieRequestHeaderFieldValue(), and
2153         CookiesStrategy::getRawCookies() now take optional parameters for
2154         frameID and pageID to allow frame-specific scoping of cookies.
2155
2156         This change makes the return values of FrameLoaderClient::frameID()
2157         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
2158         WebCore can call those getters and get the right return values in
2159         WebKit and std:nullopt in WebKitLegacy.
2160
2161         * WebCoreSupport/WebFrameLoaderClient.cpp:
2162         (WebFrameLoaderClient::pageID const):
2163         (WebFrameLoaderClient::frameID const):
2164             Now return an optional.
2165         * WebCoreSupport/WebFrameLoaderClient.h:
2166         * WebCoreSupport/WebPlatformStrategies.cpp:
2167         (WebPlatformStrategies::cookiesForDOM):
2168         (WebPlatformStrategies::setCookiesFromDOM):
2169         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2170         (WebPlatformStrategies::getRawCookies):
2171         * WebCoreSupport/WebPlatformStrategies.h:
2172
2173 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
2174
2175         [WTF] Thread::create should have Thread::tryCreate
2176         https://bugs.webkit.org/show_bug.cgi?id=180333
2177
2178         Reviewed by Darin Adler.
2179
2180         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
2181         (WKQCA::CVDisplayLink::start):
2182
2183 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2184
2185         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
2186         https://bugs.webkit.org/show_bug.cgi?id=180572
2187
2188         Reviewed by Mark Lam.
2189
2190         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
2191         Also we use Lock instead of Mutex.
2192
2193         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
2194         (WKQCA::CAD3DRenderer::swapChain):
2195         (WKQCA::CAD3DRenderer::renderAndPresent):
2196         (WKQCA::CAD3DRenderer::renderToImage):
2197         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2198         (WKQCA::CAD3DRenderer::renderInternal):
2199         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
2200         * WebKitQuartzCoreAdditions/CAView.cpp:
2201         (WKQCA::CAView::Handle::create):
2202         Return Ref<Handle> instead of RefPtr<>.
2203
2204         (WKQCA::CAView::Handle::lock):
2205         (WKQCA::CAView::Handle::view const):
2206         (WKQCA::CAView::Handle::clear):
2207         (WKQCA::views):
2208         (WKQCA::viewsNeedingUpdate):
2209         (WKQCA::CAView::releaseAllD3DResources):
2210         (WKQCA::CAView::CAView):
2211         (WKQCA::CAView::~CAView):
2212         (WKQCA::CAView::setLayer):
2213         (WKQCA::CAView::update):
2214         (WKQCA::CAView::drawToWindow):
2215         (WKQCA::CAView::drawToWindowInternal):
2216         (WKQCA::CAView::drawToImage):
2217         (WKQCA::CAView::willDraw):
2218         (WKQCA::CAView::drawIntoDC):
2219         (WKQCA::CAView::setShouldInvertColors):
2220         (WKQCA::CAView::scheduleNextDraw):
2221         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2222         (WKQCA::CAView::contextDidChange):
2223         (WKQCA::CAView::updateSoon):
2224         (WKQCA::CAView::updateViewsNow):
2225         (WKQCA::CAView::d3dDevice9):
2226         (WKQCA::CAView::Handle::mutex): Deleted.
2227         (WKQCA::globalStateMutex): Deleted.
2228         (): Deleted.
2229         * WebKitQuartzCoreAdditions/CAView.h:
2230
2231 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
2232
2233         Use StaticLock instead of NeverDestroyed<Lock>
2234         https://bugs.webkit.org/show_bug.cgi?id=180507
2235
2236         Reviewed by Saam Barati.
2237
2238         * WebLocalizableStrings.cpp:
2239         (findCachedString):
2240         (cacheString):
2241         (mainBundleLocStrings): Deleted.
2242         (frameworkLocStringsMutex): Deleted.
2243
2244 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
2245
2246         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
2247         https://bugs.webkit.org/show_bug.cgi?id=180431
2248         <rdar://problem/34531264>
2249
2250         Reviewed by Simon Fraser.
2251
2252         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
2253         'override' to make sure this doesn't break in the future.
2254
2255         * WebView.cpp:
2256         (WebView::notifyAnimationStarted):
2257         (WebView::paintContents):
2258         * WebView.h:
2259
2260 2017-11-23  Darin Adler  <darin@apple.com>
2261
2262         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2263         https://bugs.webkit.org/show_bug.cgi?id=179981
2264
2265         Reviewed by Sam Weinig.
2266
2267         * WebView.cpp:
2268         (WebView::searchFor): Use |= instead of | to build FindOptions.
2269         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
2270         (WebView::findString): Create FindOptions with |=; the old code just passed a
2271         WebKit FindOptions through without converting to WebCore::FindOptions.
2272
2273 2017-11-23  Darin Adler  <darin@apple.com>
2274
2275         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2276         https://bugs.webkit.org/show_bug.cgi?id=179907
2277
2278         Reviewed by Sam Weinig.
2279
2280         * Plugins/PluginDatabaseWin.cpp:
2281         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
2282         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
2283         * WebDownloadCFNet.cpp:
2284         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
2285
2286         * WebView.cpp:
2287         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
2288         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
2289         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
2290         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
2291         the code does not cause any change in behavior.
2292
2293 2017-11-22  Ali Juma  <ajuma@chromium.org>
2294
2295         Implement VisualViewport API attributes
2296         https://bugs.webkit.org/show_bug.cgi?id=179385
2297
2298         Reviewed by Frédéric Wang.
2299
2300         Add a VisualViewportAPI preference.
2301
2302         * Interfaces/IWebPreferencesPrivate.idl:
2303         * WebPreferenceKeysPrivate.h:
2304         * WebPreferences.cpp:
2305         (WebPreferences::initializeDefaultSettings):
2306         (WebPreferences::visualViewportAPIEnabled):
2307         (WebPreferences::setVisualViewportAPIEnabled):
2308         * WebPreferences.h:
2309         * WebView.cpp:
2310         (WebView::notifyPreferencesChanged):
2311
2312 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2313
2314         Unreviewed, rolling out r225093.
2315         https://bugs.webkit.org/show_bug.cgi?id=179938
2316
2317         Compilation failed on WinCairo 64-bit Release (Requested by
2318         fredw on #webkit).
2319
2320         Reverted changeset:
2321
2322         "Implement VisualViewport API attributes"
2323         https://bugs.webkit.org/show_bug.cgi?id=179385
2324         https://trac.webkit.org/changeset/225093
2325
2326 2017-11-21  Ali Juma  <ajuma@chromium.org>
2327
2328         Implement VisualViewport API attributes
2329         https://bugs.webkit.org/show_bug.cgi?id=179385
2330
2331         Reviewed by Frédéric Wang.
2332
2333         Add a VisualViewportAPI preference.
2334
2335         * Interfaces/IWebPreferencesPrivate.idl:
2336         * WebPreferenceKeysPrivate.h:
2337         * WebPreferences.cpp:
2338         (WebPreferences::initializeDefaultSettings):
2339         (WebPreferences::visualViewportAPIEnabled):
2340         (WebPreferences::setVisualViewportAPIEnabled):
2341         * WebPreferences.h:
2342         * WebView.cpp:
2343         (WebView::notifyPreferencesChanged):
2344
2345 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2346
2347         Clean up old URL parser remnants
2348         https://bugs.webkit.org/show_bug.cgi?id=179573
2349
2350         Reviewed by Darin Adler.
2351
2352         * WebCoreSupport/WebContextMenuClient.cpp:
2353         (WebContextMenuClient::searchWithGoogle):
2354         Use https if we do end up searching with google.
2355
2356 2017-11-12  Darin Adler  <darin@apple.com>
2357
2358         More is<> and downcast<>, less static_cast<>
2359         https://bugs.webkit.org/show_bug.cgi?id=179600
2360
2361         Reviewed by Chris Dumez.
2362
2363         * WebView.cpp:
2364         (WebView::handleEditingKeyboardEvent): Use downcast.
2365
2366 2017-11-09  Christopher Reid  <chris.reid@sony.com>
2367
2368         Use enum classes within FileSystem
2369         https://bugs.webkit.org/show_bug.cgi?id=175172
2370
2371         Reviewed by Darin Adler.
2372
2373         * Plugins/PluginDatabase.cpp:
2374
2375 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
2376
2377         [Win] Add WebKitQuartzCoreAdditions library.
2378         https://bugs.webkit.org/show_bug.cgi?id=179331
2379
2380         Reviewed by Alex Christensen.
2381
2382         * WebKitQuartzCoreAdditions: Added.
2383         * WebKitQuartzCoreAdditions/API: Added.
2384         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
2385         (toImage):
2386         (WKCACFImageGetWidth):
2387         (WKCACFImageGetHeight):
2388         (WKCACFImageCopyFileMapping):
2389         (WKCACFImageCreateWithImage):
2390         (WKCACFImageFinalize):
2391         (WKCACFImageCopyFormattingDescription):
2392         (WKCACFImageCopyDebugDescription):
2393         (WKCACFImageGetTypeID):
2394         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
2395         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
2396         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
2397         (toView):
2398         (toImpl):
2399         (WKCACFViewCreate):
2400         (WKCACFViewSetLayer):
2401         (WKCACFViewUpdate):
2402         (WKCACFViewFlushContext):
2403         (WKCACFViewInvalidateRects):
2404         (WKCACFViewCanDraw):
2405         (WKCACFViewDraw):
2406         (WKCACFViewCopyDrawnImage):
2407         (WKCACFViewDrawIntoDC):
2408         (contextDidChangeCallback):
2409         (WKCACFViewSetContextDidChangeCallback):
2410         (WKCACFViewGetLastCommitTime):
2411         (WKCACFViewSetContextUserData):
2412         (WKCACFViewGetContext):
2413         (WKCACFViewFinalize):
2414         (WKCACFViewCopyFormattingDescription):
2415         (WKCACFViewCopyDebugDescription):
2416         (WKCACFViewGetTypeID):
2417         (WKCACFViewSetShouldInvertColors):
2418         (WKCACFViewGetD3DDevice9):
2419         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
2420         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
2421         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
2422         (WKQCA::dllInstance):
2423         (DllMain):
2424         (WKCACFShutDown):
2425         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
2426         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
2427         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
2428         (WKQCA::d3d):
2429         (WKQCA::initialPresentationParameters):
2430         (WKQCA::CAD3DRenderer::shared):
2431         (WKQCA::CAD3DRenderer::CAD3DRenderer):
2432         (WKQCA::CAD3DRenderer::swapChain):
2433         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
2434         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
2435         (WKQCA::CAD3DRenderer::initialize):
2436         (WKQCA::D3DMatrixOrthoOffCenterRH):
2437         (WKQCA::prepareDevice):
2438         (WKQCA::updateBounds):
2439         (WKQCA::CAD3DRenderer::renderAndPresent):
2440         (WKQCA::CAD3DRenderer::renderToImage):
2441         (WKQCA::CAD3DRenderer::setDeviceIsLost):
2442         (WKQCA::CAD3DRenderer::renderInternal):
2443         (WKQCA::CAD3DRenderer::postProcess):
2444         (WKQCA::CAD3DRenderer::resetD3DDevice):
2445         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
2446         (WKQCA::CAD3DRenderer::release):
2447         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
2448         (WKQCA::D3DPostProcessingContext::sceneTexture const):
2449         (WKQCA::D3DPostProcessingContext::overlayQuad const):
2450         (WKQCA::CAD3DRenderer::d3dDevice9 const):
2451         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
2452         (WKQCA::CAView::Handle::create):
2453         (WKQCA::CAView::Handle::~Handle):
2454         (WKQCA::CAView::Handle::mutex):
2455         (WKQCA::CAView::Handle::view const):
2456         (WKQCA::CAView::Handle::clear):
2457         (WKQCA::CAView::Handle::Handle):
2458         (WKQCA::globalStateMutex):
2459         (WKQCA::registerMessageWindowClass):
2460         (WKQCA::createMessageWindow):
2461         (WKQCA::CAView::releaseAllD3DResources):
2462         (WKQCA::CAView::CAView):
2463         (WKQCA::CAView::~CAView):
2464         (WKQCA::CAView::create):
2465         (WKQCA::CAView::setContextDidChangeCallback):
2466         (WKQCA::CAView::setLayer):
2467         (WKQCA::CAView::update):
2468         (WKQCA::CAView::invalidateRects):
2469         (WKQCA::CAView::drawToWindow):
2470         (WKQCA::CAView::drawToWindowInternal):
2471         (WKQCA::CAView::drawToImage):
2472         (WKQCA::CAView::willDraw):
2473         (WKQCA::CAView::didDraw):
2474         (WKQCA::CAView::drawIntoDC):
2475         (WKQCA::CAView::setShouldInvertColors):
2476         (WKQCA::CAView::scheduleNextDraw):
2477         (WKQCA::CAView::displayLinkReachedCAMediaTime):
2478         (WKQCA::CAView::contextDidChangeCallback):
2479         (WKQCA::CAView::contextDidChange):
2480         (WKQCA::CAView::updateSoon):
2481         (WKQCA::CAView::updateViewsNow):
2482         (WKQCA::CAView::d3dDevice9):
2483         * WebKitQuartzCoreAdditions/CAView.h: Added.
2484         (WKQCA::CAView::context const):
2485         (WKQCA::CAView::canDraw const):
2486         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
2487         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
2488         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
2489         (WKQCA::CVDisplayLink::CVDisplayLink):
2490         (WKQCA::CVDisplayLink::~CVDisplayLink):
2491         (WKQCA::CVDisplayLink::create):
2492         (WKQCA::CVDisplayLink::start):
2493         (WKQCA::CVDisplayLink::stop):
2494         (WKQCA::CVDisplayLink::setPaused):
2495         (WKQCA::CVDisplayLink::runIOThread):
2496         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
2497         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
2498         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
2499         * WebKitQuartzCoreAdditions/Image.cpp: Added.
2500         (WKQCA::numBytesForSize):
2501         (WKQCA::Image::create):
2502         (WKQCA::Image::Image):
2503         (WKQCA::Image::~Image):
2504         (WKQCA::bitmapInfo):
2505         (WKQCA::Image::createDIB const):
2506         (WKQCA::Image::copyFileMapping):
2507         * WebKitQuartzCoreAdditions/Image.h: Added.
2508         (WKQCA::Image::size const):
2509         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
2510         (WKQCA::getBackBufferRectAsRenderTarget):
2511         (WKQCA::getSystemMemoryCopy):
2512         (WKQCA::copyRectToBitmap):
2513         (WKQCA::getImageCopy):
2514         (WKQCA::getBackBufferRectAsImage):
2515         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
2516         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
2517         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
2518         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
2519         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
2520
2521 2017-11-06  Christopher Reid  <chris.reid@sony.com>
2522
2523         Use enum classes within FileSystem
2524         https://bugs.webkit.org/show_bug.cgi?id=175172
2525
2526         Reviewed by Myles C. Maxfield.
2527
2528         * Plugins/PluginDatabase.cpp:
2529
2530 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
2531
2532         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
2533         https://bugs.webkit.org/show_bug.cgi?id=178333
2534
2535         Reviewed by Darin Adler.
2536
2537         * WebCoreSupport/WebFrameLoaderClient.cpp:
2538         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
2539
2540 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2541
2542         Use CompletionHandlers for redirects
2543         https://bugs.webkit.org/show_bug.cgi?id=179163
2544
2545         Reviewed by Tim Horton.
2546
2547         * Plugins/PluginStream.cpp:
2548         (WebCore::PluginStream::willSendRequest):
2549         * Plugins/PluginStream.h:
2550         (WebCore::PluginStreamClient::~PluginStreamClient):
2551         (WebCore::PluginStreamClient::streamDidFinishLoading):
2552         (WebCore::PluginStream::create):
2553         (WebCore::PluginStream::setLoadManually):
2554
2555 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2556
2557         Add a FileSystem namespace to FileSystem.cpp
2558         https://bugs.webkit.org/show_bug.cgi?id=179063
2559
2560         Reviewed by Darin Adler.
2561
2562         * Plugins/PluginDatabase.cpp:
2563         * Plugins/PluginPackage.cpp:
2564         * Plugins/PluginStream.cpp:
2565         * Plugins/PluginStream.h:
2566         * WebApplicationCache.cpp:
2567         * WebDatabaseManager.cpp:
2568         * WebDownloadCurl.cpp:
2569         * WebPreferences.cpp:
2570         * WebView.cpp:
2571
2572 2017-10-31  Alex Christensen  <achristensen@webkit.org>
2573
2574         Fix Windows build after r224260
2575
2576         * WebView.cpp:
2577         (WebView::gesture):
2578
2579 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2580
2581         [FrameView::layout cleanup] Move core layout logic to a separate class.
2582         https://bugs.webkit.org/show_bug.cgi?id=178771
2583         <rdar://problem/35166542>
2584
2585         Reviewed by Simon Fraser.
2586
2587         Move layout code out from FrameView to LayoutContext.
2588
2589         * WebFrame.cpp:
2590         (WebFrame::layout):
2591
2592 2017-10-26  Alex Christensen  <achristensen@webkit.org>
2593
2594         Fix Windows build
2595         https://bugs.webkit.org/show_bug.cgi?id=178892
2596
2597         * AccessibleBase.cpp:
2598         (MSAARole):
2599
2600 2017-10-26  Alex Christensen  <achristensen@webkit.org>
2601
2602         Fix Windows build
2603         https://bugs.webkit.org/show_bug.cgi?id=178892
2604
2605         * AccessibleBase.cpp:
2606         (AccessibleBase::state const):
2607         (MSAARole):
2608
2609 2017-10-25  Youenn Fablet  <youenn@apple.com>
2610
2611         Enable ServiceWorker to fetch resources
2612         https://bugs.webkit.org/show_bug.cgi?id=178673
2613
2614         Reviewed by Brady Eidson.
2615
2616         Added implementation to the new getters.
2617         They are noop in the context of WK1.
2618
2619         * WebCoreSupport/WebFrameLoaderClient.cpp:
2620         (WebFrameLoaderClient::pageID const):
2621         (WebFrameLoaderClient::frameID const):
2622         (WebFrameLoaderClient::sessionID const):
2623         * WebCoreSupport/WebFrameLoaderClient.h:
2624
2625 2017-10-20  Antoine Quint  <graouts@apple.com>
2626
2627         [Web Animations] Provide basic timeline and animation interfaces
2628         https://bugs.webkit.org/show_bug.cgi?id=178526
2629
2630         Reviewed by Dean Jackson.
2631
2632         Remove the WEB_ANIMATIONS compile-time flag.
2633
2634         * WebView.cpp:
2635         (WebView::notifyPreferencesChanged):
2636
2637 2017-10-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2638
2639         [Curl] Clean up old style code in old curl files.
2640         https://bugs.webkit.org/show_bug.cgi?id=178569
2641
2642         Reviewed by Ryosuke Niwa.
2643
2644         * WebCache.cpp:
2645         (WebCache::cacheFolder):
2646         (WebCache::setCacheFolder):
2647         * WebView.cpp:
2648         (WebView::setCacheModel):
2649
2650 2017-10-19  Sam Weinig  <sam@webkit.org>
2651
2652         [Settings] Move global settings into their own file
2653         https://bugs.webkit.org/show_bug.cgi?id=178512
2654
2655         Reviewed by Darin Adler.
2656
2657         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2658
2659         * WebView.cpp:
2660         (WebView::initWithFrame):
2661
2662 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2663
2664         Replace some stack raw pointers with RefPtrs within WebCore/html
2665         https://bugs.webkit.org/show_bug.cgi?id=178201
2666         <rdar://problem/34841692>
2667
2668         Reviewed by Ryosuke Niwa.
2669
2670         * WebView.cpp:
2671         (WebView::handleEditingKeyboardEvent):
2672         Change the type of node as toNode() is changed to return RefPtr.
2673
2674 2017-10-16  Sam Weinig  <sam@webkit.org>
2675
2676         [Settings] Remove all custom code from Settings.h/cpp
2677         https://bugs.webkit.org/show_bug.cgi?id=178330
2678
2679         Reviewed by Simon Fraser.
2680
2681         * WebView.cpp:
2682         (WebView::notifyPreferencesChanged):
2683             
2684             Update for naming changes of FrameFlattening now that it is an enum class.
2685
2686 2017-10-11  Chris Dumez  <cdumez@apple.com>
2687
2688         Modernize Geolocation code
2689         https://bugs.webkit.org/show_bug.cgi?id=178148
2690
2691         Reviewed by Ryosuke Niwa.
2692
2693         * WebCoreSupport/WebGeolocationClient.cpp:
2694         (WebGeolocationClient::lastPosition):
2695         * WebCoreSupport/WebGeolocationClient.h:
2696         * WebGeolocationPosition.cpp:
2697         (WebGeolocationPosition::initWithTimestamp):
2698         (core):
2699         * WebGeolocationPosition.h:
2700         (WebGeolocationPosition::impl const):
2701
2702 2017-10-05  Chris Dumez  <cdumez@apple.com>
2703
2704         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2705         https://bugs.webkit.org/show_bug.cgi?id=177957
2706
2707         Reviewed by Alex Christensen.
2708
2709         * WebCoreSupport/WebPlatformStrategies.cpp:
2710         (WebPlatformStrategies::cookiesEnabled):
2711         * WebCoreSupport/WebPlatformStrategies.h:
2712
2713 2017-10-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2714
2715         [Curl] Reimplement CurlDownload with CurlRequest
2716         https://bugs.webkit.org/show_bug.cgi?id=177779
2717
2718         Reviewed by Alex Christensen.
2719
2720         * WebDownload.h:
2721         * WebDownloadCurl.cpp:
2722         (WebDownload::init):
2723         (WebDownload::didReceiveResponse):
2724
2725 2017-09-29  Chris Dumez  <cdumez@apple.com>
2726
2727         Split some logic out of VisitedLinkStore and make it reusable
2728         https://bugs.webkit.org/show_bug.cgi?id=177575
2729
2730         Reviewed by Alex Christensen.
2731
2732         * WebCoreSupport/WebVisitedLinkStore.cpp:
2733         (WebVisitedLinkStore::addVisitedLink):
2734         (WebVisitedLinkStore::isLinkVisited):
2735         (WebVisitedLinkStore::addVisitedLinkHash):
2736         * WebCoreSupport/WebVisitedLinkStore.h:
2737
2738 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2739
2740         Make PolicyAction an encodable enum class
2741         https://bugs.webkit.org/show_bug.cgi?id=177480
2742
2743         Reviewed by Antti Koivisto.
2744
2745         * WebCoreSupport/WebFrameLoaderClient.cpp:
2746         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2747         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2748         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2749         * WebFramePolicyListener.cpp:
2750         (WebFramePolicyListener::use):
2751         (WebFramePolicyListener::download):
2752         (WebFramePolicyListener::ignore):
2753         (WebFramePolicyListener::continueSubmit):
2754
2755 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
2756
2757         [Win] fast/canvas/2d.getPath.modification.html is failing.
2758         https://bugs.webkit.org/show_bug.cgi?id=176534
2759
2760         Reviewed by Alex Christensen.
2761
2762         We need to enable Inspector additions at runtime in order to expose the getPath function.
2763
2764         * Interfaces/IWebPreferencesPrivate.idl:
2765         * WebPreferenceKeysPrivate.h:
2766         * WebPreferences.cpp:
2767         (WebPreferences::initializeDefaultSettings):
2768         (WebPreferences::setDataTransferItemsEnabled):
2769         (WebPreferences::inspectorAdditionsEnabled):
2770         (WebPreferences::setInspectorAdditionsEnabled):
2771         * WebPreferences.h:
2772         * WebView.cpp:
2773         (WebView::notifyPreferencesChanged):
2774
2775 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2776
2777         Modernize Geolocation code
2778         https://bugs.webkit.org/show_bug.cgi?id=176496
2779
2780         Reviewed by Andy Estes.
2781
2782         * WebCoreSupport/WebGeolocationClient.cpp:
2783         (WebGeolocationClient::requestPermission):
2784         * WebCoreSupport/WebGeolocationClient.h:
2785         (WebGeolocationClient::setEnableHighAccuracy): Deleted.
2786         (WebGeolocationClient::cancelPermissionRequest): Deleted.
2787         * WebGeolocationPolicyListener.h:
2788         * WebView.cpp:
2789         (WebView::initWithFrame):
2790         (WebView::geolocationDidFailWithError):
2791
2792 2017-09-07  Per Arne Vollan  <pvollan@apple.com>
2793
2794         [Win] Enable DatatransferItems in DRT.
2795         https://bugs.webkit.org/show_bug.cgi?id=176424
2796
2797         Reviewed by Brent Fulgham.
2798
2799         * Interfaces/IWebPreferencesPrivate.idl:
2800         * WebPreferenceKeysPrivate.h:
2801         * WebPreferences.cpp:
2802         (WebPreferences::initializeDefaultSettings):
2803         (WebPreferences::QueryInterface):
2804         (WebPreferences::isSecureContextAttributeEnabled):
2805         (WebPreferences::dataTransferItemsEnabled):
2806         (WebPreferences::setDataTransferItemsEnabled):
2807         * WebPreferences.h:
2808         * WebView.cpp:
2809         (WebView::notifyPreferencesChanged):
2810
2811 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2812
2813         Unreviewed build fix #2 after r221275.
2814
2815         * WebCoreSupport/WebPlatformStrategies.cpp:
2816         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
2817         to match new API.
2818         * WebCoreSupport/WebPlatformStrategies.h: Update signatures.
2819
2820 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2821
2822         Unreviewed build fix after r221275.
2823
2824         * WebCoreSupport/WebPlatformStrategies.cpp:
2825         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Correct return type and arguments
2826         to match new API.
2827
2828 2017-08-28  Per Arne Vollan  <pvollan@apple.com>
2829
2830         [Win] The test http/tests/misc/policy-delegate-called-twice.html is crashing.
2831         https://bugs.webkit.org/show_bug.cgi?id=176031
2832
2833         Reviewed by Brent Fulgham.
2834
2835         When the function in the FramePolicyFunction parameter is called, it has already been moved
2836         to an internal member by the setUpPolicyListener method, and is no longer valid. Invoke the
2837         function by using the stored member instead.
2838
2839         * WebCoreSupport/WebFrameLoaderClient.cpp:
2840         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2841         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2842         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2843
2844 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2845
2846         Unreviewed, try to fix the Windows build after r221064
2847
2848         didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.
2849
2850         * WebCoreSupport/WebEditorClient.h:
2851
2852 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2853
2854         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2855         https://bugs.webkit.org/show_bug.cgi?id=175370
2856         <rdar://problem/33799806>
2857
2858         Reviewed by Ryosuke Niwa.
2859
2860         Adjust WebEditorClient for interface changes.
2861
2862         * WebCoreSupport/WebEditorClient.h:
2863
2864 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
2865
2866         Unreviewed build fix after r221017.
2867
2868         Correct copy/paste error.
2869
2870         * WebCoreSupport/WebPlatformStrategies.cpp:
2871         (WebPlatformStrategies::cookiesForDOM):
2872
2873 2017-08-22  Brent Fulgham  <bfulgham@apple.com>
2874
2875         Unreviewed build fix after r221017.
2876
2877         * WebCoreSupport/WebPlatformStrategies.cpp:
2878         (WebPlatformStrategies::cookiesForDOM): Update for new signature.
2879         * WebCoreSupport/WebPlatformStrategies.h:
2880
2881 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2882
2883         Remove ChromeClient::scrollbarsModeDidChange
2884         https://bugs.webkit.org/show_bug.cgi?id=175805
2885
2886         Reviewed by Daniel Bates.
2887
2888         * WebCoreSupport/WebChromeClient.h:
2889
2890 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2891
2892         Remove ChromeClient::hasOpenedPopup
2893         https://bugs.webkit.org/show_bug.cgi?id=175804
2894
2895         Reviewed by Sam Weinig.
2896
2897         * WebCoreSupport/WebChromeClient.cpp:
2898         (WebChromeClient::hasOpenedPopup const): Deleted.
2899         * WebCoreSupport/WebChromeClient.h:
2900
2901 2017-08-18  Per Arne Vollan  <pvollan@apple.com>
2902
2903         [Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
2904         https://bugs.webkit.org/show_bug.cgi?id=173536
2905
2906         Reviewed by Brent Fulgham.
2907
2908         If the tree state is dirty, accessible objects are deleted while iterating over children
2909         under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
2910         style is updated before this method is called.
2911
2912         * AccessibleBase.cpp:
2913         (AccessibleBase::getAccessibilityObjectForChild):
2914
2915 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2916
2917         [PAL] Move SessionID into PAL
2918         https://bugs.webkit.org/show_bug.cgi?id=174192
2919
2920         Reviewed by Antti Koivisto.
2921
2922         * WebCoreSupport/WebFrameLoaderClient.cpp:
2923         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2924         * WebCoreSupport/WebFrameLoaderClient.h:
2925         * WebCoreSupport/WebFrameNetworkingContext.cpp:
2926         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
2927         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2928         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2929         (WebFrameNetworkingContext::storageSession const):
2930         * WebCoreSupport/WebPlatformStrategies.cpp:
2931         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2932         * WebCoreSupport/WebPlatformStrategies.h:
2933
2934 2017-08-15  Youenn Fablet  <youenn@apple.com>
2935
2936         [Cache API] Adding generic support for CacheStorage and Cache methods
2937         https://bugs.webkit.org/show_bug.cgi?id=175455
2938
2939         Reviewed by Chris Dumez.
2940
2941         * WebView.cpp:
2942         (WebView::initWithFrame):
2943
2944 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2945
2946         Composition underline color is always black
2947         https://bugs.webkit.org/show_bug.cgi?id=174675
2948
2949         Reviewed by Ryosuke Niwa.
2950
2951         * WebView.cpp:
2952         (WebView::setCompositionForTesting): Use text color for
2953         composition underline.
2954
2955 2017-08-09  Daniel Bates  <dabates@apple.com>
2956
2957         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2958         https://bugs.webkit.org/show_bug.cgi?id=175247
2959         <rdar://problem/33679804>
2960
2961         Reviewed by Brady Eidson.
2962
2963         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2964         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2965         clients that need to make use of this information at this time. If such a needs comes up
2966         then we can expose API/SPI similar to what we do for WebKit.
2967
2968         * WebCoreSupport/WebFrameLoaderClient.cpp:
2969         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2970         * WebCoreSupport/WebFrameLoaderClient.h:
2971
2972 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
2973
2974         Async image decoding for large images should be disabled after the first time a tile is painted
2975         https://bugs.webkit.org/show_bug.cgi?id=174451
2976         <rdar://problem/31246421>
2977
2978         Reviewed by Simon Fraser.
2979
2980         * FullscreenVideoController.cpp:
2981         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
2982         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2983         (AcceleratedCompositingContext::paintContents):
2984         * WebCoreSupport/AcceleratedCompositingContext.h:
2985
2986 2017-07-23  Darin Adler  <darin@apple.com>
2987
2988         More NeverDestroyed and related cleanup
2989         https://bugs.webkit.org/show_bug.cgi?id=174745
2990
2991         Reviewed by Alex Christensen.
2992
2993         * Plugins/PluginDatabase.cpp:
2994         (WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
2995         instead of DEPRECATED_DEFINE_STATIC_LOCAL.
2996         * Plugins/PluginMainThreadScheduler.cpp:
2997         (WebCore::PluginMainThreadScheduler::scheduler): Ditto.
2998         * Plugins/PluginMainThreadScheduler.h: Ditto.
2999         * WebCoreSupport/WebPlatformStrategies.cpp:
3000         (WebPlatformStrategies::initialize): Ditto.
3001         * WebCoreSupport/WebPlatformStrategies.h: Ditto.
3002         * WebHistory.cpp:
3003         (sharedHistoryStorage): Ditto.
3004         * WebLocalizableStrings.cpp:
3005         (mainBundleLocStrings): Ditto.
3006         (frameworkLocStringsMutex): Ditto.
3007         (frameworkLocStrings): Ditto.
3008         * WebView.cpp:
3009         (WebView::standardUserAgentWithApplicationName): Ditto.
3010         Also changed to keep one global string with the prefix of the user agent string
3011         instead of keeping two globals with pieces of that prefix.
3012
3013 2017-07-24  Chris Dumez  <cdumez@apple.com>
3014
3015         Make ExceptionCode a proper enumeration
3016         https://bugs.webkit.org/show_bug.cgi?id=174771
3017
3018         Reviewed by Sam Weinig.
3019
3020         Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
3021
3022         * DOMCoreClasses.cpp:
3023         (DOMDocument::createEvent):
3024         * WebView.cpp:
3025         (WebView::prepareCandidateWindow):
3026
3027 2017-07-21  Andreas Kling  <akling@apple.com>
3028
3029         Use more references in event dispatch code
3030         https://bugs.webkit.org/show_bug.cgi?id=174681
3031
3032         Reviewed by Geoffrey Garen.
3033
3034         * DOMEventsClasses.cpp:
3035         (WebEventListener::handleEvent):
3036         * DOMEventsClasses.h:
3037         * Plugins/PluginView.cpp:
3038         (WebCore::PluginView::handleEvent):
3039         * Plugins/PluginView.h:
3040
3041 2017-07-20  Brady Eidson  <beidson@apple.com>
3042
3043         Remove WebIconDatabase from WebKitLegacy/win.
3044         https://bugs.webkit.org/show_bug.cgi?id=174608
3045
3046         Reviewed by Alex Christensen.
3047
3048         It is unused.
3049         
3050         * ForEachCoClass.h:
3051
3052         * Interfaces/IWebIconDatabase.idl: Removed.
3053
3054         * Interfaces/WebKit.idl:
3055
3056         * WebCoreStatistics.cpp:
3057         (WebCoreStatistics::iconPageURLMappingCount):
3058         (WebCoreStatistics::iconRetainedPageURLCount):
3059         (WebCoreStatistics::iconRecordCount):
3060         (WebCoreStatistics::iconsWithDataCount):
3061
3062         * WebIconDatabase.cpp: Removed.
3063         * WebIconDatabase.h: Removed.
3064         * WebKitClassFactory.cpp:
3065
3066         * WebKitDLL.cpp:
3067         (shutDownWebKit):
3068
3069         * WebKitLogging.h:
3070
3071         * WebView.cpp:
3072         (WebView::close):
3073         (WebView::notifyDidAddIcon):
3074         (WebView::registerForIconNotification):
3075         (WebView::dispatchDidReceiveIconFromWebFrame):
3076         (WebView::onNotify):
3077
3078 2017-07-18  Matt Lewis  <jlewis3@apple.com>
3079
3080         Unreviewed, rolling out r219610.
3081
3082         This caused an api failure on all platforms for the test
3083         SnapshotImageLargeAsyncDecoding
3084
3085         Reverted changeset:
3086
3087         "Async image decoding for large images should be disabled
3088         after the first time a tile is painted"
3089         https://bugs.webkit.org/show_bug.cgi?id=174451
3090         http://trac.webkit.org/changeset/219610
3091
3092 2017-07-18  Said Abou-Hallawa  <sabouhallawa@apple.com>
3093
3094         Async image decoding for large images should be disabled after the first time a tile is painted
3095         https://bugs.webkit.org/show_bug.cgi?id=174451
3096
3097         Reviewed by Simon Fraser.
3098
3099         * FullscreenVideoController.cpp:
3100         (FullscreenVideoController::LayerClient::platformCALayerPaintContents):
3101         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3102         (AcceleratedCompositingContext::paintContents):
3103         * WebCoreSupport/AcceleratedCompositingContext.h:
3104
3105 2017-07-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3106
3107         [Curl] Don't start downloading more than once for same request
3108         https://bugs.webkit.org/show_bug.cgi?id=174172
3109
3110         Reviewed by Alex Christensen.
3111
3112         * WebDownloadCurl.cpp:
3113         (WebDownload::init):
3114
3115 2017-07-12  Daniel Bates  <dabates@apple.com>
3116
3117         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3118         https://bugs.webkit.org/show_bug.cgi?id=174427
3119
3120         Rubber-stamped by Brady Eidson.
3121
3122         * Plugins/PluginView.cpp:
3123         (WebCore::PluginView::start):
3124         (WebCore::PluginView::getURLNotify):
3125         (WebCore::PluginView::getURL):
3126         (WebCore::PluginView::handlePost):
3127
3128 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3129
3130         [WTF] Move SoftLinking.h into WTF
3131         https://bugs.webkit.org/show_bug.cgi?id=174000
3132
3133         Reviewed by Alex Christensen.
3134
3135         * WebKitClassFactory.cpp:
3136         * WebView.cpp:
3137
3138 2017-07-05  Brady Eidson  <beidson@apple.com>
3139
3140         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3141         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3142
3143         Reviewed by Alex Christensen.
3144
3145         Adopt to the new constructor for FrameLoadRequest.
3146
3147         * Plugins/PluginView.cpp:
3148         (WebCore::PluginView::start):
3149         (WebCore::PluginView::getURLNotify):
3150         (WebCore::PluginView::getURL):
3151         (WebCore::PluginView::handlePost):
3152
3153 2017-07-03  Brady Eidson  <beidson@apple.com>
3154
3155         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3156         https://bugs.webkit.org/show_bug.cgi?id=174073
3157
3158         Reviewed by Andy Estes.
3159
3160         * WebCoreSupport/WebFrameLoaderClient.cpp:
3161         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3162         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3163         * WebCoreSupport/WebFrameLoaderClient.h:
3164
3165 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3166
3167         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3168         https://bugs.webkit.org/show_bug.cgi?id=174004
3169
3170         Reviewed by Simon Fraser.
3171
3172         * WebCoreSupport/WebFrameLoaderClient.cpp:
3173         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3174
3175 2017-06-30  Daniel Bates  <dabates@apple.com>
3176
3177         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3178         https://bugs.webkit.org/show_bug.cgi?id=165160
3179         <rdar://problem/29451999>
3180
3181         Reviewed by Brady Eidson.
3182
3183         Pass the document that is requesting the load to the loader.
3184
3185         * Plugins/PluginView.cpp:
3186         (WebCore::PluginView::start):
3187         (WebCore::PluginView::getURLNotify):
3188         (WebCore::PluginView::getURL):
3189         (WebCore::PluginView::handlePost):
3190
3191 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3192
3193         Refactor drag start codepaths to plumb a DragItem to client layers
3194         https://bugs.webkit.org/show_bug.cgi?id=173832
3195         Work towards <rdar://problem/32236827>
3196
3197         Reviewed by Ryosuke Niwa and Tim Horton.
3198
3199         Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
3200
3201         * WebCoreSupport/WebDragClient.cpp:
3202         (WebDragClient::startDrag):
3203         * WebCoreSupport/WebDragClient.h:
3204
3205 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3206
3207         Remove excessive headers from JavaScriptCore
3208         https://bugs.webkit.org/show_bug.cgi?id=173812
3209
3210         Reviewed by Darin Adler.
3211
3212         * Plugins/PluginPackage.cpp:
3213
3214 2017-06-22  Daniel Bates  <dabates@apple.com>
3215
3216         Make FrameLoadRequest a move-only type
3217         https://bugs.webkit.org/show_bug.cgi?id=173682
3218
3219         Reviewed by Alex Christensen and Darin Adler.
3220
3221         A FrameLoadRequest groups together the information to perform a load into a single object
3222         that is more manageable to pass around than its constituent parts. Code that receives a
3223         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3224         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3225         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
3226
3227         * Plugins/PluginView.cpp:
3228         (WebCore::PluginView::start):
3229         (WebCore::PluginView::performRequest):
3230         (WebCore::PluginView::load):
3231         (WebCore::PluginView::getURLNotify):
3232         (WebCore::PluginView::getURL):
3233         (WebCore::PluginView::handlePost):
3234         * Plugins/PluginView.h:
3235         (WebCore::PluginRequest::PluginRequest):
3236
3237 2017-06-22  Daniel Bates  <dabates@apple.com>
3238
3239         [Win] Cleanup: Remove unnecessary include of header FrameLoadRequest.h
3240         https://bugs.webkit.org/show_bug.cgi?id=173683
3241
3242         Reviewed by Alex Christensen.
3243
3244         Neither file PluginViewWin.cpp nor WebContextMenuClient.cpp need to include
3245         header FrameLoadRequest.h. The former includes FrameLoadRequest.h indirectly
3246         by including PluginView.h. The latter does not make use of the functionality
3247         provided by FrameLoadRequest.h.
3248
3249         * Plugins/PluginViewWin.cpp:
3250         * WebCoreSupport/WebContextMenuClient.cpp:
3251
3252 2017-06-21  Daniel Bates  <dabates@apple.com>
3253
3254         Cleanup FrameLoadRequest
3255         https://bugs.webkit.org/show_bug.cgi?id=173564
3256         <rdar://problem/32903570>
3257
3258         Reviewed by Brent Fulgham.
3259
3260         * Plugins/PluginView.cpp:
3261         (WebCore::PluginView::start): Explicitly pass an empty ResourceRequest (we populate it after
3262         we instantiate the FrameLoadRequest) and pass the null-string for the target frame name as
3263         we do not have one. Use C++11 brace initialization syntax.
3264         (WebCore::PluginView::getURLNotify): Explicitly pass the null-string for the target frame
3265         name as we do not have one. Use C++11 brace initialization syntax.
3266         (WebCore::PluginView::getURL): Ditto.
3267         (WebCore::PluginView::handlePost): Move instantiation of FrameLoadRequest from the top of the
3268         function to closer to where it is actually used. Explicitly pass the null-string for the target
3269         frame name as we do not have one. Use C++11 brace initialization syntax.
3270
3271 2017-06-20  Daniel Bates  <dabates@apple.com>
3272
3273         Have FrameLoadRequest takes a Frame& instead of a Frame*
3274         https://bugs.webkit.org/show_bug.cgi?id=173614
3275         <rdar://problem/32884890>
3276
3277         Reviewed by Brent Fulgham.
3278
3279         * Plugins/PluginView.cpp:
3280         (WebCore::PluginView::performRequest):
3281         * WebFrame.cpp:
3282         (WebFrame::loadRequest):
3283
3284 2017-06-19  Chris Dumez  <cdumez@apple.com>
3285
3286         Use WTF::Function instead of std::function in more places in WebCore/
3287         https://bugs.webkit.org/show_bug.cgi?id=173535
3288
3289         Reviewed by Antti Koivisto.
3290
3291         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
3292
3293         * WebCoreSupport/WebFrameLoaderClient.cpp:
3294         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3295         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3296         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3297         (WebFrameLoaderClient::dispatchWillSubmitForm):
3298         (WebFrameLoaderClient::setUpPolicyListener):
3299         (WebFrameLoaderClient::receivedPolicyDecision):
3300         * WebCoreSupport/WebFrameLoaderClient.h:
3301
3302 2017-05-14 Frederic Wang  <fwang@igalia.com>
3303
3304         Add heuristic to avoid flattening "fullscreen" iframes
3305         https://bugs.webkit.org/show_bug.cgi?id=171914
3306
3307         Reviewed by Simon Fraser.
3308
3309         This commit ajusts the window port to internally use the new preference type for frame flattening.
3310         However, the "partial frame flattening" value is not exposed yet.
3311
3312         * WebView.cpp:
3313         (WebView::notifyPreferencesChanged): Use the new type for frame flattening.
3314
3315 2017-06-17  Chris Dumez  <cdumez@apple.com>
3316
3317         Use WTF::Function instead of std::function in WebKit2/
3318         https://bugs.webkit.org/show_bug.cgi?id=173504
3319
3320         Reviewed by Darin Adler.
3321
3322         Use WTF::Function instead of std::function in WebKit2/ to avoid
3323         unnecessary copying.
3324
3325         * Plugins/PluginStream.cpp:
3326         (WebCore::PluginStream::willSendRequest):
3327         * Plugins/PluginStream.h:
3328
3329 2017-06-16  Sam Weinig  <sam@webkit.org>
3330
3331         [WebIDL] Remove custom bindings for HTMLDocument
3332         https://bugs.webkit.org/show_bug.cgi?id=173444
3333
3334         Reviewed by Darin Adler.
3335
3336         * DOMHTMLClasses.cpp:
3337         (DOMHTMLDocument::write):
3338         (DOMHTMLDocument::writeln):
3339         Update for new signature of write/writeln.
3340
3341 2017-06-16  Daniel Bates  <dabates@apple.com>
3342
3343         Cleanup: WebContextMenuClient::searchWithGoogle() should parse URL using URL { URL { }, ... }
3344         instead of URL { ParsedURLString, ... }
3345         https://bugs.webkit.org/show_bug.cgi?id=173495
3346         <rdar://problem/32827445>
3347
3348         Reviewed by Alex Christensen.
3349
3350         URL(ParsedURLString, ...) should only be used with a string that was the result of URL::string().
3351         Otherwise, it will cause an assertion failure if the canonicalized URL differs from the string.
3352         Although it is unlikely that the hardcoded string in WebContextMenuClient::searchWithGoogle()
3353         would differ from the canonicalized URL it is best practice to use URL(URL(), ...) to
3354         parse an arbitrary string that looks like a URL.
3355
3356         Also modernize the code using C++14 idioms.
3357
3358         * WebCoreSupport/WebContextMenuClient.cpp:
3359         (WebContextMenuClient::searchWithGoogle):
3360
3361 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
3362
3363         [Win] WebKit shouldn't include the forwarding header of WebKit itself
3364         https://bugs.webkit.org/show_bug.cgi?id=173352
3365
3366         Reviewed by Alex Christensen.
3367
3368         * WebKitPrefix.h: Include WebKit.h of DerivedSources/WebKit instead of DerivedSources/ForwardingHeaders.
3369
3370 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
3371
3372         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
3373         https://bugs.webkit.org/show_bug.cgi?id=173318
3374
3375         Reviewed by Darin Adler.
3376
3377         The logical frame size is currently calculated by scaling the frame size in pixels,
3378         and rounding the coordinates to the nearest integers. The computed logical frame
3379         size will in some cases be smaller than the scaled frame size in pixels, since it is
3380         represented as an IntSize. In these cases, the bottom line will not be painted.
3381         Instead of calculating the logical frame size by rounding the scaled frame in
3382         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
3383
3384         * WebCoreSupport/WebFrameLoaderClient.cpp:
3385         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3386
3387 2017-06-13  Daniel Bates  <dabates@apple.com>
3388
3389         Implement W3C Secure Contexts Draft Specification
3390         https://bugs.webkit.org/show_bug.cgi?id=158121
3391         <rdar://problem/26012994>
3392
3393         Reviewed by Brent Fulgham.
3394
3395         Part 4
3396
3397         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3398
3399         * Interfaces/IWebPreferencesPrivate.idl: Bump the version.
3400         * WebPreferenceKeysPrivate.h:
3401         * WebPreferences.cpp:
3402         (WebPreferences::initializeDefaultSettings):
3403         (WebPreferences::QueryInterface):
3404         (WebPreferences::setIsSecureContextAttributeEnabled):
3405         (WebPreferences::isSecureContextAttributeEnabled):
3406         * WebPreferences.h:
3407         * WebView.cpp:
3408         (WebView::notifyPreferencesChanged):
3409
3410 2017-06-13  Per Arne Vollan  <pvollan@apple.com>
3411
3412         [Win] WebKit fails to paint the bottom lines of the window at 125% scale.
3413         https://bugs.webkit.org/show_bug.cgi?id=173318
3414
3415         Reviewed by Alex Christensen.
3416
3417         The logical frame size is currently calculated by scaling the frame size in pixels,
3418         and rounding the coordinates to the nearest integers. The computed logical frame
3419         size will in some cases be smaller than the scaled frame size in pixels, since it is
3420         represented as an IntSize. In these cases, the bottom line will not be painted.
3421         Instead of calculating the logical frame size by rounding the scaled frame in
3422         pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
3423  
3424         * WebView.cpp:
3425         (WebView::sizeChanged):
3426
3427 2017-06-13  Sam Weinig  <sam@webkit.org>
3428
3429         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
3430         https://bugs.webkit.org/show_bug.cgi?id=80733
3431
3432         Reviewed by Chris Dumez.
3433
3434         * WebFrame.cpp:
3435         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
3436
3437 2017-06-12  Daewoong Jang  <daewoong.jang@navercorp.com>
3438
3439         Remove WebCore::unloadModule and related data types
3440         https://bugs.webkit.org/show_bug.cgi?id=173231
3441
3442         Reviewed by Darin Adler.
3443
3444         * Plugins/PlatformModule.h: Added.
3445         (WebCore::PlatformModuleVersion::PlatformModuleVersion):
3446         * Plugins/PluginPackage.cpp:
3447         (WebCore::PluginPackage::freeLibraryTimerFired):
3448         * Plugins/PluginPackage.h:
3449
3450 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3451
3452         [iOS DnD] Add a hook to perform two-step drops in editable content
3453         https://bugs.webkit.org/show_bug.cgi?id=172992
3454         <rdar://problem/32590174>
3455
3456         Reviewed by Tim Horton.
3457
3458         Add a stub implementation for performTwoStepDrop on Windows.
3459
3460         * WebCoreSupport/WebEditorClient.h:
3461
3462 2017-06-04  Konstantin Tokarev  <annulen@yandex.ru>
3463
3464         Fix build of Windows-specific code with ICU 59.1
3465         https://bugs.webkit.org/show_bug.cgi?id=172729
3466
3467         Reviewed by Darin Adler.
3468
3469         Fix conversions from WTF::String to wchar_t* and vice versa.
3470
3471         * Plugins/PluginDatabaseWin.cpp:
3472         (WebCore::addPluginPathsFromRegistry):
3473         (WebCore::PluginDatabase::getPluginPathsInDirectories):
3474         (WebCore::addMozillaPluginDirectories):
3475         (WebCore::addWindowsMediaPlayerPluginDirectory):
3476         (WebCore::addAdobeAcrobatPluginDirectory):
3477         (WebCore::addJavaPluginDirectory):
3478         (WebCore::safariPluginsDirectory):
3479         (WebCore::addMacromediaPluginDirectories):
3480         * Plugins/PluginPackageWin.cpp:
3481         (WebCore::getVersionInfo):
3482         (WebCore::PluginPackage::fetchInfo):
3483         (WebCore::PluginPackage::load):
3484         * Plugins/PluginViewWin.cpp:
3485         (WebCore::PluginView::handlePostReadFile):
3486
3487 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
3488
3489         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
3490         https://bugs.webkit.org/show_bug.cgi?id=172709
3491
3492         Reviewed by Brent Fulgham.
3493
3494         Add method to exit fullscreen mode.
3495
3496         * Interfaces/IWebViewPrivate.idl:
3497         * WebView.cpp:
3498         (WebView::exitFullscreenIfNeeded):
3499         * WebView.h:
3500
3501 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
3502
3503         [Win] Create unique network storage session for each DRT.
3504         https://bugs.webkit.org/show_bug.cgi?id=172540
3505
3506         Reviewed by Brent Fulgham.
3507
3508         During layout testing, each DRT instance should have its own network storage session.
3509
3510         * Interfaces/IWebPreferencesPrivate.idl:
3511         * WebPreferences.cpp:
3512         (WebPreferences::switchNetworkLoaderToNewTestingSession):
3513         * WebPreferences.h:
3514
3515 2017-05-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3516
3517         [WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
3518         https://bugs.webkit.org/show_bug.cgi?id=172535
3519
3520         Reviewed by Konstantin Tokarev.
3521
3522         * WebCoreSupport/AcceleratedCompositingContext.cpp:
3523         (AcceleratedCompositingContext::paintContents): Append the fifth argument.
3524         * WebCoreSupport/AcceleratedCompositingContext.h: Ditto.
3525
3526 2017-05-14  Per Arne Vollan  <pvollan@apple.com>
3527
3528         [Win] fast/cookies/local-file-can-set-cookies.html is flaky.
3529         https://bugs.webkit.org/show_bug.cgi?id=172071
3530
3531         Reviewed by Alexey Proskuryakov.
3532
3533         We need to delete all cookies after each test.
3534
3535         * Interfaces/IWebPreferencesPrivate.idl:
3536         * WebPreferences.cpp:
3537         (WebPreferences::linkPreloadEnabled):
3538         (WebPreferences::clearNetworkLoaderSession):
3539         * WebPreferences.h:
3540
3541 2017-05-13  Chris Dumez  <cdumez@apple.com>
3542
3543         Stop using RefPtr::release()
3544         https://bugs.webkit.org/show_bug.cgi?id=172074
3545
3546         Reviewed by Geoffrey Garen.