REGRESSION: editing/async-clipboard/clipboard-interfaces.html is failing in WebKit1
[WebKit-https.git] / Source / WebKitLegacy / win / ChangeLog
1 2019-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         REGRESSION: editing/async-clipboard/clipboard-interfaces.html is failing in WebKit1
4         https://bugs.webkit.org/show_bug.cgi?id=202940
5         <rdar://problem/56262298>
6
7         Reviewed by Ryosuke Niwa.
8
9         Add support for the asyncClipboardAPIEnabled feature flag in legacy WebKit on Windows.
10
11         * Interfaces/IWebPreferencesPrivate.idl:
12         * WebPreferenceKeysPrivate.h:
13         * WebPreferences.cpp:
14         (WebPreferences::initializeDefaultSettings):
15         (WebPreferences::asyncClipboardAPIEnabled):
16         (WebPreferences::setAsyncClipboardAPIEnabled):
17         * WebPreferences.h:
18         * WebView.cpp:
19         (WebView::notifyPreferencesChanged):
20
21 2019-10-14  Chris Dumez  <cdumez@apple.com>
22
23         [WK2] Have WebBackForwardCache class coordinate page caching in all WebProcesses
24         https://bugs.webkit.org/show_bug.cgi?id=202929
25         <rdar://problem/56250421>
26
27         Reviewed by Alex Christensen.
28
29         * WebCoreSupport/WebFrameLoaderClient.cpp:
30         * WebCoreSupport/WebFrameLoaderClient.h:
31
32 2019-10-12  Ryosuke Niwa  <rniwa@webkit.org>
33
34         requestIdleCallback is not enabled in DumpRenderTree on Windows
35         https://bugs.webkit.org/show_bug.cgi?id=202876
36
37         Address the forgotten review comment.
38
39         * WebPreferenceKeysPrivate.h:
40
41 2019-10-12  Ryosuke Niwa  <rniwa@webkit.org>
42
43         requestIdleCallback is not enabled in DumpRenderTree on Windows
44         https://bugs.webkit.org/show_bug.cgi?id=202876
45
46         Reviewed by Wenson Hsieh.
47
48         Added the missing plumbing to enable requestIdleCallback.
49
50         * Interfaces/IWebPreferencesPrivate.idl:
51         * WebPreferenceKeysPrivate.h:
52         * WebPreferences.cpp:
53         (WebPreferences::initializeDefaultSettings):
54         (WebPreferences::requestIdleCallbackEnabled):
55         (WebPreferences::setRequestIdleCallbackEnabled):
56         * WebPreferences.h:
57         * WebView.cpp:
58         (WebView::notifyPreferencesChanged):
59
60 2019-10-04  Alex Christensen  <achristensen@webkit.org>
61
62         Rename SchemeRegistry to LegacySchemeRegistry
63         https://bugs.webkit.org/show_bug.cgi?id=202586
64
65         Reviewed by Tim Horton.
66
67         * WebView.cpp:
68         (WebView::registerURLSchemeAsLocal):
69         (WebView::setDomainRelaxationForbiddenForURLScheme):
70         (WebView::registerURLSchemeAsSecure):
71         (WebView::registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing):
72
73 2019-09-27  Chris Dumez  <cdumez@apple.com>
74
75         Pages using WebGLRenderingContext fail to enter the back/forward cache
76         https://bugs.webkit.org/show_bug.cgi?id=202318
77         <rdar://problem/55783612>
78
79         Reviewed by Tim Horton.
80
81         * WebView.cpp:
82         (WindowCloseTimer::WindowCloseTimer):
83         (WindowCloseTimer::contextDestroyed):
84         * WebView.h:
85
86 2019-09-25  Fujii Hironori  <Hironori.Fujii@sony.com>
87
88         Unreviewed build fix for Windows ports.
89         https://bugs.webkit.org/show_bug.cgi?id=202125
90         <rdar://problem/14944104>
91
92         * WebCoreSupport/WebEditorClient.h: Added missing subFrameScrollPositionChanged.
93
94 2019-09-24  Fujii Hironori  <Hironori.Fujii@sony.com>
95
96         Remove SchemeRegistry's list of URL schemes allowing local storage in private browsing, which is unused
97         https://bugs.webkit.org/show_bug.cgi?id=202181
98
99         Unreviewed build fix for Windows ports.
100
101         ..\..\Source\WebKitLegacy\win\WebView.cpp(7342): error C2039: 'registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing': is not a member of 'WebCore::SchemeRegistry'
102
103         * WebView.cpp:
104         (WebView::registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing): Removed calling the removed function.
105
106 2019-09-21  Chris Dumez  <cdumez@apple.com>
107
108         Reduce use of SessionID::defaultSessionID() in WebKit
109         https://bugs.webkit.org/show_bug.cgi?id=202080
110
111         Reviewed by Alex Christensen.
112
113         * WebCoreSupport/WebFrameLoaderClient.cpp:
114         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
115         * WebCoreSupport/WebFrameLoaderClient.h:
116
117 2019-09-18  Chris Dumez  <cdumez@apple.com>
118
119         BlobRegistry no longer needs SessionIDs
120         https://bugs.webkit.org/show_bug.cgi?id=201936
121
122         Reviewed by Geoffrey Garen.
123
124         BlobRegistry no longer needs SessionIDs, now that we have a single session per WebProcess.
125
126         * WebCoreSupport/WebPlatformStrategies.cpp:
127
128 2019-09-16  Fujii Hironori  <Hironori.Fujii@sony.com>
129
130         [WinCairo][curl] Don't compile unused CertificateCFWin.cpp
131         https://bugs.webkit.org/show_bug.cgi?id=201860
132
133         Reviewed by Alex Christensen.
134
135         * WebMutableURLRequest.cpp: Include <WebCore/CertificateCFWin.h> only if USE(CFURLCONNECTION).
136         (WebMutableURLRequest::setClientCertificate): Don't use PCCERT_CONTEXT for curl port which is defined in WinCrypt.
137
138 2019-09-13  Fujii Hironori  <Hironori.Fujii@sony.com>
139
140         [WinCairo][WK1] Accelerated Compositing can't be disabled by using WebPreferences::setAcceleratedCompositingEnabled
141         https://bugs.webkit.org/show_bug.cgi?id=201749
142
143         Reviewed by Don Olmstead.
144
145         WebPreferences::acceleratedCompositingEnabled always returned TRUE
146         for !USE(CA). It should reflect the pref value set by
147         setAcceleratedCompositingEnabled.
148
149         * WebPreferences.cpp:
150         (WebPreferences::initializeDefaultSettings): Set kCFBooleanTrue to WebKitAcceleratedCompositingEnabledPreferenceKey even for !USE(CG).
151         (WebPreferences::acceleratedCompositingEnabled): Return the pref value for !USE(CA).
152
153 2019-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
154
155         [Win][WK1] Invert Colors inverts a part of the viewport in high DPI
156         https://bugs.webkit.org/show_bug.cgi?id=201719
157
158         Reviewed by Don Olmstead.
159
160         * WebView.cpp:
161         (WebView::paintWithDirect2D):
162         (WebView::paintIntoBackingStore):
163         Call gc.restore() after inverting the dirty rect.
164
165 2019-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
166
167         [Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
168         https://bugs.webkit.org/show_bug.cgi?id=192581
169         <rdar://problem/46651605>
170
171         Reviewed by Alex Christensen.
172
173         WebKitLegacy COM interfaces have same name methods within the old
174         and new interfaces. For example, both IWebEditingDelegate and
175         IWebEditingDelegate2 interfaces have 'shouldInsertNode' method.
176         This is a part of public API, can't be renamed.
177
178         * Interfaces/IWebEditingDelegate.idl:
179         * Interfaces/IWebViewPrivate.idl:
180         Added #pragma to ignore the warning.
181
182 2019-09-09  Fujii Hironori  <Hironori.Fujii@sony.com>
183
184         [Win][WebKitLegacy] WebKitDLL.h(53,37): warning: 'gClassNameCount' has C-linkage specified, but returns user-defined type 'HashCountedSet<WTF::String> &' which is incompatible with C [-Wreturn-type-c-linkage]
185         https://bugs.webkit.org/show_bug.cgi?id=201601
186
187         Reviewed by Ross Kirsling.
188
189         Fixed a clang-cl warning. Names which aren't dllexport-ed don't
190         need to be in a extern "C" scope because they aren't exported to
191         other DLLs.
192
193         * WebKitDLL.h: Moved some variables and gClassNameCount() out of extern "C" scope.
194
195 2019-09-06  Alex Christensen  <achristensen@webkit.org>
196
197         When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID
198         https://bugs.webkit.org/show_bug.cgi?id=201480
199
200         Reviewed by Youenn Fablet.
201
202         * WebView.cpp:
203         (WebView::notifyPreferencesChanged):
204
205 2019-09-06  Rob Buis  <rbuis@igalia.com>
206
207         Add runtime flag for lazy image loading
208         https://bugs.webkit.org/show_bug.cgi?id=199794
209
210         Reviewed by Frédéric Wang.
211
212         Remove parts of r248409 that were meant for WK1 since
213         lazy image loading is WK2 only.
214
215         * Interfaces/IWebPreferencesPrivate.idl:
216         * WebPreferenceKeysPrivate.h:
217         * WebPreferences.cpp:
218         (WebPreferences::initializeDefaultSettings):
219         (WebPreferences::setResizeObserverEnabled):
220         (WebPreferences::lazyImageLoadingEnabled): Deleted.
221         (WebPreferences::setLazyImageLoadingEnabled): Deleted.
222         * WebPreferences.h:
223         * WebView.cpp:
224         (WebView::notifyPreferencesChanged):
225
226 2019-09-05  Fujii Hironori  <Hironori.Fujii@sony.com>
227
228         [WinCairo][WK1] ASSERTION FAILED: !isAcceleratedCompositing() in WebView::updateBackingStore
229         https://bugs.webkit.org/show_bug.cgi?id=201493
230
231         Reviewed by Don Olmstead.
232
233         WebView::paint switches painting code path by checking accelerated
234         compositing enabled. However, accelerated compositing could be
235         enabled after the checking.
236
237         WebView::paint called WebView::paintCompositedContentToHDC and
238         WebCore::Page::updateRendering.
239         WebView::paintCompositedContentToHDC checks accelerated
240         compositing enabled. Then, WebCore::Page::updateRendering executes
241         JavaScript and accelerated compositing could be enabled.
242
243         * WebView.cpp:
244         (WebView::paint): Call WebCore::Page::updateRendering the
245         beginning of the function.
246
247 2019-09-03  Antti Koivisto  <antti@apple.com>
248
249         Remove redundant painting phase arguments from GraphicsLayerClient functions
250         https://bugs.webkit.org/show_bug.cgi?id=201443
251
252         Reviewed by Simon Fraser.
253
254         * WebView.cpp:
255         (WebView::paintContents):
256         * WebView.h:
257
258 2019-08-27  Mark Lam  <mark.lam@apple.com>
259
260         Refactor to use VM& instead of VM* at as many places as possible.
261         https://bugs.webkit.org/show_bug.cgi?id=201172
262
263         Reviewed by Yusuke Suzuki.
264
265         * WebFrame.cpp:
266         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
267
268 2019-08-21  Ryosuke Niwa  <rniwa@webkit.org>
269
270         Put keygen element behind a runtime flag and disable it by default
271         https://bugs.webkit.org/show_bug.cgi?id=200850
272
273         Reviewed by Antti Koivisto.
274
275         * Interfaces/IWebPreferencesPrivate.idl:
276         * WebPreferenceKeysPrivate.h:
277         * WebPreferences.cpp:
278         (WebPreferences::keygenElementEnabled):
279         (WebPreferences::setKeygenElementEnabled):
280         * WebPreferences.h:
281         * WebView.cpp:
282         (WebView::notifyPreferencesChanged):
283
284 2019-08-19  Fujii Hironori  <Hironori.Fujii@sony.com>
285
286         [WinCairo][WK1] A browser window starts as an inactive window because AcceleratedCompositingContext::acceleratedCompositingAvailable creates temporary window
287         https://bugs.webkit.org/show_bug.cgi?id=200493
288
289         Reviewed by Ross Kirsling.
290
291         Reverted r179962.
292
293         * WebCoreSupport/AcceleratedCompositingContext.cpp:
294         (AcceleratedCompositingContext::acceleratedCompositingAvailable): Deleted.
295         * WebCoreSupport/AcceleratedCompositingContext.h:
296         * WebView.cpp:
297         (WebView::notifyPreferencesChanged):
298
299 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
300
301         Remove IDB-specific quota
302         https://bugs.webkit.org/show_bug.cgi?id=196545
303         <rdar://problem/54201783>
304
305         Reviewed by Youenn Fablet.
306
307         * Interfaces/IWebDatabaseManager.idl:
308         * WebDatabaseManager.cpp:
309         (WebDatabaseManager::setIDBPerOriginQuota): Deleted.
310         * WebDatabaseManager.h:
311
312 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
313
314         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
315         https://bugs.webkit.org/show_bug.cgi?id=200620
316
317         Reviewed by Geoffrey Garen.
318
319         * FullscreenVideoController.cpp:
320         (FullscreenVideoController::FullscreenVideoController):
321         * Plugins/PluginStream.cpp:
322         (WebCore::PluginStream::didReceiveData):
323         * Plugins/PluginView.cpp:
324         (WebCore::PluginView::load):
325         * Plugins/PluginViewWin.cpp:
326         (WebCore::PluginView::wndProc):
327         * WebCoreSupport/WebChromeClient.cpp:
328         (WebChromeClient::WebChromeClient):
329         * WebCoreSupport/WebFrameLoaderClient.cpp:
330         (WebFrameLoaderClient::WebFrameLoaderClient):
331         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
332         * WebCoreSupport/WebInspectorClient.cpp:
333         (WebInspectorClient::openLocalFrontend):
334         (WebInspectorClient::highlight):
335         * WebElementPropertyBag.cpp:
336         (WebElementPropertyBag::WebElementPropertyBag):
337         * WebHistoryItem.cpp:
338         (WebHistoryItem::initFromDictionaryRepresentation):
339         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
340         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
341         * WebNotificationCenter.cpp:
342         (WebNotificationCenter::WebNotificationCenter):
343         * WebView.cpp:
344         (WebView::handleMouseEvent):
345         (WebView::registerEmbeddedViewMIMEType):
346         (WebView::enterVideoFullscreenForVideoElement):
347         (WebView::addUserScriptToGroup):
348         (WebView::addUserStyleSheetToGroup):
349         (WebView::setAcceleratedCompositing):
350
351 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
352
353         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
354         https://bugs.webkit.org/show_bug.cgi?id=200620
355
356         Reviewed by Geoffrey Garen.
357
358         * FullscreenVideoController.cpp:
359         * FullscreenVideoController.h:
360         * Plugins/PluginMessageThrottlerWin.h:
361         * WebCachedFramePlatformData.h:
362         * WebCoreSupport/AcceleratedCompositingContext.h:
363         * WebCoreSupport/WebChromeClient.h:
364         * WebCoreSupport/WebContextMenuClient.h:
365         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
366         * WebCoreSupport/WebDragClient.h:
367         * WebCoreSupport/WebEditorClient.h:
368         * WebCoreSupport/WebFrameLoaderClient.cpp:
369         * WebCoreSupport/WebGeolocationClient.h:
370         * WebCoreSupport/WebInspectorClient.h:
371         * WebDatabaseManager.cpp:
372         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
373         * WebNodeHighlight.h:
374         * WebNotificationCenter.cpp:
375         * WebNotificationCenter.h:
376
377 2019-08-15  Brent Fulgham  <bfulgham@apple.com>
378
379         [FTW] Enable CoreFoundation use if building for Apple target
380         https://bugs.webkit.org/show_bug.cgi?id=200799
381
382         Reviewed by Alex Christensen.
383
384         * FullscreenVideoController.cpp:
385         (FullscreenVideoController::FullscreenVideoController):
386         (FullscreenVideoController::enterFullscreen):
387         (FullscreenVideoController::exitFullscreen):
388         (FullscreenVideoController::createHUDWindow):
389         * FullscreenVideoController.h:
390         * WebView.cpp:
391         (WebView::exitFullscreenIfNeeded):
392
393 2019-08-15  Youenn Fablet  <youenn@apple.com>
394
395         Always create a Document with a valid SessionID
396         https://bugs.webkit.org/show_bug.cgi?id=200727
397
398         Reviewed by Alex Christensen.
399
400         Implement WebKit1 sessionID getter like done for WebKit2.
401         Either the loader client has a page in which case the page session ID is used
402         or the client has no page, in which case the default session ID is used.
403         This is the same behavior as CachedResourceLoader.
404
405         * WebCoreSupport/WebFrameLoaderClient.cpp:
406         (WebFrameLoaderClient::sessionID const):
407
408 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
409
410         Unreviewed, rolling out r248526.
411
412         Caused two IndexedDB perf tests to fail
413
414         Reverted changeset:
415
416         "Remove IDB-specific quota"
417         https://bugs.webkit.org/show_bug.cgi?id=196545
418         https://trac.webkit.org/changeset/248526
419
420 2019-08-14  Youenn Fablet  <youenn@apple.com>
421
422         ThreadableBlobRegistry::blobSize should take a SessionID as parameter
423         https://bugs.webkit.org/show_bug.cgi?id=200671
424
425         Reviewed by Alex Christensen.
426
427         * WebCoreSupport/WebPlatformStrategies.cpp:
428
429 2019-08-13  Youenn Fablet  <youenn@apple.com>
430
431         Blob registries should be keyed by session IDs
432         https://bugs.webkit.org/show_bug.cgi?id=200567
433         <rdar://problem/54120212>
434
435         Reviewed by Alex Christensen.
436
437         * WebCoreSupport/WebPlatformStrategies.cpp:
438         (WebPlatformStrategies::createBlobRegistry):
439
440 2019-08-12  Youenn Fablet  <youenn@apple.com>
441
442         Remove IDB-specific quota
443         https://bugs.webkit.org/show_bug.cgi?id=196545
444
445         Reviewed by Alex Christensen.
446
447         * Interfaces/IWebDatabaseManager.idl:
448         * WebDatabaseManager.cpp:
449         (WebDatabaseManager::setIDBPerOriginQuota): Deleted.
450         * WebDatabaseManager.h:
451
452 2019-08-09  Per Arne Vollan  <pvollan@apple.com>
453
454         [Win] Remove compiler workaround for VS2013
455         https://bugs.webkit.org/show_bug.cgi?id=200582
456
457         Reviewed by Don Olmstead.
458
459         A VS2013 compiler workaround can be removed now.
460
461         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp:
462         (DllMain):
463
464 2019-08-08  Per Arne Vollan  <pvollan@apple.com>
465
466         [Win] Fix internal build
467         https://bugs.webkit.org/show_bug.cgi?id=200519
468
469         Reviewed by Alex Christensen.
470
471         Switch to the String::wideCharacers method, since its return type is compatible with the Win32 api.
472
473         * WebDownloadCFNet.cpp:
474         (WebDownload::didFinish):
475
476 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
477
478         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
479         https://bugs.webkit.org/show_bug.cgi?id=200539
480         <rdar://problem/54082550>
481
482         Reviewed by Dean Jackson.
483
484         * AccessibleBase.cpp:
485         (AccessibleBase::get_locale):
486         * CFDictionaryPropertyBag.cpp:
487         (ConvertCFTypeToVariant):
488         (CFDictionaryPropertyBag::Read):
489         (CFDictionaryPropertyBag::Write):
490         * CFDictionaryPropertyBag.h:
491         * COMPropertyBag.h:
492         (HashType>::Read):
493         (HashType>::GetPropertyInfo):
494         * MarshallingHelpers.cpp:
495         * MarshallingHelpers.h:
496         * WebApplicationCache.cpp:
497         * WebArchive.cpp:
498         * WebArchive.h:
499         * WebCache.cpp:
500         * WebCoreSupport/WebFrameLoaderClient.cpp:
501         * WebDatabaseManager.cpp:
502         * WebHistory.cpp:
503         * WebHistoryItem.cpp:
504         * WebKitCOMAPI.cpp:
505         * WebKitCOMAPI.h:
506         * WebKitDLL.cpp:
507         * WebLocalizableStrings.cpp:
508         * WebLocalizableStrings.h:
509         * WebMutableURLRequest.cpp:
510         * WebPreferences.cpp:
511         * WebPreferences.h:
512         * WebView.cpp:
513         * WebView.h:
514
515 2019-08-08  Rob Buis  <rbuis@igalia.com>
516
517         Add runtime flag for lazy image loading
518         https://bugs.webkit.org/show_bug.cgi?id=199794
519
520         Reviewed by Darin Adler.
521
522         Set lazyImageLoading runtime flag if preference is set.
523
524         * Interfaces/IWebPreferencesPrivate.idl:
525         * WebPreferenceKeysPrivate.h:
526         * WebPreferences.cpp:
527         (WebPreferences::initializeDefaultSettings):
528         (WebPreferences::lazyImageLoadingEnabled):
529         (WebPreferences::setLazyImageLoadingEnabled):
530         * WebPreferences.h:
531         * WebView.cpp:
532         (WebView::notifyPreferencesChanged):
533
534 2019-07-28  Fujii Hironori  <Hironori.Fujii@sony.com>
535
536         [Win][WK1] Can't change Web Inspector frontend height in high DPI
537         https://bugs.webkit.org/show_bug.cgi?id=200153
538
539         Reviewed by Don Olmstead.
540
541         * WebCoreSupport/WebInspectorClient.cpp:
542         (WebInspectorFrontendClient::setAttachedWindowHeight):
543         Applied deviceScaleFactor to the argument height.
544
545 2019-07-26  Konstantin Tokarev  <annulen@yandex.ru>
546
547         [Win] Remove unused methods from WebPluginInfoProvider
548         https://bugs.webkit.org/show_bug.cgi?id=200178
549
550         Reviewed by Brent Fulgham.
551
552         These methods are guarded with PLATFORM(MAC) and have no definitions.
553         Also remove unused friend declaration.
554
555         * WebCoreSupport/WebPluginInfoProvider.h:
556
557 2019-07-25  Fujii Hironori  <Hironori.Fujii@sony.com>
558
559         [Win][WK1] The inspected webview window is misplaced after changing Web Inspector frontend window height
560         https://bugs.webkit.org/show_bug.cgi?id=200152
561
562         Reviewed by Brent Fulgham.
563
564         In WebInspectorFrontendClient::setAttachedWindowHeight, the size
565         of m_inspectedWebViewHwnd was changed to the whole host window
566         size. But, it's too tall because MiniBrowser's host window has a
567         toolbar. The toolbar height should be taken into account.
568
569         Change to the height of m_inspectedWebViewHwnd to the sum of
570         inspected WebView and inspector frontend WebView heights.
571
572         * WebCoreSupport/WebInspectorClient.cpp:
573         (WebInspectorFrontendClient::setAttachedWindowHeight):
574
575 2019-07-23  Wenson Hsieh  <wenson_hsieh@apple.com>
576
577         [macOS 10.15] Web process crashes when attempting to show the font panel via Font > Show Fonts
578         https://bugs.webkit.org/show_bug.cgi?id=200021
579         <rdar://problem/53301325>
580
581         Reviewed by Ryosuke Niwa.
582
583         Implement a new editing client hook.
584
585         * WebCoreSupport/WebEditorClient.h:
586
587 2019-07-13  Zalan Bujtas  <zalan@apple.com>
588
589         Cannot bring up custom media controls at all on v.youku.com
590         https://bugs.webkit.org/show_bug.cgi?id=199699
591         <rdar://problem/51835327>
592
593         Reviewed by Simon Fraser.
594
595         * WebActionPropertyBag.cpp:
596         (WebActionPropertyBag::Read):
597         * WebView.cpp:
598         (WebView::handleContextMenuEvent):
599         (WebView::elementAtPoint):
600
601 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
602
603         [WinCairo] ASSERTION FAILED: info.bmBitsPixel == 32 in createCairoContextWithHDC
604         https://bugs.webkit.org/show_bug.cgi?id=198323
605
606         Reviewed by Per Arne Vollan.
607
608         WebView::paint binds m_backingStoreBitmap to a DC by using
609         SelectObject. WebView::paint can be called recursively, but
610         m_backingStoreBitmap can't be bound to multiple DCs at the same
611         time. Then, SelectObject was failing in such case.
612
613         Call WebCore::Page::updateRendering before binding
614         m_backingStoreBitmap instead of after it.
615
616         Reverted r202744 change which won't be needed since this change.
617
618         * WebView.cpp:
619         (WebView::scrollBackingStore): Removed r202744's change.
620         (WebView::updateBackingStore): Removed m_page->updateRendering().
621         (WebView::paint): Do m_page->updateRendering() before binding m_backingStoreBitmap.
622         * WebView.h: Removed unused WebView::isPainting.
623
624 2019-07-02  Devin Rousso  <drousso@apple.com>
625
626         Web Inspector: Debug: "Reset Web Inspector" should also clear the saved window size and attachment side
627         https://bugs.webkit.org/show_bug.cgi?id=198956
628
629         Reviewed by Matt Baker.
630
631         * WebCoreSupport/WebInspectorClient.h:
632         * WebCoreSupport/WebInspectorClient.cpp:
633         (WebInspectorFrontendClient::resetWindowState): Added.
634
635 2019-06-30  Fujii Hironori  <Hironori.Fujii@sony.com>
636
637         [Win] Multiline mode of tooltip control does word-wrapping very slowly
638         https://bugs.webkit.org/show_bug.cgi?id=198989
639
640         Reviewed by Ross Kirsling.
641
642         * WebView.cpp:
643         (truncatedString): Added.
644         (WebView::setToolTip): Use truncatedString.
645
646 2019-06-16  Darin Adler  <darin@apple.com>
647
648         Rename AtomicString to AtomString
649         https://bugs.webkit.org/show_bug.cgi?id=195276
650
651         Reviewed by Michael Catanzaro.
652
653         * many files: Let do-webcore-rename do the renaming.
654
655 2019-05-31  Don Olmstead  <don.olmstead@sony.com>
656
657         [CMake] Add WebKit::WTF target
658         https://bugs.webkit.org/show_bug.cgi?id=198400
659
660         Reviewed by Konstantin Tokarev.
661
662         Use the WebKit::WTF target.
663
664         * WebKitQuartzCoreAdditions/CMakeLists.txt:
665
666 2019-05-30  Simon Fraser  <simon.fraser@apple.com>
667
668         Use an OptionSet<> for GraphicsLayerPaintingPhase
669         https://bugs.webkit.org/show_bug.cgi?id=198404
670
671         Reviewed by Tim Horton.
672
673         Replace GraphicsLayerPaintingPhase with OptionSet<GraphicsLayerPaintingPhase>.
674
675         No behavior change.
676
677         * WebCoreSupport/AcceleratedCompositingContext.cpp:
678         (AcceleratedCompositingContext::paintContents):
679         * WebCoreSupport/AcceleratedCompositingContext.h:
680         * WebView.cpp:
681         (WebView::paintContents):
682         * WebView.h:
683
684 2019-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
685
686         [iOS] Dropped text, attachments, and images should animate into place
687         https://bugs.webkit.org/show_bug.cgi?id=198243
688         <rdar://problem/35205373>
689
690         Reviewed by Tim Horton.
691
692         * WebCoreSupport/WebChromeClient.cpp:
693         (WebChromeClient::didFinishLoadingImageForElement):
694         * WebCoreSupport/WebChromeClient.h:
695
696 2019-05-03  Daniel Bates  <dabates@apple.com>
697
698         Pass KeyboardEvent by reference in more places
699         https://bugs.webkit.org/show_bug.cgi?id=197480
700
701         Reviewed by Wenson Hsieh.
702
703         * WebCoreSupport/WebEditorClient.cpp:
704         (WebEditorClient::handleKeyboardEvent):
705         (WebEditorClient::handleInputMethodKeydown):
706         * WebCoreSupport/WebEditorClient.h:
707         * WebView.cpp:
708         (WebView::handleEditingKeyboardEvent):
709         * WebView.h:
710
711 2019-05-02  Frederic Wang  <fwang@igalia.com>
712
713         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
714         https://bugs.webkit.org/show_bug.cgi?id=196142
715
716         This patch introduces some experimental runtime flag to let users
717         disable MathML features that are removed from MathML Core [1]. For now,
718         these features are only disabled on GTK and WPE ports.
719
720         [1] https://mathml-refresh.github.io/mathml-core/
721
722         Reviewed by Rob Buis.
723
724         * Interfaces/IWebPreferencesPrivate.idl:
725         * WebPreferenceKeysPrivate.h:
726         * WebPreferences.cpp:
727         (WebPreferences::initializeDefaultSettings):
728         (WebPreferences::coreMathMLEnabled):
729         (WebPreferences::setCoreMathMLEnabled):
730         * WebPreferences.h:
731         * WebView.cpp:
732         (WebView::notifyPreferencesChanged):
733
734 2019-04-24  Zalan Bujtas  <zalan@apple.com>
735
736         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
737         https://bugs.webkit.org/show_bug.cgi?id=196948
738         <rdar://problem/49927131>
739
740         Reviewed by Tim Horton.
741
742         * WebCoreSupport/WebChromeClient.cpp:
743         (WebChromeClient::intrinsicContentsSizeChanged const):
744         * WebCoreSupport/WebChromeClient.h:
745
746 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
747
748         Make it possible to control the renderTreeAsText output by setting options on testRunner
749         https://bugs.webkit.org/show_bug.cgi?id=197133
750
751         Reviewed by Sam Weinig.
752
753         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
754         that make sense in testing (those that don't dump unstable data like addresses), and plumb
755         these flags through the various framework layers.
756
757         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
758
759         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
760         and hand-code DumpRenderTree bindings.
761
762         Some cleanup of the TestRunners, using member initializers.
763
764         * Interfaces/IWebFramePrivate.idl:
765         * WebFrame.cpp:
766         (toRenderAsTextFlags):
767         (WebFrame::renderTreeAsExternalRepresentation):
768         (WebFrame::renderTreeAsExternalRepresentationForPrinting):
769         * WebFrame.h:
770
771 2019-04-23  Chris Dumez  <cdumez@apple.com>
772
773         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
774         https://bugs.webkit.org/show_bug.cgi?id=197097
775         <rdar://problem/50048318>
776
777         Reviewed by Alex Christensen.
778
779         * WebCoreSupport/WebFrameLoaderClient.cpp:
780         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
781         * WebCoreSupport/WebFrameLoaderClient.h:
782
783 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
784
785         [CMake][Win] Use target oriented design for WebKitLegacy
786         https://bugs.webkit.org/show_bug.cgi?id=197112
787
788         Reviewed by Konstantin Tokarev.
789
790         Fix an include directory.
791
792         * WebKitQuartzCoreAdditions/CMakeLists.txt:
793
794 2019-04-18  Jer Noble  <jer.noble@apple.com>
795
796         Refactoring: Pull all fullscreen code out of Document and into its own helper class
797         https://bugs.webkit.org/show_bug.cgi?id=197017
798
799         Reviewed by Eric Carlson.
800
801         * WebCoreSupport/WebChromeClient.cpp:
802         (WebChromeClient::createWindow):
803         * WebView.cpp:
804         (WebView::fullScreenClientWillEnterFullScreen):
805         (WebView::fullScreenClientDidEnterFullScreen):
806         (WebView::fullScreenClientWillExitFullScreen):
807         (WebView::fullScreenClientDidExitFullScreen):
808
809 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
810
811         requestAnimationFrame should execute before the next frame
812         https://bugs.webkit.org/show_bug.cgi?id=177484
813
814         Reviewed by Simon Fraser.
815
816         * WebView.cpp:
817         (WebView::updateBackingStore):
818         (WebView::flushPendingGraphicsLayerChangesSoon):
819         (WebView::flushPendingGraphicsLayerChanges):
820         Call Page::updateRendering() which implements "Update the rendering"
821         step of the HTML Event Loop specification.
822
823 2019-04-10  Devin Rousso  <drousso@apple.com>
824
825         Web Inspector: save sheet should be anchored underneath the tab bar when detached
826         https://bugs.webkit.org/show_bug.cgi?id=196722
827         <rdar://problem/49613280>
828
829         Reviewed by Timothy Hatcher.
830
831         * WebCoreSupport/WebInspectorClient.h:
832         * WebCoreSupport/WebInspectorClient.cpp:
833         (WebInspectorFrontendClient::setSheetRect): Added.
834
835 2019-04-10  Alex Christensen  <achristensen@webkit.org>
836
837         Add SPI WKNavigationResponse._downloadAttribute
838         https://bugs.webkit.org/show_bug.cgi?id=196755
839         <rdar://49587365>
840
841         Reviewed by Brady Eidson.
842
843         * WebCoreSupport/WebFrameLoaderClient.cpp:
844         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
845         * WebCoreSupport/WebFrameLoaderClient.h:
846
847 2019-04-05  Commit Queue  <commit-queue@webkit.org>
848
849         Unreviewed, rolling out r243833.
850         https://bugs.webkit.org/show_bug.cgi?id=196645
851
852         This change breaks build of WPE and GTK ports (Requested by
853         annulen on #webkit).
854
855         Reverted changeset:
856
857         "[CMake][WTF] Mirror XCode header directories"
858         https://bugs.webkit.org/show_bug.cgi?id=191662
859         https://trac.webkit.org/changeset/243833
860
861 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
862
863         [CMake][WTF] Mirror XCode header directories
864         https://bugs.webkit.org/show_bug.cgi?id=191662
865
866         Reviewed by Konstantin Tokarev.
867
868         * WebKitQuartzCoreAdditions/CMakeLists.txt:
869
870 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
871
872         Implement ResizeObserver.
873         https://bugs.webkit.org/show_bug.cgi?id=157743
874
875         Reviewed by Simon Fraser.
876
877         * Interfaces/IWebPreferencesPrivate.idl:
878         * WebPreferenceKeysPrivate.h:
879         * WebPreferences.cpp:
880         (WebPreferences::initializeDefaultSettings):
881         (WebPreferences::resizeObserverEnabled):
882         (WebPreferences::setResizeObserverEnabled):
883         * WebPreferences.h:
884         * WebView.cpp:
885         (WebView::notifyPreferencesChanged):
886
887 2019-03-17  Fujii Hironori  <Hironori.Fujii@sony.com>
888
889         [Win][WK1] Null dereference in WebFrameNetworkingContext::storageSession
890         https://bugs.webkit.org/show_bug.cgi?id=195741
891
892         Reviewed by Ross Kirsling.
893
894         * WebCoreSupport/WebFrameNetworkingContext.cpp:
895         (WebFrameNetworkingContext::storageSession const): Added a null check of frame()->page() as well as Mac port does (Bug 183455).
896
897 2019-03-13  Ryan Haddad  <ryanhaddad@apple.com>
898
899         Unreviewed attempt to fix the Windows build after r242920.
900
901         * WebCoreSupport/WebFrameLoaderClient.h:
902
903 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
904
905         [Win] Fix a slew of simple clang-cl warnings.
906         https://bugs.webkit.org/show_bug.cgi?id=195652
907
908         Reviewed by Don Olmstead.
909
910         * Interfaces/AccessibleComparable.idl: -Wmissing-braces
911         * Plugins/PluginDatabaseWin.cpp: -Wunused-function
912         (WebCore::addJavaPluginDirectory): Deleted.
913         * WebCoreSupport/AcceleratedCompositingContext.cpp:
914         (AcceleratedCompositingContext::AcceleratedCompositingContext): -Wreorder
915         * WebCoreSupport/WebEditorClient.cpp:
916         (WebEditorUndoCommand::WebEditorUndoCommand): -Wreorder
917         (undoNameForEditAction): -Wswitch
918         * WebCoreSupport/WebFrameLoaderClient.cpp:
919         (WebFrameLoaderClient::WebFrameLoaderClient): -Wswitch
920         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): -Wunused-variable
921         * WebCoreSupport/WebInspectorClient.cpp:
922         (WebInspectorFrontendClient::WebInspectorFrontendClient): -Wreorder
923         * WebCoreSupport/WebInspectorClient.h: -Winconsistent-missing-override
924         * WebError.cpp:
925         (WebError::WebError): -Wreorder
926         * WebFrame.cpp:
927         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld): -Wlogical-op-parentheses
928         * WebHistory.cpp: -Wunused-function (x5)
929         (areEqualOrClose): Deleted.
930         (addDayToSystemTime): Deleted.
931         (getDayBoundaries): Deleted.
932         (beginningOfDay): Deleted.
933         (dateKey): Deleted.
934         * WebNotificationCenter.cpp:
935         (WebNotificationCenter::removeObserver): -Wunused-variable
936         * WebView.cpp: -Wunused-function, -Wreorder
937         (WebView::addVisitedLinks): -Wunused-variable
938
939 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
940
941         Unreviewed, rolling out r242688, r242643, r242624.
942
943         Caused multiple layout test failures and crashes on iOS and macOS.
944
945         Reverted changeset:
946
947         "requestAnimationFrame should execute before the next frame"
948         https://bugs.webkit.org/show_bug.cgi?id=177484
949         https://trac.webkit.org/changeset/242624/webkit
950
951         * WebView.cpp:
952         (WebView::updateBackingStore):
953         (WebView::flushPendingGraphicsLayerChangesSoon):
954         (WebView::flushPendingGraphicsLayerChanges):
955
956 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
957
958         requestAnimationFrame should execute before the next frame
959         https://bugs.webkit.org/show_bug.cgi?id=177484
960
961         Reviewed by Simon Fraser.
962
963         * WebView.cpp:
964         (WebView::updateBackingStore):
965         (WebView::flushPendingGraphicsLayerChangesSoon):
966         (WebView::flushPendingGraphicsLayerChanges):
967         Call Page::renderingUpdate() which implements  "Update the rendering"
968         step of the HTML Event Loop specification.
969
970 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
971
972         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
973         https://bugs.webkit.org/show_bug.cgi?id=195346
974
975         Reviewed by Fujii Hironori.
976
977         * COMPropertyBag.h:
978         (HashType>::GetPropertyInfo):
979         (HashType>::LoadObject):
980         * DOMCoreClasses.cpp:
981         (DOMNode::addEventListener):
982         (DOMNode::removeEventListener):
983         (DOMWindow::addEventListener):
984         (DOMWindow::removeEventListener):
985         (DOMElement::font):
986         * DOMHTMLClasses.cpp:
987         (DOMHTMLInputElement::setValueForUser):
988         (DOMHTMLInputElement::replaceCharactersInRange):
989         * Plugins/PluginDatabaseWin.cpp:
990         (WebCore::addPluginPathsFromRegistry):
991         (WebCore::PluginDatabase::getPluginPathsInDirectories const):
992         (WebCore::addMozillaPluginDirectories):
993         (WebCore::addWindowsMediaPlayerPluginDirectory):
994         (WebCore::addAdobeAcrobatPluginDirectory):
995         (WebCore::addJavaPluginDirectory):
996         (WebCore::safariPluginsDirectory):
997         (WebCore::addMacromediaPluginDirectories):
998         * Plugins/PluginPackageWin.cpp:
999         (WebCore::getVersionInfo):
1000         (WebCore::PluginPackage::fetchInfo):
1001         (WebCore::PluginPackage::load):
1002         * Plugins/PluginViewWin.cpp:
1003         (WebCore::PluginView::handlePostReadFile):
1004         * WebCoreSupport/WebChromeClient.cpp:
1005         (WebChromeClient::runOpenPanel):
1006         * WebCoreSupport/WebEditorClient.cpp:
1007         (WebEditorClient::checkSpellingOfString):
1008         (WebEditorClient::checkGrammarOfString):
1009         * WebCoreSupport/WebInspectorClient.cpp:
1010         (WebInspectorFrontendClient::updateWindowTitle):
1011         * WebLocalizableStrings.cpp:
1012         (LocalizedString::operator LPCTSTR const):
1013         * WebView.cpp:
1014         (createContextMenuFromItems):
1015         (WebView::setToolTip):
1016         Use wchar helpers as needed.
1017
1018 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1019
1020         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
1021         https://bugs.webkit.org/show_bug.cgi?id=195053
1022         <rdar://problem/48134710>
1023
1024         Reviewed by Ryosuke Niwa.
1025
1026         * WebCoreSupport/WebEditorClient.h:
1027
1028 2019-02-20  Darin Adler  <darin@apple.com>
1029
1030         Finish removing String::format
1031         https://bugs.webkit.org/show_bug.cgi?id=194893
1032
1033         Reviewed by Daniel Bates.
1034
1035         * FullscreenVideoController.cpp:
1036         (timeToString): Use makeString and pad.
1037
1038 2019-02-27  Simon Fraser  <simon.fraser@apple.com>
1039
1040         Roll out r242014; it caused crashes in compositing logging (webkit.org/b/195141)
1041
1042         * FullscreenVideoController.cpp:
1043         (timeToString):
1044
1045 2019-02-26  Philippe Normand  <pnormand@igalia.com>
1046
1047         [WPE] Add API for webview background color configuration
1048         https://bugs.webkit.org/show_bug.cgi?id=192305
1049
1050         Reviewed by Michael Catanzaro.
1051
1052         * WebCoreSupport/WebFrameLoaderClient.cpp:
1053         (WebFrameLoaderClient::transitionToCommittedForNewPage): Create
1054         FrameView with background color.
1055
1056 2019-02-20  Darin Adler  <darin@apple.com>
1057
1058         Finish removing String::format
1059         https://bugs.webkit.org/show_bug.cgi?id=194893
1060
1061         Reviewed by Daniel Bates.
1062
1063         * FullscreenVideoController.cpp:
1064         (timeToString): Use makeString and pad.
1065
1066 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1067
1068         Input type "formatSetInlineTextDirection" is dispatched when changing paragraph-level text direction
1069         https://bugs.webkit.org/show_bug.cgi?id=194703
1070         <rdar://problem/48111775>
1071
1072         Reviewed by Ryosuke Niwa.
1073
1074         * WebCoreSupport/WebEditorClient.cpp:
1075         (undoNameForEditAction):
1076
1077 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1078
1079         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1080         https://bugs.webkit.org/show_bug.cgi?id=194670
1081         <rdar://problem/39066529>
1082
1083         Reviewed by Tim Horton.
1084
1085         * WebCoreSupport/WebEditorClient.cpp:
1086         (WebEditorClient::replacementURLForResource): Deleted.
1087         * WebCoreSupport/WebEditorClient.h:
1088
1089 2019-02-10  Darin Adler  <darin@apple.com>
1090
1091         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1092         https://bugs.webkit.org/show_bug.cgi?id=194487
1093
1094         Reviewed by Daniel Bates.
1095
1096         * WebView.cpp:
1097         (webKitVersionString): Use makeString instead of String::format.
1098
1099 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1100
1101         Allow pages to trigger programmatic paste from script on iOS
1102         https://bugs.webkit.org/show_bug.cgi?id=194271
1103         <rdar://problem/47808810>
1104
1105         Reviewed by Ryosuke Niwa.
1106
1107         * WebCoreSupport/WebEditorClient.h:
1108
1109 2019-02-06  Daniel Bates  <dabates@apple.com>
1110
1111         Standardize on ControlKey instead of CtrlKey
1112         https://bugs.webkit.org/show_bug.cgi?id=194317
1113
1114         Reviewed by Tim Horton.
1115
1116         * AccessibleBase.cpp:
1117         (AccessibleBase::get_accKeyboardShortcut):
1118         * WebView.cpp:
1119         (WebView::keyDown):
1120
1121 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
1122
1123         PageOverlayController's layers should be created lazily
1124         https://bugs.webkit.org/show_bug.cgi?id=194199
1125         rdar://problem/46571593
1126
1127         Reviewed by Tim Horton.
1128
1129         Expose PageOverlayController::hasDocumentOverlays() and hasViewOverlays()
1130         and use them to only parent the overlay-hosting layers when necessary.
1131
1132         For document overlays, RenderLayerCompositor::appendDocumentOverlayLayers() can
1133         simply do nothing if there are none. Updates are triggered via Page::installedPageOverlaysChanged(),
1134         which calls FrameView::setNeedsCompositingConfigurationUpdate() to trigger the root layer
1135         compositing updates that parents the layerWithDocumentOverlays().
1136
1137         View overlays are added to the layer tree via the DrawingArea. When we go between having
1138         none and some view overlays, Page::installedPageOverlaysChanged() calls attachViewOverlayGraphicsLayer()
1139         on the ChromeClient, and the DrawingArea responds by calling updateRootLayers() and scheduling a
1140         compositing flush (this has to be done manually because view overlay layers are outside the
1141         subtree managed by RenderLayerCompositor).
1142         
1143         Now that GraphicsLayers are ref-counted, we can let the DrawingArea simply retain its m_viewOverlayRootLayer;
1144         there is no need for RenderLayerCompositor::attachRootLayer()/detachRootLayer() to do anything with view
1145         overlay layers. This implies that a page can navigate (new FrameView) and view overlays will persist, without
1146         having to be manually removed and re-added. We can also remove the Frame argument to attachViewOverlayGraphicsLayer().
1147
1148         * WebCoreSupport/WebChromeClient.cpp:
1149         (WebChromeClient::attachViewOverlayGraphicsLayer):
1150         * WebCoreSupport/WebChromeClient.h:
1151
1152 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
1153
1154         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
1155         https://bugs.webkit.org/show_bug.cgi?id=194189
1156
1157         Reviewed by Geoffrey Garen.
1158
1159         Pass the policy check identifier around functions and store it in WebFramePolicyListener
1160         so that we can send it back to WebCore with the navigation policy decision.
1161
1162         * WebCoreSupport/WebFrameLoaderClient.cpp:
1163         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1164         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1165         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1166         (WebFrameLoaderClient::dispatchWillSubmitForm):
1167         (WebFrameLoaderClient::setUpPolicyListener):
1168         * WebCoreSupport/WebFrameLoaderClient.h:
1169
1170 2019-01-31  Alex Christensen  <achristensen@webkit.org>
1171
1172         Revert r238819 which is unneeded and caused a performance regression.
1173         https://bugs.webkit.org/show_bug.cgi?id=192272
1174         <rdar://problem/46664625>
1175
1176         * WebCoreSupport/WebFrameLoaderClient.cpp:
1177         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1178         * WebCoreSupport/WebFrameLoaderClient.h:
1179
1180 2019-01-31  Takashi Komori  <Takashi.Komori@sony.com>
1181
1182         [Curl] Fix DRT crash related to private browsing.
1183         https://bugs.webkit.org/show_bug.cgi?id=193816
1184
1185         Reviewed by Alex Christensen.
1186
1187         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1188         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1189
1190 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1191
1192         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1193         https://bugs.webkit.org/show_bug.cgi?id=193941
1194
1195         Reviewed by Alex Christensen.
1196
1197         * Plugins/PluginMessageThrottlerWin.cpp:
1198         * Plugins/PluginView.cpp:
1199         * Plugins/PluginViewWin.cpp:
1200
1201 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1202
1203         Move FileSystem to WTF
1204         https://bugs.webkit.org/show_bug.cgi?id=193602
1205
1206         Reviewed by Yusuke Suzuki.
1207
1208         * Plugins/PluginDatabase.cpp:
1209         * Plugins/PluginPackage.h:
1210         * Plugins/PluginStream.h:
1211         * WebApplicationCache.cpp:
1212         * WebDatabaseManager.cpp:
1213         * WebDownloadCurl.cpp:
1214         * WebPreferences.cpp:
1215         * WebView.cpp:
1216
1217 2019-01-22  Alex Christensen  <achristensen@webkit.org>
1218
1219         Move NetworkStorageSession ownership to NetworkProcess
1220         https://bugs.webkit.org/show_bug.cgi?id=193580
1221
1222         Reviewed by Geoff Garen.
1223
1224         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1225         (WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
1226         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1227         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
1228         (WebFrameNetworkingContext::storageSession const):
1229         * WebDownloadCFNet.cpp:
1230         (WebDownload::didReceiveAuthenticationChallenge):
1231         * WebPreferences.cpp:
1232         (WebPreferences::clearNetworkLoaderSession):
1233         (WebPreferences::switchNetworkLoaderToNewTestingSession):
1234
1235 2019-01-15  Darin Adler  <darin@apple.com>
1236
1237         Use references rather than pointers for register/unregister functions, and more
1238         https://bugs.webkit.org/show_bug.cgi?id=175028
1239
1240         Reviewed by Daniel Bates.
1241
1242         * Plugins/PluginView.cpp:
1243         (WebCore::PluginView::startOrAddToUnstartedList): Pass a reference.
1244         (WebCore::PluginView::~PluginView): Ditto.
1245         * WebView.cpp:
1246         (WebView::fullScreenClientWillEnterFullScreen): Ditto.
1247         (WebView::fullScreenClientDidEnterFullScreen): Ditto.
1248         (WebView::fullScreenClientDidExitFullScreen): Ditto.
1249
1250 2019-01-17  Per Arne Vollan  <pvollan@apple.com>
1251
1252         [Win][HighDPI] Repaint glitches when scrolling.
1253         https://bugs.webkit.org/show_bug.cgi?id=173152
1254         <rdar://problem/45269953>
1255
1256         Reviewed by Brent Fulgham.
1257
1258         Non-integral device scale factors are causing repaint glitches, because the computation of the scroll
1259         delta in pixel coordinates from the scroll delta in logical coordinates will not always be correct.
1260         Instead of blitting the scroll rectangle, repaint the entire region affected by scrolling.
1261
1262         * WebView.cpp:
1263         (WebView::scrollBackingStore):
1264
1265 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1266
1267         Stop using NetworkStorageSession::storageSession in WebCore
1268         https://bugs.webkit.org/show_bug.cgi?id=193529
1269
1270         Reviewed by Tim Horton.
1271
1272         * WebView.cpp:
1273         (WebView::initWithFrame):
1274
1275 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1276
1277         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1278         https://bugs.webkit.org/show_bug.cgi?id=193368
1279
1280         Reviewed by Geoff Garen.
1281
1282         * WebDownloadCFNet.cpp:
1283         (WebDownload::didReceiveAuthenticationChallenge):
1284
1285 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1286
1287         Fix Windows build after r240014
1288         https://bugs.webkit.org/show_bug.cgi?id=161106
1289
1290         * WebView.cpp:
1291
1292 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1293
1294         Stop using CookiesStrategy
1295         https://bugs.webkit.org/show_bug.cgi?id=161106
1296
1297         Reviewed by Don Olmstead and Antti Koivisto.
1298
1299         * Plugins/PluginView.cpp:
1300         (WebCore::PluginView::getValueForURL):
1301         (WebCore::PluginView::setValueForURL):
1302         * WebCoreSupport/WebPlatformStrategies.cpp:
1303         (WebPlatformStrategies::createBlobRegistry):
1304         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1305         (WebPlatformStrategies::cookiesForDOM): Deleted.
1306         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1307         (WebPlatformStrategies::cookiesEnabled): Deleted.
1308         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1309         (WebPlatformStrategies::getRawCookies): Deleted.
1310         (WebPlatformStrategies::deleteCookie): Deleted.
1311         * WebCoreSupport/WebPlatformStrategies.h:
1312         * WebView.cpp:
1313         (WebView::initWithFrame):
1314
1315 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1316
1317         Stop using NetworkStorageSession in WebProcess
1318         https://bugs.webkit.org/show_bug.cgi?id=193236
1319
1320         Reviewed by Don Olmstead.
1321
1322         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1323         (WebFrameNetworkingContext::storageSession const):
1324         * WebCoreSupport/WebFrameNetworkingContext.h:
1325         * WebCoreSupport/WebPlatformStrategies.cpp:
1326         (WebPlatformStrategies::cookiesForDOM):
1327         (WebPlatformStrategies::setCookiesFromDOM):
1328         (WebPlatformStrategies::cookiesEnabled):
1329         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1330         (WebPlatformStrategies::getRawCookies):
1331         (WebPlatformStrategies::deleteCookie):
1332         * WebCoreSupport/WebPlatformStrategies.h:
1333
1334 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1335
1336         Unreviewed, rolling out r239727.
1337
1338         Broke API tests
1339
1340         Reverted changeset:
1341
1342         "Stop using NetworkStorageSession in WebProcess"
1343         https://bugs.webkit.org/show_bug.cgi?id=193236
1344         https://trac.webkit.org/changeset/239727
1345
1346 2018-12-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1347
1348         Remove "using namespace std;"
1349         https://bugs.webkit.org/show_bug.cgi?id=192973
1350
1351         Reviewed by Alex Christensen.
1352
1353         * FullscreenVideoController.cpp:
1354         * WebFrame.cpp:
1355         (WebFrame::drawFooter):
1356         * WebHistory.cpp:
1357         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
1358         * WebKitQuartzCoreAdditions/CAView.cpp:
1359         * WebView.cpp:
1360         (PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
1361         (PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
1362         (WebView::setCacheModel):
1363         (WebView::maxCacheModelInAnyInstance):
1364
1365 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1366
1367         Use Ref<> as much as possible
1368         https://bugs.webkit.org/show_bug.cgi?id=192808
1369
1370         Reviewed by Alex Christensen.
1371
1372         * Plugins/PluginDatabase.cpp:
1373         (WebCore::PluginDatabase::refresh):
1374         * Plugins/PluginView.cpp:
1375         (WebCore::PluginView::mediaCanStart):
1376         (WebCore::PluginView::performRequest):
1377         (WebCore::PluginView::bindingInstance):
1378         * Plugins/PluginView.h:
1379         * WebCoreSupport/WebFrameLoaderClient.cpp:
1380         (WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
1381         (WebFrameLoaderClient::createPlugin):
1382         (WebFrameLoaderClient::createJavaAppletWidget):
1383         * WebCoreSupport/WebFrameLoaderClient.h:
1384         * WebFrame.cpp:
1385         (WebFrame::loadData):
1386         (WebFrame::loadPlainTextString):
1387         (WebFrame::loadHTMLString):
1388         * WebFrame.h:
1389         * WebKitQuartzCoreAdditions/CAView.cpp:
1390         (WKQCA::CAView::create):
1391         * WebKitQuartzCoreAdditions/CAView.h:
1392         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
1393         (WKQCA::CVDisplayLink::create):
1394         * WebKitQuartzCoreAdditions/CVDisplayLink.h:
1395         * WebKitQuartzCoreAdditions/ImageConversion.cpp:
1396         (WKQCA::getImageCopy):
1397         * WebView.cpp:
1398         (WebView::addUserScriptToGroup):
1399         (WebView::addUserStyleSheetToGroup):
1400
1401 2018-12-20  Chris Dumez  <cdumez@apple.com>
1402
1403         Use Optional::valueOr() instead of Optional::value_or()
1404         https://bugs.webkit.org/show_bug.cgi?id=192933
1405
1406         Reviewed by Geoffrey Garen.
1407
1408         * WebSecurityOrigin.cpp:
1409         (WebSecurityOrigin::port):
1410
1411 2018-12-19  Chris Dumez  <cdumez@apple.com>
1412
1413         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1414         https://bugs.webkit.org/show_bug.cgi?id=192728
1415         <rdar://problem/46746779>
1416
1417         Reviewed by Geoff Garen.
1418
1419         * Plugins/*:
1420         * WebCoreSupport/*:
1421
1422 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1423
1424         [Win][Clang][WebKitLegacy] warning: expected a qualified name after 'typename' of COMEnumVariant and COMPropertyBag
1425         https://bugs.webkit.org/show_bug.cgi?id=192617
1426
1427         Reviewed by Alex Christensen.
1428
1429         * COMEnumVariant.h:
1430         (COMEnumVariant<ContainerType>::adopt): Removed 'typename' from non dependent names.
1431         (COMEnumVariant<ContainerType>::createInstance): Ditto.
1432         (COMEnumVariant<ContainerType>::Next): Prepend 'typename' for dependent names.
1433         * COMPropertyBag.h:
1434         (HashType>::createInstance): Removed 'typename' from non dependent names.
1435         (HashType>::adopt): Ditto.
1436         (HashType>::Read): Replaced dependent name 'HashMapType::const_iterator' with 'auto'.
1437         (HashType>::GetPropertyInfo): Ditto.
1438
1439 2018-12-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1440
1441         [Win][Clang][WebKitLegacy] WebFrame.cpp: warning: delete called on non-final 'WebFrame' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
1442         https://bugs.webkit.org/show_bug.cgi?id=192618
1443
1444         Reviewed by Alex Christensen.
1445
1446         Classes which implement COM interface usually doesn't need the
1447         virtual destructor because it has Release() virtual method to
1448         destruct itself.
1449
1450         Marked 'final' such classes to suppress clang-cl's compilation
1451         warnings.
1452
1453         * COMEnumVariant.h:
1454         * COMPropertyBag.h:
1455         * DefaultDownloadDelegate.h:
1456         * DefaultPolicyDelegate.h:
1457         * MemoryStream.h:
1458         * WebActionPropertyBag.h:
1459         * WebApplicationCache.h:
1460         * WebArchive.h:
1461         * WebBackForwardList.h:
1462         * WebCache.h:
1463         * WebCoreStatistics.h:
1464         * WebCoreSupport/WebEditorClient.cpp:
1465         * WebCoreSupport/WebInspectorDelegate.h:
1466         * WebDataSource.h:
1467         * WebDatabaseManager.cpp:
1468         * WebDatabaseManager.h:
1469         * WebDownload.h:
1470         * WebDropSource.h:
1471         * WebElementPropertyBag.h:
1472         * WebError.h:
1473         * WebFrame.cpp:
1474         * WebFrame.h:
1475         * WebFramePolicyListener.h:
1476         * WebGeolocationPolicyListener.h:
1477         * WebGeolocationPosition.h:
1478         * WebHTMLRepresentation.h:
1479         * WebHistory.h:
1480         * WebHistoryItem.h:
1481         * WebInspector.h:
1482         * WebJavaScriptCollector.h:
1483         * WebKitClassFactory.h:
1484         * WebKitMessageLoop.h:
1485         * WebKitStatistics.h:
1486         * WebMutableURLRequest.h:
1487         * WebNavigationData.h:
1488         * WebNotification.h:
1489         * WebNotificationCenter.h:
1490         * WebPreferences.h:
1491         * WebResource.h:
1492         * WebScriptWorld.h:
1493         * WebSecurityOrigin.h:
1494         * WebSerializedJSValue.h:
1495         * WebTextRenderer.h:
1496         * WebURLAuthenticationChallenge.h:
1497         * WebURLAuthenticationChallengeSender.h:
1498         * WebURLCredential.h:
1499         * WebURLProtectionSpace.h:
1500         * WebURLResponse.h:
1501         * WebUserContentURLPattern.h:
1502         * WebView.cpp:
1503         * WebView.h:
1504         * WebWorkersPrivate.h:
1505
1506 2018-12-11  Fujii Hironori  <Hironori.Fujii@sony.com>
1507
1508         [Win][Clang] Fix warning -Wmissing-field-initializers
1509         https://bugs.webkit.org/show_bug.cgi?id=192584
1510
1511         Reviewed by Yusuke Suzuki.
1512
1513         Initialize a struct with '{ }' instead of '= {0}'.
1514
1515         * WebKitMessageLoop.cpp:
1516         (WebKitMessageLoop::run):
1517         * WebView.cpp:
1518         (WebView::onMenuCommand):
1519         (WebView::gesture):
1520         (WebView::setShouldInvertColors):
1521         (WebView::initializeToolTipWindow):
1522         (WebView::setToolTip):
1523         (WebView::fullScreenClientForceRepaint):
1524
1525 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1526
1527         Turn WritingDirection into an enum class
1528         https://bugs.webkit.org/show_bug.cgi?id=192401
1529         Work towards <rdar://problem/42075638>
1530
1531         Reviewed by Dan Bernstein.
1532
1533         Change WritingDirection from an enum to an enum class. No change in behavior.
1534
1535         * WebFrame.cpp:
1536         (WebFrame::setTextDirection):
1537
1538 2018-12-03  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1539
1540         Use WallTime for file time
1541         https://bugs.webkit.org/show_bug.cgi?id=192287
1542
1543         Reviewed by Darin Adler.
1544
1545         * Plugins/PluginDatabase.cpp:
1546         (WebCore::PluginDatabase::refresh):
1547
1548 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1549
1550         Fix Windows build.
1551
1552         * WebView.cpp:
1553
1554 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1555
1556         Fix Windows build.
1557
1558         * WebCoreSupport/WebFrameLoaderClient.h:
1559
1560 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1561
1562         Fix Windows build.
1563
1564         * WebCoreSupport/WebFrameLoaderClient.h:
1565
1566 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1567
1568         Move URL from WebCore to WTF
1569         https://bugs.webkit.org/show_bug.cgi?id=190234
1570
1571         Reviewed by Keith Miller.
1572
1573         * MarshallingHelpers.cpp:
1574         * MarshallingHelpers.h:
1575         * Plugins/PluginDatabase.cpp:
1576         * Plugins/PluginDatabase.h:
1577         * Plugins/PluginDatabaseWin.cpp:
1578         * Plugins/PluginStream.h:
1579         * Plugins/PluginView.h:
1580         * WebCoreSupport/WebContextMenuClient.h:
1581         * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
1582         * WebCoreSupport/WebDesktopNotificationsDelegate.h:
1583         * WebCoreSupport/WebFrameLoaderClient.h:
1584         * WebCoreSupport/WebPlatformStrategies.h:
1585         * WebCoreSupport/WebPluginInfoProvider.cpp:
1586         (WebPluginInfoProvider::webVisiblePluginInfo):
1587         * WebCoreSupport/WebPluginInfoProvider.h:
1588         * WebCoreSupport/WebVisitedLinkStore.h:
1589         * WebDataSource.cpp:
1590         * WebDownload.h:
1591         * WebElementPropertyBag.cpp:
1592         * WebFrame.h:
1593         * WebHistory.cpp:
1594         * WebHistory.h:
1595         * WebHistoryItem.cpp:
1596         * WebResource.cpp:
1597         (WebResource::WebResource):
1598         * WebResource.h:
1599         * WebSecurityOrigin.cpp:
1600         * WebURLResponse.cpp:
1601         (WebURLResponse::createInstance):
1602         * WebUserContentURLPattern.cpp:
1603         * WebView.h:
1604
1605 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1606
1607         Remove dead code from an earlier attempt at implementing safe browsing
1608         https://bugs.webkit.org/show_bug.cgi?id=192067
1609
1610         Reviewed by Chris Dumez.
1611
1612         * WebCoreSupport/WebFrameLoaderClient.cpp:
1613         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1614         * WebCoreSupport/WebFrameLoaderClient.h:
1615
1616 2018-11-26  Fujii Hironori  <Hironori.Fujii@sony.com>
1617
1618         [Clang][WebKitLegacy][Win] MarshallingHelpers.h(65,47): warning: extra qualification on member 'windowsEpochAbsoluteTime' [-Wmicrosoft-extra-qualification]
1619         https://bugs.webkit.org/show_bug.cgi?id=191959
1620
1621         Reviewed by Alex Christensen.
1622
1623         * MarshallingHelpers.h: Removed extra "MarshallingHelpers::" of windowsEpochAbsoluteTime declaration.
1624
1625 2018-11-26  Brent Fulgham  <bfulgham@apple.com>
1626
1627         [Win] Reduce the use of WKSI library calls: CoreAnimation
1628         https://bugs.webkit.org/show_bug.cgi?id=191777
1629         <rdar://problem/46140542>
1630
1631         Reviewed by Zalan Bujtas.
1632
1633         Update the Windows build of WebKit to refer to the SPI headers, rather than WebKitSystemInterface.
1634         Move a small amount of glue code from WKSI to WebCore, and remove any includes or link
1635         directives for WebKitSystemInterface.lib.
1636
1637         * FullscreenVideoController.cpp:
1638         * WebKitGraphics.cpp:
1639         * WebPreferences.cpp:
1640
1641 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1642
1643         Address post-review feedback after r238438
1644         https://bugs.webkit.org/show_bug.cgi?id=191913
1645
1646         Reviewed by Ryosuke Niwa.
1647
1648         * AccessibleTextImpl.cpp:
1649         (AccessibleText::replaceText):
1650
1651 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1652
1653         Web Inspector: "Reload Web Inspector" button no longer partially works
1654         https://bugs.webkit.org/show_bug.cgi?id=191773
1655         <rdar://problem/46139932>
1656
1657         Reviewed by Devin Rousso.
1658
1659         * WebCoreSupport/WebInspectorClient.cpp:
1660         (WebInspectorFrontendClient::reopen):
1661         * WebCoreSupport/WebInspectorClient.h:
1662
1663 2018-11-17  Devin Rousso  <drousso@apple.com>
1664
1665         Web Inspector: Network: add button to show system certificate dialog
1666         https://bugs.webkit.org/show_bug.cgi?id=191458
1667         <rdar://problem/45977019>
1668
1669         Reviewed by Joseph Pecoraro.
1670
1671         * WebCoreSupport/WebInspectorClient.h:
1672         * WebCoreSupport/WebInspectorClient.cpp:
1673         (WebInspectorFrontendClient::showCertificate): Added.
1674
1675 2018-11-16  Brent Fulgham  <bfulgham@apple.com>
1676
1677         [Win] Reduce the use of WKSI library calls: CFNetwork
1678         https://bugs.webkit.org/show_bug.cgi?id=191718
1679         <rdar://problem/46108732>
1680
1681         Reviewed by Alex Christensen.
1682
1683         Remove custom WKSI CFNetwork calls, since the SPI is already documented in PAL. Just
1684         make the same calls on Windows, like we did for iOS and macOS back in 2017.
1685
1686         * WebCache.cpp:
1687         (WebCache::cacheFolder):
1688         * WebCoreSupport/WebFrameNetworkingContext.cpp:
1689         * WebCoreSupport/WebPlatformStrategies.cpp:
1690         * WebError.cpp:
1691         (WebError::localizedDescription):
1692         (WebError::sslPeerCertificate):
1693         * WebURLResponse.cpp:
1694         (WebURLResponse::sslPeerCertificate):
1695         (WebURLResponse::certificateDictionary const):
1696         * WebView.cpp:
1697         (WebView::setCacheModel):
1698
1699 2018-11-15  Brent Fulgham  <bfulgham@apple.com>
1700
1701         [Win] Reduce the use of WKSI library calls: Font Handling
1702         https://bugs.webkit.org/show_bug.cgi?id=191701
1703         <rdar://problem/46104809>
1704
1705         Reviewed by Myles C. Maxfield.
1706
1707         Update to use the old font handling routines moved from WKSI to FontCascade.
1708
1709         * WebPreferences.cpp:
1710         (WebPreferences::setFontSmoothing):
1711         (WebPreferences::setFontSmoothingContrast):
1712         * WebView.cpp:
1713         (systemParameterChanged):
1714
1715 2018-11-14  Timothy Hatcher  <timothy@apple.com>
1716
1717         Default the view background color and text color to different values when in dark mode.
1718         https://bugs.webkit.org/show_bug.cgi?id=191607
1719         rdar://problem/46045854
1720
1721         Reviewed by Dean Jackson.
1722
1723         * WebFrame.cpp:
1724         (WebFrame::updateBackground): Drop backgroundColor.
1725         * WebCoreSupport/WebFrameLoaderClient.cpp:
1726         (WebFrameLoaderClient::transitionToCommittedForNewPage): Drop backgroundColor.
1727
1728 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1729
1730         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1731         https://bugs.webkit.org/show_bug.cgi?id=191612
1732
1733         Reviewed by Matt Baker.
1734
1735         * WebCoreSupport/WebInspectorClient.cpp:
1736         (WebInspectorFrontendClient::destroyInspectorView):
1737
1738 2018-11-12  Don Olmstead  <don.olmstead@sony.com>
1739
1740         Shipped PNGs include bad profiles: iCCP: known incorrect sRGB profile
1741         https://bugs.webkit.org/show_bug.cgi?id=189230
1742         <rdar://problem/44050379>
1743
1744         Reviewed by Joseph Pecoraro.
1745
1746         Runs all png images through zopflipng. This results in a smaller file
1747         size and takes care of this issue as a byproduct.
1748
1749         * WebKit.resources/deleteButton.png:
1750         * WebKit.resources/deleteButtonPressed.png:
1751         * WebKit.resources/fsVideoAudioVolumeHigh.png:
1752         * WebKit.resources/fsVideoAudioVolumeLow.png:
1753         * WebKit.resources/fsVideoExitFullscreen.png:
1754         * WebKit.resources/fsVideoPause.png:
1755         * WebKit.resources/fsVideoPlay.png:
1756         * WebKit.resources/missingImage.png:
1757         * WebKit.resources/nullplugin.png:
1758         * WebKit.resources/panEastCursor.png:
1759         * WebKit.resources/panIcon.png:
1760         * WebKit.resources/panNorthCursor.png:
1761         * WebKit.resources/panNorthEastCursor.png:
1762         * WebKit.resources/panNorthWestCursor.png:
1763         * WebKit.resources/panSouthCursor.png:
1764         * WebKit.resources/panSouthEastCursor.png:
1765         * WebKit.resources/panSouthWestCursor.png:
1766         * WebKit.resources/panWestCursor.png:
1767         * WebKit.resources/searchCancel.png:
1768         * WebKit.resources/searchCancelPressed.png:
1769         * WebKit.resources/searchMagnifier.png:
1770         * WebKit.resources/searchMagnifierResults.png:
1771         * WebKit.resources/textAreaResizeCorner.png:
1772         * WebKit.resources/verticalTextCursor.png:
1773         * WebKit.resources/zoomInCursor.png:
1774         * WebKit.resources/zoomOutCursor.png:
1775
1776 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1777
1778         Unreviewed Windows build fix for r238049.
1779
1780         * WebView.cpp:
1781         (WebView::initWithFrame):
1782
1783 2018-11-09  Ross Kirsling  <ross.kirsling@sony.com>
1784
1785         Unreviewed MSVC build fix after r238039 (and r238046).
1786
1787         * WebDocumentLoader.h:
1788         * WebView.cpp:
1789         (WebView::setShouldApplyMacFontAscentHack):
1790
1791 2018-11-09  Antti Koivisto  <antti@apple.com>
1792
1793         Use OptionSet for layout milestones
1794         https://bugs.webkit.org/show_bug.cgi?id=191470
1795
1796         Reviewed by Dean Jackson.
1797
1798         * WebCoreSupport/WebFrameLoaderClient.cpp:
1799         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1800         * WebCoreSupport/WebFrameLoaderClient.h:
1801
1802 2018-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1803
1804         WebHistory.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1805         https://bugs.webkit.org/show_bug.cgi?id=191455
1806
1807         Reviewed by Brent Fulgham.
1808
1809         * WebHistory.h: Marked with 'override' and removed 'virtual'.
1810
1811 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1812
1813         Add a storage limit for IndexedDB
1814         https://bugs.webkit.org/show_bug.cgi?id=190598
1815         <rdar://problem/44654715>
1816
1817         Reviewed by Chris Dumez.
1818
1819         * Interfaces/IWebDatabaseManager.idl:
1820         * WebDatabaseManager.cpp:
1821         (WebDatabaseManager::setIDBPerOriginQuota):
1822         * WebDatabaseManager.h:
1823
1824 2018-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
1825
1826         [Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
1827         https://bugs.webkit.org/show_bug.cgi?id=191105
1828
1829         Reviewed by Brent Fulgham.
1830
1831         * DOMHTMLClasses.h:
1832         (DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
1833         instead of own setNodeValue.
1834
1835 2018-10-25  Antoine Quint  <graouts@apple.com>
1836
1837         [Web Animations] Turn Web Animations CSS Integration off by default
1838         https://bugs.webkit.org/show_bug.cgi?id=190901
1839
1840         Reviewed by Dean Jackson.
1841
1842         * WebPreferences.cpp:
1843         (WebPreferences::initializeDefaultSettings):
1844
1845 2018-10-21  Fujii Hironori  <Hironori.Fujii@sony.com>
1846
1847         [Win][Clang] WebView.h: warning: 'QueryInterface' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
1848         https://bugs.webkit.org/show_bug.cgi?id=190744
1849
1850         Reviewed by Alex Christensen.
1851
1852         clang-cl reports compilation warnings for inconsistent 'override'
1853         keyword usage.
1854
1855         WebView::flushPendingGraphicsLayerChanges is used only if USE(CA).
1856         This can't be marked 'override' if !USE(CA).
1857
1858         * WebView.cpp:
1859         (WebView::flushPendingGraphicsLayerChanges): Define flushPendingGraphicsLayerChanges only if USE(CA).
1860         * WebView.h: Marked all overriding member function declarations of WebView 'override'.
1861         Declare flushPendingGraphicsLayerChanges only if USE(CA).
1862
1863 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1864
1865         Clean up FrameLoader two-state enums
1866         https://bugs.webkit.org/show_bug.cgi?id=190731
1867
1868         Reviewed by Chris Dumez.
1869
1870         * WebCoreSupport/WebFrameLoaderClient.cpp:
1871         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1872         * WebCoreSupport/WebFrameLoaderClient.h:
1873
1874 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1875
1876         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1877         https://bugs.webkit.org/show_bug.cgi?id=190675
1878
1879         Reviewed by Chris Dumez.
1880
1881         * BackForwardList.cpp:
1882         (BackForwardList::backItem):
1883         (BackForwardList::currentItem):
1884         (BackForwardList::forwardItem):
1885         (BackForwardList::backListCount const):
1886         (BackForwardList::forwardListCount const):
1887         (BackForwardList::itemAtIndex):
1888         * BackForwardList.h:
1889
1890 2018-10-16  Ryan Haddad  <ryanhaddad@apple.com>
1891
1892         Unreviewed attempt to fix the Windows build after r237112.
1893
1894         * Plugins/PluginView.cpp:
1895         (WebCore::PluginView::performRequest):
1896
1897 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1898
1899         Replace HistoryItem* with HistoryItem& where possible
1900         https://bugs.webkit.org/show_bug.cgi?id=190617
1901
1902         Reviewed by Chris Dumez.
1903
1904         * BackForwardList.cpp:
1905         (BackForwardList::goToItem):
1906         * BackForwardList.h:
1907         * WebBackForwardList.cpp:
1908         (WebBackForwardList::goToItem):
1909
1910 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1911
1912         Fix Windows build.
1913
1914         * WebView.cpp:
1915         (WebView::loadBackForwardListFromOtherView):
1916
1917 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1918
1919         Fix WinCairo build.
1920
1921         * WebView.cpp:
1922         (WebView::backForwardList):
1923
1924 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1925
1926         Modernize BackForwardClient.h
1927         https://bugs.webkit.org/show_bug.cgi?id=190610
1928
1929         Reviewed by Chris Dumez.
1930
1931         * BackForwardList.cpp:
1932         (BackForwardList::backListCount const):
1933         (BackForwardList::forwardListCount const):
1934         (BackForwardList::backListCount): Deleted.
1935         (BackForwardList::forwardListCount): Deleted.
1936         * BackForwardList.h:
1937         * WebView.cpp:
1938         (WebView::initWithFrame):
1939         (WebView::backForwardList):
1940
1941 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1942
1943         Remove unused WebView._globalHistoryItem
1944         https://bugs.webkit.org/show_bug.cgi?id=190601
1945
1946         Reviewed by Chris Dumez.
1947
1948         * WebCoreSupport/WebFrameLoaderClient.cpp:
1949         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1950         * WebCoreSupport/WebFrameLoaderClient.h:
1951         * WebView.cpp:
1952         (WebView::globalHistoryItem):
1953         (WebView::setGlobalHistoryItem): Deleted.
1954         * WebView.h:
1955
1956 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1957
1958         Remove unused parameters from FrameLoaderClient::createFrame
1959         https://bugs.webkit.org/show_bug.cgi?id=190587
1960
1961         Reviewed by Chris Dumez.
1962
1963         * WebCoreSupport/WebFrameLoaderClient.cpp:
1964         (WebFrameLoaderClient::createFrame):
1965         * WebCoreSupport/WebFrameLoaderClient.h:
1966
1967 2018-10-15  Chris Dumez  <cdumez@apple.com>
1968
1969         Unreviewed Windows build fix after r237112.
1970
1971         * Plugins/PluginView.cpp:
1972         (WebCore::PluginView::performRequest):
1973         (WebCore::PluginView::load):
1974
1975 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1976
1977         Remove InjectedBundle processing of back/forward lists
1978         https://bugs.webkit.org/show_bug.cgi?id=190459
1979
1980         Reviewed by Chris Dumez.
1981
1982         * WebCoreSupport/WebFrameLoaderClient.cpp:
1983         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1984         * WebCoreSupport/WebFrameLoaderClient.h:
1985
1986 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1987
1988         Remove ParsedURLString
1989         https://bugs.webkit.org/show_bug.cgi?id=190154
1990
1991         Reviewed by Chris Dumez.
1992
1993         * WebDownloadCurl.cpp:
1994         (WebDownload::initWithRequest):
1995         * WebURLResponse.cpp:
1996         (WebURLResponse::createInstance):
1997
1998 2018-09-28  Chris Dumez  <cdumez@apple.com>
1999
2000         Drop support for cross-origin-window-policy header
2001         https://bugs.webkit.org/show_bug.cgi?id=190081
2002
2003         Reviewed by Ryosuke Niwa.
2004
2005         * WebPreferenceKeysPrivate.h:
2006         * WebPreferences.cpp:
2007         (WebPreferences::initializeDefaultSettings):
2008         (WebPreferences::crossOriginWindowPolicySupportEnabled):
2009         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
2010         * WebView.cpp:
2011         (WebView::notifyPreferencesChanged):
2012
2013 2018-09-27  Antoine Quint  <graouts@apple.com>
2014
2015         [Web Animations] Turn Web Animations with CSS integration on
2016         https://bugs.webkit.org/show_bug.cgi?id=184819
2017         <rdar://problem/39597337>
2018
2019         Reviewed by Dean Jackson.
2020
2021         * WebPreferences.cpp:
2022         (WebPreferences::initializeDefaultSettings):
2023
2024 2018-09-21  Alex Christensen  <achristensen@webkit.org>
2025
2026         Use a Variant for FormDataElement
2027         https://bugs.webkit.org/show_bug.cgi?id=189777
2028
2029         Reviewed by Chris Dumez.
2030
2031         * WebMutableURLRequest.cpp:
2032         (WebMutableURLRequest::setHTTPBody):
2033
2034 2018-09-17  Fujii Hironori  <Hironori.Fujii@sony.com>
2035
2036         [Win][Clang][WebKitLegacy] error: cannot pass object of non-trivial type through variadic function
2037         https://bugs.webkit.org/show_bug.cgi?id=189612
2038
2039         Reviewed by Alex Christensen.
2040
2041         Non-trivial types can't be used as aruguments of LOG_ERROR and
2042         ASSERT_WITH_MESSAGE.
2043
2044         * DefaultPolicyDelegate.cpp:
2045         (DefaultPolicyDelegate::unableToImplementPolicyWithError): Apply
2046         static_cast<BSTR> to convert BString.
2047         * WebLocalizableStrings.cpp:
2048         (copyLocalizedStringFromBundle): Convert 'key' from WTF::String to
2049         char* by using 'key.utf8().data()'.
2050
2051 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
2052
2053         Unreviewed, rolling out r235953.
2054
2055         Caused layout test crashes under GuardMalloc.
2056
2057         Reverted changeset:
2058
2059         "Make GraphicsLayers ref-counted, so their tree can persist
2060         when disconnected from RenderLayerBackings"
2061         https://bugs.webkit.org/show_bug.cgi?id=189521
2062         https://trac.webkit.org/changeset/235953
2063
2064 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
2065
2066         [Win][Clang][WebKitLegacy] Fix compilation errors and warnings of WebPreferences.cpp
2067         https://bugs.webkit.org/show_bug.cgi?id=189538
2068
2069         Reviewed by Per Arne Vollan.
2070
2071         * WebPreferences.cpp:
2072         Changed the type of CFNumberTraits::Type from unsigned int to CFNumberType.
2073         (WebPreferences::migrateWebKitPreferencesToCFPreferences):
2074         Apply static_cast to the result of OR-ed CFPropertyListFormat.
2075         (WebPreferences::screenFontSubstitutionEnabled):
2076         Assign false to the content of the out variable 'enabled', not assigning 0 to the variable.
2077
2078 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
2079
2080         [Win][Clang][WebKitLegacy] error: 'static' is invalid in friend declarations
2081         https://bugs.webkit.org/show_bug.cgi?id=189539
2082
2083         Reviewed by Alex Christensen.
2084
2085         * WebCoreSupport/WebInspectorClient.h: Removed 'static' of WebInspectorWndProc friend declaration.
2086         * WebCoreSupport/WebInspectorClient.cpp:
2087         (WebInspectorWndProc): Ditto.
2088         * WebNodeHighlight.cpp: Added OverlayWndProc declaration to be called before the definition.
2089         * WebNodeHighlight.h: Removed 'static` of OverlayWndProc friend declaration.
2090
2091 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2092
2093         Refactor WebCore::EditAction to be an 8-bit enum class
2094         https://bugs.webkit.org/show_bug.cgi?id=189383
2095
2096         Reviewed by Dan Bernstein.
2097
2098         * WebCoreSupport/WebEditorClient.cpp:
2099         (undoNameForEditAction):
2100
2101 2018-09-04  Frederic Wang  <fwang@igalia.com>
2102
2103         Add basic support for ScrollIntoViewOptions
2104         https://bugs.webkit.org/show_bug.cgi?id=189258
2105
2106         Reviewed by Simon Fraser.
2107
2108         * DOMCoreClasses.cpp: Add ScrollIntoViewOptions header so that this file
2109         can build despite the new scrollIntoView function.
2110
2111 2018-08-31  Chris Dumez  <cdumez@apple.com>
2112
2113         Unreviewed Windows build fix after r235562.
2114
2115         * WebCoreSupport/WebFrameLoaderClient.cpp:
2116         (WebFrameLoaderClient::dispatchWillSubmitForm):
2117
2118 2018-08-31  Chris Dumez  <cdumez@apple.com>
2119
2120         Assertion hit in ~CompletionHandler() from ~WebFrame()
2121         https://bugs.webkit.org/show_bug.cgi?id=189199
2122         <rdar://problem/42657233>
2123
2124         Reviewed by Youenn Fablet.
2125
2126         * WebCoreSupport/WebFrameLoaderClient.cpp:
2127         (WebFrameLoaderClient::dispatchWillSubmitForm):
2128         * WebCoreSupport/WebFrameLoaderClient.h:
2129
2130 2018-08-31  Frederic Wang  <fwang@igalia.com>
2131
2132         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
2133         https://bugs.webkit.org/show_bug.cgi?id=182053
2134
2135         Reviewed by Simon Fraser.
2136
2137         Add developer flag to use standard behavior for scrolling* attributes.
2138
2139         * Interfaces/IWebPreferencesPrivate.idl:
2140         * WebPreferenceKeysPrivate.h:
2141         * WebPreferences.cpp:
2142         (WebPreferences::initializeDefaultSettings):
2143         (WebPreferences::CSSOMViewScrollingAPIEnabled):
2144         (WebPreferences::setCSSOMViewScrollingAPIEnabled):
2145         * WebPreferences.h:
2146         * WebView.cpp:
2147         (WebView::notifyPreferencesChanged):
2148
2149 2018-08-30  Don Olmstead  <don.olmstead@sony.com>
2150
2151         [CMake] Replace AVFoundationSupport.py using CMake
2152         https://bugs.webkit.org/show_bug.cgi?id=182891
2153
2154         Reviewed by Per Arne Vollan.
2155
2156         Remove references to the config.h contained in WebCore as it should
2157         not be accessible from outside of WebCore.
2158
2159         * WebKitPrefix.h:
2160
2161 2018-08-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2162
2163         [Attachment Support] Augment _WKAttachment SPI to handle NSFileWrappers in addition to NSData
2164         https://bugs.webkit.org/show_bug.cgi?id=188496
2165         <rdar://problem/43216836>
2166
2167         Reviewed by Tim Horton.
2168
2169         Adjust for changing PromisedAttachmentInfo.h to forward declare WebCore::SharedBuffer rather than include the
2170         header directly.
2171
2172         * WebCoreSupport/WebDragClient.cpp:
2173
2174 2018-08-17  Alex Christensen  <achristensen@webkit.org>
2175
2176         Add some plumbing for safe browsing
2177         https://bugs.webkit.org/show_bug.cgi?id=188709
2178
2179         Reviewed by Tim Horton.
2180
2181         * WebCoreSupport/WebFrameLoaderClient.cpp:
2182         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2183         * WebCoreSupport/WebFrameLoaderClient.h:
2184
2185 2018-08-02  David Fenton  <david_fenton@apple.com>
2186
2187         Unreviewed, rolling out r234489.
2188
2189         Caused 50+ crashes and 60+ API failures on iOS
2190
2191         Reverted changeset:
2192
2193         "[WTF] Rename String::format to String::deprecatedFormat"
2194         https://bugs.webkit.org/show_bug.cgi?id=188191
2195         https://trac.webkit.org/changeset/234489
2196
2197 2018-08-01  Tomas Popela  <tpopela@redhat.com>
2198
2199         [WTF] Rename String::format to String::deprecatedFormat
2200         https://bugs.webkit.org/show_bug.cgi?id=188191
2201
2202         Reviewed by Darin Adler.
2203
2204         It should be replaced with string concatenation.
2205
2206         * FullscreenVideoController.cpp:
2207         (timeToString):
2208         * WebView.cpp:
2209         (webKitVersionString):
2210
2211 2018-07-30  Rob Buis  <rbuis@igalia.com>
2212
2213         https://bugs.webkit.org/show_bug.cgi?id=188137
2214         Merge PlatformCookieJar functions into NetworkStorageSession
2215
2216         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
2217
2218         Reviewed by Alex Christensen.
2219
2220         * WebCoreSupport/WebPlatformStrategies.cpp:
2221         (WebPlatformStrategies::cookiesForDOM):
2222         (WebPlatformStrategies::setCookiesFromDOM):
2223         (WebPlatformStrategies::cookiesEnabled):
2224         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2225         (WebPlatformStrategies::getRawCookies):
2226         (WebPlatformStrategies::deleteCookie):
2227         * WebPreferences.cpp:
2228         (WebPreferences::clearNetworkLoaderSession):
2229
2230 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
2231
2232         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
2233         https://bugs.webkit.org/show_bug.cgi?id=187963
2234
2235         Reviewed by Alex Christensen.
2236
2237         * Plugins/PluginPackageWin.cpp:
2238         (WebCore::PluginPackage::fetchInfo):
2239         Update split/splitAllowingEmptyEntries usage.
2240
2241 2018-07-18  Antoine Quint  <graouts@apple.com>
2242
2243         [Web Animations] Interpolation between font-styles with a keyword value should be discrete
2244         https://bugs.webkit.org/show_bug.cgi?id=187722
2245
2246         Reviewed by Myles Maxfield.
2247
2248         Use isItalic() since that function knows how to handle an std::optional<FontSelectionValue>.
2249
2250         * DOMCoreClasses.cpp:
2251         (DOMElement::font):
2252
2253 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
2254
2255         Disable cross-origin-window-policy by default
2256         https://bugs.webkit.org/show_bug.cgi?id=187509
2257
2258         Reviewed by Chris Dumez.
2259
2260         * WebPreferences.cpp:
2261         (WebPreferences::initializeDefaultSettings):
2262
2263 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2264
2265         [WTF] Add user-defined literal for ASCIILiteral
2266         https://bugs.webkit.org/show_bug.cgi?id=186839
2267
2268         Reviewed by Darin Adler.
2269
2270         * Plugins/PluginStream.cpp:
2271         (WebCore::PluginStream::startStream):
2272         * WebCoreSupport/WebContextMenuClient.cpp:
2273         (WebContextMenuClient::searchWithGoogle):
2274
2275 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2276
2277         [Win] Fix build break after r232815 (SupportedPluginIdentifier)
2278         https://bugs.webkit.org/show_bug.cgi?id=186623
2279
2280         Reviewed by Youenn Fablet.
2281
2282         * WebCoreSupport/WebPluginInfoProvider.cpp:
2283         (WebPluginInfoProvider::pluginInfo):
2284         (WebPluginInfoProvider::webVisiblePluginInfo):
2285         * WebCoreSupport/WebPluginInfoProvider.h:
2286
2287 2018-06-13  Chris Dumez  <cdumez@apple.com>
2288
2289         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
2290         https://bugs.webkit.org/show_bug.cgi?id=186545
2291
2292         Reviewed by Brady Eidson.
2293
2294         Update client delegate now that parameter type has changed.
2295
2296         * WebCoreSupport/WebFrameLoaderClient.cpp:
2297         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2298         * WebCoreSupport/WebFrameLoaderClient.h:
2299
2300 2018-06-11  Chris Dumez  <cdumez@apple.com>
2301
2302         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
2303         https://bugs.webkit.org/show_bug.cgi?id=186441
2304
2305         Reviewed by Brady Eidson.
2306
2307         Rename existing flag to something a bit more generic, now that it is used for
2308         more things than bypassing the navigation policy check.
2309
2310         * WebView.cpp:
2311         (WebView::goToBackForwardItem):
2312         (WebView::loadBackForwardListFromOtherView):
2313
2314 2018-06-04  Chris Dumez  <cdumez@apple.com>
2315
2316         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
2317         https://bugs.webkit.org/show_bug.cgi?id=186287
2318         <rdar://problem/40783352>
2319
2320         Reviewed by Youenn Fablet.
2321
2322         * Interfaces/IWebPreferencesPrivate.idl:
2323         * WebPreferenceKeysPrivate.h:
2324         * WebPreferences.cpp:
2325         (WebPreferences::initializeDefaultSettings):
2326         (WebPreferences::crossOriginWindowPolicySupportEnabled):
2327         (WebPreferences::setCrossOriginWindowPolicySupportEnabled):
2328         * WebPreferences.h:
2329         * WebView.cpp:
2330         (WebView::notifyPreferencesChanged):
2331
2332 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2333
2334         [JSC] Pass VM& parameter as much as possible
2335         https://bugs.webkit.org/show_bug.cgi?id=186085
2336
2337         Reviewed by Saam Barati.
2338
2339         * Plugins/PluginPackage.cpp:
2340         (WebCore::NPN_Invoke):
2341
2342 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2343
2344         REGRESSION(r232316) [Win] error C2039: 'event': is not a member of 'WebCore::NavigationAction'
2345         https://bugs.webkit.org/show_bug.cgi?id=186125
2346
2347         Unreviewed build fix
2348
2349         * WebActionPropertyBag.cpp:
2350         (WebActionPropertyBag::Read):
2351         (findMouseEvent): Deleted.
2352
2353 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
2354
2355         REGRESSION(r232198) [WinCairo] cannot convert from 'WTF::StringView' to 'const WTF::String'
2356         https://bugs.webkit.org/show_bug.cgi?id=186027
2357
2358         Unreviewed build fix
2359
2360         * WebMutableURLRequest.cpp:
2361         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
2362         (WebMutableURLRequest::setClientCertificate):
2363
2364 2018-05-25  Chris Dumez  <cdumez@apple.com>
2365
2366         Minor ApplicationCacheStorage clean up
2367         https://bugs.webkit.org/show_bug.cgi?id=185984
2368
2369         Reviewed by Youenn Fablet.
2370
2371         * WebApplicationCache.cpp:
2372         (WebApplicationCache::originsWithCache):
2373
2374 2018-05-24  Chris Dumez  <cdumez@apple.com>
2375
2376         Reduce copying of FontCascadeDescription objects by moving them around
2377         https://bugs.webkit.org/show_bug.cgi?id=185963
2378
2379         Reviewed by Simon Fraser.
2380
2381         Reduce copying of FontCascadeDescription objects by moving them around when possible.
2382
2383         * FullscreenVideoController.cpp:
2384         (FullscreenVideoController::draw):
2385
2386 2018-05-15  Antoine Quint  <graouts@apple.com>
2387
2388         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2389         https://bugs.webkit.org/show_bug.cgi?id=185647
2390
2391         Reviewed by Dean Jackson.
2392
2393         Rename the Web Animations CSS integration flag.
2394
2395         * Interfaces/IWebPreferencesPrivate.idl:
2396         * WebPreferenceKeysPrivate.h:
2397         * WebPreferences.cpp:
2398         (WebPreferences::initializeDefaultSettings):
2399         (WebPreferences::webAnimationsCSSIntegrationEnabled):
2400         (WebPreferences::setWebAnimationsCSSIntegrationEnabled):
2401         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
2402         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled): Deleted.
2403         * WebPreferences.h:
2404         * WebView.cpp:
2405         (WebView::notifyPreferencesChanged):
2406
2407 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2408
2409         REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
2410         https://bugs.webkit.org/show_bug.cgi?id=185505
2411
2412         Unreviewed serious crash fix
2413
2414         Windows port crashes soon since Bug 184996.
2415
2416         * WebPreferences.cpp:
2417         (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
2418         * WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
2419
2420 2018-05-07  Daniel Bates  <dabates@apple.com>
2421
2422         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
2423         https://bugs.webkit.org/show_bug.cgi?id=185170
2424
2425         Reviewed by Per Arne Vollan.
2426
2427         * WebCache.cpp:
2428         (WebCache::empty):
2429
2430 2018-04-27  Chris Dumez  <cdumez@apple.com>
2431
2432         Use WindowProxy instead of DOMWindow in our IDL
2433         https://bugs.webkit.org/show_bug.cgi?id=185022
2434
2435         Reviewed by Sam Weinig.
2436
2437         * DOMCoreClasses.cpp:
2438         (DOMDocument::getComputedStyle):
2439
2440 2018-04-23  Daniel Bates  <dabates@apple.com>
2441
2442         Implement Same-Site cookies
2443         https://bugs.webkit.org/show_bug.cgi?id=159464
2444         <rdar://problem/27196358>
2445
2446         Reviewed by Brent Fulgham.
2447
2448         Pass the Same-Site info through the strategy.
2449
2450         * WebCoreSupport/WebPlatformStrategies.cpp:
2451         (WebPlatformStrategies::cookiesForDOM):
2452         (WebPlatformStrategies::setCookiesFromDOM):
2453         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2454         (WebPlatformStrategies::getRawCookies):
2455         * WebCoreSupport/WebPlatformStrategies.h:
2456
2457 2018-04-23  Daniel Bates  <dabates@apple.com>
2458
2459         Implement Same-Site cookies
2460         https://bugs.webkit.org/show_bug.cgi?id=159464
2461         <rdar://problem/27196358>
2462
2463         Reviewed by Brent Fulgham.
2464
2465         Pass the Same-Site info through the strategy.
2466
2467         * WebCoreSupport/WebPlatformStrategies.cpp:
2468         (WebPlatformStrategies::cookiesForDOM):
2469         (WebPlatformStrategies::setCookiesFromDOM):
2470         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2471         (WebPlatformStrategies::getRawCookies):
2472         * WebCoreSupport/WebPlatformStrategies.h:
2473
2474 2018-04-20  Youenn Fablet  <youenn@apple.com>
2475
2476         Make PluginData cache its web visible plugins
2477         https://bugs.webkit.org/show_bug.cgi?id=184421
2478
2479         Reviewed by Chris Dumez.
2480
2481         * WebCoreSupport/WebPluginInfoProvider.cpp:
2482         (WebPluginInfoProvider::pluginInfo):
2483         (WebPluginInfoProvider::webVisiblePluginInfo):
2484         * WebCoreSupport/WebPluginInfoProvider.h:
2485
2486 2018-04-19  Chris Dumez  <cdumez@apple.com>
2487
2488         Rename JSDOMWindowProxy to JSWindowProxy
2489         https://bugs.webkit.org/show_bug.cgi?id=184797
2490
2491         Reviewed by Sam Weinig.
2492
2493         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
2494
2495         * WebFrame.cpp:
2496         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2497
2498 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2499
2500         Unreviewed rollout of r230632. Regression in memory usage.
2501
2502         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2503
2504         * WebPreferences.cpp:
2505         (WebPreferences::initializeDefaultSettings):
2506
2507 2018-04-17  Chris Dumez  <cdumez@apple.com>
2508
2509         Unreviewed attempt to fix the Windows build after r230721
2510
2511         * WebCoreSupport/WebFrameLoaderClient.cpp:
2512         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2513
2514 2018-04-17  Chris Dumez  <cdumez@apple.com>
2515
2516         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
2517         https://bugs.webkit.org/show_bug.cgi?id=184678
2518         <rdar://problem/39422122>
2519
2520         Reviewed by Alex Christensen.
2521
2522         Add new parameter to dispatchDecidePolicyForNavigationAction.
2523
2524         * WebCoreSupport/WebFrameLoaderClient.cpp:
2525         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2526         * WebCoreSupport/WebFrameLoaderClient.h:
2527
2528 2018-04-12  Antoine Quint  <graouts@apple.com>
2529
2530         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
2531         https://bugs.webkit.org/show_bug.cgi?id=184569
2532         <rdar://problem/38671301>
2533
2534         Reviewed by Jon Lee.
2535
2536         Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.
2537
2538         * WebPreferences.cpp:
2539
2540 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2541
2542         [WTF] Remove StaticLock
2543         https://bugs.webkit.org/show_bug.cgi?id=184332
2544
2545         Reviewed by Mark Lam.
2546
2547         * WebKitQuartzCoreAdditions/CAView.cpp:
2548         (WKQCA::CAView::releaseAllD3DResources):
2549         * WebLocalizableStrings.cpp:
2550
2551 2018-04-03  Chris Dumez  <cdumez@apple.com>
2552
2553         Drop MainFrame class
2554         https://bugs.webkit.org/show_bug.cgi?id=184191
2555
2556         Reviewed by Darin Adler.
2557
2558         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
2559         relationship between the Page and the MainFrame.
2560
2561         This is ground work for introducing LocalFrame / RemoteFrame concepts.
2562
2563         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2564         * WebCoreSupport/WebContextMenuClient.cpp:
2565         * WebCoreSupport/WebDragClient.cpp:
2566         * WebDropSource.cpp:
2567         * WebFrame.cpp:
2568         * WebView.cpp:
2569
2570 2018-03-26  Chris Dumez  <cdumez@apple.com>
2571
2572         Use SecurityOriginData more consistently in Service Worker code
2573         https://bugs.webkit.org/show_bug.cgi?id=183969
2574
2575         Reviewed by Darin Adler.
2576
2577         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2578
2579         * WebDatabaseManager.cpp:
2580         (WebDatabaseManager::databasesWithOrigin):
2581         (WebDatabaseManager::deleteOrigin):
2582         (WebDatabaseManager::deleteDatabase):
2583         (WebDatabaseManager::setQuota):
2584         * WebSecurityOrigin.cpp:
2585         (WebSecurityOrigin::usage):
2586         (WebSecurityOrigin::quota):
2587         (WebSecurityOrigin::setQuota):
2588
2589 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
2590
2591         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
2592         https://bugs.webkit.org/show_bug.cgi?id=183911
2593         <rdar://problem/38762306>
2594
2595         Reviewed by Youenn Fablet.
2596
2597         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
2598
2599         * WebView.cpp:
2600         (WebView::WebView):
2601
2602 2018-03-25  Commit Queue  <commit-queue@webkit.org>
2603
2604         Unreviewed, rolling out r229954.
2605         https://bugs.webkit.org/show_bug.cgi?id=184000
2606
2607         Caused many layout tests to crash on Apple High Sierra,
2608         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
2609         by dydz on #webkit).
2610
2611         Reverted changeset:
2612
2613         "Use SecurityOriginData more consistently in Service Worker
2614         code"
2615         https://bugs.webkit.org/show_bug.cgi?id=183969
2616         https://trac.webkit.org/changeset/229954
2617
2618 2018-03-24  Chris Dumez  <cdumez@apple.com>
2619
2620         Use SecurityOriginData more consistently in Service Worker code
2621         https://bugs.webkit.org/show_bug.cgi?id=183969
2622
2623         Reviewed by Darin Adler.
2624
2625         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2626
2627         * WebDatabaseManager.cpp:
2628         (WebDatabaseManager::databasesWithOrigin):
2629         (WebDatabaseManager::deleteOrigin):
2630         (WebDatabaseManager::deleteDatabase):
2631         (WebDatabaseManager::setQuota):
2632         * WebSecurityOrigin.cpp:
2633         (WebSecurityOrigin::usage):
2634         (WebSecurityOrigin::quota):
2635         (WebSecurityOrigin::setQuota):
2636
2637 2018-03-23  Chris Dumez  <cdumez@apple.com>
2638
2639         Unreviewed attempt to fix Windows build after r229926.
2640
2641         * WebView.cpp:
2642
2643 2018-03-23  Brady Eidson  <beidson@apple.com>
2644
2645         Go to back/forward list items after a process-swapped navigation.
2646         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
2647
2648         Reviewed by Andy Estes.
2649
2650         * WebView.cpp:
2651         (WebView::goToBackForwardItem):
2652         (WebView::loadBackForwardListFromOtherView):
2653
2654 2018-03-23  Miguel Gomez  <magomez@igalia.com>
2655
2656         [GTK][WPE] Avoid software color conversion inside BitmapTextureGL
2657         https://bugs.webkit.org/show_bug.cgi?id=183892
2658
2659         Remove the UpdateContentsFlag parameter as it's not used anymore.
2660
2661         Reviewed by Žan Doberšek.
2662
2663         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2664         (AcceleratedCompositingContext::acceleratedCompositingAvailable):
2665
2666 2018-03-15  Yousuke Kimoto  <yousuke.kimoto@sony.com>
2667
2668         [WinCairo] Fix build errors when ENABLE_NETSCAPE_PLUGIN_API is turned off
2669         https://bugs.webkit.org/show_bug.cgi?id=183335
2670
2671         Reviewed by Alex Christensen.
2672
2673         * Plugins/PluginDatabaseWin.cpp:
2674         * Plugins/PluginMessageThrottlerWin.cpp:
2675         (WebCore::PluginMessageThrottlerWin::processQueuedMessage):
2676         * Plugins/PluginPackageWin.cpp:
2677         (WebCore::PluginPackage::load):
2678         * Plugins/PluginView.h:
2679         * Plugins/PluginViewWin.cpp:
2680         * Plugins/npapi.cpp:
2681         * WebCoreSupport/WebFrameLoaderClient.cpp:
2682         (WebFrameLoaderClient::createPlugin):
2683         (WebFrameLoaderClient::createJavaAppletWidget):
2684         * WebView.cpp:
2685         (WebView::WebViewWndProc):
2686
2687 2018-03-13  Ross Kirsling  <ross.kirsling@sony.com>
2688
2689         [Win] Layout Test fast/html/menuitem-element.html is failing.
2690         https://bugs.webkit.org/show_bug.cgi?id=179299
2691
2692         Reviewed by Per Arne Vollan.
2693
2694         * Interfaces/IWebPreferencesPrivate.idl:
2695         * WebPreferenceKeysPrivate.h:
2696         * WebPreferences.cpp:
2697         (WebPreferences::menuItemElementEnabled):
2698         (WebPreferences::setMenuItemElementEnabled):
2699         * WebPreferences.h:
2700         * WebView.cpp:
2701         (WebView::notifyPreferencesChanged):
2702         Add private web preference "menuItemElementEnabled".
2703
2704 2018-03-12  Antoine Quint  <graouts@apple.com>
2705
2706         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
2707         https://bugs.webkit.org/show_bug.cgi?id=183504
2708         <rdar://problem/38372965>
2709
2710         Reviewed by Dean Jackson and Jon Lee.
2711
2712         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
2713         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
2714
2715         * Interfaces/IWebPreferencesPrivate.idl:
2716         * WebPreferences.cpp:
2717         (WebPreferences::cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2718         (WebPreferences::setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled):
2719         * WebPreferenceKeysPrivate.h
2720         * WebPreferences.h:
2721         * WebView.cpp:
2722         (WebView::notifyPreferencesChanged):
2723
2724 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2725
2726         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
2727         https://bugs.webkit.org/show_bug.cgi?id=183429
2728
2729         Reviewed by Mark Lam.
2730
2731         * WebFrame.cpp:
2732         (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
2733
2734 2018-03-08  Tim Horton  <timothy_horton@apple.com>
2735
2736         Stop linking ApplicationServices directly
2737         https://bugs.webkit.org/show_bug.cgi?id=182867
2738         <rdar://problem/38252142>
2739
2740         Reviewed by Alex Christensen.
2741
2742         The frameworks that we use that live inside ApplicationServices
2743         have mostly moved out, so import them directly.
2744
2745         * FullscreenVideoController.cpp:
2746
2747 2018-03-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2748
2749         Fix std::make_unique / new[] using system malloc
2750         https://bugs.webkit.org/show_bug.cgi?id=182975
2751
2752         Reviewed by JF Bastien.
2753
2754         Use Vector instead.
2755
2756         * MarshallingHelpers.cpp:
2757         (MarshallingHelpers::safeArrayToStringArray):
2758         (MarshallingHelpers::safeArrayToIntArray):
2759         * Plugins/PluginPackageWin.cpp:
2760         (WebCore::PluginPackage::fetchInfo):
2761         * WebPreferences.cpp:
2762         (WebPreferences::copyWebKitPreferencesToCFPreferences):
2763         * WebView.cpp:
2764         (WebView::onMenuCommand):
2765
2766 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2767
2768         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
2769         https://bugs.webkit.org/show_bug.cgi?id=183312
2770
2771         Reviewed by Mark Lam.
2772
2773         Remove wtf/CurrentTime.h include pragma.
2774
2775         * WebDownload.cpp:
2776         * WebDownloadCFNet.cpp:
2777         * WebDropSource.cpp:
2778
2779 2018-03-01  Yusuke Suzuki  <utatane.tea@gmail.com>
2780
2781         Remove monotonicallyIncreasingTime
2782         https://bugs.webkit.org/show_bug.cgi?id=182911
2783
2784         Reviewed by Michael Catanzaro.
2785
2786         * FullscreenVideoController.cpp:
2787         (FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
2788         * Plugins/PluginMessageThrottlerWin.cpp:
2789         (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
2790         (WebCore::PluginMessageThrottlerWin::appendMessage):
2791         * Plugins/PluginMessageThrottlerWin.h:
2792         * WebView.cpp:
2793         (WebView::notifyAnimationStarted):
2794         * WebView.h:
2795
2796 2018-03-01  Ross Kirsling  <ross.kirsling@sony.com>
2797
2798         [Win][DRT] Implement setSpatialNavigationEnabled.
2799         https://bugs.webkit.org/show_bug.cgi?id=183166
2800
2801         Reviewed by Per Arne Vollan.
2802
2803         Create a non-dummy implementation of the private preference in Win WKL to support layout tests.
2804
2805         * Interfaces/IWebPreferencesPrivate.idl:
2806         * WebPreferenceKeysPrivate.h:
2807         * WebPreferences.cpp:
2808         (WebPreferences::initializeDefaultSettings):
2809         (WebPreferences::spatialNavigationEnabled):
2810         (WebPreferences::setSpatialNavigationEnabled):
2811         * WebPreferences.h:
2812         * WebView.cpp:
2813         (WebView::notifyPreferencesChanged):
2814
2815 2018-02-28  Alex Christensen  <achristensen@webkit.org>
2816
2817         Reduce use of NetworkingContext in WebKit
2818         https://bugs.webkit.org/show_bug.cgi?id=183213
2819
2820         Reviewed by Brady Eidson.
2821
2822         * Plugins/PluginView.cpp:
2823         (WebCore::PluginView::getValueForURL):
2824
2825 2018-02-26  Don Olmstead  <don.olmstead@sony.com>
2826
2827         Fix WebCore includes within WebKitLegacy
2828         https://bugs.webkit.org/show_bug.cgi?id=183147
2829
2830         Reviewed by Tim Horton.
2831
2832         * Plugins/PluginDatabase.cpp:
2833         * Plugins/PluginDatabaseWin.cpp:
2834         * Plugins/PluginDebug.cpp:
2835         * Plugins/PluginDebug.h:
2836         * Plugins/PluginMainThreadScheduler.cpp:
2837         * Plugins/PluginMessageThrottlerWin.cpp:
2838         * Plugins/PluginMessageThrottlerWin.h:
2839         * Plugins/PluginPackage.cpp:
2840         * Plugins/PluginPackage.h:
2841         * Plugins/PluginPackageWin.cpp:
2842         * Plugins/PluginStream.cpp:
2843         * Plugins/PluginStream.h:
2844         * Plugins/PluginView.cpp:
2845         * Plugins/PluginView.h:
2846         * Plugins/PluginViewWin.cpp:
2847         * Plugins/npapi.cpp:
2848         * WebCoreSupport/WebChromeClient.cpp:
2849         * WebCoreSupport/WebContextMenuClient.cpp:
2850         * WebCoreSupport/WebFrameLoaderClient.cpp:
2851         * WebCoreSupport/WebInspectorClient.cpp:
2852         * WebCoreSupport/WebPlatformStrategies.cpp:
2853         * WebFrame.cpp:
2854         * WebKitMessageLoop.cpp:
2855         * WebView.cpp:
2856         * storage/WebDatabaseProvider.cpp:
2857
2858 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2859
2860         Remove currentTime() / currentTimeMS()
2861         https://bugs.webkit.org/show_bug.cgi?id=183052
2862
2863         Reviewed by Mark Lam.
2864
2865         * WebCoreSupport/WebFrameLoaderClient.cpp:
2866         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2867         * WebCoreSupport/WebFrameLoaderClient.h:
2868         * WebDownload.h:
2869         * WebDownloadCFNet.cpp:
2870         (WebDownload::didStart):
2871         (WebDownload::didReceiveData):
2872         (WebDownload::didFinish):
2873
2874 2018-02-21  Don Olmstead  <don.olmstead@sony.com>
2875
2876         [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
2877         https://bugs.webkit.org/show_bug.cgi?id=182883
2878
2879         Reviewed by Per Arne Vollan.
2880
2881         * WebKitPrefix.h:
2882
2883 2018-02-16  Dean Jackson  <dino@apple.com>
2884
2885         Use OPENGL macros to be more clear about which OpenGL/ES WebGL uses on Cocoa
2886         https://bugs.webkit.org/show_bug.cgi?id=182894
2887
2888         Reviewed by Tim Horton.
2889
2890         Rename OPENGL_ES_2 to OPENGL_ES.
2891
2892         * WebCoreSupport/AcceleratedCompositingContext.cpp:
2893
2894 2018-02-16  Youenn Fablet  <youenn@apple.com>
2895
2896         Allow specifying which plug-ins are supported
2897         https://bugs.webkit.org/show_bug.cgi?id=182748
2898
2899         Reviewed by Chris Dumez.
2900
2901         * WebCoreSupport/WebPluginInfoProvider.cpp:
2902         (WebPluginInfoProvider::getPluginInfo):
2903         * WebCoreSupport/WebPluginInfoProvider.h:
2904
2905 2018-02-15  Don Olmstead  <don.olmstead@sony.com>
2906
2907         WebCore headers should not be included relatively within dependent projects
2908         https://bugs.webkit.org/show_bug.cgi?id=182805
2909
2910         Reviewed by Chris Dumez.
2911
2912         * FullscreenVideoController.h:
2913
2914 2018-02-13  Commit Queue  <commit-queue@webkit.org>
2915
2916         Unreviewed, rolling out r228431.
2917         https://bugs.webkit.org/show_bug.cgi?id=182766
2918
2919         Regressed CMake build stability (Requested by dolmstead on
2920         #webkit).
2921
2922         Reverted changeset:
2923
2924         "[CMake] Make WebCore headers copies"
2925         https://bugs.webkit.org/show_bug.cgi?id=182512
2926         https://trac.webkit.org/changeset/228431
2927
2928 2018-02-13  Don Olmstead  <don.olmstead@sony.com>
2929
2930         [CMake] Make WebCore headers copies
2931         https://bugs.webkit.org/show_bug.cgi?id=182512
2932
2933         Reviewed by Keith Miller.
2934
2935         * FullscreenVideoController.h:
2936         * Plugins/PluginDatabase.cpp:
2937         * Plugins/PluginDatabaseWin.cpp:
2938         * Plugins/PluginDebug.cpp:
2939         * Plugins/PluginMainThreadScheduler.cpp:
2940         * Plugins/PluginMessageThrottlerWin.cpp:
2941         * Plugins/PluginPackage.cpp:
2942         * Plugins/PluginPackageWin.cpp:
2943         * Plugins/PluginStream.cpp:
2944         * Plugins/PluginView.cpp:
2945         * Plugins/PluginViewWin.cpp:
2946         * Plugins/npapi.cpp:
2947         * WebKitMessageLoop.cpp:
2948         * WebKitPrefix.h:
2949         * storage/WebDatabaseProvider.cpp:
2950
2951 2018-01-13  Darin Adler  <darin@apple.com>
2952
2953         Event improvements
2954         https://bugs.webkit.org/show_bug.cgi?id=179591
2955
2956         Reviewed by Chris Dumez.
2957
2958         * Plugins/PluginView.cpp: Removed include of ScriptValue.h.
2959         * WebFrame.cpp: Ditto.
2960
2961         * WebScriptWorld.cpp:
2962         (WebScriptWorld::scriptWorldForGlobalContext): Pass reference to currentWorld.
2963
2964         * WebView.cpp: Removed include of ScriptValue.h.
2965         (WebView::handleEditingKeyboardEvent): Updated for name change from
2966         keyEvent to underlyingPlatformEvent.
2967
2968 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
2969
2970         Remove WebCore/ForwardingHeaders directory
2971         https://bugs.webkit.org/show_bug.cgi?id=182347
2972
2973         Reviewed by Keith Miller.
2974
2975         * Plugins/PluginView.cpp:
2976         * Plugins/PluginViewWin.cpp:
2977         * WebCoreSupport/WebInspectorClient.cpp:
2978         * WebCoreSupport/WebInspectorClient.h:
2979         * WebFrame.cpp:
2980         * WebJavaScriptCollector.cpp:
2981         * WebView.cpp:
2982
2983 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2984
2985         Unreviewed, another attempt to fix the Windows build after r227479.
2986
2987         * WebFrame.cpp:
2988         (WebFrame::elementWithName):
2989
2990 2018-01-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2991
2992         Unreviewed, try to fix the Windows build after r227479.
2993
2994         Tweak some Windows WebKitLegacy code to use updated HTMLFormElement methods.
2995
2996         * WebFrame.cpp:
2997         (WebFrame::elementWithName):
2998         (WebFrame::controlsInForm):
2999
3000 2018-01-19  Per Arne Vollan  <pvollan@apple.com>
3001
3002         [Win] Compile error: 'WebKitQuartzCoreAdditionsBase.h' not found.
3003         https://bugs.webkit.org/show_bug.cgi?id=181859
3004         <rdar://problem/36659886>
3005
3006         Reviewed by Alex Christensen.
3007         
3008         Use local include patch.
3009
3010         * WebKitQuartzCoreAdditions/API/WKCACFImage.h:
3011         * WebKitQuartzCoreAdditions/API/WKCACFView.h:
3012         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h:
3013
3014 2018-01-17  Youenn Fablet  <youenn@apple.com>
3015
3016         Put fetch Request.keepalive behind a runtime flag
3017         https://bugs.webkit.org/show_bug.cgi?id=181592
3018
3019         Reviewed by Chris Dumez.
3020
3021         * WebPreferences.cpp:
3022         (WebPreferences::fetchAPIKeepAliveEnabled):
3023         (WebPreferences::setFetchAPIKeepAliveEnabled):
3024         * WebPreferences.h:
3025         * WebView.cpp:
3026         (WebView::notifyPreferencesChanged):
3027
3028 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3029
3030         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
3031         https://bugs.webkit.org/show_bug.cgi?id=181637
3032         <rdar://problem/36508471>
3033
3034         Reviewed by Tim Horton.
3035
3036         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
3037
3038         * WebCoreSupport/WebEditorClient.cpp:
3039         (WebEditorClient::replacementURLForResource):
3040         * WebCoreSupport/WebEditorClient.h:
3041
3042 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
3043
3044         Remove std::chrono completely
3045         https://bugs.webkit.org/show_bug.cgi?id=181186
3046
3047         Reviewed by Alex Christensen.
3048
3049         * Plugins/PluginStream.cpp:
3050         (WebCore::lastModifiedDateMS):
3051
3052 2018-01-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3053
3054         [Win] Web Inspector: Wrongly placed inspector highlight in HiDPI
3055         https://bugs.webkit.org/show_bug.cgi?id=181173
3056
3057         Reviewed by Alex Christensen.
3058
3059         * WebNodeHighlight.cpp:
3060         (WebNodeHighlight::update): Scale the GraphicsContext.
3061
3062 2017-12-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3063
3064         REGRESSION(r225769): Build error with constexpr std::max // std::min in libdstdc++4
3065         https://bugs.webkit.org/show_bug.cgi?id=181160
3066
3067         Reviewed by Myles C. Maxfield.
3068
3069         * Plugins/PluginView.cpp:
3070         (WebCore::PluginView::handlePost): Disambiguate usage of min (Use the version from stdlib).
3071
3072 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
3073
3074         Enable picture-in-picture from inline element on suspend.
3075         https://bugs.webkit.org/show_bug.cgi?id=180942
3076         rdar://problem/34745234
3077
3078         Reviewed by Jer Noble.
3079
3080         Update signature of enterVideoFullscreenForVideoElement.
3081
3082         * WebCoreSupport/WebChromeClient.cpp:
3083         (WebChromeClient::enterVideoFullscreenForVideoElement):
3084         * WebCoreSupport/WebChromeClient.h:
3085
3086 2017-12-18  Fujii Hironori  <Hironori.Fujii@sony.com>
3087
3088         [Win] SHOULD NEVER BE REACHED in WebFrameLoaderClient::pageID
3089         https://bugs.webkit.org/show_bug.cgi?id=180926
3090
3091         Reviewed by Tim Horton.
3092
3093         Apply the same change of mac/WebCoreSupport/WebFrameLoaderClient.mm
3094         of r225934 to win/WebCoreSupport/WebFrameLoaderClient.cpp.
3095
3096         * WebCoreSupport/WebFrameLoaderClient.cpp:
3097         (WebFrameLoaderClient::frameID const): Removed RELEASE_ASSERT_NOT_REACHED.
3098         (WebFrameLoaderClient::pageID const): Ditto.
3099
3100 2017-12-16  Yusuke Suzuki  <utatane.tea@gmail.com>
3101
3102         Remove unnecessary boolean result of start() functions
3103         https://bugs.webkit.org/show_bug.cgi?id=180856
3104
3105         Reviewed by Darin Adler.
3106
3107         It always returns true.
3108
3109         * WebDownloadCurl.cpp:
3110         (WebDownload::start):
3111
3112 2017-12-14  John Wilander  <wilander@apple.com>
3113
3114         Storage Access API: Implement frame-specific access in the document.cookie layer
3115         https://bugs.webkit.org/show_bug.cgi?id=180682
3116         <rdar://problem/35982257>
3117
3118         Reviewed by Alex Christensen.
3119
3120         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
3121         CookiesStrategy::cookieRequestHeaderFieldValue(), and
3122         CookiesStrategy::getRawCookies() now take optional parameters for
3123         frameID and pageID to allow frame-specific scoping of cookies.
3124
3125         This change makes the return values of FrameLoaderClient::frameID()
3126         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
3127         WebCore can call those getters and get the right return values in
3128         WebKit and std:nullopt in WebKitLegacy.
3129
3130         * WebCoreSupport/WebFrameLoaderClient.cpp:
3131         (WebFrameLoaderClient::pageID const):
3132         (WebFrameLoaderClient::frameID const):
3133             Now return an optional.
3134         * WebCoreSupport/WebFrameLoaderClient.h:
3135         * WebCoreSupport/WebPlatformStrategies.cpp:
3136         (WebPlatformStrategies::cookiesForDOM):
3137         (WebPlatformStrategies::setCookiesFromDOM):
3138         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3139         (WebPlatformStrategies::getRawCookies):
3140         * WebCoreSupport/WebPlatformStrategies.h:
3141
3142 2017-12-12  Yusuke Suzuki  <utatane.tea@gmail.com>
3143
3144         [WTF] Thread::create should have Thread::tryCreate
3145         https://bugs.webkit.org/show_bug.cgi?id=180333
3146
3147         Reviewed by Darin Adler.
3148
3149         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp:
3150         (WKQCA::CVDisplayLink::start):
3151
3152 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3153
3154         Use StaticLock and Lock instead of Mutex in Windows WebKitLegacy
3155         https://bugs.webkit.org/show_bug.cgi?id=180572
3156
3157         Reviewed by Mark Lam.
3158
3159         Use StaticLock and drop DEPRECATED_DEFINE_STATIC_LOCAL.
3160         Also we use Lock instead of Mutex.
3161
3162         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
3163         (WKQCA::CAD3DRenderer::swapChain):
3164         (WKQCA::CAD3DRenderer::renderAndPresent):
3165         (WKQCA::CAD3DRenderer::renderToImage):
3166         (WKQCA::CAD3DRenderer::setDeviceIsLost):
3167         (WKQCA::CAD3DRenderer::renderInternal):
3168         * WebKitQuartzCoreAdditions/CAD3DRenderer.h:
3169         * WebKitQuartzCoreAdditions/CAView.cpp:
3170         (WKQCA::CAView::Handle::create):
3171         Return Ref<Handle> instead of RefPtr<>.
3172
3173         (WKQCA::CAView::Handle::lock):
3174         (WKQCA::CAView::Handle::view const):
3175         (WKQCA::CAView::Handle::clear):
3176         (WKQCA::views):
3177         (WKQCA::viewsNeedingUpdate):
3178         (WKQCA::CAView::releaseAllD3DResources):
3179         (WKQCA::CAView::CAView):
3180         (WKQCA::CAView::~CAView):
3181         (WKQCA::CAView::setLayer):
3182         (WKQCA::CAView::update):
3183         (WKQCA::CAView::drawToWindow):
3184         (WKQCA::CAView::drawToWindowInternal):
3185         (WKQCA::CAView::drawToImage):
3186         (WKQCA::CAView::willDraw):
3187         (WKQCA::CAView::drawIntoDC):
3188         (WKQCA::CAView::setShouldInvertColors):
3189         (WKQCA::CAView::scheduleNextDraw):
3190         (WKQCA::CAView::displayLinkReachedCAMediaTime):
3191         (WKQCA::CAView::contextDidChange):
3192         (WKQCA::CAView::updateSoon):
3193         (WKQCA::CAView::updateViewsNow):
3194         (WKQCA::CAView::d3dDevice9):
3195         (WKQCA::CAView::Handle::mutex): Deleted.
3196         (WKQCA::globalStateMutex): Deleted.
3197         (): Deleted.
3198         * WebKitQuartzCoreAdditions/CAView.h:
3199
3200 2017-12-07  Yusuke Suzuki  <utatane.tea@gmail.com>
3201
3202         Use StaticLock instead of NeverDestroyed<Lock>
3203         https://bugs.webkit.org/show_bug.cgi?id=180507
3204
3205         Reviewed by Saam Barati.
3206
3207         * WebLocalizableStrings.cpp:
3208         (findCachedString):
3209         (cacheString):
3210         (mainBundleLocStrings): Deleted.
3211         (frameworkLocStringsMutex): Deleted.
3212
3213 2017-12-05  Per Arne Vollan  <pvollan@apple.com>
3214
3215         [Win] Scrollbars are sometimes not rendered in accelerated compositing mode.
3216         https://bugs.webkit.org/show_bug.cgi?id=180431
3217         <rdar://problem/34531264>
3218
3219         Reviewed by Simon Fraser.
3220
3221         Fix the signatures of GraphicsLayerClient that should have been overridden, and use
3222         'override' to make sure this doesn't break in the future.
3223
3224         * WebView.cpp:
3225         (WebView::notifyAnimationStarted):
3226         (WebView::paintContents):
3227         * WebView.h:
3228
3229 2017-11-23  Darin Adler  <darin@apple.com>
3230
3231         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
3232         https://bugs.webkit.org/show_bug.cgi?id=179981
3233
3234         Reviewed by Sam Weinig.
3235
3236         * WebView.cpp:
3237         (WebView::searchFor): Use |= instead of | to build FindOptions.
3238         (WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
3239         (WebView::findString): Create FindOptions with |=; the old code just passed a
3240         WebKit FindOptions through without converting to WebCore::FindOptions.
3241
3242 2017-11-23  Darin Adler  <darin@apple.com>
3243
3244         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
3245         https://bugs.webkit.org/show_bug.cgi?id=179907
3246
3247         Reviewed by Sam Weinig.
3248
3249         * Plugins/PluginDatabaseWin.cpp:
3250         (WebCore::PluginDatabase::getPluginPathsInDirectories const): Use
3251         startsWithLettersIgnoringASCIICase and endsWithIgnoringASCIICase.
3252         * WebDownloadCFNet.cpp:
3253         (WebDownload::initToResumeWithBundle): Use endsWithIgnoringASCIICase.
3254
3255         * WebView.cpp:
3256         (WebView::markAllMatchesForText): Fix old code that was passing TextCaseSensitivity
3257         to a function that actually takes FindOptions. By luck, TextCaseSensitive happens to
3258         be 0, which is correct FindOptions for case sensitive matching, and TextCaseInsensitive
3259         happens to be 1, which is correct FindOptions for case insensitive matching, so fixing
3260         the code does not cause any change in behavior.
3261
3262 2017-11-22  Ali Juma  <ajuma@chromium.org>
3263
3264         Implement VisualViewport API attributes
3265         https://bugs.webkit.org/show_bug.cgi?id=179385
3266
3267         Reviewed by Frédéric Wang.
3268
3269         Add a VisualViewportAPI preference.
3270
3271         * Interfaces/IWebPreferencesPrivate.idl:
3272         * WebPreferenceKeysPrivate.h:
3273         * WebPreferences.cpp:
3274         (WebPreferences::initializeDefaultSettings):
3275         (WebPreferences::visualViewportAPIEnabled):
3276         (WebPreferences::setVisualViewportAPIEnabled):
3277         * WebPreferences.h:
3278         * WebView.cpp:
3279         (WebView::notifyPreferencesChanged):
3280
3281 2017-11-22  Commit Queue  <commit-queue@webkit.org>
3282
3283         Unreviewed, rolling out r225093.
3284         https://bugs.webkit.org/show_bug.cgi?id=179938
3285
3286         Compilation failed on WinCairo 64-bit Release (Requested by
3287         fredw on #webkit).
3288
3289         Reverted changeset:
3290
3291         "Implement VisualViewport API attributes"
3292         https://bugs.webkit.org/show_bug.cgi?id=179385
3293         https://trac.webkit.org/changeset/225093
3294
3295 2017-11-21  Ali Juma  <ajuma@chromium.org>
3296
3297         Implement VisualViewport API attributes
3298         https://bugs.webkit.org/show_bug.cgi?id=179385
3299
3300         Reviewed by Frédéric Wang.
3301
3302         Add a VisualViewportAPI preference.
3303
3304         * Interfaces/IWebPreferencesPrivate.idl:
3305         * WebPreferenceKeysPrivate.h:
3306         * WebPreferences.cpp:
3307         (WebPreferences::initializeDefaultSettings):
3308         (WebPreferences::visualViewportAPIEnabled):
3309         (WebPreferences::setVisualViewportAPIEnabled):
3310         * WebPreferences.h:
3311         * WebView.cpp:
3312         (WebView::notifyPreferencesChanged):
3313
3314 2017-11-14  Alex Christensen  <achristensen@webkit.org>
3315
3316         Clean up old URL parser remnants
3317         https://bugs.webkit.org/show_bug.cgi?id=179573
3318
3319         Reviewed by Darin Adler.
3320
3321         * WebCoreSupport/WebContextMenuClient.cpp:
3322         (WebContextMenuClient::searchWithGoogle):
3323         Use https if we do end up searching with google.
3324
3325 2017-11-12  Darin Adler  <darin@apple.com>
3326
3327         More is<> and downcast<>, less static_cast<>
3328         https://bugs.webkit.org/show_bug.cgi?id=179600
3329
3330         Reviewed by Chris Dumez.
3331
3332         * WebView.cpp:
3333         (WebView::handleEditingKeyboardEvent): Use downcast.
3334
3335 2017-11-09  Christopher Reid  <chris.reid@sony.com>
3336
3337         Use enum classes within FileSystem
3338         https://bugs.webkit.org/show_bug.cgi?id=175172
3339
3340         Reviewed by Darin Adler.
3341
3342         * Plugins/PluginDatabase.cpp:
3343
3344 2017-11-06  Per Arne Vollan  <pvollan@apple.com>
3345
3346         [Win] Add WebKitQuartzCoreAdditions library.
3347         https://bugs.webkit.org/show_bug.cgi?id=179331
3348
3349         Reviewed by Alex Christensen.
3350
3351         * WebKitQuartzCoreAdditions: Added.
3352         * WebKitQuartzCoreAdditions/API: Added.
3353         * WebKitQuartzCoreAdditions/API/WKCACFImage.cpp: Added.
3354         (toImage):
3355         (WKCACFImageGetWidth):
3356         (WKCACFImageGetHeight):
3357         (WKCACFImageCopyFileMapping):
3358         (WKCACFImageCreateWithImage):
3359         (WKCACFImageFinalize):
3360         (WKCACFImageCopyFormattingDescription):
3361         (WKCACFImageCopyDebugDescription):
3362         (WKCACFImageGetTypeID):
3363         * WebKitQuartzCoreAdditions/API/WKCACFImage.h: Added.
3364         * WebKitQuartzCoreAdditions/API/WKCACFImageInternal.h: Added.
3365         * WebKitQuartzCoreAdditions/API/WKCACFView.cpp: Added.
3366         (toView):
3367         (toImpl):
3368         (WKCACFViewCreate):
3369         (WKCACFViewSetLayer):
3370         (WKCACFViewUpdate):
3371         (WKCACFViewFlushContext):
3372         (WKCACFViewInvalidateRects):
3373         (WKCACFViewCanDraw):
3374         (WKCACFViewDraw):
3375         (WKCACFViewCopyDrawnImage):
3376         (WKCACFViewDrawIntoDC):
3377         (contextDidChangeCallback):
3378         (WKCACFViewSetContextDidChangeCallback):
3379         (WKCACFViewGetLastCommitTime):
3380         (WKCACFViewSetContextUserData):
3381         (WKCACFViewGetContext):
3382         (WKCACFViewFinalize):
3383         (WKCACFViewCopyFormattingDescription):
3384         (WKCACFViewCopyDebugDescription):
3385         (WKCACFViewGetTypeID):
3386         (WKCACFViewSetShouldInvertColors):
3387         (WKCACFViewGetD3DDevice9):
3388         * WebKitQuartzCoreAdditions/API/WKCACFView.h: Added.
3389         * WebKitQuartzCoreAdditions/API/WKCACFViewPrivate.h: Added.
3390         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditions.cpp: Added.
3391         (WKQCA::dllInstance):
3392         (DllMain):
3393         (WKCACFShutDown):
3394         * WebKitQuartzCoreAdditions/API/WebKitQuartzCoreAdditionsBase.h: Added.
3395         * WebKitQuartzCoreAdditions/CAD3DRenderer.cpp: Added.
3396         (WKQCA::D3DPostProcessingContext::D3DPostProcessingContext):
3397         (WKQCA::d3d):
3398         (WKQCA::initialPresentationParameters):
3399         (WKQCA::CAD3DRenderer::shared):
3400         (WKQCA::CAD3DRenderer::CAD3DRenderer):
3401         (WKQCA::CAD3DRenderer::swapChain):
3402         (WKQCA::CAD3DRenderer::createD3DPostProcessingContext):
3403         (WKQCA::hardwareCapabilitiesIndicateCoreAnimationSupport):
3404         (WKQCA::CAD3DRenderer::initialize):
3405         (WKQCA::D3DMatrixOrthoOffCenterRH):
3406         (WKQCA::prepareDevice):
3407         (WKQCA::updateBounds):
3408         (WKQCA::CAD3DRenderer::renderAndPresent):
3409         (WKQCA::CAD3DRenderer::renderToImage):
3410         (WKQCA::CAD3DRenderer::setDeviceIsLost):
3411         (WKQCA::CAD3DRenderer::renderInternal):
3412         (WKQCA::CAD3DRenderer::postProcess):
3413         (WKQCA::CAD3DRenderer::resetD3DDevice):
3414         (WKQCA::CAD3DRenderer::createShaderIfNeeded):
3415         (WKQCA::CAD3DRenderer::release):
3416         * WebKitQuartzCoreAdditions/CAD3DRenderer.h: Added.
3417         (WKQCA::D3DPostProcessingContext::sceneTexture const):
3418         (WKQCA::D3DPostProcessingContext::overlayQuad const):
3419         (WKQCA::CAD3DRenderer::d3dDevice9 const):
3420         * WebKitQuartzCoreAdditions/CAView.cpp: Added.
3421         (WKQCA::CAView::Handle::create):
3422         (WKQCA::CAView::Handle::~Handle):
3423         (WKQCA::CAView::Handle::mutex):
3424         (WKQCA::CAView::Handle::view const):
3425         (WKQCA::CAView::Handle::clear):
3426         (WKQCA::CAView::Handle::Handle):
3427         (WKQCA::globalStateMutex):
3428         (WKQCA::registerMessageWindowClass):
3429         (WKQCA::createMessageWindow):
3430         (WKQCA::CAView::releaseAllD3DResources):
3431         (WKQCA::CAView::CAView):
3432         (WKQCA::CAView::~CAView):
3433         (WKQCA::CAView::create):
3434         (WKQCA::CAView::setContextDidChangeCallback):
3435         (WKQCA::CAView::setLayer):
3436         (WKQCA::CAView::update):
3437         (WKQCA::CAView::invalidateRects):
3438         (WKQCA::CAView::drawToWindow):
3439         (WKQCA::CAView::drawToWindowInternal):
3440         (WKQCA::CAView::drawToImage):
3441         (WKQCA::CAView::willDraw):
3442         (WKQCA::CAView::didDraw):
3443         (WKQCA::CAView::drawIntoDC):
3444         (WKQCA::CAView::setShouldInvertColors):
3445         (WKQCA::CAView::scheduleNextDraw):
3446         (WKQCA::CAView::displayLinkReachedCAMediaTime):
3447         (WKQCA::CAView::contextDidChangeCallback):
3448         (WKQCA::CAView::contextDidChange):
3449         (WKQCA::CAView::updateSoon):
3450         (WKQCA::CAView::updateViewsNow):
3451         (WKQCA::CAView::d3dDevice9):
3452         * WebKitQuartzCoreAdditions/CAView.h: Added.
3453         (WKQCA::CAView::context const):
3454         (WKQCA::CAView::canDraw const):
3455         (WKQCA::CAView::ContextDidChangeCallback::ContextDidChangeCallback):
3456         * WebKitQuartzCoreAdditions/CMakeLists.txt: Added.
3457         * WebKitQuartzCoreAdditions/CVDisplayLink.cpp: Added.
3458         (WKQCA::CVDisplayLink::CVDisplayLink):
3459         (WKQCA::CVDisplayLink::~CVDisplayLink):
3460         (WKQCA::CVDisplayLink::create):
3461         (WKQCA::CVDisplayLink::start):
3462         (WKQCA::CVDisplayLink::stop):
3463         (WKQCA::CVDisplayLink::setPaused):
3464         (WKQCA::CVDisplayLink::runIOThread):
3465         * WebKitQuartzCoreAdditions/CVDisplayLink.h: Added.
3466         * WebKitQuartzCoreAdditions/CVDisplayLinkClient.h: Added.
3467         (WKQCA::CVDisplayLinkClient::~CVDisplayLinkClient):
3468         * WebKitQuartzCoreAdditions/Image.cpp: Added.
3469         (WKQCA::numBytesForSize):
3470         (WKQCA::Image::create):
3471         (WKQCA::Image::Image):
3472         (WKQCA::Image::~Image):
3473         (WKQCA::bitmapInfo):
3474         (WKQCA::Image::createDIB const):
3475         (WKQCA::Image::copyFileMapping):
3476         * WebKitQuartzCoreAdditions/Image.h: Added.
3477         (WKQCA::Image::size const):
3478         * WebKitQuartzCoreAdditions/ImageConversion.cpp: Added.
3479         (WKQCA::getBackBufferRectAsRenderTarget):
3480         (WKQCA::getSystemMemoryCopy):
3481         (WKQCA::copyRectToBitmap):
3482         (WKQCA::getImageCopy):
3483         (WKQCA::getBackBufferRectAsImage):
3484         * WebKitQuartzCoreAdditions/ImageConversion.h: Added.
3485         * WebKitQuartzCoreAdditions/InvertColorPS.hlsl: Added.
3486         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsInternal.h: Added.
3487         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.cpp: Added.
3488         * WebKitQuartzCoreAdditions/WebKitQuartzCoreAdditionsPrefix.h: Added.
3489
3490 2017-11-06  Christopher Reid  <chris.reid@sony.com>
3491
3492         Use enum classes within FileSystem
3493         https://bugs.webkit.org/show_bug.cgi?id=175172
3494
3495         Reviewed by Myles C. Maxfield.
3496
3497         * Plugins/PluginDatabase.cpp:
3498
3499 2017-11-02  Maciej Stachowiak  <mjs@apple.com>
3500
3501         Don't try to guess plugin MIME type from a file extension in a URL (no observable effect)
3502         https://bugs.webkit.org/show_bug.cgi?id=178333
3503
3504         Reviewed by Darin Adler.
3505
3506         * WebCoreSupport/WebFrameLoaderClient.cpp:
3507         (WebFrameLoaderClient::objectContentType): Remove unnecessary call to mimeTypeFromURL
3508
3509 2017-11-02  Alex Christensen  <achristensen@webkit.org>
3510
3511         Use CompletionHandlers for redirects
3512         https://bugs.webkit.org/show_bug.cgi?id=179163
3513
3514         Reviewed by Tim Horton.
3515
3516         * Plugins/PluginStream.cpp:
3517         (WebCore::PluginStream::willSendRequest):
3518         * Plugins/PluginStream.h:
3519         (WebCore::PluginStreamClient::~PluginStreamClient):
3520         (WebCore::PluginStreamClient::streamDidFinishLoading):
3521         (WebCore::PluginStream::create):
3522         (WebCore::PluginStream::setLoadManually):
3523
3524 2017-11-02  Christopher Reid  <chris.reid@sony.com>
3525
3526         Add a FileSystem namespace to FileSystem.cpp
3527         https://bugs.webkit.org/show_bug.cgi?id=179063
3528
3529         Reviewed by Darin Adler.
3530
3531         * Plugins/PluginDatabase.cpp:
3532         * Plugins/PluginPackage.cpp:
3533         * Plugins/PluginStream.cpp:
3534         * Plugins/PluginStream.h:
3535         * WebApplicationCache.cpp:
3536         * WebDatabaseManager.cpp:
3537         * WebDownloadCurl.cpp:
3538         * WebPreferences.cpp:
3539         * WebView.cpp:
3540
3541 2017-10-31  Alex Christensen  <achristensen@webkit.org>
3542
3543         Fix Windows build after r224260
3544
3545         * WebView.cpp:
3546