[iOS] WebKit should dispatch DOM events when a modifier key is pressed
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-11-02  Daniel Bates  <dabates@apple.com>
2
3         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
4         https://bugs.webkit.org/show_bug.cgi?id=190487
5
6         Reviewed by Tim Horton.
7
8         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
9         allow the default handling.
10
11         * WebView/WebHTMLView.mm:
12         (-[WebHTMLView _handleEditingKeyEvent:]):
13
14 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
15
16         Add a storage limit for IndexedDB
17         https://bugs.webkit.org/show_bug.cgi?id=190598
18         <rdar://problem/44654715>
19
20         Reviewed by Chris Dumez.
21
22         * Storage/WebDatabaseManager.mm:
23         (-[WebDatabaseManager setIDBPerOriginQuota:]):
24         * Storage/WebDatabaseManagerPrivate.h:
25
26 2018-10-31  Antti Koivisto  <antti@apple.com>
27
28         Remove LayerFlushScheduler
29         https://bugs.webkit.org/show_bug.cgi?id=191103
30
31         Reviewed by Anders Carlsson.
32
33         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
34         all the virtual cruft.
35
36         * WebView/WebViewData.h:
37         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
38         (): Deleted.
39         * WebView/WebViewData.mm:
40         (currentRunLoop):
41         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
42         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
43         (WebViewLayerFlushScheduler::schedule):
44         (WebViewLayerFlushScheduler::invalidate):
45         (WebViewLayerFlushScheduler::layerFlushCallback):
46
47 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
48
49         Enable InstallAPI for iOS unconditionally
50         https://bugs.webkit.org/show_bug.cgi?id=191043
51         rdar://problem/32728423
52
53         Reviewed by Dan Bernstein.
54
55         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
56         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
57         shouldn't be processed by InstallAPI.
58         * MigrateHeaders.make: Removed an obsolete workaround.
59         * Misc/NSURLDownloadSPI.h: Added.
60         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
61
62 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
63
64         Clean up some obsolete MAX_ALLOWED macros
65         https://bugs.webkit.org/show_bug.cgi?id=190916
66
67         Reviewed by Tim Horton.
68
69         * WebView/WebHTMLView.mm:
70         (-[WebHTMLView pressureChangeWithEvent:]):
71         * WebView/WebPDFView.h:
72
73 2018-10-30  Commit Queue  <commit-queue@webkit.org>
74
75         Unreviewed, rolling out r237600 and r237604.
76         https://bugs.webkit.org/show_bug.cgi?id=191086
77
78         Breaks internal iOS builds (Requested by ryanhadd_ on
79         #webkit).
80
81         Reverted changesets:
82
83         "Enable InstallAPI for iOS unconditionally"
84         https://bugs.webkit.org/show_bug.cgi?id=191043
85         https://trac.webkit.org/changeset/237600
86
87         "Build fix attempt after enabling InstallAPI for iOS."
88         https://bugs.webkit.org/show_bug.cgi?id=191043
89         https://trac.webkit.org/changeset/237604
90
91 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
92
93         Enable InstallAPI for iOS unconditionally
94         https://bugs.webkit.org/show_bug.cgi?id=191043
95         rdar://problem/32728423
96
97         Reviewed by Dan Bernstein.
98
99         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
100         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
101         shouldn't be processed by InstallAPI.
102         * MigrateHeaders.make: Removed an obsolete workaround.
103         * Misc/NSURLDownloadSPI.h: Added.
104         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
105
106 2018-10-29  Tim Horton  <timothy_horton@apple.com>
107
108         Modernize WebKit nibs and lprojs for localization's sake
109         https://bugs.webkit.org/show_bug.cgi?id=190911
110         <rdar://problem/45349466>
111
112         Reviewed by Dan Bernstein.
113
114         * Misc/WebNSControlExtras.m:
115         (-[NSControl sizeToFitAndAdjustWindowHeight]):
116         NSWindow and its contents are both in the same scale space these days; avoid
117         double-applying the scale factor, or you can't see the prompt.
118
119         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
120         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
121         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
122         NIB->XIB
123
124 2018-10-25  Antoine Quint  <graouts@apple.com>
125
126         [Web Animations] Turn Web Animations CSS Integration off by default
127         https://bugs.webkit.org/show_bug.cgi?id=190901
128
129         Reviewed by Dean Jackson.
130
131         * WebView/WebPreferences.mm:
132         (+[WebPreferences initialize]):
133
134 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
135
136         Clean up some obsolete macOS version guards
137         https://bugs.webkit.org/show_bug.cgi?id=190887
138
139         Reviewed by Dan Bernstein.
140
141         * Misc/WebNSPasteboardExtras.mm:
142         (+[NSPasteboard _web_dragTypesForURL]):
143         * WebCoreSupport/PopupMenuMac.mm:
144         (PopupMenuMac::show):
145         * WebCoreSupport/WebEditorClient.h:
146         * WebCoreSupport/WebEditorClient.mm:
147         (WebEditorClient::respondToChangedSelection):
148         * WebView/WebPDFView.mm:
149         (-[WebPDFView _clipViewForPDFDocumentView]):
150
151 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
152
153         Turn on Conic Gradients
154         https://bugs.webkit.org/show_bug.cgi?id=190810
155
156         Reviewed by Tim Horton.
157
158         * Configurations/FeatureDefines.xcconfig:
159
160 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
161
162         Cleanup: MIMETypeRegistry functions
163         https://bugs.webkit.org/show_bug.cgi?id=190838
164
165         Reviewed by Simon Fraser.
166
167         * Misc/WebNSPasteboardExtras.mm:
168         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
169         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
170         because they were identical.
171
172         * WebView/WebHTMLRepresentation.mm:
173         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
174         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
175         (+[WebHTMLRepresentation supportedImageMIMETypes]):
176         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
177         * WebView/WebView.mm:
178         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
179         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
180         (+[WebView registerViewClass:representationClass:forMIMEType:]):
181
182 2018-10-23  David Kilzer  <ddkilzer@apple.com>
183
184         Fix false positive leaks when using custom -init methods that don't start with -init
185         <https://webkit.org/b/190818>
186         <rdar://problem/45476042>
187
188         Reviewed by Dan Bernstein.
189
190         * Misc/WebKitErrors.m: Move `descriptions` static global so that
191         it is accessible by both categories.
192         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
193         NSError (WebKitInternal) category.  Add attribute to make this
194         behave like an -init method.
195         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
196         NSError (WebKitInternal) category.  Modernize method.  Replace
197         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
198
199 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
200
201         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
202         https://bugs.webkit.org/show_bug.cgi?id=190729
203
204         Reviewed by Tim Horton.
205
206         * DOM/DOM.mm:
207         (-[DOMNode boundingBox]):
208         * DOM/DOMElement.mm:
209         * DOM/DOMHTML.mm:
210         * DOM/DOMInternal.mm:
211         * DOM/DOMUIKitExtensions.mm:
212         * DOM/WebDOMOperations.mm:
213         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
214         * DefaultDelegates/WebDefaultEditingDelegate.m:
215         * DefaultDelegates/WebDefaultPolicyDelegate.m:
216         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
217         * DefaultDelegates/WebDefaultUIDelegate.h:
218         * DefaultDelegates/WebDefaultUIDelegate.mm:
219         (-[WebDefaultUIDelegate webViewClose:]):
220         (-[WebDefaultUIDelegate webViewFocus:]):
221         (-[WebDefaultUIDelegate webViewUnfocus:]):
222         (-[WebDefaultUIDelegate webViewIsResizable:]):
223         (-[WebDefaultUIDelegate webView:setResizable:]):
224         (-[WebDefaultUIDelegate webView:setFrame:]):
225         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
226         * History/BackForwardList.h:
227         * History/BackForwardList.mm:
228         * History/WebBackForwardList.mm:
229         (+[WebBackForwardList initialize]):
230         (bumperCarBackForwardHackNeeded):
231         * History/WebHistory.mm:
232         (-[WebHistoryPrivate addItem:discardDuplicate:]):
233         (-[WebHistory _sendNotification:entries:]):
234         (-[WebHistory loadFromURL:error:]):
235         (-[WebHistory saveToURL:error:]):
236         * History/WebHistoryItem.mm:
237         (WKNotifyHistoryItemChanged):
238         (+[WebHistoryItem initialize]):
239         (-[WebHistoryItem initFromDictionaryRepresentation:]):
240         * History/WebURLsWithTitles.m:
241         * Misc/WebCache.mm:
242         (+[WebCache initialize]):
243         * Misc/WebDownload.mm:
244         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
245         * Misc/WebElementDictionary.mm:
246         (+[WebElementDictionary initialize]):
247         (+[WebElementDictionary initializeLookupTable]):
248         * Misc/WebIconDatabase.mm:
249         * Misc/WebKitNSStringExtras.mm:
250         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
251         * Misc/WebKitVersionChecks.h:
252         * Misc/WebKitVersionChecks.mm:
253         (WebKitLinkedOnOrAfter):
254         (WebKitLinkTimeVersion):
255         * Misc/WebLocalizableStrings.mm:
256         * Misc/WebNSControlExtras.h:
257         * Misc/WebNSControlExtras.m:
258         * Misc/WebNSEventExtras.m:
259         * Misc/WebNSFileManagerExtras.mm:
260         * Misc/WebNSImageExtras.h:
261         * Misc/WebNSImageExtras.m:
262         * Misc/WebNSPasteboardExtras.mm:
263         * Misc/WebNSPrintOperationExtras.h:
264         * Misc/WebNSPrintOperationExtras.m:
265         * Misc/WebNSViewExtras.m:
266         * Misc/WebNSWindowExtras.m:
267         * Panels/WebAuthenticationPanel.h:
268         * Panels/WebAuthenticationPanel.m:
269         * Panels/WebPanelAuthenticationHandler.m:
270         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
271         (+[WebHostedNetscapePluginView initialize]):
272         * Plugins/WebBasePluginPackage.h:
273         * Plugins/WebBasePluginPackage.mm:
274         * Plugins/WebJavaPlugIn.h:
275         * Plugins/WebPluginContainerCheck.mm:
276         * Plugins/WebPluginController.h:
277         * Plugins/WebPluginController.mm:
278         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
279         (-[WebPluginController addPlugin:]):
280         (-[WebPluginController destroyPlugin:]):
281         (-[WebPluginController destroyAllPlugins]):
282         * Plugins/WebPluginDatabase.mm:
283         (+[WebPluginDatabase _defaultPlugInPaths]):
284         * Plugins/WebPluginPackage.mm:
285         (-[WebPluginPackage initWithPath:]):
286         * Storage/WebDatabaseManager.mm:
287         (-[WebDatabaseManager deleteAllDatabases]):
288         * Storage/WebDatabaseManagerClient.h:
289         * Storage/WebDatabaseManagerClient.mm:
290         (WebDatabaseManagerClient::WebDatabaseManagerClient):
291         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
292         * Storage/WebStorageManager.mm:
293         (-[WebStorageManager deleteAllOrigins]):
294         (WebKitInitializeStorageIfNecessary):
295         * WebCoreSupport/WebAlternativeTextClient.h:
296         * WebCoreSupport/WebApplicationCache.mm:
297         (applicationCacheBundleIdentifier):
298         * WebCoreSupport/WebChromeClient.h:
299         * WebCoreSupport/WebChromeClient.mm:
300         (WebChromeClient::setWindowRect):
301         (WebChromeClient::windowRect):
302         (WebChromeClient::takeFocus):
303         (WebChromeClient::addMessageToConsole):
304         (WebChromeClient::enableSuddenTermination):
305         (WebChromeClient::disableSuddenTermination):
306         (WebChromeClient::createPopupMenu const):
307         (WebChromeClient::createSearchPopupMenu const):
308         (WebChromeClient::shouldPaintEntireContents const):
309         (WebChromeClient::supportsVideoFullscreen):
310         (WebChromeClient::supportsFullScreenForElement):
311         (WebChromeClient::enterFullScreenForElement):
312         (WebChromeClient::exitFullScreenForElement):
313         * WebCoreSupport/WebContextMenuClient.mm:
314         * WebCoreSupport/WebDragClient.mm:
315         * WebCoreSupport/WebEditorClient.h:
316         * WebCoreSupport/WebEditorClient.mm:
317         (+[WebUndoStep initialize]):
318         (updateFontPanel):
319         (WebEditorClient::didBeginEditing):
320         (WebEditorClient::respondToChangedContents):
321         (WebEditorClient::respondToChangedSelection):
322         (WebEditorClient::canceledComposition):
323         (WebEditorClient::didEndEditing):
324         (WebEditorClient::didWriteSelectionToPasteboard):
325         (attributesForAttributedStringConversion):
326         (WebEditorClient::setInsertionPasteboard):
327         (WebEditorClient::registerUndoOrRedoStep):
328         (WebEditorClient::handleKeyboardEvent):
329         (WebEditorClient::handleInputMethodKeydown):
330         (WebEditorClient::textDidChangeInTextField):
331         (WebEditorClient::requestCheckingOfString):
332         * WebCoreSupport/WebFrameLoaderClient.h:
333         * WebCoreSupport/WebFrameLoaderClient.mm:
334         (WebFrameLoaderClient::detachedFromParent2):
335         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
336         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
337         (WebFrameLoaderClient::dispatchWillSendRequest):
338         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
339         (WebFrameLoaderClient::dispatchDidReceiveResponse):
340         (WebFrameLoaderClient::willCacheResponse const):
341         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
342         (WebFrameLoaderClient::dispatchDidFinishLoading):
343         (WebFrameLoaderClient::dispatchDidFailLoading):
344         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
345         (WebFrameLoaderClient::dispatchWillClose):
346         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
347         (WebFrameLoaderClient::dispatchDidCommitLoad):
348         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
349         (WebFrameLoaderClient::dispatchDidFailLoad):
350         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
351         (WebFrameLoaderClient::dispatchDidFinishLoad):
352         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
353         (WebFrameLoaderClient::willChangeTitle):
354         (WebFrameLoaderClient::didChangeTitle):
355         (WebFrameLoaderClient::didReplaceMultipartContent):
356         (WebFrameLoaderClient::updateGlobalHistory):
357         (WebFrameLoaderClient::saveViewStateToItem):
358         (WebFrameLoaderClient::restoreViewState):
359         (WebFrameLoaderClient::provisionalLoadStarted):
360         (WebFrameLoaderClient::prepareForDataSourceReplacement):
361         (WebFrameLoaderClient::setTitle):
362         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
363         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
364         (WebFrameLoaderClient::transitionToCommittedForNewPage):
365         (WebFrameLoaderClient::didRestoreFromPageCache):
366         (WebFrameLoaderClient::actionDictionary const):
367         (WebFrameLoaderClient::createPlugin):
368         (WebFrameLoaderClient::getLoadDecisionForIcons):
369         (WebFrameLoaderClient::finishedLoadingIcon):
370         (+[WebFramePolicyListener initialize]):
371         * WebCoreSupport/WebFrameNetworkingContext.mm:
372         * WebCoreSupport/WebGeolocationClient.h:
373         * WebCoreSupport/WebGeolocationClient.mm:
374         (WebGeolocationClient::requestPermission):
375         * WebCoreSupport/WebInspectorClient.h:
376         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
377         * WebCoreSupport/WebNotificationClient.mm:
378         * WebCoreSupport/WebOpenPanelResultListener.mm:
379         * WebCoreSupport/WebPlatformStrategies.h:
380         * WebCoreSupport/WebPlatformStrategies.mm:
381         * WebCoreSupport/WebProgressTrackerClient.h:
382         * WebCoreSupport/WebProgressTrackerClient.mm:
383         (WebProgressTrackerClient::progressStarted):
384         (WebProgressTrackerClient::progressEstimateChanged):
385         (WebProgressTrackerClient::progressFinished):
386         * WebCoreSupport/WebSecurityOrigin.mm:
387         * WebInspector/WebNodeHighlight.h:
388         * WebInspector/WebNodeHighlight.mm:
389         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
390         (-[WebNodeHighlight dealloc]):
391         (-[WebNodeHighlight attach]):
392         * WebInspector/WebNodeHighlightView.h:
393         * WebInspector/WebNodeHighlightView.mm:
394         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
395         (-[WebNodeHighlightView dealloc]):
396         * WebInspector/WebNodeHighlighter.mm:
397         (-[WebNodeHighlighter highlight]):
398         * WebView/WebArchive.mm:
399         (+[WebArchivePrivate initialize]):
400         * WebView/WebClipView.h:
401         * WebView/WebDataSource.mm:
402         (WebDataSourcePrivate::WebDataSourcePrivate):
403         (+[WebDataSource initialize]):
404         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
405         (-[WebDataSource _makeRepresentation]):
406         * WebView/WebDelegateImplementationCaching.h:
407         * WebView/WebDelegateImplementationCaching.mm:
408         (CallDelegate):
409         (CallDelegateReturningFloat):
410         (CallDelegateReturningBoolean):
411         (CallUIDelegate):
412         (CallUIDelegateReturningFloat):
413         (CallUIDelegateReturningBoolean):
414         (CallFrameLoadDelegate):
415         (CallFrameLoadDelegateReturningBoolean):
416         (CallResourceLoadDelegate):
417         (CallScriptDebugDelegate):
418         (CallFormDelegate):
419         (CallFormDelegateReturningBoolean):
420         * WebView/WebDeviceOrientation.mm:
421         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
422         * WebView/WebDocumentInternal.h:
423         * WebView/WebDocumentLoaderMac.mm:
424         (needsDataLoadWorkaround):
425         * WebView/WebDynamicScrollBarsViewInternal.h:
426         * WebView/WebFormDelegate.m:
427         * WebView/WebFrame.mm:
428         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
429         (-[WebFrame _unmarkAllMisspellings]):
430         (-[WebFrame _paintBehaviorForDestinationContext:]):
431         (-[WebFrame _drawRect:contentsOnly:]):
432         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
433         (-[WebFrame _scrollDOMRangeToVisible:]):
434         (-[WebFrame _bodyBackgroundColor]):
435         (-[WebFrame accessibilityRoot]):
436         (needsMicrosoftMessengerDOMDocumentWorkaround):
437         * WebView/WebFrameInternal.h:
438         * WebView/WebFrameView.mm:
439         (-[WebFrameView _setDocumentView:]):
440         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
441         (-[WebFrameView _viewClassForMIMEType:]):
442         (-[WebFrameView initWithFrame:]):
443         (-[WebFrameView drawRect:]):
444         (-[WebFrameView _firstResponderIsFormControl]):
445         (-[WebFrameView keyDown:keyDown:]):
446         (-[WebFrameView _isScrollable]):
447         * WebView/WebFullScreenController.h:
448         * WebView/WebFullScreenController.mm:
449         * WebView/WebHTMLRepresentation.mm:
450         * WebView/WebHTMLView.mm:
451         (-[WebHTMLView hitTest:]):
452         (-[WebHTMLView initWithFrame:]):
453         (-[WebHTMLView dealloc]):
454         (-[WebHTMLView addSubview:]):
455         (-[WebHTMLView mouseDown:]):
456         (-[WebHTMLView mouseUp:]):
457         (-[WebHTMLView resignFirstResponder]):
458         (-[WebHTMLView accessibilityHitTest:]):
459         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
460         * WebView/WebHTMLViewInternal.h:
461         * WebView/WebIndicateLayer.h:
462         * WebView/WebIndicateLayer.mm:
463         * WebView/WebMediaPlaybackTargetPicker.h:
464         * WebView/WebMediaPlaybackTargetPicker.mm:
465         * WebView/WebPDFDocumentExtras.h:
466         * WebView/WebPDFDocumentExtras.mm:
467         * WebView/WebPDFRepresentation.h:
468         * WebView/WebPDFRepresentation.mm:
469         * WebView/WebPDFView.h:
470         * WebView/WebPreferences.mm:
471         (cacheModelForMainBundle):
472         (WebPreferencesPrivate::WebPreferencesPrivate):
473         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
474         (-[WebPreferences encodeWithCoder:]):
475         (+[WebPreferences standardPreferences]):
476         (+[WebPreferences initialize]):
477         (-[WebPreferences _valueForKey:]):
478         (-[WebPreferences _setStringValue:forKey:]):
479         (-[WebPreferences _setIntegerValue:forKey:]):
480         (-[WebPreferences _setUnsignedIntValue:forKey:]):
481         (-[WebPreferences _setFloatValue:forKey:]):
482         (-[WebPreferences _setBoolValue:forKey:]):
483         (-[WebPreferences _setLongLongValue:forKey:]):
484         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
485         (-[WebPreferences _postCacheModelChangedNotification]):
486         (-[WebPreferences _postPreferencesChangedNotification]):
487         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
488         (-[WebPreferences setStorageBlockingPolicy:]):
489         * WebView/WebResource.mm:
490         (+[WebResourcePrivate initialize]):
491         * WebView/WebTextCompletionController.h:
492         * WebView/WebTextIterator.mm:
493         (+[WebTextIteratorPrivate initialize]):
494         * WebView/WebView.mm:
495         (shouldEnableLoadDeferring):
496         (shouldRestrictWindowFocus):
497         (shouldRespectPriorityInCSSAttributeSetters):
498         (shouldUseLegacyBackgroundSizeShorthandBehavior):
499         (shouldAllowPictureInPictureMediaPlayback):
500         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
501         (shouldAllowWindowOpenWithoutUserGesture):
502         (shouldConvertInvalidURLsToBlank):
503         (shouldRequireUserGestureToLoadVideo):
504         (-[WebView _commonInitializationWithFrameName:groupName:]):
505         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
506         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
507         (-[WebView _closePluginDatabases]):
508         (-[WebView _closeWithFastTeardown]):
509         (-[WebView _close]):
510         (+[WebView _MIMETypeForFile:]):
511         (-[WebView setShowingInspectorIndication:]):
512         (-[WebView _setFormDelegate:]):
513         (-[WebView _needsPreHTML5ParserQuirks]):
514         (-[WebView _preferencesChangedNotification:]):
515         (-[WebView _preferencesChanged:]):
516         (-[WebView _cacheResourceLoadDelegateImplementations]):
517         (-[WebView _cacheFrameLoadDelegateImplementations]):
518         (-[WebView _policyDelegateForwarder]):
519         (-[WebView _UIDelegateForwarder]):
520         (-[WebView _editingDelegateForwarder]):
521         (-[WebView _updateActiveState]):
522         (-[_WebSafeForwarder forwardInvocation:]):
523         (+[WebView initialize]):
524         (-[WebView _pluginForMIMEType:]):
525         (-[WebView _pluginForExtension:]):
526         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
527         (+[WebView canShowMIMETypeAsHTML:]):
528         (-[WebView _initWithArguments:]):
529         (-[WebView initWithFrame:frameName:groupName:]):
530         (-[WebView dealloc]):
531         (-[WebView close]):
532         (-[WebView viewDidMoveToWindow]):
533         (-[WebView setUIDelegate:]):
534         (-[WebView setResourceLoadDelegate:]):
535         (-[WebView setPolicyDelegate:]):
536         (-[WebView setFrameLoadDelegate:]):
537         (-[WebView goBack]):
538         (-[WebView goForward]):
539         (-[WebView stringByEvaluatingJavaScriptFromString:]):
540         (-[WebView setHostWindow:]):
541         (-[WebView becomeFirstResponder]):
542         (+[WebView _cacheModelChangedNotification:]):
543         (-[WebView _frameViewAtWindowPoint:]):
544         (+[WebView _preflightSpellCheckerNow:]):
545         (+[WebView _preflightSpellChecker]):
546         (-[WebView canGoBack]):
547         (-[WebView canGoForward]):
548         (-[WebView stopLoading:]):
549         (-[WebView reload:]):
550         (-[WebView setMainFrameDocumentReady:]):
551         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
552         (-[WebView setContinuousSpellCheckingEnabled:]):
553         (-[WebView undoManager]):
554         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
555         (-[WebView isAutomaticLinkDetectionEnabled]):
556         (-[WebView isAutomaticDashSubstitutionEnabled]):
557         (-[WebView isAutomaticTextReplacementEnabled]):
558         (-[WebView isAutomaticSpellingCorrectionEnabled]):
559         (+[WebView _setCacheModel:]):
560         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
561         (-[WebView _keyboardUIMode]):
562         (LayerFlushController::flushLayers):
563         (-[WebView _scheduleCompositingLayerFlush]):
564         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
565         (-[WebView fullScreenPlaceholderView]):
566         (WebInstallMemoryPressureHandler):
567         * WebView/WebViewData.h:
568         * WebView/WebViewData.mm:
569         (+[WebViewPrivate initialize]):
570         (-[WebViewPrivate init]):
571         (-[WebViewPrivate dealloc]):
572         * WebView/WebViewInternal.h:
573
574 2018-10-18  Alex Christensen  <achristensen@webkit.org>
575
576         Clean up FrameLoader two-state enums
577         https://bugs.webkit.org/show_bug.cgi?id=190731
578
579         Reviewed by Chris Dumez.
580
581         * WebCoreSupport/WebFrameLoaderClient.h:
582         * WebCoreSupport/WebFrameLoaderClient.mm:
583         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
584
585 2018-10-18  Alex Christensen  <achristensen@webkit.org>
586
587         Unreviewed, rolling out r237137.
588
589         SPI is actually used
590
591         Reverted changeset:
592
593         "Remove unused WebFrame._loadType"
594         https://bugs.webkit.org/show_bug.cgi?id=190583
595         https://trac.webkit.org/changeset/237137
596
597 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
598
599         Enable the datalist element by default on iOS and macOS
600         https://bugs.webkit.org/show_bug.cgi?id=190594
601         <rdar://problem/45281159>
602
603         Reviewed by Ryosuke Niwa and Tim Horton.
604
605         * Configurations/FeatureDefines.xcconfig:
606
607 2018-10-17  Alex Christensen  <achristensen@webkit.org>
608
609         BackForwardClient needs to be able to support UIProcess-only back/forward lists
610         https://bugs.webkit.org/show_bug.cgi?id=190675
611
612         Reviewed by Chris Dumez.
613
614         * History/BackForwardList.h:
615         * History/BackForwardList.mm:
616         (BackForwardList::backItem):
617         (BackForwardList::currentItem):
618         (BackForwardList::forwardItem):
619         (BackForwardList::backListCount const):
620         (BackForwardList::forwardListCount const):
621         (BackForwardList::itemAtIndex):
622         * History/WebBackForwardList.mm:
623         (-[WebBackForwardList backItem]):
624         (-[WebBackForwardList currentItem]):
625         (-[WebBackForwardList forwardItem]):
626         (-[WebBackForwardList itemAtIndex:]):
627
628 2018-10-16  Timothy Hatcher  <timothy@apple.com>
629
630         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
631         https://bugs.webkit.org/show_bug.cgi?id=190526
632         rdar://problem/45230140
633
634         Reviewed by Dean Jackson.
635
636         * WebCoreSupport/WebEditorClient.mm:
637         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
638
639 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
640
641         Implement feature flag and bindings for CSS Painting API
642         https://bugs.webkit.org/show_bug.cgi?id=190237
643
644         Reviewed by Ryosuke Niwa.
645
646         * Configurations/FeatureDefines.xcconfig:
647
648 2018-10-16  Alex Christensen  <achristensen@webkit.org>
649
650         Replace HistoryItem* with HistoryItem& where possible
651         https://bugs.webkit.org/show_bug.cgi?id=190617
652
653         Reviewed by Chris Dumez.
654
655         * History/BackForwardList.h:
656         * History/BackForwardList.mm:
657         (BackForwardList::goToItem):
658         * History/WebBackForwardList.mm:
659         (-[WebBackForwardList goToItem:]):
660         * History/WebHistoryItem.mm:
661         (WKNotifyHistoryItemChanged):
662         * History/WebHistoryItemInternal.h:
663
664 2018-10-16  Alex Christensen  <achristensen@webkit.org>
665
666         Remove unused WebHistoryItem._transientPropertyForKey
667         https://bugs.webkit.org/show_bug.cgi?id=190606
668
669         Reviewed by Chris Dumez.
670
671         * History/WebHistoryItem.mm:
672         * History/WebHistoryItemPrivate.h:
673
674 2018-10-15  Justin Fan  <justin_fan@apple.com>
675
676         Add WebGPU 2018 feature flag and experimental feature flag
677         https://bugs.webkit.org/show_bug.cgi?id=190509
678
679         Reviewed by Dean Jackson.
680
681         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
682         for the 2018 WebGPU prototype.
683
684         * Configurations/FeatureDefines.xcconfig:
685         * WebView/WebPreferenceKeysPrivate.h:
686         * WebView/WebPreferences.mm:
687         (+[WebPreferences initialize]):
688         (-[WebPreferences webGPUEnabled]):
689         (-[WebPreferences setWebGPUEnabled:]):
690         * WebView/WebPreferencesPrivate.h:
691         * WebView/WebView.mm:
692         (-[WebView _preferencesChanged:]):
693
694 2018-10-15  Alex Christensen  <achristensen@webkit.org>
695
696         Fix iOS build after r237157
697
698         * WebView/WebView.mm:
699         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
700
701 2018-10-15  Alex Christensen  <achristensen@webkit.org>
702
703         Modernize BackForwardClient.h
704         https://bugs.webkit.org/show_bug.cgi?id=190610
705
706         Reviewed by Chris Dumez.
707
708         * History/BackForwardList.h:
709         * History/BackForwardList.mm:
710         (BackForwardList::backListCount const):
711         (BackForwardList::forwardListCount const):
712         (BackForwardList::backListCount): Deleted.
713         (BackForwardList::forwardListCount): Deleted.
714         * History/WebBackForwardList.mm:
715         (-[WebBackForwardList init]):
716         * WebCoreSupport/WebFrameLoaderClient.mm:
717         (WebFrameLoaderClient::canCachePage const):
718         * WebView/WebFrameView.mm:
719         (-[WebFrameView keyDown:keyDown:]):
720         * WebView/WebView.mm:
721         (-[WebView _commonInitializationWithFrameName:groupName:]):
722         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
723         (-[WebView _loadBackForwardListFromOtherView:]):
724         (-[WebView initWithCoder:]):
725         (-[WebView encodeWithCoder:]):
726         (-[WebView backForwardList]):
727         (-[WebView setMaintainsBackForwardList:]):
728
729 2018-10-15  Timothy Hatcher  <timothy@apple.com>
730
731         Add support for prefers-color-scheme media query
732         https://bugs.webkit.org/show_bug.cgi?id=190499
733         rdar://problem/45212025
734
735         Reviewed by Dean Jackson.
736
737         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
738
739 2018-10-15  Alex Christensen  <achristensen@webkit.org>
740
741         Remove unused WebView._globalHistoryItem
742         https://bugs.webkit.org/show_bug.cgi?id=190601
743
744         Reviewed by Chris Dumez.
745
746         * WebCoreSupport/WebFrameLoaderClient.h:
747         * WebCoreSupport/WebFrameLoaderClient.mm:
748         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
749         * WebView/WebView.mm:
750         (-[WebView _globalHistoryItem]): Deleted.
751         (-[WebView _setGlobalHistoryItem:]): Deleted.
752         * WebView/WebViewData.h:
753         * WebView/WebViewInternal.h:
754         * WebView/WebViewPrivate.h:
755
756 2018-10-15  Alex Christensen  <achristensen@webkit.org>
757
758         Remove unused parameters from FrameLoaderClient::createFrame
759         https://bugs.webkit.org/show_bug.cgi?id=190587
760
761         Reviewed by Chris Dumez.
762
763         * WebCoreSupport/WebFrameLoaderClient.h:
764         * WebCoreSupport/WebFrameLoaderClient.mm:
765         (WebFrameLoaderClient::createFrame):
766
767 2018-10-15  Alex Christensen  <achristensen@webkit.org>
768
769         Remove unused WebFrame._loadType
770         https://bugs.webkit.org/show_bug.cgi?id=190583
771
772         Reviewed by Chris Dumez.
773
774         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
775
776         * WebView/WebFrame.mm:
777         (toWebFrameLoadType): Deleted.
778         (-[WebFrame _loadType]): Deleted.
779         * WebView/WebFramePrivate.h:
780
781 2018-10-15  Chris Dumez  <cdumez@apple.com>
782
783         Restrict browsing context lookup by name to frames that are related to one another
784         https://bugs.webkit.org/show_bug.cgi?id=190475
785
786         Reviewed by Alex Christensen.
787
788         * WebView/WebFrame.mm:
789         (-[WebFrame findFrameNamed:]):
790
791 2018-10-15  Alex Christensen  <achristensen@webkit.org>
792
793         Remove InjectedBundle processing of back/forward lists
794         https://bugs.webkit.org/show_bug.cgi?id=190459
795
796         Reviewed by Chris Dumez.
797
798         * WebCoreSupport/WebFrameLoaderClient.h:
799         * WebCoreSupport/WebFrameLoaderClient.mm:
800         (WebFrameLoaderClient::shouldGoToHistoryItem const):
801
802 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
803
804         [JSC] Remove Option::useAsyncIterator
805         https://bugs.webkit.org/show_bug.cgi?id=190567
806
807         Reviewed by Saam Barati.
808
809         * Configurations/FeatureDefines.xcconfig:
810
811 2018-10-12  Alex Christensen  <achristensen@webkit.org>
812
813         Allow encoding of small enum classes
814         https://bugs.webkit.org/show_bug.cgi?id=190531
815
816         Reviewed by Tim Horton.
817
818         * WebCoreSupport/WebFrameLoaderClient.mm:
819         (-[WebFramePolicyListener dealloc]):
820
821 2018-10-11  Keith Rollin  <krollin@apple.com>
822
823         CURRENT_ARCH should not be used in Run Script phase.
824         https://bugs.webkit.org/show_bug.cgi?id=190407
825         <rdar://problem/45133556>
826
827         Reviewed by Alexey Proskuryakov.
828
829         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
830         CURRENT_ARCH is not well-defined during this phase (and may even have
831         the value "undefined") since this phase is run just once per build
832         rather than once per supported architecture. Migrate away from
833         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
834         performing an operation for each value, or by picking the first entry
835         in ARCHS and using that as a representative value.
836
837         * Configurations/WebKitLegacy.xcconfig: When generating
838         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
839         macosx platforms.
840
841         * MigrateHeaders.make:
842         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
843         generate one for each architecture in ARCHS.
844
845 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
846
847         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
848         https://bugs.webkit.org/show_bug.cgi?id=190429
849
850         Reviewed by Saam Barati.
851
852         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
853
854         * WebView/WebPDFRepresentation.mm:
855         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
856
857 2018-10-08  Justin Fan  <justin_fan@apple.com>
858
859         WebGPU: Rename old WebGPU prototype to WebMetal
860         https://bugs.webkit.org/show_bug.cgi?id=190325
861         <rdar://problem/44990443>
862
863         Reviewed by Dean Jackson.
864
865         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
866
867         * Configurations/FeatureDefines.xcconfig:
868         * WebView/WebPreferenceKeysPrivate.h:
869         * WebView/WebPreferences.mm:
870         (+[WebPreferences initialize]):
871         (-[WebPreferences webMetalEnabled]):
872         (-[WebPreferences setWebMetalEnabled:]):
873         (-[WebPreferences webGPUEnabled]): Deleted.
874         (-[WebPreferences setWebGPUEnabled:]): Deleted.
875         * WebView/WebPreferencesPrivate.h:
876         * WebView/WebView.mm:
877         (-[WebView _preferencesChanged:]):
878
879 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
880
881         Make <input type=color> a runtime enabled (on-by-default) feature
882         https://bugs.webkit.org/show_bug.cgi?id=189162
883
884         Reviewed by Wenson Hsieh and Tim Horton.
885
886         * Configurations/FeatureDefines.xcconfig:
887
888 2018-10-07  Dan Bernstein  <mitz@apple.com>
889
890         Fixed building with the latest macOS SDK
891
892         * Plugins/WebNetscapePluginPackage.mm:
893         (-[WebNetscapePluginPackage openResourceFile]):
894         (-[WebNetscapePluginPackage closeResourceFile:]):
895
896 2018-10-04  Dan Bernstein  <mitz@apple.com>
897
898         More Carbon build-fixing.
899
900         * Carbon/CarbonWindowAdapter.mm:
901         (-[CarbonWindowAdapter _destroyRealWindow:]):
902         (-[CarbonWindowAdapter _growBoxRect]):
903
904 2018-10-04  Dan Bernstein  <mitz@apple.com>
905
906         Retried to fix 32-bit macOS builds after r236846.
907
908         * WebView/WebHTMLView.mm:
909         (-[WebHTMLView setMarkedText:selectedRange:]):
910
911 2018-10-04  Dan Bernstein  <mitz@apple.com>
912
913         Retried to fix 32-bit macOS builds after r236846.
914
915         * Carbon/HIWebView.mm:
916         (ActiveStateChanged):
917
918 2018-10-04  Dan Bernstein  <mitz@apple.com>
919
920         Tried to fix 32-bit macOS builds after r236846.
921
922         * Carbon/HIWebView.mm:
923         (_NSSelectorForHICommand):
924
925 2018-10-04  Dan Bernstein  <mitz@apple.com>
926
927         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
928         https://bugs.webkit.org/show_bug.cgi?id=190250
929
930         Reviewed by Andy Estes.
931
932         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
933           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
934           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
935           an earlier line set it to YES.
936
937         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
938         changes below.
939
940         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
941           provides some missing method declarations.
942
943         * Misc/WebDownload.mm:
944         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
945           a deprecated method.
946
947         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
948
949         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
950           other code in the file uses a method from it.
951
952         * Plugins/WebBaseNetscapePluginView.mm:
953         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
954           a deprecated method.
955
956         * Plugins/WebPluginController.mm:
957         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
958           around use of a selector that may be present in some WebKit client.
959
960         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
961           method declarations.
962
963         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
964           from here.
965
966         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
967           missing method declarations.
968
969         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
970           from here.
971
972         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
973           call from here.
974         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
975           an obsolete delegate method for binary compatibility.
976         (pluginView): Ditto.
977
978         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
979           call from here.
980
981         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
982           WebDeviceOrientationProviderMock protocol.
983
984         * WebView/WebDeviceOrientationProviderMock.mm:
985         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
986           main @implementation.
987
988         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
989           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
990
991         * WebView/WebDynamicScrollBarsView.mm:
992         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
993           of a deprecated method.
994
995         * WebView/WebHTMLView.mm:
996         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
997           selector warning around action methods that are not declared anywhere in WebKit.
998
999         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
1000           about implementing this deprecated method.
1001         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
1002         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
1003         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1004         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
1005         (-[WebHTMLView characterIndexForPoint:]): Ditto.
1006         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1007         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1008         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1009         (-[WebHTMLView doCommandBySelector:]): Ditto.
1010         (-[WebHTMLView insertText:]): Ditto.
1011
1012         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
1013
1014         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
1015
1016         * WebView/WebPDFView.h: Removed previewView ivar.
1017
1018         * WebView/WebPDFView.mm:
1019           Removed declaration of FileInternal category and merged its implementation with the main
1020           implementation.
1021         (-[WebPDFView dealloc]): Removed previewView ivar.
1022         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
1023           exist in macOS versions we support.
1024         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
1025         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
1026           action methods internal to PDFKit.
1027         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
1028         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
1029
1030         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
1031           call on macOS, even though in r86988 we started calling different methods on iOS.
1032
1033         * WebView/WebView.mm:
1034         - Imported headers that declare delegate methods that we call.
1035         - Removed declaration of WebFileInternal category and merged its implementation with the
1036           main implementation.
1037         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
1038           category, which made them impossible to call from the main implementation. Moved those
1039           into the main implementation. One of those had to be declared in a class extension,
1040           because it is called from a method implemented in the WebPrivate category, and that
1041           category’s implementation appears first in the file.
1042
1043         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
1044           around use of obsolete delegate method for binary compatibility.
1045
1046         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
1047
1048 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
1049
1050         Runtime flag and IDL for MediaRecorder
1051         https://bugs.webkit.org/show_bug.cgi?id=190018
1052
1053         Reviewed by Youenn Fablet and Chris Dumez.
1054
1055         * WebView/WebPreferenceKeysPrivate.h:
1056         * WebView/WebPreferences.mm:
1057         (+[WebPreferences initialize]):
1058         (-[WebPreferences mediaRecorderEnabled]):
1059         (-[WebPreferences setMediaRecorderEnabled:]):
1060         * WebView/WebPreferencesPrivate.h:
1061         * WebView/WebView.mm:
1062         (-[WebView _preferencesChanged:]):
1063
1064 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1065
1066         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
1067         https://bugs.webkit.org/show_bug.cgi?id=190238
1068
1069         Reviewed by Antti Koivisto.
1070
1071         Enabled the feature by default.
1072
1073         * WebView/WebPreferences.mm:
1074         (+[WebPreferences initialize]):
1075
1076 2018-10-01  Dean Jackson  <dino@apple.com>
1077
1078         [macOS] Switching to discrete GPU should be done in the UI process
1079         https://bugs.webkit.org/show_bug.cgi?id=189361
1080         <rdar://problem/43949622>
1081
1082         Reviewed by Simon Fraser.
1083
1084         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
1085         not support swapping to the discrete GPU in this configuration.
1086
1087         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
1088         (WebKit::WebSwitchingGPUClient::singleton):
1089         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
1090         * WebView/WebView.mm:
1091         (-[WebView _commonInitializationWithFrameName:groupName:]):
1092
1093 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1094
1095         Remove ParsedURLString
1096         https://bugs.webkit.org/show_bug.cgi?id=190154
1097
1098         Reviewed by Chris Dumez.
1099
1100         * WebView/WebScriptDebugger.mm:
1101         (toNSURL):
1102
1103 2018-10-01  Dean Jackson  <dino@apple.com>
1104
1105         Remove CSS Animation Triggers
1106         https://bugs.webkit.org/show_bug.cgi?id=190175
1107         <rdar://problem/44925626>
1108
1109         Reviewed by Simon Fraser.
1110
1111         * Configurations/FeatureDefines.xcconfig:
1112
1113 2018-10-02  Commit Queue  <commit-queue@webkit.org>
1114
1115         Unreviewed, rolling out r236624 and r236671.
1116         https://bugs.webkit.org/show_bug.cgi?id=190207
1117
1118         The change in r236624 introduced crashes on the bots
1119         (Requested by ryanhaddad on #webkit).
1120
1121         Reverted changesets:
1122
1123         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1124         https://bugs.webkit.org/show_bug.cgi?id=188747
1125         https://trac.webkit.org/changeset/236624
1126
1127         "Unify implementation in VideoFullscreenInterfaceAVKit"
1128         https://bugs.webkit.org/show_bug.cgi?id=190091
1129         https://trac.webkit.org/changeset/236671
1130
1131 2018-10-01  Alex Christensen  <achristensen@webkit.org>
1132
1133         URL should not use TextEncoding internally
1134         https://bugs.webkit.org/show_bug.cgi?id=190111
1135
1136         Reviewed by Andy Estes.
1137
1138         * Misc/WebNSURLExtras.mm:
1139
1140 2018-09-28  Jer Noble  <jer.noble@apple.com>
1141
1142         Refactoring: eliminate raw pointer usage in Fullscreen code
1143         https://bugs.webkit.org/show_bug.cgi?id=188747
1144         <rdar://problem/43541164>
1145
1146         Reviewed by Alex Christensen.
1147
1148         PlaybackSessionInterface no longer has an invalidate() method.
1149
1150         * WebView/WebView.mm:
1151         (-[WebView _clearPlaybackControlsManager]):
1152
1153 2018-09-28  Chris Dumez  <cdumez@apple.com>
1154
1155         Drop support for cross-origin-window-policy header
1156         https://bugs.webkit.org/show_bug.cgi?id=190081
1157
1158         Reviewed by Ryosuke Niwa.
1159
1160         * WebView/WebPreferenceKeysPrivate.h:
1161         * WebView/WebPreferences.mm:
1162         (+[WebPreferences initialize]):
1163         * WebView/WebPreferencesPrivate.h:
1164         * WebView/WebView.mm:
1165         (-[WebView _preferencesChanged:]):
1166
1167 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
1168
1169         Rename createMarkup to serializePreservingVisualAppearance
1170         https://bugs.webkit.org/show_bug.cgi?id=190086
1171
1172         Reviewed by Wenson Hsieh.
1173
1174         * DOM/WebDOMOperations.mm:
1175         (-[DOMRange markupString]):
1176
1177 2018-09-28  Commit Queue  <commit-queue@webkit.org>
1178
1179         Unreviewed, rolling out r236605.
1180         https://bugs.webkit.org/show_bug.cgi?id=190087
1181
1182         caused three API test timeouts (Requested by jernoble on
1183         #webkit).
1184
1185         Reverted changeset:
1186
1187         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1188         https://bugs.webkit.org/show_bug.cgi?id=188747
1189         https://trac.webkit.org/changeset/236605
1190
1191 2018-09-28  Jer Noble  <jer.noble@apple.com>
1192
1193         Refactoring: eliminate raw pointer usage in Fullscreen code
1194         https://bugs.webkit.org/show_bug.cgi?id=188747
1195         <rdar://problem/43541164>
1196
1197         Reviewed by Alex Christensen.
1198
1199         PlaybackSessionInterface no longer has an invalidate() method.
1200
1201         * WebView/WebView.mm:
1202         (-[WebView _clearPlaybackControlsManager]):
1203
1204 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1205
1206         Use enum class in createMarkup arguments
1207         https://bugs.webkit.org/show_bug.cgi?id=190028
1208
1209         Reviewed by Wenson Hsieh.
1210
1211         * DOM/WebDOMOperations.mm:
1212         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
1213         (-[DOMRange markupString]): Ditto.
1214
1215 2018-09-27  Antoine Quint  <graouts@apple.com>
1216
1217         [Web Animations] Turn Web Animations with CSS integration on
1218         https://bugs.webkit.org/show_bug.cgi?id=184819
1219         <rdar://problem/39597337>
1220
1221         Reviewed by Dean Jackson.
1222
1223         * WebView/WebPreferences.mm:
1224         (+[WebPreferences initialize]):
1225
1226 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1227
1228         Selection should work across shadow boundary when initiated by a mouse drag
1229         https://bugs.webkit.org/show_bug.cgi?id=151380
1230         <rdar://problem/24363872>
1231
1232         Reviewed by Wenson Hsieh.
1233
1234         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
1235
1236         * WebView/WebPreferenceKeysPrivate.h:
1237         * WebView/WebPreferences.mm:
1238         (+[WebPreferences initialize]):
1239         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
1240         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
1241         * WebView/WebPreferencesPrivate.h:
1242         * WebView/WebView.mm:
1243         (-[WebView _preferencesChanged:]):
1244
1245 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1246
1247         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
1248         https://bugs.webkit.org/show_bug.cgi?id=189918
1249         Work towards <rdar://problem/44648705>
1250
1251         Reviewed by Tim Horton.
1252
1253         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
1254
1255         * WebView/WebHTMLView.mm:
1256         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
1257         (-[WebHTMLView _updateFontPanel]):
1258         * WebView/WebView.mm:
1259         (-[WebView typingAttributes]):
1260
1261 2018-09-17  Darin Adler  <darin@apple.com>
1262
1263         Use OpaqueJSString rather than JSRetainPtr inside WebKit
1264         https://bugs.webkit.org/show_bug.cgi?id=189652
1265
1266         Reviewed by Saam Barati.
1267
1268         * WebView/WebPDFRepresentation.mm:
1269         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
1270
1271 2018-09-14  Jer Noble  <jer.noble@apple.com>
1272
1273         Turn SourceBufferChangeTypeEnabled on by default
1274         https://bugs.webkit.org/show_bug.cgi?id=189527
1275
1276         Reviewed by Eric Carlson.
1277
1278         * WebView/WebPreferences.mm:
1279         (+[WebPreferences initialize]):
1280
1281 2018-09-12  Alex Christensen  <achristensen@webkit.org>
1282
1283         Fix an internal build after r235935
1284         https://bugs.webkit.org/show_bug.cgi?id=188996
1285
1286         * Carbon/HIWebView.mm:
1287         (Draw):
1288         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
1289
1290 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
1291
1292         Add IGNORE_WARNING_.* macros
1293         https://bugs.webkit.org/show_bug.cgi?id=188996
1294
1295         Reviewed by Michael Catanzaro.
1296
1297         * Carbon/CarbonUtils.m:
1298         (PoolCleaner):
1299         * Carbon/CarbonWindowAdapter.mm:
1300         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1301         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1302         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1303         (-[CarbonWindowAdapter _termWindowIfOwner]):
1304         (-[CarbonWindowAdapter _windowMovedToRect:]):
1305         (-[CarbonWindowAdapter setContentView:]):
1306         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1307         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1308         * Carbon/CarbonWindowFrame.m:
1309         (-[CarbonWindowFrame title]):
1310         * Carbon/HIViewAdapter.m:
1311         (+[HIViewAdapter getHIViewForNSView:]):
1312         * Carbon/HIWebView.mm:
1313         (overrideCGContext):
1314         (restoreCGContext):
1315         (Draw):
1316         * DOM/DOM.mm:
1317         * History/WebHistory.mm:
1318         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1319         * History/WebHistoryItem.mm:
1320         (-[WebHistoryItem icon]):
1321         * Misc/WebKitNSStringExtras.mm:
1322         (-[NSString _web_drawAtPoint:font:textColor:]):
1323         * Misc/WebNSImageExtras.m:
1324         (-[NSImage _web_scaleToMaxSize:]):
1325         (-[NSImage _web_dissolveToFraction:]):
1326         * Misc/WebNSPasteboardExtras.mm:
1327         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1328         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1329         * Panels/WebAuthenticationPanel.m:
1330         (-[WebAuthenticationPanel loadNib]):
1331         * Plugins/Hosted/NetscapePluginHostManager.mm:
1332         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1333         (WebKit::NetscapePluginHostManager::didCreateWindow):
1334         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1335         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
1336         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
1337         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
1338         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1339         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
1340         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1341         (-[WebHostedNetscapePluginView drawRect:]):
1342         * Plugins/Hosted/WebTextInputWindowController.m:
1343         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1344         * Plugins/WebBaseNetscapePluginView.mm:
1345         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
1346         * Plugins/WebNetscapePluginPackage.mm:
1347         (-[WebNetscapePluginPackage _tryLoad]):
1348         * Plugins/WebNetscapePluginView.mm:
1349         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1350         (-[WebNetscapePluginView sendDrawRectEvent:]):
1351         (-[WebNetscapePluginView drawRect:]):
1352         * Plugins/WebPluginController.mm:
1353         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
1354         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
1355         * WebCoreSupport/PopupMenuMac.mm:
1356         (PopupMenuMac::populate):
1357         * WebCoreSupport/WebAlternativeTextClient.h:
1358         * WebCoreSupport/WebDragClient.mm:
1359         (WebDragClient::startDrag):
1360         * WebCoreSupport/WebFrameLoaderClient.mm:
1361         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1362         (webGetNSImage):
1363         * WebInspector/WebNodeHighlight.mm:
1364         * WebInspector/WebNodeHighlightView.mm:
1365         (-[WebNodeHighlightView drawRect:]):
1366         * WebView/WebClipView.mm:
1367         (-[WebClipView initWithFrame:]):
1368         * WebView/WebFrame.mm:
1369         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1370         (-[WebFrame _drawRect:contentsOnly:]):
1371         (-[WebFrame accessibilityRoot]):
1372         * WebView/WebFullScreenController.mm:
1373         (-[WebFullScreenController enterFullScreen:]):
1374         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1375         (-[WebFullScreenController exitFullScreen]):
1376         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1377         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1378         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1379         * WebView/WebHTMLView.mm:
1380         (-[NSWindow _web_borderView]):
1381         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
1382         (-[WebHTMLView _setAsideSubviews]):
1383         (-[WebHTMLView _autoscroll]):
1384         (-[WebHTMLView drawRect:]):
1385         (-[WebHTMLView mouseDown:]):
1386         (-[WebHTMLView mouseDragged:]):
1387         (-[WebHTMLView mouseUp:]):
1388         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
1389         (-[WebHTMLView knowsPageRange:]):
1390         (-[WebHTMLView accessibilityHitTest:]):
1391         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1392         (-[WebHTMLView _colorAsString:]):
1393         (-[WebHTMLView copyFont:]):
1394         (-[WebHTMLView _executeSavedKeypressCommands]):
1395         (-[WebHTMLView attachRootLayer:]):
1396         (-[WebHTMLView textStorage]):
1397         (-[WebHTMLView _updateSelectionForInputManager]):
1398         * WebView/WebPDFView.mm:
1399         (_applicationInfoForMIMEType):
1400         (-[WebPDFView centerSelectionInVisibleArea:]):
1401         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1402         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1403         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1404         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
1405         * WebView/WebTextCompletionController.mm:
1406         (-[WebTextCompletionController _buildUI]):
1407         (-[WebTextCompletionController _placePopupWindow:]):
1408         * WebView/WebVideoFullscreenController.mm:
1409         * WebView/WebVideoFullscreenHUDWindowController.mm:
1410         (createMediaUIBackgroundView):
1411         * WebView/WebView.mm:
1412         (-[WebTextListTouchBarViewController initWithWebView:]):
1413         (-[WebView _dispatchTileDidDraw:]):
1414         (-[WebView encodeWithCoder:]):
1415         (-[WebView mainFrameIcon]):
1416         (LayerFlushController::flushLayers):
1417         * WebView/WebWindowAnimation.mm:
1418         (setScaledFrameForWindow):
1419
1420 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1421
1422         Remove unused needsDestruction class variables from HashTraits
1423         https://bugs.webkit.org/show_bug.cgi?id=189490
1424
1425         Reviewed by Daniel Bates.
1426
1427         * History/BinaryPropertyList.cpp: Removed needsDestruction.
1428
1429 2018-09-07  Frederic Wang  <fwang@igalia.com>
1430
1431         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
1432         https://bugs.webkit.org/show_bug.cgi?id=182230
1433
1434         Reviewed by Simon Fraser.
1435
1436         * DOM/DOMDocument.mm:
1437         (-[DOMDocument scrollingElement]): Use the new name.
1438
1439 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1440
1441         Refactor WebCore::EditAction to be an 8-bit enum class
1442         https://bugs.webkit.org/show_bug.cgi?id=189383
1443
1444         Reviewed by Dan Bernstein.
1445
1446         * WebCoreSupport/WebEditorClient.mm:
1447         (undoNameForEditAction):
1448         * WebView/WebHTMLView.mm:
1449         (-[WebHTMLView pasteFont:]):
1450         (-[WebHTMLView changeFont:]):
1451         (-[WebHTMLView changeAttributes:]):
1452         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
1453         (-[WebHTMLView changeColor:]):
1454         * WebView/WebView.mm:
1455         (-[WebView setTypingStyle:]):
1456
1457 2018-09-06  Frederic Wang  <fwang@igalia.com>
1458
1459         Group options of scrollRectToVisible into a struct
1460         https://bugs.webkit.org/show_bug.cgi?id=189352
1461
1462         Reviewed by Simon Fraser.
1463
1464         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
1465         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
1466         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
1467
1468 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1469
1470         [macOS] Cannot change font size at selection until font panel is shown
1471         https://bugs.webkit.org/show_bug.cgi?id=189295
1472         <rdar://problem/35593389>
1473
1474         Reviewed by Ryosuke Niwa.
1475
1476         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
1477         WebCore ChangeLog for more details.
1478
1479         * WebView/WebHTMLView.mm:
1480         (-[WebHTMLView changeFont:]):
1481         (-[WebHTMLView changeAttributes:]):
1482         (-[WebHTMLView _originalFontA]): Deleted.
1483         (-[WebHTMLView _originalFontB]): Deleted.
1484         (fontNameForDescription): Deleted.
1485         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
1486         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
1487         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
1488
1489 2018-09-05  Jer Noble  <jer.noble@apple.com>
1490
1491         Add MediaCapabilities as an Experimental Feature
1492         https://bugs.webkit.org/show_bug.cgi?id=189209
1493
1494         Reviewed by Eric Carlson.
1495
1496         RuntimeEnabledFeature -> Setting.
1497
1498         * WebView/WebView.mm:
1499         (-[WebView _preferencesChanged:]):
1500
1501 2018-09-04  Frederic Wang  <fwang@igalia.com>
1502
1503         Add basic support for ScrollIntoViewOptions
1504         https://bugs.webkit.org/show_bug.cgi?id=189258
1505
1506         Reviewed by Simon Fraser.
1507
1508         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
1509         header so that this file can build despite the new scrollIntoView function.
1510
1511 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1512
1513         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
1514         https://bugs.webkit.org/show_bug.cgi?id=188890
1515         <rdar://problem/43648605>
1516
1517         Reviewed by Tim Horton.
1518
1519         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
1520         more detail.
1521
1522         * WebCoreSupport/WebPlatformStrategies.h:
1523         * WebCoreSupport/WebPlatformStrategies.mm:
1524         (WebPlatformStrategies::allStringsForType):
1525
1526 2018-09-01  Darin Adler  <darin@apple.com>
1527
1528         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
1529         https://bugs.webkit.org/show_bug.cgi?id=189072
1530         Reviewed by Dan Bernstein.
1531
1532         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
1533         and declarations for NSURLDownload init methods.
1534
1535         * Misc/WebDownloadInternal.h: Removed.
1536
1537         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
1538         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
1539         "-Wdeprecated-declarations" because the method used here is deprecated.
1540
1541         * WebView/WebView.mm:
1542         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
1543         used here is deprecated.
1544
1545 2018-08-31  Chris Dumez  <cdumez@apple.com>
1546
1547         Assertion hit in ~CompletionHandler() from ~WebFrame()
1548         https://bugs.webkit.org/show_bug.cgi?id=189199
1549         <rdar://problem/42657233>
1550
1551         Reviewed by Youenn Fablet.
1552
1553         * WebCoreSupport/WebFrameLoaderClient.h:
1554         * WebCoreSupport/WebFrameLoaderClient.mm:
1555         (WebFrameLoaderClient::dispatchWillSubmitForm):
1556
1557 2018-08-31  Antti Koivisto  <antti@apple.com>
1558
1559         Replace OptionSet |= and -= operators with add() and remove() functions
1560         https://bugs.webkit.org/show_bug.cgi?id=189169
1561
1562         Reviewed by Anders Carlsson.
1563
1564         * WebView/WebFrame.mm:
1565         (-[WebFrame _drawRect:contentsOnly:]):
1566         * WebView/WebView.mm:
1567         (coreOptions):
1568
1569 2018-08-31  Frederic Wang  <fwang@igalia.com>
1570
1571         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1572         https://bugs.webkit.org/show_bug.cgi?id=182053
1573
1574         Reviewed by Simon Fraser.
1575
1576         Add developer flag to use standard behavior for scrolling* attributes.
1577
1578         * WebView/WebPreferenceKeysPrivate.h:
1579         * WebView/WebPreferences.mm:
1580         (+[WebPreferences initialize]):
1581         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
1582         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
1583         * WebView/WebPreferencesPrivate.h:
1584         * WebView/WebView.mm:
1585         (-[WebView _preferencesChanged:]):
1586
1587 2018-08-29  Olivia Barnett  <obarnett@apple.com>
1588
1589         Implement the Web Share API
1590         https://bugs.webkit.org/show_bug.cgi?id=171100
1591         <rdar://problem/31751734>
1592
1593         Reviewed by Tim Horton.
1594
1595         * WebCoreSupport/WebChromeClient.h:
1596         * WebCoreSupport/WebChromeClient.mm:
1597         (WebChromeClient::showShareSheet):
1598         Empty declaration of showShareSheet.
1599
1600 2018-08-29  Youenn Fablet  <youenn@apple.com>
1601
1602         Remove WebRTC legacy API implementation
1603         https://bugs.webkit.org/show_bug.cgi?id=189040
1604
1605         Reviewed by Eric Carlson.
1606
1607         * WebView/WebPreferenceKeysPrivate.h:
1608         * WebView/WebPreferences.mm:
1609         (+[WebPreferences initialize]):
1610         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
1611         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
1612         * WebView/WebPreferencesPrivate.h:
1613         * WebView/WebView.mm:
1614         (-[WebView _preferencesChanged:]):
1615
1616 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1617
1618         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
1619         https://bugs.webkit.org/show_bug.cgi?id=189054
1620
1621         Reviewed by Andy Estes.
1622
1623         Remove the pasteboard type argument from readURLFromPasteboard.
1624
1625         * WebCoreSupport/WebPlatformStrategies.h:
1626         * WebCoreSupport/WebPlatformStrategies.mm:
1627         (WebPlatformStrategies::readURLFromPasteboard):
1628
1629 2018-08-27  Keith Rollin  <krollin@apple.com>
1630
1631         Unreviewed build fix -- disable LTO for production builds
1632
1633         * Configurations/Base.xcconfig:
1634
1635 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
1636
1637         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
1638         https://bugs.webkit.org/show_bug.cgi?id=188931
1639
1640         Reviewed by Wenson Hsieh.
1641
1642         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
1643
1644 2018-08-27  Keith Rollin  <krollin@apple.com>
1645
1646         Build system support for LTO
1647         https://bugs.webkit.org/show_bug.cgi?id=187785
1648         <rdar://problem/42353132>
1649
1650         Reviewed by Dan Bernstein.
1651
1652         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
1653         LTO.
1654
1655         * Configurations/Base.xcconfig:
1656         * Configurations/DebugRelease.xcconfig:
1657
1658 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
1659
1660         Pass in IsComposed flag to Event constructors
1661         https://bugs.webkit.org/show_bug.cgi?id=188720
1662         <rdar://problem/43580387>
1663
1664         Reviewed by Simon Fraser.
1665
1666         * WebView/WebPDFView.mm:
1667         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
1668         whether it's simulated or not.
1669
1670 2018-08-23  Mark Lam  <mark.lam@apple.com>
1671
1672         Move vmEntryGlobalObject() to VM from CallFrame.
1673         https://bugs.webkit.org/show_bug.cgi?id=188900
1674         <rdar://problem/43655753>
1675
1676         Reviewed by Michael Saboff.
1677
1678         * WebView/WebScriptDebugger.mm:
1679         (WebScriptDebugger::sourceParsed):
1680
1681 2018-08-23  Andy Estes  <aestes@apple.com>
1682
1683         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
1684         https://bugs.webkit.org/show_bug.cgi?id=188829
1685
1686         Reviewed by Tim Horton.
1687
1688         * Configurations/FeatureDefines.xcconfig:
1689
1690 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
1691
1692         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
1693         https://bugs.webkit.org/show_bug.cgi?id=188777
1694
1695         Reviewed by Simon Fraser.
1696
1697         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
1698         being "true" before the code change.
1699
1700         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
1701
1702         * WebView/WebPDFView.mm:
1703         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1704
1705 2018-08-21  Daniel Bates  <dabates@apple.com>
1706
1707         Replace TextCheckingTypeMask with OptionSet
1708         https://bugs.webkit.org/show_bug.cgi?id=188678
1709
1710         Reviewed by Antti Koivisto.
1711
1712         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
1713         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
1714         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
1715         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
1716
1717         * WebCoreSupport/WebEditorClient.h:
1718         * WebCoreSupport/WebEditorClient.mm:
1719         (WebEditorClient::checkTextOfParagraph):
1720         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
1721         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
1722         left as this is more readable and unncessary now that modern compilers like Clang have
1723         diagnostics to catch accidental assignments when equality was intended.
1724         (WebEditorClient::didCheckSucceed):
1725         * WebView/WebView.mm:
1726         (coreTextCheckingType):
1727         (textCheckingResultFromNSTextCheckingResult):
1728
1729 2018-08-21  Daniel Bates  <dabates@apple.com>
1730
1731         [iOS][WK1] Support toggling continuous spell checking from tests
1732         https://bugs.webkit.org/show_bug.cgi?id=188763
1733
1734         Reviewed by Simon Fraser.
1735
1736         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
1737         spell checking from tests in iOS WebKit Legacy.
1738
1739         * WebCoreSupport/WebEditorClient.h:
1740         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
1741         * WebCoreSupport/WebEditorClient.mm:
1742         * WebView/WebView.h:
1743         * WebView/WebView.mm:
1744         (-[WebView toggleContinuousSpellChecking:]):
1745         (-[WebView toggleSmartInsertDelete:]):
1746
1747 2018-08-17  Alex Christensen  <achristensen@webkit.org>
1748
1749         Add some plumbing for safe browsing
1750         https://bugs.webkit.org/show_bug.cgi?id=188709
1751
1752         Reviewed by Tim Horton.
1753
1754         * WebCoreSupport/WebFrameLoaderClient.h:
1755         * WebCoreSupport/WebFrameLoaderClient.mm:
1756         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1757
1758 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
1759
1760         Replace canBubble and cancelable booleans in Event by enum classes
1761         https://bugs.webkit.org/show_bug.cgi?id=188692
1762
1763         Reviewed by Alex Christensen.
1764
1765         * WebView/WebPDFView.mm:
1766         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1767         * WebView/WebView.mm:
1768         (-[WebView _dispatchUnloadEvent]):
1769
1770 2018-08-16  Jer Noble  <jer.noble@apple.com>
1771
1772         Add Experimental Feature support for SourceBuffer.changeType()
1773         https://bugs.webkit.org/show_bug.cgi?id=188626
1774         <rdar://problem/43356021>
1775
1776         Reviewed by Eric Carlson.
1777
1778         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
1779
1780         * WebView/WebPreferenceKeysPrivate.h:
1781         * WebView/WebPreferences.mm:
1782         (+[WebPreferences initialize]):
1783         (-[WebPreferences sourceBufferChangeTypeEnabled]):
1784         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
1785         * WebView/WebPreferencesPrivate.h:
1786         * WebView/WebView.mm:
1787         (-[WebView _preferencesChanged:]):
1788
1789 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
1790
1791         Support drag-and-drop for input[type=color]
1792         https://bugs.webkit.org/show_bug.cgi?id=188464
1793
1794         Reviewed by Wenson Hsieh.
1795
1796         * WebCoreSupport/WebPlatformStrategies.h:
1797         * WebCoreSupport/WebPlatformStrategies.mm:
1798         (WebPlatformStrategies::setColor):
1799
1800 2018-08-15  Tim Horton  <timothy_horton@apple.com>
1801
1802         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
1803         https://bugs.webkit.org/show_bug.cgi?id=188569
1804         <rdar://problem/34201095>
1805
1806         Reviewed by Megan Gardner.
1807
1808         * WebView/WebImmediateActionController.mm:
1809         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1810         Speculative fix; the crashes indicate font is null, but we just checked it,
1811         so it must be getting made null by convertFont:toSize:. Check again!
1812
1813 2018-08-13  Alex Christensen  <achristensen@webkit.org>
1814
1815         Use a 1-byte enum class for TextDirection
1816         https://bugs.webkit.org/show_bug.cgi?id=188350
1817
1818         Reviewed by Simon Fraser.
1819
1820         * WebCoreSupport/PopupMenuMac.mm:
1821         (PopupMenuMac::populate):
1822         (PopupMenuMac::show):
1823         * WebCoreSupport/WebFrameLoaderClient.mm:
1824         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1825         * WebView/WebFrame.mm:
1826         (-[WebFrame _dispatchDidReceiveTitle:]):
1827
1828 2018-08-09  Ali Juma  <ajuma@chromium.org>
1829
1830         Import WPTs for IntersectionObserver
1831         https://bugs.webkit.org/show_bug.cgi?id=188416
1832
1833         Reviewed by Simon Fraser.
1834
1835         * WebView/WebPreferencesPrivate.h:
1836
1837 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
1838
1839         Follow-up build fix for r234685
1840         https://bugs.webkit.org/show_bug.cgi?id=188245
1841
1842         Unreviewed build fix.
1843
1844         * WebCoreSupport/WebSecurityOriginPrivate.h:
1845
1846 2018-08-05  Darin Adler  <darin@apple.com>
1847
1848         [Cocoa] More tweaks and refactoring to prepare for ARC
1849         https://bugs.webkit.org/show_bug.cgi?id=188245
1850
1851         Reviewed by Dan Bernstein.
1852
1853         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
1854
1855         * Carbon/CarbonWindowFrame.m:
1856         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
1857
1858         * DOM/DOM.mm:
1859         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
1860         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
1861         garbage collection so this method isn't useful.
1862
1863         * DOM/DOMXPath.mm:
1864         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
1865         Objective-C garbage collection so this method isn't useful.
1866
1867         * History/WebHistory.mm:
1868         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
1869
1870         * Misc/WebElementDictionary.mm:
1871         (addLookupKey): Use a bridging cast.
1872         (cacheValueForKey): Ditto.
1873         (-[WebElementDictionary _fillCache]): Ditto.
1874         (-[WebElementDictionary objectForKey:]): Ditto.
1875
1876         * Misc/WebKitNSStringExtras.mm:
1877         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
1878         (-[NSString _web_widthWithFont:]): Ditto.
1879         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
1880
1881         * Misc/WebLocalizableStrings.mm:
1882         (WebLocalizedString): Use a bridging cast.
1883
1884         * Misc/WebNSDataExtras.mm:
1885         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
1886         and use CFBridgingRelease instead of calling autorelease directly.
1887         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
1888         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
1889         on the amount of explicit release and autorelease.
1890
1891         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
1892         * Misc/WebNSDictionaryExtras.m:
1893         (-[NSDictionary _webkit_intForKey:]): Deleted.
1894         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
1895         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
1896         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
1897         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
1898         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
1899         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
1900
1901         * Misc/WebStringTruncator.mm:
1902         (fontFromNSFont): Use a bridging cast.
1903
1904         * Plugins/Hosted/NetscapePluginHostManager.mm:
1905         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
1906
1907         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1908         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
1909         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
1910         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
1911         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
1912         * Plugins/Hosted/ProxyInstance.mm:
1913         (WebKit::ProxyInstance::getPropertyNames): Ditto.
1914         * Plugins/WebBasePluginPackage.mm:
1915         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
1916         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1917         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
1918         * Plugins/WebNetscapePluginPackage.mm:
1919         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
1920
1921         * Plugins/WebNetscapePluginView.mm:
1922         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
1923         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
1924         (-[WebNetscapePluginView status:]): Use a bridging cast.
1925         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
1926
1927         * Plugins/WebPluginController.mm:
1928         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
1929
1930         * Plugins/WebPluginDatabase.mm:
1931         (checkCandidate): Use explicit __strong for out argument types.
1932
1933         * Plugins/npapi.mm:
1934         (pluginViewForInstance): Use a bridging cast.
1935
1936         * Storage/WebDatabaseManager.mm:
1937         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
1938         explicit NSNumber and NSDictionary calls.
1939
1940         * WebCoreSupport/WebContextMenuClient.mm:
1941         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
1942
1943         * WebCoreSupport/WebEditorClient.mm:
1944         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
1945         (WebEditorClient::handleInputMethodKeydown): Ditto.
1946
1947         * WebCoreSupport/WebFrameNetworkingContext.mm:
1948         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
1949
1950         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
1951         as a struct rather than an Objective-C class, since that's how it's defined.
1952
1953         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
1954
1955         * WebView/WebFullScreenController.mm:
1956         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
1957         * WebView/WebHTMLView.mm:
1958         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1959         Ditto.
1960         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1961
1962         * WebView/WebImmediateActionController.mm:
1963         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
1964         go down to the document and then back to the frame.
1965         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
1966         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
1967         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
1968
1969         * WebView/WebJSPDFDoc.mm:
1970         (jsPDFDocInitialize): Removed some unneeded type casting.
1971         (jsPDFDocFinalize): Ditto.
1972         (jsPDFDocPrint): Use a bridging cast.
1973
1974         * WebView/WebPDFView.mm:
1975         (_applicationInfoForMIMEType): Use bridging casts.
1976
1977         * WebView/WebPreferences.mm:
1978         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
1979         instead of methods from WebNSDictionaryExtras.
1980         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
1981         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
1982         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
1983         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
1984         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
1985
1986         * WebView/WebView.mm:
1987         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
1988         (-[WebView _addToAllWebViewsSet]): Ditto.
1989         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
1990         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
1991         so it can be called from WebViewData methods.
1992
1993         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
1994         method, _windowVisibilityChanged:.
1995
1996         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
1997         called from WebViewData methods.
1998
1999 2018-08-06  Alex Christensen  <achristensen@webkit.org>
2000
2001         Use enum classes and OptionSets for PaintPhase and PaintBehavior
2002         https://bugs.webkit.org/show_bug.cgi?id=188323
2003
2004         Reviewed by Simon Fraser.
2005
2006         * WebCoreSupport/WebContextMenuClient.mm:
2007         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2008         * WebView/WebFrame.mm:
2009         (-[WebFrame _paintBehaviorForDestinationContext:]):
2010         (-[WebFrame _drawRect:contentsOnly:]):
2011         * WebView/WebHTMLView.mm:
2012         (imageFromRect):
2013         (selectionImage):
2014
2015 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2016
2017         Add support for microtasks in workers
2018         https://bugs.webkit.org/show_bug.cgi?id=188246
2019
2020         Reviewed by Darin Adler.
2021
2022         Rename JSMainThreadExecState.h to JSExecState.h.
2023
2024         * DOM/DOMAttr.mm:
2025         * DOM/DOMBlob.mm:
2026         * DOM/DOMCDATASection.mm:
2027         * DOM/DOMCSSCharsetRule.mm:
2028         * DOM/DOMCSSFontFaceRule.mm:
2029         * DOM/DOMCSSImportRule.mm:
2030         * DOM/DOMCSSMediaRule.mm:
2031         * DOM/DOMCSSPageRule.mm:
2032         * DOM/DOMCSSPrimitiveValue.mm:
2033         * DOM/DOMCSSRule.mm:
2034         * DOM/DOMCSSRuleList.mm:
2035         * DOM/DOMCSSStyleDeclaration.mm:
2036         * DOM/DOMCSSStyleRule.mm:
2037         * DOM/DOMCSSStyleSheet.mm:
2038         * DOM/DOMCSSUnknownRule.mm:
2039         * DOM/DOMCSSValue.mm:
2040         * DOM/DOMCSSValueList.mm:
2041         * DOM/DOMCharacterData.mm:
2042         * DOM/DOMComment.mm:
2043         * DOM/DOMCounter.mm:
2044         * DOM/DOMDocument.mm:
2045         * DOM/DOMDocumentFragment.mm:
2046         * DOM/DOMDocumentType.mm:
2047         * DOM/DOMElement.mm:
2048         * DOM/DOMEvent.mm:
2049         * DOM/DOMFile.mm:
2050         * DOM/DOMFileList.mm:
2051         * DOM/DOMHTML.mm:
2052         * DOM/DOMHTMLAnchorElement.mm:
2053         * DOM/DOMHTMLAppletElement.mm:
2054         * DOM/DOMHTMLAreaElement.mm:
2055         * DOM/DOMHTMLBRElement.mm:
2056         * DOM/DOMHTMLBaseElement.mm:
2057         * DOM/DOMHTMLBaseFontElement.mm:
2058         * DOM/DOMHTMLBodyElement.mm:
2059         * DOM/DOMHTMLButtonElement.mm:
2060         * DOM/DOMHTMLCanvasElement.mm:
2061         * DOM/DOMHTMLCollection.mm:
2062         * DOM/DOMHTMLDListElement.mm:
2063         * DOM/DOMHTMLDirectoryElement.mm:
2064         * DOM/DOMHTMLDivElement.mm:
2065         * DOM/DOMHTMLDocument.mm:
2066         * DOM/DOMHTMLElement.mm:
2067         * DOM/DOMHTMLEmbedElement.mm:
2068         * DOM/DOMHTMLFieldSetElement.mm:
2069         * DOM/DOMHTMLFontElement.mm:
2070         * DOM/DOMHTMLFormElement.mm:
2071         * DOM/DOMHTMLFrameElement.mm:
2072         * DOM/DOMHTMLFrameSetElement.mm:
2073         * DOM/DOMHTMLHRElement.mm:
2074         * DOM/DOMHTMLHeadElement.mm:
2075         * DOM/DOMHTMLHeadingElement.mm:
2076         * DOM/DOMHTMLHtmlElement.mm:
2077         * DOM/DOMHTMLIFrameElement.mm:
2078         * DOM/DOMHTMLImageElement.mm:
2079         * DOM/DOMHTMLInputElement.mm:
2080         * DOM/DOMHTMLLIElement.mm:
2081         * DOM/DOMHTMLLabelElement.mm:
2082         * DOM/DOMHTMLLegendElement.mm:
2083         * DOM/DOMHTMLLinkElement.mm:
2084         * DOM/DOMHTMLMapElement.mm:
2085         * DOM/DOMHTMLMarqueeElement.mm:
2086         * DOM/DOMHTMLMediaElement.mm:
2087         * DOM/DOMHTMLMenuElement.mm:
2088         * DOM/DOMHTMLMetaElement.mm:
2089         * DOM/DOMHTMLModElement.mm:
2090         * DOM/DOMHTMLOListElement.mm:
2091         * DOM/DOMHTMLObjectElement.mm:
2092         * DOM/DOMHTMLOptGroupElement.mm:
2093         * DOM/DOMHTMLOptionElement.mm:
2094         * DOM/DOMHTMLOptionsCollection.mm:
2095         * DOM/DOMHTMLParagraphElement.mm:
2096         * DOM/DOMHTMLParamElement.mm:
2097         * DOM/DOMHTMLPreElement.mm:
2098         * DOM/DOMHTMLQuoteElement.mm:
2099         * DOM/DOMHTMLScriptElement.mm:
2100         * DOM/DOMHTMLSelectElement.mm:
2101         * DOM/DOMHTMLStyleElement.mm:
2102         * DOM/DOMHTMLTableCaptionElement.mm:
2103         * DOM/DOMHTMLTableCellElement.mm:
2104         * DOM/DOMHTMLTableColElement.mm:
2105         * DOM/DOMHTMLTableElement.mm:
2106         * DOM/DOMHTMLTableRowElement.mm:
2107         * DOM/DOMHTMLTableSectionElement.mm:
2108         * DOM/DOMHTMLTextAreaElement.mm:
2109         * DOM/DOMHTMLTitleElement.mm:
2110         * DOM/DOMHTMLUListElement.mm:
2111         * DOM/DOMHTMLVideoElement.mm:
2112         * DOM/DOMImplementation.mm:
2113         * DOM/DOMKeyboardEvent.mm:
2114         * DOM/DOMMediaError.mm:
2115         * DOM/DOMMediaList.mm:
2116         * DOM/DOMMouseEvent.mm:
2117         * DOM/DOMMutationEvent.mm:
2118         * DOM/DOMNamedNodeMap.mm:
2119         * DOM/DOMNode.mm:
2120         * DOM/DOMNodeIterator.mm:
2121         * DOM/DOMNodeList.mm:
2122         * DOM/DOMOverflowEvent.mm:
2123         * DOM/DOMProcessingInstruction.mm:
2124         * DOM/DOMProgressEvent.mm:
2125         * DOM/DOMRGBColor.mm:
2126         * DOM/DOMRange.mm:
2127         * DOM/DOMRect.mm:
2128         * DOM/DOMStyleSheet.mm:
2129         * DOM/DOMStyleSheetList.mm:
2130         * DOM/DOMText.mm:
2131         * DOM/DOMTextEvent.mm:
2132         * DOM/DOMTimeRanges.mm:
2133         * DOM/DOMTokenList.mm:
2134         * DOM/DOMTreeWalker.mm:
2135         * DOM/DOMUIEvent.mm:
2136         * DOM/DOMWheelEvent.mm:
2137         * DOM/DOMXPathExpression.mm:
2138         * DOM/DOMXPathResult.mm:
2139         * DOM/ObjCEventListener.mm:
2140
2141 2018-08-03  Alex Christensen  <achristensen@webkit.org>
2142
2143         Fix spelling of "overridden"
2144         https://bugs.webkit.org/show_bug.cgi?id=188315
2145
2146         Reviewed by Darin Adler.
2147
2148         * Misc/WebKitVersionChecks.mm:
2149         (setWebKitLinkTimeVersion):
2150         (WebKitLinkTimeVersion):
2151         * Plugins/WebBaseNetscapePluginView.mm:
2152         (-[WebBaseNetscapePluginView handleMouseMoved:]):
2153         * WebCoreSupport/PopupMenuMac.mm:
2154         (PopupMenuMac::populate):
2155
2156 2018-08-01  Nan Wang  <n_wang@apple.com>
2157
2158         AX: AOM: Add ARIA IDL Attribute Reflection
2159         https://bugs.webkit.org/show_bug.cgi?id=184676
2160         <rdar://problem/39476882>
2161
2162         Reviewed by Chris Fleizach.
2163
2164         * WebView/WebPreferenceKeysPrivate.h:
2165         * WebView/WebPreferences.mm:
2166         (+[WebPreferences initialize]):
2167         (-[WebPreferences ariaReflectionEnabled]):
2168         (-[WebPreferences setAriaReflectionEnabled:]):
2169         * WebView/WebPreferencesPrivate.h:
2170         * WebView/WebView.mm:
2171         (-[WebView _preferencesChanged:]):
2172
2173 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
2174
2175         Shrink GraphicsLayerCA
2176         https://bugs.webkit.org/show_bug.cgi?id=188141
2177
2178         Reviewed by Zalan Bujtas.
2179
2180         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
2181         * moving all the clone-related stuff into the lazily-allocated m_layerClones
2182         * moving all the animation-related stuff into the lazily-allocated m_animations
2183         * making enums be 8-bit
2184         * re-ordering data members
2185
2186         * WebView/WebView.mm:
2187         (-[WebView _setMediaLayer:forPluginView:]):
2188
2189 2018-07-30  Rob Buis  <rbuis@igalia.com>
2190
2191         Merge PlatformCookieJar functions into NetworkStorageSession
2192         https://bugs.webkit.org/show_bug.cgi?id=188137
2193
2194         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
2195
2196         Reviewed by Alex Christensen.
2197
2198         * WebCoreSupport/WebPlatformStrategies.mm:
2199         (WebPlatformStrategies::cookiesForDOM):
2200         (WebPlatformStrategies::setCookiesFromDOM):
2201         (WebPlatformStrategies::cookiesEnabled):
2202         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2203         (WebPlatformStrategies::getRawCookies):
2204         (WebPlatformStrategies::deleteCookie):
2205         * WebView/WebPreferences.mm:
2206         (+[WebPreferences _clearNetworkLoaderSession]):
2207
2208 2018-07-28  Darin Adler  <darin@apple.com>
2209
2210         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
2211         https://bugs.webkit.org/show_bug.cgi?id=188140
2212
2213         Reviewed by Sam Weinig.
2214
2215         * WebView/WebImmediateActionController.mm:
2216         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
2217         new DictionaryLookup function that returns a tuple instead of using an out argument.
2218
2219 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
2220
2221         [INTL] Remove INTL sub-feature compile flags
2222         https://bugs.webkit.org/show_bug.cgi?id=188081
2223
2224         Reviewed by Michael Catanzaro.
2225
2226         * Configurations/FeatureDefines.xcconfig:
2227
2228 2018-07-26  Commit Queue  <commit-queue@webkit.org>
2229
2230         Unreviewed, rolling out r234181 and r234189.
2231         https://bugs.webkit.org/show_bug.cgi?id=188075
2232
2233         These are not needed right now (Requested by thorton on
2234         #webkit).
2235
2236         Reverted changesets:
2237
2238         "Enable Web Content Filtering on watchOS"
2239         https://bugs.webkit.org/show_bug.cgi?id=187979
2240         https://trac.webkit.org/changeset/234181
2241
2242         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
2243         https://bugs.webkit.org/show_bug.cgi?id=187985
2244         https://trac.webkit.org/changeset/234189
2245
2246 2018-07-26  Timothy Hatcher  <timothy@apple.com>
2247
2248         Use the Page's appearance when converting pasteboard attributed strings.
2249         https://bugs.webkit.org/show_bug.cgi?id=188067
2250         rdar://problem/42632246
2251
2252         Reviewed by Wenson Hsieh.
2253
2254         * WebCoreSupport/WebEditorClient.mm:
2255         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
2256
2257 2018-07-25  Chris Dumez  <cdumez@apple.com>
2258
2259         navigator.userAgent may return outdated value after webView.customUserAgent is set
2260         https://bugs.webkit.org/show_bug.cgi?id=188009
2261         <rdar://problem/42566456>
2262
2263         Reviewed by Alex Christensen.
2264
2265         Let the page know when the user agent changes.
2266
2267         * WebView/WebView.mm:
2268         (-[WebView _preferencesChanged:]):
2269         (-[WebView setApplicationNameForUserAgent:]):
2270         (-[WebView _invalidateUserAgentCache]):
2271         (-[WebView setCustomUserAgent:]):
2272         * WebView/WebViewInternal.h:
2273
2274 2018-07-24  Tim Horton  <timothy_horton@apple.com>
2275
2276         Enable Web Content Filtering on watchOS
2277         https://bugs.webkit.org/show_bug.cgi?id=187979
2278         <rdar://problem/42559346>
2279
2280         Reviewed by Wenson Hsieh.
2281
2282         * Configurations/FeatureDefines.xcconfig:
2283
2284 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
2285
2286         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
2287         https://bugs.webkit.org/show_bug.cgi?id=187846
2288
2289         Reviewed by Simon Fraser.
2290
2291         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
2292
2293         * WebView/WebHTMLView.mm:
2294         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
2295         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
2296
2297 2018-07-11  Dean Jackson  <dino@apple.com>
2298
2299         Allow removal of white backgrounds
2300         https://bugs.webkit.org/show_bug.cgi?id=187574
2301         <rdar://problem/41146792>
2302
2303         Reviewed by Simon Fraser.
2304
2305         Add a new WebPreference for punching out white backgrounds.
2306
2307         * WebView/WebPreferenceKeysPrivate.h:
2308         * WebView/WebPreferences.mm:
2309         (+[WebPreferences initialize]):
2310         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
2311         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
2312         * WebView/WebPreferencesPrivate.h:
2313         * WebView/WebView.mm:
2314         (-[WebView _preferencesChanged:]):
2315
2316 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
2317
2318         Ensure WebKit stack is ad-hoc signed
2319         https://bugs.webkit.org/show_bug.cgi?id=187667
2320
2321         Reviewed by Alexey Proskuryakov.
2322
2323         * Configurations/Base.xcconfig:
2324
2325 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
2326
2327         REGRESSION (231276): Attempting to copy an image fails
2328         https://bugs.webkit.org/show_bug.cgi?id=187212
2329         <rdar://problem/41540074>
2330
2331         Reviewed by Ryosuke Niwa.
2332
2333         Renamed methods to make it clear that one URL and one title are being passed in.
2334
2335         * WebCoreSupport/WebPlatformStrategies.h:
2336         * WebCoreSupport/WebPlatformStrategies.mm:
2337         (WebPlatformStrategies::setURL):
2338
2339 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
2340
2341         Disable cross-origin-window-policy by default
2342         https://bugs.webkit.org/show_bug.cgi?id=187509
2343
2344         Reviewed by Chris Dumez.
2345
2346         * WebView/WebPreferences.mm:
2347         (+[WebPreferences initialize]):
2348
2349 2018-07-09  Timothy Hatcher  <timothy@apple.com>
2350
2351         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2352         https://bugs.webkit.org/show_bug.cgi?id=187425
2353         rdar://problem/39948240
2354
2355         Reviewed by Tim Horton.
2356
2357         * WebView/WebView.mm:
2358         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
2359         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
2360         a call in this method to setUseDarkAppearance.
2361         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
2362         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
2363         (-[WebView _updateDefaultAppearance]): Deleted.
2364         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
2365
2366 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
2367
2368         Shrink various loading-related enums to shrink CachedResource
2369         https://bugs.webkit.org/show_bug.cgi?id=187443
2370
2371         Reviewed by Chris Dumez.
2372
2373         * WebCoreSupport/WebFrameLoaderClient.mm:
2374         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2375         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2376         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2377         (WebFrameLoaderClient::dispatchWillSendRequest):
2378         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2379         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2380         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2381         (WebFrameLoaderClient::updateGlobalHistory):
2382         (WebFrameLoaderClient::canHandleRequest const):
2383         * WebView/WebDataSource.mm:
2384         (-[WebDataSource initialRequest]):
2385         (-[WebDataSource request]):
2386
2387 2018-07-09  Commit Queue  <commit-queue@webkit.org>
2388
2389         Unreviewed, rolling out r233612.
2390         https://bugs.webkit.org/show_bug.cgi?id=187475
2391
2392         Revision caused the api test LinkColorWithSystemAppearance to
2393         fail on all systems. (Requested by Truitt on #webkit).
2394
2395         Reverted changeset:
2396
2397         "Semantic colors don't update when accessibility Increase
2398         Contrast mode is enabled."
2399         https://bugs.webkit.org/show_bug.cgi?id=187425
2400         https://trac.webkit.org/changeset/233612
2401
2402 2018-07-06  Timothy Hatcher  <timothy@apple.com>
2403
2404         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2405         https://bugs.webkit.org/show_bug.cgi?id=187425
2406         rdar://problem/39948240
2407
2408         Reviewed by Tim Horton.
2409
2410         * WebView/WebView.mm:
2411         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
2412         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
2413         a call in this method to setUseDarkAppearance.
2414         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
2415         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
2416         (-[WebView _updateDefaultAppearance]): Deleted.
2417         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
2418
2419 2018-07-05  Timothy Hatcher  <timothy@apple.com>
2420
2421         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
2422         https://bugs.webkit.org/show_bug.cgi?id=187369
2423         rdar://problem/41870420
2424
2425         Reviewed by Tim Horton.
2426
2427         * WebView/WebMediaPlaybackTargetPicker.mm:
2428         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
2429         * WebView/WebView.mm:
2430         (-[WebView _commonInitializationWithFrameName:groupName:]):
2431         (-[WebView _effectiveAppearanceIsDark]):
2432         (-[WebView _updateDefaultAppearance]):
2433         (-[WebView _defaultAppearance]): Deleted.
2434
2435 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
2436
2437         Youtube video pages crash after a couple of minutes
2438         https://bugs.webkit.org/show_bug.cgi?id=187316
2439
2440         Reviewed by Antti Koivisto.
2441
2442         * WebView/WebView.mm:
2443         (-[WebView _preferencesChanged:]):
2444
2445 2018-07-04  Tim Horton  <timothy_horton@apple.com>
2446
2447         Introduce PLATFORM(IOSMAC)
2448         https://bugs.webkit.org/show_bug.cgi?id=187315
2449
2450         Reviewed by Dan Bernstein.
2451
2452         * Configurations/Base.xcconfig:
2453         * Configurations/FeatureDefines.xcconfig:
2454
2455 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2456
2457         [iOS] DataTransfer.getData always returns the empty string when dropping text
2458         https://bugs.webkit.org/show_bug.cgi?id=187130
2459         <rdar://problem/41014117>
2460
2461         Reviewed by Ryosuke Niwa.
2462
2463         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
2464
2465         * WebCoreSupport/WebPlatformStrategies.h:
2466         * WebCoreSupport/WebPlatformStrategies.mm:
2467         (WebPlatformStrategies::allPasteboardItemInfo):
2468
2469 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
2470
2471         [Mac] AirPlay picker uses incorrect theme in Dark mode
2472         https://bugs.webkit.org/show_bug.cgi?id=187054
2473         <rdar://problem/41291093>
2474
2475         Reviewed by Timothy Hatcher.
2476
2477         * WebView/WebMediaPlaybackTargetPicker.mm:
2478         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
2479
2480 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2481
2482         [WTF] Add user-defined literal for ASCIILiteral
2483         https://bugs.webkit.org/show_bug.cgi?id=186839
2484
2485         Reviewed by Darin Adler.
2486
2487         * DOM/ExceptionHandlers.mm:
2488         (raiseDOMErrorException):
2489         * Plugins/Hosted/ProxyInstance.mm:
2490         (WebKit::ProxyInstance::invokeMethod):
2491         * Storage/WebDatabaseProvider.mm:
2492         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
2493
2494 2018-06-22  Timothy Hatcher  <timothy@apple.com>
2495
2496         Recalc styles every time defaultAppearance changes.
2497         https://bugs.webkit.org/show_bug.cgi?id=186866
2498         rdar://problem/41309805
2499
2500         Reviewed by Tim Horton.
2501
2502         * WebView/WebView.mm:
2503         (-[WebView _updateDefaultAppearance]):
2504         (-[WebView _setUseSystemAppearance:]):
2505         (-[WebView _useSystemAppearance]):
2506
2507 2018-06-20  Darin Adler  <darin@apple.com>
2508
2509         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
2510         https://bugs.webkit.org/show_bug.cgi?id=186875
2511
2512         Reviewed by Anders Carlsson.
2513
2514         * WebView/WebHTMLView.mm:
2515         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
2516         to write te file to.
2517         * WebView/WebPreferences.mm:
2518         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
2519         * WebView/WebView.mm:
2520         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
2521
2522 2018-06-12  Darin Adler  <darin@apple.com>
2523
2524         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
2525         https://bugs.webkit.org/show_bug.cgi?id=186526
2526
2527         Reviewed by Anders Carlsson.
2528
2529         * Plugins/Hosted/NetscapePluginHostManager.mm:
2530         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
2531
2532         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2533         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
2534         assignment rather than adoptNS/leakRef.
2535         * Plugins/WebNetscapePluginView.mm:
2536         (-[WebNetscapePluginView createPlugin]): Ditto.
2537
2538         * WebCoreSupport/WebContextMenuClient.mm:
2539         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
2540         RetainPtr::autorelease; no need to autorelease just to pass something as a function
2541         argument, so use RetainPtr::get instead.
2542
2543         * WebView/WebHTMLView.mm:
2544         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
2545         No need to autorelease the result when the return type is RetainPtr.
2546
2547         * WebView/WebPDFRepresentation.mm:
2548         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
2549
2550 2018-06-13  Youenn Fablet  <youenn@apple.com>
2551
2552         Supported plugin check should be based on plugin identifier
2553         https://bugs.webkit.org/show_bug.cgi?id=186578
2554         <rdar://problem/40523828>
2555
2556         Reviewed by Darin Adler.
2557
2558         * WebCoreSupport/WebPluginInfoProvider.h:
2559         * WebCoreSupport/WebPluginInfoProvider.mm:
2560         (WebPluginInfoProvider::pluginInfo):
2561         (WebPluginInfoProvider::webVisiblePluginInfo):
2562
2563 2018-06-13  Chris Dumez  <cdumez@apple.com>
2564
2565         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
2566         https://bugs.webkit.org/show_bug.cgi?id=186545
2567
2568         Reviewed by Brady Eidson.
2569
2570         Update client delegate now that parameter type has changed.
2571
2572         * WebCoreSupport/WebFrameLoaderClient.h:
2573         * WebCoreSupport/WebFrameLoaderClient.mm:
2574         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2575
2576 2018-06-11  Tim Horton  <timothy_horton@apple.com>
2577
2578         Link drag image is inconsistently unreadable in dark mode
2579         https://bugs.webkit.org/show_bug.cgi?id=186472
2580
2581         Reviewed by Timothy Hatcher.
2582
2583         * WebView/WebView.mm:
2584         (-[WebView _defaultAppearance]):
2585         Make defaultAppearance accurate even if useSystemAppearance is false.
2586         Some parts of WebKit (like the link drag image, but also context menus)
2587         want to be able to follow the system appearance regardless of whether
2588         the view or content has opted in.
2589
2590 2018-06-11  Chris Dumez  <cdumez@apple.com>
2591
2592         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
2593         https://bugs.webkit.org/show_bug.cgi?id=186441
2594
2595         Reviewed by Brady Eidson.
2596
2597         Rename existing flag to something a bit more generic, now that it is used for
2598         more things than bypassing the navigation policy check.
2599
2600         * WebView/WebView.mm:
2601         (-[WebView _loadBackForwardListFromOtherView:]):
2602         (-[WebView goToBackForwardItem:]):
2603
2604 2018-06-09  Dan Bernstein  <mitz@apple.com>
2605
2606         [Xcode] Clean up and modernize some build setting definitions
2607         https://bugs.webkit.org/show_bug.cgi?id=186463
2608
2609         Reviewed by Sam Weinig.
2610
2611         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
2612         * Configurations/DebugRelease.xcconfig: Ditto.
2613         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
2614           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
2615         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
2616         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
2617           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
2618         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
2619
2620 2018-06-08  Darin Adler  <darin@apple.com>
2621
2622         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
2623         https://bugs.webkit.org/show_bug.cgi?id=186436
2624
2625         Reviewed by Anders Carlsson.
2626
2627         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
2628         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
2629         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
2630         (PoolCleaner): Ditto.
2631
2632         * History/WebHistory.mm:
2633         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2634         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
2635         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
2636         now hardly used if at all.
2637         * WebView/WebView.mm:
2638         (-[WebView rectsForTextMatches]): Ditto.
2639
2640 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2641
2642         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
2643         https://bugs.webkit.org/show_bug.cgi?id=186442
2644         <rdar://problem/40879364>
2645
2646         Reviewed by Tim Horton.
2647
2648         * Configurations/FeatureDefines.xcconfig:
2649
2650 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
2651
2652         [Datalist] Allow TextFieldInputType to show and hide suggestions
2653         https://bugs.webkit.org/show_bug.cgi?id=186151
2654
2655         Reviewed by Tim Horton.
2656
2657         * WebCoreSupport/WebChromeClient.h:
2658         * WebCoreSupport/WebChromeClient.mm:
2659         (WebChromeClient::createDataListSuggestionPicker):
2660
2661 2018-06-07  Chris Dumez  <cdumez@apple.com>
2662
2663         Add base class to get WeakPtrFactory member and avoid some boilerplate code
2664         https://bugs.webkit.org/show_bug.cgi?id=186407
2665
2666         Reviewed by Brent Fulgham.
2667
2668         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
2669         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
2670         This also gets rid of old-style createWeakPtr() methods in favor of the newer
2671         makeWeakPtr().
2672
2673         * WebCoreSupport/WebEditorClient.h:
2674         * WebCoreSupport/WebEditorClient.mm:
2675         (WebEditorClient::requestCandidatesForSelection):
2676
2677 2018-06-05  Chris Dumez  <cdumez@apple.com>
2678
2679         Regression(r232082): Websites get loaded inside of Messages App chat transcript
2680         https://bugs.webkit.org/show_bug.cgi?id=186331
2681         <rdar://problem/40735446>
2682
2683         Reviewed by Darin Adler.
2684
2685         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
2686         but does not call use / ignore on the listener, then we would do "use" by default.
2687         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
2688         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
2689         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
2690         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
2691         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
2692         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
2693         and Box.app is still working properly.
2694
2695         * WebCoreSupport/WebFrameLoaderClient.h:
2696         * WebCoreSupport/WebFrameLoaderClient.mm:
2697         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2698         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2699         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2700         (WebFrameLoaderClient::dispatchWillSubmitForm):
2701         (WebFrameLoaderClient::setUpPolicyListener):
2702         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
2703         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
2704         (-[WebFramePolicyListener dealloc]):
2705         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
2706         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
2707
2708 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2709
2710         Adjust compile and runtime flags to match shippable state of features
2711         https://bugs.webkit.org/show_bug.cgi?id=186319
2712         <rdar://problem/40352045>
2713
2714         Reviewed by Maciej Stachowiak, Jon Lee, and others.
2715
2716         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
2717         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
2718         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
2719         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
2720         Cocoa builds.
2721
2722 2018-06-05  Timothy Hatcher  <timothy@apple.com>
2723
2724         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
2725
2726         https://bugs.webkit.org/show_bug.cgi?id=186323
2727         rdar://problem/38382252
2728
2729         Reviewed by Tim Horton.
2730
2731         * WebView/WebView.mm:
2732         (-[WebView _defaultAppearance]):
2733
2734 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2735
2736         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
2737         https://bugs.webkit.org/show_bug.cgi?id=186286
2738         <rdar://problem/40782992>
2739
2740         Reviewed by Dan Bernstein.
2741
2742         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
2743         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
2744         change this flag when preparing for a production release.
2745
2746         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
2747         whether experimental features should be enabled, and use it to properly define the
2748         feature flag.
2749
2750 2018-06-03  Darin Adler  <darin@apple.com>
2751
2752         Simplify and remove some unused video element code (helpful for ARC-compatibility)
2753         https://bugs.webkit.org/show_bug.cgi?id=186258
2754
2755         Reviewed by Daniel Bates.
2756
2757         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
2758         forward declarations. Removed methods that don't need to be public.
2759
2760         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
2761         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
2762         unnamed category in here and also replaced the HUDWindowControllerDelegate
2763         with the unnamed category. Removed unused NSWindow category defining the
2764         isOnActiveSpace, which is not called anywhere in this file at this time.
2765         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
2766         into setVideoElement.
2767         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
2768         and removed unneeded typecast.
2769         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
2770         using statement at the top of the file.
2771         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
2772         the many side effects and special considerations that this method that sounds
2773         like a setter has. Updated code to use the new
2774         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
2775         HTMLVideoElement::platformMedia function. Also straightened out the logic a
2776         bit and added some FIXME comments about small problems noticed but not fixed.
2777         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
2778         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
2779         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
2780         typecast. Removed call to updatePowerAssertions method.
2781         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
2782         updatePowerAssertions method.
2783         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
2784         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
2785         else, so this was dead code that did nothing.
2786         (-[WebVideoFullscreenController rateChanged:]): Removed call to
2787         updatePowerAssertions method.
2788
2789 2018-06-04  Chris Dumez  <cdumez@apple.com>
2790
2791         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
2792         https://bugs.webkit.org/show_bug.cgi?id=186287
2793         <rdar://problem/40783352>
2794
2795         Reviewed by Youenn Fablet.
2796
2797         * WebView/WebPreferenceKeysPrivate.h:
2798         * WebView/WebPreferences.mm:
2799         (+[WebPreferences initialize]):
2800         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
2801         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
2802         * WebView/WebPreferencesPrivate.h:
2803         * WebView/WebView.mm:
2804         (-[WebView _preferencesChanged:]):
2805
2806 2018-06-02  Darin Adler  <darin@apple.com>
2807
2808         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
2809         https://bugs.webkit.org/show_bug.cgi?id=186227
2810
2811         Reviewed by Dan Bernstein.
2812
2813         * Misc/WebKitErrors.m:
2814         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
2815         * Plugins/WebPluginDatabase.mm:
2816         (-[WebPluginDatabase refresh]): Ditto.
2817         * WebCoreSupport/WebChromeClient.mm:
2818         (WebChromeClient::setStatusbarText): Ditto.
2819
2820 2018-06-01  Chris Dumez  <cdumez@apple.com>
2821
2822         REGRESSION (r231456): Colloquy is broken
2823         https://bugs.webkit.org/show_bug.cgi?id=186197
2824         <rdar://problem/40722960>
2825
2826         Reviewed by Timothy Hatcher.
2827
2828         Restore pre-r231456 behavior for Colloquy app so that it works again.
2829
2830         * WebView/WebView.mm:
2831         (-[WebView _needsFrameNameFallbackToIdQuirk]):
2832         (-[WebView _preferencesChanged:]):
2833
2834 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2835
2836         [JSC] Pass VM& parameter as much as possible
2837         https://bugs.webkit.org/show_bug.cgi?id=186085
2838
2839         Reviewed by Saam Barati.
2840
2841         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2842         (WebKit::NetscapePluginInstanceProxy::invoke):
2843
2844 2018-05-30  Daniel Bates  <dabates@apple.com>
2845
2846         NavigationAction does not need to hold initiating DOM Event
2847         https://bugs.webkit.org/show_bug.cgi?id=185958
2848         <rdar://problem/40531539>
2849
2850         Reviewed by Simon Fraser.
2851
2852         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
2853
2854         * WebCoreSupport/WebFrameLoaderClient.mm:
2855         (WebFrameLoaderClient::actionDictionary const):
2856         (findMouseEvent): Deleted.
2857
2858 2018-05-27  Dan Bernstein  <mitz@apple.com>
2859
2860         Reverted the changes made for https://webkit.org/b/186016
2861
2862         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
2863
2864
2865 2018-05-27  David Kilzer  <ddkilzer@apple.com>
2866
2867         [iOS] Fix warnings about leaks found by clang static analyzer
2868         <https://webkit.org/b/186009>
2869         <rdar://problem/40574267>
2870
2871         Reviewed by Daniel Bates.
2872
2873         * WebView/WebHTMLView.mm:
2874         (-[WebHTMLView doCommandBySelector:]): Fix use of an
2875         uninitialized boolean variable (`eventWasHandled`) that only
2876         happened on iOS.
2877
2878 2018-05-27  Dan Bernstein  <mitz@apple.com>
2879
2880         [Cocoa] Avoid importing directly from subumbrella frameworks
2881         https://bugs.webkit.org/show_bug.cgi?id=186016
2882
2883         Reviewed by Sam Weinig.
2884
2885         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
2886         * Carbon/CarbonWindowAdapter.mm: Ditto.
2887         * Carbon/CarbonWindowFrame.m: Ditto.
2888         * Carbon/HIViewAdapter.h: Ditto.
2889         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
2890           OTHER_CPLUSPLUSFLAGS.
2891         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
2892         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
2893         * WebView/WebPDFView.h: Ditto.
2894
2895 2018-05-27  Sam Weinig  <sam@webkit.org>
2896
2897         Modernize RenderStyleConstants.h - Part 3
2898         https://bugs.webkit.org/show_bug.cgi?id=186015
2899
2900         Reviewed by Yusuke Suzuki.
2901
2902         * WebView/WebView.mm:
2903         (-[WebView updateTextTouchBar]):
2904         Update for new enum name.
2905
2906 2018-05-25  Chris Dumez  <cdumez@apple.com>
2907
2908         Minor ApplicationCacheStorage clean up
2909         https://bugs.webkit.org/show_bug.cgi?id=185984
2910
2911         Reviewed by Youenn Fablet.
2912
2913         * WebCoreSupport/WebApplicationCache.mm:
2914         (+[WebApplicationCache originsWithCache]):
2915
2916 2018-05-25  David Kilzer  <ddkilzer@apple.com>
2917
2918         Fix issues with -dealloc methods found by clang static analyzer
2919         <https://webkit.org/b/185887>
2920
2921         Reviewed by Joseph Pecoraro.
2922
2923         * WebView/WebView.mm:
2924         (-[WebUITextIndicatorData dealloc]):
2925         - Move method implementation from (WebUITextIndicatorInternal)
2926           category to the main category since this is public API.  This
2927           fixes the false positive warning about a missing -dealloc
2928           method.
2929
2930 2018-05-24  Sam Weinig  <sam@webkit.org>
2931
2932         Modernize RenderStyleConstants.h - Part 2
2933         https://bugs.webkit.org/show_bug.cgi?id=185901
2934
2935         Reviewed by Simon Fraser.
2936
2937         * WebView/WebHTMLRepresentation.mm:
2938         (searchForLabelsBeforeElement):
2939         * WebView/WebView.mm:
2940         (nsTextAlignmentFromRenderStyle):
2941         Update for new enum names.
2942
2943 2018-05-22  Chris Dumez  <cdumez@apple.com>
2944
2945         Regression(AsyncPolicyDelegates): Box.app login Window is blank
2946         https://bugs.webkit.org/show_bug.cgi?id=185832
2947         <rdar://problem/40307871>
2948
2949         Reviewed by Geoffrey Garen.
2950
2951         We used to have a bug where where we would fail to wait for the policy decision for
2952         the navigation response from the client and the load would keep going, racing with
2953         the client's policy decision. If the client did not respond in time, the behavior
2954         would be the same as "Use" policy action.
2955
2956         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
2957         but the load happened to proceed anyway due to our bug. Now that we've fixed the
2958         WebKit bug, however, the load would hang because the completion handler for the
2959         decidePolicyForNavigationResponse would never get called.
2960
2961         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
2962         instead of retaining it. If the policy listener object gets destroyed because getting
2963         resolved, we now use "Use" policy action in its dealloc function to maintain previous
2964         behavior.
2965
2966         * WebCoreSupport/WebFrameLoaderClient.h:
2967         * WebCoreSupport/WebFrameLoaderClient.mm:
2968         (WebFrameLoaderClient::cancelPolicyCheck):
2969         (WebFrameLoaderClient::setUpPolicyListener):
2970         (-[WebFramePolicyListener dealloc]):
2971
2972 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
2973
2974         Unreviewed, rolling out r232052.
2975
2976         Breaks internal builds.
2977
2978         Reverted changeset:
2979
2980         "Use more C++17"
2981         https://bugs.webkit.org/show_bug.cgi?id=185176
2982         https://trac.webkit.org/changeset/232052
2983
2984 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2985
2986         Use more C++17
2987         https://bugs.webkit.org/show_bug.cgi?id=185176
2988
2989         Reviewed by JF Bastien.
2990
2991         * Configurations/Base.xcconfig:
2992         * Configurations/WebKitLegacy.xcconfig:
2993
2994 2018-05-21  Chris Nardi  <cnardi@chromium.org>
2995
2996         Remove dead exception in MediaList.appendMedium
2997         https://bugs.webkit.org/show_bug.cgi?id=185278
2998
2999         Reviewed by Chris Dumez.
3000
3001         Remove code pertaining to an exception being thrown by appendMedium().
3002
3003         * DOM/DOMMediaList.mm:
3004         (-[DOMMediaList appendMedium:]):
3005
3006 2018-05-21  Jer Noble  <jer.noble@apple.com>
3007
3008         Complete fix for enabling modern EME by default
3009         https://bugs.webkit.org/show_bug.cgi?id=185770
3010         <rdar://problem/40368220>
3011
3012         Reviewed by Eric Carlson.
3013
3014         * Configurations/FeatureDefines.xcconfig:
3015
3016 2018-05-21  Antti Koivisto  <antti@apple.com>
3017
3018         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
3019         https://bugs.webkit.org/show_bug.cgi?id=185815
3020         <rdar://problem/40310069>
3021
3022         Reviewed by Simon Fraser.
3023
3024         User stylesheet parsing may depend on the colorFilterEnabled preference.
3025
3026         * WebView/WebView.mm:
3027         (-[WebView _preferencesChanged:]):
3028
3029 2018-05-18  Commit Queue  <commit-queue@webkit.org>
3030
3031         Unreviewed, rolling out r231982.
3032         https://bugs.webkit.org/show_bug.cgi?id=185793
3033
3034         Caused layout test failures (Requested by realdawei on
3035         #webkit).
3036
3037         Reverted changeset:
3038
3039         "Complete fix for enabling modern EME by default"
3040         https://bugs.webkit.org/show_bug.cgi?id=185770
3041         https://trac.webkit.org/changeset/231982
3042
3043 2018-05-18  Jer Noble  <jer.noble@apple.com>
3044
3045         Complete fix for enabling modern EME by default
3046         https://bugs.webkit.org/show_bug.cgi?id=185770
3047         <rdar://problem/40368220>
3048
3049         Reviewed by Eric Carlson.
3050
3051         * Configurations/FeatureDefines.xcconfig:
3052
3053 2018-05-18  Chris Dumez  <cdumez@apple.com>
3054
3055         Avoid keeping the frame alive when ref'ing a WindowProxy
3056         https://bugs.webkit.org/show_bug.cgi?id=185737
3057         <rdar://problem/40004666>
3058
3059         Reviewed by Sam Weinig.
3060
3061         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3062         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3063
3064 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
3065
3066         Add support for Intl NumberFormat formatToParts
3067         https://bugs.webkit.org/show_bug.cgi?id=185375
3068
3069         Reviewed by Yusuke Suzuki.
3070
3071         Add flag for NumberFormat formatToParts.
3072
3073         * Configurations/FeatureDefines.xcconfig:
3074
3075 2018-05-16  Chris Nardi  <cnardi@chromium.org>
3076
3077         Fixup after r231849: Do not mark Mac API methods as deprecated
3078         https://bugs.webkit.org/show_bug.cgi?id=185684
3079
3080         Reviewed by Darin Adler.
3081
3082         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
3083         as the entire class is already marked as deprecated, so it is unnecessary.
3084
3085         * DOM/DOMDocument.h:
3086
3087 2018-05-16  Chris Nardi  <cnardi@chromium.org>
3088
3089         Remove Document#selectedStylesheetSet/preferredStylesheetSet
3090         https://bugs.webkit.org/show_bug.cgi?id=185381
3091
3092         Reviewed by Darin Adler.
3093
3094         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
3095         and make them do nothing.
3096
3097         * DOM/DOMDocument.h:
3098         * DOM/DOMDocument.mm:
3099         (-[DOMDocument preferredStylesheetSet]):
3100         (-[DOMDocument selectedStylesheetSet]):
3101         (-[DOMDocument setSelectedStylesheetSet:]):
3102
3103 2018-05-15  Antoine Quint  <graouts@apple.com>
3104
3105         [Web Animations] Expose Web Animations CSS integration as an experimental feature
3106         https://bugs.webkit.org/show_bug.cgi?id=185647
3107
3108         Reviewed by Dean Jackson.
3109
3110         Rename the Web Animations CSS integration flag.
3111
3112         * WebView/WebPreferenceKeysPrivate.h:
3113         * WebView/WebPreferences.mm:
3114         (+[WebPreferences initialize]):
3115         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
3116         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
3117         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
3118         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
3119         * WebView/WebPreferencesPrivate.h:
3120         * WebView/WebView.mm:
3121         (-[WebView _preferencesChanged:]):
3122
3123 2018-05-14  Daniel Bates  <dabates@apple.com>
3124
3125         Fix the Apple Internal build
3126
3127         See <rdar://problem/40237873> for more details.
3128
3129         * WebView/WebFullScreenController.mm:
3130         (-[WebFullScreenController enterFullScreen:]):
3131         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3132         (-[WebFullScreenController exitFullScreen]):
3133         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3134         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3135         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3136
3137 2018-05-11  Timothy Hatcher  <timothy@apple.com>
3138
3139         WebHTMLView is not setting aside subviews when drawing.
3140
3141         https://bugs.webkit.org/show_bug.cgi?id=185561
3142         rdar://problem/40172894
3143
3144         Reviewed by Simon Fraser.
3145
3146         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
3147
3148         * WebView/WebHTMLView.mm:
3149         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
3150
3151 2018-05-07  Daniel Bates  <dabates@apple.com>
3152
3153         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
3154         https://bugs.webkit.org/show_bug.cgi?id=185170
3155
3156         Reviewed by Per Arne Vollan.
3157
3158         * Misc/WebCache.mm:
3159         (+[WebCache empty]):
3160
3161 2018-05-04  Timothy Hatcher  <timothy@apple.com>
3162
3163         Deprecate legacy WebView and friends
3164         https://bugs.webkit.org/show_bug.cgi?id=185279
3165         rdar://problem/33268700
3166
3167         Reviewed by Tim Horton.
3168
3169         Added deprecation macros to all the classes, extern strings, and enums.
3170
3171         * Configurations/WebKitLegacy.xcconfig:
3172         Added BUILDING_WEBKIT define to disable the deprecation macros.
3173         * DOM/DOMAbstractView.h:
3174         * DOM/DOMAttr.h:
3175         * DOM/DOMBlob.h:
3176         * DOM/DOMCDATASection.h:
3177         * DOM/DOMCSSCharsetRule.h:
3178         * DOM/DOMCSSFontFaceRule.h:
3179         * DOM/DOMCSSImportRule.h:
3180         * DOM/DOMCSSMediaRule.h:
3181         * DOM/DOMCSSPageRule.h:
3182         * DOM/DOMCSSPrimitiveValue.h:
3183         * DOM/DOMCSSRule.h:
3184         * DOM/DOMCSSRuleList.h:
3185         * DOM/DOMCSSStyleDeclaration.h:
3186         * DOM/DOMCSSStyleRule.h:
3187         * DOM/DOMCSSStyleSheet.h:
3188         * DOM/DOMCSSUnknownRule.h:
3189         * DOM/DOMCSSValue.h:
3190         * DOM/DOMCSSValueList.h:
3191         * DOM/DOMCharacterData.h:
3192         * DOM/DOMComment.h:
3193         * DOM/DOMCounter.h:
3194         * DOM/DOMDocument.h:
3195         * DOM/DOMDocumentFragment.h:
3196         * DOM/DOMDocumentType.h:
3197         * DOM/DOMElement.h:
3198         * DOM/DOMEntity.h:
3199         * DOM/DOMEntityReference.h:
3200         * DOM/DOMEvent.h:
3201         * DOM/DOMEventException.h:
3202         * DOM/DOMEventListener.h:
3203         * DOM/DOMEventTarget.h:
3204         * DOM/DOMException.h:
3205         * DOM/DOMFile.h:
3206         * DOM/DOMFileList.h:
3207         * DOM/DOMHTMLAnchorElement.h:
3208         * DOM/DOMHTMLAppletElement.h:
3209         * DOM/DOMHTMLAreaElement.h:
3210         * DOM/DOMHTMLBRElement.h:
3211         * DOM/DOMHTMLBaseElement.h:
3212         * DOM/DOMHTMLBaseFontElement.h:
3213         * DOM/DOMHTMLBodyElement.h:
3214         * DOM/DOMHTMLButtonElement.h:
3215         * DOM/DOMHTMLCanvasElement.h:
3216         * DOM/DOMHTMLCollection.h:
3217         * DOM/DOMHTMLDListElement.h:
3218         * DOM/DOMHTMLDirectoryElement.h:
3219         * DOM/DOMHTMLDivElement.h:
3220         * DOM/DOMHTMLDocument.h:
3221         * DOM/DOMHTMLElement.h:
3222         * DOM/DOMHTMLEmbedElement.h:
3223         * DOM/DOMHTMLFieldSetElement.h:
3224         * DOM/DOMHTMLFontElement.h:
3225         * DOM/DOMHTMLFormElement.h:
3226         * DOM/DOMHTMLFrameElement.h:
3227         * DOM/DOMHTMLFrameSetElement.h:
3228         * DOM/DOMHTMLHRElement.h:
3229         * DOM/DOMHTMLHeadElement.h:
3230         * DOM/DOMHTMLHeadingElement.h:
3231         * DOM/DOMHTMLHtmlElement.h:
3232         * DOM/DOMHTMLIFrameElement.h:
3233         * DOM/DOMHTMLImageElement.h:
3234         * DOM/DOMHTMLInputElement.h:
3235         * DOM/DOMHTMLLIElement.h:
3236         * DOM/DOMHTMLLabelElement.h:
3237         * DOM/DOMHTMLLegendElement.h:
3238         * DOM/DOMHTMLLinkElement.h:
3239         * DOM/DOMHTMLMapElement.h:
3240         * DOM/DOMHTMLMarqueeElement.h:
3241         * DOM/DOMHTMLMediaElement.h:
3242         * DOM/DOMHTMLMenuElement.h:
3243         * DOM/DOMHTMLMetaElement.h:
3244         * DOM/DOMHTMLModElement.h:
3245         * DOM/DOMHTMLOListElement.h:
3246         * DOM/DOMHTMLObjectElement.h:
3247         * DOM/DOMHTMLOptGroupElement.h:
3248         * DOM/DOMHTMLOptionElement.h:
3249         * DOM/DOMHTMLOptionsCollection.h:
3250         * DOM/DOMHTMLParagraphElement.h:
3251         * DOM/DOMHTMLParamElement.h:
3252         * DOM/DOMHTMLPreElement.h:
3253         * DOM/DOMHTMLQuoteElement.h:
3254         * DOM/DOMHTMLScriptElement.h:
3255         * DOM/DOMHTMLSelectElement.h:
3256         * DOM/DOMHTMLStyleElement.h:
3257         * DOM/DOMHTMLTableCaptionElement.h:
3258         * DOM/DOMHTMLTableCellElement.h:
3259         * DOM/DOMHTMLTableColElement.h:
3260         * DOM/DOMHTMLTableElement.h:
3261         * DOM/DOMHTMLTableRowElement.h:
3262         * DOM/DOMHTMLTableSectionElement.h:
3263         * DOM/DOMHTMLTextAreaElement.h:
3264         * DOM/DOMHTMLTitleElement.h:
3265         * DOM/DOMHTMLUListElement.h:
3266         * DOM/DOMHTMLVideoElement.h:
3267         * DOM/DOMImplementation.h:
3268         * DOM/DOMKeyboardEvent.h:
3269         * DOM/DOMMediaError.h:
3270         * DOM/DOMMediaList.h:
3271         * DOM/DOMMouseEvent.h:
3272         * DOM/DOMMutationEvent.h:
3273         * DOM/DOMNamedNodeMap.h:
3274         * DOM/DOMNode.h:
3275         * DOM/DOMNodeFilter.h:
3276         * DOM/DOMNodeIterator.h:
3277         * DOM/DOMNodeList.h:
3278         * DOM/DOMObject.h:
3279         * DOM/DOMOverflowEvent.h:
3280         * DOM/DOMProcessingInstruction.h:
3281         * DOM/DOMProgressEvent.h:
3282         * DOM/DOMRGBColor.h:
3283         * DOM/DOMRange.h:
3284         * DOM/DOMRangeException.h:
3285         * DOM/DOMRect.h:
3286         * DOM/DOMStyleSheet.h:
3287         * DOM/DOMStyleSheetList.h:
3288         * DOM/DOMText.h:
3289         * DOM/DOMTextEvent.h:
3290         * DOM/DOMTimeRanges.h:
3291         * DOM/DOMTokenList.h:
3292         * DOM/DOMTreeWalker.h:
3293         * DOM/DOMUIEvent.h:
3294         * DOM/DOMWheelEvent.h:
3295         * DOM/DOMXPathException.h:
3296         * DOM/DOMXPathExpression.h:
3297         * DOM/DOMXPathNSResolver.h:
3298         * DOM/DOMXPathResult.h:
3299         * History/WebBackForwardList.h:
3300         * History/WebHistory.h:
3301         * History/WebHistoryItem.h:
3302         * Misc/WebDownload.h:
3303         * Misc/WebKitErrors.h:
3304         * Plugins/WebPluginViewFactory.h:
3305         * WebView/WebArchive.h:
3306         * WebView/WebDataSource.h:
3307         * WebView/WebDocument.h:
3308         * WebView/WebEditingDelegate.h:
3309         * WebView/WebFormDelegate.h:
3310         * WebView/WebFrame.h:
3311         * WebView/WebFrameLoadDelegate.h:
3312         * WebView/WebFrameView.h:
3313         * WebView/WebPolicyDelegate.h:
3314         * WebView/WebPreferences.h:
3315         * WebView/WebPreferencesPrivate.h:
3316         * WebView/WebResourceLoadDelegate.h:
3317         * WebView/WebUIDelegate.h:
3318         * WebView/WebUIDelegatePrivate.h:
3319         * WebView/WebView.h:
3320         * WebView/WebViewPrivate.h:
3321         * postprocess-headers.sh:
3322         Remove step that converts WEBKIT macros to NS macros.
3323         Change it to just remove the macros on iOS builds.
3324
3325 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
3326
3327         [MediaStream] remove WK1 support
3328         https://bugs.webkit.org/show_bug.cgi?id=185136
3329
3330         Reviewed by Youenn Fablet.
3331
3332         * WebCoreSupport/WebUserMediaClient.h: Removed.
3333         * WebCoreSupport/WebUserMediaClient.mm: Removed.
3334         * WebView/WebView.mm:
3335         (-[WebView _commonInitializationWithFrameName:groupName:]):
3336         (-[WebView _preferencesChanged:]):
3337         (-[WebView _setUserMediaClient:]): Deleted.
3338         (-[WebView _userMediaClient]): Deleted.
3339         * WebView/WebViewData.h:
3340         * WebView/WebViewPrivate.h:
3341
3342 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
3343
3344         WebAssembly: add support for stream APIs - JavaScript API
3345         https://bugs.webkit.org/show_bug.cgi?id=183442
3346
3347         Reviewed by Yusuke Suzuki and JF Bastien.
3348
3349         Add WEBASSEMBLY_STREAMINNG_API feature flag
3350
3351         * Configurations/FeatureDefines.xcconfig:
3352
3353 2018-04-30  JF Bastien  <jfbastien@apple.com>
3354
3355         Use some C++17 features
3356         https://bugs.webkit.org/show_bug.cgi?id=185135
3357
3358         Reviewed by Alex Christensen.
3359
3360         * Configurations/WebKitLegacy.xcconfig:
3361
3362 2018-04-27  Chris Dumez  <cdumez@apple.com>
3363
3364         Use WindowProxy instead of DOMWindow in our IDL
3365         https://bugs.webkit.org/show_bug.cgi?id=185022
3366
3367         Reviewed by Sam Weinig.
3368
3369         * DOM/DOMAbstractView.mm:
3370         (kit):
3371         (toWindowProxy):
3372         * DOM/DOMAbstractViewInternal.h:
3373         * DOM/DOMDocument.mm:
3374         (-[DOMDocument defaultView]):
3375         (-[DOMDocument getComputedStyle:pseudoElement:]):
3376         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
3377         * DOM/DOMHTMLFrameElement.mm:
3378         (-[DOMHTMLFrameElement contentWindow]):
3379         * DOM/DOMHTMLIFrameElement.mm:
3380         (-[DOMHTMLIFrameElement contentWindow]):
3381         * DOM/DOMKeyboardEvent.mm:
3382         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
3383         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
3384         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
3385         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
3386         * DOM/DOMMouseEvent.mm:
3387         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
3388         * DOM/DOMTextEvent.mm:
3389         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
3390         * DOM/DOMUIEvent.mm:
3391         (-[DOMUIEvent view]):
3392         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
3393         * DOM/DOMWheelEvent.mm:
3394         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
3395
3396 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
3397
3398         Implement rendering support for the color-filter CSS property
3399         https://bugs.webkit.org/show_bug.cgi?id=185047
3400         rdar://problem/39664967
3401
3402         Reviewed by Tim Horton.
3403         
3404         The body background should reflect the filtered color.
3405
3406         * WebView/WebFrame.mm:
3407         (-[WebFrame _bodyBackgroundColor]):
3408         * WebView/WebView.mm:
3409         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
3410
3411 2018-04-26  Jer Noble  <jer.noble@apple.com>
3412
3413         WK_COCOA_TOUCH all the things.
3414         https://bugs.webkit.org/show_bug.cgi?id=185006
3415
3416         Reviewed by Tim Horton.
3417
3418         * Configurations/WebKitLegacy.xcconfig:
3419
3420 2018-04-26  Daniel Bates  <dabates@apple.com>
3421
3422         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
3423         https://bugs.webkit.org/show_bug.cgi?id=184161
3424         <rdar://problem/39051645>
3425
3426         Reviewed by Dan Bernstein.
3427
3428         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
3429         dropping a PDF embedded using an HTML image element into the same web view.
3430
3431         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
3432         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
3433         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
3434         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
3435         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
3436         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
3437         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
3438         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
3439         image document when navigated to directly. Since we can support dragging PDF document images we need to
3440         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
3441         We need to do both such queries before falling back to using the main resource of the Web Archive as
3442         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
3443         not an image document.
3444
3445         * Misc/WebNSPasteboardExtras.mm:
3446         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
3447
3448 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
3449
3450         Disable content filtering in minimal simulator mode
3451         https://bugs.webkit.org/show_bug.cgi?id=185027
3452         <rdar://problem/39736091>
3453
3454         Reviewed by Jer Noble.
3455
3456         * Configurations/FeatureDefines.xcconfig:
3457
3458 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
3459
3460         [INTL] Implement Intl.PluralRules
3461         https://bugs.webkit.org/show_bug.cgi?id=184312
3462
3463         Reviewed by JF Bastien.
3464
3465         Added Intl.PluralRules feature flag.
3466
3467         * Configurations/FeatureDefines.xcconfig:
3468
3469 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
3470
3471         Remove access to keychain from the WebContent process
3472         https://bugs.webkit.org/show_bug.cgi?id=184428
3473         <rdar://problem/13150903>
3474
3475         Reviewed by Brent Fulgham.
3476
3477         This patch does the followings:
3478         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
3479         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
3480         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
3481
3482         * WebCoreSupport/WebChromeClient.h:
3483         * WebCoreSupport/WebChromeClient.mm:
3484         (WebChromeClient::signedPublicKeyAndChallengeString const):
3485         * WebView/WebUIDelegatePrivate.h:
3486
3487 2018-04-24  Jer Noble  <jer.noble@apple.com>
3488
3489         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
3490         https://bugs.webkit.org/show_bug.cgi?id=184786
3491
3492         Reviewed by Tim Horton.
3493
3494         * Configurations/WebKitLegacy.xcconfig:
3495         * MigrateHeaders.make:
3496
3497 2018-04-23  Daniel Bates  <dabates@apple.com>
3498
3499         Implement Same-Site cookies
3500         https://bugs.webkit.org/show_bug.cgi?id=159464
3501         <rdar://problem/27196358>
3502
3503         Reviewed by Brent Fulgham.
3504
3505         Pass the Same-Site info through the strategy.
3506
3507         * WebCoreSupport/WebPlatformStrategies.h:
3508         * WebCoreSupport/WebPlatformStrategies.mm:
3509         (WebPlatformStrategies::cookiesForDOM):
3510         (WebPlatformStrategies::setCookiesFromDOM):
3511         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3512         (WebPlatformStrategies::getRawCookies):
3513
3514 2018-04-23  Zalan Bujtas  <zalan@apple.com>
3515
3516         [LayoutFormattingContext] Initial commit.
3517         https://bugs.webkit.org/show_bug.cgi?id=184896
3518
3519         Reviewed by Antti Koivisto.
3520
3521         * Configurations/FeatureDefines.xcconfig:
3522
3523 2018-04-23  Daniel Bates  <dabates@apple.com>
3524
3525         Implement Same-Site cookies
3526         https://bugs.webkit.org/show_bug.cgi?id=159464
3527         <rdar://problem/27196358>
3528
3529         Reviewed by Brent Fulgham.
3530
3531         Pass the Same-Site info through the strategy.
3532
3533         * WebCoreSupport/WebPlatformStrategies.h:
3534         * WebCoreSupport/WebPlatformStrategies.mm:
3535         (WebPlatformStrategies::cookiesForDOM):
3536         (WebPlatformStrategies::setCookiesFromDOM):
3537         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3538         (WebPlatformStrategies::getRawCookies):
3539
3540 2018-04-20  Timothy Hatcher  <timothy@apple.com>
3541
3542         NULL dereference crash sometimes under [super initWithCoder:] in WebView
3543
3544         https://bugs.webkit.org/show_bug.cgi?id=184851
3545         rdar://problem/39611236
3546
3547         Reviewed by Tim Horton.
3548
3549         * WebView/WebView.mm:
3550         (-[WebView _commonInitializationWithFrameName:groupName:]):
3551         (-[WebView effectiveAppearanceDidChange]):
3552         Added a null check and call the code later in initialization.
3553
3554 2018-04-20  Tim Horton  <timothy_horton@apple.com>
3555
3556         Adjust geolocation feature flag
3557         https://bugs.webkit.org/show_bug.cgi?id=184856
3558
3559         Reviewed by Wenson Hsieh.
3560
3561         * Configurations/FeatureDefines.xcconfig:
3562
3563 2018-04-18  Jer Noble  <jer.noble@apple.com>
3564
3565         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
3566         https://bugs.webkit.org/show_bug.cgi?id=184762
3567
3568         Reviewed by Dan Bernstein.
3569
3570         * Configurations/WebKitLegacy.xcconfig:
3571
3572 2018-04-20  Youenn Fablet  <youenn@apple.com>
3573
3574         Make PluginData cache its web visible plugins
3575         https://bugs.webkit.org/show_bug.cgi?id=184421
3576
3577         Reviewed by Chris Dumez.
3578
3579         * WebCoreSupport/WebPluginInfoProvider.h:
3580         * WebCoreSupport/WebPluginInfoProvider.mm:
3581         (WebPluginInfoProvider::pluginInfo):
3582         (WebPluginInfoProvider::webVisiblePluginInfo):
3583
3584 2018-04-19  Chris Dumez  <cdumez@apple.com>
3585
3586         Rename JSDOMWindowProxy to JSWindowProxy
3587         https://bugs.webkit.org/show_bug.cgi?id=184797
3588
3589         Reviewed by Sam Weinig.
3590
3591         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
3592
3593         * DOM/DOMUtility.mm:
3594         (createDOMWrapper):
3595         * WebView/WebFrame.mm:
3596         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3597
3598 2018-04-19  David Kilzer  <ddkilzer@apple.com>
3599
3600         Enable Objective-C weak references
3601         <https://webkit.org/b/184789>
3602         <rdar://problem/39571716>
3603
3604         Reviewed by Dan Bernstein.
3605
3606         * Configurations/Base.xcconfig:
3607         (CLANG_ENABLE_OBJC_WEAK): Enable.
3608
3609 2018-04-18  Chris Dumez  <cdumez@apple.com>
3610
3611         Rename WindowProxyController to WindowProxy
3612         https://bugs.webkit.org/show_bug.cgi?id=184756
3613
3614         Reviewed by Sam Weinig.
3615
3616         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
3617         needed use WindowProxyController type, which was a bit confusing.
3618
3619         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3620         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3621         * WebView/WebFrame.mm:
3622         (-[WebFrame _attachScriptDebugger]):
3623
3624 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
3625
3626         Unreviewed rollout of r230632. Regression in memory usage.
3627
3628         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
3629
3630         * WebView/WebPreferences.mm:
3631         (+[WebPreferences initialize]):
3632
3633 2018-04-17  Chris Dumez  <cdumez@apple.com>
3634
3635         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
3636         https://bugs.webkit.org/show_bug.cgi?id=184678
3637         <rdar://problem/39422122>
3638
3639         Reviewed by Alex Christensen.
3640
3641         Add new parameter to dispatchDecidePolicyForNavigationAction.
3642
3643         * WebCoreSupport/WebFrameLoaderClient.h:
3644         * WebCoreSupport/WebFrameLoaderClient.mm:
3645         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3646
3647 2018-04-13  Chris Dumez  <cdumez@apple.com>
3648
3649         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
3650         https://bugs.webkit.org/show_bug.cgi?id=184591
3651
3652         Reviewed by Sam Weinig.
3653
3654         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
3655         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
3656         This is work towards fixing Bug 184515.
3657
3658         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3659         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3660         * WebView/WebFrame.mm:
3661         (-[WebFrame _attachScriptDebugger]):
3662
3663 2018-04-12  Antoine Quint  <graouts@apple.com>
3664
3665         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
3666         https://bugs.webkit.org/show_bug.cgi?id=184569
3667         <rdar://problem/38671301>
3668
3669         Reviewed by Jon Lee.
3670
3671         * WebView/WebPreferences.mm:
3672
3673 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3674
3675         [WTF] Remove StaticLock
3676         https://bugs.webkit.org/show_bug.cgi?id=184332
3677
3678         Reviewed by Mark Lam.
3679
3680         * DOM/DOMInternal.mm:
3681         (getDOMWrapper):
3682         (addDOMWrapper):
3683         (removeDOMWrapper):
3684
3685 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
3686
3687         Failures from mach port reference handling should be fatal
3688         https://bugs.webkit.org/show_bug.cgi?id=184202
3689         <rdar://problem/37771114>
3690
3691         Reviewed by Anders Carlsson.
3692
3693         * Plugins/Hosted/NetscapePluginHostManager.mm:
3694         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
3695
3696 2018-04-03  Andy Estes  <aestes@apple.com>
3697
3698         [Mac] Prioritize file promises over filenames during drag and drop
3699         https://bugs.webkit.org/show_bug.cgi?id=184237
3700         <rdar://problem/38278076>
3701
3702         Reviewed by Wenson Hsieh.
3703
3704         * WebView/WebView.mm:
3705         (-[WebView performDragOperation:]):
3706
3707 2018-04-03  Chris Dumez  <cdumez@apple.com>
3708
3709         Drop MainFrame class
3710         https://bugs.webkit.org/show_bug.cgi?id=184191
3711
3712         Reviewed by Darin Adler.
3713
3714         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
3715         relationship between the Page and the MainFrame.
3716
3717         This is ground work for introducing LocalFrame / RemoteFrame concepts.
3718
3719         * WebCoreSupport/WebDragClient.mm:
3720         * WebCoreSupport/WebFrameLoaderClient.mm:
3721         * WebCoreSupport/WebInspectorClient.mm:
3722         * WebCoreSupport/WebPlatformStrategies.mm:
3723         * WebCoreSupport/WebPluginInfoProvider.mm:
3724         * WebView/WebFrame.mm:
3725         * WebView/WebFrameView.mm:
3726         * WebView/WebHTMLView.mm:
3727         * WebView/WebView.mm:
3728
3729 2018-04-02  Jer Noble  <jer.noble@apple.com>
3730
3731         Enable Legacy EME for all WebKit & WebKitLegacy clients
3732         https://bugs.webkit.org/show_bug.cgi?id=184018
3733         <rdar://problem/34887387>
3734
3735         Reviewed by Eric Carlson.
3736
3737         * WebView/WebPreferences.mm:
3738         (+[WebPreferences initialize]):
3739
3740 2018-03-29  JF Bastien  <jfbastien@apple.com>
3741
3742         Use Forward.h instead of forward-declaring WTF::String
3743         https://bugs.webkit.org/show_bug.cgi?id=184172
3744         <rdar://problem/39026146>
3745
3746         Reviewed by Yusuke Suzuki.
3747
3748         As part of #184164 I'm changing WTF::String, and the forward
3749         declarations are just wrong because I'm making it templated. We
3750         should use Forward.h anyways, so do that instead.
3751
3752         * WebView/WebScriptDebugger.h:
3753
3754 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
3755
3756         Protect against invalid mach ports returned by mach_port_request_notification
3757         https://bugs.webkit.org/show_bug.cgi?id=184106
3758         <rdar://problem/37865316>
3759
3760         Reviewed by Chris Dumez.
3761
3762         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3763         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
3764         and clean up if it experienced an error.
3765         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
3766
3767 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
3768
3769         Avoid uninitialized mach ports
3770         https://bugs.webkit.org/show_bug.cgi?id=184090
3771         <rdar://problem/37261129>
3772
3773         Reviewed by Chris Dumez.
3774
3775         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
3776         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
3777         there is a potential for us to try to use invalid ports.
3778
3779         We should always check return values, and ensure that the mach port variables we seek to initialize are
3780         kept in a valid state.
3781
3782         Reviewed by Chris Dumez.
3783
3784         * Plugins/Hosted/NetscapePluginHostManager.h:
3785         * Plugins/Hosted/NetscapePluginHostManager.mm:
3786         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
3787         port is passed to an API function.
3788         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
3789         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
3790         * Plugins/Hosted/NetscapePluginHostProxy.h:
3791         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3792         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
3793         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
3794         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
3795         (WKPCStatusText): Ditto.
3796         (WKPCLoadURL): Ditto.
3797         (WKPCCancelLoadURL): Ditto.
3798         (WKPCInvalidateRect): Ditto.
3799         (WKPCGetScriptableNPObjectReply): Ditto.
3800         (WKPCBooleanReply): Ditto.
3801         (WKPCBooleanAndDataReply): Ditto.
3802         (WKPCInstantiatePluginReply): Ditto.
3803         (WKPCGetWindowNPObject): Ditto.
3804         (WKPCGetPluginElementNPObject): Ditto.
3805         (WKPCForgetBrowserObject): Ditto.
3806         (WKPCEvaluate): Ditto.
3807         (WKPCGetStringIdentifier): Ditto.
3808         (WKPCGetIntIdentifier): Ditto.
3809         (WKPCInvoke): Ditto.
3810         (WKPCInvokeDefault): Ditto.
3811         (WKPCConstruct): Ditto.
3812         (WKPCGetProperty): Ditto.
3813         (WKPCSetProperty): Ditto.
3814         (WKPCRemoveProperty): Ditto.
3815         (WKPCHasProperty): Ditto.
3816         (WKPCHasMethod): Ditto.
3817         (WKPCIdentifierInfo): Ditto.
3818         (WKPCEnumerate): Ditto.
3819         (WKPCSetMenuBarVisible): Ditto.
3820         (WKPCSetFullscreenWindowIsShowing): Ditto.
3821         (WKPCSetModal): Ditto.
3822         (WKPCGetCookies): Ditto.
3823         (WKPCGetProxy): Ditto.
3824         (WKPCSetCookies): Ditto.
3825         (WKPCGetAuthenticationInfo): Ditto.
3826         (WKPCConvertPoint): Ditto.
3827         (WKPCLayerHostingModeChanged): Ditto.
3828         (WKPCSetException): Ditto.
3829
3830 2018-03-26  Tim Horton  <timothy_horton@apple.com>
3831
3832         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
3833         https://bugs.webkit.org/show_bug.cgi?id=184030
3834         <rdar://problem/38895281>
3835
3836         Reviewed by Dan Bernstein.
3837
3838         * Configurations/Base.xcconfig:
3839
3840 2018-03-26  Chris Dumez  <cdumez@apple.com>
3841
3842         Use SecurityOriginData more consistently in Service Worker code
3843         https://bugs.webkit.org/show_bug.cgi?id=183969
3844
3845         Reviewed by Darin Adler.
3846
3847         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3848
3849         * Storage/WebDatabaseManager.mm:
3850         (-[WebDatabaseManager databasesWithOrigin:]):
3851         (-[WebDatabaseManager deleteOrigin:]):
3852         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3853         * Storage/WebDatabaseQuotaManager.mm:
3854         (-[WebDatabaseQuotaManager usage]):
3855         (-[WebDatabaseQuotaManager quota]):
3856         (-[WebDatabaseQuotaManager setQuota:]):
3857         * Storage/WebStorageManager.mm:
3858         (-[WebStorageManager deleteOrigin:]):
3859         * WebCoreSupport/WebSecurityOrigin.mm:
3860         (-[WebSecurityOrigin databaseIdentifier]):
3861         (-[WebSecurityOrigin usage]):
3862         (-[WebSecurityOrigin quota]):
3863         (-[WebSecurityOrigin setQuota:]):
3864
3865 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
3866
3867         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
3868         https://bugs.webkit.org/show_bug.cgi?id=183911
3869         <rdar://problem/38762306>
3870
3871         Reviewed by Youenn Fablet.
3872
3873         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
3874
3875         * WebView/WebView.mm:
3876         (+[WebView initialize]):
3877
3878 2018-03-26  Alex Christensen  <achristensen@webkit.org>
3879
3880         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
3881         https://bugs.webkit.org/show_bug.cgi?id=183965
3882
3883         Reviewed by Chris Dumez.
3884
3885         * WebCoreSupport/WebFrameLoaderClient.h:
3886         * WebCoreSupport/WebFrameLoaderClient.mm:
3887         (WebFrameLoaderClient::willCacheResponse const):
3888
3889 2018-03-25  Commit Queue  <commit-queue@webkit.org>
3890
3891         Unreviewed, rolling out r229954.
3892         https://bugs.webkit.org/show_bug.cgi?id=184000
3893
3894         Caused many layout tests to crash on Apple High Sierra,
3895         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
3896         by dydz on #webkit).
3897
3898         Reverted changeset:
3899
3900         "Use SecurityOriginData more consistently in Service Worker
3901         code"
3902         https://bugs.webkit.org/show_bug.cgi?id=183969
3903         https://trac.webkit.org/changeset/229954
3904
3905 2018-03-24  Chris Dumez  <cdumez@apple.com>
3906
3907         Use SecurityOriginData more consistently in Service Worker code
3908         https://bugs.webkit.org/show_bug.cgi?id=183969
3909
3910         Reviewed by Darin Adler.
3911
3912         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3913
3914         * Storage/WebDatabaseManager.mm:
3915         (-[WebDatabaseManager databasesWithOrigin:]):
3916         (-[WebDatabaseManager deleteOrigin:]):
3917         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3918         * Storage/WebDatabaseQuotaManager.mm:
3919         (-[WebDatabaseQuotaManager usage]):
3920         (-[WebDatabaseQuotaManager quota]):
3921         (-[WebDatabaseQuotaManager setQuota:]):
3922         * Storage/WebStorageManager.mm:
3923         (-[WebStorageManager deleteOrigin:]):
3924         * WebCoreSupport/WebSecurityOrigin.mm:
3925         (-[WebSecurityOrigin databaseIdentifier]):
3926         (-[WebSecurityOrigin usage]):
3927         (-[WebSecurityOrigin quota]):
3928         (-[WebSecurityOrigin setQuota:]):
3929
3930 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
3931
3932         Fix the build
3933
3934         * WebView/WebView.mm:
3935
3936 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3937
3938         Fix the build with no pasteboard
3939         https://bugs.webkit.org/show_bug.cgi?id=183973
3940
3941         Reviewed by Dan Bernstein.
3942
3943         * Configurations/FeatureDefines.xcconfig:
3944         * WebView/WebView.mm:
3945         (-[WebView _requestStartDataInteraction:globalPosition:]):
3946         (-[WebView _getDataInteractionData]):
3947         (-[WebView _dataOperationTextIndicator]):
3948         (-[WebView _dragSourceAction]):
3949         (-[WebView _draggedLinkTitle]):
3950         (-[WebView _draggedLinkURL]):
3951         (-[WebView _draggedElementBounds]):
3952         (-[WebView _enteredDataInteraction:client:global:operation:]):
3953         (-[WebView _updatedDataInteraction:client:global:operation:]):
3954         (-[WebView _exitedDataInteraction:client:global:operation:]):
3955         (-[WebView _performDataInteraction:client:global:operation:]):
3956         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3957         (-[WebView _endedDataInteraction:global:]):
3958         (-[WebView _dataInteractionCaretRect]):
3959         * WebView/WebViewPrivate.h:
3960
3961 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3962
3963         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
3964         https://bugs.webkit.org/show_bug.cgi?id=183960
3965         <rdar://problem/38812356>
3966
3967         Reviewed by Dan Bernstein.
3968
3969         * Configurations/WebKitLegacy.xcconfig:
3970
3971 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3972
3973         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
3974         https://bugs.webkit.org/show_bug.cgi?id=183954
3975         <rdar://problem/38808858>
3976
3977         Reviewed by Dan Bernstein.
3978
3979         * WebView/WebPreferences.mm:
3980         (-[WebPreferences setAudioSessionCategoryOverride:]):
3981
3982 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3983
3984         Adopt WK_PLATFORM_NAME in WebKitLegacy
3985         https://bugs.webkit.org/show_bug.cgi?id=183948
3986         <rdar://problem/38803908>
3987
3988         Reviewed by Dan Bernstein.
3989
3990         * Configurations/WebKitLegacy.xcconfig:
3991         * MigrateHeaders.make:
3992         * postprocess-headers.sh:
3993
3994 2018-03-23  Brady Eidson  <beidson@apple.com>
3995
3996         Go to back/forward list items after a process-swapped navigation.
3997         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
3998
3999         Reviewed by Andy Estes.
4000
4001         * WebView/WebView.mm:
4002         (-[WebView _loadBackForwardListFromOtherView:]):
4003         (-[WebView goToBackForwardItem:]):
4004
4005 2018-03-22  Tim Horton  <timothy_horton@apple.com>
4006
4007         Improve readability of WebCore's OTHER_LDFLAGS
4008         https://bugs.webkit.org/show_bug.cgi?id=183909
4009         <rdar://problem/38760992>
4010
4011         Reviewed by Dan Bernstein.
4012
4013         * Configurations/Base.xcconfig:
4014         * Configurations/FeatureDefines.xcconfig:
4015
4016 2018-03-20  Tim Horton  <timothy_horton@apple.com>
4017
4018         Enable the minimal simulator feature flag when appropriate
4019         https://bugs.webkit.org/show_bug.cgi?id=183807
4020
4021         Reviewed by Dan Bernstein.
4022
4023         * Configurations/FeatureDefines.xcconfig:
4024
4025 2018-03-20  Tim Horton  <timothy_horton@apple.com>
4026
4027         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
4028         https://bugs.webkit.org/show_bug.cgi?id=183758
4029         <rdar://problem/38017644>
4030
4031         Reviewed by Dan Bernstein.
4032
4033         * Configurations/FeatureDefines.xcconfig:
4034
4035 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
4036
4037         Clear style colors when setting default appearance
4038         https://bugs.webkit.org/show_bug.cgi?id=183759
4039
4040         Reviewed by Tim Horton.
4041
4042         Colors are cached and need to be cleared and recalculated.