requestAnimationFrame should execute before the next frame
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2
3         requestAnimationFrame should execute before the next frame
4         https://bugs.webkit.org/show_bug.cgi?id=177484
5
6         Reviewed by Simon Fraser.
7
8         * WebView/WebView.mm:
9         (-[WebView _viewWillDrawInternal]):
10         Call Page::renderingUpdate() which implements  "Update the rendering"
11         step of the HTML Event Loop specification.
12
13 2019-03-07  Zalan Bujtas  <zalan@apple.com>
14
15         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
16         https://bugs.webkit.org/show_bug.cgi?id=195353
17         <rdar://problem/48626394>
18
19         Reviewed by Simon Fraser.
20
21         * WebView/WebPreferenceKeysPrivate.h:
22         * WebView/WebPreferences.mm:
23         (+[WebPreferences initialize]):
24         (-[WebPreferences contentChangeObserverEnabled]):
25         (-[WebPreferences setContentChangeObserverEnabled:]):
26         * WebView/WebPreferencesPrivate.h:
27         * WebView/WebView.mm:
28         (-[WebView _preferencesChanged:]):
29
30 2019-03-06  Sam Weinig  <sam@webkit.org>
31
32         WebKitLegacy does not need to generate an export file for i386 anymore
33         https://bugs.webkit.org/show_bug.cgi?id=195380
34
35         Reviewed by Dan Bernstein.
36
37         * Configurations/WebKitLegacy.xcconfig:
38         Simplify EXPORTED_SYMBOLS_FILE down to just a single path to a generated file.
39         It still needs to be generated, since we are concatenating the shared exports
40         file with a macOS or iOS specific one.
41
42         * WebKit.mac.exp:
43         Remove i386 specific symbols that we were previously stripping.
44
45 2019-03-06  Rob Buis  <rbuis@igalia.com>
46
47         Consider supporting the `referrerpolicy` attribute.
48         https://bugs.webkit.org/show_bug.cgi?id=179053
49
50         Reviewed by Darin Adler.
51
52         Add a runtime flag for referrerpolicy attribute.
53
54         * WebView/WebPreferenceKeysPrivate.h:
55         * WebView/WebPreferences.mm:
56         (+[WebPreferences initialize]):
57         (-[WebPreferences referrerPolicyAttributeEnabled]):
58         (-[WebPreferences setReferrerPolicyAttributeEnabled:]):
59         * WebView/WebPreferencesPrivate.h:
60         * WebView/WebView.mm:
61         (-[WebView _preferencesChanged:]):
62
63 2019-03-03  Tim Horton  <timothy_horton@apple.com>
64
65         Remove some more unused 32-bit code
66         https://bugs.webkit.org/show_bug.cgi?id=195255
67
68         Reviewed by Darin Adler.
69
70         * Plugins/WebNetscapePluginEventHandler.mm:
71         (WebNetscapePluginEventHandler::create):
72         * Plugins/WebNetscapePluginView.h:
73         * Plugins/WebNetscapePluginView.mm:
74         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
75         (-[WebNetscapePluginView restorePortState:]):
76         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
77         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
78         (-[WebNetscapePluginView updateAndSetWindow]):
79         (-[WebNetscapePluginView setWindowIfNecessary]):
80         (-[WebNetscapePluginView createPlugin]):
81         (-[WebNetscapePluginView fini]):
82         (-[WebNetscapePluginView drawRect:]):
83         (-[WebNetscapePluginView invalidateRegion:]):
84         (-[WebNetscapePluginView getVariable:value:]):
85         (-[WebNetscapePluginView setVariable:value:]):
86         (isDrawingModelQuickDraw): Deleted.
87         (-[WebNetscapePluginView fixWindowPort]): Deleted.
88         (getQDPixelFormatForBitmapContext): Deleted.
89         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
90         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
91         * WebView/WebDelegateImplementationCaching.mm:
92
93 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
94
95         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
96         https://bugs.webkit.org/show_bug.cgi?id=195053
97         <rdar://problem/48134710>
98
99         Reviewed by Ryosuke Niwa.
100
101         * WebCoreSupport/WebEditorClient.h:
102
103 2019-03-01  Tim Horton  <timothy_horton@apple.com>
104
105         Remove unused code in WebKitLegacy
106         https://bugs.webkit.org/show_bug.cgi?id=189614
107
108         Reviewed by Simon Fraser.
109
110         * Carbon/CarbonUtils.h: Removed.
111         * Carbon/CarbonUtils.m: Removed.
112         * Carbon/CarbonWindowAdapter.h: Removed.
113         * Carbon/CarbonWindowAdapter.mm: Removed.
114         * Carbon/CarbonWindowContentView.h: Removed.
115         * Carbon/CarbonWindowContentView.m: Removed.
116         * Carbon/CarbonWindowFrame.h: Removed.
117         * Carbon/CarbonWindowFrame.m: Removed.
118         * Carbon/HIViewAdapter.h: Removed.
119         * Carbon/HIViewAdapter.m: Removed.
120         * Carbon/HIWebView.h: Removed.
121         * Carbon/HIWebView.mm: Removed.
122         * Configurations/WebKitLegacy.xcconfig:
123         * WebKit.mac.exp:
124
125 2019-03-01  Justin Fan  <justin_fan@apple.com>
126
127         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
128         https://bugs.webkit.org/show_bug.cgi?id=195191
129
130         Rubber-stamped by Dean Jackson.
131
132         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
133
134         * Configurations/FeatureDefines.xcconfig:
135
136 2019-02-28  Antoine Quint  <graouts@apple.com>
137
138         Enable the Pointer Events runtime flag by default
139         https://bugs.webkit.org/show_bug.cgi?id=195156
140
141         Reviewed by Dean Jackson.
142
143         * WebView/WebPreferences.mm:
144         (+[WebPreferences initialize]):
145
146 2019-02-28  Justin Fan  <justin_fan@apple.com>
147
148         [Web GPU] Enable Web GPU only on 64-bit
149         https://bugs.webkit.org/show_bug.cgi?id=195139
150
151         Because Metal is only supported on 64 bit apps.
152
153         Unreviewed build fix.
154
155         * Configurations/FeatureDefines.xcconfig:
156
157 2019-02-27  Antoine Quint  <graouts@apple.com>
158
159         Support Pointer Events on macOS
160         https://bugs.webkit.org/show_bug.cgi?id=195008
161         <rdar://problem/47454419>
162
163         Reviewed by Dean Jackson.
164
165         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
166
167         * Configurations/FeatureDefines.xcconfig:
168         * WebView/WebPreferenceKeysPrivate.h:
169         * WebView/WebPreferences.mm:
170         (+[WebPreferences initialize]):
171         (-[WebPreferences pointerEventsEnabled]):
172         (-[WebPreferences setPointerEventsEnabled:]):
173         * WebView/WebPreferencesPrivate.h:
174         * WebView/WebView.mm:
175         (-[WebView _preferencesChanged:]):
176
177 2019-02-23  Keith Miller  <keith_miller@apple.com>
178
179         Add new mac target numbers
180         https://bugs.webkit.org/show_bug.cgi?id=194955
181
182         Reviewed by Tim Horton.
183
184         * Configurations/Base.xcconfig:
185         * Configurations/DebugRelease.xcconfig:
186
187 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
188
189         Hardcode Visual Viewports on everywhere except iOS WK1
190         https://bugs.webkit.org/show_bug.cgi?id=194928
191
192         Reviewed by Zalan Bujtas.
193
194         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
195         change the default value of the Setting to 'true', and hardcode WebView on iOS to
196         set it to false. The setting has shipped for several years and there's no need to turn
197         it off now.
198
199         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
200         Visual Viewports are not enabled.
201         
202         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
203         that only runs in WK2
204
205         * WebView/WebPreferenceKeysPrivate.h:
206         * WebView/WebPreferences.mm:
207         (+[WebPreferences initialize]):
208         (-[WebPreferences visualViewportEnabled]): Deleted.
209         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
210         * WebView/WebPreferencesPrivate.h:
211         * WebView/WebView.mm:
212         (-[WebView _preferencesChanged:]):
213
214 2019-02-21  Darin Adler  <darin@apple.com>
215
216         Some refinements for Node and Document
217         https://bugs.webkit.org/show_bug.cgi?id=194764
218
219         Reviewed by Ryosuke Niwa.
220
221         * DOM/DOMDocument.mm:
222         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
223         through to WebCore or even looking at the arguments.
224         (-[DOMDocument getOverrideStyle::]): Ditto.
225
226 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
227
228         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
229         https://bugs.webkit.org/show_bug.cgi?id=194670
230         <rdar://problem/39066529>
231
232         Reviewed by Tim Horton.
233
234         * WebCoreSupport/WebEditorClient.h:
235         * WebCoreSupport/WebEditorClient.mm:
236         (WebEditorClient::replacementURLForResource): Deleted.
237         * WebCoreSupport/WebPlatformStrategies.h:
238         * WebCoreSupport/WebPlatformStrategies.mm:
239         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
240
241 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
242
243         Add MSE logging configuration
244         https://bugs.webkit.org/show_bug.cgi?id=194719
245         <rdar://problem/48122151>
246
247         Reviewed by Joseph Pecoraro.
248
249         * WebCoreSupport/WebChromeClient.mm:
250         (stringForMessageSource): Recognize the MSE message source.
251
252 2019-02-17  David Kilzer  <ddkilzer@apple.com>
253
254         Unreviewed, rolling out r241620.
255
256         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
257         (Requested by ddkilzer on #webkit.)
258
259         Reverted changeset:
260
261         "[WTF] Add environment variable helpers"
262         https://bugs.webkit.org/show_bug.cgi?id=192405
263         https://trac.webkit.org/changeset/241620
264
265 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
266
267         [WTF] Add environment variable helpers
268         https://bugs.webkit.org/show_bug.cgi?id=192405
269
270         Reviewed by Michael Catanzaro.
271
272         * WebView/WebView.mm:
273         (-[WebView _initWithFrame:frameName:groupName:]):
274         Utilize WTF::Environment where possible.
275
276 2019-02-15  Brian Burg  <bburg@apple.com>
277
278         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
279         https://bugs.webkit.org/show_bug.cgi?id=194411
280         <rdar://problem/47787614>
281
282         Reviewed by Joseph Pecoraro.
283
284         * Configurations/WebKitLegacy.xcconfig:
285         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
286
287         * WebCoreSupport/WebInspectorClient.mm:
288         (WebInspectorFrontendClient::localizedStringsURL):
289         (-[WebInspectorWindowController inspectorPagePath]):
290         (-[WebInspectorWindowController inspectorTestPagePath]):
291         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
292
293 2019-02-15  Commit Queue  <commit-queue@webkit.org>
294
295         Unreviewed, rolling out r241559 and r241566.
296         https://bugs.webkit.org/show_bug.cgi?id=194710
297
298         Causes layout test crashes under GuardMalloc (Requested by
299         ryanhaddad on #webkit).
300
301         Reverted changesets:
302
303         "[WTF] Add environment variable helpers"
304         https://bugs.webkit.org/show_bug.cgi?id=192405
305         https://trac.webkit.org/changeset/241559
306
307         "Unreviewed build fix for WinCairo Debug after r241559."
308         https://trac.webkit.org/changeset/241566
309
310 2019-02-15  Truitt Savell  <tsavell@apple.com>
311
312         Unreviewed, rolling out r241564.
313
314         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
315
316         Reverted changeset:
317
318         "[Mac] WebInspectorUI.framework does not need to be soft-
319         linked anymore"
320         https://bugs.webkit.org/show_bug.cgi?id=194411
321         https://trac.webkit.org/changeset/241564
322
323 2019-02-14  Brian Burg  <bburg@apple.com>
324
325         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
326         https://bugs.webkit.org/show_bug.cgi?id=194411
327         <rdar://problem/47787614>
328
329         Reviewed by Joseph Pecoraro.
330
331         * Configurations/WebKitLegacy.xcconfig:
332         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
333
334         * WebCoreSupport/WebInspectorClient.mm:
335         (WebInspectorFrontendClient::localizedStringsURL):
336         (-[WebInspectorWindowController inspectorPagePath]):
337         (-[WebInspectorWindowController inspectorTestPagePath]):
338         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
339
340 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
341
342         [WTF] Add environment variable helpers
343         https://bugs.webkit.org/show_bug.cgi?id=192405
344
345         Reviewed by Michael Catanzaro.
346
347         * WebView/WebView.mm:
348         (-[WebView _initWithFrame:frameName:groupName:]):
349         Utilize WTF::Environment where possible.
350
351 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
352
353         Allow pages to trigger programmatic paste from script on iOS
354         https://bugs.webkit.org/show_bug.cgi?id=194271
355         <rdar://problem/47808810>
356
357         Reviewed by Ryosuke Niwa.
358
359         See WebCore and WebKit ChangeLogs for more details.
360
361         * WebCoreSupport/WebEditorClient.h:
362
363 2019-02-12  Andy Estes  <aestes@apple.com>
364
365         [iOSMac] Enable Parental Controls Content Filtering
366         https://bugs.webkit.org/show_bug.cgi?id=194521
367         <rdar://39732376>
368
369         Reviewed by Tim Horton.
370
371         * Configurations/FeatureDefines.xcconfig:
372
373 2019-02-06  Andy Estes  <aestes@apple.com>
374
375         [Payment Request] It should be possible to require a phonetic name for shipping contacts
376         https://bugs.webkit.org/show_bug.cgi?id=194311
377         <rdar://46733045>
378
379         Reviewed by Alex Christensen.
380
381         * WebCoreSupport/WebPaymentCoordinatorClient.h:
382         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
383         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
384
385 2019-02-04  Said Abou-Hallawa  <said@apple.com>
386
387         [CG] Enable setAdditionalSupportedImageTypes for WK1
388         https://bugs.webkit.org/show_bug.cgi?id=194190
389
390         Reviewed by Tim Horton.
391
392         1. Define the preferences key AdditionalSupportedImageTypes.
393         2. Add additionalSupportedImageTypes as a private preference property.
394         3. Define the setter and the getter of the property.
395         4. Add function to convert from an id to an array of strings.
396         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
397
398         * WebView/WebPreferenceKeysPrivate.h:
399         * WebView/WebPreferences.mm:
400         (-[WebPreferences _stringArrayValueForKey:]):
401         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
402         (-[WebPreferences setAdditionalSupportedImageTypes:]):
403         (-[WebPreferences additionalSupportedImageTypes]):
404         * WebView/WebPreferencesPrivate.h:
405         * WebView/WebView.mm:
406         (-[WebView _preferencesChanged:]):
407
408 2019-02-04  Timothy Hatcher  <timothy@apple.com>
409
410         Add WebView SPI to temporarily force light or dark appearance on a page.
411         https://bugs.webkit.org/show_bug.cgi?id=194230
412
413         Reviewed by Tim Horton.
414
415         * WebView/WebView.mm:
416         (-[WebView _useDarkAppearance:]): Added.
417         (-[WebView _setUseDarkAppearance:]): Added.
418         * WebView/WebViewPrivate.h:
419
420 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
421
422         PageOverlayController's layers should be created lazily
423         https://bugs.webkit.org/show_bug.cgi?id=194199
424         rdar://problem/46571593
425
426         Reviewed by Tim Horton.
427
428         * WebCoreSupport/WebChromeClient.h:
429         * WebCoreSupport/WebChromeClient.mm:
430         (WebChromeClient::attachViewOverlayGraphicsLayer):
431
432 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
433
434         Make setNeedsLayout on the root more explicitly about triggering its side-effects
435         https://bugs.webkit.org/show_bug.cgi?id=194198
436
437         Reviewed by Antti Koivisto.
438
439         Call the newly named functions.
440
441         * WebView/WebFrame.mm:
442         (-[WebFrame setNeedsLayout]):
443         * WebView/WebHTMLView.mm:
444         (-[WebHTMLView setNeedsLayout:]):
445
446 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
447
448         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
449         https://bugs.webkit.org/show_bug.cgi?id=194189
450
451         Reviewed by Geoffrey Garen.
452
453         Pass the policy check identifier around functions and store it in WebFramePolicyListener
454         so that we can send it back to WebCore with the navigation policy decision.
455
456         * WebCoreSupport/WebFrameLoaderClient.h:
457         * WebCoreSupport/WebFrameLoaderClient.mm:
458         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
459         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
460         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
461         (WebFrameLoaderClient::dispatchWillSubmitForm):
462         (WebFrameLoaderClient::setUpPolicyListener):
463         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
464         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
465         (-[WebFramePolicyListener invalidate]):
466         (-[WebFramePolicyListener dealloc]):
467         (-[WebFramePolicyListener receivedPolicyDecision:]):
468         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
469         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
470
471 2019-01-31  Alex Christensen  <achristensen@webkit.org>
472
473         Revert r238819 which is unneeded and caused a performance regression.
474         https://bugs.webkit.org/show_bug.cgi?id=192272
475         <rdar://problem/46664625>
476
477         * WebCoreSupport/WebFrameLoaderClient.h:
478         * WebCoreSupport/WebFrameLoaderClient.mm:
479         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
480
481 2019-01-28  Devin Rousso  <drousso@apple.com>
482
483         Web Inspector: provide a way to edit page WebRTC settings on a remote target
484         https://bugs.webkit.org/show_bug.cgi?id=193863
485         <rdar://problem/47572764>
486
487         Reviewed by Joseph Pecoraro.
488
489         * WebView/WebView.mm:
490         (-[WebView _preferencesChanged:]):
491         Add page-level settings for WebRTC preferences.
492
493 2019-01-28  Andy Estes  <aestes@apple.com>
494
495         [watchOS] Enable Parental Controls content filtering
496         https://bugs.webkit.org/show_bug.cgi?id=193939
497         <rdar://problem/46641912>
498
499         Reviewed by Ryosuke Niwa.
500
501         * Configurations/FeatureDefines.xcconfig:
502
503 2019-01-28  Timothy Hatcher  <timothy@apple.com>
504
505         Make it easier for non-Apple ports to enable dark mode CSS support.
506         https://bugs.webkit.org/show_bug.cgi?id=193882
507
508         Reviewed by Megan Gardner.
509
510         * WebView/WebView.mm:
511         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
512         (-[WebView _effectiveAppearanceIsDark]): Ditto.
513
514 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
515
516         AX: Introduce a static accessibility tree
517         https://bugs.webkit.org/show_bug.cgi?id=193348
518         <rdar://problem/47203295>
519
520         Reviewed by Ryosuke Niwa.
521
522         * Configurations/FeatureDefines.xcconfig:
523
524 2019-01-25  Keith Rollin  <krollin@apple.com>
525
526         Update WebKitAdditions.xcconfig with correct order of variable definitions
527         https://bugs.webkit.org/show_bug.cgi?id=193793
528         <rdar://problem/47532439>
529
530         Reviewed by Alex Christensen.
531
532         XCBuild changes the way xcconfig variables are evaluated. In short,
533         all config file assignments are now considered in part of the
534         evaluation. When using the new build system and an .xcconfig file
535         contains multiple assignments of the same build setting:
536
537         - Later assignments using $(inherited) will inherit from earlier
538           assignments in the xcconfig file.
539         - Later assignments not using $(inherited) will take precedence over
540           earlier assignments. An assignment to a more general setting will
541           mask an earlier assignment to a less general setting. For example,
542           an assignment without a condition ('FOO = bar') will completely mask
543           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
544
545         This affects some of our .xcconfig files, in that sometimes platform-
546         or sdk-specific definitions appear before the general definitions.
547         Under the new evaluations rules, the general definitions alway take
548         effect because they always overwrite the more-specific definitions. The
549         solution is to swap the order, so that the general definitions are
550         established first, and then conditionally overwritten by the
551         more-specific definitions.
552
553         * Configurations/Version.xcconfig:
554         * Configurations/WebKitLegacy.xcconfig:
555
556 2019-01-25  David Kilzer  <ddkilzer@apple.com>
557
558         Move soft-linking of Lookup.framework out of LookupSPI.h
559         <https://webkit.org/b/193815>
560
561         Reviewed by Tim Horton.
562
563         * WebView/WebImmediateActionController.mm:
564         (-[WebImmediateActionController _animationControllerForText]):
565         * WebView/WebView.mm:
566         (-[WebView _prepareForDictionaryLookup]):
567         - Move soft-linking to LookupSoftLink.{h,mm}.
568
569 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
570
571         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
572         https://bugs.webkit.org/show_bug.cgi?id=193829
573
574         Reviewed by Tim Horton.
575
576         * WebCoreSupport/WebDragClient.mm:
577         (WebDragClient::didConcludeEditDrag):
578         * WebView/WebView.mm:
579         (-[WebView _requestStartDataInteraction:globalPosition:]):
580         (-[WebView _didConcludeEditDrag]):
581         (-[WebView _didConcludeEditDataInteraction]): Deleted.
582         * WebView/WebViewInternal.h:
583
584 2019-01-24  John Wilander  <wilander@apple.com>
585
586         Add Ad Click Attribution as an internal/experimental feature
587         https://bugs.webkit.org/show_bug.cgi?id=193685
588         <rdar://problem/47450399>
589
590         Reviewed by Brent Fulgham.
591
592         * WebView/WebPreferenceKeysPrivate.h:
593         * WebView/WebPreferences.mm:
594         (+[WebPreferences initialize]):
595         (-[WebPreferences adClickAttributionEnabled]):
596         (-[WebPreferences setAdClickAttributionEnabled:]):
597             Added support for experimental ad click attribution.
598         * WebView/WebPreferencesPrivate.h:
599         * WebView/WebView.mm:
600         (-[WebView _preferencesChanged:]):
601
602 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
603
604         Move FileSystem to WTF
605         https://bugs.webkit.org/show_bug.cgi?id=193602
606
607         Reviewed by Yusuke Suzuki.
608
609         * Misc/WebNSFileManagerExtras.mm:
610         * Storage/WebDatabaseProvider.mm:
611         * WebView/WebView.mm:
612
613 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
614
615         Fix the Apple Internal build. See <rdar://problem/47491383>.
616
617         Rubber-stamped by Tim Horton.
618
619         * WebCoreSupport/WebFrameLoaderClient.mm:
620
621 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
622
623         Clean up USE(WEB_THREAD)
624         https://bugs.webkit.org/show_bug.cgi?id=193698
625
626         Rubber-stamped by Tim Horton.
627
628         * Misc/WebCache.mm:
629         (+[WebCache emptyInMemoryResources]):
630         * WebCoreSupport/WebFrameLoaderClient.mm:
631         (-[WebFramePolicyListener use]):
632         * WebCoreSupport/WebGeolocationClient.mm:
633         (-[WebGeolocationPolicyListener allow]):
634         (-[WebGeolocationPolicyListener deny]):
635         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
636         * WebView/WebFrame.mm:
637         (-[WebFrame deviceOrientationChanged]):
638         * WebView/WebHTMLView.mm:
639         (hardwareKeyboardAvailabilityChangedCallback):
640         * WebView/WebView.mm:
641         (+[WebView _releaseMemoryNow]):
642         (+[WebView willEnterBackgroundWithCompletionHandler:]):
643         (-[WebView updateLayoutIgnorePendingStyleSheets]):
644         (-[WebView _dispatchUnloadEvent]):
645         (-[WebView _close]):
646         (-[WebView _preferencesChangedNotification:]):
647         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
648         (-[WebView goBack]):
649         (-[WebView goForward]):
650         (+[WebView _cacheModelChangedNotification:]):
651         (-[WebView stopLoading:]):
652         (-[WebView stopLoadingAndClear]):
653         (-[WebView reload:]):
654         (WebInstallMemoryPressureHandler):
655
656 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
657
658         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
659         https://bugs.webkit.org/show_bug.cgi?id=193706
660         <rdar://problem/44807048>
661
662         Reviewed by Ryosuke Niwa.
663
664         Use UndoStep::label().
665
666         * WebCoreSupport/WebEditorClient.h:
667         * WebCoreSupport/WebEditorClient.mm:
668         (-[WebUndoStep initWithUndoStep:]):
669         (+[WebUndoStep stepWithUndoStep:]):
670         (WebEditorClient::registerUndoOrRedoStep):
671         (WebEditorClient::registerUndoStep):
672         (WebEditorClient::registerRedoStep):
673
674 2019-01-22  Alex Christensen  <achristensen@webkit.org>
675
676         Move NetworkStorageSession ownership to NetworkProcess
677         https://bugs.webkit.org/show_bug.cgi?id=193580
678
679         Reviewed by Geoff Garen.
680
681         * Misc/WebCache.mm:
682         (+[WebCache clearCachedCredentials]):
683         * Misc/WebDownload.mm:
684         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
685         * Plugins/WebBaseNetscapePluginView.mm:
686         (WebKit::getAuthenticationInfo):
687         * WebCoreSupport/WebFrameNetworkingContext.mm:
688         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
689         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
690         (WebFrameNetworkingContext::storageSession const):
691         * WebView/WebPreferences.mm:
692         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
693         (+[WebPreferences _clearNetworkLoaderSession]):
694         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
695
696 2019-01-22  Daniel Bates  <dabates@apple.com>
697
698         [iOS] Interpret text key commands on keydown and app key commands on keypress
699         https://bugs.webkit.org/show_bug.cgi?id=192897
700         <rdar://problem/46857378>
701
702         Reviewed by Brent Fulgham.
703
704         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
705         is false) and keypress (isCharEvent is true), respectively.
706
707         * WebView/WebHTMLView.mm:
708         (-[WebHTMLView _handleEditingKeyEvent:]):
709
710 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
711
712         [css-logical] Implement flow-relative margin, padding and border shorthands
713         https://bugs.webkit.org/show_bug.cgi?id=188697
714
715         Reviewed by Simon Fraser and Antti Koivisto.
716
717         Add CSSLogicalEnabled runtime flag.
718
719         * WebView/WebPreferenceKeysPrivate.h:
720         * WebView/WebPreferences.mm:
721         (+[WebPreferences initialize]):
722         (-[WebPreferences cssLogicalEnabled]):
723         (-[WebPreferences setCSSLogicalEnabled:]):
724         * WebView/WebPreferencesPrivate.h:
725         * WebView/WebView.mm:
726         (-[WebView _preferencesChanged:]):
727
728 2019-01-15  Darin Adler  <darin@apple.com>
729
730         Use references rather than pointers for register/unregister functions, and more
731         https://bugs.webkit.org/show_bug.cgi?id=175028
732
733         Reviewed by Daniel Bates.
734
735         * WebCoreSupport/WebKitFullScreenListener.mm:
736         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
737         functions in Document; pass a reference.
738         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
739         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
740         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
741         * WebView/WebFullScreenController.mm:
742         (-[WebFullScreenController enterFullScreen:]): Ditto.
743         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
744         (-[WebFullScreenController exitFullScreen]): Ditto.
745         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
746         * WebView/WebFullScreenController.mm:
747         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
748
749 2019-01-12  Dan Bernstein  <mitz@apple.com>
750
751         [Cocoa] Avoid importing directly from subumbrella frameworks
752         https://bugs.webkit.org/show_bug.cgi?id=186016
753         <rdar://problem/40591038>
754
755         Reviewed by Sam Weinig.
756
757         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
758         * Carbon/CarbonWindowAdapter.mm: Ditto.
759         * Carbon/CarbonWindowFrame.m: Ditto.
760         * Carbon/HIViewAdapter.h: Ditto.
761         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
762           OTHER_CFLAGS_COCOA_TOUCH_NO.
763         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
764         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
765         * WebView/WebPDFView.h: Ditto.
766
767 2019-01-20  Antoine Quint  <graouts@apple.com>
768
769         Add a POINTER_EVENTS feature flag
770         https://bugs.webkit.org/show_bug.cgi?id=193577
771         <rdar://problem/47408511>
772
773         Unreviewed. Also enable Pointer Events for iosmac.
774
775         * Configurations/FeatureDefines.xcconfig:
776
777 2019-01-19  Antoine Quint  <graouts@apple.com>
778
779         Add a POINTER_EVENTS feature flag
780         https://bugs.webkit.org/show_bug.cgi?id=193577
781
782         Reviewed by Dean Jackson.
783
784         * Configurations/FeatureDefines.xcconfig:
785
786 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
787
788         Revert r238815, it broke WK1 video fullscreen on Mac
789         https://bugs.webkit.org/show_bug.cgi?id=193586
790         <rdar://problem/47358941>
791
792         Reviewed by Jer Noble.
793
794         * WebView/WebVideoFullscreenController.h: Added.
795         * WebView/WebVideoFullscreenController.mm: Added.
796         (SOFT_LINK_CLASS):
797         (-[WebVideoFullscreenController init]):
798         (-[WebVideoFullscreenController dealloc]):
799         (-[WebVideoFullscreenController fullscreenWindow]):
800         (-[WebVideoFullscreenController windowDidLoad]):
801         (-[WebVideoFullscreenController videoElement]):
802         (-[WebVideoFullscreenController setVideoElement:]):
803         (-[WebVideoFullscreenController clearFadeAnimation]):
804         (-[WebVideoFullscreenController windowDidExitFullscreen]):
805         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
806         (-[WebVideoFullscreenController videoElementRect]):
807         (-[WebVideoFullscreenController applicationDidResignActive:]):
808         (frameExpandedToRatioOfFrame):
809         (createBackgroundFullscreenWindow):
810         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
811         (-[WebVideoFullscreenController enterFullscreen:]):
812         (-[WebVideoFullscreenController exitFullscreen]):
813         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
814         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
815         (-[WebVideoFullscreenController _requestExit]):
816         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
817         (-[WebVideoFullscreenController requestExitFullscreen]):
818         (-[WebVideoFullscreenController fadeHUDIn]):
819         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
820         (-[WebVideoFullscreenController rateChanged:]):
821         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
822         (-[WebVideoFullscreenWindow dealloc]):
823         (-[WebVideoFullscreenWindow resignFirstResponder]):
824         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
825         (-[WebVideoFullscreenWindow mouseDown:]):
826         (-[WebVideoFullscreenWindow cancelOperation:]):
827         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
828         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
829         (-[WebVideoFullscreenWindow animationDidEnd:]):
830         (-[WebVideoFullscreenWindow mouseMoved:]):
831         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
832         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
833         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
834         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
835         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
836         (-[WebVideoFullscreenHUDWindow center]):
837         (-[WebVideoFullscreenHUDWindow keyDown:]):
838         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
839         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
840         (-[WebVideoFullscreenHUDWindowController init]):
841         (-[WebVideoFullscreenHUDWindowController dealloc]):
842         (-[WebVideoFullscreenHUDWindowController setArea:]):
843         (-[WebVideoFullscreenHUDWindowController keyDown:]):
844         (-[WebVideoFullscreenHUDWindowController delegate]):
845         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
846         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
847         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
848         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
849         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
850         (-[WebVideoFullscreenHUDWindowController closeWindow]):
851         (createMediaUIControl):
852         (createControlWithMediaUIControlType):
853         (createTimeTextField):
854         (createMediaUIBackgroundView):
855         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
856         (-[WebVideoFullscreenHUDWindowController updateVolume]):
857         (-[WebVideoFullscreenHUDWindowController updateTime]):
858         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
859         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
860         (-[WebVideoFullscreenHUDWindowController currentTime]):
861         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
862         (-[WebVideoFullscreenHUDWindowController duration]):
863         (-[WebVideoFullscreenHUDWindowController maxVolume]):
864         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
865         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
866         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
867         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
868         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
869         (-[WebVideoFullscreenHUDWindowController volume]):
870         (-[WebVideoFullscreenHUDWindowController setVolume:]):
871         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
872         (-[WebVideoFullscreenHUDWindowController updateRate]):
873         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
874         (-[WebVideoFullscreenHUDWindowController playing]):
875         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
876         (timeToString):
877         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
878         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
879         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
880         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
881         (-[WebVideoFullscreenHUDWindowController rewind:]):
882         (-[WebVideoFullscreenHUDWindowController fastForward:]):
883         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
884         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
885         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
886         * WebView/WebView.mm:
887         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
888         (-[WebView _exitVideoFullscreen]):
889
890 2019-01-18  Tim Horton  <timothy_horton@apple.com>
891
892         Get rid of ADVANCED_SPELL_CHECKING
893         https://bugs.webkit.org/show_bug.cgi?id=193592
894
895         Reviewed by Wenson Hsieh.
896
897         * WebCoreSupport/WebEditorClient.mm:
898         (insertionPointFromCurrentSelection):
899         (WebEditorClient::checkTextOfParagraph):
900         (WebEditorClient::getGuessesForWord):
901         (WebEditorClient::requestCandidatesForSelection):
902         (WebEditorClient::requestCheckingOfString):
903         * WebView/WebHTMLView.mm:
904         (-[WebHTMLView insertText:]):
905
906 2019-01-18  Jer Noble  <jer.noble@apple.com>
907
908         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
909         https://bugs.webkit.org/show_bug.cgi?id=189553
910
911         Reviewed by Tim Horton.
912
913         * Configurations/Base.xcconfig:
914         * Configurations/SDKVariant.xcconfig: Added.
915         * Configurations/WebKitLegacy.xcconfig:
916
917 2019-01-18  David Kilzer  <ddkilzer@apple.com>
918
919         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
920         <https://webkit.org/b/193568>
921         <rdar://problem/47381130>
922
923         Reviewed by Alex Christensen.
924
925         * WebView/WebView.mm:
926         - Remove unused soft-linking macros.
927         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
928         (-[WebUITextIndicatorData initWithImage:scale:]):
929         - Update to use exported PAL functions.
930
931 2019-01-17  Truitt Savell  <tsavell@apple.com>
932
933         Unreviewed, rolling out r240124.
934
935         This commit broke an internal build.
936
937         Reverted changeset:
938
939         "SDK_VARIANT build destinations should be separate from non-
940         SDK_VARIANT builds"
941         https://bugs.webkit.org/show_bug.cgi?id=189553
942         https://trac.webkit.org/changeset/240124
943
944 2019-01-17  Jer Noble  <jer.noble@apple.com>
945
946         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
947         https://bugs.webkit.org/show_bug.cgi?id=189553
948
949         Reviewed by Tim Horton.
950
951         * Configurations/Base.xcconfig:
952         * Configurations/SDKVariant.xcconfig: Added.
953         * Configurations/WebKitLegacy.xcconfig:
954
955 2019-01-17  Alex Christensen  <achristensen@webkit.org>
956
957         Stop using NetworkStorageSession::storageSession in WebCore
958         https://bugs.webkit.org/show_bug.cgi?id=193529
959
960         Reviewed by Tim Horton.
961
962         * Misc/WebCache.mm:
963         (+[WebCache addImageToCache:forURL:forFrame:]):
964         * WebView/WebView.mm:
965         (-[WebView _commonInitializationWithFrameName:groupName:]):
966         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
967
968 2019-01-15  Alex Christensen  <achristensen@webkit.org>
969
970         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
971         https://bugs.webkit.org/show_bug.cgi?id=193368
972
973         Reviewed by Geoff Garen.
974
975         * Misc/WebCache.mm:
976         (+[WebCache clearCachedCredentials]):
977         * Misc/WebDownload.mm:
978         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
979         * Plugins/WebBaseNetscapePluginView.mm:
980         (WebKit::getAuthenticationInfo):
981
982 2019-01-15  Alex Christensen  <achristensen@webkit.org>
983
984         Stop using CookiesStrategy
985         https://bugs.webkit.org/show_bug.cgi?id=161106
986
987         Reviewed by Don Olmstead and Antti Koivisto.
988
989         * Misc/WebCache.mm:
990         (+[WebCache addImageToCache:forURL:forFrame:]):
991         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
992         (WebKit::NetscapePluginInstanceProxy::getCookies):
993         (WebKit::NetscapePluginInstanceProxy::setCookies):
994         * Plugins/WebNetscapePluginView.mm:
995         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
996         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
997         * WebCoreSupport/WebPlatformStrategies.h:
998         * WebCoreSupport/WebPlatformStrategies.mm:
999         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1000         (WebPlatformStrategies::cookiesForDOM): Deleted.
1001         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1002         (WebPlatformStrategies::cookiesEnabled): Deleted.
1003         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1004         (WebPlatformStrategies::getRawCookies): Deleted.
1005         (WebPlatformStrategies::deleteCookie): Deleted.
1006         * WebView/WebView.mm:
1007         (-[WebView _commonInitializationWithFrameName:groupName:]):
1008         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1009
1010 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1011
1012         Cannot tab out of WKWebView on macOS
1013         https://bugs.webkit.org/show_bug.cgi?id=161448
1014         <rdar://problem/28100085>
1015
1016         Reviewed by Dean Jackson.
1017
1018         * WebCoreSupport/WebChromeClient.mm:
1019         * WebView/WebView.mm:
1020         Make use of SPI headers.
1021
1022 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1023
1024         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1025         r239913, and r239914.
1026         https://bugs.webkit.org/show_bug.cgi?id=193407
1027
1028         These revisions caused an internal failure (Requested by
1029         Truitt on #webkit).
1030
1031         Reverted changesets:
1032
1033         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1034         https://bugs.webkit.org/show_bug.cgi?id=186016
1035         https://trac.webkit.org/changeset/239901
1036
1037         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1038         https://trac.webkit.org/changeset/239909
1039
1040         "Tried to fix the build."
1041         https://trac.webkit.org/changeset/239910
1042
1043         "Fixed iOS builds after r239910."
1044         https://trac.webkit.org/changeset/239912
1045
1046         "More build fixing."
1047         https://trac.webkit.org/changeset/239913
1048
1049         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1050         https://trac.webkit.org/changeset/239914
1051
1052 2019-01-14  Mark Lam  <mark.lam@apple.com>
1053
1054         Re-enable ability to build --cloop builds.
1055         https://bugs.webkit.org/show_bug.cgi?id=192955
1056         <rdar://problem/46882363>
1057
1058         Reviewed by Saam barati and Keith Miller.
1059
1060         * Configurations/FeatureDefines.xcconfig:
1061
1062 2019-01-13  Dan Bernstein  <mitz@apple.com>
1063
1064         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1065
1066         Patch by Keith Rollin.
1067
1068         * WebView/PDFViewSPI.h:
1069
1070 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1071
1072         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1073         https://bugs.webkit.org/show_bug.cgi?id=191655
1074         rdar://problem/46074680
1075
1076         Reviewed by Megan Gardner.
1077
1078         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1079         * WebView/WebView.mm:
1080         (-[WebView _effectiveAppearanceIsDark]):
1081
1082 2019-01-12  Dan Bernstein  <mitz@apple.com>
1083
1084         [Cocoa] Avoid importing directly from subumbrella frameworks
1085         https://bugs.webkit.org/show_bug.cgi?id=186016
1086         <rdar://problem/40591038>
1087
1088         Reviewed by Sam Weinig.
1089
1090         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1091         * Carbon/CarbonWindowAdapter.mm: Ditto.
1092         * Carbon/CarbonWindowFrame.m: Ditto.
1093         * Carbon/HIViewAdapter.h: Ditto.
1094         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1095           OTHER_CFLAGS_COCOA_TOUCH_NO.
1096         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1097         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1098         * WebView/WebPDFView.h: Ditto.
1099
1100 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1101
1102         Enable visual viewport API by default
1103         https://bugs.webkit.org/show_bug.cgi?id=193376
1104
1105         Reviewed by Simon Fraser.
1106
1107         * WebView/WebPreferences.mm:
1108         (+[WebPreferences initialize]):
1109
1110 2019-01-11  John Wilander  <wilander@apple.com>
1111
1112         Compile out Web API Statistics Collection
1113         https://bugs.webkit.org/show_bug.cgi?id=193370
1114         <rdar://problem/45388584>
1115
1116         Reviewed by Brent Fulgham.
1117
1118         * Configurations/FeatureDefines.xcconfig:
1119             Defined ENABLE_WEB_API_STATISTICS, off by default.
1120
1121 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1122
1123         Stop using NetworkStorageSession in WebProcess
1124         https://bugs.webkit.org/show_bug.cgi?id=193236
1125
1126         Reviewed by Don Olmstead.
1127
1128         * WebCoreSupport/WebFrameNetworkingContext.h:
1129         * WebCoreSupport/WebFrameNetworkingContext.mm:
1130         (WebFrameNetworkingContext::storageSession const):
1131         * WebCoreSupport/WebPlatformStrategies.h:
1132         * WebCoreSupport/WebPlatformStrategies.mm:
1133         (WebPlatformStrategies::cookiesForDOM):
1134         (WebPlatformStrategies::setCookiesFromDOM):
1135         (WebPlatformStrategies::cookiesEnabled):
1136         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1137         (WebPlatformStrategies::getRawCookies):
1138         (WebPlatformStrategies::deleteCookie):
1139         * WebView/WebView.mm:
1140         (-[WebView _cachedResponseForURL:]):
1141         (-[WebView _clearCredentials]):
1142
1143 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1144
1145         Unreviewed, rolling out r239727.
1146
1147         Broke API tests
1148
1149         Reverted changeset:
1150
1151         "Stop using NetworkStorageSession in WebProcess"
1152         https://bugs.webkit.org/show_bug.cgi?id=193236
1153         https://trac.webkit.org/changeset/239727
1154
1155 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1156
1157         Stop using NetworkStorageSession in WebProcess
1158         https://bugs.webkit.org/show_bug.cgi?id=193236
1159
1160         Reviewed by Don Olmstead.
1161
1162         * WebCoreSupport/WebFrameNetworkingContext.h:
1163         * WebCoreSupport/WebFrameNetworkingContext.mm:
1164         (WebFrameNetworkingContext::storageSession const):
1165         * WebView/WebView.mm:
1166         (-[WebView _cachedResponseForURL:]):
1167         (-[WebView _clearCredentials]):
1168
1169 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1170
1171         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1172         <https://webkit.org/b/193056>
1173
1174         Reviewed by Alex Christensen.
1175
1176         * Plugins/Hosted/NetscapePluginHostProxy.h:
1177         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1178         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1179         (WebKit::NetscapePluginInstanceProxy::enumerate):
1180         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1181         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1182         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1183         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1184         * Plugins/Hosted/ProxyInstance.mm:
1185         (WebKit::ProxyInstance::invoke):
1186         * WebCoreSupport/WebGeolocationClient.mm:
1187         * WebView/WebDataSource.mm:
1188         (-[WebDataSource _receivedData:]):
1189         * WebView/WebView.mm:
1190         (-[WebView _cachedResponseForURL:]):
1191         - Remove '*' from RetainPtr<> type.
1192
1193 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1194
1195         Progress towards fixing Mac CMake build
1196         https://bugs.webkit.org/show_bug.cgi?id=193105
1197
1198         Reviewed by Don Olmstead.
1199
1200         * WebKitPrefix.h:
1201
1202 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1203
1204         Web Inspector: Use save sheet instead of dialog where possible
1205         https://bugs.webkit.org/show_bug.cgi?id=193160
1206         <rdar://problem/37399759>
1207
1208         Reviewed by Devin Rousso.
1209
1210         * WebCoreSupport/WebInspectorClient.mm:
1211         (WebInspectorFrontendClient::save):
1212
1213 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1214
1215         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1216         https://bugs.webkit.org/show_bug.cgi?id=193129
1217
1218         Reviewed by Tim Horton.
1219
1220         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1221
1222         * WebCoreSupport/WebEditorClient.mm:
1223         (WebEditorClient::registerUndoOrRedoStep):
1224         (undoNameForEditAction): Deleted.
1225
1226 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1227
1228         Add support for using the current text selection as the find string on iOS
1229         https://bugs.webkit.org/show_bug.cgi?id=193034
1230         <rdar://problem/45138739>
1231
1232         Reviewed by Tim Horton.
1233
1234         Add a method stub for WebKitLegacy.
1235
1236         * WebCoreSupport/WebEditorClient.h:
1237
1238 2019-01-01  Jeff Miller  <jeffm@apple.com>
1239
1240         Update user-visible copyright strings to include 2019
1241         https://bugs.webkit.org/show_bug.cgi?id=192811
1242
1243         Reviewed by Mark Lam.
1244
1245         * Info.plist:
1246
1247 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1248
1249         Use Ref<> as much as possible
1250         https://bugs.webkit.org/show_bug.cgi?id=192808
1251
1252         Reviewed by Alex Christensen.
1253
1254         * DOM/DOM.mm:
1255         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1256         * Plugins/Hosted/NetscapePluginHostManager.mm:
1257         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1258         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1259         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1260         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1261         * Plugins/WebNetscapePluginView.mm:
1262         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1263         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1264         * WebCoreSupport/WebContextMenuClient.mm:
1265         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1266         * WebCoreSupport/WebFrameLoaderClient.mm:
1267         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1268         * WebView/WebFrame.mm:
1269         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1270         * WebView/WebHTMLView.mm:
1271         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1272         * WebView/WebView.mm:
1273         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1274         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1275
1276 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1277
1278         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1279         https://bugs.webkit.org/show_bug.cgi?id=192821
1280
1281         Reviewed by Chris Dumez.
1282
1283         When a window becomes occluded, the window server informs the application.
1284         This should be used to suspend any work that is not visible by the user.
1285
1286         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1287         In some cases, that lead to performance impact (see radar).
1288
1289         This patch adds an observer for the occlusion notification. I tried to stick
1290         with the same names used by WebKit2.
1291
1292         * WebView/WebView.mm:
1293         (-[WebView _isViewVisible]):
1294         (-[WebView addWindowObserversForWindow:]):
1295         (-[WebView removeWindowObservers]):
1296         (-[WebView _windowDidChangeOcclusionState:]):
1297
1298 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1299
1300         [WebAuthN] Add a runtime flag for local authenticator
1301         https://bugs.webkit.org/show_bug.cgi?id=192792
1302         <rdar://problem/46798738>
1303
1304         Reviewed by Brent Fulgham.
1305
1306         * WebView/WebPreferenceKeysPrivate.h:
1307         * WebView/WebPreferences.mm:
1308         (+[WebPreferences initialize]):
1309         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1310         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1311         * WebView/WebPreferencesPrivate.h:
1312         * WebView/WebView.mm:
1313         (-[WebView _preferencesChanged:]):
1314
1315 2018-12-20  Chris Dumez  <cdumez@apple.com>
1316
1317         Use Optional::valueOr() instead of Optional::value_or()
1318         https://bugs.webkit.org/show_bug.cgi?id=192933
1319
1320         Reviewed by Geoffrey Garen.
1321
1322         * WebCoreSupport/WebSecurityOrigin.mm:
1323         (-[WebSecurityOrigin port]):
1324
1325 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1326
1327         Unreviewed, rolling out r239417.
1328
1329         Introduced two API test failures on macOS.
1330
1331         Reverted changeset:
1332
1333         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1334         occlusion changes"
1335         https://bugs.webkit.org/show_bug.cgi?id=192821
1336         https://trac.webkit.org/changeset/239417
1337
1338 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1339
1340         WKWebView default UA doesn't freeze the build number
1341         https://bugs.webkit.org/show_bug.cgi?id=192809
1342         <rdar://problem/44687185>
1343
1344         Reviewed by Andy Estes.
1345
1346         Always reports the frozen build number.
1347
1348         * WebView/WebView.mm:
1349         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1350         actual build number through this method call.
1351         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1352
1353 2018-12-19  Chris Dumez  <cdumez@apple.com>
1354
1355         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1356         https://bugs.webkit.org/show_bug.cgi?id=192728
1357         <rdar://problem/46746779>
1358
1359         Reviewed by Geoff Garen.
1360
1361         * DOM/*:
1362         * Plugins/*:
1363         * WebCoreSupport/*:
1364         * WebView/*:
1365
1366 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1367
1368         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1369         https://bugs.webkit.org/show_bug.cgi?id=192821
1370
1371         Reviewed by Chris Dumez.
1372
1373         When a window becomes occluded, the window server informs the application.
1374         This should be used to suspend any work that is not visible by the user.
1375
1376         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1377         In some cases, that lead to performance impact (see radar).
1378
1379         This patch adds an observer for the occlusion notification. I tried to stick
1380         with the same names used by WebKit2.
1381
1382         * WebView/WebView.mm:
1383         (-[WebView _isViewVisible]):
1384         (-[WebView addWindowObserversForWindow:]):
1385         (-[WebView removeWindowObservers]):
1386         (-[WebView _windowDidChangeOcclusionState:]):
1387
1388 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1389
1390         Allow clients to set the navigator platform
1391         https://bugs.webkit.org/show_bug.cgi?id=192735
1392
1393         Reviewed by Tim Horton.
1394
1395         Add stubs to fill out the added functionality in FrameLoaderClient.
1396
1397         * WebCoreSupport/WebFrameLoaderClient.h:
1398         * WebCoreSupport/WebFrameLoaderClient.mm:
1399         (WebFrameLoaderClient::navigatorPlatform):
1400
1401 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1402
1403         offsetLeft and offsetParent should adjust across shadow boundaries
1404         https://bugs.webkit.org/show_bug.cgi?id=157437
1405         <rdar://problem/26154021>
1406
1407         Reviewed by Simon Fraser.
1408
1409         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1410
1411         * DOM/DOMElement.mm:
1412         (-[DOMElement offsetLeft]):
1413         (-[DOMElement offsetTop]):
1414         (-[DOMElement offsetParent]):
1415
1416 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1417
1418         Unreviewed build fix.
1419
1420         * WebView/WebFrame.mm:
1421         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1422
1423 2018-12-15  Darin Adler  <darin@apple.com>
1424
1425         Use warning-ignoring macros more consistently and simply
1426         https://bugs.webkit.org/show_bug.cgi?id=192743
1427
1428         Reviewed by Mark Lam.
1429
1430         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1431         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1432         compilers in Objective-C++ code.
1433
1434         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1435         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1436         accomodate non-clang compilers here. Also use #pragma once, add a missing
1437         "explicit" and fix conditionals.
1438
1439 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1440
1441         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1442         https://bugs.webkit.org/show_bug.cgi?id=192653
1443
1444         Reviewed by Wenson Hsieh.
1445
1446         * WebView/WebHTMLView.mm:
1447         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1448
1449 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1450
1451         Implement feature flag for CSS Typed OM
1452         https://bugs.webkit.org/show_bug.cgi?id=192610
1453
1454         Reviewed by Ryosuke Niwa.
1455
1456         * Configurations/FeatureDefines.xcconfig:
1457
1458 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1459
1460         WebCore shouldn't have a Objective-C class named NSCursor
1461         https://bugs.webkit.org/show_bug.cgi?id=192602
1462         <rdar://problem/46615532>
1463
1464         Reviewed by Wenson Hsieh.
1465
1466         * WebView/WebFrameView.mm:
1467         (-[WebFrameView keyDown:keyDown:]):
1468         * WebView/WebHTMLView.mm:
1469         (-[WebHTMLView keyDown:]):
1470         (-[WebHTMLView performKeyEquivalent:]):
1471         Only use NSCursor on macOS.
1472
1473 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1474
1475         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1476         https://bugs.webkit.org/show_bug.cgi?id=192573
1477
1478         Reviewed by Simon Fraser.
1479
1480         * Configurations/FeatureDefines.xcconfig:
1481
1482 2018-12-10  Antti Koivisto  <antti@apple.com>
1483
1484         Rename "forced style recalc" to "full style rebuild"
1485         https://bugs.webkit.org/show_bug.cgi?id=192572
1486
1487         Reviewed by Zalan Bujtas.
1488
1489         * WebView/WebHTMLView.mm:
1490         (-[WebHTMLView setNeedsToApplyStyles:]):
1491
1492 2018-12-10  Darin Adler  <darin@apple.com>
1493
1494         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1495         https://bugs.webkit.org/show_bug.cgi?id=192533
1496         rdar://problem/45732710
1497
1498         Reviewed by Anders Carlsson.
1499
1500         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1501         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1502
1503 2018-12-10  Darin Adler  <darin@apple.com>
1504
1505         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1506         https://bugs.webkit.org/show_bug.cgi?id=192532
1507         rdar://problem/45731047
1508
1509         Reviewed by Chris Dumez.
1510
1511         * Plugins/Hosted/NetscapePluginHostManager.mm:
1512         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1513         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1514         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1515
1516 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1517
1518         Turn WritingDirection into an enum class
1519         https://bugs.webkit.org/show_bug.cgi?id=192401
1520         Work towards <rdar://problem/42075638>
1521
1522         Reviewed by Dan Bernstein.
1523
1524         Change WritingDirection from an enum to an enum class. No change in behavior.
1525
1526         * WebView/WebHTMLView.mm:
1527         (-[WebHTMLView toggleBaseWritingDirection:]):
1528         (-[WebHTMLView changeBaseWritingDirection:]):
1529         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1530
1531 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1532
1533         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1534         https://bugs.webkit.org/show_bug.cgi?id=192272
1535
1536         Reviewed by Brady Eidson.
1537
1538         * WebCoreSupport/WebFrameLoaderClient.h:
1539         * WebCoreSupport/WebFrameLoaderClient.mm:
1540         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1541
1542 2018-12-03  Jer Noble  <jer.noble@apple.com>
1543
1544         Get rid of old, dead Mac video fullscreen code.
1545         https://bugs.webkit.org/show_bug.cgi?id=192315
1546
1547         Reviewed by Eric Carlson.
1548
1549         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1550         is no longer supported in the Mac port.
1551
1552         * WebView/WebVideoFullscreenController.h: Removed.
1553         * WebView/WebVideoFullscreenController.mm: Removed.
1554         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1555         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1556         * WebView/WebView.mm:
1557         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1558         (-[WebView _exitVideoFullscreen]):
1559
1560 2018-12-03  Daniel Bates  <dabates@apple.com>
1561
1562         [iOS] Do not handle key events that are key commands
1563         https://bugs.webkit.org/show_bug.cgi?id=191608
1564         <rdar://problem/46046013>
1565
1566         Reviewed by Ryosuke Niwa.
1567
1568         A key down event may be associated with a key command. If it is then we want to execute the
1569         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1570         event as a key command to find out.
1571
1572         * WebView/WebHTMLView.mm:
1573         (-[WebHTMLView _handleEditingKeyEvent:]):
1574
1575 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1576
1577         Add a runtime feature flag for LayoutFormattingContext.
1578         https://bugs.webkit.org/show_bug.cgi?id=192280
1579
1580         Reviewed by Simon Fraser.
1581
1582         * Configurations/FeatureDefines.xcconfig:
1583
1584 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1585
1586         Move URL from WebCore to WTF
1587         https://bugs.webkit.org/show_bug.cgi?id=190234
1588
1589         Reviewed by Keith Miller.
1590
1591         * DOM/DOMAttr.mm:
1592         * DOM/DOMBlob.mm:
1593         * DOM/DOMCSSCharsetRule.mm:
1594         * DOM/DOMCSSImportRule.mm:
1595         * DOM/DOMCSSMediaRule.mm:
1596         * DOM/DOMCSSPageRule.mm:
1597         * DOM/DOMCSSPrimitiveValue.mm:
1598         * DOM/DOMCSSRule.mm:
1599         * DOM/DOMCSSStyleDeclaration.mm:
1600         * DOM/DOMCSSStyleRule.mm:
1601         * DOM/DOMCSSStyleSheet.mm:
1602         * DOM/DOMCSSValue.mm:
1603         * DOM/DOMCharacterData.mm:
1604         * DOM/DOMCounter.mm:
1605         * DOM/DOMDocument.mm:
1606         * DOM/DOMDocumentFragment.mm:
1607         * DOM/DOMDocumentType.mm:
1608         * DOM/DOMEvent.mm:
1609         * DOM/DOMFile.mm:
1610         * DOM/DOMHTMLAnchorElement.mm:
1611         * DOM/DOMHTMLAppletElement.mm:
1612         * DOM/DOMHTMLAreaElement.mm:
1613         * DOM/DOMHTMLBRElement.mm:
1614         * DOM/DOMHTMLBaseElement.mm:
1615         * DOM/DOMHTMLBaseFontElement.mm:
1616         * DOM/DOMHTMLBodyElement.mm:
1617         * DOM/DOMHTMLButtonElement.mm:
1618         * DOM/DOMHTMLCanvasElement.mm:
1619         * DOM/DOMHTMLCollection.mm:
1620         * DOM/DOMHTMLDivElement.mm:
1621         * DOM/DOMHTMLDocument.mm:
1622         * DOM/DOMHTMLElement.mm:
1623         * DOM/DOMHTMLEmbedElement.mm:
1624         * DOM/DOMHTMLFieldSetElement.mm:
1625         * DOM/DOMHTMLFontElement.mm:
1626         * DOM/DOMHTMLFormElement.mm:
1627         * DOM/DOMHTMLFrameElement.mm:
1628         * DOM/DOMHTMLFrameSetElement.mm:
1629         * DOM/DOMHTMLHRElement.mm:
1630         * DOM/DOMHTMLHeadElement.mm:
1631         * DOM/DOMHTMLHeadingElement.mm:
1632         * DOM/DOMHTMLHtmlElement.mm:
1633         * DOM/DOMHTMLIFrameElement.mm:
1634         * DOM/DOMHTMLImageElement.mm:
1635         * DOM/DOMHTMLInputElement.mm:
1636         * DOM/DOMHTMLLIElement.mm:
1637         * DOM/DOMHTMLLabelElement.mm:
1638         * DOM/DOMHTMLLegendElement.mm:
1639         * DOM/DOMHTMLLinkElement.mm:
1640         * DOM/DOMHTMLMapElement.mm:
1641         * DOM/DOMHTMLMarqueeElement.mm:
1642         * DOM/DOMHTMLMediaElement.mm:
1643         * DOM/DOMHTMLMetaElement.mm:
1644         * DOM/DOMHTMLModElement.mm:
1645         * DOM/DOMHTMLOListElement.mm:
1646         * DOM/DOMHTMLObjectElement.mm:
1647         * DOM/DOMHTMLOptGroupElement.mm:
1648         * DOM/DOMHTMLOptionElement.mm:
1649         * DOM/DOMHTMLOptionsCollection.mm:
1650         * DOM/DOMHTMLParagraphElement.mm:
1651         * DOM/DOMHTMLParamElement.mm:
1652         * DOM/DOMHTMLQuoteElement.mm:
1653         * DOM/DOMHTMLScriptElement.mm:
1654         * DOM/DOMHTMLSelectElement.mm:
1655         * DOM/DOMHTMLStyleElement.mm:
1656         * DOM/DOMHTMLTableCaptionElement.mm:
1657         * DOM/DOMHTMLTableCellElement.mm:
1658         * DOM/DOMHTMLTableColElement.mm:
1659         * DOM/DOMHTMLTableElement.mm:
1660         * DOM/DOMHTMLTableRowElement.mm:
1661         * DOM/DOMHTMLTableSectionElement.mm:
1662         * DOM/DOMHTMLTitleElement.mm:
1663         * DOM/DOMHTMLUListElement.mm:
1664         * DOM/DOMHTMLVideoElement.mm:
1665         * DOM/DOMKeyboardEvent.mm:
1666         * DOM/DOMMediaList.mm:
1667         * DOM/DOMMouseEvent.mm:
1668         * DOM/DOMMutationEvent.mm:
1669         * DOM/DOMNamedNodeMap.mm:
1670         * DOM/DOMProcessingInstruction.mm:
1671         * DOM/DOMRange.mm:
1672         * DOM/DOMStyleSheet.mm:
1673         * DOM/DOMText.mm:
1674         * DOM/DOMTextEvent.mm:
1675         * DOM/DOMTokenList.mm:
1676         * DOM/DOMUIEvent.mm:
1677         * DOM/DOMXPathResult.mm:
1678         * History/WebHistoryItem.mm:
1679         * Misc/WebNSURLExtras.mm:
1680         (-[NSURL _web_userVisibleString]):
1681         (-[NSURL _web_URLByRemovingUserInfo]):
1682         (-[NSURL _web_dataForURLComponentType:]):
1683         (-[NSURL _web_schemeData]):
1684         (-[NSURL _web_hostData]):
1685         * Misc/WebUserContentURLPattern.mm:
1686         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1687         * Plugins/WebNetscapePluginStream.h:
1688         (WebNetscapePluginStream::setRequestURL):
1689         * WebCoreSupport/WebChromeClient.h:
1690         * WebCoreSupport/WebChromeClient.mm:
1691         (WebChromeClient::signedPublicKeyAndChallengeString const):
1692         * WebCoreSupport/WebContextMenuClient.h:
1693         * WebCoreSupport/WebContextMenuClient.mm:
1694         * WebCoreSupport/WebDragClient.h:
1695         * WebCoreSupport/WebFrameLoaderClient.h:
1696         * WebCoreSupport/WebFrameLoaderClient.mm:
1697         (WebFrameLoaderClient::updateGlobalHistory):
1698         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1699         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1700         (WebPaymentCoordinatorClient::showPaymentUI):
1701         * WebCoreSupport/WebPlatformStrategies.h:
1702         * WebCoreSupport/WebPlatformStrategies.mm:
1703         (WebPlatformStrategies::readURLFromPasteboard):
1704         * WebCoreSupport/WebPluginInfoProvider.h:
1705         * WebCoreSupport/WebPluginInfoProvider.mm:
1706         (WebPluginInfoProvider::webVisiblePluginInfo):
1707         * WebCoreSupport/WebSecurityOrigin.mm:
1708         * WebCoreSupport/WebVisitedLinkStore.h:
1709         * WebView/WebDataSource.mm:
1710         * WebView/WebFrame.mm:
1711         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1712         * WebView/WebImmediateActionController.mm:
1713         (-[WebImmediateActionController _defaultAnimationController]):
1714         * WebView/WebPDFView.mm:
1715         * WebView/WebScriptDebugger.mm:
1716         * WebView/WebViewInternal.h:
1717
1718 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1719
1720         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1721         https://bugs.webkit.org/show_bug.cgi?id=192197
1722
1723         Reviewed by Jiewen Tan.
1724
1725         * Configurations/FeatureDefines.xcconfig:
1726         * WebCoreSupport/WebChromeClient.h:
1727         * WebCoreSupport/WebChromeClient.mm:
1728
1729 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1730
1731         Remove dead code from an earlier attempt at implementing safe browsing
1732         https://bugs.webkit.org/show_bug.cgi?id=192067
1733
1734         Reviewed by Chris Dumez.
1735
1736         * WebCoreSupport/WebFrameLoaderClient.h:
1737         * WebCoreSupport/WebFrameLoaderClient.mm:
1738         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1739
1740 2018-11-27  Mark Lam  <mark.lam@apple.com>
1741
1742         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1743         https://bugs.webkit.org/show_bug.cgi?id=192055
1744         <rdar://problem/46288783>
1745
1746         Reviewed by Saam Barati.
1747
1748         * Configurations/FeatureDefines.xcconfig:
1749
1750 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1751
1752         Make it possible to insert editable images with a gesture
1753         https://bugs.webkit.org/show_bug.cgi?id=191937
1754
1755         Reviewed by Wenson Hsieh.
1756
1757         * WebCoreSupport/WebEditorClient.mm:
1758         (undoNameForEditAction):
1759         Add a undo name.
1760
1761 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1762
1763         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1764         https://bugs.webkit.org/show_bug.cgi?id=191945
1765
1766         Reviewed by Anders Carlsson.
1767
1768         * WebCoreSupport/WebEditorClient.mm:
1769         (undoNameForEditAction):
1770
1771 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1772
1773         Enable drag and drop support for iOSMac
1774         https://bugs.webkit.org/show_bug.cgi?id=191818
1775         <rdar://problem/43907454>
1776
1777         Reviewed by Dean Jackson.
1778
1779         * Configurations/FeatureDefines.xcconfig:
1780
1781 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1782
1783         Address post-review feedback after r238438
1784         https://bugs.webkit.org/show_bug.cgi?id=191913
1785
1786         Reviewed by Ryosuke Niwa.
1787
1788         * WebView/WebFrame.mm:
1789         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1790         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1791         * WebView/WebView.mm:
1792         (-[WebView setSelectedDOMRange:affinity:]):
1793
1794 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1795
1796         Web Inspector: "Reload Web Inspector" button no longer partially works
1797         https://bugs.webkit.org/show_bug.cgi?id=191773
1798         <rdar://problem/46139932>
1799
1800         Reviewed by Devin Rousso.
1801
1802         * WebCoreSupport/WebInspectorClient.h:
1803         * WebCoreSupport/WebInspectorClient.mm:
1804         (WebInspectorFrontendClient::reopen):
1805
1806 2018-11-17  Devin Rousso  <drousso@apple.com>
1807
1808         Web Inspector: Network: add button to show system certificate dialog
1809         https://bugs.webkit.org/show_bug.cgi?id=191458
1810         <rdar://problem/45977019>
1811
1812         Reviewed by Joseph Pecoraro.
1813
1814         * WebCoreSupport/WebInspectorClient.h:
1815         * WebCoreSupport/WebInspectorClient.mm:
1816         (WebInspectorFrontendClient::showCertificate): Added.
1817
1818         * Configurations/WebKitLegacy.xcconfig:
1819
1820 2018-11-15  Truitt Savell  <tsavell@apple.com>
1821
1822         Unreviewed, rolling out r238244.
1823
1824         Caused High Sierra test runs to fail early with 50 crashes and
1825         casued 25 API failures.
1826
1827         Reverted changeset:
1828
1829         "[css-logical] Implement flow-relative margin, padding and
1830         border shorthands"
1831         https://bugs.webkit.org/show_bug.cgi?id=188697
1832         https://trac.webkit.org/changeset/238244
1833
1834 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1835
1836         [css-logical] Implement flow-relative margin, padding and border shorthands
1837         https://bugs.webkit.org/show_bug.cgi?id=188697
1838
1839         Reviewed by Simon Fraser and Antti Koivisto.
1840
1841         Add CSSLogicalEnabled runtime flag.
1842
1843         * WebView/WebPreferenceKeysPrivate.h:
1844         * WebView/WebPreferences.mm:
1845         (+[WebPreferences initialize]):
1846         (-[WebPreferences cssLogicalEnabled]):
1847         (-[WebPreferences setCSSLogicalEnabled:]):
1848         * WebView/WebPreferencesPrivate.h:
1849         * WebView/WebView.mm:
1850         (-[WebView _preferencesChanged:]):
1851
1852 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1853
1854         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1855         https://bugs.webkit.org/show_bug.cgi?id=191612
1856
1857         Reviewed by Matt Baker.
1858
1859         * WebCoreSupport/WebInspectorClient.mm:
1860         (-[WebInspectorWindowController destroyInspectorView]):
1861
1862 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1863
1864         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1865         https://bugs.webkit.org/show_bug.cgi?id=191494
1866         <rdar://problem/45469854>
1867
1868         Reviewed by Devin Rousso.
1869
1870         * WebCoreSupport/WebInspectorClient.h:
1871         WebKitLegacy will still have remote inspection of the Page directly.
1872
1873 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1874
1875         Make compositing updates incremental
1876         https://bugs.webkit.org/show_bug.cgi?id=90342
1877
1878         Reviewed by Antti Koivisto.
1879
1880         Fix spelling error.
1881
1882         * WebView/WebView.mm:
1883         (-[WebView _setMediaLayer:forPluginView:]):
1884
1885 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1886
1887         Implement a new edit command to change the enclosing list type
1888         https://bugs.webkit.org/show_bug.cgi?id=191487
1889         <rdar://problem/45955922>
1890
1891         Reviewed by Ryosuke Niwa.
1892
1893         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1894
1895         * WebCoreSupport/WebEditorClient.mm:
1896         (undoNameForEditAction):
1897
1898 2018-11-11  Daniel Bates  <dabates@apple.com>
1899
1900         [iOS] Draw caps lock indicator in password fields
1901         https://bugs.webkit.org/show_bug.cgi?id=190565
1902         <rdar://problem/45262343>
1903
1904         Reviewed by Dean Jackson.
1905
1906         Update the caps lock state when a hardware keyboard is attached or detached.
1907
1908         * WebView/WebHTMLView.mm:
1909         (hardwareKeyboardAvailabilityChangedCallback): Added.
1910         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1911         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1912
1913 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1914
1915         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1916         https://bugs.webkit.org/show_bug.cgi?id=191492
1917
1918         Reviewed by Alex Christensen.
1919
1920         * Carbon/HIWebView.mm:
1921         * Misc/WebNSFileManagerExtras.mm:
1922         * Misc/WebNSURLExtras.mm:
1923         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1924         * Plugins/WebBasePluginPackage.mm:
1925         * Plugins/WebPluginContainerCheck.mm:
1926         * WebCoreSupport/WebCachedFramePlatformData.h:
1927         * WebCoreSupport/WebDeviceOrientationClient.mm:
1928         * WebView/WebDelegateImplementationCaching.mm:
1929         * WebView/WebHTMLView.mm:
1930         * WebView/WebPDFRepresentation.mm:
1931         * WebView/WebPolicyDelegate.mm:
1932         * WebView/WebView.mm:
1933
1934 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1935
1936         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1937         https://bugs.webkit.org/show_bug.cgi?id=191492
1938
1939         Reviewed by Alex Christensen.
1940
1941         * Carbon/HIWebView.mm:
1942         (UpdateCommandStatus):
1943         * Misc/WebNSFileManagerExtras.mm:
1944         * Misc/WebNSURLExtras.mm:
1945         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1946         * Plugins/WebBasePluginPackage.mm:
1947         * Plugins/WebPluginContainerCheck.mm:
1948         (-[WebPluginContainerCheck _continueWithPolicy:]):
1949         * WebCoreSupport/WebCachedFramePlatformData.h:
1950         (WebCachedFramePlatformData::clear):
1951         * WebCoreSupport/WebDeviceOrientationClient.mm:
1952         (WebDeviceOrientationClient::getProvider const):
1953         * WebView/WebDelegateImplementationCaching.mm:
1954         (CallDelegate):
1955         (CallDelegateReturningBoolean):
1956         (CallResourceLoadDelegateReturningBoolean):
1957         (CallFormDelegate):
1958         (CallFormDelegateReturningBoolean):
1959         * WebView/WebHTMLView.mm:
1960         * WebView/WebPDFRepresentation.mm:
1961         * WebView/WebPolicyDelegate.mm:
1962         (-[WebPolicyDecisionListener _usePolicy:]):
1963         * WebView/WebView.mm:
1964
1965 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1966
1967         Unreviewed, rolling out r238047.
1968
1969         Introduced layout test failures on iOS simulator.
1970
1971         Reverted changeset:
1972
1973         "[iOS] Draw caps lock indicator in password fields"
1974         https://bugs.webkit.org/show_bug.cgi?id=190565
1975         https://trac.webkit.org/changeset/238047
1976
1977 2018-11-09  Antti Koivisto  <antti@apple.com>
1978
1979         Use OptionSet for layout milestones
1980         https://bugs.webkit.org/show_bug.cgi?id=191470
1981
1982         Reviewed by Dean Jackson.
1983
1984         * WebCoreSupport/WebFrameLoaderClient.h:
1985         * WebCoreSupport/WebFrameLoaderClient.mm:
1986         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1987         * WebView/WebView.mm:
1988         (coreLayoutMilestones):
1989         (kitLayoutMilestones):
1990         (-[WebView _cacheFrameLoadDelegateImplementations]):
1991         * WebView/WebViewInternal.h:
1992
1993 2018-11-09  Daniel Bates  <dabates@apple.com>
1994
1995         [iOS] Draw caps lock indicator in password fields
1996         https://bugs.webkit.org/show_bug.cgi?id=190565
1997         <rdar://problem/45262343>
1998
1999         Reviewed by Dean Jackson.
2000
2001         Update the caps lock state when a hardware keyboard is attached or detached.
2002
2003         * WebView/WebHTMLView.mm:
2004         (hardwareKeyboardAvailabilityChangedCallback): Added.
2005         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2006         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2007
2008 2018-11-09  Daniel Bates  <dabates@apple.com>
2009
2010         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
2011         action when forward delete is pressed outside a text field
2012         https://bugs.webkit.org/show_bug.cgi?id=190566
2013         <rdar://problem/45262367>
2014
2015         Reviewed by Wenson Hsieh.
2016
2017         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
2018         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
2019         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
2020
2021         * WebView/WebHTMLView.mm:
2022         (-[WebHTMLView _handleEditingKeyEvent:]):
2023
2024 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
2025
2026         Adopt Reveal Framework to replace Lookup
2027         https://bugs.webkit.org/show_bug.cgi?id=191097
2028         <rdar://problem/45924508>
2029
2030         Reviewed by Tim Horton.
2031
2032         Pass in what it needed to clear the textIndicators. This is better than
2033         the current notification structure.
2034
2035         * WebView/WebView.mm:
2036         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2037         (-[WebView _prepareForDictionaryLookup]):
2038
2039 2018-11-06  Justin Fan  <justin_fan@apple.com>
2040
2041         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2042         https://bugs.webkit.org/show_bug.cgi?id=191291
2043
2044         Reviewed by Myles Maxfield.
2045
2046         Properly disable WEBGPU on all non-Metal platforms for now.
2047
2048         * Configurations/FeatureDefines.xcconfig:
2049
2050 2018-11-02  Daniel Bates  <dabates@apple.com>
2051
2052         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2053         https://bugs.webkit.org/show_bug.cgi?id=190487
2054
2055         Reviewed by Tim Horton.
2056
2057         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
2058         allow the default handling.
2059
2060         * WebView/WebHTMLView.mm:
2061         (-[WebHTMLView _handleEditingKeyEvent:]):
2062
2063 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2064
2065         Add a storage limit for IndexedDB
2066         https://bugs.webkit.org/show_bug.cgi?id=190598
2067         <rdar://problem/44654715>
2068
2069         Reviewed by Chris Dumez.
2070
2071         * Storage/WebDatabaseManager.mm:
2072         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2073         * Storage/WebDatabaseManagerPrivate.h:
2074
2075 2018-10-31  Antti Koivisto  <antti@apple.com>
2076
2077         Remove LayerFlushScheduler
2078         https://bugs.webkit.org/show_bug.cgi?id=191103
2079
2080         Reviewed by Anders Carlsson.
2081
2082         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2083         all the virtual cruft.
2084
2085         * WebView/WebViewData.h:
2086         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2087         (): Deleted.
2088         * WebView/WebViewData.mm:
2089         (currentRunLoop):
2090         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2091         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2092         (WebViewLayerFlushScheduler::schedule):
2093         (WebViewLayerFlushScheduler::invalidate):
2094         (WebViewLayerFlushScheduler::layerFlushCallback):
2095
2096 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2097
2098         Enable InstallAPI for iOS unconditionally
2099         https://bugs.webkit.org/show_bug.cgi?id=191043
2100         rdar://problem/32728423
2101
2102         Reviewed by Dan Bernstein.
2103
2104         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2105         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2106         shouldn't be processed by InstallAPI.
2107         * MigrateHeaders.make: Removed an obsolete workaround.
2108         * Misc/NSURLDownloadSPI.h: Added.
2109         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2110
2111 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2112
2113         Clean up some obsolete MAX_ALLOWED macros
2114         https://bugs.webkit.org/show_bug.cgi?id=190916
2115
2116         Reviewed by Tim Horton.
2117
2118         * WebView/WebHTMLView.mm:
2119         (-[WebHTMLView pressureChangeWithEvent:]):
2120         * WebView/WebPDFView.h:
2121
2122 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2123
2124         Unreviewed, rolling out r237600 and r237604.
2125         https://bugs.webkit.org/show_bug.cgi?id=191086
2126
2127         Breaks internal iOS builds (Requested by ryanhadd_ on
2128         #webkit).
2129
2130         Reverted changesets:
2131
2132         "Enable InstallAPI for iOS unconditionally"
2133         https://bugs.webkit.org/show_bug.cgi?id=191043
2134         https://trac.webkit.org/changeset/237600
2135
2136         "Build fix attempt after enabling InstallAPI for iOS."
2137         https://bugs.webkit.org/show_bug.cgi?id=191043
2138         https://trac.webkit.org/changeset/237604
2139
2140 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2141
2142         Enable InstallAPI for iOS unconditionally
2143         https://bugs.webkit.org/show_bug.cgi?id=191043
2144         rdar://problem/32728423
2145
2146         Reviewed by Dan Bernstein.
2147
2148         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2149         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2150         shouldn't be processed by InstallAPI.
2151         * MigrateHeaders.make: Removed an obsolete workaround.
2152         * Misc/NSURLDownloadSPI.h: Added.
2153         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2154
2155 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2156
2157         Modernize WebKit nibs and lprojs for localization's sake
2158         https://bugs.webkit.org/show_bug.cgi?id=190911
2159         <rdar://problem/45349466>
2160
2161         Reviewed by Dan Bernstein.
2162
2163         * Misc/WebNSControlExtras.m:
2164         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2165         NSWindow and its contents are both in the same scale space these days; avoid
2166         double-applying the scale factor, or you can't see the prompt.
2167
2168         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2169         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2170         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2171         NIB->XIB
2172
2173 2018-10-25  Antoine Quint  <graouts@apple.com>
2174
2175         [Web Animations] Turn Web Animations CSS Integration off by default
2176         https://bugs.webkit.org/show_bug.cgi?id=190901
2177
2178         Reviewed by Dean Jackson.
2179
2180         * WebView/WebPreferences.mm:
2181         (+[WebPreferences initialize]):
2182
2183 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2184
2185         Clean up some obsolete macOS version guards
2186         https://bugs.webkit.org/show_bug.cgi?id=190887
2187
2188         Reviewed by Dan Bernstein.
2189
2190         * Misc/WebNSPasteboardExtras.mm:
2191         (+[NSPasteboard _web_dragTypesForURL]):
2192         * WebCoreSupport/PopupMenuMac.mm:
2193         (PopupMenuMac::show):
2194         * WebCoreSupport/WebEditorClient.h:
2195         * WebCoreSupport/WebEditorClient.mm:
2196         (WebEditorClient::respondToChangedSelection):
2197         * WebView/WebPDFView.mm:
2198         (-[WebPDFView _clipViewForPDFDocumentView]):
2199
2200 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2201
2202         Turn on Conic Gradients
2203         https://bugs.webkit.org/show_bug.cgi?id=190810
2204
2205         Reviewed by Tim Horton.
2206
2207         * Configurations/FeatureDefines.xcconfig:
2208
2209 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2210
2211         Cleanup: MIMETypeRegistry functions
2212         https://bugs.webkit.org/show_bug.cgi?id=190838
2213
2214         Reviewed by Simon Fraser.
2215
2216         * Misc/WebNSPasteboardExtras.mm:
2217         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2218         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2219         because they were identical.
2220
2221         * WebView/WebHTMLRepresentation.mm:
2222         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2223         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2224         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2225         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2226         * WebView/WebView.mm:
2227         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2228         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2229         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2230
2231 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2232
2233         Fix false positive leaks when using custom -init methods that don't start with -init
2234         <https://webkit.org/b/190818>
2235         <rdar://problem/45476042>
2236
2237         Reviewed by Dan Bernstein.
2238
2239         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2240         it is accessible by both categories.
2241         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2242         NSError (WebKitInternal) category.  Add attribute to make this
2243         behave like an -init method.
2244         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2245         NSError (WebKitInternal) category.  Modernize method.  Replace
2246         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2247
2248 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2249
2250         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2251         https://bugs.webkit.org/show_bug.cgi?id=190729
2252
2253         Reviewed by Tim Horton.
2254
2255         * DOM/DOM.mm:
2256         (-[DOMNode boundingBox]):
2257         * DOM/DOMElement.mm:
2258         * DOM/DOMHTML.mm:
2259         * DOM/DOMInternal.mm:
2260         * DOM/DOMUIKitExtensions.mm:
2261         * DOM/WebDOMOperations.mm:
2262         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2263         * DefaultDelegates/WebDefaultEditingDelegate.m:
2264         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2265         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2266         * DefaultDelegates/WebDefaultUIDelegate.h:
2267         * DefaultDelegates/WebDefaultUIDelegate.mm:
2268         (-[WebDefaultUIDelegate webViewClose:]):
2269         (-[WebDefaultUIDelegate webViewFocus:]):
2270         (-[WebDefaultUIDelegate webViewUnfocus:]):
2271         (-[WebDefaultUIDelegate webViewIsResizable:]):
2272         (-[WebDefaultUIDelegate webView:setResizable:]):
2273         (-[WebDefaultUIDelegate webView:setFrame:]):
2274         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2275         * History/BackForwardList.h:
2276         * History/BackForwardList.mm:
2277         * History/WebBackForwardList.mm:
2278         (+[WebBackForwardList initialize]):
2279         (bumperCarBackForwardHackNeeded):
2280         * History/WebHistory.mm:
2281         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2282         (-[WebHistory _sendNotification:entries:]):
2283         (-[WebHistory loadFromURL:error:]):
2284         (-[WebHistory saveToURL:error:]):
2285         * History/WebHistoryItem.mm:
2286         (WKNotifyHistoryItemChanged):
2287         (+[WebHistoryItem initialize]):
2288         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2289         * History/WebURLsWithTitles.m:
2290         * Misc/WebCache.mm:
2291         (+[WebCache initialize]):
2292         * Misc/WebDownload.mm:
2293         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2294         * Misc/WebElementDictionary.mm:
2295         (+[WebElementDictionary initialize]):
2296         (+[WebElementDictionary initializeLookupTable]):
2297         * Misc/WebIconDatabase.mm:
2298         * Misc/WebKitNSStringExtras.mm:
2299         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2300         * Misc/WebKitVersionChecks.h:
2301         * Misc/WebKitVersionChecks.mm:
2302         (WebKitLinkedOnOrAfter):
2303         (WebKitLinkTimeVersion):
2304         * Misc/WebLocalizableStrings.mm:
2305         * Misc/WebNSControlExtras.h:
2306         * Misc/WebNSControlExtras.m:
2307         * Misc/WebNSEventExtras.m:
2308         * Misc/WebNSFileManagerExtras.mm:
2309         * Misc/WebNSImageExtras.h:
2310         * Misc/WebNSImageExtras.m:
2311         * Misc/WebNSPasteboardExtras.mm:
2312         * Misc/WebNSPrintOperationExtras.h:
2313         * Misc/WebNSPrintOperationExtras.m:
2314         * Misc/WebNSViewExtras.m:
2315         * Misc/WebNSWindowExtras.m:
2316         * Panels/WebAuthenticationPanel.h:
2317         * Panels/WebAuthenticationPanel.m:
2318         * Panels/WebPanelAuthenticationHandler.m:
2319         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2320         (+[WebHostedNetscapePluginView initialize]):
2321         * Plugins/WebBasePluginPackage.h:
2322         * Plugins/WebBasePluginPackage.mm:
2323         * Plugins/WebJavaPlugIn.h:
2324         * Plugins/WebPluginContainerCheck.mm:
2325         * Plugins/WebPluginController.h:
2326         * Plugins/WebPluginController.mm:
2327         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2328         (-[WebPluginController addPlugin:]):
2329         (-[WebPluginController destroyPlugin:]):
2330         (-[WebPluginController destroyAllPlugins]):
2331         * Plugins/WebPluginDatabase.mm:
2332         (+[WebPluginDatabase _defaultPlugInPaths]):
2333         * Plugins/WebPluginPackage.mm:
2334         (-[WebPluginPackage initWithPath:]):
2335         * Storage/WebDatabaseManager.mm:
2336         (-[WebDatabaseManager deleteAllDatabases]):
2337         * Storage/WebDatabaseManagerClient.h:
2338         * Storage/WebDatabaseManagerClient.mm:
2339         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2340         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2341         * Storage/WebStorageManager.mm:
2342         (-[WebStorageManager deleteAllOrigins]):
2343         (WebKitInitializeStorageIfNecessary):
2344         * WebCoreSupport/WebAlternativeTextClient.h:
2345         * WebCoreSupport/WebApplicationCache.mm:
2346         (applicationCacheBundleIdentifier):
2347         * WebCoreSupport/WebChromeClient.h:
2348         * WebCoreSupport/WebChromeClient.mm:
2349         (WebChromeClient::setWindowRect):
2350         (WebChromeClient::windowRect):
2351         (WebChromeClient::takeFocus):
2352         (WebChromeClient::addMessageToConsole):
2353         (WebChromeClient::enableSuddenTermination):
2354         (WebChromeClient::disableSuddenTermination):
2355         (WebChromeClient::createPopupMenu const):
2356         (WebChromeClient::createSearchPopupMenu const):
2357         (WebChromeClient::shouldPaintEntireContents const):
2358         (WebChromeClient::supportsVideoFullscreen):
2359         (WebChromeClient::supportsFullScreenForElement):
2360         (WebChromeClient::enterFullScreenForElement):
2361         (WebChromeClient::exitFullScreenForElement):
2362         * WebCoreSupport/WebContextMenuClient.mm:
2363         * WebCoreSupport/WebDragClient.mm:
2364         * WebCoreSupport/WebEditorClient.h:
2365         * WebCoreSupport/WebEditorClient.mm:
2366         (+[WebUndoStep initialize]):
2367         (updateFontPanel):
2368         (WebEditorClient::didBeginEditing):
2369         (WebEditorClient::respondToChangedContents):
2370         (WebEditorClient::respondToChangedSelection):
2371         (WebEditorClient::canceledComposition):
2372         (WebEditorClient::didEndEditing):
2373         (WebEditorClient::didWriteSelectionToPasteboard):
2374         (attributesForAttributedStringConversion):
2375         (WebEditorClient::setInsertionPasteboard):
2376         (WebEditorClient::registerUndoOrRedoStep):
2377         (WebEditorClient::handleKeyboardEvent):
2378         (WebEditorClient::handleInputMethodKeydown):
2379         (WebEditorClient::textDidChangeInTextField):
2380         (WebEditorClient::requestCheckingOfString):
2381         * WebCoreSupport/WebFrameLoaderClient.h:
2382         * WebCoreSupport/WebFrameLoaderClient.mm:
2383         (WebFrameLoaderClient::detachedFromParent2):
2384         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2385         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2386         (WebFrameLoaderClient::dispatchWillSendRequest):
2387         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2388         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2389         (WebFrameLoaderClient::willCacheResponse const):
2390         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2391         (WebFrameLoaderClient::dispatchDidFinishLoading):
2392         (WebFrameLoaderClient::dispatchDidFailLoading):
2393         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2394         (WebFrameLoaderClient::dispatchWillClose):
2395         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2396         (WebFrameLoaderClient::dispatchDidCommitLoad):
2397         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2398         (WebFrameLoaderClient::dispatchDidFailLoad):
2399         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2400         (WebFrameLoaderClient::dispatchDidFinishLoad):
2401         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2402         (WebFrameLoaderClient::willChangeTitle):
2403         (WebFrameLoaderClient::didChangeTitle):
2404         (WebFrameLoaderClient::didReplaceMultipartContent):
2405         (WebFrameLoaderClient::updateGlobalHistory):
2406         (WebFrameLoaderClient::saveViewStateToItem):
2407         (WebFrameLoaderClient::restoreViewState):
2408         (WebFrameLoaderClient::provisionalLoadStarted):
2409         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2410         (WebFrameLoaderClient::setTitle):
2411         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2412         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2413         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2414         (WebFrameLoaderClient::didRestoreFromPageCache):
2415         (WebFrameLoaderClient::actionDictionary const):
2416         (WebFrameLoaderClient::createPlugin):
2417         (WebFrameLoaderClient::getLoadDecisionForIcons):
2418         (WebFrameLoaderClient::finishedLoadingIcon):
2419         (+[WebFramePolicyListener initialize]):
2420         * WebCoreSupport/WebFrameNetworkingContext.mm:
2421         * WebCoreSupport/WebGeolocationClient.h:
2422         * WebCoreSupport/WebGeolocationClient.mm:
2423         (WebGeolocationClient::requestPermission):
2424         * WebCoreSupport/WebInspectorClient.h:
2425         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2426         * WebCoreSupport/WebNotificationClient.mm:
2427         * WebCoreSupport/WebOpenPanelResultListener.mm:
2428         * WebCoreSupport/WebPlatformStrategies.h:
2429         * WebCoreSupport/WebPlatformStrategies.mm:
2430         * WebCoreSupport/WebProgressTrackerClient.h:
2431         * WebCoreSupport/WebProgressTrackerClient.mm:
2432         (WebProgressTrackerClient::progressStarted):
2433         (WebProgressTrackerClient::progressEstimateChanged):
2434         (WebProgressTrackerClient::progressFinished):
2435         * WebCoreSupport/WebSecurityOrigin.mm:
2436         * WebInspector/WebNodeHighlight.h:
2437         * WebInspector/WebNodeHighlight.mm:
2438         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2439         (-[WebNodeHighlight dealloc]):
2440         (-[WebNodeHighlight attach]):
2441         * WebInspector/WebNodeHighlightView.h:
2442         * WebInspector/WebNodeHighlightView.mm:
2443         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2444         (-[WebNodeHighlightView dealloc]):
2445         * WebInspector/WebNodeHighlighter.mm:
2446         (-[WebNodeHighlighter highlight]):
2447         * WebView/WebArchive.mm:
2448         (+[WebArchivePrivate initialize]):
2449         * WebView/WebClipView.h:
2450         * WebView/WebDataSource.mm:
2451         (WebDataSourcePrivate::WebDataSourcePrivate):
2452         (+[WebDataSource initialize]):
2453         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2454         (-[WebDataSource _makeRepresentation]):
2455         * WebView/WebDelegateImplementationCaching.h:
2456         * WebView/WebDelegateImplementationCaching.mm:
2457         (CallDelegate):
2458         (CallDelegateReturningFloat):
2459         (CallDelegateReturningBoolean):
2460         (CallUIDelegate):
2461         (CallUIDelegateReturningFloat):
2462         (CallUIDelegateReturningBoolean):
2463         (CallFrameLoadDelegate):
2464         (CallFrameLoadDelegateReturningBoolean):
2465         (CallResourceLoadDelegate):
2466         (CallScriptDebugDelegate):
2467         (CallFormDelegate):
2468         (CallFormDelegateReturningBoolean):
2469         * WebView/WebDeviceOrientation.mm:
2470         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2471         * WebView/WebDocumentInternal.h:
2472         * WebView/WebDocumentLoaderMac.mm:
2473         (needsDataLoadWorkaround):
2474         * WebView/WebDynamicScrollBarsViewInternal.h:
2475         * WebView/WebFormDelegate.m:
2476         * WebView/WebFrame.mm:
2477         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2478         (-[WebFrame _unmarkAllMisspellings]):
2479         (-[WebFrame _paintBehaviorForDestinationContext:]):
2480         (-[WebFrame _drawRect:contentsOnly:]):
2481         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2482         (-[WebFrame _scrollDOMRangeToVisible:]):
2483         (-[WebFrame _bodyBackgroundColor]):
2484         (-[WebFrame accessibilityRoot]):
2485         (needsMicrosoftMessengerDOMDocumentWorkaround):
2486         * WebView/WebFrameInternal.h:
2487         * WebView/WebFrameView.mm:
2488         (-[WebFrameView _setDocumentView:]):
2489         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2490         (-[WebFrameView _viewClassForMIMEType:]):
2491         (-[WebFrameView initWithFrame:]):
2492         (-[WebFrameView drawRect:]):
2493         (-[WebFrameView _firstResponderIsFormControl]):
2494         (-[WebFrameView keyDown:keyDown:]):
2495         (-[WebFrameView _isScrollable]):
2496         * WebView/WebFullScreenController.h:
2497         * WebView/WebFullScreenController.mm:
2498         * WebView/WebHTMLRepresentation.mm:
2499         * WebView/WebHTMLView.mm:
2500         (-[WebHTMLView hitTest:]):
2501         (-[WebHTMLView initWithFrame:]):
2502         (-[WebHTMLView dealloc]):
2503         (-[WebHTMLView addSubview:]):
2504         (-[WebHTMLView mouseDown:]):
2505         (-[WebHTMLView mouseUp:]):
2506         (-[WebHTMLView resignFirstResponder]):
2507         (-[WebHTMLView accessibilityHitTest:]):
2508         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2509         * WebView/WebHTMLViewInternal.h:
2510         * WebView/WebIndicateLayer.h:
2511         * WebView/WebIndicateLayer.mm:
2512         * WebView/WebMediaPlaybackTargetPicker.h:
2513         * WebView/WebMediaPlaybackTargetPicker.mm:
2514         * WebView/WebPDFDocumentExtras.h:
2515         * WebView/WebPDFDocumentExtras.mm:
2516         * WebView/WebPDFRepresentation.h:
2517         * WebView/WebPDFRepresentation.mm:
2518         * WebView/WebPDFView.h:
2519         * WebView/WebPreferences.mm:
2520         (cacheModelForMainBundle):
2521         (WebPreferencesPrivate::WebPreferencesPrivate):
2522         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2523         (-[WebPreferences encodeWithCoder:]):
2524         (+[WebPreferences standardPreferences]):
2525         (+[WebPreferences initialize]):
2526         (-[WebPreferences _valueForKey:]):
2527         (-[WebPreferences _setStringValue:forKey:]):
2528         (-[WebPreferences _setIntegerValue:forKey:]):
2529         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2530         (-[WebPreferences _setFloatValue:forKey:]):
2531         (-[WebPreferences _setBoolValue:forKey:]):
2532         (-[WebPreferences _setLongLongValue:forKey:]):
2533         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2534         (-[WebPreferences _postCacheModelChangedNotification]):
2535         (-[WebPreferences _postPreferencesChangedNotification]):
2536         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2537         (-[WebPreferences setStorageBlockingPolicy:]):
2538         * WebView/WebResource.mm:
2539         (+[WebResourcePrivate initialize]):
2540         * WebView/WebTextCompletionController.h:
2541         * WebView/WebTextIterator.mm:
2542         (+[WebTextIteratorPrivate initialize]):
2543         * WebView/WebView.mm:
2544         (shouldEnableLoadDeferring):
2545         (shouldRestrictWindowFocus):
2546         (shouldRespectPriorityInCSSAttributeSetters):
2547         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2548         (shouldAllowPictureInPictureMediaPlayback):
2549         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2550         (shouldAllowWindowOpenWithoutUserGesture):
2551         (shouldConvertInvalidURLsToBlank):
2552         (shouldRequireUserGestureToLoadVideo):
2553         (-[WebView _commonInitializationWithFrameName:groupName:]):
2554         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2555         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2556         (-[WebView _closePluginDatabases]):
2557         (-[WebView _closeWithFastTeardown]):
2558         (-[WebView _close]):
2559         (+[WebView _MIMETypeForFile:]):
2560         (-[WebView setShowingInspectorIndication:]):
2561         (-[WebView _setFormDelegate:]):
2562         (-[WebView _needsPreHTML5ParserQuirks]):
2563         (-[WebView _preferencesChangedNotification:]):
2564         (-[WebView _preferencesChanged:]):
2565         (-[WebView _cacheResourceLoadDelegateImplementations]):
2566         (-[WebView _cacheFrameLoadDelegateImplementations]):
2567         (-[WebView _policyDelegateForwarder]):
2568         (-[WebView _UIDelegateForwarder]):
2569         (-[WebView _editingDelegateForwarder]):
2570         (-[WebView _updateActiveState]):
2571         (-[_WebSafeForwarder forwardInvocation:]):
2572         (+[WebView initialize]):
2573         (-[WebView _pluginForMIMEType:]):
2574         (-[WebView _pluginForExtension:]):
2575         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2576         (+[WebView canShowMIMETypeAsHTML:]):
2577         (-[WebView _initWithArguments:]):
2578         (-[WebView initWithFrame:frameName:groupName:]):
2579         (-[WebView dealloc]):
2580         (-[WebView close]):
2581         (-[WebView viewDidMoveToWindow]):
2582         (-[WebView setUIDelegate:]):
2583         (-[WebView setResourceLoadDelegate:]):
2584         (-[WebView setPolicyDelegate:]):
2585         (-[WebView setFrameLoadDelegate:]):
2586         (-[WebView goBack]):
2587         (-[WebView goForward]):
2588         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2589         (-[WebView setHostWindow:]):
2590         (-[WebView becomeFirstResponder]):
2591         (+[WebView _cacheModelChangedNotification:]):
2592         (-[WebView _frameViewAtWindowPoint:]):
2593         (+[WebView _preflightSpellCheckerNow:]):
2594         (+[WebView _preflightSpellChecker]):
2595         (-[WebView canGoBack]):
2596         (-[WebView canGoForward]):
2597         (-[WebView stopLoading:]):
2598         (-[WebView reload:]):
2599         (-[WebView setMainFrameDocumentReady:]):
2600         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2601         (-[WebView setContinuousSpellCheckingEnabled:]):
2602         (-[WebView undoManager]):
2603         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2604         (-[WebView isAutomaticLinkDetectionEnabled]):
2605         (-[WebView isAutomaticDashSubstitutionEnabled]):
2606         (-[WebView isAutomaticTextReplacementEnabled]):
2607         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2608         (+[WebView _setCacheModel:]):
2609         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2610         (-[WebView _keyboardUIMode]):
2611         (LayerFlushController::flushLayers):
2612         (-[WebView _scheduleCompositingLayerFlush]):
2613         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2614         (-[WebView fullScreenPlaceholderView]):
2615         (WebInstallMemoryPressureHandler):
2616         * WebView/WebViewData.h:
2617         * WebView/WebViewData.mm:
2618         (+[WebViewPrivate initialize]):
2619         (-[WebViewPrivate init]):
2620         (-[WebViewPrivate dealloc]):
2621         * WebView/WebViewInternal.h:
2622
2623 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2624
2625         Clean up FrameLoader two-state enums
2626         https://bugs.webkit.org/show_bug.cgi?id=190731
2627
2628         Reviewed by Chris Dumez.
2629
2630         * WebCoreSupport/WebFrameLoaderClient.h:
2631         * WebCoreSupport/WebFrameLoaderClient.mm:
2632         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2633
2634 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2635
2636         Unreviewed, rolling out r237137.
2637
2638         SPI is actually used
2639
2640         Reverted changeset:
2641
2642         "Remove unused WebFrame._loadType"
2643         https://bugs.webkit.org/show_bug.cgi?id=190583
2644         https://trac.webkit.org/changeset/237137
2645
2646 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2647
2648         Enable the datalist element by default on iOS and macOS
2649         https://bugs.webkit.org/show_bug.cgi?id=190594
2650         <rdar://problem/45281159>
2651
2652         Reviewed by Ryosuke Niwa and Tim Horton.
2653
2654         * Configurations/FeatureDefines.xcconfig:
2655
2656 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2657
2658         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2659         https://bugs.webkit.org/show_bug.cgi?id=190675
2660
2661         Reviewed by Chris Dumez.
2662
2663         * History/BackForwardList.h:
2664         * History/BackForwardList.mm:
2665         (BackForwardList::backItem):
2666         (BackForwardList::currentItem):
2667         (BackForwardList::forwardItem):
2668         (BackForwardList::backListCount const):
2669         (BackForwardList::forwardListCount const):
2670         (BackForwardList::itemAtIndex):
2671         * History/WebBackForwardList.mm:
2672         (-[WebBackForwardList backItem]):
2673         (-[WebBackForwardList currentItem]):
2674         (-[WebBackForwardList forwardItem]):
2675         (-[WebBackForwardList itemAtIndex:]):
2676
2677 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2678
2679         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2680         https://bugs.webkit.org/show_bug.cgi?id=190526
2681         rdar://problem/45230140
2682
2683         Reviewed by Dean Jackson.
2684
2685         * WebCoreSupport/WebEditorClient.mm:
2686         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2687
2688 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2689
2690         Implement feature flag and bindings for CSS Painting API
2691         https://bugs.webkit.org/show_bug.cgi?id=190237
2692
2693         Reviewed by Ryosuke Niwa.
2694
2695         * Configurations/FeatureDefines.xcconfig:
2696
2697 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2698
2699         Replace HistoryItem* with HistoryItem& where possible
2700         https://bugs.webkit.org/show_bug.cgi?id=190617
2701
2702         Reviewed by Chris Dumez.
2703
2704         * History/BackForwardList.h:
2705         * History/BackForwardList.mm:
2706         (BackForwardList::goToItem):
2707         * History/WebBackForwardList.mm:
2708         (-[WebBackForwardList goToItem:]):
2709         * History/WebHistoryItem.mm:
2710         (WKNotifyHistoryItemChanged):
2711         * History/WebHistoryItemInternal.h:
2712
2713 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2714
2715         Remove unused WebHistoryItem._transientPropertyForKey
2716         https://bugs.webkit.org/show_bug.cgi?id=190606
2717
2718         Reviewed by Chris Dumez.
2719
2720         * History/WebHistoryItem.mm:
2721         * History/WebHistoryItemPrivate.h:
2722
2723 2018-10-15  Justin Fan  <justin_fan@apple.com>
2724
2725         Add WebGPU 2018 feature flag and experimental feature flag
2726         https://bugs.webkit.org/show_bug.cgi?id=190509
2727
2728         Reviewed by Dean Jackson.
2729
2730         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2731         for the 2018 WebGPU prototype.
2732
2733         * Configurations/FeatureDefines.xcconfig:
2734         * WebView/WebPreferenceKeysPrivate.h:
2735         * WebView/WebPreferences.mm:
2736         (+[WebPreferences initialize]):
2737         (-[WebPreferences webGPUEnabled]):
2738         (-[WebPreferences setWebGPUEnabled:]):
2739         * WebView/WebPreferencesPrivate.h:
2740         * WebView/WebView.mm:
2741         (-[WebView _preferencesChanged:]):
2742
2743 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2744
2745         Fix iOS build after r237157
2746
2747         * WebView/WebView.mm:
2748         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2749
2750 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2751
2752         Modernize BackForwardClient.h
2753         https://bugs.webkit.org/show_bug.cgi?id=190610
2754
2755         Reviewed by Chris Dumez.
2756
2757         * History/BackForwardList.h:
2758         * History/BackForwardList.mm:
2759         (BackForwardList::backListCount const):
2760         (BackForwardList::forwardListCount const):
2761         (BackForwardList::backListCount): Deleted.
2762         (BackForwardList::forwardListCount): Deleted.
2763         * History/WebBackForwardList.mm:
2764         (-[WebBackForwardList init]):
2765         * WebCoreSupport/WebFrameLoaderClient.mm:
2766         (WebFrameLoaderClient::canCachePage const):
2767         * WebView/WebFrameView.mm:
2768         (-[WebFrameView keyDown:keyDown:]):
2769         * WebView/WebView.mm:
2770         (-[WebView _commonInitializationWithFrameName:groupName:]):
2771         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2772         (-[WebView _loadBackForwardListFromOtherView:]):
2773         (-[WebView initWithCoder:]):
2774         (-[WebView encodeWithCoder:]):
2775         (-[WebView backForwardList]):
2776         (-[WebView setMaintainsBackForwardList:]):
2777
2778 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2779
2780         Add support for prefers-color-scheme media query
2781         https://bugs.webkit.org/show_bug.cgi?id=190499
2782         rdar://problem/45212025
2783
2784         Reviewed by Dean Jackson.
2785
2786         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2787
2788 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2789
2790         Remove unused WebView._globalHistoryItem
2791         https://bugs.webkit.org/show_bug.cgi?id=190601
2792
2793         Reviewed by Chris Dumez.
2794
2795         * WebCoreSupport/WebFrameLoaderClient.h:
2796         * WebCoreSupport/WebFrameLoaderClient.mm:
2797         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2798         * WebView/WebView.mm:
2799         (-[WebView _globalHistoryItem]): Deleted.
2800         (-[WebView _setGlobalHistoryItem:]): Deleted.
2801         * WebView/WebViewData.h:
2802         * WebView/WebViewInternal.h:
2803         * WebView/WebViewPrivate.h:
2804
2805 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2806
2807         Remove unused parameters from FrameLoaderClient::createFrame
2808         https://bugs.webkit.org/show_bug.cgi?id=190587
2809
2810         Reviewed by Chris Dumez.
2811
2812         * WebCoreSupport/WebFrameLoaderClient.h:
2813         * WebCoreSupport/WebFrameLoaderClient.mm:
2814         (WebFrameLoaderClient::createFrame):
2815
2816 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2817
2818         Remove unused WebFrame._loadType
2819         https://bugs.webkit.org/show_bug.cgi?id=190583
2820
2821         Reviewed by Chris Dumez.
2822
2823         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2824
2825         * WebView/WebFrame.mm:
2826         (toWebFrameLoadType): Deleted.
2827         (-[WebFrame _loadType]): Deleted.
2828         * WebView/WebFramePrivate.h:
2829
2830 2018-10-15  Chris Dumez  <cdumez@apple.com>
2831
2832         Restrict browsing context lookup by name to frames that are related to one another
2833         https://bugs.webkit.org/show_bug.cgi?id=190475
2834
2835         Reviewed by Alex Christensen.
2836
2837         * WebView/WebFrame.mm:
2838         (-[WebFrame findFrameNamed:]):
2839
2840 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2841
2842         Remove InjectedBundle processing of back/forward lists
2843         https://bugs.webkit.org/show_bug.cgi?id=190459
2844
2845         Reviewed by Chris Dumez.
2846
2847         * WebCoreSupport/WebFrameLoaderClient.h:
2848         * WebCoreSupport/WebFrameLoaderClient.mm:
2849         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2850
2851 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2852
2853         [JSC] Remove Option::useAsyncIterator
2854         https://bugs.webkit.org/show_bug.cgi?id=190567
2855
2856         Reviewed by Saam Barati.
2857
2858         * Configurations/FeatureDefines.xcconfig:
2859
2860 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2861
2862         Allow encoding of small enum classes
2863         https://bugs.webkit.org/show_bug.cgi?id=190531
2864
2865         Reviewed by Tim Horton.
2866
2867         * WebCoreSupport/WebFrameLoaderClient.mm:
2868         (-[WebFramePolicyListener dealloc]):
2869
2870 2018-10-11  Keith Rollin  <krollin@apple.com>
2871
2872         CURRENT_ARCH should not be used in Run Script phase.
2873         https://bugs.webkit.org/show_bug.cgi?id=190407
2874         <rdar://problem/45133556>
2875
2876         Reviewed by Alexey Proskuryakov.
2877
2878         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2879         CURRENT_ARCH is not well-defined during this phase (and may even have
2880         the value "undefined") since this phase is run just once per build
2881         rather than once per supported architecture. Migrate away from
2882         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2883         performing an operation for each value, or by picking the first entry
2884         in ARCHS and using that as a representative value.
2885
2886         * Configurations/WebKitLegacy.xcconfig: When generating
2887         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2888         macosx platforms.
2889
2890         * MigrateHeaders.make:
2891         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2892         generate one for each architecture in ARCHS.
2893
2894 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2895
2896         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2897         https://bugs.webkit.org/show_bug.cgi?id=190429
2898
2899         Reviewed by Saam Barati.
2900
2901         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2902
2903         * WebView/WebPDFRepresentation.mm:
2904         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2905
2906 2018-10-08  Justin Fan  <justin_fan@apple.com>
2907
2908         WebGPU: Rename old WebGPU prototype to WebMetal
2909         https://bugs.webkit.org/show_bug.cgi?id=190325
2910         <rdar://problem/44990443>
2911
2912         Reviewed by Dean Jackson.
2913
2914         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2915
2916         * Configurations/FeatureDefines.xcconfig:
2917         * WebView/WebPreferenceKeysPrivate.h:
2918         * WebView/WebPreferences.mm:
2919         (+[WebPreferences initialize]):
2920         (-[WebPreferences webMetalEnabled]):
2921         (-[WebPreferences setWebMetalEnabled:]):
2922         (-[WebPreferences webGPUEnabled]): Deleted.
2923         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2924         * WebView/WebPreferencesPrivate.h:
2925         * WebView/WebView.mm:
2926         (-[WebView _preferencesChanged:]):
2927
2928 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2929
2930         Make <input type=color> a runtime enabled (on-by-default) feature
2931         https://bugs.webkit.org/show_bug.cgi?id=189162
2932
2933         Reviewed by Wenson Hsieh and Tim Horton.
2934
2935         * Configurations/FeatureDefines.xcconfig:
2936
2937 2018-10-07  Dan Bernstein  <mitz@apple.com>
2938
2939         Fixed building with the latest macOS SDK
2940
2941         * Plugins/WebNetscapePluginPackage.mm:
2942         (-[WebNetscapePluginPackage openResourceFile]):
2943         (-[WebNetscapePluginPackage closeResourceFile:]):
2944
2945 2018-10-04  Dan Bernstein  <mitz@apple.com>
2946
2947         More Carbon build-fixing.
2948
2949         * Carbon/CarbonWindowAdapter.mm:
2950         (-[CarbonWindowAdapter _destroyRealWindow:]):
2951         (-[CarbonWindowAdapter _growBoxRect]):
2952
2953 2018-10-04  Dan Bernstein  <mitz@apple.com>
2954
2955         Retried to fix 32-bit macOS builds after r236846.
2956
2957         * WebView/WebHTMLView.mm:
2958         (-[WebHTMLView setMarkedText:selectedRange:]):
2959
2960 2018-10-04  Dan Bernstein  <mitz@apple.com>
2961
2962         Retried to fix 32-bit macOS builds after r236846.
2963
2964         * Carbon/HIWebView.mm:
2965         (ActiveStateChanged):
2966
2967 2018-10-04  Dan Bernstein  <mitz@apple.com>
2968
2969         Tried to fix 32-bit macOS builds after r236846.
2970
2971         * Carbon/HIWebView.mm:
2972         (_NSSelectorForHICommand):
2973
2974 2018-10-04  Dan Bernstein  <mitz@apple.com>
2975
2976         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2977         https://bugs.webkit.org/show_bug.cgi?id=190250
2978
2979         Reviewed by Andy Estes.
2980
2981         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2982           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2983           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2984           an earlier line set it to YES.
2985
2986         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2987         changes below.
2988
2989         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2990           provides some missing method declarations.
2991
2992         * Misc/WebDownload.mm:
2993         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2994           a deprecated method.
2995
2996         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2997
2998         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2999           other code in the file uses a method from it.
3000
3001         * Plugins/WebBaseNetscapePluginView.mm:
3002         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
3003           a deprecated method.
3004
3005         * Plugins/WebPluginController.mm:
3006         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
3007           around use of a selector that may be present in some WebKit client.
3008
3009         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
3010           method declarations.
3011
3012         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
3013           from here.
3014
3015         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
3016           missing method declarations.
3017
3018         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
3019           from here.
3020
3021         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
3022           call from here.
3023         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
3024           an obsolete delegate method for binary compatibility.
3025         (pluginView): Ditto.
3026
3027         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
3028           call from here.
3029
3030         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
3031           WebDeviceOrientationProviderMock protocol.
3032
3033         * WebView/WebDeviceOrientationProviderMock.mm:
3034         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
3035           main @implementation.
3036
3037         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
3038           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
3039
3040         * WebView/WebDynamicScrollBarsView.mm:
3041         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
3042           of a deprecated method.
3043
3044         * WebView/WebHTMLView.mm:
3045         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
3046           selector warning around action methods that are not declared anywhere in WebKit.
3047
3048         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
3049           about implementing this deprecated method.
3050         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
3051         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3052         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3053         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3054         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3055         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3056         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3057         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3058         (-[WebHTMLView doCommandBySelector:]): Ditto.
3059         (-[WebHTMLView insertText:]): Ditto.
3060
3061         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
3062
3063         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
3064
3065         * WebView/WebPDFView.h: Removed previewView ivar.
3066
3067         * WebView/WebPDFView.mm:
3068           Removed declaration of FileInternal category and merged its implementation with the main
3069           implementation.
3070         (-[WebPDFView dealloc]): Removed previewView ivar.
3071         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
3072           exist in macOS versions we support.
3073         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
3074         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
3075           action methods internal to PDFKit.
3076         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
3077         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
3078
3079         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
3080           call on macOS, even though in r86988 we started calling different methods on iOS.
3081
3082         * WebView/WebView.mm:
3083         - Imported headers that declare delegate methods that we call.
3084         - Removed declaration of WebFileInternal category and merged its implementation with the
3085           main implementation.
3086         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
3087           category, which made them impossible to call from the main implementation. Moved those
3088           into the main implementation. One of those had to be declared in a class extension,
3089           because it is called from a method implemented in the WebPrivate category, and that
3090           category’s implementation appears first in the file.
3091
3092         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
3093           around use of obsolete delegate method for binary compatibility.
3094
3095         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
3096
3097 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3098
3099         Runtime flag and IDL for MediaRecorder
3100         https://bugs.webkit.org/show_bug.cgi?id=190018
3101
3102         Reviewed by Youenn Fablet and Chris Dumez.
3103
3104         * WebView/WebPreferenceKeysPrivate.h:
3105         * WebView/WebPreferences.mm:
3106         (+[WebPreferences initialize]):
3107         (-[WebPreferences mediaRecorderEnabled]):
3108         (-[WebPreferences setMediaRecorderEnabled:]):
3109         * WebView/WebPreferencesPrivate.h:
3110         * WebView/WebView.mm:
3111         (-[WebView _preferencesChanged:]):
3112
3113 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3114
3115         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3116         https://bugs.webkit.org/show_bug.cgi?id=190238
3117
3118         Reviewed by Antti Koivisto.
3119
3120         Enabled the feature by default.
3121
3122         * WebView/WebPreferences.mm:
3123         (+[WebPreferences initialize]):
3124
3125 2018-10-01  Dean Jackson  <dino@apple.com>
3126
3127         [macOS] Switching to discrete GPU should be done in the UI process
3128         https://bugs.webkit.org/show_bug.cgi?id=189361
3129         <rdar://problem/43949622>
3130
3131         Reviewed by Simon Fraser.
3132
3133         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
3134         not support swapping to the discrete GPU in this configuration.
3135
3136         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
3137         (WebKit::WebSwitchingGPUClient::singleton):
3138         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
3139         * WebView/WebView.mm:
3140         (-[WebView _commonInitializationWithFrameName:groupName:]):
3141
3142 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3143
3144         Remove ParsedURLString
3145         https://bugs.webkit.org/show_bug.cgi?id=190154
3146
3147         Reviewed by Chris Dumez.
3148
3149         * WebView/WebScriptDebugger.mm:
3150         (toNSURL):
3151
3152 2018-10-01  Dean Jackson  <dino@apple.com>
3153
3154         Remove CSS Animation Triggers
3155         https://bugs.webkit.org/show_bug.cgi?id=190175
3156         <rdar://problem/44925626>
3157
3158         Reviewed by Simon Fraser.
3159
3160         * Configurations/FeatureDefines.xcconfig:
3161
3162 2018-10-02  Commit Queue  <commit-queue@webkit.org>
3163
3164         Unreviewed, rolling out r236624 and r236671.
3165         https://bugs.webkit.org/show_bug.cgi?id=190207
3166
3167         The change in r236624 introduced crashes on the bots
3168         (Requested by ryanhaddad on #webkit).
3169
3170         Reverted changesets:
3171
3172         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3173         https://bugs.webkit.org/show_bug.cgi?id=188747
3174         https://trac.webkit.org/changeset/236624
3175
3176         "Unify implementation in VideoFullscreenInterfaceAVKit"
3177         https://bugs.webkit.org/show_bug.cgi?id=190091
3178         https://trac.webkit.org/changeset/236671
3179
3180 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3181
3182         URL should not use TextEncoding internally
3183         https://bugs.webkit.org/show_bug.cgi?id=190111
3184
3185         Reviewed by Andy Estes.
3186
3187         * Misc/WebNSURLExtras.mm:
3188
3189 2018-09-28  Jer Noble  <jer.noble@apple.com>
3190
3191         Refactoring: eliminate raw pointer usage in Fullscreen code
3192         https://bugs.webkit.org/show_bug.cgi?id=188747
3193         <rdar://problem/43541164>
3194
3195         Reviewed by Alex Christensen.
3196
3197         PlaybackSessionInterface no longer has an invalidate() method.
3198
3199         * WebView/WebView.mm:
3200         (-[WebView _clearPlaybackControlsManager]):
3201
3202 2018-09-28  Chris Dumez  <cdumez@apple.com>
3203
3204         Drop support for cross-origin-window-policy header
3205         https://bugs.webkit.org/show_bug.cgi?id=190081
3206
3207         Reviewed by Ryosuke Niwa.
3208
3209         * WebView/WebPreferenceKeysPrivate.h:
3210         * WebView/WebPreferences.mm:
3211         (+[WebPreferences initialize]):
3212         * WebView/WebPreferencesPrivate.h:
3213         * WebView/WebView.mm:
3214         (-[WebView _preferencesChanged:]):
3215
3216 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3217
3218         Rename createMarkup to serializePreservingVisualAppearance
3219         https://bugs.webkit.org/show_bug.cgi?id=190086
3220
3221         Reviewed by Wenson Hsieh.
3222
3223         * DOM/WebDOMOperations.mm:
3224         (-[DOMRange markupString]):
3225
3226 2018-09-28  Commit Queue  <commit-queue@webkit.org>
3227
3228         Unreviewed, rolling out r236605.
3229         https://bugs.webkit.org/show_bug.cgi?id=190087
3230
3231         caused three API test timeouts (Requested by jernoble on
3232         #webkit).
3233
3234         Reverted changeset:
3235
3236         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3237         https://bugs.webkit.org/show_bug.cgi?id=188747
3238         https://trac.webkit.org/changeset/236605
3239
3240 2018-09-28  Jer Noble  <jer.noble@apple.com>
3241
3242         Refactoring: eliminate raw pointer usage in Fullscreen code
3243         https://bugs.webkit.org/show_bug.cgi?id=188747
3244         <rdar://problem/43541164>
3245
3246         Reviewed by Alex Christensen.
3247
3248         PlaybackSessionInterface no longer has an invalidate() method.
3249
3250         * WebView/WebView.mm:
3251         (-[WebView _clearPlaybackControlsManager]):
3252
3253 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3254
3255         Use enum class in createMarkup arguments
3256         https://bugs.webkit.org/show_bug.cgi?id=190028
3257
3258         Reviewed by Wenson Hsieh.
3259
3260         * DOM/WebDOMOperations.mm:
3261         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
3262         (-[DOMRange markupString]): Ditto.
3263
3264 2018-09-27  Antoine Quint  <graouts@apple.com>
3265
3266         [Web Animations] Turn Web Animations with CSS integration on
3267         https://bugs.webkit.org/show_bug.cgi?id=184819
3268         <rdar://problem/39597337>
3269
3270         Reviewed by Dean Jackson.
3271
3272         * WebView/WebPreferences.mm:
3273         (+[WebPreferences initialize]):
3274
3275 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3276
3277         Selection should work across shadow boundary when initiated by a mouse drag
3278         https://bugs.webkit.org/show_bug.cgi?id=151380
3279         <rdar://problem/24363872>
3280
3281         Reviewed by Wenson Hsieh.
3282
3283         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
3284
3285         * WebView/WebPreferenceKeysPrivate.h:
3286         * WebView/WebPreferences.mm:
3287         (+[WebPreferences initialize]):
3288         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
3289         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
3290         * WebView/WebPreferencesPrivate.h:
3291         * WebView/WebView.mm:
3292         (-[WebView _preferencesChanged:]):
3293
3294 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3295
3296         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3297         https://bugs.webkit.org/show_bug.cgi?id=189918
3298         Work towards <rdar://problem/44648705>
3299
3300         Reviewed by Tim Horton.
3301
3302         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3303
3304         * WebView/WebHTMLView.mm:
3305         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3306         (-[WebHTMLView _updateFontPanel]):
3307         * WebView/WebView.mm:
3308         (-[WebView typingAttributes]):
3309
3310 2018-09-17  Darin Adler  <darin@apple.com>
3311
3312         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3313         https://bugs.webkit.org/show_bug.cgi?id=189652
3314
3315         Reviewed by Saam Barati.
3316
3317         * WebView/WebPDFRepresentation.mm:
3318         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3319
3320 2018-09-14  Jer Noble  <jer.noble@apple.com>
3321
3322         Turn SourceBufferChangeTypeEnabled on by default
3323         https://bugs.webkit.org/show_bug.cgi?id=189527
3324
3325         Reviewed by Eric Carlson.
3326
3327         * WebView/WebPreferences.mm:
3328         (+[WebPreferences initialize]):
3329
3330 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3331
3332         Fix an internal build after r235935
3333         https://bugs.webkit.org/show_bug.cgi?id=188996
3334
3335         * Carbon/HIWebView.mm:
3336         (Draw):
3337         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3338
3339 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3340
3341         Add IGNORE_WARNING_.* macros
3342         https://bugs.webkit.org/show_bug.cgi?id=188996
3343
3344         Reviewed by Michael Catanzaro.
3345
3346         * Carbon/CarbonUtils.m:
3347         (PoolCleaner):
3348         * Carbon/CarbonWindowAdapter.mm:
3349         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3350         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3351         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3352         (-[CarbonWindowAdapter _termWindowIfOwner]):
3353         (-[CarbonWindowAdapter _windowMovedToRect:]):
3354         (-[CarbonWindowAdapter setContentView:]):
3355         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3356         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3357         * Carbon/CarbonWindowFrame.m:
3358         (-[CarbonWindowFrame title]):
3359         * Carbon/HIViewAdapter.m:
3360         (+[HIViewAdapter getHIViewForNSView:]):
3361         * Carbon/HIWebView.mm:
3362         (overrideCGContext):
3363         (restoreCGContext):
3364         (Draw):
3365         * DOM/DOM.mm:
3366         * History/WebHistory.mm:
3367         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3368         * History/WebHistoryItem.mm:
3369         (-[WebHistoryItem icon]):
3370         * Misc/WebKitNSStringExtras.mm:
3371         (-[NSString _web_drawAtPoint:font:textColor:]):
3372         * Misc/WebNSImageExtras.m:
3373         (-[NSImage _web_scaleToMaxSize:]):
3374         (-[NSImage _web_dissolveToFraction:]):
3375         * Misc/WebNSPasteboardExtras.mm:
3376         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3377         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3378         * Panels/WebAuthenticationPanel.m:
3379         (-[WebAuthenticationPanel loadNib]):
3380         * Plugins/Hosted/NetscapePluginHostManager.mm:
3381         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3382         (WebKit::NetscapePluginHostManager::didCreateWindow):
3383         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3384         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3385         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3386         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3387         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3388         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3389         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3390         (-[WebHostedNetscapePluginView drawRect:]):
3391         * Plugins/Hosted/WebTextInputWindowController.m:
3392         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3393         * Plugins/WebBaseNetscapePluginView.mm:
3394         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3395         * Plugins/WebNetscapePluginPackage.mm:
3396         (-[WebNetscapePluginPackage _tryLoad]):
3397         * Plugins/WebNetscapePluginView.mm:
3398         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3399         (-[WebNetscapePluginView sendDrawRectEvent:]):
3400         (-[WebNetscapePluginView drawRect:]):
3401         * Plugins/WebPluginController.mm:
3402         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3403         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3404         * WebCoreSupport/PopupMenuMac.mm:
3405         (PopupMenuMac::populate):
3406         * WebCoreSupport/WebAlternativeTextClient.h:
3407         * WebCoreSupport/WebDragClient.mm:
3408         (WebDragClient::startDrag):
3409         * WebCoreSupport/WebFrameLoaderClient.mm:
3410         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3411         (webGetNSImage):
3412         * WebInspector/WebNodeHighlight.mm:
3413         * WebInspector/WebNodeHighlightView.mm:
3414         (-[WebNodeHighlightView drawRect:]):
3415         * WebView/WebClipView.mm:
3416         (-[WebClipView initWithFrame:]):
3417         * WebView/WebFrame.mm:
3418         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3419         (-[WebFrame _drawRect:contentsOnly:]):
3420         (-[WebFrame accessibilityRoot]):
3421         * WebView/WebFullScreenController.mm:
3422         (-[WebFullScreenController enterFullScreen:]):
3423         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3424         (-[WebFullScreenController exitFullScreen]):
3425         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3426         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3427         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3428         * WebView/WebHTMLView.mm:
3429         (-[NSWindow _web_borderView]):
3430         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3431         (-[WebHTMLView _setAsideSubviews]):
3432         (-[WebHTMLView _autoscroll]):
3433         (-[WebHTMLView drawRect:]):
3434         (-[WebHTMLView mouseDown:]):
3435         (-[WebHTMLView mouseDragged:]):
3436         (-[WebHTMLView mouseUp:]):
3437         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3438         (-[WebHTMLView knowsPageRange:]):
3439         (-[WebHTMLView accessibilityHitTest:]):
3440         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3441         (-[WebHTMLView _colorAsString:]):
3442         (-[WebHTMLView copyFont:]):
3443         (-[WebHTMLView _executeSavedKeypressCommands]):
3444         (-[WebHTMLView attachRootLayer:]):
3445         (-[WebHTMLView textStorage]):
3446         (-[WebHTMLView _updateSelectionForInputManager]):
3447         * WebView/WebPDFView.mm:
3448         (_applicationInfoForMIMEType):
3449         (-[WebPDFView centerSelectionInVisibleArea:]):
3450         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3451         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3452         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3453         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3454         * WebView/WebTextCompletionController.mm:
3455         (-[WebTextCompletionController _buildUI]):
3456         (-[WebTextCompletionController _placePopupWindow:]):
3457         * WebView/WebVideoFullscreenController.mm:
3458         * WebView/WebVideoFullscreenHUDWindowController.mm:
3459         (createMediaUIBackgroundView):
3460         * WebView/WebView.mm:
3461         (-[WebTextListTouchBarViewController initWithWebView:]):
3462         (-[WebView _dispatchTileDidDraw:]):
3463         (-[WebView encodeWithCoder:]):
3464         (-[WebView mainFrameIcon]):
3465         (LayerFlushController::flushLayers):
3466         * WebView/WebWindowAnimation.mm:
3467         (setScaledFrameForWindow):
3468
3469 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3470
3471         Remove unused needsDestruction class variables from HashTraits
3472         https://bugs.webkit.org/show_bug.cgi?id=189490
3473
3474         Reviewed by Daniel Bates.
3475
3476         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3477
3478 2018-09-07  Frederic Wang  <fwang@igalia.com>
3479
3480         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3481         https://bugs.webkit.org/show_bug.cgi?id=182230
3482
3483         Reviewed by Simon Fraser.
3484
3485         * DOM/DOMDocument.mm:
3486         (-[DOMDocument scrollingElement]): Use the new name.
3487
3488 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3489
3490         Refactor WebCore::EditAction to be an 8-bit enum class
3491         https://bugs.webkit.org/show_bug.cgi?id=189383
3492
3493         Reviewed by Dan Bernstein.
3494
3495         * WebCoreSupport/WebEditorClient.mm:
3496         (undoNameForEditAction):
3497         * WebView/WebHTMLView.mm:
3498         (-[WebHTMLView pasteFont:]):
3499         (-[WebHTMLView changeFont:]):
3500         (-[WebHTMLView changeAttributes:]):
3501         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3502         (-[WebHTMLView changeColor:]):
3503         * WebView/WebView.mm:
3504         (-[WebView setTypingStyle:]):
3505
3506 2018-09-06  Frederic Wang  <fwang@igalia.com>
3507
3508         Group options of scrollRectToVisible into a struct
3509         https://bugs.webkit.org/show_bug.cgi?id=189352
3510
3511         Reviewed by Simon Fraser.
3512
3513         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3514         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3515         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3516
3517 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3518
3519         [macOS] Cannot change font size at selection until font panel is shown
3520         https://bugs.webkit.org/show_bug.cgi?id=189295
3521         <rdar://problem/35593389>
3522
3523         Reviewed by Ryosuke Niwa.
3524
3525         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3526         WebCore ChangeLog for more details.
3527
3528         * WebView/WebHTMLView.mm:
3529         (-[WebHTMLView changeFont:]):
3530         (-[WebHTMLView changeAttributes:]):
3531         (-[WebHTMLView _originalFontA]): Deleted.
3532         (-[WebHTMLView _originalFontB]): Deleted.
3533         (fontNameForDescription): Deleted.
3534         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3535         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3536         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3537
3538 2018-09-05  Jer Noble  <jer.noble@apple.com>
3539
3540         Add MediaCapabilities as an Experimental Feature
3541         https://bugs.webkit.org/show_bug.cgi?id=189209
3542
3543         Reviewed by Eric Carlson.
3544
3545         RuntimeEnabledFeature -> Setting.
3546
3547         * WebView/WebView.mm:
3548         (-[WebView _preferencesChanged:]):
3549
3550 2018-09-04  Frederic Wang  <fwang@igalia.com>
3551
3552         Add basic support for ScrollIntoViewOptions
3553         https://bugs.webkit.org/show_bug.cgi?id=189258
3554
3555         Reviewed by Simon Fraser.
3556
3557         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3558         header so that this file can build despite the new scrollIntoView function.
3559
3560 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3561
3562         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3563         https://bugs.webkit.org/show_bug.cgi?id=188890
3564         <rdar://problem/43648605>
3565
3566         Reviewed by Tim Horton.
3567
3568         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3569         more detail.
3570
3571         * WebCoreSupport/WebPlatformStrategies.h:
3572         * WebCoreSupport/WebPlatformStrategies.mm:
3573         (WebPlatformStrategies::allStringsForType):
3574
3575 2018-09-01  Darin Adler  <darin@apple.com>
3576
3577         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3578         https://bugs.webkit.org/show_bug.cgi?id=189072
3579         Reviewed by Dan Bernstein.
3580
3581         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3582         and declarations for NSURLDownload init methods.
3583
3584         * Misc/WebDownloadInternal.h: Removed.
3585
3586         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3587         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3588         "-Wdeprecated-declarations" because the method used here is deprecated.
3589
3590         * WebView/WebView.mm:
3591         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3592         used here is deprecated.
3593
3594 2018-08-31  Chris Dumez  <cdumez@apple.com>
3595
3596         Assertion hit in ~CompletionHandler() from ~WebFrame()
3597         https://bugs.webkit.org/show_bug.cgi?id=189199
3598         <rdar://problem/42657233>
3599
3600         Reviewed by Youenn Fablet.
3601
3602         * WebCoreSupport/WebFrameLoaderClient.h:
3603         * WebCoreSupport/WebFrameLoaderClient.mm:
3604         (WebFrameLoaderClient::dispatchWillSubmitForm):
3605
3606 2018-08-31  Antti Koivisto  <antti@apple.com>
3607
3608         Replace OptionSet |= and -= operators with add() and remove() functions
3609         https://bugs.webkit.org/show_bug.cgi?id=189169
3610
3611         Reviewed by Anders Carlsson.
3612
3613         * WebView/WebFrame.mm:
3614         (-[WebFrame _drawRect:contentsOnly:]):
3615         * WebView/WebView.mm:
3616         (coreOptions):
3617
3618 2018-08-31  Frederic Wang  <fwang@igalia.com>
3619
3620         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3621         https://bugs.webkit.org/show_bug.cgi?id=182053
3622
3623         Reviewed by Simon Fraser.
3624
3625         Add developer flag to use standard behavior for scrolling* attributes.
3626
3627         * WebView/WebPreferenceKeysPrivate.h:
3628         * WebView/WebPreferences.mm:
3629         (+[WebPreferences initialize]):
3630         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3631         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3632         * WebView/WebPreferencesPrivate.h:
3633         * WebView/WebView.mm:
3634         (-[WebView _preferencesChanged:]):
3635
3636 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3637
3638         Implement the Web Share API
3639         https://bugs.webkit.org/show_bug.cgi?id=171100
3640         <rdar://problem/31751734>
3641
3642         Reviewed by Tim Horton.
3643
3644         * WebCoreSupport/WebChromeClient.h:
3645         * WebCoreSupport/WebChromeClient.mm:
3646         (WebChromeClient::showShareSheet):
3647         Empty declaration of showShareSheet.
3648
3649 2018-08-29  Youenn Fablet  <youenn@apple.com>
3650
3651         Remove WebRTC legacy API implementation
3652         https://bugs.webkit.org/show_bug.cgi?id=189040
3653
3654         Reviewed by Eric Carlson.
3655
3656         * WebView/WebPreferenceKeysPrivate.h:
3657         * WebView/WebPreferences.mm:
3658         (+[WebPreferences initialize]):
3659         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3660         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3661         * WebView/WebPreferencesPrivate.h:
3662         * WebView/WebView.mm:
3663         (-[WebView _preferencesChanged:]):
3664
3665 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3666
3667         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3668         https://bugs.webkit.org/show_bug.cgi?id=189054
3669
3670         Reviewed by Andy Estes.
3671
3672         Remove the pasteboard type argument from readURLFromPasteboard.
3673
3674         * WebCoreSupport/WebPlatformStrategies.h:
3675         * WebCoreSupport/WebPlatformStrategies.mm:
3676         (WebPlatformStrategies::readURLFromPasteboard):
3677
3678 2018-08-27  Keith Rollin  <krollin@apple.com>
3679
3680         Unreviewed build fix -- disable LTO for production builds
3681
3682         * Configurations/Base.xcconfig:
3683
3684 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3685
3686         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3687         https://bugs.webkit.org/show_bug.cgi?id=188931
3688
3689         Reviewed by Wenson Hsieh.
3690
3691         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3692
3693 2018-08-27  Keith Rollin  <krollin@apple.com>
3694
3695         Build system support for LTO
3696         https://bugs.webkit.org/show_bug.cgi?id=187785
3697         <rdar://problem/42353132>
3698
3699         Reviewed by Dan Bernstein.
3700
3701         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3702         LTO.
3703
3704         * Configurations/Base.xcconfig:
3705         * Configurations/DebugRelease.xcconfig:
3706
3707 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3708
3709         Pass in IsComposed flag to Event constructors
3710         https://bugs.webkit.org/show_bug.cgi?id=188720
3711         <rdar://problem/43580387>
3712
3713         Reviewed by Simon Fraser.
3714
3715         * WebView/WebPDFView.mm:
3716         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3717         whether it's simulated or not.
3718
3719 2018-08-23  Mark Lam  <mark.lam@apple.com>
3720
3721         Move vmEntryGlobalObject() to VM from CallFrame.
3722         https://bugs.webkit.org/show_bug.cgi?id=188900
3723         <rdar://problem/43655753>
3724
3725         Reviewed by Michael Saboff.
3726
3727         * WebView/WebScriptDebugger.mm:
3728         (WebScriptDebugger::sourceParsed):
3729
3730 2018-08-23  Andy Estes  <aestes@apple.com>
3731
3732         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3733         https://bugs.webkit.org/show_bug.cgi?id=188829
3734
3735         Reviewed by Tim Horton.
3736
3737         * Configurations/FeatureDefines.xcconfig:
3738
3739 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3740
3741         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3742         https://bugs.webkit.org/show_bug.cgi?id=188777
3743
3744         Reviewed by Simon Fraser.
3745
3746         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3747         being "true" before the code change.
3748
3749         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3750
3751         * WebView/WebPDFView.mm:
3752         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3753
3754 2018-08-21  Daniel Bates  <dabates@apple.com>
3755
3756         Replace TextCheckingTypeMask with OptionSet
3757         https://bugs.webkit.org/show_bug.cgi?id=188678
3758
3759         Reviewed by Antti Koivisto.
3760
3761         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3762         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3763         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3764         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3765
3766         * WebCoreSupport/WebEditorClient.h:
3767         * WebCoreSupport/WebEditorClient.mm:
3768         (WebEditorClient::checkTextOfParagraph):
3769         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3770         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3771         left as this is more readable and unncessary now that modern compilers like Clang have
3772         diagnostics to catch accidental assignments when equality was intended.
3773         (WebEditorClient::didCheckSucceed):
3774         * WebView/WebView.mm:
3775         (coreTextCheckingType):
3776         (textCheckingResultFromNSTextCheckingResult):
3777
3778 2018-08-21  Daniel Bates  <dabates@apple.com>
3779
3780         [iOS][WK1] Support toggling continuous spell checking from tests
3781         https://bugs.webkit.org/show_bug.cgi?id=188763
3782
3783         Reviewed by Simon Fraser.
3784
3785         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3786         spell checking from tests in iOS WebKit Legacy.
3787
3788         * WebCoreSupport/WebEditorClient.h:
3789         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3790         * WebCoreSupport/WebEditorClient.mm:
3791         * WebView/WebView.h:
3792         * WebView/WebView.mm:
3793         (-[WebView toggleContinuousSpellChecking:]):
3794         (-[WebView toggleSmartInsertDelete:]):
3795
3796 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3797
3798         Add some plumbing for safe browsing
3799         https://bugs.webkit.org/show_bug.cgi?id=188709
3800
3801         Reviewed by Tim Horton.
3802
3803         * WebCoreSupport/WebFrameLoaderClient.h:
3804         * WebCoreSupport/WebFrameLoaderClient.mm:
3805         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3806
3807 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3808
3809         Replace canBubble and cancelable booleans in Event by enum classes
3810         https://bugs.webkit.org/show_bug.cgi?id=188692
3811
3812         Reviewed by Alex Christensen.
3813
3814         * WebView/WebPDFView.mm:
3815         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3816         * WebView/WebView.mm:
3817         (-[WebView _dispatchUnloadEvent]):
3818
3819 2018-08-16  Jer Noble  <jer.noble@apple.com>
3820
3821         Add Experimental Feature support for SourceBuffer.changeType()
3822         https://bugs.webkit.org/show_bug.cgi?id=188626
3823         <rdar://problem/43356021>
3824
3825         Reviewed by Eric Carlson.
3826
3827         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3828
3829         * WebView/WebPreferenceKeysPrivate.h:
3830         * WebView/WebPreferences.mm:
3831         (+[WebPreferences initialize]):
3832         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3833         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3834         * WebView/WebPreferencesPrivate.h:
3835         * WebView/WebView.mm:
3836         (-[WebView _preferencesChanged:]):
3837
3838 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3839
3840         Support drag-and-drop for input[type=color]
3841         https://bugs.webkit.org/show_bug.cgi?id=188464
3842
3843         Reviewed by Wenson Hsieh.
3844
3845         * WebCoreSupport/WebPlatformStrategies.h:
3846         * WebCoreSupport/WebPlatformStrategies.mm:
3847         (WebPlatformStrategies::setColor):
3848
3849 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3850
3851         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3852         https://bugs.webkit.org/show_bug.cgi?id=188569
3853         <rdar://problem/34201095>
3854
3855         Reviewed by Megan Gardner.
3856
3857         * WebView/WebImmediateActionController.mm:
3858         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3859         Speculative fix; the crashes indicate font is null, but we just checked it,
3860         so it must be getting made null by convertFont:toSize:. Check again!
3861
3862 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3863
3864         Use a 1-byte enum class for TextDirection
3865         https://bugs.webkit.org/show_bug.cgi?id=188350
3866
3867         Reviewed by Simon Fraser.
3868
3869         * WebCoreSupport/PopupMenuMac.mm:
3870         (PopupMenuMac::populate):
3871         (PopupMenuMac::show):
3872         * WebCoreSupport/WebFrameLoaderClient.mm:
3873         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3874         * WebView/WebFrame.mm:
3875         (-[WebFrame _dispatchDidReceiveTitle:]):
3876
3877 2018-08-09  Ali Juma  <ajuma@chromium.org>
3878
3879         Import WPTs for IntersectionObserver
3880         https://bugs.webkit.org/show_bug.cgi?id=188416
3881
3882         Reviewed by Simon Fraser.
3883
3884         * WebView/WebPreferencesPrivate.h:
3885
3886 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3887
3888         Follow-up build fix for r234685
3889         https://bugs.webkit.org/show_bug.cgi?id=188245
3890
3891         Unreviewed build fix.
3892
3893         * WebCoreSupport/WebSecurityOriginPrivate.h:
3894
3895 2018-08-05  Darin Adler  <darin@apple.com>
3896
3897         [Cocoa] More tweaks and refactoring to prepare for ARC
3898         https://bugs.webkit.org/show_bug.cgi?id=188245
3899
3900         Reviewed by Dan Bernstein.
3901
3902         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3903
3904         * Carbon/CarbonWindowFrame.m:
3905         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3906
3907         * DOM/DOM.mm:
3908         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3909         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3910         garbage collection so this method isn't useful.
3911
3912         * DOM/DOMXPath.mm:
3913         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3914         Objective-C garbage collection so this method isn't useful.
3915
3916         * History/WebHistory.mm:
3917         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3918
3919         * Misc/WebElementDictionary.mm:
3920         (addLookupKey): Use a bridging cast.
3921         (cacheValueForKey): Ditto.
3922         (-[WebElementDictionary _fillCache]): Ditto.
3923         (-[WebElementDictionary objectForKey:]): Ditto.
3924
3925         * Misc/WebKitNSStringExtras.mm:
3926         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3927         (-[NSString _web_widthWithFont:]): Ditto.
3928         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3929
3930         * Misc/WebLocalizableStrings.mm:
3931         (WebLocalizedString): Use a bridging cast.
3932
3933         * Misc/WebNSDataExtras.mm:
3934         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3935         and use CFBridgingRelease instead of calling autorelease directly.
3936         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3937         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3938         on the amount of explicit release and autorelease.
3939
3940         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3941         * Misc/WebNSDictionaryExtras.m:
3942         (-[NSDictionary _webkit_intForKey:]): Deleted.
3943         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3944         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3945         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3946         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3947         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3948         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3949
3950         * Misc/WebStringTruncator.mm:
3951         (fontFromNSFont): Use a bridging cast.
3952
3953         * Plugins/Hosted/NetscapePluginHostManager.mm:
3954         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3955
3956         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3957         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3958         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3959         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3960         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3961         * Plugins/Hosted/ProxyInstance.mm:
3962         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3963         * Plugins/WebBasePluginPackage.mm:
3964         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3965         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3966         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3967         * Plugins/WebNetscapePluginPackage.mm:
3968         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3969
3970         * Plugins/WebNetscapePluginView.mm:
3971         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3972         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3973         (-[WebNetscapePluginView status:]): Use a bridging cast.
3974         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3975
3976         * Plugins/WebPluginController.mm:
3977         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3978
3979         * Plugins/WebPluginDatabase.mm:
3980         (checkCandidate): Use explicit __strong for out argument types.
3981
3982         * Plugins/npapi.mm:
3983         (pluginViewForInstance): Use a bridging cast.
3984
3985         * Storage/WebDatabaseManager.mm:
3986         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3987         explicit NSNumber and NSDictionary calls.
3988
3989         * WebCoreSupport/WebContextMenuClient.mm:
3990         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3991
3992         * WebCoreSupport/WebEditorClient.mm:
3993         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3994         (WebEditorClient::handleInputMethodKeydown): Ditto.
3995
3996         * WebCoreSupport/WebFrameNetworkingContext.mm:
3997         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3998
3999         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
4000         as a struct rather than an Objective-C class, since that's how it's defined.
4001
4002         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
4003
4004         * WebView/WebFullScreenController.mm:
4005         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
4006         * WebView/WebHTMLView.mm:
4007         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
4008         Ditto.
4009         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
4010
4011         * WebView/WebImmediateActionController.mm:
4012         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
4013         go down to the document and then back to the frame.
4014         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
4015         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
4016         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
4017
4018         * WebView/WebJSPDFDoc.mm:
4019         (jsPDFDocInitialize): Removed some unneeded type casting.
4020         (jsPDFDocFinalize): Ditto.
4021         (jsPDFDocPrint): Use a bridging cast.
4022
4023         * WebView/WebPDFView.mm:
4024         (_applicationInfoForMIMEType): Use bridging casts.
4025
4026         * WebView/WebPreferences.mm:
4027         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
4028         instead of methods from WebNSDictionaryExtras.
4029         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
4030         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
4031         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
4032         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
4033         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
4034
4035         * WebView/WebView.mm:
4036         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
4037         (-[WebView _addToAllWebViewsSet]): Ditto.
4038         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
4039         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
4040         so it can be called from WebViewData methods.
4041
4042         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
4043         method, _windowVisibilityChanged:.
4044
4045         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
4046         called from WebViewData methods.
4047
4048 2018-08-06  Alex Christensen  <achristensen@webkit.org>
4049
4050         Use enum classes and OptionSets for PaintPhase and PaintBehavior
4051         https://bugs.webkit.org/show_bug.cgi?id=188323
4052
4053         Reviewed by Simon Fraser.