Cannot tab out of WKWebView on macOS
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-01-15  Tim Horton  <timothy_horton@apple.com>
2
3         Cannot tab out of WKWebView on macOS
4         https://bugs.webkit.org/show_bug.cgi?id=161448
5         <rdar://problem/28100085>
6
7         Reviewed by Dean Jackson.
8
9         * WebCoreSupport/WebChromeClient.mm:
10         * WebView/WebView.mm:
11         Make use of SPI headers.
12
13 2019-01-14  Commit Queue  <commit-queue@webkit.org>
14
15         Unreviewed, rolling out r239901, r239909, r239910, r239912,
16         r239913, and r239914.
17         https://bugs.webkit.org/show_bug.cgi?id=193407
18
19         These revisions caused an internal failure (Requested by
20         Truitt on #webkit).
21
22         Reverted changesets:
23
24         "[Cocoa] Avoid importing directly from subumbrella frameworks"
25         https://bugs.webkit.org/show_bug.cgi?id=186016
26         https://trac.webkit.org/changeset/239901
27
28         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
29         https://trac.webkit.org/changeset/239909
30
31         "Tried to fix the build."
32         https://trac.webkit.org/changeset/239910
33
34         "Fixed iOS builds after r239910."
35         https://trac.webkit.org/changeset/239912
36
37         "More build fixing."
38         https://trac.webkit.org/changeset/239913
39
40         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
41         https://trac.webkit.org/changeset/239914
42
43 2019-01-14  Mark Lam  <mark.lam@apple.com>
44
45         Re-enable ability to build --cloop builds.
46         https://bugs.webkit.org/show_bug.cgi?id=192955
47         <rdar://problem/46882363>
48
49         Reviewed by Saam barati and Keith Miller.
50
51         * Configurations/FeatureDefines.xcconfig:
52
53 2019-01-13  Dan Bernstein  <mitz@apple.com>
54
55         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
56
57         Patch by Keith Rollin.
58
59         * WebView/PDFViewSPI.h:
60
61 2019-01-12  Timothy Hatcher  <timothy@apple.com>
62
63         Have prefers-color-scheme: light always match on macOS versions before Mojave.
64         https://bugs.webkit.org/show_bug.cgi?id=191655
65         rdar://problem/46074680
66
67         Reviewed by Megan Gardner.
68
69         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
70         * WebView/WebView.mm:
71         (-[WebView _effectiveAppearanceIsDark]):
72
73 2019-01-12  Dan Bernstein  <mitz@apple.com>
74
75         [Cocoa] Avoid importing directly from subumbrella frameworks
76         https://bugs.webkit.org/show_bug.cgi?id=186016
77         <rdar://problem/40591038>
78
79         Reviewed by Sam Weinig.
80
81         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
82         * Carbon/CarbonWindowAdapter.mm: Ditto.
83         * Carbon/CarbonWindowFrame.m: Ditto.
84         * Carbon/HIViewAdapter.h: Ditto.
85         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
86           OTHER_CFLAGS_COCOA_TOUCH_NO.
87         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
88         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
89         * WebView/WebPDFView.h: Ditto.
90
91 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
92
93         Enable visual viewport API by default
94         https://bugs.webkit.org/show_bug.cgi?id=193376
95
96         Reviewed by Simon Fraser.
97
98         * WebView/WebPreferences.mm:
99         (+[WebPreferences initialize]):
100
101 2019-01-11  John Wilander  <wilander@apple.com>
102
103         Compile out Web API Statistics Collection
104         https://bugs.webkit.org/show_bug.cgi?id=193370
105         <rdar://problem/45388584>
106
107         Reviewed by Brent Fulgham.
108
109         * Configurations/FeatureDefines.xcconfig:
110             Defined ENABLE_WEB_API_STATISTICS, off by default.
111
112 2019-01-08  Alex Christensen  <achristensen@webkit.org>
113
114         Stop using NetworkStorageSession in WebProcess
115         https://bugs.webkit.org/show_bug.cgi?id=193236
116
117         Reviewed by Don Olmstead.
118
119         * WebCoreSupport/WebFrameNetworkingContext.h:
120         * WebCoreSupport/WebFrameNetworkingContext.mm:
121         (WebFrameNetworkingContext::storageSession const):
122         * WebCoreSupport/WebPlatformStrategies.h:
123         * WebCoreSupport/WebPlatformStrategies.mm:
124         (WebPlatformStrategies::cookiesForDOM):
125         (WebPlatformStrategies::setCookiesFromDOM):
126         (WebPlatformStrategies::cookiesEnabled):
127         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
128         (WebPlatformStrategies::getRawCookies):
129         (WebPlatformStrategies::deleteCookie):
130         * WebView/WebView.mm:
131         (-[WebView _cachedResponseForURL:]):
132         (-[WebView _clearCredentials]):
133
134 2019-01-08  Alex Christensen  <achristensen@webkit.org>
135
136         Unreviewed, rolling out r239727.
137
138         Broke API tests
139
140         Reverted changeset:
141
142         "Stop using NetworkStorageSession in WebProcess"
143         https://bugs.webkit.org/show_bug.cgi?id=193236
144         https://trac.webkit.org/changeset/239727
145
146 2019-01-08  Alex Christensen  <achristensen@webkit.org>
147
148         Stop using NetworkStorageSession in WebProcess
149         https://bugs.webkit.org/show_bug.cgi?id=193236
150
151         Reviewed by Don Olmstead.
152
153         * WebCoreSupport/WebFrameNetworkingContext.h:
154         * WebCoreSupport/WebFrameNetworkingContext.mm:
155         (WebFrameNetworkingContext::storageSession const):
156         * WebView/WebView.mm:
157         (-[WebView _cachedResponseForURL:]):
158         (-[WebView _clearCredentials]):
159
160 2019-01-07  David Kilzer  <ddkilzer@apple.com>
161
162         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
163         <https://webkit.org/b/193056>
164
165         Reviewed by Alex Christensen.
166
167         * Plugins/Hosted/NetscapePluginHostProxy.h:
168         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
169         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
170         (WebKit::NetscapePluginInstanceProxy::enumerate):
171         (WebKit::NetscapePluginInstanceProxy::marshalValue):
172         (WebKit::NetscapePluginInstanceProxy::marshalValues):
173         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
174         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
175         * Plugins/Hosted/ProxyInstance.mm:
176         (WebKit::ProxyInstance::invoke):
177         * WebCoreSupport/WebGeolocationClient.mm:
178         * WebView/WebDataSource.mm:
179         (-[WebDataSource _receivedData:]):
180         * WebView/WebView.mm:
181         (-[WebView _cachedResponseForURL:]):
182         - Remove '*' from RetainPtr<> type.
183
184 2019-01-04  Alex Christensen  <achristensen@webkit.org>
185
186         Progress towards fixing Mac CMake build
187         https://bugs.webkit.org/show_bug.cgi?id=193105
188
189         Reviewed by Don Olmstead.
190
191         * WebKitPrefix.h:
192
193 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
194
195         Web Inspector: Use save sheet instead of dialog where possible
196         https://bugs.webkit.org/show_bug.cgi?id=193160
197         <rdar://problem/37399759>
198
199         Reviewed by Devin Rousso.
200
201         * WebCoreSupport/WebInspectorClient.mm:
202         (WebInspectorFrontendClient::save):
203
204 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
205
206         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
207         https://bugs.webkit.org/show_bug.cgi?id=193129
208
209         Reviewed by Tim Horton.
210
211         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
212
213         * WebCoreSupport/WebEditorClient.mm:
214         (WebEditorClient::registerUndoOrRedoStep):
215         (undoNameForEditAction): Deleted.
216
217 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
218
219         Add support for using the current text selection as the find string on iOS
220         https://bugs.webkit.org/show_bug.cgi?id=193034
221         <rdar://problem/45138739>
222
223         Reviewed by Tim Horton.
224
225         Add a method stub for WebKitLegacy.
226
227         * WebCoreSupport/WebEditorClient.h:
228
229 2019-01-01  Jeff Miller  <jeffm@apple.com>
230
231         Update user-visible copyright strings to include 2019
232         https://bugs.webkit.org/show_bug.cgi?id=192811
233
234         Reviewed by Mark Lam.
235
236         * Info.plist:
237
238 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
239
240         Use Ref<> as much as possible
241         https://bugs.webkit.org/show_bug.cgi?id=192808
242
243         Reviewed by Alex Christensen.
244
245         * DOM/DOM.mm:
246         (-[DOMNode getPreviewSnapshotImage:andRects:]):
247         * Plugins/Hosted/NetscapePluginHostManager.mm:
248         (WebKit::NetscapePluginHostManager::instantiatePlugin):
249         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
250         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
251         (WebKit::NetscapePluginInstanceProxy::loadRequest):
252         * Plugins/WebNetscapePluginView.mm:
253         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
254         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
255         * WebCoreSupport/WebContextMenuClient.mm:
256         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
257         * WebCoreSupport/WebFrameLoaderClient.mm:
258         (WebFrameLoaderClient::transitionToCommittedForNewPage):
259         * WebView/WebFrame.mm:
260         (-[WebFrame getDictationResultRanges:andMetadatas:]):
261         * WebView/WebHTMLView.mm:
262         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
263         * WebView/WebView.mm:
264         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
265         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
266
267 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
268
269         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
270         https://bugs.webkit.org/show_bug.cgi?id=192821
271
272         Reviewed by Chris Dumez.
273
274         When a window becomes occluded, the window server informs the application.
275         This should be used to suspend any work that is not visible by the user.
276
277         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
278         In some cases, that lead to performance impact (see radar).
279
280         This patch adds an observer for the occlusion notification. I tried to stick
281         with the same names used by WebKit2.
282
283         * WebView/WebView.mm:
284         (-[WebView _isViewVisible]):
285         (-[WebView addWindowObserversForWindow:]):
286         (-[WebView removeWindowObservers]):
287         (-[WebView _windowDidChangeOcclusionState:]):
288
289 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
290
291         [WebAuthN] Add a runtime flag for local authenticator
292         https://bugs.webkit.org/show_bug.cgi?id=192792
293         <rdar://problem/46798738>
294
295         Reviewed by Brent Fulgham.
296
297         * WebView/WebPreferenceKeysPrivate.h:
298         * WebView/WebPreferences.mm:
299         (+[WebPreferences initialize]):
300         (-[WebPreferences webAuthenticationEnabled]): Deleted.
301         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
302         * WebView/WebPreferencesPrivate.h:
303         * WebView/WebView.mm:
304         (-[WebView _preferencesChanged:]):
305
306 2018-12-20  Chris Dumez  <cdumez@apple.com>
307
308         Use Optional::valueOr() instead of Optional::value_or()
309         https://bugs.webkit.org/show_bug.cgi?id=192933
310
311         Reviewed by Geoffrey Garen.
312
313         * WebCoreSupport/WebSecurityOrigin.mm:
314         (-[WebSecurityOrigin port]):
315
316 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
317
318         Unreviewed, rolling out r239417.
319
320         Introduced two API test failures on macOS.
321
322         Reverted changeset:
323
324         "<rdar://problem/46194315> macOS: WebKit1 does not handle
325         occlusion changes"
326         https://bugs.webkit.org/show_bug.cgi?id=192821
327         https://trac.webkit.org/changeset/239417
328
329 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
330
331         WKWebView default UA doesn't freeze the build number
332         https://bugs.webkit.org/show_bug.cgi?id=192809
333         <rdar://problem/44687185>
334
335         Reviewed by Andy Estes.
336
337         Always reports the frozen build number.
338
339         * WebView/WebView.mm:
340         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
341         actual build number through this method call.
342         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
343
344 2018-12-19  Chris Dumez  <cdumez@apple.com>
345
346         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
347         https://bugs.webkit.org/show_bug.cgi?id=192728
348         <rdar://problem/46746779>
349
350         Reviewed by Geoff Garen.
351
352         * DOM/*:
353         * Plugins/*:
354         * WebCoreSupport/*:
355         * WebView/*:
356
357 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
358
359         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
360         https://bugs.webkit.org/show_bug.cgi?id=192821
361
362         Reviewed by Chris Dumez.
363
364         When a window becomes occluded, the window server informs the application.
365         This should be used to suspend any work that is not visible by the user.
366
367         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
368         In some cases, that lead to performance impact (see radar).
369
370         This patch adds an observer for the occlusion notification. I tried to stick
371         with the same names used by WebKit2.
372
373         * WebView/WebView.mm:
374         (-[WebView _isViewVisible]):
375         (-[WebView addWindowObserversForWindow:]):
376         (-[WebView removeWindowObservers]):
377         (-[WebView _windowDidChangeOcclusionState:]):
378
379 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
380
381         Allow clients to set the navigator platform
382         https://bugs.webkit.org/show_bug.cgi?id=192735
383
384         Reviewed by Tim Horton.
385
386         Add stubs to fill out the added functionality in FrameLoaderClient.
387
388         * WebCoreSupport/WebFrameLoaderClient.h:
389         * WebCoreSupport/WebFrameLoaderClient.mm:
390         (WebFrameLoaderClient::navigatorPlatform):
391
392 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
393
394         offsetLeft and offsetParent should adjust across shadow boundaries
395         https://bugs.webkit.org/show_bug.cgi?id=157437
396         <rdar://problem/26154021>
397
398         Reviewed by Simon Fraser.
399
400         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
401
402         * DOM/DOMElement.mm:
403         (-[DOMElement offsetLeft]):
404         (-[DOMElement offsetTop]):
405         (-[DOMElement offsetParent]):
406
407 2018-12-17  Zalan Bujtas  <zalan@apple.com>
408
409         Unreviewed build fix.
410
411         * WebView/WebFrame.mm:
412         (-[WebFrame getDictationResultRanges:andMetadatas:]):
413
414 2018-12-15  Darin Adler  <darin@apple.com>
415
416         Use warning-ignoring macros more consistently and simply
417         https://bugs.webkit.org/show_bug.cgi?id=192743
418
419         Reviewed by Mark Lam.
420
421         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
422         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
423         compilers in Objective-C++ code.
424
425         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
426         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
427         accomodate non-clang compilers here. Also use #pragma once, add a missing
428         "explicit" and fix conditionals.
429
430 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
431
432         Make TextInputController.legacyAttributedString take DOM nodes and offsets
433         https://bugs.webkit.org/show_bug.cgi?id=192653
434
435         Reviewed by Wenson Hsieh.
436
437         * WebView/WebHTMLView.mm:
438         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
439
440 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
441
442         Implement feature flag for CSS Typed OM
443         https://bugs.webkit.org/show_bug.cgi?id=192610
444
445         Reviewed by Ryosuke Niwa.
446
447         * Configurations/FeatureDefines.xcconfig:
448
449 2018-12-11  Tim Horton  <timothy_horton@apple.com>
450
451         WebCore shouldn't have a Objective-C class named NSCursor
452         https://bugs.webkit.org/show_bug.cgi?id=192602
453         <rdar://problem/46615532>
454
455         Reviewed by Wenson Hsieh.
456
457         * WebView/WebFrameView.mm:
458         (-[WebFrameView keyDown:keyDown:]):
459         * WebView/WebHTMLView.mm:
460         (-[WebHTMLView keyDown:]):
461         (-[WebHTMLView performKeyEquivalent:]):
462         Only use NSCursor on macOS.
463
464 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
465
466         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
467         https://bugs.webkit.org/show_bug.cgi?id=192573
468
469         Reviewed by Simon Fraser.
470
471         * Configurations/FeatureDefines.xcconfig:
472
473 2018-12-10  Antti Koivisto  <antti@apple.com>
474
475         Rename "forced style recalc" to "full style rebuild"
476         https://bugs.webkit.org/show_bug.cgi?id=192572
477
478         Reviewed by Zalan Bujtas.
479
480         * WebView/WebHTMLView.mm:
481         (-[WebHTMLView setNeedsToApplyStyles:]):
482
483 2018-12-10  Darin Adler  <darin@apple.com>
484
485         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
486         https://bugs.webkit.org/show_bug.cgi?id=192533
487         rdar://problem/45732710
488
489         Reviewed by Anders Carlsson.
490
491         * Plugins/Hosted/NetscapePluginHostProxy.mm:
492         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
493
494 2018-12-10  Darin Adler  <darin@apple.com>
495
496         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
497         https://bugs.webkit.org/show_bug.cgi?id=192532
498         rdar://problem/45731047
499
500         Reviewed by Chris Dumez.
501
502         * Plugins/Hosted/NetscapePluginHostManager.mm:
503         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
504         * Plugins/Hosted/NetscapePluginHostProxy.mm:
505         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
506
507 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
508
509         Turn WritingDirection into an enum class
510         https://bugs.webkit.org/show_bug.cgi?id=192401
511         Work towards <rdar://problem/42075638>
512
513         Reviewed by Dan Bernstein.
514
515         Change WritingDirection from an enum to an enum class. No change in behavior.
516
517         * WebView/WebHTMLView.mm:
518         (-[WebHTMLView toggleBaseWritingDirection:]):
519         (-[WebHTMLView changeBaseWritingDirection:]):
520         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
521
522 2018-12-03  Alex Christensen  <achristensen@webkit.org>
523
524         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
525         https://bugs.webkit.org/show_bug.cgi?id=192272
526
527         Reviewed by Brady Eidson.
528
529         * WebCoreSupport/WebFrameLoaderClient.h:
530         * WebCoreSupport/WebFrameLoaderClient.mm:
531         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
532
533 2018-12-03  Jer Noble  <jer.noble@apple.com>
534
535         Get rid of old, dead Mac video fullscreen code.
536         https://bugs.webkit.org/show_bug.cgi?id=192315
537
538         Reviewed by Eric Carlson.
539
540         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
541         is no longer supported in the Mac port.
542
543         * WebView/WebVideoFullscreenController.h: Removed.
544         * WebView/WebVideoFullscreenController.mm: Removed.
545         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
546         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
547         * WebView/WebView.mm:
548         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
549         (-[WebView _exitVideoFullscreen]):
550
551 2018-12-03  Daniel Bates  <dabates@apple.com>
552
553         [iOS] Do not handle key events that are key commands
554         https://bugs.webkit.org/show_bug.cgi?id=191608
555         <rdar://problem/46046013>
556
557         Reviewed by Ryosuke Niwa.
558
559         A key down event may be associated with a key command. If it is then we want to execute the
560         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
561         event as a key command to find out.
562
563         * WebView/WebHTMLView.mm:
564         (-[WebHTMLView _handleEditingKeyEvent:]):
565
566 2018-12-02  Zalan Bujtas  <zalan@apple.com>
567
568         Add a runtime feature flag for LayoutFormattingContext.
569         https://bugs.webkit.org/show_bug.cgi?id=192280
570
571         Reviewed by Simon Fraser.
572
573         * Configurations/FeatureDefines.xcconfig:
574
575 2018-11-30  Alex Christensen  <achristensen@webkit.org>
576
577         Move URL from WebCore to WTF
578         https://bugs.webkit.org/show_bug.cgi?id=190234
579
580         Reviewed by Keith Miller.
581
582         * DOM/DOMAttr.mm:
583         * DOM/DOMBlob.mm:
584         * DOM/DOMCSSCharsetRule.mm:
585         * DOM/DOMCSSImportRule.mm:
586         * DOM/DOMCSSMediaRule.mm:
587         * DOM/DOMCSSPageRule.mm:
588         * DOM/DOMCSSPrimitiveValue.mm:
589         * DOM/DOMCSSRule.mm:
590         * DOM/DOMCSSStyleDeclaration.mm:
591         * DOM/DOMCSSStyleRule.mm:
592         * DOM/DOMCSSStyleSheet.mm:
593         * DOM/DOMCSSValue.mm:
594         * DOM/DOMCharacterData.mm:
595         * DOM/DOMCounter.mm:
596         * DOM/DOMDocument.mm:
597         * DOM/DOMDocumentFragment.mm:
598         * DOM/DOMDocumentType.mm:
599         * DOM/DOMEvent.mm:
600         * DOM/DOMFile.mm:
601         * DOM/DOMHTMLAnchorElement.mm:
602         * DOM/DOMHTMLAppletElement.mm:
603         * DOM/DOMHTMLAreaElement.mm:
604         * DOM/DOMHTMLBRElement.mm:
605         * DOM/DOMHTMLBaseElement.mm:
606         * DOM/DOMHTMLBaseFontElement.mm:
607         * DOM/DOMHTMLBodyElement.mm:
608         * DOM/DOMHTMLButtonElement.mm:
609         * DOM/DOMHTMLCanvasElement.mm:
610         * DOM/DOMHTMLCollection.mm:
611         * DOM/DOMHTMLDivElement.mm:
612         * DOM/DOMHTMLDocument.mm:
613         * DOM/DOMHTMLElement.mm:
614         * DOM/DOMHTMLEmbedElement.mm:
615         * DOM/DOMHTMLFieldSetElement.mm:
616         * DOM/DOMHTMLFontElement.mm:
617         * DOM/DOMHTMLFormElement.mm:
618         * DOM/DOMHTMLFrameElement.mm:
619         * DOM/DOMHTMLFrameSetElement.mm:
620         * DOM/DOMHTMLHRElement.mm:
621         * DOM/DOMHTMLHeadElement.mm:
622         * DOM/DOMHTMLHeadingElement.mm:
623         * DOM/DOMHTMLHtmlElement.mm:
624         * DOM/DOMHTMLIFrameElement.mm:
625         * DOM/DOMHTMLImageElement.mm:
626         * DOM/DOMHTMLInputElement.mm:
627         * DOM/DOMHTMLLIElement.mm:
628         * DOM/DOMHTMLLabelElement.mm:
629         * DOM/DOMHTMLLegendElement.mm:
630         * DOM/DOMHTMLLinkElement.mm:
631         * DOM/DOMHTMLMapElement.mm:
632         * DOM/DOMHTMLMarqueeElement.mm:
633         * DOM/DOMHTMLMediaElement.mm:
634         * DOM/DOMHTMLMetaElement.mm:
635         * DOM/DOMHTMLModElement.mm:
636         * DOM/DOMHTMLOListElement.mm:
637         * DOM/DOMHTMLObjectElement.mm:
638         * DOM/DOMHTMLOptGroupElement.mm:
639         * DOM/DOMHTMLOptionElement.mm:
640         * DOM/DOMHTMLOptionsCollection.mm:
641         * DOM/DOMHTMLParagraphElement.mm:
642         * DOM/DOMHTMLParamElement.mm:
643         * DOM/DOMHTMLQuoteElement.mm:
644         * DOM/DOMHTMLScriptElement.mm:
645         * DOM/DOMHTMLSelectElement.mm:
646         * DOM/DOMHTMLStyleElement.mm:
647         * DOM/DOMHTMLTableCaptionElement.mm:
648         * DOM/DOMHTMLTableCellElement.mm:
649         * DOM/DOMHTMLTableColElement.mm:
650         * DOM/DOMHTMLTableElement.mm:
651         * DOM/DOMHTMLTableRowElement.mm:
652         * DOM/DOMHTMLTableSectionElement.mm:
653         * DOM/DOMHTMLTitleElement.mm:
654         * DOM/DOMHTMLUListElement.mm:
655         * DOM/DOMHTMLVideoElement.mm:
656         * DOM/DOMKeyboardEvent.mm:
657         * DOM/DOMMediaList.mm:
658         * DOM/DOMMouseEvent.mm:
659         * DOM/DOMMutationEvent.mm:
660         * DOM/DOMNamedNodeMap.mm:
661         * DOM/DOMProcessingInstruction.mm:
662         * DOM/DOMRange.mm:
663         * DOM/DOMStyleSheet.mm:
664         * DOM/DOMText.mm:
665         * DOM/DOMTextEvent.mm:
666         * DOM/DOMTokenList.mm:
667         * DOM/DOMUIEvent.mm:
668         * DOM/DOMXPathResult.mm:
669         * History/WebHistoryItem.mm:
670         * Misc/WebNSURLExtras.mm:
671         (-[NSURL _web_userVisibleString]):
672         (-[NSURL _web_URLByRemovingUserInfo]):
673         (-[NSURL _web_dataForURLComponentType:]):
674         (-[NSURL _web_schemeData]):
675         (-[NSURL _web_hostData]):
676         * Misc/WebUserContentURLPattern.mm:
677         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
678         * Plugins/WebNetscapePluginStream.h:
679         (WebNetscapePluginStream::setRequestURL):
680         * WebCoreSupport/WebChromeClient.h:
681         * WebCoreSupport/WebChromeClient.mm:
682         (WebChromeClient::signedPublicKeyAndChallengeString const):
683         * WebCoreSupport/WebContextMenuClient.h:
684         * WebCoreSupport/WebContextMenuClient.mm:
685         * WebCoreSupport/WebDragClient.h:
686         * WebCoreSupport/WebFrameLoaderClient.h:
687         * WebCoreSupport/WebFrameLoaderClient.mm:
688         (WebFrameLoaderClient::updateGlobalHistory):
689         * WebCoreSupport/WebPaymentCoordinatorClient.h:
690         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
691         (WebPaymentCoordinatorClient::showPaymentUI):
692         * WebCoreSupport/WebPlatformStrategies.h:
693         * WebCoreSupport/WebPlatformStrategies.mm:
694         (WebPlatformStrategies::readURLFromPasteboard):
695         * WebCoreSupport/WebPluginInfoProvider.h:
696         * WebCoreSupport/WebPluginInfoProvider.mm:
697         (WebPluginInfoProvider::webVisiblePluginInfo):
698         * WebCoreSupport/WebSecurityOrigin.mm:
699         * WebCoreSupport/WebVisitedLinkStore.h:
700         * WebView/WebDataSource.mm:
701         * WebView/WebFrame.mm:
702         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
703         * WebView/WebImmediateActionController.mm:
704         (-[WebImmediateActionController _defaultAnimationController]):
705         * WebView/WebPDFView.mm:
706         * WebView/WebScriptDebugger.mm:
707         * WebView/WebViewInternal.h:
708
709 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
710
711         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
712         https://bugs.webkit.org/show_bug.cgi?id=192197
713
714         Reviewed by Jiewen Tan.
715
716         * Configurations/FeatureDefines.xcconfig:
717         * WebCoreSupport/WebChromeClient.h:
718         * WebCoreSupport/WebChromeClient.mm:
719
720 2018-11-28  Alex Christensen  <achristensen@webkit.org>
721
722         Remove dead code from an earlier attempt at implementing safe browsing
723         https://bugs.webkit.org/show_bug.cgi?id=192067
724
725         Reviewed by Chris Dumez.
726
727         * WebCoreSupport/WebFrameLoaderClient.h:
728         * WebCoreSupport/WebFrameLoaderClient.mm:
729         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
730
731 2018-11-27  Mark Lam  <mark.lam@apple.com>
732
733         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
734         https://bugs.webkit.org/show_bug.cgi?id=192055
735         <rdar://problem/46288783>
736
737         Reviewed by Saam Barati.
738
739         * Configurations/FeatureDefines.xcconfig:
740
741 2018-11-25  Tim Horton  <timothy_horton@apple.com>
742
743         Make it possible to insert editable images with a gesture
744         https://bugs.webkit.org/show_bug.cgi?id=191937
745
746         Reviewed by Wenson Hsieh.
747
748         * WebCoreSupport/WebEditorClient.mm:
749         (undoNameForEditAction):
750         Add a undo name.
751
752 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
753
754         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
755         https://bugs.webkit.org/show_bug.cgi?id=191945
756
757         Reviewed by Anders Carlsson.
758
759         * WebCoreSupport/WebEditorClient.mm:
760         (undoNameForEditAction):
761
762 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
763
764         Enable drag and drop support for iOSMac
765         https://bugs.webkit.org/show_bug.cgi?id=191818
766         <rdar://problem/43907454>
767
768         Reviewed by Dean Jackson.
769
770         * Configurations/FeatureDefines.xcconfig:
771
772 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
773
774         Address post-review feedback after r238438
775         https://bugs.webkit.org/show_bug.cgi?id=191913
776
777         Reviewed by Ryosuke Niwa.
778
779         * WebView/WebFrame.mm:
780         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
781         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
782         * WebView/WebView.mm:
783         (-[WebView setSelectedDOMRange:affinity:]):
784
785 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
786
787         Web Inspector: "Reload Web Inspector" button no longer partially works
788         https://bugs.webkit.org/show_bug.cgi?id=191773
789         <rdar://problem/46139932>
790
791         Reviewed by Devin Rousso.
792
793         * WebCoreSupport/WebInspectorClient.h:
794         * WebCoreSupport/WebInspectorClient.mm:
795         (WebInspectorFrontendClient::reopen):
796
797 2018-11-17  Devin Rousso  <drousso@apple.com>
798
799         Web Inspector: Network: add button to show system certificate dialog
800         https://bugs.webkit.org/show_bug.cgi?id=191458
801         <rdar://problem/45977019>
802
803         Reviewed by Joseph Pecoraro.
804
805         * WebCoreSupport/WebInspectorClient.h:
806         * WebCoreSupport/WebInspectorClient.mm:
807         (WebInspectorFrontendClient::showCertificate): Added.
808
809         * Configurations/WebKitLegacy.xcconfig:
810
811 2018-11-15  Truitt Savell  <tsavell@apple.com>
812
813         Unreviewed, rolling out r238244.
814
815         Caused High Sierra test runs to fail early with 50 crashes and
816         casued 25 API failures.
817
818         Reverted changeset:
819
820         "[css-logical] Implement flow-relative margin, padding and
821         border shorthands"
822         https://bugs.webkit.org/show_bug.cgi?id=188697
823         https://trac.webkit.org/changeset/238244
824
825 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
826
827         [css-logical] Implement flow-relative margin, padding and border shorthands
828         https://bugs.webkit.org/show_bug.cgi?id=188697
829
830         Reviewed by Simon Fraser and Antti Koivisto.
831
832         Add CSSLogicalEnabled runtime flag.
833
834         * WebView/WebPreferenceKeysPrivate.h:
835         * WebView/WebPreferences.mm:
836         (+[WebPreferences initialize]):
837         (-[WebPreferences cssLogicalEnabled]):
838         (-[WebPreferences setCSSLogicalEnabled:]):
839         * WebView/WebPreferencesPrivate.h:
840         * WebView/WebView.mm:
841         (-[WebView _preferencesChanged:]):
842
843 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
844
845         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
846         https://bugs.webkit.org/show_bug.cgi?id=191612
847
848         Reviewed by Matt Baker.
849
850         * WebCoreSupport/WebInspectorClient.mm:
851         (-[WebInspectorWindowController destroyInspectorView]):
852
853 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
854
855         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
856         https://bugs.webkit.org/show_bug.cgi?id=191494
857         <rdar://problem/45469854>
858
859         Reviewed by Devin Rousso.
860
861         * WebCoreSupport/WebInspectorClient.h:
862         WebKitLegacy will still have remote inspection of the Page directly.
863
864 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
865
866         Make compositing updates incremental
867         https://bugs.webkit.org/show_bug.cgi?id=90342
868
869         Reviewed by Antti Koivisto.
870
871         Fix spelling error.
872
873         * WebView/WebView.mm:
874         (-[WebView _setMediaLayer:forPluginView:]):
875
876 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
877
878         Implement a new edit command to change the enclosing list type
879         https://bugs.webkit.org/show_bug.cgi?id=191487
880         <rdar://problem/45955922>
881
882         Reviewed by Ryosuke Niwa.
883
884         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
885
886         * WebCoreSupport/WebEditorClient.mm:
887         (undoNameForEditAction):
888
889 2018-11-11  Daniel Bates  <dabates@apple.com>
890
891         [iOS] Draw caps lock indicator in password fields
892         https://bugs.webkit.org/show_bug.cgi?id=190565
893         <rdar://problem/45262343>
894
895         Reviewed by Dean Jackson.
896
897         Update the caps lock state when a hardware keyboard is attached or detached.
898
899         * WebView/WebHTMLView.mm:
900         (hardwareKeyboardAvailabilityChangedCallback): Added.
901         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
902         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
903
904 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
905
906         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
907         https://bugs.webkit.org/show_bug.cgi?id=191492
908
909         Reviewed by Alex Christensen.
910
911         * Carbon/HIWebView.mm:
912         * Misc/WebNSFileManagerExtras.mm:
913         * Misc/WebNSURLExtras.mm:
914         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
915         * Plugins/WebBasePluginPackage.mm:
916         * Plugins/WebPluginContainerCheck.mm:
917         * WebCoreSupport/WebCachedFramePlatformData.h:
918         * WebCoreSupport/WebDeviceOrientationClient.mm:
919         * WebView/WebDelegateImplementationCaching.mm:
920         * WebView/WebHTMLView.mm:
921         * WebView/WebPDFRepresentation.mm:
922         * WebView/WebPolicyDelegate.mm:
923         * WebView/WebView.mm:
924
925 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
926
927         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
928         https://bugs.webkit.org/show_bug.cgi?id=191492
929
930         Reviewed by Alex Christensen.
931
932         * Carbon/HIWebView.mm:
933         (UpdateCommandStatus):
934         * Misc/WebNSFileManagerExtras.mm:
935         * Misc/WebNSURLExtras.mm:
936         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
937         * Plugins/WebBasePluginPackage.mm:
938         * Plugins/WebPluginContainerCheck.mm:
939         (-[WebPluginContainerCheck _continueWithPolicy:]):
940         * WebCoreSupport/WebCachedFramePlatformData.h:
941         (WebCachedFramePlatformData::clear):
942         * WebCoreSupport/WebDeviceOrientationClient.mm:
943         (WebDeviceOrientationClient::getProvider const):
944         * WebView/WebDelegateImplementationCaching.mm:
945         (CallDelegate):
946         (CallDelegateReturningBoolean):
947         (CallResourceLoadDelegateReturningBoolean):
948         (CallFormDelegate):
949         (CallFormDelegateReturningBoolean):
950         * WebView/WebHTMLView.mm:
951         * WebView/WebPDFRepresentation.mm:
952         * WebView/WebPolicyDelegate.mm:
953         (-[WebPolicyDecisionListener _usePolicy:]):
954         * WebView/WebView.mm:
955
956 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
957
958         Unreviewed, rolling out r238047.
959
960         Introduced layout test failures on iOS simulator.
961
962         Reverted changeset:
963
964         "[iOS] Draw caps lock indicator in password fields"
965         https://bugs.webkit.org/show_bug.cgi?id=190565
966         https://trac.webkit.org/changeset/238047
967
968 2018-11-09  Antti Koivisto  <antti@apple.com>
969
970         Use OptionSet for layout milestones
971         https://bugs.webkit.org/show_bug.cgi?id=191470
972
973         Reviewed by Dean Jackson.
974
975         * WebCoreSupport/WebFrameLoaderClient.h:
976         * WebCoreSupport/WebFrameLoaderClient.mm:
977         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
978         * WebView/WebView.mm:
979         (coreLayoutMilestones):
980         (kitLayoutMilestones):
981         (-[WebView _cacheFrameLoadDelegateImplementations]):
982         * WebView/WebViewInternal.h:
983
984 2018-11-09  Daniel Bates  <dabates@apple.com>
985
986         [iOS] Draw caps lock indicator in password fields
987         https://bugs.webkit.org/show_bug.cgi?id=190565
988         <rdar://problem/45262343>
989
990         Reviewed by Dean Jackson.
991
992         Update the caps lock state when a hardware keyboard is attached or detached.
993
994         * WebView/WebHTMLView.mm:
995         (hardwareKeyboardAvailabilityChangedCallback): Added.
996         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
997         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
998
999 2018-11-09  Daniel Bates  <dabates@apple.com>
1000
1001         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1002         action when forward delete is pressed outside a text field
1003         https://bugs.webkit.org/show_bug.cgi?id=190566
1004         <rdar://problem/45262367>
1005
1006         Reviewed by Wenson Hsieh.
1007
1008         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1009         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1010         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1011
1012         * WebView/WebHTMLView.mm:
1013         (-[WebHTMLView _handleEditingKeyEvent:]):
1014
1015 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1016
1017         Adopt Reveal Framework to replace Lookup
1018         https://bugs.webkit.org/show_bug.cgi?id=191097
1019         <rdar://problem/45924508>
1020
1021         Reviewed by Tim Horton.
1022
1023         Pass in what it needed to clear the textIndicators. This is better than
1024         the current notification structure.
1025
1026         * WebView/WebView.mm:
1027         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1028         (-[WebView _prepareForDictionaryLookup]):
1029
1030 2018-11-06  Justin Fan  <justin_fan@apple.com>
1031
1032         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1033         https://bugs.webkit.org/show_bug.cgi?id=191291
1034
1035         Reviewed by Myles Maxfield.
1036
1037         Properly disable WEBGPU on all non-Metal platforms for now.
1038
1039         * Configurations/FeatureDefines.xcconfig:
1040
1041 2018-11-02  Daniel Bates  <dabates@apple.com>
1042
1043         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1044         https://bugs.webkit.org/show_bug.cgi?id=190487
1045
1046         Reviewed by Tim Horton.
1047
1048         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1049         allow the default handling.
1050
1051         * WebView/WebHTMLView.mm:
1052         (-[WebHTMLView _handleEditingKeyEvent:]):
1053
1054 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1055
1056         Add a storage limit for IndexedDB
1057         https://bugs.webkit.org/show_bug.cgi?id=190598
1058         <rdar://problem/44654715>
1059
1060         Reviewed by Chris Dumez.
1061
1062         * Storage/WebDatabaseManager.mm:
1063         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1064         * Storage/WebDatabaseManagerPrivate.h:
1065
1066 2018-10-31  Antti Koivisto  <antti@apple.com>
1067
1068         Remove LayerFlushScheduler
1069         https://bugs.webkit.org/show_bug.cgi?id=191103
1070
1071         Reviewed by Anders Carlsson.
1072
1073         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1074         all the virtual cruft.
1075
1076         * WebView/WebViewData.h:
1077         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1078         (): Deleted.
1079         * WebView/WebViewData.mm:
1080         (currentRunLoop):
1081         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1082         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1083         (WebViewLayerFlushScheduler::schedule):
1084         (WebViewLayerFlushScheduler::invalidate):
1085         (WebViewLayerFlushScheduler::layerFlushCallback):
1086
1087 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1088
1089         Enable InstallAPI for iOS unconditionally
1090         https://bugs.webkit.org/show_bug.cgi?id=191043
1091         rdar://problem/32728423
1092
1093         Reviewed by Dan Bernstein.
1094
1095         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1096         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1097         shouldn't be processed by InstallAPI.
1098         * MigrateHeaders.make: Removed an obsolete workaround.
1099         * Misc/NSURLDownloadSPI.h: Added.
1100         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1101
1102 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1103
1104         Clean up some obsolete MAX_ALLOWED macros
1105         https://bugs.webkit.org/show_bug.cgi?id=190916
1106
1107         Reviewed by Tim Horton.
1108
1109         * WebView/WebHTMLView.mm:
1110         (-[WebHTMLView pressureChangeWithEvent:]):
1111         * WebView/WebPDFView.h:
1112
1113 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1114
1115         Unreviewed, rolling out r237600 and r237604.
1116         https://bugs.webkit.org/show_bug.cgi?id=191086
1117
1118         Breaks internal iOS builds (Requested by ryanhadd_ on
1119         #webkit).
1120
1121         Reverted changesets:
1122
1123         "Enable InstallAPI for iOS unconditionally"
1124         https://bugs.webkit.org/show_bug.cgi?id=191043
1125         https://trac.webkit.org/changeset/237600
1126
1127         "Build fix attempt after enabling InstallAPI for iOS."
1128         https://bugs.webkit.org/show_bug.cgi?id=191043
1129         https://trac.webkit.org/changeset/237604
1130
1131 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1132
1133         Enable InstallAPI for iOS unconditionally
1134         https://bugs.webkit.org/show_bug.cgi?id=191043
1135         rdar://problem/32728423
1136
1137         Reviewed by Dan Bernstein.
1138
1139         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1140         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1141         shouldn't be processed by InstallAPI.
1142         * MigrateHeaders.make: Removed an obsolete workaround.
1143         * Misc/NSURLDownloadSPI.h: Added.
1144         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1145
1146 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1147
1148         Modernize WebKit nibs and lprojs for localization's sake
1149         https://bugs.webkit.org/show_bug.cgi?id=190911
1150         <rdar://problem/45349466>
1151
1152         Reviewed by Dan Bernstein.
1153
1154         * Misc/WebNSControlExtras.m:
1155         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1156         NSWindow and its contents are both in the same scale space these days; avoid
1157         double-applying the scale factor, or you can't see the prompt.
1158
1159         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1160         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1161         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1162         NIB->XIB
1163
1164 2018-10-25  Antoine Quint  <graouts@apple.com>
1165
1166         [Web Animations] Turn Web Animations CSS Integration off by default
1167         https://bugs.webkit.org/show_bug.cgi?id=190901
1168
1169         Reviewed by Dean Jackson.
1170
1171         * WebView/WebPreferences.mm:
1172         (+[WebPreferences initialize]):
1173
1174 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1175
1176         Clean up some obsolete macOS version guards
1177         https://bugs.webkit.org/show_bug.cgi?id=190887
1178
1179         Reviewed by Dan Bernstein.
1180
1181         * Misc/WebNSPasteboardExtras.mm:
1182         (+[NSPasteboard _web_dragTypesForURL]):
1183         * WebCoreSupport/PopupMenuMac.mm:
1184         (PopupMenuMac::show):
1185         * WebCoreSupport/WebEditorClient.h:
1186         * WebCoreSupport/WebEditorClient.mm:
1187         (WebEditorClient::respondToChangedSelection):
1188         * WebView/WebPDFView.mm:
1189         (-[WebPDFView _clipViewForPDFDocumentView]):
1190
1191 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1192
1193         Turn on Conic Gradients
1194         https://bugs.webkit.org/show_bug.cgi?id=190810
1195
1196         Reviewed by Tim Horton.
1197
1198         * Configurations/FeatureDefines.xcconfig:
1199
1200 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1201
1202         Cleanup: MIMETypeRegistry functions
1203         https://bugs.webkit.org/show_bug.cgi?id=190838
1204
1205         Reviewed by Simon Fraser.
1206
1207         * Misc/WebNSPasteboardExtras.mm:
1208         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1209         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1210         because they were identical.
1211
1212         * WebView/WebHTMLRepresentation.mm:
1213         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1214         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1215         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1216         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1217         * WebView/WebView.mm:
1218         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1219         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1220         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1221
1222 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1223
1224         Fix false positive leaks when using custom -init methods that don't start with -init
1225         <https://webkit.org/b/190818>
1226         <rdar://problem/45476042>
1227
1228         Reviewed by Dan Bernstein.
1229
1230         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1231         it is accessible by both categories.
1232         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1233         NSError (WebKitInternal) category.  Add attribute to make this
1234         behave like an -init method.
1235         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1236         NSError (WebKitInternal) category.  Modernize method.  Replace
1237         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1238
1239 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1240
1241         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1242         https://bugs.webkit.org/show_bug.cgi?id=190729
1243
1244         Reviewed by Tim Horton.
1245
1246         * DOM/DOM.mm:
1247         (-[DOMNode boundingBox]):
1248         * DOM/DOMElement.mm:
1249         * DOM/DOMHTML.mm:
1250         * DOM/DOMInternal.mm:
1251         * DOM/DOMUIKitExtensions.mm:
1252         * DOM/WebDOMOperations.mm:
1253         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1254         * DefaultDelegates/WebDefaultEditingDelegate.m:
1255         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1256         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1257         * DefaultDelegates/WebDefaultUIDelegate.h:
1258         * DefaultDelegates/WebDefaultUIDelegate.mm:
1259         (-[WebDefaultUIDelegate webViewClose:]):
1260         (-[WebDefaultUIDelegate webViewFocus:]):
1261         (-[WebDefaultUIDelegate webViewUnfocus:]):
1262         (-[WebDefaultUIDelegate webViewIsResizable:]):
1263         (-[WebDefaultUIDelegate webView:setResizable:]):
1264         (-[WebDefaultUIDelegate webView:setFrame:]):
1265         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1266         * History/BackForwardList.h:
1267         * History/BackForwardList.mm:
1268         * History/WebBackForwardList.mm:
1269         (+[WebBackForwardList initialize]):
1270         (bumperCarBackForwardHackNeeded):
1271         * History/WebHistory.mm:
1272         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1273         (-[WebHistory _sendNotification:entries:]):
1274         (-[WebHistory loadFromURL:error:]):
1275         (-[WebHistory saveToURL:error:]):
1276         * History/WebHistoryItem.mm:
1277         (WKNotifyHistoryItemChanged):
1278         (+[WebHistoryItem initialize]):
1279         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1280         * History/WebURLsWithTitles.m:
1281         * Misc/WebCache.mm:
1282         (+[WebCache initialize]):
1283         * Misc/WebDownload.mm:
1284         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1285         * Misc/WebElementDictionary.mm:
1286         (+[WebElementDictionary initialize]):
1287         (+[WebElementDictionary initializeLookupTable]):
1288         * Misc/WebIconDatabase.mm:
1289         * Misc/WebKitNSStringExtras.mm:
1290         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1291         * Misc/WebKitVersionChecks.h:
1292         * Misc/WebKitVersionChecks.mm:
1293         (WebKitLinkedOnOrAfter):
1294         (WebKitLinkTimeVersion):
1295         * Misc/WebLocalizableStrings.mm:
1296         * Misc/WebNSControlExtras.h:
1297         * Misc/WebNSControlExtras.m:
1298         * Misc/WebNSEventExtras.m:
1299         * Misc/WebNSFileManagerExtras.mm:
1300         * Misc/WebNSImageExtras.h:
1301         * Misc/WebNSImageExtras.m:
1302         * Misc/WebNSPasteboardExtras.mm:
1303         * Misc/WebNSPrintOperationExtras.h:
1304         * Misc/WebNSPrintOperationExtras.m:
1305         * Misc/WebNSViewExtras.m:
1306         * Misc/WebNSWindowExtras.m:
1307         * Panels/WebAuthenticationPanel.h:
1308         * Panels/WebAuthenticationPanel.m:
1309         * Panels/WebPanelAuthenticationHandler.m:
1310         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1311         (+[WebHostedNetscapePluginView initialize]):
1312         * Plugins/WebBasePluginPackage.h:
1313         * Plugins/WebBasePluginPackage.mm:
1314         * Plugins/WebJavaPlugIn.h:
1315         * Plugins/WebPluginContainerCheck.mm:
1316         * Plugins/WebPluginController.h:
1317         * Plugins/WebPluginController.mm:
1318         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1319         (-[WebPluginController addPlugin:]):
1320         (-[WebPluginController destroyPlugin:]):
1321         (-[WebPluginController destroyAllPlugins]):
1322         * Plugins/WebPluginDatabase.mm:
1323         (+[WebPluginDatabase _defaultPlugInPaths]):
1324         * Plugins/WebPluginPackage.mm:
1325         (-[WebPluginPackage initWithPath:]):
1326         * Storage/WebDatabaseManager.mm:
1327         (-[WebDatabaseManager deleteAllDatabases]):
1328         * Storage/WebDatabaseManagerClient.h:
1329         * Storage/WebDatabaseManagerClient.mm:
1330         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1331         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1332         * Storage/WebStorageManager.mm:
1333         (-[WebStorageManager deleteAllOrigins]):
1334         (WebKitInitializeStorageIfNecessary):
1335         * WebCoreSupport/WebAlternativeTextClient.h:
1336         * WebCoreSupport/WebApplicationCache.mm:
1337         (applicationCacheBundleIdentifier):
1338         * WebCoreSupport/WebChromeClient.h:
1339         * WebCoreSupport/WebChromeClient.mm:
1340         (WebChromeClient::setWindowRect):
1341         (WebChromeClient::windowRect):
1342         (WebChromeClient::takeFocus):
1343         (WebChromeClient::addMessageToConsole):
1344         (WebChromeClient::enableSuddenTermination):
1345         (WebChromeClient::disableSuddenTermination):
1346         (WebChromeClient::createPopupMenu const):
1347         (WebChromeClient::createSearchPopupMenu const):
1348         (WebChromeClient::shouldPaintEntireContents const):
1349         (WebChromeClient::supportsVideoFullscreen):
1350         (WebChromeClient::supportsFullScreenForElement):
1351         (WebChromeClient::enterFullScreenForElement):
1352         (WebChromeClient::exitFullScreenForElement):
1353         * WebCoreSupport/WebContextMenuClient.mm:
1354         * WebCoreSupport/WebDragClient.mm:
1355         * WebCoreSupport/WebEditorClient.h:
1356         * WebCoreSupport/WebEditorClient.mm:
1357         (+[WebUndoStep initialize]):
1358         (updateFontPanel):
1359         (WebEditorClient::didBeginEditing):
1360         (WebEditorClient::respondToChangedContents):
1361         (WebEditorClient::respondToChangedSelection):
1362         (WebEditorClient::canceledComposition):
1363         (WebEditorClient::didEndEditing):
1364         (WebEditorClient::didWriteSelectionToPasteboard):
1365         (attributesForAttributedStringConversion):
1366         (WebEditorClient::setInsertionPasteboard):
1367         (WebEditorClient::registerUndoOrRedoStep):
1368         (WebEditorClient::handleKeyboardEvent):
1369         (WebEditorClient::handleInputMethodKeydown):
1370         (WebEditorClient::textDidChangeInTextField):
1371         (WebEditorClient::requestCheckingOfString):
1372         * WebCoreSupport/WebFrameLoaderClient.h:
1373         * WebCoreSupport/WebFrameLoaderClient.mm:
1374         (WebFrameLoaderClient::detachedFromParent2):
1375         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1376         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1377         (WebFrameLoaderClient::dispatchWillSendRequest):
1378         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1379         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1380         (WebFrameLoaderClient::willCacheResponse const):
1381         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1382         (WebFrameLoaderClient::dispatchDidFinishLoading):
1383         (WebFrameLoaderClient::dispatchDidFailLoading):
1384         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1385         (WebFrameLoaderClient::dispatchWillClose):
1386         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1387         (WebFrameLoaderClient::dispatchDidCommitLoad):
1388         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1389         (WebFrameLoaderClient::dispatchDidFailLoad):
1390         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1391         (WebFrameLoaderClient::dispatchDidFinishLoad):
1392         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1393         (WebFrameLoaderClient::willChangeTitle):
1394         (WebFrameLoaderClient::didChangeTitle):
1395         (WebFrameLoaderClient::didReplaceMultipartContent):
1396         (WebFrameLoaderClient::updateGlobalHistory):
1397         (WebFrameLoaderClient::saveViewStateToItem):
1398         (WebFrameLoaderClient::restoreViewState):
1399         (WebFrameLoaderClient::provisionalLoadStarted):
1400         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1401         (WebFrameLoaderClient::setTitle):
1402         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1403         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1404         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1405         (WebFrameLoaderClient::didRestoreFromPageCache):
1406         (WebFrameLoaderClient::actionDictionary const):
1407         (WebFrameLoaderClient::createPlugin):
1408         (WebFrameLoaderClient::getLoadDecisionForIcons):
1409         (WebFrameLoaderClient::finishedLoadingIcon):
1410         (+[WebFramePolicyListener initialize]):
1411         * WebCoreSupport/WebFrameNetworkingContext.mm:
1412         * WebCoreSupport/WebGeolocationClient.h:
1413         * WebCoreSupport/WebGeolocationClient.mm:
1414         (WebGeolocationClient::requestPermission):
1415         * WebCoreSupport/WebInspectorClient.h:
1416         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1417         * WebCoreSupport/WebNotificationClient.mm:
1418         * WebCoreSupport/WebOpenPanelResultListener.mm:
1419         * WebCoreSupport/WebPlatformStrategies.h:
1420         * WebCoreSupport/WebPlatformStrategies.mm:
1421         * WebCoreSupport/WebProgressTrackerClient.h:
1422         * WebCoreSupport/WebProgressTrackerClient.mm:
1423         (WebProgressTrackerClient::progressStarted):
1424         (WebProgressTrackerClient::progressEstimateChanged):
1425         (WebProgressTrackerClient::progressFinished):
1426         * WebCoreSupport/WebSecurityOrigin.mm:
1427         * WebInspector/WebNodeHighlight.h:
1428         * WebInspector/WebNodeHighlight.mm:
1429         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1430         (-[WebNodeHighlight dealloc]):
1431         (-[WebNodeHighlight attach]):
1432         * WebInspector/WebNodeHighlightView.h:
1433         * WebInspector/WebNodeHighlightView.mm:
1434         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1435         (-[WebNodeHighlightView dealloc]):
1436         * WebInspector/WebNodeHighlighter.mm:
1437         (-[WebNodeHighlighter highlight]):
1438         * WebView/WebArchive.mm:
1439         (+[WebArchivePrivate initialize]):
1440         * WebView/WebClipView.h:
1441         * WebView/WebDataSource.mm:
1442         (WebDataSourcePrivate::WebDataSourcePrivate):
1443         (+[WebDataSource initialize]):
1444         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1445         (-[WebDataSource _makeRepresentation]):
1446         * WebView/WebDelegateImplementationCaching.h:
1447         * WebView/WebDelegateImplementationCaching.mm:
1448         (CallDelegate):
1449         (CallDelegateReturningFloat):
1450         (CallDelegateReturningBoolean):
1451         (CallUIDelegate):
1452         (CallUIDelegateReturningFloat):
1453         (CallUIDelegateReturningBoolean):
1454         (CallFrameLoadDelegate):
1455         (CallFrameLoadDelegateReturningBoolean):
1456         (CallResourceLoadDelegate):
1457         (CallScriptDebugDelegate):
1458         (CallFormDelegate):
1459         (CallFormDelegateReturningBoolean):
1460         * WebView/WebDeviceOrientation.mm:
1461         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1462         * WebView/WebDocumentInternal.h:
1463         * WebView/WebDocumentLoaderMac.mm:
1464         (needsDataLoadWorkaround):
1465         * WebView/WebDynamicScrollBarsViewInternal.h:
1466         * WebView/WebFormDelegate.m:
1467         * WebView/WebFrame.mm:
1468         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1469         (-[WebFrame _unmarkAllMisspellings]):
1470         (-[WebFrame _paintBehaviorForDestinationContext:]):
1471         (-[WebFrame _drawRect:contentsOnly:]):
1472         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1473         (-[WebFrame _scrollDOMRangeToVisible:]):
1474         (-[WebFrame _bodyBackgroundColor]):
1475         (-[WebFrame accessibilityRoot]):
1476         (needsMicrosoftMessengerDOMDocumentWorkaround):
1477         * WebView/WebFrameInternal.h:
1478         * WebView/WebFrameView.mm:
1479         (-[WebFrameView _setDocumentView:]):
1480         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1481         (-[WebFrameView _viewClassForMIMEType:]):
1482         (-[WebFrameView initWithFrame:]):
1483         (-[WebFrameView drawRect:]):
1484         (-[WebFrameView _firstResponderIsFormControl]):
1485         (-[WebFrameView keyDown:keyDown:]):
1486         (-[WebFrameView _isScrollable]):
1487         * WebView/WebFullScreenController.h:
1488         * WebView/WebFullScreenController.mm:
1489         * WebView/WebHTMLRepresentation.mm:
1490         * WebView/WebHTMLView.mm:
1491         (-[WebHTMLView hitTest:]):
1492         (-[WebHTMLView initWithFrame:]):
1493         (-[WebHTMLView dealloc]):
1494         (-[WebHTMLView addSubview:]):
1495         (-[WebHTMLView mouseDown:]):
1496         (-[WebHTMLView mouseUp:]):
1497         (-[WebHTMLView resignFirstResponder]):
1498         (-[WebHTMLView accessibilityHitTest:]):
1499         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1500         * WebView/WebHTMLViewInternal.h:
1501         * WebView/WebIndicateLayer.h:
1502         * WebView/WebIndicateLayer.mm:
1503         * WebView/WebMediaPlaybackTargetPicker.h:
1504         * WebView/WebMediaPlaybackTargetPicker.mm:
1505         * WebView/WebPDFDocumentExtras.h:
1506         * WebView/WebPDFDocumentExtras.mm:
1507         * WebView/WebPDFRepresentation.h:
1508         * WebView/WebPDFRepresentation.mm:
1509         * WebView/WebPDFView.h:
1510         * WebView/WebPreferences.mm:
1511         (cacheModelForMainBundle):
1512         (WebPreferencesPrivate::WebPreferencesPrivate):
1513         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
1514         (-[WebPreferences encodeWithCoder:]):
1515         (+[WebPreferences standardPreferences]):
1516         (+[WebPreferences initialize]):
1517         (-[WebPreferences _valueForKey:]):
1518         (-[WebPreferences _setStringValue:forKey:]):
1519         (-[WebPreferences _setIntegerValue:forKey:]):
1520         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1521         (-[WebPreferences _setFloatValue:forKey:]):
1522         (-[WebPreferences _setBoolValue:forKey:]):
1523         (-[WebPreferences _setLongLongValue:forKey:]):
1524         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1525         (-[WebPreferences _postCacheModelChangedNotification]):
1526         (-[WebPreferences _postPreferencesChangedNotification]):
1527         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1528         (-[WebPreferences setStorageBlockingPolicy:]):
1529         * WebView/WebResource.mm:
1530         (+[WebResourcePrivate initialize]):
1531         * WebView/WebTextCompletionController.h:
1532         * WebView/WebTextIterator.mm:
1533         (+[WebTextIteratorPrivate initialize]):
1534         * WebView/WebView.mm:
1535         (shouldEnableLoadDeferring):
1536         (shouldRestrictWindowFocus):
1537         (shouldRespectPriorityInCSSAttributeSetters):
1538         (shouldUseLegacyBackgroundSizeShorthandBehavior):
1539         (shouldAllowPictureInPictureMediaPlayback):
1540         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
1541         (shouldAllowWindowOpenWithoutUserGesture):
1542         (shouldConvertInvalidURLsToBlank):
1543         (shouldRequireUserGestureToLoadVideo):
1544         (-[WebView _commonInitializationWithFrameName:groupName:]):
1545         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
1546         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
1547         (-[WebView _closePluginDatabases]):
1548         (-[WebView _closeWithFastTeardown]):
1549         (-[WebView _close]):
1550         (+[WebView _MIMETypeForFile:]):
1551         (-[WebView setShowingInspectorIndication:]):
1552         (-[WebView _setFormDelegate:]):
1553         (-[WebView _needsPreHTML5ParserQuirks]):
1554         (-[WebView _preferencesChangedNotification:]):
1555         (-[WebView _preferencesChanged:]):
1556         (-[WebView _cacheResourceLoadDelegateImplementations]):
1557         (-[WebView _cacheFrameLoadDelegateImplementations]):
1558         (-[WebView _policyDelegateForwarder]):
1559         (-[WebView _UIDelegateForwarder]):
1560         (-[WebView _editingDelegateForwarder]):
1561         (-[WebView _updateActiveState]):
1562         (-[_WebSafeForwarder forwardInvocation:]):
1563         (+[WebView initialize]):
1564         (-[WebView _pluginForMIMEType:]):
1565         (-[WebView _pluginForExtension:]):
1566         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
1567         (+[WebView canShowMIMETypeAsHTML:]):
1568         (-[WebView _initWithArguments:]):
1569         (-[WebView initWithFrame:frameName:groupName:]):
1570         (-[WebView dealloc]):
1571         (-[WebView close]):
1572         (-[WebView viewDidMoveToWindow]):
1573         (-[WebView setUIDelegate:]):
1574         (-[WebView setResourceLoadDelegate:]):
1575         (-[WebView setPolicyDelegate:]):
1576         (-[WebView setFrameLoadDelegate:]):
1577         (-[WebView goBack]):
1578         (-[WebView goForward]):
1579         (-[WebView stringByEvaluatingJavaScriptFromString:]):
1580         (-[WebView setHostWindow:]):
1581         (-[WebView becomeFirstResponder]):
1582         (+[WebView _cacheModelChangedNotification:]):
1583         (-[WebView _frameViewAtWindowPoint:]):
1584         (+[WebView _preflightSpellCheckerNow:]):
1585         (+[WebView _preflightSpellChecker]):
1586         (-[WebView canGoBack]):
1587         (-[WebView canGoForward]):
1588         (-[WebView stopLoading:]):
1589         (-[WebView reload:]):
1590         (-[WebView setMainFrameDocumentReady:]):
1591         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1592         (-[WebView setContinuousSpellCheckingEnabled:]):
1593         (-[WebView undoManager]):
1594         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
1595         (-[WebView isAutomaticLinkDetectionEnabled]):
1596         (-[WebView isAutomaticDashSubstitutionEnabled]):
1597         (-[WebView isAutomaticTextReplacementEnabled]):
1598         (-[WebView isAutomaticSpellingCorrectionEnabled]):
1599         (+[WebView _setCacheModel:]):
1600         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1601         (-[WebView _keyboardUIMode]):
1602         (LayerFlushController::flushLayers):
1603         (-[WebView _scheduleCompositingLayerFlush]):
1604         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1605         (-[WebView fullScreenPlaceholderView]):
1606         (WebInstallMemoryPressureHandler):
1607         * WebView/WebViewData.h:
1608         * WebView/WebViewData.mm:
1609         (+[WebViewPrivate initialize]):
1610         (-[WebViewPrivate init]):
1611         (-[WebViewPrivate dealloc]):
1612         * WebView/WebViewInternal.h:
1613
1614 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1615
1616         Clean up FrameLoader two-state enums
1617         https://bugs.webkit.org/show_bug.cgi?id=190731
1618
1619         Reviewed by Chris Dumez.
1620
1621         * WebCoreSupport/WebFrameLoaderClient.h:
1622         * WebCoreSupport/WebFrameLoaderClient.mm:
1623         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1624
1625 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1626
1627         Unreviewed, rolling out r237137.
1628
1629         SPI is actually used
1630
1631         Reverted changeset:
1632
1633         "Remove unused WebFrame._loadType"
1634         https://bugs.webkit.org/show_bug.cgi?id=190583
1635         https://trac.webkit.org/changeset/237137
1636
1637 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1638
1639         Enable the datalist element by default on iOS and macOS
1640         https://bugs.webkit.org/show_bug.cgi?id=190594
1641         <rdar://problem/45281159>
1642
1643         Reviewed by Ryosuke Niwa and Tim Horton.
1644
1645         * Configurations/FeatureDefines.xcconfig:
1646
1647 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1648
1649         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1650         https://bugs.webkit.org/show_bug.cgi?id=190675
1651
1652         Reviewed by Chris Dumez.
1653
1654         * History/BackForwardList.h:
1655         * History/BackForwardList.mm:
1656         (BackForwardList::backItem):
1657         (BackForwardList::currentItem):
1658         (BackForwardList::forwardItem):
1659         (BackForwardList::backListCount const):
1660         (BackForwardList::forwardListCount const):
1661         (BackForwardList::itemAtIndex):
1662         * History/WebBackForwardList.mm:
1663         (-[WebBackForwardList backItem]):
1664         (-[WebBackForwardList currentItem]):
1665         (-[WebBackForwardList forwardItem]):
1666         (-[WebBackForwardList itemAtIndex:]):
1667
1668 2018-10-16  Timothy Hatcher  <timothy@apple.com>
1669
1670         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
1671         https://bugs.webkit.org/show_bug.cgi?id=190526
1672         rdar://problem/45230140
1673
1674         Reviewed by Dean Jackson.
1675
1676         * WebCoreSupport/WebEditorClient.mm:
1677         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
1678
1679 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
1680
1681         Implement feature flag and bindings for CSS Painting API
1682         https://bugs.webkit.org/show_bug.cgi?id=190237
1683
1684         Reviewed by Ryosuke Niwa.
1685
1686         * Configurations/FeatureDefines.xcconfig:
1687
1688 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1689
1690         Replace HistoryItem* with HistoryItem& where possible
1691         https://bugs.webkit.org/show_bug.cgi?id=190617
1692
1693         Reviewed by Chris Dumez.
1694
1695         * History/BackForwardList.h:
1696         * History/BackForwardList.mm:
1697         (BackForwardList::goToItem):
1698         * History/WebBackForwardList.mm:
1699         (-[WebBackForwardList goToItem:]):
1700         * History/WebHistoryItem.mm:
1701         (WKNotifyHistoryItemChanged):
1702         * History/WebHistoryItemInternal.h:
1703
1704 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1705
1706         Remove unused WebHistoryItem._transientPropertyForKey
1707         https://bugs.webkit.org/show_bug.cgi?id=190606
1708
1709         Reviewed by Chris Dumez.
1710
1711         * History/WebHistoryItem.mm:
1712         * History/WebHistoryItemPrivate.h:
1713
1714 2018-10-15  Justin Fan  <justin_fan@apple.com>
1715
1716         Add WebGPU 2018 feature flag and experimental feature flag
1717         https://bugs.webkit.org/show_bug.cgi?id=190509
1718
1719         Reviewed by Dean Jackson.
1720
1721         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
1722         for the 2018 WebGPU prototype.
1723
1724         * Configurations/FeatureDefines.xcconfig:
1725         * WebView/WebPreferenceKeysPrivate.h:
1726         * WebView/WebPreferences.mm:
1727         (+[WebPreferences initialize]):
1728         (-[WebPreferences webGPUEnabled]):
1729         (-[WebPreferences setWebGPUEnabled:]):
1730         * WebView/WebPreferencesPrivate.h:
1731         * WebView/WebView.mm:
1732         (-[WebView _preferencesChanged:]):
1733
1734 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1735
1736         Fix iOS build after r237157
1737
1738         * WebView/WebView.mm:
1739         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1740
1741 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1742
1743         Modernize BackForwardClient.h
1744         https://bugs.webkit.org/show_bug.cgi?id=190610
1745
1746         Reviewed by Chris Dumez.
1747
1748         * History/BackForwardList.h:
1749         * History/BackForwardList.mm:
1750         (BackForwardList::backListCount const):
1751         (BackForwardList::forwardListCount const):
1752         (BackForwardList::backListCount): Deleted.
1753         (BackForwardList::forwardListCount): Deleted.
1754         * History/WebBackForwardList.mm:
1755         (-[WebBackForwardList init]):
1756         * WebCoreSupport/WebFrameLoaderClient.mm:
1757         (WebFrameLoaderClient::canCachePage const):
1758         * WebView/WebFrameView.mm:
1759         (-[WebFrameView keyDown:keyDown:]):
1760         * WebView/WebView.mm:
1761         (-[WebView _commonInitializationWithFrameName:groupName:]):
1762         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1763         (-[WebView _loadBackForwardListFromOtherView:]):
1764         (-[WebView initWithCoder:]):
1765         (-[WebView encodeWithCoder:]):
1766         (-[WebView backForwardList]):
1767         (-[WebView setMaintainsBackForwardList:]):
1768
1769 2018-10-15  Timothy Hatcher  <timothy@apple.com>
1770
1771         Add support for prefers-color-scheme media query
1772         https://bugs.webkit.org/show_bug.cgi?id=190499
1773         rdar://problem/45212025
1774
1775         Reviewed by Dean Jackson.
1776
1777         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
1778
1779 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1780
1781         Remove unused WebView._globalHistoryItem
1782         https://bugs.webkit.org/show_bug.cgi?id=190601
1783
1784         Reviewed by Chris Dumez.
1785
1786         * WebCoreSupport/WebFrameLoaderClient.h:
1787         * WebCoreSupport/WebFrameLoaderClient.mm:
1788         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1789         * WebView/WebView.mm:
1790         (-[WebView _globalHistoryItem]): Deleted.
1791         (-[WebView _setGlobalHistoryItem:]): Deleted.
1792         * WebView/WebViewData.h:
1793         * WebView/WebViewInternal.h:
1794         * WebView/WebViewPrivate.h:
1795
1796 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1797
1798         Remove unused parameters from FrameLoaderClient::createFrame
1799         https://bugs.webkit.org/show_bug.cgi?id=190587
1800
1801         Reviewed by Chris Dumez.
1802
1803         * WebCoreSupport/WebFrameLoaderClient.h:
1804         * WebCoreSupport/WebFrameLoaderClient.mm:
1805         (WebFrameLoaderClient::createFrame):
1806
1807 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1808
1809         Remove unused WebFrame._loadType
1810         https://bugs.webkit.org/show_bug.cgi?id=190583
1811
1812         Reviewed by Chris Dumez.
1813
1814         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
1815
1816         * WebView/WebFrame.mm:
1817         (toWebFrameLoadType): Deleted.
1818         (-[WebFrame _loadType]): Deleted.
1819         * WebView/WebFramePrivate.h:
1820
1821 2018-10-15  Chris Dumez  <cdumez@apple.com>
1822
1823         Restrict browsing context lookup by name to frames that are related to one another
1824         https://bugs.webkit.org/show_bug.cgi?id=190475
1825
1826         Reviewed by Alex Christensen.
1827
1828         * WebView/WebFrame.mm:
1829         (-[WebFrame findFrameNamed:]):
1830
1831 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1832
1833         Remove InjectedBundle processing of back/forward lists
1834         https://bugs.webkit.org/show_bug.cgi?id=190459
1835
1836         Reviewed by Chris Dumez.
1837
1838         * WebCoreSupport/WebFrameLoaderClient.h:
1839         * WebCoreSupport/WebFrameLoaderClient.mm:
1840         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1841
1842 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1843
1844         [JSC] Remove Option::useAsyncIterator
1845         https://bugs.webkit.org/show_bug.cgi?id=190567
1846
1847         Reviewed by Saam Barati.
1848
1849         * Configurations/FeatureDefines.xcconfig:
1850
1851 2018-10-12  Alex Christensen  <achristensen@webkit.org>
1852
1853         Allow encoding of small enum classes
1854         https://bugs.webkit.org/show_bug.cgi?id=190531
1855
1856         Reviewed by Tim Horton.
1857
1858         * WebCoreSupport/WebFrameLoaderClient.mm:
1859         (-[WebFramePolicyListener dealloc]):
1860
1861 2018-10-11  Keith Rollin  <krollin@apple.com>
1862
1863         CURRENT_ARCH should not be used in Run Script phase.
1864         https://bugs.webkit.org/show_bug.cgi?id=190407
1865         <rdar://problem/45133556>
1866
1867         Reviewed by Alexey Proskuryakov.
1868
1869         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
1870         CURRENT_ARCH is not well-defined during this phase (and may even have
1871         the value "undefined") since this phase is run just once per build
1872         rather than once per supported architecture. Migrate away from
1873         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
1874         performing an operation for each value, or by picking the first entry
1875         in ARCHS and using that as a representative value.
1876
1877         * Configurations/WebKitLegacy.xcconfig: When generating
1878         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
1879         macosx platforms.
1880
1881         * MigrateHeaders.make:
1882         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
1883         generate one for each architecture in ARCHS.
1884
1885 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1886
1887         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
1888         https://bugs.webkit.org/show_bug.cgi?id=190429
1889
1890         Reviewed by Saam Barati.
1891
1892         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
1893
1894         * WebView/WebPDFRepresentation.mm:
1895         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
1896
1897 2018-10-08  Justin Fan  <justin_fan@apple.com>
1898
1899         WebGPU: Rename old WebGPU prototype to WebMetal
1900         https://bugs.webkit.org/show_bug.cgi?id=190325
1901         <rdar://problem/44990443>
1902
1903         Reviewed by Dean Jackson.
1904
1905         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
1906
1907         * Configurations/FeatureDefines.xcconfig:
1908         * WebView/WebPreferenceKeysPrivate.h:
1909         * WebView/WebPreferences.mm:
1910         (+[WebPreferences initialize]):
1911         (-[WebPreferences webMetalEnabled]):
1912         (-[WebPreferences setWebMetalEnabled:]):
1913         (-[WebPreferences webGPUEnabled]): Deleted.
1914         (-[WebPreferences setWebGPUEnabled:]): Deleted.
1915         * WebView/WebPreferencesPrivate.h:
1916         * WebView/WebView.mm:
1917         (-[WebView _preferencesChanged:]):
1918
1919 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
1920
1921         Make <input type=color> a runtime enabled (on-by-default) feature
1922         https://bugs.webkit.org/show_bug.cgi?id=189162
1923
1924         Reviewed by Wenson Hsieh and Tim Horton.
1925
1926         * Configurations/FeatureDefines.xcconfig:
1927
1928 2018-10-07  Dan Bernstein  <mitz@apple.com>
1929
1930         Fixed building with the latest macOS SDK
1931
1932         * Plugins/WebNetscapePluginPackage.mm:
1933         (-[WebNetscapePluginPackage openResourceFile]):
1934         (-[WebNetscapePluginPackage closeResourceFile:]):
1935
1936 2018-10-04  Dan Bernstein  <mitz@apple.com>
1937
1938         More Carbon build-fixing.
1939
1940         * Carbon/CarbonWindowAdapter.mm:
1941         (-[CarbonWindowAdapter _destroyRealWindow:]):
1942         (-[CarbonWindowAdapter _growBoxRect]):
1943
1944 2018-10-04  Dan Bernstein  <mitz@apple.com>
1945
1946         Retried to fix 32-bit macOS builds after r236846.
1947
1948         * WebView/WebHTMLView.mm:
1949         (-[WebHTMLView setMarkedText:selectedRange:]):
1950
1951 2018-10-04  Dan Bernstein  <mitz@apple.com>
1952
1953         Retried to fix 32-bit macOS builds after r236846.
1954
1955         * Carbon/HIWebView.mm:
1956         (ActiveStateChanged):
1957
1958 2018-10-04  Dan Bernstein  <mitz@apple.com>
1959
1960         Tried to fix 32-bit macOS builds after r236846.
1961
1962         * Carbon/HIWebView.mm:
1963         (_NSSelectorForHICommand):
1964
1965 2018-10-04  Dan Bernstein  <mitz@apple.com>
1966
1967         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
1968         https://bugs.webkit.org/show_bug.cgi?id=190250
1969
1970         Reviewed by Andy Estes.
1971
1972         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
1973           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
1974           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
1975           an earlier line set it to YES.
1976
1977         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
1978         changes below.
1979
1980         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
1981           provides some missing method declarations.
1982
1983         * Misc/WebDownload.mm:
1984         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
1985           a deprecated method.
1986
1987         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
1988
1989         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
1990           other code in the file uses a method from it.
1991
1992         * Plugins/WebBaseNetscapePluginView.mm:
1993         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
1994           a deprecated method.
1995
1996         * Plugins/WebPluginController.mm:
1997         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
1998           around use of a selector that may be present in some WebKit client.
1999
2000         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2001           method declarations.
2002
2003         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2004           from here.
2005
2006         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2007           missing method declarations.
2008
2009         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2010           from here.
2011
2012         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2013           call from here.
2014         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2015           an obsolete delegate method for binary compatibility.
2016         (pluginView): Ditto.
2017
2018         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2019           call from here.
2020
2021         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2022           WebDeviceOrientationProviderMock protocol.
2023
2024         * WebView/WebDeviceOrientationProviderMock.mm:
2025         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2026           main @implementation.
2027
2028         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2029           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2030
2031         * WebView/WebDynamicScrollBarsView.mm:
2032         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2033           of a deprecated method.
2034
2035         * WebView/WebHTMLView.mm:
2036         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2037           selector warning around action methods that are not declared anywhere in WebKit.
2038
2039         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2040           about implementing this deprecated method.
2041         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2042         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2043         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2044         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2045         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2046         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2047         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2048         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2049         (-[WebHTMLView doCommandBySelector:]): Ditto.
2050         (-[WebHTMLView insertText:]): Ditto.
2051
2052         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2053
2054         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2055
2056         * WebView/WebPDFView.h: Removed previewView ivar.
2057
2058         * WebView/WebPDFView.mm:
2059           Removed declaration of FileInternal category and merged its implementation with the main
2060           implementation.
2061         (-[WebPDFView dealloc]): Removed previewView ivar.
2062         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2063           exist in macOS versions we support.
2064         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2065         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2066           action methods internal to PDFKit.
2067         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2068         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2069
2070         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2071           call on macOS, even though in r86988 we started calling different methods on iOS.
2072
2073         * WebView/WebView.mm:
2074         - Imported headers that declare delegate methods that we call.
2075         - Removed declaration of WebFileInternal category and merged its implementation with the
2076           main implementation.
2077         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2078           category, which made them impossible to call from the main implementation. Moved those
2079           into the main implementation. One of those had to be declared in a class extension,
2080           because it is called from a method implemented in the WebPrivate category, and that
2081           category’s implementation appears first in the file.
2082
2083         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2084           around use of obsolete delegate method for binary compatibility.
2085
2086         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2087
2088 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2089
2090         Runtime flag and IDL for MediaRecorder
2091         https://bugs.webkit.org/show_bug.cgi?id=190018
2092
2093         Reviewed by Youenn Fablet and Chris Dumez.
2094
2095         * WebView/WebPreferenceKeysPrivate.h:
2096         * WebView/WebPreferences.mm:
2097         (+[WebPreferences initialize]):
2098         (-[WebPreferences mediaRecorderEnabled]):
2099         (-[WebPreferences setMediaRecorderEnabled:]):
2100         * WebView/WebPreferencesPrivate.h:
2101         * WebView/WebView.mm:
2102         (-[WebView _preferencesChanged:]):
2103
2104 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2105
2106         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2107         https://bugs.webkit.org/show_bug.cgi?id=190238
2108
2109         Reviewed by Antti Koivisto.
2110
2111         Enabled the feature by default.
2112
2113         * WebView/WebPreferences.mm:
2114         (+[WebPreferences initialize]):
2115
2116 2018-10-01  Dean Jackson  <dino@apple.com>
2117
2118         [macOS] Switching to discrete GPU should be done in the UI process
2119         https://bugs.webkit.org/show_bug.cgi?id=189361
2120         <rdar://problem/43949622>
2121
2122         Reviewed by Simon Fraser.
2123
2124         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2125         not support swapping to the discrete GPU in this configuration.
2126
2127         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2128         (WebKit::WebSwitchingGPUClient::singleton):
2129         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2130         * WebView/WebView.mm:
2131         (-[WebView _commonInitializationWithFrameName:groupName:]):
2132
2133 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2134
2135         Remove ParsedURLString
2136         https://bugs.webkit.org/show_bug.cgi?id=190154
2137
2138         Reviewed by Chris Dumez.
2139
2140         * WebView/WebScriptDebugger.mm:
2141         (toNSURL):
2142
2143 2018-10-01  Dean Jackson  <dino@apple.com>
2144
2145         Remove CSS Animation Triggers
2146         https://bugs.webkit.org/show_bug.cgi?id=190175
2147         <rdar://problem/44925626>
2148
2149         Reviewed by Simon Fraser.
2150
2151         * Configurations/FeatureDefines.xcconfig:
2152
2153 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2154
2155         Unreviewed, rolling out r236624 and r236671.
2156         https://bugs.webkit.org/show_bug.cgi?id=190207
2157
2158         The change in r236624 introduced crashes on the bots
2159         (Requested by ryanhaddad on #webkit).
2160
2161         Reverted changesets:
2162
2163         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2164         https://bugs.webkit.org/show_bug.cgi?id=188747
2165         https://trac.webkit.org/changeset/236624
2166
2167         "Unify implementation in VideoFullscreenInterfaceAVKit"
2168         https://bugs.webkit.org/show_bug.cgi?id=190091
2169         https://trac.webkit.org/changeset/236671
2170
2171 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2172
2173         URL should not use TextEncoding internally
2174         https://bugs.webkit.org/show_bug.cgi?id=190111
2175
2176         Reviewed by Andy Estes.
2177
2178         * Misc/WebNSURLExtras.mm:
2179
2180 2018-09-28  Jer Noble  <jer.noble@apple.com>
2181
2182         Refactoring: eliminate raw pointer usage in Fullscreen code
2183         https://bugs.webkit.org/show_bug.cgi?id=188747
2184         <rdar://problem/43541164>
2185
2186         Reviewed by Alex Christensen.
2187
2188         PlaybackSessionInterface no longer has an invalidate() method.
2189
2190         * WebView/WebView.mm:
2191         (-[WebView _clearPlaybackControlsManager]):
2192
2193 2018-09-28  Chris Dumez  <cdumez@apple.com>
2194
2195         Drop support for cross-origin-window-policy header
2196         https://bugs.webkit.org/show_bug.cgi?id=190081
2197
2198         Reviewed by Ryosuke Niwa.
2199
2200         * WebView/WebPreferenceKeysPrivate.h:
2201         * WebView/WebPreferences.mm:
2202         (+[WebPreferences initialize]):
2203         * WebView/WebPreferencesPrivate.h:
2204         * WebView/WebView.mm:
2205         (-[WebView _preferencesChanged:]):
2206
2207 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2208
2209         Rename createMarkup to serializePreservingVisualAppearance
2210         https://bugs.webkit.org/show_bug.cgi?id=190086
2211
2212         Reviewed by Wenson Hsieh.
2213
2214         * DOM/WebDOMOperations.mm:
2215         (-[DOMRange markupString]):
2216
2217 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2218
2219         Unreviewed, rolling out r236605.
2220         https://bugs.webkit.org/show_bug.cgi?id=190087
2221
2222         caused three API test timeouts (Requested by jernoble on
2223         #webkit).
2224
2225         Reverted changeset:
2226
2227         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2228         https://bugs.webkit.org/show_bug.cgi?id=188747
2229         https://trac.webkit.org/changeset/236605
2230
2231 2018-09-28  Jer Noble  <jer.noble@apple.com>
2232
2233         Refactoring: eliminate raw pointer usage in Fullscreen code
2234         https://bugs.webkit.org/show_bug.cgi?id=188747
2235         <rdar://problem/43541164>
2236
2237         Reviewed by Alex Christensen.
2238
2239         PlaybackSessionInterface no longer has an invalidate() method.
2240
2241         * WebView/WebView.mm:
2242         (-[WebView _clearPlaybackControlsManager]):
2243
2244 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2245
2246         Use enum class in createMarkup arguments
2247         https://bugs.webkit.org/show_bug.cgi?id=190028
2248
2249         Reviewed by Wenson Hsieh.
2250
2251         * DOM/WebDOMOperations.mm:
2252         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2253         (-[DOMRange markupString]): Ditto.
2254
2255 2018-09-27  Antoine Quint  <graouts@apple.com>
2256
2257         [Web Animations] Turn Web Animations with CSS integration on
2258         https://bugs.webkit.org/show_bug.cgi?id=184819
2259         <rdar://problem/39597337>
2260
2261         Reviewed by Dean Jackson.
2262
2263         * WebView/WebPreferences.mm:
2264         (+[WebPreferences initialize]):
2265
2266 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2267
2268         Selection should work across shadow boundary when initiated by a mouse drag
2269         https://bugs.webkit.org/show_bug.cgi?id=151380
2270         <rdar://problem/24363872>
2271
2272         Reviewed by Wenson Hsieh.
2273
2274         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2275
2276         * WebView/WebPreferenceKeysPrivate.h:
2277         * WebView/WebPreferences.mm:
2278         (+[WebPreferences initialize]):
2279         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2280         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2281         * WebView/WebPreferencesPrivate.h:
2282         * WebView/WebView.mm:
2283         (-[WebView _preferencesChanged:]):
2284
2285 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2286
2287         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2288         https://bugs.webkit.org/show_bug.cgi?id=189918
2289         Work towards <rdar://problem/44648705>
2290
2291         Reviewed by Tim Horton.
2292
2293         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2294
2295         * WebView/WebHTMLView.mm:
2296         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2297         (-[WebHTMLView _updateFontPanel]):
2298         * WebView/WebView.mm:
2299         (-[WebView typingAttributes]):
2300
2301 2018-09-17  Darin Adler  <darin@apple.com>
2302
2303         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2304         https://bugs.webkit.org/show_bug.cgi?id=189652
2305
2306         Reviewed by Saam Barati.
2307
2308         * WebView/WebPDFRepresentation.mm:
2309         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2310
2311 2018-09-14  Jer Noble  <jer.noble@apple.com>
2312
2313         Turn SourceBufferChangeTypeEnabled on by default
2314         https://bugs.webkit.org/show_bug.cgi?id=189527
2315
2316         Reviewed by Eric Carlson.
2317
2318         * WebView/WebPreferences.mm:
2319         (+[WebPreferences initialize]):
2320
2321 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2322
2323         Fix an internal build after r235935
2324         https://bugs.webkit.org/show_bug.cgi?id=188996
2325
2326         * Carbon/HIWebView.mm:
2327         (Draw):
2328         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2329
2330 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2331
2332         Add IGNORE_WARNING_.* macros
2333         https://bugs.webkit.org/show_bug.cgi?id=188996
2334
2335         Reviewed by Michael Catanzaro.
2336
2337         * Carbon/CarbonUtils.m:
2338         (PoolCleaner):
2339         * Carbon/CarbonWindowAdapter.mm:
2340         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2341         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2342         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2343         (-[CarbonWindowAdapter _termWindowIfOwner]):
2344         (-[CarbonWindowAdapter _windowMovedToRect:]):
2345         (-[CarbonWindowAdapter setContentView:]):
2346         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2347         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2348         * Carbon/CarbonWindowFrame.m:
2349         (-[CarbonWindowFrame title]):
2350         * Carbon/HIViewAdapter.m:
2351         (+[HIViewAdapter getHIViewForNSView:]):
2352         * Carbon/HIWebView.mm:
2353         (overrideCGContext):
2354         (restoreCGContext):
2355         (Draw):
2356         * DOM/DOM.mm:
2357         * History/WebHistory.mm:
2358         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2359         * History/WebHistoryItem.mm:
2360         (-[WebHistoryItem icon]):
2361         * Misc/WebKitNSStringExtras.mm:
2362         (-[NSString _web_drawAtPoint:font:textColor:]):
2363         * Misc/WebNSImageExtras.m:
2364         (-[NSImage _web_scaleToMaxSize:]):
2365         (-[NSImage _web_dissolveToFraction:]):
2366         * Misc/WebNSPasteboardExtras.mm:
2367         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2368         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2369         * Panels/WebAuthenticationPanel.m:
2370         (-[WebAuthenticationPanel loadNib]):
2371         * Plugins/Hosted/NetscapePluginHostManager.mm:
2372         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2373         (WebKit::NetscapePluginHostManager::didCreateWindow):
2374         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2375         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2376         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2377         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2378         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2379         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2380         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2381         (-[WebHostedNetscapePluginView drawRect:]):
2382         * Plugins/Hosted/WebTextInputWindowController.m:
2383         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2384         * Plugins/WebBaseNetscapePluginView.mm:
2385         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2386         * Plugins/WebNetscapePluginPackage.mm:
2387         (-[WebNetscapePluginPackage _tryLoad]):
2388         * Plugins/WebNetscapePluginView.mm:
2389         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2390         (-[WebNetscapePluginView sendDrawRectEvent:]):
2391         (-[WebNetscapePluginView drawRect:]):
2392         * Plugins/WebPluginController.mm:
2393         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2394         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2395         * WebCoreSupport/PopupMenuMac.mm:
2396         (PopupMenuMac::populate):
2397         * WebCoreSupport/WebAlternativeTextClient.h:
2398         * WebCoreSupport/WebDragClient.mm:
2399         (WebDragClient::startDrag):
2400         * WebCoreSupport/WebFrameLoaderClient.mm:
2401         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2402         (webGetNSImage):
2403         * WebInspector/WebNodeHighlight.mm:
2404         * WebInspector/WebNodeHighlightView.mm:
2405         (-[WebNodeHighlightView drawRect:]):
2406         * WebView/WebClipView.mm:
2407         (-[WebClipView initWithFrame:]):
2408         * WebView/WebFrame.mm:
2409         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2410         (-[WebFrame _drawRect:contentsOnly:]):
2411         (-[WebFrame accessibilityRoot]):
2412         * WebView/WebFullScreenController.mm:
2413         (-[WebFullScreenController enterFullScreen:]):
2414         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2415         (-[WebFullScreenController exitFullScreen]):
2416         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2417         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2418         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2419         * WebView/WebHTMLView.mm:
2420         (-[NSWindow _web_borderView]):
2421         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2422         (-[WebHTMLView _setAsideSubviews]):
2423         (-[WebHTMLView _autoscroll]):
2424         (-[WebHTMLView drawRect:]):
2425         (-[WebHTMLView mouseDown:]):
2426         (-[WebHTMLView mouseDragged:]):
2427         (-[WebHTMLView mouseUp:]):
2428         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2429         (-[WebHTMLView knowsPageRange:]):
2430         (-[WebHTMLView accessibilityHitTest:]):
2431         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2432         (-[WebHTMLView _colorAsString:]):
2433         (-[WebHTMLView copyFont:]):
2434         (-[WebHTMLView _executeSavedKeypressCommands]):
2435         (-[WebHTMLView attachRootLayer:]):
2436         (-[WebHTMLView textStorage]):
2437         (-[WebHTMLView _updateSelectionForInputManager]):
2438         * WebView/WebPDFView.mm:
2439         (_applicationInfoForMIMEType):
2440         (-[WebPDFView centerSelectionInVisibleArea:]):
2441         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2442         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2443         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2444         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2445         * WebView/WebTextCompletionController.mm:
2446         (-[WebTextCompletionController _buildUI]):
2447         (-[WebTextCompletionController _placePopupWindow:]):
2448         * WebView/WebVideoFullscreenController.mm:
2449         * WebView/WebVideoFullscreenHUDWindowController.mm:
2450         (createMediaUIBackgroundView):
2451         * WebView/WebView.mm:
2452         (-[WebTextListTouchBarViewController initWithWebView:]):
2453         (-[WebView _dispatchTileDidDraw:]):
2454         (-[WebView encodeWithCoder:]):
2455         (-[WebView mainFrameIcon]):
2456         (LayerFlushController::flushLayers):
2457         * WebView/WebWindowAnimation.mm:
2458         (setScaledFrameForWindow):
2459
2460 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2461
2462         Remove unused needsDestruction class variables from HashTraits
2463         https://bugs.webkit.org/show_bug.cgi?id=189490
2464
2465         Reviewed by Daniel Bates.
2466
2467         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2468
2469 2018-09-07  Frederic Wang  <fwang@igalia.com>
2470
2471         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2472         https://bugs.webkit.org/show_bug.cgi?id=182230
2473
2474         Reviewed by Simon Fraser.
2475
2476         * DOM/DOMDocument.mm:
2477         (-[DOMDocument scrollingElement]): Use the new name.
2478
2479 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2480
2481         Refactor WebCore::EditAction to be an 8-bit enum class
2482         https://bugs.webkit.org/show_bug.cgi?id=189383
2483
2484         Reviewed by Dan Bernstein.
2485
2486         * WebCoreSupport/WebEditorClient.mm:
2487         (undoNameForEditAction):
2488         * WebView/WebHTMLView.mm:
2489         (-[WebHTMLView pasteFont:]):
2490         (-[WebHTMLView changeFont:]):
2491         (-[WebHTMLView changeAttributes:]):
2492         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
2493         (-[WebHTMLView changeColor:]):
2494         * WebView/WebView.mm:
2495         (-[WebView setTypingStyle:]):
2496
2497 2018-09-06  Frederic Wang  <fwang@igalia.com>
2498
2499         Group options of scrollRectToVisible into a struct
2500         https://bugs.webkit.org/show_bug.cgi?id=189352
2501
2502         Reviewed by Simon Fraser.
2503
2504         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
2505         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
2506         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
2507
2508 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2509
2510         [macOS] Cannot change font size at selection until font panel is shown
2511         https://bugs.webkit.org/show_bug.cgi?id=189295
2512         <rdar://problem/35593389>
2513
2514         Reviewed by Ryosuke Niwa.
2515
2516         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
2517         WebCore ChangeLog for more details.
2518
2519         * WebView/WebHTMLView.mm:
2520         (-[WebHTMLView changeFont:]):
2521         (-[WebHTMLView changeAttributes:]):
2522         (-[WebHTMLView _originalFontA]): Deleted.
2523         (-[WebHTMLView _originalFontB]): Deleted.
2524         (fontNameForDescription): Deleted.
2525         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
2526         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
2527         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
2528
2529 2018-09-05  Jer Noble  <jer.noble@apple.com>
2530
2531         Add MediaCapabilities as an Experimental Feature
2532         https://bugs.webkit.org/show_bug.cgi?id=189209
2533
2534         Reviewed by Eric Carlson.
2535
2536         RuntimeEnabledFeature -> Setting.
2537
2538         * WebView/WebView.mm:
2539         (-[WebView _preferencesChanged:]):
2540
2541 2018-09-04  Frederic Wang  <fwang@igalia.com>
2542
2543         Add basic support for ScrollIntoViewOptions
2544         https://bugs.webkit.org/show_bug.cgi?id=189258
2545
2546         Reviewed by Simon Fraser.
2547
2548         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
2549         header so that this file can build despite the new scrollIntoView function.
2550
2551 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2552
2553         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
2554         https://bugs.webkit.org/show_bug.cgi?id=188890
2555         <rdar://problem/43648605>
2556
2557         Reviewed by Tim Horton.
2558
2559         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
2560         more detail.
2561
2562         * WebCoreSupport/WebPlatformStrategies.h:
2563         * WebCoreSupport/WebPlatformStrategies.mm:
2564         (WebPlatformStrategies::allStringsForType):
2565
2566 2018-09-01  Darin Adler  <darin@apple.com>
2567
2568         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
2569         https://bugs.webkit.org/show_bug.cgi?id=189072
2570         Reviewed by Dan Bernstein.
2571
2572         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
2573         and declarations for NSURLDownload init methods.
2574
2575         * Misc/WebDownloadInternal.h: Removed.
2576
2577         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
2578         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
2579         "-Wdeprecated-declarations" because the method used here is deprecated.
2580
2581         * WebView/WebView.mm:
2582         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
2583         used here is deprecated.
2584
2585 2018-08-31  Chris Dumez  <cdumez@apple.com>
2586
2587         Assertion hit in ~CompletionHandler() from ~WebFrame()
2588         https://bugs.webkit.org/show_bug.cgi?id=189199
2589         <rdar://problem/42657233>
2590
2591         Reviewed by Youenn Fablet.
2592
2593         * WebCoreSupport/WebFrameLoaderClient.h:
2594         * WebCoreSupport/WebFrameLoaderClient.mm:
2595         (WebFrameLoaderClient::dispatchWillSubmitForm):
2596
2597 2018-08-31  Antti Koivisto  <antti@apple.com>
2598
2599         Replace OptionSet |= and -= operators with add() and remove() functions
2600         https://bugs.webkit.org/show_bug.cgi?id=189169
2601
2602         Reviewed by Anders Carlsson.
2603
2604         * WebView/WebFrame.mm:
2605         (-[WebFrame _drawRect:contentsOnly:]):
2606         * WebView/WebView.mm:
2607         (coreOptions):
2608
2609 2018-08-31  Frederic Wang  <fwang@igalia.com>
2610
2611         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
2612         https://bugs.webkit.org/show_bug.cgi?id=182053
2613
2614         Reviewed by Simon Fraser.
2615
2616         Add developer flag to use standard behavior for scrolling* attributes.
2617
2618         * WebView/WebPreferenceKeysPrivate.h:
2619         * WebView/WebPreferences.mm:
2620         (+[WebPreferences initialize]):
2621         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
2622         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
2623         * WebView/WebPreferencesPrivate.h:
2624         * WebView/WebView.mm:
2625         (-[WebView _preferencesChanged:]):
2626
2627 2018-08-29  Olivia Barnett  <obarnett@apple.com>
2628
2629         Implement the Web Share API
2630         https://bugs.webkit.org/show_bug.cgi?id=171100
2631         <rdar://problem/31751734>
2632
2633         Reviewed by Tim Horton.
2634
2635         * WebCoreSupport/WebChromeClient.h:
2636         * WebCoreSupport/WebChromeClient.mm:
2637         (WebChromeClient::showShareSheet):
2638         Empty declaration of showShareSheet.
2639
2640 2018-08-29  Youenn Fablet  <youenn@apple.com>
2641
2642         Remove WebRTC legacy API implementation
2643         https://bugs.webkit.org/show_bug.cgi?id=189040
2644
2645         Reviewed by Eric Carlson.
2646
2647         * WebView/WebPreferenceKeysPrivate.h:
2648         * WebView/WebPreferences.mm:
2649         (+[WebPreferences initialize]):
2650         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
2651         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
2652         * WebView/WebPreferencesPrivate.h:
2653         * WebView/WebView.mm:
2654         (-[WebView _preferencesChanged:]):
2655
2656 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2657
2658         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
2659         https://bugs.webkit.org/show_bug.cgi?id=189054
2660
2661         Reviewed by Andy Estes.
2662
2663         Remove the pasteboard type argument from readURLFromPasteboard.
2664
2665         * WebCoreSupport/WebPlatformStrategies.h:
2666         * WebCoreSupport/WebPlatformStrategies.mm:
2667         (WebPlatformStrategies::readURLFromPasteboard):
2668
2669 2018-08-27  Keith Rollin  <krollin@apple.com>
2670
2671         Unreviewed build fix -- disable LTO for production builds
2672
2673         * Configurations/Base.xcconfig:
2674
2675 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
2676
2677         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
2678         https://bugs.webkit.org/show_bug.cgi?id=188931
2679
2680         Reviewed by Wenson Hsieh.
2681
2682         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
2683
2684 2018-08-27  Keith Rollin  <krollin@apple.com>
2685
2686         Build system support for LTO
2687         https://bugs.webkit.org/show_bug.cgi?id=187785
2688         <rdar://problem/42353132>
2689
2690         Reviewed by Dan Bernstein.
2691
2692         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
2693         LTO.
2694
2695         * Configurations/Base.xcconfig:
2696         * Configurations/DebugRelease.xcconfig:
2697
2698 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
2699
2700         Pass in IsComposed flag to Event constructors
2701         https://bugs.webkit.org/show_bug.cgi?id=188720
2702         <rdar://problem/43580387>
2703
2704         Reviewed by Simon Fraser.
2705
2706         * WebView/WebPDFView.mm:
2707         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
2708         whether it's simulated or not.
2709
2710 2018-08-23  Mark Lam  <mark.lam@apple.com>
2711
2712         Move vmEntryGlobalObject() to VM from CallFrame.
2713         https://bugs.webkit.org/show_bug.cgi?id=188900
2714         <rdar://problem/43655753>
2715
2716         Reviewed by Michael Saboff.
2717
2718         * WebView/WebScriptDebugger.mm:
2719         (WebScriptDebugger::sourceParsed):
2720
2721 2018-08-23  Andy Estes  <aestes@apple.com>
2722
2723         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
2724         https://bugs.webkit.org/show_bug.cgi?id=188829
2725
2726         Reviewed by Tim Horton.
2727
2728         * Configurations/FeatureDefines.xcconfig:
2729
2730 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2731
2732         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
2733         https://bugs.webkit.org/show_bug.cgi?id=188777
2734
2735         Reviewed by Simon Fraser.
2736
2737         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
2738         being "true" before the code change.
2739
2740         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
2741
2742         * WebView/WebPDFView.mm:
2743         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2744
2745 2018-08-21  Daniel Bates  <dabates@apple.com>
2746
2747         Replace TextCheckingTypeMask with OptionSet
2748         https://bugs.webkit.org/show_bug.cgi?id=188678
2749
2750         Reviewed by Antti Koivisto.
2751
2752         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
2753         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
2754         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
2755         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
2756
2757         * WebCoreSupport/WebEditorClient.h:
2758         * WebCoreSupport/WebEditorClient.mm:
2759         (WebEditorClient::checkTextOfParagraph):
2760         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
2761         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
2762         left as this is more readable and unncessary now that modern compilers like Clang have
2763         diagnostics to catch accidental assignments when equality was intended.
2764         (WebEditorClient::didCheckSucceed):
2765         * WebView/WebView.mm:
2766         (coreTextCheckingType):
2767         (textCheckingResultFromNSTextCheckingResult):
2768
2769 2018-08-21  Daniel Bates  <dabates@apple.com>
2770
2771         [iOS][WK1] Support toggling continuous spell checking from tests
2772         https://bugs.webkit.org/show_bug.cgi?id=188763
2773
2774         Reviewed by Simon Fraser.
2775
2776         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
2777         spell checking from tests in iOS WebKit Legacy.
2778
2779         * WebCoreSupport/WebEditorClient.h:
2780         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
2781         * WebCoreSupport/WebEditorClient.mm:
2782         * WebView/WebView.h:
2783         * WebView/WebView.mm:
2784         (-[WebView toggleContinuousSpellChecking:]):
2785         (-[WebView toggleSmartInsertDelete:]):
2786
2787 2018-08-17  Alex Christensen  <achristensen@webkit.org>
2788
2789         Add some plumbing for safe browsing
2790         https://bugs.webkit.org/show_bug.cgi?id=188709
2791
2792         Reviewed by Tim Horton.
2793
2794         * WebCoreSupport/WebFrameLoaderClient.h:
2795         * WebCoreSupport/WebFrameLoaderClient.mm:
2796         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2797
2798 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
2799
2800         Replace canBubble and cancelable booleans in Event by enum classes
2801         https://bugs.webkit.org/show_bug.cgi?id=188692
2802
2803         Reviewed by Alex Christensen.
2804
2805         * WebView/WebPDFView.mm:
2806         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2807         * WebView/WebView.mm:
2808         (-[WebView _dispatchUnloadEvent]):
2809
2810 2018-08-16  Jer Noble  <jer.noble@apple.com>
2811
2812         Add Experimental Feature support for SourceBuffer.changeType()
2813         https://bugs.webkit.org/show_bug.cgi?id=188626
2814         <rdar://problem/43356021>
2815
2816         Reviewed by Eric Carlson.
2817
2818         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
2819
2820         * WebView/WebPreferenceKeysPrivate.h:
2821         * WebView/WebPreferences.mm:
2822         (+[WebPreferences initialize]):
2823         (-[WebPreferences sourceBufferChangeTypeEnabled]):
2824         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
2825         * WebView/WebPreferencesPrivate.h:
2826         * WebView/WebView.mm:
2827         (-[WebView _preferencesChanged:]):
2828
2829 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
2830
2831         Support drag-and-drop for input[type=color]
2832         https://bugs.webkit.org/show_bug.cgi?id=188464
2833
2834         Reviewed by Wenson Hsieh.
2835
2836         * WebCoreSupport/WebPlatformStrategies.h:
2837         * WebCoreSupport/WebPlatformStrategies.mm:
2838         (WebPlatformStrategies::setColor):
2839
2840 2018-08-15  Tim Horton  <timothy_horton@apple.com>
2841
2842         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
2843         https://bugs.webkit.org/show_bug.cgi?id=188569
2844         <rdar://problem/34201095>
2845
2846         Reviewed by Megan Gardner.
2847
2848         * WebView/WebImmediateActionController.mm:
2849         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2850         Speculative fix; the crashes indicate font is null, but we just checked it,
2851         so it must be getting made null by convertFont:toSize:. Check again!
2852
2853 2018-08-13  Alex Christensen  <achristensen@webkit.org>
2854
2855         Use a 1-byte enum class for TextDirection
2856         https://bugs.webkit.org/show_bug.cgi?id=188350
2857
2858         Reviewed by Simon Fraser.
2859
2860         * WebCoreSupport/PopupMenuMac.mm:
2861         (PopupMenuMac::populate):
2862         (PopupMenuMac::show):
2863         * WebCoreSupport/WebFrameLoaderClient.mm:
2864         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2865         * WebView/WebFrame.mm:
2866         (-[WebFrame _dispatchDidReceiveTitle:]):
2867
2868 2018-08-09  Ali Juma  <ajuma@chromium.org>
2869
2870         Import WPTs for IntersectionObserver
2871         https://bugs.webkit.org/show_bug.cgi?id=188416
2872
2873         Reviewed by Simon Fraser.
2874
2875         * WebView/WebPreferencesPrivate.h:
2876
2877 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
2878
2879         Follow-up build fix for r234685
2880         https://bugs.webkit.org/show_bug.cgi?id=188245
2881
2882         Unreviewed build fix.
2883
2884         * WebCoreSupport/WebSecurityOriginPrivate.h:
2885
2886 2018-08-05  Darin Adler  <darin@apple.com>
2887
2888         [Cocoa] More tweaks and refactoring to prepare for ARC
2889         https://bugs.webkit.org/show_bug.cgi?id=188245
2890
2891         Reviewed by Dan Bernstein.
2892
2893         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
2894
2895         * Carbon/CarbonWindowFrame.m:
2896         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
2897
2898         * DOM/DOM.mm:
2899         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
2900         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
2901         garbage collection so this method isn't useful.
2902
2903         * DOM/DOMXPath.mm:
2904         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
2905         Objective-C garbage collection so this method isn't useful.
2906
2907         * History/WebHistory.mm:
2908         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
2909
2910         * Misc/WebElementDictionary.mm:
2911         (addLookupKey): Use a bridging cast.
2912         (cacheValueForKey): Ditto.
2913         (-[WebElementDictionary _fillCache]): Ditto.
2914         (-[WebElementDictionary objectForKey:]): Ditto.
2915
2916         * Misc/WebKitNSStringExtras.mm:
2917         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
2918         (-[NSString _web_widthWithFont:]): Ditto.
2919         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
2920
2921         * Misc/WebLocalizableStrings.mm:
2922         (WebLocalizedString): Use a bridging cast.
2923
2924         * Misc/WebNSDataExtras.mm:
2925         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
2926         and use CFBridgingRelease instead of calling autorelease directly.
2927         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
2928         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
2929         on the amount of explicit release and autorelease.
2930
2931         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
2932         * Misc/WebNSDictionaryExtras.m:
2933         (-[NSDictionary _webkit_intForKey:]): Deleted.
2934         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
2935         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
2936         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
2937         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
2938         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
2939         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
2940
2941         * Misc/WebStringTruncator.mm:
2942         (fontFromNSFont): Use a bridging cast.
2943
2944         * Plugins/Hosted/NetscapePluginHostManager.mm:
2945         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
2946
2947         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2948         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
2949         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
2950         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
2951         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
2952         * Plugins/Hosted/ProxyInstance.mm:
2953         (WebKit::ProxyInstance::getPropertyNames): Ditto.
2954         * Plugins/WebBasePluginPackage.mm:
2955         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
2956         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2957         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
2958         * Plugins/WebNetscapePluginPackage.mm:
2959         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
2960
2961         * Plugins/WebNetscapePluginView.mm:
2962         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
2963         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
2964         (-[WebNetscapePluginView status:]): Use a bridging cast.
2965         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
2966
2967         * Plugins/WebPluginController.mm:
2968         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
2969
2970         * Plugins/WebPluginDatabase.mm:
2971         (checkCandidate): Use explicit __strong for out argument types.
2972
2973         * Plugins/npapi.mm:
2974         (pluginViewForInstance): Use a bridging cast.
2975
2976         * Storage/WebDatabaseManager.mm:
2977         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
2978         explicit NSNumber and NSDictionary calls.
2979
2980         * WebCoreSupport/WebContextMenuClient.mm:
2981         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
2982
2983         * WebCoreSupport/WebEditorClient.mm:
2984         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
2985         (WebEditorClient::handleInputMethodKeydown): Ditto.
2986
2987         * WebCoreSupport/WebFrameNetworkingContext.mm:
2988         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
2989
2990         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
2991         as a struct rather than an Objective-C class, since that's how it's defined.
2992
2993         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
2994
2995         * WebView/WebFullScreenController.mm:
2996         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
2997         * WebView/WebHTMLView.mm:
2998         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2999         Ditto.
3000         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3001
3002         * WebView/WebImmediateActionController.mm:
3003         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3004         go down to the document and then back to the frame.
3005         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3006         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3007         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3008
3009         * WebView/WebJSPDFDoc.mm:
3010         (jsPDFDocInitialize): Removed some unneeded type casting.
3011         (jsPDFDocFinalize): Ditto.
3012         (jsPDFDocPrint): Use a bridging cast.
3013
3014         * WebView/WebPDFView.mm:
3015         (_applicationInfoForMIMEType): Use bridging casts.
3016
3017         * WebView/WebPreferences.mm:
3018         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3019         instead of methods from WebNSDictionaryExtras.
3020         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3021         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3022         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3023         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3024         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3025
3026         * WebView/WebView.mm:
3027         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3028         (-[WebView _addToAllWebViewsSet]): Ditto.
3029         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3030         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3031         so it can be called from WebViewData methods.
3032
3033         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3034         method, _windowVisibilityChanged:.
3035
3036         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3037         called from WebViewData methods.
3038
3039 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3040
3041         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3042         https://bugs.webkit.org/show_bug.cgi?id=188323
3043
3044         Reviewed by Simon Fraser.
3045
3046         * WebCoreSupport/WebContextMenuClient.mm:
3047         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3048         * WebView/WebFrame.mm:
3049         (-[WebFrame _paintBehaviorForDestinationContext:]):
3050         (-[WebFrame _drawRect:contentsOnly:]):
3051         * WebView/WebHTMLView.mm:
3052         (imageFromRect):
3053         (selectionImage):
3054
3055 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3056
3057         Add support for microtasks in workers
3058         https://bugs.webkit.org/show_bug.cgi?id=188246
3059
3060         Reviewed by Darin Adler.
3061
3062         Rename JSMainThreadExecState.h to JSExecState.h.
3063
3064         * DOM/DOMAttr.mm:
3065         * DOM/DOMBlob.mm:
3066         * DOM/DOMCDATASection.mm:
3067         * DOM/DOMCSSCharsetRule.mm:
3068         * DOM/DOMCSSFontFaceRule.mm:
3069         * DOM/DOMCSSImportRule.mm:
3070         * DOM/DOMCSSMediaRule.mm:
3071         * DOM/DOMCSSPageRule.mm:
3072         * DOM/DOMCSSPrimitiveValue.mm:
3073         * DOM/DOMCSSRule.mm:
3074         * DOM/DOMCSSRuleList.mm:
3075         * DOM/DOMCSSStyleDeclaration.mm:
3076         * DOM/DOMCSSStyleRule.mm:
3077         * DOM/DOMCSSStyleSheet.mm:
3078         * DOM/DOMCSSUnknownRule.mm:
3079         * DOM/DOMCSSValue.mm:
3080         * DOM/DOMCSSValueList.mm:
3081         * DOM/DOMCharacterData.mm:
3082         * DOM/DOMComment.mm:
3083         * DOM/DOMCounter.mm:
3084         * DOM/DOMDocument.mm:
3085         * DOM/DOMDocumentFragment.mm:
3086         * DOM/DOMDocumentType.mm:
3087         * DOM/DOMElement.mm:
3088         * DOM/DOMEvent.mm:
3089         * DOM/DOMFile.mm:
3090         * DOM/DOMFileList.mm:
3091         * DOM/DOMHTML.mm:
3092         * DOM/DOMHTMLAnchorElement.mm:
3093         * DOM/DOMHTMLAppletElement.mm:
3094         * DOM/DOMHTMLAreaElement.mm:
3095         * DOM/DOMHTMLBRElement.mm:
3096         * DOM/DOMHTMLBaseElement.mm:
3097         * DOM/DOMHTMLBaseFontElement.mm:
3098         * DOM/DOMHTMLBodyElement.mm:
3099         * DOM/DOMHTMLButtonElement.mm:
3100         * DOM/DOMHTMLCanvasElement.mm:
3101         * DOM/DOMHTMLCollection.mm:
3102         * DOM/DOMHTMLDListElement.mm:
3103         * DOM/DOMHTMLDirectoryElement.mm:
3104         * DOM/DOMHTMLDivElement.mm:
3105         * DOM/DOMHTMLDocument.mm:
3106         * DOM/DOMHTMLElement.mm:
3107         * DOM/DOMHTMLEmbedElement.mm:
3108         * DOM/DOMHTMLFieldSetElement.mm:
3109         * DOM/DOMHTMLFontElement.mm:
3110         * DOM/DOMHTMLFormElement.mm:
3111         * DOM/DOMHTMLFrameElement.mm:
3112         * DOM/DOMHTMLFrameSetElement.mm:
3113         * DOM/DOMHTMLHRElement.mm:
3114         * DOM/DOMHTMLHeadElement.mm:
3115         * DOM/DOMHTMLHeadingElement.mm:
3116         * DOM/DOMHTMLHtmlElement.mm:
3117         * DOM/DOMHTMLIFrameElement.mm:
3118         * DOM/DOMHTMLImageElement.mm:
3119         * DOM/DOMHTMLInputElement.mm:
3120         * DOM/DOMHTMLLIElement.mm:
3121         * DOM/DOMHTMLLabelElement.mm:
3122         * DOM/DOMHTMLLegendElement.mm:
3123         * DOM/DOMHTMLLinkElement.mm:
3124         * DOM/DOMHTMLMapElement.mm:
3125         * DOM/DOMHTMLMarqueeElement.mm:
3126         * DOM/DOMHTMLMediaElement.mm:
3127         * DOM/DOMHTMLMenuElement.mm:
3128         * DOM/DOMHTMLMetaElement.mm:
3129         * DOM/DOMHTMLModElement.mm:
3130         * DOM/DOMHTMLOListElement.mm:
3131         * DOM/DOMHTMLObjectElement.mm:
3132         * DOM/DOMHTMLOptGroupElement.mm:
3133         * DOM/DOMHTMLOptionElement.mm:
3134         * DOM/DOMHTMLOptionsCollection.mm:
3135         * DOM/DOMHTMLParagraphElement.mm:
3136         * DOM/DOMHTMLParamElement.mm:
3137         * DOM/DOMHTMLPreElement.mm:
3138         * DOM/DOMHTMLQuoteElement.mm:
3139         * DOM/DOMHTMLScriptElement.mm:
3140         * DOM/DOMHTMLSelectElement.mm:
3141         * DOM/DOMHTMLStyleElement.mm:
3142         * DOM/DOMHTMLTableCaptionElement.mm:
3143         * DOM/DOMHTMLTableCellElement.mm:
3144         * DOM/DOMHTMLTableColElement.mm:
3145         * DOM/DOMHTMLTableElement.mm:
3146         * DOM/DOMHTMLTableRowElement.mm:
3147         * DOM/DOMHTMLTableSectionElement.mm:
3148         * DOM/DOMHTMLTextAreaElement.mm:
3149         * DOM/DOMHTMLTitleElement.mm:
3150         * DOM/DOMHTMLUListElement.mm:
3151         * DOM/DOMHTMLVideoElement.mm:
3152         * DOM/DOMImplementation.mm:
3153         * DOM/DOMKeyboardEvent.mm:
3154         * DOM/DOMMediaError.mm:
3155         * DOM/DOMMediaList.mm:
3156         * DOM/DOMMouseEvent.mm:
3157         * DOM/DOMMutationEvent.mm:
3158         * DOM/DOMNamedNodeMap.mm:
3159         * DOM/DOMNode.mm:
3160         * DOM/DOMNodeIterator.mm:
3161         * DOM/DOMNodeList.mm:
3162         * DOM/DOMOverflowEvent.mm:
3163         * DOM/DOMProcessingInstruction.mm:
3164         * DOM/DOMProgressEvent.mm:
3165         * DOM/DOMRGBColor.mm:
3166         * DOM/DOMRange.mm:
3167         * DOM/DOMRect.mm:
3168         * DOM/DOMStyleSheet.mm:
3169         * DOM/DOMStyleSheetList.mm:
3170         * DOM/DOMText.mm:
3171         * DOM/DOMTextEvent.mm:
3172         * DOM/DOMTimeRanges.mm:
3173         * DOM/DOMTokenList.mm:
3174         * DOM/DOMTreeWalker.mm:
3175         * DOM/DOMUIEvent.mm:
3176         * DOM/DOMWheelEvent.mm:
3177         * DOM/DOMXPathExpression.mm:
3178         * DOM/DOMXPathResult.mm:
3179         * DOM/ObjCEventListener.mm:
3180
3181 2018-08-03  Alex Christensen  <achristensen@webkit.org>
3182
3183         Fix spelling of "overridden"
3184         https://bugs.webkit.org/show_bug.cgi?id=188315
3185
3186         Reviewed by Darin Adler.
3187
3188         * Misc/WebKitVersionChecks.mm:
3189         (setWebKitLinkTimeVersion):
3190         (WebKitLinkTimeVersion):
3191         * Plugins/WebBaseNetscapePluginView.mm:
3192         (-[WebBaseNetscapePluginView handleMouseMoved:]):
3193         * WebCoreSupport/PopupMenuMac.mm:
3194         (PopupMenuMac::populate):
3195
3196 2018-08-01  Nan Wang  <n_wang@apple.com>
3197
3198         AX: AOM: Add ARIA IDL Attribute Reflection
3199         https://bugs.webkit.org/show_bug.cgi?id=184676
3200         <rdar://problem/39476882>
3201
3202         Reviewed by Chris Fleizach.
3203
3204         * WebView/WebPreferenceKeysPrivate.h:
3205         * WebView/WebPreferences.mm:
3206         (+[WebPreferences initialize]):
3207         (-[WebPreferences ariaReflectionEnabled]):
3208         (-[WebPreferences setAriaReflectionEnabled:]):
3209         * WebView/WebPreferencesPrivate.h:
3210         * WebView/WebView.mm:
3211         (-[WebView _preferencesChanged:]):
3212
3213 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
3214
3215         Shrink GraphicsLayerCA
3216         https://bugs.webkit.org/show_bug.cgi?id=188141
3217
3218         Reviewed by Zalan Bujtas.
3219
3220         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
3221         * moving all the clone-related stuff into the lazily-allocated m_layerClones
3222         * moving all the animation-related stuff into the lazily-allocated m_animations
3223         * making enums be 8-bit
3224         * re-ordering data members
3225
3226         * WebView/WebView.mm:
3227         (-[WebView _setMediaLayer:forPluginView:]):
3228
3229 2018-07-30  Rob Buis  <rbuis@igalia.com>
3230
3231         Merge PlatformCookieJar functions into NetworkStorageSession
3232         https://bugs.webkit.org/show_bug.cgi?id=188137
3233
3234         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
3235
3236         Reviewed by Alex Christensen.
3237
3238         * WebCoreSupport/WebPlatformStrategies.mm:
3239         (WebPlatformStrategies::cookiesForDOM):
3240         (WebPlatformStrategies::setCookiesFromDOM):
3241         (WebPlatformStrategies::cookiesEnabled):
3242         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3243         (WebPlatformStrategies::getRawCookies):
3244         (WebPlatformStrategies::deleteCookie):
3245         * WebView/WebPreferences.mm:
3246         (+[WebPreferences _clearNetworkLoaderSession]):
3247
3248 2018-07-28  Darin Adler  <darin@apple.com>
3249
3250         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
3251         https://bugs.webkit.org/show_bug.cgi?id=188140
3252
3253         Reviewed by Sam Weinig.
3254
3255         * WebView/WebImmediateActionController.mm:
3256         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
3257         new DictionaryLookup function that returns a tuple instead of using an out argument.
3258
3259 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
3260
3261         [INTL] Remove INTL sub-feature compile flags
3262         https://bugs.webkit.org/show_bug.cgi?id=188081
3263
3264         Reviewed by Michael Catanzaro.
3265
3266         * Configurations/FeatureDefines.xcconfig:
3267
3268 2018-07-26  Commit Queue  <commit-queue@webkit.org>
3269
3270         Unreviewed, rolling out r234181 and r234189.
3271         https://bugs.webkit.org/show_bug.cgi?id=188075
3272
3273         These are not needed right now (Requested by thorton on
3274         #webkit).
3275
3276         Reverted changesets:
3277
3278         "Enable Web Content Filtering on watchOS"
3279         https://bugs.webkit.org/show_bug.cgi?id=187979
3280         https://trac.webkit.org/changeset/234181
3281
3282         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
3283         https://bugs.webkit.org/show_bug.cgi?id=187985
3284         https://trac.webkit.org/changeset/234189
3285
3286 2018-07-26  Timothy Hatcher  <timothy@apple.com>
3287
3288         Use the Page's appearance when converting pasteboard attributed strings.
3289         https://bugs.webkit.org/show_bug.cgi?id=188067
3290         rdar://problem/42632246
3291
3292         Reviewed by Wenson Hsieh.
3293
3294         * WebCoreSupport/WebEditorClient.mm:
3295         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
3296
3297 2018-07-25  Chris Dumez  <cdumez@apple.com>
3298
3299         navigator.userAgent may return outdated value after webView.customUserAgent is set
3300         https://bugs.webkit.org/show_bug.cgi?id=188009
3301         <rdar://problem/42566456>
3302
3303         Reviewed by Alex Christensen.
3304
3305         Let the page know when the user agent changes.
3306
3307         * WebView/WebView.mm:
3308         (-[WebView _preferencesChanged:]):
3309         (-[WebView setApplicationNameForUserAgent:]):
3310         (-[WebView _invalidateUserAgentCache]):
3311         (-[WebView setCustomUserAgent:]):
3312         * WebView/WebViewInternal.h:
3313
3314 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3315
3316         Enable Web Content Filtering on watchOS
3317         https://bugs.webkit.org/show_bug.cgi?id=187979
3318         <rdar://problem/42559346>
3319
3320         Reviewed by Wenson Hsieh.
3321
3322         * Configurations/FeatureDefines.xcconfig:
3323
3324 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3325
3326         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3327         https://bugs.webkit.org/show_bug.cgi?id=187846
3328
3329         Reviewed by Simon Fraser.
3330
3331         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
3332
3333         * WebView/WebHTMLView.mm:
3334         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
3335         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
3336
3337 2018-07-11  Dean Jackson  <dino@apple.com>
3338
3339         Allow removal of white backgrounds
3340         https://bugs.webkit.org/show_bug.cgi?id=187574
3341         <rdar://problem/41146792>
3342
3343         Reviewed by Simon Fraser.
3344
3345         Add a new WebPreference for punching out white backgrounds.
3346
3347         * WebView/WebPreferenceKeysPrivate.h:
3348         * WebView/WebPreferences.mm:
3349         (+[WebPreferences initialize]):
3350         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
3351         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
3352         * WebView/WebPreferencesPrivate.h:
3353         * WebView/WebView.mm:
3354         (-[WebView _preferencesChanged:]):
3355
3356 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
3357
3358         Ensure WebKit stack is ad-hoc signed
3359         https://bugs.webkit.org/show_bug.cgi?id=187667
3360
3361         Reviewed by Alexey Proskuryakov.
3362
3363         * Configurations/Base.xcconfig:
3364
3365 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
3366
3367         REGRESSION (231276): Attempting to copy an image fails
3368         https://bugs.webkit.org/show_bug.cgi?id=187212
3369         <rdar://problem/41540074>
3370
3371         Reviewed by Ryosuke Niwa.
3372
3373         Renamed methods to make it clear that one URL and one title are being passed in.
3374
3375         * WebCoreSupport/WebPlatformStrategies.h:
3376         * WebCoreSupport/WebPlatformStrategies.mm:
3377         (WebPlatformStrategies::setURL):
3378
3379 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
3380
3381         Disable cross-origin-window-policy by default
3382         https://bugs.webkit.org/show_bug.cgi?id=187509
3383
3384         Reviewed by Chris Dumez.
3385
3386         * WebView/WebPreferences.mm:
3387         (+[WebPreferences initialize]):
3388
3389 2018-07-09  Timothy Hatcher  <timothy@apple.com>
3390
3391         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3392         https://bugs.webkit.org/show_bug.cgi?id=187425
3393         rdar://problem/39948240
3394
3395         Reviewed by Tim Horton.
3396
3397         * WebView/WebView.mm:
3398         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3399         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3400         a call in this method to setUseDarkAppearance.
3401         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3402         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3403         (-[WebView _updateDefaultAppearance]): Deleted.
3404         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3405
3406 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
3407
3408         Shrink various loading-related enums to shrink CachedResource
3409         https://bugs.webkit.org/show_bug.cgi?id=187443
3410
3411         Reviewed by Chris Dumez.
3412
3413         * WebCoreSupport/WebFrameLoaderClient.mm:
3414         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3415         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
3416         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3417         (WebFrameLoaderClient::dispatchWillSendRequest):
3418         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3419         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3420         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3421         (WebFrameLoaderClient::updateGlobalHistory):
3422         (WebFrameLoaderClient::canHandleRequest const):
3423         * WebView/WebDataSource.mm:
3424         (-[WebDataSource initialRequest]):
3425         (-[WebDataSource request]):
3426
3427 2018-07-09  Commit Queue  <commit-queue@webkit.org>
3428
3429         Unreviewed, rolling out r233612.
3430         https://bugs.webkit.org/show_bug.cgi?id=187475
3431
3432         Revision caused the api test LinkColorWithSystemAppearance to
3433         fail on all systems. (Requested by Truitt on #webkit).
3434
3435         Reverted changeset:
3436
3437         "Semantic colors don't update when accessibility Increase
3438         Contrast mode is enabled."
3439         https://bugs.webkit.org/show_bug.cgi?id=187425
3440         https://trac.webkit.org/changeset/233612
3441
3442 2018-07-06  Timothy Hatcher  <timothy@apple.com>
3443
3444         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3445         https://bugs.webkit.org/show_bug.cgi?id=187425
3446         rdar://problem/39948240
3447
3448         Reviewed by Tim Horton.
3449
3450         * WebView/WebView.mm:
3451         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3452         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3453         a call in this method to setUseDarkAppearance.
3454         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3455         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3456         (-[WebView _updateDefaultAppearance]): Deleted.
3457         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3458
3459 2018-07-05  Timothy Hatcher  <timothy@apple.com>
3460
3461         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
3462         https://bugs.webkit.org/show_bug.cgi?id=187369
3463         rdar://problem/41870420
3464
3465         Reviewed by Tim Horton.
3466
3467         * WebView/WebMediaPlaybackTargetPicker.mm:
3468         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
3469         * WebView/WebView.mm:
3470         (-[WebView _commonInitializationWithFrameName:groupName:]):
3471         (-[WebView _effectiveAppearanceIsDark]):
3472         (-[WebView _updateDefaultAppearance]):
3473         (-[WebView _defaultAppearance]): Deleted.
3474
3475 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
3476
3477         Youtube video pages crash after a couple of minutes
3478         https://bugs.webkit.org/show_bug.cgi?id=187316
3479
3480         Reviewed by Antti Koivisto.
3481
3482         * WebView/WebView.mm:
3483         (-[WebView _preferencesChanged:]):
3484
3485 2018-07-04  Tim Horton  <timothy_horton@apple.com>
3486
3487         Introduce PLATFORM(IOSMAC)
3488         https://bugs.webkit.org/show_bug.cgi?id=187315
3489
3490         Reviewed by Dan Bernstein.
3491
3492         * Configurations/Base.xcconfig:
3493         * Configurations/FeatureDefines.xcconfig:
3494
3495 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3496
3497         [iOS] DataTransfer.getData always returns the empty string when dropping text
3498         https://bugs.webkit.org/show_bug.cgi?id=187130
3499         <rdar://problem/41014117>
3500
3501         Reviewed by Ryosuke Niwa.
3502
3503         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
3504
3505         * WebCoreSupport/WebPlatformStrategies.h:
3506         * WebCoreSupport/WebPlatformStrategies.mm:
3507         (WebPlatformStrategies::allPasteboardItemInfo):
3508
3509 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
3510
3511         [Mac] AirPlay picker uses incorrect theme in Dark mode
3512         https://bugs.webkit.org/show_bug.cgi?id=187054
3513         <rdar://problem/41291093>
3514
3515         Reviewed by Timothy Hatcher.
3516
3517         * WebView/WebMediaPlaybackTargetPicker.mm:
3518         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
3519
3520 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3521
3522         [WTF] Add user-defined literal for ASCIILiteral
3523         https://bugs.webkit.org/show_bug.cgi?id=186839
3524
3525         Reviewed by Darin Adler.
3526
3527         * DOM/ExceptionHandlers.mm:
3528         (raiseDOMErrorException):
3529         * Plugins/Hosted/ProxyInstance.mm:
3530         (WebKit::ProxyInstance::invokeMethod):
3531         * Storage/WebDatabaseProvider.mm:
3532         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
3533
3534 2018-06-22  Timothy Hatcher  <timothy@apple.com>
3535
3536         Recalc styles every time defaultAppearance changes.
3537         https://bugs.webkit.org/show_bug.cgi?id=186866
3538         rdar://problem/41309805
3539
3540         Reviewed by Tim Horton.
3541
3542         * WebView/WebView.mm:
3543         (-[WebView _updateDefaultAppearance]):
3544         (-[WebView _setUseSystemAppearance:]):
3545         (-[WebView _useSystemAppearance]):
3546
3547 2018-06-20  Darin Adler  <darin@apple.com>
3548
3549         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
3550         https://bugs.webkit.org/show_bug.cgi?id=186875
3551
3552         Reviewed by Anders Carlsson.
3553
3554         * WebView/WebHTMLView.mm:
3555         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
3556         to write te file to.
3557         * WebView/WebPreferences.mm:
3558         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
3559         * WebView/WebView.mm:
3560         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
3561
3562 2018-06-12  Darin Adler  <darin@apple.com>
3563
3564         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
3565         https://bugs.webkit.org/show_bug.cgi?id=186526
3566
3567         Reviewed by Anders Carlsson.
3568
3569         * Plugins/Hosted/NetscapePluginHostManager.mm:
3570         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
3571
3572         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3573         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
3574         assignment rather than adoptNS/leakRef.
3575         * Plugins/WebNetscapePluginView.mm:
3576         (-[WebNetscapePluginView createPlugin]): Ditto.
3577
3578         * WebCoreSupport/WebContextMenuClient.mm:
3579         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
3580         RetainPtr::autorelease; no need to autorelease just to pass something as a function
3581         argument, so use RetainPtr::get instead.
3582
3583         * WebView/WebHTMLView.mm:
3584         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
3585         No need to autorelease the result when the return type is RetainPtr.
3586
3587         * WebView/WebPDFRepresentation.mm:
3588         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
3589
3590 2018-06-13  Youenn Fablet  <youenn@apple.com>
3591
3592         Supported plugin check should be based on plugin identifier
3593         https://bugs.webkit.org/show_bug.cgi?id=186578
3594         <rdar://problem/40523828>
3595
3596         Reviewed by Darin Adler.
3597
3598         * WebCoreSupport/WebPluginInfoProvider.h:
3599         * WebCoreSupport/WebPluginInfoProvider.mm:
3600         (WebPluginInfoProvider::pluginInfo):
3601         (WebPluginInfoProvider::webVisiblePluginInfo):
3602
3603 2018-06-13  Chris Dumez  <cdumez@apple.com>
3604
3605         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
3606         https://bugs.webkit.org/show_bug.cgi?id=186545
3607
3608         Reviewed by Brady Eidson.
3609
3610         Update client delegate now that parameter type has changed.
3611
3612         * WebCoreSupport/WebFrameLoaderClient.h:
3613         * WebCoreSupport/WebFrameLoaderClient.mm:
3614         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3615
3616 2018-06-11  Tim Horton  <timothy_horton@apple.com>
3617
3618         Link drag image is inconsistently unreadable in dark mode
3619         https://bugs.webkit.org/show_bug.cgi?id=186472
3620
3621         Reviewed by Timothy Hatcher.
3622
3623         * WebView/WebView.mm:
3624         (-[WebView _defaultAppearance]):
3625         Make defaultAppearance accurate even if useSystemAppearance is false.
3626         Some parts of WebKit (like the link drag image, but also context menus)
3627         want to be able to follow the system appearance regardless of whether
3628         the view or content has opted in.
3629
3630 2018-06-11  Chris Dumez  <cdumez@apple.com>
3631
3632         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
3633         https://bugs.webkit.org/show_bug.cgi?id=186441
3634
3635         Reviewed by Brady Eidson.
3636
3637         Rename existing flag to something a bit more generic, now that it is used for
3638         more things than bypassing the navigation policy check.
3639
3640         * WebView/WebView.mm:
3641         (-[WebView _loadBackForwardListFromOtherView:]):
3642         (-[WebView goToBackForwardItem:]):
3643
3644 2018-06-09  Dan Bernstein  <mitz@apple.com>
3645
3646         [Xcode] Clean up and modernize some build setting definitions
3647         https://bugs.webkit.org/show_bug.cgi?id=186463
3648
3649         Reviewed by Sam Weinig.
3650
3651         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
3652         * Configurations/DebugRelease.xcconfig: Ditto.
3653         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
3654           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
3655         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
3656         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
3657           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
3658         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
3659
3660 2018-06-08  Darin Adler  <darin@apple.com>
3661
3662         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
3663         https://bugs.webkit.org/show_bug.cgi?id=186436
3664
3665         Reviewed by Anders Carlsson.
3666
3667         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
3668         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
3669         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
3670         (PoolCleaner): Ditto.
3671
3672         * History/WebHistory.mm:
3673         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3674         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
3675         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
3676         now hardly used if at all.
3677         * WebView/WebView.mm:
3678         (-[WebView rectsForTextMatches]): Ditto.
3679
3680 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3681
3682         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
3683         https://bugs.webkit.org/show_bug.cgi?id=186442
3684         <rdar://problem/40879364>
3685
3686         Reviewed by Tim Horton.
3687
3688         * Configurations/FeatureDefines.xcconfig:
3689
3690 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
3691
3692         [Datalist] Allow TextFieldInputType to show and hide suggestions
3693         https://bugs.webkit.org/show_bug.cgi?id=186151
3694
3695         Reviewed by Tim Horton.
3696
3697         * WebCoreSupport/WebChromeClient.h:
3698         * WebCoreSupport/WebChromeClient.mm:
3699         (WebChromeClient::createDataListSuggestionPicker):
3700
3701 2018-06-07  Chris Dumez  <cdumez@apple.com>
3702
3703         Add base class to get WeakPtrFactory member and avoid some boilerplate code
3704         https://bugs.webkit.org/show_bug.cgi?id=186407
3705
3706         Reviewed by Brent Fulgham.
3707
3708         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
3709         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
3710         This also gets rid of old-style createWeakPtr() methods in favor of the newer
3711         makeWeakPtr().
3712
3713         * WebCoreSupport/WebEditorClient.h:
3714         * WebCoreSupport/WebEditorClient.mm:
3715         (WebEditorClient::requestCandidatesForSelection):
3716
3717 2018-06-05  Chris Dumez  <cdumez@apple.com>
3718
3719         Regression(r232082): Websites get loaded inside of Messages App chat transcript
3720         https://bugs.webkit.org/show_bug.cgi?id=186331
3721         <rdar://problem/40735446>
3722
3723         Reviewed by Darin Adler.
3724
3725         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
3726         but does not call use / ignore on the listener, then we would do "use" by default.
3727         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
3728         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
3729         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
3730         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
3731         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
3732         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
3733         and Box.app is still working properly.
3734
3735         * WebCoreSupport/WebFrameLoaderClient.h:
3736         * WebCoreSupport/WebFrameLoaderClient.mm:
3737         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3738         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3739         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3740         (WebFrameLoaderClient::dispatchWillSubmitForm):
3741         (WebFrameLoaderClient::setUpPolicyListener):
3742         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
3743         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
3744         (-[WebFramePolicyListener dealloc]):
3745         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
3746         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
3747
3748 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3749
3750         Adjust compile and runtime flags to match shippable state of features
3751         https://bugs.webkit.org/show_bug.cgi?id=186319
3752         <rdar://problem/40352045>
3753
3754         Reviewed by Maciej Stachowiak, Jon Lee, and others.
3755
3756         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
3757         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
3758         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
3759         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
3760         Cocoa builds.
3761
3762 2018-06-05  Timothy Hatcher  <timothy@apple.com>
3763
3764         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
3765
3766         https://bugs.webkit.org/show_bug.cgi?id=186323
3767         rdar://problem/38382252
3768
3769         Reviewed by Tim Horton.
3770
3771         * WebView/WebView.mm:
3772         (-[WebView _defaultAppearance]):
3773
3774 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3775
3776         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
3777         https://bugs.webkit.org/show_bug.cgi?id=186286
3778         <rdar://problem/40782992>
3779
3780         Reviewed by Dan Bernstein.
3781
3782         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
3783         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
3784         change this flag when preparing for a production release.
3785
3786         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
3787         whether experimental features should be enabled, and use it to properly define the
3788         feature flag.
3789
3790 2018-06-03  Darin Adler  <darin@apple.com>
3791
3792         Simplify and remove some unused video element code (helpful for ARC-compatibility)
3793         https://bugs.webkit.org/show_bug.cgi?id=186258
3794
3795         Reviewed by Daniel Bates.
3796
3797         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
3798         forward declarations. Removed methods that don't need to be public.
3799
3800         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
3801         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
3802         unnamed category in here and also replaced the HUDWindowControllerDelegate
3803         with the unnamed category. Removed unused NSWindow category defining the
3804         isOnActiveSpace, which is not called anywhere in this file at this time.
3805         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
3806         into setVideoElement.
3807         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
3808         and removed unneeded typecast.
3809         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
3810         using statement at the top of the file.
3811         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
3812         the many side effects and special considerations that this method that sounds
3813         like a setter has. Updated code to use the new
3814         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
3815         HTMLVideoElement::platformMedia function. Also straightened out the logic a
3816         bit and added some FIXME comments about small problems noticed but not fixed.
3817         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
3818         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
3819         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
3820         typecast. Removed call to updatePowerAssertions method.
3821         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
3822         updatePowerAssertions method.
3823         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
3824         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
3825         else, so this was dead code that did nothing.
3826         (-[WebVideoFullscreenController rateChanged:]): Removed call to
3827         updatePowerAssertions method.
3828
3829 2018-06-04  Chris Dumez  <cdumez@apple.com>
3830
3831         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
3832         https://bugs.webkit.org/show_bug.cgi?id=186287
3833         <rdar://problem/40783352>
3834
3835         Reviewed by Youenn Fablet.
3836
3837         * WebView/WebPreferenceKeysPrivate.h:
3838         * WebView/WebPreferences.mm:
3839         (+[WebPreferences initialize]):
3840         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
3841         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
3842         * WebView/WebPreferencesPrivate.h:
3843         * WebView/WebView.mm:
3844         (-[WebView _preferencesChanged:]):
3845
3846 2018-06-02  Darin Adler  <darin@apple.com>
3847
3848         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
3849         https://bugs.webkit.org/show_bug.cgi?id=186227
3850
3851         Reviewed by Dan Bernstein.
3852
3853         * Misc/WebKitErrors.m:
3854         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
3855         * Plugins/WebPluginDatabase.mm:
3856         (-[WebPluginDatabase refresh]): Ditto.
3857         * WebCoreSupport/WebChromeClient.mm:
3858         (WebChromeClient::setStatusbarText): Ditto.
3859
3860 2018-06-01  Chris Dumez  <cdumez@apple.com>
3861
3862         REGRESSION (r231456): Colloquy is broken
3863         https://bugs.webkit.org/show_bug.cgi?id=186197
3864         <rdar://problem/40722960>
3865
3866         Reviewed by Timothy Hatcher.
3867
3868         Restore pre-r231456 behavior for Colloquy app so that it works again.
3869
3870         * WebView/WebView.mm:
3871         (-[WebView _needsFrameNameFallbackToIdQuirk]):
3872         (-[WebView _preferencesChanged:]):
3873
3874 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
3875
3876         [JSC] Pass VM& parameter as much as possible
3877         https://bugs.webkit.org/show_bug.cgi?id=186085
3878
3879         Reviewed by Saam Barati.
3880
3881         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3882         (WebKit::NetscapePluginInstanceProxy::invoke):
3883
3884 2018-05-30  Daniel Bates  <dabates@apple.com>
3885
3886         NavigationAction does not need to hold initiating DOM Event
3887         https://bugs.webkit.org/show_bug.cgi?id=185958
3888         <rdar://problem/40531539>
3889
3890         Reviewed by Simon Fraser.
3891
3892         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
3893
3894         * WebCoreSupport/WebFrameLoaderClient.mm:
3895         (WebFrameLoaderClient::actionDictionary const):
3896         (findMouseEvent): Deleted.
3897
3898 2018-05-27  Dan Bernstein  <mitz@apple.com>
3899
3900         Reverted the changes made for https://webkit.org/b/186016
3901
3902         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
3903
3904
3905 2018-05-27  David Kilzer  <ddkilzer@apple.com>
3906
3907         [iOS] Fix warnings about leaks found by clang static analyzer
3908         <https://webkit.org/b/186009>
3909         <rdar://problem/40574267>
3910
3911         Reviewed by Daniel Bates.
3912
3913         * WebView/WebHTMLView.mm:
3914         (-[WebHTMLView doCommandBySelector:]): Fix use of an
3915         uninitialized boolean variable (`eventWasHandled`) that only
3916         happened on iOS.
3917
3918 2018-05-27  Dan Bernstein  <mitz@apple.com>
3919
3920         [Cocoa] Avoid importing directly from subumbrella frameworks
3921         https://bugs.webkit.org/show_bug.cgi?id=186016
3922
3923         Reviewed by Sam Weinig.
3924
3925         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
3926         * Carbon/CarbonWindowAdapter.mm: Ditto.
3927         * Carbon/CarbonWindowFrame.m: Ditto.
3928         * Carbon/HIViewAdapter.h: Ditto.
3929         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
3930           OTHER_CPLUSPLUSFLAGS.
3931         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
3932         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
3933         * WebView/WebPDFView.h: Ditto.
3934
3935 2018-05-27  Sam Weinig  <sam@webkit.org>
3936
3937         Modernize RenderStyleConstants.h - Part 3
3938         https://bugs.webkit.org/show_bug.cgi?id=186015
3939
3940         Reviewed by Yusuke Suzuki.
3941
3942         * WebView/WebView.mm:
3943         (-[WebView updateTextTouchBar]):
3944         Update for new enum name.
3945
3946 2018-05-25  Chris Dumez  <cdumez@apple.com>
3947
3948         Minor ApplicationCacheStorage clean up
3949         https://bugs.webkit.org/show_bug.cgi?id=185984
3950
3951         Reviewed by Youenn Fablet.
3952
3953         * WebCoreSupport/WebApplicationCache.mm:
3954         (+[WebApplicationCache originsWithCache]):
3955
3956 2018-05-25  David Kilzer  <ddkilzer@apple.com>
3957
3958         Fix issues with -dealloc methods found by clang static analyzer
3959         <https://webkit.org/b/185887>
3960
3961         Reviewed by Joseph Pecoraro.
3962
3963         * WebView/WebView.mm:
3964         (-[WebUITextIndicatorData dealloc]):
3965         - Move method implementation from (WebUITextIndicatorInternal)
3966           category to the main category since this is public API.  This
3967           fixes the false positive warning about a missing -dealloc
3968           method.
3969
3970 2018-05-24  Sam Weinig  <sam@webkit.org>
3971
3972         Modernize RenderStyleConstants.h - Part 2
3973         https://bugs.webkit.org/show_bug.cgi?id=185901
3974
3975         Reviewed by Simon Fraser.
3976
3977         * WebView/WebHTMLRepresentation.mm:
3978         (searchForLabelsBeforeElement):
3979         * WebView/WebView.mm:
3980         (nsTextAlignmentFromRenderStyle):
3981         Update for new enum names.
3982
3983 2018-05-22  Chris Dumez  <cdumez@apple.com>
3984
3985         Regression(AsyncPolicyDelegates): Box.app login Window is blank
3986         https://bugs.webkit.org/show_bug.cgi?id=185832
3987         <rdar://problem/40307871>
3988
3989         Reviewed by Geoffrey Garen.
3990
3991         We used to have a bug where where we would fail to wait for the policy decision for
3992         the navigation response from the client and the load would keep going, racing with
3993         the client's policy decision. If the client did not respond in time, the behavior
3994         would be the same as "Use" policy action.
3995
3996         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
3997         but the load happened to proceed anyway due to our bug. Now that we've fixed the
3998         WebKit bug, however, the load would hang because the completion handler for the
3999         decidePolicyForNavigationResponse would never get called.
4000
4001         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
4002         instead of retaining it. If the policy listener object gets destroyed because getting
4003         resolved, we now use "Use" policy action in its dealloc function to maintain previous
4004         behavior.
4005
4006         * WebCoreSupport/WebFrameLoaderClient.h:
4007         * WebCoreSupport/WebFrameLoaderClient.mm:
4008         (WebFrameLoaderClient::cancelPolicyCheck):
4009         (WebFrameLoaderClient::setUpPolicyListener):
4010         (-[WebFramePolicyListener dealloc]):
4011
4012 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
4013
4014         Unreviewed, rolling out r232052.
4015
4016         Breaks internal builds.
4017
4018         Reverted changeset:
4019
4020         "Use more C++17"
4021         https://bugs.webkit.org/show_bug.cgi?id=185176
4022         https://trac.webkit.org/changeset/232052
4023
4024 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
4025
4026         Use more C++17
4027         https://bugs.webkit.org/show_bug.cgi?id=185176
4028
4029         Reviewed by JF Bastien.
4030
4031         * Configurations/Base.xcconfig:
4032         * Configurations/WebKitLegacy.xcconfig:
4033
4034 2018-05-21  Chris Nardi  <cnardi@chromium.org>
4035
4036         Remove dead exception in MediaList.appendMedium
4037         https://bugs.webkit.org/show_bug.cgi?id=185278
4038
4039         Reviewed by Chris Dumez.
4040
4041         Remove code pertaining to an exception being thrown by appendMedium().
4042
4043         * DOM/DOMMediaList.mm:
4044         (-[DOMMediaList appendMedium:]):
4045
4046 2018-05-21  Jer Noble  <jer.noble@apple.com>
4047
4048         Complete fix for enabling modern EME by default
4049         https://bugs.webkit.org/show_bug.cgi?id=185770
4050         <rdar://problem/40368220>