Remove InjectedBundle processing of back/forward lists
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2
3         Remove InjectedBundle processing of back/forward lists
4         https://bugs.webkit.org/show_bug.cgi?id=190459
5
6         Reviewed by Chris Dumez.
7
8         * WebCoreSupport/WebFrameLoaderClient.h:
9         * WebCoreSupport/WebFrameLoaderClient.mm:
10         (WebFrameLoaderClient::shouldGoToHistoryItem const):
11
12 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
13
14         [JSC] Remove Option::useAsyncIterator
15         https://bugs.webkit.org/show_bug.cgi?id=190567
16
17         Reviewed by Saam Barati.
18
19         * Configurations/FeatureDefines.xcconfig:
20
21 2018-10-12  Alex Christensen  <achristensen@webkit.org>
22
23         Allow encoding of small enum classes
24         https://bugs.webkit.org/show_bug.cgi?id=190531
25
26         Reviewed by Tim Horton.
27
28         * WebCoreSupport/WebFrameLoaderClient.mm:
29         (-[WebFramePolicyListener dealloc]):
30
31 2018-10-11  Keith Rollin  <krollin@apple.com>
32
33         CURRENT_ARCH should not be used in Run Script phase.
34         https://bugs.webkit.org/show_bug.cgi?id=190407
35         <rdar://problem/45133556>
36
37         Reviewed by Alexey Proskuryakov.
38
39         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
40         CURRENT_ARCH is not well-defined during this phase (and may even have
41         the value "undefined") since this phase is run just once per build
42         rather than once per supported architecture. Migrate away from
43         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
44         performing an operation for each value, or by picking the first entry
45         in ARCHS and using that as a representative value.
46
47         * Configurations/WebKitLegacy.xcconfig: When generating
48         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
49         macosx platforms.
50
51         * MigrateHeaders.make:
52         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
53         generate one for each architecture in ARCHS.
54
55 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
56
57         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
58         https://bugs.webkit.org/show_bug.cgi?id=190429
59
60         Reviewed by Saam Barati.
61
62         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
63
64         * WebView/WebPDFRepresentation.mm:
65         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
66
67 2018-10-08  Justin Fan  <justin_fan@apple.com>
68
69         WebGPU: Rename old WebGPU prototype to WebMetal
70         https://bugs.webkit.org/show_bug.cgi?id=190325
71         <rdar://problem/44990443>
72
73         Reviewed by Dean Jackson.
74
75         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
76
77         * Configurations/FeatureDefines.xcconfig:
78         * WebView/WebPreferenceKeysPrivate.h:
79         * WebView/WebPreferences.mm:
80         (+[WebPreferences initialize]):
81         (-[WebPreferences webMetalEnabled]):
82         (-[WebPreferences setWebMetalEnabled:]):
83         (-[WebPreferences webGPUEnabled]): Deleted.
84         (-[WebPreferences setWebGPUEnabled:]): Deleted.
85         * WebView/WebPreferencesPrivate.h:
86         * WebView/WebView.mm:
87         (-[WebView _preferencesChanged:]):
88
89 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
90
91         Make <input type=color> a runtime enabled (on-by-default) feature
92         https://bugs.webkit.org/show_bug.cgi?id=189162
93
94         Reviewed by Wenson Hsieh and Tim Horton.
95
96         * Configurations/FeatureDefines.xcconfig:
97
98 2018-10-07  Dan Bernstein  <mitz@apple.com>
99
100         Fixed building with the latest macOS SDK
101
102         * Plugins/WebNetscapePluginPackage.mm:
103         (-[WebNetscapePluginPackage openResourceFile]):
104         (-[WebNetscapePluginPackage closeResourceFile:]):
105
106 2018-10-04  Dan Bernstein  <mitz@apple.com>
107
108         More Carbon build-fixing.
109
110         * Carbon/CarbonWindowAdapter.mm:
111         (-[CarbonWindowAdapter _destroyRealWindow:]):
112         (-[CarbonWindowAdapter _growBoxRect]):
113
114 2018-10-04  Dan Bernstein  <mitz@apple.com>
115
116         Retried to fix 32-bit macOS builds after r236846.
117
118         * WebView/WebHTMLView.mm:
119         (-[WebHTMLView setMarkedText:selectedRange:]):
120
121 2018-10-04  Dan Bernstein  <mitz@apple.com>
122
123         Retried to fix 32-bit macOS builds after r236846.
124
125         * Carbon/HIWebView.mm:
126         (ActiveStateChanged):
127
128 2018-10-04  Dan Bernstein  <mitz@apple.com>
129
130         Tried to fix 32-bit macOS builds after r236846.
131
132         * Carbon/HIWebView.mm:
133         (_NSSelectorForHICommand):
134
135 2018-10-04  Dan Bernstein  <mitz@apple.com>
136
137         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
138         https://bugs.webkit.org/show_bug.cgi?id=190250
139
140         Reviewed by Andy Estes.
141
142         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
143           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
144           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
145           an earlier line set it to YES.
146
147         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
148         changes below.
149
150         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
151           provides some missing method declarations.
152
153         * Misc/WebDownload.mm:
154         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
155           a deprecated method.
156
157         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
158
159         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
160           other code in the file uses a method from it.
161
162         * Plugins/WebBaseNetscapePluginView.mm:
163         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
164           a deprecated method.
165
166         * Plugins/WebPluginController.mm:
167         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
168           around use of a selector that may be present in some WebKit client.
169
170         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
171           method declarations.
172
173         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
174           from here.
175
176         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
177           missing method declarations.
178
179         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
180           from here.
181
182         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
183           call from here.
184         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
185           an obsolete delegate method for binary compatibility.
186         (pluginView): Ditto.
187
188         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
189           call from here.
190
191         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
192           WebDeviceOrientationProviderMock protocol.
193
194         * WebView/WebDeviceOrientationProviderMock.mm:
195         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
196           main @implementation.
197
198         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
199           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
200
201         * WebView/WebDynamicScrollBarsView.mm:
202         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
203           of a deprecated method.
204
205         * WebView/WebHTMLView.mm:
206         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
207           selector warning around action methods that are not declared anywhere in WebKit.
208
209         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
210           about implementing this deprecated method.
211         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
212         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
213         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
214         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
215         (-[WebHTMLView characterIndexForPoint:]): Ditto.
216         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
217         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
218         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
219         (-[WebHTMLView doCommandBySelector:]): Ditto.
220         (-[WebHTMLView insertText:]): Ditto.
221
222         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
223
224         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
225
226         * WebView/WebPDFView.h: Removed previewView ivar.
227
228         * WebView/WebPDFView.mm:
229           Removed declaration of FileInternal category and merged its implementation with the main
230           implementation.
231         (-[WebPDFView dealloc]): Removed previewView ivar.
232         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
233           exist in macOS versions we support.
234         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
235         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
236           action methods internal to PDFKit.
237         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
238         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
239
240         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
241           call on macOS, even though in r86988 we started calling different methods on iOS.
242
243         * WebView/WebView.mm:
244         - Imported headers that declare delegate methods that we call.
245         - Removed declaration of WebFileInternal category and merged its implementation with the
246           main implementation.
247         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
248           category, which made them impossible to call from the main implementation. Moved those
249           into the main implementation. One of those had to be declared in a class extension,
250           because it is called from a method implemented in the WebPrivate category, and that
251           category’s implementation appears first in the file.
252
253         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
254           around use of obsolete delegate method for binary compatibility.
255
256         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
257
258 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
259
260         Runtime flag and IDL for MediaRecorder
261         https://bugs.webkit.org/show_bug.cgi?id=190018
262
263         Reviewed by Youenn Fablet and Chris Dumez.
264
265         * WebView/WebPreferenceKeysPrivate.h:
266         * WebView/WebPreferences.mm:
267         (+[WebPreferences initialize]):
268         (-[WebPreferences mediaRecorderEnabled]):
269         (-[WebPreferences setMediaRecorderEnabled:]):
270         * WebView/WebPreferencesPrivate.h:
271         * WebView/WebView.mm:
272         (-[WebView _preferencesChanged:]):
273
274 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
275
276         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
277         https://bugs.webkit.org/show_bug.cgi?id=190238
278
279         Reviewed by Antti Koivisto.
280
281         Enabled the feature by default.
282
283         * WebView/WebPreferences.mm:
284         (+[WebPreferences initialize]):
285
286 2018-10-01  Dean Jackson  <dino@apple.com>
287
288         [macOS] Switching to discrete GPU should be done in the UI process
289         https://bugs.webkit.org/show_bug.cgi?id=189361
290         <rdar://problem/43949622>
291
292         Reviewed by Simon Fraser.
293
294         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
295         not support swapping to the discrete GPU in this configuration.
296
297         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
298         (WebKit::WebSwitchingGPUClient::singleton):
299         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
300         * WebView/WebView.mm:
301         (-[WebView _commonInitializationWithFrameName:groupName:]):
302
303 2018-10-02  Alex Christensen  <achristensen@webkit.org>
304
305         Remove ParsedURLString
306         https://bugs.webkit.org/show_bug.cgi?id=190154
307
308         Reviewed by Chris Dumez.
309
310         * WebView/WebScriptDebugger.mm:
311         (toNSURL):
312
313 2018-10-01  Dean Jackson  <dino@apple.com>
314
315         Remove CSS Animation Triggers
316         https://bugs.webkit.org/show_bug.cgi?id=190175
317         <rdar://problem/44925626>
318
319         Reviewed by Simon Fraser.
320
321         * Configurations/FeatureDefines.xcconfig:
322
323 2018-10-02  Commit Queue  <commit-queue@webkit.org>
324
325         Unreviewed, rolling out r236624 and r236671.
326         https://bugs.webkit.org/show_bug.cgi?id=190207
327
328         The change in r236624 introduced crashes on the bots
329         (Requested by ryanhaddad on #webkit).
330
331         Reverted changesets:
332
333         "Refactoring: eliminate raw pointer usage in Fullscreen code"
334         https://bugs.webkit.org/show_bug.cgi?id=188747
335         https://trac.webkit.org/changeset/236624
336
337         "Unify implementation in VideoFullscreenInterfaceAVKit"
338         https://bugs.webkit.org/show_bug.cgi?id=190091
339         https://trac.webkit.org/changeset/236671
340
341 2018-10-01  Alex Christensen  <achristensen@webkit.org>
342
343         URL should not use TextEncoding internally
344         https://bugs.webkit.org/show_bug.cgi?id=190111
345
346         Reviewed by Andy Estes.
347
348         * Misc/WebNSURLExtras.mm:
349
350 2018-09-28  Jer Noble  <jer.noble@apple.com>
351
352         Refactoring: eliminate raw pointer usage in Fullscreen code
353         https://bugs.webkit.org/show_bug.cgi?id=188747
354         <rdar://problem/43541164>
355
356         Reviewed by Alex Christensen.
357
358         PlaybackSessionInterface no longer has an invalidate() method.
359
360         * WebView/WebView.mm:
361         (-[WebView _clearPlaybackControlsManager]):
362
363 2018-09-28  Chris Dumez  <cdumez@apple.com>
364
365         Drop support for cross-origin-window-policy header
366         https://bugs.webkit.org/show_bug.cgi?id=190081
367
368         Reviewed by Ryosuke Niwa.
369
370         * WebView/WebPreferenceKeysPrivate.h:
371         * WebView/WebPreferences.mm:
372         (+[WebPreferences initialize]):
373         * WebView/WebPreferencesPrivate.h:
374         * WebView/WebView.mm:
375         (-[WebView _preferencesChanged:]):
376
377 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
378
379         Rename createMarkup to serializePreservingVisualAppearance
380         https://bugs.webkit.org/show_bug.cgi?id=190086
381
382         Reviewed by Wenson Hsieh.
383
384         * DOM/WebDOMOperations.mm:
385         (-[DOMRange markupString]):
386
387 2018-09-28  Commit Queue  <commit-queue@webkit.org>
388
389         Unreviewed, rolling out r236605.
390         https://bugs.webkit.org/show_bug.cgi?id=190087
391
392         caused three API test timeouts (Requested by jernoble on
393         #webkit).
394
395         Reverted changeset:
396
397         "Refactoring: eliminate raw pointer usage in Fullscreen code"
398         https://bugs.webkit.org/show_bug.cgi?id=188747
399         https://trac.webkit.org/changeset/236605
400
401 2018-09-28  Jer Noble  <jer.noble@apple.com>
402
403         Refactoring: eliminate raw pointer usage in Fullscreen code
404         https://bugs.webkit.org/show_bug.cgi?id=188747
405         <rdar://problem/43541164>
406
407         Reviewed by Alex Christensen.
408
409         PlaybackSessionInterface no longer has an invalidate() method.
410
411         * WebView/WebView.mm:
412         (-[WebView _clearPlaybackControlsManager]):
413
414 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
415
416         Use enum class in createMarkup arguments
417         https://bugs.webkit.org/show_bug.cgi?id=190028
418
419         Reviewed by Wenson Hsieh.
420
421         * DOM/WebDOMOperations.mm:
422         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
423         (-[DOMRange markupString]): Ditto.
424
425 2018-09-27  Antoine Quint  <graouts@apple.com>
426
427         [Web Animations] Turn Web Animations with CSS integration on
428         https://bugs.webkit.org/show_bug.cgi?id=184819
429         <rdar://problem/39597337>
430
431         Reviewed by Dean Jackson.
432
433         * WebView/WebPreferences.mm:
434         (+[WebPreferences initialize]):
435
436 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
437
438         Selection should work across shadow boundary when initiated by a mouse drag
439         https://bugs.webkit.org/show_bug.cgi?id=151380
440         <rdar://problem/24363872>
441
442         Reviewed by Wenson Hsieh.
443
444         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
445
446         * WebView/WebPreferenceKeysPrivate.h:
447         * WebView/WebPreferences.mm:
448         (+[WebPreferences initialize]):
449         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
450         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
451         * WebView/WebPreferencesPrivate.h:
452         * WebView/WebView.mm:
453         (-[WebView _preferencesChanged:]):
454
455 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
456
457         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
458         https://bugs.webkit.org/show_bug.cgi?id=189918
459         Work towards <rdar://problem/44648705>
460
461         Reviewed by Tim Horton.
462
463         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
464
465         * WebView/WebHTMLView.mm:
466         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
467         (-[WebHTMLView _updateFontPanel]):
468         * WebView/WebView.mm:
469         (-[WebView typingAttributes]):
470
471 2018-09-17  Darin Adler  <darin@apple.com>
472
473         Use OpaqueJSString rather than JSRetainPtr inside WebKit
474         https://bugs.webkit.org/show_bug.cgi?id=189652
475
476         Reviewed by Saam Barati.
477
478         * WebView/WebPDFRepresentation.mm:
479         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
480
481 2018-09-14  Jer Noble  <jer.noble@apple.com>
482
483         Turn SourceBufferChangeTypeEnabled on by default
484         https://bugs.webkit.org/show_bug.cgi?id=189527
485
486         Reviewed by Eric Carlson.
487
488         * WebView/WebPreferences.mm:
489         (+[WebPreferences initialize]):
490
491 2018-09-12  Alex Christensen  <achristensen@webkit.org>
492
493         Fix an internal build after r235935
494         https://bugs.webkit.org/show_bug.cgi?id=188996
495
496         * Carbon/HIWebView.mm:
497         (Draw):
498         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
499
500 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
501
502         Add IGNORE_WARNING_.* macros
503         https://bugs.webkit.org/show_bug.cgi?id=188996
504
505         Reviewed by Michael Catanzaro.
506
507         * Carbon/CarbonUtils.m:
508         (PoolCleaner):
509         * Carbon/CarbonWindowAdapter.mm:
510         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
511         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
512         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
513         (-[CarbonWindowAdapter _termWindowIfOwner]):
514         (-[CarbonWindowAdapter _windowMovedToRect:]):
515         (-[CarbonWindowAdapter setContentView:]):
516         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
517         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
518         * Carbon/CarbonWindowFrame.m:
519         (-[CarbonWindowFrame title]):
520         * Carbon/HIViewAdapter.m:
521         (+[HIViewAdapter getHIViewForNSView:]):
522         * Carbon/HIWebView.mm:
523         (overrideCGContext):
524         (restoreCGContext):
525         (Draw):
526         * DOM/DOM.mm:
527         * History/WebHistory.mm:
528         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
529         * History/WebHistoryItem.mm:
530         (-[WebHistoryItem icon]):
531         * Misc/WebKitNSStringExtras.mm:
532         (-[NSString _web_drawAtPoint:font:textColor:]):
533         * Misc/WebNSImageExtras.m:
534         (-[NSImage _web_scaleToMaxSize:]):
535         (-[NSImage _web_dissolveToFraction:]):
536         * Misc/WebNSPasteboardExtras.mm:
537         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
538         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
539         * Panels/WebAuthenticationPanel.m:
540         (-[WebAuthenticationPanel loadNib]):
541         * Plugins/Hosted/NetscapePluginHostManager.mm:
542         (WebKit::NetscapePluginHostManager::spawnPluginHost):
543         (WebKit::NetscapePluginHostManager::didCreateWindow):
544         * Plugins/Hosted/NetscapePluginHostProxy.mm:
545         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
546         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
547         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
548         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
549         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
550         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
551         (-[WebHostedNetscapePluginView drawRect:]):
552         * Plugins/Hosted/WebTextInputWindowController.m:
553         (-[WebTextInputPanel _interpretKeyEvent:string:]):
554         * Plugins/WebBaseNetscapePluginView.mm:
555         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
556         * Plugins/WebNetscapePluginPackage.mm:
557         (-[WebNetscapePluginPackage _tryLoad]):
558         * Plugins/WebNetscapePluginView.mm:
559         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
560         (-[WebNetscapePluginView sendDrawRectEvent:]):
561         (-[WebNetscapePluginView drawRect:]):
562         * Plugins/WebPluginController.mm:
563         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
564         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
565         * WebCoreSupport/PopupMenuMac.mm:
566         (PopupMenuMac::populate):
567         * WebCoreSupport/WebAlternativeTextClient.h:
568         * WebCoreSupport/WebDragClient.mm:
569         (WebDragClient::startDrag):
570         * WebCoreSupport/WebFrameLoaderClient.mm:
571         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
572         (webGetNSImage):
573         * WebInspector/WebNodeHighlight.mm:
574         * WebInspector/WebNodeHighlightView.mm:
575         (-[WebNodeHighlightView drawRect:]):
576         * WebView/WebClipView.mm:
577         (-[WebClipView initWithFrame:]):
578         * WebView/WebFrame.mm:
579         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
580         (-[WebFrame _drawRect:contentsOnly:]):
581         (-[WebFrame accessibilityRoot]):
582         * WebView/WebFullScreenController.mm:
583         (-[WebFullScreenController enterFullScreen:]):
584         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
585         (-[WebFullScreenController exitFullScreen]):
586         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
587         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
588         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
589         * WebView/WebHTMLView.mm:
590         (-[NSWindow _web_borderView]):
591         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
592         (-[WebHTMLView _setAsideSubviews]):
593         (-[WebHTMLView _autoscroll]):
594         (-[WebHTMLView drawRect:]):
595         (-[WebHTMLView mouseDown:]):
596         (-[WebHTMLView mouseDragged:]):
597         (-[WebHTMLView mouseUp:]):
598         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
599         (-[WebHTMLView knowsPageRange:]):
600         (-[WebHTMLView accessibilityHitTest:]):
601         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
602         (-[WebHTMLView _colorAsString:]):
603         (-[WebHTMLView copyFont:]):
604         (-[WebHTMLView _executeSavedKeypressCommands]):
605         (-[WebHTMLView attachRootLayer:]):
606         (-[WebHTMLView textStorage]):
607         (-[WebHTMLView _updateSelectionForInputManager]):
608         * WebView/WebPDFView.mm:
609         (_applicationInfoForMIMEType):
610         (-[WebPDFView centerSelectionInVisibleArea:]):
611         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
612         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
613         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
614         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
615         * WebView/WebTextCompletionController.mm:
616         (-[WebTextCompletionController _buildUI]):
617         (-[WebTextCompletionController _placePopupWindow:]):
618         * WebView/WebVideoFullscreenController.mm:
619         * WebView/WebVideoFullscreenHUDWindowController.mm:
620         (createMediaUIBackgroundView):
621         * WebView/WebView.mm:
622         (-[WebTextListTouchBarViewController initWithWebView:]):
623         (-[WebView _dispatchTileDidDraw:]):
624         (-[WebView encodeWithCoder:]):
625         (-[WebView mainFrameIcon]):
626         (LayerFlushController::flushLayers):
627         * WebView/WebWindowAnimation.mm:
628         (setScaledFrameForWindow):
629
630 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
631
632         Remove unused needsDestruction class variables from HashTraits
633         https://bugs.webkit.org/show_bug.cgi?id=189490
634
635         Reviewed by Daniel Bates.
636
637         * History/BinaryPropertyList.cpp: Removed needsDestruction.
638
639 2018-09-07  Frederic Wang  <fwang@igalia.com>
640
641         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
642         https://bugs.webkit.org/show_bug.cgi?id=182230
643
644         Reviewed by Simon Fraser.
645
646         * DOM/DOMDocument.mm:
647         (-[DOMDocument scrollingElement]): Use the new name.
648
649 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
650
651         Refactor WebCore::EditAction to be an 8-bit enum class
652         https://bugs.webkit.org/show_bug.cgi?id=189383
653
654         Reviewed by Dan Bernstein.
655
656         * WebCoreSupport/WebEditorClient.mm:
657         (undoNameForEditAction):
658         * WebView/WebHTMLView.mm:
659         (-[WebHTMLView pasteFont:]):
660         (-[WebHTMLView changeFont:]):
661         (-[WebHTMLView changeAttributes:]):
662         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
663         (-[WebHTMLView changeColor:]):
664         * WebView/WebView.mm:
665         (-[WebView setTypingStyle:]):
666
667 2018-09-06  Frederic Wang  <fwang@igalia.com>
668
669         Group options of scrollRectToVisible into a struct
670         https://bugs.webkit.org/show_bug.cgi?id=189352
671
672         Reviewed by Simon Fraser.
673
674         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
675         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
676         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
677
678 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
679
680         [macOS] Cannot change font size at selection until font panel is shown
681         https://bugs.webkit.org/show_bug.cgi?id=189295
682         <rdar://problem/35593389>
683
684         Reviewed by Ryosuke Niwa.
685
686         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
687         WebCore ChangeLog for more details.
688
689         * WebView/WebHTMLView.mm:
690         (-[WebHTMLView changeFont:]):
691         (-[WebHTMLView changeAttributes:]):
692         (-[WebHTMLView _originalFontA]): Deleted.
693         (-[WebHTMLView _originalFontB]): Deleted.
694         (fontNameForDescription): Deleted.
695         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
696         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
697         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
698
699 2018-09-05  Jer Noble  <jer.noble@apple.com>
700
701         Add MediaCapabilities as an Experimental Feature
702         https://bugs.webkit.org/show_bug.cgi?id=189209
703
704         Reviewed by Eric Carlson.
705
706         RuntimeEnabledFeature -> Setting.
707
708         * WebView/WebView.mm:
709         (-[WebView _preferencesChanged:]):
710
711 2018-09-04  Frederic Wang  <fwang@igalia.com>
712
713         Add basic support for ScrollIntoViewOptions
714         https://bugs.webkit.org/show_bug.cgi?id=189258
715
716         Reviewed by Simon Fraser.
717
718         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
719         header so that this file can build despite the new scrollIntoView function.
720
721 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
722
723         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
724         https://bugs.webkit.org/show_bug.cgi?id=188890
725         <rdar://problem/43648605>
726
727         Reviewed by Tim Horton.
728
729         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
730         more detail.
731
732         * WebCoreSupport/WebPlatformStrategies.h:
733         * WebCoreSupport/WebPlatformStrategies.mm:
734         (WebPlatformStrategies::allStringsForType):
735
736 2018-09-01  Darin Adler  <darin@apple.com>
737
738         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
739         https://bugs.webkit.org/show_bug.cgi?id=189072
740         Reviewed by Dan Bernstein.
741
742         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
743         and declarations for NSURLDownload init methods.
744
745         * Misc/WebDownloadInternal.h: Removed.
746
747         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
748         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
749         "-Wdeprecated-declarations" because the method used here is deprecated.
750
751         * WebView/WebView.mm:
752         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
753         used here is deprecated.
754
755 2018-08-31  Chris Dumez  <cdumez@apple.com>
756
757         Assertion hit in ~CompletionHandler() from ~WebFrame()
758         https://bugs.webkit.org/show_bug.cgi?id=189199
759         <rdar://problem/42657233>
760
761         Reviewed by Youenn Fablet.
762
763         * WebCoreSupport/WebFrameLoaderClient.h:
764         * WebCoreSupport/WebFrameLoaderClient.mm:
765         (WebFrameLoaderClient::dispatchWillSubmitForm):
766
767 2018-08-31  Antti Koivisto  <antti@apple.com>
768
769         Replace OptionSet |= and -= operators with add() and remove() functions
770         https://bugs.webkit.org/show_bug.cgi?id=189169
771
772         Reviewed by Anders Carlsson.
773
774         * WebView/WebFrame.mm:
775         (-[WebFrame _drawRect:contentsOnly:]):
776         * WebView/WebView.mm:
777         (coreOptions):
778
779 2018-08-31  Frederic Wang  <fwang@igalia.com>
780
781         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
782         https://bugs.webkit.org/show_bug.cgi?id=182053
783
784         Reviewed by Simon Fraser.
785
786         Add developer flag to use standard behavior for scrolling* attributes.
787
788         * WebView/WebPreferenceKeysPrivate.h:
789         * WebView/WebPreferences.mm:
790         (+[WebPreferences initialize]):
791         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
792         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
793         * WebView/WebPreferencesPrivate.h:
794         * WebView/WebView.mm:
795         (-[WebView _preferencesChanged:]):
796
797 2018-08-29  Olivia Barnett  <obarnett@apple.com>
798
799         Implement the Web Share API
800         https://bugs.webkit.org/show_bug.cgi?id=171100
801         <rdar://problem/31751734>
802
803         Reviewed by Tim Horton.
804
805         * WebCoreSupport/WebChromeClient.h:
806         * WebCoreSupport/WebChromeClient.mm:
807         (WebChromeClient::showShareSheet):
808         Empty declaration of showShareSheet.
809
810 2018-08-29  Youenn Fablet  <youenn@apple.com>
811
812         Remove WebRTC legacy API implementation
813         https://bugs.webkit.org/show_bug.cgi?id=189040
814
815         Reviewed by Eric Carlson.
816
817         * WebView/WebPreferenceKeysPrivate.h:
818         * WebView/WebPreferences.mm:
819         (+[WebPreferences initialize]):
820         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
821         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
822         * WebView/WebPreferencesPrivate.h:
823         * WebView/WebView.mm:
824         (-[WebView _preferencesChanged:]):
825
826 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
827
828         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
829         https://bugs.webkit.org/show_bug.cgi?id=189054
830
831         Reviewed by Andy Estes.
832
833         Remove the pasteboard type argument from readURLFromPasteboard.
834
835         * WebCoreSupport/WebPlatformStrategies.h:
836         * WebCoreSupport/WebPlatformStrategies.mm:
837         (WebPlatformStrategies::readURLFromPasteboard):
838
839 2018-08-27  Keith Rollin  <krollin@apple.com>
840
841         Unreviewed build fix -- disable LTO for production builds
842
843         * Configurations/Base.xcconfig:
844
845 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
846
847         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
848         https://bugs.webkit.org/show_bug.cgi?id=188931
849
850         Reviewed by Wenson Hsieh.
851
852         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
853
854 2018-08-27  Keith Rollin  <krollin@apple.com>
855
856         Build system support for LTO
857         https://bugs.webkit.org/show_bug.cgi?id=187785
858         <rdar://problem/42353132>
859
860         Reviewed by Dan Bernstein.
861
862         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
863         LTO.
864
865         * Configurations/Base.xcconfig:
866         * Configurations/DebugRelease.xcconfig:
867
868 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
869
870         Pass in IsComposed flag to Event constructors
871         https://bugs.webkit.org/show_bug.cgi?id=188720
872         <rdar://problem/43580387>
873
874         Reviewed by Simon Fraser.
875
876         * WebView/WebPDFView.mm:
877         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
878         whether it's simulated or not.
879
880 2018-08-23  Mark Lam  <mark.lam@apple.com>
881
882         Move vmEntryGlobalObject() to VM from CallFrame.
883         https://bugs.webkit.org/show_bug.cgi?id=188900
884         <rdar://problem/43655753>
885
886         Reviewed by Michael Saboff.
887
888         * WebView/WebScriptDebugger.mm:
889         (WebScriptDebugger::sourceParsed):
890
891 2018-08-23  Andy Estes  <aestes@apple.com>
892
893         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
894         https://bugs.webkit.org/show_bug.cgi?id=188829
895
896         Reviewed by Tim Horton.
897
898         * Configurations/FeatureDefines.xcconfig:
899
900 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
901
902         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
903         https://bugs.webkit.org/show_bug.cgi?id=188777
904
905         Reviewed by Simon Fraser.
906
907         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
908         being "true" before the code change.
909
910         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
911
912         * WebView/WebPDFView.mm:
913         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
914
915 2018-08-21  Daniel Bates  <dabates@apple.com>
916
917         Replace TextCheckingTypeMask with OptionSet
918         https://bugs.webkit.org/show_bug.cgi?id=188678
919
920         Reviewed by Antti Koivisto.
921
922         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
923         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
924         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
925         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
926
927         * WebCoreSupport/WebEditorClient.h:
928         * WebCoreSupport/WebEditorClient.mm:
929         (WebEditorClient::checkTextOfParagraph):
930         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
931         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
932         left as this is more readable and unncessary now that modern compilers like Clang have
933         diagnostics to catch accidental assignments when equality was intended.
934         (WebEditorClient::didCheckSucceed):
935         * WebView/WebView.mm:
936         (coreTextCheckingType):
937         (textCheckingResultFromNSTextCheckingResult):
938
939 2018-08-21  Daniel Bates  <dabates@apple.com>
940
941         [iOS][WK1] Support toggling continuous spell checking from tests
942         https://bugs.webkit.org/show_bug.cgi?id=188763
943
944         Reviewed by Simon Fraser.
945
946         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
947         spell checking from tests in iOS WebKit Legacy.
948
949         * WebCoreSupport/WebEditorClient.h:
950         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
951         * WebCoreSupport/WebEditorClient.mm:
952         * WebView/WebView.h:
953         * WebView/WebView.mm:
954         (-[WebView toggleContinuousSpellChecking:]):
955         (-[WebView toggleSmartInsertDelete:]):
956
957 2018-08-17  Alex Christensen  <achristensen@webkit.org>
958
959         Add some plumbing for safe browsing
960         https://bugs.webkit.org/show_bug.cgi?id=188709
961
962         Reviewed by Tim Horton.
963
964         * WebCoreSupport/WebFrameLoaderClient.h:
965         * WebCoreSupport/WebFrameLoaderClient.mm:
966         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
967
968 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
969
970         Replace canBubble and cancelable booleans in Event by enum classes
971         https://bugs.webkit.org/show_bug.cgi?id=188692
972
973         Reviewed by Alex Christensen.
974
975         * WebView/WebPDFView.mm:
976         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
977         * WebView/WebView.mm:
978         (-[WebView _dispatchUnloadEvent]):
979
980 2018-08-16  Jer Noble  <jer.noble@apple.com>
981
982         Add Experimental Feature support for SourceBuffer.changeType()
983         https://bugs.webkit.org/show_bug.cgi?id=188626
984         <rdar://problem/43356021>
985
986         Reviewed by Eric Carlson.
987
988         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
989
990         * WebView/WebPreferenceKeysPrivate.h:
991         * WebView/WebPreferences.mm:
992         (+[WebPreferences initialize]):
993         (-[WebPreferences sourceBufferChangeTypeEnabled]):
994         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
995         * WebView/WebPreferencesPrivate.h:
996         * WebView/WebView.mm:
997         (-[WebView _preferencesChanged:]):
998
999 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
1000
1001         Support drag-and-drop for input[type=color]
1002         https://bugs.webkit.org/show_bug.cgi?id=188464
1003
1004         Reviewed by Wenson Hsieh.
1005
1006         * WebCoreSupport/WebPlatformStrategies.h:
1007         * WebCoreSupport/WebPlatformStrategies.mm:
1008         (WebPlatformStrategies::setColor):
1009
1010 2018-08-15  Tim Horton  <timothy_horton@apple.com>
1011
1012         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
1013         https://bugs.webkit.org/show_bug.cgi?id=188569
1014         <rdar://problem/34201095>
1015
1016         Reviewed by Megan Gardner.
1017
1018         * WebView/WebImmediateActionController.mm:
1019         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1020         Speculative fix; the crashes indicate font is null, but we just checked it,
1021         so it must be getting made null by convertFont:toSize:. Check again!
1022
1023 2018-08-13  Alex Christensen  <achristensen@webkit.org>
1024
1025         Use a 1-byte enum class for TextDirection
1026         https://bugs.webkit.org/show_bug.cgi?id=188350
1027
1028         Reviewed by Simon Fraser.
1029
1030         * WebCoreSupport/PopupMenuMac.mm:
1031         (PopupMenuMac::populate):
1032         (PopupMenuMac::show):
1033         * WebCoreSupport/WebFrameLoaderClient.mm:
1034         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1035         * WebView/WebFrame.mm:
1036         (-[WebFrame _dispatchDidReceiveTitle:]):
1037
1038 2018-08-09  Ali Juma  <ajuma@chromium.org>
1039
1040         Import WPTs for IntersectionObserver
1041         https://bugs.webkit.org/show_bug.cgi?id=188416
1042
1043         Reviewed by Simon Fraser.
1044
1045         * WebView/WebPreferencesPrivate.h:
1046
1047 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
1048
1049         Follow-up build fix for r234685
1050         https://bugs.webkit.org/show_bug.cgi?id=188245
1051
1052         Unreviewed build fix.
1053
1054         * WebCoreSupport/WebSecurityOriginPrivate.h:
1055
1056 2018-08-05  Darin Adler  <darin@apple.com>
1057
1058         [Cocoa] More tweaks and refactoring to prepare for ARC
1059         https://bugs.webkit.org/show_bug.cgi?id=188245
1060
1061         Reviewed by Dan Bernstein.
1062
1063         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
1064
1065         * Carbon/CarbonWindowFrame.m:
1066         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
1067
1068         * DOM/DOM.mm:
1069         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
1070         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
1071         garbage collection so this method isn't useful.
1072
1073         * DOM/DOMXPath.mm:
1074         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
1075         Objective-C garbage collection so this method isn't useful.
1076
1077         * History/WebHistory.mm:
1078         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
1079
1080         * Misc/WebElementDictionary.mm:
1081         (addLookupKey): Use a bridging cast.
1082         (cacheValueForKey): Ditto.
1083         (-[WebElementDictionary _fillCache]): Ditto.
1084         (-[WebElementDictionary objectForKey:]): Ditto.
1085
1086         * Misc/WebKitNSStringExtras.mm:
1087         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
1088         (-[NSString _web_widthWithFont:]): Ditto.
1089         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
1090
1091         * Misc/WebLocalizableStrings.mm:
1092         (WebLocalizedString): Use a bridging cast.
1093
1094         * Misc/WebNSDataExtras.mm:
1095         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
1096         and use CFBridgingRelease instead of calling autorelease directly.
1097         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
1098         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
1099         on the amount of explicit release and autorelease.
1100
1101         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
1102         * Misc/WebNSDictionaryExtras.m:
1103         (-[NSDictionary _webkit_intForKey:]): Deleted.
1104         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
1105         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
1106         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
1107         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
1108         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
1109         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
1110
1111         * Misc/WebStringTruncator.mm:
1112         (fontFromNSFont): Use a bridging cast.
1113
1114         * Plugins/Hosted/NetscapePluginHostManager.mm:
1115         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
1116
1117         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1118         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
1119         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
1120         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
1121         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
1122         * Plugins/Hosted/ProxyInstance.mm:
1123         (WebKit::ProxyInstance::getPropertyNames): Ditto.
1124         * Plugins/WebBasePluginPackage.mm:
1125         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
1126         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1127         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
1128         * Plugins/WebNetscapePluginPackage.mm:
1129         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
1130
1131         * Plugins/WebNetscapePluginView.mm:
1132         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
1133         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
1134         (-[WebNetscapePluginView status:]): Use a bridging cast.
1135         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
1136
1137         * Plugins/WebPluginController.mm:
1138         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
1139
1140         * Plugins/WebPluginDatabase.mm:
1141         (checkCandidate): Use explicit __strong for out argument types.
1142
1143         * Plugins/npapi.mm:
1144         (pluginViewForInstance): Use a bridging cast.
1145
1146         * Storage/WebDatabaseManager.mm:
1147         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
1148         explicit NSNumber and NSDictionary calls.
1149
1150         * WebCoreSupport/WebContextMenuClient.mm:
1151         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
1152
1153         * WebCoreSupport/WebEditorClient.mm:
1154         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
1155         (WebEditorClient::handleInputMethodKeydown): Ditto.
1156
1157         * WebCoreSupport/WebFrameNetworkingContext.mm:
1158         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
1159
1160         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
1161         as a struct rather than an Objective-C class, since that's how it's defined.
1162
1163         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
1164
1165         * WebView/WebFullScreenController.mm:
1166         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
1167         * WebView/WebHTMLView.mm:
1168         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1169         Ditto.
1170         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1171
1172         * WebView/WebImmediateActionController.mm:
1173         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
1174         go down to the document and then back to the frame.
1175         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
1176         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
1177         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
1178
1179         * WebView/WebJSPDFDoc.mm:
1180         (jsPDFDocInitialize): Removed some unneeded type casting.
1181         (jsPDFDocFinalize): Ditto.
1182         (jsPDFDocPrint): Use a bridging cast.
1183
1184         * WebView/WebPDFView.mm:
1185         (_applicationInfoForMIMEType): Use bridging casts.
1186
1187         * WebView/WebPreferences.mm:
1188         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
1189         instead of methods from WebNSDictionaryExtras.
1190         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
1191         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
1192         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
1193         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
1194         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
1195
1196         * WebView/WebView.mm:
1197         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
1198         (-[WebView _addToAllWebViewsSet]): Ditto.
1199         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
1200         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
1201         so it can be called from WebViewData methods.
1202
1203         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
1204         method, _windowVisibilityChanged:.
1205
1206         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
1207         called from WebViewData methods.
1208
1209 2018-08-06  Alex Christensen  <achristensen@webkit.org>
1210
1211         Use enum classes and OptionSets for PaintPhase and PaintBehavior
1212         https://bugs.webkit.org/show_bug.cgi?id=188323
1213
1214         Reviewed by Simon Fraser.
1215
1216         * WebCoreSupport/WebContextMenuClient.mm:
1217         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1218         * WebView/WebFrame.mm:
1219         (-[WebFrame _paintBehaviorForDestinationContext:]):
1220         (-[WebFrame _drawRect:contentsOnly:]):
1221         * WebView/WebHTMLView.mm:
1222         (imageFromRect):
1223         (selectionImage):
1224
1225 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1226
1227         Add support for microtasks in workers
1228         https://bugs.webkit.org/show_bug.cgi?id=188246
1229
1230         Reviewed by Darin Adler.
1231
1232         Rename JSMainThreadExecState.h to JSExecState.h.
1233
1234         * DOM/DOMAttr.mm:
1235         * DOM/DOMBlob.mm:
1236         * DOM/DOMCDATASection.mm:
1237         * DOM/DOMCSSCharsetRule.mm:
1238         * DOM/DOMCSSFontFaceRule.mm:
1239         * DOM/DOMCSSImportRule.mm:
1240         * DOM/DOMCSSMediaRule.mm:
1241         * DOM/DOMCSSPageRule.mm:
1242         * DOM/DOMCSSPrimitiveValue.mm:
1243         * DOM/DOMCSSRule.mm:
1244         * DOM/DOMCSSRuleList.mm:
1245         * DOM/DOMCSSStyleDeclaration.mm:
1246         * DOM/DOMCSSStyleRule.mm:
1247         * DOM/DOMCSSStyleSheet.mm:
1248         * DOM/DOMCSSUnknownRule.mm:
1249         * DOM/DOMCSSValue.mm:
1250         * DOM/DOMCSSValueList.mm:
1251         * DOM/DOMCharacterData.mm:
1252         * DOM/DOMComment.mm:
1253         * DOM/DOMCounter.mm:
1254         * DOM/DOMDocument.mm:
1255         * DOM/DOMDocumentFragment.mm:
1256         * DOM/DOMDocumentType.mm:
1257         * DOM/DOMElement.mm:
1258         * DOM/DOMEvent.mm:
1259         * DOM/DOMFile.mm:
1260         * DOM/DOMFileList.mm:
1261         * DOM/DOMHTML.mm:
1262         * DOM/DOMHTMLAnchorElement.mm:
1263         * DOM/DOMHTMLAppletElement.mm:
1264         * DOM/DOMHTMLAreaElement.mm:
1265         * DOM/DOMHTMLBRElement.mm:
1266         * DOM/DOMHTMLBaseElement.mm:
1267         * DOM/DOMHTMLBaseFontElement.mm:
1268         * DOM/DOMHTMLBodyElement.mm:
1269         * DOM/DOMHTMLButtonElement.mm:
1270         * DOM/DOMHTMLCanvasElement.mm:
1271         * DOM/DOMHTMLCollection.mm:
1272         * DOM/DOMHTMLDListElement.mm:
1273         * DOM/DOMHTMLDirectoryElement.mm:
1274         * DOM/DOMHTMLDivElement.mm:
1275         * DOM/DOMHTMLDocument.mm:
1276         * DOM/DOMHTMLElement.mm:
1277         * DOM/DOMHTMLEmbedElement.mm:
1278         * DOM/DOMHTMLFieldSetElement.mm:
1279         * DOM/DOMHTMLFontElement.mm:
1280         * DOM/DOMHTMLFormElement.mm:
1281         * DOM/DOMHTMLFrameElement.mm:
1282         * DOM/DOMHTMLFrameSetElement.mm:
1283         * DOM/DOMHTMLHRElement.mm:
1284         * DOM/DOMHTMLHeadElement.mm:
1285         * DOM/DOMHTMLHeadingElement.mm:
1286         * DOM/DOMHTMLHtmlElement.mm:
1287         * DOM/DOMHTMLIFrameElement.mm:
1288         * DOM/DOMHTMLImageElement.mm:
1289         * DOM/DOMHTMLInputElement.mm:
1290         * DOM/DOMHTMLLIElement.mm:
1291         * DOM/DOMHTMLLabelElement.mm:
1292         * DOM/DOMHTMLLegendElement.mm:
1293         * DOM/DOMHTMLLinkElement.mm:
1294         * DOM/DOMHTMLMapElement.mm:
1295         * DOM/DOMHTMLMarqueeElement.mm:
1296         * DOM/DOMHTMLMediaElement.mm:
1297         * DOM/DOMHTMLMenuElement.mm:
1298         * DOM/DOMHTMLMetaElement.mm:
1299         * DOM/DOMHTMLModElement.mm:
1300         * DOM/DOMHTMLOListElement.mm:
1301         * DOM/DOMHTMLObjectElement.mm:
1302         * DOM/DOMHTMLOptGroupElement.mm:
1303         * DOM/DOMHTMLOptionElement.mm:
1304         * DOM/DOMHTMLOptionsCollection.mm:
1305         * DOM/DOMHTMLParagraphElement.mm:
1306         * DOM/DOMHTMLParamElement.mm:
1307         * DOM/DOMHTMLPreElement.mm:
1308         * DOM/DOMHTMLQuoteElement.mm:
1309         * DOM/DOMHTMLScriptElement.mm:
1310         * DOM/DOMHTMLSelectElement.mm:
1311         * DOM/DOMHTMLStyleElement.mm:
1312         * DOM/DOMHTMLTableCaptionElement.mm:
1313         * DOM/DOMHTMLTableCellElement.mm:
1314         * DOM/DOMHTMLTableColElement.mm:
1315         * DOM/DOMHTMLTableElement.mm:
1316         * DOM/DOMHTMLTableRowElement.mm:
1317         * DOM/DOMHTMLTableSectionElement.mm:
1318         * DOM/DOMHTMLTextAreaElement.mm:
1319         * DOM/DOMHTMLTitleElement.mm:
1320         * DOM/DOMHTMLUListElement.mm:
1321         * DOM/DOMHTMLVideoElement.mm:
1322         * DOM/DOMImplementation.mm:
1323         * DOM/DOMKeyboardEvent.mm:
1324         * DOM/DOMMediaError.mm:
1325         * DOM/DOMMediaList.mm:
1326         * DOM/DOMMouseEvent.mm:
1327         * DOM/DOMMutationEvent.mm:
1328         * DOM/DOMNamedNodeMap.mm:
1329         * DOM/DOMNode.mm:
1330         * DOM/DOMNodeIterator.mm:
1331         * DOM/DOMNodeList.mm:
1332         * DOM/DOMOverflowEvent.mm:
1333         * DOM/DOMProcessingInstruction.mm:
1334         * DOM/DOMProgressEvent.mm:
1335         * DOM/DOMRGBColor.mm:
1336         * DOM/DOMRange.mm:
1337         * DOM/DOMRect.mm:
1338         * DOM/DOMStyleSheet.mm:
1339         * DOM/DOMStyleSheetList.mm:
1340         * DOM/DOMText.mm:
1341         * DOM/DOMTextEvent.mm:
1342         * DOM/DOMTimeRanges.mm:
1343         * DOM/DOMTokenList.mm:
1344         * DOM/DOMTreeWalker.mm:
1345         * DOM/DOMUIEvent.mm:
1346         * DOM/DOMWheelEvent.mm:
1347         * DOM/DOMXPathExpression.mm:
1348         * DOM/DOMXPathResult.mm:
1349         * DOM/ObjCEventListener.mm:
1350
1351 2018-08-03  Alex Christensen  <achristensen@webkit.org>
1352
1353         Fix spelling of "overridden"
1354         https://bugs.webkit.org/show_bug.cgi?id=188315
1355
1356         Reviewed by Darin Adler.
1357
1358         * Misc/WebKitVersionChecks.mm:
1359         (setWebKitLinkTimeVersion):
1360         (WebKitLinkTimeVersion):
1361         * Plugins/WebBaseNetscapePluginView.mm:
1362         (-[WebBaseNetscapePluginView handleMouseMoved:]):
1363         * WebCoreSupport/PopupMenuMac.mm:
1364         (PopupMenuMac::populate):
1365
1366 2018-08-01  Nan Wang  <n_wang@apple.com>
1367
1368         AX: AOM: Add ARIA IDL Attribute Reflection
1369         https://bugs.webkit.org/show_bug.cgi?id=184676
1370         <rdar://problem/39476882>
1371
1372         Reviewed by Chris Fleizach.
1373
1374         * WebView/WebPreferenceKeysPrivate.h:
1375         * WebView/WebPreferences.mm:
1376         (+[WebPreferences initialize]):
1377         (-[WebPreferences ariaReflectionEnabled]):
1378         (-[WebPreferences setAriaReflectionEnabled:]):
1379         * WebView/WebPreferencesPrivate.h:
1380         * WebView/WebView.mm:
1381         (-[WebView _preferencesChanged:]):
1382
1383 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
1384
1385         Shrink GraphicsLayerCA
1386         https://bugs.webkit.org/show_bug.cgi?id=188141
1387
1388         Reviewed by Zalan Bujtas.
1389
1390         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
1391         * moving all the clone-related stuff into the lazily-allocated m_layerClones
1392         * moving all the animation-related stuff into the lazily-allocated m_animations
1393         * making enums be 8-bit
1394         * re-ordering data members
1395
1396         * WebView/WebView.mm:
1397         (-[WebView _setMediaLayer:forPluginView:]):
1398
1399 2018-07-30  Rob Buis  <rbuis@igalia.com>
1400
1401         Merge PlatformCookieJar functions into NetworkStorageSession
1402         https://bugs.webkit.org/show_bug.cgi?id=188137
1403
1404         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1405
1406         Reviewed by Alex Christensen.
1407
1408         * WebCoreSupport/WebPlatformStrategies.mm:
1409         (WebPlatformStrategies::cookiesForDOM):
1410         (WebPlatformStrategies::setCookiesFromDOM):
1411         (WebPlatformStrategies::cookiesEnabled):
1412         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1413         (WebPlatformStrategies::getRawCookies):
1414         (WebPlatformStrategies::deleteCookie):
1415         * WebView/WebPreferences.mm:
1416         (+[WebPreferences _clearNetworkLoaderSession]):
1417
1418 2018-07-28  Darin Adler  <darin@apple.com>
1419
1420         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
1421         https://bugs.webkit.org/show_bug.cgi?id=188140
1422
1423         Reviewed by Sam Weinig.
1424
1425         * WebView/WebImmediateActionController.mm:
1426         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
1427         new DictionaryLookup function that returns a tuple instead of using an out argument.
1428
1429 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
1430
1431         [INTL] Remove INTL sub-feature compile flags
1432         https://bugs.webkit.org/show_bug.cgi?id=188081
1433
1434         Reviewed by Michael Catanzaro.
1435
1436         * Configurations/FeatureDefines.xcconfig:
1437
1438 2018-07-26  Commit Queue  <commit-queue@webkit.org>
1439
1440         Unreviewed, rolling out r234181 and r234189.
1441         https://bugs.webkit.org/show_bug.cgi?id=188075
1442
1443         These are not needed right now (Requested by thorton on
1444         #webkit).
1445
1446         Reverted changesets:
1447
1448         "Enable Web Content Filtering on watchOS"
1449         https://bugs.webkit.org/show_bug.cgi?id=187979
1450         https://trac.webkit.org/changeset/234181
1451
1452         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
1453         https://bugs.webkit.org/show_bug.cgi?id=187985
1454         https://trac.webkit.org/changeset/234189
1455
1456 2018-07-26  Timothy Hatcher  <timothy@apple.com>
1457
1458         Use the Page's appearance when converting pasteboard attributed strings.
1459         https://bugs.webkit.org/show_bug.cgi?id=188067
1460         rdar://problem/42632246
1461
1462         Reviewed by Wenson Hsieh.
1463
1464         * WebCoreSupport/WebEditorClient.mm:
1465         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
1466
1467 2018-07-25  Chris Dumez  <cdumez@apple.com>
1468
1469         navigator.userAgent may return outdated value after webView.customUserAgent is set
1470         https://bugs.webkit.org/show_bug.cgi?id=188009
1471         <rdar://problem/42566456>
1472
1473         Reviewed by Alex Christensen.
1474
1475         Let the page know when the user agent changes.
1476
1477         * WebView/WebView.mm:
1478         (-[WebView _preferencesChanged:]):
1479         (-[WebView setApplicationNameForUserAgent:]):
1480         (-[WebView _invalidateUserAgentCache]):
1481         (-[WebView setCustomUserAgent:]):
1482         * WebView/WebViewInternal.h:
1483
1484 2018-07-24  Tim Horton  <timothy_horton@apple.com>
1485
1486         Enable Web Content Filtering on watchOS
1487         https://bugs.webkit.org/show_bug.cgi?id=187979
1488         <rdar://problem/42559346>
1489
1490         Reviewed by Wenson Hsieh.
1491
1492         * Configurations/FeatureDefines.xcconfig:
1493
1494 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
1495
1496         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
1497         https://bugs.webkit.org/show_bug.cgi?id=187846
1498
1499         Reviewed by Simon Fraser.
1500
1501         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
1502
1503         * WebView/WebHTMLView.mm:
1504         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
1505         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
1506
1507 2018-07-11  Dean Jackson  <dino@apple.com>
1508
1509         Allow removal of white backgrounds
1510         https://bugs.webkit.org/show_bug.cgi?id=187574
1511         <rdar://problem/41146792>
1512
1513         Reviewed by Simon Fraser.
1514
1515         Add a new WebPreference for punching out white backgrounds.
1516
1517         * WebView/WebPreferenceKeysPrivate.h:
1518         * WebView/WebPreferences.mm:
1519         (+[WebPreferences initialize]):
1520         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
1521         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
1522         * WebView/WebPreferencesPrivate.h:
1523         * WebView/WebView.mm:
1524         (-[WebView _preferencesChanged:]):
1525
1526 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
1527
1528         Ensure WebKit stack is ad-hoc signed
1529         https://bugs.webkit.org/show_bug.cgi?id=187667
1530
1531         Reviewed by Alexey Proskuryakov.
1532
1533         * Configurations/Base.xcconfig:
1534
1535 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
1536
1537         REGRESSION (231276): Attempting to copy an image fails
1538         https://bugs.webkit.org/show_bug.cgi?id=187212
1539         <rdar://problem/41540074>
1540
1541         Reviewed by Ryosuke Niwa.
1542
1543         Renamed methods to make it clear that one URL and one title are being passed in.
1544
1545         * WebCoreSupport/WebPlatformStrategies.h:
1546         * WebCoreSupport/WebPlatformStrategies.mm:
1547         (WebPlatformStrategies::setURL):
1548
1549 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1550
1551         Disable cross-origin-window-policy by default
1552         https://bugs.webkit.org/show_bug.cgi?id=187509
1553
1554         Reviewed by Chris Dumez.
1555
1556         * WebView/WebPreferences.mm:
1557         (+[WebPreferences initialize]):
1558
1559 2018-07-09  Timothy Hatcher  <timothy@apple.com>
1560
1561         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
1562         https://bugs.webkit.org/show_bug.cgi?id=187425
1563         rdar://problem/39948240
1564
1565         Reviewed by Tim Horton.
1566
1567         * WebView/WebView.mm:
1568         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
1569         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
1570         a call in this method to setUseDarkAppearance.
1571         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
1572         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
1573         (-[WebView _updateDefaultAppearance]): Deleted.
1574         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
1575
1576 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
1577
1578         Shrink various loading-related enums to shrink CachedResource
1579         https://bugs.webkit.org/show_bug.cgi?id=187443
1580
1581         Reviewed by Chris Dumez.
1582
1583         * WebCoreSupport/WebFrameLoaderClient.mm:
1584         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1585         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1586         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1587         (WebFrameLoaderClient::dispatchWillSendRequest):
1588         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1589         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1590         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1591         (WebFrameLoaderClient::updateGlobalHistory):
1592         (WebFrameLoaderClient::canHandleRequest const):
1593         * WebView/WebDataSource.mm:
1594         (-[WebDataSource initialRequest]):
1595         (-[WebDataSource request]):
1596
1597 2018-07-09  Commit Queue  <commit-queue@webkit.org>
1598
1599         Unreviewed, rolling out r233612.
1600         https://bugs.webkit.org/show_bug.cgi?id=187475
1601
1602         Revision caused the api test LinkColorWithSystemAppearance to
1603         fail on all systems. (Requested by Truitt on #webkit).
1604
1605         Reverted changeset:
1606
1607         "Semantic colors don't update when accessibility Increase
1608         Contrast mode is enabled."
1609         https://bugs.webkit.org/show_bug.cgi?id=187425
1610         https://trac.webkit.org/changeset/233612
1611
1612 2018-07-06  Timothy Hatcher  <timothy@apple.com>
1613
1614         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
1615         https://bugs.webkit.org/show_bug.cgi?id=187425
1616         rdar://problem/39948240
1617
1618         Reviewed by Tim Horton.
1619
1620         * WebView/WebView.mm:
1621         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
1622         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
1623         a call in this method to setUseDarkAppearance.
1624         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
1625         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
1626         (-[WebView _updateDefaultAppearance]): Deleted.
1627         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
1628
1629 2018-07-05  Timothy Hatcher  <timothy@apple.com>
1630
1631         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
1632         https://bugs.webkit.org/show_bug.cgi?id=187369
1633         rdar://problem/41870420
1634
1635         Reviewed by Tim Horton.
1636
1637         * WebView/WebMediaPlaybackTargetPicker.mm:
1638         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
1639         * WebView/WebView.mm:
1640         (-[WebView _commonInitializationWithFrameName:groupName:]):
1641         (-[WebView _effectiveAppearanceIsDark]):
1642         (-[WebView _updateDefaultAppearance]):
1643         (-[WebView _defaultAppearance]): Deleted.
1644
1645 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
1646
1647         Youtube video pages crash after a couple of minutes
1648         https://bugs.webkit.org/show_bug.cgi?id=187316
1649
1650         Reviewed by Antti Koivisto.
1651
1652         * WebView/WebView.mm:
1653         (-[WebView _preferencesChanged:]):
1654
1655 2018-07-04  Tim Horton  <timothy_horton@apple.com>
1656
1657         Introduce PLATFORM(IOSMAC)
1658         https://bugs.webkit.org/show_bug.cgi?id=187315
1659
1660         Reviewed by Dan Bernstein.
1661
1662         * Configurations/Base.xcconfig:
1663         * Configurations/FeatureDefines.xcconfig:
1664
1665 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1666
1667         [iOS] DataTransfer.getData always returns the empty string when dropping text
1668         https://bugs.webkit.org/show_bug.cgi?id=187130
1669         <rdar://problem/41014117>
1670
1671         Reviewed by Ryosuke Niwa.
1672
1673         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
1674
1675         * WebCoreSupport/WebPlatformStrategies.h:
1676         * WebCoreSupport/WebPlatformStrategies.mm:
1677         (WebPlatformStrategies::allPasteboardItemInfo):
1678
1679 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
1680
1681         [Mac] AirPlay picker uses incorrect theme in Dark mode
1682         https://bugs.webkit.org/show_bug.cgi?id=187054
1683         <rdar://problem/41291093>
1684
1685         Reviewed by Timothy Hatcher.
1686
1687         * WebView/WebMediaPlaybackTargetPicker.mm:
1688         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
1689
1690 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1691
1692         [WTF] Add user-defined literal for ASCIILiteral
1693         https://bugs.webkit.org/show_bug.cgi?id=186839
1694
1695         Reviewed by Darin Adler.
1696
1697         * DOM/ExceptionHandlers.mm:
1698         (raiseDOMErrorException):
1699         * Plugins/Hosted/ProxyInstance.mm:
1700         (WebKit::ProxyInstance::invokeMethod):
1701         * Storage/WebDatabaseProvider.mm:
1702         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
1703
1704 2018-06-22  Timothy Hatcher  <timothy@apple.com>
1705
1706         Recalc styles every time defaultAppearance changes.
1707         https://bugs.webkit.org/show_bug.cgi?id=186866
1708         rdar://problem/41309805
1709
1710         Reviewed by Tim Horton.
1711
1712         * WebView/WebView.mm:
1713         (-[WebView _updateDefaultAppearance]):
1714         (-[WebView _setUseSystemAppearance:]):
1715         (-[WebView _useSystemAppearance]):
1716
1717 2018-06-20  Darin Adler  <darin@apple.com>
1718
1719         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
1720         https://bugs.webkit.org/show_bug.cgi?id=186875
1721
1722         Reviewed by Anders Carlsson.
1723
1724         * WebView/WebHTMLView.mm:
1725         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
1726         to write te file to.
1727         * WebView/WebPreferences.mm:
1728         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
1729         * WebView/WebView.mm:
1730         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
1731
1732 2018-06-12  Darin Adler  <darin@apple.com>
1733
1734         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
1735         https://bugs.webkit.org/show_bug.cgi?id=186526
1736
1737         Reviewed by Anders Carlsson.
1738
1739         * Plugins/Hosted/NetscapePluginHostManager.mm:
1740         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
1741
1742         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1743         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
1744         assignment rather than adoptNS/leakRef.
1745         * Plugins/WebNetscapePluginView.mm:
1746         (-[WebNetscapePluginView createPlugin]): Ditto.
1747
1748         * WebCoreSupport/WebContextMenuClient.mm:
1749         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
1750         RetainPtr::autorelease; no need to autorelease just to pass something as a function
1751         argument, so use RetainPtr::get instead.
1752
1753         * WebView/WebHTMLView.mm:
1754         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
1755         No need to autorelease the result when the return type is RetainPtr.
1756
1757         * WebView/WebPDFRepresentation.mm:
1758         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
1759
1760 2018-06-13  Youenn Fablet  <youenn@apple.com>
1761
1762         Supported plugin check should be based on plugin identifier
1763         https://bugs.webkit.org/show_bug.cgi?id=186578
1764         <rdar://problem/40523828>
1765
1766         Reviewed by Darin Adler.
1767
1768         * WebCoreSupport/WebPluginInfoProvider.h:
1769         * WebCoreSupport/WebPluginInfoProvider.mm:
1770         (WebPluginInfoProvider::pluginInfo):
1771         (WebPluginInfoProvider::webVisiblePluginInfo):
1772
1773 2018-06-13  Chris Dumez  <cdumez@apple.com>
1774
1775         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1776         https://bugs.webkit.org/show_bug.cgi?id=186545
1777
1778         Reviewed by Brady Eidson.
1779
1780         Update client delegate now that parameter type has changed.
1781
1782         * WebCoreSupport/WebFrameLoaderClient.h:
1783         * WebCoreSupport/WebFrameLoaderClient.mm:
1784         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1785
1786 2018-06-11  Tim Horton  <timothy_horton@apple.com>
1787
1788         Link drag image is inconsistently unreadable in dark mode
1789         https://bugs.webkit.org/show_bug.cgi?id=186472
1790
1791         Reviewed by Timothy Hatcher.
1792
1793         * WebView/WebView.mm:
1794         (-[WebView _defaultAppearance]):
1795         Make defaultAppearance accurate even if useSystemAppearance is false.
1796         Some parts of WebKit (like the link drag image, but also context menus)
1797         want to be able to follow the system appearance regardless of whether
1798         the view or content has opted in.
1799
1800 2018-06-11  Chris Dumez  <cdumez@apple.com>
1801
1802         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
1803         https://bugs.webkit.org/show_bug.cgi?id=186441
1804
1805         Reviewed by Brady Eidson.
1806
1807         Rename existing flag to something a bit more generic, now that it is used for
1808         more things than bypassing the navigation policy check.
1809
1810         * WebView/WebView.mm:
1811         (-[WebView _loadBackForwardListFromOtherView:]):
1812         (-[WebView goToBackForwardItem:]):
1813
1814 2018-06-09  Dan Bernstein  <mitz@apple.com>
1815
1816         [Xcode] Clean up and modernize some build setting definitions
1817         https://bugs.webkit.org/show_bug.cgi?id=186463
1818
1819         Reviewed by Sam Weinig.
1820
1821         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
1822         * Configurations/DebugRelease.xcconfig: Ditto.
1823         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
1824           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
1825         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
1826         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
1827           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
1828         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
1829
1830 2018-06-08  Darin Adler  <darin@apple.com>
1831
1832         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
1833         https://bugs.webkit.org/show_bug.cgi?id=186436
1834
1835         Reviewed by Anders Carlsson.
1836
1837         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
1838         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
1839         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
1840         (PoolCleaner): Ditto.
1841
1842         * History/WebHistory.mm:
1843         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1844         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
1845         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
1846         now hardly used if at all.
1847         * WebView/WebView.mm:
1848         (-[WebView rectsForTextMatches]): Ditto.
1849
1850 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1851
1852         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
1853         https://bugs.webkit.org/show_bug.cgi?id=186442
1854         <rdar://problem/40879364>
1855
1856         Reviewed by Tim Horton.
1857
1858         * Configurations/FeatureDefines.xcconfig:
1859
1860 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
1861
1862         [Datalist] Allow TextFieldInputType to show and hide suggestions
1863         https://bugs.webkit.org/show_bug.cgi?id=186151
1864
1865         Reviewed by Tim Horton.
1866
1867         * WebCoreSupport/WebChromeClient.h:
1868         * WebCoreSupport/WebChromeClient.mm:
1869         (WebChromeClient::createDataListSuggestionPicker):
1870
1871 2018-06-07  Chris Dumez  <cdumez@apple.com>
1872
1873         Add base class to get WeakPtrFactory member and avoid some boilerplate code
1874         https://bugs.webkit.org/show_bug.cgi?id=186407
1875
1876         Reviewed by Brent Fulgham.
1877
1878         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
1879         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
1880         This also gets rid of old-style createWeakPtr() methods in favor of the newer
1881         makeWeakPtr().
1882
1883         * WebCoreSupport/WebEditorClient.h:
1884         * WebCoreSupport/WebEditorClient.mm:
1885         (WebEditorClient::requestCandidatesForSelection):
1886
1887 2018-06-05  Chris Dumez  <cdumez@apple.com>
1888
1889         Regression(r232082): Websites get loaded inside of Messages App chat transcript
1890         https://bugs.webkit.org/show_bug.cgi?id=186331
1891         <rdar://problem/40735446>
1892
1893         Reviewed by Darin Adler.
1894
1895         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
1896         but does not call use / ignore on the listener, then we would do "use" by default.
1897         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
1898         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
1899         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
1900         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
1901         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
1902         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
1903         and Box.app is still working properly.
1904
1905         * WebCoreSupport/WebFrameLoaderClient.h:
1906         * WebCoreSupport/WebFrameLoaderClient.mm:
1907         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1908         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1909         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1910         (WebFrameLoaderClient::dispatchWillSubmitForm):
1911         (WebFrameLoaderClient::setUpPolicyListener):
1912         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
1913         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
1914         (-[WebFramePolicyListener dealloc]):
1915         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
1916         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
1917
1918 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
1919
1920         Adjust compile and runtime flags to match shippable state of features
1921         https://bugs.webkit.org/show_bug.cgi?id=186319
1922         <rdar://problem/40352045>
1923
1924         Reviewed by Maciej Stachowiak, Jon Lee, and others.
1925
1926         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
1927         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
1928         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
1929         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
1930         Cocoa builds.
1931
1932 2018-06-05  Timothy Hatcher  <timothy@apple.com>
1933
1934         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
1935
1936         https://bugs.webkit.org/show_bug.cgi?id=186323
1937         rdar://problem/38382252
1938
1939         Reviewed by Tim Horton.
1940
1941         * WebView/WebView.mm:
1942         (-[WebView _defaultAppearance]):
1943
1944 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
1945
1946         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
1947         https://bugs.webkit.org/show_bug.cgi?id=186286
1948         <rdar://problem/40782992>
1949
1950         Reviewed by Dan Bernstein.
1951
1952         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
1953         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
1954         change this flag when preparing for a production release.
1955
1956         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
1957         whether experimental features should be enabled, and use it to properly define the
1958         feature flag.
1959
1960 2018-06-03  Darin Adler  <darin@apple.com>
1961
1962         Simplify and remove some unused video element code (helpful for ARC-compatibility)
1963         https://bugs.webkit.org/show_bug.cgi?id=186258
1964
1965         Reviewed by Daniel Bates.
1966
1967         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
1968         forward declarations. Removed methods that don't need to be public.
1969
1970         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
1971         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
1972         unnamed category in here and also replaced the HUDWindowControllerDelegate
1973         with the unnamed category. Removed unused NSWindow category defining the
1974         isOnActiveSpace, which is not called anywhere in this file at this time.
1975         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
1976         into setVideoElement.
1977         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
1978         and removed unneeded typecast.
1979         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
1980         using statement at the top of the file.
1981         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
1982         the many side effects and special considerations that this method that sounds
1983         like a setter has. Updated code to use the new
1984         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
1985         HTMLVideoElement::platformMedia function. Also straightened out the logic a
1986         bit and added some FIXME comments about small problems noticed but not fixed.
1987         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
1988         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
1989         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
1990         typecast. Removed call to updatePowerAssertions method.
1991         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
1992         updatePowerAssertions method.
1993         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
1994         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
1995         else, so this was dead code that did nothing.
1996         (-[WebVideoFullscreenController rateChanged:]): Removed call to
1997         updatePowerAssertions method.
1998
1999 2018-06-04  Chris Dumez  <cdumez@apple.com>
2000
2001         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
2002         https://bugs.webkit.org/show_bug.cgi?id=186287
2003         <rdar://problem/40783352>
2004
2005         Reviewed by Youenn Fablet.
2006
2007         * WebView/WebPreferenceKeysPrivate.h:
2008         * WebView/WebPreferences.mm:
2009         (+[WebPreferences initialize]):
2010         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
2011         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
2012         * WebView/WebPreferencesPrivate.h:
2013         * WebView/WebView.mm:
2014         (-[WebView _preferencesChanged:]):
2015
2016 2018-06-02  Darin Adler  <darin@apple.com>
2017
2018         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
2019         https://bugs.webkit.org/show_bug.cgi?id=186227
2020
2021         Reviewed by Dan Bernstein.
2022
2023         * Misc/WebKitErrors.m:
2024         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
2025         * Plugins/WebPluginDatabase.mm:
2026         (-[WebPluginDatabase refresh]): Ditto.
2027         * WebCoreSupport/WebChromeClient.mm:
2028         (WebChromeClient::setStatusbarText): Ditto.
2029
2030 2018-06-01  Chris Dumez  <cdumez@apple.com>
2031
2032         REGRESSION (r231456): Colloquy is broken
2033         https://bugs.webkit.org/show_bug.cgi?id=186197
2034         <rdar://problem/40722960>
2035
2036         Reviewed by Timothy Hatcher.
2037
2038         Restore pre-r231456 behavior for Colloquy app so that it works again.
2039
2040         * WebView/WebView.mm:
2041         (-[WebView _needsFrameNameFallbackToIdQuirk]):
2042         (-[WebView _preferencesChanged:]):
2043
2044 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2045
2046         [JSC] Pass VM& parameter as much as possible
2047         https://bugs.webkit.org/show_bug.cgi?id=186085
2048
2049         Reviewed by Saam Barati.
2050
2051         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2052         (WebKit::NetscapePluginInstanceProxy::invoke):
2053
2054 2018-05-30  Daniel Bates  <dabates@apple.com>
2055
2056         NavigationAction does not need to hold initiating DOM Event
2057         https://bugs.webkit.org/show_bug.cgi?id=185958
2058         <rdar://problem/40531539>
2059
2060         Reviewed by Simon Fraser.
2061
2062         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
2063
2064         * WebCoreSupport/WebFrameLoaderClient.mm:
2065         (WebFrameLoaderClient::actionDictionary const):
2066         (findMouseEvent): Deleted.
2067
2068 2018-05-27  Dan Bernstein  <mitz@apple.com>
2069
2070         Reverted the changes made for https://webkit.org/b/186016
2071
2072         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
2073
2074
2075 2018-05-27  David Kilzer  <ddkilzer@apple.com>
2076
2077         [iOS] Fix warnings about leaks found by clang static analyzer
2078         <https://webkit.org/b/186009>
2079         <rdar://problem/40574267>
2080
2081         Reviewed by Daniel Bates.
2082
2083         * WebView/WebHTMLView.mm:
2084         (-[WebHTMLView doCommandBySelector:]): Fix use of an
2085         uninitialized boolean variable (`eventWasHandled`) that only
2086         happened on iOS.
2087
2088 2018-05-27  Dan Bernstein  <mitz@apple.com>
2089
2090         [Cocoa] Avoid importing directly from subumbrella frameworks
2091         https://bugs.webkit.org/show_bug.cgi?id=186016
2092
2093         Reviewed by Sam Weinig.
2094
2095         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
2096         * Carbon/CarbonWindowAdapter.mm: Ditto.
2097         * Carbon/CarbonWindowFrame.m: Ditto.
2098         * Carbon/HIViewAdapter.h: Ditto.
2099         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
2100           OTHER_CPLUSPLUSFLAGS.
2101         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
2102         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
2103         * WebView/WebPDFView.h: Ditto.
2104
2105 2018-05-27  Sam Weinig  <sam@webkit.org>
2106
2107         Modernize RenderStyleConstants.h - Part 3
2108         https://bugs.webkit.org/show_bug.cgi?id=186015
2109
2110         Reviewed by Yusuke Suzuki.
2111
2112         * WebView/WebView.mm:
2113         (-[WebView updateTextTouchBar]):
2114         Update for new enum name.
2115
2116 2018-05-25  Chris Dumez  <cdumez@apple.com>
2117
2118         Minor ApplicationCacheStorage clean up
2119         https://bugs.webkit.org/show_bug.cgi?id=185984
2120
2121         Reviewed by Youenn Fablet.
2122
2123         * WebCoreSupport/WebApplicationCache.mm:
2124         (+[WebApplicationCache originsWithCache]):
2125
2126 2018-05-25  David Kilzer  <ddkilzer@apple.com>
2127
2128         Fix issues with -dealloc methods found by clang static analyzer
2129         <https://webkit.org/b/185887>
2130
2131         Reviewed by Joseph Pecoraro.
2132
2133         * WebView/WebView.mm:
2134         (-[WebUITextIndicatorData dealloc]):
2135         - Move method implementation from (WebUITextIndicatorInternal)
2136           category to the main category since this is public API.  This
2137           fixes the false positive warning about a missing -dealloc
2138           method.
2139
2140 2018-05-24  Sam Weinig  <sam@webkit.org>
2141
2142         Modernize RenderStyleConstants.h - Part 2
2143         https://bugs.webkit.org/show_bug.cgi?id=185901
2144
2145         Reviewed by Simon Fraser.
2146
2147         * WebView/WebHTMLRepresentation.mm:
2148         (searchForLabelsBeforeElement):
2149         * WebView/WebView.mm:
2150         (nsTextAlignmentFromRenderStyle):
2151         Update for new enum names.
2152
2153 2018-05-22  Chris Dumez  <cdumez@apple.com>
2154
2155         Regression(AsyncPolicyDelegates): Box.app login Window is blank
2156         https://bugs.webkit.org/show_bug.cgi?id=185832
2157         <rdar://problem/40307871>
2158
2159         Reviewed by Geoffrey Garen.
2160
2161         We used to have a bug where where we would fail to wait for the policy decision for
2162         the navigation response from the client and the load would keep going, racing with
2163         the client's policy decision. If the client did not respond in time, the behavior
2164         would be the same as "Use" policy action.
2165
2166         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
2167         but the load happened to proceed anyway due to our bug. Now that we've fixed the
2168         WebKit bug, however, the load would hang because the completion handler for the
2169         decidePolicyForNavigationResponse would never get called.
2170
2171         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
2172         instead of retaining it. If the policy listener object gets destroyed because getting
2173         resolved, we now use "Use" policy action in its dealloc function to maintain previous
2174         behavior.
2175
2176         * WebCoreSupport/WebFrameLoaderClient.h:
2177         * WebCoreSupport/WebFrameLoaderClient.mm:
2178         (WebFrameLoaderClient::cancelPolicyCheck):
2179         (WebFrameLoaderClient::setUpPolicyListener):
2180         (-[WebFramePolicyListener dealloc]):
2181
2182 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
2183
2184         Unreviewed, rolling out r232052.
2185
2186         Breaks internal builds.
2187
2188         Reverted changeset:
2189
2190         "Use more C++17"
2191         https://bugs.webkit.org/show_bug.cgi?id=185176
2192         https://trac.webkit.org/changeset/232052
2193
2194 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2195
2196         Use more C++17
2197         https://bugs.webkit.org/show_bug.cgi?id=185176
2198
2199         Reviewed by JF Bastien.
2200
2201         * Configurations/Base.xcconfig:
2202         * Configurations/WebKitLegacy.xcconfig:
2203
2204 2018-05-21  Chris Nardi  <cnardi@chromium.org>
2205
2206         Remove dead exception in MediaList.appendMedium
2207         https://bugs.webkit.org/show_bug.cgi?id=185278
2208
2209         Reviewed by Chris Dumez.
2210
2211         Remove code pertaining to an exception being thrown by appendMedium().
2212
2213         * DOM/DOMMediaList.mm:
2214         (-[DOMMediaList appendMedium:]):
2215
2216 2018-05-21  Jer Noble  <jer.noble@apple.com>
2217
2218         Complete fix for enabling modern EME by default
2219         https://bugs.webkit.org/show_bug.cgi?id=185770
2220         <rdar://problem/40368220>
2221
2222         Reviewed by Eric Carlson.
2223
2224         * Configurations/FeatureDefines.xcconfig:
2225
2226 2018-05-21  Antti Koivisto  <antti@apple.com>
2227
2228         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
2229         https://bugs.webkit.org/show_bug.cgi?id=185815
2230         <rdar://problem/40310069>
2231
2232         Reviewed by Simon Fraser.
2233
2234         User stylesheet parsing may depend on the colorFilterEnabled preference.
2235
2236         * WebView/WebView.mm:
2237         (-[WebView _preferencesChanged:]):
2238
2239 2018-05-18  Commit Queue  <commit-queue@webkit.org>
2240
2241         Unreviewed, rolling out r231982.
2242         https://bugs.webkit.org/show_bug.cgi?id=185793
2243
2244         Caused layout test failures (Requested by realdawei on
2245         #webkit).
2246
2247         Reverted changeset:
2248
2249         "Complete fix for enabling modern EME by default"
2250         https://bugs.webkit.org/show_bug.cgi?id=185770
2251         https://trac.webkit.org/changeset/231982
2252
2253 2018-05-18  Jer Noble  <jer.noble@apple.com>
2254
2255         Complete fix for enabling modern EME by default
2256         https://bugs.webkit.org/show_bug.cgi?id=185770
2257         <rdar://problem/40368220>
2258
2259         Reviewed by Eric Carlson.
2260
2261         * Configurations/FeatureDefines.xcconfig:
2262
2263 2018-05-18  Chris Dumez  <cdumez@apple.com>
2264
2265         Avoid keeping the frame alive when ref'ing a WindowProxy
2266         https://bugs.webkit.org/show_bug.cgi?id=185737
2267         <rdar://problem/40004666>
2268
2269         Reviewed by Sam Weinig.
2270
2271         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2272         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2273
2274 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
2275
2276         Add support for Intl NumberFormat formatToParts
2277         https://bugs.webkit.org/show_bug.cgi?id=185375
2278
2279         Reviewed by Yusuke Suzuki.
2280
2281         Add flag for NumberFormat formatToParts.
2282
2283         * Configurations/FeatureDefines.xcconfig:
2284
2285 2018-05-16  Chris Nardi  <cnardi@chromium.org>
2286
2287         Fixup after r231849: Do not mark Mac API methods as deprecated
2288         https://bugs.webkit.org/show_bug.cgi?id=185684
2289
2290         Reviewed by Darin Adler.
2291
2292         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
2293         as the entire class is already marked as deprecated, so it is unnecessary.
2294
2295         * DOM/DOMDocument.h:
2296
2297 2018-05-16  Chris Nardi  <cnardi@chromium.org>
2298
2299         Remove Document#selectedStylesheetSet/preferredStylesheetSet
2300         https://bugs.webkit.org/show_bug.cgi?id=185381
2301
2302         Reviewed by Darin Adler.
2303
2304         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
2305         and make them do nothing.
2306
2307         * DOM/DOMDocument.h:
2308         * DOM/DOMDocument.mm:
2309         (-[DOMDocument preferredStylesheetSet]):
2310         (-[DOMDocument selectedStylesheetSet]):
2311         (-[DOMDocument setSelectedStylesheetSet:]):
2312
2313 2018-05-15  Antoine Quint  <graouts@apple.com>
2314
2315         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2316         https://bugs.webkit.org/show_bug.cgi?id=185647
2317
2318         Reviewed by Dean Jackson.
2319
2320         Rename the Web Animations CSS integration flag.
2321
2322         * WebView/WebPreferenceKeysPrivate.h:
2323         * WebView/WebPreferences.mm:
2324         (+[WebPreferences initialize]):
2325         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
2326         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
2327         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
2328         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
2329         * WebView/WebPreferencesPrivate.h:
2330         * WebView/WebView.mm:
2331         (-[WebView _preferencesChanged:]):
2332
2333 2018-05-14  Daniel Bates  <dabates@apple.com>
2334
2335         Fix the Apple Internal build
2336
2337         See <rdar://problem/40237873> for more details.
2338
2339         * WebView/WebFullScreenController.mm:
2340         (-[WebFullScreenController enterFullScreen:]):
2341         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2342         (-[WebFullScreenController exitFullScreen]):
2343         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2344         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2345         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2346
2347 2018-05-11  Timothy Hatcher  <timothy@apple.com>
2348
2349         WebHTMLView is not setting aside subviews when drawing.
2350
2351         https://bugs.webkit.org/show_bug.cgi?id=185561
2352         rdar://problem/40172894
2353
2354         Reviewed by Simon Fraser.
2355
2356         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
2357
2358         * WebView/WebHTMLView.mm:
2359         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
2360
2361 2018-05-07  Daniel Bates  <dabates@apple.com>
2362
2363         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
2364         https://bugs.webkit.org/show_bug.cgi?id=185170
2365
2366         Reviewed by Per Arne Vollan.
2367
2368         * Misc/WebCache.mm:
2369         (+[WebCache empty]):
2370
2371 2018-05-04  Timothy Hatcher  <timothy@apple.com>
2372
2373         Deprecate legacy WebView and friends
2374         https://bugs.webkit.org/show_bug.cgi?id=185279
2375         rdar://problem/33268700
2376
2377         Reviewed by Tim Horton.
2378
2379         Added deprecation macros to all the classes, extern strings, and enums.
2380
2381         * Configurations/WebKitLegacy.xcconfig:
2382         Added BUILDING_WEBKIT define to disable the deprecation macros.
2383         * DOM/DOMAbstractView.h:
2384         * DOM/DOMAttr.h:
2385         * DOM/DOMBlob.h:
2386         * DOM/DOMCDATASection.h:
2387         * DOM/DOMCSSCharsetRule.h:
2388         * DOM/DOMCSSFontFaceRule.h:
2389         * DOM/DOMCSSImportRule.h:
2390         * DOM/DOMCSSMediaRule.h:
2391         * DOM/DOMCSSPageRule.h:
2392         * DOM/DOMCSSPrimitiveValue.h:
2393         * DOM/DOMCSSRule.h:
2394         * DOM/DOMCSSRuleList.h:
2395         * DOM/DOMCSSStyleDeclaration.h:
2396         * DOM/DOMCSSStyleRule.h:
2397         * DOM/DOMCSSStyleSheet.h:
2398         * DOM/DOMCSSUnknownRule.h:
2399         * DOM/DOMCSSValue.h:
2400         * DOM/DOMCSSValueList.h:
2401         * DOM/DOMCharacterData.h:
2402         * DOM/DOMComment.h:
2403         * DOM/DOMCounter.h:
2404         * DOM/DOMDocument.h:
2405         * DOM/DOMDocumentFragment.h:
2406         * DOM/DOMDocumentType.h:
2407         * DOM/DOMElement.h:
2408         * DOM/DOMEntity.h:
2409         * DOM/DOMEntityReference.h:
2410         * DOM/DOMEvent.h:
2411         * DOM/DOMEventException.h:
2412         * DOM/DOMEventListener.h:
2413         * DOM/DOMEventTarget.h:
2414         * DOM/DOMException.h:
2415         * DOM/DOMFile.h:
2416         * DOM/DOMFileList.h:
2417         * DOM/DOMHTMLAnchorElement.h:
2418         * DOM/DOMHTMLAppletElement.h:
2419         * DOM/DOMHTMLAreaElement.h:
2420         * DOM/DOMHTMLBRElement.h:
2421         * DOM/DOMHTMLBaseElement.h:
2422         * DOM/DOMHTMLBaseFontElement.h:
2423         * DOM/DOMHTMLBodyElement.h:
2424         * DOM/DOMHTMLButtonElement.h:
2425         * DOM/DOMHTMLCanvasElement.h:
2426         * DOM/DOMHTMLCollection.h:
2427         * DOM/DOMHTMLDListElement.h:
2428         * DOM/DOMHTMLDirectoryElement.h:
2429         * DOM/DOMHTMLDivElement.h:
2430         * DOM/DOMHTMLDocument.h:
2431         * DOM/DOMHTMLElement.h:
2432         * DOM/DOMHTMLEmbedElement.h:
2433         * DOM/DOMHTMLFieldSetElement.h:
2434         * DOM/DOMHTMLFontElement.h:
2435         * DOM/DOMHTMLFormElement.h:
2436         * DOM/DOMHTMLFrameElement.h:
2437         * DOM/DOMHTMLFrameSetElement.h:
2438         * DOM/DOMHTMLHRElement.h:
2439         * DOM/DOMHTMLHeadElement.h:
2440         * DOM/DOMHTMLHeadingElement.h:
2441         * DOM/DOMHTMLHtmlElement.h:
2442         * DOM/DOMHTMLIFrameElement.h:
2443         * DOM/DOMHTMLImageElement.h:
2444         * DOM/DOMHTMLInputElement.h:
2445         * DOM/DOMHTMLLIElement.h:
2446         * DOM/DOMHTMLLabelElement.h:
2447         * DOM/DOMHTMLLegendElement.h:
2448         * DOM/DOMHTMLLinkElement.h:
2449         * DOM/DOMHTMLMapElement.h:
2450         * DOM/DOMHTMLMarqueeElement.h:
2451         * DOM/DOMHTMLMediaElement.h:
2452         * DOM/DOMHTMLMenuElement.h:
2453         * DOM/DOMHTMLMetaElement.h:
2454         * DOM/DOMHTMLModElement.h:
2455         * DOM/DOMHTMLOListElement.h:
2456         * DOM/DOMHTMLObjectElement.h:
2457         * DOM/DOMHTMLOptGroupElement.h:
2458         * DOM/DOMHTMLOptionElement.h:
2459         * DOM/DOMHTMLOptionsCollection.h:
2460         * DOM/DOMHTMLParagraphElement.h:
2461         * DOM/DOMHTMLParamElement.h:
2462         * DOM/DOMHTMLPreElement.h:
2463         * DOM/DOMHTMLQuoteElement.h:
2464         * DOM/DOMHTMLScriptElement.h:
2465         * DOM/DOMHTMLSelectElement.h:
2466         * DOM/DOMHTMLStyleElement.h:
2467         * DOM/DOMHTMLTableCaptionElement.h:
2468         * DOM/DOMHTMLTableCellElement.h:
2469         * DOM/DOMHTMLTableColElement.h:
2470         * DOM/DOMHTMLTableElement.h:
2471         * DOM/DOMHTMLTableRowElement.h:
2472         * DOM/DOMHTMLTableSectionElement.h:
2473         * DOM/DOMHTMLTextAreaElement.h:
2474         * DOM/DOMHTMLTitleElement.h:
2475         * DOM/DOMHTMLUListElement.h:
2476         * DOM/DOMHTMLVideoElement.h:
2477         * DOM/DOMImplementation.h:
2478         * DOM/DOMKeyboardEvent.h:
2479         * DOM/DOMMediaError.h:
2480         * DOM/DOMMediaList.h:
2481         * DOM/DOMMouseEvent.h:
2482         * DOM/DOMMutationEvent.h:
2483         * DOM/DOMNamedNodeMap.h:
2484         * DOM/DOMNode.h:
2485         * DOM/DOMNodeFilter.h:
2486         * DOM/DOMNodeIterator.h:
2487         * DOM/DOMNodeList.h:
2488         * DOM/DOMObject.h:
2489         * DOM/DOMOverflowEvent.h:
2490         * DOM/DOMProcessingInstruction.h:
2491         * DOM/DOMProgressEvent.h:
2492         * DOM/DOMRGBColor.h:
2493         * DOM/DOMRange.h:
2494         * DOM/DOMRangeException.h:
2495         * DOM/DOMRect.h:
2496         * DOM/DOMStyleSheet.h:
2497         * DOM/DOMStyleSheetList.h:
2498         * DOM/DOMText.h:
2499         * DOM/DOMTextEvent.h:
2500         * DOM/DOMTimeRanges.h:
2501         * DOM/DOMTokenList.h:
2502         * DOM/DOMTreeWalker.h:
2503         * DOM/DOMUIEvent.h:
2504         * DOM/DOMWheelEvent.h:
2505         * DOM/DOMXPathException.h:
2506         * DOM/DOMXPathExpression.h:
2507         * DOM/DOMXPathNSResolver.h:
2508         * DOM/DOMXPathResult.h:
2509         * History/WebBackForwardList.h:
2510         * History/WebHistory.h:
2511         * History/WebHistoryItem.h:
2512         * Misc/WebDownload.h:
2513         * Misc/WebKitErrors.h:
2514         * Plugins/WebPluginViewFactory.h:
2515         * WebView/WebArchive.h:
2516         * WebView/WebDataSource.h:
2517         * WebView/WebDocument.h:
2518         * WebView/WebEditingDelegate.h:
2519         * WebView/WebFormDelegate.h:
2520         * WebView/WebFrame.h:
2521         * WebView/WebFrameLoadDelegate.h:
2522         * WebView/WebFrameView.h:
2523         * WebView/WebPolicyDelegate.h:
2524         * WebView/WebPreferences.h:
2525         * WebView/WebPreferencesPrivate.h:
2526         * WebView/WebResourceLoadDelegate.h:
2527         * WebView/WebUIDelegate.h:
2528         * WebView/WebUIDelegatePrivate.h:
2529         * WebView/WebView.h:
2530         * WebView/WebViewPrivate.h:
2531         * postprocess-headers.sh:
2532         Remove step that converts WEBKIT macros to NS macros.
2533         Change it to just remove the macros on iOS builds.
2534
2535 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
2536
2537         [MediaStream] remove WK1 support
2538         https://bugs.webkit.org/show_bug.cgi?id=185136
2539
2540         Reviewed by Youenn Fablet.
2541
2542         * WebCoreSupport/WebUserMediaClient.h: Removed.
2543         * WebCoreSupport/WebUserMediaClient.mm: Removed.
2544         * WebView/WebView.mm:
2545         (-[WebView _commonInitializationWithFrameName:groupName:]):
2546         (-[WebView _preferencesChanged:]):
2547         (-[WebView _setUserMediaClient:]): Deleted.
2548         (-[WebView _userMediaClient]): Deleted.
2549         * WebView/WebViewData.h:
2550         * WebView/WebViewPrivate.h:
2551
2552 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
2553
2554         WebAssembly: add support for stream APIs - JavaScript API
2555         https://bugs.webkit.org/show_bug.cgi?id=183442
2556
2557         Reviewed by Yusuke Suzuki and JF Bastien.
2558
2559         Add WEBASSEMBLY_STREAMINNG_API feature flag
2560
2561         * Configurations/FeatureDefines.xcconfig:
2562
2563 2018-04-30  JF Bastien  <jfbastien@apple.com>
2564
2565         Use some C++17 features
2566         https://bugs.webkit.org/show_bug.cgi?id=185135
2567
2568         Reviewed by Alex Christensen.
2569
2570         * Configurations/WebKitLegacy.xcconfig:
2571
2572 2018-04-27  Chris Dumez  <cdumez@apple.com>
2573
2574         Use WindowProxy instead of DOMWindow in our IDL
2575         https://bugs.webkit.org/show_bug.cgi?id=185022
2576
2577         Reviewed by Sam Weinig.
2578
2579         * DOM/DOMAbstractView.mm:
2580         (kit):
2581         (toWindowProxy):
2582         * DOM/DOMAbstractViewInternal.h:
2583         * DOM/DOMDocument.mm:
2584         (-[DOMDocument defaultView]):
2585         (-[DOMDocument getComputedStyle:pseudoElement:]):
2586         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
2587         * DOM/DOMHTMLFrameElement.mm:
2588         (-[DOMHTMLFrameElement contentWindow]):
2589         * DOM/DOMHTMLIFrameElement.mm:
2590         (-[DOMHTMLIFrameElement contentWindow]):
2591         * DOM/DOMKeyboardEvent.mm:
2592         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
2593         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
2594         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
2595         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
2596         * DOM/DOMMouseEvent.mm:
2597         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
2598         * DOM/DOMTextEvent.mm:
2599         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
2600         * DOM/DOMUIEvent.mm:
2601         (-[DOMUIEvent view]):
2602         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
2603         * DOM/DOMWheelEvent.mm:
2604         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
2605
2606 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
2607
2608         Implement rendering support for the color-filter CSS property
2609         https://bugs.webkit.org/show_bug.cgi?id=185047
2610         rdar://problem/39664967
2611
2612         Reviewed by Tim Horton.
2613         
2614         The body background should reflect the filtered color.
2615
2616         * WebView/WebFrame.mm:
2617         (-[WebFrame _bodyBackgroundColor]):
2618         * WebView/WebView.mm:
2619         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
2620
2621 2018-04-26  Jer Noble  <jer.noble@apple.com>
2622
2623         WK_COCOA_TOUCH all the things.
2624         https://bugs.webkit.org/show_bug.cgi?id=185006
2625
2626         Reviewed by Tim Horton.
2627
2628         * Configurations/WebKitLegacy.xcconfig:
2629
2630 2018-04-26  Daniel Bates  <dabates@apple.com>
2631
2632         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
2633         https://bugs.webkit.org/show_bug.cgi?id=184161
2634         <rdar://problem/39051645>
2635
2636         Reviewed by Dan Bernstein.
2637
2638         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
2639         dropping a PDF embedded using an HTML image element into the same web view.
2640
2641         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
2642         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
2643         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
2644         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
2645         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
2646         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
2647         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
2648         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
2649         image document when navigated to directly. Since we can support dragging PDF document images we need to
2650         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
2651         We need to do both such queries before falling back to using the main resource of the Web Archive as
2652         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
2653         not an image document.
2654
2655         * Misc/WebNSPasteboardExtras.mm:
2656         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2657
2658 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
2659
2660         Disable content filtering in minimal simulator mode
2661         https://bugs.webkit.org/show_bug.cgi?id=185027
2662         <rdar://problem/39736091>
2663
2664         Reviewed by Jer Noble.
2665
2666         * Configurations/FeatureDefines.xcconfig:
2667
2668 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
2669
2670         [INTL] Implement Intl.PluralRules
2671         https://bugs.webkit.org/show_bug.cgi?id=184312
2672
2673         Reviewed by JF Bastien.
2674
2675         Added Intl.PluralRules feature flag.
2676
2677         * Configurations/FeatureDefines.xcconfig:
2678
2679 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
2680
2681         Remove access to keychain from the WebContent process
2682         https://bugs.webkit.org/show_bug.cgi?id=184428
2683         <rdar://problem/13150903>
2684
2685         Reviewed by Brent Fulgham.
2686
2687         This patch does the followings:
2688         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
2689         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
2690         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
2691
2692         * WebCoreSupport/WebChromeClient.h:
2693         * WebCoreSupport/WebChromeClient.mm:
2694         (WebChromeClient::signedPublicKeyAndChallengeString const):
2695         * WebView/WebUIDelegatePrivate.h:
2696
2697 2018-04-24  Jer Noble  <jer.noble@apple.com>
2698
2699         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
2700         https://bugs.webkit.org/show_bug.cgi?id=184786
2701
2702         Reviewed by Tim Horton.
2703
2704         * Configurations/WebKitLegacy.xcconfig:
2705         * MigrateHeaders.make:
2706
2707 2018-04-23  Daniel Bates  <dabates@apple.com>
2708
2709         Implement Same-Site cookies
2710         https://bugs.webkit.org/show_bug.cgi?id=159464
2711         <rdar://problem/27196358>
2712
2713         Reviewed by Brent Fulgham.
2714
2715         Pass the Same-Site info through the strategy.
2716
2717         * WebCoreSupport/WebPlatformStrategies.h:
2718         * WebCoreSupport/WebPlatformStrategies.mm:
2719         (WebPlatformStrategies::cookiesForDOM):
2720         (WebPlatformStrategies::setCookiesFromDOM):
2721         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2722         (WebPlatformStrategies::getRawCookies):
2723
2724 2018-04-23  Zalan Bujtas  <zalan@apple.com>
2725
2726         [LayoutFormattingContext] Initial commit.
2727         https://bugs.webkit.org/show_bug.cgi?id=184896
2728
2729         Reviewed by Antti Koivisto.
2730
2731         * Configurations/FeatureDefines.xcconfig:
2732
2733 2018-04-23  Daniel Bates  <dabates@apple.com>
2734
2735         Implement Same-Site cookies
2736         https://bugs.webkit.org/show_bug.cgi?id=159464
2737         <rdar://problem/27196358>
2738
2739         Reviewed by Brent Fulgham.
2740
2741         Pass the Same-Site info through the strategy.
2742
2743         * WebCoreSupport/WebPlatformStrategies.h:
2744         * WebCoreSupport/WebPlatformStrategies.mm:
2745         (WebPlatformStrategies::cookiesForDOM):
2746         (WebPlatformStrategies::setCookiesFromDOM):
2747         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2748         (WebPlatformStrategies::getRawCookies):
2749
2750 2018-04-20  Timothy Hatcher  <timothy@apple.com>
2751
2752         NULL dereference crash sometimes under [super initWithCoder:] in WebView
2753
2754         https://bugs.webkit.org/show_bug.cgi?id=184851
2755         rdar://problem/39611236
2756
2757         Reviewed by Tim Horton.
2758
2759         * WebView/WebView.mm:
2760         (-[WebView _commonInitializationWithFrameName:groupName:]):
2761         (-[WebView effectiveAppearanceDidChange]):
2762         Added a null check and call the code later in initialization.
2763
2764 2018-04-20  Tim Horton  <timothy_horton@apple.com>
2765
2766         Adjust geolocation feature flag
2767         https://bugs.webkit.org/show_bug.cgi?id=184856
2768
2769         Reviewed by Wenson Hsieh.
2770
2771         * Configurations/FeatureDefines.xcconfig:
2772
2773 2018-04-18  Jer Noble  <jer.noble@apple.com>
2774
2775         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
2776         https://bugs.webkit.org/show_bug.cgi?id=184762
2777
2778         Reviewed by Dan Bernstein.
2779
2780         * Configurations/WebKitLegacy.xcconfig:
2781
2782 2018-04-20  Youenn Fablet  <youenn@apple.com>
2783
2784         Make PluginData cache its web visible plugins
2785         https://bugs.webkit.org/show_bug.cgi?id=184421
2786
2787         Reviewed by Chris Dumez.
2788
2789         * WebCoreSupport/WebPluginInfoProvider.h:
2790         * WebCoreSupport/WebPluginInfoProvider.mm:
2791         (WebPluginInfoProvider::pluginInfo):
2792         (WebPluginInfoProvider::webVisiblePluginInfo):
2793
2794 2018-04-19  Chris Dumez  <cdumez@apple.com>
2795
2796         Rename JSDOMWindowProxy to JSWindowProxy
2797         https://bugs.webkit.org/show_bug.cgi?id=184797
2798
2799         Reviewed by Sam Weinig.
2800
2801         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
2802
2803         * DOM/DOMUtility.mm:
2804         (createDOMWrapper):
2805         * WebView/WebFrame.mm:
2806         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2807
2808 2018-04-19  David Kilzer  <ddkilzer@apple.com>
2809
2810         Enable Objective-C weak references
2811         <https://webkit.org/b/184789>
2812         <rdar://problem/39571716>
2813
2814         Reviewed by Dan Bernstein.
2815
2816         * Configurations/Base.xcconfig:
2817         (CLANG_ENABLE_OBJC_WEAK): Enable.
2818
2819 2018-04-18  Chris Dumez  <cdumez@apple.com>
2820
2821         Rename WindowProxyController to WindowProxy
2822         https://bugs.webkit.org/show_bug.cgi?id=184756
2823
2824         Reviewed by Sam Weinig.
2825
2826         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
2827         needed use WindowProxyController type, which was a bit confusing.
2828
2829         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2830         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2831         * WebView/WebFrame.mm:
2832         (-[WebFrame _attachScriptDebugger]):
2833
2834 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2835
2836         Unreviewed rollout of r230632. Regression in memory usage.
2837
2838         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2839
2840         * WebView/WebPreferences.mm:
2841         (+[WebPreferences initialize]):
2842
2843 2018-04-17  Chris Dumez  <cdumez@apple.com>
2844
2845         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
2846         https://bugs.webkit.org/show_bug.cgi?id=184678
2847         <rdar://problem/39422122>
2848
2849         Reviewed by Alex Christensen.
2850
2851         Add new parameter to dispatchDecidePolicyForNavigationAction.
2852
2853         * WebCoreSupport/WebFrameLoaderClient.h:
2854         * WebCoreSupport/WebFrameLoaderClient.mm:
2855         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2856
2857 2018-04-13  Chris Dumez  <cdumez@apple.com>
2858
2859         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
2860         https://bugs.webkit.org/show_bug.cgi?id=184591
2861
2862         Reviewed by Sam Weinig.
2863
2864         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
2865         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
2866         This is work towards fixing Bug 184515.
2867
2868         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2869         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2870         * WebView/WebFrame.mm:
2871         (-[WebFrame _attachScriptDebugger]):
2872
2873 2018-04-12  Antoine Quint  <graouts@apple.com>
2874
2875         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
2876         https://bugs.webkit.org/show_bug.cgi?id=184569
2877         <rdar://problem/38671301>
2878
2879         Reviewed by Jon Lee.
2880
2881         * WebView/WebPreferences.mm:
2882
2883 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2884
2885         [WTF] Remove StaticLock
2886         https://bugs.webkit.org/show_bug.cgi?id=184332
2887
2888         Reviewed by Mark Lam.
2889
2890         * DOM/DOMInternal.mm:
2891         (getDOMWrapper):
2892         (addDOMWrapper):
2893         (removeDOMWrapper):
2894
2895 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
2896
2897         Failures from mach port reference handling should be fatal
2898         https://bugs.webkit.org/show_bug.cgi?id=184202
2899         <rdar://problem/37771114>
2900
2901         Reviewed by Anders Carlsson.
2902
2903         * Plugins/Hosted/NetscapePluginHostManager.mm:
2904         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
2905
2906 2018-04-03  Andy Estes  <aestes@apple.com>
2907
2908         [Mac] Prioritize file promises over filenames during drag and drop
2909         https://bugs.webkit.org/show_bug.cgi?id=184237
2910         <rdar://problem/38278076>
2911
2912         Reviewed by Wenson Hsieh.
2913
2914         * WebView/WebView.mm:
2915         (-[WebView performDragOperation:]):
2916
2917 2018-04-03  Chris Dumez  <cdumez@apple.com>
2918
2919         Drop MainFrame class
2920         https://bugs.webkit.org/show_bug.cgi?id=184191
2921
2922         Reviewed by Darin Adler.
2923
2924         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
2925         relationship between the Page and the MainFrame.
2926
2927         This is ground work for introducing LocalFrame / RemoteFrame concepts.
2928
2929         * WebCoreSupport/WebDragClient.mm:
2930         * WebCoreSupport/WebFrameLoaderClient.mm:
2931         * WebCoreSupport/WebInspectorClient.mm:
2932         * WebCoreSupport/WebPlatformStrategies.mm:
2933         * WebCoreSupport/WebPluginInfoProvider.mm:
2934         * WebView/WebFrame.mm:
2935         * WebView/WebFrameView.mm:
2936         * WebView/WebHTMLView.mm:
2937         * WebView/WebView.mm:
2938
2939 2018-04-02  Jer Noble  <jer.noble@apple.com>
2940
2941         Enable Legacy EME for all WebKit & WebKitLegacy clients
2942         https://bugs.webkit.org/show_bug.cgi?id=184018
2943         <rdar://problem/34887387>
2944
2945         Reviewed by Eric Carlson.
2946
2947         * WebView/WebPreferences.mm:
2948         (+[WebPreferences initialize]):
2949
2950 2018-03-29  JF Bastien  <jfbastien@apple.com>
2951
2952         Use Forward.h instead of forward-declaring WTF::String
2953         https://bugs.webkit.org/show_bug.cgi?id=184172
2954         <rdar://problem/39026146>
2955
2956         Reviewed by Yusuke Suzuki.
2957
2958         As part of #184164 I'm changing WTF::String, and the forward
2959         declarations are just wrong because I'm making it templated. We
2960         should use Forward.h anyways, so do that instead.
2961
2962         * WebView/WebScriptDebugger.h:
2963
2964 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
2965
2966         Protect against invalid mach ports returned by mach_port_request_notification
2967         https://bugs.webkit.org/show_bug.cgi?id=184106
2968         <rdar://problem/37865316>
2969
2970         Reviewed by Chris Dumez.
2971
2972         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2973         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
2974         and clean up if it experienced an error.
2975         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
2976
2977 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
2978
2979         Avoid uninitialized mach ports
2980         https://bugs.webkit.org/show_bug.cgi?id=184090
2981         <rdar://problem/37261129>
2982
2983         Reviewed by Chris Dumez.
2984
2985         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
2986         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
2987         there is a potential for us to try to use invalid ports.
2988
2989         We should always check return values, and ensure that the mach port variables we seek to initialize are
2990         kept in a valid state.
2991
2992         Reviewed by Chris Dumez.
2993
2994         * Plugins/Hosted/NetscapePluginHostManager.h:
2995         * Plugins/Hosted/NetscapePluginHostManager.mm:
2996         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
2997         port is passed to an API function.
2998         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
2999         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
3000         * Plugins/Hosted/NetscapePluginHostProxy.h:
3001         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3002         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
3003         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
3004         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
3005         (WKPCStatusText): Ditto.
3006         (WKPCLoadURL): Ditto.
3007         (WKPCCancelLoadURL): Ditto.
3008         (WKPCInvalidateRect): Ditto.
3009         (WKPCGetScriptableNPObjectReply): Ditto.
3010         (WKPCBooleanReply): Ditto.
3011         (WKPCBooleanAndDataReply): Ditto.
3012         (WKPCInstantiatePluginReply): Ditto.
3013         (WKPCGetWindowNPObject): Ditto.
3014         (WKPCGetPluginElementNPObject): Ditto.
3015         (WKPCForgetBrowserObject): Ditto.
3016         (WKPCEvaluate): Ditto.
3017         (WKPCGetStringIdentifier): Ditto.
3018         (WKPCGetIntIdentifier): Ditto.
3019         (WKPCInvoke): Ditto.
3020         (WKPCInvokeDefault): Ditto.
3021         (WKPCConstruct): Ditto.
3022         (WKPCGetProperty): Ditto.
3023         (WKPCSetProperty): Ditto.
3024         (WKPCRemoveProperty): Ditto.
3025         (WKPCHasProperty): Ditto.
3026         (WKPCHasMethod): Ditto.
3027         (WKPCIdentifierInfo): Ditto.
3028         (WKPCEnumerate): Ditto.
3029         (WKPCSetMenuBarVisible): Ditto.
3030         (WKPCSetFullscreenWindowIsShowing): Ditto.
3031         (WKPCSetModal): Ditto.
3032         (WKPCGetCookies): Ditto.
3033         (WKPCGetProxy): Ditto.
3034         (WKPCSetCookies): Ditto.
3035         (WKPCGetAuthenticationInfo): Ditto.
3036         (WKPCConvertPoint): Ditto.
3037         (WKPCLayerHostingModeChanged): Ditto.
3038         (WKPCSetException): Ditto.
3039
3040 2018-03-26  Tim Horton  <timothy_horton@apple.com>
3041
3042         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
3043         https://bugs.webkit.org/show_bug.cgi?id=184030
3044         <rdar://problem/38895281>
3045
3046         Reviewed by Dan Bernstein.
3047
3048         * Configurations/Base.xcconfig:
3049
3050 2018-03-26  Chris Dumez  <cdumez@apple.com>
3051
3052         Use SecurityOriginData more consistently in Service Worker code
3053         https://bugs.webkit.org/show_bug.cgi?id=183969
3054
3055         Reviewed by Darin Adler.
3056
3057         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3058
3059         * Storage/WebDatabaseManager.mm:
3060         (-[WebDatabaseManager databasesWithOrigin:]):
3061         (-[WebDatabaseManager deleteOrigin:]):
3062         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3063         * Storage/WebDatabaseQuotaManager.mm:
3064         (-[WebDatabaseQuotaManager usage]):
3065         (-[WebDatabaseQuotaManager quota]):
3066         (-[WebDatabaseQuotaManager setQuota:]):
3067         * Storage/WebStorageManager.mm:
3068         (-[WebStorageManager deleteOrigin:]):
3069         * WebCoreSupport/WebSecurityOrigin.mm:
3070         (-[WebSecurityOrigin databaseIdentifier]):
3071         (-[WebSecurityOrigin usage]):
3072         (-[WebSecurityOrigin quota]):
3073         (-[WebSecurityOrigin setQuota:]):
3074
3075 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
3076
3077         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
3078         https://bugs.webkit.org/show_bug.cgi?id=183911
3079         <rdar://problem/38762306>
3080
3081         Reviewed by Youenn Fablet.
3082
3083         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
3084
3085         * WebView/WebView.mm:
3086         (+[WebView initialize]):
3087
3088 2018-03-26  Alex Christensen  <achristensen@webkit.org>
3089
3090         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
3091         https://bugs.webkit.org/show_bug.cgi?id=183965
3092
3093         Reviewed by Chris Dumez.
3094
3095         * WebCoreSupport/WebFrameLoaderClient.h:
3096         * WebCoreSupport/WebFrameLoaderClient.mm:
3097         (WebFrameLoaderClient::willCacheResponse const):
3098
3099 2018-03-25  Commit Queue  <commit-queue@webkit.org>
3100
3101         Unreviewed, rolling out r229954.
3102         https://bugs.webkit.org/show_bug.cgi?id=184000
3103
3104         Caused many layout tests to crash on Apple High Sierra,
3105         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
3106         by dydz on #webkit).
3107
3108         Reverted changeset:
3109
3110         "Use SecurityOriginData more consistently in Service Worker
3111         code"
3112         https://bugs.webkit.org/show_bug.cgi?id=183969
3113         https://trac.webkit.org/changeset/229954
3114
3115 2018-03-24  Chris Dumez  <cdumez@apple.com>
3116
3117         Use SecurityOriginData more consistently in Service Worker code
3118         https://bugs.webkit.org/show_bug.cgi?id=183969
3119
3120         Reviewed by Darin Adler.
3121
3122         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3123
3124         * Storage/WebDatabaseManager.mm:
3125         (-[WebDatabaseManager databasesWithOrigin:]):
3126         (-[WebDatabaseManager deleteOrigin:]):
3127         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3128         * Storage/WebDatabaseQuotaManager.mm:
3129         (-[WebDatabaseQuotaManager usage]):
3130         (-[WebDatabaseQuotaManager quota]):
3131         (-[WebDatabaseQuotaManager setQuota:]):
3132         * Storage/WebStorageManager.mm:
3133         (-[WebStorageManager deleteOrigin:]):
3134         * WebCoreSupport/WebSecurityOrigin.mm:
3135         (-[WebSecurityOrigin databaseIdentifier]):
3136         (-[WebSecurityOrigin usage]):
3137         (-[WebSecurityOrigin quota]):
3138         (-[WebSecurityOrigin setQuota:]):
3139
3140 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
3141
3142         Fix the build
3143
3144         * WebView/WebView.mm:
3145
3146 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3147
3148         Fix the build with no pasteboard
3149         https://bugs.webkit.org/show_bug.cgi?id=183973
3150
3151         Reviewed by Dan Bernstein.
3152
3153         * Configurations/FeatureDefines.xcconfig:
3154         * WebView/WebView.mm:
3155         (-[WebView _requestStartDataInteraction:globalPosition:]):
3156         (-[WebView _getDataInteractionData]):
3157         (-[WebView _dataOperationTextIndicator]):
3158         (-[WebView _dragSourceAction]):
3159         (-[WebView _draggedLinkTitle]):
3160         (-[WebView _draggedLinkURL]):
3161         (-[WebView _draggedElementBounds]):
3162         (-[WebView _enteredDataInteraction:client:global:operation:]):
3163         (-[WebView _updatedDataInteraction:client:global:operation:]):
3164         (-[WebView _exitedDataInteraction:client:global:operation:]):
3165         (-[WebView _performDataInteraction:client:global:operation:]):
3166         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3167         (-[WebView _endedDataInteraction:global:]):
3168         (-[WebView _dataInteractionCaretRect]):
3169         * WebView/WebViewPrivate.h:
3170
3171 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3172
3173         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
3174         https://bugs.webkit.org/show_bug.cgi?id=183960
3175         <rdar://problem/38812356>
3176
3177         Reviewed by Dan Bernstein.
3178
3179         * Configurations/WebKitLegacy.xcconfig:
3180
3181 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3182
3183         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
3184         https://bugs.webkit.org/show_bug.cgi?id=183954
3185         <rdar://problem/38808858>
3186
3187         Reviewed by Dan Bernstein.
3188
3189         * WebView/WebPreferences.mm:
3190         (-[WebPreferences setAudioSessionCategoryOverride:]):
3191
3192 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3193
3194         Adopt WK_PLATFORM_NAME in WebKitLegacy
3195         https://bugs.webkit.org/show_bug.cgi?id=183948
3196         <rdar://problem/38803908>
3197
3198         Reviewed by Dan Bernstein.
3199
3200         * Configurations/WebKitLegacy.xcconfig:
3201         * MigrateHeaders.make:
3202         * postprocess-headers.sh:
3203
3204 2018-03-23  Brady Eidson  <beidson@apple.com>
3205
3206         Go to back/forward list items after a process-swapped navigation.
3207         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
3208
3209         Reviewed by Andy Estes.
3210
3211         * WebView/WebView.mm:
3212         (-[WebView _loadBackForwardListFromOtherView:]):
3213         (-[WebView goToBackForwardItem:]):
3214
3215 2018-03-22  Tim Horton  <timothy_horton@apple.com>
3216
3217         Improve readability of WebCore's OTHER_LDFLAGS
3218         https://bugs.webkit.org/show_bug.cgi?id=183909
3219         <rdar://problem/38760992>
3220
3221         Reviewed by Dan Bernstein.
3222
3223         * Configurations/Base.xcconfig:
3224         * Configurations/FeatureDefines.xcconfig:
3225
3226 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3227
3228         Enable the minimal simulator feature flag when appropriate
3229         https://bugs.webkit.org/show_bug.cgi?id=183807
3230
3231         Reviewed by Dan Bernstein.
3232
3233         * Configurations/FeatureDefines.xcconfig:
3234
3235 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3236
3237         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
3238         https://bugs.webkit.org/show_bug.cgi?id=183758
3239         <rdar://problem/38017644>
3240
3241         Reviewed by Dan Bernstein.
3242
3243         * Configurations/FeatureDefines.xcconfig:
3244
3245 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
3246
3247         Clear style colors when setting default appearance
3248         https://bugs.webkit.org/show_bug.cgi?id=183759
3249
3250         Reviewed by Tim Horton.
3251
3252         Colors are cached and need to be cleared and recalculated.
3253         Refactor to do all style recalcs together.
3254
3255         * WebView/WebView.mm:
3256         (-[WebView _setDefaultAppearanceAndClearStyle]):
3257         (-[WebView _setUseSystemAppearance:]):
3258         (-[WebView effectiveAppearanceDidChange]):
3259
3260 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3261
3262         Unreviewed, another quick fix for r229699
3263
3264         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
3265
3266         * Configurations/FeatureDefines.xcconfig:
3267
3268 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
3269
3270         Ensure that style is updated when the effective appearance changes
3271         https://bugs.webkit.org/show_bug.cgi?id=183690
3272         <rdar://problem/38385900>
3273
3274         Reviewed by Tim Horton and Wenson Hsieh.
3275
3276         Respond to and respect the effective appearance changing.
3277
3278         * WebView/WebView.mm:
3279         (-[WebView _setUseSystemAppearance:]):
3280         (-[WebView effectiveAppearanceDidChange]):
3281
3282 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
3283
3284         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
3285         https://bugs.webkit.org/show_bug.cgi?id=183677
3286
3287         Reviewed by Tim Horton.
3288
3289         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
3290
3291         * DOM/DOM.mm:
3292         (-[DOMHTMLLinkElement _mediaQueryMatches]):
3293
3294 2018-03-14  Tim Horton  <timothy_horton@apple.com>
3295
3296         Fix the build after r229567
3297
3298         * Configurations/FeatureDefines.xcconfig:
3299
3300 2018-03-12  Tim Horton  <timothy_horton@apple.com>
3301
3302         Stop using SDK conditionals to control feature definitions
3303         https://bugs.webkit.org/show_bug.cgi?id=183430
3304         <rdar://problem/38251619>
3305
3306         Reviewed by Dan Bernstein.
3307
3308         * Configurations/FeatureDefines.xcconfig:
3309         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
3310
3311 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
3312
3313         Runtime flag for link prefetch and remove link subresource.
3314         https://bugs.webkit.org/show_bug.cgi?id=183540
3315
3316         Reviewed by Chris Dumez.
3317
3318         Remove the LINK_PREFETCH build time flag.
3319
3320         * Configurations/FeatureDefines.xcconfig:
3321
3322 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
3323
3324         Remove GridLayout runtime flag
3325         https://bugs.webkit.org/show_bug.cgi?id=183484
3326
3327         Reviewed by Myles C. Maxfield.
3328
3329         The Grid Layout feature has been enabled by default for almost a
3330         year, so I think it's time to remove the runtime flag and the
3331
3332         * WebView/WebPreferenceKeysPrivate.h:
3333         * WebView/WebPreferences.mm:
3334         (+[WebPreferences initialize]):
3335         * WebView/WebPreferencesPrivate.h:
3336         * WebView/WebView.mm:
3337         (-[WebView _preferencesChanged:]):
3338
3339 2018-03-12  Antoine Quint  <graouts@apple.com>
3340
3341         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
3342         https://bugs.webkit.org/show_bug.cgi?id=183504
3343         <rdar://problem/38372965>
3344
3345         Reviewed by Dean Jackson and Jon Lee.
3346
3347         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
3348         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
3349
3350         * WebView/WebPreferenceKeysPrivate.h:
3351         * WebView/WebPreferences.mm:
3352         (+[WebPreferences initialize]):
3353         (-[WebPreferences setModernMediaControlsEnabled:]):
3354         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
3355         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
3356         * WebView/WebPreferencesPrivate.h:
3357         * WebView/WebView.mm:
3358         (-[WebView _preferencesChanged:]):
3359
3360 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
3361
3362         Media query for default appearance
3363         https://bugs.webkit.org/show_bug.cgi?id=183539
3364         <rdar://problem/38326388>
3365
3366         Reviewed by Tim Horton.
3367
3368         Write a media query to evaluate appearance.
3369
3370         * WebView/WebView.mm:
3371         (-[WebView _commonInitializationWithFrameName:groupName:]):
3372         (-[WebView _setUseSystemAppearance:]):
3373
3374 2018-03-09  Andy Estes  <aestes@apple.com>
3375
3376         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
3377         https://bugs.webkit.org/show_bug.cgi?id=183489
3378         <rdar://problem/38267517>
3379
3380         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
3381         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
3382         to issue a sandbox extension for this directory, but for security reasons App Sandbox
3383         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
3384         block with a nil error and a valid file URL, but no file will actually exist at that URL.
3385
3386         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
3387         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
3388         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
3389         drop destination.
3390
3391         Reviewed by Wenson Hsieh.
3392
3393         * WebView/WebView.mm:
3394         (-[WebView performDragOperation:]):
3395
3396 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
3397
3398         Allow WebViews to disable system appearance
3399         https://bugs.webkit.org/show_bug.cgi?id=183418
3400         <rdar://problem/36975642>
3401
3402         Reviewed by Tim Horton.
3403
3404         Allow webviews to choose whether or not to follow the default system appearance.
3405
3406         * WebView/WebView.mm:
3407         (-[WebView _setUseSystemAppearance:]):
3408         (-[WebView _useSystemAppearance]):
3409         * WebView/WebViewPrivate.h:
3410
3411 2018-03-08  Youenn Fablet  <youenn@apple.com>
3412
3413         libwebrtc update broke internal builds
3414         https://bugs.webkit.org/show_bug.cgi?id=183454
3415
3416         Reviewed by Eric Carlson.
3417
3418         * Configurations/WebKitLegacy.xcconfig:
3419
3420 2018-03-08  Chris Dumez  <cdumez@apple.com>
3421
3422         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
3423         https://bugs.webkit.org/show_bug.cgi?id=183455
3424         <rdar://problem/38191749>
3425
3426         Reviewed by Youenn Fablet.
3427
3428         Add a null check for the page as we have evidence from crashes that it can be null.
3429         Other functions in WebFrameNetworkingContext already null check the page as well,
3430         not just the frame so this is consistent.
3431
3432         * WebCoreSupport/WebFrameNetworkingContext.mm:
3433         (WebFrameNetworkingContext::storageSession const):
3434
3435 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3436
3437         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
3438         https://bugs.webkit.org/show_bug.cgi?id=183429
3439
3440         Reviewed by Mark Lam.
3441
3442         * DOM/DOM.mm:
3443         (+[DOMNode _nodeFromJSWrapper:]):
3444         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3445         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
3446         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
3447         * Plugins/Hosted/ProxyInstance.mm:
3448         (WebKit::ProxyInstance::invokeMethod):
3449         * WebView/WebView.mm:
3450         (aeDescFromJSValue):
3451
3452 2018-03-08  Tim Horton  <timothy_horton@apple.com>
3453
3454         Stop linking ApplicationServices directly
3455         https://bugs.webkit.org/show_bug.cgi?id=182867
3456         <rdar://problem/38252142>
3457
3458         Reviewed by Alex Christensen.
3459
3460         The frameworks that we use that live inside ApplicationServices
3461         have mostly moved out, so import them directly.
3462
3463         * Carbon/CarbonUtils.h:
3464         * WebKitPrefix.h:
3465         * WebView/WebHTMLView.mm:
3466         * WebView/WebPDFView.mm:
3467
3468 2018-03-07  Tim Horton  <timothy_horton@apple.com>
3469
3470         Sort and separate FeatureDefines.xcconfig
3471         https://bugs.webkit.org/show_bug.cgi?id=183427
3472
3473         Reviewed by Dan Bernstein.
3474
3475         * Configurations/FeatureDefines.xcconfig:
3476         Sort and split FeatureDefines into paragraphs
3477         (to make it easier to sort later).
3478
3479 2018-03-07  Youenn Fablet  <youenn@apple.com>
3480
3481         Match unsupported plugins based on domains and not origin
3482         https://bugs.webkit.org/show_bug.cgi?id=183384
3483
3484         Reviewed by Chris Dumez.
3485
3486         * WebCoreSupport/WebPluginInfoProvider.h:
3487         * WebCoreSupport/WebPluginInfoProvider.mm:
3488         (WebPluginInfoProvider::getPluginInfo):
3489         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3490
3491 2018-03-05  Andy Estes  <aestes@apple.com>
3492
3493         [Mac] Teach WebCore::Pasteboard about file promise drags
3494         https://bugs.webkit.org/show_bug.cgi?id=183314
3495         <rdar://problem/38105493>
3496
3497         Reviewed by Darin Adler.
3498
3499         Added a FIXME comment.
3500
3501         * WebView/WebView.mm:
3502         (-[WebView performDragOperation:]):
3503
3504 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3505
3506         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
3507         https://bugs.webkit.org/show_bug.cgi?id=183312
3508
3509         Reviewed by Mark Lam.
3510
3511         Remove wtf/CurrentTime.h include pragma.
3512
3513         * WebView/WebFrame.mm:
3514         * WebView/WebPDFView.mm:
3515
3516 2018-03-04  Tim Horton  <timothy_horton@apple.com>
3517
3518         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
3519         https://bugs.webkit.org/show_bug.cgi?id=183283
3520         <rdar://problem/38062148>
3521
3522         Reviewed by Sam Weinig.
3523
3524         * Configurations/FeatureDefines.xcconfig:
3525
3526 2018-02-28  Alex Christensen  <achristensen@webkit.org>
3527
3528         Reduce use of NetworkingContext in WebKit
3529         https://bugs.webkit.org/show_bug.cgi?id=183213
3530
3531         Reviewed by Brady Eidson.
3532
3533         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3534         (WebKit::NetscapePluginInstanceProxy::getProxy):
3535         * Plugins/WebNetscapePluginView.mm:
3536         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
3537
3538 2018-02-17  Darin Adler  <darin@apple.com>
3539
3540         Prepare for ExtendedColor changes (first step)
3541         https://bugs.webkit.org/show_bug.cgi?id=182904
3542
3543         Reviewed by Sam Weinig.
3544
3545         * Misc/WebKitNSStringExtras.mm:
3546         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
3547
3548 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
3549
3550         Remove currentTime() / currentTimeMS()
3551         https://bugs.webkit.org/show_bug.cgi?id=183052
3552
3553         Reviewed by Mark Lam.
3554
3555         * WebCoreSupport/WebFrameLoaderClient.h:
3556         * WebCoreSupport/WebFrameLoaderClient.mm:
3557         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
3558
3559 2018-02-16  Youenn Fablet  <youenn@apple.com>
3560
3561         Allow specifying which plug-ins are supported
3562         https://bugs.webkit.org/show_bug.cgi?id=182748
3563
3564         Reviewed by Chris Dumez.
3565
3566         * WebCoreSupport/WebPluginInfoProvider.h:
3567         * WebCoreSupport/WebPluginInfoProvider.mm:
3568         (WebPluginInfoProvider::getPluginInfo):
3569         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3570
3571 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
3572
3573         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
3574         https://bugs.webkit.org/show_bug.cgi?id=182882
3575         <rdar://problem/35672661>
3576
3577         Reviewed by Dan Bernstein.
3578
3579         Make sure the smart pointer hold the collection of subviews lives at least as
3580         long as the loop using it.
3581
3582         * WebView/WebHTMLView.mm:
3583         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
3584
3585 2018-02-14  Daniel Bates  <dabates@apple.com>
3586
3587         Disallow cross-origin subresources from asking for credentials
3588         https://bugs.webkit.org/show_bug.cgi?id=182579
3589         <rdar://problem/36162271>
3590
3591         Reviewed by Andy Estes.
3592
3593         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
3594         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
3595
3596         * WebView/WebPreferenceKeysPrivate.h:
3597         * WebView/WebPreferences.mm:
3598         (+[WebPreferences initialize]):
3599         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
3600         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
3601         * WebView/WebPreferencesPrivate.h:
3602         * WebView/WebView.mm:
3603         (-[WebView _preferencesChanged:]):
3604
3605 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3606
3607         Remove ForwardingHeaders directory from WebKitLegacy/mac.
3608         https://bugs.webkit.org/show_bug.cgi?id=182738
3609
3610         Reviewed by Darin Adler.
3611
3612         * ForwardingHeaders/collector/handles/Global.h: Removed.
3613         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
3614         * ForwardingHeaders/runtime/Completion.h: Removed.
3615         * ForwardingHeaders/runtime/Error.h: Removed.
3616         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
3617         * ForwardingHeaders/runtime/JSFunction.h: Removed.
3618         * ForwardingHeaders/runtime/JSLock.h: Removed.
3619         * ForwardingHeaders/runtime/JSObject.h: Removed.
3620         * ForwardingHeaders/runtime/JSString.h: Removed.
3621         * ForwardingHeaders/runtime/Protect.h: Removed.
3622         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
3623
3624 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
3625
3626         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
3627         https://bugs.webkit.org/show_bug.cgi?id=182641
3628
3629         Reviewed by Dan Bernstein.
3630
3631         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
3632         https://trac.webkit.org/changeset/228308.
3633
3634         * WebView/WebVideoFullscreenController.h:
3635         * WebView/WebVideoFullscreenHUDWindowController.mm:
3636         * WebView/WebWindowAnimation.h:
3637         * WebView/WebWindowAnimation.mm:
3638         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
3639         (WebCore::scaledRect): Deleted.
3640         (WebCore::squaredDistance): Deleted.
3641
3642 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
3643
3644         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
3645
3646         * WebView/WebWindowAnimation.mm:
3647         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
3648
3649 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
3650
3651         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
3652         https://bugs.webkit.org/show_bug.cgi?id=182615
3653
3654         Reviewed by Eric Carlson.
3655
3656         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
3657         Ideally, we should not reference NSApp in WebCore.
3658
3659         * WebView/WebFullScreenController.mm:
3660         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
3661         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
3662         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
3663         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
3664         * WebView/WebView.mm:
3665         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
3666         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
3667
3668 2018-01-13  Darin Adler  <darin@apple.com>
3669
3670         Event improvements
3671         https://bugs.webkit.org/show_bug.cgi?id=179591
3672
3673         Reviewed by Chris Dumez.
3674
3675         * DOM/DOMWheelEvent.mm:
3676         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
3677         Call initWebKitWheelEvent.
3678
3679         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
3680         * WebCoreSupport/WebInspectorClient.mm: Ditto.
3681         * WebView/WebFrame.mm: Ditto.
3682
3683         * WebView/WebHTMLView.mm:
3684         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
3685         underlyingPlatformEvent.
3686         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
3687
3688         * WebView/WebScriptWorld.mm:
3689         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
3690
3691         * WebView/WebView.mm: Removed include of ScriptValue.h.
3692
3693 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
3694
3695         Remove WebCore/ForwardingHeaders directory
3696         https://bugs.webkit.org/show_bug.cgi?id=182347
3697
3698         Reviewed by Keith Miller.
3699
3700         * Carbon/CarbonWindowAdapter.mm:
3701         * DOM/WebDOMOperations.mm:
3702         * History/WebBackForwardList.mm:
3703         * History/WebHistoryItem.mm:
3704         * Misc/WebCache.mm:
3705         * Misc/WebElementDictionary.mm:
3706         * Misc/WebIconDatabase.mm:
3707         * Misc/WebStringTruncator.mm:
3708         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3709         * Plugins/Hosted/ProxyInstance.mm:
3710         * Plugins/Hosted/ProxyRuntimeObject.mm:
3711         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3712         * Plugins/WebBaseNetscapePluginView.mm:
3713         * Plugins/WebBasePluginPackage.mm:
3714         * Plugins/WebNetscapePluginStream.mm:
3715         * Plugins/WebNetscapePluginView.mm:
3716         * Plugins/WebPluginController.mm:
3717         * WebCoreSupport/WebEditorClient.mm:
3718         * WebCoreSupport/WebFrameLoaderClient.mm:
3719         * WebCoreSupport/WebInspectorClient.h:
3720         * WebCoreSupport/WebInspectorClient.mm:
3721         * WebView/WebDataSource.mm:
3722         * WebView/WebFrame.mm:
3723         * WebView/WebHTMLRepresentation.mm:
3724         * WebView/WebHTMLView.mm:
3725         * WebView/WebPreferences.mm:
3726         * WebView/WebScriptDebugDelegate.mm:
3727         * WebView/WebScriptDebugger.h:
3728         * WebView/WebTextIterator.mm:
3729         * WebView/WebView.mm:
3730         * WebView/WebViewData.mm:
3731
3732 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
3733
3734         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
3735         https://bugs.webkit.org/show_bug.cgi?id=182312
3736
3737         Reviewed by Michael Catanzaro.
3738
3739         * WebKitPrefix.h:
3740
3741 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
3742
3743         [WebAuthN] Add a compile-time feature flag
3744         https://bugs.webkit.org/show_bug.cgi?id=182211
3745         <rdar://problem/36936365>
3746
3747         Reviewed by Brent Fulgham.
3748
3749         * Configurations/FeatureDefines.xcconfig:
3750
3751 2018-01-27  Dan Bernstein  <mitz@apple.com>
3752
3753         HaveInternalSDK includes should be "#include?"
3754         https://bugs.webkit.org/show_bug.cgi?id=179670
3755
3756         * Configurations/Base.xcconfig:
3757
3758 2018-01-24  Alex Christensen  <achristensen@webkit.org>
3759
3760         Remove unused QTKit preference
3761         https://bugs.webkit.org/show_bug.cgi?id=181968
3762
3763         Reviewed by Alexey Proskuryakov.
3764
3765         * WebView/WebPreferenceKeysPrivate.h:
3766         * WebView/WebPreferences.mm:
3767         (+[WebPreferences initialize]):
3768         (-[WebPreferences setQTKitEnabled:]): Deleted.
3769         (-[WebPreferences isQTKitEnabled]): Deleted.
3770         * WebView/WebPreferencesPrivate.h:
3771         * WebView/WebView.mm:
3772         (-[WebView _preferencesChanged:]):
3773
3774 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3775
3776         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
3777         https://bugs.webkit.org/show_bug.cgi?id=182037
3778         <rdar://problem/36747812>
3779
3780         Reviewed by Ryosuke Niwa.
3781
3782         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
3783         for more details.
3784
3785         * WebView/WebHTMLRepresentation.mm:
3786         (-[WebHTMLRepresentation elementWithName:inForm:]):
3787         (-[WebHTMLRepresentation controlsInForm:]):
3788
3789 2018-01-23  Alex Christensen  <achristensen@webkit.org>
3790
3791         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
3792         https://bugs.webkit.org/show_bug.cgi?id=181961
3793
3794         Reviewed by Michael Catanzaro.
3795
3796         * WebView/WebPreferences.mm:
3797
3798 2018-01-23  Commit Queue  <commit-queue@webkit.org>
3799
3800         Unreviewed, rolling out r227437.
3801         https://bugs.webkit.org/show_bug.cgi?id=182011
3802
3803         broke build (Requested by alexchristensen on #webkit).
3804
3805         Reverted changeset:
3806
3807         "Remove unused QTKit preference"
3808         https://bugs.webkit.org/show_bug.cgi?id=181968
3809         https://trac.webkit.org/changeset/227437
3810
3811 2018-01-23  Alex Christensen  <achristensen@webkit.org>
3812
3813         Remove unused QTKit preference
3814         https://bugs.webkit.org/show_bug.cgi?id=181968
3815
3816         Reviewed by Alexey Proskuryakov.
3817
3818         * WebView/WebPreferenceKeysPrivate.h:
3819         * WebView/WebPreferences.mm:
3820         (+[WebPreferences initialize]):
3821         (-[WebPreferences setQTKitEnabled:]): Deleted.
3822         (-[WebPreferences isQTKitEnabled]): Deleted.
3823         * WebView/WebPreferencesPrivate.h:
3824         * WebView/WebView.mm:
3825         (-[WebView _preferencesChanged:]):
3826
3827 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3828
3829         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
3830         https://bugs.webkit.org/show_bug.cgi?id=181960
3831         <rdar://problem/36431678>
3832
3833         Reviewed by Tim Horton.
3834
3835         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
3836         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
3837         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
3838
3839         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
3840         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
3841         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
3842
3843         * WebView/WebView.mm:
3844         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3845
3846 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
3847
3848         Turning off custom pasteboard data doesn't actually turn it off in WK2
3849         https://bugs.webkit.org/show_bug.cgi?id=181920
3850         <rdar://problem/36686429>
3851
3852         Reviewed by Wenson Hsieh.
3853
3854         Always disable custom pasteboard data in WebKit1. See r226156 for details.
3855
3856         * WebView/WebPreferences.mm:
3857         (+[WebPreferences initialize]):
3858         * WebView/WebView.mm:
3859         (-[WebView _preferencesChanged:]):
3860
3861 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3862
3863         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
3864         https://bugs.webkit.org/show_bug.cgi?id=181918
3865
3866         Reviewed by Tim Horton.
3867
3868         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
3869
3870         * Configurations/FeatureDefines.xcconfig:
3871
3872 2018-01-20  Andy Estes  <aestes@apple.com>
3873
3874         [Apple Pay] Stop eagerly loading PassKit.framework
3875         https://bugs.webkit.org/show_bug.cgi?id=181911
3876         <rdar://problem/36555369>
3877
3878         Reviewed by Tim Horton.
3879
3880         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3881         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3882         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
3883
3884         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
3885
3886 2018-01-19  Dean Jackson  <dino@apple.com>
3887
3888         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
3889         https://bugs.webkit.org/show_bug.cgi?id=181817
3890         <rdar://problem/35274055>
3891
3892         Reviewed by Simon Fraser.
3893
3894         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
3895
3896         * Misc/WebKitVersionChecks.h:
3897         * WebView/WebView.mm:
3898         (-[WebView _commonInitializationWithFrameName:groupName:]):
3899
3900 2018-01-19  Alex Christensen  <achristensen@webkit.org>
3901
3902         Remove unused WebViewPrivate _allowCookies
3903         https://bugs.webkit.org/show_bug.cgi?id=181812
3904
3905         Reviewed by Tim Horton.
3906
3907         * WebView/WebView.mm:
3908         (+[WebView _setAllowCookies:]): Deleted.
3909         (+[WebView _allowCookies]): Deleted.
3910         * WebView/WebViewPrivate.h:
3911
3912 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
3913
3914         Build fix, remove a call to -[NSWindow setOneShot:]
3915         https://bugs.webkit.org/show_bug.cgi?id=181809
3916
3917         Reviewed by Tim Horton.
3918
3919         * WebView/WebTextCompletionController.mm:
3920         (-[WebTextCompletionController _buildUI]):
3921
3922 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3923
3924         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
3925
3926         * Carbon/HIWebView.mm:
3927         (overrideCGContext):
3928         (restoreCGContext):
3929
3930 2018-01-18  Dan Bernstein  <mitz@apple.com>
3931
3932         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
3933         https://bugs.webkit.org/show_bug.cgi?id=181803
3934
3935         Reviewed by Tim Horton.
3936
3937         * Configurations/Base.xcconfig: Updated.
3938         * Configurations/DebugRelease.xcconfig: Ditto.
3939         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
3940         * Configurations/Version.xcconfig: Updated.
3941         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
3942           useful for defining settings that depend on the target macOS version.
3943
3944 2018-01-17  Youenn Fablet  <youenn@apple.com>
3945
3946         Put fetch Request.keepalive behind a runtime flag
3947         https://bugs.webkit.org/show_bug.cgi?id=181592
3948
3949         Reviewed by Chris Dumez.
3950
3951         * WebView/WebPreferenceKeysPrivate.h:
3952         * WebView/WebPreferences.mm:
3953         (+[WebPreferences initialize]):
3954         (-[WebPreferences fetchAPIKeepAliveEnabled]):
3955         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
3956         * WebView/WebPreferencesPrivate.h:
3957         * WebView/WebView.mm:
3958         (-[WebView _preferencesChanged:]):
3959
3960 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3961
3962         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
3963         https://bugs.webkit.org/show_bug.cgi?id=181637
3964         <rdar://problem/36508471>
3965
3966         Reviewed by Tim Horton.
3967
3968         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
3969
3970         * WebCoreSupport/WebEditorClient.h:
3971         * WebCoreSupport/WebEditorClient.mm:
3972         (WebEditorClient::replacementURLForResource):
3973
3974 2018-01-11  Keith Miller  <keith_miller@apple.com>
3975
3976         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
3977         https://bugs.webkit.org/show_bug.cgi?id=181573
3978
3979         Reviewed by Simon Fraser.
3980
3981         * Configurations/FeatureDefines.xcconfig:
3982
3983 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3984
3985         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
3986         https://bugs.webkit.org/show_bug.cgi?id=181497
3987
3988         Reviewed by Tim Horton.
3989
3990         See other ChangeLogs for more detail.
3991
3992         * WebCoreSupport/WebDragClient.h:
3993
3994 2018-01-11  Tim Horton  <timothy_horton@apple.com>
3995
3996         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
3997         https://bugs.webkit.org/show_bug.cgi?id=181523
3998         <rdar://problem/28959131>
3999
4000         Reviewed by Alex Christensen.
4001
4002         * WebView/WebImmediateActionController.mm:
4003         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
4004         Apply the change made in r216652 to WebKit1's immediate action controller.
4005
4006         Speculative (but successful in WebKit2) fix for non-reproducible crash when
4007         the startContainer of the range is in an anonymous node.
4008
4009 2018-01-11  Youenn Fablet  <youenn@apple.com>
4010
4011         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
4012         https://bugs.webkit.org/show_bug.cgi?id=181480
4013
4014         Reviewed by Eric Carlson.
4015
4016         * WebView/WebPreferences.mm:
4017         (+[WebPreferences initialize]):
4018
4019 2018-01-08  David Kilzer  <ddkilzer@apple.com>
4020
4021         Fix check-webkit-style issues with WebNSDataExtras.mm
4022         <https://webkit.org/b/181369>
4023
4024         Reviewed by Alex Christensen.
4025
4026         * Misc/WebNSDataExtras.mm:
4027         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
4028         (-[NSData _webkit_guessedMIMETypeForXML]):
4029         (-[NSData _webkit_guessedMIMEType]):
4030         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
4031         (_findEOL):
4032         (-[NSData _webkit_parseRFC822HeaderFields]):
4033         (-[NSData _web_locationAfterFirstBlankLine]):
4034         - Fix all the check-webkit-style warnings.
4035
4036 2018-01-08  David Kilzer  <ddkilzer@apple.com>
4037
4038         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
4039         <https://webkit.org/b/181256>
4040         <rdar://problem/36281730>
4041
4042         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
4043         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
4044         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
4045           to avoid warnings from casting CFStringRef to NPNSString*.
4046           Note that CFMutableStringRef is the same as CFStringRef
4047           without the const modifier, hence its use in the const_cast<>
4048           above.
4049
4050 2018-01-08  David Kilzer  <ddkilzer@apple.com>
4051
4052         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
4053         <https://webkit.org/b/181256>
4054         <rdar://problem/36281730>
4055
4056         * Carbon/HIWebView.mm:
4057         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
4058         checked_cf_cast<CFRunLoopRef>() to fix warning.
4059
4060 2018-01-07  David Kilzer  <ddkilzer@apple.com>
4061
4062         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
4063         <https://webkit.org/b/181256>
4064         <rdar://problem/36281730>
4065
4066         Reviewed by Darin Adler.
4067