Add WebView SPI to temporarily force light or dark appearance on a page.
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-02-04  Timothy Hatcher  <timothy@apple.com>
2
3         Add WebView SPI to temporarily force light or dark appearance on a page.
4         https://bugs.webkit.org/show_bug.cgi?id=194230
5
6         Reviewed by Tim Horton.
7
8         * WebView/WebView.mm:
9         (-[WebView _useDarkAppearance:]): Added.
10         (-[WebView _setUseDarkAppearance:]): Added.
11         * WebView/WebViewPrivate.h:
12
13 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
14
15         PageOverlayController's layers should be created lazily
16         https://bugs.webkit.org/show_bug.cgi?id=194199
17         rdar://problem/46571593
18
19         Reviewed by Tim Horton.
20
21         * WebCoreSupport/WebChromeClient.h:
22         * WebCoreSupport/WebChromeClient.mm:
23         (WebChromeClient::attachViewOverlayGraphicsLayer):
24
25 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
26
27         Make setNeedsLayout on the root more explicitly about triggering its side-effects
28         https://bugs.webkit.org/show_bug.cgi?id=194198
29
30         Reviewed by Antti Koivisto.
31
32         Call the newly named functions.
33
34         * WebView/WebFrame.mm:
35         (-[WebFrame setNeedsLayout]):
36         * WebView/WebHTMLView.mm:
37         (-[WebHTMLView setNeedsLayout:]):
38
39 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
40
41         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
42         https://bugs.webkit.org/show_bug.cgi?id=194189
43
44         Reviewed by Geoffrey Garen.
45
46         Pass the policy check identifier around functions and store it in WebFramePolicyListener
47         so that we can send it back to WebCore with the navigation policy decision.
48
49         * WebCoreSupport/WebFrameLoaderClient.h:
50         * WebCoreSupport/WebFrameLoaderClient.mm:
51         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
52         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
53         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
54         (WebFrameLoaderClient::dispatchWillSubmitForm):
55         (WebFrameLoaderClient::setUpPolicyListener):
56         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
57         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
58         (-[WebFramePolicyListener invalidate]):
59         (-[WebFramePolicyListener dealloc]):
60         (-[WebFramePolicyListener receivedPolicyDecision:]):
61         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
62         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
63
64 2019-01-31  Alex Christensen  <achristensen@webkit.org>
65
66         Revert r238819 which is unneeded and caused a performance regression.
67         https://bugs.webkit.org/show_bug.cgi?id=192272
68         <rdar://problem/46664625>
69
70         * WebCoreSupport/WebFrameLoaderClient.h:
71         * WebCoreSupport/WebFrameLoaderClient.mm:
72         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
73
74 2019-01-28  Devin Rousso  <drousso@apple.com>
75
76         Web Inspector: provide a way to edit page WebRTC settings on a remote target
77         https://bugs.webkit.org/show_bug.cgi?id=193863
78         <rdar://problem/47572764>
79
80         Reviewed by Joseph Pecoraro.
81
82         * WebView/WebView.mm:
83         (-[WebView _preferencesChanged:]):
84         Add page-level settings for WebRTC preferences.
85
86 2019-01-28  Andy Estes  <aestes@apple.com>
87
88         [watchOS] Enable Parental Controls content filtering
89         https://bugs.webkit.org/show_bug.cgi?id=193939
90         <rdar://problem/46641912>
91
92         Reviewed by Ryosuke Niwa.
93
94         * Configurations/FeatureDefines.xcconfig:
95
96 2019-01-28  Timothy Hatcher  <timothy@apple.com>
97
98         Make it easier for non-Apple ports to enable dark mode CSS support.
99         https://bugs.webkit.org/show_bug.cgi?id=193882
100
101         Reviewed by Megan Gardner.
102
103         * WebView/WebView.mm:
104         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
105         (-[WebView _effectiveAppearanceIsDark]): Ditto.
106
107 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
108
109         AX: Introduce a static accessibility tree
110         https://bugs.webkit.org/show_bug.cgi?id=193348
111         <rdar://problem/47203295>
112
113         Reviewed by Ryosuke Niwa.
114
115         * Configurations/FeatureDefines.xcconfig:
116
117 2019-01-25  Keith Rollin  <krollin@apple.com>
118
119         Update WebKitAdditions.xcconfig with correct order of variable definitions
120         https://bugs.webkit.org/show_bug.cgi?id=193793
121         <rdar://problem/47532439>
122
123         Reviewed by Alex Christensen.
124
125         XCBuild changes the way xcconfig variables are evaluated. In short,
126         all config file assignments are now considered in part of the
127         evaluation. When using the new build system and an .xcconfig file
128         contains multiple assignments of the same build setting:
129
130         - Later assignments using $(inherited) will inherit from earlier
131           assignments in the xcconfig file.
132         - Later assignments not using $(inherited) will take precedence over
133           earlier assignments. An assignment to a more general setting will
134           mask an earlier assignment to a less general setting. For example,
135           an assignment without a condition ('FOO = bar') will completely mask
136           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
137
138         This affects some of our .xcconfig files, in that sometimes platform-
139         or sdk-specific definitions appear before the general definitions.
140         Under the new evaluations rules, the general definitions alway take
141         effect because they always overwrite the more-specific definitions. The
142         solution is to swap the order, so that the general definitions are
143         established first, and then conditionally overwritten by the
144         more-specific definitions.
145
146         * Configurations/Version.xcconfig:
147         * Configurations/WebKitLegacy.xcconfig:
148
149 2019-01-25  David Kilzer  <ddkilzer@apple.com>
150
151         Move soft-linking of Lookup.framework out of LookupSPI.h
152         <https://webkit.org/b/193815>
153
154         Reviewed by Tim Horton.
155
156         * WebView/WebImmediateActionController.mm:
157         (-[WebImmediateActionController _animationControllerForText]):
158         * WebView/WebView.mm:
159         (-[WebView _prepareForDictionaryLookup]):
160         - Move soft-linking to LookupSoftLink.{h,mm}.
161
162 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
163
164         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
165         https://bugs.webkit.org/show_bug.cgi?id=193829
166
167         Reviewed by Tim Horton.
168
169         * WebCoreSupport/WebDragClient.mm:
170         (WebDragClient::didConcludeEditDrag):
171         * WebView/WebView.mm:
172         (-[WebView _requestStartDataInteraction:globalPosition:]):
173         (-[WebView _didConcludeEditDrag]):
174         (-[WebView _didConcludeEditDataInteraction]): Deleted.
175         * WebView/WebViewInternal.h:
176
177 2019-01-24  John Wilander  <wilander@apple.com>
178
179         Add Ad Click Attribution as an internal/experimental feature
180         https://bugs.webkit.org/show_bug.cgi?id=193685
181         <rdar://problem/47450399>
182
183         Reviewed by Brent Fulgham.
184
185         * WebView/WebPreferenceKeysPrivate.h:
186         * WebView/WebPreferences.mm:
187         (+[WebPreferences initialize]):
188         (-[WebPreferences adClickAttributionEnabled]):
189         (-[WebPreferences setAdClickAttributionEnabled:]):
190             Added support for experimental ad click attribution.
191         * WebView/WebPreferencesPrivate.h:
192         * WebView/WebView.mm:
193         (-[WebView _preferencesChanged:]):
194
195 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
196
197         Move FileSystem to WTF
198         https://bugs.webkit.org/show_bug.cgi?id=193602
199
200         Reviewed by Yusuke Suzuki.
201
202         * Misc/WebNSFileManagerExtras.mm:
203         * Storage/WebDatabaseProvider.mm:
204         * WebView/WebView.mm:
205
206 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
207
208         Fix the Apple Internal build. See <rdar://problem/47491383>.
209
210         Rubber-stamped by Tim Horton.
211
212         * WebCoreSupport/WebFrameLoaderClient.mm:
213
214 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
215
216         Clean up USE(WEB_THREAD)
217         https://bugs.webkit.org/show_bug.cgi?id=193698
218
219         Rubber-stamped by Tim Horton.
220
221         * Misc/WebCache.mm:
222         (+[WebCache emptyInMemoryResources]):
223         * WebCoreSupport/WebFrameLoaderClient.mm:
224         (-[WebFramePolicyListener use]):
225         * WebCoreSupport/WebGeolocationClient.mm:
226         (-[WebGeolocationPolicyListener allow]):
227         (-[WebGeolocationPolicyListener deny]):
228         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
229         * WebView/WebFrame.mm:
230         (-[WebFrame deviceOrientationChanged]):
231         * WebView/WebHTMLView.mm:
232         (hardwareKeyboardAvailabilityChangedCallback):
233         * WebView/WebView.mm:
234         (+[WebView _releaseMemoryNow]):
235         (+[WebView willEnterBackgroundWithCompletionHandler:]):
236         (-[WebView updateLayoutIgnorePendingStyleSheets]):
237         (-[WebView _dispatchUnloadEvent]):
238         (-[WebView _close]):
239         (-[WebView _preferencesChangedNotification:]):
240         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
241         (-[WebView goBack]):
242         (-[WebView goForward]):
243         (+[WebView _cacheModelChangedNotification:]):
244         (-[WebView stopLoading:]):
245         (-[WebView stopLoadingAndClear]):
246         (-[WebView reload:]):
247         (WebInstallMemoryPressureHandler):
248
249 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
250
251         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
252         https://bugs.webkit.org/show_bug.cgi?id=193706
253         <rdar://problem/44807048>
254
255         Reviewed by Ryosuke Niwa.
256
257         Use UndoStep::label().
258
259         * WebCoreSupport/WebEditorClient.h:
260         * WebCoreSupport/WebEditorClient.mm:
261         (-[WebUndoStep initWithUndoStep:]):
262         (+[WebUndoStep stepWithUndoStep:]):
263         (WebEditorClient::registerUndoOrRedoStep):
264         (WebEditorClient::registerUndoStep):
265         (WebEditorClient::registerRedoStep):
266
267 2019-01-22  Alex Christensen  <achristensen@webkit.org>
268
269         Move NetworkStorageSession ownership to NetworkProcess
270         https://bugs.webkit.org/show_bug.cgi?id=193580
271
272         Reviewed by Geoff Garen.
273
274         * Misc/WebCache.mm:
275         (+[WebCache clearCachedCredentials]):
276         * Misc/WebDownload.mm:
277         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
278         * Plugins/WebBaseNetscapePluginView.mm:
279         (WebKit::getAuthenticationInfo):
280         * WebCoreSupport/WebFrameNetworkingContext.mm:
281         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
282         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
283         (WebFrameNetworkingContext::storageSession const):
284         * WebView/WebPreferences.mm:
285         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
286         (+[WebPreferences _clearNetworkLoaderSession]):
287         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
288
289 2019-01-22  Daniel Bates  <dabates@apple.com>
290
291         [iOS] Interpret text key commands on keydown and app key commands on keypress
292         https://bugs.webkit.org/show_bug.cgi?id=192897
293         <rdar://problem/46857378>
294
295         Reviewed by Brent Fulgham.
296
297         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
298         is false) and keypress (isCharEvent is true), respectively.
299
300         * WebView/WebHTMLView.mm:
301         (-[WebHTMLView _handleEditingKeyEvent:]):
302
303 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
304
305         [css-logical] Implement flow-relative margin, padding and border shorthands
306         https://bugs.webkit.org/show_bug.cgi?id=188697
307
308         Reviewed by Simon Fraser and Antti Koivisto.
309
310         Add CSSLogicalEnabled runtime flag.
311
312         * WebView/WebPreferenceKeysPrivate.h:
313         * WebView/WebPreferences.mm:
314         (+[WebPreferences initialize]):
315         (-[WebPreferences cssLogicalEnabled]):
316         (-[WebPreferences setCSSLogicalEnabled:]):
317         * WebView/WebPreferencesPrivate.h:
318         * WebView/WebView.mm:
319         (-[WebView _preferencesChanged:]):
320
321 2019-01-15  Darin Adler  <darin@apple.com>
322
323         Use references rather than pointers for register/unregister functions, and more
324         https://bugs.webkit.org/show_bug.cgi?id=175028
325
326         Reviewed by Daniel Bates.
327
328         * WebCoreSupport/WebKitFullScreenListener.mm:
329         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
330         functions in Document; pass a reference.
331         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
332         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
333         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
334         * WebView/WebFullScreenController.mm:
335         (-[WebFullScreenController enterFullScreen:]): Ditto.
336         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
337         (-[WebFullScreenController exitFullScreen]): Ditto.
338         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
339         * WebView/WebFullScreenController.mm:
340         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
341
342 2019-01-12  Dan Bernstein  <mitz@apple.com>
343
344         [Cocoa] Avoid importing directly from subumbrella frameworks
345         https://bugs.webkit.org/show_bug.cgi?id=186016
346         <rdar://problem/40591038>
347
348         Reviewed by Sam Weinig.
349
350         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
351         * Carbon/CarbonWindowAdapter.mm: Ditto.
352         * Carbon/CarbonWindowFrame.m: Ditto.
353         * Carbon/HIViewAdapter.h: Ditto.
354         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
355           OTHER_CFLAGS_COCOA_TOUCH_NO.
356         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
357         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
358         * WebView/WebPDFView.h: Ditto.
359
360 2019-01-20  Antoine Quint  <graouts@apple.com>
361
362         Add a POINTER_EVENTS feature flag
363         https://bugs.webkit.org/show_bug.cgi?id=193577
364         <rdar://problem/47408511>
365
366         Unreviewed. Also enable Pointer Events for iosmac.
367
368         * Configurations/FeatureDefines.xcconfig:
369
370 2019-01-19  Antoine Quint  <graouts@apple.com>
371
372         Add a POINTER_EVENTS feature flag
373         https://bugs.webkit.org/show_bug.cgi?id=193577
374
375         Reviewed by Dean Jackson.
376
377         * Configurations/FeatureDefines.xcconfig:
378
379 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
380
381         Revert r238815, it broke WK1 video fullscreen on Mac
382         https://bugs.webkit.org/show_bug.cgi?id=193586
383         <rdar://problem/47358941>
384
385         Reviewed by Jer Noble.
386
387         * WebView/WebVideoFullscreenController.h: Added.
388         * WebView/WebVideoFullscreenController.mm: Added.
389         (SOFT_LINK_CLASS):
390         (-[WebVideoFullscreenController init]):
391         (-[WebVideoFullscreenController dealloc]):
392         (-[WebVideoFullscreenController fullscreenWindow]):
393         (-[WebVideoFullscreenController windowDidLoad]):
394         (-[WebVideoFullscreenController videoElement]):
395         (-[WebVideoFullscreenController setVideoElement:]):
396         (-[WebVideoFullscreenController clearFadeAnimation]):
397         (-[WebVideoFullscreenController windowDidExitFullscreen]):
398         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
399         (-[WebVideoFullscreenController videoElementRect]):
400         (-[WebVideoFullscreenController applicationDidResignActive:]):
401         (frameExpandedToRatioOfFrame):
402         (createBackgroundFullscreenWindow):
403         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
404         (-[WebVideoFullscreenController enterFullscreen:]):
405         (-[WebVideoFullscreenController exitFullscreen]):
406         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
407         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
408         (-[WebVideoFullscreenController _requestExit]):
409         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
410         (-[WebVideoFullscreenController requestExitFullscreen]):
411         (-[WebVideoFullscreenController fadeHUDIn]):
412         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
413         (-[WebVideoFullscreenController rateChanged:]):
414         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
415         (-[WebVideoFullscreenWindow dealloc]):
416         (-[WebVideoFullscreenWindow resignFirstResponder]):
417         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
418         (-[WebVideoFullscreenWindow mouseDown:]):
419         (-[WebVideoFullscreenWindow cancelOperation:]):
420         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
421         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
422         (-[WebVideoFullscreenWindow animationDidEnd:]):
423         (-[WebVideoFullscreenWindow mouseMoved:]):
424         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
425         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
426         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
427         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
428         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
429         (-[WebVideoFullscreenHUDWindow center]):
430         (-[WebVideoFullscreenHUDWindow keyDown:]):
431         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
432         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
433         (-[WebVideoFullscreenHUDWindowController init]):
434         (-[WebVideoFullscreenHUDWindowController dealloc]):
435         (-[WebVideoFullscreenHUDWindowController setArea:]):
436         (-[WebVideoFullscreenHUDWindowController keyDown:]):
437         (-[WebVideoFullscreenHUDWindowController delegate]):
438         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
439         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
440         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
441         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
442         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
443         (-[WebVideoFullscreenHUDWindowController closeWindow]):
444         (createMediaUIControl):
445         (createControlWithMediaUIControlType):
446         (createTimeTextField):
447         (createMediaUIBackgroundView):
448         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
449         (-[WebVideoFullscreenHUDWindowController updateVolume]):
450         (-[WebVideoFullscreenHUDWindowController updateTime]):
451         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
452         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
453         (-[WebVideoFullscreenHUDWindowController currentTime]):
454         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
455         (-[WebVideoFullscreenHUDWindowController duration]):
456         (-[WebVideoFullscreenHUDWindowController maxVolume]):
457         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
458         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
459         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
460         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
461         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
462         (-[WebVideoFullscreenHUDWindowController volume]):
463         (-[WebVideoFullscreenHUDWindowController setVolume:]):
464         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
465         (-[WebVideoFullscreenHUDWindowController updateRate]):
466         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
467         (-[WebVideoFullscreenHUDWindowController playing]):
468         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
469         (timeToString):
470         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
471         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
472         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
473         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
474         (-[WebVideoFullscreenHUDWindowController rewind:]):
475         (-[WebVideoFullscreenHUDWindowController fastForward:]):
476         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
477         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
478         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
479         * WebView/WebView.mm:
480         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
481         (-[WebView _exitVideoFullscreen]):
482
483 2019-01-18  Tim Horton  <timothy_horton@apple.com>
484
485         Get rid of ADVANCED_SPELL_CHECKING
486         https://bugs.webkit.org/show_bug.cgi?id=193592
487
488         Reviewed by Wenson Hsieh.
489
490         * WebCoreSupport/WebEditorClient.mm:
491         (insertionPointFromCurrentSelection):
492         (WebEditorClient::checkTextOfParagraph):
493         (WebEditorClient::getGuessesForWord):
494         (WebEditorClient::requestCandidatesForSelection):
495         (WebEditorClient::requestCheckingOfString):
496         * WebView/WebHTMLView.mm:
497         (-[WebHTMLView insertText:]):
498
499 2019-01-18  Jer Noble  <jer.noble@apple.com>
500
501         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
502         https://bugs.webkit.org/show_bug.cgi?id=189553
503
504         Reviewed by Tim Horton.
505
506         * Configurations/Base.xcconfig:
507         * Configurations/SDKVariant.xcconfig: Added.
508         * Configurations/WebKitLegacy.xcconfig:
509
510 2019-01-18  David Kilzer  <ddkilzer@apple.com>
511
512         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
513         <https://webkit.org/b/193568>
514         <rdar://problem/47381130>
515
516         Reviewed by Alex Christensen.
517
518         * WebView/WebView.mm:
519         - Remove unused soft-linking macros.
520         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
521         (-[WebUITextIndicatorData initWithImage:scale:]):
522         - Update to use exported PAL functions.
523
524 2019-01-17  Truitt Savell  <tsavell@apple.com>
525
526         Unreviewed, rolling out r240124.
527
528         This commit broke an internal build.
529
530         Reverted changeset:
531
532         "SDK_VARIANT build destinations should be separate from non-
533         SDK_VARIANT builds"
534         https://bugs.webkit.org/show_bug.cgi?id=189553
535         https://trac.webkit.org/changeset/240124
536
537 2019-01-17  Jer Noble  <jer.noble@apple.com>
538
539         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
540         https://bugs.webkit.org/show_bug.cgi?id=189553
541
542         Reviewed by Tim Horton.
543
544         * Configurations/Base.xcconfig:
545         * Configurations/SDKVariant.xcconfig: Added.
546         * Configurations/WebKitLegacy.xcconfig:
547
548 2019-01-17  Alex Christensen  <achristensen@webkit.org>
549
550         Stop using NetworkStorageSession::storageSession in WebCore
551         https://bugs.webkit.org/show_bug.cgi?id=193529
552
553         Reviewed by Tim Horton.
554
555         * Misc/WebCache.mm:
556         (+[WebCache addImageToCache:forURL:forFrame:]):
557         * WebView/WebView.mm:
558         (-[WebView _commonInitializationWithFrameName:groupName:]):
559         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
560
561 2019-01-15  Alex Christensen  <achristensen@webkit.org>
562
563         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
564         https://bugs.webkit.org/show_bug.cgi?id=193368
565
566         Reviewed by Geoff Garen.
567
568         * Misc/WebCache.mm:
569         (+[WebCache clearCachedCredentials]):
570         * Misc/WebDownload.mm:
571         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
572         * Plugins/WebBaseNetscapePluginView.mm:
573         (WebKit::getAuthenticationInfo):
574
575 2019-01-15  Alex Christensen  <achristensen@webkit.org>
576
577         Stop using CookiesStrategy
578         https://bugs.webkit.org/show_bug.cgi?id=161106
579
580         Reviewed by Don Olmstead and Antti Koivisto.
581
582         * Misc/WebCache.mm:
583         (+[WebCache addImageToCache:forURL:forFrame:]):
584         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
585         (WebKit::NetscapePluginInstanceProxy::getCookies):
586         (WebKit::NetscapePluginInstanceProxy::setCookies):
587         * Plugins/WebNetscapePluginView.mm:
588         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
589         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
590         * WebCoreSupport/WebPlatformStrategies.h:
591         * WebCoreSupport/WebPlatformStrategies.mm:
592         (WebPlatformStrategies::createCookiesStrategy): Deleted.
593         (WebPlatformStrategies::cookiesForDOM): Deleted.
594         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
595         (WebPlatformStrategies::cookiesEnabled): Deleted.
596         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
597         (WebPlatformStrategies::getRawCookies): Deleted.
598         (WebPlatformStrategies::deleteCookie): Deleted.
599         * WebView/WebView.mm:
600         (-[WebView _commonInitializationWithFrameName:groupName:]):
601         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
602
603 2019-01-15  Tim Horton  <timothy_horton@apple.com>
604
605         Cannot tab out of WKWebView on macOS
606         https://bugs.webkit.org/show_bug.cgi?id=161448
607         <rdar://problem/28100085>
608
609         Reviewed by Dean Jackson.
610
611         * WebCoreSupport/WebChromeClient.mm:
612         * WebView/WebView.mm:
613         Make use of SPI headers.
614
615 2019-01-14  Commit Queue  <commit-queue@webkit.org>
616
617         Unreviewed, rolling out r239901, r239909, r239910, r239912,
618         r239913, and r239914.
619         https://bugs.webkit.org/show_bug.cgi?id=193407
620
621         These revisions caused an internal failure (Requested by
622         Truitt on #webkit).
623
624         Reverted changesets:
625
626         "[Cocoa] Avoid importing directly from subumbrella frameworks"
627         https://bugs.webkit.org/show_bug.cgi?id=186016
628         https://trac.webkit.org/changeset/239901
629
630         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
631         https://trac.webkit.org/changeset/239909
632
633         "Tried to fix the build."
634         https://trac.webkit.org/changeset/239910
635
636         "Fixed iOS builds after r239910."
637         https://trac.webkit.org/changeset/239912
638
639         "More build fixing."
640         https://trac.webkit.org/changeset/239913
641
642         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
643         https://trac.webkit.org/changeset/239914
644
645 2019-01-14  Mark Lam  <mark.lam@apple.com>
646
647         Re-enable ability to build --cloop builds.
648         https://bugs.webkit.org/show_bug.cgi?id=192955
649         <rdar://problem/46882363>
650
651         Reviewed by Saam barati and Keith Miller.
652
653         * Configurations/FeatureDefines.xcconfig:
654
655 2019-01-13  Dan Bernstein  <mitz@apple.com>
656
657         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
658
659         Patch by Keith Rollin.
660
661         * WebView/PDFViewSPI.h:
662
663 2019-01-12  Timothy Hatcher  <timothy@apple.com>
664
665         Have prefers-color-scheme: light always match on macOS versions before Mojave.
666         https://bugs.webkit.org/show_bug.cgi?id=191655
667         rdar://problem/46074680
668
669         Reviewed by Megan Gardner.
670
671         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
672         * WebView/WebView.mm:
673         (-[WebView _effectiveAppearanceIsDark]):
674
675 2019-01-12  Dan Bernstein  <mitz@apple.com>
676
677         [Cocoa] Avoid importing directly from subumbrella frameworks
678         https://bugs.webkit.org/show_bug.cgi?id=186016
679         <rdar://problem/40591038>
680
681         Reviewed by Sam Weinig.
682
683         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
684         * Carbon/CarbonWindowAdapter.mm: Ditto.
685         * Carbon/CarbonWindowFrame.m: Ditto.
686         * Carbon/HIViewAdapter.h: Ditto.
687         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
688           OTHER_CFLAGS_COCOA_TOUCH_NO.
689         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
690         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
691         * WebView/WebPDFView.h: Ditto.
692
693 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
694
695         Enable visual viewport API by default
696         https://bugs.webkit.org/show_bug.cgi?id=193376
697
698         Reviewed by Simon Fraser.
699
700         * WebView/WebPreferences.mm:
701         (+[WebPreferences initialize]):
702
703 2019-01-11  John Wilander  <wilander@apple.com>
704
705         Compile out Web API Statistics Collection
706         https://bugs.webkit.org/show_bug.cgi?id=193370
707         <rdar://problem/45388584>
708
709         Reviewed by Brent Fulgham.
710
711         * Configurations/FeatureDefines.xcconfig:
712             Defined ENABLE_WEB_API_STATISTICS, off by default.
713
714 2019-01-08  Alex Christensen  <achristensen@webkit.org>
715
716         Stop using NetworkStorageSession in WebProcess
717         https://bugs.webkit.org/show_bug.cgi?id=193236
718
719         Reviewed by Don Olmstead.
720
721         * WebCoreSupport/WebFrameNetworkingContext.h:
722         * WebCoreSupport/WebFrameNetworkingContext.mm:
723         (WebFrameNetworkingContext::storageSession const):
724         * WebCoreSupport/WebPlatformStrategies.h:
725         * WebCoreSupport/WebPlatformStrategies.mm:
726         (WebPlatformStrategies::cookiesForDOM):
727         (WebPlatformStrategies::setCookiesFromDOM):
728         (WebPlatformStrategies::cookiesEnabled):
729         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
730         (WebPlatformStrategies::getRawCookies):
731         (WebPlatformStrategies::deleteCookie):
732         * WebView/WebView.mm:
733         (-[WebView _cachedResponseForURL:]):
734         (-[WebView _clearCredentials]):
735
736 2019-01-08  Alex Christensen  <achristensen@webkit.org>
737
738         Unreviewed, rolling out r239727.
739
740         Broke API tests
741
742         Reverted changeset:
743
744         "Stop using NetworkStorageSession in WebProcess"
745         https://bugs.webkit.org/show_bug.cgi?id=193236
746         https://trac.webkit.org/changeset/239727
747
748 2019-01-08  Alex Christensen  <achristensen@webkit.org>
749
750         Stop using NetworkStorageSession in WebProcess
751         https://bugs.webkit.org/show_bug.cgi?id=193236
752
753         Reviewed by Don Olmstead.
754
755         * WebCoreSupport/WebFrameNetworkingContext.h:
756         * WebCoreSupport/WebFrameNetworkingContext.mm:
757         (WebFrameNetworkingContext::storageSession const):
758         * WebView/WebView.mm:
759         (-[WebView _cachedResponseForURL:]):
760         (-[WebView _clearCredentials]):
761
762 2019-01-07  David Kilzer  <ddkilzer@apple.com>
763
764         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
765         <https://webkit.org/b/193056>
766
767         Reviewed by Alex Christensen.
768
769         * Plugins/Hosted/NetscapePluginHostProxy.h:
770         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
771         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
772         (WebKit::NetscapePluginInstanceProxy::enumerate):
773         (WebKit::NetscapePluginInstanceProxy::marshalValue):
774         (WebKit::NetscapePluginInstanceProxy::marshalValues):
775         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
776         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
777         * Plugins/Hosted/ProxyInstance.mm:
778         (WebKit::ProxyInstance::invoke):
779         * WebCoreSupport/WebGeolocationClient.mm:
780         * WebView/WebDataSource.mm:
781         (-[WebDataSource _receivedData:]):
782         * WebView/WebView.mm:
783         (-[WebView _cachedResponseForURL:]):
784         - Remove '*' from RetainPtr<> type.
785
786 2019-01-04  Alex Christensen  <achristensen@webkit.org>
787
788         Progress towards fixing Mac CMake build
789         https://bugs.webkit.org/show_bug.cgi?id=193105
790
791         Reviewed by Don Olmstead.
792
793         * WebKitPrefix.h:
794
795 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
796
797         Web Inspector: Use save sheet instead of dialog where possible
798         https://bugs.webkit.org/show_bug.cgi?id=193160
799         <rdar://problem/37399759>
800
801         Reviewed by Devin Rousso.
802
803         * WebCoreSupport/WebInspectorClient.mm:
804         (WebInspectorFrontendClient::save):
805
806 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
807
808         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
809         https://bugs.webkit.org/show_bug.cgi?id=193129
810
811         Reviewed by Tim Horton.
812
813         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
814
815         * WebCoreSupport/WebEditorClient.mm:
816         (WebEditorClient::registerUndoOrRedoStep):
817         (undoNameForEditAction): Deleted.
818
819 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
820
821         Add support for using the current text selection as the find string on iOS
822         https://bugs.webkit.org/show_bug.cgi?id=193034
823         <rdar://problem/45138739>
824
825         Reviewed by Tim Horton.
826
827         Add a method stub for WebKitLegacy.
828
829         * WebCoreSupport/WebEditorClient.h:
830
831 2019-01-01  Jeff Miller  <jeffm@apple.com>
832
833         Update user-visible copyright strings to include 2019
834         https://bugs.webkit.org/show_bug.cgi?id=192811
835
836         Reviewed by Mark Lam.
837
838         * Info.plist:
839
840 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
841
842         Use Ref<> as much as possible
843         https://bugs.webkit.org/show_bug.cgi?id=192808
844
845         Reviewed by Alex Christensen.
846
847         * DOM/DOM.mm:
848         (-[DOMNode getPreviewSnapshotImage:andRects:]):
849         * Plugins/Hosted/NetscapePluginHostManager.mm:
850         (WebKit::NetscapePluginHostManager::instantiatePlugin):
851         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
852         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
853         (WebKit::NetscapePluginInstanceProxy::loadRequest):
854         * Plugins/WebNetscapePluginView.mm:
855         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
856         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
857         * WebCoreSupport/WebContextMenuClient.mm:
858         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
859         * WebCoreSupport/WebFrameLoaderClient.mm:
860         (WebFrameLoaderClient::transitionToCommittedForNewPage):
861         * WebView/WebFrame.mm:
862         (-[WebFrame getDictationResultRanges:andMetadatas:]):
863         * WebView/WebHTMLView.mm:
864         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
865         * WebView/WebView.mm:
866         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
867         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
868
869 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
870
871         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
872         https://bugs.webkit.org/show_bug.cgi?id=192821
873
874         Reviewed by Chris Dumez.
875
876         When a window becomes occluded, the window server informs the application.
877         This should be used to suspend any work that is not visible by the user.
878
879         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
880         In some cases, that lead to performance impact (see radar).
881
882         This patch adds an observer for the occlusion notification. I tried to stick
883         with the same names used by WebKit2.
884
885         * WebView/WebView.mm:
886         (-[WebView _isViewVisible]):
887         (-[WebView addWindowObserversForWindow:]):
888         (-[WebView removeWindowObservers]):
889         (-[WebView _windowDidChangeOcclusionState:]):
890
891 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
892
893         [WebAuthN] Add a runtime flag for local authenticator
894         https://bugs.webkit.org/show_bug.cgi?id=192792
895         <rdar://problem/46798738>
896
897         Reviewed by Brent Fulgham.
898
899         * WebView/WebPreferenceKeysPrivate.h:
900         * WebView/WebPreferences.mm:
901         (+[WebPreferences initialize]):
902         (-[WebPreferences webAuthenticationEnabled]): Deleted.
903         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
904         * WebView/WebPreferencesPrivate.h:
905         * WebView/WebView.mm:
906         (-[WebView _preferencesChanged:]):
907
908 2018-12-20  Chris Dumez  <cdumez@apple.com>
909
910         Use Optional::valueOr() instead of Optional::value_or()
911         https://bugs.webkit.org/show_bug.cgi?id=192933
912
913         Reviewed by Geoffrey Garen.
914
915         * WebCoreSupport/WebSecurityOrigin.mm:
916         (-[WebSecurityOrigin port]):
917
918 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
919
920         Unreviewed, rolling out r239417.
921
922         Introduced two API test failures on macOS.
923
924         Reverted changeset:
925
926         "<rdar://problem/46194315> macOS: WebKit1 does not handle
927         occlusion changes"
928         https://bugs.webkit.org/show_bug.cgi?id=192821
929         https://trac.webkit.org/changeset/239417
930
931 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
932
933         WKWebView default UA doesn't freeze the build number
934         https://bugs.webkit.org/show_bug.cgi?id=192809
935         <rdar://problem/44687185>
936
937         Reviewed by Andy Estes.
938
939         Always reports the frozen build number.
940
941         * WebView/WebView.mm:
942         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
943         actual build number through this method call.
944         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
945
946 2018-12-19  Chris Dumez  <cdumez@apple.com>
947
948         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
949         https://bugs.webkit.org/show_bug.cgi?id=192728
950         <rdar://problem/46746779>
951
952         Reviewed by Geoff Garen.
953
954         * DOM/*:
955         * Plugins/*:
956         * WebCoreSupport/*:
957         * WebView/*:
958
959 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
960
961         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
962         https://bugs.webkit.org/show_bug.cgi?id=192821
963
964         Reviewed by Chris Dumez.
965
966         When a window becomes occluded, the window server informs the application.
967         This should be used to suspend any work that is not visible by the user.
968
969         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
970         In some cases, that lead to performance impact (see radar).
971
972         This patch adds an observer for the occlusion notification. I tried to stick
973         with the same names used by WebKit2.
974
975         * WebView/WebView.mm:
976         (-[WebView _isViewVisible]):
977         (-[WebView addWindowObserversForWindow:]):
978         (-[WebView removeWindowObservers]):
979         (-[WebView _windowDidChangeOcclusionState:]):
980
981 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
982
983         Allow clients to set the navigator platform
984         https://bugs.webkit.org/show_bug.cgi?id=192735
985
986         Reviewed by Tim Horton.
987
988         Add stubs to fill out the added functionality in FrameLoaderClient.
989
990         * WebCoreSupport/WebFrameLoaderClient.h:
991         * WebCoreSupport/WebFrameLoaderClient.mm:
992         (WebFrameLoaderClient::navigatorPlatform):
993
994 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
995
996         offsetLeft and offsetParent should adjust across shadow boundaries
997         https://bugs.webkit.org/show_bug.cgi?id=157437
998         <rdar://problem/26154021>
999
1000         Reviewed by Simon Fraser.
1001
1002         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1003
1004         * DOM/DOMElement.mm:
1005         (-[DOMElement offsetLeft]):
1006         (-[DOMElement offsetTop]):
1007         (-[DOMElement offsetParent]):
1008
1009 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1010
1011         Unreviewed build fix.
1012
1013         * WebView/WebFrame.mm:
1014         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1015
1016 2018-12-15  Darin Adler  <darin@apple.com>
1017
1018         Use warning-ignoring macros more consistently and simply
1019         https://bugs.webkit.org/show_bug.cgi?id=192743
1020
1021         Reviewed by Mark Lam.
1022
1023         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1024         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1025         compilers in Objective-C++ code.
1026
1027         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1028         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1029         accomodate non-clang compilers here. Also use #pragma once, add a missing
1030         "explicit" and fix conditionals.
1031
1032 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1033
1034         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1035         https://bugs.webkit.org/show_bug.cgi?id=192653
1036
1037         Reviewed by Wenson Hsieh.
1038
1039         * WebView/WebHTMLView.mm:
1040         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1041
1042 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1043
1044         Implement feature flag for CSS Typed OM
1045         https://bugs.webkit.org/show_bug.cgi?id=192610
1046
1047         Reviewed by Ryosuke Niwa.
1048
1049         * Configurations/FeatureDefines.xcconfig:
1050
1051 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1052
1053         WebCore shouldn't have a Objective-C class named NSCursor
1054         https://bugs.webkit.org/show_bug.cgi?id=192602
1055         <rdar://problem/46615532>
1056
1057         Reviewed by Wenson Hsieh.
1058
1059         * WebView/WebFrameView.mm:
1060         (-[WebFrameView keyDown:keyDown:]):
1061         * WebView/WebHTMLView.mm:
1062         (-[WebHTMLView keyDown:]):
1063         (-[WebHTMLView performKeyEquivalent:]):
1064         Only use NSCursor on macOS.
1065
1066 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1067
1068         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1069         https://bugs.webkit.org/show_bug.cgi?id=192573
1070
1071         Reviewed by Simon Fraser.
1072
1073         * Configurations/FeatureDefines.xcconfig:
1074
1075 2018-12-10  Antti Koivisto  <antti@apple.com>
1076
1077         Rename "forced style recalc" to "full style rebuild"
1078         https://bugs.webkit.org/show_bug.cgi?id=192572
1079
1080         Reviewed by Zalan Bujtas.
1081
1082         * WebView/WebHTMLView.mm:
1083         (-[WebHTMLView setNeedsToApplyStyles:]):
1084
1085 2018-12-10  Darin Adler  <darin@apple.com>
1086
1087         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1088         https://bugs.webkit.org/show_bug.cgi?id=192533
1089         rdar://problem/45732710
1090
1091         Reviewed by Anders Carlsson.
1092
1093         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1094         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1095
1096 2018-12-10  Darin Adler  <darin@apple.com>
1097
1098         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1099         https://bugs.webkit.org/show_bug.cgi?id=192532
1100         rdar://problem/45731047
1101
1102         Reviewed by Chris Dumez.
1103
1104         * Plugins/Hosted/NetscapePluginHostManager.mm:
1105         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1106         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1107         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1108
1109 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1110
1111         Turn WritingDirection into an enum class
1112         https://bugs.webkit.org/show_bug.cgi?id=192401
1113         Work towards <rdar://problem/42075638>
1114
1115         Reviewed by Dan Bernstein.
1116
1117         Change WritingDirection from an enum to an enum class. No change in behavior.
1118
1119         * WebView/WebHTMLView.mm:
1120         (-[WebHTMLView toggleBaseWritingDirection:]):
1121         (-[WebHTMLView changeBaseWritingDirection:]):
1122         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1123
1124 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1125
1126         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1127         https://bugs.webkit.org/show_bug.cgi?id=192272
1128
1129         Reviewed by Brady Eidson.
1130
1131         * WebCoreSupport/WebFrameLoaderClient.h:
1132         * WebCoreSupport/WebFrameLoaderClient.mm:
1133         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1134
1135 2018-12-03  Jer Noble  <jer.noble@apple.com>
1136
1137         Get rid of old, dead Mac video fullscreen code.
1138         https://bugs.webkit.org/show_bug.cgi?id=192315
1139
1140         Reviewed by Eric Carlson.
1141
1142         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1143         is no longer supported in the Mac port.
1144
1145         * WebView/WebVideoFullscreenController.h: Removed.
1146         * WebView/WebVideoFullscreenController.mm: Removed.
1147         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1148         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1149         * WebView/WebView.mm:
1150         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1151         (-[WebView _exitVideoFullscreen]):
1152
1153 2018-12-03  Daniel Bates  <dabates@apple.com>
1154
1155         [iOS] Do not handle key events that are key commands
1156         https://bugs.webkit.org/show_bug.cgi?id=191608
1157         <rdar://problem/46046013>
1158
1159         Reviewed by Ryosuke Niwa.
1160
1161         A key down event may be associated with a key command. If it is then we want to execute the
1162         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1163         event as a key command to find out.
1164
1165         * WebView/WebHTMLView.mm:
1166         (-[WebHTMLView _handleEditingKeyEvent:]):
1167
1168 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1169
1170         Add a runtime feature flag for LayoutFormattingContext.
1171         https://bugs.webkit.org/show_bug.cgi?id=192280
1172
1173         Reviewed by Simon Fraser.
1174
1175         * Configurations/FeatureDefines.xcconfig:
1176
1177 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1178
1179         Move URL from WebCore to WTF
1180         https://bugs.webkit.org/show_bug.cgi?id=190234
1181
1182         Reviewed by Keith Miller.
1183
1184         * DOM/DOMAttr.mm:
1185         * DOM/DOMBlob.mm:
1186         * DOM/DOMCSSCharsetRule.mm:
1187         * DOM/DOMCSSImportRule.mm:
1188         * DOM/DOMCSSMediaRule.mm:
1189         * DOM/DOMCSSPageRule.mm:
1190         * DOM/DOMCSSPrimitiveValue.mm:
1191         * DOM/DOMCSSRule.mm:
1192         * DOM/DOMCSSStyleDeclaration.mm:
1193         * DOM/DOMCSSStyleRule.mm:
1194         * DOM/DOMCSSStyleSheet.mm:
1195         * DOM/DOMCSSValue.mm:
1196         * DOM/DOMCharacterData.mm:
1197         * DOM/DOMCounter.mm:
1198         * DOM/DOMDocument.mm:
1199         * DOM/DOMDocumentFragment.mm:
1200         * DOM/DOMDocumentType.mm:
1201         * DOM/DOMEvent.mm:
1202         * DOM/DOMFile.mm:
1203         * DOM/DOMHTMLAnchorElement.mm:
1204         * DOM/DOMHTMLAppletElement.mm:
1205         * DOM/DOMHTMLAreaElement.mm:
1206         * DOM/DOMHTMLBRElement.mm:
1207         * DOM/DOMHTMLBaseElement.mm:
1208         * DOM/DOMHTMLBaseFontElement.mm:
1209         * DOM/DOMHTMLBodyElement.mm:
1210         * DOM/DOMHTMLButtonElement.mm:
1211         * DOM/DOMHTMLCanvasElement.mm:
1212         * DOM/DOMHTMLCollection.mm:
1213         * DOM/DOMHTMLDivElement.mm:
1214         * DOM/DOMHTMLDocument.mm:
1215         * DOM/DOMHTMLElement.mm:
1216         * DOM/DOMHTMLEmbedElement.mm:
1217         * DOM/DOMHTMLFieldSetElement.mm:
1218         * DOM/DOMHTMLFontElement.mm:
1219         * DOM/DOMHTMLFormElement.mm:
1220         * DOM/DOMHTMLFrameElement.mm:
1221         * DOM/DOMHTMLFrameSetElement.mm:
1222         * DOM/DOMHTMLHRElement.mm:
1223         * DOM/DOMHTMLHeadElement.mm:
1224         * DOM/DOMHTMLHeadingElement.mm:
1225         * DOM/DOMHTMLHtmlElement.mm:
1226         * DOM/DOMHTMLIFrameElement.mm:
1227         * DOM/DOMHTMLImageElement.mm:
1228         * DOM/DOMHTMLInputElement.mm:
1229         * DOM/DOMHTMLLIElement.mm:
1230         * DOM/DOMHTMLLabelElement.mm:
1231         * DOM/DOMHTMLLegendElement.mm:
1232         * DOM/DOMHTMLLinkElement.mm:
1233         * DOM/DOMHTMLMapElement.mm:
1234         * DOM/DOMHTMLMarqueeElement.mm:
1235         * DOM/DOMHTMLMediaElement.mm:
1236         * DOM/DOMHTMLMetaElement.mm:
1237         * DOM/DOMHTMLModElement.mm:
1238         * DOM/DOMHTMLOListElement.mm:
1239         * DOM/DOMHTMLObjectElement.mm:
1240         * DOM/DOMHTMLOptGroupElement.mm:
1241         * DOM/DOMHTMLOptionElement.mm:
1242         * DOM/DOMHTMLOptionsCollection.mm:
1243         * DOM/DOMHTMLParagraphElement.mm:
1244         * DOM/DOMHTMLParamElement.mm:
1245         * DOM/DOMHTMLQuoteElement.mm:
1246         * DOM/DOMHTMLScriptElement.mm:
1247         * DOM/DOMHTMLSelectElement.mm:
1248         * DOM/DOMHTMLStyleElement.mm:
1249         * DOM/DOMHTMLTableCaptionElement.mm:
1250         * DOM/DOMHTMLTableCellElement.mm:
1251         * DOM/DOMHTMLTableColElement.mm:
1252         * DOM/DOMHTMLTableElement.mm:
1253         * DOM/DOMHTMLTableRowElement.mm:
1254         * DOM/DOMHTMLTableSectionElement.mm:
1255         * DOM/DOMHTMLTitleElement.mm:
1256         * DOM/DOMHTMLUListElement.mm:
1257         * DOM/DOMHTMLVideoElement.mm:
1258         * DOM/DOMKeyboardEvent.mm:
1259         * DOM/DOMMediaList.mm:
1260         * DOM/DOMMouseEvent.mm:
1261         * DOM/DOMMutationEvent.mm:
1262         * DOM/DOMNamedNodeMap.mm:
1263         * DOM/DOMProcessingInstruction.mm:
1264         * DOM/DOMRange.mm:
1265         * DOM/DOMStyleSheet.mm:
1266         * DOM/DOMText.mm:
1267         * DOM/DOMTextEvent.mm:
1268         * DOM/DOMTokenList.mm:
1269         * DOM/DOMUIEvent.mm:
1270         * DOM/DOMXPathResult.mm:
1271         * History/WebHistoryItem.mm:
1272         * Misc/WebNSURLExtras.mm:
1273         (-[NSURL _web_userVisibleString]):
1274         (-[NSURL _web_URLByRemovingUserInfo]):
1275         (-[NSURL _web_dataForURLComponentType:]):
1276         (-[NSURL _web_schemeData]):
1277         (-[NSURL _web_hostData]):
1278         * Misc/WebUserContentURLPattern.mm:
1279         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1280         * Plugins/WebNetscapePluginStream.h:
1281         (WebNetscapePluginStream::setRequestURL):
1282         * WebCoreSupport/WebChromeClient.h:
1283         * WebCoreSupport/WebChromeClient.mm:
1284         (WebChromeClient::signedPublicKeyAndChallengeString const):
1285         * WebCoreSupport/WebContextMenuClient.h:
1286         * WebCoreSupport/WebContextMenuClient.mm:
1287         * WebCoreSupport/WebDragClient.h:
1288         * WebCoreSupport/WebFrameLoaderClient.h:
1289         * WebCoreSupport/WebFrameLoaderClient.mm:
1290         (WebFrameLoaderClient::updateGlobalHistory):
1291         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1292         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1293         (WebPaymentCoordinatorClient::showPaymentUI):
1294         * WebCoreSupport/WebPlatformStrategies.h:
1295         * WebCoreSupport/WebPlatformStrategies.mm:
1296         (WebPlatformStrategies::readURLFromPasteboard):
1297         * WebCoreSupport/WebPluginInfoProvider.h:
1298         * WebCoreSupport/WebPluginInfoProvider.mm:
1299         (WebPluginInfoProvider::webVisiblePluginInfo):
1300         * WebCoreSupport/WebSecurityOrigin.mm:
1301         * WebCoreSupport/WebVisitedLinkStore.h:
1302         * WebView/WebDataSource.mm:
1303         * WebView/WebFrame.mm:
1304         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1305         * WebView/WebImmediateActionController.mm:
1306         (-[WebImmediateActionController _defaultAnimationController]):
1307         * WebView/WebPDFView.mm:
1308         * WebView/WebScriptDebugger.mm:
1309         * WebView/WebViewInternal.h:
1310
1311 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1312
1313         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1314         https://bugs.webkit.org/show_bug.cgi?id=192197
1315
1316         Reviewed by Jiewen Tan.
1317
1318         * Configurations/FeatureDefines.xcconfig:
1319         * WebCoreSupport/WebChromeClient.h:
1320         * WebCoreSupport/WebChromeClient.mm:
1321
1322 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1323
1324         Remove dead code from an earlier attempt at implementing safe browsing
1325         https://bugs.webkit.org/show_bug.cgi?id=192067
1326
1327         Reviewed by Chris Dumez.
1328
1329         * WebCoreSupport/WebFrameLoaderClient.h:
1330         * WebCoreSupport/WebFrameLoaderClient.mm:
1331         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1332
1333 2018-11-27  Mark Lam  <mark.lam@apple.com>
1334
1335         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1336         https://bugs.webkit.org/show_bug.cgi?id=192055
1337         <rdar://problem/46288783>
1338
1339         Reviewed by Saam Barati.
1340
1341         * Configurations/FeatureDefines.xcconfig:
1342
1343 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1344
1345         Make it possible to insert editable images with a gesture
1346         https://bugs.webkit.org/show_bug.cgi?id=191937
1347
1348         Reviewed by Wenson Hsieh.
1349
1350         * WebCoreSupport/WebEditorClient.mm:
1351         (undoNameForEditAction):
1352         Add a undo name.
1353
1354 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1355
1356         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1357         https://bugs.webkit.org/show_bug.cgi?id=191945
1358
1359         Reviewed by Anders Carlsson.
1360
1361         * WebCoreSupport/WebEditorClient.mm:
1362         (undoNameForEditAction):
1363
1364 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1365
1366         Enable drag and drop support for iOSMac
1367         https://bugs.webkit.org/show_bug.cgi?id=191818
1368         <rdar://problem/43907454>
1369
1370         Reviewed by Dean Jackson.
1371
1372         * Configurations/FeatureDefines.xcconfig:
1373
1374 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1375
1376         Address post-review feedback after r238438
1377         https://bugs.webkit.org/show_bug.cgi?id=191913
1378
1379         Reviewed by Ryosuke Niwa.
1380
1381         * WebView/WebFrame.mm:
1382         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1383         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1384         * WebView/WebView.mm:
1385         (-[WebView setSelectedDOMRange:affinity:]):
1386
1387 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1388
1389         Web Inspector: "Reload Web Inspector" button no longer partially works
1390         https://bugs.webkit.org/show_bug.cgi?id=191773
1391         <rdar://problem/46139932>
1392
1393         Reviewed by Devin Rousso.
1394
1395         * WebCoreSupport/WebInspectorClient.h:
1396         * WebCoreSupport/WebInspectorClient.mm:
1397         (WebInspectorFrontendClient::reopen):
1398
1399 2018-11-17  Devin Rousso  <drousso@apple.com>
1400
1401         Web Inspector: Network: add button to show system certificate dialog
1402         https://bugs.webkit.org/show_bug.cgi?id=191458
1403         <rdar://problem/45977019>
1404
1405         Reviewed by Joseph Pecoraro.
1406
1407         * WebCoreSupport/WebInspectorClient.h:
1408         * WebCoreSupport/WebInspectorClient.mm:
1409         (WebInspectorFrontendClient::showCertificate): Added.
1410
1411         * Configurations/WebKitLegacy.xcconfig:
1412
1413 2018-11-15  Truitt Savell  <tsavell@apple.com>
1414
1415         Unreviewed, rolling out r238244.
1416
1417         Caused High Sierra test runs to fail early with 50 crashes and
1418         casued 25 API failures.
1419
1420         Reverted changeset:
1421
1422         "[css-logical] Implement flow-relative margin, padding and
1423         border shorthands"
1424         https://bugs.webkit.org/show_bug.cgi?id=188697
1425         https://trac.webkit.org/changeset/238244
1426
1427 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1428
1429         [css-logical] Implement flow-relative margin, padding and border shorthands
1430         https://bugs.webkit.org/show_bug.cgi?id=188697
1431
1432         Reviewed by Simon Fraser and Antti Koivisto.
1433
1434         Add CSSLogicalEnabled runtime flag.
1435
1436         * WebView/WebPreferenceKeysPrivate.h:
1437         * WebView/WebPreferences.mm:
1438         (+[WebPreferences initialize]):
1439         (-[WebPreferences cssLogicalEnabled]):
1440         (-[WebPreferences setCSSLogicalEnabled:]):
1441         * WebView/WebPreferencesPrivate.h:
1442         * WebView/WebView.mm:
1443         (-[WebView _preferencesChanged:]):
1444
1445 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1446
1447         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1448         https://bugs.webkit.org/show_bug.cgi?id=191612
1449
1450         Reviewed by Matt Baker.
1451
1452         * WebCoreSupport/WebInspectorClient.mm:
1453         (-[WebInspectorWindowController destroyInspectorView]):
1454
1455 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1456
1457         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1458         https://bugs.webkit.org/show_bug.cgi?id=191494
1459         <rdar://problem/45469854>
1460
1461         Reviewed by Devin Rousso.
1462
1463         * WebCoreSupport/WebInspectorClient.h:
1464         WebKitLegacy will still have remote inspection of the Page directly.
1465
1466 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1467
1468         Make compositing updates incremental
1469         https://bugs.webkit.org/show_bug.cgi?id=90342
1470
1471         Reviewed by Antti Koivisto.
1472
1473         Fix spelling error.
1474
1475         * WebView/WebView.mm:
1476         (-[WebView _setMediaLayer:forPluginView:]):
1477
1478 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1479
1480         Implement a new edit command to change the enclosing list type
1481         https://bugs.webkit.org/show_bug.cgi?id=191487
1482         <rdar://problem/45955922>
1483
1484         Reviewed by Ryosuke Niwa.
1485
1486         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1487
1488         * WebCoreSupport/WebEditorClient.mm:
1489         (undoNameForEditAction):
1490
1491 2018-11-11  Daniel Bates  <dabates@apple.com>
1492
1493         [iOS] Draw caps lock indicator in password fields
1494         https://bugs.webkit.org/show_bug.cgi?id=190565
1495         <rdar://problem/45262343>
1496
1497         Reviewed by Dean Jackson.
1498
1499         Update the caps lock state when a hardware keyboard is attached or detached.
1500
1501         * WebView/WebHTMLView.mm:
1502         (hardwareKeyboardAvailabilityChangedCallback): Added.
1503         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1504         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1505
1506 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1507
1508         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1509         https://bugs.webkit.org/show_bug.cgi?id=191492
1510
1511         Reviewed by Alex Christensen.
1512
1513         * Carbon/HIWebView.mm:
1514         * Misc/WebNSFileManagerExtras.mm:
1515         * Misc/WebNSURLExtras.mm:
1516         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1517         * Plugins/WebBasePluginPackage.mm:
1518         * Plugins/WebPluginContainerCheck.mm:
1519         * WebCoreSupport/WebCachedFramePlatformData.h:
1520         * WebCoreSupport/WebDeviceOrientationClient.mm:
1521         * WebView/WebDelegateImplementationCaching.mm:
1522         * WebView/WebHTMLView.mm:
1523         * WebView/WebPDFRepresentation.mm:
1524         * WebView/WebPolicyDelegate.mm:
1525         * WebView/WebView.mm:
1526
1527 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1528
1529         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1530         https://bugs.webkit.org/show_bug.cgi?id=191492
1531
1532         Reviewed by Alex Christensen.
1533
1534         * Carbon/HIWebView.mm:
1535         (UpdateCommandStatus):
1536         * Misc/WebNSFileManagerExtras.mm:
1537         * Misc/WebNSURLExtras.mm:
1538         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1539         * Plugins/WebBasePluginPackage.mm:
1540         * Plugins/WebPluginContainerCheck.mm:
1541         (-[WebPluginContainerCheck _continueWithPolicy:]):
1542         * WebCoreSupport/WebCachedFramePlatformData.h:
1543         (WebCachedFramePlatformData::clear):
1544         * WebCoreSupport/WebDeviceOrientationClient.mm:
1545         (WebDeviceOrientationClient::getProvider const):
1546         * WebView/WebDelegateImplementationCaching.mm:
1547         (CallDelegate):
1548         (CallDelegateReturningBoolean):
1549         (CallResourceLoadDelegateReturningBoolean):
1550         (CallFormDelegate):
1551         (CallFormDelegateReturningBoolean):
1552         * WebView/WebHTMLView.mm:
1553         * WebView/WebPDFRepresentation.mm:
1554         * WebView/WebPolicyDelegate.mm:
1555         (-[WebPolicyDecisionListener _usePolicy:]):
1556         * WebView/WebView.mm:
1557
1558 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1559
1560         Unreviewed, rolling out r238047.
1561
1562         Introduced layout test failures on iOS simulator.
1563
1564         Reverted changeset:
1565
1566         "[iOS] Draw caps lock indicator in password fields"
1567         https://bugs.webkit.org/show_bug.cgi?id=190565
1568         https://trac.webkit.org/changeset/238047
1569
1570 2018-11-09  Antti Koivisto  <antti@apple.com>
1571
1572         Use OptionSet for layout milestones
1573         https://bugs.webkit.org/show_bug.cgi?id=191470
1574
1575         Reviewed by Dean Jackson.
1576
1577         * WebCoreSupport/WebFrameLoaderClient.h:
1578         * WebCoreSupport/WebFrameLoaderClient.mm:
1579         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1580         * WebView/WebView.mm:
1581         (coreLayoutMilestones):
1582         (kitLayoutMilestones):
1583         (-[WebView _cacheFrameLoadDelegateImplementations]):
1584         * WebView/WebViewInternal.h:
1585
1586 2018-11-09  Daniel Bates  <dabates@apple.com>
1587
1588         [iOS] Draw caps lock indicator in password fields
1589         https://bugs.webkit.org/show_bug.cgi?id=190565
1590         <rdar://problem/45262343>
1591
1592         Reviewed by Dean Jackson.
1593
1594         Update the caps lock state when a hardware keyboard is attached or detached.
1595
1596         * WebView/WebHTMLView.mm:
1597         (hardwareKeyboardAvailabilityChangedCallback): Added.
1598         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1599         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1600
1601 2018-11-09  Daniel Bates  <dabates@apple.com>
1602
1603         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1604         action when forward delete is pressed outside a text field
1605         https://bugs.webkit.org/show_bug.cgi?id=190566
1606         <rdar://problem/45262367>
1607
1608         Reviewed by Wenson Hsieh.
1609
1610         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1611         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1612         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1613
1614         * WebView/WebHTMLView.mm:
1615         (-[WebHTMLView _handleEditingKeyEvent:]):
1616
1617 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1618
1619         Adopt Reveal Framework to replace Lookup
1620         https://bugs.webkit.org/show_bug.cgi?id=191097
1621         <rdar://problem/45924508>
1622
1623         Reviewed by Tim Horton.
1624
1625         Pass in what it needed to clear the textIndicators. This is better than
1626         the current notification structure.
1627
1628         * WebView/WebView.mm:
1629         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1630         (-[WebView _prepareForDictionaryLookup]):
1631
1632 2018-11-06  Justin Fan  <justin_fan@apple.com>
1633
1634         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1635         https://bugs.webkit.org/show_bug.cgi?id=191291
1636
1637         Reviewed by Myles Maxfield.
1638
1639         Properly disable WEBGPU on all non-Metal platforms for now.
1640
1641         * Configurations/FeatureDefines.xcconfig:
1642
1643 2018-11-02  Daniel Bates  <dabates@apple.com>
1644
1645         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1646         https://bugs.webkit.org/show_bug.cgi?id=190487
1647
1648         Reviewed by Tim Horton.
1649
1650         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1651         allow the default handling.
1652
1653         * WebView/WebHTMLView.mm:
1654         (-[WebHTMLView _handleEditingKeyEvent:]):
1655
1656 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1657
1658         Add a storage limit for IndexedDB
1659         https://bugs.webkit.org/show_bug.cgi?id=190598
1660         <rdar://problem/44654715>
1661
1662         Reviewed by Chris Dumez.
1663
1664         * Storage/WebDatabaseManager.mm:
1665         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1666         * Storage/WebDatabaseManagerPrivate.h:
1667
1668 2018-10-31  Antti Koivisto  <antti@apple.com>
1669
1670         Remove LayerFlushScheduler
1671         https://bugs.webkit.org/show_bug.cgi?id=191103
1672
1673         Reviewed by Anders Carlsson.
1674
1675         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1676         all the virtual cruft.
1677
1678         * WebView/WebViewData.h:
1679         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1680         (): Deleted.
1681         * WebView/WebViewData.mm:
1682         (currentRunLoop):
1683         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1684         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1685         (WebViewLayerFlushScheduler::schedule):
1686         (WebViewLayerFlushScheduler::invalidate):
1687         (WebViewLayerFlushScheduler::layerFlushCallback):
1688
1689 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1690
1691         Enable InstallAPI for iOS unconditionally
1692         https://bugs.webkit.org/show_bug.cgi?id=191043
1693         rdar://problem/32728423
1694
1695         Reviewed by Dan Bernstein.
1696
1697         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1698         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1699         shouldn't be processed by InstallAPI.
1700         * MigrateHeaders.make: Removed an obsolete workaround.
1701         * Misc/NSURLDownloadSPI.h: Added.
1702         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1703
1704 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1705
1706         Clean up some obsolete MAX_ALLOWED macros
1707         https://bugs.webkit.org/show_bug.cgi?id=190916
1708
1709         Reviewed by Tim Horton.
1710
1711         * WebView/WebHTMLView.mm:
1712         (-[WebHTMLView pressureChangeWithEvent:]):
1713         * WebView/WebPDFView.h:
1714
1715 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1716
1717         Unreviewed, rolling out r237600 and r237604.
1718         https://bugs.webkit.org/show_bug.cgi?id=191086
1719
1720         Breaks internal iOS builds (Requested by ryanhadd_ on
1721         #webkit).
1722
1723         Reverted changesets:
1724
1725         "Enable InstallAPI for iOS unconditionally"
1726         https://bugs.webkit.org/show_bug.cgi?id=191043
1727         https://trac.webkit.org/changeset/237600
1728
1729         "Build fix attempt after enabling InstallAPI for iOS."
1730         https://bugs.webkit.org/show_bug.cgi?id=191043
1731         https://trac.webkit.org/changeset/237604
1732
1733 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1734
1735         Enable InstallAPI for iOS unconditionally
1736         https://bugs.webkit.org/show_bug.cgi?id=191043
1737         rdar://problem/32728423
1738
1739         Reviewed by Dan Bernstein.
1740
1741         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1742         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1743         shouldn't be processed by InstallAPI.
1744         * MigrateHeaders.make: Removed an obsolete workaround.
1745         * Misc/NSURLDownloadSPI.h: Added.
1746         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1747
1748 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1749
1750         Modernize WebKit nibs and lprojs for localization's sake
1751         https://bugs.webkit.org/show_bug.cgi?id=190911
1752         <rdar://problem/45349466>
1753
1754         Reviewed by Dan Bernstein.
1755
1756         * Misc/WebNSControlExtras.m:
1757         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1758         NSWindow and its contents are both in the same scale space these days; avoid
1759         double-applying the scale factor, or you can't see the prompt.
1760
1761         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1762         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1763         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1764         NIB->XIB
1765
1766 2018-10-25  Antoine Quint  <graouts@apple.com>
1767
1768         [Web Animations] Turn Web Animations CSS Integration off by default
1769         https://bugs.webkit.org/show_bug.cgi?id=190901
1770
1771         Reviewed by Dean Jackson.
1772
1773         * WebView/WebPreferences.mm:
1774         (+[WebPreferences initialize]):
1775
1776 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1777
1778         Clean up some obsolete macOS version guards
1779         https://bugs.webkit.org/show_bug.cgi?id=190887
1780
1781         Reviewed by Dan Bernstein.
1782
1783         * Misc/WebNSPasteboardExtras.mm:
1784         (+[NSPasteboard _web_dragTypesForURL]):
1785         * WebCoreSupport/PopupMenuMac.mm:
1786         (PopupMenuMac::show):
1787         * WebCoreSupport/WebEditorClient.h:
1788         * WebCoreSupport/WebEditorClient.mm:
1789         (WebEditorClient::respondToChangedSelection):
1790         * WebView/WebPDFView.mm:
1791         (-[WebPDFView _clipViewForPDFDocumentView]):
1792
1793 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1794
1795         Turn on Conic Gradients
1796         https://bugs.webkit.org/show_bug.cgi?id=190810
1797
1798         Reviewed by Tim Horton.
1799
1800         * Configurations/FeatureDefines.xcconfig:
1801
1802 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1803
1804         Cleanup: MIMETypeRegistry functions
1805         https://bugs.webkit.org/show_bug.cgi?id=190838
1806
1807         Reviewed by Simon Fraser.
1808
1809         * Misc/WebNSPasteboardExtras.mm:
1810         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1811         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1812         because they were identical.
1813
1814         * WebView/WebHTMLRepresentation.mm:
1815         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1816         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1817         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1818         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1819         * WebView/WebView.mm:
1820         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1821         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1822         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1823
1824 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1825
1826         Fix false positive leaks when using custom -init methods that don't start with -init
1827         <https://webkit.org/b/190818>
1828         <rdar://problem/45476042>
1829
1830         Reviewed by Dan Bernstein.
1831
1832         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1833         it is accessible by both categories.
1834         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1835         NSError (WebKitInternal) category.  Add attribute to make this
1836         behave like an -init method.
1837         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1838         NSError (WebKitInternal) category.  Modernize method.  Replace
1839         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1840
1841 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1842
1843         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1844         https://bugs.webkit.org/show_bug.cgi?id=190729
1845
1846         Reviewed by Tim Horton.
1847
1848         * DOM/DOM.mm:
1849         (-[DOMNode boundingBox]):
1850         * DOM/DOMElement.mm:
1851         * DOM/DOMHTML.mm:
1852         * DOM/DOMInternal.mm:
1853         * DOM/DOMUIKitExtensions.mm:
1854         * DOM/WebDOMOperations.mm:
1855         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1856         * DefaultDelegates/WebDefaultEditingDelegate.m:
1857         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1858         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1859         * DefaultDelegates/WebDefaultUIDelegate.h:
1860         * DefaultDelegates/WebDefaultUIDelegate.mm:
1861         (-[WebDefaultUIDelegate webViewClose:]):
1862         (-[WebDefaultUIDelegate webViewFocus:]):
1863         (-[WebDefaultUIDelegate webViewUnfocus:]):
1864         (-[WebDefaultUIDelegate webViewIsResizable:]):
1865         (-[WebDefaultUIDelegate webView:setResizable:]):
1866         (-[WebDefaultUIDelegate webView:setFrame:]):
1867         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1868         * History/BackForwardList.h:
1869         * History/BackForwardList.mm:
1870         * History/WebBackForwardList.mm:
1871         (+[WebBackForwardList initialize]):
1872         (bumperCarBackForwardHackNeeded):
1873         * History/WebHistory.mm:
1874         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1875         (-[WebHistory _sendNotification:entries:]):
1876         (-[WebHistory loadFromURL:error:]):
1877         (-[WebHistory saveToURL:error:]):
1878         * History/WebHistoryItem.mm:
1879         (WKNotifyHistoryItemChanged):
1880         (+[WebHistoryItem initialize]):
1881         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1882         * History/WebURLsWithTitles.m:
1883         * Misc/WebCache.mm:
1884         (+[WebCache initialize]):
1885         * Misc/WebDownload.mm:
1886         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1887         * Misc/WebElementDictionary.mm:
1888         (+[WebElementDictionary initialize]):
1889         (+[WebElementDictionary initializeLookupTable]):
1890         * Misc/WebIconDatabase.mm:
1891         * Misc/WebKitNSStringExtras.mm:
1892         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1893         * Misc/WebKitVersionChecks.h:
1894         * Misc/WebKitVersionChecks.mm:
1895         (WebKitLinkedOnOrAfter):
1896         (WebKitLinkTimeVersion):
1897         * Misc/WebLocalizableStrings.mm:
1898         * Misc/WebNSControlExtras.h:
1899         * Misc/WebNSControlExtras.m:
1900         * Misc/WebNSEventExtras.m:
1901         * Misc/WebNSFileManagerExtras.mm:
1902         * Misc/WebNSImageExtras.h:
1903         * Misc/WebNSImageExtras.m:
1904         * Misc/WebNSPasteboardExtras.mm:
1905         * Misc/WebNSPrintOperationExtras.h:
1906         * Misc/WebNSPrintOperationExtras.m:
1907         * Misc/WebNSViewExtras.m:
1908         * Misc/WebNSWindowExtras.m:
1909         * Panels/WebAuthenticationPanel.h:
1910         * Panels/WebAuthenticationPanel.m:
1911         * Panels/WebPanelAuthenticationHandler.m:
1912         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1913         (+[WebHostedNetscapePluginView initialize]):
1914         * Plugins/WebBasePluginPackage.h:
1915         * Plugins/WebBasePluginPackage.mm:
1916         * Plugins/WebJavaPlugIn.h:
1917         * Plugins/WebPluginContainerCheck.mm:
1918         * Plugins/WebPluginController.h:
1919         * Plugins/WebPluginController.mm:
1920         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1921         (-[WebPluginController addPlugin:]):
1922         (-[WebPluginController destroyPlugin:]):
1923         (-[WebPluginController destroyAllPlugins]):
1924         * Plugins/WebPluginDatabase.mm:
1925         (+[WebPluginDatabase _defaultPlugInPaths]):
1926         * Plugins/WebPluginPackage.mm:
1927         (-[WebPluginPackage initWithPath:]):
1928         * Storage/WebDatabaseManager.mm:
1929         (-[WebDatabaseManager deleteAllDatabases]):
1930         * Storage/WebDatabaseManagerClient.h:
1931         * Storage/WebDatabaseManagerClient.mm:
1932         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1933         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1934         * Storage/WebStorageManager.mm:
1935         (-[WebStorageManager deleteAllOrigins]):
1936         (WebKitInitializeStorageIfNecessary):
1937         * WebCoreSupport/WebAlternativeTextClient.h:
1938         * WebCoreSupport/WebApplicationCache.mm:
1939         (applicationCacheBundleIdentifier):
1940         * WebCoreSupport/WebChromeClient.h:
1941         * WebCoreSupport/WebChromeClient.mm:
1942         (WebChromeClient::setWindowRect):
1943         (WebChromeClient::windowRect):
1944         (WebChromeClient::takeFocus):
1945         (WebChromeClient::addMessageToConsole):
1946         (WebChromeClient::enableSuddenTermination):
1947         (WebChromeClient::disableSuddenTermination):
1948         (WebChromeClient::createPopupMenu const):
1949         (WebChromeClient::createSearchPopupMenu const):
1950         (WebChromeClient::shouldPaintEntireContents const):
1951         (WebChromeClient::supportsVideoFullscreen):
1952         (WebChromeClient::supportsFullScreenForElement):
1953         (WebChromeClient::enterFullScreenForElement):
1954         (WebChromeClient::exitFullScreenForElement):
1955         * WebCoreSupport/WebContextMenuClient.mm:
1956         * WebCoreSupport/WebDragClient.mm:
1957         * WebCoreSupport/WebEditorClient.h:
1958         * WebCoreSupport/WebEditorClient.mm:
1959         (+[WebUndoStep initialize]):
1960         (updateFontPanel):
1961         (WebEditorClient::didBeginEditing):
1962         (WebEditorClient::respondToChangedContents):
1963         (WebEditorClient::respondToChangedSelection):
1964         (WebEditorClient::canceledComposition):
1965         (WebEditorClient::didEndEditing):
1966         (WebEditorClient::didWriteSelectionToPasteboard):
1967         (attributesForAttributedStringConversion):
1968         (WebEditorClient::setInsertionPasteboard):
1969         (WebEditorClient::registerUndoOrRedoStep):
1970         (WebEditorClient::handleKeyboardEvent):
1971         (WebEditorClient::handleInputMethodKeydown):
1972         (WebEditorClient::textDidChangeInTextField):
1973         (WebEditorClient::requestCheckingOfString):
1974         * WebCoreSupport/WebFrameLoaderClient.h:
1975         * WebCoreSupport/WebFrameLoaderClient.mm:
1976         (WebFrameLoaderClient::detachedFromParent2):
1977         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1978         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1979         (WebFrameLoaderClient::dispatchWillSendRequest):
1980         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1981         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1982         (WebFrameLoaderClient::willCacheResponse const):
1983         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1984         (WebFrameLoaderClient::dispatchDidFinishLoading):
1985         (WebFrameLoaderClient::dispatchDidFailLoading):
1986         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1987         (WebFrameLoaderClient::dispatchWillClose):
1988         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1989         (WebFrameLoaderClient::dispatchDidCommitLoad):
1990         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1991         (WebFrameLoaderClient::dispatchDidFailLoad):
1992         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1993         (WebFrameLoaderClient::dispatchDidFinishLoad):
1994         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1995         (WebFrameLoaderClient::willChangeTitle):
1996         (WebFrameLoaderClient::didChangeTitle):
1997         (WebFrameLoaderClient::didReplaceMultipartContent):
1998         (WebFrameLoaderClient::updateGlobalHistory):
1999         (WebFrameLoaderClient::saveViewStateToItem):
2000         (WebFrameLoaderClient::restoreViewState):
2001         (WebFrameLoaderClient::provisionalLoadStarted):
2002         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2003         (WebFrameLoaderClient::setTitle):
2004         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2005         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2006         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2007         (WebFrameLoaderClient::didRestoreFromPageCache):
2008         (WebFrameLoaderClient::actionDictionary const):
2009         (WebFrameLoaderClient::createPlugin):
2010         (WebFrameLoaderClient::getLoadDecisionForIcons):
2011         (WebFrameLoaderClient::finishedLoadingIcon):
2012         (+[WebFramePolicyListener initialize]):
2013         * WebCoreSupport/WebFrameNetworkingContext.mm:
2014         * WebCoreSupport/WebGeolocationClient.h:
2015         * WebCoreSupport/WebGeolocationClient.mm:
2016         (WebGeolocationClient::requestPermission):
2017         * WebCoreSupport/WebInspectorClient.h:
2018         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2019         * WebCoreSupport/WebNotificationClient.mm:
2020         * WebCoreSupport/WebOpenPanelResultListener.mm:
2021         * WebCoreSupport/WebPlatformStrategies.h:
2022         * WebCoreSupport/WebPlatformStrategies.mm:
2023         * WebCoreSupport/WebProgressTrackerClient.h:
2024         * WebCoreSupport/WebProgressTrackerClient.mm:
2025         (WebProgressTrackerClient::progressStarted):
2026         (WebProgressTrackerClient::progressEstimateChanged):
2027         (WebProgressTrackerClient::progressFinished):
2028         * WebCoreSupport/WebSecurityOrigin.mm:
2029         * WebInspector/WebNodeHighlight.h:
2030         * WebInspector/WebNodeHighlight.mm:
2031         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2032         (-[WebNodeHighlight dealloc]):
2033         (-[WebNodeHighlight attach]):
2034         * WebInspector/WebNodeHighlightView.h:
2035         * WebInspector/WebNodeHighlightView.mm:
2036         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2037         (-[WebNodeHighlightView dealloc]):
2038         * WebInspector/WebNodeHighlighter.mm:
2039         (-[WebNodeHighlighter highlight]):
2040         * WebView/WebArchive.mm:
2041         (+[WebArchivePrivate initialize]):
2042         * WebView/WebClipView.h:
2043         * WebView/WebDataSource.mm:
2044         (WebDataSourcePrivate::WebDataSourcePrivate):
2045         (+[WebDataSource initialize]):
2046         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2047         (-[WebDataSource _makeRepresentation]):
2048         * WebView/WebDelegateImplementationCaching.h:
2049         * WebView/WebDelegateImplementationCaching.mm:
2050         (CallDelegate):
2051         (CallDelegateReturningFloat):
2052         (CallDelegateReturningBoolean):
2053         (CallUIDelegate):
2054         (CallUIDelegateReturningFloat):
2055         (CallUIDelegateReturningBoolean):
2056         (CallFrameLoadDelegate):
2057         (CallFrameLoadDelegateReturningBoolean):
2058         (CallResourceLoadDelegate):
2059         (CallScriptDebugDelegate):
2060         (CallFormDelegate):
2061         (CallFormDelegateReturningBoolean):
2062         * WebView/WebDeviceOrientation.mm:
2063         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2064         * WebView/WebDocumentInternal.h:
2065         * WebView/WebDocumentLoaderMac.mm:
2066         (needsDataLoadWorkaround):
2067         * WebView/WebDynamicScrollBarsViewInternal.h:
2068         * WebView/WebFormDelegate.m:
2069         * WebView/WebFrame.mm:
2070         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2071         (-[WebFrame _unmarkAllMisspellings]):
2072         (-[WebFrame _paintBehaviorForDestinationContext:]):
2073         (-[WebFrame _drawRect:contentsOnly:]):
2074         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2075         (-[WebFrame _scrollDOMRangeToVisible:]):
2076         (-[WebFrame _bodyBackgroundColor]):
2077         (-[WebFrame accessibilityRoot]):
2078         (needsMicrosoftMessengerDOMDocumentWorkaround):
2079         * WebView/WebFrameInternal.h:
2080         * WebView/WebFrameView.mm:
2081         (-[WebFrameView _setDocumentView:]):
2082         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2083         (-[WebFrameView _viewClassForMIMEType:]):
2084         (-[WebFrameView initWithFrame:]):
2085         (-[WebFrameView drawRect:]):
2086         (-[WebFrameView _firstResponderIsFormControl]):
2087         (-[WebFrameView keyDown:keyDown:]):
2088         (-[WebFrameView _isScrollable]):
2089         * WebView/WebFullScreenController.h:
2090         * WebView/WebFullScreenController.mm:
2091         * WebView/WebHTMLRepresentation.mm:
2092         * WebView/WebHTMLView.mm:
2093         (-[WebHTMLView hitTest:]):
2094         (-[WebHTMLView initWithFrame:]):
2095         (-[WebHTMLView dealloc]):
2096         (-[WebHTMLView addSubview:]):
2097         (-[WebHTMLView mouseDown:]):
2098         (-[WebHTMLView mouseUp:]):
2099         (-[WebHTMLView resignFirstResponder]):
2100         (-[WebHTMLView accessibilityHitTest:]):
2101         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2102         * WebView/WebHTMLViewInternal.h:
2103         * WebView/WebIndicateLayer.h:
2104         * WebView/WebIndicateLayer.mm:
2105         * WebView/WebMediaPlaybackTargetPicker.h:
2106         * WebView/WebMediaPlaybackTargetPicker.mm:
2107         * WebView/WebPDFDocumentExtras.h:
2108         * WebView/WebPDFDocumentExtras.mm:
2109         * WebView/WebPDFRepresentation.h:
2110         * WebView/WebPDFRepresentation.mm:
2111         * WebView/WebPDFView.h:
2112         * WebView/WebPreferences.mm:
2113         (cacheModelForMainBundle):
2114         (WebPreferencesPrivate::WebPreferencesPrivate):
2115         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2116         (-[WebPreferences encodeWithCoder:]):
2117         (+[WebPreferences standardPreferences]):
2118         (+[WebPreferences initialize]):
2119         (-[WebPreferences _valueForKey:]):
2120         (-[WebPreferences _setStringValue:forKey:]):
2121         (-[WebPreferences _setIntegerValue:forKey:]):
2122         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2123         (-[WebPreferences _setFloatValue:forKey:]):
2124         (-[WebPreferences _setBoolValue:forKey:]):
2125         (-[WebPreferences _setLongLongValue:forKey:]):
2126         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2127         (-[WebPreferences _postCacheModelChangedNotification]):
2128         (-[WebPreferences _postPreferencesChangedNotification]):
2129         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2130         (-[WebPreferences setStorageBlockingPolicy:]):
2131         * WebView/WebResource.mm:
2132         (+[WebResourcePrivate initialize]):
2133         * WebView/WebTextCompletionController.h:
2134         * WebView/WebTextIterator.mm:
2135         (+[WebTextIteratorPrivate initialize]):
2136         * WebView/WebView.mm:
2137         (shouldEnableLoadDeferring):
2138         (shouldRestrictWindowFocus):
2139         (shouldRespectPriorityInCSSAttributeSetters):
2140         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2141         (shouldAllowPictureInPictureMediaPlayback):
2142         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2143         (shouldAllowWindowOpenWithoutUserGesture):
2144         (shouldConvertInvalidURLsToBlank):
2145         (shouldRequireUserGestureToLoadVideo):
2146         (-[WebView _commonInitializationWithFrameName:groupName:]):
2147         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2148         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2149         (-[WebView _closePluginDatabases]):
2150         (-[WebView _closeWithFastTeardown]):
2151         (-[WebView _close]):
2152         (+[WebView _MIMETypeForFile:]):
2153         (-[WebView setShowingInspectorIndication:]):
2154         (-[WebView _setFormDelegate:]):
2155         (-[WebView _needsPreHTML5ParserQuirks]):
2156         (-[WebView _preferencesChangedNotification:]):
2157         (-[WebView _preferencesChanged:]):
2158         (-[WebView _cacheResourceLoadDelegateImplementations]):
2159         (-[WebView _cacheFrameLoadDelegateImplementations]):
2160         (-[WebView _policyDelegateForwarder]):
2161         (-[WebView _UIDelegateForwarder]):
2162         (-[WebView _editingDelegateForwarder]):
2163         (-[WebView _updateActiveState]):
2164         (-[_WebSafeForwarder forwardInvocation:]):
2165         (+[WebView initialize]):
2166         (-[WebView _pluginForMIMEType:]):
2167         (-[WebView _pluginForExtension:]):
2168         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2169         (+[WebView canShowMIMETypeAsHTML:]):
2170         (-[WebView _initWithArguments:]):
2171         (-[WebView initWithFrame:frameName:groupName:]):
2172         (-[WebView dealloc]):
2173         (-[WebView close]):
2174         (-[WebView viewDidMoveToWindow]):
2175         (-[WebView setUIDelegate:]):
2176         (-[WebView setResourceLoadDelegate:]):
2177         (-[WebView setPolicyDelegate:]):
2178         (-[WebView setFrameLoadDelegate:]):
2179         (-[WebView goBack]):
2180         (-[WebView goForward]):
2181         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2182         (-[WebView setHostWindow:]):
2183         (-[WebView becomeFirstResponder]):
2184         (+[WebView _cacheModelChangedNotification:]):
2185         (-[WebView _frameViewAtWindowPoint:]):
2186         (+[WebView _preflightSpellCheckerNow:]):
2187         (+[WebView _preflightSpellChecker]):
2188         (-[WebView canGoBack]):
2189         (-[WebView canGoForward]):
2190         (-[WebView stopLoading:]):
2191         (-[WebView reload:]):
2192         (-[WebView setMainFrameDocumentReady:]):
2193         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2194         (-[WebView setContinuousSpellCheckingEnabled:]):
2195         (-[WebView undoManager]):
2196         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2197         (-[WebView isAutomaticLinkDetectionEnabled]):
2198         (-[WebView isAutomaticDashSubstitutionEnabled]):
2199         (-[WebView isAutomaticTextReplacementEnabled]):
2200         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2201         (+[WebView _setCacheModel:]):
2202         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2203         (-[WebView _keyboardUIMode]):
2204         (LayerFlushController::flushLayers):
2205         (-[WebView _scheduleCompositingLayerFlush]):
2206         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2207         (-[WebView fullScreenPlaceholderView]):
2208         (WebInstallMemoryPressureHandler):
2209         * WebView/WebViewData.h:
2210         * WebView/WebViewData.mm:
2211         (+[WebViewPrivate initialize]):
2212         (-[WebViewPrivate init]):
2213         (-[WebViewPrivate dealloc]):
2214         * WebView/WebViewInternal.h:
2215
2216 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2217
2218         Clean up FrameLoader two-state enums
2219         https://bugs.webkit.org/show_bug.cgi?id=190731
2220
2221         Reviewed by Chris Dumez.
2222
2223         * WebCoreSupport/WebFrameLoaderClient.h:
2224         * WebCoreSupport/WebFrameLoaderClient.mm:
2225         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2226
2227 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2228
2229         Unreviewed, rolling out r237137.
2230
2231         SPI is actually used
2232
2233         Reverted changeset:
2234
2235         "Remove unused WebFrame._loadType"
2236         https://bugs.webkit.org/show_bug.cgi?id=190583
2237         https://trac.webkit.org/changeset/237137
2238
2239 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2240
2241         Enable the datalist element by default on iOS and macOS
2242         https://bugs.webkit.org/show_bug.cgi?id=190594
2243         <rdar://problem/45281159>
2244
2245         Reviewed by Ryosuke Niwa and Tim Horton.
2246
2247         * Configurations/FeatureDefines.xcconfig:
2248
2249 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2250
2251         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2252         https://bugs.webkit.org/show_bug.cgi?id=190675
2253
2254         Reviewed by Chris Dumez.
2255
2256         * History/BackForwardList.h:
2257         * History/BackForwardList.mm:
2258         (BackForwardList::backItem):
2259         (BackForwardList::currentItem):
2260         (BackForwardList::forwardItem):
2261         (BackForwardList::backListCount const):
2262         (BackForwardList::forwardListCount const):
2263         (BackForwardList::itemAtIndex):
2264         * History/WebBackForwardList.mm:
2265         (-[WebBackForwardList backItem]):
2266         (-[WebBackForwardList currentItem]):
2267         (-[WebBackForwardList forwardItem]):
2268         (-[WebBackForwardList itemAtIndex:]):
2269
2270 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2271
2272         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2273         https://bugs.webkit.org/show_bug.cgi?id=190526
2274         rdar://problem/45230140
2275
2276         Reviewed by Dean Jackson.
2277
2278         * WebCoreSupport/WebEditorClient.mm:
2279         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2280
2281 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2282
2283         Implement feature flag and bindings for CSS Painting API
2284         https://bugs.webkit.org/show_bug.cgi?id=190237
2285
2286         Reviewed by Ryosuke Niwa.
2287
2288         * Configurations/FeatureDefines.xcconfig:
2289
2290 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2291
2292         Replace HistoryItem* with HistoryItem& where possible
2293         https://bugs.webkit.org/show_bug.cgi?id=190617
2294
2295         Reviewed by Chris Dumez.
2296
2297         * History/BackForwardList.h:
2298         * History/BackForwardList.mm:
2299         (BackForwardList::goToItem):
2300         * History/WebBackForwardList.mm:
2301         (-[WebBackForwardList goToItem:]):
2302         * History/WebHistoryItem.mm:
2303         (WKNotifyHistoryItemChanged):
2304         * History/WebHistoryItemInternal.h:
2305
2306 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2307
2308         Remove unused WebHistoryItem._transientPropertyForKey
2309         https://bugs.webkit.org/show_bug.cgi?id=190606
2310
2311         Reviewed by Chris Dumez.
2312
2313         * History/WebHistoryItem.mm:
2314         * History/WebHistoryItemPrivate.h:
2315
2316 2018-10-15  Justin Fan  <justin_fan@apple.com>
2317
2318         Add WebGPU 2018 feature flag and experimental feature flag
2319         https://bugs.webkit.org/show_bug.cgi?id=190509
2320
2321         Reviewed by Dean Jackson.
2322
2323         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2324         for the 2018 WebGPU prototype.
2325
2326         * Configurations/FeatureDefines.xcconfig:
2327         * WebView/WebPreferenceKeysPrivate.h:
2328         * WebView/WebPreferences.mm:
2329         (+[WebPreferences initialize]):
2330         (-[WebPreferences webGPUEnabled]):
2331         (-[WebPreferences setWebGPUEnabled:]):
2332         * WebView/WebPreferencesPrivate.h:
2333         * WebView/WebView.mm:
2334         (-[WebView _preferencesChanged:]):
2335
2336 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2337
2338         Fix iOS build after r237157
2339
2340         * WebView/WebView.mm:
2341         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2342
2343 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2344
2345         Modernize BackForwardClient.h
2346         https://bugs.webkit.org/show_bug.cgi?id=190610
2347
2348         Reviewed by Chris Dumez.
2349
2350         * History/BackForwardList.h:
2351         * History/BackForwardList.mm:
2352         (BackForwardList::backListCount const):
2353         (BackForwardList::forwardListCount const):
2354         (BackForwardList::backListCount): Deleted.
2355         (BackForwardList::forwardListCount): Deleted.
2356         * History/WebBackForwardList.mm:
2357         (-[WebBackForwardList init]):
2358         * WebCoreSupport/WebFrameLoaderClient.mm:
2359         (WebFrameLoaderClient::canCachePage const):
2360         * WebView/WebFrameView.mm:
2361         (-[WebFrameView keyDown:keyDown:]):
2362         * WebView/WebView.mm:
2363         (-[WebView _commonInitializationWithFrameName:groupName:]):
2364         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2365         (-[WebView _loadBackForwardListFromOtherView:]):
2366         (-[WebView initWithCoder:]):
2367         (-[WebView encodeWithCoder:]):
2368         (-[WebView backForwardList]):
2369         (-[WebView setMaintainsBackForwardList:]):
2370
2371 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2372
2373         Add support for prefers-color-scheme media query
2374         https://bugs.webkit.org/show_bug.cgi?id=190499
2375         rdar://problem/45212025
2376
2377         Reviewed by Dean Jackson.
2378
2379         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2380
2381 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2382
2383         Remove unused WebView._globalHistoryItem
2384         https://bugs.webkit.org/show_bug.cgi?id=190601
2385
2386         Reviewed by Chris Dumez.
2387
2388         * WebCoreSupport/WebFrameLoaderClient.h:
2389         * WebCoreSupport/WebFrameLoaderClient.mm:
2390         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2391         * WebView/WebView.mm:
2392         (-[WebView _globalHistoryItem]): Deleted.
2393         (-[WebView _setGlobalHistoryItem:]): Deleted.
2394         * WebView/WebViewData.h:
2395         * WebView/WebViewInternal.h:
2396         * WebView/WebViewPrivate.h:
2397
2398 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2399
2400         Remove unused parameters from FrameLoaderClient::createFrame
2401         https://bugs.webkit.org/show_bug.cgi?id=190587
2402
2403         Reviewed by Chris Dumez.
2404
2405         * WebCoreSupport/WebFrameLoaderClient.h:
2406         * WebCoreSupport/WebFrameLoaderClient.mm:
2407         (WebFrameLoaderClient::createFrame):
2408
2409 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2410
2411         Remove unused WebFrame._loadType
2412         https://bugs.webkit.org/show_bug.cgi?id=190583
2413
2414         Reviewed by Chris Dumez.
2415
2416         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2417
2418         * WebView/WebFrame.mm:
2419         (toWebFrameLoadType): Deleted.
2420         (-[WebFrame _loadType]): Deleted.
2421         * WebView/WebFramePrivate.h:
2422
2423 2018-10-15  Chris Dumez  <cdumez@apple.com>
2424
2425         Restrict browsing context lookup by name to frames that are related to one another
2426         https://bugs.webkit.org/show_bug.cgi?id=190475
2427
2428         Reviewed by Alex Christensen.
2429
2430         * WebView/WebFrame.mm:
2431         (-[WebFrame findFrameNamed:]):
2432
2433 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2434
2435         Remove InjectedBundle processing of back/forward lists
2436         https://bugs.webkit.org/show_bug.cgi?id=190459
2437
2438         Reviewed by Chris Dumez.
2439
2440         * WebCoreSupport/WebFrameLoaderClient.h:
2441         * WebCoreSupport/WebFrameLoaderClient.mm:
2442         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2443
2444 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2445
2446         [JSC] Remove Option::useAsyncIterator
2447         https://bugs.webkit.org/show_bug.cgi?id=190567
2448
2449         Reviewed by Saam Barati.
2450
2451         * Configurations/FeatureDefines.xcconfig:
2452
2453 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2454
2455         Allow encoding of small enum classes
2456         https://bugs.webkit.org/show_bug.cgi?id=190531
2457
2458         Reviewed by Tim Horton.
2459
2460         * WebCoreSupport/WebFrameLoaderClient.mm:
2461         (-[WebFramePolicyListener dealloc]):
2462
2463 2018-10-11  Keith Rollin  <krollin@apple.com>
2464
2465         CURRENT_ARCH should not be used in Run Script phase.
2466         https://bugs.webkit.org/show_bug.cgi?id=190407
2467         <rdar://problem/45133556>
2468
2469         Reviewed by Alexey Proskuryakov.
2470
2471         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2472         CURRENT_ARCH is not well-defined during this phase (and may even have
2473         the value "undefined") since this phase is run just once per build
2474         rather than once per supported architecture. Migrate away from
2475         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2476         performing an operation for each value, or by picking the first entry
2477         in ARCHS and using that as a representative value.
2478
2479         * Configurations/WebKitLegacy.xcconfig: When generating
2480         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2481         macosx platforms.
2482
2483         * MigrateHeaders.make:
2484         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2485         generate one for each architecture in ARCHS.
2486
2487 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2488
2489         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2490         https://bugs.webkit.org/show_bug.cgi?id=190429
2491
2492         Reviewed by Saam Barati.
2493
2494         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2495
2496         * WebView/WebPDFRepresentation.mm:
2497         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2498
2499 2018-10-08  Justin Fan  <justin_fan@apple.com>
2500
2501         WebGPU: Rename old WebGPU prototype to WebMetal
2502         https://bugs.webkit.org/show_bug.cgi?id=190325
2503         <rdar://problem/44990443>
2504
2505         Reviewed by Dean Jackson.
2506
2507         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2508
2509         * Configurations/FeatureDefines.xcconfig:
2510         * WebView/WebPreferenceKeysPrivate.h:
2511         * WebView/WebPreferences.mm:
2512         (+[WebPreferences initialize]):
2513         (-[WebPreferences webMetalEnabled]):
2514         (-[WebPreferences setWebMetalEnabled:]):
2515         (-[WebPreferences webGPUEnabled]): Deleted.
2516         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2517         * WebView/WebPreferencesPrivate.h:
2518         * WebView/WebView.mm:
2519         (-[WebView _preferencesChanged:]):
2520
2521 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2522
2523         Make <input type=color> a runtime enabled (on-by-default) feature
2524         https://bugs.webkit.org/show_bug.cgi?id=189162
2525
2526         Reviewed by Wenson Hsieh and Tim Horton.
2527
2528         * Configurations/FeatureDefines.xcconfig:
2529
2530 2018-10-07  Dan Bernstein  <mitz@apple.com>
2531
2532         Fixed building with the latest macOS SDK
2533
2534         * Plugins/WebNetscapePluginPackage.mm:
2535         (-[WebNetscapePluginPackage openResourceFile]):
2536         (-[WebNetscapePluginPackage closeResourceFile:]):
2537
2538 2018-10-04  Dan Bernstein  <mitz@apple.com>
2539
2540         More Carbon build-fixing.
2541
2542         * Carbon/CarbonWindowAdapter.mm:
2543         (-[CarbonWindowAdapter _destroyRealWindow:]):
2544         (-[CarbonWindowAdapter _growBoxRect]):
2545
2546 2018-10-04  Dan Bernstein  <mitz@apple.com>
2547
2548         Retried to fix 32-bit macOS builds after r236846.
2549
2550         * WebView/WebHTMLView.mm:
2551         (-[WebHTMLView setMarkedText:selectedRange:]):
2552
2553 2018-10-04  Dan Bernstein  <mitz@apple.com>
2554
2555         Retried to fix 32-bit macOS builds after r236846.
2556
2557         * Carbon/HIWebView.mm:
2558         (ActiveStateChanged):
2559
2560 2018-10-04  Dan Bernstein  <mitz@apple.com>
2561
2562         Tried to fix 32-bit macOS builds after r236846.
2563
2564         * Carbon/HIWebView.mm:
2565         (_NSSelectorForHICommand):
2566
2567 2018-10-04  Dan Bernstein  <mitz@apple.com>
2568
2569         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2570         https://bugs.webkit.org/show_bug.cgi?id=190250
2571
2572         Reviewed by Andy Estes.
2573
2574         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2575           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2576           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2577           an earlier line set it to YES.
2578
2579         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2580         changes below.
2581
2582         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2583           provides some missing method declarations.
2584
2585         * Misc/WebDownload.mm:
2586         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2587           a deprecated method.
2588
2589         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2590
2591         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2592           other code in the file uses a method from it.
2593
2594         * Plugins/WebBaseNetscapePluginView.mm:
2595         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2596           a deprecated method.
2597
2598         * Plugins/WebPluginController.mm:
2599         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2600           around use of a selector that may be present in some WebKit client.
2601
2602         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2603           method declarations.
2604
2605         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2606           from here.
2607
2608         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2609           missing method declarations.
2610
2611         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2612           from here.
2613
2614         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2615           call from here.
2616         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2617           an obsolete delegate method for binary compatibility.
2618         (pluginView): Ditto.
2619
2620         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2621           call from here.
2622
2623         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2624           WebDeviceOrientationProviderMock protocol.
2625
2626         * WebView/WebDeviceOrientationProviderMock.mm:
2627         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2628           main @implementation.
2629
2630         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2631           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2632
2633         * WebView/WebDynamicScrollBarsView.mm:
2634         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2635           of a deprecated method.
2636
2637         * WebView/WebHTMLView.mm:
2638         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2639           selector warning around action methods that are not declared anywhere in WebKit.
2640
2641         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2642           about implementing this deprecated method.
2643         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2644         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2645         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2646         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2647         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2648         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2649         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2650         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2651         (-[WebHTMLView doCommandBySelector:]): Ditto.
2652         (-[WebHTMLView insertText:]): Ditto.
2653
2654         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2655
2656         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2657
2658         * WebView/WebPDFView.h: Removed previewView ivar.
2659
2660         * WebView/WebPDFView.mm:
2661           Removed declaration of FileInternal category and merged its implementation with the main
2662           implementation.
2663         (-[WebPDFView dealloc]): Removed previewView ivar.
2664         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2665           exist in macOS versions we support.
2666         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2667         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2668           action methods internal to PDFKit.
2669         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2670         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2671
2672         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2673           call on macOS, even though in r86988 we started calling different methods on iOS.
2674
2675         * WebView/WebView.mm:
2676         - Imported headers that declare delegate methods that we call.
2677         - Removed declaration of WebFileInternal category and merged its implementation with the
2678           main implementation.
2679         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2680           category, which made them impossible to call from the main implementation. Moved those
2681           into the main implementation. One of those had to be declared in a class extension,
2682           because it is called from a method implemented in the WebPrivate category, and that
2683           category’s implementation appears first in the file.
2684
2685         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2686           around use of obsolete delegate method for binary compatibility.
2687
2688         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2689
2690 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2691
2692         Runtime flag and IDL for MediaRecorder
2693         https://bugs.webkit.org/show_bug.cgi?id=190018
2694
2695         Reviewed by Youenn Fablet and Chris Dumez.
2696
2697         * WebView/WebPreferenceKeysPrivate.h:
2698         * WebView/WebPreferences.mm:
2699         (+[WebPreferences initialize]):
2700         (-[WebPreferences mediaRecorderEnabled]):
2701         (-[WebPreferences setMediaRecorderEnabled:]):
2702         * WebView/WebPreferencesPrivate.h:
2703         * WebView/WebView.mm:
2704         (-[WebView _preferencesChanged:]):
2705
2706 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2707
2708         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2709         https://bugs.webkit.org/show_bug.cgi?id=190238
2710
2711         Reviewed by Antti Koivisto.
2712
2713         Enabled the feature by default.
2714
2715         * WebView/WebPreferences.mm:
2716         (+[WebPreferences initialize]):
2717
2718 2018-10-01  Dean Jackson  <dino@apple.com>
2719
2720         [macOS] Switching to discrete GPU should be done in the UI process
2721         https://bugs.webkit.org/show_bug.cgi?id=189361
2722         <rdar://problem/43949622>
2723
2724         Reviewed by Simon Fraser.
2725
2726         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2727         not support swapping to the discrete GPU in this configuration.
2728
2729         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2730         (WebKit::WebSwitchingGPUClient::singleton):
2731         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2732         * WebView/WebView.mm:
2733         (-[WebView _commonInitializationWithFrameName:groupName:]):
2734
2735 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2736
2737         Remove ParsedURLString
2738         https://bugs.webkit.org/show_bug.cgi?id=190154
2739
2740         Reviewed by Chris Dumez.
2741
2742         * WebView/WebScriptDebugger.mm:
2743         (toNSURL):
2744
2745 2018-10-01  Dean Jackson  <dino@apple.com>
2746
2747         Remove CSS Animation Triggers
2748         https://bugs.webkit.org/show_bug.cgi?id=190175
2749         <rdar://problem/44925626>
2750
2751         Reviewed by Simon Fraser.
2752
2753         * Configurations/FeatureDefines.xcconfig:
2754
2755 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2756
2757         Unreviewed, rolling out r236624 and r236671.
2758         https://bugs.webkit.org/show_bug.cgi?id=190207
2759
2760         The change in r236624 introduced crashes on the bots
2761         (Requested by ryanhaddad on #webkit).
2762
2763         Reverted changesets:
2764
2765         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2766         https://bugs.webkit.org/show_bug.cgi?id=188747
2767         https://trac.webkit.org/changeset/236624
2768
2769         "Unify implementation in VideoFullscreenInterfaceAVKit"
2770         https://bugs.webkit.org/show_bug.cgi?id=190091
2771         https://trac.webkit.org/changeset/236671
2772
2773 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2774
2775         URL should not use TextEncoding internally
2776         https://bugs.webkit.org/show_bug.cgi?id=190111
2777
2778         Reviewed by Andy Estes.
2779
2780         * Misc/WebNSURLExtras.mm:
2781
2782 2018-09-28  Jer Noble  <jer.noble@apple.com>
2783
2784         Refactoring: eliminate raw pointer usage in Fullscreen code
2785         https://bugs.webkit.org/show_bug.cgi?id=188747
2786         <rdar://problem/43541164>
2787
2788         Reviewed by Alex Christensen.
2789
2790         PlaybackSessionInterface no longer has an invalidate() method.
2791
2792         * WebView/WebView.mm:
2793         (-[WebView _clearPlaybackControlsManager]):
2794
2795 2018-09-28  Chris Dumez  <cdumez@apple.com>
2796
2797         Drop support for cross-origin-window-policy header
2798         https://bugs.webkit.org/show_bug.cgi?id=190081
2799
2800         Reviewed by Ryosuke Niwa.
2801
2802         * WebView/WebPreferenceKeysPrivate.h:
2803         * WebView/WebPreferences.mm:
2804         (+[WebPreferences initialize]):
2805         * WebView/WebPreferencesPrivate.h:
2806         * WebView/WebView.mm:
2807         (-[WebView _preferencesChanged:]):
2808
2809 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2810
2811         Rename createMarkup to serializePreservingVisualAppearance
2812         https://bugs.webkit.org/show_bug.cgi?id=190086
2813
2814         Reviewed by Wenson Hsieh.
2815
2816         * DOM/WebDOMOperations.mm:
2817         (-[DOMRange markupString]):
2818
2819 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2820
2821         Unreviewed, rolling out r236605.
2822         https://bugs.webkit.org/show_bug.cgi?id=190087
2823
2824         caused three API test timeouts (Requested by jernoble on
2825         #webkit).
2826
2827         Reverted changeset:
2828
2829         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2830         https://bugs.webkit.org/show_bug.cgi?id=188747
2831         https://trac.webkit.org/changeset/236605
2832
2833 2018-09-28  Jer Noble  <jer.noble@apple.com>
2834
2835         Refactoring: eliminate raw pointer usage in Fullscreen code
2836         https://bugs.webkit.org/show_bug.cgi?id=188747
2837         <rdar://problem/43541164>
2838
2839         Reviewed by Alex Christensen.
2840
2841         PlaybackSessionInterface no longer has an invalidate() method.
2842
2843         * WebView/WebView.mm:
2844         (-[WebView _clearPlaybackControlsManager]):
2845
2846 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2847
2848         Use enum class in createMarkup arguments
2849         https://bugs.webkit.org/show_bug.cgi?id=190028
2850
2851         Reviewed by Wenson Hsieh.
2852
2853         * DOM/WebDOMOperations.mm:
2854         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2855         (-[DOMRange markupString]): Ditto.
2856
2857 2018-09-27  Antoine Quint  <graouts@apple.com>
2858
2859         [Web Animations] Turn Web Animations with CSS integration on
2860         https://bugs.webkit.org/show_bug.cgi?id=184819
2861         <rdar://problem/39597337>
2862
2863         Reviewed by Dean Jackson.
2864
2865         * WebView/WebPreferences.mm:
2866         (+[WebPreferences initialize]):
2867
2868 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2869
2870         Selection should work across shadow boundary when initiated by a mouse drag
2871         https://bugs.webkit.org/show_bug.cgi?id=151380
2872         <rdar://problem/24363872>
2873
2874         Reviewed by Wenson Hsieh.
2875
2876         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2877
2878         * WebView/WebPreferenceKeysPrivate.h:
2879         * WebView/WebPreferences.mm:
2880         (+[WebPreferences initialize]):
2881         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2882         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2883         * WebView/WebPreferencesPrivate.h:
2884         * WebView/WebView.mm:
2885         (-[WebView _preferencesChanged:]):
2886
2887 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2888
2889         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2890         https://bugs.webkit.org/show_bug.cgi?id=189918
2891         Work towards <rdar://problem/44648705>
2892
2893         Reviewed by Tim Horton.
2894
2895         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2896
2897         * WebView/WebHTMLView.mm:
2898         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2899         (-[WebHTMLView _updateFontPanel]):
2900         * WebView/WebView.mm:
2901         (-[WebView typingAttributes]):
2902
2903 2018-09-17  Darin Adler  <darin@apple.com>
2904
2905         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2906         https://bugs.webkit.org/show_bug.cgi?id=189652
2907
2908         Reviewed by Saam Barati.
2909
2910         * WebView/WebPDFRepresentation.mm:
2911         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2912
2913 2018-09-14  Jer Noble  <jer.noble@apple.com>
2914
2915         Turn SourceBufferChangeTypeEnabled on by default
2916         https://bugs.webkit.org/show_bug.cgi?id=189527
2917
2918         Reviewed by Eric Carlson.
2919
2920         * WebView/WebPreferences.mm:
2921         (+[WebPreferences initialize]):
2922
2923 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2924
2925         Fix an internal build after r235935
2926         https://bugs.webkit.org/show_bug.cgi?id=188996
2927
2928         * Carbon/HIWebView.mm:
2929         (Draw):
2930         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2931
2932 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2933
2934         Add IGNORE_WARNING_.* macros
2935         https://bugs.webkit.org/show_bug.cgi?id=188996
2936
2937         Reviewed by Michael Catanzaro.
2938
2939         * Carbon/CarbonUtils.m:
2940         (PoolCleaner):
2941         * Carbon/CarbonWindowAdapter.mm:
2942         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2943         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2944         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2945         (-[CarbonWindowAdapter _termWindowIfOwner]):
2946         (-[CarbonWindowAdapter _windowMovedToRect:]):
2947         (-[CarbonWindowAdapter setContentView:]):
2948         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2949         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2950         * Carbon/CarbonWindowFrame.m:
2951         (-[CarbonWindowFrame title]):
2952         * Carbon/HIViewAdapter.m:
2953         (+[HIViewAdapter getHIViewForNSView:]):
2954         * Carbon/HIWebView.mm:
2955         (overrideCGContext):
2956         (restoreCGContext):
2957         (Draw):
2958         * DOM/DOM.mm:
2959         * History/WebHistory.mm:
2960         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2961         * History/WebHistoryItem.mm:
2962         (-[WebHistoryItem icon]):
2963         * Misc/WebKitNSStringExtras.mm:
2964         (-[NSString _web_drawAtPoint:font:textColor:]):
2965         * Misc/WebNSImageExtras.m:
2966         (-[NSImage _web_scaleToMaxSize:]):
2967         (-[NSImage _web_dissolveToFraction:]):
2968         * Misc/WebNSPasteboardExtras.mm:
2969         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2970         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2971         * Panels/WebAuthenticationPanel.m:
2972         (-[WebAuthenticationPanel loadNib]):
2973         * Plugins/Hosted/NetscapePluginHostManager.mm:
2974         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2975         (WebKit::NetscapePluginHostManager::didCreateWindow):
2976         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2977         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2978         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2979         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2980         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2981         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2982         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2983         (-[WebHostedNetscapePluginView drawRect:]):
2984         * Plugins/Hosted/WebTextInputWindowController.m:
2985         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2986         * Plugins/WebBaseNetscapePluginView.mm:
2987         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2988         * Plugins/WebNetscapePluginPackage.mm:
2989         (-[WebNetscapePluginPackage _tryLoad]):
2990         * Plugins/WebNetscapePluginView.mm:
2991         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2992         (-[WebNetscapePluginView sendDrawRectEvent:]):
2993         (-[WebNetscapePluginView drawRect:]):
2994         * Plugins/WebPluginController.mm:
2995         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2996         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2997         * WebCoreSupport/PopupMenuMac.mm:
2998         (PopupMenuMac::populate):
2999         * WebCoreSupport/WebAlternativeTextClient.h:
3000         * WebCoreSupport/WebDragClient.mm:
3001         (WebDragClient::startDrag):
3002         * WebCoreSupport/WebFrameLoaderClient.mm:
3003         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3004         (webGetNSImage):
3005         * WebInspector/WebNodeHighlight.mm:
3006         * WebInspector/WebNodeHighlightView.mm:
3007         (-[WebNodeHighlightView drawRect:]):
3008         * WebView/WebClipView.mm:
3009         (-[WebClipView initWithFrame:]):
3010         * WebView/WebFrame.mm:
3011         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3012         (-[WebFrame _drawRect:contentsOnly:]):
3013         (-[WebFrame accessibilityRoot]):
3014         * WebView/WebFullScreenController.mm:
3015         (-[WebFullScreenController enterFullScreen:]):
3016         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3017         (-[WebFullScreenController exitFullScreen]):
3018         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3019         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3020         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3021         * WebView/WebHTMLView.mm:
3022         (-[NSWindow _web_borderView]):
3023         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3024         (-[WebHTMLView _setAsideSubviews]):
3025         (-[WebHTMLView _autoscroll]):
3026         (-[WebHTMLView drawRect:]):
3027         (-[WebHTMLView mouseDown:]):
3028         (-[WebHTMLView mouseDragged:]):
3029         (-[WebHTMLView mouseUp:]):
3030         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3031         (-[WebHTMLView knowsPageRange:]):
3032         (-[WebHTMLView accessibilityHitTest:]):
3033         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3034         (-[WebHTMLView _colorAsString:]):
3035         (-[WebHTMLView copyFont:]):
3036         (-[WebHTMLView _executeSavedKeypressCommands]):
3037         (-[WebHTMLView attachRootLayer:]):
3038         (-[WebHTMLView textStorage]):
3039         (-[WebHTMLView _updateSelectionForInputManager]):
3040         * WebView/WebPDFView.mm:
3041         (_applicationInfoForMIMEType):
3042         (-[WebPDFView centerSelectionInVisibleArea:]):
3043         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3044         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3045         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3046         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3047         * WebView/WebTextCompletionController.mm:
3048         (-[WebTextCompletionController _buildUI]):
3049         (-[WebTextCompletionController _placePopupWindow:]):
3050         * WebView/WebVideoFullscreenController.mm:
3051         * WebView/WebVideoFullscreenHUDWindowController.mm:
3052         (createMediaUIBackgroundView):
3053         * WebView/WebView.mm:
3054         (-[WebTextListTouchBarViewController initWithWebView:]):
3055         (-[WebView _dispatchTileDidDraw:]):
3056         (-[WebView encodeWithCoder:]):
3057         (-[WebView mainFrameIcon]):
3058         (LayerFlushController::flushLayers):
3059         * WebView/WebWindowAnimation.mm:
3060         (setScaledFrameForWindow):
3061
3062 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3063
3064         Remove unused needsDestruction class variables from HashTraits
3065         https://bugs.webkit.org/show_bug.cgi?id=189490
3066
3067         Reviewed by Daniel Bates.
3068
3069         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3070
3071 2018-09-07  Frederic Wang  <fwang@igalia.com>
3072
3073         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3074         https://bugs.webkit.org/show_bug.cgi?id=182230
3075
3076         Reviewed by Simon Fraser.
3077
3078         * DOM/DOMDocument.mm:
3079         (-[DOMDocument scrollingElement]): Use the new name.
3080
3081 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3082
3083         Refactor WebCore::EditAction to be an 8-bit enum class
3084         https://bugs.webkit.org/show_bug.cgi?id=189383
3085
3086         Reviewed by Dan Bernstein.
3087
3088         * WebCoreSupport/WebEditorClient.mm:
3089         (undoNameForEditAction):
3090         * WebView/WebHTMLView.mm:
3091         (-[WebHTMLView pasteFont:]):
3092         (-[WebHTMLView changeFont:]):
3093         (-[WebHTMLView changeAttributes:]):
3094         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3095         (-[WebHTMLView changeColor:]):
3096         * WebView/WebView.mm:
3097         (-[WebView setTypingStyle:]):
3098
3099 2018-09-06  Frederic Wang  <fwang@igalia.com>
3100
3101         Group options of scrollRectToVisible into a struct
3102         https://bugs.webkit.org/show_bug.cgi?id=189352
3103
3104         Reviewed by Simon Fraser.
3105
3106         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3107         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3108         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3109
3110 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3111
3112         [macOS] Cannot change font size at selection until font panel is shown
3113         https://bugs.webkit.org/show_bug.cgi?id=189295
3114         <rdar://problem/35593389>
3115
3116         Reviewed by Ryosuke Niwa.
3117
3118         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3119         WebCore ChangeLog for more details.
3120
3121         * WebView/WebHTMLView.mm:
3122         (-[WebHTMLView changeFont:]):
3123         (-[WebHTMLView changeAttributes:]):
3124         (-[WebHTMLView _originalFontA]): Deleted.
3125         (-[WebHTMLView _originalFontB]): Deleted.
3126         (fontNameForDescription): Deleted.
3127         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3128         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3129         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3130
3131 2018-09-05  Jer Noble  <jer.noble@apple.com>
3132
3133         Add MediaCapabilities as an Experimental Feature
3134         https://bugs.webkit.org/show_bug.cgi?id=189209
3135
3136         Reviewed by Eric Carlson.
3137
3138         RuntimeEnabledFeature -> Setting.
3139
3140         * WebView/WebView.mm:
3141         (-[WebView _preferencesChanged:]):
3142
3143 2018-09-04  Frederic Wang  <fwang@igalia.com>
3144
3145         Add basic support for ScrollIntoViewOptions
3146         https://bugs.webkit.org/show_bug.cgi?id=189258
3147
3148         Reviewed by Simon Fraser.
3149
3150         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3151         header so that this file can build despite the new scrollIntoView function.
3152
3153 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3154
3155         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3156         https://bugs.webkit.org/show_bug.cgi?id=188890
3157         <rdar://problem/43648605>
3158
3159         Reviewed by Tim Horton.
3160
3161         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3162         more detail.
3163
3164         * WebCoreSupport/WebPlatformStrategies.h:
3165         * WebCoreSupport/WebPlatformStrategies.mm:
3166         (WebPlatformStrategies::allStringsForType):
3167
3168 2018-09-01  Darin Adler  <darin@apple.com>
3169
3170         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3171         https://bugs.webkit.org/show_bug.cgi?id=189072
3172         Reviewed by Dan Bernstein.
3173
3174         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3175         and declarations for NSURLDownload init methods.
3176
3177         * Misc/WebDownloadInternal.h: Removed.
3178
3179         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3180         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3181         "-Wdeprecated-declarations" because the method used here is deprecated.
3182
3183         * WebView/WebView.mm:
3184         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3185         used here is deprecated.
3186
3187 2018-08-31  Chris Dumez  <cdumez@apple.com>
3188
3189         Assertion hit in ~CompletionHandler() from ~WebFrame()
3190         https://bugs.webkit.org/show_bug.cgi?id=189199
3191         <rdar://problem/42657233>
3192
3193         Reviewed by Youenn Fablet.
3194
3195         * WebCoreSupport/WebFrameLoaderClient.h:
3196         * WebCoreSupport/WebFrameLoaderClient.mm:
3197         (WebFrameLoaderClient::dispatchWillSubmitForm):
3198
3199 2018-08-31  Antti Koivisto  <antti@apple.com>
3200
3201         Replace OptionSet |= and -= operators with add() and remove() functions
3202         https://bugs.webkit.org/show_bug.cgi?id=189169
3203
3204         Reviewed by Anders Carlsson.
3205
3206         * WebView/WebFrame.mm:
3207         (-[WebFrame _drawRect:contentsOnly:]):
3208         * WebView/WebView.mm:
3209         (coreOptions):
3210
3211 2018-08-31  Frederic Wang  <fwang@igalia.com>
3212
3213         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3214         https://bugs.webkit.org/show_bug.cgi?id=182053
3215
3216         Reviewed by Simon Fraser.
3217
3218         Add developer flag to use standard behavior for scrolling* attributes.
3219
3220         * WebView/WebPreferenceKeysPrivate.h:
3221         * WebView/WebPreferences.mm:
3222         (+[WebPreferences initialize]):
3223         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3224         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3225         * WebView/WebPreferencesPrivate.h:
3226         * WebView/WebView.mm:
3227         (-[WebView _preferencesChanged:]):
3228
3229 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3230
3231         Implement the Web Share API
3232         https://bugs.webkit.org/show_bug.cgi?id=171100
3233         <rdar://problem/31751734>
3234
3235         Reviewed by Tim Horton.
3236
3237         * WebCoreSupport/WebChromeClient.h:
3238         * WebCoreSupport/WebChromeClient.mm:
3239         (WebChromeClient::showShareSheet):
3240         Empty declaration of showShareSheet.
3241
3242 2018-08-29  Youenn Fablet  <youenn@apple.com>
3243
3244         Remove WebRTC legacy API implementation
3245         https://bugs.webkit.org/show_bug.cgi?id=189040
3246
3247         Reviewed by Eric Carlson.
3248
3249         * WebView/WebPreferenceKeysPrivate.h:
3250         * WebView/WebPreferences.mm:
3251         (+[WebPreferences initialize]):
3252         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3253         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3254         * WebView/WebPreferencesPrivate.h:
3255         * WebView/WebView.mm:
3256         (-[WebView _preferencesChanged:]):
3257
3258 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3259
3260         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3261         https://bugs.webkit.org/show_bug.cgi?id=189054
3262
3263         Reviewed by Andy Estes.
3264
3265         Remove the pasteboard type argument from readURLFromPasteboard.
3266
3267         * WebCoreSupport/WebPlatformStrategies.h:
3268         * WebCoreSupport/WebPlatformStrategies.mm:
3269         (WebPlatformStrategies::readURLFromPasteboard):
3270
3271 2018-08-27  Keith Rollin  <krollin@apple.com>
3272
3273         Unreviewed build fix -- disable LTO for production builds
3274
3275         * Configurations/Base.xcconfig:
3276
3277 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3278
3279         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3280         https://bugs.webkit.org/show_bug.cgi?id=188931
3281
3282         Reviewed by Wenson Hsieh.
3283
3284         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3285
3286 2018-08-27  Keith Rollin  <krollin@apple.com>
3287
3288         Build system support for LTO
3289         https://bugs.webkit.org/show_bug.cgi?id=187785
3290         <rdar://problem/42353132>
3291
3292         Reviewed by Dan Bernstein.
3293
3294         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3295         LTO.
3296
3297         * Configurations/Base.xcconfig:
3298         * Configurations/DebugRelease.xcconfig:
3299
3300 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3301
3302         Pass in IsComposed flag to Event constructors
3303         https://bugs.webkit.org/show_bug.cgi?id=188720
3304         <rdar://problem/43580387>
3305
3306         Reviewed by Simon Fraser.
3307
3308         * WebView/WebPDFView.mm:
3309         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3310         whether it's simulated or not.
3311
3312 2018-08-23  Mark Lam  <mark.lam@apple.com>
3313
3314         Move vmEntryGlobalObject() to VM from CallFrame.
3315         https://bugs.webkit.org/show_bug.cgi?id=188900
3316         <rdar://problem/43655753>
3317
3318         Reviewed by Michael Saboff.
3319
3320         * WebView/WebScriptDebugger.mm:
3321         (WebScriptDebugger::sourceParsed):
3322
3323 2018-08-23  Andy Estes  <aestes@apple.com>
3324
3325         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3326         https://bugs.webkit.org/show_bug.cgi?id=188829
3327
3328         Reviewed by Tim Horton.
3329
3330         * Configurations/FeatureDefines.xcconfig:
3331
3332 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3333
3334         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3335         https://bugs.webkit.org/show_bug.cgi?id=188777
3336
3337         Reviewed by Simon Fraser.
3338
3339         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3340         being "true" before the code change.
3341
3342         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3343
3344         * WebView/WebPDFView.mm:
3345         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3346
3347 2018-08-21  Daniel Bates  <dabates@apple.com>
3348
3349         Replace TextCheckingTypeMask with OptionSet
3350         https://bugs.webkit.org/show_bug.cgi?id=188678
3351
3352         Reviewed by Antti Koivisto.
3353
3354         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3355         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3356         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3357         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3358
3359         * WebCoreSupport/WebEditorClient.h:
3360         * WebCoreSupport/WebEditorClient.mm:
3361         (WebEditorClient::checkTextOfParagraph):
3362         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3363         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3364         left as this is more readable and unncessary now that modern compilers like Clang have
3365         diagnostics to catch accidental assignments when equality was intended.
3366         (WebEditorClient::didCheckSucceed):
3367         * WebView/WebView.mm:
3368         (coreTextCheckingType):
3369         (textCheckingResultFromNSTextCheckingResult):
3370
3371 2018-08-21  Daniel Bates  <dabates@apple.com>
3372
3373         [iOS][WK1] Support toggling continuous spell checking from tests
3374         https://bugs.webkit.org/show_bug.cgi?id=188763
3375
3376         Reviewed by Simon Fraser.
3377
3378         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3379         spell checking from tests in iOS WebKit Legacy.
3380
3381         * WebCoreSupport/WebEditorClient.h:
3382         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3383         * WebCoreSupport/WebEditorClient.mm:
3384         * WebView/WebView.h:
3385         * WebView/WebView.mm:
3386         (-[WebView toggleContinuousSpellChecking:]):
3387         (-[WebView toggleSmartInsertDelete:]):
3388
3389 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3390
3391         Add some plumbing for safe browsing
3392         https://bugs.webkit.org/show_bug.cgi?id=188709
3393
3394         Reviewed by Tim Horton.
3395
3396         * WebCoreSupport/WebFrameLoaderClient.h:
3397         * WebCoreSupport/WebFrameLoaderClient.mm:
3398         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3399
3400 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3401
3402         Replace canBubble and cancelable booleans in Event by enum classes
3403         https://bugs.webkit.org/show_bug.cgi?id=188692
3404
3405         Reviewed by Alex Christensen.
3406
3407         * WebView/WebPDFView.mm:
3408         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3409         * WebView/WebView.mm:
3410         (-[WebView _dispatchUnloadEvent]):
3411
3412 2018-08-16  Jer Noble  <jer.noble@apple.com>
3413
3414         Add Experimental Feature support for SourceBuffer.changeType()
3415         https://bugs.webkit.org/show_bug.cgi?id=188626
3416         <rdar://problem/43356021>
3417
3418         Reviewed by Eric Carlson.
3419
3420         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3421
3422         * WebView/WebPreferenceKeysPrivate.h:
3423         * WebView/WebPreferences.mm:
3424         (+[WebPreferences initialize]):
3425         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3426         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3427         * WebView/WebPreferencesPrivate.h:
3428         * WebView/WebView.mm:
3429         (-[WebView _preferencesChanged:]):
3430
3431 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3432
3433         Support drag-and-drop for input[type=color]
3434         https://bugs.webkit.org/show_bug.cgi?id=188464
3435
3436         Reviewed by Wenson Hsieh.
3437
3438         * WebCoreSupport/WebPlatformStrategies.h:
3439         * WebCoreSupport/WebPlatformStrategies.mm:
3440         (WebPlatformStrategies::setColor):
3441
3442 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3443
3444         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3445         https://bugs.webkit.org/show_bug.cgi?id=188569
3446         <rdar://problem/34201095>
3447
3448         Reviewed by Megan Gardner.
3449
3450         * WebView/WebImmediateActionController.mm:
3451         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3452         Speculative fix; the crashes indicate font is null, but we just checked it,
3453         so it must be getting made null by convertFont:toSize:. Check again!
3454
3455 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3456
3457         Use a 1-byte enum class for TextDirection
3458         https://bugs.webkit.org/show_bug.cgi?id=188350
3459
3460         Reviewed by Simon Fraser.
3461
3462         * WebCoreSupport/PopupMenuMac.mm:
3463         (PopupMenuMac::populate):
3464         (PopupMenuMac::show):
3465         * WebCoreSupport/WebFrameLoaderClient.mm:
3466         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3467         * WebView/WebFrame.mm:
3468         (-[WebFrame _dispatchDidReceiveTitle:]):
3469
3470 2018-08-09  Ali Juma  <ajuma@chromium.org>
3471
3472         Import WPTs for IntersectionObserver
3473         https://bugs.webkit.org/show_bug.cgi?id=188416
3474
3475         Reviewed by Simon Fraser.
3476
3477         * WebView/WebPreferencesPrivate.h:
3478
3479 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3480
3481         Follow-up build fix for r234685
3482         https://bugs.webkit.org/show_bug.cgi?id=188245
3483
3484         Unreviewed build fix.
3485
3486         * WebCoreSupport/WebSecurityOriginPrivate.h:
3487
3488 2018-08-05  Darin Adler  <darin@apple.com>
3489
3490         [Cocoa] More tweaks and refactoring to prepare for ARC
3491         https://bugs.webkit.org/show_bug.cgi?id=188245
3492
3493         Reviewed by Dan Bernstein.
3494
3495         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3496
3497         * Carbon/CarbonWindowFrame.m:
3498         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3499
3500         * DOM/DOM.mm:
3501         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3502         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3503         garbage collection so this method isn't useful.
3504
3505         * DOM/DOMXPath.mm:
3506         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3507         Objective-C garbage collection so this method isn't useful.
3508
3509         * History/WebHistory.mm:
3510         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3511
3512         * Misc/WebElementDictionary.mm:
3513         (addLookupKey): Use a bridging cast.
3514         (cacheValueForKey): Ditto.
3515         (-[WebElementDictionary _fillCache]): Ditto.
3516         (-[WebElementDictionary objectForKey:]): Ditto.
3517
3518         * Misc/WebKitNSStringExtras.mm:
3519         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3520         (-[NSString _web_widthWithFont:]): Ditto.
3521         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3522
3523         * Misc/WebLocalizableStrings.mm:
3524         (WebLocalizedString): Use a bridging cast.
3525
3526         * Misc/WebNSDataExtras.mm:
3527         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3528         and use CFBridgingRelease instead of calling autorelease directly.
3529         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3530         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3531         on the amount of explicit release and autorelease.
3532
3533         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3534         * Misc/WebNSDictionaryExtras.m:
3535         (-[NSDictionary _webkit_intForKey:]): Deleted.
3536         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3537         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3538         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3539         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3540         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3541         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3542
3543         * Misc/WebStringTruncator.mm:
3544         (fontFromNSFont): Use a bridging cast.
3545
3546         * Plugins/Hosted/NetscapePluginHostManager.mm:
3547         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3548
3549         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3550         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3551         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3552         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3553         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3554         * Plugins/Hosted/ProxyInstance.mm:
3555         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3556         * Plugins/WebBasePluginPackage.mm:
3557         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3558         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3559         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3560         * Plugins/WebNetscapePluginPackage.mm:
3561         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3562
3563         * Plugins/WebNetscapePluginView.mm:
3564         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3565         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3566         (-[WebNetscapePluginView status:]): Use a bridging cast.
3567         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3568
3569         * Plugins/WebPluginController.mm:
3570         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3571
3572         * Plugins/WebPluginDatabase.mm:
3573         (checkCandidate): Use explicit __strong for out argument types.
3574
3575         * Plugins/npapi.mm:
3576         (pluginViewForInstance): Use a bridging cast.
3577
3578         * Storage/WebDatabaseManager.mm:
3579         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3580         explicit NSNumber and NSDictionary calls.
3581
3582         * WebCoreSupport/WebContextMenuClient.mm:
3583         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3584
3585         * WebCoreSupport/WebEditorClient.mm:
3586         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3587         (WebEditorClient::handleInputMethodKeydown): Ditto.
3588
3589         * WebCoreSupport/WebFrameNetworkingContext.mm:
3590         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3591
3592         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3593         as a struct rather than an Objective-C class, since that's how it's defined.
3594
3595         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3596
3597         * WebView/WebFullScreenController.mm:
3598         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3599         * WebView/WebHTMLView.mm:
3600         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3601         Ditto.
3602         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3603
3604         * WebView/WebImmediateActionController.mm:
3605         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3606         go down to the document and then back to the frame.
3607         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3608         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3609         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3610
3611         * WebView/WebJSPDFDoc.mm:
3612         (jsPDFDocInitialize): Removed some unneeded type casting.
3613         (jsPDFDocFinalize): Ditto.
3614         (jsPDFDocPrint): Use a bridging cast.
3615
3616         * WebView/WebPDFView.mm:
3617         (_applicationInfoForMIMEType): Use bridging casts.
3618
3619         * WebView/WebPreferences.mm:
3620         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3621         instead of methods from WebNSDictionaryExtras.
3622         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3623         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3624         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3625         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3626         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3627
3628         * WebView/WebView.mm:
3629         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3630         (-[WebView _addToAllWebViewsSet]): Ditto.
3631         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3632         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3633         so it can be called from WebViewData methods.
3634
3635         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3636         method, _windowVisibilityChanged:.
3637
3638         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3639         called from WebViewData methods.
3640
3641 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3642
3643         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3644         https://bugs.webkit.org/show_bug.cgi?id=188323
3645
3646         Reviewed by Simon Fraser.
3647
3648         * WebCoreSupport/WebContextMenuClient.mm:
3649         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3650         * WebView/WebFrame.mm:
3651         (-[WebFrame _paintBehaviorForDestinationContext:]):
3652         (-[WebFrame _drawRect:contentsOnly:]):
3653         * WebView/WebHTMLView.mm:
3654         (imageFromRect):
3655         (selectionImage):
3656
3657 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3658
3659         Add support for microtasks in workers
3660         https://bugs.webkit.org/show_bug.cgi?id=188246
3661
3662         Reviewed by Darin Adler.
3663
3664         Rename JSMainThreadExecState.h to JSExecState.h.
3665
3666         * DOM/DOMAttr.mm:
3667         * DOM/DOMBlob.mm:
3668         * DOM/DOMCDATASection.mm:
3669         * DOM/DOMCSSCharsetRule.mm:
3670         * DOM/DOMCSSFontFaceRule.mm:
3671         * DOM/DOMCSSImportRule.mm:
3672         * DOM/DOMCSSMediaRule.mm:
3673         * DOM/DOMCSSPageRule.mm:
3674         * DOM/DOMCSSPrimitiveValue.mm:
3675         * DOM/DOMCSSRule.mm:
3676         * DOM/DOMCSSRuleList.mm:
3677         * DOM/DOMCSSStyleDeclaration.mm:
3678         * DOM/DOMCSSStyleRule.mm:
3679         * DOM/DOMCSSStyleSheet.mm:
3680         * DOM/DOMCSSUnknownRule.mm:
3681         * DOM/DOMCSSValue.mm:
3682         * DOM/DOMCSSValueList.mm:
3683         * DOM/DOMCharacterData.mm:
3684         * DOM/DOMComment.mm:
3685         * DOM/DOMCounter.mm:
3686         * DOM/DOMDocument.mm:
3687         * DOM/DOMDocumentFragment.mm:
3688         * DOM/DOMDocumentType.mm:
3689         * DOM/DOMElement.mm:
3690         * DOM/DOMEvent.mm:
3691         * DOM/DOMFile.mm:
3692         * DOM/DOMFileList.mm:
3693         * DOM/DOMHTML.mm:
3694         * DOM/DOMHTMLAnchorElement.mm:
3695         * DOM/DOMHTMLAppletElement.mm:
3696         * DOM/DOMHTMLAreaElement.mm:
3697         * DOM/DOMHTMLBRElement.mm:
3698         * DOM/DOMHTMLBaseElement.mm:
3699         * DOM/DOMHTMLBaseFontElement.mm:
3700         * DOM/DOMHTMLBodyElement.mm:
3701         * DOM/DOMHTMLButtonElement.mm:
3702         * DOM/DOMHTMLCanvasElement.mm:
3703         * DOM/DOMHTMLCollection.mm:
3704         * DOM/DOMHTMLDListElement.mm:
3705         * DOM/DOMHTMLDirectoryElement.mm:
3706         * DOM/DOMHTMLDivElement.mm:
3707         * DOM/DOMHTMLDocument.mm:
3708         * DOM/DOMHTMLElement.mm:
3709         * DOM/DOMHTMLEmbedElement.mm:
3710         * DOM/DOMHTMLFieldSetElement.mm:
3711         * DOM/DOMHTMLFontElement.mm:
3712         * DOM/DOMHTMLFormElement.mm:
3713         * DOM/DOMHTMLFrameElement.mm:
3714         * DOM/DOMHTMLFrameSetElement.mm:
3715         * DOM/DOMHTMLHRElement.mm:
3716         * DOM/DOMHTMLHeadElement.mm:
3717         * DOM/DOMHTMLHeadingElement.mm:
3718         * DOM/DOMHTMLHtmlElement.mm:
3719         * DOM/DOMHTMLIFrameElement.mm:
3720         * DOM/DOMHTMLImageElement.mm:
3721         * DOM/DOMHTMLInputElement.mm:
3722         * DOM/DOMHTMLLIElement.mm:
3723         * DOM/DOMHTMLLabelElement.mm:
3724         * DOM/DOMHTMLLegendElement.mm:
3725         * DOM/DOMHTMLLinkElement.mm:
3726         * DOM/DOMHTMLMapElement.mm:
3727         * DOM/DOMHTMLMarqueeElement.mm:
3728         * DOM/DOMHTMLMediaElement.mm:
3729         * DOM/DOMHTMLMenuElement.mm:
3730         * DOM/DOMHTMLMetaElement.mm:
3731         * DOM/DOMHTMLModElement.mm:
3732         * DOM/DOMHTMLOListElement.mm:
3733         * DOM/DOMHTMLObjectElement.mm:
3734         * DOM/DOMHTMLOptGroupElement.mm:
3735         * DOM/DOMHTMLOptionElement.mm:
3736         * DOM/DOMHTMLOptionsCollection.mm:
3737         * DOM/DOMHTMLParagraphElement.mm:
3738         * DOM/DOMHTMLParamElement.mm:
3739         * DOM/DOMHTMLPreElement.mm:
3740         * DOM/DOMHTMLQuoteElement.mm:
3741         * DOM/DOMHTMLScriptElement.mm:
3742         * DOM/DOMHTMLSelectElement.mm:
3743         * DOM/DOMHTMLStyleElement.mm:
3744         * DOM/DOMHTMLTableCaptionElement.mm:
3745         * DOM/DOMHTMLTableCellElement.mm:
3746         * DOM/DOMHTMLTableColElement.mm:
3747         * DOM/DOMHTMLTableElement.mm:
3748         * DOM/DOMHTMLTableRowElement.mm:
3749         * DOM/DOMHTMLTableSectionElement.mm:
3750         * DOM/DOMHTMLTextAreaElement.mm:
3751         * DOM/DOMHTMLTitleElement.mm:
3752         * DOM/DOMHTMLUListElement.mm:
3753         * DOM/DOMHTMLVideoElement.mm:
3754         * DOM/DOMImplementation.mm:
3755         * DOM/DOMKeyboardEvent.mm:
3756         * DOM/DOMMediaError.mm:
3757         * DOM/DOMMediaList.mm:
3758         * DOM/DOMMouseEvent.mm:
3759         * DOM/DOMMutationEvent.mm:
3760         * DOM/DOMNamedNodeMap.mm:
3761         * DOM/DOMNode.mm:
3762         * DOM/DOMNodeIterator.mm:
3763         * DOM/DOMNodeList.mm:
3764         * DOM/DOMOverflowEvent.mm:
3765         * DOM/DOMProcessingInstruction.mm:
3766         * DOM/DOMProgressEvent.mm:
3767         * DOM/DOMRGBColor.mm:
3768         * DOM/DOMRange.mm:
3769         * DOM/DOMRect.mm:
3770         * DOM/DOMStyleSheet.mm:
3771         * DOM/DOMStyleSheetList.mm:
3772         * DOM/DOMText.mm:
3773         * DOM/DOMTextEvent.mm:
3774         * DOM/DOMTimeRanges.mm:
3775         * DOM/DOMTokenList.mm:
3776         * DOM/DOMTreeWalker.mm:
3777         * DOM/DOMUIEvent.mm:
3778         * DOM/DOMWheelEvent.mm:
3779         * DOM/DOMXPathExpression.mm:
3780         * DOM/DOMXPathResult.mm:
3781         * DOM/ObjCEventListener.mm:
3782
3783 2018-08-03  Alex Christensen  <achristensen@webkit.org>
3784
3785         Fix spelling of "overridden"
3786         https://bugs.webkit.org/show_bug.cgi?id=188315
3787
3788         Reviewed by Darin Adler.
3789
3790         * Misc/WebKitVersionChecks.mm:
3791         (setWebKitLinkTimeVersion):
3792         (WebKitLinkTimeVersion):
3793         * Plugins/WebBaseNetscapePluginView.mm:
3794         (-[WebBaseNetscapePluginView handleMouseMoved:]):
3795         * WebCoreSupport/PopupMenuMac.mm:
3796         (PopupMenuMac::populate):
3797
3798 2018-08-01  Nan Wang  <n_wang@apple.com>
3799
3800         AX: AOM: Add ARIA IDL Attribute Reflection
3801         https://bugs.webkit.org/show_bug.cgi?id=184676
3802         <rdar://problem/39476882>
3803
3804         Reviewed by Chris Fleizach.
3805
3806         * WebView/WebPreferenceKeysPrivate.h:
3807         * WebView/WebPreferences.mm:
3808         (+[WebPreferences initialize]):
3809         (-[WebPreferences ariaReflectionEnabled]):
3810         (-[WebPreferences setAriaReflectionEnabled:]):
3811         * WebView/WebPreferencesPrivate.h:
3812         * WebView/WebView.mm:
3813         (-[WebView _preferencesChanged:]):
3814
3815 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
3816
3817         Shrink GraphicsLayerCA
3818         https://bugs.webkit.org/show_bug.cgi?id=188141
3819
3820         Reviewed by Zalan Bujtas.
3821
3822         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
3823         * moving all the clone-related stuff into the lazily-allocated m_layerClones
3824         * moving all the animation-related stuff into the lazily-allocated m_animations
3825         * making enums be 8-bit
3826         * re-ordering data members
3827
3828         * WebView/WebView.mm:
3829         (-[WebView _setMediaLayer:forPluginView:]):
3830
3831 2018-07-30  Rob Buis  <rbuis@igalia.com>
3832
3833         Merge PlatformCookieJar functions into NetworkStorageSession
3834         https://bugs.webkit.org/show_bug.cgi?id=188137
3835
3836         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
3837
3838         Reviewed by Alex Christensen.
3839
3840         * WebCoreSupport/WebPlatformStrategies.mm:
3841         (WebPlatformStrategies::cookiesForDOM):
3842         (WebPlatformStrategies::setCookiesFromDOM):
3843         (WebPlatformStrategies::cookiesEnabled):
3844         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3845         (WebPlatformStrategies::getRawCookies):
3846         (WebPlatformStrategies::deleteCookie):
3847         * WebView/WebPreferences.mm:
3848         (+[WebPreferences _clearNetworkLoaderSession]):
3849
3850 2018-07-28  Darin Adler  <darin@apple.com>
3851
3852         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
3853         https://bugs.webkit.org/show_bug.cgi?id=188140
3854
3855         Reviewed by Sam Weinig.
3856
3857         * WebView/WebImmediateActionController.mm:
3858         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
3859         new DictionaryLookup function that returns a tuple instead of using an out argument.
3860
3861 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
3862
3863         [INTL] Remove INTL sub-feature compile flags
3864         https://bugs.webkit.org/show_bug.cgi?id=188081
3865
3866         Reviewed by Michael Catanzaro.
3867
3868         * Configurations/FeatureDefines.xcconfig:
3869
3870 2018-07-26  Commit Queue  <commit-queue@webkit.org>
3871
3872         Unreviewed, rolling out r234181 and r234189.
3873         https://bugs.webkit.org/show_bug.cgi?id=188075
3874
3875         These are not needed right now (Requested by thorton on
3876         #webkit).
3877
3878         Reverted changesets:
3879
3880         "Enable Web Content Filtering on watchOS"
3881         https://bugs.webkit.org/show_bug.cgi?id=187979
3882         https://trac.webkit.org/changeset/234181
3883
3884         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
3885         https://bugs.webkit.org/show_bug.cgi?id=187985
3886         https://trac.webkit.org/changeset/234189
3887
3888 2018-07-26  Timothy Hatcher  <timothy@apple.com>
3889
3890         Use the Page's appearance when converting pasteboard attributed strings.
3891         https://bugs.webkit.org/show_bug.cgi?id=188067
3892         rdar://problem/42632246
3893
3894         Reviewed by Wenson Hsieh.
3895
3896         * WebCoreSupport/WebEditorClient.mm:
3897         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
3898
3899 2018-07-25  Chris Dumez  <cdumez@apple.com>
3900
3901         navigator.userAgent may return outdated value after webView.customUserAgent is set
3902         https://bugs.webkit.org/show_bug.cgi?id=188009
3903         <rdar://problem/42566456>
3904
3905         Reviewed by Alex Christensen.
3906
3907         Let the page know when the user agent changes.
3908
3909         * WebView/WebView.mm:
3910         (-[WebView _preferencesChanged:]):
3911         (-[WebView setApplicationNameForUserAgent:]):
3912         (-[WebView _invalidateUserAgentCache]):
3913         (-[WebView setCustomUserAgent:]):
3914         * WebView/WebViewInternal.h:
3915
3916 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3917
3918         Enable Web Content Filtering on watchOS
3919         https://bugs.webkit.org/show_bug.cgi?id=187979
3920         <rdar://problem/42559346>
3921
3922         Reviewed by Wenson Hsieh.
3923
3924         * Configurations/FeatureDefines.xcconfig:
3925
3926 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3927
3928         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3929         https://bugs.webkit.org/show_bug.cgi?id=187846
3930
3931         Reviewed by Simon Fraser.
3932
3933         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
3934
3935         * WebView/WebHTMLView.mm:
3936         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
3937         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
3938
3939 2018-07-11  Dean Jackson  <dino@apple.com>
3940
3941         Allow removal of white backgrounds
3942         https://bugs.webkit.org/show_bug.cgi?id=187574
3943         <rdar://problem/41146792>
3944
3945         Reviewed by Simon Fraser.
3946
3947         Add a new WebPreference for punching out white backgrounds.
3948
3949         * WebView/WebPreferenceKeysPrivate.h:
3950         * WebView/WebPreferences.mm:
3951         (+[WebPreferences initialize]):
3952         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
3953         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
3954         * WebView/WebPreferencesPrivate.h:
3955         * WebView/WebView.mm:
3956         (-[WebView _preferencesChanged:]):
3957
3958 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
3959
3960         Ensure WebKit stack is ad-hoc signed
3961         https://bugs.webkit.org/show_bug.cgi?id=187667
3962
3963         Reviewed by Alexey Proskuryakov.
3964
3965         * Configurations/Base.xcconfig:
3966
3967 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
3968
3969         REGRESSION (231276): Attempting to copy an image fails
3970         https://bugs.webkit.org/show_bug.cgi?id=187212
3971         <rdar://problem/41540074>
3972
3973         Reviewed by Ryosuke Niwa.
3974
3975         Renamed methods to make it clear that one URL and one title are being passed in.
3976
3977         * WebCoreSupport/WebPlatformStrategies.h:
3978         * WebCoreSupport/WebPlatformStrategies.mm:
3979         (WebPlatformStrategies::setURL):
3980
3981 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
3982
3983         Disable cross-origin-window-policy by default
3984         https://bugs.webkit.org/show_bug.cgi?id=187509
3985
3986         Reviewed by Chris Dumez.
3987
3988         * WebView/WebPreferences.mm:
3989         (+[WebPreferences initialize]):
3990
3991 2018-07-09  Timothy Hatcher  <timothy@apple.com>
3992
3993         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3994         https://bugs.webkit.org/show_bug.cgi?id=187425
3995         rdar://problem/39948240
3996
3997         Reviewed by Tim Horton.
3998
3999         * WebView/WebView.mm:
4000         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
4001         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
4002         a call in this method to setUseDarkAppearance.
4003         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
4004         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
4005         (-[WebView _updateDefaultAppearance]): Deleted.
4006         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
4007
4008 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
4009
4010         Shrink various loading-related enums to shrink CachedResource
4011         https://bugs.webkit.org/show_bug.cgi?id=187443
4012
4013         Reviewed by Chris Dumez.
4014
4015         * WebCoreSupport/WebFrameLoaderClient.mm:
4016         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
4017         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
4018         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
4019         (WebFrameLoaderClient::dispatchWillSendRequest):
4020         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
4021         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
4022         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
4023         (WebFrameLoaderClient::updateGlobalHistory):
4024         (WebFrameLoaderClient::canHandleRequest const):
4025         * WebView/WebDataSource.mm:
4026         (-[WebDataSource initialRequest]):
4027         (-[WebDataSource request]):
4028
4029 2018-07-09  Commit Queue  <commit-queue@webkit.org>
4030
4031         Unreviewed, rolling out r233612.
4032         https://bugs.webkit.org/show_bug.cgi?id=187475
4033
4034         Revision caused the api test LinkColorWithSystemAppearance to
4035         fail on all systems. (Requested by Truitt on #webkit).
4036
4037         Reverted changeset:
4038
4039         "Semantic colors don't update when accessibility Increase
4040         Contrast mode is enabled."
4041         https://bugs.webkit.org/show_bug.cgi?id=187425
4042         https://trac.webkit.org/changeset/233612
4043
4044 2018-07-06  Timothy Hatcher  <timothy@apple.com>
4045
4046         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
4047         https://bugs.webkit.org/show_bug.cgi?id=187425
4048         rdar://problem/39948240
4049
4050         Reviewed by Tim Horton.
4051
4052         * WebView/WebView.mm: