[WTF] Remove StaticLock
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2
3         [WTF] Remove StaticLock
4         https://bugs.webkit.org/show_bug.cgi?id=184332
5
6         Reviewed by Mark Lam.
7
8         * DOM/DOMInternal.mm:
9         (getDOMWrapper):
10         (addDOMWrapper):
11         (removeDOMWrapper):
12
13 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
14
15         Failures from mach port reference handling should be fatal
16         https://bugs.webkit.org/show_bug.cgi?id=184202
17         <rdar://problem/37771114>
18
19         Reviewed by Anders Carlsson.
20
21         * Plugins/Hosted/NetscapePluginHostManager.mm:
22         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
23
24 2018-04-03  Andy Estes  <aestes@apple.com>
25
26         [Mac] Prioritize file promises over filenames during drag and drop
27         https://bugs.webkit.org/show_bug.cgi?id=184237
28         <rdar://problem/38278076>
29
30         Reviewed by Wenson Hsieh.
31
32         * WebView/WebView.mm:
33         (-[WebView performDragOperation:]):
34
35 2018-04-03  Chris Dumez  <cdumez@apple.com>
36
37         Drop MainFrame class
38         https://bugs.webkit.org/show_bug.cgi?id=184191
39
40         Reviewed by Darin Adler.
41
42         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
43         relationship between the Page and the MainFrame.
44
45         This is ground work for introducing LocalFrame / RemoteFrame concepts.
46
47         * WebCoreSupport/WebDragClient.mm:
48         * WebCoreSupport/WebFrameLoaderClient.mm:
49         * WebCoreSupport/WebInspectorClient.mm:
50         * WebCoreSupport/WebPlatformStrategies.mm:
51         * WebCoreSupport/WebPluginInfoProvider.mm:
52         * WebView/WebFrame.mm:
53         * WebView/WebFrameView.mm:
54         * WebView/WebHTMLView.mm:
55         * WebView/WebView.mm:
56
57 2018-04-02  Jer Noble  <jer.noble@apple.com>
58
59         Enable Legacy EME for all WebKit & WebKitLegacy clients
60         https://bugs.webkit.org/show_bug.cgi?id=184018
61         <rdar://problem/34887387>
62
63         Reviewed by Eric Carlson.
64
65         * WebView/WebPreferences.mm:
66         (+[WebPreferences initialize]):
67
68 2018-03-29  JF Bastien  <jfbastien@apple.com>
69
70         Use Forward.h instead of forward-declaring WTF::String
71         https://bugs.webkit.org/show_bug.cgi?id=184172
72         <rdar://problem/39026146>
73
74         Reviewed by Yusuke Suzuki.
75
76         As part of #184164 I'm changing WTF::String, and the forward
77         declarations are just wrong because I'm making it templated. We
78         should use Forward.h anyways, so do that instead.
79
80         * WebView/WebScriptDebugger.h:
81
82 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
83
84         Protect against invalid mach ports returned by mach_port_request_notification
85         https://bugs.webkit.org/show_bug.cgi?id=184106
86         <rdar://problem/37865316>
87
88         Reviewed by Chris Dumez.
89
90         * Plugins/Hosted/NetscapePluginHostProxy.mm:
91         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
92         and clean up if it experienced an error.
93         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
94
95 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
96
97         Avoid uninitialized mach ports
98         https://bugs.webkit.org/show_bug.cgi?id=184090
99         <rdar://problem/37261129>
100
101         Reviewed by Chris Dumez.
102
103         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
104         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
105         there is a potential for us to try to use invalid ports.
106
107         We should always check return values, and ensure that the mach port variables we seek to initialize are
108         kept in a valid state.
109
110         Reviewed by Chris Dumez.
111
112         * Plugins/Hosted/NetscapePluginHostManager.h:
113         * Plugins/Hosted/NetscapePluginHostManager.mm:
114         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
115         port is passed to an API function.
116         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
117         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
118         * Plugins/Hosted/NetscapePluginHostProxy.h:
119         * Plugins/Hosted/NetscapePluginHostProxy.mm:
120         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
121         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
122         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
123         (WKPCStatusText): Ditto.
124         (WKPCLoadURL): Ditto.
125         (WKPCCancelLoadURL): Ditto.
126         (WKPCInvalidateRect): Ditto.
127         (WKPCGetScriptableNPObjectReply): Ditto.
128         (WKPCBooleanReply): Ditto.
129         (WKPCBooleanAndDataReply): Ditto.
130         (WKPCInstantiatePluginReply): Ditto.
131         (WKPCGetWindowNPObject): Ditto.
132         (WKPCGetPluginElementNPObject): Ditto.
133         (WKPCForgetBrowserObject): Ditto.
134         (WKPCEvaluate): Ditto.
135         (WKPCGetStringIdentifier): Ditto.
136         (WKPCGetIntIdentifier): Ditto.
137         (WKPCInvoke): Ditto.
138         (WKPCInvokeDefault): Ditto.
139         (WKPCConstruct): Ditto.
140         (WKPCGetProperty): Ditto.
141         (WKPCSetProperty): Ditto.
142         (WKPCRemoveProperty): Ditto.
143         (WKPCHasProperty): Ditto.
144         (WKPCHasMethod): Ditto.
145         (WKPCIdentifierInfo): Ditto.
146         (WKPCEnumerate): Ditto.
147         (WKPCSetMenuBarVisible): Ditto.
148         (WKPCSetFullscreenWindowIsShowing): Ditto.
149         (WKPCSetModal): Ditto.
150         (WKPCGetCookies): Ditto.
151         (WKPCGetProxy): Ditto.
152         (WKPCSetCookies): Ditto.
153         (WKPCGetAuthenticationInfo): Ditto.
154         (WKPCConvertPoint): Ditto.
155         (WKPCLayerHostingModeChanged): Ditto.
156         (WKPCSetException): Ditto.
157
158 2018-03-26  Tim Horton  <timothy_horton@apple.com>
159
160         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
161         https://bugs.webkit.org/show_bug.cgi?id=184030
162         <rdar://problem/38895281>
163
164         Reviewed by Dan Bernstein.
165
166         * Configurations/Base.xcconfig:
167
168 2018-03-26  Chris Dumez  <cdumez@apple.com>
169
170         Use SecurityOriginData more consistently in Service Worker code
171         https://bugs.webkit.org/show_bug.cgi?id=183969
172
173         Reviewed by Darin Adler.
174
175         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
176
177         * Storage/WebDatabaseManager.mm:
178         (-[WebDatabaseManager databasesWithOrigin:]):
179         (-[WebDatabaseManager deleteOrigin:]):
180         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
181         * Storage/WebDatabaseQuotaManager.mm:
182         (-[WebDatabaseQuotaManager usage]):
183         (-[WebDatabaseQuotaManager quota]):
184         (-[WebDatabaseQuotaManager setQuota:]):
185         * Storage/WebStorageManager.mm:
186         (-[WebStorageManager deleteOrigin:]):
187         * WebCoreSupport/WebSecurityOrigin.mm:
188         (-[WebSecurityOrigin databaseIdentifier]):
189         (-[WebSecurityOrigin usage]):
190         (-[WebSecurityOrigin quota]):
191         (-[WebSecurityOrigin setQuota:]):
192
193 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
194
195         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
196         https://bugs.webkit.org/show_bug.cgi?id=183911
197         <rdar://problem/38762306>
198
199         Reviewed by Youenn Fablet.
200
201         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
202
203         * WebView/WebView.mm:
204         (+[WebView initialize]):
205
206 2018-03-26  Alex Christensen  <achristensen@webkit.org>
207
208         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
209         https://bugs.webkit.org/show_bug.cgi?id=183965
210
211         Reviewed by Chris Dumez.
212
213         * WebCoreSupport/WebFrameLoaderClient.h:
214         * WebCoreSupport/WebFrameLoaderClient.mm:
215         (WebFrameLoaderClient::willCacheResponse const):
216
217 2018-03-25  Commit Queue  <commit-queue@webkit.org>
218
219         Unreviewed, rolling out r229954.
220         https://bugs.webkit.org/show_bug.cgi?id=184000
221
222         Caused many layout tests to crash on Apple High Sierra,
223         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
224         by dydz on #webkit).
225
226         Reverted changeset:
227
228         "Use SecurityOriginData more consistently in Service Worker
229         code"
230         https://bugs.webkit.org/show_bug.cgi?id=183969
231         https://trac.webkit.org/changeset/229954
232
233 2018-03-24  Chris Dumez  <cdumez@apple.com>
234
235         Use SecurityOriginData more consistently in Service Worker code
236         https://bugs.webkit.org/show_bug.cgi?id=183969
237
238         Reviewed by Darin Adler.
239
240         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
241
242         * Storage/WebDatabaseManager.mm:
243         (-[WebDatabaseManager databasesWithOrigin:]):
244         (-[WebDatabaseManager deleteOrigin:]):
245         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
246         * Storage/WebDatabaseQuotaManager.mm:
247         (-[WebDatabaseQuotaManager usage]):
248         (-[WebDatabaseQuotaManager quota]):
249         (-[WebDatabaseQuotaManager setQuota:]):
250         * Storage/WebStorageManager.mm:
251         (-[WebStorageManager deleteOrigin:]):
252         * WebCoreSupport/WebSecurityOrigin.mm:
253         (-[WebSecurityOrigin databaseIdentifier]):
254         (-[WebSecurityOrigin usage]):
255         (-[WebSecurityOrigin quota]):
256         (-[WebSecurityOrigin setQuota:]):
257
258 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
259
260         Fix the build
261
262         * WebView/WebView.mm:
263
264 2018-03-23  Tim Horton  <timothy_horton@apple.com>
265
266         Fix the build with no pasteboard
267         https://bugs.webkit.org/show_bug.cgi?id=183973
268
269         Reviewed by Dan Bernstein.
270
271         * Configurations/FeatureDefines.xcconfig:
272         * WebView/WebView.mm:
273         (-[WebView _requestStartDataInteraction:globalPosition:]):
274         (-[WebView _getDataInteractionData]):
275         (-[WebView _dataOperationTextIndicator]):
276         (-[WebView _dragSourceAction]):
277         (-[WebView _draggedLinkTitle]):
278         (-[WebView _draggedLinkURL]):
279         (-[WebView _draggedElementBounds]):
280         (-[WebView _enteredDataInteraction:client:global:operation:]):
281         (-[WebView _updatedDataInteraction:client:global:operation:]):
282         (-[WebView _exitedDataInteraction:client:global:operation:]):
283         (-[WebView _performDataInteraction:client:global:operation:]):
284         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
285         (-[WebView _endedDataInteraction:global:]):
286         (-[WebView _dataInteractionCaretRect]):
287         * WebView/WebViewPrivate.h:
288
289 2018-03-23  Tim Horton  <timothy_horton@apple.com>
290
291         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
292         https://bugs.webkit.org/show_bug.cgi?id=183960
293         <rdar://problem/38812356>
294
295         Reviewed by Dan Bernstein.
296
297         * Configurations/WebKitLegacy.xcconfig:
298
299 2018-03-23  Tim Horton  <timothy_horton@apple.com>
300
301         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
302         https://bugs.webkit.org/show_bug.cgi?id=183954
303         <rdar://problem/38808858>
304
305         Reviewed by Dan Bernstein.
306
307         * WebView/WebPreferences.mm:
308         (-[WebPreferences setAudioSessionCategoryOverride:]):
309
310 2018-03-23  Tim Horton  <timothy_horton@apple.com>
311
312         Adopt WK_PLATFORM_NAME in WebKitLegacy
313         https://bugs.webkit.org/show_bug.cgi?id=183948
314         <rdar://problem/38803908>
315
316         Reviewed by Dan Bernstein.
317
318         * Configurations/WebKitLegacy.xcconfig:
319         * MigrateHeaders.make:
320         * postprocess-headers.sh:
321
322 2018-03-23  Brady Eidson  <beidson@apple.com>
323
324         Go to back/forward list items after a process-swapped navigation.
325         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
326
327         Reviewed by Andy Estes.
328
329         * WebView/WebView.mm:
330         (-[WebView _loadBackForwardListFromOtherView:]):
331         (-[WebView goToBackForwardItem:]):
332
333 2018-03-22  Tim Horton  <timothy_horton@apple.com>
334
335         Improve readability of WebCore's OTHER_LDFLAGS
336         https://bugs.webkit.org/show_bug.cgi?id=183909
337         <rdar://problem/38760992>
338
339         Reviewed by Dan Bernstein.
340
341         * Configurations/Base.xcconfig:
342         * Configurations/FeatureDefines.xcconfig:
343
344 2018-03-20  Tim Horton  <timothy_horton@apple.com>
345
346         Enable the minimal simulator feature flag when appropriate
347         https://bugs.webkit.org/show_bug.cgi?id=183807
348
349         Reviewed by Dan Bernstein.
350
351         * Configurations/FeatureDefines.xcconfig:
352
353 2018-03-20  Tim Horton  <timothy_horton@apple.com>
354
355         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
356         https://bugs.webkit.org/show_bug.cgi?id=183758
357         <rdar://problem/38017644>
358
359         Reviewed by Dan Bernstein.
360
361         * Configurations/FeatureDefines.xcconfig:
362
363 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
364
365         Clear style colors when setting default appearance
366         https://bugs.webkit.org/show_bug.cgi?id=183759
367
368         Reviewed by Tim Horton.
369
370         Colors are cached and need to be cleared and recalculated.
371         Refactor to do all style recalcs together.
372
373         * WebView/WebView.mm:
374         (-[WebView _setDefaultAppearanceAndClearStyle]):
375         (-[WebView _setUseSystemAppearance:]):
376         (-[WebView effectiveAppearanceDidChange]):
377
378 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
379
380         Unreviewed, another quick fix for r229699
381
382         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
383
384         * Configurations/FeatureDefines.xcconfig:
385
386 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
387
388         Ensure that style is updated when the effective appearance changes
389         https://bugs.webkit.org/show_bug.cgi?id=183690
390         <rdar://problem/38385900>
391
392         Reviewed by Tim Horton and Wenson Hsieh.
393
394         Respond to and respect the effective appearance changing.
395
396         * WebView/WebView.mm:
397         (-[WebView _setUseSystemAppearance:]):
398         (-[WebView effectiveAppearanceDidChange]):
399
400 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
401
402         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
403         https://bugs.webkit.org/show_bug.cgi?id=183677
404
405         Reviewed by Tim Horton.
406
407         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
408
409         * DOM/DOM.mm:
410         (-[DOMHTMLLinkElement _mediaQueryMatches]):
411
412 2018-03-14  Tim Horton  <timothy_horton@apple.com>
413
414         Fix the build after r229567
415
416         * Configurations/FeatureDefines.xcconfig:
417
418 2018-03-12  Tim Horton  <timothy_horton@apple.com>
419
420         Stop using SDK conditionals to control feature definitions
421         https://bugs.webkit.org/show_bug.cgi?id=183430
422         <rdar://problem/38251619>
423
424         Reviewed by Dan Bernstein.
425
426         * Configurations/FeatureDefines.xcconfig:
427         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
428
429 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
430
431         Runtime flag for link prefetch and remove link subresource.
432         https://bugs.webkit.org/show_bug.cgi?id=183540
433
434         Reviewed by Chris Dumez.
435
436         Remove the LINK_PREFETCH build time flag.
437
438         * Configurations/FeatureDefines.xcconfig:
439
440 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
441
442         Remove GridLayout runtime flag
443         https://bugs.webkit.org/show_bug.cgi?id=183484
444
445         Reviewed by Myles C. Maxfield.
446
447         The Grid Layout feature has been enabled by default for almost a
448         year, so I think it's time to remove the runtime flag and the
449
450         * WebView/WebPreferenceKeysPrivate.h:
451         * WebView/WebPreferences.mm:
452         (+[WebPreferences initialize]):
453         * WebView/WebPreferencesPrivate.h:
454         * WebView/WebView.mm:
455         (-[WebView _preferencesChanged:]):
456
457 2018-03-12  Antoine Quint  <graouts@apple.com>
458
459         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
460         https://bugs.webkit.org/show_bug.cgi?id=183504
461         <rdar://problem/38372965>
462
463         Reviewed by Dean Jackson and Jon Lee.
464
465         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
466         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
467
468         * WebView/WebPreferenceKeysPrivate.h:
469         * WebView/WebPreferences.mm:
470         (+[WebPreferences initialize]):
471         (-[WebPreferences setModernMediaControlsEnabled:]):
472         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
473         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
474         * WebView/WebPreferencesPrivate.h:
475         * WebView/WebView.mm:
476         (-[WebView _preferencesChanged:]):
477
478 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
479
480         Media query for default appearance
481         https://bugs.webkit.org/show_bug.cgi?id=183539
482         <rdar://problem/38326388>
483
484         Reviewed by Tim Horton.
485
486         Write a media query to evaluate appearance.
487
488         * WebView/WebView.mm:
489         (-[WebView _commonInitializationWithFrameName:groupName:]):
490         (-[WebView _setUseSystemAppearance:]):
491
492 2018-03-09  Andy Estes  <aestes@apple.com>
493
494         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
495         https://bugs.webkit.org/show_bug.cgi?id=183489
496         <rdar://problem/38267517>
497
498         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
499         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
500         to issue a sandbox extension for this directory, but for security reasons App Sandbox
501         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
502         block with a nil error and a valid file URL, but no file will actually exist at that URL.
503
504         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
505         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
506         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
507         drop destination.
508
509         Reviewed by Wenson Hsieh.
510
511         * WebView/WebView.mm:
512         (-[WebView performDragOperation:]):
513
514 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
515
516         Allow WebViews to disable system appearance
517         https://bugs.webkit.org/show_bug.cgi?id=183418
518         <rdar://problem/36975642>
519
520         Reviewed by Tim Horton.
521
522         Allow webviews to choose whether or not to follow the default system appearance.
523
524         * WebView/WebView.mm:
525         (-[WebView _setUseSystemAppearance:]):
526         (-[WebView _useSystemAppearance]):
527         * WebView/WebViewPrivate.h:
528
529 2018-03-08  Youenn Fablet  <youenn@apple.com>
530
531         libwebrtc update broke internal builds
532         https://bugs.webkit.org/show_bug.cgi?id=183454
533
534         Reviewed by Eric Carlson.
535
536         * Configurations/WebKitLegacy.xcconfig:
537
538 2018-03-08  Chris Dumez  <cdumez@apple.com>
539
540         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
541         https://bugs.webkit.org/show_bug.cgi?id=183455
542         <rdar://problem/38191749>
543
544         Reviewed by Youenn Fablet.
545
546         Add a null check for the page as we have evidence from crashes that it can be null.
547         Other functions in WebFrameNetworkingContext already null check the page as well,
548         not just the frame so this is consistent.
549
550         * WebCoreSupport/WebFrameNetworkingContext.mm:
551         (WebFrameNetworkingContext::storageSession const):
552
553 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
554
555         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
556         https://bugs.webkit.org/show_bug.cgi?id=183429
557
558         Reviewed by Mark Lam.
559
560         * DOM/DOM.mm:
561         (+[DOMNode _nodeFromJSWrapper:]):
562         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
563         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
564         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
565         * Plugins/Hosted/ProxyInstance.mm:
566         (WebKit::ProxyInstance::invokeMethod):
567         * WebView/WebView.mm:
568         (aeDescFromJSValue):
569
570 2018-03-08  Tim Horton  <timothy_horton@apple.com>
571
572         Stop linking ApplicationServices directly
573         https://bugs.webkit.org/show_bug.cgi?id=182867
574         <rdar://problem/38252142>
575
576         Reviewed by Alex Christensen.
577
578         The frameworks that we use that live inside ApplicationServices
579         have mostly moved out, so import them directly.
580
581         * Carbon/CarbonUtils.h:
582         * WebKitPrefix.h:
583         * WebView/WebHTMLView.mm:
584         * WebView/WebPDFView.mm:
585
586 2018-03-07  Tim Horton  <timothy_horton@apple.com>
587
588         Sort and separate FeatureDefines.xcconfig
589         https://bugs.webkit.org/show_bug.cgi?id=183427
590
591         Reviewed by Dan Bernstein.
592
593         * Configurations/FeatureDefines.xcconfig:
594         Sort and split FeatureDefines into paragraphs
595         (to make it easier to sort later).
596
597 2018-03-07  Youenn Fablet  <youenn@apple.com>
598
599         Match unsupported plugins based on domains and not origin
600         https://bugs.webkit.org/show_bug.cgi?id=183384
601
602         Reviewed by Chris Dumez.
603
604         * WebCoreSupport/WebPluginInfoProvider.h:
605         * WebCoreSupport/WebPluginInfoProvider.mm:
606         (WebPluginInfoProvider::getPluginInfo):
607         (WebPluginInfoProvider::getWebVisiblePluginInfo):
608
609 2018-03-05  Andy Estes  <aestes@apple.com>
610
611         [Mac] Teach WebCore::Pasteboard about file promise drags
612         https://bugs.webkit.org/show_bug.cgi?id=183314
613         <rdar://problem/38105493>
614
615         Reviewed by Darin Adler.
616
617         Added a FIXME comment.
618
619         * WebView/WebView.mm:
620         (-[WebView performDragOperation:]):
621
622 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
623
624         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
625         https://bugs.webkit.org/show_bug.cgi?id=183312
626
627         Reviewed by Mark Lam.
628
629         Remove wtf/CurrentTime.h include pragma.
630
631         * WebView/WebFrame.mm:
632         * WebView/WebPDFView.mm:
633
634 2018-03-04  Tim Horton  <timothy_horton@apple.com>
635
636         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
637         https://bugs.webkit.org/show_bug.cgi?id=183283
638         <rdar://problem/38062148>
639
640         Reviewed by Sam Weinig.
641
642         * Configurations/FeatureDefines.xcconfig:
643
644 2018-02-28  Alex Christensen  <achristensen@webkit.org>
645
646         Reduce use of NetworkingContext in WebKit
647         https://bugs.webkit.org/show_bug.cgi?id=183213
648
649         Reviewed by Brady Eidson.
650
651         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
652         (WebKit::NetscapePluginInstanceProxy::getProxy):
653         * Plugins/WebNetscapePluginView.mm:
654         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
655
656 2018-02-17  Darin Adler  <darin@apple.com>
657
658         Prepare for ExtendedColor changes (first step)
659         https://bugs.webkit.org/show_bug.cgi?id=182904
660
661         Reviewed by Sam Weinig.
662
663         * Misc/WebKitNSStringExtras.mm:
664         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
665
666 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
667
668         Remove currentTime() / currentTimeMS()
669         https://bugs.webkit.org/show_bug.cgi?id=183052
670
671         Reviewed by Mark Lam.
672
673         * WebCoreSupport/WebFrameLoaderClient.h:
674         * WebCoreSupport/WebFrameLoaderClient.mm:
675         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
676
677 2018-02-16  Youenn Fablet  <youenn@apple.com>
678
679         Allow specifying which plug-ins are supported
680         https://bugs.webkit.org/show_bug.cgi?id=182748
681
682         Reviewed by Chris Dumez.
683
684         * WebCoreSupport/WebPluginInfoProvider.h:
685         * WebCoreSupport/WebPluginInfoProvider.mm:
686         (WebPluginInfoProvider::getPluginInfo):
687         (WebPluginInfoProvider::getWebVisiblePluginInfo):
688
689 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
690
691         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
692         https://bugs.webkit.org/show_bug.cgi?id=182882
693         <rdar://problem/35672661>
694
695         Reviewed by Dan Bernstein.
696
697         Make sure the smart pointer hold the collection of subviews lives at least as
698         long as the loop using it.
699
700         * WebView/WebHTMLView.mm:
701         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
702
703 2018-02-14  Daniel Bates  <dabates@apple.com>
704
705         Disallow cross-origin subresources from asking for credentials
706         https://bugs.webkit.org/show_bug.cgi?id=182579
707         <rdar://problem/36162271>
708
709         Reviewed by Andy Estes.
710
711         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
712         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
713
714         * WebView/WebPreferenceKeysPrivate.h:
715         * WebView/WebPreferences.mm:
716         (+[WebPreferences initialize]):
717         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
718         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
719         * WebView/WebPreferencesPrivate.h:
720         * WebView/WebView.mm:
721         (-[WebView _preferencesChanged:]):
722
723 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
724
725         Remove ForwardingHeaders directory from WebKitLegacy/mac.
726         https://bugs.webkit.org/show_bug.cgi?id=182738
727
728         Reviewed by Darin Adler.
729
730         * ForwardingHeaders/collector/handles/Global.h: Removed.
731         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
732         * ForwardingHeaders/runtime/Completion.h: Removed.
733         * ForwardingHeaders/runtime/Error.h: Removed.
734         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
735         * ForwardingHeaders/runtime/JSFunction.h: Removed.
736         * ForwardingHeaders/runtime/JSLock.h: Removed.
737         * ForwardingHeaders/runtime/JSObject.h: Removed.
738         * ForwardingHeaders/runtime/JSString.h: Removed.
739         * ForwardingHeaders/runtime/Protect.h: Removed.
740         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
741
742 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
743
744         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
745         https://bugs.webkit.org/show_bug.cgi?id=182641
746
747         Reviewed by Dan Bernstein.
748
749         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
750         https://trac.webkit.org/changeset/228308.
751
752         * WebView/WebVideoFullscreenController.h:
753         * WebView/WebVideoFullscreenHUDWindowController.mm:
754         * WebView/WebWindowAnimation.h:
755         * WebView/WebWindowAnimation.mm:
756         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
757         (WebCore::scaledRect): Deleted.
758         (WebCore::squaredDistance): Deleted.
759
760 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
761
762         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
763
764         * WebView/WebWindowAnimation.mm:
765         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
766
767 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
768
769         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
770         https://bugs.webkit.org/show_bug.cgi?id=182615
771
772         Reviewed by Eric Carlson.
773
774         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
775         Ideally, we should not reference NSApp in WebCore.
776
777         * WebView/WebFullScreenController.mm:
778         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
779         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
780         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
781         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
782         * WebView/WebView.mm:
783         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
784         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
785
786 2018-01-13  Darin Adler  <darin@apple.com>
787
788         Event improvements
789         https://bugs.webkit.org/show_bug.cgi?id=179591
790
791         Reviewed by Chris Dumez.
792
793         * DOM/DOMWheelEvent.mm:
794         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
795         Call initWebKitWheelEvent.
796
797         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
798         * WebCoreSupport/WebInspectorClient.mm: Ditto.
799         * WebView/WebFrame.mm: Ditto.
800
801         * WebView/WebHTMLView.mm:
802         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
803         underlyingPlatformEvent.
804         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
805
806         * WebView/WebScriptWorld.mm:
807         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
808
809         * WebView/WebView.mm: Removed include of ScriptValue.h.
810
811 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
812
813         Remove WebCore/ForwardingHeaders directory
814         https://bugs.webkit.org/show_bug.cgi?id=182347
815
816         Reviewed by Keith Miller.
817
818         * Carbon/CarbonWindowAdapter.mm:
819         * DOM/WebDOMOperations.mm:
820         * History/WebBackForwardList.mm:
821         * History/WebHistoryItem.mm:
822         * Misc/WebCache.mm:
823         * Misc/WebElementDictionary.mm:
824         * Misc/WebIconDatabase.mm:
825         * Misc/WebStringTruncator.mm:
826         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
827         * Plugins/Hosted/ProxyInstance.mm:
828         * Plugins/Hosted/ProxyRuntimeObject.mm:
829         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
830         * Plugins/WebBaseNetscapePluginView.mm:
831         * Plugins/WebBasePluginPackage.mm:
832         * Plugins/WebNetscapePluginStream.mm:
833         * Plugins/WebNetscapePluginView.mm:
834         * Plugins/WebPluginController.mm:
835         * WebCoreSupport/WebEditorClient.mm:
836         * WebCoreSupport/WebFrameLoaderClient.mm:
837         * WebCoreSupport/WebInspectorClient.h:
838         * WebCoreSupport/WebInspectorClient.mm:
839         * WebView/WebDataSource.mm:
840         * WebView/WebFrame.mm:
841         * WebView/WebHTMLRepresentation.mm:
842         * WebView/WebHTMLView.mm:
843         * WebView/WebPreferences.mm:
844         * WebView/WebScriptDebugDelegate.mm:
845         * WebView/WebScriptDebugger.h:
846         * WebView/WebTextIterator.mm:
847         * WebView/WebView.mm:
848         * WebView/WebViewData.mm:
849
850 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
851
852         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
853         https://bugs.webkit.org/show_bug.cgi?id=182312
854
855         Reviewed by Michael Catanzaro.
856
857         * WebKitPrefix.h:
858
859 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
860
861         [WebAuthN] Add a compile-time feature flag
862         https://bugs.webkit.org/show_bug.cgi?id=182211
863         <rdar://problem/36936365>
864
865         Reviewed by Brent Fulgham.
866
867         * Configurations/FeatureDefines.xcconfig:
868
869 2018-01-27  Dan Bernstein  <mitz@apple.com>
870
871         HaveInternalSDK includes should be "#include?"
872         https://bugs.webkit.org/show_bug.cgi?id=179670
873
874         * Configurations/Base.xcconfig:
875
876 2018-01-24  Alex Christensen  <achristensen@webkit.org>
877
878         Remove unused QTKit preference
879         https://bugs.webkit.org/show_bug.cgi?id=181968
880
881         Reviewed by Alexey Proskuryakov.
882
883         * WebView/WebPreferenceKeysPrivate.h:
884         * WebView/WebPreferences.mm:
885         (+[WebPreferences initialize]):
886         (-[WebPreferences setQTKitEnabled:]): Deleted.
887         (-[WebPreferences isQTKitEnabled]): Deleted.
888         * WebView/WebPreferencesPrivate.h:
889         * WebView/WebView.mm:
890         (-[WebView _preferencesChanged:]):
891
892 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
893
894         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
895         https://bugs.webkit.org/show_bug.cgi?id=182037
896         <rdar://problem/36747812>
897
898         Reviewed by Ryosuke Niwa.
899
900         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
901         for more details.
902
903         * WebView/WebHTMLRepresentation.mm:
904         (-[WebHTMLRepresentation elementWithName:inForm:]):
905         (-[WebHTMLRepresentation controlsInForm:]):
906
907 2018-01-23  Alex Christensen  <achristensen@webkit.org>
908
909         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
910         https://bugs.webkit.org/show_bug.cgi?id=181961
911
912         Reviewed by Michael Catanzaro.
913
914         * WebView/WebPreferences.mm:
915
916 2018-01-23  Commit Queue  <commit-queue@webkit.org>
917
918         Unreviewed, rolling out r227437.
919         https://bugs.webkit.org/show_bug.cgi?id=182011
920
921         broke build (Requested by alexchristensen on #webkit).
922
923         Reverted changeset:
924
925         "Remove unused QTKit preference"
926         https://bugs.webkit.org/show_bug.cgi?id=181968
927         https://trac.webkit.org/changeset/227437
928
929 2018-01-23  Alex Christensen  <achristensen@webkit.org>
930
931         Remove unused QTKit preference
932         https://bugs.webkit.org/show_bug.cgi?id=181968
933
934         Reviewed by Alexey Proskuryakov.
935
936         * WebView/WebPreferenceKeysPrivate.h:
937         * WebView/WebPreferences.mm:
938         (+[WebPreferences initialize]):
939         (-[WebPreferences setQTKitEnabled:]): Deleted.
940         (-[WebPreferences isQTKitEnabled]): Deleted.
941         * WebView/WebPreferencesPrivate.h:
942         * WebView/WebView.mm:
943         (-[WebView _preferencesChanged:]):
944
945 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
946
947         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
948         https://bugs.webkit.org/show_bug.cgi?id=181960
949         <rdar://problem/36431678>
950
951         Reviewed by Tim Horton.
952
953         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
954         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
955         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
956
957         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
958         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
959         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
960
961         * WebView/WebView.mm:
962         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
963
964 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
965
966         Turning off custom pasteboard data doesn't actually turn it off in WK2
967         https://bugs.webkit.org/show_bug.cgi?id=181920
968         <rdar://problem/36686429>
969
970         Reviewed by Wenson Hsieh.
971
972         Always disable custom pasteboard data in WebKit1. See r226156 for details.
973
974         * WebView/WebPreferences.mm:
975         (+[WebPreferences initialize]):
976         * WebView/WebView.mm:
977         (-[WebView _preferencesChanged:]):
978
979 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
980
981         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
982         https://bugs.webkit.org/show_bug.cgi?id=181918
983
984         Reviewed by Tim Horton.
985
986         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
987
988         * Configurations/FeatureDefines.xcconfig:
989
990 2018-01-20  Andy Estes  <aestes@apple.com>
991
992         [Apple Pay] Stop eagerly loading PassKit.framework
993         https://bugs.webkit.org/show_bug.cgi?id=181911
994         <rdar://problem/36555369>
995
996         Reviewed by Tim Horton.
997
998         * WebCoreSupport/WebPaymentCoordinatorClient.h:
999         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1000         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1001
1002         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1003
1004 2018-01-19  Dean Jackson  <dino@apple.com>
1005
1006         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1007         https://bugs.webkit.org/show_bug.cgi?id=181817
1008         <rdar://problem/35274055>
1009
1010         Reviewed by Simon Fraser.
1011
1012         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1013
1014         * Misc/WebKitVersionChecks.h:
1015         * WebView/WebView.mm:
1016         (-[WebView _commonInitializationWithFrameName:groupName:]):
1017
1018 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1019
1020         Remove unused WebViewPrivate _allowCookies
1021         https://bugs.webkit.org/show_bug.cgi?id=181812
1022
1023         Reviewed by Tim Horton.
1024
1025         * WebView/WebView.mm:
1026         (+[WebView _setAllowCookies:]): Deleted.
1027         (+[WebView _allowCookies]): Deleted.
1028         * WebView/WebViewPrivate.h:
1029
1030 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1031
1032         Build fix, remove a call to -[NSWindow setOneShot:]
1033         https://bugs.webkit.org/show_bug.cgi?id=181809
1034
1035         Reviewed by Tim Horton.
1036
1037         * WebView/WebTextCompletionController.mm:
1038         (-[WebTextCompletionController _buildUI]):
1039
1040 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1041
1042         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1043
1044         * Carbon/HIWebView.mm:
1045         (overrideCGContext):
1046         (restoreCGContext):
1047
1048 2018-01-18  Dan Bernstein  <mitz@apple.com>
1049
1050         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1051         https://bugs.webkit.org/show_bug.cgi?id=181803
1052
1053         Reviewed by Tim Horton.
1054
1055         * Configurations/Base.xcconfig: Updated.
1056         * Configurations/DebugRelease.xcconfig: Ditto.
1057         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1058         * Configurations/Version.xcconfig: Updated.
1059         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1060           useful for defining settings that depend on the target macOS version.
1061
1062 2018-01-17  Youenn Fablet  <youenn@apple.com>
1063
1064         Put fetch Request.keepalive behind a runtime flag
1065         https://bugs.webkit.org/show_bug.cgi?id=181592
1066
1067         Reviewed by Chris Dumez.
1068
1069         * WebView/WebPreferenceKeysPrivate.h:
1070         * WebView/WebPreferences.mm:
1071         (+[WebPreferences initialize]):
1072         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1073         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1074         * WebView/WebPreferencesPrivate.h:
1075         * WebView/WebView.mm:
1076         (-[WebView _preferencesChanged:]):
1077
1078 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1079
1080         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1081         https://bugs.webkit.org/show_bug.cgi?id=181637
1082         <rdar://problem/36508471>
1083
1084         Reviewed by Tim Horton.
1085
1086         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1087
1088         * WebCoreSupport/WebEditorClient.h:
1089         * WebCoreSupport/WebEditorClient.mm:
1090         (WebEditorClient::replacementURLForResource):
1091
1092 2018-01-11  Keith Miller  <keith_miller@apple.com>
1093
1094         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1095         https://bugs.webkit.org/show_bug.cgi?id=181573
1096
1097         Reviewed by Simon Fraser.
1098
1099         * Configurations/FeatureDefines.xcconfig:
1100
1101 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1102
1103         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1104         https://bugs.webkit.org/show_bug.cgi?id=181497
1105
1106         Reviewed by Tim Horton.
1107
1108         See other ChangeLogs for more detail.
1109
1110         * WebCoreSupport/WebDragClient.h:
1111
1112 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1113
1114         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1115         https://bugs.webkit.org/show_bug.cgi?id=181523
1116         <rdar://problem/28959131>
1117
1118         Reviewed by Alex Christensen.
1119
1120         * WebView/WebImmediateActionController.mm:
1121         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1122         Apply the change made in r216652 to WebKit1's immediate action controller.
1123
1124         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1125         the startContainer of the range is in an anonymous node.
1126
1127 2018-01-11  Youenn Fablet  <youenn@apple.com>
1128
1129         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1130         https://bugs.webkit.org/show_bug.cgi?id=181480
1131
1132         Reviewed by Eric Carlson.
1133
1134         * WebView/WebPreferences.mm:
1135         (+[WebPreferences initialize]):
1136
1137 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1138
1139         Fix check-webkit-style issues with WebNSDataExtras.mm
1140         <https://webkit.org/b/181369>
1141
1142         Reviewed by Alex Christensen.
1143
1144         * Misc/WebNSDataExtras.mm:
1145         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1146         (-[NSData _webkit_guessedMIMETypeForXML]):
1147         (-[NSData _webkit_guessedMIMEType]):
1148         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1149         (_findEOL):
1150         (-[NSData _webkit_parseRFC822HeaderFields]):
1151         (-[NSData _web_locationAfterFirstBlankLine]):
1152         - Fix all the check-webkit-style warnings.
1153
1154 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1155
1156         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1157         <https://webkit.org/b/181256>
1158         <rdar://problem/36281730>
1159
1160         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1161         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1162         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1163           to avoid warnings from casting CFStringRef to NPNSString*.
1164           Note that CFMutableStringRef is the same as CFStringRef
1165           without the const modifier, hence its use in the const_cast<>
1166           above.
1167
1168 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1169
1170         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1171         <https://webkit.org/b/181256>
1172         <rdar://problem/36281730>
1173
1174         * Carbon/HIWebView.mm:
1175         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1176         checked_cf_cast<CFRunLoopRef>() to fix warning.
1177
1178 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1179
1180         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1181         <https://webkit.org/b/181256>
1182         <rdar://problem/36281730>
1183
1184         Reviewed by Darin Adler.
1185
1186         * Carbon/CarbonUtils.m:
1187         (PoolCleaner):
1188         - Use #pragmas to ignore -Wcast-qual warnings when using a
1189           C-style cast from CFTypeRef to CFRunloopRef.
1190         * Carbon/CarbonWindowFrame.m:
1191         (-[CarbonWindowFrame title]):
1192         - Use #pragmas to ignore -Wcast-qual warnings when using a
1193           C-style cast from CFStringRef to NSString *.
1194         * Carbon/HIViewAdapter.m:
1195         (+[HIViewAdapter getHIViewForNSView:]):
1196         - Use #pragmas to ignore -Wcast-qual warnings when using a
1197           C-style cast from CFTypeRef to HIViewRef.
1198         * Configurations/Base.xcconfig:
1199         (WARNING_CFLAGS): Add -Wcast-qual.
1200         * Misc/WebElementDictionary.mm:
1201         (-[WebElementDictionary objectForKey:]):
1202         - Use static_cast<SEL>(const_cast<void*>()) to fix
1203           warning.
1204         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1205         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1206         (-[NSData _webkit_guessedMIMETypeForXML]):
1207         (-[NSData _webkit_guessedMIMEType]):
1208         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1209         (_findEOL):
1210         (-[NSData _webkit_parseRFC822HeaderFields]):
1211         (-[NSData _web_startsWithBlankLine]):
1212         (-[NSData _web_locationAfterFirstBlankLine]):
1213         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1214           type to Objective-C++.  This fixes the warnings about
1215           discarding the `const` modifier when casing from CFStringRef
1216           to NSString * because in older clang versions, -Wcast-qual was
1217           completely broken when compiling C++ and Objective-C++ source
1218           files.  In newer clang versions, discarding the `const`
1219           modifier for toll-free bridged types is ignored when compiling
1220           Objective-C++ source.
1221         - Update copyright and license header.
1222         - Use reinterpret_cast<> and static_cast<> to fix warnings
1223           unrelated to (NSString *) C-style casts.
1224         - Replace use of MIN() macro with std::min<> template functions.
1225         - Fix location of `*` for local variables modified above.
1226         * Plugins/Hosted/NetscapePluginHostManager.mm:
1227         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1228         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1229         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1230         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1231           warnings.
1232         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1233         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1234         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1235           to fix warning.
1236         * Plugins/Hosted/ProxyInstance.mm:
1237         (WebKit::ProxyInstance::invoke):
1238         - Use static_cast<char*>(const_cast<void*>()) to fix
1239           warning when using -[NSData bytes].
1240         (WebKit::ProxyInstance::fieldValue const):
1241         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1242           to fix warning when using CFDataGetBytePtr().
1243         * Plugins/Hosted/WebTextInputWindowController.m:
1244         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1245         - Use #pragma to ignore -Wcast-qual warning since there
1246           is not a good way to avoid this warning in Objective-C.
1247         * Plugins/WebNetscapePluginStream.mm:
1248         (WebNetscapePluginStream::deliverData):
1249         - Use const_cast<void*>() to fix warning when using
1250           -[NSData bytes].
1251         * Plugins/WebNetscapePluginView.mm:
1252         (-[WebNetscapePluginView _createPlugin]):
1253         - Change C-style cast to const_cast<char*>() to fix
1254           warning.
1255         * WebCoreSupport/WebChromeClient.mm:
1256         (WebChromeClient::wrapCryptoKey const):
1257         (WebChromeClient::unwrapCryptoKey const):
1258         - Change C-style cast to
1259           static_cast<uint8_t*>(const_cast<void*>() to fix
1260           warning.
1261         * WebView/WebPDFView.mm:
1262         (_applicationInfoForMIMEType):
1263         - Change local variable type from 'NSURL *' to
1264           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1265           when calling -[NSURL path].
1266
1267 2018-01-05  Dan Bernstein  <mitz@apple.com>
1268
1269         Fixed the build following AppKit API deprecations in a recent SDKs
1270
1271         * WebView/WebFullScreenController.mm:
1272         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1273         (-[WebFullScreenController exitFullScreen]): Ditto.
1274         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1275         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1276         * WebView/WebHTMLView.mm:
1277         (-[WebHTMLView drawRect:]): Ditto.
1278         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1279         (-[WebHTMLView knowsPageRange:]): Ditto.
1280         * WebView/WebView.mm:
1281         (LayerFlushController::flushLayers): Ditto.
1282
1283 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1284
1285         [Attachment Support] Create attachment elements when dropping files on iOS
1286         https://bugs.webkit.org/show_bug.cgi?id=181192
1287         <rdar://problem/36280945>
1288
1289         Reviewed by Tim Horton.
1290
1291         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1292
1293         * WebCoreSupport/WebPlatformStrategies.h:
1294         * WebCoreSupport/WebPlatformStrategies.mm:
1295         (WebPlatformStrategies::informationForItemAtIndex):
1296         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1297
1298 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1299
1300         [Attachment Support] Add plumbing for starting a drag with promised blob data
1301         https://bugs.webkit.org/show_bug.cgi?id=181201
1302
1303         Reviewed by Tim Horton.
1304
1305         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1306
1307         * WebCoreSupport/WebDragClient.h:
1308
1309 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1310
1311         Add a WebAuthentication runtime feature flag
1312         https://bugs.webkit.org/show_bug.cgi?id=181220
1313         <rdar://problem/36055305>
1314
1315         Reviewed by Brent Fulgham.
1316
1317         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1318
1319         * WebView/WebPreferenceKeysPrivate.h:
1320         * WebView/WebPreferences.mm:
1321         (+[WebPreferences initialize]):
1322         (-[WebPreferences webAuthenticationEnabled]):
1323         (-[WebPreferences setWebAuthenticationEnabled:]):
1324         (-[WebPreferences credentialManagementEnabled]): Deleted.
1325         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1326         * WebView/WebPreferencesPrivate.h:
1327         * WebView/WebView.mm:
1328         (-[WebView _preferencesChanged:]):
1329
1330 2017-12-22  Jeff Miller  <jeffm@apple.com>
1331
1332         Update user-visible copyright strings to include 2018
1333         https://bugs.webkit.org/show_bug.cgi?id=181141
1334
1335         Reviewed by Dan Bernstein.
1336
1337         * Info.plist:
1338
1339 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1340
1341         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1342         https://bugs.webkit.org/show_bug.cgi?id=181188
1343
1344         Reviewed by Dan Bernstein.
1345
1346         See WebCore/ChangeLog for more detail.
1347
1348         * WebCoreSupport/WebDragClient.h:
1349         * WebCoreSupport/WebDragClient.mm:
1350         (WebDragClient::declareAndWriteAttachment): Deleted.
1351         * WebView/WebHTMLView.mm:
1352         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1353
1354 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1355
1356         Unreviewed, continue to fix build failures due to AppKit API deprecation
1357
1358         Wraps more code in -Wdeprecated-declarations.
1359
1360         * Carbon/HIWebView.mm:
1361         (overrideCGContext):
1362
1363 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1364
1365         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1366
1367         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1368
1369         * Carbon/CarbonWindowAdapter.mm:
1370         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1371         * Plugins/WebNetscapePluginView.mm:
1372         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1373         (-[WebNetscapePluginView sendDrawRectEvent:]):
1374         (-[WebNetscapePluginView drawRect:]):
1375
1376 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1377
1378         Fix build failures due to using deprecated AppKit symbols
1379         https://bugs.webkit.org/show_bug.cgi?id=181110
1380         <rdar://problem/36162865>
1381
1382         Reviewed by Dan Bernstein and Tim Horton.
1383
1384         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1385
1386         * Misc/WebKitNSStringExtras.mm:
1387         (-[NSString _web_drawAtPoint:font:textColor:]):
1388         * Misc/WebNSPasteboardExtras.h:
1389         * Misc/WebNSPasteboardExtras.mm:
1390         (+[NSPasteboard _web_writableTypesForURL]):
1391         (_createWritableTypesForImageWithoutArchive):
1392         (_createWritableTypesForImageWithArchive):
1393         (+[NSPasteboard _web_dragTypesForURL]):
1394         (-[NSPasteboard _web_bestURL]):
1395         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1396         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1397         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1398         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1399         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1400         * Panels/WebAuthenticationPanel.m:
1401         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1402         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1403         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1404         (-[WebHostedNetscapePluginView drawRect:]):
1405         * WebInspector/WebNodeHighlightView.mm:
1406         (-[WebNodeHighlightView drawRect:]):
1407         * WebView/WebFrame.mm:
1408         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1409         (-[WebFrame _drawRect:contentsOnly:]):
1410         * WebView/WebHTMLView.mm:
1411         (kit):
1412         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1413         (-[WebHTMLView _plainTextFromPasteboard:]):
1414         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1415         (+[WebHTMLView _insertablePasteboardTypes]):
1416         (+[WebHTMLView _selectionPasteboardTypes]):
1417         (-[WebHTMLView pasteboard:provideDataForType:]):
1418         (-[WebHTMLView _writeSelectionToPasteboard:]):
1419         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1420         (-[WebHTMLView validRequestorForSendType:returnType:]):
1421         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1422         (createMenuItem):
1423         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1424         (-[WebHTMLView _colorAsString:]):
1425         (-[WebHTMLView copyFont:]):
1426         * WebView/WebPDFView.mm:
1427         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1428         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1429         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1430         (-[WebPDFView pasteboardTypesForSelection]):
1431         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1432         * WebView/WebView.h:
1433         * WebView/WebView.mm:
1434         (-[WebView performDragOperation:]):
1435         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1436         (-[WebView _searchWithGoogleFromMenu:]):
1437
1438 2017-12-21  Youenn Fablet  <youenn@apple.com>
1439
1440         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1441         https://bugs.webkit.org/show_bug.cgi?id=181000
1442
1443         Reviewed by Chris Dumez.
1444
1445         * Misc/WebCache.mm:
1446         (+[WebCache addImageToCache:forURL:forFrame:]):
1447
1448 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1449
1450         Update FULLSCREEN_API feature defines.
1451         https://bugs.webkit.org/show_bug.cgi?id=181015
1452
1453         Reviewed by Tim Horton.
1454
1455         Change enabled iphone sdk for FULLSCREEN_API.
1456
1457         * Configurations/FeatureDefines.xcconfig:
1458
1459 2017-12-21  Jer Noble  <jer.noble@apple.com>
1460
1461         Add initial DOM support for Media Capabilities
1462         https://bugs.webkit.org/show_bug.cgi?id=181064
1463
1464         Reviewed by Eric Carlson.
1465
1466         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1467
1468         * WebView/WebPreferenceKeysPrivate.h:
1469         * WebView/WebPreferences.mm:
1470         (+[WebPreferences initialize]):
1471         (-[WebPreferences mediaCapabilitiesEnabled]):
1472         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1473         * WebView/WebPreferencesPrivate.h:
1474         * WebView/WebView.mm:
1475         (-[WebView _preferencesChanged:]):
1476
1477 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1478
1479         Enable picture-in-picture from inline element on suspend.
1480         https://bugs.webkit.org/show_bug.cgi?id=180942
1481         rdar://problem/34745234
1482
1483         Reviewed by Jer Noble.
1484
1485         Update signature of enterVideoFullscreenForVideoElement().
1486
1487         * WebCoreSupport/WebChromeClient.h:
1488         * WebCoreSupport/WebChromeClient.mm:
1489         (WebChromeClient::enterVideoFullscreenForVideoElement):
1490
1491 2017-12-20  Daniel Bates  <dabates@apple.com>
1492
1493         Remove Alternative Presentation Button
1494         https://bugs.webkit.org/show_bug.cgi?id=180500
1495         <rdar://problem/35891047>
1496
1497         Reviewed by Simon Fraser.
1498
1499         We no longer need the alternative presentation button.
1500
1501         * Configurations/FeatureDefines.xcconfig:
1502
1503 2017-12-19  Jer Noble  <jer.noble@apple.com>
1504
1505         Playing media elements which call "pause(); play()" will have the play promise rejected.
1506         https://bugs.webkit.org/show_bug.cgi?id=180781
1507         <rdar://problem/33191377>
1508
1509         Reviewed by Eric Carlson.
1510
1511         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1512
1513         * WebView/WebView.mm:
1514         (shouldRequireUserGestureToLoadVideo):
1515
1516 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1517
1518         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1519         https://bugs.webkit.org/show_bug.cgi?id=180977
1520
1521         Reviewed by Tim Horton.
1522
1523         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1524         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1525         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1526
1527         * WebCoreSupport/WebEditorClient.mm:
1528         (attributesForAttributedStringConversion):
1529         * WebView/WebHTMLView.mm:
1530         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1531
1532 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1533
1534         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1535
1536         Attempt to fix the following warnings:
1537
1538             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1539
1540         For the following instance variables:
1541
1542             _borderView
1543             _contentView
1544             _frame
1545             _wFlags
1546
1547         * Carbon/CarbonWindowAdapter.mm:
1548         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1549         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1550         (-[CarbonWindowAdapter _termWindowIfOwner]):
1551         (-[CarbonWindowAdapter _windowMovedToRect:]):
1552         (-[CarbonWindowAdapter setContentView:]):
1553         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1554         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1555
1556 2017-12-16  Dan Bernstein  <mitz@apple.com>
1557
1558         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1559         https://bugs.webkit.org/show_bug.cgi?id=180613
1560         <rdar://problem/35946124>
1561
1562         Reviewed by Geoff Garen.
1563
1564         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1565           clients.
1566         * WebView/WebDynamicScrollBarsView.h: Ditto.
1567         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1568
1569 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1570
1571         Enable -Wstrict-prototypes for WebKit
1572         <https://webkit.org/b/180757>
1573         <rdar://problem/36024132>
1574
1575         Rubber-stamped by Joseph Pecoraro.
1576
1577         * Configurations/Base.xcconfig:
1578         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1579
1580 2017-12-14  John Wilander  <wilander@apple.com>
1581
1582         Storage Access API: Implement frame-specific access in the document.cookie layer
1583         https://bugs.webkit.org/show_bug.cgi?id=180682
1584         <rdar://problem/35982257>
1585
1586         Reviewed by Alex Christensen.
1587
1588         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1589         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1590         CookiesStrategy::getRawCookies() now take optional parameters for
1591         frameID and pageID to allow frame-specific scoping of cookies.
1592
1593         This change makes the return values of FrameLoaderClient::frameID()
1594         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1595         WebCore can call those getters and get the right return values in
1596         WebKit and std:nullopt in WebKitLegacy.
1597
1598         * WebCoreSupport/WebFrameLoaderClient.h:
1599         * WebCoreSupport/WebFrameLoaderClient.mm:
1600         (WebFrameLoaderClient::pageID const):
1601         (WebFrameLoaderClient::frameID const):
1602         * WebCoreSupport/WebPlatformStrategies.h:
1603         * WebCoreSupport/WebPlatformStrategies.mm:
1604         (WebPlatformStrategies::cookiesForDOM):
1605         (WebPlatformStrategies::setCookiesFromDOM):
1606         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1607         (WebPlatformStrategies::getRawCookies):
1608
1609 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1610
1611         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1612         https://bugs.webkit.org/show_bug.cgi?id=180689
1613
1614         Reviewed by Tim Horton.
1615
1616         Use sRGBColorSpaceRef() from WebCore.
1617
1618         * WebView/WebHTMLView.mm:
1619         (imageFromRect):
1620
1621 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1622
1623         Stop using deprecated target conditional for simulator builds
1624         https://bugs.webkit.org/show_bug.cgi?id=180662
1625         <rdar://problem/35136156>
1626
1627         Reviewed by Simon Fraser.
1628
1629         * postprocess-headers.sh:
1630
1631 2017-12-11  David Quesada  <david_quesada@apple.com>
1632
1633         Turn on ENABLE_APPLICATION_MANIFEST
1634         https://bugs.webkit.org/show_bug.cgi?id=180562
1635         rdar://problem/35924737
1636
1637         Reviewed by Geoffrey Garen.
1638
1639         * Configurations/FeatureDefines.xcconfig:
1640
1641 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1642
1643         Remove pthread_once in favor of dispatch_once
1644         https://bugs.webkit.org/show_bug.cgi?id=180591
1645
1646         Reviewed by Saam Barati.
1647
1648         * Misc/WebKitErrors.m:
1649         (+[NSError _registerWebKitErrors]):
1650         (registerErrors): Deleted.
1651         * Storage/WebStorageManager.mm:
1652         (+[WebStorageManager _storageDirectoryPath]):
1653         (initializeLocalStoragePath): Deleted.
1654
1655 2017-12-07  Darin Adler  <darin@apple.com>
1656
1657         Remove some unused code from WebKitLegacy
1658         https://bugs.webkit.org/show_bug.cgi?id=180567
1659
1660         Reviewed by Anders Carlsson.
1661
1662         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1663         macOS (back a few versions) and iOS and removed unused
1664         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1665         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1666         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1667         _webkit_stringByCollapsingNonPrintingCharacters,
1668         _webkit_stringByCollapsingWhitespaceCharacters,
1669         _web_stringWithData:textEncodingName:, and
1670         _webkit_localStorageDirectoryWithBundleIdentifier:.
1671
1672         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1673         this source file.
1674         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1675         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1676         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1677         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1678         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1679         handle font smoothing options.
1680         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1681         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1682         from header and made it a little clearer.
1683         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1684         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1685         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1686         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1687         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1688         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1689         implementation a bit and used whole words instead of abbreviations.
1690         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1691
1692         * Misc/WebNSFileManagerExtras.mm:
1693         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1694         filenameByFixingIllegalCharacters function from WebCore directly instead of
1695         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1696
1697         * Plugins/WebBaseNetscapePluginView.mm:
1698         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1699         string replacements instead of _web_stringByStrippingReturnCharacters
1700         and to use NSString methods instead of CFString functions.
1701
1702 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1703
1704         Ignore deprecation warnings.
1705
1706         * WebView/WebHTMLView.mm:
1707         (-[NSWindow _web_borderView]):
1708         (-[WebHTMLView _setAsideSubviews]):
1709         * WebView/WebView.mm:
1710         (-[WebView encodeWithCoder:]):
1711
1712 2017-12-02  Darin Adler  <darin@apple.com>
1713
1714         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1715         https://bugs.webkit.org/show_bug.cgi?id=180009
1716
1717         Reviewed by Alex Christensen.
1718
1719         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1720
1721         * Plugins/WebBaseNetscapePluginView.mm:
1722         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1723         of strcasecmp.
1724
1725         * WebView/WebPreferences.mm:
1726         (contains): Ditto. Also made this a template so it's easier to call on an array.
1727         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1728
1729 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1730
1731         Limit user agent versioning to an upper bound
1732         https://bugs.webkit.org/show_bug.cgi?id=180365
1733         <rdar://problem/34550617>
1734
1735         Reviewed by Joseph Pecoraro.
1736
1737         * WebView/WebView.mm:
1738         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1739         creating the User Agent string.
1740         (webKitBundleVersionString): Deleted.
1741
1742 2017-12-05  Andy Estes  <aestes@apple.com>
1743
1744         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1745         https://bugs.webkit.org/show_bug.cgi?id=180457
1746         <rdar://problem/35143007>
1747
1748         Reviewed by Tim Horton.
1749
1750         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1751         check for this macro during post-processing.
1752
1753         * postprocess-headers.sh:
1754
1755 2017-12-04  David Quesada  <david_quesada@apple.com>
1756
1757         Add a class for parsing application manifests
1758         https://bugs.webkit.org/show_bug.cgi?id=177973
1759         rdar://problem/34747949
1760
1761         Reviewed by Geoffrey Garen.
1762
1763         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1764
1765 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1766
1767         Make LegacyCustomProtocolManager optional for network process
1768         https://bugs.webkit.org/show_bug.cgi?id=176230
1769
1770         Reviewed by Alex Christensen.
1771
1772         * Configurations/FeatureDefines.xcconfig:
1773
1774 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1775
1776         Fix some NSOperationQueue leaks
1777         https://bugs.webkit.org/show_bug.cgi?id=180221
1778
1779         Reviewed by Wenson Hsieh.
1780
1781         * WebView/WebView.mm:
1782         (-[WebView performDragOperation:]):
1783
1784 2017-11-30  Darin Adler  <darin@apple.com>
1785
1786         [Mac] remove unneeded RetainPtr use introduced in r225142
1787         https://bugs.webkit.org/show_bug.cgi?id=180202
1788
1789         Reviewed by Tim Horton.
1790
1791         * WebView/WebImmediateActionController.mm:
1792         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1793         RetainPtr.
1794
1795 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1796
1797         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1798         https://bugs.webkit.org/show_bug.cgi?id=175595
1799
1800         Reviewed by Darin Adler.
1801
1802         * WebView/WebPreferences.mm:
1803
1804 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1805
1806         One too many zeroes in macOS version number in FeatureDefines
1807         https://bugs.webkit.org/show_bug.cgi?id=180011
1808
1809         Reviewed by Dan Bernstein.
1810
1811         * Configurations/FeatureDefines.xcconfig:
1812
1813 2017-11-23  Darin Adler  <darin@apple.com>
1814
1815         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1816         https://bugs.webkit.org/show_bug.cgi?id=179981
1817
1818         Reviewed by Sam Weinig.
1819
1820         * WebView/WebImmediateActionController.mm:
1821         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1822         * WebView/WebView.mm:
1823         (coreOptions): Use |= instead of | to build up FindOptions.
1824
1825 2017-11-23  Sam Weinig  <sam@webkit.org>
1826
1827         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1828         https://bugs.webkit.org/show_bug.cgi?id=179954
1829
1830         Reviewed by Darin Adler.
1831
1832         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1833         with direct calls to the corresponding UserGestureIndicator functions.
1834
1835         * Plugins/WebPluginController.mm:
1836         (-[WebPluginController processingUserGesture]):
1837         * WebView/WebView.mm:
1838         (-[WebView _isProcessingUserGesture]):
1839
1840 2017-11-23  Darin Adler  <darin@apple.com>
1841
1842         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1843         https://bugs.webkit.org/show_bug.cgi?id=179907
1844
1845         Reviewed by Sam Weinig.
1846
1847         * History/BinaryPropertyList.cpp:
1848         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1849         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1850         * WebView/WebHTMLRepresentation.mm:
1851         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1852         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1853
1854 2017-11-22  Ali Juma  <ajuma@chromium.org>
1855
1856         Implement VisualViewport API attributes
1857         https://bugs.webkit.org/show_bug.cgi?id=179385
1858
1859         Reviewed by Frédéric Wang.
1860
1861         Add a VisualViewportAPI preference.
1862
1863         * WebView/WebPreferenceKeysPrivate.h:
1864         * WebView/WebPreferences.mm:
1865         (+[WebPreferences initialize]):
1866         (-[WebPreferences visualViewportAPIEnabled]):
1867         (-[WebPreferences setVisualViewportAPIEnabled:]):
1868         * WebView/WebPreferencesPrivate.h:
1869         * WebView/WebView.mm:
1870         (-[WebView _preferencesChanged:]):
1871
1872 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1873
1874         WebCoreObjCExtras.h is being included in too many places
1875         https://bugs.webkit.org/show_bug.cgi?id=179931
1876
1877         Reviewed by Darin Adler.
1878
1879         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1880         * Plugins/WebBaseNetscapePluginView.mm:
1881         * Plugins/WebBasePluginPackage.mm:
1882         * Plugins/WebNetscapePluginStream.mm:
1883         * Plugins/WebNetscapePluginView.mm:
1884         * WebView/WebTextIterator.mm:
1885         * WebView/WebViewData.mm:
1886
1887 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1888
1889         Unreviewed, rolling out r225093.
1890         https://bugs.webkit.org/show_bug.cgi?id=179938
1891
1892         Compilation failed on WinCairo 64-bit Release (Requested by
1893         fredw on #webkit).
1894
1895         Reverted changeset:
1896
1897         "Implement VisualViewport API attributes"
1898         https://bugs.webkit.org/show_bug.cgi?id=179385
1899         https://trac.webkit.org/changeset/225093
1900
1901 2017-11-21  Ali Juma  <ajuma@chromium.org>
1902
1903         Implement VisualViewport API attributes
1904         https://bugs.webkit.org/show_bug.cgi?id=179385
1905
1906         Reviewed by Frédéric Wang.
1907
1908         Add a VisualViewportAPI preference.
1909
1910         * WebView/WebPreferenceKeysPrivate.h:
1911         * WebView/WebPreferences.mm:
1912         (+[WebPreferences initialize]):
1913         (-[WebPreferences visualViewportAPIEnabled]):
1914         (-[WebPreferences setVisualViewportAPIEnabled:]):
1915         * WebView/WebPreferencesPrivate.h:
1916         * WebView/WebView.mm:
1917         (-[WebView _preferencesChanged:]):
1918
1919 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1920
1921         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1922         https://bugs.webkit.org/show_bug.cgi?id=179504
1923
1924         Reviewed by Darin Adler.
1925
1926         * Misc/WebKitNSStringExtras.mm:
1927         * Plugins/Hosted/NetscapePluginHostManager.mm:
1928         * Plugins/WebBasePluginPackage.mm:
1929
1930 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1931
1932         Remove unused TOUCH_ICON_LOADING feature flag
1933         https://bugs.webkit.org/show_bug.cgi?id=179873
1934
1935         Reviewed by Simon Fraser.
1936
1937         * Configurations/FeatureDefines.xcconfig:
1938
1939 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1940
1941         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1942         https://bugs.webkit.org/show_bug.cgi?id=179872
1943
1944         Reviewed by Darin Adler.
1945
1946         * Configurations/FeatureDefines.xcconfig:
1947
1948 2017-11-16  Daniel Bates  <dabates@apple.com>
1949
1950         Add feature define for alternative presentation button element
1951         https://bugs.webkit.org/show_bug.cgi?id=179692
1952         Part of <rdar://problem/34917108>
1953
1954         Reviewed by Andy Estes.
1955
1956         Only enabled on Cocoa platforms by default.
1957
1958         * Configurations/FeatureDefines.xcconfig:
1959
1960 2017-11-14  Nan Wang  <n_wang@apple.com>
1961
1962         AX: AOM: Implement AccessibleNode class and support label and role attributes
1963         https://bugs.webkit.org/show_bug.cgi?id=179494
1964
1965         Reviewed by Ryosuke Niwa.
1966
1967         * WebView/WebPreferenceKeysPrivate.h:
1968         * WebView/WebPreferences.mm:
1969         (+[WebPreferences initialize]):
1970         (-[WebPreferences accessibilityObjectModelEnabled]):
1971         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1972         * WebView/WebPreferencesPrivate.h:
1973         * WebView/WebView.mm:
1974         (-[WebView _preferencesChanged:]):
1975
1976 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1977
1978         Remove Cocoa CFURLConnection loading code
1979         https://bugs.webkit.org/show_bug.cgi?id=179688
1980
1981         Reviewed by Antti Koivisto.
1982
1983         * Misc/WebDownload.mm:
1984         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1985         * Misc/WebDownloadInternal.h:
1986         * Plugins/WebBaseNetscapePluginView.mm:
1987         * WebCoreSupport/WebFrameLoaderClient.mm:
1988         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1989         * WebView/WebView.mm:
1990         (-[WebView scheduleInRunLoop:forMode:]):
1991         (-[WebView unscheduleFromRunLoop:forMode:]):
1992
1993 2017-11-14  Daniel Bates  <dabates@apple.com>
1994
1995         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1996         for feature defines
1997
1998         Following r195498 and r201917 the Visual Studio property files for feature defines have
1999         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2000         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2001         files.
2002
2003         * Configurations/FeatureDefines.xcconfig:
2004
2005 2017-11-14  Jer Noble  <jer.noble@apple.com>
2006
2007         Enable Modern EME tests in DumpRenderTree
2008         https://bugs.webkit.org/show_bug.cgi?id=179544
2009
2010         Reviewed by Alex Christensen.
2011
2012         Add a WebPreferences property to enable the (modern) EME API.
2013
2014         * WebView/WebPreferenceKeysPrivate.h:
2015         * WebView/WebPreferences.mm:
2016         (+[WebPreferences initialize]):
2017         (-[WebPreferences encryptedMediaAPIEnabled]):
2018         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2019         * WebView/WebPreferencesPrivate.h:
2020         * WebView/WebView.mm:
2021         (-[WebView _preferencesChanged:]):
2022
2023 2017-11-14  Antti Koivisto  <antti@apple.com>
2024
2025         Enable display:contents by default
2026         https://bugs.webkit.org/show_bug.cgi?id=179655
2027
2028         Reviewed by Sam Weinig.
2029
2030         * WebView/WebPreferences.mm:
2031         (+[WebPreferences initialize]):
2032
2033 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2034
2035         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2036         https://bugs.webkit.org/show_bug.cgi?id=178751
2037
2038         Reviewed by Brady Eidson.
2039
2040         * WebCoreSupport/WebFrameNetworkingContext.mm:
2041         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2042
2043 2017-11-08  Keith Miller  <keith_miller@apple.com>
2044
2045         Async iteration should only fetch the next method once and add feature flag
2046         https://bugs.webkit.org/show_bug.cgi?id=179451
2047
2048         Reviewed by Geoffrey Garen.
2049
2050         Add feature flag for Async iteration.
2051
2052         * Configurations/FeatureDefines.xcconfig:
2053
2054 2017-11-13  Mark Lam  <mark.lam@apple.com>
2055
2056         Add more overflow check book-keeping for MarkedArgumentBuffer.
2057         https://bugs.webkit.org/show_bug.cgi?id=179634
2058         <rdar://problem/35492517>
2059
2060         Reviewed by Saam Barati.
2061
2062         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2063         (WebKit::NetscapePluginInstanceProxy::invoke):
2064         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2065         (WebKit::NetscapePluginInstanceProxy::construct):
2066
2067 2017-11-12  Darin Adler  <darin@apple.com>
2068
2069         More is<> and downcast<>, less static_cast<>
2070         https://bugs.webkit.org/show_bug.cgi?id=179600
2071
2072         Reviewed by Chris Dumez.
2073
2074         * DOM/DOM.mm:
2075         (kit): Use is/downcast.
2076         * WebCoreSupport/WebEditorClient.mm:
2077         (WebEditorClient::handleKeyboardEvent): Ditto.
2078         (WebEditorClient::handleInputMethodKeydown): Ditto.
2079         * WebView/WebHTMLView.mm:
2080         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2081
2082 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2083
2084         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2085         https://bugs.webkit.org/show_bug.cgi?id=179397
2086
2087         Reviewed by Wenson Hsieh.
2088
2089         * DOM/DOMHTMLInputElement.mm:
2090         (-[DOMHTMLInputElement insertTextSuggestion:]):
2091
2092 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2093
2094         HTMLMediaElement should not use element fullscreen on iOS
2095         https://bugs.webkit.org/show_bug.cgi?id=179418
2096         rdar://problem/35409277
2097
2098         Reviewed by Eric Carlson.
2099
2100         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2101
2102         * Configurations/FeatureDefines.xcconfig:
2103
2104 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2105
2106         Make ResourceLoader::willSendRequestInternal asynchronous
2107         https://bugs.webkit.org/show_bug.cgi?id=179251
2108
2109         Reviewed by Andy Estes.
2110
2111         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2112         (WebKit::HostedNetscapePluginStream::start):
2113         * Plugins/WebNetscapePluginStream.mm:
2114         (WebNetscapePluginStream::start):
2115
2116 2017-11-01  Darin Adler  <darin@apple.com>
2117
2118         Simplify event dispatch code and make it a bit more consistent
2119         https://bugs.webkit.org/show_bug.cgi?id=178991
2120
2121         Reviewed by Chris Dumez.
2122
2123         * DOM/DOMEvent.mm:
2124         (-[DOMEvent srcElement]): Call target instead of srcElement.
2125
2126 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2127
2128         [Touch Bar Web API] Add support for menuitem tag
2129         https://bugs.webkit.org/show_bug.cgi?id=179020
2130
2131         Reviewed by Ryosuke Niwa.
2132
2133         Adds in properties and methods that allow the menuitem runtime feature
2134         to be enabled or disabled.
2135
2136         * WebView/WebPreferenceKeysPrivate.h:
2137         * WebView/WebPreferences.mm:
2138         (-[WebPreferences menuItemElementEnabled]):
2139         (-[WebPreferences setMenuItemElementEnabled:]):
2140         * WebView/WebPreferencesPrivate.h:
2141         * WebView/WebView.mm:
2142         (-[WebView _preferencesChanged:]):
2143
2144 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2145
2146         Use CompletionHandlers for redirects
2147         https://bugs.webkit.org/show_bug.cgi?id=179163
2148
2149         Reviewed by Tim Horton.
2150
2151         * Plugins/Hosted/HostedNetscapePluginStream.h:
2152         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2153         (WebKit::HostedNetscapePluginStream::willSendRequest):
2154         * Plugins/WebNetscapePluginStream.h:
2155         * Plugins/WebNetscapePluginStream.mm:
2156         (WebNetscapePluginStream::willSendRequest):
2157
2158 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2159
2160         Add a FileSystem namespace to FileSystem.cpp
2161         https://bugs.webkit.org/show_bug.cgi?id=179063
2162
2163         Reviewed by Darin Adler.
2164
2165         * Misc/WebNSFileManagerExtras.mm:
2166         * Storage/WebDatabaseProvider.mm:
2167
2168 2017-11-02  Frederic Wang  <fwang@igalia.com>
2169
2170         Add references to bug 179167 in FIXME comments
2171         https://bugs.webkit.org/show_bug.cgi?id=179168
2172
2173         Reviewed by Daniel Bates.
2174
2175         * Configurations/FeatureDefines.xcconfig:
2176
2177 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2178
2179         Implement WKFullscreenWindowController for iOS.
2180         https://bugs.webkit.org/show_bug.cgi?id=178924
2181         rdar://problem/34697120
2182
2183         Reviewed by Simon Fraser.
2184
2185         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2186
2187         * Configurations/FeatureDefines.xcconfig:
2188         * WebView/WebView.mm:
2189         (-[WebView fullScreenPlaceholderView]):
2190
2191 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2192
2193         Clean up some drag and drop feature flags
2194         https://bugs.webkit.org/show_bug.cgi?id=179082
2195
2196         Reviewed by Simon Fraser.
2197
2198         * Configurations/FeatureDefines.xcconfig:
2199
2200 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2201
2202         Make it possible to test rubber-banding in overflow scroll
2203         https://bugs.webkit.org/show_bug.cgi?id=179078
2204
2205         Reviewed by Sam Weinig.
2206
2207         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2208         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2209
2210         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2211         functions, since most callers want clamped.
2212
2213         * DOM/DOMHTML.mm:
2214         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2215
2216 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2217
2218         Fix up some content filtering feature flags
2219         https://bugs.webkit.org/show_bug.cgi?id=179079
2220
2221         Reviewed by Simon Fraser.
2222
2223         * Configurations/FeatureDefines.xcconfig:
2224
2225 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2226
2227         [FrameView::layout cleanup] Move core layout logic to a separate class.
2228         https://bugs.webkit.org/show_bug.cgi?id=178771
2229         <rdar://problem/35166542>
2230
2231         Reviewed by Simon Fraser.
2232
2233         Move layout code out from FrameView to LayoutContext.
2234
2235         * WebView/WebClipView.mm:
2236         (-[WebClipView _immediateScrollToPoint:]):
2237         * WebView/WebFrame.mm:
2238         (-[WebFrame layoutCount]):
2239
2240 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2241
2242         Fix issues with WebView subframe painting
2243         https://bugs.webkit.org/show_bug.cgi?id=178842
2244         rdar://problem/34072253
2245
2246         Reviewed by Daniel Bates.
2247         
2248         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2249         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2250         High Sierra, so match the new signature.
2251
2252         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2253
2254         * WebView/WebHTMLView.mm:
2255         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2256         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2257
2258 2017-10-25  Youenn Fablet  <youenn@apple.com>
2259
2260         Enable ServiceWorker to fetch resources
2261         https://bugs.webkit.org/show_bug.cgi?id=178673
2262
2263         Reviewed by Brady Eidson.
2264
2265         * WebCoreSupport/WebFrameLoaderClient.mm:
2266         (WebFrameLoaderClient::pageID const):
2267         (WebFrameLoaderClient::frameID const):
2268         (WebFrameLoaderClient::sessionID const):
2269
2270         Added implementation to the new getters.
2271         They are noop in the context of WK1.
2272
2273 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2274
2275         Web Inspector: Enable WebKit logging configuration and display
2276         https://bugs.webkit.org/show_bug.cgi?id=177027
2277         <rdar://problem/33964767>
2278
2279         Reviewed by Joseph Pecoraro.
2280
2281         * WebCoreSupport/WebChromeClient.mm:
2282         (stringForMessageSource): Deal with Media and WebRTC message sources.
2283
2284 2017-10-20  Antoine Quint  <graouts@apple.com>
2285
2286         [Web Animations] Provide basic timeline and animation interfaces
2287         https://bugs.webkit.org/show_bug.cgi?id=178526
2288
2289         Reviewed by Dean Jackson.
2290
2291         Remove the WEB_ANIMATIONS compile-time flag.
2292
2293         * Configurations/FeatureDefines.xcconfig:
2294         * WebView/WebPreferences.mm:
2295         (+[WebPreferences initialize]):
2296         * WebView/WebView.mm:
2297         (-[WebView _preferencesChanged:]):
2298
2299 2017-10-19  Sam Weinig  <sam@webkit.org>
2300
2301         [Settings] Move global settings into their own file
2302         https://bugs.webkit.org/show_bug.cgi?id=178512
2303
2304         Reviewed by Darin Adler.
2305
2306         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2307
2308         * WebCoreSupport/WebChromeClient.mm:
2309         (WebChromeClient::supportsVideoFullscreen):
2310         * WebView/WebDynamicScrollBarsView.mm:
2311         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2312         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2313         * WebView/WebPreferences.mm:
2314         (+[WebPreferences initialize]):
2315         * WebView/WebView.mm:
2316         (-[WebView _commonInitializationWithFrameName:groupName:]):
2317         (-[WebView _preferencesChanged:]):
2318         (+[WebView _doNotStartObservingNetworkReachability]):
2319
2320 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2321
2322         Replace some stack raw pointers with RefPtrs within WebCore/html
2323         https://bugs.webkit.org/show_bug.cgi?id=178201
2324         <rdar://problem/34841692>
2325
2326         Reviewed by Ryosuke Niwa.
2327
2328         * DOM/DOM.mm:
2329         (kit):
2330         Change the type of node as toNode() is changed to return RefPtr.
2331
2332 2017-10-18  Chris Dumez  <cdumez@apple.com>
2333
2334         [Service Worker] Add stubs for Client / WindowClient / Clients
2335         https://bugs.webkit.org/show_bug.cgi?id=178469
2336
2337         Reviewed by Youenn Fablet.
2338
2339         Rename PageVisiblityState to VisibilityState.
2340
2341         * WebView/WebView.mm:
2342         (kit):
2343
2344 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2345
2346         Unreviewed, rolling out r223291.
2347
2348         See WebCore ChangeLog for more detail.
2349
2350         Reverted changeset:
2351
2352         "Remove Editor::simplifyMarkup"
2353         https://bugs.webkit.org/show_bug.cgi?id=178271
2354         https://trac.webkit.org/changeset/223291
2355
2356 2017-10-17  Keith Miller  <keith_miller@apple.com>
2357
2358         Change WebCore sources to work with unified source builds
2359         https://bugs.webkit.org/show_bug.cgi?id=178229
2360
2361         Rubber stamped by Tim Horton.
2362
2363         * Configurations/FeatureDefines.xcconfig:
2364
2365 2017-10-16  Sam Weinig  <sam@webkit.org>
2366
2367         [Settings] Remove all custom code from Settings.h/cpp
2368         https://bugs.webkit.org/show_bug.cgi?id=178330
2369
2370         Reviewed by Simon Fraser.
2371
2372         * WebView/WebPreferences.mm:
2373         (+[WebPreferences initialize]):
2374         
2375             Update for naming changes of FrameFlattening now that it is an enum class.
2376
2377 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2378
2379         Remove Editor::simplifyMarkup
2380         https://bugs.webkit.org/show_bug.cgi?id=178271
2381
2382         Reviewed by Wenson Hsieh.
2383
2384         * WebView/WebView.mm:
2385         (-[WebView _simplifyMarkup:endNode:]):
2386
2387 2017-10-12  Chris Dumez  <cdumez@apple.com>
2388
2389         [Mac] Add support for MouseEvent.buttons
2390         https://bugs.webkit.org/show_bug.cgi?id=178214
2391
2392         Reviewed by Ryosuke Niwa.
2393
2394         * WebView/WebPDFView.mm:
2395         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2396
2397 2017-10-11  Sam Weinig  <sam@webkit.org>
2398
2399         Remove out-parameter variants of copyToVector
2400         https://bugs.webkit.org/show_bug.cgi?id=178155
2401
2402         Reviewed by Tim Horton.
2403
2404         * Plugins/WebNetscapePluginView.mm:
2405         (-[WebNetscapePluginView destroyPlugin]):
2406         * WebView/WebHTMLRepresentation.mm:
2407         (newArrayWithStrings):
2408
2409             Replace out-parameter based copyToVector, with one that returns a Vector.
2410
2411 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2412
2413         Sanitize URL in pasteboard for other applications and cross origin content
2414         https://bugs.webkit.org/show_bug.cgi?id=178060
2415         <rdar://problem/34874518>
2416
2417         Reviewed by Wenson Hsieh.
2418
2419         * WebCoreSupport/WebPlatformStrategies.h:
2420         * WebCoreSupport/WebPlatformStrategies.mm:
2421         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2422
2423 2017-10-11  Chris Dumez  <cdumez@apple.com>
2424
2425         Modernize Geolocation code
2426         https://bugs.webkit.org/show_bug.cgi?id=178148
2427
2428         Reviewed by Ryosuke Niwa.
2429
2430         * WebCoreSupport/WebGeolocationClient.h:
2431         * WebCoreSupport/WebGeolocationClient.mm:
2432         (WebGeolocationClient::lastPosition):
2433         * WebView/WebGeolocationPosition.mm:
2434         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2435         (core):
2436         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2437         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2438         * WebView/WebGeolocationPositionInternal.h:
2439
2440 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2441
2442         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2443         https://bugs.webkit.org/show_bug.cgi?id=178154
2444
2445         Reviewed by Wenson Hsieh.
2446
2447         Enable custom pasteboard data by default.
2448
2449         * WebView/WebPreferenceKeysPrivate.h:
2450         * WebView/WebPreferences.mm:
2451         (+[WebPreferences initialize]):
2452         (-[WebPreferences customPasteboardDataEnabled]): Added.
2453         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2454         * WebView/WebPreferencesPrivate.h:
2455         * WebView/WebView.mm:
2456         (-[WebView _preferencesChanged:]):
2457
2458 2017-10-10  Sam Weinig  <sam@webkit.org>
2459
2460         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2461         https://bugs.webkit.org/show_bug.cgi?id=178102
2462
2463         Reviewed by Tim Horton.
2464
2465         * History/WebHistory.mm:
2466         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2467         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2468         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2469         * WebCoreSupport/WebUserMediaClient.mm:
2470         (WebUserMediaClient::pageDestroyed):
2471
2472 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2473
2474         Make the names of the options consistent
2475         https://bugs.webkit.org/show_bug.cgi?id=177933
2476
2477         Reviewed by Saam Barati.
2478
2479         * WebView/WebFrame.h:
2480         * WebView/WebHTMLView.mm:
2481         (-[WebHTMLView setMarkedText:selectedRange:]):
2482         * WebView/WebView.h:
2483
2484 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2485
2486         [iOS] Tweak support for classifying form controls (followup to r222487)
2487         https://bugs.webkit.org/show_bug.cgi?id=177917
2488         <rdar://problem/34820122>
2489
2490         Reviewed by Dean Jackson.
2491
2492         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2493
2494         * DOM/DOMHTMLInputElement.mm:
2495         (-[DOMHTMLInputElement _autofillContext]):
2496         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2497         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2498
2499 2017-10-05  Keith Miller  <keith_miller@apple.com>
2500
2501         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2502
2503         * Configurations/WebKitLegacy.xcconfig:
2504
2505 2017-10-05  Jer Noble  <jer.noble@apple.com>
2506
2507         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2508         https://bugs.webkit.org/show_bug.cgi?id=177261
2509
2510         Reviewed by Eric Carlson.
2511
2512         * Configurations/FeatureDefines.xcconfig:
2513
2514 2017-10-05  Chris Dumez  <cdumez@apple.com>
2515
2516         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2517         https://bugs.webkit.org/show_bug.cgi?id=177957
2518
2519         Reviewed by Alex Christensen.
2520
2521         * WebCoreSupport/WebPlatformStrategies.h:
2522         * WebCoreSupport/WebPlatformStrategies.mm:
2523         (WebPlatformStrategies::cookiesEnabled):
2524
2525 2017-10-05  Youenn Fablet  <youenn@apple.com>
2526
2527         Make LibWebRTCProvider port agnostic
2528         https://bugs.webkit.org/show_bug.cgi?id=177747
2529
2530         Reviewed by Alex Christensen & Alex Garcia.
2531
2532         * WebView/WebView.mm:
2533         (-[WebView _commonInitializationWithFrameName:groupName:]):
2534         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2535
2536 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2537
2538         Stop linking with WebKitSystemInterface
2539         https://bugs.webkit.org/show_bug.cgi?id=177915
2540
2541         Reviewed by Antti Koivisto.
2542
2543         * Configurations/DebugRelease.xcconfig:
2544         * Configurations/WebKitLegacy.xcconfig:
2545
2546 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2547
2548         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2549         https://bugs.webkit.org/show_bug.cgi?id=177912
2550
2551         Reviewed by Saam Barati.
2552
2553         * Carbon/CarbonUtils.m:
2554         * Carbon/CarbonWindowAdapter.mm:
2555         * Carbon/HIWebView.mm:
2556         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2557         * Misc/WebNSFileManagerExtras.mm:
2558         * Misc/WebNSPasteboardExtras.mm:
2559         * Misc/WebNSURLExtras.mm:
2560         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2561         * Plugins/Hosted/NetscapePluginHostManager.mm:
2562         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2563         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2564         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2565         * Plugins/Hosted/WebTextInputWindowController.m:
2566         * Plugins/WebBaseNetscapePluginView.mm:
2567         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2568         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2569         * Plugins/WebNetscapePluginStream.mm:
2570         * Plugins/WebNetscapePluginView.mm:
2571         * Plugins/WebPluginDatabase.mm:
2572         * WebCoreSupport/PopupMenuMac.mm:
2573         * WebCoreSupport/WebChromeClient.mm:
2574         * WebCoreSupport/WebFrameLoaderClient.mm:
2575         * WebCoreSupport/WebInspectorClient.mm:
2576         * WebCoreSupport/WebPlatformStrategies.mm:
2577         * WebCoreSupport/WebSystemInterface.mm:
2578         * WebView/WebDynamicScrollBarsView.mm:
2579         * WebView/WebFrame.mm:
2580         * WebView/WebFrameView.mm:
2581         * WebView/WebFullScreenController.mm:
2582         * WebView/WebHTMLView.mm:
2583         * WebView/WebPreferences.mm:
2584         * WebView/WebView.mm:
2585
2586 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2587
2588         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2589         rdar://problem/34705779
2590
2591         Addressing review comments that I somehow landed without.
2592
2593         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2594
2595 2017-09-29  Chris Dumez  <cdumez@apple.com>
2596
2597         Split some logic out of VisitedLinkStore and make it reusable
2598         https://bugs.webkit.org/show_bug.cgi?id=177575
2599
2600         Reviewed by Alex Christensen.
2601
2602         * WebCoreSupport/WebVisitedLinkStore.h:
2603         * WebCoreSupport/WebVisitedLinkStore.mm:
2604         (WebVisitedLinkStore::addVisitedLink):
2605         (WebVisitedLinkStore::removeVisitedLink):
2606         (WebVisitedLinkStore::isLinkVisited):
2607         (WebVisitedLinkStore::addVisitedLinkHash):
2608
2609 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2610
2611         Build fix for High Sierra 32 bit Mac
2612         https://bugs.webkit.org/show_bug.cgi?id=177551
2613         <rdar://problem/34690283>
2614
2615         Reviewed by Alexey Proskuryakov.
2616
2617         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2618         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2619         also made.
2620
2621         * Carbon/CarbonWindowAdapter.mm:
2622         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2623         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2624         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2625         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2626         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2627         (-[CarbonWindowAdapter dealloc]):
2628         (-[CarbonWindowAdapter windowRef]):
2629         (-[CarbonWindowAdapter _hasWindowRef]):
2630         (-[CarbonWindowAdapter _managesWindowRef]):
2631         (-[CarbonWindowAdapter _removeWindowRef]):
2632         (-[CarbonWindowAdapter _carbonWindowClass]):
2633         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2634         (-[CarbonWindowAdapter sendSuperEvent:]):
2635         (-[CarbonWindowAdapter relinquishFocus]):
2636         (-[CarbonWindowAdapter _cancelKey:]):
2637         (-[CarbonWindowAdapter _commonAwake]):
2638         (-[CarbonWindowAdapter _destroyRealWindow:]):
2639         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2640         (-[CarbonWindowAdapter _termWindowIfOwner]):
2641         (-[CarbonWindowAdapter _windowMovedToRect:]):
2642         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2643         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2644         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2645         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2646         (-[CarbonWindowAdapter canBecomeMainWindow]):
2647         (-[CarbonWindowAdapter encodeWithCoder:]):
2648         (-[CarbonWindowAdapter initWithCoder:]):
2649         (-[CarbonWindowAdapter setContentView:]):
2650         (-[CarbonWindowAdapter worksWhenModal]):
2651         (-[CarbonWindowAdapter _setModalWindowLevel]):
2652         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2653         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2654         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2655         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2656         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2657         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2658         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2659         (NSCarbonWindowHandleEvent):
2660         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2661         (-[CarbonWindowAdapter _growBoxRect]):
2662         * Carbon/HIWebView.mm:
2663         (HIWebViewGetWebView):
2664         (HIWebViewConstructor):
2665         (HIWebViewDestructor):
2666         (HIWebViewRegisterClass):
2667         (GetBehaviors):
2668         (Draw):
2669         (HitTest):
2670         (GetRegion):
2671         (GetWindowRef):
2672         (CreateNSEventAdoptingCGEvent):
2673         (CopyEventCGEvent):
2674         (CreateNSEventWithCarbonClickEvent):
2675         (Click):
2676         (CreateNSEventWithCarbonEvent):
2677         (MouseUp):
2678         (CreateNSEventWithCarbonMouseMoveEvent):
2679         (MouseMoved):
2680         (MouseDragged):
2681         (MouseWheelMoved):
2682         (ContextMenuClick):
2683         (GetKind):
2684         (BoundsChanged):
2685         (OwningWindowChanged):
2686         (WindowHandler):
2687         (SyncFrame):
2688         (SetFocusPart):
2689         (AdvanceFocus):
2690         (RelinquishFocus):
2691         (ActiveStateChanged):
2692         (ProcessCommand):
2693         (UpdateCommandStatus):
2694         (_NSSelectorForHICommand):
2695         (HIWebViewEventHandler):
2696         (StartUpdateObserver):
2697         (StopUpdateObserver):
2698         (UpdateObserver):
2699
2700 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2701
2702         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2703         https://bugs.webkit.org/show_bug.cgi?id=172526
2704         <rdar://problem/32396081>
2705
2706         Reviewed by Ryosuke Niwa.
2707
2708         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2709
2710         * WebCoreSupport/WebPlatformStrategies.h:
2711         * WebCoreSupport/WebPlatformStrategies.mm:
2712         (WebPlatformStrategies::webExposedTypes):
2713         (WebPlatformStrategies::writeCustomData):
2714
2715 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2716
2717         Unreviewed, rolling out r222567.
2718
2719         This broke and internal build.
2720
2721         Reverted changeset:
2722
2723         "Build fix for High Sierra 32 bit Mac"
2724         https://bugs.webkit.org/show_bug.cgi?id=177551
2725         http://trac.webkit.org/changeset/222567
2726
2727 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2728
2729         Build fix for High Sierra 32 bit Mac
2730         https://bugs.webkit.org/show_bug.cgi?id=177551
2731         <rdar://problem/34690283>
2732
2733         Reviewed by Alexey Proskuryakov.
2734
2735         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2736         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2737         also made.
2738
2739         * Carbon/CarbonWindowAdapter.mm:
2740         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2741         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2742         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2743         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2744         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2745         (-[CarbonWindowAdapter dealloc]):
2746         (-[CarbonWindowAdapter windowRef]):
2747         (-[CarbonWindowAdapter _hasWindowRef]):
2748         (-[CarbonWindowAdapter _managesWindowRef]):
2749         (-[CarbonWindowAdapter _removeWindowRef]):
2750         (-[CarbonWindowAdapter _carbonWindowClass]):
2751         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2752         (-[CarbonWindowAdapter sendSuperEvent:]):
2753         (-[CarbonWindowAdapter relinquishFocus]):
2754         (-[CarbonWindowAdapter _cancelKey:]):
2755         (-[CarbonWindowAdapter _commonAwake]):
2756         (-[CarbonWindowAdapter _destroyRealWindow:]):
2757         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2758         (-[CarbonWindowAdapter _termWindowIfOwner]):
2759         (-[CarbonWindowAdapter _windowMovedToRect:]):
2760         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2761         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2762         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2763         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2764         (-[CarbonWindowAdapter canBecomeMainWindow]):
2765         (-[CarbonWindowAdapter encodeWithCoder:]):
2766         (-[CarbonWindowAdapter initWithCoder:]):
2767         (-[CarbonWindowAdapter setContentView:]):
2768         (-[CarbonWindowAdapter worksWhenModal]):
2769         (-[CarbonWindowAdapter _setModalWindowLevel]):
2770         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2771         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2772         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2773         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2774         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2775         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2776         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2777         (NSCarbonWindowHandleEvent):
2778         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2779         (-[CarbonWindowAdapter _growBoxRect]):
2780         * Carbon/HIWebView.mm:
2781         (HIWebViewGetWebView):
2782         (HIWebViewConstructor):
2783         (HIWebViewDestructor):
2784         (HIWebViewRegisterClass):
2785         (GetBehaviors):
2786         (Draw):
2787         (HitTest):
2788         (GetRegion):
2789         (GetWindowRef):
2790         (CreateNSEventAdoptingCGEvent):
2791         (CopyEventCGEvent):
2792         (CreateNSEventWithCarbonClickEvent):
2793         (Click):
2794         (CreateNSEventWithCarbonEvent):
2795         (MouseUp):
2796         (CreateNSEventWithCarbonMouseMoveEvent):
2797         (MouseMoved):
2798         (MouseDragged):
2799         (MouseWheelMoved):
2800         (ContextMenuClick):
2801         (GetKind):
2802         (BoundsChanged):
2803         (OwningWindowChanged):
2804         (WindowHandler):
2805         (SyncFrame):
2806         (SetFocusPart):
2807         (AdvanceFocus):
2808         (RelinquishFocus):
2809         (ActiveStateChanged):
2810         (ProcessCommand):
2811         (UpdateCommandStatus):
2812         (_NSSelectorForHICommand):
2813         (HIWebViewEventHandler):
2814         (StartUpdateObserver):
2815         (StopUpdateObserver):
2816         (UpdateObserver):
2817
2818 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2819
2820         Make PolicyAction an encodable enum class
2821         https://bugs.webkit.org/show_bug.cgi?id=177480
2822
2823         Reviewed by Antti Koivisto.
2824
2825         * Plugins/WebPluginContainerCheck.mm:
2826         (-[WebPluginContainerCheck _continueWithPolicy:]):
2827         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2828         * WebCoreSupport/WebFrameLoaderClient.mm:
2829         (-[WebFramePolicyListener invalidate]):
2830         (-[WebFramePolicyListener ignore]):
2831         (-[WebFramePolicyListener download]):
2832         (-[WebFramePolicyListener use]):
2833         (-[WebFramePolicyListener continue]):
2834         * WebView/WebPolicyDelegate.mm:
2835         (-[WebPolicyDecisionListener use]):
2836         (-[WebPolicyDecisionListener ignore]):
2837         (-[WebPolicyDecisionListener download]):
2838
2839 2017-09-25  Frederik Riedel  <riedel@apple.com>
2840
2841         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2842         https://bugs.webkit.org/show_bug.cgi?id=174394
2843         <rdar://problem/33183504>
2844
2845         Reviewed by Ryosuke Niwa.
2846
2847         * DOM/DOMHTMLInputElement.h:
2848         * DOM/DOMHTMLInputElement.mm:
2849         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2850         Determines if this HTMLInputElement is part of a login screen.
2851         (-[DOMHTMLInputElement representingPageUrl]):
2852         Returns the webpage's URL that is currently displayed in the Web View.
2853         (-[DOMHTMLInputElement insertTextSuggestion:]):
2854         Inserts login credentials into the Web View.
2855
2856 2017-09-25  Sam Weinig  <sam@webkit.org>
2857
2858         Remove unused EditorClient functions
2859         https://bugs.webkit.org/show_bug.cgi?id=177463
2860
2861         Reviewed by Alex Christensen.
2862
2863         Remove unused EditorClient functions.
2864
2865         * WebCoreSupport/WebEditorClient.h:
2866         * WebCoreSupport/WebEditorClient.mm:
2867         (WebEditorClient::canonicalizeURL): Deleted.
2868         (WebEditorClient::canonicalizeURLString): Deleted.
2869         (WebEditorClient::writeDataToPasteboard): Deleted.
2870         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2871         (WebEditorClient::readDataFromPasteboard): Deleted.
2872         (WebEditorClient::pasteboardChangeCount): Deleted.
2873
2874 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2875
2876         Stop using PolicyCallback
2877         https://bugs.webkit.org/show_bug.cgi?id=176088
2878
2879         Reviewed by Andy Estes.
2880
2881         * WebCoreSupport/WebFrameLoaderClient.mm:
2882         (-[WebFramePolicyListener invalidate]):
2883         (-[WebFramePolicyListener receivedPolicyDecision:]):
2884
2885 2017-09-25  Sam Weinig  <sam@webkit.org>
2886
2887         Remove unnecessary userVisibleString EditorClient function
2888         https://bugs.webkit.org/show_bug.cgi?id=177456
2889
2890         Reviewed by Dan Bernstein.
2891
2892         * WebCoreSupport/WebEditorClient.h:
2893         * WebCoreSupport/WebEditorClient.mm:
2894         (WebEditorClient::userVisibleString): Deleted.
2895
2896             Remove userVisibleString client function.
2897
2898 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2899
2900         Separate form submission from PolicyChecker infrastructure
2901         https://bugs.webkit.org/show_bug.cgi?id=177396
2902
2903         Reviewed by Geoffrey Garen.
2904
2905         * WebCoreSupport/WebFrameLoaderClient.h:
2906         * WebCoreSupport/WebFrameLoaderClient.mm:
2907         (WebFrameLoaderClient::dispatchWillSubmitForm):
2908
2909 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2910
2911         WeakPtrFactory should populate m_ref lazily.
2912         https://bugs.webkit.org/show_bug.cgi?id=177375
2913
2914         Reviewed by Geoffrey Garen.
2915
2916         * WebCoreSupport/WebEditorClient.mm:
2917         (WebEditorClient::WebEditorClient):
2918         (WebEditorClient::requestCandidatesForSelection):
2919
2920 2017-09-22  Chris Dumez  <cdumez@apple.com>
2921
2922         Use high resolution timestamp for event time
2923         https://bugs.webkit.org/show_bug.cgi?id=154246
2924         <rdar://problem/34333304>
2925
2926         Reviewed by Ryosuke Niwa.
2927
2928         Use WallTime / MonotonicTime instead of double type for clarity.
2929
2930         * DOM/DOMEvent.mm:
2931         (-[DOMEvent timeStamp]):
2932         * WebView/WebFrame.mm:
2933         (-[WebFrame _dragSourceEndedAt:operation:]):
2934         * WebView/WebPDFView.mm:
2935         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2936
2937 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2938
2939         Enable dataTransfer.items on macOS and iOS
2940         https://bugs.webkit.org/show_bug.cgi?id=177335
2941
2942         Reviewed by Sam Weinig.
2943
2944         * WebView/WebPreferences.mm:
2945         (+[WebPreferences initialize]):
2946
2947 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2948
2949         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2950         https://bugs.webkit.org/show_bug.cgi?id=177101
2951         <rdar://problem/34500648>
2952
2953         Reviewed by Brian Burg.
2954
2955         * WebInspector/WebNodeHighlight.mm:
2956         Ensure we close the window that we have just removed.
2957
2958 2017-09-20  Antti Koivisto  <antti@apple.com>
2959
2960         Remove DOM and styling support for CSS Regions
2961         https://bugs.webkit.org/show_bug.cgi?id=177221
2962
2963         Reviewed by Andreas Kling.
2964
2965         * Configurations/FeatureDefines.xcconfig:
2966         * DOM/DOMCSS.mm:
2967         (kitClass):
2968         * DOM/DOMElement.mm:
2969         (-[DOMElement webkitRegionOverset]): Deleted.
2970
2971 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2972
2973         Layering violation in Editor::createFragment
2974         https://bugs.webkit.org/show_bug.cgi?id=176123
2975
2976         Reviewed by Darin Adler.
2977
2978         * Misc/WebNSURLExtras.h:
2979         * Misc/WebNSURLExtras.mm:
2980         * WebView/WebFrame.mm:
2981         * WebView/WebHTMLView.mm:
2982         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2983
2984         * WebCoreSupport/WebEditorClient.mm:
2985         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2986         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2987         way to avoid exporting the symbol just on newer OSes.
2988
2989 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2990
2991         On iOS, getData can't get text set by setData during copy event
2992         https://bugs.webkit.org/show_bug.cgi?id=176980
2993         <rdar://problem/34453915>
2994
2995         Reviewed by Darin Adler.
2996
2997         * WebCoreSupport/WebPlatformStrategies.h:
2998         * WebCoreSupport/WebPlatformStrategies.mm:
2999         (WebPlatformStrategies::copy): Deleted.
3000
3001 2017-09-18  Andy Estes  <aestes@apple.com>
3002
3003         [Mac] Upstream miscellaneous WebKitSystemInterface functions
3004         https://bugs.webkit.org/show_bug.cgi?id=177029
3005
3006         Reviewed by Alex Christensen.
3007
3008         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3009         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3010         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3011         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3012         * WebCoreSupport/PopupMenuMac.mm:
3013         (PopupMenuMac::show):
3014         * WebCoreSupport/WebSystemInterface.mm:
3015         (InitWebCoreSystemInterface):
3016         * WebView/WebHTMLView.mm:
3017         (-[WebHTMLView setDataSource:]):
3018         (-[WebHTMLView attachRootLayer:]):
3019         * WebView/WebView.mm:
3020         (-[WebView _needsAdobeFrameReloadingQuirk]):
3021         (-[WebView _needsLinkElementTextCSSQuirk]):
3022         (-[WebView _needsIsLoadingInAPISenseQuirk]):
3023         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
3024         (-[WebView _preferencesChanged:]):
3025
3026 2017-09-15  Andy Estes  <aestes@apple.com>
3027
3028         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
3029         https://bugs.webkit.org/show_bug.cgi?id=176953
3030
3031         Reviewed by Eric Carlson.
3032
3033         * WebCoreSupport/WebSystemInterface.mm:
3034         (InitWebCoreSystemInterface):
3035
3036 2017-09-14  Andy Estes  <aestes@apple.com>
3037
3038         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
3039         https://bugs.webkit.org/show_bug.cgi?id=176931
3040
3041         Reviewed by Joseph Pecoraro.
3042
3043         * WebCoreSupport/WebSystemInterface.mm:
3044         (InitWebCoreSystemInterface):
3045
3046 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3047
3048         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
3049         https://bugs.webkit.org/show_bug.cgi?id=176867
3050
3051         Reviewed by Sam Weinig.
3052
3053         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3054         (WebKit::NetscapePluginInstanceProxy::enumerate):
3055
3056 2017-09-13  Andy Estes  <aestes@apple.com>
3057
3058         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
3059         https://bugs.webkit.org/show_bug.cgi?id=176729
3060
3061         Reviewed by Alex Christensen.
3062
3063         * WebCoreSupport/WebSystemInterface.mm:
3064         (InitWebCoreSystemInterface):
3065         * WebView/WebView.mm:
3066         (+[WebView _setCacheModel:]):
3067
3068 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3069
3070         Refactor WebContentReader out of EditorMac and EditorIOS
3071         https://bugs.webkit.org/show_bug.cgi?id=176770
3072
3073         Reviewed by Sam Weinig.
3074
3075         * WebCoreSupport/WebEditorClient.mm:
3076
3077 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3078
3079         Dragging & dropping a file creates an attachment element even when it's disabled
3080         https://bugs.webkit.org/show_bug.cgi?id=176769
3081
3082         Reviewed by Tim Horton.
3083
3084         * WebView/WebView.mm:
3085         (-[WebView _preferencesChanged:]):
3086
3087 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3088
3089         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3090         https://bugs.webkit.org/show_bug.cgi?id=176721
3091         <rdar://problem/34373660>
3092
3093         Reviewed by Tim Horton.
3094
3095         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3096         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3097
3098         * WebView/WebView.mm:
3099         (-[WebView _startDrag:]):
3100         (-[WebView _draggedElementBounds]):
3101         (-[WebView _endedDataInteraction:global:]):
3102         * WebView/WebViewData.h:
3103
3104 2017-09-11  Andy Estes  <aestes@apple.com>
3105
3106         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3107         https://bugs.webkit.org/show_bug.cgi?id=176472
3108
3109         Reviewed by Eric Carlson.
3110
3111         * WebCoreSupport/WebSystemInterface.mm:
3112         (InitWebCoreSystemInterface):
3113
3114 2017-09-09  Mark Lam  <mark.lam@apple.com>
3115
3116         Avoid duplicate computations of ExecState::vm().
3117         https://bugs.webkit.org/show_bug.cgi?id=176647
3118
3119         Reviewed by Saam Barati.
3120
3121         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3122         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3123         (WebKit::NetscapePluginInstanceProxy::construct):
3124         (WebKit::NetscapePluginInstanceProxy::setProperty):
3125         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3126         (WebKit::NetscapePluginInstanceProxy::enumerate):
3127         * Plugins/Hosted/ProxyInstance.mm:
3128         (WebKit::ProxyRuntimeMethod::create):
3129
3130 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3131
3132         Unreviewed, rolling out r221773.
3133         https://bugs.webkit.org/show_bug.cgi?id=176614
3134
3135         This caused build failures. (Requested by mlewis13 on
3136         #webkit).
3137
3138         Reverted changeset:
3139
3140         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3141         https://bugs.webkit.org/show_bug.cgi?id=176472
3142         http://trac.webkit.org/changeset/221773
3143
3144 2017-09-07  Andy Estes  <aestes@apple.com>
3145
3146         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3147         https://bugs.webkit.org/show_bug.cgi?id=176472
3148
3149         Reviewed by Eric Carlson.
3150
3151         * WebCoreSupport/WebSystemInterface.mm:
3152         (InitWebCoreSystemInterface):
3153
3154 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3155
3156         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3157         https://bugs.webkit.org/show_bug.cgi?id=176561
3158
3159         Reviewed by Brent Fulgham.
3160
3161         * Misc/WebNSUserDefaultsExtras.mm:
3162
3163 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3164
3165         Modernize Geolocation code
3166         https://bugs.webkit.org/show_bug.cgi?id=176496
3167
3168         Reviewed by Andy Estes.
3169
3170         * WebCoreSupport/WebGeolocationClient.h:
3171         * WebCoreSupport/WebGeolocationClient.mm:
3172         (WebGeolocationClient::requestPermission):
3173         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3174         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3175         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3176         * WebView/WebView.mm:
3177         (-[WebView _commonInitializationWithFrameName:groupName:]):
3178         (-[WebView _geolocationDidFailWithMessage:]):
3179
3180 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3181
3182         Remove some unused bits of code and resources
3183         https://bugs.webkit.org/show_bug.cgi?id=176275
3184
3185         Reviewed by Dan Bernstein.
3186
3187         * Misc/WebNSFileManagerExtras.mm:
3188         Include FileSystem instead of FileSystemIOS.
3189
3190 2017-09-03  Darin Adler  <darin@apple.com>
3191
3192         [Cocoa] Tidy a few things in legacy WebHTMLView
3193         https://bugs.webkit.org/show_bug.cgi?id=176280
3194
3195         Reviewed by Dan Bernstein.
3196
3197         * WebCoreSupport/WebChromeClient.mm:
3198         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3199         methods it calls on WebHTMLView were doing nothing on iOS.
3200
3201         * WebView/WebFrame.mm:
3202         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3203         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3204
3205         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3206         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3207         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3208         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3209         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3210         Use RetainPtr instead of writing retain/release wherever possible.
3211         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3212         initialization for it. Removed various unused methods and declarations of methods.
3213         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3214         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3215         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3216         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3217         and remove CFRetain no longer needed since we don't support garbage collection any more.
3218         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3219         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3220         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3221         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3222         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3223         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3224         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3225         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3226         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3227         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3228         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3229         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3230         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3231         debug flag; we haven't used it for years and it's not clearly helpful.
3232         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3233         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3234         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3235         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3236         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3237         two additional methods in the WebPrivate category and still be called by the two
3238         methods in the WebInternal category that were already using it.
3239         (-[WebHTMLView didAddSubview:]): Deleted.
3240         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3241         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3242         place this was called, the close method.
3243         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3244         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3245         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3246         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3247         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3248         Added helper method to make the one below simpler.
3249         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3250         Compared pasteboard type strings using isEqualToString: rather than using == since
3251         we want to actually compare the string contents. Also updated to use modern for loop,
3252         renamed a local variable from "s" to "localSubresources", and factored out the handling
3253         of three image types to use the helper method above.
3254         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3255         _web_makePluginSubviewsPerformSelector:withObject: method.
3256         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3257         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3258         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3259         not call the -[NSView subviews] method to make this identical on both platforms and used
3260         a modern for loop.
3261         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3262         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3263         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3264         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3265         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3266         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3267         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3268         of it is Mac-only.
3269         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3270         method did was call itself on the main thread, and do nothing if called on main thread.
3271         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3272         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3273         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3274         half of this method.
3275         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3276         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3277         Simplified using a modern for loop and RetainPtr.
3278         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3279         (-[WebHTMLView keyDown:]): Ditto.
3280         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3281         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3282         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3283         (-[WebHTMLView complete:]): Ditto.
3284         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3285         now macOS-only.
3286         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3287         iOS since that is now macOS-only.
3288         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3289         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3290         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3291         and reorganized to use early return.
3292         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3293         on iOS, but kept there so we don't have to do #if at every call site.
3294         (-[WebHTMLView _pluginController]): Moved into internal category.
3295         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3296         there only for GC, using C++ initialization, removing obsolete comment.
3297         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3298         peculiar iOS-only comment.
3299         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3300
3301         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3302         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3303         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3304         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3305         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3306
3307         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3308         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3309         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3310         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3311         them at this time.
3312
3313 2017-09-03  Sam Weinig  <sam@webkit.org>
3314
3315         Remove CanvasProxy
3316         https://bugs.webkit.org/show_bug.cgi?id=176288
3317
3318         Reviewed by Yusuke Suzuki.
3319
3320         CanvasProxy does not appear to be in any current HTML spec
3321         and was disabled and unimplemented in our tree. Time to 
3322         get rid of it.
3323
3324         * Configurations/FeatureDefines.xcconfig:
3325
3326 2017-09-02  Andy Estes  <aestes@apple.com>
3327
3328         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3329         https://bugs.webkit.org/show_bug.cgi?id=176270
3330
3331         Reviewed by Tim Horton.
3332
3333         * Plugins/Hosted/NetscapePluginHostManager.mm:
3334         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3335         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3336         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3337         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3338         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3339         (WebKit::SoftwareCARenderer::context const):
3340         (WebKit::SoftwareCARenderer::renderContext const):
3341         (WebKit::SoftwareCARenderer::render):
3342         (-[WebHostedNetscapePluginView createPlugin]):
3343         (-[WebHostedNetscapePluginView createPluginLayer]):
3344         (-[WebHostedNetscapePluginView destroyPlugin]):
3345         (-[WebHostedNetscapePluginView drawRect:]):
3346         * WebCoreSupport/WebSystemInterface.mm:
3347         (InitWebCoreSystemInterface):
3348
3349 2017-09-01  Andy Estes  <aestes@apple.com>
3350
3351         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3352         https://bugs.webkit.org/show_bug.cgi?id=176200
3353
3354         Reviewed by Tim Horton.
3355
3356         * Carbon/HIWebView.mm:
3357         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3358         (overrideCGContext):
3359         (restoreCGContext):
3360         (Draw):
3361         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3362         (+[WebHostedNetscapePluginView initialize]):
3363         * Plugins/WebBaseNetscapePluginView.h:
3364         * Plugins/WebBaseNetscapePluginView.mm:
3365         (WebKit::sendUserChangeNotifications):
3366         * Plugins/WebNetscapePluginView.mm:
3367         (+[WebNetscapePluginView initialize]):
3368         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3369         * WebCoreSupport/WebSystemInterface.mm:
3370         (InitWebCoreSystemInterface):
3371         * WebView/WebFrame.mm:
3372         (-[WebFrame _paintBehaviorForDestinationContext:]):
3373         * WebView/WebFullScreenController.mm:
3374         (setClipRectForWindow):
3375         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3376         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3377         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3378         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3379
3380 2017-08-31  Andy Estes  <aestes@apple.com>
3381
3382         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3383         https://bugs.webkit.org/show_bug.cgi?id=176175
3384
3385         Reviewed by Brady Eidson.
3386
3387         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3388         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3389         * Plugins/Hosted/WebTextInputWindowController.m:
3390         (-[WebTextInputPanel init]):
3391         * WebCoreSupport/WebSystemInterface.mm:
3392         (InitWebCoreSystemInterface):
3393         * WebView/WebDynamicScrollBarsView.mm:
3394         (-[WebDynamicScrollBarsView scrollWheel:]):
3395         * WebView/WebHTMLView.mm:
3396         (-[WebHTMLView _removeWindowObservers]):
3397         (-[WebHTMLView addWindowObservers]):
3398         * WebView/WebView.mm:
3399         (-[WebView addWindowObserversForWindow:]):
3400         (-[WebView removeWindowObservers]):
3401         (-[WebView viewWillMoveToWindow:]):
3402
3403 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3404
3405         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3406         https://bugs.webkit.org/show_bug.cgi?id=175779
3407         <rdar://problem/22367975>
3408
3409         Reviewed by Tim Horton.
3410
3411         * WebCoreSupport/WebFrameLoaderClient.h:
3412         * WebCoreSupport/WebFrameLoaderClient.mm:
3413         (WebFrameLoaderClient::webGLPolicyForURL const):
3414         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3415
3416 2017-08-30  Andy Estes  <aestes@apple.com>
3417
3418         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3419         https://bugs.webkit.org/show_bug.cgi?id=176093
3420
3421         Reviewed by Eric Carlson.
3422
3423         * WebCoreSupport/WebSystemInterface.mm:
3424         (InitWebCoreSystemInterface):
3425
3426 2017-08-30  Andy Estes  <aestes@apple.com>
3427
3428         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3429         https://bugs.webkit.org/show_bug.cgi?id=176087
3430
3431         Reviewed by Alex Christensen.
3432
3433         * Carbon/CarbonUtils.m:
3434         (getNSAutoreleasePoolCount):
3435         (WebInitForCarbon):
3436         (PoolCleaner):
3437         * Carbon/CarbonWindowAdapter.mm:
3438         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3439         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3440         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3441         (-[CarbonWindowAdapter _windowMovedToRect:]):
3442         * Carbon/HIViewAdapter.m:
3443         * Carbon/HIWebView.mm:
3444         (Draw):
3445         (CreateNSEventAdoptingCGEvent):
3446         (CopyEventCGEvent):
3447         (CreateNSEventWithCarbonClickEvent):
3448         (Click):
3449         (CreateNSEventWithCarbonEvent):
3450         (MouseUp):
3451         (CreateNSEventWithCarbonMouseMoveEvent):
3452         (MouseMoved):
3453         (MouseDragged):
3454         (MouseWheelMoved):
3455         (WindowHandler):
3456         (HIWebViewEventHandler):
3457         * Misc/QuickDrawCompatibility.h: Removed.
3458         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3459         (getCarbonEvent):
3460         (WebNetscapePluginEventHandlerCarbon::keyDown):
3461         (WebNetscapePluginEventHandlerCarbon::keyUp):
3462         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3463         (WebNetscapePluginEventHandlerCocoa::keyDown):
3464         * Plugins/WebNetscapePluginView.mm:
3465         (-[WebNetscapePluginView tellQuickTimeToChill]):
3466
3467 2017-08-29  Andy Estes  <aestes@apple.com>
3468
3469         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3470         https://bugs.webkit.org/show_bug.cgi?id=176046
3471
3472         Reviewed by Alex Christensen.
3473
3474         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3475         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3476
3477         * Misc/WebNSFileManagerExtras.mm:
3478         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3479         (setMetaData): Deleted.
3480         * WebCoreSupport/WebSystemInterface.mm:
3481         (InitWebCoreSystemInterface):
3482
3483 2017-08-28  Andy Estes  <aestes@apple.com>
3484
3485         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3486         https://bugs.webkit.org/show_bug.cgi?id=176039
3487
3488         Reviewed by Alex Christensen.
3489
3490         * WebCoreSupport/WebSystemInterface.mm:
3491         (InitWebCoreSystemInterface):
3492         * WebView/WebPreferences.mm:
3493         (+[WebPreferences _systemCFStringEncoding]):
3494
3495 2017-08-28  Andy Estes  <aestes@apple.com>
3496
3497         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3498         https://bugs.webkit.org/show_bug.cgi?id=176032
3499
3500         Reviewed by Alex Christensen.
3501
3502         * WebCoreSupport/WebSystemInterface.mm:
3503         (InitWebCoreSystemInterface):
3504         * WebView/WebView.mm:
3505         (-[WebView _cachedResponseForURL:]):
3506
3507 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3508
3509         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3510         https://bugs.webkit.org/show_bug.cgi?id=175992
3511         <rdar://problem/34086613>
3512
3513         Reviewed by Daniel Bates.
3514
3515         * WebCoreSupport/WebPlatformStrategies.h:
3516         * WebCoreSupport/WebPlatformStrategies.mm:
3517         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3518         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3519         indicating if secure cookies were accessed.
3520
3521 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3522
3523         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3524         https://bugs.webkit.org/show_bug.cgi?id=170955
3525         <rdar://problem/31697653>
3526
3527         Reviewed by Ryosuke Niwa.
3528
3529         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3530         text is being replaced.
3531
3532         * WebView/WebHTMLView.mm:
3533         (-[WebHTMLView insertText:]):
3534
3535 2017-08-24  Chris Dumez  <cdumez@apple.com>
3536
3537         [Directory Upload] Add basic support for input.webkitdirectory
3538         https://bugs.webkit.org/show_bug.cgi?id=175950
3539         <rdar://problem/33951915>
3540
3541         Reviewed by Geoffrey Garen.
3542
3543         Add private API to toggle Directory Upload support on Mac WebKit1.
3544
3545         * WebView/WebPreferenceKeysPrivate.h:
3546         * WebView/WebPreferences.mm:
3547         (+[WebPreferences initialize]):
3548         (-[WebPreferences setDirectoryUploadEnabled:]):
3549         (-[WebPreferences directoryUploadEnabled]):
3550         * WebView/WebPreferencesPrivate.h:
3551         * WebView/WebView.mm:
3552         (-[WebView _preferencesChanged:]):
3553
3554 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3555
3556         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3557         https://bugs.webkit.org/show_bug.cgi?id=175370
3558         <rdar://problem/33799806>
3559
3560         Reviewed by Ryosuke Niwa.
3561
3562         Adjust WebEditorClient for interface changes.
3563
3564         * WebCoreSupport/WebEditorClient.h:
3565
3566 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3567
3568         Remove ChromeClient::scrollbarsModeDidChange
3569         https://bugs.webkit.org/show_bug.cgi?id=175805
3570
3571         Reviewed by Daniel Bates.
3572
3573         * WebCoreSupport/WebChromeClient.h:
3574
3575 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3576
3577         Remove ChromeClient::hasOpenedPopup
3578         https://bugs.webkit.org/show_bug.cgi?id=175804
3579
3580         Reviewed by Sam Weinig.
3581
3582         * WebCoreSupport/WebChromeClient.h:
3583         * WebCoreSupport/WebChromeClient.mm:
3584         (WebChromeClient::hasOpenedPopup const): Deleted.
3585
3586 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3587
3588         Disable access to secure cookies if an HTTPS site loads mixed content
3589         https://bugs.webkit.org/show_bug.cgi?id=157053
3590         <rdar://problem/11290808>
3591
3592         Reviewed by Dan Bates.
3593
3594         * WebCoreSupport/WebPlatformStrategies.h:
3595         * WebCoreSupport/WebPlatformStrategies.mm:
3596         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3597         indicating whether secure cookies should be included in the response.
3598
3599 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3600
3601         [PAL] Move spi/mac directory into PAL
3602         https://bugs.webkit.org/show_bug.cgi?id=175649
3603
3604         Reviewed by Myles C. Maxfield.
3605
3606         * Misc/WebSharingServicePickerController.h:
3607         * WebCoreSupport/WebContextMenuClient.mm:
3608         * WebCoreSupport/WebEditorClient.mm:
3609         * WebCoreSupport/WebSelectionServiceController.mm:
3610         * WebView/WebHTMLView.mm:
3611         * WebView/WebImmediateActionController.h:
3612         * WebView/WebImmediateActionController.mm:
3613         * WebView/WebView.mm:
3614
3615 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3616
3617         [PAL] Relocate SessionID to root
3618         https://bugs.webkit.org/show_bug.cgi?id=175684
3619
3620         Reviewed by Alex Christensen.
3621
3622         * WebCoreSupport/WebFrameNetworkingContext.mm:
3623
3624 2017-08-17  Andreas Kling  <akling@apple.com>
3625
3626         Disable CSS regions at compile time
3627         https://bugs.webkit.org/show_bug.cgi?id=175630
3628
3629         Reviewed by Antti Koivisto.
3630
3631         * Configurations/FeatureDefines.xcconfig:
3632
3633 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3634
3635         [PAL] Move SessionID into PAL
3636         https://bugs.webkit.org/show_bug.cgi?id=174192
3637
3638         Reviewed by Antti Koivisto.
3639
3640         * Misc/WebCache.mm:
3641         (+[WebCache imageForURL:]):
3642         * WebCoreSupport/WebFrameLoaderClient.h:
3643         * WebCoreSupport/WebFrameLoaderClient.mm:
3644         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3645         * WebCoreSupport/WebFrameNetworkingContext.mm:
3646         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3647         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3648         (WebFrameNetworkingContext::storageSession const):
3649         * WebCoreSupport/WebPlatformStrategies.h:
3650         * WebCoreSupport/WebPlatformStrategies.mm:
3651         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3652         * WebKitPrefix.h:
3653
3654 2017-08-16  Andy Estes  <aestes@apple.com>
3655
3656         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3657         https://bugs.webkit.org/show_bug.cgi?id=175648
3658
3659         Reviewed by Tim Horton.
3660
3661         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3662         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3663         (WebPaymentCoordinatorClient::showPaymentUI):
3664
3665 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3666
3667         [PAL] Move spi/ios and spi/win directories into PAL
3668         https://bugs.webkit.org/show_bug.cgi?id=175171
3669
3670         Reviewed by Antti Koivisto.
3671
3672         * WebCoreSupport/WebFrameLoaderClient.mm:
3673         * WebView/WebView.mm:
3674
3675 2017-08-16  Andy Estes  <aestes@apple.com>
3676
3677         [Payment Request] Add an ENABLE flag and an experimental feature preference
3678         https://bugs.webkit.org/show_bug.cgi?id=175622
3679
3680         Reviewed by Tim Horton.
3681
3682         * Configurations/FeatureDefines.xcconfig:
3683
3684 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3685
3686         [PAL] Move Sleep classes into PAL
3687         https://bugs.webkit.org/show_bug.cgi?id=175456
3688
3689         Reviewed by Ryosuke Niwa.
3690
3691         * WebView/WebFullScreenController.h:
3692
3693 2017-08-15  Youenn Fablet  <youenn@apple.com>
3694
3695         [Cache API] Adding generic support for CacheStorage and Cache methods
3696         https://bugs.webkit.org/show_bug.cgi?id=175455
3697
3698         Reviewed by Chris Dumez.
3699
3700         * WebView/WebView.mm:
3701         (-[WebView _commonInitializationWithFrameName:groupName:]):
3702
3703 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3704
3705         Remove Proximity Events and related code
3706         https://bugs.webkit.org/show_bug.cgi?id=175545
3707
3708         Reviewed by Daniel Bates.
3709
3710         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3711         and other related code.
3712
3713         * Configurations/FeatureDefines.xcconfig:
3714
3715 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3716
3717         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3718         https://bugs.webkit.org/show_bug.cgi?id=175504
3719
3720         Reviewed by Sam Weinig.
3721
3722         * Configurations/FeatureDefines.xcconfig:
3723         * DOM/DOMHTMLFormElement.mm:
3724         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3725         * WebCoreSupport/WebFrameLoaderClient.h:
3726
3727 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3728
3729         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3730         https://bugs.webkit.org/show_bug.cgi?id=175557
3731
3732         Reviewed by Jon Lee.
3733
3734         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3735
3736         * Configurations/FeatureDefines.xcconfig:
3737
3738 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3739
3740         Composition underline color is always black
3741         https://bugs.webkit.org/show_bug.cgi?id=174675
3742
3743         Reviewed by Ryosuke Niwa.
3744
3745         * WebView/WebHTMLView.mm:
3746         (extractUnderlines): If NSUnderlineColorAttributeName
3747         is not present use text color for composition underline.
3748         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3749         for composition underline in the plain text case.
3750
3751 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3752
3753         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3754         https://bugs.webkit.org/show_bug.cgi?id=175474
3755         <rdar://problem/33844628>
3756
3757         Reviewed by Wenson Hsieh.
3758
3759         Replaced the build flag by a runtime flag and disabled the feature by default.
3760
3761         * Configurations/FeatureDefines.xcconfig:
3762         * WebView/WebPreferenceKeysPrivate.h:
3763         * WebView/WebPreferences.mm:
3764         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3765         (-[WebPreferences dataTransferItemsEnabled]): Added.
3766         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3767         * WebView/WebPreferencesPrivate.h:
3768         * WebView/WebView.mm:
3769         (-[WebView _preferencesChanged:]):
3770
3771 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3772
3773         Remove ENABLE_GAMEPAD_DEPRECATED
3774         https://bugs.webkit.org/show_bug.cgi?id=175361
3775
3776         Reviewed by Carlos Garcia Campos.
3777
3778         * Configurations/FeatureDefines.xcconfig:
3779
3780 2017-08-09  Chris Dumez  <cdumez@apple.com>
3781
3782         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3783         https://bugs.webkit.org/show_bug.cgi?id=175401
3784
3785         Reviewed by Brady Eidson.
3786
3787         * WebView/WebPreferenceKeysPrivate.h:
3788         * WebView/WebPreferences.mm:
3789         (+[WebPreferences initialize]):
3790         (-[WebPreferences beaconAPIEnabled]): Deleted.
3791         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3792         * WebView/WebPreferencesPrivate.h:
3793         * WebView/WebView.mm:
3794         (-[WebView _preferencesChanged:]):
3795
3796 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3797
3798         [PAL] Move spi/cocoa and spi/cg directories into PAL
3799         https://bugs.webkit.org/show_bug.cgi?id=175175
3800
3801         Reviewed by Myles C. Maxfield.
3802
3803         * History/WebHistory.mm:
3804         * Misc/WebDownload.mm:
3805         * Misc/WebKitNSStringExtras.mm:
3806         * Plugins/Hosted/NetscapePluginHostManager.mm:
3807         * Plugins/WebPluginDatabase.mm:
3808         * WebCoreSupport/WebFrameLoaderClient.mm:
3809         * WebInspector/WebNodeHighlight.mm:
3810         * WebView/WebHTMLView.mm:
3811         * WebView/WebIndicateLayer.mm:
3812         * WebView/WebView.mm:
3813         * WebView/WebViewData.h:
3814
3815 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3816
3817         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3818         https://bugs.webkit.org/show_bug.cgi?id=175392
3819         <rdar://problem/33783207>
3820
3821         Reviewed by Tim Horton and Megan Gardner.
3822
3823         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3824
3825         * Configurations/FeatureDefines.xcconfig:
3826
3827 2017-08-09  Daniel Bates  <dabates@apple.com>
3828
3829         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3830         https://bugs.webkit.org/show_bug.cgi?id=175247
3831         <rdar://problem/33679804>
3832
3833         Reviewed by Brady Eidson.
3834
3835         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3836         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3837         clients that need to make use of this information at this time. If such a needs comes up
3838         then we can expose API/SPI similar to what we do for WebKit.
3839
3840         * WebCoreSupport/WebFrameLoaderClient.h:
3841         * WebCoreSupport/WebFrameLoaderClient.mm:
3842         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3843
3844 2017-08-08  Brady Eidson  <beidson@apple.com>
3845
3846         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3847         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3848
3849         Reviewed by Andy Estes.
3850
3851         * Misc/WebKitVersionChecks.h:
3852         * WebCoreSupport/WebFrameLoaderClient.mm:
3853         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3854           the app is linked against new WebKit with the new behavior.
3855
3856 2017-08-07  Devin Rousso  <drousso@apple.com>
3857
3858         Web Inspector: Preview Canvas path when viewing a recording
3859         https://bugs.webkit.org/show_bug.cgi?id=174967
3860
3861         Reviewed by Brian Burg.
3862
3863         * WebView/WebPreferenceKeysPrivate.h:
3864         * WebView/WebPreferences.mm:
3865         (+[WebPreferences initialize]):
3866         (-[WebPreferences inspectorAdditionsEnabled]):
3867         (-[WebPreferences setInspectorAdditionsEnabled:]):
3868         * WebView/WebPreferencesPrivate.h:
3869         * WebView/WebView.mm:
3870         (-[WebView _preferencesChanged:]):
3871         Add plumbing for new InspectorAdditions runtime flag.
3872
3873 2017-08-07  Brian Burg  <bburg@apple.com>
3874
3875         Remove CANVAS_PATH compilation guard
3876         https://bugs.webkit.org/show_bug.cgi?id=175207
3877
3878         Reviewed by Sam Weinig.
3879
3880         * Configurations/FeatureDefines.xcconfig:
3881
3882 2017-08-04  Youenn Fablet  <youenn@apple.com>
3883
3884         [Cache API] Add Cache and CacheStorage IDL definitions
3885         https://bugs.webkit.org/show_bug.cgi?id=175201
3886
3887         Reviewed by Brady Eidson.
3888
3889         * WebView/WebPreferenceKeysPrivate.h:
3890         * WebView/WebPreferences.mm:
3891         (+[WebPreferences initialize]):
3892         (-[WebPreferences cacheAPIEnabled]):
3893         (-[WebPreferences setCacheAPIEnabled:]):
3894         * WebView/WebPreferencesPrivate.h:
3895         * WebView/WebView.mm:
3896         (-[WebView _preferencesChanged:]):
3897
3898 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3899
3900         Unreviewed, rolling out r220271.
3901
3902         Rolling out due to Layout Test failing on iOS Simulator.
3903
3904         Reverted changeset:
3905
3906         "Remove STREAMS_API compilation guard"
3907         https://bugs.webkit.org/show_bug.cgi?id=175165
3908         http://trac.webkit.org/changeset/220271
3909
3910 2017-08-04  Youenn Fablet  <youenn@apple.com>
3911
3912         Remove STREAMS_API compilation guard
3913         https://bugs.webkit.org/show_bug.cgi?id=175165
3914
3915         Reviewed by Darin Adler.
3916
3917         * Configurations/FeatureDefines.xcconfig:
3918         * WebView/WebPreferences.mm:
3919         (+[WebPreferences initialize]):
3920         * WebView/WebView.mm:
3921         (-[WebView _preferencesChanged:]):
3922
3923 2017-08-03  Brian Burg  <bburg@apple.com>
3924
3925         Remove ENABLE(WEB_SOCKET) guards
3926         https://bugs.webkit.org/show_bug.cgi?id=167044
3927
3928         Reviewed by Joseph Pecoraro.
3929
3930         * Configurations/FeatureDefines.xcconfig:
3931         * WebView/WebPreferencesPrivate.h:
3932
3933 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3934
3935         [PAL] Move spi/cf directory into PAL
3936         https://bugs.webkit.org/show_bug.cgi?id=175057
3937
3938         Reviewed by Antti Koivisto.
3939
3940         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3941         * Plugins/WebNetscapePluginStream.mm:
3942         * WebCoreSupport/WebFrameNetworkingContext.mm:
3943         * WebView/WebPreferences.mm:
3944         * WebView/WebView.mm:
3945
3946 2017-08-03  Youenn Fablet  <youenn@apple.com>
3947
3948         Remove FETCH_API compilation guard
3949         https://bugs.webkit.org/show_bug.cgi?id=175154
3950
3951         Reviewed by Chris Dumez.
3952
3953         * Configurations/FeatureDefines.xcconfig:
3954         * WebView/WebPreferences.mm:
3955         (+[WebPreferences initialize]):
3956         * WebView/WebView.mm:
3957         (-[WebView _preferencesChanged:]):
3958
3959 2017-08-03  Brady Eidson  <beidson@apple.com>
3960
3961         Add SW IDLs and stub out basic functionality.
3962         https://bugs.webkit.org/show_bug.cgi?id=175115
3963
3964         Reviewed by Chris Dumez.
3965
3966         * Configurations/FeatureDefines.xcconfig:
3967
3968 2017-08-02  Sam Weinig  <sam@webkit.org>
3969
3970         [WebIDL] Convert MutationCallback to be a normal generated callback
3971         https://bugs.webkit.org/show_bug.cgi?id=174140
3972
3973         Reviewed by Darin Adler.
3974
3975         * DOM/DOMDocument.mm:
3976         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3977         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3978         Pass, now necessary, Document to NativeNodeFilter constructor.
3979
3980 2017-08-01  Chris Dumez  <cdumez@apple.com>
3981
3982         Add initial support for navigator.sendBeacon
3983         https://bugs.webkit.org/show_bug.cgi?id=175007
3984         <rdar://problem/33547728>
3985
3986         Reviewed by Sam Weinig.
3987
3988         Add setting to toggle support for the Beacon API (it is disabled by default).
3989
3990         * WebView/WebPreferenceKeysPrivate.h:
3991         * WebView/WebPreferences.mm:
3992         (+[WebPreferences initialize]):
3993         (-[WebPreferences beaconAPIEnabled]):
3994         (-[WebPreferences setBeaconAPIEnabled:]):
3995         * WebView/WebPreferencesPrivate.h:
3996         * WebView/WebView.mm:
3997         (-[WebView _preferencesChanged:]):
3998
3999 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
4000
4001         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
4002         https://bugs.webkit.org/show_bug.cgi?id=174437
4003
4004         Reviewed by Darin Adler.
4005
4006         Remove redundant Web- prefix from classes in WebKit namespace.
4007
4008         * WebView/WebView.mm:
4009         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
4010         * WebView/WebViewData.h:
4011         * WebView/WebViewData.mm:
4012
4013 2017-07-26  Brian Burg  <bburg@apple.com>
4014
4015         Remove WEB_TIMING feature flag
4016         https://bugs.webkit.org/show_bug.cgi?id=174795
4017
4018         Reviewed by Alex Christensen.
4019
4020         * Configurations/FeatureDefines.xcconfig:
4021
4022 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
4023
4024         Async image decoding for large images should be disabled after the first time a tile is painted
4025         https://bugs.webkit.org/show_bug.cgi?id=174451
4026         <rdar://problem/31246421>
4027
4028         Reviewed by Simon Fraser.
4029
4030         * WebView/WebFrame.mm:
4031         (-[WebFrame _paintBehaviorForDestinationContext:]):
4032         (-[WebFrame _drawRect:contentsOnly:]):
4033         * WebView/WebHTMLView.mm:
4034         (imageFromRect):
4035
4036 2017-07-23  Darin Adler  <darin@apple.com>
4037
4038         More NeverDestroyed and related cleanup
4039         https://bugs.webkit.org/show_bug.cgi?id=174745
4040
4041         Reviewed by Alex Christensen.
4042
4043         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
4044         for names that aren't even used in this file.
4045         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
4046         -[NSArray arrayWithObject:].
4047         (-[DOMNode absoluteQuads]): Ditto.
4048         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
4049         of writing out various types.
4050         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
4051         syntax instea of -[NSArray arrayWithObject:].
4052         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
4053         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
4054         of writing out various types.
4055         (-[DOMHTMLImageElement mimeType]): Ditto.
4056
4057 2017-07-24  Chris Dumez  <cdumez@apple.com>
4058
4059         ExceptionCode enumeration should use modern exception names
4060         https://bugs.webkit.org/show_bug.cgi?id=174794
4061
4062         Reviewed by Geoffrey Garen.
4063
4064         * DOM/ExceptionHandlers.mm:
4065         (raiseNotSupportedErrorException):
4066
4067 2017-07-23  Chris Dumez  <cdumez@apple.com>
4068
4069         Drop ExceptionCodeDescription class
4070         https://bugs.webkit.org/show_bug.cgi?id=174757
4071
4072         Reviewed by Darin Adler.
4073
4074         Stop using ExceptionCodeDescription.
4075
4076         * DOM/ExceptionHandlers.mm:
4077         (raiseDOMErrorException):
4078
4079 2017-07-21  Andreas Kling  <akling@apple.com>
4080
4081         Use more references in event dispatch code
4082         https://bugs.webkit.org/show_bug.cgi?id=174681
4083
4084         Reviewed by Geoffrey Garen.
4085
4086         * DOM/ObjCEventListener.h: