[Mac] WebKit fails to receive file promises when the embedding app is sandboxed
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-09  Andy Estes  <aestes@apple.com>
2
3         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
4         https://bugs.webkit.org/show_bug.cgi?id=183489
5         <rdar://problem/38267517>
6
7         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
8         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
9         to issue a sandbox extension for this directory, but for security reasons App Sandbox
10         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
11         block with a nil error and a valid file URL, but no file will actually exist at that URL.
12
13         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
14         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
15         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
16         drop destination.
17
18         Reviewed by Wenson Hsieh.
19
20         * WebView/WebView.mm:
21         (-[WebView performDragOperation:]):
22
23 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
24
25         Allow WebViews to disable system appearance
26         https://bugs.webkit.org/show_bug.cgi?id=183418
27         <rdar://problem/36975642>
28
29         Reviewed by Tim Horton.
30
31         Allow webviews to choose whether or not to follow the default system appearance.
32
33         * WebView/WebView.mm:
34         (-[WebView _setUseSystemAppearance:]):
35         (-[WebView _useSystemAppearance]):
36         * WebView/WebViewPrivate.h:
37
38 2018-03-08  Youenn Fablet  <youenn@apple.com>
39
40         libwebrtc update broke internal builds
41         https://bugs.webkit.org/show_bug.cgi?id=183454
42
43         Reviewed by Eric Carlson.
44
45         * Configurations/WebKitLegacy.xcconfig:
46
47 2018-03-08  Chris Dumez  <cdumez@apple.com>
48
49         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
50         https://bugs.webkit.org/show_bug.cgi?id=183455
51         <rdar://problem/38191749>
52
53         Reviewed by Youenn Fablet.
54
55         Add a null check for the page as we have evidence from crashes that it can be null.
56         Other functions in WebFrameNetworkingContext already null check the page as well,
57         not just the frame so this is consistent.
58
59         * WebCoreSupport/WebFrameNetworkingContext.mm:
60         (WebFrameNetworkingContext::storageSession const):
61
62 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
63
64         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
65         https://bugs.webkit.org/show_bug.cgi?id=183429
66
67         Reviewed by Mark Lam.
68
69         * DOM/DOM.mm:
70         (+[DOMNode _nodeFromJSWrapper:]):
71         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
72         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
73         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
74         * Plugins/Hosted/ProxyInstance.mm:
75         (WebKit::ProxyInstance::invokeMethod):
76         * WebView/WebView.mm:
77         (aeDescFromJSValue):
78
79 2018-03-08  Tim Horton  <timothy_horton@apple.com>
80
81         Stop linking ApplicationServices directly
82         https://bugs.webkit.org/show_bug.cgi?id=182867
83         <rdar://problem/38252142>
84
85         Reviewed by Alex Christensen.
86
87         The frameworks that we use that live inside ApplicationServices
88         have mostly moved out, so import them directly.
89
90         * Carbon/CarbonUtils.h:
91         * WebKitPrefix.h:
92         * WebView/WebHTMLView.mm:
93         * WebView/WebPDFView.mm:
94
95 2018-03-07  Tim Horton  <timothy_horton@apple.com>
96
97         Sort and separate FeatureDefines.xcconfig
98         https://bugs.webkit.org/show_bug.cgi?id=183427
99
100         Reviewed by Dan Bernstein.
101
102         * Configurations/FeatureDefines.xcconfig:
103         Sort and split FeatureDefines into paragraphs
104         (to make it easier to sort later).
105
106 2018-03-07  Youenn Fablet  <youenn@apple.com>
107
108         Match unsupported plugins based on domains and not origin
109         https://bugs.webkit.org/show_bug.cgi?id=183384
110
111         Reviewed by Chris Dumez.
112
113         * WebCoreSupport/WebPluginInfoProvider.h:
114         * WebCoreSupport/WebPluginInfoProvider.mm:
115         (WebPluginInfoProvider::getPluginInfo):
116         (WebPluginInfoProvider::getWebVisiblePluginInfo):
117
118 2018-03-05  Andy Estes  <aestes@apple.com>
119
120         [Mac] Teach WebCore::Pasteboard about file promise drags
121         https://bugs.webkit.org/show_bug.cgi?id=183314
122         <rdar://problem/38105493>
123
124         Reviewed by Darin Adler.
125
126         Added a FIXME comment.
127
128         * WebView/WebView.mm:
129         (-[WebView performDragOperation:]):
130
131 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
132
133         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
134         https://bugs.webkit.org/show_bug.cgi?id=183312
135
136         Reviewed by Mark Lam.
137
138         Remove wtf/CurrentTime.h include pragma.
139
140         * WebView/WebFrame.mm:
141         * WebView/WebPDFView.mm:
142
143 2018-03-04  Tim Horton  <timothy_horton@apple.com>
144
145         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
146         https://bugs.webkit.org/show_bug.cgi?id=183283
147         <rdar://problem/38062148>
148
149         Reviewed by Sam Weinig.
150
151         * Configurations/FeatureDefines.xcconfig:
152
153 2018-02-28  Alex Christensen  <achristensen@webkit.org>
154
155         Reduce use of NetworkingContext in WebKit
156         https://bugs.webkit.org/show_bug.cgi?id=183213
157
158         Reviewed by Brady Eidson.
159
160         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
161         (WebKit::NetscapePluginInstanceProxy::getProxy):
162         * Plugins/WebNetscapePluginView.mm:
163         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
164
165 2018-02-17  Darin Adler  <darin@apple.com>
166
167         Prepare for ExtendedColor changes (first step)
168         https://bugs.webkit.org/show_bug.cgi?id=182904
169
170         Reviewed by Sam Weinig.
171
172         * Misc/WebKitNSStringExtras.mm:
173         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
174
175 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
176
177         Remove currentTime() / currentTimeMS()
178         https://bugs.webkit.org/show_bug.cgi?id=183052
179
180         Reviewed by Mark Lam.
181
182         * WebCoreSupport/WebFrameLoaderClient.h:
183         * WebCoreSupport/WebFrameLoaderClient.mm:
184         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
185
186 2018-02-16  Youenn Fablet  <youenn@apple.com>
187
188         Allow specifying which plug-ins are supported
189         https://bugs.webkit.org/show_bug.cgi?id=182748
190
191         Reviewed by Chris Dumez.
192
193         * WebCoreSupport/WebPluginInfoProvider.h:
194         * WebCoreSupport/WebPluginInfoProvider.mm:
195         (WebPluginInfoProvider::getPluginInfo):
196         (WebPluginInfoProvider::getWebVisiblePluginInfo):
197
198 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
199
200         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
201         https://bugs.webkit.org/show_bug.cgi?id=182882
202         <rdar://problem/35672661>
203
204         Reviewed by Dan Bernstein.
205
206         Make sure the smart pointer hold the collection of subviews lives at least as
207         long as the loop using it.
208
209         * WebView/WebHTMLView.mm:
210         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
211
212 2018-02-14  Daniel Bates  <dabates@apple.com>
213
214         Disallow cross-origin subresources from asking for credentials
215         https://bugs.webkit.org/show_bug.cgi?id=182579
216         <rdar://problem/36162271>
217
218         Reviewed by Andy Estes.
219
220         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
221         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
222
223         * WebView/WebPreferenceKeysPrivate.h:
224         * WebView/WebPreferences.mm:
225         (+[WebPreferences initialize]):
226         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
227         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
228         * WebView/WebPreferencesPrivate.h:
229         * WebView/WebView.mm:
230         (-[WebView _preferencesChanged:]):
231
232 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
233
234         Remove ForwardingHeaders directory from WebKitLegacy/mac.
235         https://bugs.webkit.org/show_bug.cgi?id=182738
236
237         Reviewed by Darin Adler.
238
239         * ForwardingHeaders/collector/handles/Global.h: Removed.
240         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
241         * ForwardingHeaders/runtime/Completion.h: Removed.
242         * ForwardingHeaders/runtime/Error.h: Removed.
243         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
244         * ForwardingHeaders/runtime/JSFunction.h: Removed.
245         * ForwardingHeaders/runtime/JSLock.h: Removed.
246         * ForwardingHeaders/runtime/JSObject.h: Removed.
247         * ForwardingHeaders/runtime/JSString.h: Removed.
248         * ForwardingHeaders/runtime/Protect.h: Removed.
249         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
250
251 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
252
253         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
254         https://bugs.webkit.org/show_bug.cgi?id=182641
255
256         Reviewed by Dan Bernstein.
257
258         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
259         https://trac.webkit.org/changeset/228308.
260
261         * WebView/WebVideoFullscreenController.h:
262         * WebView/WebVideoFullscreenHUDWindowController.mm:
263         * WebView/WebWindowAnimation.h:
264         * WebView/WebWindowAnimation.mm:
265         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
266         (WebCore::scaledRect): Deleted.
267         (WebCore::squaredDistance): Deleted.
268
269 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
270
271         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
272
273         * WebView/WebWindowAnimation.mm:
274         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
275
276 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
277
278         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
279         https://bugs.webkit.org/show_bug.cgi?id=182615
280
281         Reviewed by Eric Carlson.
282
283         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
284         Ideally, we should not reference NSApp in WebCore.
285
286         * WebView/WebFullScreenController.mm:
287         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
288         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
289         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
290         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
291         * WebView/WebView.mm:
292         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
293         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
294
295 2018-01-13  Darin Adler  <darin@apple.com>
296
297         Event improvements
298         https://bugs.webkit.org/show_bug.cgi?id=179591
299
300         Reviewed by Chris Dumez.
301
302         * DOM/DOMWheelEvent.mm:
303         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
304         Call initWebKitWheelEvent.
305
306         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
307         * WebCoreSupport/WebInspectorClient.mm: Ditto.
308         * WebView/WebFrame.mm: Ditto.
309
310         * WebView/WebHTMLView.mm:
311         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
312         underlyingPlatformEvent.
313         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
314
315         * WebView/WebScriptWorld.mm:
316         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
317
318         * WebView/WebView.mm: Removed include of ScriptValue.h.
319
320 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
321
322         Remove WebCore/ForwardingHeaders directory
323         https://bugs.webkit.org/show_bug.cgi?id=182347
324
325         Reviewed by Keith Miller.
326
327         * Carbon/CarbonWindowAdapter.mm:
328         * DOM/WebDOMOperations.mm:
329         * History/WebBackForwardList.mm:
330         * History/WebHistoryItem.mm:
331         * Misc/WebCache.mm:
332         * Misc/WebElementDictionary.mm:
333         * Misc/WebIconDatabase.mm:
334         * Misc/WebStringTruncator.mm:
335         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
336         * Plugins/Hosted/ProxyInstance.mm:
337         * Plugins/Hosted/ProxyRuntimeObject.mm:
338         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
339         * Plugins/WebBaseNetscapePluginView.mm:
340         * Plugins/WebBasePluginPackage.mm:
341         * Plugins/WebNetscapePluginStream.mm:
342         * Plugins/WebNetscapePluginView.mm:
343         * Plugins/WebPluginController.mm:
344         * WebCoreSupport/WebEditorClient.mm:
345         * WebCoreSupport/WebFrameLoaderClient.mm:
346         * WebCoreSupport/WebInspectorClient.h:
347         * WebCoreSupport/WebInspectorClient.mm:
348         * WebView/WebDataSource.mm:
349         * WebView/WebFrame.mm:
350         * WebView/WebHTMLRepresentation.mm:
351         * WebView/WebHTMLView.mm:
352         * WebView/WebPreferences.mm:
353         * WebView/WebScriptDebugDelegate.mm:
354         * WebView/WebScriptDebugger.h:
355         * WebView/WebTextIterator.mm:
356         * WebView/WebView.mm:
357         * WebView/WebViewData.mm:
358
359 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
360
361         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
362         https://bugs.webkit.org/show_bug.cgi?id=182312
363
364         Reviewed by Michael Catanzaro.
365
366         * WebKitPrefix.h:
367
368 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
369
370         [WebAuthN] Add a compile-time feature flag
371         https://bugs.webkit.org/show_bug.cgi?id=182211
372         <rdar://problem/36936365>
373
374         Reviewed by Brent Fulgham.
375
376         * Configurations/FeatureDefines.xcconfig:
377
378 2018-01-27  Dan Bernstein  <mitz@apple.com>
379
380         HaveInternalSDK includes should be "#include?"
381         https://bugs.webkit.org/show_bug.cgi?id=179670
382
383         * Configurations/Base.xcconfig:
384
385 2018-01-24  Alex Christensen  <achristensen@webkit.org>
386
387         Remove unused QTKit preference
388         https://bugs.webkit.org/show_bug.cgi?id=181968
389
390         Reviewed by Alexey Proskuryakov.
391
392         * WebView/WebPreferenceKeysPrivate.h:
393         * WebView/WebPreferences.mm:
394         (+[WebPreferences initialize]):
395         (-[WebPreferences setQTKitEnabled:]): Deleted.
396         (-[WebPreferences isQTKitEnabled]): Deleted.
397         * WebView/WebPreferencesPrivate.h:
398         * WebView/WebView.mm:
399         (-[WebView _preferencesChanged:]):
400
401 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
402
403         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
404         https://bugs.webkit.org/show_bug.cgi?id=182037
405         <rdar://problem/36747812>
406
407         Reviewed by Ryosuke Niwa.
408
409         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
410         for more details.
411
412         * WebView/WebHTMLRepresentation.mm:
413         (-[WebHTMLRepresentation elementWithName:inForm:]):
414         (-[WebHTMLRepresentation controlsInForm:]):
415
416 2018-01-23  Alex Christensen  <achristensen@webkit.org>
417
418         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
419         https://bugs.webkit.org/show_bug.cgi?id=181961
420
421         Reviewed by Michael Catanzaro.
422
423         * WebView/WebPreferences.mm:
424
425 2018-01-23  Commit Queue  <commit-queue@webkit.org>
426
427         Unreviewed, rolling out r227437.
428         https://bugs.webkit.org/show_bug.cgi?id=182011
429
430         broke build (Requested by alexchristensen on #webkit).
431
432         Reverted changeset:
433
434         "Remove unused QTKit preference"
435         https://bugs.webkit.org/show_bug.cgi?id=181968
436         https://trac.webkit.org/changeset/227437
437
438 2018-01-23  Alex Christensen  <achristensen@webkit.org>
439
440         Remove unused QTKit preference
441         https://bugs.webkit.org/show_bug.cgi?id=181968
442
443         Reviewed by Alexey Proskuryakov.
444
445         * WebView/WebPreferenceKeysPrivate.h:
446         * WebView/WebPreferences.mm:
447         (+[WebPreferences initialize]):
448         (-[WebPreferences setQTKitEnabled:]): Deleted.
449         (-[WebPreferences isQTKitEnabled]): Deleted.
450         * WebView/WebPreferencesPrivate.h:
451         * WebView/WebView.mm:
452         (-[WebView _preferencesChanged:]):
453
454 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
455
456         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
457         https://bugs.webkit.org/show_bug.cgi?id=181960
458         <rdar://problem/36431678>
459
460         Reviewed by Tim Horton.
461
462         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
463         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
464         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
465
466         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
467         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
468         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
469
470         * WebView/WebView.mm:
471         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
472
473 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
474
475         Turning off custom pasteboard data doesn't actually turn it off in WK2
476         https://bugs.webkit.org/show_bug.cgi?id=181920
477         <rdar://problem/36686429>
478
479         Reviewed by Wenson Hsieh.
480
481         Always disable custom pasteboard data in WebKit1. See r226156 for details.
482
483         * WebView/WebPreferences.mm:
484         (+[WebPreferences initialize]):
485         * WebView/WebView.mm:
486         (-[WebView _preferencesChanged:]):
487
488 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
489
490         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
491         https://bugs.webkit.org/show_bug.cgi?id=181918
492
493         Reviewed by Tim Horton.
494
495         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
496
497         * Configurations/FeatureDefines.xcconfig:
498
499 2018-01-20  Andy Estes  <aestes@apple.com>
500
501         [Apple Pay] Stop eagerly loading PassKit.framework
502         https://bugs.webkit.org/show_bug.cgi?id=181911
503         <rdar://problem/36555369>
504
505         Reviewed by Tim Horton.
506
507         * WebCoreSupport/WebPaymentCoordinatorClient.h:
508         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
509         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
510
511         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
512
513 2018-01-19  Dean Jackson  <dino@apple.com>
514
515         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
516         https://bugs.webkit.org/show_bug.cgi?id=181817
517         <rdar://problem/35274055>
518
519         Reviewed by Simon Fraser.
520
521         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
522
523         * Misc/WebKitVersionChecks.h:
524         * WebView/WebView.mm:
525         (-[WebView _commonInitializationWithFrameName:groupName:]):
526
527 2018-01-19  Alex Christensen  <achristensen@webkit.org>
528
529         Remove unused WebViewPrivate _allowCookies
530         https://bugs.webkit.org/show_bug.cgi?id=181812
531
532         Reviewed by Tim Horton.
533
534         * WebView/WebView.mm:
535         (+[WebView _setAllowCookies:]): Deleted.
536         (+[WebView _allowCookies]): Deleted.
537         * WebView/WebViewPrivate.h:
538
539 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
540
541         Build fix, remove a call to -[NSWindow setOneShot:]
542         https://bugs.webkit.org/show_bug.cgi?id=181809
543
544         Reviewed by Tim Horton.
545
546         * WebView/WebTextCompletionController.mm:
547         (-[WebTextCompletionController _buildUI]):
548
549 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
550
551         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
552
553         * Carbon/HIWebView.mm:
554         (overrideCGContext):
555         (restoreCGContext):
556
557 2018-01-18  Dan Bernstein  <mitz@apple.com>
558
559         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
560         https://bugs.webkit.org/show_bug.cgi?id=181803
561
562         Reviewed by Tim Horton.
563
564         * Configurations/Base.xcconfig: Updated.
565         * Configurations/DebugRelease.xcconfig: Ditto.
566         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
567         * Configurations/Version.xcconfig: Updated.
568         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
569           useful for defining settings that depend on the target macOS version.
570
571 2018-01-17  Youenn Fablet  <youenn@apple.com>
572
573         Put fetch Request.keepalive behind a runtime flag
574         https://bugs.webkit.org/show_bug.cgi?id=181592
575
576         Reviewed by Chris Dumez.
577
578         * WebView/WebPreferenceKeysPrivate.h:
579         * WebView/WebPreferences.mm:
580         (+[WebPreferences initialize]):
581         (-[WebPreferences fetchAPIKeepAliveEnabled]):
582         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
583         * WebView/WebPreferencesPrivate.h:
584         * WebView/WebView.mm:
585         (-[WebView _preferencesChanged:]):
586
587 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
588
589         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
590         https://bugs.webkit.org/show_bug.cgi?id=181637
591         <rdar://problem/36508471>
592
593         Reviewed by Tim Horton.
594
595         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
596
597         * WebCoreSupport/WebEditorClient.h:
598         * WebCoreSupport/WebEditorClient.mm:
599         (WebEditorClient::replacementURLForResource):
600
601 2018-01-11  Keith Miller  <keith_miller@apple.com>
602
603         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
604         https://bugs.webkit.org/show_bug.cgi?id=181573
605
606         Reviewed by Simon Fraser.
607
608         * Configurations/FeatureDefines.xcconfig:
609
610 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
611
612         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
613         https://bugs.webkit.org/show_bug.cgi?id=181497
614
615         Reviewed by Tim Horton.
616
617         See other ChangeLogs for more detail.
618
619         * WebCoreSupport/WebDragClient.h:
620
621 2018-01-11  Tim Horton  <timothy_horton@apple.com>
622
623         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
624         https://bugs.webkit.org/show_bug.cgi?id=181523
625         <rdar://problem/28959131>
626
627         Reviewed by Alex Christensen.
628
629         * WebView/WebImmediateActionController.mm:
630         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
631         Apply the change made in r216652 to WebKit1's immediate action controller.
632
633         Speculative (but successful in WebKit2) fix for non-reproducible crash when
634         the startContainer of the range is in an anonymous node.
635
636 2018-01-11  Youenn Fablet  <youenn@apple.com>
637
638         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
639         https://bugs.webkit.org/show_bug.cgi?id=181480
640
641         Reviewed by Eric Carlson.
642
643         * WebView/WebPreferences.mm:
644         (+[WebPreferences initialize]):
645
646 2018-01-08  David Kilzer  <ddkilzer@apple.com>
647
648         Fix check-webkit-style issues with WebNSDataExtras.mm
649         <https://webkit.org/b/181369>
650
651         Reviewed by Alex Christensen.
652
653         * Misc/WebNSDataExtras.mm:
654         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
655         (-[NSData _webkit_guessedMIMETypeForXML]):
656         (-[NSData _webkit_guessedMIMEType]):
657         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
658         (_findEOL):
659         (-[NSData _webkit_parseRFC822HeaderFields]):
660         (-[NSData _web_locationAfterFirstBlankLine]):
661         - Fix all the check-webkit-style warnings.
662
663 2018-01-08  David Kilzer  <ddkilzer@apple.com>
664
665         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
666         <https://webkit.org/b/181256>
667         <rdar://problem/36281730>
668
669         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
670         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
671         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
672           to avoid warnings from casting CFStringRef to NPNSString*.
673           Note that CFMutableStringRef is the same as CFStringRef
674           without the const modifier, hence its use in the const_cast<>
675           above.
676
677 2018-01-08  David Kilzer  <ddkilzer@apple.com>
678
679         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
680         <https://webkit.org/b/181256>
681         <rdar://problem/36281730>
682
683         * Carbon/HIWebView.mm:
684         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
685         checked_cf_cast<CFRunLoopRef>() to fix warning.
686
687 2018-01-07  David Kilzer  <ddkilzer@apple.com>
688
689         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
690         <https://webkit.org/b/181256>
691         <rdar://problem/36281730>
692
693         Reviewed by Darin Adler.
694
695         * Carbon/CarbonUtils.m:
696         (PoolCleaner):
697         - Use #pragmas to ignore -Wcast-qual warnings when using a
698           C-style cast from CFTypeRef to CFRunloopRef.
699         * Carbon/CarbonWindowFrame.m:
700         (-[CarbonWindowFrame title]):
701         - Use #pragmas to ignore -Wcast-qual warnings when using a
702           C-style cast from CFStringRef to NSString *.
703         * Carbon/HIViewAdapter.m:
704         (+[HIViewAdapter getHIViewForNSView:]):
705         - Use #pragmas to ignore -Wcast-qual warnings when using a
706           C-style cast from CFTypeRef to HIViewRef.
707         * Configurations/Base.xcconfig:
708         (WARNING_CFLAGS): Add -Wcast-qual.
709         * Misc/WebElementDictionary.mm:
710         (-[WebElementDictionary objectForKey:]):
711         - Use static_cast<SEL>(const_cast<void*>()) to fix
712           warning.
713         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
714         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
715         (-[NSData _webkit_guessedMIMETypeForXML]):
716         (-[NSData _webkit_guessedMIMEType]):
717         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
718         (_findEOL):
719         (-[NSData _webkit_parseRFC822HeaderFields]):
720         (-[NSData _web_startsWithBlankLine]):
721         (-[NSData _web_locationAfterFirstBlankLine]):
722         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
723           type to Objective-C++.  This fixes the warnings about
724           discarding the `const` modifier when casing from CFStringRef
725           to NSString * because in older clang versions, -Wcast-qual was
726           completely broken when compiling C++ and Objective-C++ source
727           files.  In newer clang versions, discarding the `const`
728           modifier for toll-free bridged types is ignored when compiling
729           Objective-C++ source.
730         - Update copyright and license header.
731         - Use reinterpret_cast<> and static_cast<> to fix warnings
732           unrelated to (NSString *) C-style casts.
733         - Replace use of MIN() macro with std::min<> template functions.
734         - Fix location of `*` for local variables modified above.
735         * Plugins/Hosted/NetscapePluginHostManager.mm:
736         (WebKit::NetscapePluginHostManager::spawnPluginHost):
737         (WebKit::NetscapePluginHostManager::initializeVendorPort):
738         (WebKit::NetscapePluginHostManager::instantiatePlugin):
739         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
740           warnings.
741         * Plugins/Hosted/NetscapePluginHostProxy.mm:
742         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
743         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
744           to fix warning.
745         * Plugins/Hosted/ProxyInstance.mm:
746         (WebKit::ProxyInstance::invoke):
747         - Use static_cast<char*>(const_cast<void*>()) to fix
748           warning when using -[NSData bytes].
749         (WebKit::ProxyInstance::fieldValue const):
750         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
751           to fix warning when using CFDataGetBytePtr().
752         * Plugins/Hosted/WebTextInputWindowController.m:
753         (-[WebTextInputPanel _interpretKeyEvent:string:]):
754         - Use #pragma to ignore -Wcast-qual warning since there
755           is not a good way to avoid this warning in Objective-C.
756         * Plugins/WebNetscapePluginStream.mm:
757         (WebNetscapePluginStream::deliverData):
758         - Use const_cast<void*>() to fix warning when using
759           -[NSData bytes].
760         * Plugins/WebNetscapePluginView.mm:
761         (-[WebNetscapePluginView _createPlugin]):
762         - Change C-style cast to const_cast<char*>() to fix
763           warning.
764         * WebCoreSupport/WebChromeClient.mm:
765         (WebChromeClient::wrapCryptoKey const):
766         (WebChromeClient::unwrapCryptoKey const):
767         - Change C-style cast to
768           static_cast<uint8_t*>(const_cast<void*>() to fix
769           warning.
770         * WebView/WebPDFView.mm:
771         (_applicationInfoForMIMEType):
772         - Change local variable type from 'NSURL *' to
773           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
774           when calling -[NSURL path].
775
776 2018-01-05  Dan Bernstein  <mitz@apple.com>
777
778         Fixed the build following AppKit API deprecations in a recent SDKs
779
780         * WebView/WebFullScreenController.mm:
781         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
782         (-[WebFullScreenController exitFullScreen]): Ditto.
783         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
784         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
785         * WebView/WebHTMLView.mm:
786         (-[WebHTMLView drawRect:]): Ditto.
787         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
788         (-[WebHTMLView knowsPageRange:]): Ditto.
789         * WebView/WebView.mm:
790         (LayerFlushController::flushLayers): Ditto.
791
792 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
793
794         [Attachment Support] Create attachment elements when dropping files on iOS
795         https://bugs.webkit.org/show_bug.cgi?id=181192
796         <rdar://problem/36280945>
797
798         Reviewed by Tim Horton.
799
800         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
801
802         * WebCoreSupport/WebPlatformStrategies.h:
803         * WebCoreSupport/WebPlatformStrategies.mm:
804         (WebPlatformStrategies::informationForItemAtIndex):
805         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
806
807 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
808
809         [Attachment Support] Add plumbing for starting a drag with promised blob data
810         https://bugs.webkit.org/show_bug.cgi?id=181201
811
812         Reviewed by Tim Horton.
813
814         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
815
816         * WebCoreSupport/WebDragClient.h:
817
818 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
819
820         Add a WebAuthentication runtime feature flag
821         https://bugs.webkit.org/show_bug.cgi?id=181220
822         <rdar://problem/36055305>
823
824         Reviewed by Brent Fulgham.
825
826         Renames the CredentialManagement runtime feature flag into WebAuthentication.
827
828         * WebView/WebPreferenceKeysPrivate.h:
829         * WebView/WebPreferences.mm:
830         (+[WebPreferences initialize]):
831         (-[WebPreferences webAuthenticationEnabled]):
832         (-[WebPreferences setWebAuthenticationEnabled:]):
833         (-[WebPreferences credentialManagementEnabled]): Deleted.
834         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
835         * WebView/WebPreferencesPrivate.h:
836         * WebView/WebView.mm:
837         (-[WebView _preferencesChanged:]):
838
839 2017-12-22  Jeff Miller  <jeffm@apple.com>
840
841         Update user-visible copyright strings to include 2018
842         https://bugs.webkit.org/show_bug.cgi?id=181141
843
844         Reviewed by Dan Bernstein.
845
846         * Info.plist:
847
848 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
849
850         [Attachment Support] Remove current macOS support for dragging file-backed attachments
851         https://bugs.webkit.org/show_bug.cgi?id=181188
852
853         Reviewed by Dan Bernstein.
854
855         See WebCore/ChangeLog for more detail.
856
857         * WebCoreSupport/WebDragClient.h:
858         * WebCoreSupport/WebDragClient.mm:
859         (WebDragClient::declareAndWriteAttachment): Deleted.
860         * WebView/WebHTMLView.mm:
861         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
862
863 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
864
865         Unreviewed, continue to fix build failures due to AppKit API deprecation
866
867         Wraps more code in -Wdeprecated-declarations.
868
869         * Carbon/HIWebView.mm:
870         (overrideCGContext):
871
872 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
873
874         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
875
876         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
877
878         * Carbon/CarbonWindowAdapter.mm:
879         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
880         * Plugins/WebNetscapePluginView.mm:
881         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
882         (-[WebNetscapePluginView sendDrawRectEvent:]):
883         (-[WebNetscapePluginView drawRect:]):
884
885 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
886
887         Fix build failures due to using deprecated AppKit symbols
888         https://bugs.webkit.org/show_bug.cgi?id=181110
889         <rdar://problem/36162865>
890
891         Reviewed by Dan Bernstein and Tim Horton.
892
893         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
894
895         * Misc/WebKitNSStringExtras.mm:
896         (-[NSString _web_drawAtPoint:font:textColor:]):
897         * Misc/WebNSPasteboardExtras.h:
898         * Misc/WebNSPasteboardExtras.mm:
899         (+[NSPasteboard _web_writableTypesForURL]):
900         (_createWritableTypesForImageWithoutArchive):
901         (_createWritableTypesForImageWithArchive):
902         (+[NSPasteboard _web_dragTypesForURL]):
903         (-[NSPasteboard _web_bestURL]):
904         (-[NSPasteboard _web_writeURL:andTitle:types:]):
905         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
906         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
907         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
908         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
909         * Panels/WebAuthenticationPanel.m:
910         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
911         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
912         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
913         (-[WebHostedNetscapePluginView drawRect:]):
914         * WebInspector/WebNodeHighlightView.mm:
915         (-[WebNodeHighlightView drawRect:]):
916         * WebView/WebFrame.mm:
917         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
918         (-[WebFrame _drawRect:contentsOnly:]):
919         * WebView/WebHTMLView.mm:
920         (kit):
921         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
922         (-[WebHTMLView _plainTextFromPasteboard:]):
923         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
924         (+[WebHTMLView _insertablePasteboardTypes]):
925         (+[WebHTMLView _selectionPasteboardTypes]):
926         (-[WebHTMLView pasteboard:provideDataForType:]):
927         (-[WebHTMLView _writeSelectionToPasteboard:]):
928         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
929         (-[WebHTMLView validRequestorForSendType:returnType:]):
930         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
931         (createMenuItem):
932         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
933         (-[WebHTMLView _colorAsString:]):
934         (-[WebHTMLView copyFont:]):
935         * WebView/WebPDFView.mm:
936         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
937         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
938         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
939         (-[WebPDFView pasteboardTypesForSelection]):
940         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
941         * WebView/WebView.h:
942         * WebView/WebView.mm:
943         (-[WebView performDragOperation:]):
944         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
945         (-[WebView _searchWithGoogleFromMenu:]):
946
947 2017-12-21  Youenn Fablet  <youenn@apple.com>
948
949         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
950         https://bugs.webkit.org/show_bug.cgi?id=181000
951
952         Reviewed by Chris Dumez.
953
954         * Misc/WebCache.mm:
955         (+[WebCache addImageToCache:forURL:forFrame:]):
956
957 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
958
959         Update FULLSCREEN_API feature defines.
960         https://bugs.webkit.org/show_bug.cgi?id=181015
961
962         Reviewed by Tim Horton.
963
964         Change enabled iphone sdk for FULLSCREEN_API.
965
966         * Configurations/FeatureDefines.xcconfig:
967
968 2017-12-21  Jer Noble  <jer.noble@apple.com>
969
970         Add initial DOM support for Media Capabilities
971         https://bugs.webkit.org/show_bug.cgi?id=181064
972
973         Reviewed by Eric Carlson.
974
975         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
976
977         * WebView/WebPreferenceKeysPrivate.h:
978         * WebView/WebPreferences.mm:
979         (+[WebPreferences initialize]):
980         (-[WebPreferences mediaCapabilitiesEnabled]):
981         (-[WebPreferences setMediaCapabilitiesEnabled:]):
982         * WebView/WebPreferencesPrivate.h:
983         * WebView/WebView.mm:
984         (-[WebView _preferencesChanged:]):
985
986 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
987
988         Enable picture-in-picture from inline element on suspend.
989         https://bugs.webkit.org/show_bug.cgi?id=180942
990         rdar://problem/34745234
991
992         Reviewed by Jer Noble.
993
994         Update signature of enterVideoFullscreenForVideoElement().
995
996         * WebCoreSupport/WebChromeClient.h:
997         * WebCoreSupport/WebChromeClient.mm:
998         (WebChromeClient::enterVideoFullscreenForVideoElement):
999
1000 2017-12-20  Daniel Bates  <dabates@apple.com>
1001
1002         Remove Alternative Presentation Button
1003         https://bugs.webkit.org/show_bug.cgi?id=180500
1004         <rdar://problem/35891047>
1005
1006         Reviewed by Simon Fraser.
1007
1008         We no longer need the alternative presentation button.
1009
1010         * Configurations/FeatureDefines.xcconfig:
1011
1012 2017-12-19  Jer Noble  <jer.noble@apple.com>
1013
1014         Playing media elements which call "pause(); play()" will have the play promise rejected.
1015         https://bugs.webkit.org/show_bug.cgi?id=180781
1016         <rdar://problem/33191377>
1017
1018         Reviewed by Eric Carlson.
1019
1020         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1021
1022         * WebView/WebView.mm:
1023         (shouldRequireUserGestureToLoadVideo):
1024
1025 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1026
1027         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1028         https://bugs.webkit.org/show_bug.cgi?id=180977
1029
1030         Reviewed by Tim Horton.
1031
1032         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1033         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1034         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1035
1036         * WebCoreSupport/WebEditorClient.mm:
1037         (attributesForAttributedStringConversion):
1038         * WebView/WebHTMLView.mm:
1039         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1040
1041 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1042
1043         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1044
1045         Attempt to fix the following warnings:
1046
1047             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1048
1049         For the following instance variables:
1050
1051             _borderView
1052             _contentView
1053             _frame
1054             _wFlags
1055
1056         * Carbon/CarbonWindowAdapter.mm:
1057         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1058         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1059         (-[CarbonWindowAdapter _termWindowIfOwner]):
1060         (-[CarbonWindowAdapter _windowMovedToRect:]):
1061         (-[CarbonWindowAdapter setContentView:]):
1062         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1063         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1064
1065 2017-12-16  Dan Bernstein  <mitz@apple.com>
1066
1067         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1068         https://bugs.webkit.org/show_bug.cgi?id=180613
1069         <rdar://problem/35946124>
1070
1071         Reviewed by Geoff Garen.
1072
1073         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1074           clients.
1075         * WebView/WebDynamicScrollBarsView.h: Ditto.
1076         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1077
1078 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1079
1080         Enable -Wstrict-prototypes for WebKit
1081         <https://webkit.org/b/180757>
1082         <rdar://problem/36024132>
1083
1084         Rubber-stamped by Joseph Pecoraro.
1085
1086         * Configurations/Base.xcconfig:
1087         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1088
1089 2017-12-14  John Wilander  <wilander@apple.com>
1090
1091         Storage Access API: Implement frame-specific access in the document.cookie layer
1092         https://bugs.webkit.org/show_bug.cgi?id=180682
1093         <rdar://problem/35982257>
1094
1095         Reviewed by Alex Christensen.
1096
1097         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1098         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1099         CookiesStrategy::getRawCookies() now take optional parameters for
1100         frameID and pageID to allow frame-specific scoping of cookies.
1101
1102         This change makes the return values of FrameLoaderClient::frameID()
1103         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1104         WebCore can call those getters and get the right return values in
1105         WebKit and std:nullopt in WebKitLegacy.
1106
1107         * WebCoreSupport/WebFrameLoaderClient.h:
1108         * WebCoreSupport/WebFrameLoaderClient.mm:
1109         (WebFrameLoaderClient::pageID const):
1110         (WebFrameLoaderClient::frameID const):
1111         * WebCoreSupport/WebPlatformStrategies.h:
1112         * WebCoreSupport/WebPlatformStrategies.mm:
1113         (WebPlatformStrategies::cookiesForDOM):
1114         (WebPlatformStrategies::setCookiesFromDOM):
1115         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1116         (WebPlatformStrategies::getRawCookies):
1117
1118 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1119
1120         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1121         https://bugs.webkit.org/show_bug.cgi?id=180689
1122
1123         Reviewed by Tim Horton.
1124
1125         Use sRGBColorSpaceRef() from WebCore.
1126
1127         * WebView/WebHTMLView.mm:
1128         (imageFromRect):
1129
1130 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1131
1132         Stop using deprecated target conditional for simulator builds
1133         https://bugs.webkit.org/show_bug.cgi?id=180662
1134         <rdar://problem/35136156>
1135
1136         Reviewed by Simon Fraser.
1137
1138         * postprocess-headers.sh:
1139
1140 2017-12-11  David Quesada  <david_quesada@apple.com>
1141
1142         Turn on ENABLE_APPLICATION_MANIFEST
1143         https://bugs.webkit.org/show_bug.cgi?id=180562
1144         rdar://problem/35924737
1145
1146         Reviewed by Geoffrey Garen.
1147
1148         * Configurations/FeatureDefines.xcconfig:
1149
1150 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1151
1152         Remove pthread_once in favor of dispatch_once
1153         https://bugs.webkit.org/show_bug.cgi?id=180591
1154
1155         Reviewed by Saam Barati.
1156
1157         * Misc/WebKitErrors.m:
1158         (+[NSError _registerWebKitErrors]):
1159         (registerErrors): Deleted.
1160         * Storage/WebStorageManager.mm:
1161         (+[WebStorageManager _storageDirectoryPath]):
1162         (initializeLocalStoragePath): Deleted.
1163
1164 2017-12-07  Darin Adler  <darin@apple.com>
1165
1166         Remove some unused code from WebKitLegacy
1167         https://bugs.webkit.org/show_bug.cgi?id=180567
1168
1169         Reviewed by Anders Carlsson.
1170
1171         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1172         macOS (back a few versions) and iOS and removed unused
1173         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1174         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1175         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1176         _webkit_stringByCollapsingNonPrintingCharacters,
1177         _webkit_stringByCollapsingWhitespaceCharacters,
1178         _web_stringWithData:textEncodingName:, and
1179         _webkit_localStorageDirectoryWithBundleIdentifier:.
1180
1181         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1182         this source file.
1183         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1184         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1185         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1186         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1187         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1188         handle font smoothing options.
1189         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1190         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1191         from header and made it a little clearer.
1192         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1193         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1194         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1195         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1196         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1197         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1198         implementation a bit and used whole words instead of abbreviations.
1199         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1200
1201         * Misc/WebNSFileManagerExtras.mm:
1202         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1203         filenameByFixingIllegalCharacters function from WebCore directly instead of
1204         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1205
1206         * Plugins/WebBaseNetscapePluginView.mm:
1207         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1208         string replacements instead of _web_stringByStrippingReturnCharacters
1209         and to use NSString methods instead of CFString functions.
1210
1211 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1212
1213         Ignore deprecation warnings.
1214
1215         * WebView/WebHTMLView.mm:
1216         (-[NSWindow _web_borderView]):
1217         (-[WebHTMLView _setAsideSubviews]):
1218         * WebView/WebView.mm:
1219         (-[WebView encodeWithCoder:]):
1220
1221 2017-12-02  Darin Adler  <darin@apple.com>
1222
1223         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1224         https://bugs.webkit.org/show_bug.cgi?id=180009
1225
1226         Reviewed by Alex Christensen.
1227
1228         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1229
1230         * Plugins/WebBaseNetscapePluginView.mm:
1231         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1232         of strcasecmp.
1233
1234         * WebView/WebPreferences.mm:
1235         (contains): Ditto. Also made this a template so it's easier to call on an array.
1236         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1237
1238 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1239
1240         Limit user agent versioning to an upper bound
1241         https://bugs.webkit.org/show_bug.cgi?id=180365
1242         <rdar://problem/34550617>
1243
1244         Reviewed by Joseph Pecoraro.
1245
1246         * WebView/WebView.mm:
1247         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1248         creating the User Agent string.
1249         (webKitBundleVersionString): Deleted.
1250
1251 2017-12-05  Andy Estes  <aestes@apple.com>
1252
1253         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1254         https://bugs.webkit.org/show_bug.cgi?id=180457
1255         <rdar://problem/35143007>
1256
1257         Reviewed by Tim Horton.
1258
1259         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1260         check for this macro during post-processing.
1261
1262         * postprocess-headers.sh:
1263
1264 2017-12-04  David Quesada  <david_quesada@apple.com>
1265
1266         Add a class for parsing application manifests
1267         https://bugs.webkit.org/show_bug.cgi?id=177973
1268         rdar://problem/34747949
1269
1270         Reviewed by Geoffrey Garen.
1271
1272         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1273
1274 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1275
1276         Make LegacyCustomProtocolManager optional for network process
1277         https://bugs.webkit.org/show_bug.cgi?id=176230
1278
1279         Reviewed by Alex Christensen.
1280
1281         * Configurations/FeatureDefines.xcconfig:
1282
1283 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1284
1285         Fix some NSOperationQueue leaks
1286         https://bugs.webkit.org/show_bug.cgi?id=180221
1287
1288         Reviewed by Wenson Hsieh.
1289
1290         * WebView/WebView.mm:
1291         (-[WebView performDragOperation:]):
1292
1293 2017-11-30  Darin Adler  <darin@apple.com>
1294
1295         [Mac] remove unneeded RetainPtr use introduced in r225142
1296         https://bugs.webkit.org/show_bug.cgi?id=180202
1297
1298         Reviewed by Tim Horton.
1299
1300         * WebView/WebImmediateActionController.mm:
1301         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1302         RetainPtr.
1303
1304 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1305
1306         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1307         https://bugs.webkit.org/show_bug.cgi?id=175595
1308
1309         Reviewed by Darin Adler.
1310
1311         * WebView/WebPreferences.mm:
1312
1313 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1314
1315         One too many zeroes in macOS version number in FeatureDefines
1316         https://bugs.webkit.org/show_bug.cgi?id=180011
1317
1318         Reviewed by Dan Bernstein.
1319
1320         * Configurations/FeatureDefines.xcconfig:
1321
1322 2017-11-23  Darin Adler  <darin@apple.com>
1323
1324         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1325         https://bugs.webkit.org/show_bug.cgi?id=179981
1326
1327         Reviewed by Sam Weinig.
1328
1329         * WebView/WebImmediateActionController.mm:
1330         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1331         * WebView/WebView.mm:
1332         (coreOptions): Use |= instead of | to build up FindOptions.
1333
1334 2017-11-23  Sam Weinig  <sam@webkit.org>
1335
1336         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1337         https://bugs.webkit.org/show_bug.cgi?id=179954
1338
1339         Reviewed by Darin Adler.
1340
1341         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1342         with direct calls to the corresponding UserGestureIndicator functions.
1343
1344         * Plugins/WebPluginController.mm:
1345         (-[WebPluginController processingUserGesture]):
1346         * WebView/WebView.mm:
1347         (-[WebView _isProcessingUserGesture]):
1348
1349 2017-11-23  Darin Adler  <darin@apple.com>
1350
1351         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1352         https://bugs.webkit.org/show_bug.cgi?id=179907
1353
1354         Reviewed by Sam Weinig.
1355
1356         * History/BinaryPropertyList.cpp:
1357         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1358         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1359         * WebView/WebHTMLRepresentation.mm:
1360         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1361         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1362
1363 2017-11-22  Ali Juma  <ajuma@chromium.org>
1364
1365         Implement VisualViewport API attributes
1366         https://bugs.webkit.org/show_bug.cgi?id=179385
1367
1368         Reviewed by Frédéric Wang.
1369
1370         Add a VisualViewportAPI preference.
1371
1372         * WebView/WebPreferenceKeysPrivate.h:
1373         * WebView/WebPreferences.mm:
1374         (+[WebPreferences initialize]):
1375         (-[WebPreferences visualViewportAPIEnabled]):
1376         (-[WebPreferences setVisualViewportAPIEnabled:]):
1377         * WebView/WebPreferencesPrivate.h:
1378         * WebView/WebView.mm:
1379         (-[WebView _preferencesChanged:]):
1380
1381 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1382
1383         WebCoreObjCExtras.h is being included in too many places
1384         https://bugs.webkit.org/show_bug.cgi?id=179931
1385
1386         Reviewed by Darin Adler.
1387
1388         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1389         * Plugins/WebBaseNetscapePluginView.mm:
1390         * Plugins/WebBasePluginPackage.mm:
1391         * Plugins/WebNetscapePluginStream.mm:
1392         * Plugins/WebNetscapePluginView.mm:
1393         * WebView/WebTextIterator.mm:
1394         * WebView/WebViewData.mm:
1395
1396 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1397
1398         Unreviewed, rolling out r225093.
1399         https://bugs.webkit.org/show_bug.cgi?id=179938
1400
1401         Compilation failed on WinCairo 64-bit Release (Requested by
1402         fredw on #webkit).
1403
1404         Reverted changeset:
1405
1406         "Implement VisualViewport API attributes"
1407         https://bugs.webkit.org/show_bug.cgi?id=179385
1408         https://trac.webkit.org/changeset/225093
1409
1410 2017-11-21  Ali Juma  <ajuma@chromium.org>
1411
1412         Implement VisualViewport API attributes
1413         https://bugs.webkit.org/show_bug.cgi?id=179385
1414
1415         Reviewed by Frédéric Wang.
1416
1417         Add a VisualViewportAPI preference.
1418
1419         * WebView/WebPreferenceKeysPrivate.h:
1420         * WebView/WebPreferences.mm:
1421         (+[WebPreferences initialize]):
1422         (-[WebPreferences visualViewportAPIEnabled]):
1423         (-[WebPreferences setVisualViewportAPIEnabled:]):
1424         * WebView/WebPreferencesPrivate.h:
1425         * WebView/WebView.mm:
1426         (-[WebView _preferencesChanged:]):
1427
1428 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1429
1430         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1431         https://bugs.webkit.org/show_bug.cgi?id=179504
1432
1433         Reviewed by Darin Adler.
1434
1435         * Misc/WebKitNSStringExtras.mm:
1436         * Plugins/Hosted/NetscapePluginHostManager.mm:
1437         * Plugins/WebBasePluginPackage.mm:
1438
1439 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1440
1441         Remove unused TOUCH_ICON_LOADING feature flag
1442         https://bugs.webkit.org/show_bug.cgi?id=179873
1443
1444         Reviewed by Simon Fraser.
1445
1446         * Configurations/FeatureDefines.xcconfig:
1447
1448 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1449
1450         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1451         https://bugs.webkit.org/show_bug.cgi?id=179872
1452
1453         Reviewed by Darin Adler.
1454
1455         * Configurations/FeatureDefines.xcconfig:
1456
1457 2017-11-16  Daniel Bates  <dabates@apple.com>
1458
1459         Add feature define for alternative presentation button element
1460         https://bugs.webkit.org/show_bug.cgi?id=179692
1461         Part of <rdar://problem/34917108>
1462
1463         Reviewed by Andy Estes.
1464
1465         Only enabled on Cocoa platforms by default.
1466
1467         * Configurations/FeatureDefines.xcconfig:
1468
1469 2017-11-14  Nan Wang  <n_wang@apple.com>
1470
1471         AX: AOM: Implement AccessibleNode class and support label and role attributes
1472         https://bugs.webkit.org/show_bug.cgi?id=179494
1473
1474         Reviewed by Ryosuke Niwa.
1475
1476         * WebView/WebPreferenceKeysPrivate.h:
1477         * WebView/WebPreferences.mm:
1478         (+[WebPreferences initialize]):
1479         (-[WebPreferences accessibilityObjectModelEnabled]):
1480         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1481         * WebView/WebPreferencesPrivate.h:
1482         * WebView/WebView.mm:
1483         (-[WebView _preferencesChanged:]):
1484
1485 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1486
1487         Remove Cocoa CFURLConnection loading code
1488         https://bugs.webkit.org/show_bug.cgi?id=179688
1489
1490         Reviewed by Antti Koivisto.
1491
1492         * Misc/WebDownload.mm:
1493         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1494         * Misc/WebDownloadInternal.h:
1495         * Plugins/WebBaseNetscapePluginView.mm:
1496         * WebCoreSupport/WebFrameLoaderClient.mm:
1497         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1498         * WebView/WebView.mm:
1499         (-[WebView scheduleInRunLoop:forMode:]):
1500         (-[WebView unscheduleFromRunLoop:forMode:]):
1501
1502 2017-11-14  Daniel Bates  <dabates@apple.com>
1503
1504         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1505         for feature defines
1506
1507         Following r195498 and r201917 the Visual Studio property files for feature defines have
1508         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1509         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1510         files.
1511
1512         * Configurations/FeatureDefines.xcconfig:
1513
1514 2017-11-14  Jer Noble  <jer.noble@apple.com>
1515
1516         Enable Modern EME tests in DumpRenderTree
1517         https://bugs.webkit.org/show_bug.cgi?id=179544
1518
1519         Reviewed by Alex Christensen.
1520
1521         Add a WebPreferences property to enable the (modern) EME API.
1522
1523         * WebView/WebPreferenceKeysPrivate.h:
1524         * WebView/WebPreferences.mm:
1525         (+[WebPreferences initialize]):
1526         (-[WebPreferences encryptedMediaAPIEnabled]):
1527         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1528         * WebView/WebPreferencesPrivate.h:
1529         * WebView/WebView.mm:
1530         (-[WebView _preferencesChanged:]):
1531
1532 2017-11-14  Antti Koivisto  <antti@apple.com>
1533
1534         Enable display:contents by default
1535         https://bugs.webkit.org/show_bug.cgi?id=179655
1536
1537         Reviewed by Sam Weinig.
1538
1539         * WebView/WebPreferences.mm:
1540         (+[WebPreferences initialize]):
1541
1542 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1543
1544         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1545         https://bugs.webkit.org/show_bug.cgi?id=178751
1546
1547         Reviewed by Brady Eidson.
1548
1549         * WebCoreSupport/WebFrameNetworkingContext.mm:
1550         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1551
1552 2017-11-08  Keith Miller  <keith_miller@apple.com>
1553
1554         Async iteration should only fetch the next method once and add feature flag
1555         https://bugs.webkit.org/show_bug.cgi?id=179451
1556
1557         Reviewed by Geoffrey Garen.
1558
1559         Add feature flag for Async iteration.
1560
1561         * Configurations/FeatureDefines.xcconfig:
1562
1563 2017-11-13  Mark Lam  <mark.lam@apple.com>
1564
1565         Add more overflow check book-keeping for MarkedArgumentBuffer.
1566         https://bugs.webkit.org/show_bug.cgi?id=179634
1567         <rdar://problem/35492517>
1568
1569         Reviewed by Saam Barati.
1570
1571         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1572         (WebKit::NetscapePluginInstanceProxy::invoke):
1573         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1574         (WebKit::NetscapePluginInstanceProxy::construct):
1575
1576 2017-11-12  Darin Adler  <darin@apple.com>
1577
1578         More is<> and downcast<>, less static_cast<>
1579         https://bugs.webkit.org/show_bug.cgi?id=179600
1580
1581         Reviewed by Chris Dumez.
1582
1583         * DOM/DOM.mm:
1584         (kit): Use is/downcast.
1585         * WebCoreSupport/WebEditorClient.mm:
1586         (WebEditorClient::handleKeyboardEvent): Ditto.
1587         (WebEditorClient::handleInputMethodKeydown): Ditto.
1588         * WebView/WebHTMLView.mm:
1589         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1590
1591 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1592
1593         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1594         https://bugs.webkit.org/show_bug.cgi?id=179397
1595
1596         Reviewed by Wenson Hsieh.
1597
1598         * DOM/DOMHTMLInputElement.mm:
1599         (-[DOMHTMLInputElement insertTextSuggestion:]):
1600
1601 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1602
1603         HTMLMediaElement should not use element fullscreen on iOS
1604         https://bugs.webkit.org/show_bug.cgi?id=179418
1605         rdar://problem/35409277
1606
1607         Reviewed by Eric Carlson.
1608
1609         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1610
1611         * Configurations/FeatureDefines.xcconfig:
1612
1613 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1614
1615         Make ResourceLoader::willSendRequestInternal asynchronous
1616         https://bugs.webkit.org/show_bug.cgi?id=179251
1617
1618         Reviewed by Andy Estes.
1619
1620         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1621         (WebKit::HostedNetscapePluginStream::start):
1622         * Plugins/WebNetscapePluginStream.mm:
1623         (WebNetscapePluginStream::start):
1624
1625 2017-11-01  Darin Adler  <darin@apple.com>
1626
1627         Simplify event dispatch code and make it a bit more consistent
1628         https://bugs.webkit.org/show_bug.cgi?id=178991
1629
1630         Reviewed by Chris Dumez.
1631
1632         * DOM/DOMEvent.mm:
1633         (-[DOMEvent srcElement]): Call target instead of srcElement.
1634
1635 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1636
1637         [Touch Bar Web API] Add support for menuitem tag
1638         https://bugs.webkit.org/show_bug.cgi?id=179020
1639
1640         Reviewed by Ryosuke Niwa.
1641
1642         Adds in properties and methods that allow the menuitem runtime feature
1643         to be enabled or disabled.
1644
1645         * WebView/WebPreferenceKeysPrivate.h:
1646         * WebView/WebPreferences.mm:
1647         (-[WebPreferences menuItemElementEnabled]):
1648         (-[WebPreferences setMenuItemElementEnabled:]):
1649         * WebView/WebPreferencesPrivate.h:
1650         * WebView/WebView.mm:
1651         (-[WebView _preferencesChanged:]):
1652
1653 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1654
1655         Use CompletionHandlers for redirects
1656         https://bugs.webkit.org/show_bug.cgi?id=179163
1657
1658         Reviewed by Tim Horton.
1659
1660         * Plugins/Hosted/HostedNetscapePluginStream.h:
1661         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1662         (WebKit::HostedNetscapePluginStream::willSendRequest):
1663         * Plugins/WebNetscapePluginStream.h:
1664         * Plugins/WebNetscapePluginStream.mm:
1665         (WebNetscapePluginStream::willSendRequest):
1666
1667 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1668
1669         Add a FileSystem namespace to FileSystem.cpp
1670         https://bugs.webkit.org/show_bug.cgi?id=179063
1671
1672         Reviewed by Darin Adler.
1673
1674         * Misc/WebNSFileManagerExtras.mm:
1675         * Storage/WebDatabaseProvider.mm:
1676
1677 2017-11-02  Frederic Wang  <fwang@igalia.com>
1678
1679         Add references to bug 179167 in FIXME comments
1680         https://bugs.webkit.org/show_bug.cgi?id=179168
1681
1682         Reviewed by Daniel Bates.
1683
1684         * Configurations/FeatureDefines.xcconfig:
1685
1686 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1687
1688         Implement WKFullscreenWindowController for iOS.
1689         https://bugs.webkit.org/show_bug.cgi?id=178924
1690         rdar://problem/34697120
1691
1692         Reviewed by Simon Fraser.
1693
1694         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1695
1696         * Configurations/FeatureDefines.xcconfig:
1697         * WebView/WebView.mm:
1698         (-[WebView fullScreenPlaceholderView]):
1699
1700 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1701
1702         Clean up some drag and drop feature flags
1703         https://bugs.webkit.org/show_bug.cgi?id=179082
1704
1705         Reviewed by Simon Fraser.
1706
1707         * Configurations/FeatureDefines.xcconfig:
1708
1709 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1710
1711         Make it possible to test rubber-banding in overflow scroll
1712         https://bugs.webkit.org/show_bug.cgi?id=179078
1713
1714         Reviewed by Sam Weinig.
1715
1716         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1717         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1718
1719         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1720         functions, since most callers want clamped.
1721
1722         * DOM/DOMHTML.mm:
1723         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1724
1725 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1726
1727         Fix up some content filtering feature flags
1728         https://bugs.webkit.org/show_bug.cgi?id=179079
1729
1730         Reviewed by Simon Fraser.
1731
1732         * Configurations/FeatureDefines.xcconfig:
1733
1734 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1735
1736         [FrameView::layout cleanup] Move core layout logic to a separate class.
1737         https://bugs.webkit.org/show_bug.cgi?id=178771
1738         <rdar://problem/35166542>
1739
1740         Reviewed by Simon Fraser.
1741
1742         Move layout code out from FrameView to LayoutContext.
1743
1744         * WebView/WebClipView.mm:
1745         (-[WebClipView _immediateScrollToPoint:]):
1746         * WebView/WebFrame.mm:
1747         (-[WebFrame layoutCount]):
1748
1749 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1750
1751         Fix issues with WebView subframe painting
1752         https://bugs.webkit.org/show_bug.cgi?id=178842
1753         rdar://problem/34072253
1754
1755         Reviewed by Daniel Bates.
1756         
1757         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1758         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1759         High Sierra, so match the new signature.
1760
1761         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1762
1763         * WebView/WebHTMLView.mm:
1764         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1765         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1766
1767 2017-10-25  Youenn Fablet  <youenn@apple.com>
1768
1769         Enable ServiceWorker to fetch resources
1770         https://bugs.webkit.org/show_bug.cgi?id=178673
1771
1772         Reviewed by Brady Eidson.
1773
1774         * WebCoreSupport/WebFrameLoaderClient.mm:
1775         (WebFrameLoaderClient::pageID const):
1776         (WebFrameLoaderClient::frameID const):
1777         (WebFrameLoaderClient::sessionID const):
1778
1779         Added implementation to the new getters.
1780         They are noop in the context of WK1.
1781
1782 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1783
1784         Web Inspector: Enable WebKit logging configuration and display
1785         https://bugs.webkit.org/show_bug.cgi?id=177027
1786         <rdar://problem/33964767>
1787
1788         Reviewed by Joseph Pecoraro.
1789
1790         * WebCoreSupport/WebChromeClient.mm:
1791         (stringForMessageSource): Deal with Media and WebRTC message sources.
1792
1793 2017-10-20  Antoine Quint  <graouts@apple.com>
1794
1795         [Web Animations] Provide basic timeline and animation interfaces
1796         https://bugs.webkit.org/show_bug.cgi?id=178526
1797
1798         Reviewed by Dean Jackson.
1799
1800         Remove the WEB_ANIMATIONS compile-time flag.
1801
1802         * Configurations/FeatureDefines.xcconfig:
1803         * WebView/WebPreferences.mm:
1804         (+[WebPreferences initialize]):
1805         * WebView/WebView.mm:
1806         (-[WebView _preferencesChanged:]):
1807
1808 2017-10-19  Sam Weinig  <sam@webkit.org>
1809
1810         [Settings] Move global settings into their own file
1811         https://bugs.webkit.org/show_bug.cgi?id=178512
1812
1813         Reviewed by Darin Adler.
1814
1815         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1816
1817         * WebCoreSupport/WebChromeClient.mm:
1818         (WebChromeClient::supportsVideoFullscreen):
1819         * WebView/WebDynamicScrollBarsView.mm:
1820         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1821         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1822         * WebView/WebPreferences.mm:
1823         (+[WebPreferences initialize]):
1824         * WebView/WebView.mm:
1825         (-[WebView _commonInitializationWithFrameName:groupName:]):
1826         (-[WebView _preferencesChanged:]):
1827         (+[WebView _doNotStartObservingNetworkReachability]):
1828
1829 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1830
1831         Replace some stack raw pointers with RefPtrs within WebCore/html
1832         https://bugs.webkit.org/show_bug.cgi?id=178201
1833         <rdar://problem/34841692>
1834
1835         Reviewed by Ryosuke Niwa.
1836
1837         * DOM/DOM.mm:
1838         (kit):
1839         Change the type of node as toNode() is changed to return RefPtr.
1840
1841 2017-10-18  Chris Dumez  <cdumez@apple.com>
1842
1843         [Service Worker] Add stubs for Client / WindowClient / Clients
1844         https://bugs.webkit.org/show_bug.cgi?id=178469
1845
1846         Reviewed by Youenn Fablet.
1847
1848         Rename PageVisiblityState to VisibilityState.
1849
1850         * WebView/WebView.mm:
1851         (kit):
1852
1853 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1854
1855         Unreviewed, rolling out r223291.
1856
1857         See WebCore ChangeLog for more detail.
1858
1859         Reverted changeset:
1860
1861         "Remove Editor::simplifyMarkup"
1862         https://bugs.webkit.org/show_bug.cgi?id=178271
1863         https://trac.webkit.org/changeset/223291
1864
1865 2017-10-17  Keith Miller  <keith_miller@apple.com>
1866
1867         Change WebCore sources to work with unified source builds
1868         https://bugs.webkit.org/show_bug.cgi?id=178229
1869
1870         Rubber stamped by Tim Horton.
1871
1872         * Configurations/FeatureDefines.xcconfig:
1873
1874 2017-10-16  Sam Weinig  <sam@webkit.org>
1875
1876         [Settings] Remove all custom code from Settings.h/cpp
1877         https://bugs.webkit.org/show_bug.cgi?id=178330
1878
1879         Reviewed by Simon Fraser.
1880
1881         * WebView/WebPreferences.mm:
1882         (+[WebPreferences initialize]):
1883         
1884             Update for naming changes of FrameFlattening now that it is an enum class.
1885
1886 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1887
1888         Remove Editor::simplifyMarkup
1889         https://bugs.webkit.org/show_bug.cgi?id=178271
1890
1891         Reviewed by Wenson Hsieh.
1892
1893         * WebView/WebView.mm:
1894         (-[WebView _simplifyMarkup:endNode:]):
1895
1896 2017-10-12  Chris Dumez  <cdumez@apple.com>
1897
1898         [Mac] Add support for MouseEvent.buttons
1899         https://bugs.webkit.org/show_bug.cgi?id=178214
1900
1901         Reviewed by Ryosuke Niwa.
1902
1903         * WebView/WebPDFView.mm:
1904         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1905
1906 2017-10-11  Sam Weinig  <sam@webkit.org>
1907
1908         Remove out-parameter variants of copyToVector
1909         https://bugs.webkit.org/show_bug.cgi?id=178155
1910
1911         Reviewed by Tim Horton.
1912
1913         * Plugins/WebNetscapePluginView.mm:
1914         (-[WebNetscapePluginView destroyPlugin]):
1915         * WebView/WebHTMLRepresentation.mm:
1916         (newArrayWithStrings):
1917
1918             Replace out-parameter based copyToVector, with one that returns a Vector.
1919
1920 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1921
1922         Sanitize URL in pasteboard for other applications and cross origin content
1923         https://bugs.webkit.org/show_bug.cgi?id=178060
1924         <rdar://problem/34874518>
1925
1926         Reviewed by Wenson Hsieh.
1927
1928         * WebCoreSupport/WebPlatformStrategies.h:
1929         * WebCoreSupport/WebPlatformStrategies.mm:
1930         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
1931
1932 2017-10-11  Chris Dumez  <cdumez@apple.com>
1933
1934         Modernize Geolocation code
1935         https://bugs.webkit.org/show_bug.cgi?id=178148
1936
1937         Reviewed by Ryosuke Niwa.
1938
1939         * WebCoreSupport/WebGeolocationClient.h:
1940         * WebCoreSupport/WebGeolocationClient.mm:
1941         (WebGeolocationClient::lastPosition):
1942         * WebView/WebGeolocationPosition.mm:
1943         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1944         (core):
1945         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
1946         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1947         * WebView/WebGeolocationPositionInternal.h:
1948
1949 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1950
1951         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
1952         https://bugs.webkit.org/show_bug.cgi?id=178154
1953
1954         Reviewed by Wenson Hsieh.
1955
1956         Enable custom pasteboard data by default.
1957
1958         * WebView/WebPreferenceKeysPrivate.h:
1959         * WebView/WebPreferences.mm:
1960         (+[WebPreferences initialize]):
1961         (-[WebPreferences customPasteboardDataEnabled]): Added.
1962         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
1963         * WebView/WebPreferencesPrivate.h:
1964         * WebView/WebView.mm:
1965         (-[WebView _preferencesChanged:]):
1966
1967 2017-10-10  Sam Weinig  <sam@webkit.org>
1968
1969         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
1970         https://bugs.webkit.org/show_bug.cgi?id=178102
1971
1972         Reviewed by Tim Horton.
1973
1974         * History/WebHistory.mm:
1975         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1976         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1977         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1978         * WebCoreSupport/WebUserMediaClient.mm:
1979         (WebUserMediaClient::pageDestroyed):
1980
1981 2017-10-09  Robin Morisset  <rmorisset@apple.com>
1982
1983         Make the names of the options consistent
1984         https://bugs.webkit.org/show_bug.cgi?id=177933
1985
1986         Reviewed by Saam Barati.
1987
1988         * WebView/WebFrame.h:
1989         * WebView/WebHTMLView.mm:
1990         (-[WebHTMLView setMarkedText:selectedRange:]):
1991         * WebView/WebView.h:
1992
1993 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1994
1995         [iOS] Tweak support for classifying form controls (followup to r222487)
1996         https://bugs.webkit.org/show_bug.cgi?id=177917
1997         <rdar://problem/34820122>
1998
1999         Reviewed by Dean Jackson.
2000
2001         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2002
2003         * DOM/DOMHTMLInputElement.mm:
2004         (-[DOMHTMLInputElement _autofillContext]):
2005         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2006         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2007
2008 2017-10-05  Keith Miller  <keith_miller@apple.com>
2009
2010         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2011
2012         * Configurations/WebKitLegacy.xcconfig:
2013
2014 2017-10-05  Jer Noble  <jer.noble@apple.com>
2015
2016         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2017         https://bugs.webkit.org/show_bug.cgi?id=177261
2018
2019         Reviewed by Eric Carlson.
2020
2021         * Configurations/FeatureDefines.xcconfig:
2022
2023 2017-10-05  Chris Dumez  <cdumez@apple.com>
2024
2025         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2026         https://bugs.webkit.org/show_bug.cgi?id=177957
2027
2028         Reviewed by Alex Christensen.
2029
2030         * WebCoreSupport/WebPlatformStrategies.h:
2031         * WebCoreSupport/WebPlatformStrategies.mm:
2032         (WebPlatformStrategies::cookiesEnabled):
2033
2034 2017-10-05  Youenn Fablet  <youenn@apple.com>
2035
2036         Make LibWebRTCProvider port agnostic
2037         https://bugs.webkit.org/show_bug.cgi?id=177747
2038
2039         Reviewed by Alex Christensen & Alex Garcia.
2040
2041         * WebView/WebView.mm:
2042         (-[WebView _commonInitializationWithFrameName:groupName:]):
2043         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2044
2045 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2046
2047         Stop linking with WebKitSystemInterface
2048         https://bugs.webkit.org/show_bug.cgi?id=177915
2049
2050         Reviewed by Antti Koivisto.
2051
2052         * Configurations/DebugRelease.xcconfig:
2053         * Configurations/WebKitLegacy.xcconfig:
2054
2055 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2056
2057         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2058         https://bugs.webkit.org/show_bug.cgi?id=177912
2059
2060         Reviewed by Saam Barati.
2061
2062         * Carbon/CarbonUtils.m:
2063         * Carbon/CarbonWindowAdapter.mm:
2064         * Carbon/HIWebView.mm:
2065         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2066         * Misc/WebNSFileManagerExtras.mm:
2067         * Misc/WebNSPasteboardExtras.mm:
2068         * Misc/WebNSURLExtras.mm:
2069         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2070         * Plugins/Hosted/NetscapePluginHostManager.mm:
2071         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2072         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2073         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2074         * Plugins/Hosted/WebTextInputWindowController.m:
2075         * Plugins/WebBaseNetscapePluginView.mm:
2076         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2077         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2078         * Plugins/WebNetscapePluginStream.mm:
2079         * Plugins/WebNetscapePluginView.mm:
2080         * Plugins/WebPluginDatabase.mm:
2081         * WebCoreSupport/PopupMenuMac.mm:
2082         * WebCoreSupport/WebChromeClient.mm:
2083         * WebCoreSupport/WebFrameLoaderClient.mm:
2084         * WebCoreSupport/WebInspectorClient.mm:
2085         * WebCoreSupport/WebPlatformStrategies.mm:
2086         * WebCoreSupport/WebSystemInterface.mm:
2087         * WebView/WebDynamicScrollBarsView.mm:
2088         * WebView/WebFrame.mm:
2089         * WebView/WebFrameView.mm:
2090         * WebView/WebFullScreenController.mm:
2091         * WebView/WebHTMLView.mm:
2092         * WebView/WebPreferences.mm:
2093         * WebView/WebView.mm:
2094
2095 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2096
2097         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2098         rdar://problem/34705779
2099
2100         Addressing review comments that I somehow landed without.
2101
2102         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2103
2104 2017-09-29  Chris Dumez  <cdumez@apple.com>
2105
2106         Split some logic out of VisitedLinkStore and make it reusable
2107         https://bugs.webkit.org/show_bug.cgi?id=177575
2108
2109         Reviewed by Alex Christensen.
2110
2111         * WebCoreSupport/WebVisitedLinkStore.h:
2112         * WebCoreSupport/WebVisitedLinkStore.mm:
2113         (WebVisitedLinkStore::addVisitedLink):
2114         (WebVisitedLinkStore::removeVisitedLink):
2115         (WebVisitedLinkStore::isLinkVisited):
2116         (WebVisitedLinkStore::addVisitedLinkHash):
2117
2118 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2119
2120         Build fix for High Sierra 32 bit Mac
2121         https://bugs.webkit.org/show_bug.cgi?id=177551
2122         <rdar://problem/34690283>
2123
2124         Reviewed by Alexey Proskuryakov.
2125
2126         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2127         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2128         also made.
2129
2130         * Carbon/CarbonWindowAdapter.mm:
2131         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2132         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2133         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2134         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2135         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2136         (-[CarbonWindowAdapter dealloc]):
2137         (-[CarbonWindowAdapter windowRef]):
2138         (-[CarbonWindowAdapter _hasWindowRef]):
2139         (-[CarbonWindowAdapter _managesWindowRef]):
2140         (-[CarbonWindowAdapter _removeWindowRef]):
2141         (-[CarbonWindowAdapter _carbonWindowClass]):
2142         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2143         (-[CarbonWindowAdapter sendSuperEvent:]):
2144         (-[CarbonWindowAdapter relinquishFocus]):
2145         (-[CarbonWindowAdapter _cancelKey:]):
2146         (-[CarbonWindowAdapter _commonAwake]):
2147         (-[CarbonWindowAdapter _destroyRealWindow:]):
2148         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2149         (-[CarbonWindowAdapter _termWindowIfOwner]):
2150         (-[CarbonWindowAdapter _windowMovedToRect:]):
2151         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2152         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2153         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2154         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2155         (-[CarbonWindowAdapter canBecomeMainWindow]):
2156         (-[CarbonWindowAdapter encodeWithCoder:]):
2157         (-[CarbonWindowAdapter initWithCoder:]):
2158         (-[CarbonWindowAdapter setContentView:]):
2159         (-[CarbonWindowAdapter worksWhenModal]):
2160         (-[CarbonWindowAdapter _setModalWindowLevel]):
2161         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2162         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2163         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2164         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2165         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2166         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2167         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2168         (NSCarbonWindowHandleEvent):
2169         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2170         (-[CarbonWindowAdapter _growBoxRect]):
2171         * Carbon/HIWebView.mm:
2172         (HIWebViewGetWebView):
2173         (HIWebViewConstructor):
2174         (HIWebViewDestructor):
2175         (HIWebViewRegisterClass):
2176         (GetBehaviors):
2177         (Draw):
2178         (HitTest):
2179         (GetRegion):
2180         (GetWindowRef):
2181         (CreateNSEventAdoptingCGEvent):
2182         (CopyEventCGEvent):
2183         (CreateNSEventWithCarbonClickEvent):
2184         (Click):
2185         (CreateNSEventWithCarbonEvent):
2186         (MouseUp):
2187         (CreateNSEventWithCarbonMouseMoveEvent):
2188         (MouseMoved):
2189         (MouseDragged):
2190         (MouseWheelMoved):
2191         (ContextMenuClick):
2192         (GetKind):
2193         (BoundsChanged):
2194         (OwningWindowChanged):
2195         (WindowHandler):
2196         (SyncFrame):
2197         (SetFocusPart):
2198         (AdvanceFocus):
2199         (RelinquishFocus):
2200         (ActiveStateChanged):
2201         (ProcessCommand):
2202         (UpdateCommandStatus):
2203         (_NSSelectorForHICommand):
2204         (HIWebViewEventHandler):
2205         (StartUpdateObserver):
2206         (StopUpdateObserver):
2207         (UpdateObserver):
2208
2209 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2210
2211         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2212         https://bugs.webkit.org/show_bug.cgi?id=172526
2213         <rdar://problem/32396081>
2214
2215         Reviewed by Ryosuke Niwa.
2216
2217         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2218
2219         * WebCoreSupport/WebPlatformStrategies.h:
2220         * WebCoreSupport/WebPlatformStrategies.mm:
2221         (WebPlatformStrategies::webExposedTypes):
2222         (WebPlatformStrategies::writeCustomData):
2223
2224 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2225
2226         Unreviewed, rolling out r222567.
2227
2228         This broke and internal build.
2229
2230         Reverted changeset:
2231
2232         "Build fix for High Sierra 32 bit Mac"
2233         https://bugs.webkit.org/show_bug.cgi?id=177551
2234         http://trac.webkit.org/changeset/222567
2235
2236 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2237
2238         Build fix for High Sierra 32 bit Mac
2239         https://bugs.webkit.org/show_bug.cgi?id=177551
2240         <rdar://problem/34690283>
2241
2242         Reviewed by Alexey Proskuryakov.
2243
2244         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2245         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2246         also made.
2247
2248         * Carbon/CarbonWindowAdapter.mm:
2249         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2250         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2251         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2252         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2253         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2254         (-[CarbonWindowAdapter dealloc]):
2255         (-[CarbonWindowAdapter windowRef]):
2256         (-[CarbonWindowAdapter _hasWindowRef]):
2257         (-[CarbonWindowAdapter _managesWindowRef]):
2258         (-[CarbonWindowAdapter _removeWindowRef]):
2259         (-[CarbonWindowAdapter _carbonWindowClass]):
2260         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2261         (-[CarbonWindowAdapter sendSuperEvent:]):
2262         (-[CarbonWindowAdapter relinquishFocus]):
2263         (-[CarbonWindowAdapter _cancelKey:]):
2264         (-[CarbonWindowAdapter _commonAwake]):
2265         (-[CarbonWindowAdapter _destroyRealWindow:]):
2266         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2267         (-[CarbonWindowAdapter _termWindowIfOwner]):
2268         (-[CarbonWindowAdapter _windowMovedToRect:]):
2269         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2270         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2271         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2272         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2273         (-[CarbonWindowAdapter canBecomeMainWindow]):
2274         (-[CarbonWindowAdapter encodeWithCoder:]):
2275         (-[CarbonWindowAdapter initWithCoder:]):
2276         (-[CarbonWindowAdapter setContentView:]):
2277         (-[CarbonWindowAdapter worksWhenModal]):
2278         (-[CarbonWindowAdapter _setModalWindowLevel]):
2279         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2280         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2281         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2282         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2283         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2284         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2285         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2286         (NSCarbonWindowHandleEvent):
2287         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2288         (-[CarbonWindowAdapter _growBoxRect]):
2289         * Carbon/HIWebView.mm:
2290         (HIWebViewGetWebView):
2291         (HIWebViewConstructor):
2292         (HIWebViewDestructor):
2293         (HIWebViewRegisterClass):
2294         (GetBehaviors):
2295         (Draw):
2296         (HitTest):
2297         (GetRegion):
2298         (GetWindowRef):
2299         (CreateNSEventAdoptingCGEvent):
2300         (CopyEventCGEvent):
2301         (CreateNSEventWithCarbonClickEvent):
2302         (Click):
2303         (CreateNSEventWithCarbonEvent):
2304         (MouseUp):
2305         (CreateNSEventWithCarbonMouseMoveEvent):
2306         (MouseMoved):
2307         (MouseDragged):
2308         (MouseWheelMoved):
2309         (ContextMenuClick):
2310         (GetKind):
2311         (BoundsChanged):
2312         (OwningWindowChanged):
2313         (WindowHandler):
2314         (SyncFrame):
2315         (SetFocusPart):
2316         (AdvanceFocus):
2317         (RelinquishFocus):
2318         (ActiveStateChanged):
2319         (ProcessCommand):
2320         (UpdateCommandStatus):
2321         (_NSSelectorForHICommand):
2322         (HIWebViewEventHandler):
2323         (StartUpdateObserver):
2324         (StopUpdateObserver):
2325         (UpdateObserver):
2326
2327 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2328
2329         Make PolicyAction an encodable enum class
2330         https://bugs.webkit.org/show_bug.cgi?id=177480
2331
2332         Reviewed by Antti Koivisto.
2333
2334         * Plugins/WebPluginContainerCheck.mm:
2335         (-[WebPluginContainerCheck _continueWithPolicy:]):
2336         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2337         * WebCoreSupport/WebFrameLoaderClient.mm:
2338         (-[WebFramePolicyListener invalidate]):
2339         (-[WebFramePolicyListener ignore]):
2340         (-[WebFramePolicyListener download]):
2341         (-[WebFramePolicyListener use]):
2342         (-[WebFramePolicyListener continue]):
2343         * WebView/WebPolicyDelegate.mm:
2344         (-[WebPolicyDecisionListener use]):
2345         (-[WebPolicyDecisionListener ignore]):
2346         (-[WebPolicyDecisionListener download]):
2347
2348 2017-09-25  Frederik Riedel  <riedel@apple.com>
2349
2350         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2351         https://bugs.webkit.org/show_bug.cgi?id=174394
2352         <rdar://problem/33183504>
2353
2354         Reviewed by Ryosuke Niwa.
2355
2356         * DOM/DOMHTMLInputElement.h:
2357         * DOM/DOMHTMLInputElement.mm:
2358         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2359         Determines if this HTMLInputElement is part of a login screen.
2360         (-[DOMHTMLInputElement representingPageUrl]):
2361         Returns the webpage's URL that is currently displayed in the Web View.
2362         (-[DOMHTMLInputElement insertTextSuggestion:]):
2363         Inserts login credentials into the Web View.
2364
2365 2017-09-25  Sam Weinig  <sam@webkit.org>
2366
2367         Remove unused EditorClient functions
2368         https://bugs.webkit.org/show_bug.cgi?id=177463
2369
2370         Reviewed by Alex Christensen.
2371
2372         Remove unused EditorClient functions.
2373
2374         * WebCoreSupport/WebEditorClient.h:
2375         * WebCoreSupport/WebEditorClient.mm:
2376         (WebEditorClient::canonicalizeURL): Deleted.
2377         (WebEditorClient::canonicalizeURLString): Deleted.
2378         (WebEditorClient::writeDataToPasteboard): Deleted.
2379         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2380         (WebEditorClient::readDataFromPasteboard): Deleted.
2381         (WebEditorClient::pasteboardChangeCount): Deleted.
2382
2383 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2384
2385         Stop using PolicyCallback
2386         https://bugs.webkit.org/show_bug.cgi?id=176088
2387
2388         Reviewed by Andy Estes.
2389
2390         * WebCoreSupport/WebFrameLoaderClient.mm:
2391         (-[WebFramePolicyListener invalidate]):
2392         (-[WebFramePolicyListener receivedPolicyDecision:]):
2393
2394 2017-09-25  Sam Weinig  <sam@webkit.org>
2395
2396         Remove unnecessary userVisibleString EditorClient function
2397         https://bugs.webkit.org/show_bug.cgi?id=177456
2398
2399         Reviewed by Dan Bernstein.
2400
2401         * WebCoreSupport/WebEditorClient.h:
2402         * WebCoreSupport/WebEditorClient.mm:
2403         (WebEditorClient::userVisibleString): Deleted.
2404
2405             Remove userVisibleString client function.
2406
2407 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2408
2409         Separate form submission from PolicyChecker infrastructure
2410         https://bugs.webkit.org/show_bug.cgi?id=177396
2411
2412         Reviewed by Geoffrey Garen.
2413
2414         * WebCoreSupport/WebFrameLoaderClient.h:
2415         * WebCoreSupport/WebFrameLoaderClient.mm:
2416         (WebFrameLoaderClient::dispatchWillSubmitForm):
2417
2418 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2419
2420         WeakPtrFactory should populate m_ref lazily.
2421         https://bugs.webkit.org/show_bug.cgi?id=177375
2422
2423         Reviewed by Geoffrey Garen.
2424
2425         * WebCoreSupport/WebEditorClient.mm:
2426         (WebEditorClient::WebEditorClient):
2427         (WebEditorClient::requestCandidatesForSelection):
2428
2429 2017-09-22  Chris Dumez  <cdumez@apple.com>
2430
2431         Use high resolution timestamp for event time
2432         https://bugs.webkit.org/show_bug.cgi?id=154246
2433         <rdar://problem/34333304>
2434
2435         Reviewed by Ryosuke Niwa.
2436
2437         Use WallTime / MonotonicTime instead of double type for clarity.
2438
2439         * DOM/DOMEvent.mm:
2440         (-[DOMEvent timeStamp]):
2441         * WebView/WebFrame.mm:
2442         (-[WebFrame _dragSourceEndedAt:operation:]):
2443         * WebView/WebPDFView.mm:
2444         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2445
2446 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2447
2448         Enable dataTransfer.items on macOS and iOS
2449         https://bugs.webkit.org/show_bug.cgi?id=177335
2450
2451         Reviewed by Sam Weinig.
2452
2453         * WebView/WebPreferences.mm:
2454         (+[WebPreferences initialize]):
2455
2456 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2457
2458         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2459         https://bugs.webkit.org/show_bug.cgi?id=177101
2460         <rdar://problem/34500648>
2461
2462         Reviewed by Brian Burg.
2463
2464         * WebInspector/WebNodeHighlight.mm:
2465         Ensure we close the window that we have just removed.
2466
2467 2017-09-20  Antti Koivisto  <antti@apple.com>
2468
2469         Remove DOM and styling support for CSS Regions
2470         https://bugs.webkit.org/show_bug.cgi?id=177221
2471
2472         Reviewed by Andreas Kling.
2473
2474         * Configurations/FeatureDefines.xcconfig:
2475         * DOM/DOMCSS.mm:
2476         (kitClass):
2477         * DOM/DOMElement.mm:
2478         (-[DOMElement webkitRegionOverset]): Deleted.
2479
2480 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2481
2482         Layering violation in Editor::createFragment
2483         https://bugs.webkit.org/show_bug.cgi?id=176123
2484
2485         Reviewed by Darin Adler.
2486
2487         * Misc/WebNSURLExtras.h:
2488         * Misc/WebNSURLExtras.mm:
2489         * WebView/WebFrame.mm:
2490         * WebView/WebHTMLView.mm:
2491         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2492
2493         * WebCoreSupport/WebEditorClient.mm:
2494         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2495         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2496         way to avoid exporting the symbol just on newer OSes.
2497
2498 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2499
2500         On iOS, getData can't get text set by setData during copy event
2501         https://bugs.webkit.org/show_bug.cgi?id=176980
2502         <rdar://problem/34453915>
2503
2504         Reviewed by Darin Adler.
2505
2506         * WebCoreSupport/WebPlatformStrategies.h:
2507         * WebCoreSupport/WebPlatformStrategies.mm:
2508         (WebPlatformStrategies::copy): Deleted.
2509
2510 2017-09-18  Andy Estes  <aestes@apple.com>
2511
2512         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2513         https://bugs.webkit.org/show_bug.cgi?id=177029
2514
2515         Reviewed by Alex Christensen.
2516
2517         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2518         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2519         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2520         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2521         * WebCoreSupport/PopupMenuMac.mm:
2522         (PopupMenuMac::show):
2523         * WebCoreSupport/WebSystemInterface.mm:
2524         (InitWebCoreSystemInterface):
2525         * WebView/WebHTMLView.mm:
2526         (-[WebHTMLView setDataSource:]):
2527         (-[WebHTMLView attachRootLayer:]):
2528         * WebView/WebView.mm:
2529         (-[WebView _needsAdobeFrameReloadingQuirk]):
2530         (-[WebView _needsLinkElementTextCSSQuirk]):
2531         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2532         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2533         (-[WebView _preferencesChanged:]):
2534
2535 2017-09-15  Andy Estes  <aestes@apple.com>
2536
2537         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2538         https://bugs.webkit.org/show_bug.cgi?id=176953
2539
2540         Reviewed by Eric Carlson.
2541
2542         * WebCoreSupport/WebSystemInterface.mm:
2543         (InitWebCoreSystemInterface):
2544
2545 2017-09-14  Andy Estes  <aestes@apple.com>
2546
2547         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2548         https://bugs.webkit.org/show_bug.cgi?id=176931
2549
2550         Reviewed by Joseph Pecoraro.
2551
2552         * WebCoreSupport/WebSystemInterface.mm:
2553         (InitWebCoreSystemInterface):
2554
2555 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2556
2557         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2558         https://bugs.webkit.org/show_bug.cgi?id=176867
2559
2560         Reviewed by Sam Weinig.
2561
2562         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2563         (WebKit::NetscapePluginInstanceProxy::enumerate):
2564
2565 2017-09-13  Andy Estes  <aestes@apple.com>
2566
2567         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2568         https://bugs.webkit.org/show_bug.cgi?id=176729
2569
2570         Reviewed by Alex Christensen.
2571
2572         * WebCoreSupport/WebSystemInterface.mm:
2573         (InitWebCoreSystemInterface):
2574         * WebView/WebView.mm:
2575         (+[WebView _setCacheModel:]):
2576
2577 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2578
2579         Refactor WebContentReader out of EditorMac and EditorIOS
2580         https://bugs.webkit.org/show_bug.cgi?id=176770
2581
2582         Reviewed by Sam Weinig.
2583
2584         * WebCoreSupport/WebEditorClient.mm:
2585
2586 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2587
2588         Dragging & dropping a file creates an attachment element even when it's disabled
2589         https://bugs.webkit.org/show_bug.cgi?id=176769
2590
2591         Reviewed by Tim Horton.
2592
2593         * WebView/WebView.mm:
2594         (-[WebView _preferencesChanged:]):
2595
2596 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2597
2598         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2599         https://bugs.webkit.org/show_bug.cgi?id=176721
2600         <rdar://problem/34373660>
2601
2602         Reviewed by Tim Horton.
2603
2604         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2605         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2606
2607         * WebView/WebView.mm:
2608         (-[WebView _startDrag:]):
2609         (-[WebView _draggedElementBounds]):
2610         (-[WebView _endedDataInteraction:global:]):
2611         * WebView/WebViewData.h:
2612
2613 2017-09-11  Andy Estes  <aestes@apple.com>
2614
2615         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2616         https://bugs.webkit.org/show_bug.cgi?id=176472
2617
2618         Reviewed by Eric Carlson.
2619
2620         * WebCoreSupport/WebSystemInterface.mm:
2621         (InitWebCoreSystemInterface):
2622
2623 2017-09-09  Mark Lam  <mark.lam@apple.com>
2624
2625         Avoid duplicate computations of ExecState::vm().
2626         https://bugs.webkit.org/show_bug.cgi?id=176647
2627
2628         Reviewed by Saam Barati.
2629
2630         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2631         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2632         (WebKit::NetscapePluginInstanceProxy::construct):
2633         (WebKit::NetscapePluginInstanceProxy::setProperty):
2634         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2635         (WebKit::NetscapePluginInstanceProxy::enumerate):
2636         * Plugins/Hosted/ProxyInstance.mm:
2637         (WebKit::ProxyRuntimeMethod::create):
2638
2639 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2640
2641         Unreviewed, rolling out r221773.
2642         https://bugs.webkit.org/show_bug.cgi?id=176614
2643
2644         This caused build failures. (Requested by mlewis13 on
2645         #webkit).
2646
2647         Reverted changeset:
2648
2649         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2650         https://bugs.webkit.org/show_bug.cgi?id=176472
2651         http://trac.webkit.org/changeset/221773
2652
2653 2017-09-07  Andy Estes  <aestes@apple.com>
2654
2655         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2656         https://bugs.webkit.org/show_bug.cgi?id=176472
2657
2658         Reviewed by Eric Carlson.
2659
2660         * WebCoreSupport/WebSystemInterface.mm:
2661         (InitWebCoreSystemInterface):
2662
2663 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2664
2665         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2666         https://bugs.webkit.org/show_bug.cgi?id=176561
2667
2668         Reviewed by Brent Fulgham.
2669
2670         * Misc/WebNSUserDefaultsExtras.mm:
2671
2672 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2673
2674         Modernize Geolocation code
2675         https://bugs.webkit.org/show_bug.cgi?id=176496
2676
2677         Reviewed by Andy Estes.
2678
2679         * WebCoreSupport/WebGeolocationClient.h:
2680         * WebCoreSupport/WebGeolocationClient.mm:
2681         (WebGeolocationClient::requestPermission):
2682         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2683         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2684         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2685         * WebView/WebView.mm:
2686         (-[WebView _commonInitializationWithFrameName:groupName:]):
2687         (-[WebView _geolocationDidFailWithMessage:]):
2688
2689 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2690
2691         Remove some unused bits of code and resources
2692         https://bugs.webkit.org/show_bug.cgi?id=176275
2693
2694         Reviewed by Dan Bernstein.
2695
2696         * Misc/WebNSFileManagerExtras.mm:
2697         Include FileSystem instead of FileSystemIOS.
2698
2699 2017-09-03  Darin Adler  <darin@apple.com>
2700
2701         [Cocoa] Tidy a few things in legacy WebHTMLView
2702         https://bugs.webkit.org/show_bug.cgi?id=176280
2703
2704         Reviewed by Dan Bernstein.
2705
2706         * WebCoreSupport/WebChromeClient.mm:
2707         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2708         methods it calls on WebHTMLView were doing nothing on iOS.
2709
2710         * WebView/WebFrame.mm:
2711         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2712         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2713
2714         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2715         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2716         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2717         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2718         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2719         Use RetainPtr instead of writing retain/release wherever possible.
2720         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2721         initialization for it. Removed various unused methods and declarations of methods.
2722         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2723         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2724         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2725         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2726         and remove CFRetain no longer needed since we don't support garbage collection any more.
2727         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2728         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2729         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2730         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2731         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2732         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2733         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2734         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2735         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2736         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2737         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2738         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2739         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2740         debug flag; we haven't used it for years and it's not clearly helpful.
2741         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2742         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2743         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2744         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2745         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2746         two additional methods in the WebPrivate category and still be called by the two
2747         methods in the WebInternal category that were already using it.
2748         (-[WebHTMLView didAddSubview:]): Deleted.
2749         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2750         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2751         place this was called, the close method.
2752         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2753         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2754         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2755         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2756         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2757         Added helper method to make the one below simpler.
2758         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2759         Compared pasteboard type strings using isEqualToString: rather than using == since
2760         we want to actually compare the string contents. Also updated to use modern for loop,
2761         renamed a local variable from "s" to "localSubresources", and factored out the handling
2762         of three image types to use the helper method above.
2763         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2764         _web_makePluginSubviewsPerformSelector:withObject: method.
2765         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2766         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2767         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2768         not call the -[NSView subviews] method to make this identical on both platforms and used
2769         a modern for loop.
2770         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2771         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2772         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2773         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2774         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2775         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2776         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2777         of it is Mac-only.
2778         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2779         method did was call itself on the main thread, and do nothing if called on main thread.
2780         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2781         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2782         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2783         half of this method.
2784         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2785         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2786         Simplified using a modern for loop and RetainPtr.
2787         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2788         (-[WebHTMLView keyDown:]): Ditto.
2789         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2790         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2791         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2792         (-[WebHTMLView complete:]): Ditto.
2793         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2794         now macOS-only.
2795         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2796         iOS since that is now macOS-only.
2797         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2798         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2799         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2800         and reorganized to use early return.
2801         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2802         on iOS, but kept there so we don't have to do #if at every call site.
2803         (-[WebHTMLView _pluginController]): Moved into internal category.
2804         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2805         there only for GC, using C++ initialization, removing obsolete comment.
2806         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2807         peculiar iOS-only comment.
2808         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2809
2810         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2811         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2812         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2813         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2814         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2815
2816         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2817         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2818         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2819         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2820         them at this time.
2821
2822 2017-09-03  Sam Weinig  <sam@webkit.org>
2823
2824         Remove CanvasProxy
2825         https://bugs.webkit.org/show_bug.cgi?id=176288
2826
2827         Reviewed by Yusuke Suzuki.
2828
2829         CanvasProxy does not appear to be in any current HTML spec
2830         and was disabled and unimplemented in our tree. Time to 
2831         get rid of it.
2832
2833         * Configurations/FeatureDefines.xcconfig:
2834
2835 2017-09-02  Andy Estes  <aestes@apple.com>
2836
2837         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2838         https://bugs.webkit.org/show_bug.cgi?id=176270
2839
2840         Reviewed by Tim Horton.
2841
2842         * Plugins/Hosted/NetscapePluginHostManager.mm:
2843         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2844         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2845         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2846         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2847         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2848         (WebKit::SoftwareCARenderer::context const):
2849         (WebKit::SoftwareCARenderer::renderContext const):
2850         (WebKit::SoftwareCARenderer::render):
2851         (-[WebHostedNetscapePluginView createPlugin]):
2852         (-[WebHostedNetscapePluginView createPluginLayer]):
2853         (-[WebHostedNetscapePluginView destroyPlugin]):
2854         (-[WebHostedNetscapePluginView drawRect:]):
2855         * WebCoreSupport/WebSystemInterface.mm:
2856         (InitWebCoreSystemInterface):
2857
2858 2017-09-01  Andy Estes  <aestes@apple.com>
2859
2860         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2861         https://bugs.webkit.org/show_bug.cgi?id=176200
2862
2863         Reviewed by Tim Horton.
2864
2865         * Carbon/HIWebView.mm:
2866         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2867         (overrideCGContext):
2868         (restoreCGContext):
2869         (Draw):
2870         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2871         (+[WebHostedNetscapePluginView initialize]):
2872         * Plugins/WebBaseNetscapePluginView.h:
2873         * Plugins/WebBaseNetscapePluginView.mm:
2874         (WebKit::sendUserChangeNotifications):
2875         * Plugins/WebNetscapePluginView.mm:
2876         (+[WebNetscapePluginView initialize]):
2877         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2878         * WebCoreSupport/WebSystemInterface.mm:
2879         (InitWebCoreSystemInterface):
2880         * WebView/WebFrame.mm:
2881         (-[WebFrame _paintBehaviorForDestinationContext:]):
2882         * WebView/WebFullScreenController.mm:
2883         (setClipRectForWindow):
2884         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2885         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2886         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2887         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2888
2889 2017-08-31  Andy Estes  <aestes@apple.com>
2890
2891         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2892         https://bugs.webkit.org/show_bug.cgi?id=176175
2893
2894         Reviewed by Brady Eidson.
2895
2896         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2897         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2898         * Plugins/Hosted/WebTextInputWindowController.m:
2899         (-[WebTextInputPanel init]):
2900         * WebCoreSupport/WebSystemInterface.mm:
2901         (InitWebCoreSystemInterface):
2902         * WebView/WebDynamicScrollBarsView.mm:
2903         (-[WebDynamicScrollBarsView scrollWheel:]):
2904         * WebView/WebHTMLView.mm:
2905         (-[WebHTMLView _removeWindowObservers]):
2906         (-[WebHTMLView addWindowObservers]):
2907         * WebView/WebView.mm:
2908         (-[WebView addWindowObserversForWindow:]):
2909         (-[WebView removeWindowObservers]):
2910         (-[WebView viewWillMoveToWindow:]):
2911
2912 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2913
2914         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2915         https://bugs.webkit.org/show_bug.cgi?id=175779
2916         <rdar://problem/22367975>
2917
2918         Reviewed by Tim Horton.
2919
2920         * WebCoreSupport/WebFrameLoaderClient.h:
2921         * WebCoreSupport/WebFrameLoaderClient.mm:
2922         (WebFrameLoaderClient::webGLPolicyForURL const):
2923         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2924
2925 2017-08-30  Andy Estes  <aestes@apple.com>
2926
2927         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
2928         https://bugs.webkit.org/show_bug.cgi?id=176093
2929
2930         Reviewed by Eric Carlson.
2931
2932         * WebCoreSupport/WebSystemInterface.mm:
2933         (InitWebCoreSystemInterface):
2934
2935 2017-08-30  Andy Estes  <aestes@apple.com>
2936
2937         [Mac] Upstream Carbon-related WebKitSystemInterface functions
2938         https://bugs.webkit.org/show_bug.cgi?id=176087
2939
2940         Reviewed by Alex Christensen.
2941
2942         * Carbon/CarbonUtils.m:
2943         (getNSAutoreleasePoolCount):
2944         (WebInitForCarbon):
2945         (PoolCleaner):
2946         * Carbon/CarbonWindowAdapter.mm:
2947         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2948         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2949         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2950         (-[CarbonWindowAdapter _windowMovedToRect:]):
2951         * Carbon/HIViewAdapter.m:
2952         * Carbon/HIWebView.mm:
2953         (Draw):
2954         (CreateNSEventAdoptingCGEvent):
2955         (CopyEventCGEvent):
2956         (CreateNSEventWithCarbonClickEvent):
2957         (Click):
2958         (CreateNSEventWithCarbonEvent):
2959         (MouseUp):
2960         (CreateNSEventWithCarbonMouseMoveEvent):
2961         (MouseMoved):
2962         (MouseDragged):
2963         (MouseWheelMoved):
2964         (WindowHandler):
2965         (HIWebViewEventHandler):
2966         * Misc/QuickDrawCompatibility.h: Removed.
2967         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2968         (getCarbonEvent):
2969         (WebNetscapePluginEventHandlerCarbon::keyDown):
2970         (WebNetscapePluginEventHandlerCarbon::keyUp):
2971         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2972         (WebNetscapePluginEventHandlerCocoa::keyDown):
2973         * Plugins/WebNetscapePluginView.mm:
2974         (-[WebNetscapePluginView tellQuickTimeToChill]):
2975
2976 2017-08-29  Andy Estes  <aestes@apple.com>
2977
2978         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
2979         https://bugs.webkit.org/show_bug.cgi?id=176046
2980
2981         Reviewed by Alex Christensen.
2982
2983         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
2984         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
2985
2986         * Misc/WebNSFileManagerExtras.mm:
2987         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2988         (setMetaData): Deleted.
2989         * WebCoreSupport/WebSystemInterface.mm:
2990         (InitWebCoreSystemInterface):
2991
2992 2017-08-28  Andy Estes  <aestes@apple.com>
2993
2994         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
2995         https://bugs.webkit.org/show_bug.cgi?id=176039
2996
2997         Reviewed by Alex Christensen.
2998
2999         * WebCoreSupport/WebSystemInterface.mm:
3000         (InitWebCoreSystemInterface):
3001         * WebView/WebPreferences.mm:
3002         (+[WebPreferences _systemCFStringEncoding]):
3003
3004 2017-08-28  Andy Estes  <aestes@apple.com>
3005
3006         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3007         https://bugs.webkit.org/show_bug.cgi?id=176032
3008
3009         Reviewed by Alex Christensen.
3010
3011         * WebCoreSupport/WebSystemInterface.mm:
3012         (InitWebCoreSystemInterface):
3013         * WebView/WebView.mm:
3014         (-[WebView _cachedResponseForURL:]):
3015
3016 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3017
3018         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3019         https://bugs.webkit.org/show_bug.cgi?id=175992
3020         <rdar://problem/34086613>
3021
3022         Reviewed by Daniel Bates.
3023
3024         * WebCoreSupport/WebPlatformStrategies.h:
3025         * WebCoreSupport/WebPlatformStrategies.mm:
3026         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3027         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3028         indicating if secure cookies were accessed.
3029
3030 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3031
3032         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3033         https://bugs.webkit.org/show_bug.cgi?id=170955
3034         <rdar://problem/31697653>
3035
3036         Reviewed by Ryosuke Niwa.
3037
3038         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3039         text is being replaced.
3040
3041         * WebView/WebHTMLView.mm:
3042         (-[WebHTMLView insertText:]):
3043
3044 2017-08-24  Chris Dumez  <cdumez@apple.com>
3045
3046         [Directory Upload] Add basic support for input.webkitdirectory
3047         https://bugs.webkit.org/show_bug.cgi?id=175950
3048         <rdar://problem/33951915>
3049
3050         Reviewed by Geoffrey Garen.
3051
3052         Add private API to toggle Directory Upload support on Mac WebKit1.
3053
3054         * WebView/WebPreferenceKeysPrivate.h:
3055         * WebView/WebPreferences.mm:
3056         (+[WebPreferences initialize]):
3057         (-[WebPreferences setDirectoryUploadEnabled:]):
3058         (-[WebPreferences directoryUploadEnabled]):
3059         * WebView/WebPreferencesPrivate.h:
3060         * WebView/WebView.mm:
3061         (-[WebView _preferencesChanged:]):
3062
3063 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3064
3065         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3066         https://bugs.webkit.org/show_bug.cgi?id=175370
3067         <rdar://problem/33799806>
3068
3069         Reviewed by Ryosuke Niwa.
3070
3071         Adjust WebEditorClient for interface changes.
3072
3073         * WebCoreSupport/WebEditorClient.h:
3074
3075 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3076
3077         Remove ChromeClient::scrollbarsModeDidChange
3078         https://bugs.webkit.org/show_bug.cgi?id=175805
3079
3080         Reviewed by Daniel Bates.
3081
3082         * WebCoreSupport/WebChromeClient.h:
3083
3084 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3085
3086         Remove ChromeClient::hasOpenedPopup
3087         https://bugs.webkit.org/show_bug.cgi?id=175804
3088
3089         Reviewed by Sam Weinig.
3090
3091         * WebCoreSupport/WebChromeClient.h:
3092         * WebCoreSupport/WebChromeClient.mm:
3093         (WebChromeClient::hasOpenedPopup const): Deleted.
3094
3095 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3096
3097         Disable access to secure cookies if an HTTPS site loads mixed content
3098         https://bugs.webkit.org/show_bug.cgi?id=157053
3099         <rdar://problem/11290808>
3100
3101         Reviewed by Dan Bates.
3102
3103         * WebCoreSupport/WebPlatformStrategies.h:
3104         * WebCoreSupport/WebPlatformStrategies.mm:
3105         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3106         indicating whether secure cookies should be included in the response.
3107
3108 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3109
3110         [PAL] Move spi/mac directory into PAL
3111         https://bugs.webkit.org/show_bug.cgi?id=175649
3112
3113         Reviewed by Myles C. Maxfield.
3114
3115         * Misc/WebSharingServicePickerController.h:
3116         * WebCoreSupport/WebContextMenuClient.mm:
3117         * WebCoreSupport/WebEditorClient.mm:
3118         * WebCoreSupport/WebSelectionServiceController.mm:
3119         * WebView/WebHTMLView.mm:
3120         * WebView/WebImmediateActionController.h:
3121         * WebView/WebImmediateActionController.mm:
3122         * WebView/WebView.mm:
3123
3124 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3125
3126         [PAL] Relocate SessionID to root
3127         https://bugs.webkit.org/show_bug.cgi?id=175684
3128
3129         Reviewed by Alex Christensen.
3130
3131         * WebCoreSupport/WebFrameNetworkingContext.mm:
3132
3133 2017-08-17  Andreas Kling  <akling@apple.com>
3134
3135         Disable CSS regions at compile time
3136         https://bugs.webkit.org/show_bug.cgi?id=175630
3137
3138         Reviewed by Antti Koivisto.
3139
3140         * Configurations/FeatureDefines.xcconfig:
3141
3142 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3143
3144         [PAL] Move SessionID into PAL
3145         https://bugs.webkit.org/show_bug.cgi?id=174192
3146
3147         Reviewed by Antti Koivisto.
3148
3149         * Misc/WebCache.mm:
3150         (+[WebCache imageForURL:]):
3151         * WebCoreSupport/WebFrameLoaderClient.h:
3152         * WebCoreSupport/WebFrameLoaderClient.mm:
3153         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3154         * WebCoreSupport/WebFrameNetworkingContext.mm:
3155         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3156         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3157         (WebFrameNetworkingContext::storageSession const):
3158         * WebCoreSupport/WebPlatformStrategies.h:
3159         * WebCoreSupport/WebPlatformStrategies.mm:
3160         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3161         * WebKitPrefix.h:
3162
3163 2017-08-16  Andy Estes  <aestes@apple.com>
3164
3165         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3166         https://bugs.webkit.org/show_bug.cgi?id=175648
3167
3168         Reviewed by Tim Horton.
3169
3170         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3171         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3172         (WebPaymentCoordinatorClient::showPaymentUI):
3173
3174 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3175
3176         [PAL] Move spi/ios and spi/win directories into PAL
3177         https://bugs.webkit.org/show_bug.cgi?id=175171
3178
3179         Reviewed by Antti Koivisto.
3180
3181         * WebCoreSupport/WebFrameLoaderClient.mm:
3182         * WebView/WebView.mm:
3183
3184 2017-08-16  Andy Estes  <aestes@apple.com>
3185
3186         [Payment Request] Add an ENABLE flag and an experimental feature preference
3187         https://bugs.webkit.org/show_bug.cgi?id=175622
3188
3189         Reviewed by Tim Horton.
3190
3191         * Configurations/FeatureDefines.xcconfig:
3192
3193 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3194
3195         [PAL] Move Sleep classes into PAL
3196         https://bugs.webkit.org/show_bug.cgi?id=175456
3197
3198         Reviewed by Ryosuke Niwa.
3199
3200         * WebView/WebFullScreenController.h:
3201
3202 2017-08-15  Youenn Fablet  <youenn@apple.com>
3203
3204         [Cache API] Adding generic support for CacheStorage and Cache methods
3205         https://bugs.webkit.org/show_bug.cgi?id=175455
3206
3207         Reviewed by Chris Dumez.
3208
3209         * WebView/WebView.mm:
3210         (-[WebView _commonInitializationWithFrameName:groupName:]):
3211
3212 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3213
3214         Remove Proximity Events and related code
3215         https://bugs.webkit.org/show_bug.cgi?id=175545
3216
3217         Reviewed by Daniel Bates.
3218
3219         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3220         and other related code.
3221
3222         * Configurations/FeatureDefines.xcconfig:
3223
3224 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3225
3226         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3227         https://bugs.webkit.org/show_bug.cgi?id=175504
3228
3229         Reviewed by Sam Weinig.
3230
3231         * Configurations/FeatureDefines.xcconfig:
3232         * DOM/DOMHTMLFormElement.mm:
3233         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3234         * WebCoreSupport/WebFrameLoaderClient.h:
3235
3236 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3237
3238         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3239         https://bugs.webkit.org/show_bug.cgi?id=175557
3240
3241         Reviewed by Jon Lee.
3242
3243         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3244
3245         * Configurations/FeatureDefines.xcconfig:
3246
3247 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3248
3249         Composition underline color is always black
3250         https://bugs.webkit.org/show_bug.cgi?id=174675
3251
3252         Reviewed by Ryosuke Niwa.
3253
3254         * WebView/WebHTMLView.mm:
3255         (extractUnderlines): If NSUnderlineColorAttributeName
3256         is not present use text color for composition underline.
3257         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3258         for composition underline in the plain text case.
3259
3260 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3261
3262         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3263         https://bugs.webkit.org/show_bug.cgi?id=175474
3264         <rdar://problem/33844628>
3265
3266         Reviewed by Wenson Hsieh.
3267
3268         Replaced the build flag by a runtime flag and disabled the feature by default.
3269
3270         * Configurations/FeatureDefines.xcconfig:
3271         * WebView/WebPreferenceKeysPrivate.h:
3272         * WebView/WebPreferences.mm:
3273         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3274         (-[WebPreferences dataTransferItemsEnabled]): Added.
3275         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3276         * WebView/WebPreferencesPrivate.h:
3277         * WebView/WebView.mm:
3278         (-[WebView _preferencesChanged:]):
3279
3280 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3281
3282         Remove ENABLE_GAMEPAD_DEPRECATED
3283         https://bugs.webkit.org/show_bug.cgi?id=175361
3284
3285         Reviewed by Carlos Garcia Campos.
3286
3287         * Configurations/FeatureDefines.xcconfig:
3288
3289 2017-08-09  Chris Dumez  <cdumez@apple.com>
3290
3291         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3292         https://bugs.webkit.org/show_bug.cgi?id=175401
3293
3294         Reviewed by Brady Eidson.
3295
3296         * WebView/WebPreferenceKeysPrivate.h:
3297         * WebView/WebPreferences.mm:
3298         (+[WebPreferences initialize]):
3299         (-[WebPreferences beaconAPIEnabled]): Deleted.
3300         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3301         * WebView/WebPreferencesPrivate.h:
3302         * WebView/WebView.mm:
3303         (-[WebView _preferencesChanged:]):
3304
3305 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3306
3307         [PAL] Move spi/cocoa and spi/cg directories into PAL
3308         https://bugs.webkit.org/show_bug.cgi?id=175175
3309
3310         Reviewed by Myles C. Maxfield.
3311
3312         * History/WebHistory.mm:
3313         * Misc/WebDownload.mm:
3314         * Misc/WebKitNSStringExtras.mm:
3315         * Plugins/Hosted/NetscapePluginHostManager.mm:
3316         * Plugins/WebPluginDatabase.mm:
3317         * WebCoreSupport/WebFrameLoaderClient.mm:
3318         * WebInspector/WebNodeHighlight.mm:
3319         * WebView/WebHTMLView.mm:
3320         * WebView/WebIndicateLayer.mm:
3321         * WebView/WebView.mm:
3322         * WebView/WebViewData.h:
3323
3324 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3325
3326         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3327         https://bugs.webkit.org/show_bug.cgi?id=175392
3328         <rdar://problem/33783207>
3329
3330         Reviewed by Tim Horton and Megan Gardner.
3331
3332         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3333
3334         * Configurations/FeatureDefines.xcconfig:
3335
3336 2017-08-09  Daniel Bates  <dabates@apple.com>
3337
3338         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3339         https://bugs.webkit.org/show_bug.cgi?id=175247
3340         <rdar://problem/33679804>
3341
3342         Reviewed by Brady Eidson.
3343
3344         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3345         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3346         clients that need to make use of this information at this time. If such a needs comes up
3347         then we can expose API/SPI similar to what we do for WebKit.
3348
3349         * WebCoreSupport/WebFrameLoaderClient.h:
3350         * WebCoreSupport/WebFrameLoaderClient.mm:
3351         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3352
3353 2017-08-08  Brady Eidson  <beidson@apple.com>
3354
3355         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3356         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3357
3358         Reviewed by Andy Estes.
3359
3360         * Misc/WebKitVersionChecks.h:
3361         * WebCoreSupport/WebFrameLoaderClient.mm:
3362         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3363           the app is linked against new WebKit with the new behavior.
3364
3365 2017-08-07  Devin Rousso  <drousso@apple.com>
3366
3367         Web Inspector: Preview Canvas path when viewing a recording
3368         https://bugs.webkit.org/show_bug.cgi?id=174967
3369
3370         Reviewed by Brian Burg.
3371
3372         * WebView/WebPreferenceKeysPrivate.h:
3373         * WebView/WebPreferences.mm:
3374         (+[WebPreferences initialize]):
3375         (-[WebPreferences inspectorAdditionsEnabled]):
3376         (-[WebPreferences setInspectorAdditionsEnabled:]):
3377         * WebView/WebPreferencesPrivate.h:
3378         * WebView/WebView.mm:
3379         (-[WebView _preferencesChanged:]):
3380         Add plumbing for new InspectorAdditions runtime flag.
3381
3382 2017-08-07  Brian Burg  <bburg@apple.com>
3383
3384         Remove CANVAS_PATH compilation guard
3385         https://bugs.webkit.org/show_bug.cgi?id=175207
3386
3387         Reviewed by Sam Weinig.
3388
3389         * Configurations/FeatureDefines.xcconfig:
3390
3391 2017-08-04  Youenn Fablet  <youenn@apple.com>
3392
3393         [Cache API] Add Cache and CacheStorage IDL definitions
3394         https://bugs.webkit.org/show_bug.cgi?id=175201
3395
3396         Reviewed by Brady Eidson.
3397
3398         * WebView/WebPreferenceKeysPrivate.h:
3399         * WebView/WebPreferences.mm:
3400         (+[WebPreferences initialize]):
3401         (-[WebPreferences cacheAPIEnabled]):
3402         (-[WebPreferences setCacheAPIEnabled:]):
3403         * WebView/WebPreferencesPrivate.h:
3404         * WebView/WebView.mm:
3405         (-[WebView _preferencesChanged:]):
3406
3407 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3408
3409         Unreviewed, rolling out r220271.
3410
3411         Rolling out due to Layout Test failing on iOS Simulator.
3412
3413         Reverted changeset:
3414
3415         "Remove STREAMS_API compilation guard"
3416         https://bugs.webkit.org/show_bug.cgi?id=175165
3417         http://trac.webkit.org/changeset/220271
3418
3419 2017-08-04  Youenn Fablet  <youenn@apple.com>
3420
3421         Remove STREAMS_API compilation guard
3422         https://bugs.webkit.org/show_bug.cgi?id=175165
3423
3424         Reviewed by Darin Adler.
3425
3426         * Configurations/FeatureDefines.xcconfig:
3427         * WebView/WebPreferences.mm:
3428         (+[WebPreferences initialize]):
3429         * WebView/WebView.mm:
3430         (-[WebView _preferencesChanged:]):
3431
3432 2017-08-03  Brian Burg  <bburg@apple.com>
3433
3434         Remove ENABLE(WEB_SOCKET) guards
3435         https://bugs.webkit.org/show_bug.cgi?id=167044
3436
3437         Reviewed by Joseph Pecoraro.
3438
3439         * Configurations/FeatureDefines.xcconfig:
3440         * WebView/WebPreferencesPrivate.h:
3441
3442 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3443
3444         [PAL] Move spi/cf directory into PAL
3445         https://bugs.webkit.org/show_bug.cgi?id=175057
3446
3447         Reviewed by Antti Koivisto.
3448
3449         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3450         * Plugins/WebNetscapePluginStream.mm:
3451         * WebCoreSupport/WebFrameNetworkingContext.mm:
3452         * WebView/WebPreferences.mm:
3453         * WebView/WebView.mm:
3454
3455 2017-08-03  Youenn Fablet  <youenn@apple.com>
3456
3457         Remove FETCH_API compilation guard
3458         https://bugs.webkit.org/show_bug.cgi?id=175154
3459
3460         Reviewed by Chris Dumez.
3461
3462         * Configurations/FeatureDefines.xcconfig:
3463         * WebView/WebPreferences.mm:
3464         (+[WebPreferences initialize]):
3465         * WebView/WebView.mm:
3466         (-[WebView _preferencesChanged:]):
3467
3468 2017-08-03  Brady Eidson  <beidson@apple.com>
3469
3470         Add SW IDLs and stub out basic functionality.
3471         https://bugs.webkit.org/show_bug.cgi?id=175115
3472
3473         Reviewed by Chris Dumez.
3474
3475         * Configurations/FeatureDefines.xcconfig:
3476
3477 2017-08-02  Sam Weinig  <sam@webkit.org>
3478
3479         [WebIDL] Convert MutationCallback to be a normal generated callback
3480         https://bugs.webkit.org/show_bug.cgi?id=174140
3481
3482         Reviewed by Darin Adler.
3483
3484         * DOM/DOMDocument.mm:
3485         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3486         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3487         Pass, now necessary, Document to NativeNodeFilter constructor.
3488
3489 2017-08-01  Chris Dumez  <cdumez@apple.com>
3490
3491         Add initial support for navigator.sendBeacon
3492         https://bugs.webkit.org/show_bug.cgi?id=175007
3493         <rdar://problem/33547728>
3494
3495         Reviewed by Sam Weinig.
3496
3497         Add setting to toggle support for the Beacon API (it is disabled by default).
3498
3499         * WebView/WebPreferenceKeysPrivate.h:
3500         * WebView/WebPreferences.mm:
3501         (+[WebPreferences initialize]):
3502         (-[WebPreferences beaconAPIEnabled]):
3503         (-[WebPreferences setBeaconAPIEnabled:]):
3504         * WebView/WebPreferencesPrivate.h:
3505         * WebView/WebView.mm:
3506         (-[WebView _preferencesChanged:]):
3507
3508 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3509
3510         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3511         https://bugs.webkit.org/show_bug.cgi?id=174437
3512
3513         Reviewed by Darin Adler.
3514
3515         Remove redundant Web- prefix from classes in WebKit namespace.
3516
3517         * WebView/WebView.mm:
3518         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3519         * WebView/WebViewData.h:
3520         * WebView/WebViewData.mm:
3521
3522 2017-07-26  Brian Burg  <bburg@apple.com>
3523
3524         Remove WEB_TIMING feature flag
3525         https://bugs.webkit.org/show_bug.cgi?id=174795
3526
3527         Reviewed by Alex Christensen.
3528
3529         * Configurations/FeatureDefines.xcconfig:
3530
3531 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3532
3533         Async image decoding for large images should be disabled after the first time a tile is painted
3534         https://bugs.webkit.org/show_bug.cgi?id=174451
3535         <rdar://problem/31246421>
3536
3537         Reviewed by Simon Fraser.
3538
3539         * WebView/WebFrame.mm:
3540         (-[WebFrame _paintBehaviorForDestinationContext:]):
3541         (-[WebFrame _drawRect:contentsOnly:]):
3542         * WebView/WebHTMLView.mm:
3543         (imageFromRect):
3544
3545 2017-07-23  Darin Adler  <darin@apple.com>
3546
3547         More NeverDestroyed and related cleanup
3548         https://bugs.webkit.org/show_bug.cgi?id=174745
3549
3550         Reviewed by Alex Christensen.
3551
3552         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3553         for names that aren't even used in this file.
3554         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3555         -[NSArray arrayWithObject:].
3556         (-[DOMNode absoluteQuads]): Ditto.
3557         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3558         of writing out various types.
3559         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3560         syntax instea of -[NSArray arrayWithObject:].
3561         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3562         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3563         of writing out various types.
3564         (-[DOMHTMLImageElement mimeType]): Ditto.
3565
3566 2017-07-24  Chris Dumez  <cdumez@apple.com>
3567
3568         ExceptionCode enumeration should use modern exception names
3569         https://bugs.webkit.org/show_bug.cgi?id=174794
3570
3571         Reviewed by Geoffrey Garen.
3572
3573         * DOM/ExceptionHandlers.mm:
3574         (raiseNotSupportedErrorException):
3575
3576 2017-07-23  Chris Dumez  <cdumez@apple.com>
3577
3578         Drop ExceptionCodeDescription class
3579         https://bugs.webkit.org/show_bug.cgi?id=174757
3580
3581         Reviewed by Darin Adler.
3582
3583         Stop using ExceptionCodeDescription.
3584
3585         * DOM/ExceptionHandlers.mm:
3586         (raiseDOMErrorException):
3587
3588 2017-07-21  Andreas Kling  <akling@apple.com>
3589
3590         Use more references in event dispatch code
3591         https://bugs.webkit.org/show_bug.cgi?id=174681
3592
3593         Reviewed by Geoffrey Garen.
3594
3595         * DOM/ObjCEventListener.h:
3596         * DOM/ObjCEventListener.mm:
3597         (WebCore::ObjCEventListener::handleEvent):
3598         * WebCoreSupport/WebFrameLoaderClient.mm:
3599         (NetscapePluginWidget::handleEvent):
3600
3601 2017-07-21  Brady Eidson  <beidson@apple.com>
3602
3603         Get rid of WebCore IconDatabase code.
3604         https://bugs.webkit.org/show_bug.cgi?id=174700
3605
3606         Reviewed by Tim Horton.
3607
3608         * Misc/WebCoreStatistics.mm:
3609         (+[WebCoreStatistics iconPageURLMappingCount]):
3610         (+[WebCoreStatistics iconRetainedPageURLCount]):
3611         (+[WebCoreStatistics iconRecordCount]):
3612         (+[WebCoreStatistics iconsWithDataCount]):
3613         * WebCoreSupport/WebFrameLoaderClient.h:
3614         * WebCoreSupport/WebFrameLoaderClient.mm:
3615         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
3616         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
3617         * WebView/WebView.mm:
3618         (-[WebView mainFrameIconURL]):
3619
3620 2017-07-20  Chris Dumez  <cdumez@apple.com>
3621
3622         Drop legacy XPathException type
3623         https://bugs.webkit.org/show_bug.cgi?id=174679
3624
3625         Reviewed by Sam Weinig.
3626
3627         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3628         no longer expose XPathException.
3629
3630         * DOM/ExceptionHandlers.mm:
3631         (raiseDOMErrorException):
3632
3633 2017-07-20  Chris Dumez  <cdumez@apple.com>
3634
3635         Unreviewed, rolling out r219706.
3636
3637         Broke iOS build
3638
3639         Reverted changeset:
3640
3641         "Drop legacy XPathException type"
3642         https://bugs.webkit.org/show_bug.cgi?id=174679
3643         http://trac.webkit.org/changeset/219706
3644
3645 2017-07-20  Chris Dumez  <cdumez@apple.com>
3646
3647         Drop legacy XPathException type
3648         https://bugs.webkit.org/show_bug.cgi?id=174679
3649
3650         Reviewed by Sam Weinig.
3651
3652         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3653         no longer expose XPathException.
3654
3655         * DOM/ExceptionHandlers.mm:
3656         (raiseDOMErrorException):
3657         * WebKit.exp:
3658
3659 2017-07-20  Chris Dumez  <cdumez@apple.com>
3660
3661         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
3662         https://bugs.webkit.org/show_bug.cgi?id=174660
3663
3664         Reviewed by Geoffrey Garen.
3665
3666         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
3667         This essentially replaces a branch to figure out if the new size is less or greater than the
3668         current size by an assertion.
3669
3670         * Plugins/WebNetscapePluginView.mm:
3671         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3672
3673 2017-07-20  Brady Eidson  <beidson@apple.com>
3674
3675         Deprecate WebIconDatabase in WebKitLegacy/mac.
3676         https://bugs.webkit.org/show_bug.cgi?id=174607
3677
3678         Reviewed by Alex Christensen.
3679
3680         This patch:
3681         1 - Formally deprecates WebIconDatabase (which was never API anyways)
3682         2 - Guts the class to where it can only return the default icon at the small size
3683         3 - Reworks other parts of WebKitLegacy that used it for anything to either
3684             use something else or to not do anything.
3685         
3686         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
3687         and that patch will remove all of the last remnants of WebIconDatabase.
3688         
3689         * History/WebHistoryItem.mm:
3690         (-[WebHistoryItem icon]):
3691
3692         * Misc/WebIconDatabase.h:
3693         * Misc/WebIconDatabase.mm:
3694         (-[WebIconDatabase init]):
3695         (-[WebIconDatabase iconForURL:withSize:cache:]):
3696         (-[WebIconDatabase iconForURL:withSize:]):
3697         (-[WebIconDatabase defaultIconWithSize:]):
3698         (-[WebIconDatabase defaultIconForURL:withSize:]):
3699         (-[WebIconDatabase iconURLForURL:]):
3700         (-[WebIconDatabase retainIconForURL:]):
3701         (-[WebIconDatabase releaseIconForURL:]):
3702         (+[WebIconDatabase delayDatabaseCleanup]):
3703         (+[WebIconDatabase allowDatabaseCleanup]):
3704         (-[WebIconDatabase setDelegate:]):
3705         (-[WebIconDatabase delegate]):
3706         (+[WebIconDatabase initialize]): Deleted.
3707         (-[WebIconDatabase isEnabled]): Deleted.
3708         (-[WebIconDatabase setEnabled:]): Deleted.
3709         (-[WebIconDatabase removeAllIcons]): Deleted.
3710         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
3711         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
3712         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
3713         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
3714         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
3715         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
3716         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
3717         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
3718         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
3719         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
3720         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
3721         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
3722         (-[WebIconDatabase _databaseDirectory]): Deleted.
3723         (webGetNSImage): Deleted.
3724
3725         * Misc/WebIconDatabaseDelegate.h: Removed.
3726         * Misc/WebIconDatabaseInternal.h: Removed.
3727         * Misc/WebIconDatabasePrivate.h: Removed.
3728
3729         * WebCoreSupport/WebFrameLoaderClient.mm:
3730         (webGetNSImage):
3731
3732         * WebCoreSupport/WebIconDatabaseClient.mm:
3733         (WebIconDatabaseClient::didRemoveAllIcons):
3734         (WebIconDatabaseClient::didImportIconURLForPageURL):
3735
3736         * WebView/WebView.mm:
3737         (-[WebView setFrameLoadDelegate:]):
3738         (-[WebView mainFrameIcon]):
3739
3740 2017-07-18  Andy Estes  <aestes@apple.com>
3741
3742         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3743         https://bugs.webkit.org/show_bug.cgi?id=174631
3744
3745         Reviewed by Tim Horton.
3746
3747         * Configurations/Base.xcconfig:
3748
3749 2017-07-18  Andy Estes  <aestes@apple.com>
3750
3751         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3752         https://bugs.webkit.org/show_bug.cgi?id=174631
3753
3754         Reviewed by Sam Weinig.
3755
3756         * Configurations/Base.xcconfig:
3757
3758 2017-07-18  Andy Estes  <aestes@apple.com>
3759
3760         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3761         https://bugs.webkit.org/show_bug.cgi?id=174631
3762
3763         Reviewed by Dan Bernstein.
3764
3765         * Configurations/Base.xcconfig:
3766
3767 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3768
3769         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
3770         https://bugs.webkit.org/show_bug.cgi?id=174640
3771         <rdar://problem/33297400>
3772
3773         Reviewed by Tim Horton.
3774
3775         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
3776         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
3777         web thread here, to match the other WebView drag and drop SPI methods.
3778
3779         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
3780         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
3781         should make this robust against future UIKit changes that could make this no longer the case.
3782
3783         * WebView/WebView.mm:
3784         (-[WebView _requestStartDataInteraction:globalPosition:]):
3785         (-[WebView _dataInteractionCaretRect]):
3786
3787 2017-07-18  Andy Estes  <aestes@apple.com>
3788
3789         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3790         https://bugs.webkit.org/show_bug.cgi?id=174631
3791
3792         Reviewed by Darin Adler.
3793
3794         * Configurations/Base.xcconfig:
3795
3796 2017-07-17  Sam Weinig  <sam@webkit.org>
3797
3798         [WebIDL] Remove custom bindings that require non-caching JS strings
3799         https://bugs.webkit.org/show_bug.cgi?id=174552
3800
3801         Reviewed by Darin Adler.
3802
3803         * DOM/DOMHTMLCanvasElement.mm:
3804         (-[DOMHTMLCanvasElement toDataURL:]):
3805         Update to account for implementation now returning an UncachedString.
3806
3807 2017-07-17  Darin Adler  <darin@apple.com>
3808
3809         Improve use of NeverDestroyed
3810         https://bugs.webkit.org/show_bug.cgi?id=174348
3811
3812         Reviewed by Sam Weinig.
3813
3814         * Misc/WebStringTruncator.mm:
3815         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
3816         NeverDestroyed<RetainPtr> with just an NSFont * global.
3817
3818         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
3819         NeverDestroyed.h.
3820         * Storage/WebDatabaseManager.mm: Ditto.
3821         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
3822         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
3823
3824         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
3825         (aeDescFromJSValue): Removed double hashing by using the return value from
3826         add rather than calling contains before calling add.
3827
3828 2017-07-14  Jer Noble  <jer.noble@apple.com>
3829
3830         Allow clients to override their own hardware media requirements where no fallback media exists.
3831         https://bugs.webkit.org/show_bug.cgi?id=174426
3832         <rdar://problem/32537704>
3833
3834         Reviewed by Eric Carlson.
3835
3836         Add a new WebPreferences property to control WebCore's new
3837         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
3838
3839         * WebView/WebPreferenceKeysPrivate.h:
3840         * WebView/WebPreferences.mm:
3841         (+[WebPreferences initialize]):
3842         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
3843         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
3844         * WebView/WebPreferencesPrivate.h:
3845         * WebView/WebView.mm:
3846         (-[WebView _preferencesChanged:]):
3847
3848 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
3849
3850         Async image decoding for large images should be disabled by default
3851         https://bugs.webkit.org/show_bug.cgi?id=174432
3852
3853         Reviewed by Simon Fraser.
3854
3855         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
3856         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
3857         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
3858            a child view instead of propagating PaintBehaviorSnapshotting.
3859         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
3860            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
3861
3862         * WebView/WebFrame.mm:
3863         (-[WebFrame _paintBehaviorForDestinationContext:]):
3864         (-[WebFrame _drawRect:contentsOnly:]):
3865         * WebView/WebHTMLView.mm:
3866         (imageFromRect):
3867
3868 2017-07-12  Daniel Bates  <dabates@apple.com>
3869
3870         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3871         https://bugs.webkit.org/show_bug.cgi?id=174427
3872
3873         Rubber-stamped by Brady Eidson.
3874
3875         * WebView/WebPDFView.mm:
3876         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3877
3878 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3879
3880         Unreviewed, rolling out r219401.
3881
3882         This revision rolled out the previous patch, but after talking
3883         with reviewer, a rebaseline is what was needed.Rolling back in
3884         before rebaseline.
3885
3886         Reverted changeset:
3887
3888         "Unreviewed, rolling out r219379."
3889         https://bugs.webkit.org/show_bug.cgi?id=174400
3890         http://trac.webkit.org/changeset/219401
3891
3892 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3893
3894         Unreviewed, rolling out r219379.
3895
3896         This revision caused a consistent failure in the test
3897         fast/dom/Window/property-access-on-cached-window-after-frame-
3898         removed.html.
3899
3900         Reverted changeset:
3901
3902         "Remove NAVIGATOR_HWCONCURRENCY"
3903         https://bugs.webkit.org/show_bug.cgi?id=174400
3904         http://trac.webkit.org/changeset/219379
3905
3906 2017-07-11  Dean Jackson  <dino@apple.com>
3907
3908         Remove NAVIGATOR_HWCONCURRENCY
3909         https://bugs.webkit.org/show_bug.cgi?id=174400
3910
3911         * Configurations/FeatureDefines.xcconfig:
3912
3913 2017-07-11  Dean Jackson  <dino@apple.com>
3914
3915         Rolling out r219372.
3916
3917         * Configurations/FeatureDefines.xcconfig:
3918
3919 2017-07-11  Dean Jackson  <dino@apple.com>
3920
3921         Remove NAVIGATOR_HWCONCURRENCY
3922         https://bugs.webkit.org/show_bug.cgi?id=174400
3923
3924         * Configurations/FeatureDefines.xcconfig:
3925
3926 2017-07-03  Brian Burg  <bburg@apple.com>
3927
3928         Web Replay: remove some unused code
3929         https://bugs.webkit.org/show_bug.cgi?id=173903
3930
3931         Rubber-stamped by Joseph Pecoraro.
3932
3933         * Configurations/FeatureDefines.xcconfig:
3934
3935 2017-07-09  Brady Eidson  <beidson@apple.com>
3936
3937         Remove some obsolete WebKitVersionChecks.
3938         https://bugs.webkit.org/show_bug.cgi?id=174294
3939
3940         Reviewed by Dan Bernstein.
3941
3942         * Misc/WebKitVersionChecks.h:
3943
3944         * WebView/WebHTMLView.mm:
3945         (-[WebHTMLView hitTest:]):
3946
3947         * WebView/WebView.mm:
3948         (shouldRespectPriorityInCSSAttributeSetters):
3949         (-[WebView _commonInitializationWithFrameName:groupName:]):
3950         (-[WebView _preferencesChanged:]):
3951         (shouldTransformsAffectOverflow): Deleted.
3952         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
3953
3954 2017-07-08  Brady Eidson  <beidson@apple.com>
3955
3956         Remove some obsolete RuntimeApplicationChecks.
3957         https://bugs.webkit.org/show_bug.cgi?id=174293
3958
3959         Reviewed by Dan Bernstein.
3960
3961         * Misc/WebKitVersionChecks.h:
3962         * WebView/WebView.mm:
3963         (+[WebView enableWebThread]):
3964         (-[WebView _needsPreHTML5ParserQuirks]):
3965
3966 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3967
3968         Drop NOSNIFF compile flag
3969         https://bugs.webkit.org/show_bug.cgi?id=174289
3970
3971         Reviewed by Michael Catanzaro.
3972
3973         * Configurations/FeatureDefines.xcconfig:
3974
3975 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3976
3977         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3978         https://bugs.webkit.org/show_bug.cgi?id=174150
3979
3980         Reviewed by Mark Lam.
3981
3982         * DOM/DOM.mm:
3983         (lookupElementClass):
3984
3985 2017-07-06  Brady Eidson  <beidson@apple.com>
3986
3987         Add logging to first attempt to use the WebIconDatabase class.
3988         https://bugs.webkit.org/show_bug.cgi?id=174190
3989
3990         Reviewed by Andy Estes.
3991
3992         * Misc/WebIconDatabase.mm:
3993         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
3994         * Misc/WebKitVersionChecks.h:
3995
3996 2017-07-06  Matt Lewis  <jlewis3@apple.com>
3997
3998         Unreviewed, rolling out r219178.
3999
4000         This caused a consistent failure with the API test
4001         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
4002
4003         Reverted changeset:
4004
4005         "[WTF] Clean up StringStatics.cpp by using
4006         LazyNeverDestroyed<> for Atoms"
4007         https://bugs.webkit.org/show_bug.cgi?id=174150
4008         http://trac.webkit.org/changeset/219178
4009
4010 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
4011
4012         [WTF] Move SoftLinking.h into WTF
4013         https://bugs.webkit.org/show_bug.cgi?id=174000
4014
4015         Reviewed by Alex Christensen.
4016
4017         * Plugins/WebNetscapePluginView.mm:
4018         * Plugins/WebPluginController.mm:
4019         * WebCoreSupport/WebInspectorClient.mm:
4020         * WebView/WebFullScreenController.mm:
4021         * WebView/WebImmediateActionController.mm:
4022         * WebView/WebView.mm:
4023
4024 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
4025
4026         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
4027         https://bugs.webkit.org/show_bug.cgi?id=174150
4028
4029         Reviewed by Mark Lam.
4030
4031         * DOM/DOM.mm:
4032         (lookupElementClass):
4033
4034 2017-07-05  Brady Eidson  <beidson@apple.com>
4035
4036         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
4037         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
4038
4039         Reviewed by Alex Christensen.
4040
4041         Adopt to the new constructor for FrameLoadRequest.
4042
4043         * WebView/WebPDFView.mm:
4044         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4045
4046 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
4047
4048         Make WebKit's public headers on Mac and iOS C++ module safe
4049         https://bugs.webkit.org/show_bug.cgi?id=174175
4050
4051         Reviewed by Alex Christensen.
4052
4053         Fixed the header files.
4054
4055         * Misc/WebDownload.h:
4056         * Misc/WebKitErrors.h:
4057         * Plugins/WebPluginContainer.h:
4058         * WebView/WebResourceLoadDelegate.h:
4059
4060 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
4061
4062         Remove copy of ICU headers from WebKit
4063         https://bugs.webkit.org/show_bug.cgi?id=116407
4064
4065         Reviewed by Alex Christensen.
4066
4067         Use WTF's copy of ICU headers.
4068
4069         * Configurations/WebKitLegacy.xcconfig:
4070         * icu/unicode/localpointer.h: Removed.
4071         * icu/unicode/parseerr.h: Removed.
4072         * icu/unicode/platform.h: Removed.
4073         * icu/unicode/ptypes.h: Removed.
4074         * icu/unicode/putil.h: Removed.
4075         * icu/unicode/uchar.h: Removed.
4076         * icu/unicode/uconfig.h: Removed.
4077         * icu/unicode/ucurr.h: Removed.
4078         * icu/unicode/uidna.h: Removed.
4079         * icu/unicode/uiter.h: Removed.
4080         * icu/unicode/umachine.h: Removed.
4081         * icu/unicode/unorm.h: Removed.
4082         * icu/unicode/unorm2.h: Removed.
4083         * icu/unicode/urename.h: Removed.
4084         * icu/unicode/uscript.h: Removed.
4085         * icu/unicode/ustring.h: Removed.