[Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
2
3         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
4         https://bugs.webkit.org/show_bug.cgi?id=182882
5         <rdar://problem/35672661>
6
7         Reviewed by Dan Bernstein.
8
9         Make sure the smart pointer hold the collection of subviews lives at least as
10         long as the loop using it.
11
12         * WebView/WebHTMLView.mm:
13         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
14
15 2018-02-14  Daniel Bates  <dabates@apple.com>
16
17         Disallow cross-origin subresources from asking for credentials
18         https://bugs.webkit.org/show_bug.cgi?id=182579
19         <rdar://problem/36162271>
20
21         Reviewed by Andy Estes.
22
23         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
24         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
25
26         * WebView/WebPreferenceKeysPrivate.h:
27         * WebView/WebPreferences.mm:
28         (+[WebPreferences initialize]):
29         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
30         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
31         * WebView/WebPreferencesPrivate.h:
32         * WebView/WebView.mm:
33         (-[WebView _preferencesChanged:]):
34
35 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
36
37         Remove ForwardingHeaders directory from WebKitLegacy/mac.
38         https://bugs.webkit.org/show_bug.cgi?id=182738
39
40         Reviewed by Darin Adler.
41
42         * ForwardingHeaders/collector/handles/Global.h: Removed.
43         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
44         * ForwardingHeaders/runtime/Completion.h: Removed.
45         * ForwardingHeaders/runtime/Error.h: Removed.
46         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
47         * ForwardingHeaders/runtime/JSFunction.h: Removed.
48         * ForwardingHeaders/runtime/JSLock.h: Removed.
49         * ForwardingHeaders/runtime/JSObject.h: Removed.
50         * ForwardingHeaders/runtime/JSString.h: Removed.
51         * ForwardingHeaders/runtime/Protect.h: Removed.
52         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
53
54 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
55
56         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
57         https://bugs.webkit.org/show_bug.cgi?id=182641
58
59         Reviewed by Dan Bernstein.
60
61         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
62         https://trac.webkit.org/changeset/228308.
63
64         * WebView/WebVideoFullscreenController.h:
65         * WebView/WebVideoFullscreenHUDWindowController.mm:
66         * WebView/WebWindowAnimation.h:
67         * WebView/WebWindowAnimation.mm:
68         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
69         (WebCore::scaledRect): Deleted.
70         (WebCore::squaredDistance): Deleted.
71
72 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
73
74         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
75
76         * WebView/WebWindowAnimation.mm:
77         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
78
79 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
80
81         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
82         https://bugs.webkit.org/show_bug.cgi?id=182615
83
84         Reviewed by Eric Carlson.
85
86         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
87         Ideally, we should not reference NSApp in WebCore.
88
89         * WebView/WebFullScreenController.mm:
90         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
91         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
92         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
93         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
94         * WebView/WebView.mm:
95         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
96         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
97
98 2018-01-13  Darin Adler  <darin@apple.com>
99
100         Event improvements
101         https://bugs.webkit.org/show_bug.cgi?id=179591
102
103         Reviewed by Chris Dumez.
104
105         * DOM/DOMWheelEvent.mm:
106         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
107         Call initWebKitWheelEvent.
108
109         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
110         * WebCoreSupport/WebInspectorClient.mm: Ditto.
111         * WebView/WebFrame.mm: Ditto.
112
113         * WebView/WebHTMLView.mm:
114         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
115         underlyingPlatformEvent.
116         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
117
118         * WebView/WebScriptWorld.mm:
119         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
120
121         * WebView/WebView.mm: Removed include of ScriptValue.h.
122
123 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
124
125         Remove WebCore/ForwardingHeaders directory
126         https://bugs.webkit.org/show_bug.cgi?id=182347
127
128         Reviewed by Keith Miller.
129
130         * Carbon/CarbonWindowAdapter.mm:
131         * DOM/WebDOMOperations.mm:
132         * History/WebBackForwardList.mm:
133         * History/WebHistoryItem.mm:
134         * Misc/WebCache.mm:
135         * Misc/WebElementDictionary.mm:
136         * Misc/WebIconDatabase.mm:
137         * Misc/WebStringTruncator.mm:
138         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
139         * Plugins/Hosted/ProxyInstance.mm:
140         * Plugins/Hosted/ProxyRuntimeObject.mm:
141         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
142         * Plugins/WebBaseNetscapePluginView.mm:
143         * Plugins/WebBasePluginPackage.mm:
144         * Plugins/WebNetscapePluginStream.mm:
145         * Plugins/WebNetscapePluginView.mm:
146         * Plugins/WebPluginController.mm:
147         * WebCoreSupport/WebEditorClient.mm:
148         * WebCoreSupport/WebFrameLoaderClient.mm:
149         * WebCoreSupport/WebInspectorClient.h:
150         * WebCoreSupport/WebInspectorClient.mm:
151         * WebView/WebDataSource.mm:
152         * WebView/WebFrame.mm:
153         * WebView/WebHTMLRepresentation.mm:
154         * WebView/WebHTMLView.mm:
155         * WebView/WebPreferences.mm:
156         * WebView/WebScriptDebugDelegate.mm:
157         * WebView/WebScriptDebugger.h:
158         * WebView/WebTextIterator.mm:
159         * WebView/WebView.mm:
160         * WebView/WebViewData.mm:
161
162 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
163
164         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
165         https://bugs.webkit.org/show_bug.cgi?id=182312
166
167         Reviewed by Michael Catanzaro.
168
169         * WebKitPrefix.h:
170
171 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
172
173         [WebAuthN] Add a compile-time feature flag
174         https://bugs.webkit.org/show_bug.cgi?id=182211
175         <rdar://problem/36936365>
176
177         Reviewed by Brent Fulgham.
178
179         * Configurations/FeatureDefines.xcconfig:
180
181 2018-01-27  Dan Bernstein  <mitz@apple.com>
182
183         HaveInternalSDK includes should be "#include?"
184         https://bugs.webkit.org/show_bug.cgi?id=179670
185
186         * Configurations/Base.xcconfig:
187
188 2018-01-24  Alex Christensen  <achristensen@webkit.org>
189
190         Remove unused QTKit preference
191         https://bugs.webkit.org/show_bug.cgi?id=181968
192
193         Reviewed by Alexey Proskuryakov.
194
195         * WebView/WebPreferenceKeysPrivate.h:
196         * WebView/WebPreferences.mm:
197         (+[WebPreferences initialize]):
198         (-[WebPreferences setQTKitEnabled:]): Deleted.
199         (-[WebPreferences isQTKitEnabled]): Deleted.
200         * WebView/WebPreferencesPrivate.h:
201         * WebView/WebView.mm:
202         (-[WebView _preferencesChanged:]):
203
204 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
205
206         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
207         https://bugs.webkit.org/show_bug.cgi?id=182037
208         <rdar://problem/36747812>
209
210         Reviewed by Ryosuke Niwa.
211
212         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
213         for more details.
214
215         * WebView/WebHTMLRepresentation.mm:
216         (-[WebHTMLRepresentation elementWithName:inForm:]):
217         (-[WebHTMLRepresentation controlsInForm:]):
218
219 2018-01-23  Alex Christensen  <achristensen@webkit.org>
220
221         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
222         https://bugs.webkit.org/show_bug.cgi?id=181961
223
224         Reviewed by Michael Catanzaro.
225
226         * WebView/WebPreferences.mm:
227
228 2018-01-23  Commit Queue  <commit-queue@webkit.org>
229
230         Unreviewed, rolling out r227437.
231         https://bugs.webkit.org/show_bug.cgi?id=182011
232
233         broke build (Requested by alexchristensen on #webkit).
234
235         Reverted changeset:
236
237         "Remove unused QTKit preference"
238         https://bugs.webkit.org/show_bug.cgi?id=181968
239         https://trac.webkit.org/changeset/227437
240
241 2018-01-23  Alex Christensen  <achristensen@webkit.org>
242
243         Remove unused QTKit preference
244         https://bugs.webkit.org/show_bug.cgi?id=181968
245
246         Reviewed by Alexey Proskuryakov.
247
248         * WebView/WebPreferenceKeysPrivate.h:
249         * WebView/WebPreferences.mm:
250         (+[WebPreferences initialize]):
251         (-[WebPreferences setQTKitEnabled:]): Deleted.
252         (-[WebPreferences isQTKitEnabled]): Deleted.
253         * WebView/WebPreferencesPrivate.h:
254         * WebView/WebView.mm:
255         (-[WebView _preferencesChanged:]):
256
257 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
258
259         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
260         https://bugs.webkit.org/show_bug.cgi?id=181960
261         <rdar://problem/36431678>
262
263         Reviewed by Tim Horton.
264
265         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
266         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
267         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
268
269         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
270         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
271         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
272
273         * WebView/WebView.mm:
274         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
275
276 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
277
278         Turning off custom pasteboard data doesn't actually turn it off in WK2
279         https://bugs.webkit.org/show_bug.cgi?id=181920
280         <rdar://problem/36686429>
281
282         Reviewed by Wenson Hsieh.
283
284         Always disable custom pasteboard data in WebKit1. See r226156 for details.
285
286         * WebView/WebPreferences.mm:
287         (+[WebPreferences initialize]):
288         * WebView/WebView.mm:
289         (-[WebView _preferencesChanged:]):
290
291 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
292
293         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
294         https://bugs.webkit.org/show_bug.cgi?id=181918
295
296         Reviewed by Tim Horton.
297
298         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
299
300         * Configurations/FeatureDefines.xcconfig:
301
302 2018-01-20  Andy Estes  <aestes@apple.com>
303
304         [Apple Pay] Stop eagerly loading PassKit.framework
305         https://bugs.webkit.org/show_bug.cgi?id=181911
306         <rdar://problem/36555369>
307
308         Reviewed by Tim Horton.
309
310         * WebCoreSupport/WebPaymentCoordinatorClient.h:
311         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
312         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
313
314         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
315
316 2018-01-19  Dean Jackson  <dino@apple.com>
317
318         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
319         https://bugs.webkit.org/show_bug.cgi?id=181817
320         <rdar://problem/35274055>
321
322         Reviewed by Simon Fraser.
323
324         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
325
326         * Misc/WebKitVersionChecks.h:
327         * WebView/WebView.mm:
328         (-[WebView _commonInitializationWithFrameName:groupName:]):
329
330 2018-01-19  Alex Christensen  <achristensen@webkit.org>
331
332         Remove unused WebViewPrivate _allowCookies
333         https://bugs.webkit.org/show_bug.cgi?id=181812
334
335         Reviewed by Tim Horton.
336
337         * WebView/WebView.mm:
338         (+[WebView _setAllowCookies:]): Deleted.
339         (+[WebView _allowCookies]): Deleted.
340         * WebView/WebViewPrivate.h:
341
342 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
343
344         Build fix, remove a call to -[NSWindow setOneShot:]
345         https://bugs.webkit.org/show_bug.cgi?id=181809
346
347         Reviewed by Tim Horton.
348
349         * WebView/WebTextCompletionController.mm:
350         (-[WebTextCompletionController _buildUI]):
351
352 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
353
354         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
355
356         * Carbon/HIWebView.mm:
357         (overrideCGContext):
358         (restoreCGContext):
359
360 2018-01-18  Dan Bernstein  <mitz@apple.com>
361
362         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
363         https://bugs.webkit.org/show_bug.cgi?id=181803
364
365         Reviewed by Tim Horton.
366
367         * Configurations/Base.xcconfig: Updated.
368         * Configurations/DebugRelease.xcconfig: Ditto.
369         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
370         * Configurations/Version.xcconfig: Updated.
371         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
372           useful for defining settings that depend on the target macOS version.
373
374 2018-01-17  Youenn Fablet  <youenn@apple.com>
375
376         Put fetch Request.keepalive behind a runtime flag
377         https://bugs.webkit.org/show_bug.cgi?id=181592
378
379         Reviewed by Chris Dumez.
380
381         * WebView/WebPreferenceKeysPrivate.h:
382         * WebView/WebPreferences.mm:
383         (+[WebPreferences initialize]):
384         (-[WebPreferences fetchAPIKeepAliveEnabled]):
385         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
386         * WebView/WebPreferencesPrivate.h:
387         * WebView/WebView.mm:
388         (-[WebView _preferencesChanged:]):
389
390 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
391
392         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
393         https://bugs.webkit.org/show_bug.cgi?id=181637
394         <rdar://problem/36508471>
395
396         Reviewed by Tim Horton.
397
398         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
399
400         * WebCoreSupport/WebEditorClient.h:
401         * WebCoreSupport/WebEditorClient.mm:
402         (WebEditorClient::replacementURLForResource):
403
404 2018-01-11  Keith Miller  <keith_miller@apple.com>
405
406         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
407         https://bugs.webkit.org/show_bug.cgi?id=181573
408
409         Reviewed by Simon Fraser.
410
411         * Configurations/FeatureDefines.xcconfig:
412
413 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
414
415         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
416         https://bugs.webkit.org/show_bug.cgi?id=181497
417
418         Reviewed by Tim Horton.
419
420         See other ChangeLogs for more detail.
421
422         * WebCoreSupport/WebDragClient.h:
423
424 2018-01-11  Tim Horton  <timothy_horton@apple.com>
425
426         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
427         https://bugs.webkit.org/show_bug.cgi?id=181523
428         <rdar://problem/28959131>
429
430         Reviewed by Alex Christensen.
431
432         * WebView/WebImmediateActionController.mm:
433         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
434         Apply the change made in r216652 to WebKit1's immediate action controller.
435
436         Speculative (but successful in WebKit2) fix for non-reproducible crash when
437         the startContainer of the range is in an anonymous node.
438
439 2018-01-11  Youenn Fablet  <youenn@apple.com>
440
441         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
442         https://bugs.webkit.org/show_bug.cgi?id=181480
443
444         Reviewed by Eric Carlson.
445
446         * WebView/WebPreferences.mm:
447         (+[WebPreferences initialize]):
448
449 2018-01-08  David Kilzer  <ddkilzer@apple.com>
450
451         Fix check-webkit-style issues with WebNSDataExtras.mm
452         <https://webkit.org/b/181369>
453
454         Reviewed by Alex Christensen.
455
456         * Misc/WebNSDataExtras.mm:
457         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
458         (-[NSData _webkit_guessedMIMETypeForXML]):
459         (-[NSData _webkit_guessedMIMEType]):
460         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
461         (_findEOL):
462         (-[NSData _webkit_parseRFC822HeaderFields]):
463         (-[NSData _web_locationAfterFirstBlankLine]):
464         - Fix all the check-webkit-style warnings.
465
466 2018-01-08  David Kilzer  <ddkilzer@apple.com>
467
468         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
469         <https://webkit.org/b/181256>
470         <rdar://problem/36281730>
471
472         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
473         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
474         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
475           to avoid warnings from casting CFStringRef to NPNSString*.
476           Note that CFMutableStringRef is the same as CFStringRef
477           without the const modifier, hence its use in the const_cast<>
478           above.
479
480 2018-01-08  David Kilzer  <ddkilzer@apple.com>
481
482         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
483         <https://webkit.org/b/181256>
484         <rdar://problem/36281730>
485
486         * Carbon/HIWebView.mm:
487         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
488         checked_cf_cast<CFRunLoopRef>() to fix warning.
489
490 2018-01-07  David Kilzer  <ddkilzer@apple.com>
491
492         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
493         <https://webkit.org/b/181256>
494         <rdar://problem/36281730>
495
496         Reviewed by Darin Adler.
497
498         * Carbon/CarbonUtils.m:
499         (PoolCleaner):
500         - Use #pragmas to ignore -Wcast-qual warnings when using a
501           C-style cast from CFTypeRef to CFRunloopRef.
502         * Carbon/CarbonWindowFrame.m:
503         (-[CarbonWindowFrame title]):
504         - Use #pragmas to ignore -Wcast-qual warnings when using a
505           C-style cast from CFStringRef to NSString *.
506         * Carbon/HIViewAdapter.m:
507         (+[HIViewAdapter getHIViewForNSView:]):
508         - Use #pragmas to ignore -Wcast-qual warnings when using a
509           C-style cast from CFTypeRef to HIViewRef.
510         * Configurations/Base.xcconfig:
511         (WARNING_CFLAGS): Add -Wcast-qual.
512         * Misc/WebElementDictionary.mm:
513         (-[WebElementDictionary objectForKey:]):
514         - Use static_cast<SEL>(const_cast<void*>()) to fix
515           warning.
516         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
517         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
518         (-[NSData _webkit_guessedMIMETypeForXML]):
519         (-[NSData _webkit_guessedMIMEType]):
520         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
521         (_findEOL):
522         (-[NSData _webkit_parseRFC822HeaderFields]):
523         (-[NSData _web_startsWithBlankLine]):
524         (-[NSData _web_locationAfterFirstBlankLine]):
525         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
526           type to Objective-C++.  This fixes the warnings about
527           discarding the `const` modifier when casing from CFStringRef
528           to NSString * because in older clang versions, -Wcast-qual was
529           completely broken when compiling C++ and Objective-C++ source
530           files.  In newer clang versions, discarding the `const`
531           modifier for toll-free bridged types is ignored when compiling
532           Objective-C++ source.
533         - Update copyright and license header.
534         - Use reinterpret_cast<> and static_cast<> to fix warnings
535           unrelated to (NSString *) C-style casts.
536         - Replace use of MIN() macro with std::min<> template functions.
537         - Fix location of `*` for local variables modified above.
538         * Plugins/Hosted/NetscapePluginHostManager.mm:
539         (WebKit::NetscapePluginHostManager::spawnPluginHost):
540         (WebKit::NetscapePluginHostManager::initializeVendorPort):
541         (WebKit::NetscapePluginHostManager::instantiatePlugin):
542         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
543           warnings.
544         * Plugins/Hosted/NetscapePluginHostProxy.mm:
545         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
546         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
547           to fix warning.
548         * Plugins/Hosted/ProxyInstance.mm:
549         (WebKit::ProxyInstance::invoke):
550         - Use static_cast<char*>(const_cast<void*>()) to fix
551           warning when using -[NSData bytes].
552         (WebKit::ProxyInstance::fieldValue const):
553         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
554           to fix warning when using CFDataGetBytePtr().
555         * Plugins/Hosted/WebTextInputWindowController.m:
556         (-[WebTextInputPanel _interpretKeyEvent:string:]):
557         - Use #pragma to ignore -Wcast-qual warning since there
558           is not a good way to avoid this warning in Objective-C.
559         * Plugins/WebNetscapePluginStream.mm:
560         (WebNetscapePluginStream::deliverData):
561         - Use const_cast<void*>() to fix warning when using
562           -[NSData bytes].
563         * Plugins/WebNetscapePluginView.mm:
564         (-[WebNetscapePluginView _createPlugin]):
565         - Change C-style cast to const_cast<char*>() to fix
566           warning.
567         * WebCoreSupport/WebChromeClient.mm:
568         (WebChromeClient::wrapCryptoKey const):
569         (WebChromeClient::unwrapCryptoKey const):
570         - Change C-style cast to
571           static_cast<uint8_t*>(const_cast<void*>() to fix
572           warning.
573         * WebView/WebPDFView.mm:
574         (_applicationInfoForMIMEType):
575         - Change local variable type from 'NSURL *' to
576           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
577           when calling -[NSURL path].
578
579 2018-01-05  Dan Bernstein  <mitz@apple.com>
580
581         Fixed the build following AppKit API deprecations in a recent SDKs
582
583         * WebView/WebFullScreenController.mm:
584         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
585         (-[WebFullScreenController exitFullScreen]): Ditto.
586         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
587         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
588         * WebView/WebHTMLView.mm:
589         (-[WebHTMLView drawRect:]): Ditto.
590         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
591         (-[WebHTMLView knowsPageRange:]): Ditto.
592         * WebView/WebView.mm:
593         (LayerFlushController::flushLayers): Ditto.
594
595 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
596
597         [Attachment Support] Create attachment elements when dropping files on iOS
598         https://bugs.webkit.org/show_bug.cgi?id=181192
599         <rdar://problem/36280945>
600
601         Reviewed by Tim Horton.
602
603         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
604
605         * WebCoreSupport/WebPlatformStrategies.h:
606         * WebCoreSupport/WebPlatformStrategies.mm:
607         (WebPlatformStrategies::informationForItemAtIndex):
608         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
609
610 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
611
612         [Attachment Support] Add plumbing for starting a drag with promised blob data
613         https://bugs.webkit.org/show_bug.cgi?id=181201
614
615         Reviewed by Tim Horton.
616
617         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
618
619         * WebCoreSupport/WebDragClient.h:
620
621 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
622
623         Add a WebAuthentication runtime feature flag
624         https://bugs.webkit.org/show_bug.cgi?id=181220
625         <rdar://problem/36055305>
626
627         Reviewed by Brent Fulgham.
628
629         Renames the CredentialManagement runtime feature flag into WebAuthentication.
630
631         * WebView/WebPreferenceKeysPrivate.h:
632         * WebView/WebPreferences.mm:
633         (+[WebPreferences initialize]):
634         (-[WebPreferences webAuthenticationEnabled]):
635         (-[WebPreferences setWebAuthenticationEnabled:]):
636         (-[WebPreferences credentialManagementEnabled]): Deleted.
637         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
638         * WebView/WebPreferencesPrivate.h:
639         * WebView/WebView.mm:
640         (-[WebView _preferencesChanged:]):
641
642 2017-12-22  Jeff Miller  <jeffm@apple.com>
643
644         Update user-visible copyright strings to include 2018
645         https://bugs.webkit.org/show_bug.cgi?id=181141
646
647         Reviewed by Dan Bernstein.
648
649         * Info.plist:
650
651 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
652
653         [Attachment Support] Remove current macOS support for dragging file-backed attachments
654         https://bugs.webkit.org/show_bug.cgi?id=181188
655
656         Reviewed by Dan Bernstein.
657
658         See WebCore/ChangeLog for more detail.
659
660         * WebCoreSupport/WebDragClient.h:
661         * WebCoreSupport/WebDragClient.mm:
662         (WebDragClient::declareAndWriteAttachment): Deleted.
663         * WebView/WebHTMLView.mm:
664         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
665
666 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
667
668         Unreviewed, continue to fix build failures due to AppKit API deprecation
669
670         Wraps more code in -Wdeprecated-declarations.
671
672         * Carbon/HIWebView.mm:
673         (overrideCGContext):
674
675 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
676
677         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
678
679         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
680
681         * Carbon/CarbonWindowAdapter.mm:
682         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
683         * Plugins/WebNetscapePluginView.mm:
684         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
685         (-[WebNetscapePluginView sendDrawRectEvent:]):
686         (-[WebNetscapePluginView drawRect:]):
687
688 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
689
690         Fix build failures due to using deprecated AppKit symbols
691         https://bugs.webkit.org/show_bug.cgi?id=181110
692         <rdar://problem/36162865>
693
694         Reviewed by Dan Bernstein and Tim Horton.
695
696         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
697
698         * Misc/WebKitNSStringExtras.mm:
699         (-[NSString _web_drawAtPoint:font:textColor:]):
700         * Misc/WebNSPasteboardExtras.h:
701         * Misc/WebNSPasteboardExtras.mm:
702         (+[NSPasteboard _web_writableTypesForURL]):
703         (_createWritableTypesForImageWithoutArchive):
704         (_createWritableTypesForImageWithArchive):
705         (+[NSPasteboard _web_dragTypesForURL]):
706         (-[NSPasteboard _web_bestURL]):
707         (-[NSPasteboard _web_writeURL:andTitle:types:]):
708         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
709         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
710         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
711         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
712         * Panels/WebAuthenticationPanel.m:
713         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
714         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
715         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
716         (-[WebHostedNetscapePluginView drawRect:]):
717         * WebInspector/WebNodeHighlightView.mm:
718         (-[WebNodeHighlightView drawRect:]):
719         * WebView/WebFrame.mm:
720         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
721         (-[WebFrame _drawRect:contentsOnly:]):
722         * WebView/WebHTMLView.mm:
723         (kit):
724         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
725         (-[WebHTMLView _plainTextFromPasteboard:]):
726         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
727         (+[WebHTMLView _insertablePasteboardTypes]):
728         (+[WebHTMLView _selectionPasteboardTypes]):
729         (-[WebHTMLView pasteboard:provideDataForType:]):
730         (-[WebHTMLView _writeSelectionToPasteboard:]):
731         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
732         (-[WebHTMLView validRequestorForSendType:returnType:]):
733         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
734         (createMenuItem):
735         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
736         (-[WebHTMLView _colorAsString:]):
737         (-[WebHTMLView copyFont:]):
738         * WebView/WebPDFView.mm:
739         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
740         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
741         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
742         (-[WebPDFView pasteboardTypesForSelection]):
743         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
744         * WebView/WebView.h:
745         * WebView/WebView.mm:
746         (-[WebView performDragOperation:]):
747         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
748         (-[WebView _searchWithGoogleFromMenu:]):
749
750 2017-12-21  Youenn Fablet  <youenn@apple.com>
751
752         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
753         https://bugs.webkit.org/show_bug.cgi?id=181000
754
755         Reviewed by Chris Dumez.
756
757         * Misc/WebCache.mm:
758         (+[WebCache addImageToCache:forURL:forFrame:]):
759
760 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
761
762         Update FULLSCREEN_API feature defines.
763         https://bugs.webkit.org/show_bug.cgi?id=181015
764
765         Reviewed by Tim Horton.
766
767         Change enabled iphone sdk for FULLSCREEN_API.
768
769         * Configurations/FeatureDefines.xcconfig:
770
771 2017-12-21  Jer Noble  <jer.noble@apple.com>
772
773         Add initial DOM support for Media Capabilities
774         https://bugs.webkit.org/show_bug.cgi?id=181064
775
776         Reviewed by Eric Carlson.
777
778         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
779
780         * WebView/WebPreferenceKeysPrivate.h:
781         * WebView/WebPreferences.mm:
782         (+[WebPreferences initialize]):
783         (-[WebPreferences mediaCapabilitiesEnabled]):
784         (-[WebPreferences setMediaCapabilitiesEnabled:]):
785         * WebView/WebPreferencesPrivate.h:
786         * WebView/WebView.mm:
787         (-[WebView _preferencesChanged:]):
788
789 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
790
791         Enable picture-in-picture from inline element on suspend.
792         https://bugs.webkit.org/show_bug.cgi?id=180942
793         rdar://problem/34745234
794
795         Reviewed by Jer Noble.
796
797         Update signature of enterVideoFullscreenForVideoElement().
798
799         * WebCoreSupport/WebChromeClient.h:
800         * WebCoreSupport/WebChromeClient.mm:
801         (WebChromeClient::enterVideoFullscreenForVideoElement):
802
803 2017-12-20  Daniel Bates  <dabates@apple.com>
804
805         Remove Alternative Presentation Button
806         https://bugs.webkit.org/show_bug.cgi?id=180500
807         <rdar://problem/35891047>
808
809         Reviewed by Simon Fraser.
810
811         We no longer need the alternative presentation button.
812
813         * Configurations/FeatureDefines.xcconfig:
814
815 2017-12-19  Jer Noble  <jer.noble@apple.com>
816
817         Playing media elements which call "pause(); play()" will have the play promise rejected.
818         https://bugs.webkit.org/show_bug.cgi?id=180781
819         <rdar://problem/33191377>
820
821         Reviewed by Eric Carlson.
822
823         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
824
825         * WebView/WebView.mm:
826         (shouldRequireUserGestureToLoadVideo):
827
828 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
829
830         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
831         https://bugs.webkit.org/show_bug.cgi?id=180977
832
833         Reviewed by Tim Horton.
834
835         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
836         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
837         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
838
839         * WebCoreSupport/WebEditorClient.mm:
840         (attributesForAttributedStringConversion):
841         * WebView/WebHTMLView.mm:
842         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
843
844 2017-12-18  David Kilzer  <ddkilzer@apple.com>
845
846         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
847
848         Attempt to fix the following warnings:
849
850             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
851
852         For the following instance variables:
853
854             _borderView
855             _contentView
856             _frame
857             _wFlags
858
859         * Carbon/CarbonWindowAdapter.mm:
860         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
861         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
862         (-[CarbonWindowAdapter _termWindowIfOwner]):
863         (-[CarbonWindowAdapter _windowMovedToRect:]):
864         (-[CarbonWindowAdapter setContentView:]):
865         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
866         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
867
868 2017-12-16  Dan Bernstein  <mitz@apple.com>
869
870         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
871         https://bugs.webkit.org/show_bug.cgi?id=180613
872         <rdar://problem/35946124>
873
874         Reviewed by Geoff Garen.
875
876         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
877           clients.
878         * WebView/WebDynamicScrollBarsView.h: Ditto.
879         * WebView/WebDynamicScrollBarsView.mm: Ditto.
880
881 2017-12-14  David Kilzer  <ddkilzer@apple.com>
882
883         Enable -Wstrict-prototypes for WebKit
884         <https://webkit.org/b/180757>
885         <rdar://problem/36024132>
886
887         Rubber-stamped by Joseph Pecoraro.
888
889         * Configurations/Base.xcconfig:
890         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
891
892 2017-12-14  John Wilander  <wilander@apple.com>
893
894         Storage Access API: Implement frame-specific access in the document.cookie layer
895         https://bugs.webkit.org/show_bug.cgi?id=180682
896         <rdar://problem/35982257>
897
898         Reviewed by Alex Christensen.
899
900         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
901         CookiesStrategy::cookieRequestHeaderFieldValue(), and
902         CookiesStrategy::getRawCookies() now take optional parameters for
903         frameID and pageID to allow frame-specific scoping of cookies.
904
905         This change makes the return values of FrameLoaderClient::frameID()
906         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
907         WebCore can call those getters and get the right return values in
908         WebKit and std:nullopt in WebKitLegacy.
909
910         * WebCoreSupport/WebFrameLoaderClient.h:
911         * WebCoreSupport/WebFrameLoaderClient.mm:
912         (WebFrameLoaderClient::pageID const):
913         (WebFrameLoaderClient::frameID const):
914         * WebCoreSupport/WebPlatformStrategies.h:
915         * WebCoreSupport/WebPlatformStrategies.mm:
916         (WebPlatformStrategies::cookiesForDOM):
917         (WebPlatformStrategies::setCookiesFromDOM):
918         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
919         (WebPlatformStrategies::getRawCookies):
920
921 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
922
923         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
924         https://bugs.webkit.org/show_bug.cgi?id=180689
925
926         Reviewed by Tim Horton.
927
928         Use sRGBColorSpaceRef() from WebCore.
929
930         * WebView/WebHTMLView.mm:
931         (imageFromRect):
932
933 2017-12-11  Tim Horton  <timothy_horton@apple.com>
934
935         Stop using deprecated target conditional for simulator builds
936         https://bugs.webkit.org/show_bug.cgi?id=180662
937         <rdar://problem/35136156>
938
939         Reviewed by Simon Fraser.
940
941         * postprocess-headers.sh:
942
943 2017-12-11  David Quesada  <david_quesada@apple.com>
944
945         Turn on ENABLE_APPLICATION_MANIFEST
946         https://bugs.webkit.org/show_bug.cgi?id=180562
947         rdar://problem/35924737
948
949         Reviewed by Geoffrey Garen.
950
951         * Configurations/FeatureDefines.xcconfig:
952
953 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
954
955         Remove pthread_once in favor of dispatch_once
956         https://bugs.webkit.org/show_bug.cgi?id=180591
957
958         Reviewed by Saam Barati.
959
960         * Misc/WebKitErrors.m:
961         (+[NSError _registerWebKitErrors]):
962         (registerErrors): Deleted.
963         * Storage/WebStorageManager.mm:
964         (+[WebStorageManager _storageDirectoryPath]):
965         (initializeLocalStoragePath): Deleted.
966
967 2017-12-07  Darin Adler  <darin@apple.com>
968
969         Remove some unused code from WebKitLegacy
970         https://bugs.webkit.org/show_bug.cgi?id=180567
971
972         Reviewed by Anders Carlsson.
973
974         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
975         macOS (back a few versions) and iOS and removed unused
976         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
977         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
978         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
979         _webkit_stringByCollapsingNonPrintingCharacters,
980         _webkit_stringByCollapsingWhitespaceCharacters,
981         _web_stringWithData:textEncodingName:, and
982         _webkit_localStorageDirectoryWithBundleIdentifier:.
983
984         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
985         this source file.
986         (canUseFastRenderer): Made this faster by not calling u_charDirection for
987         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
988         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
989         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
990         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
991         handle font smoothing options.
992         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
993         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
994         from header and made it a little clearer.
995         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
996         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
997         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
998         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
999         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1000         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1001         implementation a bit and used whole words instead of abbreviations.
1002         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1003
1004         * Misc/WebNSFileManagerExtras.mm:
1005         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1006         filenameByFixingIllegalCharacters function from WebCore directly instead of
1007         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1008
1009         * Plugins/WebBaseNetscapePluginView.mm:
1010         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1011         string replacements instead of _web_stringByStrippingReturnCharacters
1012         and to use NSString methods instead of CFString functions.
1013
1014 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1015
1016         Ignore deprecation warnings.
1017
1018         * WebView/WebHTMLView.mm:
1019         (-[NSWindow _web_borderView]):
1020         (-[WebHTMLView _setAsideSubviews]):
1021         * WebView/WebView.mm:
1022         (-[WebView encodeWithCoder:]):
1023
1024 2017-12-02  Darin Adler  <darin@apple.com>
1025
1026         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1027         https://bugs.webkit.org/show_bug.cgi?id=180009
1028
1029         Reviewed by Alex Christensen.
1030
1031         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1032
1033         * Plugins/WebBaseNetscapePluginView.mm:
1034         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1035         of strcasecmp.
1036
1037         * WebView/WebPreferences.mm:
1038         (contains): Ditto. Also made this a template so it's easier to call on an array.
1039         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1040
1041 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1042
1043         Limit user agent versioning to an upper bound
1044         https://bugs.webkit.org/show_bug.cgi?id=180365
1045         <rdar://problem/34550617>
1046
1047         Reviewed by Joseph Pecoraro.
1048
1049         * WebView/WebView.mm:
1050         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1051         creating the User Agent string.
1052         (webKitBundleVersionString): Deleted.
1053
1054 2017-12-05  Andy Estes  <aestes@apple.com>
1055
1056         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1057         https://bugs.webkit.org/show_bug.cgi?id=180457
1058         <rdar://problem/35143007>
1059
1060         Reviewed by Tim Horton.
1061
1062         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1063         check for this macro during post-processing.
1064
1065         * postprocess-headers.sh:
1066
1067 2017-12-04  David Quesada  <david_quesada@apple.com>
1068
1069         Add a class for parsing application manifests
1070         https://bugs.webkit.org/show_bug.cgi?id=177973
1071         rdar://problem/34747949
1072
1073         Reviewed by Geoffrey Garen.
1074
1075         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1076
1077 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1078
1079         Make LegacyCustomProtocolManager optional for network process
1080         https://bugs.webkit.org/show_bug.cgi?id=176230
1081
1082         Reviewed by Alex Christensen.
1083
1084         * Configurations/FeatureDefines.xcconfig:
1085
1086 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1087
1088         Fix some NSOperationQueue leaks
1089         https://bugs.webkit.org/show_bug.cgi?id=180221
1090
1091         Reviewed by Wenson Hsieh.
1092
1093         * WebView/WebView.mm:
1094         (-[WebView performDragOperation:]):
1095
1096 2017-11-30  Darin Adler  <darin@apple.com>
1097
1098         [Mac] remove unneeded RetainPtr use introduced in r225142
1099         https://bugs.webkit.org/show_bug.cgi?id=180202
1100
1101         Reviewed by Tim Horton.
1102
1103         * WebView/WebImmediateActionController.mm:
1104         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1105         RetainPtr.
1106
1107 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1108
1109         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1110         https://bugs.webkit.org/show_bug.cgi?id=175595
1111
1112         Reviewed by Darin Adler.
1113
1114         * WebView/WebPreferences.mm:
1115
1116 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1117
1118         One too many zeroes in macOS version number in FeatureDefines
1119         https://bugs.webkit.org/show_bug.cgi?id=180011
1120
1121         Reviewed by Dan Bernstein.
1122
1123         * Configurations/FeatureDefines.xcconfig:
1124
1125 2017-11-23  Darin Adler  <darin@apple.com>
1126
1127         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1128         https://bugs.webkit.org/show_bug.cgi?id=179981
1129
1130         Reviewed by Sam Weinig.
1131
1132         * WebView/WebImmediateActionController.mm:
1133         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1134         * WebView/WebView.mm:
1135         (coreOptions): Use |= instead of | to build up FindOptions.
1136
1137 2017-11-23  Sam Weinig  <sam@webkit.org>
1138
1139         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1140         https://bugs.webkit.org/show_bug.cgi?id=179954
1141
1142         Reviewed by Darin Adler.
1143
1144         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1145         with direct calls to the corresponding UserGestureIndicator functions.
1146
1147         * Plugins/WebPluginController.mm:
1148         (-[WebPluginController processingUserGesture]):
1149         * WebView/WebView.mm:
1150         (-[WebView _isProcessingUserGesture]):
1151
1152 2017-11-23  Darin Adler  <darin@apple.com>
1153
1154         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1155         https://bugs.webkit.org/show_bug.cgi?id=179907
1156
1157         Reviewed by Sam Weinig.
1158
1159         * History/BinaryPropertyList.cpp:
1160         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1161         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1162         * WebView/WebHTMLRepresentation.mm:
1163         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1164         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1165
1166 2017-11-22  Ali Juma  <ajuma@chromium.org>
1167
1168         Implement VisualViewport API attributes
1169         https://bugs.webkit.org/show_bug.cgi?id=179385
1170
1171         Reviewed by Frédéric Wang.
1172
1173         Add a VisualViewportAPI preference.
1174
1175         * WebView/WebPreferenceKeysPrivate.h:
1176         * WebView/WebPreferences.mm:
1177         (+[WebPreferences initialize]):
1178         (-[WebPreferences visualViewportAPIEnabled]):
1179         (-[WebPreferences setVisualViewportAPIEnabled:]):
1180         * WebView/WebPreferencesPrivate.h:
1181         * WebView/WebView.mm:
1182         (-[WebView _preferencesChanged:]):
1183
1184 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1185
1186         WebCoreObjCExtras.h is being included in too many places
1187         https://bugs.webkit.org/show_bug.cgi?id=179931
1188
1189         Reviewed by Darin Adler.
1190
1191         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1192         * Plugins/WebBaseNetscapePluginView.mm:
1193         * Plugins/WebBasePluginPackage.mm:
1194         * Plugins/WebNetscapePluginStream.mm:
1195         * Plugins/WebNetscapePluginView.mm:
1196         * WebView/WebTextIterator.mm:
1197         * WebView/WebViewData.mm:
1198
1199 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1200
1201         Unreviewed, rolling out r225093.
1202         https://bugs.webkit.org/show_bug.cgi?id=179938
1203
1204         Compilation failed on WinCairo 64-bit Release (Requested by
1205         fredw on #webkit).
1206
1207         Reverted changeset:
1208
1209         "Implement VisualViewport API attributes"
1210         https://bugs.webkit.org/show_bug.cgi?id=179385
1211         https://trac.webkit.org/changeset/225093
1212
1213 2017-11-21  Ali Juma  <ajuma@chromium.org>
1214
1215         Implement VisualViewport API attributes
1216         https://bugs.webkit.org/show_bug.cgi?id=179385
1217
1218         Reviewed by Frédéric Wang.
1219
1220         Add a VisualViewportAPI preference.
1221
1222         * WebView/WebPreferenceKeysPrivate.h:
1223         * WebView/WebPreferences.mm:
1224         (+[WebPreferences initialize]):
1225         (-[WebPreferences visualViewportAPIEnabled]):
1226         (-[WebPreferences setVisualViewportAPIEnabled:]):
1227         * WebView/WebPreferencesPrivate.h:
1228         * WebView/WebView.mm:
1229         (-[WebView _preferencesChanged:]):
1230
1231 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1232
1233         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1234         https://bugs.webkit.org/show_bug.cgi?id=179504
1235
1236         Reviewed by Darin Adler.
1237
1238         * Misc/WebKitNSStringExtras.mm:
1239         * Plugins/Hosted/NetscapePluginHostManager.mm:
1240         * Plugins/WebBasePluginPackage.mm:
1241
1242 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1243
1244         Remove unused TOUCH_ICON_LOADING feature flag
1245         https://bugs.webkit.org/show_bug.cgi?id=179873
1246
1247         Reviewed by Simon Fraser.
1248
1249         * Configurations/FeatureDefines.xcconfig:
1250
1251 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1252
1253         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1254         https://bugs.webkit.org/show_bug.cgi?id=179872
1255
1256         Reviewed by Darin Adler.
1257
1258         * Configurations/FeatureDefines.xcconfig:
1259
1260 2017-11-16  Daniel Bates  <dabates@apple.com>
1261
1262         Add feature define for alternative presentation button element
1263         https://bugs.webkit.org/show_bug.cgi?id=179692
1264         Part of <rdar://problem/34917108>
1265
1266         Reviewed by Andy Estes.
1267
1268         Only enabled on Cocoa platforms by default.
1269
1270         * Configurations/FeatureDefines.xcconfig:
1271
1272 2017-11-14  Nan Wang  <n_wang@apple.com>
1273
1274         AX: AOM: Implement AccessibleNode class and support label and role attributes
1275         https://bugs.webkit.org/show_bug.cgi?id=179494
1276
1277         Reviewed by Ryosuke Niwa.
1278
1279         * WebView/WebPreferenceKeysPrivate.h:
1280         * WebView/WebPreferences.mm:
1281         (+[WebPreferences initialize]):
1282         (-[WebPreferences accessibilityObjectModelEnabled]):
1283         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1284         * WebView/WebPreferencesPrivate.h:
1285         * WebView/WebView.mm:
1286         (-[WebView _preferencesChanged:]):
1287
1288 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1289
1290         Remove Cocoa CFURLConnection loading code
1291         https://bugs.webkit.org/show_bug.cgi?id=179688
1292
1293         Reviewed by Antti Koivisto.
1294
1295         * Misc/WebDownload.mm:
1296         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1297         * Misc/WebDownloadInternal.h:
1298         * Plugins/WebBaseNetscapePluginView.mm:
1299         * WebCoreSupport/WebFrameLoaderClient.mm:
1300         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1301         * WebView/WebView.mm:
1302         (-[WebView scheduleInRunLoop:forMode:]):
1303         (-[WebView unscheduleFromRunLoop:forMode:]):
1304
1305 2017-11-14  Daniel Bates  <dabates@apple.com>
1306
1307         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1308         for feature defines
1309
1310         Following r195498 and r201917 the Visual Studio property files for feature defines have
1311         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1312         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1313         files.
1314
1315         * Configurations/FeatureDefines.xcconfig:
1316
1317 2017-11-14  Jer Noble  <jer.noble@apple.com>
1318
1319         Enable Modern EME tests in DumpRenderTree
1320         https://bugs.webkit.org/show_bug.cgi?id=179544
1321
1322         Reviewed by Alex Christensen.
1323
1324         Add a WebPreferences property to enable the (modern) EME API.
1325
1326         * WebView/WebPreferenceKeysPrivate.h:
1327         * WebView/WebPreferences.mm:
1328         (+[WebPreferences initialize]):
1329         (-[WebPreferences encryptedMediaAPIEnabled]):
1330         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1331         * WebView/WebPreferencesPrivate.h:
1332         * WebView/WebView.mm:
1333         (-[WebView _preferencesChanged:]):
1334
1335 2017-11-14  Antti Koivisto  <antti@apple.com>
1336
1337         Enable display:contents by default
1338         https://bugs.webkit.org/show_bug.cgi?id=179655
1339
1340         Reviewed by Sam Weinig.
1341
1342         * WebView/WebPreferences.mm:
1343         (+[WebPreferences initialize]):
1344
1345 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1346
1347         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1348         https://bugs.webkit.org/show_bug.cgi?id=178751
1349
1350         Reviewed by Brady Eidson.
1351
1352         * WebCoreSupport/WebFrameNetworkingContext.mm:
1353         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1354
1355 2017-11-08  Keith Miller  <keith_miller@apple.com>
1356
1357         Async iteration should only fetch the next method once and add feature flag
1358         https://bugs.webkit.org/show_bug.cgi?id=179451
1359
1360         Reviewed by Geoffrey Garen.
1361
1362         Add feature flag for Async iteration.
1363
1364         * Configurations/FeatureDefines.xcconfig:
1365
1366 2017-11-13  Mark Lam  <mark.lam@apple.com>
1367
1368         Add more overflow check book-keeping for MarkedArgumentBuffer.
1369         https://bugs.webkit.org/show_bug.cgi?id=179634
1370         <rdar://problem/35492517>
1371
1372         Reviewed by Saam Barati.
1373
1374         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1375         (WebKit::NetscapePluginInstanceProxy::invoke):
1376         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1377         (WebKit::NetscapePluginInstanceProxy::construct):
1378
1379 2017-11-12  Darin Adler  <darin@apple.com>
1380
1381         More is<> and downcast<>, less static_cast<>
1382         https://bugs.webkit.org/show_bug.cgi?id=179600
1383
1384         Reviewed by Chris Dumez.
1385
1386         * DOM/DOM.mm:
1387         (kit): Use is/downcast.
1388         * WebCoreSupport/WebEditorClient.mm:
1389         (WebEditorClient::handleKeyboardEvent): Ditto.
1390         (WebEditorClient::handleInputMethodKeydown): Ditto.
1391         * WebView/WebHTMLView.mm:
1392         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1393
1394 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1395
1396         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1397         https://bugs.webkit.org/show_bug.cgi?id=179397
1398
1399         Reviewed by Wenson Hsieh.
1400
1401         * DOM/DOMHTMLInputElement.mm:
1402         (-[DOMHTMLInputElement insertTextSuggestion:]):
1403
1404 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1405
1406         HTMLMediaElement should not use element fullscreen on iOS
1407         https://bugs.webkit.org/show_bug.cgi?id=179418
1408         rdar://problem/35409277
1409
1410         Reviewed by Eric Carlson.
1411
1412         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1413
1414         * Configurations/FeatureDefines.xcconfig:
1415
1416 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1417
1418         Make ResourceLoader::willSendRequestInternal asynchronous
1419         https://bugs.webkit.org/show_bug.cgi?id=179251
1420
1421         Reviewed by Andy Estes.
1422
1423         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1424         (WebKit::HostedNetscapePluginStream::start):
1425         * Plugins/WebNetscapePluginStream.mm:
1426         (WebNetscapePluginStream::start):
1427
1428 2017-11-01  Darin Adler  <darin@apple.com>
1429
1430         Simplify event dispatch code and make it a bit more consistent
1431         https://bugs.webkit.org/show_bug.cgi?id=178991
1432
1433         Reviewed by Chris Dumez.
1434
1435         * DOM/DOMEvent.mm:
1436         (-[DOMEvent srcElement]): Call target instead of srcElement.
1437
1438 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1439
1440         [Touch Bar Web API] Add support for menuitem tag
1441         https://bugs.webkit.org/show_bug.cgi?id=179020
1442
1443         Reviewed by Ryosuke Niwa.
1444
1445         Adds in properties and methods that allow the menuitem runtime feature
1446         to be enabled or disabled.
1447
1448         * WebView/WebPreferenceKeysPrivate.h:
1449         * WebView/WebPreferences.mm:
1450         (-[WebPreferences menuItemElementEnabled]):
1451         (-[WebPreferences setMenuItemElementEnabled:]):
1452         * WebView/WebPreferencesPrivate.h:
1453         * WebView/WebView.mm:
1454         (-[WebView _preferencesChanged:]):
1455
1456 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1457
1458         Use CompletionHandlers for redirects
1459         https://bugs.webkit.org/show_bug.cgi?id=179163
1460
1461         Reviewed by Tim Horton.
1462
1463         * Plugins/Hosted/HostedNetscapePluginStream.h:
1464         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1465         (WebKit::HostedNetscapePluginStream::willSendRequest):
1466         * Plugins/WebNetscapePluginStream.h:
1467         * Plugins/WebNetscapePluginStream.mm:
1468         (WebNetscapePluginStream::willSendRequest):
1469
1470 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1471
1472         Add a FileSystem namespace to FileSystem.cpp
1473         https://bugs.webkit.org/show_bug.cgi?id=179063
1474
1475         Reviewed by Darin Adler.
1476
1477         * Misc/WebNSFileManagerExtras.mm:
1478         * Storage/WebDatabaseProvider.mm:
1479
1480 2017-11-02  Frederic Wang  <fwang@igalia.com>
1481
1482         Add references to bug 179167 in FIXME comments
1483         https://bugs.webkit.org/show_bug.cgi?id=179168
1484
1485         Reviewed by Daniel Bates.
1486
1487         * Configurations/FeatureDefines.xcconfig:
1488
1489 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1490
1491         Implement WKFullscreenWindowController for iOS.
1492         https://bugs.webkit.org/show_bug.cgi?id=178924
1493         rdar://problem/34697120
1494
1495         Reviewed by Simon Fraser.
1496
1497         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1498
1499         * Configurations/FeatureDefines.xcconfig:
1500         * WebView/WebView.mm:
1501         (-[WebView fullScreenPlaceholderView]):
1502
1503 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1504
1505         Clean up some drag and drop feature flags
1506         https://bugs.webkit.org/show_bug.cgi?id=179082
1507
1508         Reviewed by Simon Fraser.
1509
1510         * Configurations/FeatureDefines.xcconfig:
1511
1512 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1513
1514         Make it possible to test rubber-banding in overflow scroll
1515         https://bugs.webkit.org/show_bug.cgi?id=179078
1516
1517         Reviewed by Sam Weinig.
1518
1519         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1520         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1521
1522         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1523         functions, since most callers want clamped.
1524
1525         * DOM/DOMHTML.mm:
1526         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1527
1528 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1529
1530         Fix up some content filtering feature flags
1531         https://bugs.webkit.org/show_bug.cgi?id=179079
1532
1533         Reviewed by Simon Fraser.
1534
1535         * Configurations/FeatureDefines.xcconfig:
1536
1537 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1538
1539         [FrameView::layout cleanup] Move core layout logic to a separate class.
1540         https://bugs.webkit.org/show_bug.cgi?id=178771
1541         <rdar://problem/35166542>
1542
1543         Reviewed by Simon Fraser.
1544
1545         Move layout code out from FrameView to LayoutContext.
1546
1547         * WebView/WebClipView.mm:
1548         (-[WebClipView _immediateScrollToPoint:]):
1549         * WebView/WebFrame.mm:
1550         (-[WebFrame layoutCount]):
1551
1552 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1553
1554         Fix issues with WebView subframe painting
1555         https://bugs.webkit.org/show_bug.cgi?id=178842
1556         rdar://problem/34072253
1557
1558         Reviewed by Daniel Bates.
1559         
1560         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1561         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1562         High Sierra, so match the new signature.
1563
1564         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1565
1566         * WebView/WebHTMLView.mm:
1567         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1568         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1569
1570 2017-10-25  Youenn Fablet  <youenn@apple.com>
1571
1572         Enable ServiceWorker to fetch resources
1573         https://bugs.webkit.org/show_bug.cgi?id=178673
1574
1575         Reviewed by Brady Eidson.
1576
1577         * WebCoreSupport/WebFrameLoaderClient.mm:
1578         (WebFrameLoaderClient::pageID const):
1579         (WebFrameLoaderClient::frameID const):
1580         (WebFrameLoaderClient::sessionID const):
1581
1582         Added implementation to the new getters.
1583         They are noop in the context of WK1.
1584
1585 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1586
1587         Web Inspector: Enable WebKit logging configuration and display
1588         https://bugs.webkit.org/show_bug.cgi?id=177027
1589         <rdar://problem/33964767>
1590
1591         Reviewed by Joseph Pecoraro.
1592
1593         * WebCoreSupport/WebChromeClient.mm:
1594         (stringForMessageSource): Deal with Media and WebRTC message sources.
1595
1596 2017-10-20  Antoine Quint  <graouts@apple.com>
1597
1598         [Web Animations] Provide basic timeline and animation interfaces
1599         https://bugs.webkit.org/show_bug.cgi?id=178526
1600
1601         Reviewed by Dean Jackson.
1602
1603         Remove the WEB_ANIMATIONS compile-time flag.
1604
1605         * Configurations/FeatureDefines.xcconfig:
1606         * WebView/WebPreferences.mm:
1607         (+[WebPreferences initialize]):
1608         * WebView/WebView.mm:
1609         (-[WebView _preferencesChanged:]):
1610
1611 2017-10-19  Sam Weinig  <sam@webkit.org>
1612
1613         [Settings] Move global settings into their own file
1614         https://bugs.webkit.org/show_bug.cgi?id=178512
1615
1616         Reviewed by Darin Adler.
1617
1618         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1619
1620         * WebCoreSupport/WebChromeClient.mm:
1621         (WebChromeClient::supportsVideoFullscreen):
1622         * WebView/WebDynamicScrollBarsView.mm:
1623         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1624         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1625         * WebView/WebPreferences.mm:
1626         (+[WebPreferences initialize]):
1627         * WebView/WebView.mm:
1628         (-[WebView _commonInitializationWithFrameName:groupName:]):
1629         (-[WebView _preferencesChanged:]):
1630         (+[WebView _doNotStartObservingNetworkReachability]):
1631
1632 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1633
1634         Replace some stack raw pointers with RefPtrs within WebCore/html
1635         https://bugs.webkit.org/show_bug.cgi?id=178201
1636         <rdar://problem/34841692>
1637
1638         Reviewed by Ryosuke Niwa.
1639
1640         * DOM/DOM.mm:
1641         (kit):
1642         Change the type of node as toNode() is changed to return RefPtr.
1643
1644 2017-10-18  Chris Dumez  <cdumez@apple.com>
1645
1646         [Service Worker] Add stubs for Client / WindowClient / Clients
1647         https://bugs.webkit.org/show_bug.cgi?id=178469
1648
1649         Reviewed by Youenn Fablet.
1650
1651         Rename PageVisiblityState to VisibilityState.
1652
1653         * WebView/WebView.mm:
1654         (kit):
1655
1656 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1657
1658         Unreviewed, rolling out r223291.
1659
1660         See WebCore ChangeLog for more detail.
1661
1662         Reverted changeset:
1663
1664         "Remove Editor::simplifyMarkup"
1665         https://bugs.webkit.org/show_bug.cgi?id=178271
1666         https://trac.webkit.org/changeset/223291
1667
1668 2017-10-17  Keith Miller  <keith_miller@apple.com>
1669
1670         Change WebCore sources to work with unified source builds
1671         https://bugs.webkit.org/show_bug.cgi?id=178229
1672
1673         Rubber stamped by Tim Horton.
1674
1675         * Configurations/FeatureDefines.xcconfig:
1676
1677 2017-10-16  Sam Weinig  <sam@webkit.org>
1678
1679         [Settings] Remove all custom code from Settings.h/cpp
1680         https://bugs.webkit.org/show_bug.cgi?id=178330
1681
1682         Reviewed by Simon Fraser.
1683
1684         * WebView/WebPreferences.mm:
1685         (+[WebPreferences initialize]):
1686         
1687             Update for naming changes of FrameFlattening now that it is an enum class.
1688
1689 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1690
1691         Remove Editor::simplifyMarkup
1692         https://bugs.webkit.org/show_bug.cgi?id=178271
1693
1694         Reviewed by Wenson Hsieh.
1695
1696         * WebView/WebView.mm:
1697         (-[WebView _simplifyMarkup:endNode:]):
1698
1699 2017-10-12  Chris Dumez  <cdumez@apple.com>
1700
1701         [Mac] Add support for MouseEvent.buttons
1702         https://bugs.webkit.org/show_bug.cgi?id=178214
1703
1704         Reviewed by Ryosuke Niwa.
1705
1706         * WebView/WebPDFView.mm:
1707         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1708
1709 2017-10-11  Sam Weinig  <sam@webkit.org>
1710
1711         Remove out-parameter variants of copyToVector
1712         https://bugs.webkit.org/show_bug.cgi?id=178155
1713
1714         Reviewed by Tim Horton.
1715
1716         * Plugins/WebNetscapePluginView.mm:
1717         (-[WebNetscapePluginView destroyPlugin]):
1718         * WebView/WebHTMLRepresentation.mm:
1719         (newArrayWithStrings):
1720
1721             Replace out-parameter based copyToVector, with one that returns a Vector.
1722
1723 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1724
1725         Sanitize URL in pasteboard for other applications and cross origin content
1726         https://bugs.webkit.org/show_bug.cgi?id=178060
1727         <rdar://problem/34874518>
1728
1729         Reviewed by Wenson Hsieh.
1730
1731         * WebCoreSupport/WebPlatformStrategies.h:
1732         * WebCoreSupport/WebPlatformStrategies.mm:
1733         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
1734
1735 2017-10-11  Chris Dumez  <cdumez@apple.com>
1736
1737         Modernize Geolocation code
1738         https://bugs.webkit.org/show_bug.cgi?id=178148
1739
1740         Reviewed by Ryosuke Niwa.
1741
1742         * WebCoreSupport/WebGeolocationClient.h:
1743         * WebCoreSupport/WebGeolocationClient.mm:
1744         (WebGeolocationClient::lastPosition):
1745         * WebView/WebGeolocationPosition.mm:
1746         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1747         (core):
1748         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
1749         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1750         * WebView/WebGeolocationPositionInternal.h:
1751
1752 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1753
1754         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
1755         https://bugs.webkit.org/show_bug.cgi?id=178154
1756
1757         Reviewed by Wenson Hsieh.
1758
1759         Enable custom pasteboard data by default.
1760
1761         * WebView/WebPreferenceKeysPrivate.h:
1762         * WebView/WebPreferences.mm:
1763         (+[WebPreferences initialize]):
1764         (-[WebPreferences customPasteboardDataEnabled]): Added.
1765         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
1766         * WebView/WebPreferencesPrivate.h:
1767         * WebView/WebView.mm:
1768         (-[WebView _preferencesChanged:]):
1769
1770 2017-10-10  Sam Weinig  <sam@webkit.org>
1771
1772         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
1773         https://bugs.webkit.org/show_bug.cgi?id=178102
1774
1775         Reviewed by Tim Horton.
1776
1777         * History/WebHistory.mm:
1778         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1779         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1780         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1781         * WebCoreSupport/WebUserMediaClient.mm:
1782         (WebUserMediaClient::pageDestroyed):
1783
1784 2017-10-09  Robin Morisset  <rmorisset@apple.com>
1785
1786         Make the names of the options consistent
1787         https://bugs.webkit.org/show_bug.cgi?id=177933
1788
1789         Reviewed by Saam Barati.
1790
1791         * WebView/WebFrame.h:
1792         * WebView/WebHTMLView.mm:
1793         (-[WebHTMLView setMarkedText:selectedRange:]):
1794         * WebView/WebView.h:
1795
1796 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1797
1798         [iOS] Tweak support for classifying form controls (followup to r222487)
1799         https://bugs.webkit.org/show_bug.cgi?id=177917
1800         <rdar://problem/34820122>
1801
1802         Reviewed by Dean Jackson.
1803
1804         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
1805
1806         * DOM/DOMHTMLInputElement.mm:
1807         (-[DOMHTMLInputElement _autofillContext]):
1808         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
1809         (-[DOMHTMLInputElement representingPageURL]): Deleted.
1810
1811 2017-10-05  Keith Miller  <keith_miller@apple.com>
1812
1813         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
1814
1815         * Configurations/WebKitLegacy.xcconfig:
1816
1817 2017-10-05  Jer Noble  <jer.noble@apple.com>
1818
1819         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1820         https://bugs.webkit.org/show_bug.cgi?id=177261
1821
1822         Reviewed by Eric Carlson.
1823
1824         * Configurations/FeatureDefines.xcconfig:
1825
1826 2017-10-05  Chris Dumez  <cdumez@apple.com>
1827
1828         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1829         https://bugs.webkit.org/show_bug.cgi?id=177957
1830
1831         Reviewed by Alex Christensen.
1832
1833         * WebCoreSupport/WebPlatformStrategies.h:
1834         * WebCoreSupport/WebPlatformStrategies.mm:
1835         (WebPlatformStrategies::cookiesEnabled):
1836
1837 2017-10-05  Youenn Fablet  <youenn@apple.com>
1838
1839         Make LibWebRTCProvider port agnostic
1840         https://bugs.webkit.org/show_bug.cgi?id=177747
1841
1842         Reviewed by Alex Christensen & Alex Garcia.
1843
1844         * WebView/WebView.mm:
1845         (-[WebView _commonInitializationWithFrameName:groupName:]):
1846         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1847
1848 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1849
1850         Stop linking with WebKitSystemInterface
1851         https://bugs.webkit.org/show_bug.cgi?id=177915
1852
1853         Reviewed by Antti Koivisto.
1854
1855         * Configurations/DebugRelease.xcconfig:
1856         * Configurations/WebKitLegacy.xcconfig:
1857
1858 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1859
1860         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
1861         https://bugs.webkit.org/show_bug.cgi?id=177912
1862
1863         Reviewed by Saam Barati.
1864
1865         * Carbon/CarbonUtils.m:
1866         * Carbon/CarbonWindowAdapter.mm:
1867         * Carbon/HIWebView.mm:
1868         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1869         * Misc/WebNSFileManagerExtras.mm:
1870         * Misc/WebNSPasteboardExtras.mm:
1871         * Misc/WebNSURLExtras.mm:
1872         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1873         * Plugins/Hosted/NetscapePluginHostManager.mm:
1874         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1875         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1876         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1877         * Plugins/Hosted/WebTextInputWindowController.m:
1878         * Plugins/WebBaseNetscapePluginView.mm:
1879         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1880         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1881         * Plugins/WebNetscapePluginStream.mm:
1882         * Plugins/WebNetscapePluginView.mm:
1883         * Plugins/WebPluginDatabase.mm:
1884         * WebCoreSupport/PopupMenuMac.mm:
1885         * WebCoreSupport/WebChromeClient.mm:
1886         * WebCoreSupport/WebFrameLoaderClient.mm:
1887         * WebCoreSupport/WebInspectorClient.mm:
1888         * WebCoreSupport/WebPlatformStrategies.mm:
1889         * WebCoreSupport/WebSystemInterface.mm:
1890         * WebView/WebDynamicScrollBarsView.mm:
1891         * WebView/WebFrame.mm:
1892         * WebView/WebFrameView.mm:
1893         * WebView/WebFullScreenController.mm:
1894         * WebView/WebHTMLView.mm:
1895         * WebView/WebPreferences.mm:
1896         * WebView/WebView.mm:
1897
1898 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
1899
1900         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
1901         rdar://problem/34705779
1902
1903         Addressing review comments that I somehow landed without.
1904
1905         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
1906
1907 2017-09-29  Chris Dumez  <cdumez@apple.com>
1908
1909         Split some logic out of VisitedLinkStore and make it reusable
1910         https://bugs.webkit.org/show_bug.cgi?id=177575
1911
1912         Reviewed by Alex Christensen.
1913
1914         * WebCoreSupport/WebVisitedLinkStore.h:
1915         * WebCoreSupport/WebVisitedLinkStore.mm:
1916         (WebVisitedLinkStore::addVisitedLink):
1917         (WebVisitedLinkStore::removeVisitedLink):
1918         (WebVisitedLinkStore::isLinkVisited):
1919         (WebVisitedLinkStore::addVisitedLinkHash):
1920
1921 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
1922
1923         Build fix for High Sierra 32 bit Mac
1924         https://bugs.webkit.org/show_bug.cgi?id=177551
1925         <rdar://problem/34690283>
1926
1927         Reviewed by Alexey Proskuryakov.
1928
1929         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1930         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1931         also made.
1932
1933         * Carbon/CarbonWindowAdapter.mm:
1934         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1935         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1936         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1937         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1938         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1939         (-[CarbonWindowAdapter dealloc]):
1940         (-[CarbonWindowAdapter windowRef]):
1941         (-[CarbonWindowAdapter _hasWindowRef]):
1942         (-[CarbonWindowAdapter _managesWindowRef]):
1943         (-[CarbonWindowAdapter _removeWindowRef]):
1944         (-[CarbonWindowAdapter _carbonWindowClass]):
1945         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1946         (-[CarbonWindowAdapter sendSuperEvent:]):
1947         (-[CarbonWindowAdapter relinquishFocus]):
1948         (-[CarbonWindowAdapter _cancelKey:]):
1949         (-[CarbonWindowAdapter _commonAwake]):
1950         (-[CarbonWindowAdapter _destroyRealWindow:]):
1951         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1952         (-[CarbonWindowAdapter _termWindowIfOwner]):
1953         (-[CarbonWindowAdapter _windowMovedToRect:]):
1954         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1955         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1956         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1957         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1958         (-[CarbonWindowAdapter canBecomeMainWindow]):
1959         (-[CarbonWindowAdapter encodeWithCoder:]):
1960         (-[CarbonWindowAdapter initWithCoder:]):
1961         (-[CarbonWindowAdapter setContentView:]):
1962         (-[CarbonWindowAdapter worksWhenModal]):
1963         (-[CarbonWindowAdapter _setModalWindowLevel]):
1964         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1965         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1966         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1967         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1968         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1969         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1970         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1971         (NSCarbonWindowHandleEvent):
1972         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1973         (-[CarbonWindowAdapter _growBoxRect]):
1974         * Carbon/HIWebView.mm:
1975         (HIWebViewGetWebView):
1976         (HIWebViewConstructor):
1977         (HIWebViewDestructor):
1978         (HIWebViewRegisterClass):
1979         (GetBehaviors):
1980         (Draw):
1981         (HitTest):
1982         (GetRegion):
1983         (GetWindowRef):
1984         (CreateNSEventAdoptingCGEvent):
1985         (CopyEventCGEvent):
1986         (CreateNSEventWithCarbonClickEvent):
1987         (Click):
1988         (CreateNSEventWithCarbonEvent):
1989         (MouseUp):
1990         (CreateNSEventWithCarbonMouseMoveEvent):
1991         (MouseMoved):
1992         (MouseDragged):
1993         (MouseWheelMoved):
1994         (ContextMenuClick):
1995         (GetKind):
1996         (BoundsChanged):
1997         (OwningWindowChanged):
1998         (WindowHandler):
1999         (SyncFrame):
2000         (SetFocusPart):
2001         (AdvanceFocus):
2002         (RelinquishFocus):
2003         (ActiveStateChanged):
2004         (ProcessCommand):
2005         (UpdateCommandStatus):
2006         (_NSSelectorForHICommand):
2007         (HIWebViewEventHandler):
2008         (StartUpdateObserver):
2009         (StopUpdateObserver):
2010         (UpdateObserver):
2011
2012 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2013
2014         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2015         https://bugs.webkit.org/show_bug.cgi?id=172526
2016         <rdar://problem/32396081>
2017
2018         Reviewed by Ryosuke Niwa.
2019
2020         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2021
2022         * WebCoreSupport/WebPlatformStrategies.h:
2023         * WebCoreSupport/WebPlatformStrategies.mm:
2024         (WebPlatformStrategies::webExposedTypes):
2025         (WebPlatformStrategies::writeCustomData):
2026
2027 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2028
2029         Unreviewed, rolling out r222567.
2030
2031         This broke and internal build.
2032
2033         Reverted changeset:
2034
2035         "Build fix for High Sierra 32 bit Mac"
2036         https://bugs.webkit.org/show_bug.cgi?id=177551
2037         http://trac.webkit.org/changeset/222567
2038
2039 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2040
2041         Build fix for High Sierra 32 bit Mac
2042         https://bugs.webkit.org/show_bug.cgi?id=177551
2043         <rdar://problem/34690283>
2044
2045         Reviewed by Alexey Proskuryakov.
2046
2047         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2048         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2049         also made.
2050
2051         * Carbon/CarbonWindowAdapter.mm:
2052         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2053         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2054         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2055         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2056         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2057         (-[CarbonWindowAdapter dealloc]):
2058         (-[CarbonWindowAdapter windowRef]):
2059         (-[CarbonWindowAdapter _hasWindowRef]):
2060         (-[CarbonWindowAdapter _managesWindowRef]):
2061         (-[CarbonWindowAdapter _removeWindowRef]):
2062         (-[CarbonWindowAdapter _carbonWindowClass]):
2063         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2064         (-[CarbonWindowAdapter sendSuperEvent:]):
2065         (-[CarbonWindowAdapter relinquishFocus]):
2066         (-[CarbonWindowAdapter _cancelKey:]):
2067         (-[CarbonWindowAdapter _commonAwake]):
2068         (-[CarbonWindowAdapter _destroyRealWindow:]):
2069         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2070         (-[CarbonWindowAdapter _termWindowIfOwner]):
2071         (-[CarbonWindowAdapter _windowMovedToRect:]):
2072         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2073         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2074         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2075         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2076         (-[CarbonWindowAdapter canBecomeMainWindow]):
2077         (-[CarbonWindowAdapter encodeWithCoder:]):
2078         (-[CarbonWindowAdapter initWithCoder:]):
2079         (-[CarbonWindowAdapter setContentView:]):
2080         (-[CarbonWindowAdapter worksWhenModal]):
2081         (-[CarbonWindowAdapter _setModalWindowLevel]):
2082         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2083         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2084         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2085         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2086         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2087         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2088         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2089         (NSCarbonWindowHandleEvent):
2090         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2091         (-[CarbonWindowAdapter _growBoxRect]):
2092         * Carbon/HIWebView.mm:
2093         (HIWebViewGetWebView):
2094         (HIWebViewConstructor):
2095         (HIWebViewDestructor):
2096         (HIWebViewRegisterClass):
2097         (GetBehaviors):
2098         (Draw):
2099         (HitTest):
2100         (GetRegion):
2101         (GetWindowRef):
2102         (CreateNSEventAdoptingCGEvent):
2103         (CopyEventCGEvent):
2104         (CreateNSEventWithCarbonClickEvent):
2105         (Click):
2106         (CreateNSEventWithCarbonEvent):
2107         (MouseUp):
2108         (CreateNSEventWithCarbonMouseMoveEvent):
2109         (MouseMoved):
2110         (MouseDragged):
2111         (MouseWheelMoved):
2112         (ContextMenuClick):
2113         (GetKind):
2114         (BoundsChanged):
2115         (OwningWindowChanged):
2116         (WindowHandler):
2117         (SyncFrame):
2118         (SetFocusPart):
2119         (AdvanceFocus):
2120         (RelinquishFocus):
2121         (ActiveStateChanged):
2122         (ProcessCommand):
2123         (UpdateCommandStatus):
2124         (_NSSelectorForHICommand):
2125         (HIWebViewEventHandler):
2126         (StartUpdateObserver):
2127         (StopUpdateObserver):
2128         (UpdateObserver):
2129
2130 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2131
2132         Make PolicyAction an encodable enum class
2133         https://bugs.webkit.org/show_bug.cgi?id=177480
2134
2135         Reviewed by Antti Koivisto.
2136
2137         * Plugins/WebPluginContainerCheck.mm:
2138         (-[WebPluginContainerCheck _continueWithPolicy:]):
2139         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2140         * WebCoreSupport/WebFrameLoaderClient.mm:
2141         (-[WebFramePolicyListener invalidate]):
2142         (-[WebFramePolicyListener ignore]):
2143         (-[WebFramePolicyListener download]):
2144         (-[WebFramePolicyListener use]):
2145         (-[WebFramePolicyListener continue]):
2146         * WebView/WebPolicyDelegate.mm:
2147         (-[WebPolicyDecisionListener use]):
2148         (-[WebPolicyDecisionListener ignore]):
2149         (-[WebPolicyDecisionListener download]):
2150
2151 2017-09-25  Frederik Riedel  <riedel@apple.com>
2152
2153         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2154         https://bugs.webkit.org/show_bug.cgi?id=174394
2155         <rdar://problem/33183504>
2156
2157         Reviewed by Ryosuke Niwa.
2158
2159         * DOM/DOMHTMLInputElement.h:
2160         * DOM/DOMHTMLInputElement.mm:
2161         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2162         Determines if this HTMLInputElement is part of a login screen.
2163         (-[DOMHTMLInputElement representingPageUrl]):
2164         Returns the webpage's URL that is currently displayed in the Web View.
2165         (-[DOMHTMLInputElement insertTextSuggestion:]):
2166         Inserts login credentials into the Web View.
2167
2168 2017-09-25  Sam Weinig  <sam@webkit.org>
2169
2170         Remove unused EditorClient functions
2171         https://bugs.webkit.org/show_bug.cgi?id=177463
2172
2173         Reviewed by Alex Christensen.
2174
2175         Remove unused EditorClient functions.
2176
2177         * WebCoreSupport/WebEditorClient.h:
2178         * WebCoreSupport/WebEditorClient.mm:
2179         (WebEditorClient::canonicalizeURL): Deleted.
2180         (WebEditorClient::canonicalizeURLString): Deleted.
2181         (WebEditorClient::writeDataToPasteboard): Deleted.
2182         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2183         (WebEditorClient::readDataFromPasteboard): Deleted.
2184         (WebEditorClient::pasteboardChangeCount): Deleted.
2185
2186 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2187
2188         Stop using PolicyCallback
2189         https://bugs.webkit.org/show_bug.cgi?id=176088
2190
2191         Reviewed by Andy Estes.
2192
2193         * WebCoreSupport/WebFrameLoaderClient.mm:
2194         (-[WebFramePolicyListener invalidate]):
2195         (-[WebFramePolicyListener receivedPolicyDecision:]):
2196
2197 2017-09-25  Sam Weinig  <sam@webkit.org>
2198
2199         Remove unnecessary userVisibleString EditorClient function
2200         https://bugs.webkit.org/show_bug.cgi?id=177456
2201
2202         Reviewed by Dan Bernstein.
2203
2204         * WebCoreSupport/WebEditorClient.h:
2205         * WebCoreSupport/WebEditorClient.mm:
2206         (WebEditorClient::userVisibleString): Deleted.
2207
2208             Remove userVisibleString client function.
2209
2210 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2211
2212         Separate form submission from PolicyChecker infrastructure
2213         https://bugs.webkit.org/show_bug.cgi?id=177396
2214
2215         Reviewed by Geoffrey Garen.
2216
2217         * WebCoreSupport/WebFrameLoaderClient.h:
2218         * WebCoreSupport/WebFrameLoaderClient.mm:
2219         (WebFrameLoaderClient::dispatchWillSubmitForm):
2220
2221 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2222
2223         WeakPtrFactory should populate m_ref lazily.
2224         https://bugs.webkit.org/show_bug.cgi?id=177375
2225
2226         Reviewed by Geoffrey Garen.
2227
2228         * WebCoreSupport/WebEditorClient.mm:
2229         (WebEditorClient::WebEditorClient):
2230         (WebEditorClient::requestCandidatesForSelection):
2231
2232 2017-09-22  Chris Dumez  <cdumez@apple.com>
2233
2234         Use high resolution timestamp for event time
2235         https://bugs.webkit.org/show_bug.cgi?id=154246
2236         <rdar://problem/34333304>
2237
2238         Reviewed by Ryosuke Niwa.
2239
2240         Use WallTime / MonotonicTime instead of double type for clarity.
2241
2242         * DOM/DOMEvent.mm:
2243         (-[DOMEvent timeStamp]):
2244         * WebView/WebFrame.mm:
2245         (-[WebFrame _dragSourceEndedAt:operation:]):
2246         * WebView/WebPDFView.mm:
2247         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2248
2249 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2250
2251         Enable dataTransfer.items on macOS and iOS
2252         https://bugs.webkit.org/show_bug.cgi?id=177335
2253
2254         Reviewed by Sam Weinig.
2255
2256         * WebView/WebPreferences.mm:
2257         (+[WebPreferences initialize]):
2258
2259 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2260
2261         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2262         https://bugs.webkit.org/show_bug.cgi?id=177101
2263         <rdar://problem/34500648>
2264
2265         Reviewed by Brian Burg.
2266
2267         * WebInspector/WebNodeHighlight.mm:
2268         Ensure we close the window that we have just removed.
2269
2270 2017-09-20  Antti Koivisto  <antti@apple.com>
2271
2272         Remove DOM and styling support for CSS Regions
2273         https://bugs.webkit.org/show_bug.cgi?id=177221
2274
2275         Reviewed by Andreas Kling.
2276
2277         * Configurations/FeatureDefines.xcconfig:
2278         * DOM/DOMCSS.mm:
2279         (kitClass):
2280         * DOM/DOMElement.mm:
2281         (-[DOMElement webkitRegionOverset]): Deleted.
2282
2283 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2284
2285         Layering violation in Editor::createFragment
2286         https://bugs.webkit.org/show_bug.cgi?id=176123
2287
2288         Reviewed by Darin Adler.
2289
2290         * Misc/WebNSURLExtras.h:
2291         * Misc/WebNSURLExtras.mm:
2292         * WebView/WebFrame.mm:
2293         * WebView/WebHTMLView.mm:
2294         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2295
2296         * WebCoreSupport/WebEditorClient.mm:
2297         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2298         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2299         way to avoid exporting the symbol just on newer OSes.
2300
2301 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2302
2303         On iOS, getData can't get text set by setData during copy event
2304         https://bugs.webkit.org/show_bug.cgi?id=176980
2305         <rdar://problem/34453915>
2306
2307         Reviewed by Darin Adler.
2308
2309         * WebCoreSupport/WebPlatformStrategies.h:
2310         * WebCoreSupport/WebPlatformStrategies.mm:
2311         (WebPlatformStrategies::copy): Deleted.
2312
2313 2017-09-18  Andy Estes  <aestes@apple.com>
2314
2315         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2316         https://bugs.webkit.org/show_bug.cgi?id=177029
2317
2318         Reviewed by Alex Christensen.
2319
2320         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2321         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2322         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2323         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2324         * WebCoreSupport/PopupMenuMac.mm:
2325         (PopupMenuMac::show):
2326         * WebCoreSupport/WebSystemInterface.mm:
2327         (InitWebCoreSystemInterface):
2328         * WebView/WebHTMLView.mm:
2329         (-[WebHTMLView setDataSource:]):
2330         (-[WebHTMLView attachRootLayer:]):
2331         * WebView/WebView.mm:
2332         (-[WebView _needsAdobeFrameReloadingQuirk]):
2333         (-[WebView _needsLinkElementTextCSSQuirk]):
2334         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2335         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2336         (-[WebView _preferencesChanged:]):
2337
2338 2017-09-15  Andy Estes  <aestes@apple.com>
2339
2340         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2341         https://bugs.webkit.org/show_bug.cgi?id=176953
2342
2343         Reviewed by Eric Carlson.
2344
2345         * WebCoreSupport/WebSystemInterface.mm:
2346         (InitWebCoreSystemInterface):
2347
2348 2017-09-14  Andy Estes  <aestes@apple.com>
2349
2350         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2351         https://bugs.webkit.org/show_bug.cgi?id=176931
2352
2353         Reviewed by Joseph Pecoraro.
2354
2355         * WebCoreSupport/WebSystemInterface.mm:
2356         (InitWebCoreSystemInterface):
2357
2358 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2359
2360         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2361         https://bugs.webkit.org/show_bug.cgi?id=176867
2362
2363         Reviewed by Sam Weinig.
2364
2365         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2366         (WebKit::NetscapePluginInstanceProxy::enumerate):
2367
2368 2017-09-13  Andy Estes  <aestes@apple.com>
2369
2370         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2371         https://bugs.webkit.org/show_bug.cgi?id=176729
2372
2373         Reviewed by Alex Christensen.
2374
2375         * WebCoreSupport/WebSystemInterface.mm:
2376         (InitWebCoreSystemInterface):
2377         * WebView/WebView.mm:
2378         (+[WebView _setCacheModel:]):
2379
2380 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2381
2382         Refactor WebContentReader out of EditorMac and EditorIOS
2383         https://bugs.webkit.org/show_bug.cgi?id=176770
2384
2385         Reviewed by Sam Weinig.
2386
2387         * WebCoreSupport/WebEditorClient.mm:
2388
2389 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2390
2391         Dragging & dropping a file creates an attachment element even when it's disabled
2392         https://bugs.webkit.org/show_bug.cgi?id=176769
2393
2394         Reviewed by Tim Horton.
2395
2396         * WebView/WebView.mm:
2397         (-[WebView _preferencesChanged:]):
2398
2399 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2400
2401         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2402         https://bugs.webkit.org/show_bug.cgi?id=176721
2403         <rdar://problem/34373660>
2404
2405         Reviewed by Tim Horton.
2406
2407         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2408         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2409
2410         * WebView/WebView.mm:
2411         (-[WebView _startDrag:]):
2412         (-[WebView _draggedElementBounds]):
2413         (-[WebView _endedDataInteraction:global:]):
2414         * WebView/WebViewData.h:
2415
2416 2017-09-11  Andy Estes  <aestes@apple.com>
2417
2418         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2419         https://bugs.webkit.org/show_bug.cgi?id=176472
2420
2421         Reviewed by Eric Carlson.
2422
2423         * WebCoreSupport/WebSystemInterface.mm:
2424         (InitWebCoreSystemInterface):
2425
2426 2017-09-09  Mark Lam  <mark.lam@apple.com>
2427
2428         Avoid duplicate computations of ExecState::vm().
2429         https://bugs.webkit.org/show_bug.cgi?id=176647
2430
2431         Reviewed by Saam Barati.
2432
2433         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2434         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2435         (WebKit::NetscapePluginInstanceProxy::construct):
2436         (WebKit::NetscapePluginInstanceProxy::setProperty):
2437         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2438         (WebKit::NetscapePluginInstanceProxy::enumerate):
2439         * Plugins/Hosted/ProxyInstance.mm:
2440         (WebKit::ProxyRuntimeMethod::create):
2441
2442 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2443
2444         Unreviewed, rolling out r221773.
2445         https://bugs.webkit.org/show_bug.cgi?id=176614
2446
2447         This caused build failures. (Requested by mlewis13 on
2448         #webkit).
2449
2450         Reverted changeset:
2451
2452         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2453         https://bugs.webkit.org/show_bug.cgi?id=176472
2454         http://trac.webkit.org/changeset/221773
2455
2456 2017-09-07  Andy Estes  <aestes@apple.com>
2457
2458         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2459         https://bugs.webkit.org/show_bug.cgi?id=176472
2460
2461         Reviewed by Eric Carlson.
2462
2463         * WebCoreSupport/WebSystemInterface.mm:
2464         (InitWebCoreSystemInterface):
2465
2466 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2467
2468         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2469         https://bugs.webkit.org/show_bug.cgi?id=176561
2470
2471         Reviewed by Brent Fulgham.
2472
2473         * Misc/WebNSUserDefaultsExtras.mm:
2474
2475 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2476
2477         Modernize Geolocation code
2478         https://bugs.webkit.org/show_bug.cgi?id=176496
2479
2480         Reviewed by Andy Estes.
2481
2482         * WebCoreSupport/WebGeolocationClient.h:
2483         * WebCoreSupport/WebGeolocationClient.mm:
2484         (WebGeolocationClient::requestPermission):
2485         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2486         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2487         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2488         * WebView/WebView.mm:
2489         (-[WebView _commonInitializationWithFrameName:groupName:]):
2490         (-[WebView _geolocationDidFailWithMessage:]):
2491
2492 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2493
2494         Remove some unused bits of code and resources
2495         https://bugs.webkit.org/show_bug.cgi?id=176275
2496
2497         Reviewed by Dan Bernstein.
2498
2499         * Misc/WebNSFileManagerExtras.mm:
2500         Include FileSystem instead of FileSystemIOS.
2501
2502 2017-09-03  Darin Adler  <darin@apple.com>
2503
2504         [Cocoa] Tidy a few things in legacy WebHTMLView
2505         https://bugs.webkit.org/show_bug.cgi?id=176280
2506
2507         Reviewed by Dan Bernstein.
2508
2509         * WebCoreSupport/WebChromeClient.mm:
2510         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2511         methods it calls on WebHTMLView were doing nothing on iOS.
2512
2513         * WebView/WebFrame.mm:
2514         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2515         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2516
2517         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2518         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2519         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2520         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2521         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2522         Use RetainPtr instead of writing retain/release wherever possible.
2523         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2524         initialization for it. Removed various unused methods and declarations of methods.
2525         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2526         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2527         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2528         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2529         and remove CFRetain no longer needed since we don't support garbage collection any more.
2530         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2531         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2532         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2533         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2534         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2535         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2536         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2537         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2538         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2539         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2540         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2541         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2542         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2543         debug flag; we haven't used it for years and it's not clearly helpful.
2544         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2545         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2546         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2547         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2548         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2549         two additional methods in the WebPrivate category and still be called by the two
2550         methods in the WebInternal category that were already using it.
2551         (-[WebHTMLView didAddSubview:]): Deleted.
2552         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2553         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2554         place this was called, the close method.
2555         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2556         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2557         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2558         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2559         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2560         Added helper method to make the one below simpler.
2561         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2562         Compared pasteboard type strings using isEqualToString: rather than using == since
2563         we want to actually compare the string contents. Also updated to use modern for loop,
2564         renamed a local variable from "s" to "localSubresources", and factored out the handling
2565         of three image types to use the helper method above.
2566         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2567         _web_makePluginSubviewsPerformSelector:withObject: method.
2568         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2569         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2570         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2571         not call the -[NSView subviews] method to make this identical on both platforms and used
2572         a modern for loop.
2573         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2574         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2575         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2576         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2577         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2578         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2579         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2580         of it is Mac-only.
2581         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2582         method did was call itself on the main thread, and do nothing if called on main thread.
2583         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2584         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2585         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2586         half of this method.
2587         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2588         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2589         Simplified using a modern for loop and RetainPtr.
2590         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2591         (-[WebHTMLView keyDown:]): Ditto.
2592         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2593         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2594         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2595         (-[WebHTMLView complete:]): Ditto.
2596         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2597         now macOS-only.
2598         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2599         iOS since that is now macOS-only.
2600         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2601         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2602         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2603         and reorganized to use early return.
2604         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2605         on iOS, but kept there so we don't have to do #if at every call site.
2606         (-[WebHTMLView _pluginController]): Moved into internal category.
2607         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2608         there only for GC, using C++ initialization, removing obsolete comment.
2609         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2610         peculiar iOS-only comment.
2611         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2612
2613         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2614         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2615         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2616         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2617         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2618
2619         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2620         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2621         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2622         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2623         them at this time.
2624
2625 2017-09-03  Sam Weinig  <sam@webkit.org>
2626
2627         Remove CanvasProxy
2628         https://bugs.webkit.org/show_bug.cgi?id=176288
2629
2630         Reviewed by Yusuke Suzuki.
2631
2632         CanvasProxy does not appear to be in any current HTML spec
2633         and was disabled and unimplemented in our tree. Time to 
2634         get rid of it.
2635
2636         * Configurations/FeatureDefines.xcconfig:
2637
2638 2017-09-02  Andy Estes  <aestes@apple.com>
2639
2640         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2641         https://bugs.webkit.org/show_bug.cgi?id=176270
2642
2643         Reviewed by Tim Horton.
2644
2645         * Plugins/Hosted/NetscapePluginHostManager.mm:
2646         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2647         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2648         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2649         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2650         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2651         (WebKit::SoftwareCARenderer::context const):
2652         (WebKit::SoftwareCARenderer::renderContext const):
2653         (WebKit::SoftwareCARenderer::render):
2654         (-[WebHostedNetscapePluginView createPlugin]):
2655         (-[WebHostedNetscapePluginView createPluginLayer]):
2656         (-[WebHostedNetscapePluginView destroyPlugin]):
2657         (-[WebHostedNetscapePluginView drawRect:]):
2658         * WebCoreSupport/WebSystemInterface.mm:
2659         (InitWebCoreSystemInterface):
2660
2661 2017-09-01  Andy Estes  <aestes@apple.com>
2662
2663         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2664         https://bugs.webkit.org/show_bug.cgi?id=176200
2665
2666         Reviewed by Tim Horton.
2667
2668         * Carbon/HIWebView.mm:
2669         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2670         (overrideCGContext):
2671         (restoreCGContext):
2672         (Draw):
2673         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2674         (+[WebHostedNetscapePluginView initialize]):
2675         * Plugins/WebBaseNetscapePluginView.h:
2676         * Plugins/WebBaseNetscapePluginView.mm:
2677         (WebKit::sendUserChangeNotifications):
2678         * Plugins/WebNetscapePluginView.mm:
2679         (+[WebNetscapePluginView initialize]):
2680         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2681         * WebCoreSupport/WebSystemInterface.mm:
2682         (InitWebCoreSystemInterface):
2683         * WebView/WebFrame.mm:
2684         (-[WebFrame _paintBehaviorForDestinationContext:]):
2685         * WebView/WebFullScreenController.mm:
2686         (setClipRectForWindow):
2687         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2688         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2689         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2690         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2691
2692 2017-08-31  Andy Estes  <aestes@apple.com>
2693
2694         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2695         https://bugs.webkit.org/show_bug.cgi?id=176175
2696
2697         Reviewed by Brady Eidson.
2698
2699         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2700         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2701         * Plugins/Hosted/WebTextInputWindowController.m:
2702         (-[WebTextInputPanel init]):
2703         * WebCoreSupport/WebSystemInterface.mm:
2704         (InitWebCoreSystemInterface):
2705         * WebView/WebDynamicScrollBarsView.mm:
2706         (-[WebDynamicScrollBarsView scrollWheel:]):
2707         * WebView/WebHTMLView.mm:
2708         (-[WebHTMLView _removeWindowObservers]):
2709         (-[WebHTMLView addWindowObservers]):
2710         * WebView/WebView.mm:
2711         (-[WebView addWindowObserversForWindow:]):
2712         (-[WebView removeWindowObservers]):
2713         (-[WebView viewWillMoveToWindow:]):
2714
2715 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2716
2717         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2718         https://bugs.webkit.org/show_bug.cgi?id=175779
2719         <rdar://problem/22367975>
2720
2721         Reviewed by Tim Horton.
2722
2723         * WebCoreSupport/WebFrameLoaderClient.h:
2724         * WebCoreSupport/WebFrameLoaderClient.mm:
2725         (WebFrameLoaderClient::webGLPolicyForURL const):
2726         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2727
2728 2017-08-30  Andy Estes  <aestes@apple.com>
2729
2730         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
2731         https://bugs.webkit.org/show_bug.cgi?id=176093
2732
2733         Reviewed by Eric Carlson.
2734
2735         * WebCoreSupport/WebSystemInterface.mm:
2736         (InitWebCoreSystemInterface):
2737
2738 2017-08-30  Andy Estes  <aestes@apple.com>
2739
2740         [Mac] Upstream Carbon-related WebKitSystemInterface functions
2741         https://bugs.webkit.org/show_bug.cgi?id=176087
2742
2743         Reviewed by Alex Christensen.
2744
2745         * Carbon/CarbonUtils.m:
2746         (getNSAutoreleasePoolCount):
2747         (WebInitForCarbon):
2748         (PoolCleaner):
2749         * Carbon/CarbonWindowAdapter.mm:
2750         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2751         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2752         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2753         (-[CarbonWindowAdapter _windowMovedToRect:]):
2754         * Carbon/HIViewAdapter.m:
2755         * Carbon/HIWebView.mm:
2756         (Draw):
2757         (CreateNSEventAdoptingCGEvent):
2758         (CopyEventCGEvent):
2759         (CreateNSEventWithCarbonClickEvent):
2760         (Click):
2761         (CreateNSEventWithCarbonEvent):
2762         (MouseUp):
2763         (CreateNSEventWithCarbonMouseMoveEvent):
2764         (MouseMoved):
2765         (MouseDragged):
2766         (MouseWheelMoved):
2767         (WindowHandler):
2768         (HIWebViewEventHandler):
2769         * Misc/QuickDrawCompatibility.h: Removed.
2770         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2771         (getCarbonEvent):
2772         (WebNetscapePluginEventHandlerCarbon::keyDown):
2773         (WebNetscapePluginEventHandlerCarbon::keyUp):
2774         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2775         (WebNetscapePluginEventHandlerCocoa::keyDown):
2776         * Plugins/WebNetscapePluginView.mm:
2777         (-[WebNetscapePluginView tellQuickTimeToChill]):
2778
2779 2017-08-29  Andy Estes  <aestes@apple.com>
2780
2781         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
2782         https://bugs.webkit.org/show_bug.cgi?id=176046
2783
2784         Reviewed by Alex Christensen.
2785
2786         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
2787         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
2788
2789         * Misc/WebNSFileManagerExtras.mm:
2790         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2791         (setMetaData): Deleted.
2792         * WebCoreSupport/WebSystemInterface.mm:
2793         (InitWebCoreSystemInterface):
2794
2795 2017-08-28  Andy Estes  <aestes@apple.com>
2796
2797         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
2798         https://bugs.webkit.org/show_bug.cgi?id=176039
2799
2800         Reviewed by Alex Christensen.
2801
2802         * WebCoreSupport/WebSystemInterface.mm:
2803         (InitWebCoreSystemInterface):
2804         * WebView/WebPreferences.mm:
2805         (+[WebPreferences _systemCFStringEncoding]):
2806
2807 2017-08-28  Andy Estes  <aestes@apple.com>
2808
2809         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
2810         https://bugs.webkit.org/show_bug.cgi?id=176032
2811
2812         Reviewed by Alex Christensen.
2813
2814         * WebCoreSupport/WebSystemInterface.mm:
2815         (InitWebCoreSystemInterface):
2816         * WebView/WebView.mm:
2817         (-[WebView _cachedResponseForURL:]):
2818
2819 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2820
2821         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
2822         https://bugs.webkit.org/show_bug.cgi?id=175992
2823         <rdar://problem/34086613>
2824
2825         Reviewed by Daniel Bates.
2826
2827         * WebCoreSupport/WebPlatformStrategies.h:
2828         * WebCoreSupport/WebPlatformStrategies.mm:
2829         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
2830         cookies should be included, and return a pair containing the resulting cookie string and a boolean
2831         indicating if secure cookies were accessed.
2832
2833 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2834
2835         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
2836         https://bugs.webkit.org/show_bug.cgi?id=170955
2837         <rdar://problem/31697653>
2838
2839         Reviewed by Ryosuke Niwa.
2840
2841         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
2842         text is being replaced.
2843
2844         * WebView/WebHTMLView.mm:
2845         (-[WebHTMLView insertText:]):
2846
2847 2017-08-24  Chris Dumez  <cdumez@apple.com>
2848
2849         [Directory Upload] Add basic support for input.webkitdirectory
2850         https://bugs.webkit.org/show_bug.cgi?id=175950
2851         <rdar://problem/33951915>
2852
2853         Reviewed by Geoffrey Garen.
2854
2855         Add private API to toggle Directory Upload support on Mac WebKit1.
2856
2857         * WebView/WebPreferenceKeysPrivate.h:
2858         * WebView/WebPreferences.mm:
2859         (+[WebPreferences initialize]):
2860         (-[WebPreferences setDirectoryUploadEnabled:]):
2861         (-[WebPreferences directoryUploadEnabled]):
2862         * WebView/WebPreferencesPrivate.h:
2863         * WebView/WebView.mm:
2864         (-[WebView _preferencesChanged:]):
2865
2866 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2867
2868         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2869         https://bugs.webkit.org/show_bug.cgi?id=175370
2870         <rdar://problem/33799806>
2871
2872         Reviewed by Ryosuke Niwa.
2873
2874         Adjust WebEditorClient for interface changes.
2875
2876         * WebCoreSupport/WebEditorClient.h:
2877
2878 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2879
2880         Remove ChromeClient::scrollbarsModeDidChange
2881         https://bugs.webkit.org/show_bug.cgi?id=175805
2882
2883         Reviewed by Daniel Bates.
2884
2885         * WebCoreSupport/WebChromeClient.h:
2886
2887 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2888
2889         Remove ChromeClient::hasOpenedPopup
2890         https://bugs.webkit.org/show_bug.cgi?id=175804
2891
2892         Reviewed by Sam Weinig.
2893
2894         * WebCoreSupport/WebChromeClient.h:
2895         * WebCoreSupport/WebChromeClient.mm:
2896         (WebChromeClient::hasOpenedPopup const): Deleted.
2897
2898 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
2899
2900         Disable access to secure cookies if an HTTPS site loads mixed content
2901         https://bugs.webkit.org/show_bug.cgi?id=157053
2902         <rdar://problem/11290808>
2903
2904         Reviewed by Dan Bates.
2905
2906         * WebCoreSupport/WebPlatformStrategies.h:
2907         * WebCoreSupport/WebPlatformStrategies.mm:
2908         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
2909         indicating whether secure cookies should be included in the response.
2910
2911 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2912
2913         [PAL] Move spi/mac directory into PAL
2914         https://bugs.webkit.org/show_bug.cgi?id=175649
2915
2916         Reviewed by Myles C. Maxfield.
2917
2918         * Misc/WebSharingServicePickerController.h:
2919         * WebCoreSupport/WebContextMenuClient.mm:
2920         * WebCoreSupport/WebEditorClient.mm:
2921         * WebCoreSupport/WebSelectionServiceController.mm:
2922         * WebView/WebHTMLView.mm:
2923         * WebView/WebImmediateActionController.h:
2924         * WebView/WebImmediateActionController.mm:
2925         * WebView/WebView.mm:
2926
2927 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2928
2929         [PAL] Relocate SessionID to root
2930         https://bugs.webkit.org/show_bug.cgi?id=175684
2931
2932         Reviewed by Alex Christensen.
2933
2934         * WebCoreSupport/WebFrameNetworkingContext.mm:
2935
2936 2017-08-17  Andreas Kling  <akling@apple.com>
2937
2938         Disable CSS regions at compile time
2939         https://bugs.webkit.org/show_bug.cgi?id=175630
2940
2941         Reviewed by Antti Koivisto.
2942
2943         * Configurations/FeatureDefines.xcconfig:
2944
2945 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2946
2947         [PAL] Move SessionID into PAL
2948         https://bugs.webkit.org/show_bug.cgi?id=174192
2949
2950         Reviewed by Antti Koivisto.
2951
2952         * Misc/WebCache.mm:
2953         (+[WebCache imageForURL:]):
2954         * WebCoreSupport/WebFrameLoaderClient.h:
2955         * WebCoreSupport/WebFrameLoaderClient.mm:
2956         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2957         * WebCoreSupport/WebFrameNetworkingContext.mm:
2958         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2959         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2960         (WebFrameNetworkingContext::storageSession const):
2961         * WebCoreSupport/WebPlatformStrategies.h:
2962         * WebCoreSupport/WebPlatformStrategies.mm:
2963         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2964         * WebKitPrefix.h:
2965
2966 2017-08-16  Andy Estes  <aestes@apple.com>
2967
2968         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
2969         https://bugs.webkit.org/show_bug.cgi?id=175648
2970
2971         Reviewed by Tim Horton.
2972
2973         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2974         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2975         (WebPaymentCoordinatorClient::showPaymentUI):
2976
2977 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2978
2979         [PAL] Move spi/ios and spi/win directories into PAL
2980         https://bugs.webkit.org/show_bug.cgi?id=175171
2981
2982         Reviewed by Antti Koivisto.
2983
2984         * WebCoreSupport/WebFrameLoaderClient.mm:
2985         * WebView/WebView.mm:
2986
2987 2017-08-16  Andy Estes  <aestes@apple.com>
2988
2989         [Payment Request] Add an ENABLE flag and an experimental feature preference
2990         https://bugs.webkit.org/show_bug.cgi?id=175622
2991
2992         Reviewed by Tim Horton.
2993
2994         * Configurations/FeatureDefines.xcconfig:
2995
2996 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
2997
2998         [PAL] Move Sleep classes into PAL
2999         https://bugs.webkit.org/show_bug.cgi?id=175456
3000
3001         Reviewed by Ryosuke Niwa.
3002
3003         * WebView/WebFullScreenController.h:
3004
3005 2017-08-15  Youenn Fablet  <youenn@apple.com>
3006
3007         [Cache API] Adding generic support for CacheStorage and Cache methods
3008         https://bugs.webkit.org/show_bug.cgi?id=175455
3009
3010         Reviewed by Chris Dumez.
3011
3012         * WebView/WebView.mm:
3013         (-[WebView _commonInitializationWithFrameName:groupName:]):
3014
3015 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3016
3017         Remove Proximity Events and related code
3018         https://bugs.webkit.org/show_bug.cgi?id=175545
3019
3020         Reviewed by Daniel Bates.
3021
3022         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3023         and other related code.
3024
3025         * Configurations/FeatureDefines.xcconfig:
3026
3027 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3028
3029         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3030         https://bugs.webkit.org/show_bug.cgi?id=175504
3031
3032         Reviewed by Sam Weinig.
3033
3034         * Configurations/FeatureDefines.xcconfig:
3035         * DOM/DOMHTMLFormElement.mm:
3036         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3037         * WebCoreSupport/WebFrameLoaderClient.h:
3038
3039 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3040
3041         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3042         https://bugs.webkit.org/show_bug.cgi?id=175557
3043
3044         Reviewed by Jon Lee.
3045
3046         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3047
3048         * Configurations/FeatureDefines.xcconfig:
3049
3050 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3051
3052         Composition underline color is always black
3053         https://bugs.webkit.org/show_bug.cgi?id=174675
3054
3055         Reviewed by Ryosuke Niwa.
3056
3057         * WebView/WebHTMLView.mm:
3058         (extractUnderlines): If NSUnderlineColorAttributeName
3059         is not present use text color for composition underline.
3060         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3061         for composition underline in the plain text case.
3062
3063 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3064
3065         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3066         https://bugs.webkit.org/show_bug.cgi?id=175474
3067         <rdar://problem/33844628>
3068
3069         Reviewed by Wenson Hsieh.
3070
3071         Replaced the build flag by a runtime flag and disabled the feature by default.
3072
3073         * Configurations/FeatureDefines.xcconfig:
3074         * WebView/WebPreferenceKeysPrivate.h:
3075         * WebView/WebPreferences.mm:
3076         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3077         (-[WebPreferences dataTransferItemsEnabled]): Added.
3078         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3079         * WebView/WebPreferencesPrivate.h:
3080         * WebView/WebView.mm:
3081         (-[WebView _preferencesChanged:]):
3082
3083 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3084
3085         Remove ENABLE_GAMEPAD_DEPRECATED
3086         https://bugs.webkit.org/show_bug.cgi?id=175361
3087
3088         Reviewed by Carlos Garcia Campos.
3089
3090         * Configurations/FeatureDefines.xcconfig:
3091
3092 2017-08-09  Chris Dumez  <cdumez@apple.com>
3093
3094         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3095         https://bugs.webkit.org/show_bug.cgi?id=175401
3096
3097         Reviewed by Brady Eidson.
3098
3099         * WebView/WebPreferenceKeysPrivate.h:
3100         * WebView/WebPreferences.mm:
3101         (+[WebPreferences initialize]):
3102         (-[WebPreferences beaconAPIEnabled]): Deleted.
3103         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3104         * WebView/WebPreferencesPrivate.h:
3105         * WebView/WebView.mm:
3106         (-[WebView _preferencesChanged:]):
3107
3108 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3109
3110         [PAL] Move spi/cocoa and spi/cg directories into PAL
3111         https://bugs.webkit.org/show_bug.cgi?id=175175
3112
3113         Reviewed by Myles C. Maxfield.
3114
3115         * History/WebHistory.mm:
3116         * Misc/WebDownload.mm:
3117         * Misc/WebKitNSStringExtras.mm:
3118         * Plugins/Hosted/NetscapePluginHostManager.mm:
3119         * Plugins/WebPluginDatabase.mm:
3120         * WebCoreSupport/WebFrameLoaderClient.mm:
3121         * WebInspector/WebNodeHighlight.mm:
3122         * WebView/WebHTMLView.mm:
3123         * WebView/WebIndicateLayer.mm:
3124         * WebView/WebView.mm:
3125         * WebView/WebViewData.h:
3126
3127 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3128
3129         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3130         https://bugs.webkit.org/show_bug.cgi?id=175392
3131         <rdar://problem/33783207>
3132
3133         Reviewed by Tim Horton and Megan Gardner.
3134
3135         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3136
3137         * Configurations/FeatureDefines.xcconfig:
3138
3139 2017-08-09  Daniel Bates  <dabates@apple.com>
3140
3141         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3142         https://bugs.webkit.org/show_bug.cgi?id=175247
3143         <rdar://problem/33679804>
3144
3145         Reviewed by Brady Eidson.
3146
3147         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3148         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3149         clients that need to make use of this information at this time. If such a needs comes up
3150         then we can expose API/SPI similar to what we do for WebKit.
3151
3152         * WebCoreSupport/WebFrameLoaderClient.h:
3153         * WebCoreSupport/WebFrameLoaderClient.mm:
3154         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3155
3156 2017-08-08  Brady Eidson  <beidson@apple.com>
3157
3158         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3159         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3160
3161         Reviewed by Andy Estes.
3162
3163         * Misc/WebKitVersionChecks.h:
3164         * WebCoreSupport/WebFrameLoaderClient.mm:
3165         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3166           the app is linked against new WebKit with the new behavior.
3167
3168 2017-08-07  Devin Rousso  <drousso@apple.com>
3169
3170         Web Inspector: Preview Canvas path when viewing a recording
3171         https://bugs.webkit.org/show_bug.cgi?id=174967
3172
3173         Reviewed by Brian Burg.
3174
3175         * WebView/WebPreferenceKeysPrivate.h:
3176         * WebView/WebPreferences.mm:
3177         (+[WebPreferences initialize]):
3178         (-[WebPreferences inspectorAdditionsEnabled]):
3179         (-[WebPreferences setInspectorAdditionsEnabled:]):
3180         * WebView/WebPreferencesPrivate.h:
3181         * WebView/WebView.mm:
3182         (-[WebView _preferencesChanged:]):
3183         Add plumbing for new InspectorAdditions runtime flag.
3184
3185 2017-08-07  Brian Burg  <bburg@apple.com>
3186
3187         Remove CANVAS_PATH compilation guard
3188         https://bugs.webkit.org/show_bug.cgi?id=175207
3189
3190         Reviewed by Sam Weinig.
3191
3192         * Configurations/FeatureDefines.xcconfig:
3193
3194 2017-08-04  Youenn Fablet  <youenn@apple.com>
3195
3196         [Cache API] Add Cache and CacheStorage IDL definitions
3197         https://bugs.webkit.org/show_bug.cgi?id=175201
3198
3199         Reviewed by Brady Eidson.
3200
3201         * WebView/WebPreferenceKeysPrivate.h:
3202         * WebView/WebPreferences.mm:
3203         (+[WebPreferences initialize]):
3204         (-[WebPreferences cacheAPIEnabled]):
3205         (-[WebPreferences setCacheAPIEnabled:]):
3206         * WebView/WebPreferencesPrivate.h:
3207         * WebView/WebView.mm:
3208         (-[WebView _preferencesChanged:]):
3209
3210 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3211
3212         Unreviewed, rolling out r220271.
3213
3214         Rolling out due to Layout Test failing on iOS Simulator.
3215
3216         Reverted changeset:
3217
3218         "Remove STREAMS_API compilation guard"
3219         https://bugs.webkit.org/show_bug.cgi?id=175165
3220         http://trac.webkit.org/changeset/220271
3221
3222 2017-08-04  Youenn Fablet  <youenn@apple.com>
3223
3224         Remove STREAMS_API compilation guard
3225         https://bugs.webkit.org/show_bug.cgi?id=175165
3226
3227         Reviewed by Darin Adler.
3228
3229         * Configurations/FeatureDefines.xcconfig:
3230         * WebView/WebPreferences.mm:
3231         (+[WebPreferences initialize]):
3232         * WebView/WebView.mm:
3233         (-[WebView _preferencesChanged:]):
3234
3235 2017-08-03  Brian Burg  <bburg@apple.com>
3236
3237         Remove ENABLE(WEB_SOCKET) guards
3238         https://bugs.webkit.org/show_bug.cgi?id=167044
3239
3240         Reviewed by Joseph Pecoraro.
3241
3242         * Configurations/FeatureDefines.xcconfig:
3243         * WebView/WebPreferencesPrivate.h:
3244
3245 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3246
3247         [PAL] Move spi/cf directory into PAL
3248         https://bugs.webkit.org/show_bug.cgi?id=175057
3249
3250         Reviewed by Antti Koivisto.
3251
3252         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3253         * Plugins/WebNetscapePluginStream.mm:
3254         * WebCoreSupport/WebFrameNetworkingContext.mm:
3255         * WebView/WebPreferences.mm:
3256         * WebView/WebView.mm:
3257
3258 2017-08-03  Youenn Fablet  <youenn@apple.com>
3259
3260         Remove FETCH_API compilation guard
3261         https://bugs.webkit.org/show_bug.cgi?id=175154
3262
3263         Reviewed by Chris Dumez.
3264
3265         * Configurations/FeatureDefines.xcconfig:
3266         * WebView/WebPreferences.mm:
3267         (+[WebPreferences initialize]):
3268         * WebView/WebView.mm:
3269         (-[WebView _preferencesChanged:]):
3270
3271 2017-08-03  Brady Eidson  <beidson@apple.com>
3272
3273         Add SW IDLs and stub out basic functionality.
3274         https://bugs.webkit.org/show_bug.cgi?id=175115
3275
3276         Reviewed by Chris Dumez.
3277
3278         * Configurations/FeatureDefines.xcconfig:
3279
3280 2017-08-02  Sam Weinig  <sam@webkit.org>
3281
3282         [WebIDL] Convert MutationCallback to be a normal generated callback
3283         https://bugs.webkit.org/show_bug.cgi?id=174140
3284
3285         Reviewed by Darin Adler.
3286
3287         * DOM/DOMDocument.mm:
3288         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3289         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3290         Pass, now necessary, Document to NativeNodeFilter constructor.
3291
3292 2017-08-01  Chris Dumez  <cdumez@apple.com>
3293
3294         Add initial support for navigator.sendBeacon
3295         https://bugs.webkit.org/show_bug.cgi?id=175007
3296         <rdar://problem/33547728>
3297
3298         Reviewed by Sam Weinig.
3299
3300         Add setting to toggle support for the Beacon API (it is disabled by default).
3301
3302         * WebView/WebPreferenceKeysPrivate.h:
3303         * WebView/WebPreferences.mm:
3304         (+[WebPreferences initialize]):
3305         (-[WebPreferences beaconAPIEnabled]):
3306         (-[WebPreferences setBeaconAPIEnabled:]):
3307         * WebView/WebPreferencesPrivate.h:
3308         * WebView/WebView.mm:
3309         (-[WebView _preferencesChanged:]):
3310
3311 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3312
3313         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3314         https://bugs.webkit.org/show_bug.cgi?id=174437
3315
3316         Reviewed by Darin Adler.
3317
3318         Remove redundant Web- prefix from classes in WebKit namespace.
3319
3320         * WebView/WebView.mm:
3321         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3322         * WebView/WebViewData.h:
3323         * WebView/WebViewData.mm:
3324
3325 2017-07-26  Brian Burg  <bburg@apple.com>
3326
3327         Remove WEB_TIMING feature flag
3328         https://bugs.webkit.org/show_bug.cgi?id=174795
3329
3330         Reviewed by Alex Christensen.
3331
3332         * Configurations/FeatureDefines.xcconfig:
3333
3334 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3335
3336         Async image decoding for large images should be disabled after the first time a tile is painted
3337         https://bugs.webkit.org/show_bug.cgi?id=174451
3338         <rdar://problem/31246421>
3339
3340         Reviewed by Simon Fraser.
3341
3342         * WebView/WebFrame.mm:
3343         (-[WebFrame _paintBehaviorForDestinationContext:]):
3344         (-[WebFrame _drawRect:contentsOnly:]):
3345         * WebView/WebHTMLView.mm:
3346         (imageFromRect):
3347
3348 2017-07-23  Darin Adler  <darin@apple.com>
3349
3350         More NeverDestroyed and related cleanup
3351         https://bugs.webkit.org/show_bug.cgi?id=174745
3352
3353         Reviewed by Alex Christensen.
3354
3355         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3356         for names that aren't even used in this file.
3357         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3358         -[NSArray arrayWithObject:].
3359         (-[DOMNode absoluteQuads]): Ditto.
3360         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3361         of writing out various types.
3362         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3363         syntax instea of -[NSArray arrayWithObject:].
3364         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3365         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3366         of writing out various types.
3367         (-[DOMHTMLImageElement mimeType]): Ditto.
3368
3369 2017-07-24  Chris Dumez  <cdumez@apple.com>
3370
3371         ExceptionCode enumeration should use modern exception names
3372         https://bugs.webkit.org/show_bug.cgi?id=174794
3373
3374         Reviewed by Geoffrey Garen.
3375
3376         * DOM/ExceptionHandlers.mm:
3377         (raiseNotSupportedErrorException):
3378
3379 2017-07-23  Chris Dumez  <cdumez@apple.com>
3380
3381         Drop ExceptionCodeDescription class
3382         https://bugs.webkit.org/show_bug.cgi?id=174757
3383
3384         Reviewed by Darin Adler.
3385
3386         Stop using ExceptionCodeDescription.
3387
3388         * DOM/ExceptionHandlers.mm:
3389         (raiseDOMErrorException):
3390
3391 2017-07-21  Andreas Kling  <akling@apple.com>
3392
3393         Use more references in event dispatch code
3394         https://bugs.webkit.org/show_bug.cgi?id=174681
3395
3396         Reviewed by Geoffrey Garen.
3397
3398         * DOM/ObjCEventListener.h:
3399         * DOM/ObjCEventListener.mm:
3400         (WebCore::ObjCEventListener::handleEvent):
3401         * WebCoreSupport/WebFrameLoaderClient.mm:
3402         (NetscapePluginWidget::handleEvent):
3403
3404 2017-07-21  Brady Eidson  <beidson@apple.com>
3405
3406         Get rid of WebCore IconDatabase code.
3407         https://bugs.webkit.org/show_bug.cgi?id=174700
3408
3409         Reviewed by Tim Horton.
3410
3411         * Misc/WebCoreStatistics.mm:
3412         (+[WebCoreStatistics iconPageURLMappingCount]):
3413         (+[WebCoreStatistics iconRetainedPageURLCount]):
3414         (+[WebCoreStatistics iconRecordCount]):
3415         (+[WebCoreStatistics iconsWithDataCount]):
3416         * WebCoreSupport/WebFrameLoaderClient.h:
3417         * WebCoreSupport/WebFrameLoaderClient.mm:
3418         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
3419         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
3420         * WebView/WebView.mm:
3421         (-[WebView mainFrameIconURL]):
3422
3423 2017-07-20  Chris Dumez  <cdumez@apple.com>
3424
3425         Drop legacy XPathException type
3426         https://bugs.webkit.org/show_bug.cgi?id=174679
3427
3428         Reviewed by Sam Weinig.
3429
3430         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3431         no longer expose XPathException.
3432
3433         * DOM/ExceptionHandlers.mm:
3434         (raiseDOMErrorException):
3435
3436 2017-07-20  Chris Dumez  <cdumez@apple.com>
3437
3438         Unreviewed, rolling out r219706.
3439
3440         Broke iOS build
3441
3442         Reverted changeset:
3443
3444         "Drop legacy XPathException type"
3445         https://bugs.webkit.org/show_bug.cgi?id=174679
3446         http://trac.webkit.org/changeset/219706
3447
3448 2017-07-20  Chris Dumez  <cdumez@apple.com>
3449
3450         Drop legacy XPathException type
3451         https://bugs.webkit.org/show_bug.cgi?id=174679
3452
3453         Reviewed by Sam Weinig.
3454
3455         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3456         no longer expose XPathException.
3457
3458         * DOM/ExceptionHandlers.mm:
3459         (raiseDOMErrorException):
3460         * WebKit.exp:
3461
3462 2017-07-20  Chris Dumez  <cdumez@apple.com>
3463
3464         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
3465         https://bugs.webkit.org/show_bug.cgi?id=174660
3466
3467         Reviewed by Geoffrey Garen.
3468
3469         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
3470         This essentially replaces a branch to figure out if the new size is less or greater than the
3471         current size by an assertion.
3472
3473         * Plugins/WebNetscapePluginView.mm:
3474         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3475
3476 2017-07-20  Brady Eidson  <beidson@apple.com>
3477
3478         Deprecate WebIconDatabase in WebKitLegacy/mac.
3479         https://bugs.webkit.org/show_bug.cgi?id=174607
3480
3481         Reviewed by Alex Christensen.
3482
3483         This patch:
3484         1 - Formally deprecates WebIconDatabase (which was never API anyways)
3485         2 - Guts the class to where it can only return the default icon at the small size
3486         3 - Reworks other parts of WebKitLegacy that used it for anything to either
3487             use something else or to not do anything.
3488         
3489         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
3490         and that patch will remove all of the last remnants of WebIconDatabase.
3491         
3492         * History/WebHistoryItem.mm:
3493         (-[WebHistoryItem icon]):
3494
3495         * Misc/WebIconDatabase.h:
3496         * Misc/WebIconDatabase.mm:
3497         (-[WebIconDatabase init]):
3498         (-[WebIconDatabase iconForURL:withSize:cache:]):
3499         (-[WebIconDatabase iconForURL:withSize:]):
3500         (-[WebIconDatabase defaultIconWithSize:]):
3501         (-[WebIconDatabase defaultIconForURL:withSize:]):
3502         (-[WebIconDatabase iconURLForURL:]):
3503         (-[WebIconDatabase retainIconForURL:]):
3504         (-[WebIconDatabase releaseIconForURL:]):
3505         (+[WebIconDatabase delayDatabaseCleanup]):
3506         (+[WebIconDatabase allowDatabaseCleanup]):
3507         (-[WebIconDatabase setDelegate:]):
3508         (-[WebIconDatabase delegate]):
3509         (+[WebIconDatabase initialize]): Deleted.
3510         (-[WebIconDatabase isEnabled]): Deleted.
3511         (-[WebIconDatabase setEnabled:]): Deleted.
3512         (-[WebIconDatabase removeAllIcons]): Deleted.
3513         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
3514         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
3515         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
3516         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
3517         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
3518         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
3519         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
3520         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
3521         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
3522         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
3523         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
3524         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
3525         (-[WebIconDatabase _databaseDirectory]): Deleted.
3526         (webGetNSImage): Deleted.
3527
3528         * Misc/WebIconDatabaseDelegate.h: Removed.
3529         * Misc/WebIconDatabaseInternal.h: Removed.
3530         * Misc/WebIconDatabasePrivate.h: Removed.
3531
3532         * WebCoreSupport/WebFrameLoaderClient.mm:
3533         (webGetNSImage):
3534
3535         * WebCoreSupport/WebIconDatabaseClient.mm:
3536         (WebIconDatabaseClient::didRemoveAllIcons):
3537         (WebIconDatabaseClient::didImportIconURLForPageURL):
3538
3539         * WebView/WebView.mm:
3540         (-[WebView setFrameLoadDelegate:]):
3541         (-[WebView mainFrameIcon]):
3542
3543 2017-07-18  Andy Estes  <aestes@apple.com>
3544
3545         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3546         https://bugs.webkit.org/show_bug.cgi?id=174631
3547
3548         Reviewed by Tim Horton.
3549
3550         * Configurations/Base.xcconfig:
3551
3552 2017-07-18  Andy Estes  <aestes@apple.com>
3553
3554         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3555         https://bugs.webkit.org/show_bug.cgi?id=174631
3556
3557         Reviewed by Sam Weinig.
3558
3559         * Configurations/Base.xcconfig:
3560
3561 2017-07-18  Andy Estes  <aestes@apple.com>
3562
3563         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3564         https://bugs.webkit.org/show_bug.cgi?id=174631
3565
3566         Reviewed by Dan Bernstein.
3567
3568         * Configurations/Base.xcconfig:
3569
3570 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3571
3572         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
3573         https://bugs.webkit.org/show_bug.cgi?id=174640
3574         <rdar://problem/33297400>
3575
3576         Reviewed by Tim Horton.
3577
3578         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
3579         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
3580         web thread here, to match the other WebView drag and drop SPI methods.
3581
3582         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
3583         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
3584         should make this robust against future UIKit changes that could make this no longer the case.
3585
3586         * WebView/WebView.mm:
3587         (-[WebView _requestStartDataInteraction:globalPosition:]):
3588         (-[WebView _dataInteractionCaretRect]):
3589
3590 2017-07-18  Andy Estes  <aestes@apple.com>
3591
3592         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3593         https://bugs.webkit.org/show_bug.cgi?id=174631
3594
3595         Reviewed by Darin Adler.
3596
3597         * Configurations/Base.xcconfig:
3598
3599 2017-07-17  Sam Weinig  <sam@webkit.org>
3600
3601         [WebIDL] Remove custom bindings that require non-caching JS strings
3602         https://bugs.webkit.org/show_bug.cgi?id=174552
3603
3604         Reviewed by Darin Adler.
3605
3606         * DOM/DOMHTMLCanvasElement.mm:
3607         (-[DOMHTMLCanvasElement toDataURL:]):
3608         Update to account for implementation now returning an UncachedString.
3609
3610 2017-07-17  Darin Adler  <darin@apple.com>
3611
3612         Improve use of NeverDestroyed
3613         https://bugs.webkit.org/show_bug.cgi?id=174348
3614
3615         Reviewed by Sam Weinig.
3616
3617         * Misc/WebStringTruncator.mm:
3618         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
3619         NeverDestroyed<RetainPtr> with just an NSFont * global.
3620
3621         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
3622         NeverDestroyed.h.
3623         * Storage/WebDatabaseManager.mm: Ditto.
3624         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
3625         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
3626
3627         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
3628         (aeDescFromJSValue): Removed double hashing by using the return value from
3629         add rather than calling contains before calling add.
3630
3631 2017-07-14  Jer Noble  <jer.noble@apple.com>
3632
3633         Allow clients to override their own hardware media requirements where no fallback media exists.
3634         https://bugs.webkit.org/show_bug.cgi?id=174426
3635         <rdar://problem/32537704>
3636
3637         Reviewed by Eric Carlson.
3638
3639         Add a new WebPreferences property to control WebCore's new
3640         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
3641
3642         * WebView/WebPreferenceKeysPrivate.h:
3643         * WebView/WebPreferences.mm:
3644         (+[WebPreferences initialize]):
3645         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
3646         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
3647         * WebView/WebPreferencesPrivate.h:
3648         * WebView/WebView.mm:
3649         (-[WebView _preferencesChanged:]):
3650
3651 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
3652
3653         Async image decoding for large images should be disabled by default
3654         https://bugs.webkit.org/show_bug.cgi?id=174432
3655
3656         Reviewed by Simon Fraser.
3657
3658         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
3659         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
3660         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
3661            a child view instead of propagating PaintBehaviorSnapshotting.
3662         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
3663            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
3664
3665         * WebView/WebFrame.mm:
3666         (-[WebFrame _paintBehaviorForDestinationContext:]):
3667         (-[WebFrame _drawRect:contentsOnly:]):
3668         * WebView/WebHTMLView.mm:
3669         (imageFromRect):
3670
3671 2017-07-12  Daniel Bates  <dabates@apple.com>
3672
3673         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3674         https://bugs.webkit.org/show_bug.cgi?id=174427
3675
3676         Rubber-stamped by Brady Eidson.
3677
3678         * WebView/WebPDFView.mm:
3679         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3680
3681 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3682
3683         Unreviewed, rolling out r219401.
3684
3685         This revision rolled out the previous patch, but after talking
3686         with reviewer, a rebaseline is what was needed.Rolling back in
3687         before rebaseline.
3688
3689         Reverted changeset:
3690
3691         "Unreviewed, rolling out r219379."
3692         https://bugs.webkit.org/show_bug.cgi?id=174400
3693         http://trac.webkit.org/changeset/219401
3694
3695 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3696
3697         Unreviewed, rolling out r219379.
3698
3699         This revision caused a consistent failure in the test
3700         fast/dom/Window/property-access-on-cached-window-after-frame-
3701         removed.html.
3702
3703         Reverted changeset:
3704
3705         "Remove NAVIGATOR_HWCONCURRENCY"
3706         https://bugs.webkit.org/show_bug.cgi?id=174400
3707         http://trac.webkit.org/changeset/219379
3708
3709 2017-07-11  Dean Jackson  <dino@apple.com>
3710
3711         Remove NAVIGATOR_HWCONCURRENCY
3712         https://bugs.webkit.org/show_bug.cgi?id=174400
3713
3714         * Configurations/FeatureDefines.xcconfig:
3715
3716 2017-07-11  Dean Jackson  <dino@apple.com>
3717
3718         Rolling out r219372.
3719
3720         * Configurations/FeatureDefines.xcconfig:
3721
3722 2017-07-11  Dean Jackson  <dino@apple.com>
3723
3724         Remove NAVIGATOR_HWCONCURRENCY
3725         https://bugs.webkit.org/show_bug.cgi?id=174400
3726
3727         * Configurations/FeatureDefines.xcconfig:
3728
3729 2017-07-03  Brian Burg  <bburg@apple.com>
3730
3731         Web Replay: remove some unused code
3732         https://bugs.webkit.org/show_bug.cgi?id=173903
3733
3734         Rubber-stamped by Joseph Pecoraro.
3735
3736         * Configurations/FeatureDefines.xcconfig:
3737
3738 2017-07-09  Brady Eidson  <beidson@apple.com>
3739
3740         Remove some obsolete WebKitVersionChecks.
3741         https://bugs.webkit.org/show_bug.cgi?id=174294
3742
3743         Reviewed by Dan Bernstein.
3744
3745         * Misc/WebKitVersionChecks.h:
3746
3747         * WebView/WebHTMLView.mm:
3748         (-[WebHTMLView hitTest:]):
3749
3750         * WebView/WebView.mm:
3751         (shouldRespectPriorityInCSSAttributeSetters):
3752         (-[WebView _commonInitializationWithFrameName:groupName:]):
3753         (-[WebView _preferencesChanged:]):
3754         (shouldTransformsAffectOverflow): Deleted.
3755         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
3756
3757 2017-07-08  Brady Eidson  <beidson@apple.com>
3758
3759         Remove some obsolete RuntimeApplicationChecks.
3760         https://bugs.webkit.org/show_bug.cgi?id=174293
3761
3762         Reviewed by Dan Bernstein.
3763
3764         * Misc/WebKitVersionChecks.h:
3765         * WebView/WebView.mm:
3766         (+[WebView enableWebThread]):
3767         (-[WebView _needsPreHTML5ParserQuirks]):
3768
3769 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3770
3771         Drop NOSNIFF compile flag
3772         https://bugs.webkit.org/show_bug.cgi?id=174289
3773
3774         Reviewed by Michael Catanzaro.
3775
3776         * Configurations/FeatureDefines.xcconfig:
3777
3778 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3779
3780         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3781         https://bugs.webkit.org/show_bug.cgi?id=174150
3782
3783         Reviewed by Mark Lam.
3784
3785         * DOM/DOM.mm:
3786         (lookupElementClass):
3787
3788 2017-07-06  Brady Eidson  <beidson@apple.com>
3789
3790         Add logging to first attempt to use the WebIconDatabase class.
3791         https://bugs.webkit.org/show_bug.cgi?id=174190
3792
3793         Reviewed by Andy Estes.
3794
3795         * Misc/WebIconDatabase.mm:
3796         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
3797         * Misc/WebKitVersionChecks.h:
3798
3799 2017-07-06  Matt Lewis  <jlewis3@apple.com>
3800
3801         Unreviewed, rolling out r219178.
3802
3803         This caused a consistent failure with the API test
3804         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
3805
3806         Reverted changeset:
3807
3808         "[WTF] Clean up StringStatics.cpp by using
3809         LazyNeverDestroyed<> for Atoms"
3810         https://bugs.webkit.org/show_bug.cgi?id=174150
3811         http://trac.webkit.org/changeset/219178
3812
3813 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3814
3815         [WTF] Move SoftLinking.h into WTF
3816         https://bugs.webkit.org/show_bug.cgi?id=174000
3817
3818         Reviewed by Alex Christensen.
3819
3820         * Plugins/WebNetscapePluginView.mm:
3821         * Plugins/WebPluginController.mm:
3822         * WebCoreSupport/WebInspectorClient.mm:
3823         * WebView/WebFullScreenController.mm:
3824         * WebView/WebImmediateActionController.mm:
3825         * WebView/WebView.mm:
3826
3827 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3828
3829         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3830         https://bugs.webkit.org/show_bug.cgi?id=174150
3831
3832         Reviewed by Mark Lam.
3833
3834         * DOM/DOM.mm:
3835         (lookupElementClass):
3836
3837 2017-07-05  Brady Eidson  <beidson@apple.com>
3838
3839         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3840         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3841
3842         Reviewed by Alex Christensen.
3843
3844         Adopt to the new constructor for FrameLoadRequest.
3845
3846         * WebView/WebPDFView.mm:
3847         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3848
3849 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3850
3851         Make WebKit's public headers on Mac and iOS C++ module safe
3852         https://bugs.webkit.org/show_bug.cgi?id=174175
3853
3854         Reviewed by Alex Christensen.
3855
3856         Fixed the header files.
3857
3858         * Misc/WebDownload.h:
3859         * Misc/WebKitErrors.h:
3860         * Plugins/WebPluginContainer.h:
3861         * WebView/WebResourceLoadDelegate.h:
3862
3863 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3864
3865         Remove copy of ICU headers from WebKit
3866         https://bugs.webkit.org/show_bug.cgi?id=116407
3867
3868         Reviewed by Alex Christensen.
3869
3870         Use WTF's copy of ICU headers.
3871
3872         * Configurations/WebKitLegacy.xcconfig:
3873         * icu/unicode/localpointer.h: Removed.
3874         * icu/unicode/parseerr.h: Removed.
3875         * icu/unicode/platform.h: Removed.
3876         * icu/unicode/ptypes.h: Removed.
3877         * icu/unicode/putil.h: Removed.
3878         * icu/unicode/uchar.h: Removed.
3879         * icu/unicode/uconfig.h: Removed.
3880         * icu/unicode/ucurr.h: Removed.
3881         * icu/unicode/uidna.h: Removed.
3882         * icu/unicode/uiter.h: Removed.
3883         * icu/unicode/umachine.h: Removed.
3884         * icu/unicode/unorm.h: Removed.
3885         * icu/unicode/unorm2.h: Removed.
3886         * icu/unicode/urename.h: Removed.
3887         * icu/unicode/uscript.h: Removed.
3888         * icu/unicode/ustring.h: Removed.
3889         * icu/unicode/utf.h: Removed.
3890         * icu/unicode/utf16.h: Removed.
3891         * icu/unicode/utf8.h: Removed.
3892         * icu/unicode/utf_old.h: Removed.
3893         * icu/unicode/utypes.h: Removed.
3894         * icu/unicode/uvernum.h: Removed.
3895         * icu/unicode/uversion.h: Removed.
3896
3897 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3898
3899         Add WebKitPrivateFrameworkStubs for iOS 11
3900         https://bugs.webkit.org/show_bug.cgi?id=173988
3901
3902         Reviewed by David Kilzer.
3903
3904         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
3905         use the same directory for private framework stubs.
3906
3907 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3908
3909         Unreviewed, rolling out r219103.
3910
3911         Caused multiple build failures.
3912
3913         Reverted changeset:
3914
3915         "Remove copy of ICU headers from WebKit"
3916         https://bugs.webkit.org/show_bug.cgi?id=116407
3917         http://trac.webkit.org/changeset/219103
3918
3919 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3920
3921         Remove copy of ICU headers from WebKit
3922         https://bugs.webkit.org/show_bug.cgi?id=116407
3923
3924         Reviewed by Alex Christensen.
3925
3926         Use WTF's copy of ICU headers.
3927
3928         * Configurations/WebKitLegacy.xcconfig:
3929         * icu/unicode/localpointer.h: Removed.
3930         * icu/unicode/parseerr.h: Removed.
3931         * icu/unicode/platform.h: Removed.
3932         * icu/unicode/ptypes.h: Removed.
3933         * icu/unicode/putil.h: Removed.
3934         * icu/unicode/uchar.h: Removed.
3935         * icu/unicode/uconfig.h: Removed.
3936         * icu/unicode/ucurr.h: Removed.
3937         * icu/unicode/uidna.h: Removed.
3938         * icu/unicode/uiter.h: Removed.
3939         * icu/unicode/umachine.h: Removed.
3940         * icu/unicode/unorm.h: Removed.
3941         * icu/unicode/unorm2.h: Removed.
3942         * icu/unicode/urename.h: Removed.
3943         * icu/unicode/uscript.h: Removed.
3944         * icu/unicode/ustring.h: Removed.
3945         * icu/unicode/utf.h: Removed.
3946         * icu/unicode/utf16.h: Removed.
3947         * icu/unicode/utf8.h: Removed.
3948         * icu/unicode/utf_old.h: Removed.
3949         * icu/unicode/utypes.h: Removed.
3950         * icu/unicode/uvernum.h: Removed.
3951         * icu/unicode/uversion.h: Removed.
3952
3953 2017-07-03  Brady Eidson  <beidson@apple.com>
3954
3955         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3956         https://bugs.webkit.org/show_bug.cgi?id=174073
3957
3958         Reviewed by Andy Estes.
3959
3960         WebView now keeps a direct copy of its main frame icon as a member variable.
3961         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
3962         
3963         This change causes a progression in KVO observation of the mainFrameIcon property as we now
3964         have both the old icon and new icon at the time it changes.
3965
3966         * WebCoreSupport/WebFrameLoaderClient.h:
3967         * WebCoreSupport/WebFrameLoaderClient.mm:
3968         (WebFrameLoaderClient::prepareForDataSourceReplacement):
3969         (WebFrameLoaderClient::getLoadDecisionForIcons):
3970         (WebFrameLoaderClient::finishedLoadingIcon):
3971         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3972         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3973
3974         * WebView/WebView.mm:
3975         (+[WebView _setIconLoadingEnabled:]):
3976         (+[WebView _isIconLoadingEnabled]):
3977         (-[WebView mainFrameIcon]):
3978         (-[WebView _setMainFrameIcon:]):
3979         (-[WebView _receivedIconChangedNotification:]): Deleted.
3980         (-[WebView _registerForIconNotification:]): Deleted.
3981         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
3982         * WebView/WebViewData.h:
3983         * WebView/WebViewInternal.h:
3984         * WebView/WebViewPrivate.h:
3985
3986 2017-07-03  Sam Weinig  <sam@webkit.org>
3987
3988         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
3989         https://bugs.webkit.org/show_bug.cgi?id=174083
3990
3991         Reviewed by Alex Christensen.
3992
3993         * Configurations/FeatureDefines.xcconfig:
3994         Add ENABLE_NAVIGATOR_STANDALONE.
3995
3996 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3997
3998         Expose unobscuredSafeAreaInsets on WebView
3999         https://bugs.webkit.org/show_bug.cgi?id=174075
4000         <rdar://problem/33096997>
4001
4002         Reviewed by Beth Dakin.
4003
4004         * WebView/WebView.mm:
4005         (-[WebView _setUnobscuredSafeAreaInsets:]):
4006         (-[WebView _unobscuredSafeAreaInsets]):
4007         * WebView/WebViewPrivate.h:
4008         Expose unobscuredSafeAreaInsets as a new private property on WebView,
4009         similar to how it is exposed in WebKit2.
4010
4011 2017-07-03  Andy Estes  <aestes@apple.com>
4012
4013         [Xcode] Add an experimental setting to build with ccache
4014         https://bugs.webkit.org/show_bug.cgi?id=173875
4015
4016         Reviewed by Tim Horton.
4017
4018         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
4019
4020 2017-07-03  Tim Horton  <timothy_horton@apple.com>
4021
4022         Expose WebPreferences for viewport-fit and constant() properties
4023         https://bugs.webkit.org/show_bug.cgi?id=174072
4024         <rdar://problem/33096639>
4025
4026         Reviewed by Ryosuke Niwa.
4027
4028         * WebView/WebPreferenceKeysPrivate.h:
4029         * WebView/WebPreferences.mm:
4030         (-[WebPreferences viewportFitEnabled]):
4031         (-[WebPreferences setViewportFitEnabled:]):
4032         (-[WebPreferences constantPropertiesEnabled]):
4033         (-[WebPreferences setConstantPropertiesEnabled:]):
4034         * WebView/WebPreferencesPrivate.h:
4035         * WebView/WebView.mm:
4036         (-[WebView _preferencesChanged:]):
4037
4038 2017-07-01  Tim Horton  <timothy_horton@apple.com>
4039
4040         Expose viewport-fit value to UIKit via viewport arguments dictionary
4041         https://bugs.webkit.org/show_bug.cgi?id=174071
4042         <rdar://problem/33096620>
4043
4044         Reviewed by Wenson Hsieh.
4045
4046         * History/WebHistoryItem.mm:
4047         * History/WebHistoryItemPrivate.h:
4048         Add another dictionary key and three values.
4049
4050 2017-07-01  Dan Bernstein  <mitz@apple.com>
4051
4052         [iOS] Remove code only needed when building for iOS 9.x
4053         https://bugs.webkit.org/show_bug.cgi?id=174068
4054
4055         Reviewed by Tim Horton.
4056
4057         * Configurations/FeatureDefines.xcconfig:
4058
4059 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
4060
4061         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
4062         https://bugs.webkit.org/show_bug.cgi?id=174004
4063
4064         Reviewed by Simon Fraser.
4065
4066         * WebCoreSupport/WebPluginInfoProvider.mm:
4067
4068 2017-07-01  Dan Bernstein  <mitz@apple.com>
4069
4070         [macOS] Remove code only needed when building for OS X Yosemite
4071         https://bugs.webkit.org/show_bug.cgi?id=174067
4072
4073         Reviewed by Tim Horton.
4074
4075         * Configurations/Base.xcconfig:
4076         * Configurations/DebugRelease.xcconfig:
4077         * Configurations/FeatureDefines.xcconfig:
4078         * Configurations/Version.xcconfig:
4079         * Plugins/WebBasePluginPackage.mm:
4080         (-[WebBasePluginPackage getPluginInfoFromPLists]):
4081         * WebCoreSupport/PopupMenuMac.mm:
4082         (PopupMenuMac::show):