[Attachment Support] Create attachment elements when dropping files on iOS
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         [Attachment Support] Create attachment elements when dropping files on iOS
4         https://bugs.webkit.org/show_bug.cgi?id=181192
5         <rdar://problem/36280945>
6
7         Reviewed by Tim Horton.
8
9         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
10
11         * WebCoreSupport/WebPlatformStrategies.h:
12         * WebCoreSupport/WebPlatformStrategies.mm:
13         (WebPlatformStrategies::informationForItemAtIndex):
14         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
15
16 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
17
18         [Attachment Support] Add plumbing for starting a drag with promised blob data
19         https://bugs.webkit.org/show_bug.cgi?id=181201
20
21         Reviewed by Tim Horton.
22
23         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
24
25         * WebCoreSupport/WebDragClient.h:
26
27 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
28
29         Add a WebAuthentication runtime feature flag
30         https://bugs.webkit.org/show_bug.cgi?id=181220
31         <rdar://problem/36055305>
32
33         Reviewed by Brent Fulgham.
34
35         Renames the CredentialManagement runtime feature flag into WebAuthentication.
36
37         * WebView/WebPreferenceKeysPrivate.h:
38         * WebView/WebPreferences.mm:
39         (+[WebPreferences initialize]):
40         (-[WebPreferences webAuthenticationEnabled]):
41         (-[WebPreferences setWebAuthenticationEnabled:]):
42         (-[WebPreferences credentialManagementEnabled]): Deleted.
43         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
44         * WebView/WebPreferencesPrivate.h:
45         * WebView/WebView.mm:
46         (-[WebView _preferencesChanged:]):
47
48 2017-12-22  Jeff Miller  <jeffm@apple.com>
49
50         Update user-visible copyright strings to include 2018
51         https://bugs.webkit.org/show_bug.cgi?id=181141
52
53         Reviewed by Dan Bernstein.
54
55         * Info.plist:
56
57 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
58
59         [Attachment Support] Remove current macOS support for dragging file-backed attachments
60         https://bugs.webkit.org/show_bug.cgi?id=181188
61
62         Reviewed by Dan Bernstein.
63
64         See WebCore/ChangeLog for more detail.
65
66         * WebCoreSupport/WebDragClient.h:
67         * WebCoreSupport/WebDragClient.mm:
68         (WebDragClient::declareAndWriteAttachment): Deleted.
69         * WebView/WebHTMLView.mm:
70         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
71
72 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
73
74         Unreviewed, continue to fix build failures due to AppKit API deprecation
75
76         Wraps more code in -Wdeprecated-declarations.
77
78         * Carbon/HIWebView.mm:
79         (overrideCGContext):
80
81 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
82
83         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
84
85         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
86
87         * Carbon/CarbonWindowAdapter.mm:
88         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
89         * Plugins/WebNetscapePluginView.mm:
90         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
91         (-[WebNetscapePluginView sendDrawRectEvent:]):
92         (-[WebNetscapePluginView drawRect:]):
93
94 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
95
96         Fix build failures due to using deprecated AppKit symbols
97         https://bugs.webkit.org/show_bug.cgi?id=181110
98         <rdar://problem/36162865>
99
100         Reviewed by Dan Bernstein and Tim Horton.
101
102         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
103
104         * Misc/WebKitNSStringExtras.mm:
105         (-[NSString _web_drawAtPoint:font:textColor:]):
106         * Misc/WebNSPasteboardExtras.h:
107         * Misc/WebNSPasteboardExtras.mm:
108         (+[NSPasteboard _web_writableTypesForURL]):
109         (_createWritableTypesForImageWithoutArchive):
110         (_createWritableTypesForImageWithArchive):
111         (+[NSPasteboard _web_dragTypesForURL]):
112         (-[NSPasteboard _web_bestURL]):
113         (-[NSPasteboard _web_writeURL:andTitle:types:]):
114         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
115         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
116         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
117         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
118         * Panels/WebAuthenticationPanel.m:
119         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
120         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
121         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
122         (-[WebHostedNetscapePluginView drawRect:]):
123         * WebInspector/WebNodeHighlightView.mm:
124         (-[WebNodeHighlightView drawRect:]):
125         * WebView/WebFrame.mm:
126         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
127         (-[WebFrame _drawRect:contentsOnly:]):
128         * WebView/WebHTMLView.mm:
129         (kit):
130         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
131         (-[WebHTMLView _plainTextFromPasteboard:]):
132         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
133         (+[WebHTMLView _insertablePasteboardTypes]):
134         (+[WebHTMLView _selectionPasteboardTypes]):
135         (-[WebHTMLView pasteboard:provideDataForType:]):
136         (-[WebHTMLView _writeSelectionToPasteboard:]):
137         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
138         (-[WebHTMLView validRequestorForSendType:returnType:]):
139         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
140         (createMenuItem):
141         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
142         (-[WebHTMLView _colorAsString:]):
143         (-[WebHTMLView copyFont:]):
144         * WebView/WebPDFView.mm:
145         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
146         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
147         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
148         (-[WebPDFView pasteboardTypesForSelection]):
149         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
150         * WebView/WebView.h:
151         * WebView/WebView.mm:
152         (-[WebView performDragOperation:]):
153         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
154         (-[WebView _searchWithGoogleFromMenu:]):
155
156 2017-12-21  Youenn Fablet  <youenn@apple.com>
157
158         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
159         https://bugs.webkit.org/show_bug.cgi?id=181000
160
161         Reviewed by Chris Dumez.
162
163         * Misc/WebCache.mm:
164         (+[WebCache addImageToCache:forURL:forFrame:]):
165
166 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
167
168         Update FULLSCREEN_API feature defines.
169         https://bugs.webkit.org/show_bug.cgi?id=181015
170
171         Reviewed by Tim Horton.
172
173         Change enabled iphone sdk for FULLSCREEN_API.
174
175         * Configurations/FeatureDefines.xcconfig:
176
177 2017-12-21  Jer Noble  <jer.noble@apple.com>
178
179         Add initial DOM support for Media Capabilities
180         https://bugs.webkit.org/show_bug.cgi?id=181064
181
182         Reviewed by Eric Carlson.
183
184         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
185
186         * WebView/WebPreferenceKeysPrivate.h:
187         * WebView/WebPreferences.mm:
188         (+[WebPreferences initialize]):
189         (-[WebPreferences mediaCapabilitiesEnabled]):
190         (-[WebPreferences setMediaCapabilitiesEnabled:]):
191         * WebView/WebPreferencesPrivate.h:
192         * WebView/WebView.mm:
193         (-[WebView _preferencesChanged:]):
194
195 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
196
197         Enable picture-in-picture from inline element on suspend.
198         https://bugs.webkit.org/show_bug.cgi?id=180942
199         rdar://problem/34745234
200
201         Reviewed by Jer Noble.
202
203         Update signature of enterVideoFullscreenForVideoElement().
204
205         * WebCoreSupport/WebChromeClient.h:
206         * WebCoreSupport/WebChromeClient.mm:
207         (WebChromeClient::enterVideoFullscreenForVideoElement):
208
209 2017-12-20  Daniel Bates  <dabates@apple.com>
210
211         Remove Alternative Presentation Button
212         https://bugs.webkit.org/show_bug.cgi?id=180500
213         <rdar://problem/35891047>
214
215         Reviewed by Simon Fraser.
216
217         We no longer need the alternative presentation button.
218
219         * Configurations/FeatureDefines.xcconfig:
220
221 2017-12-19  Jer Noble  <jer.noble@apple.com>
222
223         Playing media elements which call "pause(); play()" will have the play promise rejected.
224         https://bugs.webkit.org/show_bug.cgi?id=180781
225         <rdar://problem/33191377>
226
227         Reviewed by Eric Carlson.
228
229         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
230
231         * WebView/WebView.mm:
232         (shouldRequireUserGestureToLoadVideo):
233
234 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
235
236         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
237         https://bugs.webkit.org/show_bug.cgi?id=180977
238
239         Reviewed by Tim Horton.
240
241         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
242         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
243         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
244
245         * WebCoreSupport/WebEditorClient.mm:
246         (attributesForAttributedStringConversion):
247         * WebView/WebHTMLView.mm:
248         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
249
250 2017-12-18  David Kilzer  <ddkilzer@apple.com>
251
252         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
253
254         Attempt to fix the following warnings:
255
256             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
257
258         For the following instance variables:
259
260             _borderView
261             _contentView
262             _frame
263             _wFlags
264
265         * Carbon/CarbonWindowAdapter.mm:
266         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
267         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
268         (-[CarbonWindowAdapter _termWindowIfOwner]):
269         (-[CarbonWindowAdapter _windowMovedToRect:]):
270         (-[CarbonWindowAdapter setContentView:]):
271         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
272         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
273
274 2017-12-16  Dan Bernstein  <mitz@apple.com>
275
276         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
277         https://bugs.webkit.org/show_bug.cgi?id=180613
278         <rdar://problem/35946124>
279
280         Reviewed by Geoff Garen.
281
282         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
283           clients.
284         * WebView/WebDynamicScrollBarsView.h: Ditto.
285         * WebView/WebDynamicScrollBarsView.mm: Ditto.
286
287 2017-12-14  David Kilzer  <ddkilzer@apple.com>
288
289         Enable -Wstrict-prototypes for WebKit
290         <https://webkit.org/b/180757>
291         <rdar://problem/36024132>
292
293         Rubber-stamped by Joseph Pecoraro.
294
295         * Configurations/Base.xcconfig:
296         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
297
298 2017-12-14  John Wilander  <wilander@apple.com>
299
300         Storage Access API: Implement frame-specific access in the document.cookie layer
301         https://bugs.webkit.org/show_bug.cgi?id=180682
302         <rdar://problem/35982257>
303
304         Reviewed by Alex Christensen.
305
306         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
307         CookiesStrategy::cookieRequestHeaderFieldValue(), and
308         CookiesStrategy::getRawCookies() now take optional parameters for
309         frameID and pageID to allow frame-specific scoping of cookies.
310
311         This change makes the return values of FrameLoaderClient::frameID()
312         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
313         WebCore can call those getters and get the right return values in
314         WebKit and std:nullopt in WebKitLegacy.
315
316         * WebCoreSupport/WebFrameLoaderClient.h:
317         * WebCoreSupport/WebFrameLoaderClient.mm:
318         (WebFrameLoaderClient::pageID const):
319         (WebFrameLoaderClient::frameID const):
320         * WebCoreSupport/WebPlatformStrategies.h:
321         * WebCoreSupport/WebPlatformStrategies.mm:
322         (WebPlatformStrategies::cookiesForDOM):
323         (WebPlatformStrategies::setCookiesFromDOM):
324         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
325         (WebPlatformStrategies::getRawCookies):
326
327 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
328
329         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
330         https://bugs.webkit.org/show_bug.cgi?id=180689
331
332         Reviewed by Tim Horton.
333
334         Use sRGBColorSpaceRef() from WebCore.
335
336         * WebView/WebHTMLView.mm:
337         (imageFromRect):
338
339 2017-12-11  Tim Horton  <timothy_horton@apple.com>
340
341         Stop using deprecated target conditional for simulator builds
342         https://bugs.webkit.org/show_bug.cgi?id=180662
343         <rdar://problem/35136156>
344
345         Reviewed by Simon Fraser.
346
347         * postprocess-headers.sh:
348
349 2017-12-11  David Quesada  <david_quesada@apple.com>
350
351         Turn on ENABLE_APPLICATION_MANIFEST
352         https://bugs.webkit.org/show_bug.cgi?id=180562
353         rdar://problem/35924737
354
355         Reviewed by Geoffrey Garen.
356
357         * Configurations/FeatureDefines.xcconfig:
358
359 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
360
361         Remove pthread_once in favor of dispatch_once
362         https://bugs.webkit.org/show_bug.cgi?id=180591
363
364         Reviewed by Saam Barati.
365
366         * Misc/WebKitErrors.m:
367         (+[NSError _registerWebKitErrors]):
368         (registerErrors): Deleted.
369         * Storage/WebStorageManager.mm:
370         (+[WebStorageManager _storageDirectoryPath]):
371         (initializeLocalStoragePath): Deleted.
372
373 2017-12-07  Darin Adler  <darin@apple.com>
374
375         Remove some unused code from WebKitLegacy
376         https://bugs.webkit.org/show_bug.cgi?id=180567
377
378         Reviewed by Anders Carlsson.
379
380         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
381         macOS (back a few versions) and iOS and removed unused
382         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
383         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
384         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
385         _webkit_stringByCollapsingNonPrintingCharacters,
386         _webkit_stringByCollapsingWhitespaceCharacters,
387         _web_stringWithData:textEncodingName:, and
388         _webkit_localStorageDirectoryWithBundleIdentifier:.
389
390         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
391         this source file.
392         (canUseFastRenderer): Made this faster by not calling u_charDirection for
393         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
394         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
395         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
396         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
397         handle font smoothing options.
398         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
399         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
400         from header and made it a little clearer.
401         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
402         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
403         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
404         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
405         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
406         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
407         implementation a bit and used whole words instead of abbreviations.
408         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
409
410         * Misc/WebNSFileManagerExtras.mm:
411         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
412         filenameByFixingIllegalCharacters function from WebCore directly instead of
413         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
414
415         * Plugins/WebBaseNetscapePluginView.mm:
416         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
417         string replacements instead of _web_stringByStrippingReturnCharacters
418         and to use NSString methods instead of CFString functions.
419
420 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
421
422         Ignore deprecation warnings.
423
424         * WebView/WebHTMLView.mm:
425         (-[NSWindow _web_borderView]):
426         (-[WebHTMLView _setAsideSubviews]):
427         * WebView/WebView.mm:
428         (-[WebView encodeWithCoder:]):
429
430 2017-12-02  Darin Adler  <darin@apple.com>
431
432         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
433         https://bugs.webkit.org/show_bug.cgi?id=180009
434
435         Reviewed by Alex Christensen.
436
437         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
438
439         * Plugins/WebBaseNetscapePluginView.mm:
440         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
441         of strcasecmp.
442
443         * WebView/WebPreferences.mm:
444         (contains): Ditto. Also made this a template so it's easier to call on an array.
445         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
446
447 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
448
449         Limit user agent versioning to an upper bound
450         https://bugs.webkit.org/show_bug.cgi?id=180365
451         <rdar://problem/34550617>
452
453         Reviewed by Joseph Pecoraro.
454
455         * WebView/WebView.mm:
456         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
457         creating the User Agent string.
458         (webKitBundleVersionString): Deleted.
459
460 2017-12-05  Andy Estes  <aestes@apple.com>
461
462         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
463         https://bugs.webkit.org/show_bug.cgi?id=180457
464         <rdar://problem/35143007>
465
466         Reviewed by Tim Horton.
467
468         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
469         check for this macro during post-processing.
470
471         * postprocess-headers.sh:
472
473 2017-12-04  David Quesada  <david_quesada@apple.com>
474
475         Add a class for parsing application manifests
476         https://bugs.webkit.org/show_bug.cgi?id=177973
477         rdar://problem/34747949
478
479         Reviewed by Geoffrey Garen.
480
481         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
482
483 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
484
485         Make LegacyCustomProtocolManager optional for network process
486         https://bugs.webkit.org/show_bug.cgi?id=176230
487
488         Reviewed by Alex Christensen.
489
490         * Configurations/FeatureDefines.xcconfig:
491
492 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
493
494         Fix some NSOperationQueue leaks
495         https://bugs.webkit.org/show_bug.cgi?id=180221
496
497         Reviewed by Wenson Hsieh.
498
499         * WebView/WebView.mm:
500         (-[WebView performDragOperation:]):
501
502 2017-11-30  Darin Adler  <darin@apple.com>
503
504         [Mac] remove unneeded RetainPtr use introduced in r225142
505         https://bugs.webkit.org/show_bug.cgi?id=180202
506
507         Reviewed by Tim Horton.
508
509         * WebView/WebImmediateActionController.mm:
510         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
511         RetainPtr.
512
513 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
514
515         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
516         https://bugs.webkit.org/show_bug.cgi?id=175595
517
518         Reviewed by Darin Adler.
519
520         * WebView/WebPreferences.mm:
521
522 2017-11-27  Tim Horton  <timothy_horton@apple.com>
523
524         One too many zeroes in macOS version number in FeatureDefines
525         https://bugs.webkit.org/show_bug.cgi?id=180011
526
527         Reviewed by Dan Bernstein.
528
529         * Configurations/FeatureDefines.xcconfig:
530
531 2017-11-23  Darin Adler  <darin@apple.com>
532
533         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
534         https://bugs.webkit.org/show_bug.cgi?id=179981
535
536         Reviewed by Sam Weinig.
537
538         * WebView/WebImmediateActionController.mm:
539         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
540         * WebView/WebView.mm:
541         (coreOptions): Use |= instead of | to build up FindOptions.
542
543 2017-11-23  Sam Weinig  <sam@webkit.org>
544
545         Remove unneeded ScriptController::processingUserGesture() forwarding functions
546         https://bugs.webkit.org/show_bug.cgi?id=179954
547
548         Reviewed by Darin Adler.
549
550         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
551         with direct calls to the corresponding UserGestureIndicator functions.
552
553         * Plugins/WebPluginController.mm:
554         (-[WebPluginController processingUserGesture]):
555         * WebView/WebView.mm:
556         (-[WebView _isProcessingUserGesture]):
557
558 2017-11-23  Darin Adler  <darin@apple.com>
559
560         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
561         https://bugs.webkit.org/show_bug.cgi?id=179907
562
563         Reviewed by Sam Weinig.
564
565         * History/BinaryPropertyList.cpp:
566         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
567         (BinaryPropertyListSerializer::appendStringObject): Ditto.
568         * WebView/WebHTMLRepresentation.mm:
569         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
570         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
571
572 2017-11-22  Ali Juma  <ajuma@chromium.org>
573
574         Implement VisualViewport API attributes
575         https://bugs.webkit.org/show_bug.cgi?id=179385
576
577         Reviewed by Frédéric Wang.
578
579         Add a VisualViewportAPI preference.
580
581         * WebView/WebPreferenceKeysPrivate.h:
582         * WebView/WebPreferences.mm:
583         (+[WebPreferences initialize]):
584         (-[WebPreferences visualViewportAPIEnabled]):
585         (-[WebPreferences setVisualViewportAPIEnabled:]):
586         * WebView/WebPreferencesPrivate.h:
587         * WebView/WebView.mm:
588         (-[WebView _preferencesChanged:]):
589
590 2017-11-22  Christopher Reid  <chris.reid@sony.com>
591
592         WebCoreObjCExtras.h is being included in too many places
593         https://bugs.webkit.org/show_bug.cgi?id=179931
594
595         Reviewed by Darin Adler.
596
597         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
598         * Plugins/WebBaseNetscapePluginView.mm:
599         * Plugins/WebBasePluginPackage.mm:
600         * Plugins/WebNetscapePluginStream.mm:
601         * Plugins/WebNetscapePluginView.mm:
602         * WebView/WebTextIterator.mm:
603         * WebView/WebViewData.mm:
604
605 2017-11-22  Commit Queue  <commit-queue@webkit.org>
606
607         Unreviewed, rolling out r225093.
608         https://bugs.webkit.org/show_bug.cgi?id=179938
609
610         Compilation failed on WinCairo 64-bit Release (Requested by
611         fredw on #webkit).
612
613         Reverted changeset:
614
615         "Implement VisualViewport API attributes"
616         https://bugs.webkit.org/show_bug.cgi?id=179385
617         https://trac.webkit.org/changeset/225093
618
619 2017-11-21  Ali Juma  <ajuma@chromium.org>
620
621         Implement VisualViewport API attributes
622         https://bugs.webkit.org/show_bug.cgi?id=179385
623
624         Reviewed by Frédéric Wang.
625
626         Add a VisualViewportAPI preference.
627
628         * WebView/WebPreferenceKeysPrivate.h:
629         * WebView/WebPreferences.mm:
630         (+[WebPreferences initialize]):
631         (-[WebPreferences visualViewportAPIEnabled]):
632         (-[WebPreferences setVisualViewportAPIEnabled:]):
633         * WebView/WebPreferencesPrivate.h:
634         * WebView/WebView.mm:
635         (-[WebView _preferencesChanged:]):
636
637 2017-11-21  Christopher Reid  <chris.reid@sony.com>
638
639         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
640         https://bugs.webkit.org/show_bug.cgi?id=179504
641
642         Reviewed by Darin Adler.
643
644         * Misc/WebKitNSStringExtras.mm:
645         * Plugins/Hosted/NetscapePluginHostManager.mm:
646         * Plugins/WebBasePluginPackage.mm:
647
648 2017-11-19  Tim Horton  <timothy_horton@apple.com>
649
650         Remove unused TOUCH_ICON_LOADING feature flag
651         https://bugs.webkit.org/show_bug.cgi?id=179873
652
653         Reviewed by Simon Fraser.
654
655         * Configurations/FeatureDefines.xcconfig:
656
657 2017-11-19  Tim Horton  <timothy_horton@apple.com>
658
659         Remove unused LEGACY_VENDOR_PREFIXES feature flag
660         https://bugs.webkit.org/show_bug.cgi?id=179872
661
662         Reviewed by Darin Adler.
663
664         * Configurations/FeatureDefines.xcconfig:
665
666 2017-11-16  Daniel Bates  <dabates@apple.com>
667
668         Add feature define for alternative presentation button element
669         https://bugs.webkit.org/show_bug.cgi?id=179692
670         Part of <rdar://problem/34917108>
671
672         Reviewed by Andy Estes.
673
674         Only enabled on Cocoa platforms by default.
675
676         * Configurations/FeatureDefines.xcconfig:
677
678 2017-11-14  Nan Wang  <n_wang@apple.com>
679
680         AX: AOM: Implement AccessibleNode class and support label and role attributes
681         https://bugs.webkit.org/show_bug.cgi?id=179494
682
683         Reviewed by Ryosuke Niwa.
684
685         * WebView/WebPreferenceKeysPrivate.h:
686         * WebView/WebPreferences.mm:
687         (+[WebPreferences initialize]):
688         (-[WebPreferences accessibilityObjectModelEnabled]):
689         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
690         * WebView/WebPreferencesPrivate.h:
691         * WebView/WebView.mm:
692         (-[WebView _preferencesChanged:]):
693
694 2017-11-14  Alex Christensen  <achristensen@webkit.org>
695
696         Remove Cocoa CFURLConnection loading code
697         https://bugs.webkit.org/show_bug.cgi?id=179688
698
699         Reviewed by Antti Koivisto.
700
701         * Misc/WebDownload.mm:
702         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
703         * Misc/WebDownloadInternal.h:
704         * Plugins/WebBaseNetscapePluginView.mm:
705         * WebCoreSupport/WebFrameLoaderClient.mm:
706         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
707         * WebView/WebView.mm:
708         (-[WebView scheduleInRunLoop:forMode:]):
709         (-[WebView unscheduleFromRunLoop:forMode:]):
710
711 2017-11-14  Daniel Bates  <dabates@apple.com>
712
713         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
714         for feature defines
715
716         Following r195498 and r201917 the Visual Studio property files for feature defines have
717         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
718         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
719         files.
720
721         * Configurations/FeatureDefines.xcconfig:
722
723 2017-11-14  Jer Noble  <jer.noble@apple.com>
724
725         Enable Modern EME tests in DumpRenderTree
726         https://bugs.webkit.org/show_bug.cgi?id=179544
727
728         Reviewed by Alex Christensen.
729
730         Add a WebPreferences property to enable the (modern) EME API.
731
732         * WebView/WebPreferenceKeysPrivate.h:
733         * WebView/WebPreferences.mm:
734         (+[WebPreferences initialize]):
735         (-[WebPreferences encryptedMediaAPIEnabled]):
736         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
737         * WebView/WebPreferencesPrivate.h:
738         * WebView/WebView.mm:
739         (-[WebView _preferencesChanged:]):
740
741 2017-11-14  Antti Koivisto  <antti@apple.com>
742
743         Enable display:contents by default
744         https://bugs.webkit.org/show_bug.cgi?id=179655
745
746         Reviewed by Sam Weinig.
747
748         * WebView/WebPreferences.mm:
749         (+[WebPreferences initialize]):
750
751 2017-11-13  Alex Christensen  <achristensen@webkit.org>
752
753         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
754         https://bugs.webkit.org/show_bug.cgi?id=178751
755
756         Reviewed by Brady Eidson.
757
758         * WebCoreSupport/WebFrameNetworkingContext.mm:
759         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
760
761 2017-11-08  Keith Miller  <keith_miller@apple.com>
762
763         Async iteration should only fetch the next method once and add feature flag
764         https://bugs.webkit.org/show_bug.cgi?id=179451
765
766         Reviewed by Geoffrey Garen.
767
768         Add feature flag for Async iteration.
769
770         * Configurations/FeatureDefines.xcconfig:
771
772 2017-11-13  Mark Lam  <mark.lam@apple.com>
773
774         Add more overflow check book-keeping for MarkedArgumentBuffer.
775         https://bugs.webkit.org/show_bug.cgi?id=179634
776         <rdar://problem/35492517>
777
778         Reviewed by Saam Barati.
779
780         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
781         (WebKit::NetscapePluginInstanceProxy::invoke):
782         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
783         (WebKit::NetscapePluginInstanceProxy::construct):
784
785 2017-11-12  Darin Adler  <darin@apple.com>
786
787         More is<> and downcast<>, less static_cast<>
788         https://bugs.webkit.org/show_bug.cgi?id=179600
789
790         Reviewed by Chris Dumez.
791
792         * DOM/DOM.mm:
793         (kit): Use is/downcast.
794         * WebCoreSupport/WebEditorClient.mm:
795         (WebEditorClient::handleKeyboardEvent): Ditto.
796         (WebEditorClient::handleInputMethodKeydown): Ditto.
797         * WebView/WebHTMLView.mm:
798         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
799
800 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
801
802         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
803         https://bugs.webkit.org/show_bug.cgi?id=179397
804
805         Reviewed by Wenson Hsieh.
806
807         * DOM/DOMHTMLInputElement.mm:
808         (-[DOMHTMLInputElement insertTextSuggestion:]):
809
810 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
811
812         HTMLMediaElement should not use element fullscreen on iOS
813         https://bugs.webkit.org/show_bug.cgi?id=179418
814         rdar://problem/35409277
815
816         Reviewed by Eric Carlson.
817
818         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
819
820         * Configurations/FeatureDefines.xcconfig:
821
822 2017-11-06  Alex Christensen  <achristensen@webkit.org>
823
824         Make ResourceLoader::willSendRequestInternal asynchronous
825         https://bugs.webkit.org/show_bug.cgi?id=179251
826
827         Reviewed by Andy Estes.
828
829         * Plugins/Hosted/HostedNetscapePluginStream.mm:
830         (WebKit::HostedNetscapePluginStream::start):
831         * Plugins/WebNetscapePluginStream.mm:
832         (WebNetscapePluginStream::start):
833
834 2017-11-01  Darin Adler  <darin@apple.com>
835
836         Simplify event dispatch code and make it a bit more consistent
837         https://bugs.webkit.org/show_bug.cgi?id=178991
838
839         Reviewed by Chris Dumez.
840
841         * DOM/DOMEvent.mm:
842         (-[DOMEvent srcElement]): Call target instead of srcElement.
843
844 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
845
846         [Touch Bar Web API] Add support for menuitem tag
847         https://bugs.webkit.org/show_bug.cgi?id=179020
848
849         Reviewed by Ryosuke Niwa.
850
851         Adds in properties and methods that allow the menuitem runtime feature
852         to be enabled or disabled.
853
854         * WebView/WebPreferenceKeysPrivate.h:
855         * WebView/WebPreferences.mm:
856         (-[WebPreferences menuItemElementEnabled]):
857         (-[WebPreferences setMenuItemElementEnabled:]):
858         * WebView/WebPreferencesPrivate.h:
859         * WebView/WebView.mm:
860         (-[WebView _preferencesChanged:]):
861
862 2017-11-02  Alex Christensen  <achristensen@webkit.org>
863
864         Use CompletionHandlers for redirects
865         https://bugs.webkit.org/show_bug.cgi?id=179163
866
867         Reviewed by Tim Horton.
868
869         * Plugins/Hosted/HostedNetscapePluginStream.h:
870         * Plugins/Hosted/HostedNetscapePluginStream.mm:
871         (WebKit::HostedNetscapePluginStream::willSendRequest):
872         * Plugins/WebNetscapePluginStream.h:
873         * Plugins/WebNetscapePluginStream.mm:
874         (WebNetscapePluginStream::willSendRequest):
875
876 2017-11-02  Christopher Reid  <chris.reid@sony.com>
877
878         Add a FileSystem namespace to FileSystem.cpp
879         https://bugs.webkit.org/show_bug.cgi?id=179063
880
881         Reviewed by Darin Adler.
882
883         * Misc/WebNSFileManagerExtras.mm:
884         * Storage/WebDatabaseProvider.mm:
885
886 2017-11-02  Frederic Wang  <fwang@igalia.com>
887
888         Add references to bug 179167 in FIXME comments
889         https://bugs.webkit.org/show_bug.cgi?id=179168
890
891         Reviewed by Daniel Bates.
892
893         * Configurations/FeatureDefines.xcconfig:
894
895 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
896
897         Implement WKFullscreenWindowController for iOS.
898         https://bugs.webkit.org/show_bug.cgi?id=178924
899         rdar://problem/34697120
900
901         Reviewed by Simon Fraser.
902
903         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
904
905         * Configurations/FeatureDefines.xcconfig:
906         * WebView/WebView.mm:
907         (-[WebView fullScreenPlaceholderView]):
908
909 2017-10-31  Tim Horton  <timothy_horton@apple.com>
910
911         Clean up some drag and drop feature flags
912         https://bugs.webkit.org/show_bug.cgi?id=179082
913
914         Reviewed by Simon Fraser.
915
916         * Configurations/FeatureDefines.xcconfig:
917
918 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
919
920         Make it possible to test rubber-banding in overflow scroll
921         https://bugs.webkit.org/show_bug.cgi?id=179078
922
923         Reviewed by Sam Weinig.
924
925         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
926         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
927
928         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
929         functions, since most callers want clamped.
930
931         * DOM/DOMHTML.mm:
932         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
933
934 2017-10-31  Tim Horton  <timothy_horton@apple.com>
935
936         Fix up some content filtering feature flags
937         https://bugs.webkit.org/show_bug.cgi?id=179079
938
939         Reviewed by Simon Fraser.
940
941         * Configurations/FeatureDefines.xcconfig:
942
943 2017-10-28  Zalan Bujtas  <zalan@apple.com>
944
945         [FrameView::layout cleanup] Move core layout logic to a separate class.
946         https://bugs.webkit.org/show_bug.cgi?id=178771
947         <rdar://problem/35166542>
948
949         Reviewed by Simon Fraser.
950
951         Move layout code out from FrameView to LayoutContext.
952
953         * WebView/WebClipView.mm:
954         (-[WebClipView _immediateScrollToPoint:]):
955         * WebView/WebFrame.mm:
956         (-[WebFrame layoutCount]):
957
958 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
959
960         Fix issues with WebView subframe painting
961         https://bugs.webkit.org/show_bug.cgi?id=178842
962         rdar://problem/34072253
963
964         Reviewed by Daniel Bates.
965         
966         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
967         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
968         High Sierra, so match the new signature.
969
970         Also rename the 'rect' param to 'displayRect' to match AppKit code.
971
972         * WebView/WebHTMLView.mm:
973         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
974         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
975
976 2017-10-25  Youenn Fablet  <youenn@apple.com>
977
978         Enable ServiceWorker to fetch resources
979         https://bugs.webkit.org/show_bug.cgi?id=178673
980
981         Reviewed by Brady Eidson.
982
983         * WebCoreSupport/WebFrameLoaderClient.mm:
984         (WebFrameLoaderClient::pageID const):
985         (WebFrameLoaderClient::frameID const):
986         (WebFrameLoaderClient::sessionID const):
987
988         Added implementation to the new getters.
989         They are noop in the context of WK1.
990
991 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
992
993         Web Inspector: Enable WebKit logging configuration and display
994         https://bugs.webkit.org/show_bug.cgi?id=177027
995         <rdar://problem/33964767>
996
997         Reviewed by Joseph Pecoraro.
998
999         * WebCoreSupport/WebChromeClient.mm:
1000         (stringForMessageSource): Deal with Media and WebRTC message sources.
1001
1002 2017-10-20  Antoine Quint  <graouts@apple.com>
1003
1004         [Web Animations] Provide basic timeline and animation interfaces
1005         https://bugs.webkit.org/show_bug.cgi?id=178526
1006
1007         Reviewed by Dean Jackson.
1008
1009         Remove the WEB_ANIMATIONS compile-time flag.
1010
1011         * Configurations/FeatureDefines.xcconfig:
1012         * WebView/WebPreferences.mm:
1013         (+[WebPreferences initialize]):
1014         * WebView/WebView.mm:
1015         (-[WebView _preferencesChanged:]):
1016
1017 2017-10-19  Sam Weinig  <sam@webkit.org>
1018
1019         [Settings] Move global settings into their own file
1020         https://bugs.webkit.org/show_bug.cgi?id=178512
1021
1022         Reviewed by Darin Adler.
1023
1024         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1025
1026         * WebCoreSupport/WebChromeClient.mm:
1027         (WebChromeClient::supportsVideoFullscreen):
1028         * WebView/WebDynamicScrollBarsView.mm:
1029         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1030         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1031         * WebView/WebPreferences.mm:
1032         (+[WebPreferences initialize]):
1033         * WebView/WebView.mm:
1034         (-[WebView _commonInitializationWithFrameName:groupName:]):
1035         (-[WebView _preferencesChanged:]):
1036         (+[WebView _doNotStartObservingNetworkReachability]):
1037
1038 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1039
1040         Replace some stack raw pointers with RefPtrs within WebCore/html
1041         https://bugs.webkit.org/show_bug.cgi?id=178201
1042         <rdar://problem/34841692>
1043
1044         Reviewed by Ryosuke Niwa.
1045
1046         * DOM/DOM.mm:
1047         (kit):
1048         Change the type of node as toNode() is changed to return RefPtr.
1049
1050 2017-10-18  Chris Dumez  <cdumez@apple.com>
1051
1052         [Service Worker] Add stubs for Client / WindowClient / Clients
1053         https://bugs.webkit.org/show_bug.cgi?id=178469
1054
1055         Reviewed by Youenn Fablet.
1056
1057         Rename PageVisiblityState to VisibilityState.
1058
1059         * WebView/WebView.mm:
1060         (kit):
1061
1062 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1063
1064         Unreviewed, rolling out r223291.
1065
1066         See WebCore ChangeLog for more detail.
1067
1068         Reverted changeset:
1069
1070         "Remove Editor::simplifyMarkup"
1071         https://bugs.webkit.org/show_bug.cgi?id=178271
1072         https://trac.webkit.org/changeset/223291
1073
1074 2017-10-17  Keith Miller  <keith_miller@apple.com>
1075
1076         Change WebCore sources to work with unified source builds
1077         https://bugs.webkit.org/show_bug.cgi?id=178229
1078
1079         Rubber stamped by Tim Horton.
1080
1081         * Configurations/FeatureDefines.xcconfig:
1082
1083 2017-10-16  Sam Weinig  <sam@webkit.org>
1084
1085         [Settings] Remove all custom code from Settings.h/cpp
1086         https://bugs.webkit.org/show_bug.cgi?id=178330
1087
1088         Reviewed by Simon Fraser.
1089
1090         * WebView/WebPreferences.mm:
1091         (+[WebPreferences initialize]):
1092         
1093             Update for naming changes of FrameFlattening now that it is an enum class.
1094
1095 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1096
1097         Remove Editor::simplifyMarkup
1098         https://bugs.webkit.org/show_bug.cgi?id=178271
1099
1100         Reviewed by Wenson Hsieh.
1101
1102         * WebView/WebView.mm:
1103         (-[WebView _simplifyMarkup:endNode:]):
1104
1105 2017-10-12  Chris Dumez  <cdumez@apple.com>
1106
1107         [Mac] Add support for MouseEvent.buttons
1108         https://bugs.webkit.org/show_bug.cgi?id=178214
1109
1110         Reviewed by Ryosuke Niwa.
1111
1112         * WebView/WebPDFView.mm:
1113         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1114
1115 2017-10-11  Sam Weinig  <sam@webkit.org>
1116
1117         Remove out-parameter variants of copyToVector
1118         https://bugs.webkit.org/show_bug.cgi?id=178155
1119
1120         Reviewed by Tim Horton.
1121
1122         * Plugins/WebNetscapePluginView.mm:
1123         (-[WebNetscapePluginView destroyPlugin]):
1124         * WebView/WebHTMLRepresentation.mm:
1125         (newArrayWithStrings):
1126
1127             Replace out-parameter based copyToVector, with one that returns a Vector.
1128
1129 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1130
1131         Sanitize URL in pasteboard for other applications and cross origin content
1132         https://bugs.webkit.org/show_bug.cgi?id=178060
1133         <rdar://problem/34874518>
1134
1135         Reviewed by Wenson Hsieh.
1136
1137         * WebCoreSupport/WebPlatformStrategies.h:
1138         * WebCoreSupport/WebPlatformStrategies.mm:
1139         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
1140
1141 2017-10-11  Chris Dumez  <cdumez@apple.com>
1142
1143         Modernize Geolocation code
1144         https://bugs.webkit.org/show_bug.cgi?id=178148
1145
1146         Reviewed by Ryosuke Niwa.
1147
1148         * WebCoreSupport/WebGeolocationClient.h:
1149         * WebCoreSupport/WebGeolocationClient.mm:
1150         (WebGeolocationClient::lastPosition):
1151         * WebView/WebGeolocationPosition.mm:
1152         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1153         (core):
1154         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
1155         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1156         * WebView/WebGeolocationPositionInternal.h:
1157
1158 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1159
1160         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
1161         https://bugs.webkit.org/show_bug.cgi?id=178154
1162
1163         Reviewed by Wenson Hsieh.
1164
1165         Enable custom pasteboard data by default.
1166
1167         * WebView/WebPreferenceKeysPrivate.h:
1168         * WebView/WebPreferences.mm:
1169         (+[WebPreferences initialize]):
1170         (-[WebPreferences customPasteboardDataEnabled]): Added.
1171         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
1172         * WebView/WebPreferencesPrivate.h:
1173         * WebView/WebView.mm:
1174         (-[WebView _preferencesChanged:]):
1175
1176 2017-10-10  Sam Weinig  <sam@webkit.org>
1177
1178         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
1179         https://bugs.webkit.org/show_bug.cgi?id=178102
1180
1181         Reviewed by Tim Horton.
1182
1183         * History/WebHistory.mm:
1184         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1185         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1186         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1187         * WebCoreSupport/WebUserMediaClient.mm:
1188         (WebUserMediaClient::pageDestroyed):
1189
1190 2017-10-09  Robin Morisset  <rmorisset@apple.com>
1191
1192         Make the names of the options consistent
1193         https://bugs.webkit.org/show_bug.cgi?id=177933
1194
1195         Reviewed by Saam Barati.
1196
1197         * WebView/WebFrame.h:
1198         * WebView/WebHTMLView.mm:
1199         (-[WebHTMLView setMarkedText:selectedRange:]):
1200         * WebView/WebView.h:
1201
1202 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1203
1204         [iOS] Tweak support for classifying form controls (followup to r222487)
1205         https://bugs.webkit.org/show_bug.cgi?id=177917
1206         <rdar://problem/34820122>
1207
1208         Reviewed by Dean Jackson.
1209
1210         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
1211
1212         * DOM/DOMHTMLInputElement.mm:
1213         (-[DOMHTMLInputElement _autofillContext]):
1214         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
1215         (-[DOMHTMLInputElement representingPageURL]): Deleted.
1216
1217 2017-10-05  Keith Miller  <keith_miller@apple.com>
1218
1219         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
1220
1221         * Configurations/WebKitLegacy.xcconfig:
1222
1223 2017-10-05  Jer Noble  <jer.noble@apple.com>
1224
1225         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1226         https://bugs.webkit.org/show_bug.cgi?id=177261
1227
1228         Reviewed by Eric Carlson.
1229
1230         * Configurations/FeatureDefines.xcconfig:
1231
1232 2017-10-05  Chris Dumez  <cdumez@apple.com>
1233
1234         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1235         https://bugs.webkit.org/show_bug.cgi?id=177957
1236
1237         Reviewed by Alex Christensen.
1238
1239         * WebCoreSupport/WebPlatformStrategies.h:
1240         * WebCoreSupport/WebPlatformStrategies.mm:
1241         (WebPlatformStrategies::cookiesEnabled):
1242
1243 2017-10-05  Youenn Fablet  <youenn@apple.com>
1244
1245         Make LibWebRTCProvider port agnostic
1246         https://bugs.webkit.org/show_bug.cgi?id=177747
1247
1248         Reviewed by Alex Christensen & Alex Garcia.
1249
1250         * WebView/WebView.mm:
1251         (-[WebView _commonInitializationWithFrameName:groupName:]):
1252         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1253
1254 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1255
1256         Stop linking with WebKitSystemInterface
1257         https://bugs.webkit.org/show_bug.cgi?id=177915
1258
1259         Reviewed by Antti Koivisto.
1260
1261         * Configurations/DebugRelease.xcconfig:
1262         * Configurations/WebKitLegacy.xcconfig:
1263
1264 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1265
1266         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
1267         https://bugs.webkit.org/show_bug.cgi?id=177912
1268
1269         Reviewed by Saam Barati.
1270
1271         * Carbon/CarbonUtils.m:
1272         * Carbon/CarbonWindowAdapter.mm:
1273         * Carbon/HIWebView.mm:
1274         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1275         * Misc/WebNSFileManagerExtras.mm:
1276         * Misc/WebNSPasteboardExtras.mm:
1277         * Misc/WebNSURLExtras.mm:
1278         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1279         * Plugins/Hosted/NetscapePluginHostManager.mm:
1280         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1281         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1282         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1283         * Plugins/Hosted/WebTextInputWindowController.m:
1284         * Plugins/WebBaseNetscapePluginView.mm:
1285         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1286         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1287         * Plugins/WebNetscapePluginStream.mm:
1288         * Plugins/WebNetscapePluginView.mm:
1289         * Plugins/WebPluginDatabase.mm:
1290         * WebCoreSupport/PopupMenuMac.mm:
1291         * WebCoreSupport/WebChromeClient.mm:
1292         * WebCoreSupport/WebFrameLoaderClient.mm:
1293         * WebCoreSupport/WebInspectorClient.mm:
1294         * WebCoreSupport/WebPlatformStrategies.mm:
1295         * WebCoreSupport/WebSystemInterface.mm:
1296         * WebView/WebDynamicScrollBarsView.mm:
1297         * WebView/WebFrame.mm:
1298         * WebView/WebFrameView.mm:
1299         * WebView/WebFullScreenController.mm:
1300         * WebView/WebHTMLView.mm:
1301         * WebView/WebPreferences.mm:
1302         * WebView/WebView.mm:
1303
1304 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
1305
1306         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
1307         rdar://problem/34705779
1308
1309         Addressing review comments that I somehow landed without.
1310
1311         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
1312
1313 2017-09-29  Chris Dumez  <cdumez@apple.com>
1314
1315         Split some logic out of VisitedLinkStore and make it reusable
1316         https://bugs.webkit.org/show_bug.cgi?id=177575
1317
1318         Reviewed by Alex Christensen.
1319
1320         * WebCoreSupport/WebVisitedLinkStore.h:
1321         * WebCoreSupport/WebVisitedLinkStore.mm:
1322         (WebVisitedLinkStore::addVisitedLink):
1323         (WebVisitedLinkStore::removeVisitedLink):
1324         (WebVisitedLinkStore::isLinkVisited):
1325         (WebVisitedLinkStore::addVisitedLinkHash):
1326
1327 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
1328
1329         Build fix for High Sierra 32 bit Mac
1330         https://bugs.webkit.org/show_bug.cgi?id=177551
1331         <rdar://problem/34690283>
1332
1333         Reviewed by Alexey Proskuryakov.
1334
1335         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1336         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1337         also made.
1338
1339         * Carbon/CarbonWindowAdapter.mm:
1340         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1341         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1342         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1343         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1344         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1345         (-[CarbonWindowAdapter dealloc]):
1346         (-[CarbonWindowAdapter windowRef]):
1347         (-[CarbonWindowAdapter _hasWindowRef]):
1348         (-[CarbonWindowAdapter _managesWindowRef]):
1349         (-[CarbonWindowAdapter _removeWindowRef]):
1350         (-[CarbonWindowAdapter _carbonWindowClass]):
1351         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1352         (-[CarbonWindowAdapter sendSuperEvent:]):
1353         (-[CarbonWindowAdapter relinquishFocus]):
1354         (-[CarbonWindowAdapter _cancelKey:]):
1355         (-[CarbonWindowAdapter _commonAwake]):
1356         (-[CarbonWindowAdapter _destroyRealWindow:]):
1357         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1358         (-[CarbonWindowAdapter _termWindowIfOwner]):
1359         (-[CarbonWindowAdapter _windowMovedToRect:]):
1360         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1361         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1362         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1363         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1364         (-[CarbonWindowAdapter canBecomeMainWindow]):
1365         (-[CarbonWindowAdapter encodeWithCoder:]):
1366         (-[CarbonWindowAdapter initWithCoder:]):
1367         (-[CarbonWindowAdapter setContentView:]):
1368         (-[CarbonWindowAdapter worksWhenModal]):
1369         (-[CarbonWindowAdapter _setModalWindowLevel]):
1370         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1371         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1372         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1373         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1374         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1375         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1376         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1377         (NSCarbonWindowHandleEvent):
1378         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1379         (-[CarbonWindowAdapter _growBoxRect]):
1380         * Carbon/HIWebView.mm:
1381         (HIWebViewGetWebView):
1382         (HIWebViewConstructor):
1383         (HIWebViewDestructor):
1384         (HIWebViewRegisterClass):
1385         (GetBehaviors):
1386         (Draw):
1387         (HitTest):
1388         (GetRegion):
1389         (GetWindowRef):
1390         (CreateNSEventAdoptingCGEvent):
1391         (CopyEventCGEvent):
1392         (CreateNSEventWithCarbonClickEvent):
1393         (Click):
1394         (CreateNSEventWithCarbonEvent):
1395         (MouseUp):
1396         (CreateNSEventWithCarbonMouseMoveEvent):
1397         (MouseMoved):
1398         (MouseDragged):
1399         (MouseWheelMoved):
1400         (ContextMenuClick):
1401         (GetKind):
1402         (BoundsChanged):
1403         (OwningWindowChanged):
1404         (WindowHandler):
1405         (SyncFrame):
1406         (SetFocusPart):
1407         (AdvanceFocus):
1408         (RelinquishFocus):
1409         (ActiveStateChanged):
1410         (ProcessCommand):
1411         (UpdateCommandStatus):
1412         (_NSSelectorForHICommand):
1413         (HIWebViewEventHandler):
1414         (StartUpdateObserver):
1415         (StopUpdateObserver):
1416         (UpdateObserver):
1417
1418 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1419
1420         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
1421         https://bugs.webkit.org/show_bug.cgi?id=172526
1422         <rdar://problem/32396081>
1423
1424         Reviewed by Ryosuke Niwa.
1425
1426         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
1427
1428         * WebCoreSupport/WebPlatformStrategies.h:
1429         * WebCoreSupport/WebPlatformStrategies.mm:
1430         (WebPlatformStrategies::webExposedTypes):
1431         (WebPlatformStrategies::writeCustomData):
1432
1433 2017-09-27  Matt Lewis  <jlewis3@apple.com>
1434
1435         Unreviewed, rolling out r222567.
1436
1437         This broke and internal build.
1438
1439         Reverted changeset:
1440
1441         "Build fix for High Sierra 32 bit Mac"
1442         https://bugs.webkit.org/show_bug.cgi?id=177551
1443         http://trac.webkit.org/changeset/222567
1444
1445 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
1446
1447         Build fix for High Sierra 32 bit Mac
1448         https://bugs.webkit.org/show_bug.cgi?id=177551
1449         <rdar://problem/34690283>
1450
1451         Reviewed by Alexey Proskuryakov.
1452
1453         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1454         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1455         also made.
1456
1457         * Carbon/CarbonWindowAdapter.mm:
1458         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1459         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1460         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1461         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1462         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1463         (-[CarbonWindowAdapter dealloc]):
1464         (-[CarbonWindowAdapter windowRef]):
1465         (-[CarbonWindowAdapter _hasWindowRef]):
1466         (-[CarbonWindowAdapter _managesWindowRef]):
1467         (-[CarbonWindowAdapter _removeWindowRef]):
1468         (-[CarbonWindowAdapter _carbonWindowClass]):
1469         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1470         (-[CarbonWindowAdapter sendSuperEvent:]):
1471         (-[CarbonWindowAdapter relinquishFocus]):
1472         (-[CarbonWindowAdapter _cancelKey:]):
1473         (-[CarbonWindowAdapter _commonAwake]):
1474         (-[CarbonWindowAdapter _destroyRealWindow:]):
1475         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1476         (-[CarbonWindowAdapter _termWindowIfOwner]):
1477         (-[CarbonWindowAdapter _windowMovedToRect:]):
1478         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1479         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1480         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1481         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1482         (-[CarbonWindowAdapter canBecomeMainWindow]):
1483         (-[CarbonWindowAdapter encodeWithCoder:]):
1484         (-[CarbonWindowAdapter initWithCoder:]):
1485         (-[CarbonWindowAdapter setContentView:]):
1486         (-[CarbonWindowAdapter worksWhenModal]):
1487         (-[CarbonWindowAdapter _setModalWindowLevel]):
1488         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1489         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1490         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1491         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1492         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1493         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1494         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1495         (NSCarbonWindowHandleEvent):
1496         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1497         (-[CarbonWindowAdapter _growBoxRect]):
1498         * Carbon/HIWebView.mm:
1499         (HIWebViewGetWebView):
1500         (HIWebViewConstructor):
1501         (HIWebViewDestructor):
1502         (HIWebViewRegisterClass):
1503         (GetBehaviors):
1504         (Draw):
1505         (HitTest):
1506         (GetRegion):
1507         (GetWindowRef):
1508         (CreateNSEventAdoptingCGEvent):
1509         (CopyEventCGEvent):
1510         (CreateNSEventWithCarbonClickEvent):
1511         (Click):
1512         (CreateNSEventWithCarbonEvent):
1513         (MouseUp):
1514         (CreateNSEventWithCarbonMouseMoveEvent):
1515         (MouseMoved):
1516         (MouseDragged):
1517         (MouseWheelMoved):
1518         (ContextMenuClick):
1519         (GetKind):
1520         (BoundsChanged):
1521         (OwningWindowChanged):
1522         (WindowHandler):
1523         (SyncFrame):
1524         (SetFocusPart):
1525         (AdvanceFocus):
1526         (RelinquishFocus):
1527         (ActiveStateChanged):
1528         (ProcessCommand):
1529         (UpdateCommandStatus):
1530         (_NSSelectorForHICommand):
1531         (HIWebViewEventHandler):
1532         (StartUpdateObserver):
1533         (StopUpdateObserver):
1534         (UpdateObserver):
1535
1536 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1537
1538         Make PolicyAction an encodable enum class
1539         https://bugs.webkit.org/show_bug.cgi?id=177480
1540
1541         Reviewed by Antti Koivisto.
1542
1543         * Plugins/WebPluginContainerCheck.mm:
1544         (-[WebPluginContainerCheck _continueWithPolicy:]):
1545         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
1546         * WebCoreSupport/WebFrameLoaderClient.mm:
1547         (-[WebFramePolicyListener invalidate]):
1548         (-[WebFramePolicyListener ignore]):
1549         (-[WebFramePolicyListener download]):
1550         (-[WebFramePolicyListener use]):
1551         (-[WebFramePolicyListener continue]):
1552         * WebView/WebPolicyDelegate.mm:
1553         (-[WebPolicyDecisionListener use]):
1554         (-[WebPolicyDecisionListener ignore]):
1555         (-[WebPolicyDecisionListener download]):
1556
1557 2017-09-25  Frederik Riedel  <riedel@apple.com>
1558
1559         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
1560         https://bugs.webkit.org/show_bug.cgi?id=174394
1561         <rdar://problem/33183504>
1562
1563         Reviewed by Ryosuke Niwa.
1564
1565         * DOM/DOMHTMLInputElement.h:
1566         * DOM/DOMHTMLInputElement.mm:
1567         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
1568         Determines if this HTMLInputElement is part of a login screen.
1569         (-[DOMHTMLInputElement representingPageUrl]):
1570         Returns the webpage's URL that is currently displayed in the Web View.
1571         (-[DOMHTMLInputElement insertTextSuggestion:]):
1572         Inserts login credentials into the Web View.
1573
1574 2017-09-25  Sam Weinig  <sam@webkit.org>
1575
1576         Remove unused EditorClient functions
1577         https://bugs.webkit.org/show_bug.cgi?id=177463
1578
1579         Reviewed by Alex Christensen.
1580
1581         Remove unused EditorClient functions.
1582
1583         * WebCoreSupport/WebEditorClient.h:
1584         * WebCoreSupport/WebEditorClient.mm:
1585         (WebEditorClient::canonicalizeURL): Deleted.
1586         (WebEditorClient::canonicalizeURLString): Deleted.
1587         (WebEditorClient::writeDataToPasteboard): Deleted.
1588         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
1589         (WebEditorClient::readDataFromPasteboard): Deleted.
1590         (WebEditorClient::pasteboardChangeCount): Deleted.
1591
1592 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1593
1594         Stop using PolicyCallback
1595         https://bugs.webkit.org/show_bug.cgi?id=176088
1596
1597         Reviewed by Andy Estes.
1598
1599         * WebCoreSupport/WebFrameLoaderClient.mm:
1600         (-[WebFramePolicyListener invalidate]):
1601         (-[WebFramePolicyListener receivedPolicyDecision:]):
1602
1603 2017-09-25  Sam Weinig  <sam@webkit.org>
1604
1605         Remove unnecessary userVisibleString EditorClient function
1606         https://bugs.webkit.org/show_bug.cgi?id=177456
1607
1608         Reviewed by Dan Bernstein.
1609
1610         * WebCoreSupport/WebEditorClient.h:
1611         * WebCoreSupport/WebEditorClient.mm:
1612         (WebEditorClient::userVisibleString): Deleted.
1613
1614             Remove userVisibleString client function.
1615
1616 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1617
1618         Separate form submission from PolicyChecker infrastructure
1619         https://bugs.webkit.org/show_bug.cgi?id=177396
1620
1621         Reviewed by Geoffrey Garen.
1622
1623         * WebCoreSupport/WebFrameLoaderClient.h:
1624         * WebCoreSupport/WebFrameLoaderClient.mm:
1625         (WebFrameLoaderClient::dispatchWillSubmitForm):
1626
1627 2017-09-22  Zalan Bujtas  <zalan@apple.com>
1628
1629         WeakPtrFactory should populate m_ref lazily.
1630         https://bugs.webkit.org/show_bug.cgi?id=177375
1631
1632         Reviewed by Geoffrey Garen.
1633
1634         * WebCoreSupport/WebEditorClient.mm:
1635         (WebEditorClient::WebEditorClient):
1636         (WebEditorClient::requestCandidatesForSelection):
1637
1638 2017-09-22  Chris Dumez  <cdumez@apple.com>
1639
1640         Use high resolution timestamp for event time
1641         https://bugs.webkit.org/show_bug.cgi?id=154246
1642         <rdar://problem/34333304>
1643
1644         Reviewed by Ryosuke Niwa.
1645
1646         Use WallTime / MonotonicTime instead of double type for clarity.
1647
1648         * DOM/DOMEvent.mm:
1649         (-[DOMEvent timeStamp]):
1650         * WebView/WebFrame.mm:
1651         (-[WebFrame _dragSourceEndedAt:operation:]):
1652         * WebView/WebPDFView.mm:
1653         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1654
1655 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
1656
1657         Enable dataTransfer.items on macOS and iOS
1658         https://bugs.webkit.org/show_bug.cgi?id=177335
1659
1660         Reviewed by Sam Weinig.
1661
1662         * WebView/WebPreferences.mm:
1663         (+[WebPreferences initialize]):
1664
1665 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
1666
1667         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
1668         https://bugs.webkit.org/show_bug.cgi?id=177101
1669         <rdar://problem/34500648>
1670
1671         Reviewed by Brian Burg.
1672
1673         * WebInspector/WebNodeHighlight.mm:
1674         Ensure we close the window that we have just removed.
1675
1676 2017-09-20  Antti Koivisto  <antti@apple.com>
1677
1678         Remove DOM and styling support for CSS Regions
1679         https://bugs.webkit.org/show_bug.cgi?id=177221
1680
1681         Reviewed by Andreas Kling.
1682
1683         * Configurations/FeatureDefines.xcconfig:
1684         * DOM/DOMCSS.mm:
1685         (kitClass):
1686         * DOM/DOMElement.mm:
1687         (-[DOMElement webkitRegionOverset]): Deleted.
1688
1689 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
1690
1691         Layering violation in Editor::createFragment
1692         https://bugs.webkit.org/show_bug.cgi?id=176123
1693
1694         Reviewed by Darin Adler.
1695
1696         * Misc/WebNSURLExtras.h:
1697         * Misc/WebNSURLExtras.mm:
1698         * WebView/WebFrame.mm:
1699         * WebView/WebHTMLView.mm:
1700         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
1701
1702         * WebCoreSupport/WebEditorClient.mm:
1703         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
1704         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
1705         way to avoid exporting the symbol just on newer OSes.
1706
1707 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
1708
1709         On iOS, getData can't get text set by setData during copy event
1710         https://bugs.webkit.org/show_bug.cgi?id=176980
1711         <rdar://problem/34453915>
1712
1713         Reviewed by Darin Adler.
1714
1715         * WebCoreSupport/WebPlatformStrategies.h:
1716         * WebCoreSupport/WebPlatformStrategies.mm:
1717         (WebPlatformStrategies::copy): Deleted.
1718
1719 2017-09-18  Andy Estes  <aestes@apple.com>
1720
1721         [Mac] Upstream miscellaneous WebKitSystemInterface functions
1722         https://bugs.webkit.org/show_bug.cgi?id=177029
1723
1724         Reviewed by Alex Christensen.
1725
1726         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1727         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
1728         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1729         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1730         * WebCoreSupport/PopupMenuMac.mm:
1731         (PopupMenuMac::show):
1732         * WebCoreSupport/WebSystemInterface.mm:
1733         (InitWebCoreSystemInterface):
1734         * WebView/WebHTMLView.mm:
1735         (-[WebHTMLView setDataSource:]):
1736         (-[WebHTMLView attachRootLayer:]):
1737         * WebView/WebView.mm:
1738         (-[WebView _needsAdobeFrameReloadingQuirk]):
1739         (-[WebView _needsLinkElementTextCSSQuirk]):
1740         (-[WebView _needsIsLoadingInAPISenseQuirk]):
1741         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
1742         (-[WebView _preferencesChanged:]):
1743
1744 2017-09-15  Andy Estes  <aestes@apple.com>
1745
1746         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
1747         https://bugs.webkit.org/show_bug.cgi?id=176953
1748
1749         Reviewed by Eric Carlson.
1750
1751         * WebCoreSupport/WebSystemInterface.mm:
1752         (InitWebCoreSystemInterface):
1753
1754 2017-09-14  Andy Estes  <aestes@apple.com>
1755
1756         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
1757         https://bugs.webkit.org/show_bug.cgi?id=176931
1758
1759         Reviewed by Joseph Pecoraro.
1760
1761         * WebCoreSupport/WebSystemInterface.mm:
1762         (InitWebCoreSystemInterface):
1763
1764 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1765
1766         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
1767         https://bugs.webkit.org/show_bug.cgi?id=176867
1768
1769         Reviewed by Sam Weinig.
1770
1771         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1772         (WebKit::NetscapePluginInstanceProxy::enumerate):
1773
1774 2017-09-13  Andy Estes  <aestes@apple.com>
1775
1776         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
1777         https://bugs.webkit.org/show_bug.cgi?id=176729
1778
1779         Reviewed by Alex Christensen.
1780
1781         * WebCoreSupport/WebSystemInterface.mm:
1782         (InitWebCoreSystemInterface):
1783         * WebView/WebView.mm:
1784         (+[WebView _setCacheModel:]):
1785
1786 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1787
1788         Refactor WebContentReader out of EditorMac and EditorIOS
1789         https://bugs.webkit.org/show_bug.cgi?id=176770
1790
1791         Reviewed by Sam Weinig.
1792
1793         * WebCoreSupport/WebEditorClient.mm:
1794
1795 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
1796
1797         Dragging & dropping a file creates an attachment element even when it's disabled
1798         https://bugs.webkit.org/show_bug.cgi?id=176769
1799
1800         Reviewed by Tim Horton.
1801
1802         * WebView/WebView.mm:
1803         (-[WebView _preferencesChanged:]):
1804
1805 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1806
1807         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
1808         https://bugs.webkit.org/show_bug.cgi?id=176721
1809         <rdar://problem/34373660>
1810
1811         Reviewed by Tim Horton.
1812
1813         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
1814         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
1815
1816         * WebView/WebView.mm:
1817         (-[WebView _startDrag:]):
1818         (-[WebView _draggedElementBounds]):
1819         (-[WebView _endedDataInteraction:global:]):
1820         * WebView/WebViewData.h:
1821
1822 2017-09-11  Andy Estes  <aestes@apple.com>
1823
1824         [Mac] Upstream QTKit-related WebKitSystemInterface functions
1825         https://bugs.webkit.org/show_bug.cgi?id=176472
1826
1827         Reviewed by Eric Carlson.
1828
1829         * WebCoreSupport/WebSystemInterface.mm:
1830         (InitWebCoreSystemInterface):
1831
1832 2017-09-09  Mark Lam  <mark.lam@apple.com>
1833
1834         Avoid duplicate computations of ExecState::vm().
1835         https://bugs.webkit.org/show_bug.cgi?id=176647
1836
1837         Reviewed by Saam Barati.
1838
1839         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1840         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1841         (WebKit::NetscapePluginInstanceProxy::construct):
1842         (WebKit::NetscapePluginInstanceProxy::setProperty):
1843         (WebKit::NetscapePluginInstanceProxy::removeProperty):
1844         (WebKit::NetscapePluginInstanceProxy::enumerate):
1845         * Plugins/Hosted/ProxyInstance.mm:
1846         (WebKit::ProxyRuntimeMethod::create):
1847
1848 2017-09-08  Commit Queue  <commit-queue@webkit.org>
1849
1850         Unreviewed, rolling out r221773.
1851         https://bugs.webkit.org/show_bug.cgi?id=176614
1852
1853         This caused build failures. (Requested by mlewis13 on
1854         #webkit).
1855
1856         Reverted changeset:
1857
1858         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
1859         https://bugs.webkit.org/show_bug.cgi?id=176472
1860         http://trac.webkit.org/changeset/221773
1861
1862 2017-09-07  Andy Estes  <aestes@apple.com>
1863
1864         [Mac] Upstream QTKit-related WebKitSystemInterface functions
1865         https://bugs.webkit.org/show_bug.cgi?id=176472
1866
1867         Reviewed by Eric Carlson.
1868
1869         * WebCoreSupport/WebSystemInterface.mm:
1870         (InitWebCoreSystemInterface):
1871
1872 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
1873
1874         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
1875         https://bugs.webkit.org/show_bug.cgi?id=176561
1876
1877         Reviewed by Brent Fulgham.
1878
1879         * Misc/WebNSUserDefaultsExtras.mm:
1880
1881 2017-09-07  Alex Christensen  <achristensen@webkit.org>
1882
1883         Modernize Geolocation code
1884         https://bugs.webkit.org/show_bug.cgi?id=176496
1885
1886         Reviewed by Andy Estes.
1887
1888         * WebCoreSupport/WebGeolocationClient.h:
1889         * WebCoreSupport/WebGeolocationClient.mm:
1890         (WebGeolocationClient::requestPermission):
1891         (-[WebGeolocationPolicyListener initWithGeolocation:]):
1892         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
1893         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
1894         * WebView/WebView.mm:
1895         (-[WebView _commonInitializationWithFrameName:groupName:]):
1896         (-[WebView _geolocationDidFailWithMessage:]):
1897
1898 2017-09-05  Tim Horton  <timothy_horton@apple.com>
1899
1900         Remove some unused bits of code and resources
1901         https://bugs.webkit.org/show_bug.cgi?id=176275
1902
1903         Reviewed by Dan Bernstein.
1904
1905         * Misc/WebNSFileManagerExtras.mm:
1906         Include FileSystem instead of FileSystemIOS.
1907
1908 2017-09-03  Darin Adler  <darin@apple.com>
1909
1910         [Cocoa] Tidy a few things in legacy WebHTMLView
1911         https://bugs.webkit.org/show_bug.cgi?id=176280
1912
1913         Reviewed by Dan Bernstein.
1914
1915         * WebCoreSupport/WebChromeClient.mm:
1916         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
1917         methods it calls on WebHTMLView were doing nothing on iOS.
1918
1919         * WebView/WebFrame.mm:
1920         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
1921         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
1922
1923         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
1924         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
1925         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
1926         order. Removed all sorts of unused things. Made more code and fields Mac-only where
1927         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
1928         Use RetainPtr instead of writing retain/release wherever possible.
1929         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
1930         initialization for it. Removed various unused methods and declarations of methods.
1931         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
1932         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
1933         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
1934         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
1935         and remove CFRetain no longer needed since we don't support garbage collection any more.
1936         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
1937         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
1938         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
1939         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
1940         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
1941         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
1942         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
1943         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1944         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
1945         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
1946         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
1947         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
1948         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
1949         debug flag; we haven't used it for years and it's not clearly helpful.
1950         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
1951         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
1952         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
1953         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
1954         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
1955         two additional methods in the WebPrivate category and still be called by the two
1956         methods in the WebInternal category that were already using it.
1957         (-[WebHTMLView didAddSubview:]): Deleted.
1958         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
1959         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
1960         place this was called, the close method.
1961         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
1962         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1963         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
1964         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
1965         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
1966         Added helper method to make the one below simpler.
1967         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1968         Compared pasteboard type strings using isEqualToString: rather than using == since
1969         we want to actually compare the string contents. Also updated to use modern for loop,
1970         renamed a local variable from "s" to "localSubresources", and factored out the handling
1971         of three image types to use the helper method above.
1972         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
1973         _web_makePluginSubviewsPerformSelector:withObject: method.
1974         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
1975         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
1976         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
1977         not call the -[NSView subviews] method to make this identical on both platforms and used
1978         a modern for loop.
1979         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
1980         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
1981         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
1982         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
1983         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
1984         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
1985         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
1986         of it is Mac-only.
1987         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
1988         method did was call itself on the main thread, and do nothing if called on main thread.
1989         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
1990         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
1991         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
1992         half of this method.
1993         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
1994         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1995         Simplified using a modern for loop and RetainPtr.
1996         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
1997         (-[WebHTMLView keyDown:]): Ditto.
1998         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
1999         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2000         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2001         (-[WebHTMLView complete:]): Ditto.
2002         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2003         now macOS-only.
2004         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2005         iOS since that is now macOS-only.
2006         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2007         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2008         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2009         and reorganized to use early return.
2010         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2011         on iOS, but kept there so we don't have to do #if at every call site.
2012         (-[WebHTMLView _pluginController]): Moved into internal category.
2013         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2014         there only for GC, using C++ initialization, removing obsolete comment.
2015         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2016         peculiar iOS-only comment.
2017         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2018
2019         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2020         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2021         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2022         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2023         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2024
2025         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2026         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2027         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2028         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2029         them at this time.
2030
2031 2017-09-03  Sam Weinig  <sam@webkit.org>
2032
2033         Remove CanvasProxy
2034         https://bugs.webkit.org/show_bug.cgi?id=176288
2035
2036         Reviewed by Yusuke Suzuki.
2037
2038         CanvasProxy does not appear to be in any current HTML spec
2039         and was disabled and unimplemented in our tree. Time to 
2040         get rid of it.
2041
2042         * Configurations/FeatureDefines.xcconfig:
2043
2044 2017-09-02  Andy Estes  <aestes@apple.com>
2045
2046         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2047         https://bugs.webkit.org/show_bug.cgi?id=176270
2048
2049         Reviewed by Tim Horton.
2050
2051         * Plugins/Hosted/NetscapePluginHostManager.mm:
2052         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2053         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2054         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2055         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2056         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2057         (WebKit::SoftwareCARenderer::context const):
2058         (WebKit::SoftwareCARenderer::renderContext const):
2059         (WebKit::SoftwareCARenderer::render):
2060         (-[WebHostedNetscapePluginView createPlugin]):
2061         (-[WebHostedNetscapePluginView createPluginLayer]):
2062         (-[WebHostedNetscapePluginView destroyPlugin]):
2063         (-[WebHostedNetscapePluginView drawRect:]):
2064         * WebCoreSupport/WebSystemInterface.mm:
2065         (InitWebCoreSystemInterface):
2066
2067 2017-09-01  Andy Estes  <aestes@apple.com>
2068
2069         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2070         https://bugs.webkit.org/show_bug.cgi?id=176200
2071
2072         Reviewed by Tim Horton.
2073
2074         * Carbon/HIWebView.mm:
2075         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2076         (overrideCGContext):
2077         (restoreCGContext):
2078         (Draw):
2079         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2080         (+[WebHostedNetscapePluginView initialize]):
2081         * Plugins/WebBaseNetscapePluginView.h:
2082         * Plugins/WebBaseNetscapePluginView.mm:
2083         (WebKit::sendUserChangeNotifications):
2084         * Plugins/WebNetscapePluginView.mm:
2085         (+[WebNetscapePluginView initialize]):
2086         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2087         * WebCoreSupport/WebSystemInterface.mm:
2088         (InitWebCoreSystemInterface):
2089         * WebView/WebFrame.mm:
2090         (-[WebFrame _paintBehaviorForDestinationContext:]):
2091         * WebView/WebFullScreenController.mm:
2092         (setClipRectForWindow):
2093         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2094         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2095         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2096         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2097
2098 2017-08-31  Andy Estes  <aestes@apple.com>
2099
2100         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2101         https://bugs.webkit.org/show_bug.cgi?id=176175
2102
2103         Reviewed by Brady Eidson.
2104
2105         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2106         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2107         * Plugins/Hosted/WebTextInputWindowController.m:
2108         (-[WebTextInputPanel init]):
2109         * WebCoreSupport/WebSystemInterface.mm:
2110         (InitWebCoreSystemInterface):
2111         * WebView/WebDynamicScrollBarsView.mm:
2112         (-[WebDynamicScrollBarsView scrollWheel:]):
2113         * WebView/WebHTMLView.mm:
2114         (-[WebHTMLView _removeWindowObservers]):
2115         (-[WebHTMLView addWindowObservers]):
2116         * WebView/WebView.mm:
2117         (-[WebView addWindowObserversForWindow:]):
2118         (-[WebView removeWindowObservers]):
2119         (-[WebView viewWillMoveToWindow:]):
2120
2121 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2122
2123         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2124         https://bugs.webkit.org/show_bug.cgi?id=175779
2125         <rdar://problem/22367975>
2126
2127         Reviewed by Tim Horton.
2128
2129         * WebCoreSupport/WebFrameLoaderClient.h:
2130         * WebCoreSupport/WebFrameLoaderClient.mm:
2131         (WebFrameLoaderClient::webGLPolicyForURL const):
2132         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2133
2134 2017-08-30  Andy Estes  <aestes@apple.com>
2135
2136         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
2137         https://bugs.webkit.org/show_bug.cgi?id=176093
2138
2139         Reviewed by Eric Carlson.
2140
2141         * WebCoreSupport/WebSystemInterface.mm:
2142         (InitWebCoreSystemInterface):
2143
2144 2017-08-30  Andy Estes  <aestes@apple.com>
2145
2146         [Mac] Upstream Carbon-related WebKitSystemInterface functions
2147         https://bugs.webkit.org/show_bug.cgi?id=176087
2148
2149         Reviewed by Alex Christensen.
2150
2151         * Carbon/CarbonUtils.m:
2152         (getNSAutoreleasePoolCount):
2153         (WebInitForCarbon):
2154         (PoolCleaner):
2155         * Carbon/CarbonWindowAdapter.mm:
2156         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2157         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2158         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2159         (-[CarbonWindowAdapter _windowMovedToRect:]):
2160         * Carbon/HIViewAdapter.m:
2161         * Carbon/HIWebView.mm:
2162         (Draw):
2163         (CreateNSEventAdoptingCGEvent):
2164         (CopyEventCGEvent):
2165         (CreateNSEventWithCarbonClickEvent):
2166         (Click):
2167         (CreateNSEventWithCarbonEvent):
2168         (MouseUp):
2169         (CreateNSEventWithCarbonMouseMoveEvent):
2170         (MouseMoved):
2171         (MouseDragged):
2172         (MouseWheelMoved):
2173         (WindowHandler):
2174         (HIWebViewEventHandler):
2175         * Misc/QuickDrawCompatibility.h: Removed.
2176         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2177         (getCarbonEvent):
2178         (WebNetscapePluginEventHandlerCarbon::keyDown):
2179         (WebNetscapePluginEventHandlerCarbon::keyUp):
2180         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2181         (WebNetscapePluginEventHandlerCocoa::keyDown):
2182         * Plugins/WebNetscapePluginView.mm:
2183         (-[WebNetscapePluginView tellQuickTimeToChill]):
2184
2185 2017-08-29  Andy Estes  <aestes@apple.com>
2186
2187         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
2188         https://bugs.webkit.org/show_bug.cgi?id=176046
2189
2190         Reviewed by Alex Christensen.
2191
2192         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
2193         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
2194
2195         * Misc/WebNSFileManagerExtras.mm:
2196         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2197         (setMetaData): Deleted.
2198         * WebCoreSupport/WebSystemInterface.mm:
2199         (InitWebCoreSystemInterface):
2200
2201 2017-08-28  Andy Estes  <aestes@apple.com>
2202
2203         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
2204         https://bugs.webkit.org/show_bug.cgi?id=176039
2205
2206         Reviewed by Alex Christensen.
2207
2208         * WebCoreSupport/WebSystemInterface.mm:
2209         (InitWebCoreSystemInterface):
2210         * WebView/WebPreferences.mm:
2211         (+[WebPreferences _systemCFStringEncoding]):
2212
2213 2017-08-28  Andy Estes  <aestes@apple.com>
2214
2215         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
2216         https://bugs.webkit.org/show_bug.cgi?id=176032
2217
2218         Reviewed by Alex Christensen.
2219
2220         * WebCoreSupport/WebSystemInterface.mm:
2221         (InitWebCoreSystemInterface):
2222         * WebView/WebView.mm:
2223         (-[WebView _cachedResponseForURL:]):
2224
2225 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2226
2227         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
2228         https://bugs.webkit.org/show_bug.cgi?id=175992
2229         <rdar://problem/34086613>
2230
2231         Reviewed by Daniel Bates.
2232
2233         * WebCoreSupport/WebPlatformStrategies.h:
2234         * WebCoreSupport/WebPlatformStrategies.mm:
2235         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
2236         cookies should be included, and return a pair containing the resulting cookie string and a boolean
2237         indicating if secure cookies were accessed.
2238
2239 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2240
2241         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
2242         https://bugs.webkit.org/show_bug.cgi?id=170955
2243         <rdar://problem/31697653>
2244
2245         Reviewed by Ryosuke Niwa.
2246
2247         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
2248         text is being replaced.
2249
2250         * WebView/WebHTMLView.mm:
2251         (-[WebHTMLView insertText:]):
2252
2253 2017-08-24  Chris Dumez  <cdumez@apple.com>
2254
2255         [Directory Upload] Add basic support for input.webkitdirectory
2256         https://bugs.webkit.org/show_bug.cgi?id=175950
2257         <rdar://problem/33951915>
2258
2259         Reviewed by Geoffrey Garen.
2260
2261         Add private API to toggle Directory Upload support on Mac WebKit1.
2262
2263         * WebView/WebPreferenceKeysPrivate.h:
2264         * WebView/WebPreferences.mm:
2265         (+[WebPreferences initialize]):
2266         (-[WebPreferences setDirectoryUploadEnabled:]):
2267         (-[WebPreferences directoryUploadEnabled]):
2268         * WebView/WebPreferencesPrivate.h:
2269         * WebView/WebView.mm:
2270         (-[WebView _preferencesChanged:]):
2271
2272 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2273
2274         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2275         https://bugs.webkit.org/show_bug.cgi?id=175370
2276         <rdar://problem/33799806>
2277
2278         Reviewed by Ryosuke Niwa.
2279
2280         Adjust WebEditorClient for interface changes.
2281
2282         * WebCoreSupport/WebEditorClient.h:
2283
2284 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2285
2286         Remove ChromeClient::scrollbarsModeDidChange
2287         https://bugs.webkit.org/show_bug.cgi?id=175805
2288
2289         Reviewed by Daniel Bates.
2290
2291         * WebCoreSupport/WebChromeClient.h:
2292
2293 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2294
2295         Remove ChromeClient::hasOpenedPopup
2296         https://bugs.webkit.org/show_bug.cgi?id=175804
2297
2298         Reviewed by Sam Weinig.
2299
2300         * WebCoreSupport/WebChromeClient.h:
2301         * WebCoreSupport/WebChromeClient.mm:
2302         (WebChromeClient::hasOpenedPopup const): Deleted.
2303
2304 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
2305
2306         Disable access to secure cookies if an HTTPS site loads mixed content
2307         https://bugs.webkit.org/show_bug.cgi?id=157053
2308         <rdar://problem/11290808>
2309
2310         Reviewed by Dan Bates.
2311
2312         * WebCoreSupport/WebPlatformStrategies.h:
2313         * WebCoreSupport/WebPlatformStrategies.mm:
2314         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
2315         indicating whether secure cookies should be included in the response.
2316
2317 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2318
2319         [PAL] Move spi/mac directory into PAL
2320         https://bugs.webkit.org/show_bug.cgi?id=175649
2321
2322         Reviewed by Myles C. Maxfield.
2323
2324         * Misc/WebSharingServicePickerController.h:
2325         * WebCoreSupport/WebContextMenuClient.mm:
2326         * WebCoreSupport/WebEditorClient.mm:
2327         * WebCoreSupport/WebSelectionServiceController.mm:
2328         * WebView/WebHTMLView.mm:
2329         * WebView/WebImmediateActionController.h:
2330         * WebView/WebImmediateActionController.mm:
2331         * WebView/WebView.mm:
2332
2333 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2334
2335         [PAL] Relocate SessionID to root
2336         https://bugs.webkit.org/show_bug.cgi?id=175684
2337
2338         Reviewed by Alex Christensen.
2339
2340         * WebCoreSupport/WebFrameNetworkingContext.mm:
2341
2342 2017-08-17  Andreas Kling  <akling@apple.com>
2343
2344         Disable CSS regions at compile time
2345         https://bugs.webkit.org/show_bug.cgi?id=175630
2346
2347         Reviewed by Antti Koivisto.
2348
2349         * Configurations/FeatureDefines.xcconfig:
2350
2351 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2352
2353         [PAL] Move SessionID into PAL
2354         https://bugs.webkit.org/show_bug.cgi?id=174192
2355
2356         Reviewed by Antti Koivisto.
2357
2358         * Misc/WebCache.mm:
2359         (+[WebCache imageForURL:]):
2360         * WebCoreSupport/WebFrameLoaderClient.h:
2361         * WebCoreSupport/WebFrameLoaderClient.mm:
2362         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2363         * WebCoreSupport/WebFrameNetworkingContext.mm:
2364         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2365         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2366         (WebFrameNetworkingContext::storageSession const):
2367         * WebCoreSupport/WebPlatformStrategies.h:
2368         * WebCoreSupport/WebPlatformStrategies.mm:
2369         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2370         * WebKitPrefix.h:
2371
2372 2017-08-16  Andy Estes  <aestes@apple.com>
2373
2374         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
2375         https://bugs.webkit.org/show_bug.cgi?id=175648
2376
2377         Reviewed by Tim Horton.
2378
2379         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2380         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2381         (WebPaymentCoordinatorClient::showPaymentUI):
2382
2383 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2384
2385         [PAL] Move spi/ios and spi/win directories into PAL
2386         https://bugs.webkit.org/show_bug.cgi?id=175171
2387
2388         Reviewed by Antti Koivisto.
2389
2390         * WebCoreSupport/WebFrameLoaderClient.mm:
2391         * WebView/WebView.mm:
2392
2393 2017-08-16  Andy Estes  <aestes@apple.com>
2394
2395         [Payment Request] Add an ENABLE flag and an experimental feature preference
2396         https://bugs.webkit.org/show_bug.cgi?id=175622
2397
2398         Reviewed by Tim Horton.
2399
2400         * Configurations/FeatureDefines.xcconfig:
2401
2402 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
2403
2404         [PAL] Move Sleep classes into PAL
2405         https://bugs.webkit.org/show_bug.cgi?id=175456
2406
2407         Reviewed by Ryosuke Niwa.
2408
2409         * WebView/WebFullScreenController.h:
2410
2411 2017-08-15  Youenn Fablet  <youenn@apple.com>
2412
2413         [Cache API] Adding generic support for CacheStorage and Cache methods
2414         https://bugs.webkit.org/show_bug.cgi?id=175455
2415
2416         Reviewed by Chris Dumez.
2417
2418         * WebView/WebView.mm:
2419         (-[WebView _commonInitializationWithFrameName:groupName:]):
2420
2421 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2422
2423         Remove Proximity Events and related code
2424         https://bugs.webkit.org/show_bug.cgi?id=175545
2425
2426         Reviewed by Daniel Bates.
2427
2428         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
2429         and other related code.
2430
2431         * Configurations/FeatureDefines.xcconfig:
2432
2433 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2434
2435         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
2436         https://bugs.webkit.org/show_bug.cgi?id=175504
2437
2438         Reviewed by Sam Weinig.
2439
2440         * Configurations/FeatureDefines.xcconfig:
2441         * DOM/DOMHTMLFormElement.mm:
2442         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
2443         * WebCoreSupport/WebFrameLoaderClient.h:
2444
2445 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2446
2447         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
2448         https://bugs.webkit.org/show_bug.cgi?id=175557
2449
2450         Reviewed by Jon Lee.
2451
2452         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
2453
2454         * Configurations/FeatureDefines.xcconfig:
2455
2456 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2457
2458         Composition underline color is always black
2459         https://bugs.webkit.org/show_bug.cgi?id=174675
2460
2461         Reviewed by Ryosuke Niwa.
2462
2463         * WebView/WebHTMLView.mm:
2464         (extractUnderlines): If NSUnderlineColorAttributeName
2465         is not present use text color for composition underline.
2466         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
2467         for composition underline in the plain text case.
2468
2469 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
2470
2471         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
2472         https://bugs.webkit.org/show_bug.cgi?id=175474
2473         <rdar://problem/33844628>
2474
2475         Reviewed by Wenson Hsieh.
2476
2477         Replaced the build flag by a runtime flag and disabled the feature by default.
2478
2479         * Configurations/FeatureDefines.xcconfig:
2480         * WebView/WebPreferenceKeysPrivate.h:
2481         * WebView/WebPreferences.mm:
2482         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
2483         (-[WebPreferences dataTransferItemsEnabled]): Added.
2484         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
2485         * WebView/WebPreferencesPrivate.h:
2486         * WebView/WebView.mm:
2487         (-[WebView _preferencesChanged:]):
2488
2489 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2490
2491         Remove ENABLE_GAMEPAD_DEPRECATED
2492         https://bugs.webkit.org/show_bug.cgi?id=175361
2493
2494         Reviewed by Carlos Garcia Campos.
2495
2496         * Configurations/FeatureDefines.xcconfig:
2497
2498 2017-08-09  Chris Dumez  <cdumez@apple.com>
2499
2500         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
2501         https://bugs.webkit.org/show_bug.cgi?id=175401
2502
2503         Reviewed by Brady Eidson.
2504
2505         * WebView/WebPreferenceKeysPrivate.h:
2506         * WebView/WebPreferences.mm:
2507         (+[WebPreferences initialize]):
2508         (-[WebPreferences beaconAPIEnabled]): Deleted.
2509         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
2510         * WebView/WebPreferencesPrivate.h:
2511         * WebView/WebView.mm:
2512         (-[WebView _preferencesChanged:]):
2513
2514 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2515
2516         [PAL] Move spi/cocoa and spi/cg directories into PAL
2517         https://bugs.webkit.org/show_bug.cgi?id=175175
2518
2519         Reviewed by Myles C. Maxfield.
2520
2521         * History/WebHistory.mm:
2522         * Misc/WebDownload.mm:
2523         * Misc/WebKitNSStringExtras.mm:
2524         * Plugins/Hosted/NetscapePluginHostManager.mm:
2525         * Plugins/WebPluginDatabase.mm:
2526         * WebCoreSupport/WebFrameLoaderClient.mm:
2527         * WebInspector/WebNodeHighlight.mm:
2528         * WebView/WebHTMLView.mm:
2529         * WebView/WebIndicateLayer.mm:
2530         * WebView/WebView.mm:
2531         * WebView/WebViewData.h:
2532
2533 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2534
2535         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
2536         https://bugs.webkit.org/show_bug.cgi?id=175392
2537         <rdar://problem/33783207>
2538
2539         Reviewed by Tim Horton and Megan Gardner.
2540
2541         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
2542
2543         * Configurations/FeatureDefines.xcconfig:
2544
2545 2017-08-09  Daniel Bates  <dabates@apple.com>
2546
2547         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2548         https://bugs.webkit.org/show_bug.cgi?id=175247
2549         <rdar://problem/33679804>
2550
2551         Reviewed by Brady Eidson.
2552
2553         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2554         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2555         clients that need to make use of this information at this time. If such a needs comes up
2556         then we can expose API/SPI similar to what we do for WebKit.
2557
2558         * WebCoreSupport/WebFrameLoaderClient.h:
2559         * WebCoreSupport/WebFrameLoaderClient.mm:
2560         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2561
2562 2017-08-08  Brady Eidson  <beidson@apple.com>
2563
2564         Don't enable default icon loading in WK1 for apps linked against old SDKs.
2565         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
2566
2567         Reviewed by Andy Estes.
2568
2569         * Misc/WebKitVersionChecks.h:
2570         * WebCoreSupport/WebFrameLoaderClient.mm:
2571         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
2572           the app is linked against new WebKit with the new behavior.
2573
2574 2017-08-07  Devin Rousso  <drousso@apple.com>
2575
2576         Web Inspector: Preview Canvas path when viewing a recording
2577         https://bugs.webkit.org/show_bug.cgi?id=174967
2578
2579         Reviewed by Brian Burg.
2580
2581         * WebView/WebPreferenceKeysPrivate.h:
2582         * WebView/WebPreferences.mm:
2583         (+[WebPreferences initialize]):
2584         (-[WebPreferences inspectorAdditionsEnabled]):
2585         (-[WebPreferences setInspectorAdditionsEnabled:]):
2586         * WebView/WebPreferencesPrivate.h:
2587         * WebView/WebView.mm:
2588         (-[WebView _preferencesChanged:]):
2589         Add plumbing for new InspectorAdditions runtime flag.
2590
2591 2017-08-07  Brian Burg  <bburg@apple.com>
2592
2593         Remove CANVAS_PATH compilation guard
2594         https://bugs.webkit.org/show_bug.cgi?id=175207
2595
2596         Reviewed by Sam Weinig.
2597
2598         * Configurations/FeatureDefines.xcconfig:
2599
2600 2017-08-04  Youenn Fablet  <youenn@apple.com>
2601
2602         [Cache API] Add Cache and CacheStorage IDL definitions
2603         https://bugs.webkit.org/show_bug.cgi?id=175201
2604
2605         Reviewed by Brady Eidson.
2606
2607         * WebView/WebPreferenceKeysPrivate.h:
2608         * WebView/WebPreferences.mm:
2609         (+[WebPreferences initialize]):
2610         (-[WebPreferences cacheAPIEnabled]):
2611         (-[WebPreferences setCacheAPIEnabled:]):
2612         * WebView/WebPreferencesPrivate.h:
2613         * WebView/WebView.mm:
2614         (-[WebView _preferencesChanged:]):
2615
2616 2017-08-04  Matt Lewis  <jlewis3@apple.com>
2617
2618         Unreviewed, rolling out r220271.
2619
2620         Rolling out due to Layout Test failing on iOS Simulator.
2621
2622         Reverted changeset:
2623
2624         "Remove STREAMS_API compilation guard"
2625         https://bugs.webkit.org/show_bug.cgi?id=175165
2626         http://trac.webkit.org/changeset/220271
2627
2628 2017-08-04  Youenn Fablet  <youenn@apple.com>
2629
2630         Remove STREAMS_API compilation guard
2631         https://bugs.webkit.org/show_bug.cgi?id=175165
2632
2633         Reviewed by Darin Adler.
2634
2635         * Configurations/FeatureDefines.xcconfig:
2636         * WebView/WebPreferences.mm:
2637         (+[WebPreferences initialize]):
2638         * WebView/WebView.mm:
2639         (-[WebView _preferencesChanged:]):
2640
2641 2017-08-03  Brian Burg  <bburg@apple.com>
2642
2643         Remove ENABLE(WEB_SOCKET) guards
2644         https://bugs.webkit.org/show_bug.cgi?id=167044
2645
2646         Reviewed by Joseph Pecoraro.
2647
2648         * Configurations/FeatureDefines.xcconfig:
2649         * WebView/WebPreferencesPrivate.h:
2650
2651 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
2652
2653         [PAL] Move spi/cf directory into PAL
2654         https://bugs.webkit.org/show_bug.cgi?id=175057
2655
2656         Reviewed by Antti Koivisto.
2657
2658         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2659         * Plugins/WebNetscapePluginStream.mm:
2660         * WebCoreSupport/WebFrameNetworkingContext.mm:
2661         * WebView/WebPreferences.mm:
2662         * WebView/WebView.mm:
2663
2664 2017-08-03  Youenn Fablet  <youenn@apple.com>
2665
2666         Remove FETCH_API compilation guard
2667         https://bugs.webkit.org/show_bug.cgi?id=175154
2668
2669         Reviewed by Chris Dumez.
2670
2671         * Configurations/FeatureDefines.xcconfig:
2672         * WebView/WebPreferences.mm:
2673         (+[WebPreferences initialize]):
2674         * WebView/WebView.mm:
2675         (-[WebView _preferencesChanged:]):
2676
2677 2017-08-03  Brady Eidson  <beidson@apple.com>
2678
2679         Add SW IDLs and stub out basic functionality.
2680         https://bugs.webkit.org/show_bug.cgi?id=175115
2681
2682         Reviewed by Chris Dumez.
2683
2684         * Configurations/FeatureDefines.xcconfig:
2685
2686 2017-08-02  Sam Weinig  <sam@webkit.org>
2687
2688         [WebIDL] Convert MutationCallback to be a normal generated callback
2689         https://bugs.webkit.org/show_bug.cgi?id=174140
2690
2691         Reviewed by Darin Adler.
2692
2693         * DOM/DOMDocument.mm:
2694         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
2695         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
2696         Pass, now necessary, Document to NativeNodeFilter constructor.
2697
2698 2017-08-01  Chris Dumez  <cdumez@apple.com>
2699
2700         Add initial support for navigator.sendBeacon
2701         https://bugs.webkit.org/show_bug.cgi?id=175007
2702         <rdar://problem/33547728>
2703
2704         Reviewed by Sam Weinig.
2705
2706         Add setting to toggle support for the Beacon API (it is disabled by default).
2707
2708         * WebView/WebPreferenceKeysPrivate.h:
2709         * WebView/WebPreferences.mm:
2710         (+[WebPreferences initialize]):
2711         (-[WebPreferences beaconAPIEnabled]):
2712         (-[WebPreferences setBeaconAPIEnabled:]):
2713         * WebView/WebPreferencesPrivate.h:
2714         * WebView/WebView.mm:
2715         (-[WebView _preferencesChanged:]):
2716
2717 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
2718
2719         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
2720         https://bugs.webkit.org/show_bug.cgi?id=174437
2721
2722         Reviewed by Darin Adler.
2723
2724         Remove redundant Web- prefix from classes in WebKit namespace.
2725
2726         * WebView/WebView.mm:
2727         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
2728         * WebView/WebViewData.h:
2729         * WebView/WebViewData.mm:
2730
2731 2017-07-26  Brian Burg  <bburg@apple.com>
2732
2733         Remove WEB_TIMING feature flag
2734         https://bugs.webkit.org/show_bug.cgi?id=174795
2735
2736         Reviewed by Alex Christensen.
2737
2738         * Configurations/FeatureDefines.xcconfig:
2739
2740 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
2741
2742         Async image decoding for large images should be disabled after the first time a tile is painted
2743         https://bugs.webkit.org/show_bug.cgi?id=174451
2744         <rdar://problem/31246421>
2745
2746         Reviewed by Simon Fraser.
2747
2748         * WebView/WebFrame.mm:
2749         (-[WebFrame _paintBehaviorForDestinationContext:]):
2750         (-[WebFrame _drawRect:contentsOnly:]):
2751         * WebView/WebHTMLView.mm:
2752         (imageFromRect):
2753
2754 2017-07-23  Darin Adler  <darin@apple.com>
2755
2756         More NeverDestroyed and related cleanup
2757         https://bugs.webkit.org/show_bug.cgi?id=174745
2758
2759         Reviewed by Alex Christensen.
2760
2761         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
2762         for names that aren't even used in this file.
2763         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
2764         -[NSArray arrayWithObject:].
2765         (-[DOMNode absoluteQuads]): Ditto.
2766         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
2767         of writing out various types.
2768         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
2769         syntax instea of -[NSArray arrayWithObject:].
2770         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
2771         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
2772         of writing out various types.
2773         (-[DOMHTMLImageElement mimeType]): Ditto.
2774
2775 2017-07-24  Chris Dumez  <cdumez@apple.com>
2776
2777         ExceptionCode enumeration should use modern exception names
2778         https://bugs.webkit.org/show_bug.cgi?id=174794
2779
2780         Reviewed by Geoffrey Garen.
2781
2782         * DOM/ExceptionHandlers.mm:
2783         (raiseNotSupportedErrorException):
2784
2785 2017-07-23  Chris Dumez  <cdumez@apple.com>
2786
2787         Drop ExceptionCodeDescription class
2788         https://bugs.webkit.org/show_bug.cgi?id=174757
2789
2790         Reviewed by Darin Adler.
2791
2792         Stop using ExceptionCodeDescription.
2793
2794         * DOM/ExceptionHandlers.mm:
2795         (raiseDOMErrorException):
2796
2797 2017-07-21  Andreas Kling  <akling@apple.com>
2798
2799         Use more references in event dispatch code
2800         https://bugs.webkit.org/show_bug.cgi?id=174681
2801
2802         Reviewed by Geoffrey Garen.
2803
2804         * DOM/ObjCEventListener.h:
2805         * DOM/ObjCEventListener.mm:
2806         (WebCore::ObjCEventListener::handleEvent):
2807         * WebCoreSupport/WebFrameLoaderClient.mm:
2808         (NetscapePluginWidget::handleEvent):
2809
2810 2017-07-21  Brady Eidson  <beidson@apple.com>
2811
2812         Get rid of WebCore IconDatabase code.
2813         https://bugs.webkit.org/show_bug.cgi?id=174700
2814
2815         Reviewed by Tim Horton.
2816
2817         * Misc/WebCoreStatistics.mm:
2818         (+[WebCoreStatistics iconPageURLMappingCount]):
2819         (+[WebCoreStatistics iconRetainedPageURLCount]):
2820         (+[WebCoreStatistics iconRecordCount]):
2821         (+[WebCoreStatistics iconsWithDataCount]):
2822         * WebCoreSupport/WebFrameLoaderClient.h:
2823         * WebCoreSupport/WebFrameLoaderClient.mm:
2824         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
2825         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
2826         * WebView/WebView.mm:
2827         (-[WebView mainFrameIconURL]):
2828
2829 2017-07-20  Chris Dumez  <cdumez@apple.com>
2830
2831         Drop legacy XPathException type
2832         https://bugs.webkit.org/show_bug.cgi?id=174679
2833
2834         Reviewed by Sam Weinig.
2835
2836         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
2837         no longer expose XPathException.
2838
2839         * DOM/ExceptionHandlers.mm:
2840         (raiseDOMErrorException):
2841
2842 2017-07-20  Chris Dumez  <cdumez@apple.com>
2843
2844         Unreviewed, rolling out r219706.
2845
2846         Broke iOS build
2847
2848         Reverted changeset:
2849
2850         "Drop legacy XPathException type"
2851         https://bugs.webkit.org/show_bug.cgi?id=174679
2852         http://trac.webkit.org/changeset/219706
2853
2854 2017-07-20  Chris Dumez  <cdumez@apple.com>
2855
2856         Drop legacy XPathException type
2857         https://bugs.webkit.org/show_bug.cgi?id=174679
2858
2859         Reviewed by Sam Weinig.
2860
2861         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
2862         no longer expose XPathException.
2863
2864         * DOM/ExceptionHandlers.mm:
2865         (raiseDOMErrorException):
2866         * WebKit.exp:
2867
2868 2017-07-20  Chris Dumez  <cdumez@apple.com>
2869
2870         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
2871         https://bugs.webkit.org/show_bug.cgi?id=174660
2872
2873         Reviewed by Geoffrey Garen.
2874
2875         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
2876         This essentially replaces a branch to figure out if the new size is less or greater than the
2877         current size by an assertion.
2878
2879         * Plugins/WebNetscapePluginView.mm:
2880         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2881
2882 2017-07-20  Brady Eidson  <beidson@apple.com>
2883
2884         Deprecate WebIconDatabase in WebKitLegacy/mac.
2885         https://bugs.webkit.org/show_bug.cgi?id=174607
2886
2887         Reviewed by Alex Christensen.
2888
2889         This patch:
2890         1 - Formally deprecates WebIconDatabase (which was never API anyways)
2891         2 - Guts the class to where it can only return the default icon at the small size
2892         3 - Reworks other parts of WebKitLegacy that used it for anything to either
2893             use something else or to not do anything.
2894         
2895         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
2896         and that patch will remove all of the last remnants of WebIconDatabase.
2897         
2898         * History/WebHistoryItem.mm:
2899         (-[WebHistoryItem icon]):
2900
2901         * Misc/WebIconDatabase.h:
2902         * Misc/WebIconDatabase.mm:
2903         (-[WebIconDatabase init]):
2904         (-[WebIconDatabase iconForURL:withSize:cache:]):
2905         (-[WebIconDatabase iconForURL:withSize:]):
2906         (-[WebIconDatabase defaultIconWithSize:]):
2907         (-[WebIconDatabase defaultIconForURL:withSize:]):
2908         (-[WebIconDatabase iconURLForURL:]):
2909         (-[WebIconDatabase retainIconForURL:]):
2910         (-[WebIconDatabase releaseIconForURL:]):
2911         (+[WebIconDatabase delayDatabaseCleanup]):
2912         (+[WebIconDatabase allowDatabaseCleanup]):
2913         (-[WebIconDatabase setDelegate:]):
2914         (-[WebIconDatabase delegate]):
2915         (+[WebIconDatabase initialize]): Deleted.
2916         (-[WebIconDatabase isEnabled]): Deleted.
2917         (-[WebIconDatabase setEnabled:]): Deleted.
2918         (-[WebIconDatabase removeAllIcons]): Deleted.
2919         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
2920         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
2921         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
2922         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
2923         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
2924         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
2925         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
2926         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
2927         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
2928         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
2929         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
2930         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
2931         (-[WebIconDatabase _databaseDirectory]): Deleted.
2932         (webGetNSImage): Deleted.
2933
2934         * Misc/WebIconDatabaseDelegate.h: Removed.
2935         * Misc/WebIconDatabaseInternal.h: Removed.
2936         * Misc/WebIconDatabasePrivate.h: Removed.
2937
2938         * WebCoreSupport/WebFrameLoaderClient.mm:
2939         (webGetNSImage):
2940
2941         * WebCoreSupport/WebIconDatabaseClient.mm:
2942         (WebIconDatabaseClient::didRemoveAllIcons):
2943         (WebIconDatabaseClient::didImportIconURLForPageURL):
2944
2945         * WebView/WebView.mm:
2946         (-[WebView setFrameLoadDelegate:]):
2947         (-[WebView mainFrameIcon]):
2948
2949 2017-07-18  Andy Estes  <aestes@apple.com>
2950
2951         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2952         https://bugs.webkit.org/show_bug.cgi?id=174631
2953
2954         Reviewed by Tim Horton.
2955
2956         * Configurations/Base.xcconfig:
2957
2958 2017-07-18  Andy Estes  <aestes@apple.com>
2959
2960         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2961         https://bugs.webkit.org/show_bug.cgi?id=174631
2962
2963         Reviewed by Sam Weinig.
2964
2965         * Configurations/Base.xcconfig:
2966
2967 2017-07-18  Andy Estes  <aestes@apple.com>
2968
2969         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
2970         https://bugs.webkit.org/show_bug.cgi?id=174631
2971
2972         Reviewed by Dan Bernstein.
2973
2974         * Configurations/Base.xcconfig:
2975
2976 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2977
2978         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
2979         https://bugs.webkit.org/show_bug.cgi?id=174640
2980         <rdar://problem/33297400>
2981
2982         Reviewed by Tim Horton.
2983
2984         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
2985         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
2986         web thread here, to match the other WebView drag and drop SPI methods.
2987
2988         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
2989         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
2990         should make this robust against future UIKit changes that could make this no longer the case.
2991
2992         * WebView/WebView.mm:
2993         (-[WebView _requestStartDataInteraction:globalPosition:]):
2994         (-[WebView _dataInteractionCaretRect]):
2995
2996 2017-07-18  Andy Estes  <aestes@apple.com>
2997
2998         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2999         https://bugs.webkit.org/show_bug.cgi?id=174631
3000
3001         Reviewed by Darin Adler.
3002
3003         * Configurations/Base.xcconfig:
3004
3005 2017-07-17  Sam Weinig  <sam@webkit.org>
3006
3007         [WebIDL] Remove custom bindings that require non-caching JS strings
3008         https://bugs.webkit.org/show_bug.cgi?id=174552
3009
3010         Reviewed by Darin Adler.
3011
3012         * DOM/DOMHTMLCanvasElement.mm:
3013         (-[DOMHTMLCanvasElement toDataURL:]):
3014         Update to account for implementation now returning an UncachedString.
3015
3016 2017-07-17  Darin Adler  <darin@apple.com>
3017
3018         Improve use of NeverDestroyed
3019         https://bugs.webkit.org/show_bug.cgi?id=174348
3020
3021         Reviewed by Sam Weinig.
3022
3023         * Misc/WebStringTruncator.mm:
3024         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
3025         NeverDestroyed<RetainPtr> with just an NSFont * global.
3026
3027         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
3028         NeverDestroyed.h.
3029         * Storage/WebDatabaseManager.mm: Ditto.
3030         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
3031         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
3032
3033         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
3034         (aeDescFromJSValue): Removed double hashing by using the return value from
3035         add rather than calling contains before calling add.
3036
3037 2017-07-14  Jer Noble  <jer.noble@apple.com>
3038
3039         Allow clients to override their own hardware media requirements where no fallback media exists.
3040         https://bugs.webkit.org/show_bug.cgi?id=174426
3041         <rdar://problem/32537704>
3042
3043         Reviewed by Eric Carlson.
3044
3045         Add a new WebPreferences property to control WebCore's new
3046         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
3047
3048         * WebView/WebPreferenceKeysPrivate.h:
3049         * WebView/WebPreferences.mm:
3050         (+[WebPreferences initialize]):
3051         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
3052         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
3053         * WebView/WebPreferencesPrivate.h:
3054         * WebView/WebView.mm:
3055         (-[WebView _preferencesChanged:]):
3056
3057 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
3058
3059         Async image decoding for large images should be disabled by default
3060         https://bugs.webkit.org/show_bug.cgi?id=174432
3061
3062         Reviewed by Simon Fraser.
3063
3064         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
3065         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
3066         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
3067            a child view instead of propagating PaintBehaviorSnapshotting.
3068         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
3069            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
3070
3071         * WebView/WebFrame.mm:
3072         (-[WebFrame _paintBehaviorForDestinationContext:]):
3073         (-[WebFrame _drawRect:contentsOnly:]):
3074         * WebView/WebHTMLView.mm:
3075         (imageFromRect):
3076
3077 2017-07-12  Daniel Bates  <dabates@apple.com>
3078
3079         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3080         https://bugs.webkit.org/show_bug.cgi?id=174427
3081
3082         Rubber-stamped by Brady Eidson.
3083
3084         * WebView/WebPDFView.mm:
3085         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3086
3087 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3088
3089         Unreviewed, rolling out r219401.
3090
3091         This revision rolled out the previous patch, but after talking
3092         with reviewer, a rebaseline is what was needed.Rolling back in
3093         before rebaseline.
3094
3095         Reverted changeset:
3096
3097         "Unreviewed, rolling out r219379."
3098         https://bugs.webkit.org/show_bug.cgi?id=174400
3099         http://trac.webkit.org/changeset/219401
3100
3101 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3102
3103         Unreviewed, rolling out r219379.
3104
3105         This revision caused a consistent failure in the test
3106         fast/dom/Window/property-access-on-cached-window-after-frame-
3107         removed.html.
3108
3109         Reverted changeset:
3110
3111         "Remove NAVIGATOR_HWCONCURRENCY"
3112         https://bugs.webkit.org/show_bug.cgi?id=174400
3113         http://trac.webkit.org/changeset/219379
3114
3115 2017-07-11  Dean Jackson  <dino@apple.com>
3116
3117         Remove NAVIGATOR_HWCONCURRENCY
3118         https://bugs.webkit.org/show_bug.cgi?id=174400
3119
3120         * Configurations/FeatureDefines.xcconfig:
3121
3122 2017-07-11  Dean Jackson  <dino@apple.com>
3123
3124         Rolling out r219372.
3125
3126         * Configurations/FeatureDefines.xcconfig:
3127
3128 2017-07-11  Dean Jackson  <dino@apple.com>
3129
3130         Remove NAVIGATOR_HWCONCURRENCY
3131         https://bugs.webkit.org/show_bug.cgi?id=174400
3132
3133         * Configurations/FeatureDefines.xcconfig:
3134
3135 2017-07-03  Brian Burg  <bburg@apple.com>
3136
3137         Web Replay: remove some unused code
3138         https://bugs.webkit.org/show_bug.cgi?id=173903
3139
3140         Rubber-stamped by Joseph Pecoraro.
3141
3142         * Configurations/FeatureDefines.xcconfig:
3143
3144 2017-07-09  Brady Eidson  <beidson@apple.com>
3145
3146         Remove some obsolete WebKitVersionChecks.
3147         https://bugs.webkit.org/show_bug.cgi?id=174294
3148
3149         Reviewed by Dan Bernstein.
3150
3151         * Misc/WebKitVersionChecks.h:
3152
3153         * WebView/WebHTMLView.mm:
3154         (-[WebHTMLView hitTest:]):
3155
3156         * WebView/WebView.mm:
3157         (shouldRespectPriorityInCSSAttributeSetters):
3158         (-[WebView _commonInitializationWithFrameName:groupName:]):
3159         (-[WebView _preferencesChanged:]):
3160         (shouldTransformsAffectOverflow): Deleted.
3161         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
3162
3163 2017-07-08  Brady Eidson  <beidson@apple.com>
3164
3165         Remove some obsolete RuntimeApplicationChecks.
3166         https://bugs.webkit.org/show_bug.cgi?id=174293
3167
3168         Reviewed by Dan Bernstein.
3169
3170         * Misc/WebKitVersionChecks.h:
3171         * WebView/WebView.mm:
3172         (+[WebView enableWebThread]):
3173         (-[WebView _needsPreHTML5ParserQuirks]):
3174
3175 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3176
3177         Drop NOSNIFF compile flag
3178         https://bugs.webkit.org/show_bug.cgi?id=174289
3179
3180         Reviewed by Michael Catanzaro.
3181
3182         * Configurations/FeatureDefines.xcconfig:
3183
3184 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3185
3186         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3187         https://bugs.webkit.org/show_bug.cgi?id=174150
3188
3189         Reviewed by Mark Lam.
3190
3191         * DOM/DOM.mm:
3192         (lookupElementClass):
3193
3194 2017-07-06  Brady Eidson  <beidson@apple.com>
3195
3196         Add logging to first attempt to use the WebIconDatabase class.
3197         https://bugs.webkit.org/show_bug.cgi?id=174190
3198
3199         Reviewed by Andy Estes.
3200
3201         * Misc/WebIconDatabase.mm:
3202         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
3203         * Misc/WebKitVersionChecks.h:
3204
3205 2017-07-06  Matt Lewis  <jlewis3@apple.com>
3206
3207         Unreviewed, rolling out r219178.
3208
3209         This caused a consistent failure with the API test
3210         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
3211
3212         Reverted changeset:
3213
3214         "[WTF] Clean up StringStatics.cpp by using
3215         LazyNeverDestroyed<> for Atoms"
3216         https://bugs.webkit.org/show_bug.cgi?id=174150
3217         http://trac.webkit.org/changeset/219178
3218
3219 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3220
3221         [WTF] Move SoftLinking.h into WTF
3222         https://bugs.webkit.org/show_bug.cgi?id=174000
3223
3224         Reviewed by Alex Christensen.
3225
3226         * Plugins/WebNetscapePluginView.mm:
3227         * Plugins/WebPluginController.mm:
3228         * WebCoreSupport/WebInspectorClient.mm:
3229         * WebView/WebFullScreenController.mm:
3230         * WebView/WebImmediateActionController.mm:
3231         * WebView/WebView.mm:
3232
3233 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3234
3235         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3236         https://bugs.webkit.org/show_bug.cgi?id=174150
3237
3238         Reviewed by Mark Lam.
3239
3240         * DOM/DOM.mm:
3241         (lookupElementClass):
3242
3243 2017-07-05  Brady Eidson  <beidson@apple.com>
3244
3245         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3246         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3247
3248         Reviewed by Alex Christensen.
3249
3250         Adopt to the new constructor for FrameLoadRequest.
3251
3252         * WebView/WebPDFView.mm:
3253         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3254
3255 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3256
3257         Make WebKit's public headers on Mac and iOS C++ module safe
3258         https://bugs.webkit.org/show_bug.cgi?id=174175
3259
3260         Reviewed by Alex Christensen.
3261
3262         Fixed the header files.
3263
3264         * Misc/WebDownload.h:
3265         * Misc/WebKitErrors.h:
3266         * Plugins/WebPluginContainer.h:
3267         * WebView/WebResourceLoadDelegate.h:
3268
3269 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3270
3271         Remove copy of ICU headers from WebKit
3272         https://bugs.webkit.org/show_bug.cgi?id=116407
3273
3274         Reviewed by Alex Christensen.
3275
3276         Use WTF's copy of ICU headers.
3277
3278         * Configurations/WebKitLegacy.xcconfig:
3279         * icu/unicode/localpointer.h: Removed.
3280         * icu/unicode/parseerr.h: Removed.
3281         * icu/unicode/platform.h: Removed.
3282         * icu/unicode/ptypes.h: Removed.
3283         * icu/unicode/putil.h: Removed.
3284         * icu/unicode/uchar.h: Removed.
3285         * icu/unicode/uconfig.h: Removed.
3286         * icu/unicode/ucurr.h: Removed.
3287         * icu/unicode/uidna.h: Removed.
3288         * icu/unicode/uiter.h: Removed.
3289         * icu/unicode/umachine.h: Removed.
3290         * icu/unicode/unorm.h: Removed.
3291         * icu/unicode/unorm2.h: Removed.
3292         * icu/unicode/urename.h: Removed.
3293         * icu/unicode/uscript.h: Removed.
3294         * icu/unicode/ustring.h: Removed.
3295         * icu/unicode/utf.h: Removed.
3296         * icu/unicode/utf16.h: Removed.
3297         * icu/unicode/utf8.h: Removed.
3298         * icu/unicode/utf_old.h: Removed.
3299         * icu/unicode/utypes.h: Removed.
3300         * icu/unicode/uvernum.h: Removed.
3301         * icu/unicode/uversion.h: Removed.
3302
3303 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3304
3305         Add WebKitPrivateFrameworkStubs for iOS 11
3306         https://bugs.webkit.org/show_bug.cgi?id=173988
3307
3308         Reviewed by David Kilzer.
3309
3310         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
3311         use the same directory for private framework stubs.
3312
3313 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3314
3315         Unreviewed, rolling out r219103.
3316
3317         Caused multiple build failures.
3318
3319         Reverted changeset:
3320
3321         "Remove copy of ICU headers from WebKit"
3322         https://bugs.webkit.org/show_bug.cgi?id=116407
3323         http://trac.webkit.org/changeset/219103
3324
3325 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3326
3327         Remove copy of ICU headers from WebKit
3328         https://bugs.webkit.org/show_bug.cgi?id=116407
3329
3330         Reviewed by Alex Christensen.
3331
3332         Use WTF's copy of ICU headers.
3333
3334         * Configurations/WebKitLegacy.xcconfig:
3335         * icu/unicode/localpointer.h: Removed.
3336         * icu/unicode/parseerr.h: Removed.
3337         * icu/unicode/platform.h: Removed.
3338         * icu/unicode/ptypes.h: Removed.
3339         * icu/unicode/putil.h: Removed.
3340         * icu/unicode/uchar.h: Removed.
3341         * icu/unicode/uconfig.h: Removed.
3342         * icu/unicode/ucurr.h: Removed.
3343         * icu/unicode/uidna.h: Removed.
3344         * icu/unicode/uiter.h: Removed.
3345         * icu/unicode/umachine.h: Removed.
3346         * icu/unicode/unorm.h: Removed.
3347         * icu/unicode/unorm2.h: Removed.
3348         * icu/unicode/urename.h: Removed.
3349         * icu/unicode/uscript.h: Removed.
3350         * icu/unicode/ustring.h: Removed.
3351         * icu/unicode/utf.h: Removed.
3352         * icu/unicode/utf16.h: Removed.
3353         * icu/unicode/utf8.h: Removed.
3354         * icu/unicode/utf_old.h: Removed.
3355         * icu/unicode/utypes.h: Removed.
3356         * icu/unicode/uvernum.h: Removed.
3357         * icu/unicode/uversion.h: Removed.
3358
3359 2017-07-03  Brady Eidson  <beidson@apple.com>
3360
3361         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3362         https://bugs.webkit.org/show_bug.cgi?id=174073
3363
3364         Reviewed by Andy Estes.
3365
3366         WebView now keeps a direct copy of its main frame icon as a member variable.
3367         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
3368         
3369         This change causes a progression in KVO observation of the mainFrameIcon property as we now
3370         have both the old icon and new icon at the time it changes.
3371
3372         * WebCoreSupport/WebFrameLoaderClient.h:
3373         * WebCoreSupport/WebFrameLoaderClient.mm:
3374         (WebFrameLoaderClient::prepareForDataSourceReplacement):
3375         (WebFrameLoaderClient::getLoadDecisionForIcons):
3376         (WebFrameLoaderClient::finishedLoadingIcon):
3377         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3378         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3379
3380         * WebView/WebView.mm:
3381         (+[WebView _setIconLoadingEnabled:]):
3382         (+[WebView _isIconLoadingEnabled]):
3383         (-[WebView mainFrameIcon]):
3384         (-[WebView _setMainFrameIcon:]):
3385         (-[WebView _receivedIconChangedNotification:]): Deleted.
3386         (-[WebView _registerForIconNotification:]): Deleted.
3387         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
3388         * WebView/WebViewData.h:
3389         * WebView/WebViewInternal.h:
3390         * WebView/WebViewPrivate.h:
3391
3392 2017-07-03  Sam Weinig  <sam@webkit.org>
3393
3394         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
3395         https://bugs.webkit.org/show_bug.cgi?id=174083
3396
3397         Reviewed by Alex Christensen.
3398
3399         * Configurations/FeatureDefines.xcconfig:
3400         Add ENABLE_NAVIGATOR_STANDALONE.
3401
3402 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3403
3404         Expose unobscuredSafeAreaInsets on WebView
3405         https://bugs.webkit.org/show_bug.cgi?id=174075
3406         <rdar://problem/33096997>
3407
3408         Reviewed by Beth Dakin.
3409
3410         * WebView/WebView.mm:
3411         (-[WebView _setUnobscuredSafeAreaInsets:]):
3412         (-[WebView _unobscuredSafeAreaInsets]):
3413         * WebView/WebViewPrivate.h:
3414         Expose unobscuredSafeAreaInsets as a new private property on WebView,
3415         similar to how it is exposed in WebKit2.
3416
3417 2017-07-03  Andy Estes  <aestes@apple.com>
3418
3419         [Xcode] Add an experimental setting to build with ccache
3420         https://bugs.webkit.org/show_bug.cgi?id=173875
3421
3422         Reviewed by Tim Horton.
3423
3424         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3425
3426 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3427
3428         Expose WebPreferences for viewport-fit and constant() properties
3429         https://bugs.webkit.org/show_bug.cgi?id=174072
3430         <rdar://problem/33096639>
3431
3432         Reviewed by Ryosuke Niwa.
3433
3434         * WebView/WebPreferenceKeysPrivate.h:
3435         * WebView/WebPreferences.mm:
3436         (-[WebPreferences viewportFitEnabled]):
3437         (-[WebPreferences setViewportFitEnabled:]):
3438         (-[WebPreferences constantPropertiesEnabled]):
3439         (-[WebPreferences setConstantPropertiesEnabled:]):
3440         * WebView/WebPreferencesPrivate.h:
3441         * WebView/WebView.mm:
3442         (-[WebView _preferencesChanged:]):
3443
3444 2017-07-01  Tim Horton  <timothy_horton@apple.com>
3445
3446         Expose viewport-fit value to UIKit via viewport arguments dictionary
3447         https://bugs.webkit.org/show_bug.cgi?id=174071
3448         <rdar://problem/33096620>
3449
3450         Reviewed by Wenson Hsieh.
3451
3452         * History/WebHistoryItem.mm:
3453         * History/WebHistoryItemPrivate.h:
3454         Add another dictionary key and three values.
3455
3456 2017-07-01  Dan Bernstein  <mitz@apple.com>
3457
3458         [iOS] Remove code only needed when building for iOS 9.x
3459         https://bugs.webkit.org/show_bug.cgi?id=174068
3460
3461         Reviewed by Tim Horton.
3462
3463         * Configurations/FeatureDefines.xcconfig:
3464
3465 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3466
3467         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3468         https://bugs.webkit.org/show_bug.cgi?id=174004
3469
3470         Reviewed by Simon Fraser.
3471
3472         * WebCoreSupport/WebPluginInfoProvider.mm:
3473
3474 2017-07-01  Dan Bernstein  <mitz@apple.com>
3475
3476         [macOS] Remove code only needed when building for OS X Yosemite
3477         https://bugs.webkit.org/show_bug.cgi?id=174067
3478
3479         Reviewed by Tim Horton.
3480
3481         * Configurations/Base.xcconfig:
3482         * Configurations/DebugRelease.xcconfig:
3483         * Configurations/FeatureDefines.xcconfig:
3484         * Configurations/Version.xcconfig:
3485         * Plugins/WebBasePluginPackage.mm:
3486         (-[WebBasePluginPackage getPluginInfoFromPLists]):
3487         * WebCoreSupport/PopupMenuMac.mm:
3488         (PopupMenuMac::show):
3489         * WebCoreSupport/WebInspectorClient.mm:
3490         (WebInspectorFrontendClient::startWindowDrag):
3491         (-[WebInspectorWindowController window]):
3492         * WebView/WebView.mm:
3493         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3494
3495 2017-06-30  Daniel Bates  <dabates@apple.com>
3496
3497         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3498         https://bugs.webkit.org/show_bug.cgi?id=165160
3499         <rdar://problem/29451999>
3500
3501         Reviewed by Brady Eidson.
3502
3503         Pass the document that is requesting the load to the loader.
3504
3505         * WebView/WebPDFView.mm:
3506         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3507
3508 2017-06-29  Jer Noble  <jer.noble@apple.com>
3509
3510         Make Legacy EME API controlled by RuntimeEnabled setting.
3511         https://bugs.webkit.org/show_bug.cgi?id=173994
3512
3513         Reviewed by Sam Weinig.
3514
3515         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
3516
3517         * Configurations/FeatureDefines.xcconfig:
3518         * WebView/WebPreferenceKeysPrivate.h:
3519         * WebView/WebPreferences.mm:
3520         (+[WebPreferences initialize]):
3521         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
3522         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
3523         * WebView/WebPreferencesPrivate.h:
3524         * WebView/WebView.mm:
3525         (-[WebView _preferencesChanged:]):
3526
3527 2017-06-30  Chris Dumez  <cdumez@apple.com>
3528
3529         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
3530         https://bugs.webkit.org/show_bug.cgi?id=174013
3531
3532         Reviewed by Brent Fulgham.
3533
3534         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
3535         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
3536
3537         * WebView/WebView.mm:
3538         (-[WebView _commonInitializationWithFrameName:groupName:]):
3539
3540 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3541
3542         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3543         https://bugs.webkit.org/show_bug.cgi?id=174017
3544         <rdar://problem/32959782>
3545
3546         Reviewed by Simon Fraser.
3547
3548         Use root view coordinates when computing the drag caret rect.
3549
3550         * WebView/WebView.mm:
3551         (-[WebView _dataInteractionCaretRect]):
3552
3553 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
3554
3555         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
3556         https://bugs.webkit.org/show_bug.cgi?id=173899
3557         rdar://problem/32994474
3558
3559         Reviewed by Tim Horton.
3560
3561         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
3562         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
3563         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
3564
3565         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
3566         documentView is a WebHTMLView.
3567
3568         * WebView/WebFrame.mm:
3569         (-[WebFrame _webHTMLDocumentView]):
3570         (-[WebFrame _paintBehaviorForDestinationContext:]):
3571         (-[WebFrame _drawRect:contentsOnly:]):
3572         (-[WebFrame setTimeoutsPaused:]):
3573         (-[WebFrame prepareForPause]):
3574         (-[WebFrame resumeFromPause]):
3575         (-[WebFrame resetTextAutosizingBeforeLayout]):
3576         * WebView/WebHTMLView.mm:
3577         (-[WebHTMLView drawLayer:inContext:]):
3578         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
3579         * WebView/WebHTMLViewInternal.h:
3580
3581 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3582
3583         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
3584         https://bugs.webkit.org/show_bug.cgi?id=173854
3585         <rdar://problem/32236827>
3586
3587         Reviewed by Ryosuke Niwa and Tim Horton.
3588
3589         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
3590         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
3591
3592         * WebView/WebView.mm:
3593         (-[WebView _startDrag:]):
3594         (-[WebView _dragSourceAction]):
3595         (-[WebView _draggedLinkTitle]):
3596         (-[WebView _draggedLinkURL]):
3597         (-[WebView _draggedElementBounds]):
3598         (-[WebView _endedDataInteraction:global:]):
3599         * WebView/WebViewData.h:
3600         * WebView/WebViewPrivate.h:
3601
3602 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3603
3604         Refactor drag start codepaths to plumb a DragItem to client layers
3605         https://bugs.webkit.org/show_bug.cgi?id=173832
3606         Work towards <rdar://problem/32236827>
3607
3608         Reviewed by Ryosuke Niwa and Tim Horton.
3609
3610         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
3611         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
3612         to _startDrag: to match logic used to start a drag on other platforms.
3613
3614         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
3615         through the DragItem struct.
3616
3617         * WebCoreSupport/WebDragClient.h:
3618         * WebCoreSupport/WebDragClient.mm:
3619         (WebDragClient::startDrag):
3620         (WebDragClient::dragSourceActionMaskForPoint):
3621         (WebDragClient::willPerformDragSourceAction):
3622         (WebDragClient::beginDrag):
3623         * WebView/WebView.mm:
3624         (-[WebView _startDrag:]):
3625         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
3626         * WebView/WebViewInternal.h:
3627
3628 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3629
3630         Remove excessive headers from JavaScriptCore
3631         https://bugs.webkit.org/show_bug.cgi?id=173812
3632
3633         Reviewed by Darin Adler.
3634
3635         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3636         * WebView/WebView.mm:
3637
3638 2017-06-23  Tim Horton  <timothy_horton@apple.com>
3639
3640         Remove an unused typedef from WebFrameLoaderClient
3641         https://bugs.webkit.org/show_bug.cgi?id=173795
3642
3643         Reviewed by Simon Fraser.
3644
3645         * WebCoreSupport/WebFrameLoaderClient.h:
3646         This unused typedef in the global namespace conflicts with one in a macOS system header.
3647         Also... it's unused.
3648         Remove it.
3649
3650 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3651
3652         Remove excessive headers from WebCore/{bindings,css,dom}
3653         https://bugs.webkit.org/show_bug.cgi?id=173766
3654
3655         Reviewed by Simon Fraser.
3656
3657         * DOM/DOMInternal.mm:
3658
3659 2017-06-22  Daniel Bates  <dabates@apple.com>
3660
3661         Make FrameLoadRequest a move-only type
3662         https://bugs.webkit.org/show_bug.cgi?id=173682
3663
3664         Reviewed by Alex Christensen and Darin Adler.
3665
3666         A FrameLoadRequest groups together the information to perform a load into a single object
3667         that is more manageable to pass around than its constituent parts. Code that receives a
3668         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3669         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3670         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
3671
3672         * Plugins/WebPluginController.mm:
3673         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
3674         * WebView/WebPDFView.mm:
3675         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3676
3677 2017-06-21  Antoine Quint  <graouts@apple.com>
3678
3679         Ensure DRT always logs rAF suspension debugging code
3680         https://bugs.webkit.org/show_bug.cgi?id=173681
3681
3682         Reviewed by Tim "Mr. T" Horton.
3683
3684         * WebView/WebPreferenceKeysPrivate.h:
3685         * WebView/WebPreferences.mm:
3686         (+[WebPreferences initialize]):
3687         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
3688         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
3689         * WebView/WebPreferencesPrivate.h:
3690         * WebView/WebView.mm:
3691         (-[WebView _preferencesChanged:]):
3692
3693 2017-06-21  Daniel Bates  <dabates@apple.com>
3694
3695         Cleanup FrameLoadRequest
3696         https://bugs.webkit.org/show_bug.cgi?id=173564
3697         <rdar://problem/32903570>
3698
3699         Reviewed by Brent Fulgham.
3700
3701         * WebView/WebPDFView.mm:
3702         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
3703         into a local variable and use C++11 brace initialization syntax to make it easier to identify
3704         the arguments passed to FrameLoader::loadFrameRequest().
3705
3706 2017-06-21  Antoine Quint  <graouts@apple.com>
3707
3708         Add logging to identify when the Page suspends scripted animations
3709         https://bugs.webkit.org/show_bug.cgi?id=173626
3710
3711         Reviewed by Tim Horton.
3712
3713         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
3714         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
3715
3716         * WebView/WebPreferenceKeysPrivate.h:
3717         * WebView/WebPreferences.mm:
3718         (+[WebPreferences initialize]):
3719         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
3720         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
3721         * WebView/WebPreferencesPrivate.h:
3722         * WebView/WebView.mm:
3723         (-[WebView _preferencesChanged:]):
3724
3725 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3726
3727         Disable font variations on macOS Sierra and iOS 10
3728         https://bugs.webkit.org/show_bug.cgi?id=173618
3729         <rdar://problem/32879164>
3730
3731         Reviewed by Jon Lee.
3732
3733         * Configurations/FeatureDefines.xcconfig:
3734
3735 2017-06-20  Daniel Bates  <dabates@apple.com>
3736
3737         Have FrameLoadRequest takes a Frame& instead of a Frame*
3738         https://bugs.webkit.org/show_bug.cgi?id=173614
3739         <rdar://problem/32884890>
3740
3741         Reviewed by Brent Fulgham.
3742
3743         * Plugins/WebPluginController.mm:
3744         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
3745         * WebView/WebFrame.mm:
3746         (-[WebFrame loadRequest:]):
3747         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
3748
3749 2017-06-19  Frederic Wang  <fwang@igalia.com>
3750
3751         [Mac] Add an experimental feature setting for async frame scrolling
3752         https://bugs.webkit.org/show_bug.cgi?id=173359
3753
3754         Reviewed by Simon Fraser.
3755
3756         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
3757         * WebView/WebPreferences.mm:
3758         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
3759         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
3760         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
3761         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
3762         * WebView/WebView.mm:
3763         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
3764         scrolling.
3765
3766 2017-06-19  Chris Dumez  <cdumez@apple.com>
3767
3768         Use WTF::Function instead of std::function in more places in WebCore/
3769         https://bugs.webkit.org/show_bug.cgi?id=173535
3770
3771         Reviewed by Antti Koivisto.
3772
3773         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
3774
3775         * WebCoreSupport/WebFrameLoaderClient.h:
3776         * WebCoreSupport/WebFrameLoaderClient.mm:
3777         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3778         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3779         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3780         (WebFrameLoaderClient::dispatchWillSubmitForm):
3781         (WebFrameLoaderClient::setUpPolicyListener):
3782         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
3783         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
3784
3785 2017-05-14 Frederic Wang  <fwang@igalia.com>
3786
3787         Add heuristic to avoid flattening "fullscreen" iframes
3788         https://bugs.webkit.org/show_bug.cgi?id=171914
3789
3790         Reviewed by Simon Fraser.
3791
3792         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
3793
3794         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
3795         * WebView/WebPreferences.mm:
3796         (+[WebPreferences initialize]): Handle frame flattening as an enum.
3797         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
3798         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
3799         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
3800         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
3801         * WebView/WebPreferencesPrivate.h: Ditto.
3802         * WebView/WebView.mm:
3803         (-[WebView _preferencesChanged:]): Ditto.
3804         * WebView/WebPreferencesPrivate.h: Add new enum definition.
3805
3806 2017-06-17  Chris Dumez  <cdumez@apple.com>
3807
3808         Use WTF::Function instead of std::function in WebKit2/
3809         https://bugs.webkit.org/show_bug.cgi?id=173504
3810
3811         Reviewed by Darin Adler.
3812
3813         Use WTF::Function instead of std::function in WebKit2/ to avoid
3814         unnecessary copying.
3815
3816         * Plugins/Hosted/HostedNetscapePluginStream.h:
3817         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3818         (WebKit::HostedNetscapePluginStream::willSendRequest):
3819         * Plugins/WebNetscapePluginStream.h:
3820         * Plugins/WebNetscapePluginStream.mm:
3821         (WebNetscapePluginStream::willSendRequest):
3822         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3823         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3824         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
3825         (WebPaymentCoordinatorClient::openPaymentSetup):
3826
3827 2017-06-16  Sam Weinig  <sam@webkit.org>
3828
3829         [WebIDL] Remove custom bindings for HTMLDocument
3830         https://bugs.webkit.org/show_bug.cgi?id=173444
3831
3832         Reviewed by Darin Adler.
3833
3834         * DOM/DOMHTMLDocument.mm:
3835         (-[DOMHTMLDocument linkColor]):
3836         (-[DOMHTMLDocument setLinkColor:]):
3837         (-[DOMHTMLDocument write:]):
3838         (-[DOMHTMLDocument writeln:]):
3839         Update for new signature of write/writeln and rename of linkColor to linkColorForBindings.
3840
3841 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3842
3843         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
3844         https://bugs.webkit.org/show_bug.cgi?id=173366
3845         <rdar://problem/32767014>
3846
3847         Reviewed by Tim Horton.
3848
3849         Move pieces of iOS WebKit1 drag and drop implementation into OpenSource. No change in behavior.
3850
3851         * Configurations/FeatureDefines.xcconfig:
3852         * WebCoreSupport/WebDragClient.mm:
3853         (WebDragClient::useLegacyDragClient):
3854         (WebDragClient::willPerformDragDestinationAction):
3855         (WebDragClient::dragSourceActionMaskForPoint):
3856         (WebDragClient::willPerformDragSourceAction):
3857         (WebDragClient::startDrag):
3858         (WebDragClient::beginDrag):
3859         (WebDragClient::declareAndWriteDragImage):
3860         (WebDragClient::declareAndWriteAttachment):
3861         (WebDragClient::didConcludeEditDrag):
3862         * WebView/WebView.mm:
3863         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
3864         (-[WebView _getDataInteractionData]):
3865         (-[WebView dragDataForSession:client:global:operation:]):
3866         (-[WebView _enteredDataInteraction:client:global:operation:]):
3867         (-[WebView _updatedDataInteraction:client:global:operation:]):
3868         (-[WebView _exitedDataInteraction:client:global:operation:]):
3869         (-[WebView _performDataInteraction:client:global:operation:]):
3870         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3871         (-[WebView _endedDataInteraction:global:]):
3872         (-[WebView _didConcludeEditDataInteraction]):
3873         (floatRectsForCGRectArray): Deleted.
3874         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]): Deleted.
3875         * WebView/WebViewData.h:
3876         * WebView/WebViewData.mm:
3877         (-[WebViewPrivate dealloc]):
3878         * WebView/WebViewPrivate.h:
3879
3880 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3881
3882         [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default
3883         https://bugs.webkit.org/show_bug.cgi?id=173454
3884         <rdar://problem/31720671>
3885
3886         Reviewed by Tim Horton.
3887
3888         Adds -webView:dragDestinationActionMaskForSession: as SPI to WebUIDelegate.
3889         If unimplemented, the default UI delegate allows all actions except for URL loading.
3890
3891         * DefaultDelegates/WebDefaultUIDelegate.mm:
3892         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForSession:]):
3893         * WebView/WebUIDelegatePrivate.h:
3894         * WebView/WebView.mm:
3895         (-[WebView dragDestinationActionMaskForSession:]):
3896
3897 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3898
3899         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
3900         https://bugs.webkit.org/show_bug.cgi?id=173338
3901         <rdar://problem/32777720>
3902
3903         Reviewed by Tim Horton.
3904
3905         Rename updatePreferredTypeIdentifiers to updateSupportedTypeIdentifiers.
3906
3907         * WebCoreSupport/WebPlatformStrategies.h:
3908         * WebCoreSupport/WebPlatformStrategies.mm:
3909         (WebPlatformStrategies::updateSupportedTypeIdentifiers):
3910         (WebPlatformStrategies::updatePreferredTypeIdentifiers): Deleted.
3911
3912 2017-06-13  Daniel Bates  <dabates@apple.com>
3913
3914         Implement W3C Secure Contexts Draft Specification
3915         https://bugs.webkit.org/show_bug.cgi?id=158121
3916         <rdar://problem/26012994>
3917
3918         Reviewed by Brent Fulgham.
3919
3920         Part 4
3921
3922         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3923
3924         * WebView/WebPreferenceKeysPrivate.h:
3925         * WebView/WebPreferences.mm:
3926         (+[WebPreferences initialize]):
3927         (-[WebPreferences isSecureContextAttributeEnabled]):
3928         (-[WebPreferences setIsSecureContextAttributeEnabled:]):
3929         * WebView/WebPreferencesPrivate.h:
3930         * WebView/WebView.mm:
3931         (-[WebView _preferencesChanged:]):
3932
3933 2017-06-13  Sam Weinig  <sam@webkit.org>
3934
3935         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
3936         https://bugs.webkit.org/show_bug.cgi?id=80733
3937
3938         Reviewed by Chris Dumez.
3939
3940         * DOM/DOMUtility.mm:
3941         (createDOMWrapper):
3942         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3943         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3944         * WebView/WebFrame.mm:
3945         (-[WebFrame _attachScriptDebugger]):
3946         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3947
3948 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
3949
3950         [WebCrypto] Remove experimental feature flag of SubtleCrypto
3951         https://bugs.webkit.org/show_bug.cgi?id=173197
3952         <rdar://problem/32688148>
3953
3954         Reviewed by Brent Fulgham.
3955
3956         * WebView/WebPreferences.mm:
3957         (+[WebPreferences initialize]):
3958         (-[WebPreferences subtleCryptoEnabled]): Deleted.
3959         (-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
3960         * WebView/WebPreferencesPrivate.h:
3961         * WebView/WebView.mm:
3962         (-[WebView _preferencesChanged:]):
3963
3964 2017-06-10  Dan Bernstein  <mitz@apple.com>
3965
3966         Reverted r218056 because it made the IDE reindex constantly.
3967
3968         * Configurations/DebugRelease.xcconfig:
3969
3970 2017-06-10  Dan Bernstein  <mitz@apple.com>
3971
3972         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
3973         https://bugs.webkit.org/show_bug.cgi?id=173223
3974
3975         Reviewed by Sam Weinig.
3976
3977         The rebuilds were happening due to a difference in the compiler options that the IDE and
3978         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
3979         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
3980         specify an appropriate path in CLANG_INDEX_STORE_PATH.
3981
3982         * Configurations/DebugRelease.xcconfig:
3983
3984 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3985
3986         [iOS DnD] Add a hook to perform two-step drops in editable content
3987         https://bugs.webkit.org/show_bug.cgi?id=172992
3988         <rdar://problem/32590174>
3989
3990         Reviewed by Tim Horton.
3991
3992         Adds a new SPI to WebUIKitDelegate to allow WK1 clients to override default drop behavior. Returning YES from
3993         -performTwoStepDrop:atDestination:isMove: will prevent content from being inserted on drop in WebKit; otherwise,
3994         returning NO will continue with default WebKit behavior.
3995
3996         * WebCoreSupport/WebEditorClient.h:
3997         * WebCoreSupport/WebEditorClient.mm:
3998         (WebEditorClient::performTwoStepDrop):
3999
4000 2017-06-08  Jer Noble  <jer.noble@apple.com>
4001
4002         Clients of the WK2 C-API don't have their mediaContentTypesRequiringHardwareSupport setting initialized correctly.
4003         https://bugs.webkit.org/show_bug.cgi?id=173091
4004
4005         Reviewed by Eric Carlson.
4006
4007         * WebView/WebPreferences.mm:
4008         (+[WebPreferences initialize]):
4009
4010 2017-06-07  Jer Noble  <jer.noble@apple.com>
4011
4012         Clean-up: RenderElement.h includes headers it doesn't use
4013         https://bugs.webkit.org/show_bug.cgi?id=173046
4014
4015         Reviewed by Andy Estes.
4016
4017         * WebView/WebImmediateActionController.mm:
4018
4019 2017-06-07  Zalan Bujtas  <zalan@apple.com>
4020
4021         [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
4022         https://bugs.webkit.org/show_bug.cgi?id=173044
4023         <rdar://problem/32449338>
4024
4025         Reviewed by Tim Horton.
4026
4027         Cache the current device orientation so that we don't have to lift the WebThread lock
4028         to collect it.
4029
4030         * WebView/WebFrame.mm:
4031         (-[WebFrame deviceOrientationChanged]):
4032         * WebView/WebView.mm:
4033         (-[WebView _commonInitializationWithFrameName:groupName:]):
4034         (-[WebView _setDeviceOrientation:]):
4035         (-[WebView _deviceOrientation]):
4036         * WebView/WebViewData.h:
4037         * WebView/WebViewInternal.h:
4038
4039 2017-06-06  Jer Noble  <jer.noble@apple.com>
4040
4041         [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
4042         https://bugs.webkit.org/show_bug.cgi?id=173008
4043
4044         Reviewed by Eric Carlson.
4045
4046         Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
4047
4048         * WebView/WebPreferenceKeysPrivate.h:
4049         * WebView/WebPreferences.mm:
4050         (+[WebPreferences initialize]):
4051         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
4052         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
4053         * WebView/WebPreferencesPrivate.h:
4054         * WebView/WebView.mm:
4055         (-[WebView _preferencesChanged:]):
4056
4057 2017-06-06  Youenn Fablet  <youenn@apple.com>
4058
4059         Add an option to disable getUserMedia prompt in case of mock capture sources
4060         https://bugs.webkit.org/show_bug.cgi?id=172981
4061         <rdar://problem/32580325>
4062
4063         Reviewed by Eric Carlson.
4064
4065         Defining the option, getter and setter.
4066
4067         * WebView/WebPreferences.mm:
4068         (+[WebPreferences initialize]):
4069         (-[WebPreferences mockCaptureDevicesPromptEnabled]):
4070         (-[WebPreferences setMockCaptureDevicesPromptEnabled:]):
4071         * WebView/WebPreferencesPrivate.h:
4072
4073 2017-06-05  Dan Bernstein  <mitz@apple.com>
4074
4075         Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.
4076
4077         * WebView/WebView.mm:
4078         (-[WebView updateMediaTouchBar]):
4079         * WebView/WebViewData.h:
4080
4081 2017-06-03  Darin Adler  <darin@apple.com>
4082
4083         Streamline handling of attributes, using references as much as possible