Event improvements
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-01-13  Darin Adler  <darin@apple.com>
2
3         Event improvements
4         https://bugs.webkit.org/show_bug.cgi?id=179591
5
6         Reviewed by Chris Dumez.
7
8         * DOM/DOMWheelEvent.mm:
9         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
10         Call initWebKitWheelEvent.
11
12         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
13         * WebCoreSupport/WebInspectorClient.mm: Ditto.
14         * WebView/WebFrame.mm: Ditto.
15
16         * WebView/WebHTMLView.mm:
17         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
18         underlyingPlatformEvent.
19         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
20
21         * WebView/WebScriptWorld.mm:
22         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
23
24         * WebView/WebView.mm: Removed include of ScriptValue.h.
25
26 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
27
28         Remove WebCore/ForwardingHeaders directory
29         https://bugs.webkit.org/show_bug.cgi?id=182347
30
31         Reviewed by Keith Miller.
32
33         * Carbon/CarbonWindowAdapter.mm:
34         * DOM/WebDOMOperations.mm:
35         * History/WebBackForwardList.mm:
36         * History/WebHistoryItem.mm:
37         * Misc/WebCache.mm:
38         * Misc/WebElementDictionary.mm:
39         * Misc/WebIconDatabase.mm:
40         * Misc/WebStringTruncator.mm:
41         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
42         * Plugins/Hosted/ProxyInstance.mm:
43         * Plugins/Hosted/ProxyRuntimeObject.mm:
44         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
45         * Plugins/WebBaseNetscapePluginView.mm:
46         * Plugins/WebBasePluginPackage.mm:
47         * Plugins/WebNetscapePluginStream.mm:
48         * Plugins/WebNetscapePluginView.mm:
49         * Plugins/WebPluginController.mm:
50         * WebCoreSupport/WebEditorClient.mm:
51         * WebCoreSupport/WebFrameLoaderClient.mm:
52         * WebCoreSupport/WebInspectorClient.h:
53         * WebCoreSupport/WebInspectorClient.mm:
54         * WebView/WebDataSource.mm:
55         * WebView/WebFrame.mm:
56         * WebView/WebHTMLRepresentation.mm:
57         * WebView/WebHTMLView.mm:
58         * WebView/WebPreferences.mm:
59         * WebView/WebScriptDebugDelegate.mm:
60         * WebView/WebScriptDebugger.h:
61         * WebView/WebTextIterator.mm:
62         * WebView/WebView.mm:
63         * WebView/WebViewData.mm:
64
65 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
66
67         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
68         https://bugs.webkit.org/show_bug.cgi?id=182312
69
70         Reviewed by Michael Catanzaro.
71
72         * WebKitPrefix.h:
73
74 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
75
76         [WebAuthN] Add a compile-time feature flag
77         https://bugs.webkit.org/show_bug.cgi?id=182211
78         <rdar://problem/36936365>
79
80         Reviewed by Brent Fulgham.
81
82         * Configurations/FeatureDefines.xcconfig:
83
84 2018-01-27  Dan Bernstein  <mitz@apple.com>
85
86         HaveInternalSDK includes should be "#include?"
87         https://bugs.webkit.org/show_bug.cgi?id=179670
88
89         * Configurations/Base.xcconfig:
90
91 2018-01-24  Alex Christensen  <achristensen@webkit.org>
92
93         Remove unused QTKit preference
94         https://bugs.webkit.org/show_bug.cgi?id=181968
95
96         Reviewed by Alexey Proskuryakov.
97
98         * WebView/WebPreferenceKeysPrivate.h:
99         * WebView/WebPreferences.mm:
100         (+[WebPreferences initialize]):
101         (-[WebPreferences setQTKitEnabled:]): Deleted.
102         (-[WebPreferences isQTKitEnabled]): Deleted.
103         * WebView/WebPreferencesPrivate.h:
104         * WebView/WebView.mm:
105         (-[WebView _preferencesChanged:]):
106
107 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
108
109         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
110         https://bugs.webkit.org/show_bug.cgi?id=182037
111         <rdar://problem/36747812>
112
113         Reviewed by Ryosuke Niwa.
114
115         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
116         for more details.
117
118         * WebView/WebHTMLRepresentation.mm:
119         (-[WebHTMLRepresentation elementWithName:inForm:]):
120         (-[WebHTMLRepresentation controlsInForm:]):
121
122 2018-01-23  Alex Christensen  <achristensen@webkit.org>
123
124         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
125         https://bugs.webkit.org/show_bug.cgi?id=181961
126
127         Reviewed by Michael Catanzaro.
128
129         * WebView/WebPreferences.mm:
130
131 2018-01-23  Commit Queue  <commit-queue@webkit.org>
132
133         Unreviewed, rolling out r227437.
134         https://bugs.webkit.org/show_bug.cgi?id=182011
135
136         broke build (Requested by alexchristensen on #webkit).
137
138         Reverted changeset:
139
140         "Remove unused QTKit preference"
141         https://bugs.webkit.org/show_bug.cgi?id=181968
142         https://trac.webkit.org/changeset/227437
143
144 2018-01-23  Alex Christensen  <achristensen@webkit.org>
145
146         Remove unused QTKit preference
147         https://bugs.webkit.org/show_bug.cgi?id=181968
148
149         Reviewed by Alexey Proskuryakov.
150
151         * WebView/WebPreferenceKeysPrivate.h:
152         * WebView/WebPreferences.mm:
153         (+[WebPreferences initialize]):
154         (-[WebPreferences setQTKitEnabled:]): Deleted.
155         (-[WebPreferences isQTKitEnabled]): Deleted.
156         * WebView/WebPreferencesPrivate.h:
157         * WebView/WebView.mm:
158         (-[WebView _preferencesChanged:]):
159
160 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
161
162         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
163         https://bugs.webkit.org/show_bug.cgi?id=181960
164         <rdar://problem/36431678>
165
166         Reviewed by Tim Horton.
167
168         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
169         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
170         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
171
172         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
173         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
174         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
175
176         * WebView/WebView.mm:
177         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
178
179 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
180
181         Turning off custom pasteboard data doesn't actually turn it off in WK2
182         https://bugs.webkit.org/show_bug.cgi?id=181920
183         <rdar://problem/36686429>
184
185         Reviewed by Wenson Hsieh.
186
187         Always disable custom pasteboard data in WebKit1. See r226156 for details.
188
189         * WebView/WebPreferences.mm:
190         (+[WebPreferences initialize]):
191         * WebView/WebView.mm:
192         (-[WebView _preferencesChanged:]):
193
194 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
195
196         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
197         https://bugs.webkit.org/show_bug.cgi?id=181918
198
199         Reviewed by Tim Horton.
200
201         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
202
203         * Configurations/FeatureDefines.xcconfig:
204
205 2018-01-20  Andy Estes  <aestes@apple.com>
206
207         [Apple Pay] Stop eagerly loading PassKit.framework
208         https://bugs.webkit.org/show_bug.cgi?id=181911
209         <rdar://problem/36555369>
210
211         Reviewed by Tim Horton.
212
213         * WebCoreSupport/WebPaymentCoordinatorClient.h:
214         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
215         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
216
217         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
218
219 2018-01-19  Dean Jackson  <dino@apple.com>
220
221         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
222         https://bugs.webkit.org/show_bug.cgi?id=181817
223         <rdar://problem/35274055>
224
225         Reviewed by Simon Fraser.
226
227         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
228
229         * Misc/WebKitVersionChecks.h:
230         * WebView/WebView.mm:
231         (-[WebView _commonInitializationWithFrameName:groupName:]):
232
233 2018-01-19  Alex Christensen  <achristensen@webkit.org>
234
235         Remove unused WebViewPrivate _allowCookies
236         https://bugs.webkit.org/show_bug.cgi?id=181812
237
238         Reviewed by Tim Horton.
239
240         * WebView/WebView.mm:
241         (+[WebView _setAllowCookies:]): Deleted.
242         (+[WebView _allowCookies]): Deleted.
243         * WebView/WebViewPrivate.h:
244
245 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
246
247         Build fix, remove a call to -[NSWindow setOneShot:]
248         https://bugs.webkit.org/show_bug.cgi?id=181809
249
250         Reviewed by Tim Horton.
251
252         * WebView/WebTextCompletionController.mm:
253         (-[WebTextCompletionController _buildUI]):
254
255 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
256
257         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
258
259         * Carbon/HIWebView.mm:
260         (overrideCGContext):
261         (restoreCGContext):
262
263 2018-01-18  Dan Bernstein  <mitz@apple.com>
264
265         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
266         https://bugs.webkit.org/show_bug.cgi?id=181803
267
268         Reviewed by Tim Horton.
269
270         * Configurations/Base.xcconfig: Updated.
271         * Configurations/DebugRelease.xcconfig: Ditto.
272         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
273         * Configurations/Version.xcconfig: Updated.
274         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
275           useful for defining settings that depend on the target macOS version.
276
277 2018-01-17  Youenn Fablet  <youenn@apple.com>
278
279         Put fetch Request.keepalive behind a runtime flag
280         https://bugs.webkit.org/show_bug.cgi?id=181592
281
282         Reviewed by Chris Dumez.
283
284         * WebView/WebPreferenceKeysPrivate.h:
285         * WebView/WebPreferences.mm:
286         (+[WebPreferences initialize]):
287         (-[WebPreferences fetchAPIKeepAliveEnabled]):
288         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
289         * WebView/WebPreferencesPrivate.h:
290         * WebView/WebView.mm:
291         (-[WebView _preferencesChanged:]):
292
293 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
294
295         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
296         https://bugs.webkit.org/show_bug.cgi?id=181637
297         <rdar://problem/36508471>
298
299         Reviewed by Tim Horton.
300
301         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
302
303         * WebCoreSupport/WebEditorClient.h:
304         * WebCoreSupport/WebEditorClient.mm:
305         (WebEditorClient::replacementURLForResource):
306
307 2018-01-11  Keith Miller  <keith_miller@apple.com>
308
309         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
310         https://bugs.webkit.org/show_bug.cgi?id=181573
311
312         Reviewed by Simon Fraser.
313
314         * Configurations/FeatureDefines.xcconfig:
315
316 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
317
318         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
319         https://bugs.webkit.org/show_bug.cgi?id=181497
320
321         Reviewed by Tim Horton.
322
323         See other ChangeLogs for more detail.
324
325         * WebCoreSupport/WebDragClient.h:
326
327 2018-01-11  Tim Horton  <timothy_horton@apple.com>
328
329         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
330         https://bugs.webkit.org/show_bug.cgi?id=181523
331         <rdar://problem/28959131>
332
333         Reviewed by Alex Christensen.
334
335         * WebView/WebImmediateActionController.mm:
336         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
337         Apply the change made in r216652 to WebKit1's immediate action controller.
338
339         Speculative (but successful in WebKit2) fix for non-reproducible crash when
340         the startContainer of the range is in an anonymous node.
341
342 2018-01-11  Youenn Fablet  <youenn@apple.com>
343
344         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
345         https://bugs.webkit.org/show_bug.cgi?id=181480
346
347         Reviewed by Eric Carlson.
348
349         * WebView/WebPreferences.mm:
350         (+[WebPreferences initialize]):
351
352 2018-01-08  David Kilzer  <ddkilzer@apple.com>
353
354         Fix check-webkit-style issues with WebNSDataExtras.mm
355         <https://webkit.org/b/181369>
356
357         Reviewed by Alex Christensen.
358
359         * Misc/WebNSDataExtras.mm:
360         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
361         (-[NSData _webkit_guessedMIMETypeForXML]):
362         (-[NSData _webkit_guessedMIMEType]):
363         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
364         (_findEOL):
365         (-[NSData _webkit_parseRFC822HeaderFields]):
366         (-[NSData _web_locationAfterFirstBlankLine]):
367         - Fix all the check-webkit-style warnings.
368
369 2018-01-08  David Kilzer  <ddkilzer@apple.com>
370
371         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
372         <https://webkit.org/b/181256>
373         <rdar://problem/36281730>
374
375         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
376         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
377         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
378           to avoid warnings from casting CFStringRef to NPNSString*.
379           Note that CFMutableStringRef is the same as CFStringRef
380           without the const modifier, hence its use in the const_cast<>
381           above.
382
383 2018-01-08  David Kilzer  <ddkilzer@apple.com>
384
385         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
386         <https://webkit.org/b/181256>
387         <rdar://problem/36281730>
388
389         * Carbon/HIWebView.mm:
390         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
391         checked_cf_cast<CFRunLoopRef>() to fix warning.
392
393 2018-01-07  David Kilzer  <ddkilzer@apple.com>
394
395         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
396         <https://webkit.org/b/181256>
397         <rdar://problem/36281730>
398
399         Reviewed by Darin Adler.
400
401         * Carbon/CarbonUtils.m:
402         (PoolCleaner):
403         - Use #pragmas to ignore -Wcast-qual warnings when using a
404           C-style cast from CFTypeRef to CFRunloopRef.
405         * Carbon/CarbonWindowFrame.m:
406         (-[CarbonWindowFrame title]):
407         - Use #pragmas to ignore -Wcast-qual warnings when using a
408           C-style cast from CFStringRef to NSString *.
409         * Carbon/HIViewAdapter.m:
410         (+[HIViewAdapter getHIViewForNSView:]):
411         - Use #pragmas to ignore -Wcast-qual warnings when using a
412           C-style cast from CFTypeRef to HIViewRef.
413         * Configurations/Base.xcconfig:
414         (WARNING_CFLAGS): Add -Wcast-qual.
415         * Misc/WebElementDictionary.mm:
416         (-[WebElementDictionary objectForKey:]):
417         - Use static_cast<SEL>(const_cast<void*>()) to fix
418           warning.
419         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
420         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
421         (-[NSData _webkit_guessedMIMETypeForXML]):
422         (-[NSData _webkit_guessedMIMEType]):
423         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
424         (_findEOL):
425         (-[NSData _webkit_parseRFC822HeaderFields]):
426         (-[NSData _web_startsWithBlankLine]):
427         (-[NSData _web_locationAfterFirstBlankLine]):
428         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
429           type to Objective-C++.  This fixes the warnings about
430           discarding the `const` modifier when casing from CFStringRef
431           to NSString * because in older clang versions, -Wcast-qual was
432           completely broken when compiling C++ and Objective-C++ source
433           files.  In newer clang versions, discarding the `const`
434           modifier for toll-free bridged types is ignored when compiling
435           Objective-C++ source.
436         - Update copyright and license header.
437         - Use reinterpret_cast<> and static_cast<> to fix warnings
438           unrelated to (NSString *) C-style casts.
439         - Replace use of MIN() macro with std::min<> template functions.
440         - Fix location of `*` for local variables modified above.
441         * Plugins/Hosted/NetscapePluginHostManager.mm:
442         (WebKit::NetscapePluginHostManager::spawnPluginHost):
443         (WebKit::NetscapePluginHostManager::initializeVendorPort):
444         (WebKit::NetscapePluginHostManager::instantiatePlugin):
445         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
446           warnings.
447         * Plugins/Hosted/NetscapePluginHostProxy.mm:
448         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
449         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
450           to fix warning.
451         * Plugins/Hosted/ProxyInstance.mm:
452         (WebKit::ProxyInstance::invoke):
453         - Use static_cast<char*>(const_cast<void*>()) to fix
454           warning when using -[NSData bytes].
455         (WebKit::ProxyInstance::fieldValue const):
456         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
457           to fix warning when using CFDataGetBytePtr().
458         * Plugins/Hosted/WebTextInputWindowController.m:
459         (-[WebTextInputPanel _interpretKeyEvent:string:]):
460         - Use #pragma to ignore -Wcast-qual warning since there
461           is not a good way to avoid this warning in Objective-C.
462         * Plugins/WebNetscapePluginStream.mm:
463         (WebNetscapePluginStream::deliverData):
464         - Use const_cast<void*>() to fix warning when using
465           -[NSData bytes].
466         * Plugins/WebNetscapePluginView.mm:
467         (-[WebNetscapePluginView _createPlugin]):
468         - Change C-style cast to const_cast<char*>() to fix
469           warning.
470         * WebCoreSupport/WebChromeClient.mm:
471         (WebChromeClient::wrapCryptoKey const):
472         (WebChromeClient::unwrapCryptoKey const):
473         - Change C-style cast to
474           static_cast<uint8_t*>(const_cast<void*>() to fix
475           warning.
476         * WebView/WebPDFView.mm:
477         (_applicationInfoForMIMEType):
478         - Change local variable type from 'NSURL *' to
479           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
480           when calling -[NSURL path].
481
482 2018-01-05  Dan Bernstein  <mitz@apple.com>
483
484         Fixed the build following AppKit API deprecations in a recent SDKs
485
486         * WebView/WebFullScreenController.mm:
487         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
488         (-[WebFullScreenController exitFullScreen]): Ditto.
489         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
490         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
491         * WebView/WebHTMLView.mm:
492         (-[WebHTMLView drawRect:]): Ditto.
493         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
494         (-[WebHTMLView knowsPageRange:]): Ditto.
495         * WebView/WebView.mm:
496         (LayerFlushController::flushLayers): Ditto.
497
498 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
499
500         [Attachment Support] Create attachment elements when dropping files on iOS
501         https://bugs.webkit.org/show_bug.cgi?id=181192
502         <rdar://problem/36280945>
503
504         Reviewed by Tim Horton.
505
506         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
507
508         * WebCoreSupport/WebPlatformStrategies.h:
509         * WebCoreSupport/WebPlatformStrategies.mm:
510         (WebPlatformStrategies::informationForItemAtIndex):
511         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
512
513 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
514
515         [Attachment Support] Add plumbing for starting a drag with promised blob data
516         https://bugs.webkit.org/show_bug.cgi?id=181201
517
518         Reviewed by Tim Horton.
519
520         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
521
522         * WebCoreSupport/WebDragClient.h:
523
524 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
525
526         Add a WebAuthentication runtime feature flag
527         https://bugs.webkit.org/show_bug.cgi?id=181220
528         <rdar://problem/36055305>
529
530         Reviewed by Brent Fulgham.
531
532         Renames the CredentialManagement runtime feature flag into WebAuthentication.
533
534         * WebView/WebPreferenceKeysPrivate.h:
535         * WebView/WebPreferences.mm:
536         (+[WebPreferences initialize]):
537         (-[WebPreferences webAuthenticationEnabled]):
538         (-[WebPreferences setWebAuthenticationEnabled:]):
539         (-[WebPreferences credentialManagementEnabled]): Deleted.
540         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
541         * WebView/WebPreferencesPrivate.h:
542         * WebView/WebView.mm:
543         (-[WebView _preferencesChanged:]):
544
545 2017-12-22  Jeff Miller  <jeffm@apple.com>
546
547         Update user-visible copyright strings to include 2018
548         https://bugs.webkit.org/show_bug.cgi?id=181141
549
550         Reviewed by Dan Bernstein.
551
552         * Info.plist:
553
554 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
555
556         [Attachment Support] Remove current macOS support for dragging file-backed attachments
557         https://bugs.webkit.org/show_bug.cgi?id=181188
558
559         Reviewed by Dan Bernstein.
560
561         See WebCore/ChangeLog for more detail.
562
563         * WebCoreSupport/WebDragClient.h:
564         * WebCoreSupport/WebDragClient.mm:
565         (WebDragClient::declareAndWriteAttachment): Deleted.
566         * WebView/WebHTMLView.mm:
567         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
568
569 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
570
571         Unreviewed, continue to fix build failures due to AppKit API deprecation
572
573         Wraps more code in -Wdeprecated-declarations.
574
575         * Carbon/HIWebView.mm:
576         (overrideCGContext):
577
578 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
579
580         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
581
582         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
583
584         * Carbon/CarbonWindowAdapter.mm:
585         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
586         * Plugins/WebNetscapePluginView.mm:
587         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
588         (-[WebNetscapePluginView sendDrawRectEvent:]):
589         (-[WebNetscapePluginView drawRect:]):
590
591 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
592
593         Fix build failures due to using deprecated AppKit symbols
594         https://bugs.webkit.org/show_bug.cgi?id=181110
595         <rdar://problem/36162865>
596
597         Reviewed by Dan Bernstein and Tim Horton.
598
599         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
600
601         * Misc/WebKitNSStringExtras.mm:
602         (-[NSString _web_drawAtPoint:font:textColor:]):
603         * Misc/WebNSPasteboardExtras.h:
604         * Misc/WebNSPasteboardExtras.mm:
605         (+[NSPasteboard _web_writableTypesForURL]):
606         (_createWritableTypesForImageWithoutArchive):
607         (_createWritableTypesForImageWithArchive):
608         (+[NSPasteboard _web_dragTypesForURL]):
609         (-[NSPasteboard _web_bestURL]):
610         (-[NSPasteboard _web_writeURL:andTitle:types:]):
611         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
612         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
613         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
614         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
615         * Panels/WebAuthenticationPanel.m:
616         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
617         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
618         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
619         (-[WebHostedNetscapePluginView drawRect:]):
620         * WebInspector/WebNodeHighlightView.mm:
621         (-[WebNodeHighlightView drawRect:]):
622         * WebView/WebFrame.mm:
623         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
624         (-[WebFrame _drawRect:contentsOnly:]):
625         * WebView/WebHTMLView.mm:
626         (kit):
627         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
628         (-[WebHTMLView _plainTextFromPasteboard:]):
629         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
630         (+[WebHTMLView _insertablePasteboardTypes]):
631         (+[WebHTMLView _selectionPasteboardTypes]):
632         (-[WebHTMLView pasteboard:provideDataForType:]):
633         (-[WebHTMLView _writeSelectionToPasteboard:]):
634         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
635         (-[WebHTMLView validRequestorForSendType:returnType:]):
636         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
637         (createMenuItem):
638         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
639         (-[WebHTMLView _colorAsString:]):
640         (-[WebHTMLView copyFont:]):
641         * WebView/WebPDFView.mm:
642         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
643         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
644         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
645         (-[WebPDFView pasteboardTypesForSelection]):
646         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
647         * WebView/WebView.h:
648         * WebView/WebView.mm:
649         (-[WebView performDragOperation:]):
650         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
651         (-[WebView _searchWithGoogleFromMenu:]):
652
653 2017-12-21  Youenn Fablet  <youenn@apple.com>
654
655         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
656         https://bugs.webkit.org/show_bug.cgi?id=181000
657
658         Reviewed by Chris Dumez.
659
660         * Misc/WebCache.mm:
661         (+[WebCache addImageToCache:forURL:forFrame:]):
662
663 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
664
665         Update FULLSCREEN_API feature defines.
666         https://bugs.webkit.org/show_bug.cgi?id=181015
667
668         Reviewed by Tim Horton.
669
670         Change enabled iphone sdk for FULLSCREEN_API.
671
672         * Configurations/FeatureDefines.xcconfig:
673
674 2017-12-21  Jer Noble  <jer.noble@apple.com>
675
676         Add initial DOM support for Media Capabilities
677         https://bugs.webkit.org/show_bug.cgi?id=181064
678
679         Reviewed by Eric Carlson.
680
681         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
682
683         * WebView/WebPreferenceKeysPrivate.h:
684         * WebView/WebPreferences.mm:
685         (+[WebPreferences initialize]):
686         (-[WebPreferences mediaCapabilitiesEnabled]):
687         (-[WebPreferences setMediaCapabilitiesEnabled:]):
688         * WebView/WebPreferencesPrivate.h:
689         * WebView/WebView.mm:
690         (-[WebView _preferencesChanged:]):
691
692 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
693
694         Enable picture-in-picture from inline element on suspend.
695         https://bugs.webkit.org/show_bug.cgi?id=180942
696         rdar://problem/34745234
697
698         Reviewed by Jer Noble.
699
700         Update signature of enterVideoFullscreenForVideoElement().
701
702         * WebCoreSupport/WebChromeClient.h:
703         * WebCoreSupport/WebChromeClient.mm:
704         (WebChromeClient::enterVideoFullscreenForVideoElement):
705
706 2017-12-20  Daniel Bates  <dabates@apple.com>
707
708         Remove Alternative Presentation Button
709         https://bugs.webkit.org/show_bug.cgi?id=180500
710         <rdar://problem/35891047>
711
712         Reviewed by Simon Fraser.
713
714         We no longer need the alternative presentation button.
715
716         * Configurations/FeatureDefines.xcconfig:
717
718 2017-12-19  Jer Noble  <jer.noble@apple.com>
719
720         Playing media elements which call "pause(); play()" will have the play promise rejected.
721         https://bugs.webkit.org/show_bug.cgi?id=180781
722         <rdar://problem/33191377>
723
724         Reviewed by Eric Carlson.
725
726         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
727
728         * WebView/WebView.mm:
729         (shouldRequireUserGestureToLoadVideo):
730
731 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
732
733         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
734         https://bugs.webkit.org/show_bug.cgi?id=180977
735
736         Reviewed by Tim Horton.
737
738         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
739         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
740         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
741
742         * WebCoreSupport/WebEditorClient.mm:
743         (attributesForAttributedStringConversion):
744         * WebView/WebHTMLView.mm:
745         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
746
747 2017-12-18  David Kilzer  <ddkilzer@apple.com>
748
749         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
750
751         Attempt to fix the following warnings:
752
753             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
754
755         For the following instance variables:
756
757             _borderView
758             _contentView
759             _frame
760             _wFlags
761
762         * Carbon/CarbonWindowAdapter.mm:
763         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
764         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
765         (-[CarbonWindowAdapter _termWindowIfOwner]):
766         (-[CarbonWindowAdapter _windowMovedToRect:]):
767         (-[CarbonWindowAdapter setContentView:]):
768         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
769         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
770
771 2017-12-16  Dan Bernstein  <mitz@apple.com>
772
773         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
774         https://bugs.webkit.org/show_bug.cgi?id=180613
775         <rdar://problem/35946124>
776
777         Reviewed by Geoff Garen.
778
779         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
780           clients.
781         * WebView/WebDynamicScrollBarsView.h: Ditto.
782         * WebView/WebDynamicScrollBarsView.mm: Ditto.
783
784 2017-12-14  David Kilzer  <ddkilzer@apple.com>
785
786         Enable -Wstrict-prototypes for WebKit
787         <https://webkit.org/b/180757>
788         <rdar://problem/36024132>
789
790         Rubber-stamped by Joseph Pecoraro.
791
792         * Configurations/Base.xcconfig:
793         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
794
795 2017-12-14  John Wilander  <wilander@apple.com>
796
797         Storage Access API: Implement frame-specific access in the document.cookie layer
798         https://bugs.webkit.org/show_bug.cgi?id=180682
799         <rdar://problem/35982257>
800
801         Reviewed by Alex Christensen.
802
803         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
804         CookiesStrategy::cookieRequestHeaderFieldValue(), and
805         CookiesStrategy::getRawCookies() now take optional parameters for
806         frameID and pageID to allow frame-specific scoping of cookies.
807
808         This change makes the return values of FrameLoaderClient::frameID()
809         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
810         WebCore can call those getters and get the right return values in
811         WebKit and std:nullopt in WebKitLegacy.
812
813         * WebCoreSupport/WebFrameLoaderClient.h:
814         * WebCoreSupport/WebFrameLoaderClient.mm:
815         (WebFrameLoaderClient::pageID const):
816         (WebFrameLoaderClient::frameID const):
817         * WebCoreSupport/WebPlatformStrategies.h:
818         * WebCoreSupport/WebPlatformStrategies.mm:
819         (WebPlatformStrategies::cookiesForDOM):
820         (WebPlatformStrategies::setCookiesFromDOM):
821         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
822         (WebPlatformStrategies::getRawCookies):
823
824 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
825
826         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
827         https://bugs.webkit.org/show_bug.cgi?id=180689
828
829         Reviewed by Tim Horton.
830
831         Use sRGBColorSpaceRef() from WebCore.
832
833         * WebView/WebHTMLView.mm:
834         (imageFromRect):
835
836 2017-12-11  Tim Horton  <timothy_horton@apple.com>
837
838         Stop using deprecated target conditional for simulator builds
839         https://bugs.webkit.org/show_bug.cgi?id=180662
840         <rdar://problem/35136156>
841
842         Reviewed by Simon Fraser.
843
844         * postprocess-headers.sh:
845
846 2017-12-11  David Quesada  <david_quesada@apple.com>
847
848         Turn on ENABLE_APPLICATION_MANIFEST
849         https://bugs.webkit.org/show_bug.cgi?id=180562
850         rdar://problem/35924737
851
852         Reviewed by Geoffrey Garen.
853
854         * Configurations/FeatureDefines.xcconfig:
855
856 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
857
858         Remove pthread_once in favor of dispatch_once
859         https://bugs.webkit.org/show_bug.cgi?id=180591
860
861         Reviewed by Saam Barati.
862
863         * Misc/WebKitErrors.m:
864         (+[NSError _registerWebKitErrors]):
865         (registerErrors): Deleted.
866         * Storage/WebStorageManager.mm:
867         (+[WebStorageManager _storageDirectoryPath]):
868         (initializeLocalStoragePath): Deleted.
869
870 2017-12-07  Darin Adler  <darin@apple.com>
871
872         Remove some unused code from WebKitLegacy
873         https://bugs.webkit.org/show_bug.cgi?id=180567
874
875         Reviewed by Anders Carlsson.
876
877         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
878         macOS (back a few versions) and iOS and removed unused
879         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
880         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
881         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
882         _webkit_stringByCollapsingNonPrintingCharacters,
883         _webkit_stringByCollapsingWhitespaceCharacters,
884         _web_stringWithData:textEncodingName:, and
885         _webkit_localStorageDirectoryWithBundleIdentifier:.
886
887         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
888         this source file.
889         (canUseFastRenderer): Made this faster by not calling u_charDirection for
890         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
891         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
892         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
893         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
894         handle font smoothing options.
895         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
896         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
897         from header and made it a little clearer.
898         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
899         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
900         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
901         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
902         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
903         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
904         implementation a bit and used whole words instead of abbreviations.
905         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
906
907         * Misc/WebNSFileManagerExtras.mm:
908         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
909         filenameByFixingIllegalCharacters function from WebCore directly instead of
910         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
911
912         * Plugins/WebBaseNetscapePluginView.mm:
913         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
914         string replacements instead of _web_stringByStrippingReturnCharacters
915         and to use NSString methods instead of CFString functions.
916
917 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
918
919         Ignore deprecation warnings.
920
921         * WebView/WebHTMLView.mm:
922         (-[NSWindow _web_borderView]):
923         (-[WebHTMLView _setAsideSubviews]):
924         * WebView/WebView.mm:
925         (-[WebView encodeWithCoder:]):
926
927 2017-12-02  Darin Adler  <darin@apple.com>
928
929         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
930         https://bugs.webkit.org/show_bug.cgi?id=180009
931
932         Reviewed by Alex Christensen.
933
934         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
935
936         * Plugins/WebBaseNetscapePluginView.mm:
937         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
938         of strcasecmp.
939
940         * WebView/WebPreferences.mm:
941         (contains): Ditto. Also made this a template so it's easier to call on an array.
942         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
943
944 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
945
946         Limit user agent versioning to an upper bound
947         https://bugs.webkit.org/show_bug.cgi?id=180365
948         <rdar://problem/34550617>
949
950         Reviewed by Joseph Pecoraro.
951
952         * WebView/WebView.mm:
953         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
954         creating the User Agent string.
955         (webKitBundleVersionString): Deleted.
956
957 2017-12-05  Andy Estes  <aestes@apple.com>
958
959         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
960         https://bugs.webkit.org/show_bug.cgi?id=180457
961         <rdar://problem/35143007>
962
963         Reviewed by Tim Horton.
964
965         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
966         check for this macro during post-processing.
967
968         * postprocess-headers.sh:
969
970 2017-12-04  David Quesada  <david_quesada@apple.com>
971
972         Add a class for parsing application manifests
973         https://bugs.webkit.org/show_bug.cgi?id=177973
974         rdar://problem/34747949
975
976         Reviewed by Geoffrey Garen.
977
978         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
979
980 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
981
982         Make LegacyCustomProtocolManager optional for network process
983         https://bugs.webkit.org/show_bug.cgi?id=176230
984
985         Reviewed by Alex Christensen.
986
987         * Configurations/FeatureDefines.xcconfig:
988
989 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
990
991         Fix some NSOperationQueue leaks
992         https://bugs.webkit.org/show_bug.cgi?id=180221
993
994         Reviewed by Wenson Hsieh.
995
996         * WebView/WebView.mm:
997         (-[WebView performDragOperation:]):
998
999 2017-11-30  Darin Adler  <darin@apple.com>
1000
1001         [Mac] remove unneeded RetainPtr use introduced in r225142
1002         https://bugs.webkit.org/show_bug.cgi?id=180202
1003
1004         Reviewed by Tim Horton.
1005
1006         * WebView/WebImmediateActionController.mm:
1007         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1008         RetainPtr.
1009
1010 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1011
1012         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1013         https://bugs.webkit.org/show_bug.cgi?id=175595
1014
1015         Reviewed by Darin Adler.
1016
1017         * WebView/WebPreferences.mm:
1018
1019 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1020
1021         One too many zeroes in macOS version number in FeatureDefines
1022         https://bugs.webkit.org/show_bug.cgi?id=180011
1023
1024         Reviewed by Dan Bernstein.
1025
1026         * Configurations/FeatureDefines.xcconfig:
1027
1028 2017-11-23  Darin Adler  <darin@apple.com>
1029
1030         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1031         https://bugs.webkit.org/show_bug.cgi?id=179981
1032
1033         Reviewed by Sam Weinig.
1034
1035         * WebView/WebImmediateActionController.mm:
1036         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1037         * WebView/WebView.mm:
1038         (coreOptions): Use |= instead of | to build up FindOptions.
1039
1040 2017-11-23  Sam Weinig  <sam@webkit.org>
1041
1042         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1043         https://bugs.webkit.org/show_bug.cgi?id=179954
1044
1045         Reviewed by Darin Adler.
1046
1047         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1048         with direct calls to the corresponding UserGestureIndicator functions.
1049
1050         * Plugins/WebPluginController.mm:
1051         (-[WebPluginController processingUserGesture]):
1052         * WebView/WebView.mm:
1053         (-[WebView _isProcessingUserGesture]):
1054
1055 2017-11-23  Darin Adler  <darin@apple.com>
1056
1057         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1058         https://bugs.webkit.org/show_bug.cgi?id=179907
1059
1060         Reviewed by Sam Weinig.
1061
1062         * History/BinaryPropertyList.cpp:
1063         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1064         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1065         * WebView/WebHTMLRepresentation.mm:
1066         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1067         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1068
1069 2017-11-22  Ali Juma  <ajuma@chromium.org>
1070
1071         Implement VisualViewport API attributes
1072         https://bugs.webkit.org/show_bug.cgi?id=179385
1073
1074         Reviewed by Frédéric Wang.
1075
1076         Add a VisualViewportAPI preference.
1077
1078         * WebView/WebPreferenceKeysPrivate.h:
1079         * WebView/WebPreferences.mm:
1080         (+[WebPreferences initialize]):
1081         (-[WebPreferences visualViewportAPIEnabled]):
1082         (-[WebPreferences setVisualViewportAPIEnabled:]):
1083         * WebView/WebPreferencesPrivate.h:
1084         * WebView/WebView.mm:
1085         (-[WebView _preferencesChanged:]):
1086
1087 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1088
1089         WebCoreObjCExtras.h is being included in too many places
1090         https://bugs.webkit.org/show_bug.cgi?id=179931
1091
1092         Reviewed by Darin Adler.
1093
1094         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1095         * Plugins/WebBaseNetscapePluginView.mm:
1096         * Plugins/WebBasePluginPackage.mm:
1097         * Plugins/WebNetscapePluginStream.mm:
1098         * Plugins/WebNetscapePluginView.mm:
1099         * WebView/WebTextIterator.mm:
1100         * WebView/WebViewData.mm:
1101
1102 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1103
1104         Unreviewed, rolling out r225093.
1105         https://bugs.webkit.org/show_bug.cgi?id=179938
1106
1107         Compilation failed on WinCairo 64-bit Release (Requested by
1108         fredw on #webkit).
1109
1110         Reverted changeset:
1111
1112         "Implement VisualViewport API attributes"
1113         https://bugs.webkit.org/show_bug.cgi?id=179385
1114         https://trac.webkit.org/changeset/225093
1115
1116 2017-11-21  Ali Juma  <ajuma@chromium.org>
1117
1118         Implement VisualViewport API attributes
1119         https://bugs.webkit.org/show_bug.cgi?id=179385
1120
1121         Reviewed by Frédéric Wang.
1122
1123         Add a VisualViewportAPI preference.
1124
1125         * WebView/WebPreferenceKeysPrivate.h:
1126         * WebView/WebPreferences.mm:
1127         (+[WebPreferences initialize]):
1128         (-[WebPreferences visualViewportAPIEnabled]):
1129         (-[WebPreferences setVisualViewportAPIEnabled:]):
1130         * WebView/WebPreferencesPrivate.h:
1131         * WebView/WebView.mm:
1132         (-[WebView _preferencesChanged:]):
1133
1134 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1135
1136         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1137         https://bugs.webkit.org/show_bug.cgi?id=179504
1138
1139         Reviewed by Darin Adler.
1140
1141         * Misc/WebKitNSStringExtras.mm:
1142         * Plugins/Hosted/NetscapePluginHostManager.mm:
1143         * Plugins/WebBasePluginPackage.mm:
1144
1145 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1146
1147         Remove unused TOUCH_ICON_LOADING feature flag
1148         https://bugs.webkit.org/show_bug.cgi?id=179873
1149
1150         Reviewed by Simon Fraser.
1151
1152         * Configurations/FeatureDefines.xcconfig:
1153
1154 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1155
1156         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1157         https://bugs.webkit.org/show_bug.cgi?id=179872
1158
1159         Reviewed by Darin Adler.
1160
1161         * Configurations/FeatureDefines.xcconfig:
1162
1163 2017-11-16  Daniel Bates  <dabates@apple.com>
1164
1165         Add feature define for alternative presentation button element
1166         https://bugs.webkit.org/show_bug.cgi?id=179692
1167         Part of <rdar://problem/34917108>
1168
1169         Reviewed by Andy Estes.
1170
1171         Only enabled on Cocoa platforms by default.
1172
1173         * Configurations/FeatureDefines.xcconfig:
1174
1175 2017-11-14  Nan Wang  <n_wang@apple.com>
1176
1177         AX: AOM: Implement AccessibleNode class and support label and role attributes
1178         https://bugs.webkit.org/show_bug.cgi?id=179494
1179
1180         Reviewed by Ryosuke Niwa.
1181
1182         * WebView/WebPreferenceKeysPrivate.h:
1183         * WebView/WebPreferences.mm:
1184         (+[WebPreferences initialize]):
1185         (-[WebPreferences accessibilityObjectModelEnabled]):
1186         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1187         * WebView/WebPreferencesPrivate.h:
1188         * WebView/WebView.mm:
1189         (-[WebView _preferencesChanged:]):
1190
1191 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1192
1193         Remove Cocoa CFURLConnection loading code
1194         https://bugs.webkit.org/show_bug.cgi?id=179688
1195
1196         Reviewed by Antti Koivisto.
1197
1198         * Misc/WebDownload.mm:
1199         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1200         * Misc/WebDownloadInternal.h:
1201         * Plugins/WebBaseNetscapePluginView.mm:
1202         * WebCoreSupport/WebFrameLoaderClient.mm:
1203         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1204         * WebView/WebView.mm:
1205         (-[WebView scheduleInRunLoop:forMode:]):
1206         (-[WebView unscheduleFromRunLoop:forMode:]):
1207
1208 2017-11-14  Daniel Bates  <dabates@apple.com>
1209
1210         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1211         for feature defines
1212
1213         Following r195498 and r201917 the Visual Studio property files for feature defines have
1214         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1215         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1216         files.
1217
1218         * Configurations/FeatureDefines.xcconfig:
1219
1220 2017-11-14  Jer Noble  <jer.noble@apple.com>
1221
1222         Enable Modern EME tests in DumpRenderTree
1223         https://bugs.webkit.org/show_bug.cgi?id=179544
1224
1225         Reviewed by Alex Christensen.
1226
1227         Add a WebPreferences property to enable the (modern) EME API.
1228
1229         * WebView/WebPreferenceKeysPrivate.h:
1230         * WebView/WebPreferences.mm:
1231         (+[WebPreferences initialize]):
1232         (-[WebPreferences encryptedMediaAPIEnabled]):
1233         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1234         * WebView/WebPreferencesPrivate.h:
1235         * WebView/WebView.mm:
1236         (-[WebView _preferencesChanged:]):
1237
1238 2017-11-14  Antti Koivisto  <antti@apple.com>
1239
1240         Enable display:contents by default
1241         https://bugs.webkit.org/show_bug.cgi?id=179655
1242
1243         Reviewed by Sam Weinig.
1244
1245         * WebView/WebPreferences.mm:
1246         (+[WebPreferences initialize]):
1247
1248 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1249
1250         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1251         https://bugs.webkit.org/show_bug.cgi?id=178751
1252
1253         Reviewed by Brady Eidson.
1254
1255         * WebCoreSupport/WebFrameNetworkingContext.mm:
1256         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1257
1258 2017-11-08  Keith Miller  <keith_miller@apple.com>
1259
1260         Async iteration should only fetch the next method once and add feature flag
1261         https://bugs.webkit.org/show_bug.cgi?id=179451
1262
1263         Reviewed by Geoffrey Garen.
1264
1265         Add feature flag for Async iteration.
1266
1267         * Configurations/FeatureDefines.xcconfig:
1268
1269 2017-11-13  Mark Lam  <mark.lam@apple.com>
1270
1271         Add more overflow check book-keeping for MarkedArgumentBuffer.
1272         https://bugs.webkit.org/show_bug.cgi?id=179634
1273         <rdar://problem/35492517>
1274
1275         Reviewed by Saam Barati.
1276
1277         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1278         (WebKit::NetscapePluginInstanceProxy::invoke):
1279         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1280         (WebKit::NetscapePluginInstanceProxy::construct):
1281
1282 2017-11-12  Darin Adler  <darin@apple.com>
1283
1284         More is<> and downcast<>, less static_cast<>
1285         https://bugs.webkit.org/show_bug.cgi?id=179600
1286
1287         Reviewed by Chris Dumez.
1288
1289         * DOM/DOM.mm:
1290         (kit): Use is/downcast.
1291         * WebCoreSupport/WebEditorClient.mm:
1292         (WebEditorClient::handleKeyboardEvent): Ditto.
1293         (WebEditorClient::handleInputMethodKeydown): Ditto.
1294         * WebView/WebHTMLView.mm:
1295         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1296
1297 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1298
1299         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1300         https://bugs.webkit.org/show_bug.cgi?id=179397
1301
1302         Reviewed by Wenson Hsieh.
1303
1304         * DOM/DOMHTMLInputElement.mm:
1305         (-[DOMHTMLInputElement insertTextSuggestion:]):
1306
1307 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1308
1309         HTMLMediaElement should not use element fullscreen on iOS
1310         https://bugs.webkit.org/show_bug.cgi?id=179418
1311         rdar://problem/35409277
1312
1313         Reviewed by Eric Carlson.
1314
1315         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1316
1317         * Configurations/FeatureDefines.xcconfig:
1318
1319 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1320
1321         Make ResourceLoader::willSendRequestInternal asynchronous
1322         https://bugs.webkit.org/show_bug.cgi?id=179251
1323
1324         Reviewed by Andy Estes.
1325
1326         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1327         (WebKit::HostedNetscapePluginStream::start):
1328         * Plugins/WebNetscapePluginStream.mm:
1329         (WebNetscapePluginStream::start):
1330
1331 2017-11-01  Darin Adler  <darin@apple.com>
1332
1333         Simplify event dispatch code and make it a bit more consistent
1334         https://bugs.webkit.org/show_bug.cgi?id=178991
1335
1336         Reviewed by Chris Dumez.
1337
1338         * DOM/DOMEvent.mm:
1339         (-[DOMEvent srcElement]): Call target instead of srcElement.
1340
1341 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1342
1343         [Touch Bar Web API] Add support for menuitem tag
1344         https://bugs.webkit.org/show_bug.cgi?id=179020
1345
1346         Reviewed by Ryosuke Niwa.
1347
1348         Adds in properties and methods that allow the menuitem runtime feature
1349         to be enabled or disabled.
1350
1351         * WebView/WebPreferenceKeysPrivate.h:
1352         * WebView/WebPreferences.mm:
1353         (-[WebPreferences menuItemElementEnabled]):
1354         (-[WebPreferences setMenuItemElementEnabled:]):
1355         * WebView/WebPreferencesPrivate.h:
1356         * WebView/WebView.mm:
1357         (-[WebView _preferencesChanged:]):
1358
1359 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1360
1361         Use CompletionHandlers for redirects
1362         https://bugs.webkit.org/show_bug.cgi?id=179163
1363
1364         Reviewed by Tim Horton.
1365
1366         * Plugins/Hosted/HostedNetscapePluginStream.h:
1367         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1368         (WebKit::HostedNetscapePluginStream::willSendRequest):
1369         * Plugins/WebNetscapePluginStream.h:
1370         * Plugins/WebNetscapePluginStream.mm:
1371         (WebNetscapePluginStream::willSendRequest):
1372
1373 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1374
1375         Add a FileSystem namespace to FileSystem.cpp
1376         https://bugs.webkit.org/show_bug.cgi?id=179063
1377
1378         Reviewed by Darin Adler.
1379
1380         * Misc/WebNSFileManagerExtras.mm:
1381         * Storage/WebDatabaseProvider.mm:
1382
1383 2017-11-02  Frederic Wang  <fwang@igalia.com>
1384
1385         Add references to bug 179167 in FIXME comments
1386         https://bugs.webkit.org/show_bug.cgi?id=179168
1387
1388         Reviewed by Daniel Bates.
1389
1390         * Configurations/FeatureDefines.xcconfig:
1391
1392 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1393
1394         Implement WKFullscreenWindowController for iOS.
1395         https://bugs.webkit.org/show_bug.cgi?id=178924
1396         rdar://problem/34697120
1397
1398         Reviewed by Simon Fraser.
1399
1400         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1401
1402         * Configurations/FeatureDefines.xcconfig:
1403         * WebView/WebView.mm:
1404         (-[WebView fullScreenPlaceholderView]):
1405
1406 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1407
1408         Clean up some drag and drop feature flags
1409         https://bugs.webkit.org/show_bug.cgi?id=179082
1410
1411         Reviewed by Simon Fraser.
1412
1413         * Configurations/FeatureDefines.xcconfig:
1414
1415 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1416
1417         Make it possible to test rubber-banding in overflow scroll
1418         https://bugs.webkit.org/show_bug.cgi?id=179078
1419
1420         Reviewed by Sam Weinig.
1421
1422         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1423         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1424
1425         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1426         functions, since most callers want clamped.
1427
1428         * DOM/DOMHTML.mm:
1429         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1430
1431 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1432
1433         Fix up some content filtering feature flags
1434         https://bugs.webkit.org/show_bug.cgi?id=179079
1435
1436         Reviewed by Simon Fraser.
1437
1438         * Configurations/FeatureDefines.xcconfig:
1439
1440 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1441
1442         [FrameView::layout cleanup] Move core layout logic to a separate class.
1443         https://bugs.webkit.org/show_bug.cgi?id=178771
1444         <rdar://problem/35166542>
1445
1446         Reviewed by Simon Fraser.
1447
1448         Move layout code out from FrameView to LayoutContext.
1449
1450         * WebView/WebClipView.mm:
1451         (-[WebClipView _immediateScrollToPoint:]):
1452         * WebView/WebFrame.mm:
1453         (-[WebFrame layoutCount]):
1454
1455 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1456
1457         Fix issues with WebView subframe painting
1458         https://bugs.webkit.org/show_bug.cgi?id=178842
1459         rdar://problem/34072253
1460
1461         Reviewed by Daniel Bates.
1462         
1463         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1464         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1465         High Sierra, so match the new signature.
1466
1467         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1468
1469         * WebView/WebHTMLView.mm:
1470         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1471         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1472
1473 2017-10-25  Youenn Fablet  <youenn@apple.com>
1474
1475         Enable ServiceWorker to fetch resources
1476         https://bugs.webkit.org/show_bug.cgi?id=178673
1477
1478         Reviewed by Brady Eidson.
1479
1480         * WebCoreSupport/WebFrameLoaderClient.mm:
1481         (WebFrameLoaderClient::pageID const):
1482         (WebFrameLoaderClient::frameID const):
1483         (WebFrameLoaderClient::sessionID const):
1484
1485         Added implementation to the new getters.
1486         They are noop in the context of WK1.
1487
1488 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1489
1490         Web Inspector: Enable WebKit logging configuration and display
1491         https://bugs.webkit.org/show_bug.cgi?id=177027
1492         <rdar://problem/33964767>
1493
1494         Reviewed by Joseph Pecoraro.
1495
1496         * WebCoreSupport/WebChromeClient.mm:
1497         (stringForMessageSource): Deal with Media and WebRTC message sources.
1498
1499 2017-10-20  Antoine Quint  <graouts@apple.com>
1500
1501         [Web Animations] Provide basic timeline and animation interfaces
1502         https://bugs.webkit.org/show_bug.cgi?id=178526
1503
1504         Reviewed by Dean Jackson.
1505
1506         Remove the WEB_ANIMATIONS compile-time flag.
1507
1508         * Configurations/FeatureDefines.xcconfig:
1509         * WebView/WebPreferences.mm:
1510         (+[WebPreferences initialize]):
1511         * WebView/WebView.mm:
1512         (-[WebView _preferencesChanged:]):
1513
1514 2017-10-19  Sam Weinig  <sam@webkit.org>
1515
1516         [Settings] Move global settings into their own file
1517         https://bugs.webkit.org/show_bug.cgi?id=178512
1518
1519         Reviewed by Darin Adler.
1520
1521         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1522
1523         * WebCoreSupport/WebChromeClient.mm:
1524         (WebChromeClient::supportsVideoFullscreen):
1525         * WebView/WebDynamicScrollBarsView.mm:
1526         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1527         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1528         * WebView/WebPreferences.mm:
1529         (+[WebPreferences initialize]):
1530         * WebView/WebView.mm:
1531         (-[WebView _commonInitializationWithFrameName:groupName:]):
1532         (-[WebView _preferencesChanged:]):
1533         (+[WebView _doNotStartObservingNetworkReachability]):
1534
1535 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1536
1537         Replace some stack raw pointers with RefPtrs within WebCore/html
1538         https://bugs.webkit.org/show_bug.cgi?id=178201
1539         <rdar://problem/34841692>
1540
1541         Reviewed by Ryosuke Niwa.
1542
1543         * DOM/DOM.mm:
1544         (kit):
1545         Change the type of node as toNode() is changed to return RefPtr.
1546
1547 2017-10-18  Chris Dumez  <cdumez@apple.com>
1548
1549         [Service Worker] Add stubs for Client / WindowClient / Clients
1550         https://bugs.webkit.org/show_bug.cgi?id=178469
1551
1552         Reviewed by Youenn Fablet.
1553
1554         Rename PageVisiblityState to VisibilityState.
1555
1556         * WebView/WebView.mm:
1557         (kit):
1558
1559 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1560
1561         Unreviewed, rolling out r223291.
1562
1563         See WebCore ChangeLog for more detail.
1564
1565         Reverted changeset:
1566
1567         "Remove Editor::simplifyMarkup"
1568         https://bugs.webkit.org/show_bug.cgi?id=178271
1569         https://trac.webkit.org/changeset/223291
1570
1571 2017-10-17  Keith Miller  <keith_miller@apple.com>
1572
1573         Change WebCore sources to work with unified source builds
1574         https://bugs.webkit.org/show_bug.cgi?id=178229
1575
1576         Rubber stamped by Tim Horton.
1577
1578         * Configurations/FeatureDefines.xcconfig:
1579
1580 2017-10-16  Sam Weinig  <sam@webkit.org>
1581
1582         [Settings] Remove all custom code from Settings.h/cpp
1583         https://bugs.webkit.org/show_bug.cgi?id=178330
1584
1585         Reviewed by Simon Fraser.
1586
1587         * WebView/WebPreferences.mm:
1588         (+[WebPreferences initialize]):
1589         
1590             Update for naming changes of FrameFlattening now that it is an enum class.
1591
1592 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1593
1594         Remove Editor::simplifyMarkup
1595         https://bugs.webkit.org/show_bug.cgi?id=178271
1596
1597         Reviewed by Wenson Hsieh.
1598
1599         * WebView/WebView.mm:
1600         (-[WebView _simplifyMarkup:endNode:]):
1601
1602 2017-10-12  Chris Dumez  <cdumez@apple.com>
1603
1604         [Mac] Add support for MouseEvent.buttons
1605         https://bugs.webkit.org/show_bug.cgi?id=178214
1606
1607         Reviewed by Ryosuke Niwa.
1608
1609         * WebView/WebPDFView.mm:
1610         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1611
1612 2017-10-11  Sam Weinig  <sam@webkit.org>
1613
1614         Remove out-parameter variants of copyToVector
1615         https://bugs.webkit.org/show_bug.cgi?id=178155
1616
1617         Reviewed by Tim Horton.
1618
1619         * Plugins/WebNetscapePluginView.mm:
1620         (-[WebNetscapePluginView destroyPlugin]):
1621         * WebView/WebHTMLRepresentation.mm:
1622         (newArrayWithStrings):
1623
1624             Replace out-parameter based copyToVector, with one that returns a Vector.
1625
1626 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1627
1628         Sanitize URL in pasteboard for other applications and cross origin content
1629         https://bugs.webkit.org/show_bug.cgi?id=178060
1630         <rdar://problem/34874518>
1631
1632         Reviewed by Wenson Hsieh.
1633
1634         * WebCoreSupport/WebPlatformStrategies.h:
1635         * WebCoreSupport/WebPlatformStrategies.mm:
1636         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
1637
1638 2017-10-11  Chris Dumez  <cdumez@apple.com>
1639
1640         Modernize Geolocation code
1641         https://bugs.webkit.org/show_bug.cgi?id=178148
1642
1643         Reviewed by Ryosuke Niwa.
1644
1645         * WebCoreSupport/WebGeolocationClient.h:
1646         * WebCoreSupport/WebGeolocationClient.mm:
1647         (WebGeolocationClient::lastPosition):
1648         * WebView/WebGeolocationPosition.mm:
1649         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1650         (core):
1651         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
1652         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1653         * WebView/WebGeolocationPositionInternal.h:
1654
1655 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1656
1657         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
1658         https://bugs.webkit.org/show_bug.cgi?id=178154
1659
1660         Reviewed by Wenson Hsieh.
1661
1662         Enable custom pasteboard data by default.
1663
1664         * WebView/WebPreferenceKeysPrivate.h:
1665         * WebView/WebPreferences.mm:
1666         (+[WebPreferences initialize]):
1667         (-[WebPreferences customPasteboardDataEnabled]): Added.
1668         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
1669         * WebView/WebPreferencesPrivate.h:
1670         * WebView/WebView.mm:
1671         (-[WebView _preferencesChanged:]):
1672
1673 2017-10-10  Sam Weinig  <sam@webkit.org>
1674
1675         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
1676         https://bugs.webkit.org/show_bug.cgi?id=178102
1677
1678         Reviewed by Tim Horton.
1679
1680         * History/WebHistory.mm:
1681         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1682         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1683         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1684         * WebCoreSupport/WebUserMediaClient.mm:
1685         (WebUserMediaClient::pageDestroyed):
1686
1687 2017-10-09  Robin Morisset  <rmorisset@apple.com>
1688
1689         Make the names of the options consistent
1690         https://bugs.webkit.org/show_bug.cgi?id=177933
1691
1692         Reviewed by Saam Barati.
1693
1694         * WebView/WebFrame.h:
1695         * WebView/WebHTMLView.mm:
1696         (-[WebHTMLView setMarkedText:selectedRange:]):
1697         * WebView/WebView.h:
1698
1699 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1700
1701         [iOS] Tweak support for classifying form controls (followup to r222487)
1702         https://bugs.webkit.org/show_bug.cgi?id=177917
1703         <rdar://problem/34820122>
1704
1705         Reviewed by Dean Jackson.
1706
1707         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
1708
1709         * DOM/DOMHTMLInputElement.mm:
1710         (-[DOMHTMLInputElement _autofillContext]):
1711         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
1712         (-[DOMHTMLInputElement representingPageURL]): Deleted.
1713
1714 2017-10-05  Keith Miller  <keith_miller@apple.com>
1715
1716         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
1717
1718         * Configurations/WebKitLegacy.xcconfig:
1719
1720 2017-10-05  Jer Noble  <jer.noble@apple.com>
1721
1722         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1723         https://bugs.webkit.org/show_bug.cgi?id=177261
1724
1725         Reviewed by Eric Carlson.
1726
1727         * Configurations/FeatureDefines.xcconfig:
1728
1729 2017-10-05  Chris Dumez  <cdumez@apple.com>
1730
1731         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1732         https://bugs.webkit.org/show_bug.cgi?id=177957
1733
1734         Reviewed by Alex Christensen.
1735
1736         * WebCoreSupport/WebPlatformStrategies.h:
1737         * WebCoreSupport/WebPlatformStrategies.mm:
1738         (WebPlatformStrategies::cookiesEnabled):
1739
1740 2017-10-05  Youenn Fablet  <youenn@apple.com>
1741
1742         Make LibWebRTCProvider port agnostic
1743         https://bugs.webkit.org/show_bug.cgi?id=177747
1744
1745         Reviewed by Alex Christensen & Alex Garcia.
1746
1747         * WebView/WebView.mm:
1748         (-[WebView _commonInitializationWithFrameName:groupName:]):
1749         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1750
1751 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1752
1753         Stop linking with WebKitSystemInterface
1754         https://bugs.webkit.org/show_bug.cgi?id=177915
1755
1756         Reviewed by Antti Koivisto.
1757
1758         * Configurations/DebugRelease.xcconfig:
1759         * Configurations/WebKitLegacy.xcconfig:
1760
1761 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1762
1763         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
1764         https://bugs.webkit.org/show_bug.cgi?id=177912
1765
1766         Reviewed by Saam Barati.
1767
1768         * Carbon/CarbonUtils.m:
1769         * Carbon/CarbonWindowAdapter.mm:
1770         * Carbon/HIWebView.mm:
1771         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1772         * Misc/WebNSFileManagerExtras.mm:
1773         * Misc/WebNSPasteboardExtras.mm:
1774         * Misc/WebNSURLExtras.mm:
1775         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1776         * Plugins/Hosted/NetscapePluginHostManager.mm:
1777         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1778         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1779         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1780         * Plugins/Hosted/WebTextInputWindowController.m:
1781         * Plugins/WebBaseNetscapePluginView.mm:
1782         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1783         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1784         * Plugins/WebNetscapePluginStream.mm:
1785         * Plugins/WebNetscapePluginView.mm:
1786         * Plugins/WebPluginDatabase.mm:
1787         * WebCoreSupport/PopupMenuMac.mm:
1788         * WebCoreSupport/WebChromeClient.mm:
1789         * WebCoreSupport/WebFrameLoaderClient.mm:
1790         * WebCoreSupport/WebInspectorClient.mm:
1791         * WebCoreSupport/WebPlatformStrategies.mm:
1792         * WebCoreSupport/WebSystemInterface.mm:
1793         * WebView/WebDynamicScrollBarsView.mm:
1794         * WebView/WebFrame.mm:
1795         * WebView/WebFrameView.mm:
1796         * WebView/WebFullScreenController.mm:
1797         * WebView/WebHTMLView.mm:
1798         * WebView/WebPreferences.mm:
1799         * WebView/WebView.mm:
1800
1801 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
1802
1803         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
1804         rdar://problem/34705779
1805
1806         Addressing review comments that I somehow landed without.
1807
1808         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
1809
1810 2017-09-29  Chris Dumez  <cdumez@apple.com>
1811
1812         Split some logic out of VisitedLinkStore and make it reusable
1813         https://bugs.webkit.org/show_bug.cgi?id=177575
1814
1815         Reviewed by Alex Christensen.
1816
1817         * WebCoreSupport/WebVisitedLinkStore.h:
1818         * WebCoreSupport/WebVisitedLinkStore.mm:
1819         (WebVisitedLinkStore::addVisitedLink):
1820         (WebVisitedLinkStore::removeVisitedLink):
1821         (WebVisitedLinkStore::isLinkVisited):
1822         (WebVisitedLinkStore::addVisitedLinkHash):
1823
1824 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
1825
1826         Build fix for High Sierra 32 bit Mac
1827         https://bugs.webkit.org/show_bug.cgi?id=177551
1828         <rdar://problem/34690283>
1829
1830         Reviewed by Alexey Proskuryakov.
1831
1832         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1833         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1834         also made.
1835
1836         * Carbon/CarbonWindowAdapter.mm:
1837         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1838         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1839         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1840         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1841         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1842         (-[CarbonWindowAdapter dealloc]):
1843         (-[CarbonWindowAdapter windowRef]):
1844         (-[CarbonWindowAdapter _hasWindowRef]):
1845         (-[CarbonWindowAdapter _managesWindowRef]):
1846         (-[CarbonWindowAdapter _removeWindowRef]):
1847         (-[CarbonWindowAdapter _carbonWindowClass]):
1848         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1849         (-[CarbonWindowAdapter sendSuperEvent:]):
1850         (-[CarbonWindowAdapter relinquishFocus]):
1851         (-[CarbonWindowAdapter _cancelKey:]):
1852         (-[CarbonWindowAdapter _commonAwake]):
1853         (-[CarbonWindowAdapter _destroyRealWindow:]):
1854         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1855         (-[CarbonWindowAdapter _termWindowIfOwner]):
1856         (-[CarbonWindowAdapter _windowMovedToRect:]):
1857         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1858         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1859         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1860         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1861         (-[CarbonWindowAdapter canBecomeMainWindow]):
1862         (-[CarbonWindowAdapter encodeWithCoder:]):
1863         (-[CarbonWindowAdapter initWithCoder:]):
1864         (-[CarbonWindowAdapter setContentView:]):
1865         (-[CarbonWindowAdapter worksWhenModal]):
1866         (-[CarbonWindowAdapter _setModalWindowLevel]):
1867         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1868         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1869         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1870         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1871         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1872         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1873         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1874         (NSCarbonWindowHandleEvent):
1875         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1876         (-[CarbonWindowAdapter _growBoxRect]):
1877         * Carbon/HIWebView.mm:
1878         (HIWebViewGetWebView):
1879         (HIWebViewConstructor):
1880         (HIWebViewDestructor):
1881         (HIWebViewRegisterClass):
1882         (GetBehaviors):
1883         (Draw):
1884         (HitTest):
1885         (GetRegion):
1886         (GetWindowRef):
1887         (CreateNSEventAdoptingCGEvent):
1888         (CopyEventCGEvent):
1889         (CreateNSEventWithCarbonClickEvent):
1890         (Click):
1891         (CreateNSEventWithCarbonEvent):
1892         (MouseUp):
1893         (CreateNSEventWithCarbonMouseMoveEvent):
1894         (MouseMoved):
1895         (MouseDragged):
1896         (MouseWheelMoved):
1897         (ContextMenuClick):
1898         (GetKind):
1899         (BoundsChanged):
1900         (OwningWindowChanged):
1901         (WindowHandler):
1902         (SyncFrame):
1903         (SetFocusPart):
1904         (AdvanceFocus):
1905         (RelinquishFocus):
1906         (ActiveStateChanged):
1907         (ProcessCommand):
1908         (UpdateCommandStatus):
1909         (_NSSelectorForHICommand):
1910         (HIWebViewEventHandler):
1911         (StartUpdateObserver):
1912         (StopUpdateObserver):
1913         (UpdateObserver):
1914
1915 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1916
1917         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
1918         https://bugs.webkit.org/show_bug.cgi?id=172526
1919         <rdar://problem/32396081>
1920
1921         Reviewed by Ryosuke Niwa.
1922
1923         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
1924
1925         * WebCoreSupport/WebPlatformStrategies.h:
1926         * WebCoreSupport/WebPlatformStrategies.mm:
1927         (WebPlatformStrategies::webExposedTypes):
1928         (WebPlatformStrategies::writeCustomData):
1929
1930 2017-09-27  Matt Lewis  <jlewis3@apple.com>
1931
1932         Unreviewed, rolling out r222567.
1933
1934         This broke and internal build.
1935
1936         Reverted changeset:
1937
1938         "Build fix for High Sierra 32 bit Mac"
1939         https://bugs.webkit.org/show_bug.cgi?id=177551
1940         http://trac.webkit.org/changeset/222567
1941
1942 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
1943
1944         Build fix for High Sierra 32 bit Mac
1945         https://bugs.webkit.org/show_bug.cgi?id=177551
1946         <rdar://problem/34690283>
1947
1948         Reviewed by Alexey Proskuryakov.
1949
1950         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1951         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1952         also made.
1953
1954         * Carbon/CarbonWindowAdapter.mm:
1955         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1956         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1957         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1958         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1959         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1960         (-[CarbonWindowAdapter dealloc]):
1961         (-[CarbonWindowAdapter windowRef]):
1962         (-[CarbonWindowAdapter _hasWindowRef]):
1963         (-[CarbonWindowAdapter _managesWindowRef]):
1964         (-[CarbonWindowAdapter _removeWindowRef]):
1965         (-[CarbonWindowAdapter _carbonWindowClass]):
1966         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1967         (-[CarbonWindowAdapter sendSuperEvent:]):
1968         (-[CarbonWindowAdapter relinquishFocus]):
1969         (-[CarbonWindowAdapter _cancelKey:]):
1970         (-[CarbonWindowAdapter _commonAwake]):
1971         (-[CarbonWindowAdapter _destroyRealWindow:]):
1972         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1973         (-[CarbonWindowAdapter _termWindowIfOwner]):
1974         (-[CarbonWindowAdapter _windowMovedToRect:]):
1975         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1976         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1977         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1978         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1979         (-[CarbonWindowAdapter canBecomeMainWindow]):
1980         (-[CarbonWindowAdapter encodeWithCoder:]):
1981         (-[CarbonWindowAdapter initWithCoder:]):
1982         (-[CarbonWindowAdapter setContentView:]):
1983         (-[CarbonWindowAdapter worksWhenModal]):
1984         (-[CarbonWindowAdapter _setModalWindowLevel]):
1985         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1986         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1987         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1988         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1989         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1990         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1991         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1992         (NSCarbonWindowHandleEvent):
1993         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1994         (-[CarbonWindowAdapter _growBoxRect]):
1995         * Carbon/HIWebView.mm:
1996         (HIWebViewGetWebView):
1997         (HIWebViewConstructor):
1998         (HIWebViewDestructor):
1999         (HIWebViewRegisterClass):
2000         (GetBehaviors):
2001         (Draw):
2002         (HitTest):
2003         (GetRegion):
2004         (GetWindowRef):
2005         (CreateNSEventAdoptingCGEvent):
2006         (CopyEventCGEvent):
2007         (CreateNSEventWithCarbonClickEvent):
2008         (Click):
2009         (CreateNSEventWithCarbonEvent):
2010         (MouseUp):
2011         (CreateNSEventWithCarbonMouseMoveEvent):
2012         (MouseMoved):
2013         (MouseDragged):
2014         (MouseWheelMoved):
2015         (ContextMenuClick):
2016         (GetKind):
2017         (BoundsChanged):
2018         (OwningWindowChanged):
2019         (WindowHandler):
2020         (SyncFrame):
2021         (SetFocusPart):
2022         (AdvanceFocus):
2023         (RelinquishFocus):
2024         (ActiveStateChanged):
2025         (ProcessCommand):
2026         (UpdateCommandStatus):
2027         (_NSSelectorForHICommand):
2028         (HIWebViewEventHandler):
2029         (StartUpdateObserver):
2030         (StopUpdateObserver):
2031         (UpdateObserver):
2032
2033 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2034
2035         Make PolicyAction an encodable enum class
2036         https://bugs.webkit.org/show_bug.cgi?id=177480
2037
2038         Reviewed by Antti Koivisto.
2039
2040         * Plugins/WebPluginContainerCheck.mm:
2041         (-[WebPluginContainerCheck _continueWithPolicy:]):
2042         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2043         * WebCoreSupport/WebFrameLoaderClient.mm:
2044         (-[WebFramePolicyListener invalidate]):
2045         (-[WebFramePolicyListener ignore]):
2046         (-[WebFramePolicyListener download]):
2047         (-[WebFramePolicyListener use]):
2048         (-[WebFramePolicyListener continue]):
2049         * WebView/WebPolicyDelegate.mm:
2050         (-[WebPolicyDecisionListener use]):
2051         (-[WebPolicyDecisionListener ignore]):
2052         (-[WebPolicyDecisionListener download]):
2053
2054 2017-09-25  Frederik Riedel  <riedel@apple.com>
2055
2056         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2057         https://bugs.webkit.org/show_bug.cgi?id=174394
2058         <rdar://problem/33183504>
2059
2060         Reviewed by Ryosuke Niwa.
2061
2062         * DOM/DOMHTMLInputElement.h:
2063         * DOM/DOMHTMLInputElement.mm:
2064         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2065         Determines if this HTMLInputElement is part of a login screen.
2066         (-[DOMHTMLInputElement representingPageUrl]):
2067         Returns the webpage's URL that is currently displayed in the Web View.
2068         (-[DOMHTMLInputElement insertTextSuggestion:]):
2069         Inserts login credentials into the Web View.
2070
2071 2017-09-25  Sam Weinig  <sam@webkit.org>
2072
2073         Remove unused EditorClient functions
2074         https://bugs.webkit.org/show_bug.cgi?id=177463
2075
2076         Reviewed by Alex Christensen.
2077
2078         Remove unused EditorClient functions.
2079
2080         * WebCoreSupport/WebEditorClient.h:
2081         * WebCoreSupport/WebEditorClient.mm:
2082         (WebEditorClient::canonicalizeURL): Deleted.
2083         (WebEditorClient::canonicalizeURLString): Deleted.
2084         (WebEditorClient::writeDataToPasteboard): Deleted.
2085         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2086         (WebEditorClient::readDataFromPasteboard): Deleted.
2087         (WebEditorClient::pasteboardChangeCount): Deleted.
2088
2089 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2090
2091         Stop using PolicyCallback
2092         https://bugs.webkit.org/show_bug.cgi?id=176088
2093
2094         Reviewed by Andy Estes.
2095
2096         * WebCoreSupport/WebFrameLoaderClient.mm:
2097         (-[WebFramePolicyListener invalidate]):
2098         (-[WebFramePolicyListener receivedPolicyDecision:]):
2099
2100 2017-09-25  Sam Weinig  <sam@webkit.org>
2101
2102         Remove unnecessary userVisibleString EditorClient function
2103         https://bugs.webkit.org/show_bug.cgi?id=177456
2104
2105         Reviewed by Dan Bernstein.
2106
2107         * WebCoreSupport/WebEditorClient.h:
2108         * WebCoreSupport/WebEditorClient.mm:
2109         (WebEditorClient::userVisibleString): Deleted.
2110
2111             Remove userVisibleString client function.
2112
2113 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2114
2115         Separate form submission from PolicyChecker infrastructure
2116         https://bugs.webkit.org/show_bug.cgi?id=177396
2117
2118         Reviewed by Geoffrey Garen.
2119
2120         * WebCoreSupport/WebFrameLoaderClient.h:
2121         * WebCoreSupport/WebFrameLoaderClient.mm:
2122         (WebFrameLoaderClient::dispatchWillSubmitForm):
2123
2124 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2125
2126         WeakPtrFactory should populate m_ref lazily.
2127         https://bugs.webkit.org/show_bug.cgi?id=177375
2128
2129         Reviewed by Geoffrey Garen.
2130
2131         * WebCoreSupport/WebEditorClient.mm:
2132         (WebEditorClient::WebEditorClient):
2133         (WebEditorClient::requestCandidatesForSelection):
2134
2135 2017-09-22  Chris Dumez  <cdumez@apple.com>
2136
2137         Use high resolution timestamp for event time
2138         https://bugs.webkit.org/show_bug.cgi?id=154246
2139         <rdar://problem/34333304>
2140
2141         Reviewed by Ryosuke Niwa.
2142
2143         Use WallTime / MonotonicTime instead of double type for clarity.
2144
2145         * DOM/DOMEvent.mm:
2146         (-[DOMEvent timeStamp]):
2147         * WebView/WebFrame.mm:
2148         (-[WebFrame _dragSourceEndedAt:operation:]):
2149         * WebView/WebPDFView.mm:
2150         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2151
2152 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2153
2154         Enable dataTransfer.items on macOS and iOS
2155         https://bugs.webkit.org/show_bug.cgi?id=177335
2156
2157         Reviewed by Sam Weinig.
2158
2159         * WebView/WebPreferences.mm:
2160         (+[WebPreferences initialize]):
2161
2162 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2163
2164         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2165         https://bugs.webkit.org/show_bug.cgi?id=177101
2166         <rdar://problem/34500648>
2167
2168         Reviewed by Brian Burg.
2169
2170         * WebInspector/WebNodeHighlight.mm:
2171         Ensure we close the window that we have just removed.
2172
2173 2017-09-20  Antti Koivisto  <antti@apple.com>
2174
2175         Remove DOM and styling support for CSS Regions
2176         https://bugs.webkit.org/show_bug.cgi?id=177221
2177
2178         Reviewed by Andreas Kling.
2179
2180         * Configurations/FeatureDefines.xcconfig:
2181         * DOM/DOMCSS.mm:
2182         (kitClass):
2183         * DOM/DOMElement.mm:
2184         (-[DOMElement webkitRegionOverset]): Deleted.
2185
2186 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2187
2188         Layering violation in Editor::createFragment
2189         https://bugs.webkit.org/show_bug.cgi?id=176123
2190
2191         Reviewed by Darin Adler.
2192
2193         * Misc/WebNSURLExtras.h:
2194         * Misc/WebNSURLExtras.mm:
2195         * WebView/WebFrame.mm:
2196         * WebView/WebHTMLView.mm:
2197         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2198
2199         * WebCoreSupport/WebEditorClient.mm:
2200         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2201         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2202         way to avoid exporting the symbol just on newer OSes.
2203
2204 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2205
2206         On iOS, getData can't get text set by setData during copy event
2207         https://bugs.webkit.org/show_bug.cgi?id=176980
2208         <rdar://problem/34453915>
2209
2210         Reviewed by Darin Adler.
2211
2212         * WebCoreSupport/WebPlatformStrategies.h:
2213         * WebCoreSupport/WebPlatformStrategies.mm:
2214         (WebPlatformStrategies::copy): Deleted.
2215
2216 2017-09-18  Andy Estes  <aestes@apple.com>
2217
2218         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2219         https://bugs.webkit.org/show_bug.cgi?id=177029
2220
2221         Reviewed by Alex Christensen.
2222
2223         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2224         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2225         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2226         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2227         * WebCoreSupport/PopupMenuMac.mm:
2228         (PopupMenuMac::show):
2229         * WebCoreSupport/WebSystemInterface.mm:
2230         (InitWebCoreSystemInterface):
2231         * WebView/WebHTMLView.mm:
2232         (-[WebHTMLView setDataSource:]):
2233         (-[WebHTMLView attachRootLayer:]):
2234         * WebView/WebView.mm:
2235         (-[WebView _needsAdobeFrameReloadingQuirk]):
2236         (-[WebView _needsLinkElementTextCSSQuirk]):
2237         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2238         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2239         (-[WebView _preferencesChanged:]):
2240
2241 2017-09-15  Andy Estes  <aestes@apple.com>
2242
2243         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2244         https://bugs.webkit.org/show_bug.cgi?id=176953
2245
2246         Reviewed by Eric Carlson.
2247
2248         * WebCoreSupport/WebSystemInterface.mm:
2249         (InitWebCoreSystemInterface):
2250
2251 2017-09-14  Andy Estes  <aestes@apple.com>
2252
2253         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2254         https://bugs.webkit.org/show_bug.cgi?id=176931
2255
2256         Reviewed by Joseph Pecoraro.
2257
2258         * WebCoreSupport/WebSystemInterface.mm:
2259         (InitWebCoreSystemInterface):
2260
2261 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2262
2263         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2264         https://bugs.webkit.org/show_bug.cgi?id=176867
2265
2266         Reviewed by Sam Weinig.
2267
2268         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2269         (WebKit::NetscapePluginInstanceProxy::enumerate):
2270
2271 2017-09-13  Andy Estes  <aestes@apple.com>
2272
2273         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2274         https://bugs.webkit.org/show_bug.cgi?id=176729
2275
2276         Reviewed by Alex Christensen.
2277
2278         * WebCoreSupport/WebSystemInterface.mm:
2279         (InitWebCoreSystemInterface):
2280         * WebView/WebView.mm:
2281         (+[WebView _setCacheModel:]):
2282
2283 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2284
2285         Refactor WebContentReader out of EditorMac and EditorIOS
2286         https://bugs.webkit.org/show_bug.cgi?id=176770
2287
2288         Reviewed by Sam Weinig.
2289
2290         * WebCoreSupport/WebEditorClient.mm:
2291
2292 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2293
2294         Dragging & dropping a file creates an attachment element even when it's disabled
2295         https://bugs.webkit.org/show_bug.cgi?id=176769
2296
2297         Reviewed by Tim Horton.
2298
2299         * WebView/WebView.mm:
2300         (-[WebView _preferencesChanged:]):
2301
2302 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2303
2304         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2305         https://bugs.webkit.org/show_bug.cgi?id=176721
2306         <rdar://problem/34373660>
2307
2308         Reviewed by Tim Horton.
2309
2310         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2311         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2312
2313         * WebView/WebView.mm:
2314         (-[WebView _startDrag:]):
2315         (-[WebView _draggedElementBounds]):
2316         (-[WebView _endedDataInteraction:global:]):
2317         * WebView/WebViewData.h:
2318
2319 2017-09-11  Andy Estes  <aestes@apple.com>
2320
2321         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2322         https://bugs.webkit.org/show_bug.cgi?id=176472
2323
2324         Reviewed by Eric Carlson.
2325
2326         * WebCoreSupport/WebSystemInterface.mm:
2327         (InitWebCoreSystemInterface):
2328
2329 2017-09-09  Mark Lam  <mark.lam@apple.com>
2330
2331         Avoid duplicate computations of ExecState::vm().
2332         https://bugs.webkit.org/show_bug.cgi?id=176647
2333
2334         Reviewed by Saam Barati.
2335
2336         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2337         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2338         (WebKit::NetscapePluginInstanceProxy::construct):
2339         (WebKit::NetscapePluginInstanceProxy::setProperty):
2340         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2341         (WebKit::NetscapePluginInstanceProxy::enumerate):
2342         * Plugins/Hosted/ProxyInstance.mm:
2343         (WebKit::ProxyRuntimeMethod::create):
2344
2345 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2346
2347         Unreviewed, rolling out r221773.
2348         https://bugs.webkit.org/show_bug.cgi?id=176614
2349
2350         This caused build failures. (Requested by mlewis13 on
2351         #webkit).
2352
2353         Reverted changeset:
2354
2355         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2356         https://bugs.webkit.org/show_bug.cgi?id=176472
2357         http://trac.webkit.org/changeset/221773
2358
2359 2017-09-07  Andy Estes  <aestes@apple.com>
2360
2361         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2362         https://bugs.webkit.org/show_bug.cgi?id=176472
2363
2364         Reviewed by Eric Carlson.
2365
2366         * WebCoreSupport/WebSystemInterface.mm:
2367         (InitWebCoreSystemInterface):
2368
2369 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2370
2371         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2372         https://bugs.webkit.org/show_bug.cgi?id=176561
2373
2374         Reviewed by Brent Fulgham.
2375
2376         * Misc/WebNSUserDefaultsExtras.mm:
2377
2378 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2379
2380         Modernize Geolocation code
2381         https://bugs.webkit.org/show_bug.cgi?id=176496
2382
2383         Reviewed by Andy Estes.
2384
2385         * WebCoreSupport/WebGeolocationClient.h:
2386         * WebCoreSupport/WebGeolocationClient.mm:
2387         (WebGeolocationClient::requestPermission):
2388         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2389         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2390         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2391         * WebView/WebView.mm:
2392         (-[WebView _commonInitializationWithFrameName:groupName:]):
2393         (-[WebView _geolocationDidFailWithMessage:]):
2394
2395 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2396
2397         Remove some unused bits of code and resources
2398         https://bugs.webkit.org/show_bug.cgi?id=176275
2399
2400         Reviewed by Dan Bernstein.
2401
2402         * Misc/WebNSFileManagerExtras.mm:
2403         Include FileSystem instead of FileSystemIOS.
2404
2405 2017-09-03  Darin Adler  <darin@apple.com>
2406
2407         [Cocoa] Tidy a few things in legacy WebHTMLView
2408         https://bugs.webkit.org/show_bug.cgi?id=176280
2409
2410         Reviewed by Dan Bernstein.
2411
2412         * WebCoreSupport/WebChromeClient.mm:
2413         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2414         methods it calls on WebHTMLView were doing nothing on iOS.
2415
2416         * WebView/WebFrame.mm:
2417         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2418         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2419
2420         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2421         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2422         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2423         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2424         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2425         Use RetainPtr instead of writing retain/release wherever possible.
2426         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2427         initialization for it. Removed various unused methods and declarations of methods.
2428         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2429         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2430         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2431         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2432         and remove CFRetain no longer needed since we don't support garbage collection any more.
2433         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2434         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2435         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2436         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2437         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2438         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2439         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2440         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2441         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2442         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2443         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2444         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2445         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2446         debug flag; we haven't used it for years and it's not clearly helpful.
2447         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2448         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2449         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2450         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2451         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2452         two additional methods in the WebPrivate category and still be called by the two
2453         methods in the WebInternal category that were already using it.
2454         (-[WebHTMLView didAddSubview:]): Deleted.
2455         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2456         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2457         place this was called, the close method.
2458         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2459         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2460         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2461         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2462         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2463         Added helper method to make the one below simpler.
2464         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2465         Compared pasteboard type strings using isEqualToString: rather than using == since
2466         we want to actually compare the string contents. Also updated to use modern for loop,
2467         renamed a local variable from "s" to "localSubresources", and factored out the handling
2468         of three image types to use the helper method above.
2469         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2470         _web_makePluginSubviewsPerformSelector:withObject: method.
2471         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2472         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2473         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2474         not call the -[NSView subviews] method to make this identical on both platforms and used
2475         a modern for loop.
2476         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2477         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2478         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2479         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2480         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2481         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2482         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2483         of it is Mac-only.
2484         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2485         method did was call itself on the main thread, and do nothing if called on main thread.
2486         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2487         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2488         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2489         half of this method.
2490         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2491         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2492         Simplified using a modern for loop and RetainPtr.
2493         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2494         (-[WebHTMLView keyDown:]): Ditto.
2495         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2496         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2497         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2498         (-[WebHTMLView complete:]): Ditto.
2499         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2500         now macOS-only.
2501         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2502         iOS since that is now macOS-only.
2503         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2504         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2505         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2506         and reorganized to use early return.
2507         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2508         on iOS, but kept there so we don't have to do #if at every call site.
2509         (-[WebHTMLView _pluginController]): Moved into internal category.
2510         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2511         there only for GC, using C++ initialization, removing obsolete comment.
2512         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2513         peculiar iOS-only comment.
2514         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2515
2516         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2517         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2518         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2519         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2520         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2521
2522         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2523         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2524         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2525         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2526         them at this time.
2527
2528 2017-09-03  Sam Weinig  <sam@webkit.org>
2529
2530         Remove CanvasProxy
2531         https://bugs.webkit.org/show_bug.cgi?id=176288
2532
2533         Reviewed by Yusuke Suzuki.
2534
2535         CanvasProxy does not appear to be in any current HTML spec
2536         and was disabled and unimplemented in our tree. Time to 
2537         get rid of it.
2538
2539         * Configurations/FeatureDefines.xcconfig:
2540
2541 2017-09-02  Andy Estes  <aestes@apple.com>
2542
2543         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2544         https://bugs.webkit.org/show_bug.cgi?id=176270
2545
2546         Reviewed by Tim Horton.
2547
2548         * Plugins/Hosted/NetscapePluginHostManager.mm:
2549         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2550         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2551         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2552         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2553         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2554         (WebKit::SoftwareCARenderer::context const):
2555         (WebKit::SoftwareCARenderer::renderContext const):
2556         (WebKit::SoftwareCARenderer::render):
2557         (-[WebHostedNetscapePluginView createPlugin]):
2558         (-[WebHostedNetscapePluginView createPluginLayer]):
2559         (-[WebHostedNetscapePluginView destroyPlugin]):
2560         (-[WebHostedNetscapePluginView drawRect:]):
2561         * WebCoreSupport/WebSystemInterface.mm:
2562         (InitWebCoreSystemInterface):
2563
2564 2017-09-01  Andy Estes  <aestes@apple.com>
2565
2566         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2567         https://bugs.webkit.org/show_bug.cgi?id=176200
2568
2569         Reviewed by Tim Horton.
2570
2571         * Carbon/HIWebView.mm:
2572         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2573         (overrideCGContext):
2574         (restoreCGContext):
2575         (Draw):
2576         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2577         (+[WebHostedNetscapePluginView initialize]):
2578         * Plugins/WebBaseNetscapePluginView.h:
2579         * Plugins/WebBaseNetscapePluginView.mm:
2580         (WebKit::sendUserChangeNotifications):
2581         * Plugins/WebNetscapePluginView.mm:
2582         (+[WebNetscapePluginView initialize]):
2583         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2584         * WebCoreSupport/WebSystemInterface.mm:
2585         (InitWebCoreSystemInterface):
2586         * WebView/WebFrame.mm:
2587         (-[WebFrame _paintBehaviorForDestinationContext:]):
2588         * WebView/WebFullScreenController.mm:
2589         (setClipRectForWindow):
2590         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2591         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2592         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2593         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2594
2595 2017-08-31  Andy Estes  <aestes@apple.com>
2596
2597         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2598         https://bugs.webkit.org/show_bug.cgi?id=176175
2599
2600         Reviewed by Brady Eidson.
2601
2602         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2603         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2604         * Plugins/Hosted/WebTextInputWindowController.m:
2605         (-[WebTextInputPanel init]):
2606         * WebCoreSupport/WebSystemInterface.mm:
2607         (InitWebCoreSystemInterface):
2608         * WebView/WebDynamicScrollBarsView.mm:
2609         (-[WebDynamicScrollBarsView scrollWheel:]):
2610         * WebView/WebHTMLView.mm:
2611         (-[WebHTMLView _removeWindowObservers]):
2612         (-[WebHTMLView addWindowObservers]):
2613         * WebView/WebView.mm:
2614         (-[WebView addWindowObserversForWindow:]):
2615         (-[WebView removeWindowObservers]):
2616         (-[WebView viewWillMoveToWindow:]):
2617
2618 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2619
2620         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2621         https://bugs.webkit.org/show_bug.cgi?id=175779
2622         <rdar://problem/22367975>
2623
2624         Reviewed by Tim Horton.
2625
2626         * WebCoreSupport/WebFrameLoaderClient.h:
2627         * WebCoreSupport/WebFrameLoaderClient.mm:
2628         (WebFrameLoaderClient::webGLPolicyForURL const):
2629         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2630
2631 2017-08-30  Andy Estes  <aestes@apple.com>
2632
2633         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
2634         https://bugs.webkit.org/show_bug.cgi?id=176093
2635
2636         Reviewed by Eric Carlson.
2637
2638         * WebCoreSupport/WebSystemInterface.mm:
2639         (InitWebCoreSystemInterface):
2640
2641 2017-08-30  Andy Estes  <aestes@apple.com>
2642
2643         [Mac] Upstream Carbon-related WebKitSystemInterface functions
2644         https://bugs.webkit.org/show_bug.cgi?id=176087
2645
2646         Reviewed by Alex Christensen.
2647
2648         * Carbon/CarbonUtils.m:
2649         (getNSAutoreleasePoolCount):
2650         (WebInitForCarbon):
2651         (PoolCleaner):
2652         * Carbon/CarbonWindowAdapter.mm:
2653         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2654         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2655         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2656         (-[CarbonWindowAdapter _windowMovedToRect:]):
2657         * Carbon/HIViewAdapter.m:
2658         * Carbon/HIWebView.mm:
2659         (Draw):
2660         (CreateNSEventAdoptingCGEvent):
2661         (CopyEventCGEvent):
2662         (CreateNSEventWithCarbonClickEvent):
2663         (Click):
2664         (CreateNSEventWithCarbonEvent):
2665         (MouseUp):
2666         (CreateNSEventWithCarbonMouseMoveEvent):
2667         (MouseMoved):
2668         (MouseDragged):
2669         (MouseWheelMoved):
2670         (WindowHandler):
2671         (HIWebViewEventHandler):
2672         * Misc/QuickDrawCompatibility.h: Removed.
2673         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2674         (getCarbonEvent):
2675         (WebNetscapePluginEventHandlerCarbon::keyDown):
2676         (WebNetscapePluginEventHandlerCarbon::keyUp):
2677         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2678         (WebNetscapePluginEventHandlerCocoa::keyDown):
2679         * Plugins/WebNetscapePluginView.mm:
2680         (-[WebNetscapePluginView tellQuickTimeToChill]):
2681
2682 2017-08-29  Andy Estes  <aestes@apple.com>
2683
2684         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
2685         https://bugs.webkit.org/show_bug.cgi?id=176046
2686
2687         Reviewed by Alex Christensen.
2688
2689         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
2690         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
2691
2692         * Misc/WebNSFileManagerExtras.mm:
2693         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2694         (setMetaData): Deleted.
2695         * WebCoreSupport/WebSystemInterface.mm:
2696         (InitWebCoreSystemInterface):
2697
2698 2017-08-28  Andy Estes  <aestes@apple.com>
2699
2700         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
2701         https://bugs.webkit.org/show_bug.cgi?id=176039
2702
2703         Reviewed by Alex Christensen.
2704
2705         * WebCoreSupport/WebSystemInterface.mm:
2706         (InitWebCoreSystemInterface):
2707         * WebView/WebPreferences.mm:
2708         (+[WebPreferences _systemCFStringEncoding]):
2709
2710 2017-08-28  Andy Estes  <aestes@apple.com>
2711
2712         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
2713         https://bugs.webkit.org/show_bug.cgi?id=176032
2714
2715         Reviewed by Alex Christensen.
2716
2717         * WebCoreSupport/WebSystemInterface.mm:
2718         (InitWebCoreSystemInterface):
2719         * WebView/WebView.mm:
2720         (-[WebView _cachedResponseForURL:]):
2721
2722 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2723
2724         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
2725         https://bugs.webkit.org/show_bug.cgi?id=175992
2726         <rdar://problem/34086613>
2727
2728         Reviewed by Daniel Bates.
2729
2730         * WebCoreSupport/WebPlatformStrategies.h:
2731         * WebCoreSupport/WebPlatformStrategies.mm:
2732         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
2733         cookies should be included, and return a pair containing the resulting cookie string and a boolean
2734         indicating if secure cookies were accessed.
2735
2736 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2737
2738         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
2739         https://bugs.webkit.org/show_bug.cgi?id=170955
2740         <rdar://problem/31697653>
2741
2742         Reviewed by Ryosuke Niwa.
2743
2744         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
2745         text is being replaced.
2746
2747         * WebView/WebHTMLView.mm:
2748         (-[WebHTMLView insertText:]):
2749
2750 2017-08-24  Chris Dumez  <cdumez@apple.com>
2751
2752         [Directory Upload] Add basic support for input.webkitdirectory
2753         https://bugs.webkit.org/show_bug.cgi?id=175950
2754         <rdar://problem/33951915>
2755
2756         Reviewed by Geoffrey Garen.
2757
2758         Add private API to toggle Directory Upload support on Mac WebKit1.
2759
2760         * WebView/WebPreferenceKeysPrivate.h:
2761         * WebView/WebPreferences.mm:
2762         (+[WebPreferences initialize]):
2763         (-[WebPreferences setDirectoryUploadEnabled:]):
2764         (-[WebPreferences directoryUploadEnabled]):
2765         * WebView/WebPreferencesPrivate.h:
2766         * WebView/WebView.mm:
2767         (-[WebView _preferencesChanged:]):
2768
2769 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2770
2771         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2772         https://bugs.webkit.org/show_bug.cgi?id=175370
2773         <rdar://problem/33799806>
2774
2775         Reviewed by Ryosuke Niwa.
2776
2777         Adjust WebEditorClient for interface changes.
2778
2779         * WebCoreSupport/WebEditorClient.h:
2780
2781 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2782
2783         Remove ChromeClient::scrollbarsModeDidChange
2784         https://bugs.webkit.org/show_bug.cgi?id=175805
2785
2786         Reviewed by Daniel Bates.
2787
2788         * WebCoreSupport/WebChromeClient.h:
2789
2790 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2791
2792         Remove ChromeClient::hasOpenedPopup
2793         https://bugs.webkit.org/show_bug.cgi?id=175804
2794
2795         Reviewed by Sam Weinig.
2796
2797         * WebCoreSupport/WebChromeClient.h:
2798         * WebCoreSupport/WebChromeClient.mm:
2799         (WebChromeClient::hasOpenedPopup const): Deleted.
2800
2801 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
2802
2803         Disable access to secure cookies if an HTTPS site loads mixed content
2804         https://bugs.webkit.org/show_bug.cgi?id=157053
2805         <rdar://problem/11290808>
2806
2807         Reviewed by Dan Bates.
2808
2809         * WebCoreSupport/WebPlatformStrategies.h:
2810         * WebCoreSupport/WebPlatformStrategies.mm:
2811         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
2812         indicating whether secure cookies should be included in the response.
2813
2814 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2815
2816         [PAL] Move spi/mac directory into PAL
2817         https://bugs.webkit.org/show_bug.cgi?id=175649
2818
2819         Reviewed by Myles C. Maxfield.
2820
2821         * Misc/WebSharingServicePickerController.h:
2822         * WebCoreSupport/WebContextMenuClient.mm:
2823         * WebCoreSupport/WebEditorClient.mm:
2824         * WebCoreSupport/WebSelectionServiceController.mm:
2825         * WebView/WebHTMLView.mm:
2826         * WebView/WebImmediateActionController.h:
2827         * WebView/WebImmediateActionController.mm:
2828         * WebView/WebView.mm:
2829
2830 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2831
2832         [PAL] Relocate SessionID to root
2833         https://bugs.webkit.org/show_bug.cgi?id=175684
2834
2835         Reviewed by Alex Christensen.
2836
2837         * WebCoreSupport/WebFrameNetworkingContext.mm:
2838
2839 2017-08-17  Andreas Kling  <akling@apple.com>
2840
2841         Disable CSS regions at compile time
2842         https://bugs.webkit.org/show_bug.cgi?id=175630
2843
2844         Reviewed by Antti Koivisto.
2845
2846         * Configurations/FeatureDefines.xcconfig:
2847
2848 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2849
2850         [PAL] Move SessionID into PAL
2851         https://bugs.webkit.org/show_bug.cgi?id=174192
2852
2853         Reviewed by Antti Koivisto.
2854
2855         * Misc/WebCache.mm:
2856         (+[WebCache imageForURL:]):
2857         * WebCoreSupport/WebFrameLoaderClient.h:
2858         * WebCoreSupport/WebFrameLoaderClient.mm:
2859         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2860         * WebCoreSupport/WebFrameNetworkingContext.mm:
2861         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2862         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2863         (WebFrameNetworkingContext::storageSession const):
2864         * WebCoreSupport/WebPlatformStrategies.h:
2865         * WebCoreSupport/WebPlatformStrategies.mm:
2866         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2867         * WebKitPrefix.h:
2868
2869 2017-08-16  Andy Estes  <aestes@apple.com>
2870
2871         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
2872         https://bugs.webkit.org/show_bug.cgi?id=175648
2873
2874         Reviewed by Tim Horton.
2875
2876         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2877         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2878         (WebPaymentCoordinatorClient::showPaymentUI):
2879
2880 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2881
2882         [PAL] Move spi/ios and spi/win directories into PAL
2883         https://bugs.webkit.org/show_bug.cgi?id=175171
2884
2885         Reviewed by Antti Koivisto.
2886
2887         * WebCoreSupport/WebFrameLoaderClient.mm:
2888         * WebView/WebView.mm:
2889
2890 2017-08-16  Andy Estes  <aestes@apple.com>
2891
2892         [Payment Request] Add an ENABLE flag and an experimental feature preference
2893         https://bugs.webkit.org/show_bug.cgi?id=175622
2894
2895         Reviewed by Tim Horton.
2896
2897         * Configurations/FeatureDefines.xcconfig:
2898
2899 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
2900
2901         [PAL] Move Sleep classes into PAL
2902         https://bugs.webkit.org/show_bug.cgi?id=175456
2903
2904         Reviewed by Ryosuke Niwa.
2905
2906         * WebView/WebFullScreenController.h:
2907
2908 2017-08-15  Youenn Fablet  <youenn@apple.com>
2909
2910         [Cache API] Adding generic support for CacheStorage and Cache methods
2911         https://bugs.webkit.org/show_bug.cgi?id=175455
2912
2913         Reviewed by Chris Dumez.
2914
2915         * WebView/WebView.mm:
2916         (-[WebView _commonInitializationWithFrameName:groupName:]):
2917
2918 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2919
2920         Remove Proximity Events and related code
2921         https://bugs.webkit.org/show_bug.cgi?id=175545
2922
2923         Reviewed by Daniel Bates.
2924
2925         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
2926         and other related code.
2927
2928         * Configurations/FeatureDefines.xcconfig:
2929
2930 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2931
2932         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
2933         https://bugs.webkit.org/show_bug.cgi?id=175504
2934
2935         Reviewed by Sam Weinig.
2936
2937         * Configurations/FeatureDefines.xcconfig:
2938         * DOM/DOMHTMLFormElement.mm:
2939         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
2940         * WebCoreSupport/WebFrameLoaderClient.h:
2941
2942 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2943
2944         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
2945         https://bugs.webkit.org/show_bug.cgi?id=175557
2946
2947         Reviewed by Jon Lee.
2948
2949         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
2950
2951         * Configurations/FeatureDefines.xcconfig:
2952
2953 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2954
2955         Composition underline color is always black
2956         https://bugs.webkit.org/show_bug.cgi?id=174675
2957
2958         Reviewed by Ryosuke Niwa.
2959
2960         * WebView/WebHTMLView.mm:
2961         (extractUnderlines): If NSUnderlineColorAttributeName
2962         is not present use text color for composition underline.
2963         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
2964         for composition underline in the plain text case.
2965
2966 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
2967
2968         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
2969         https://bugs.webkit.org/show_bug.cgi?id=175474
2970         <rdar://problem/33844628>
2971
2972         Reviewed by Wenson Hsieh.
2973
2974         Replaced the build flag by a runtime flag and disabled the feature by default.
2975
2976         * Configurations/FeatureDefines.xcconfig:
2977         * WebView/WebPreferenceKeysPrivate.h:
2978         * WebView/WebPreferences.mm:
2979         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
2980         (-[WebPreferences dataTransferItemsEnabled]): Added.
2981         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
2982         * WebView/WebPreferencesPrivate.h:
2983         * WebView/WebView.mm:
2984         (-[WebView _preferencesChanged:]):
2985
2986 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2987
2988         Remove ENABLE_GAMEPAD_DEPRECATED
2989         https://bugs.webkit.org/show_bug.cgi?id=175361
2990
2991         Reviewed by Carlos Garcia Campos.
2992
2993         * Configurations/FeatureDefines.xcconfig:
2994
2995 2017-08-09  Chris Dumez  <cdumez@apple.com>
2996
2997         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
2998         https://bugs.webkit.org/show_bug.cgi?id=175401
2999
3000         Reviewed by Brady Eidson.
3001
3002         * WebView/WebPreferenceKeysPrivate.h:
3003         * WebView/WebPreferences.mm:
3004         (+[WebPreferences initialize]):
3005         (-[WebPreferences beaconAPIEnabled]): Deleted.
3006         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3007         * WebView/WebPreferencesPrivate.h:
3008         * WebView/WebView.mm:
3009         (-[WebView _preferencesChanged:]):
3010
3011 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3012
3013         [PAL] Move spi/cocoa and spi/cg directories into PAL
3014         https://bugs.webkit.org/show_bug.cgi?id=175175
3015
3016         Reviewed by Myles C. Maxfield.
3017
3018         * History/WebHistory.mm:
3019         * Misc/WebDownload.mm:
3020         * Misc/WebKitNSStringExtras.mm:
3021         * Plugins/Hosted/NetscapePluginHostManager.mm:
3022         * Plugins/WebPluginDatabase.mm:
3023         * WebCoreSupport/WebFrameLoaderClient.mm:
3024         * WebInspector/WebNodeHighlight.mm:
3025         * WebView/WebHTMLView.mm:
3026         * WebView/WebIndicateLayer.mm:
3027         * WebView/WebView.mm:
3028         * WebView/WebViewData.h:
3029
3030 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3031
3032         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3033         https://bugs.webkit.org/show_bug.cgi?id=175392
3034         <rdar://problem/33783207>
3035
3036         Reviewed by Tim Horton and Megan Gardner.
3037
3038         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3039
3040         * Configurations/FeatureDefines.xcconfig:
3041
3042 2017-08-09  Daniel Bates  <dabates@apple.com>
3043
3044         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3045         https://bugs.webkit.org/show_bug.cgi?id=175247
3046         <rdar://problem/33679804>
3047
3048         Reviewed by Brady Eidson.
3049
3050         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3051         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3052         clients that need to make use of this information at this time. If such a needs comes up
3053         then we can expose API/SPI similar to what we do for WebKit.
3054
3055         * WebCoreSupport/WebFrameLoaderClient.h:
3056         * WebCoreSupport/WebFrameLoaderClient.mm:
3057         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3058
3059 2017-08-08  Brady Eidson  <beidson@apple.com>
3060
3061         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3062         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3063
3064         Reviewed by Andy Estes.
3065
3066         * Misc/WebKitVersionChecks.h:
3067         * WebCoreSupport/WebFrameLoaderClient.mm:
3068         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3069           the app is linked against new WebKit with the new behavior.
3070
3071 2017-08-07  Devin Rousso  <drousso@apple.com>
3072
3073         Web Inspector: Preview Canvas path when viewing a recording
3074         https://bugs.webkit.org/show_bug.cgi?id=174967
3075
3076         Reviewed by Brian Burg.
3077
3078         * WebView/WebPreferenceKeysPrivate.h:
3079         * WebView/WebPreferences.mm:
3080         (+[WebPreferences initialize]):
3081         (-[WebPreferences inspectorAdditionsEnabled]):
3082         (-[WebPreferences setInspectorAdditionsEnabled:]):
3083         * WebView/WebPreferencesPrivate.h:
3084         * WebView/WebView.mm:
3085         (-[WebView _preferencesChanged:]):
3086         Add plumbing for new InspectorAdditions runtime flag.
3087
3088 2017-08-07  Brian Burg  <bburg@apple.com>
3089
3090         Remove CANVAS_PATH compilation guard
3091         https://bugs.webkit.org/show_bug.cgi?id=175207
3092
3093         Reviewed by Sam Weinig.
3094
3095         * Configurations/FeatureDefines.xcconfig:
3096
3097 2017-08-04  Youenn Fablet  <youenn@apple.com>
3098
3099         [Cache API] Add Cache and CacheStorage IDL definitions
3100         https://bugs.webkit.org/show_bug.cgi?id=175201
3101
3102         Reviewed by Brady Eidson.
3103
3104         * WebView/WebPreferenceKeysPrivate.h:
3105         * WebView/WebPreferences.mm:
3106         (+[WebPreferences initialize]):
3107         (-[WebPreferences cacheAPIEnabled]):
3108         (-[WebPreferences setCacheAPIEnabled:]):
3109         * WebView/WebPreferencesPrivate.h:
3110         * WebView/WebView.mm:
3111         (-[WebView _preferencesChanged:]):
3112
3113 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3114
3115         Unreviewed, rolling out r220271.
3116
3117         Rolling out due to Layout Test failing on iOS Simulator.
3118
3119         Reverted changeset:
3120
3121         "Remove STREAMS_API compilation guard"
3122         https://bugs.webkit.org/show_bug.cgi?id=175165
3123         http://trac.webkit.org/changeset/220271
3124
3125 2017-08-04  Youenn Fablet  <youenn@apple.com>
3126
3127         Remove STREAMS_API compilation guard
3128         https://bugs.webkit.org/show_bug.cgi?id=175165
3129
3130         Reviewed by Darin Adler.
3131
3132         * Configurations/FeatureDefines.xcconfig:
3133         * WebView/WebPreferences.mm:
3134         (+[WebPreferences initialize]):
3135         * WebView/WebView.mm:
3136         (-[WebView _preferencesChanged:]):
3137
3138 2017-08-03  Brian Burg  <bburg@apple.com>
3139
3140         Remove ENABLE(WEB_SOCKET) guards
3141         https://bugs.webkit.org/show_bug.cgi?id=167044
3142
3143         Reviewed by Joseph Pecoraro.
3144
3145         * Configurations/FeatureDefines.xcconfig:
3146         * WebView/WebPreferencesPrivate.h:
3147
3148 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3149
3150         [PAL] Move spi/cf directory into PAL
3151         https://bugs.webkit.org/show_bug.cgi?id=175057
3152
3153         Reviewed by Antti Koivisto.
3154
3155         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3156         * Plugins/WebNetscapePluginStream.mm:
3157         * WebCoreSupport/WebFrameNetworkingContext.mm:
3158         * WebView/WebPreferences.mm:
3159         * WebView/WebView.mm:
3160
3161 2017-08-03  Youenn Fablet  <youenn@apple.com>
3162
3163         Remove FETCH_API compilation guard
3164         https://bugs.webkit.org/show_bug.cgi?id=175154
3165
3166         Reviewed by Chris Dumez.
3167
3168         * Configurations/FeatureDefines.xcconfig:
3169         * WebView/WebPreferences.mm:
3170         (+[WebPreferences initialize]):
3171         * WebView/WebView.mm:
3172         (-[WebView _preferencesChanged:]):
3173
3174 2017-08-03  Brady Eidson  <beidson@apple.com>
3175
3176         Add SW IDLs and stub out basic functionality.
3177         https://bugs.webkit.org/show_bug.cgi?id=175115
3178
3179         Reviewed by Chris Dumez.
3180
3181         * Configurations/FeatureDefines.xcconfig:
3182
3183 2017-08-02  Sam Weinig  <sam@webkit.org>
3184
3185         [WebIDL] Convert MutationCallback to be a normal generated callback
3186         https://bugs.webkit.org/show_bug.cgi?id=174140
3187
3188         Reviewed by Darin Adler.
3189
3190         * DOM/DOMDocument.mm:
3191         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3192         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3193         Pass, now necessary, Document to NativeNodeFilter constructor.
3194
3195 2017-08-01  Chris Dumez  <cdumez@apple.com>
3196
3197         Add initial support for navigator.sendBeacon
3198         https://bugs.webkit.org/show_bug.cgi?id=175007
3199         <rdar://problem/33547728>
3200
3201         Reviewed by Sam Weinig.
3202
3203         Add setting to toggle support for the Beacon API (it is disabled by default).
3204
3205         * WebView/WebPreferenceKeysPrivate.h:
3206         * WebView/WebPreferences.mm:
3207         (+[WebPreferences initialize]):
3208         (-[WebPreferences beaconAPIEnabled]):
3209         (-[WebPreferences setBeaconAPIEnabled:]):
3210         * WebView/WebPreferencesPrivate.h:
3211         * WebView/WebView.mm:
3212         (-[WebView _preferencesChanged:]):
3213
3214 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3215
3216         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3217         https://bugs.webkit.org/show_bug.cgi?id=174437
3218
3219         Reviewed by Darin Adler.
3220
3221         Remove redundant Web- prefix from classes in WebKit namespace.
3222
3223         * WebView/WebView.mm:
3224         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3225         * WebView/WebViewData.h:
3226         * WebView/WebViewData.mm:
3227
3228 2017-07-26  Brian Burg  <bburg@apple.com>
3229
3230         Remove WEB_TIMING feature flag
3231         https://bugs.webkit.org/show_bug.cgi?id=174795
3232
3233         Reviewed by Alex Christensen.
3234
3235         * Configurations/FeatureDefines.xcconfig:
3236
3237 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3238
3239         Async image decoding for large images should be disabled after the first time a tile is painted
3240         https://bugs.webkit.org/show_bug.cgi?id=174451
3241         <rdar://problem/31246421>
3242
3243         Reviewed by Simon Fraser.
3244
3245         * WebView/WebFrame.mm:
3246         (-[WebFrame _paintBehaviorForDestinationContext:]):
3247         (-[WebFrame _drawRect:contentsOnly:]):
3248         * WebView/WebHTMLView.mm:
3249         (imageFromRect):
3250
3251 2017-07-23  Darin Adler  <darin@apple.com>
3252
3253         More NeverDestroyed and related cleanup
3254         https://bugs.webkit.org/show_bug.cgi?id=174745
3255
3256         Reviewed by Alex Christensen.
3257
3258         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3259         for names that aren't even used in this file.
3260         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3261         -[NSArray arrayWithObject:].
3262         (-[DOMNode absoluteQuads]): Ditto.
3263         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3264         of writing out various types.
3265         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3266         syntax instea of -[NSArray arrayWithObject:].
3267         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3268         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3269         of writing out various types.
3270         (-[DOMHTMLImageElement mimeType]): Ditto.
3271
3272 2017-07-24  Chris Dumez  <cdumez@apple.com>
3273
3274         ExceptionCode enumeration should use modern exception names
3275         https://bugs.webkit.org/show_bug.cgi?id=174794
3276
3277         Reviewed by Geoffrey Garen.
3278
3279         * DOM/ExceptionHandlers.mm:
3280         (raiseNotSupportedErrorException):
3281
3282 2017-07-23  Chris Dumez  <cdumez@apple.com>
3283
3284         Drop ExceptionCodeDescription class
3285         https://bugs.webkit.org/show_bug.cgi?id=174757
3286
3287         Reviewed by Darin Adler.
3288
3289         Stop using ExceptionCodeDescription.
3290
3291         * DOM/ExceptionHandlers.mm:
3292         (raiseDOMErrorException):
3293
3294 2017-07-21  Andreas Kling  <akling@apple.com>
3295
3296         Use more references in event dispatch code
3297         https://bugs.webkit.org/show_bug.cgi?id=174681
3298
3299         Reviewed by Geoffrey Garen.
3300
3301         * DOM/ObjCEventListener.h:
3302         * DOM/ObjCEventListener.mm:
3303         (WebCore::ObjCEventListener::handleEvent):
3304         * WebCoreSupport/WebFrameLoaderClient.mm:
3305         (NetscapePluginWidget::handleEvent):
3306
3307 2017-07-21  Brady Eidson  <beidson@apple.com>
3308
3309         Get rid of WebCore IconDatabase code.
3310         https://bugs.webkit.org/show_bug.cgi?id=174700
3311
3312         Reviewed by Tim Horton.
3313
3314         * Misc/WebCoreStatistics.mm:
3315         (+[WebCoreStatistics iconPageURLMappingCount]):
3316         (+[WebCoreStatistics iconRetainedPageURLCount]):
3317         (+[WebCoreStatistics iconRecordCount]):
3318         (+[WebCoreStatistics iconsWithDataCount]):
3319         * WebCoreSupport/WebFrameLoaderClient.h:
3320         * WebCoreSupport/WebFrameLoaderClient.mm:
3321         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
3322         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
3323         * WebView/WebView.mm:
3324         (-[WebView mainFrameIconURL]):
3325
3326 2017-07-20  Chris Dumez  <cdumez@apple.com>
3327
3328         Drop legacy XPathException type
3329         https://bugs.webkit.org/show_bug.cgi?id=174679
3330
3331         Reviewed by Sam Weinig.
3332
3333         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3334         no longer expose XPathException.
3335
3336         * DOM/ExceptionHandlers.mm:
3337         (raiseDOMErrorException):
3338
3339 2017-07-20  Chris Dumez  <cdumez@apple.com>
3340
3341         Unreviewed, rolling out r219706.
3342
3343         Broke iOS build
3344
3345         Reverted changeset:
3346
3347         "Drop legacy XPathException type"
3348         https://bugs.webkit.org/show_bug.cgi?id=174679
3349         http://trac.webkit.org/changeset/219706
3350
3351 2017-07-20  Chris Dumez  <cdumez@apple.com>
3352
3353         Drop legacy XPathException type
3354         https://bugs.webkit.org/show_bug.cgi?id=174679
3355
3356         Reviewed by Sam Weinig.
3357
3358         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3359         no longer expose XPathException.
3360
3361         * DOM/ExceptionHandlers.mm:
3362         (raiseDOMErrorException):
3363         * WebKit.exp:
3364
3365 2017-07-20  Chris Dumez  <cdumez@apple.com>
3366
3367         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
3368         https://bugs.webkit.org/show_bug.cgi?id=174660
3369
3370         Reviewed by Geoffrey Garen.
3371
3372         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
3373         This essentially replaces a branch to figure out if the new size is less or greater than the
3374         current size by an assertion.
3375
3376         * Plugins/WebNetscapePluginView.mm:
3377         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3378
3379 2017-07-20  Brady Eidson  <beidson@apple.com>
3380
3381         Deprecate WebIconDatabase in WebKitLegacy/mac.
3382         https://bugs.webkit.org/show_bug.cgi?id=174607
3383
3384         Reviewed by Alex Christensen.
3385
3386         This patch:
3387         1 - Formally deprecates WebIconDatabase (which was never API anyways)
3388         2 - Guts the class to where it can only return the default icon at the small size
3389         3 - Reworks other parts of WebKitLegacy that used it for anything to either
3390             use something else or to not do anything.
3391         
3392         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
3393         and that patch will remove all of the last remnants of WebIconDatabase.
3394         
3395         * History/WebHistoryItem.mm:
3396         (-[WebHistoryItem icon]):
3397
3398         * Misc/WebIconDatabase.h:
3399         * Misc/WebIconDatabase.mm:
3400         (-[WebIconDatabase init]):
3401         (-[WebIconDatabase iconForURL:withSize:cache:]):
3402         (-[WebIconDatabase iconForURL:withSize:]):
3403         (-[WebIconDatabase defaultIconWithSize:]):
3404         (-[WebIconDatabase defaultIconForURL:withSize:]):
3405         (-[WebIconDatabase iconURLForURL:]):
3406         (-[WebIconDatabase retainIconForURL:]):
3407         (-[WebIconDatabase releaseIconForURL:]):
3408         (+[WebIconDatabase delayDatabaseCleanup]):
3409         (+[WebIconDatabase allowDatabaseCleanup]):
3410         (-[WebIconDatabase setDelegate:]):
3411         (-[WebIconDatabase delegate]):
3412         (+[WebIconDatabase initialize]): Deleted.
3413         (-[WebIconDatabase isEnabled]): Deleted.
3414         (-[WebIconDatabase setEnabled:]): Deleted.
3415         (-[WebIconDatabase removeAllIcons]): Deleted.
3416         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
3417         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
3418         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
3419         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
3420         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
3421         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
3422         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
3423         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
3424         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
3425         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
3426         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
3427         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
3428         (-[WebIconDatabase _databaseDirectory]): Deleted.
3429         (webGetNSImage): Deleted.
3430
3431         * Misc/WebIconDatabaseDelegate.h: Removed.
3432         * Misc/WebIconDatabaseInternal.h: Removed.
3433         * Misc/WebIconDatabasePrivate.h: Removed.
3434
3435         * WebCoreSupport/WebFrameLoaderClient.mm:
3436         (webGetNSImage):
3437
3438         * WebCoreSupport/WebIconDatabaseClient.mm:
3439         (WebIconDatabaseClient::didRemoveAllIcons):
3440         (WebIconDatabaseClient::didImportIconURLForPageURL):
3441
3442         * WebView/WebView.mm:
3443         (-[WebView setFrameLoadDelegate:]):
3444         (-[WebView mainFrameIcon]):
3445
3446 2017-07-18  Andy Estes  <aestes@apple.com>
3447
3448         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3449         https://bugs.webkit.org/show_bug.cgi?id=174631
3450
3451         Reviewed by Tim Horton.
3452
3453         * Configurations/Base.xcconfig:
3454
3455 2017-07-18  Andy Estes  <aestes@apple.com>
3456
3457         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3458         https://bugs.webkit.org/show_bug.cgi?id=174631
3459
3460         Reviewed by Sam Weinig.
3461
3462         * Configurations/Base.xcconfig:
3463
3464 2017-07-18  Andy Estes  <aestes@apple.com>
3465
3466         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3467         https://bugs.webkit.org/show_bug.cgi?id=174631
3468
3469         Reviewed by Dan Bernstein.
3470
3471         * Configurations/Base.xcconfig:
3472
3473 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3474
3475         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
3476         https://bugs.webkit.org/show_bug.cgi?id=174640
3477         <rdar://problem/33297400>
3478
3479         Reviewed by Tim Horton.
3480
3481         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
3482         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
3483         web thread here, to match the other WebView drag and drop SPI methods.
3484
3485         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
3486         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
3487         should make this robust against future UIKit changes that could make this no longer the case.
3488
3489         * WebView/WebView.mm:
3490         (-[WebView _requestStartDataInteraction:globalPosition:]):
3491         (-[WebView _dataInteractionCaretRect]):
3492
3493 2017-07-18  Andy Estes  <aestes@apple.com>
3494
3495         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3496         https://bugs.webkit.org/show_bug.cgi?id=174631
3497
3498         Reviewed by Darin Adler.
3499
3500         * Configurations/Base.xcconfig:
3501
3502 2017-07-17  Sam Weinig  <sam@webkit.org>
3503
3504         [WebIDL] Remove custom bindings that require non-caching JS strings
3505         https://bugs.webkit.org/show_bug.cgi?id=174552
3506
3507         Reviewed by Darin Adler.
3508
3509         * DOM/DOMHTMLCanvasElement.mm:
3510         (-[DOMHTMLCanvasElement toDataURL:]):
3511         Update to account for implementation now returning an UncachedString.
3512
3513 2017-07-17  Darin Adler  <darin@apple.com>
3514
3515         Improve use of NeverDestroyed
3516         https://bugs.webkit.org/show_bug.cgi?id=174348
3517
3518         Reviewed by Sam Weinig.
3519
3520         * Misc/WebStringTruncator.mm:
3521         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
3522         NeverDestroyed<RetainPtr> with just an NSFont * global.
3523
3524         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
3525         NeverDestroyed.h.
3526         * Storage/WebDatabaseManager.mm: Ditto.
3527         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
3528         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
3529
3530         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
3531         (aeDescFromJSValue): Removed double hashing by using the return value from
3532         add rather than calling contains before calling add.
3533
3534 2017-07-14  Jer Noble  <jer.noble@apple.com>
3535
3536         Allow clients to override their own hardware media requirements where no fallback media exists.
3537         https://bugs.webkit.org/show_bug.cgi?id=174426
3538         <rdar://problem/32537704>
3539
3540         Reviewed by Eric Carlson.
3541
3542         Add a new WebPreferences property to control WebCore's new
3543         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
3544
3545         * WebView/WebPreferenceKeysPrivate.h:
3546         * WebView/WebPreferences.mm:
3547         (+[WebPreferences initialize]):
3548         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
3549         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
3550         * WebView/WebPreferencesPrivate.h:
3551         * WebView/WebView.mm:
3552         (-[WebView _preferencesChanged:]):
3553
3554 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
3555
3556         Async image decoding for large images should be disabled by default
3557         https://bugs.webkit.org/show_bug.cgi?id=174432
3558
3559         Reviewed by Simon Fraser.
3560
3561         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
3562         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
3563         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
3564            a child view instead of propagating PaintBehaviorSnapshotting.
3565         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
3566            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
3567
3568         * WebView/WebFrame.mm:
3569         (-[WebFrame _paintBehaviorForDestinationContext:]):
3570         (-[WebFrame _drawRect:contentsOnly:]):
3571         * WebView/WebHTMLView.mm:
3572         (imageFromRect):
3573
3574 2017-07-12  Daniel Bates  <dabates@apple.com>
3575
3576         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3577         https://bugs.webkit.org/show_bug.cgi?id=174427
3578
3579         Rubber-stamped by Brady Eidson.
3580
3581         * WebView/WebPDFView.mm:
3582         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3583
3584 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3585
3586         Unreviewed, rolling out r219401.
3587
3588         This revision rolled out the previous patch, but after talking
3589         with reviewer, a rebaseline is what was needed.Rolling back in
3590         before rebaseline.
3591
3592         Reverted changeset:
3593
3594         "Unreviewed, rolling out r219379."
3595         https://bugs.webkit.org/show_bug.cgi?id=174400
3596         http://trac.webkit.org/changeset/219401
3597
3598 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3599
3600         Unreviewed, rolling out r219379.
3601
3602         This revision caused a consistent failure in the test
3603         fast/dom/Window/property-access-on-cached-window-after-frame-
3604         removed.html.
3605
3606         Reverted changeset:
3607
3608         "Remove NAVIGATOR_HWCONCURRENCY"
3609         https://bugs.webkit.org/show_bug.cgi?id=174400
3610         http://trac.webkit.org/changeset/219379
3611
3612 2017-07-11  Dean Jackson  <dino@apple.com>
3613
3614         Remove NAVIGATOR_HWCONCURRENCY
3615         https://bugs.webkit.org/show_bug.cgi?id=174400
3616
3617         * Configurations/FeatureDefines.xcconfig:
3618
3619 2017-07-11  Dean Jackson  <dino@apple.com>
3620
3621         Rolling out r219372.
3622
3623         * Configurations/FeatureDefines.xcconfig:
3624
3625 2017-07-11  Dean Jackson  <dino@apple.com>
3626
3627         Remove NAVIGATOR_HWCONCURRENCY
3628         https://bugs.webkit.org/show_bug.cgi?id=174400
3629
3630         * Configurations/FeatureDefines.xcconfig:
3631
3632 2017-07-03  Brian Burg  <bburg@apple.com>
3633
3634         Web Replay: remove some unused code
3635         https://bugs.webkit.org/show_bug.cgi?id=173903
3636
3637         Rubber-stamped by Joseph Pecoraro.
3638
3639         * Configurations/FeatureDefines.xcconfig:
3640
3641 2017-07-09  Brady Eidson  <beidson@apple.com>
3642
3643         Remove some obsolete WebKitVersionChecks.
3644         https://bugs.webkit.org/show_bug.cgi?id=174294
3645
3646         Reviewed by Dan Bernstein.
3647
3648         * Misc/WebKitVersionChecks.h:
3649
3650         * WebView/WebHTMLView.mm:
3651         (-[WebHTMLView hitTest:]):
3652
3653         * WebView/WebView.mm:
3654         (shouldRespectPriorityInCSSAttributeSetters):
3655         (-[WebView _commonInitializationWithFrameName:groupName:]):
3656         (-[WebView _preferencesChanged:]):
3657         (shouldTransformsAffectOverflow): Deleted.
3658         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
3659
3660 2017-07-08  Brady Eidson  <beidson@apple.com>
3661
3662         Remove some obsolete RuntimeApplicationChecks.
3663         https://bugs.webkit.org/show_bug.cgi?id=174293
3664
3665         Reviewed by Dan Bernstein.
3666
3667         * Misc/WebKitVersionChecks.h:
3668         * WebView/WebView.mm:
3669         (+[WebView enableWebThread]):
3670         (-[WebView _needsPreHTML5ParserQuirks]):
3671
3672 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3673
3674         Drop NOSNIFF compile flag
3675         https://bugs.webkit.org/show_bug.cgi?id=174289
3676
3677         Reviewed by Michael Catanzaro.
3678
3679         * Configurations/FeatureDefines.xcconfig:
3680
3681 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3682
3683         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3684         https://bugs.webkit.org/show_bug.cgi?id=174150
3685
3686         Reviewed by Mark Lam.
3687
3688         * DOM/DOM.mm:
3689         (lookupElementClass):
3690
3691 2017-07-06  Brady Eidson  <beidson@apple.com>
3692
3693         Add logging to first attempt to use the WebIconDatabase class.
3694         https://bugs.webkit.org/show_bug.cgi?id=174190
3695
3696         Reviewed by Andy Estes.
3697
3698         * Misc/WebIconDatabase.mm:
3699         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
3700         * Misc/WebKitVersionChecks.h:
3701
3702 2017-07-06  Matt Lewis  <jlewis3@apple.com>
3703
3704         Unreviewed, rolling out r219178.
3705
3706         This caused a consistent failure with the API test
3707         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
3708
3709         Reverted changeset:
3710
3711         "[WTF] Clean up StringStatics.cpp by using
3712         LazyNeverDestroyed<> for Atoms"
3713         https://bugs.webkit.org/show_bug.cgi?id=174150
3714         http://trac.webkit.org/changeset/219178
3715
3716 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3717
3718         [WTF] Move SoftLinking.h into WTF
3719         https://bugs.webkit.org/show_bug.cgi?id=174000
3720
3721         Reviewed by Alex Christensen.
3722
3723         * Plugins/WebNetscapePluginView.mm:
3724         * Plugins/WebPluginController.mm:
3725         * WebCoreSupport/WebInspectorClient.mm:
3726         * WebView/WebFullScreenController.mm:
3727         * WebView/WebImmediateActionController.mm:
3728         * WebView/WebView.mm:
3729
3730 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3731
3732         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3733         https://bugs.webkit.org/show_bug.cgi?id=174150
3734
3735         Reviewed by Mark Lam.
3736
3737         * DOM/DOM.mm:
3738         (lookupElementClass):
3739
3740 2017-07-05  Brady Eidson  <beidson@apple.com>
3741
3742         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3743         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3744
3745         Reviewed by Alex Christensen.
3746
3747         Adopt to the new constructor for FrameLoadRequest.
3748
3749         * WebView/WebPDFView.mm:
3750         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3751
3752 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3753
3754         Make WebKit's public headers on Mac and iOS C++ module safe
3755         https://bugs.webkit.org/show_bug.cgi?id=174175
3756
3757         Reviewed by Alex Christensen.
3758
3759         Fixed the header files.
3760
3761         * Misc/WebDownload.h:
3762         * Misc/WebKitErrors.h:
3763         * Plugins/WebPluginContainer.h:
3764         * WebView/WebResourceLoadDelegate.h:
3765
3766 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3767
3768         Remove copy of ICU headers from WebKit
3769         https://bugs.webkit.org/show_bug.cgi?id=116407
3770
3771         Reviewed by Alex Christensen.
3772
3773         Use WTF's copy of ICU headers.
3774
3775         * Configurations/WebKitLegacy.xcconfig:
3776         * icu/unicode/localpointer.h: Removed.
3777         * icu/unicode/parseerr.h: Removed.
3778         * icu/unicode/platform.h: Removed.
3779         * icu/unicode/ptypes.h: Removed.
3780         * icu/unicode/putil.h: Removed.
3781         * icu/unicode/uchar.h: Removed.
3782         * icu/unicode/uconfig.h: Removed.
3783         * icu/unicode/ucurr.h: Removed.
3784         * icu/unicode/uidna.h: Removed.
3785         * icu/unicode/uiter.h: Removed.
3786         * icu/unicode/umachine.h: Removed.
3787         * icu/unicode/unorm.h: Removed.
3788         * icu/unicode/unorm2.h: Removed.
3789         * icu/unicode/urename.h: Removed.
3790         * icu/unicode/uscript.h: Removed.
3791         * icu/unicode/ustring.h: Removed.
3792         * icu/unicode/utf.h: Removed.
3793         * icu/unicode/utf16.h: Removed.
3794         * icu/unicode/utf8.h: Removed.
3795         * icu/unicode/utf_old.h: Removed.
3796         * icu/unicode/utypes.h: Removed.
3797         * icu/unicode/uvernum.h: Removed.
3798         * icu/unicode/uversion.h: Removed.
3799
3800 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3801
3802         Add WebKitPrivateFrameworkStubs for iOS 11
3803         https://bugs.webkit.org/show_bug.cgi?id=173988
3804
3805         Reviewed by David Kilzer.
3806
3807         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
3808         use the same directory for private framework stubs.
3809
3810 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3811
3812         Unreviewed, rolling out r219103.
3813
3814         Caused multiple build failures.
3815
3816         Reverted changeset:
3817
3818         "Remove copy of ICU headers from WebKit"
3819         https://bugs.webkit.org/show_bug.cgi?id=116407
3820         http://trac.webkit.org/changeset/219103
3821
3822 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3823
3824         Remove copy of ICU headers from WebKit
3825         https://bugs.webkit.org/show_bug.cgi?id=116407
3826
3827         Reviewed by Alex Christensen.
3828
3829         Use WTF's copy of ICU headers.
3830
3831         * Configurations/WebKitLegacy.xcconfig:
3832         * icu/unicode/localpointer.h: Removed.
3833         * icu/unicode/parseerr.h: Removed.
3834         * icu/unicode/platform.h: Removed.
3835         * icu/unicode/ptypes.h: Removed.
3836         * icu/unicode/putil.h: Removed.
3837         * icu/unicode/uchar.h: Removed.
3838         * icu/unicode/uconfig.h: Removed.
3839         * icu/unicode/ucurr.h: Removed.
3840         * icu/unicode/uidna.h: Removed.
3841         * icu/unicode/uiter.h: Removed.
3842         * icu/unicode/umachine.h: Removed.
3843         * icu/unicode/unorm.h: Removed.
3844         * icu/unicode/unorm2.h: Removed.
3845         * icu/unicode/urename.h: Removed.
3846         * icu/unicode/uscript.h: Removed.
3847         * icu/unicode/ustring.h: Removed.
3848         * icu/unicode/utf.h: Removed.
3849         * icu/unicode/utf16.h: Removed.
3850         * icu/unicode/utf8.h: Removed.
3851         * icu/unicode/utf_old.h: Removed.
3852         * icu/unicode/utypes.h: Removed.
3853         * icu/unicode/uvernum.h: Removed.
3854         * icu/unicode/uversion.h: Removed.
3855
3856 2017-07-03  Brady Eidson  <beidson@apple.com>
3857
3858         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3859         https://bugs.webkit.org/show_bug.cgi?id=174073
3860
3861         Reviewed by Andy Estes.
3862
3863         WebView now keeps a direct copy of its main frame icon as a member variable.
3864         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
3865         
3866         This change causes a progression in KVO observation of the mainFrameIcon property as we now
3867         have both the old icon and new icon at the time it changes.
3868
3869         * WebCoreSupport/WebFrameLoaderClient.h:
3870         * WebCoreSupport/WebFrameLoaderClient.mm:
3871         (WebFrameLoaderClient::prepareForDataSourceReplacement):
3872         (WebFrameLoaderClient::getLoadDecisionForIcons):
3873         (WebFrameLoaderClient::finishedLoadingIcon):
3874         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3875         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3876
3877         * WebView/WebView.mm:
3878         (+[WebView _setIconLoadingEnabled:]):
3879         (+[WebView _isIconLoadingEnabled]):
3880         (-[WebView mainFrameIcon]):
3881         (-[WebView _setMainFrameIcon:]):
3882         (-[WebView _receivedIconChangedNotification:]): Deleted.
3883         (-[WebView _registerForIconNotification:]): Deleted.
3884         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
3885         * WebView/WebViewData.h:
3886         * WebView/WebViewInternal.h:
3887         * WebView/WebViewPrivate.h:
3888
3889 2017-07-03  Sam Weinig  <sam@webkit.org>
3890
3891         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
3892         https://bugs.webkit.org/show_bug.cgi?id=174083
3893
3894         Reviewed by Alex Christensen.
3895
3896         * Configurations/FeatureDefines.xcconfig:
3897         Add ENABLE_NAVIGATOR_STANDALONE.
3898
3899 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3900
3901         Expose unobscuredSafeAreaInsets on WebView
3902         https://bugs.webkit.org/show_bug.cgi?id=174075
3903         <rdar://problem/33096997>
3904
3905         Reviewed by Beth Dakin.
3906
3907         * WebView/WebView.mm:
3908         (-[WebView _setUnobscuredSafeAreaInsets:]):
3909         (-[WebView _unobscuredSafeAreaInsets]):
3910         * WebView/WebViewPrivate.h:
3911         Expose unobscuredSafeAreaInsets as a new private property on WebView,
3912         similar to how it is exposed in WebKit2.
3913
3914 2017-07-03  Andy Estes  <aestes@apple.com>
3915
3916         [Xcode] Add an experimental setting to build with ccache
3917         https://bugs.webkit.org/show_bug.cgi?id=173875
3918
3919         Reviewed by Tim Horton.
3920
3921         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3922
3923 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3924
3925         Expose WebPreferences for viewport-fit and constant() properties
3926         https://bugs.webkit.org/show_bug.cgi?id=174072
3927         <rdar://problem/33096639>
3928
3929         Reviewed by Ryosuke Niwa.
3930
3931         * WebView/WebPreferenceKeysPrivate.h:
3932         * WebView/WebPreferences.mm:
3933         (-[WebPreferences viewportFitEnabled]):
3934         (-[WebPreferences setViewportFitEnabled:]):
3935         (-[WebPreferences constantPropertiesEnabled]):
3936         (-[WebPreferences setConstantPropertiesEnabled:]):
3937         * WebView/WebPreferencesPrivate.h:
3938         * WebView/WebView.mm:
3939         (-[WebView _preferencesChanged:]):
3940
3941 2017-07-01  Tim Horton  <timothy_horton@apple.com>
3942
3943         Expose viewport-fit value to UIKit via viewport arguments dictionary
3944         https://bugs.webkit.org/show_bug.cgi?id=174071
3945         <rdar://problem/33096620>
3946
3947         Reviewed by Wenson Hsieh.
3948
3949         * History/WebHistoryItem.mm:
3950         * History/WebHistoryItemPrivate.h:
3951         Add another dictionary key and three values.
3952
3953 2017-07-01  Dan Bernstein  <mitz@apple.com>
3954
3955         [iOS] Remove code only needed when building for iOS 9.x
3956         https://bugs.webkit.org/show_bug.cgi?id=174068
3957
3958         Reviewed by Tim Horton.
3959
3960         * Configurations/FeatureDefines.xcconfig:
3961
3962 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3963
3964         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3965         https://bugs.webkit.org/show_bug.cgi?id=174004
3966
3967         Reviewed by Simon Fraser.
3968
3969         * WebCoreSupport/WebPluginInfoProvider.mm:
3970
3971 2017-07-01  Dan Bernstein  <mitz@apple.com>
3972
3973         [macOS] Remove code only needed when building for OS X Yosemite
3974         https://bugs.webkit.org/show_bug.cgi?id=174067
3975
3976         Reviewed by Tim Horton.
3977
3978         * Configurations/Base.xcconfig:
3979         * Configurations/DebugRelease.xcconfig:
3980         * Configurations/FeatureDefines.xcconfig:
3981         * Configurations/Version.xcconfig:
3982         * Plugins/WebBasePluginPackage.mm:
3983         (-[WebBasePluginPackage getPluginInfoFromPLists]):
3984         * WebCoreSupport/PopupMenuMac.mm:
3985         (PopupMenuMac::show):
3986         * WebCoreSupport/WebInspectorClient.mm:
3987         (WebInspectorFrontendClient::startWindowDrag):
3988         (-[WebInspectorWindowController window]):
3989         * WebView/WebView.mm:
3990         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3991
3992 2017-06-30  Daniel Bates  <dabates@apple.com>
3993
3994         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3995         https://bugs.webkit.org/show_bug.cgi?id=165160
3996         <rdar://problem/29451999>
3997
3998         Reviewed by Brady Eidson.
3999
4000         Pass the document that is requesting the load to the loader.
4001
4002         * WebView/WebPDFView.mm:
4003         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4004
4005 2017-06-29  Jer Noble  <jer.noble@apple.com>
4006
4007         Make Legacy EME API controlled by RuntimeEnabled setting.
4008         https://bugs.webkit.org/show_bug.cgi?id=173994
4009
4010         Reviewed by Sam Weinig.
4011
4012         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
4013
4014         * Configurations/FeatureDefines.xcconfig:
4015         * WebView/WebPreferenceKeysPrivate.h:
4016         * WebView/WebPreferences.mm:
4017         (+[WebPreferences initialize]):
4018         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
4019         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
4020         * WebView/WebPreferencesPrivate.h:
4021         * WebView/WebView.mm:
4022         (-[WebView _preferencesChanged:]):
4023
4024 2017-06-30  Chris Dumez  <cdumez@apple.com>
4025
4026         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
4027         https://bugs.webkit.org/show_bug.cgi?id=174013
4028
4029         Reviewed by Brent Fulgham.
4030
4031         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
4032         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
4033
4034         * WebView/WebView.mm:
4035         (-[WebView _commonInitializationWithFrameName:groupName:]):
4036
4037 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
4038
4039         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
4040         https://bugs.webkit.org/show_bug.cgi?id=174017
4041         <rdar://problem/32959782>
4042
4043         Reviewed by Simon Fraser.
4044
4045         Use root view coordinates when computing the drag caret rect.
4046
4047         * WebView/WebView.mm:
4048         (-[WebView _dataInteractionCaretRect]):
4049
4050 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
4051
4052         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
4053         https://bugs.webkit.org/show_bug.cgi?id=173899
4054         rdar://problem/32994474
4055
4056         Reviewed by Tim Horton.
4057
4058         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
4059         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
4060         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
4061
4062         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
4063         documentView is a WebHTMLView.
4064
4065         * WebView/WebFrame.mm:
4066         (-[WebFrame _webHTMLDocumentView]):
4067         (-[WebFrame _paintBehaviorForDestinationContext:]):
4068         (-[WebFrame _drawRect:contentsOnly:]):
4069         (-[WebFrame setTimeoutsPaused:]):
4070         (-[WebFrame prepareForPause]):
4071         (-[WebFrame resumeFromPause]):
4072         (-[WebFrame resetTextAutosizingBeforeLayout]):
4073         * WebView/WebHTMLView.mm:
4074         (-[WebHTMLView drawLayer:inContext:]):
4075         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
4076         * WebView/WebHTMLViewInternal.h:
4077
4078 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
4079
4080         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
4081         https://bugs.webkit.org/show_bug.cgi?id=173854
4082         <rdar://problem/32236827>
4083
4084         Reviewed by Ryosuke Niwa and Tim Horton.
4085