Stop using NetworkStorageSession::storageSession in WebCore
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2
3         Stop using NetworkStorageSession::storageSession in WebCore
4         https://bugs.webkit.org/show_bug.cgi?id=193529
5
6         Reviewed by Tim Horton.
7
8         * Misc/WebCache.mm:
9         (+[WebCache addImageToCache:forURL:forFrame:]):
10         * WebView/WebView.mm:
11         (-[WebView _commonInitializationWithFrameName:groupName:]):
12         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
13
14 2019-01-15  Alex Christensen  <achristensen@webkit.org>
15
16         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
17         https://bugs.webkit.org/show_bug.cgi?id=193368
18
19         Reviewed by Geoff Garen.
20
21         * Misc/WebCache.mm:
22         (+[WebCache clearCachedCredentials]):
23         * Misc/WebDownload.mm:
24         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
25         * Plugins/WebBaseNetscapePluginView.mm:
26         (WebKit::getAuthenticationInfo):
27
28 2019-01-15  Alex Christensen  <achristensen@webkit.org>
29
30         Stop using CookiesStrategy
31         https://bugs.webkit.org/show_bug.cgi?id=161106
32
33         Reviewed by Don Olmstead and Antti Koivisto.
34
35         * Misc/WebCache.mm:
36         (+[WebCache addImageToCache:forURL:forFrame:]):
37         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
38         (WebKit::NetscapePluginInstanceProxy::getCookies):
39         (WebKit::NetscapePluginInstanceProxy::setCookies):
40         * Plugins/WebNetscapePluginView.mm:
41         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
42         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
43         * WebCoreSupport/WebPlatformStrategies.h:
44         * WebCoreSupport/WebPlatformStrategies.mm:
45         (WebPlatformStrategies::createCookiesStrategy): Deleted.
46         (WebPlatformStrategies::cookiesForDOM): Deleted.
47         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
48         (WebPlatformStrategies::cookiesEnabled): Deleted.
49         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
50         (WebPlatformStrategies::getRawCookies): Deleted.
51         (WebPlatformStrategies::deleteCookie): Deleted.
52         * WebView/WebView.mm:
53         (-[WebView _commonInitializationWithFrameName:groupName:]):
54         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
55
56 2019-01-15  Tim Horton  <timothy_horton@apple.com>
57
58         Cannot tab out of WKWebView on macOS
59         https://bugs.webkit.org/show_bug.cgi?id=161448
60         <rdar://problem/28100085>
61
62         Reviewed by Dean Jackson.
63
64         * WebCoreSupport/WebChromeClient.mm:
65         * WebView/WebView.mm:
66         Make use of SPI headers.
67
68 2019-01-14  Commit Queue  <commit-queue@webkit.org>
69
70         Unreviewed, rolling out r239901, r239909, r239910, r239912,
71         r239913, and r239914.
72         https://bugs.webkit.org/show_bug.cgi?id=193407
73
74         These revisions caused an internal failure (Requested by
75         Truitt on #webkit).
76
77         Reverted changesets:
78
79         "[Cocoa] Avoid importing directly from subumbrella frameworks"
80         https://bugs.webkit.org/show_bug.cgi?id=186016
81         https://trac.webkit.org/changeset/239901
82
83         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
84         https://trac.webkit.org/changeset/239909
85
86         "Tried to fix the build."
87         https://trac.webkit.org/changeset/239910
88
89         "Fixed iOS builds after r239910."
90         https://trac.webkit.org/changeset/239912
91
92         "More build fixing."
93         https://trac.webkit.org/changeset/239913
94
95         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
96         https://trac.webkit.org/changeset/239914
97
98 2019-01-14  Mark Lam  <mark.lam@apple.com>
99
100         Re-enable ability to build --cloop builds.
101         https://bugs.webkit.org/show_bug.cgi?id=192955
102         <rdar://problem/46882363>
103
104         Reviewed by Saam barati and Keith Miller.
105
106         * Configurations/FeatureDefines.xcconfig:
107
108 2019-01-13  Dan Bernstein  <mitz@apple.com>
109
110         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
111
112         Patch by Keith Rollin.
113
114         * WebView/PDFViewSPI.h:
115
116 2019-01-12  Timothy Hatcher  <timothy@apple.com>
117
118         Have prefers-color-scheme: light always match on macOS versions before Mojave.
119         https://bugs.webkit.org/show_bug.cgi?id=191655
120         rdar://problem/46074680
121
122         Reviewed by Megan Gardner.
123
124         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
125         * WebView/WebView.mm:
126         (-[WebView _effectiveAppearanceIsDark]):
127
128 2019-01-12  Dan Bernstein  <mitz@apple.com>
129
130         [Cocoa] Avoid importing directly from subumbrella frameworks
131         https://bugs.webkit.org/show_bug.cgi?id=186016
132         <rdar://problem/40591038>
133
134         Reviewed by Sam Weinig.
135
136         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
137         * Carbon/CarbonWindowAdapter.mm: Ditto.
138         * Carbon/CarbonWindowFrame.m: Ditto.
139         * Carbon/HIViewAdapter.h: Ditto.
140         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
141           OTHER_CFLAGS_COCOA_TOUCH_NO.
142         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
143         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
144         * WebView/WebPDFView.h: Ditto.
145
146 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
147
148         Enable visual viewport API by default
149         https://bugs.webkit.org/show_bug.cgi?id=193376
150
151         Reviewed by Simon Fraser.
152
153         * WebView/WebPreferences.mm:
154         (+[WebPreferences initialize]):
155
156 2019-01-11  John Wilander  <wilander@apple.com>
157
158         Compile out Web API Statistics Collection
159         https://bugs.webkit.org/show_bug.cgi?id=193370
160         <rdar://problem/45388584>
161
162         Reviewed by Brent Fulgham.
163
164         * Configurations/FeatureDefines.xcconfig:
165             Defined ENABLE_WEB_API_STATISTICS, off by default.
166
167 2019-01-08  Alex Christensen  <achristensen@webkit.org>
168
169         Stop using NetworkStorageSession in WebProcess
170         https://bugs.webkit.org/show_bug.cgi?id=193236
171
172         Reviewed by Don Olmstead.
173
174         * WebCoreSupport/WebFrameNetworkingContext.h:
175         * WebCoreSupport/WebFrameNetworkingContext.mm:
176         (WebFrameNetworkingContext::storageSession const):
177         * WebCoreSupport/WebPlatformStrategies.h:
178         * WebCoreSupport/WebPlatformStrategies.mm:
179         (WebPlatformStrategies::cookiesForDOM):
180         (WebPlatformStrategies::setCookiesFromDOM):
181         (WebPlatformStrategies::cookiesEnabled):
182         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
183         (WebPlatformStrategies::getRawCookies):
184         (WebPlatformStrategies::deleteCookie):
185         * WebView/WebView.mm:
186         (-[WebView _cachedResponseForURL:]):
187         (-[WebView _clearCredentials]):
188
189 2019-01-08  Alex Christensen  <achristensen@webkit.org>
190
191         Unreviewed, rolling out r239727.
192
193         Broke API tests
194
195         Reverted changeset:
196
197         "Stop using NetworkStorageSession in WebProcess"
198         https://bugs.webkit.org/show_bug.cgi?id=193236
199         https://trac.webkit.org/changeset/239727
200
201 2019-01-08  Alex Christensen  <achristensen@webkit.org>
202
203         Stop using NetworkStorageSession in WebProcess
204         https://bugs.webkit.org/show_bug.cgi?id=193236
205
206         Reviewed by Don Olmstead.
207
208         * WebCoreSupport/WebFrameNetworkingContext.h:
209         * WebCoreSupport/WebFrameNetworkingContext.mm:
210         (WebFrameNetworkingContext::storageSession const):
211         * WebView/WebView.mm:
212         (-[WebView _cachedResponseForURL:]):
213         (-[WebView _clearCredentials]):
214
215 2019-01-07  David Kilzer  <ddkilzer@apple.com>
216
217         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
218         <https://webkit.org/b/193056>
219
220         Reviewed by Alex Christensen.
221
222         * Plugins/Hosted/NetscapePluginHostProxy.h:
223         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
224         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
225         (WebKit::NetscapePluginInstanceProxy::enumerate):
226         (WebKit::NetscapePluginInstanceProxy::marshalValue):
227         (WebKit::NetscapePluginInstanceProxy::marshalValues):
228         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
229         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
230         * Plugins/Hosted/ProxyInstance.mm:
231         (WebKit::ProxyInstance::invoke):
232         * WebCoreSupport/WebGeolocationClient.mm:
233         * WebView/WebDataSource.mm:
234         (-[WebDataSource _receivedData:]):
235         * WebView/WebView.mm:
236         (-[WebView _cachedResponseForURL:]):
237         - Remove '*' from RetainPtr<> type.
238
239 2019-01-04  Alex Christensen  <achristensen@webkit.org>
240
241         Progress towards fixing Mac CMake build
242         https://bugs.webkit.org/show_bug.cgi?id=193105
243
244         Reviewed by Don Olmstead.
245
246         * WebKitPrefix.h:
247
248 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
249
250         Web Inspector: Use save sheet instead of dialog where possible
251         https://bugs.webkit.org/show_bug.cgi?id=193160
252         <rdar://problem/37399759>
253
254         Reviewed by Devin Rousso.
255
256         * WebCoreSupport/WebInspectorClient.mm:
257         (WebInspectorFrontendClient::save):
258
259 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
260
261         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
262         https://bugs.webkit.org/show_bug.cgi?id=193129
263
264         Reviewed by Tim Horton.
265
266         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
267
268         * WebCoreSupport/WebEditorClient.mm:
269         (WebEditorClient::registerUndoOrRedoStep):
270         (undoNameForEditAction): Deleted.
271
272 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
273
274         Add support for using the current text selection as the find string on iOS
275         https://bugs.webkit.org/show_bug.cgi?id=193034
276         <rdar://problem/45138739>
277
278         Reviewed by Tim Horton.
279
280         Add a method stub for WebKitLegacy.
281
282         * WebCoreSupport/WebEditorClient.h:
283
284 2019-01-01  Jeff Miller  <jeffm@apple.com>
285
286         Update user-visible copyright strings to include 2019
287         https://bugs.webkit.org/show_bug.cgi?id=192811
288
289         Reviewed by Mark Lam.
290
291         * Info.plist:
292
293 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
294
295         Use Ref<> as much as possible
296         https://bugs.webkit.org/show_bug.cgi?id=192808
297
298         Reviewed by Alex Christensen.
299
300         * DOM/DOM.mm:
301         (-[DOMNode getPreviewSnapshotImage:andRects:]):
302         * Plugins/Hosted/NetscapePluginHostManager.mm:
303         (WebKit::NetscapePluginHostManager::instantiatePlugin):
304         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
305         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
306         (WebKit::NetscapePluginInstanceProxy::loadRequest):
307         * Plugins/WebNetscapePluginView.mm:
308         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
309         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
310         * WebCoreSupport/WebContextMenuClient.mm:
311         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
312         * WebCoreSupport/WebFrameLoaderClient.mm:
313         (WebFrameLoaderClient::transitionToCommittedForNewPage):
314         * WebView/WebFrame.mm:
315         (-[WebFrame getDictationResultRanges:andMetadatas:]):
316         * WebView/WebHTMLView.mm:
317         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
318         * WebView/WebView.mm:
319         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
320         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
321
322 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
323
324         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
325         https://bugs.webkit.org/show_bug.cgi?id=192821
326
327         Reviewed by Chris Dumez.
328
329         When a window becomes occluded, the window server informs the application.
330         This should be used to suspend any work that is not visible by the user.
331
332         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
333         In some cases, that lead to performance impact (see radar).
334
335         This patch adds an observer for the occlusion notification. I tried to stick
336         with the same names used by WebKit2.
337
338         * WebView/WebView.mm:
339         (-[WebView _isViewVisible]):
340         (-[WebView addWindowObserversForWindow:]):
341         (-[WebView removeWindowObservers]):
342         (-[WebView _windowDidChangeOcclusionState:]):
343
344 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
345
346         [WebAuthN] Add a runtime flag for local authenticator
347         https://bugs.webkit.org/show_bug.cgi?id=192792
348         <rdar://problem/46798738>
349
350         Reviewed by Brent Fulgham.
351
352         * WebView/WebPreferenceKeysPrivate.h:
353         * WebView/WebPreferences.mm:
354         (+[WebPreferences initialize]):
355         (-[WebPreferences webAuthenticationEnabled]): Deleted.
356         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
357         * WebView/WebPreferencesPrivate.h:
358         * WebView/WebView.mm:
359         (-[WebView _preferencesChanged:]):
360
361 2018-12-20  Chris Dumez  <cdumez@apple.com>
362
363         Use Optional::valueOr() instead of Optional::value_or()
364         https://bugs.webkit.org/show_bug.cgi?id=192933
365
366         Reviewed by Geoffrey Garen.
367
368         * WebCoreSupport/WebSecurityOrigin.mm:
369         (-[WebSecurityOrigin port]):
370
371 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
372
373         Unreviewed, rolling out r239417.
374
375         Introduced two API test failures on macOS.
376
377         Reverted changeset:
378
379         "<rdar://problem/46194315> macOS: WebKit1 does not handle
380         occlusion changes"
381         https://bugs.webkit.org/show_bug.cgi?id=192821
382         https://trac.webkit.org/changeset/239417
383
384 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
385
386         WKWebView default UA doesn't freeze the build number
387         https://bugs.webkit.org/show_bug.cgi?id=192809
388         <rdar://problem/44687185>
389
390         Reviewed by Andy Estes.
391
392         Always reports the frozen build number.
393
394         * WebView/WebView.mm:
395         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
396         actual build number through this method call.
397         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
398
399 2018-12-19  Chris Dumez  <cdumez@apple.com>
400
401         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
402         https://bugs.webkit.org/show_bug.cgi?id=192728
403         <rdar://problem/46746779>
404
405         Reviewed by Geoff Garen.
406
407         * DOM/*:
408         * Plugins/*:
409         * WebCoreSupport/*:
410         * WebView/*:
411
412 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
413
414         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
415         https://bugs.webkit.org/show_bug.cgi?id=192821
416
417         Reviewed by Chris Dumez.
418
419         When a window becomes occluded, the window server informs the application.
420         This should be used to suspend any work that is not visible by the user.
421
422         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
423         In some cases, that lead to performance impact (see radar).
424
425         This patch adds an observer for the occlusion notification. I tried to stick
426         with the same names used by WebKit2.
427
428         * WebView/WebView.mm:
429         (-[WebView _isViewVisible]):
430         (-[WebView addWindowObserversForWindow:]):
431         (-[WebView removeWindowObservers]):
432         (-[WebView _windowDidChangeOcclusionState:]):
433
434 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
435
436         Allow clients to set the navigator platform
437         https://bugs.webkit.org/show_bug.cgi?id=192735
438
439         Reviewed by Tim Horton.
440
441         Add stubs to fill out the added functionality in FrameLoaderClient.
442
443         * WebCoreSupport/WebFrameLoaderClient.h:
444         * WebCoreSupport/WebFrameLoaderClient.mm:
445         (WebFrameLoaderClient::navigatorPlatform):
446
447 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
448
449         offsetLeft and offsetParent should adjust across shadow boundaries
450         https://bugs.webkit.org/show_bug.cgi?id=157437
451         <rdar://problem/26154021>
452
453         Reviewed by Simon Fraser.
454
455         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
456
457         * DOM/DOMElement.mm:
458         (-[DOMElement offsetLeft]):
459         (-[DOMElement offsetTop]):
460         (-[DOMElement offsetParent]):
461
462 2018-12-17  Zalan Bujtas  <zalan@apple.com>
463
464         Unreviewed build fix.
465
466         * WebView/WebFrame.mm:
467         (-[WebFrame getDictationResultRanges:andMetadatas:]):
468
469 2018-12-15  Darin Adler  <darin@apple.com>
470
471         Use warning-ignoring macros more consistently and simply
472         https://bugs.webkit.org/show_bug.cgi?id=192743
473
474         Reviewed by Mark Lam.
475
476         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
477         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
478         compilers in Objective-C++ code.
479
480         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
481         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
482         accomodate non-clang compilers here. Also use #pragma once, add a missing
483         "explicit" and fix conditionals.
484
485 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
486
487         Make TextInputController.legacyAttributedString take DOM nodes and offsets
488         https://bugs.webkit.org/show_bug.cgi?id=192653
489
490         Reviewed by Wenson Hsieh.
491
492         * WebView/WebHTMLView.mm:
493         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
494
495 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
496
497         Implement feature flag for CSS Typed OM
498         https://bugs.webkit.org/show_bug.cgi?id=192610
499
500         Reviewed by Ryosuke Niwa.
501
502         * Configurations/FeatureDefines.xcconfig:
503
504 2018-12-11  Tim Horton  <timothy_horton@apple.com>
505
506         WebCore shouldn't have a Objective-C class named NSCursor
507         https://bugs.webkit.org/show_bug.cgi?id=192602
508         <rdar://problem/46615532>
509
510         Reviewed by Wenson Hsieh.
511
512         * WebView/WebFrameView.mm:
513         (-[WebFrameView keyDown:keyDown:]):
514         * WebView/WebHTMLView.mm:
515         (-[WebHTMLView keyDown:]):
516         (-[WebHTMLView performKeyEquivalent:]):
517         Only use NSCursor on macOS.
518
519 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
520
521         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
522         https://bugs.webkit.org/show_bug.cgi?id=192573
523
524         Reviewed by Simon Fraser.
525
526         * Configurations/FeatureDefines.xcconfig:
527
528 2018-12-10  Antti Koivisto  <antti@apple.com>
529
530         Rename "forced style recalc" to "full style rebuild"
531         https://bugs.webkit.org/show_bug.cgi?id=192572
532
533         Reviewed by Zalan Bujtas.
534
535         * WebView/WebHTMLView.mm:
536         (-[WebHTMLView setNeedsToApplyStyles:]):
537
538 2018-12-10  Darin Adler  <darin@apple.com>
539
540         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
541         https://bugs.webkit.org/show_bug.cgi?id=192533
542         rdar://problem/45732710
543
544         Reviewed by Anders Carlsson.
545
546         * Plugins/Hosted/NetscapePluginHostProxy.mm:
547         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
548
549 2018-12-10  Darin Adler  <darin@apple.com>
550
551         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
552         https://bugs.webkit.org/show_bug.cgi?id=192532
553         rdar://problem/45731047
554
555         Reviewed by Chris Dumez.
556
557         * Plugins/Hosted/NetscapePluginHostManager.mm:
558         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
559         * Plugins/Hosted/NetscapePluginHostProxy.mm:
560         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
561
562 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
563
564         Turn WritingDirection into an enum class
565         https://bugs.webkit.org/show_bug.cgi?id=192401
566         Work towards <rdar://problem/42075638>
567
568         Reviewed by Dan Bernstein.
569
570         Change WritingDirection from an enum to an enum class. No change in behavior.
571
572         * WebView/WebHTMLView.mm:
573         (-[WebHTMLView toggleBaseWritingDirection:]):
574         (-[WebHTMLView changeBaseWritingDirection:]):
575         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
576
577 2018-12-03  Alex Christensen  <achristensen@webkit.org>
578
579         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
580         https://bugs.webkit.org/show_bug.cgi?id=192272
581
582         Reviewed by Brady Eidson.
583
584         * WebCoreSupport/WebFrameLoaderClient.h:
585         * WebCoreSupport/WebFrameLoaderClient.mm:
586         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
587
588 2018-12-03  Jer Noble  <jer.noble@apple.com>
589
590         Get rid of old, dead Mac video fullscreen code.
591         https://bugs.webkit.org/show_bug.cgi?id=192315
592
593         Reviewed by Eric Carlson.
594
595         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
596         is no longer supported in the Mac port.
597
598         * WebView/WebVideoFullscreenController.h: Removed.
599         * WebView/WebVideoFullscreenController.mm: Removed.
600         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
601         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
602         * WebView/WebView.mm:
603         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
604         (-[WebView _exitVideoFullscreen]):
605
606 2018-12-03  Daniel Bates  <dabates@apple.com>
607
608         [iOS] Do not handle key events that are key commands
609         https://bugs.webkit.org/show_bug.cgi?id=191608
610         <rdar://problem/46046013>
611
612         Reviewed by Ryosuke Niwa.
613
614         A key down event may be associated with a key command. If it is then we want to execute the
615         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
616         event as a key command to find out.
617
618         * WebView/WebHTMLView.mm:
619         (-[WebHTMLView _handleEditingKeyEvent:]):
620
621 2018-12-02  Zalan Bujtas  <zalan@apple.com>
622
623         Add a runtime feature flag for LayoutFormattingContext.
624         https://bugs.webkit.org/show_bug.cgi?id=192280
625
626         Reviewed by Simon Fraser.
627
628         * Configurations/FeatureDefines.xcconfig:
629
630 2018-11-30  Alex Christensen  <achristensen@webkit.org>
631
632         Move URL from WebCore to WTF
633         https://bugs.webkit.org/show_bug.cgi?id=190234
634
635         Reviewed by Keith Miller.
636
637         * DOM/DOMAttr.mm:
638         * DOM/DOMBlob.mm:
639         * DOM/DOMCSSCharsetRule.mm:
640         * DOM/DOMCSSImportRule.mm:
641         * DOM/DOMCSSMediaRule.mm:
642         * DOM/DOMCSSPageRule.mm:
643         * DOM/DOMCSSPrimitiveValue.mm:
644         * DOM/DOMCSSRule.mm:
645         * DOM/DOMCSSStyleDeclaration.mm:
646         * DOM/DOMCSSStyleRule.mm:
647         * DOM/DOMCSSStyleSheet.mm:
648         * DOM/DOMCSSValue.mm:
649         * DOM/DOMCharacterData.mm:
650         * DOM/DOMCounter.mm:
651         * DOM/DOMDocument.mm:
652         * DOM/DOMDocumentFragment.mm:
653         * DOM/DOMDocumentType.mm:
654         * DOM/DOMEvent.mm:
655         * DOM/DOMFile.mm:
656         * DOM/DOMHTMLAnchorElement.mm:
657         * DOM/DOMHTMLAppletElement.mm:
658         * DOM/DOMHTMLAreaElement.mm:
659         * DOM/DOMHTMLBRElement.mm:
660         * DOM/DOMHTMLBaseElement.mm:
661         * DOM/DOMHTMLBaseFontElement.mm:
662         * DOM/DOMHTMLBodyElement.mm:
663         * DOM/DOMHTMLButtonElement.mm:
664         * DOM/DOMHTMLCanvasElement.mm:
665         * DOM/DOMHTMLCollection.mm:
666         * DOM/DOMHTMLDivElement.mm:
667         * DOM/DOMHTMLDocument.mm:
668         * DOM/DOMHTMLElement.mm:
669         * DOM/DOMHTMLEmbedElement.mm:
670         * DOM/DOMHTMLFieldSetElement.mm:
671         * DOM/DOMHTMLFontElement.mm:
672         * DOM/DOMHTMLFormElement.mm:
673         * DOM/DOMHTMLFrameElement.mm:
674         * DOM/DOMHTMLFrameSetElement.mm:
675         * DOM/DOMHTMLHRElement.mm:
676         * DOM/DOMHTMLHeadElement.mm:
677         * DOM/DOMHTMLHeadingElement.mm:
678         * DOM/DOMHTMLHtmlElement.mm:
679         * DOM/DOMHTMLIFrameElement.mm:
680         * DOM/DOMHTMLImageElement.mm:
681         * DOM/DOMHTMLInputElement.mm:
682         * DOM/DOMHTMLLIElement.mm:
683         * DOM/DOMHTMLLabelElement.mm:
684         * DOM/DOMHTMLLegendElement.mm:
685         * DOM/DOMHTMLLinkElement.mm:
686         * DOM/DOMHTMLMapElement.mm:
687         * DOM/DOMHTMLMarqueeElement.mm:
688         * DOM/DOMHTMLMediaElement.mm:
689         * DOM/DOMHTMLMetaElement.mm:
690         * DOM/DOMHTMLModElement.mm:
691         * DOM/DOMHTMLOListElement.mm:
692         * DOM/DOMHTMLObjectElement.mm:
693         * DOM/DOMHTMLOptGroupElement.mm:
694         * DOM/DOMHTMLOptionElement.mm:
695         * DOM/DOMHTMLOptionsCollection.mm:
696         * DOM/DOMHTMLParagraphElement.mm:
697         * DOM/DOMHTMLParamElement.mm:
698         * DOM/DOMHTMLQuoteElement.mm:
699         * DOM/DOMHTMLScriptElement.mm:
700         * DOM/DOMHTMLSelectElement.mm:
701         * DOM/DOMHTMLStyleElement.mm:
702         * DOM/DOMHTMLTableCaptionElement.mm:
703         * DOM/DOMHTMLTableCellElement.mm:
704         * DOM/DOMHTMLTableColElement.mm:
705         * DOM/DOMHTMLTableElement.mm:
706         * DOM/DOMHTMLTableRowElement.mm:
707         * DOM/DOMHTMLTableSectionElement.mm:
708         * DOM/DOMHTMLTitleElement.mm:
709         * DOM/DOMHTMLUListElement.mm:
710         * DOM/DOMHTMLVideoElement.mm:
711         * DOM/DOMKeyboardEvent.mm:
712         * DOM/DOMMediaList.mm:
713         * DOM/DOMMouseEvent.mm:
714         * DOM/DOMMutationEvent.mm:
715         * DOM/DOMNamedNodeMap.mm:
716         * DOM/DOMProcessingInstruction.mm:
717         * DOM/DOMRange.mm:
718         * DOM/DOMStyleSheet.mm:
719         * DOM/DOMText.mm:
720         * DOM/DOMTextEvent.mm:
721         * DOM/DOMTokenList.mm:
722         * DOM/DOMUIEvent.mm:
723         * DOM/DOMXPathResult.mm:
724         * History/WebHistoryItem.mm:
725         * Misc/WebNSURLExtras.mm:
726         (-[NSURL _web_userVisibleString]):
727         (-[NSURL _web_URLByRemovingUserInfo]):
728         (-[NSURL _web_dataForURLComponentType:]):
729         (-[NSURL _web_schemeData]):
730         (-[NSURL _web_hostData]):
731         * Misc/WebUserContentURLPattern.mm:
732         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
733         * Plugins/WebNetscapePluginStream.h:
734         (WebNetscapePluginStream::setRequestURL):
735         * WebCoreSupport/WebChromeClient.h:
736         * WebCoreSupport/WebChromeClient.mm:
737         (WebChromeClient::signedPublicKeyAndChallengeString const):
738         * WebCoreSupport/WebContextMenuClient.h:
739         * WebCoreSupport/WebContextMenuClient.mm:
740         * WebCoreSupport/WebDragClient.h:
741         * WebCoreSupport/WebFrameLoaderClient.h:
742         * WebCoreSupport/WebFrameLoaderClient.mm:
743         (WebFrameLoaderClient::updateGlobalHistory):
744         * WebCoreSupport/WebPaymentCoordinatorClient.h:
745         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
746         (WebPaymentCoordinatorClient::showPaymentUI):
747         * WebCoreSupport/WebPlatformStrategies.h:
748         * WebCoreSupport/WebPlatformStrategies.mm:
749         (WebPlatformStrategies::readURLFromPasteboard):
750         * WebCoreSupport/WebPluginInfoProvider.h:
751         * WebCoreSupport/WebPluginInfoProvider.mm:
752         (WebPluginInfoProvider::webVisiblePluginInfo):
753         * WebCoreSupport/WebSecurityOrigin.mm:
754         * WebCoreSupport/WebVisitedLinkStore.h:
755         * WebView/WebDataSource.mm:
756         * WebView/WebFrame.mm:
757         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
758         * WebView/WebImmediateActionController.mm:
759         (-[WebImmediateActionController _defaultAnimationController]):
760         * WebView/WebPDFView.mm:
761         * WebView/WebScriptDebugger.mm:
762         * WebView/WebViewInternal.h:
763
764 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
765
766         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
767         https://bugs.webkit.org/show_bug.cgi?id=192197
768
769         Reviewed by Jiewen Tan.
770
771         * Configurations/FeatureDefines.xcconfig:
772         * WebCoreSupport/WebChromeClient.h:
773         * WebCoreSupport/WebChromeClient.mm:
774
775 2018-11-28  Alex Christensen  <achristensen@webkit.org>
776
777         Remove dead code from an earlier attempt at implementing safe browsing
778         https://bugs.webkit.org/show_bug.cgi?id=192067
779
780         Reviewed by Chris Dumez.
781
782         * WebCoreSupport/WebFrameLoaderClient.h:
783         * WebCoreSupport/WebFrameLoaderClient.mm:
784         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
785
786 2018-11-27  Mark Lam  <mark.lam@apple.com>
787
788         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
789         https://bugs.webkit.org/show_bug.cgi?id=192055
790         <rdar://problem/46288783>
791
792         Reviewed by Saam Barati.
793
794         * Configurations/FeatureDefines.xcconfig:
795
796 2018-11-25  Tim Horton  <timothy_horton@apple.com>
797
798         Make it possible to insert editable images with a gesture
799         https://bugs.webkit.org/show_bug.cgi?id=191937
800
801         Reviewed by Wenson Hsieh.
802
803         * WebCoreSupport/WebEditorClient.mm:
804         (undoNameForEditAction):
805         Add a undo name.
806
807 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
808
809         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
810         https://bugs.webkit.org/show_bug.cgi?id=191945
811
812         Reviewed by Anders Carlsson.
813
814         * WebCoreSupport/WebEditorClient.mm:
815         (undoNameForEditAction):
816
817 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
818
819         Enable drag and drop support for iOSMac
820         https://bugs.webkit.org/show_bug.cgi?id=191818
821         <rdar://problem/43907454>
822
823         Reviewed by Dean Jackson.
824
825         * Configurations/FeatureDefines.xcconfig:
826
827 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
828
829         Address post-review feedback after r238438
830         https://bugs.webkit.org/show_bug.cgi?id=191913
831
832         Reviewed by Ryosuke Niwa.
833
834         * WebView/WebFrame.mm:
835         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
836         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
837         * WebView/WebView.mm:
838         (-[WebView setSelectedDOMRange:affinity:]):
839
840 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
841
842         Web Inspector: "Reload Web Inspector" button no longer partially works
843         https://bugs.webkit.org/show_bug.cgi?id=191773
844         <rdar://problem/46139932>
845
846         Reviewed by Devin Rousso.
847
848         * WebCoreSupport/WebInspectorClient.h:
849         * WebCoreSupport/WebInspectorClient.mm:
850         (WebInspectorFrontendClient::reopen):
851
852 2018-11-17  Devin Rousso  <drousso@apple.com>
853
854         Web Inspector: Network: add button to show system certificate dialog
855         https://bugs.webkit.org/show_bug.cgi?id=191458
856         <rdar://problem/45977019>
857
858         Reviewed by Joseph Pecoraro.
859
860         * WebCoreSupport/WebInspectorClient.h:
861         * WebCoreSupport/WebInspectorClient.mm:
862         (WebInspectorFrontendClient::showCertificate): Added.
863
864         * Configurations/WebKitLegacy.xcconfig:
865
866 2018-11-15  Truitt Savell  <tsavell@apple.com>
867
868         Unreviewed, rolling out r238244.
869
870         Caused High Sierra test runs to fail early with 50 crashes and
871         casued 25 API failures.
872
873         Reverted changeset:
874
875         "[css-logical] Implement flow-relative margin, padding and
876         border shorthands"
877         https://bugs.webkit.org/show_bug.cgi?id=188697
878         https://trac.webkit.org/changeset/238244
879
880 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
881
882         [css-logical] Implement flow-relative margin, padding and border shorthands
883         https://bugs.webkit.org/show_bug.cgi?id=188697
884
885         Reviewed by Simon Fraser and Antti Koivisto.
886
887         Add CSSLogicalEnabled runtime flag.
888
889         * WebView/WebPreferenceKeysPrivate.h:
890         * WebView/WebPreferences.mm:
891         (+[WebPreferences initialize]):
892         (-[WebPreferences cssLogicalEnabled]):
893         (-[WebPreferences setCSSLogicalEnabled:]):
894         * WebView/WebPreferencesPrivate.h:
895         * WebView/WebView.mm:
896         (-[WebView _preferencesChanged:]):
897
898 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
899
900         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
901         https://bugs.webkit.org/show_bug.cgi?id=191612
902
903         Reviewed by Matt Baker.
904
905         * WebCoreSupport/WebInspectorClient.mm:
906         (-[WebInspectorWindowController destroyInspectorView]):
907
908 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
909
910         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
911         https://bugs.webkit.org/show_bug.cgi?id=191494
912         <rdar://problem/45469854>
913
914         Reviewed by Devin Rousso.
915
916         * WebCoreSupport/WebInspectorClient.h:
917         WebKitLegacy will still have remote inspection of the Page directly.
918
919 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
920
921         Make compositing updates incremental
922         https://bugs.webkit.org/show_bug.cgi?id=90342
923
924         Reviewed by Antti Koivisto.
925
926         Fix spelling error.
927
928         * WebView/WebView.mm:
929         (-[WebView _setMediaLayer:forPluginView:]):
930
931 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
932
933         Implement a new edit command to change the enclosing list type
934         https://bugs.webkit.org/show_bug.cgi?id=191487
935         <rdar://problem/45955922>
936
937         Reviewed by Ryosuke Niwa.
938
939         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
940
941         * WebCoreSupport/WebEditorClient.mm:
942         (undoNameForEditAction):
943
944 2018-11-11  Daniel Bates  <dabates@apple.com>
945
946         [iOS] Draw caps lock indicator in password fields
947         https://bugs.webkit.org/show_bug.cgi?id=190565
948         <rdar://problem/45262343>
949
950         Reviewed by Dean Jackson.
951
952         Update the caps lock state when a hardware keyboard is attached or detached.
953
954         * WebView/WebHTMLView.mm:
955         (hardwareKeyboardAvailabilityChangedCallback): Added.
956         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
957         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
958
959 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
960
961         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
962         https://bugs.webkit.org/show_bug.cgi?id=191492
963
964         Reviewed by Alex Christensen.
965
966         * Carbon/HIWebView.mm:
967         * Misc/WebNSFileManagerExtras.mm:
968         * Misc/WebNSURLExtras.mm:
969         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
970         * Plugins/WebBasePluginPackage.mm:
971         * Plugins/WebPluginContainerCheck.mm:
972         * WebCoreSupport/WebCachedFramePlatformData.h:
973         * WebCoreSupport/WebDeviceOrientationClient.mm:
974         * WebView/WebDelegateImplementationCaching.mm:
975         * WebView/WebHTMLView.mm:
976         * WebView/WebPDFRepresentation.mm:
977         * WebView/WebPolicyDelegate.mm:
978         * WebView/WebView.mm:
979
980 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
981
982         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
983         https://bugs.webkit.org/show_bug.cgi?id=191492
984
985         Reviewed by Alex Christensen.
986
987         * Carbon/HIWebView.mm:
988         (UpdateCommandStatus):
989         * Misc/WebNSFileManagerExtras.mm:
990         * Misc/WebNSURLExtras.mm:
991         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
992         * Plugins/WebBasePluginPackage.mm:
993         * Plugins/WebPluginContainerCheck.mm:
994         (-[WebPluginContainerCheck _continueWithPolicy:]):
995         * WebCoreSupport/WebCachedFramePlatformData.h:
996         (WebCachedFramePlatformData::clear):
997         * WebCoreSupport/WebDeviceOrientationClient.mm:
998         (WebDeviceOrientationClient::getProvider const):
999         * WebView/WebDelegateImplementationCaching.mm:
1000         (CallDelegate):
1001         (CallDelegateReturningBoolean):
1002         (CallResourceLoadDelegateReturningBoolean):
1003         (CallFormDelegate):
1004         (CallFormDelegateReturningBoolean):
1005         * WebView/WebHTMLView.mm:
1006         * WebView/WebPDFRepresentation.mm:
1007         * WebView/WebPolicyDelegate.mm:
1008         (-[WebPolicyDecisionListener _usePolicy:]):
1009         * WebView/WebView.mm:
1010
1011 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1012
1013         Unreviewed, rolling out r238047.
1014
1015         Introduced layout test failures on iOS simulator.
1016
1017         Reverted changeset:
1018
1019         "[iOS] Draw caps lock indicator in password fields"
1020         https://bugs.webkit.org/show_bug.cgi?id=190565
1021         https://trac.webkit.org/changeset/238047
1022
1023 2018-11-09  Antti Koivisto  <antti@apple.com>
1024
1025         Use OptionSet for layout milestones
1026         https://bugs.webkit.org/show_bug.cgi?id=191470
1027
1028         Reviewed by Dean Jackson.
1029
1030         * WebCoreSupport/WebFrameLoaderClient.h:
1031         * WebCoreSupport/WebFrameLoaderClient.mm:
1032         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1033         * WebView/WebView.mm:
1034         (coreLayoutMilestones):
1035         (kitLayoutMilestones):
1036         (-[WebView _cacheFrameLoadDelegateImplementations]):
1037         * WebView/WebViewInternal.h:
1038
1039 2018-11-09  Daniel Bates  <dabates@apple.com>
1040
1041         [iOS] Draw caps lock indicator in password fields
1042         https://bugs.webkit.org/show_bug.cgi?id=190565
1043         <rdar://problem/45262343>
1044
1045         Reviewed by Dean Jackson.
1046
1047         Update the caps lock state when a hardware keyboard is attached or detached.
1048
1049         * WebView/WebHTMLView.mm:
1050         (hardwareKeyboardAvailabilityChangedCallback): Added.
1051         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1052         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1053
1054 2018-11-09  Daniel Bates  <dabates@apple.com>
1055
1056         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1057         action when forward delete is pressed outside a text field
1058         https://bugs.webkit.org/show_bug.cgi?id=190566
1059         <rdar://problem/45262367>
1060
1061         Reviewed by Wenson Hsieh.
1062
1063         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1064         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1065         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1066
1067         * WebView/WebHTMLView.mm:
1068         (-[WebHTMLView _handleEditingKeyEvent:]):
1069
1070 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1071
1072         Adopt Reveal Framework to replace Lookup
1073         https://bugs.webkit.org/show_bug.cgi?id=191097
1074         <rdar://problem/45924508>
1075
1076         Reviewed by Tim Horton.
1077
1078         Pass in what it needed to clear the textIndicators. This is better than
1079         the current notification structure.
1080
1081         * WebView/WebView.mm:
1082         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1083         (-[WebView _prepareForDictionaryLookup]):
1084
1085 2018-11-06  Justin Fan  <justin_fan@apple.com>
1086
1087         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1088         https://bugs.webkit.org/show_bug.cgi?id=191291
1089
1090         Reviewed by Myles Maxfield.
1091
1092         Properly disable WEBGPU on all non-Metal platforms for now.
1093
1094         * Configurations/FeatureDefines.xcconfig:
1095
1096 2018-11-02  Daniel Bates  <dabates@apple.com>
1097
1098         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1099         https://bugs.webkit.org/show_bug.cgi?id=190487
1100
1101         Reviewed by Tim Horton.
1102
1103         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1104         allow the default handling.
1105
1106         * WebView/WebHTMLView.mm:
1107         (-[WebHTMLView _handleEditingKeyEvent:]):
1108
1109 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1110
1111         Add a storage limit for IndexedDB
1112         https://bugs.webkit.org/show_bug.cgi?id=190598
1113         <rdar://problem/44654715>
1114
1115         Reviewed by Chris Dumez.
1116
1117         * Storage/WebDatabaseManager.mm:
1118         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1119         * Storage/WebDatabaseManagerPrivate.h:
1120
1121 2018-10-31  Antti Koivisto  <antti@apple.com>
1122
1123         Remove LayerFlushScheduler
1124         https://bugs.webkit.org/show_bug.cgi?id=191103
1125
1126         Reviewed by Anders Carlsson.
1127
1128         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1129         all the virtual cruft.
1130
1131         * WebView/WebViewData.h:
1132         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1133         (): Deleted.
1134         * WebView/WebViewData.mm:
1135         (currentRunLoop):
1136         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1137         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1138         (WebViewLayerFlushScheduler::schedule):
1139         (WebViewLayerFlushScheduler::invalidate):
1140         (WebViewLayerFlushScheduler::layerFlushCallback):
1141
1142 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1143
1144         Enable InstallAPI for iOS unconditionally
1145         https://bugs.webkit.org/show_bug.cgi?id=191043
1146         rdar://problem/32728423
1147
1148         Reviewed by Dan Bernstein.
1149
1150         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1151         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1152         shouldn't be processed by InstallAPI.
1153         * MigrateHeaders.make: Removed an obsolete workaround.
1154         * Misc/NSURLDownloadSPI.h: Added.
1155         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1156
1157 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1158
1159         Clean up some obsolete MAX_ALLOWED macros
1160         https://bugs.webkit.org/show_bug.cgi?id=190916
1161
1162         Reviewed by Tim Horton.
1163
1164         * WebView/WebHTMLView.mm:
1165         (-[WebHTMLView pressureChangeWithEvent:]):
1166         * WebView/WebPDFView.h:
1167
1168 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1169
1170         Unreviewed, rolling out r237600 and r237604.
1171         https://bugs.webkit.org/show_bug.cgi?id=191086
1172
1173         Breaks internal iOS builds (Requested by ryanhadd_ on
1174         #webkit).
1175
1176         Reverted changesets:
1177
1178         "Enable InstallAPI for iOS unconditionally"
1179         https://bugs.webkit.org/show_bug.cgi?id=191043
1180         https://trac.webkit.org/changeset/237600
1181
1182         "Build fix attempt after enabling InstallAPI for iOS."
1183         https://bugs.webkit.org/show_bug.cgi?id=191043
1184         https://trac.webkit.org/changeset/237604
1185
1186 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1187
1188         Enable InstallAPI for iOS unconditionally
1189         https://bugs.webkit.org/show_bug.cgi?id=191043
1190         rdar://problem/32728423
1191
1192         Reviewed by Dan Bernstein.
1193
1194         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1195         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1196         shouldn't be processed by InstallAPI.
1197         * MigrateHeaders.make: Removed an obsolete workaround.
1198         * Misc/NSURLDownloadSPI.h: Added.
1199         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1200
1201 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1202
1203         Modernize WebKit nibs and lprojs for localization's sake
1204         https://bugs.webkit.org/show_bug.cgi?id=190911
1205         <rdar://problem/45349466>
1206
1207         Reviewed by Dan Bernstein.
1208
1209         * Misc/WebNSControlExtras.m:
1210         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1211         NSWindow and its contents are both in the same scale space these days; avoid
1212         double-applying the scale factor, or you can't see the prompt.
1213
1214         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1215         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1216         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1217         NIB->XIB
1218
1219 2018-10-25  Antoine Quint  <graouts@apple.com>
1220
1221         [Web Animations] Turn Web Animations CSS Integration off by default
1222         https://bugs.webkit.org/show_bug.cgi?id=190901
1223
1224         Reviewed by Dean Jackson.
1225
1226         * WebView/WebPreferences.mm:
1227         (+[WebPreferences initialize]):
1228
1229 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1230
1231         Clean up some obsolete macOS version guards
1232         https://bugs.webkit.org/show_bug.cgi?id=190887
1233
1234         Reviewed by Dan Bernstein.
1235
1236         * Misc/WebNSPasteboardExtras.mm:
1237         (+[NSPasteboard _web_dragTypesForURL]):
1238         * WebCoreSupport/PopupMenuMac.mm:
1239         (PopupMenuMac::show):
1240         * WebCoreSupport/WebEditorClient.h:
1241         * WebCoreSupport/WebEditorClient.mm:
1242         (WebEditorClient::respondToChangedSelection):
1243         * WebView/WebPDFView.mm:
1244         (-[WebPDFView _clipViewForPDFDocumentView]):
1245
1246 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1247
1248         Turn on Conic Gradients
1249         https://bugs.webkit.org/show_bug.cgi?id=190810
1250
1251         Reviewed by Tim Horton.
1252
1253         * Configurations/FeatureDefines.xcconfig:
1254
1255 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1256
1257         Cleanup: MIMETypeRegistry functions
1258         https://bugs.webkit.org/show_bug.cgi?id=190838
1259
1260         Reviewed by Simon Fraser.
1261
1262         * Misc/WebNSPasteboardExtras.mm:
1263         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1264         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1265         because they were identical.
1266
1267         * WebView/WebHTMLRepresentation.mm:
1268         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1269         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1270         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1271         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1272         * WebView/WebView.mm:
1273         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1274         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1275         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1276
1277 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1278
1279         Fix false positive leaks when using custom -init methods that don't start with -init
1280         <https://webkit.org/b/190818>
1281         <rdar://problem/45476042>
1282
1283         Reviewed by Dan Bernstein.
1284
1285         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1286         it is accessible by both categories.
1287         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1288         NSError (WebKitInternal) category.  Add attribute to make this
1289         behave like an -init method.
1290         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1291         NSError (WebKitInternal) category.  Modernize method.  Replace
1292         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1293
1294 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1295
1296         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1297         https://bugs.webkit.org/show_bug.cgi?id=190729
1298
1299         Reviewed by Tim Horton.
1300
1301         * DOM/DOM.mm:
1302         (-[DOMNode boundingBox]):
1303         * DOM/DOMElement.mm:
1304         * DOM/DOMHTML.mm:
1305         * DOM/DOMInternal.mm:
1306         * DOM/DOMUIKitExtensions.mm:
1307         * DOM/WebDOMOperations.mm:
1308         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1309         * DefaultDelegates/WebDefaultEditingDelegate.m:
1310         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1311         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1312         * DefaultDelegates/WebDefaultUIDelegate.h:
1313         * DefaultDelegates/WebDefaultUIDelegate.mm:
1314         (-[WebDefaultUIDelegate webViewClose:]):
1315         (-[WebDefaultUIDelegate webViewFocus:]):
1316         (-[WebDefaultUIDelegate webViewUnfocus:]):
1317         (-[WebDefaultUIDelegate webViewIsResizable:]):
1318         (-[WebDefaultUIDelegate webView:setResizable:]):
1319         (-[WebDefaultUIDelegate webView:setFrame:]):
1320         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1321         * History/BackForwardList.h:
1322         * History/BackForwardList.mm:
1323         * History/WebBackForwardList.mm:
1324         (+[WebBackForwardList initialize]):
1325         (bumperCarBackForwardHackNeeded):
1326         * History/WebHistory.mm:
1327         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1328         (-[WebHistory _sendNotification:entries:]):
1329         (-[WebHistory loadFromURL:error:]):
1330         (-[WebHistory saveToURL:error:]):
1331         * History/WebHistoryItem.mm:
1332         (WKNotifyHistoryItemChanged):
1333         (+[WebHistoryItem initialize]):
1334         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1335         * History/WebURLsWithTitles.m:
1336         * Misc/WebCache.mm:
1337         (+[WebCache initialize]):
1338         * Misc/WebDownload.mm:
1339         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1340         * Misc/WebElementDictionary.mm:
1341         (+[WebElementDictionary initialize]):
1342         (+[WebElementDictionary initializeLookupTable]):
1343         * Misc/WebIconDatabase.mm:
1344         * Misc/WebKitNSStringExtras.mm:
1345         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1346         * Misc/WebKitVersionChecks.h:
1347         * Misc/WebKitVersionChecks.mm:
1348         (WebKitLinkedOnOrAfter):
1349         (WebKitLinkTimeVersion):
1350         * Misc/WebLocalizableStrings.mm:
1351         * Misc/WebNSControlExtras.h:
1352         * Misc/WebNSControlExtras.m:
1353         * Misc/WebNSEventExtras.m:
1354         * Misc/WebNSFileManagerExtras.mm:
1355         * Misc/WebNSImageExtras.h:
1356         * Misc/WebNSImageExtras.m:
1357         * Misc/WebNSPasteboardExtras.mm:
1358         * Misc/WebNSPrintOperationExtras.h:
1359         * Misc/WebNSPrintOperationExtras.m:
1360         * Misc/WebNSViewExtras.m:
1361         * Misc/WebNSWindowExtras.m:
1362         * Panels/WebAuthenticationPanel.h:
1363         * Panels/WebAuthenticationPanel.m:
1364         * Panels/WebPanelAuthenticationHandler.m:
1365         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1366         (+[WebHostedNetscapePluginView initialize]):
1367         * Plugins/WebBasePluginPackage.h:
1368         * Plugins/WebBasePluginPackage.mm:
1369         * Plugins/WebJavaPlugIn.h:
1370         * Plugins/WebPluginContainerCheck.mm:
1371         * Plugins/WebPluginController.h:
1372         * Plugins/WebPluginController.mm:
1373         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1374         (-[WebPluginController addPlugin:]):
1375         (-[WebPluginController destroyPlugin:]):
1376         (-[WebPluginController destroyAllPlugins]):
1377         * Plugins/WebPluginDatabase.mm:
1378         (+[WebPluginDatabase _defaultPlugInPaths]):
1379         * Plugins/WebPluginPackage.mm:
1380         (-[WebPluginPackage initWithPath:]):
1381         * Storage/WebDatabaseManager.mm:
1382         (-[WebDatabaseManager deleteAllDatabases]):
1383         * Storage/WebDatabaseManagerClient.h:
1384         * Storage/WebDatabaseManagerClient.mm:
1385         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1386         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1387         * Storage/WebStorageManager.mm:
1388         (-[WebStorageManager deleteAllOrigins]):
1389         (WebKitInitializeStorageIfNecessary):
1390         * WebCoreSupport/WebAlternativeTextClient.h:
1391         * WebCoreSupport/WebApplicationCache.mm:
1392         (applicationCacheBundleIdentifier):
1393         * WebCoreSupport/WebChromeClient.h:
1394         * WebCoreSupport/WebChromeClient.mm:
1395         (WebChromeClient::setWindowRect):
1396         (WebChromeClient::windowRect):
1397         (WebChromeClient::takeFocus):
1398         (WebChromeClient::addMessageToConsole):
1399         (WebChromeClient::enableSuddenTermination):
1400         (WebChromeClient::disableSuddenTermination):
1401         (WebChromeClient::createPopupMenu const):
1402         (WebChromeClient::createSearchPopupMenu const):
1403         (WebChromeClient::shouldPaintEntireContents const):
1404         (WebChromeClient::supportsVideoFullscreen):
1405         (WebChromeClient::supportsFullScreenForElement):
1406         (WebChromeClient::enterFullScreenForElement):
1407         (WebChromeClient::exitFullScreenForElement):
1408         * WebCoreSupport/WebContextMenuClient.mm:
1409         * WebCoreSupport/WebDragClient.mm:
1410         * WebCoreSupport/WebEditorClient.h:
1411         * WebCoreSupport/WebEditorClient.mm:
1412         (+[WebUndoStep initialize]):
1413         (updateFontPanel):
1414         (WebEditorClient::didBeginEditing):
1415         (WebEditorClient::respondToChangedContents):
1416         (WebEditorClient::respondToChangedSelection):
1417         (WebEditorClient::canceledComposition):
1418         (WebEditorClient::didEndEditing):
1419         (WebEditorClient::didWriteSelectionToPasteboard):
1420         (attributesForAttributedStringConversion):
1421         (WebEditorClient::setInsertionPasteboard):
1422         (WebEditorClient::registerUndoOrRedoStep):
1423         (WebEditorClient::handleKeyboardEvent):
1424         (WebEditorClient::handleInputMethodKeydown):
1425         (WebEditorClient::textDidChangeInTextField):
1426         (WebEditorClient::requestCheckingOfString):
1427         * WebCoreSupport/WebFrameLoaderClient.h:
1428         * WebCoreSupport/WebFrameLoaderClient.mm:
1429         (WebFrameLoaderClient::detachedFromParent2):
1430         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1431         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1432         (WebFrameLoaderClient::dispatchWillSendRequest):
1433         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1434         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1435         (WebFrameLoaderClient::willCacheResponse const):
1436         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1437         (WebFrameLoaderClient::dispatchDidFinishLoading):
1438         (WebFrameLoaderClient::dispatchDidFailLoading):
1439         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1440         (WebFrameLoaderClient::dispatchWillClose):
1441         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1442         (WebFrameLoaderClient::dispatchDidCommitLoad):
1443         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1444         (WebFrameLoaderClient::dispatchDidFailLoad):
1445         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1446         (WebFrameLoaderClient::dispatchDidFinishLoad):
1447         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1448         (WebFrameLoaderClient::willChangeTitle):
1449         (WebFrameLoaderClient::didChangeTitle):
1450         (WebFrameLoaderClient::didReplaceMultipartContent):
1451         (WebFrameLoaderClient::updateGlobalHistory):
1452         (WebFrameLoaderClient::saveViewStateToItem):
1453         (WebFrameLoaderClient::restoreViewState):
1454         (WebFrameLoaderClient::provisionalLoadStarted):
1455         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1456         (WebFrameLoaderClient::setTitle):
1457         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1458         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1459         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1460         (WebFrameLoaderClient::didRestoreFromPageCache):
1461         (WebFrameLoaderClient::actionDictionary const):
1462         (WebFrameLoaderClient::createPlugin):
1463         (WebFrameLoaderClient::getLoadDecisionForIcons):
1464         (WebFrameLoaderClient::finishedLoadingIcon):
1465         (+[WebFramePolicyListener initialize]):
1466         * WebCoreSupport/WebFrameNetworkingContext.mm:
1467         * WebCoreSupport/WebGeolocationClient.h:
1468         * WebCoreSupport/WebGeolocationClient.mm:
1469         (WebGeolocationClient::requestPermission):
1470         * WebCoreSupport/WebInspectorClient.h:
1471         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1472         * WebCoreSupport/WebNotificationClient.mm:
1473         * WebCoreSupport/WebOpenPanelResultListener.mm:
1474         * WebCoreSupport/WebPlatformStrategies.h:
1475         * WebCoreSupport/WebPlatformStrategies.mm:
1476         * WebCoreSupport/WebProgressTrackerClient.h:
1477         * WebCoreSupport/WebProgressTrackerClient.mm:
1478         (WebProgressTrackerClient::progressStarted):
1479         (WebProgressTrackerClient::progressEstimateChanged):
1480         (WebProgressTrackerClient::progressFinished):
1481         * WebCoreSupport/WebSecurityOrigin.mm:
1482         * WebInspector/WebNodeHighlight.h:
1483         * WebInspector/WebNodeHighlight.mm:
1484         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1485         (-[WebNodeHighlight dealloc]):
1486         (-[WebNodeHighlight attach]):
1487         * WebInspector/WebNodeHighlightView.h:
1488         * WebInspector/WebNodeHighlightView.mm:
1489         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1490         (-[WebNodeHighlightView dealloc]):
1491         * WebInspector/WebNodeHighlighter.mm:
1492         (-[WebNodeHighlighter highlight]):
1493         * WebView/WebArchive.mm:
1494         (+[WebArchivePrivate initialize]):
1495         * WebView/WebClipView.h:
1496         * WebView/WebDataSource.mm:
1497         (WebDataSourcePrivate::WebDataSourcePrivate):
1498         (+[WebDataSource initialize]):
1499         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1500         (-[WebDataSource _makeRepresentation]):
1501         * WebView/WebDelegateImplementationCaching.h:
1502         * WebView/WebDelegateImplementationCaching.mm:
1503         (CallDelegate):
1504         (CallDelegateReturningFloat):
1505         (CallDelegateReturningBoolean):
1506         (CallUIDelegate):
1507         (CallUIDelegateReturningFloat):
1508         (CallUIDelegateReturningBoolean):
1509         (CallFrameLoadDelegate):
1510         (CallFrameLoadDelegateReturningBoolean):
1511         (CallResourceLoadDelegate):
1512         (CallScriptDebugDelegate):
1513         (CallFormDelegate):
1514         (CallFormDelegateReturningBoolean):
1515         * WebView/WebDeviceOrientation.mm:
1516         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1517         * WebView/WebDocumentInternal.h:
1518         * WebView/WebDocumentLoaderMac.mm:
1519         (needsDataLoadWorkaround):
1520         * WebView/WebDynamicScrollBarsViewInternal.h:
1521         * WebView/WebFormDelegate.m:
1522         * WebView/WebFrame.mm:
1523         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1524         (-[WebFrame _unmarkAllMisspellings]):
1525         (-[WebFrame _paintBehaviorForDestinationContext:]):
1526         (-[WebFrame _drawRect:contentsOnly:]):
1527         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1528         (-[WebFrame _scrollDOMRangeToVisible:]):
1529         (-[WebFrame _bodyBackgroundColor]):
1530         (-[WebFrame accessibilityRoot]):
1531         (needsMicrosoftMessengerDOMDocumentWorkaround):
1532         * WebView/WebFrameInternal.h:
1533         * WebView/WebFrameView.mm:
1534         (-[WebFrameView _setDocumentView:]):
1535         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1536         (-[WebFrameView _viewClassForMIMEType:]):
1537         (-[WebFrameView initWithFrame:]):
1538         (-[WebFrameView drawRect:]):
1539         (-[WebFrameView _firstResponderIsFormControl]):
1540         (-[WebFrameView keyDown:keyDown:]):
1541         (-[WebFrameView _isScrollable]):
1542         * WebView/WebFullScreenController.h:
1543         * WebView/WebFullScreenController.mm:
1544         * WebView/WebHTMLRepresentation.mm:
1545         * WebView/WebHTMLView.mm:
1546         (-[WebHTMLView hitTest:]):
1547         (-[WebHTMLView initWithFrame:]):
1548         (-[WebHTMLView dealloc]):
1549         (-[WebHTMLView addSubview:]):
1550         (-[WebHTMLView mouseDown:]):
1551         (-[WebHTMLView mouseUp:]):
1552         (-[WebHTMLView resignFirstResponder]):
1553         (-[WebHTMLView accessibilityHitTest:]):
1554         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1555         * WebView/WebHTMLViewInternal.h:
1556         * WebView/WebIndicateLayer.h:
1557         * WebView/WebIndicateLayer.mm:
1558         * WebView/WebMediaPlaybackTargetPicker.h:
1559         * WebView/WebMediaPlaybackTargetPicker.mm:
1560         * WebView/WebPDFDocumentExtras.h:
1561         * WebView/WebPDFDocumentExtras.mm:
1562         * WebView/WebPDFRepresentation.h:
1563         * WebView/WebPDFRepresentation.mm:
1564         * WebView/WebPDFView.h:
1565         * WebView/WebPreferences.mm:
1566         (cacheModelForMainBundle):
1567         (WebPreferencesPrivate::WebPreferencesPrivate):
1568         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
1569         (-[WebPreferences encodeWithCoder:]):
1570         (+[WebPreferences standardPreferences]):
1571         (+[WebPreferences initialize]):
1572         (-[WebPreferences _valueForKey:]):
1573         (-[WebPreferences _setStringValue:forKey:]):
1574         (-[WebPreferences _setIntegerValue:forKey:]):
1575         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1576         (-[WebPreferences _setFloatValue:forKey:]):
1577         (-[WebPreferences _setBoolValue:forKey:]):
1578         (-[WebPreferences _setLongLongValue:forKey:]):
1579         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1580         (-[WebPreferences _postCacheModelChangedNotification]):
1581         (-[WebPreferences _postPreferencesChangedNotification]):
1582         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1583         (-[WebPreferences setStorageBlockingPolicy:]):
1584         * WebView/WebResource.mm:
1585         (+[WebResourcePrivate initialize]):
1586         * WebView/WebTextCompletionController.h:
1587         * WebView/WebTextIterator.mm:
1588         (+[WebTextIteratorPrivate initialize]):
1589         * WebView/WebView.mm:
1590         (shouldEnableLoadDeferring):
1591         (shouldRestrictWindowFocus):
1592         (shouldRespectPriorityInCSSAttributeSetters):
1593         (shouldUseLegacyBackgroundSizeShorthandBehavior):
1594         (shouldAllowPictureInPictureMediaPlayback):
1595         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
1596         (shouldAllowWindowOpenWithoutUserGesture):
1597         (shouldConvertInvalidURLsToBlank):
1598         (shouldRequireUserGestureToLoadVideo):
1599         (-[WebView _commonInitializationWithFrameName:groupName:]):
1600         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
1601         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
1602         (-[WebView _closePluginDatabases]):
1603         (-[WebView _closeWithFastTeardown]):
1604         (-[WebView _close]):
1605         (+[WebView _MIMETypeForFile:]):
1606         (-[WebView setShowingInspectorIndication:]):
1607         (-[WebView _setFormDelegate:]):
1608         (-[WebView _needsPreHTML5ParserQuirks]):
1609         (-[WebView _preferencesChangedNotification:]):
1610         (-[WebView _preferencesChanged:]):
1611         (-[WebView _cacheResourceLoadDelegateImplementations]):
1612         (-[WebView _cacheFrameLoadDelegateImplementations]):
1613         (-[WebView _policyDelegateForwarder]):
1614         (-[WebView _UIDelegateForwarder]):
1615         (-[WebView _editingDelegateForwarder]):
1616         (-[WebView _updateActiveState]):
1617         (-[_WebSafeForwarder forwardInvocation:]):
1618         (+[WebView initialize]):
1619         (-[WebView _pluginForMIMEType:]):
1620         (-[WebView _pluginForExtension:]):
1621         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
1622         (+[WebView canShowMIMETypeAsHTML:]):
1623         (-[WebView _initWithArguments:]):
1624         (-[WebView initWithFrame:frameName:groupName:]):
1625         (-[WebView dealloc]):
1626         (-[WebView close]):
1627         (-[WebView viewDidMoveToWindow]):
1628         (-[WebView setUIDelegate:]):
1629         (-[WebView setResourceLoadDelegate:]):
1630         (-[WebView setPolicyDelegate:]):
1631         (-[WebView setFrameLoadDelegate:]):
1632         (-[WebView goBack]):
1633         (-[WebView goForward]):
1634         (-[WebView stringByEvaluatingJavaScriptFromString:]):
1635         (-[WebView setHostWindow:]):
1636         (-[WebView becomeFirstResponder]):
1637         (+[WebView _cacheModelChangedNotification:]):
1638         (-[WebView _frameViewAtWindowPoint:]):
1639         (+[WebView _preflightSpellCheckerNow:]):
1640         (+[WebView _preflightSpellChecker]):
1641         (-[WebView canGoBack]):
1642         (-[WebView canGoForward]):
1643         (-[WebView stopLoading:]):
1644         (-[WebView reload:]):
1645         (-[WebView setMainFrameDocumentReady:]):
1646         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1647         (-[WebView setContinuousSpellCheckingEnabled:]):
1648         (-[WebView undoManager]):
1649         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
1650         (-[WebView isAutomaticLinkDetectionEnabled]):
1651         (-[WebView isAutomaticDashSubstitutionEnabled]):
1652         (-[WebView isAutomaticTextReplacementEnabled]):
1653         (-[WebView isAutomaticSpellingCorrectionEnabled]):
1654         (+[WebView _setCacheModel:]):
1655         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1656         (-[WebView _keyboardUIMode]):
1657         (LayerFlushController::flushLayers):
1658         (-[WebView _scheduleCompositingLayerFlush]):
1659         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1660         (-[WebView fullScreenPlaceholderView]):
1661         (WebInstallMemoryPressureHandler):
1662         * WebView/WebViewData.h:
1663         * WebView/WebViewData.mm:
1664         (+[WebViewPrivate initialize]):
1665         (-[WebViewPrivate init]):
1666         (-[WebViewPrivate dealloc]):
1667         * WebView/WebViewInternal.h:
1668
1669 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1670
1671         Clean up FrameLoader two-state enums
1672         https://bugs.webkit.org/show_bug.cgi?id=190731
1673
1674         Reviewed by Chris Dumez.
1675
1676         * WebCoreSupport/WebFrameLoaderClient.h:
1677         * WebCoreSupport/WebFrameLoaderClient.mm:
1678         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1679
1680 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1681
1682         Unreviewed, rolling out r237137.
1683
1684         SPI is actually used
1685
1686         Reverted changeset:
1687
1688         "Remove unused WebFrame._loadType"
1689         https://bugs.webkit.org/show_bug.cgi?id=190583
1690         https://trac.webkit.org/changeset/237137
1691
1692 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1693
1694         Enable the datalist element by default on iOS and macOS
1695         https://bugs.webkit.org/show_bug.cgi?id=190594
1696         <rdar://problem/45281159>
1697
1698         Reviewed by Ryosuke Niwa and Tim Horton.
1699
1700         * Configurations/FeatureDefines.xcconfig:
1701
1702 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1703
1704         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1705         https://bugs.webkit.org/show_bug.cgi?id=190675
1706
1707         Reviewed by Chris Dumez.
1708
1709         * History/BackForwardList.h:
1710         * History/BackForwardList.mm:
1711         (BackForwardList::backItem):
1712         (BackForwardList::currentItem):
1713         (BackForwardList::forwardItem):
1714         (BackForwardList::backListCount const):
1715         (BackForwardList::forwardListCount const):
1716         (BackForwardList::itemAtIndex):
1717         * History/WebBackForwardList.mm:
1718         (-[WebBackForwardList backItem]):
1719         (-[WebBackForwardList currentItem]):
1720         (-[WebBackForwardList forwardItem]):
1721         (-[WebBackForwardList itemAtIndex:]):
1722
1723 2018-10-16  Timothy Hatcher  <timothy@apple.com>
1724
1725         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
1726         https://bugs.webkit.org/show_bug.cgi?id=190526
1727         rdar://problem/45230140
1728
1729         Reviewed by Dean Jackson.
1730
1731         * WebCoreSupport/WebEditorClient.mm:
1732         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
1733
1734 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
1735
1736         Implement feature flag and bindings for CSS Painting API
1737         https://bugs.webkit.org/show_bug.cgi?id=190237
1738
1739         Reviewed by Ryosuke Niwa.
1740
1741         * Configurations/FeatureDefines.xcconfig:
1742
1743 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1744
1745         Replace HistoryItem* with HistoryItem& where possible
1746         https://bugs.webkit.org/show_bug.cgi?id=190617
1747
1748         Reviewed by Chris Dumez.
1749
1750         * History/BackForwardList.h:
1751         * History/BackForwardList.mm:
1752         (BackForwardList::goToItem):
1753         * History/WebBackForwardList.mm:
1754         (-[WebBackForwardList goToItem:]):
1755         * History/WebHistoryItem.mm:
1756         (WKNotifyHistoryItemChanged):
1757         * History/WebHistoryItemInternal.h:
1758
1759 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1760
1761         Remove unused WebHistoryItem._transientPropertyForKey
1762         https://bugs.webkit.org/show_bug.cgi?id=190606
1763
1764         Reviewed by Chris Dumez.
1765
1766         * History/WebHistoryItem.mm:
1767         * History/WebHistoryItemPrivate.h:
1768
1769 2018-10-15  Justin Fan  <justin_fan@apple.com>
1770
1771         Add WebGPU 2018 feature flag and experimental feature flag
1772         https://bugs.webkit.org/show_bug.cgi?id=190509
1773
1774         Reviewed by Dean Jackson.
1775
1776         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
1777         for the 2018 WebGPU prototype.
1778
1779         * Configurations/FeatureDefines.xcconfig:
1780         * WebView/WebPreferenceKeysPrivate.h:
1781         * WebView/WebPreferences.mm:
1782         (+[WebPreferences initialize]):
1783         (-[WebPreferences webGPUEnabled]):
1784         (-[WebPreferences setWebGPUEnabled:]):
1785         * WebView/WebPreferencesPrivate.h:
1786         * WebView/WebView.mm:
1787         (-[WebView _preferencesChanged:]):
1788
1789 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1790
1791         Fix iOS build after r237157
1792
1793         * WebView/WebView.mm:
1794         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1795
1796 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1797
1798         Modernize BackForwardClient.h
1799         https://bugs.webkit.org/show_bug.cgi?id=190610
1800
1801         Reviewed by Chris Dumez.
1802
1803         * History/BackForwardList.h:
1804         * History/BackForwardList.mm:
1805         (BackForwardList::backListCount const):
1806         (BackForwardList::forwardListCount const):
1807         (BackForwardList::backListCount): Deleted.
1808         (BackForwardList::forwardListCount): Deleted.
1809         * History/WebBackForwardList.mm:
1810         (-[WebBackForwardList init]):
1811         * WebCoreSupport/WebFrameLoaderClient.mm:
1812         (WebFrameLoaderClient::canCachePage const):
1813         * WebView/WebFrameView.mm:
1814         (-[WebFrameView keyDown:keyDown:]):
1815         * WebView/WebView.mm:
1816         (-[WebView _commonInitializationWithFrameName:groupName:]):
1817         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1818         (-[WebView _loadBackForwardListFromOtherView:]):
1819         (-[WebView initWithCoder:]):
1820         (-[WebView encodeWithCoder:]):
1821         (-[WebView backForwardList]):
1822         (-[WebView setMaintainsBackForwardList:]):
1823
1824 2018-10-15  Timothy Hatcher  <timothy@apple.com>
1825
1826         Add support for prefers-color-scheme media query
1827         https://bugs.webkit.org/show_bug.cgi?id=190499
1828         rdar://problem/45212025
1829
1830         Reviewed by Dean Jackson.
1831
1832         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
1833
1834 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1835
1836         Remove unused WebView._globalHistoryItem
1837         https://bugs.webkit.org/show_bug.cgi?id=190601
1838
1839         Reviewed by Chris Dumez.
1840
1841         * WebCoreSupport/WebFrameLoaderClient.h:
1842         * WebCoreSupport/WebFrameLoaderClient.mm:
1843         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1844         * WebView/WebView.mm:
1845         (-[WebView _globalHistoryItem]): Deleted.
1846         (-[WebView _setGlobalHistoryItem:]): Deleted.
1847         * WebView/WebViewData.h:
1848         * WebView/WebViewInternal.h:
1849         * WebView/WebViewPrivate.h:
1850
1851 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1852
1853         Remove unused parameters from FrameLoaderClient::createFrame
1854         https://bugs.webkit.org/show_bug.cgi?id=190587
1855
1856         Reviewed by Chris Dumez.
1857
1858         * WebCoreSupport/WebFrameLoaderClient.h:
1859         * WebCoreSupport/WebFrameLoaderClient.mm:
1860         (WebFrameLoaderClient::createFrame):
1861
1862 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1863
1864         Remove unused WebFrame._loadType
1865         https://bugs.webkit.org/show_bug.cgi?id=190583
1866
1867         Reviewed by Chris Dumez.
1868
1869         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
1870
1871         * WebView/WebFrame.mm:
1872         (toWebFrameLoadType): Deleted.
1873         (-[WebFrame _loadType]): Deleted.
1874         * WebView/WebFramePrivate.h:
1875
1876 2018-10-15  Chris Dumez  <cdumez@apple.com>
1877
1878         Restrict browsing context lookup by name to frames that are related to one another
1879         https://bugs.webkit.org/show_bug.cgi?id=190475
1880
1881         Reviewed by Alex Christensen.
1882
1883         * WebView/WebFrame.mm:
1884         (-[WebFrame findFrameNamed:]):
1885
1886 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1887
1888         Remove InjectedBundle processing of back/forward lists
1889         https://bugs.webkit.org/show_bug.cgi?id=190459
1890
1891         Reviewed by Chris Dumez.
1892
1893         * WebCoreSupport/WebFrameLoaderClient.h:
1894         * WebCoreSupport/WebFrameLoaderClient.mm:
1895         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1896
1897 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1898
1899         [JSC] Remove Option::useAsyncIterator
1900         https://bugs.webkit.org/show_bug.cgi?id=190567
1901
1902         Reviewed by Saam Barati.
1903
1904         * Configurations/FeatureDefines.xcconfig:
1905
1906 2018-10-12  Alex Christensen  <achristensen@webkit.org>
1907
1908         Allow encoding of small enum classes
1909         https://bugs.webkit.org/show_bug.cgi?id=190531
1910
1911         Reviewed by Tim Horton.
1912
1913         * WebCoreSupport/WebFrameLoaderClient.mm:
1914         (-[WebFramePolicyListener dealloc]):
1915
1916 2018-10-11  Keith Rollin  <krollin@apple.com>
1917
1918         CURRENT_ARCH should not be used in Run Script phase.
1919         https://bugs.webkit.org/show_bug.cgi?id=190407
1920         <rdar://problem/45133556>
1921
1922         Reviewed by Alexey Proskuryakov.
1923
1924         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
1925         CURRENT_ARCH is not well-defined during this phase (and may even have
1926         the value "undefined") since this phase is run just once per build
1927         rather than once per supported architecture. Migrate away from
1928         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
1929         performing an operation for each value, or by picking the first entry
1930         in ARCHS and using that as a representative value.
1931
1932         * Configurations/WebKitLegacy.xcconfig: When generating
1933         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
1934         macosx platforms.
1935
1936         * MigrateHeaders.make:
1937         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
1938         generate one for each architecture in ARCHS.
1939
1940 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1941
1942         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
1943         https://bugs.webkit.org/show_bug.cgi?id=190429
1944
1945         Reviewed by Saam Barati.
1946
1947         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
1948
1949         * WebView/WebPDFRepresentation.mm:
1950         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
1951
1952 2018-10-08  Justin Fan  <justin_fan@apple.com>
1953
1954         WebGPU: Rename old WebGPU prototype to WebMetal
1955         https://bugs.webkit.org/show_bug.cgi?id=190325
1956         <rdar://problem/44990443>
1957
1958         Reviewed by Dean Jackson.
1959
1960         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
1961
1962         * Configurations/FeatureDefines.xcconfig:
1963         * WebView/WebPreferenceKeysPrivate.h:
1964         * WebView/WebPreferences.mm:
1965         (+[WebPreferences initialize]):
1966         (-[WebPreferences webMetalEnabled]):
1967         (-[WebPreferences setWebMetalEnabled:]):
1968         (-[WebPreferences webGPUEnabled]): Deleted.
1969         (-[WebPreferences setWebGPUEnabled:]): Deleted.
1970         * WebView/WebPreferencesPrivate.h:
1971         * WebView/WebView.mm:
1972         (-[WebView _preferencesChanged:]):
1973
1974 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
1975
1976         Make <input type=color> a runtime enabled (on-by-default) feature
1977         https://bugs.webkit.org/show_bug.cgi?id=189162
1978
1979         Reviewed by Wenson Hsieh and Tim Horton.
1980
1981         * Configurations/FeatureDefines.xcconfig:
1982
1983 2018-10-07  Dan Bernstein  <mitz@apple.com>
1984
1985         Fixed building with the latest macOS SDK
1986
1987         * Plugins/WebNetscapePluginPackage.mm:
1988         (-[WebNetscapePluginPackage openResourceFile]):
1989         (-[WebNetscapePluginPackage closeResourceFile:]):
1990
1991 2018-10-04  Dan Bernstein  <mitz@apple.com>
1992
1993         More Carbon build-fixing.
1994
1995         * Carbon/CarbonWindowAdapter.mm:
1996         (-[CarbonWindowAdapter _destroyRealWindow:]):
1997         (-[CarbonWindowAdapter _growBoxRect]):
1998
1999 2018-10-04  Dan Bernstein  <mitz@apple.com>
2000
2001         Retried to fix 32-bit macOS builds after r236846.
2002
2003         * WebView/WebHTMLView.mm:
2004         (-[WebHTMLView setMarkedText:selectedRange:]):
2005
2006 2018-10-04  Dan Bernstein  <mitz@apple.com>
2007
2008         Retried to fix 32-bit macOS builds after r236846.
2009
2010         * Carbon/HIWebView.mm:
2011         (ActiveStateChanged):
2012
2013 2018-10-04  Dan Bernstein  <mitz@apple.com>
2014
2015         Tried to fix 32-bit macOS builds after r236846.
2016
2017         * Carbon/HIWebView.mm:
2018         (_NSSelectorForHICommand):
2019
2020 2018-10-04  Dan Bernstein  <mitz@apple.com>
2021
2022         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2023         https://bugs.webkit.org/show_bug.cgi?id=190250
2024
2025         Reviewed by Andy Estes.
2026
2027         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2028           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2029           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2030           an earlier line set it to YES.
2031
2032         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2033         changes below.
2034
2035         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2036           provides some missing method declarations.
2037
2038         * Misc/WebDownload.mm:
2039         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2040           a deprecated method.
2041
2042         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2043
2044         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2045           other code in the file uses a method from it.
2046
2047         * Plugins/WebBaseNetscapePluginView.mm:
2048         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2049           a deprecated method.
2050
2051         * Plugins/WebPluginController.mm:
2052         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2053           around use of a selector that may be present in some WebKit client.
2054
2055         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2056           method declarations.
2057
2058         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2059           from here.
2060
2061         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2062           missing method declarations.
2063
2064         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2065           from here.
2066
2067         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2068           call from here.
2069         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2070           an obsolete delegate method for binary compatibility.
2071         (pluginView): Ditto.
2072
2073         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2074           call from here.
2075
2076         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2077           WebDeviceOrientationProviderMock protocol.
2078
2079         * WebView/WebDeviceOrientationProviderMock.mm:
2080         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2081           main @implementation.
2082
2083         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2084           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2085
2086         * WebView/WebDynamicScrollBarsView.mm:
2087         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2088           of a deprecated method.
2089
2090         * WebView/WebHTMLView.mm:
2091         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2092           selector warning around action methods that are not declared anywhere in WebKit.
2093
2094         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2095           about implementing this deprecated method.
2096         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2097         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2098         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2099         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2100         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2101         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2102         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2103         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2104         (-[WebHTMLView doCommandBySelector:]): Ditto.
2105         (-[WebHTMLView insertText:]): Ditto.
2106
2107         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2108
2109         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2110
2111         * WebView/WebPDFView.h: Removed previewView ivar.
2112
2113         * WebView/WebPDFView.mm:
2114           Removed declaration of FileInternal category and merged its implementation with the main
2115           implementation.
2116         (-[WebPDFView dealloc]): Removed previewView ivar.
2117         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2118           exist in macOS versions we support.
2119         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2120         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2121           action methods internal to PDFKit.
2122         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2123         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2124
2125         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2126           call on macOS, even though in r86988 we started calling different methods on iOS.
2127
2128         * WebView/WebView.mm:
2129         - Imported headers that declare delegate methods that we call.
2130         - Removed declaration of WebFileInternal category and merged its implementation with the
2131           main implementation.
2132         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2133           category, which made them impossible to call from the main implementation. Moved those
2134           into the main implementation. One of those had to be declared in a class extension,
2135           because it is called from a method implemented in the WebPrivate category, and that
2136           category’s implementation appears first in the file.
2137
2138         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2139           around use of obsolete delegate method for binary compatibility.
2140
2141         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2142
2143 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2144
2145         Runtime flag and IDL for MediaRecorder
2146         https://bugs.webkit.org/show_bug.cgi?id=190018
2147
2148         Reviewed by Youenn Fablet and Chris Dumez.
2149
2150         * WebView/WebPreferenceKeysPrivate.h:
2151         * WebView/WebPreferences.mm:
2152         (+[WebPreferences initialize]):
2153         (-[WebPreferences mediaRecorderEnabled]):
2154         (-[WebPreferences setMediaRecorderEnabled:]):
2155         * WebView/WebPreferencesPrivate.h:
2156         * WebView/WebView.mm:
2157         (-[WebView _preferencesChanged:]):
2158
2159 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2160
2161         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2162         https://bugs.webkit.org/show_bug.cgi?id=190238
2163
2164         Reviewed by Antti Koivisto.
2165
2166         Enabled the feature by default.
2167
2168         * WebView/WebPreferences.mm:
2169         (+[WebPreferences initialize]):
2170
2171 2018-10-01  Dean Jackson  <dino@apple.com>
2172
2173         [macOS] Switching to discrete GPU should be done in the UI process
2174         https://bugs.webkit.org/show_bug.cgi?id=189361
2175         <rdar://problem/43949622>
2176
2177         Reviewed by Simon Fraser.
2178
2179         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2180         not support swapping to the discrete GPU in this configuration.
2181
2182         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2183         (WebKit::WebSwitchingGPUClient::singleton):
2184         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2185         * WebView/WebView.mm:
2186         (-[WebView _commonInitializationWithFrameName:groupName:]):
2187
2188 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2189
2190         Remove ParsedURLString
2191         https://bugs.webkit.org/show_bug.cgi?id=190154
2192
2193         Reviewed by Chris Dumez.
2194
2195         * WebView/WebScriptDebugger.mm:
2196         (toNSURL):
2197
2198 2018-10-01  Dean Jackson  <dino@apple.com>
2199
2200         Remove CSS Animation Triggers
2201         https://bugs.webkit.org/show_bug.cgi?id=190175
2202         <rdar://problem/44925626>
2203
2204         Reviewed by Simon Fraser.
2205
2206         * Configurations/FeatureDefines.xcconfig:
2207
2208 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2209
2210         Unreviewed, rolling out r236624 and r236671.
2211         https://bugs.webkit.org/show_bug.cgi?id=190207
2212
2213         The change in r236624 introduced crashes on the bots
2214         (Requested by ryanhaddad on #webkit).
2215
2216         Reverted changesets:
2217
2218         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2219         https://bugs.webkit.org/show_bug.cgi?id=188747
2220         https://trac.webkit.org/changeset/236624
2221
2222         "Unify implementation in VideoFullscreenInterfaceAVKit"
2223         https://bugs.webkit.org/show_bug.cgi?id=190091
2224         https://trac.webkit.org/changeset/236671
2225
2226 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2227
2228         URL should not use TextEncoding internally
2229         https://bugs.webkit.org/show_bug.cgi?id=190111
2230
2231         Reviewed by Andy Estes.
2232
2233         * Misc/WebNSURLExtras.mm:
2234
2235 2018-09-28  Jer Noble  <jer.noble@apple.com>
2236
2237         Refactoring: eliminate raw pointer usage in Fullscreen code
2238         https://bugs.webkit.org/show_bug.cgi?id=188747
2239         <rdar://problem/43541164>
2240
2241         Reviewed by Alex Christensen.
2242
2243         PlaybackSessionInterface no longer has an invalidate() method.
2244
2245         * WebView/WebView.mm:
2246         (-[WebView _clearPlaybackControlsManager]):
2247
2248 2018-09-28  Chris Dumez  <cdumez@apple.com>
2249
2250         Drop support for cross-origin-window-policy header
2251         https://bugs.webkit.org/show_bug.cgi?id=190081
2252
2253         Reviewed by Ryosuke Niwa.
2254
2255         * WebView/WebPreferenceKeysPrivate.h:
2256         * WebView/WebPreferences.mm:
2257         (+[WebPreferences initialize]):
2258         * WebView/WebPreferencesPrivate.h:
2259         * WebView/WebView.mm:
2260         (-[WebView _preferencesChanged:]):
2261
2262 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2263
2264         Rename createMarkup to serializePreservingVisualAppearance
2265         https://bugs.webkit.org/show_bug.cgi?id=190086
2266
2267         Reviewed by Wenson Hsieh.
2268
2269         * DOM/WebDOMOperations.mm:
2270         (-[DOMRange markupString]):
2271
2272 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2273
2274         Unreviewed, rolling out r236605.
2275         https://bugs.webkit.org/show_bug.cgi?id=190087
2276
2277         caused three API test timeouts (Requested by jernoble on
2278         #webkit).
2279
2280         Reverted changeset:
2281
2282         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2283         https://bugs.webkit.org/show_bug.cgi?id=188747
2284         https://trac.webkit.org/changeset/236605
2285
2286 2018-09-28  Jer Noble  <jer.noble@apple.com>
2287
2288         Refactoring: eliminate raw pointer usage in Fullscreen code
2289         https://bugs.webkit.org/show_bug.cgi?id=188747
2290         <rdar://problem/43541164>
2291
2292         Reviewed by Alex Christensen.
2293
2294         PlaybackSessionInterface no longer has an invalidate() method.
2295
2296         * WebView/WebView.mm:
2297         (-[WebView _clearPlaybackControlsManager]):
2298
2299 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2300
2301         Use enum class in createMarkup arguments
2302         https://bugs.webkit.org/show_bug.cgi?id=190028
2303
2304         Reviewed by Wenson Hsieh.
2305
2306         * DOM/WebDOMOperations.mm:
2307         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2308         (-[DOMRange markupString]): Ditto.
2309
2310 2018-09-27  Antoine Quint  <graouts@apple.com>
2311
2312         [Web Animations] Turn Web Animations with CSS integration on
2313         https://bugs.webkit.org/show_bug.cgi?id=184819
2314         <rdar://problem/39597337>
2315
2316         Reviewed by Dean Jackson.
2317
2318         * WebView/WebPreferences.mm:
2319         (+[WebPreferences initialize]):
2320
2321 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2322
2323         Selection should work across shadow boundary when initiated by a mouse drag
2324         https://bugs.webkit.org/show_bug.cgi?id=151380
2325         <rdar://problem/24363872>
2326
2327         Reviewed by Wenson Hsieh.
2328
2329         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2330
2331         * WebView/WebPreferenceKeysPrivate.h:
2332         * WebView/WebPreferences.mm:
2333         (+[WebPreferences initialize]):
2334         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2335         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2336         * WebView/WebPreferencesPrivate.h:
2337         * WebView/WebView.mm:
2338         (-[WebView _preferencesChanged:]):
2339
2340 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2341
2342         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2343         https://bugs.webkit.org/show_bug.cgi?id=189918
2344         Work towards <rdar://problem/44648705>
2345
2346         Reviewed by Tim Horton.
2347
2348         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2349
2350         * WebView/WebHTMLView.mm:
2351         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2352         (-[WebHTMLView _updateFontPanel]):
2353         * WebView/WebView.mm:
2354         (-[WebView typingAttributes]):
2355
2356 2018-09-17  Darin Adler  <darin@apple.com>
2357
2358         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2359         https://bugs.webkit.org/show_bug.cgi?id=189652
2360
2361         Reviewed by Saam Barati.
2362
2363         * WebView/WebPDFRepresentation.mm:
2364         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2365
2366 2018-09-14  Jer Noble  <jer.noble@apple.com>
2367
2368         Turn SourceBufferChangeTypeEnabled on by default
2369         https://bugs.webkit.org/show_bug.cgi?id=189527
2370
2371         Reviewed by Eric Carlson.
2372
2373         * WebView/WebPreferences.mm:
2374         (+[WebPreferences initialize]):
2375
2376 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2377
2378         Fix an internal build after r235935
2379         https://bugs.webkit.org/show_bug.cgi?id=188996
2380
2381         * Carbon/HIWebView.mm:
2382         (Draw):
2383         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2384
2385 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2386
2387         Add IGNORE_WARNING_.* macros
2388         https://bugs.webkit.org/show_bug.cgi?id=188996
2389
2390         Reviewed by Michael Catanzaro.
2391
2392         * Carbon/CarbonUtils.m:
2393         (PoolCleaner):
2394         * Carbon/CarbonWindowAdapter.mm:
2395         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2396         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2397         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2398         (-[CarbonWindowAdapter _termWindowIfOwner]):
2399         (-[CarbonWindowAdapter _windowMovedToRect:]):
2400         (-[CarbonWindowAdapter setContentView:]):
2401         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2402         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2403         * Carbon/CarbonWindowFrame.m:
2404         (-[CarbonWindowFrame title]):
2405         * Carbon/HIViewAdapter.m:
2406         (+[HIViewAdapter getHIViewForNSView:]):
2407         * Carbon/HIWebView.mm:
2408         (overrideCGContext):
2409         (restoreCGContext):
2410         (Draw):
2411         * DOM/DOM.mm:
2412         * History/WebHistory.mm:
2413         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2414         * History/WebHistoryItem.mm:
2415         (-[WebHistoryItem icon]):
2416         * Misc/WebKitNSStringExtras.mm:
2417         (-[NSString _web_drawAtPoint:font:textColor:]):
2418         * Misc/WebNSImageExtras.m:
2419         (-[NSImage _web_scaleToMaxSize:]):
2420         (-[NSImage _web_dissolveToFraction:]):
2421         * Misc/WebNSPasteboardExtras.mm:
2422         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2423         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2424         * Panels/WebAuthenticationPanel.m:
2425         (-[WebAuthenticationPanel loadNib]):
2426         * Plugins/Hosted/NetscapePluginHostManager.mm:
2427         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2428         (WebKit::NetscapePluginHostManager::didCreateWindow):
2429         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2430         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2431         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2432         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2433         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2434         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2435         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2436         (-[WebHostedNetscapePluginView drawRect:]):
2437         * Plugins/Hosted/WebTextInputWindowController.m:
2438         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2439         * Plugins/WebBaseNetscapePluginView.mm:
2440         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2441         * Plugins/WebNetscapePluginPackage.mm:
2442         (-[WebNetscapePluginPackage _tryLoad]):
2443         * Plugins/WebNetscapePluginView.mm:
2444         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2445         (-[WebNetscapePluginView sendDrawRectEvent:]):
2446         (-[WebNetscapePluginView drawRect:]):
2447         * Plugins/WebPluginController.mm:
2448         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2449         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2450         * WebCoreSupport/PopupMenuMac.mm:
2451         (PopupMenuMac::populate):
2452         * WebCoreSupport/WebAlternativeTextClient.h:
2453         * WebCoreSupport/WebDragClient.mm:
2454         (WebDragClient::startDrag):
2455         * WebCoreSupport/WebFrameLoaderClient.mm:
2456         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2457         (webGetNSImage):
2458         * WebInspector/WebNodeHighlight.mm:
2459         * WebInspector/WebNodeHighlightView.mm:
2460         (-[WebNodeHighlightView drawRect:]):
2461         * WebView/WebClipView.mm:
2462         (-[WebClipView initWithFrame:]):
2463         * WebView/WebFrame.mm:
2464         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2465         (-[WebFrame _drawRect:contentsOnly:]):
2466         (-[WebFrame accessibilityRoot]):
2467         * WebView/WebFullScreenController.mm:
2468         (-[WebFullScreenController enterFullScreen:]):
2469         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2470         (-[WebFullScreenController exitFullScreen]):
2471         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2472         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2473         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2474         * WebView/WebHTMLView.mm:
2475         (-[NSWindow _web_borderView]):
2476         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2477         (-[WebHTMLView _setAsideSubviews]):
2478         (-[WebHTMLView _autoscroll]):
2479         (-[WebHTMLView drawRect:]):
2480         (-[WebHTMLView mouseDown:]):
2481         (-[WebHTMLView mouseDragged:]):
2482         (-[WebHTMLView mouseUp:]):
2483         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2484         (-[WebHTMLView knowsPageRange:]):
2485         (-[WebHTMLView accessibilityHitTest:]):
2486         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2487         (-[WebHTMLView _colorAsString:]):
2488         (-[WebHTMLView copyFont:]):
2489         (-[WebHTMLView _executeSavedKeypressCommands]):
2490         (-[WebHTMLView attachRootLayer:]):
2491         (-[WebHTMLView textStorage]):
2492         (-[WebHTMLView _updateSelectionForInputManager]):
2493         * WebView/WebPDFView.mm:
2494         (_applicationInfoForMIMEType):
2495         (-[WebPDFView centerSelectionInVisibleArea:]):
2496         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2497         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2498         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2499         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2500         * WebView/WebTextCompletionController.mm:
2501         (-[WebTextCompletionController _buildUI]):
2502         (-[WebTextCompletionController _placePopupWindow:]):
2503         * WebView/WebVideoFullscreenController.mm:
2504         * WebView/WebVideoFullscreenHUDWindowController.mm:
2505         (createMediaUIBackgroundView):
2506         * WebView/WebView.mm:
2507         (-[WebTextListTouchBarViewController initWithWebView:]):
2508         (-[WebView _dispatchTileDidDraw:]):
2509         (-[WebView encodeWithCoder:]):
2510         (-[WebView mainFrameIcon]):
2511         (LayerFlushController::flushLayers):
2512         * WebView/WebWindowAnimation.mm:
2513         (setScaledFrameForWindow):
2514
2515 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2516
2517         Remove unused needsDestruction class variables from HashTraits
2518         https://bugs.webkit.org/show_bug.cgi?id=189490
2519
2520         Reviewed by Daniel Bates.
2521
2522         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2523
2524 2018-09-07  Frederic Wang  <fwang@igalia.com>
2525
2526         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2527         https://bugs.webkit.org/show_bug.cgi?id=182230
2528
2529         Reviewed by Simon Fraser.
2530
2531         * DOM/DOMDocument.mm:
2532         (-[DOMDocument scrollingElement]): Use the new name.
2533
2534 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2535
2536         Refactor WebCore::EditAction to be an 8-bit enum class
2537         https://bugs.webkit.org/show_bug.cgi?id=189383
2538
2539         Reviewed by Dan Bernstein.
2540
2541         * WebCoreSupport/WebEditorClient.mm:
2542         (undoNameForEditAction):
2543         * WebView/WebHTMLView.mm:
2544         (-[WebHTMLView pasteFont:]):
2545         (-[WebHTMLView changeFont:]):
2546         (-[WebHTMLView changeAttributes:]):
2547         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
2548         (-[WebHTMLView changeColor:]):
2549         * WebView/WebView.mm:
2550         (-[WebView setTypingStyle:]):
2551
2552 2018-09-06  Frederic Wang  <fwang@igalia.com>
2553
2554         Group options of scrollRectToVisible into a struct
2555         https://bugs.webkit.org/show_bug.cgi?id=189352
2556
2557         Reviewed by Simon Fraser.
2558
2559         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
2560         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
2561         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
2562
2563 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2564
2565         [macOS] Cannot change font size at selection until font panel is shown
2566         https://bugs.webkit.org/show_bug.cgi?id=189295
2567         <rdar://problem/35593389>
2568
2569         Reviewed by Ryosuke Niwa.
2570
2571         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
2572         WebCore ChangeLog for more details.
2573
2574         * WebView/WebHTMLView.mm:
2575         (-[WebHTMLView changeFont:]):
2576         (-[WebHTMLView changeAttributes:]):
2577         (-[WebHTMLView _originalFontA]): Deleted.
2578         (-[WebHTMLView _originalFontB]): Deleted.
2579         (fontNameForDescription): Deleted.
2580         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
2581         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
2582         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
2583
2584 2018-09-05  Jer Noble  <jer.noble@apple.com>
2585
2586         Add MediaCapabilities as an Experimental Feature
2587         https://bugs.webkit.org/show_bug.cgi?id=189209
2588
2589         Reviewed by Eric Carlson.
2590
2591         RuntimeEnabledFeature -> Setting.
2592
2593         * WebView/WebView.mm:
2594         (-[WebView _preferencesChanged:]):
2595
2596 2018-09-04  Frederic Wang  <fwang@igalia.com>
2597
2598         Add basic support for ScrollIntoViewOptions
2599         https://bugs.webkit.org/show_bug.cgi?id=189258
2600
2601         Reviewed by Simon Fraser.
2602
2603         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
2604         header so that this file can build despite the new scrollIntoView function.
2605
2606 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2607
2608         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
2609         https://bugs.webkit.org/show_bug.cgi?id=188890
2610         <rdar://problem/43648605>
2611
2612         Reviewed by Tim Horton.
2613
2614         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
2615         more detail.
2616
2617         * WebCoreSupport/WebPlatformStrategies.h:
2618         * WebCoreSupport/WebPlatformStrategies.mm:
2619         (WebPlatformStrategies::allStringsForType):
2620
2621 2018-09-01  Darin Adler  <darin@apple.com>
2622
2623         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
2624         https://bugs.webkit.org/show_bug.cgi?id=189072
2625         Reviewed by Dan Bernstein.
2626
2627         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
2628         and declarations for NSURLDownload init methods.
2629
2630         * Misc/WebDownloadInternal.h: Removed.
2631
2632         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
2633         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
2634         "-Wdeprecated-declarations" because the method used here is deprecated.
2635
2636         * WebView/WebView.mm:
2637         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
2638         used here is deprecated.
2639
2640 2018-08-31  Chris Dumez  <cdumez@apple.com>
2641
2642         Assertion hit in ~CompletionHandler() from ~WebFrame()
2643         https://bugs.webkit.org/show_bug.cgi?id=189199
2644         <rdar://problem/42657233>
2645
2646         Reviewed by Youenn Fablet.
2647
2648         * WebCoreSupport/WebFrameLoaderClient.h:
2649         * WebCoreSupport/WebFrameLoaderClient.mm:
2650         (WebFrameLoaderClient::dispatchWillSubmitForm):
2651
2652 2018-08-31  Antti Koivisto  <antti@apple.com>
2653
2654         Replace OptionSet |= and -= operators with add() and remove() functions
2655         https://bugs.webkit.org/show_bug.cgi?id=189169
2656
2657         Reviewed by Anders Carlsson.
2658
2659         * WebView/WebFrame.mm:
2660         (-[WebFrame _drawRect:contentsOnly:]):
2661         * WebView/WebView.mm:
2662         (coreOptions):
2663
2664 2018-08-31  Frederic Wang  <fwang@igalia.com>
2665
2666         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
2667         https://bugs.webkit.org/show_bug.cgi?id=182053
2668
2669         Reviewed by Simon Fraser.
2670
2671         Add developer flag to use standard behavior for scrolling* attributes.
2672
2673         * WebView/WebPreferenceKeysPrivate.h:
2674         * WebView/WebPreferences.mm:
2675         (+[WebPreferences initialize]):
2676         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
2677         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
2678         * WebView/WebPreferencesPrivate.h:
2679         * WebView/WebView.mm:
2680         (-[WebView _preferencesChanged:]):
2681
2682 2018-08-29  Olivia Barnett  <obarnett@apple.com>
2683
2684         Implement the Web Share API
2685         https://bugs.webkit.org/show_bug.cgi?id=171100
2686         <rdar://problem/31751734>
2687
2688         Reviewed by Tim Horton.
2689
2690         * WebCoreSupport/WebChromeClient.h:
2691         * WebCoreSupport/WebChromeClient.mm:
2692         (WebChromeClient::showShareSheet):
2693         Empty declaration of showShareSheet.
2694
2695 2018-08-29  Youenn Fablet  <youenn@apple.com>
2696
2697         Remove WebRTC legacy API implementation
2698         https://bugs.webkit.org/show_bug.cgi?id=189040
2699
2700         Reviewed by Eric Carlson.
2701
2702         * WebView/WebPreferenceKeysPrivate.h:
2703         * WebView/WebPreferences.mm:
2704         (+[WebPreferences initialize]):
2705         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
2706         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
2707         * WebView/WebPreferencesPrivate.h:
2708         * WebView/WebView.mm:
2709         (-[WebView _preferencesChanged:]):
2710
2711 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2712
2713         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
2714         https://bugs.webkit.org/show_bug.cgi?id=189054
2715
2716         Reviewed by Andy Estes.
2717
2718         Remove the pasteboard type argument from readURLFromPasteboard.
2719
2720         * WebCoreSupport/WebPlatformStrategies.h:
2721         * WebCoreSupport/WebPlatformStrategies.mm:
2722         (WebPlatformStrategies::readURLFromPasteboard):
2723
2724 2018-08-27  Keith Rollin  <krollin@apple.com>
2725
2726         Unreviewed build fix -- disable LTO for production builds
2727
2728         * Configurations/Base.xcconfig:
2729
2730 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
2731
2732         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
2733         https://bugs.webkit.org/show_bug.cgi?id=188931
2734
2735         Reviewed by Wenson Hsieh.
2736
2737         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
2738
2739 2018-08-27  Keith Rollin  <krollin@apple.com>
2740
2741         Build system support for LTO
2742         https://bugs.webkit.org/show_bug.cgi?id=187785
2743         <rdar://problem/42353132>
2744
2745         Reviewed by Dan Bernstein.
2746
2747         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
2748         LTO.
2749
2750         * Configurations/Base.xcconfig:
2751         * Configurations/DebugRelease.xcconfig:
2752
2753 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
2754
2755         Pass in IsComposed flag to Event constructors
2756         https://bugs.webkit.org/show_bug.cgi?id=188720
2757         <rdar://problem/43580387>
2758
2759         Reviewed by Simon Fraser.
2760
2761         * WebView/WebPDFView.mm:
2762         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
2763         whether it's simulated or not.
2764
2765 2018-08-23  Mark Lam  <mark.lam@apple.com>
2766
2767         Move vmEntryGlobalObject() to VM from CallFrame.
2768         https://bugs.webkit.org/show_bug.cgi?id=188900
2769         <rdar://problem/43655753>
2770
2771         Reviewed by Michael Saboff.
2772
2773         * WebView/WebScriptDebugger.mm:
2774         (WebScriptDebugger::sourceParsed):
2775
2776 2018-08-23  Andy Estes  <aestes@apple.com>
2777
2778         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
2779         https://bugs.webkit.org/show_bug.cgi?id=188829
2780
2781         Reviewed by Tim Horton.
2782
2783         * Configurations/FeatureDefines.xcconfig:
2784
2785 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2786
2787         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
2788         https://bugs.webkit.org/show_bug.cgi?id=188777
2789
2790         Reviewed by Simon Fraser.
2791
2792         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
2793         being "true" before the code change.
2794
2795         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
2796
2797         * WebView/WebPDFView.mm:
2798         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2799
2800 2018-08-21  Daniel Bates  <dabates@apple.com>
2801
2802         Replace TextCheckingTypeMask with OptionSet
2803         https://bugs.webkit.org/show_bug.cgi?id=188678
2804
2805         Reviewed by Antti Koivisto.
2806
2807         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
2808         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
2809         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
2810         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
2811
2812         * WebCoreSupport/WebEditorClient.h:
2813         * WebCoreSupport/WebEditorClient.mm:
2814         (WebEditorClient::checkTextOfParagraph):
2815         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
2816         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
2817         left as this is more readable and unncessary now that modern compilers like Clang have
2818         diagnostics to catch accidental assignments when equality was intended.
2819         (WebEditorClient::didCheckSucceed):
2820         * WebView/WebView.mm:
2821         (coreTextCheckingType):
2822         (textCheckingResultFromNSTextCheckingResult):
2823
2824 2018-08-21  Daniel Bates  <dabates@apple.com>
2825
2826         [iOS][WK1] Support toggling continuous spell checking from tests
2827         https://bugs.webkit.org/show_bug.cgi?id=188763
2828
2829         Reviewed by Simon Fraser.
2830
2831         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
2832         spell checking from tests in iOS WebKit Legacy.
2833
2834         * WebCoreSupport/WebEditorClient.h:
2835         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
2836         * WebCoreSupport/WebEditorClient.mm:
2837         * WebView/WebView.h:
2838         * WebView/WebView.mm:
2839         (-[WebView toggleContinuousSpellChecking:]):
2840         (-[WebView toggleSmartInsertDelete:]):
2841
2842 2018-08-17  Alex Christensen  <achristensen@webkit.org>
2843
2844         Add some plumbing for safe browsing
2845         https://bugs.webkit.org/show_bug.cgi?id=188709
2846
2847         Reviewed by Tim Horton.
2848
2849         * WebCoreSupport/WebFrameLoaderClient.h:
2850         * WebCoreSupport/WebFrameLoaderClient.mm:
2851         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2852
2853 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
2854
2855         Replace canBubble and cancelable booleans in Event by enum classes
2856         https://bugs.webkit.org/show_bug.cgi?id=188692
2857
2858         Reviewed by Alex Christensen.
2859
2860         * WebView/WebPDFView.mm:
2861         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2862         * WebView/WebView.mm:
2863         (-[WebView _dispatchUnloadEvent]):
2864
2865 2018-08-16  Jer Noble  <jer.noble@apple.com>
2866
2867         Add Experimental Feature support for SourceBuffer.changeType()
2868         https://bugs.webkit.org/show_bug.cgi?id=188626
2869         <rdar://problem/43356021>
2870
2871         Reviewed by Eric Carlson.
2872
2873         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
2874
2875         * WebView/WebPreferenceKeysPrivate.h:
2876         * WebView/WebPreferences.mm:
2877         (+[WebPreferences initialize]):
2878         (-[WebPreferences sourceBufferChangeTypeEnabled]):
2879         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
2880         * WebView/WebPreferencesPrivate.h:
2881         * WebView/WebView.mm:
2882         (-[WebView _preferencesChanged:]):
2883
2884 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
2885
2886         Support drag-and-drop for input[type=color]
2887         https://bugs.webkit.org/show_bug.cgi?id=188464
2888
2889         Reviewed by Wenson Hsieh.
2890
2891         * WebCoreSupport/WebPlatformStrategies.h:
2892         * WebCoreSupport/WebPlatformStrategies.mm:
2893         (WebPlatformStrategies::setColor):
2894
2895 2018-08-15  Tim Horton  <timothy_horton@apple.com>
2896
2897         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
2898         https://bugs.webkit.org/show_bug.cgi?id=188569
2899         <rdar://problem/34201095>
2900
2901         Reviewed by Megan Gardner.
2902
2903         * WebView/WebImmediateActionController.mm:
2904         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2905         Speculative fix; the crashes indicate font is null, but we just checked it,
2906         so it must be getting made null by convertFont:toSize:. Check again!
2907
2908 2018-08-13  Alex Christensen  <achristensen@webkit.org>
2909
2910         Use a 1-byte enum class for TextDirection
2911         https://bugs.webkit.org/show_bug.cgi?id=188350
2912
2913         Reviewed by Simon Fraser.
2914
2915         * WebCoreSupport/PopupMenuMac.mm:
2916         (PopupMenuMac::populate):
2917         (PopupMenuMac::show):
2918         * WebCoreSupport/WebFrameLoaderClient.mm:
2919         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2920         * WebView/WebFrame.mm:
2921         (-[WebFrame _dispatchDidReceiveTitle:]):
2922
2923 2018-08-09  Ali Juma  <ajuma@chromium.org>
2924
2925         Import WPTs for IntersectionObserver
2926         https://bugs.webkit.org/show_bug.cgi?id=188416
2927
2928         Reviewed by Simon Fraser.
2929
2930         * WebView/WebPreferencesPrivate.h:
2931
2932 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
2933
2934         Follow-up build fix for r234685
2935         https://bugs.webkit.org/show_bug.cgi?id=188245
2936
2937         Unreviewed build fix.
2938
2939         * WebCoreSupport/WebSecurityOriginPrivate.h:
2940
2941 2018-08-05  Darin Adler  <darin@apple.com>
2942
2943         [Cocoa] More tweaks and refactoring to prepare for ARC
2944         https://bugs.webkit.org/show_bug.cgi?id=188245
2945
2946         Reviewed by Dan Bernstein.
2947
2948         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
2949
2950         * Carbon/CarbonWindowFrame.m:
2951         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
2952
2953         * DOM/DOM.mm:
2954         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
2955         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
2956         garbage collection so this method isn't useful.
2957
2958         * DOM/DOMXPath.mm:
2959         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
2960         Objective-C garbage collection so this method isn't useful.
2961
2962         * History/WebHistory.mm:
2963         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
2964
2965         * Misc/WebElementDictionary.mm:
2966         (addLookupKey): Use a bridging cast.
2967         (cacheValueForKey): Ditto.
2968         (-[WebElementDictionary _fillCache]): Ditto.
2969         (-[WebElementDictionary objectForKey:]): Ditto.
2970
2971         * Misc/WebKitNSStringExtras.mm:
2972         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
2973         (-[NSString _web_widthWithFont:]): Ditto.
2974         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
2975
2976         * Misc/WebLocalizableStrings.mm:
2977         (WebLocalizedString): Use a bridging cast.
2978
2979         * Misc/WebNSDataExtras.mm:
2980         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
2981         and use CFBridgingRelease instead of calling autorelease directly.
2982         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
2983         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
2984         on the amount of explicit release and autorelease.
2985
2986         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
2987         * Misc/WebNSDictionaryExtras.m:
2988         (-[NSDictionary _webkit_intForKey:]): Deleted.
2989         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
2990         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
2991         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
2992         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
2993         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
2994         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
2995
2996         * Misc/WebStringTruncator.mm:
2997         (fontFromNSFont): Use a bridging cast.
2998
2999         * Plugins/Hosted/NetscapePluginHostManager.mm:
3000         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3001
3002         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3003         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3004         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3005         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3006         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3007         * Plugins/Hosted/ProxyInstance.mm:
3008         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3009         * Plugins/WebBasePluginPackage.mm:
3010         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3011         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3012         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3013         * Plugins/WebNetscapePluginPackage.mm:
3014         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3015
3016         * Plugins/WebNetscapePluginView.mm:
3017         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3018         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3019         (-[WebNetscapePluginView status:]): Use a bridging cast.
3020         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3021
3022         * Plugins/WebPluginController.mm:
3023         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3024
3025         * Plugins/WebPluginDatabase.mm:
3026         (checkCandidate): Use explicit __strong for out argument types.
3027
3028         * Plugins/npapi.mm:
3029         (pluginViewForInstance): Use a bridging cast.
3030
3031         * Storage/WebDatabaseManager.mm:
3032         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3033         explicit NSNumber and NSDictionary calls.
3034
3035         * WebCoreSupport/WebContextMenuClient.mm:
3036         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3037
3038         * WebCoreSupport/WebEditorClient.mm:
3039         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3040         (WebEditorClient::handleInputMethodKeydown): Ditto.
3041
3042         * WebCoreSupport/WebFrameNetworkingContext.mm:
3043         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3044
3045         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3046         as a struct rather than an Objective-C class, since that's how it's defined.
3047
3048         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3049
3050         * WebView/WebFullScreenController.mm:
3051         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3052         * WebView/WebHTMLView.mm:
3053         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3054         Ditto.
3055         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3056
3057         * WebView/WebImmediateActionController.mm:
3058         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3059         go down to the document and then back to the frame.
3060         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3061         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3062         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3063
3064         * WebView/WebJSPDFDoc.mm:
3065         (jsPDFDocInitialize): Removed some unneeded type casting.
3066         (jsPDFDocFinalize): Ditto.
3067         (jsPDFDocPrint): Use a bridging cast.
3068
3069         * WebView/WebPDFView.mm:
3070         (_applicationInfoForMIMEType): Use bridging casts.
3071
3072         * WebView/WebPreferences.mm:
3073         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3074         instead of methods from WebNSDictionaryExtras.
3075         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3076         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3077         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3078         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3079         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3080
3081         * WebView/WebView.mm:
3082         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3083         (-[WebView _addToAllWebViewsSet]): Ditto.
3084         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3085         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3086         so it can be called from WebViewData methods.
3087
3088         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3089         method, _windowVisibilityChanged:.
3090
3091         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3092         called from WebViewData methods.
3093
3094 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3095
3096         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3097         https://bugs.webkit.org/show_bug.cgi?id=188323
3098
3099         Reviewed by Simon Fraser.
3100
3101         * WebCoreSupport/WebContextMenuClient.mm:
3102         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3103         * WebView/WebFrame.mm:
3104         (-[WebFrame _paintBehaviorForDestinationContext:]):
3105         (-[WebFrame _drawRect:contentsOnly:]):
3106         * WebView/WebHTMLView.mm:
3107         (imageFromRect):
3108         (selectionImage):
3109
3110 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3111
3112         Add support for microtasks in workers
3113         https://bugs.webkit.org/show_bug.cgi?id=188246
3114
3115         Reviewed by Darin Adler.
3116
3117         Rename JSMainThreadExecState.h to JSExecState.h.
3118
3119         * DOM/DOMAttr.mm:
3120         * DOM/DOMBlob.mm:
3121         * DOM/DOMCDATASection.mm:
3122         * DOM/DOMCSSCharsetRule.mm:
3123         * DOM/DOMCSSFontFaceRule.mm:
3124         * DOM/DOMCSSImportRule.mm:
3125         * DOM/DOMCSSMediaRule.mm:
3126         * DOM/DOMCSSPageRule.mm:
3127         * DOM/DOMCSSPrimitiveValue.mm:
3128         * DOM/DOMCSSRule.mm:
3129         * DOM/DOMCSSRuleList.mm:
3130         * DOM/DOMCSSStyleDeclaration.mm:
3131         * DOM/DOMCSSStyleRule.mm:
3132         * DOM/DOMCSSStyleSheet.mm:
3133         * DOM/DOMCSSUnknownRule.mm:
3134         * DOM/DOMCSSValue.mm:
3135         * DOM/DOMCSSValueList.mm:
3136         * DOM/DOMCharacterData.mm:
3137         * DOM/DOMComment.mm:
3138         * DOM/DOMCounter.mm:
3139         * DOM/DOMDocument.mm:
3140         * DOM/DOMDocumentFragment.mm:
3141         * DOM/DOMDocumentType.mm:
3142         * DOM/DOMElement.mm:
3143         * DOM/DOMEvent.mm:
3144         * DOM/DOMFile.mm:
3145         * DOM/DOMFileList.mm:
3146         * DOM/DOMHTML.mm:
3147         * DOM/DOMHTMLAnchorElement.mm:
3148         * DOM/DOMHTMLAppletElement.mm:
3149         * DOM/DOMHTMLAreaElement.mm:
3150         * DOM/DOMHTMLBRElement.mm:
3151         * DOM/DOMHTMLBaseElement.mm:
3152         * DOM/DOMHTMLBaseFontElement.mm:
3153         * DOM/DOMHTMLBodyElement.mm:
3154         * DOM/DOMHTMLButtonElement.mm:
3155         * DOM/DOMHTMLCanvasElement.mm:
3156         * DOM/DOMHTMLCollection.mm:
3157         * DOM/DOMHTMLDListElement.mm:
3158         * DOM/DOMHTMLDirectoryElement.mm:
3159         * DOM/DOMHTMLDivElement.mm:
3160         * DOM/DOMHTMLDocument.mm:
3161         * DOM/DOMHTMLElement.mm:
3162         * DOM/DOMHTMLEmbedElement.mm:
3163         * DOM/DOMHTMLFieldSetElement.mm:
3164         * DOM/DOMHTMLFontElement.mm:
3165         * DOM/DOMHTMLFormElement.mm:
3166         * DOM/DOMHTMLFrameElement.mm:
3167         * DOM/DOMHTMLFrameSetElement.mm:
3168         * DOM/DOMHTMLHRElement.mm:
3169         * DOM/DOMHTMLHeadElement.mm:
3170         * DOM/DOMHTMLHeadingElement.mm:
3171         * DOM/DOMHTMLHtmlElement.mm:
3172         * DOM/DOMHTMLIFrameElement.mm:
3173         * DOM/DOMHTMLImageElement.mm:
3174         * DOM/DOMHTMLInputElement.mm:
3175         * DOM/DOMHTMLLIElement.mm:
3176         * DOM/DOMHTMLLabelElement.mm:
3177         * DOM/DOMHTMLLegendElement.mm:
3178         * DOM/DOMHTMLLinkElement.mm:
3179         * DOM/DOMHTMLMapElement.mm:
3180         * DOM/DOMHTMLMarqueeElement.mm:
3181         * DOM/DOMHTMLMediaElement.mm:
3182         * DOM/DOMHTMLMenuElement.mm:
3183         * DOM/DOMHTMLMetaElement.mm:
3184         * DOM/DOMHTMLModElement.mm:
3185         * DOM/DOMHTMLOListElement.mm:
3186         * DOM/DOMHTMLObjectElement.mm:
3187         * DOM/DOMHTMLOptGroupElement.mm:
3188         * DOM/DOMHTMLOptionElement.mm:
3189         * DOM/DOMHTMLOptionsCollection.mm:
3190         * DOM/DOMHTMLParagraphElement.mm:
3191         * DOM/DOMHTMLParamElement.mm:
3192         * DOM/DOMHTMLPreElement.mm:
3193         * DOM/DOMHTMLQuoteElement.mm:
3194         * DOM/DOMHTMLScriptElement.mm:
3195         * DOM/DOMHTMLSelectElement.mm:
3196         * DOM/DOMHTMLStyleElement.mm:
3197         * DOM/DOMHTMLTableCaptionElement.mm:
3198         * DOM/DOMHTMLTableCellElement.mm:
3199         * DOM/DOMHTMLTableColElement.mm:
3200         * DOM/DOMHTMLTableElement.mm:
3201         * DOM/DOMHTMLTableRowElement.mm:
3202         * DOM/DOMHTMLTableSectionElement.mm:
3203         * DOM/DOMHTMLTextAreaElement.mm:
3204         * DOM/DOMHTMLTitleElement.mm:
3205         * DOM/DOMHTMLUListElement.mm:
3206         * DOM/DOMHTMLVideoElement.mm:
3207         * DOM/DOMImplementation.mm:
3208         * DOM/DOMKeyboardEvent.mm:
3209         * DOM/DOMMediaError.mm:
3210         * DOM/DOMMediaList.mm:
3211         * DOM/DOMMouseEvent.mm:
3212         * DOM/DOMMutationEvent.mm:
3213         * DOM/DOMNamedNodeMap.mm:
3214         * DOM/DOMNode.mm:
3215         * DOM/DOMNodeIterator.mm:
3216         * DOM/DOMNodeList.mm:
3217         * DOM/DOMOverflowEvent.mm:
3218         * DOM/DOMProcessingInstruction.mm:
3219         * DOM/DOMProgressEvent.mm:
3220         * DOM/DOMRGBColor.mm:
3221         * DOM/DOMRange.mm:
3222         * DOM/DOMRect.mm:
3223         * DOM/DOMStyleSheet.mm:
3224         * DOM/DOMStyleSheetList.mm:
3225         * DOM/DOMText.mm:
3226         * DOM/DOMTextEvent.mm:
3227         * DOM/DOMTimeRanges.mm:
3228         * DOM/DOMTokenList.mm:
3229         * DOM/DOMTreeWalker.mm:
3230         * DOM/DOMUIEvent.mm:
3231         * DOM/DOMWheelEvent.mm:
3232         * DOM/DOMXPathExpression.mm:
3233         * DOM/DOMXPathResult.mm:
3234         * DOM/ObjCEventListener.mm:
3235
3236 2018-08-03  Alex Christensen  <achristensen@webkit.org>
3237
3238         Fix spelling of "overridden"
3239         https://bugs.webkit.org/show_bug.cgi?id=188315
3240
3241         Reviewed by Darin Adler.
3242
3243         * Misc/WebKitVersionChecks.mm:
3244         (setWebKitLinkTimeVersion):
3245         (WebKitLinkTimeVersion):
3246         * Plugins/WebBaseNetscapePluginView.mm:
3247         (-[WebBaseNetscapePluginView handleMouseMoved:]):
3248         * WebCoreSupport/PopupMenuMac.mm:
3249         (PopupMenuMac::populate):
3250
3251 2018-08-01  Nan Wang  <n_wang@apple.com>
3252
3253         AX: AOM: Add ARIA IDL Attribute Reflection
3254         https://bugs.webkit.org/show_bug.cgi?id=184676
3255         <rdar://problem/39476882>
3256
3257         Reviewed by Chris Fleizach.
3258
3259         * WebView/WebPreferenceKeysPrivate.h:
3260         * WebView/WebPreferences.mm:
3261         (+[WebPreferences initialize]):
3262         (-[WebPreferences ariaReflectionEnabled]):
3263         (-[WebPreferences setAriaReflectionEnabled:]):
3264         * WebView/WebPreferencesPrivate.h:
3265         * WebView/WebView.mm:
3266         (-[WebView _preferencesChanged:]):
3267
3268 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
3269
3270         Shrink GraphicsLayerCA
3271         https://bugs.webkit.org/show_bug.cgi?id=188141
3272
3273         Reviewed by Zalan Bujtas.
3274
3275         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
3276         * moving all the clone-related stuff into the lazily-allocated m_layerClones
3277         * moving all the animation-related stuff into the lazily-allocated m_animations
3278         * making enums be 8-bit
3279         * re-ordering data members
3280
3281         * WebView/WebView.mm:
3282         (-[WebView _setMediaLayer:forPluginView:]):
3283
3284 2018-07-30  Rob Buis  <rbuis@igalia.com>
3285
3286         Merge PlatformCookieJar functions into NetworkStorageSession
3287         https://bugs.webkit.org/show_bug.cgi?id=188137
3288
3289         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
3290
3291         Reviewed by Alex Christensen.
3292
3293         * WebCoreSupport/WebPlatformStrategies.mm:
3294         (WebPlatformStrategies::cookiesForDOM):
3295         (WebPlatformStrategies::setCookiesFromDOM):
3296         (WebPlatformStrategies::cookiesEnabled):
3297         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3298         (WebPlatformStrategies::getRawCookies):
3299         (WebPlatformStrategies::deleteCookie):
3300         * WebView/WebPreferences.mm:
3301         (+[WebPreferences _clearNetworkLoaderSession]):
3302
3303 2018-07-28  Darin Adler  <darin@apple.com>
3304
3305         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
3306         https://bugs.webkit.org/show_bug.cgi?id=188140
3307
3308         Reviewed by Sam Weinig.
3309
3310         * WebView/WebImmediateActionController.mm:
3311         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
3312         new DictionaryLookup function that returns a tuple instead of using an out argument.
3313
3314 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
3315
3316         [INTL] Remove INTL sub-feature compile flags
3317         https://bugs.webkit.org/show_bug.cgi?id=188081
3318
3319         Reviewed by Michael Catanzaro.
3320
3321         * Configurations/FeatureDefines.xcconfig:
3322
3323 2018-07-26  Commit Queue  <commit-queue@webkit.org>
3324
3325         Unreviewed, rolling out r234181 and r234189.
3326         https://bugs.webkit.org/show_bug.cgi?id=188075
3327
3328         These are not needed right now (Requested by thorton on
3329         #webkit).
3330
3331         Reverted changesets:
3332
3333         "Enable Web Content Filtering on watchOS"
3334         https://bugs.webkit.org/show_bug.cgi?id=187979
3335         https://trac.webkit.org/changeset/234181
3336
3337         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
3338         https://bugs.webkit.org/show_bug.cgi?id=187985
3339         https://trac.webkit.org/changeset/234189
3340
3341 2018-07-26  Timothy Hatcher  <timothy@apple.com>
3342
3343         Use the Page's appearance when converting pasteboard attributed strings.
3344         https://bugs.webkit.org/show_bug.cgi?id=188067
3345         rdar://problem/42632246
3346
3347         Reviewed by Wenson Hsieh.
3348
3349         * WebCoreSupport/WebEditorClient.mm:
3350         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
3351
3352 2018-07-25  Chris Dumez  <cdumez@apple.com>
3353
3354         navigator.userAgent may return outdated value after webView.customUserAgent is set
3355         https://bugs.webkit.org/show_bug.cgi?id=188009
3356         <rdar://problem/42566456>
3357
3358         Reviewed by Alex Christensen.
3359
3360         Let the page know when the user agent changes.
3361
3362         * WebView/WebView.mm:
3363         (-[WebView _preferencesChanged:]):
3364         (-[WebView setApplicationNameForUserAgent:]):
3365         (-[WebView _invalidateUserAgentCache]):
3366         (-[WebView setCustomUserAgent:]):
3367         * WebView/WebViewInternal.h:
3368
3369 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3370
3371         Enable Web Content Filtering on watchOS
3372         https://bugs.webkit.org/show_bug.cgi?id=187979
3373         <rdar://problem/42559346>
3374
3375         Reviewed by Wenson Hsieh.
3376
3377         * Configurations/FeatureDefines.xcconfig:
3378
3379 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3380
3381         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3382         https://bugs.webkit.org/show_bug.cgi?id=187846
3383
3384         Reviewed by Simon Fraser.
3385
3386         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
3387
3388         * WebView/WebHTMLView.mm:
3389         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
3390         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
3391
3392 2018-07-11  Dean Jackson  <dino@apple.com>
3393
3394         Allow removal of white backgrounds
3395         https://bugs.webkit.org/show_bug.cgi?id=187574
3396         <rdar://problem/41146792>
3397
3398         Reviewed by Simon Fraser.
3399
3400         Add a new WebPreference for punching out white backgrounds.
3401
3402         * WebView/WebPreferenceKeysPrivate.h:
3403         * WebView/WebPreferences.mm:
3404         (+[WebPreferences initialize]):
3405         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
3406         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
3407         * WebView/WebPreferencesPrivate.h:
3408         * WebView/WebView.mm:
3409         (-[WebView _preferencesChanged:]):
3410
3411 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
3412
3413         Ensure WebKit stack is ad-hoc signed
3414         https://bugs.webkit.org/show_bug.cgi?id=187667
3415
3416         Reviewed by Alexey Proskuryakov.
3417
3418         * Configurations/Base.xcconfig:
3419
3420 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
3421
3422         REGRESSION (231276): Attempting to copy an image fails
3423         https://bugs.webkit.org/show_bug.cgi?id=187212
3424         <rdar://problem/41540074>
3425
3426         Reviewed by Ryosuke Niwa.
3427
3428         Renamed methods to make it clear that one URL and one title are being passed in.
3429
3430         * WebCoreSupport/WebPlatformStrategies.h:
3431         * WebCoreSupport/WebPlatformStrategies.mm:
3432         (WebPlatformStrategies::setURL):
3433
3434 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
3435
3436         Disable cross-origin-window-policy by default
3437         https://bugs.webkit.org/show_bug.cgi?id=187509
3438
3439         Reviewed by Chris Dumez.
3440
3441         * WebView/WebPreferences.mm:
3442         (+[WebPreferences initialize]):
3443
3444 2018-07-09  Timothy Hatcher  <timothy@apple.com>
3445
3446         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3447         https://bugs.webkit.org/show_bug.cgi?id=187425
3448         rdar://problem/39948240
3449
3450         Reviewed by Tim Horton.
3451
3452         * WebView/WebView.mm:
3453         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3454         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3455         a call in this method to setUseDarkAppearance.
3456         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3457         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3458         (-[WebView _updateDefaultAppearance]): Deleted.
3459         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3460
3461 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
3462
3463         Shrink various loading-related enums to shrink CachedResource
3464         https://bugs.webkit.org/show_bug.cgi?id=187443
3465
3466         Reviewed by Chris Dumez.
3467
3468         * WebCoreSupport/WebFrameLoaderClient.mm:
3469         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3470         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
3471         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3472         (WebFrameLoaderClient::dispatchWillSendRequest):
3473         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3474         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3475         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3476         (WebFrameLoaderClient::updateGlobalHistory):
3477         (WebFrameLoaderClient::canHandleRequest const):
3478         * WebView/WebDataSource.mm:
3479         (-[WebDataSource initialRequest]):
3480         (-[WebDataSource request]):
3481
3482 2018-07-09  Commit Queue  <commit-queue@webkit.org>
3483
3484         Unreviewed, rolling out r233612.
3485         https://bugs.webkit.org/show_bug.cgi?id=187475
3486
3487         Revision caused the api test LinkColorWithSystemAppearance to
3488         fail on all systems. (Requested by Truitt on #webkit).
3489
3490         Reverted changeset:
3491
3492         "Semantic colors don't update when accessibility Increase
3493         Contrast mode is enabled."
3494         https://bugs.webkit.org/show_bug.cgi?id=187425
3495         https://trac.webkit.org/changeset/233612
3496
3497 2018-07-06  Timothy Hatcher  <timothy@apple.com>
3498
3499         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3500         https://bugs.webkit.org/show_bug.cgi?id=187425
3501         rdar://problem/39948240
3502
3503         Reviewed by Tim Horton.
3504
3505         * WebView/WebView.mm:
3506         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3507         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3508         a call in this method to setUseDarkAppearance.
3509         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3510         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3511         (-[WebView _updateDefaultAppearance]): Deleted.
3512         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3513
3514 2018-07-05  Timothy Hatcher  <timothy@apple.com>
3515
3516         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
3517         https://bugs.webkit.org/show_bug.cgi?id=187369
3518         rdar://problem/41870420
3519
3520         Reviewed by Tim Horton.
3521
3522         * WebView/WebMediaPlaybackTargetPicker.mm:
3523         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
3524         * WebView/WebView.mm:
3525         (-[WebView _commonInitializationWithFrameName:groupName:]):
3526         (-[WebView _effectiveAppearanceIsDark]):
3527         (-[WebView _updateDefaultAppearance]):
3528         (-[WebView _defaultAppearance]): Deleted.
3529
3530 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
3531
3532         Youtube video pages crash after a couple of minutes
3533         https://bugs.webkit.org/show_bug.cgi?id=187316
3534
3535         Reviewed by Antti Koivisto.
3536
3537         * WebView/WebView.mm:
3538         (-[WebView _preferencesChanged:]):
3539
3540 2018-07-04  Tim Horton  <timothy_horton@apple.com>
3541
3542         Introduce PLATFORM(IOSMAC)
3543         https://bugs.webkit.org/show_bug.cgi?id=187315
3544
3545         Reviewed by Dan Bernstein.
3546
3547         * Configurations/Base.xcconfig:
3548         * Configurations/FeatureDefines.xcconfig:
3549
3550 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3551
3552         [iOS] DataTransfer.getData always returns the empty string when dropping text
3553         https://bugs.webkit.org/show_bug.cgi?id=187130
3554         <rdar://problem/41014117>
3555
3556         Reviewed by Ryosuke Niwa.
3557
3558         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
3559
3560         * WebCoreSupport/WebPlatformStrategies.h:
3561         * WebCoreSupport/WebPlatformStrategies.mm:
3562         (WebPlatformStrategies::allPasteboardItemInfo):
3563
3564 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
3565
3566         [Mac] AirPlay picker uses incorrect theme in Dark mode
3567         https://bugs.webkit.org/show_bug.cgi?id=187054
3568         <rdar://problem/41291093>
3569
3570         Reviewed by Timothy Hatcher.
3571
3572         * WebView/WebMediaPlaybackTargetPicker.mm:
3573         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
3574
3575 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3576
3577         [WTF] Add user-defined literal for ASCIILiteral
3578         https://bugs.webkit.org/show_bug.cgi?id=186839
3579
3580         Reviewed by Darin Adler.
3581
3582         * DOM/ExceptionHandlers.mm:
3583         (raiseDOMErrorException):
3584         * Plugins/Hosted/ProxyInstance.mm:
3585         (WebKit::ProxyInstance::invokeMethod):
3586         * Storage/WebDatabaseProvider.mm:
3587         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
3588
3589 2018-06-22  Timothy Hatcher  <timothy@apple.com>
3590
3591         Recalc styles every time defaultAppearance changes.
3592         https://bugs.webkit.org/show_bug.cgi?id=186866
3593         rdar://problem/41309805
3594
3595         Reviewed by Tim Horton.
3596
3597         * WebView/WebView.mm:
3598         (-[WebView _updateDefaultAppearance]):
3599         (-[WebView _setUseSystemAppearance:]):
3600         (-[WebView _useSystemAppearance]):
3601
3602 2018-06-20  Darin Adler  <darin@apple.com>
3603
3604         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
3605         https://bugs.webkit.org/show_bug.cgi?id=186875
3606
3607         Reviewed by Anders Carlsson.
3608
3609         * WebView/WebHTMLView.mm:
3610         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
3611         to write te file to.
3612         * WebView/WebPreferences.mm:
3613         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
3614         * WebView/WebView.mm:
3615         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
3616
3617 2018-06-12  Darin Adler  <darin@apple.com>
3618
3619         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
3620         https://bugs.webkit.org/show_bug.cgi?id=186526
3621
3622         Reviewed by Anders Carlsson.
3623
3624         * Plugins/Hosted/NetscapePluginHostManager.mm:
3625         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
3626
3627         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3628         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
3629         assignment rather than adoptNS/leakRef.
3630         * Plugins/WebNetscapePluginView.mm:
3631         (-[WebNetscapePluginView createPlugin]): Ditto.
3632
3633         * WebCoreSupport/WebContextMenuClient.mm:
3634         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
3635         RetainPtr::autorelease; no need to autorelease just to pass something as a function
3636         argument, so use RetainPtr::get instead.
3637
3638         * WebView/WebHTMLView.mm:
3639         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
3640         No need to autorelease the result when the return type is RetainPtr.
3641
3642         * WebView/WebPDFRepresentation.mm:
3643         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
3644
3645 2018-06-13  Youenn Fablet  <youenn@apple.com>
3646
3647         Supported plugin check should be based on plugin identifier
3648         https://bugs.webkit.org/show_bug.cgi?id=186578
3649         <rdar://problem/40523828>
3650
3651         Reviewed by Darin Adler.
3652
3653         * WebCoreSupport/WebPluginInfoProvider.h:
3654         * WebCoreSupport/WebPluginInfoProvider.mm:
3655         (WebPluginInfoProvider::pluginInfo):
3656         (WebPluginInfoProvider::webVisiblePluginInfo):
3657
3658 2018-06-13  Chris Dumez  <cdumez@apple.com>
3659
3660         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
3661         https://bugs.webkit.org/show_bug.cgi?id=186545
3662
3663         Reviewed by Brady Eidson.
3664
3665         Update client delegate now that parameter type has changed.
3666
3667         * WebCoreSupport/WebFrameLoaderClient.h:
3668         * WebCoreSupport/WebFrameLoaderClient.mm:
3669         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3670
3671 2018-06-11  Tim Horton  <timothy_horton@apple.com>
3672
3673         Link drag image is inconsistently unreadable in dark mode
3674         https://bugs.webkit.org/show_bug.cgi?id=186472
3675
3676         Reviewed by Timothy Hatcher.
3677
3678         * WebView/WebView.mm:
3679         (-[WebView _defaultAppearance]):
3680         Make defaultAppearance accurate even if useSystemAppearance is false.
3681         Some parts of WebKit (like the link drag image, but also context menus)
3682         want to be able to follow the system appearance regardless of whether
3683         the view or content has opted in.
3684
3685 2018-06-11  Chris Dumez  <cdumez@apple.com>
3686
3687         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
3688         https://bugs.webkit.org/show_bug.cgi?id=186441
3689
3690         Reviewed by Brady Eidson.
3691
3692         Rename existing flag to something a bit more generic, now that it is used for
3693         more things than bypassing the navigation policy check.
3694
3695         * WebView/WebView.mm:
3696         (-[WebView _loadBackForwardListFromOtherView:]):
3697         (-[WebView goToBackForwardItem:]):
3698
3699 2018-06-09  Dan Bernstein  <mitz@apple.com>
3700
3701         [Xcode] Clean up and modernize some build setting definitions
3702         https://bugs.webkit.org/show_bug.cgi?id=186463
3703
3704         Reviewed by Sam Weinig.
3705
3706         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
3707         * Configurations/DebugRelease.xcconfig: Ditto.
3708         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
3709           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
3710         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
3711         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
3712           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
3713         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
3714
3715 2018-06-08  Darin Adler  <darin@apple.com>
3716
3717         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
3718         https://bugs.webkit.org/show_bug.cgi?id=186436
3719
3720         Reviewed by Anders Carlsson.
3721
3722         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
3723         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
3724         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
3725         (PoolCleaner): Ditto.
3726
3727         * History/WebHistory.mm:
3728         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3729         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
3730         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
3731         now hardly used if at all.
3732         * WebView/WebView.mm:
3733         (-[WebView rectsForTextMatches]): Ditto.
3734
3735 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3736
3737         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
3738         https://bugs.webkit.org/show_bug.cgi?id=186442
3739         <rdar://problem/40879364>
3740
3741         Reviewed by Tim Horton.
3742
3743         * Configurations/FeatureDefines.xcconfig:
3744
3745 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
3746
3747         [Datalist] Allow TextFieldInputType to show and hide suggestions
3748         https://bugs.webkit.org/show_bug.cgi?id=186151
3749
3750         Reviewed by Tim Horton.
3751
3752         * WebCoreSupport/WebChromeClient.h:
3753         * WebCoreSupport/WebChromeClient.mm:
3754         (WebChromeClient::createDataListSuggestionPicker):
3755
3756 2018-06-07  Chris Dumez  <cdumez@apple.com>
3757
3758         Add base class to get WeakPtrFactory member and avoid some boilerplate code
3759         https://bugs.webkit.org/show_bug.cgi?id=186407
3760
3761         Reviewed by Brent Fulgham.
3762
3763         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
3764         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
3765         This also gets rid of old-style createWeakPtr() methods in favor of the newer
3766         makeWeakPtr().
3767
3768         * WebCoreSupport/WebEditorClient.h:
3769         * WebCoreSupport/WebEditorClient.mm:
3770         (WebEditorClient::requestCandidatesForSelection):
3771
3772 2018-06-05  Chris Dumez  <cdumez@apple.com>
3773
3774         Regression(r232082): Websites get loaded inside of Messages App chat transcript
3775         https://bugs.webkit.org/show_bug.cgi?id=186331
3776         <rdar://problem/40735446>
3777
3778         Reviewed by Darin Adler.
3779
3780         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
3781         but does not call use / ignore on the listener, then we would do "use" by default.
3782         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
3783         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
3784         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
3785         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
3786         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
3787         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
3788         and Box.app is still working properly.
3789
3790         * WebCoreSupport/WebFrameLoaderClient.h:
3791         * WebCoreSupport/WebFrameLoaderClient.mm:
3792         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3793         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3794         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3795         (WebFrameLoaderClient::dispatchWillSubmitForm):
3796         (WebFrameLoaderClient::setUpPolicyListener):
3797         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
3798         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
3799         (-[WebFramePolicyListener dealloc]):
3800         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
3801         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
3802
3803 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3804
3805         Adjust compile and runtime flags to match shippable state of features
3806         https://bugs.webkit.org/show_bug.cgi?id=186319
3807         <rdar://problem/40352045>
3808
3809         Reviewed by Maciej Stachowiak, Jon Lee, and others.
3810
3811         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
3812         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
3813         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
3814         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
3815         Cocoa builds.
3816
3817 2018-06-05  Timothy Hatcher  <timothy@apple.com>
3818
3819         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
3820
3821         https://bugs.webkit.org/show_bug.cgi?id=186323
3822         rdar://problem/38382252
3823
3824         Reviewed by Tim Horton.
3825
3826         * WebView/WebView.mm:
3827         (-[WebView _defaultAppearance]):
3828
3829 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3830
3831         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
3832         https://bugs.webkit.org/show_bug.cgi?id=186286
3833         <rdar://problem/40782992>
3834
3835         Reviewed by Dan Bernstein.
3836
3837         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
3838         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
3839         change this flag when preparing for a production release.
3840
3841         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
3842         whether experimental features should be enabled, and use it to properly define the
3843         feature flag.
3844
3845 2018-06-03  Darin Adler  <darin@apple.com>
3846
3847         Simplify and remove some unused video element code (helpful for ARC-compatibility)
3848         https://bugs.webkit.org/show_bug.cgi?id=186258
3849
3850         Reviewed by Daniel Bates.
3851
3852         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
3853         forward declarations. Removed methods that don't need to be public.
3854
3855         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
3856         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
3857         unnamed category in here and also replaced the HUDWindowControllerDelegate
3858         with the unnamed category. Removed unused NSWindow category defining the
3859         isOnActiveSpace, which is not called anywhere in this file at this time.
3860         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
3861         into setVideoElement.
3862         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
3863         and removed unneeded typecast.
3864         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
3865         using statement at the top of the file.
3866         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
3867         the many side effects and special considerations that this method that sounds
3868         like a setter has. Updated code to use the new
3869         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
3870         HTMLVideoElement::platformMedia function. Also straightened out the logic a
3871         bit and added some FIXME comments about small problems noticed but not fixed.
3872         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
3873         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
3874         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
3875         typecast. Removed call to updatePowerAssertions method.
3876         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
3877         updatePowerAssertions method.
3878         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
3879         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
3880         else, so this was dead code that did nothing.
3881         (-[WebVideoFullscreenController rateChanged:]): Removed call to
3882         updatePowerAssertions method.
3883
3884 2018-06-04  Chris Dumez  <cdumez@apple.com>
3885
3886         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
3887         https://bugs.webkit.org/show_bug.cgi?id=186287
3888         <rdar://problem/40783352>
3889
3890         Reviewed by Youenn Fablet.
3891
3892         * WebView/WebPreferenceKeysPrivate.h:
3893         * WebView/WebPreferences.mm:
3894         (+[WebPreferences initialize]):
3895         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
3896         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
3897         * WebView/WebPreferencesPrivate.h:
3898         * WebView/WebView.mm:
3899         (-[WebView _preferencesChanged:]):
3900
3901 2018-06-02  Darin Adler  <darin@apple.com>
3902
3903         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
3904         https://bugs.webkit.org/show_bug.cgi?id=186227
3905
3906         Reviewed by Dan Bernstein.
3907
3908         * Misc/WebKitErrors.m:
3909         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
3910         * Plugins/WebPluginDatabase.mm:
3911         (-[WebPluginDatabase refresh]): Ditto.
3912         * WebCoreSupport/WebChromeClient.mm:
3913         (WebChromeClient::setStatusbarText): Ditto.
3914
3915 2018-06-01  Chris Dumez  <cdumez@apple.com>
3916
3917         REGRESSION (r231456): Colloquy is broken
3918         https://bugs.webkit.org/show_bug.cgi?id=186197
3919         <rdar://problem/40722960>
3920
3921         Reviewed by Timothy Hatcher.
3922
3923         Restore pre-r231456 behavior for Colloquy app so that it works again.
3924
3925         * WebView/WebView.mm:
3926         (-[WebView _needsFrameNameFallbackToIdQuirk]):
3927         (-[WebView _preferencesChanged:]):
3928
3929 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
3930
3931         [JSC] Pass VM& parameter as much as possible
3932         https://bugs.webkit.org/show_bug.cgi?id=186085
3933
3934         Reviewed by Saam Barati.
3935
3936         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3937         (WebKit::NetscapePluginInstanceProxy::invoke):
3938
3939 2018-05-30  Daniel Bates  <dabates@apple.com>
3940
3941         NavigationAction does not need to hold initiating DOM Event
3942         https://bugs.webkit.org/show_bug.cgi?id=185958
3943         <rdar://problem/40531539>
3944
3945         Reviewed by Simon Fraser.
3946
3947         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
3948
3949         * WebCoreSupport/WebFrameLoaderClient.mm:
3950         (WebFrameLoaderClient::actionDictionary const):
3951         (findMouseEvent): Deleted.
3952
3953 2018-05-27  Dan Bernstein  <mitz@apple.com>
3954
3955         Reverted the changes made for https://webkit.org/b/186016
3956
3957         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
3958
3959
3960 2018-05-27  David Kilzer  <ddkilzer@apple.com>
3961
3962         [iOS] Fix warnings about leaks found by clang static analyzer
3963         <https://webkit.org/b/186009>
3964         <rdar://problem/40574267>
3965
3966         Reviewed by Daniel Bates.
3967
3968         * WebView/WebHTMLView.mm:
3969         (-[WebHTMLView doCommandBySelector:]): Fix use of an
3970         uninitialized boolean variable (`eventWasHandled`) that only
3971         happened on iOS.
3972
3973 2018-05-27  Dan Bernstein  <mitz@apple.com>
3974
3975         [Cocoa] Avoid importing directly from subumbrella frameworks
3976         https://bugs.webkit.org/show_bug.cgi?id=186016
3977
3978         Reviewed by Sam Weinig.
3979
3980         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
3981         * Carbon/CarbonWindowAdapter.mm: Ditto.
3982         * Carbon/CarbonWindowFrame.m: Ditto.
3983         * Carbon/HIViewAdapter.h: Ditto.
3984         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
3985           OTHER_CPLUSPLUSFLAGS.
3986         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
3987         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
3988         * WebView/WebPDFView.h: Ditto.
3989
3990 2018-05-27  Sam Weinig  <sam@webkit.org>
3991
3992         Modernize RenderStyleConstants.h - Part 3
3993         https://bugs.webkit.org/show_bug.cgi?id=186015
3994
3995         Reviewed by Yusuke Suzuki.
3996
3997         * WebView/WebView.mm:
3998         (-[WebView updateTextTouchBar]):
3999         Update for new enum name.
4000
4001 2018-05-25  Chris Dumez  <cdumez@apple.com>
4002
4003         Minor ApplicationCacheStorage clean up
4004         https://bugs.webkit.org/show_bug.cgi?id=185984
4005
4006         Reviewed by Youenn Fablet.
4007
4008         * WebCoreSupport/WebApplicationCache.mm:
4009         (+[WebApplicationCache originsWithCache]):
4010
4011 2018-05-25  David Kilzer  <ddkilzer@apple.com>
4012
4013         Fix issues with -dealloc methods found by clang static analyzer
4014         <https://webkit.org/b/185887>
4015
4016         Reviewed by Joseph Pecoraro.
4017
4018         * WebView/WebView.mm:
4019         (-[WebUITextIndicatorData dealloc]):
4020         - Move method implementation from (WebUITextIndicatorInternal)
4021           category to the main category since this is public API.  This
4022           fixes the false positive warning about a missing -dealloc
4023           method.
4024
4025 2018-05-24  Sam Weinig  <sam@webkit.org>
4026
4027         Modernize RenderStyleConstants.h - Part 2
4028         https://bugs.webkit.org/show_bug.cgi?id=185901
4029
4030         Reviewed by Simon Fraser.
4031
4032         * WebView/WebHTMLRepresentation.mm:
4033         (searchForLabelsBeforeElement):
4034         * WebView/WebView.mm:
4035         (nsTextAlignmentFromRenderStyle):
4036         Update for new enum names.
4037
4038 2018-05-22  Chris Dumez  <cdumez@apple.com>
4039
4040         Regression(AsyncPolicyDelegates): Box.app login Window is blank
4041         https://bugs.webkit.org/show_bug.cgi?id=185832
4042         <rdar://problem/40307871>
4043
4044         Reviewed by Geoffrey Garen.
4045
4046         We used to have a bug where where we would fail to wait for the policy decision for
4047         the navigation response from the client and the load would keep going, racing with
4048         the client's policy decision. If the client did not respond in time, the behavior
4049         would be the