Address post-review feedback after r238438
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Address post-review feedback after r238438
4         https://bugs.webkit.org/show_bug.cgi?id=191913
5
6         Reviewed by Ryosuke Niwa.
7
8         * WebView/WebFrame.mm:
9         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
10         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
11         * WebView/WebView.mm:
12         (-[WebView setSelectedDOMRange:affinity:]):
13
14 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
15
16         Web Inspector: "Reload Web Inspector" button no longer partially works
17         https://bugs.webkit.org/show_bug.cgi?id=191773
18         <rdar://problem/46139932>
19
20         Reviewed by Devin Rousso.
21
22         * WebCoreSupport/WebInspectorClient.h:
23         * WebCoreSupport/WebInspectorClient.mm:
24         (WebInspectorFrontendClient::reopen):
25
26 2018-11-17  Devin Rousso  <drousso@apple.com>
27
28         Web Inspector: Network: add button to show system certificate dialog
29         https://bugs.webkit.org/show_bug.cgi?id=191458
30         <rdar://problem/45977019>
31
32         Reviewed by Joseph Pecoraro.
33
34         * WebCoreSupport/WebInspectorClient.h:
35         * WebCoreSupport/WebInspectorClient.mm:
36         (WebInspectorFrontendClient::showCertificate): Added.
37
38         * Configurations/WebKitLegacy.xcconfig:
39
40 2018-11-15  Truitt Savell  <tsavell@apple.com>
41
42         Unreviewed, rolling out r238244.
43
44         Caused High Sierra test runs to fail early with 50 crashes and
45         casued 25 API failures.
46
47         Reverted changeset:
48
49         "[css-logical] Implement flow-relative margin, padding and
50         border shorthands"
51         https://bugs.webkit.org/show_bug.cgi?id=188697
52         https://trac.webkit.org/changeset/238244
53
54 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
55
56         [css-logical] Implement flow-relative margin, padding and border shorthands
57         https://bugs.webkit.org/show_bug.cgi?id=188697
58
59         Reviewed by Simon Fraser and Antti Koivisto.
60
61         Add CSSLogicalEnabled runtime flag.
62
63         * WebView/WebPreferenceKeysPrivate.h:
64         * WebView/WebPreferences.mm:
65         (+[WebPreferences initialize]):
66         (-[WebPreferences cssLogicalEnabled]):
67         (-[WebPreferences setCSSLogicalEnabled:]):
68         * WebView/WebPreferencesPrivate.h:
69         * WebView/WebView.mm:
70         (-[WebView _preferencesChanged:]):
71
72 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
73
74         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
75         https://bugs.webkit.org/show_bug.cgi?id=191612
76
77         Reviewed by Matt Baker.
78
79         * WebCoreSupport/WebInspectorClient.mm:
80         (-[WebInspectorWindowController destroyInspectorView]):
81
82 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
83
84         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
85         https://bugs.webkit.org/show_bug.cgi?id=191494
86         <rdar://problem/45469854>
87
88         Reviewed by Devin Rousso.
89
90         * WebCoreSupport/WebInspectorClient.h:
91         WebKitLegacy will still have remote inspection of the Page directly.
92
93 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
94
95         Make compositing updates incremental
96         https://bugs.webkit.org/show_bug.cgi?id=90342
97
98         Reviewed by Antti Koivisto.
99
100         Fix spelling error.
101
102         * WebView/WebView.mm:
103         (-[WebView _setMediaLayer:forPluginView:]):
104
105 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
106
107         Implement a new edit command to change the enclosing list type
108         https://bugs.webkit.org/show_bug.cgi?id=191487
109         <rdar://problem/45955922>
110
111         Reviewed by Ryosuke Niwa.
112
113         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
114
115         * WebCoreSupport/WebEditorClient.mm:
116         (undoNameForEditAction):
117
118 2018-11-11  Daniel Bates  <dabates@apple.com>
119
120         [iOS] Draw caps lock indicator in password fields
121         https://bugs.webkit.org/show_bug.cgi?id=190565
122         <rdar://problem/45262343>
123
124         Reviewed by Dean Jackson.
125
126         Update the caps lock state when a hardware keyboard is attached or detached.
127
128         * WebView/WebHTMLView.mm:
129         (hardwareKeyboardAvailabilityChangedCallback): Added.
130         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
131         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
132
133 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
134
135         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
136         https://bugs.webkit.org/show_bug.cgi?id=191492
137
138         Reviewed by Alex Christensen.
139
140         * Carbon/HIWebView.mm:
141         * Misc/WebNSFileManagerExtras.mm:
142         * Misc/WebNSURLExtras.mm:
143         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
144         * Plugins/WebBasePluginPackage.mm:
145         * Plugins/WebPluginContainerCheck.mm:
146         * WebCoreSupport/WebCachedFramePlatformData.h:
147         * WebCoreSupport/WebDeviceOrientationClient.mm:
148         * WebView/WebDelegateImplementationCaching.mm:
149         * WebView/WebHTMLView.mm:
150         * WebView/WebPDFRepresentation.mm:
151         * WebView/WebPolicyDelegate.mm:
152         * WebView/WebView.mm:
153
154 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
155
156         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
157         https://bugs.webkit.org/show_bug.cgi?id=191492
158
159         Reviewed by Alex Christensen.
160
161         * Carbon/HIWebView.mm:
162         (UpdateCommandStatus):
163         * Misc/WebNSFileManagerExtras.mm:
164         * Misc/WebNSURLExtras.mm:
165         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
166         * Plugins/WebBasePluginPackage.mm:
167         * Plugins/WebPluginContainerCheck.mm:
168         (-[WebPluginContainerCheck _continueWithPolicy:]):
169         * WebCoreSupport/WebCachedFramePlatformData.h:
170         (WebCachedFramePlatformData::clear):
171         * WebCoreSupport/WebDeviceOrientationClient.mm:
172         (WebDeviceOrientationClient::getProvider const):
173         * WebView/WebDelegateImplementationCaching.mm:
174         (CallDelegate):
175         (CallDelegateReturningBoolean):
176         (CallResourceLoadDelegateReturningBoolean):
177         (CallFormDelegate):
178         (CallFormDelegateReturningBoolean):
179         * WebView/WebHTMLView.mm:
180         * WebView/WebPDFRepresentation.mm:
181         * WebView/WebPolicyDelegate.mm:
182         (-[WebPolicyDecisionListener _usePolicy:]):
183         * WebView/WebView.mm:
184
185 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
186
187         Unreviewed, rolling out r238047.
188
189         Introduced layout test failures on iOS simulator.
190
191         Reverted changeset:
192
193         "[iOS] Draw caps lock indicator in password fields"
194         https://bugs.webkit.org/show_bug.cgi?id=190565
195         https://trac.webkit.org/changeset/238047
196
197 2018-11-09  Antti Koivisto  <antti@apple.com>
198
199         Use OptionSet for layout milestones
200         https://bugs.webkit.org/show_bug.cgi?id=191470
201
202         Reviewed by Dean Jackson.
203
204         * WebCoreSupport/WebFrameLoaderClient.h:
205         * WebCoreSupport/WebFrameLoaderClient.mm:
206         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
207         * WebView/WebView.mm:
208         (coreLayoutMilestones):
209         (kitLayoutMilestones):
210         (-[WebView _cacheFrameLoadDelegateImplementations]):
211         * WebView/WebViewInternal.h:
212
213 2018-11-09  Daniel Bates  <dabates@apple.com>
214
215         [iOS] Draw caps lock indicator in password fields
216         https://bugs.webkit.org/show_bug.cgi?id=190565
217         <rdar://problem/45262343>
218
219         Reviewed by Dean Jackson.
220
221         Update the caps lock state when a hardware keyboard is attached or detached.
222
223         * WebView/WebHTMLView.mm:
224         (hardwareKeyboardAvailabilityChangedCallback): Added.
225         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
226         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
227
228 2018-11-09  Daniel Bates  <dabates@apple.com>
229
230         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
231         action when forward delete is pressed outside a text field
232         https://bugs.webkit.org/show_bug.cgi?id=190566
233         <rdar://problem/45262367>
234
235         Reviewed by Wenson Hsieh.
236
237         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
238         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
239         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
240
241         * WebView/WebHTMLView.mm:
242         (-[WebHTMLView _handleEditingKeyEvent:]):
243
244 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
245
246         Adopt Reveal Framework to replace Lookup
247         https://bugs.webkit.org/show_bug.cgi?id=191097
248         <rdar://problem/45924508>
249
250         Reviewed by Tim Horton.
251
252         Pass in what it needed to clear the textIndicators. This is better than
253         the current notification structure.
254
255         * WebView/WebView.mm:
256         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
257         (-[WebView _prepareForDictionaryLookup]):
258
259 2018-11-06  Justin Fan  <justin_fan@apple.com>
260
261         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
262         https://bugs.webkit.org/show_bug.cgi?id=191291
263
264         Reviewed by Myles Maxfield.
265
266         Properly disable WEBGPU on all non-Metal platforms for now.
267
268         * Configurations/FeatureDefines.xcconfig:
269
270 2018-11-02  Daniel Bates  <dabates@apple.com>
271
272         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
273         https://bugs.webkit.org/show_bug.cgi?id=190487
274
275         Reviewed by Tim Horton.
276
277         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
278         allow the default handling.
279
280         * WebView/WebHTMLView.mm:
281         (-[WebHTMLView _handleEditingKeyEvent:]):
282
283 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
284
285         Add a storage limit for IndexedDB
286         https://bugs.webkit.org/show_bug.cgi?id=190598
287         <rdar://problem/44654715>
288
289         Reviewed by Chris Dumez.
290
291         * Storage/WebDatabaseManager.mm:
292         (-[WebDatabaseManager setIDBPerOriginQuota:]):
293         * Storage/WebDatabaseManagerPrivate.h:
294
295 2018-10-31  Antti Koivisto  <antti@apple.com>
296
297         Remove LayerFlushScheduler
298         https://bugs.webkit.org/show_bug.cgi?id=191103
299
300         Reviewed by Anders Carlsson.
301
302         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
303         all the virtual cruft.
304
305         * WebView/WebViewData.h:
306         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
307         (): Deleted.
308         * WebView/WebViewData.mm:
309         (currentRunLoop):
310         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
311         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
312         (WebViewLayerFlushScheduler::schedule):
313         (WebViewLayerFlushScheduler::invalidate):
314         (WebViewLayerFlushScheduler::layerFlushCallback):
315
316 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
317
318         Enable InstallAPI for iOS unconditionally
319         https://bugs.webkit.org/show_bug.cgi?id=191043
320         rdar://problem/32728423
321
322         Reviewed by Dan Bernstein.
323
324         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
325         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
326         shouldn't be processed by InstallAPI.
327         * MigrateHeaders.make: Removed an obsolete workaround.
328         * Misc/NSURLDownloadSPI.h: Added.
329         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
330
331 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
332
333         Clean up some obsolete MAX_ALLOWED macros
334         https://bugs.webkit.org/show_bug.cgi?id=190916
335
336         Reviewed by Tim Horton.
337
338         * WebView/WebHTMLView.mm:
339         (-[WebHTMLView pressureChangeWithEvent:]):
340         * WebView/WebPDFView.h:
341
342 2018-10-30  Commit Queue  <commit-queue@webkit.org>
343
344         Unreviewed, rolling out r237600 and r237604.
345         https://bugs.webkit.org/show_bug.cgi?id=191086
346
347         Breaks internal iOS builds (Requested by ryanhadd_ on
348         #webkit).
349
350         Reverted changesets:
351
352         "Enable InstallAPI for iOS unconditionally"
353         https://bugs.webkit.org/show_bug.cgi?id=191043
354         https://trac.webkit.org/changeset/237600
355
356         "Build fix attempt after enabling InstallAPI for iOS."
357         https://bugs.webkit.org/show_bug.cgi?id=191043
358         https://trac.webkit.org/changeset/237604
359
360 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
361
362         Enable InstallAPI for iOS unconditionally
363         https://bugs.webkit.org/show_bug.cgi?id=191043
364         rdar://problem/32728423
365
366         Reviewed by Dan Bernstein.
367
368         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
369         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
370         shouldn't be processed by InstallAPI.
371         * MigrateHeaders.make: Removed an obsolete workaround.
372         * Misc/NSURLDownloadSPI.h: Added.
373         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
374
375 2018-10-29  Tim Horton  <timothy_horton@apple.com>
376
377         Modernize WebKit nibs and lprojs for localization's sake
378         https://bugs.webkit.org/show_bug.cgi?id=190911
379         <rdar://problem/45349466>
380
381         Reviewed by Dan Bernstein.
382
383         * Misc/WebNSControlExtras.m:
384         (-[NSControl sizeToFitAndAdjustWindowHeight]):
385         NSWindow and its contents are both in the same scale space these days; avoid
386         double-applying the scale factor, or you can't see the prompt.
387
388         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
389         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
390         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
391         NIB->XIB
392
393 2018-10-25  Antoine Quint  <graouts@apple.com>
394
395         [Web Animations] Turn Web Animations CSS Integration off by default
396         https://bugs.webkit.org/show_bug.cgi?id=190901
397
398         Reviewed by Dean Jackson.
399
400         * WebView/WebPreferences.mm:
401         (+[WebPreferences initialize]):
402
403 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
404
405         Clean up some obsolete macOS version guards
406         https://bugs.webkit.org/show_bug.cgi?id=190887
407
408         Reviewed by Dan Bernstein.
409
410         * Misc/WebNSPasteboardExtras.mm:
411         (+[NSPasteboard _web_dragTypesForURL]):
412         * WebCoreSupport/PopupMenuMac.mm:
413         (PopupMenuMac::show):
414         * WebCoreSupport/WebEditorClient.h:
415         * WebCoreSupport/WebEditorClient.mm:
416         (WebEditorClient::respondToChangedSelection):
417         * WebView/WebPDFView.mm:
418         (-[WebPDFView _clipViewForPDFDocumentView]):
419
420 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
421
422         Turn on Conic Gradients
423         https://bugs.webkit.org/show_bug.cgi?id=190810
424
425         Reviewed by Tim Horton.
426
427         * Configurations/FeatureDefines.xcconfig:
428
429 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
430
431         Cleanup: MIMETypeRegistry functions
432         https://bugs.webkit.org/show_bug.cgi?id=190838
433
434         Reviewed by Simon Fraser.
435
436         * Misc/WebNSPasteboardExtras.mm:
437         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
438         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
439         because they were identical.
440
441         * WebView/WebHTMLRepresentation.mm:
442         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
443         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
444         (+[WebHTMLRepresentation supportedImageMIMETypes]):
445         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
446         * WebView/WebView.mm:
447         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
448         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
449         (+[WebView registerViewClass:representationClass:forMIMEType:]):
450
451 2018-10-23  David Kilzer  <ddkilzer@apple.com>
452
453         Fix false positive leaks when using custom -init methods that don't start with -init
454         <https://webkit.org/b/190818>
455         <rdar://problem/45476042>
456
457         Reviewed by Dan Bernstein.
458
459         * Misc/WebKitErrors.m: Move `descriptions` static global so that
460         it is accessible by both categories.
461         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
462         NSError (WebKitInternal) category.  Add attribute to make this
463         behave like an -init method.
464         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
465         NSError (WebKitInternal) category.  Modernize method.  Replace
466         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
467
468 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
469
470         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
471         https://bugs.webkit.org/show_bug.cgi?id=190729
472
473         Reviewed by Tim Horton.
474
475         * DOM/DOM.mm:
476         (-[DOMNode boundingBox]):
477         * DOM/DOMElement.mm:
478         * DOM/DOMHTML.mm:
479         * DOM/DOMInternal.mm:
480         * DOM/DOMUIKitExtensions.mm:
481         * DOM/WebDOMOperations.mm:
482         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
483         * DefaultDelegates/WebDefaultEditingDelegate.m:
484         * DefaultDelegates/WebDefaultPolicyDelegate.m:
485         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
486         * DefaultDelegates/WebDefaultUIDelegate.h:
487         * DefaultDelegates/WebDefaultUIDelegate.mm:
488         (-[WebDefaultUIDelegate webViewClose:]):
489         (-[WebDefaultUIDelegate webViewFocus:]):
490         (-[WebDefaultUIDelegate webViewUnfocus:]):
491         (-[WebDefaultUIDelegate webViewIsResizable:]):
492         (-[WebDefaultUIDelegate webView:setResizable:]):
493         (-[WebDefaultUIDelegate webView:setFrame:]):
494         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
495         * History/BackForwardList.h:
496         * History/BackForwardList.mm:
497         * History/WebBackForwardList.mm:
498         (+[WebBackForwardList initialize]):
499         (bumperCarBackForwardHackNeeded):
500         * History/WebHistory.mm:
501         (-[WebHistoryPrivate addItem:discardDuplicate:]):
502         (-[WebHistory _sendNotification:entries:]):
503         (-[WebHistory loadFromURL:error:]):
504         (-[WebHistory saveToURL:error:]):
505         * History/WebHistoryItem.mm:
506         (WKNotifyHistoryItemChanged):
507         (+[WebHistoryItem initialize]):
508         (-[WebHistoryItem initFromDictionaryRepresentation:]):
509         * History/WebURLsWithTitles.m:
510         * Misc/WebCache.mm:
511         (+[WebCache initialize]):
512         * Misc/WebDownload.mm:
513         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
514         * Misc/WebElementDictionary.mm:
515         (+[WebElementDictionary initialize]):
516         (+[WebElementDictionary initializeLookupTable]):
517         * Misc/WebIconDatabase.mm:
518         * Misc/WebKitNSStringExtras.mm:
519         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
520         * Misc/WebKitVersionChecks.h:
521         * Misc/WebKitVersionChecks.mm:
522         (WebKitLinkedOnOrAfter):
523         (WebKitLinkTimeVersion):
524         * Misc/WebLocalizableStrings.mm:
525         * Misc/WebNSControlExtras.h:
526         * Misc/WebNSControlExtras.m:
527         * Misc/WebNSEventExtras.m:
528         * Misc/WebNSFileManagerExtras.mm:
529         * Misc/WebNSImageExtras.h:
530         * Misc/WebNSImageExtras.m:
531         * Misc/WebNSPasteboardExtras.mm:
532         * Misc/WebNSPrintOperationExtras.h:
533         * Misc/WebNSPrintOperationExtras.m:
534         * Misc/WebNSViewExtras.m:
535         * Misc/WebNSWindowExtras.m:
536         * Panels/WebAuthenticationPanel.h:
537         * Panels/WebAuthenticationPanel.m:
538         * Panels/WebPanelAuthenticationHandler.m:
539         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
540         (+[WebHostedNetscapePluginView initialize]):
541         * Plugins/WebBasePluginPackage.h:
542         * Plugins/WebBasePluginPackage.mm:
543         * Plugins/WebJavaPlugIn.h:
544         * Plugins/WebPluginContainerCheck.mm:
545         * Plugins/WebPluginController.h:
546         * Plugins/WebPluginController.mm:
547         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
548         (-[WebPluginController addPlugin:]):
549         (-[WebPluginController destroyPlugin:]):
550         (-[WebPluginController destroyAllPlugins]):
551         * Plugins/WebPluginDatabase.mm:
552         (+[WebPluginDatabase _defaultPlugInPaths]):
553         * Plugins/WebPluginPackage.mm:
554         (-[WebPluginPackage initWithPath:]):
555         * Storage/WebDatabaseManager.mm:
556         (-[WebDatabaseManager deleteAllDatabases]):
557         * Storage/WebDatabaseManagerClient.h:
558         * Storage/WebDatabaseManagerClient.mm:
559         (WebDatabaseManagerClient::WebDatabaseManagerClient):
560         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
561         * Storage/WebStorageManager.mm:
562         (-[WebStorageManager deleteAllOrigins]):
563         (WebKitInitializeStorageIfNecessary):
564         * WebCoreSupport/WebAlternativeTextClient.h:
565         * WebCoreSupport/WebApplicationCache.mm:
566         (applicationCacheBundleIdentifier):
567         * WebCoreSupport/WebChromeClient.h:
568         * WebCoreSupport/WebChromeClient.mm:
569         (WebChromeClient::setWindowRect):
570         (WebChromeClient::windowRect):
571         (WebChromeClient::takeFocus):
572         (WebChromeClient::addMessageToConsole):
573         (WebChromeClient::enableSuddenTermination):
574         (WebChromeClient::disableSuddenTermination):
575         (WebChromeClient::createPopupMenu const):
576         (WebChromeClient::createSearchPopupMenu const):
577         (WebChromeClient::shouldPaintEntireContents const):
578         (WebChromeClient::supportsVideoFullscreen):
579         (WebChromeClient::supportsFullScreenForElement):
580         (WebChromeClient::enterFullScreenForElement):
581         (WebChromeClient::exitFullScreenForElement):
582         * WebCoreSupport/WebContextMenuClient.mm:
583         * WebCoreSupport/WebDragClient.mm:
584         * WebCoreSupport/WebEditorClient.h:
585         * WebCoreSupport/WebEditorClient.mm:
586         (+[WebUndoStep initialize]):
587         (updateFontPanel):
588         (WebEditorClient::didBeginEditing):
589         (WebEditorClient::respondToChangedContents):
590         (WebEditorClient::respondToChangedSelection):
591         (WebEditorClient::canceledComposition):
592         (WebEditorClient::didEndEditing):
593         (WebEditorClient::didWriteSelectionToPasteboard):
594         (attributesForAttributedStringConversion):
595         (WebEditorClient::setInsertionPasteboard):
596         (WebEditorClient::registerUndoOrRedoStep):
597         (WebEditorClient::handleKeyboardEvent):
598         (WebEditorClient::handleInputMethodKeydown):
599         (WebEditorClient::textDidChangeInTextField):
600         (WebEditorClient::requestCheckingOfString):
601         * WebCoreSupport/WebFrameLoaderClient.h:
602         * WebCoreSupport/WebFrameLoaderClient.mm:
603         (WebFrameLoaderClient::detachedFromParent2):
604         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
605         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
606         (WebFrameLoaderClient::dispatchWillSendRequest):
607         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
608         (WebFrameLoaderClient::dispatchDidReceiveResponse):
609         (WebFrameLoaderClient::willCacheResponse const):
610         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
611         (WebFrameLoaderClient::dispatchDidFinishLoading):
612         (WebFrameLoaderClient::dispatchDidFailLoading):
613         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
614         (WebFrameLoaderClient::dispatchWillClose):
615         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
616         (WebFrameLoaderClient::dispatchDidCommitLoad):
617         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
618         (WebFrameLoaderClient::dispatchDidFailLoad):
619         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
620         (WebFrameLoaderClient::dispatchDidFinishLoad):
621         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
622         (WebFrameLoaderClient::willChangeTitle):
623         (WebFrameLoaderClient::didChangeTitle):
624         (WebFrameLoaderClient::didReplaceMultipartContent):
625         (WebFrameLoaderClient::updateGlobalHistory):
626         (WebFrameLoaderClient::saveViewStateToItem):
627         (WebFrameLoaderClient::restoreViewState):
628         (WebFrameLoaderClient::provisionalLoadStarted):
629         (WebFrameLoaderClient::prepareForDataSourceReplacement):
630         (WebFrameLoaderClient::setTitle):
631         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
632         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
633         (WebFrameLoaderClient::transitionToCommittedForNewPage):
634         (WebFrameLoaderClient::didRestoreFromPageCache):
635         (WebFrameLoaderClient::actionDictionary const):
636         (WebFrameLoaderClient::createPlugin):
637         (WebFrameLoaderClient::getLoadDecisionForIcons):
638         (WebFrameLoaderClient::finishedLoadingIcon):
639         (+[WebFramePolicyListener initialize]):
640         * WebCoreSupport/WebFrameNetworkingContext.mm:
641         * WebCoreSupport/WebGeolocationClient.h:
642         * WebCoreSupport/WebGeolocationClient.mm:
643         (WebGeolocationClient::requestPermission):
644         * WebCoreSupport/WebInspectorClient.h:
645         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
646         * WebCoreSupport/WebNotificationClient.mm:
647         * WebCoreSupport/WebOpenPanelResultListener.mm:
648         * WebCoreSupport/WebPlatformStrategies.h:
649         * WebCoreSupport/WebPlatformStrategies.mm:
650         * WebCoreSupport/WebProgressTrackerClient.h:
651         * WebCoreSupport/WebProgressTrackerClient.mm:
652         (WebProgressTrackerClient::progressStarted):
653         (WebProgressTrackerClient::progressEstimateChanged):
654         (WebProgressTrackerClient::progressFinished):
655         * WebCoreSupport/WebSecurityOrigin.mm:
656         * WebInspector/WebNodeHighlight.h:
657         * WebInspector/WebNodeHighlight.mm:
658         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
659         (-[WebNodeHighlight dealloc]):
660         (-[WebNodeHighlight attach]):
661         * WebInspector/WebNodeHighlightView.h:
662         * WebInspector/WebNodeHighlightView.mm:
663         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
664         (-[WebNodeHighlightView dealloc]):
665         * WebInspector/WebNodeHighlighter.mm:
666         (-[WebNodeHighlighter highlight]):
667         * WebView/WebArchive.mm:
668         (+[WebArchivePrivate initialize]):
669         * WebView/WebClipView.h:
670         * WebView/WebDataSource.mm:
671         (WebDataSourcePrivate::WebDataSourcePrivate):
672         (+[WebDataSource initialize]):
673         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
674         (-[WebDataSource _makeRepresentation]):
675         * WebView/WebDelegateImplementationCaching.h:
676         * WebView/WebDelegateImplementationCaching.mm:
677         (CallDelegate):
678         (CallDelegateReturningFloat):
679         (CallDelegateReturningBoolean):
680         (CallUIDelegate):
681         (CallUIDelegateReturningFloat):
682         (CallUIDelegateReturningBoolean):
683         (CallFrameLoadDelegate):
684         (CallFrameLoadDelegateReturningBoolean):
685         (CallResourceLoadDelegate):
686         (CallScriptDebugDelegate):
687         (CallFormDelegate):
688         (CallFormDelegateReturningBoolean):
689         * WebView/WebDeviceOrientation.mm:
690         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
691         * WebView/WebDocumentInternal.h:
692         * WebView/WebDocumentLoaderMac.mm:
693         (needsDataLoadWorkaround):
694         * WebView/WebDynamicScrollBarsViewInternal.h:
695         * WebView/WebFormDelegate.m:
696         * WebView/WebFrame.mm:
697         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
698         (-[WebFrame _unmarkAllMisspellings]):
699         (-[WebFrame _paintBehaviorForDestinationContext:]):
700         (-[WebFrame _drawRect:contentsOnly:]):
701         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
702         (-[WebFrame _scrollDOMRangeToVisible:]):
703         (-[WebFrame _bodyBackgroundColor]):
704         (-[WebFrame accessibilityRoot]):
705         (needsMicrosoftMessengerDOMDocumentWorkaround):
706         * WebView/WebFrameInternal.h:
707         * WebView/WebFrameView.mm:
708         (-[WebFrameView _setDocumentView:]):
709         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
710         (-[WebFrameView _viewClassForMIMEType:]):
711         (-[WebFrameView initWithFrame:]):
712         (-[WebFrameView drawRect:]):
713         (-[WebFrameView _firstResponderIsFormControl]):
714         (-[WebFrameView keyDown:keyDown:]):
715         (-[WebFrameView _isScrollable]):
716         * WebView/WebFullScreenController.h:
717         * WebView/WebFullScreenController.mm:
718         * WebView/WebHTMLRepresentation.mm:
719         * WebView/WebHTMLView.mm:
720         (-[WebHTMLView hitTest:]):
721         (-[WebHTMLView initWithFrame:]):
722         (-[WebHTMLView dealloc]):
723         (-[WebHTMLView addSubview:]):
724         (-[WebHTMLView mouseDown:]):
725         (-[WebHTMLView mouseUp:]):
726         (-[WebHTMLView resignFirstResponder]):
727         (-[WebHTMLView accessibilityHitTest:]):
728         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
729         * WebView/WebHTMLViewInternal.h:
730         * WebView/WebIndicateLayer.h:
731         * WebView/WebIndicateLayer.mm:
732         * WebView/WebMediaPlaybackTargetPicker.h:
733         * WebView/WebMediaPlaybackTargetPicker.mm:
734         * WebView/WebPDFDocumentExtras.h:
735         * WebView/WebPDFDocumentExtras.mm:
736         * WebView/WebPDFRepresentation.h:
737         * WebView/WebPDFRepresentation.mm:
738         * WebView/WebPDFView.h:
739         * WebView/WebPreferences.mm:
740         (cacheModelForMainBundle):
741         (WebPreferencesPrivate::WebPreferencesPrivate):
742         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
743         (-[WebPreferences encodeWithCoder:]):
744         (+[WebPreferences standardPreferences]):
745         (+[WebPreferences initialize]):
746         (-[WebPreferences _valueForKey:]):
747         (-[WebPreferences _setStringValue:forKey:]):
748         (-[WebPreferences _setIntegerValue:forKey:]):
749         (-[WebPreferences _setUnsignedIntValue:forKey:]):
750         (-[WebPreferences _setFloatValue:forKey:]):
751         (-[WebPreferences _setBoolValue:forKey:]):
752         (-[WebPreferences _setLongLongValue:forKey:]):
753         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
754         (-[WebPreferences _postCacheModelChangedNotification]):
755         (-[WebPreferences _postPreferencesChangedNotification]):
756         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
757         (-[WebPreferences setStorageBlockingPolicy:]):
758         * WebView/WebResource.mm:
759         (+[WebResourcePrivate initialize]):
760         * WebView/WebTextCompletionController.h:
761         * WebView/WebTextIterator.mm:
762         (+[WebTextIteratorPrivate initialize]):
763         * WebView/WebView.mm:
764         (shouldEnableLoadDeferring):
765         (shouldRestrictWindowFocus):
766         (shouldRespectPriorityInCSSAttributeSetters):
767         (shouldUseLegacyBackgroundSizeShorthandBehavior):
768         (shouldAllowPictureInPictureMediaPlayback):
769         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
770         (shouldAllowWindowOpenWithoutUserGesture):
771         (shouldConvertInvalidURLsToBlank):
772         (shouldRequireUserGestureToLoadVideo):
773         (-[WebView _commonInitializationWithFrameName:groupName:]):
774         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
775         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
776         (-[WebView _closePluginDatabases]):
777         (-[WebView _closeWithFastTeardown]):
778         (-[WebView _close]):
779         (+[WebView _MIMETypeForFile:]):
780         (-[WebView setShowingInspectorIndication:]):
781         (-[WebView _setFormDelegate:]):
782         (-[WebView _needsPreHTML5ParserQuirks]):
783         (-[WebView _preferencesChangedNotification:]):
784         (-[WebView _preferencesChanged:]):
785         (-[WebView _cacheResourceLoadDelegateImplementations]):
786         (-[WebView _cacheFrameLoadDelegateImplementations]):
787         (-[WebView _policyDelegateForwarder]):
788         (-[WebView _UIDelegateForwarder]):
789         (-[WebView _editingDelegateForwarder]):
790         (-[WebView _updateActiveState]):
791         (-[_WebSafeForwarder forwardInvocation:]):
792         (+[WebView initialize]):
793         (-[WebView _pluginForMIMEType:]):
794         (-[WebView _pluginForExtension:]):
795         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
796         (+[WebView canShowMIMETypeAsHTML:]):
797         (-[WebView _initWithArguments:]):
798         (-[WebView initWithFrame:frameName:groupName:]):
799         (-[WebView dealloc]):
800         (-[WebView close]):
801         (-[WebView viewDidMoveToWindow]):
802         (-[WebView setUIDelegate:]):
803         (-[WebView setResourceLoadDelegate:]):
804         (-[WebView setPolicyDelegate:]):
805         (-[WebView setFrameLoadDelegate:]):
806         (-[WebView goBack]):
807         (-[WebView goForward]):
808         (-[WebView stringByEvaluatingJavaScriptFromString:]):
809         (-[WebView setHostWindow:]):
810         (-[WebView becomeFirstResponder]):
811         (+[WebView _cacheModelChangedNotification:]):
812         (-[WebView _frameViewAtWindowPoint:]):
813         (+[WebView _preflightSpellCheckerNow:]):
814         (+[WebView _preflightSpellChecker]):
815         (-[WebView canGoBack]):
816         (-[WebView canGoForward]):
817         (-[WebView stopLoading:]):
818         (-[WebView reload:]):
819         (-[WebView setMainFrameDocumentReady:]):
820         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
821         (-[WebView setContinuousSpellCheckingEnabled:]):
822         (-[WebView undoManager]):
823         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
824         (-[WebView isAutomaticLinkDetectionEnabled]):
825         (-[WebView isAutomaticDashSubstitutionEnabled]):
826         (-[WebView isAutomaticTextReplacementEnabled]):
827         (-[WebView isAutomaticSpellingCorrectionEnabled]):
828         (+[WebView _setCacheModel:]):
829         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
830         (-[WebView _keyboardUIMode]):
831         (LayerFlushController::flushLayers):
832         (-[WebView _scheduleCompositingLayerFlush]):
833         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
834         (-[WebView fullScreenPlaceholderView]):
835         (WebInstallMemoryPressureHandler):
836         * WebView/WebViewData.h:
837         * WebView/WebViewData.mm:
838         (+[WebViewPrivate initialize]):
839         (-[WebViewPrivate init]):
840         (-[WebViewPrivate dealloc]):
841         * WebView/WebViewInternal.h:
842
843 2018-10-18  Alex Christensen  <achristensen@webkit.org>
844
845         Clean up FrameLoader two-state enums
846         https://bugs.webkit.org/show_bug.cgi?id=190731
847
848         Reviewed by Chris Dumez.
849
850         * WebCoreSupport/WebFrameLoaderClient.h:
851         * WebCoreSupport/WebFrameLoaderClient.mm:
852         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
853
854 2018-10-18  Alex Christensen  <achristensen@webkit.org>
855
856         Unreviewed, rolling out r237137.
857
858         SPI is actually used
859
860         Reverted changeset:
861
862         "Remove unused WebFrame._loadType"
863         https://bugs.webkit.org/show_bug.cgi?id=190583
864         https://trac.webkit.org/changeset/237137
865
866 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
867
868         Enable the datalist element by default on iOS and macOS
869         https://bugs.webkit.org/show_bug.cgi?id=190594
870         <rdar://problem/45281159>
871
872         Reviewed by Ryosuke Niwa and Tim Horton.
873
874         * Configurations/FeatureDefines.xcconfig:
875
876 2018-10-17  Alex Christensen  <achristensen@webkit.org>
877
878         BackForwardClient needs to be able to support UIProcess-only back/forward lists
879         https://bugs.webkit.org/show_bug.cgi?id=190675
880
881         Reviewed by Chris Dumez.
882
883         * History/BackForwardList.h:
884         * History/BackForwardList.mm:
885         (BackForwardList::backItem):
886         (BackForwardList::currentItem):
887         (BackForwardList::forwardItem):
888         (BackForwardList::backListCount const):
889         (BackForwardList::forwardListCount const):
890         (BackForwardList::itemAtIndex):
891         * History/WebBackForwardList.mm:
892         (-[WebBackForwardList backItem]):
893         (-[WebBackForwardList currentItem]):
894         (-[WebBackForwardList forwardItem]):
895         (-[WebBackForwardList itemAtIndex:]):
896
897 2018-10-16  Timothy Hatcher  <timothy@apple.com>
898
899         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
900         https://bugs.webkit.org/show_bug.cgi?id=190526
901         rdar://problem/45230140
902
903         Reviewed by Dean Jackson.
904
905         * WebCoreSupport/WebEditorClient.mm:
906         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
907
908 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
909
910         Implement feature flag and bindings for CSS Painting API
911         https://bugs.webkit.org/show_bug.cgi?id=190237
912
913         Reviewed by Ryosuke Niwa.
914
915         * Configurations/FeatureDefines.xcconfig:
916
917 2018-10-16  Alex Christensen  <achristensen@webkit.org>
918
919         Replace HistoryItem* with HistoryItem& where possible
920         https://bugs.webkit.org/show_bug.cgi?id=190617
921
922         Reviewed by Chris Dumez.
923
924         * History/BackForwardList.h:
925         * History/BackForwardList.mm:
926         (BackForwardList::goToItem):
927         * History/WebBackForwardList.mm:
928         (-[WebBackForwardList goToItem:]):
929         * History/WebHistoryItem.mm:
930         (WKNotifyHistoryItemChanged):
931         * History/WebHistoryItemInternal.h:
932
933 2018-10-16  Alex Christensen  <achristensen@webkit.org>
934
935         Remove unused WebHistoryItem._transientPropertyForKey
936         https://bugs.webkit.org/show_bug.cgi?id=190606
937
938         Reviewed by Chris Dumez.
939
940         * History/WebHistoryItem.mm:
941         * History/WebHistoryItemPrivate.h:
942
943 2018-10-15  Justin Fan  <justin_fan@apple.com>
944
945         Add WebGPU 2018 feature flag and experimental feature flag
946         https://bugs.webkit.org/show_bug.cgi?id=190509
947
948         Reviewed by Dean Jackson.
949
950         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
951         for the 2018 WebGPU prototype.
952
953         * Configurations/FeatureDefines.xcconfig:
954         * WebView/WebPreferenceKeysPrivate.h:
955         * WebView/WebPreferences.mm:
956         (+[WebPreferences initialize]):
957         (-[WebPreferences webGPUEnabled]):
958         (-[WebPreferences setWebGPUEnabled:]):
959         * WebView/WebPreferencesPrivate.h:
960         * WebView/WebView.mm:
961         (-[WebView _preferencesChanged:]):
962
963 2018-10-15  Alex Christensen  <achristensen@webkit.org>
964
965         Fix iOS build after r237157
966
967         * WebView/WebView.mm:
968         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
969
970 2018-10-15  Alex Christensen  <achristensen@webkit.org>
971
972         Modernize BackForwardClient.h
973         https://bugs.webkit.org/show_bug.cgi?id=190610
974
975         Reviewed by Chris Dumez.
976
977         * History/BackForwardList.h:
978         * History/BackForwardList.mm:
979         (BackForwardList::backListCount const):
980         (BackForwardList::forwardListCount const):
981         (BackForwardList::backListCount): Deleted.
982         (BackForwardList::forwardListCount): Deleted.
983         * History/WebBackForwardList.mm:
984         (-[WebBackForwardList init]):
985         * WebCoreSupport/WebFrameLoaderClient.mm:
986         (WebFrameLoaderClient::canCachePage const):
987         * WebView/WebFrameView.mm:
988         (-[WebFrameView keyDown:keyDown:]):
989         * WebView/WebView.mm:
990         (-[WebView _commonInitializationWithFrameName:groupName:]):
991         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
992         (-[WebView _loadBackForwardListFromOtherView:]):
993         (-[WebView initWithCoder:]):
994         (-[WebView encodeWithCoder:]):
995         (-[WebView backForwardList]):
996         (-[WebView setMaintainsBackForwardList:]):
997
998 2018-10-15  Timothy Hatcher  <timothy@apple.com>
999
1000         Add support for prefers-color-scheme media query
1001         https://bugs.webkit.org/show_bug.cgi?id=190499
1002         rdar://problem/45212025
1003
1004         Reviewed by Dean Jackson.
1005
1006         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
1007
1008 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1009
1010         Remove unused WebView._globalHistoryItem
1011         https://bugs.webkit.org/show_bug.cgi?id=190601
1012
1013         Reviewed by Chris Dumez.
1014
1015         * WebCoreSupport/WebFrameLoaderClient.h:
1016         * WebCoreSupport/WebFrameLoaderClient.mm:
1017         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
1018         * WebView/WebView.mm:
1019         (-[WebView _globalHistoryItem]): Deleted.
1020         (-[WebView _setGlobalHistoryItem:]): Deleted.
1021         * WebView/WebViewData.h:
1022         * WebView/WebViewInternal.h:
1023         * WebView/WebViewPrivate.h:
1024
1025 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1026
1027         Remove unused parameters from FrameLoaderClient::createFrame
1028         https://bugs.webkit.org/show_bug.cgi?id=190587
1029
1030         Reviewed by Chris Dumez.
1031
1032         * WebCoreSupport/WebFrameLoaderClient.h:
1033         * WebCoreSupport/WebFrameLoaderClient.mm:
1034         (WebFrameLoaderClient::createFrame):
1035
1036 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1037
1038         Remove unused WebFrame._loadType
1039         https://bugs.webkit.org/show_bug.cgi?id=190583
1040
1041         Reviewed by Chris Dumez.
1042
1043         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
1044
1045         * WebView/WebFrame.mm:
1046         (toWebFrameLoadType): Deleted.
1047         (-[WebFrame _loadType]): Deleted.
1048         * WebView/WebFramePrivate.h:
1049
1050 2018-10-15  Chris Dumez  <cdumez@apple.com>
1051
1052         Restrict browsing context lookup by name to frames that are related to one another
1053         https://bugs.webkit.org/show_bug.cgi?id=190475
1054
1055         Reviewed by Alex Christensen.
1056
1057         * WebView/WebFrame.mm:
1058         (-[WebFrame findFrameNamed:]):
1059
1060 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1061
1062         Remove InjectedBundle processing of back/forward lists
1063         https://bugs.webkit.org/show_bug.cgi?id=190459
1064
1065         Reviewed by Chris Dumez.
1066
1067         * WebCoreSupport/WebFrameLoaderClient.h:
1068         * WebCoreSupport/WebFrameLoaderClient.mm:
1069         (WebFrameLoaderClient::shouldGoToHistoryItem const):
1070
1071 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1072
1073         [JSC] Remove Option::useAsyncIterator
1074         https://bugs.webkit.org/show_bug.cgi?id=190567
1075
1076         Reviewed by Saam Barati.
1077
1078         * Configurations/FeatureDefines.xcconfig:
1079
1080 2018-10-12  Alex Christensen  <achristensen@webkit.org>
1081
1082         Allow encoding of small enum classes
1083         https://bugs.webkit.org/show_bug.cgi?id=190531
1084
1085         Reviewed by Tim Horton.
1086
1087         * WebCoreSupport/WebFrameLoaderClient.mm:
1088         (-[WebFramePolicyListener dealloc]):
1089
1090 2018-10-11  Keith Rollin  <krollin@apple.com>
1091
1092         CURRENT_ARCH should not be used in Run Script phase.
1093         https://bugs.webkit.org/show_bug.cgi?id=190407
1094         <rdar://problem/45133556>
1095
1096         Reviewed by Alexey Proskuryakov.
1097
1098         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
1099         CURRENT_ARCH is not well-defined during this phase (and may even have
1100         the value "undefined") since this phase is run just once per build
1101         rather than once per supported architecture. Migrate away from
1102         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
1103         performing an operation for each value, or by picking the first entry
1104         in ARCHS and using that as a representative value.
1105
1106         * Configurations/WebKitLegacy.xcconfig: When generating
1107         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
1108         macosx platforms.
1109
1110         * MigrateHeaders.make:
1111         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
1112         generate one for each architecture in ARCHS.
1113
1114 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1115
1116         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
1117         https://bugs.webkit.org/show_bug.cgi?id=190429
1118
1119         Reviewed by Saam Barati.
1120
1121         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
1122
1123         * WebView/WebPDFRepresentation.mm:
1124         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
1125
1126 2018-10-08  Justin Fan  <justin_fan@apple.com>
1127
1128         WebGPU: Rename old WebGPU prototype to WebMetal
1129         https://bugs.webkit.org/show_bug.cgi?id=190325
1130         <rdar://problem/44990443>
1131
1132         Reviewed by Dean Jackson.
1133
1134         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
1135
1136         * Configurations/FeatureDefines.xcconfig:
1137         * WebView/WebPreferenceKeysPrivate.h:
1138         * WebView/WebPreferences.mm:
1139         (+[WebPreferences initialize]):
1140         (-[WebPreferences webMetalEnabled]):
1141         (-[WebPreferences setWebMetalEnabled:]):
1142         (-[WebPreferences webGPUEnabled]): Deleted.
1143         (-[WebPreferences setWebGPUEnabled:]): Deleted.
1144         * WebView/WebPreferencesPrivate.h:
1145         * WebView/WebView.mm:
1146         (-[WebView _preferencesChanged:]):
1147
1148 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
1149
1150         Make <input type=color> a runtime enabled (on-by-default) feature
1151         https://bugs.webkit.org/show_bug.cgi?id=189162
1152
1153         Reviewed by Wenson Hsieh and Tim Horton.
1154
1155         * Configurations/FeatureDefines.xcconfig:
1156
1157 2018-10-07  Dan Bernstein  <mitz@apple.com>
1158
1159         Fixed building with the latest macOS SDK
1160
1161         * Plugins/WebNetscapePluginPackage.mm:
1162         (-[WebNetscapePluginPackage openResourceFile]):
1163         (-[WebNetscapePluginPackage closeResourceFile:]):
1164
1165 2018-10-04  Dan Bernstein  <mitz@apple.com>
1166
1167         More Carbon build-fixing.
1168
1169         * Carbon/CarbonWindowAdapter.mm:
1170         (-[CarbonWindowAdapter _destroyRealWindow:]):
1171         (-[CarbonWindowAdapter _growBoxRect]):
1172
1173 2018-10-04  Dan Bernstein  <mitz@apple.com>
1174
1175         Retried to fix 32-bit macOS builds after r236846.
1176
1177         * WebView/WebHTMLView.mm:
1178         (-[WebHTMLView setMarkedText:selectedRange:]):
1179
1180 2018-10-04  Dan Bernstein  <mitz@apple.com>
1181
1182         Retried to fix 32-bit macOS builds after r236846.
1183
1184         * Carbon/HIWebView.mm:
1185         (ActiveStateChanged):
1186
1187 2018-10-04  Dan Bernstein  <mitz@apple.com>
1188
1189         Tried to fix 32-bit macOS builds after r236846.
1190
1191         * Carbon/HIWebView.mm:
1192         (_NSSelectorForHICommand):
1193
1194 2018-10-04  Dan Bernstein  <mitz@apple.com>
1195
1196         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
1197         https://bugs.webkit.org/show_bug.cgi?id=190250
1198
1199         Reviewed by Andy Estes.
1200
1201         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
1202           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
1203           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
1204           an earlier line set it to YES.
1205
1206         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
1207         changes below.
1208
1209         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
1210           provides some missing method declarations.
1211
1212         * Misc/WebDownload.mm:
1213         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
1214           a deprecated method.
1215
1216         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
1217
1218         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
1219           other code in the file uses a method from it.
1220
1221         * Plugins/WebBaseNetscapePluginView.mm:
1222         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
1223           a deprecated method.
1224
1225         * Plugins/WebPluginController.mm:
1226         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
1227           around use of a selector that may be present in some WebKit client.
1228
1229         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
1230           method declarations.
1231
1232         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
1233           from here.
1234
1235         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
1236           missing method declarations.
1237
1238         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
1239           from here.
1240
1241         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
1242           call from here.
1243         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
1244           an obsolete delegate method for binary compatibility.
1245         (pluginView): Ditto.
1246
1247         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
1248           call from here.
1249
1250         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
1251           WebDeviceOrientationProviderMock protocol.
1252
1253         * WebView/WebDeviceOrientationProviderMock.mm:
1254         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
1255           main @implementation.
1256
1257         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
1258           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
1259
1260         * WebView/WebDynamicScrollBarsView.mm:
1261         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
1262           of a deprecated method.
1263
1264         * WebView/WebHTMLView.mm:
1265         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
1266           selector warning around action methods that are not declared anywhere in WebKit.
1267
1268         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
1269           about implementing this deprecated method.
1270         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
1271         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
1272         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1273         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
1274         (-[WebHTMLView characterIndexForPoint:]): Ditto.
1275         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1276         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1277         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1278         (-[WebHTMLView doCommandBySelector:]): Ditto.
1279         (-[WebHTMLView insertText:]): Ditto.
1280
1281         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
1282
1283         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
1284
1285         * WebView/WebPDFView.h: Removed previewView ivar.
1286
1287         * WebView/WebPDFView.mm:
1288           Removed declaration of FileInternal category and merged its implementation with the main
1289           implementation.
1290         (-[WebPDFView dealloc]): Removed previewView ivar.
1291         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
1292           exist in macOS versions we support.
1293         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
1294         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
1295           action methods internal to PDFKit.
1296         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
1297         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
1298
1299         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
1300           call on macOS, even though in r86988 we started calling different methods on iOS.
1301
1302         * WebView/WebView.mm:
1303         - Imported headers that declare delegate methods that we call.
1304         - Removed declaration of WebFileInternal category and merged its implementation with the
1305           main implementation.
1306         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
1307           category, which made them impossible to call from the main implementation. Moved those
1308           into the main implementation. One of those had to be declared in a class extension,
1309           because it is called from a method implemented in the WebPrivate category, and that
1310           category’s implementation appears first in the file.
1311
1312         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
1313           around use of obsolete delegate method for binary compatibility.
1314
1315         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
1316
1317 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
1318
1319         Runtime flag and IDL for MediaRecorder
1320         https://bugs.webkit.org/show_bug.cgi?id=190018
1321
1322         Reviewed by Youenn Fablet and Chris Dumez.
1323
1324         * WebView/WebPreferenceKeysPrivate.h:
1325         * WebView/WebPreferences.mm:
1326         (+[WebPreferences initialize]):
1327         (-[WebPreferences mediaRecorderEnabled]):
1328         (-[WebPreferences setMediaRecorderEnabled:]):
1329         * WebView/WebPreferencesPrivate.h:
1330         * WebView/WebView.mm:
1331         (-[WebView _preferencesChanged:]):
1332
1333 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1334
1335         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
1336         https://bugs.webkit.org/show_bug.cgi?id=190238
1337
1338         Reviewed by Antti Koivisto.
1339
1340         Enabled the feature by default.
1341
1342         * WebView/WebPreferences.mm:
1343         (+[WebPreferences initialize]):
1344
1345 2018-10-01  Dean Jackson  <dino@apple.com>
1346
1347         [macOS] Switching to discrete GPU should be done in the UI process
1348         https://bugs.webkit.org/show_bug.cgi?id=189361
1349         <rdar://problem/43949622>
1350
1351         Reviewed by Simon Fraser.
1352
1353         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
1354         not support swapping to the discrete GPU in this configuration.
1355
1356         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
1357         (WebKit::WebSwitchingGPUClient::singleton):
1358         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
1359         * WebView/WebView.mm:
1360         (-[WebView _commonInitializationWithFrameName:groupName:]):
1361
1362 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1363
1364         Remove ParsedURLString
1365         https://bugs.webkit.org/show_bug.cgi?id=190154
1366
1367         Reviewed by Chris Dumez.
1368
1369         * WebView/WebScriptDebugger.mm:
1370         (toNSURL):
1371
1372 2018-10-01  Dean Jackson  <dino@apple.com>
1373
1374         Remove CSS Animation Triggers
1375         https://bugs.webkit.org/show_bug.cgi?id=190175
1376         <rdar://problem/44925626>
1377
1378         Reviewed by Simon Fraser.
1379
1380         * Configurations/FeatureDefines.xcconfig:
1381
1382 2018-10-02  Commit Queue  <commit-queue@webkit.org>
1383
1384         Unreviewed, rolling out r236624 and r236671.
1385         https://bugs.webkit.org/show_bug.cgi?id=190207
1386
1387         The change in r236624 introduced crashes on the bots
1388         (Requested by ryanhaddad on #webkit).
1389
1390         Reverted changesets:
1391
1392         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1393         https://bugs.webkit.org/show_bug.cgi?id=188747
1394         https://trac.webkit.org/changeset/236624
1395
1396         "Unify implementation in VideoFullscreenInterfaceAVKit"
1397         https://bugs.webkit.org/show_bug.cgi?id=190091
1398         https://trac.webkit.org/changeset/236671
1399
1400 2018-10-01  Alex Christensen  <achristensen@webkit.org>
1401
1402         URL should not use TextEncoding internally
1403         https://bugs.webkit.org/show_bug.cgi?id=190111
1404
1405         Reviewed by Andy Estes.
1406
1407         * Misc/WebNSURLExtras.mm:
1408
1409 2018-09-28  Jer Noble  <jer.noble@apple.com>
1410
1411         Refactoring: eliminate raw pointer usage in Fullscreen code
1412         https://bugs.webkit.org/show_bug.cgi?id=188747
1413         <rdar://problem/43541164>
1414
1415         Reviewed by Alex Christensen.
1416
1417         PlaybackSessionInterface no longer has an invalidate() method.
1418
1419         * WebView/WebView.mm:
1420         (-[WebView _clearPlaybackControlsManager]):
1421
1422 2018-09-28  Chris Dumez  <cdumez@apple.com>
1423
1424         Drop support for cross-origin-window-policy header
1425         https://bugs.webkit.org/show_bug.cgi?id=190081
1426
1427         Reviewed by Ryosuke Niwa.
1428
1429         * WebView/WebPreferenceKeysPrivate.h:
1430         * WebView/WebPreferences.mm:
1431         (+[WebPreferences initialize]):
1432         * WebView/WebPreferencesPrivate.h:
1433         * WebView/WebView.mm:
1434         (-[WebView _preferencesChanged:]):
1435
1436 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
1437
1438         Rename createMarkup to serializePreservingVisualAppearance
1439         https://bugs.webkit.org/show_bug.cgi?id=190086
1440
1441         Reviewed by Wenson Hsieh.
1442
1443         * DOM/WebDOMOperations.mm:
1444         (-[DOMRange markupString]):
1445
1446 2018-09-28  Commit Queue  <commit-queue@webkit.org>
1447
1448         Unreviewed, rolling out r236605.
1449         https://bugs.webkit.org/show_bug.cgi?id=190087
1450
1451         caused three API test timeouts (Requested by jernoble on
1452         #webkit).
1453
1454         Reverted changeset:
1455
1456         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1457         https://bugs.webkit.org/show_bug.cgi?id=188747
1458         https://trac.webkit.org/changeset/236605
1459
1460 2018-09-28  Jer Noble  <jer.noble@apple.com>
1461
1462         Refactoring: eliminate raw pointer usage in Fullscreen code
1463         https://bugs.webkit.org/show_bug.cgi?id=188747
1464         <rdar://problem/43541164>
1465
1466         Reviewed by Alex Christensen.
1467
1468         PlaybackSessionInterface no longer has an invalidate() method.
1469
1470         * WebView/WebView.mm:
1471         (-[WebView _clearPlaybackControlsManager]):
1472
1473 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1474
1475         Use enum class in createMarkup arguments
1476         https://bugs.webkit.org/show_bug.cgi?id=190028
1477
1478         Reviewed by Wenson Hsieh.
1479
1480         * DOM/WebDOMOperations.mm:
1481         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
1482         (-[DOMRange markupString]): Ditto.
1483
1484 2018-09-27  Antoine Quint  <graouts@apple.com>
1485
1486         [Web Animations] Turn Web Animations with CSS integration on
1487         https://bugs.webkit.org/show_bug.cgi?id=184819
1488         <rdar://problem/39597337>
1489
1490         Reviewed by Dean Jackson.
1491
1492         * WebView/WebPreferences.mm:
1493         (+[WebPreferences initialize]):
1494
1495 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1496
1497         Selection should work across shadow boundary when initiated by a mouse drag
1498         https://bugs.webkit.org/show_bug.cgi?id=151380
1499         <rdar://problem/24363872>
1500
1501         Reviewed by Wenson Hsieh.
1502
1503         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
1504
1505         * WebView/WebPreferenceKeysPrivate.h:
1506         * WebView/WebPreferences.mm:
1507         (+[WebPreferences initialize]):
1508         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
1509         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
1510         * WebView/WebPreferencesPrivate.h:
1511         * WebView/WebView.mm:
1512         (-[WebView _preferencesChanged:]):
1513
1514 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1515
1516         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
1517         https://bugs.webkit.org/show_bug.cgi?id=189918
1518         Work towards <rdar://problem/44648705>
1519
1520         Reviewed by Tim Horton.
1521
1522         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
1523
1524         * WebView/WebHTMLView.mm:
1525         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
1526         (-[WebHTMLView _updateFontPanel]):
1527         * WebView/WebView.mm:
1528         (-[WebView typingAttributes]):
1529
1530 2018-09-17  Darin Adler  <darin@apple.com>
1531
1532         Use OpaqueJSString rather than JSRetainPtr inside WebKit
1533         https://bugs.webkit.org/show_bug.cgi?id=189652
1534
1535         Reviewed by Saam Barati.
1536
1537         * WebView/WebPDFRepresentation.mm:
1538         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
1539
1540 2018-09-14  Jer Noble  <jer.noble@apple.com>
1541
1542         Turn SourceBufferChangeTypeEnabled on by default
1543         https://bugs.webkit.org/show_bug.cgi?id=189527
1544
1545         Reviewed by Eric Carlson.
1546
1547         * WebView/WebPreferences.mm:
1548         (+[WebPreferences initialize]):
1549
1550 2018-09-12  Alex Christensen  <achristensen@webkit.org>
1551
1552         Fix an internal build after r235935
1553         https://bugs.webkit.org/show_bug.cgi?id=188996
1554
1555         * Carbon/HIWebView.mm:
1556         (Draw):
1557         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
1558
1559 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
1560
1561         Add IGNORE_WARNING_.* macros
1562         https://bugs.webkit.org/show_bug.cgi?id=188996
1563
1564         Reviewed by Michael Catanzaro.
1565
1566         * Carbon/CarbonUtils.m:
1567         (PoolCleaner):
1568         * Carbon/CarbonWindowAdapter.mm:
1569         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1570         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1571         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1572         (-[CarbonWindowAdapter _termWindowIfOwner]):
1573         (-[CarbonWindowAdapter _windowMovedToRect:]):
1574         (-[CarbonWindowAdapter setContentView:]):
1575         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1576         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1577         * Carbon/CarbonWindowFrame.m:
1578         (-[CarbonWindowFrame title]):
1579         * Carbon/HIViewAdapter.m:
1580         (+[HIViewAdapter getHIViewForNSView:]):
1581         * Carbon/HIWebView.mm:
1582         (overrideCGContext):
1583         (restoreCGContext):
1584         (Draw):
1585         * DOM/DOM.mm:
1586         * History/WebHistory.mm:
1587         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1588         * History/WebHistoryItem.mm:
1589         (-[WebHistoryItem icon]):
1590         * Misc/WebKitNSStringExtras.mm:
1591         (-[NSString _web_drawAtPoint:font:textColor:]):
1592         * Misc/WebNSImageExtras.m:
1593         (-[NSImage _web_scaleToMaxSize:]):
1594         (-[NSImage _web_dissolveToFraction:]):
1595         * Misc/WebNSPasteboardExtras.mm:
1596         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1597         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1598         * Panels/WebAuthenticationPanel.m:
1599         (-[WebAuthenticationPanel loadNib]):
1600         * Plugins/Hosted/NetscapePluginHostManager.mm:
1601         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1602         (WebKit::NetscapePluginHostManager::didCreateWindow):
1603         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1604         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
1605         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
1606         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
1607         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1608         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
1609         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1610         (-[WebHostedNetscapePluginView drawRect:]):
1611         * Plugins/Hosted/WebTextInputWindowController.m:
1612         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1613         * Plugins/WebBaseNetscapePluginView.mm:
1614         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
1615         * Plugins/WebNetscapePluginPackage.mm:
1616         (-[WebNetscapePluginPackage _tryLoad]):
1617         * Plugins/WebNetscapePluginView.mm:
1618         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1619         (-[WebNetscapePluginView sendDrawRectEvent:]):
1620         (-[WebNetscapePluginView drawRect:]):
1621         * Plugins/WebPluginController.mm:
1622         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
1623         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
1624         * WebCoreSupport/PopupMenuMac.mm:
1625         (PopupMenuMac::populate):
1626         * WebCoreSupport/WebAlternativeTextClient.h:
1627         * WebCoreSupport/WebDragClient.mm:
1628         (WebDragClient::startDrag):
1629         * WebCoreSupport/WebFrameLoaderClient.mm:
1630         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1631         (webGetNSImage):
1632         * WebInspector/WebNodeHighlight.mm:
1633         * WebInspector/WebNodeHighlightView.mm:
1634         (-[WebNodeHighlightView drawRect:]):
1635         * WebView/WebClipView.mm:
1636         (-[WebClipView initWithFrame:]):
1637         * WebView/WebFrame.mm:
1638         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1639         (-[WebFrame _drawRect:contentsOnly:]):
1640         (-[WebFrame accessibilityRoot]):
1641         * WebView/WebFullScreenController.mm:
1642         (-[WebFullScreenController enterFullScreen:]):
1643         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1644         (-[WebFullScreenController exitFullScreen]):
1645         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1646         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1647         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1648         * WebView/WebHTMLView.mm:
1649         (-[NSWindow _web_borderView]):
1650         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
1651         (-[WebHTMLView _setAsideSubviews]):
1652         (-[WebHTMLView _autoscroll]):
1653         (-[WebHTMLView drawRect:]):
1654         (-[WebHTMLView mouseDown:]):
1655         (-[WebHTMLView mouseDragged:]):
1656         (-[WebHTMLView mouseUp:]):
1657         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
1658         (-[WebHTMLView knowsPageRange:]):
1659         (-[WebHTMLView accessibilityHitTest:]):
1660         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1661         (-[WebHTMLView _colorAsString:]):
1662         (-[WebHTMLView copyFont:]):
1663         (-[WebHTMLView _executeSavedKeypressCommands]):
1664         (-[WebHTMLView attachRootLayer:]):
1665         (-[WebHTMLView textStorage]):
1666         (-[WebHTMLView _updateSelectionForInputManager]):
1667         * WebView/WebPDFView.mm:
1668         (_applicationInfoForMIMEType):
1669         (-[WebPDFView centerSelectionInVisibleArea:]):
1670         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1671         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1672         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1673         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
1674         * WebView/WebTextCompletionController.mm:
1675         (-[WebTextCompletionController _buildUI]):
1676         (-[WebTextCompletionController _placePopupWindow:]):
1677         * WebView/WebVideoFullscreenController.mm:
1678         * WebView/WebVideoFullscreenHUDWindowController.mm:
1679         (createMediaUIBackgroundView):
1680         * WebView/WebView.mm:
1681         (-[WebTextListTouchBarViewController initWithWebView:]):
1682         (-[WebView _dispatchTileDidDraw:]):
1683         (-[WebView encodeWithCoder:]):
1684         (-[WebView mainFrameIcon]):
1685         (LayerFlushController::flushLayers):
1686         * WebView/WebWindowAnimation.mm:
1687         (setScaledFrameForWindow):
1688
1689 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1690
1691         Remove unused needsDestruction class variables from HashTraits
1692         https://bugs.webkit.org/show_bug.cgi?id=189490
1693
1694         Reviewed by Daniel Bates.
1695
1696         * History/BinaryPropertyList.cpp: Removed needsDestruction.
1697
1698 2018-09-07  Frederic Wang  <fwang@igalia.com>
1699
1700         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
1701         https://bugs.webkit.org/show_bug.cgi?id=182230
1702
1703         Reviewed by Simon Fraser.
1704
1705         * DOM/DOMDocument.mm:
1706         (-[DOMDocument scrollingElement]): Use the new name.
1707
1708 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1709
1710         Refactor WebCore::EditAction to be an 8-bit enum class
1711         https://bugs.webkit.org/show_bug.cgi?id=189383
1712
1713         Reviewed by Dan Bernstein.
1714
1715         * WebCoreSupport/WebEditorClient.mm:
1716         (undoNameForEditAction):
1717         * WebView/WebHTMLView.mm:
1718         (-[WebHTMLView pasteFont:]):
1719         (-[WebHTMLView changeFont:]):
1720         (-[WebHTMLView changeAttributes:]):
1721         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
1722         (-[WebHTMLView changeColor:]):
1723         * WebView/WebView.mm:
1724         (-[WebView setTypingStyle:]):
1725
1726 2018-09-06  Frederic Wang  <fwang@igalia.com>
1727
1728         Group options of scrollRectToVisible into a struct
1729         https://bugs.webkit.org/show_bug.cgi?id=189352
1730
1731         Reviewed by Simon Fraser.
1732
1733         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
1734         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
1735         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
1736
1737 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1738
1739         [macOS] Cannot change font size at selection until font panel is shown
1740         https://bugs.webkit.org/show_bug.cgi?id=189295
1741         <rdar://problem/35593389>
1742
1743         Reviewed by Ryosuke Niwa.
1744
1745         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
1746         WebCore ChangeLog for more details.
1747
1748         * WebView/WebHTMLView.mm:
1749         (-[WebHTMLView changeFont:]):
1750         (-[WebHTMLView changeAttributes:]):
1751         (-[WebHTMLView _originalFontA]): Deleted.
1752         (-[WebHTMLView _originalFontB]): Deleted.
1753         (fontNameForDescription): Deleted.
1754         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
1755         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
1756         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
1757
1758 2018-09-05  Jer Noble  <jer.noble@apple.com>
1759
1760         Add MediaCapabilities as an Experimental Feature
1761         https://bugs.webkit.org/show_bug.cgi?id=189209
1762
1763         Reviewed by Eric Carlson.
1764
1765         RuntimeEnabledFeature -> Setting.
1766
1767         * WebView/WebView.mm:
1768         (-[WebView _preferencesChanged:]):
1769
1770 2018-09-04  Frederic Wang  <fwang@igalia.com>
1771
1772         Add basic support for ScrollIntoViewOptions
1773         https://bugs.webkit.org/show_bug.cgi?id=189258
1774
1775         Reviewed by Simon Fraser.
1776
1777         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
1778         header so that this file can build despite the new scrollIntoView function.
1779
1780 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1781
1782         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
1783         https://bugs.webkit.org/show_bug.cgi?id=188890
1784         <rdar://problem/43648605>
1785
1786         Reviewed by Tim Horton.
1787
1788         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
1789         more detail.
1790
1791         * WebCoreSupport/WebPlatformStrategies.h:
1792         * WebCoreSupport/WebPlatformStrategies.mm:
1793         (WebPlatformStrategies::allStringsForType):
1794
1795 2018-09-01  Darin Adler  <darin@apple.com>
1796
1797         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
1798         https://bugs.webkit.org/show_bug.cgi?id=189072
1799         Reviewed by Dan Bernstein.
1800
1801         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
1802         and declarations for NSURLDownload init methods.
1803
1804         * Misc/WebDownloadInternal.h: Removed.
1805
1806         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
1807         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
1808         "-Wdeprecated-declarations" because the method used here is deprecated.
1809
1810         * WebView/WebView.mm:
1811         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
1812         used here is deprecated.
1813
1814 2018-08-31  Chris Dumez  <cdumez@apple.com>
1815
1816         Assertion hit in ~CompletionHandler() from ~WebFrame()
1817         https://bugs.webkit.org/show_bug.cgi?id=189199
1818         <rdar://problem/42657233>
1819
1820         Reviewed by Youenn Fablet.
1821
1822         * WebCoreSupport/WebFrameLoaderClient.h:
1823         * WebCoreSupport/WebFrameLoaderClient.mm:
1824         (WebFrameLoaderClient::dispatchWillSubmitForm):
1825
1826 2018-08-31  Antti Koivisto  <antti@apple.com>
1827
1828         Replace OptionSet |= and -= operators with add() and remove() functions
1829         https://bugs.webkit.org/show_bug.cgi?id=189169
1830
1831         Reviewed by Anders Carlsson.
1832
1833         * WebView/WebFrame.mm:
1834         (-[WebFrame _drawRect:contentsOnly:]):
1835         * WebView/WebView.mm:
1836         (coreOptions):
1837
1838 2018-08-31  Frederic Wang  <fwang@igalia.com>
1839
1840         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1841         https://bugs.webkit.org/show_bug.cgi?id=182053
1842
1843         Reviewed by Simon Fraser.
1844
1845         Add developer flag to use standard behavior for scrolling* attributes.
1846
1847         * WebView/WebPreferenceKeysPrivate.h:
1848         * WebView/WebPreferences.mm:
1849         (+[WebPreferences initialize]):
1850         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
1851         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
1852         * WebView/WebPreferencesPrivate.h:
1853         * WebView/WebView.mm:
1854         (-[WebView _preferencesChanged:]):
1855
1856 2018-08-29  Olivia Barnett  <obarnett@apple.com>
1857
1858         Implement the Web Share API
1859         https://bugs.webkit.org/show_bug.cgi?id=171100
1860         <rdar://problem/31751734>
1861
1862         Reviewed by Tim Horton.
1863
1864         * WebCoreSupport/WebChromeClient.h:
1865         * WebCoreSupport/WebChromeClient.mm:
1866         (WebChromeClient::showShareSheet):
1867         Empty declaration of showShareSheet.
1868
1869 2018-08-29  Youenn Fablet  <youenn@apple.com>
1870
1871         Remove WebRTC legacy API implementation
1872         https://bugs.webkit.org/show_bug.cgi?id=189040
1873
1874         Reviewed by Eric Carlson.
1875
1876         * WebView/WebPreferenceKeysPrivate.h:
1877         * WebView/WebPreferences.mm:
1878         (+[WebPreferences initialize]):
1879         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
1880         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
1881         * WebView/WebPreferencesPrivate.h:
1882         * WebView/WebView.mm:
1883         (-[WebView _preferencesChanged:]):
1884
1885 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1886
1887         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
1888         https://bugs.webkit.org/show_bug.cgi?id=189054
1889
1890         Reviewed by Andy Estes.
1891
1892         Remove the pasteboard type argument from readURLFromPasteboard.
1893
1894         * WebCoreSupport/WebPlatformStrategies.h:
1895         * WebCoreSupport/WebPlatformStrategies.mm:
1896         (WebPlatformStrategies::readURLFromPasteboard):
1897
1898 2018-08-27  Keith Rollin  <krollin@apple.com>
1899
1900         Unreviewed build fix -- disable LTO for production builds
1901
1902         * Configurations/Base.xcconfig:
1903
1904 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
1905
1906         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
1907         https://bugs.webkit.org/show_bug.cgi?id=188931
1908
1909         Reviewed by Wenson Hsieh.
1910
1911         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
1912
1913 2018-08-27  Keith Rollin  <krollin@apple.com>
1914
1915         Build system support for LTO
1916         https://bugs.webkit.org/show_bug.cgi?id=187785
1917         <rdar://problem/42353132>
1918
1919         Reviewed by Dan Bernstein.
1920
1921         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
1922         LTO.
1923
1924         * Configurations/Base.xcconfig:
1925         * Configurations/DebugRelease.xcconfig:
1926
1927 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
1928
1929         Pass in IsComposed flag to Event constructors
1930         https://bugs.webkit.org/show_bug.cgi?id=188720
1931         <rdar://problem/43580387>
1932
1933         Reviewed by Simon Fraser.
1934
1935         * WebView/WebPDFView.mm:
1936         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
1937         whether it's simulated or not.
1938
1939 2018-08-23  Mark Lam  <mark.lam@apple.com>
1940
1941         Move vmEntryGlobalObject() to VM from CallFrame.
1942         https://bugs.webkit.org/show_bug.cgi?id=188900
1943         <rdar://problem/43655753>
1944
1945         Reviewed by Michael Saboff.
1946
1947         * WebView/WebScriptDebugger.mm:
1948         (WebScriptDebugger::sourceParsed):
1949
1950 2018-08-23  Andy Estes  <aestes@apple.com>
1951
1952         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
1953         https://bugs.webkit.org/show_bug.cgi?id=188829
1954
1955         Reviewed by Tim Horton.
1956
1957         * Configurations/FeatureDefines.xcconfig:
1958
1959 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
1960
1961         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
1962         https://bugs.webkit.org/show_bug.cgi?id=188777
1963
1964         Reviewed by Simon Fraser.
1965
1966         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
1967         being "true" before the code change.
1968
1969         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
1970
1971         * WebView/WebPDFView.mm:
1972         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1973
1974 2018-08-21  Daniel Bates  <dabates@apple.com>
1975
1976         Replace TextCheckingTypeMask with OptionSet
1977         https://bugs.webkit.org/show_bug.cgi?id=188678
1978
1979         Reviewed by Antti Koivisto.
1980
1981         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
1982         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
1983         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
1984         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
1985
1986         * WebCoreSupport/WebEditorClient.h:
1987         * WebCoreSupport/WebEditorClient.mm:
1988         (WebEditorClient::checkTextOfParagraph):
1989         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
1990         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
1991         left as this is more readable and unncessary now that modern compilers like Clang have
1992         diagnostics to catch accidental assignments when equality was intended.
1993         (WebEditorClient::didCheckSucceed):
1994         * WebView/WebView.mm:
1995         (coreTextCheckingType):
1996         (textCheckingResultFromNSTextCheckingResult):
1997
1998 2018-08-21  Daniel Bates  <dabates@apple.com>
1999
2000         [iOS][WK1] Support toggling continuous spell checking from tests
2001         https://bugs.webkit.org/show_bug.cgi?id=188763
2002
2003         Reviewed by Simon Fraser.
2004
2005         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
2006         spell checking from tests in iOS WebKit Legacy.
2007
2008         * WebCoreSupport/WebEditorClient.h:
2009         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
2010         * WebCoreSupport/WebEditorClient.mm:
2011         * WebView/WebView.h:
2012         * WebView/WebView.mm:
2013         (-[WebView toggleContinuousSpellChecking:]):
2014         (-[WebView toggleSmartInsertDelete:]):
2015
2016 2018-08-17  Alex Christensen  <achristensen@webkit.org>
2017
2018         Add some plumbing for safe browsing
2019         https://bugs.webkit.org/show_bug.cgi?id=188709
2020
2021         Reviewed by Tim Horton.
2022
2023         * WebCoreSupport/WebFrameLoaderClient.h:
2024         * WebCoreSupport/WebFrameLoaderClient.mm:
2025         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2026
2027 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
2028
2029         Replace canBubble and cancelable booleans in Event by enum classes
2030         https://bugs.webkit.org/show_bug.cgi?id=188692
2031
2032         Reviewed by Alex Christensen.
2033
2034         * WebView/WebPDFView.mm:
2035         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2036         * WebView/WebView.mm:
2037         (-[WebView _dispatchUnloadEvent]):
2038
2039 2018-08-16  Jer Noble  <jer.noble@apple.com>
2040
2041         Add Experimental Feature support for SourceBuffer.changeType()
2042         https://bugs.webkit.org/show_bug.cgi?id=188626
2043         <rdar://problem/43356021>
2044
2045         Reviewed by Eric Carlson.
2046
2047         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
2048
2049         * WebView/WebPreferenceKeysPrivate.h:
2050         * WebView/WebPreferences.mm:
2051         (+[WebPreferences initialize]):
2052         (-[WebPreferences sourceBufferChangeTypeEnabled]):
2053         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
2054         * WebView/WebPreferencesPrivate.h:
2055         * WebView/WebView.mm:
2056         (-[WebView _preferencesChanged:]):
2057
2058 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
2059
2060         Support drag-and-drop for input[type=color]
2061         https://bugs.webkit.org/show_bug.cgi?id=188464
2062
2063         Reviewed by Wenson Hsieh.
2064
2065         * WebCoreSupport/WebPlatformStrategies.h:
2066         * WebCoreSupport/WebPlatformStrategies.mm:
2067         (WebPlatformStrategies::setColor):
2068
2069 2018-08-15  Tim Horton  <timothy_horton@apple.com>
2070
2071         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
2072         https://bugs.webkit.org/show_bug.cgi?id=188569
2073         <rdar://problem/34201095>
2074
2075         Reviewed by Megan Gardner.
2076
2077         * WebView/WebImmediateActionController.mm:
2078         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
2079         Speculative fix; the crashes indicate font is null, but we just checked it,
2080         so it must be getting made null by convertFont:toSize:. Check again!
2081
2082 2018-08-13  Alex Christensen  <achristensen@webkit.org>
2083
2084         Use a 1-byte enum class for TextDirection
2085         https://bugs.webkit.org/show_bug.cgi?id=188350
2086
2087         Reviewed by Simon Fraser.
2088
2089         * WebCoreSupport/PopupMenuMac.mm:
2090         (PopupMenuMac::populate):
2091         (PopupMenuMac::show):
2092         * WebCoreSupport/WebFrameLoaderClient.mm:
2093         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2094         * WebView/WebFrame.mm:
2095         (-[WebFrame _dispatchDidReceiveTitle:]):
2096
2097 2018-08-09  Ali Juma  <ajuma@chromium.org>
2098
2099         Import WPTs for IntersectionObserver
2100         https://bugs.webkit.org/show_bug.cgi?id=188416
2101
2102         Reviewed by Simon Fraser.
2103
2104         * WebView/WebPreferencesPrivate.h:
2105
2106 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
2107
2108         Follow-up build fix for r234685
2109         https://bugs.webkit.org/show_bug.cgi?id=188245
2110
2111         Unreviewed build fix.
2112
2113         * WebCoreSupport/WebSecurityOriginPrivate.h:
2114
2115 2018-08-05  Darin Adler  <darin@apple.com>
2116
2117         [Cocoa] More tweaks and refactoring to prepare for ARC
2118         https://bugs.webkit.org/show_bug.cgi?id=188245
2119
2120         Reviewed by Dan Bernstein.
2121
2122         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
2123
2124         * Carbon/CarbonWindowFrame.m:
2125         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
2126
2127         * DOM/DOM.mm:
2128         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
2129         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
2130         garbage collection so this method isn't useful.
2131
2132         * DOM/DOMXPath.mm:
2133         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
2134         Objective-C garbage collection so this method isn't useful.
2135
2136         * History/WebHistory.mm:
2137         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
2138
2139         * Misc/WebElementDictionary.mm:
2140         (addLookupKey): Use a bridging cast.
2141         (cacheValueForKey): Ditto.
2142         (-[WebElementDictionary _fillCache]): Ditto.
2143         (-[WebElementDictionary objectForKey:]): Ditto.
2144
2145         * Misc/WebKitNSStringExtras.mm:
2146         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
2147         (-[NSString _web_widthWithFont:]): Ditto.
2148         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
2149
2150         * Misc/WebLocalizableStrings.mm:
2151         (WebLocalizedString): Use a bridging cast.
2152
2153         * Misc/WebNSDataExtras.mm:
2154         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
2155         and use CFBridgingRelease instead of calling autorelease directly.
2156         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
2157         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
2158         on the amount of explicit release and autorelease.
2159
2160         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
2161         * Misc/WebNSDictionaryExtras.m:
2162         (-[NSDictionary _webkit_intForKey:]): Deleted.
2163         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
2164         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
2165         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
2166         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
2167         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
2168         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
2169
2170         * Misc/WebStringTruncator.mm:
2171         (fontFromNSFont): Use a bridging cast.
2172
2173         * Plugins/Hosted/NetscapePluginHostManager.mm:
2174         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
2175
2176         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2177         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
2178         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
2179         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
2180         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
2181         * Plugins/Hosted/ProxyInstance.mm:
2182         (WebKit::ProxyInstance::getPropertyNames): Ditto.
2183         * Plugins/WebBasePluginPackage.mm:
2184         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
2185         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2186         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
2187         * Plugins/WebNetscapePluginPackage.mm:
2188         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
2189
2190         * Plugins/WebNetscapePluginView.mm:
2191         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
2192         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
2193         (-[WebNetscapePluginView status:]): Use a bridging cast.
2194         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
2195
2196         * Plugins/WebPluginController.mm:
2197         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
2198
2199         * Plugins/WebPluginDatabase.mm:
2200         (checkCandidate): Use explicit __strong for out argument types.
2201
2202         * Plugins/npapi.mm:
2203         (pluginViewForInstance): Use a bridging cast.
2204
2205         * Storage/WebDatabaseManager.mm:
2206         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
2207         explicit NSNumber and NSDictionary calls.
2208
2209         * WebCoreSupport/WebContextMenuClient.mm:
2210         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
2211
2212         * WebCoreSupport/WebEditorClient.mm:
2213         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
2214         (WebEditorClient::handleInputMethodKeydown): Ditto.
2215
2216         * WebCoreSupport/WebFrameNetworkingContext.mm:
2217         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
2218
2219         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
2220         as a struct rather than an Objective-C class, since that's how it's defined.
2221
2222         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
2223
2224         * WebView/WebFullScreenController.mm:
2225         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
2226         * WebView/WebHTMLView.mm:
2227         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2228         Ditto.
2229         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2230
2231         * WebView/WebImmediateActionController.mm:
2232         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
2233         go down to the document and then back to the frame.
2234         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
2235         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
2236         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
2237
2238         * WebView/WebJSPDFDoc.mm:
2239         (jsPDFDocInitialize): Removed some unneeded type casting.
2240         (jsPDFDocFinalize): Ditto.
2241         (jsPDFDocPrint): Use a bridging cast.
2242
2243         * WebView/WebPDFView.mm:
2244         (_applicationInfoForMIMEType): Use bridging casts.
2245
2246         * WebView/WebPreferences.mm:
2247         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
2248         instead of methods from WebNSDictionaryExtras.
2249         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
2250         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
2251         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
2252         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
2253         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
2254
2255         * WebView/WebView.mm:
2256         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
2257         (-[WebView _addToAllWebViewsSet]): Ditto.
2258         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
2259         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
2260         so it can be called from WebViewData methods.
2261
2262         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
2263         method, _windowVisibilityChanged:.
2264
2265         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
2266         called from WebViewData methods.
2267
2268 2018-08-06  Alex Christensen  <achristensen@webkit.org>
2269
2270         Use enum classes and OptionSets for PaintPhase and PaintBehavior
2271         https://bugs.webkit.org/show_bug.cgi?id=188323
2272
2273         Reviewed by Simon Fraser.
2274
2275         * WebCoreSupport/WebContextMenuClient.mm:
2276         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2277         * WebView/WebFrame.mm:
2278         (-[WebFrame _paintBehaviorForDestinationContext:]):
2279         (-[WebFrame _drawRect:contentsOnly:]):
2280         * WebView/WebHTMLView.mm:
2281         (imageFromRect):
2282         (selectionImage):
2283
2284 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2285
2286         Add support for microtasks in workers
2287         https://bugs.webkit.org/show_bug.cgi?id=188246
2288
2289         Reviewed by Darin Adler.
2290
2291         Rename JSMainThreadExecState.h to JSExecState.h.
2292
2293         * DOM/DOMAttr.mm:
2294         * DOM/DOMBlob.mm:
2295         * DOM/DOMCDATASection.mm:
2296         * DOM/DOMCSSCharsetRule.mm:
2297         * DOM/DOMCSSFontFaceRule.mm:
2298         * DOM/DOMCSSImportRule.mm:
2299         * DOM/DOMCSSMediaRule.mm:
2300         * DOM/DOMCSSPageRule.mm:
2301         * DOM/DOMCSSPrimitiveValue.mm:
2302         * DOM/DOMCSSRule.mm:
2303         * DOM/DOMCSSRuleList.mm:
2304         * DOM/DOMCSSStyleDeclaration.mm:
2305         * DOM/DOMCSSStyleRule.mm:
2306         * DOM/DOMCSSStyleSheet.mm:
2307         * DOM/DOMCSSUnknownRule.mm:
2308         * DOM/DOMCSSValue.mm:
2309         * DOM/DOMCSSValueList.mm:
2310         * DOM/DOMCharacterData.mm:
2311         * DOM/DOMComment.mm:
2312         * DOM/DOMCounter.mm:
2313         * DOM/DOMDocument.mm:
2314         * DOM/DOMDocumentFragment.mm:
2315         * DOM/DOMDocumentType.mm:
2316         * DOM/DOMElement.mm:
2317         * DOM/DOMEvent.mm:
2318         * DOM/DOMFile.mm:
2319         * DOM/DOMFileList.mm:
2320         * DOM/DOMHTML.mm:
2321         * DOM/DOMHTMLAnchorElement.mm:
2322         * DOM/DOMHTMLAppletElement.mm:
2323         * DOM/DOMHTMLAreaElement.mm:
2324         * DOM/DOMHTMLBRElement.mm:
2325         * DOM/DOMHTMLBaseElement.mm:
2326         * DOM/DOMHTMLBaseFontElement.mm:
2327         * DOM/DOMHTMLBodyElement.mm:
2328         * DOM/DOMHTMLButtonElement.mm:
2329         * DOM/DOMHTMLCanvasElement.mm:
2330         * DOM/DOMHTMLCollection.mm:
2331         * DOM/DOMHTMLDListElement.mm:
2332         * DOM/DOMHTMLDirectoryElement.mm:
2333         * DOM/DOMHTMLDivElement.mm:
2334         * DOM/DOMHTMLDocument.mm:
2335         * DOM/DOMHTMLElement.mm:
2336         * DOM/DOMHTMLEmbedElement.mm:
2337         * DOM/DOMHTMLFieldSetElement.mm:
2338         * DOM/DOMHTMLFontElement.mm:
2339         * DOM/DOMHTMLFormElement.mm:
2340         * DOM/DOMHTMLFrameElement.mm:
2341         * DOM/DOMHTMLFrameSetElement.mm:
2342         * DOM/DOMHTMLHRElement.mm:
2343         * DOM/DOMHTMLHeadElement.mm:
2344         * DOM/DOMHTMLHeadingElement.mm:
2345         * DOM/DOMHTMLHtmlElement.mm:
2346         * DOM/DOMHTMLIFrameElement.mm:
2347         * DOM/DOMHTMLImageElement.mm:
2348         * DOM/DOMHTMLInputElement.mm:
2349         * DOM/DOMHTMLLIElement.mm:
2350         * DOM/DOMHTMLLabelElement.mm:
2351         * DOM/DOMHTMLLegendElement.mm:
2352         * DOM/DOMHTMLLinkElement.mm:
2353         * DOM/DOMHTMLMapElement.mm:
2354         * DOM/DOMHTMLMarqueeElement.mm:
2355         * DOM/DOMHTMLMediaElement.mm:
2356         * DOM/DOMHTMLMenuElement.mm:
2357         * DOM/DOMHTMLMetaElement.mm:
2358         * DOM/DOMHTMLModElement.mm:
2359         * DOM/DOMHTMLOListElement.mm:
2360         * DOM/DOMHTMLObjectElement.mm:
2361         * DOM/DOMHTMLOptGroupElement.mm:
2362         * DOM/DOMHTMLOptionElement.mm:
2363         * DOM/DOMHTMLOptionsCollection.mm:
2364         * DOM/DOMHTMLParagraphElement.mm:
2365         * DOM/DOMHTMLParamElement.mm:
2366         * DOM/DOMHTMLPreElement.mm:
2367         * DOM/DOMHTMLQuoteElement.mm:
2368         * DOM/DOMHTMLScriptElement.mm:
2369         * DOM/DOMHTMLSelectElement.mm:
2370         * DOM/DOMHTMLStyleElement.mm:
2371         * DOM/DOMHTMLTableCaptionElement.mm:
2372         * DOM/DOMHTMLTableCellElement.mm:
2373         * DOM/DOMHTMLTableColElement.mm:
2374         * DOM/DOMHTMLTableElement.mm:
2375         * DOM/DOMHTMLTableRowElement.mm:
2376         * DOM/DOMHTMLTableSectionElement.mm:
2377         * DOM/DOMHTMLTextAreaElement.mm:
2378         * DOM/DOMHTMLTitleElement.mm:
2379         * DOM/DOMHTMLUListElement.mm:
2380         * DOM/DOMHTMLVideoElement.mm:
2381         * DOM/DOMImplementation.mm:
2382         * DOM/DOMKeyboardEvent.mm:
2383         * DOM/DOMMediaError.mm:
2384         * DOM/DOMMediaList.mm:
2385         * DOM/DOMMouseEvent.mm:
2386         * DOM/DOMMutationEvent.mm:
2387         * DOM/DOMNamedNodeMap.mm:
2388         * DOM/DOMNode.mm:
2389         * DOM/DOMNodeIterator.mm:
2390         * DOM/DOMNodeList.mm:
2391         * DOM/DOMOverflowEvent.mm:
2392         * DOM/DOMProcessingInstruction.mm:
2393         * DOM/DOMProgressEvent.mm:
2394         * DOM/DOMRGBColor.mm:
2395         * DOM/DOMRange.mm:
2396         * DOM/DOMRect.mm:
2397         * DOM/DOMStyleSheet.mm:
2398         * DOM/DOMStyleSheetList.mm:
2399         * DOM/DOMText.mm:
2400         * DOM/DOMTextEvent.mm:
2401         * DOM/DOMTimeRanges.mm:
2402         * DOM/DOMTokenList.mm:
2403         * DOM/DOMTreeWalker.mm:
2404         * DOM/DOMUIEvent.mm:
2405         * DOM/DOMWheelEvent.mm:
2406         * DOM/DOMXPathExpression.mm:
2407         * DOM/DOMXPathResult.mm:
2408         * DOM/ObjCEventListener.mm:
2409
2410 2018-08-03  Alex Christensen  <achristensen@webkit.org>
2411
2412         Fix spelling of "overridden"
2413         https://bugs.webkit.org/show_bug.cgi?id=188315
2414
2415         Reviewed by Darin Adler.
2416
2417         * Misc/WebKitVersionChecks.mm:
2418         (setWebKitLinkTimeVersion):
2419         (WebKitLinkTimeVersion):
2420         * Plugins/WebBaseNetscapePluginView.mm:
2421         (-[WebBaseNetscapePluginView handleMouseMoved:]):
2422         * WebCoreSupport/PopupMenuMac.mm:
2423         (PopupMenuMac::populate):
2424
2425 2018-08-01  Nan Wang  <n_wang@apple.com>
2426
2427         AX: AOM: Add ARIA IDL Attribute Reflection
2428         https://bugs.webkit.org/show_bug.cgi?id=184676
2429         <rdar://problem/39476882>
2430
2431         Reviewed by Chris Fleizach.
2432
2433         * WebView/WebPreferenceKeysPrivate.h:
2434         * WebView/WebPreferences.mm:
2435         (+[WebPreferences initialize]):
2436         (-[WebPreferences ariaReflectionEnabled]):
2437         (-[WebPreferences setAriaReflectionEnabled:]):
2438         * WebView/WebPreferencesPrivate.h:
2439         * WebView/WebView.mm:
2440         (-[WebView _preferencesChanged:]):
2441
2442 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
2443
2444         Shrink GraphicsLayerCA
2445         https://bugs.webkit.org/show_bug.cgi?id=188141
2446
2447         Reviewed by Zalan Bujtas.
2448
2449         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
2450         * moving all the clone-related stuff into the lazily-allocated m_layerClones
2451         * moving all the animation-related stuff into the lazily-allocated m_animations
2452         * making enums be 8-bit
2453         * re-ordering data members
2454
2455         * WebView/WebView.mm:
2456         (-[WebView _setMediaLayer:forPluginView:]):
2457
2458 2018-07-30  Rob Buis  <rbuis@igalia.com>
2459
2460         Merge PlatformCookieJar functions into NetworkStorageSession
2461         https://bugs.webkit.org/show_bug.cgi?id=188137
2462
2463         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
2464
2465         Reviewed by Alex Christensen.
2466
2467         * WebCoreSupport/WebPlatformStrategies.mm:
2468         (WebPlatformStrategies::cookiesForDOM):
2469         (WebPlatformStrategies::setCookiesFromDOM):
2470         (WebPlatformStrategies::cookiesEnabled):
2471         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2472         (WebPlatformStrategies::getRawCookies):
2473         (WebPlatformStrategies::deleteCookie):
2474         * WebView/WebPreferences.mm:
2475         (+[WebPreferences _clearNetworkLoaderSession]):
2476
2477 2018-07-28  Darin Adler  <darin@apple.com>
2478
2479         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
2480         https://bugs.webkit.org/show_bug.cgi?id=188140
2481
2482         Reviewed by Sam Weinig.
2483
2484         * WebView/WebImmediateActionController.mm:
2485         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
2486         new DictionaryLookup function that returns a tuple instead of using an out argument.
2487
2488 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
2489
2490         [INTL] Remove INTL sub-feature compile flags
2491         https://bugs.webkit.org/show_bug.cgi?id=188081
2492
2493         Reviewed by Michael Catanzaro.
2494
2495         * Configurations/FeatureDefines.xcconfig:
2496
2497 2018-07-26  Commit Queue  <commit-queue@webkit.org>
2498
2499         Unreviewed, rolling out r234181 and r234189.
2500         https://bugs.webkit.org/show_bug.cgi?id=188075
2501
2502         These are not needed right now (Requested by thorton on
2503         #webkit).
2504
2505         Reverted changesets:
2506
2507         "Enable Web Content Filtering on watchOS"
2508         https://bugs.webkit.org/show_bug.cgi?id=187979
2509         https://trac.webkit.org/changeset/234181
2510
2511         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
2512         https://bugs.webkit.org/show_bug.cgi?id=187985
2513         https://trac.webkit.org/changeset/234189
2514
2515 2018-07-26  Timothy Hatcher  <timothy@apple.com>
2516
2517         Use the Page's appearance when converting pasteboard attributed strings.
2518         https://bugs.webkit.org/show_bug.cgi?id=188067
2519         rdar://problem/42632246
2520
2521         Reviewed by Wenson Hsieh.
2522
2523         * WebCoreSupport/WebEditorClient.mm:
2524         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
2525
2526 2018-07-25  Chris Dumez  <cdumez@apple.com>
2527
2528         navigator.userAgent may return outdated value after webView.customUserAgent is set
2529         https://bugs.webkit.org/show_bug.cgi?id=188009
2530         <rdar://problem/42566456>
2531
2532         Reviewed by Alex Christensen.
2533
2534         Let the page know when the user agent changes.
2535
2536         * WebView/WebView.mm:
2537         (-[WebView _preferencesChanged:]):
2538         (-[WebView setApplicationNameForUserAgent:]):
2539         (-[WebView _invalidateUserAgentCache]):
2540         (-[WebView setCustomUserAgent:]):
2541         * WebView/WebViewInternal.h:
2542
2543 2018-07-24  Tim Horton  <timothy_horton@apple.com>
2544
2545         Enable Web Content Filtering on watchOS
2546         https://bugs.webkit.org/show_bug.cgi?id=187979
2547         <rdar://problem/42559346>
2548
2549         Reviewed by Wenson Hsieh.
2550
2551         * Configurations/FeatureDefines.xcconfig:
2552
2553 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
2554
2555         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
2556         https://bugs.webkit.org/show_bug.cgi?id=187846
2557
2558         Reviewed by Simon Fraser.
2559
2560         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
2561
2562         * WebView/WebHTMLView.mm:
2563         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
2564         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
2565
2566 2018-07-11  Dean Jackson  <dino@apple.com>
2567
2568         Allow removal of white backgrounds
2569         https://bugs.webkit.org/show_bug.cgi?id=187574
2570         <rdar://problem/41146792>
2571
2572         Reviewed by Simon Fraser.
2573
2574         Add a new WebPreference for punching out white backgrounds.
2575
2576         * WebView/WebPreferenceKeysPrivate.h:
2577         * WebView/WebPreferences.mm:
2578         (+[WebPreferences initialize]):
2579         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
2580         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
2581         * WebView/WebPreferencesPrivate.h:
2582         * WebView/WebView.mm:
2583         (-[WebView _preferencesChanged:]):
2584
2585 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
2586
2587         Ensure WebKit stack is ad-hoc signed
2588         https://bugs.webkit.org/show_bug.cgi?id=187667
2589
2590         Reviewed by Alexey Proskuryakov.
2591
2592         * Configurations/Base.xcconfig:
2593
2594 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
2595
2596         REGRESSION (231276): Attempting to copy an image fails
2597         https://bugs.webkit.org/show_bug.cgi?id=187212
2598         <rdar://problem/41540074>
2599
2600         Reviewed by Ryosuke Niwa.
2601
2602         Renamed methods to make it clear that one URL and one title are being passed in.
2603
2604         * WebCoreSupport/WebPlatformStrategies.h:
2605         * WebCoreSupport/WebPlatformStrategies.mm:
2606         (WebPlatformStrategies::setURL):
2607
2608 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
2609
2610         Disable cross-origin-window-policy by default
2611         https://bugs.webkit.org/show_bug.cgi?id=187509
2612
2613         Reviewed by Chris Dumez.
2614
2615         * WebView/WebPreferences.mm:
2616         (+[WebPreferences initialize]):
2617
2618 2018-07-09  Timothy Hatcher  <timothy@apple.com>
2619
2620         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2621         https://bugs.webkit.org/show_bug.cgi?id=187425
2622         rdar://problem/39948240
2623
2624         Reviewed by Tim Horton.
2625
2626         * WebView/WebView.mm:
2627         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
2628         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
2629         a call in this method to setUseDarkAppearance.
2630         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
2631         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
2632         (-[WebView _updateDefaultAppearance]): Deleted.
2633         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
2634
2635 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
2636
2637         Shrink various loading-related enums to shrink CachedResource
2638         https://bugs.webkit.org/show_bug.cgi?id=187443
2639
2640         Reviewed by Chris Dumez.
2641
2642         * WebCoreSupport/WebFrameLoaderClient.mm:
2643         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2644         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2645         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2646         (WebFrameLoaderClient::dispatchWillSendRequest):
2647         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2648         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2649         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2650         (WebFrameLoaderClient::updateGlobalHistory):
2651         (WebFrameLoaderClient::canHandleRequest const):
2652         * WebView/WebDataSource.mm:
2653         (-[WebDataSource initialRequest]):
2654         (-[WebDataSource request]):
2655
2656 2018-07-09  Commit Queue  <commit-queue@webkit.org>
2657
2658         Unreviewed, rolling out r233612.
2659         https://bugs.webkit.org/show_bug.cgi?id=187475
2660
2661         Revision caused the api test LinkColorWithSystemAppearance to
2662         fail on all systems. (Requested by Truitt on #webkit).
2663
2664         Reverted changeset:
2665
2666         "Semantic colors don't update when accessibility Increase
2667         Contrast mode is enabled."
2668         https://bugs.webkit.org/show_bug.cgi?id=187425
2669         https://trac.webkit.org/changeset/233612
2670
2671 2018-07-06  Timothy Hatcher  <timothy@apple.com>
2672
2673         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2674         https://bugs.webkit.org/show_bug.cgi?id=187425
2675         rdar://problem/39948240
2676
2677         Reviewed by Tim Horton.
2678
2679         * WebView/WebView.mm:
2680         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
2681         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
2682         a call in this method to setUseDarkAppearance.
2683         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
2684         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
2685         (-[WebView _updateDefaultAppearance]): Deleted.
2686         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
2687
2688 2018-07-05  Timothy Hatcher  <timothy@apple.com>
2689
2690         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
2691         https://bugs.webkit.org/show_bug.cgi?id=187369
2692         rdar://problem/41870420
2693
2694         Reviewed by Tim Horton.
2695
2696         * WebView/WebMediaPlaybackTargetPicker.mm:
2697         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
2698         * WebView/WebView.mm:
2699         (-[WebView _commonInitializationWithFrameName:groupName:]):
2700         (-[WebView _effectiveAppearanceIsDark]):
2701         (-[WebView _updateDefaultAppearance]):
2702         (-[WebView _defaultAppearance]): Deleted.
2703
2704 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
2705
2706         Youtube video pages crash after a couple of minutes
2707         https://bugs.webkit.org/show_bug.cgi?id=187316
2708
2709         Reviewed by Antti Koivisto.
2710
2711         * WebView/WebView.mm:
2712         (-[WebView _preferencesChanged:]):
2713
2714 2018-07-04  Tim Horton  <timothy_horton@apple.com>
2715
2716         Introduce PLATFORM(IOSMAC)
2717         https://bugs.webkit.org/show_bug.cgi?id=187315
2718
2719         Reviewed by Dan Bernstein.
2720
2721         * Configurations/Base.xcconfig:
2722         * Configurations/FeatureDefines.xcconfig:
2723
2724 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2725
2726         [iOS] DataTransfer.getData always returns the empty string when dropping text
2727         https://bugs.webkit.org/show_bug.cgi?id=187130
2728         <rdar://problem/41014117>
2729
2730         Reviewed by Ryosuke Niwa.
2731
2732         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
2733
2734         * WebCoreSupport/WebPlatformStrategies.h:
2735         * WebCoreSupport/WebPlatformStrategies.mm:
2736         (WebPlatformStrategies::allPasteboardItemInfo):
2737
2738 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
2739
2740         [Mac] AirPlay picker uses incorrect theme in Dark mode
2741         https://bugs.webkit.org/show_bug.cgi?id=187054
2742         <rdar://problem/41291093>
2743
2744         Reviewed by Timothy Hatcher.
2745
2746         * WebView/WebMediaPlaybackTargetPicker.mm:
2747         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
2748
2749 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2750
2751         [WTF] Add user-defined literal for ASCIILiteral
2752         https://bugs.webkit.org/show_bug.cgi?id=186839
2753
2754         Reviewed by Darin Adler.
2755
2756         * DOM/ExceptionHandlers.mm:
2757         (raiseDOMErrorException):
2758         * Plugins/Hosted/ProxyInstance.mm:
2759         (WebKit::ProxyInstance::invokeMethod):
2760         * Storage/WebDatabaseProvider.mm:
2761         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
2762
2763 2018-06-22  Timothy Hatcher  <timothy@apple.com>
2764
2765         Recalc styles every time defaultAppearance changes.
2766         https://bugs.webkit.org/show_bug.cgi?id=186866
2767         rdar://problem/41309805
2768
2769         Reviewed by Tim Horton.
2770
2771         * WebView/WebView.mm:
2772         (-[WebView _updateDefaultAppearance]):
2773         (-[WebView _setUseSystemAppearance:]):
2774         (-[WebView _useSystemAppearance]):
2775
2776 2018-06-20  Darin Adler  <darin@apple.com>
2777
2778         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
2779         https://bugs.webkit.org/show_bug.cgi?id=186875
2780
2781         Reviewed by Anders Carlsson.
2782
2783         * WebView/WebHTMLView.mm:
2784         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
2785         to write te file to.
2786         * WebView/WebPreferences.mm:
2787         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
2788         * WebView/WebView.mm:
2789         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
2790
2791 2018-06-12  Darin Adler  <darin@apple.com>
2792
2793         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
2794         https://bugs.webkit.org/show_bug.cgi?id=186526
2795
2796         Reviewed by Anders Carlsson.
2797
2798         * Plugins/Hosted/NetscapePluginHostManager.mm:
2799         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
2800
2801         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2802         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
2803         assignment rather than adoptNS/leakRef.
2804         * Plugins/WebNetscapePluginView.mm:
2805         (-[WebNetscapePluginView createPlugin]): Ditto.
2806
2807         * WebCoreSupport/WebContextMenuClient.mm:
2808         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
2809         RetainPtr::autorelease; no need to autorelease just to pass something as a function
2810         argument, so use RetainPtr::get instead.
2811
2812         * WebView/WebHTMLView.mm:
2813         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
2814         No need to autorelease the result when the return type is RetainPtr.
2815
2816         * WebView/WebPDFRepresentation.mm:
2817         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
2818
2819 2018-06-13  Youenn Fablet  <youenn@apple.com>
2820
2821         Supported plugin check should be based on plugin identifier
2822         https://bugs.webkit.org/show_bug.cgi?id=186578
2823         <rdar://problem/40523828>
2824
2825         Reviewed by Darin Adler.
2826
2827         * WebCoreSupport/WebPluginInfoProvider.h:
2828         * WebCoreSupport/WebPluginInfoProvider.mm:
2829         (WebPluginInfoProvider::pluginInfo):
2830         (WebPluginInfoProvider::webVisiblePluginInfo):
2831
2832 2018-06-13  Chris Dumez  <cdumez@apple.com>
2833
2834         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
2835         https://bugs.webkit.org/show_bug.cgi?id=186545
2836
2837         Reviewed by Brady Eidson.
2838
2839         Update client delegate now that parameter type has changed.
2840
2841         * WebCoreSupport/WebFrameLoaderClient.h:
2842         * WebCoreSupport/WebFrameLoaderClient.mm:
2843         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2844
2845 2018-06-11  Tim Horton  <timothy_horton@apple.com>
2846
2847         Link drag image is inconsistently unreadable in dark mode
2848         https://bugs.webkit.org/show_bug.cgi?id=186472
2849
2850         Reviewed by Timothy Hatcher.
2851
2852         * WebView/WebView.mm:
2853         (-[WebView _defaultAppearance]):
2854         Make defaultAppearance accurate even if useSystemAppearance is false.
2855         Some parts of WebKit (like the link drag image, but also context menus)
2856         want to be able to follow the system appearance regardless of whether
2857         the view or content has opted in.
2858
2859 2018-06-11  Chris Dumez  <cdumez@apple.com>
2860
2861         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
2862         https://bugs.webkit.org/show_bug.cgi?id=186441
2863
2864         Reviewed by Brady Eidson.
2865
2866         Rename existing flag to something a bit more generic, now that it is used for
2867         more things than bypassing the navigation policy check.
2868
2869         * WebView/WebView.mm:
2870         (-[WebView _loadBackForwardListFromOtherView:]):
2871         (-[WebView goToBackForwardItem:]):
2872
2873 2018-06-09  Dan Bernstein  <mitz@apple.com>
2874
2875         [Xcode] Clean up and modernize some build setting definitions
2876         https://bugs.webkit.org/show_bug.cgi?id=186463
2877
2878         Reviewed by Sam Weinig.
2879
2880         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
2881         * Configurations/DebugRelease.xcconfig: Ditto.
2882         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
2883           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
2884         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
2885         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
2886           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
2887         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
2888
2889 2018-06-08  Darin Adler  <darin@apple.com>
2890
2891         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
2892         https://bugs.webkit.org/show_bug.cgi?id=186436
2893
2894         Reviewed by Anders Carlsson.
2895
2896         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
2897         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
2898         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
2899         (PoolCleaner): Ditto.
2900
2901         * History/WebHistory.mm:
2902         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2903         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
2904         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
2905         now hardly used if at all.
2906         * WebView/WebView.mm:
2907         (-[WebView rectsForTextMatches]): Ditto.
2908
2909 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2910
2911         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
2912         https://bugs.webkit.org/show_bug.cgi?id=186442
2913         <rdar://problem/40879364>
2914
2915         Reviewed by Tim Horton.
2916
2917         * Configurations/FeatureDefines.xcconfig:
2918
2919 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
2920
2921         [Datalist] Allow TextFieldInputType to show and hide suggestions
2922         https://bugs.webkit.org/show_bug.cgi?id=186151
2923
2924         Reviewed by Tim Horton.
2925
2926         * WebCoreSupport/WebChromeClient.h:
2927         * WebCoreSupport/WebChromeClient.mm:
2928         (WebChromeClient::createDataListSuggestionPicker):
2929
2930 2018-06-07  Chris Dumez  <cdumez@apple.com>
2931
2932         Add base class to get WeakPtrFactory member and avoid some boilerplate code
2933         https://bugs.webkit.org/show_bug.cgi?id=186407
2934
2935         Reviewed by Brent Fulgham.
2936
2937         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
2938         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
2939         This also gets rid of old-style createWeakPtr() methods in favor of the newer
2940         makeWeakPtr().
2941
2942         * WebCoreSupport/WebEditorClient.h:
2943         * WebCoreSupport/WebEditorClient.mm:
2944         (WebEditorClient::requestCandidatesForSelection):
2945
2946 2018-06-05  Chris Dumez  <cdumez@apple.com>
2947
2948         Regression(r232082): Websites get loaded inside of Messages App chat transcript
2949         https://bugs.webkit.org/show_bug.cgi?id=186331
2950         <rdar://problem/40735446>
2951
2952         Reviewed by Darin Adler.
2953
2954         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
2955         but does not call use / ignore on the listener, then we would do "use" by default.
2956         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
2957         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
2958         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
2959         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
2960         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
2961         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
2962         and Box.app is still working properly.
2963
2964         * WebCoreSupport/WebFrameLoaderClient.h:
2965         * WebCoreSupport/WebFrameLoaderClient.mm:
2966         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2967         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2968         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2969         (WebFrameLoaderClient::dispatchWillSubmitForm):
2970         (WebFrameLoaderClient::setUpPolicyListener):
2971         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
2972         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
2973         (-[WebFramePolicyListener dealloc]):
2974         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
2975         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
2976
2977 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2978
2979         Adjust compile and runtime flags to match shippable state of features
2980         https://bugs.webkit.org/show_bug.cgi?id=186319
2981         <rdar://problem/40352045>
2982
2983         Reviewed by Maciej Stachowiak, Jon Lee, and others.
2984
2985         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
2986         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
2987         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
2988         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
2989         Cocoa builds.
2990
2991 2018-06-05  Timothy Hatcher  <timothy@apple.com>
2992
2993         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
2994
2995         https://bugs.webkit.org/show_bug.cgi?id=186323
2996         rdar://problem/38382252
2997
2998         Reviewed by Tim Horton.
2999
3000         * WebView/WebView.mm:
3001         (-[WebView _defaultAppearance]):
3002
3003 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3004
3005         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
3006         https://bugs.webkit.org/show_bug.cgi?id=186286
3007         <rdar://problem/40782992>
3008
3009         Reviewed by Dan Bernstein.
3010
3011         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
3012         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
3013         change this flag when preparing for a production release.
3014
3015         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
3016         whether experimental features should be enabled, and use it to properly define the
3017         feature flag.
3018
3019 2018-06-03  Darin Adler  <darin@apple.com>
3020
3021         Simplify and remove some unused video element code (helpful for ARC-compatibility)
3022         https://bugs.webkit.org/show_bug.cgi?id=186258
3023
3024         Reviewed by Daniel Bates.
3025
3026         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
3027         forward declarations. Removed methods that don't need to be public.
3028
3029         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
3030         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
3031         unnamed category in here and also replaced the HUDWindowControllerDelegate
3032         with the unnamed category. Removed unused NSWindow category defining the
3033         isOnActiveSpace, which is not called anywhere in this file at this time.
3034         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
3035         into setVideoElement.
3036         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
3037         and removed unneeded typecast.
3038         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
3039         using statement at the top of the file.
3040         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
3041         the many side effects and special considerations that this method that sounds
3042         like a setter has. Updated code to use the new
3043         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
3044         HTMLVideoElement::platformMedia function. Also straightened out the logic a
3045         bit and added some FIXME comments about small problems noticed but not fixed.
3046         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
3047         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
3048         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
3049         typecast. Removed call to updatePowerAssertions method.
3050         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
3051         updatePowerAssertions method.
3052         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
3053         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
3054         else, so this was dead code that did nothing.
3055         (-[WebVideoFullscreenController rateChanged:]): Removed call to
3056         updatePowerAssertions method.
3057
3058 2018-06-04  Chris Dumez  <cdumez@apple.com>
3059
3060         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
3061         https://bugs.webkit.org/show_bug.cgi?id=186287
3062         <rdar://problem/40783352>
3063
3064         Reviewed by Youenn Fablet.
3065
3066         * WebView/WebPreferenceKeysPrivate.h:
3067         * WebView/WebPreferences.mm:
3068         (+[WebPreferences initialize]):
3069         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
3070         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
3071         * WebView/WebPreferencesPrivate.h:
3072         * WebView/WebView.mm:
3073         (-[WebView _preferencesChanged:]):
3074
3075 2018-06-02  Darin Adler  <darin@apple.com>
3076
3077         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
3078         https://bugs.webkit.org/show_bug.cgi?id=186227
3079
3080         Reviewed by Dan Bernstein.
3081
3082         * Misc/WebKitErrors.m:
3083         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
3084         * Plugins/WebPluginDatabase.mm:
3085         (-[WebPluginDatabase refresh]): Ditto.
3086         * WebCoreSupport/WebChromeClient.mm:
3087         (WebChromeClient::setStatusbarText): Ditto.
3088
3089 2018-06-01  Chris Dumez  <cdumez@apple.com>
3090
3091         REGRESSION (r231456): Colloquy is broken
3092         https://bugs.webkit.org/show_bug.cgi?id=186197
3093         <rdar://problem/40722960>
3094
3095         Reviewed by Timothy Hatcher.
3096
3097         Restore pre-r231456 behavior for Colloquy app so that it works again.
3098
3099         * WebView/WebView.mm:
3100         (-[WebView _needsFrameNameFallbackToIdQuirk]):
3101         (-[WebView _preferencesChanged:]):
3102
3103 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
3104
3105         [JSC] Pass VM& parameter as much as possible
3106         https://bugs.webkit.org/show_bug.cgi?id=186085
3107
3108         Reviewed by Saam Barati.
3109
3110         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3111         (WebKit::NetscapePluginInstanceProxy::invoke):
3112
3113 2018-05-30  Daniel Bates  <dabates@apple.com>
3114
3115         NavigationAction does not need to hold initiating DOM Event
3116         https://bugs.webkit.org/show_bug.cgi?id=185958
3117         <rdar://problem/40531539>
3118
3119         Reviewed by Simon Fraser.
3120
3121         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
3122
3123         * WebCoreSupport/WebFrameLoaderClient.mm:
3124         (WebFrameLoaderClient::actionDictionary const):
3125         (findMouseEvent): Deleted.
3126
3127 2018-05-27  Dan Bernstein  <mitz@apple.com>
3128
3129         Reverted the changes made for https://webkit.org/b/186016
3130
3131         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
3132
3133
3134 2018-05-27  David Kilzer  <ddkilzer@apple.com>
3135
3136         [iOS] Fix warnings about leaks found by clang static analyzer
3137         <https://webkit.org/b/186009>
3138         <rdar://problem/40574267>
3139
3140         Reviewed by Daniel Bates.
3141
3142         * WebView/WebHTMLView.mm:
3143         (-[WebHTMLView doCommandBySelector:]): Fix use of an
3144         uninitialized boolean variable (`eventWasHandled`) that only
3145         happened on iOS.
3146
3147 2018-05-27  Dan Bernstein  <mitz@apple.com>
3148
3149         [Cocoa] Avoid importing directly from subumbrella frameworks
3150         https://bugs.webkit.org/show_bug.cgi?id=186016
3151
3152         Reviewed by Sam Weinig.
3153
3154         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
3155         * Carbon/CarbonWindowAdapter.mm: Ditto.
3156         * Carbon/CarbonWindowFrame.m: Ditto.
3157         * Carbon/HIViewAdapter.h: Ditto.
3158         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
3159           OTHER_CPLUSPLUSFLAGS.
3160         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
3161         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
3162         * WebView/WebPDFView.h: Ditto.
3163
3164 2018-05-27  Sam Weinig  <sam@webkit.org>
3165
3166         Modernize RenderStyleConstants.h - Part 3
3167         https://bugs.webkit.org/show_bug.cgi?id=186015
3168
3169         Reviewed by Yusuke Suzuki.
3170
3171         * WebView/WebView.mm:
3172         (-[WebView updateTextTouchBar]):
3173         Update for new enum name.
3174
3175 2018-05-25  Chris Dumez  <cdumez@apple.com>
3176
3177         Minor ApplicationCacheStorage clean up
3178         https://bugs.webkit.org/show_bug.cgi?id=185984
3179
3180         Reviewed by Youenn Fablet.
3181
3182         * WebCoreSupport/WebApplicationCache.mm:
3183         (+[WebApplicationCache originsWithCache]):
3184
3185 2018-05-25  David Kilzer  <ddkilzer@apple.com>
3186
3187         Fix issues with -dealloc methods found by clang static analyzer
3188         <https://webkit.org/b/185887>
3189
3190         Reviewed by Joseph Pecoraro.
3191
3192         * WebView/WebView.mm:
3193         (-[WebUITextIndicatorData dealloc]):
3194         - Move method implementation from (WebUITextIndicatorInternal)
3195           category to the main category since this is public API.  This
3196           fixes the false positive warning about a missing -dealloc
3197           method.
3198
3199 2018-05-24  Sam Weinig  <sam@webkit.org>
3200
3201         Modernize RenderStyleConstants.h - Part 2
3202         https://bugs.webkit.org/show_bug.cgi?id=185901
3203
3204         Reviewed by Simon Fraser.
3205
3206         * WebView/WebHTMLRepresentation.mm:
3207         (searchForLabelsBeforeElement):
3208         * WebView/WebView.mm:
3209         (nsTextAlignmentFromRenderStyle):
3210         Update for new enum names.
3211
3212 2018-05-22  Chris Dumez  <cdumez@apple.com>
3213
3214         Regression(AsyncPolicyDelegates): Box.app login Window is blank
3215         https://bugs.webkit.org/show_bug.cgi?id=185832
3216         <rdar://problem/40307871>
3217
3218         Reviewed by Geoffrey Garen.
3219
3220         We used to have a bug where where we would fail to wait for the policy decision for
3221         the navigation response from the client and the load would keep going, racing with
3222         the client's policy decision. If the client did not respond in time, the behavior
3223         would be the same as "Use" policy action.
3224
3225         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
3226         but the load happened to proceed anyway due to our bug. Now that we've fixed the
3227         WebKit bug, however, the load would hang because the completion handler for the
3228         decidePolicyForNavigationResponse would never get called.
3229
3230         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
3231         instead of retaining it. If the policy listener object gets destroyed because getting
3232         resolved, we now use "Use" policy action in its dealloc function to maintain previous
3233         behavior.
3234
3235         * WebCoreSupport/WebFrameLoaderClient.h:
3236         * WebCoreSupport/WebFrameLoaderClient.mm:
3237         (WebFrameLoaderClient::cancelPolicyCheck):
3238         (WebFrameLoaderClient::setUpPolicyListener):
3239         (-[WebFramePolicyListener dealloc]):
3240
3241 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
3242
3243         Unreviewed, rolling out r232052.
3244
3245         Breaks internal builds.
3246
3247         Reverted changeset:
3248
3249         "Use more C++17"
3250         https://bugs.webkit.org/show_bug.cgi?id=185176
3251         https://trac.webkit.org/changeset/232052
3252
3253 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
3254
3255         Use more C++17
3256         https://bugs.webkit.org/show_bug.cgi?id=185176
3257
3258         Reviewed by JF Bastien.
3259
3260         * Configurations/Base.xcconfig:
3261         * Configurations/WebKitLegacy.xcconfig:
3262
3263 2018-05-21  Chris Nardi  <cnardi@chromium.org>
3264
3265         Remove dead exception in MediaList.appendMedium
3266         https://bugs.webkit.org/show_bug.cgi?id=185278
3267
3268         Reviewed by Chris Dumez.
3269
3270         Remove code pertaining to an exception being thrown by appendMedium().
3271
3272         * DOM/DOMMediaList.mm:
3273         (-[DOMMediaList appendMedium:]):
3274
3275 2018-05-21  Jer Noble  <jer.noble@apple.com>
3276
3277         Complete fix for enabling modern EME by default
3278         https://bugs.webkit.org/show_bug.cgi?id=185770
3279         <rdar://problem/40368220>
3280
3281         Reviewed by Eric Carlson.
3282
3283         * Configurations/FeatureDefines.xcconfig:
3284
3285 2018-05-21  Antti Koivisto  <antti@apple.com>
3286
3287         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
3288         https://bugs.webkit.org/show_bug.cgi?id=185815
3289         <rdar://problem/40310069>
3290
3291         Reviewed by Simon Fraser.
3292
3293         User stylesheet parsing may depend on the colorFilterEnabled preference.
3294
3295         * WebView/WebView.mm:
3296         (-[WebView _preferencesChanged:]):
3297
3298 2018-05-18  Commit Queue  <commit-queue@webkit.org>
3299
3300         Unreviewed, rolling out r231982.
3301         https://bugs.webkit.org/show_bug.cgi?id=185793
3302
3303         Caused layout test failures (Requested by realdawei on
3304         #webkit).
3305
3306         Reverted changeset:
3307
3308         "Complete fix for enabling modern EME by default"
3309         https://bugs.webkit.org/show_bug.cgi?id=185770
3310         https://trac.webkit.org/changeset/231982
3311
3312 2018-05-18  Jer Noble  <jer.noble@apple.com>
3313
3314         Complete fix for enabling modern EME by default
3315         https://bugs.webkit.org/show_bug.cgi?id=185770
3316         <rdar://problem/40368220>
3317
3318         Reviewed by Eric Carlson.
3319
3320         * Configurations/FeatureDefines.xcconfig:
3321
3322 2018-05-18  Chris Dumez  <cdumez@apple.com>
3323
3324         Avoid keeping the frame alive when ref'ing a WindowProxy
3325         https://bugs.webkit.org/show_bug.cgi?id=185737
3326         <rdar://problem/40004666>
3327
3328         Reviewed by Sam Weinig.
3329
3330         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3331         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3332
3333 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
3334
3335         Add support for Intl NumberFormat formatToParts
3336         https://bugs.webkit.org/show_bug.cgi?id=185375
3337
3338         Reviewed by Yusuke Suzuki.
3339
3340         Add flag for NumberFormat formatToParts.
3341
3342         * Configurations/FeatureDefines.xcconfig:
3343
3344 2018-05-16  Chris Nardi  <cnardi@chromium.org>
3345
3346         Fixup after r231849: Do not mark Mac API methods as deprecated
3347         https://bugs.webkit.org/show_bug.cgi?id=185684
3348
3349         Reviewed by Darin Adler.
3350
3351         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
3352         as the entire class is already marked as deprecated, so it is unnecessary.
3353
3354         * DOM/DOMDocument.h:
3355
3356 2018-05-16  Chris Nardi  <cnardi@chromium.org>
3357
3358         Remove Document#selectedStylesheetSet/preferredStylesheetSet
3359         https://bugs.webkit.org/show_bug.cgi?id=185381
3360
3361         Reviewed by Darin Adler.
3362
3363         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
3364         and make them do nothing.
3365
3366         * DOM/DOMDocument.h:
3367         * DOM/DOMDocument.mm:
3368         (-[DOMDocument preferredStylesheetSet]):
3369         (-[DOMDocument selectedStylesheetSet]):
3370         (-[DOMDocument setSelectedStylesheetSet:]):
3371
3372 2018-05-15  Antoine Quint  <graouts@apple.com>
3373
3374         [Web Animations] Expose Web Animations CSS integration as an experimental feature
3375         https://bugs.webkit.org/show_bug.cgi?id=185647
3376
3377         Reviewed by Dean Jackson.
3378
3379         Rename the Web Animations CSS integration flag.
3380
3381         * WebView/WebPreferenceKeysPrivate.h:
3382         * WebView/WebPreferences.mm:
3383         (+[WebPreferences initialize]):
3384         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
3385         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
3386         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
3387         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
3388         * WebView/WebPreferencesPrivate.h:
3389         * WebView/WebView.mm:
3390         (-[WebView _preferencesChanged:]):
3391
3392 2018-05-14  Daniel Bates  <dabates@apple.com>
3393
3394         Fix the Apple Internal build
3395
3396         See <rdar://problem/40237873> for more details.
3397
3398         * WebView/WebFullScreenController.mm:
3399         (-[WebFullScreenController enterFullScreen:]):
3400         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3401         (-[WebFullScreenController exitFullScreen]):
3402         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3403         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3404         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3405
3406 2018-05-11  Timothy Hatcher  <timothy@apple.com>
3407
3408         WebHTMLView is not setting aside subviews when drawing.
3409
3410         https://bugs.webkit.org/show_bug.cgi?id=185561
3411         rdar://problem/40172894
3412
3413         Reviewed by Simon Fraser.
3414
3415         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
3416
3417         * WebView/WebHTMLView.mm:
3418         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
3419
3420 2018-05-07  Daniel Bates  <dabates@apple.com>
3421
3422         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
3423         https://bugs.webkit.org/show_bug.cgi?id=185170
3424
3425         Reviewed by Per Arne Vollan.
3426
3427         * Misc/WebCache.mm:
3428         (+[WebCache empty]):
3429
3430 2018-05-04  Timothy Hatcher  <timothy@apple.com>
3431
3432         Deprecate legacy WebView and friends
3433         https://bugs.webkit.org/show_bug.cgi?id=185279
3434         rdar://problem/33268700
3435
3436         Reviewed by Tim Horton.
3437
3438         Added deprecation macros to all the classes, extern strings, and enums.
3439
3440         * Configurations/WebKitLegacy.xcconfig:
3441         Added BUILDING_WEBKIT define to disable the deprecation macros.
3442         * DOM/DOMAbstractView.h:
3443         * DOM/DOMAttr.h:
3444         * DOM/DOMBlob.h:
3445         * DOM/DOMCDATASection.h:
3446         * DOM/DOMCSSCharsetRule.h:
3447         * DOM/DOMCSSFontFaceRule.h:
3448         * DOM/DOMCSSImportRule.h:
3449         * DOM/DOMCSSMediaRule.h:
3450         * DOM/DOMCSSPageRule.h:
3451         * DOM/DOMCSSPrimitiveValue.h:
3452         * DOM/DOMCSSRule.h:
3453         * DOM/DOMCSSRuleList.h:
3454         * DOM/DOMCSSStyleDeclaration.h:
3455         * DOM/DOMCSSStyleRule.h:
3456         * DOM/DOMCSSStyleSheet.h:
3457         * DOM/DOMCSSUnknownRule.h:
3458         * DOM/DOMCSSValue.h:
3459         * DOM/DOMCSSValueList.h:
3460         * DOM/DOMCharacterData.h:
3461         * DOM/DOMComment.h:
3462         * DOM/DOMCounter.h:
3463         * DOM/DOMDocument.h:
3464         * DOM/DOMDocumentFragment.h:
3465         * DOM/DOMDocumentType.h:
3466         * DOM/DOMElement.h:
3467         * DOM/DOMEntity.h:
3468         * DOM/DOMEntityReference.h:
3469         * DOM/DOMEvent.h:
3470         * DOM/DOMEventException.h:
3471         * DOM/DOMEventListener.h:
3472         * DOM/DOMEventTarget.h:
3473         * DOM/DOMException.h:
3474         * DOM/DOMFile.h:
3475         * DOM/DOMFileList.h:
3476         * DOM/DOMHTMLAnchorElement.h:
3477         * DOM/DOMHTMLAppletElement.h:
3478         * DOM/DOMHTMLAreaElement.h:
3479         * DOM/DOMHTMLBRElement.h:
3480         * DOM/DOMHTMLBaseElement.h:
3481         * DOM/DOMHTMLBaseFontElement.h:
3482         * DOM/DOMHTMLBodyElement.h:
3483         * DOM/DOMHTMLButtonElement.h:
3484         * DOM/DOMHTMLCanvasElement.h:
3485         * DOM/DOMHTMLCollection.h:
3486         * DOM/DOMHTMLDListElement.h:
3487         * DOM/DOMHTMLDirectoryElement.h:
3488         * DOM/DOMHTMLDivElement.h:
3489         * DOM/DOMHTMLDocument.h:
3490         * DOM/DOMHTMLElement.h:
3491         * DOM/DOMHTMLEmbedElement.h:
3492         * DOM/DOMHTMLFieldSetElement.h:
3493         * DOM/DOMHTMLFontElement.h:
3494         * DOM/DOMHTMLFormElement.h:
3495         * DOM/DOMHTMLFrameElement.h:
3496         * DOM/DOMHTMLFrameSetElement.h:
3497         * DOM/DOMHTMLHRElement.h:
3498         * DOM/DOMHTMLHeadElement.h:
3499         * DOM/DOMHTMLHeadingElement.h:
3500         * DOM/DOMHTMLHtmlElement.h:
3501         * DOM/DOMHTMLIFrameElement.h:
3502         * DOM/DOMHTMLImageElement.h:
3503         * DOM/DOMHTMLInputElement.h:
3504         * DOM/DOMHTMLLIElement.h:
3505         * DOM/DOMHTMLLabelElement.h:
3506         * DOM/DOMHTMLLegendElement.h:
3507         * DOM/DOMHTMLLinkElement.h:
3508         * DOM/DOMHTMLMapElement.h:
3509         * DOM/DOMHTMLMarqueeElement.h:
3510         * DOM/DOMHTMLMediaElement.h:
3511         * DOM/DOMHTMLMenuElement.h:
3512         * DOM/DOMHTMLMetaElement.h:
3513         * DOM/DOMHTMLModElement.h:
3514         * DOM/DOMHTMLOListElement.h:
3515         * DOM/DOMHTMLObjectElement.h:
3516         * DOM/DOMHTMLOptGroupElement.h:
3517         * DOM/DOMHTMLOptionElement.h:
3518         * DOM/DOMHTMLOptionsCollection.h:
3519         * DOM/DOMHTMLParagraphElement.h:
3520         * DOM/DOMHTMLParamElement.h:
3521         * DOM/DOMHTMLPreElement.h:
3522         * DOM/DOMHTMLQuoteElement.h:
3523         * DOM/DOMHTMLScriptElement.h:
3524         * DOM/DOMHTMLSelectElement.h:
3525         * DOM/DOMHTMLStyleElement.h:
3526         * DOM/DOMHTMLTableCaptionElement.h:
3527         * DOM/DOMHTMLTableCellElement.h:
3528         * DOM/DOMHTMLTableColElement.h:
3529         * DOM/DOMHTMLTableElement.h:
3530         * DOM/DOMHTMLTableRowElement.h:
3531         * DOM/DOMHTMLTableSectionElement.h:
3532         * DOM/DOMHTMLTextAreaElement.h:
3533         * DOM/DOMHTMLTitleElement.h:
3534         * DOM/DOMHTMLUListElement.h:
3535         * DOM/DOMHTMLVideoElement.h:
3536         * DOM/DOMImplementation.h:
3537         * DOM/DOMKeyboardEvent.h:
3538         * DOM/DOMMediaError.h:
3539         * DOM/DOMMediaList.h:
3540         * DOM/DOMMouseEvent.h:
3541         * DOM/DOMMutationEvent.h:
3542         * DOM/DOMNamedNodeMap.h:
3543         * DOM/DOMNode.h:
3544         * DOM/DOMNodeFilter.h:
3545         * DOM/DOMNodeIterator.h:
3546         * DOM/DOMNodeList.h:
3547         * DOM/DOMObject.h:
3548         * DOM/DOMOverflowEvent.h:
3549         * DOM/DOMProcessingInstruction.h:
3550         * DOM/DOMProgressEvent.h:
3551         * DOM/DOMRGBColor.h:
3552         * DOM/DOMRange.h:
3553         * DOM/DOMRangeException.h:
3554         * DOM/DOMRect.h:
3555         * DOM/DOMStyleSheet.h:
3556         * DOM/DOMStyleSheetList.h:
3557         * DOM/DOMText.h:
3558         * DOM/DOMTextEvent.h:
3559         * DOM/DOMTimeRanges.h:
3560         * DOM/DOMTokenList.h:
3561         * DOM/DOMTreeWalker.h:
3562         * DOM/DOMUIEvent.h:
3563         * DOM/DOMWheelEvent.h:
3564         * DOM/DOMXPathException.h:
3565         * DOM/DOMXPathExpression.h:
3566         * DOM/DOMXPathNSResolver.h:
3567         * DOM/DOMXPathResult.h:
3568         * History/WebBackForwardList.h:
3569         * History/WebHistory.h:
3570         * History/WebHistoryItem.h:
3571         * Misc/WebDownload.h:
3572         * Misc/WebKitErrors.h:
3573         * Plugins/WebPluginViewFactory.h:
3574         * WebView/WebArchive.h:
3575         * WebView/WebDataSource.h:
3576         * WebView/WebDocument.h:
3577         * WebView/WebEditingDelegate.h:
3578         * WebView/WebFormDelegate.h:
3579         * WebView/WebFrame.h:
3580         * WebView/WebFrameLoadDelegate.h:
3581         * WebView/WebFrameView.h:
3582         * WebView/WebPolicyDelegate.h:
3583         * WebView/WebPreferences.h:
3584         * WebView/WebPreferencesPrivate.h:
3585         * WebView/WebResourceLoadDelegate.h:
3586         * WebView/WebUIDelegate.h:
3587         * WebView/WebUIDelegatePrivate.h:
3588         * WebView/WebView.h:
3589         * WebView/WebViewPrivate.h:
3590         * postprocess-headers.sh:
3591         Remove step that converts WEBKIT macros to NS macros.
3592         Change it to just remove the macros on iOS builds.
3593
3594 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
3595
3596         [MediaStream] remove WK1 support
3597         https://bugs.webkit.org/show_bug.cgi?id=185136
3598
3599         Reviewed by Youenn Fablet.
3600
3601         * WebCoreSupport/WebUserMediaClient.h: Removed.
3602         * WebCoreSupport/WebUserMediaClient.mm: Removed.
3603         * WebView/WebView.mm:
3604         (-[WebView _commonInitializationWithFrameName:groupName:]):
3605         (-[WebView _preferencesChanged:]):
3606         (-[WebView _setUserMediaClient:]): Deleted.
3607         (-[WebView _userMediaClient]): Deleted.
3608         * WebView/WebViewData.h:
3609         * WebView/WebViewPrivate.h:
3610
3611 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
3612
3613         WebAssembly: add support for stream APIs - JavaScript API
3614         https://bugs.webkit.org/show_bug.cgi?id=183442
3615
3616         Reviewed by Yusuke Suzuki and JF Bastien.
3617
3618         Add WEBASSEMBLY_STREAMINNG_API feature flag
3619
3620         * Configurations/FeatureDefines.xcconfig:
3621
3622 2018-04-30  JF Bastien  <jfbastien@apple.com>
3623
3624         Use some C++17 features
3625         https://bugs.webkit.org/show_bug.cgi?id=185135
3626
3627         Reviewed by Alex Christensen.
3628
3629         * Configurations/WebKitLegacy.xcconfig:
3630
3631 2018-04-27  Chris Dumez  <cdumez@apple.com>
3632
3633         Use WindowProxy instead of DOMWindow in our IDL
3634         https://bugs.webkit.org/show_bug.cgi?id=185022
3635
3636         Reviewed by Sam Weinig.
3637
3638         * DOM/DOMAbstractView.mm:
3639         (kit):
3640         (toWindowProxy):
3641         * DOM/DOMAbstractViewInternal.h:
3642         * DOM/DOMDocument.mm:
3643         (-[DOMDocument defaultView]):
3644         (-[DOMDocument getComputedStyle:pseudoElement:]):
3645         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
3646         * DOM/DOMHTMLFrameElement.mm:
3647         (-[DOMHTMLFrameElement contentWindow]):
3648         * DOM/DOMHTMLIFrameElement.mm:
3649         (-[DOMHTMLIFrameElement contentWindow]):
3650         * DOM/DOMKeyboardEvent.mm:
3651         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
3652         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
3653         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
3654         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
3655         * DOM/DOMMouseEvent.mm:
3656         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
3657         * DOM/DOMTextEvent.mm:
3658         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
3659         * DOM/DOMUIEvent.mm:
3660         (-[DOMUIEvent view]):
3661         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
3662         * DOM/DOMWheelEvent.mm:
3663         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
3664
3665 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
3666
3667         Implement rendering support for the color-filter CSS property
3668         https://bugs.webkit.org/show_bug.cgi?id=185047
3669         rdar://problem/39664967
3670
3671         Reviewed by Tim Horton.
3672         
3673         The body background should reflect the filtered color.
3674
3675         * WebView/WebFrame.mm:
3676         (-[WebFrame _bodyBackgroundColor]):
3677         * WebView/WebView.mm:
3678         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
3679
3680 2018-04-26  Jer Noble  <jer.noble@apple.com>
3681
3682         WK_COCOA_TOUCH all the things.
3683         https://bugs.webkit.org/show_bug.cgi?id=185006
3684
3685         Reviewed by Tim Horton.
3686
3687         * Configurations/WebKitLegacy.xcconfig:
3688
3689 2018-04-26  Daniel Bates  <dabates@apple.com>
3690
3691         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
3692         https://bugs.webkit.org/show_bug.cgi?id=184161
3693         <rdar://problem/39051645>
3694
3695         Reviewed by Dan Bernstein.
3696
3697         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
3698         dropping a PDF embedded using an HTML image element into the same web view.
3699
3700         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
3701         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
3702         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
3703         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
3704         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
3705         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
3706         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
3707         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
3708         image document when navigated to directly. Since we can support dragging PDF document images we need to
3709         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
3710         We need to do both such queries before falling back to using the main resource of the Web Archive as
3711         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
3712         not an image document.
3713
3714         * Misc/WebNSPasteboardExtras.mm:
3715         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
3716
3717 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
3718
3719         Disable content filtering in minimal simulator mode
3720         https://bugs.webkit.org/show_bug.cgi?id=185027
3721         <rdar://problem/39736091>
3722
3723         Reviewed by Jer Noble.
3724
3725         * Configurations/FeatureDefines.xcconfig:
3726
3727 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
3728
3729         [INTL] Implement Intl.PluralRules
3730         https://bugs.webkit.org/show_bug.cgi?id=184312
3731
3732         Reviewed by JF Bastien.
3733
3734         Added Intl.PluralRules feature flag.
3735
3736         * Configurations/FeatureDefines.xcconfig:
3737
3738 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
3739
3740         Remove access to keychain from the WebContent process
3741         https://bugs.webkit.org/show_bug.cgi?id=184428
3742         <rdar://problem/13150903>
3743
3744         Reviewed by Brent Fulgham.
3745
3746         This patch does the followings:
3747         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
3748         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
3749         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
3750
3751         * WebCoreSupport/WebChromeClient.h:
3752         * WebCoreSupport/WebChromeClient.mm:
3753         (WebChromeClient::signedPublicKeyAndChallengeString const):
3754         * WebView/WebUIDelegatePrivate.h:
3755
3756 2018-04-24  Jer Noble  <jer.noble@apple.com>
3757
3758         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
3759         https://bugs.webkit.org/show_bug.cgi?id=184786
3760
3761         Reviewed by Tim Horton.
3762
3763         * Configurations/WebKitLegacy.xcconfig:
3764         * MigrateHeaders.make:
3765
3766 2018-04-23  Daniel Bates  <dabates@apple.com>
3767
3768         Implement Same-Site cookies
3769         https://bugs.webkit.org/show_bug.cgi?id=159464
3770         <rdar://problem/27196358>
3771
3772         Reviewed by Brent Fulgham.
3773
3774         Pass the Same-Site info through the strategy.
3775
3776         * WebCoreSupport/WebPlatformStrategies.h:
3777         * WebCoreSupport/WebPlatformStrategies.mm:
3778         (WebPlatformStrategies::cookiesForDOM):
3779         (WebPlatformStrategies::setCookiesFromDOM):
3780         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3781         (WebPlatformStrategies::getRawCookies):
3782
3783 2018-04-23  Zalan Bujtas  <zalan@apple.com>
3784
3785         [LayoutFormattingContext] Initial commit.
3786         https://bugs.webkit.org/show_bug.cgi?id=184896
3787
3788         Reviewed by Antti Koivisto.
3789
3790         * Configurations/FeatureDefines.xcconfig:
3791
3792 2018-04-23  Daniel Bates  <dabates@apple.com>
3793
3794         Implement Same-Site cookies
3795         https://bugs.webkit.org/show_bug.cgi?id=159464
3796         <rdar://problem/27196358>
3797
3798         Reviewed by Brent Fulgham.
3799
3800         Pass the Same-Site info through the strategy.
3801
3802         * WebCoreSupport/WebPlatformStrategies.h:
3803         * WebCoreSupport/WebPlatformStrategies.mm:
3804         (WebPlatformStrategies::cookiesForDOM):
3805         (WebPlatformStrategies::setCookiesFromDOM):
3806         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3807         (WebPlatformStrategies::getRawCookies):
3808
3809 2018-04-20  Timothy Hatcher  <timothy@apple.com>
3810
3811         NULL dereference crash sometimes under [super initWithCoder:] in WebView
3812
3813         https://bugs.webkit.org/show_bug.cgi?id=184851
3814         rdar://problem/39611236
3815
3816         Reviewed by Tim Horton.
3817
3818         * WebView/WebView.mm:
3819         (-[WebView _commonInitializationWithFrameName:groupName:]):
3820         (-[WebView effectiveAppearanceDidChange]):
3821         Added a null check and call the code later in initialization.
3822
3823 2018-04-20  Tim Horton  <timothy_horton@apple.com>
3824
3825         Adjust geolocation feature flag
3826         https://bugs.webkit.org/show_bug.cgi?id=184856
3827
3828         Reviewed by Wenson Hsieh.
3829
3830         * Configurations/FeatureDefines.xcconfig:
3831
3832 2018-04-18  Jer Noble  <jer.noble@apple.com>
3833
3834         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
3835         https://bugs.webkit.org/show_bug.cgi?id=184762
3836
3837         Reviewed by Dan Bernstein.
3838
3839         * Configurations/WebKitLegacy.xcconfig:
3840
3841 2018-04-20  Youenn Fablet  <youenn@apple.com>
3842
3843         Make PluginData cache its web visible plugins
3844         https://bugs.webkit.org/show_bug.cgi?id=184421
3845
3846         Reviewed by Chris Dumez.
3847
3848         * WebCoreSupport/WebPluginInfoProvider.h:
3849         * WebCoreSupport/WebPluginInfoProvider.mm:
3850         (WebPluginInfoProvider::pluginInfo):
3851         (WebPluginInfoProvider::webVisiblePluginInfo):
3852
3853 2018-04-19  Chris Dumez  <cdumez@apple.com>
3854
3855         Rename JSDOMWindowProxy to JSWindowProxy
3856         https://bugs.webkit.org/show_bug.cgi?id=184797
3857
3858         Reviewed by Sam Weinig.
3859
3860         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
3861
3862         * DOM/DOMUtility.mm:
3863         (createDOMWrapper):
3864         * WebView/WebFrame.mm:
3865         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3866
3867 2018-04-19  David Kilzer  <ddkilzer@apple.com>
3868
3869         Enable Objective-C weak references
3870         <https://webkit.org/b/184789>
3871         <rdar://problem/39571716>
3872
3873         Reviewed by Dan Bernstein.
3874
3875         * Configurations/Base.xcconfig:
3876         (CLANG_ENABLE_OBJC_WEAK): Enable.
3877
3878 2018-04-18  Chris Dumez  <cdumez@apple.com>
3879
3880         Rename WindowProxyController to WindowProxy
3881         https://bugs.webkit.org/show_bug.cgi?id=184756
3882
3883         Reviewed by Sam Weinig.
3884
3885         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
3886         needed use WindowProxyController type, which was a bit confusing.
3887
3888         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3889         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3890         * WebView/WebFrame.mm:
3891         (-[WebFrame _attachScriptDebugger]):
3892
3893 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
3894
3895         Unreviewed rollout of r230632. Regression in memory usage.
3896
3897         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
3898
3899         * WebView/WebPreferences.mm:
3900         (+[WebPreferences initialize]):
3901
3902 2018-04-17  Chris Dumez  <cdumez@apple.com>
3903
3904         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
3905         https://bugs.webkit.org/show_bug.cgi?id=184678
3906         <rdar://problem/39422122>
3907
3908         Reviewed by Alex Christensen.
3909
3910         Add new parameter to dispatchDecidePolicyForNavigationAction.
3911
3912         * WebCoreSupport/WebFrameLoaderClient.h:
3913         * WebCoreSupport/WebFrameLoaderClient.mm:
3914         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3915
3916 2018-04-13  Chris Dumez  <cdumez@apple.com>
3917
3918         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
3919         https://bugs.webkit.org/show_bug.cgi?id=184591
3920
3921         Reviewed by Sam Weinig.
3922
3923         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
3924         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
3925         This is work towards fixing Bug 184515.
3926
3927         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3928         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3929         * WebView/WebFrame.mm:
3930         (-[WebFrame _attachScriptDebugger]):
3931
3932 2018-04-12  Antoine Quint  <graouts@apple.com>
3933
3934         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
3935         https://bugs.webkit.org/show_bug.cgi?id=184569
3936         <rdar://problem/38671301>
3937
3938         Reviewed by Jon Lee.
3939
3940         * WebView/WebPreferences.mm:
3941
3942 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3943
3944         [WTF] Remove StaticLock
3945         https://bugs.webkit.org/show_bug.cgi?id=184332
3946
3947         Reviewed by Mark Lam.
3948
3949         * DOM/DOMInternal.mm:
3950         (getDOMWrapper):
3951         (addDOMWrapper):
3952         (removeDOMWrapper):
3953
3954 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
3955
3956         Failures from mach port reference handling should be fatal
3957         https://bugs.webkit.org/show_bug.cgi?id=184202
3958         <rdar://problem/37771114>
3959
3960         Reviewed by Anders Carlsson.
3961
3962         * Plugins/Hosted/NetscapePluginHostManager.mm:
3963         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
3964
3965 2018-04-03  Andy Estes  <aestes@apple.com>
3966
3967         [Mac] Prioritize file promises over filenames during drag and drop
3968         https://bugs.webkit.org/show_bug.cgi?id=184237
3969         <rdar://problem/38278076>
3970
3971         Reviewed by Wenson Hsieh.
3972
3973         * WebView/WebView.mm:
3974         (-[WebView performDragOperation:]):
3975
3976 2018-04-03  Chris Dumez  <cdumez@apple.com>
3977
3978         Drop MainFrame class
3979         https://bugs.webkit.org/show_bug.cgi?id=184191
3980
3981         Reviewed by Darin Adler.
3982
3983         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
3984         relationship between the Page and the MainFrame.
3985
3986         This is ground work for introducing LocalFrame / RemoteFrame concepts.
3987
3988         * WebCoreSupport/WebDragClient.mm:
3989         * WebCoreSupport/WebFrameLoaderClient.mm:
3990         * WebCoreSupport/WebInspectorClient.mm:
3991         * WebCoreSupport/WebPlatformStrategies.mm:
3992         * WebCoreSupport/WebPluginInfoProvider.mm:
3993         * WebView/WebFrame.mm:
3994         * WebView/WebFrameView.mm:
3995         * WebView/WebHTMLView.mm:
3996         * WebView/WebView.mm:
3997
3998 2018-04-02  Jer Noble  <jer.noble@apple.com>
3999
4000         Enable Legacy EME for all WebKit & WebKitLegacy clients
4001         https://bugs.webkit.org/show_bug.cgi?id=184018
4002         <rdar://problem/34887387>
4003
4004         Reviewed by Eric Carlson.
4005
4006         * WebView/WebPreferences.mm:
4007         (+[WebPreferences initialize]):
4008
4009 2018-03-29  JF Bastien  <jfbastien@apple.com>
4010
4011         Use Forward.h instead of forward-declaring WTF::String
4012         https://bugs.webkit.org/show_bug.cgi?id=184172
4013         <rdar://problem/39026146>
4014
4015         Reviewed by Yusuke Suzuki.
4016
4017         As part of #184164 I'm changing WTF::String, and the forward
4018         declarations are just wrong because I'm making it templated. We
4019         should use Forward.h anyways, so do that instead.
4020
4021         * WebView/WebScriptDebugger.h:
4022
4023 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
4024
4025         Protect against invalid mach ports returned by mach_port_request_notification
4026         https://bugs.webkit.org/show_bug.cgi?id=184106
4027         <rdar://problem/37865316>
4028
4029         Reviewed by Chris Dumez.
4030
4031         * Plugins/Hosted/NetscapePluginHostProxy.mm:
4032         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
4033         and clean up if it experienced an error.
4034         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
4035
4036 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
4037
4038         Avoid uninitialized mach ports
4039         https://bugs.webkit.org/show_bug.cgi?id=184090
4040         <rdar://problem/37261129>
4041
4042         Reviewed by Chris Dumez.
4043
4044         It is possible for mach_port_allocate to return an err