Remove AUDIO_TOOLBOX_AUDIO_SESSION
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-04-05  Eric Carlson  <eric.carlson@apple.com>
2
3         Remove AUDIO_TOOLBOX_AUDIO_SESSION
4         https://bugs.webkit.org/show_bug.cgi?id=196653
5         <rdar://problem/49652098>
6
7         Reviewed by Jer Noble.
8
9         * WebView/WebPreferences.mm:
10         (-[WebPreferences setAudioSessionCategoryOverride:]):
11
12 2019-04-05  Eric Carlson  <eric.carlson@apple.com>
13
14         Stop including <AudioToolbox/AudioSession.h>
15         https://bugs.webkit.org/show_bug.cgi?id=196648
16         <rdar://problem/39665771>
17
18         Reviewed by Jer Noble.
19
20         * WebView/WebPreferencesPrivate.h:
21
22 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
23
24         Have ScrollableArea store a ScrollType for the current scroll
25         https://bugs.webkit.org/show_bug.cgi?id=196627
26
27         Reviewed by Zalan Bujtas.
28
29         Send the programmatic scroll type.
30
31         * DOM/DOMHTML.mm:
32         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
33
34 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
35
36         -apple-trailing-word is needed for browser detection
37         https://bugs.webkit.org/show_bug.cgi?id=196575
38
39         Unreviewed.
40
41         * Configurations/FeatureDefines.xcconfig:
42
43 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
44
45         Remove support for -apple-trailing-word
46         https://bugs.webkit.org/show_bug.cgi?id=196525
47
48         Reviewed by Zalan Bujtas.
49
50         This CSS property is nonstandard and not used.
51
52         * Configurations/FeatureDefines.xcconfig:
53
54 2019-04-01  Alex Christensen  <achristensen@webkit.org>
55
56         Add SPI to canonicalize NSURLs with WTF::URL
57         https://bugs.webkit.org/show_bug.cgi?id=196415
58         <rdar://problem/44980271>
59
60         Reviewed by Darin Adler.
61
62         * Misc/WebNSURLExtras.h:
63         * Misc/WebNSURLExtras.mm:
64         (-[NSURL _webkit_canonicalize_with_wtf]):
65         _webkit_canonicalize is old and changing it causes strange bugs like rdar://problem/5315926
66         Instead, make a new version that uses WTF::URL to canonicalize an NSURL.
67
68 2019-03-31  Sam Weinig  <weinig@apple.com>
69
70         Remove more i386 specific configurations
71         https://bugs.webkit.org/show_bug.cgi?id=196430
72
73         Reviewed by Alexey Proskuryakov.
74
75         * Configurations/FeatureDefines.xcconfig:
76         ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
77
78 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
79
80         Delete WebMetal implementation in favor of WebGPU
81         https://bugs.webkit.org/show_bug.cgi?id=195418
82
83         Reviewed by Dean Jackson.
84
85         * Configurations/FeatureDefines.xcconfig:
86         * WebView/WebPreferenceKeysPrivate.h:
87         * WebView/WebPreferences.mm:
88         (+[WebPreferences initialize]):
89         (-[WebPreferences webMetalEnabled]): Deleted.
90         (-[WebPreferences setWebMetalEnabled:]): Deleted.
91         * WebView/WebPreferencesPrivate.h:
92         * WebView/WebView.mm:
93         (-[WebView _preferencesChanged:]):
94
95 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
96
97         Implement ResizeObserver.
98         https://bugs.webkit.org/show_bug.cgi?id=157743
99
100         Reviewed by Simon Fraser.
101
102         * Configurations/FeatureDefines.xcconfig:
103         * WebView/WebPreferenceKeysPrivate.h:
104         * WebView/WebPreferences.mm:
105         (+[WebPreferences initialize]):
106         (-[WebPreferences resizeObserverEnabled]):
107         (-[WebPreferences setResizeObserverEnabled:]):
108         * WebView/WebPreferencesPrivate.h:
109         * WebView/WebView.mm:
110         (-[WebView _preferencesChanged:]):
111         (-[WebView _flushCompositingChanges]): checkResizeObservations() in the begining.
112
113 2019-03-27  Ryosuke Niwa  <rniwa@webkit.org>
114
115         [macOS] Select element doesn't show popup if select element had lost focus while popup was previosuly shown
116         https://bugs.webkit.org/show_bug.cgi?id=196336
117
118         Reviewed by Tim Horton.
119
120         Fixed the bug that we were not actually dismissing the popup in PopupMenuMac::hide as done in WebKit2.
121
122         Unfortunately no new tests since intenals.isSelectPopupVisible would always return false in WebKit1.
123
124         * WebCoreSupport/PopupMenuMac.mm:
125         (PopupMenuMac::hide):
126
127 2019-03-25  Andy Estes  <aestes@apple.com>
128
129         [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
130         https://bugs.webkit.org/show_bug.cgi?id=194964
131         <rdar://problem/48279441>
132
133         Reviewed by Alex Christensen.
134
135         The WebDataSource._quickLookContent SPI accidentally relied on PreviewLoaders being leaked
136         to keep the temporary file referenced by WebQuickLookFileNameKey in existence. Since
137         PreviewLoaders are now being deleted properly, we teach WebDataSource to keep the
138         PreviewLoaderClient alive for its lifetime. This ensures that as long as
139         WebDataSource._quickLookContent can be called, the associated temp file will not be deleted
140         by WebKit.
141
142         * WebCoreSupport/WebFrameLoaderClient.mm:
143         (WebFrameLoaderClient::createPreviewLoaderClient):
144         * WebView/WebDataSource.mm:
145         (-[WebDataSource _quickLookPreviewLoaderClient]):
146         (-[WebDataSource _setQuickLookPreviewLoaderClient:]):
147         * WebView/WebDataSourceInternal.h:
148
149 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
150
151         Remove NavigatorContentUtils in WebCore/Modules
152         https://bugs.webkit.org/show_bug.cgi?id=196070
153
154         Reviewed by Alex Christensen.
155
156         NavigatorContentUtils was to support the custom scheme spec [1].
157         However, in WebKit side, no port has supported the feature in
158         WebKit layer after EFL port was removed. So there has been the
159         only IDL implementation of the NavigatorContentUtils in WebCore.
160         So we don't need to keep the implementation in WebKit.
161
162         * Configurations/FeatureDefines.xcconfig:
163
164 2019-03-22  Keith Rollin  <krollin@apple.com>
165
166         Enable ThinLTO support in Production builds
167         https://bugs.webkit.org/show_bug.cgi?id=190758
168         <rdar://problem/45413233>
169
170         Reviewed by Daniel Bates.
171
172         Enable building with Thin LTO in Production when using Xcode 10.2 or
173         later. This change results in a 1.45% progression in PLT5. Full
174         Production build times increase about 2-3%. Incremental build times
175         are more severely affected, and so LTO is not enabled for local
176         engineering builds.
177
178         LTO is enabled only on macOS for now, until rdar://problem/49013399,
179         which affects ARM builds, is fixed.
180
181         To change the LTO setting when building locally:
182
183         - If building with `make`, specify WK_LTO_MODE={none,thin,full} on the
184           command line.
185         - If building with `build-webkit`, specify --lto-mode={none,thin,full}
186           on the command line.
187         - If building with `build-root`, specify --lto={none,thin,full} on the
188           command line.
189         - If building with Xcode, create a LocalOverrides.xcconfig file at the
190           top level of your repository directory (if needed) and define
191           WK_LTO_MODE to full, thin, or none.
192
193         * Configurations/Base.xcconfig:
194
195 2019-03-21  Andy Estes  <aestes@apple.com>
196
197         [iOS] Apple Pay should be available in documents with no user agent scripts
198         https://bugs.webkit.org/show_bug.cgi?id=196061
199         <rdar://problem/48649391>
200
201         Reviewed by Brady Eidson.
202
203         * WebView/WebFrame.mm:
204         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
205
206 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
207
208         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
209         https://bugs.webkit.org/show_bug.cgi?id=196049
210
211         Reviewed by Tim Horton.
212
213         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
214         overflow scrolling in general, so rename it.
215
216         * Configurations/FeatureDefines.xcconfig:
217
218 2019-03-13  Dean Jackson  <dino@apple.com>
219
220         Block all plugins smaller than 5x5px
221         https://bugs.webkit.org/show_bug.cgi?id=195702
222         <rdar://problem/28435204>
223
224         Reviewed by Sam Weinig.
225
226         Removed a function that was never being called.
227
228         * WebCoreSupport/WebFrameLoaderClient.h:
229         * WebCoreSupport/WebFrameLoaderClient.mm:
230         (WebFrameLoaderClient::recreatePlugin): Deleted.
231
232 2019-03-13  Keith Rollin  <krollin@apple.com>
233
234         Add support for new StagedFrameworks layout
235         https://bugs.webkit.org/show_bug.cgi?id=195543
236
237         Reviewed by Alexey Proskuryakov.
238
239         When creating the WebKit layout for out-of-band Safari/WebKit updates,
240         use an optional path prefix when called for.
241
242         * Configurations/WebKitLegacy.xcconfig:
243
244 2019-03-12  Ryosuke Niwa  <rniwa@webkit.org>
245
246         Remove a site specific hack for AppleConnect plugin
247         https://bugs.webkit.org/show_bug.cgi?id=195643
248
249         Reviewed by Simon Fraser.
250
251         r66437 added a workaround for AppleConnect plugin.
252
253         Remove this code since Safari doesn't even use WebKitLegacy anymore,
254         and other WebKit clients support AppleConnect plugins.
255
256         * WebCoreSupport/WebFrameLoaderClient.mm:
257         (WebFrameLoaderClient::createPlugin):
258
259 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
260
261         Unreviewed, rolling out r242688, r242643, r242624.
262
263         Caused multiple layout test failures and crashes on iOS and macOS.
264
265         Reverted changeset:
266
267         "requestAnimationFrame should execute before the next frame"
268         https://bugs.webkit.org/show_bug.cgi?id=177484
269         https://trac.webkit.org/changeset/242624/webkit
270
271         * WebView/WebView.mm:
272         (-[WebView _viewWillDrawInternal]):
273
274 2019-03-09  Andy Estes  <aestes@apple.com>
275
276         [Apple Pay] CanMakePaymentsWithActiveCard and OpenPaymentSetup should be async messages
277         https://bugs.webkit.org/show_bug.cgi?id=195526
278         <rdar://problem/48745636>
279
280         Reviewed by Chris Dumez.
281
282         * WebCoreSupport/WebPaymentCoordinatorClient.h:
283         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
284         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
285         (WebPaymentCoordinatorClient::openPaymentSetup):
286
287 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
288
289         requestAnimationFrame should execute before the next frame
290         https://bugs.webkit.org/show_bug.cgi?id=177484
291
292         Reviewed by Simon Fraser.
293
294         * WebView/WebView.mm:
295         (-[WebView _viewWillDrawInternal]):
296         Call Page::renderingUpdate() which implements  "Update the rendering"
297         step of the HTML Event Loop specification.
298
299 2019-03-07  Zalan Bujtas  <zalan@apple.com>
300
301         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
302         https://bugs.webkit.org/show_bug.cgi?id=195353
303         <rdar://problem/48626394>
304
305         Reviewed by Simon Fraser.
306
307         * WebView/WebPreferenceKeysPrivate.h:
308         * WebView/WebPreferences.mm:
309         (+[WebPreferences initialize]):
310         (-[WebPreferences contentChangeObserverEnabled]):
311         (-[WebPreferences setContentChangeObserverEnabled:]):
312         * WebView/WebPreferencesPrivate.h:
313         * WebView/WebView.mm:
314         (-[WebView _preferencesChanged:]):
315
316 2019-03-06  Sam Weinig  <sam@webkit.org>
317
318         WebKitLegacy does not need to generate an export file for i386 anymore
319         https://bugs.webkit.org/show_bug.cgi?id=195380
320
321         Reviewed by Dan Bernstein.
322
323         * Configurations/WebKitLegacy.xcconfig:
324         Simplify EXPORTED_SYMBOLS_FILE down to just a single path to a generated file.
325         It still needs to be generated, since we are concatenating the shared exports
326         file with a macOS or iOS specific one.
327
328         * WebKit.mac.exp:
329         Remove i386 specific symbols that we were previously stripping.
330
331 2019-03-06  Rob Buis  <rbuis@igalia.com>
332
333         Consider supporting the `referrerpolicy` attribute.
334         https://bugs.webkit.org/show_bug.cgi?id=179053
335
336         Reviewed by Darin Adler.
337
338         Add a runtime flag for referrerpolicy attribute.
339
340         * WebView/WebPreferenceKeysPrivate.h:
341         * WebView/WebPreferences.mm:
342         (+[WebPreferences initialize]):
343         (-[WebPreferences referrerPolicyAttributeEnabled]):
344         (-[WebPreferences setReferrerPolicyAttributeEnabled:]):
345         * WebView/WebPreferencesPrivate.h:
346         * WebView/WebView.mm:
347         (-[WebView _preferencesChanged:]):
348
349 2019-03-03  Tim Horton  <timothy_horton@apple.com>
350
351         Remove some more unused 32-bit code
352         https://bugs.webkit.org/show_bug.cgi?id=195255
353
354         Reviewed by Darin Adler.
355
356         * Plugins/WebNetscapePluginEventHandler.mm:
357         (WebNetscapePluginEventHandler::create):
358         * Plugins/WebNetscapePluginView.h:
359         * Plugins/WebNetscapePluginView.mm:
360         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
361         (-[WebNetscapePluginView restorePortState:]):
362         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
363         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
364         (-[WebNetscapePluginView updateAndSetWindow]):
365         (-[WebNetscapePluginView setWindowIfNecessary]):
366         (-[WebNetscapePluginView createPlugin]):
367         (-[WebNetscapePluginView fini]):
368         (-[WebNetscapePluginView drawRect:]):
369         (-[WebNetscapePluginView invalidateRegion:]):
370         (-[WebNetscapePluginView getVariable:value:]):
371         (-[WebNetscapePluginView setVariable:value:]):
372         (isDrawingModelQuickDraw): Deleted.
373         (-[WebNetscapePluginView fixWindowPort]): Deleted.
374         (getQDPixelFormatForBitmapContext): Deleted.
375         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
376         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
377         * WebView/WebDelegateImplementationCaching.mm:
378
379 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
380
381         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
382         https://bugs.webkit.org/show_bug.cgi?id=195053
383         <rdar://problem/48134710>
384
385         Reviewed by Ryosuke Niwa.
386
387         * WebCoreSupport/WebEditorClient.h:
388
389 2019-03-01  Tim Horton  <timothy_horton@apple.com>
390
391         Remove unused code in WebKitLegacy
392         https://bugs.webkit.org/show_bug.cgi?id=189614
393
394         Reviewed by Simon Fraser.
395
396         * Carbon/CarbonUtils.h: Removed.
397         * Carbon/CarbonUtils.m: Removed.
398         * Carbon/CarbonWindowAdapter.h: Removed.
399         * Carbon/CarbonWindowAdapter.mm: Removed.
400         * Carbon/CarbonWindowContentView.h: Removed.
401         * Carbon/CarbonWindowContentView.m: Removed.
402         * Carbon/CarbonWindowFrame.h: Removed.
403         * Carbon/CarbonWindowFrame.m: Removed.
404         * Carbon/HIViewAdapter.h: Removed.
405         * Carbon/HIViewAdapter.m: Removed.
406         * Carbon/HIWebView.h: Removed.
407         * Carbon/HIWebView.mm: Removed.
408         * Configurations/WebKitLegacy.xcconfig:
409         * WebKit.mac.exp:
410
411 2019-03-01  Justin Fan  <justin_fan@apple.com>
412
413         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
414         https://bugs.webkit.org/show_bug.cgi?id=195191
415
416         Rubber-stamped by Dean Jackson.
417
418         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
419
420         * Configurations/FeatureDefines.xcconfig:
421
422 2019-02-28  Antoine Quint  <graouts@apple.com>
423
424         Enable the Pointer Events runtime flag by default
425         https://bugs.webkit.org/show_bug.cgi?id=195156
426
427         Reviewed by Dean Jackson.
428
429         * WebView/WebPreferences.mm:
430         (+[WebPreferences initialize]):
431
432 2019-02-28  Justin Fan  <justin_fan@apple.com>
433
434         [Web GPU] Enable Web GPU only on 64-bit
435         https://bugs.webkit.org/show_bug.cgi?id=195139
436
437         Because Metal is only supported on 64 bit apps.
438
439         Unreviewed build fix.
440
441         * Configurations/FeatureDefines.xcconfig:
442
443 2019-02-27  Antoine Quint  <graouts@apple.com>
444
445         Support Pointer Events on macOS
446         https://bugs.webkit.org/show_bug.cgi?id=195008
447         <rdar://problem/47454419>
448
449         Reviewed by Dean Jackson.
450
451         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
452
453         * Configurations/FeatureDefines.xcconfig:
454         * WebView/WebPreferenceKeysPrivate.h:
455         * WebView/WebPreferences.mm:
456         (+[WebPreferences initialize]):
457         (-[WebPreferences pointerEventsEnabled]):
458         (-[WebPreferences setPointerEventsEnabled:]):
459         * WebView/WebPreferencesPrivate.h:
460         * WebView/WebView.mm:
461         (-[WebView _preferencesChanged:]):
462
463 2019-02-23  Keith Miller  <keith_miller@apple.com>
464
465         Add new mac target numbers
466         https://bugs.webkit.org/show_bug.cgi?id=194955
467
468         Reviewed by Tim Horton.
469
470         * Configurations/Base.xcconfig:
471         * Configurations/DebugRelease.xcconfig:
472
473 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
474
475         Hardcode Visual Viewports on everywhere except iOS WK1
476         https://bugs.webkit.org/show_bug.cgi?id=194928
477
478         Reviewed by Zalan Bujtas.
479
480         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
481         change the default value of the Setting to 'true', and hardcode WebView on iOS to
482         set it to false. The setting has shipped for several years and there's no need to turn
483         it off now.
484
485         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
486         Visual Viewports are not enabled.
487         
488         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
489         that only runs in WK2
490
491         * WebView/WebPreferenceKeysPrivate.h:
492         * WebView/WebPreferences.mm:
493         (+[WebPreferences initialize]):
494         (-[WebPreferences visualViewportEnabled]): Deleted.
495         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
496         * WebView/WebPreferencesPrivate.h:
497         * WebView/WebView.mm:
498         (-[WebView _preferencesChanged:]):
499
500 2019-02-21  Darin Adler  <darin@apple.com>
501
502         Some refinements for Node and Document
503         https://bugs.webkit.org/show_bug.cgi?id=194764
504
505         Reviewed by Ryosuke Niwa.
506
507         * DOM/DOMDocument.mm:
508         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
509         through to WebCore or even looking at the arguments.
510         (-[DOMDocument getOverrideStyle::]): Ditto.
511
512 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
513
514         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
515         https://bugs.webkit.org/show_bug.cgi?id=194670
516         <rdar://problem/39066529>
517
518         Reviewed by Tim Horton.
519
520         * WebCoreSupport/WebEditorClient.h:
521         * WebCoreSupport/WebEditorClient.mm:
522         (WebEditorClient::replacementURLForResource): Deleted.
523         * WebCoreSupport/WebPlatformStrategies.h:
524         * WebCoreSupport/WebPlatformStrategies.mm:
525         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
526
527 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
528
529         Add MSE logging configuration
530         https://bugs.webkit.org/show_bug.cgi?id=194719
531         <rdar://problem/48122151>
532
533         Reviewed by Joseph Pecoraro.
534
535         * WebCoreSupport/WebChromeClient.mm:
536         (stringForMessageSource): Recognize the MSE message source.
537
538 2019-02-17  David Kilzer  <ddkilzer@apple.com>
539
540         Unreviewed, rolling out r241620.
541
542         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
543         (Requested by ddkilzer on #webkit.)
544
545         Reverted changeset:
546
547         "[WTF] Add environment variable helpers"
548         https://bugs.webkit.org/show_bug.cgi?id=192405
549         https://trac.webkit.org/changeset/241620
550
551 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
552
553         [WTF] Add environment variable helpers
554         https://bugs.webkit.org/show_bug.cgi?id=192405
555
556         Reviewed by Michael Catanzaro.
557
558         * WebView/WebView.mm:
559         (-[WebView _initWithFrame:frameName:groupName:]):
560         Utilize WTF::Environment where possible.
561
562 2019-02-15  Brian Burg  <bburg@apple.com>
563
564         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
565         https://bugs.webkit.org/show_bug.cgi?id=194411
566         <rdar://problem/47787614>
567
568         Reviewed by Joseph Pecoraro.
569
570         * Configurations/WebKitLegacy.xcconfig:
571         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
572
573         * WebCoreSupport/WebInspectorClient.mm:
574         (WebInspectorFrontendClient::localizedStringsURL):
575         (-[WebInspectorWindowController inspectorPagePath]):
576         (-[WebInspectorWindowController inspectorTestPagePath]):
577         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
578
579 2019-02-15  Commit Queue  <commit-queue@webkit.org>
580
581         Unreviewed, rolling out r241559 and r241566.
582         https://bugs.webkit.org/show_bug.cgi?id=194710
583
584         Causes layout test crashes under GuardMalloc (Requested by
585         ryanhaddad on #webkit).
586
587         Reverted changesets:
588
589         "[WTF] Add environment variable helpers"
590         https://bugs.webkit.org/show_bug.cgi?id=192405
591         https://trac.webkit.org/changeset/241559
592
593         "Unreviewed build fix for WinCairo Debug after r241559."
594         https://trac.webkit.org/changeset/241566
595
596 2019-02-15  Truitt Savell  <tsavell@apple.com>
597
598         Unreviewed, rolling out r241564.
599
600         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
601
602         Reverted changeset:
603
604         "[Mac] WebInspectorUI.framework does not need to be soft-
605         linked anymore"
606         https://bugs.webkit.org/show_bug.cgi?id=194411
607         https://trac.webkit.org/changeset/241564
608
609 2019-02-14  Brian Burg  <bburg@apple.com>
610
611         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
612         https://bugs.webkit.org/show_bug.cgi?id=194411
613         <rdar://problem/47787614>
614
615         Reviewed by Joseph Pecoraro.
616
617         * Configurations/WebKitLegacy.xcconfig:
618         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
619
620         * WebCoreSupport/WebInspectorClient.mm:
621         (WebInspectorFrontendClient::localizedStringsURL):
622         (-[WebInspectorWindowController inspectorPagePath]):
623         (-[WebInspectorWindowController inspectorTestPagePath]):
624         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
625
626 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
627
628         [WTF] Add environment variable helpers
629         https://bugs.webkit.org/show_bug.cgi?id=192405
630
631         Reviewed by Michael Catanzaro.
632
633         * WebView/WebView.mm:
634         (-[WebView _initWithFrame:frameName:groupName:]):
635         Utilize WTF::Environment where possible.
636
637 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
638
639         Allow pages to trigger programmatic paste from script on iOS
640         https://bugs.webkit.org/show_bug.cgi?id=194271
641         <rdar://problem/47808810>
642
643         Reviewed by Ryosuke Niwa.
644
645         See WebCore and WebKit ChangeLogs for more details.
646
647         * WebCoreSupport/WebEditorClient.h:
648
649 2019-02-12  Andy Estes  <aestes@apple.com>
650
651         [iOSMac] Enable Parental Controls Content Filtering
652         https://bugs.webkit.org/show_bug.cgi?id=194521
653         <rdar://39732376>
654
655         Reviewed by Tim Horton.
656
657         * Configurations/FeatureDefines.xcconfig:
658
659 2019-02-06  Andy Estes  <aestes@apple.com>
660
661         [Payment Request] It should be possible to require a phonetic name for shipping contacts
662         https://bugs.webkit.org/show_bug.cgi?id=194311
663         <rdar://46733045>
664
665         Reviewed by Alex Christensen.
666
667         * WebCoreSupport/WebPaymentCoordinatorClient.h:
668         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
669         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
670
671 2019-02-04  Said Abou-Hallawa  <said@apple.com>
672
673         [CG] Enable setAdditionalSupportedImageTypes for WK1
674         https://bugs.webkit.org/show_bug.cgi?id=194190
675
676         Reviewed by Tim Horton.
677
678         1. Define the preferences key AdditionalSupportedImageTypes.
679         2. Add additionalSupportedImageTypes as a private preference property.
680         3. Define the setter and the getter of the property.
681         4. Add function to convert from an id to an array of strings.
682         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
683
684         * WebView/WebPreferenceKeysPrivate.h:
685         * WebView/WebPreferences.mm:
686         (-[WebPreferences _stringArrayValueForKey:]):
687         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
688         (-[WebPreferences setAdditionalSupportedImageTypes:]):
689         (-[WebPreferences additionalSupportedImageTypes]):
690         * WebView/WebPreferencesPrivate.h:
691         * WebView/WebView.mm:
692         (-[WebView _preferencesChanged:]):
693
694 2019-02-04  Timothy Hatcher  <timothy@apple.com>
695
696         Add WebView SPI to temporarily force light or dark appearance on a page.
697         https://bugs.webkit.org/show_bug.cgi?id=194230
698
699         Reviewed by Tim Horton.
700
701         * WebView/WebView.mm:
702         (-[WebView _useDarkAppearance:]): Added.
703         (-[WebView _setUseDarkAppearance:]): Added.
704         * WebView/WebViewPrivate.h:
705
706 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
707
708         PageOverlayController's layers should be created lazily
709         https://bugs.webkit.org/show_bug.cgi?id=194199
710         rdar://problem/46571593
711
712         Reviewed by Tim Horton.
713
714         * WebCoreSupport/WebChromeClient.h:
715         * WebCoreSupport/WebChromeClient.mm:
716         (WebChromeClient::attachViewOverlayGraphicsLayer):
717
718 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
719
720         Make setNeedsLayout on the root more explicitly about triggering its side-effects
721         https://bugs.webkit.org/show_bug.cgi?id=194198
722
723         Reviewed by Antti Koivisto.
724
725         Call the newly named functions.
726
727         * WebView/WebFrame.mm:
728         (-[WebFrame setNeedsLayout]):
729         * WebView/WebHTMLView.mm:
730         (-[WebHTMLView setNeedsLayout:]):
731
732 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
733
734         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
735         https://bugs.webkit.org/show_bug.cgi?id=194189
736
737         Reviewed by Geoffrey Garen.
738
739         Pass the policy check identifier around functions and store it in WebFramePolicyListener
740         so that we can send it back to WebCore with the navigation policy decision.
741
742         * WebCoreSupport/WebFrameLoaderClient.h:
743         * WebCoreSupport/WebFrameLoaderClient.mm:
744         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
745         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
746         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
747         (WebFrameLoaderClient::dispatchWillSubmitForm):
748         (WebFrameLoaderClient::setUpPolicyListener):
749         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
750         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
751         (-[WebFramePolicyListener invalidate]):
752         (-[WebFramePolicyListener dealloc]):
753         (-[WebFramePolicyListener receivedPolicyDecision:]):
754         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
755         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
756
757 2019-01-31  Alex Christensen  <achristensen@webkit.org>
758
759         Revert r238819 which is unneeded and caused a performance regression.
760         https://bugs.webkit.org/show_bug.cgi?id=192272
761         <rdar://problem/46664625>
762
763         * WebCoreSupport/WebFrameLoaderClient.h:
764         * WebCoreSupport/WebFrameLoaderClient.mm:
765         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
766
767 2019-01-28  Devin Rousso  <drousso@apple.com>
768
769         Web Inspector: provide a way to edit page WebRTC settings on a remote target
770         https://bugs.webkit.org/show_bug.cgi?id=193863
771         <rdar://problem/47572764>
772
773         Reviewed by Joseph Pecoraro.
774
775         * WebView/WebView.mm:
776         (-[WebView _preferencesChanged:]):
777         Add page-level settings for WebRTC preferences.
778
779 2019-01-28  Andy Estes  <aestes@apple.com>
780
781         [watchOS] Enable Parental Controls content filtering
782         https://bugs.webkit.org/show_bug.cgi?id=193939
783         <rdar://problem/46641912>
784
785         Reviewed by Ryosuke Niwa.
786
787         * Configurations/FeatureDefines.xcconfig:
788
789 2019-01-28  Timothy Hatcher  <timothy@apple.com>
790
791         Make it easier for non-Apple ports to enable dark mode CSS support.
792         https://bugs.webkit.org/show_bug.cgi?id=193882
793
794         Reviewed by Megan Gardner.
795
796         * WebView/WebView.mm:
797         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
798         (-[WebView _effectiveAppearanceIsDark]): Ditto.
799
800 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
801
802         AX: Introduce a static accessibility tree
803         https://bugs.webkit.org/show_bug.cgi?id=193348
804         <rdar://problem/47203295>
805
806         Reviewed by Ryosuke Niwa.
807
808         * Configurations/FeatureDefines.xcconfig:
809
810 2019-01-25  Keith Rollin  <krollin@apple.com>
811
812         Update WebKitAdditions.xcconfig with correct order of variable definitions
813         https://bugs.webkit.org/show_bug.cgi?id=193793
814         <rdar://problem/47532439>
815
816         Reviewed by Alex Christensen.
817
818         XCBuild changes the way xcconfig variables are evaluated. In short,
819         all config file assignments are now considered in part of the
820         evaluation. When using the new build system and an .xcconfig file
821         contains multiple assignments of the same build setting:
822
823         - Later assignments using $(inherited) will inherit from earlier
824           assignments in the xcconfig file.
825         - Later assignments not using $(inherited) will take precedence over
826           earlier assignments. An assignment to a more general setting will
827           mask an earlier assignment to a less general setting. For example,
828           an assignment without a condition ('FOO = bar') will completely mask
829           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
830
831         This affects some of our .xcconfig files, in that sometimes platform-
832         or sdk-specific definitions appear before the general definitions.
833         Under the new evaluations rules, the general definitions alway take
834         effect because they always overwrite the more-specific definitions. The
835         solution is to swap the order, so that the general definitions are
836         established first, and then conditionally overwritten by the
837         more-specific definitions.
838
839         * Configurations/Version.xcconfig:
840         * Configurations/WebKitLegacy.xcconfig:
841
842 2019-01-25  David Kilzer  <ddkilzer@apple.com>
843
844         Move soft-linking of Lookup.framework out of LookupSPI.h
845         <https://webkit.org/b/193815>
846
847         Reviewed by Tim Horton.
848
849         * WebView/WebImmediateActionController.mm:
850         (-[WebImmediateActionController _animationControllerForText]):
851         * WebView/WebView.mm:
852         (-[WebView _prepareForDictionaryLookup]):
853         - Move soft-linking to LookupSoftLink.{h,mm}.
854
855 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
856
857         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
858         https://bugs.webkit.org/show_bug.cgi?id=193829
859
860         Reviewed by Tim Horton.
861
862         * WebCoreSupport/WebDragClient.mm:
863         (WebDragClient::didConcludeEditDrag):
864         * WebView/WebView.mm:
865         (-[WebView _requestStartDataInteraction:globalPosition:]):
866         (-[WebView _didConcludeEditDrag]):
867         (-[WebView _didConcludeEditDataInteraction]): Deleted.
868         * WebView/WebViewInternal.h:
869
870 2019-01-24  John Wilander  <wilander@apple.com>
871
872         Add Ad Click Attribution as an internal/experimental feature
873         https://bugs.webkit.org/show_bug.cgi?id=193685
874         <rdar://problem/47450399>
875
876         Reviewed by Brent Fulgham.
877
878         * WebView/WebPreferenceKeysPrivate.h:
879         * WebView/WebPreferences.mm:
880         (+[WebPreferences initialize]):
881         (-[WebPreferences adClickAttributionEnabled]):
882         (-[WebPreferences setAdClickAttributionEnabled:]):
883             Added support for experimental ad click attribution.
884         * WebView/WebPreferencesPrivate.h:
885         * WebView/WebView.mm:
886         (-[WebView _preferencesChanged:]):
887
888 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
889
890         Move FileSystem to WTF
891         https://bugs.webkit.org/show_bug.cgi?id=193602
892
893         Reviewed by Yusuke Suzuki.
894
895         * Misc/WebNSFileManagerExtras.mm:
896         * Storage/WebDatabaseProvider.mm:
897         * WebView/WebView.mm:
898
899 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
900
901         Fix the Apple Internal build. See <rdar://problem/47491383>.
902
903         Rubber-stamped by Tim Horton.
904
905         * WebCoreSupport/WebFrameLoaderClient.mm:
906
907 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
908
909         Clean up USE(WEB_THREAD)
910         https://bugs.webkit.org/show_bug.cgi?id=193698
911
912         Rubber-stamped by Tim Horton.
913
914         * Misc/WebCache.mm:
915         (+[WebCache emptyInMemoryResources]):
916         * WebCoreSupport/WebFrameLoaderClient.mm:
917         (-[WebFramePolicyListener use]):
918         * WebCoreSupport/WebGeolocationClient.mm:
919         (-[WebGeolocationPolicyListener allow]):
920         (-[WebGeolocationPolicyListener deny]):
921         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
922         * WebView/WebFrame.mm:
923         (-[WebFrame deviceOrientationChanged]):
924         * WebView/WebHTMLView.mm:
925         (hardwareKeyboardAvailabilityChangedCallback):
926         * WebView/WebView.mm:
927         (+[WebView _releaseMemoryNow]):
928         (+[WebView willEnterBackgroundWithCompletionHandler:]):
929         (-[WebView updateLayoutIgnorePendingStyleSheets]):
930         (-[WebView _dispatchUnloadEvent]):
931         (-[WebView _close]):
932         (-[WebView _preferencesChangedNotification:]):
933         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
934         (-[WebView goBack]):
935         (-[WebView goForward]):
936         (+[WebView _cacheModelChangedNotification:]):
937         (-[WebView stopLoading:]):
938         (-[WebView stopLoadingAndClear]):
939         (-[WebView reload:]):
940         (WebInstallMemoryPressureHandler):
941
942 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
943
944         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
945         https://bugs.webkit.org/show_bug.cgi?id=193706
946         <rdar://problem/44807048>
947
948         Reviewed by Ryosuke Niwa.
949
950         Use UndoStep::label().
951
952         * WebCoreSupport/WebEditorClient.h:
953         * WebCoreSupport/WebEditorClient.mm:
954         (-[WebUndoStep initWithUndoStep:]):
955         (+[WebUndoStep stepWithUndoStep:]):
956         (WebEditorClient::registerUndoOrRedoStep):
957         (WebEditorClient::registerUndoStep):
958         (WebEditorClient::registerRedoStep):
959
960 2019-01-22  Alex Christensen  <achristensen@webkit.org>
961
962         Move NetworkStorageSession ownership to NetworkProcess
963         https://bugs.webkit.org/show_bug.cgi?id=193580
964
965         Reviewed by Geoff Garen.
966
967         * Misc/WebCache.mm:
968         (+[WebCache clearCachedCredentials]):
969         * Misc/WebDownload.mm:
970         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
971         * Plugins/WebBaseNetscapePluginView.mm:
972         (WebKit::getAuthenticationInfo):
973         * WebCoreSupport/WebFrameNetworkingContext.mm:
974         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
975         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
976         (WebFrameNetworkingContext::storageSession const):
977         * WebView/WebPreferences.mm:
978         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
979         (+[WebPreferences _clearNetworkLoaderSession]):
980         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
981
982 2019-01-22  Daniel Bates  <dabates@apple.com>
983
984         [iOS] Interpret text key commands on keydown and app key commands on keypress
985         https://bugs.webkit.org/show_bug.cgi?id=192897
986         <rdar://problem/46857378>
987
988         Reviewed by Brent Fulgham.
989
990         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
991         is false) and keypress (isCharEvent is true), respectively.
992
993         * WebView/WebHTMLView.mm:
994         (-[WebHTMLView _handleEditingKeyEvent:]):
995
996 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
997
998         [css-logical] Implement flow-relative margin, padding and border shorthands
999         https://bugs.webkit.org/show_bug.cgi?id=188697
1000
1001         Reviewed by Simon Fraser and Antti Koivisto.
1002
1003         Add CSSLogicalEnabled runtime flag.
1004
1005         * WebView/WebPreferenceKeysPrivate.h:
1006         * WebView/WebPreferences.mm:
1007         (+[WebPreferences initialize]):
1008         (-[WebPreferences cssLogicalEnabled]):
1009         (-[WebPreferences setCSSLogicalEnabled:]):
1010         * WebView/WebPreferencesPrivate.h:
1011         * WebView/WebView.mm:
1012         (-[WebView _preferencesChanged:]):
1013
1014 2019-01-15  Darin Adler  <darin@apple.com>
1015
1016         Use references rather than pointers for register/unregister functions, and more
1017         https://bugs.webkit.org/show_bug.cgi?id=175028
1018
1019         Reviewed by Daniel Bates.
1020
1021         * WebCoreSupport/WebKitFullScreenListener.mm:
1022         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
1023         functions in Document; pass a reference.
1024         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
1025         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
1026         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
1027         * WebView/WebFullScreenController.mm:
1028         (-[WebFullScreenController enterFullScreen:]): Ditto.
1029         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
1030         (-[WebFullScreenController exitFullScreen]): Ditto.
1031         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
1032         * WebView/WebFullScreenController.mm:
1033         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
1034
1035 2019-01-12  Dan Bernstein  <mitz@apple.com>
1036
1037         [Cocoa] Avoid importing directly from subumbrella frameworks
1038         https://bugs.webkit.org/show_bug.cgi?id=186016
1039         <rdar://problem/40591038>
1040
1041         Reviewed by Sam Weinig.
1042
1043         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1044         * Carbon/CarbonWindowAdapter.mm: Ditto.
1045         * Carbon/CarbonWindowFrame.m: Ditto.
1046         * Carbon/HIViewAdapter.h: Ditto.
1047         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1048           OTHER_CFLAGS_COCOA_TOUCH_NO.
1049         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1050         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1051         * WebView/WebPDFView.h: Ditto.
1052
1053 2019-01-20  Antoine Quint  <graouts@apple.com>
1054
1055         Add a POINTER_EVENTS feature flag
1056         https://bugs.webkit.org/show_bug.cgi?id=193577
1057         <rdar://problem/47408511>
1058
1059         Unreviewed. Also enable Pointer Events for iosmac.
1060
1061         * Configurations/FeatureDefines.xcconfig:
1062
1063 2019-01-19  Antoine Quint  <graouts@apple.com>
1064
1065         Add a POINTER_EVENTS feature flag
1066         https://bugs.webkit.org/show_bug.cgi?id=193577
1067
1068         Reviewed by Dean Jackson.
1069
1070         * Configurations/FeatureDefines.xcconfig:
1071
1072 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
1073
1074         Revert r238815, it broke WK1 video fullscreen on Mac
1075         https://bugs.webkit.org/show_bug.cgi?id=193586
1076         <rdar://problem/47358941>
1077
1078         Reviewed by Jer Noble.
1079
1080         * WebView/WebVideoFullscreenController.h: Added.
1081         * WebView/WebVideoFullscreenController.mm: Added.
1082         (SOFT_LINK_CLASS):
1083         (-[WebVideoFullscreenController init]):
1084         (-[WebVideoFullscreenController dealloc]):
1085         (-[WebVideoFullscreenController fullscreenWindow]):
1086         (-[WebVideoFullscreenController windowDidLoad]):
1087         (-[WebVideoFullscreenController videoElement]):
1088         (-[WebVideoFullscreenController setVideoElement:]):
1089         (-[WebVideoFullscreenController clearFadeAnimation]):
1090         (-[WebVideoFullscreenController windowDidExitFullscreen]):
1091         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
1092         (-[WebVideoFullscreenController videoElementRect]):
1093         (-[WebVideoFullscreenController applicationDidResignActive:]):
1094         (frameExpandedToRatioOfFrame):
1095         (createBackgroundFullscreenWindow):
1096         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
1097         (-[WebVideoFullscreenController enterFullscreen:]):
1098         (-[WebVideoFullscreenController exitFullscreen]):
1099         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
1100         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
1101         (-[WebVideoFullscreenController _requestExit]):
1102         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
1103         (-[WebVideoFullscreenController requestExitFullscreen]):
1104         (-[WebVideoFullscreenController fadeHUDIn]):
1105         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
1106         (-[WebVideoFullscreenController rateChanged:]):
1107         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1108         (-[WebVideoFullscreenWindow dealloc]):
1109         (-[WebVideoFullscreenWindow resignFirstResponder]):
1110         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
1111         (-[WebVideoFullscreenWindow mouseDown:]):
1112         (-[WebVideoFullscreenWindow cancelOperation:]):
1113         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
1114         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
1115         (-[WebVideoFullscreenWindow animationDidEnd:]):
1116         (-[WebVideoFullscreenWindow mouseMoved:]):
1117         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
1118         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
1119         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
1120         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
1121         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
1122         (-[WebVideoFullscreenHUDWindow center]):
1123         (-[WebVideoFullscreenHUDWindow keyDown:]):
1124         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
1125         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
1126         (-[WebVideoFullscreenHUDWindowController init]):
1127         (-[WebVideoFullscreenHUDWindowController dealloc]):
1128         (-[WebVideoFullscreenHUDWindowController setArea:]):
1129         (-[WebVideoFullscreenHUDWindowController keyDown:]):
1130         (-[WebVideoFullscreenHUDWindowController delegate]):
1131         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
1132         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
1133         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
1134         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
1135         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
1136         (-[WebVideoFullscreenHUDWindowController closeWindow]):
1137         (createMediaUIControl):
1138         (createControlWithMediaUIControlType):
1139         (createTimeTextField):
1140         (createMediaUIBackgroundView):
1141         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
1142         (-[WebVideoFullscreenHUDWindowController updateVolume]):
1143         (-[WebVideoFullscreenHUDWindowController updateTime]):
1144         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
1145         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
1146         (-[WebVideoFullscreenHUDWindowController currentTime]):
1147         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
1148         (-[WebVideoFullscreenHUDWindowController duration]):
1149         (-[WebVideoFullscreenHUDWindowController maxVolume]):
1150         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
1151         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
1152         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
1153         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
1154         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
1155         (-[WebVideoFullscreenHUDWindowController volume]):
1156         (-[WebVideoFullscreenHUDWindowController setVolume:]):
1157         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
1158         (-[WebVideoFullscreenHUDWindowController updateRate]):
1159         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
1160         (-[WebVideoFullscreenHUDWindowController playing]):
1161         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
1162         (timeToString):
1163         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
1164         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
1165         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
1166         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
1167         (-[WebVideoFullscreenHUDWindowController rewind:]):
1168         (-[WebVideoFullscreenHUDWindowController fastForward:]):
1169         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
1170         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
1171         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
1172         * WebView/WebView.mm:
1173         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1174         (-[WebView _exitVideoFullscreen]):
1175
1176 2019-01-18  Tim Horton  <timothy_horton@apple.com>
1177
1178         Get rid of ADVANCED_SPELL_CHECKING
1179         https://bugs.webkit.org/show_bug.cgi?id=193592
1180
1181         Reviewed by Wenson Hsieh.
1182
1183         * WebCoreSupport/WebEditorClient.mm:
1184         (insertionPointFromCurrentSelection):
1185         (WebEditorClient::checkTextOfParagraph):
1186         (WebEditorClient::getGuessesForWord):
1187         (WebEditorClient::requestCandidatesForSelection):
1188         (WebEditorClient::requestCheckingOfString):
1189         * WebView/WebHTMLView.mm:
1190         (-[WebHTMLView insertText:]):
1191
1192 2019-01-18  Jer Noble  <jer.noble@apple.com>
1193
1194         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1195         https://bugs.webkit.org/show_bug.cgi?id=189553
1196
1197         Reviewed by Tim Horton.
1198
1199         * Configurations/Base.xcconfig:
1200         * Configurations/SDKVariant.xcconfig: Added.
1201         * Configurations/WebKitLegacy.xcconfig:
1202
1203 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1204
1205         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1206         <https://webkit.org/b/193568>
1207         <rdar://problem/47381130>
1208
1209         Reviewed by Alex Christensen.
1210
1211         * WebView/WebView.mm:
1212         - Remove unused soft-linking macros.
1213         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1214         (-[WebUITextIndicatorData initWithImage:scale:]):
1215         - Update to use exported PAL functions.
1216
1217 2019-01-17  Truitt Savell  <tsavell@apple.com>
1218
1219         Unreviewed, rolling out r240124.
1220
1221         This commit broke an internal build.
1222
1223         Reverted changeset:
1224
1225         "SDK_VARIANT build destinations should be separate from non-
1226         SDK_VARIANT builds"
1227         https://bugs.webkit.org/show_bug.cgi?id=189553
1228         https://trac.webkit.org/changeset/240124
1229
1230 2019-01-17  Jer Noble  <jer.noble@apple.com>
1231
1232         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1233         https://bugs.webkit.org/show_bug.cgi?id=189553
1234
1235         Reviewed by Tim Horton.
1236
1237         * Configurations/Base.xcconfig:
1238         * Configurations/SDKVariant.xcconfig: Added.
1239         * Configurations/WebKitLegacy.xcconfig:
1240
1241 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1242
1243         Stop using NetworkStorageSession::storageSession in WebCore
1244         https://bugs.webkit.org/show_bug.cgi?id=193529
1245
1246         Reviewed by Tim Horton.
1247
1248         * Misc/WebCache.mm:
1249         (+[WebCache addImageToCache:forURL:forFrame:]):
1250         * WebView/WebView.mm:
1251         (-[WebView _commonInitializationWithFrameName:groupName:]):
1252         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1253
1254 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1255
1256         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1257         https://bugs.webkit.org/show_bug.cgi?id=193368
1258
1259         Reviewed by Geoff Garen.
1260
1261         * Misc/WebCache.mm:
1262         (+[WebCache clearCachedCredentials]):
1263         * Misc/WebDownload.mm:
1264         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1265         * Plugins/WebBaseNetscapePluginView.mm:
1266         (WebKit::getAuthenticationInfo):
1267
1268 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1269
1270         Stop using CookiesStrategy
1271         https://bugs.webkit.org/show_bug.cgi?id=161106
1272
1273         Reviewed by Don Olmstead and Antti Koivisto.
1274
1275         * Misc/WebCache.mm:
1276         (+[WebCache addImageToCache:forURL:forFrame:]):
1277         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1278         (WebKit::NetscapePluginInstanceProxy::getCookies):
1279         (WebKit::NetscapePluginInstanceProxy::setCookies):
1280         * Plugins/WebNetscapePluginView.mm:
1281         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1282         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1283         * WebCoreSupport/WebPlatformStrategies.h:
1284         * WebCoreSupport/WebPlatformStrategies.mm:
1285         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1286         (WebPlatformStrategies::cookiesForDOM): Deleted.
1287         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1288         (WebPlatformStrategies::cookiesEnabled): Deleted.
1289         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1290         (WebPlatformStrategies::getRawCookies): Deleted.
1291         (WebPlatformStrategies::deleteCookie): Deleted.
1292         * WebView/WebView.mm:
1293         (-[WebView _commonInitializationWithFrameName:groupName:]):
1294         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1295
1296 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1297
1298         Cannot tab out of WKWebView on macOS
1299         https://bugs.webkit.org/show_bug.cgi?id=161448
1300         <rdar://problem/28100085>
1301
1302         Reviewed by Dean Jackson.
1303
1304         * WebCoreSupport/WebChromeClient.mm:
1305         * WebView/WebView.mm:
1306         Make use of SPI headers.
1307
1308 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1309
1310         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1311         r239913, and r239914.
1312         https://bugs.webkit.org/show_bug.cgi?id=193407
1313
1314         These revisions caused an internal failure (Requested by
1315         Truitt on #webkit).
1316
1317         Reverted changesets:
1318
1319         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1320         https://bugs.webkit.org/show_bug.cgi?id=186016
1321         https://trac.webkit.org/changeset/239901
1322
1323         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1324         https://trac.webkit.org/changeset/239909
1325
1326         "Tried to fix the build."
1327         https://trac.webkit.org/changeset/239910
1328
1329         "Fixed iOS builds after r239910."
1330         https://trac.webkit.org/changeset/239912
1331
1332         "More build fixing."
1333         https://trac.webkit.org/changeset/239913
1334
1335         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1336         https://trac.webkit.org/changeset/239914
1337
1338 2019-01-14  Mark Lam  <mark.lam@apple.com>
1339
1340         Re-enable ability to build --cloop builds.
1341         https://bugs.webkit.org/show_bug.cgi?id=192955
1342         <rdar://problem/46882363>
1343
1344         Reviewed by Saam barati and Keith Miller.
1345
1346         * Configurations/FeatureDefines.xcconfig:
1347
1348 2019-01-13  Dan Bernstein  <mitz@apple.com>
1349
1350         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1351
1352         Patch by Keith Rollin.
1353
1354         * WebView/PDFViewSPI.h:
1355
1356 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1357
1358         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1359         https://bugs.webkit.org/show_bug.cgi?id=191655
1360         rdar://problem/46074680
1361
1362         Reviewed by Megan Gardner.
1363
1364         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1365         * WebView/WebView.mm:
1366         (-[WebView _effectiveAppearanceIsDark]):
1367
1368 2019-01-12  Dan Bernstein  <mitz@apple.com>
1369
1370         [Cocoa] Avoid importing directly from subumbrella frameworks
1371         https://bugs.webkit.org/show_bug.cgi?id=186016
1372         <rdar://problem/40591038>
1373
1374         Reviewed by Sam Weinig.
1375
1376         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1377         * Carbon/CarbonWindowAdapter.mm: Ditto.
1378         * Carbon/CarbonWindowFrame.m: Ditto.
1379         * Carbon/HIViewAdapter.h: Ditto.
1380         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1381           OTHER_CFLAGS_COCOA_TOUCH_NO.
1382         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1383         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1384         * WebView/WebPDFView.h: Ditto.
1385
1386 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1387
1388         Enable visual viewport API by default
1389         https://bugs.webkit.org/show_bug.cgi?id=193376
1390
1391         Reviewed by Simon Fraser.
1392
1393         * WebView/WebPreferences.mm:
1394         (+[WebPreferences initialize]):
1395
1396 2019-01-11  John Wilander  <wilander@apple.com>
1397
1398         Compile out Web API Statistics Collection
1399         https://bugs.webkit.org/show_bug.cgi?id=193370
1400         <rdar://problem/45388584>
1401
1402         Reviewed by Brent Fulgham.
1403
1404         * Configurations/FeatureDefines.xcconfig:
1405             Defined ENABLE_WEB_API_STATISTICS, off by default.
1406
1407 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1408
1409         Stop using NetworkStorageSession in WebProcess
1410         https://bugs.webkit.org/show_bug.cgi?id=193236
1411
1412         Reviewed by Don Olmstead.
1413
1414         * WebCoreSupport/WebFrameNetworkingContext.h:
1415         * WebCoreSupport/WebFrameNetworkingContext.mm:
1416         (WebFrameNetworkingContext::storageSession const):
1417         * WebCoreSupport/WebPlatformStrategies.h:
1418         * WebCoreSupport/WebPlatformStrategies.mm:
1419         (WebPlatformStrategies::cookiesForDOM):
1420         (WebPlatformStrategies::setCookiesFromDOM):
1421         (WebPlatformStrategies::cookiesEnabled):
1422         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1423         (WebPlatformStrategies::getRawCookies):
1424         (WebPlatformStrategies::deleteCookie):
1425         * WebView/WebView.mm:
1426         (-[WebView _cachedResponseForURL:]):
1427         (-[WebView _clearCredentials]):
1428
1429 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1430
1431         Unreviewed, rolling out r239727.
1432
1433         Broke API tests
1434
1435         Reverted changeset:
1436
1437         "Stop using NetworkStorageSession in WebProcess"
1438         https://bugs.webkit.org/show_bug.cgi?id=193236
1439         https://trac.webkit.org/changeset/239727
1440
1441 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1442
1443         Stop using NetworkStorageSession in WebProcess
1444         https://bugs.webkit.org/show_bug.cgi?id=193236
1445
1446         Reviewed by Don Olmstead.
1447
1448         * WebCoreSupport/WebFrameNetworkingContext.h:
1449         * WebCoreSupport/WebFrameNetworkingContext.mm:
1450         (WebFrameNetworkingContext::storageSession const):
1451         * WebView/WebView.mm:
1452         (-[WebView _cachedResponseForURL:]):
1453         (-[WebView _clearCredentials]):
1454
1455 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1456
1457         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1458         <https://webkit.org/b/193056>
1459
1460         Reviewed by Alex Christensen.
1461
1462         * Plugins/Hosted/NetscapePluginHostProxy.h:
1463         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1464         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1465         (WebKit::NetscapePluginInstanceProxy::enumerate):
1466         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1467         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1468         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1469         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1470         * Plugins/Hosted/ProxyInstance.mm:
1471         (WebKit::ProxyInstance::invoke):
1472         * WebCoreSupport/WebGeolocationClient.mm:
1473         * WebView/WebDataSource.mm:
1474         (-[WebDataSource _receivedData:]):
1475         * WebView/WebView.mm:
1476         (-[WebView _cachedResponseForURL:]):
1477         - Remove '*' from RetainPtr<> type.
1478
1479 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1480
1481         Progress towards fixing Mac CMake build
1482         https://bugs.webkit.org/show_bug.cgi?id=193105
1483
1484         Reviewed by Don Olmstead.
1485
1486         * WebKitPrefix.h:
1487
1488 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1489
1490         Web Inspector: Use save sheet instead of dialog where possible
1491         https://bugs.webkit.org/show_bug.cgi?id=193160
1492         <rdar://problem/37399759>
1493
1494         Reviewed by Devin Rousso.
1495
1496         * WebCoreSupport/WebInspectorClient.mm:
1497         (WebInspectorFrontendClient::save):
1498
1499 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1500
1501         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1502         https://bugs.webkit.org/show_bug.cgi?id=193129
1503
1504         Reviewed by Tim Horton.
1505
1506         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1507
1508         * WebCoreSupport/WebEditorClient.mm:
1509         (WebEditorClient::registerUndoOrRedoStep):
1510         (undoNameForEditAction): Deleted.
1511
1512 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1513
1514         Add support for using the current text selection as the find string on iOS
1515         https://bugs.webkit.org/show_bug.cgi?id=193034
1516         <rdar://problem/45138739>
1517
1518         Reviewed by Tim Horton.
1519
1520         Add a method stub for WebKitLegacy.
1521
1522         * WebCoreSupport/WebEditorClient.h:
1523
1524 2019-01-01  Jeff Miller  <jeffm@apple.com>
1525
1526         Update user-visible copyright strings to include 2019
1527         https://bugs.webkit.org/show_bug.cgi?id=192811
1528
1529         Reviewed by Mark Lam.
1530
1531         * Info.plist:
1532
1533 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1534
1535         Use Ref<> as much as possible
1536         https://bugs.webkit.org/show_bug.cgi?id=192808
1537
1538         Reviewed by Alex Christensen.
1539
1540         * DOM/DOM.mm:
1541         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1542         * Plugins/Hosted/NetscapePluginHostManager.mm:
1543         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1544         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1545         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1546         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1547         * Plugins/WebNetscapePluginView.mm:
1548         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1549         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1550         * WebCoreSupport/WebContextMenuClient.mm:
1551         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1552         * WebCoreSupport/WebFrameLoaderClient.mm:
1553         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1554         * WebView/WebFrame.mm:
1555         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1556         * WebView/WebHTMLView.mm:
1557         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1558         * WebView/WebView.mm:
1559         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1560         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1561
1562 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1563
1564         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1565         https://bugs.webkit.org/show_bug.cgi?id=192821
1566
1567         Reviewed by Chris Dumez.
1568
1569         When a window becomes occluded, the window server informs the application.
1570         This should be used to suspend any work that is not visible by the user.
1571
1572         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1573         In some cases, that lead to performance impact (see radar).
1574
1575         This patch adds an observer for the occlusion notification. I tried to stick
1576         with the same names used by WebKit2.
1577
1578         * WebView/WebView.mm:
1579         (-[WebView _isViewVisible]):
1580         (-[WebView addWindowObserversForWindow:]):
1581         (-[WebView removeWindowObservers]):
1582         (-[WebView _windowDidChangeOcclusionState:]):
1583
1584 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1585
1586         [WebAuthN] Add a runtime flag for local authenticator
1587         https://bugs.webkit.org/show_bug.cgi?id=192792
1588         <rdar://problem/46798738>
1589
1590         Reviewed by Brent Fulgham.
1591
1592         * WebView/WebPreferenceKeysPrivate.h:
1593         * WebView/WebPreferences.mm:
1594         (+[WebPreferences initialize]):
1595         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1596         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1597         * WebView/WebPreferencesPrivate.h:
1598         * WebView/WebView.mm:
1599         (-[WebView _preferencesChanged:]):
1600
1601 2018-12-20  Chris Dumez  <cdumez@apple.com>
1602
1603         Use Optional::valueOr() instead of Optional::value_or()
1604         https://bugs.webkit.org/show_bug.cgi?id=192933
1605
1606         Reviewed by Geoffrey Garen.
1607
1608         * WebCoreSupport/WebSecurityOrigin.mm:
1609         (-[WebSecurityOrigin port]):
1610
1611 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1612
1613         Unreviewed, rolling out r239417.
1614
1615         Introduced two API test failures on macOS.
1616
1617         Reverted changeset:
1618
1619         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1620         occlusion changes"
1621         https://bugs.webkit.org/show_bug.cgi?id=192821
1622         https://trac.webkit.org/changeset/239417
1623
1624 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1625
1626         WKWebView default UA doesn't freeze the build number
1627         https://bugs.webkit.org/show_bug.cgi?id=192809
1628         <rdar://problem/44687185>
1629
1630         Reviewed by Andy Estes.
1631
1632         Always reports the frozen build number.
1633
1634         * WebView/WebView.mm:
1635         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1636         actual build number through this method call.
1637         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1638
1639 2018-12-19  Chris Dumez  <cdumez@apple.com>
1640
1641         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1642         https://bugs.webkit.org/show_bug.cgi?id=192728
1643         <rdar://problem/46746779>
1644
1645         Reviewed by Geoff Garen.
1646
1647         * DOM/*:
1648         * Plugins/*:
1649         * WebCoreSupport/*:
1650         * WebView/*:
1651
1652 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1653
1654         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1655         https://bugs.webkit.org/show_bug.cgi?id=192821
1656
1657         Reviewed by Chris Dumez.
1658
1659         When a window becomes occluded, the window server informs the application.
1660         This should be used to suspend any work that is not visible by the user.
1661
1662         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1663         In some cases, that lead to performance impact (see radar).
1664
1665         This patch adds an observer for the occlusion notification. I tried to stick
1666         with the same names used by WebKit2.
1667
1668         * WebView/WebView.mm:
1669         (-[WebView _isViewVisible]):
1670         (-[WebView addWindowObserversForWindow:]):
1671         (-[WebView removeWindowObservers]):
1672         (-[WebView _windowDidChangeOcclusionState:]):
1673
1674 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1675
1676         Allow clients to set the navigator platform
1677         https://bugs.webkit.org/show_bug.cgi?id=192735
1678
1679         Reviewed by Tim Horton.
1680
1681         Add stubs to fill out the added functionality in FrameLoaderClient.
1682
1683         * WebCoreSupport/WebFrameLoaderClient.h:
1684         * WebCoreSupport/WebFrameLoaderClient.mm:
1685         (WebFrameLoaderClient::navigatorPlatform):
1686
1687 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1688
1689         offsetLeft and offsetParent should adjust across shadow boundaries
1690         https://bugs.webkit.org/show_bug.cgi?id=157437
1691         <rdar://problem/26154021>
1692
1693         Reviewed by Simon Fraser.
1694
1695         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1696
1697         * DOM/DOMElement.mm:
1698         (-[DOMElement offsetLeft]):
1699         (-[DOMElement offsetTop]):
1700         (-[DOMElement offsetParent]):
1701
1702 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1703
1704         Unreviewed build fix.
1705
1706         * WebView/WebFrame.mm:
1707         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1708
1709 2018-12-15  Darin Adler  <darin@apple.com>
1710
1711         Use warning-ignoring macros more consistently and simply
1712         https://bugs.webkit.org/show_bug.cgi?id=192743
1713
1714         Reviewed by Mark Lam.
1715
1716         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1717         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1718         compilers in Objective-C++ code.
1719
1720         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1721         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1722         accomodate non-clang compilers here. Also use #pragma once, add a missing
1723         "explicit" and fix conditionals.
1724
1725 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1726
1727         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1728         https://bugs.webkit.org/show_bug.cgi?id=192653
1729
1730         Reviewed by Wenson Hsieh.
1731
1732         * WebView/WebHTMLView.mm:
1733         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1734
1735 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1736
1737         Implement feature flag for CSS Typed OM
1738         https://bugs.webkit.org/show_bug.cgi?id=192610
1739
1740         Reviewed by Ryosuke Niwa.
1741
1742         * Configurations/FeatureDefines.xcconfig:
1743
1744 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1745
1746         WebCore shouldn't have a Objective-C class named NSCursor
1747         https://bugs.webkit.org/show_bug.cgi?id=192602
1748         <rdar://problem/46615532>
1749
1750         Reviewed by Wenson Hsieh.
1751
1752         * WebView/WebFrameView.mm:
1753         (-[WebFrameView keyDown:keyDown:]):
1754         * WebView/WebHTMLView.mm:
1755         (-[WebHTMLView keyDown:]):
1756         (-[WebHTMLView performKeyEquivalent:]):
1757         Only use NSCursor on macOS.
1758
1759 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1760
1761         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1762         https://bugs.webkit.org/show_bug.cgi?id=192573
1763
1764         Reviewed by Simon Fraser.
1765
1766         * Configurations/FeatureDefines.xcconfig:
1767
1768 2018-12-10  Antti Koivisto  <antti@apple.com>
1769
1770         Rename "forced style recalc" to "full style rebuild"
1771         https://bugs.webkit.org/show_bug.cgi?id=192572
1772
1773         Reviewed by Zalan Bujtas.
1774
1775         * WebView/WebHTMLView.mm:
1776         (-[WebHTMLView setNeedsToApplyStyles:]):
1777
1778 2018-12-10  Darin Adler  <darin@apple.com>
1779
1780         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1781         https://bugs.webkit.org/show_bug.cgi?id=192533
1782         rdar://problem/45732710
1783
1784         Reviewed by Anders Carlsson.
1785
1786         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1787         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1788
1789 2018-12-10  Darin Adler  <darin@apple.com>
1790
1791         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1792         https://bugs.webkit.org/show_bug.cgi?id=192532
1793         rdar://problem/45731047
1794
1795         Reviewed by Chris Dumez.
1796
1797         * Plugins/Hosted/NetscapePluginHostManager.mm:
1798         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1799         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1800         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1801
1802 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1803
1804         Turn WritingDirection into an enum class
1805         https://bugs.webkit.org/show_bug.cgi?id=192401
1806         Work towards <rdar://problem/42075638>
1807
1808         Reviewed by Dan Bernstein.
1809
1810         Change WritingDirection from an enum to an enum class. No change in behavior.
1811
1812         * WebView/WebHTMLView.mm:
1813         (-[WebHTMLView toggleBaseWritingDirection:]):
1814         (-[WebHTMLView changeBaseWritingDirection:]):
1815         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1816
1817 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1818
1819         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1820         https://bugs.webkit.org/show_bug.cgi?id=192272
1821
1822         Reviewed by Brady Eidson.
1823
1824         * WebCoreSupport/WebFrameLoaderClient.h:
1825         * WebCoreSupport/WebFrameLoaderClient.mm:
1826         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1827
1828 2018-12-03  Jer Noble  <jer.noble@apple.com>
1829
1830         Get rid of old, dead Mac video fullscreen code.
1831         https://bugs.webkit.org/show_bug.cgi?id=192315
1832
1833         Reviewed by Eric Carlson.
1834
1835         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1836         is no longer supported in the Mac port.
1837
1838         * WebView/WebVideoFullscreenController.h: Removed.
1839         * WebView/WebVideoFullscreenController.mm: Removed.
1840         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1841         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1842         * WebView/WebView.mm:
1843         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1844         (-[WebView _exitVideoFullscreen]):
1845
1846 2018-12-03  Daniel Bates  <dabates@apple.com>
1847
1848         [iOS] Do not handle key events that are key commands
1849         https://bugs.webkit.org/show_bug.cgi?id=191608
1850         <rdar://problem/46046013>
1851
1852         Reviewed by Ryosuke Niwa.
1853
1854         A key down event may be associated with a key command. If it is then we want to execute the
1855         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1856         event as a key command to find out.
1857
1858         * WebView/WebHTMLView.mm:
1859         (-[WebHTMLView _handleEditingKeyEvent:]):
1860
1861 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1862
1863         Add a runtime feature flag for LayoutFormattingContext.
1864         https://bugs.webkit.org/show_bug.cgi?id=192280
1865
1866         Reviewed by Simon Fraser.
1867
1868         * Configurations/FeatureDefines.xcconfig:
1869
1870 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1871
1872         Move URL from WebCore to WTF
1873         https://bugs.webkit.org/show_bug.cgi?id=190234
1874
1875         Reviewed by Keith Miller.
1876
1877         * DOM/DOMAttr.mm:
1878         * DOM/DOMBlob.mm:
1879         * DOM/DOMCSSCharsetRule.mm:
1880         * DOM/DOMCSSImportRule.mm:
1881         * DOM/DOMCSSMediaRule.mm:
1882         * DOM/DOMCSSPageRule.mm:
1883         * DOM/DOMCSSPrimitiveValue.mm:
1884         * DOM/DOMCSSRule.mm:
1885         * DOM/DOMCSSStyleDeclaration.mm:
1886         * DOM/DOMCSSStyleRule.mm:
1887         * DOM/DOMCSSStyleSheet.mm:
1888         * DOM/DOMCSSValue.mm:
1889         * DOM/DOMCharacterData.mm:
1890         * DOM/DOMCounter.mm:
1891         * DOM/DOMDocument.mm:
1892         * DOM/DOMDocumentFragment.mm:
1893         * DOM/DOMDocumentType.mm:
1894         * DOM/DOMEvent.mm:
1895         * DOM/DOMFile.mm:
1896         * DOM/DOMHTMLAnchorElement.mm:
1897         * DOM/DOMHTMLAppletElement.mm:
1898         * DOM/DOMHTMLAreaElement.mm:
1899         * DOM/DOMHTMLBRElement.mm:
1900         * DOM/DOMHTMLBaseElement.mm:
1901         * DOM/DOMHTMLBaseFontElement.mm:
1902         * DOM/DOMHTMLBodyElement.mm:
1903         * DOM/DOMHTMLButtonElement.mm:
1904         * DOM/DOMHTMLCanvasElement.mm:
1905         * DOM/DOMHTMLCollection.mm:
1906         * DOM/DOMHTMLDivElement.mm:
1907         * DOM/DOMHTMLDocument.mm:
1908         * DOM/DOMHTMLElement.mm:
1909         * DOM/DOMHTMLEmbedElement.mm:
1910         * DOM/DOMHTMLFieldSetElement.mm:
1911         * DOM/DOMHTMLFontElement.mm:
1912         * DOM/DOMHTMLFormElement.mm:
1913         * DOM/DOMHTMLFrameElement.mm:
1914         * DOM/DOMHTMLFrameSetElement.mm:
1915         * DOM/DOMHTMLHRElement.mm:
1916         * DOM/DOMHTMLHeadElement.mm:
1917         * DOM/DOMHTMLHeadingElement.mm:
1918         * DOM/DOMHTMLHtmlElement.mm:
1919         * DOM/DOMHTMLIFrameElement.mm:
1920         * DOM/DOMHTMLImageElement.mm:
1921         * DOM/DOMHTMLInputElement.mm:
1922         * DOM/DOMHTMLLIElement.mm:
1923         * DOM/DOMHTMLLabelElement.mm:
1924         * DOM/DOMHTMLLegendElement.mm:
1925         * DOM/DOMHTMLLinkElement.mm:
1926         * DOM/DOMHTMLMapElement.mm:
1927         * DOM/DOMHTMLMarqueeElement.mm:
1928         * DOM/DOMHTMLMediaElement.mm:
1929         * DOM/DOMHTMLMetaElement.mm:
1930         * DOM/DOMHTMLModElement.mm:
1931         * DOM/DOMHTMLOListElement.mm:
1932         * DOM/DOMHTMLObjectElement.mm:
1933         * DOM/DOMHTMLOptGroupElement.mm:
1934         * DOM/DOMHTMLOptionElement.mm:
1935         * DOM/DOMHTMLOptionsCollection.mm:
1936         * DOM/DOMHTMLParagraphElement.mm:
1937         * DOM/DOMHTMLParamElement.mm:
1938         * DOM/DOMHTMLQuoteElement.mm:
1939         * DOM/DOMHTMLScriptElement.mm:
1940         * DOM/DOMHTMLSelectElement.mm:
1941         * DOM/DOMHTMLStyleElement.mm:
1942         * DOM/DOMHTMLTableCaptionElement.mm:
1943         * DOM/DOMHTMLTableCellElement.mm:
1944         * DOM/DOMHTMLTableColElement.mm:
1945         * DOM/DOMHTMLTableElement.mm:
1946         * DOM/DOMHTMLTableRowElement.mm:
1947         * DOM/DOMHTMLTableSectionElement.mm:
1948         * DOM/DOMHTMLTitleElement.mm:
1949         * DOM/DOMHTMLUListElement.mm:
1950         * DOM/DOMHTMLVideoElement.mm:
1951         * DOM/DOMKeyboardEvent.mm:
1952         * DOM/DOMMediaList.mm:
1953         * DOM/DOMMouseEvent.mm:
1954         * DOM/DOMMutationEvent.mm:
1955         * DOM/DOMNamedNodeMap.mm:
1956         * DOM/DOMProcessingInstruction.mm:
1957         * DOM/DOMRange.mm:
1958         * DOM/DOMStyleSheet.mm:
1959         * DOM/DOMText.mm:
1960         * DOM/DOMTextEvent.mm:
1961         * DOM/DOMTokenList.mm:
1962         * DOM/DOMUIEvent.mm:
1963         * DOM/DOMXPathResult.mm:
1964         * History/WebHistoryItem.mm:
1965         * Misc/WebNSURLExtras.mm:
1966         (-[NSURL _web_userVisibleString]):
1967         (-[NSURL _web_URLByRemovingUserInfo]):
1968         (-[NSURL _web_dataForURLComponentType:]):
1969         (-[NSURL _web_schemeData]):
1970         (-[NSURL _web_hostData]):
1971         * Misc/WebUserContentURLPattern.mm:
1972         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1973         * Plugins/WebNetscapePluginStream.h:
1974         (WebNetscapePluginStream::setRequestURL):
1975         * WebCoreSupport/WebChromeClient.h:
1976         * WebCoreSupport/WebChromeClient.mm:
1977         (WebChromeClient::signedPublicKeyAndChallengeString const):
1978         * WebCoreSupport/WebContextMenuClient.h:
1979         * WebCoreSupport/WebContextMenuClient.mm:
1980         * WebCoreSupport/WebDragClient.h:
1981         * WebCoreSupport/WebFrameLoaderClient.h:
1982         * WebCoreSupport/WebFrameLoaderClient.mm:
1983         (WebFrameLoaderClient::updateGlobalHistory):
1984         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1985         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1986         (WebPaymentCoordinatorClient::showPaymentUI):
1987         * WebCoreSupport/WebPlatformStrategies.h:
1988         * WebCoreSupport/WebPlatformStrategies.mm:
1989         (WebPlatformStrategies::readURLFromPasteboard):
1990         * WebCoreSupport/WebPluginInfoProvider.h:
1991         * WebCoreSupport/WebPluginInfoProvider.mm:
1992         (WebPluginInfoProvider::webVisiblePluginInfo):
1993         * WebCoreSupport/WebSecurityOrigin.mm:
1994         * WebCoreSupport/WebVisitedLinkStore.h:
1995         * WebView/WebDataSource.mm:
1996         * WebView/WebFrame.mm:
1997         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1998         * WebView/WebImmediateActionController.mm:
1999         (-[WebImmediateActionController _defaultAnimationController]):
2000         * WebView/WebPDFView.mm:
2001         * WebView/WebScriptDebugger.mm:
2002         * WebView/WebViewInternal.h:
2003
2004 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
2005
2006         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
2007         https://bugs.webkit.org/show_bug.cgi?id=192197
2008
2009         Reviewed by Jiewen Tan.
2010
2011         * Configurations/FeatureDefines.xcconfig:
2012         * WebCoreSupport/WebChromeClient.h:
2013         * WebCoreSupport/WebChromeClient.mm:
2014
2015 2018-11-28  Alex Christensen  <achristensen@webkit.org>
2016
2017         Remove dead code from an earlier attempt at implementing safe browsing
2018         https://bugs.webkit.org/show_bug.cgi?id=192067
2019
2020         Reviewed by Chris Dumez.
2021
2022         * WebCoreSupport/WebFrameLoaderClient.h:
2023         * WebCoreSupport/WebFrameLoaderClient.mm:
2024         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2025
2026 2018-11-27  Mark Lam  <mark.lam@apple.com>
2027
2028         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
2029         https://bugs.webkit.org/show_bug.cgi?id=192055
2030         <rdar://problem/46288783>
2031
2032         Reviewed by Saam Barati.
2033
2034         * Configurations/FeatureDefines.xcconfig:
2035
2036 2018-11-25  Tim Horton  <timothy_horton@apple.com>
2037
2038         Make it possible to insert editable images with a gesture
2039         https://bugs.webkit.org/show_bug.cgi?id=191937
2040
2041         Reviewed by Wenson Hsieh.
2042
2043         * WebCoreSupport/WebEditorClient.mm:
2044         (undoNameForEditAction):
2045         Add a undo name.
2046
2047 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2048
2049         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
2050         https://bugs.webkit.org/show_bug.cgi?id=191945
2051
2052         Reviewed by Anders Carlsson.
2053
2054         * WebCoreSupport/WebEditorClient.mm:
2055         (undoNameForEditAction):
2056
2057 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2058
2059         Enable drag and drop support for iOSMac
2060         https://bugs.webkit.org/show_bug.cgi?id=191818
2061         <rdar://problem/43907454>
2062
2063         Reviewed by Dean Jackson.
2064
2065         * Configurations/FeatureDefines.xcconfig:
2066
2067 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2068
2069         Address post-review feedback after r238438
2070         https://bugs.webkit.org/show_bug.cgi?id=191913
2071
2072         Reviewed by Ryosuke Niwa.
2073
2074         * WebView/WebFrame.mm:
2075         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
2076         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2077         * WebView/WebView.mm:
2078         (-[WebView setSelectedDOMRange:affinity:]):
2079
2080 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
2081
2082         Web Inspector: "Reload Web Inspector" button no longer partially works
2083         https://bugs.webkit.org/show_bug.cgi?id=191773
2084         <rdar://problem/46139932>
2085
2086         Reviewed by Devin Rousso.
2087
2088         * WebCoreSupport/WebInspectorClient.h:
2089         * WebCoreSupport/WebInspectorClient.mm:
2090         (WebInspectorFrontendClient::reopen):
2091
2092 2018-11-17  Devin Rousso  <drousso@apple.com>
2093
2094         Web Inspector: Network: add button to show system certificate dialog
2095         https://bugs.webkit.org/show_bug.cgi?id=191458
2096         <rdar://problem/45977019>
2097
2098         Reviewed by Joseph Pecoraro.
2099
2100         * WebCoreSupport/WebInspectorClient.h:
2101         * WebCoreSupport/WebInspectorClient.mm:
2102         (WebInspectorFrontendClient::showCertificate): Added.
2103
2104         * Configurations/WebKitLegacy.xcconfig:
2105
2106 2018-11-15  Truitt Savell  <tsavell@apple.com>
2107
2108         Unreviewed, rolling out r238244.
2109
2110         Caused High Sierra test runs to fail early with 50 crashes and
2111         casued 25 API failures.
2112
2113         Reverted changeset:
2114
2115         "[css-logical] Implement flow-relative margin, padding and
2116         border shorthands"
2117         https://bugs.webkit.org/show_bug.cgi?id=188697
2118         https://trac.webkit.org/changeset/238244
2119
2120 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
2121
2122         [css-logical] Implement flow-relative margin, padding and border shorthands
2123         https://bugs.webkit.org/show_bug.cgi?id=188697
2124
2125         Reviewed by Simon Fraser and Antti Koivisto.
2126
2127         Add CSSLogicalEnabled runtime flag.
2128
2129         * WebView/WebPreferenceKeysPrivate.h:
2130         * WebView/WebPreferences.mm:
2131         (+[WebPreferences initialize]):
2132         (-[WebPreferences cssLogicalEnabled]):
2133         (-[WebPreferences setCSSLogicalEnabled:]):
2134         * WebView/WebPreferencesPrivate.h:
2135         * WebView/WebView.mm:
2136         (-[WebView _preferencesChanged:]):
2137
2138 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2139
2140         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
2141         https://bugs.webkit.org/show_bug.cgi?id=191612
2142
2143         Reviewed by Matt Baker.
2144
2145         * WebCoreSupport/WebInspectorClient.mm:
2146         (-[WebInspectorWindowController destroyInspectorView]):
2147
2148 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2149
2150         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
2151         https://bugs.webkit.org/show_bug.cgi?id=191494
2152         <rdar://problem/45469854>
2153
2154         Reviewed by Devin Rousso.
2155
2156         * WebCoreSupport/WebInspectorClient.h:
2157         WebKitLegacy will still have remote inspection of the Page directly.
2158
2159 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
2160
2161         Make compositing updates incremental
2162         https://bugs.webkit.org/show_bug.cgi?id=90342
2163
2164         Reviewed by Antti Koivisto.
2165
2166         Fix spelling error.
2167
2168         * WebView/WebView.mm:
2169         (-[WebView _setMediaLayer:forPluginView:]):
2170
2171 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2172
2173         Implement a new edit command to change the enclosing list type
2174         https://bugs.webkit.org/show_bug.cgi?id=191487
2175         <rdar://problem/45955922>
2176
2177         Reviewed by Ryosuke Niwa.
2178
2179         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
2180
2181         * WebCoreSupport/WebEditorClient.mm:
2182         (undoNameForEditAction):
2183
2184 2018-11-11  Daniel Bates  <dabates@apple.com>
2185
2186         [iOS] Draw caps lock indicator in password fields
2187         https://bugs.webkit.org/show_bug.cgi?id=190565
2188         <rdar://problem/45262343>
2189
2190         Reviewed by Dean Jackson.
2191
2192         Update the caps lock state when a hardware keyboard is attached or detached.
2193
2194         * WebView/WebHTMLView.mm:
2195         (hardwareKeyboardAvailabilityChangedCallback): Added.
2196         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2197         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2198
2199 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
2200
2201         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2202         https://bugs.webkit.org/show_bug.cgi?id=191492
2203
2204         Reviewed by Alex Christensen.
2205
2206         * Carbon/HIWebView.mm:
2207         * Misc/WebNSFileManagerExtras.mm:
2208         * Misc/WebNSURLExtras.mm:
2209         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2210         * Plugins/WebBasePluginPackage.mm:
2211         * Plugins/WebPluginContainerCheck.mm:
2212         * WebCoreSupport/WebCachedFramePlatformData.h:
2213         * WebCoreSupport/WebDeviceOrientationClient.mm:
2214         * WebView/WebDelegateImplementationCaching.mm:
2215         * WebView/WebHTMLView.mm:
2216         * WebView/WebPDFRepresentation.mm:
2217         * WebView/WebPolicyDelegate.mm:
2218         * WebView/WebView.mm:
2219
2220 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
2221
2222         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2223         https://bugs.webkit.org/show_bug.cgi?id=191492
2224
2225         Reviewed by Alex Christensen.
2226
2227         * Carbon/HIWebView.mm:
2228         (UpdateCommandStatus):
2229         * Misc/WebNSFileManagerExtras.mm:
2230         * Misc/WebNSURLExtras.mm:
2231         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2232         * Plugins/WebBasePluginPackage.mm:
2233         * Plugins/WebPluginContainerCheck.mm:
2234         (-[WebPluginContainerCheck _continueWithPolicy:]):
2235         * WebCoreSupport/WebCachedFramePlatformData.h:
2236         (WebCachedFramePlatformData::clear):
2237         * WebCoreSupport/WebDeviceOrientationClient.mm:
2238         (WebDeviceOrientationClient::getProvider const):
2239         * WebView/WebDelegateImplementationCaching.mm:
2240         (CallDelegate):
2241         (CallDelegateReturningBoolean):
2242         (CallResourceLoadDelegateReturningBoolean):
2243         (CallFormDelegate):
2244         (CallFormDelegateReturningBoolean):
2245         * WebView/WebHTMLView.mm:
2246         * WebView/WebPDFRepresentation.mm:
2247         * WebView/WebPolicyDelegate.mm:
2248         (-[WebPolicyDecisionListener _usePolicy:]):
2249         * WebView/WebView.mm:
2250
2251 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
2252
2253         Unreviewed, rolling out r238047.
2254
2255         Introduced layout test failures on iOS simulator.
2256
2257         Reverted changeset:
2258
2259         "[iOS] Draw caps lock indicator in password fields"
2260         https://bugs.webkit.org/show_bug.cgi?id=190565
2261         https://trac.webkit.org/changeset/238047
2262
2263 2018-11-09  Antti Koivisto  <antti@apple.com>
2264
2265         Use OptionSet for layout milestones
2266         https://bugs.webkit.org/show_bug.cgi?id=191470
2267
2268         Reviewed by Dean Jackson.
2269
2270         * WebCoreSupport/WebFrameLoaderClient.h:
2271         * WebCoreSupport/WebFrameLoaderClient.mm:
2272         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2273         * WebView/WebView.mm:
2274         (coreLayoutMilestones):
2275         (kitLayoutMilestones):
2276         (-[WebView _cacheFrameLoadDelegateImplementations]):
2277         * WebView/WebViewInternal.h:
2278
2279 2018-11-09  Daniel Bates  <dabates@apple.com>
2280
2281         [iOS] Draw caps lock indicator in password fields
2282         https://bugs.webkit.org/show_bug.cgi?id=190565
2283         <rdar://problem/45262343>
2284
2285         Reviewed by Dean Jackson.
2286
2287         Update the caps lock state when a hardware keyboard is attached or detached.
2288
2289         * WebView/WebHTMLView.mm:
2290         (hardwareKeyboardAvailabilityChangedCallback): Added.
2291         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2292         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2293
2294 2018-11-09  Daniel Bates  <dabates@apple.com>
2295
2296         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
2297         action when forward delete is pressed outside a text field
2298         https://bugs.webkit.org/show_bug.cgi?id=190566
2299         <rdar://problem/45262367>
2300
2301         Reviewed by Wenson Hsieh.
2302
2303         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
2304         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
2305         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
2306
2307         * WebView/WebHTMLView.mm:
2308         (-[WebHTMLView _handleEditingKeyEvent:]):
2309
2310 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
2311
2312         Adopt Reveal Framework to replace Lookup
2313         https://bugs.webkit.org/show_bug.cgi?id=191097
2314         <rdar://problem/45924508>
2315
2316         Reviewed by Tim Horton.
2317
2318         Pass in what it needed to clear the textIndicators. This is better than
2319         the current notification structure.
2320
2321         * WebView/WebView.mm:
2322         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2323         (-[WebView _prepareForDictionaryLookup]):
2324
2325 2018-11-06  Justin Fan  <justin_fan@apple.com>
2326
2327         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2328         https://bugs.webkit.org/show_bug.cgi?id=191291
2329
2330         Reviewed by Myles Maxfield.
2331
2332         Properly disable WEBGPU on all non-Metal platforms for now.
2333
2334         * Configurations/FeatureDefines.xcconfig:
2335
2336 2018-11-02  Daniel Bates  <dabates@apple.com>
2337
2338         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2339         https://bugs.webkit.org/show_bug.cgi?id=190487
2340
2341         Reviewed by Tim Horton.
2342
2343         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
2344         allow the default handling.
2345
2346         * WebView/WebHTMLView.mm:
2347         (-[WebHTMLView _handleEditingKeyEvent:]):
2348
2349 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2350
2351         Add a storage limit for IndexedDB
2352         https://bugs.webkit.org/show_bug.cgi?id=190598
2353         <rdar://problem/44654715>
2354
2355         Reviewed by Chris Dumez.
2356
2357         * Storage/WebDatabaseManager.mm:
2358         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2359         * Storage/WebDatabaseManagerPrivate.h:
2360
2361 2018-10-31  Antti Koivisto  <antti@apple.com>
2362
2363         Remove LayerFlushScheduler
2364         https://bugs.webkit.org/show_bug.cgi?id=191103
2365
2366         Reviewed by Anders Carlsson.
2367
2368         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2369         all the virtual cruft.
2370
2371         * WebView/WebViewData.h:
2372         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2373         (): Deleted.
2374         * WebView/WebViewData.mm:
2375         (currentRunLoop):
2376         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2377         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2378         (WebViewLayerFlushScheduler::schedule):
2379         (WebViewLayerFlushScheduler::invalidate):
2380         (WebViewLayerFlushScheduler::layerFlushCallback):
2381
2382 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2383
2384         Enable InstallAPI for iOS unconditionally
2385         https://bugs.webkit.org/show_bug.cgi?id=191043
2386         rdar://problem/32728423
2387
2388         Reviewed by Dan Bernstein.
2389
2390         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2391         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2392         shouldn't be processed by InstallAPI.
2393         * MigrateHeaders.make: Removed an obsolete workaround.
2394         * Misc/NSURLDownloadSPI.h: Added.
2395         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2396
2397 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2398
2399         Clean up some obsolete MAX_ALLOWED macros
2400         https://bugs.webkit.org/show_bug.cgi?id=190916
2401
2402         Reviewed by Tim Horton.
2403
2404         * WebView/WebHTMLView.mm:
2405         (-[WebHTMLView pressureChangeWithEvent:]):
2406         * WebView/WebPDFView.h:
2407
2408 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2409
2410         Unreviewed, rolling out r237600 and r237604.
2411         https://bugs.webkit.org/show_bug.cgi?id=191086
2412
2413         Breaks internal iOS builds (Requested by ryanhadd_ on
2414         #webkit).
2415
2416         Reverted changesets:
2417
2418         "Enable InstallAPI for iOS unconditionally"
2419         https://bugs.webkit.org/show_bug.cgi?id=191043
2420         https://trac.webkit.org/changeset/237600
2421
2422         "Build fix attempt after enabling InstallAPI for iOS."
2423         https://bugs.webkit.org/show_bug.cgi?id=191043
2424         https://trac.webkit.org/changeset/237604
2425
2426 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2427
2428         Enable InstallAPI for iOS unconditionally
2429         https://bugs.webkit.org/show_bug.cgi?id=191043
2430         rdar://problem/32728423
2431
2432         Reviewed by Dan Bernstein.
2433
2434         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2435         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2436         shouldn't be processed by InstallAPI.
2437         * MigrateHeaders.make: Removed an obsolete workaround.
2438         * Misc/NSURLDownloadSPI.h: Added.
2439         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2440
2441 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2442
2443         Modernize WebKit nibs and lprojs for localization's sake
2444         https://bugs.webkit.org/show_bug.cgi?id=190911
2445         <rdar://problem/45349466>
2446
2447         Reviewed by Dan Bernstein.
2448
2449         * Misc/WebNSControlExtras.m:
2450         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2451         NSWindow and its contents are both in the same scale space these days; avoid
2452         double-applying the scale factor, or you can't see the prompt.
2453
2454         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2455         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2456         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2457         NIB->XIB
2458
2459 2018-10-25  Antoine Quint  <graouts@apple.com>
2460
2461         [Web Animations] Turn Web Animations CSS Integration off by default
2462         https://bugs.webkit.org/show_bug.cgi?id=190901
2463
2464         Reviewed by Dean Jackson.
2465
2466         * WebView/WebPreferences.mm:
2467         (+[WebPreferences initialize]):
2468
2469 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2470
2471         Clean up some obsolete macOS version guards
2472         https://bugs.webkit.org/show_bug.cgi?id=190887
2473
2474         Reviewed by Dan Bernstein.
2475
2476         * Misc/WebNSPasteboardExtras.mm:
2477         (+[NSPasteboard _web_dragTypesForURL]):
2478         * WebCoreSupport/PopupMenuMac.mm:
2479         (PopupMenuMac::show):
2480         * WebCoreSupport/WebEditorClient.h:
2481         * WebCoreSupport/WebEditorClient.mm:
2482         (WebEditorClient::respondToChangedSelection):
2483         * WebView/WebPDFView.mm:
2484         (-[WebPDFView _clipViewForPDFDocumentView]):
2485
2486 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2487
2488         Turn on Conic Gradients
2489         https://bugs.webkit.org/show_bug.cgi?id=190810
2490
2491         Reviewed by Tim Horton.
2492
2493         * Configurations/FeatureDefines.xcconfig:
2494
2495 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2496
2497         Cleanup: MIMETypeRegistry functions
2498         https://bugs.webkit.org/show_bug.cgi?id=190838
2499
2500         Reviewed by Simon Fraser.
2501
2502         * Misc/WebNSPasteboardExtras.mm:
2503         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2504         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2505         because they were identical.
2506
2507         * WebView/WebHTMLRepresentation.mm:
2508         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2509         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2510         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2511         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2512         * WebView/WebView.mm:
2513         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2514         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2515         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2516
2517 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2518
2519         Fix false positive leaks when using custom -init methods that don't start with -init
2520         <https://webkit.org/b/190818>
2521         <rdar://problem/45476042>
2522
2523         Reviewed by Dan Bernstein.
2524
2525         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2526         it is accessible by both categories.
2527         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2528         NSError (WebKitInternal) category.  Add attribute to make this
2529         behave like an -init method.
2530         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2531         NSError (WebKitInternal) category.  Modernize method.  Replace
2532         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2533
2534 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2535
2536         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2537         https://bugs.webkit.org/show_bug.cgi?id=190729
2538
2539         Reviewed by Tim Horton.
2540
2541         * DOM/DOM.mm:
2542         (-[DOMNode boundingBox]):
2543         * DOM/DOMElement.mm:
2544         * DOM/DOMHTML.mm:
2545         * DOM/DOMInternal.mm:
2546         * DOM/DOMUIKitExtensions.mm:
2547         * DOM/WebDOMOperations.mm:
2548         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2549         * DefaultDelegates/WebDefaultEditingDelegate.m:
2550         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2551         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2552         * DefaultDelegates/WebDefaultUIDelegate.h:
2553         * DefaultDelegates/WebDefaultUIDelegate.mm:
2554         (-[WebDefaultUIDelegate webViewClose:]):
2555         (-[WebDefaultUIDelegate webViewFocus:]):
2556         (-[WebDefaultUIDelegate webViewUnfocus:]):
2557         (-[WebDefaultUIDelegate webViewIsResizable:]):
2558         (-[WebDefaultUIDelegate webView:setResizable:]):
2559         (-[WebDefaultUIDelegate webView:setFrame:]):
2560         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2561         * History/BackForwardList.h:
2562         * History/BackForwardList.mm:
2563         * History/WebBackForwardList.mm:
2564         (+[WebBackForwardList initialize]):
2565         (bumperCarBackForwardHackNeeded):
2566         * History/WebHistory.mm:
2567         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2568         (-[WebHistory _sendNotification:entries:]):
2569         (-[WebHistory loadFromURL:error:]):
2570         (-[WebHistory saveToURL:error:]):
2571         * History/WebHistoryItem.mm:
2572         (WKNotifyHistoryItemChanged):
2573         (+[WebHistoryItem initialize]):
2574         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2575         * History/WebURLsWithTitles.m:
2576         * Misc/WebCache.mm:
2577         (+[WebCache initialize]):
2578         * Misc/WebDownload.mm:
2579         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2580         * Misc/WebElementDictionary.mm:
2581         (+[WebElementDictionary initialize]):
2582         (+[WebElementDictionary initializeLookupTable]):
2583         * Misc/WebIconDatabase.mm:
2584         * Misc/WebKitNSStringExtras.mm:
2585         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2586         * Misc/WebKitVersionChecks.h:
2587         * Misc/WebKitVersionChecks.mm:
2588         (WebKitLinkedOnOrAfter):
2589         (WebKitLinkTimeVersion):
2590         * Misc/WebLocalizableStrings.mm:
2591         * Misc/WebNSControlExtras.h:
2592         * Misc/WebNSControlExtras.m:
2593         * Misc/WebNSEventExtras.m:
2594         * Misc/WebNSFileManagerExtras.mm:
2595         * Misc/WebNSImageExtras.h:
2596         * Misc/WebNSImageExtras.m:
2597         * Misc/WebNSPasteboardExtras.mm:
2598         * Misc/WebNSPrintOperationExtras.h:
2599         * Misc/WebNSPrintOperationExtras.m:
2600         * Misc/WebNSViewExtras.m:
2601         * Misc/WebNSWindowExtras.m:
2602         * Panels/WebAuthenticationPanel.h:
2603         * Panels/WebAuthenticationPanel.m:
2604         * Panels/WebPanelAuthenticationHandler.m:
2605         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2606         (+[WebHostedNetscapePluginView initialize]):
2607         * Plugins/WebBasePluginPackage.h:
2608         * Plugins/WebBasePluginPackage.mm:
2609         * Plugins/WebJavaPlugIn.h:
2610         * Plugins/WebPluginContainerCheck.mm:
2611         * Plugins/WebPluginController.h:
2612         * Plugins/WebPluginController.mm:
2613         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2614         (-[WebPluginController addPlugin:]):
2615         (-[WebPluginController destroyPlugin:]):
2616         (-[WebPluginController destroyAllPlugins]):
2617         * Plugins/WebPluginDatabase.mm:
2618         (+[WebPluginDatabase _defaultPlugInPaths]):
2619         * Plugins/WebPluginPackage.mm:
2620         (-[WebPluginPackage initWithPath:]):
2621         * Storage/WebDatabaseManager.mm:
2622         (-[WebDatabaseManager deleteAllDatabases]):
2623         * Storage/WebDatabaseManagerClient.h:
2624         * Storage/WebDatabaseManagerClient.mm:
2625         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2626         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2627         * Storage/WebStorageManager.mm:
2628         (-[WebStorageManager deleteAllOrigins]):
2629         (WebKitInitializeStorageIfNecessary):
2630         * WebCoreSupport/WebAlternativeTextClient.h:
2631         * WebCoreSupport/WebApplicationCache.mm:
2632         (applicationCacheBundleIdentifier):
2633         * WebCoreSupport/WebChromeClient.h:
2634         * WebCoreSupport/WebChromeClient.mm:
2635         (WebChromeClient::setWindowRect):
2636         (WebChromeClient::windowRect):
2637         (WebChromeClient::takeFocus):
2638         (WebChromeClient::addMessageToConsole):
2639         (WebChromeClient::enableSuddenTermination):
2640         (WebChromeClient::disableSuddenTermination):
2641         (WebChromeClient::createPopupMenu const):
2642         (WebChromeClient::createSearchPopupMenu const):
2643         (WebChromeClient::shouldPaintEntireContents const):
2644         (WebChromeClient::supportsVideoFullscreen):
2645         (WebChromeClient::supportsFullScreenForElement):
2646         (WebChromeClient::enterFullScreenForElement):
2647         (WebChromeClient::exitFullScreenForElement):
2648         * WebCoreSupport/WebContextMenuClient.mm:
2649         * WebCoreSupport/WebDragClient.mm:
2650         * WebCoreSupport/WebEditorClient.h:
2651         * WebCoreSupport/WebEditorClient.mm:
2652         (+[WebUndoStep initialize]):
2653         (updateFontPanel):
2654         (WebEditorClient::didBeginEditing):
2655         (WebEditorClient::respondToChangedContents):
2656         (WebEditorClient::respondToChangedSelection):
2657         (WebEditorClient::canceledComposition):
2658         (WebEditorClient::didEndEditing):
2659         (WebEditorClient::didWriteSelectionToPasteboard):
2660         (attributesForAttributedStringConversion):
2661         (WebEditorClient::setInsertionPasteboard):
2662         (WebEditorClient::registerUndoOrRedoStep):
2663         (WebEditorClient::handleKeyboardEvent):
2664         (WebEditorClient::handleInputMethodKeydown):
2665         (WebEditorClient::textDidChangeInTextField):
2666         (WebEditorClient::requestCheckingOfString):
2667         * WebCoreSupport/WebFrameLoaderClient.h:
2668         * WebCoreSupport/WebFrameLoaderClient.mm:
2669         (WebFrameLoaderClient::detachedFromParent2):
2670         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2671         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2672         (WebFrameLoaderClient::dispatchWillSendRequest):
2673         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2674         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2675         (WebFrameLoaderClient::willCacheResponse const):
2676         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2677         (WebFrameLoaderClient::dispatchDidFinishLoading):
2678         (WebFrameLoaderClient::dispatchDidFailLoading):
2679         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2680         (WebFrameLoaderClient::dispatchWillClose):
2681         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2682         (WebFrameLoaderClient::dispatchDidCommitLoad):
2683         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2684         (WebFrameLoaderClient::dispatchDidFailLoad):
2685         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2686         (WebFrameLoaderClient::dispatchDidFinishLoad):
2687         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2688         (WebFrameLoaderClient::willChangeTitle):
2689         (WebFrameLoaderClient::didChangeTitle):
2690         (WebFrameLoaderClient::didReplaceMultipartContent):
2691         (WebFrameLoaderClient::updateGlobalHistory):
2692         (WebFrameLoaderClient::saveViewStateToItem):
2693         (WebFrameLoaderClient::restoreViewState):
2694         (WebFrameLoaderClient::provisionalLoadStarted):
2695         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2696         (WebFrameLoaderClient::setTitle):
2697         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2698         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2699         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2700         (WebFrameLoaderClient::didRestoreFromPageCache):
2701         (WebFrameLoaderClient::actionDictionary const):
2702         (WebFrameLoaderClient::createPlugin):
2703         (WebFrameLoaderClient::getLoadDecisionForIcons):
2704         (WebFrameLoaderClient::finishedLoadingIcon):
2705         (+[WebFramePolicyListener initialize]):
2706         * WebCoreSupport/WebFrameNetworkingContext.mm:
2707         * WebCoreSupport/WebGeolocationClient.h:
2708         * WebCoreSupport/WebGeolocationClient.mm:
2709         (WebGeolocationClient::requestPermission):
2710         * WebCoreSupport/WebInspectorClient.h:
2711         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2712         * WebCoreSupport/WebNotificationClient.mm:
2713         * WebCoreSupport/WebOpenPanelResultListener.mm:
2714         * WebCoreSupport/WebPlatformStrategies.h:
2715         * WebCoreSupport/WebPlatformStrategies.mm:
2716         * WebCoreSupport/WebProgressTrackerClient.h:
2717         * WebCoreSupport/WebProgressTrackerClient.mm:
2718         (WebProgressTrackerClient::progressStarted):
2719         (WebProgressTrackerClient::progressEstimateChanged):
2720         (WebProgressTrackerClient::progressFinished):
2721         * WebCoreSupport/WebSecurityOrigin.mm:
2722         * WebInspector/WebNodeHighlight.h:
2723         * WebInspector/WebNodeHighlight.mm:
2724         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2725         (-[WebNodeHighlight dealloc]):
2726         (-[WebNodeHighlight attach]):
2727         * WebInspector/WebNodeHighlightView.h:
2728         * WebInspector/WebNodeHighlightView.mm:
2729         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2730         (-[WebNodeHighlightView dealloc]):
2731         * WebInspector/WebNodeHighlighter.mm:
2732         (-[WebNodeHighlighter highlight]):
2733         * WebView/WebArchive.mm:
2734         (+[WebArchivePrivate initialize]):
2735         * WebView/WebClipView.h:
2736         * WebView/WebDataSource.mm:
2737         (WebDataSourcePrivate::WebDataSourcePrivate):
2738         (+[WebDataSource initialize]):
2739         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2740         (-[WebDataSource _makeRepresentation]):
2741         * WebView/WebDelegateImplementationCaching.h:
2742         * WebView/WebDelegateImplementationCaching.mm:
2743         (CallDelegate):
2744         (CallDelegateReturningFloat):
2745         (CallDelegateReturningBoolean):
2746         (CallUIDelegate):
2747         (CallUIDelegateReturningFloat):
2748         (CallUIDelegateReturningBoolean):
2749         (CallFrameLoadDelegate):
2750         (CallFrameLoadDelegateReturningBoolean):
2751         (CallResourceLoadDelegate):
2752         (CallScriptDebugDelegate):
2753         (CallFormDelegate):
2754         (CallFormDelegateReturningBoolean):
2755         * WebView/WebDeviceOrientation.mm:
2756         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2757         * WebView/WebDocumentInternal.h:
2758         * WebView/WebDocumentLoaderMac.mm:
2759         (needsDataLoadWorkaround):
2760         * WebView/WebDynamicScrollBarsViewInternal.h:
2761         * WebView/WebFormDelegate.m:
2762         * WebView/WebFrame.mm:
2763         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2764         (-[WebFrame _unmarkAllMisspellings]):
2765         (-[WebFrame _paintBehaviorForDestinationContext:]):
2766         (-[WebFrame _drawRect:contentsOnly:]):
2767         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2768         (-[WebFrame _scrollDOMRangeToVisible:]):
2769         (-[WebFrame _bodyBackgroundColor]):
2770         (-[WebFrame accessibilityRoot]):
2771         (needsMicrosoftMessengerDOMDocumentWorkaround):
2772         * WebView/WebFrameInternal.h:
2773         * WebView/WebFrameView.mm:
2774         (-[WebFrameView _setDocumentView:]):
2775         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2776         (-[WebFrameView _viewClassForMIMEType:]):
2777         (-[WebFrameView initWithFrame:]):
2778         (-[WebFrameView drawRect:]):
2779         (-[WebFrameView _firstResponderIsFormControl]):
2780         (-[WebFrameView keyDown:keyDown:]):
2781         (-[WebFrameView _isScrollable]):
2782         * WebView/WebFullScreenController.h:
2783         * WebView/WebFullScreenController.mm:
2784         * WebView/WebHTMLRepresentation.mm:
2785         * WebView/WebHTMLView.mm:
2786         (-[WebHTMLView hitTest:]):
2787         (-[WebHTMLView initWithFrame:]):
2788         (-[WebHTMLView dealloc]):
2789         (-[WebHTMLView addSubview:]):
2790         (-[WebHTMLView mouseDown:]):
2791         (-[WebHTMLView mouseUp:]):
2792         (-[WebHTMLView resignFirstResponder]):
2793         (-[WebHTMLView accessibilityHitTest:]):
2794         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2795         * WebView/WebHTMLViewInternal.h:
2796         * WebView/WebIndicateLayer.h:
2797         * WebView/WebIndicateLayer.mm:
2798         * WebView/WebMediaPlaybackTargetPicker.h:
2799         * WebView/WebMediaPlaybackTargetPicker.mm:
2800         * WebView/WebPDFDocumentExtras.h:
2801         * WebView/WebPDFDocumentExtras.mm:
2802         * WebView/WebPDFRepresentation.h:
2803         * WebView/WebPDFRepresentation.mm:
2804         * WebView/WebPDFView.h:
2805         * WebView/WebPreferences.mm:
2806         (cacheModelForMainBundle):
2807         (WebPreferencesPrivate::WebPreferencesPrivate):
2808         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2809         (-[WebPreferences encodeWithCoder:]):
2810         (+[WebPreferences standardPreferences]):
2811         (+[WebPreferences initialize]):
2812         (-[WebPreferences _valueForKey:]):
2813         (-[WebPreferences _setStringValue:forKey:]):
2814         (-[WebPreferences _setIntegerValue:forKey:]):
2815         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2816         (-[WebPreferences _setFloatValue:forKey:]):
2817         (-[WebPreferences _setBoolValue:forKey:]):
2818         (-[WebPreferences _setLongLongValue:forKey:]):
2819         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2820         (-[WebPreferences _postCacheModelChangedNotification]):
2821         (-[WebPreferences _postPreferencesChangedNotification]):
2822         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2823         (-[WebPreferences setStorageBlockingPolicy:]):
2824         * WebView/WebResource.mm:
2825         (+[WebResourcePrivate initialize]):
2826         * WebView/WebTextCompletionController.h:
2827         * WebView/WebTextIterator.mm:
2828         (+[WebTextIteratorPrivate initialize]):
2829         * WebView/WebView.mm:
2830         (shouldEnableLoadDeferring):
2831         (shouldRestrictWindowFocus):
2832         (shouldRespectPriorityInCSSAttributeSetters):
2833         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2834         (shouldAllowPictureInPictureMediaPlayback):
2835         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2836         (shouldAllowWindowOpenWithoutUserGesture):
2837         (shouldConvertInvalidURLsToBlank):
2838         (shouldRequireUserGestureToLoadVideo):
2839         (-[WebView _commonInitializationWithFrameName:groupName:]):
2840         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2841         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2842         (-[WebView _closePluginDatabases]):
2843         (-[WebView _closeWithFastTeardown]):
2844         (-[WebView _close]):
2845         (+[WebView _MIMETypeForFile:]):
2846         (-[WebView setShowingInspectorIndication:]):
2847         (-[WebView _setFormDelegate:]):
2848         (-[WebView _needsPreHTML5ParserQuirks]):
2849         (-[WebView _preferencesChangedNotification:]):
2850         (-[WebView _preferencesChanged:]):
2851         (-[WebView _cacheResourceLoadDelegateImplementations]):
2852         (-[WebView _cacheFrameLoadDelegateImplementations]):
2853         (-[WebView _policyDelegateForwarder]):
2854         (-[WebView _UIDelegateForwarder]):
2855         (-[WebView _editingDelegateForwarder]):
2856         (-[WebView _updateActiveState]):
2857         (-[_WebSafeForwarder forwardInvocation:]):
2858         (+[WebView initialize]):
2859         (-[WebView _pluginForMIMEType:]):
2860         (-[WebView _pluginForExtension:]):
2861         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2862         (+[WebView canShowMIMETypeAsHTML:]):
2863         (-[WebView _initWithArguments:]):
2864         (-[WebView initWithFrame:frameName:groupName:]):
2865         (-[WebView dealloc]):
2866         (-[WebView close]):
2867         (-[WebView viewDidMoveToWindow]):
2868         (-[WebView setUIDelegate:]):
2869         (-[WebView setResourceLoadDelegate:]):
2870         (-[WebView setPolicyDelegate:]):
2871         (-[WebView setFrameLoadDelegate:]):
2872         (-[WebView goBack]):
2873         (-[WebView goForward]):
2874         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2875         (-[WebView setHostWindow:]):
2876         (-[WebView becomeFirstResponder]):
2877         (+[WebView _cacheModelChangedNotification:]):
2878         (-[WebView _frameViewAtWindowPoint:]):
2879         (+[WebView _preflightSpellCheckerNow:]):
2880         (+[WebView _preflightSpellChecker]):
2881         (-[WebView canGoBack]):
2882         (-[WebView canGoForward]):
2883         (-[WebView stopLoading:]):
2884         (-[WebView reload:]):
2885         (-[WebView setMainFrameDocumentReady:]):
2886         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2887         (-[WebView setContinuousSpellCheckingEnabled:]):
2888         (-[WebView undoManager]):
2889         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2890         (-[WebView isAutomaticLinkDetectionEnabled]):
2891         (-[WebView isAutomaticDashSubstitutionEnabled]):
2892         (-[WebView isAutomaticTextReplacementEnabled]):
2893         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2894         (+[WebView _setCacheModel:]):
2895         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2896         (-[WebView _keyboardUIMode]):
2897         (LayerFlushController::flushLayers):
2898         (-[WebView _scheduleCompositingLayerFlush]):
2899         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2900         (-[WebView fullScreenPlaceholderView]):
2901         (WebInstallMemoryPressureHandler):
2902         * WebView/WebViewData.h:
2903         * WebView/WebViewData.mm:
2904         (+[WebViewPrivate initialize]):
2905         (-[WebViewPrivate init]):
2906         (-[WebViewPrivate dealloc]):
2907         * WebView/WebViewInternal.h:
2908
2909 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2910
2911         Clean up FrameLoader two-state enums
2912         https://bugs.webkit.org/show_bug.cgi?id=190731
2913
2914         Reviewed by Chris Dumez.
2915
2916         * WebCoreSupport/WebFrameLoaderClient.h:
2917         * WebCoreSupport/WebFrameLoaderClient.mm:
2918         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2919
2920 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2921
2922         Unreviewed, rolling out r237137.
2923
2924         SPI is actually used
2925
2926         Reverted changeset:
2927
2928         "Remove unused WebFrame._loadType"
2929         https://bugs.webkit.org/show_bug.cgi?id=190583
2930         https://trac.webkit.org/changeset/237137
2931
2932 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2933
2934         Enable the datalist element by default on iOS and macOS
2935         https://bugs.webkit.org/show_bug.cgi?id=190594
2936         <rdar://problem/45281159>
2937
2938         Reviewed by Ryosuke Niwa and Tim Horton.
2939
2940         * Configurations/FeatureDefines.xcconfig:
2941
2942 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2943
2944         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2945         https://bugs.webkit.org/show_bug.cgi?id=190675
2946
2947         Reviewed by Chris Dumez.
2948
2949         * History/BackForwardList.h:
2950         * History/BackForwardList.mm:
2951         (BackForwardList::backItem):
2952         (BackForwardList::currentItem):
2953         (BackForwardList::forwardItem):
2954         (BackForwardList::backListCount const):
2955         (BackForwardList::forwardListCount const):
2956         (BackForwardList::itemAtIndex):
2957         * History/WebBackForwardList.mm:
2958         (-[WebBackForwardList backItem]):
2959         (-[WebBackForwardList currentItem]):
2960         (-[WebBackForwardList forwardItem]):
2961         (-[WebBackForwardList itemAtIndex:]):
2962
2963 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2964
2965         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2966         https://bugs.webkit.org/show_bug.cgi?id=190526
2967         rdar://problem/45230140
2968
2969         Reviewed by Dean Jackson.
2970
2971         * WebCoreSupport/WebEditorClient.mm:
2972         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2973
2974 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2975
2976         Implement feature flag and bindings for CSS Painting API
2977         https://bugs.webkit.org/show_bug.cgi?id=190237
2978
2979         Reviewed by Ryosuke Niwa.
2980
2981         * Configurations/FeatureDefines.xcconfig:
2982
2983 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2984
2985         Replace HistoryItem* with HistoryItem& where possible
2986         https://bugs.webkit.org/show_bug.cgi?id=190617
2987
2988         Reviewed by Chris Dumez.
2989
2990         * History/BackForwardList.h:
2991         * History/BackForwardList.mm:
2992         (BackForwardList::goToItem):
2993         * History/WebBackForwardList.mm:
2994         (-[WebBackForwardList goToItem:]):
2995         * History/WebHistoryItem.mm:
2996         (WKNotifyHistoryItemChanged):
2997         * History/WebHistoryItemInternal.h:
2998
2999 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3000
3001         Remove unused WebHistoryItem._transientPropertyForKey
3002         https://bugs.webkit.org/show_bug.cgi?id=190606
3003
3004         Reviewed by Chris Dumez.
3005
3006         * History/WebHistoryItem.mm:
3007         * History/WebHistoryItemPrivate.h:
3008
3009 2018-10-15  Justin Fan  <justin_fan@apple.com>
3010
3011         Add WebGPU 2018 feature flag and experimental feature flag
3012         https://bugs.webkit.org/show_bug.cgi?id=190509
3013
3014         Reviewed by Dean Jackson.
3015
3016         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
3017         for the 2018 WebGPU prototype.
3018
3019         * Configurations/FeatureDefines.xcconfig:
3020         * WebView/WebPreferenceKeysPrivate.h:
3021         * WebView/WebPreferences.mm:
3022         (+[WebPreferences initialize]):
3023         (-[WebPreferences webGPUEnabled]):
3024         (-[WebPreferences setWebGPUEnabled:]):
3025         * WebView/WebPreferencesPrivate.h:
3026         * WebView/WebView.mm:
3027         (-[WebView _preferencesChanged:]):
3028
3029 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3030
3031         Fix iOS build after r237157
3032
3033         * WebView/WebView.mm:
3034         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3035
3036 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3037
3038         Modernize BackForwardClient.h
3039         https://bugs.webkit.org/show_bug.cgi?id=190610
3040
3041         Reviewed by Chris Dumez.
3042
3043         * History/BackForwardList.h:
3044         * History/BackForwardList.mm:
3045         (BackForwardList::backListCount const):
3046         (BackForwardList::forwardListCount const):
3047         (BackForwardList::backListCount): Deleted.
3048         (BackForwardList::forwardListCount): Deleted.
3049         * History/WebBackForwardList.mm:
3050         (-[WebBackForwardList init]):
3051         * WebCoreSupport/WebFrameLoaderClient.mm:
3052         (WebFrameLoaderClient::canCachePage const):
3053         * WebView/WebFrameView.mm:
3054         (-[WebFrameView keyDown:keyDown:]):
3055         * WebView/WebView.mm:
3056         (-[WebView _commonInitializationWithFrameName:groupName:]):
3057         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3058         (-[WebView _loadBackForwardListFromOtherView:]):
3059         (-[WebView initWithCoder:]):
3060         (-[WebView encodeWithCoder:]):
3061         (-[WebView backForwardList]):
3062         (-[WebView setMaintainsBackForwardList:]):
3063
3064 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3065
3066         Add support for prefers-color-scheme media query
3067         https://bugs.webkit.org/show_bug.cgi?id=190499
3068         rdar://problem/45212025
3069
3070         Reviewed by Dean Jackson.
3071
3072         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3073
3074 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3075
3076         Remove unused WebView._globalHistoryItem
3077         https://bugs.webkit.org/show_bug.cgi?id=190601
3078
3079         Reviewed by Chris Dumez.
3080
3081         * WebCoreSupport/WebFrameLoaderClient.h:
3082         * WebCoreSupport/WebFrameLoaderClient.mm:
3083         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
3084         * WebView/WebView.mm:
3085         (-[WebView _globalHistoryItem]): Deleted.
3086         (-[WebView _setGlobalHistoryItem:]): Deleted.
3087         * WebView/WebViewData.h:
3088         * WebView/WebViewInternal.h:
3089         * WebView/WebViewPrivate.h:
3090
3091 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3092
3093         Remove unused parameters from FrameLoaderClient::createFrame
3094         https://bugs.webkit.org/show_bug.cgi?id=190587
3095
3096         Reviewed by Chris Dumez.
3097
3098         * WebCoreSupport/WebFrameLoaderClient.h:
3099         * WebCoreSupport/WebFrameLoaderClient.mm:
3100         (WebFrameLoaderClient::createFrame):
3101
3102 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3103
3104         Remove unused WebFrame._loadType
3105         https://bugs.webkit.org/show_bug.cgi?id=190583
3106
3107         Reviewed by Chris Dumez.
3108
3109         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
3110
3111         * WebView/WebFrame.mm:
3112         (toWebFrameLoadType): Deleted.
3113         (-[WebFrame _loadType]): Deleted.
3114         * WebView/WebFramePrivate.h:
3115
3116 2018-10-15  Chris Dumez  <cdumez@apple.com>
3117
3118         Restrict browsing context lookup by name to frames that are related to one another
3119         https://bugs.webkit.org/show_bug.cgi?id=190475
3120
3121         Reviewed by Alex Christensen.
3122
3123         * WebView/WebFrame.mm:
3124         (-[WebFrame findFrameNamed:]):
3125
3126 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3127
3128         Remove InjectedBundle processing of back/forward lists
3129         https://bugs.webkit.org/show_bug.cgi?id=190459
3130
3131         Reviewed by Chris Dumez.
3132
3133         * WebCoreSupport/WebFrameLoaderClient.h:
3134         * WebCoreSupport/WebFrameLoaderClient.mm:
3135         (WebFrameLoaderClient::shouldGoToHistoryItem const):
3136
3137 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3138
3139         [JSC] Remove Option::useAsyncIterator
3140         https://bugs.webkit.org/show_bug.cgi?id=190567
3141
3142         Reviewed by Saam Barati.
3143
3144         * Configurations/FeatureDefines.xcconfig:
3145
3146 2018-10-12  Alex Christensen  <achristensen@webkit.org>
3147
3148         Allow encoding of small enum classes
3149         https://bugs.webkit.org/show_bug.cgi?id=190531
3150
3151         Reviewed by Tim Horton.
3152
3153         * WebCoreSupport/WebFrameLoaderClient.mm:
3154         (-[WebFramePolicyListener dealloc]):
3155
3156 2018-10-11  Keith Rollin  <krollin@apple.com>
3157
3158         CURRENT_ARCH should not be used in Run Script phase.
3159         https://bugs.webkit.org/show_bug.cgi?id=190407
3160         <rdar://problem/45133556>
3161
3162         Reviewed by Alexey Proskuryakov.
3163
3164         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
3165         CURRENT_ARCH is not well-defined during this phase (and may even have
3166         the value "undefined") since this phase is run just once per build
3167         rather than once per supported architecture. Migrate away from
3168         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
3169         performing an operation for each value, or by picking the first entry
3170         in ARCHS and using that as a representative value.
3171
3172         * Configurations/WebKitLegacy.xcconfig: When generating
3173         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
3174         macosx platforms.
3175
3176         * MigrateHeaders.make:
3177         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
3178         generate one for each architecture in ARCHS.
3179
3180 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3181
3182         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3183         https://bugs.webkit.org/show_bug.cgi?id=190429
3184
3185         Reviewed by Saam Barati.
3186
3187         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
3188
3189         * WebView/WebPDFRepresentation.mm:
3190         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
3191
3192 2018-10-08  Justin Fan  <justin_fan@apple.com>
3193
3194         WebGPU: Rename old WebGPU prototype to WebMetal
3195         https://bugs.webkit.org/show_bug.cgi?id=190325
3196         <rdar://problem/44990443>
3197
3198         Reviewed by Dean Jackson.
3199
3200         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3201
3202         * Configurations/FeatureDefines.xcconfig:
3203         * WebView/WebPreferenceKeysPrivate.h:
3204         * WebView/WebPreferences.mm:
3205         (+[WebPreferences initialize]):
3206         (-[WebPreferences webMetalEnabled]):
3207         (-[WebPreferences setWebMetalEnabled:]):
3208         (-[WebPreferences webGPUEnabled]): Deleted.
3209         (-[WebPreferences setWebGPUEnabled:]): Deleted.
3210         * WebView/WebPreferencesPrivate.h:
3211         * WebView/WebView.mm:
3212         (-[WebView _preferencesChanged:]):
3213
3214 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3215
3216         Make <input type=color> a runtime enabled (on-by-default) feature
3217         https://bugs.webkit.org/show_bug.cgi?id=189162
3218
3219         Reviewed by Wenson Hsieh and Tim Horton.
3220
3221         * Configurations/FeatureDefines.xcconfig:
3222
3223 2018-10-07  Dan Bernstein  <mitz@apple.com>
3224
3225         Fixed building with the latest macOS SDK
3226
3227         * Plugins/WebNetscapePluginPackage.mm:
3228         (-[WebNetscapePluginPackage openResourceFile]):
3229         (-[WebNetscapePluginPackage closeResourceFile:]):
3230
3231 2018-10-04  Dan Bernstein  <mitz@apple.com>
3232
3233         More Carbon build-fixing.
3234
3235         * Carbon/CarbonWindowAdapter.mm:
3236         (-[CarbonWindowAdapter _destroyRealWindow:]):
3237         (-[CarbonWindowAdapter _growBoxRect]):
3238
3239 2018-10-04  Dan Bernstein  <mitz@apple.com>
3240
3241         Retried to fix 32-bit macOS builds after r236846.
3242
3243         * WebView/WebHTMLView.mm:
3244         (-[WebHTMLView setMarkedText:selectedRange:]):
3245
3246 2018-10-04  Dan Bernstein  <mitz@apple.com>
3247
3248         Retried to fix 32-bit macOS builds after r236846.
3249
3250         * Carbon/HIWebView.mm:
3251         (ActiveStateChanged):
3252
3253 2018-10-04  Dan Bernstein  <mitz@apple.com>
3254
3255         Tried to fix 32-bit macOS builds after r236846.
3256
3257         * Carbon/HIWebView.mm:
3258         (_NSSelectorForHICommand):
3259
3260 2018-10-04  Dan Bernstein  <mitz@apple.com>
3261
3262         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
3263         https://bugs.webkit.org/show_bug.cgi?id=190250
3264
3265         Reviewed by Andy Estes.
3266
3267         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
3268           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3269           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
3270           an earlier line set it to YES.
3271
3272         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
3273         changes below.
3274
3275         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
3276           provides some missing method declarations.
3277
3278         * Misc/WebDownload.mm:
3279         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
3280           a deprecated method.
3281
3282         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
3283
3284         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
3285           other code in the file uses a method from it.
3286
3287         * Plugins/WebBaseNetscapePluginView.mm:
3288         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
3289           a deprecated method.
3290
3291         * Plugins/WebPluginController.mm:
3292         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
3293           around use of a selector that may be present in some WebKit client.
3294
3295         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
3296           method declarations.
3297
3298         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
3299           from here.
3300
3301         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
3302           missing method declarations.
3303
3304         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
3305           from here.
3306
3307         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
3308           call from here.
3309         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
3310           an obsolete delegate method for binary compatibility.
3311         (pluginView): Ditto.
3312
3313         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
3314           call from here.
3315
3316         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
3317           WebDeviceOrientationProviderMock protocol.
3318
3319         * WebView/WebDeviceOrientationProviderMock.mm:
3320         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
3321           main @implementation.
3322
3323         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
3324           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
3325
3326         * WebView/WebDynamicScrollBarsView.mm:
3327         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
3328           of a deprecated method.
3329
3330         * WebView/WebHTMLView.mm:
3331         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
3332           selector warning around action methods that are not declared anywhere in WebKit.
3333
3334         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
3335           about implementing this deprecated method.
3336         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
3337         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3338         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3339         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3340         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3341         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3342         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3343         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3344         (-[WebHTMLView doCommandBySelector:]): Ditto.
3345         (-[WebHTMLView insertText:]): Ditto.
3346
3347         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
3348
3349         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
3350
3351         * WebView/WebPDFView.h: Removed previewView ivar.
3352
3353         * WebView/WebPDFView.mm:
3354           Removed declaration of FileInternal category and merged its implementation with the main
3355           implementation.
3356         (-[WebPDFView dealloc]): Removed previewView ivar.
3357         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
3358           exist in macOS versions we support.
3359         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
3360         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
3361           action methods internal to PDFKit.
3362         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
3363         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
3364
3365         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
3366           call on macOS, even though in r86988 we started calling different methods on iOS.
3367
3368         * WebView/WebView.mm:
3369         - Imported headers that declare delegate methods that we call.
3370         - Removed declaration of WebFileInternal category and merged its implementation with the
3371           main implementation.
3372         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
3373           category, which made them impossible to call from the main implementation. Moved those
3374           into the main implementation. One of those had to be declared in a class extension,
3375           because it is called from a method implemented in the WebPrivate category, and that
3376           category’s implementation appears first in the file.
3377
3378         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
3379           around use of obsolete delegate method for binary compatibility.
3380
3381         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
3382
3383 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3384
3385         Runtime flag and IDL for MediaRecorder
3386         https://bugs.webkit.org/show_bug.cgi?id=190018
3387
3388         Reviewed by Youenn Fablet and Chris Dumez.
3389
3390         * WebView/WebPreferenceKeysPrivate.h:
3391         * WebView/WebPreferences.mm:
3392         (+[WebPreferences initialize]):
3393         (-[WebPreferences mediaRecorderEnabled]):
3394         (-[WebPreferences setMediaRecorderEnabled:]):
3395         * WebView/WebPreferencesPrivate.h:
3396         * WebView/WebView.mm:
3397         (-[WebView _preferencesChanged:]):
3398
3399 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3400
3401         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3402         https://bugs.webkit.org/show_bug.cgi?id=190238
3403
3404         Reviewed by Antti Koivisto.
3405
3406         Enabled the feature by default.
3407
3408         * WebView/WebPreferences.mm:
3409         (+[WebPreferences initialize]):
3410
3411 2018-10-01  Dean Jackson  <dino@apple.com>
3412
3413         [macOS] Switching to discrete GPU should be done in the UI process
3414         https://bugs.webkit.org/show_bug.cgi?id=189361
3415         <rdar://problem/43949622>
3416
3417         Reviewed by Simon Fraser.
3418
3419         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
3420         not support swapping to the discrete GPU in this configuration.
3421
3422         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
3423         (WebKit::WebSwitchingGPUClient::singleton):
3424         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
3425         * WebView/WebView.mm:
3426         (-[WebView _commonInitializationWithFrameName:groupName:]):
3427
3428 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3429
3430         Remove ParsedURLString
3431         https://bugs.webkit.org/show_bug.cgi?id=190154
3432
3433         Reviewed by Chris Dumez.
3434
3435         * WebView/WebScriptDebugger.mm:
3436         (toNSURL):
3437
3438 2018-10-01  Dean Jackson  <dino@apple.com>
3439
3440         Remove CSS Animation Triggers
3441         https://bugs.webkit.org/show_bug.cgi?id=190175
3442         <rdar://problem/44925626>
3443
3444         Reviewed by Simon Fraser.
3445
3446         * Configurations/FeatureDefines.xcconfig:
3447
3448 2018-10-02  Commit Queue  <commit-queue@webkit.org>
3449
3450         Unreviewed, rolling out r236624 and r236671.
3451         https://bugs.webkit.org/show_bug.cgi?id=190207
3452
3453         The change in r236624 introduced crashes on the bots
3454         (Requested by ryanhaddad on #webkit).
3455
3456         Reverted changesets:
3457
3458         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3459         https://bugs.webkit.org/show_bug.cgi?id=188747
3460         https://trac.webkit.org/changeset/236624
3461
3462         "Unify implementation in VideoFullscreenInterfaceAVKit"
3463         https://bugs.webkit.org/show_bug.cgi?id=190091
3464         https://trac.webkit.org/changeset/236671
3465
3466 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3467
3468         URL should not use TextEncoding internally
3469         https://bugs.webkit.org/show_bug.cgi?id=190111
3470
3471         Reviewed by Andy Estes.
3472
3473         * Misc/WebNSURLExtras.mm:
3474
3475 2018-09-28  Jer Noble  <jer.noble@apple.com>
3476
3477         Refactoring: eliminate raw pointer usage in Fullscreen code
3478         https://bugs.webkit.org/show_bug.cgi?id=188747
3479         <rdar://problem/43541164>
3480
3481         Reviewed by Alex Christensen.
3482
3483         PlaybackSessionInterface no longer has an invalidate() method.
3484
3485         * WebView/WebView.mm:
3486         (-[WebView _clearPlaybackControlsManager]):
3487
3488 2018-09-28  Chris Dumez  <cdumez@apple.com>
3489
3490         Drop support for cross-origin-window-policy header
3491         https://bugs.webkit.org/show_bug.cgi?id=190081
3492
3493         Reviewed by Ryosuke Niwa.
3494
3495         * WebView/WebPreferenceKeysPrivate.h:
3496         * WebView/WebPreferences.mm:
3497         (+[WebPreferences initialize]):
3498         * WebView/WebPreferencesPrivate.h:
3499         * WebView/WebView.mm:
3500         (-[WebView _preferencesChanged:]):
3501
3502 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3503
3504         Rename createMarkup to serializePreservingVisualAppearance
3505         https://bugs.webkit.org/show_bug.cgi?id=190086
3506
3507         Reviewed by Wenson Hsieh.
3508
3509         * DOM/WebDOMOperations.mm:
3510         (-[DOMRange markupString]):
3511
3512 2018-09-28  Commit Queue  <commit-queue@webkit.org>
3513
3514         Unreviewed, rolling out r236605.
3515         https://bugs.webkit.org/show_bug.cgi?id=190087
3516
3517         caused three API test timeouts (Requested by jernoble on
3518         #webkit).
3519
3520         Reverted changeset:
3521
3522         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3523         https://bugs.webkit.org/show_bug.cgi?id=188747
3524         https://trac.webkit.org/changeset/236605
3525
3526 2018-09-28  Jer Noble  <jer.noble@apple.com>
3527
3528         Refactoring: eliminate raw pointer usage in Fullscreen code
3529         https://bugs.webkit.org/show_bug.cgi?id=188747
3530         <rdar://problem/43541164>
3531
3532         Reviewed by Alex Christensen.
3533
3534         PlaybackSessionInterface no longer has an invalidate() method.
3535
3536         * WebView/WebView.mm:
3537         (-[WebView _clearPlaybackControlsManager]):
3538
3539 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3540
3541         Use enum class in createMarkup arguments
3542         https://bugs.webkit.org/show_bug.cgi?id=190028
3543
3544         Reviewed by Wenson Hsieh.
3545
3546         * DOM/WebDOMOperations.mm:
3547         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
3548         (-[DOMRange markupString]): Ditto.
3549
3550 2018-09-27  Antoine Quint  <graouts@apple.com>
3551
3552         [Web Animations] Turn Web Animations with CSS integration on
3553         https://bugs.webkit.org/show_bug.cgi?id=184819
3554         <rdar://problem/39597337>
3555
3556         Reviewed by Dean Jackson.
3557
3558         * WebView/WebPreferences.mm:
3559         (+[WebPreferences initialize]):
3560
3561 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3562
3563         Selection should work across shadow boundary when initiated by a mouse drag
3564         https://bugs.webkit.org/show_bug.cgi?id=151380
3565         <rdar://problem/24363872>
3566
3567         Reviewed by Wenson Hsieh.
3568
3569         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
3570
3571         * WebView/WebPreferenceKeysPrivate.h:
3572         * WebView/WebPreferences.mm:
3573         (+[WebPreferences initialize]):
3574         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
3575         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
3576         * WebView/WebPreferencesPrivate.h:
3577         * WebView/WebView.mm:
3578         (-[WebView _preferencesChanged:]):
3579
3580 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3581
3582         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3583         https://bugs.webkit.org/show_bug.cgi?id=189918
3584         Work towards <rdar://problem/44648705>
3585
3586         Reviewed by Tim Horton.
3587
3588         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3589
3590         * WebView/WebHTMLView.mm:
3591         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3592         (-[WebHTMLView _updateFontPanel]):
3593         * WebView/WebView.mm:
3594         (-[WebView typingAttributes]):
3595
3596 2018-09-17  Darin Adler  <darin@apple.com>
3597
3598         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3599         https://bugs.webkit.org/show_bug.cgi?id=189652
3600
3601         Reviewed by Saam Barati.
3602
3603         * WebView/WebPDFRepresentation.mm:
3604         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3605
3606 2018-09-14  Jer Noble  <jer.noble@apple.com>
3607
3608         Turn SourceBufferChangeTypeEnabled on by default
3609         https://bugs.webkit.org/show_bug.cgi?id=189527
3610
3611         Reviewed by Eric Carlson.
3612
3613         * WebView/WebPreferences.mm:
3614         (+[WebPreferences initialize]):
3615
3616 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3617
3618         Fix an internal build after r235935
3619         https://bugs.webkit.org/show_bug.cgi?id=188996
3620
3621         * Carbon/HIWebView.mm:
3622         (Draw):
3623         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3624
3625 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3626
3627         Add IGNORE_WARNING_.* macros
3628         https://bugs.webkit.org/show_bug.cgi?id=188996
3629
3630         Reviewed by Michael Catanzaro.
3631
3632         * Carbon/CarbonUtils.m:
3633         (PoolCleaner):
3634         * Carbon/CarbonWindowAdapter.mm:
3635         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3636         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3637         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3638         (-[CarbonWindowAdapter _termWindowIfOwner]):
3639         (-[CarbonWindowAdapter _windowMovedToRect:]):
3640         (-[CarbonWindowAdapter setContentView:]):
3641         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3642         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3643         * Carbon/CarbonWindowFrame.m:
3644         (-[CarbonWindowFrame title]):
3645         * Carbon/HIViewAdapter.m:
3646         (+[HIViewAdapter getHIViewForNSView:]):
3647         * Carbon/HIWebView.mm:
3648         (overrideCGContext):
3649         (restoreCGContext):
3650         (Draw):
3651         * DOM/DOM.mm:
3652         * History/WebHistory.mm:
3653         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3654         * History/WebHistoryItem.mm:
3655         (-[WebHistoryItem icon]):
3656         * Misc/WebKitNSStringExtras.mm:
3657         (-[NSString _web_drawAtPoint:font:textColor:]):
3658         * Misc/WebNSImageExtras.m:
3659         (-[NSImage _web_scaleToMaxSize:]):
3660         (-[NSImage _web_dissolveToFraction:]):
3661         * Misc/WebNSPasteboardExtras.mm:
3662         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3663         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3664         * Panels/WebAuthenticationPanel.m:
3665         (-[WebAuthenticationPanel loadNib]):
3666         * Plugins/Hosted/NetscapePluginHostManager.mm:
3667         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3668         (WebKit::NetscapePluginHostManager::didCreateWindow):
3669         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3670         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3671         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3672         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3673         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3674         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3675         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3676         (-[WebHostedNetscapePluginView drawRect:]):
3677         * Plugins/Hosted/WebTextInputWindowController.m:
3678         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3679         * Plugins/WebBaseNetscapePluginView.mm:
3680         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3681         * Plugins/WebNetscapePluginPackage.mm:
3682         (-[WebNetscapePluginPackage _tryLoad]):
3683         * Plugins/WebNetscapePluginView.mm:
3684         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3685         (-[WebNetscapePluginView sendDrawRectEvent:]):
3686         (-[WebNetscapePluginView drawRect:]):
3687         * Plugins/WebPluginController.mm:
3688         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3689         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3690         * WebCoreSupport/PopupMenuMac.mm:
3691         (PopupMenuMac::populate):
3692         * WebCoreSupport/WebAlternativeTextClient.h:
3693         * WebCoreSupport/WebDragClient.mm:
3694         (WebDragClient::startDrag):
3695         * WebCoreSupport/WebFrameLoaderClient.mm:
3696         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3697         (webGetNSImage):
3698         * WebInspector/WebNodeHighlight.mm:
3699         * WebInspector/WebNodeHighlightView.mm:
3700         (-[WebNodeHighlightView drawRect:]):
3701         * WebView/WebClipView.mm:
3702         (-[WebClipView initWithFrame:]):
3703         * WebView/WebFrame.mm:
3704         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3705         (-[WebFrame _drawRect:contentsOnly:]):
3706         (-[WebFrame accessibilityRoot]):
3707         * WebView/WebFullScreenController.mm:
3708         (-[WebFullScreenController enterFullScreen:]):
3709         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3710         (-[WebFullScreenController exitFullScreen]):
3711         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3712         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3713         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3714         * WebView/WebHTMLView.mm:
3715         (-[NSWindow _web_borderView]):
3716         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3717         (-[WebHTMLView _setAsideSubviews]):
3718         (-[WebHTMLView _autoscroll]):
3719         (-[WebHTMLView drawRect:]):
3720         (-[WebHTMLView mouseDown:]):
3721         (-[WebHTMLView mouseDragged:]):
3722         (-[WebHTMLView mouseUp:]):
3723         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3724         (-[WebHTMLView knowsPageRange:]):
3725         (-[WebHTMLView accessibilityHitTest:]):
3726         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3727         (-[WebHTMLView _colorAsString:]):
3728         (-[WebHTMLView copyFont:]):
3729         (-[WebHTMLView _executeSavedKeypressCommands]):
3730         (-[WebHTMLView attachRootLayer:]):
3731         (-[WebHTMLView textStorage]):
3732         (-[WebHTMLView _updateSelectionForInputManager]):
3733         * WebView/WebPDFView.mm:
3734         (_applicationInfoForMIMEType):
3735         (-[WebPDFView centerSelectionInVisibleArea:]):
3736         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3737         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3738         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3739         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3740         * WebView/WebTextCompletionController.mm:
3741         (-[WebTextCompletionController _buildUI]):
3742         (-[WebTextCompletionController _placePopupWindow:]):
3743         * WebView/WebVideoFullscreenController.mm:
3744         * WebView/WebVideoFullscreenHUDWindowController.mm:
3745         (createMediaUIBackgroundView):
3746         * WebView/WebView.mm:
3747         (-[WebTextListTouchBarViewController initWithWebView:]):
3748         (-[WebView _dispatchTileDidDraw:]):
3749         (-[WebView encodeWithCoder:]):
3750         (-[WebView mainFrameIcon]):
3751         (LayerFlushController::flushLayers):
3752         * WebView/WebWindowAnimation.mm:
3753         (setScaledFrameForWindow):
3754
3755 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3756
3757         Remove unused needsDestruction class variables from HashTraits
3758         https://bugs.webkit.org/show_bug.cgi?id=189490
3759
3760         Reviewed by Daniel Bates.
3761
3762         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3763
3764 2018-09-07  Frederic Wang  <fwang@igalia.com>
3765
3766         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3767         https://bugs.webkit.org/show_bug.cgi?id=182230
3768
3769         Reviewed by Simon Fraser.
3770
3771         * DOM/DOMDocument.mm:
3772         (-[DOMDocument scrollingElement]): Use the new name.
3773
3774 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3775
3776         Refactor WebCore::EditAction to be an 8-bit enum class
3777         https://bugs.webkit.org/show_bug.cgi?id=189383
3778
3779         Reviewed by Dan Bernstein.
3780
3781         * WebCoreSupport/WebEditorClient.mm:
3782         (undoNameForEditAction):
3783         * WebView/WebHTMLView.mm:
3784         (-[WebHTMLView pasteFont:]):
3785         (-[WebHTMLView changeFont:]):
3786         (-[WebHTMLView changeAttributes:]):
3787         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3788         (-[WebHTMLView changeColor:]):
3789         * WebView/WebView.mm:
3790         (-[WebView setTypingStyle:]):
3791
3792 2018-09-06  Frederic Wang  <fwang@igalia.com>
3793
3794         Group options of scrollRectToVisible into a struct
3795         https://bugs.webkit.org/show_bug.cgi?id=189352
3796
3797         Reviewed by Simon Fraser.
3798
3799         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3800         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3801         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3802
3803 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3804
3805         [macOS] Cannot change font size at selection until font panel is shown
3806         https://bugs.webkit.org/show_bug.cgi?id=189295
3807         <rdar://problem/35593389>
3808
3809         Reviewed by Ryosuke Niwa.
3810
3811         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3812         WebCore ChangeLog for more details.
3813
3814         * WebView/WebHTMLView.mm:
3815         (-[WebHTMLView changeFont:]):
3816         (-[WebHTMLView changeAttributes:]):
3817         (-[WebHTMLView _originalFontA]): Deleted.
3818         (-[WebHTMLView _originalFontB]): Deleted.
3819         (fontNameForDescription): Deleted.
3820         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3821         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3822         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3823
3824 2018-09-05  Jer Noble  <jer.noble@apple.com>
3825
3826         Add MediaCapabilities as an Experimental Feature
3827         https://bugs.webkit.org/show_bug.cgi?id=189209
3828
3829         Reviewed by Eric Carlson.
3830
3831         RuntimeEnabledFeature -> Setting.
3832
3833         * WebView/WebView.mm:
3834         (-[WebView _preferencesChanged:]):
3835
3836 2018-09-04  Frederic Wang  <fwang@igalia.com>
3837
3838         Add basic support for ScrollIntoViewOptions
3839         https://bugs.webkit.org/show_bug.cgi?id=189258
3840
3841         Reviewed by Simon Fraser.
3842
3843         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3844         header so that this file can build despite the new scrollIntoView function.
3845
3846 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3847
3848         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3849         https://bugs.webkit.org/show_bug.cgi?id=188890
3850         <rdar://problem/43648605>
3851
3852         Reviewed by Tim Horton.
3853
3854         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3855         more detail.
3856
3857         * WebCoreSupport/WebPlatformStrategies.h:
3858         * WebCoreSupport/WebPlatformStrategies.mm:
3859         (WebPlatformStrategies::allStringsForType):
3860
3861 2018-09-01  Darin Adler  <darin@apple.com>
3862
3863         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3864         https://bugs.webkit.org/show_bug.cgi?id=189072
3865         Reviewed by Dan Bernstein.
3866
3867         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3868         and declarations for NSURLDownload init methods.
3869
3870         * Misc/WebDownloadInternal.h: Removed.
3871
3872         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3873         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3874         "-Wdeprecated-declarations" because the method used here is deprecated.
3875
3876         * WebView/WebView.mm:
3877         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3878         used here is deprecated.
3879
3880 2018-08-31  Chris Dumez  <cdumez@apple.com>
3881
3882         Assertion hit in ~CompletionHandler() from ~WebFrame()
3883         https://bugs.webkit.org/show_bug.cgi?id=189199
3884         <rdar://problem/42657233>
3885
3886         Reviewed by Youenn Fablet.
3887
3888         * WebCoreSupport/WebFrameLoaderClient.h:
3889         * WebCoreSupport/WebFrameLoaderClient.mm:
3890         (WebFrameLoaderClient::dispatchWillSubmitForm):
3891
3892 2018-08-31  Antti Koivisto  <antti@apple.com>
3893
3894         Replace OptionSet |= and -= operators with add() and remove() functions
3895         https://bugs.webkit.org/show_bug.cgi?id=189169
3896
3897         Reviewed by Anders Carlsson.
3898
3899         * WebView/WebFrame.mm:
3900         (-[WebFrame _drawRect:contentsOnly:]):
3901         * WebView/WebView.mm:
3902         (coreOptions):
3903
3904 2018-08-31  Frederic Wang  <fwang@igalia.com>
3905
3906         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3907         https://bugs.webkit.org/show_bug.cgi?id=182053
3908
3909         Reviewed by Simon Fraser.
3910
3911         Add developer flag to use standard behavior for scrolling* attributes.
3912
3913         * WebView/WebPreferenceKeysPrivate.h:
3914         * WebView/WebPreferences.mm:
3915         (+[WebPreferences initialize]):
3916         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3917         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3918         * WebView/WebPreferencesPrivate.h:
3919         * WebView/WebView.mm:
3920         (-[WebView _preferencesChanged:]):
3921
3922 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3923
3924         Implement the Web Share API
3925         https://bugs.webkit.org/show_bug.cgi?id=171100
3926         <rdar://problem/31751734>
3927
3928         Reviewed by Tim Horton.
3929
3930         * WebCoreSupport/WebChromeClient.h:
3931         * WebCoreSupport/WebChromeClient.mm:
3932         (WebChromeClient::showShareSheet):
3933         Empty declaration of showShareSheet.
3934
3935 2018-08-29  Youenn Fablet  <youenn@apple.com>
3936
3937         Remove WebRTC legacy API implementation
3938         https://bugs.webkit.org/show_bug.cgi?id=189040
3939
3940         Reviewed by Eric Carlson.
3941
3942         * WebView/WebPreferenceKeysPrivate.h:
3943         * WebView/WebPreferences.mm:
3944         (+[WebPreferences initialize]):
3945         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3946         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3947         * WebView/WebPreferencesPrivate.h:
3948         * WebView/WebView.mm:
3949         (-[WebView _preferencesChanged:]):
3950
3951 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3952
3953         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3954         https://bugs.webkit.org/show_bug.cgi?id=189054
3955
3956         Reviewed by Andy Estes.
3957
3958         Remove the pasteboard type argument from readURLFromPasteboard.
3959
3960         * WebCoreSupport/WebPlatformStrategies.h:
3961         * WebCoreSupport/WebPlatformStrategies.mm:
3962         (WebPlatformStrategies::readURLFromPasteboard):
3963
3964 2018-08-27  Keith Rollin  <krollin@apple.com>
3965
3966         Unreviewed build fix -- disable LTO for production builds
3967
3968         * Configurations/Base.xcconfig:
3969
3970 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3971
3972         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3973         https://bugs.webkit.org/show_bug.cgi?id=188931
3974
3975         Reviewed by Wenson Hsieh.
3976
3977         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3978
3979 2018-08-27  Keith Rollin  <krollin@apple.com>
3980
3981         Build system support for LTO
3982         https://bugs.webkit.org/show_bug.cgi?id=187785
3983         <rdar://problem/42353132>
3984
3985         Reviewed by Dan Bernstein.
3986
3987         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3988         LTO.
3989
3990         * Configurations/Base.xcconfig:
3991         * Configurations/DebugRelease.xcconfig:
3992
3993 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3994
3995         Pass in IsComposed flag to Event constructors
3996         https://bugs.webkit.org/show_bug.cgi?id=188720
3997         <rdar://problem/43580387>
3998
3999         Reviewed by Simon Fraser.
4000
4001         * WebView/WebPDFView.mm:
4002         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
4003         whether it's simulated or not.
4004
4005 2018-08-23  Mark Lam  <mark.lam@apple.com>
4006
4007         Move vmEntryGlobalObject() to VM from CallFrame.
4008         https://bugs.webkit.org/show_bug.cgi?id=188900
4009         <rdar://problem/43655753>
4010
4011         Reviewed by Michael Saboff.
4012
4013         * WebView/WebScriptDebugger.mm:
4014         (WebScriptDebugger::sourceParsed):
4015
4016 2018-08-23  Andy Estes  <aestes@apple.com>
4017
4018         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
4019         https://bugs.webkit.org/show_bug.cgi?id=188829
4020
4021         Reviewed by Tim Horton.
4022
4023         * Configurations/FeatureDefines.xcconfig:
4024
4025 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
4026
4027         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
4028         https://bugs.webkit.org/show_bug.cgi?id=188777
4029
4030         Reviewed by Simon Fraser.
4031
4032         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
4033         being "true" before the code change.
4034
4035         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
4036
4037         * WebView/WebPDFView.mm:
4038         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4039
4040 2018-08-21  Daniel Bates  <dabates@apple.com>
4041
4042         Replace TextCheckingTypeMask with OptionSet
4043         https://bugs.webkit.org/show_bug.cgi?id=188678
4044
4045         Reviewed by Antti Koivisto.
4046
4047         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
4048         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
4049         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
4050         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
4051
4052         * WebCoreSupport/WebEditorClient.h:
4053         * WebCoreSupport/WebEditorClient.mm:
4054         (WebEditorClient::checkTextOfParagraph):
4055         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
4056         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
4057         left as this is more readable and unncessary now that modern compilers like Clang have
4058         diagnostics to catch accidental assignments when equality was intended.
4059         (WebEditorClient::didCheckSucceed):
4060         * WebView/WebView.mm:
4061         (coreTextCheckingType):
4062         (textCheckingResultFromNSTextCheckingResult):
4063