Enable InstallAPI for iOS unconditionally
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2
3         Enable InstallAPI for iOS unconditionally
4         https://bugs.webkit.org/show_bug.cgi?id=191043
5         rdar://problem/32728423
6
7         Reviewed by Dan Bernstein.
8
9         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
10         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
11         shouldn't be processed by InstallAPI.
12         * MigrateHeaders.make: Removed an obsolete workaround.
13         * Misc/NSURLDownloadSPI.h: Added.
14         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
15
16 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
17
18         Clean up some obsolete MAX_ALLOWED macros
19         https://bugs.webkit.org/show_bug.cgi?id=190916
20
21         Reviewed by Tim Horton.
22
23         * WebView/WebHTMLView.mm:
24         (-[WebHTMLView pressureChangeWithEvent:]):
25         * WebView/WebPDFView.h:
26
27 2018-10-30  Commit Queue  <commit-queue@webkit.org>
28
29         Unreviewed, rolling out r237600 and r237604.
30         https://bugs.webkit.org/show_bug.cgi?id=191086
31
32         Breaks internal iOS builds (Requested by ryanhadd_ on
33         #webkit).
34
35         Reverted changesets:
36
37         "Enable InstallAPI for iOS unconditionally"
38         https://bugs.webkit.org/show_bug.cgi?id=191043
39         https://trac.webkit.org/changeset/237600
40
41         "Build fix attempt after enabling InstallAPI for iOS."
42         https://bugs.webkit.org/show_bug.cgi?id=191043
43         https://trac.webkit.org/changeset/237604
44
45 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
46
47         Enable InstallAPI for iOS unconditionally
48         https://bugs.webkit.org/show_bug.cgi?id=191043
49         rdar://problem/32728423
50
51         Reviewed by Dan Bernstein.
52
53         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
54         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
55         shouldn't be processed by InstallAPI.
56         * MigrateHeaders.make: Removed an obsolete workaround.
57         * Misc/NSURLDownloadSPI.h: Added.
58         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
59
60 2018-10-29  Tim Horton  <timothy_horton@apple.com>
61
62         Modernize WebKit nibs and lprojs for localization's sake
63         https://bugs.webkit.org/show_bug.cgi?id=190911
64         <rdar://problem/45349466>
65
66         Reviewed by Dan Bernstein.
67
68         * Misc/WebNSControlExtras.m:
69         (-[NSControl sizeToFitAndAdjustWindowHeight]):
70         NSWindow and its contents are both in the same scale space these days; avoid
71         double-applying the scale factor, or you can't see the prompt.
72
73         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
74         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
75         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
76         NIB->XIB
77
78 2018-10-25  Antoine Quint  <graouts@apple.com>
79
80         [Web Animations] Turn Web Animations CSS Integration off by default
81         https://bugs.webkit.org/show_bug.cgi?id=190901
82
83         Reviewed by Dean Jackson.
84
85         * WebView/WebPreferences.mm:
86         (+[WebPreferences initialize]):
87
88 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
89
90         Clean up some obsolete macOS version guards
91         https://bugs.webkit.org/show_bug.cgi?id=190887
92
93         Reviewed by Dan Bernstein.
94
95         * Misc/WebNSPasteboardExtras.mm:
96         (+[NSPasteboard _web_dragTypesForURL]):
97         * WebCoreSupport/PopupMenuMac.mm:
98         (PopupMenuMac::show):
99         * WebCoreSupport/WebEditorClient.h:
100         * WebCoreSupport/WebEditorClient.mm:
101         (WebEditorClient::respondToChangedSelection):
102         * WebView/WebPDFView.mm:
103         (-[WebPDFView _clipViewForPDFDocumentView]):
104
105 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
106
107         Turn on Conic Gradients
108         https://bugs.webkit.org/show_bug.cgi?id=190810
109
110         Reviewed by Tim Horton.
111
112         * Configurations/FeatureDefines.xcconfig:
113
114 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
115
116         Cleanup: MIMETypeRegistry functions
117         https://bugs.webkit.org/show_bug.cgi?id=190838
118
119         Reviewed by Simon Fraser.
120
121         * Misc/WebNSPasteboardExtras.mm:
122         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
123         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
124         because they were identical.
125
126         * WebView/WebHTMLRepresentation.mm:
127         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
128         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
129         (+[WebHTMLRepresentation supportedImageMIMETypes]):
130         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
131         * WebView/WebView.mm:
132         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
133         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
134         (+[WebView registerViewClass:representationClass:forMIMEType:]):
135
136 2018-10-23  David Kilzer  <ddkilzer@apple.com>
137
138         Fix false positive leaks when using custom -init methods that don't start with -init
139         <https://webkit.org/b/190818>
140         <rdar://problem/45476042>
141
142         Reviewed by Dan Bernstein.
143
144         * Misc/WebKitErrors.m: Move `descriptions` static global so that
145         it is accessible by both categories.
146         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
147         NSError (WebKitInternal) category.  Add attribute to make this
148         behave like an -init method.
149         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
150         NSError (WebKitInternal) category.  Modernize method.  Replace
151         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
152
153 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
154
155         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
156         https://bugs.webkit.org/show_bug.cgi?id=190729
157
158         Reviewed by Tim Horton.
159
160         * DOM/DOM.mm:
161         (-[DOMNode boundingBox]):
162         * DOM/DOMElement.mm:
163         * DOM/DOMHTML.mm:
164         * DOM/DOMInternal.mm:
165         * DOM/DOMUIKitExtensions.mm:
166         * DOM/WebDOMOperations.mm:
167         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
168         * DefaultDelegates/WebDefaultEditingDelegate.m:
169         * DefaultDelegates/WebDefaultPolicyDelegate.m:
170         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
171         * DefaultDelegates/WebDefaultUIDelegate.h:
172         * DefaultDelegates/WebDefaultUIDelegate.mm:
173         (-[WebDefaultUIDelegate webViewClose:]):
174         (-[WebDefaultUIDelegate webViewFocus:]):
175         (-[WebDefaultUIDelegate webViewUnfocus:]):
176         (-[WebDefaultUIDelegate webViewIsResizable:]):
177         (-[WebDefaultUIDelegate webView:setResizable:]):
178         (-[WebDefaultUIDelegate webView:setFrame:]):
179         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
180         * History/BackForwardList.h:
181         * History/BackForwardList.mm:
182         * History/WebBackForwardList.mm:
183         (+[WebBackForwardList initialize]):
184         (bumperCarBackForwardHackNeeded):
185         * History/WebHistory.mm:
186         (-[WebHistoryPrivate addItem:discardDuplicate:]):
187         (-[WebHistory _sendNotification:entries:]):
188         (-[WebHistory loadFromURL:error:]):
189         (-[WebHistory saveToURL:error:]):
190         * History/WebHistoryItem.mm:
191         (WKNotifyHistoryItemChanged):
192         (+[WebHistoryItem initialize]):
193         (-[WebHistoryItem initFromDictionaryRepresentation:]):
194         * History/WebURLsWithTitles.m:
195         * Misc/WebCache.mm:
196         (+[WebCache initialize]):
197         * Misc/WebDownload.mm:
198         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
199         * Misc/WebElementDictionary.mm:
200         (+[WebElementDictionary initialize]):
201         (+[WebElementDictionary initializeLookupTable]):
202         * Misc/WebIconDatabase.mm:
203         * Misc/WebKitNSStringExtras.mm:
204         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
205         * Misc/WebKitVersionChecks.h:
206         * Misc/WebKitVersionChecks.mm:
207         (WebKitLinkedOnOrAfter):
208         (WebKitLinkTimeVersion):
209         * Misc/WebLocalizableStrings.mm:
210         * Misc/WebNSControlExtras.h:
211         * Misc/WebNSControlExtras.m:
212         * Misc/WebNSEventExtras.m:
213         * Misc/WebNSFileManagerExtras.mm:
214         * Misc/WebNSImageExtras.h:
215         * Misc/WebNSImageExtras.m:
216         * Misc/WebNSPasteboardExtras.mm:
217         * Misc/WebNSPrintOperationExtras.h:
218         * Misc/WebNSPrintOperationExtras.m:
219         * Misc/WebNSViewExtras.m:
220         * Misc/WebNSWindowExtras.m:
221         * Panels/WebAuthenticationPanel.h:
222         * Panels/WebAuthenticationPanel.m:
223         * Panels/WebPanelAuthenticationHandler.m:
224         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
225         (+[WebHostedNetscapePluginView initialize]):
226         * Plugins/WebBasePluginPackage.h:
227         * Plugins/WebBasePluginPackage.mm:
228         * Plugins/WebJavaPlugIn.h:
229         * Plugins/WebPluginContainerCheck.mm:
230         * Plugins/WebPluginController.h:
231         * Plugins/WebPluginController.mm:
232         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
233         (-[WebPluginController addPlugin:]):
234         (-[WebPluginController destroyPlugin:]):
235         (-[WebPluginController destroyAllPlugins]):
236         * Plugins/WebPluginDatabase.mm:
237         (+[WebPluginDatabase _defaultPlugInPaths]):
238         * Plugins/WebPluginPackage.mm:
239         (-[WebPluginPackage initWithPath:]):
240         * Storage/WebDatabaseManager.mm:
241         (-[WebDatabaseManager deleteAllDatabases]):
242         * Storage/WebDatabaseManagerClient.h:
243         * Storage/WebDatabaseManagerClient.mm:
244         (WebDatabaseManagerClient::WebDatabaseManagerClient):
245         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
246         * Storage/WebStorageManager.mm:
247         (-[WebStorageManager deleteAllOrigins]):
248         (WebKitInitializeStorageIfNecessary):
249         * WebCoreSupport/WebAlternativeTextClient.h:
250         * WebCoreSupport/WebApplicationCache.mm:
251         (applicationCacheBundleIdentifier):
252         * WebCoreSupport/WebChromeClient.h:
253         * WebCoreSupport/WebChromeClient.mm:
254         (WebChromeClient::setWindowRect):
255         (WebChromeClient::windowRect):
256         (WebChromeClient::takeFocus):
257         (WebChromeClient::addMessageToConsole):
258         (WebChromeClient::enableSuddenTermination):
259         (WebChromeClient::disableSuddenTermination):
260         (WebChromeClient::createPopupMenu const):
261         (WebChromeClient::createSearchPopupMenu const):
262         (WebChromeClient::shouldPaintEntireContents const):
263         (WebChromeClient::supportsVideoFullscreen):
264         (WebChromeClient::supportsFullScreenForElement):
265         (WebChromeClient::enterFullScreenForElement):
266         (WebChromeClient::exitFullScreenForElement):
267         * WebCoreSupport/WebContextMenuClient.mm:
268         * WebCoreSupport/WebDragClient.mm:
269         * WebCoreSupport/WebEditorClient.h:
270         * WebCoreSupport/WebEditorClient.mm:
271         (+[WebUndoStep initialize]):
272         (updateFontPanel):
273         (WebEditorClient::didBeginEditing):
274         (WebEditorClient::respondToChangedContents):
275         (WebEditorClient::respondToChangedSelection):
276         (WebEditorClient::canceledComposition):
277         (WebEditorClient::didEndEditing):
278         (WebEditorClient::didWriteSelectionToPasteboard):
279         (attributesForAttributedStringConversion):
280         (WebEditorClient::setInsertionPasteboard):
281         (WebEditorClient::registerUndoOrRedoStep):
282         (WebEditorClient::handleKeyboardEvent):
283         (WebEditorClient::handleInputMethodKeydown):
284         (WebEditorClient::textDidChangeInTextField):
285         (WebEditorClient::requestCheckingOfString):
286         * WebCoreSupport/WebFrameLoaderClient.h:
287         * WebCoreSupport/WebFrameLoaderClient.mm:
288         (WebFrameLoaderClient::detachedFromParent2):
289         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
290         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
291         (WebFrameLoaderClient::dispatchWillSendRequest):
292         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
293         (WebFrameLoaderClient::dispatchDidReceiveResponse):
294         (WebFrameLoaderClient::willCacheResponse const):
295         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
296         (WebFrameLoaderClient::dispatchDidFinishLoading):
297         (WebFrameLoaderClient::dispatchDidFailLoading):
298         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
299         (WebFrameLoaderClient::dispatchWillClose):
300         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
301         (WebFrameLoaderClient::dispatchDidCommitLoad):
302         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
303         (WebFrameLoaderClient::dispatchDidFailLoad):
304         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
305         (WebFrameLoaderClient::dispatchDidFinishLoad):
306         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
307         (WebFrameLoaderClient::willChangeTitle):
308         (WebFrameLoaderClient::didChangeTitle):
309         (WebFrameLoaderClient::didReplaceMultipartContent):
310         (WebFrameLoaderClient::updateGlobalHistory):
311         (WebFrameLoaderClient::saveViewStateToItem):
312         (WebFrameLoaderClient::restoreViewState):
313         (WebFrameLoaderClient::provisionalLoadStarted):
314         (WebFrameLoaderClient::prepareForDataSourceReplacement):
315         (WebFrameLoaderClient::setTitle):
316         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
317         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
318         (WebFrameLoaderClient::transitionToCommittedForNewPage):
319         (WebFrameLoaderClient::didRestoreFromPageCache):
320         (WebFrameLoaderClient::actionDictionary const):
321         (WebFrameLoaderClient::createPlugin):
322         (WebFrameLoaderClient::getLoadDecisionForIcons):
323         (WebFrameLoaderClient::finishedLoadingIcon):
324         (+[WebFramePolicyListener initialize]):
325         * WebCoreSupport/WebFrameNetworkingContext.mm:
326         * WebCoreSupport/WebGeolocationClient.h:
327         * WebCoreSupport/WebGeolocationClient.mm:
328         (WebGeolocationClient::requestPermission):
329         * WebCoreSupport/WebInspectorClient.h:
330         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
331         * WebCoreSupport/WebNotificationClient.mm:
332         * WebCoreSupport/WebOpenPanelResultListener.mm:
333         * WebCoreSupport/WebPlatformStrategies.h:
334         * WebCoreSupport/WebPlatformStrategies.mm:
335         * WebCoreSupport/WebProgressTrackerClient.h:
336         * WebCoreSupport/WebProgressTrackerClient.mm:
337         (WebProgressTrackerClient::progressStarted):
338         (WebProgressTrackerClient::progressEstimateChanged):
339         (WebProgressTrackerClient::progressFinished):
340         * WebCoreSupport/WebSecurityOrigin.mm:
341         * WebInspector/WebNodeHighlight.h:
342         * WebInspector/WebNodeHighlight.mm:
343         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
344         (-[WebNodeHighlight dealloc]):
345         (-[WebNodeHighlight attach]):
346         * WebInspector/WebNodeHighlightView.h:
347         * WebInspector/WebNodeHighlightView.mm:
348         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
349         (-[WebNodeHighlightView dealloc]):
350         * WebInspector/WebNodeHighlighter.mm:
351         (-[WebNodeHighlighter highlight]):
352         * WebView/WebArchive.mm:
353         (+[WebArchivePrivate initialize]):
354         * WebView/WebClipView.h:
355         * WebView/WebDataSource.mm:
356         (WebDataSourcePrivate::WebDataSourcePrivate):
357         (+[WebDataSource initialize]):
358         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
359         (-[WebDataSource _makeRepresentation]):
360         * WebView/WebDelegateImplementationCaching.h:
361         * WebView/WebDelegateImplementationCaching.mm:
362         (CallDelegate):
363         (CallDelegateReturningFloat):
364         (CallDelegateReturningBoolean):
365         (CallUIDelegate):
366         (CallUIDelegateReturningFloat):
367         (CallUIDelegateReturningBoolean):
368         (CallFrameLoadDelegate):
369         (CallFrameLoadDelegateReturningBoolean):
370         (CallResourceLoadDelegate):
371         (CallScriptDebugDelegate):
372         (CallFormDelegate):
373         (CallFormDelegateReturningBoolean):
374         * WebView/WebDeviceOrientation.mm:
375         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
376         * WebView/WebDocumentInternal.h:
377         * WebView/WebDocumentLoaderMac.mm:
378         (needsDataLoadWorkaround):
379         * WebView/WebDynamicScrollBarsViewInternal.h:
380         * WebView/WebFormDelegate.m:
381         * WebView/WebFrame.mm:
382         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
383         (-[WebFrame _unmarkAllMisspellings]):
384         (-[WebFrame _paintBehaviorForDestinationContext:]):
385         (-[WebFrame _drawRect:contentsOnly:]):
386         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
387         (-[WebFrame _scrollDOMRangeToVisible:]):
388         (-[WebFrame _bodyBackgroundColor]):
389         (-[WebFrame accessibilityRoot]):
390         (needsMicrosoftMessengerDOMDocumentWorkaround):
391         * WebView/WebFrameInternal.h:
392         * WebView/WebFrameView.mm:
393         (-[WebFrameView _setDocumentView:]):
394         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
395         (-[WebFrameView _viewClassForMIMEType:]):
396         (-[WebFrameView initWithFrame:]):
397         (-[WebFrameView drawRect:]):
398         (-[WebFrameView _firstResponderIsFormControl]):
399         (-[WebFrameView keyDown:keyDown:]):
400         (-[WebFrameView _isScrollable]):
401         * WebView/WebFullScreenController.h:
402         * WebView/WebFullScreenController.mm:
403         * WebView/WebHTMLRepresentation.mm:
404         * WebView/WebHTMLView.mm:
405         (-[WebHTMLView hitTest:]):
406         (-[WebHTMLView initWithFrame:]):
407         (-[WebHTMLView dealloc]):
408         (-[WebHTMLView addSubview:]):
409         (-[WebHTMLView mouseDown:]):
410         (-[WebHTMLView mouseUp:]):
411         (-[WebHTMLView resignFirstResponder]):
412         (-[WebHTMLView accessibilityHitTest:]):
413         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
414         * WebView/WebHTMLViewInternal.h:
415         * WebView/WebIndicateLayer.h:
416         * WebView/WebIndicateLayer.mm:
417         * WebView/WebMediaPlaybackTargetPicker.h:
418         * WebView/WebMediaPlaybackTargetPicker.mm:
419         * WebView/WebPDFDocumentExtras.h:
420         * WebView/WebPDFDocumentExtras.mm:
421         * WebView/WebPDFRepresentation.h:
422         * WebView/WebPDFRepresentation.mm:
423         * WebView/WebPDFView.h:
424         * WebView/WebPreferences.mm:
425         (cacheModelForMainBundle):
426         (WebPreferencesPrivate::WebPreferencesPrivate):
427         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
428         (-[WebPreferences encodeWithCoder:]):
429         (+[WebPreferences standardPreferences]):
430         (+[WebPreferences initialize]):
431         (-[WebPreferences _valueForKey:]):
432         (-[WebPreferences _setStringValue:forKey:]):
433         (-[WebPreferences _setIntegerValue:forKey:]):
434         (-[WebPreferences _setUnsignedIntValue:forKey:]):
435         (-[WebPreferences _setFloatValue:forKey:]):
436         (-[WebPreferences _setBoolValue:forKey:]):
437         (-[WebPreferences _setLongLongValue:forKey:]):
438         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
439         (-[WebPreferences _postCacheModelChangedNotification]):
440         (-[WebPreferences _postPreferencesChangedNotification]):
441         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
442         (-[WebPreferences setStorageBlockingPolicy:]):
443         * WebView/WebResource.mm:
444         (+[WebResourcePrivate initialize]):
445         * WebView/WebTextCompletionController.h:
446         * WebView/WebTextIterator.mm:
447         (+[WebTextIteratorPrivate initialize]):
448         * WebView/WebView.mm:
449         (shouldEnableLoadDeferring):
450         (shouldRestrictWindowFocus):
451         (shouldRespectPriorityInCSSAttributeSetters):
452         (shouldUseLegacyBackgroundSizeShorthandBehavior):
453         (shouldAllowPictureInPictureMediaPlayback):
454         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
455         (shouldAllowWindowOpenWithoutUserGesture):
456         (shouldConvertInvalidURLsToBlank):
457         (shouldRequireUserGestureToLoadVideo):
458         (-[WebView _commonInitializationWithFrameName:groupName:]):
459         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
460         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
461         (-[WebView _closePluginDatabases]):
462         (-[WebView _closeWithFastTeardown]):
463         (-[WebView _close]):
464         (+[WebView _MIMETypeForFile:]):
465         (-[WebView setShowingInspectorIndication:]):
466         (-[WebView _setFormDelegate:]):
467         (-[WebView _needsPreHTML5ParserQuirks]):
468         (-[WebView _preferencesChangedNotification:]):
469         (-[WebView _preferencesChanged:]):
470         (-[WebView _cacheResourceLoadDelegateImplementations]):
471         (-[WebView _cacheFrameLoadDelegateImplementations]):
472         (-[WebView _policyDelegateForwarder]):
473         (-[WebView _UIDelegateForwarder]):
474         (-[WebView _editingDelegateForwarder]):
475         (-[WebView _updateActiveState]):
476         (-[_WebSafeForwarder forwardInvocation:]):
477         (+[WebView initialize]):
478         (-[WebView _pluginForMIMEType:]):
479         (-[WebView _pluginForExtension:]):
480         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
481         (+[WebView canShowMIMETypeAsHTML:]):
482         (-[WebView _initWithArguments:]):
483         (-[WebView initWithFrame:frameName:groupName:]):
484         (-[WebView dealloc]):
485         (-[WebView close]):
486         (-[WebView viewDidMoveToWindow]):
487         (-[WebView setUIDelegate:]):
488         (-[WebView setResourceLoadDelegate:]):
489         (-[WebView setPolicyDelegate:]):
490         (-[WebView setFrameLoadDelegate:]):
491         (-[WebView goBack]):
492         (-[WebView goForward]):
493         (-[WebView stringByEvaluatingJavaScriptFromString:]):
494         (-[WebView setHostWindow:]):
495         (-[WebView becomeFirstResponder]):
496         (+[WebView _cacheModelChangedNotification:]):
497         (-[WebView _frameViewAtWindowPoint:]):
498         (+[WebView _preflightSpellCheckerNow:]):
499         (+[WebView _preflightSpellChecker]):
500         (-[WebView canGoBack]):
501         (-[WebView canGoForward]):
502         (-[WebView stopLoading:]):
503         (-[WebView reload:]):
504         (-[WebView setMainFrameDocumentReady:]):
505         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
506         (-[WebView setContinuousSpellCheckingEnabled:]):
507         (-[WebView undoManager]):
508         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
509         (-[WebView isAutomaticLinkDetectionEnabled]):
510         (-[WebView isAutomaticDashSubstitutionEnabled]):
511         (-[WebView isAutomaticTextReplacementEnabled]):
512         (-[WebView isAutomaticSpellingCorrectionEnabled]):
513         (+[WebView _setCacheModel:]):
514         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
515         (-[WebView _keyboardUIMode]):
516         (LayerFlushController::flushLayers):
517         (-[WebView _scheduleCompositingLayerFlush]):
518         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
519         (-[WebView fullScreenPlaceholderView]):
520         (WebInstallMemoryPressureHandler):
521         * WebView/WebViewData.h:
522         * WebView/WebViewData.mm:
523         (+[WebViewPrivate initialize]):
524         (-[WebViewPrivate init]):
525         (-[WebViewPrivate dealloc]):
526         * WebView/WebViewInternal.h:
527
528 2018-10-18  Alex Christensen  <achristensen@webkit.org>
529
530         Clean up FrameLoader two-state enums
531         https://bugs.webkit.org/show_bug.cgi?id=190731
532
533         Reviewed by Chris Dumez.
534
535         * WebCoreSupport/WebFrameLoaderClient.h:
536         * WebCoreSupport/WebFrameLoaderClient.mm:
537         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
538
539 2018-10-18  Alex Christensen  <achristensen@webkit.org>
540
541         Unreviewed, rolling out r237137.
542
543         SPI is actually used
544
545         Reverted changeset:
546
547         "Remove unused WebFrame._loadType"
548         https://bugs.webkit.org/show_bug.cgi?id=190583
549         https://trac.webkit.org/changeset/237137
550
551 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
552
553         Enable the datalist element by default on iOS and macOS
554         https://bugs.webkit.org/show_bug.cgi?id=190594
555         <rdar://problem/45281159>
556
557         Reviewed by Ryosuke Niwa and Tim Horton.
558
559         * Configurations/FeatureDefines.xcconfig:
560
561 2018-10-17  Alex Christensen  <achristensen@webkit.org>
562
563         BackForwardClient needs to be able to support UIProcess-only back/forward lists
564         https://bugs.webkit.org/show_bug.cgi?id=190675
565
566         Reviewed by Chris Dumez.
567
568         * History/BackForwardList.h:
569         * History/BackForwardList.mm:
570         (BackForwardList::backItem):
571         (BackForwardList::currentItem):
572         (BackForwardList::forwardItem):
573         (BackForwardList::backListCount const):
574         (BackForwardList::forwardListCount const):
575         (BackForwardList::itemAtIndex):
576         * History/WebBackForwardList.mm:
577         (-[WebBackForwardList backItem]):
578         (-[WebBackForwardList currentItem]):
579         (-[WebBackForwardList forwardItem]):
580         (-[WebBackForwardList itemAtIndex:]):
581
582 2018-10-16  Timothy Hatcher  <timothy@apple.com>
583
584         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
585         https://bugs.webkit.org/show_bug.cgi?id=190526
586         rdar://problem/45230140
587
588         Reviewed by Dean Jackson.
589
590         * WebCoreSupport/WebEditorClient.mm:
591         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
592
593 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
594
595         Implement feature flag and bindings for CSS Painting API
596         https://bugs.webkit.org/show_bug.cgi?id=190237
597
598         Reviewed by Ryosuke Niwa.
599
600         * Configurations/FeatureDefines.xcconfig:
601
602 2018-10-16  Alex Christensen  <achristensen@webkit.org>
603
604         Replace HistoryItem* with HistoryItem& where possible
605         https://bugs.webkit.org/show_bug.cgi?id=190617
606
607         Reviewed by Chris Dumez.
608
609         * History/BackForwardList.h:
610         * History/BackForwardList.mm:
611         (BackForwardList::goToItem):
612         * History/WebBackForwardList.mm:
613         (-[WebBackForwardList goToItem:]):
614         * History/WebHistoryItem.mm:
615         (WKNotifyHistoryItemChanged):
616         * History/WebHistoryItemInternal.h:
617
618 2018-10-16  Alex Christensen  <achristensen@webkit.org>
619
620         Remove unused WebHistoryItem._transientPropertyForKey
621         https://bugs.webkit.org/show_bug.cgi?id=190606
622
623         Reviewed by Chris Dumez.
624
625         * History/WebHistoryItem.mm:
626         * History/WebHistoryItemPrivate.h:
627
628 2018-10-15  Justin Fan  <justin_fan@apple.com>
629
630         Add WebGPU 2018 feature flag and experimental feature flag
631         https://bugs.webkit.org/show_bug.cgi?id=190509
632
633         Reviewed by Dean Jackson.
634
635         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
636         for the 2018 WebGPU prototype.
637
638         * Configurations/FeatureDefines.xcconfig:
639         * WebView/WebPreferenceKeysPrivate.h:
640         * WebView/WebPreferences.mm:
641         (+[WebPreferences initialize]):
642         (-[WebPreferences webGPUEnabled]):
643         (-[WebPreferences setWebGPUEnabled:]):
644         * WebView/WebPreferencesPrivate.h:
645         * WebView/WebView.mm:
646         (-[WebView _preferencesChanged:]):
647
648 2018-10-15  Alex Christensen  <achristensen@webkit.org>
649
650         Fix iOS build after r237157
651
652         * WebView/WebView.mm:
653         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
654
655 2018-10-15  Alex Christensen  <achristensen@webkit.org>
656
657         Modernize BackForwardClient.h
658         https://bugs.webkit.org/show_bug.cgi?id=190610
659
660         Reviewed by Chris Dumez.
661
662         * History/BackForwardList.h:
663         * History/BackForwardList.mm:
664         (BackForwardList::backListCount const):
665         (BackForwardList::forwardListCount const):
666         (BackForwardList::backListCount): Deleted.
667         (BackForwardList::forwardListCount): Deleted.
668         * History/WebBackForwardList.mm:
669         (-[WebBackForwardList init]):
670         * WebCoreSupport/WebFrameLoaderClient.mm:
671         (WebFrameLoaderClient::canCachePage const):
672         * WebView/WebFrameView.mm:
673         (-[WebFrameView keyDown:keyDown:]):
674         * WebView/WebView.mm:
675         (-[WebView _commonInitializationWithFrameName:groupName:]):
676         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
677         (-[WebView _loadBackForwardListFromOtherView:]):
678         (-[WebView initWithCoder:]):
679         (-[WebView encodeWithCoder:]):
680         (-[WebView backForwardList]):
681         (-[WebView setMaintainsBackForwardList:]):
682
683 2018-10-15  Timothy Hatcher  <timothy@apple.com>
684
685         Add support for prefers-color-scheme media query
686         https://bugs.webkit.org/show_bug.cgi?id=190499
687         rdar://problem/45212025
688
689         Reviewed by Dean Jackson.
690
691         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
692
693 2018-10-15  Alex Christensen  <achristensen@webkit.org>
694
695         Remove unused WebView._globalHistoryItem
696         https://bugs.webkit.org/show_bug.cgi?id=190601
697
698         Reviewed by Chris Dumez.
699
700         * WebCoreSupport/WebFrameLoaderClient.h:
701         * WebCoreSupport/WebFrameLoaderClient.mm:
702         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
703         * WebView/WebView.mm:
704         (-[WebView _globalHistoryItem]): Deleted.
705         (-[WebView _setGlobalHistoryItem:]): Deleted.
706         * WebView/WebViewData.h:
707         * WebView/WebViewInternal.h:
708         * WebView/WebViewPrivate.h:
709
710 2018-10-15  Alex Christensen  <achristensen@webkit.org>
711
712         Remove unused parameters from FrameLoaderClient::createFrame
713         https://bugs.webkit.org/show_bug.cgi?id=190587
714
715         Reviewed by Chris Dumez.
716
717         * WebCoreSupport/WebFrameLoaderClient.h:
718         * WebCoreSupport/WebFrameLoaderClient.mm:
719         (WebFrameLoaderClient::createFrame):
720
721 2018-10-15  Alex Christensen  <achristensen@webkit.org>
722
723         Remove unused WebFrame._loadType
724         https://bugs.webkit.org/show_bug.cgi?id=190583
725
726         Reviewed by Chris Dumez.
727
728         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
729
730         * WebView/WebFrame.mm:
731         (toWebFrameLoadType): Deleted.
732         (-[WebFrame _loadType]): Deleted.
733         * WebView/WebFramePrivate.h:
734
735 2018-10-15  Chris Dumez  <cdumez@apple.com>
736
737         Restrict browsing context lookup by name to frames that are related to one another
738         https://bugs.webkit.org/show_bug.cgi?id=190475
739
740         Reviewed by Alex Christensen.
741
742         * WebView/WebFrame.mm:
743         (-[WebFrame findFrameNamed:]):
744
745 2018-10-15  Alex Christensen  <achristensen@webkit.org>
746
747         Remove InjectedBundle processing of back/forward lists
748         https://bugs.webkit.org/show_bug.cgi?id=190459
749
750         Reviewed by Chris Dumez.
751
752         * WebCoreSupport/WebFrameLoaderClient.h:
753         * WebCoreSupport/WebFrameLoaderClient.mm:
754         (WebFrameLoaderClient::shouldGoToHistoryItem const):
755
756 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
757
758         [JSC] Remove Option::useAsyncIterator
759         https://bugs.webkit.org/show_bug.cgi?id=190567
760
761         Reviewed by Saam Barati.
762
763         * Configurations/FeatureDefines.xcconfig:
764
765 2018-10-12  Alex Christensen  <achristensen@webkit.org>
766
767         Allow encoding of small enum classes
768         https://bugs.webkit.org/show_bug.cgi?id=190531
769
770         Reviewed by Tim Horton.
771
772         * WebCoreSupport/WebFrameLoaderClient.mm:
773         (-[WebFramePolicyListener dealloc]):
774
775 2018-10-11  Keith Rollin  <krollin@apple.com>
776
777         CURRENT_ARCH should not be used in Run Script phase.
778         https://bugs.webkit.org/show_bug.cgi?id=190407
779         <rdar://problem/45133556>
780
781         Reviewed by Alexey Proskuryakov.
782
783         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
784         CURRENT_ARCH is not well-defined during this phase (and may even have
785         the value "undefined") since this phase is run just once per build
786         rather than once per supported architecture. Migrate away from
787         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
788         performing an operation for each value, or by picking the first entry
789         in ARCHS and using that as a representative value.
790
791         * Configurations/WebKitLegacy.xcconfig: When generating
792         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
793         macosx platforms.
794
795         * MigrateHeaders.make:
796         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
797         generate one for each architecture in ARCHS.
798
799 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
800
801         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
802         https://bugs.webkit.org/show_bug.cgi?id=190429
803
804         Reviewed by Saam Barati.
805
806         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
807
808         * WebView/WebPDFRepresentation.mm:
809         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
810
811 2018-10-08  Justin Fan  <justin_fan@apple.com>
812
813         WebGPU: Rename old WebGPU prototype to WebMetal
814         https://bugs.webkit.org/show_bug.cgi?id=190325
815         <rdar://problem/44990443>
816
817         Reviewed by Dean Jackson.
818
819         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
820
821         * Configurations/FeatureDefines.xcconfig:
822         * WebView/WebPreferenceKeysPrivate.h:
823         * WebView/WebPreferences.mm:
824         (+[WebPreferences initialize]):
825         (-[WebPreferences webMetalEnabled]):
826         (-[WebPreferences setWebMetalEnabled:]):
827         (-[WebPreferences webGPUEnabled]): Deleted.
828         (-[WebPreferences setWebGPUEnabled:]): Deleted.
829         * WebView/WebPreferencesPrivate.h:
830         * WebView/WebView.mm:
831         (-[WebView _preferencesChanged:]):
832
833 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
834
835         Make <input type=color> a runtime enabled (on-by-default) feature
836         https://bugs.webkit.org/show_bug.cgi?id=189162
837
838         Reviewed by Wenson Hsieh and Tim Horton.
839
840         * Configurations/FeatureDefines.xcconfig:
841
842 2018-10-07  Dan Bernstein  <mitz@apple.com>
843
844         Fixed building with the latest macOS SDK
845
846         * Plugins/WebNetscapePluginPackage.mm:
847         (-[WebNetscapePluginPackage openResourceFile]):
848         (-[WebNetscapePluginPackage closeResourceFile:]):
849
850 2018-10-04  Dan Bernstein  <mitz@apple.com>
851
852         More Carbon build-fixing.
853
854         * Carbon/CarbonWindowAdapter.mm:
855         (-[CarbonWindowAdapter _destroyRealWindow:]):
856         (-[CarbonWindowAdapter _growBoxRect]):
857
858 2018-10-04  Dan Bernstein  <mitz@apple.com>
859
860         Retried to fix 32-bit macOS builds after r236846.
861
862         * WebView/WebHTMLView.mm:
863         (-[WebHTMLView setMarkedText:selectedRange:]):
864
865 2018-10-04  Dan Bernstein  <mitz@apple.com>
866
867         Retried to fix 32-bit macOS builds after r236846.
868
869         * Carbon/HIWebView.mm:
870         (ActiveStateChanged):
871
872 2018-10-04  Dan Bernstein  <mitz@apple.com>
873
874         Tried to fix 32-bit macOS builds after r236846.
875
876         * Carbon/HIWebView.mm:
877         (_NSSelectorForHICommand):
878
879 2018-10-04  Dan Bernstein  <mitz@apple.com>
880
881         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
882         https://bugs.webkit.org/show_bug.cgi?id=190250
883
884         Reviewed by Andy Estes.
885
886         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
887           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
888           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
889           an earlier line set it to YES.
890
891         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
892         changes below.
893
894         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
895           provides some missing method declarations.
896
897         * Misc/WebDownload.mm:
898         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
899           a deprecated method.
900
901         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
902
903         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
904           other code in the file uses a method from it.
905
906         * Plugins/WebBaseNetscapePluginView.mm:
907         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
908           a deprecated method.
909
910         * Plugins/WebPluginController.mm:
911         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
912           around use of a selector that may be present in some WebKit client.
913
914         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
915           method declarations.
916
917         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
918           from here.
919
920         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
921           missing method declarations.
922
923         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
924           from here.
925
926         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
927           call from here.
928         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
929           an obsolete delegate method for binary compatibility.
930         (pluginView): Ditto.
931
932         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
933           call from here.
934
935         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
936           WebDeviceOrientationProviderMock protocol.
937
938         * WebView/WebDeviceOrientationProviderMock.mm:
939         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
940           main @implementation.
941
942         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
943           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
944
945         * WebView/WebDynamicScrollBarsView.mm:
946         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
947           of a deprecated method.
948
949         * WebView/WebHTMLView.mm:
950         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
951           selector warning around action methods that are not declared anywhere in WebKit.
952
953         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
954           about implementing this deprecated method.
955         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
956         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
957         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
958         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
959         (-[WebHTMLView characterIndexForPoint:]): Ditto.
960         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
961         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
962         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
963         (-[WebHTMLView doCommandBySelector:]): Ditto.
964         (-[WebHTMLView insertText:]): Ditto.
965
966         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
967
968         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
969
970         * WebView/WebPDFView.h: Removed previewView ivar.
971
972         * WebView/WebPDFView.mm:
973           Removed declaration of FileInternal category and merged its implementation with the main
974           implementation.
975         (-[WebPDFView dealloc]): Removed previewView ivar.
976         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
977           exist in macOS versions we support.
978         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
979         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
980           action methods internal to PDFKit.
981         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
982         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
983
984         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
985           call on macOS, even though in r86988 we started calling different methods on iOS.
986
987         * WebView/WebView.mm:
988         - Imported headers that declare delegate methods that we call.
989         - Removed declaration of WebFileInternal category and merged its implementation with the
990           main implementation.
991         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
992           category, which made them impossible to call from the main implementation. Moved those
993           into the main implementation. One of those had to be declared in a class extension,
994           because it is called from a method implemented in the WebPrivate category, and that
995           category’s implementation appears first in the file.
996
997         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
998           around use of obsolete delegate method for binary compatibility.
999
1000         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
1001
1002 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
1003
1004         Runtime flag and IDL for MediaRecorder
1005         https://bugs.webkit.org/show_bug.cgi?id=190018
1006
1007         Reviewed by Youenn Fablet and Chris Dumez.
1008
1009         * WebView/WebPreferenceKeysPrivate.h:
1010         * WebView/WebPreferences.mm:
1011         (+[WebPreferences initialize]):
1012         (-[WebPreferences mediaRecorderEnabled]):
1013         (-[WebPreferences setMediaRecorderEnabled:]):
1014         * WebView/WebPreferencesPrivate.h:
1015         * WebView/WebView.mm:
1016         (-[WebView _preferencesChanged:]):
1017
1018 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1019
1020         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
1021         https://bugs.webkit.org/show_bug.cgi?id=190238
1022
1023         Reviewed by Antti Koivisto.
1024
1025         Enabled the feature by default.
1026
1027         * WebView/WebPreferences.mm:
1028         (+[WebPreferences initialize]):
1029
1030 2018-10-01  Dean Jackson  <dino@apple.com>
1031
1032         [macOS] Switching to discrete GPU should be done in the UI process
1033         https://bugs.webkit.org/show_bug.cgi?id=189361
1034         <rdar://problem/43949622>
1035
1036         Reviewed by Simon Fraser.
1037
1038         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
1039         not support swapping to the discrete GPU in this configuration.
1040
1041         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
1042         (WebKit::WebSwitchingGPUClient::singleton):
1043         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
1044         * WebView/WebView.mm:
1045         (-[WebView _commonInitializationWithFrameName:groupName:]):
1046
1047 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1048
1049         Remove ParsedURLString
1050         https://bugs.webkit.org/show_bug.cgi?id=190154
1051
1052         Reviewed by Chris Dumez.
1053
1054         * WebView/WebScriptDebugger.mm:
1055         (toNSURL):
1056
1057 2018-10-01  Dean Jackson  <dino@apple.com>
1058
1059         Remove CSS Animation Triggers
1060         https://bugs.webkit.org/show_bug.cgi?id=190175
1061         <rdar://problem/44925626>
1062
1063         Reviewed by Simon Fraser.
1064
1065         * Configurations/FeatureDefines.xcconfig:
1066
1067 2018-10-02  Commit Queue  <commit-queue@webkit.org>
1068
1069         Unreviewed, rolling out r236624 and r236671.
1070         https://bugs.webkit.org/show_bug.cgi?id=190207
1071
1072         The change in r236624 introduced crashes on the bots
1073         (Requested by ryanhaddad on #webkit).
1074
1075         Reverted changesets:
1076
1077         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1078         https://bugs.webkit.org/show_bug.cgi?id=188747
1079         https://trac.webkit.org/changeset/236624
1080
1081         "Unify implementation in VideoFullscreenInterfaceAVKit"
1082         https://bugs.webkit.org/show_bug.cgi?id=190091
1083         https://trac.webkit.org/changeset/236671
1084
1085 2018-10-01  Alex Christensen  <achristensen@webkit.org>
1086
1087         URL should not use TextEncoding internally
1088         https://bugs.webkit.org/show_bug.cgi?id=190111
1089
1090         Reviewed by Andy Estes.
1091
1092         * Misc/WebNSURLExtras.mm:
1093
1094 2018-09-28  Jer Noble  <jer.noble@apple.com>
1095
1096         Refactoring: eliminate raw pointer usage in Fullscreen code
1097         https://bugs.webkit.org/show_bug.cgi?id=188747
1098         <rdar://problem/43541164>
1099
1100         Reviewed by Alex Christensen.
1101
1102         PlaybackSessionInterface no longer has an invalidate() method.
1103
1104         * WebView/WebView.mm:
1105         (-[WebView _clearPlaybackControlsManager]):
1106
1107 2018-09-28  Chris Dumez  <cdumez@apple.com>
1108
1109         Drop support for cross-origin-window-policy header
1110         https://bugs.webkit.org/show_bug.cgi?id=190081
1111
1112         Reviewed by Ryosuke Niwa.
1113
1114         * WebView/WebPreferenceKeysPrivate.h:
1115         * WebView/WebPreferences.mm:
1116         (+[WebPreferences initialize]):
1117         * WebView/WebPreferencesPrivate.h:
1118         * WebView/WebView.mm:
1119         (-[WebView _preferencesChanged:]):
1120
1121 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
1122
1123         Rename createMarkup to serializePreservingVisualAppearance
1124         https://bugs.webkit.org/show_bug.cgi?id=190086
1125
1126         Reviewed by Wenson Hsieh.
1127
1128         * DOM/WebDOMOperations.mm:
1129         (-[DOMRange markupString]):
1130
1131 2018-09-28  Commit Queue  <commit-queue@webkit.org>
1132
1133         Unreviewed, rolling out r236605.
1134         https://bugs.webkit.org/show_bug.cgi?id=190087
1135
1136         caused three API test timeouts (Requested by jernoble on
1137         #webkit).
1138
1139         Reverted changeset:
1140
1141         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1142         https://bugs.webkit.org/show_bug.cgi?id=188747
1143         https://trac.webkit.org/changeset/236605
1144
1145 2018-09-28  Jer Noble  <jer.noble@apple.com>
1146
1147         Refactoring: eliminate raw pointer usage in Fullscreen code
1148         https://bugs.webkit.org/show_bug.cgi?id=188747
1149         <rdar://problem/43541164>
1150
1151         Reviewed by Alex Christensen.
1152
1153         PlaybackSessionInterface no longer has an invalidate() method.
1154
1155         * WebView/WebView.mm:
1156         (-[WebView _clearPlaybackControlsManager]):
1157
1158 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1159
1160         Use enum class in createMarkup arguments
1161         https://bugs.webkit.org/show_bug.cgi?id=190028
1162
1163         Reviewed by Wenson Hsieh.
1164
1165         * DOM/WebDOMOperations.mm:
1166         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
1167         (-[DOMRange markupString]): Ditto.
1168
1169 2018-09-27  Antoine Quint  <graouts@apple.com>
1170
1171         [Web Animations] Turn Web Animations with CSS integration on
1172         https://bugs.webkit.org/show_bug.cgi?id=184819
1173         <rdar://problem/39597337>
1174
1175         Reviewed by Dean Jackson.
1176
1177         * WebView/WebPreferences.mm:
1178         (+[WebPreferences initialize]):
1179
1180 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1181
1182         Selection should work across shadow boundary when initiated by a mouse drag
1183         https://bugs.webkit.org/show_bug.cgi?id=151380
1184         <rdar://problem/24363872>
1185
1186         Reviewed by Wenson Hsieh.
1187
1188         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
1189
1190         * WebView/WebPreferenceKeysPrivate.h:
1191         * WebView/WebPreferences.mm:
1192         (+[WebPreferences initialize]):
1193         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
1194         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
1195         * WebView/WebPreferencesPrivate.h:
1196         * WebView/WebView.mm:
1197         (-[WebView _preferencesChanged:]):
1198
1199 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1200
1201         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
1202         https://bugs.webkit.org/show_bug.cgi?id=189918
1203         Work towards <rdar://problem/44648705>
1204
1205         Reviewed by Tim Horton.
1206
1207         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
1208
1209         * WebView/WebHTMLView.mm:
1210         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
1211         (-[WebHTMLView _updateFontPanel]):
1212         * WebView/WebView.mm:
1213         (-[WebView typingAttributes]):
1214
1215 2018-09-17  Darin Adler  <darin@apple.com>
1216
1217         Use OpaqueJSString rather than JSRetainPtr inside WebKit
1218         https://bugs.webkit.org/show_bug.cgi?id=189652
1219
1220         Reviewed by Saam Barati.
1221
1222         * WebView/WebPDFRepresentation.mm:
1223         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
1224
1225 2018-09-14  Jer Noble  <jer.noble@apple.com>
1226
1227         Turn SourceBufferChangeTypeEnabled on by default
1228         https://bugs.webkit.org/show_bug.cgi?id=189527
1229
1230         Reviewed by Eric Carlson.
1231
1232         * WebView/WebPreferences.mm:
1233         (+[WebPreferences initialize]):
1234
1235 2018-09-12  Alex Christensen  <achristensen@webkit.org>
1236
1237         Fix an internal build after r235935
1238         https://bugs.webkit.org/show_bug.cgi?id=188996
1239
1240         * Carbon/HIWebView.mm:
1241         (Draw):
1242         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
1243
1244 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
1245
1246         Add IGNORE_WARNING_.* macros
1247         https://bugs.webkit.org/show_bug.cgi?id=188996
1248
1249         Reviewed by Michael Catanzaro.
1250
1251         * Carbon/CarbonUtils.m:
1252         (PoolCleaner):
1253         * Carbon/CarbonWindowAdapter.mm:
1254         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1255         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1256         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1257         (-[CarbonWindowAdapter _termWindowIfOwner]):
1258         (-[CarbonWindowAdapter _windowMovedToRect:]):
1259         (-[CarbonWindowAdapter setContentView:]):
1260         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1261         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1262         * Carbon/CarbonWindowFrame.m:
1263         (-[CarbonWindowFrame title]):
1264         * Carbon/HIViewAdapter.m:
1265         (+[HIViewAdapter getHIViewForNSView:]):
1266         * Carbon/HIWebView.mm:
1267         (overrideCGContext):
1268         (restoreCGContext):
1269         (Draw):
1270         * DOM/DOM.mm:
1271         * History/WebHistory.mm:
1272         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1273         * History/WebHistoryItem.mm:
1274         (-[WebHistoryItem icon]):
1275         * Misc/WebKitNSStringExtras.mm:
1276         (-[NSString _web_drawAtPoint:font:textColor:]):
1277         * Misc/WebNSImageExtras.m:
1278         (-[NSImage _web_scaleToMaxSize:]):
1279         (-[NSImage _web_dissolveToFraction:]):
1280         * Misc/WebNSPasteboardExtras.mm:
1281         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1282         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1283         * Panels/WebAuthenticationPanel.m:
1284         (-[WebAuthenticationPanel loadNib]):
1285         * Plugins/Hosted/NetscapePluginHostManager.mm:
1286         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1287         (WebKit::NetscapePluginHostManager::didCreateWindow):
1288         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1289         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
1290         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
1291         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
1292         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1293         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
1294         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1295         (-[WebHostedNetscapePluginView drawRect:]):
1296         * Plugins/Hosted/WebTextInputWindowController.m:
1297         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1298         * Plugins/WebBaseNetscapePluginView.mm:
1299         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
1300         * Plugins/WebNetscapePluginPackage.mm:
1301         (-[WebNetscapePluginPackage _tryLoad]):
1302         * Plugins/WebNetscapePluginView.mm:
1303         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1304         (-[WebNetscapePluginView sendDrawRectEvent:]):
1305         (-[WebNetscapePluginView drawRect:]):
1306         * Plugins/WebPluginController.mm:
1307         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
1308         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
1309         * WebCoreSupport/PopupMenuMac.mm:
1310         (PopupMenuMac::populate):
1311         * WebCoreSupport/WebAlternativeTextClient.h:
1312         * WebCoreSupport/WebDragClient.mm:
1313         (WebDragClient::startDrag):
1314         * WebCoreSupport/WebFrameLoaderClient.mm:
1315         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1316         (webGetNSImage):
1317         * WebInspector/WebNodeHighlight.mm:
1318         * WebInspector/WebNodeHighlightView.mm:
1319         (-[WebNodeHighlightView drawRect:]):
1320         * WebView/WebClipView.mm:
1321         (-[WebClipView initWithFrame:]):
1322         * WebView/WebFrame.mm:
1323         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1324         (-[WebFrame _drawRect:contentsOnly:]):
1325         (-[WebFrame accessibilityRoot]):
1326         * WebView/WebFullScreenController.mm:
1327         (-[WebFullScreenController enterFullScreen:]):
1328         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1329         (-[WebFullScreenController exitFullScreen]):
1330         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1331         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1332         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1333         * WebView/WebHTMLView.mm:
1334         (-[NSWindow _web_borderView]):
1335         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
1336         (-[WebHTMLView _setAsideSubviews]):
1337         (-[WebHTMLView _autoscroll]):
1338         (-[WebHTMLView drawRect:]):
1339         (-[WebHTMLView mouseDown:]):
1340         (-[WebHTMLView mouseDragged:]):
1341         (-[WebHTMLView mouseUp:]):
1342         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
1343         (-[WebHTMLView knowsPageRange:]):
1344         (-[WebHTMLView accessibilityHitTest:]):
1345         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1346         (-[WebHTMLView _colorAsString:]):
1347         (-[WebHTMLView copyFont:]):
1348         (-[WebHTMLView _executeSavedKeypressCommands]):
1349         (-[WebHTMLView attachRootLayer:]):
1350         (-[WebHTMLView textStorage]):
1351         (-[WebHTMLView _updateSelectionForInputManager]):
1352         * WebView/WebPDFView.mm:
1353         (_applicationInfoForMIMEType):
1354         (-[WebPDFView centerSelectionInVisibleArea:]):
1355         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1356         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1357         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1358         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
1359         * WebView/WebTextCompletionController.mm:
1360         (-[WebTextCompletionController _buildUI]):
1361         (-[WebTextCompletionController _placePopupWindow:]):
1362         * WebView/WebVideoFullscreenController.mm:
1363         * WebView/WebVideoFullscreenHUDWindowController.mm:
1364         (createMediaUIBackgroundView):
1365         * WebView/WebView.mm:
1366         (-[WebTextListTouchBarViewController initWithWebView:]):
1367         (-[WebView _dispatchTileDidDraw:]):
1368         (-[WebView encodeWithCoder:]):
1369         (-[WebView mainFrameIcon]):
1370         (LayerFlushController::flushLayers):
1371         * WebView/WebWindowAnimation.mm:
1372         (setScaledFrameForWindow):
1373
1374 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1375
1376         Remove unused needsDestruction class variables from HashTraits
1377         https://bugs.webkit.org/show_bug.cgi?id=189490
1378
1379         Reviewed by Daniel Bates.
1380
1381         * History/BinaryPropertyList.cpp: Removed needsDestruction.
1382
1383 2018-09-07  Frederic Wang  <fwang@igalia.com>
1384
1385         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
1386         https://bugs.webkit.org/show_bug.cgi?id=182230
1387
1388         Reviewed by Simon Fraser.
1389
1390         * DOM/DOMDocument.mm:
1391         (-[DOMDocument scrollingElement]): Use the new name.
1392
1393 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1394
1395         Refactor WebCore::EditAction to be an 8-bit enum class
1396         https://bugs.webkit.org/show_bug.cgi?id=189383
1397
1398         Reviewed by Dan Bernstein.
1399
1400         * WebCoreSupport/WebEditorClient.mm:
1401         (undoNameForEditAction):
1402         * WebView/WebHTMLView.mm:
1403         (-[WebHTMLView pasteFont:]):
1404         (-[WebHTMLView changeFont:]):
1405         (-[WebHTMLView changeAttributes:]):
1406         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
1407         (-[WebHTMLView changeColor:]):
1408         * WebView/WebView.mm:
1409         (-[WebView setTypingStyle:]):
1410
1411 2018-09-06  Frederic Wang  <fwang@igalia.com>
1412
1413         Group options of scrollRectToVisible into a struct
1414         https://bugs.webkit.org/show_bug.cgi?id=189352
1415
1416         Reviewed by Simon Fraser.
1417
1418         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
1419         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
1420         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
1421
1422 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1423
1424         [macOS] Cannot change font size at selection until font panel is shown
1425         https://bugs.webkit.org/show_bug.cgi?id=189295
1426         <rdar://problem/35593389>
1427
1428         Reviewed by Ryosuke Niwa.
1429
1430         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
1431         WebCore ChangeLog for more details.
1432
1433         * WebView/WebHTMLView.mm:
1434         (-[WebHTMLView changeFont:]):
1435         (-[WebHTMLView changeAttributes:]):
1436         (-[WebHTMLView _originalFontA]): Deleted.
1437         (-[WebHTMLView _originalFontB]): Deleted.
1438         (fontNameForDescription): Deleted.
1439         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
1440         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
1441         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
1442
1443 2018-09-05  Jer Noble  <jer.noble@apple.com>
1444
1445         Add MediaCapabilities as an Experimental Feature
1446         https://bugs.webkit.org/show_bug.cgi?id=189209
1447
1448         Reviewed by Eric Carlson.
1449
1450         RuntimeEnabledFeature -> Setting.
1451
1452         * WebView/WebView.mm:
1453         (-[WebView _preferencesChanged:]):
1454
1455 2018-09-04  Frederic Wang  <fwang@igalia.com>
1456
1457         Add basic support for ScrollIntoViewOptions
1458         https://bugs.webkit.org/show_bug.cgi?id=189258
1459
1460         Reviewed by Simon Fraser.
1461
1462         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
1463         header so that this file can build despite the new scrollIntoView function.
1464
1465 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1466
1467         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
1468         https://bugs.webkit.org/show_bug.cgi?id=188890
1469         <rdar://problem/43648605>
1470
1471         Reviewed by Tim Horton.
1472
1473         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
1474         more detail.
1475
1476         * WebCoreSupport/WebPlatformStrategies.h:
1477         * WebCoreSupport/WebPlatformStrategies.mm:
1478         (WebPlatformStrategies::allStringsForType):
1479
1480 2018-09-01  Darin Adler  <darin@apple.com>
1481
1482         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
1483         https://bugs.webkit.org/show_bug.cgi?id=189072
1484         Reviewed by Dan Bernstein.
1485
1486         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
1487         and declarations for NSURLDownload init methods.
1488
1489         * Misc/WebDownloadInternal.h: Removed.
1490
1491         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
1492         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
1493         "-Wdeprecated-declarations" because the method used here is deprecated.
1494
1495         * WebView/WebView.mm:
1496         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
1497         used here is deprecated.
1498
1499 2018-08-31  Chris Dumez  <cdumez@apple.com>
1500
1501         Assertion hit in ~CompletionHandler() from ~WebFrame()
1502         https://bugs.webkit.org/show_bug.cgi?id=189199
1503         <rdar://problem/42657233>
1504
1505         Reviewed by Youenn Fablet.
1506
1507         * WebCoreSupport/WebFrameLoaderClient.h:
1508         * WebCoreSupport/WebFrameLoaderClient.mm:
1509         (WebFrameLoaderClient::dispatchWillSubmitForm):
1510
1511 2018-08-31  Antti Koivisto  <antti@apple.com>
1512
1513         Replace OptionSet |= and -= operators with add() and remove() functions
1514         https://bugs.webkit.org/show_bug.cgi?id=189169
1515
1516         Reviewed by Anders Carlsson.
1517
1518         * WebView/WebFrame.mm:
1519         (-[WebFrame _drawRect:contentsOnly:]):
1520         * WebView/WebView.mm:
1521         (coreOptions):
1522
1523 2018-08-31  Frederic Wang  <fwang@igalia.com>
1524
1525         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1526         https://bugs.webkit.org/show_bug.cgi?id=182053
1527
1528         Reviewed by Simon Fraser.
1529
1530         Add developer flag to use standard behavior for scrolling* attributes.
1531
1532         * WebView/WebPreferenceKeysPrivate.h:
1533         * WebView/WebPreferences.mm:
1534         (+[WebPreferences initialize]):
1535         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
1536         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
1537         * WebView/WebPreferencesPrivate.h:
1538         * WebView/WebView.mm:
1539         (-[WebView _preferencesChanged:]):
1540
1541 2018-08-29  Olivia Barnett  <obarnett@apple.com>
1542
1543         Implement the Web Share API
1544         https://bugs.webkit.org/show_bug.cgi?id=171100
1545         <rdar://problem/31751734>
1546
1547         Reviewed by Tim Horton.
1548
1549         * WebCoreSupport/WebChromeClient.h:
1550         * WebCoreSupport/WebChromeClient.mm:
1551         (WebChromeClient::showShareSheet):
1552         Empty declaration of showShareSheet.
1553
1554 2018-08-29  Youenn Fablet  <youenn@apple.com>
1555
1556         Remove WebRTC legacy API implementation
1557         https://bugs.webkit.org/show_bug.cgi?id=189040
1558
1559         Reviewed by Eric Carlson.
1560
1561         * WebView/WebPreferenceKeysPrivate.h:
1562         * WebView/WebPreferences.mm:
1563         (+[WebPreferences initialize]):
1564         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
1565         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
1566         * WebView/WebPreferencesPrivate.h:
1567         * WebView/WebView.mm:
1568         (-[WebView _preferencesChanged:]):
1569
1570 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1571
1572         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
1573         https://bugs.webkit.org/show_bug.cgi?id=189054
1574
1575         Reviewed by Andy Estes.
1576
1577         Remove the pasteboard type argument from readURLFromPasteboard.
1578
1579         * WebCoreSupport/WebPlatformStrategies.h:
1580         * WebCoreSupport/WebPlatformStrategies.mm:
1581         (WebPlatformStrategies::readURLFromPasteboard):
1582
1583 2018-08-27  Keith Rollin  <krollin@apple.com>
1584
1585         Unreviewed build fix -- disable LTO for production builds
1586
1587         * Configurations/Base.xcconfig:
1588
1589 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
1590
1591         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
1592         https://bugs.webkit.org/show_bug.cgi?id=188931
1593
1594         Reviewed by Wenson Hsieh.
1595
1596         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
1597
1598 2018-08-27  Keith Rollin  <krollin@apple.com>
1599
1600         Build system support for LTO
1601         https://bugs.webkit.org/show_bug.cgi?id=187785
1602         <rdar://problem/42353132>
1603
1604         Reviewed by Dan Bernstein.
1605
1606         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
1607         LTO.
1608
1609         * Configurations/Base.xcconfig:
1610         * Configurations/DebugRelease.xcconfig:
1611
1612 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
1613
1614         Pass in IsComposed flag to Event constructors
1615         https://bugs.webkit.org/show_bug.cgi?id=188720
1616         <rdar://problem/43580387>
1617
1618         Reviewed by Simon Fraser.
1619
1620         * WebView/WebPDFView.mm:
1621         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
1622         whether it's simulated or not.
1623
1624 2018-08-23  Mark Lam  <mark.lam@apple.com>
1625
1626         Move vmEntryGlobalObject() to VM from CallFrame.
1627         https://bugs.webkit.org/show_bug.cgi?id=188900
1628         <rdar://problem/43655753>
1629
1630         Reviewed by Michael Saboff.
1631
1632         * WebView/WebScriptDebugger.mm:
1633         (WebScriptDebugger::sourceParsed):
1634
1635 2018-08-23  Andy Estes  <aestes@apple.com>
1636
1637         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
1638         https://bugs.webkit.org/show_bug.cgi?id=188829
1639
1640         Reviewed by Tim Horton.
1641
1642         * Configurations/FeatureDefines.xcconfig:
1643
1644 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
1645
1646         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
1647         https://bugs.webkit.org/show_bug.cgi?id=188777
1648
1649         Reviewed by Simon Fraser.
1650
1651         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
1652         being "true" before the code change.
1653
1654         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
1655
1656         * WebView/WebPDFView.mm:
1657         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1658
1659 2018-08-21  Daniel Bates  <dabates@apple.com>
1660
1661         Replace TextCheckingTypeMask with OptionSet
1662         https://bugs.webkit.org/show_bug.cgi?id=188678
1663
1664         Reviewed by Antti Koivisto.
1665
1666         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
1667         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
1668         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
1669         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
1670
1671         * WebCoreSupport/WebEditorClient.h:
1672         * WebCoreSupport/WebEditorClient.mm:
1673         (WebEditorClient::checkTextOfParagraph):
1674         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
1675         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
1676         left as this is more readable and unncessary now that modern compilers like Clang have
1677         diagnostics to catch accidental assignments when equality was intended.
1678         (WebEditorClient::didCheckSucceed):
1679         * WebView/WebView.mm:
1680         (coreTextCheckingType):
1681         (textCheckingResultFromNSTextCheckingResult):
1682
1683 2018-08-21  Daniel Bates  <dabates@apple.com>
1684
1685         [iOS][WK1] Support toggling continuous spell checking from tests
1686         https://bugs.webkit.org/show_bug.cgi?id=188763
1687
1688         Reviewed by Simon Fraser.
1689
1690         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
1691         spell checking from tests in iOS WebKit Legacy.
1692
1693         * WebCoreSupport/WebEditorClient.h:
1694         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
1695         * WebCoreSupport/WebEditorClient.mm:
1696         * WebView/WebView.h:
1697         * WebView/WebView.mm:
1698         (-[WebView toggleContinuousSpellChecking:]):
1699         (-[WebView toggleSmartInsertDelete:]):
1700
1701 2018-08-17  Alex Christensen  <achristensen@webkit.org>
1702
1703         Add some plumbing for safe browsing
1704         https://bugs.webkit.org/show_bug.cgi?id=188709
1705
1706         Reviewed by Tim Horton.
1707
1708         * WebCoreSupport/WebFrameLoaderClient.h:
1709         * WebCoreSupport/WebFrameLoaderClient.mm:
1710         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1711
1712 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
1713
1714         Replace canBubble and cancelable booleans in Event by enum classes
1715         https://bugs.webkit.org/show_bug.cgi?id=188692
1716
1717         Reviewed by Alex Christensen.
1718
1719         * WebView/WebPDFView.mm:
1720         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1721         * WebView/WebView.mm:
1722         (-[WebView _dispatchUnloadEvent]):
1723
1724 2018-08-16  Jer Noble  <jer.noble@apple.com>
1725
1726         Add Experimental Feature support for SourceBuffer.changeType()
1727         https://bugs.webkit.org/show_bug.cgi?id=188626
1728         <rdar://problem/43356021>
1729
1730         Reviewed by Eric Carlson.
1731
1732         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
1733
1734         * WebView/WebPreferenceKeysPrivate.h:
1735         * WebView/WebPreferences.mm:
1736         (+[WebPreferences initialize]):
1737         (-[WebPreferences sourceBufferChangeTypeEnabled]):
1738         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
1739         * WebView/WebPreferencesPrivate.h:
1740         * WebView/WebView.mm:
1741         (-[WebView _preferencesChanged:]):
1742
1743 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
1744
1745         Support drag-and-drop for input[type=color]
1746         https://bugs.webkit.org/show_bug.cgi?id=188464
1747
1748         Reviewed by Wenson Hsieh.
1749
1750         * WebCoreSupport/WebPlatformStrategies.h:
1751         * WebCoreSupport/WebPlatformStrategies.mm:
1752         (WebPlatformStrategies::setColor):
1753
1754 2018-08-15  Tim Horton  <timothy_horton@apple.com>
1755
1756         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
1757         https://bugs.webkit.org/show_bug.cgi?id=188569
1758         <rdar://problem/34201095>
1759
1760         Reviewed by Megan Gardner.
1761
1762         * WebView/WebImmediateActionController.mm:
1763         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1764         Speculative fix; the crashes indicate font is null, but we just checked it,
1765         so it must be getting made null by convertFont:toSize:. Check again!
1766
1767 2018-08-13  Alex Christensen  <achristensen@webkit.org>
1768
1769         Use a 1-byte enum class for TextDirection
1770         https://bugs.webkit.org/show_bug.cgi?id=188350
1771
1772         Reviewed by Simon Fraser.
1773
1774         * WebCoreSupport/PopupMenuMac.mm:
1775         (PopupMenuMac::populate):
1776         (PopupMenuMac::show):
1777         * WebCoreSupport/WebFrameLoaderClient.mm:
1778         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1779         * WebView/WebFrame.mm:
1780         (-[WebFrame _dispatchDidReceiveTitle:]):
1781
1782 2018-08-09  Ali Juma  <ajuma@chromium.org>
1783
1784         Import WPTs for IntersectionObserver
1785         https://bugs.webkit.org/show_bug.cgi?id=188416
1786
1787         Reviewed by Simon Fraser.
1788
1789         * WebView/WebPreferencesPrivate.h:
1790
1791 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
1792
1793         Follow-up build fix for r234685
1794         https://bugs.webkit.org/show_bug.cgi?id=188245
1795
1796         Unreviewed build fix.
1797
1798         * WebCoreSupport/WebSecurityOriginPrivate.h:
1799
1800 2018-08-05  Darin Adler  <darin@apple.com>
1801
1802         [Cocoa] More tweaks and refactoring to prepare for ARC
1803         https://bugs.webkit.org/show_bug.cgi?id=188245
1804
1805         Reviewed by Dan Bernstein.
1806
1807         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
1808
1809         * Carbon/CarbonWindowFrame.m:
1810         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
1811
1812         * DOM/DOM.mm:
1813         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
1814         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
1815         garbage collection so this method isn't useful.
1816
1817         * DOM/DOMXPath.mm:
1818         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
1819         Objective-C garbage collection so this method isn't useful.
1820
1821         * History/WebHistory.mm:
1822         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
1823
1824         * Misc/WebElementDictionary.mm:
1825         (addLookupKey): Use a bridging cast.
1826         (cacheValueForKey): Ditto.
1827         (-[WebElementDictionary _fillCache]): Ditto.
1828         (-[WebElementDictionary objectForKey:]): Ditto.
1829
1830         * Misc/WebKitNSStringExtras.mm:
1831         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
1832         (-[NSString _web_widthWithFont:]): Ditto.
1833         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
1834
1835         * Misc/WebLocalizableStrings.mm:
1836         (WebLocalizedString): Use a bridging cast.
1837
1838         * Misc/WebNSDataExtras.mm:
1839         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
1840         and use CFBridgingRelease instead of calling autorelease directly.
1841         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
1842         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
1843         on the amount of explicit release and autorelease.
1844
1845         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
1846         * Misc/WebNSDictionaryExtras.m:
1847         (-[NSDictionary _webkit_intForKey:]): Deleted.
1848         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
1849         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
1850         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
1851         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
1852         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
1853         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
1854
1855         * Misc/WebStringTruncator.mm:
1856         (fontFromNSFont): Use a bridging cast.
1857
1858         * Plugins/Hosted/NetscapePluginHostManager.mm:
1859         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
1860
1861         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1862         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
1863         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
1864         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
1865         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
1866         * Plugins/Hosted/ProxyInstance.mm:
1867         (WebKit::ProxyInstance::getPropertyNames): Ditto.
1868         * Plugins/WebBasePluginPackage.mm:
1869         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
1870         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1871         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
1872         * Plugins/WebNetscapePluginPackage.mm:
1873         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
1874
1875         * Plugins/WebNetscapePluginView.mm:
1876         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
1877         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
1878         (-[WebNetscapePluginView status:]): Use a bridging cast.
1879         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
1880
1881         * Plugins/WebPluginController.mm:
1882         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
1883
1884         * Plugins/WebPluginDatabase.mm:
1885         (checkCandidate): Use explicit __strong for out argument types.
1886
1887         * Plugins/npapi.mm:
1888         (pluginViewForInstance): Use a bridging cast.
1889
1890         * Storage/WebDatabaseManager.mm:
1891         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
1892         explicit NSNumber and NSDictionary calls.
1893
1894         * WebCoreSupport/WebContextMenuClient.mm:
1895         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
1896
1897         * WebCoreSupport/WebEditorClient.mm:
1898         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
1899         (WebEditorClient::handleInputMethodKeydown): Ditto.
1900
1901         * WebCoreSupport/WebFrameNetworkingContext.mm:
1902         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
1903
1904         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
1905         as a struct rather than an Objective-C class, since that's how it's defined.
1906
1907         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
1908
1909         * WebView/WebFullScreenController.mm:
1910         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
1911         * WebView/WebHTMLView.mm:
1912         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1913         Ditto.
1914         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1915
1916         * WebView/WebImmediateActionController.mm:
1917         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
1918         go down to the document and then back to the frame.
1919         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
1920         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
1921         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
1922
1923         * WebView/WebJSPDFDoc.mm:
1924         (jsPDFDocInitialize): Removed some unneeded type casting.
1925         (jsPDFDocFinalize): Ditto.
1926         (jsPDFDocPrint): Use a bridging cast.
1927
1928         * WebView/WebPDFView.mm:
1929         (_applicationInfoForMIMEType): Use bridging casts.
1930
1931         * WebView/WebPreferences.mm:
1932         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
1933         instead of methods from WebNSDictionaryExtras.
1934         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
1935         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
1936         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
1937         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
1938         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
1939
1940         * WebView/WebView.mm:
1941         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
1942         (-[WebView _addToAllWebViewsSet]): Ditto.
1943         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
1944         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
1945         so it can be called from WebViewData methods.
1946
1947         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
1948         method, _windowVisibilityChanged:.
1949
1950         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
1951         called from WebViewData methods.
1952
1953 2018-08-06  Alex Christensen  <achristensen@webkit.org>
1954
1955         Use enum classes and OptionSets for PaintPhase and PaintBehavior
1956         https://bugs.webkit.org/show_bug.cgi?id=188323
1957
1958         Reviewed by Simon Fraser.
1959
1960         * WebCoreSupport/WebContextMenuClient.mm:
1961         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1962         * WebView/WebFrame.mm:
1963         (-[WebFrame _paintBehaviorForDestinationContext:]):
1964         (-[WebFrame _drawRect:contentsOnly:]):
1965         * WebView/WebHTMLView.mm:
1966         (imageFromRect):
1967         (selectionImage):
1968
1969 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1970
1971         Add support for microtasks in workers
1972         https://bugs.webkit.org/show_bug.cgi?id=188246
1973
1974         Reviewed by Darin Adler.
1975
1976         Rename JSMainThreadExecState.h to JSExecState.h.
1977
1978         * DOM/DOMAttr.mm:
1979         * DOM/DOMBlob.mm:
1980         * DOM/DOMCDATASection.mm:
1981         * DOM/DOMCSSCharsetRule.mm:
1982         * DOM/DOMCSSFontFaceRule.mm:
1983         * DOM/DOMCSSImportRule.mm:
1984         * DOM/DOMCSSMediaRule.mm:
1985         * DOM/DOMCSSPageRule.mm:
1986         * DOM/DOMCSSPrimitiveValue.mm:
1987         * DOM/DOMCSSRule.mm:
1988         * DOM/DOMCSSRuleList.mm:
1989         * DOM/DOMCSSStyleDeclaration.mm:
1990         * DOM/DOMCSSStyleRule.mm:
1991         * DOM/DOMCSSStyleSheet.mm:
1992         * DOM/DOMCSSUnknownRule.mm:
1993         * DOM/DOMCSSValue.mm:
1994         * DOM/DOMCSSValueList.mm:
1995         * DOM/DOMCharacterData.mm:
1996         * DOM/DOMComment.mm:
1997         * DOM/DOMCounter.mm:
1998         * DOM/DOMDocument.mm:
1999         * DOM/DOMDocumentFragment.mm:
2000         * DOM/DOMDocumentType.mm:
2001         * DOM/DOMElement.mm:
2002         * DOM/DOMEvent.mm:
2003         * DOM/DOMFile.mm:
2004         * DOM/DOMFileList.mm:
2005         * DOM/DOMHTML.mm:
2006         * DOM/DOMHTMLAnchorElement.mm:
2007         * DOM/DOMHTMLAppletElement.mm:
2008         * DOM/DOMHTMLAreaElement.mm:
2009         * DOM/DOMHTMLBRElement.mm:
2010         * DOM/DOMHTMLBaseElement.mm:
2011         * DOM/DOMHTMLBaseFontElement.mm:
2012         * DOM/DOMHTMLBodyElement.mm:
2013         * DOM/DOMHTMLButtonElement.mm:
2014         * DOM/DOMHTMLCanvasElement.mm:
2015         * DOM/DOMHTMLCollection.mm:
2016         * DOM/DOMHTMLDListElement.mm:
2017         * DOM/DOMHTMLDirectoryElement.mm:
2018         * DOM/DOMHTMLDivElement.mm:
2019         * DOM/DOMHTMLDocument.mm:
2020         * DOM/DOMHTMLElement.mm:
2021         * DOM/DOMHTMLEmbedElement.mm:
2022         * DOM/DOMHTMLFieldSetElement.mm:
2023         * DOM/DOMHTMLFontElement.mm:
2024         * DOM/DOMHTMLFormElement.mm:
2025         * DOM/DOMHTMLFrameElement.mm:
2026         * DOM/DOMHTMLFrameSetElement.mm:
2027         * DOM/DOMHTMLHRElement.mm:
2028         * DOM/DOMHTMLHeadElement.mm:
2029         * DOM/DOMHTMLHeadingElement.mm:
2030         * DOM/DOMHTMLHtmlElement.mm:
2031         * DOM/DOMHTMLIFrameElement.mm:
2032         * DOM/DOMHTMLImageElement.mm:
2033         * DOM/DOMHTMLInputElement.mm:
2034         * DOM/DOMHTMLLIElement.mm:
2035         * DOM/DOMHTMLLabelElement.mm:
2036         * DOM/DOMHTMLLegendElement.mm:
2037         * DOM/DOMHTMLLinkElement.mm:
2038         * DOM/DOMHTMLMapElement.mm:
2039         * DOM/DOMHTMLMarqueeElement.mm:
2040         * DOM/DOMHTMLMediaElement.mm:
2041         * DOM/DOMHTMLMenuElement.mm:
2042         * DOM/DOMHTMLMetaElement.mm:
2043         * DOM/DOMHTMLModElement.mm:
2044         * DOM/DOMHTMLOListElement.mm:
2045         * DOM/DOMHTMLObjectElement.mm:
2046         * DOM/DOMHTMLOptGroupElement.mm:
2047         * DOM/DOMHTMLOptionElement.mm:
2048         * DOM/DOMHTMLOptionsCollection.mm:
2049         * DOM/DOMHTMLParagraphElement.mm:
2050         * DOM/DOMHTMLParamElement.mm:
2051         * DOM/DOMHTMLPreElement.mm:
2052         * DOM/DOMHTMLQuoteElement.mm:
2053         * DOM/DOMHTMLScriptElement.mm:
2054         * DOM/DOMHTMLSelectElement.mm:
2055         * DOM/DOMHTMLStyleElement.mm:
2056         * DOM/DOMHTMLTableCaptionElement.mm:
2057         * DOM/DOMHTMLTableCellElement.mm:
2058         * DOM/DOMHTMLTableColElement.mm:
2059         * DOM/DOMHTMLTableElement.mm:
2060         * DOM/DOMHTMLTableRowElement.mm:
2061         * DOM/DOMHTMLTableSectionElement.mm:
2062         * DOM/DOMHTMLTextAreaElement.mm:
2063         * DOM/DOMHTMLTitleElement.mm:
2064         * DOM/DOMHTMLUListElement.mm:
2065         * DOM/DOMHTMLVideoElement.mm:
2066         * DOM/DOMImplementation.mm:
2067         * DOM/DOMKeyboardEvent.mm:
2068         * DOM/DOMMediaError.mm:
2069         * DOM/DOMMediaList.mm:
2070         * DOM/DOMMouseEvent.mm:
2071         * DOM/DOMMutationEvent.mm:
2072         * DOM/DOMNamedNodeMap.mm:
2073         * DOM/DOMNode.mm:
2074         * DOM/DOMNodeIterator.mm:
2075         * DOM/DOMNodeList.mm:
2076         * DOM/DOMOverflowEvent.mm:
2077         * DOM/DOMProcessingInstruction.mm:
2078         * DOM/DOMProgressEvent.mm:
2079         * DOM/DOMRGBColor.mm:
2080         * DOM/DOMRange.mm:
2081         * DOM/DOMRect.mm:
2082         * DOM/DOMStyleSheet.mm:
2083         * DOM/DOMStyleSheetList.mm:
2084         * DOM/DOMText.mm:
2085         * DOM/DOMTextEvent.mm:
2086         * DOM/DOMTimeRanges.mm:
2087         * DOM/DOMTokenList.mm:
2088         * DOM/DOMTreeWalker.mm:
2089         * DOM/DOMUIEvent.mm:
2090         * DOM/DOMWheelEvent.mm:
2091         * DOM/DOMXPathExpression.mm:
2092         * DOM/DOMXPathResult.mm:
2093         * DOM/ObjCEventListener.mm:
2094
2095 2018-08-03  Alex Christensen  <achristensen@webkit.org>
2096
2097         Fix spelling of "overridden"
2098         https://bugs.webkit.org/show_bug.cgi?id=188315
2099
2100         Reviewed by Darin Adler.
2101
2102         * Misc/WebKitVersionChecks.mm:
2103         (setWebKitLinkTimeVersion):
2104         (WebKitLinkTimeVersion):
2105         * Plugins/WebBaseNetscapePluginView.mm:
2106         (-[WebBaseNetscapePluginView handleMouseMoved:]):
2107         * WebCoreSupport/PopupMenuMac.mm:
2108         (PopupMenuMac::populate):
2109
2110 2018-08-01  Nan Wang  <n_wang@apple.com>
2111
2112         AX: AOM: Add ARIA IDL Attribute Reflection
2113         https://bugs.webkit.org/show_bug.cgi?id=184676
2114         <rdar://problem/39476882>
2115
2116         Reviewed by Chris Fleizach.
2117
2118         * WebView/WebPreferenceKeysPrivate.h:
2119         * WebView/WebPreferences.mm:
2120         (+[WebPreferences initialize]):
2121         (-[WebPreferences ariaReflectionEnabled]):
2122         (-[WebPreferences setAriaReflectionEnabled:]):
2123         * WebView/WebPreferencesPrivate.h:
2124         * WebView/WebView.mm:
2125         (-[WebView _preferencesChanged:]):
2126
2127 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
2128
2129         Shrink GraphicsLayerCA
2130         https://bugs.webkit.org/show_bug.cgi?id=188141
2131
2132         Reviewed by Zalan Bujtas.
2133
2134         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
2135         * moving all the clone-related stuff into the lazily-allocated m_layerClones
2136         * moving all the animation-related stuff into the lazily-allocated m_animations
2137         * making enums be 8-bit
2138         * re-ordering data members
2139
2140         * WebView/WebView.mm:
2141         (-[WebView _setMediaLayer:forPluginView:]):
2142
2143 2018-07-30  Rob Buis  <rbuis@igalia.com>
2144
2145         Merge PlatformCookieJar functions into NetworkStorageSession
2146         https://bugs.webkit.org/show_bug.cgi?id=188137
2147
2148         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
2149
2150         Reviewed by Alex Christensen.
2151
2152         * WebCoreSupport/WebPlatformStrategies.mm:
2153         (WebPlatformStrategies::cookiesForDOM):
2154         (WebPlatformStrategies::setCookiesFromDOM):
2155         (WebPlatformStrategies::cookiesEnabled):
2156         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2157         (WebPlatformStrategies::getRawCookies):
2158         (WebPlatformStrategies::deleteCookie):
2159         * WebView/WebPreferences.mm:
2160         (+[WebPreferences _clearNetworkLoaderSession]):
2161
2162 2018-07-28  Darin Adler  <darin@apple.com>
2163
2164         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
2165         https://bugs.webkit.org/show_bug.cgi?id=188140
2166
2167         Reviewed by Sam Weinig.
2168
2169         * WebView/WebImmediateActionController.mm:
2170         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
2171         new DictionaryLookup function that returns a tuple instead of using an out argument.
2172
2173 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
2174
2175         [INTL] Remove INTL sub-feature compile flags
2176         https://bugs.webkit.org/show_bug.cgi?id=188081
2177
2178         Reviewed by Michael Catanzaro.
2179
2180         * Configurations/FeatureDefines.xcconfig:
2181
2182 2018-07-26  Commit Queue  <commit-queue@webkit.org>
2183
2184         Unreviewed, rolling out r234181 and r234189.
2185         https://bugs.webkit.org/show_bug.cgi?id=188075
2186
2187         These are not needed right now (Requested by thorton on
2188         #webkit).
2189
2190         Reverted changesets:
2191
2192         "Enable Web Content Filtering on watchOS"
2193         https://bugs.webkit.org/show_bug.cgi?id=187979
2194         https://trac.webkit.org/changeset/234181
2195
2196         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
2197         https://bugs.webkit.org/show_bug.cgi?id=187985
2198         https://trac.webkit.org/changeset/234189
2199
2200 2018-07-26  Timothy Hatcher  <timothy@apple.com>
2201
2202         Use the Page's appearance when converting pasteboard attributed strings.
2203         https://bugs.webkit.org/show_bug.cgi?id=188067
2204         rdar://problem/42632246
2205
2206         Reviewed by Wenson Hsieh.
2207
2208         * WebCoreSupport/WebEditorClient.mm:
2209         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
2210
2211 2018-07-25  Chris Dumez  <cdumez@apple.com>
2212
2213         navigator.userAgent may return outdated value after webView.customUserAgent is set
2214         https://bugs.webkit.org/show_bug.cgi?id=188009
2215         <rdar://problem/42566456>
2216
2217         Reviewed by Alex Christensen.
2218
2219         Let the page know when the user agent changes.
2220
2221         * WebView/WebView.mm:
2222         (-[WebView _preferencesChanged:]):
2223         (-[WebView setApplicationNameForUserAgent:]):
2224         (-[WebView _invalidateUserAgentCache]):
2225         (-[WebView setCustomUserAgent:]):
2226         * WebView/WebViewInternal.h:
2227
2228 2018-07-24  Tim Horton  <timothy_horton@apple.com>
2229
2230         Enable Web Content Filtering on watchOS
2231         https://bugs.webkit.org/show_bug.cgi?id=187979
2232         <rdar://problem/42559346>
2233
2234         Reviewed by Wenson Hsieh.
2235
2236         * Configurations/FeatureDefines.xcconfig:
2237
2238 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
2239
2240         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
2241         https://bugs.webkit.org/show_bug.cgi?id=187846
2242
2243         Reviewed by Simon Fraser.
2244
2245         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
2246
2247         * WebView/WebHTMLView.mm:
2248         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
2249         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
2250
2251 2018-07-11  Dean Jackson  <dino@apple.com>
2252
2253         Allow removal of white backgrounds
2254         https://bugs.webkit.org/show_bug.cgi?id=187574
2255         <rdar://problem/41146792>
2256
2257         Reviewed by Simon Fraser.
2258
2259         Add a new WebPreference for punching out white backgrounds.
2260
2261         * WebView/WebPreferenceKeysPrivate.h:
2262         * WebView/WebPreferences.mm:
2263         (+[WebPreferences initialize]):
2264         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
2265         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
2266         * WebView/WebPreferencesPrivate.h:
2267         * WebView/WebView.mm:
2268         (-[WebView _preferencesChanged:]):
2269
2270 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
2271
2272         Ensure WebKit stack is ad-hoc signed
2273         https://bugs.webkit.org/show_bug.cgi?id=187667
2274
2275         Reviewed by Alexey Proskuryakov.
2276
2277         * Configurations/Base.xcconfig:
2278
2279 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
2280
2281         REGRESSION (231276): Attempting to copy an image fails
2282         https://bugs.webkit.org/show_bug.cgi?id=187212
2283         <rdar://problem/41540074>
2284
2285         Reviewed by Ryosuke Niwa.
2286
2287         Renamed methods to make it clear that one URL and one title are being passed in.
2288
2289         * WebCoreSupport/WebPlatformStrategies.h:
2290         * WebCoreSupport/WebPlatformStrategies.mm:
2291         (WebPlatformStrategies::setURL):
2292
2293 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
2294
2295         Disable cross-origin-window-policy by default
2296         https://bugs.webkit.org/show_bug.cgi?id=187509
2297
2298         Reviewed by Chris Dumez.
2299
2300         * WebView/WebPreferences.mm:
2301         (+[WebPreferences initialize]):
2302
2303 2018-07-09  Timothy Hatcher  <timothy@apple.com>
2304
2305         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2306         https://bugs.webkit.org/show_bug.cgi?id=187425
2307         rdar://problem/39948240
2308
2309         Reviewed by Tim Horton.
2310
2311         * WebView/WebView.mm:
2312         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
2313         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
2314         a call in this method to setUseDarkAppearance.
2315         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
2316         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
2317         (-[WebView _updateDefaultAppearance]): Deleted.
2318         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
2319
2320 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
2321
2322         Shrink various loading-related enums to shrink CachedResource
2323         https://bugs.webkit.org/show_bug.cgi?id=187443
2324
2325         Reviewed by Chris Dumez.
2326
2327         * WebCoreSupport/WebFrameLoaderClient.mm:
2328         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2329         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2330         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2331         (WebFrameLoaderClient::dispatchWillSendRequest):
2332         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2333         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2334         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2335         (WebFrameLoaderClient::updateGlobalHistory):
2336         (WebFrameLoaderClient::canHandleRequest const):
2337         * WebView/WebDataSource.mm:
2338         (-[WebDataSource initialRequest]):
2339         (-[WebDataSource request]):
2340
2341 2018-07-09  Commit Queue  <commit-queue@webkit.org>
2342
2343         Unreviewed, rolling out r233612.
2344         https://bugs.webkit.org/show_bug.cgi?id=187475
2345
2346         Revision caused the api test LinkColorWithSystemAppearance to
2347         fail on all systems. (Requested by Truitt on #webkit).
2348
2349         Reverted changeset:
2350
2351         "Semantic colors don't update when accessibility Increase
2352         Contrast mode is enabled."
2353         https://bugs.webkit.org/show_bug.cgi?id=187425
2354         https://trac.webkit.org/changeset/233612
2355
2356 2018-07-06  Timothy Hatcher  <timothy@apple.com>
2357
2358         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2359         https://bugs.webkit.org/show_bug.cgi?id=187425
2360         rdar://problem/39948240
2361
2362         Reviewed by Tim Horton.
2363
2364         * WebView/WebView.mm:
2365         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
2366         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
2367         a call in this method to setUseDarkAppearance.
2368         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
2369         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
2370         (-[WebView _updateDefaultAppearance]): Deleted.
2371         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
2372
2373 2018-07-05  Timothy Hatcher  <timothy@apple.com>
2374
2375         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
2376         https://bugs.webkit.org/show_bug.cgi?id=187369
2377         rdar://problem/41870420
2378
2379         Reviewed by Tim Horton.
2380
2381         * WebView/WebMediaPlaybackTargetPicker.mm:
2382         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
2383         * WebView/WebView.mm:
2384         (-[WebView _commonInitializationWithFrameName:groupName:]):
2385         (-[WebView _effectiveAppearanceIsDark]):
2386         (-[WebView _updateDefaultAppearance]):
2387         (-[WebView _defaultAppearance]): Deleted.
2388
2389 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
2390
2391         Youtube video pages crash after a couple of minutes
2392         https://bugs.webkit.org/show_bug.cgi?id=187316
2393
2394         Reviewed by Antti Koivisto.
2395
2396         * WebView/WebView.mm:
2397         (-[WebView _preferencesChanged:]):
2398
2399 2018-07-04  Tim Horton  <timothy_horton@apple.com>
2400
2401         Introduce PLATFORM(IOSMAC)
2402         https://bugs.webkit.org/show_bug.cgi?id=187315
2403
2404         Reviewed by Dan Bernstein.
2405
2406         * Configurations/Base.xcconfig:
2407         * Configurations/FeatureDefines.xcconfig:
2408
2409 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2410
2411         [iOS] DataTransfer.getData always returns the empty string when dropping text
2412         https://bugs.webkit.org/show_bug.cgi?id=187130
2413         <rdar://problem/41014117>
2414
2415         Reviewed by Ryosuke Niwa.
2416
2417         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
2418
2419         * WebCoreSupport/WebPlatformStrategies.h:
2420         * WebCoreSupport/WebPlatformStrategies.mm:
2421         (WebPlatformStrategies::allPasteboardItemInfo):
2422
2423 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
2424
2425         [Mac] AirPlay picker uses incorrect theme in Dark mode
2426         https://bugs.webkit.org/show_bug.cgi?id=187054
2427         <rdar://problem/41291093>
2428
2429         Reviewed by Timothy Hatcher.
2430
2431         * WebView/WebMediaPlaybackTargetPicker.mm:
2432         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
2433
2434 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2435
2436         [WTF] Add user-defined literal for ASCIILiteral
2437         https://bugs.webkit.org/show_bug.cgi?id=186839
2438
2439         Reviewed by Darin Adler.
2440
2441         * DOM/ExceptionHandlers.mm:
2442         (raiseDOMErrorException):
2443         * Plugins/Hosted/ProxyInstance.mm:
2444         (WebKit::ProxyInstance::invokeMethod):
2445         * Storage/WebDatabaseProvider.mm:
2446         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
2447
2448 2018-06-22  Timothy Hatcher  <timothy@apple.com>
2449
2450         Recalc styles every time defaultAppearance changes.
2451         https://bugs.webkit.org/show_bug.cgi?id=186866
2452         rdar://problem/41309805
2453
2454         Reviewed by Tim Horton.
2455
2456         * WebView/WebView.mm:
2457         (-[WebView _updateDefaultAppearance]):
2458         (-[WebView _setUseSystemAppearance:]):
2459         (-[WebView _useSystemAppearance]):
2460
2461 2018-06-20  Darin Adler  <darin@apple.com>
2462
2463         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
2464         https://bugs.webkit.org/show_bug.cgi?id=186875
2465
2466         Reviewed by Anders Carlsson.
2467
2468         * WebView/WebHTMLView.mm:
2469         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
2470         to write te file to.
2471         * WebView/WebPreferences.mm:
2472         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
2473         * WebView/WebView.mm:
2474         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
2475
2476 2018-06-12  Darin Adler  <darin@apple.com>
2477
2478         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
2479         https://bugs.webkit.org/show_bug.cgi?id=186526
2480
2481         Reviewed by Anders Carlsson.
2482
2483         * Plugins/Hosted/NetscapePluginHostManager.mm:
2484         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
2485
2486         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2487         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
2488         assignment rather than adoptNS/leakRef.
2489         * Plugins/WebNetscapePluginView.mm:
2490         (-[WebNetscapePluginView createPlugin]): Ditto.
2491
2492         * WebCoreSupport/WebContextMenuClient.mm:
2493         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
2494         RetainPtr::autorelease; no need to autorelease just to pass something as a function
2495         argument, so use RetainPtr::get instead.
2496
2497         * WebView/WebHTMLView.mm:
2498         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
2499         No need to autorelease the result when the return type is RetainPtr.
2500
2501         * WebView/WebPDFRepresentation.mm:
2502         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
2503
2504 2018-06-13  Youenn Fablet  <youenn@apple.com>
2505
2506         Supported plugin check should be based on plugin identifier
2507         https://bugs.webkit.org/show_bug.cgi?id=186578
2508         <rdar://problem/40523828>
2509
2510         Reviewed by Darin Adler.
2511
2512         * WebCoreSupport/WebPluginInfoProvider.h:
2513         * WebCoreSupport/WebPluginInfoProvider.mm:
2514         (WebPluginInfoProvider::pluginInfo):
2515         (WebPluginInfoProvider::webVisiblePluginInfo):
2516
2517 2018-06-13  Chris Dumez  <cdumez@apple.com>
2518
2519         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
2520         https://bugs.webkit.org/show_bug.cgi?id=186545
2521
2522         Reviewed by Brady Eidson.
2523
2524         Update client delegate now that parameter type has changed.
2525
2526         * WebCoreSupport/WebFrameLoaderClient.h:
2527         * WebCoreSupport/WebFrameLoaderClient.mm:
2528         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2529
2530 2018-06-11  Tim Horton  <timothy_horton@apple.com>
2531
2532         Link drag image is inconsistently unreadable in dark mode
2533         https://bugs.webkit.org/show_bug.cgi?id=186472
2534
2535         Reviewed by Timothy Hatcher.
2536
2537         * WebView/WebView.mm:
2538         (-[WebView _defaultAppearance]):
2539         Make defaultAppearance accurate even if useSystemAppearance is false.
2540         Some parts of WebKit (like the link drag image, but also context menus)
2541         want to be able to follow the system appearance regardless of whether
2542         the view or content has opted in.
2543
2544 2018-06-11  Chris Dumez  <cdumez@apple.com>
2545
2546         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
2547         https://bugs.webkit.org/show_bug.cgi?id=186441
2548
2549         Reviewed by Brady Eidson.
2550
2551         Rename existing flag to something a bit more generic, now that it is used for
2552         more things than bypassing the navigation policy check.
2553
2554         * WebView/WebView.mm:
2555         (-[WebView _loadBackForwardListFromOtherView:]):
2556         (-[WebView goToBackForwardItem:]):
2557
2558 2018-06-09  Dan Bernstein  <mitz@apple.com>
2559
2560         [Xcode] Clean up and modernize some build setting definitions
2561         https://bugs.webkit.org/show_bug.cgi?id=186463
2562
2563         Reviewed by Sam Weinig.
2564
2565         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
2566         * Configurations/DebugRelease.xcconfig: Ditto.
2567         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
2568           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
2569         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
2570         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
2571           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
2572         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
2573
2574 2018-06-08  Darin Adler  <darin@apple.com>
2575
2576         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
2577         https://bugs.webkit.org/show_bug.cgi?id=186436
2578
2579         Reviewed by Anders Carlsson.
2580
2581         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
2582         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
2583         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
2584         (PoolCleaner): Ditto.
2585
2586         * History/WebHistory.mm:
2587         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2588         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
2589         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
2590         now hardly used if at all.
2591         * WebView/WebView.mm:
2592         (-[WebView rectsForTextMatches]): Ditto.
2593
2594 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2595
2596         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
2597         https://bugs.webkit.org/show_bug.cgi?id=186442
2598         <rdar://problem/40879364>
2599
2600         Reviewed by Tim Horton.
2601
2602         * Configurations/FeatureDefines.xcconfig:
2603
2604 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
2605
2606         [Datalist] Allow TextFieldInputType to show and hide suggestions
2607         https://bugs.webkit.org/show_bug.cgi?id=186151
2608
2609         Reviewed by Tim Horton.
2610
2611         * WebCoreSupport/WebChromeClient.h:
2612         * WebCoreSupport/WebChromeClient.mm:
2613         (WebChromeClient::createDataListSuggestionPicker):
2614
2615 2018-06-07  Chris Dumez  <cdumez@apple.com>
2616
2617         Add base class to get WeakPtrFactory member and avoid some boilerplate code
2618         https://bugs.webkit.org/show_bug.cgi?id=186407
2619
2620         Reviewed by Brent Fulgham.
2621
2622         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
2623         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
2624         This also gets rid of old-style createWeakPtr() methods in favor of the newer
2625         makeWeakPtr().
2626
2627         * WebCoreSupport/WebEditorClient.h:
2628         * WebCoreSupport/WebEditorClient.mm:
2629         (WebEditorClient::requestCandidatesForSelection):
2630
2631 2018-06-05  Chris Dumez  <cdumez@apple.com>
2632
2633         Regression(r232082): Websites get loaded inside of Messages App chat transcript
2634         https://bugs.webkit.org/show_bug.cgi?id=186331
2635         <rdar://problem/40735446>
2636
2637         Reviewed by Darin Adler.
2638
2639         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
2640         but does not call use / ignore on the listener, then we would do "use" by default.
2641         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
2642         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
2643         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
2644         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
2645         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
2646         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
2647         and Box.app is still working properly.
2648
2649         * WebCoreSupport/WebFrameLoaderClient.h:
2650         * WebCoreSupport/WebFrameLoaderClient.mm:
2651         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2652         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2653         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2654         (WebFrameLoaderClient::dispatchWillSubmitForm):
2655         (WebFrameLoaderClient::setUpPolicyListener):
2656         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
2657         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
2658         (-[WebFramePolicyListener dealloc]):
2659         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
2660         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
2661
2662 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2663
2664         Adjust compile and runtime flags to match shippable state of features
2665         https://bugs.webkit.org/show_bug.cgi?id=186319
2666         <rdar://problem/40352045>
2667
2668         Reviewed by Maciej Stachowiak, Jon Lee, and others.
2669
2670         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
2671         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
2672         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
2673         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
2674         Cocoa builds.
2675
2676 2018-06-05  Timothy Hatcher  <timothy@apple.com>
2677
2678         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
2679
2680         https://bugs.webkit.org/show_bug.cgi?id=186323
2681         rdar://problem/38382252
2682
2683         Reviewed by Tim Horton.
2684
2685         * WebView/WebView.mm:
2686         (-[WebView _defaultAppearance]):
2687
2688 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2689
2690         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
2691         https://bugs.webkit.org/show_bug.cgi?id=186286
2692         <rdar://problem/40782992>
2693
2694         Reviewed by Dan Bernstein.
2695
2696         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
2697         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
2698         change this flag when preparing for a production release.
2699
2700         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
2701         whether experimental features should be enabled, and use it to properly define the
2702         feature flag.
2703
2704 2018-06-03  Darin Adler  <darin@apple.com>
2705
2706         Simplify and remove some unused video element code (helpful for ARC-compatibility)
2707         https://bugs.webkit.org/show_bug.cgi?id=186258
2708
2709         Reviewed by Daniel Bates.
2710
2711         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
2712         forward declarations. Removed methods that don't need to be public.
2713
2714         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
2715         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
2716         unnamed category in here and also replaced the HUDWindowControllerDelegate
2717         with the unnamed category. Removed unused NSWindow category defining the
2718         isOnActiveSpace, which is not called anywhere in this file at this time.
2719         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
2720         into setVideoElement.
2721         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
2722         and removed unneeded typecast.
2723         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
2724         using statement at the top of the file.
2725         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
2726         the many side effects and special considerations that this method that sounds
2727         like a setter has. Updated code to use the new
2728         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
2729         HTMLVideoElement::platformMedia function. Also straightened out the logic a
2730         bit and added some FIXME comments about small problems noticed but not fixed.
2731         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
2732         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
2733         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
2734         typecast. Removed call to updatePowerAssertions method.
2735         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
2736         updatePowerAssertions method.
2737         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
2738         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
2739         else, so this was dead code that did nothing.
2740         (-[WebVideoFullscreenController rateChanged:]): Removed call to
2741         updatePowerAssertions method.
2742
2743 2018-06-04  Chris Dumez  <cdumez@apple.com>
2744
2745         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
2746         https://bugs.webkit.org/show_bug.cgi?id=186287
2747         <rdar://problem/40783352>
2748
2749         Reviewed by Youenn Fablet.
2750
2751         * WebView/WebPreferenceKeysPrivate.h:
2752         * WebView/WebPreferences.mm:
2753         (+[WebPreferences initialize]):
2754         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
2755         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
2756         * WebView/WebPreferencesPrivate.h:
2757         * WebView/WebView.mm:
2758         (-[WebView _preferencesChanged:]):
2759
2760 2018-06-02  Darin Adler  <darin@apple.com>
2761
2762         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
2763         https://bugs.webkit.org/show_bug.cgi?id=186227
2764
2765         Reviewed by Dan Bernstein.
2766
2767         * Misc/WebKitErrors.m:
2768         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
2769         * Plugins/WebPluginDatabase.mm:
2770         (-[WebPluginDatabase refresh]): Ditto.
2771         * WebCoreSupport/WebChromeClient.mm:
2772         (WebChromeClient::setStatusbarText): Ditto.
2773
2774 2018-06-01  Chris Dumez  <cdumez@apple.com>
2775
2776         REGRESSION (r231456): Colloquy is broken
2777         https://bugs.webkit.org/show_bug.cgi?id=186197
2778         <rdar://problem/40722960>
2779
2780         Reviewed by Timothy Hatcher.
2781
2782         Restore pre-r231456 behavior for Colloquy app so that it works again.
2783
2784         * WebView/WebView.mm:
2785         (-[WebView _needsFrameNameFallbackToIdQuirk]):
2786         (-[WebView _preferencesChanged:]):
2787
2788 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2789
2790         [JSC] Pass VM& parameter as much as possible
2791         https://bugs.webkit.org/show_bug.cgi?id=186085
2792
2793         Reviewed by Saam Barati.
2794
2795         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2796         (WebKit::NetscapePluginInstanceProxy::invoke):
2797
2798 2018-05-30  Daniel Bates  <dabates@apple.com>
2799
2800         NavigationAction does not need to hold initiating DOM Event
2801         https://bugs.webkit.org/show_bug.cgi?id=185958
2802         <rdar://problem/40531539>
2803
2804         Reviewed by Simon Fraser.
2805
2806         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
2807
2808         * WebCoreSupport/WebFrameLoaderClient.mm:
2809         (WebFrameLoaderClient::actionDictionary const):
2810         (findMouseEvent): Deleted.
2811
2812 2018-05-27  Dan Bernstein  <mitz@apple.com>
2813
2814         Reverted the changes made for https://webkit.org/b/186016
2815
2816         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
2817
2818
2819 2018-05-27  David Kilzer  <ddkilzer@apple.com>
2820
2821         [iOS] Fix warnings about leaks found by clang static analyzer
2822         <https://webkit.org/b/186009>
2823         <rdar://problem/40574267>
2824
2825         Reviewed by Daniel Bates.
2826
2827         * WebView/WebHTMLView.mm:
2828         (-[WebHTMLView doCommandBySelector:]): Fix use of an
2829         uninitialized boolean variable (`eventWasHandled`) that only
2830         happened on iOS.
2831
2832 2018-05-27  Dan Bernstein  <mitz@apple.com>
2833
2834         [Cocoa] Avoid importing directly from subumbrella frameworks
2835         https://bugs.webkit.org/show_bug.cgi?id=186016
2836
2837         Reviewed by Sam Weinig.
2838
2839         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
2840         * Carbon/CarbonWindowAdapter.mm: Ditto.
2841         * Carbon/CarbonWindowFrame.m: Ditto.
2842         * Carbon/HIViewAdapter.h: Ditto.
2843         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
2844           OTHER_CPLUSPLUSFLAGS.
2845         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
2846         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
2847         * WebView/WebPDFView.h: Ditto.
2848
2849 2018-05-27  Sam Weinig  <sam@webkit.org>
2850
2851         Modernize RenderStyleConstants.h - Part 3
2852         https://bugs.webkit.org/show_bug.cgi?id=186015
2853
2854         Reviewed by Yusuke Suzuki.
2855
2856         * WebView/WebView.mm:
2857         (-[WebView updateTextTouchBar]):
2858         Update for new enum name.
2859
2860 2018-05-25  Chris Dumez  <cdumez@apple.com>
2861
2862         Minor ApplicationCacheStorage clean up
2863         https://bugs.webkit.org/show_bug.cgi?id=185984
2864
2865         Reviewed by Youenn Fablet.
2866
2867         * WebCoreSupport/WebApplicationCache.mm:
2868         (+[WebApplicationCache originsWithCache]):
2869
2870 2018-05-25  David Kilzer  <ddkilzer@apple.com>
2871
2872         Fix issues with -dealloc methods found by clang static analyzer
2873         <https://webkit.org/b/185887>
2874
2875         Reviewed by Joseph Pecoraro.
2876
2877         * WebView/WebView.mm:
2878         (-[WebUITextIndicatorData dealloc]):
2879         - Move method implementation from (WebUITextIndicatorInternal)
2880           category to the main category since this is public API.  This
2881           fixes the false positive warning about a missing -dealloc
2882           method.
2883
2884 2018-05-24  Sam Weinig  <sam@webkit.org>
2885
2886         Modernize RenderStyleConstants.h - Part 2
2887         https://bugs.webkit.org/show_bug.cgi?id=185901
2888
2889         Reviewed by Simon Fraser.
2890
2891         * WebView/WebHTMLRepresentation.mm:
2892         (searchForLabelsBeforeElement):
2893         * WebView/WebView.mm:
2894         (nsTextAlignmentFromRenderStyle):
2895         Update for new enum names.
2896
2897 2018-05-22  Chris Dumez  <cdumez@apple.com>
2898
2899         Regression(AsyncPolicyDelegates): Box.app login Window is blank
2900         https://bugs.webkit.org/show_bug.cgi?id=185832
2901         <rdar://problem/40307871>
2902
2903         Reviewed by Geoffrey Garen.
2904
2905         We used to have a bug where where we would fail to wait for the policy decision for
2906         the navigation response from the client and the load would keep going, racing with
2907         the client's policy decision. If the client did not respond in time, the behavior
2908         would be the same as "Use" policy action.
2909
2910         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
2911         but the load happened to proceed anyway due to our bug. Now that we've fixed the
2912         WebKit bug, however, the load would hang because the completion handler for the
2913         decidePolicyForNavigationResponse would never get called.
2914
2915         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
2916         instead of retaining it. If the policy listener object gets destroyed because getting
2917         resolved, we now use "Use" policy action in its dealloc function to maintain previous
2918         behavior.
2919
2920         * WebCoreSupport/WebFrameLoaderClient.h:
2921         * WebCoreSupport/WebFrameLoaderClient.mm:
2922         (WebFrameLoaderClient::cancelPolicyCheck):
2923         (WebFrameLoaderClient::setUpPolicyListener):
2924         (-[WebFramePolicyListener dealloc]):
2925
2926 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
2927
2928         Unreviewed, rolling out r232052.
2929
2930         Breaks internal builds.
2931
2932         Reverted changeset:
2933
2934         "Use more C++17"
2935         https://bugs.webkit.org/show_bug.cgi?id=185176
2936         https://trac.webkit.org/changeset/232052
2937
2938 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2939
2940         Use more C++17
2941         https://bugs.webkit.org/show_bug.cgi?id=185176
2942
2943         Reviewed by JF Bastien.
2944
2945         * Configurations/Base.xcconfig:
2946         * Configurations/WebKitLegacy.xcconfig:
2947
2948 2018-05-21  Chris Nardi  <cnardi@chromium.org>
2949
2950         Remove dead exception in MediaList.appendMedium
2951         https://bugs.webkit.org/show_bug.cgi?id=185278
2952
2953         Reviewed by Chris Dumez.
2954
2955         Remove code pertaining to an exception being thrown by appendMedium().
2956
2957         * DOM/DOMMediaList.mm:
2958         (-[DOMMediaList appendMedium:]):
2959
2960 2018-05-21  Jer Noble  <jer.noble@apple.com>
2961
2962         Complete fix for enabling modern EME by default
2963         https://bugs.webkit.org/show_bug.cgi?id=185770
2964         <rdar://problem/40368220>
2965
2966         Reviewed by Eric Carlson.
2967
2968         * Configurations/FeatureDefines.xcconfig:
2969
2970 2018-05-21  Antti Koivisto  <antti@apple.com>
2971
2972         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
2973         https://bugs.webkit.org/show_bug.cgi?id=185815
2974         <rdar://problem/40310069>
2975
2976         Reviewed by Simon Fraser.
2977
2978         User stylesheet parsing may depend on the colorFilterEnabled preference.
2979
2980         * WebView/WebView.mm:
2981         (-[WebView _preferencesChanged:]):
2982
2983 2018-05-18  Commit Queue  <commit-queue@webkit.org>
2984
2985         Unreviewed, rolling out r231982.
2986         https://bugs.webkit.org/show_bug.cgi?id=185793
2987
2988         Caused layout test failures (Requested by realdawei on
2989         #webkit).
2990
2991         Reverted changeset:
2992
2993         "Complete fix for enabling modern EME by default"
2994         https://bugs.webkit.org/show_bug.cgi?id=185770
2995         https://trac.webkit.org/changeset/231982
2996
2997 2018-05-18  Jer Noble  <jer.noble@apple.com>
2998
2999         Complete fix for enabling modern EME by default
3000         https://bugs.webkit.org/show_bug.cgi?id=185770
3001         <rdar://problem/40368220>
3002
3003         Reviewed by Eric Carlson.
3004
3005         * Configurations/FeatureDefines.xcconfig:
3006
3007 2018-05-18  Chris Dumez  <cdumez@apple.com>
3008
3009         Avoid keeping the frame alive when ref'ing a WindowProxy
3010         https://bugs.webkit.org/show_bug.cgi?id=185737
3011         <rdar://problem/40004666>
3012
3013         Reviewed by Sam Weinig.
3014
3015         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3016         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3017
3018 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
3019
3020         Add support for Intl NumberFormat formatToParts
3021         https://bugs.webkit.org/show_bug.cgi?id=185375
3022
3023         Reviewed by Yusuke Suzuki.
3024
3025         Add flag for NumberFormat formatToParts.
3026
3027         * Configurations/FeatureDefines.xcconfig:
3028
3029 2018-05-16  Chris Nardi  <cnardi@chromium.org>
3030
3031         Fixup after r231849: Do not mark Mac API methods as deprecated
3032         https://bugs.webkit.org/show_bug.cgi?id=185684
3033
3034         Reviewed by Darin Adler.
3035
3036         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
3037         as the entire class is already marked as deprecated, so it is unnecessary.
3038
3039         * DOM/DOMDocument.h:
3040
3041 2018-05-16  Chris Nardi  <cnardi@chromium.org>
3042
3043         Remove Document#selectedStylesheetSet/preferredStylesheetSet
3044         https://bugs.webkit.org/show_bug.cgi?id=185381
3045
3046         Reviewed by Darin Adler.
3047
3048         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
3049         and make them do nothing.
3050
3051         * DOM/DOMDocument.h:
3052         * DOM/DOMDocument.mm:
3053         (-[DOMDocument preferredStylesheetSet]):
3054         (-[DOMDocument selectedStylesheetSet]):
3055         (-[DOMDocument setSelectedStylesheetSet:]):
3056
3057 2018-05-15  Antoine Quint  <graouts@apple.com>
3058
3059         [Web Animations] Expose Web Animations CSS integration as an experimental feature
3060         https://bugs.webkit.org/show_bug.cgi?id=185647
3061
3062         Reviewed by Dean Jackson.
3063
3064         Rename the Web Animations CSS integration flag.
3065
3066         * WebView/WebPreferenceKeysPrivate.h:
3067         * WebView/WebPreferences.mm:
3068         (+[WebPreferences initialize]):
3069         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
3070         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
3071         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
3072         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
3073         * WebView/WebPreferencesPrivate.h:
3074         * WebView/WebView.mm:
3075         (-[WebView _preferencesChanged:]):
3076
3077 2018-05-14  Daniel Bates  <dabates@apple.com>
3078
3079         Fix the Apple Internal build
3080
3081         See <rdar://problem/40237873> for more details.
3082
3083         * WebView/WebFullScreenController.mm:
3084         (-[WebFullScreenController enterFullScreen:]):
3085         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3086         (-[WebFullScreenController exitFullScreen]):
3087         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3088         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3089         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3090
3091 2018-05-11  Timothy Hatcher  <timothy@apple.com>
3092
3093         WebHTMLView is not setting aside subviews when drawing.
3094
3095         https://bugs.webkit.org/show_bug.cgi?id=185561
3096         rdar://problem/40172894
3097
3098         Reviewed by Simon Fraser.
3099
3100         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
3101
3102         * WebView/WebHTMLView.mm:
3103         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
3104
3105 2018-05-07  Daniel Bates  <dabates@apple.com>
3106
3107         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
3108         https://bugs.webkit.org/show_bug.cgi?id=185170
3109
3110         Reviewed by Per Arne Vollan.
3111
3112         * Misc/WebCache.mm:
3113         (+[WebCache empty]):
3114
3115 2018-05-04  Timothy Hatcher  <timothy@apple.com>
3116
3117         Deprecate legacy WebView and friends
3118         https://bugs.webkit.org/show_bug.cgi?id=185279
3119         rdar://problem/33268700
3120
3121         Reviewed by Tim Horton.
3122
3123         Added deprecation macros to all the classes, extern strings, and enums.
3124
3125         * Configurations/WebKitLegacy.xcconfig:
3126         Added BUILDING_WEBKIT define to disable the deprecation macros.
3127         * DOM/DOMAbstractView.h:
3128         * DOM/DOMAttr.h:
3129         * DOM/DOMBlob.h:
3130         * DOM/DOMCDATASection.h:
3131         * DOM/DOMCSSCharsetRule.h:
3132         * DOM/DOMCSSFontFaceRule.h:
3133         * DOM/DOMCSSImportRule.h:
3134         * DOM/DOMCSSMediaRule.h:
3135         * DOM/DOMCSSPageRule.h:
3136         * DOM/DOMCSSPrimitiveValue.h:
3137         * DOM/DOMCSSRule.h:
3138         * DOM/DOMCSSRuleList.h:
3139         * DOM/DOMCSSStyleDeclaration.h:
3140         * DOM/DOMCSSStyleRule.h:
3141         * DOM/DOMCSSStyleSheet.h:
3142         * DOM/DOMCSSUnknownRule.h:
3143         * DOM/DOMCSSValue.h:
3144         * DOM/DOMCSSValueList.h:
3145         * DOM/DOMCharacterData.h:
3146         * DOM/DOMComment.h:
3147         * DOM/DOMCounter.h:
3148         * DOM/DOMDocument.h:
3149         * DOM/DOMDocumentFragment.h:
3150         * DOM/DOMDocumentType.h:
3151         * DOM/DOMElement.h:
3152         * DOM/DOMEntity.h:
3153         * DOM/DOMEntityReference.h:
3154         * DOM/DOMEvent.h:
3155         * DOM/DOMEventException.h:
3156         * DOM/DOMEventListener.h:
3157         * DOM/DOMEventTarget.h:
3158         * DOM/DOMException.h:
3159         * DOM/DOMFile.h:
3160         * DOM/DOMFileList.h:
3161         * DOM/DOMHTMLAnchorElement.h:
3162         * DOM/DOMHTMLAppletElement.h:
3163         * DOM/DOMHTMLAreaElement.h:
3164         * DOM/DOMHTMLBRElement.h:
3165         * DOM/DOMHTMLBaseElement.h:
3166         * DOM/DOMHTMLBaseFontElement.h:
3167         * DOM/DOMHTMLBodyElement.h:
3168         * DOM/DOMHTMLButtonElement.h:
3169         * DOM/DOMHTMLCanvasElement.h:
3170         * DOM/DOMHTMLCollection.h:
3171         * DOM/DOMHTMLDListElement.h:
3172         * DOM/DOMHTMLDirectoryElement.h:
3173         * DOM/DOMHTMLDivElement.h:
3174         * DOM/DOMHTMLDocument.h:
3175         * DOM/DOMHTMLElement.h:
3176         * DOM/DOMHTMLEmbedElement.h:
3177         * DOM/DOMHTMLFieldSetElement.h:
3178         * DOM/DOMHTMLFontElement.h:
3179         * DOM/DOMHTMLFormElement.h:
3180         * DOM/DOMHTMLFrameElement.h:
3181         * DOM/DOMHTMLFrameSetElement.h:
3182         * DOM/DOMHTMLHRElement.h:
3183         * DOM/DOMHTMLHeadElement.h:
3184         * DOM/DOMHTMLHeadingElement.h:
3185         * DOM/DOMHTMLHtmlElement.h:
3186         * DOM/DOMHTMLIFrameElement.h:
3187         * DOM/DOMHTMLImageElement.h:
3188         * DOM/DOMHTMLInputElement.h:
3189         * DOM/DOMHTMLLIElement.h:
3190         * DOM/DOMHTMLLabelElement.h:
3191         * DOM/DOMHTMLLegendElement.h:
3192         * DOM/DOMHTMLLinkElement.h:
3193         * DOM/DOMHTMLMapElement.h:
3194         * DOM/DOMHTMLMarqueeElement.h:
3195         * DOM/DOMHTMLMediaElement.h:
3196         * DOM/DOMHTMLMenuElement.h:
3197         * DOM/DOMHTMLMetaElement.h:
3198         * DOM/DOMHTMLModElement.h:
3199         * DOM/DOMHTMLOListElement.h:
3200         * DOM/DOMHTMLObjectElement.h:
3201         * DOM/DOMHTMLOptGroupElement.h:
3202         * DOM/DOMHTMLOptionElement.h:
3203         * DOM/DOMHTMLOptionsCollection.h:
3204         * DOM/DOMHTMLParagraphElement.h:
3205         * DOM/DOMHTMLParamElement.h:
3206         * DOM/DOMHTMLPreElement.h:
3207         * DOM/DOMHTMLQuoteElement.h:
3208         * DOM/DOMHTMLScriptElement.h:
3209         * DOM/DOMHTMLSelectElement.h:
3210         * DOM/DOMHTMLStyleElement.h:
3211         * DOM/DOMHTMLTableCaptionElement.h:
3212         * DOM/DOMHTMLTableCellElement.h:
3213         * DOM/DOMHTMLTableColElement.h:
3214         * DOM/DOMHTMLTableElement.h:
3215         * DOM/DOMHTMLTableRowElement.h:
3216         * DOM/DOMHTMLTableSectionElement.h:
3217         * DOM/DOMHTMLTextAreaElement.h:
3218         * DOM/DOMHTMLTitleElement.h:
3219         * DOM/DOMHTMLUListElement.h:
3220         * DOM/DOMHTMLVideoElement.h:
3221         * DOM/DOMImplementation.h:
3222         * DOM/DOMKeyboardEvent.h:
3223         * DOM/DOMMediaError.h:
3224         * DOM/DOMMediaList.h:
3225         * DOM/DOMMouseEvent.h:
3226         * DOM/DOMMutationEvent.h:
3227         * DOM/DOMNamedNodeMap.h:
3228         * DOM/DOMNode.h:
3229         * DOM/DOMNodeFilter.h:
3230         * DOM/DOMNodeIterator.h:
3231         * DOM/DOMNodeList.h:
3232         * DOM/DOMObject.h:
3233         * DOM/DOMOverflowEvent.h:
3234         * DOM/DOMProcessingInstruction.h:
3235         * DOM/DOMProgressEvent.h:
3236         * DOM/DOMRGBColor.h:
3237         * DOM/DOMRange.h:
3238         * DOM/DOMRangeException.h:
3239         * DOM/DOMRect.h:
3240         * DOM/DOMStyleSheet.h:
3241         * DOM/DOMStyleSheetList.h:
3242         * DOM/DOMText.h:
3243         * DOM/DOMTextEvent.h:
3244         * DOM/DOMTimeRanges.h:
3245         * DOM/DOMTokenList.h:
3246         * DOM/DOMTreeWalker.h:
3247         * DOM/DOMUIEvent.h:
3248         * DOM/DOMWheelEvent.h:
3249         * DOM/DOMXPathException.h:
3250         * DOM/DOMXPathExpression.h:
3251         * DOM/DOMXPathNSResolver.h:
3252         * DOM/DOMXPathResult.h:
3253         * History/WebBackForwardList.h:
3254         * History/WebHistory.h:
3255         * History/WebHistoryItem.h:
3256         * Misc/WebDownload.h:
3257         * Misc/WebKitErrors.h:
3258         * Plugins/WebPluginViewFactory.h:
3259         * WebView/WebArchive.h:
3260         * WebView/WebDataSource.h:
3261         * WebView/WebDocument.h:
3262         * WebView/WebEditingDelegate.h:
3263         * WebView/WebFormDelegate.h:
3264         * WebView/WebFrame.h:
3265         * WebView/WebFrameLoadDelegate.h:
3266         * WebView/WebFrameView.h:
3267         * WebView/WebPolicyDelegate.h:
3268         * WebView/WebPreferences.h:
3269         * WebView/WebPreferencesPrivate.h:
3270         * WebView/WebResourceLoadDelegate.h:
3271         * WebView/WebUIDelegate.h:
3272         * WebView/WebUIDelegatePrivate.h:
3273         * WebView/WebView.h:
3274         * WebView/WebViewPrivate.h:
3275         * postprocess-headers.sh:
3276         Remove step that converts WEBKIT macros to NS macros.
3277         Change it to just remove the macros on iOS builds.
3278
3279 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
3280
3281         [MediaStream] remove WK1 support
3282         https://bugs.webkit.org/show_bug.cgi?id=185136
3283
3284         Reviewed by Youenn Fablet.
3285
3286         * WebCoreSupport/WebUserMediaClient.h: Removed.
3287         * WebCoreSupport/WebUserMediaClient.mm: Removed.
3288         * WebView/WebView.mm:
3289         (-[WebView _commonInitializationWithFrameName:groupName:]):
3290         (-[WebView _preferencesChanged:]):
3291         (-[WebView _setUserMediaClient:]): Deleted.
3292         (-[WebView _userMediaClient]): Deleted.
3293         * WebView/WebViewData.h:
3294         * WebView/WebViewPrivate.h:
3295
3296 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
3297
3298         WebAssembly: add support for stream APIs - JavaScript API
3299         https://bugs.webkit.org/show_bug.cgi?id=183442
3300
3301         Reviewed by Yusuke Suzuki and JF Bastien.
3302
3303         Add WEBASSEMBLY_STREAMINNG_API feature flag
3304
3305         * Configurations/FeatureDefines.xcconfig:
3306
3307 2018-04-30  JF Bastien  <jfbastien@apple.com>
3308
3309         Use some C++17 features
3310         https://bugs.webkit.org/show_bug.cgi?id=185135
3311
3312         Reviewed by Alex Christensen.
3313
3314         * Configurations/WebKitLegacy.xcconfig:
3315
3316 2018-04-27  Chris Dumez  <cdumez@apple.com>
3317
3318         Use WindowProxy instead of DOMWindow in our IDL
3319         https://bugs.webkit.org/show_bug.cgi?id=185022
3320
3321         Reviewed by Sam Weinig.
3322
3323         * DOM/DOMAbstractView.mm:
3324         (kit):
3325         (toWindowProxy):
3326         * DOM/DOMAbstractViewInternal.h:
3327         * DOM/DOMDocument.mm:
3328         (-[DOMDocument defaultView]):
3329         (-[DOMDocument getComputedStyle:pseudoElement:]):
3330         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
3331         * DOM/DOMHTMLFrameElement.mm:
3332         (-[DOMHTMLFrameElement contentWindow]):
3333         * DOM/DOMHTMLIFrameElement.mm:
3334         (-[DOMHTMLIFrameElement contentWindow]):
3335         * DOM/DOMKeyboardEvent.mm:
3336         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
3337         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
3338         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
3339         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
3340         * DOM/DOMMouseEvent.mm:
3341         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
3342         * DOM/DOMTextEvent.mm:
3343         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
3344         * DOM/DOMUIEvent.mm:
3345         (-[DOMUIEvent view]):
3346         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
3347         * DOM/DOMWheelEvent.mm:
3348         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
3349
3350 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
3351
3352         Implement rendering support for the color-filter CSS property
3353         https://bugs.webkit.org/show_bug.cgi?id=185047
3354         rdar://problem/39664967
3355
3356         Reviewed by Tim Horton.
3357         
3358         The body background should reflect the filtered color.
3359
3360         * WebView/WebFrame.mm:
3361         (-[WebFrame _bodyBackgroundColor]):
3362         * WebView/WebView.mm:
3363         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
3364
3365 2018-04-26  Jer Noble  <jer.noble@apple.com>
3366
3367         WK_COCOA_TOUCH all the things.
3368         https://bugs.webkit.org/show_bug.cgi?id=185006
3369
3370         Reviewed by Tim Horton.
3371
3372         * Configurations/WebKitLegacy.xcconfig:
3373
3374 2018-04-26  Daniel Bates  <dabates@apple.com>
3375
3376         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
3377         https://bugs.webkit.org/show_bug.cgi?id=184161
3378         <rdar://problem/39051645>
3379
3380         Reviewed by Dan Bernstein.
3381
3382         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
3383         dropping a PDF embedded using an HTML image element into the same web view.
3384
3385         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
3386         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
3387         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
3388         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
3389         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
3390         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
3391         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
3392         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
3393         image document when navigated to directly. Since we can support dragging PDF document images we need to
3394         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
3395         We need to do both such queries before falling back to using the main resource of the Web Archive as
3396         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
3397         not an image document.
3398
3399         * Misc/WebNSPasteboardExtras.mm:
3400         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
3401
3402 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
3403
3404         Disable content filtering in minimal simulator mode
3405         https://bugs.webkit.org/show_bug.cgi?id=185027
3406         <rdar://problem/39736091>
3407
3408         Reviewed by Jer Noble.
3409
3410         * Configurations/FeatureDefines.xcconfig:
3411
3412 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
3413
3414         [INTL] Implement Intl.PluralRules
3415         https://bugs.webkit.org/show_bug.cgi?id=184312
3416
3417         Reviewed by JF Bastien.
3418
3419         Added Intl.PluralRules feature flag.
3420
3421         * Configurations/FeatureDefines.xcconfig:
3422
3423 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
3424
3425         Remove access to keychain from the WebContent process
3426         https://bugs.webkit.org/show_bug.cgi?id=184428
3427         <rdar://problem/13150903>
3428
3429         Reviewed by Brent Fulgham.
3430
3431         This patch does the followings:
3432         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
3433         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
3434         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
3435
3436         * WebCoreSupport/WebChromeClient.h:
3437         * WebCoreSupport/WebChromeClient.mm:
3438         (WebChromeClient::signedPublicKeyAndChallengeString const):
3439         * WebView/WebUIDelegatePrivate.h:
3440
3441 2018-04-24  Jer Noble  <jer.noble@apple.com>
3442
3443         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
3444         https://bugs.webkit.org/show_bug.cgi?id=184786
3445
3446         Reviewed by Tim Horton.
3447
3448         * Configurations/WebKitLegacy.xcconfig:
3449         * MigrateHeaders.make:
3450
3451 2018-04-23  Daniel Bates  <dabates@apple.com>
3452
3453         Implement Same-Site cookies
3454         https://bugs.webkit.org/show_bug.cgi?id=159464
3455         <rdar://problem/27196358>
3456
3457         Reviewed by Brent Fulgham.
3458
3459         Pass the Same-Site info through the strategy.
3460
3461         * WebCoreSupport/WebPlatformStrategies.h:
3462         * WebCoreSupport/WebPlatformStrategies.mm:
3463         (WebPlatformStrategies::cookiesForDOM):
3464         (WebPlatformStrategies::setCookiesFromDOM):
3465         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3466         (WebPlatformStrategies::getRawCookies):
3467
3468 2018-04-23  Zalan Bujtas  <zalan@apple.com>
3469
3470         [LayoutFormattingContext] Initial commit.
3471         https://bugs.webkit.org/show_bug.cgi?id=184896
3472
3473         Reviewed by Antti Koivisto.
3474
3475         * Configurations/FeatureDefines.xcconfig:
3476
3477 2018-04-23  Daniel Bates  <dabates@apple.com>
3478
3479         Implement Same-Site cookies
3480         https://bugs.webkit.org/show_bug.cgi?id=159464
3481         <rdar://problem/27196358>
3482
3483         Reviewed by Brent Fulgham.
3484
3485         Pass the Same-Site info through the strategy.
3486
3487         * WebCoreSupport/WebPlatformStrategies.h:
3488         * WebCoreSupport/WebPlatformStrategies.mm:
3489         (WebPlatformStrategies::cookiesForDOM):
3490         (WebPlatformStrategies::setCookiesFromDOM):
3491         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3492         (WebPlatformStrategies::getRawCookies):
3493
3494 2018-04-20  Timothy Hatcher  <timothy@apple.com>
3495
3496         NULL dereference crash sometimes under [super initWithCoder:] in WebView
3497
3498         https://bugs.webkit.org/show_bug.cgi?id=184851
3499         rdar://problem/39611236
3500
3501         Reviewed by Tim Horton.
3502
3503         * WebView/WebView.mm:
3504         (-[WebView _commonInitializationWithFrameName:groupName:]):
3505         (-[WebView effectiveAppearanceDidChange]):
3506         Added a null check and call the code later in initialization.
3507
3508 2018-04-20  Tim Horton  <timothy_horton@apple.com>
3509
3510         Adjust geolocation feature flag
3511         https://bugs.webkit.org/show_bug.cgi?id=184856
3512
3513         Reviewed by Wenson Hsieh.
3514
3515         * Configurations/FeatureDefines.xcconfig:
3516
3517 2018-04-18  Jer Noble  <jer.noble@apple.com>
3518
3519         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
3520         https://bugs.webkit.org/show_bug.cgi?id=184762
3521
3522         Reviewed by Dan Bernstein.
3523
3524         * Configurations/WebKitLegacy.xcconfig:
3525
3526 2018-04-20  Youenn Fablet  <youenn@apple.com>
3527
3528         Make PluginData cache its web visible plugins
3529         https://bugs.webkit.org/show_bug.cgi?id=184421
3530
3531         Reviewed by Chris Dumez.
3532
3533         * WebCoreSupport/WebPluginInfoProvider.h:
3534         * WebCoreSupport/WebPluginInfoProvider.mm:
3535         (WebPluginInfoProvider::pluginInfo):
3536         (WebPluginInfoProvider::webVisiblePluginInfo):
3537
3538 2018-04-19  Chris Dumez  <cdumez@apple.com>
3539
3540         Rename JSDOMWindowProxy to JSWindowProxy
3541         https://bugs.webkit.org/show_bug.cgi?id=184797
3542
3543         Reviewed by Sam Weinig.
3544
3545         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
3546
3547         * DOM/DOMUtility.mm:
3548         (createDOMWrapper):
3549         * WebView/WebFrame.mm:
3550         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3551
3552 2018-04-19  David Kilzer  <ddkilzer@apple.com>
3553
3554         Enable Objective-C weak references
3555         <https://webkit.org/b/184789>
3556         <rdar://problem/39571716>
3557
3558         Reviewed by Dan Bernstein.
3559
3560         * Configurations/Base.xcconfig:
3561         (CLANG_ENABLE_OBJC_WEAK): Enable.
3562
3563 2018-04-18  Chris Dumez  <cdumez@apple.com>
3564
3565         Rename WindowProxyController to WindowProxy
3566         https://bugs.webkit.org/show_bug.cgi?id=184756
3567
3568         Reviewed by Sam Weinig.
3569
3570         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
3571         needed use WindowProxyController type, which was a bit confusing.
3572
3573         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3574         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3575         * WebView/WebFrame.mm:
3576         (-[WebFrame _attachScriptDebugger]):
3577
3578 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
3579
3580         Unreviewed rollout of r230632. Regression in memory usage.
3581
3582         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
3583
3584         * WebView/WebPreferences.mm:
3585         (+[WebPreferences initialize]):
3586
3587 2018-04-17  Chris Dumez  <cdumez@apple.com>
3588
3589         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
3590         https://bugs.webkit.org/show_bug.cgi?id=184678
3591         <rdar://problem/39422122>
3592
3593         Reviewed by Alex Christensen.
3594
3595         Add new parameter to dispatchDecidePolicyForNavigationAction.
3596
3597         * WebCoreSupport/WebFrameLoaderClient.h:
3598         * WebCoreSupport/WebFrameLoaderClient.mm:
3599         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3600
3601 2018-04-13  Chris Dumez  <cdumez@apple.com>
3602
3603         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
3604         https://bugs.webkit.org/show_bug.cgi?id=184591
3605
3606         Reviewed by Sam Weinig.
3607
3608         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
3609         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
3610         This is work towards fixing Bug 184515.
3611
3612         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3613         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3614         * WebView/WebFrame.mm:
3615         (-[WebFrame _attachScriptDebugger]):
3616
3617 2018-04-12  Antoine Quint  <graouts@apple.com>
3618
3619         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
3620         https://bugs.webkit.org/show_bug.cgi?id=184569
3621         <rdar://problem/38671301>
3622
3623         Reviewed by Jon Lee.
3624
3625         * WebView/WebPreferences.mm:
3626
3627 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3628
3629         [WTF] Remove StaticLock
3630         https://bugs.webkit.org/show_bug.cgi?id=184332
3631
3632         Reviewed by Mark Lam.
3633
3634         * DOM/DOMInternal.mm:
3635         (getDOMWrapper):
3636         (addDOMWrapper):
3637         (removeDOMWrapper):
3638
3639 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
3640
3641         Failures from mach port reference handling should be fatal
3642         https://bugs.webkit.org/show_bug.cgi?id=184202
3643         <rdar://problem/37771114>
3644
3645         Reviewed by Anders Carlsson.
3646
3647         * Plugins/Hosted/NetscapePluginHostManager.mm:
3648         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
3649
3650 2018-04-03  Andy Estes  <aestes@apple.com>
3651
3652         [Mac] Prioritize file promises over filenames during drag and drop
3653         https://bugs.webkit.org/show_bug.cgi?id=184237
3654         <rdar://problem/38278076>
3655
3656         Reviewed by Wenson Hsieh.
3657
3658         * WebView/WebView.mm:
3659         (-[WebView performDragOperation:]):
3660
3661 2018-04-03  Chris Dumez  <cdumez@apple.com>
3662
3663         Drop MainFrame class
3664         https://bugs.webkit.org/show_bug.cgi?id=184191
3665
3666         Reviewed by Darin Adler.
3667
3668         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
3669         relationship between the Page and the MainFrame.
3670
3671         This is ground work for introducing LocalFrame / RemoteFrame concepts.
3672
3673         * WebCoreSupport/WebDragClient.mm:
3674         * WebCoreSupport/WebFrameLoaderClient.mm:
3675         * WebCoreSupport/WebInspectorClient.mm:
3676         * WebCoreSupport/WebPlatformStrategies.mm:
3677         * WebCoreSupport/WebPluginInfoProvider.mm:
3678         * WebView/WebFrame.mm:
3679         * WebView/WebFrameView.mm:
3680         * WebView/WebHTMLView.mm:
3681         * WebView/WebView.mm:
3682
3683 2018-04-02  Jer Noble  <jer.noble@apple.com>
3684
3685         Enable Legacy EME for all WebKit & WebKitLegacy clients
3686         https://bugs.webkit.org/show_bug.cgi?id=184018
3687         <rdar://problem/34887387>
3688
3689         Reviewed by Eric Carlson.
3690
3691         * WebView/WebPreferences.mm:
3692         (+[WebPreferences initialize]):
3693
3694 2018-03-29  JF Bastien  <jfbastien@apple.com>
3695
3696         Use Forward.h instead of forward-declaring WTF::String
3697         https://bugs.webkit.org/show_bug.cgi?id=184172
3698         <rdar://problem/39026146>
3699
3700         Reviewed by Yusuke Suzuki.
3701
3702         As part of #184164 I'm changing WTF::String, and the forward
3703         declarations are just wrong because I'm making it templated. We
3704         should use Forward.h anyways, so do that instead.
3705
3706         * WebView/WebScriptDebugger.h:
3707
3708 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
3709
3710         Protect against invalid mach ports returned by mach_port_request_notification
3711         https://bugs.webkit.org/show_bug.cgi?id=184106
3712         <rdar://problem/37865316>
3713
3714         Reviewed by Chris Dumez.
3715
3716         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3717         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
3718         and clean up if it experienced an error.
3719         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
3720
3721 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
3722
3723         Avoid uninitialized mach ports
3724         https://bugs.webkit.org/show_bug.cgi?id=184090
3725         <rdar://problem/37261129>
3726
3727         Reviewed by Chris Dumez.
3728
3729         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
3730         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
3731         there is a potential for us to try to use invalid ports.
3732
3733         We should always check return values, and ensure that the mach port variables we seek to initialize are
3734         kept in a valid state.
3735
3736         Reviewed by Chris Dumez.
3737
3738         * Plugins/Hosted/NetscapePluginHostManager.h:
3739         * Plugins/Hosted/NetscapePluginHostManager.mm:
3740         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
3741         port is passed to an API function.
3742         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
3743         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
3744         * Plugins/Hosted/NetscapePluginHostProxy.h:
3745         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3746         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
3747         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
3748         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
3749         (WKPCStatusText): Ditto.
3750         (WKPCLoadURL): Ditto.
3751         (WKPCCancelLoadURL): Ditto.
3752         (WKPCInvalidateRect): Ditto.
3753         (WKPCGetScriptableNPObjectReply): Ditto.
3754         (WKPCBooleanReply): Ditto.
3755         (WKPCBooleanAndDataReply): Ditto.
3756         (WKPCInstantiatePluginReply): Ditto.
3757         (WKPCGetWindowNPObject): Ditto.
3758         (WKPCGetPluginElementNPObject): Ditto.
3759         (WKPCForgetBrowserObject): Ditto.
3760         (WKPCEvaluate): Ditto.
3761         (WKPCGetStringIdentifier): Ditto.
3762         (WKPCGetIntIdentifier): Ditto.
3763         (WKPCInvoke): Ditto.
3764         (WKPCInvokeDefault): Ditto.
3765         (WKPCConstruct): Ditto.
3766         (WKPCGetProperty): Ditto.
3767         (WKPCSetProperty): Ditto.
3768         (WKPCRemoveProperty): Ditto.
3769         (WKPCHasProperty): Ditto.
3770         (WKPCHasMethod): Ditto.
3771         (WKPCIdentifierInfo): Ditto.
3772         (WKPCEnumerate): Ditto.
3773         (WKPCSetMenuBarVisible): Ditto.
3774         (WKPCSetFullscreenWindowIsShowing): Ditto.
3775         (WKPCSetModal): Ditto.
3776         (WKPCGetCookies): Ditto.
3777         (WKPCGetProxy): Ditto.
3778         (WKPCSetCookies): Ditto.
3779         (WKPCGetAuthenticationInfo): Ditto.
3780         (WKPCConvertPoint): Ditto.
3781         (WKPCLayerHostingModeChanged): Ditto.
3782         (WKPCSetException): Ditto.
3783
3784 2018-03-26  Tim Horton  <timothy_horton@apple.com>
3785
3786         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
3787         https://bugs.webkit.org/show_bug.cgi?id=184030
3788         <rdar://problem/38895281>
3789
3790         Reviewed by Dan Bernstein.
3791
3792         * Configurations/Base.xcconfig:
3793
3794 2018-03-26  Chris Dumez  <cdumez@apple.com>
3795
3796         Use SecurityOriginData more consistently in Service Worker code
3797         https://bugs.webkit.org/show_bug.cgi?id=183969
3798
3799         Reviewed by Darin Adler.
3800
3801         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3802
3803         * Storage/WebDatabaseManager.mm:
3804         (-[WebDatabaseManager databasesWithOrigin:]):
3805         (-[WebDatabaseManager deleteOrigin:]):
3806         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3807         * Storage/WebDatabaseQuotaManager.mm:
3808         (-[WebDatabaseQuotaManager usage]):
3809         (-[WebDatabaseQuotaManager quota]):
3810         (-[WebDatabaseQuotaManager setQuota:]):
3811         * Storage/WebStorageManager.mm:
3812         (-[WebStorageManager deleteOrigin:]):
3813         * WebCoreSupport/WebSecurityOrigin.mm:
3814         (-[WebSecurityOrigin databaseIdentifier]):
3815         (-[WebSecurityOrigin usage]):
3816         (-[WebSecurityOrigin quota]):
3817         (-[WebSecurityOrigin setQuota:]):
3818
3819 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
3820
3821         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
3822         https://bugs.webkit.org/show_bug.cgi?id=183911
3823         <rdar://problem/38762306>
3824
3825         Reviewed by Youenn Fablet.
3826
3827         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
3828
3829         * WebView/WebView.mm:
3830         (+[WebView initialize]):
3831
3832 2018-03-26  Alex Christensen  <achristensen@webkit.org>
3833
3834         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
3835         https://bugs.webkit.org/show_bug.cgi?id=183965
3836
3837         Reviewed by Chris Dumez.
3838
3839         * WebCoreSupport/WebFrameLoaderClient.h:
3840         * WebCoreSupport/WebFrameLoaderClient.mm:
3841         (WebFrameLoaderClient::willCacheResponse const):
3842
3843 2018-03-25  Commit Queue  <commit-queue@webkit.org>
3844
3845         Unreviewed, rolling out r229954.
3846         https://bugs.webkit.org/show_bug.cgi?id=184000
3847
3848         Caused many layout tests to crash on Apple High Sierra,
3849         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
3850         by dydz on #webkit).
3851
3852         Reverted changeset:
3853
3854         "Use SecurityOriginData more consistently in Service Worker
3855         code"
3856         https://bugs.webkit.org/show_bug.cgi?id=183969
3857         https://trac.webkit.org/changeset/229954
3858
3859 2018-03-24  Chris Dumez  <cdumez@apple.com>
3860
3861         Use SecurityOriginData more consistently in Service Worker code
3862         https://bugs.webkit.org/show_bug.cgi?id=183969
3863
3864         Reviewed by Darin Adler.
3865
3866         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3867
3868         * Storage/WebDatabaseManager.mm:
3869         (-[WebDatabaseManager databasesWithOrigin:]):
3870         (-[WebDatabaseManager deleteOrigin:]):
3871         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3872         * Storage/WebDatabaseQuotaManager.mm:
3873         (-[WebDatabaseQuotaManager usage]):
3874         (-[WebDatabaseQuotaManager quota]):
3875         (-[WebDatabaseQuotaManager setQuota:]):
3876         * Storage/WebStorageManager.mm:
3877         (-[WebStorageManager deleteOrigin:]):
3878         * WebCoreSupport/WebSecurityOrigin.mm:
3879         (-[WebSecurityOrigin databaseIdentifier]):
3880         (-[WebSecurityOrigin usage]):
3881         (-[WebSecurityOrigin quota]):
3882         (-[WebSecurityOrigin setQuota:]):
3883
3884 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
3885
3886         Fix the build
3887
3888         * WebView/WebView.mm:
3889
3890 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3891
3892         Fix the build with no pasteboard
3893         https://bugs.webkit.org/show_bug.cgi?id=183973
3894
3895         Reviewed by Dan Bernstein.
3896
3897         * Configurations/FeatureDefines.xcconfig:
3898         * WebView/WebView.mm:
3899         (-[WebView _requestStartDataInteraction:globalPosition:]):
3900         (-[WebView _getDataInteractionData]):
3901         (-[WebView _dataOperationTextIndicator]):
3902         (-[WebView _dragSourceAction]):
3903         (-[WebView _draggedLinkTitle]):
3904         (-[WebView _draggedLinkURL]):
3905         (-[WebView _draggedElementBounds]):
3906         (-[WebView _enteredDataInteraction:client:global:operation:]):
3907         (-[WebView _updatedDataInteraction:client:global:operation:]):
3908         (-[WebView _exitedDataInteraction:client:global:operation:]):
3909         (-[WebView _performDataInteraction:client:global:operation:]):
3910         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3911         (-[WebView _endedDataInteraction:global:]):
3912         (-[WebView _dataInteractionCaretRect]):
3913         * WebView/WebViewPrivate.h:
3914
3915 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3916
3917         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
3918         https://bugs.webkit.org/show_bug.cgi?id=183960
3919         <rdar://problem/38812356>
3920
3921         Reviewed by Dan Bernstein.
3922
3923         * Configurations/WebKitLegacy.xcconfig:
3924
3925 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3926
3927         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
3928         https://bugs.webkit.org/show_bug.cgi?id=183954
3929         <rdar://problem/38808858>
3930
3931         Reviewed by Dan Bernstein.
3932
3933         * WebView/WebPreferences.mm:
3934         (-[WebPreferences setAudioSessionCategoryOverride:]):
3935
3936 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3937
3938         Adopt WK_PLATFORM_NAME in WebKitLegacy
3939         https://bugs.webkit.org/show_bug.cgi?id=183948
3940         <rdar://problem/38803908>
3941
3942         Reviewed by Dan Bernstein.
3943
3944         * Configurations/WebKitLegacy.xcconfig:
3945         * MigrateHeaders.make:
3946         * postprocess-headers.sh:
3947
3948 2018-03-23  Brady Eidson  <beidson@apple.com>
3949
3950         Go to back/forward list items after a process-swapped navigation.
3951         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
3952
3953         Reviewed by Andy Estes.
3954
3955         * WebView/WebView.mm:
3956         (-[WebView _loadBackForwardListFromOtherView:]):
3957         (-[WebView goToBackForwardItem:]):
3958
3959 2018-03-22  Tim Horton  <timothy_horton@apple.com>
3960
3961         Improve readability of WebCore's OTHER_LDFLAGS
3962         https://bugs.webkit.org/show_bug.cgi?id=183909
3963         <rdar://problem/38760992>
3964
3965         Reviewed by Dan Bernstein.
3966
3967         * Configurations/Base.xcconfig:
3968         * Configurations/FeatureDefines.xcconfig:
3969
3970 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3971
3972         Enable the minimal simulator feature flag when appropriate
3973         https://bugs.webkit.org/show_bug.cgi?id=183807
3974
3975         Reviewed by Dan Bernstein.
3976
3977         * Configurations/FeatureDefines.xcconfig:
3978
3979 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3980
3981         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
3982         https://bugs.webkit.org/show_bug.cgi?id=183758
3983         <rdar://problem/38017644>
3984
3985         Reviewed by Dan Bernstein.
3986
3987         * Configurations/FeatureDefines.xcconfig:
3988
3989 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
3990
3991         Clear style colors when setting default appearance
3992         https://bugs.webkit.org/show_bug.cgi?id=183759
3993
3994         Reviewed by Tim Horton.
3995
3996         Colors are cached and need to be cleared and recalculated.
3997         Refactor to do all style recalcs together.
3998
3999         * WebView/WebView.mm:
4000         (-[WebView _setDefaultAppearanceAndClearStyle]):
4001         (-[WebView _setUseSystemAppearance:]):
4002         (-[WebView effectiveAppearanceDidChange]):
4003
4004 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
4005
4006         Unreviewed, another quick fix for r229699
4007
4008         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
4009
4010         * Configurations/FeatureDefines.xcconfig:
4011
4012 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
4013
4014         Ensure that style is updated when the effective appearance changes
4015         https://bugs.webkit.org/show_bug.cgi?id=183690
4016         <rdar://problem/38385900>
4017
4018         Reviewed by Tim Horton and Wenson Hsieh.
4019
4020         Respond to and respect the effective appearance changing.
4021
4022         * WebView/WebView.mm:
4023         (-[WebView _setUseSystemAppearance:]):
4024         (-[WebView effectiveAppearanceDidChange]):
4025
4026 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
4027
4028         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
4029         https://bugs.webkit.org/show_bug.cgi?id=183677
4030
4031         Reviewed by Tim Horton.
4032
4033         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
4034
4035         * DOM/DOM.mm:
4036         (-[DOMHTMLLinkElement _mediaQueryMatches]):
4037
4038 2018-03-14  Tim Horton  <timothy_horton@apple.com>
4039
4040         Fix the build after r229567
4041
4042         * Configurations/FeatureDefines.xcconfig:
4043