Go to back/forward list items after a process-swapped navigation.
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-23  Brady Eidson  <beidson@apple.com>
2
3         Go to back/forward list items after a process-swapped navigation.
4         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
5
6         Reviewed by Andy Estes.
7
8         * WebView/WebView.mm:
9         (-[WebView _loadBackForwardListFromOtherView:]):
10         (-[WebView goToBackForwardItem:]):
11
12 2018-03-22  Tim Horton  <timothy_horton@apple.com>
13
14         Improve readability of WebCore's OTHER_LDFLAGS
15         https://bugs.webkit.org/show_bug.cgi?id=183909
16         <rdar://problem/38760992>
17
18         Reviewed by Dan Bernstein.
19
20         * Configurations/Base.xcconfig:
21         * Configurations/FeatureDefines.xcconfig:
22
23 2018-03-20  Tim Horton  <timothy_horton@apple.com>
24
25         Enable the minimal simulator feature flag when appropriate
26         https://bugs.webkit.org/show_bug.cgi?id=183807
27
28         Reviewed by Dan Bernstein.
29
30         * Configurations/FeatureDefines.xcconfig:
31
32 2018-03-20  Tim Horton  <timothy_horton@apple.com>
33
34         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
35         https://bugs.webkit.org/show_bug.cgi?id=183758
36         <rdar://problem/38017644>
37
38         Reviewed by Dan Bernstein.
39
40         * Configurations/FeatureDefines.xcconfig:
41
42 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
43
44         Clear style colors when setting default appearance
45         https://bugs.webkit.org/show_bug.cgi?id=183759
46
47         Reviewed by Tim Horton.
48
49         Colors are cached and need to be cleared and recalculated.
50         Refactor to do all style recalcs together.
51
52         * WebView/WebView.mm:
53         (-[WebView _setDefaultAppearanceAndClearStyle]):
54         (-[WebView _setUseSystemAppearance:]):
55         (-[WebView effectiveAppearanceDidChange]):
56
57 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
58
59         Unreviewed, another quick fix for r229699
60
61         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
62
63         * Configurations/FeatureDefines.xcconfig:
64
65 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
66
67         Ensure that style is updated when the effective appearance changes
68         https://bugs.webkit.org/show_bug.cgi?id=183690
69         <rdar://problem/38385900>
70
71         Reviewed by Tim Horton and Wenson Hsieh.
72
73         Respond to and respect the effective appearance changing.
74
75         * WebView/WebView.mm:
76         (-[WebView _setUseSystemAppearance:]):
77         (-[WebView effectiveAppearanceDidChange]):
78
79 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
80
81         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
82         https://bugs.webkit.org/show_bug.cgi?id=183677
83
84         Reviewed by Tim Horton.
85
86         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
87
88         * DOM/DOM.mm:
89         (-[DOMHTMLLinkElement _mediaQueryMatches]):
90
91 2018-03-14  Tim Horton  <timothy_horton@apple.com>
92
93         Fix the build after r229567
94
95         * Configurations/FeatureDefines.xcconfig:
96
97 2018-03-12  Tim Horton  <timothy_horton@apple.com>
98
99         Stop using SDK conditionals to control feature definitions
100         https://bugs.webkit.org/show_bug.cgi?id=183430
101         <rdar://problem/38251619>
102
103         Reviewed by Dan Bernstein.
104
105         * Configurations/FeatureDefines.xcconfig:
106         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
107
108 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
109
110         Runtime flag for link prefetch and remove link subresource.
111         https://bugs.webkit.org/show_bug.cgi?id=183540
112
113         Reviewed by Chris Dumez.
114
115         Remove the LINK_PREFETCH build time flag.
116
117         * Configurations/FeatureDefines.xcconfig:
118
119 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
120
121         Remove GridLayout runtime flag
122         https://bugs.webkit.org/show_bug.cgi?id=183484
123
124         Reviewed by Myles C. Maxfield.
125
126         The Grid Layout feature has been enabled by default for almost a
127         year, so I think it's time to remove the runtime flag and the
128
129         * WebView/WebPreferenceKeysPrivate.h:
130         * WebView/WebPreferences.mm:
131         (+[WebPreferences initialize]):
132         * WebView/WebPreferencesPrivate.h:
133         * WebView/WebView.mm:
134         (-[WebView _preferencesChanged:]):
135
136 2018-03-12  Antoine Quint  <graouts@apple.com>
137
138         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
139         https://bugs.webkit.org/show_bug.cgi?id=183504
140         <rdar://problem/38372965>
141
142         Reviewed by Dean Jackson and Jon Lee.
143
144         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
145         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
146
147         * WebView/WebPreferenceKeysPrivate.h:
148         * WebView/WebPreferences.mm:
149         (+[WebPreferences initialize]):
150         (-[WebPreferences setModernMediaControlsEnabled:]):
151         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
152         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
153         * WebView/WebPreferencesPrivate.h:
154         * WebView/WebView.mm:
155         (-[WebView _preferencesChanged:]):
156
157 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
158
159         Media query for default appearance
160         https://bugs.webkit.org/show_bug.cgi?id=183539
161         <rdar://problem/38326388>
162
163         Reviewed by Tim Horton.
164
165         Write a media query to evaluate appearance.
166
167         * WebView/WebView.mm:
168         (-[WebView _commonInitializationWithFrameName:groupName:]):
169         (-[WebView _setUseSystemAppearance:]):
170
171 2018-03-09  Andy Estes  <aestes@apple.com>
172
173         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
174         https://bugs.webkit.org/show_bug.cgi?id=183489
175         <rdar://problem/38267517>
176
177         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
178         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
179         to issue a sandbox extension for this directory, but for security reasons App Sandbox
180         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
181         block with a nil error and a valid file URL, but no file will actually exist at that URL.
182
183         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
184         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
185         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
186         drop destination.
187
188         Reviewed by Wenson Hsieh.
189
190         * WebView/WebView.mm:
191         (-[WebView performDragOperation:]):
192
193 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
194
195         Allow WebViews to disable system appearance
196         https://bugs.webkit.org/show_bug.cgi?id=183418
197         <rdar://problem/36975642>
198
199         Reviewed by Tim Horton.
200
201         Allow webviews to choose whether or not to follow the default system appearance.
202
203         * WebView/WebView.mm:
204         (-[WebView _setUseSystemAppearance:]):
205         (-[WebView _useSystemAppearance]):
206         * WebView/WebViewPrivate.h:
207
208 2018-03-08  Youenn Fablet  <youenn@apple.com>
209
210         libwebrtc update broke internal builds
211         https://bugs.webkit.org/show_bug.cgi?id=183454
212
213         Reviewed by Eric Carlson.
214
215         * Configurations/WebKitLegacy.xcconfig:
216
217 2018-03-08  Chris Dumez  <cdumez@apple.com>
218
219         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
220         https://bugs.webkit.org/show_bug.cgi?id=183455
221         <rdar://problem/38191749>
222
223         Reviewed by Youenn Fablet.
224
225         Add a null check for the page as we have evidence from crashes that it can be null.
226         Other functions in WebFrameNetworkingContext already null check the page as well,
227         not just the frame so this is consistent.
228
229         * WebCoreSupport/WebFrameNetworkingContext.mm:
230         (WebFrameNetworkingContext::storageSession const):
231
232 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
233
234         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
235         https://bugs.webkit.org/show_bug.cgi?id=183429
236
237         Reviewed by Mark Lam.
238
239         * DOM/DOM.mm:
240         (+[DOMNode _nodeFromJSWrapper:]):
241         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
242         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
243         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
244         * Plugins/Hosted/ProxyInstance.mm:
245         (WebKit::ProxyInstance::invokeMethod):
246         * WebView/WebView.mm:
247         (aeDescFromJSValue):
248
249 2018-03-08  Tim Horton  <timothy_horton@apple.com>
250
251         Stop linking ApplicationServices directly
252         https://bugs.webkit.org/show_bug.cgi?id=182867
253         <rdar://problem/38252142>
254
255         Reviewed by Alex Christensen.
256
257         The frameworks that we use that live inside ApplicationServices
258         have mostly moved out, so import them directly.
259
260         * Carbon/CarbonUtils.h:
261         * WebKitPrefix.h:
262         * WebView/WebHTMLView.mm:
263         * WebView/WebPDFView.mm:
264
265 2018-03-07  Tim Horton  <timothy_horton@apple.com>
266
267         Sort and separate FeatureDefines.xcconfig
268         https://bugs.webkit.org/show_bug.cgi?id=183427
269
270         Reviewed by Dan Bernstein.
271
272         * Configurations/FeatureDefines.xcconfig:
273         Sort and split FeatureDefines into paragraphs
274         (to make it easier to sort later).
275
276 2018-03-07  Youenn Fablet  <youenn@apple.com>
277
278         Match unsupported plugins based on domains and not origin
279         https://bugs.webkit.org/show_bug.cgi?id=183384
280
281         Reviewed by Chris Dumez.
282
283         * WebCoreSupport/WebPluginInfoProvider.h:
284         * WebCoreSupport/WebPluginInfoProvider.mm:
285         (WebPluginInfoProvider::getPluginInfo):
286         (WebPluginInfoProvider::getWebVisiblePluginInfo):
287
288 2018-03-05  Andy Estes  <aestes@apple.com>
289
290         [Mac] Teach WebCore::Pasteboard about file promise drags
291         https://bugs.webkit.org/show_bug.cgi?id=183314
292         <rdar://problem/38105493>
293
294         Reviewed by Darin Adler.
295
296         Added a FIXME comment.
297
298         * WebView/WebView.mm:
299         (-[WebView performDragOperation:]):
300
301 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
302
303         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
304         https://bugs.webkit.org/show_bug.cgi?id=183312
305
306         Reviewed by Mark Lam.
307
308         Remove wtf/CurrentTime.h include pragma.
309
310         * WebView/WebFrame.mm:
311         * WebView/WebPDFView.mm:
312
313 2018-03-04  Tim Horton  <timothy_horton@apple.com>
314
315         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
316         https://bugs.webkit.org/show_bug.cgi?id=183283
317         <rdar://problem/38062148>
318
319         Reviewed by Sam Weinig.
320
321         * Configurations/FeatureDefines.xcconfig:
322
323 2018-02-28  Alex Christensen  <achristensen@webkit.org>
324
325         Reduce use of NetworkingContext in WebKit
326         https://bugs.webkit.org/show_bug.cgi?id=183213
327
328         Reviewed by Brady Eidson.
329
330         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
331         (WebKit::NetscapePluginInstanceProxy::getProxy):
332         * Plugins/WebNetscapePluginView.mm:
333         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
334
335 2018-02-17  Darin Adler  <darin@apple.com>
336
337         Prepare for ExtendedColor changes (first step)
338         https://bugs.webkit.org/show_bug.cgi?id=182904
339
340         Reviewed by Sam Weinig.
341
342         * Misc/WebKitNSStringExtras.mm:
343         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
344
345 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
346
347         Remove currentTime() / currentTimeMS()
348         https://bugs.webkit.org/show_bug.cgi?id=183052
349
350         Reviewed by Mark Lam.
351
352         * WebCoreSupport/WebFrameLoaderClient.h:
353         * WebCoreSupport/WebFrameLoaderClient.mm:
354         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
355
356 2018-02-16  Youenn Fablet  <youenn@apple.com>
357
358         Allow specifying which plug-ins are supported
359         https://bugs.webkit.org/show_bug.cgi?id=182748
360
361         Reviewed by Chris Dumez.
362
363         * WebCoreSupport/WebPluginInfoProvider.h:
364         * WebCoreSupport/WebPluginInfoProvider.mm:
365         (WebPluginInfoProvider::getPluginInfo):
366         (WebPluginInfoProvider::getWebVisiblePluginInfo):
367
368 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
369
370         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
371         https://bugs.webkit.org/show_bug.cgi?id=182882
372         <rdar://problem/35672661>
373
374         Reviewed by Dan Bernstein.
375
376         Make sure the smart pointer hold the collection of subviews lives at least as
377         long as the loop using it.
378
379         * WebView/WebHTMLView.mm:
380         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
381
382 2018-02-14  Daniel Bates  <dabates@apple.com>
383
384         Disallow cross-origin subresources from asking for credentials
385         https://bugs.webkit.org/show_bug.cgi?id=182579
386         <rdar://problem/36162271>
387
388         Reviewed by Andy Estes.
389
390         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
391         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
392
393         * WebView/WebPreferenceKeysPrivate.h:
394         * WebView/WebPreferences.mm:
395         (+[WebPreferences initialize]):
396         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
397         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
398         * WebView/WebPreferencesPrivate.h:
399         * WebView/WebView.mm:
400         (-[WebView _preferencesChanged:]):
401
402 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
403
404         Remove ForwardingHeaders directory from WebKitLegacy/mac.
405         https://bugs.webkit.org/show_bug.cgi?id=182738
406
407         Reviewed by Darin Adler.
408
409         * ForwardingHeaders/collector/handles/Global.h: Removed.
410         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
411         * ForwardingHeaders/runtime/Completion.h: Removed.
412         * ForwardingHeaders/runtime/Error.h: Removed.
413         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
414         * ForwardingHeaders/runtime/JSFunction.h: Removed.
415         * ForwardingHeaders/runtime/JSLock.h: Removed.
416         * ForwardingHeaders/runtime/JSObject.h: Removed.
417         * ForwardingHeaders/runtime/JSString.h: Removed.
418         * ForwardingHeaders/runtime/Protect.h: Removed.
419         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
420
421 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
422
423         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
424         https://bugs.webkit.org/show_bug.cgi?id=182641
425
426         Reviewed by Dan Bernstein.
427
428         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
429         https://trac.webkit.org/changeset/228308.
430
431         * WebView/WebVideoFullscreenController.h:
432         * WebView/WebVideoFullscreenHUDWindowController.mm:
433         * WebView/WebWindowAnimation.h:
434         * WebView/WebWindowAnimation.mm:
435         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
436         (WebCore::scaledRect): Deleted.
437         (WebCore::squaredDistance): Deleted.
438
439 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
440
441         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
442
443         * WebView/WebWindowAnimation.mm:
444         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
445
446 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
447
448         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
449         https://bugs.webkit.org/show_bug.cgi?id=182615
450
451         Reviewed by Eric Carlson.
452
453         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
454         Ideally, we should not reference NSApp in WebCore.
455
456         * WebView/WebFullScreenController.mm:
457         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
458         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
459         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
460         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
461         * WebView/WebView.mm:
462         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
463         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
464
465 2018-01-13  Darin Adler  <darin@apple.com>
466
467         Event improvements
468         https://bugs.webkit.org/show_bug.cgi?id=179591
469
470         Reviewed by Chris Dumez.
471
472         * DOM/DOMWheelEvent.mm:
473         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
474         Call initWebKitWheelEvent.
475
476         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
477         * WebCoreSupport/WebInspectorClient.mm: Ditto.
478         * WebView/WebFrame.mm: Ditto.
479
480         * WebView/WebHTMLView.mm:
481         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
482         underlyingPlatformEvent.
483         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
484
485         * WebView/WebScriptWorld.mm:
486         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
487
488         * WebView/WebView.mm: Removed include of ScriptValue.h.
489
490 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
491
492         Remove WebCore/ForwardingHeaders directory
493         https://bugs.webkit.org/show_bug.cgi?id=182347
494
495         Reviewed by Keith Miller.
496
497         * Carbon/CarbonWindowAdapter.mm:
498         * DOM/WebDOMOperations.mm:
499         * History/WebBackForwardList.mm:
500         * History/WebHistoryItem.mm:
501         * Misc/WebCache.mm:
502         * Misc/WebElementDictionary.mm:
503         * Misc/WebIconDatabase.mm:
504         * Misc/WebStringTruncator.mm:
505         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
506         * Plugins/Hosted/ProxyInstance.mm:
507         * Plugins/Hosted/ProxyRuntimeObject.mm:
508         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
509         * Plugins/WebBaseNetscapePluginView.mm:
510         * Plugins/WebBasePluginPackage.mm:
511         * Plugins/WebNetscapePluginStream.mm:
512         * Plugins/WebNetscapePluginView.mm:
513         * Plugins/WebPluginController.mm:
514         * WebCoreSupport/WebEditorClient.mm:
515         * WebCoreSupport/WebFrameLoaderClient.mm:
516         * WebCoreSupport/WebInspectorClient.h:
517         * WebCoreSupport/WebInspectorClient.mm:
518         * WebView/WebDataSource.mm:
519         * WebView/WebFrame.mm:
520         * WebView/WebHTMLRepresentation.mm:
521         * WebView/WebHTMLView.mm:
522         * WebView/WebPreferences.mm:
523         * WebView/WebScriptDebugDelegate.mm:
524         * WebView/WebScriptDebugger.h:
525         * WebView/WebTextIterator.mm:
526         * WebView/WebView.mm:
527         * WebView/WebViewData.mm:
528
529 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
530
531         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
532         https://bugs.webkit.org/show_bug.cgi?id=182312
533
534         Reviewed by Michael Catanzaro.
535
536         * WebKitPrefix.h:
537
538 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
539
540         [WebAuthN] Add a compile-time feature flag
541         https://bugs.webkit.org/show_bug.cgi?id=182211
542         <rdar://problem/36936365>
543
544         Reviewed by Brent Fulgham.
545
546         * Configurations/FeatureDefines.xcconfig:
547
548 2018-01-27  Dan Bernstein  <mitz@apple.com>
549
550         HaveInternalSDK includes should be "#include?"
551         https://bugs.webkit.org/show_bug.cgi?id=179670
552
553         * Configurations/Base.xcconfig:
554
555 2018-01-24  Alex Christensen  <achristensen@webkit.org>
556
557         Remove unused QTKit preference
558         https://bugs.webkit.org/show_bug.cgi?id=181968
559
560         Reviewed by Alexey Proskuryakov.
561
562         * WebView/WebPreferenceKeysPrivate.h:
563         * WebView/WebPreferences.mm:
564         (+[WebPreferences initialize]):
565         (-[WebPreferences setQTKitEnabled:]): Deleted.
566         (-[WebPreferences isQTKitEnabled]): Deleted.
567         * WebView/WebPreferencesPrivate.h:
568         * WebView/WebView.mm:
569         (-[WebView _preferencesChanged:]):
570
571 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
572
573         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
574         https://bugs.webkit.org/show_bug.cgi?id=182037
575         <rdar://problem/36747812>
576
577         Reviewed by Ryosuke Niwa.
578
579         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
580         for more details.
581
582         * WebView/WebHTMLRepresentation.mm:
583         (-[WebHTMLRepresentation elementWithName:inForm:]):
584         (-[WebHTMLRepresentation controlsInForm:]):
585
586 2018-01-23  Alex Christensen  <achristensen@webkit.org>
587
588         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
589         https://bugs.webkit.org/show_bug.cgi?id=181961
590
591         Reviewed by Michael Catanzaro.
592
593         * WebView/WebPreferences.mm:
594
595 2018-01-23  Commit Queue  <commit-queue@webkit.org>
596
597         Unreviewed, rolling out r227437.
598         https://bugs.webkit.org/show_bug.cgi?id=182011
599
600         broke build (Requested by alexchristensen on #webkit).
601
602         Reverted changeset:
603
604         "Remove unused QTKit preference"
605         https://bugs.webkit.org/show_bug.cgi?id=181968
606         https://trac.webkit.org/changeset/227437
607
608 2018-01-23  Alex Christensen  <achristensen@webkit.org>
609
610         Remove unused QTKit preference
611         https://bugs.webkit.org/show_bug.cgi?id=181968
612
613         Reviewed by Alexey Proskuryakov.
614
615         * WebView/WebPreferenceKeysPrivate.h:
616         * WebView/WebPreferences.mm:
617         (+[WebPreferences initialize]):
618         (-[WebPreferences setQTKitEnabled:]): Deleted.
619         (-[WebPreferences isQTKitEnabled]): Deleted.
620         * WebView/WebPreferencesPrivate.h:
621         * WebView/WebView.mm:
622         (-[WebView _preferencesChanged:]):
623
624 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
625
626         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
627         https://bugs.webkit.org/show_bug.cgi?id=181960
628         <rdar://problem/36431678>
629
630         Reviewed by Tim Horton.
631
632         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
633         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
634         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
635
636         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
637         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
638         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
639
640         * WebView/WebView.mm:
641         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
642
643 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
644
645         Turning off custom pasteboard data doesn't actually turn it off in WK2
646         https://bugs.webkit.org/show_bug.cgi?id=181920
647         <rdar://problem/36686429>
648
649         Reviewed by Wenson Hsieh.
650
651         Always disable custom pasteboard data in WebKit1. See r226156 for details.
652
653         * WebView/WebPreferences.mm:
654         (+[WebPreferences initialize]):
655         * WebView/WebView.mm:
656         (-[WebView _preferencesChanged:]):
657
658 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
659
660         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
661         https://bugs.webkit.org/show_bug.cgi?id=181918
662
663         Reviewed by Tim Horton.
664
665         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
666
667         * Configurations/FeatureDefines.xcconfig:
668
669 2018-01-20  Andy Estes  <aestes@apple.com>
670
671         [Apple Pay] Stop eagerly loading PassKit.framework
672         https://bugs.webkit.org/show_bug.cgi?id=181911
673         <rdar://problem/36555369>
674
675         Reviewed by Tim Horton.
676
677         * WebCoreSupport/WebPaymentCoordinatorClient.h:
678         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
679         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
680
681         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
682
683 2018-01-19  Dean Jackson  <dino@apple.com>
684
685         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
686         https://bugs.webkit.org/show_bug.cgi?id=181817
687         <rdar://problem/35274055>
688
689         Reviewed by Simon Fraser.
690
691         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
692
693         * Misc/WebKitVersionChecks.h:
694         * WebView/WebView.mm:
695         (-[WebView _commonInitializationWithFrameName:groupName:]):
696
697 2018-01-19  Alex Christensen  <achristensen@webkit.org>
698
699         Remove unused WebViewPrivate _allowCookies
700         https://bugs.webkit.org/show_bug.cgi?id=181812
701
702         Reviewed by Tim Horton.
703
704         * WebView/WebView.mm:
705         (+[WebView _setAllowCookies:]): Deleted.
706         (+[WebView _allowCookies]): Deleted.
707         * WebView/WebViewPrivate.h:
708
709 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
710
711         Build fix, remove a call to -[NSWindow setOneShot:]
712         https://bugs.webkit.org/show_bug.cgi?id=181809
713
714         Reviewed by Tim Horton.
715
716         * WebView/WebTextCompletionController.mm:
717         (-[WebTextCompletionController _buildUI]):
718
719 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
720
721         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
722
723         * Carbon/HIWebView.mm:
724         (overrideCGContext):
725         (restoreCGContext):
726
727 2018-01-18  Dan Bernstein  <mitz@apple.com>
728
729         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
730         https://bugs.webkit.org/show_bug.cgi?id=181803
731
732         Reviewed by Tim Horton.
733
734         * Configurations/Base.xcconfig: Updated.
735         * Configurations/DebugRelease.xcconfig: Ditto.
736         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
737         * Configurations/Version.xcconfig: Updated.
738         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
739           useful for defining settings that depend on the target macOS version.
740
741 2018-01-17  Youenn Fablet  <youenn@apple.com>
742
743         Put fetch Request.keepalive behind a runtime flag
744         https://bugs.webkit.org/show_bug.cgi?id=181592
745
746         Reviewed by Chris Dumez.
747
748         * WebView/WebPreferenceKeysPrivate.h:
749         * WebView/WebPreferences.mm:
750         (+[WebPreferences initialize]):
751         (-[WebPreferences fetchAPIKeepAliveEnabled]):
752         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
753         * WebView/WebPreferencesPrivate.h:
754         * WebView/WebView.mm:
755         (-[WebView _preferencesChanged:]):
756
757 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
758
759         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
760         https://bugs.webkit.org/show_bug.cgi?id=181637
761         <rdar://problem/36508471>
762
763         Reviewed by Tim Horton.
764
765         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
766
767         * WebCoreSupport/WebEditorClient.h:
768         * WebCoreSupport/WebEditorClient.mm:
769         (WebEditorClient::replacementURLForResource):
770
771 2018-01-11  Keith Miller  <keith_miller@apple.com>
772
773         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
774         https://bugs.webkit.org/show_bug.cgi?id=181573
775
776         Reviewed by Simon Fraser.
777
778         * Configurations/FeatureDefines.xcconfig:
779
780 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
781
782         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
783         https://bugs.webkit.org/show_bug.cgi?id=181497
784
785         Reviewed by Tim Horton.
786
787         See other ChangeLogs for more detail.
788
789         * WebCoreSupport/WebDragClient.h:
790
791 2018-01-11  Tim Horton  <timothy_horton@apple.com>
792
793         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
794         https://bugs.webkit.org/show_bug.cgi?id=181523
795         <rdar://problem/28959131>
796
797         Reviewed by Alex Christensen.
798
799         * WebView/WebImmediateActionController.mm:
800         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
801         Apply the change made in r216652 to WebKit1's immediate action controller.
802
803         Speculative (but successful in WebKit2) fix for non-reproducible crash when
804         the startContainer of the range is in an anonymous node.
805
806 2018-01-11  Youenn Fablet  <youenn@apple.com>
807
808         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
809         https://bugs.webkit.org/show_bug.cgi?id=181480
810
811         Reviewed by Eric Carlson.
812
813         * WebView/WebPreferences.mm:
814         (+[WebPreferences initialize]):
815
816 2018-01-08  David Kilzer  <ddkilzer@apple.com>
817
818         Fix check-webkit-style issues with WebNSDataExtras.mm
819         <https://webkit.org/b/181369>
820
821         Reviewed by Alex Christensen.
822
823         * Misc/WebNSDataExtras.mm:
824         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
825         (-[NSData _webkit_guessedMIMETypeForXML]):
826         (-[NSData _webkit_guessedMIMEType]):
827         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
828         (_findEOL):
829         (-[NSData _webkit_parseRFC822HeaderFields]):
830         (-[NSData _web_locationAfterFirstBlankLine]):
831         - Fix all the check-webkit-style warnings.
832
833 2018-01-08  David Kilzer  <ddkilzer@apple.com>
834
835         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
836         <https://webkit.org/b/181256>
837         <rdar://problem/36281730>
838
839         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
840         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
841         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
842           to avoid warnings from casting CFStringRef to NPNSString*.
843           Note that CFMutableStringRef is the same as CFStringRef
844           without the const modifier, hence its use in the const_cast<>
845           above.
846
847 2018-01-08  David Kilzer  <ddkilzer@apple.com>
848
849         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
850         <https://webkit.org/b/181256>
851         <rdar://problem/36281730>
852
853         * Carbon/HIWebView.mm:
854         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
855         checked_cf_cast<CFRunLoopRef>() to fix warning.
856
857 2018-01-07  David Kilzer  <ddkilzer@apple.com>
858
859         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
860         <https://webkit.org/b/181256>
861         <rdar://problem/36281730>
862
863         Reviewed by Darin Adler.
864
865         * Carbon/CarbonUtils.m:
866         (PoolCleaner):
867         - Use #pragmas to ignore -Wcast-qual warnings when using a
868           C-style cast from CFTypeRef to CFRunloopRef.
869         * Carbon/CarbonWindowFrame.m:
870         (-[CarbonWindowFrame title]):
871         - Use #pragmas to ignore -Wcast-qual warnings when using a
872           C-style cast from CFStringRef to NSString *.
873         * Carbon/HIViewAdapter.m:
874         (+[HIViewAdapter getHIViewForNSView:]):
875         - Use #pragmas to ignore -Wcast-qual warnings when using a
876           C-style cast from CFTypeRef to HIViewRef.
877         * Configurations/Base.xcconfig:
878         (WARNING_CFLAGS): Add -Wcast-qual.
879         * Misc/WebElementDictionary.mm:
880         (-[WebElementDictionary objectForKey:]):
881         - Use static_cast<SEL>(const_cast<void*>()) to fix
882           warning.
883         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
884         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
885         (-[NSData _webkit_guessedMIMETypeForXML]):
886         (-[NSData _webkit_guessedMIMEType]):
887         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
888         (_findEOL):
889         (-[NSData _webkit_parseRFC822HeaderFields]):
890         (-[NSData _web_startsWithBlankLine]):
891         (-[NSData _web_locationAfterFirstBlankLine]):
892         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
893           type to Objective-C++.  This fixes the warnings about
894           discarding the `const` modifier when casing from CFStringRef
895           to NSString * because in older clang versions, -Wcast-qual was
896           completely broken when compiling C++ and Objective-C++ source
897           files.  In newer clang versions, discarding the `const`
898           modifier for toll-free bridged types is ignored when compiling
899           Objective-C++ source.
900         - Update copyright and license header.
901         - Use reinterpret_cast<> and static_cast<> to fix warnings
902           unrelated to (NSString *) C-style casts.
903         - Replace use of MIN() macro with std::min<> template functions.
904         - Fix location of `*` for local variables modified above.
905         * Plugins/Hosted/NetscapePluginHostManager.mm:
906         (WebKit::NetscapePluginHostManager::spawnPluginHost):
907         (WebKit::NetscapePluginHostManager::initializeVendorPort):
908         (WebKit::NetscapePluginHostManager::instantiatePlugin):
909         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
910           warnings.
911         * Plugins/Hosted/NetscapePluginHostProxy.mm:
912         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
913         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
914           to fix warning.
915         * Plugins/Hosted/ProxyInstance.mm:
916         (WebKit::ProxyInstance::invoke):
917         - Use static_cast<char*>(const_cast<void*>()) to fix
918           warning when using -[NSData bytes].
919         (WebKit::ProxyInstance::fieldValue const):
920         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
921           to fix warning when using CFDataGetBytePtr().
922         * Plugins/Hosted/WebTextInputWindowController.m:
923         (-[WebTextInputPanel _interpretKeyEvent:string:]):
924         - Use #pragma to ignore -Wcast-qual warning since there
925           is not a good way to avoid this warning in Objective-C.
926         * Plugins/WebNetscapePluginStream.mm:
927         (WebNetscapePluginStream::deliverData):
928         - Use const_cast<void*>() to fix warning when using
929           -[NSData bytes].
930         * Plugins/WebNetscapePluginView.mm:
931         (-[WebNetscapePluginView _createPlugin]):
932         - Change C-style cast to const_cast<char*>() to fix
933           warning.
934         * WebCoreSupport/WebChromeClient.mm:
935         (WebChromeClient::wrapCryptoKey const):
936         (WebChromeClient::unwrapCryptoKey const):
937         - Change C-style cast to
938           static_cast<uint8_t*>(const_cast<void*>() to fix
939           warning.
940         * WebView/WebPDFView.mm:
941         (_applicationInfoForMIMEType):
942         - Change local variable type from 'NSURL *' to
943           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
944           when calling -[NSURL path].
945
946 2018-01-05  Dan Bernstein  <mitz@apple.com>
947
948         Fixed the build following AppKit API deprecations in a recent SDKs
949
950         * WebView/WebFullScreenController.mm:
951         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
952         (-[WebFullScreenController exitFullScreen]): Ditto.
953         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
954         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
955         * WebView/WebHTMLView.mm:
956         (-[WebHTMLView drawRect:]): Ditto.
957         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
958         (-[WebHTMLView knowsPageRange:]): Ditto.
959         * WebView/WebView.mm:
960         (LayerFlushController::flushLayers): Ditto.
961
962 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
963
964         [Attachment Support] Create attachment elements when dropping files on iOS
965         https://bugs.webkit.org/show_bug.cgi?id=181192
966         <rdar://problem/36280945>
967
968         Reviewed by Tim Horton.
969
970         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
971
972         * WebCoreSupport/WebPlatformStrategies.h:
973         * WebCoreSupport/WebPlatformStrategies.mm:
974         (WebPlatformStrategies::informationForItemAtIndex):
975         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
976
977 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
978
979         [Attachment Support] Add plumbing for starting a drag with promised blob data
980         https://bugs.webkit.org/show_bug.cgi?id=181201
981
982         Reviewed by Tim Horton.
983
984         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
985
986         * WebCoreSupport/WebDragClient.h:
987
988 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
989
990         Add a WebAuthentication runtime feature flag
991         https://bugs.webkit.org/show_bug.cgi?id=181220
992         <rdar://problem/36055305>
993
994         Reviewed by Brent Fulgham.
995
996         Renames the CredentialManagement runtime feature flag into WebAuthentication.
997
998         * WebView/WebPreferenceKeysPrivate.h:
999         * WebView/WebPreferences.mm:
1000         (+[WebPreferences initialize]):
1001         (-[WebPreferences webAuthenticationEnabled]):
1002         (-[WebPreferences setWebAuthenticationEnabled:]):
1003         (-[WebPreferences credentialManagementEnabled]): Deleted.
1004         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1005         * WebView/WebPreferencesPrivate.h:
1006         * WebView/WebView.mm:
1007         (-[WebView _preferencesChanged:]):
1008
1009 2017-12-22  Jeff Miller  <jeffm@apple.com>
1010
1011         Update user-visible copyright strings to include 2018
1012         https://bugs.webkit.org/show_bug.cgi?id=181141
1013
1014         Reviewed by Dan Bernstein.
1015
1016         * Info.plist:
1017
1018 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1019
1020         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1021         https://bugs.webkit.org/show_bug.cgi?id=181188
1022
1023         Reviewed by Dan Bernstein.
1024
1025         See WebCore/ChangeLog for more detail.
1026
1027         * WebCoreSupport/WebDragClient.h:
1028         * WebCoreSupport/WebDragClient.mm:
1029         (WebDragClient::declareAndWriteAttachment): Deleted.
1030         * WebView/WebHTMLView.mm:
1031         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1032
1033 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1034
1035         Unreviewed, continue to fix build failures due to AppKit API deprecation
1036
1037         Wraps more code in -Wdeprecated-declarations.
1038
1039         * Carbon/HIWebView.mm:
1040         (overrideCGContext):
1041
1042 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1043
1044         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1045
1046         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1047
1048         * Carbon/CarbonWindowAdapter.mm:
1049         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1050         * Plugins/WebNetscapePluginView.mm:
1051         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1052         (-[WebNetscapePluginView sendDrawRectEvent:]):
1053         (-[WebNetscapePluginView drawRect:]):
1054
1055 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1056
1057         Fix build failures due to using deprecated AppKit symbols
1058         https://bugs.webkit.org/show_bug.cgi?id=181110
1059         <rdar://problem/36162865>
1060
1061         Reviewed by Dan Bernstein and Tim Horton.
1062
1063         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1064
1065         * Misc/WebKitNSStringExtras.mm:
1066         (-[NSString _web_drawAtPoint:font:textColor:]):
1067         * Misc/WebNSPasteboardExtras.h:
1068         * Misc/WebNSPasteboardExtras.mm:
1069         (+[NSPasteboard _web_writableTypesForURL]):
1070         (_createWritableTypesForImageWithoutArchive):
1071         (_createWritableTypesForImageWithArchive):
1072         (+[NSPasteboard _web_dragTypesForURL]):
1073         (-[NSPasteboard _web_bestURL]):
1074         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1075         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1076         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1077         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1078         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1079         * Panels/WebAuthenticationPanel.m:
1080         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1081         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1082         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1083         (-[WebHostedNetscapePluginView drawRect:]):
1084         * WebInspector/WebNodeHighlightView.mm:
1085         (-[WebNodeHighlightView drawRect:]):
1086         * WebView/WebFrame.mm:
1087         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1088         (-[WebFrame _drawRect:contentsOnly:]):
1089         * WebView/WebHTMLView.mm:
1090         (kit):
1091         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1092         (-[WebHTMLView _plainTextFromPasteboard:]):
1093         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1094         (+[WebHTMLView _insertablePasteboardTypes]):
1095         (+[WebHTMLView _selectionPasteboardTypes]):
1096         (-[WebHTMLView pasteboard:provideDataForType:]):
1097         (-[WebHTMLView _writeSelectionToPasteboard:]):
1098         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1099         (-[WebHTMLView validRequestorForSendType:returnType:]):
1100         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1101         (createMenuItem):
1102         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1103         (-[WebHTMLView _colorAsString:]):
1104         (-[WebHTMLView copyFont:]):
1105         * WebView/WebPDFView.mm:
1106         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1107         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1108         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1109         (-[WebPDFView pasteboardTypesForSelection]):
1110         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1111         * WebView/WebView.h:
1112         * WebView/WebView.mm:
1113         (-[WebView performDragOperation:]):
1114         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1115         (-[WebView _searchWithGoogleFromMenu:]):
1116
1117 2017-12-21  Youenn Fablet  <youenn@apple.com>
1118
1119         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1120         https://bugs.webkit.org/show_bug.cgi?id=181000
1121
1122         Reviewed by Chris Dumez.
1123
1124         * Misc/WebCache.mm:
1125         (+[WebCache addImageToCache:forURL:forFrame:]):
1126
1127 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1128
1129         Update FULLSCREEN_API feature defines.
1130         https://bugs.webkit.org/show_bug.cgi?id=181015
1131
1132         Reviewed by Tim Horton.
1133
1134         Change enabled iphone sdk for FULLSCREEN_API.
1135
1136         * Configurations/FeatureDefines.xcconfig:
1137
1138 2017-12-21  Jer Noble  <jer.noble@apple.com>
1139
1140         Add initial DOM support for Media Capabilities
1141         https://bugs.webkit.org/show_bug.cgi?id=181064
1142
1143         Reviewed by Eric Carlson.
1144
1145         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1146
1147         * WebView/WebPreferenceKeysPrivate.h:
1148         * WebView/WebPreferences.mm:
1149         (+[WebPreferences initialize]):
1150         (-[WebPreferences mediaCapabilitiesEnabled]):
1151         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1152         * WebView/WebPreferencesPrivate.h:
1153         * WebView/WebView.mm:
1154         (-[WebView _preferencesChanged:]):
1155
1156 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1157
1158         Enable picture-in-picture from inline element on suspend.
1159         https://bugs.webkit.org/show_bug.cgi?id=180942
1160         rdar://problem/34745234
1161
1162         Reviewed by Jer Noble.
1163
1164         Update signature of enterVideoFullscreenForVideoElement().
1165
1166         * WebCoreSupport/WebChromeClient.h:
1167         * WebCoreSupport/WebChromeClient.mm:
1168         (WebChromeClient::enterVideoFullscreenForVideoElement):
1169
1170 2017-12-20  Daniel Bates  <dabates@apple.com>
1171
1172         Remove Alternative Presentation Button
1173         https://bugs.webkit.org/show_bug.cgi?id=180500
1174         <rdar://problem/35891047>
1175
1176         Reviewed by Simon Fraser.
1177
1178         We no longer need the alternative presentation button.
1179
1180         * Configurations/FeatureDefines.xcconfig:
1181
1182 2017-12-19  Jer Noble  <jer.noble@apple.com>
1183
1184         Playing media elements which call "pause(); play()" will have the play promise rejected.
1185         https://bugs.webkit.org/show_bug.cgi?id=180781
1186         <rdar://problem/33191377>
1187
1188         Reviewed by Eric Carlson.
1189
1190         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1191
1192         * WebView/WebView.mm:
1193         (shouldRequireUserGestureToLoadVideo):
1194
1195 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1196
1197         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1198         https://bugs.webkit.org/show_bug.cgi?id=180977
1199
1200         Reviewed by Tim Horton.
1201
1202         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1203         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1204         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1205
1206         * WebCoreSupport/WebEditorClient.mm:
1207         (attributesForAttributedStringConversion):
1208         * WebView/WebHTMLView.mm:
1209         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1210
1211 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1212
1213         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1214
1215         Attempt to fix the following warnings:
1216
1217             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1218
1219         For the following instance variables:
1220
1221             _borderView
1222             _contentView
1223             _frame
1224             _wFlags
1225
1226         * Carbon/CarbonWindowAdapter.mm:
1227         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1228         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1229         (-[CarbonWindowAdapter _termWindowIfOwner]):
1230         (-[CarbonWindowAdapter _windowMovedToRect:]):
1231         (-[CarbonWindowAdapter setContentView:]):
1232         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1233         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1234
1235 2017-12-16  Dan Bernstein  <mitz@apple.com>
1236
1237         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1238         https://bugs.webkit.org/show_bug.cgi?id=180613
1239         <rdar://problem/35946124>
1240
1241         Reviewed by Geoff Garen.
1242
1243         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1244           clients.
1245         * WebView/WebDynamicScrollBarsView.h: Ditto.
1246         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1247
1248 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1249
1250         Enable -Wstrict-prototypes for WebKit
1251         <https://webkit.org/b/180757>
1252         <rdar://problem/36024132>
1253
1254         Rubber-stamped by Joseph Pecoraro.
1255
1256         * Configurations/Base.xcconfig:
1257         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1258
1259 2017-12-14  John Wilander  <wilander@apple.com>
1260
1261         Storage Access API: Implement frame-specific access in the document.cookie layer
1262         https://bugs.webkit.org/show_bug.cgi?id=180682
1263         <rdar://problem/35982257>
1264
1265         Reviewed by Alex Christensen.
1266
1267         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1268         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1269         CookiesStrategy::getRawCookies() now take optional parameters for
1270         frameID and pageID to allow frame-specific scoping of cookies.
1271
1272         This change makes the return values of FrameLoaderClient::frameID()
1273         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1274         WebCore can call those getters and get the right return values in
1275         WebKit and std:nullopt in WebKitLegacy.
1276
1277         * WebCoreSupport/WebFrameLoaderClient.h:
1278         * WebCoreSupport/WebFrameLoaderClient.mm:
1279         (WebFrameLoaderClient::pageID const):
1280         (WebFrameLoaderClient::frameID const):
1281         * WebCoreSupport/WebPlatformStrategies.h:
1282         * WebCoreSupport/WebPlatformStrategies.mm:
1283         (WebPlatformStrategies::cookiesForDOM):
1284         (WebPlatformStrategies::setCookiesFromDOM):
1285         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1286         (WebPlatformStrategies::getRawCookies):
1287
1288 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1289
1290         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1291         https://bugs.webkit.org/show_bug.cgi?id=180689
1292
1293         Reviewed by Tim Horton.
1294
1295         Use sRGBColorSpaceRef() from WebCore.
1296
1297         * WebView/WebHTMLView.mm:
1298         (imageFromRect):
1299
1300 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1301
1302         Stop using deprecated target conditional for simulator builds
1303         https://bugs.webkit.org/show_bug.cgi?id=180662
1304         <rdar://problem/35136156>
1305
1306         Reviewed by Simon Fraser.
1307
1308         * postprocess-headers.sh:
1309
1310 2017-12-11  David Quesada  <david_quesada@apple.com>
1311
1312         Turn on ENABLE_APPLICATION_MANIFEST
1313         https://bugs.webkit.org/show_bug.cgi?id=180562
1314         rdar://problem/35924737
1315
1316         Reviewed by Geoffrey Garen.
1317
1318         * Configurations/FeatureDefines.xcconfig:
1319
1320 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1321
1322         Remove pthread_once in favor of dispatch_once
1323         https://bugs.webkit.org/show_bug.cgi?id=180591
1324
1325         Reviewed by Saam Barati.
1326
1327         * Misc/WebKitErrors.m:
1328         (+[NSError _registerWebKitErrors]):
1329         (registerErrors): Deleted.
1330         * Storage/WebStorageManager.mm:
1331         (+[WebStorageManager _storageDirectoryPath]):
1332         (initializeLocalStoragePath): Deleted.
1333
1334 2017-12-07  Darin Adler  <darin@apple.com>
1335
1336         Remove some unused code from WebKitLegacy
1337         https://bugs.webkit.org/show_bug.cgi?id=180567
1338
1339         Reviewed by Anders Carlsson.
1340
1341         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1342         macOS (back a few versions) and iOS and removed unused
1343         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1344         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1345         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1346         _webkit_stringByCollapsingNonPrintingCharacters,
1347         _webkit_stringByCollapsingWhitespaceCharacters,
1348         _web_stringWithData:textEncodingName:, and
1349         _webkit_localStorageDirectoryWithBundleIdentifier:.
1350
1351         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1352         this source file.
1353         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1354         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1355         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1356         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1357         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1358         handle font smoothing options.
1359         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1360         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1361         from header and made it a little clearer.
1362         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1363         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1364         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1365         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1366         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1367         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1368         implementation a bit and used whole words instead of abbreviations.
1369         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1370
1371         * Misc/WebNSFileManagerExtras.mm:
1372         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1373         filenameByFixingIllegalCharacters function from WebCore directly instead of
1374         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1375
1376         * Plugins/WebBaseNetscapePluginView.mm:
1377         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1378         string replacements instead of _web_stringByStrippingReturnCharacters
1379         and to use NSString methods instead of CFString functions.
1380
1381 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1382
1383         Ignore deprecation warnings.
1384
1385         * WebView/WebHTMLView.mm:
1386         (-[NSWindow _web_borderView]):
1387         (-[WebHTMLView _setAsideSubviews]):
1388         * WebView/WebView.mm:
1389         (-[WebView encodeWithCoder:]):
1390
1391 2017-12-02  Darin Adler  <darin@apple.com>
1392
1393         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1394         https://bugs.webkit.org/show_bug.cgi?id=180009
1395
1396         Reviewed by Alex Christensen.
1397
1398         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1399
1400         * Plugins/WebBaseNetscapePluginView.mm:
1401         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1402         of strcasecmp.
1403
1404         * WebView/WebPreferences.mm:
1405         (contains): Ditto. Also made this a template so it's easier to call on an array.
1406         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1407
1408 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1409
1410         Limit user agent versioning to an upper bound
1411         https://bugs.webkit.org/show_bug.cgi?id=180365
1412         <rdar://problem/34550617>
1413
1414         Reviewed by Joseph Pecoraro.
1415
1416         * WebView/WebView.mm:
1417         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1418         creating the User Agent string.
1419         (webKitBundleVersionString): Deleted.
1420
1421 2017-12-05  Andy Estes  <aestes@apple.com>
1422
1423         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1424         https://bugs.webkit.org/show_bug.cgi?id=180457
1425         <rdar://problem/35143007>
1426
1427         Reviewed by Tim Horton.
1428
1429         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1430         check for this macro during post-processing.
1431
1432         * postprocess-headers.sh:
1433
1434 2017-12-04  David Quesada  <david_quesada@apple.com>
1435
1436         Add a class for parsing application manifests
1437         https://bugs.webkit.org/show_bug.cgi?id=177973
1438         rdar://problem/34747949
1439
1440         Reviewed by Geoffrey Garen.
1441
1442         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1443
1444 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1445
1446         Make LegacyCustomProtocolManager optional for network process
1447         https://bugs.webkit.org/show_bug.cgi?id=176230
1448
1449         Reviewed by Alex Christensen.
1450
1451         * Configurations/FeatureDefines.xcconfig:
1452
1453 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1454
1455         Fix some NSOperationQueue leaks
1456         https://bugs.webkit.org/show_bug.cgi?id=180221
1457
1458         Reviewed by Wenson Hsieh.
1459
1460         * WebView/WebView.mm:
1461         (-[WebView performDragOperation:]):
1462
1463 2017-11-30  Darin Adler  <darin@apple.com>
1464
1465         [Mac] remove unneeded RetainPtr use introduced in r225142
1466         https://bugs.webkit.org/show_bug.cgi?id=180202
1467
1468         Reviewed by Tim Horton.
1469
1470         * WebView/WebImmediateActionController.mm:
1471         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1472         RetainPtr.
1473
1474 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1475
1476         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1477         https://bugs.webkit.org/show_bug.cgi?id=175595
1478
1479         Reviewed by Darin Adler.
1480
1481         * WebView/WebPreferences.mm:
1482
1483 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1484
1485         One too many zeroes in macOS version number in FeatureDefines
1486         https://bugs.webkit.org/show_bug.cgi?id=180011
1487
1488         Reviewed by Dan Bernstein.
1489
1490         * Configurations/FeatureDefines.xcconfig:
1491
1492 2017-11-23  Darin Adler  <darin@apple.com>
1493
1494         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1495         https://bugs.webkit.org/show_bug.cgi?id=179981
1496
1497         Reviewed by Sam Weinig.
1498
1499         * WebView/WebImmediateActionController.mm:
1500         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1501         * WebView/WebView.mm:
1502         (coreOptions): Use |= instead of | to build up FindOptions.
1503
1504 2017-11-23  Sam Weinig  <sam@webkit.org>
1505
1506         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1507         https://bugs.webkit.org/show_bug.cgi?id=179954
1508
1509         Reviewed by Darin Adler.
1510
1511         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1512         with direct calls to the corresponding UserGestureIndicator functions.
1513
1514         * Plugins/WebPluginController.mm:
1515         (-[WebPluginController processingUserGesture]):
1516         * WebView/WebView.mm:
1517         (-[WebView _isProcessingUserGesture]):
1518
1519 2017-11-23  Darin Adler  <darin@apple.com>
1520
1521         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1522         https://bugs.webkit.org/show_bug.cgi?id=179907
1523
1524         Reviewed by Sam Weinig.
1525
1526         * History/BinaryPropertyList.cpp:
1527         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1528         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1529         * WebView/WebHTMLRepresentation.mm:
1530         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1531         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1532
1533 2017-11-22  Ali Juma  <ajuma@chromium.org>
1534
1535         Implement VisualViewport API attributes
1536         https://bugs.webkit.org/show_bug.cgi?id=179385
1537
1538         Reviewed by Frédéric Wang.
1539
1540         Add a VisualViewportAPI preference.
1541
1542         * WebView/WebPreferenceKeysPrivate.h:
1543         * WebView/WebPreferences.mm:
1544         (+[WebPreferences initialize]):
1545         (-[WebPreferences visualViewportAPIEnabled]):
1546         (-[WebPreferences setVisualViewportAPIEnabled:]):
1547         * WebView/WebPreferencesPrivate.h:
1548         * WebView/WebView.mm:
1549         (-[WebView _preferencesChanged:]):
1550
1551 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1552
1553         WebCoreObjCExtras.h is being included in too many places
1554         https://bugs.webkit.org/show_bug.cgi?id=179931
1555
1556         Reviewed by Darin Adler.
1557
1558         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1559         * Plugins/WebBaseNetscapePluginView.mm:
1560         * Plugins/WebBasePluginPackage.mm:
1561         * Plugins/WebNetscapePluginStream.mm:
1562         * Plugins/WebNetscapePluginView.mm:
1563         * WebView/WebTextIterator.mm:
1564         * WebView/WebViewData.mm:
1565
1566 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1567
1568         Unreviewed, rolling out r225093.
1569         https://bugs.webkit.org/show_bug.cgi?id=179938
1570
1571         Compilation failed on WinCairo 64-bit Release (Requested by
1572         fredw on #webkit).
1573
1574         Reverted changeset:
1575
1576         "Implement VisualViewport API attributes"
1577         https://bugs.webkit.org/show_bug.cgi?id=179385
1578         https://trac.webkit.org/changeset/225093
1579
1580 2017-11-21  Ali Juma  <ajuma@chromium.org>
1581
1582         Implement VisualViewport API attributes
1583         https://bugs.webkit.org/show_bug.cgi?id=179385
1584
1585         Reviewed by Frédéric Wang.
1586
1587         Add a VisualViewportAPI preference.
1588
1589         * WebView/WebPreferenceKeysPrivate.h:
1590         * WebView/WebPreferences.mm:
1591         (+[WebPreferences initialize]):
1592         (-[WebPreferences visualViewportAPIEnabled]):
1593         (-[WebPreferences setVisualViewportAPIEnabled:]):
1594         * WebView/WebPreferencesPrivate.h:
1595         * WebView/WebView.mm:
1596         (-[WebView _preferencesChanged:]):
1597
1598 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1599
1600         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1601         https://bugs.webkit.org/show_bug.cgi?id=179504
1602
1603         Reviewed by Darin Adler.
1604
1605         * Misc/WebKitNSStringExtras.mm:
1606         * Plugins/Hosted/NetscapePluginHostManager.mm:
1607         * Plugins/WebBasePluginPackage.mm:
1608
1609 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1610
1611         Remove unused TOUCH_ICON_LOADING feature flag
1612         https://bugs.webkit.org/show_bug.cgi?id=179873
1613
1614         Reviewed by Simon Fraser.
1615
1616         * Configurations/FeatureDefines.xcconfig:
1617
1618 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1619
1620         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1621         https://bugs.webkit.org/show_bug.cgi?id=179872
1622
1623         Reviewed by Darin Adler.
1624
1625         * Configurations/FeatureDefines.xcconfig:
1626
1627 2017-11-16  Daniel Bates  <dabates@apple.com>
1628
1629         Add feature define for alternative presentation button element
1630         https://bugs.webkit.org/show_bug.cgi?id=179692
1631         Part of <rdar://problem/34917108>
1632
1633         Reviewed by Andy Estes.
1634
1635         Only enabled on Cocoa platforms by default.
1636
1637         * Configurations/FeatureDefines.xcconfig:
1638
1639 2017-11-14  Nan Wang  <n_wang@apple.com>
1640
1641         AX: AOM: Implement AccessibleNode class and support label and role attributes
1642         https://bugs.webkit.org/show_bug.cgi?id=179494
1643
1644         Reviewed by Ryosuke Niwa.
1645
1646         * WebView/WebPreferenceKeysPrivate.h:
1647         * WebView/WebPreferences.mm:
1648         (+[WebPreferences initialize]):
1649         (-[WebPreferences accessibilityObjectModelEnabled]):
1650         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1651         * WebView/WebPreferencesPrivate.h:
1652         * WebView/WebView.mm:
1653         (-[WebView _preferencesChanged:]):
1654
1655 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1656
1657         Remove Cocoa CFURLConnection loading code
1658         https://bugs.webkit.org/show_bug.cgi?id=179688
1659
1660         Reviewed by Antti Koivisto.
1661
1662         * Misc/WebDownload.mm:
1663         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1664         * Misc/WebDownloadInternal.h:
1665         * Plugins/WebBaseNetscapePluginView.mm:
1666         * WebCoreSupport/WebFrameLoaderClient.mm:
1667         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1668         * WebView/WebView.mm:
1669         (-[WebView scheduleInRunLoop:forMode:]):
1670         (-[WebView unscheduleFromRunLoop:forMode:]):
1671
1672 2017-11-14  Daniel Bates  <dabates@apple.com>
1673
1674         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1675         for feature defines
1676
1677         Following r195498 and r201917 the Visual Studio property files for feature defines have
1678         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1679         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1680         files.
1681
1682         * Configurations/FeatureDefines.xcconfig:
1683
1684 2017-11-14  Jer Noble  <jer.noble@apple.com>
1685
1686         Enable Modern EME tests in DumpRenderTree
1687         https://bugs.webkit.org/show_bug.cgi?id=179544
1688
1689         Reviewed by Alex Christensen.
1690
1691         Add a WebPreferences property to enable the (modern) EME API.
1692
1693         * WebView/WebPreferenceKeysPrivate.h:
1694         * WebView/WebPreferences.mm:
1695         (+[WebPreferences initialize]):
1696         (-[WebPreferences encryptedMediaAPIEnabled]):
1697         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1698         * WebView/WebPreferencesPrivate.h:
1699         * WebView/WebView.mm:
1700         (-[WebView _preferencesChanged:]):
1701
1702 2017-11-14  Antti Koivisto  <antti@apple.com>
1703
1704         Enable display:contents by default
1705         https://bugs.webkit.org/show_bug.cgi?id=179655
1706
1707         Reviewed by Sam Weinig.
1708
1709         * WebView/WebPreferences.mm:
1710         (+[WebPreferences initialize]):
1711
1712 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1713
1714         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1715         https://bugs.webkit.org/show_bug.cgi?id=178751
1716
1717         Reviewed by Brady Eidson.
1718
1719         * WebCoreSupport/WebFrameNetworkingContext.mm:
1720         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1721
1722 2017-11-08  Keith Miller  <keith_miller@apple.com>
1723
1724         Async iteration should only fetch the next method once and add feature flag
1725         https://bugs.webkit.org/show_bug.cgi?id=179451
1726
1727         Reviewed by Geoffrey Garen.
1728
1729         Add feature flag for Async iteration.
1730
1731         * Configurations/FeatureDefines.xcconfig:
1732
1733 2017-11-13  Mark Lam  <mark.lam@apple.com>
1734
1735         Add more overflow check book-keeping for MarkedArgumentBuffer.
1736         https://bugs.webkit.org/show_bug.cgi?id=179634
1737         <rdar://problem/35492517>
1738
1739         Reviewed by Saam Barati.
1740
1741         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1742         (WebKit::NetscapePluginInstanceProxy::invoke):
1743         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1744         (WebKit::NetscapePluginInstanceProxy::construct):
1745
1746 2017-11-12  Darin Adler  <darin@apple.com>
1747
1748         More is<> and downcast<>, less static_cast<>
1749         https://bugs.webkit.org/show_bug.cgi?id=179600
1750
1751         Reviewed by Chris Dumez.
1752
1753         * DOM/DOM.mm:
1754         (kit): Use is/downcast.
1755         * WebCoreSupport/WebEditorClient.mm:
1756         (WebEditorClient::handleKeyboardEvent): Ditto.
1757         (WebEditorClient::handleInputMethodKeydown): Ditto.
1758         * WebView/WebHTMLView.mm:
1759         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1760
1761 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1762
1763         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1764         https://bugs.webkit.org/show_bug.cgi?id=179397
1765
1766         Reviewed by Wenson Hsieh.
1767
1768         * DOM/DOMHTMLInputElement.mm:
1769         (-[DOMHTMLInputElement insertTextSuggestion:]):
1770
1771 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1772
1773         HTMLMediaElement should not use element fullscreen on iOS
1774         https://bugs.webkit.org/show_bug.cgi?id=179418
1775         rdar://problem/35409277
1776
1777         Reviewed by Eric Carlson.
1778
1779         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1780
1781         * Configurations/FeatureDefines.xcconfig:
1782
1783 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1784
1785         Make ResourceLoader::willSendRequestInternal asynchronous
1786         https://bugs.webkit.org/show_bug.cgi?id=179251
1787
1788         Reviewed by Andy Estes.
1789
1790         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1791         (WebKit::HostedNetscapePluginStream::start):
1792         * Plugins/WebNetscapePluginStream.mm:
1793         (WebNetscapePluginStream::start):
1794
1795 2017-11-01  Darin Adler  <darin@apple.com>
1796
1797         Simplify event dispatch code and make it a bit more consistent
1798         https://bugs.webkit.org/show_bug.cgi?id=178991
1799
1800         Reviewed by Chris Dumez.
1801
1802         * DOM/DOMEvent.mm:
1803         (-[DOMEvent srcElement]): Call target instead of srcElement.
1804
1805 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1806
1807         [Touch Bar Web API] Add support for menuitem tag
1808         https://bugs.webkit.org/show_bug.cgi?id=179020
1809
1810         Reviewed by Ryosuke Niwa.
1811
1812         Adds in properties and methods that allow the menuitem runtime feature
1813         to be enabled or disabled.
1814
1815         * WebView/WebPreferenceKeysPrivate.h:
1816         * WebView/WebPreferences.mm:
1817         (-[WebPreferences menuItemElementEnabled]):
1818         (-[WebPreferences setMenuItemElementEnabled:]):
1819         * WebView/WebPreferencesPrivate.h:
1820         * WebView/WebView.mm:
1821         (-[WebView _preferencesChanged:]):
1822
1823 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1824
1825         Use CompletionHandlers for redirects
1826         https://bugs.webkit.org/show_bug.cgi?id=179163
1827
1828         Reviewed by Tim Horton.
1829
1830         * Plugins/Hosted/HostedNetscapePluginStream.h:
1831         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1832         (WebKit::HostedNetscapePluginStream::willSendRequest):
1833         * Plugins/WebNetscapePluginStream.h:
1834         * Plugins/WebNetscapePluginStream.mm:
1835         (WebNetscapePluginStream::willSendRequest):
1836
1837 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1838
1839         Add a FileSystem namespace to FileSystem.cpp
1840         https://bugs.webkit.org/show_bug.cgi?id=179063
1841
1842         Reviewed by Darin Adler.
1843
1844         * Misc/WebNSFileManagerExtras.mm:
1845         * Storage/WebDatabaseProvider.mm:
1846
1847 2017-11-02  Frederic Wang  <fwang@igalia.com>
1848
1849         Add references to bug 179167 in FIXME comments
1850         https://bugs.webkit.org/show_bug.cgi?id=179168
1851
1852         Reviewed by Daniel Bates.
1853
1854         * Configurations/FeatureDefines.xcconfig:
1855
1856 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1857
1858         Implement WKFullscreenWindowController for iOS.
1859         https://bugs.webkit.org/show_bug.cgi?id=178924
1860         rdar://problem/34697120
1861
1862         Reviewed by Simon Fraser.
1863
1864         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1865
1866         * Configurations/FeatureDefines.xcconfig:
1867         * WebView/WebView.mm:
1868         (-[WebView fullScreenPlaceholderView]):
1869
1870 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1871
1872         Clean up some drag and drop feature flags
1873         https://bugs.webkit.org/show_bug.cgi?id=179082
1874
1875         Reviewed by Simon Fraser.
1876
1877         * Configurations/FeatureDefines.xcconfig:
1878
1879 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1880
1881         Make it possible to test rubber-banding in overflow scroll
1882         https://bugs.webkit.org/show_bug.cgi?id=179078
1883
1884         Reviewed by Sam Weinig.
1885
1886         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1887         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1888
1889         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1890         functions, since most callers want clamped.
1891
1892         * DOM/DOMHTML.mm:
1893         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1894
1895 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1896
1897         Fix up some content filtering feature flags
1898         https://bugs.webkit.org/show_bug.cgi?id=179079
1899
1900         Reviewed by Simon Fraser.
1901
1902         * Configurations/FeatureDefines.xcconfig:
1903
1904 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1905
1906         [FrameView::layout cleanup] Move core layout logic to a separate class.
1907         https://bugs.webkit.org/show_bug.cgi?id=178771
1908         <rdar://problem/35166542>
1909
1910         Reviewed by Simon Fraser.
1911
1912         Move layout code out from FrameView to LayoutContext.
1913
1914         * WebView/WebClipView.mm:
1915         (-[WebClipView _immediateScrollToPoint:]):
1916         * WebView/WebFrame.mm:
1917         (-[WebFrame layoutCount]):
1918
1919 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1920
1921         Fix issues with WebView subframe painting
1922         https://bugs.webkit.org/show_bug.cgi?id=178842
1923         rdar://problem/34072253
1924
1925         Reviewed by Daniel Bates.
1926         
1927         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1928         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1929         High Sierra, so match the new signature.
1930
1931         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1932
1933         * WebView/WebHTMLView.mm:
1934         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1935         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1936
1937 2017-10-25  Youenn Fablet  <youenn@apple.com>
1938
1939         Enable ServiceWorker to fetch resources
1940         https://bugs.webkit.org/show_bug.cgi?id=178673
1941
1942         Reviewed by Brady Eidson.
1943
1944         * WebCoreSupport/WebFrameLoaderClient.mm:
1945         (WebFrameLoaderClient::pageID const):
1946         (WebFrameLoaderClient::frameID const):
1947         (WebFrameLoaderClient::sessionID const):
1948
1949         Added implementation to the new getters.
1950         They are noop in the context of WK1.
1951
1952 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1953
1954         Web Inspector: Enable WebKit logging configuration and display
1955         https://bugs.webkit.org/show_bug.cgi?id=177027
1956         <rdar://problem/33964767>
1957
1958         Reviewed by Joseph Pecoraro.
1959
1960         * WebCoreSupport/WebChromeClient.mm:
1961         (stringForMessageSource): Deal with Media and WebRTC message sources.
1962
1963 2017-10-20  Antoine Quint  <graouts@apple.com>
1964
1965         [Web Animations] Provide basic timeline and animation interfaces
1966         https://bugs.webkit.org/show_bug.cgi?id=178526
1967
1968         Reviewed by Dean Jackson.
1969
1970         Remove the WEB_ANIMATIONS compile-time flag.
1971
1972         * Configurations/FeatureDefines.xcconfig:
1973         * WebView/WebPreferences.mm:
1974         (+[WebPreferences initialize]):
1975         * WebView/WebView.mm:
1976         (-[WebView _preferencesChanged:]):
1977
1978 2017-10-19  Sam Weinig  <sam@webkit.org>
1979
1980         [Settings] Move global settings into their own file
1981         https://bugs.webkit.org/show_bug.cgi?id=178512
1982
1983         Reviewed by Darin Adler.
1984
1985         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1986
1987         * WebCoreSupport/WebChromeClient.mm:
1988         (WebChromeClient::supportsVideoFullscreen):
1989         * WebView/WebDynamicScrollBarsView.mm:
1990         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1991         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1992         * WebView/WebPreferences.mm:
1993         (+[WebPreferences initialize]):
1994         * WebView/WebView.mm:
1995         (-[WebView _commonInitializationWithFrameName:groupName:]):
1996         (-[WebView _preferencesChanged:]):
1997         (+[WebView _doNotStartObservingNetworkReachability]):
1998
1999 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2000
2001         Replace some stack raw pointers with RefPtrs within WebCore/html
2002         https://bugs.webkit.org/show_bug.cgi?id=178201
2003         <rdar://problem/34841692>
2004
2005         Reviewed by Ryosuke Niwa.
2006
2007         * DOM/DOM.mm:
2008         (kit):
2009         Change the type of node as toNode() is changed to return RefPtr.
2010
2011 2017-10-18  Chris Dumez  <cdumez@apple.com>
2012
2013         [Service Worker] Add stubs for Client / WindowClient / Clients
2014         https://bugs.webkit.org/show_bug.cgi?id=178469
2015
2016         Reviewed by Youenn Fablet.
2017
2018         Rename PageVisiblityState to VisibilityState.
2019
2020         * WebView/WebView.mm:
2021         (kit):
2022
2023 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2024
2025         Unreviewed, rolling out r223291.
2026
2027         See WebCore ChangeLog for more detail.
2028
2029         Reverted changeset:
2030
2031         "Remove Editor::simplifyMarkup"
2032         https://bugs.webkit.org/show_bug.cgi?id=178271
2033         https://trac.webkit.org/changeset/223291
2034
2035 2017-10-17  Keith Miller  <keith_miller@apple.com>
2036
2037         Change WebCore sources to work with unified source builds
2038         https://bugs.webkit.org/show_bug.cgi?id=178229
2039
2040         Rubber stamped by Tim Horton.
2041
2042         * Configurations/FeatureDefines.xcconfig:
2043
2044 2017-10-16  Sam Weinig  <sam@webkit.org>
2045
2046         [Settings] Remove all custom code from Settings.h/cpp
2047         https://bugs.webkit.org/show_bug.cgi?id=178330
2048
2049         Reviewed by Simon Fraser.
2050
2051         * WebView/WebPreferences.mm:
2052         (+[WebPreferences initialize]):
2053         
2054             Update for naming changes of FrameFlattening now that it is an enum class.
2055
2056 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2057
2058         Remove Editor::simplifyMarkup
2059         https://bugs.webkit.org/show_bug.cgi?id=178271
2060
2061         Reviewed by Wenson Hsieh.
2062
2063         * WebView/WebView.mm:
2064         (-[WebView _simplifyMarkup:endNode:]):
2065
2066 2017-10-12  Chris Dumez  <cdumez@apple.com>
2067
2068         [Mac] Add support for MouseEvent.buttons
2069         https://bugs.webkit.org/show_bug.cgi?id=178214
2070
2071         Reviewed by Ryosuke Niwa.
2072
2073         * WebView/WebPDFView.mm:
2074         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2075
2076 2017-10-11  Sam Weinig  <sam@webkit.org>
2077
2078         Remove out-parameter variants of copyToVector
2079         https://bugs.webkit.org/show_bug.cgi?id=178155
2080
2081         Reviewed by Tim Horton.
2082
2083         * Plugins/WebNetscapePluginView.mm:
2084         (-[WebNetscapePluginView destroyPlugin]):
2085         * WebView/WebHTMLRepresentation.mm:
2086         (newArrayWithStrings):
2087
2088             Replace out-parameter based copyToVector, with one that returns a Vector.
2089
2090 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2091
2092         Sanitize URL in pasteboard for other applications and cross origin content
2093         https://bugs.webkit.org/show_bug.cgi?id=178060
2094         <rdar://problem/34874518>
2095
2096         Reviewed by Wenson Hsieh.
2097
2098         * WebCoreSupport/WebPlatformStrategies.h:
2099         * WebCoreSupport/WebPlatformStrategies.mm:
2100         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2101
2102 2017-10-11  Chris Dumez  <cdumez@apple.com>
2103
2104         Modernize Geolocation code
2105         https://bugs.webkit.org/show_bug.cgi?id=178148
2106
2107         Reviewed by Ryosuke Niwa.
2108
2109         * WebCoreSupport/WebGeolocationClient.h:
2110         * WebCoreSupport/WebGeolocationClient.mm:
2111         (WebGeolocationClient::lastPosition):
2112         * WebView/WebGeolocationPosition.mm:
2113         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2114         (core):
2115         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2116         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2117         * WebView/WebGeolocationPositionInternal.h:
2118
2119 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2120
2121         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2122         https://bugs.webkit.org/show_bug.cgi?id=178154
2123
2124         Reviewed by Wenson Hsieh.
2125
2126         Enable custom pasteboard data by default.
2127
2128         * WebView/WebPreferenceKeysPrivate.h:
2129         * WebView/WebPreferences.mm:
2130         (+[WebPreferences initialize]):
2131         (-[WebPreferences customPasteboardDataEnabled]): Added.
2132         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2133         * WebView/WebPreferencesPrivate.h:
2134         * WebView/WebView.mm:
2135         (-[WebView _preferencesChanged:]):
2136
2137 2017-10-10  Sam Weinig  <sam@webkit.org>
2138
2139         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2140         https://bugs.webkit.org/show_bug.cgi?id=178102
2141
2142         Reviewed by Tim Horton.
2143
2144         * History/WebHistory.mm:
2145         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2146         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2147         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2148         * WebCoreSupport/WebUserMediaClient.mm:
2149         (WebUserMediaClient::pageDestroyed):
2150
2151 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2152
2153         Make the names of the options consistent
2154         https://bugs.webkit.org/show_bug.cgi?id=177933
2155
2156         Reviewed by Saam Barati.
2157
2158         * WebView/WebFrame.h:
2159         * WebView/WebHTMLView.mm:
2160         (-[WebHTMLView setMarkedText:selectedRange:]):
2161         * WebView/WebView.h:
2162
2163 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2164
2165         [iOS] Tweak support for classifying form controls (followup to r222487)
2166         https://bugs.webkit.org/show_bug.cgi?id=177917
2167         <rdar://problem/34820122>
2168
2169         Reviewed by Dean Jackson.
2170
2171         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2172
2173         * DOM/DOMHTMLInputElement.mm:
2174         (-[DOMHTMLInputElement _autofillContext]):
2175         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2176         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2177
2178 2017-10-05  Keith Miller  <keith_miller@apple.com>
2179
2180         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2181
2182         * Configurations/WebKitLegacy.xcconfig:
2183
2184 2017-10-05  Jer Noble  <jer.noble@apple.com>
2185
2186         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2187         https://bugs.webkit.org/show_bug.cgi?id=177261
2188
2189         Reviewed by Eric Carlson.
2190
2191         * Configurations/FeatureDefines.xcconfig:
2192
2193 2017-10-05  Chris Dumez  <cdumez@apple.com>
2194
2195         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2196         https://bugs.webkit.org/show_bug.cgi?id=177957
2197
2198         Reviewed by Alex Christensen.
2199
2200         * WebCoreSupport/WebPlatformStrategies.h:
2201         * WebCoreSupport/WebPlatformStrategies.mm:
2202         (WebPlatformStrategies::cookiesEnabled):
2203
2204 2017-10-05  Youenn Fablet  <youenn@apple.com>
2205
2206         Make LibWebRTCProvider port agnostic
2207         https://bugs.webkit.org/show_bug.cgi?id=177747
2208
2209         Reviewed by Alex Christensen & Alex Garcia.
2210
2211         * WebView/WebView.mm:
2212         (-[WebView _commonInitializationWithFrameName:groupName:]):
2213         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2214
2215 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2216
2217         Stop linking with WebKitSystemInterface
2218         https://bugs.webkit.org/show_bug.cgi?id=177915
2219
2220         Reviewed by Antti Koivisto.
2221
2222         * Configurations/DebugRelease.xcconfig:
2223         * Configurations/WebKitLegacy.xcconfig:
2224
2225 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2226
2227         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2228         https://bugs.webkit.org/show_bug.cgi?id=177912
2229
2230         Reviewed by Saam Barati.
2231
2232         * Carbon/CarbonUtils.m:
2233         * Carbon/CarbonWindowAdapter.mm:
2234         * Carbon/HIWebView.mm:
2235         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2236         * Misc/WebNSFileManagerExtras.mm:
2237         * Misc/WebNSPasteboardExtras.mm:
2238         * Misc/WebNSURLExtras.mm:
2239         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2240         * Plugins/Hosted/NetscapePluginHostManager.mm:
2241         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2242         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2243         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2244         * Plugins/Hosted/WebTextInputWindowController.m:
2245         * Plugins/WebBaseNetscapePluginView.mm:
2246         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2247         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2248         * Plugins/WebNetscapePluginStream.mm:
2249         * Plugins/WebNetscapePluginView.mm:
2250         * Plugins/WebPluginDatabase.mm:
2251         * WebCoreSupport/PopupMenuMac.mm:
2252         * WebCoreSupport/WebChromeClient.mm:
2253         * WebCoreSupport/WebFrameLoaderClient.mm:
2254         * WebCoreSupport/WebInspectorClient.mm:
2255         * WebCoreSupport/WebPlatformStrategies.mm:
2256         * WebCoreSupport/WebSystemInterface.mm:
2257         * WebView/WebDynamicScrollBarsView.mm:
2258         * WebView/WebFrame.mm:
2259         * WebView/WebFrameView.mm:
2260         * WebView/WebFullScreenController.mm:
2261         * WebView/WebHTMLView.mm:
2262         * WebView/WebPreferences.mm:
2263         * WebView/WebView.mm:
2264
2265 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2266
2267         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2268         rdar://problem/34705779
2269
2270         Addressing review comments that I somehow landed without.
2271
2272         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2273
2274 2017-09-29  Chris Dumez  <cdumez@apple.com>
2275
2276         Split some logic out of VisitedLinkStore and make it reusable
2277         https://bugs.webkit.org/show_bug.cgi?id=177575
2278
2279         Reviewed by Alex Christensen.
2280
2281         * WebCoreSupport/WebVisitedLinkStore.h:
2282         * WebCoreSupport/WebVisitedLinkStore.mm:
2283         (WebVisitedLinkStore::addVisitedLink):
2284         (WebVisitedLinkStore::removeVisitedLink):
2285         (WebVisitedLinkStore::isLinkVisited):
2286         (WebVisitedLinkStore::addVisitedLinkHash):
2287
2288 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2289
2290         Build fix for High Sierra 32 bit Mac
2291         https://bugs.webkit.org/show_bug.cgi?id=177551
2292         <rdar://problem/34690283>
2293
2294         Reviewed by Alexey Proskuryakov.
2295
2296         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2297         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2298         also made.
2299
2300         * Carbon/CarbonWindowAdapter.mm:
2301         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2302         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2303         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2304         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2305         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2306         (-[CarbonWindowAdapter dealloc]):
2307         (-[CarbonWindowAdapter windowRef]):
2308         (-[CarbonWindowAdapter _hasWindowRef]):
2309         (-[CarbonWindowAdapter _managesWindowRef]):
2310         (-[CarbonWindowAdapter _removeWindowRef]):
2311         (-[CarbonWindowAdapter _carbonWindowClass]):
2312         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2313         (-[CarbonWindowAdapter sendSuperEvent:]):
2314         (-[CarbonWindowAdapter relinquishFocus]):
2315         (-[CarbonWindowAdapter _cancelKey:]):
2316         (-[CarbonWindowAdapter _commonAwake]):
2317         (-[CarbonWindowAdapter _destroyRealWindow:]):
2318         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2319         (-[CarbonWindowAdapter _termWindowIfOwner]):
2320         (-[CarbonWindowAdapter _windowMovedToRect:]):
2321         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2322         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2323         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2324         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2325         (-[CarbonWindowAdapter canBecomeMainWindow]):
2326         (-[CarbonWindowAdapter encodeWithCoder:]):
2327         (-[CarbonWindowAdapter initWithCoder:]):
2328         (-[CarbonWindowAdapter setContentView:]):
2329         (-[CarbonWindowAdapter worksWhenModal]):
2330         (-[CarbonWindowAdapter _setModalWindowLevel]):
2331         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2332         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2333         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2334         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2335         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2336         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2337         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2338         (NSCarbonWindowHandleEvent):
2339         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2340         (-[CarbonWindowAdapter _growBoxRect]):
2341         * Carbon/HIWebView.mm:
2342         (HIWebViewGetWebView):
2343         (HIWebViewConstructor):
2344         (HIWebViewDestructor):
2345         (HIWebViewRegisterClass):
2346         (GetBehaviors):
2347         (Draw):
2348         (HitTest):
2349         (GetRegion):
2350         (GetWindowRef):
2351         (CreateNSEventAdoptingCGEvent):
2352         (CopyEventCGEvent):
2353         (CreateNSEventWithCarbonClickEvent):
2354         (Click):
2355         (CreateNSEventWithCarbonEvent):
2356         (MouseUp):
2357         (CreateNSEventWithCarbonMouseMoveEvent):
2358         (MouseMoved):
2359         (MouseDragged):
2360         (MouseWheelMoved):
2361         (ContextMenuClick):
2362         (GetKind):
2363         (BoundsChanged):
2364         (OwningWindowChanged):
2365         (WindowHandler):
2366         (SyncFrame):
2367         (SetFocusPart):
2368         (AdvanceFocus):
2369         (RelinquishFocus):
2370         (ActiveStateChanged):
2371         (ProcessCommand):
2372         (UpdateCommandStatus):
2373         (_NSSelectorForHICommand):
2374         (HIWebViewEventHandler):
2375         (StartUpdateObserver):
2376         (StopUpdateObserver):
2377         (UpdateObserver):
2378
2379 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2380
2381         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2382         https://bugs.webkit.org/show_bug.cgi?id=172526
2383         <rdar://problem/32396081>
2384
2385         Reviewed by Ryosuke Niwa.
2386
2387         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2388
2389         * WebCoreSupport/WebPlatformStrategies.h:
2390         * WebCoreSupport/WebPlatformStrategies.mm:
2391         (WebPlatformStrategies::webExposedTypes):
2392         (WebPlatformStrategies::writeCustomData):
2393
2394 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2395
2396         Unreviewed, rolling out r222567.
2397
2398         This broke and internal build.
2399
2400         Reverted changeset:
2401
2402         "Build fix for High Sierra 32 bit Mac"
2403         https://bugs.webkit.org/show_bug.cgi?id=177551
2404         http://trac.webkit.org/changeset/222567
2405
2406 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2407
2408         Build fix for High Sierra 32 bit Mac
2409         https://bugs.webkit.org/show_bug.cgi?id=177551
2410         <rdar://problem/34690283>
2411
2412         Reviewed by Alexey Proskuryakov.
2413
2414         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2415         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2416         also made.
2417
2418         * Carbon/CarbonWindowAdapter.mm:
2419         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2420         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2421         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2422         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2423         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2424         (-[CarbonWindowAdapter dealloc]):
2425         (-[CarbonWindowAdapter windowRef]):
2426         (-[CarbonWindowAdapter _hasWindowRef]):
2427         (-[CarbonWindowAdapter _managesWindowRef]):
2428         (-[CarbonWindowAdapter _removeWindowRef]):
2429         (-[CarbonWindowAdapter _carbonWindowClass]):
2430         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2431         (-[CarbonWindowAdapter sendSuperEvent:]):
2432         (-[CarbonWindowAdapter relinquishFocus]):
2433         (-[CarbonWindowAdapter _cancelKey:]):
2434         (-[CarbonWindowAdapter _commonAwake]):
2435         (-[CarbonWindowAdapter _destroyRealWindow:]):
2436         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2437         (-[CarbonWindowAdapter _termWindowIfOwner]):
2438         (-[CarbonWindowAdapter _windowMovedToRect:]):
2439         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2440         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2441         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2442         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2443         (-[CarbonWindowAdapter canBecomeMainWindow]):
2444         (-[CarbonWindowAdapter encodeWithCoder:]):
2445         (-[CarbonWindowAdapter initWithCoder:]):
2446         (-[CarbonWindowAdapter setContentView:]):
2447         (-[CarbonWindowAdapter worksWhenModal]):
2448         (-[CarbonWindowAdapter _setModalWindowLevel]):
2449         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2450         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2451         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2452         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2453         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2454         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2455         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2456         (NSCarbonWindowHandleEvent):
2457         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2458         (-[CarbonWindowAdapter _growBoxRect]):
2459         * Carbon/HIWebView.mm:
2460         (HIWebViewGetWebView):
2461         (HIWebViewConstructor):
2462         (HIWebViewDestructor):
2463         (HIWebViewRegisterClass):
2464         (GetBehaviors):
2465         (Draw):
2466         (HitTest):
2467         (GetRegion):
2468         (GetWindowRef):
2469         (CreateNSEventAdoptingCGEvent):
2470         (CopyEventCGEvent):
2471         (CreateNSEventWithCarbonClickEvent):
2472         (Click):
2473         (CreateNSEventWithCarbonEvent):
2474         (MouseUp):
2475         (CreateNSEventWithCarbonMouseMoveEvent):
2476         (MouseMoved):
2477         (MouseDragged):
2478         (MouseWheelMoved):
2479         (ContextMenuClick):
2480         (GetKind):
2481         (BoundsChanged):
2482         (OwningWindowChanged):
2483         (WindowHandler):
2484         (SyncFrame):
2485         (SetFocusPart):
2486         (AdvanceFocus):
2487         (RelinquishFocus):
2488         (ActiveStateChanged):
2489         (ProcessCommand):
2490         (UpdateCommandStatus):
2491         (_NSSelectorForHICommand):
2492         (HIWebViewEventHandler):
2493         (StartUpdateObserver):
2494         (StopUpdateObserver):
2495         (UpdateObserver):
2496
2497 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2498
2499         Make PolicyAction an encodable enum class
2500         https://bugs.webkit.org/show_bug.cgi?id=177480
2501
2502         Reviewed by Antti Koivisto.
2503
2504         * Plugins/WebPluginContainerCheck.mm:
2505         (-[WebPluginContainerCheck _continueWithPolicy:]):
2506         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2507         * WebCoreSupport/WebFrameLoaderClient.mm:
2508         (-[WebFramePolicyListener invalidate]):
2509         (-[WebFramePolicyListener ignore]):
2510         (-[WebFramePolicyListener download]):
2511         (-[WebFramePolicyListener use]):
2512         (-[WebFramePolicyListener continue]):
2513         * WebView/WebPolicyDelegate.mm:
2514         (-[WebPolicyDecisionListener use]):
2515         (-[WebPolicyDecisionListener ignore]):
2516         (-[WebPolicyDecisionListener download]):
2517
2518 2017-09-25  Frederik Riedel  <riedel@apple.com>
2519
2520         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2521         https://bugs.webkit.org/show_bug.cgi?id=174394
2522         <rdar://problem/33183504>
2523
2524         Reviewed by Ryosuke Niwa.
2525
2526         * DOM/DOMHTMLInputElement.h:
2527         * DOM/DOMHTMLInputElement.mm:
2528         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2529         Determines if this HTMLInputElement is part of a login screen.
2530         (-[DOMHTMLInputElement representingPageUrl]):
2531         Returns the webpage's URL that is currently displayed in the Web View.
2532         (-[DOMHTMLInputElement insertTextSuggestion:]):
2533         Inserts login credentials into the Web View.
2534
2535 2017-09-25  Sam Weinig  <sam@webkit.org>
2536
2537         Remove unused EditorClient functions
2538         https://bugs.webkit.org/show_bug.cgi?id=177463
2539
2540         Reviewed by Alex Christensen.
2541
2542         Remove unused EditorClient functions.
2543
2544         * WebCoreSupport/WebEditorClient.h:
2545         * WebCoreSupport/WebEditorClient.mm:
2546         (WebEditorClient::canonicalizeURL): Deleted.
2547         (WebEditorClient::canonicalizeURLString): Deleted.
2548         (WebEditorClient::writeDataToPasteboard): Deleted.
2549         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2550         (WebEditorClient::readDataFromPasteboard): Deleted.
2551         (WebEditorClient::pasteboardChangeCount): Deleted.
2552
2553 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2554
2555         Stop using PolicyCallback
2556         https://bugs.webkit.org/show_bug.cgi?id=176088
2557
2558         Reviewed by Andy Estes.
2559
2560         * WebCoreSupport/WebFrameLoaderClient.mm:
2561         (-[WebFramePolicyListener invalidate]):
2562         (-[WebFramePolicyListener receivedPolicyDecision:]):
2563
2564 2017-09-25  Sam Weinig  <sam@webkit.org>
2565
2566         Remove unnecessary userVisibleString EditorClient function
2567         https://bugs.webkit.org/show_bug.cgi?id=177456
2568
2569         Reviewed by Dan Bernstein.
2570
2571         * WebCoreSupport/WebEditorClient.h:
2572         * WebCoreSupport/WebEditorClient.mm:
2573         (WebEditorClient::userVisibleString): Deleted.
2574
2575             Remove userVisibleString client function.
2576
2577 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2578
2579         Separate form submission from PolicyChecker infrastructure
2580         https://bugs.webkit.org/show_bug.cgi?id=177396
2581
2582         Reviewed by Geoffrey Garen.
2583
2584         * WebCoreSupport/WebFrameLoaderClient.h:
2585         * WebCoreSupport/WebFrameLoaderClient.mm:
2586         (WebFrameLoaderClient::dispatchWillSubmitForm):
2587
2588 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2589
2590         WeakPtrFactory should populate m_ref lazily.
2591         https://bugs.webkit.org/show_bug.cgi?id=177375
2592
2593         Reviewed by Geoffrey Garen.
2594
2595         * WebCoreSupport/WebEditorClient.mm:
2596         (WebEditorClient::WebEditorClient):
2597         (WebEditorClient::requestCandidatesForSelection):
2598
2599 2017-09-22  Chris Dumez  <cdumez@apple.com>
2600
2601         Use high resolution timestamp for event time
2602         https://bugs.webkit.org/show_bug.cgi?id=154246
2603         <rdar://problem/34333304>
2604
2605         Reviewed by Ryosuke Niwa.
2606
2607         Use WallTime / MonotonicTime instead of double type for clarity.
2608
2609         * DOM/DOMEvent.mm:
2610         (-[DOMEvent timeStamp]):
2611         * WebView/WebFrame.mm:
2612         (-[WebFrame _dragSourceEndedAt:operation:]):
2613         * WebView/WebPDFView.mm:
2614         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2615
2616 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2617
2618         Enable dataTransfer.items on macOS and iOS
2619         https://bugs.webkit.org/show_bug.cgi?id=177335
2620
2621         Reviewed by Sam Weinig.
2622
2623         * WebView/WebPreferences.mm:
2624         (+[WebPreferences initialize]):
2625
2626 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2627
2628         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2629         https://bugs.webkit.org/show_bug.cgi?id=177101
2630         <rdar://problem/34500648>
2631
2632         Reviewed by Brian Burg.
2633
2634         * WebInspector/WebNodeHighlight.mm:
2635         Ensure we close the window that we have just removed.
2636
2637 2017-09-20  Antti Koivisto  <antti@apple.com>
2638
2639         Remove DOM and styling support for CSS Regions
2640         https://bugs.webkit.org/show_bug.cgi?id=177221
2641
2642         Reviewed by Andreas Kling.
2643
2644         * Configurations/FeatureDefines.xcconfig:
2645         * DOM/DOMCSS.mm:
2646         (kitClass):
2647         * DOM/DOMElement.mm:
2648         (-[DOMElement webkitRegionOverset]): Deleted.
2649
2650 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2651
2652         Layering violation in Editor::createFragment
2653         https://bugs.webkit.org/show_bug.cgi?id=176123
2654
2655         Reviewed by Darin Adler.
2656
2657         * Misc/WebNSURLExtras.h:
2658         * Misc/WebNSURLExtras.mm:
2659         * WebView/WebFrame.mm:
2660         * WebView/WebHTMLView.mm:
2661         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2662
2663         * WebCoreSupport/WebEditorClient.mm:
2664         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2665         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2666         way to avoid exporting the symbol just on newer OSes.
2667
2668 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2669
2670         On iOS, getData can't get text set by setData during copy event
2671         https://bugs.webkit.org/show_bug.cgi?id=176980
2672         <rdar://problem/34453915>
2673
2674         Reviewed by Darin Adler.
2675
2676         * WebCoreSupport/WebPlatformStrategies.h:
2677         * WebCoreSupport/WebPlatformStrategies.mm:
2678         (WebPlatformStrategies::copy): Deleted.
2679
2680 2017-09-18  Andy Estes  <aestes@apple.com>
2681
2682         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2683         https://bugs.webkit.org/show_bug.cgi?id=177029
2684
2685         Reviewed by Alex Christensen.
2686
2687         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2688         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2689         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2690         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2691         * WebCoreSupport/PopupMenuMac.mm:
2692         (PopupMenuMac::show):
2693         * WebCoreSupport/WebSystemInterface.mm:
2694         (InitWebCoreSystemInterface):
2695         * WebView/WebHTMLView.mm:
2696         (-[WebHTMLView setDataSource:]):
2697         (-[WebHTMLView attachRootLayer:]):
2698         * WebView/WebView.mm:
2699         (-[WebView _needsAdobeFrameReloadingQuirk]):
2700         (-[WebView _needsLinkElementTextCSSQuirk]):
2701         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2702         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2703         (-[WebView _preferencesChanged:]):
2704
2705 2017-09-15  Andy Estes  <aestes@apple.com>
2706
2707         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2708         https://bugs.webkit.org/show_bug.cgi?id=176953
2709
2710         Reviewed by Eric Carlson.
2711
2712         * WebCoreSupport/WebSystemInterface.mm:
2713         (InitWebCoreSystemInterface):
2714
2715 2017-09-14  Andy Estes  <aestes@apple.com>
2716
2717         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2718         https://bugs.webkit.org/show_bug.cgi?id=176931
2719
2720         Reviewed by Joseph Pecoraro.
2721
2722         * WebCoreSupport/WebSystemInterface.mm:
2723         (InitWebCoreSystemInterface):
2724
2725 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2726
2727         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2728         https://bugs.webkit.org/show_bug.cgi?id=176867
2729
2730         Reviewed by Sam Weinig.
2731
2732         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2733         (WebKit::NetscapePluginInstanceProxy::enumerate):
2734
2735 2017-09-13  Andy Estes  <aestes@apple.com>
2736
2737         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2738         https://bugs.webkit.org/show_bug.cgi?id=176729
2739
2740         Reviewed by Alex Christensen.
2741
2742         * WebCoreSupport/WebSystemInterface.mm:
2743         (InitWebCoreSystemInterface):
2744         * WebView/WebView.mm:
2745         (+[WebView _setCacheModel:]):
2746
2747 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2748
2749         Refactor WebContentReader out of EditorMac and EditorIOS
2750         https://bugs.webkit.org/show_bug.cgi?id=176770
2751
2752         Reviewed by Sam Weinig.
2753
2754         * WebCoreSupport/WebEditorClient.mm:
2755
2756 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2757
2758         Dragging & dropping a file creates an attachment element even when it's disabled
2759         https://bugs.webkit.org/show_bug.cgi?id=176769
2760
2761         Reviewed by Tim Horton.
2762
2763         * WebView/WebView.mm:
2764         (-[WebView _preferencesChanged:]):
2765
2766 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2767
2768         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2769         https://bugs.webkit.org/show_bug.cgi?id=176721
2770         <rdar://problem/34373660>
2771
2772         Reviewed by Tim Horton.
2773
2774         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2775         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2776
2777         * WebView/WebView.mm:
2778         (-[WebView _startDrag:]):
2779         (-[WebView _draggedElementBounds]):
2780         (-[WebView _endedDataInteraction:global:]):
2781         * WebView/WebViewData.h:
2782
2783 2017-09-11  Andy Estes  <aestes@apple.com>
2784
2785         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2786         https://bugs.webkit.org/show_bug.cgi?id=176472
2787
2788         Reviewed by Eric Carlson.
2789
2790         * WebCoreSupport/WebSystemInterface.mm:
2791         (InitWebCoreSystemInterface):
2792
2793 2017-09-09  Mark Lam  <mark.lam@apple.com>
2794
2795         Avoid duplicate computations of ExecState::vm().
2796         https://bugs.webkit.org/show_bug.cgi?id=176647
2797
2798         Reviewed by Saam Barati.
2799
2800         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2801         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2802         (WebKit::NetscapePluginInstanceProxy::construct):
2803         (WebKit::NetscapePluginInstanceProxy::setProperty):
2804         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2805         (WebKit::NetscapePluginInstanceProxy::enumerate):
2806         * Plugins/Hosted/ProxyInstance.mm:
2807         (WebKit::ProxyRuntimeMethod::create):
2808
2809 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2810
2811         Unreviewed, rolling out r221773.
2812         https://bugs.webkit.org/show_bug.cgi?id=176614
2813
2814         This caused build failures. (Requested by mlewis13 on
2815         #webkit).
2816
2817         Reverted changeset:
2818
2819         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2820         https://bugs.webkit.org/show_bug.cgi?id=176472
2821         http://trac.webkit.org/changeset/221773
2822
2823 2017-09-07  Andy Estes  <aestes@apple.com>
2824
2825         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2826         https://bugs.webkit.org/show_bug.cgi?id=176472
2827
2828         Reviewed by Eric Carlson.
2829
2830         * WebCoreSupport/WebSystemInterface.mm:
2831         (InitWebCoreSystemInterface):
2832
2833 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2834
2835         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2836         https://bugs.webkit.org/show_bug.cgi?id=176561
2837
2838         Reviewed by Brent Fulgham.
2839
2840         * Misc/WebNSUserDefaultsExtras.mm:
2841
2842 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2843
2844         Modernize Geolocation code
2845         https://bugs.webkit.org/show_bug.cgi?id=176496
2846
2847         Reviewed by Andy Estes.
2848
2849         * WebCoreSupport/WebGeolocationClient.h:
2850         * WebCoreSupport/WebGeolocationClient.mm:
2851         (WebGeolocationClient::requestPermission):
2852         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2853         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2854         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2855         * WebView/WebView.mm:
2856         (-[WebView _commonInitializationWithFrameName:groupName:]):
2857         (-[WebView _geolocationDidFailWithMessage:]):
2858
2859 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2860
2861         Remove some unused bits of code and resources
2862         https://bugs.webkit.org/show_bug.cgi?id=176275
2863
2864         Reviewed by Dan Bernstein.
2865
2866         * Misc/WebNSFileManagerExtras.mm:
2867         Include FileSystem instead of FileSystemIOS.
2868
2869 2017-09-03  Darin Adler  <darin@apple.com>
2870
2871         [Cocoa] Tidy a few things in legacy WebHTMLView
2872         https://bugs.webkit.org/show_bug.cgi?id=176280
2873
2874         Reviewed by Dan Bernstein.
2875
2876         * WebCoreSupport/WebChromeClient.mm:
2877         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2878         methods it calls on WebHTMLView were doing nothing on iOS.
2879
2880         * WebView/WebFrame.mm:
2881         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2882         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2883
2884         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2885         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2886         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2887         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2888         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2889         Use RetainPtr instead of writing retain/release wherever possible.
2890         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2891         initialization for it. Removed various unused methods and declarations of methods.
2892         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2893         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2894         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2895         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2896         and remove CFRetain no longer needed since we don't support garbage collection any more.
2897         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2898         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2899         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2900         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2901         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2902         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2903         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2904         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2905         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2906         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2907         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2908         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2909         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2910         debug flag; we haven't used it for years and it's not clearly helpful.
2911         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2912         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2913         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2914         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2915         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2916         two additional methods in the WebPrivate category and still be called by the two
2917         methods in the WebInternal category that were already using it.
2918         (-[WebHTMLView didAddSubview:]): Deleted.
2919         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2920         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2921         place this was called, the close method.
2922         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2923         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2924         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2925         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2926         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2927         Added helper method to make the one below simpler.
2928         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2929         Compared pasteboard type strings using isEqualToString: rather than using == since
2930         we want to actually compare the string contents. Also updated to use modern for loop,
2931         renamed a local variable from "s" to "localSubresources", and factored out the handling
2932         of three image types to use the helper method above.
2933         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2934         _web_makePluginSubviewsPerformSelector:withObject: method.
2935         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2936         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2937         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2938         not call the -[NSView subviews] method to make this identical on both platforms and used
2939         a modern for loop.
2940         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2941         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2942         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2943         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2944         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2945         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2946         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2947         of it is Mac-only.
2948         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2949         method did was call itself on the main thread, and do nothing if called on main thread.
2950         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2951         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2952         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2953         half of this method.
2954         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2955         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2956         Simplified using a modern for loop and RetainPtr.
2957         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2958         (-[WebHTMLView keyDown:]): Ditto.
2959         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2960         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2961         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2962         (-[WebHTMLView complete:]): Ditto.
2963         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2964         now macOS-only.
2965         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2966         iOS since that is now macOS-only.
2967         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2968         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2969         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2970         and reorganized to use early return.
2971         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2972         on iOS, but kept there so we don't have to do #if at every call site.
2973         (-[WebHTMLView _pluginController]): Moved into internal category.
2974         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2975         there only for GC, using C++ initialization, removing obsolete comment.
2976         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2977         peculiar iOS-only comment.
2978         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2979
2980         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2981         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2982         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2983         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2984         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2985
2986         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2987         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2988         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2989         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2990         them at this time.
2991
2992 2017-09-03  Sam Weinig  <sam@webkit.org>
2993
2994         Remove CanvasProxy
2995         https://bugs.webkit.org/show_bug.cgi?id=176288
2996
2997         Reviewed by Yusuke Suzuki.
2998
2999         CanvasProxy does not appear to be in any current HTML spec
3000         and was disabled and unimplemented in our tree. Time to 
3001         get rid of it.
3002
3003         * Configurations/FeatureDefines.xcconfig:
3004
3005 2017-09-02  Andy Estes  <aestes@apple.com>
3006
3007         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3008         https://bugs.webkit.org/show_bug.cgi?id=176270
3009
3010         Reviewed by Tim Horton.
3011
3012         * Plugins/Hosted/NetscapePluginHostManager.mm:
3013         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3014         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3015         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3016         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3017         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3018         (WebKit::SoftwareCARenderer::context const):
3019         (WebKit::SoftwareCARenderer::renderContext const):
3020         (WebKit::SoftwareCARenderer::render):
3021         (-[WebHostedNetscapePluginView createPlugin]):
3022         (-[WebHostedNetscapePluginView createPluginLayer]):
3023         (-[WebHostedNetscapePluginView destroyPlugin]):
3024         (-[WebHostedNetscapePluginView drawRect:]):
3025         * WebCoreSupport/WebSystemInterface.mm:
3026         (InitWebCoreSystemInterface):
3027
3028 2017-09-01  Andy Estes  <aestes@apple.com>
3029
3030         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3031         https://bugs.webkit.org/show_bug.cgi?id=176200
3032
3033         Reviewed by Tim Horton.
3034
3035         * Carbon/HIWebView.mm:
3036         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3037         (overrideCGContext):
3038         (restoreCGContext):
3039         (Draw):
3040         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3041         (+[WebHostedNetscapePluginView initialize]):
3042         * Plugins/WebBaseNetscapePluginView.h:
3043         * Plugins/WebBaseNetscapePluginView.mm:
3044         (WebKit::sendUserChangeNotifications):
3045         * Plugins/WebNetscapePluginView.mm:
3046         (+[WebNetscapePluginView initialize]):
3047         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3048         * WebCoreSupport/WebSystemInterface.mm:
3049         (InitWebCoreSystemInterface):
3050         * WebView/WebFrame.mm:
3051         (-[WebFrame _paintBehaviorForDestinationContext:]):
3052         * WebView/WebFullScreenController.mm:
3053         (setClipRectForWindow):
3054         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3055         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3056         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3057         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3058
3059 2017-08-31  Andy Estes  <aestes@apple.com>
3060
3061         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3062         https://bugs.webkit.org/show_bug.cgi?id=176175
3063
3064         Reviewed by Brady Eidson.
3065
3066         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3067         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3068         * Plugins/Hosted/WebTextInputWindowController.m:
3069         (-[WebTextInputPanel init]):
3070         * WebCoreSupport/WebSystemInterface.mm:
3071         (InitWebCoreSystemInterface):
3072         * WebView/WebDynamicScrollBarsView.mm:
3073         (-[WebDynamicScrollBarsView scrollWheel:]):
3074         * WebView/WebHTMLView.mm:
3075         (-[WebHTMLView _removeWindowObservers]):
3076         (-[WebHTMLView addWindowObservers]):
3077         * WebView/WebView.mm:
3078         (-[WebView addWindowObserversForWindow:]):
3079         (-[WebView removeWindowObservers]):
3080         (-[WebView viewWillMoveToWindow:]):
3081
3082 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3083
3084         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3085         https://bugs.webkit.org/show_bug.cgi?id=175779
3086         <rdar://problem/22367975>
3087
3088         Reviewed by Tim Horton.
3089
3090         * WebCoreSupport/WebFrameLoaderClient.h:
3091         * WebCoreSupport/WebFrameLoaderClient.mm:
3092         (WebFrameLoaderClient::webGLPolicyForURL const):
3093         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3094
3095 2017-08-30  Andy Estes  <aestes@apple.com>
3096
3097         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3098         https://bugs.webkit.org/show_bug.cgi?id=176093
3099
3100         Reviewed by Eric Carlson.
3101
3102         * WebCoreSupport/WebSystemInterface.mm:
3103         (InitWebCoreSystemInterface):
3104
3105 2017-08-30  Andy Estes  <aestes@apple.com>
3106
3107         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3108         https://bugs.webkit.org/show_bug.cgi?id=176087
3109
3110         Reviewed by Alex Christensen.
3111
3112         * Carbon/CarbonUtils.m:
3113         (getNSAutoreleasePoolCount):
3114         (WebInitForCarbon):
3115         (PoolCleaner):
3116         * Carbon/CarbonWindowAdapter.mm:
3117         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3118         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3119         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3120         (-[CarbonWindowAdapter _windowMovedToRect:]):
3121         * Carbon/HIViewAdapter.m:
3122         * Carbon/HIWebView.mm:
3123         (Draw):
3124         (CreateNSEventAdoptingCGEvent):
3125         (CopyEventCGEvent):
3126         (CreateNSEventWithCarbonClickEvent):
3127         (Click):
3128         (CreateNSEventWithCarbonEvent):
3129         (MouseUp):
3130         (CreateNSEventWithCarbonMouseMoveEvent):
3131         (MouseMoved):
3132         (MouseDragged):
3133         (MouseWheelMoved):
3134         (WindowHandler):
3135         (HIWebViewEventHandler):
3136         * Misc/QuickDrawCompatibility.h: Removed.
3137         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3138         (getCarbonEvent):
3139         (WebNetscapePluginEventHandlerCarbon::keyDown):
3140         (WebNetscapePluginEventHandlerCarbon::keyUp):
3141         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3142         (WebNetscapePluginEventHandlerCocoa::keyDown):
3143         * Plugins/WebNetscapePluginView.mm:
3144         (-[WebNetscapePluginView tellQuickTimeToChill]):
3145
3146 2017-08-29  Andy Estes  <aestes@apple.com>
3147
3148         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3149         https://bugs.webkit.org/show_bug.cgi?id=176046
3150
3151         Reviewed by Alex Christensen.
3152
3153         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3154         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3155
3156         * Misc/WebNSFileManagerExtras.mm:
3157         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3158         (setMetaData): Deleted.
3159         * WebCoreSupport/WebSystemInterface.mm:
3160         (InitWebCoreSystemInterface):
3161
3162 2017-08-28  Andy Estes  <aestes@apple.com>
3163
3164         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3165         https://bugs.webkit.org/show_bug.cgi?id=176039
3166
3167         Reviewed by Alex Christensen.
3168
3169         * WebCoreSupport/WebSystemInterface.mm:
3170         (InitWebCoreSystemInterface):
3171         * WebView/WebPreferences.mm:
3172         (+[WebPreferences _systemCFStringEncoding]):
3173
3174 2017-08-28  Andy Estes  <aestes@apple.com>
3175
3176         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3177         https://bugs.webkit.org/show_bug.cgi?id=176032
3178
3179         Reviewed by Alex Christensen.
3180
3181         * WebCoreSupport/WebSystemInterface.mm:
3182         (InitWebCoreSystemInterface):
3183         * WebView/WebView.mm:
3184         (-[WebView _cachedResponseForURL:]):
3185
3186 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3187
3188         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3189         https://bugs.webkit.org/show_bug.cgi?id=175992
3190         <rdar://problem/34086613>
3191
3192         Reviewed by Daniel Bates.
3193
3194         * WebCoreSupport/WebPlatformStrategies.h:
3195         * WebCoreSupport/WebPlatformStrategies.mm:
3196         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3197         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3198         indicating if secure cookies were accessed.
3199
3200 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3201
3202         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3203         https://bugs.webkit.org/show_bug.cgi?id=170955
3204         <rdar://problem/31697653>
3205
3206         Reviewed by Ryosuke Niwa.
3207
3208         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3209         text is being replaced.
3210
3211         * WebView/WebHTMLView.mm:
3212         (-[WebHTMLView insertText:]):
3213
3214 2017-08-24  Chris Dumez  <cdumez@apple.com>
3215
3216         [Directory Upload] Add basic support for input.webkitdirectory
3217         https://bugs.webkit.org/show_bug.cgi?id=175950
3218         <rdar://problem/33951915>
3219
3220         Reviewed by Geoffrey Garen.
3221
3222         Add private API to toggle Directory Upload support on Mac WebKit1.
3223
3224         * WebView/WebPreferenceKeysPrivate.h:
3225         * WebView/WebPreferences.mm:
3226         (+[WebPreferences initialize]):
3227         (-[WebPreferences setDirectoryUploadEnabled:]):
3228         (-[WebPreferences directoryUploadEnabled]):
3229         * WebView/WebPreferencesPrivate.h:
3230         * WebView/WebView.mm:
3231         (-[WebView _preferencesChanged:]):
3232
3233 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3234
3235         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3236         https://bugs.webkit.org/show_bug.cgi?id=175370
3237         <rdar://problem/33799806>
3238
3239         Reviewed by Ryosuke Niwa.
3240
3241         Adjust WebEditorClient for interface changes.
3242
3243         * WebCoreSupport/WebEditorClient.h:
3244
3245 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3246
3247         Remove ChromeClient::scrollbarsModeDidChange
3248         https://bugs.webkit.org/show_bug.cgi?id=175805
3249
3250         Reviewed by Daniel Bates.
3251
3252         * WebCoreSupport/WebChromeClient.h:
3253
3254 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3255
3256         Remove ChromeClient::hasOpenedPopup
3257         https://bugs.webkit.org/show_bug.cgi?id=175804
3258
3259         Reviewed by Sam Weinig.
3260
3261         * WebCoreSupport/WebChromeClient.h:
3262         * WebCoreSupport/WebChromeClient.mm:
3263         (WebChromeClient::hasOpenedPopup const): Deleted.
3264
3265 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3266
3267         Disable access to secure cookies if an HTTPS site loads mixed content
3268         https://bugs.webkit.org/show_bug.cgi?id=157053
3269         <rdar://problem/11290808>
3270
3271         Reviewed by Dan Bates.
3272
3273         * WebCoreSupport/WebPlatformStrategies.h:
3274         * WebCoreSupport/WebPlatformStrategies.mm:
3275         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3276         indicating whether secure cookies should be included in the response.
3277
3278 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3279
3280         [PAL] Move spi/mac directory into PAL
3281         https://bugs.webkit.org/show_bug.cgi?id=175649
3282
3283         Reviewed by Myles C. Maxfield.
3284
3285         * Misc/WebSharingServicePickerController.h:
3286         * WebCoreSupport/WebContextMenuClient.mm:
3287         * WebCoreSupport/WebEditorClient.mm:
3288         * WebCoreSupport/WebSelectionServiceController.mm:
3289         * WebView/WebHTMLView.mm:
3290         * WebView/WebImmediateActionController.h:
3291         * WebView/WebImmediateActionController.mm:
3292         * WebView/WebView.mm:
3293
3294 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3295
3296         [PAL] Relocate SessionID to root
3297         https://bugs.webkit.org/show_bug.cgi?id=175684
3298
3299         Reviewed by Alex Christensen.
3300
3301         * WebCoreSupport/WebFrameNetworkingContext.mm:
3302
3303 2017-08-17  Andreas Kling  <akling@apple.com>
3304
3305         Disable CSS regions at compile time
3306         https://bugs.webkit.org/show_bug.cgi?id=175630
3307
3308         Reviewed by Antti Koivisto.
3309
3310         * Configurations/FeatureDefines.xcconfig:
3311
3312 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3313
3314         [PAL] Move SessionID into PAL
3315         https://bugs.webkit.org/show_bug.cgi?id=174192
3316
3317         Reviewed by Antti Koivisto.
3318
3319         * Misc/WebCache.mm:
3320         (+[WebCache imageForURL:]):
3321         * WebCoreSupport/WebFrameLoaderClient.h:
3322         * WebCoreSupport/WebFrameLoaderClient.mm:
3323         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3324         * WebCoreSupport/WebFrameNetworkingContext.mm:
3325         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3326         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3327         (WebFrameNetworkingContext::storageSession const):
3328         * WebCoreSupport/WebPlatformStrategies.h:
3329         * WebCoreSupport/WebPlatformStrategies.mm:
3330         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3331         * WebKitPrefix.h:
3332
3333 2017-08-16  Andy Estes  <aestes@apple.com>
3334
3335         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3336         https://bugs.webkit.org/show_bug.cgi?id=175648
3337
3338         Reviewed by Tim Horton.
3339
3340         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3341         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3342         (WebPaymentCoordinatorClient::showPaymentUI):
3343
3344 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3345
3346         [PAL] Move spi/ios and spi/win directories into PAL
3347         https://bugs.webkit.org/show_bug.cgi?id=175171
3348
3349         Reviewed by Antti Koivisto.
3350
3351         * WebCoreSupport/WebFrameLoaderClient.mm:
3352         * WebView/WebView.mm:
3353
3354 2017-08-16  Andy Estes  <aestes@apple.com>
3355
3356         [Payment Request] Add an ENABLE flag and an experimental feature preference
3357         https://bugs.webkit.org/show_bug.cgi?id=175622
3358
3359         Reviewed by Tim Horton.
3360
3361         * Configurations/FeatureDefines.xcconfig:
3362
3363 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3364
3365         [PAL] Move Sleep classes into PAL
3366         https://bugs.webkit.org/show_bug.cgi?id=175456
3367
3368         Reviewed by Ryosuke Niwa.
3369
3370         * WebView/WebFullScreenController.h:
3371
3372 2017-08-15  Youenn Fablet  <youenn@apple.com>
3373
3374         [Cache API] Adding generic support for CacheStorage and Cache methods
3375         https://bugs.webkit.org/show_bug.cgi?id=175455
3376
3377         Reviewed by Chris Dumez.
3378
3379         * WebView/WebView.mm:
3380         (-[WebView _commonInitializationWithFrameName:groupName:]):
3381
3382 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3383
3384         Remove Proximity Events and related code
3385         https://bugs.webkit.org/show_bug.cgi?id=175545
3386
3387         Reviewed by Daniel Bates.
3388
3389         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3390         and other related code.
3391
3392         * Configurations/FeatureDefines.xcconfig:
3393
3394 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3395
3396         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3397         https://bugs.webkit.org/show_bug.cgi?id=175504
3398
3399         Reviewed by Sam Weinig.
3400
3401         * Configurations/FeatureDefines.xcconfig:
3402         * DOM/DOMHTMLFormElement.mm:
3403         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3404         * WebCoreSupport/WebFrameLoaderClient.h:
3405
3406 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3407
3408         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3409         https://bugs.webkit.org/show_bug.cgi?id=175557
3410
3411         Reviewed by Jon Lee.
3412
3413         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3414
3415         * Configurations/FeatureDefines.xcconfig:
3416
3417 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3418
3419         Composition underline color is always black
3420         https://bugs.webkit.org/show_bug.cgi?id=174675
3421
3422         Reviewed by Ryosuke Niwa.
3423
3424         * WebView/WebHTMLView.mm:
3425         (extractUnderlines): If NSUnderlineColorAttributeName
3426         is not present use text color for composition underline.
3427         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3428         for composition underline in the plain text case.
3429
3430 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3431
3432         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3433         https://bugs.webkit.org/show_bug.cgi?id=175474
3434         <rdar://problem/33844628>
3435
3436         Reviewed by Wenson Hsieh.
3437
3438         Replaced the build flag by a runtime flag and disabled the feature by default.
3439
3440         * Configurations/FeatureDefines.xcconfig:
3441         * WebView/WebPreferenceKeysPrivate.h:
3442         * WebView/WebPreferences.mm:
3443         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3444         (-[WebPreferences dataTransferItemsEnabled]): Added.
3445         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3446         * WebView/WebPreferencesPrivate.h:
3447         * WebView/WebView.mm:
3448         (-[WebView _preferencesChanged:]):
3449
3450 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3451
3452         Remove ENABLE_GAMEPAD_DEPRECATED
3453         https://bugs.webkit.org/show_bug.cgi?id=175361
3454
3455         Reviewed by Carlos Garcia Campos.
3456
3457         * Configurations/FeatureDefines.xcconfig:
3458
3459 2017-08-09  Chris Dumez  <cdumez@apple.com>
3460
3461         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3462         https://bugs.webkit.org/show_bug.cgi?id=175401
3463
3464         Reviewed by Brady Eidson.
3465
3466         * WebView/WebPreferenceKeysPrivate.h:
3467         * WebView/WebPreferences.mm:
3468         (+[WebPreferences initialize]):
3469         (-[WebPreferences beaconAPIEnabled]): Deleted.
3470         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3471         * WebView/WebPreferencesPrivate.h:
3472         * WebView/WebView.mm:
3473         (-[WebView _preferencesChanged:]):
3474
3475 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3476
3477         [PAL] Move spi/cocoa and spi/cg directories into PAL
3478         https://bugs.webkit.org/show_bug.cgi?id=175175
3479
3480         Reviewed by Myles C. Maxfield.
3481
3482         * History/WebHistory.mm:
3483         * Misc/WebDownload.mm:
3484         * Misc/WebKitNSStringExtras.mm:
3485         * Plugins/Hosted/NetscapePluginHostManager.mm:
3486         * Plugins/WebPluginDatabase.mm:
3487         * WebCoreSupport/WebFrameLoaderClient.mm:
3488         * WebInspector/WebNodeHighlight.mm:
3489         * WebView/WebHTMLView.mm:
3490         * WebView/WebIndicateLayer.mm:
3491         * WebView/WebView.mm:
3492         * WebView/WebViewData.h:
3493
3494 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3495
3496         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3497         https://bugs.webkit.org/show_bug.cgi?id=175392
3498         <rdar://problem/33783207>
3499
3500         Reviewed by Tim Horton and Megan Gardner.
3501
3502         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3503
3504         * Configurations/FeatureDefines.xcconfig:
3505
3506 2017-08-09  Daniel Bates  <dabates@apple.com>
3507
3508         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3509         https://bugs.webkit.org/show_bug.cgi?id=175247
3510         <rdar://problem/33679804>
3511
3512         Reviewed by Brady Eidson.
3513
3514         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3515         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3516         clients that need to make use of this information at this time. If such a needs comes up
3517         then we can expose API/SPI similar to what we do for WebKit.
3518
3519         * WebCoreSupport/WebFrameLoaderClient.h:
3520         * WebCoreSupport/WebFrameLoaderClient.mm:
3521         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3522
3523 2017-08-08  Brady Eidson  <beidson@apple.com>
3524
3525         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3526         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3527
3528         Reviewed by Andy Estes.
3529
3530         * Misc/WebKitVersionChecks.h:
3531         * WebCoreSupport/WebFrameLoaderClient.mm:
3532         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3533           the app is linked against new WebKit with the new behavior.
3534
3535 2017-08-07  Devin Rousso  <drousso@apple.com>
3536
3537         Web Inspector: Preview Canvas path when viewing a recording
3538         https://bugs.webkit.org/show_bug.cgi?id=174967
3539
3540         Reviewed by Brian Burg.
3541
3542         * WebView/WebPreferenceKeysPrivate.h:
3543         * WebView/WebPreferences.mm:
3544         (+[WebPreferences initialize]):
3545         (-[WebPreferences inspectorAdditionsEnabled]):
3546         (-[WebPreferences setInspectorAdditionsEnabled:]):
3547         * WebView/WebPreferencesPrivate.h:
3548         * WebView/WebView.mm:
3549         (-[WebView _preferencesChanged:]):
3550         Add plumbing for new InspectorAdditions runtime flag.
3551
3552 2017-08-07  Brian Burg  <bburg@apple.com>
3553
3554         Remove CANVAS_PATH compilation guard
3555         https://bugs.webkit.org/show_bug.cgi?id=175207
3556
3557         Reviewed by Sam Weinig.
3558
3559         * Configurations/FeatureDefines.xcconfig:
3560
3561 2017-08-04  Youenn Fablet  <youenn@apple.com>
3562
3563         [Cache API] Add Cache and CacheStorage IDL definitions
3564         https://bugs.webkit.org/show_bug.cgi?id=175201
3565
3566         Reviewed by Brady Eidson.
3567
3568         * WebView/WebPreferenceKeysPrivate.h:
3569         * WebView/WebPreferences.mm:
3570         (+[WebPreferences initialize]):
3571         (-[WebPreferences cacheAPIEnabled]):
3572         (-[WebPreferences setCacheAPIEnabled:]):
3573         * WebView/WebPreferencesPrivate.h:
3574         * WebView/WebView.mm:
3575         (-[WebView _preferencesChanged:]):
3576
3577 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3578
3579         Unreviewed, rolling out r220271.
3580
3581         Rolling out due to Layout Test failing on iOS Simulator.
3582
3583         Reverted changeset:
3584
3585         "Remove STREAMS_API compilation guard"
3586         https://bugs.webkit.org/show_bug.cgi?id=175165
3587         http://trac.webkit.org/changeset/220271
3588
3589 2017-08-04  Youenn Fablet  <youenn@apple.com>
3590
3591         Remove STREAMS_API compilation guard
3592         https://bugs.webkit.org/show_bug.cgi?id=175165
3593
3594         Reviewed by Darin Adler.
3595
3596         * Configurations/FeatureDefines.xcconfig:
3597         * WebView/WebPreferences.mm:
3598         (+[WebPreferences initialize]):
3599         * WebView/WebView.mm:
3600         (-[WebView _preferencesChanged:]):
3601
3602 2017-08-03  Brian Burg  <bburg@apple.com>
3603
3604         Remove ENABLE(WEB_SOCKET) guards
3605         https://bugs.webkit.org/show_bug.cgi?id=167044
3606
3607         Reviewed by Joseph Pecoraro.
3608
3609         * Configurations/FeatureDefines.xcconfig:
3610         * WebView/WebPreferencesPrivate.h:
3611
3612 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3613
3614         [PAL] Move spi/cf directory into PAL
3615         https://bugs.webkit.org/show_bug.cgi?id=175057
3616
3617         Reviewed by Antti Koivisto.
3618
3619         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3620         * Plugins/WebNetscapePluginStream.mm:
3621         * WebCoreSupport/WebFrameNetworkingContext.mm:
3622         * WebView/WebPreferences.mm:
3623         * WebView/WebView.mm:
3624
3625 2017-08-03  Youenn Fablet  <youenn@apple.com>
3626
3627         Remove FETCH_API compilation guard
3628         https://bugs.webkit.org/show_bug.cgi?id=175154
3629
3630         Reviewed by Chris Dumez.
3631
3632         * Configurations/FeatureDefines.xcconfig:
3633         * WebView/WebPreferences.mm:
3634         (+[WebPreferences initialize]):
3635         * WebView/WebView.mm:
3636         (-[WebView _preferencesChanged:]):
3637
3638 2017-08-03  Brady Eidson  <beidson@apple.com>
3639
3640         Add SW IDLs and stub out basic functionality.
3641         https://bugs.webkit.org/show_bug.cgi?id=175115
3642
3643         Reviewed by Chris Dumez.
3644
3645         * Configurations/FeatureDefines.xcconfig:
3646
3647 2017-08-02  Sam Weinig  <sam@webkit.org>
3648
3649         [WebIDL] Convert MutationCallback to be a normal generated callback
3650         https://bugs.webkit.org/show_bug.cgi?id=174140
3651
3652         Reviewed by Darin Adler.
3653
3654         * DOM/DOMDocument.mm:
3655         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3656         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3657         Pass, now necessary, Document to NativeNodeFilter constructor.
3658
3659 2017-08-01  Chris Dumez  <cdumez@apple.com>
3660
3661         Add initial support for navigator.sendBeacon
3662         https://bugs.webkit.org/show_bug.cgi?id=175007
3663         <rdar://problem/33547728>
3664
3665         Reviewed by Sam Weinig.
3666
3667         Add setting to toggle support for the Beacon API (it is disabled by default).
3668
3669         * WebView/WebPreferenceKeysPrivate.h:
3670         * WebView/WebPreferences.mm:
3671         (+[WebPreferences initialize]):
3672         (-[WebPreferences beaconAPIEnabled]):
3673         (-[WebPreferences setBeaconAPIEnabled:]):
3674         * WebView/WebPreferencesPrivate.h:
3675         * WebView/WebView.mm:
3676         (-[WebView _preferencesChanged:]):
3677
3678 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3679
3680         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3681         https://bugs.webkit.org/show_bug.cgi?id=174437
3682
3683         Reviewed by Darin Adler.
3684
3685         Remove redundant Web- prefix from classes in WebKit namespace.
3686
3687         * WebView/WebView.mm:
3688         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3689         * WebView/WebViewData.h:
3690         * WebView/WebViewData.mm:
3691
3692 2017-07-26  Brian Burg  <bburg@apple.com>
3693
3694         Remove WEB_TIMING feature flag
3695         https://bugs.webkit.org/show_bug.cgi?id=174795
3696
3697         Reviewed by Alex Christensen.
3698
3699         * Configurations/FeatureDefines.xcconfig:
3700
3701 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3702
3703         Async image decoding for large images should be disabled after the first time a tile is painted
3704         https://bugs.webkit.org/show_bug.cgi?id=174451
3705         <rdar://problem/31246421>
3706
3707         Reviewed by Simon Fraser.
3708
3709         * WebView/WebFrame.mm:
3710         (-[WebFrame _paintBehaviorForDestinationContext:]):
3711         (-[WebFrame _drawRect:contentsOnly:]):
3712         * WebView/WebHTMLView.mm:
3713         (imageFromRect):
3714
3715 2017-07-23  Darin Adler  <darin@apple.com>
3716
3717         More NeverDestroyed and related cleanup
3718         https://bugs.webkit.org/show_bug.cgi?id=174745
3719
3720         Reviewed by Alex Christensen.
3721
3722         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3723         for names that aren't even used in this file.
3724         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3725         -[NSArray arrayWithObject:].
3726         (-[DOMNode absoluteQuads]): Ditto.
3727         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3728         of writing out various types.
3729         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3730         syntax instea of -[NSArray arrayWithObject:].
3731         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3732         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3733         of writing out various types.
3734         (-[DOMHTMLImageElement mimeType]): Ditto.
3735
3736 2017-07-24  Chris Dumez  <cdumez@apple.com>
3737
3738         ExceptionCode enumeration should use modern exception names
3739         https://bugs.webkit.org/show_bug.cgi?id=174794
3740
3741         Reviewed by Geoffrey Garen.
3742
3743         * DOM/ExceptionHandlers.mm:
3744         (raiseNotSupportedErrorException):
3745
3746 2017-07-23  Chris Dumez  <cdumez@apple.com>
3747
3748         Drop ExceptionCodeDescription class
3749         https://bugs.webkit.org/show_bug.cgi?id=174757
3750
3751         Reviewed by Darin Adler.
3752
3753         Stop using ExceptionCodeDescription.
3754
3755         * DOM/ExceptionHandlers.mm:
3756         (raiseDOMErrorException):
3757
3758 2017-07-21  Andreas Kling  <akling@apple.com>
3759
3760         Use more references in event dispatch code
3761         https://bugs.webkit.org/show_bug.cgi?id=174681
3762
3763         Reviewed by Geoffrey Garen.
3764
3765         * DOM/ObjCEventListener.h:
3766         * DOM/ObjCEventListener.mm:
3767         (WebCore::ObjCEventListener::handleEvent):
3768         * WebCoreSupport/WebFrameLoaderClient.mm:
3769         (NetscapePluginWidget::handleEvent):
3770
3771 2017-07-21  Brady Eidson  <beidson@apple.com>
3772
3773         Get rid of WebCore IconDatabase code.
3774         https://bugs.webkit.org/show_bug.cgi?id=174700
3775
3776         Reviewed by Tim Horton.
3777
3778         * Misc/WebCoreStatistics.mm:
3779         (+[WebCoreStatistics iconPageURLMappingCount]):
3780         (+[WebCoreStatistics iconRetainedPageURLCount]):
3781         (+[WebCoreStatistics iconRecordCount]):
3782         (+[WebCoreStatistics iconsWithDataCount]):
3783         * WebCoreSupport/WebFrameLoaderClient.h:
3784         * WebCoreSupport/WebFrameLoaderClient.mm:
3785         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
3786         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
3787         * WebView/WebView.mm:
3788         (-[WebView mainFrameIconURL]):
3789
3790 2017-07-20  Chris Dumez  <cdumez@apple.com>
3791
3792         Drop legacy XPathException type
3793         https://bugs.webkit.org/show_bug.cgi?id=174679
3794
3795         Reviewed by Sam Weinig.
3796
3797         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3798         no longer expose XPathException.
3799
3800         * DOM/ExceptionHandlers.mm:
3801         (raiseDOMErrorException):
3802
3803 2017-07-20  Chris Dumez  <cdumez@apple.com>
3804
3805         Unreviewed, rolling out r219706.
3806
3807         Broke iOS build
3808
3809         Reverted changeset:
3810
3811         "Drop legacy XPathException type"
3812         https://bugs.webkit.org/show_bug.cgi?id=174679
3813         http://trac.webkit.org/changeset/219706
3814
3815 2017-07-20  Chris Dumez  <cdumez@apple.com>
3816
3817         Drop legacy XPathException type
3818         https://bugs.webkit.org/show_bug.cgi?id=174679
3819
3820         Reviewed by Sam Weinig.
3821
3822         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3823         no longer expose XPathException.
3824
3825         * DOM/ExceptionHandlers.mm:
3826         (raiseDOMErrorException):
3827         * WebKit.exp:
3828
3829 2017-07-20  Chris Dumez  <cdumez@apple.com>
3830
3831         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
3832         https://bugs.webkit.org/show_bug.cgi?id=174660
3833
3834         Reviewed by Geoffrey Garen.
3835
3836         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
3837         This essentially replaces a branch to figure out if the new size is less or greater than the
3838         current size by an assertion.
3839
3840         * Plugins/WebNetscapePluginView.mm:
3841         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3842
3843 2017-07-20  Brady Eidson  <beidson@apple.com>
3844
3845         Deprecate WebIconDatabase in WebKitLegacy/mac.
3846         https://bugs.webkit.org/show_bug.cgi?id=174607
3847
3848         Reviewed by Alex Christensen.
3849
3850         This patch:
3851         1 - Formally deprecates WebIconDatabase (which was never API anyways)
3852         2 - Guts the class to where it can only return the default icon at the small size
3853         3 - Reworks other parts of WebKitLegacy that used it for anything to either
3854             use something else or to not do anything.
3855         
3856         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
3857         and that patch will remove all of the last remnants of WebIconDatabase.
3858         
3859         * History/WebHistoryItem.mm:
3860         (-[WebHistoryItem icon]):
3861
3862         * Misc/WebIconDatabase.h:
3863         * Misc/WebIconDatabase.mm:
3864         (-[WebIconDatabase init]):
3865         (-[WebIconDatabase iconForURL:withSize:cache:]):
3866         (-[WebIconDatabase iconForURL:withSize:]):
3867         (-[WebIconDatabase defaultIconWithSize:]):
3868         (-[WebIconDatabase defaultIconForURL:withSize:]):
3869         (-[WebIconDatabase iconURLForURL:]):
3870         (-[WebIconDatabase retainIconForURL:]):
3871         (-[WebIconDatabase releaseIconForURL:]):
3872         (+[WebIconDatabase delayDatabaseCleanup]):
3873         (+[WebIconDatabase allowDatabaseCleanup]):
3874         (-[WebIconDatabase setDelegate:]):
3875         (-[WebIconDatabase delegate]):
3876         (+[WebIconDatabase initialize]): Deleted.
3877         (-[WebIconDatabase isEnabled]): Deleted.
3878         (-[WebIconDatabase setEnabled:]): Deleted.
3879         (-[WebIconDatabase removeAllIcons]): Deleted.
3880         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
3881         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
3882         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
3883         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
3884         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
3885         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
3886         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
3887         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
3888         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
3889         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
3890         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
3891         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
3892         (-[WebIconDatabase _databaseDirectory]): Deleted.
3893         (webGetNSImage): Deleted.
3894
3895         * Misc/WebIconDatabaseDelegate.h: Removed.
3896         * Misc/WebIconDatabaseInternal.h: Removed.
3897         * Misc/WebIconDatabasePrivate.h: Removed.
3898
3899         * WebCoreSupport/WebFrameLoaderClient.mm:
3900         (webGetNSImage):
3901
3902         * WebCoreSupport/WebIconDatabaseClient.mm:
3903         (WebIconDatabaseClient::didRemoveAllIcons):
3904         (WebIconDatabaseClient::didImportIconURLForPageURL):
3905
3906         * WebView/WebView.mm:
3907         (-[WebView setFrameLoadDelegate:]):
3908         (-[WebView mainFrameIcon]):
3909
3910 2017-07-18  Andy Estes  <aestes@apple.com>
3911
3912         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3913         https://bugs.webkit.org/show_bug.cgi?id=174631
3914
3915         Reviewed by Tim Horton.
3916
3917         * Configurations/Base.xcconfig:
3918
3919 2017-07-18  Andy Estes  <aestes@apple.com>
3920
3921         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3922         https://bugs.webkit.org/show_bug.cgi?id=174631
3923
3924         Reviewed by Sam Weinig.
3925
3926         * Configurations/Base.xcconfig:
3927
3928 2017-07-18  Andy Estes  <aestes@apple.com>
3929
3930         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3931         https://bugs.webkit.org/show_bug.cgi?id=174631
3932
3933         Reviewed by Dan Bernstein.
3934
3935         * Configurations/Base.xcconfig:
3936
3937 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3938
3939         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
3940         https://bugs.webkit.org/show_bug.cgi?id=174640
3941         <rdar://problem/33297400>
3942
3943         Reviewed by Tim Horton.
3944
3945         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
3946         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
3947         web thread here, to match the other WebView drag and drop SPI methods.
3948
3949         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
3950         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
3951         should make this robust against future UIKit changes that could make this no longer the case.
3952
3953         * WebView/WebView.mm:
3954         (-[WebView _requestStartDataInteraction:globalPosition:]):
3955         (-[WebView _dataInteractionCaretRect]):
3956
3957 2017-07-18  Andy Estes  <aestes@apple.com>
3958
3959         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3960         https://bugs.webkit.org/show_bug.cgi?id=174631
3961
3962         Reviewed by Darin Adler.
3963
3964         * Configurations/Base.xcconfig:
3965
3966 2017-07-17  Sam Weinig  <sam@webkit.org>
3967
3968         [WebIDL] Remove custom bindings that require non-caching JS strings
3969         https://bugs.webkit.org/show_bug.cgi?id=174552
3970
3971         Reviewed by Darin Adler.
3972
3973         * DOM/DOMHTMLCanvasElement.mm:
3974         (-[DOMHTMLCanvasElement toDataURL:]):
3975         Update to account for implementation now returning an UncachedString.
3976
3977 2017-07-17  Darin Adler  <darin@apple.com>
3978
3979         Improve use of NeverDestroyed
3980         https://bugs.webkit.org/show_bug.cgi?id=174348
3981
3982         Reviewed by Sam Weinig.
3983
3984         * Misc/WebStringTruncator.mm:
3985         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
3986         NeverDestroyed<RetainPtr> with just an NSFont * global.
3987
3988         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
3989         NeverDestroyed.h.
3990         * Storage/WebDatabaseManager.mm: Ditto.
3991         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
3992         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
3993
3994         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
3995         (aeDescFromJSValue): Removed double hashing by using the return value from
3996         add rather than calling contains before calling add.
3997
3998 2017-07-14  Jer Noble  <jer.noble@apple.com>
3999
4000         Allow clients to override their own hardware media requirements where no fallback media exists.
4001         https://bugs.webkit.org/show_bug.cgi?id=174426
4002         <rdar://problem/32537704>
4003
4004         Reviewed by Eric Carlson.
4005
4006         Add a new WebPreferences property to control WebCore's new
4007         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
4008
4009         * WebView/WebPreferenceKeysPrivate.h:
4010         * WebView/WebPreferences.mm:
4011         (+[WebPreferences initialize]):
4012         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
4013         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
4014         * WebView/WebPreferencesPrivate.h:
4015         * WebView/WebView.mm:
4016         (-[WebView _preferencesChanged:]):
4017
4018 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
4019
4020         Async image decoding for large images should be disabled by default
4021         https://bugs.webkit.org/show_bug.cgi?id=174432
4022
4023         Reviewed by Simon Fraser.
4024
4025         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
4026         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
4027         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
4028            a child view instead of propagating PaintBehaviorSnapshotting.
4029         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
4030            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
4031
4032         * WebView/WebFrame.mm:
4033         (-[WebFrame _paintBehaviorForDestinationContext:]):
4034         (-[WebFrame _drawRect:contentsOnly:]):
4035         * WebView/WebHTMLView.mm:
4036         (imageFromRect):
4037
4038 2017-07-12  Daniel Bates  <dabates@apple.com>
4039
4040         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
4041         https://bugs.webkit.org/show_bug.cgi?id=174427
4042
4043         Rubber-stamped by Brady Eidson.
4044
4045         * WebView/WebPDFView.mm:
4046         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4047
4048 2017-07-12  Matt Lewis  <jlewis3@apple.com>
4049
4050         Unreviewed, rolling out r219401.
4051
4052         This revision rolled out the previous patch, but after talking
4053         with reviewer, a rebaseline is what was needed.Rolling back in
4054         before rebaseline.
4055
4056         Reverted changeset:
4057
4058         "Unreviewed, rolling out r219379."
4059         https://bugs.webkit.org/show_bug.cgi?id=174400
4060         http://trac.webkit.org/changeset/219401
4061
4062 2017-07-12  Matt Lewis  <jlewis3@apple.com>
4063
4064         Unreviewed, rolling out r219379.
4065
4066         This revision caused a consistent failure in the test
4067         fast/dom/Window/property-access-on-cached-window-after-frame-
4068         removed.html.
4069
4070         Reverted changeset:
4071
4072         "Remove NAVIGATOR_HWCONCURRENCY"
4073         https://bugs.webkit.org/show_bug.cgi?id=174400
4074         http://trac.webkit.org/changeset/219379
4075
4076 2017-07-11  Dean Jackson  <dino@apple.com>
4077
4078         Remove NAVIGATOR_HWCONCURRENCY
4079         https://bugs.webkit.org/show_bug.cgi?id=174400
4080
4081         * Configurations/FeatureDefines.xcconfig:
4082
4083 2017-07-11  Dean Jackson  <dino@apple.com>