Rename WindowProxyController to WindowProxy
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-04-18  Chris Dumez  <cdumez@apple.com>
2
3         Rename WindowProxyController to WindowProxy
4         https://bugs.webkit.org/show_bug.cgi?id=184756
5
6         Reviewed by Sam Weinig.
7
8         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
9         needed use WindowProxyController type, which was a bit confusing.
10
11         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
12         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
13         * WebView/WebFrame.mm:
14         (-[WebFrame _attachScriptDebugger]):
15
16 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
17
18         Unreviewed rollout of r230632. Regression in memory usage.
19
20         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
21
22         * WebView/WebPreferences.mm:
23         (+[WebPreferences initialize]):
24
25 2018-04-17  Chris Dumez  <cdumez@apple.com>
26
27         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
28         https://bugs.webkit.org/show_bug.cgi?id=184678
29         <rdar://problem/39422122>
30
31         Reviewed by Alex Christensen.
32
33         Add new parameter to dispatchDecidePolicyForNavigationAction.
34
35         * WebCoreSupport/WebFrameLoaderClient.h:
36         * WebCoreSupport/WebFrameLoaderClient.mm:
37         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
38
39 2018-04-13  Chris Dumez  <cdumez@apple.com>
40
41         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
42         https://bugs.webkit.org/show_bug.cgi?id=184591
43
44         Reviewed by Sam Weinig.
45
46         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
47         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
48         This is work towards fixing Bug 184515.
49
50         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
51         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
52         * WebView/WebFrame.mm:
53         (-[WebFrame _attachScriptDebugger]):
54
55 2018-04-12  Antoine Quint  <graouts@apple.com>
56
57         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
58         https://bugs.webkit.org/show_bug.cgi?id=184569
59         <rdar://problem/38671301>
60
61         Reviewed by Jon Lee.
62
63         * WebView/WebPreferences.mm:
64
65 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
66
67         [WTF] Remove StaticLock
68         https://bugs.webkit.org/show_bug.cgi?id=184332
69
70         Reviewed by Mark Lam.
71
72         * DOM/DOMInternal.mm:
73         (getDOMWrapper):
74         (addDOMWrapper):
75         (removeDOMWrapper):
76
77 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
78
79         Failures from mach port reference handling should be fatal
80         https://bugs.webkit.org/show_bug.cgi?id=184202
81         <rdar://problem/37771114>
82
83         Reviewed by Anders Carlsson.
84
85         * Plugins/Hosted/NetscapePluginHostManager.mm:
86         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
87
88 2018-04-03  Andy Estes  <aestes@apple.com>
89
90         [Mac] Prioritize file promises over filenames during drag and drop
91         https://bugs.webkit.org/show_bug.cgi?id=184237
92         <rdar://problem/38278076>
93
94         Reviewed by Wenson Hsieh.
95
96         * WebView/WebView.mm:
97         (-[WebView performDragOperation:]):
98
99 2018-04-03  Chris Dumez  <cdumez@apple.com>
100
101         Drop MainFrame class
102         https://bugs.webkit.org/show_bug.cgi?id=184191
103
104         Reviewed by Darin Adler.
105
106         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
107         relationship between the Page and the MainFrame.
108
109         This is ground work for introducing LocalFrame / RemoteFrame concepts.
110
111         * WebCoreSupport/WebDragClient.mm:
112         * WebCoreSupport/WebFrameLoaderClient.mm:
113         * WebCoreSupport/WebInspectorClient.mm:
114         * WebCoreSupport/WebPlatformStrategies.mm:
115         * WebCoreSupport/WebPluginInfoProvider.mm:
116         * WebView/WebFrame.mm:
117         * WebView/WebFrameView.mm:
118         * WebView/WebHTMLView.mm:
119         * WebView/WebView.mm:
120
121 2018-04-02  Jer Noble  <jer.noble@apple.com>
122
123         Enable Legacy EME for all WebKit & WebKitLegacy clients
124         https://bugs.webkit.org/show_bug.cgi?id=184018
125         <rdar://problem/34887387>
126
127         Reviewed by Eric Carlson.
128
129         * WebView/WebPreferences.mm:
130         (+[WebPreferences initialize]):
131
132 2018-03-29  JF Bastien  <jfbastien@apple.com>
133
134         Use Forward.h instead of forward-declaring WTF::String
135         https://bugs.webkit.org/show_bug.cgi?id=184172
136         <rdar://problem/39026146>
137
138         Reviewed by Yusuke Suzuki.
139
140         As part of #184164 I'm changing WTF::String, and the forward
141         declarations are just wrong because I'm making it templated. We
142         should use Forward.h anyways, so do that instead.
143
144         * WebView/WebScriptDebugger.h:
145
146 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
147
148         Protect against invalid mach ports returned by mach_port_request_notification
149         https://bugs.webkit.org/show_bug.cgi?id=184106
150         <rdar://problem/37865316>
151
152         Reviewed by Chris Dumez.
153
154         * Plugins/Hosted/NetscapePluginHostProxy.mm:
155         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
156         and clean up if it experienced an error.
157         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
158
159 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
160
161         Avoid uninitialized mach ports
162         https://bugs.webkit.org/show_bug.cgi?id=184090
163         <rdar://problem/37261129>
164
165         Reviewed by Chris Dumez.
166
167         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
168         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
169         there is a potential for us to try to use invalid ports.
170
171         We should always check return values, and ensure that the mach port variables we seek to initialize are
172         kept in a valid state.
173
174         Reviewed by Chris Dumez.
175
176         * Plugins/Hosted/NetscapePluginHostManager.h:
177         * Plugins/Hosted/NetscapePluginHostManager.mm:
178         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
179         port is passed to an API function.
180         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
181         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
182         * Plugins/Hosted/NetscapePluginHostProxy.h:
183         * Plugins/Hosted/NetscapePluginHostProxy.mm:
184         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
185         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
186         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
187         (WKPCStatusText): Ditto.
188         (WKPCLoadURL): Ditto.
189         (WKPCCancelLoadURL): Ditto.
190         (WKPCInvalidateRect): Ditto.
191         (WKPCGetScriptableNPObjectReply): Ditto.
192         (WKPCBooleanReply): Ditto.
193         (WKPCBooleanAndDataReply): Ditto.
194         (WKPCInstantiatePluginReply): Ditto.
195         (WKPCGetWindowNPObject): Ditto.
196         (WKPCGetPluginElementNPObject): Ditto.
197         (WKPCForgetBrowserObject): Ditto.
198         (WKPCEvaluate): Ditto.
199         (WKPCGetStringIdentifier): Ditto.
200         (WKPCGetIntIdentifier): Ditto.
201         (WKPCInvoke): Ditto.
202         (WKPCInvokeDefault): Ditto.
203         (WKPCConstruct): Ditto.
204         (WKPCGetProperty): Ditto.
205         (WKPCSetProperty): Ditto.
206         (WKPCRemoveProperty): Ditto.
207         (WKPCHasProperty): Ditto.
208         (WKPCHasMethod): Ditto.
209         (WKPCIdentifierInfo): Ditto.
210         (WKPCEnumerate): Ditto.
211         (WKPCSetMenuBarVisible): Ditto.
212         (WKPCSetFullscreenWindowIsShowing): Ditto.
213         (WKPCSetModal): Ditto.
214         (WKPCGetCookies): Ditto.
215         (WKPCGetProxy): Ditto.
216         (WKPCSetCookies): Ditto.
217         (WKPCGetAuthenticationInfo): Ditto.
218         (WKPCConvertPoint): Ditto.
219         (WKPCLayerHostingModeChanged): Ditto.
220         (WKPCSetException): Ditto.
221
222 2018-03-26  Tim Horton  <timothy_horton@apple.com>
223
224         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
225         https://bugs.webkit.org/show_bug.cgi?id=184030
226         <rdar://problem/38895281>
227
228         Reviewed by Dan Bernstein.
229
230         * Configurations/Base.xcconfig:
231
232 2018-03-26  Chris Dumez  <cdumez@apple.com>
233
234         Use SecurityOriginData more consistently in Service Worker code
235         https://bugs.webkit.org/show_bug.cgi?id=183969
236
237         Reviewed by Darin Adler.
238
239         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
240
241         * Storage/WebDatabaseManager.mm:
242         (-[WebDatabaseManager databasesWithOrigin:]):
243         (-[WebDatabaseManager deleteOrigin:]):
244         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
245         * Storage/WebDatabaseQuotaManager.mm:
246         (-[WebDatabaseQuotaManager usage]):
247         (-[WebDatabaseQuotaManager quota]):
248         (-[WebDatabaseQuotaManager setQuota:]):
249         * Storage/WebStorageManager.mm:
250         (-[WebStorageManager deleteOrigin:]):
251         * WebCoreSupport/WebSecurityOrigin.mm:
252         (-[WebSecurityOrigin databaseIdentifier]):
253         (-[WebSecurityOrigin usage]):
254         (-[WebSecurityOrigin quota]):
255         (-[WebSecurityOrigin setQuota:]):
256
257 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
258
259         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
260         https://bugs.webkit.org/show_bug.cgi?id=183911
261         <rdar://problem/38762306>
262
263         Reviewed by Youenn Fablet.
264
265         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
266
267         * WebView/WebView.mm:
268         (+[WebView initialize]):
269
270 2018-03-26  Alex Christensen  <achristensen@webkit.org>
271
272         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
273         https://bugs.webkit.org/show_bug.cgi?id=183965
274
275         Reviewed by Chris Dumez.
276
277         * WebCoreSupport/WebFrameLoaderClient.h:
278         * WebCoreSupport/WebFrameLoaderClient.mm:
279         (WebFrameLoaderClient::willCacheResponse const):
280
281 2018-03-25  Commit Queue  <commit-queue@webkit.org>
282
283         Unreviewed, rolling out r229954.
284         https://bugs.webkit.org/show_bug.cgi?id=184000
285
286         Caused many layout tests to crash on Apple High Sierra,
287         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
288         by dydz on #webkit).
289
290         Reverted changeset:
291
292         "Use SecurityOriginData more consistently in Service Worker
293         code"
294         https://bugs.webkit.org/show_bug.cgi?id=183969
295         https://trac.webkit.org/changeset/229954
296
297 2018-03-24  Chris Dumez  <cdumez@apple.com>
298
299         Use SecurityOriginData more consistently in Service Worker code
300         https://bugs.webkit.org/show_bug.cgi?id=183969
301
302         Reviewed by Darin Adler.
303
304         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
305
306         * Storage/WebDatabaseManager.mm:
307         (-[WebDatabaseManager databasesWithOrigin:]):
308         (-[WebDatabaseManager deleteOrigin:]):
309         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
310         * Storage/WebDatabaseQuotaManager.mm:
311         (-[WebDatabaseQuotaManager usage]):
312         (-[WebDatabaseQuotaManager quota]):
313         (-[WebDatabaseQuotaManager setQuota:]):
314         * Storage/WebStorageManager.mm:
315         (-[WebStorageManager deleteOrigin:]):
316         * WebCoreSupport/WebSecurityOrigin.mm:
317         (-[WebSecurityOrigin databaseIdentifier]):
318         (-[WebSecurityOrigin usage]):
319         (-[WebSecurityOrigin quota]):
320         (-[WebSecurityOrigin setQuota:]):
321
322 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
323
324         Fix the build
325
326         * WebView/WebView.mm:
327
328 2018-03-23  Tim Horton  <timothy_horton@apple.com>
329
330         Fix the build with no pasteboard
331         https://bugs.webkit.org/show_bug.cgi?id=183973
332
333         Reviewed by Dan Bernstein.
334
335         * Configurations/FeatureDefines.xcconfig:
336         * WebView/WebView.mm:
337         (-[WebView _requestStartDataInteraction:globalPosition:]):
338         (-[WebView _getDataInteractionData]):
339         (-[WebView _dataOperationTextIndicator]):
340         (-[WebView _dragSourceAction]):
341         (-[WebView _draggedLinkTitle]):
342         (-[WebView _draggedLinkURL]):
343         (-[WebView _draggedElementBounds]):
344         (-[WebView _enteredDataInteraction:client:global:operation:]):
345         (-[WebView _updatedDataInteraction:client:global:operation:]):
346         (-[WebView _exitedDataInteraction:client:global:operation:]):
347         (-[WebView _performDataInteraction:client:global:operation:]):
348         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
349         (-[WebView _endedDataInteraction:global:]):
350         (-[WebView _dataInteractionCaretRect]):
351         * WebView/WebViewPrivate.h:
352
353 2018-03-23  Tim Horton  <timothy_horton@apple.com>
354
355         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
356         https://bugs.webkit.org/show_bug.cgi?id=183960
357         <rdar://problem/38812356>
358
359         Reviewed by Dan Bernstein.
360
361         * Configurations/WebKitLegacy.xcconfig:
362
363 2018-03-23  Tim Horton  <timothy_horton@apple.com>
364
365         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
366         https://bugs.webkit.org/show_bug.cgi?id=183954
367         <rdar://problem/38808858>
368
369         Reviewed by Dan Bernstein.
370
371         * WebView/WebPreferences.mm:
372         (-[WebPreferences setAudioSessionCategoryOverride:]):
373
374 2018-03-23  Tim Horton  <timothy_horton@apple.com>
375
376         Adopt WK_PLATFORM_NAME in WebKitLegacy
377         https://bugs.webkit.org/show_bug.cgi?id=183948
378         <rdar://problem/38803908>
379
380         Reviewed by Dan Bernstein.
381
382         * Configurations/WebKitLegacy.xcconfig:
383         * MigrateHeaders.make:
384         * postprocess-headers.sh:
385
386 2018-03-23  Brady Eidson  <beidson@apple.com>
387
388         Go to back/forward list items after a process-swapped navigation.
389         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
390
391         Reviewed by Andy Estes.
392
393         * WebView/WebView.mm:
394         (-[WebView _loadBackForwardListFromOtherView:]):
395         (-[WebView goToBackForwardItem:]):
396
397 2018-03-22  Tim Horton  <timothy_horton@apple.com>
398
399         Improve readability of WebCore's OTHER_LDFLAGS
400         https://bugs.webkit.org/show_bug.cgi?id=183909
401         <rdar://problem/38760992>
402
403         Reviewed by Dan Bernstein.
404
405         * Configurations/Base.xcconfig:
406         * Configurations/FeatureDefines.xcconfig:
407
408 2018-03-20  Tim Horton  <timothy_horton@apple.com>
409
410         Enable the minimal simulator feature flag when appropriate
411         https://bugs.webkit.org/show_bug.cgi?id=183807
412
413         Reviewed by Dan Bernstein.
414
415         * Configurations/FeatureDefines.xcconfig:
416
417 2018-03-20  Tim Horton  <timothy_horton@apple.com>
418
419         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
420         https://bugs.webkit.org/show_bug.cgi?id=183758
421         <rdar://problem/38017644>
422
423         Reviewed by Dan Bernstein.
424
425         * Configurations/FeatureDefines.xcconfig:
426
427 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
428
429         Clear style colors when setting default appearance
430         https://bugs.webkit.org/show_bug.cgi?id=183759
431
432         Reviewed by Tim Horton.
433
434         Colors are cached and need to be cleared and recalculated.
435         Refactor to do all style recalcs together.
436
437         * WebView/WebView.mm:
438         (-[WebView _setDefaultAppearanceAndClearStyle]):
439         (-[WebView _setUseSystemAppearance:]):
440         (-[WebView effectiveAppearanceDidChange]):
441
442 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
443
444         Unreviewed, another quick fix for r229699
445
446         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
447
448         * Configurations/FeatureDefines.xcconfig:
449
450 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
451
452         Ensure that style is updated when the effective appearance changes
453         https://bugs.webkit.org/show_bug.cgi?id=183690
454         <rdar://problem/38385900>
455
456         Reviewed by Tim Horton and Wenson Hsieh.
457
458         Respond to and respect the effective appearance changing.
459
460         * WebView/WebView.mm:
461         (-[WebView _setUseSystemAppearance:]):
462         (-[WebView effectiveAppearanceDidChange]):
463
464 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
465
466         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
467         https://bugs.webkit.org/show_bug.cgi?id=183677
468
469         Reviewed by Tim Horton.
470
471         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
472
473         * DOM/DOM.mm:
474         (-[DOMHTMLLinkElement _mediaQueryMatches]):
475
476 2018-03-14  Tim Horton  <timothy_horton@apple.com>
477
478         Fix the build after r229567
479
480         * Configurations/FeatureDefines.xcconfig:
481
482 2018-03-12  Tim Horton  <timothy_horton@apple.com>
483
484         Stop using SDK conditionals to control feature definitions
485         https://bugs.webkit.org/show_bug.cgi?id=183430
486         <rdar://problem/38251619>
487
488         Reviewed by Dan Bernstein.
489
490         * Configurations/FeatureDefines.xcconfig:
491         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
492
493 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
494
495         Runtime flag for link prefetch and remove link subresource.
496         https://bugs.webkit.org/show_bug.cgi?id=183540
497
498         Reviewed by Chris Dumez.
499
500         Remove the LINK_PREFETCH build time flag.
501
502         * Configurations/FeatureDefines.xcconfig:
503
504 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
505
506         Remove GridLayout runtime flag
507         https://bugs.webkit.org/show_bug.cgi?id=183484
508
509         Reviewed by Myles C. Maxfield.
510
511         The Grid Layout feature has been enabled by default for almost a
512         year, so I think it's time to remove the runtime flag and the
513
514         * WebView/WebPreferenceKeysPrivate.h:
515         * WebView/WebPreferences.mm:
516         (+[WebPreferences initialize]):
517         * WebView/WebPreferencesPrivate.h:
518         * WebView/WebView.mm:
519         (-[WebView _preferencesChanged:]):
520
521 2018-03-12  Antoine Quint  <graouts@apple.com>
522
523         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
524         https://bugs.webkit.org/show_bug.cgi?id=183504
525         <rdar://problem/38372965>
526
527         Reviewed by Dean Jackson and Jon Lee.
528
529         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
530         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
531
532         * WebView/WebPreferenceKeysPrivate.h:
533         * WebView/WebPreferences.mm:
534         (+[WebPreferences initialize]):
535         (-[WebPreferences setModernMediaControlsEnabled:]):
536         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
537         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
538         * WebView/WebPreferencesPrivate.h:
539         * WebView/WebView.mm:
540         (-[WebView _preferencesChanged:]):
541
542 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
543
544         Media query for default appearance
545         https://bugs.webkit.org/show_bug.cgi?id=183539
546         <rdar://problem/38326388>
547
548         Reviewed by Tim Horton.
549
550         Write a media query to evaluate appearance.
551
552         * WebView/WebView.mm:
553         (-[WebView _commonInitializationWithFrameName:groupName:]):
554         (-[WebView _setUseSystemAppearance:]):
555
556 2018-03-09  Andy Estes  <aestes@apple.com>
557
558         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
559         https://bugs.webkit.org/show_bug.cgi?id=183489
560         <rdar://problem/38267517>
561
562         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
563         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
564         to issue a sandbox extension for this directory, but for security reasons App Sandbox
565         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
566         block with a nil error and a valid file URL, but no file will actually exist at that URL.
567
568         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
569         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
570         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
571         drop destination.
572
573         Reviewed by Wenson Hsieh.
574
575         * WebView/WebView.mm:
576         (-[WebView performDragOperation:]):
577
578 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
579
580         Allow WebViews to disable system appearance
581         https://bugs.webkit.org/show_bug.cgi?id=183418
582         <rdar://problem/36975642>
583
584         Reviewed by Tim Horton.
585
586         Allow webviews to choose whether or not to follow the default system appearance.
587
588         * WebView/WebView.mm:
589         (-[WebView _setUseSystemAppearance:]):
590         (-[WebView _useSystemAppearance]):
591         * WebView/WebViewPrivate.h:
592
593 2018-03-08  Youenn Fablet  <youenn@apple.com>
594
595         libwebrtc update broke internal builds
596         https://bugs.webkit.org/show_bug.cgi?id=183454
597
598         Reviewed by Eric Carlson.
599
600         * Configurations/WebKitLegacy.xcconfig:
601
602 2018-03-08  Chris Dumez  <cdumez@apple.com>
603
604         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
605         https://bugs.webkit.org/show_bug.cgi?id=183455
606         <rdar://problem/38191749>
607
608         Reviewed by Youenn Fablet.
609
610         Add a null check for the page as we have evidence from crashes that it can be null.
611         Other functions in WebFrameNetworkingContext already null check the page as well,
612         not just the frame so this is consistent.
613
614         * WebCoreSupport/WebFrameNetworkingContext.mm:
615         (WebFrameNetworkingContext::storageSession const):
616
617 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
618
619         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
620         https://bugs.webkit.org/show_bug.cgi?id=183429
621
622         Reviewed by Mark Lam.
623
624         * DOM/DOM.mm:
625         (+[DOMNode _nodeFromJSWrapper:]):
626         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
627         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
628         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
629         * Plugins/Hosted/ProxyInstance.mm:
630         (WebKit::ProxyInstance::invokeMethod):
631         * WebView/WebView.mm:
632         (aeDescFromJSValue):
633
634 2018-03-08  Tim Horton  <timothy_horton@apple.com>
635
636         Stop linking ApplicationServices directly
637         https://bugs.webkit.org/show_bug.cgi?id=182867
638         <rdar://problem/38252142>
639
640         Reviewed by Alex Christensen.
641
642         The frameworks that we use that live inside ApplicationServices
643         have mostly moved out, so import them directly.
644
645         * Carbon/CarbonUtils.h:
646         * WebKitPrefix.h:
647         * WebView/WebHTMLView.mm:
648         * WebView/WebPDFView.mm:
649
650 2018-03-07  Tim Horton  <timothy_horton@apple.com>
651
652         Sort and separate FeatureDefines.xcconfig
653         https://bugs.webkit.org/show_bug.cgi?id=183427
654
655         Reviewed by Dan Bernstein.
656
657         * Configurations/FeatureDefines.xcconfig:
658         Sort and split FeatureDefines into paragraphs
659         (to make it easier to sort later).
660
661 2018-03-07  Youenn Fablet  <youenn@apple.com>
662
663         Match unsupported plugins based on domains and not origin
664         https://bugs.webkit.org/show_bug.cgi?id=183384
665
666         Reviewed by Chris Dumez.
667
668         * WebCoreSupport/WebPluginInfoProvider.h:
669         * WebCoreSupport/WebPluginInfoProvider.mm:
670         (WebPluginInfoProvider::getPluginInfo):
671         (WebPluginInfoProvider::getWebVisiblePluginInfo):
672
673 2018-03-05  Andy Estes  <aestes@apple.com>
674
675         [Mac] Teach WebCore::Pasteboard about file promise drags
676         https://bugs.webkit.org/show_bug.cgi?id=183314
677         <rdar://problem/38105493>
678
679         Reviewed by Darin Adler.
680
681         Added a FIXME comment.
682
683         * WebView/WebView.mm:
684         (-[WebView performDragOperation:]):
685
686 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
687
688         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
689         https://bugs.webkit.org/show_bug.cgi?id=183312
690
691         Reviewed by Mark Lam.
692
693         Remove wtf/CurrentTime.h include pragma.
694
695         * WebView/WebFrame.mm:
696         * WebView/WebPDFView.mm:
697
698 2018-03-04  Tim Horton  <timothy_horton@apple.com>
699
700         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
701         https://bugs.webkit.org/show_bug.cgi?id=183283
702         <rdar://problem/38062148>
703
704         Reviewed by Sam Weinig.
705
706         * Configurations/FeatureDefines.xcconfig:
707
708 2018-02-28  Alex Christensen  <achristensen@webkit.org>
709
710         Reduce use of NetworkingContext in WebKit
711         https://bugs.webkit.org/show_bug.cgi?id=183213
712
713         Reviewed by Brady Eidson.
714
715         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
716         (WebKit::NetscapePluginInstanceProxy::getProxy):
717         * Plugins/WebNetscapePluginView.mm:
718         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
719
720 2018-02-17  Darin Adler  <darin@apple.com>
721
722         Prepare for ExtendedColor changes (first step)
723         https://bugs.webkit.org/show_bug.cgi?id=182904
724
725         Reviewed by Sam Weinig.
726
727         * Misc/WebKitNSStringExtras.mm:
728         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
729
730 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
731
732         Remove currentTime() / currentTimeMS()
733         https://bugs.webkit.org/show_bug.cgi?id=183052
734
735         Reviewed by Mark Lam.
736
737         * WebCoreSupport/WebFrameLoaderClient.h:
738         * WebCoreSupport/WebFrameLoaderClient.mm:
739         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
740
741 2018-02-16  Youenn Fablet  <youenn@apple.com>
742
743         Allow specifying which plug-ins are supported
744         https://bugs.webkit.org/show_bug.cgi?id=182748
745
746         Reviewed by Chris Dumez.
747
748         * WebCoreSupport/WebPluginInfoProvider.h:
749         * WebCoreSupport/WebPluginInfoProvider.mm:
750         (WebPluginInfoProvider::getPluginInfo):
751         (WebPluginInfoProvider::getWebVisiblePluginInfo):
752
753 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
754
755         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
756         https://bugs.webkit.org/show_bug.cgi?id=182882
757         <rdar://problem/35672661>
758
759         Reviewed by Dan Bernstein.
760
761         Make sure the smart pointer hold the collection of subviews lives at least as
762         long as the loop using it.
763
764         * WebView/WebHTMLView.mm:
765         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
766
767 2018-02-14  Daniel Bates  <dabates@apple.com>
768
769         Disallow cross-origin subresources from asking for credentials
770         https://bugs.webkit.org/show_bug.cgi?id=182579
771         <rdar://problem/36162271>
772
773         Reviewed by Andy Estes.
774
775         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
776         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
777
778         * WebView/WebPreferenceKeysPrivate.h:
779         * WebView/WebPreferences.mm:
780         (+[WebPreferences initialize]):
781         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
782         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
783         * WebView/WebPreferencesPrivate.h:
784         * WebView/WebView.mm:
785         (-[WebView _preferencesChanged:]):
786
787 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
788
789         Remove ForwardingHeaders directory from WebKitLegacy/mac.
790         https://bugs.webkit.org/show_bug.cgi?id=182738
791
792         Reviewed by Darin Adler.
793
794         * ForwardingHeaders/collector/handles/Global.h: Removed.
795         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
796         * ForwardingHeaders/runtime/Completion.h: Removed.
797         * ForwardingHeaders/runtime/Error.h: Removed.
798         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
799         * ForwardingHeaders/runtime/JSFunction.h: Removed.
800         * ForwardingHeaders/runtime/JSLock.h: Removed.
801         * ForwardingHeaders/runtime/JSObject.h: Removed.
802         * ForwardingHeaders/runtime/JSString.h: Removed.
803         * ForwardingHeaders/runtime/Protect.h: Removed.
804         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
805
806 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
807
808         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
809         https://bugs.webkit.org/show_bug.cgi?id=182641
810
811         Reviewed by Dan Bernstein.
812
813         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
814         https://trac.webkit.org/changeset/228308.
815
816         * WebView/WebVideoFullscreenController.h:
817         * WebView/WebVideoFullscreenHUDWindowController.mm:
818         * WebView/WebWindowAnimation.h:
819         * WebView/WebWindowAnimation.mm:
820         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
821         (WebCore::scaledRect): Deleted.
822         (WebCore::squaredDistance): Deleted.
823
824 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
825
826         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
827
828         * WebView/WebWindowAnimation.mm:
829         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
830
831 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
832
833         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
834         https://bugs.webkit.org/show_bug.cgi?id=182615
835
836         Reviewed by Eric Carlson.
837
838         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
839         Ideally, we should not reference NSApp in WebCore.
840
841         * WebView/WebFullScreenController.mm:
842         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
843         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
844         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
845         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
846         * WebView/WebView.mm:
847         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
848         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
849
850 2018-01-13  Darin Adler  <darin@apple.com>
851
852         Event improvements
853         https://bugs.webkit.org/show_bug.cgi?id=179591
854
855         Reviewed by Chris Dumez.
856
857         * DOM/DOMWheelEvent.mm:
858         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
859         Call initWebKitWheelEvent.
860
861         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
862         * WebCoreSupport/WebInspectorClient.mm: Ditto.
863         * WebView/WebFrame.mm: Ditto.
864
865         * WebView/WebHTMLView.mm:
866         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
867         underlyingPlatformEvent.
868         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
869
870         * WebView/WebScriptWorld.mm:
871         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
872
873         * WebView/WebView.mm: Removed include of ScriptValue.h.
874
875 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
876
877         Remove WebCore/ForwardingHeaders directory
878         https://bugs.webkit.org/show_bug.cgi?id=182347
879
880         Reviewed by Keith Miller.
881
882         * Carbon/CarbonWindowAdapter.mm:
883         * DOM/WebDOMOperations.mm:
884         * History/WebBackForwardList.mm:
885         * History/WebHistoryItem.mm:
886         * Misc/WebCache.mm:
887         * Misc/WebElementDictionary.mm:
888         * Misc/WebIconDatabase.mm:
889         * Misc/WebStringTruncator.mm:
890         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
891         * Plugins/Hosted/ProxyInstance.mm:
892         * Plugins/Hosted/ProxyRuntimeObject.mm:
893         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
894         * Plugins/WebBaseNetscapePluginView.mm:
895         * Plugins/WebBasePluginPackage.mm:
896         * Plugins/WebNetscapePluginStream.mm:
897         * Plugins/WebNetscapePluginView.mm:
898         * Plugins/WebPluginController.mm:
899         * WebCoreSupport/WebEditorClient.mm:
900         * WebCoreSupport/WebFrameLoaderClient.mm:
901         * WebCoreSupport/WebInspectorClient.h:
902         * WebCoreSupport/WebInspectorClient.mm:
903         * WebView/WebDataSource.mm:
904         * WebView/WebFrame.mm:
905         * WebView/WebHTMLRepresentation.mm:
906         * WebView/WebHTMLView.mm:
907         * WebView/WebPreferences.mm:
908         * WebView/WebScriptDebugDelegate.mm:
909         * WebView/WebScriptDebugger.h:
910         * WebView/WebTextIterator.mm:
911         * WebView/WebView.mm:
912         * WebView/WebViewData.mm:
913
914 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
915
916         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
917         https://bugs.webkit.org/show_bug.cgi?id=182312
918
919         Reviewed by Michael Catanzaro.
920
921         * WebKitPrefix.h:
922
923 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
924
925         [WebAuthN] Add a compile-time feature flag
926         https://bugs.webkit.org/show_bug.cgi?id=182211
927         <rdar://problem/36936365>
928
929         Reviewed by Brent Fulgham.
930
931         * Configurations/FeatureDefines.xcconfig:
932
933 2018-01-27  Dan Bernstein  <mitz@apple.com>
934
935         HaveInternalSDK includes should be "#include?"
936         https://bugs.webkit.org/show_bug.cgi?id=179670
937
938         * Configurations/Base.xcconfig:
939
940 2018-01-24  Alex Christensen  <achristensen@webkit.org>
941
942         Remove unused QTKit preference
943         https://bugs.webkit.org/show_bug.cgi?id=181968
944
945         Reviewed by Alexey Proskuryakov.
946
947         * WebView/WebPreferenceKeysPrivate.h:
948         * WebView/WebPreferences.mm:
949         (+[WebPreferences initialize]):
950         (-[WebPreferences setQTKitEnabled:]): Deleted.
951         (-[WebPreferences isQTKitEnabled]): Deleted.
952         * WebView/WebPreferencesPrivate.h:
953         * WebView/WebView.mm:
954         (-[WebView _preferencesChanged:]):
955
956 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
957
958         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
959         https://bugs.webkit.org/show_bug.cgi?id=182037
960         <rdar://problem/36747812>
961
962         Reviewed by Ryosuke Niwa.
963
964         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
965         for more details.
966
967         * WebView/WebHTMLRepresentation.mm:
968         (-[WebHTMLRepresentation elementWithName:inForm:]):
969         (-[WebHTMLRepresentation controlsInForm:]):
970
971 2018-01-23  Alex Christensen  <achristensen@webkit.org>
972
973         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
974         https://bugs.webkit.org/show_bug.cgi?id=181961
975
976         Reviewed by Michael Catanzaro.
977
978         * WebView/WebPreferences.mm:
979
980 2018-01-23  Commit Queue  <commit-queue@webkit.org>
981
982         Unreviewed, rolling out r227437.
983         https://bugs.webkit.org/show_bug.cgi?id=182011
984
985         broke build (Requested by alexchristensen on #webkit).
986
987         Reverted changeset:
988
989         "Remove unused QTKit preference"
990         https://bugs.webkit.org/show_bug.cgi?id=181968
991         https://trac.webkit.org/changeset/227437
992
993 2018-01-23  Alex Christensen  <achristensen@webkit.org>
994
995         Remove unused QTKit preference
996         https://bugs.webkit.org/show_bug.cgi?id=181968
997
998         Reviewed by Alexey Proskuryakov.
999
1000         * WebView/WebPreferenceKeysPrivate.h:
1001         * WebView/WebPreferences.mm:
1002         (+[WebPreferences initialize]):
1003         (-[WebPreferences setQTKitEnabled:]): Deleted.
1004         (-[WebPreferences isQTKitEnabled]): Deleted.
1005         * WebView/WebPreferencesPrivate.h:
1006         * WebView/WebView.mm:
1007         (-[WebView _preferencesChanged:]):
1008
1009 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1010
1011         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
1012         https://bugs.webkit.org/show_bug.cgi?id=181960
1013         <rdar://problem/36431678>
1014
1015         Reviewed by Tim Horton.
1016
1017         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
1018         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
1019         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
1020
1021         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
1022         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
1023         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
1024
1025         * WebView/WebView.mm:
1026         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1027
1028 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
1029
1030         Turning off custom pasteboard data doesn't actually turn it off in WK2
1031         https://bugs.webkit.org/show_bug.cgi?id=181920
1032         <rdar://problem/36686429>
1033
1034         Reviewed by Wenson Hsieh.
1035
1036         Always disable custom pasteboard data in WebKit1. See r226156 for details.
1037
1038         * WebView/WebPreferences.mm:
1039         (+[WebPreferences initialize]):
1040         * WebView/WebView.mm:
1041         (-[WebView _preferencesChanged:]):
1042
1043 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1044
1045         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1046         https://bugs.webkit.org/show_bug.cgi?id=181918
1047
1048         Reviewed by Tim Horton.
1049
1050         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1051
1052         * Configurations/FeatureDefines.xcconfig:
1053
1054 2018-01-20  Andy Estes  <aestes@apple.com>
1055
1056         [Apple Pay] Stop eagerly loading PassKit.framework
1057         https://bugs.webkit.org/show_bug.cgi?id=181911
1058         <rdar://problem/36555369>
1059
1060         Reviewed by Tim Horton.
1061
1062         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1063         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1064         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1065
1066         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1067
1068 2018-01-19  Dean Jackson  <dino@apple.com>
1069
1070         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1071         https://bugs.webkit.org/show_bug.cgi?id=181817
1072         <rdar://problem/35274055>
1073
1074         Reviewed by Simon Fraser.
1075
1076         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1077
1078         * Misc/WebKitVersionChecks.h:
1079         * WebView/WebView.mm:
1080         (-[WebView _commonInitializationWithFrameName:groupName:]):
1081
1082 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1083
1084         Remove unused WebViewPrivate _allowCookies
1085         https://bugs.webkit.org/show_bug.cgi?id=181812
1086
1087         Reviewed by Tim Horton.
1088
1089         * WebView/WebView.mm:
1090         (+[WebView _setAllowCookies:]): Deleted.
1091         (+[WebView _allowCookies]): Deleted.
1092         * WebView/WebViewPrivate.h:
1093
1094 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1095
1096         Build fix, remove a call to -[NSWindow setOneShot:]
1097         https://bugs.webkit.org/show_bug.cgi?id=181809
1098
1099         Reviewed by Tim Horton.
1100
1101         * WebView/WebTextCompletionController.mm:
1102         (-[WebTextCompletionController _buildUI]):
1103
1104 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1105
1106         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1107
1108         * Carbon/HIWebView.mm:
1109         (overrideCGContext):
1110         (restoreCGContext):
1111
1112 2018-01-18  Dan Bernstein  <mitz@apple.com>
1113
1114         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1115         https://bugs.webkit.org/show_bug.cgi?id=181803
1116
1117         Reviewed by Tim Horton.
1118
1119         * Configurations/Base.xcconfig: Updated.
1120         * Configurations/DebugRelease.xcconfig: Ditto.
1121         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1122         * Configurations/Version.xcconfig: Updated.
1123         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1124           useful for defining settings that depend on the target macOS version.
1125
1126 2018-01-17  Youenn Fablet  <youenn@apple.com>
1127
1128         Put fetch Request.keepalive behind a runtime flag
1129         https://bugs.webkit.org/show_bug.cgi?id=181592
1130
1131         Reviewed by Chris Dumez.
1132
1133         * WebView/WebPreferenceKeysPrivate.h:
1134         * WebView/WebPreferences.mm:
1135         (+[WebPreferences initialize]):
1136         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1137         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1138         * WebView/WebPreferencesPrivate.h:
1139         * WebView/WebView.mm:
1140         (-[WebView _preferencesChanged:]):
1141
1142 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1143
1144         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1145         https://bugs.webkit.org/show_bug.cgi?id=181637
1146         <rdar://problem/36508471>
1147
1148         Reviewed by Tim Horton.
1149
1150         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1151
1152         * WebCoreSupport/WebEditorClient.h:
1153         * WebCoreSupport/WebEditorClient.mm:
1154         (WebEditorClient::replacementURLForResource):
1155
1156 2018-01-11  Keith Miller  <keith_miller@apple.com>
1157
1158         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1159         https://bugs.webkit.org/show_bug.cgi?id=181573
1160
1161         Reviewed by Simon Fraser.
1162
1163         * Configurations/FeatureDefines.xcconfig:
1164
1165 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1166
1167         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1168         https://bugs.webkit.org/show_bug.cgi?id=181497
1169
1170         Reviewed by Tim Horton.
1171
1172         See other ChangeLogs for more detail.
1173
1174         * WebCoreSupport/WebDragClient.h:
1175
1176 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1177
1178         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1179         https://bugs.webkit.org/show_bug.cgi?id=181523
1180         <rdar://problem/28959131>
1181
1182         Reviewed by Alex Christensen.
1183
1184         * WebView/WebImmediateActionController.mm:
1185         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1186         Apply the change made in r216652 to WebKit1's immediate action controller.
1187
1188         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1189         the startContainer of the range is in an anonymous node.
1190
1191 2018-01-11  Youenn Fablet  <youenn@apple.com>
1192
1193         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1194         https://bugs.webkit.org/show_bug.cgi?id=181480
1195
1196         Reviewed by Eric Carlson.
1197
1198         * WebView/WebPreferences.mm:
1199         (+[WebPreferences initialize]):
1200
1201 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1202
1203         Fix check-webkit-style issues with WebNSDataExtras.mm
1204         <https://webkit.org/b/181369>
1205
1206         Reviewed by Alex Christensen.
1207
1208         * Misc/WebNSDataExtras.mm:
1209         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1210         (-[NSData _webkit_guessedMIMETypeForXML]):
1211         (-[NSData _webkit_guessedMIMEType]):
1212         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1213         (_findEOL):
1214         (-[NSData _webkit_parseRFC822HeaderFields]):
1215         (-[NSData _web_locationAfterFirstBlankLine]):
1216         - Fix all the check-webkit-style warnings.
1217
1218 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1219
1220         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1221         <https://webkit.org/b/181256>
1222         <rdar://problem/36281730>
1223
1224         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1225         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1226         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1227           to avoid warnings from casting CFStringRef to NPNSString*.
1228           Note that CFMutableStringRef is the same as CFStringRef
1229           without the const modifier, hence its use in the const_cast<>
1230           above.
1231
1232 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1233
1234         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1235         <https://webkit.org/b/181256>
1236         <rdar://problem/36281730>
1237
1238         * Carbon/HIWebView.mm:
1239         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1240         checked_cf_cast<CFRunLoopRef>() to fix warning.
1241
1242 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1243
1244         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1245         <https://webkit.org/b/181256>
1246         <rdar://problem/36281730>
1247
1248         Reviewed by Darin Adler.
1249
1250         * Carbon/CarbonUtils.m:
1251         (PoolCleaner):
1252         - Use #pragmas to ignore -Wcast-qual warnings when using a
1253           C-style cast from CFTypeRef to CFRunloopRef.
1254         * Carbon/CarbonWindowFrame.m:
1255         (-[CarbonWindowFrame title]):
1256         - Use #pragmas to ignore -Wcast-qual warnings when using a
1257           C-style cast from CFStringRef to NSString *.
1258         * Carbon/HIViewAdapter.m:
1259         (+[HIViewAdapter getHIViewForNSView:]):
1260         - Use #pragmas to ignore -Wcast-qual warnings when using a
1261           C-style cast from CFTypeRef to HIViewRef.
1262         * Configurations/Base.xcconfig:
1263         (WARNING_CFLAGS): Add -Wcast-qual.
1264         * Misc/WebElementDictionary.mm:
1265         (-[WebElementDictionary objectForKey:]):
1266         - Use static_cast<SEL>(const_cast<void*>()) to fix
1267           warning.
1268         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1269         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1270         (-[NSData _webkit_guessedMIMETypeForXML]):
1271         (-[NSData _webkit_guessedMIMEType]):
1272         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1273         (_findEOL):
1274         (-[NSData _webkit_parseRFC822HeaderFields]):
1275         (-[NSData _web_startsWithBlankLine]):
1276         (-[NSData _web_locationAfterFirstBlankLine]):
1277         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1278           type to Objective-C++.  This fixes the warnings about
1279           discarding the `const` modifier when casing from CFStringRef
1280           to NSString * because in older clang versions, -Wcast-qual was
1281           completely broken when compiling C++ and Objective-C++ source
1282           files.  In newer clang versions, discarding the `const`
1283           modifier for toll-free bridged types is ignored when compiling
1284           Objective-C++ source.
1285         - Update copyright and license header.
1286         - Use reinterpret_cast<> and static_cast<> to fix warnings
1287           unrelated to (NSString *) C-style casts.
1288         - Replace use of MIN() macro with std::min<> template functions.
1289         - Fix location of `*` for local variables modified above.
1290         * Plugins/Hosted/NetscapePluginHostManager.mm:
1291         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1292         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1293         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1294         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1295           warnings.
1296         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1297         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1298         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1299           to fix warning.
1300         * Plugins/Hosted/ProxyInstance.mm:
1301         (WebKit::ProxyInstance::invoke):
1302         - Use static_cast<char*>(const_cast<void*>()) to fix
1303           warning when using -[NSData bytes].
1304         (WebKit::ProxyInstance::fieldValue const):
1305         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1306           to fix warning when using CFDataGetBytePtr().
1307         * Plugins/Hosted/WebTextInputWindowController.m:
1308         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1309         - Use #pragma to ignore -Wcast-qual warning since there
1310           is not a good way to avoid this warning in Objective-C.
1311         * Plugins/WebNetscapePluginStream.mm:
1312         (WebNetscapePluginStream::deliverData):
1313         - Use const_cast<void*>() to fix warning when using
1314           -[NSData bytes].
1315         * Plugins/WebNetscapePluginView.mm:
1316         (-[WebNetscapePluginView _createPlugin]):
1317         - Change C-style cast to const_cast<char*>() to fix
1318           warning.
1319         * WebCoreSupport/WebChromeClient.mm:
1320         (WebChromeClient::wrapCryptoKey const):
1321         (WebChromeClient::unwrapCryptoKey const):
1322         - Change C-style cast to
1323           static_cast<uint8_t*>(const_cast<void*>() to fix
1324           warning.
1325         * WebView/WebPDFView.mm:
1326         (_applicationInfoForMIMEType):
1327         - Change local variable type from 'NSURL *' to
1328           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1329           when calling -[NSURL path].
1330
1331 2018-01-05  Dan Bernstein  <mitz@apple.com>
1332
1333         Fixed the build following AppKit API deprecations in a recent SDKs
1334
1335         * WebView/WebFullScreenController.mm:
1336         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1337         (-[WebFullScreenController exitFullScreen]): Ditto.
1338         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1339         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1340         * WebView/WebHTMLView.mm:
1341         (-[WebHTMLView drawRect:]): Ditto.
1342         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1343         (-[WebHTMLView knowsPageRange:]): Ditto.
1344         * WebView/WebView.mm:
1345         (LayerFlushController::flushLayers): Ditto.
1346
1347 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1348
1349         [Attachment Support] Create attachment elements when dropping files on iOS
1350         https://bugs.webkit.org/show_bug.cgi?id=181192
1351         <rdar://problem/36280945>
1352
1353         Reviewed by Tim Horton.
1354
1355         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1356
1357         * WebCoreSupport/WebPlatformStrategies.h:
1358         * WebCoreSupport/WebPlatformStrategies.mm:
1359         (WebPlatformStrategies::informationForItemAtIndex):
1360         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1361
1362 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1363
1364         [Attachment Support] Add plumbing for starting a drag with promised blob data
1365         https://bugs.webkit.org/show_bug.cgi?id=181201
1366
1367         Reviewed by Tim Horton.
1368
1369         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1370
1371         * WebCoreSupport/WebDragClient.h:
1372
1373 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1374
1375         Add a WebAuthentication runtime feature flag
1376         https://bugs.webkit.org/show_bug.cgi?id=181220
1377         <rdar://problem/36055305>
1378
1379         Reviewed by Brent Fulgham.
1380
1381         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1382
1383         * WebView/WebPreferenceKeysPrivate.h:
1384         * WebView/WebPreferences.mm:
1385         (+[WebPreferences initialize]):
1386         (-[WebPreferences webAuthenticationEnabled]):
1387         (-[WebPreferences setWebAuthenticationEnabled:]):
1388         (-[WebPreferences credentialManagementEnabled]): Deleted.
1389         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1390         * WebView/WebPreferencesPrivate.h:
1391         * WebView/WebView.mm:
1392         (-[WebView _preferencesChanged:]):
1393
1394 2017-12-22  Jeff Miller  <jeffm@apple.com>
1395
1396         Update user-visible copyright strings to include 2018
1397         https://bugs.webkit.org/show_bug.cgi?id=181141
1398
1399         Reviewed by Dan Bernstein.
1400
1401         * Info.plist:
1402
1403 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1404
1405         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1406         https://bugs.webkit.org/show_bug.cgi?id=181188
1407
1408         Reviewed by Dan Bernstein.
1409
1410         See WebCore/ChangeLog for more detail.
1411
1412         * WebCoreSupport/WebDragClient.h:
1413         * WebCoreSupport/WebDragClient.mm:
1414         (WebDragClient::declareAndWriteAttachment): Deleted.
1415         * WebView/WebHTMLView.mm:
1416         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1417
1418 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1419
1420         Unreviewed, continue to fix build failures due to AppKit API deprecation
1421
1422         Wraps more code in -Wdeprecated-declarations.
1423
1424         * Carbon/HIWebView.mm:
1425         (overrideCGContext):
1426
1427 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1428
1429         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1430
1431         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1432
1433         * Carbon/CarbonWindowAdapter.mm:
1434         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1435         * Plugins/WebNetscapePluginView.mm:
1436         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1437         (-[WebNetscapePluginView sendDrawRectEvent:]):
1438         (-[WebNetscapePluginView drawRect:]):
1439
1440 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1441
1442         Fix build failures due to using deprecated AppKit symbols
1443         https://bugs.webkit.org/show_bug.cgi?id=181110
1444         <rdar://problem/36162865>
1445
1446         Reviewed by Dan Bernstein and Tim Horton.
1447
1448         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1449
1450         * Misc/WebKitNSStringExtras.mm:
1451         (-[NSString _web_drawAtPoint:font:textColor:]):
1452         * Misc/WebNSPasteboardExtras.h:
1453         * Misc/WebNSPasteboardExtras.mm:
1454         (+[NSPasteboard _web_writableTypesForURL]):
1455         (_createWritableTypesForImageWithoutArchive):
1456         (_createWritableTypesForImageWithArchive):
1457         (+[NSPasteboard _web_dragTypesForURL]):
1458         (-[NSPasteboard _web_bestURL]):
1459         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1460         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1461         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1462         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1463         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1464         * Panels/WebAuthenticationPanel.m:
1465         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1466         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1467         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1468         (-[WebHostedNetscapePluginView drawRect:]):
1469         * WebInspector/WebNodeHighlightView.mm:
1470         (-[WebNodeHighlightView drawRect:]):
1471         * WebView/WebFrame.mm:
1472         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1473         (-[WebFrame _drawRect:contentsOnly:]):
1474         * WebView/WebHTMLView.mm:
1475         (kit):
1476         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1477         (-[WebHTMLView _plainTextFromPasteboard:]):
1478         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1479         (+[WebHTMLView _insertablePasteboardTypes]):
1480         (+[WebHTMLView _selectionPasteboardTypes]):
1481         (-[WebHTMLView pasteboard:provideDataForType:]):
1482         (-[WebHTMLView _writeSelectionToPasteboard:]):
1483         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1484         (-[WebHTMLView validRequestorForSendType:returnType:]):
1485         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1486         (createMenuItem):
1487         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1488         (-[WebHTMLView _colorAsString:]):
1489         (-[WebHTMLView copyFont:]):
1490         * WebView/WebPDFView.mm:
1491         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1492         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1493         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1494         (-[WebPDFView pasteboardTypesForSelection]):
1495         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1496         * WebView/WebView.h:
1497         * WebView/WebView.mm:
1498         (-[WebView performDragOperation:]):
1499         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1500         (-[WebView _searchWithGoogleFromMenu:]):
1501
1502 2017-12-21  Youenn Fablet  <youenn@apple.com>
1503
1504         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1505         https://bugs.webkit.org/show_bug.cgi?id=181000
1506
1507         Reviewed by Chris Dumez.
1508
1509         * Misc/WebCache.mm:
1510         (+[WebCache addImageToCache:forURL:forFrame:]):
1511
1512 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1513
1514         Update FULLSCREEN_API feature defines.
1515         https://bugs.webkit.org/show_bug.cgi?id=181015
1516
1517         Reviewed by Tim Horton.
1518
1519         Change enabled iphone sdk for FULLSCREEN_API.
1520
1521         * Configurations/FeatureDefines.xcconfig:
1522
1523 2017-12-21  Jer Noble  <jer.noble@apple.com>
1524
1525         Add initial DOM support for Media Capabilities
1526         https://bugs.webkit.org/show_bug.cgi?id=181064
1527
1528         Reviewed by Eric Carlson.
1529
1530         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1531
1532         * WebView/WebPreferenceKeysPrivate.h:
1533         * WebView/WebPreferences.mm:
1534         (+[WebPreferences initialize]):
1535         (-[WebPreferences mediaCapabilitiesEnabled]):
1536         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1537         * WebView/WebPreferencesPrivate.h:
1538         * WebView/WebView.mm:
1539         (-[WebView _preferencesChanged:]):
1540
1541 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1542
1543         Enable picture-in-picture from inline element on suspend.
1544         https://bugs.webkit.org/show_bug.cgi?id=180942
1545         rdar://problem/34745234
1546
1547         Reviewed by Jer Noble.
1548
1549         Update signature of enterVideoFullscreenForVideoElement().
1550
1551         * WebCoreSupport/WebChromeClient.h:
1552         * WebCoreSupport/WebChromeClient.mm:
1553         (WebChromeClient::enterVideoFullscreenForVideoElement):
1554
1555 2017-12-20  Daniel Bates  <dabates@apple.com>
1556
1557         Remove Alternative Presentation Button
1558         https://bugs.webkit.org/show_bug.cgi?id=180500
1559         <rdar://problem/35891047>
1560
1561         Reviewed by Simon Fraser.
1562
1563         We no longer need the alternative presentation button.
1564
1565         * Configurations/FeatureDefines.xcconfig:
1566
1567 2017-12-19  Jer Noble  <jer.noble@apple.com>
1568
1569         Playing media elements which call "pause(); play()" will have the play promise rejected.
1570         https://bugs.webkit.org/show_bug.cgi?id=180781
1571         <rdar://problem/33191377>
1572
1573         Reviewed by Eric Carlson.
1574
1575         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1576
1577         * WebView/WebView.mm:
1578         (shouldRequireUserGestureToLoadVideo):
1579
1580 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1581
1582         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1583         https://bugs.webkit.org/show_bug.cgi?id=180977
1584
1585         Reviewed by Tim Horton.
1586
1587         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1588         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1589         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1590
1591         * WebCoreSupport/WebEditorClient.mm:
1592         (attributesForAttributedStringConversion):
1593         * WebView/WebHTMLView.mm:
1594         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1595
1596 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1597
1598         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1599
1600         Attempt to fix the following warnings:
1601
1602             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1603
1604         For the following instance variables:
1605
1606             _borderView
1607             _contentView
1608             _frame
1609             _wFlags
1610
1611         * Carbon/CarbonWindowAdapter.mm:
1612         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1613         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1614         (-[CarbonWindowAdapter _termWindowIfOwner]):
1615         (-[CarbonWindowAdapter _windowMovedToRect:]):
1616         (-[CarbonWindowAdapter setContentView:]):
1617         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1618         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1619
1620 2017-12-16  Dan Bernstein  <mitz@apple.com>
1621
1622         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1623         https://bugs.webkit.org/show_bug.cgi?id=180613
1624         <rdar://problem/35946124>
1625
1626         Reviewed by Geoff Garen.
1627
1628         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1629           clients.
1630         * WebView/WebDynamicScrollBarsView.h: Ditto.
1631         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1632
1633 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1634
1635         Enable -Wstrict-prototypes for WebKit
1636         <https://webkit.org/b/180757>
1637         <rdar://problem/36024132>
1638
1639         Rubber-stamped by Joseph Pecoraro.
1640
1641         * Configurations/Base.xcconfig:
1642         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1643
1644 2017-12-14  John Wilander  <wilander@apple.com>
1645
1646         Storage Access API: Implement frame-specific access in the document.cookie layer
1647         https://bugs.webkit.org/show_bug.cgi?id=180682
1648         <rdar://problem/35982257>
1649
1650         Reviewed by Alex Christensen.
1651
1652         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1653         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1654         CookiesStrategy::getRawCookies() now take optional parameters for
1655         frameID and pageID to allow frame-specific scoping of cookies.
1656
1657         This change makes the return values of FrameLoaderClient::frameID()
1658         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1659         WebCore can call those getters and get the right return values in
1660         WebKit and std:nullopt in WebKitLegacy.
1661
1662         * WebCoreSupport/WebFrameLoaderClient.h:
1663         * WebCoreSupport/WebFrameLoaderClient.mm:
1664         (WebFrameLoaderClient::pageID const):
1665         (WebFrameLoaderClient::frameID const):
1666         * WebCoreSupport/WebPlatformStrategies.h:
1667         * WebCoreSupport/WebPlatformStrategies.mm:
1668         (WebPlatformStrategies::cookiesForDOM):
1669         (WebPlatformStrategies::setCookiesFromDOM):
1670         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1671         (WebPlatformStrategies::getRawCookies):
1672
1673 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1674
1675         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1676         https://bugs.webkit.org/show_bug.cgi?id=180689
1677
1678         Reviewed by Tim Horton.
1679
1680         Use sRGBColorSpaceRef() from WebCore.
1681
1682         * WebView/WebHTMLView.mm:
1683         (imageFromRect):
1684
1685 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1686
1687         Stop using deprecated target conditional for simulator builds
1688         https://bugs.webkit.org/show_bug.cgi?id=180662
1689         <rdar://problem/35136156>
1690
1691         Reviewed by Simon Fraser.
1692
1693         * postprocess-headers.sh:
1694
1695 2017-12-11  David Quesada  <david_quesada@apple.com>
1696
1697         Turn on ENABLE_APPLICATION_MANIFEST
1698         https://bugs.webkit.org/show_bug.cgi?id=180562
1699         rdar://problem/35924737
1700
1701         Reviewed by Geoffrey Garen.
1702
1703         * Configurations/FeatureDefines.xcconfig:
1704
1705 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1706
1707         Remove pthread_once in favor of dispatch_once
1708         https://bugs.webkit.org/show_bug.cgi?id=180591
1709
1710         Reviewed by Saam Barati.
1711
1712         * Misc/WebKitErrors.m:
1713         (+[NSError _registerWebKitErrors]):
1714         (registerErrors): Deleted.
1715         * Storage/WebStorageManager.mm:
1716         (+[WebStorageManager _storageDirectoryPath]):
1717         (initializeLocalStoragePath): Deleted.
1718
1719 2017-12-07  Darin Adler  <darin@apple.com>
1720
1721         Remove some unused code from WebKitLegacy
1722         https://bugs.webkit.org/show_bug.cgi?id=180567
1723
1724         Reviewed by Anders Carlsson.
1725
1726         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1727         macOS (back a few versions) and iOS and removed unused
1728         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1729         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1730         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1731         _webkit_stringByCollapsingNonPrintingCharacters,
1732         _webkit_stringByCollapsingWhitespaceCharacters,
1733         _web_stringWithData:textEncodingName:, and
1734         _webkit_localStorageDirectoryWithBundleIdentifier:.
1735
1736         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1737         this source file.
1738         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1739         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1740         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1741         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1742         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1743         handle font smoothing options.
1744         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1745         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1746         from header and made it a little clearer.
1747         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1748         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1749         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1750         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1751         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1752         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1753         implementation a bit and used whole words instead of abbreviations.
1754         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1755
1756         * Misc/WebNSFileManagerExtras.mm:
1757         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1758         filenameByFixingIllegalCharacters function from WebCore directly instead of
1759         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1760
1761         * Plugins/WebBaseNetscapePluginView.mm:
1762         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1763         string replacements instead of _web_stringByStrippingReturnCharacters
1764         and to use NSString methods instead of CFString functions.
1765
1766 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1767
1768         Ignore deprecation warnings.
1769
1770         * WebView/WebHTMLView.mm:
1771         (-[NSWindow _web_borderView]):
1772         (-[WebHTMLView _setAsideSubviews]):
1773         * WebView/WebView.mm:
1774         (-[WebView encodeWithCoder:]):
1775
1776 2017-12-02  Darin Adler  <darin@apple.com>
1777
1778         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1779         https://bugs.webkit.org/show_bug.cgi?id=180009
1780
1781         Reviewed by Alex Christensen.
1782
1783         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1784
1785         * Plugins/WebBaseNetscapePluginView.mm:
1786         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1787         of strcasecmp.
1788
1789         * WebView/WebPreferences.mm:
1790         (contains): Ditto. Also made this a template so it's easier to call on an array.
1791         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1792
1793 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1794
1795         Limit user agent versioning to an upper bound
1796         https://bugs.webkit.org/show_bug.cgi?id=180365
1797         <rdar://problem/34550617>
1798
1799         Reviewed by Joseph Pecoraro.
1800
1801         * WebView/WebView.mm:
1802         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1803         creating the User Agent string.
1804         (webKitBundleVersionString): Deleted.
1805
1806 2017-12-05  Andy Estes  <aestes@apple.com>
1807
1808         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1809         https://bugs.webkit.org/show_bug.cgi?id=180457
1810         <rdar://problem/35143007>
1811
1812         Reviewed by Tim Horton.
1813
1814         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1815         check for this macro during post-processing.
1816
1817         * postprocess-headers.sh:
1818
1819 2017-12-04  David Quesada  <david_quesada@apple.com>
1820
1821         Add a class for parsing application manifests
1822         https://bugs.webkit.org/show_bug.cgi?id=177973
1823         rdar://problem/34747949
1824
1825         Reviewed by Geoffrey Garen.
1826
1827         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1828
1829 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1830
1831         Make LegacyCustomProtocolManager optional for network process
1832         https://bugs.webkit.org/show_bug.cgi?id=176230
1833
1834         Reviewed by Alex Christensen.
1835
1836         * Configurations/FeatureDefines.xcconfig:
1837
1838 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1839
1840         Fix some NSOperationQueue leaks
1841         https://bugs.webkit.org/show_bug.cgi?id=180221
1842
1843         Reviewed by Wenson Hsieh.
1844
1845         * WebView/WebView.mm:
1846         (-[WebView performDragOperation:]):
1847
1848 2017-11-30  Darin Adler  <darin@apple.com>
1849
1850         [Mac] remove unneeded RetainPtr use introduced in r225142
1851         https://bugs.webkit.org/show_bug.cgi?id=180202
1852
1853         Reviewed by Tim Horton.
1854
1855         * WebView/WebImmediateActionController.mm:
1856         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1857         RetainPtr.
1858
1859 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1860
1861         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1862         https://bugs.webkit.org/show_bug.cgi?id=175595
1863
1864         Reviewed by Darin Adler.
1865
1866         * WebView/WebPreferences.mm:
1867
1868 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1869
1870         One too many zeroes in macOS version number in FeatureDefines
1871         https://bugs.webkit.org/show_bug.cgi?id=180011
1872
1873         Reviewed by Dan Bernstein.
1874
1875         * Configurations/FeatureDefines.xcconfig:
1876
1877 2017-11-23  Darin Adler  <darin@apple.com>
1878
1879         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1880         https://bugs.webkit.org/show_bug.cgi?id=179981
1881
1882         Reviewed by Sam Weinig.
1883
1884         * WebView/WebImmediateActionController.mm:
1885         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1886         * WebView/WebView.mm:
1887         (coreOptions): Use |= instead of | to build up FindOptions.
1888
1889 2017-11-23  Sam Weinig  <sam@webkit.org>
1890
1891         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1892         https://bugs.webkit.org/show_bug.cgi?id=179954
1893
1894         Reviewed by Darin Adler.
1895
1896         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1897         with direct calls to the corresponding UserGestureIndicator functions.
1898
1899         * Plugins/WebPluginController.mm:
1900         (-[WebPluginController processingUserGesture]):
1901         * WebView/WebView.mm:
1902         (-[WebView _isProcessingUserGesture]):
1903
1904 2017-11-23  Darin Adler  <darin@apple.com>
1905
1906         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1907         https://bugs.webkit.org/show_bug.cgi?id=179907
1908
1909         Reviewed by Sam Weinig.
1910
1911         * History/BinaryPropertyList.cpp:
1912         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1913         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1914         * WebView/WebHTMLRepresentation.mm:
1915         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1916         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1917
1918 2017-11-22  Ali Juma  <ajuma@chromium.org>
1919
1920         Implement VisualViewport API attributes
1921         https://bugs.webkit.org/show_bug.cgi?id=179385
1922
1923         Reviewed by Frédéric Wang.
1924
1925         Add a VisualViewportAPI preference.
1926
1927         * WebView/WebPreferenceKeysPrivate.h:
1928         * WebView/WebPreferences.mm:
1929         (+[WebPreferences initialize]):
1930         (-[WebPreferences visualViewportAPIEnabled]):
1931         (-[WebPreferences setVisualViewportAPIEnabled:]):
1932         * WebView/WebPreferencesPrivate.h:
1933         * WebView/WebView.mm:
1934         (-[WebView _preferencesChanged:]):
1935
1936 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1937
1938         WebCoreObjCExtras.h is being included in too many places
1939         https://bugs.webkit.org/show_bug.cgi?id=179931
1940
1941         Reviewed by Darin Adler.
1942
1943         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1944         * Plugins/WebBaseNetscapePluginView.mm:
1945         * Plugins/WebBasePluginPackage.mm:
1946         * Plugins/WebNetscapePluginStream.mm:
1947         * Plugins/WebNetscapePluginView.mm:
1948         * WebView/WebTextIterator.mm:
1949         * WebView/WebViewData.mm:
1950
1951 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1952
1953         Unreviewed, rolling out r225093.
1954         https://bugs.webkit.org/show_bug.cgi?id=179938
1955
1956         Compilation failed on WinCairo 64-bit Release (Requested by
1957         fredw on #webkit).
1958
1959         Reverted changeset:
1960
1961         "Implement VisualViewport API attributes"
1962         https://bugs.webkit.org/show_bug.cgi?id=179385
1963         https://trac.webkit.org/changeset/225093
1964
1965 2017-11-21  Ali Juma  <ajuma@chromium.org>
1966
1967         Implement VisualViewport API attributes
1968         https://bugs.webkit.org/show_bug.cgi?id=179385
1969
1970         Reviewed by Frédéric Wang.
1971
1972         Add a VisualViewportAPI preference.
1973
1974         * WebView/WebPreferenceKeysPrivate.h:
1975         * WebView/WebPreferences.mm:
1976         (+[WebPreferences initialize]):
1977         (-[WebPreferences visualViewportAPIEnabled]):
1978         (-[WebPreferences setVisualViewportAPIEnabled:]):
1979         * WebView/WebPreferencesPrivate.h:
1980         * WebView/WebView.mm:
1981         (-[WebView _preferencesChanged:]):
1982
1983 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1984
1985         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1986         https://bugs.webkit.org/show_bug.cgi?id=179504
1987
1988         Reviewed by Darin Adler.
1989
1990         * Misc/WebKitNSStringExtras.mm:
1991         * Plugins/Hosted/NetscapePluginHostManager.mm:
1992         * Plugins/WebBasePluginPackage.mm:
1993
1994 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1995
1996         Remove unused TOUCH_ICON_LOADING feature flag
1997         https://bugs.webkit.org/show_bug.cgi?id=179873
1998
1999         Reviewed by Simon Fraser.
2000
2001         * Configurations/FeatureDefines.xcconfig:
2002
2003 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2004
2005         Remove unused LEGACY_VENDOR_PREFIXES feature flag
2006         https://bugs.webkit.org/show_bug.cgi?id=179872
2007
2008         Reviewed by Darin Adler.
2009
2010         * Configurations/FeatureDefines.xcconfig:
2011
2012 2017-11-16  Daniel Bates  <dabates@apple.com>
2013
2014         Add feature define for alternative presentation button element
2015         https://bugs.webkit.org/show_bug.cgi?id=179692
2016         Part of <rdar://problem/34917108>
2017
2018         Reviewed by Andy Estes.
2019
2020         Only enabled on Cocoa platforms by default.
2021
2022         * Configurations/FeatureDefines.xcconfig:
2023
2024 2017-11-14  Nan Wang  <n_wang@apple.com>
2025
2026         AX: AOM: Implement AccessibleNode class and support label and role attributes
2027         https://bugs.webkit.org/show_bug.cgi?id=179494
2028
2029         Reviewed by Ryosuke Niwa.
2030
2031         * WebView/WebPreferenceKeysPrivate.h:
2032         * WebView/WebPreferences.mm:
2033         (+[WebPreferences initialize]):
2034         (-[WebPreferences accessibilityObjectModelEnabled]):
2035         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
2036         * WebView/WebPreferencesPrivate.h:
2037         * WebView/WebView.mm:
2038         (-[WebView _preferencesChanged:]):
2039
2040 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2041
2042         Remove Cocoa CFURLConnection loading code
2043         https://bugs.webkit.org/show_bug.cgi?id=179688
2044
2045         Reviewed by Antti Koivisto.
2046
2047         * Misc/WebDownload.mm:
2048         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2049         * Misc/WebDownloadInternal.h:
2050         * Plugins/WebBaseNetscapePluginView.mm:
2051         * WebCoreSupport/WebFrameLoaderClient.mm:
2052         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2053         * WebView/WebView.mm:
2054         (-[WebView scheduleInRunLoop:forMode:]):
2055         (-[WebView unscheduleFromRunLoop:forMode:]):
2056
2057 2017-11-14  Daniel Bates  <dabates@apple.com>
2058
2059         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
2060         for feature defines
2061
2062         Following r195498 and r201917 the Visual Studio property files for feature defines have
2063         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2064         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2065         files.
2066
2067         * Configurations/FeatureDefines.xcconfig:
2068
2069 2017-11-14  Jer Noble  <jer.noble@apple.com>
2070
2071         Enable Modern EME tests in DumpRenderTree
2072         https://bugs.webkit.org/show_bug.cgi?id=179544
2073
2074         Reviewed by Alex Christensen.
2075
2076         Add a WebPreferences property to enable the (modern) EME API.
2077
2078         * WebView/WebPreferenceKeysPrivate.h:
2079         * WebView/WebPreferences.mm:
2080         (+[WebPreferences initialize]):
2081         (-[WebPreferences encryptedMediaAPIEnabled]):
2082         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2083         * WebView/WebPreferencesPrivate.h:
2084         * WebView/WebView.mm:
2085         (-[WebView _preferencesChanged:]):
2086
2087 2017-11-14  Antti Koivisto  <antti@apple.com>
2088
2089         Enable display:contents by default
2090         https://bugs.webkit.org/show_bug.cgi?id=179655
2091
2092         Reviewed by Sam Weinig.
2093
2094         * WebView/WebPreferences.mm:
2095         (+[WebPreferences initialize]):
2096
2097 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2098
2099         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2100         https://bugs.webkit.org/show_bug.cgi?id=178751
2101
2102         Reviewed by Brady Eidson.
2103
2104         * WebCoreSupport/WebFrameNetworkingContext.mm:
2105         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2106
2107 2017-11-08  Keith Miller  <keith_miller@apple.com>
2108
2109         Async iteration should only fetch the next method once and add feature flag
2110         https://bugs.webkit.org/show_bug.cgi?id=179451
2111
2112         Reviewed by Geoffrey Garen.
2113
2114         Add feature flag for Async iteration.
2115
2116         * Configurations/FeatureDefines.xcconfig:
2117
2118 2017-11-13  Mark Lam  <mark.lam@apple.com>
2119
2120         Add more overflow check book-keeping for MarkedArgumentBuffer.
2121         https://bugs.webkit.org/show_bug.cgi?id=179634
2122         <rdar://problem/35492517>
2123
2124         Reviewed by Saam Barati.
2125
2126         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2127         (WebKit::NetscapePluginInstanceProxy::invoke):
2128         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2129         (WebKit::NetscapePluginInstanceProxy::construct):
2130
2131 2017-11-12  Darin Adler  <darin@apple.com>
2132
2133         More is<> and downcast<>, less static_cast<>
2134         https://bugs.webkit.org/show_bug.cgi?id=179600
2135
2136         Reviewed by Chris Dumez.
2137
2138         * DOM/DOM.mm:
2139         (kit): Use is/downcast.
2140         * WebCoreSupport/WebEditorClient.mm:
2141         (WebEditorClient::handleKeyboardEvent): Ditto.
2142         (WebEditorClient::handleInputMethodKeydown): Ditto.
2143         * WebView/WebHTMLView.mm:
2144         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2145
2146 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2147
2148         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2149         https://bugs.webkit.org/show_bug.cgi?id=179397
2150
2151         Reviewed by Wenson Hsieh.
2152
2153         * DOM/DOMHTMLInputElement.mm:
2154         (-[DOMHTMLInputElement insertTextSuggestion:]):
2155
2156 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2157
2158         HTMLMediaElement should not use element fullscreen on iOS
2159         https://bugs.webkit.org/show_bug.cgi?id=179418
2160         rdar://problem/35409277
2161
2162         Reviewed by Eric Carlson.
2163
2164         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2165
2166         * Configurations/FeatureDefines.xcconfig:
2167
2168 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2169
2170         Make ResourceLoader::willSendRequestInternal asynchronous
2171         https://bugs.webkit.org/show_bug.cgi?id=179251
2172
2173         Reviewed by Andy Estes.
2174
2175         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2176         (WebKit::HostedNetscapePluginStream::start):
2177         * Plugins/WebNetscapePluginStream.mm:
2178         (WebNetscapePluginStream::start):
2179
2180 2017-11-01  Darin Adler  <darin@apple.com>
2181
2182         Simplify event dispatch code and make it a bit more consistent
2183         https://bugs.webkit.org/show_bug.cgi?id=178991
2184
2185         Reviewed by Chris Dumez.
2186
2187         * DOM/DOMEvent.mm:
2188         (-[DOMEvent srcElement]): Call target instead of srcElement.
2189
2190 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2191
2192         [Touch Bar Web API] Add support for menuitem tag
2193         https://bugs.webkit.org/show_bug.cgi?id=179020
2194
2195         Reviewed by Ryosuke Niwa.
2196
2197         Adds in properties and methods that allow the menuitem runtime feature
2198         to be enabled or disabled.
2199
2200         * WebView/WebPreferenceKeysPrivate.h:
2201         * WebView/WebPreferences.mm:
2202         (-[WebPreferences menuItemElementEnabled]):
2203         (-[WebPreferences setMenuItemElementEnabled:]):
2204         * WebView/WebPreferencesPrivate.h:
2205         * WebView/WebView.mm:
2206         (-[WebView _preferencesChanged:]):
2207
2208 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2209
2210         Use CompletionHandlers for redirects
2211         https://bugs.webkit.org/show_bug.cgi?id=179163
2212
2213         Reviewed by Tim Horton.
2214
2215         * Plugins/Hosted/HostedNetscapePluginStream.h:
2216         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2217         (WebKit::HostedNetscapePluginStream::willSendRequest):
2218         * Plugins/WebNetscapePluginStream.h:
2219         * Plugins/WebNetscapePluginStream.mm:
2220         (WebNetscapePluginStream::willSendRequest):
2221
2222 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2223
2224         Add a FileSystem namespace to FileSystem.cpp
2225         https://bugs.webkit.org/show_bug.cgi?id=179063
2226
2227         Reviewed by Darin Adler.
2228
2229         * Misc/WebNSFileManagerExtras.mm:
2230         * Storage/WebDatabaseProvider.mm:
2231
2232 2017-11-02  Frederic Wang  <fwang@igalia.com>
2233
2234         Add references to bug 179167 in FIXME comments
2235         https://bugs.webkit.org/show_bug.cgi?id=179168
2236
2237         Reviewed by Daniel Bates.
2238
2239         * Configurations/FeatureDefines.xcconfig:
2240
2241 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2242
2243         Implement WKFullscreenWindowController for iOS.
2244         https://bugs.webkit.org/show_bug.cgi?id=178924
2245         rdar://problem/34697120
2246
2247         Reviewed by Simon Fraser.
2248
2249         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2250
2251         * Configurations/FeatureDefines.xcconfig:
2252         * WebView/WebView.mm:
2253         (-[WebView fullScreenPlaceholderView]):
2254
2255 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2256
2257         Clean up some drag and drop feature flags
2258         https://bugs.webkit.org/show_bug.cgi?id=179082
2259
2260         Reviewed by Simon Fraser.
2261
2262         * Configurations/FeatureDefines.xcconfig:
2263
2264 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2265
2266         Make it possible to test rubber-banding in overflow scroll
2267         https://bugs.webkit.org/show_bug.cgi?id=179078
2268
2269         Reviewed by Sam Weinig.
2270
2271         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2272         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2273
2274         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2275         functions, since most callers want clamped.
2276
2277         * DOM/DOMHTML.mm:
2278         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2279
2280 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2281
2282         Fix up some content filtering feature flags
2283         https://bugs.webkit.org/show_bug.cgi?id=179079
2284
2285         Reviewed by Simon Fraser.
2286
2287         * Configurations/FeatureDefines.xcconfig:
2288
2289 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2290
2291         [FrameView::layout cleanup] Move core layout logic to a separate class.
2292         https://bugs.webkit.org/show_bug.cgi?id=178771
2293         <rdar://problem/35166542>
2294
2295         Reviewed by Simon Fraser.
2296
2297         Move layout code out from FrameView to LayoutContext.
2298
2299         * WebView/WebClipView.mm:
2300         (-[WebClipView _immediateScrollToPoint:]):
2301         * WebView/WebFrame.mm:
2302         (-[WebFrame layoutCount]):
2303
2304 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2305
2306         Fix issues with WebView subframe painting
2307         https://bugs.webkit.org/show_bug.cgi?id=178842
2308         rdar://problem/34072253
2309
2310         Reviewed by Daniel Bates.
2311         
2312         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2313         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2314         High Sierra, so match the new signature.
2315
2316         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2317
2318         * WebView/WebHTMLView.mm:
2319         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2320         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2321
2322 2017-10-25  Youenn Fablet  <youenn@apple.com>
2323
2324         Enable ServiceWorker to fetch resources
2325         https://bugs.webkit.org/show_bug.cgi?id=178673
2326
2327         Reviewed by Brady Eidson.
2328
2329         * WebCoreSupport/WebFrameLoaderClient.mm:
2330         (WebFrameLoaderClient::pageID const):
2331         (WebFrameLoaderClient::frameID const):
2332         (WebFrameLoaderClient::sessionID const):
2333
2334         Added implementation to the new getters.
2335         They are noop in the context of WK1.
2336
2337 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2338
2339         Web Inspector: Enable WebKit logging configuration and display
2340         https://bugs.webkit.org/show_bug.cgi?id=177027
2341         <rdar://problem/33964767>
2342
2343         Reviewed by Joseph Pecoraro.
2344
2345         * WebCoreSupport/WebChromeClient.mm:
2346         (stringForMessageSource): Deal with Media and WebRTC message sources.
2347
2348 2017-10-20  Antoine Quint  <graouts@apple.com>
2349
2350         [Web Animations] Provide basic timeline and animation interfaces
2351         https://bugs.webkit.org/show_bug.cgi?id=178526
2352
2353         Reviewed by Dean Jackson.
2354
2355         Remove the WEB_ANIMATIONS compile-time flag.
2356
2357         * Configurations/FeatureDefines.xcconfig:
2358         * WebView/WebPreferences.mm:
2359         (+[WebPreferences initialize]):
2360         * WebView/WebView.mm:
2361         (-[WebView _preferencesChanged:]):
2362
2363 2017-10-19  Sam Weinig  <sam@webkit.org>
2364
2365         [Settings] Move global settings into their own file
2366         https://bugs.webkit.org/show_bug.cgi?id=178512
2367
2368         Reviewed by Darin Adler.
2369
2370         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2371
2372         * WebCoreSupport/WebChromeClient.mm:
2373         (WebChromeClient::supportsVideoFullscreen):
2374         * WebView/WebDynamicScrollBarsView.mm:
2375         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2376         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2377         * WebView/WebPreferences.mm:
2378         (+[WebPreferences initialize]):
2379         * WebView/WebView.mm:
2380         (-[WebView _commonInitializationWithFrameName:groupName:]):
2381         (-[WebView _preferencesChanged:]):
2382         (+[WebView _doNotStartObservingNetworkReachability]):
2383
2384 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2385
2386         Replace some stack raw pointers with RefPtrs within WebCore/html
2387         https://bugs.webkit.org/show_bug.cgi?id=178201
2388         <rdar://problem/34841692>
2389
2390         Reviewed by Ryosuke Niwa.
2391
2392         * DOM/DOM.mm:
2393         (kit):
2394         Change the type of node as toNode() is changed to return RefPtr.
2395
2396 2017-10-18  Chris Dumez  <cdumez@apple.com>
2397
2398         [Service Worker] Add stubs for Client / WindowClient / Clients
2399         https://bugs.webkit.org/show_bug.cgi?id=178469
2400
2401         Reviewed by Youenn Fablet.
2402
2403         Rename PageVisiblityState to VisibilityState.
2404
2405         * WebView/WebView.mm:
2406         (kit):
2407
2408 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2409
2410         Unreviewed, rolling out r223291.
2411
2412         See WebCore ChangeLog for more detail.
2413
2414         Reverted changeset:
2415
2416         "Remove Editor::simplifyMarkup"
2417         https://bugs.webkit.org/show_bug.cgi?id=178271
2418         https://trac.webkit.org/changeset/223291
2419
2420 2017-10-17  Keith Miller  <keith_miller@apple.com>
2421
2422         Change WebCore sources to work with unified source builds
2423         https://bugs.webkit.org/show_bug.cgi?id=178229
2424
2425         Rubber stamped by Tim Horton.
2426
2427         * Configurations/FeatureDefines.xcconfig:
2428
2429 2017-10-16  Sam Weinig  <sam@webkit.org>
2430
2431         [Settings] Remove all custom code from Settings.h/cpp
2432         https://bugs.webkit.org/show_bug.cgi?id=178330
2433
2434         Reviewed by Simon Fraser.
2435
2436         * WebView/WebPreferences.mm:
2437         (+[WebPreferences initialize]):
2438         
2439             Update for naming changes of FrameFlattening now that it is an enum class.
2440
2441 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2442
2443         Remove Editor::simplifyMarkup
2444         https://bugs.webkit.org/show_bug.cgi?id=178271
2445
2446         Reviewed by Wenson Hsieh.
2447
2448         * WebView/WebView.mm:
2449         (-[WebView _simplifyMarkup:endNode:]):
2450
2451 2017-10-12  Chris Dumez  <cdumez@apple.com>
2452
2453         [Mac] Add support for MouseEvent.buttons
2454         https://bugs.webkit.org/show_bug.cgi?id=178214
2455
2456         Reviewed by Ryosuke Niwa.
2457
2458         * WebView/WebPDFView.mm:
2459         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2460
2461 2017-10-11  Sam Weinig  <sam@webkit.org>
2462
2463         Remove out-parameter variants of copyToVector
2464         https://bugs.webkit.org/show_bug.cgi?id=178155
2465
2466         Reviewed by Tim Horton.
2467
2468         * Plugins/WebNetscapePluginView.mm:
2469         (-[WebNetscapePluginView destroyPlugin]):
2470         * WebView/WebHTMLRepresentation.mm:
2471         (newArrayWithStrings):
2472
2473             Replace out-parameter based copyToVector, with one that returns a Vector.
2474
2475 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2476
2477         Sanitize URL in pasteboard for other applications and cross origin content
2478         https://bugs.webkit.org/show_bug.cgi?id=178060
2479         <rdar://problem/34874518>
2480
2481         Reviewed by Wenson Hsieh.
2482
2483         * WebCoreSupport/WebPlatformStrategies.h:
2484         * WebCoreSupport/WebPlatformStrategies.mm:
2485         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2486
2487 2017-10-11  Chris Dumez  <cdumez@apple.com>
2488
2489         Modernize Geolocation code
2490         https://bugs.webkit.org/show_bug.cgi?id=178148
2491
2492         Reviewed by Ryosuke Niwa.
2493
2494         * WebCoreSupport/WebGeolocationClient.h:
2495         * WebCoreSupport/WebGeolocationClient.mm:
2496         (WebGeolocationClient::lastPosition):
2497         * WebView/WebGeolocationPosition.mm:
2498         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2499         (core):
2500         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2501         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2502         * WebView/WebGeolocationPositionInternal.h:
2503
2504 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2505
2506         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2507         https://bugs.webkit.org/show_bug.cgi?id=178154
2508
2509         Reviewed by Wenson Hsieh.
2510
2511         Enable custom pasteboard data by default.
2512
2513         * WebView/WebPreferenceKeysPrivate.h:
2514         * WebView/WebPreferences.mm:
2515         (+[WebPreferences initialize]):
2516         (-[WebPreferences customPasteboardDataEnabled]): Added.
2517         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2518         * WebView/WebPreferencesPrivate.h:
2519         * WebView/WebView.mm:
2520         (-[WebView _preferencesChanged:]):
2521
2522 2017-10-10  Sam Weinig  <sam@webkit.org>
2523
2524         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2525         https://bugs.webkit.org/show_bug.cgi?id=178102
2526
2527         Reviewed by Tim Horton.
2528
2529         * History/WebHistory.mm:
2530         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2531         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2532         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2533         * WebCoreSupport/WebUserMediaClient.mm:
2534         (WebUserMediaClient::pageDestroyed):
2535
2536 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2537
2538         Make the names of the options consistent
2539         https://bugs.webkit.org/show_bug.cgi?id=177933
2540
2541         Reviewed by Saam Barati.
2542
2543         * WebView/WebFrame.h:
2544         * WebView/WebHTMLView.mm:
2545         (-[WebHTMLView setMarkedText:selectedRange:]):
2546         * WebView/WebView.h:
2547
2548 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2549
2550         [iOS] Tweak support for classifying form controls (followup to r222487)
2551         https://bugs.webkit.org/show_bug.cgi?id=177917
2552         <rdar://problem/34820122>
2553
2554         Reviewed by Dean Jackson.
2555
2556         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2557
2558         * DOM/DOMHTMLInputElement.mm:
2559         (-[DOMHTMLInputElement _autofillContext]):
2560         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2561         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2562
2563 2017-10-05  Keith Miller  <keith_miller@apple.com>
2564
2565         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2566
2567         * Configurations/WebKitLegacy.xcconfig:
2568
2569 2017-10-05  Jer Noble  <jer.noble@apple.com>
2570
2571         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2572         https://bugs.webkit.org/show_bug.cgi?id=177261
2573
2574         Reviewed by Eric Carlson.
2575
2576         * Configurations/FeatureDefines.xcconfig:
2577
2578 2017-10-05  Chris Dumez  <cdumez@apple.com>
2579
2580         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2581         https://bugs.webkit.org/show_bug.cgi?id=177957
2582
2583         Reviewed by Alex Christensen.
2584
2585         * WebCoreSupport/WebPlatformStrategies.h:
2586         * WebCoreSupport/WebPlatformStrategies.mm:
2587         (WebPlatformStrategies::cookiesEnabled):
2588
2589 2017-10-05  Youenn Fablet  <youenn@apple.com>
2590
2591         Make LibWebRTCProvider port agnostic
2592         https://bugs.webkit.org/show_bug.cgi?id=177747
2593
2594         Reviewed by Alex Christensen & Alex Garcia.
2595
2596         * WebView/WebView.mm:
2597         (-[WebView _commonInitializationWithFrameName:groupName:]):
2598         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2599
2600 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2601
2602         Stop linking with WebKitSystemInterface
2603         https://bugs.webkit.org/show_bug.cgi?id=177915
2604
2605         Reviewed by Antti Koivisto.
2606
2607         * Configurations/DebugRelease.xcconfig:
2608         * Configurations/WebKitLegacy.xcconfig:
2609
2610 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2611
2612         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2613         https://bugs.webkit.org/show_bug.cgi?id=177912
2614
2615         Reviewed by Saam Barati.
2616
2617         * Carbon/CarbonUtils.m:
2618         * Carbon/CarbonWindowAdapter.mm:
2619         * Carbon/HIWebView.mm:
2620         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2621         * Misc/WebNSFileManagerExtras.mm:
2622         * Misc/WebNSPasteboardExtras.mm:
2623         * Misc/WebNSURLExtras.mm:
2624         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2625         * Plugins/Hosted/NetscapePluginHostManager.mm:
2626         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2627         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2628         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2629         * Plugins/Hosted/WebTextInputWindowController.m:
2630         * Plugins/WebBaseNetscapePluginView.mm:
2631         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2632         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2633         * Plugins/WebNetscapePluginStream.mm:
2634         * Plugins/WebNetscapePluginView.mm:
2635         * Plugins/WebPluginDatabase.mm:
2636         * WebCoreSupport/PopupMenuMac.mm:
2637         * WebCoreSupport/WebChromeClient.mm:
2638         * WebCoreSupport/WebFrameLoaderClient.mm:
2639         * WebCoreSupport/WebInspectorClient.mm:
2640         * WebCoreSupport/WebPlatformStrategies.mm:
2641         * WebCoreSupport/WebSystemInterface.mm:
2642         * WebView/WebDynamicScrollBarsView.mm:
2643         * WebView/WebFrame.mm:
2644         * WebView/WebFrameView.mm:
2645         * WebView/WebFullScreenController.mm:
2646         * WebView/WebHTMLView.mm:
2647         * WebView/WebPreferences.mm:
2648         * WebView/WebView.mm:
2649
2650 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2651
2652         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2653         rdar://problem/34705779
2654
2655         Addressing review comments that I somehow landed without.
2656
2657         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2658
2659 2017-09-29  Chris Dumez  <cdumez@apple.com>
2660
2661         Split some logic out of VisitedLinkStore and make it reusable
2662         https://bugs.webkit.org/show_bug.cgi?id=177575
2663
2664         Reviewed by Alex Christensen.
2665
2666         * WebCoreSupport/WebVisitedLinkStore.h:
2667         * WebCoreSupport/WebVisitedLinkStore.mm:
2668         (WebVisitedLinkStore::addVisitedLink):
2669         (WebVisitedLinkStore::removeVisitedLink):
2670         (WebVisitedLinkStore::isLinkVisited):
2671         (WebVisitedLinkStore::addVisitedLinkHash):
2672
2673 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2674
2675         Build fix for High Sierra 32 bit Mac
2676         https://bugs.webkit.org/show_bug.cgi?id=177551
2677         <rdar://problem/34690283>
2678
2679         Reviewed by Alexey Proskuryakov.
2680
2681         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2682         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2683         also made.
2684
2685         * Carbon/CarbonWindowAdapter.mm:
2686         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2687         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2688         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2689         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2690         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2691         (-[CarbonWindowAdapter dealloc]):
2692         (-[CarbonWindowAdapter windowRef]):
2693         (-[CarbonWindowAdapter _hasWindowRef]):
2694         (-[CarbonWindowAdapter _managesWindowRef]):
2695         (-[CarbonWindowAdapter _removeWindowRef]):
2696         (-[CarbonWindowAdapter _carbonWindowClass]):
2697         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2698         (-[CarbonWindowAdapter sendSuperEvent:]):
2699         (-[CarbonWindowAdapter relinquishFocus]):
2700         (-[CarbonWindowAdapter _cancelKey:]):
2701         (-[CarbonWindowAdapter _commonAwake]):
2702         (-[CarbonWindowAdapter _destroyRealWindow:]):
2703         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2704         (-[CarbonWindowAdapter _termWindowIfOwner]):
2705         (-[CarbonWindowAdapter _windowMovedToRect:]):
2706         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2707         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2708         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2709         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2710         (-[CarbonWindowAdapter canBecomeMainWindow]):
2711         (-[CarbonWindowAdapter encodeWithCoder:]):
2712         (-[CarbonWindowAdapter initWithCoder:]):
2713         (-[CarbonWindowAdapter setContentView:]):
2714         (-[CarbonWindowAdapter worksWhenModal]):
2715         (-[CarbonWindowAdapter _setModalWindowLevel]):
2716         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2717         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2718         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2719         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2720         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2721         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2722         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2723         (NSCarbonWindowHandleEvent):
2724         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2725         (-[CarbonWindowAdapter _growBoxRect]):
2726         * Carbon/HIWebView.mm:
2727         (HIWebViewGetWebView):
2728         (HIWebViewConstructor):
2729         (HIWebViewDestructor):
2730         (HIWebViewRegisterClass):
2731         (GetBehaviors):
2732         (Draw):
2733         (HitTest):
2734         (GetRegion):
2735         (GetWindowRef):
2736         (CreateNSEventAdoptingCGEvent):
2737         (CopyEventCGEvent):
2738         (CreateNSEventWithCarbonClickEvent):
2739         (Click):
2740         (CreateNSEventWithCarbonEvent):
2741         (MouseUp):
2742         (CreateNSEventWithCarbonMouseMoveEvent):
2743         (MouseMoved):
2744         (MouseDragged):
2745         (MouseWheelMoved):
2746         (ContextMenuClick):
2747         (GetKind):
2748         (BoundsChanged):
2749         (OwningWindowChanged):
2750         (WindowHandler):
2751         (SyncFrame):
2752         (SetFocusPart):
2753         (AdvanceFocus):
2754         (RelinquishFocus):
2755         (ActiveStateChanged):
2756         (ProcessCommand):
2757         (UpdateCommandStatus):
2758         (_NSSelectorForHICommand):
2759         (HIWebViewEventHandler):
2760         (StartUpdateObserver):
2761         (StopUpdateObserver):
2762         (UpdateObserver):
2763
2764 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2765
2766         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2767         https://bugs.webkit.org/show_bug.cgi?id=172526
2768         <rdar://problem/32396081>
2769
2770         Reviewed by Ryosuke Niwa.
2771
2772         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2773
2774         * WebCoreSupport/WebPlatformStrategies.h:
2775         * WebCoreSupport/WebPlatformStrategies.mm:
2776         (WebPlatformStrategies::webExposedTypes):
2777         (WebPlatformStrategies::writeCustomData):
2778
2779 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2780
2781         Unreviewed, rolling out r222567.
2782
2783         This broke and internal build.
2784
2785         Reverted changeset:
2786
2787         "Build fix for High Sierra 32 bit Mac"
2788         https://bugs.webkit.org/show_bug.cgi?id=177551
2789         http://trac.webkit.org/changeset/222567
2790
2791 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2792
2793         Build fix for High Sierra 32 bit Mac
2794         https://bugs.webkit.org/show_bug.cgi?id=177551
2795         <rdar://problem/34690283>
2796
2797         Reviewed by Alexey Proskuryakov.
2798
2799         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2800         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2801         also made.
2802
2803         * Carbon/CarbonWindowAdapter.mm:
2804         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2805         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2806         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2807         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2808         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2809         (-[CarbonWindowAdapter dealloc]):
2810         (-[CarbonWindowAdapter windowRef]):
2811         (-[CarbonWindowAdapter _hasWindowRef]):
2812         (-[CarbonWindowAdapter _managesWindowRef]):
2813         (-[CarbonWindowAdapter _removeWindowRef]):
2814         (-[CarbonWindowAdapter _carbonWindowClass]):
2815         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2816         (-[CarbonWindowAdapter sendSuperEvent:]):
2817         (-[CarbonWindowAdapter relinquishFocus]):
2818         (-[CarbonWindowAdapter _cancelKey:]):
2819         (-[CarbonWindowAdapter _commonAwake]):
2820         (-[CarbonWindowAdapter _destroyRealWindow:]):
2821         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2822         (-[CarbonWindowAdapter _termWindowIfOwner]):
2823         (-[CarbonWindowAdapter _windowMovedToRect:]):
2824         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2825         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2826         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2827         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2828         (-[CarbonWindowAdapter canBecomeMainWindow]):
2829         (-[CarbonWindowAdapter encodeWithCoder:]):
2830         (-[CarbonWindowAdapter initWithCoder:]):
2831         (-[CarbonWindowAdapter setContentView:]):
2832         (-[CarbonWindowAdapter worksWhenModal]):
2833         (-[CarbonWindowAdapter _setModalWindowLevel]):
2834         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2835         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2836         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2837         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2838         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2839         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2840         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2841         (NSCarbonWindowHandleEvent):
2842         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2843         (-[CarbonWindowAdapter _growBoxRect]):
2844         * Carbon/HIWebView.mm:
2845         (HIWebViewGetWebView):
2846         (HIWebViewConstructor):
2847         (HIWebViewDestructor):
2848         (HIWebViewRegisterClass):
2849         (GetBehaviors):
2850         (Draw):
2851         (HitTest):
2852         (GetRegion):
2853         (GetWindowRef):
2854         (CreateNSEventAdoptingCGEvent):
2855         (CopyEventCGEvent):
2856         (CreateNSEventWithCarbonClickEvent):
2857         (Click):
2858         (CreateNSEventWithCarbonEvent):
2859         (MouseUp):
2860         (CreateNSEventWithCarbonMouseMoveEvent):
2861         (MouseMoved):
2862         (MouseDragged):
2863         (MouseWheelMoved):
2864         (ContextMenuClick):
2865         (GetKind):
2866         (BoundsChanged):
2867         (OwningWindowChanged):
2868         (WindowHandler):
2869         (SyncFrame):
2870         (SetFocusPart):
2871         (AdvanceFocus):
2872         (RelinquishFocus):
2873         (ActiveStateChanged):
2874         (ProcessCommand):
2875         (UpdateCommandStatus):
2876         (_NSSelectorForHICommand):
2877         (HIWebViewEventHandler):
2878         (StartUpdateObserver):
2879         (StopUpdateObserver):
2880         (UpdateObserver):
2881
2882 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2883
2884         Make PolicyAction an encodable enum class
2885         https://bugs.webkit.org/show_bug.cgi?id=177480
2886
2887         Reviewed by Antti Koivisto.
2888
2889         * Plugins/WebPluginContainerCheck.mm:
2890         (-[WebPluginContainerCheck _continueWithPolicy:]):
2891         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2892         * WebCoreSupport/WebFrameLoaderClient.mm:
2893         (-[WebFramePolicyListener invalidate]):
2894         (-[WebFramePolicyListener ignore]):
2895         (-[WebFramePolicyListener download]):
2896         (-[WebFramePolicyListener use]):
2897         (-[WebFramePolicyListener continue]):
2898         * WebView/WebPolicyDelegate.mm:
2899         (-[WebPolicyDecisionListener use]):
2900         (-[WebPolicyDecisionListener ignore]):
2901         (-[WebPolicyDecisionListener download]):
2902
2903 2017-09-25  Frederik Riedel  <riedel@apple.com>
2904
2905         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2906         https://bugs.webkit.org/show_bug.cgi?id=174394
2907         <rdar://problem/33183504>
2908
2909         Reviewed by Ryosuke Niwa.
2910
2911         * DOM/DOMHTMLInputElement.h:
2912         * DOM/DOMHTMLInputElement.mm:
2913         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2914         Determines if this HTMLInputElement is part of a login screen.
2915         (-[DOMHTMLInputElement representingPageUrl]):
2916         Returns the webpage's URL that is currently displayed in the Web View.
2917         (-[DOMHTMLInputElement insertTextSuggestion:]):
2918         Inserts login credentials into the Web View.
2919
2920 2017-09-25  Sam Weinig  <sam@webkit.org>
2921
2922         Remove unused EditorClient functions
2923         https://bugs.webkit.org/show_bug.cgi?id=177463
2924
2925         Reviewed by Alex Christensen.
2926
2927         Remove unused EditorClient functions.
2928
2929         * WebCoreSupport/WebEditorClient.h:
2930         * WebCoreSupport/WebEditorClient.mm:
2931         (WebEditorClient::canonicalizeURL): Deleted.
2932         (WebEditorClient::canonicalizeURLString): Deleted.
2933         (WebEditorClient::writeDataToPasteboard): Deleted.
2934         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2935         (WebEditorClient::readDataFromPasteboard): Deleted.
2936         (WebEditorClient::pasteboardChangeCount): Deleted.
2937
2938 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2939
2940         Stop using PolicyCallback
2941         https://bugs.webkit.org/show_bug.cgi?id=176088
2942
2943         Reviewed by Andy Estes.
2944
2945         * WebCoreSupport/WebFrameLoaderClient.mm:
2946         (-[WebFramePolicyListener invalidate]):
2947         (-[WebFramePolicyListener receivedPolicyDecision:]):
2948
2949 2017-09-25  Sam Weinig  <sam@webkit.org>
2950
2951         Remove unnecessary userVisibleString EditorClient function
2952         https://bugs.webkit.org/show_bug.cgi?id=177456
2953
2954         Reviewed by Dan Bernstein.
2955
2956         * WebCoreSupport/WebEditorClient.h:
2957         * WebCoreSupport/WebEditorClient.mm:
2958         (WebEditorClient::userVisibleString): Deleted.
2959
2960             Remove userVisibleString client function.
2961
2962 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2963
2964         Separate form submission from PolicyChecker infrastructure
2965         https://bugs.webkit.org/show_bug.cgi?id=177396
2966
2967         Reviewed by Geoffrey Garen.
2968
2969         * WebCoreSupport/WebFrameLoaderClient.h:
2970         * WebCoreSupport/WebFrameLoaderClient.mm:
2971         (WebFrameLoaderClient::dispatchWillSubmitForm):
2972
2973 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2974
2975         WeakPtrFactory should populate m_ref lazily.
2976         https://bugs.webkit.org/show_bug.cgi?id=177375
2977
2978         Reviewed by Geoffrey Garen.
2979
2980         * WebCoreSupport/WebEditorClient.mm:
2981         (WebEditorClient::WebEditorClient):
2982         (WebEditorClient::requestCandidatesForSelection):
2983
2984 2017-09-22  Chris Dumez  <cdumez@apple.com>
2985
2986         Use high resolution timestamp for event time
2987         https://bugs.webkit.org/show_bug.cgi?id=154246
2988         <rdar://problem/34333304>
2989
2990         Reviewed by Ryosuke Niwa.
2991
2992         Use WallTime / MonotonicTime instead of double type for clarity.
2993
2994         * DOM/DOMEvent.mm:
2995         (-[DOMEvent timeStamp]):
2996         * WebView/WebFrame.mm:
2997         (-[WebFrame _dragSourceEndedAt:operation:]):
2998         * WebView/WebPDFView.mm:
2999         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3000
3001 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3002
3003         Enable dataTransfer.items on macOS and iOS
3004         https://bugs.webkit.org/show_bug.cgi?id=177335
3005
3006         Reviewed by Sam Weinig.
3007
3008         * WebView/WebPreferences.mm:
3009         (+[WebPreferences initialize]):
3010
3011 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
3012
3013         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
3014         https://bugs.webkit.org/show_bug.cgi?id=177101
3015         <rdar://problem/34500648>
3016
3017         Reviewed by Brian Burg.
3018
3019         * WebInspector/WebNodeHighlight.mm:
3020         Ensure we close the window that we have just removed.
3021
3022 2017-09-20  Antti Koivisto  <antti@apple.com>
3023
3024         Remove DOM and styling support for CSS Regions
3025         https://bugs.webkit.org/show_bug.cgi?id=177221
3026
3027         Reviewed by Andreas Kling.
3028
3029         * Configurations/FeatureDefines.xcconfig:
3030         * DOM/DOMCSS.mm:
3031         (kitClass):
3032         * DOM/DOMElement.mm:
3033         (-[DOMElement webkitRegionOverset]): Deleted.
3034
3035 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
3036
3037         Layering violation in Editor::createFragment
3038         https://bugs.webkit.org/show_bug.cgi?id=176123
3039
3040         Reviewed by Darin Adler.
3041
3042         * Misc/WebNSURLExtras.h:
3043         * Misc/WebNSURLExtras.mm:
3044         * WebView/WebFrame.mm:
3045         * WebView/WebHTMLView.mm:
3046         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
3047
3048         * WebCoreSupport/WebEditorClient.mm:
3049         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
3050         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
3051         way to avoid exporting the symbol just on newer OSes.
3052
3053 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
3054
3055         On iOS, getData can't get text set by setData during copy event
3056         https://bugs.webkit.org/show_bug.cgi?id=176980
3057         <rdar://problem/34453915>
3058
3059         Reviewed by Darin Adler.
3060
3061         * WebCoreSupport/WebPlatformStrategies.h:
3062         * WebCoreSupport/WebPlatformStrategies.mm:
3063         (WebPlatformStrategies::copy): Deleted.
3064
3065 2017-09-18  Andy Estes  <aestes@apple.com>
3066
3067         [Mac] Upstream miscellaneous WebKitSystemInterface functions
3068         https://bugs.webkit.org/show_bug.cgi?id=177029
3069
3070         Reviewed by Alex Christensen.
3071
3072         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3073         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3074         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3075         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3076         * WebCoreSupport/PopupMenuMac.mm:
3077         (PopupMenuMac::show):
3078         * WebCoreSupport/WebSystemInterface.mm:
3079         (InitWebCoreSystemInterface):
3080         * WebView/WebHTMLView.mm:
3081         (-[WebHTMLView setDataSource:]):
3082         (-[WebHTMLView attachRootLayer:]):
3083         * WebView/WebView.mm:
3084         (-[WebView _needsAdobeFrameReloadingQuirk]):
3085         (-[WebView _needsLinkElementTextCSSQuirk]):
3086         (-[WebView _needsIsLoadingInAPISenseQuirk]):
3087         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
3088         (-[WebView _preferencesChanged:]):
3089
3090 2017-09-15  Andy Estes  <aestes@apple.com>
3091
3092         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
3093         https://bugs.webkit.org/show_bug.cgi?id=176953
3094
3095         Reviewed by Eric Carlson.
3096
3097         * WebCoreSupport/WebSystemInterface.mm:
3098         (InitWebCoreSystemInterface):
3099
3100 2017-09-14  Andy Estes  <aestes@apple.com>
3101
3102         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
3103         https://bugs.webkit.org/show_bug.cgi?id=176931
3104
3105         Reviewed by Joseph Pecoraro.
3106
3107         * WebCoreSupport/WebSystemInterface.mm:
3108         (InitWebCoreSystemInterface):
3109
3110 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3111
3112         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
3113         https://bugs.webkit.org/show_bug.cgi?id=176867
3114
3115         Reviewed by Sam Weinig.
3116
3117         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3118         (WebKit::NetscapePluginInstanceProxy::enumerate):
3119
3120 2017-09-13  Andy Estes  <aestes@apple.com>
3121
3122         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
3123         https://bugs.webkit.org/show_bug.cgi?id=176729
3124
3125         Reviewed by Alex Christensen.
3126
3127         * WebCoreSupport/WebSystemInterface.mm:
3128         (InitWebCoreSystemInterface):
3129         * WebView/WebView.mm:
3130         (+[WebView _setCacheModel:]):
3131
3132 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3133
3134         Refactor WebContentReader out of EditorMac and EditorIOS
3135         https://bugs.webkit.org/show_bug.cgi?id=176770
3136
3137         Reviewed by Sam Weinig.
3138
3139         * WebCoreSupport/WebEditorClient.mm:
3140
3141 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3142
3143         Dragging & dropping a file creates an attachment element even when it's disabled
3144         https://bugs.webkit.org/show_bug.cgi?id=176769
3145
3146         Reviewed by Tim Horton.
3147
3148         * WebView/WebView.mm:
3149         (-[WebView _preferencesChanged:]):
3150
3151 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3152
3153         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3154         https://bugs.webkit.org/show_bug.cgi?id=176721
3155         <rdar://problem/34373660>
3156
3157         Reviewed by Tim Horton.
3158
3159         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3160         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3161
3162         * WebView/WebView.mm:
3163         (-[WebView _startDrag:]):
3164         (-[WebView _draggedElementBounds]):
3165         (-[WebView _endedDataInteraction:global:]):
3166         * WebView/WebViewData.h:
3167
3168 2017-09-11  Andy Estes  <aestes@apple.com>
3169
3170         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3171         https://bugs.webkit.org/show_bug.cgi?id=176472
3172
3173         Reviewed by Eric Carlson.
3174
3175         * WebCoreSupport/WebSystemInterface.mm:
3176         (InitWebCoreSystemInterface):
3177
3178 2017-09-09  Mark Lam  <mark.lam@apple.com>
3179
3180         Avoid duplicate computations of ExecState::vm().
3181         https://bugs.webkit.org/show_bug.cgi?id=176647
3182
3183         Reviewed by Saam Barati.
3184
3185         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3186         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3187         (WebKit::NetscapePluginInstanceProxy::construct):
3188         (WebKit::NetscapePluginInstanceProxy::setProperty):
3189         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3190         (WebKit::NetscapePluginInstanceProxy::enumerate):
3191         * Plugins/Hosted/ProxyInstance.mm:
3192         (WebKit::ProxyRuntimeMethod::create):
3193
3194 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3195
3196         Unreviewed, rolling out r221773.
3197         https://bugs.webkit.org/show_bug.cgi?id=176614
3198
3199         This caused build failures. (Requested by mlewis13 on
3200         #webkit).
3201
3202         Reverted changeset:
3203
3204         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3205         https://bugs.webkit.org/show_bug.cgi?id=176472
3206         http://trac.webkit.org/changeset/221773
3207
3208 2017-09-07  Andy Estes  <aestes@apple.com>
3209
3210         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3211         https://bugs.webkit.org/show_bug.cgi?id=176472
3212
3213         Reviewed by Eric Carlson.
3214
3215         * WebCoreSupport/WebSystemInterface.mm:
3216         (InitWebCoreSystemInterface):
3217
3218 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3219
3220         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3221         https://bugs.webkit.org/show_bug.cgi?id=176561
3222
3223         Reviewed by Brent Fulgham.
3224
3225         * Misc/WebNSUserDefaultsExtras.mm:
3226
3227 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3228
3229         Modernize Geolocation code
3230         https://bugs.webkit.org/show_bug.cgi?id=176496
3231
3232         Reviewed by Andy Estes.
3233
3234         * WebCoreSupport/WebGeolocationClient.h:
3235         * WebCoreSupport/WebGeolocationClient.mm:
3236         (WebGeolocationClient::requestPermission):
3237         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3238         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3239         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3240         * WebView/WebView.mm:
3241         (-[WebView _commonInitializationWithFrameName:groupName:]):
3242         (-[WebView _geolocationDidFailWithMessage:]):
3243
3244 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3245
3246         Remove some unused bits of code and resources
3247         https://bugs.webkit.org/show_bug.cgi?id=176275
3248
3249         Reviewed by Dan Bernstein.
3250
3251         * Misc/WebNSFileManagerExtras.mm:
3252         Include FileSystem instead of FileSystemIOS.
3253
3254 2017-09-03  Darin Adler  <darin@apple.com>
3255
3256         [Cocoa] Tidy a few things in legacy WebHTMLView
3257         https://bugs.webkit.org/show_bug.cgi?id=176280
3258
3259         Reviewed by Dan Bernstein.
3260
3261         * WebCoreSupport/WebChromeClient.mm:
3262         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3263         methods it calls on WebHTMLView were doing nothing on iOS.
3264
3265         * WebView/WebFrame.mm:
3266         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3267         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3268
3269         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3270         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3271         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3272         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3273         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3274         Use RetainPtr instead of writing retain/release wherever possible.
3275         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3276         initialization for it. Removed various unused methods and declarations of methods.
3277         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3278         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3279         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3280         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3281         and remove CFRetain no longer needed since we don't support garbage collection any more.
3282         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3283         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3284         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3285         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3286         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3287         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3288         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3289         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3290         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3291         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3292         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3293         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3294         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3295         debug flag; we haven't used it for years and it's not clearly helpful.
3296         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3297         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3298         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3299         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3300         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3301         two additional methods in the WebPrivate category and still be called by the two
3302         methods in the WebInternal category that were already using it.
3303         (-[WebHTMLView didAddSubview:]): Deleted.
3304         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3305         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3306         place this was called, the close method.
3307         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3308         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3309         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3310         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3311         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3312         Added helper method to make the one below simpler.
3313         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3314         Compared pasteboard type strings using isEqualToString: rather than using == since
3315         we want to actually compare the string contents. Also updated to use modern for loop,
3316         renamed a local variable from "s" to "localSubresources", and factored out the handling
3317         of three image types to use the helper method above.
3318         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3319         _web_makePluginSubviewsPerformSelector:withObject: method.
3320         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3321         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3322         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3323         not call the -[NSView subviews] method to make this identical on both platforms and used
3324         a modern for loop.
3325         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3326         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3327         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3328         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3329         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3330         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3331         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3332         of it is Mac-only.
3333         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3334         method did was call itself on the main thread, and do nothing if called on main thread.
3335         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3336         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3337         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3338         half of this method.
3339         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3340         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3341         Simplified using a modern for loop and RetainPtr.
3342         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3343         (-[WebHTMLView keyDown:]): Ditto.
3344         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3345         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3346         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3347         (-[WebHTMLView complete:]): Ditto.
3348         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3349         now macOS-only.
3350         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3351         iOS since that is now macOS-only.
3352         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3353         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3354         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3355         and reorganized to use early return.
3356         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3357         on iOS, but kept there so we don't have to do #if at every call site.
3358         (-[WebHTMLView _pluginController]): Moved into internal category.
3359         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3360         there only for GC, using C++ initialization, removing obsolete comment.
3361         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3362         peculiar iOS-only comment.
3363         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3364
3365         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3366         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3367         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3368         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3369         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3370
3371         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3372         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3373         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3374         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3375         them at this time.
3376
3377 2017-09-03  Sam Weinig  <sam@webkit.org>
3378
3379         Remove CanvasProxy
3380         https://bugs.webkit.org/show_bug.cgi?id=176288
3381
3382         Reviewed by Yusuke Suzuki.
3383
3384         CanvasProxy does not appear to be in any current HTML spec
3385         and was disabled and unimplemented in our tree. Time to 
3386         get rid of it.
3387
3388         * Configurations/FeatureDefines.xcconfig:
3389
3390 2017-09-02  Andy Estes  <aestes@apple.com>
3391
3392         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3393         https://bugs.webkit.org/show_bug.cgi?id=176270
3394
3395         Reviewed by Tim Horton.
3396
3397         * Plugins/Hosted/NetscapePluginHostManager.mm:
3398         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3399         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3400         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3401         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3402         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3403         (WebKit::SoftwareCARenderer::context const):
3404         (WebKit::SoftwareCARenderer::renderContext const):
3405         (WebKit::SoftwareCARenderer::render):
3406         (-[WebHostedNetscapePluginView createPlugin]):
3407         (-[WebHostedNetscapePluginView createPluginLayer]):
3408         (-[WebHostedNetscapePluginView destroyPlugin]):
3409         (-[WebHostedNetscapePluginView drawRect:]):
3410         * WebCoreSupport/WebSystemInterface.mm:
3411         (InitWebCoreSystemInterface):
3412
3413 2017-09-01  Andy Estes  <aestes@apple.com>
3414
3415         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3416         https://bugs.webkit.org/show_bug.cgi?id=176200
3417
3418         Reviewed by Tim Horton.
3419
3420         * Carbon/HIWebView.mm:
3421         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3422         (overrideCGContext):
3423         (restoreCGContext):
3424         (Draw):
3425         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3426         (+[WebHostedNetscapePluginView initialize]):
3427         * Plugins/WebBaseNetscapePluginView.h:
3428         * Plugins/WebBaseNetscapePluginView.mm:
3429         (WebKit::sendUserChangeNotifications):
3430         * Plugins/WebNetscapePluginView.mm:
3431         (+[WebNetscapePluginView initialize]):
3432         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3433         * WebCoreSupport/WebSystemInterface.mm:
3434         (InitWebCoreSystemInterface):
3435         * WebView/WebFrame.mm:
3436         (-[WebFrame _paintBehaviorForDestinationContext:]):
3437         * WebView/WebFullScreenController.mm:
3438         (setClipRectForWindow):
3439         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3440         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3441         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3442         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3443
3444 2017-08-31  Andy Estes  <aestes@apple.com>
3445
3446         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3447         https://bugs.webkit.org/show_bug.cgi?id=176175
3448
3449         Reviewed by Brady Eidson.
3450
3451         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3452         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3453         * Plugins/Hosted/WebTextInputWindowController.m:
3454         (-[WebTextInputPanel init]):
3455         * WebCoreSupport/WebSystemInterface.mm:
3456         (InitWebCoreSystemInterface):
3457         * WebView/WebDynamicScrollBarsView.mm:
3458         (-[WebDynamicScrollBarsView scrollWheel:]):
3459         * WebView/WebHTMLView.mm:
3460         (-[WebHTMLView _removeWindowObservers]):
3461         (-[WebHTMLView addWindowObservers]):
3462         * WebView/WebView.mm:
3463         (-[WebView addWindowObserversForWindow:]):
3464         (-[WebView removeWindowObservers]):
3465         (-[WebView viewWillMoveToWindow:]):
3466
3467 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3468
3469         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3470         https://bugs.webkit.org/show_bug.cgi?id=175779
3471         <rdar://problem/22367975>
3472
3473         Reviewed by Tim Horton.
3474
3475         * WebCoreSupport/WebFrameLoaderClient.h:
3476         * WebCoreSupport/WebFrameLoaderClient.mm:
3477         (WebFrameLoaderClient::webGLPolicyForURL const):
3478         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3479
3480 2017-08-30  Andy Estes  <aestes@apple.com>
3481
3482         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3483         https://bugs.webkit.org/show_bug.cgi?id=176093
3484
3485         Reviewed by Eric Carlson.
3486
3487         * WebCoreSupport/WebSystemInterface.mm:
3488         (InitWebCoreSystemInterface):
3489
3490 2017-08-30  Andy Estes  <aestes@apple.com>
3491
3492         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3493         https://bugs.webkit.org/show_bug.cgi?id=176087
3494
3495         Reviewed by Alex Christensen.
3496
3497         * Carbon/CarbonUtils.m:
3498         (getNSAutoreleasePoolCount):
3499         (WebInitForCarbon):
3500         (PoolCleaner):
3501         * Carbon/CarbonWindowAdapter.mm:
3502         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3503         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3504         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3505         (-[CarbonWindowAdapter _windowMovedToRect:]):
3506         * Carbon/HIViewAdapter.m:
3507         * Carbon/HIWebView.mm:
3508         (Draw):
3509         (CreateNSEventAdoptingCGEvent):
3510         (CopyEventCGEvent):
3511         (CreateNSEventWithCarbonClickEvent):
3512         (Click):
3513         (CreateNSEventWithCarbonEvent):
3514         (MouseUp):
3515         (CreateNSEventWithCarbonMouseMoveEvent):
3516         (MouseMoved):
3517         (MouseDragged):
3518         (MouseWheelMoved):
3519         (WindowHandler):
3520         (HIWebViewEventHandler):
3521         * Misc/QuickDrawCompatibility.h: Removed.
3522         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3523         (getCarbonEvent):
3524         (WebNetscapePluginEventHandlerCarbon::keyDown):
3525         (WebNetscapePluginEventHandlerCarbon::keyUp):
3526         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3527         (WebNetscapePluginEventHandlerCocoa::keyDown):
3528         * Plugins/WebNetscapePluginView.mm:
3529         (-[WebNetscapePluginView tellQuickTimeToChill]):
3530
3531 2017-08-29  Andy Estes  <aestes@apple.com>
3532
3533         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3534         https://bugs.webkit.org/show_bug.cgi?id=176046
3535
3536         Reviewed by Alex Christensen.
3537
3538         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3539         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3540
3541         * Misc/WebNSFileManagerExtras.mm:
3542         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3543         (setMetaData): Deleted.
3544         * WebCoreSupport/WebSystemInterface.mm:
3545         (InitWebCoreSystemInterface):
3546
3547 2017-08-28  Andy Estes  <aestes@apple.com>
3548
3549         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3550         https://bugs.webkit.org/show_bug.cgi?id=176039
3551
3552         Reviewed by Alex Christensen.
3553
3554         * WebCoreSupport/WebSystemInterface.mm:
3555         (InitWebCoreSystemInterface):
3556         * WebView/WebPreferences.mm:
3557         (+[WebPreferences _systemCFStringEncoding]):
3558
3559 2017-08-28  Andy Estes  <aestes@apple.com>
3560
3561         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3562         https://bugs.webkit.org/show_bug.cgi?id=176032
3563
3564         Reviewed by Alex Christensen.
3565
3566         * WebCoreSupport/WebSystemInterface.mm:
3567         (InitWebCoreSystemInterface):
3568         * WebView/WebView.mm:
3569         (-[WebView _cachedResponseForURL:]):
3570
3571 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3572
3573         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3574         https://bugs.webkit.org/show_bug.cgi?id=175992
3575         <rdar://problem/34086613>
3576
3577         Reviewed by Daniel Bates.
3578
3579         * WebCoreSupport/WebPlatformStrategies.h:
3580         * WebCoreSupport/WebPlatformStrategies.mm:
3581         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3582         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3583         indicating if secure cookies were accessed.
3584
3585 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3586
3587         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3588         https://bugs.webkit.org/show_bug.cgi?id=170955
3589         <rdar://problem/31697653>
3590
3591         Reviewed by Ryosuke Niwa.
3592
3593         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3594         text is being replaced.
3595
3596         * WebView/WebHTMLView.mm:
3597         (-[WebHTMLView insertText:]):
3598
3599 2017-08-24  Chris Dumez  <cdumez@apple.com>
3600
3601         [Directory Upload] Add basic support for input.webkitdirectory
3602         https://bugs.webkit.org/show_bug.cgi?id=175950
3603         <rdar://problem/33951915>
3604
3605         Reviewed by Geoffrey Garen.
3606
3607         Add private API to toggle Directory Upload support on Mac WebKit1.
3608
3609         * WebView/WebPreferenceKeysPrivate.h:
3610         * WebView/WebPreferences.mm:
3611         (+[WebPreferences initialize]):
3612         (-[WebPreferences setDirectoryUploadEnabled:]):
3613         (-[WebPreferences directoryUploadEnabled]):
3614         * WebView/WebPreferencesPrivate.h:
3615         * WebView/WebView.mm:
3616         (-[WebView _preferencesChanged:]):
3617
3618 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3619
3620         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3621         https://bugs.webkit.org/show_bug.cgi?id=175370
3622         <rdar://problem/33799806>
3623
3624         Reviewed by Ryosuke Niwa.
3625
3626         Adjust WebEditorClient for interface changes.
3627
3628         * WebCoreSupport/WebEditorClient.h:
3629
3630 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3631
3632         Remove ChromeClient::scrollbarsModeDidChange
3633         https://bugs.webkit.org/show_bug.cgi?id=175805
3634
3635         Reviewed by Daniel Bates.
3636
3637         * WebCoreSupport/WebChromeClient.h:
3638
3639 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3640
3641         Remove ChromeClient::hasOpenedPopup
3642         https://bugs.webkit.org/show_bug.cgi?id=175804
3643
3644         Reviewed by Sam Weinig.
3645
3646         * WebCoreSupport/WebChromeClient.h:
3647         * WebCoreSupport/WebChromeClient.mm:
3648         (WebChromeClient::hasOpenedPopup const): Deleted.
3649
3650 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3651
3652         Disable access to secure cookies if an HTTPS site loads mixed content
3653         https://bugs.webkit.org/show_bug.cgi?id=157053
3654         <rdar://problem/11290808>
3655
3656         Reviewed by Dan Bates.
3657
3658         * WebCoreSupport/WebPlatformStrategies.h:
3659         * WebCoreSupport/WebPlatformStrategies.mm:
3660         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3661         indicating whether secure cookies should be included in the response.
3662
3663 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3664
3665         [PAL] Move spi/mac directory into PAL
3666         https://bugs.webkit.org/show_bug.cgi?id=175649
3667
3668         Reviewed by Myles C. Maxfield.
3669
3670         * Misc/WebSharingServicePickerController.h:
3671         * WebCoreSupport/WebContextMenuClient.mm:
3672         * WebCoreSupport/WebEditorClient.mm:
3673         * WebCoreSupport/WebSelectionServiceController.mm:
3674         * WebView/WebHTMLView.mm:
3675         * WebView/WebImmediateActionController.h:
3676         * WebView/WebImmediateActionController.mm:
3677         * WebView/WebView.mm:
3678
3679 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3680
3681         [PAL] Relocate SessionID to root
3682         https://bugs.webkit.org/show_bug.cgi?id=175684
3683
3684         Reviewed by Alex Christensen.
3685
3686         * WebCoreSupport/WebFrameNetworkingContext.mm:
3687
3688 2017-08-17  Andreas Kling  <akling@apple.com>
3689
3690         Disable CSS regions at compile time
3691         https://bugs.webkit.org/show_bug.cgi?id=175630
3692
3693         Reviewed by Antti Koivisto.
3694
3695         * Configurations/FeatureDefines.xcconfig:
3696
3697 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3698
3699         [PAL] Move SessionID into PAL
3700         https://bugs.webkit.org/show_bug.cgi?id=174192
3701
3702         Reviewed by Antti Koivisto.
3703
3704         * Misc/WebCache.mm:
3705         (+[WebCache imageForURL:]):
3706         * WebCoreSupport/WebFrameLoaderClient.h:
3707         * WebCoreSupport/WebFrameLoaderClient.mm:
3708         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3709         * WebCoreSupport/WebFrameNetworkingContext.mm:
3710         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3711         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3712         (WebFrameNetworkingContext::storageSession const):
3713         * WebCoreSupport/WebPlatformStrategies.h:
3714         * WebCoreSupport/WebPlatformStrategies.mm:
3715         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3716         * WebKitPrefix.h:
3717
3718 2017-08-16  Andy Estes  <aestes@apple.com>
3719
3720         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3721         https://bugs.webkit.org/show_bug.cgi?id=175648
3722
3723         Reviewed by Tim Horton.
3724
3725         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3726         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3727         (WebPaymentCoordinatorClient::showPaymentUI):
3728
3729 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3730
3731         [PAL] Move spi/ios and spi/win directories into PAL
3732         https://bugs.webkit.org/show_bug.cgi?id=175171
3733
3734         Reviewed by Antti Koivisto.
3735
3736         * WebCoreSupport/WebFrameLoaderClient.mm:
3737         * WebView/WebView.mm:
3738
3739 2017-08-16  Andy Estes  <aestes@apple.com>
3740
3741         [Payment Request] Add an ENABLE flag and an experimental feature preference
3742         https://bugs.webkit.org/show_bug.cgi?id=175622
3743
3744         Reviewed by Tim Horton.
3745
3746         * Configurations/FeatureDefines.xcconfig:
3747
3748 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3749
3750         [PAL] Move Sleep classes into PAL
3751         https://bugs.webkit.org/show_bug.cgi?id=175456
3752
3753         Reviewed by Ryosuke Niwa.
3754
3755         * WebView/WebFullScreenController.h:
3756
3757 2017-08-15  Youenn Fablet  <youenn@apple.com>
3758
3759         [Cache API] Adding generic support for CacheStorage and Cache methods
3760         https://bugs.webkit.org/show_bug.cgi?id=175455
3761
3762         Reviewed by Chris Dumez.
3763
3764         * WebView/WebView.mm:
3765         (-[WebView _commonInitializationWithFrameName:groupName:]):
3766
3767 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3768
3769         Remove Proximity Events and related code
3770         https://bugs.webkit.org/show_bug.cgi?id=175545
3771
3772         Reviewed by Daniel Bates.
3773
3774         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3775         and other related code.
3776
3777         * Configurations/FeatureDefines.xcconfig:
3778
3779 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3780
3781         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3782         https://bugs.webkit.org/show_bug.cgi?id=175504
3783
3784         Reviewed by Sam Weinig.
3785
3786         * Configurations/FeatureDefines.xcconfig:
3787         * DOM/DOMHTMLFormElement.mm:
3788         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3789         * WebCoreSupport/WebFrameLoaderClient.h:
3790
3791 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3792
3793         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3794         https://bugs.webkit.org/show_bug.cgi?id=175557
3795
3796         Reviewed by Jon Lee.
3797
3798         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3799
3800         * Configurations/FeatureDefines.xcconfig:
3801
3802 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3803
3804         Composition underline color is always black
3805         https://bugs.webkit.org/show_bug.cgi?id=174675
3806
3807         Reviewed by Ryosuke Niwa.
3808
3809         * WebView/WebHTMLView.mm:
3810         (extractUnderlines): If NSUnderlineColorAttributeName
3811         is not present use text color for composition underline.
3812         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3813         for composition underline in the plain text case.
3814
3815 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3816
3817         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3818         https://bugs.webkit.org/show_bug.cgi?id=175474
3819         <rdar://problem/33844628>
3820
3821         Reviewed by Wenson Hsieh.
3822
3823         Replaced the build flag by a runtime flag and disabled the feature by default.
3824
3825         * Configurations/FeatureDefines.xcconfig:
3826         * WebView/WebPreferenceKeysPrivate.h:
3827         * WebView/WebPreferences.mm:
3828         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3829         (-[WebPreferences dataTransferItemsEnabled]): Added.
3830         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3831         * WebView/WebPreferencesPrivate.h:
3832         * WebView/WebView.mm:
3833         (-[WebView _preferencesChanged:]):
3834
3835 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3836
3837         Remove ENABLE_GAMEPAD_DEPRECATED
3838         https://bugs.webkit.org/show_bug.cgi?id=175361
3839
3840         Reviewed by Carlos Garcia Campos.
3841
3842         * Configurations/FeatureDefines.xcconfig:
3843
3844 2017-08-09  Chris Dumez  <cdumez@apple.com>
3845
3846         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3847         https://bugs.webkit.org/show_bug.cgi?id=175401
3848
3849         Reviewed by Brady Eidson.
3850
3851         * WebView/WebPreferenceKeysPrivate.h:
3852         * WebView/WebPreferences.mm:
3853         (+[WebPreferences initialize]):
3854         (-[WebPreferences beaconAPIEnabled]): Deleted.
3855         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3856         * WebView/WebPreferencesPrivate.h:
3857         * WebView/WebView.mm:
3858         (-[WebView _preferencesChanged:]):
3859
3860 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3861
3862         [PAL] Move spi/cocoa and spi/cg directories into PAL
3863         https://bugs.webkit.org/show_bug.cgi?id=175175
3864
3865         Reviewed by Myles C. Maxfield.
3866
3867         * History/WebHistory.mm:
3868         * Misc/WebDownload.mm:
3869         * Misc/WebKitNSStringExtras.mm:
3870         * Plugins/Hosted/NetscapePluginHostManager.mm:
3871         * Plugins/WebPluginDatabase.mm:
3872         * WebCoreSupport/WebFrameLoaderClient.mm:
3873         * WebInspector/WebNodeHighlight.mm:
3874         * WebView/WebHTMLView.mm:
3875         * WebView/WebIndicateLayer.mm:
3876         * WebView/WebView.mm:
3877         * WebView/WebViewData.h:
3878
3879 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3880
3881         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3882         https://bugs.webkit.org/show_bug.cgi?id=175392
3883         <rdar://problem/33783207>
3884
3885         Reviewed by Tim Horton and Megan Gardner.
3886
3887         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3888
3889         * Configurations/FeatureDefines.xcconfig:
3890
3891 2017-08-09  Daniel Bates  <dabates@apple.com>
3892
3893         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3894         https://bugs.webkit.org/show_bug.cgi?id=175247
3895         <rdar://problem/33679804>
3896
3897         Reviewed by Brady Eidson.
3898
3899         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3900         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3901         clients that need to make use of this information at this time. If such a needs comes up
3902         then we can expose API/SPI similar to what we do for WebKit.
3903
3904         * WebCoreSupport/WebFrameLoaderClient.h:
3905         * WebCoreSupport/WebFrameLoaderClient.mm:
3906         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3907
3908 2017-08-08  Brady Eidson  <beidson@apple.com>
3909
3910         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3911         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3912
3913         Reviewed by Andy Estes.
3914
3915         * Misc/WebKitVersionChecks.h:
3916         * WebCoreSupport/WebFrameLoaderClient.mm:
3917         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3918           the app is linked against new WebKit with the new behavior.
3919
3920 2017-08-07  Devin Rousso  <drousso@apple.com>
3921
3922         Web Inspector: Preview Canvas path when viewing a recording
3923         https://bugs.webkit.org/show_bug.cgi?id=174967
3924
3925         Reviewed by Brian Burg.
3926
3927         * WebView/WebPreferenceKeysPrivate.h:
3928         * WebView/WebPreferences.mm:
3929         (+[WebPreferences initialize]):
3930         (-[WebPreferences inspectorAdditionsEnabled]):
3931         (-[WebPreferences setInspectorAdditionsEnabled:]):
3932         * WebView/WebPreferencesPrivate.h:
3933         * WebView/WebView.mm:
3934         (-[WebView _preferencesChanged:]):
3935         Add plumbing for new InspectorAdditions runtime flag.
3936
3937 2017-08-07  Brian Burg  <bburg@apple.com>
3938
3939         Remove CANVAS_PATH compilation guard
3940         https://bugs.webkit.org/show_bug.cgi?id=175207
3941
3942         Reviewed by Sam Weinig.
3943
3944         * Configurations/FeatureDefines.xcconfig:
3945
3946 2017-08-04  Youenn Fablet  <youenn@apple.com>
3947
3948         [Cache API] Add Cache and CacheStorage IDL definitions
3949         https://bugs.webkit.org/show_bug.cgi?id=175201
3950
3951         Reviewed by Brady Eidson.
3952
3953         * WebView/WebPreferenceKeysPrivate.h:
3954         * WebView/WebPreferences.mm:
3955         (+[WebPreferences initialize]):
3956         (-[WebPreferences cacheAPIEnabled]):
3957         (-[WebPreferences setCacheAPIEnabled:]):
3958         * WebView/WebPreferencesPrivate.h:
3959         * WebView/WebView.mm:
3960         (-[WebView _preferencesChanged:]):
3961
3962 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3963
3964         Unreviewed, rolling out r220271.
3965
3966         Rolling out due to Layout Test failing on iOS Simulator.
3967
3968         Reverted changeset:
3969
3970         "Remove STREAMS_API compilation guard"
3971         https://bugs.webkit.org/show_bug.cgi?id=175165
3972         http://trac.webkit.org/changeset/220271
3973
3974 2017-08-04  Youenn Fablet  <youenn@apple.com>
3975
3976         Remove STREAMS_API compilation guard
3977         https://bugs.webkit.org/show_bug.cgi?id=175165
3978
3979         Reviewed by Darin Adler.
3980
3981         * Configurations/FeatureDefines.xcconfig:
3982         * WebView/WebPreferences.mm:
3983         (+[WebPreferences initialize]):
3984         * WebView/WebView.mm:
3985         (-[WebView _preferencesChanged:]):
3986
3987 2017-08-03  Brian Burg  <bburg@apple.com>
3988
3989         Remove ENABLE(WEB_SOCKET) guards
3990         https://bugs.webkit.org/show_bug.cgi?id=167044
3991
3992         Reviewed by Joseph Pecoraro.
3993
3994         * Configurations/FeatureDefines.xcconfig:
3995         * WebView/WebPreferencesPrivate.h:
3996
3997 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3998
3999         [PAL] Move spi/cf directory into PAL
4000         https://bugs.webkit.org/show_bug.cgi?id=175057
4001
4002         Reviewed by Antti Koivisto.
4003
4004         * Plugins/Hosted/HostedNetscapePluginStream.mm:
4005         * Plugins/WebNetscapePluginStream.mm:
4006         * WebCoreSupport/WebFrameNetworkingContext.mm:
4007         * WebView/WebPreferences.mm:
4008         * WebView/WebView.mm:
4009
4010 2017-08-03  Youenn Fablet  <youenn@apple.com>
4011
4012         Remove FETCH_API compilation guard
4013         https://bugs.webkit.org/show_bug.cgi?id=175154
4014
4015         Reviewed by Chris Dumez.
4016
4017         * Configurations/FeatureDefines.xcconfig:
4018         * WebView/WebPreferences.mm:
4019         (+[WebPreferences initialize]):
4020         * WebView/WebView.mm:
4021         (-[WebView _preferencesChanged:]):
4022
4023 2017-08-03  Brady Eidson  <beidson@apple.com>
4024
4025         Add SW IDLs and stub out basic functionality.
4026         https://bugs.webkit.org/show_bug.cgi?id=175115
4027
4028         Reviewed by Chris Dumez.
4029
4030         * Configurations/FeatureDefines.xcconfig:
4031
4032 2017-08-02  Sam Weinig  <sam@webkit.org>
4033
4034         [WebIDL] Convert MutationCallback to be a normal generated callback
4035         https://bugs.webkit.org/show_bug.cgi?id=174140
4036
4037         Reviewed by Darin Adler.
4038
4039         * DOM/DOMDocument.mm:
4040         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
4041         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
4042         Pass, now necessary, Document to NativeNodeFilter constructor.
4043
4044 2017-08-01  Chris Dumez  <cdumez@apple.com>
4045
4046         Add initial support for navigator.sendBeacon
4047         https://bugs.webkit.org/show_bug.cgi?id=175007
4048         <rdar://problem/33547728>
4049
4050         Reviewed by Sam Weinig.
4051
4052         Add setting to toggle support for the Beacon API (it is disabled by default).
4053
4054         * WebView/WebPreferenceKeysPrivate.h:
4055         * WebView/WebPreferences.mm:
4056         (+[WebPreferences initialize]):
4057         (-[WebPreferences beaconAPIEnabled]):
4058         (-[WebPreferences setBeaconAPIEnabled:]):
4059         * WebView/WebPreferencesPrivate.h:
4060         * WebView/WebView.mm:
4061         (-[WebView _preferencesChanged:]):
4062
4063 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
4064
4065         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
4066         https://bugs.webkit.org/show_bug.cgi?id=174437
4067
4068         Reviewed by Darin Adler.
4069
4070         Remove redundant Web- prefix from classes in WebKit namespace.
4071
4072         * WebView/WebView.mm:
4073         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
4074         * WebView/WebViewData.h:
4075         * WebView/WebViewData.mm:
4076
4077 2017-07-26  Brian Burg  <bburg@apple.com>
4078
4079         Remove WEB_TIMING feature flag
4080         https://bugs.webkit.org/show_bug.cgi?id=174795
4081
4082         Reviewed by Alex Christensen.
4083
4084         * Configurations/FeatureDefines.xcconfig:
4085