[Web GPU] Fix Web GPU experimental feature on iOS
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-04-08  Justin Fan  <justin_fan@apple.com>
2
3         [Web GPU] Fix Web GPU experimental feature on iOS
4         https://bugs.webkit.org/show_bug.cgi?id=196632
5
6         Reviewed by Myles C. Maxfield.
7
8         Add feature conditionals for iOS 11.
9         Properly make Web GPU available on iOS 11+.
10
11         * Configurations/FeatureDefines.xcconfig:
12         * Configurations/WebKitTargetConditionals.xcconfig:
13
14 2019-04-05  Alex Christensen  <achristensen@webkit.org>
15
16         REGRESSION(AppleWebKit/605.1.15): WebDownloadDelegate delegate methods called on non-main thread
17         https://bugs.webkit.org/show_bug.cgi?id=190918
18         <rdar://problem/45603890>
19
20         Reviewed by Darin Adler.
21
22         Since we not doing networking on the main thread but WebView is to be used on the main thread,
23         we need to hop delegate calls to the main thread similarly to how we do it in the non-download
24         delegate calls in WebCoreResourceHandleAsOperationQueueDelegate.
25
26         * Misc/WebDownload.mm:
27         (-[WebDownloadInternal downloadDidBegin:]):
28         (-[WebDownloadInternal download:willSendRequest:redirectResponse:]):
29         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
30         (-[WebDownloadInternal download:didReceiveResponse:]):
31         (-[WebDownloadInternal download:didReceiveDataOfLength:]):
32         (-[WebDownloadInternal download:shouldDecodeSourceDataOfMIMEType:]):
33         (-[WebDownloadInternal download:decideDestinationWithSuggestedFilename:]):
34         (-[WebDownloadInternal download:didCreateDestination:]):
35         (-[WebDownloadInternal downloadDidFinish:]):
36         (-[WebDownloadInternal download:didFailWithError:]):
37
38 2019-04-05  Eric Carlson  <eric.carlson@apple.com>
39
40         Remove AUDIO_TOOLBOX_AUDIO_SESSION
41         https://bugs.webkit.org/show_bug.cgi?id=196653
42         <rdar://problem/49652098>
43
44         Reviewed by Jer Noble.
45
46         * WebView/WebPreferences.mm:
47         (-[WebPreferences setAudioSessionCategoryOverride:]):
48
49 2019-04-05  Eric Carlson  <eric.carlson@apple.com>
50
51         Stop including <AudioToolbox/AudioSession.h>
52         https://bugs.webkit.org/show_bug.cgi?id=196648
53         <rdar://problem/39665771>
54
55         Reviewed by Jer Noble.
56
57         * WebView/WebPreferencesPrivate.h:
58
59 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
60
61         Have ScrollableArea store a ScrollType for the current scroll
62         https://bugs.webkit.org/show_bug.cgi?id=196627
63
64         Reviewed by Zalan Bujtas.
65
66         Send the programmatic scroll type.
67
68         * DOM/DOMHTML.mm:
69         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
70
71 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
72
73         -apple-trailing-word is needed for browser detection
74         https://bugs.webkit.org/show_bug.cgi?id=196575
75
76         Unreviewed.
77
78         * Configurations/FeatureDefines.xcconfig:
79
80 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
81
82         Remove support for -apple-trailing-word
83         https://bugs.webkit.org/show_bug.cgi?id=196525
84
85         Reviewed by Zalan Bujtas.
86
87         This CSS property is nonstandard and not used.
88
89         * Configurations/FeatureDefines.xcconfig:
90
91 2019-04-01  Alex Christensen  <achristensen@webkit.org>
92
93         Add SPI to canonicalize NSURLs with WTF::URL
94         https://bugs.webkit.org/show_bug.cgi?id=196415
95         <rdar://problem/44980271>
96
97         Reviewed by Darin Adler.
98
99         * Misc/WebNSURLExtras.h:
100         * Misc/WebNSURLExtras.mm:
101         (-[NSURL _webkit_canonicalize_with_wtf]):
102         _webkit_canonicalize is old and changing it causes strange bugs like rdar://problem/5315926
103         Instead, make a new version that uses WTF::URL to canonicalize an NSURL.
104
105 2019-03-31  Sam Weinig  <weinig@apple.com>
106
107         Remove more i386 specific configurations
108         https://bugs.webkit.org/show_bug.cgi?id=196430
109
110         Reviewed by Alexey Proskuryakov.
111
112         * Configurations/FeatureDefines.xcconfig:
113         ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
114
115 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
116
117         Delete WebMetal implementation in favor of WebGPU
118         https://bugs.webkit.org/show_bug.cgi?id=195418
119
120         Reviewed by Dean Jackson.
121
122         * Configurations/FeatureDefines.xcconfig:
123         * WebView/WebPreferenceKeysPrivate.h:
124         * WebView/WebPreferences.mm:
125         (+[WebPreferences initialize]):
126         (-[WebPreferences webMetalEnabled]): Deleted.
127         (-[WebPreferences setWebMetalEnabled:]): Deleted.
128         * WebView/WebPreferencesPrivate.h:
129         * WebView/WebView.mm:
130         (-[WebView _preferencesChanged:]):
131
132 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
133
134         Implement ResizeObserver.
135         https://bugs.webkit.org/show_bug.cgi?id=157743
136
137         Reviewed by Simon Fraser.
138
139         * Configurations/FeatureDefines.xcconfig:
140         * WebView/WebPreferenceKeysPrivate.h:
141         * WebView/WebPreferences.mm:
142         (+[WebPreferences initialize]):
143         (-[WebPreferences resizeObserverEnabled]):
144         (-[WebPreferences setResizeObserverEnabled:]):
145         * WebView/WebPreferencesPrivate.h:
146         * WebView/WebView.mm:
147         (-[WebView _preferencesChanged:]):
148         (-[WebView _flushCompositingChanges]): checkResizeObservations() in the begining.
149
150 2019-03-27  Ryosuke Niwa  <rniwa@webkit.org>
151
152         [macOS] Select element doesn't show popup if select element had lost focus while popup was previosuly shown
153         https://bugs.webkit.org/show_bug.cgi?id=196336
154
155         Reviewed by Tim Horton.
156
157         Fixed the bug that we were not actually dismissing the popup in PopupMenuMac::hide as done in WebKit2.
158
159         Unfortunately no new tests since intenals.isSelectPopupVisible would always return false in WebKit1.
160
161         * WebCoreSupport/PopupMenuMac.mm:
162         (PopupMenuMac::hide):
163
164 2019-03-25  Andy Estes  <aestes@apple.com>
165
166         [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
167         https://bugs.webkit.org/show_bug.cgi?id=194964
168         <rdar://problem/48279441>
169
170         Reviewed by Alex Christensen.
171
172         The WebDataSource._quickLookContent SPI accidentally relied on PreviewLoaders being leaked
173         to keep the temporary file referenced by WebQuickLookFileNameKey in existence. Since
174         PreviewLoaders are now being deleted properly, we teach WebDataSource to keep the
175         PreviewLoaderClient alive for its lifetime. This ensures that as long as
176         WebDataSource._quickLookContent can be called, the associated temp file will not be deleted
177         by WebKit.
178
179         * WebCoreSupport/WebFrameLoaderClient.mm:
180         (WebFrameLoaderClient::createPreviewLoaderClient):
181         * WebView/WebDataSource.mm:
182         (-[WebDataSource _quickLookPreviewLoaderClient]):
183         (-[WebDataSource _setQuickLookPreviewLoaderClient:]):
184         * WebView/WebDataSourceInternal.h:
185
186 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
187
188         Remove NavigatorContentUtils in WebCore/Modules
189         https://bugs.webkit.org/show_bug.cgi?id=196070
190
191         Reviewed by Alex Christensen.
192
193         NavigatorContentUtils was to support the custom scheme spec [1].
194         However, in WebKit side, no port has supported the feature in
195         WebKit layer after EFL port was removed. So there has been the
196         only IDL implementation of the NavigatorContentUtils in WebCore.
197         So we don't need to keep the implementation in WebKit.
198
199         * Configurations/FeatureDefines.xcconfig:
200
201 2019-03-22  Keith Rollin  <krollin@apple.com>
202
203         Enable ThinLTO support in Production builds
204         https://bugs.webkit.org/show_bug.cgi?id=190758
205         <rdar://problem/45413233>
206
207         Reviewed by Daniel Bates.
208
209         Enable building with Thin LTO in Production when using Xcode 10.2 or
210         later. This change results in a 1.45% progression in PLT5. Full
211         Production build times increase about 2-3%. Incremental build times
212         are more severely affected, and so LTO is not enabled for local
213         engineering builds.
214
215         LTO is enabled only on macOS for now, until rdar://problem/49013399,
216         which affects ARM builds, is fixed.
217
218         To change the LTO setting when building locally:
219
220         - If building with `make`, specify WK_LTO_MODE={none,thin,full} on the
221           command line.
222         - If building with `build-webkit`, specify --lto-mode={none,thin,full}
223           on the command line.
224         - If building with `build-root`, specify --lto={none,thin,full} on the
225           command line.
226         - If building with Xcode, create a LocalOverrides.xcconfig file at the
227           top level of your repository directory (if needed) and define
228           WK_LTO_MODE to full, thin, or none.
229
230         * Configurations/Base.xcconfig:
231
232 2019-03-21  Andy Estes  <aestes@apple.com>
233
234         [iOS] Apple Pay should be available in documents with no user agent scripts
235         https://bugs.webkit.org/show_bug.cgi?id=196061
236         <rdar://problem/48649391>
237
238         Reviewed by Brady Eidson.
239
240         * WebView/WebFrame.mm:
241         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
242
243 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
244
245         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
246         https://bugs.webkit.org/show_bug.cgi?id=196049
247
248         Reviewed by Tim Horton.
249
250         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
251         overflow scrolling in general, so rename it.
252
253         * Configurations/FeatureDefines.xcconfig:
254
255 2019-03-13  Dean Jackson  <dino@apple.com>
256
257         Block all plugins smaller than 5x5px
258         https://bugs.webkit.org/show_bug.cgi?id=195702
259         <rdar://problem/28435204>
260
261         Reviewed by Sam Weinig.
262
263         Removed a function that was never being called.
264
265         * WebCoreSupport/WebFrameLoaderClient.h:
266         * WebCoreSupport/WebFrameLoaderClient.mm:
267         (WebFrameLoaderClient::recreatePlugin): Deleted.
268
269 2019-03-13  Keith Rollin  <krollin@apple.com>
270
271         Add support for new StagedFrameworks layout
272         https://bugs.webkit.org/show_bug.cgi?id=195543
273
274         Reviewed by Alexey Proskuryakov.
275
276         When creating the WebKit layout for out-of-band Safari/WebKit updates,
277         use an optional path prefix when called for.
278
279         * Configurations/WebKitLegacy.xcconfig:
280
281 2019-03-12  Ryosuke Niwa  <rniwa@webkit.org>
282
283         Remove a site specific hack for AppleConnect plugin
284         https://bugs.webkit.org/show_bug.cgi?id=195643
285
286         Reviewed by Simon Fraser.
287
288         r66437 added a workaround for AppleConnect plugin.
289
290         Remove this code since Safari doesn't even use WebKitLegacy anymore,
291         and other WebKit clients support AppleConnect plugins.
292
293         * WebCoreSupport/WebFrameLoaderClient.mm:
294         (WebFrameLoaderClient::createPlugin):
295
296 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
297
298         Unreviewed, rolling out r242688, r242643, r242624.
299
300         Caused multiple layout test failures and crashes on iOS and macOS.
301
302         Reverted changeset:
303
304         "requestAnimationFrame should execute before the next frame"
305         https://bugs.webkit.org/show_bug.cgi?id=177484
306         https://trac.webkit.org/changeset/242624/webkit
307
308         * WebView/WebView.mm:
309         (-[WebView _viewWillDrawInternal]):
310
311 2019-03-09  Andy Estes  <aestes@apple.com>
312
313         [Apple Pay] CanMakePaymentsWithActiveCard and OpenPaymentSetup should be async messages
314         https://bugs.webkit.org/show_bug.cgi?id=195526
315         <rdar://problem/48745636>
316
317         Reviewed by Chris Dumez.
318
319         * WebCoreSupport/WebPaymentCoordinatorClient.h:
320         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
321         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
322         (WebPaymentCoordinatorClient::openPaymentSetup):
323
324 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
325
326         requestAnimationFrame should execute before the next frame
327         https://bugs.webkit.org/show_bug.cgi?id=177484
328
329         Reviewed by Simon Fraser.
330
331         * WebView/WebView.mm:
332         (-[WebView _viewWillDrawInternal]):
333         Call Page::renderingUpdate() which implements  "Update the rendering"
334         step of the HTML Event Loop specification.
335
336 2019-03-07  Zalan Bujtas  <zalan@apple.com>
337
338         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
339         https://bugs.webkit.org/show_bug.cgi?id=195353
340         <rdar://problem/48626394>
341
342         Reviewed by Simon Fraser.
343
344         * WebView/WebPreferenceKeysPrivate.h:
345         * WebView/WebPreferences.mm:
346         (+[WebPreferences initialize]):
347         (-[WebPreferences contentChangeObserverEnabled]):
348         (-[WebPreferences setContentChangeObserverEnabled:]):
349         * WebView/WebPreferencesPrivate.h:
350         * WebView/WebView.mm:
351         (-[WebView _preferencesChanged:]):
352
353 2019-03-06  Sam Weinig  <sam@webkit.org>
354
355         WebKitLegacy does not need to generate an export file for i386 anymore
356         https://bugs.webkit.org/show_bug.cgi?id=195380
357
358         Reviewed by Dan Bernstein.
359
360         * Configurations/WebKitLegacy.xcconfig:
361         Simplify EXPORTED_SYMBOLS_FILE down to just a single path to a generated file.
362         It still needs to be generated, since we are concatenating the shared exports
363         file with a macOS or iOS specific one.
364
365         * WebKit.mac.exp:
366         Remove i386 specific symbols that we were previously stripping.
367
368 2019-03-06  Rob Buis  <rbuis@igalia.com>
369
370         Consider supporting the `referrerpolicy` attribute.
371         https://bugs.webkit.org/show_bug.cgi?id=179053
372
373         Reviewed by Darin Adler.
374
375         Add a runtime flag for referrerpolicy attribute.
376
377         * WebView/WebPreferenceKeysPrivate.h:
378         * WebView/WebPreferences.mm:
379         (+[WebPreferences initialize]):
380         (-[WebPreferences referrerPolicyAttributeEnabled]):
381         (-[WebPreferences setReferrerPolicyAttributeEnabled:]):
382         * WebView/WebPreferencesPrivate.h:
383         * WebView/WebView.mm:
384         (-[WebView _preferencesChanged:]):
385
386 2019-03-03  Tim Horton  <timothy_horton@apple.com>
387
388         Remove some more unused 32-bit code
389         https://bugs.webkit.org/show_bug.cgi?id=195255
390
391         Reviewed by Darin Adler.
392
393         * Plugins/WebNetscapePluginEventHandler.mm:
394         (WebNetscapePluginEventHandler::create):
395         * Plugins/WebNetscapePluginView.h:
396         * Plugins/WebNetscapePluginView.mm:
397         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
398         (-[WebNetscapePluginView restorePortState:]):
399         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
400         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
401         (-[WebNetscapePluginView updateAndSetWindow]):
402         (-[WebNetscapePluginView setWindowIfNecessary]):
403         (-[WebNetscapePluginView createPlugin]):
404         (-[WebNetscapePluginView fini]):
405         (-[WebNetscapePluginView drawRect:]):
406         (-[WebNetscapePluginView invalidateRegion:]):
407         (-[WebNetscapePluginView getVariable:value:]):
408         (-[WebNetscapePluginView setVariable:value:]):
409         (isDrawingModelQuickDraw): Deleted.
410         (-[WebNetscapePluginView fixWindowPort]): Deleted.
411         (getQDPixelFormatForBitmapContext): Deleted.
412         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
413         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
414         * WebView/WebDelegateImplementationCaching.mm:
415
416 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
417
418         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
419         https://bugs.webkit.org/show_bug.cgi?id=195053
420         <rdar://problem/48134710>
421
422         Reviewed by Ryosuke Niwa.
423
424         * WebCoreSupport/WebEditorClient.h:
425
426 2019-03-01  Tim Horton  <timothy_horton@apple.com>
427
428         Remove unused code in WebKitLegacy
429         https://bugs.webkit.org/show_bug.cgi?id=189614
430
431         Reviewed by Simon Fraser.
432
433         * Carbon/CarbonUtils.h: Removed.
434         * Carbon/CarbonUtils.m: Removed.
435         * Carbon/CarbonWindowAdapter.h: Removed.
436         * Carbon/CarbonWindowAdapter.mm: Removed.
437         * Carbon/CarbonWindowContentView.h: Removed.
438         * Carbon/CarbonWindowContentView.m: Removed.
439         * Carbon/CarbonWindowFrame.h: Removed.
440         * Carbon/CarbonWindowFrame.m: Removed.
441         * Carbon/HIViewAdapter.h: Removed.
442         * Carbon/HIViewAdapter.m: Removed.
443         * Carbon/HIWebView.h: Removed.
444         * Carbon/HIWebView.mm: Removed.
445         * Configurations/WebKitLegacy.xcconfig:
446         * WebKit.mac.exp:
447
448 2019-03-01  Justin Fan  <justin_fan@apple.com>
449
450         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
451         https://bugs.webkit.org/show_bug.cgi?id=195191
452
453         Rubber-stamped by Dean Jackson.
454
455         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
456
457         * Configurations/FeatureDefines.xcconfig:
458
459 2019-02-28  Antoine Quint  <graouts@apple.com>
460
461         Enable the Pointer Events runtime flag by default
462         https://bugs.webkit.org/show_bug.cgi?id=195156
463
464         Reviewed by Dean Jackson.
465
466         * WebView/WebPreferences.mm:
467         (+[WebPreferences initialize]):
468
469 2019-02-28  Justin Fan  <justin_fan@apple.com>
470
471         [Web GPU] Enable Web GPU only on 64-bit
472         https://bugs.webkit.org/show_bug.cgi?id=195139
473
474         Because Metal is only supported on 64 bit apps.
475
476         Unreviewed build fix.
477
478         * Configurations/FeatureDefines.xcconfig:
479
480 2019-02-27  Antoine Quint  <graouts@apple.com>
481
482         Support Pointer Events on macOS
483         https://bugs.webkit.org/show_bug.cgi?id=195008
484         <rdar://problem/47454419>
485
486         Reviewed by Dean Jackson.
487
488         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
489
490         * Configurations/FeatureDefines.xcconfig:
491         * WebView/WebPreferenceKeysPrivate.h:
492         * WebView/WebPreferences.mm:
493         (+[WebPreferences initialize]):
494         (-[WebPreferences pointerEventsEnabled]):
495         (-[WebPreferences setPointerEventsEnabled:]):
496         * WebView/WebPreferencesPrivate.h:
497         * WebView/WebView.mm:
498         (-[WebView _preferencesChanged:]):
499
500 2019-02-23  Keith Miller  <keith_miller@apple.com>
501
502         Add new mac target numbers
503         https://bugs.webkit.org/show_bug.cgi?id=194955
504
505         Reviewed by Tim Horton.
506
507         * Configurations/Base.xcconfig:
508         * Configurations/DebugRelease.xcconfig:
509
510 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
511
512         Hardcode Visual Viewports on everywhere except iOS WK1
513         https://bugs.webkit.org/show_bug.cgi?id=194928
514
515         Reviewed by Zalan Bujtas.
516
517         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
518         change the default value of the Setting to 'true', and hardcode WebView on iOS to
519         set it to false. The setting has shipped for several years and there's no need to turn
520         it off now.
521
522         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
523         Visual Viewports are not enabled.
524         
525         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
526         that only runs in WK2
527
528         * WebView/WebPreferenceKeysPrivate.h:
529         * WebView/WebPreferences.mm:
530         (+[WebPreferences initialize]):
531         (-[WebPreferences visualViewportEnabled]): Deleted.
532         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
533         * WebView/WebPreferencesPrivate.h:
534         * WebView/WebView.mm:
535         (-[WebView _preferencesChanged:]):
536
537 2019-02-21  Darin Adler  <darin@apple.com>
538
539         Some refinements for Node and Document
540         https://bugs.webkit.org/show_bug.cgi?id=194764
541
542         Reviewed by Ryosuke Niwa.
543
544         * DOM/DOMDocument.mm:
545         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
546         through to WebCore or even looking at the arguments.
547         (-[DOMDocument getOverrideStyle::]): Ditto.
548
549 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
550
551         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
552         https://bugs.webkit.org/show_bug.cgi?id=194670
553         <rdar://problem/39066529>
554
555         Reviewed by Tim Horton.
556
557         * WebCoreSupport/WebEditorClient.h:
558         * WebCoreSupport/WebEditorClient.mm:
559         (WebEditorClient::replacementURLForResource): Deleted.
560         * WebCoreSupport/WebPlatformStrategies.h:
561         * WebCoreSupport/WebPlatformStrategies.mm:
562         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
563
564 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
565
566         Add MSE logging configuration
567         https://bugs.webkit.org/show_bug.cgi?id=194719
568         <rdar://problem/48122151>
569
570         Reviewed by Joseph Pecoraro.
571
572         * WebCoreSupport/WebChromeClient.mm:
573         (stringForMessageSource): Recognize the MSE message source.
574
575 2019-02-17  David Kilzer  <ddkilzer@apple.com>
576
577         Unreviewed, rolling out r241620.
578
579         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
580         (Requested by ddkilzer on #webkit.)
581
582         Reverted changeset:
583
584         "[WTF] Add environment variable helpers"
585         https://bugs.webkit.org/show_bug.cgi?id=192405
586         https://trac.webkit.org/changeset/241620
587
588 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
589
590         [WTF] Add environment variable helpers
591         https://bugs.webkit.org/show_bug.cgi?id=192405
592
593         Reviewed by Michael Catanzaro.
594
595         * WebView/WebView.mm:
596         (-[WebView _initWithFrame:frameName:groupName:]):
597         Utilize WTF::Environment where possible.
598
599 2019-02-15  Brian Burg  <bburg@apple.com>
600
601         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
602         https://bugs.webkit.org/show_bug.cgi?id=194411
603         <rdar://problem/47787614>
604
605         Reviewed by Joseph Pecoraro.
606
607         * Configurations/WebKitLegacy.xcconfig:
608         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
609
610         * WebCoreSupport/WebInspectorClient.mm:
611         (WebInspectorFrontendClient::localizedStringsURL):
612         (-[WebInspectorWindowController inspectorPagePath]):
613         (-[WebInspectorWindowController inspectorTestPagePath]):
614         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
615
616 2019-02-15  Commit Queue  <commit-queue@webkit.org>
617
618         Unreviewed, rolling out r241559 and r241566.
619         https://bugs.webkit.org/show_bug.cgi?id=194710
620
621         Causes layout test crashes under GuardMalloc (Requested by
622         ryanhaddad on #webkit).
623
624         Reverted changesets:
625
626         "[WTF] Add environment variable helpers"
627         https://bugs.webkit.org/show_bug.cgi?id=192405
628         https://trac.webkit.org/changeset/241559
629
630         "Unreviewed build fix for WinCairo Debug after r241559."
631         https://trac.webkit.org/changeset/241566
632
633 2019-02-15  Truitt Savell  <tsavell@apple.com>
634
635         Unreviewed, rolling out r241564.
636
637         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
638
639         Reverted changeset:
640
641         "[Mac] WebInspectorUI.framework does not need to be soft-
642         linked anymore"
643         https://bugs.webkit.org/show_bug.cgi?id=194411
644         https://trac.webkit.org/changeset/241564
645
646 2019-02-14  Brian Burg  <bburg@apple.com>
647
648         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
649         https://bugs.webkit.org/show_bug.cgi?id=194411
650         <rdar://problem/47787614>
651
652         Reviewed by Joseph Pecoraro.
653
654         * Configurations/WebKitLegacy.xcconfig:
655         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
656
657         * WebCoreSupport/WebInspectorClient.mm:
658         (WebInspectorFrontendClient::localizedStringsURL):
659         (-[WebInspectorWindowController inspectorPagePath]):
660         (-[WebInspectorWindowController inspectorTestPagePath]):
661         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
662
663 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
664
665         [WTF] Add environment variable helpers
666         https://bugs.webkit.org/show_bug.cgi?id=192405
667
668         Reviewed by Michael Catanzaro.
669
670         * WebView/WebView.mm:
671         (-[WebView _initWithFrame:frameName:groupName:]):
672         Utilize WTF::Environment where possible.
673
674 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
675
676         Allow pages to trigger programmatic paste from script on iOS
677         https://bugs.webkit.org/show_bug.cgi?id=194271
678         <rdar://problem/47808810>
679
680         Reviewed by Ryosuke Niwa.
681
682         See WebCore and WebKit ChangeLogs for more details.
683
684         * WebCoreSupport/WebEditorClient.h:
685
686 2019-02-12  Andy Estes  <aestes@apple.com>
687
688         [iOSMac] Enable Parental Controls Content Filtering
689         https://bugs.webkit.org/show_bug.cgi?id=194521
690         <rdar://39732376>
691
692         Reviewed by Tim Horton.
693
694         * Configurations/FeatureDefines.xcconfig:
695
696 2019-02-06  Andy Estes  <aestes@apple.com>
697
698         [Payment Request] It should be possible to require a phonetic name for shipping contacts
699         https://bugs.webkit.org/show_bug.cgi?id=194311
700         <rdar://46733045>
701
702         Reviewed by Alex Christensen.
703
704         * WebCoreSupport/WebPaymentCoordinatorClient.h:
705         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
706         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
707
708 2019-02-04  Said Abou-Hallawa  <said@apple.com>
709
710         [CG] Enable setAdditionalSupportedImageTypes for WK1
711         https://bugs.webkit.org/show_bug.cgi?id=194190
712
713         Reviewed by Tim Horton.
714
715         1. Define the preferences key AdditionalSupportedImageTypes.
716         2. Add additionalSupportedImageTypes as a private preference property.
717         3. Define the setter and the getter of the property.
718         4. Add function to convert from an id to an array of strings.
719         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
720
721         * WebView/WebPreferenceKeysPrivate.h:
722         * WebView/WebPreferences.mm:
723         (-[WebPreferences _stringArrayValueForKey:]):
724         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
725         (-[WebPreferences setAdditionalSupportedImageTypes:]):
726         (-[WebPreferences additionalSupportedImageTypes]):
727         * WebView/WebPreferencesPrivate.h:
728         * WebView/WebView.mm:
729         (-[WebView _preferencesChanged:]):
730
731 2019-02-04  Timothy Hatcher  <timothy@apple.com>
732
733         Add WebView SPI to temporarily force light or dark appearance on a page.
734         https://bugs.webkit.org/show_bug.cgi?id=194230
735
736         Reviewed by Tim Horton.
737
738         * WebView/WebView.mm:
739         (-[WebView _useDarkAppearance:]): Added.
740         (-[WebView _setUseDarkAppearance:]): Added.
741         * WebView/WebViewPrivate.h:
742
743 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
744
745         PageOverlayController's layers should be created lazily
746         https://bugs.webkit.org/show_bug.cgi?id=194199
747         rdar://problem/46571593
748
749         Reviewed by Tim Horton.
750
751         * WebCoreSupport/WebChromeClient.h:
752         * WebCoreSupport/WebChromeClient.mm:
753         (WebChromeClient::attachViewOverlayGraphicsLayer):
754
755 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
756
757         Make setNeedsLayout on the root more explicitly about triggering its side-effects
758         https://bugs.webkit.org/show_bug.cgi?id=194198
759
760         Reviewed by Antti Koivisto.
761
762         Call the newly named functions.
763
764         * WebView/WebFrame.mm:
765         (-[WebFrame setNeedsLayout]):
766         * WebView/WebHTMLView.mm:
767         (-[WebHTMLView setNeedsLayout:]):
768
769 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
770
771         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
772         https://bugs.webkit.org/show_bug.cgi?id=194189
773
774         Reviewed by Geoffrey Garen.
775
776         Pass the policy check identifier around functions and store it in WebFramePolicyListener
777         so that we can send it back to WebCore with the navigation policy decision.
778
779         * WebCoreSupport/WebFrameLoaderClient.h:
780         * WebCoreSupport/WebFrameLoaderClient.mm:
781         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
782         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
783         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
784         (WebFrameLoaderClient::dispatchWillSubmitForm):
785         (WebFrameLoaderClient::setUpPolicyListener):
786         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
787         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
788         (-[WebFramePolicyListener invalidate]):
789         (-[WebFramePolicyListener dealloc]):
790         (-[WebFramePolicyListener receivedPolicyDecision:]):
791         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
792         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
793
794 2019-01-31  Alex Christensen  <achristensen@webkit.org>
795
796         Revert r238819 which is unneeded and caused a performance regression.
797         https://bugs.webkit.org/show_bug.cgi?id=192272
798         <rdar://problem/46664625>
799
800         * WebCoreSupport/WebFrameLoaderClient.h:
801         * WebCoreSupport/WebFrameLoaderClient.mm:
802         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
803
804 2019-01-28  Devin Rousso  <drousso@apple.com>
805
806         Web Inspector: provide a way to edit page WebRTC settings on a remote target
807         https://bugs.webkit.org/show_bug.cgi?id=193863
808         <rdar://problem/47572764>
809
810         Reviewed by Joseph Pecoraro.
811
812         * WebView/WebView.mm:
813         (-[WebView _preferencesChanged:]):
814         Add page-level settings for WebRTC preferences.
815
816 2019-01-28  Andy Estes  <aestes@apple.com>
817
818         [watchOS] Enable Parental Controls content filtering
819         https://bugs.webkit.org/show_bug.cgi?id=193939
820         <rdar://problem/46641912>
821
822         Reviewed by Ryosuke Niwa.
823
824         * Configurations/FeatureDefines.xcconfig:
825
826 2019-01-28  Timothy Hatcher  <timothy@apple.com>
827
828         Make it easier for non-Apple ports to enable dark mode CSS support.
829         https://bugs.webkit.org/show_bug.cgi?id=193882
830
831         Reviewed by Megan Gardner.
832
833         * WebView/WebView.mm:
834         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
835         (-[WebView _effectiveAppearanceIsDark]): Ditto.
836
837 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
838
839         AX: Introduce a static accessibility tree
840         https://bugs.webkit.org/show_bug.cgi?id=193348
841         <rdar://problem/47203295>
842
843         Reviewed by Ryosuke Niwa.
844
845         * Configurations/FeatureDefines.xcconfig:
846
847 2019-01-25  Keith Rollin  <krollin@apple.com>
848
849         Update WebKitAdditions.xcconfig with correct order of variable definitions
850         https://bugs.webkit.org/show_bug.cgi?id=193793
851         <rdar://problem/47532439>
852
853         Reviewed by Alex Christensen.
854
855         XCBuild changes the way xcconfig variables are evaluated. In short,
856         all config file assignments are now considered in part of the
857         evaluation. When using the new build system and an .xcconfig file
858         contains multiple assignments of the same build setting:
859
860         - Later assignments using $(inherited) will inherit from earlier
861           assignments in the xcconfig file.
862         - Later assignments not using $(inherited) will take precedence over
863           earlier assignments. An assignment to a more general setting will
864           mask an earlier assignment to a less general setting. For example,
865           an assignment without a condition ('FOO = bar') will completely mask
866           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
867
868         This affects some of our .xcconfig files, in that sometimes platform-
869         or sdk-specific definitions appear before the general definitions.
870         Under the new evaluations rules, the general definitions alway take
871         effect because they always overwrite the more-specific definitions. The
872         solution is to swap the order, so that the general definitions are
873         established first, and then conditionally overwritten by the
874         more-specific definitions.
875
876         * Configurations/Version.xcconfig:
877         * Configurations/WebKitLegacy.xcconfig:
878
879 2019-01-25  David Kilzer  <ddkilzer@apple.com>
880
881         Move soft-linking of Lookup.framework out of LookupSPI.h
882         <https://webkit.org/b/193815>
883
884         Reviewed by Tim Horton.
885
886         * WebView/WebImmediateActionController.mm:
887         (-[WebImmediateActionController _animationControllerForText]):
888         * WebView/WebView.mm:
889         (-[WebView _prepareForDictionaryLookup]):
890         - Move soft-linking to LookupSoftLink.{h,mm}.
891
892 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
893
894         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
895         https://bugs.webkit.org/show_bug.cgi?id=193829
896
897         Reviewed by Tim Horton.
898
899         * WebCoreSupport/WebDragClient.mm:
900         (WebDragClient::didConcludeEditDrag):
901         * WebView/WebView.mm:
902         (-[WebView _requestStartDataInteraction:globalPosition:]):
903         (-[WebView _didConcludeEditDrag]):
904         (-[WebView _didConcludeEditDataInteraction]): Deleted.
905         * WebView/WebViewInternal.h:
906
907 2019-01-24  John Wilander  <wilander@apple.com>
908
909         Add Ad Click Attribution as an internal/experimental feature
910         https://bugs.webkit.org/show_bug.cgi?id=193685
911         <rdar://problem/47450399>
912
913         Reviewed by Brent Fulgham.
914
915         * WebView/WebPreferenceKeysPrivate.h:
916         * WebView/WebPreferences.mm:
917         (+[WebPreferences initialize]):
918         (-[WebPreferences adClickAttributionEnabled]):
919         (-[WebPreferences setAdClickAttributionEnabled:]):
920             Added support for experimental ad click attribution.
921         * WebView/WebPreferencesPrivate.h:
922         * WebView/WebView.mm:
923         (-[WebView _preferencesChanged:]):
924
925 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
926
927         Move FileSystem to WTF
928         https://bugs.webkit.org/show_bug.cgi?id=193602
929
930         Reviewed by Yusuke Suzuki.
931
932         * Misc/WebNSFileManagerExtras.mm:
933         * Storage/WebDatabaseProvider.mm:
934         * WebView/WebView.mm:
935
936 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
937
938         Fix the Apple Internal build. See <rdar://problem/47491383>.
939
940         Rubber-stamped by Tim Horton.
941
942         * WebCoreSupport/WebFrameLoaderClient.mm:
943
944 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
945
946         Clean up USE(WEB_THREAD)
947         https://bugs.webkit.org/show_bug.cgi?id=193698
948
949         Rubber-stamped by Tim Horton.
950
951         * Misc/WebCache.mm:
952         (+[WebCache emptyInMemoryResources]):
953         * WebCoreSupport/WebFrameLoaderClient.mm:
954         (-[WebFramePolicyListener use]):
955         * WebCoreSupport/WebGeolocationClient.mm:
956         (-[WebGeolocationPolicyListener allow]):
957         (-[WebGeolocationPolicyListener deny]):
958         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
959         * WebView/WebFrame.mm:
960         (-[WebFrame deviceOrientationChanged]):
961         * WebView/WebHTMLView.mm:
962         (hardwareKeyboardAvailabilityChangedCallback):
963         * WebView/WebView.mm:
964         (+[WebView _releaseMemoryNow]):
965         (+[WebView willEnterBackgroundWithCompletionHandler:]):
966         (-[WebView updateLayoutIgnorePendingStyleSheets]):
967         (-[WebView _dispatchUnloadEvent]):
968         (-[WebView _close]):
969         (-[WebView _preferencesChangedNotification:]):
970         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
971         (-[WebView goBack]):
972         (-[WebView goForward]):
973         (+[WebView _cacheModelChangedNotification:]):
974         (-[WebView stopLoading:]):
975         (-[WebView stopLoadingAndClear]):
976         (-[WebView reload:]):
977         (WebInstallMemoryPressureHandler):
978
979 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
980
981         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
982         https://bugs.webkit.org/show_bug.cgi?id=193706
983         <rdar://problem/44807048>
984
985         Reviewed by Ryosuke Niwa.
986
987         Use UndoStep::label().
988
989         * WebCoreSupport/WebEditorClient.h:
990         * WebCoreSupport/WebEditorClient.mm:
991         (-[WebUndoStep initWithUndoStep:]):
992         (+[WebUndoStep stepWithUndoStep:]):
993         (WebEditorClient::registerUndoOrRedoStep):
994         (WebEditorClient::registerUndoStep):
995         (WebEditorClient::registerRedoStep):
996
997 2019-01-22  Alex Christensen  <achristensen@webkit.org>
998
999         Move NetworkStorageSession ownership to NetworkProcess
1000         https://bugs.webkit.org/show_bug.cgi?id=193580
1001
1002         Reviewed by Geoff Garen.
1003
1004         * Misc/WebCache.mm:
1005         (+[WebCache clearCachedCredentials]):
1006         * Misc/WebDownload.mm:
1007         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1008         * Plugins/WebBaseNetscapePluginView.mm:
1009         (WebKit::getAuthenticationInfo):
1010         * WebCoreSupport/WebFrameNetworkingContext.mm:
1011         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1012         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
1013         (WebFrameNetworkingContext::storageSession const):
1014         * WebView/WebPreferences.mm:
1015         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1016         (+[WebPreferences _clearNetworkLoaderSession]):
1017         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
1018
1019 2019-01-22  Daniel Bates  <dabates@apple.com>
1020
1021         [iOS] Interpret text key commands on keydown and app key commands on keypress
1022         https://bugs.webkit.org/show_bug.cgi?id=192897
1023         <rdar://problem/46857378>
1024
1025         Reviewed by Brent Fulgham.
1026
1027         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
1028         is false) and keypress (isCharEvent is true), respectively.
1029
1030         * WebView/WebHTMLView.mm:
1031         (-[WebHTMLView _handleEditingKeyEvent:]):
1032
1033 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
1034
1035         [css-logical] Implement flow-relative margin, padding and border shorthands
1036         https://bugs.webkit.org/show_bug.cgi?id=188697
1037
1038         Reviewed by Simon Fraser and Antti Koivisto.
1039
1040         Add CSSLogicalEnabled runtime flag.
1041
1042         * WebView/WebPreferenceKeysPrivate.h:
1043         * WebView/WebPreferences.mm:
1044         (+[WebPreferences initialize]):
1045         (-[WebPreferences cssLogicalEnabled]):
1046         (-[WebPreferences setCSSLogicalEnabled:]):
1047         * WebView/WebPreferencesPrivate.h:
1048         * WebView/WebView.mm:
1049         (-[WebView _preferencesChanged:]):
1050
1051 2019-01-15  Darin Adler  <darin@apple.com>
1052
1053         Use references rather than pointers for register/unregister functions, and more
1054         https://bugs.webkit.org/show_bug.cgi?id=175028
1055
1056         Reviewed by Daniel Bates.
1057
1058         * WebCoreSupport/WebKitFullScreenListener.mm:
1059         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
1060         functions in Document; pass a reference.
1061         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
1062         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
1063         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
1064         * WebView/WebFullScreenController.mm:
1065         (-[WebFullScreenController enterFullScreen:]): Ditto.
1066         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
1067         (-[WebFullScreenController exitFullScreen]): Ditto.
1068         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
1069         * WebView/WebFullScreenController.mm:
1070         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
1071
1072 2019-01-12  Dan Bernstein  <mitz@apple.com>
1073
1074         [Cocoa] Avoid importing directly from subumbrella frameworks
1075         https://bugs.webkit.org/show_bug.cgi?id=186016
1076         <rdar://problem/40591038>
1077
1078         Reviewed by Sam Weinig.
1079
1080         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1081         * Carbon/CarbonWindowAdapter.mm: Ditto.
1082         * Carbon/CarbonWindowFrame.m: Ditto.
1083         * Carbon/HIViewAdapter.h: Ditto.
1084         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1085           OTHER_CFLAGS_COCOA_TOUCH_NO.
1086         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1087         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1088         * WebView/WebPDFView.h: Ditto.
1089
1090 2019-01-20  Antoine Quint  <graouts@apple.com>
1091
1092         Add a POINTER_EVENTS feature flag
1093         https://bugs.webkit.org/show_bug.cgi?id=193577
1094         <rdar://problem/47408511>
1095
1096         Unreviewed. Also enable Pointer Events for iosmac.
1097
1098         * Configurations/FeatureDefines.xcconfig:
1099
1100 2019-01-19  Antoine Quint  <graouts@apple.com>
1101
1102         Add a POINTER_EVENTS feature flag
1103         https://bugs.webkit.org/show_bug.cgi?id=193577
1104
1105         Reviewed by Dean Jackson.
1106
1107         * Configurations/FeatureDefines.xcconfig:
1108
1109 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
1110
1111         Revert r238815, it broke WK1 video fullscreen on Mac
1112         https://bugs.webkit.org/show_bug.cgi?id=193586
1113         <rdar://problem/47358941>
1114
1115         Reviewed by Jer Noble.
1116
1117         * WebView/WebVideoFullscreenController.h: Added.
1118         * WebView/WebVideoFullscreenController.mm: Added.
1119         (SOFT_LINK_CLASS):
1120         (-[WebVideoFullscreenController init]):
1121         (-[WebVideoFullscreenController dealloc]):
1122         (-[WebVideoFullscreenController fullscreenWindow]):
1123         (-[WebVideoFullscreenController windowDidLoad]):
1124         (-[WebVideoFullscreenController videoElement]):
1125         (-[WebVideoFullscreenController setVideoElement:]):
1126         (-[WebVideoFullscreenController clearFadeAnimation]):
1127         (-[WebVideoFullscreenController windowDidExitFullscreen]):
1128         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
1129         (-[WebVideoFullscreenController videoElementRect]):
1130         (-[WebVideoFullscreenController applicationDidResignActive:]):
1131         (frameExpandedToRatioOfFrame):
1132         (createBackgroundFullscreenWindow):
1133         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
1134         (-[WebVideoFullscreenController enterFullscreen:]):
1135         (-[WebVideoFullscreenController exitFullscreen]):
1136         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
1137         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
1138         (-[WebVideoFullscreenController _requestExit]):
1139         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
1140         (-[WebVideoFullscreenController requestExitFullscreen]):
1141         (-[WebVideoFullscreenController fadeHUDIn]):
1142         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
1143         (-[WebVideoFullscreenController rateChanged:]):
1144         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1145         (-[WebVideoFullscreenWindow dealloc]):
1146         (-[WebVideoFullscreenWindow resignFirstResponder]):
1147         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
1148         (-[WebVideoFullscreenWindow mouseDown:]):
1149         (-[WebVideoFullscreenWindow cancelOperation:]):
1150         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
1151         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
1152         (-[WebVideoFullscreenWindow animationDidEnd:]):
1153         (-[WebVideoFullscreenWindow mouseMoved:]):
1154         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
1155         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
1156         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
1157         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
1158         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
1159         (-[WebVideoFullscreenHUDWindow center]):
1160         (-[WebVideoFullscreenHUDWindow keyDown:]):
1161         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
1162         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
1163         (-[WebVideoFullscreenHUDWindowController init]):
1164         (-[WebVideoFullscreenHUDWindowController dealloc]):
1165         (-[WebVideoFullscreenHUDWindowController setArea:]):
1166         (-[WebVideoFullscreenHUDWindowController keyDown:]):
1167         (-[WebVideoFullscreenHUDWindowController delegate]):
1168         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
1169         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
1170         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
1171         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
1172         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
1173         (-[WebVideoFullscreenHUDWindowController closeWindow]):
1174         (createMediaUIControl):
1175         (createControlWithMediaUIControlType):
1176         (createTimeTextField):
1177         (createMediaUIBackgroundView):
1178         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
1179         (-[WebVideoFullscreenHUDWindowController updateVolume]):
1180         (-[WebVideoFullscreenHUDWindowController updateTime]):
1181         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
1182         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
1183         (-[WebVideoFullscreenHUDWindowController currentTime]):
1184         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
1185         (-[WebVideoFullscreenHUDWindowController duration]):
1186         (-[WebVideoFullscreenHUDWindowController maxVolume]):
1187         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
1188         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
1189         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
1190         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
1191         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
1192         (-[WebVideoFullscreenHUDWindowController volume]):
1193         (-[WebVideoFullscreenHUDWindowController setVolume:]):
1194         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
1195         (-[WebVideoFullscreenHUDWindowController updateRate]):
1196         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
1197         (-[WebVideoFullscreenHUDWindowController playing]):
1198         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
1199         (timeToString):
1200         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
1201         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
1202         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
1203         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
1204         (-[WebVideoFullscreenHUDWindowController rewind:]):
1205         (-[WebVideoFullscreenHUDWindowController fastForward:]):
1206         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
1207         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
1208         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
1209         * WebView/WebView.mm:
1210         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1211         (-[WebView _exitVideoFullscreen]):
1212
1213 2019-01-18  Tim Horton  <timothy_horton@apple.com>
1214
1215         Get rid of ADVANCED_SPELL_CHECKING
1216         https://bugs.webkit.org/show_bug.cgi?id=193592
1217
1218         Reviewed by Wenson Hsieh.
1219
1220         * WebCoreSupport/WebEditorClient.mm:
1221         (insertionPointFromCurrentSelection):
1222         (WebEditorClient::checkTextOfParagraph):
1223         (WebEditorClient::getGuessesForWord):
1224         (WebEditorClient::requestCandidatesForSelection):
1225         (WebEditorClient::requestCheckingOfString):
1226         * WebView/WebHTMLView.mm:
1227         (-[WebHTMLView insertText:]):
1228
1229 2019-01-18  Jer Noble  <jer.noble@apple.com>
1230
1231         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1232         https://bugs.webkit.org/show_bug.cgi?id=189553
1233
1234         Reviewed by Tim Horton.
1235
1236         * Configurations/Base.xcconfig:
1237         * Configurations/SDKVariant.xcconfig: Added.
1238         * Configurations/WebKitLegacy.xcconfig:
1239
1240 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1241
1242         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1243         <https://webkit.org/b/193568>
1244         <rdar://problem/47381130>
1245
1246         Reviewed by Alex Christensen.
1247
1248         * WebView/WebView.mm:
1249         - Remove unused soft-linking macros.
1250         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1251         (-[WebUITextIndicatorData initWithImage:scale:]):
1252         - Update to use exported PAL functions.
1253
1254 2019-01-17  Truitt Savell  <tsavell@apple.com>
1255
1256         Unreviewed, rolling out r240124.
1257
1258         This commit broke an internal build.
1259
1260         Reverted changeset:
1261
1262         "SDK_VARIANT build destinations should be separate from non-
1263         SDK_VARIANT builds"
1264         https://bugs.webkit.org/show_bug.cgi?id=189553
1265         https://trac.webkit.org/changeset/240124
1266
1267 2019-01-17  Jer Noble  <jer.noble@apple.com>
1268
1269         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1270         https://bugs.webkit.org/show_bug.cgi?id=189553
1271
1272         Reviewed by Tim Horton.
1273
1274         * Configurations/Base.xcconfig:
1275         * Configurations/SDKVariant.xcconfig: Added.
1276         * Configurations/WebKitLegacy.xcconfig:
1277
1278 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1279
1280         Stop using NetworkStorageSession::storageSession in WebCore
1281         https://bugs.webkit.org/show_bug.cgi?id=193529
1282
1283         Reviewed by Tim Horton.
1284
1285         * Misc/WebCache.mm:
1286         (+[WebCache addImageToCache:forURL:forFrame:]):
1287         * WebView/WebView.mm:
1288         (-[WebView _commonInitializationWithFrameName:groupName:]):
1289         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1290
1291 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1292
1293         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1294         https://bugs.webkit.org/show_bug.cgi?id=193368
1295
1296         Reviewed by Geoff Garen.
1297
1298         * Misc/WebCache.mm:
1299         (+[WebCache clearCachedCredentials]):
1300         * Misc/WebDownload.mm:
1301         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1302         * Plugins/WebBaseNetscapePluginView.mm:
1303         (WebKit::getAuthenticationInfo):
1304
1305 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1306
1307         Stop using CookiesStrategy
1308         https://bugs.webkit.org/show_bug.cgi?id=161106
1309
1310         Reviewed by Don Olmstead and Antti Koivisto.
1311
1312         * Misc/WebCache.mm:
1313         (+[WebCache addImageToCache:forURL:forFrame:]):
1314         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1315         (WebKit::NetscapePluginInstanceProxy::getCookies):
1316         (WebKit::NetscapePluginInstanceProxy::setCookies):
1317         * Plugins/WebNetscapePluginView.mm:
1318         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1319         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1320         * WebCoreSupport/WebPlatformStrategies.h:
1321         * WebCoreSupport/WebPlatformStrategies.mm:
1322         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1323         (WebPlatformStrategies::cookiesForDOM): Deleted.
1324         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1325         (WebPlatformStrategies::cookiesEnabled): Deleted.
1326         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1327         (WebPlatformStrategies::getRawCookies): Deleted.
1328         (WebPlatformStrategies::deleteCookie): Deleted.
1329         * WebView/WebView.mm:
1330         (-[WebView _commonInitializationWithFrameName:groupName:]):
1331         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1332
1333 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1334
1335         Cannot tab out of WKWebView on macOS
1336         https://bugs.webkit.org/show_bug.cgi?id=161448
1337         <rdar://problem/28100085>
1338
1339         Reviewed by Dean Jackson.
1340
1341         * WebCoreSupport/WebChromeClient.mm:
1342         * WebView/WebView.mm:
1343         Make use of SPI headers.
1344
1345 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1346
1347         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1348         r239913, and r239914.
1349         https://bugs.webkit.org/show_bug.cgi?id=193407
1350
1351         These revisions caused an internal failure (Requested by
1352         Truitt on #webkit).
1353
1354         Reverted changesets:
1355
1356         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1357         https://bugs.webkit.org/show_bug.cgi?id=186016
1358         https://trac.webkit.org/changeset/239901
1359
1360         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1361         https://trac.webkit.org/changeset/239909
1362
1363         "Tried to fix the build."
1364         https://trac.webkit.org/changeset/239910
1365
1366         "Fixed iOS builds after r239910."
1367         https://trac.webkit.org/changeset/239912
1368
1369         "More build fixing."
1370         https://trac.webkit.org/changeset/239913
1371
1372         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1373         https://trac.webkit.org/changeset/239914
1374
1375 2019-01-14  Mark Lam  <mark.lam@apple.com>
1376
1377         Re-enable ability to build --cloop builds.
1378         https://bugs.webkit.org/show_bug.cgi?id=192955
1379         <rdar://problem/46882363>
1380
1381         Reviewed by Saam barati and Keith Miller.
1382
1383         * Configurations/FeatureDefines.xcconfig:
1384
1385 2019-01-13  Dan Bernstein  <mitz@apple.com>
1386
1387         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1388
1389         Patch by Keith Rollin.
1390
1391         * WebView/PDFViewSPI.h:
1392
1393 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1394
1395         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1396         https://bugs.webkit.org/show_bug.cgi?id=191655
1397         rdar://problem/46074680
1398
1399         Reviewed by Megan Gardner.
1400
1401         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1402         * WebView/WebView.mm:
1403         (-[WebView _effectiveAppearanceIsDark]):
1404
1405 2019-01-12  Dan Bernstein  <mitz@apple.com>
1406
1407         [Cocoa] Avoid importing directly from subumbrella frameworks
1408         https://bugs.webkit.org/show_bug.cgi?id=186016
1409         <rdar://problem/40591038>
1410
1411         Reviewed by Sam Weinig.
1412
1413         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1414         * Carbon/CarbonWindowAdapter.mm: Ditto.
1415         * Carbon/CarbonWindowFrame.m: Ditto.
1416         * Carbon/HIViewAdapter.h: Ditto.
1417         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1418           OTHER_CFLAGS_COCOA_TOUCH_NO.
1419         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1420         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1421         * WebView/WebPDFView.h: Ditto.
1422
1423 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1424
1425         Enable visual viewport API by default
1426         https://bugs.webkit.org/show_bug.cgi?id=193376
1427
1428         Reviewed by Simon Fraser.
1429
1430         * WebView/WebPreferences.mm:
1431         (+[WebPreferences initialize]):
1432
1433 2019-01-11  John Wilander  <wilander@apple.com>
1434
1435         Compile out Web API Statistics Collection
1436         https://bugs.webkit.org/show_bug.cgi?id=193370
1437         <rdar://problem/45388584>
1438
1439         Reviewed by Brent Fulgham.
1440
1441         * Configurations/FeatureDefines.xcconfig:
1442             Defined ENABLE_WEB_API_STATISTICS, off by default.
1443
1444 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1445
1446         Stop using NetworkStorageSession in WebProcess
1447         https://bugs.webkit.org/show_bug.cgi?id=193236
1448
1449         Reviewed by Don Olmstead.
1450
1451         * WebCoreSupport/WebFrameNetworkingContext.h:
1452         * WebCoreSupport/WebFrameNetworkingContext.mm:
1453         (WebFrameNetworkingContext::storageSession const):
1454         * WebCoreSupport/WebPlatformStrategies.h:
1455         * WebCoreSupport/WebPlatformStrategies.mm:
1456         (WebPlatformStrategies::cookiesForDOM):
1457         (WebPlatformStrategies::setCookiesFromDOM):
1458         (WebPlatformStrategies::cookiesEnabled):
1459         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1460         (WebPlatformStrategies::getRawCookies):
1461         (WebPlatformStrategies::deleteCookie):
1462         * WebView/WebView.mm:
1463         (-[WebView _cachedResponseForURL:]):
1464         (-[WebView _clearCredentials]):
1465
1466 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1467
1468         Unreviewed, rolling out r239727.
1469
1470         Broke API tests
1471
1472         Reverted changeset:
1473
1474         "Stop using NetworkStorageSession in WebProcess"
1475         https://bugs.webkit.org/show_bug.cgi?id=193236
1476         https://trac.webkit.org/changeset/239727
1477
1478 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1479
1480         Stop using NetworkStorageSession in WebProcess
1481         https://bugs.webkit.org/show_bug.cgi?id=193236
1482
1483         Reviewed by Don Olmstead.
1484
1485         * WebCoreSupport/WebFrameNetworkingContext.h:
1486         * WebCoreSupport/WebFrameNetworkingContext.mm:
1487         (WebFrameNetworkingContext::storageSession const):
1488         * WebView/WebView.mm:
1489         (-[WebView _cachedResponseForURL:]):
1490         (-[WebView _clearCredentials]):
1491
1492 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1493
1494         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1495         <https://webkit.org/b/193056>
1496
1497         Reviewed by Alex Christensen.
1498
1499         * Plugins/Hosted/NetscapePluginHostProxy.h:
1500         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1501         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1502         (WebKit::NetscapePluginInstanceProxy::enumerate):
1503         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1504         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1505         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1506         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1507         * Plugins/Hosted/ProxyInstance.mm:
1508         (WebKit::ProxyInstance::invoke):
1509         * WebCoreSupport/WebGeolocationClient.mm:
1510         * WebView/WebDataSource.mm:
1511         (-[WebDataSource _receivedData:]):
1512         * WebView/WebView.mm:
1513         (-[WebView _cachedResponseForURL:]):
1514         - Remove '*' from RetainPtr<> type.
1515
1516 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1517
1518         Progress towards fixing Mac CMake build
1519         https://bugs.webkit.org/show_bug.cgi?id=193105
1520
1521         Reviewed by Don Olmstead.
1522
1523         * WebKitPrefix.h:
1524
1525 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1526
1527         Web Inspector: Use save sheet instead of dialog where possible
1528         https://bugs.webkit.org/show_bug.cgi?id=193160
1529         <rdar://problem/37399759>
1530
1531         Reviewed by Devin Rousso.
1532
1533         * WebCoreSupport/WebInspectorClient.mm:
1534         (WebInspectorFrontendClient::save):
1535
1536 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1537
1538         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1539         https://bugs.webkit.org/show_bug.cgi?id=193129
1540
1541         Reviewed by Tim Horton.
1542
1543         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1544
1545         * WebCoreSupport/WebEditorClient.mm:
1546         (WebEditorClient::registerUndoOrRedoStep):
1547         (undoNameForEditAction): Deleted.
1548
1549 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1550
1551         Add support for using the current text selection as the find string on iOS
1552         https://bugs.webkit.org/show_bug.cgi?id=193034
1553         <rdar://problem/45138739>
1554
1555         Reviewed by Tim Horton.
1556
1557         Add a method stub for WebKitLegacy.
1558
1559         * WebCoreSupport/WebEditorClient.h:
1560
1561 2019-01-01  Jeff Miller  <jeffm@apple.com>
1562
1563         Update user-visible copyright strings to include 2019
1564         https://bugs.webkit.org/show_bug.cgi?id=192811
1565
1566         Reviewed by Mark Lam.
1567
1568         * Info.plist:
1569
1570 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1571
1572         Use Ref<> as much as possible
1573         https://bugs.webkit.org/show_bug.cgi?id=192808
1574
1575         Reviewed by Alex Christensen.
1576
1577         * DOM/DOM.mm:
1578         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1579         * Plugins/Hosted/NetscapePluginHostManager.mm:
1580         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1581         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1582         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1583         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1584         * Plugins/WebNetscapePluginView.mm:
1585         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1586         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1587         * WebCoreSupport/WebContextMenuClient.mm:
1588         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1589         * WebCoreSupport/WebFrameLoaderClient.mm:
1590         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1591         * WebView/WebFrame.mm:
1592         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1593         * WebView/WebHTMLView.mm:
1594         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1595         * WebView/WebView.mm:
1596         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1597         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1598
1599 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1600
1601         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1602         https://bugs.webkit.org/show_bug.cgi?id=192821
1603
1604         Reviewed by Chris Dumez.
1605
1606         When a window becomes occluded, the window server informs the application.
1607         This should be used to suspend any work that is not visible by the user.
1608
1609         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1610         In some cases, that lead to performance impact (see radar).
1611
1612         This patch adds an observer for the occlusion notification. I tried to stick
1613         with the same names used by WebKit2.
1614
1615         * WebView/WebView.mm:
1616         (-[WebView _isViewVisible]):
1617         (-[WebView addWindowObserversForWindow:]):
1618         (-[WebView removeWindowObservers]):
1619         (-[WebView _windowDidChangeOcclusionState:]):
1620
1621 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1622
1623         [WebAuthN] Add a runtime flag for local authenticator
1624         https://bugs.webkit.org/show_bug.cgi?id=192792
1625         <rdar://problem/46798738>
1626
1627         Reviewed by Brent Fulgham.
1628
1629         * WebView/WebPreferenceKeysPrivate.h:
1630         * WebView/WebPreferences.mm:
1631         (+[WebPreferences initialize]):
1632         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1633         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1634         * WebView/WebPreferencesPrivate.h:
1635         * WebView/WebView.mm:
1636         (-[WebView _preferencesChanged:]):
1637
1638 2018-12-20  Chris Dumez  <cdumez@apple.com>
1639
1640         Use Optional::valueOr() instead of Optional::value_or()
1641         https://bugs.webkit.org/show_bug.cgi?id=192933
1642
1643         Reviewed by Geoffrey Garen.
1644
1645         * WebCoreSupport/WebSecurityOrigin.mm:
1646         (-[WebSecurityOrigin port]):
1647
1648 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1649
1650         Unreviewed, rolling out r239417.
1651
1652         Introduced two API test failures on macOS.
1653
1654         Reverted changeset:
1655
1656         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1657         occlusion changes"
1658         https://bugs.webkit.org/show_bug.cgi?id=192821
1659         https://trac.webkit.org/changeset/239417
1660
1661 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1662
1663         WKWebView default UA doesn't freeze the build number
1664         https://bugs.webkit.org/show_bug.cgi?id=192809
1665         <rdar://problem/44687185>
1666
1667         Reviewed by Andy Estes.
1668
1669         Always reports the frozen build number.
1670
1671         * WebView/WebView.mm:
1672         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1673         actual build number through this method call.
1674         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1675
1676 2018-12-19  Chris Dumez  <cdumez@apple.com>
1677
1678         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1679         https://bugs.webkit.org/show_bug.cgi?id=192728
1680         <rdar://problem/46746779>
1681
1682         Reviewed by Geoff Garen.
1683
1684         * DOM/*:
1685         * Plugins/*:
1686         * WebCoreSupport/*:
1687         * WebView/*:
1688
1689 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1690
1691         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1692         https://bugs.webkit.org/show_bug.cgi?id=192821
1693
1694         Reviewed by Chris Dumez.
1695
1696         When a window becomes occluded, the window server informs the application.
1697         This should be used to suspend any work that is not visible by the user.
1698
1699         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1700         In some cases, that lead to performance impact (see radar).
1701
1702         This patch adds an observer for the occlusion notification. I tried to stick
1703         with the same names used by WebKit2.
1704
1705         * WebView/WebView.mm:
1706         (-[WebView _isViewVisible]):
1707         (-[WebView addWindowObserversForWindow:]):
1708         (-[WebView removeWindowObservers]):
1709         (-[WebView _windowDidChangeOcclusionState:]):
1710
1711 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1712
1713         Allow clients to set the navigator platform
1714         https://bugs.webkit.org/show_bug.cgi?id=192735
1715
1716         Reviewed by Tim Horton.
1717
1718         Add stubs to fill out the added functionality in FrameLoaderClient.
1719
1720         * WebCoreSupport/WebFrameLoaderClient.h:
1721         * WebCoreSupport/WebFrameLoaderClient.mm:
1722         (WebFrameLoaderClient::navigatorPlatform):
1723
1724 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1725
1726         offsetLeft and offsetParent should adjust across shadow boundaries
1727         https://bugs.webkit.org/show_bug.cgi?id=157437
1728         <rdar://problem/26154021>
1729
1730         Reviewed by Simon Fraser.
1731
1732         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1733
1734         * DOM/DOMElement.mm:
1735         (-[DOMElement offsetLeft]):
1736         (-[DOMElement offsetTop]):
1737         (-[DOMElement offsetParent]):
1738
1739 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1740
1741         Unreviewed build fix.
1742
1743         * WebView/WebFrame.mm:
1744         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1745
1746 2018-12-15  Darin Adler  <darin@apple.com>
1747
1748         Use warning-ignoring macros more consistently and simply
1749         https://bugs.webkit.org/show_bug.cgi?id=192743
1750
1751         Reviewed by Mark Lam.
1752
1753         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1754         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1755         compilers in Objective-C++ code.
1756
1757         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1758         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1759         accomodate non-clang compilers here. Also use #pragma once, add a missing
1760         "explicit" and fix conditionals.
1761
1762 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1763
1764         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1765         https://bugs.webkit.org/show_bug.cgi?id=192653
1766
1767         Reviewed by Wenson Hsieh.
1768
1769         * WebView/WebHTMLView.mm:
1770         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1771
1772 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1773
1774         Implement feature flag for CSS Typed OM
1775         https://bugs.webkit.org/show_bug.cgi?id=192610
1776
1777         Reviewed by Ryosuke Niwa.
1778
1779         * Configurations/FeatureDefines.xcconfig:
1780
1781 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1782
1783         WebCore shouldn't have a Objective-C class named NSCursor
1784         https://bugs.webkit.org/show_bug.cgi?id=192602
1785         <rdar://problem/46615532>
1786
1787         Reviewed by Wenson Hsieh.
1788
1789         * WebView/WebFrameView.mm:
1790         (-[WebFrameView keyDown:keyDown:]):
1791         * WebView/WebHTMLView.mm:
1792         (-[WebHTMLView keyDown:]):
1793         (-[WebHTMLView performKeyEquivalent:]):
1794         Only use NSCursor on macOS.
1795
1796 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1797
1798         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1799         https://bugs.webkit.org/show_bug.cgi?id=192573
1800
1801         Reviewed by Simon Fraser.
1802
1803         * Configurations/FeatureDefines.xcconfig:
1804
1805 2018-12-10  Antti Koivisto  <antti@apple.com>
1806
1807         Rename "forced style recalc" to "full style rebuild"
1808         https://bugs.webkit.org/show_bug.cgi?id=192572
1809
1810         Reviewed by Zalan Bujtas.
1811
1812         * WebView/WebHTMLView.mm:
1813         (-[WebHTMLView setNeedsToApplyStyles:]):
1814
1815 2018-12-10  Darin Adler  <darin@apple.com>
1816
1817         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1818         https://bugs.webkit.org/show_bug.cgi?id=192533
1819         rdar://problem/45732710
1820
1821         Reviewed by Anders Carlsson.
1822
1823         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1824         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1825
1826 2018-12-10  Darin Adler  <darin@apple.com>
1827
1828         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1829         https://bugs.webkit.org/show_bug.cgi?id=192532
1830         rdar://problem/45731047
1831
1832         Reviewed by Chris Dumez.
1833
1834         * Plugins/Hosted/NetscapePluginHostManager.mm:
1835         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1836         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1837         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1838
1839 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1840
1841         Turn WritingDirection into an enum class
1842         https://bugs.webkit.org/show_bug.cgi?id=192401
1843         Work towards <rdar://problem/42075638>
1844
1845         Reviewed by Dan Bernstein.
1846
1847         Change WritingDirection from an enum to an enum class. No change in behavior.
1848
1849         * WebView/WebHTMLView.mm:
1850         (-[WebHTMLView toggleBaseWritingDirection:]):
1851         (-[WebHTMLView changeBaseWritingDirection:]):
1852         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1853
1854 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1855
1856         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1857         https://bugs.webkit.org/show_bug.cgi?id=192272
1858
1859         Reviewed by Brady Eidson.
1860
1861         * WebCoreSupport/WebFrameLoaderClient.h:
1862         * WebCoreSupport/WebFrameLoaderClient.mm:
1863         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1864
1865 2018-12-03  Jer Noble  <jer.noble@apple.com>
1866
1867         Get rid of old, dead Mac video fullscreen code.
1868         https://bugs.webkit.org/show_bug.cgi?id=192315
1869
1870         Reviewed by Eric Carlson.
1871
1872         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1873         is no longer supported in the Mac port.
1874
1875         * WebView/WebVideoFullscreenController.h: Removed.
1876         * WebView/WebVideoFullscreenController.mm: Removed.
1877         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1878         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1879         * WebView/WebView.mm:
1880         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1881         (-[WebView _exitVideoFullscreen]):
1882
1883 2018-12-03  Daniel Bates  <dabates@apple.com>
1884
1885         [iOS] Do not handle key events that are key commands
1886         https://bugs.webkit.org/show_bug.cgi?id=191608
1887         <rdar://problem/46046013>
1888
1889         Reviewed by Ryosuke Niwa.
1890
1891         A key down event may be associated with a key command. If it is then we want to execute the
1892         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1893         event as a key command to find out.
1894
1895         * WebView/WebHTMLView.mm:
1896         (-[WebHTMLView _handleEditingKeyEvent:]):
1897
1898 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1899
1900         Add a runtime feature flag for LayoutFormattingContext.
1901         https://bugs.webkit.org/show_bug.cgi?id=192280
1902
1903         Reviewed by Simon Fraser.
1904
1905         * Configurations/FeatureDefines.xcconfig:
1906
1907 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1908
1909         Move URL from WebCore to WTF
1910         https://bugs.webkit.org/show_bug.cgi?id=190234
1911
1912         Reviewed by Keith Miller.
1913
1914         * DOM/DOMAttr.mm:
1915         * DOM/DOMBlob.mm:
1916         * DOM/DOMCSSCharsetRule.mm:
1917         * DOM/DOMCSSImportRule.mm:
1918         * DOM/DOMCSSMediaRule.mm:
1919         * DOM/DOMCSSPageRule.mm:
1920         * DOM/DOMCSSPrimitiveValue.mm:
1921         * DOM/DOMCSSRule.mm:
1922         * DOM/DOMCSSStyleDeclaration.mm:
1923         * DOM/DOMCSSStyleRule.mm:
1924         * DOM/DOMCSSStyleSheet.mm:
1925         * DOM/DOMCSSValue.mm:
1926         * DOM/DOMCharacterData.mm:
1927         * DOM/DOMCounter.mm:
1928         * DOM/DOMDocument.mm:
1929         * DOM/DOMDocumentFragment.mm:
1930         * DOM/DOMDocumentType.mm:
1931         * DOM/DOMEvent.mm:
1932         * DOM/DOMFile.mm:
1933         * DOM/DOMHTMLAnchorElement.mm:
1934         * DOM/DOMHTMLAppletElement.mm:
1935         * DOM/DOMHTMLAreaElement.mm:
1936         * DOM/DOMHTMLBRElement.mm:
1937         * DOM/DOMHTMLBaseElement.mm:
1938         * DOM/DOMHTMLBaseFontElement.mm:
1939         * DOM/DOMHTMLBodyElement.mm:
1940         * DOM/DOMHTMLButtonElement.mm:
1941         * DOM/DOMHTMLCanvasElement.mm:
1942         * DOM/DOMHTMLCollection.mm:
1943         * DOM/DOMHTMLDivElement.mm:
1944         * DOM/DOMHTMLDocument.mm:
1945         * DOM/DOMHTMLElement.mm:
1946         * DOM/DOMHTMLEmbedElement.mm:
1947         * DOM/DOMHTMLFieldSetElement.mm:
1948         * DOM/DOMHTMLFontElement.mm:
1949         * DOM/DOMHTMLFormElement.mm:
1950         * DOM/DOMHTMLFrameElement.mm:
1951         * DOM/DOMHTMLFrameSetElement.mm:
1952         * DOM/DOMHTMLHRElement.mm:
1953         * DOM/DOMHTMLHeadElement.mm:
1954         * DOM/DOMHTMLHeadingElement.mm:
1955         * DOM/DOMHTMLHtmlElement.mm:
1956         * DOM/DOMHTMLIFrameElement.mm:
1957         * DOM/DOMHTMLImageElement.mm:
1958         * DOM/DOMHTMLInputElement.mm:
1959         * DOM/DOMHTMLLIElement.mm:
1960         * DOM/DOMHTMLLabelElement.mm:
1961         * DOM/DOMHTMLLegendElement.mm:
1962         * DOM/DOMHTMLLinkElement.mm:
1963         * DOM/DOMHTMLMapElement.mm:
1964         * DOM/DOMHTMLMarqueeElement.mm:
1965         * DOM/DOMHTMLMediaElement.mm:
1966         * DOM/DOMHTMLMetaElement.mm:
1967         * DOM/DOMHTMLModElement.mm:
1968         * DOM/DOMHTMLOListElement.mm:
1969         * DOM/DOMHTMLObjectElement.mm:
1970         * DOM/DOMHTMLOptGroupElement.mm:
1971         * DOM/DOMHTMLOptionElement.mm:
1972         * DOM/DOMHTMLOptionsCollection.mm:
1973         * DOM/DOMHTMLParagraphElement.mm:
1974         * DOM/DOMHTMLParamElement.mm:
1975         * DOM/DOMHTMLQuoteElement.mm:
1976         * DOM/DOMHTMLScriptElement.mm:
1977         * DOM/DOMHTMLSelectElement.mm:
1978         * DOM/DOMHTMLStyleElement.mm:
1979         * DOM/DOMHTMLTableCaptionElement.mm:
1980         * DOM/DOMHTMLTableCellElement.mm:
1981         * DOM/DOMHTMLTableColElement.mm:
1982         * DOM/DOMHTMLTableElement.mm:
1983         * DOM/DOMHTMLTableRowElement.mm:
1984         * DOM/DOMHTMLTableSectionElement.mm:
1985         * DOM/DOMHTMLTitleElement.mm:
1986         * DOM/DOMHTMLUListElement.mm:
1987         * DOM/DOMHTMLVideoElement.mm:
1988         * DOM/DOMKeyboardEvent.mm:
1989         * DOM/DOMMediaList.mm:
1990         * DOM/DOMMouseEvent.mm:
1991         * DOM/DOMMutationEvent.mm:
1992         * DOM/DOMNamedNodeMap.mm:
1993         * DOM/DOMProcessingInstruction.mm:
1994         * DOM/DOMRange.mm:
1995         * DOM/DOMStyleSheet.mm:
1996         * DOM/DOMText.mm:
1997         * DOM/DOMTextEvent.mm:
1998         * DOM/DOMTokenList.mm:
1999         * DOM/DOMUIEvent.mm:
2000         * DOM/DOMXPathResult.mm:
2001         * History/WebHistoryItem.mm:
2002         * Misc/WebNSURLExtras.mm:
2003         (-[NSURL _web_userVisibleString]):
2004         (-[NSURL _web_URLByRemovingUserInfo]):
2005         (-[NSURL _web_dataForURLComponentType:]):
2006         (-[NSURL _web_schemeData]):
2007         (-[NSURL _web_hostData]):
2008         * Misc/WebUserContentURLPattern.mm:
2009         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2010         * Plugins/WebNetscapePluginStream.h:
2011         (WebNetscapePluginStream::setRequestURL):
2012         * WebCoreSupport/WebChromeClient.h:
2013         * WebCoreSupport/WebChromeClient.mm:
2014         (WebChromeClient::signedPublicKeyAndChallengeString const):
2015         * WebCoreSupport/WebContextMenuClient.h:
2016         * WebCoreSupport/WebContextMenuClient.mm:
2017         * WebCoreSupport/WebDragClient.h:
2018         * WebCoreSupport/WebFrameLoaderClient.h:
2019         * WebCoreSupport/WebFrameLoaderClient.mm:
2020         (WebFrameLoaderClient::updateGlobalHistory):
2021         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2022         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2023         (WebPaymentCoordinatorClient::showPaymentUI):
2024         * WebCoreSupport/WebPlatformStrategies.h:
2025         * WebCoreSupport/WebPlatformStrategies.mm:
2026         (WebPlatformStrategies::readURLFromPasteboard):
2027         * WebCoreSupport/WebPluginInfoProvider.h:
2028         * WebCoreSupport/WebPluginInfoProvider.mm:
2029         (WebPluginInfoProvider::webVisiblePluginInfo):
2030         * WebCoreSupport/WebSecurityOrigin.mm:
2031         * WebCoreSupport/WebVisitedLinkStore.h:
2032         * WebView/WebDataSource.mm:
2033         * WebView/WebFrame.mm:
2034         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
2035         * WebView/WebImmediateActionController.mm:
2036         (-[WebImmediateActionController _defaultAnimationController]):
2037         * WebView/WebPDFView.mm:
2038         * WebView/WebScriptDebugger.mm:
2039         * WebView/WebViewInternal.h:
2040
2041 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
2042
2043         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
2044         https://bugs.webkit.org/show_bug.cgi?id=192197
2045
2046         Reviewed by Jiewen Tan.
2047
2048         * Configurations/FeatureDefines.xcconfig:
2049         * WebCoreSupport/WebChromeClient.h:
2050         * WebCoreSupport/WebChromeClient.mm:
2051
2052 2018-11-28  Alex Christensen  <achristensen@webkit.org>
2053
2054         Remove dead code from an earlier attempt at implementing safe browsing
2055         https://bugs.webkit.org/show_bug.cgi?id=192067
2056
2057         Reviewed by Chris Dumez.
2058
2059         * WebCoreSupport/WebFrameLoaderClient.h:
2060         * WebCoreSupport/WebFrameLoaderClient.mm:
2061         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2062
2063 2018-11-27  Mark Lam  <mark.lam@apple.com>
2064
2065         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
2066         https://bugs.webkit.org/show_bug.cgi?id=192055
2067         <rdar://problem/46288783>
2068
2069         Reviewed by Saam Barati.
2070
2071         * Configurations/FeatureDefines.xcconfig:
2072
2073 2018-11-25  Tim Horton  <timothy_horton@apple.com>
2074
2075         Make it possible to insert editable images with a gesture
2076         https://bugs.webkit.org/show_bug.cgi?id=191937
2077
2078         Reviewed by Wenson Hsieh.
2079
2080         * WebCoreSupport/WebEditorClient.mm:
2081         (undoNameForEditAction):
2082         Add a undo name.
2083
2084 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2085
2086         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
2087         https://bugs.webkit.org/show_bug.cgi?id=191945
2088
2089         Reviewed by Anders Carlsson.
2090
2091         * WebCoreSupport/WebEditorClient.mm:
2092         (undoNameForEditAction):
2093
2094 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2095
2096         Enable drag and drop support for iOSMac
2097         https://bugs.webkit.org/show_bug.cgi?id=191818
2098         <rdar://problem/43907454>
2099
2100         Reviewed by Dean Jackson.
2101
2102         * Configurations/FeatureDefines.xcconfig:
2103
2104 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2105
2106         Address post-review feedback after r238438
2107         https://bugs.webkit.org/show_bug.cgi?id=191913
2108
2109         Reviewed by Ryosuke Niwa.
2110
2111         * WebView/WebFrame.mm:
2112         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
2113         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2114         * WebView/WebView.mm:
2115         (-[WebView setSelectedDOMRange:affinity:]):
2116
2117 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
2118
2119         Web Inspector: "Reload Web Inspector" button no longer partially works
2120         https://bugs.webkit.org/show_bug.cgi?id=191773
2121         <rdar://problem/46139932>
2122
2123         Reviewed by Devin Rousso.
2124
2125         * WebCoreSupport/WebInspectorClient.h:
2126         * WebCoreSupport/WebInspectorClient.mm:
2127         (WebInspectorFrontendClient::reopen):
2128
2129 2018-11-17  Devin Rousso  <drousso@apple.com>
2130
2131         Web Inspector: Network: add button to show system certificate dialog
2132         https://bugs.webkit.org/show_bug.cgi?id=191458
2133         <rdar://problem/45977019>
2134
2135         Reviewed by Joseph Pecoraro.
2136
2137         * WebCoreSupport/WebInspectorClient.h:
2138         * WebCoreSupport/WebInspectorClient.mm:
2139         (WebInspectorFrontendClient::showCertificate): Added.
2140
2141         * Configurations/WebKitLegacy.xcconfig:
2142
2143 2018-11-15  Truitt Savell  <tsavell@apple.com>
2144
2145         Unreviewed, rolling out r238244.
2146
2147         Caused High Sierra test runs to fail early with 50 crashes and
2148         casued 25 API failures.
2149
2150         Reverted changeset:
2151
2152         "[css-logical] Implement flow-relative margin, padding and
2153         border shorthands"
2154         https://bugs.webkit.org/show_bug.cgi?id=188697
2155         https://trac.webkit.org/changeset/238244
2156
2157 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
2158
2159         [css-logical] Implement flow-relative margin, padding and border shorthands
2160         https://bugs.webkit.org/show_bug.cgi?id=188697
2161
2162         Reviewed by Simon Fraser and Antti Koivisto.
2163
2164         Add CSSLogicalEnabled runtime flag.
2165
2166         * WebView/WebPreferenceKeysPrivate.h:
2167         * WebView/WebPreferences.mm:
2168         (+[WebPreferences initialize]):
2169         (-[WebPreferences cssLogicalEnabled]):
2170         (-[WebPreferences setCSSLogicalEnabled:]):
2171         * WebView/WebPreferencesPrivate.h:
2172         * WebView/WebView.mm:
2173         (-[WebView _preferencesChanged:]):
2174
2175 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2176
2177         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
2178         https://bugs.webkit.org/show_bug.cgi?id=191612
2179
2180         Reviewed by Matt Baker.
2181
2182         * WebCoreSupport/WebInspectorClient.mm:
2183         (-[WebInspectorWindowController destroyInspectorView]):
2184
2185 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2186
2187         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
2188         https://bugs.webkit.org/show_bug.cgi?id=191494
2189         <rdar://problem/45469854>
2190
2191         Reviewed by Devin Rousso.
2192
2193         * WebCoreSupport/WebInspectorClient.h:
2194         WebKitLegacy will still have remote inspection of the Page directly.
2195
2196 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
2197
2198         Make compositing updates incremental
2199         https://bugs.webkit.org/show_bug.cgi?id=90342
2200
2201         Reviewed by Antti Koivisto.
2202
2203         Fix spelling error.
2204
2205         * WebView/WebView.mm:
2206         (-[WebView _setMediaLayer:forPluginView:]):
2207
2208 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2209
2210         Implement a new edit command to change the enclosing list type
2211         https://bugs.webkit.org/show_bug.cgi?id=191487
2212         <rdar://problem/45955922>
2213
2214         Reviewed by Ryosuke Niwa.
2215
2216         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
2217
2218         * WebCoreSupport/WebEditorClient.mm:
2219         (undoNameForEditAction):
2220
2221 2018-11-11  Daniel Bates  <dabates@apple.com>
2222
2223         [iOS] Draw caps lock indicator in password fields
2224         https://bugs.webkit.org/show_bug.cgi?id=190565
2225         <rdar://problem/45262343>
2226
2227         Reviewed by Dean Jackson.
2228
2229         Update the caps lock state when a hardware keyboard is attached or detached.
2230
2231         * WebView/WebHTMLView.mm:
2232         (hardwareKeyboardAvailabilityChangedCallback): Added.
2233         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2234         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2235
2236 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
2237
2238         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2239         https://bugs.webkit.org/show_bug.cgi?id=191492
2240
2241         Reviewed by Alex Christensen.
2242
2243         * Carbon/HIWebView.mm:
2244         * Misc/WebNSFileManagerExtras.mm:
2245         * Misc/WebNSURLExtras.mm:
2246         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2247         * Plugins/WebBasePluginPackage.mm:
2248         * Plugins/WebPluginContainerCheck.mm:
2249         * WebCoreSupport/WebCachedFramePlatformData.h:
2250         * WebCoreSupport/WebDeviceOrientationClient.mm:
2251         * WebView/WebDelegateImplementationCaching.mm:
2252         * WebView/WebHTMLView.mm:
2253         * WebView/WebPDFRepresentation.mm:
2254         * WebView/WebPolicyDelegate.mm:
2255         * WebView/WebView.mm:
2256
2257 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
2258
2259         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2260         https://bugs.webkit.org/show_bug.cgi?id=191492
2261
2262         Reviewed by Alex Christensen.
2263
2264         * Carbon/HIWebView.mm:
2265         (UpdateCommandStatus):
2266         * Misc/WebNSFileManagerExtras.mm:
2267         * Misc/WebNSURLExtras.mm:
2268         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2269         * Plugins/WebBasePluginPackage.mm:
2270         * Plugins/WebPluginContainerCheck.mm:
2271         (-[WebPluginContainerCheck _continueWithPolicy:]):
2272         * WebCoreSupport/WebCachedFramePlatformData.h:
2273         (WebCachedFramePlatformData::clear):
2274         * WebCoreSupport/WebDeviceOrientationClient.mm:
2275         (WebDeviceOrientationClient::getProvider const):
2276         * WebView/WebDelegateImplementationCaching.mm:
2277         (CallDelegate):
2278         (CallDelegateReturningBoolean):
2279         (CallResourceLoadDelegateReturningBoolean):
2280         (CallFormDelegate):
2281         (CallFormDelegateReturningBoolean):
2282         * WebView/WebHTMLView.mm:
2283         * WebView/WebPDFRepresentation.mm:
2284         * WebView/WebPolicyDelegate.mm:
2285         (-[WebPolicyDecisionListener _usePolicy:]):
2286         * WebView/WebView.mm:
2287
2288 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
2289
2290         Unreviewed, rolling out r238047.
2291
2292         Introduced layout test failures on iOS simulator.
2293
2294         Reverted changeset:
2295
2296         "[iOS] Draw caps lock indicator in password fields"
2297         https://bugs.webkit.org/show_bug.cgi?id=190565
2298         https://trac.webkit.org/changeset/238047
2299
2300 2018-11-09  Antti Koivisto  <antti@apple.com>
2301
2302         Use OptionSet for layout milestones
2303         https://bugs.webkit.org/show_bug.cgi?id=191470
2304
2305         Reviewed by Dean Jackson.
2306
2307         * WebCoreSupport/WebFrameLoaderClient.h:
2308         * WebCoreSupport/WebFrameLoaderClient.mm:
2309         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2310         * WebView/WebView.mm:
2311         (coreLayoutMilestones):
2312         (kitLayoutMilestones):
2313         (-[WebView _cacheFrameLoadDelegateImplementations]):
2314         * WebView/WebViewInternal.h:
2315
2316 2018-11-09  Daniel Bates  <dabates@apple.com>
2317
2318         [iOS] Draw caps lock indicator in password fields
2319         https://bugs.webkit.org/show_bug.cgi?id=190565
2320         <rdar://problem/45262343>
2321
2322         Reviewed by Dean Jackson.
2323
2324         Update the caps lock state when a hardware keyboard is attached or detached.
2325
2326         * WebView/WebHTMLView.mm:
2327         (hardwareKeyboardAvailabilityChangedCallback): Added.
2328         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2329         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2330
2331 2018-11-09  Daniel Bates  <dabates@apple.com>
2332
2333         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
2334         action when forward delete is pressed outside a text field
2335         https://bugs.webkit.org/show_bug.cgi?id=190566
2336         <rdar://problem/45262367>
2337
2338         Reviewed by Wenson Hsieh.
2339
2340         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
2341         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
2342         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
2343
2344         * WebView/WebHTMLView.mm:
2345         (-[WebHTMLView _handleEditingKeyEvent:]):
2346
2347 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
2348
2349         Adopt Reveal Framework to replace Lookup
2350         https://bugs.webkit.org/show_bug.cgi?id=191097
2351         <rdar://problem/45924508>
2352
2353         Reviewed by Tim Horton.
2354
2355         Pass in what it needed to clear the textIndicators. This is better than
2356         the current notification structure.
2357
2358         * WebView/WebView.mm:
2359         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2360         (-[WebView _prepareForDictionaryLookup]):
2361
2362 2018-11-06  Justin Fan  <justin_fan@apple.com>
2363
2364         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2365         https://bugs.webkit.org/show_bug.cgi?id=191291
2366
2367         Reviewed by Myles Maxfield.
2368
2369         Properly disable WEBGPU on all non-Metal platforms for now.
2370
2371         * Configurations/FeatureDefines.xcconfig:
2372
2373 2018-11-02  Daniel Bates  <dabates@apple.com>
2374
2375         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2376         https://bugs.webkit.org/show_bug.cgi?id=190487
2377
2378         Reviewed by Tim Horton.
2379
2380         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
2381         allow the default handling.
2382
2383         * WebView/WebHTMLView.mm:
2384         (-[WebHTMLView _handleEditingKeyEvent:]):
2385
2386 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2387
2388         Add a storage limit for IndexedDB
2389         https://bugs.webkit.org/show_bug.cgi?id=190598
2390         <rdar://problem/44654715>
2391
2392         Reviewed by Chris Dumez.
2393
2394         * Storage/WebDatabaseManager.mm:
2395         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2396         * Storage/WebDatabaseManagerPrivate.h:
2397
2398 2018-10-31  Antti Koivisto  <antti@apple.com>
2399
2400         Remove LayerFlushScheduler
2401         https://bugs.webkit.org/show_bug.cgi?id=191103
2402
2403         Reviewed by Anders Carlsson.
2404
2405         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2406         all the virtual cruft.
2407
2408         * WebView/WebViewData.h:
2409         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2410         (): Deleted.
2411         * WebView/WebViewData.mm:
2412         (currentRunLoop):
2413         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2414         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2415         (WebViewLayerFlushScheduler::schedule):
2416         (WebViewLayerFlushScheduler::invalidate):
2417         (WebViewLayerFlushScheduler::layerFlushCallback):
2418
2419 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2420
2421         Enable InstallAPI for iOS unconditionally
2422         https://bugs.webkit.org/show_bug.cgi?id=191043
2423         rdar://problem/32728423
2424
2425         Reviewed by Dan Bernstein.
2426
2427         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2428         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2429         shouldn't be processed by InstallAPI.
2430         * MigrateHeaders.make: Removed an obsolete workaround.
2431         * Misc/NSURLDownloadSPI.h: Added.
2432         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2433
2434 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2435
2436         Clean up some obsolete MAX_ALLOWED macros
2437         https://bugs.webkit.org/show_bug.cgi?id=190916
2438
2439         Reviewed by Tim Horton.
2440
2441         * WebView/WebHTMLView.mm:
2442         (-[WebHTMLView pressureChangeWithEvent:]):
2443         * WebView/WebPDFView.h:
2444
2445 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2446
2447         Unreviewed, rolling out r237600 and r237604.
2448         https://bugs.webkit.org/show_bug.cgi?id=191086
2449
2450         Breaks internal iOS builds (Requested by ryanhadd_ on
2451         #webkit).
2452
2453         Reverted changesets:
2454
2455         "Enable InstallAPI for iOS unconditionally"
2456         https://bugs.webkit.org/show_bug.cgi?id=191043
2457         https://trac.webkit.org/changeset/237600
2458
2459         "Build fix attempt after enabling InstallAPI for iOS."
2460         https://bugs.webkit.org/show_bug.cgi?id=191043
2461         https://trac.webkit.org/changeset/237604
2462
2463 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2464
2465         Enable InstallAPI for iOS unconditionally
2466         https://bugs.webkit.org/show_bug.cgi?id=191043
2467         rdar://problem/32728423
2468
2469         Reviewed by Dan Bernstein.
2470
2471         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2472         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2473         shouldn't be processed by InstallAPI.
2474         * MigrateHeaders.make: Removed an obsolete workaround.
2475         * Misc/NSURLDownloadSPI.h: Added.
2476         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2477
2478 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2479
2480         Modernize WebKit nibs and lprojs for localization's sake
2481         https://bugs.webkit.org/show_bug.cgi?id=190911
2482         <rdar://problem/45349466>
2483
2484         Reviewed by Dan Bernstein.
2485
2486         * Misc/WebNSControlExtras.m:
2487         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2488         NSWindow and its contents are both in the same scale space these days; avoid
2489         double-applying the scale factor, or you can't see the prompt.
2490
2491         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2492         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2493         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2494         NIB->XIB
2495
2496 2018-10-25  Antoine Quint  <graouts@apple.com>
2497
2498         [Web Animations] Turn Web Animations CSS Integration off by default
2499         https://bugs.webkit.org/show_bug.cgi?id=190901
2500
2501         Reviewed by Dean Jackson.
2502
2503         * WebView/WebPreferences.mm:
2504         (+[WebPreferences initialize]):
2505
2506 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2507
2508         Clean up some obsolete macOS version guards
2509         https://bugs.webkit.org/show_bug.cgi?id=190887
2510
2511         Reviewed by Dan Bernstein.
2512
2513         * Misc/WebNSPasteboardExtras.mm:
2514         (+[NSPasteboard _web_dragTypesForURL]):
2515         * WebCoreSupport/PopupMenuMac.mm:
2516         (PopupMenuMac::show):
2517         * WebCoreSupport/WebEditorClient.h:
2518         * WebCoreSupport/WebEditorClient.mm:
2519         (WebEditorClient::respondToChangedSelection):
2520         * WebView/WebPDFView.mm:
2521         (-[WebPDFView _clipViewForPDFDocumentView]):
2522
2523 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2524
2525         Turn on Conic Gradients
2526         https://bugs.webkit.org/show_bug.cgi?id=190810
2527
2528         Reviewed by Tim Horton.
2529
2530         * Configurations/FeatureDefines.xcconfig:
2531
2532 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2533
2534         Cleanup: MIMETypeRegistry functions
2535         https://bugs.webkit.org/show_bug.cgi?id=190838
2536
2537         Reviewed by Simon Fraser.
2538
2539         * Misc/WebNSPasteboardExtras.mm:
2540         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2541         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2542         because they were identical.
2543
2544         * WebView/WebHTMLRepresentation.mm:
2545         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2546         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2547         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2548         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2549         * WebView/WebView.mm:
2550         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2551         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2552         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2553
2554 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2555
2556         Fix false positive leaks when using custom -init methods that don't start with -init
2557         <https://webkit.org/b/190818>
2558         <rdar://problem/45476042>
2559
2560         Reviewed by Dan Bernstein.
2561
2562         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2563         it is accessible by both categories.
2564         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2565         NSError (WebKitInternal) category.  Add attribute to make this
2566         behave like an -init method.
2567         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2568         NSError (WebKitInternal) category.  Modernize method.  Replace
2569         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2570
2571 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2572
2573         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2574         https://bugs.webkit.org/show_bug.cgi?id=190729
2575
2576         Reviewed by Tim Horton.
2577
2578         * DOM/DOM.mm:
2579         (-[DOMNode boundingBox]):
2580         * DOM/DOMElement.mm:
2581         * DOM/DOMHTML.mm:
2582         * DOM/DOMInternal.mm:
2583         * DOM/DOMUIKitExtensions.mm:
2584         * DOM/WebDOMOperations.mm:
2585         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2586         * DefaultDelegates/WebDefaultEditingDelegate.m:
2587         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2588         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2589         * DefaultDelegates/WebDefaultUIDelegate.h:
2590         * DefaultDelegates/WebDefaultUIDelegate.mm:
2591         (-[WebDefaultUIDelegate webViewClose:]):
2592         (-[WebDefaultUIDelegate webViewFocus:]):
2593         (-[WebDefaultUIDelegate webViewUnfocus:]):
2594         (-[WebDefaultUIDelegate webViewIsResizable:]):
2595         (-[WebDefaultUIDelegate webView:setResizable:]):
2596         (-[WebDefaultUIDelegate webView:setFrame:]):
2597         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2598         * History/BackForwardList.h:
2599         * History/BackForwardList.mm:
2600         * History/WebBackForwardList.mm:
2601         (+[WebBackForwardList initialize]):
2602         (bumperCarBackForwardHackNeeded):
2603         * History/WebHistory.mm:
2604         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2605         (-[WebHistory _sendNotification:entries:]):
2606         (-[WebHistory loadFromURL:error:]):
2607         (-[WebHistory saveToURL:error:]):
2608         * History/WebHistoryItem.mm:
2609         (WKNotifyHistoryItemChanged):
2610         (+[WebHistoryItem initialize]):
2611         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2612         * History/WebURLsWithTitles.m:
2613         * Misc/WebCache.mm:
2614         (+[WebCache initialize]):
2615         * Misc/WebDownload.mm:
2616         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2617         * Misc/WebElementDictionary.mm:
2618         (+[WebElementDictionary initialize]):
2619         (+[WebElementDictionary initializeLookupTable]):
2620         * Misc/WebIconDatabase.mm:
2621         * Misc/WebKitNSStringExtras.mm:
2622         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2623         * Misc/WebKitVersionChecks.h:
2624         * Misc/WebKitVersionChecks.mm:
2625         (WebKitLinkedOnOrAfter):
2626         (WebKitLinkTimeVersion):
2627         * Misc/WebLocalizableStrings.mm:
2628         * Misc/WebNSControlExtras.h:
2629         * Misc/WebNSControlExtras.m:
2630         * Misc/WebNSEventExtras.m:
2631         * Misc/WebNSFileManagerExtras.mm:
2632         * Misc/WebNSImageExtras.h:
2633         * Misc/WebNSImageExtras.m:
2634         * Misc/WebNSPasteboardExtras.mm:
2635         * Misc/WebNSPrintOperationExtras.h:
2636         * Misc/WebNSPrintOperationExtras.m:
2637         * Misc/WebNSViewExtras.m:
2638         * Misc/WebNSWindowExtras.m:
2639         * Panels/WebAuthenticationPanel.h:
2640         * Panels/WebAuthenticationPanel.m:
2641         * Panels/WebPanelAuthenticationHandler.m:
2642         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2643         (+[WebHostedNetscapePluginView initialize]):
2644         * Plugins/WebBasePluginPackage.h:
2645         * Plugins/WebBasePluginPackage.mm:
2646         * Plugins/WebJavaPlugIn.h:
2647         * Plugins/WebPluginContainerCheck.mm:
2648         * Plugins/WebPluginController.h:
2649         * Plugins/WebPluginController.mm:
2650         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2651         (-[WebPluginController addPlugin:]):
2652         (-[WebPluginController destroyPlugin:]):
2653         (-[WebPluginController destroyAllPlugins]):
2654         * Plugins/WebPluginDatabase.mm:
2655         (+[WebPluginDatabase _defaultPlugInPaths]):
2656         * Plugins/WebPluginPackage.mm:
2657         (-[WebPluginPackage initWithPath:]):
2658         * Storage/WebDatabaseManager.mm:
2659         (-[WebDatabaseManager deleteAllDatabases]):
2660         * Storage/WebDatabaseManagerClient.h:
2661         * Storage/WebDatabaseManagerClient.mm:
2662         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2663         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2664         * Storage/WebStorageManager.mm:
2665         (-[WebStorageManager deleteAllOrigins]):
2666         (WebKitInitializeStorageIfNecessary):
2667         * WebCoreSupport/WebAlternativeTextClient.h:
2668         * WebCoreSupport/WebApplicationCache.mm:
2669         (applicationCacheBundleIdentifier):
2670         * WebCoreSupport/WebChromeClient.h:
2671         * WebCoreSupport/WebChromeClient.mm:
2672         (WebChromeClient::setWindowRect):
2673         (WebChromeClient::windowRect):
2674         (WebChromeClient::takeFocus):
2675         (WebChromeClient::addMessageToConsole):
2676         (WebChromeClient::enableSuddenTermination):
2677         (WebChromeClient::disableSuddenTermination):
2678         (WebChromeClient::createPopupMenu const):
2679         (WebChromeClient::createSearchPopupMenu const):
2680         (WebChromeClient::shouldPaintEntireContents const):
2681         (WebChromeClient::supportsVideoFullscreen):
2682         (WebChromeClient::supportsFullScreenForElement):
2683         (WebChromeClient::enterFullScreenForElement):
2684         (WebChromeClient::exitFullScreenForElement):
2685         * WebCoreSupport/WebContextMenuClient.mm:
2686         * WebCoreSupport/WebDragClient.mm:
2687         * WebCoreSupport/WebEditorClient.h:
2688         * WebCoreSupport/WebEditorClient.mm:
2689         (+[WebUndoStep initialize]):
2690         (updateFontPanel):
2691         (WebEditorClient::didBeginEditing):
2692         (WebEditorClient::respondToChangedContents):
2693         (WebEditorClient::respondToChangedSelection):
2694         (WebEditorClient::canceledComposition):
2695         (WebEditorClient::didEndEditing):
2696         (WebEditorClient::didWriteSelectionToPasteboard):
2697         (attributesForAttributedStringConversion):
2698         (WebEditorClient::setInsertionPasteboard):
2699         (WebEditorClient::registerUndoOrRedoStep):
2700         (WebEditorClient::handleKeyboardEvent):
2701         (WebEditorClient::handleInputMethodKeydown):
2702         (WebEditorClient::textDidChangeInTextField):
2703         (WebEditorClient::requestCheckingOfString):
2704         * WebCoreSupport/WebFrameLoaderClient.h:
2705         * WebCoreSupport/WebFrameLoaderClient.mm:
2706         (WebFrameLoaderClient::detachedFromParent2):
2707         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2708         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2709         (WebFrameLoaderClient::dispatchWillSendRequest):
2710         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2711         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2712         (WebFrameLoaderClient::willCacheResponse const):
2713         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2714         (WebFrameLoaderClient::dispatchDidFinishLoading):
2715         (WebFrameLoaderClient::dispatchDidFailLoading):
2716         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2717         (WebFrameLoaderClient::dispatchWillClose):
2718         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2719         (WebFrameLoaderClient::dispatchDidCommitLoad):
2720         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2721         (WebFrameLoaderClient::dispatchDidFailLoad):
2722         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2723         (WebFrameLoaderClient::dispatchDidFinishLoad):
2724         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2725         (WebFrameLoaderClient::willChangeTitle):
2726         (WebFrameLoaderClient::didChangeTitle):
2727         (WebFrameLoaderClient::didReplaceMultipartContent):
2728         (WebFrameLoaderClient::updateGlobalHistory):
2729         (WebFrameLoaderClient::saveViewStateToItem):
2730         (WebFrameLoaderClient::restoreViewState):
2731         (WebFrameLoaderClient::provisionalLoadStarted):
2732         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2733         (WebFrameLoaderClient::setTitle):
2734         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2735         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2736         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2737         (WebFrameLoaderClient::didRestoreFromPageCache):
2738         (WebFrameLoaderClient::actionDictionary const):
2739         (WebFrameLoaderClient::createPlugin):
2740         (WebFrameLoaderClient::getLoadDecisionForIcons):
2741         (WebFrameLoaderClient::finishedLoadingIcon):
2742         (+[WebFramePolicyListener initialize]):
2743         * WebCoreSupport/WebFrameNetworkingContext.mm:
2744         * WebCoreSupport/WebGeolocationClient.h:
2745         * WebCoreSupport/WebGeolocationClient.mm:
2746         (WebGeolocationClient::requestPermission):
2747         * WebCoreSupport/WebInspectorClient.h:
2748         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2749         * WebCoreSupport/WebNotificationClient.mm:
2750         * WebCoreSupport/WebOpenPanelResultListener.mm:
2751         * WebCoreSupport/WebPlatformStrategies.h:
2752         * WebCoreSupport/WebPlatformStrategies.mm:
2753         * WebCoreSupport/WebProgressTrackerClient.h:
2754         * WebCoreSupport/WebProgressTrackerClient.mm:
2755         (WebProgressTrackerClient::progressStarted):
2756         (WebProgressTrackerClient::progressEstimateChanged):
2757         (WebProgressTrackerClient::progressFinished):
2758         * WebCoreSupport/WebSecurityOrigin.mm:
2759         * WebInspector/WebNodeHighlight.h:
2760         * WebInspector/WebNodeHighlight.mm:
2761         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2762         (-[WebNodeHighlight dealloc]):
2763         (-[WebNodeHighlight attach]):
2764         * WebInspector/WebNodeHighlightView.h:
2765         * WebInspector/WebNodeHighlightView.mm:
2766         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2767         (-[WebNodeHighlightView dealloc]):
2768         * WebInspector/WebNodeHighlighter.mm:
2769         (-[WebNodeHighlighter highlight]):
2770         * WebView/WebArchive.mm:
2771         (+[WebArchivePrivate initialize]):
2772         * WebView/WebClipView.h:
2773         * WebView/WebDataSource.mm:
2774         (WebDataSourcePrivate::WebDataSourcePrivate):
2775         (+[WebDataSource initialize]):
2776         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2777         (-[WebDataSource _makeRepresentation]):
2778         * WebView/WebDelegateImplementationCaching.h:
2779         * WebView/WebDelegateImplementationCaching.mm:
2780         (CallDelegate):
2781         (CallDelegateReturningFloat):
2782         (CallDelegateReturningBoolean):
2783         (CallUIDelegate):
2784         (CallUIDelegateReturningFloat):
2785         (CallUIDelegateReturningBoolean):
2786         (CallFrameLoadDelegate):
2787         (CallFrameLoadDelegateReturningBoolean):
2788         (CallResourceLoadDelegate):
2789         (CallScriptDebugDelegate):
2790         (CallFormDelegate):
2791         (CallFormDelegateReturningBoolean):
2792         * WebView/WebDeviceOrientation.mm:
2793         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2794         * WebView/WebDocumentInternal.h:
2795         * WebView/WebDocumentLoaderMac.mm:
2796         (needsDataLoadWorkaround):
2797         * WebView/WebDynamicScrollBarsViewInternal.h:
2798         * WebView/WebFormDelegate.m:
2799         * WebView/WebFrame.mm:
2800         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2801         (-[WebFrame _unmarkAllMisspellings]):
2802         (-[WebFrame _paintBehaviorForDestinationContext:]):
2803         (-[WebFrame _drawRect:contentsOnly:]):
2804         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2805         (-[WebFrame _scrollDOMRangeToVisible:]):
2806         (-[WebFrame _bodyBackgroundColor]):
2807         (-[WebFrame accessibilityRoot]):
2808         (needsMicrosoftMessengerDOMDocumentWorkaround):
2809         * WebView/WebFrameInternal.h:
2810         * WebView/WebFrameView.mm:
2811         (-[WebFrameView _setDocumentView:]):
2812         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2813         (-[WebFrameView _viewClassForMIMEType:]):
2814         (-[WebFrameView initWithFrame:]):
2815         (-[WebFrameView drawRect:]):
2816         (-[WebFrameView _firstResponderIsFormControl]):
2817         (-[WebFrameView keyDown:keyDown:]):
2818         (-[WebFrameView _isScrollable]):
2819         * WebView/WebFullScreenController.h:
2820         * WebView/WebFullScreenController.mm:
2821         * WebView/WebHTMLRepresentation.mm:
2822         * WebView/WebHTMLView.mm:
2823         (-[WebHTMLView hitTest:]):
2824         (-[WebHTMLView initWithFrame:]):
2825         (-[WebHTMLView dealloc]):
2826         (-[WebHTMLView addSubview:]):
2827         (-[WebHTMLView mouseDown:]):
2828         (-[WebHTMLView mouseUp:]):
2829         (-[WebHTMLView resignFirstResponder]):
2830         (-[WebHTMLView accessibilityHitTest:]):
2831         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2832         * WebView/WebHTMLViewInternal.h:
2833         * WebView/WebIndicateLayer.h:
2834         * WebView/WebIndicateLayer.mm:
2835         * WebView/WebMediaPlaybackTargetPicker.h:
2836         * WebView/WebMediaPlaybackTargetPicker.mm:
2837         * WebView/WebPDFDocumentExtras.h:
2838         * WebView/WebPDFDocumentExtras.mm:
2839         * WebView/WebPDFRepresentation.h:
2840         * WebView/WebPDFRepresentation.mm:
2841         * WebView/WebPDFView.h:
2842         * WebView/WebPreferences.mm:
2843         (cacheModelForMainBundle):
2844         (WebPreferencesPrivate::WebPreferencesPrivate):
2845         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2846         (-[WebPreferences encodeWithCoder:]):
2847         (+[WebPreferences standardPreferences]):
2848         (+[WebPreferences initialize]):
2849         (-[WebPreferences _valueForKey:]):
2850         (-[WebPreferences _setStringValue:forKey:]):
2851         (-[WebPreferences _setIntegerValue:forKey:]):
2852         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2853         (-[WebPreferences _setFloatValue:forKey:]):
2854         (-[WebPreferences _setBoolValue:forKey:]):
2855         (-[WebPreferences _setLongLongValue:forKey:]):
2856         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2857         (-[WebPreferences _postCacheModelChangedNotification]):
2858         (-[WebPreferences _postPreferencesChangedNotification]):
2859         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2860         (-[WebPreferences setStorageBlockingPolicy:]):
2861         * WebView/WebResource.mm:
2862         (+[WebResourcePrivate initialize]):
2863         * WebView/WebTextCompletionController.h:
2864         * WebView/WebTextIterator.mm:
2865         (+[WebTextIteratorPrivate initialize]):
2866         * WebView/WebView.mm:
2867         (shouldEnableLoadDeferring):
2868         (shouldRestrictWindowFocus):
2869         (shouldRespectPriorityInCSSAttributeSetters):
2870         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2871         (shouldAllowPictureInPictureMediaPlayback):
2872         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2873         (shouldAllowWindowOpenWithoutUserGesture):
2874         (shouldConvertInvalidURLsToBlank):
2875         (shouldRequireUserGestureToLoadVideo):
2876         (-[WebView _commonInitializationWithFrameName:groupName:]):
2877         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2878         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2879         (-[WebView _closePluginDatabases]):
2880         (-[WebView _closeWithFastTeardown]):
2881         (-[WebView _close]):
2882         (+[WebView _MIMETypeForFile:]):
2883         (-[WebView setShowingInspectorIndication:]):
2884         (-[WebView _setFormDelegate:]):
2885         (-[WebView _needsPreHTML5ParserQuirks]):
2886         (-[WebView _preferencesChangedNotification:]):
2887         (-[WebView _preferencesChanged:]):
2888         (-[WebView _cacheResourceLoadDelegateImplementations]):
2889         (-[WebView _cacheFrameLoadDelegateImplementations]):
2890         (-[WebView _policyDelegateForwarder]):
2891         (-[WebView _UIDelegateForwarder]):
2892         (-[WebView _editingDelegateForwarder]):
2893         (-[WebView _updateActiveState]):
2894         (-[_WebSafeForwarder forwardInvocation:]):
2895         (+[WebView initialize]):
2896         (-[WebView _pluginForMIMEType:]):
2897         (-[WebView _pluginForExtension:]):
2898         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2899         (+[WebView canShowMIMETypeAsHTML:]):
2900         (-[WebView _initWithArguments:]):
2901         (-[WebView initWithFrame:frameName:groupName:]):
2902         (-[WebView dealloc]):
2903         (-[WebView close]):
2904         (-[WebView viewDidMoveToWindow]):
2905         (-[WebView setUIDelegate:]):
2906         (-[WebView setResourceLoadDelegate:]):
2907         (-[WebView setPolicyDelegate:]):
2908         (-[WebView setFrameLoadDelegate:]):
2909         (-[WebView goBack]):
2910         (-[WebView goForward]):
2911         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2912         (-[WebView setHostWindow:]):
2913         (-[WebView becomeFirstResponder]):
2914         (+[WebView _cacheModelChangedNotification:]):
2915         (-[WebView _frameViewAtWindowPoint:]):
2916         (+[WebView _preflightSpellCheckerNow:]):
2917         (+[WebView _preflightSpellChecker]):
2918         (-[WebView canGoBack]):
2919         (-[WebView canGoForward]):
2920         (-[WebView stopLoading:]):
2921         (-[WebView reload:]):
2922         (-[WebView setMainFrameDocumentReady:]):
2923         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2924         (-[WebView setContinuousSpellCheckingEnabled:]):
2925         (-[WebView undoManager]):
2926         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2927         (-[WebView isAutomaticLinkDetectionEnabled]):
2928         (-[WebView isAutomaticDashSubstitutionEnabled]):
2929         (-[WebView isAutomaticTextReplacementEnabled]):
2930         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2931         (+[WebView _setCacheModel:]):
2932         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2933         (-[WebView _keyboardUIMode]):
2934         (LayerFlushController::flushLayers):
2935         (-[WebView _scheduleCompositingLayerFlush]):
2936         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2937         (-[WebView fullScreenPlaceholderView]):
2938         (WebInstallMemoryPressureHandler):
2939         * WebView/WebViewData.h:
2940         * WebView/WebViewData.mm:
2941         (+[WebViewPrivate initialize]):
2942         (-[WebViewPrivate init]):
2943         (-[WebViewPrivate dealloc]):
2944         * WebView/WebViewInternal.h:
2945
2946 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2947
2948         Clean up FrameLoader two-state enums
2949         https://bugs.webkit.org/show_bug.cgi?id=190731
2950
2951         Reviewed by Chris Dumez.
2952
2953         * WebCoreSupport/WebFrameLoaderClient.h:
2954         * WebCoreSupport/WebFrameLoaderClient.mm:
2955         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2956
2957 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2958
2959         Unreviewed, rolling out r237137.
2960
2961         SPI is actually used
2962
2963         Reverted changeset:
2964
2965         "Remove unused WebFrame._loadType"
2966         https://bugs.webkit.org/show_bug.cgi?id=190583
2967         https://trac.webkit.org/changeset/237137
2968
2969 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2970
2971         Enable the datalist element by default on iOS and macOS
2972         https://bugs.webkit.org/show_bug.cgi?id=190594
2973         <rdar://problem/45281159>
2974
2975         Reviewed by Ryosuke Niwa and Tim Horton.
2976
2977         * Configurations/FeatureDefines.xcconfig:
2978
2979 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2980
2981         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2982         https://bugs.webkit.org/show_bug.cgi?id=190675
2983
2984         Reviewed by Chris Dumez.
2985
2986         * History/BackForwardList.h:
2987         * History/BackForwardList.mm:
2988         (BackForwardList::backItem):
2989         (BackForwardList::currentItem):
2990         (BackForwardList::forwardItem):
2991         (BackForwardList::backListCount const):
2992         (BackForwardList::forwardListCount const):
2993         (BackForwardList::itemAtIndex):
2994         * History/WebBackForwardList.mm:
2995         (-[WebBackForwardList backItem]):
2996         (-[WebBackForwardList currentItem]):
2997         (-[WebBackForwardList forwardItem]):
2998         (-[WebBackForwardList itemAtIndex:]):
2999
3000 2018-10-16  Timothy Hatcher  <timothy@apple.com>
3001
3002         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
3003         https://bugs.webkit.org/show_bug.cgi?id=190526
3004         rdar://problem/45230140
3005
3006         Reviewed by Dean Jackson.
3007
3008         * WebCoreSupport/WebEditorClient.mm:
3009         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
3010
3011 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
3012
3013         Implement feature flag and bindings for CSS Painting API
3014         https://bugs.webkit.org/show_bug.cgi?id=190237
3015
3016         Reviewed by Ryosuke Niwa.
3017
3018         * Configurations/FeatureDefines.xcconfig:
3019
3020 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3021
3022         Replace HistoryItem* with HistoryItem& where possible
3023         https://bugs.webkit.org/show_bug.cgi?id=190617
3024
3025         Reviewed by Chris Dumez.
3026
3027         * History/BackForwardList.h:
3028         * History/BackForwardList.mm:
3029         (BackForwardList::goToItem):
3030         * History/WebBackForwardList.mm:
3031         (-[WebBackForwardList goToItem:]):
3032         * History/WebHistoryItem.mm:
3033         (WKNotifyHistoryItemChanged):
3034         * History/WebHistoryItemInternal.h:
3035
3036 2018-10-16  Alex Christensen  <achristensen@webkit.org>
3037
3038         Remove unused WebHistoryItem._transientPropertyForKey
3039         https://bugs.webkit.org/show_bug.cgi?id=190606
3040
3041         Reviewed by Chris Dumez.
3042
3043         * History/WebHistoryItem.mm:
3044         * History/WebHistoryItemPrivate.h:
3045
3046 2018-10-15  Justin Fan  <justin_fan@apple.com>
3047
3048         Add WebGPU 2018 feature flag and experimental feature flag
3049         https://bugs.webkit.org/show_bug.cgi?id=190509
3050
3051         Reviewed by Dean Jackson.
3052
3053         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
3054         for the 2018 WebGPU prototype.
3055
3056         * Configurations/FeatureDefines.xcconfig:
3057         * WebView/WebPreferenceKeysPrivate.h:
3058         * WebView/WebPreferences.mm:
3059         (+[WebPreferences initialize]):
3060         (-[WebPreferences webGPUEnabled]):
3061         (-[WebPreferences setWebGPUEnabled:]):
3062         * WebView/WebPreferencesPrivate.h:
3063         * WebView/WebView.mm:
3064         (-[WebView _preferencesChanged:]):
3065
3066 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3067
3068         Fix iOS build after r237157
3069
3070         * WebView/WebView.mm:
3071         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3072
3073 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3074
3075         Modernize BackForwardClient.h
3076         https://bugs.webkit.org/show_bug.cgi?id=190610
3077
3078         Reviewed by Chris Dumez.
3079
3080         * History/BackForwardList.h:
3081         * History/BackForwardList.mm:
3082         (BackForwardList::backListCount const):
3083         (BackForwardList::forwardListCount const):
3084         (BackForwardList::backListCount): Deleted.
3085         (BackForwardList::forwardListCount): Deleted.
3086         * History/WebBackForwardList.mm:
3087         (-[WebBackForwardList init]):
3088         * WebCoreSupport/WebFrameLoaderClient.mm:
3089         (WebFrameLoaderClient::canCachePage const):
3090         * WebView/WebFrameView.mm:
3091         (-[WebFrameView keyDown:keyDown:]):
3092         * WebView/WebView.mm:
3093         (-[WebView _commonInitializationWithFrameName:groupName:]):
3094         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3095         (-[WebView _loadBackForwardListFromOtherView:]):
3096         (-[WebView initWithCoder:]):
3097         (-[WebView encodeWithCoder:]):
3098         (-[WebView backForwardList]):
3099         (-[WebView setMaintainsBackForwardList:]):
3100
3101 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3102
3103         Add support for prefers-color-scheme media query
3104         https://bugs.webkit.org/show_bug.cgi?id=190499
3105         rdar://problem/45212025
3106
3107         Reviewed by Dean Jackson.
3108
3109         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3110
3111 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3112
3113         Remove unused WebView._globalHistoryItem
3114         https://bugs.webkit.org/show_bug.cgi?id=190601
3115
3116         Reviewed by Chris Dumez.
3117
3118         * WebCoreSupport/WebFrameLoaderClient.h:
3119         * WebCoreSupport/WebFrameLoaderClient.mm:
3120         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
3121         * WebView/WebView.mm:
3122         (-[WebView _globalHistoryItem]): Deleted.
3123         (-[WebView _setGlobalHistoryItem:]): Deleted.
3124         * WebView/WebViewData.h:
3125         * WebView/WebViewInternal.h:
3126         * WebView/WebViewPrivate.h:
3127
3128 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3129
3130         Remove unused parameters from FrameLoaderClient::createFrame
3131         https://bugs.webkit.org/show_bug.cgi?id=190587
3132
3133         Reviewed by Chris Dumez.
3134
3135         * WebCoreSupport/WebFrameLoaderClient.h:
3136         * WebCoreSupport/WebFrameLoaderClient.mm:
3137         (WebFrameLoaderClient::createFrame):
3138
3139 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3140
3141         Remove unused WebFrame._loadType
3142         https://bugs.webkit.org/show_bug.cgi?id=190583
3143
3144         Reviewed by Chris Dumez.
3145
3146         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
3147
3148         * WebView/WebFrame.mm:
3149         (toWebFrameLoadType): Deleted.
3150         (-[WebFrame _loadType]): Deleted.
3151         * WebView/WebFramePrivate.h:
3152
3153 2018-10-15  Chris Dumez  <cdumez@apple.com>
3154
3155         Restrict browsing context lookup by name to frames that are related to one another
3156         https://bugs.webkit.org/show_bug.cgi?id=190475
3157
3158         Reviewed by Alex Christensen.
3159
3160         * WebView/WebFrame.mm:
3161         (-[WebFrame findFrameNamed:]):
3162
3163 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3164
3165         Remove InjectedBundle processing of back/forward lists
3166         https://bugs.webkit.org/show_bug.cgi?id=190459
3167
3168         Reviewed by Chris Dumez.
3169
3170         * WebCoreSupport/WebFrameLoaderClient.h:
3171         * WebCoreSupport/WebFrameLoaderClient.mm:
3172         (WebFrameLoaderClient::shouldGoToHistoryItem const):
3173
3174 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3175
3176         [JSC] Remove Option::useAsyncIterator
3177         https://bugs.webkit.org/show_bug.cgi?id=190567
3178
3179         Reviewed by Saam Barati.
3180
3181         * Configurations/FeatureDefines.xcconfig:
3182
3183 2018-10-12  Alex Christensen  <achristensen@webkit.org>
3184
3185         Allow encoding of small enum classes
3186         https://bugs.webkit.org/show_bug.cgi?id=190531
3187
3188         Reviewed by Tim Horton.
3189
3190         * WebCoreSupport/WebFrameLoaderClient.mm:
3191         (-[WebFramePolicyListener dealloc]):
3192
3193 2018-10-11  Keith Rollin  <krollin@apple.com>
3194
3195         CURRENT_ARCH should not be used in Run Script phase.
3196         https://bugs.webkit.org/show_bug.cgi?id=190407
3197         <rdar://problem/45133556>
3198
3199         Reviewed by Alexey Proskuryakov.
3200
3201         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
3202         CURRENT_ARCH is not well-defined during this phase (and may even have
3203         the value "undefined") since this phase is run just once per build
3204         rather than once per supported architecture. Migrate away from
3205         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
3206         performing an operation for each value, or by picking the first entry
3207         in ARCHS and using that as a representative value.
3208
3209         * Configurations/WebKitLegacy.xcconfig: When generating
3210         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
3211         macosx platforms.
3212
3213         * MigrateHeaders.make:
3214         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
3215         generate one for each architecture in ARCHS.
3216
3217 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3218
3219         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3220         https://bugs.webkit.org/show_bug.cgi?id=190429
3221
3222         Reviewed by Saam Barati.
3223
3224         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
3225
3226         * WebView/WebPDFRepresentation.mm:
3227         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
3228
3229 2018-10-08  Justin Fan  <justin_fan@apple.com>
3230
3231         WebGPU: Rename old WebGPU prototype to WebMetal
3232         https://bugs.webkit.org/show_bug.cgi?id=190325
3233         <rdar://problem/44990443>
3234
3235         Reviewed by Dean Jackson.
3236
3237         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3238
3239         * Configurations/FeatureDefines.xcconfig:
3240         * WebView/WebPreferenceKeysPrivate.h:
3241         * WebView/WebPreferences.mm:
3242         (+[WebPreferences initialize]):
3243         (-[WebPreferences webMetalEnabled]):
3244         (-[WebPreferences setWebMetalEnabled:]):
3245         (-[WebPreferences webGPUEnabled]): Deleted.
3246         (-[WebPreferences setWebGPUEnabled:]): Deleted.
3247         * WebView/WebPreferencesPrivate.h:
3248         * WebView/WebView.mm:
3249         (-[WebView _preferencesChanged:]):
3250
3251 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3252
3253         Make <input type=color> a runtime enabled (on-by-default) feature
3254         https://bugs.webkit.org/show_bug.cgi?id=189162
3255
3256         Reviewed by Wenson Hsieh and Tim Horton.
3257
3258         * Configurations/FeatureDefines.xcconfig:
3259
3260 2018-10-07  Dan Bernstein  <mitz@apple.com>
3261
3262         Fixed building with the latest macOS SDK
3263
3264         * Plugins/WebNetscapePluginPackage.mm:
3265         (-[WebNetscapePluginPackage openResourceFile]):
3266         (-[WebNetscapePluginPackage closeResourceFile:]):
3267
3268 2018-10-04  Dan Bernstein  <mitz@apple.com>
3269
3270         More Carbon build-fixing.
3271
3272         * Carbon/CarbonWindowAdapter.mm:
3273         (-[CarbonWindowAdapter _destroyRealWindow:]):
3274         (-[CarbonWindowAdapter _growBoxRect]):
3275
3276 2018-10-04  Dan Bernstein  <mitz@apple.com>
3277
3278         Retried to fix 32-bit macOS builds after r236846.
3279
3280         * WebView/WebHTMLView.mm:
3281         (-[WebHTMLView setMarkedText:selectedRange:]):
3282
3283 2018-10-04  Dan Bernstein  <mitz@apple.com>
3284
3285         Retried to fix 32-bit macOS builds after r236846.
3286
3287         * Carbon/HIWebView.mm:
3288         (ActiveStateChanged):
3289
3290 2018-10-04  Dan Bernstein  <mitz@apple.com>
3291
3292         Tried to fix 32-bit macOS builds after r236846.
3293
3294         * Carbon/HIWebView.mm:
3295         (_NSSelectorForHICommand):
3296
3297 2018-10-04  Dan Bernstein  <mitz@apple.com>
3298
3299         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
3300         https://bugs.webkit.org/show_bug.cgi?id=190250
3301
3302         Reviewed by Andy Estes.
3303
3304         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
3305           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3306           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
3307           an earlier line set it to YES.
3308
3309         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
3310         changes below.
3311
3312         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
3313           provides some missing method declarations.
3314
3315         * Misc/WebDownload.mm:
3316         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
3317           a deprecated method.
3318
3319         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
3320
3321         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
3322           other code in the file uses a method from it.
3323
3324         * Plugins/WebBaseNetscapePluginView.mm:
3325         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
3326           a deprecated method.
3327
3328         * Plugins/WebPluginController.mm:
3329         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
3330           around use of a selector that may be present in some WebKit client.
3331
3332         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
3333           method declarations.
3334
3335         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
3336           from here.
3337
3338         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
3339           missing method declarations.
3340
3341         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
3342           from here.
3343
3344         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
3345           call from here.
3346         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
3347           an obsolete delegate method for binary compatibility.
3348         (pluginView): Ditto.
3349
3350         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
3351           call from here.
3352
3353         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
3354           WebDeviceOrientationProviderMock protocol.
3355
3356         * WebView/WebDeviceOrientationProviderMock.mm:
3357         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
3358           main @implementation.
3359
3360         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
3361           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
3362
3363         * WebView/WebDynamicScrollBarsView.mm:
3364         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
3365           of a deprecated method.
3366
3367         * WebView/WebHTMLView.mm:
3368         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
3369           selector warning around action methods that are not declared anywhere in WebKit.
3370
3371         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
3372           about implementing this deprecated method.
3373         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
3374         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3375         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3376         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3377         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3378         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3379         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3380         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3381         (-[WebHTMLView doCommandBySelector:]): Ditto.
3382         (-[WebHTMLView insertText:]): Ditto.
3383
3384         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
3385
3386         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
3387
3388         * WebView/WebPDFView.h: Removed previewView ivar.
3389
3390         * WebView/WebPDFView.mm:
3391           Removed declaration of FileInternal category and merged its implementation with the main
3392           implementation.
3393         (-[WebPDFView dealloc]): Removed previewView ivar.
3394         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
3395           exist in macOS versions we support.
3396         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
3397         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
3398           action methods internal to PDFKit.
3399         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
3400         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
3401
3402         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
3403           call on macOS, even though in r86988 we started calling different methods on iOS.
3404
3405         * WebView/WebView.mm:
3406         - Imported headers that declare delegate methods that we call.
3407         - Removed declaration of WebFileInternal category and merged its implementation with the
3408           main implementation.
3409         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
3410           category, which made them impossible to call from the main implementation. Moved those
3411           into the main implementation. One of those had to be declared in a class extension,
3412           because it is called from a method implemented in the WebPrivate category, and that
3413           category’s implementation appears first in the file.
3414
3415         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
3416           around use of obsolete delegate method for binary compatibility.
3417
3418         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
3419
3420 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3421
3422         Runtime flag and IDL for MediaRecorder
3423         https://bugs.webkit.org/show_bug.cgi?id=190018
3424
3425         Reviewed by Youenn Fablet and Chris Dumez.
3426
3427         * WebView/WebPreferenceKeysPrivate.h:
3428         * WebView/WebPreferences.mm:
3429         (+[WebPreferences initialize]):
3430         (-[WebPreferences mediaRecorderEnabled]):
3431         (-[WebPreferences setMediaRecorderEnabled:]):
3432         * WebView/WebPreferencesPrivate.h:
3433         * WebView/WebView.mm:
3434         (-[WebView _preferencesChanged:]):
3435
3436 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3437
3438         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3439         https://bugs.webkit.org/show_bug.cgi?id=190238
3440
3441         Reviewed by Antti Koivisto.
3442
3443         Enabled the feature by default.
3444
3445         * WebView/WebPreferences.mm:
3446         (+[WebPreferences initialize]):
3447
3448 2018-10-01  Dean Jackson  <dino@apple.com>
3449
3450         [macOS] Switching to discrete GPU should be done in the UI process
3451         https://bugs.webkit.org/show_bug.cgi?id=189361
3452         <rdar://problem/43949622>
3453
3454         Reviewed by Simon Fraser.
3455
3456         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
3457         not support swapping to the discrete GPU in this configuration.
3458
3459         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
3460         (WebKit::WebSwitchingGPUClient::singleton):
3461         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
3462         * WebView/WebView.mm:
3463         (-[WebView _commonInitializationWithFrameName:groupName:]):
3464
3465 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3466
3467         Remove ParsedURLString
3468         https://bugs.webkit.org/show_bug.cgi?id=190154
3469
3470         Reviewed by Chris Dumez.
3471
3472         * WebView/WebScriptDebugger.mm:
3473         (toNSURL):
3474
3475 2018-10-01  Dean Jackson  <dino@apple.com>
3476
3477         Remove CSS Animation Triggers
3478         https://bugs.webkit.org/show_bug.cgi?id=190175
3479         <rdar://problem/44925626>
3480
3481         Reviewed by Simon Fraser.
3482
3483         * Configurations/FeatureDefines.xcconfig:
3484
3485 2018-10-02  Commit Queue  <commit-queue@webkit.org>
3486
3487         Unreviewed, rolling out r236624 and r236671.
3488         https://bugs.webkit.org/show_bug.cgi?id=190207
3489
3490         The change in r236624 introduced crashes on the bots
3491         (Requested by ryanhaddad on #webkit).
3492
3493         Reverted changesets:
3494
3495         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3496         https://bugs.webkit.org/show_bug.cgi?id=188747
3497         https://trac.webkit.org/changeset/236624
3498
3499         "Unify implementation in VideoFullscreenInterfaceAVKit"
3500         https://bugs.webkit.org/show_bug.cgi?id=190091
3501         https://trac.webkit.org/changeset/236671
3502
3503 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3504
3505         URL should not use TextEncoding internally
3506         https://bugs.webkit.org/show_bug.cgi?id=190111
3507
3508         Reviewed by Andy Estes.
3509
3510         * Misc/WebNSURLExtras.mm:
3511
3512 2018-09-28  Jer Noble  <jer.noble@apple.com>
3513
3514         Refactoring: eliminate raw pointer usage in Fullscreen code
3515         https://bugs.webkit.org/show_bug.cgi?id=188747
3516         <rdar://problem/43541164>
3517
3518         Reviewed by Alex Christensen.
3519
3520         PlaybackSessionInterface no longer has an invalidate() method.
3521
3522         * WebView/WebView.mm:
3523         (-[WebView _clearPlaybackControlsManager]):
3524
3525 2018-09-28  Chris Dumez  <cdumez@apple.com>
3526
3527         Drop support for cross-origin-window-policy header
3528         https://bugs.webkit.org/show_bug.cgi?id=190081
3529
3530         Reviewed by Ryosuke Niwa.
3531
3532         * WebView/WebPreferenceKeysPrivate.h:
3533         * WebView/WebPreferences.mm:
3534         (+[WebPreferences initialize]):
3535         * WebView/WebPreferencesPrivate.h:
3536         * WebView/WebView.mm:
3537         (-[WebView _preferencesChanged:]):
3538
3539 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3540
3541         Rename createMarkup to serializePreservingVisualAppearance
3542         https://bugs.webkit.org/show_bug.cgi?id=190086
3543
3544         Reviewed by Wenson Hsieh.
3545
3546         * DOM/WebDOMOperations.mm:
3547         (-[DOMRange markupString]):
3548
3549 2018-09-28  Commit Queue  <commit-queue@webkit.org>
3550
3551         Unreviewed, rolling out r236605.
3552         https://bugs.webkit.org/show_bug.cgi?id=190087
3553
3554         caused three API test timeouts (Requested by jernoble on
3555         #webkit).
3556
3557         Reverted changeset:
3558
3559         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3560         https://bugs.webkit.org/show_bug.cgi?id=188747
3561         https://trac.webkit.org/changeset/236605
3562
3563 2018-09-28  Jer Noble  <jer.noble@apple.com>
3564
3565         Refactoring: eliminate raw pointer usage in Fullscreen code
3566         https://bugs.webkit.org/show_bug.cgi?id=188747
3567         <rdar://problem/43541164>
3568
3569         Reviewed by Alex Christensen.
3570
3571         PlaybackSessionInterface no longer has an invalidate() method.
3572
3573         * WebView/WebView.mm:
3574         (-[WebView _clearPlaybackControlsManager]):
3575
3576 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3577
3578         Use enum class in createMarkup arguments
3579         https://bugs.webkit.org/show_bug.cgi?id=190028
3580
3581         Reviewed by Wenson Hsieh.
3582
3583         * DOM/WebDOMOperations.mm:
3584         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
3585         (-[DOMRange markupString]): Ditto.
3586
3587 2018-09-27  Antoine Quint  <graouts@apple.com>
3588
3589         [Web Animations] Turn Web Animations with CSS integration on
3590         https://bugs.webkit.org/show_bug.cgi?id=184819
3591         <rdar://problem/39597337>
3592
3593         Reviewed by Dean Jackson.
3594
3595         * WebView/WebPreferences.mm:
3596         (+[WebPreferences initialize]):
3597
3598 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3599
3600         Selection should work across shadow boundary when initiated by a mouse drag
3601         https://bugs.webkit.org/show_bug.cgi?id=151380
3602         <rdar://problem/24363872>
3603
3604         Reviewed by Wenson Hsieh.
3605
3606         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
3607
3608         * WebView/WebPreferenceKeysPrivate.h:
3609         * WebView/WebPreferences.mm:
3610         (+[WebPreferences initialize]):
3611         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
3612         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
3613         * WebView/WebPreferencesPrivate.h:
3614         * WebView/WebView.mm:
3615         (-[WebView _preferencesChanged:]):
3616
3617 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3618
3619         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3620         https://bugs.webkit.org/show_bug.cgi?id=189918
3621         Work towards <rdar://problem/44648705>
3622
3623         Reviewed by Tim Horton.
3624
3625         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3626
3627         * WebView/WebHTMLView.mm:
3628         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3629         (-[WebHTMLView _updateFontPanel]):
3630         * WebView/WebView.mm:
3631         (-[WebView typingAttributes]):
3632
3633 2018-09-17  Darin Adler  <darin@apple.com>
3634
3635         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3636         https://bugs.webkit.org/show_bug.cgi?id=189652
3637
3638         Reviewed by Saam Barati.
3639
3640         * WebView/WebPDFRepresentation.mm:
3641         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3642
3643 2018-09-14  Jer Noble  <jer.noble@apple.com>
3644
3645         Turn SourceBufferChangeTypeEnabled on by default
3646         https://bugs.webkit.org/show_bug.cgi?id=189527
3647
3648         Reviewed by Eric Carlson.
3649
3650         * WebView/WebPreferences.mm:
3651         (+[WebPreferences initialize]):
3652
3653 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3654
3655         Fix an internal build after r235935
3656         https://bugs.webkit.org/show_bug.cgi?id=188996
3657
3658         * Carbon/HIWebView.mm:
3659         (Draw):
3660         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3661
3662 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3663
3664         Add IGNORE_WARNING_.* macros
3665         https://bugs.webkit.org/show_bug.cgi?id=188996
3666
3667         Reviewed by Michael Catanzaro.
3668
3669         * Carbon/CarbonUtils.m:
3670         (PoolCleaner):
3671         * Carbon/CarbonWindowAdapter.mm:
3672         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3673         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3674         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3675         (-[CarbonWindowAdapter _termWindowIfOwner]):
3676         (-[CarbonWindowAdapter _windowMovedToRect:]):
3677         (-[CarbonWindowAdapter setContentView:]):
3678         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3679         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3680         * Carbon/CarbonWindowFrame.m:
3681         (-[CarbonWindowFrame title]):
3682         * Carbon/HIViewAdapter.m:
3683         (+[HIViewAdapter getHIViewForNSView:]):
3684         * Carbon/HIWebView.mm:
3685         (overrideCGContext):
3686         (restoreCGContext):
3687         (Draw):
3688         * DOM/DOM.mm:
3689         * History/WebHistory.mm:
3690         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3691         * History/WebHistoryItem.mm:
3692         (-[WebHistoryItem icon]):
3693         * Misc/WebKitNSStringExtras.mm:
3694         (-[NSString _web_drawAtPoint:font:textColor:]):
3695         * Misc/WebNSImageExtras.m:
3696         (-[NSImage _web_scaleToMaxSize:]):
3697         (-[NSImage _web_dissolveToFraction:]):
3698         * Misc/WebNSPasteboardExtras.mm:
3699         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3700         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3701         * Panels/WebAuthenticationPanel.m:
3702         (-[WebAuthenticationPanel loadNib]):
3703         * Plugins/Hosted/NetscapePluginHostManager.mm:
3704         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3705         (WebKit::NetscapePluginHostManager::didCreateWindow):
3706         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3707         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3708         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3709         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3710         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3711         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3712         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3713         (-[WebHostedNetscapePluginView drawRect:]):
3714         * Plugins/Hosted/WebTextInputWindowController.m:
3715         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3716         * Plugins/WebBaseNetscapePluginView.mm:
3717         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3718         * Plugins/WebNetscapePluginPackage.mm:
3719         (-[WebNetscapePluginPackage _tryLoad]):
3720         * Plugins/WebNetscapePluginView.mm:
3721         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3722         (-[WebNetscapePluginView sendDrawRectEvent:]):
3723         (-[WebNetscapePluginView drawRect:]):
3724         * Plugins/WebPluginController.mm:
3725         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3726         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3727         * WebCoreSupport/PopupMenuMac.mm:
3728         (PopupMenuMac::populate):
3729         * WebCoreSupport/WebAlternativeTextClient.h:
3730         * WebCoreSupport/WebDragClient.mm:
3731         (WebDragClient::startDrag):
3732         * WebCoreSupport/WebFrameLoaderClient.mm:
3733         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3734         (webGetNSImage):
3735         * WebInspector/WebNodeHighlight.mm:
3736         * WebInspector/WebNodeHighlightView.mm:
3737         (-[WebNodeHighlightView drawRect:]):
3738         * WebView/WebClipView.mm:
3739         (-[WebClipView initWithFrame:]):
3740         * WebView/WebFrame.mm:
3741         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3742         (-[WebFrame _drawRect:contentsOnly:]):
3743         (-[WebFrame accessibilityRoot]):
3744         * WebView/WebFullScreenController.mm:
3745         (-[WebFullScreenController enterFullScreen:]):
3746         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3747         (-[WebFullScreenController exitFullScreen]):
3748         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3749         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3750         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3751         * WebView/WebHTMLView.mm:
3752         (-[NSWindow _web_borderView]):
3753         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3754         (-[WebHTMLView _setAsideSubviews]):
3755         (-[WebHTMLView _autoscroll]):
3756         (-[WebHTMLView drawRect:]):
3757         (-[WebHTMLView mouseDown:]):
3758         (-[WebHTMLView mouseDragged:]):
3759         (-[WebHTMLView mouseUp:]):
3760         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3761         (-[WebHTMLView knowsPageRange:]):
3762         (-[WebHTMLView accessibilityHitTest:]):
3763         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3764         (-[WebHTMLView _colorAsString:]):
3765         (-[WebHTMLView copyFont:]):
3766         (-[WebHTMLView _executeSavedKeypressCommands]):
3767         (-[WebHTMLView attachRootLayer:]):
3768         (-[WebHTMLView textStorage]):
3769         (-[WebHTMLView _updateSelectionForInputManager]):
3770         * WebView/WebPDFView.mm:
3771         (_applicationInfoForMIMEType):
3772         (-[WebPDFView centerSelectionInVisibleArea:]):
3773         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3774         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3775         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3776         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3777         * WebView/WebTextCompletionController.mm:
3778         (-[WebTextCompletionController _buildUI]):
3779         (-[WebTextCompletionController _placePopupWindow:]):
3780         * WebView/WebVideoFullscreenController.mm:
3781         * WebView/WebVideoFullscreenHUDWindowController.mm:
3782         (createMediaUIBackgroundView):
3783         * WebView/WebView.mm:
3784         (-[WebTextListTouchBarViewController initWithWebView:]):
3785         (-[WebView _dispatchTileDidDraw:]):
3786         (-[WebView encodeWithCoder:]):
3787         (-[WebView mainFrameIcon]):
3788         (LayerFlushController::flushLayers):
3789         * WebView/WebWindowAnimation.mm:
3790         (setScaledFrameForWindow):
3791
3792 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3793
3794         Remove unused needsDestruction class variables from HashTraits
3795         https://bugs.webkit.org/show_bug.cgi?id=189490
3796
3797         Reviewed by Daniel Bates.
3798
3799         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3800
3801 2018-09-07  Frederic Wang  <fwang@igalia.com>
3802
3803         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3804         https://bugs.webkit.org/show_bug.cgi?id=182230
3805
3806         Reviewed by Simon Fraser.
3807
3808         * DOM/DOMDocument.mm:
3809         (-[DOMDocument scrollingElement]): Use the new name.
3810
3811 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3812
3813         Refactor WebCore::EditAction to be an 8-bit enum class
3814         https://bugs.webkit.org/show_bug.cgi?id=189383
3815
3816         Reviewed by Dan Bernstein.
3817
3818         * WebCoreSupport/WebEditorClient.mm:
3819         (undoNameForEditAction):
3820         * WebView/WebHTMLView.mm:
3821         (-[WebHTMLView pasteFont:]):
3822         (-[WebHTMLView changeFont:]):
3823         (-[WebHTMLView changeAttributes:]):
3824         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3825         (-[WebHTMLView changeColor:]):
3826         * WebView/WebView.mm:
3827         (-[WebView setTypingStyle:]):
3828
3829 2018-09-06  Frederic Wang  <fwang@igalia.com>
3830
3831         Group options of scrollRectToVisible into a struct
3832         https://bugs.webkit.org/show_bug.cgi?id=189352
3833
3834         Reviewed by Simon Fraser.
3835
3836         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3837         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3838         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3839
3840 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3841
3842         [macOS] Cannot change font size at selection until font panel is shown
3843         https://bugs.webkit.org/show_bug.cgi?id=189295
3844         <rdar://problem/35593389>
3845
3846         Reviewed by Ryosuke Niwa.
3847
3848         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3849         WebCore ChangeLog for more details.
3850
3851         * WebView/WebHTMLView.mm:
3852         (-[WebHTMLView changeFont:]):
3853         (-[WebHTMLView changeAttributes:]):
3854         (-[WebHTMLView _originalFontA]): Deleted.
3855         (-[WebHTMLView _originalFontB]): Deleted.
3856         (fontNameForDescription): Deleted.
3857         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3858         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3859         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3860
3861 2018-09-05  Jer Noble  <jer.noble@apple.com>
3862
3863         Add MediaCapabilities as an Experimental Feature
3864         https://bugs.webkit.org/show_bug.cgi?id=189209
3865
3866         Reviewed by Eric Carlson.
3867
3868         RuntimeEnabledFeature -> Setting.
3869
3870         * WebView/WebView.mm:
3871         (-[WebView _preferencesChanged:]):
3872
3873 2018-09-04  Frederic Wang  <fwang@igalia.com>
3874
3875         Add basic support for ScrollIntoViewOptions
3876         https://bugs.webkit.org/show_bug.cgi?id=189258
3877
3878         Reviewed by Simon Fraser.
3879
3880         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3881         header so that this file can build despite the new scrollIntoView function.
3882
3883 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3884
3885         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3886         https://bugs.webkit.org/show_bug.cgi?id=188890
3887         <rdar://problem/43648605>
3888
3889         Reviewed by Tim Horton.
3890
3891         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3892         more detail.
3893
3894         * WebCoreSupport/WebPlatformStrategies.h:
3895         * WebCoreSupport/WebPlatformStrategies.mm:
3896         (WebPlatformStrategies::allStringsForType):
3897
3898 2018-09-01  Darin Adler  <darin@apple.com>
3899
3900         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3901         https://bugs.webkit.org/show_bug.cgi?id=189072
3902         Reviewed by Dan Bernstein.
3903
3904         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3905         and declarations for NSURLDownload init methods.
3906
3907         * Misc/WebDownloadInternal.h: Removed.
3908
3909         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3910         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3911         "-Wdeprecated-declarations" because the method used here is deprecated.
3912
3913         * WebView/WebView.mm:
3914         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3915         used here is deprecated.
3916
3917 2018-08-31  Chris Dumez  <cdumez@apple.com>
3918
3919         Assertion hit in ~CompletionHandler() from ~WebFrame()
3920         https://bugs.webkit.org/show_bug.cgi?id=189199
3921         <rdar://problem/42657233>
3922
3923         Reviewed by Youenn Fablet.
3924
3925         * WebCoreSupport/WebFrameLoaderClient.h:
3926         * WebCoreSupport/WebFrameLoaderClient.mm:
3927         (WebFrameLoaderClient::dispatchWillSubmitForm):
3928
3929 2018-08-31  Antti Koivisto  <antti@apple.com>
3930
3931         Replace OptionSet |= and -= operators with add() and remove() functions
3932         https://bugs.webkit.org/show_bug.cgi?id=189169
3933
3934         Reviewed by Anders Carlsson.
3935
3936         * WebView/WebFrame.mm:
3937         (-[WebFrame _drawRect:contentsOnly:]):
3938         * WebView/WebView.mm:
3939         (coreOptions):
3940
3941 2018-08-31  Frederic Wang  <fwang@igalia.com>
3942
3943         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3944         https://bugs.webkit.org/show_bug.cgi?id=182053
3945
3946         Reviewed by Simon Fraser.
3947
3948         Add developer flag to use standard behavior for scrolling* attributes.
3949
3950         * WebView/WebPreferenceKeysPrivate.h:
3951         * WebView/WebPreferences.mm:
3952         (+[WebPreferences initialize]):
3953         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3954         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3955         * WebView/WebPreferencesPrivate.h:
3956         * WebView/WebView.mm:
3957         (-[WebView _preferencesChanged:]):
3958
3959 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3960
3961         Implement the Web Share API
3962         https://bugs.webkit.org/show_bug.cgi?id=171100
3963         <rdar://problem/31751734>
3964
3965         Reviewed by Tim Horton.
3966
3967         * WebCoreSupport/WebChromeClient.h:
3968         * WebCoreSupport/WebChromeClient.mm:
3969         (WebChromeClient::showShareSheet):
3970         Empty declaration of showShareSheet.
3971
3972 2018-08-29  Youenn Fablet  <youenn@apple.com>
3973
3974         Remove WebRTC legacy API implementation
3975         https://bugs.webkit.org/show_bug.cgi?id=189040
3976
3977         Reviewed by Eric Carlson.
3978
3979         * WebView/WebPreferenceKeysPrivate.h:
3980         * WebView/WebPreferences.mm:
3981         (+[WebPreferences initialize]):
3982         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3983         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3984         * WebView/WebPreferencesPrivate.h:
3985         * WebView/WebView.mm:
3986         (-[WebView _preferencesChanged:]):
3987
3988 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3989
3990         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3991         https://bugs.webkit.org/show_bug.cgi?id=189054
3992
3993         Reviewed by Andy Estes.
3994
3995         Remove the pasteboard type argument from readURLFromPasteboard.
3996
3997         * WebCoreSupport/WebPlatformStrategies.h:
3998         * WebCoreSupport/WebPlatformStrategies.mm:
3999         (WebPlatformStrategies::readURLFromPasteboard):
4000
4001 2018-08-27  Keith Rollin  <krollin@apple.com>
4002
4003         Unreviewed build fix -- disable LTO for production builds
4004
4005         * Configurations/Base.xcconfig:
4006
4007 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
4008
4009         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
4010         https://bugs.webkit.org/show_bug.cgi?id=188931
4011
4012         Reviewed by Wenson Hsieh.
4013
4014         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
4015
4016 2018-08-27  Keith Rollin  <krollin@apple.com>
4017
4018         Build system support for LTO
4019         https://bugs.webkit.org/show_bug.cgi?id=187785
4020         <rdar://problem/42353132>
4021
4022         Reviewed by Dan Bernstein.
4023
4024         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
4025         LTO.
4026
4027         * Configurations/Base.xcconfig:
4028         * Configurations/DebugRelease.xcconfig:
4029
4030 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
4031
4032         Pass in IsComposed flag to Event constructors
4033         https://bugs.webkit.org/show_bug.cgi?id=188720
4034         <rdar://problem/43580387>
4035
4036         Reviewed by Simon Fraser.
4037
4038         * WebView/WebPDFView.mm:
4039         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
4040         whether it's simulated or not.
4041
4042 2018-08-23  Mark Lam  <mark.lam@apple.com>
4043
4044         Move vmEntryGlobalObject() to VM from CallFrame.
4045         https://bugs.webkit.org/show_bug.cgi?id=188900
4046         <rdar://problem/43655753>
4047
4048         Reviewed by Michael Saboff.
4049
4050         * WebView/WebScriptDebugger.mm:
4051         (WebScriptDebugger::sourceParsed):
4052
4053 2018-08-23  Andy Estes  <aestes@apple.com>
4054
4055         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
4056         https://bugs.webkit.org/show_bug.cgi?id=188829
4057
4058         Reviewed by Tim Horton.
4059
4060         * Configurations/FeatureDefines.xcconfig:
4061
4062 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
4063
4064         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>