Hardcode Visual Viewports on everywhere except iOS WK1
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
2
3         Hardcode Visual Viewports on everywhere except iOS WK1
4         https://bugs.webkit.org/show_bug.cgi?id=194928
5
6         Reviewed by Zalan Bujtas.
7
8         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
9         change the default value of the Setting to 'true', and hardcode WebView on iOS to
10         set it to false. The setting has shipped for several years and there's no need to turn
11         it off now.
12
13         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
14         Visual Viewports are not enabled.
15         
16         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
17         that only runs in WK2
18
19         * WebView/WebPreferenceKeysPrivate.h:
20         * WebView/WebPreferences.mm:
21         (+[WebPreferences initialize]):
22         (-[WebPreferences visualViewportEnabled]): Deleted.
23         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
24         * WebView/WebPreferencesPrivate.h:
25         * WebView/WebView.mm:
26         (-[WebView _preferencesChanged:]):
27
28 2019-02-21  Darin Adler  <darin@apple.com>
29
30         Some refinements for Node and Document
31         https://bugs.webkit.org/show_bug.cgi?id=194764
32
33         Reviewed by Ryosuke Niwa.
34
35         * DOM/DOMDocument.mm:
36         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
37         through to WebCore or even looking at the arguments.
38         (-[DOMDocument getOverrideStyle::]): Ditto.
39
40 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
41
42         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
43         https://bugs.webkit.org/show_bug.cgi?id=194670
44         <rdar://problem/39066529>
45
46         Reviewed by Tim Horton.
47
48         * WebCoreSupport/WebEditorClient.h:
49         * WebCoreSupport/WebEditorClient.mm:
50         (WebEditorClient::replacementURLForResource): Deleted.
51         * WebCoreSupport/WebPlatformStrategies.h:
52         * WebCoreSupport/WebPlatformStrategies.mm:
53         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
54
55 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
56
57         Add MSE logging configuration
58         https://bugs.webkit.org/show_bug.cgi?id=194719
59         <rdar://problem/48122151>
60
61         Reviewed by Joseph Pecoraro.
62
63         * WebCoreSupport/WebChromeClient.mm:
64         (stringForMessageSource): Recognize the MSE message source.
65
66 2019-02-17  David Kilzer  <ddkilzer@apple.com>
67
68         Unreviewed, rolling out r241620.
69
70         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
71         (Requested by ddkilzer on #webkit.)
72
73         Reverted changeset:
74
75         "[WTF] Add environment variable helpers"
76         https://bugs.webkit.org/show_bug.cgi?id=192405
77         https://trac.webkit.org/changeset/241620
78
79 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
80
81         [WTF] Add environment variable helpers
82         https://bugs.webkit.org/show_bug.cgi?id=192405
83
84         Reviewed by Michael Catanzaro.
85
86         * WebView/WebView.mm:
87         (-[WebView _initWithFrame:frameName:groupName:]):
88         Utilize WTF::Environment where possible.
89
90 2019-02-15  Brian Burg  <bburg@apple.com>
91
92         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
93         https://bugs.webkit.org/show_bug.cgi?id=194411
94         <rdar://problem/47787614>
95
96         Reviewed by Joseph Pecoraro.
97
98         * Configurations/WebKitLegacy.xcconfig:
99         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
100
101         * WebCoreSupport/WebInspectorClient.mm:
102         (WebInspectorFrontendClient::localizedStringsURL):
103         (-[WebInspectorWindowController inspectorPagePath]):
104         (-[WebInspectorWindowController inspectorTestPagePath]):
105         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
106
107 2019-02-15  Commit Queue  <commit-queue@webkit.org>
108
109         Unreviewed, rolling out r241559 and r241566.
110         https://bugs.webkit.org/show_bug.cgi?id=194710
111
112         Causes layout test crashes under GuardMalloc (Requested by
113         ryanhaddad on #webkit).
114
115         Reverted changesets:
116
117         "[WTF] Add environment variable helpers"
118         https://bugs.webkit.org/show_bug.cgi?id=192405
119         https://trac.webkit.org/changeset/241559
120
121         "Unreviewed build fix for WinCairo Debug after r241559."
122         https://trac.webkit.org/changeset/241566
123
124 2019-02-15  Truitt Savell  <tsavell@apple.com>
125
126         Unreviewed, rolling out r241564.
127
128         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
129
130         Reverted changeset:
131
132         "[Mac] WebInspectorUI.framework does not need to be soft-
133         linked anymore"
134         https://bugs.webkit.org/show_bug.cgi?id=194411
135         https://trac.webkit.org/changeset/241564
136
137 2019-02-14  Brian Burg  <bburg@apple.com>
138
139         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
140         https://bugs.webkit.org/show_bug.cgi?id=194411
141         <rdar://problem/47787614>
142
143         Reviewed by Joseph Pecoraro.
144
145         * Configurations/WebKitLegacy.xcconfig:
146         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
147
148         * WebCoreSupport/WebInspectorClient.mm:
149         (WebInspectorFrontendClient::localizedStringsURL):
150         (-[WebInspectorWindowController inspectorPagePath]):
151         (-[WebInspectorWindowController inspectorTestPagePath]):
152         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
153
154 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
155
156         [WTF] Add environment variable helpers
157         https://bugs.webkit.org/show_bug.cgi?id=192405
158
159         Reviewed by Michael Catanzaro.
160
161         * WebView/WebView.mm:
162         (-[WebView _initWithFrame:frameName:groupName:]):
163         Utilize WTF::Environment where possible.
164
165 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
166
167         Allow pages to trigger programmatic paste from script on iOS
168         https://bugs.webkit.org/show_bug.cgi?id=194271
169         <rdar://problem/47808810>
170
171         Reviewed by Ryosuke Niwa.
172
173         See WebCore and WebKit ChangeLogs for more details.
174
175         * WebCoreSupport/WebEditorClient.h:
176
177 2019-02-12  Andy Estes  <aestes@apple.com>
178
179         [iOSMac] Enable Parental Controls Content Filtering
180         https://bugs.webkit.org/show_bug.cgi?id=194521
181         <rdar://39732376>
182
183         Reviewed by Tim Horton.
184
185         * Configurations/FeatureDefines.xcconfig:
186
187 2019-02-06  Andy Estes  <aestes@apple.com>
188
189         [Payment Request] It should be possible to require a phonetic name for shipping contacts
190         https://bugs.webkit.org/show_bug.cgi?id=194311
191         <rdar://46733045>
192
193         Reviewed by Alex Christensen.
194
195         * WebCoreSupport/WebPaymentCoordinatorClient.h:
196         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
197         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
198
199 2019-02-04  Said Abou-Hallawa  <said@apple.com>
200
201         [CG] Enable setAdditionalSupportedImageTypes for WK1
202         https://bugs.webkit.org/show_bug.cgi?id=194190
203
204         Reviewed by Tim Horton.
205
206         1. Define the preferences key AdditionalSupportedImageTypes.
207         2. Add additionalSupportedImageTypes as a private preference property.
208         3. Define the setter and the getter of the property.
209         4. Add function to convert from an id to an array of strings.
210         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
211
212         * WebView/WebPreferenceKeysPrivate.h:
213         * WebView/WebPreferences.mm:
214         (-[WebPreferences _stringArrayValueForKey:]):
215         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
216         (-[WebPreferences setAdditionalSupportedImageTypes:]):
217         (-[WebPreferences additionalSupportedImageTypes]):
218         * WebView/WebPreferencesPrivate.h:
219         * WebView/WebView.mm:
220         (-[WebView _preferencesChanged:]):
221
222 2019-02-04  Timothy Hatcher  <timothy@apple.com>
223
224         Add WebView SPI to temporarily force light or dark appearance on a page.
225         https://bugs.webkit.org/show_bug.cgi?id=194230
226
227         Reviewed by Tim Horton.
228
229         * WebView/WebView.mm:
230         (-[WebView _useDarkAppearance:]): Added.
231         (-[WebView _setUseDarkAppearance:]): Added.
232         * WebView/WebViewPrivate.h:
233
234 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
235
236         PageOverlayController's layers should be created lazily
237         https://bugs.webkit.org/show_bug.cgi?id=194199
238         rdar://problem/46571593
239
240         Reviewed by Tim Horton.
241
242         * WebCoreSupport/WebChromeClient.h:
243         * WebCoreSupport/WebChromeClient.mm:
244         (WebChromeClient::attachViewOverlayGraphicsLayer):
245
246 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
247
248         Make setNeedsLayout on the root more explicitly about triggering its side-effects
249         https://bugs.webkit.org/show_bug.cgi?id=194198
250
251         Reviewed by Antti Koivisto.
252
253         Call the newly named functions.
254
255         * WebView/WebFrame.mm:
256         (-[WebFrame setNeedsLayout]):
257         * WebView/WebHTMLView.mm:
258         (-[WebHTMLView setNeedsLayout:]):
259
260 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
261
262         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
263         https://bugs.webkit.org/show_bug.cgi?id=194189
264
265         Reviewed by Geoffrey Garen.
266
267         Pass the policy check identifier around functions and store it in WebFramePolicyListener
268         so that we can send it back to WebCore with the navigation policy decision.
269
270         * WebCoreSupport/WebFrameLoaderClient.h:
271         * WebCoreSupport/WebFrameLoaderClient.mm:
272         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
273         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
274         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
275         (WebFrameLoaderClient::dispatchWillSubmitForm):
276         (WebFrameLoaderClient::setUpPolicyListener):
277         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
278         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
279         (-[WebFramePolicyListener invalidate]):
280         (-[WebFramePolicyListener dealloc]):
281         (-[WebFramePolicyListener receivedPolicyDecision:]):
282         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
283         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
284
285 2019-01-31  Alex Christensen  <achristensen@webkit.org>
286
287         Revert r238819 which is unneeded and caused a performance regression.
288         https://bugs.webkit.org/show_bug.cgi?id=192272
289         <rdar://problem/46664625>
290
291         * WebCoreSupport/WebFrameLoaderClient.h:
292         * WebCoreSupport/WebFrameLoaderClient.mm:
293         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
294
295 2019-01-28  Devin Rousso  <drousso@apple.com>
296
297         Web Inspector: provide a way to edit page WebRTC settings on a remote target
298         https://bugs.webkit.org/show_bug.cgi?id=193863
299         <rdar://problem/47572764>
300
301         Reviewed by Joseph Pecoraro.
302
303         * WebView/WebView.mm:
304         (-[WebView _preferencesChanged:]):
305         Add page-level settings for WebRTC preferences.
306
307 2019-01-28  Andy Estes  <aestes@apple.com>
308
309         [watchOS] Enable Parental Controls content filtering
310         https://bugs.webkit.org/show_bug.cgi?id=193939
311         <rdar://problem/46641912>
312
313         Reviewed by Ryosuke Niwa.
314
315         * Configurations/FeatureDefines.xcconfig:
316
317 2019-01-28  Timothy Hatcher  <timothy@apple.com>
318
319         Make it easier for non-Apple ports to enable dark mode CSS support.
320         https://bugs.webkit.org/show_bug.cgi?id=193882
321
322         Reviewed by Megan Gardner.
323
324         * WebView/WebView.mm:
325         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
326         (-[WebView _effectiveAppearanceIsDark]): Ditto.
327
328 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
329
330         AX: Introduce a static accessibility tree
331         https://bugs.webkit.org/show_bug.cgi?id=193348
332         <rdar://problem/47203295>
333
334         Reviewed by Ryosuke Niwa.
335
336         * Configurations/FeatureDefines.xcconfig:
337
338 2019-01-25  Keith Rollin  <krollin@apple.com>
339
340         Update WebKitAdditions.xcconfig with correct order of variable definitions
341         https://bugs.webkit.org/show_bug.cgi?id=193793
342         <rdar://problem/47532439>
343
344         Reviewed by Alex Christensen.
345
346         XCBuild changes the way xcconfig variables are evaluated. In short,
347         all config file assignments are now considered in part of the
348         evaluation. When using the new build system and an .xcconfig file
349         contains multiple assignments of the same build setting:
350
351         - Later assignments using $(inherited) will inherit from earlier
352           assignments in the xcconfig file.
353         - Later assignments not using $(inherited) will take precedence over
354           earlier assignments. An assignment to a more general setting will
355           mask an earlier assignment to a less general setting. For example,
356           an assignment without a condition ('FOO = bar') will completely mask
357           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
358
359         This affects some of our .xcconfig files, in that sometimes platform-
360         or sdk-specific definitions appear before the general definitions.
361         Under the new evaluations rules, the general definitions alway take
362         effect because they always overwrite the more-specific definitions. The
363         solution is to swap the order, so that the general definitions are
364         established first, and then conditionally overwritten by the
365         more-specific definitions.
366
367         * Configurations/Version.xcconfig:
368         * Configurations/WebKitLegacy.xcconfig:
369
370 2019-01-25  David Kilzer  <ddkilzer@apple.com>
371
372         Move soft-linking of Lookup.framework out of LookupSPI.h
373         <https://webkit.org/b/193815>
374
375         Reviewed by Tim Horton.
376
377         * WebView/WebImmediateActionController.mm:
378         (-[WebImmediateActionController _animationControllerForText]):
379         * WebView/WebView.mm:
380         (-[WebView _prepareForDictionaryLookup]):
381         - Move soft-linking to LookupSoftLink.{h,mm}.
382
383 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
384
385         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
386         https://bugs.webkit.org/show_bug.cgi?id=193829
387
388         Reviewed by Tim Horton.
389
390         * WebCoreSupport/WebDragClient.mm:
391         (WebDragClient::didConcludeEditDrag):
392         * WebView/WebView.mm:
393         (-[WebView _requestStartDataInteraction:globalPosition:]):
394         (-[WebView _didConcludeEditDrag]):
395         (-[WebView _didConcludeEditDataInteraction]): Deleted.
396         * WebView/WebViewInternal.h:
397
398 2019-01-24  John Wilander  <wilander@apple.com>
399
400         Add Ad Click Attribution as an internal/experimental feature
401         https://bugs.webkit.org/show_bug.cgi?id=193685
402         <rdar://problem/47450399>
403
404         Reviewed by Brent Fulgham.
405
406         * WebView/WebPreferenceKeysPrivate.h:
407         * WebView/WebPreferences.mm:
408         (+[WebPreferences initialize]):
409         (-[WebPreferences adClickAttributionEnabled]):
410         (-[WebPreferences setAdClickAttributionEnabled:]):
411             Added support for experimental ad click attribution.
412         * WebView/WebPreferencesPrivate.h:
413         * WebView/WebView.mm:
414         (-[WebView _preferencesChanged:]):
415
416 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
417
418         Move FileSystem to WTF
419         https://bugs.webkit.org/show_bug.cgi?id=193602
420
421         Reviewed by Yusuke Suzuki.
422
423         * Misc/WebNSFileManagerExtras.mm:
424         * Storage/WebDatabaseProvider.mm:
425         * WebView/WebView.mm:
426
427 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
428
429         Fix the Apple Internal build. See <rdar://problem/47491383>.
430
431         Rubber-stamped by Tim Horton.
432
433         * WebCoreSupport/WebFrameLoaderClient.mm:
434
435 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
436
437         Clean up USE(WEB_THREAD)
438         https://bugs.webkit.org/show_bug.cgi?id=193698
439
440         Rubber-stamped by Tim Horton.
441
442         * Misc/WebCache.mm:
443         (+[WebCache emptyInMemoryResources]):
444         * WebCoreSupport/WebFrameLoaderClient.mm:
445         (-[WebFramePolicyListener use]):
446         * WebCoreSupport/WebGeolocationClient.mm:
447         (-[WebGeolocationPolicyListener allow]):
448         (-[WebGeolocationPolicyListener deny]):
449         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
450         * WebView/WebFrame.mm:
451         (-[WebFrame deviceOrientationChanged]):
452         * WebView/WebHTMLView.mm:
453         (hardwareKeyboardAvailabilityChangedCallback):
454         * WebView/WebView.mm:
455         (+[WebView _releaseMemoryNow]):
456         (+[WebView willEnterBackgroundWithCompletionHandler:]):
457         (-[WebView updateLayoutIgnorePendingStyleSheets]):
458         (-[WebView _dispatchUnloadEvent]):
459         (-[WebView _close]):
460         (-[WebView _preferencesChangedNotification:]):
461         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
462         (-[WebView goBack]):
463         (-[WebView goForward]):
464         (+[WebView _cacheModelChangedNotification:]):
465         (-[WebView stopLoading:]):
466         (-[WebView stopLoadingAndClear]):
467         (-[WebView reload:]):
468         (WebInstallMemoryPressureHandler):
469
470 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
471
472         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
473         https://bugs.webkit.org/show_bug.cgi?id=193706
474         <rdar://problem/44807048>
475
476         Reviewed by Ryosuke Niwa.
477
478         Use UndoStep::label().
479
480         * WebCoreSupport/WebEditorClient.h:
481         * WebCoreSupport/WebEditorClient.mm:
482         (-[WebUndoStep initWithUndoStep:]):
483         (+[WebUndoStep stepWithUndoStep:]):
484         (WebEditorClient::registerUndoOrRedoStep):
485         (WebEditorClient::registerUndoStep):
486         (WebEditorClient::registerRedoStep):
487
488 2019-01-22  Alex Christensen  <achristensen@webkit.org>
489
490         Move NetworkStorageSession ownership to NetworkProcess
491         https://bugs.webkit.org/show_bug.cgi?id=193580
492
493         Reviewed by Geoff Garen.
494
495         * Misc/WebCache.mm:
496         (+[WebCache clearCachedCredentials]):
497         * Misc/WebDownload.mm:
498         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
499         * Plugins/WebBaseNetscapePluginView.mm:
500         (WebKit::getAuthenticationInfo):
501         * WebCoreSupport/WebFrameNetworkingContext.mm:
502         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
503         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
504         (WebFrameNetworkingContext::storageSession const):
505         * WebView/WebPreferences.mm:
506         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
507         (+[WebPreferences _clearNetworkLoaderSession]):
508         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
509
510 2019-01-22  Daniel Bates  <dabates@apple.com>
511
512         [iOS] Interpret text key commands on keydown and app key commands on keypress
513         https://bugs.webkit.org/show_bug.cgi?id=192897
514         <rdar://problem/46857378>
515
516         Reviewed by Brent Fulgham.
517
518         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
519         is false) and keypress (isCharEvent is true), respectively.
520
521         * WebView/WebHTMLView.mm:
522         (-[WebHTMLView _handleEditingKeyEvent:]):
523
524 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
525
526         [css-logical] Implement flow-relative margin, padding and border shorthands
527         https://bugs.webkit.org/show_bug.cgi?id=188697
528
529         Reviewed by Simon Fraser and Antti Koivisto.
530
531         Add CSSLogicalEnabled runtime flag.
532
533         * WebView/WebPreferenceKeysPrivate.h:
534         * WebView/WebPreferences.mm:
535         (+[WebPreferences initialize]):
536         (-[WebPreferences cssLogicalEnabled]):
537         (-[WebPreferences setCSSLogicalEnabled:]):
538         * WebView/WebPreferencesPrivate.h:
539         * WebView/WebView.mm:
540         (-[WebView _preferencesChanged:]):
541
542 2019-01-15  Darin Adler  <darin@apple.com>
543
544         Use references rather than pointers for register/unregister functions, and more
545         https://bugs.webkit.org/show_bug.cgi?id=175028
546
547         Reviewed by Daniel Bates.
548
549         * WebCoreSupport/WebKitFullScreenListener.mm:
550         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
551         functions in Document; pass a reference.
552         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
553         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
554         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
555         * WebView/WebFullScreenController.mm:
556         (-[WebFullScreenController enterFullScreen:]): Ditto.
557         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
558         (-[WebFullScreenController exitFullScreen]): Ditto.
559         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
560         * WebView/WebFullScreenController.mm:
561         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
562
563 2019-01-12  Dan Bernstein  <mitz@apple.com>
564
565         [Cocoa] Avoid importing directly from subumbrella frameworks
566         https://bugs.webkit.org/show_bug.cgi?id=186016
567         <rdar://problem/40591038>
568
569         Reviewed by Sam Weinig.
570
571         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
572         * Carbon/CarbonWindowAdapter.mm: Ditto.
573         * Carbon/CarbonWindowFrame.m: Ditto.
574         * Carbon/HIViewAdapter.h: Ditto.
575         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
576           OTHER_CFLAGS_COCOA_TOUCH_NO.
577         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
578         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
579         * WebView/WebPDFView.h: Ditto.
580
581 2019-01-20  Antoine Quint  <graouts@apple.com>
582
583         Add a POINTER_EVENTS feature flag
584         https://bugs.webkit.org/show_bug.cgi?id=193577
585         <rdar://problem/47408511>
586
587         Unreviewed. Also enable Pointer Events for iosmac.
588
589         * Configurations/FeatureDefines.xcconfig:
590
591 2019-01-19  Antoine Quint  <graouts@apple.com>
592
593         Add a POINTER_EVENTS feature flag
594         https://bugs.webkit.org/show_bug.cgi?id=193577
595
596         Reviewed by Dean Jackson.
597
598         * Configurations/FeatureDefines.xcconfig:
599
600 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
601
602         Revert r238815, it broke WK1 video fullscreen on Mac
603         https://bugs.webkit.org/show_bug.cgi?id=193586
604         <rdar://problem/47358941>
605
606         Reviewed by Jer Noble.
607
608         * WebView/WebVideoFullscreenController.h: Added.
609         * WebView/WebVideoFullscreenController.mm: Added.
610         (SOFT_LINK_CLASS):
611         (-[WebVideoFullscreenController init]):
612         (-[WebVideoFullscreenController dealloc]):
613         (-[WebVideoFullscreenController fullscreenWindow]):
614         (-[WebVideoFullscreenController windowDidLoad]):
615         (-[WebVideoFullscreenController videoElement]):
616         (-[WebVideoFullscreenController setVideoElement:]):
617         (-[WebVideoFullscreenController clearFadeAnimation]):
618         (-[WebVideoFullscreenController windowDidExitFullscreen]):
619         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
620         (-[WebVideoFullscreenController videoElementRect]):
621         (-[WebVideoFullscreenController applicationDidResignActive:]):
622         (frameExpandedToRatioOfFrame):
623         (createBackgroundFullscreenWindow):
624         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
625         (-[WebVideoFullscreenController enterFullscreen:]):
626         (-[WebVideoFullscreenController exitFullscreen]):
627         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
628         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
629         (-[WebVideoFullscreenController _requestExit]):
630         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
631         (-[WebVideoFullscreenController requestExitFullscreen]):
632         (-[WebVideoFullscreenController fadeHUDIn]):
633         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
634         (-[WebVideoFullscreenController rateChanged:]):
635         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
636         (-[WebVideoFullscreenWindow dealloc]):
637         (-[WebVideoFullscreenWindow resignFirstResponder]):
638         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
639         (-[WebVideoFullscreenWindow mouseDown:]):
640         (-[WebVideoFullscreenWindow cancelOperation:]):
641         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
642         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
643         (-[WebVideoFullscreenWindow animationDidEnd:]):
644         (-[WebVideoFullscreenWindow mouseMoved:]):
645         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
646         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
647         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
648         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
649         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
650         (-[WebVideoFullscreenHUDWindow center]):
651         (-[WebVideoFullscreenHUDWindow keyDown:]):
652         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
653         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
654         (-[WebVideoFullscreenHUDWindowController init]):
655         (-[WebVideoFullscreenHUDWindowController dealloc]):
656         (-[WebVideoFullscreenHUDWindowController setArea:]):
657         (-[WebVideoFullscreenHUDWindowController keyDown:]):
658         (-[WebVideoFullscreenHUDWindowController delegate]):
659         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
660         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
661         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
662         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
663         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
664         (-[WebVideoFullscreenHUDWindowController closeWindow]):
665         (createMediaUIControl):
666         (createControlWithMediaUIControlType):
667         (createTimeTextField):
668         (createMediaUIBackgroundView):
669         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
670         (-[WebVideoFullscreenHUDWindowController updateVolume]):
671         (-[WebVideoFullscreenHUDWindowController updateTime]):
672         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
673         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
674         (-[WebVideoFullscreenHUDWindowController currentTime]):
675         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
676         (-[WebVideoFullscreenHUDWindowController duration]):
677         (-[WebVideoFullscreenHUDWindowController maxVolume]):
678         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
679         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
680         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
681         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
682         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
683         (-[WebVideoFullscreenHUDWindowController volume]):
684         (-[WebVideoFullscreenHUDWindowController setVolume:]):
685         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
686         (-[WebVideoFullscreenHUDWindowController updateRate]):
687         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
688         (-[WebVideoFullscreenHUDWindowController playing]):
689         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
690         (timeToString):
691         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
692         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
693         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
694         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
695         (-[WebVideoFullscreenHUDWindowController rewind:]):
696         (-[WebVideoFullscreenHUDWindowController fastForward:]):
697         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
698         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
699         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
700         * WebView/WebView.mm:
701         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
702         (-[WebView _exitVideoFullscreen]):
703
704 2019-01-18  Tim Horton  <timothy_horton@apple.com>
705
706         Get rid of ADVANCED_SPELL_CHECKING
707         https://bugs.webkit.org/show_bug.cgi?id=193592
708
709         Reviewed by Wenson Hsieh.
710
711         * WebCoreSupport/WebEditorClient.mm:
712         (insertionPointFromCurrentSelection):
713         (WebEditorClient::checkTextOfParagraph):
714         (WebEditorClient::getGuessesForWord):
715         (WebEditorClient::requestCandidatesForSelection):
716         (WebEditorClient::requestCheckingOfString):
717         * WebView/WebHTMLView.mm:
718         (-[WebHTMLView insertText:]):
719
720 2019-01-18  Jer Noble  <jer.noble@apple.com>
721
722         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
723         https://bugs.webkit.org/show_bug.cgi?id=189553
724
725         Reviewed by Tim Horton.
726
727         * Configurations/Base.xcconfig:
728         * Configurations/SDKVariant.xcconfig: Added.
729         * Configurations/WebKitLegacy.xcconfig:
730
731 2019-01-18  David Kilzer  <ddkilzer@apple.com>
732
733         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
734         <https://webkit.org/b/193568>
735         <rdar://problem/47381130>
736
737         Reviewed by Alex Christensen.
738
739         * WebView/WebView.mm:
740         - Remove unused soft-linking macros.
741         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
742         (-[WebUITextIndicatorData initWithImage:scale:]):
743         - Update to use exported PAL functions.
744
745 2019-01-17  Truitt Savell  <tsavell@apple.com>
746
747         Unreviewed, rolling out r240124.
748
749         This commit broke an internal build.
750
751         Reverted changeset:
752
753         "SDK_VARIANT build destinations should be separate from non-
754         SDK_VARIANT builds"
755         https://bugs.webkit.org/show_bug.cgi?id=189553
756         https://trac.webkit.org/changeset/240124
757
758 2019-01-17  Jer Noble  <jer.noble@apple.com>
759
760         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
761         https://bugs.webkit.org/show_bug.cgi?id=189553
762
763         Reviewed by Tim Horton.
764
765         * Configurations/Base.xcconfig:
766         * Configurations/SDKVariant.xcconfig: Added.
767         * Configurations/WebKitLegacy.xcconfig:
768
769 2019-01-17  Alex Christensen  <achristensen@webkit.org>
770
771         Stop using NetworkStorageSession::storageSession in WebCore
772         https://bugs.webkit.org/show_bug.cgi?id=193529
773
774         Reviewed by Tim Horton.
775
776         * Misc/WebCache.mm:
777         (+[WebCache addImageToCache:forURL:forFrame:]):
778         * WebView/WebView.mm:
779         (-[WebView _commonInitializationWithFrameName:groupName:]):
780         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
781
782 2019-01-15  Alex Christensen  <achristensen@webkit.org>
783
784         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
785         https://bugs.webkit.org/show_bug.cgi?id=193368
786
787         Reviewed by Geoff Garen.
788
789         * Misc/WebCache.mm:
790         (+[WebCache clearCachedCredentials]):
791         * Misc/WebDownload.mm:
792         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
793         * Plugins/WebBaseNetscapePluginView.mm:
794         (WebKit::getAuthenticationInfo):
795
796 2019-01-15  Alex Christensen  <achristensen@webkit.org>
797
798         Stop using CookiesStrategy
799         https://bugs.webkit.org/show_bug.cgi?id=161106
800
801         Reviewed by Don Olmstead and Antti Koivisto.
802
803         * Misc/WebCache.mm:
804         (+[WebCache addImageToCache:forURL:forFrame:]):
805         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
806         (WebKit::NetscapePluginInstanceProxy::getCookies):
807         (WebKit::NetscapePluginInstanceProxy::setCookies):
808         * Plugins/WebNetscapePluginView.mm:
809         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
810         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
811         * WebCoreSupport/WebPlatformStrategies.h:
812         * WebCoreSupport/WebPlatformStrategies.mm:
813         (WebPlatformStrategies::createCookiesStrategy): Deleted.
814         (WebPlatformStrategies::cookiesForDOM): Deleted.
815         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
816         (WebPlatformStrategies::cookiesEnabled): Deleted.
817         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
818         (WebPlatformStrategies::getRawCookies): Deleted.
819         (WebPlatformStrategies::deleteCookie): Deleted.
820         * WebView/WebView.mm:
821         (-[WebView _commonInitializationWithFrameName:groupName:]):
822         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
823
824 2019-01-15  Tim Horton  <timothy_horton@apple.com>
825
826         Cannot tab out of WKWebView on macOS
827         https://bugs.webkit.org/show_bug.cgi?id=161448
828         <rdar://problem/28100085>
829
830         Reviewed by Dean Jackson.
831
832         * WebCoreSupport/WebChromeClient.mm:
833         * WebView/WebView.mm:
834         Make use of SPI headers.
835
836 2019-01-14  Commit Queue  <commit-queue@webkit.org>
837
838         Unreviewed, rolling out r239901, r239909, r239910, r239912,
839         r239913, and r239914.
840         https://bugs.webkit.org/show_bug.cgi?id=193407
841
842         These revisions caused an internal failure (Requested by
843         Truitt on #webkit).
844
845         Reverted changesets:
846
847         "[Cocoa] Avoid importing directly from subumbrella frameworks"
848         https://bugs.webkit.org/show_bug.cgi?id=186016
849         https://trac.webkit.org/changeset/239901
850
851         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
852         https://trac.webkit.org/changeset/239909
853
854         "Tried to fix the build."
855         https://trac.webkit.org/changeset/239910
856
857         "Fixed iOS builds after r239910."
858         https://trac.webkit.org/changeset/239912
859
860         "More build fixing."
861         https://trac.webkit.org/changeset/239913
862
863         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
864         https://trac.webkit.org/changeset/239914
865
866 2019-01-14  Mark Lam  <mark.lam@apple.com>
867
868         Re-enable ability to build --cloop builds.
869         https://bugs.webkit.org/show_bug.cgi?id=192955
870         <rdar://problem/46882363>
871
872         Reviewed by Saam barati and Keith Miller.
873
874         * Configurations/FeatureDefines.xcconfig:
875
876 2019-01-13  Dan Bernstein  <mitz@apple.com>
877
878         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
879
880         Patch by Keith Rollin.
881
882         * WebView/PDFViewSPI.h:
883
884 2019-01-12  Timothy Hatcher  <timothy@apple.com>
885
886         Have prefers-color-scheme: light always match on macOS versions before Mojave.
887         https://bugs.webkit.org/show_bug.cgi?id=191655
888         rdar://problem/46074680
889
890         Reviewed by Megan Gardner.
891
892         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
893         * WebView/WebView.mm:
894         (-[WebView _effectiveAppearanceIsDark]):
895
896 2019-01-12  Dan Bernstein  <mitz@apple.com>
897
898         [Cocoa] Avoid importing directly from subumbrella frameworks
899         https://bugs.webkit.org/show_bug.cgi?id=186016
900         <rdar://problem/40591038>
901
902         Reviewed by Sam Weinig.
903
904         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
905         * Carbon/CarbonWindowAdapter.mm: Ditto.
906         * Carbon/CarbonWindowFrame.m: Ditto.
907         * Carbon/HIViewAdapter.h: Ditto.
908         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
909           OTHER_CFLAGS_COCOA_TOUCH_NO.
910         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
911         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
912         * WebView/WebPDFView.h: Ditto.
913
914 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
915
916         Enable visual viewport API by default
917         https://bugs.webkit.org/show_bug.cgi?id=193376
918
919         Reviewed by Simon Fraser.
920
921         * WebView/WebPreferences.mm:
922         (+[WebPreferences initialize]):
923
924 2019-01-11  John Wilander  <wilander@apple.com>
925
926         Compile out Web API Statistics Collection
927         https://bugs.webkit.org/show_bug.cgi?id=193370
928         <rdar://problem/45388584>
929
930         Reviewed by Brent Fulgham.
931
932         * Configurations/FeatureDefines.xcconfig:
933             Defined ENABLE_WEB_API_STATISTICS, off by default.
934
935 2019-01-08  Alex Christensen  <achristensen@webkit.org>
936
937         Stop using NetworkStorageSession in WebProcess
938         https://bugs.webkit.org/show_bug.cgi?id=193236
939
940         Reviewed by Don Olmstead.
941
942         * WebCoreSupport/WebFrameNetworkingContext.h:
943         * WebCoreSupport/WebFrameNetworkingContext.mm:
944         (WebFrameNetworkingContext::storageSession const):
945         * WebCoreSupport/WebPlatformStrategies.h:
946         * WebCoreSupport/WebPlatformStrategies.mm:
947         (WebPlatformStrategies::cookiesForDOM):
948         (WebPlatformStrategies::setCookiesFromDOM):
949         (WebPlatformStrategies::cookiesEnabled):
950         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
951         (WebPlatformStrategies::getRawCookies):
952         (WebPlatformStrategies::deleteCookie):
953         * WebView/WebView.mm:
954         (-[WebView _cachedResponseForURL:]):
955         (-[WebView _clearCredentials]):
956
957 2019-01-08  Alex Christensen  <achristensen@webkit.org>
958
959         Unreviewed, rolling out r239727.
960
961         Broke API tests
962
963         Reverted changeset:
964
965         "Stop using NetworkStorageSession in WebProcess"
966         https://bugs.webkit.org/show_bug.cgi?id=193236
967         https://trac.webkit.org/changeset/239727
968
969 2019-01-08  Alex Christensen  <achristensen@webkit.org>
970
971         Stop using NetworkStorageSession in WebProcess
972         https://bugs.webkit.org/show_bug.cgi?id=193236
973
974         Reviewed by Don Olmstead.
975
976         * WebCoreSupport/WebFrameNetworkingContext.h:
977         * WebCoreSupport/WebFrameNetworkingContext.mm:
978         (WebFrameNetworkingContext::storageSession const):
979         * WebView/WebView.mm:
980         (-[WebView _cachedResponseForURL:]):
981         (-[WebView _clearCredentials]):
982
983 2019-01-07  David Kilzer  <ddkilzer@apple.com>
984
985         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
986         <https://webkit.org/b/193056>
987
988         Reviewed by Alex Christensen.
989
990         * Plugins/Hosted/NetscapePluginHostProxy.h:
991         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
992         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
993         (WebKit::NetscapePluginInstanceProxy::enumerate):
994         (WebKit::NetscapePluginInstanceProxy::marshalValue):
995         (WebKit::NetscapePluginInstanceProxy::marshalValues):
996         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
997         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
998         * Plugins/Hosted/ProxyInstance.mm:
999         (WebKit::ProxyInstance::invoke):
1000         * WebCoreSupport/WebGeolocationClient.mm:
1001         * WebView/WebDataSource.mm:
1002         (-[WebDataSource _receivedData:]):
1003         * WebView/WebView.mm:
1004         (-[WebView _cachedResponseForURL:]):
1005         - Remove '*' from RetainPtr<> type.
1006
1007 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1008
1009         Progress towards fixing Mac CMake build
1010         https://bugs.webkit.org/show_bug.cgi?id=193105
1011
1012         Reviewed by Don Olmstead.
1013
1014         * WebKitPrefix.h:
1015
1016 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1017
1018         Web Inspector: Use save sheet instead of dialog where possible
1019         https://bugs.webkit.org/show_bug.cgi?id=193160
1020         <rdar://problem/37399759>
1021
1022         Reviewed by Devin Rousso.
1023
1024         * WebCoreSupport/WebInspectorClient.mm:
1025         (WebInspectorFrontendClient::save):
1026
1027 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1028
1029         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1030         https://bugs.webkit.org/show_bug.cgi?id=193129
1031
1032         Reviewed by Tim Horton.
1033
1034         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1035
1036         * WebCoreSupport/WebEditorClient.mm:
1037         (WebEditorClient::registerUndoOrRedoStep):
1038         (undoNameForEditAction): Deleted.
1039
1040 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1041
1042         Add support for using the current text selection as the find string on iOS
1043         https://bugs.webkit.org/show_bug.cgi?id=193034
1044         <rdar://problem/45138739>
1045
1046         Reviewed by Tim Horton.
1047
1048         Add a method stub for WebKitLegacy.
1049
1050         * WebCoreSupport/WebEditorClient.h:
1051
1052 2019-01-01  Jeff Miller  <jeffm@apple.com>
1053
1054         Update user-visible copyright strings to include 2019
1055         https://bugs.webkit.org/show_bug.cgi?id=192811
1056
1057         Reviewed by Mark Lam.
1058
1059         * Info.plist:
1060
1061 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1062
1063         Use Ref<> as much as possible
1064         https://bugs.webkit.org/show_bug.cgi?id=192808
1065
1066         Reviewed by Alex Christensen.
1067
1068         * DOM/DOM.mm:
1069         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1070         * Plugins/Hosted/NetscapePluginHostManager.mm:
1071         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1072         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1073         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1074         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1075         * Plugins/WebNetscapePluginView.mm:
1076         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1077         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1078         * WebCoreSupport/WebContextMenuClient.mm:
1079         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1080         * WebCoreSupport/WebFrameLoaderClient.mm:
1081         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1082         * WebView/WebFrame.mm:
1083         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1084         * WebView/WebHTMLView.mm:
1085         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1086         * WebView/WebView.mm:
1087         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1088         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1089
1090 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1091
1092         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1093         https://bugs.webkit.org/show_bug.cgi?id=192821
1094
1095         Reviewed by Chris Dumez.
1096
1097         When a window becomes occluded, the window server informs the application.
1098         This should be used to suspend any work that is not visible by the user.
1099
1100         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1101         In some cases, that lead to performance impact (see radar).
1102
1103         This patch adds an observer for the occlusion notification. I tried to stick
1104         with the same names used by WebKit2.
1105
1106         * WebView/WebView.mm:
1107         (-[WebView _isViewVisible]):
1108         (-[WebView addWindowObserversForWindow:]):
1109         (-[WebView removeWindowObservers]):
1110         (-[WebView _windowDidChangeOcclusionState:]):
1111
1112 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1113
1114         [WebAuthN] Add a runtime flag for local authenticator
1115         https://bugs.webkit.org/show_bug.cgi?id=192792
1116         <rdar://problem/46798738>
1117
1118         Reviewed by Brent Fulgham.
1119
1120         * WebView/WebPreferenceKeysPrivate.h:
1121         * WebView/WebPreferences.mm:
1122         (+[WebPreferences initialize]):
1123         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1124         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1125         * WebView/WebPreferencesPrivate.h:
1126         * WebView/WebView.mm:
1127         (-[WebView _preferencesChanged:]):
1128
1129 2018-12-20  Chris Dumez  <cdumez@apple.com>
1130
1131         Use Optional::valueOr() instead of Optional::value_or()
1132         https://bugs.webkit.org/show_bug.cgi?id=192933
1133
1134         Reviewed by Geoffrey Garen.
1135
1136         * WebCoreSupport/WebSecurityOrigin.mm:
1137         (-[WebSecurityOrigin port]):
1138
1139 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1140
1141         Unreviewed, rolling out r239417.
1142
1143         Introduced two API test failures on macOS.
1144
1145         Reverted changeset:
1146
1147         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1148         occlusion changes"
1149         https://bugs.webkit.org/show_bug.cgi?id=192821
1150         https://trac.webkit.org/changeset/239417
1151
1152 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1153
1154         WKWebView default UA doesn't freeze the build number
1155         https://bugs.webkit.org/show_bug.cgi?id=192809
1156         <rdar://problem/44687185>
1157
1158         Reviewed by Andy Estes.
1159
1160         Always reports the frozen build number.
1161
1162         * WebView/WebView.mm:
1163         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1164         actual build number through this method call.
1165         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1166
1167 2018-12-19  Chris Dumez  <cdumez@apple.com>
1168
1169         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1170         https://bugs.webkit.org/show_bug.cgi?id=192728
1171         <rdar://problem/46746779>
1172
1173         Reviewed by Geoff Garen.
1174
1175         * DOM/*:
1176         * Plugins/*:
1177         * WebCoreSupport/*:
1178         * WebView/*:
1179
1180 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1181
1182         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1183         https://bugs.webkit.org/show_bug.cgi?id=192821
1184
1185         Reviewed by Chris Dumez.
1186
1187         When a window becomes occluded, the window server informs the application.
1188         This should be used to suspend any work that is not visible by the user.
1189
1190         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1191         In some cases, that lead to performance impact (see radar).
1192
1193         This patch adds an observer for the occlusion notification. I tried to stick
1194         with the same names used by WebKit2.
1195
1196         * WebView/WebView.mm:
1197         (-[WebView _isViewVisible]):
1198         (-[WebView addWindowObserversForWindow:]):
1199         (-[WebView removeWindowObservers]):
1200         (-[WebView _windowDidChangeOcclusionState:]):
1201
1202 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1203
1204         Allow clients to set the navigator platform
1205         https://bugs.webkit.org/show_bug.cgi?id=192735
1206
1207         Reviewed by Tim Horton.
1208
1209         Add stubs to fill out the added functionality in FrameLoaderClient.
1210
1211         * WebCoreSupport/WebFrameLoaderClient.h:
1212         * WebCoreSupport/WebFrameLoaderClient.mm:
1213         (WebFrameLoaderClient::navigatorPlatform):
1214
1215 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1216
1217         offsetLeft and offsetParent should adjust across shadow boundaries
1218         https://bugs.webkit.org/show_bug.cgi?id=157437
1219         <rdar://problem/26154021>
1220
1221         Reviewed by Simon Fraser.
1222
1223         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1224
1225         * DOM/DOMElement.mm:
1226         (-[DOMElement offsetLeft]):
1227         (-[DOMElement offsetTop]):
1228         (-[DOMElement offsetParent]):
1229
1230 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1231
1232         Unreviewed build fix.
1233
1234         * WebView/WebFrame.mm:
1235         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1236
1237 2018-12-15  Darin Adler  <darin@apple.com>
1238
1239         Use warning-ignoring macros more consistently and simply
1240         https://bugs.webkit.org/show_bug.cgi?id=192743
1241
1242         Reviewed by Mark Lam.
1243
1244         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1245         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1246         compilers in Objective-C++ code.
1247
1248         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1249         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1250         accomodate non-clang compilers here. Also use #pragma once, add a missing
1251         "explicit" and fix conditionals.
1252
1253 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1254
1255         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1256         https://bugs.webkit.org/show_bug.cgi?id=192653
1257
1258         Reviewed by Wenson Hsieh.
1259
1260         * WebView/WebHTMLView.mm:
1261         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1262
1263 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1264
1265         Implement feature flag for CSS Typed OM
1266         https://bugs.webkit.org/show_bug.cgi?id=192610
1267
1268         Reviewed by Ryosuke Niwa.
1269
1270         * Configurations/FeatureDefines.xcconfig:
1271
1272 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1273
1274         WebCore shouldn't have a Objective-C class named NSCursor
1275         https://bugs.webkit.org/show_bug.cgi?id=192602
1276         <rdar://problem/46615532>
1277
1278         Reviewed by Wenson Hsieh.
1279
1280         * WebView/WebFrameView.mm:
1281         (-[WebFrameView keyDown:keyDown:]):
1282         * WebView/WebHTMLView.mm:
1283         (-[WebHTMLView keyDown:]):
1284         (-[WebHTMLView performKeyEquivalent:]):
1285         Only use NSCursor on macOS.
1286
1287 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1288
1289         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1290         https://bugs.webkit.org/show_bug.cgi?id=192573
1291
1292         Reviewed by Simon Fraser.
1293
1294         * Configurations/FeatureDefines.xcconfig:
1295
1296 2018-12-10  Antti Koivisto  <antti@apple.com>
1297
1298         Rename "forced style recalc" to "full style rebuild"
1299         https://bugs.webkit.org/show_bug.cgi?id=192572
1300
1301         Reviewed by Zalan Bujtas.
1302
1303         * WebView/WebHTMLView.mm:
1304         (-[WebHTMLView setNeedsToApplyStyles:]):
1305
1306 2018-12-10  Darin Adler  <darin@apple.com>
1307
1308         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1309         https://bugs.webkit.org/show_bug.cgi?id=192533
1310         rdar://problem/45732710
1311
1312         Reviewed by Anders Carlsson.
1313
1314         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1315         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1316
1317 2018-12-10  Darin Adler  <darin@apple.com>
1318
1319         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1320         https://bugs.webkit.org/show_bug.cgi?id=192532
1321         rdar://problem/45731047
1322
1323         Reviewed by Chris Dumez.
1324
1325         * Plugins/Hosted/NetscapePluginHostManager.mm:
1326         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1327         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1328         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1329
1330 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1331
1332         Turn WritingDirection into an enum class
1333         https://bugs.webkit.org/show_bug.cgi?id=192401
1334         Work towards <rdar://problem/42075638>
1335
1336         Reviewed by Dan Bernstein.
1337
1338         Change WritingDirection from an enum to an enum class. No change in behavior.
1339
1340         * WebView/WebHTMLView.mm:
1341         (-[WebHTMLView toggleBaseWritingDirection:]):
1342         (-[WebHTMLView changeBaseWritingDirection:]):
1343         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1344
1345 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1346
1347         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1348         https://bugs.webkit.org/show_bug.cgi?id=192272
1349
1350         Reviewed by Brady Eidson.
1351
1352         * WebCoreSupport/WebFrameLoaderClient.h:
1353         * WebCoreSupport/WebFrameLoaderClient.mm:
1354         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1355
1356 2018-12-03  Jer Noble  <jer.noble@apple.com>
1357
1358         Get rid of old, dead Mac video fullscreen code.
1359         https://bugs.webkit.org/show_bug.cgi?id=192315
1360
1361         Reviewed by Eric Carlson.
1362
1363         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1364         is no longer supported in the Mac port.
1365
1366         * WebView/WebVideoFullscreenController.h: Removed.
1367         * WebView/WebVideoFullscreenController.mm: Removed.
1368         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1369         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1370         * WebView/WebView.mm:
1371         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1372         (-[WebView _exitVideoFullscreen]):
1373
1374 2018-12-03  Daniel Bates  <dabates@apple.com>
1375
1376         [iOS] Do not handle key events that are key commands
1377         https://bugs.webkit.org/show_bug.cgi?id=191608
1378         <rdar://problem/46046013>
1379
1380         Reviewed by Ryosuke Niwa.
1381
1382         A key down event may be associated with a key command. If it is then we want to execute the
1383         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1384         event as a key command to find out.
1385
1386         * WebView/WebHTMLView.mm:
1387         (-[WebHTMLView _handleEditingKeyEvent:]):
1388
1389 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1390
1391         Add a runtime feature flag for LayoutFormattingContext.
1392         https://bugs.webkit.org/show_bug.cgi?id=192280
1393
1394         Reviewed by Simon Fraser.
1395
1396         * Configurations/FeatureDefines.xcconfig:
1397
1398 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1399
1400         Move URL from WebCore to WTF
1401         https://bugs.webkit.org/show_bug.cgi?id=190234
1402
1403         Reviewed by Keith Miller.
1404
1405         * DOM/DOMAttr.mm:
1406         * DOM/DOMBlob.mm:
1407         * DOM/DOMCSSCharsetRule.mm:
1408         * DOM/DOMCSSImportRule.mm:
1409         * DOM/DOMCSSMediaRule.mm:
1410         * DOM/DOMCSSPageRule.mm:
1411         * DOM/DOMCSSPrimitiveValue.mm:
1412         * DOM/DOMCSSRule.mm:
1413         * DOM/DOMCSSStyleDeclaration.mm:
1414         * DOM/DOMCSSStyleRule.mm:
1415         * DOM/DOMCSSStyleSheet.mm:
1416         * DOM/DOMCSSValue.mm:
1417         * DOM/DOMCharacterData.mm:
1418         * DOM/DOMCounter.mm:
1419         * DOM/DOMDocument.mm:
1420         * DOM/DOMDocumentFragment.mm:
1421         * DOM/DOMDocumentType.mm:
1422         * DOM/DOMEvent.mm:
1423         * DOM/DOMFile.mm:
1424         * DOM/DOMHTMLAnchorElement.mm:
1425         * DOM/DOMHTMLAppletElement.mm:
1426         * DOM/DOMHTMLAreaElement.mm:
1427         * DOM/DOMHTMLBRElement.mm:
1428         * DOM/DOMHTMLBaseElement.mm:
1429         * DOM/DOMHTMLBaseFontElement.mm:
1430         * DOM/DOMHTMLBodyElement.mm:
1431         * DOM/DOMHTMLButtonElement.mm:
1432         * DOM/DOMHTMLCanvasElement.mm:
1433         * DOM/DOMHTMLCollection.mm:
1434         * DOM/DOMHTMLDivElement.mm:
1435         * DOM/DOMHTMLDocument.mm:
1436         * DOM/DOMHTMLElement.mm:
1437         * DOM/DOMHTMLEmbedElement.mm:
1438         * DOM/DOMHTMLFieldSetElement.mm:
1439         * DOM/DOMHTMLFontElement.mm:
1440         * DOM/DOMHTMLFormElement.mm:
1441         * DOM/DOMHTMLFrameElement.mm:
1442         * DOM/DOMHTMLFrameSetElement.mm:
1443         * DOM/DOMHTMLHRElement.mm:
1444         * DOM/DOMHTMLHeadElement.mm:
1445         * DOM/DOMHTMLHeadingElement.mm:
1446         * DOM/DOMHTMLHtmlElement.mm:
1447         * DOM/DOMHTMLIFrameElement.mm:
1448         * DOM/DOMHTMLImageElement.mm:
1449         * DOM/DOMHTMLInputElement.mm:
1450         * DOM/DOMHTMLLIElement.mm:
1451         * DOM/DOMHTMLLabelElement.mm:
1452         * DOM/DOMHTMLLegendElement.mm:
1453         * DOM/DOMHTMLLinkElement.mm:
1454         * DOM/DOMHTMLMapElement.mm:
1455         * DOM/DOMHTMLMarqueeElement.mm:
1456         * DOM/DOMHTMLMediaElement.mm:
1457         * DOM/DOMHTMLMetaElement.mm:
1458         * DOM/DOMHTMLModElement.mm:
1459         * DOM/DOMHTMLOListElement.mm:
1460         * DOM/DOMHTMLObjectElement.mm:
1461         * DOM/DOMHTMLOptGroupElement.mm:
1462         * DOM/DOMHTMLOptionElement.mm:
1463         * DOM/DOMHTMLOptionsCollection.mm:
1464         * DOM/DOMHTMLParagraphElement.mm:
1465         * DOM/DOMHTMLParamElement.mm:
1466         * DOM/DOMHTMLQuoteElement.mm:
1467         * DOM/DOMHTMLScriptElement.mm:
1468         * DOM/DOMHTMLSelectElement.mm:
1469         * DOM/DOMHTMLStyleElement.mm:
1470         * DOM/DOMHTMLTableCaptionElement.mm:
1471         * DOM/DOMHTMLTableCellElement.mm:
1472         * DOM/DOMHTMLTableColElement.mm:
1473         * DOM/DOMHTMLTableElement.mm:
1474         * DOM/DOMHTMLTableRowElement.mm:
1475         * DOM/DOMHTMLTableSectionElement.mm:
1476         * DOM/DOMHTMLTitleElement.mm:
1477         * DOM/DOMHTMLUListElement.mm:
1478         * DOM/DOMHTMLVideoElement.mm:
1479         * DOM/DOMKeyboardEvent.mm:
1480         * DOM/DOMMediaList.mm:
1481         * DOM/DOMMouseEvent.mm:
1482         * DOM/DOMMutationEvent.mm:
1483         * DOM/DOMNamedNodeMap.mm:
1484         * DOM/DOMProcessingInstruction.mm:
1485         * DOM/DOMRange.mm:
1486         * DOM/DOMStyleSheet.mm:
1487         * DOM/DOMText.mm:
1488         * DOM/DOMTextEvent.mm:
1489         * DOM/DOMTokenList.mm:
1490         * DOM/DOMUIEvent.mm:
1491         * DOM/DOMXPathResult.mm:
1492         * History/WebHistoryItem.mm:
1493         * Misc/WebNSURLExtras.mm:
1494         (-[NSURL _web_userVisibleString]):
1495         (-[NSURL _web_URLByRemovingUserInfo]):
1496         (-[NSURL _web_dataForURLComponentType:]):
1497         (-[NSURL _web_schemeData]):
1498         (-[NSURL _web_hostData]):
1499         * Misc/WebUserContentURLPattern.mm:
1500         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1501         * Plugins/WebNetscapePluginStream.h:
1502         (WebNetscapePluginStream::setRequestURL):
1503         * WebCoreSupport/WebChromeClient.h:
1504         * WebCoreSupport/WebChromeClient.mm:
1505         (WebChromeClient::signedPublicKeyAndChallengeString const):
1506         * WebCoreSupport/WebContextMenuClient.h:
1507         * WebCoreSupport/WebContextMenuClient.mm:
1508         * WebCoreSupport/WebDragClient.h:
1509         * WebCoreSupport/WebFrameLoaderClient.h:
1510         * WebCoreSupport/WebFrameLoaderClient.mm:
1511         (WebFrameLoaderClient::updateGlobalHistory):
1512         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1513         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1514         (WebPaymentCoordinatorClient::showPaymentUI):
1515         * WebCoreSupport/WebPlatformStrategies.h:
1516         * WebCoreSupport/WebPlatformStrategies.mm:
1517         (WebPlatformStrategies::readURLFromPasteboard):
1518         * WebCoreSupport/WebPluginInfoProvider.h:
1519         * WebCoreSupport/WebPluginInfoProvider.mm:
1520         (WebPluginInfoProvider::webVisiblePluginInfo):
1521         * WebCoreSupport/WebSecurityOrigin.mm:
1522         * WebCoreSupport/WebVisitedLinkStore.h:
1523         * WebView/WebDataSource.mm:
1524         * WebView/WebFrame.mm:
1525         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1526         * WebView/WebImmediateActionController.mm:
1527         (-[WebImmediateActionController _defaultAnimationController]):
1528         * WebView/WebPDFView.mm:
1529         * WebView/WebScriptDebugger.mm:
1530         * WebView/WebViewInternal.h:
1531
1532 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1533
1534         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1535         https://bugs.webkit.org/show_bug.cgi?id=192197
1536
1537         Reviewed by Jiewen Tan.
1538
1539         * Configurations/FeatureDefines.xcconfig:
1540         * WebCoreSupport/WebChromeClient.h:
1541         * WebCoreSupport/WebChromeClient.mm:
1542
1543 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1544
1545         Remove dead code from an earlier attempt at implementing safe browsing
1546         https://bugs.webkit.org/show_bug.cgi?id=192067
1547
1548         Reviewed by Chris Dumez.
1549
1550         * WebCoreSupport/WebFrameLoaderClient.h:
1551         * WebCoreSupport/WebFrameLoaderClient.mm:
1552         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1553
1554 2018-11-27  Mark Lam  <mark.lam@apple.com>
1555
1556         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1557         https://bugs.webkit.org/show_bug.cgi?id=192055
1558         <rdar://problem/46288783>
1559
1560         Reviewed by Saam Barati.
1561
1562         * Configurations/FeatureDefines.xcconfig:
1563
1564 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1565
1566         Make it possible to insert editable images with a gesture
1567         https://bugs.webkit.org/show_bug.cgi?id=191937
1568
1569         Reviewed by Wenson Hsieh.
1570
1571         * WebCoreSupport/WebEditorClient.mm:
1572         (undoNameForEditAction):
1573         Add a undo name.
1574
1575 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1576
1577         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1578         https://bugs.webkit.org/show_bug.cgi?id=191945
1579
1580         Reviewed by Anders Carlsson.
1581
1582         * WebCoreSupport/WebEditorClient.mm:
1583         (undoNameForEditAction):
1584
1585 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1586
1587         Enable drag and drop support for iOSMac
1588         https://bugs.webkit.org/show_bug.cgi?id=191818
1589         <rdar://problem/43907454>
1590
1591         Reviewed by Dean Jackson.
1592
1593         * Configurations/FeatureDefines.xcconfig:
1594
1595 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1596
1597         Address post-review feedback after r238438
1598         https://bugs.webkit.org/show_bug.cgi?id=191913
1599
1600         Reviewed by Ryosuke Niwa.
1601
1602         * WebView/WebFrame.mm:
1603         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1604         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1605         * WebView/WebView.mm:
1606         (-[WebView setSelectedDOMRange:affinity:]):
1607
1608 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1609
1610         Web Inspector: "Reload Web Inspector" button no longer partially works
1611         https://bugs.webkit.org/show_bug.cgi?id=191773
1612         <rdar://problem/46139932>
1613
1614         Reviewed by Devin Rousso.
1615
1616         * WebCoreSupport/WebInspectorClient.h:
1617         * WebCoreSupport/WebInspectorClient.mm:
1618         (WebInspectorFrontendClient::reopen):
1619
1620 2018-11-17  Devin Rousso  <drousso@apple.com>
1621
1622         Web Inspector: Network: add button to show system certificate dialog
1623         https://bugs.webkit.org/show_bug.cgi?id=191458
1624         <rdar://problem/45977019>
1625
1626         Reviewed by Joseph Pecoraro.
1627
1628         * WebCoreSupport/WebInspectorClient.h:
1629         * WebCoreSupport/WebInspectorClient.mm:
1630         (WebInspectorFrontendClient::showCertificate): Added.
1631
1632         * Configurations/WebKitLegacy.xcconfig:
1633
1634 2018-11-15  Truitt Savell  <tsavell@apple.com>
1635
1636         Unreviewed, rolling out r238244.
1637
1638         Caused High Sierra test runs to fail early with 50 crashes and
1639         casued 25 API failures.
1640
1641         Reverted changeset:
1642
1643         "[css-logical] Implement flow-relative margin, padding and
1644         border shorthands"
1645         https://bugs.webkit.org/show_bug.cgi?id=188697
1646         https://trac.webkit.org/changeset/238244
1647
1648 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1649
1650         [css-logical] Implement flow-relative margin, padding and border shorthands
1651         https://bugs.webkit.org/show_bug.cgi?id=188697
1652
1653         Reviewed by Simon Fraser and Antti Koivisto.
1654
1655         Add CSSLogicalEnabled runtime flag.
1656
1657         * WebView/WebPreferenceKeysPrivate.h:
1658         * WebView/WebPreferences.mm:
1659         (+[WebPreferences initialize]):
1660         (-[WebPreferences cssLogicalEnabled]):
1661         (-[WebPreferences setCSSLogicalEnabled:]):
1662         * WebView/WebPreferencesPrivate.h:
1663         * WebView/WebView.mm:
1664         (-[WebView _preferencesChanged:]):
1665
1666 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1667
1668         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1669         https://bugs.webkit.org/show_bug.cgi?id=191612
1670
1671         Reviewed by Matt Baker.
1672
1673         * WebCoreSupport/WebInspectorClient.mm:
1674         (-[WebInspectorWindowController destroyInspectorView]):
1675
1676 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1677
1678         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1679         https://bugs.webkit.org/show_bug.cgi?id=191494
1680         <rdar://problem/45469854>
1681
1682         Reviewed by Devin Rousso.
1683
1684         * WebCoreSupport/WebInspectorClient.h:
1685         WebKitLegacy will still have remote inspection of the Page directly.
1686
1687 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1688
1689         Make compositing updates incremental
1690         https://bugs.webkit.org/show_bug.cgi?id=90342
1691
1692         Reviewed by Antti Koivisto.
1693
1694         Fix spelling error.
1695
1696         * WebView/WebView.mm:
1697         (-[WebView _setMediaLayer:forPluginView:]):
1698
1699 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1700
1701         Implement a new edit command to change the enclosing list type
1702         https://bugs.webkit.org/show_bug.cgi?id=191487
1703         <rdar://problem/45955922>
1704
1705         Reviewed by Ryosuke Niwa.
1706
1707         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1708
1709         * WebCoreSupport/WebEditorClient.mm:
1710         (undoNameForEditAction):
1711
1712 2018-11-11  Daniel Bates  <dabates@apple.com>
1713
1714         [iOS] Draw caps lock indicator in password fields
1715         https://bugs.webkit.org/show_bug.cgi?id=190565
1716         <rdar://problem/45262343>
1717
1718         Reviewed by Dean Jackson.
1719
1720         Update the caps lock state when a hardware keyboard is attached or detached.
1721
1722         * WebView/WebHTMLView.mm:
1723         (hardwareKeyboardAvailabilityChangedCallback): Added.
1724         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1725         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1726
1727 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1728
1729         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1730         https://bugs.webkit.org/show_bug.cgi?id=191492
1731
1732         Reviewed by Alex Christensen.
1733
1734         * Carbon/HIWebView.mm:
1735         * Misc/WebNSFileManagerExtras.mm:
1736         * Misc/WebNSURLExtras.mm:
1737         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1738         * Plugins/WebBasePluginPackage.mm:
1739         * Plugins/WebPluginContainerCheck.mm:
1740         * WebCoreSupport/WebCachedFramePlatformData.h:
1741         * WebCoreSupport/WebDeviceOrientationClient.mm:
1742         * WebView/WebDelegateImplementationCaching.mm:
1743         * WebView/WebHTMLView.mm:
1744         * WebView/WebPDFRepresentation.mm:
1745         * WebView/WebPolicyDelegate.mm:
1746         * WebView/WebView.mm:
1747
1748 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1749
1750         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1751         https://bugs.webkit.org/show_bug.cgi?id=191492
1752
1753         Reviewed by Alex Christensen.
1754
1755         * Carbon/HIWebView.mm:
1756         (UpdateCommandStatus):
1757         * Misc/WebNSFileManagerExtras.mm:
1758         * Misc/WebNSURLExtras.mm:
1759         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1760         * Plugins/WebBasePluginPackage.mm:
1761         * Plugins/WebPluginContainerCheck.mm:
1762         (-[WebPluginContainerCheck _continueWithPolicy:]):
1763         * WebCoreSupport/WebCachedFramePlatformData.h:
1764         (WebCachedFramePlatformData::clear):
1765         * WebCoreSupport/WebDeviceOrientationClient.mm:
1766         (WebDeviceOrientationClient::getProvider const):
1767         * WebView/WebDelegateImplementationCaching.mm:
1768         (CallDelegate):
1769         (CallDelegateReturningBoolean):
1770         (CallResourceLoadDelegateReturningBoolean):
1771         (CallFormDelegate):
1772         (CallFormDelegateReturningBoolean):
1773         * WebView/WebHTMLView.mm:
1774         * WebView/WebPDFRepresentation.mm:
1775         * WebView/WebPolicyDelegate.mm:
1776         (-[WebPolicyDecisionListener _usePolicy:]):
1777         * WebView/WebView.mm:
1778
1779 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1780
1781         Unreviewed, rolling out r238047.
1782
1783         Introduced layout test failures on iOS simulator.
1784
1785         Reverted changeset:
1786
1787         "[iOS] Draw caps lock indicator in password fields"
1788         https://bugs.webkit.org/show_bug.cgi?id=190565
1789         https://trac.webkit.org/changeset/238047
1790
1791 2018-11-09  Antti Koivisto  <antti@apple.com>
1792
1793         Use OptionSet for layout milestones
1794         https://bugs.webkit.org/show_bug.cgi?id=191470
1795
1796         Reviewed by Dean Jackson.
1797
1798         * WebCoreSupport/WebFrameLoaderClient.h:
1799         * WebCoreSupport/WebFrameLoaderClient.mm:
1800         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1801         * WebView/WebView.mm:
1802         (coreLayoutMilestones):
1803         (kitLayoutMilestones):
1804         (-[WebView _cacheFrameLoadDelegateImplementations]):
1805         * WebView/WebViewInternal.h:
1806
1807 2018-11-09  Daniel Bates  <dabates@apple.com>
1808
1809         [iOS] Draw caps lock indicator in password fields
1810         https://bugs.webkit.org/show_bug.cgi?id=190565
1811         <rdar://problem/45262343>
1812
1813         Reviewed by Dean Jackson.
1814
1815         Update the caps lock state when a hardware keyboard is attached or detached.
1816
1817         * WebView/WebHTMLView.mm:
1818         (hardwareKeyboardAvailabilityChangedCallback): Added.
1819         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1820         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1821
1822 2018-11-09  Daniel Bates  <dabates@apple.com>
1823
1824         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1825         action when forward delete is pressed outside a text field
1826         https://bugs.webkit.org/show_bug.cgi?id=190566
1827         <rdar://problem/45262367>
1828
1829         Reviewed by Wenson Hsieh.
1830
1831         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1832         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1833         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1834
1835         * WebView/WebHTMLView.mm:
1836         (-[WebHTMLView _handleEditingKeyEvent:]):
1837
1838 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1839
1840         Adopt Reveal Framework to replace Lookup
1841         https://bugs.webkit.org/show_bug.cgi?id=191097
1842         <rdar://problem/45924508>
1843
1844         Reviewed by Tim Horton.
1845
1846         Pass in what it needed to clear the textIndicators. This is better than
1847         the current notification structure.
1848
1849         * WebView/WebView.mm:
1850         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1851         (-[WebView _prepareForDictionaryLookup]):
1852
1853 2018-11-06  Justin Fan  <justin_fan@apple.com>
1854
1855         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1856         https://bugs.webkit.org/show_bug.cgi?id=191291
1857
1858         Reviewed by Myles Maxfield.
1859
1860         Properly disable WEBGPU on all non-Metal platforms for now.
1861
1862         * Configurations/FeatureDefines.xcconfig:
1863
1864 2018-11-02  Daniel Bates  <dabates@apple.com>
1865
1866         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1867         https://bugs.webkit.org/show_bug.cgi?id=190487
1868
1869         Reviewed by Tim Horton.
1870
1871         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1872         allow the default handling.
1873
1874         * WebView/WebHTMLView.mm:
1875         (-[WebHTMLView _handleEditingKeyEvent:]):
1876
1877 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1878
1879         Add a storage limit for IndexedDB
1880         https://bugs.webkit.org/show_bug.cgi?id=190598
1881         <rdar://problem/44654715>
1882
1883         Reviewed by Chris Dumez.
1884
1885         * Storage/WebDatabaseManager.mm:
1886         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1887         * Storage/WebDatabaseManagerPrivate.h:
1888
1889 2018-10-31  Antti Koivisto  <antti@apple.com>
1890
1891         Remove LayerFlushScheduler
1892         https://bugs.webkit.org/show_bug.cgi?id=191103
1893
1894         Reviewed by Anders Carlsson.
1895
1896         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1897         all the virtual cruft.
1898
1899         * WebView/WebViewData.h:
1900         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1901         (): Deleted.
1902         * WebView/WebViewData.mm:
1903         (currentRunLoop):
1904         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1905         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1906         (WebViewLayerFlushScheduler::schedule):
1907         (WebViewLayerFlushScheduler::invalidate):
1908         (WebViewLayerFlushScheduler::layerFlushCallback):
1909
1910 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1911
1912         Enable InstallAPI for iOS unconditionally
1913         https://bugs.webkit.org/show_bug.cgi?id=191043
1914         rdar://problem/32728423
1915
1916         Reviewed by Dan Bernstein.
1917
1918         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1919         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1920         shouldn't be processed by InstallAPI.
1921         * MigrateHeaders.make: Removed an obsolete workaround.
1922         * Misc/NSURLDownloadSPI.h: Added.
1923         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1924
1925 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1926
1927         Clean up some obsolete MAX_ALLOWED macros
1928         https://bugs.webkit.org/show_bug.cgi?id=190916
1929
1930         Reviewed by Tim Horton.
1931
1932         * WebView/WebHTMLView.mm:
1933         (-[WebHTMLView pressureChangeWithEvent:]):
1934         * WebView/WebPDFView.h:
1935
1936 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1937
1938         Unreviewed, rolling out r237600 and r237604.
1939         https://bugs.webkit.org/show_bug.cgi?id=191086
1940
1941         Breaks internal iOS builds (Requested by ryanhadd_ on
1942         #webkit).
1943
1944         Reverted changesets:
1945
1946         "Enable InstallAPI for iOS unconditionally"
1947         https://bugs.webkit.org/show_bug.cgi?id=191043
1948         https://trac.webkit.org/changeset/237600
1949
1950         "Build fix attempt after enabling InstallAPI for iOS."
1951         https://bugs.webkit.org/show_bug.cgi?id=191043
1952         https://trac.webkit.org/changeset/237604
1953
1954 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1955
1956         Enable InstallAPI for iOS unconditionally
1957         https://bugs.webkit.org/show_bug.cgi?id=191043
1958         rdar://problem/32728423
1959
1960         Reviewed by Dan Bernstein.
1961
1962         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1963         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1964         shouldn't be processed by InstallAPI.
1965         * MigrateHeaders.make: Removed an obsolete workaround.
1966         * Misc/NSURLDownloadSPI.h: Added.
1967         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1968
1969 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1970
1971         Modernize WebKit nibs and lprojs for localization's sake
1972         https://bugs.webkit.org/show_bug.cgi?id=190911
1973         <rdar://problem/45349466>
1974
1975         Reviewed by Dan Bernstein.
1976
1977         * Misc/WebNSControlExtras.m:
1978         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1979         NSWindow and its contents are both in the same scale space these days; avoid
1980         double-applying the scale factor, or you can't see the prompt.
1981
1982         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1983         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1984         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1985         NIB->XIB
1986
1987 2018-10-25  Antoine Quint  <graouts@apple.com>
1988
1989         [Web Animations] Turn Web Animations CSS Integration off by default
1990         https://bugs.webkit.org/show_bug.cgi?id=190901
1991
1992         Reviewed by Dean Jackson.
1993
1994         * WebView/WebPreferences.mm:
1995         (+[WebPreferences initialize]):
1996
1997 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1998
1999         Clean up some obsolete macOS version guards
2000         https://bugs.webkit.org/show_bug.cgi?id=190887
2001
2002         Reviewed by Dan Bernstein.
2003
2004         * Misc/WebNSPasteboardExtras.mm:
2005         (+[NSPasteboard _web_dragTypesForURL]):
2006         * WebCoreSupport/PopupMenuMac.mm:
2007         (PopupMenuMac::show):
2008         * WebCoreSupport/WebEditorClient.h:
2009         * WebCoreSupport/WebEditorClient.mm:
2010         (WebEditorClient::respondToChangedSelection):
2011         * WebView/WebPDFView.mm:
2012         (-[WebPDFView _clipViewForPDFDocumentView]):
2013
2014 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2015
2016         Turn on Conic Gradients
2017         https://bugs.webkit.org/show_bug.cgi?id=190810
2018
2019         Reviewed by Tim Horton.
2020
2021         * Configurations/FeatureDefines.xcconfig:
2022
2023 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2024
2025         Cleanup: MIMETypeRegistry functions
2026         https://bugs.webkit.org/show_bug.cgi?id=190838
2027
2028         Reviewed by Simon Fraser.
2029
2030         * Misc/WebNSPasteboardExtras.mm:
2031         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2032         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2033         because they were identical.
2034
2035         * WebView/WebHTMLRepresentation.mm:
2036         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2037         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2038         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2039         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2040         * WebView/WebView.mm:
2041         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2042         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2043         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2044
2045 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2046
2047         Fix false positive leaks when using custom -init methods that don't start with -init
2048         <https://webkit.org/b/190818>
2049         <rdar://problem/45476042>
2050
2051         Reviewed by Dan Bernstein.
2052
2053         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2054         it is accessible by both categories.
2055         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2056         NSError (WebKitInternal) category.  Add attribute to make this
2057         behave like an -init method.
2058         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2059         NSError (WebKitInternal) category.  Modernize method.  Replace
2060         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2061
2062 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2063
2064         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2065         https://bugs.webkit.org/show_bug.cgi?id=190729
2066
2067         Reviewed by Tim Horton.
2068
2069         * DOM/DOM.mm:
2070         (-[DOMNode boundingBox]):
2071         * DOM/DOMElement.mm:
2072         * DOM/DOMHTML.mm:
2073         * DOM/DOMInternal.mm:
2074         * DOM/DOMUIKitExtensions.mm:
2075         * DOM/WebDOMOperations.mm:
2076         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2077         * DefaultDelegates/WebDefaultEditingDelegate.m:
2078         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2079         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2080         * DefaultDelegates/WebDefaultUIDelegate.h:
2081         * DefaultDelegates/WebDefaultUIDelegate.mm:
2082         (-[WebDefaultUIDelegate webViewClose:]):
2083         (-[WebDefaultUIDelegate webViewFocus:]):
2084         (-[WebDefaultUIDelegate webViewUnfocus:]):
2085         (-[WebDefaultUIDelegate webViewIsResizable:]):
2086         (-[WebDefaultUIDelegate webView:setResizable:]):
2087         (-[WebDefaultUIDelegate webView:setFrame:]):
2088         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2089         * History/BackForwardList.h:
2090         * History/BackForwardList.mm:
2091         * History/WebBackForwardList.mm:
2092         (+[WebBackForwardList initialize]):
2093         (bumperCarBackForwardHackNeeded):
2094         * History/WebHistory.mm:
2095         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2096         (-[WebHistory _sendNotification:entries:]):
2097         (-[WebHistory loadFromURL:error:]):
2098         (-[WebHistory saveToURL:error:]):
2099         * History/WebHistoryItem.mm:
2100         (WKNotifyHistoryItemChanged):
2101         (+[WebHistoryItem initialize]):
2102         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2103         * History/WebURLsWithTitles.m:
2104         * Misc/WebCache.mm:
2105         (+[WebCache initialize]):
2106         * Misc/WebDownload.mm:
2107         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2108         * Misc/WebElementDictionary.mm:
2109         (+[WebElementDictionary initialize]):
2110         (+[WebElementDictionary initializeLookupTable]):
2111         * Misc/WebIconDatabase.mm:
2112         * Misc/WebKitNSStringExtras.mm:
2113         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2114         * Misc/WebKitVersionChecks.h:
2115         * Misc/WebKitVersionChecks.mm:
2116         (WebKitLinkedOnOrAfter):
2117         (WebKitLinkTimeVersion):
2118         * Misc/WebLocalizableStrings.mm:
2119         * Misc/WebNSControlExtras.h:
2120         * Misc/WebNSControlExtras.m:
2121         * Misc/WebNSEventExtras.m:
2122         * Misc/WebNSFileManagerExtras.mm:
2123         * Misc/WebNSImageExtras.h:
2124         * Misc/WebNSImageExtras.m:
2125         * Misc/WebNSPasteboardExtras.mm:
2126         * Misc/WebNSPrintOperationExtras.h:
2127         * Misc/WebNSPrintOperationExtras.m:
2128         * Misc/WebNSViewExtras.m:
2129         * Misc/WebNSWindowExtras.m:
2130         * Panels/WebAuthenticationPanel.h:
2131         * Panels/WebAuthenticationPanel.m:
2132         * Panels/WebPanelAuthenticationHandler.m:
2133         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2134         (+[WebHostedNetscapePluginView initialize]):
2135         * Plugins/WebBasePluginPackage.h:
2136         * Plugins/WebBasePluginPackage.mm:
2137         * Plugins/WebJavaPlugIn.h:
2138         * Plugins/WebPluginContainerCheck.mm:
2139         * Plugins/WebPluginController.h:
2140         * Plugins/WebPluginController.mm:
2141         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2142         (-[WebPluginController addPlugin:]):
2143         (-[WebPluginController destroyPlugin:]):
2144         (-[WebPluginController destroyAllPlugins]):
2145         * Plugins/WebPluginDatabase.mm:
2146         (+[WebPluginDatabase _defaultPlugInPaths]):
2147         * Plugins/WebPluginPackage.mm:
2148         (-[WebPluginPackage initWithPath:]):
2149         * Storage/WebDatabaseManager.mm:
2150         (-[WebDatabaseManager deleteAllDatabases]):
2151         * Storage/WebDatabaseManagerClient.h:
2152         * Storage/WebDatabaseManagerClient.mm:
2153         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2154         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2155         * Storage/WebStorageManager.mm:
2156         (-[WebStorageManager deleteAllOrigins]):
2157         (WebKitInitializeStorageIfNecessary):
2158         * WebCoreSupport/WebAlternativeTextClient.h:
2159         * WebCoreSupport/WebApplicationCache.mm:
2160         (applicationCacheBundleIdentifier):
2161         * WebCoreSupport/WebChromeClient.h:
2162         * WebCoreSupport/WebChromeClient.mm:
2163         (WebChromeClient::setWindowRect):
2164         (WebChromeClient::windowRect):
2165         (WebChromeClient::takeFocus):
2166         (WebChromeClient::addMessageToConsole):
2167         (WebChromeClient::enableSuddenTermination):
2168         (WebChromeClient::disableSuddenTermination):
2169         (WebChromeClient::createPopupMenu const):
2170         (WebChromeClient::createSearchPopupMenu const):
2171         (WebChromeClient::shouldPaintEntireContents const):
2172         (WebChromeClient::supportsVideoFullscreen):
2173         (WebChromeClient::supportsFullScreenForElement):
2174         (WebChromeClient::enterFullScreenForElement):
2175         (WebChromeClient::exitFullScreenForElement):
2176         * WebCoreSupport/WebContextMenuClient.mm:
2177         * WebCoreSupport/WebDragClient.mm:
2178         * WebCoreSupport/WebEditorClient.h:
2179         * WebCoreSupport/WebEditorClient.mm:
2180         (+[WebUndoStep initialize]):
2181         (updateFontPanel):
2182         (WebEditorClient::didBeginEditing):
2183         (WebEditorClient::respondToChangedContents):
2184         (WebEditorClient::respondToChangedSelection):
2185         (WebEditorClient::canceledComposition):
2186         (WebEditorClient::didEndEditing):
2187         (WebEditorClient::didWriteSelectionToPasteboard):
2188         (attributesForAttributedStringConversion):
2189         (WebEditorClient::setInsertionPasteboard):
2190         (WebEditorClient::registerUndoOrRedoStep):
2191         (WebEditorClient::handleKeyboardEvent):
2192         (WebEditorClient::handleInputMethodKeydown):
2193         (WebEditorClient::textDidChangeInTextField):
2194         (WebEditorClient::requestCheckingOfString):
2195         * WebCoreSupport/WebFrameLoaderClient.h:
2196         * WebCoreSupport/WebFrameLoaderClient.mm:
2197         (WebFrameLoaderClient::detachedFromParent2):
2198         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2199         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2200         (WebFrameLoaderClient::dispatchWillSendRequest):
2201         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2202         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2203         (WebFrameLoaderClient::willCacheResponse const):
2204         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2205         (WebFrameLoaderClient::dispatchDidFinishLoading):
2206         (WebFrameLoaderClient::dispatchDidFailLoading):
2207         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2208         (WebFrameLoaderClient::dispatchWillClose):
2209         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2210         (WebFrameLoaderClient::dispatchDidCommitLoad):
2211         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2212         (WebFrameLoaderClient::dispatchDidFailLoad):
2213         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2214         (WebFrameLoaderClient::dispatchDidFinishLoad):
2215         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2216         (WebFrameLoaderClient::willChangeTitle):
2217         (WebFrameLoaderClient::didChangeTitle):
2218         (WebFrameLoaderClient::didReplaceMultipartContent):
2219         (WebFrameLoaderClient::updateGlobalHistory):
2220         (WebFrameLoaderClient::saveViewStateToItem):
2221         (WebFrameLoaderClient::restoreViewState):
2222         (WebFrameLoaderClient::provisionalLoadStarted):
2223         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2224         (WebFrameLoaderClient::setTitle):
2225         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2226         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2227         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2228         (WebFrameLoaderClient::didRestoreFromPageCache):
2229         (WebFrameLoaderClient::actionDictionary const):
2230         (WebFrameLoaderClient::createPlugin):
2231         (WebFrameLoaderClient::getLoadDecisionForIcons):
2232         (WebFrameLoaderClient::finishedLoadingIcon):
2233         (+[WebFramePolicyListener initialize]):
2234         * WebCoreSupport/WebFrameNetworkingContext.mm:
2235         * WebCoreSupport/WebGeolocationClient.h:
2236         * WebCoreSupport/WebGeolocationClient.mm:
2237         (WebGeolocationClient::requestPermission):
2238         * WebCoreSupport/WebInspectorClient.h:
2239         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2240         * WebCoreSupport/WebNotificationClient.mm:
2241         * WebCoreSupport/WebOpenPanelResultListener.mm:
2242         * WebCoreSupport/WebPlatformStrategies.h:
2243         * WebCoreSupport/WebPlatformStrategies.mm:
2244         * WebCoreSupport/WebProgressTrackerClient.h:
2245         * WebCoreSupport/WebProgressTrackerClient.mm:
2246         (WebProgressTrackerClient::progressStarted):
2247         (WebProgressTrackerClient::progressEstimateChanged):
2248         (WebProgressTrackerClient::progressFinished):
2249         * WebCoreSupport/WebSecurityOrigin.mm:
2250         * WebInspector/WebNodeHighlight.h:
2251         * WebInspector/WebNodeHighlight.mm:
2252         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2253         (-[WebNodeHighlight dealloc]):
2254         (-[WebNodeHighlight attach]):
2255         * WebInspector/WebNodeHighlightView.h:
2256         * WebInspector/WebNodeHighlightView.mm:
2257         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2258         (-[WebNodeHighlightView dealloc]):
2259         * WebInspector/WebNodeHighlighter.mm:
2260         (-[WebNodeHighlighter highlight]):
2261         * WebView/WebArchive.mm:
2262         (+[WebArchivePrivate initialize]):
2263         * WebView/WebClipView.h:
2264         * WebView/WebDataSource.mm:
2265         (WebDataSourcePrivate::WebDataSourcePrivate):
2266         (+[WebDataSource initialize]):
2267         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2268         (-[WebDataSource _makeRepresentation]):
2269         * WebView/WebDelegateImplementationCaching.h:
2270         * WebView/WebDelegateImplementationCaching.mm:
2271         (CallDelegate):
2272         (CallDelegateReturningFloat):
2273         (CallDelegateReturningBoolean):
2274         (CallUIDelegate):
2275         (CallUIDelegateReturningFloat):
2276         (CallUIDelegateReturningBoolean):
2277         (CallFrameLoadDelegate):
2278         (CallFrameLoadDelegateReturningBoolean):
2279         (CallResourceLoadDelegate):
2280         (CallScriptDebugDelegate):
2281         (CallFormDelegate):
2282         (CallFormDelegateReturningBoolean):
2283         * WebView/WebDeviceOrientation.mm:
2284         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2285         * WebView/WebDocumentInternal.h:
2286         * WebView/WebDocumentLoaderMac.mm:
2287         (needsDataLoadWorkaround):
2288         * WebView/WebDynamicScrollBarsViewInternal.h:
2289         * WebView/WebFormDelegate.m:
2290         * WebView/WebFrame.mm:
2291         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2292         (-[WebFrame _unmarkAllMisspellings]):
2293         (-[WebFrame _paintBehaviorForDestinationContext:]):
2294         (-[WebFrame _drawRect:contentsOnly:]):
2295         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2296         (-[WebFrame _scrollDOMRangeToVisible:]):
2297         (-[WebFrame _bodyBackgroundColor]):
2298         (-[WebFrame accessibilityRoot]):
2299         (needsMicrosoftMessengerDOMDocumentWorkaround):
2300         * WebView/WebFrameInternal.h:
2301         * WebView/WebFrameView.mm:
2302         (-[WebFrameView _setDocumentView:]):
2303         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2304         (-[WebFrameView _viewClassForMIMEType:]):
2305         (-[WebFrameView initWithFrame:]):
2306         (-[WebFrameView drawRect:]):
2307         (-[WebFrameView _firstResponderIsFormControl]):
2308         (-[WebFrameView keyDown:keyDown:]):
2309         (-[WebFrameView _isScrollable]):
2310         * WebView/WebFullScreenController.h:
2311         * WebView/WebFullScreenController.mm:
2312         * WebView/WebHTMLRepresentation.mm:
2313         * WebView/WebHTMLView.mm:
2314         (-[WebHTMLView hitTest:]):
2315         (-[WebHTMLView initWithFrame:]):
2316         (-[WebHTMLView dealloc]):
2317         (-[WebHTMLView addSubview:]):
2318         (-[WebHTMLView mouseDown:]):
2319         (-[WebHTMLView mouseUp:]):
2320         (-[WebHTMLView resignFirstResponder]):
2321         (-[WebHTMLView accessibilityHitTest:]):
2322         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2323         * WebView/WebHTMLViewInternal.h:
2324         * WebView/WebIndicateLayer.h:
2325         * WebView/WebIndicateLayer.mm:
2326         * WebView/WebMediaPlaybackTargetPicker.h:
2327         * WebView/WebMediaPlaybackTargetPicker.mm:
2328         * WebView/WebPDFDocumentExtras.h:
2329         * WebView/WebPDFDocumentExtras.mm:
2330         * WebView/WebPDFRepresentation.h:
2331         * WebView/WebPDFRepresentation.mm:
2332         * WebView/WebPDFView.h:
2333         * WebView/WebPreferences.mm:
2334         (cacheModelForMainBundle):
2335         (WebPreferencesPrivate::WebPreferencesPrivate):
2336         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2337         (-[WebPreferences encodeWithCoder:]):
2338         (+[WebPreferences standardPreferences]):
2339         (+[WebPreferences initialize]):
2340         (-[WebPreferences _valueForKey:]):
2341         (-[WebPreferences _setStringValue:forKey:]):
2342         (-[WebPreferences _setIntegerValue:forKey:]):
2343         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2344         (-[WebPreferences _setFloatValue:forKey:]):
2345         (-[WebPreferences _setBoolValue:forKey:]):
2346         (-[WebPreferences _setLongLongValue:forKey:]):
2347         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2348         (-[WebPreferences _postCacheModelChangedNotification]):
2349         (-[WebPreferences _postPreferencesChangedNotification]):
2350         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2351         (-[WebPreferences setStorageBlockingPolicy:]):
2352         * WebView/WebResource.mm:
2353         (+[WebResourcePrivate initialize]):
2354         * WebView/WebTextCompletionController.h:
2355         * WebView/WebTextIterator.mm:
2356         (+[WebTextIteratorPrivate initialize]):
2357         * WebView/WebView.mm:
2358         (shouldEnableLoadDeferring):
2359         (shouldRestrictWindowFocus):
2360         (shouldRespectPriorityInCSSAttributeSetters):
2361         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2362         (shouldAllowPictureInPictureMediaPlayback):
2363         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2364         (shouldAllowWindowOpenWithoutUserGesture):
2365         (shouldConvertInvalidURLsToBlank):
2366         (shouldRequireUserGestureToLoadVideo):
2367         (-[WebView _commonInitializationWithFrameName:groupName:]):
2368         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2369         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2370         (-[WebView _closePluginDatabases]):
2371         (-[WebView _closeWithFastTeardown]):
2372         (-[WebView _close]):
2373         (+[WebView _MIMETypeForFile:]):
2374         (-[WebView setShowingInspectorIndication:]):
2375         (-[WebView _setFormDelegate:]):
2376         (-[WebView _needsPreHTML5ParserQuirks]):
2377         (-[WebView _preferencesChangedNotification:]):
2378         (-[WebView _preferencesChanged:]):
2379         (-[WebView _cacheResourceLoadDelegateImplementations]):
2380         (-[WebView _cacheFrameLoadDelegateImplementations]):
2381         (-[WebView _policyDelegateForwarder]):
2382         (-[WebView _UIDelegateForwarder]):
2383         (-[WebView _editingDelegateForwarder]):
2384         (-[WebView _updateActiveState]):
2385         (-[_WebSafeForwarder forwardInvocation:]):
2386         (+[WebView initialize]):
2387         (-[WebView _pluginForMIMEType:]):
2388         (-[WebView _pluginForExtension:]):
2389         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2390         (+[WebView canShowMIMETypeAsHTML:]):
2391         (-[WebView _initWithArguments:]):
2392         (-[WebView initWithFrame:frameName:groupName:]):
2393         (-[WebView dealloc]):
2394         (-[WebView close]):
2395         (-[WebView viewDidMoveToWindow]):
2396         (-[WebView setUIDelegate:]):
2397         (-[WebView setResourceLoadDelegate:]):
2398         (-[WebView setPolicyDelegate:]):
2399         (-[WebView setFrameLoadDelegate:]):
2400         (-[WebView goBack]):
2401         (-[WebView goForward]):
2402         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2403         (-[WebView setHostWindow:]):
2404         (-[WebView becomeFirstResponder]):
2405         (+[WebView _cacheModelChangedNotification:]):
2406         (-[WebView _frameViewAtWindowPoint:]):
2407         (+[WebView _preflightSpellCheckerNow:]):
2408         (+[WebView _preflightSpellChecker]):
2409         (-[WebView canGoBack]):
2410         (-[WebView canGoForward]):
2411         (-[WebView stopLoading:]):
2412         (-[WebView reload:]):
2413         (-[WebView setMainFrameDocumentReady:]):
2414         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2415         (-[WebView setContinuousSpellCheckingEnabled:]):
2416         (-[WebView undoManager]):
2417         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2418         (-[WebView isAutomaticLinkDetectionEnabled]):
2419         (-[WebView isAutomaticDashSubstitutionEnabled]):
2420         (-[WebView isAutomaticTextReplacementEnabled]):
2421         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2422         (+[WebView _setCacheModel:]):
2423         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2424         (-[WebView _keyboardUIMode]):
2425         (LayerFlushController::flushLayers):
2426         (-[WebView _scheduleCompositingLayerFlush]):
2427         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2428         (-[WebView fullScreenPlaceholderView]):
2429         (WebInstallMemoryPressureHandler):
2430         * WebView/WebViewData.h:
2431         * WebView/WebViewData.mm:
2432         (+[WebViewPrivate initialize]):
2433         (-[WebViewPrivate init]):
2434         (-[WebViewPrivate dealloc]):
2435         * WebView/WebViewInternal.h:
2436
2437 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2438
2439         Clean up FrameLoader two-state enums
2440         https://bugs.webkit.org/show_bug.cgi?id=190731
2441
2442         Reviewed by Chris Dumez.
2443
2444         * WebCoreSupport/WebFrameLoaderClient.h:
2445         * WebCoreSupport/WebFrameLoaderClient.mm:
2446         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2447
2448 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2449
2450         Unreviewed, rolling out r237137.
2451
2452         SPI is actually used
2453
2454         Reverted changeset:
2455
2456         "Remove unused WebFrame._loadType"
2457         https://bugs.webkit.org/show_bug.cgi?id=190583
2458         https://trac.webkit.org/changeset/237137
2459
2460 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2461
2462         Enable the datalist element by default on iOS and macOS
2463         https://bugs.webkit.org/show_bug.cgi?id=190594
2464         <rdar://problem/45281159>
2465
2466         Reviewed by Ryosuke Niwa and Tim Horton.
2467
2468         * Configurations/FeatureDefines.xcconfig:
2469
2470 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2471
2472         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2473         https://bugs.webkit.org/show_bug.cgi?id=190675
2474
2475         Reviewed by Chris Dumez.
2476
2477         * History/BackForwardList.h:
2478         * History/BackForwardList.mm:
2479         (BackForwardList::backItem):
2480         (BackForwardList::currentItem):
2481         (BackForwardList::forwardItem):
2482         (BackForwardList::backListCount const):
2483         (BackForwardList::forwardListCount const):
2484         (BackForwardList::itemAtIndex):
2485         * History/WebBackForwardList.mm:
2486         (-[WebBackForwardList backItem]):
2487         (-[WebBackForwardList currentItem]):
2488         (-[WebBackForwardList forwardItem]):
2489         (-[WebBackForwardList itemAtIndex:]):
2490
2491 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2492
2493         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2494         https://bugs.webkit.org/show_bug.cgi?id=190526
2495         rdar://problem/45230140
2496
2497         Reviewed by Dean Jackson.
2498
2499         * WebCoreSupport/WebEditorClient.mm:
2500         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2501
2502 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2503
2504         Implement feature flag and bindings for CSS Painting API
2505         https://bugs.webkit.org/show_bug.cgi?id=190237
2506
2507         Reviewed by Ryosuke Niwa.
2508
2509         * Configurations/FeatureDefines.xcconfig:
2510
2511 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2512
2513         Replace HistoryItem* with HistoryItem& where possible
2514         https://bugs.webkit.org/show_bug.cgi?id=190617
2515
2516         Reviewed by Chris Dumez.
2517
2518         * History/BackForwardList.h:
2519         * History/BackForwardList.mm:
2520         (BackForwardList::goToItem):
2521         * History/WebBackForwardList.mm:
2522         (-[WebBackForwardList goToItem:]):
2523         * History/WebHistoryItem.mm:
2524         (WKNotifyHistoryItemChanged):
2525         * History/WebHistoryItemInternal.h:
2526
2527 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2528
2529         Remove unused WebHistoryItem._transientPropertyForKey
2530         https://bugs.webkit.org/show_bug.cgi?id=190606
2531
2532         Reviewed by Chris Dumez.
2533
2534         * History/WebHistoryItem.mm:
2535         * History/WebHistoryItemPrivate.h:
2536
2537 2018-10-15  Justin Fan  <justin_fan@apple.com>
2538
2539         Add WebGPU 2018 feature flag and experimental feature flag
2540         https://bugs.webkit.org/show_bug.cgi?id=190509
2541
2542         Reviewed by Dean Jackson.
2543
2544         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2545         for the 2018 WebGPU prototype.
2546
2547         * Configurations/FeatureDefines.xcconfig:
2548         * WebView/WebPreferenceKeysPrivate.h:
2549         * WebView/WebPreferences.mm:
2550         (+[WebPreferences initialize]):
2551         (-[WebPreferences webGPUEnabled]):
2552         (-[WebPreferences setWebGPUEnabled:]):
2553         * WebView/WebPreferencesPrivate.h:
2554         * WebView/WebView.mm:
2555         (-[WebView _preferencesChanged:]):
2556
2557 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2558
2559         Fix iOS build after r237157
2560
2561         * WebView/WebView.mm:
2562         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2563
2564 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2565
2566         Modernize BackForwardClient.h
2567         https://bugs.webkit.org/show_bug.cgi?id=190610
2568
2569         Reviewed by Chris Dumez.
2570
2571         * History/BackForwardList.h:
2572         * History/BackForwardList.mm:
2573         (BackForwardList::backListCount const):
2574         (BackForwardList::forwardListCount const):
2575         (BackForwardList::backListCount): Deleted.
2576         (BackForwardList::forwardListCount): Deleted.
2577         * History/WebBackForwardList.mm:
2578         (-[WebBackForwardList init]):
2579         * WebCoreSupport/WebFrameLoaderClient.mm:
2580         (WebFrameLoaderClient::canCachePage const):
2581         * WebView/WebFrameView.mm:
2582         (-[WebFrameView keyDown:keyDown:]):
2583         * WebView/WebView.mm:
2584         (-[WebView _commonInitializationWithFrameName:groupName:]):
2585         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2586         (-[WebView _loadBackForwardListFromOtherView:]):
2587         (-[WebView initWithCoder:]):
2588         (-[WebView encodeWithCoder:]):
2589         (-[WebView backForwardList]):
2590         (-[WebView setMaintainsBackForwardList:]):
2591
2592 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2593
2594         Add support for prefers-color-scheme media query
2595         https://bugs.webkit.org/show_bug.cgi?id=190499
2596         rdar://problem/45212025
2597
2598         Reviewed by Dean Jackson.
2599
2600         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2601
2602 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2603
2604         Remove unused WebView._globalHistoryItem
2605         https://bugs.webkit.org/show_bug.cgi?id=190601
2606
2607         Reviewed by Chris Dumez.
2608
2609         * WebCoreSupport/WebFrameLoaderClient.h:
2610         * WebCoreSupport/WebFrameLoaderClient.mm:
2611         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2612         * WebView/WebView.mm:
2613         (-[WebView _globalHistoryItem]): Deleted.
2614         (-[WebView _setGlobalHistoryItem:]): Deleted.
2615         * WebView/WebViewData.h:
2616         * WebView/WebViewInternal.h:
2617         * WebView/WebViewPrivate.h:
2618
2619 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2620
2621         Remove unused parameters from FrameLoaderClient::createFrame
2622         https://bugs.webkit.org/show_bug.cgi?id=190587
2623
2624         Reviewed by Chris Dumez.
2625
2626         * WebCoreSupport/WebFrameLoaderClient.h:
2627         * WebCoreSupport/WebFrameLoaderClient.mm:
2628         (WebFrameLoaderClient::createFrame):
2629
2630 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2631
2632         Remove unused WebFrame._loadType
2633         https://bugs.webkit.org/show_bug.cgi?id=190583
2634
2635         Reviewed by Chris Dumez.
2636
2637         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2638
2639         * WebView/WebFrame.mm:
2640         (toWebFrameLoadType): Deleted.
2641         (-[WebFrame _loadType]): Deleted.
2642         * WebView/WebFramePrivate.h:
2643
2644 2018-10-15  Chris Dumez  <cdumez@apple.com>
2645
2646         Restrict browsing context lookup by name to frames that are related to one another
2647         https://bugs.webkit.org/show_bug.cgi?id=190475
2648
2649         Reviewed by Alex Christensen.
2650
2651         * WebView/WebFrame.mm:
2652         (-[WebFrame findFrameNamed:]):
2653
2654 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2655
2656         Remove InjectedBundle processing of back/forward lists
2657         https://bugs.webkit.org/show_bug.cgi?id=190459
2658
2659         Reviewed by Chris Dumez.
2660
2661         * WebCoreSupport/WebFrameLoaderClient.h:
2662         * WebCoreSupport/WebFrameLoaderClient.mm:
2663         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2664
2665 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2666
2667         [JSC] Remove Option::useAsyncIterator
2668         https://bugs.webkit.org/show_bug.cgi?id=190567
2669
2670         Reviewed by Saam Barati.
2671
2672         * Configurations/FeatureDefines.xcconfig:
2673
2674 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2675
2676         Allow encoding of small enum classes
2677         https://bugs.webkit.org/show_bug.cgi?id=190531
2678
2679         Reviewed by Tim Horton.
2680
2681         * WebCoreSupport/WebFrameLoaderClient.mm:
2682         (-[WebFramePolicyListener dealloc]):
2683
2684 2018-10-11  Keith Rollin  <krollin@apple.com>
2685
2686         CURRENT_ARCH should not be used in Run Script phase.
2687         https://bugs.webkit.org/show_bug.cgi?id=190407
2688         <rdar://problem/45133556>
2689
2690         Reviewed by Alexey Proskuryakov.
2691
2692         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2693         CURRENT_ARCH is not well-defined during this phase (and may even have
2694         the value "undefined") since this phase is run just once per build
2695         rather than once per supported architecture. Migrate away from
2696         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2697         performing an operation for each value, or by picking the first entry
2698         in ARCHS and using that as a representative value.
2699
2700         * Configurations/WebKitLegacy.xcconfig: When generating
2701         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2702         macosx platforms.
2703
2704         * MigrateHeaders.make:
2705         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2706         generate one for each architecture in ARCHS.
2707
2708 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2709
2710         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2711         https://bugs.webkit.org/show_bug.cgi?id=190429
2712
2713         Reviewed by Saam Barati.
2714
2715         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2716
2717         * WebView/WebPDFRepresentation.mm:
2718         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2719
2720 2018-10-08  Justin Fan  <justin_fan@apple.com>
2721
2722         WebGPU: Rename old WebGPU prototype to WebMetal
2723         https://bugs.webkit.org/show_bug.cgi?id=190325
2724         <rdar://problem/44990443>
2725
2726         Reviewed by Dean Jackson.
2727
2728         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2729
2730         * Configurations/FeatureDefines.xcconfig:
2731         * WebView/WebPreferenceKeysPrivate.h:
2732         * WebView/WebPreferences.mm:
2733         (+[WebPreferences initialize]):
2734         (-[WebPreferences webMetalEnabled]):
2735         (-[WebPreferences setWebMetalEnabled:]):
2736         (-[WebPreferences webGPUEnabled]): Deleted.
2737         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2738         * WebView/WebPreferencesPrivate.h:
2739         * WebView/WebView.mm:
2740         (-[WebView _preferencesChanged:]):
2741
2742 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2743
2744         Make <input type=color> a runtime enabled (on-by-default) feature
2745         https://bugs.webkit.org/show_bug.cgi?id=189162
2746
2747         Reviewed by Wenson Hsieh and Tim Horton.
2748
2749         * Configurations/FeatureDefines.xcconfig:
2750
2751 2018-10-07  Dan Bernstein  <mitz@apple.com>
2752
2753         Fixed building with the latest macOS SDK
2754
2755         * Plugins/WebNetscapePluginPackage.mm:
2756         (-[WebNetscapePluginPackage openResourceFile]):
2757         (-[WebNetscapePluginPackage closeResourceFile:]):
2758
2759 2018-10-04  Dan Bernstein  <mitz@apple.com>
2760
2761         More Carbon build-fixing.
2762
2763         * Carbon/CarbonWindowAdapter.mm:
2764         (-[CarbonWindowAdapter _destroyRealWindow:]):
2765         (-[CarbonWindowAdapter _growBoxRect]):
2766
2767 2018-10-04  Dan Bernstein  <mitz@apple.com>
2768
2769         Retried to fix 32-bit macOS builds after r236846.
2770
2771         * WebView/WebHTMLView.mm:
2772         (-[WebHTMLView setMarkedText:selectedRange:]):
2773
2774 2018-10-04  Dan Bernstein  <mitz@apple.com>
2775
2776         Retried to fix 32-bit macOS builds after r236846.
2777
2778         * Carbon/HIWebView.mm:
2779         (ActiveStateChanged):
2780
2781 2018-10-04  Dan Bernstein  <mitz@apple.com>
2782
2783         Tried to fix 32-bit macOS builds after r236846.
2784
2785         * Carbon/HIWebView.mm:
2786         (_NSSelectorForHICommand):
2787
2788 2018-10-04  Dan Bernstein  <mitz@apple.com>
2789
2790         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2791         https://bugs.webkit.org/show_bug.cgi?id=190250
2792
2793         Reviewed by Andy Estes.
2794
2795         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2796           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2797           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2798           an earlier line set it to YES.
2799
2800         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2801         changes below.
2802
2803         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2804           provides some missing method declarations.
2805
2806         * Misc/WebDownload.mm:
2807         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2808           a deprecated method.
2809
2810         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2811
2812         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2813           other code in the file uses a method from it.
2814
2815         * Plugins/WebBaseNetscapePluginView.mm:
2816         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2817           a deprecated method.
2818
2819         * Plugins/WebPluginController.mm:
2820         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2821           around use of a selector that may be present in some WebKit client.
2822
2823         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2824           method declarations.
2825
2826         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2827           from here.
2828
2829         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2830           missing method declarations.
2831
2832         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2833           from here.
2834
2835         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2836           call from here.
2837         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2838           an obsolete delegate method for binary compatibility.
2839         (pluginView): Ditto.
2840
2841         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2842           call from here.
2843
2844         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2845           WebDeviceOrientationProviderMock protocol.
2846
2847         * WebView/WebDeviceOrientationProviderMock.mm:
2848         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2849           main @implementation.
2850
2851         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2852           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2853
2854         * WebView/WebDynamicScrollBarsView.mm:
2855         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2856           of a deprecated method.
2857
2858         * WebView/WebHTMLView.mm:
2859         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2860           selector warning around action methods that are not declared anywhere in WebKit.
2861
2862         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2863           about implementing this deprecated method.
2864         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2865         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2866         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2867         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2868         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2869         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2870         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2871         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2872         (-[WebHTMLView doCommandBySelector:]): Ditto.
2873         (-[WebHTMLView insertText:]): Ditto.
2874
2875         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2876
2877         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2878
2879         * WebView/WebPDFView.h: Removed previewView ivar.
2880
2881         * WebView/WebPDFView.mm:
2882           Removed declaration of FileInternal category and merged its implementation with the main
2883           implementation.
2884         (-[WebPDFView dealloc]): Removed previewView ivar.
2885         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2886           exist in macOS versions we support.
2887         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2888         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2889           action methods internal to PDFKit.
2890         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2891         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2892
2893         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2894           call on macOS, even though in r86988 we started calling different methods on iOS.
2895
2896         * WebView/WebView.mm:
2897         - Imported headers that declare delegate methods that we call.
2898         - Removed declaration of WebFileInternal category and merged its implementation with the
2899           main implementation.
2900         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2901           category, which made them impossible to call from the main implementation. Moved those
2902           into the main implementation. One of those had to be declared in a class extension,
2903           because it is called from a method implemented in the WebPrivate category, and that
2904           category’s implementation appears first in the file.
2905
2906         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2907           around use of obsolete delegate method for binary compatibility.
2908
2909         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2910
2911 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2912
2913         Runtime flag and IDL for MediaRecorder
2914         https://bugs.webkit.org/show_bug.cgi?id=190018
2915
2916         Reviewed by Youenn Fablet and Chris Dumez.
2917
2918         * WebView/WebPreferenceKeysPrivate.h:
2919         * WebView/WebPreferences.mm:
2920         (+[WebPreferences initialize]):
2921         (-[WebPreferences mediaRecorderEnabled]):
2922         (-[WebPreferences setMediaRecorderEnabled:]):
2923         * WebView/WebPreferencesPrivate.h:
2924         * WebView/WebView.mm:
2925         (-[WebView _preferencesChanged:]):
2926
2927 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2928
2929         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2930         https://bugs.webkit.org/show_bug.cgi?id=190238
2931
2932         Reviewed by Antti Koivisto.
2933
2934         Enabled the feature by default.
2935
2936         * WebView/WebPreferences.mm:
2937         (+[WebPreferences initialize]):
2938
2939 2018-10-01  Dean Jackson  <dino@apple.com>
2940
2941         [macOS] Switching to discrete GPU should be done in the UI process
2942         https://bugs.webkit.org/show_bug.cgi?id=189361
2943         <rdar://problem/43949622>
2944
2945         Reviewed by Simon Fraser.
2946
2947         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2948         not support swapping to the discrete GPU in this configuration.
2949
2950         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2951         (WebKit::WebSwitchingGPUClient::singleton):
2952         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2953         * WebView/WebView.mm:
2954         (-[WebView _commonInitializationWithFrameName:groupName:]):
2955
2956 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2957
2958         Remove ParsedURLString
2959         https://bugs.webkit.org/show_bug.cgi?id=190154
2960
2961         Reviewed by Chris Dumez.
2962
2963         * WebView/WebScriptDebugger.mm:
2964         (toNSURL):
2965
2966 2018-10-01  Dean Jackson  <dino@apple.com>
2967
2968         Remove CSS Animation Triggers
2969         https://bugs.webkit.org/show_bug.cgi?id=190175
2970         <rdar://problem/44925626>
2971
2972         Reviewed by Simon Fraser.
2973
2974         * Configurations/FeatureDefines.xcconfig:
2975
2976 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2977
2978         Unreviewed, rolling out r236624 and r236671.
2979         https://bugs.webkit.org/show_bug.cgi?id=190207
2980
2981         The change in r236624 introduced crashes on the bots
2982         (Requested by ryanhaddad on #webkit).
2983
2984         Reverted changesets:
2985
2986         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2987         https://bugs.webkit.org/show_bug.cgi?id=188747
2988         https://trac.webkit.org/changeset/236624
2989
2990         "Unify implementation in VideoFullscreenInterfaceAVKit"
2991         https://bugs.webkit.org/show_bug.cgi?id=190091
2992         https://trac.webkit.org/changeset/236671
2993
2994 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2995
2996         URL should not use TextEncoding internally
2997         https://bugs.webkit.org/show_bug.cgi?id=190111
2998
2999         Reviewed by Andy Estes.
3000
3001         * Misc/WebNSURLExtras.mm:
3002
3003 2018-09-28  Jer Noble  <jer.noble@apple.com>
3004
3005         Refactoring: eliminate raw pointer usage in Fullscreen code
3006         https://bugs.webkit.org/show_bug.cgi?id=188747
3007         <rdar://problem/43541164>
3008
3009         Reviewed by Alex Christensen.
3010
3011         PlaybackSessionInterface no longer has an invalidate() method.
3012
3013         * WebView/WebView.mm:
3014         (-[WebView _clearPlaybackControlsManager]):
3015
3016 2018-09-28  Chris Dumez  <cdumez@apple.com>
3017
3018         Drop support for cross-origin-window-policy header
3019         https://bugs.webkit.org/show_bug.cgi?id=190081
3020
3021         Reviewed by Ryosuke Niwa.
3022
3023         * WebView/WebPreferenceKeysPrivate.h:
3024         * WebView/WebPreferences.mm:
3025         (+[WebPreferences initialize]):
3026         * WebView/WebPreferencesPrivate.h:
3027         * WebView/WebView.mm:
3028         (-[WebView _preferencesChanged:]):
3029
3030 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3031
3032         Rename createMarkup to serializePreservingVisualAppearance
3033         https://bugs.webkit.org/show_bug.cgi?id=190086
3034
3035         Reviewed by Wenson Hsieh.
3036
3037         * DOM/WebDOMOperations.mm:
3038         (-[DOMRange markupString]):
3039
3040 2018-09-28  Commit Queue  <commit-queue@webkit.org>
3041
3042         Unreviewed, rolling out r236605.
3043         https://bugs.webkit.org/show_bug.cgi?id=190087
3044
3045         caused three API test timeouts (Requested by jernoble on
3046         #webkit).
3047
3048         Reverted changeset:
3049
3050         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3051         https://bugs.webkit.org/show_bug.cgi?id=188747
3052         https://trac.webkit.org/changeset/236605
3053
3054 2018-09-28  Jer Noble  <jer.noble@apple.com>
3055
3056         Refactoring: eliminate raw pointer usage in Fullscreen code
3057         https://bugs.webkit.org/show_bug.cgi?id=188747
3058         <rdar://problem/43541164>
3059
3060         Reviewed by Alex Christensen.
3061
3062         PlaybackSessionInterface no longer has an invalidate() method.
3063
3064         * WebView/WebView.mm:
3065         (-[WebView _clearPlaybackControlsManager]):
3066
3067 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3068
3069         Use enum class in createMarkup arguments
3070         https://bugs.webkit.org/show_bug.cgi?id=190028
3071
3072         Reviewed by Wenson Hsieh.
3073
3074         * DOM/WebDOMOperations.mm:
3075         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
3076         (-[DOMRange markupString]): Ditto.
3077
3078 2018-09-27  Antoine Quint  <graouts@apple.com>
3079
3080         [Web Animations] Turn Web Animations with CSS integration on
3081         https://bugs.webkit.org/show_bug.cgi?id=184819
3082         <rdar://problem/39597337>
3083
3084         Reviewed by Dean Jackson.
3085
3086         * WebView/WebPreferences.mm:
3087         (+[WebPreferences initialize]):
3088
3089 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3090
3091         Selection should work across shadow boundary when initiated by a mouse drag
3092         https://bugs.webkit.org/show_bug.cgi?id=151380
3093         <rdar://problem/24363872>
3094
3095         Reviewed by Wenson Hsieh.
3096
3097         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
3098
3099         * WebView/WebPreferenceKeysPrivate.h:
3100         * WebView/WebPreferences.mm:
3101         (+[WebPreferences initialize]):
3102         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
3103         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
3104         * WebView/WebPreferencesPrivate.h:
3105         * WebView/WebView.mm:
3106         (-[WebView _preferencesChanged:]):
3107
3108 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3109
3110         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3111         https://bugs.webkit.org/show_bug.cgi?id=189918
3112         Work towards <rdar://problem/44648705>
3113
3114         Reviewed by Tim Horton.
3115
3116         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3117
3118         * WebView/WebHTMLView.mm:
3119         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3120         (-[WebHTMLView _updateFontPanel]):
3121         * WebView/WebView.mm:
3122         (-[WebView typingAttributes]):
3123
3124 2018-09-17  Darin Adler  <darin@apple.com>
3125
3126         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3127         https://bugs.webkit.org/show_bug.cgi?id=189652
3128
3129         Reviewed by Saam Barati.
3130
3131         * WebView/WebPDFRepresentation.mm:
3132         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3133
3134 2018-09-14  Jer Noble  <jer.noble@apple.com>
3135
3136         Turn SourceBufferChangeTypeEnabled on by default
3137         https://bugs.webkit.org/show_bug.cgi?id=189527
3138
3139         Reviewed by Eric Carlson.
3140
3141         * WebView/WebPreferences.mm:
3142         (+[WebPreferences initialize]):
3143
3144 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3145
3146         Fix an internal build after r235935
3147         https://bugs.webkit.org/show_bug.cgi?id=188996
3148
3149         * Carbon/HIWebView.mm:
3150         (Draw):
3151         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3152
3153 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3154
3155         Add IGNORE_WARNING_.* macros
3156         https://bugs.webkit.org/show_bug.cgi?id=188996
3157
3158         Reviewed by Michael Catanzaro.
3159
3160         * Carbon/CarbonUtils.m:
3161         (PoolCleaner):
3162         * Carbon/CarbonWindowAdapter.mm:
3163         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3164         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3165         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3166         (-[CarbonWindowAdapter _termWindowIfOwner]):
3167         (-[CarbonWindowAdapter _windowMovedToRect:]):
3168         (-[CarbonWindowAdapter setContentView:]):
3169         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3170         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3171         * Carbon/CarbonWindowFrame.m:
3172         (-[CarbonWindowFrame title]):
3173         * Carbon/HIViewAdapter.m:
3174         (+[HIViewAdapter getHIViewForNSView:]):
3175         * Carbon/HIWebView.mm:
3176         (overrideCGContext):
3177         (restoreCGContext):
3178         (Draw):
3179         * DOM/DOM.mm:
3180         * History/WebHistory.mm:
3181         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3182         * History/WebHistoryItem.mm:
3183         (-[WebHistoryItem icon]):
3184         * Misc/WebKitNSStringExtras.mm:
3185         (-[NSString _web_drawAtPoint:font:textColor:]):
3186         * Misc/WebNSImageExtras.m:
3187         (-[NSImage _web_scaleToMaxSize:]):
3188         (-[NSImage _web_dissolveToFraction:]):
3189         * Misc/WebNSPasteboardExtras.mm:
3190         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3191         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3192         * Panels/WebAuthenticationPanel.m:
3193         (-[WebAuthenticationPanel loadNib]):
3194         * Plugins/Hosted/NetscapePluginHostManager.mm:
3195         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3196         (WebKit::NetscapePluginHostManager::didCreateWindow):
3197         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3198         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3199         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3200         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3201         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3202         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3203         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3204         (-[WebHostedNetscapePluginView drawRect:]):
3205         * Plugins/Hosted/WebTextInputWindowController.m:
3206         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3207         * Plugins/WebBaseNetscapePluginView.mm:
3208         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3209         * Plugins/WebNetscapePluginPackage.mm:
3210         (-[WebNetscapePluginPackage _tryLoad]):
3211         * Plugins/WebNetscapePluginView.mm:
3212         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3213         (-[WebNetscapePluginView sendDrawRectEvent:]):
3214         (-[WebNetscapePluginView drawRect:]):
3215         * Plugins/WebPluginController.mm:
3216         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3217         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3218         * WebCoreSupport/PopupMenuMac.mm:
3219         (PopupMenuMac::populate):
3220         * WebCoreSupport/WebAlternativeTextClient.h:
3221         * WebCoreSupport/WebDragClient.mm:
3222         (WebDragClient::startDrag):
3223         * WebCoreSupport/WebFrameLoaderClient.mm:
3224         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3225         (webGetNSImage):
3226         * WebInspector/WebNodeHighlight.mm:
3227         * WebInspector/WebNodeHighlightView.mm:
3228         (-[WebNodeHighlightView drawRect:]):
3229         * WebView/WebClipView.mm:
3230         (-[WebClipView initWithFrame:]):
3231         * WebView/WebFrame.mm:
3232         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3233         (-[WebFrame _drawRect:contentsOnly:]):
3234         (-[WebFrame accessibilityRoot]):
3235         * WebView/WebFullScreenController.mm:
3236         (-[WebFullScreenController enterFullScreen:]):
3237         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3238         (-[WebFullScreenController exitFullScreen]):
3239         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3240         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3241         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3242         * WebView/WebHTMLView.mm:
3243         (-[NSWindow _web_borderView]):
3244         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3245         (-[WebHTMLView _setAsideSubviews]):
3246         (-[WebHTMLView _autoscroll]):
3247         (-[WebHTMLView drawRect:]):
3248         (-[WebHTMLView mouseDown:]):
3249         (-[WebHTMLView mouseDragged:]):
3250         (-[WebHTMLView mouseUp:]):
3251         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3252         (-[WebHTMLView knowsPageRange:]):
3253         (-[WebHTMLView accessibilityHitTest:]):
3254         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3255         (-[WebHTMLView _colorAsString:]):
3256         (-[WebHTMLView copyFont:]):
3257         (-[WebHTMLView _executeSavedKeypressCommands]):
3258         (-[WebHTMLView attachRootLayer:]):
3259         (-[WebHTMLView textStorage]):
3260         (-[WebHTMLView _updateSelectionForInputManager]):
3261         * WebView/WebPDFView.mm:
3262         (_applicationInfoForMIMEType):
3263         (-[WebPDFView centerSelectionInVisibleArea:]):
3264         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3265         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3266         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3267         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3268         * WebView/WebTextCompletionController.mm:
3269         (-[WebTextCompletionController _buildUI]):
3270         (-[WebTextCompletionController _placePopupWindow:]):
3271         * WebView/WebVideoFullscreenController.mm:
3272         * WebView/WebVideoFullscreenHUDWindowController.mm:
3273         (createMediaUIBackgroundView):
3274         * WebView/WebView.mm:
3275         (-[WebTextListTouchBarViewController initWithWebView:]):
3276         (-[WebView _dispatchTileDidDraw:]):
3277         (-[WebView encodeWithCoder:]):
3278         (-[WebView mainFrameIcon]):
3279         (LayerFlushController::flushLayers):
3280         * WebView/WebWindowAnimation.mm:
3281         (setScaledFrameForWindow):
3282
3283 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3284
3285         Remove unused needsDestruction class variables from HashTraits
3286         https://bugs.webkit.org/show_bug.cgi?id=189490
3287
3288         Reviewed by Daniel Bates.
3289
3290         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3291
3292 2018-09-07  Frederic Wang  <fwang@igalia.com>
3293
3294         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3295         https://bugs.webkit.org/show_bug.cgi?id=182230
3296
3297         Reviewed by Simon Fraser.
3298
3299         * DOM/DOMDocument.mm:
3300         (-[DOMDocument scrollingElement]): Use the new name.
3301
3302 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3303
3304         Refactor WebCore::EditAction to be an 8-bit enum class
3305         https://bugs.webkit.org/show_bug.cgi?id=189383
3306
3307         Reviewed by Dan Bernstein.
3308
3309         * WebCoreSupport/WebEditorClient.mm:
3310         (undoNameForEditAction):
3311         * WebView/WebHTMLView.mm:
3312         (-[WebHTMLView pasteFont:]):
3313         (-[WebHTMLView changeFont:]):
3314         (-[WebHTMLView changeAttributes:]):
3315         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3316         (-[WebHTMLView changeColor:]):
3317         * WebView/WebView.mm:
3318         (-[WebView setTypingStyle:]):
3319
3320 2018-09-06  Frederic Wang  <fwang@igalia.com>
3321
3322         Group options of scrollRectToVisible into a struct
3323         https://bugs.webkit.org/show_bug.cgi?id=189352
3324
3325         Reviewed by Simon Fraser.
3326
3327         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3328         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3329         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3330
3331 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3332
3333         [macOS] Cannot change font size at selection until font panel is shown
3334         https://bugs.webkit.org/show_bug.cgi?id=189295
3335         <rdar://problem/35593389>
3336
3337         Reviewed by Ryosuke Niwa.
3338
3339         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3340         WebCore ChangeLog for more details.
3341
3342         * WebView/WebHTMLView.mm:
3343         (-[WebHTMLView changeFont:]):
3344         (-[WebHTMLView changeAttributes:]):
3345         (-[WebHTMLView _originalFontA]): Deleted.
3346         (-[WebHTMLView _originalFontB]): Deleted.
3347         (fontNameForDescription): Deleted.
3348         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3349         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3350         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3351
3352 2018-09-05  Jer Noble  <jer.noble@apple.com>
3353
3354         Add MediaCapabilities as an Experimental Feature
3355         https://bugs.webkit.org/show_bug.cgi?id=189209
3356
3357         Reviewed by Eric Carlson.
3358
3359         RuntimeEnabledFeature -> Setting.
3360
3361         * WebView/WebView.mm:
3362         (-[WebView _preferencesChanged:]):
3363
3364 2018-09-04  Frederic Wang  <fwang@igalia.com>
3365
3366         Add basic support for ScrollIntoViewOptions
3367         https://bugs.webkit.org/show_bug.cgi?id=189258
3368
3369         Reviewed by Simon Fraser.
3370
3371         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3372         header so that this file can build despite the new scrollIntoView function.
3373
3374 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3375
3376         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3377         https://bugs.webkit.org/show_bug.cgi?id=188890
3378         <rdar://problem/43648605>
3379
3380         Reviewed by Tim Horton.
3381
3382         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3383         more detail.
3384
3385         * WebCoreSupport/WebPlatformStrategies.h:
3386         * WebCoreSupport/WebPlatformStrategies.mm:
3387         (WebPlatformStrategies::allStringsForType):
3388
3389 2018-09-01  Darin Adler  <darin@apple.com>
3390
3391         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3392         https://bugs.webkit.org/show_bug.cgi?id=189072
3393         Reviewed by Dan Bernstein.
3394
3395         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3396         and declarations for NSURLDownload init methods.
3397
3398         * Misc/WebDownloadInternal.h: Removed.
3399
3400         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3401         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3402         "-Wdeprecated-declarations" because the method used here is deprecated.
3403
3404         * WebView/WebView.mm:
3405         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3406         used here is deprecated.
3407
3408 2018-08-31  Chris Dumez  <cdumez@apple.com>
3409
3410         Assertion hit in ~CompletionHandler() from ~WebFrame()
3411         https://bugs.webkit.org/show_bug.cgi?id=189199
3412         <rdar://problem/42657233>
3413
3414         Reviewed by Youenn Fablet.
3415
3416         * WebCoreSupport/WebFrameLoaderClient.h:
3417         * WebCoreSupport/WebFrameLoaderClient.mm:
3418         (WebFrameLoaderClient::dispatchWillSubmitForm):
3419
3420 2018-08-31  Antti Koivisto  <antti@apple.com>
3421
3422         Replace OptionSet |= and -= operators with add() and remove() functions
3423         https://bugs.webkit.org/show_bug.cgi?id=189169
3424
3425         Reviewed by Anders Carlsson.
3426
3427         * WebView/WebFrame.mm:
3428         (-[WebFrame _drawRect:contentsOnly:]):
3429         * WebView/WebView.mm:
3430         (coreOptions):
3431
3432 2018-08-31  Frederic Wang  <fwang@igalia.com>
3433
3434         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3435         https://bugs.webkit.org/show_bug.cgi?id=182053
3436
3437         Reviewed by Simon Fraser.
3438
3439         Add developer flag to use standard behavior for scrolling* attributes.
3440
3441         * WebView/WebPreferenceKeysPrivate.h:
3442         * WebView/WebPreferences.mm:
3443         (+[WebPreferences initialize]):
3444         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3445         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3446         * WebView/WebPreferencesPrivate.h:
3447         * WebView/WebView.mm:
3448         (-[WebView _preferencesChanged:]):
3449
3450 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3451
3452         Implement the Web Share API
3453         https://bugs.webkit.org/show_bug.cgi?id=171100
3454         <rdar://problem/31751734>
3455
3456         Reviewed by Tim Horton.
3457
3458         * WebCoreSupport/WebChromeClient.h:
3459         * WebCoreSupport/WebChromeClient.mm:
3460         (WebChromeClient::showShareSheet):
3461         Empty declaration of showShareSheet.
3462
3463 2018-08-29  Youenn Fablet  <youenn@apple.com>
3464
3465         Remove WebRTC legacy API implementation
3466         https://bugs.webkit.org/show_bug.cgi?id=189040
3467
3468         Reviewed by Eric Carlson.
3469
3470         * WebView/WebPreferenceKeysPrivate.h:
3471         * WebView/WebPreferences.mm:
3472         (+[WebPreferences initialize]):
3473         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3474         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3475         * WebView/WebPreferencesPrivate.h:
3476         * WebView/WebView.mm:
3477         (-[WebView _preferencesChanged:]):
3478
3479 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3480
3481         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3482         https://bugs.webkit.org/show_bug.cgi?id=189054
3483
3484         Reviewed by Andy Estes.
3485
3486         Remove the pasteboard type argument from readURLFromPasteboard.
3487
3488         * WebCoreSupport/WebPlatformStrategies.h:
3489         * WebCoreSupport/WebPlatformStrategies.mm:
3490         (WebPlatformStrategies::readURLFromPasteboard):
3491
3492 2018-08-27  Keith Rollin  <krollin@apple.com>
3493
3494         Unreviewed build fix -- disable LTO for production builds
3495
3496         * Configurations/Base.xcconfig:
3497
3498 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3499
3500         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3501         https://bugs.webkit.org/show_bug.cgi?id=188931
3502
3503         Reviewed by Wenson Hsieh.
3504
3505         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3506
3507 2018-08-27  Keith Rollin  <krollin@apple.com>
3508
3509         Build system support for LTO
3510         https://bugs.webkit.org/show_bug.cgi?id=187785
3511         <rdar://problem/42353132>
3512
3513         Reviewed by Dan Bernstein.
3514
3515         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3516         LTO.
3517
3518         * Configurations/Base.xcconfig:
3519         * Configurations/DebugRelease.xcconfig:
3520
3521 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3522
3523         Pass in IsComposed flag to Event constructors
3524         https://bugs.webkit.org/show_bug.cgi?id=188720
3525         <rdar://problem/43580387>
3526
3527         Reviewed by Simon Fraser.
3528
3529         * WebView/WebPDFView.mm:
3530         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3531         whether it's simulated or not.
3532
3533 2018-08-23  Mark Lam  <mark.lam@apple.com>
3534
3535         Move vmEntryGlobalObject() to VM from CallFrame.
3536         https://bugs.webkit.org/show_bug.cgi?id=188900
3537         <rdar://problem/43655753>
3538
3539         Reviewed by Michael Saboff.
3540
3541         * WebView/WebScriptDebugger.mm:
3542         (WebScriptDebugger::sourceParsed):
3543
3544 2018-08-23  Andy Estes  <aestes@apple.com>
3545
3546         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3547         https://bugs.webkit.org/show_bug.cgi?id=188829
3548
3549         Reviewed by Tim Horton.
3550
3551         * Configurations/FeatureDefines.xcconfig:
3552
3553 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3554
3555         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3556         https://bugs.webkit.org/show_bug.cgi?id=188777
3557
3558         Reviewed by Simon Fraser.
3559
3560         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3561         being "true" before the code change.
3562
3563         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3564
3565         * WebView/WebPDFView.mm:
3566         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3567
3568 2018-08-21  Daniel Bates  <dabates@apple.com>
3569
3570         Replace TextCheckingTypeMask with OptionSet
3571         https://bugs.webkit.org/show_bug.cgi?id=188678
3572
3573         Reviewed by Antti Koivisto.
3574
3575         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3576         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3577         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3578         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3579
3580         * WebCoreSupport/WebEditorClient.h:
3581         * WebCoreSupport/WebEditorClient.mm:
3582         (WebEditorClient::checkTextOfParagraph):
3583         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3584         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3585         left as this is more readable and unncessary now that modern compilers like Clang have
3586         diagnostics to catch accidental assignments when equality was intended.
3587         (WebEditorClient::didCheckSucceed):
3588         * WebView/WebView.mm:
3589         (coreTextCheckingType):
3590         (textCheckingResultFromNSTextCheckingResult):
3591
3592 2018-08-21  Daniel Bates  <dabates@apple.com>
3593
3594         [iOS][WK1] Support toggling continuous spell checking from tests
3595         https://bugs.webkit.org/show_bug.cgi?id=188763
3596
3597         Reviewed by Simon Fraser.
3598
3599         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3600         spell checking from tests in iOS WebKit Legacy.
3601
3602         * WebCoreSupport/WebEditorClient.h:
3603         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3604         * WebCoreSupport/WebEditorClient.mm:
3605         * WebView/WebView.h:
3606         * WebView/WebView.mm:
3607         (-[WebView toggleContinuousSpellChecking:]):
3608         (-[WebView toggleSmartInsertDelete:]):
3609
3610 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3611
3612         Add some plumbing for safe browsing
3613         https://bugs.webkit.org/show_bug.cgi?id=188709
3614
3615         Reviewed by Tim Horton.
3616
3617         * WebCoreSupport/WebFrameLoaderClient.h:
3618         * WebCoreSupport/WebFrameLoaderClient.mm:
3619         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3620
3621 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3622
3623         Replace canBubble and cancelable booleans in Event by enum classes
3624         https://bugs.webkit.org/show_bug.cgi?id=188692
3625
3626         Reviewed by Alex Christensen.
3627
3628         * WebView/WebPDFView.mm:
3629         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3630         * WebView/WebView.mm:
3631         (-[WebView _dispatchUnloadEvent]):
3632
3633 2018-08-16  Jer Noble  <jer.noble@apple.com>
3634
3635         Add Experimental Feature support for SourceBuffer.changeType()
3636         https://bugs.webkit.org/show_bug.cgi?id=188626
3637         <rdar://problem/43356021>
3638
3639         Reviewed by Eric Carlson.
3640
3641         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3642
3643         * WebView/WebPreferenceKeysPrivate.h:
3644         * WebView/WebPreferences.mm:
3645         (+[WebPreferences initialize]):
3646         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3647         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3648         * WebView/WebPreferencesPrivate.h:
3649         * WebView/WebView.mm:
3650         (-[WebView _preferencesChanged:]):
3651
3652 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3653
3654         Support drag-and-drop for input[type=color]
3655         https://bugs.webkit.org/show_bug.cgi?id=188464
3656
3657         Reviewed by Wenson Hsieh.
3658
3659         * WebCoreSupport/WebPlatformStrategies.h:
3660         * WebCoreSupport/WebPlatformStrategies.mm:
3661         (WebPlatformStrategies::setColor):
3662
3663 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3664
3665         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3666         https://bugs.webkit.org/show_bug.cgi?id=188569
3667         <rdar://problem/34201095>
3668
3669         Reviewed by Megan Gardner.
3670
3671         * WebView/WebImmediateActionController.mm:
3672         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3673         Speculative fix; the crashes indicate font is null, but we just checked it,
3674         so it must be getting made null by convertFont:toSize:. Check again!
3675
3676 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3677
3678         Use a 1-byte enum class for TextDirection
3679         https://bugs.webkit.org/show_bug.cgi?id=188350
3680
3681         Reviewed by Simon Fraser.
3682
3683         * WebCoreSupport/PopupMenuMac.mm:
3684         (PopupMenuMac::populate):
3685         (PopupMenuMac::show):
3686         * WebCoreSupport/WebFrameLoaderClient.mm:
3687         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3688         * WebView/WebFrame.mm:
3689         (-[WebFrame _dispatchDidReceiveTitle:]):
3690
3691 2018-08-09  Ali Juma  <ajuma@chromium.org>
3692
3693         Import WPTs for IntersectionObserver
3694         https://bugs.webkit.org/show_bug.cgi?id=188416
3695
3696         Reviewed by Simon Fraser.
3697
3698         * WebView/WebPreferencesPrivate.h:
3699
3700 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3701
3702         Follow-up build fix for r234685
3703         https://bugs.webkit.org/show_bug.cgi?id=188245
3704
3705         Unreviewed build fix.
3706
3707         * WebCoreSupport/WebSecurityOriginPrivate.h:
3708
3709 2018-08-05  Darin Adler  <darin@apple.com>
3710
3711         [Cocoa] More tweaks and refactoring to prepare for ARC
3712         https://bugs.webkit.org/show_bug.cgi?id=188245
3713
3714         Reviewed by Dan Bernstein.
3715
3716         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3717
3718         * Carbon/CarbonWindowFrame.m:
3719         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3720
3721         * DOM/DOM.mm:
3722         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3723         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3724         garbage collection so this method isn't useful.
3725
3726         * DOM/DOMXPath.mm:
3727         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3728         Objective-C garbage collection so this method isn't useful.
3729
3730         * History/WebHistory.mm:
3731         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3732
3733         * Misc/WebElementDictionary.mm:
3734         (addLookupKey): Use a bridging cast.
3735         (cacheValueForKey): Ditto.
3736         (-[WebElementDictionary _fillCache]): Ditto.
3737         (-[WebElementDictionary objectForKey:]): Ditto.
3738
3739         * Misc/WebKitNSStringExtras.mm:
3740         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3741         (-[NSString _web_widthWithFont:]): Ditto.
3742         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3743
3744         * Misc/WebLocalizableStrings.mm:
3745         (WebLocalizedString): Use a bridging cast.
3746
3747         * Misc/WebNSDataExtras.mm:
3748         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3749         and use CFBridgingRelease instead of calling autorelease directly.
3750         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3751         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3752         on the amount of explicit release and autorelease.
3753
3754         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3755         * Misc/WebNSDictionaryExtras.m:
3756         (-[NSDictionary _webkit_intForKey:]): Deleted.
3757         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3758         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3759         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3760         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3761         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3762         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3763
3764         * Misc/WebStringTruncator.mm:
3765         (fontFromNSFont): Use a bridging cast.
3766
3767         * Plugins/Hosted/NetscapePluginHostManager.mm:
3768         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3769
3770         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3771         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3772         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3773         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3774         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3775         * Plugins/Hosted/ProxyInstance.mm:
3776         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3777         * Plugins/WebBasePluginPackage.mm:
3778         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3779         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3780         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3781         * Plugins/WebNetscapePluginPackage.mm:
3782         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3783
3784         * Plugins/WebNetscapePluginView.mm:
3785         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3786         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3787         (-[WebNetscapePluginView status:]): Use a bridging cast.
3788         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3789
3790         * Plugins/WebPluginController.mm:
3791         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3792
3793         * Plugins/WebPluginDatabase.mm:
3794         (checkCandidate): Use explicit __strong for out argument types.
3795
3796         * Plugins/npapi.mm:
3797         (pluginViewForInstance): Use a bridging cast.
3798
3799         * Storage/WebDatabaseManager.mm:
3800         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3801         explicit NSNumber and NSDictionary calls.
3802
3803         * WebCoreSupport/WebContextMenuClient.mm:
3804         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3805
3806         * WebCoreSupport/WebEditorClient.mm:
3807         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3808         (WebEditorClient::handleInputMethodKeydown): Ditto.
3809
3810         * WebCoreSupport/WebFrameNetworkingContext.mm:
3811         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3812
3813         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3814         as a struct rather than an Objective-C class, since that's how it's defined.
3815
3816         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3817
3818         * WebView/WebFullScreenController.mm:
3819         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3820         * WebView/WebHTMLView.mm:
3821         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3822         Ditto.
3823         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3824
3825         * WebView/WebImmediateActionController.mm:
3826         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3827         go down to the document and then back to the frame.
3828         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3829         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3830         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3831
3832         * WebView/WebJSPDFDoc.mm:
3833         (jsPDFDocInitialize): Removed some unneeded type casting.
3834         (jsPDFDocFinalize): Ditto.
3835         (jsPDFDocPrint): Use a bridging cast.
3836
3837         * WebView/WebPDFView.mm:
3838         (_applicationInfoForMIMEType): Use bridging casts.
3839
3840         * WebView/WebPreferences.mm:
3841         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3842         instead of methods from WebNSDictionaryExtras.
3843         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3844         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3845         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3846         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3847         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3848
3849         * WebView/WebView.mm:
3850         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3851         (-[WebView _addToAllWebViewsSet]): Ditto.
3852         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3853         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3854         so it can be called from WebViewData methods.
3855
3856         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3857         method, _windowVisibilityChanged:.
3858
3859         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3860         called from WebViewData methods.
3861
3862 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3863
3864         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3865         https://bugs.webkit.org/show_bug.cgi?id=188323
3866
3867         Reviewed by Simon Fraser.
3868
3869         * WebCoreSupport/WebContextMenuClient.mm:
3870         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3871         * WebView/WebFrame.mm:
3872         (-[WebFrame _paintBehaviorForDestinationContext:]):
3873         (-[WebFrame _drawRect:contentsOnly:]):
3874         * WebView/WebHTMLView.mm:
3875         (imageFromRect):
3876         (selectionImage):
3877
3878 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3879
3880         Add support for microtasks in workers
3881         https://bugs.webkit.org/show_bug.cgi?id=188246
3882
3883         Reviewed by Darin Adler.
3884
3885         Rename JSMainThreadExecState.h to JSExecState.h.
3886
3887         * DOM/DOMAttr.mm:
3888         * DOM/DOMBlob.mm:
3889         * DOM/DOMCDATASection.mm:
3890         * DOM/DOMCSSCharsetRule.mm:
3891         * DOM/DOMCSSFontFaceRule.mm:
3892         * DOM/DOMCSSImportRule.mm:
3893         * DOM/DOMCSSMediaRule.mm:
3894         * DOM/DOMCSSPageRule.mm:
3895         * DOM/DOMCSSPrimitiveValue.mm:
3896         * DOM/DOMCSSRule.mm:
3897         * DOM/DOMCSSRuleList.mm:
3898         * DOM/DOMCSSStyleDeclaration.mm:
3899         * DOM/DOMCSSStyleRule.mm:
3900         * DOM/DOMCSSStyleSheet.mm:
3901         * DOM/DOMCSSUnknownRule.mm:
3902         * DOM/DOMCSSValue.mm:
3903         * DOM/DOMCSSValueList.mm:
3904         * DOM/DOMCharacterData.mm:
3905         * DOM/DOMComment.mm:
3906         * DOM/DOMCounter.mm:
3907         * DOM/DOMDocument.mm:
3908         * DOM/DOMDocumentFragment.mm:
3909         * DOM/DOMDocumentType.mm:
3910         * DOM/DOMElement.mm:
3911         * DOM/DOMEvent.mm:
3912         * DOM/DOMFile.mm:
3913         * DOM/DOMFileList.mm:
3914         * DOM/DOMHTML.mm:
3915         * DOM/DOMHTMLAnchorElement.mm:
3916         * DOM/DOMHTMLAppletElement.mm:
3917         * DOM/DOMHTMLAreaElement.mm:
3918         * DOM/DOMHTMLBRElement.mm:
3919         * DOM/DOMHTMLBaseElement.mm:
3920         * DOM/DOMHTMLBaseFontElement.mm:
3921         * DOM/DOMHTMLBodyElement.mm:
3922         * DOM/DOMHTMLButtonElement.mm:
3923         * DOM/DOMHTMLCanvasElement.mm:
3924         * DOM/DOMHTMLCollection.mm:
3925         * DOM/DOMHTMLDListElement.mm:
3926         * DOM/DOMHTMLDirectoryElement.mm:
3927         * DOM/DOMHTMLDivElement.mm:
3928         * DOM/DOMHTMLDocument.mm:
3929         * DOM/DOMHTMLElement.mm:
3930         * DOM/DOMHTMLEmbedElement.mm:
3931         * DOM/DOMHTMLFieldSetElement.mm:
3932         * DOM/DOMHTMLFontElement.mm:
3933         * DOM/DOMHTMLFormElement.mm:
3934         * DOM/DOMHTMLFrameElement.mm:
3935         * DOM/DOMHTMLFrameSetElement.mm:
3936         * DOM/DOMHTMLHRElement.mm:
3937         * DOM/DOMHTMLHeadElement.mm:
3938         * DOM/DOMHTMLHeadingElement.mm:
3939         * DOM/DOMHTMLHtmlElement.mm:
3940         * DOM/DOMHTMLIFrameElement.mm:
3941         * DOM/DOMHTMLImageElement.mm:
3942         * DOM/DOMHTMLInputElement.mm:
3943         * DOM/DOMHTMLLIElement.mm:
3944         * DOM/DOMHTMLLabelElement.mm:
3945         * DOM/DOMHTMLLegendElement.mm:
3946         * DOM/DOMHTMLLinkElement.mm:
3947         * DOM/DOMHTMLMapElement.mm:
3948         * DOM/DOMHTMLMarqueeElement.mm:
3949         * DOM/DOMHTMLMediaElement.mm:
3950         * DOM/DOMHTMLMenuElement.mm:
3951         * DOM/DOMHTMLMetaElement.mm:
3952         * DOM/DOMHTMLModElement.mm:
3953         * DOM/DOMHTMLOListElement.mm:
3954         * DOM/DOMHTMLObjectElement.mm:
3955         * DOM/DOMHTMLOptGroupElement.mm:
3956         * DOM/DOMHTMLOptionElement.mm:
3957         * DOM/DOMHTMLOptionsCollection.mm:
3958         * DOM/DOMHTMLParagraphElement.mm:
3959         * DOM/DOMHTMLParamElement.mm:
3960         * DOM/DOMHTMLPreElement.mm:
3961         * DOM/DOMHTMLQuoteElement.mm:
3962         * DOM/DOMHTMLScriptElement.mm:
3963         * DOM/DOMHTMLSelectElement.mm:
3964         * DOM/DOMHTMLStyleElement.mm:
3965         * DOM/DOMHTMLTableCaptionElement.mm:
3966         * DOM/DOMHTMLTableCellElement.mm:
3967         * DOM/DOMHTMLTableColElement.mm:
3968         * DOM/DOMHTMLTableElement.mm:
3969         * DOM/DOMHTMLTableRowElement.mm:
3970         * DOM/DOMHTMLTableSectionElement.mm:
3971         * DOM/DOMHTMLTextAreaElement.mm:
3972         * DOM/DOMHTMLTitleElement.mm:
3973         * DOM/DOMHTMLUListElement.mm:
3974         * DOM/DOMHTMLVideoElement.mm:
3975         * DOM/DOMImplementation.mm:
3976         * DOM/DOMKeyboardEvent.mm:
3977         * DOM/DOMMediaError.mm:
3978         * DOM/DOMMediaList.mm:
3979         * DOM/DOMMouseEvent.mm:
3980         * DOM/DOMMutationEvent.mm:
3981         * DOM/DOMNamedNodeMap.mm:
3982         * DOM/DOMNode.mm:
3983         * DOM/DOMNodeIterator.mm:
3984         * DOM/DOMNodeList.mm:
3985         * DOM/DOMOverflowEvent.mm:
3986         * DOM/DOMProcessingInstruction.mm:
3987         * DOM/DOMProgressEvent.mm:
3988         * DOM/DOMRGBColor.mm:
3989         * DOM/DOMRange.mm:
3990         * DOM/DOMRect.mm:
3991         * DOM/DOMStyleSheet.mm:
3992         * DOM/DOMStyleSheetList.mm:
3993         * DOM/DOMText.mm:
3994         * DOM/DOMTextEvent.mm:
3995         * DOM/DOMTimeRanges.mm:
3996         * DOM/DOMTokenList.mm:
3997         * DOM/DOMTreeWalker.mm:
3998         * DOM/DOMUIEvent.mm:
3999         * DOM/DOMWheelEvent.mm:
4000         * DOM/DOMXPathExpression.mm:
4001         * DOM/DOMXPathResult.mm:
4002         * DOM/ObjCEventListener.mm:
4003
4004 2018-08-03  Alex Christensen  <achristensen@webkit.org>
4005
4006         Fix spelling of "overridden"
4007         https://bugs.webkit.org/show_bug.cgi?id=188315
4008
4009         Reviewed by Darin Adler.
4010
4011         * Misc/WebKitVersionChecks.mm:
4012         (setWebKitLinkTimeVersion):
4013         (WebKitLinkTimeVersion):
4014         * Plugins/WebBaseNetscapePluginView.mm:
4015         (-[WebBaseNetscapePluginView handleMouseMoved:]):
4016         * WebCoreSupport/PopupMenuMac.mm:
4017         (PopupMenuMac::populate):
4018
4019 2018-08-01  Nan Wang  <n_wang@apple.com>
4020
4021         AX: AOM: Add ARIA IDL Attribute Reflection
4022         https://bugs.webkit.org/show_bug.cgi?id=184676
4023         <rdar://problem/39476882>
4024
4025         Reviewed by Chris Fleizach.
4026
4027         * WebView/WebPreferenceKeysPrivate.h:
4028         * WebView/WebPreferences.mm:
4029         (+[WebPreferences initialize]):
4030         (-[WebPreferences ariaReflectionEnabled]):
4031         (-[WebPreferences setAriaReflectionEnabled:]):
4032         * WebView/WebPreferencesPrivate.h:
4033         * WebView/WebView.mm:
4034         (-[WebView _preferencesChanged:]):
4035
4036 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
4037
4038         Shrink GraphicsLayerCA
4039         https://bugs.webkit.org/show_bug.cgi?id=188141
4040
4041         Reviewed by Zalan Bujtas.
4042
4043         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
4044         * moving all the clone-related stuff into the lazily-allocated m_layerClones
4045         * moving all the animation-related stuff into the lazily-allocated m_animations
4046         * making enums be 8-bit
4047         * re-ordering data members
4048
4049         * WebView/WebView.mm:
4050         (-[WebView _setMediaLayer:forPluginView:]):
4051