Add a POINTER_EVENTS feature flag
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-01-19  Antoine Quint  <graouts@apple.com>
2
3         Add a POINTER_EVENTS feature flag
4         https://bugs.webkit.org/show_bug.cgi?id=193577
5
6         Reviewed by Dean Jackson.
7
8         * Configurations/FeatureDefines.xcconfig:
9
10 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
11
12         Revert r238815, it broke WK1 video fullscreen on Mac
13         https://bugs.webkit.org/show_bug.cgi?id=193586
14         <rdar://problem/47358941>
15
16         Reviewed by Jer Noble.
17
18         * WebView/WebVideoFullscreenController.h: Added.
19         * WebView/WebVideoFullscreenController.mm: Added.
20         (SOFT_LINK_CLASS):
21         (-[WebVideoFullscreenController init]):
22         (-[WebVideoFullscreenController dealloc]):
23         (-[WebVideoFullscreenController fullscreenWindow]):
24         (-[WebVideoFullscreenController windowDidLoad]):
25         (-[WebVideoFullscreenController videoElement]):
26         (-[WebVideoFullscreenController setVideoElement:]):
27         (-[WebVideoFullscreenController clearFadeAnimation]):
28         (-[WebVideoFullscreenController windowDidExitFullscreen]):
29         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
30         (-[WebVideoFullscreenController videoElementRect]):
31         (-[WebVideoFullscreenController applicationDidResignActive:]):
32         (frameExpandedToRatioOfFrame):
33         (createBackgroundFullscreenWindow):
34         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
35         (-[WebVideoFullscreenController enterFullscreen:]):
36         (-[WebVideoFullscreenController exitFullscreen]):
37         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
38         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
39         (-[WebVideoFullscreenController _requestExit]):
40         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
41         (-[WebVideoFullscreenController requestExitFullscreen]):
42         (-[WebVideoFullscreenController fadeHUDIn]):
43         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
44         (-[WebVideoFullscreenController rateChanged:]):
45         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
46         (-[WebVideoFullscreenWindow dealloc]):
47         (-[WebVideoFullscreenWindow resignFirstResponder]):
48         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
49         (-[WebVideoFullscreenWindow mouseDown:]):
50         (-[WebVideoFullscreenWindow cancelOperation:]):
51         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
52         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
53         (-[WebVideoFullscreenWindow animationDidEnd:]):
54         (-[WebVideoFullscreenWindow mouseMoved:]):
55         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
56         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
57         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
58         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
59         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
60         (-[WebVideoFullscreenHUDWindow center]):
61         (-[WebVideoFullscreenHUDWindow keyDown:]):
62         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
63         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
64         (-[WebVideoFullscreenHUDWindowController init]):
65         (-[WebVideoFullscreenHUDWindowController dealloc]):
66         (-[WebVideoFullscreenHUDWindowController setArea:]):
67         (-[WebVideoFullscreenHUDWindowController keyDown:]):
68         (-[WebVideoFullscreenHUDWindowController delegate]):
69         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
70         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
71         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
72         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
73         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
74         (-[WebVideoFullscreenHUDWindowController closeWindow]):
75         (createMediaUIControl):
76         (createControlWithMediaUIControlType):
77         (createTimeTextField):
78         (createMediaUIBackgroundView):
79         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
80         (-[WebVideoFullscreenHUDWindowController updateVolume]):
81         (-[WebVideoFullscreenHUDWindowController updateTime]):
82         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
83         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
84         (-[WebVideoFullscreenHUDWindowController currentTime]):
85         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
86         (-[WebVideoFullscreenHUDWindowController duration]):
87         (-[WebVideoFullscreenHUDWindowController maxVolume]):
88         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
89         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
90         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
91         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
92         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
93         (-[WebVideoFullscreenHUDWindowController volume]):
94         (-[WebVideoFullscreenHUDWindowController setVolume:]):
95         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
96         (-[WebVideoFullscreenHUDWindowController updateRate]):
97         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
98         (-[WebVideoFullscreenHUDWindowController playing]):
99         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
100         (timeToString):
101         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
102         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
103         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
104         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
105         (-[WebVideoFullscreenHUDWindowController rewind:]):
106         (-[WebVideoFullscreenHUDWindowController fastForward:]):
107         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
108         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
109         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
110         * WebView/WebView.mm:
111         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
112         (-[WebView _exitVideoFullscreen]):
113
114 2019-01-18  Tim Horton  <timothy_horton@apple.com>
115
116         Get rid of ADVANCED_SPELL_CHECKING
117         https://bugs.webkit.org/show_bug.cgi?id=193592
118
119         Reviewed by Wenson Hsieh.
120
121         * WebCoreSupport/WebEditorClient.mm:
122         (insertionPointFromCurrentSelection):
123         (WebEditorClient::checkTextOfParagraph):
124         (WebEditorClient::getGuessesForWord):
125         (WebEditorClient::requestCandidatesForSelection):
126         (WebEditorClient::requestCheckingOfString):
127         * WebView/WebHTMLView.mm:
128         (-[WebHTMLView insertText:]):
129
130 2019-01-18  Jer Noble  <jer.noble@apple.com>
131
132         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
133         https://bugs.webkit.org/show_bug.cgi?id=189553
134
135         Reviewed by Tim Horton.
136
137         * Configurations/Base.xcconfig:
138         * Configurations/SDKVariant.xcconfig: Added.
139         * Configurations/WebKitLegacy.xcconfig:
140
141 2019-01-18  David Kilzer  <ddkilzer@apple.com>
142
143         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
144         <https://webkit.org/b/193568>
145         <rdar://problem/47381130>
146
147         Reviewed by Alex Christensen.
148
149         * WebView/WebView.mm:
150         - Remove unused soft-linking macros.
151         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
152         (-[WebUITextIndicatorData initWithImage:scale:]):
153         - Update to use exported PAL functions.
154
155 2019-01-17  Truitt Savell  <tsavell@apple.com>
156
157         Unreviewed, rolling out r240124.
158
159         This commit broke an internal build.
160
161         Reverted changeset:
162
163         "SDK_VARIANT build destinations should be separate from non-
164         SDK_VARIANT builds"
165         https://bugs.webkit.org/show_bug.cgi?id=189553
166         https://trac.webkit.org/changeset/240124
167
168 2019-01-17  Jer Noble  <jer.noble@apple.com>
169
170         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
171         https://bugs.webkit.org/show_bug.cgi?id=189553
172
173         Reviewed by Tim Horton.
174
175         * Configurations/Base.xcconfig:
176         * Configurations/SDKVariant.xcconfig: Added.
177         * Configurations/WebKitLegacy.xcconfig:
178
179 2019-01-17  Alex Christensen  <achristensen@webkit.org>
180
181         Stop using NetworkStorageSession::storageSession in WebCore
182         https://bugs.webkit.org/show_bug.cgi?id=193529
183
184         Reviewed by Tim Horton.
185
186         * Misc/WebCache.mm:
187         (+[WebCache addImageToCache:forURL:forFrame:]):
188         * WebView/WebView.mm:
189         (-[WebView _commonInitializationWithFrameName:groupName:]):
190         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
191
192 2019-01-15  Alex Christensen  <achristensen@webkit.org>
193
194         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
195         https://bugs.webkit.org/show_bug.cgi?id=193368
196
197         Reviewed by Geoff Garen.
198
199         * Misc/WebCache.mm:
200         (+[WebCache clearCachedCredentials]):
201         * Misc/WebDownload.mm:
202         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
203         * Plugins/WebBaseNetscapePluginView.mm:
204         (WebKit::getAuthenticationInfo):
205
206 2019-01-15  Alex Christensen  <achristensen@webkit.org>
207
208         Stop using CookiesStrategy
209         https://bugs.webkit.org/show_bug.cgi?id=161106
210
211         Reviewed by Don Olmstead and Antti Koivisto.
212
213         * Misc/WebCache.mm:
214         (+[WebCache addImageToCache:forURL:forFrame:]):
215         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
216         (WebKit::NetscapePluginInstanceProxy::getCookies):
217         (WebKit::NetscapePluginInstanceProxy::setCookies):
218         * Plugins/WebNetscapePluginView.mm:
219         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
220         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
221         * WebCoreSupport/WebPlatformStrategies.h:
222         * WebCoreSupport/WebPlatformStrategies.mm:
223         (WebPlatformStrategies::createCookiesStrategy): Deleted.
224         (WebPlatformStrategies::cookiesForDOM): Deleted.
225         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
226         (WebPlatformStrategies::cookiesEnabled): Deleted.
227         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
228         (WebPlatformStrategies::getRawCookies): Deleted.
229         (WebPlatformStrategies::deleteCookie): Deleted.
230         * WebView/WebView.mm:
231         (-[WebView _commonInitializationWithFrameName:groupName:]):
232         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
233
234 2019-01-15  Tim Horton  <timothy_horton@apple.com>
235
236         Cannot tab out of WKWebView on macOS
237         https://bugs.webkit.org/show_bug.cgi?id=161448
238         <rdar://problem/28100085>
239
240         Reviewed by Dean Jackson.
241
242         * WebCoreSupport/WebChromeClient.mm:
243         * WebView/WebView.mm:
244         Make use of SPI headers.
245
246 2019-01-14  Commit Queue  <commit-queue@webkit.org>
247
248         Unreviewed, rolling out r239901, r239909, r239910, r239912,
249         r239913, and r239914.
250         https://bugs.webkit.org/show_bug.cgi?id=193407
251
252         These revisions caused an internal failure (Requested by
253         Truitt on #webkit).
254
255         Reverted changesets:
256
257         "[Cocoa] Avoid importing directly from subumbrella frameworks"
258         https://bugs.webkit.org/show_bug.cgi?id=186016
259         https://trac.webkit.org/changeset/239901
260
261         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
262         https://trac.webkit.org/changeset/239909
263
264         "Tried to fix the build."
265         https://trac.webkit.org/changeset/239910
266
267         "Fixed iOS builds after r239910."
268         https://trac.webkit.org/changeset/239912
269
270         "More build fixing."
271         https://trac.webkit.org/changeset/239913
272
273         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
274         https://trac.webkit.org/changeset/239914
275
276 2019-01-14  Mark Lam  <mark.lam@apple.com>
277
278         Re-enable ability to build --cloop builds.
279         https://bugs.webkit.org/show_bug.cgi?id=192955
280         <rdar://problem/46882363>
281
282         Reviewed by Saam barati and Keith Miller.
283
284         * Configurations/FeatureDefines.xcconfig:
285
286 2019-01-13  Dan Bernstein  <mitz@apple.com>
287
288         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
289
290         Patch by Keith Rollin.
291
292         * WebView/PDFViewSPI.h:
293
294 2019-01-12  Timothy Hatcher  <timothy@apple.com>
295
296         Have prefers-color-scheme: light always match on macOS versions before Mojave.
297         https://bugs.webkit.org/show_bug.cgi?id=191655
298         rdar://problem/46074680
299
300         Reviewed by Megan Gardner.
301
302         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
303         * WebView/WebView.mm:
304         (-[WebView _effectiveAppearanceIsDark]):
305
306 2019-01-12  Dan Bernstein  <mitz@apple.com>
307
308         [Cocoa] Avoid importing directly from subumbrella frameworks
309         https://bugs.webkit.org/show_bug.cgi?id=186016
310         <rdar://problem/40591038>
311
312         Reviewed by Sam Weinig.
313
314         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
315         * Carbon/CarbonWindowAdapter.mm: Ditto.
316         * Carbon/CarbonWindowFrame.m: Ditto.
317         * Carbon/HIViewAdapter.h: Ditto.
318         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
319           OTHER_CFLAGS_COCOA_TOUCH_NO.
320         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
321         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
322         * WebView/WebPDFView.h: Ditto.
323
324 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
325
326         Enable visual viewport API by default
327         https://bugs.webkit.org/show_bug.cgi?id=193376
328
329         Reviewed by Simon Fraser.
330
331         * WebView/WebPreferences.mm:
332         (+[WebPreferences initialize]):
333
334 2019-01-11  John Wilander  <wilander@apple.com>
335
336         Compile out Web API Statistics Collection
337         https://bugs.webkit.org/show_bug.cgi?id=193370
338         <rdar://problem/45388584>
339
340         Reviewed by Brent Fulgham.
341
342         * Configurations/FeatureDefines.xcconfig:
343             Defined ENABLE_WEB_API_STATISTICS, off by default.
344
345 2019-01-08  Alex Christensen  <achristensen@webkit.org>
346
347         Stop using NetworkStorageSession in WebProcess
348         https://bugs.webkit.org/show_bug.cgi?id=193236
349
350         Reviewed by Don Olmstead.
351
352         * WebCoreSupport/WebFrameNetworkingContext.h:
353         * WebCoreSupport/WebFrameNetworkingContext.mm:
354         (WebFrameNetworkingContext::storageSession const):
355         * WebCoreSupport/WebPlatformStrategies.h:
356         * WebCoreSupport/WebPlatformStrategies.mm:
357         (WebPlatformStrategies::cookiesForDOM):
358         (WebPlatformStrategies::setCookiesFromDOM):
359         (WebPlatformStrategies::cookiesEnabled):
360         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
361         (WebPlatformStrategies::getRawCookies):
362         (WebPlatformStrategies::deleteCookie):
363         * WebView/WebView.mm:
364         (-[WebView _cachedResponseForURL:]):
365         (-[WebView _clearCredentials]):
366
367 2019-01-08  Alex Christensen  <achristensen@webkit.org>
368
369         Unreviewed, rolling out r239727.
370
371         Broke API tests
372
373         Reverted changeset:
374
375         "Stop using NetworkStorageSession in WebProcess"
376         https://bugs.webkit.org/show_bug.cgi?id=193236
377         https://trac.webkit.org/changeset/239727
378
379 2019-01-08  Alex Christensen  <achristensen@webkit.org>
380
381         Stop using NetworkStorageSession in WebProcess
382         https://bugs.webkit.org/show_bug.cgi?id=193236
383
384         Reviewed by Don Olmstead.
385
386         * WebCoreSupport/WebFrameNetworkingContext.h:
387         * WebCoreSupport/WebFrameNetworkingContext.mm:
388         (WebFrameNetworkingContext::storageSession const):
389         * WebView/WebView.mm:
390         (-[WebView _cachedResponseForURL:]):
391         (-[WebView _clearCredentials]):
392
393 2019-01-07  David Kilzer  <ddkilzer@apple.com>
394
395         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
396         <https://webkit.org/b/193056>
397
398         Reviewed by Alex Christensen.
399
400         * Plugins/Hosted/NetscapePluginHostProxy.h:
401         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
402         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
403         (WebKit::NetscapePluginInstanceProxy::enumerate):
404         (WebKit::NetscapePluginInstanceProxy::marshalValue):
405         (WebKit::NetscapePluginInstanceProxy::marshalValues):
406         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
407         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
408         * Plugins/Hosted/ProxyInstance.mm:
409         (WebKit::ProxyInstance::invoke):
410         * WebCoreSupport/WebGeolocationClient.mm:
411         * WebView/WebDataSource.mm:
412         (-[WebDataSource _receivedData:]):
413         * WebView/WebView.mm:
414         (-[WebView _cachedResponseForURL:]):
415         - Remove '*' from RetainPtr<> type.
416
417 2019-01-04  Alex Christensen  <achristensen@webkit.org>
418
419         Progress towards fixing Mac CMake build
420         https://bugs.webkit.org/show_bug.cgi?id=193105
421
422         Reviewed by Don Olmstead.
423
424         * WebKitPrefix.h:
425
426 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
427
428         Web Inspector: Use save sheet instead of dialog where possible
429         https://bugs.webkit.org/show_bug.cgi?id=193160
430         <rdar://problem/37399759>
431
432         Reviewed by Devin Rousso.
433
434         * WebCoreSupport/WebInspectorClient.mm:
435         (WebInspectorFrontendClient::save):
436
437 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
438
439         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
440         https://bugs.webkit.org/show_bug.cgi?id=193129
441
442         Reviewed by Tim Horton.
443
444         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
445
446         * WebCoreSupport/WebEditorClient.mm:
447         (WebEditorClient::registerUndoOrRedoStep):
448         (undoNameForEditAction): Deleted.
449
450 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
451
452         Add support for using the current text selection as the find string on iOS
453         https://bugs.webkit.org/show_bug.cgi?id=193034
454         <rdar://problem/45138739>
455
456         Reviewed by Tim Horton.
457
458         Add a method stub for WebKitLegacy.
459
460         * WebCoreSupport/WebEditorClient.h:
461
462 2019-01-01  Jeff Miller  <jeffm@apple.com>
463
464         Update user-visible copyright strings to include 2019
465         https://bugs.webkit.org/show_bug.cgi?id=192811
466
467         Reviewed by Mark Lam.
468
469         * Info.plist:
470
471 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
472
473         Use Ref<> as much as possible
474         https://bugs.webkit.org/show_bug.cgi?id=192808
475
476         Reviewed by Alex Christensen.
477
478         * DOM/DOM.mm:
479         (-[DOMNode getPreviewSnapshotImage:andRects:]):
480         * Plugins/Hosted/NetscapePluginHostManager.mm:
481         (WebKit::NetscapePluginHostManager::instantiatePlugin):
482         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
483         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
484         (WebKit::NetscapePluginInstanceProxy::loadRequest):
485         * Plugins/WebNetscapePluginView.mm:
486         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
487         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
488         * WebCoreSupport/WebContextMenuClient.mm:
489         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
490         * WebCoreSupport/WebFrameLoaderClient.mm:
491         (WebFrameLoaderClient::transitionToCommittedForNewPage):
492         * WebView/WebFrame.mm:
493         (-[WebFrame getDictationResultRanges:andMetadatas:]):
494         * WebView/WebHTMLView.mm:
495         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
496         * WebView/WebView.mm:
497         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
498         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
499
500 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
501
502         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
503         https://bugs.webkit.org/show_bug.cgi?id=192821
504
505         Reviewed by Chris Dumez.
506
507         When a window becomes occluded, the window server informs the application.
508         This should be used to suspend any work that is not visible by the user.
509
510         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
511         In some cases, that lead to performance impact (see radar).
512
513         This patch adds an observer for the occlusion notification. I tried to stick
514         with the same names used by WebKit2.
515
516         * WebView/WebView.mm:
517         (-[WebView _isViewVisible]):
518         (-[WebView addWindowObserversForWindow:]):
519         (-[WebView removeWindowObservers]):
520         (-[WebView _windowDidChangeOcclusionState:]):
521
522 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
523
524         [WebAuthN] Add a runtime flag for local authenticator
525         https://bugs.webkit.org/show_bug.cgi?id=192792
526         <rdar://problem/46798738>
527
528         Reviewed by Brent Fulgham.
529
530         * WebView/WebPreferenceKeysPrivate.h:
531         * WebView/WebPreferences.mm:
532         (+[WebPreferences initialize]):
533         (-[WebPreferences webAuthenticationEnabled]): Deleted.
534         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
535         * WebView/WebPreferencesPrivate.h:
536         * WebView/WebView.mm:
537         (-[WebView _preferencesChanged:]):
538
539 2018-12-20  Chris Dumez  <cdumez@apple.com>
540
541         Use Optional::valueOr() instead of Optional::value_or()
542         https://bugs.webkit.org/show_bug.cgi?id=192933
543
544         Reviewed by Geoffrey Garen.
545
546         * WebCoreSupport/WebSecurityOrigin.mm:
547         (-[WebSecurityOrigin port]):
548
549 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
550
551         Unreviewed, rolling out r239417.
552
553         Introduced two API test failures on macOS.
554
555         Reverted changeset:
556
557         "<rdar://problem/46194315> macOS: WebKit1 does not handle
558         occlusion changes"
559         https://bugs.webkit.org/show_bug.cgi?id=192821
560         https://trac.webkit.org/changeset/239417
561
562 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
563
564         WKWebView default UA doesn't freeze the build number
565         https://bugs.webkit.org/show_bug.cgi?id=192809
566         <rdar://problem/44687185>
567
568         Reviewed by Andy Estes.
569
570         Always reports the frozen build number.
571
572         * WebView/WebView.mm:
573         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
574         actual build number through this method call.
575         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
576
577 2018-12-19  Chris Dumez  <cdumez@apple.com>
578
579         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
580         https://bugs.webkit.org/show_bug.cgi?id=192728
581         <rdar://problem/46746779>
582
583         Reviewed by Geoff Garen.
584
585         * DOM/*:
586         * Plugins/*:
587         * WebCoreSupport/*:
588         * WebView/*:
589
590 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
591
592         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
593         https://bugs.webkit.org/show_bug.cgi?id=192821
594
595         Reviewed by Chris Dumez.
596
597         When a window becomes occluded, the window server informs the application.
598         This should be used to suspend any work that is not visible by the user.
599
600         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
601         In some cases, that lead to performance impact (see radar).
602
603         This patch adds an observer for the occlusion notification. I tried to stick
604         with the same names used by WebKit2.
605
606         * WebView/WebView.mm:
607         (-[WebView _isViewVisible]):
608         (-[WebView addWindowObserversForWindow:]):
609         (-[WebView removeWindowObservers]):
610         (-[WebView _windowDidChangeOcclusionState:]):
611
612 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
613
614         Allow clients to set the navigator platform
615         https://bugs.webkit.org/show_bug.cgi?id=192735
616
617         Reviewed by Tim Horton.
618
619         Add stubs to fill out the added functionality in FrameLoaderClient.
620
621         * WebCoreSupport/WebFrameLoaderClient.h:
622         * WebCoreSupport/WebFrameLoaderClient.mm:
623         (WebFrameLoaderClient::navigatorPlatform):
624
625 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
626
627         offsetLeft and offsetParent should adjust across shadow boundaries
628         https://bugs.webkit.org/show_bug.cgi?id=157437
629         <rdar://problem/26154021>
630
631         Reviewed by Simon Fraser.
632
633         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
634
635         * DOM/DOMElement.mm:
636         (-[DOMElement offsetLeft]):
637         (-[DOMElement offsetTop]):
638         (-[DOMElement offsetParent]):
639
640 2018-12-17  Zalan Bujtas  <zalan@apple.com>
641
642         Unreviewed build fix.
643
644         * WebView/WebFrame.mm:
645         (-[WebFrame getDictationResultRanges:andMetadatas:]):
646
647 2018-12-15  Darin Adler  <darin@apple.com>
648
649         Use warning-ignoring macros more consistently and simply
650         https://bugs.webkit.org/show_bug.cgi?id=192743
651
652         Reviewed by Mark Lam.
653
654         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
655         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
656         compilers in Objective-C++ code.
657
658         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
659         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
660         accomodate non-clang compilers here. Also use #pragma once, add a missing
661         "explicit" and fix conditionals.
662
663 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
664
665         Make TextInputController.legacyAttributedString take DOM nodes and offsets
666         https://bugs.webkit.org/show_bug.cgi?id=192653
667
668         Reviewed by Wenson Hsieh.
669
670         * WebView/WebHTMLView.mm:
671         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
672
673 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
674
675         Implement feature flag for CSS Typed OM
676         https://bugs.webkit.org/show_bug.cgi?id=192610
677
678         Reviewed by Ryosuke Niwa.
679
680         * Configurations/FeatureDefines.xcconfig:
681
682 2018-12-11  Tim Horton  <timothy_horton@apple.com>
683
684         WebCore shouldn't have a Objective-C class named NSCursor
685         https://bugs.webkit.org/show_bug.cgi?id=192602
686         <rdar://problem/46615532>
687
688         Reviewed by Wenson Hsieh.
689
690         * WebView/WebFrameView.mm:
691         (-[WebFrameView keyDown:keyDown:]):
692         * WebView/WebHTMLView.mm:
693         (-[WebHTMLView keyDown:]):
694         (-[WebHTMLView performKeyEquivalent:]):
695         Only use NSCursor on macOS.
696
697 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
698
699         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
700         https://bugs.webkit.org/show_bug.cgi?id=192573
701
702         Reviewed by Simon Fraser.
703
704         * Configurations/FeatureDefines.xcconfig:
705
706 2018-12-10  Antti Koivisto  <antti@apple.com>
707
708         Rename "forced style recalc" to "full style rebuild"
709         https://bugs.webkit.org/show_bug.cgi?id=192572
710
711         Reviewed by Zalan Bujtas.
712
713         * WebView/WebHTMLView.mm:
714         (-[WebHTMLView setNeedsToApplyStyles:]):
715
716 2018-12-10  Darin Adler  <darin@apple.com>
717
718         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
719         https://bugs.webkit.org/show_bug.cgi?id=192533
720         rdar://problem/45732710
721
722         Reviewed by Anders Carlsson.
723
724         * Plugins/Hosted/NetscapePluginHostProxy.mm:
725         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
726
727 2018-12-10  Darin Adler  <darin@apple.com>
728
729         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
730         https://bugs.webkit.org/show_bug.cgi?id=192532
731         rdar://problem/45731047
732
733         Reviewed by Chris Dumez.
734
735         * Plugins/Hosted/NetscapePluginHostManager.mm:
736         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
737         * Plugins/Hosted/NetscapePluginHostProxy.mm:
738         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
739
740 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
741
742         Turn WritingDirection into an enum class
743         https://bugs.webkit.org/show_bug.cgi?id=192401
744         Work towards <rdar://problem/42075638>
745
746         Reviewed by Dan Bernstein.
747
748         Change WritingDirection from an enum to an enum class. No change in behavior.
749
750         * WebView/WebHTMLView.mm:
751         (-[WebHTMLView toggleBaseWritingDirection:]):
752         (-[WebHTMLView changeBaseWritingDirection:]):
753         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
754
755 2018-12-03  Alex Christensen  <achristensen@webkit.org>
756
757         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
758         https://bugs.webkit.org/show_bug.cgi?id=192272
759
760         Reviewed by Brady Eidson.
761
762         * WebCoreSupport/WebFrameLoaderClient.h:
763         * WebCoreSupport/WebFrameLoaderClient.mm:
764         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
765
766 2018-12-03  Jer Noble  <jer.noble@apple.com>
767
768         Get rid of old, dead Mac video fullscreen code.
769         https://bugs.webkit.org/show_bug.cgi?id=192315
770
771         Reviewed by Eric Carlson.
772
773         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
774         is no longer supported in the Mac port.
775
776         * WebView/WebVideoFullscreenController.h: Removed.
777         * WebView/WebVideoFullscreenController.mm: Removed.
778         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
779         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
780         * WebView/WebView.mm:
781         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
782         (-[WebView _exitVideoFullscreen]):
783
784 2018-12-03  Daniel Bates  <dabates@apple.com>
785
786         [iOS] Do not handle key events that are key commands
787         https://bugs.webkit.org/show_bug.cgi?id=191608
788         <rdar://problem/46046013>
789
790         Reviewed by Ryosuke Niwa.
791
792         A key down event may be associated with a key command. If it is then we want to execute the
793         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
794         event as a key command to find out.
795
796         * WebView/WebHTMLView.mm:
797         (-[WebHTMLView _handleEditingKeyEvent:]):
798
799 2018-12-02  Zalan Bujtas  <zalan@apple.com>
800
801         Add a runtime feature flag for LayoutFormattingContext.
802         https://bugs.webkit.org/show_bug.cgi?id=192280
803
804         Reviewed by Simon Fraser.
805
806         * Configurations/FeatureDefines.xcconfig:
807
808 2018-11-30  Alex Christensen  <achristensen@webkit.org>
809
810         Move URL from WebCore to WTF
811         https://bugs.webkit.org/show_bug.cgi?id=190234
812
813         Reviewed by Keith Miller.
814
815         * DOM/DOMAttr.mm:
816         * DOM/DOMBlob.mm:
817         * DOM/DOMCSSCharsetRule.mm:
818         * DOM/DOMCSSImportRule.mm:
819         * DOM/DOMCSSMediaRule.mm:
820         * DOM/DOMCSSPageRule.mm:
821         * DOM/DOMCSSPrimitiveValue.mm:
822         * DOM/DOMCSSRule.mm:
823         * DOM/DOMCSSStyleDeclaration.mm:
824         * DOM/DOMCSSStyleRule.mm:
825         * DOM/DOMCSSStyleSheet.mm:
826         * DOM/DOMCSSValue.mm:
827         * DOM/DOMCharacterData.mm:
828         * DOM/DOMCounter.mm:
829         * DOM/DOMDocument.mm:
830         * DOM/DOMDocumentFragment.mm:
831         * DOM/DOMDocumentType.mm:
832         * DOM/DOMEvent.mm:
833         * DOM/DOMFile.mm:
834         * DOM/DOMHTMLAnchorElement.mm:
835         * DOM/DOMHTMLAppletElement.mm:
836         * DOM/DOMHTMLAreaElement.mm:
837         * DOM/DOMHTMLBRElement.mm:
838         * DOM/DOMHTMLBaseElement.mm:
839         * DOM/DOMHTMLBaseFontElement.mm:
840         * DOM/DOMHTMLBodyElement.mm:
841         * DOM/DOMHTMLButtonElement.mm:
842         * DOM/DOMHTMLCanvasElement.mm:
843         * DOM/DOMHTMLCollection.mm:
844         * DOM/DOMHTMLDivElement.mm:
845         * DOM/DOMHTMLDocument.mm:
846         * DOM/DOMHTMLElement.mm:
847         * DOM/DOMHTMLEmbedElement.mm:
848         * DOM/DOMHTMLFieldSetElement.mm:
849         * DOM/DOMHTMLFontElement.mm:
850         * DOM/DOMHTMLFormElement.mm:
851         * DOM/DOMHTMLFrameElement.mm:
852         * DOM/DOMHTMLFrameSetElement.mm:
853         * DOM/DOMHTMLHRElement.mm:
854         * DOM/DOMHTMLHeadElement.mm:
855         * DOM/DOMHTMLHeadingElement.mm:
856         * DOM/DOMHTMLHtmlElement.mm:
857         * DOM/DOMHTMLIFrameElement.mm:
858         * DOM/DOMHTMLImageElement.mm:
859         * DOM/DOMHTMLInputElement.mm:
860         * DOM/DOMHTMLLIElement.mm:
861         * DOM/DOMHTMLLabelElement.mm:
862         * DOM/DOMHTMLLegendElement.mm:
863         * DOM/DOMHTMLLinkElement.mm:
864         * DOM/DOMHTMLMapElement.mm:
865         * DOM/DOMHTMLMarqueeElement.mm:
866         * DOM/DOMHTMLMediaElement.mm:
867         * DOM/DOMHTMLMetaElement.mm:
868         * DOM/DOMHTMLModElement.mm:
869         * DOM/DOMHTMLOListElement.mm:
870         * DOM/DOMHTMLObjectElement.mm:
871         * DOM/DOMHTMLOptGroupElement.mm:
872         * DOM/DOMHTMLOptionElement.mm:
873         * DOM/DOMHTMLOptionsCollection.mm:
874         * DOM/DOMHTMLParagraphElement.mm:
875         * DOM/DOMHTMLParamElement.mm:
876         * DOM/DOMHTMLQuoteElement.mm:
877         * DOM/DOMHTMLScriptElement.mm:
878         * DOM/DOMHTMLSelectElement.mm:
879         * DOM/DOMHTMLStyleElement.mm:
880         * DOM/DOMHTMLTableCaptionElement.mm:
881         * DOM/DOMHTMLTableCellElement.mm:
882         * DOM/DOMHTMLTableColElement.mm:
883         * DOM/DOMHTMLTableElement.mm:
884         * DOM/DOMHTMLTableRowElement.mm:
885         * DOM/DOMHTMLTableSectionElement.mm:
886         * DOM/DOMHTMLTitleElement.mm:
887         * DOM/DOMHTMLUListElement.mm:
888         * DOM/DOMHTMLVideoElement.mm:
889         * DOM/DOMKeyboardEvent.mm:
890         * DOM/DOMMediaList.mm:
891         * DOM/DOMMouseEvent.mm:
892         * DOM/DOMMutationEvent.mm:
893         * DOM/DOMNamedNodeMap.mm:
894         * DOM/DOMProcessingInstruction.mm:
895         * DOM/DOMRange.mm:
896         * DOM/DOMStyleSheet.mm:
897         * DOM/DOMText.mm:
898         * DOM/DOMTextEvent.mm:
899         * DOM/DOMTokenList.mm:
900         * DOM/DOMUIEvent.mm:
901         * DOM/DOMXPathResult.mm:
902         * History/WebHistoryItem.mm:
903         * Misc/WebNSURLExtras.mm:
904         (-[NSURL _web_userVisibleString]):
905         (-[NSURL _web_URLByRemovingUserInfo]):
906         (-[NSURL _web_dataForURLComponentType:]):
907         (-[NSURL _web_schemeData]):
908         (-[NSURL _web_hostData]):
909         * Misc/WebUserContentURLPattern.mm:
910         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
911         * Plugins/WebNetscapePluginStream.h:
912         (WebNetscapePluginStream::setRequestURL):
913         * WebCoreSupport/WebChromeClient.h:
914         * WebCoreSupport/WebChromeClient.mm:
915         (WebChromeClient::signedPublicKeyAndChallengeString const):
916         * WebCoreSupport/WebContextMenuClient.h:
917         * WebCoreSupport/WebContextMenuClient.mm:
918         * WebCoreSupport/WebDragClient.h:
919         * WebCoreSupport/WebFrameLoaderClient.h:
920         * WebCoreSupport/WebFrameLoaderClient.mm:
921         (WebFrameLoaderClient::updateGlobalHistory):
922         * WebCoreSupport/WebPaymentCoordinatorClient.h:
923         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
924         (WebPaymentCoordinatorClient::showPaymentUI):
925         * WebCoreSupport/WebPlatformStrategies.h:
926         * WebCoreSupport/WebPlatformStrategies.mm:
927         (WebPlatformStrategies::readURLFromPasteboard):
928         * WebCoreSupport/WebPluginInfoProvider.h:
929         * WebCoreSupport/WebPluginInfoProvider.mm:
930         (WebPluginInfoProvider::webVisiblePluginInfo):
931         * WebCoreSupport/WebSecurityOrigin.mm:
932         * WebCoreSupport/WebVisitedLinkStore.h:
933         * WebView/WebDataSource.mm:
934         * WebView/WebFrame.mm:
935         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
936         * WebView/WebImmediateActionController.mm:
937         (-[WebImmediateActionController _defaultAnimationController]):
938         * WebView/WebPDFView.mm:
939         * WebView/WebScriptDebugger.mm:
940         * WebView/WebViewInternal.h:
941
942 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
943
944         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
945         https://bugs.webkit.org/show_bug.cgi?id=192197
946
947         Reviewed by Jiewen Tan.
948
949         * Configurations/FeatureDefines.xcconfig:
950         * WebCoreSupport/WebChromeClient.h:
951         * WebCoreSupport/WebChromeClient.mm:
952
953 2018-11-28  Alex Christensen  <achristensen@webkit.org>
954
955         Remove dead code from an earlier attempt at implementing safe browsing
956         https://bugs.webkit.org/show_bug.cgi?id=192067
957
958         Reviewed by Chris Dumez.
959
960         * WebCoreSupport/WebFrameLoaderClient.h:
961         * WebCoreSupport/WebFrameLoaderClient.mm:
962         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
963
964 2018-11-27  Mark Lam  <mark.lam@apple.com>
965
966         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
967         https://bugs.webkit.org/show_bug.cgi?id=192055
968         <rdar://problem/46288783>
969
970         Reviewed by Saam Barati.
971
972         * Configurations/FeatureDefines.xcconfig:
973
974 2018-11-25  Tim Horton  <timothy_horton@apple.com>
975
976         Make it possible to insert editable images with a gesture
977         https://bugs.webkit.org/show_bug.cgi?id=191937
978
979         Reviewed by Wenson Hsieh.
980
981         * WebCoreSupport/WebEditorClient.mm:
982         (undoNameForEditAction):
983         Add a undo name.
984
985 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
986
987         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
988         https://bugs.webkit.org/show_bug.cgi?id=191945
989
990         Reviewed by Anders Carlsson.
991
992         * WebCoreSupport/WebEditorClient.mm:
993         (undoNameForEditAction):
994
995 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
996
997         Enable drag and drop support for iOSMac
998         https://bugs.webkit.org/show_bug.cgi?id=191818
999         <rdar://problem/43907454>
1000
1001         Reviewed by Dean Jackson.
1002
1003         * Configurations/FeatureDefines.xcconfig:
1004
1005 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1006
1007         Address post-review feedback after r238438
1008         https://bugs.webkit.org/show_bug.cgi?id=191913
1009
1010         Reviewed by Ryosuke Niwa.
1011
1012         * WebView/WebFrame.mm:
1013         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1014         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1015         * WebView/WebView.mm:
1016         (-[WebView setSelectedDOMRange:affinity:]):
1017
1018 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1019
1020         Web Inspector: "Reload Web Inspector" button no longer partially works
1021         https://bugs.webkit.org/show_bug.cgi?id=191773
1022         <rdar://problem/46139932>
1023
1024         Reviewed by Devin Rousso.
1025
1026         * WebCoreSupport/WebInspectorClient.h:
1027         * WebCoreSupport/WebInspectorClient.mm:
1028         (WebInspectorFrontendClient::reopen):
1029
1030 2018-11-17  Devin Rousso  <drousso@apple.com>
1031
1032         Web Inspector: Network: add button to show system certificate dialog
1033         https://bugs.webkit.org/show_bug.cgi?id=191458
1034         <rdar://problem/45977019>
1035
1036         Reviewed by Joseph Pecoraro.
1037
1038         * WebCoreSupport/WebInspectorClient.h:
1039         * WebCoreSupport/WebInspectorClient.mm:
1040         (WebInspectorFrontendClient::showCertificate): Added.
1041
1042         * Configurations/WebKitLegacy.xcconfig:
1043
1044 2018-11-15  Truitt Savell  <tsavell@apple.com>
1045
1046         Unreviewed, rolling out r238244.
1047
1048         Caused High Sierra test runs to fail early with 50 crashes and
1049         casued 25 API failures.
1050
1051         Reverted changeset:
1052
1053         "[css-logical] Implement flow-relative margin, padding and
1054         border shorthands"
1055         https://bugs.webkit.org/show_bug.cgi?id=188697
1056         https://trac.webkit.org/changeset/238244
1057
1058 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1059
1060         [css-logical] Implement flow-relative margin, padding and border shorthands
1061         https://bugs.webkit.org/show_bug.cgi?id=188697
1062
1063         Reviewed by Simon Fraser and Antti Koivisto.
1064
1065         Add CSSLogicalEnabled runtime flag.
1066
1067         * WebView/WebPreferenceKeysPrivate.h:
1068         * WebView/WebPreferences.mm:
1069         (+[WebPreferences initialize]):
1070         (-[WebPreferences cssLogicalEnabled]):
1071         (-[WebPreferences setCSSLogicalEnabled:]):
1072         * WebView/WebPreferencesPrivate.h:
1073         * WebView/WebView.mm:
1074         (-[WebView _preferencesChanged:]):
1075
1076 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1077
1078         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1079         https://bugs.webkit.org/show_bug.cgi?id=191612
1080
1081         Reviewed by Matt Baker.
1082
1083         * WebCoreSupport/WebInspectorClient.mm:
1084         (-[WebInspectorWindowController destroyInspectorView]):
1085
1086 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1087
1088         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1089         https://bugs.webkit.org/show_bug.cgi?id=191494
1090         <rdar://problem/45469854>
1091
1092         Reviewed by Devin Rousso.
1093
1094         * WebCoreSupport/WebInspectorClient.h:
1095         WebKitLegacy will still have remote inspection of the Page directly.
1096
1097 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1098
1099         Make compositing updates incremental
1100         https://bugs.webkit.org/show_bug.cgi?id=90342
1101
1102         Reviewed by Antti Koivisto.
1103
1104         Fix spelling error.
1105
1106         * WebView/WebView.mm:
1107         (-[WebView _setMediaLayer:forPluginView:]):
1108
1109 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1110
1111         Implement a new edit command to change the enclosing list type
1112         https://bugs.webkit.org/show_bug.cgi?id=191487
1113         <rdar://problem/45955922>
1114
1115         Reviewed by Ryosuke Niwa.
1116
1117         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1118
1119         * WebCoreSupport/WebEditorClient.mm:
1120         (undoNameForEditAction):
1121
1122 2018-11-11  Daniel Bates  <dabates@apple.com>
1123
1124         [iOS] Draw caps lock indicator in password fields
1125         https://bugs.webkit.org/show_bug.cgi?id=190565
1126         <rdar://problem/45262343>
1127
1128         Reviewed by Dean Jackson.
1129
1130         Update the caps lock state when a hardware keyboard is attached or detached.
1131
1132         * WebView/WebHTMLView.mm:
1133         (hardwareKeyboardAvailabilityChangedCallback): Added.
1134         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1135         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1136
1137 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1138
1139         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1140         https://bugs.webkit.org/show_bug.cgi?id=191492
1141
1142         Reviewed by Alex Christensen.
1143
1144         * Carbon/HIWebView.mm:
1145         * Misc/WebNSFileManagerExtras.mm:
1146         * Misc/WebNSURLExtras.mm:
1147         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1148         * Plugins/WebBasePluginPackage.mm:
1149         * Plugins/WebPluginContainerCheck.mm:
1150         * WebCoreSupport/WebCachedFramePlatformData.h:
1151         * WebCoreSupport/WebDeviceOrientationClient.mm:
1152         * WebView/WebDelegateImplementationCaching.mm:
1153         * WebView/WebHTMLView.mm:
1154         * WebView/WebPDFRepresentation.mm:
1155         * WebView/WebPolicyDelegate.mm:
1156         * WebView/WebView.mm:
1157
1158 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1159
1160         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1161         https://bugs.webkit.org/show_bug.cgi?id=191492
1162
1163         Reviewed by Alex Christensen.
1164
1165         * Carbon/HIWebView.mm:
1166         (UpdateCommandStatus):
1167         * Misc/WebNSFileManagerExtras.mm:
1168         * Misc/WebNSURLExtras.mm:
1169         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1170         * Plugins/WebBasePluginPackage.mm:
1171         * Plugins/WebPluginContainerCheck.mm:
1172         (-[WebPluginContainerCheck _continueWithPolicy:]):
1173         * WebCoreSupport/WebCachedFramePlatformData.h:
1174         (WebCachedFramePlatformData::clear):
1175         * WebCoreSupport/WebDeviceOrientationClient.mm:
1176         (WebDeviceOrientationClient::getProvider const):
1177         * WebView/WebDelegateImplementationCaching.mm:
1178         (CallDelegate):
1179         (CallDelegateReturningBoolean):
1180         (CallResourceLoadDelegateReturningBoolean):
1181         (CallFormDelegate):
1182         (CallFormDelegateReturningBoolean):
1183         * WebView/WebHTMLView.mm:
1184         * WebView/WebPDFRepresentation.mm:
1185         * WebView/WebPolicyDelegate.mm:
1186         (-[WebPolicyDecisionListener _usePolicy:]):
1187         * WebView/WebView.mm:
1188
1189 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1190
1191         Unreviewed, rolling out r238047.
1192
1193         Introduced layout test failures on iOS simulator.
1194
1195         Reverted changeset:
1196
1197         "[iOS] Draw caps lock indicator in password fields"
1198         https://bugs.webkit.org/show_bug.cgi?id=190565
1199         https://trac.webkit.org/changeset/238047
1200
1201 2018-11-09  Antti Koivisto  <antti@apple.com>
1202
1203         Use OptionSet for layout milestones
1204         https://bugs.webkit.org/show_bug.cgi?id=191470
1205
1206         Reviewed by Dean Jackson.
1207
1208         * WebCoreSupport/WebFrameLoaderClient.h:
1209         * WebCoreSupport/WebFrameLoaderClient.mm:
1210         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1211         * WebView/WebView.mm:
1212         (coreLayoutMilestones):
1213         (kitLayoutMilestones):
1214         (-[WebView _cacheFrameLoadDelegateImplementations]):
1215         * WebView/WebViewInternal.h:
1216
1217 2018-11-09  Daniel Bates  <dabates@apple.com>
1218
1219         [iOS] Draw caps lock indicator in password fields
1220         https://bugs.webkit.org/show_bug.cgi?id=190565
1221         <rdar://problem/45262343>
1222
1223         Reviewed by Dean Jackson.
1224
1225         Update the caps lock state when a hardware keyboard is attached or detached.
1226
1227         * WebView/WebHTMLView.mm:
1228         (hardwareKeyboardAvailabilityChangedCallback): Added.
1229         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1230         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1231
1232 2018-11-09  Daniel Bates  <dabates@apple.com>
1233
1234         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1235         action when forward delete is pressed outside a text field
1236         https://bugs.webkit.org/show_bug.cgi?id=190566
1237         <rdar://problem/45262367>
1238
1239         Reviewed by Wenson Hsieh.
1240
1241         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1242         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1243         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1244
1245         * WebView/WebHTMLView.mm:
1246         (-[WebHTMLView _handleEditingKeyEvent:]):
1247
1248 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1249
1250         Adopt Reveal Framework to replace Lookup
1251         https://bugs.webkit.org/show_bug.cgi?id=191097
1252         <rdar://problem/45924508>
1253
1254         Reviewed by Tim Horton.
1255
1256         Pass in what it needed to clear the textIndicators. This is better than
1257         the current notification structure.
1258
1259         * WebView/WebView.mm:
1260         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1261         (-[WebView _prepareForDictionaryLookup]):
1262
1263 2018-11-06  Justin Fan  <justin_fan@apple.com>
1264
1265         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1266         https://bugs.webkit.org/show_bug.cgi?id=191291
1267
1268         Reviewed by Myles Maxfield.
1269
1270         Properly disable WEBGPU on all non-Metal platforms for now.
1271
1272         * Configurations/FeatureDefines.xcconfig:
1273
1274 2018-11-02  Daniel Bates  <dabates@apple.com>
1275
1276         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1277         https://bugs.webkit.org/show_bug.cgi?id=190487
1278
1279         Reviewed by Tim Horton.
1280
1281         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1282         allow the default handling.
1283
1284         * WebView/WebHTMLView.mm:
1285         (-[WebHTMLView _handleEditingKeyEvent:]):
1286
1287 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1288
1289         Add a storage limit for IndexedDB
1290         https://bugs.webkit.org/show_bug.cgi?id=190598
1291         <rdar://problem/44654715>
1292
1293         Reviewed by Chris Dumez.
1294
1295         * Storage/WebDatabaseManager.mm:
1296         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1297         * Storage/WebDatabaseManagerPrivate.h:
1298
1299 2018-10-31  Antti Koivisto  <antti@apple.com>
1300
1301         Remove LayerFlushScheduler
1302         https://bugs.webkit.org/show_bug.cgi?id=191103
1303
1304         Reviewed by Anders Carlsson.
1305
1306         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1307         all the virtual cruft.
1308
1309         * WebView/WebViewData.h:
1310         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1311         (): Deleted.
1312         * WebView/WebViewData.mm:
1313         (currentRunLoop):
1314         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1315         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1316         (WebViewLayerFlushScheduler::schedule):
1317         (WebViewLayerFlushScheduler::invalidate):
1318         (WebViewLayerFlushScheduler::layerFlushCallback):
1319
1320 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1321
1322         Enable InstallAPI for iOS unconditionally
1323         https://bugs.webkit.org/show_bug.cgi?id=191043
1324         rdar://problem/32728423
1325
1326         Reviewed by Dan Bernstein.
1327
1328         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1329         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1330         shouldn't be processed by InstallAPI.
1331         * MigrateHeaders.make: Removed an obsolete workaround.
1332         * Misc/NSURLDownloadSPI.h: Added.
1333         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1334
1335 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1336
1337         Clean up some obsolete MAX_ALLOWED macros
1338         https://bugs.webkit.org/show_bug.cgi?id=190916
1339
1340         Reviewed by Tim Horton.
1341
1342         * WebView/WebHTMLView.mm:
1343         (-[WebHTMLView pressureChangeWithEvent:]):
1344         * WebView/WebPDFView.h:
1345
1346 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1347
1348         Unreviewed, rolling out r237600 and r237604.
1349         https://bugs.webkit.org/show_bug.cgi?id=191086
1350
1351         Breaks internal iOS builds (Requested by ryanhadd_ on
1352         #webkit).
1353
1354         Reverted changesets:
1355
1356         "Enable InstallAPI for iOS unconditionally"
1357         https://bugs.webkit.org/show_bug.cgi?id=191043
1358         https://trac.webkit.org/changeset/237600
1359
1360         "Build fix attempt after enabling InstallAPI for iOS."
1361         https://bugs.webkit.org/show_bug.cgi?id=191043
1362         https://trac.webkit.org/changeset/237604
1363
1364 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1365
1366         Enable InstallAPI for iOS unconditionally
1367         https://bugs.webkit.org/show_bug.cgi?id=191043
1368         rdar://problem/32728423
1369
1370         Reviewed by Dan Bernstein.
1371
1372         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1373         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1374         shouldn't be processed by InstallAPI.
1375         * MigrateHeaders.make: Removed an obsolete workaround.
1376         * Misc/NSURLDownloadSPI.h: Added.
1377         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1378
1379 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1380
1381         Modernize WebKit nibs and lprojs for localization's sake
1382         https://bugs.webkit.org/show_bug.cgi?id=190911
1383         <rdar://problem/45349466>
1384
1385         Reviewed by Dan Bernstein.
1386
1387         * Misc/WebNSControlExtras.m:
1388         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1389         NSWindow and its contents are both in the same scale space these days; avoid
1390         double-applying the scale factor, or you can't see the prompt.
1391
1392         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1393         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1394         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1395         NIB->XIB
1396
1397 2018-10-25  Antoine Quint  <graouts@apple.com>
1398
1399         [Web Animations] Turn Web Animations CSS Integration off by default
1400         https://bugs.webkit.org/show_bug.cgi?id=190901
1401
1402         Reviewed by Dean Jackson.
1403
1404         * WebView/WebPreferences.mm:
1405         (+[WebPreferences initialize]):
1406
1407 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1408
1409         Clean up some obsolete macOS version guards
1410         https://bugs.webkit.org/show_bug.cgi?id=190887
1411
1412         Reviewed by Dan Bernstein.
1413
1414         * Misc/WebNSPasteboardExtras.mm:
1415         (+[NSPasteboard _web_dragTypesForURL]):
1416         * WebCoreSupport/PopupMenuMac.mm:
1417         (PopupMenuMac::show):
1418         * WebCoreSupport/WebEditorClient.h:
1419         * WebCoreSupport/WebEditorClient.mm:
1420         (WebEditorClient::respondToChangedSelection):
1421         * WebView/WebPDFView.mm:
1422         (-[WebPDFView _clipViewForPDFDocumentView]):
1423
1424 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1425
1426         Turn on Conic Gradients
1427         https://bugs.webkit.org/show_bug.cgi?id=190810
1428
1429         Reviewed by Tim Horton.
1430
1431         * Configurations/FeatureDefines.xcconfig:
1432
1433 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1434
1435         Cleanup: MIMETypeRegistry functions
1436         https://bugs.webkit.org/show_bug.cgi?id=190838
1437
1438         Reviewed by Simon Fraser.
1439
1440         * Misc/WebNSPasteboardExtras.mm:
1441         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1442         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1443         because they were identical.
1444
1445         * WebView/WebHTMLRepresentation.mm:
1446         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1447         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1448         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1449         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1450         * WebView/WebView.mm:
1451         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1452         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1453         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1454
1455 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1456
1457         Fix false positive leaks when using custom -init methods that don't start with -init
1458         <https://webkit.org/b/190818>
1459         <rdar://problem/45476042>
1460
1461         Reviewed by Dan Bernstein.
1462
1463         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1464         it is accessible by both categories.
1465         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1466         NSError (WebKitInternal) category.  Add attribute to make this
1467         behave like an -init method.
1468         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1469         NSError (WebKitInternal) category.  Modernize method.  Replace
1470         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1471
1472 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1473
1474         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1475         https://bugs.webkit.org/show_bug.cgi?id=190729
1476
1477         Reviewed by Tim Horton.
1478
1479         * DOM/DOM.mm:
1480         (-[DOMNode boundingBox]):
1481         * DOM/DOMElement.mm:
1482         * DOM/DOMHTML.mm:
1483         * DOM/DOMInternal.mm:
1484         * DOM/DOMUIKitExtensions.mm:
1485         * DOM/WebDOMOperations.mm:
1486         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1487         * DefaultDelegates/WebDefaultEditingDelegate.m:
1488         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1489         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1490         * DefaultDelegates/WebDefaultUIDelegate.h:
1491         * DefaultDelegates/WebDefaultUIDelegate.mm:
1492         (-[WebDefaultUIDelegate webViewClose:]):
1493         (-[WebDefaultUIDelegate webViewFocus:]):
1494         (-[WebDefaultUIDelegate webViewUnfocus:]):
1495         (-[WebDefaultUIDelegate webViewIsResizable:]):
1496         (-[WebDefaultUIDelegate webView:setResizable:]):
1497         (-[WebDefaultUIDelegate webView:setFrame:]):
1498         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1499         * History/BackForwardList.h:
1500         * History/BackForwardList.mm:
1501         * History/WebBackForwardList.mm:
1502         (+[WebBackForwardList initialize]):
1503         (bumperCarBackForwardHackNeeded):
1504         * History/WebHistory.mm:
1505         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1506         (-[WebHistory _sendNotification:entries:]):
1507         (-[WebHistory loadFromURL:error:]):
1508         (-[WebHistory saveToURL:error:]):
1509         * History/WebHistoryItem.mm:
1510         (WKNotifyHistoryItemChanged):
1511         (+[WebHistoryItem initialize]):
1512         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1513         * History/WebURLsWithTitles.m:
1514         * Misc/WebCache.mm:
1515         (+[WebCache initialize]):
1516         * Misc/WebDownload.mm:
1517         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1518         * Misc/WebElementDictionary.mm:
1519         (+[WebElementDictionary initialize]):
1520         (+[WebElementDictionary initializeLookupTable]):
1521         * Misc/WebIconDatabase.mm:
1522         * Misc/WebKitNSStringExtras.mm:
1523         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1524         * Misc/WebKitVersionChecks.h:
1525         * Misc/WebKitVersionChecks.mm:
1526         (WebKitLinkedOnOrAfter):
1527         (WebKitLinkTimeVersion):
1528         * Misc/WebLocalizableStrings.mm:
1529         * Misc/WebNSControlExtras.h:
1530         * Misc/WebNSControlExtras.m:
1531         * Misc/WebNSEventExtras.m:
1532         * Misc/WebNSFileManagerExtras.mm:
1533         * Misc/WebNSImageExtras.h:
1534         * Misc/WebNSImageExtras.m:
1535         * Misc/WebNSPasteboardExtras.mm:
1536         * Misc/WebNSPrintOperationExtras.h:
1537         * Misc/WebNSPrintOperationExtras.m:
1538         * Misc/WebNSViewExtras.m:
1539         * Misc/WebNSWindowExtras.m:
1540         * Panels/WebAuthenticationPanel.h:
1541         * Panels/WebAuthenticationPanel.m:
1542         * Panels/WebPanelAuthenticationHandler.m:
1543         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1544         (+[WebHostedNetscapePluginView initialize]):
1545         * Plugins/WebBasePluginPackage.h:
1546         * Plugins/WebBasePluginPackage.mm:
1547         * Plugins/WebJavaPlugIn.h:
1548         * Plugins/WebPluginContainerCheck.mm:
1549         * Plugins/WebPluginController.h:
1550         * Plugins/WebPluginController.mm:
1551         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1552         (-[WebPluginController addPlugin:]):
1553         (-[WebPluginController destroyPlugin:]):
1554         (-[WebPluginController destroyAllPlugins]):
1555         * Plugins/WebPluginDatabase.mm:
1556         (+[WebPluginDatabase _defaultPlugInPaths]):
1557         * Plugins/WebPluginPackage.mm:
1558         (-[WebPluginPackage initWithPath:]):
1559         * Storage/WebDatabaseManager.mm:
1560         (-[WebDatabaseManager deleteAllDatabases]):
1561         * Storage/WebDatabaseManagerClient.h:
1562         * Storage/WebDatabaseManagerClient.mm:
1563         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1564         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1565         * Storage/WebStorageManager.mm:
1566         (-[WebStorageManager deleteAllOrigins]):
1567         (WebKitInitializeStorageIfNecessary):
1568         * WebCoreSupport/WebAlternativeTextClient.h:
1569         * WebCoreSupport/WebApplicationCache.mm:
1570         (applicationCacheBundleIdentifier):
1571         * WebCoreSupport/WebChromeClient.h:
1572         * WebCoreSupport/WebChromeClient.mm:
1573         (WebChromeClient::setWindowRect):
1574         (WebChromeClient::windowRect):
1575         (WebChromeClient::takeFocus):
1576         (WebChromeClient::addMessageToConsole):
1577         (WebChromeClient::enableSuddenTermination):
1578         (WebChromeClient::disableSuddenTermination):
1579         (WebChromeClient::createPopupMenu const):
1580         (WebChromeClient::createSearchPopupMenu const):
1581         (WebChromeClient::shouldPaintEntireContents const):
1582         (WebChromeClient::supportsVideoFullscreen):
1583         (WebChromeClient::supportsFullScreenForElement):
1584         (WebChromeClient::enterFullScreenForElement):
1585         (WebChromeClient::exitFullScreenForElement):
1586         * WebCoreSupport/WebContextMenuClient.mm:
1587         * WebCoreSupport/WebDragClient.mm:
1588         * WebCoreSupport/WebEditorClient.h:
1589         * WebCoreSupport/WebEditorClient.mm:
1590         (+[WebUndoStep initialize]):
1591         (updateFontPanel):
1592         (WebEditorClient::didBeginEditing):
1593         (WebEditorClient::respondToChangedContents):
1594         (WebEditorClient::respondToChangedSelection):
1595         (WebEditorClient::canceledComposition):
1596         (WebEditorClient::didEndEditing):
1597         (WebEditorClient::didWriteSelectionToPasteboard):
1598         (attributesForAttributedStringConversion):
1599         (WebEditorClient::setInsertionPasteboard):
1600         (WebEditorClient::registerUndoOrRedoStep):
1601         (WebEditorClient::handleKeyboardEvent):
1602         (WebEditorClient::handleInputMethodKeydown):
1603         (WebEditorClient::textDidChangeInTextField):
1604         (WebEditorClient::requestCheckingOfString):
1605         * WebCoreSupport/WebFrameLoaderClient.h:
1606         * WebCoreSupport/WebFrameLoaderClient.mm:
1607         (WebFrameLoaderClient::detachedFromParent2):
1608         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1609         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1610         (WebFrameLoaderClient::dispatchWillSendRequest):
1611         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1612         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1613         (WebFrameLoaderClient::willCacheResponse const):
1614         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1615         (WebFrameLoaderClient::dispatchDidFinishLoading):
1616         (WebFrameLoaderClient::dispatchDidFailLoading):
1617         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1618         (WebFrameLoaderClient::dispatchWillClose):
1619         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1620         (WebFrameLoaderClient::dispatchDidCommitLoad):
1621         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1622         (WebFrameLoaderClient::dispatchDidFailLoad):
1623         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1624         (WebFrameLoaderClient::dispatchDidFinishLoad):
1625         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1626         (WebFrameLoaderClient::willChangeTitle):
1627         (WebFrameLoaderClient::didChangeTitle):
1628         (WebFrameLoaderClient::didReplaceMultipartContent):
1629         (WebFrameLoaderClient::updateGlobalHistory):
1630         (WebFrameLoaderClient::saveViewStateToItem):
1631         (WebFrameLoaderClient::restoreViewState):
1632         (WebFrameLoaderClient::provisionalLoadStarted):
1633         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1634         (WebFrameLoaderClient::setTitle):
1635         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
1636         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
1637         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1638         (WebFrameLoaderClient::didRestoreFromPageCache):
1639         (WebFrameLoaderClient::actionDictionary const):
1640         (WebFrameLoaderClient::createPlugin):
1641         (WebFrameLoaderClient::getLoadDecisionForIcons):
1642         (WebFrameLoaderClient::finishedLoadingIcon):
1643         (+[WebFramePolicyListener initialize]):
1644         * WebCoreSupport/WebFrameNetworkingContext.mm:
1645         * WebCoreSupport/WebGeolocationClient.h:
1646         * WebCoreSupport/WebGeolocationClient.mm:
1647         (WebGeolocationClient::requestPermission):
1648         * WebCoreSupport/WebInspectorClient.h:
1649         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
1650         * WebCoreSupport/WebNotificationClient.mm:
1651         * WebCoreSupport/WebOpenPanelResultListener.mm:
1652         * WebCoreSupport/WebPlatformStrategies.h:
1653         * WebCoreSupport/WebPlatformStrategies.mm:
1654         * WebCoreSupport/WebProgressTrackerClient.h:
1655         * WebCoreSupport/WebProgressTrackerClient.mm:
1656         (WebProgressTrackerClient::progressStarted):
1657         (WebProgressTrackerClient::progressEstimateChanged):
1658         (WebProgressTrackerClient::progressFinished):
1659         * WebCoreSupport/WebSecurityOrigin.mm:
1660         * WebInspector/WebNodeHighlight.h:
1661         * WebInspector/WebNodeHighlight.mm:
1662         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
1663         (-[WebNodeHighlight dealloc]):
1664         (-[WebNodeHighlight attach]):
1665         * WebInspector/WebNodeHighlightView.h:
1666         * WebInspector/WebNodeHighlightView.mm:
1667         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
1668         (-[WebNodeHighlightView dealloc]):
1669         * WebInspector/WebNodeHighlighter.mm:
1670         (-[WebNodeHighlighter highlight]):
1671         * WebView/WebArchive.mm:
1672         (+[WebArchivePrivate initialize]):
1673         * WebView/WebClipView.h:
1674         * WebView/WebDataSource.mm:
1675         (WebDataSourcePrivate::WebDataSourcePrivate):
1676         (+[WebDataSource initialize]):
1677         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1678         (-[WebDataSource _makeRepresentation]):
1679         * WebView/WebDelegateImplementationCaching.h:
1680         * WebView/WebDelegateImplementationCaching.mm:
1681         (CallDelegate):
1682         (CallDelegateReturningFloat):
1683         (CallDelegateReturningBoolean):
1684         (CallUIDelegate):
1685         (CallUIDelegateReturningFloat):
1686         (CallUIDelegateReturningBoolean):
1687         (CallFrameLoadDelegate):
1688         (CallFrameLoadDelegateReturningBoolean):
1689         (CallResourceLoadDelegate):
1690         (CallScriptDebugDelegate):
1691         (CallFormDelegate):
1692         (CallFormDelegateReturningBoolean):
1693         * WebView/WebDeviceOrientation.mm:
1694         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
1695         * WebView/WebDocumentInternal.h:
1696         * WebView/WebDocumentLoaderMac.mm:
1697         (needsDataLoadWorkaround):
1698         * WebView/WebDynamicScrollBarsViewInternal.h:
1699         * WebView/WebFormDelegate.m:
1700         * WebView/WebFrame.mm:
1701         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1702         (-[WebFrame _unmarkAllMisspellings]):
1703         (-[WebFrame _paintBehaviorForDestinationContext:]):
1704         (-[WebFrame _drawRect:contentsOnly:]):
1705         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
1706         (-[WebFrame _scrollDOMRangeToVisible:]):
1707         (-[WebFrame _bodyBackgroundColor]):
1708         (-[WebFrame accessibilityRoot]):
1709         (needsMicrosoftMessengerDOMDocumentWorkaround):
1710         * WebView/WebFrameInternal.h:
1711         * WebView/WebFrameView.mm:
1712         (-[WebFrameView _setDocumentView:]):
1713         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
1714         (-[WebFrameView _viewClassForMIMEType:]):
1715         (-[WebFrameView initWithFrame:]):
1716         (-[WebFrameView drawRect:]):
1717         (-[WebFrameView _firstResponderIsFormControl]):
1718         (-[WebFrameView keyDown:keyDown:]):
1719         (-[WebFrameView _isScrollable]):
1720         * WebView/WebFullScreenController.h:
1721         * WebView/WebFullScreenController.mm:
1722         * WebView/WebHTMLRepresentation.mm:
1723         * WebView/WebHTMLView.mm:
1724         (-[WebHTMLView hitTest:]):
1725         (-[WebHTMLView initWithFrame:]):
1726         (-[WebHTMLView dealloc]):
1727         (-[WebHTMLView addSubview:]):
1728         (-[WebHTMLView mouseDown:]):
1729         (-[WebHTMLView mouseUp:]):
1730         (-[WebHTMLView resignFirstResponder]):
1731         (-[WebHTMLView accessibilityHitTest:]):
1732         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
1733         * WebView/WebHTMLViewInternal.h:
1734         * WebView/WebIndicateLayer.h:
1735         * WebView/WebIndicateLayer.mm:
1736         * WebView/WebMediaPlaybackTargetPicker.h:
1737         * WebView/WebMediaPlaybackTargetPicker.mm:
1738         * WebView/WebPDFDocumentExtras.h:
1739         * WebView/WebPDFDocumentExtras.mm:
1740         * WebView/WebPDFRepresentation.h:
1741         * WebView/WebPDFRepresentation.mm:
1742         * WebView/WebPDFView.h:
1743         * WebView/WebPreferences.mm:
1744         (cacheModelForMainBundle):
1745         (WebPreferencesPrivate::WebPreferencesPrivate):
1746         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
1747         (-[WebPreferences encodeWithCoder:]):
1748         (+[WebPreferences standardPreferences]):
1749         (+[WebPreferences initialize]):
1750         (-[WebPreferences _valueForKey:]):
1751         (-[WebPreferences _setStringValue:forKey:]):
1752         (-[WebPreferences _setIntegerValue:forKey:]):
1753         (-[WebPreferences _setUnsignedIntValue:forKey:]):
1754         (-[WebPreferences _setFloatValue:forKey:]):
1755         (-[WebPreferences _setBoolValue:forKey:]):
1756         (-[WebPreferences _setLongLongValue:forKey:]):
1757         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
1758         (-[WebPreferences _postCacheModelChangedNotification]):
1759         (-[WebPreferences _postPreferencesChangedNotification]):
1760         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
1761         (-[WebPreferences setStorageBlockingPolicy:]):
1762         * WebView/WebResource.mm:
1763         (+[WebResourcePrivate initialize]):
1764         * WebView/WebTextCompletionController.h:
1765         * WebView/WebTextIterator.mm:
1766         (+[WebTextIteratorPrivate initialize]):
1767         * WebView/WebView.mm:
1768         (shouldEnableLoadDeferring):
1769         (shouldRestrictWindowFocus):
1770         (shouldRespectPriorityInCSSAttributeSetters):
1771         (shouldUseLegacyBackgroundSizeShorthandBehavior):
1772         (shouldAllowPictureInPictureMediaPlayback):
1773         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
1774         (shouldAllowWindowOpenWithoutUserGesture):
1775         (shouldConvertInvalidURLsToBlank):
1776         (shouldRequireUserGestureToLoadVideo):
1777         (-[WebView _commonInitializationWithFrameName:groupName:]):
1778         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
1779         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
1780         (-[WebView _closePluginDatabases]):
1781         (-[WebView _closeWithFastTeardown]):
1782         (-[WebView _close]):
1783         (+[WebView _MIMETypeForFile:]):
1784         (-[WebView setShowingInspectorIndication:]):
1785         (-[WebView _setFormDelegate:]):
1786         (-[WebView _needsPreHTML5ParserQuirks]):
1787         (-[WebView _preferencesChangedNotification:]):
1788         (-[WebView _preferencesChanged:]):
1789         (-[WebView _cacheResourceLoadDelegateImplementations]):
1790         (-[WebView _cacheFrameLoadDelegateImplementations]):
1791         (-[WebView _policyDelegateForwarder]):
1792         (-[WebView _UIDelegateForwarder]):
1793         (-[WebView _editingDelegateForwarder]):
1794         (-[WebView _updateActiveState]):
1795         (-[_WebSafeForwarder forwardInvocation:]):
1796         (+[WebView initialize]):
1797         (-[WebView _pluginForMIMEType:]):
1798         (-[WebView _pluginForExtension:]):
1799         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
1800         (+[WebView canShowMIMETypeAsHTML:]):
1801         (-[WebView _initWithArguments:]):
1802         (-[WebView initWithFrame:frameName:groupName:]):
1803         (-[WebView dealloc]):
1804         (-[WebView close]):
1805         (-[WebView viewDidMoveToWindow]):
1806         (-[WebView setUIDelegate:]):
1807         (-[WebView setResourceLoadDelegate:]):
1808         (-[WebView setPolicyDelegate:]):
1809         (-[WebView setFrameLoadDelegate:]):
1810         (-[WebView goBack]):
1811         (-[WebView goForward]):
1812         (-[WebView stringByEvaluatingJavaScriptFromString:]):
1813         (-[WebView setHostWindow:]):
1814         (-[WebView becomeFirstResponder]):
1815         (+[WebView _cacheModelChangedNotification:]):
1816         (-[WebView _frameViewAtWindowPoint:]):
1817         (+[WebView _preflightSpellCheckerNow:]):
1818         (+[WebView _preflightSpellChecker]):
1819         (-[WebView canGoBack]):
1820         (-[WebView canGoForward]):
1821         (-[WebView stopLoading:]):
1822         (-[WebView reload:]):
1823         (-[WebView setMainFrameDocumentReady:]):
1824         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1825         (-[WebView setContinuousSpellCheckingEnabled:]):
1826         (-[WebView undoManager]):
1827         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
1828         (-[WebView isAutomaticLinkDetectionEnabled]):
1829         (-[WebView isAutomaticDashSubstitutionEnabled]):
1830         (-[WebView isAutomaticTextReplacementEnabled]):
1831         (-[WebView isAutomaticSpellingCorrectionEnabled]):
1832         (+[WebView _setCacheModel:]):
1833         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
1834         (-[WebView _keyboardUIMode]):
1835         (LayerFlushController::flushLayers):
1836         (-[WebView _scheduleCompositingLayerFlush]):
1837         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1838         (-[WebView fullScreenPlaceholderView]):
1839         (WebInstallMemoryPressureHandler):
1840         * WebView/WebViewData.h:
1841         * WebView/WebViewData.mm:
1842         (+[WebViewPrivate initialize]):
1843         (-[WebViewPrivate init]):
1844         (-[WebViewPrivate dealloc]):
1845         * WebView/WebViewInternal.h:
1846
1847 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1848
1849         Clean up FrameLoader two-state enums
1850         https://bugs.webkit.org/show_bug.cgi?id=190731
1851
1852         Reviewed by Chris Dumez.
1853
1854         * WebCoreSupport/WebFrameLoaderClient.h:
1855         * WebCoreSupport/WebFrameLoaderClient.mm:
1856         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1857
1858 2018-10-18  Alex Christensen  <achristensen@webkit.org>
1859
1860         Unreviewed, rolling out r237137.
1861
1862         SPI is actually used
1863
1864         Reverted changeset:
1865
1866         "Remove unused WebFrame._loadType"
1867         https://bugs.webkit.org/show_bug.cgi?id=190583
1868         https://trac.webkit.org/changeset/237137
1869
1870 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1871
1872         Enable the datalist element by default on iOS and macOS
1873         https://bugs.webkit.org/show_bug.cgi?id=190594
1874         <rdar://problem/45281159>
1875
1876         Reviewed by Ryosuke Niwa and Tim Horton.
1877
1878         * Configurations/FeatureDefines.xcconfig:
1879
1880 2018-10-17  Alex Christensen  <achristensen@webkit.org>
1881
1882         BackForwardClient needs to be able to support UIProcess-only back/forward lists
1883         https://bugs.webkit.org/show_bug.cgi?id=190675
1884
1885         Reviewed by Chris Dumez.
1886
1887         * History/BackForwardList.h:
1888         * History/BackForwardList.mm:
1889         (BackForwardList::backItem):
1890         (BackForwardList::currentItem):
1891         (BackForwardList::forwardItem):
1892         (BackForwardList::backListCount const):
1893         (BackForwardList::forwardListCount const):
1894         (BackForwardList::itemAtIndex):
1895         * History/WebBackForwardList.mm:
1896         (-[WebBackForwardList backItem]):
1897         (-[WebBackForwardList currentItem]):
1898         (-[WebBackForwardList forwardItem]):
1899         (-[WebBackForwardList itemAtIndex:]):
1900
1901 2018-10-16  Timothy Hatcher  <timothy@apple.com>
1902
1903         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
1904         https://bugs.webkit.org/show_bug.cgi?id=190526
1905         rdar://problem/45230140
1906
1907         Reviewed by Dean Jackson.
1908
1909         * WebCoreSupport/WebEditorClient.mm:
1910         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
1911
1912 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
1913
1914         Implement feature flag and bindings for CSS Painting API
1915         https://bugs.webkit.org/show_bug.cgi?id=190237
1916
1917         Reviewed by Ryosuke Niwa.
1918
1919         * Configurations/FeatureDefines.xcconfig:
1920
1921 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1922
1923         Replace HistoryItem* with HistoryItem& where possible
1924         https://bugs.webkit.org/show_bug.cgi?id=190617
1925
1926         Reviewed by Chris Dumez.
1927
1928         * History/BackForwardList.h:
1929         * History/BackForwardList.mm:
1930         (BackForwardList::goToItem):
1931         * History/WebBackForwardList.mm:
1932         (-[WebBackForwardList goToItem:]):
1933         * History/WebHistoryItem.mm:
1934         (WKNotifyHistoryItemChanged):
1935         * History/WebHistoryItemInternal.h:
1936
1937 2018-10-16  Alex Christensen  <achristensen@webkit.org>
1938
1939         Remove unused WebHistoryItem._transientPropertyForKey
1940         https://bugs.webkit.org/show_bug.cgi?id=190606
1941
1942         Reviewed by Chris Dumez.
1943
1944         * History/WebHistoryItem.mm:
1945         * History/WebHistoryItemPrivate.h:
1946
1947 2018-10-15  Justin Fan  <justin_fan@apple.com>
1948
1949         Add WebGPU 2018 feature flag and experimental feature flag
1950         https://bugs.webkit.org/show_bug.cgi?id=190509
1951
1952         Reviewed by Dean Jackson.
1953
1954         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
1955         for the 2018 WebGPU prototype.
1956
1957         * Configurations/FeatureDefines.xcconfig:
1958         * WebView/WebPreferenceKeysPrivate.h:
1959         * WebView/WebPreferences.mm:
1960         (+[WebPreferences initialize]):
1961         (-[WebPreferences webGPUEnabled]):
1962         (-[WebPreferences setWebGPUEnabled:]):
1963         * WebView/WebPreferencesPrivate.h:
1964         * WebView/WebView.mm:
1965         (-[WebView _preferencesChanged:]):
1966
1967 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1968
1969         Fix iOS build after r237157
1970
1971         * WebView/WebView.mm:
1972         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1973
1974 2018-10-15  Alex Christensen  <achristensen@webkit.org>
1975
1976         Modernize BackForwardClient.h
1977         https://bugs.webkit.org/show_bug.cgi?id=190610
1978
1979         Reviewed by Chris Dumez.
1980
1981         * History/BackForwardList.h:
1982         * History/BackForwardList.mm:
1983         (BackForwardList::backListCount const):
1984         (BackForwardList::forwardListCount const):
1985         (BackForwardList::backListCount): Deleted.
1986         (BackForwardList::forwardListCount): Deleted.
1987         * History/WebBackForwardList.mm:
1988         (-[WebBackForwardList init]):
1989         * WebCoreSupport/WebFrameLoaderClient.mm:
1990         (WebFrameLoaderClient::canCachePage const):
1991         * WebView/WebFrameView.mm:
1992         (-[WebFrameView keyDown:keyDown:]):
1993         * WebView/WebView.mm:
1994         (-[WebView _commonInitializationWithFrameName:groupName:]):
1995         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1996         (-[WebView _loadBackForwardListFromOtherView:]):
1997         (-[WebView initWithCoder:]):
1998         (-[WebView encodeWithCoder:]):
1999         (-[WebView backForwardList]):
2000         (-[WebView setMaintainsBackForwardList:]):
2001
2002 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2003
2004         Add support for prefers-color-scheme media query
2005         https://bugs.webkit.org/show_bug.cgi?id=190499
2006         rdar://problem/45212025
2007
2008         Reviewed by Dean Jackson.
2009
2010         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2011
2012 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2013
2014         Remove unused WebView._globalHistoryItem
2015         https://bugs.webkit.org/show_bug.cgi?id=190601
2016
2017         Reviewed by Chris Dumez.
2018
2019         * WebCoreSupport/WebFrameLoaderClient.h:
2020         * WebCoreSupport/WebFrameLoaderClient.mm:
2021         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2022         * WebView/WebView.mm:
2023         (-[WebView _globalHistoryItem]): Deleted.
2024         (-[WebView _setGlobalHistoryItem:]): Deleted.
2025         * WebView/WebViewData.h:
2026         * WebView/WebViewInternal.h:
2027         * WebView/WebViewPrivate.h:
2028
2029 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2030
2031         Remove unused parameters from FrameLoaderClient::createFrame
2032         https://bugs.webkit.org/show_bug.cgi?id=190587
2033
2034         Reviewed by Chris Dumez.
2035
2036         * WebCoreSupport/WebFrameLoaderClient.h:
2037         * WebCoreSupport/WebFrameLoaderClient.mm:
2038         (WebFrameLoaderClient::createFrame):
2039
2040 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2041
2042         Remove unused WebFrame._loadType
2043         https://bugs.webkit.org/show_bug.cgi?id=190583
2044
2045         Reviewed by Chris Dumez.
2046
2047         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2048
2049         * WebView/WebFrame.mm:
2050         (toWebFrameLoadType): Deleted.
2051         (-[WebFrame _loadType]): Deleted.
2052         * WebView/WebFramePrivate.h:
2053
2054 2018-10-15  Chris Dumez  <cdumez@apple.com>
2055
2056         Restrict browsing context lookup by name to frames that are related to one another
2057         https://bugs.webkit.org/show_bug.cgi?id=190475
2058
2059         Reviewed by Alex Christensen.
2060
2061         * WebView/WebFrame.mm:
2062         (-[WebFrame findFrameNamed:]):
2063
2064 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2065
2066         Remove InjectedBundle processing of back/forward lists
2067         https://bugs.webkit.org/show_bug.cgi?id=190459
2068
2069         Reviewed by Chris Dumez.
2070
2071         * WebCoreSupport/WebFrameLoaderClient.h:
2072         * WebCoreSupport/WebFrameLoaderClient.mm:
2073         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2074
2075 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2076
2077         [JSC] Remove Option::useAsyncIterator
2078         https://bugs.webkit.org/show_bug.cgi?id=190567
2079
2080         Reviewed by Saam Barati.
2081
2082         * Configurations/FeatureDefines.xcconfig:
2083
2084 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2085
2086         Allow encoding of small enum classes
2087         https://bugs.webkit.org/show_bug.cgi?id=190531
2088
2089         Reviewed by Tim Horton.
2090
2091         * WebCoreSupport/WebFrameLoaderClient.mm:
2092         (-[WebFramePolicyListener dealloc]):
2093
2094 2018-10-11  Keith Rollin  <krollin@apple.com>
2095
2096         CURRENT_ARCH should not be used in Run Script phase.
2097         https://bugs.webkit.org/show_bug.cgi?id=190407
2098         <rdar://problem/45133556>
2099
2100         Reviewed by Alexey Proskuryakov.
2101
2102         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2103         CURRENT_ARCH is not well-defined during this phase (and may even have
2104         the value "undefined") since this phase is run just once per build
2105         rather than once per supported architecture. Migrate away from
2106         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2107         performing an operation for each value, or by picking the first entry
2108         in ARCHS and using that as a representative value.
2109
2110         * Configurations/WebKitLegacy.xcconfig: When generating
2111         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2112         macosx platforms.
2113
2114         * MigrateHeaders.make:
2115         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2116         generate one for each architecture in ARCHS.
2117
2118 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2119
2120         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2121         https://bugs.webkit.org/show_bug.cgi?id=190429
2122
2123         Reviewed by Saam Barati.
2124
2125         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2126
2127         * WebView/WebPDFRepresentation.mm:
2128         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2129
2130 2018-10-08  Justin Fan  <justin_fan@apple.com>
2131
2132         WebGPU: Rename old WebGPU prototype to WebMetal
2133         https://bugs.webkit.org/show_bug.cgi?id=190325
2134         <rdar://problem/44990443>
2135
2136         Reviewed by Dean Jackson.
2137
2138         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2139
2140         * Configurations/FeatureDefines.xcconfig:
2141         * WebView/WebPreferenceKeysPrivate.h:
2142         * WebView/WebPreferences.mm:
2143         (+[WebPreferences initialize]):
2144         (-[WebPreferences webMetalEnabled]):
2145         (-[WebPreferences setWebMetalEnabled:]):
2146         (-[WebPreferences webGPUEnabled]): Deleted.
2147         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2148         * WebView/WebPreferencesPrivate.h:
2149         * WebView/WebView.mm:
2150         (-[WebView _preferencesChanged:]):
2151
2152 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2153
2154         Make <input type=color> a runtime enabled (on-by-default) feature
2155         https://bugs.webkit.org/show_bug.cgi?id=189162
2156
2157         Reviewed by Wenson Hsieh and Tim Horton.
2158
2159         * Configurations/FeatureDefines.xcconfig:
2160
2161 2018-10-07  Dan Bernstein  <mitz@apple.com>
2162
2163         Fixed building with the latest macOS SDK
2164
2165         * Plugins/WebNetscapePluginPackage.mm:
2166         (-[WebNetscapePluginPackage openResourceFile]):
2167         (-[WebNetscapePluginPackage closeResourceFile:]):
2168
2169 2018-10-04  Dan Bernstein  <mitz@apple.com>
2170
2171         More Carbon build-fixing.
2172
2173         * Carbon/CarbonWindowAdapter.mm:
2174         (-[CarbonWindowAdapter _destroyRealWindow:]):
2175         (-[CarbonWindowAdapter _growBoxRect]):
2176
2177 2018-10-04  Dan Bernstein  <mitz@apple.com>
2178
2179         Retried to fix 32-bit macOS builds after r236846.
2180
2181         * WebView/WebHTMLView.mm:
2182         (-[WebHTMLView setMarkedText:selectedRange:]):
2183
2184 2018-10-04  Dan Bernstein  <mitz@apple.com>
2185
2186         Retried to fix 32-bit macOS builds after r236846.
2187
2188         * Carbon/HIWebView.mm:
2189         (ActiveStateChanged):
2190
2191 2018-10-04  Dan Bernstein  <mitz@apple.com>
2192
2193         Tried to fix 32-bit macOS builds after r236846.
2194
2195         * Carbon/HIWebView.mm:
2196         (_NSSelectorForHICommand):
2197
2198 2018-10-04  Dan Bernstein  <mitz@apple.com>
2199
2200         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2201         https://bugs.webkit.org/show_bug.cgi?id=190250
2202
2203         Reviewed by Andy Estes.
2204
2205         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2206           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2207           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2208           an earlier line set it to YES.
2209
2210         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2211         changes below.
2212
2213         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2214           provides some missing method declarations.
2215
2216         * Misc/WebDownload.mm:
2217         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2218           a deprecated method.
2219
2220         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2221
2222         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2223           other code in the file uses a method from it.
2224
2225         * Plugins/WebBaseNetscapePluginView.mm:
2226         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2227           a deprecated method.
2228
2229         * Plugins/WebPluginController.mm:
2230         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2231           around use of a selector that may be present in some WebKit client.
2232
2233         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2234           method declarations.
2235
2236         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2237           from here.
2238
2239         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2240           missing method declarations.
2241
2242         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2243           from here.
2244
2245         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2246           call from here.
2247         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2248           an obsolete delegate method for binary compatibility.
2249         (pluginView): Ditto.
2250
2251         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2252           call from here.
2253
2254         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2255           WebDeviceOrientationProviderMock protocol.
2256
2257         * WebView/WebDeviceOrientationProviderMock.mm:
2258         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2259           main @implementation.
2260
2261         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2262           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2263
2264         * WebView/WebDynamicScrollBarsView.mm:
2265         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2266           of a deprecated method.
2267
2268         * WebView/WebHTMLView.mm:
2269         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2270           selector warning around action methods that are not declared anywhere in WebKit.
2271
2272         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2273           about implementing this deprecated method.
2274         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2275         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2276         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2277         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2278         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2279         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2280         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2281         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2282         (-[WebHTMLView doCommandBySelector:]): Ditto.
2283         (-[WebHTMLView insertText:]): Ditto.
2284
2285         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2286
2287         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2288
2289         * WebView/WebPDFView.h: Removed previewView ivar.
2290
2291         * WebView/WebPDFView.mm:
2292           Removed declaration of FileInternal category and merged its implementation with the main
2293           implementation.
2294         (-[WebPDFView dealloc]): Removed previewView ivar.
2295         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2296           exist in macOS versions we support.
2297         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2298         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2299           action methods internal to PDFKit.
2300         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2301         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2302
2303         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2304           call on macOS, even though in r86988 we started calling different methods on iOS.
2305
2306         * WebView/WebView.mm:
2307         - Imported headers that declare delegate methods that we call.
2308         - Removed declaration of WebFileInternal category and merged its implementation with the
2309           main implementation.
2310         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2311           category, which made them impossible to call from the main implementation. Moved those
2312           into the main implementation. One of those had to be declared in a class extension,
2313           because it is called from a method implemented in the WebPrivate category, and that
2314           category’s implementation appears first in the file.
2315
2316         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2317           around use of obsolete delegate method for binary compatibility.
2318
2319         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2320
2321 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2322
2323         Runtime flag and IDL for MediaRecorder
2324         https://bugs.webkit.org/show_bug.cgi?id=190018
2325
2326         Reviewed by Youenn Fablet and Chris Dumez.
2327
2328         * WebView/WebPreferenceKeysPrivate.h:
2329         * WebView/WebPreferences.mm:
2330         (+[WebPreferences initialize]):
2331         (-[WebPreferences mediaRecorderEnabled]):
2332         (-[WebPreferences setMediaRecorderEnabled:]):
2333         * WebView/WebPreferencesPrivate.h:
2334         * WebView/WebView.mm:
2335         (-[WebView _preferencesChanged:]):
2336
2337 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2338
2339         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2340         https://bugs.webkit.org/show_bug.cgi?id=190238
2341
2342         Reviewed by Antti Koivisto.
2343
2344         Enabled the feature by default.
2345
2346         * WebView/WebPreferences.mm:
2347         (+[WebPreferences initialize]):
2348
2349 2018-10-01  Dean Jackson  <dino@apple.com>
2350
2351         [macOS] Switching to discrete GPU should be done in the UI process
2352         https://bugs.webkit.org/show_bug.cgi?id=189361
2353         <rdar://problem/43949622>
2354
2355         Reviewed by Simon Fraser.
2356
2357         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2358         not support swapping to the discrete GPU in this configuration.
2359
2360         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2361         (WebKit::WebSwitchingGPUClient::singleton):
2362         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2363         * WebView/WebView.mm:
2364         (-[WebView _commonInitializationWithFrameName:groupName:]):
2365
2366 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2367
2368         Remove ParsedURLString
2369         https://bugs.webkit.org/show_bug.cgi?id=190154
2370
2371         Reviewed by Chris Dumez.
2372
2373         * WebView/WebScriptDebugger.mm:
2374         (toNSURL):
2375
2376 2018-10-01  Dean Jackson  <dino@apple.com>
2377
2378         Remove CSS Animation Triggers
2379         https://bugs.webkit.org/show_bug.cgi?id=190175
2380         <rdar://problem/44925626>
2381
2382         Reviewed by Simon Fraser.
2383
2384         * Configurations/FeatureDefines.xcconfig:
2385
2386 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2387
2388         Unreviewed, rolling out r236624 and r236671.
2389         https://bugs.webkit.org/show_bug.cgi?id=190207
2390
2391         The change in r236624 introduced crashes on the bots
2392         (Requested by ryanhaddad on #webkit).
2393
2394         Reverted changesets:
2395
2396         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2397         https://bugs.webkit.org/show_bug.cgi?id=188747
2398         https://trac.webkit.org/changeset/236624
2399
2400         "Unify implementation in VideoFullscreenInterfaceAVKit"
2401         https://bugs.webkit.org/show_bug.cgi?id=190091
2402         https://trac.webkit.org/changeset/236671
2403
2404 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2405
2406         URL should not use TextEncoding internally
2407         https://bugs.webkit.org/show_bug.cgi?id=190111
2408
2409         Reviewed by Andy Estes.
2410
2411         * Misc/WebNSURLExtras.mm:
2412
2413 2018-09-28  Jer Noble  <jer.noble@apple.com>
2414
2415         Refactoring: eliminate raw pointer usage in Fullscreen code
2416         https://bugs.webkit.org/show_bug.cgi?id=188747
2417         <rdar://problem/43541164>
2418
2419         Reviewed by Alex Christensen.
2420
2421         PlaybackSessionInterface no longer has an invalidate() method.
2422
2423         * WebView/WebView.mm:
2424         (-[WebView _clearPlaybackControlsManager]):
2425
2426 2018-09-28  Chris Dumez  <cdumez@apple.com>
2427
2428         Drop support for cross-origin-window-policy header
2429         https://bugs.webkit.org/show_bug.cgi?id=190081
2430
2431         Reviewed by Ryosuke Niwa.
2432
2433         * WebView/WebPreferenceKeysPrivate.h:
2434         * WebView/WebPreferences.mm:
2435         (+[WebPreferences initialize]):
2436         * WebView/WebPreferencesPrivate.h:
2437         * WebView/WebView.mm:
2438         (-[WebView _preferencesChanged:]):
2439
2440 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2441
2442         Rename createMarkup to serializePreservingVisualAppearance
2443         https://bugs.webkit.org/show_bug.cgi?id=190086
2444
2445         Reviewed by Wenson Hsieh.
2446
2447         * DOM/WebDOMOperations.mm:
2448         (-[DOMRange markupString]):
2449
2450 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2451
2452         Unreviewed, rolling out r236605.
2453         https://bugs.webkit.org/show_bug.cgi?id=190087
2454
2455         caused three API test timeouts (Requested by jernoble on
2456         #webkit).
2457
2458         Reverted changeset:
2459
2460         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2461         https://bugs.webkit.org/show_bug.cgi?id=188747
2462         https://trac.webkit.org/changeset/236605
2463
2464 2018-09-28  Jer Noble  <jer.noble@apple.com>
2465
2466         Refactoring: eliminate raw pointer usage in Fullscreen code
2467         https://bugs.webkit.org/show_bug.cgi?id=188747
2468         <rdar://problem/43541164>
2469
2470         Reviewed by Alex Christensen.
2471
2472         PlaybackSessionInterface no longer has an invalidate() method.
2473
2474         * WebView/WebView.mm:
2475         (-[WebView _clearPlaybackControlsManager]):
2476
2477 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2478
2479         Use enum class in createMarkup arguments
2480         https://bugs.webkit.org/show_bug.cgi?id=190028
2481
2482         Reviewed by Wenson Hsieh.
2483
2484         * DOM/WebDOMOperations.mm:
2485         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2486         (-[DOMRange markupString]): Ditto.
2487
2488 2018-09-27  Antoine Quint  <graouts@apple.com>
2489
2490         [Web Animations] Turn Web Animations with CSS integration on
2491         https://bugs.webkit.org/show_bug.cgi?id=184819
2492         <rdar://problem/39597337>
2493
2494         Reviewed by Dean Jackson.
2495
2496         * WebView/WebPreferences.mm:
2497         (+[WebPreferences initialize]):
2498
2499 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2500
2501         Selection should work across shadow boundary when initiated by a mouse drag
2502         https://bugs.webkit.org/show_bug.cgi?id=151380
2503         <rdar://problem/24363872>
2504
2505         Reviewed by Wenson Hsieh.
2506
2507         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2508
2509         * WebView/WebPreferenceKeysPrivate.h:
2510         * WebView/WebPreferences.mm:
2511         (+[WebPreferences initialize]):
2512         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2513         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2514         * WebView/WebPreferencesPrivate.h:
2515         * WebView/WebView.mm:
2516         (-[WebView _preferencesChanged:]):
2517
2518 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2519
2520         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2521         https://bugs.webkit.org/show_bug.cgi?id=189918
2522         Work towards <rdar://problem/44648705>
2523
2524         Reviewed by Tim Horton.
2525
2526         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2527
2528         * WebView/WebHTMLView.mm:
2529         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2530         (-[WebHTMLView _updateFontPanel]):
2531         * WebView/WebView.mm:
2532         (-[WebView typingAttributes]):
2533
2534 2018-09-17  Darin Adler  <darin@apple.com>
2535
2536         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2537         https://bugs.webkit.org/show_bug.cgi?id=189652
2538
2539         Reviewed by Saam Barati.
2540
2541         * WebView/WebPDFRepresentation.mm:
2542         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2543
2544 2018-09-14  Jer Noble  <jer.noble@apple.com>
2545
2546         Turn SourceBufferChangeTypeEnabled on by default
2547         https://bugs.webkit.org/show_bug.cgi?id=189527
2548
2549         Reviewed by Eric Carlson.
2550
2551         * WebView/WebPreferences.mm:
2552         (+[WebPreferences initialize]):
2553
2554 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2555
2556         Fix an internal build after r235935
2557         https://bugs.webkit.org/show_bug.cgi?id=188996
2558
2559         * Carbon/HIWebView.mm:
2560         (Draw):
2561         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2562
2563 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2564
2565         Add IGNORE_WARNING_.* macros
2566         https://bugs.webkit.org/show_bug.cgi?id=188996
2567
2568         Reviewed by Michael Catanzaro.
2569
2570         * Carbon/CarbonUtils.m:
2571         (PoolCleaner):
2572         * Carbon/CarbonWindowAdapter.mm:
2573         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2574         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2575         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2576         (-[CarbonWindowAdapter _termWindowIfOwner]):
2577         (-[CarbonWindowAdapter _windowMovedToRect:]):
2578         (-[CarbonWindowAdapter setContentView:]):
2579         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2580         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2581         * Carbon/CarbonWindowFrame.m:
2582         (-[CarbonWindowFrame title]):
2583         * Carbon/HIViewAdapter.m:
2584         (+[HIViewAdapter getHIViewForNSView:]):
2585         * Carbon/HIWebView.mm:
2586         (overrideCGContext):
2587         (restoreCGContext):
2588         (Draw):
2589         * DOM/DOM.mm:
2590         * History/WebHistory.mm:
2591         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2592         * History/WebHistoryItem.mm:
2593         (-[WebHistoryItem icon]):
2594         * Misc/WebKitNSStringExtras.mm:
2595         (-[NSString _web_drawAtPoint:font:textColor:]):
2596         * Misc/WebNSImageExtras.m:
2597         (-[NSImage _web_scaleToMaxSize:]):
2598         (-[NSImage _web_dissolveToFraction:]):
2599         * Misc/WebNSPasteboardExtras.mm:
2600         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
2601         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
2602         * Panels/WebAuthenticationPanel.m:
2603         (-[WebAuthenticationPanel loadNib]):
2604         * Plugins/Hosted/NetscapePluginHostManager.mm:
2605         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2606         (WebKit::NetscapePluginHostManager::didCreateWindow):
2607         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2608         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
2609         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
2610         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
2611         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2612         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
2613         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2614         (-[WebHostedNetscapePluginView drawRect:]):
2615         * Plugins/Hosted/WebTextInputWindowController.m:
2616         (-[WebTextInputPanel _interpretKeyEvent:string:]):
2617         * Plugins/WebBaseNetscapePluginView.mm:
2618         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
2619         * Plugins/WebNetscapePluginPackage.mm:
2620         (-[WebNetscapePluginPackage _tryLoad]):
2621         * Plugins/WebNetscapePluginView.mm:
2622         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2623         (-[WebNetscapePluginView sendDrawRectEvent:]):
2624         (-[WebNetscapePluginView drawRect:]):
2625         * Plugins/WebPluginController.mm:
2626         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
2627         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
2628         * WebCoreSupport/PopupMenuMac.mm:
2629         (PopupMenuMac::populate):
2630         * WebCoreSupport/WebAlternativeTextClient.h:
2631         * WebCoreSupport/WebDragClient.mm:
2632         (WebDragClient::startDrag):
2633         * WebCoreSupport/WebFrameLoaderClient.mm:
2634         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2635         (webGetNSImage):
2636         * WebInspector/WebNodeHighlight.mm:
2637         * WebInspector/WebNodeHighlightView.mm:
2638         (-[WebNodeHighlightView drawRect:]):
2639         * WebView/WebClipView.mm:
2640         (-[WebClipView initWithFrame:]):
2641         * WebView/WebFrame.mm:
2642         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2643         (-[WebFrame _drawRect:contentsOnly:]):
2644         (-[WebFrame accessibilityRoot]):
2645         * WebView/WebFullScreenController.mm:
2646         (-[WebFullScreenController enterFullScreen:]):
2647         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2648         (-[WebFullScreenController exitFullScreen]):
2649         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2650         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2651         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2652         * WebView/WebHTMLView.mm:
2653         (-[NSWindow _web_borderView]):
2654         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
2655         (-[WebHTMLView _setAsideSubviews]):
2656         (-[WebHTMLView _autoscroll]):
2657         (-[WebHTMLView drawRect:]):
2658         (-[WebHTMLView mouseDown:]):
2659         (-[WebHTMLView mouseDragged:]):
2660         (-[WebHTMLView mouseUp:]):
2661         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
2662         (-[WebHTMLView knowsPageRange:]):
2663         (-[WebHTMLView accessibilityHitTest:]):
2664         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
2665         (-[WebHTMLView _colorAsString:]):
2666         (-[WebHTMLView copyFont:]):
2667         (-[WebHTMLView _executeSavedKeypressCommands]):
2668         (-[WebHTMLView attachRootLayer:]):
2669         (-[WebHTMLView textStorage]):
2670         (-[WebHTMLView _updateSelectionForInputManager]):
2671         * WebView/WebPDFView.mm:
2672         (_applicationInfoForMIMEType):
2673         (-[WebPDFView centerSelectionInVisibleArea:]):
2674         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
2675         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
2676         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
2677         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
2678         * WebView/WebTextCompletionController.mm:
2679         (-[WebTextCompletionController _buildUI]):
2680         (-[WebTextCompletionController _placePopupWindow:]):
2681         * WebView/WebVideoFullscreenController.mm:
2682         * WebView/WebVideoFullscreenHUDWindowController.mm:
2683         (createMediaUIBackgroundView):
2684         * WebView/WebView.mm:
2685         (-[WebTextListTouchBarViewController initWithWebView:]):
2686         (-[WebView _dispatchTileDidDraw:]):
2687         (-[WebView encodeWithCoder:]):
2688         (-[WebView mainFrameIcon]):
2689         (LayerFlushController::flushLayers):
2690         * WebView/WebWindowAnimation.mm:
2691         (setScaledFrameForWindow):
2692
2693 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2694
2695         Remove unused needsDestruction class variables from HashTraits
2696         https://bugs.webkit.org/show_bug.cgi?id=189490
2697
2698         Reviewed by Daniel Bates.
2699
2700         * History/BinaryPropertyList.cpp: Removed needsDestruction.
2701
2702 2018-09-07  Frederic Wang  <fwang@igalia.com>
2703
2704         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
2705         https://bugs.webkit.org/show_bug.cgi?id=182230
2706
2707         Reviewed by Simon Fraser.
2708
2709         * DOM/DOMDocument.mm:
2710         (-[DOMDocument scrollingElement]): Use the new name.
2711
2712 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2713
2714         Refactor WebCore::EditAction to be an 8-bit enum class
2715         https://bugs.webkit.org/show_bug.cgi?id=189383
2716
2717         Reviewed by Dan Bernstein.
2718
2719         * WebCoreSupport/WebEditorClient.mm:
2720         (undoNameForEditAction):
2721         * WebView/WebHTMLView.mm:
2722         (-[WebHTMLView pasteFont:]):
2723         (-[WebHTMLView changeFont:]):
2724         (-[WebHTMLView changeAttributes:]):
2725         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
2726         (-[WebHTMLView changeColor:]):
2727         * WebView/WebView.mm:
2728         (-[WebView setTypingStyle:]):
2729
2730 2018-09-06  Frederic Wang  <fwang@igalia.com>
2731
2732         Group options of scrollRectToVisible into a struct
2733         https://bugs.webkit.org/show_bug.cgi?id=189352
2734
2735         Reviewed by Simon Fraser.
2736
2737         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
2738         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
2739         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
2740
2741 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2742
2743         [macOS] Cannot change font size at selection until font panel is shown
2744         https://bugs.webkit.org/show_bug.cgi?id=189295
2745         <rdar://problem/35593389>
2746
2747         Reviewed by Ryosuke Niwa.
2748
2749         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
2750         WebCore ChangeLog for more details.
2751
2752         * WebView/WebHTMLView.mm:
2753         (-[WebHTMLView changeFont:]):
2754         (-[WebHTMLView changeAttributes:]):
2755         (-[WebHTMLView _originalFontA]): Deleted.
2756         (-[WebHTMLView _originalFontB]): Deleted.
2757         (fontNameForDescription): Deleted.
2758         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
2759         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
2760         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
2761
2762 2018-09-05  Jer Noble  <jer.noble@apple.com>
2763
2764         Add MediaCapabilities as an Experimental Feature
2765         https://bugs.webkit.org/show_bug.cgi?id=189209
2766
2767         Reviewed by Eric Carlson.
2768
2769         RuntimeEnabledFeature -> Setting.
2770
2771         * WebView/WebView.mm:
2772         (-[WebView _preferencesChanged:]):
2773
2774 2018-09-04  Frederic Wang  <fwang@igalia.com>
2775
2776         Add basic support for ScrollIntoViewOptions
2777         https://bugs.webkit.org/show_bug.cgi?id=189258
2778
2779         Reviewed by Simon Fraser.
2780
2781         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
2782         header so that this file can build despite the new scrollIntoView function.
2783
2784 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2785
2786         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
2787         https://bugs.webkit.org/show_bug.cgi?id=188890
2788         <rdar://problem/43648605>
2789
2790         Reviewed by Tim Horton.
2791
2792         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
2793         more detail.
2794
2795         * WebCoreSupport/WebPlatformStrategies.h:
2796         * WebCoreSupport/WebPlatformStrategies.mm:
2797         (WebPlatformStrategies::allStringsForType):
2798
2799 2018-09-01  Darin Adler  <darin@apple.com>
2800
2801         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
2802         https://bugs.webkit.org/show_bug.cgi?id=189072
2803         Reviewed by Dan Bernstein.
2804
2805         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
2806         and declarations for NSURLDownload init methods.
2807
2808         * Misc/WebDownloadInternal.h: Removed.
2809
2810         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
2811         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
2812         "-Wdeprecated-declarations" because the method used here is deprecated.
2813
2814         * WebView/WebView.mm:
2815         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
2816         used here is deprecated.
2817
2818 2018-08-31  Chris Dumez  <cdumez@apple.com>
2819
2820         Assertion hit in ~CompletionHandler() from ~WebFrame()
2821         https://bugs.webkit.org/show_bug.cgi?id=189199
2822         <rdar://problem/42657233>
2823
2824         Reviewed by Youenn Fablet.
2825
2826         * WebCoreSupport/WebFrameLoaderClient.h:
2827         * WebCoreSupport/WebFrameLoaderClient.mm:
2828         (WebFrameLoaderClient::dispatchWillSubmitForm):
2829
2830 2018-08-31  Antti Koivisto  <antti@apple.com>
2831
2832         Replace OptionSet |= and -= operators with add() and remove() functions
2833         https://bugs.webkit.org/show_bug.cgi?id=189169
2834
2835         Reviewed by Anders Carlsson.
2836
2837         * WebView/WebFrame.mm:
2838         (-[WebFrame _drawRect:contentsOnly:]):
2839         * WebView/WebView.mm:
2840         (coreOptions):
2841
2842 2018-08-31  Frederic Wang  <fwang@igalia.com>
2843
2844         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
2845         https://bugs.webkit.org/show_bug.cgi?id=182053
2846
2847         Reviewed by Simon Fraser.
2848
2849         Add developer flag to use standard behavior for scrolling* attributes.
2850
2851         * WebView/WebPreferenceKeysPrivate.h:
2852         * WebView/WebPreferences.mm:
2853         (+[WebPreferences initialize]):
2854         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
2855         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
2856         * WebView/WebPreferencesPrivate.h:
2857         * WebView/WebView.mm:
2858         (-[WebView _preferencesChanged:]):
2859
2860 2018-08-29  Olivia Barnett  <obarnett@apple.com>
2861
2862         Implement the Web Share API
2863         https://bugs.webkit.org/show_bug.cgi?id=171100
2864         <rdar://problem/31751734>
2865
2866         Reviewed by Tim Horton.
2867
2868         * WebCoreSupport/WebChromeClient.h:
2869         * WebCoreSupport/WebChromeClient.mm:
2870         (WebChromeClient::showShareSheet):
2871         Empty declaration of showShareSheet.
2872
2873 2018-08-29  Youenn Fablet  <youenn@apple.com>
2874
2875         Remove WebRTC legacy API implementation
2876         https://bugs.webkit.org/show_bug.cgi?id=189040
2877
2878         Reviewed by Eric Carlson.
2879
2880         * WebView/WebPreferenceKeysPrivate.h:
2881         * WebView/WebPreferences.mm:
2882         (+[WebPreferences initialize]):
2883         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
2884         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
2885         * WebView/WebPreferencesPrivate.h:
2886         * WebView/WebView.mm:
2887         (-[WebView _preferencesChanged:]):
2888
2889 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2890
2891         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
2892         https://bugs.webkit.org/show_bug.cgi?id=189054
2893
2894         Reviewed by Andy Estes.
2895
2896         Remove the pasteboard type argument from readURLFromPasteboard.
2897
2898         * WebCoreSupport/WebPlatformStrategies.h:
2899         * WebCoreSupport/WebPlatformStrategies.mm:
2900         (WebPlatformStrategies::readURLFromPasteboard):
2901
2902 2018-08-27  Keith Rollin  <krollin@apple.com>
2903
2904         Unreviewed build fix -- disable LTO for production builds
2905
2906         * Configurations/Base.xcconfig:
2907
2908 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
2909
2910         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
2911         https://bugs.webkit.org/show_bug.cgi?id=188931
2912
2913         Reviewed by Wenson Hsieh.
2914
2915         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
2916
2917 2018-08-27  Keith Rollin  <krollin@apple.com>
2918
2919         Build system support for LTO
2920         https://bugs.webkit.org/show_bug.cgi?id=187785
2921         <rdar://problem/42353132>
2922
2923         Reviewed by Dan Bernstein.
2924
2925         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
2926         LTO.
2927
2928         * Configurations/Base.xcconfig:
2929         * Configurations/DebugRelease.xcconfig:
2930
2931 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
2932
2933         Pass in IsComposed flag to Event constructors
2934         https://bugs.webkit.org/show_bug.cgi?id=188720
2935         <rdar://problem/43580387>
2936
2937         Reviewed by Simon Fraser.
2938
2939         * WebView/WebPDFView.mm:
2940         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
2941         whether it's simulated or not.
2942
2943 2018-08-23  Mark Lam  <mark.lam@apple.com>
2944
2945         Move vmEntryGlobalObject() to VM from CallFrame.
2946         https://bugs.webkit.org/show_bug.cgi?id=188900
2947         <rdar://problem/43655753>
2948
2949         Reviewed by Michael Saboff.
2950
2951         * WebView/WebScriptDebugger.mm:
2952         (WebScriptDebugger::sourceParsed):
2953
2954 2018-08-23  Andy Estes  <aestes@apple.com>
2955
2956         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
2957         https://bugs.webkit.org/show_bug.cgi?id=188829
2958
2959         Reviewed by Tim Horton.
2960
2961         * Configurations/FeatureDefines.xcconfig:
2962
2963 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
2964
2965         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
2966         https://bugs.webkit.org/show_bug.cgi?id=188777
2967
2968         Reviewed by Simon Fraser.
2969
2970         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
2971         being "true" before the code change.
2972
2973         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
2974
2975         * WebView/WebPDFView.mm:
2976         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2977
2978 2018-08-21  Daniel Bates  <dabates@apple.com>
2979
2980         Replace TextCheckingTypeMask with OptionSet
2981         https://bugs.webkit.org/show_bug.cgi?id=188678
2982
2983         Reviewed by Antti Koivisto.
2984
2985         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
2986         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
2987         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
2988         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
2989
2990         * WebCoreSupport/WebEditorClient.h:
2991         * WebCoreSupport/WebEditorClient.mm:
2992         (WebEditorClient::checkTextOfParagraph):
2993         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
2994         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
2995         left as this is more readable and unncessary now that modern compilers like Clang have
2996         diagnostics to catch accidental assignments when equality was intended.
2997         (WebEditorClient::didCheckSucceed):
2998         * WebView/WebView.mm:
2999         (coreTextCheckingType):
3000         (textCheckingResultFromNSTextCheckingResult):
3001
3002 2018-08-21  Daniel Bates  <dabates@apple.com>
3003
3004         [iOS][WK1] Support toggling continuous spell checking from tests
3005         https://bugs.webkit.org/show_bug.cgi?id=188763
3006
3007         Reviewed by Simon Fraser.
3008
3009         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3010         spell checking from tests in iOS WebKit Legacy.
3011
3012         * WebCoreSupport/WebEditorClient.h:
3013         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3014         * WebCoreSupport/WebEditorClient.mm:
3015         * WebView/WebView.h:
3016         * WebView/WebView.mm:
3017         (-[WebView toggleContinuousSpellChecking:]):
3018         (-[WebView toggleSmartInsertDelete:]):
3019
3020 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3021
3022         Add some plumbing for safe browsing
3023         https://bugs.webkit.org/show_bug.cgi?id=188709
3024
3025         Reviewed by Tim Horton.
3026
3027         * WebCoreSupport/WebFrameLoaderClient.h:
3028         * WebCoreSupport/WebFrameLoaderClient.mm:
3029         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3030
3031 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3032
3033         Replace canBubble and cancelable booleans in Event by enum classes
3034         https://bugs.webkit.org/show_bug.cgi?id=188692
3035
3036         Reviewed by Alex Christensen.
3037
3038         * WebView/WebPDFView.mm:
3039         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3040         * WebView/WebView.mm:
3041         (-[WebView _dispatchUnloadEvent]):
3042
3043 2018-08-16  Jer Noble  <jer.noble@apple.com>
3044
3045         Add Experimental Feature support for SourceBuffer.changeType()
3046         https://bugs.webkit.org/show_bug.cgi?id=188626
3047         <rdar://problem/43356021>
3048
3049         Reviewed by Eric Carlson.
3050
3051         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3052
3053         * WebView/WebPreferenceKeysPrivate.h:
3054         * WebView/WebPreferences.mm:
3055         (+[WebPreferences initialize]):
3056         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3057         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3058         * WebView/WebPreferencesPrivate.h:
3059         * WebView/WebView.mm:
3060         (-[WebView _preferencesChanged:]):
3061
3062 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3063
3064         Support drag-and-drop for input[type=color]
3065         https://bugs.webkit.org/show_bug.cgi?id=188464
3066
3067         Reviewed by Wenson Hsieh.
3068
3069         * WebCoreSupport/WebPlatformStrategies.h:
3070         * WebCoreSupport/WebPlatformStrategies.mm:
3071         (WebPlatformStrategies::setColor):
3072
3073 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3074
3075         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3076         https://bugs.webkit.org/show_bug.cgi?id=188569
3077         <rdar://problem/34201095>
3078
3079         Reviewed by Megan Gardner.
3080
3081         * WebView/WebImmediateActionController.mm:
3082         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3083         Speculative fix; the crashes indicate font is null, but we just checked it,
3084         so it must be getting made null by convertFont:toSize:. Check again!
3085
3086 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3087
3088         Use a 1-byte enum class for TextDirection
3089         https://bugs.webkit.org/show_bug.cgi?id=188350
3090
3091         Reviewed by Simon Fraser.
3092
3093         * WebCoreSupport/PopupMenuMac.mm:
3094         (PopupMenuMac::populate):
3095         (PopupMenuMac::show):
3096         * WebCoreSupport/WebFrameLoaderClient.mm:
3097         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3098         * WebView/WebFrame.mm:
3099         (-[WebFrame _dispatchDidReceiveTitle:]):
3100
3101 2018-08-09  Ali Juma  <ajuma@chromium.org>
3102
3103         Import WPTs for IntersectionObserver
3104         https://bugs.webkit.org/show_bug.cgi?id=188416
3105
3106         Reviewed by Simon Fraser.
3107
3108         * WebView/WebPreferencesPrivate.h:
3109
3110 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3111
3112         Follow-up build fix for r234685
3113         https://bugs.webkit.org/show_bug.cgi?id=188245
3114
3115         Unreviewed build fix.
3116
3117         * WebCoreSupport/WebSecurityOriginPrivate.h:
3118
3119 2018-08-05  Darin Adler  <darin@apple.com>
3120
3121         [Cocoa] More tweaks and refactoring to prepare for ARC
3122         https://bugs.webkit.org/show_bug.cgi?id=188245
3123
3124         Reviewed by Dan Bernstein.
3125
3126         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3127
3128         * Carbon/CarbonWindowFrame.m:
3129         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3130
3131         * DOM/DOM.mm:
3132         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3133         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3134         garbage collection so this method isn't useful.
3135
3136         * DOM/DOMXPath.mm:
3137         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3138         Objective-C garbage collection so this method isn't useful.
3139
3140         * History/WebHistory.mm:
3141         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3142
3143         * Misc/WebElementDictionary.mm:
3144         (addLookupKey): Use a bridging cast.
3145         (cacheValueForKey): Ditto.
3146         (-[WebElementDictionary _fillCache]): Ditto.
3147         (-[WebElementDictionary objectForKey:]): Ditto.
3148
3149         * Misc/WebKitNSStringExtras.mm:
3150         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3151         (-[NSString _web_widthWithFont:]): Ditto.
3152         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3153
3154         * Misc/WebLocalizableStrings.mm:
3155         (WebLocalizedString): Use a bridging cast.
3156
3157         * Misc/WebNSDataExtras.mm:
3158         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3159         and use CFBridgingRelease instead of calling autorelease directly.
3160         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3161         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3162         on the amount of explicit release and autorelease.
3163
3164         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3165         * Misc/WebNSDictionaryExtras.m:
3166         (-[NSDictionary _webkit_intForKey:]): Deleted.
3167         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3168         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3169         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3170         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3171         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3172         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3173
3174         * Misc/WebStringTruncator.mm:
3175         (fontFromNSFont): Use a bridging cast.
3176
3177         * Plugins/Hosted/NetscapePluginHostManager.mm:
3178         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3179
3180         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3181         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3182         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3183         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3184         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3185         * Plugins/Hosted/ProxyInstance.mm:
3186         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3187         * Plugins/WebBasePluginPackage.mm:
3188         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3189         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3190         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3191         * Plugins/WebNetscapePluginPackage.mm:
3192         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3193
3194         * Plugins/WebNetscapePluginView.mm:
3195         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3196         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3197         (-[WebNetscapePluginView status:]): Use a bridging cast.
3198         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3199
3200         * Plugins/WebPluginController.mm:
3201         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3202
3203         * Plugins/WebPluginDatabase.mm:
3204         (checkCandidate): Use explicit __strong for out argument types.
3205
3206         * Plugins/npapi.mm:
3207         (pluginViewForInstance): Use a bridging cast.
3208
3209         * Storage/WebDatabaseManager.mm:
3210         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3211         explicit NSNumber and NSDictionary calls.
3212
3213         * WebCoreSupport/WebContextMenuClient.mm:
3214         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3215
3216         * WebCoreSupport/WebEditorClient.mm:
3217         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3218         (WebEditorClient::handleInputMethodKeydown): Ditto.
3219
3220         * WebCoreSupport/WebFrameNetworkingContext.mm:
3221         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3222
3223         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3224         as a struct rather than an Objective-C class, since that's how it's defined.
3225
3226         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3227
3228         * WebView/WebFullScreenController.mm:
3229         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3230         * WebView/WebHTMLView.mm:
3231         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3232         Ditto.
3233         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3234
3235         * WebView/WebImmediateActionController.mm:
3236         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3237         go down to the document and then back to the frame.
3238         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3239         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3240         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3241
3242         * WebView/WebJSPDFDoc.mm:
3243         (jsPDFDocInitialize): Removed some unneeded type casting.
3244         (jsPDFDocFinalize): Ditto.
3245         (jsPDFDocPrint): Use a bridging cast.
3246
3247         * WebView/WebPDFView.mm:
3248         (_applicationInfoForMIMEType): Use bridging casts.
3249
3250         * WebView/WebPreferences.mm:
3251         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3252         instead of methods from WebNSDictionaryExtras.
3253         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3254         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3255         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3256         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3257         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3258
3259         * WebView/WebView.mm:
3260         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3261         (-[WebView _addToAllWebViewsSet]): Ditto.
3262         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3263         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3264         so it can be called from WebViewData methods.
3265
3266         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3267         method, _windowVisibilityChanged:.
3268
3269         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3270         called from WebViewData methods.
3271
3272 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3273
3274         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3275         https://bugs.webkit.org/show_bug.cgi?id=188323
3276
3277         Reviewed by Simon Fraser.
3278
3279         * WebCoreSupport/WebContextMenuClient.mm:
3280         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3281         * WebView/WebFrame.mm:
3282         (-[WebFrame _paintBehaviorForDestinationContext:]):
3283         (-[WebFrame _drawRect:contentsOnly:]):
3284         * WebView/WebHTMLView.mm:
3285         (imageFromRect):
3286         (selectionImage):
3287
3288 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3289
3290         Add support for microtasks in workers
3291         https://bugs.webkit.org/show_bug.cgi?id=188246
3292
3293         Reviewed by Darin Adler.
3294
3295         Rename JSMainThreadExecState.h to JSExecState.h.
3296
3297         * DOM/DOMAttr.mm:
3298         * DOM/DOMBlob.mm:
3299         * DOM/DOMCDATASection.mm:
3300         * DOM/DOMCSSCharsetRule.mm:
3301         * DOM/DOMCSSFontFaceRule.mm:
3302         * DOM/DOMCSSImportRule.mm:
3303         * DOM/DOMCSSMediaRule.mm:
3304         * DOM/DOMCSSPageRule.mm:
3305         * DOM/DOMCSSPrimitiveValue.mm:
3306         * DOM/DOMCSSRule.mm:
3307         * DOM/DOMCSSRuleList.mm:
3308         * DOM/DOMCSSStyleDeclaration.mm:
3309         * DOM/DOMCSSStyleRule.mm:
3310         * DOM/DOMCSSStyleSheet.mm:
3311         * DOM/DOMCSSUnknownRule.mm:
3312         * DOM/DOMCSSValue.mm:
3313         * DOM/DOMCSSValueList.mm:
3314         * DOM/DOMCharacterData.mm:
3315         * DOM/DOMComment.mm:
3316         * DOM/DOMCounter.mm:
3317         * DOM/DOMDocument.mm:
3318         * DOM/DOMDocumentFragment.mm:
3319         * DOM/DOMDocumentType.mm:
3320         * DOM/DOMElement.mm:
3321         * DOM/DOMEvent.mm:
3322         * DOM/DOMFile.mm:
3323         * DOM/DOMFileList.mm:
3324         * DOM/DOMHTML.mm:
3325         * DOM/DOMHTMLAnchorElement.mm:
3326         * DOM/DOMHTMLAppletElement.mm:
3327         * DOM/DOMHTMLAreaElement.mm:
3328         * DOM/DOMHTMLBRElement.mm:
3329         * DOM/DOMHTMLBaseElement.mm:
3330         * DOM/DOMHTMLBaseFontElement.mm:
3331         * DOM/DOMHTMLBodyElement.mm:
3332         * DOM/DOMHTMLButtonElement.mm:
3333         * DOM/DOMHTMLCanvasElement.mm:
3334         * DOM/DOMHTMLCollection.mm:
3335         * DOM/DOMHTMLDListElement.mm:
3336         * DOM/DOMHTMLDirectoryElement.mm:
3337         * DOM/DOMHTMLDivElement.mm:
3338         * DOM/DOMHTMLDocument.mm:
3339         * DOM/DOMHTMLElement.mm:
3340         * DOM/DOMHTMLEmbedElement.mm:
3341         * DOM/DOMHTMLFieldSetElement.mm:
3342         * DOM/DOMHTMLFontElement.mm:
3343         * DOM/DOMHTMLFormElement.mm:
3344         * DOM/DOMHTMLFrameElement.mm:
3345         * DOM/DOMHTMLFrameSetElement.mm:
3346         * DOM/DOMHTMLHRElement.mm:
3347         * DOM/DOMHTMLHeadElement.mm:
3348         * DOM/DOMHTMLHeadingElement.mm:
3349         * DOM/DOMHTMLHtmlElement.mm:
3350         * DOM/DOMHTMLIFrameElement.mm:
3351         * DOM/DOMHTMLImageElement.mm:
3352         * DOM/DOMHTMLInputElement.mm:
3353         * DOM/DOMHTMLLIElement.mm:
3354         * DOM/DOMHTMLLabelElement.mm:
3355         * DOM/DOMHTMLLegendElement.mm:
3356         * DOM/DOMHTMLLinkElement.mm:
3357         * DOM/DOMHTMLMapElement.mm:
3358         * DOM/DOMHTMLMarqueeElement.mm:
3359         * DOM/DOMHTMLMediaElement.mm:
3360         * DOM/DOMHTMLMenuElement.mm:
3361         * DOM/DOMHTMLMetaElement.mm:
3362         * DOM/DOMHTMLModElement.mm:
3363         * DOM/DOMHTMLOListElement.mm:
3364         * DOM/DOMHTMLObjectElement.mm:
3365         * DOM/DOMHTMLOptGroupElement.mm:
3366         * DOM/DOMHTMLOptionElement.mm:
3367         * DOM/DOMHTMLOptionsCollection.mm:
3368         * DOM/DOMHTMLParagraphElement.mm:
3369         * DOM/DOMHTMLParamElement.mm:
3370         * DOM/DOMHTMLPreElement.mm:
3371         * DOM/DOMHTMLQuoteElement.mm:
3372         * DOM/DOMHTMLScriptElement.mm:
3373         * DOM/DOMHTMLSelectElement.mm:
3374         * DOM/DOMHTMLStyleElement.mm:
3375         * DOM/DOMHTMLTableCaptionElement.mm:
3376         * DOM/DOMHTMLTableCellElement.mm:
3377         * DOM/DOMHTMLTableColElement.mm:
3378         * DOM/DOMHTMLTableElement.mm:
3379         * DOM/DOMHTMLTableRowElement.mm:
3380         * DOM/DOMHTMLTableSectionElement.mm:
3381         * DOM/DOMHTMLTextAreaElement.mm:
3382         * DOM/DOMHTMLTitleElement.mm:
3383         * DOM/DOMHTMLUListElement.mm:
3384         * DOM/DOMHTMLVideoElement.mm:
3385         * DOM/DOMImplementation.mm:
3386         * DOM/DOMKeyboardEvent.mm:
3387         * DOM/DOMMediaError.mm:
3388         * DOM/DOMMediaList.mm:
3389         * DOM/DOMMouseEvent.mm:
3390         * DOM/DOMMutationEvent.mm:
3391         * DOM/DOMNamedNodeMap.mm:
3392         * DOM/DOMNode.mm:
3393         * DOM/DOMNodeIterator.mm:
3394         * DOM/DOMNodeList.mm:
3395         * DOM/DOMOverflowEvent.mm:
3396         * DOM/DOMProcessingInstruction.mm:
3397         * DOM/DOMProgressEvent.mm:
3398         * DOM/DOMRGBColor.mm:
3399         * DOM/DOMRange.mm:
3400         * DOM/DOMRect.mm:
3401         * DOM/DOMStyleSheet.mm:
3402         * DOM/DOMStyleSheetList.mm:
3403         * DOM/DOMText.mm:
3404         * DOM/DOMTextEvent.mm:
3405         * DOM/DOMTimeRanges.mm:
3406         * DOM/DOMTokenList.mm:
3407         * DOM/DOMTreeWalker.mm:
3408         * DOM/DOMUIEvent.mm:
3409         * DOM/DOMWheelEvent.mm:
3410         * DOM/DOMXPathExpression.mm:
3411         * DOM/DOMXPathResult.mm:
3412         * DOM/ObjCEventListener.mm:
3413
3414 2018-08-03  Alex Christensen  <achristensen@webkit.org>
3415
3416         Fix spelling of "overridden"
3417         https://bugs.webkit.org/show_bug.cgi?id=188315
3418
3419         Reviewed by Darin Adler.
3420
3421         * Misc/WebKitVersionChecks.mm:
3422         (setWebKitLinkTimeVersion):
3423         (WebKitLinkTimeVersion):
3424         * Plugins/WebBaseNetscapePluginView.mm:
3425         (-[WebBaseNetscapePluginView handleMouseMoved:]):
3426         * WebCoreSupport/PopupMenuMac.mm:
3427         (PopupMenuMac::populate):
3428
3429 2018-08-01  Nan Wang  <n_wang@apple.com>
3430
3431         AX: AOM: Add ARIA IDL Attribute Reflection
3432         https://bugs.webkit.org/show_bug.cgi?id=184676
3433         <rdar://problem/39476882>
3434
3435         Reviewed by Chris Fleizach.
3436
3437         * WebView/WebPreferenceKeysPrivate.h:
3438         * WebView/WebPreferences.mm:
3439         (+[WebPreferences initialize]):
3440         (-[WebPreferences ariaReflectionEnabled]):
3441         (-[WebPreferences setAriaReflectionEnabled:]):
3442         * WebView/WebPreferencesPrivate.h:
3443         * WebView/WebView.mm:
3444         (-[WebView _preferencesChanged:]):
3445
3446 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
3447
3448         Shrink GraphicsLayerCA
3449         https://bugs.webkit.org/show_bug.cgi?id=188141
3450
3451         Reviewed by Zalan Bujtas.
3452
3453         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
3454         * moving all the clone-related stuff into the lazily-allocated m_layerClones
3455         * moving all the animation-related stuff into the lazily-allocated m_animations
3456         * making enums be 8-bit
3457         * re-ordering data members
3458
3459         * WebView/WebView.mm:
3460         (-[WebView _setMediaLayer:forPluginView:]):
3461
3462 2018-07-30  Rob Buis  <rbuis@igalia.com>
3463
3464         Merge PlatformCookieJar functions into NetworkStorageSession
3465         https://bugs.webkit.org/show_bug.cgi?id=188137
3466
3467         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
3468
3469         Reviewed by Alex Christensen.
3470
3471         * WebCoreSupport/WebPlatformStrategies.mm:
3472         (WebPlatformStrategies::cookiesForDOM):
3473         (WebPlatformStrategies::setCookiesFromDOM):
3474         (WebPlatformStrategies::cookiesEnabled):
3475         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3476         (WebPlatformStrategies::getRawCookies):
3477         (WebPlatformStrategies::deleteCookie):
3478         * WebView/WebPreferences.mm:
3479         (+[WebPreferences _clearNetworkLoaderSession]):
3480
3481 2018-07-28  Darin Adler  <darin@apple.com>
3482
3483         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
3484         https://bugs.webkit.org/show_bug.cgi?id=188140
3485
3486         Reviewed by Sam Weinig.
3487
3488         * WebView/WebImmediateActionController.mm:
3489         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
3490         new DictionaryLookup function that returns a tuple instead of using an out argument.
3491
3492 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
3493
3494         [INTL] Remove INTL sub-feature compile flags
3495         https://bugs.webkit.org/show_bug.cgi?id=188081
3496
3497         Reviewed by Michael Catanzaro.
3498
3499         * Configurations/FeatureDefines.xcconfig:
3500
3501 2018-07-26  Commit Queue  <commit-queue@webkit.org>
3502
3503         Unreviewed, rolling out r234181 and r234189.
3504         https://bugs.webkit.org/show_bug.cgi?id=188075
3505
3506         These are not needed right now (Requested by thorton on
3507         #webkit).
3508
3509         Reverted changesets:
3510
3511         "Enable Web Content Filtering on watchOS"
3512         https://bugs.webkit.org/show_bug.cgi?id=187979
3513         https://trac.webkit.org/changeset/234181
3514
3515         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
3516         https://bugs.webkit.org/show_bug.cgi?id=187985
3517         https://trac.webkit.org/changeset/234189
3518
3519 2018-07-26  Timothy Hatcher  <timothy@apple.com>
3520
3521         Use the Page's appearance when converting pasteboard attributed strings.
3522         https://bugs.webkit.org/show_bug.cgi?id=188067
3523         rdar://problem/42632246
3524
3525         Reviewed by Wenson Hsieh.
3526
3527         * WebCoreSupport/WebEditorClient.mm:
3528         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
3529
3530 2018-07-25  Chris Dumez  <cdumez@apple.com>
3531
3532         navigator.userAgent may return outdated value after webView.customUserAgent is set
3533         https://bugs.webkit.org/show_bug.cgi?id=188009
3534         <rdar://problem/42566456>
3535
3536         Reviewed by Alex Christensen.
3537
3538         Let the page know when the user agent changes.
3539
3540         * WebView/WebView.mm:
3541         (-[WebView _preferencesChanged:]):
3542         (-[WebView setApplicationNameForUserAgent:]):
3543         (-[WebView _invalidateUserAgentCache]):
3544         (-[WebView setCustomUserAgent:]):
3545         * WebView/WebViewInternal.h:
3546
3547 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3548
3549         Enable Web Content Filtering on watchOS
3550         https://bugs.webkit.org/show_bug.cgi?id=187979
3551         <rdar://problem/42559346>
3552
3553         Reviewed by Wenson Hsieh.
3554
3555         * Configurations/FeatureDefines.xcconfig:
3556
3557 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3558
3559         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3560         https://bugs.webkit.org/show_bug.cgi?id=187846
3561
3562         Reviewed by Simon Fraser.
3563
3564         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
3565
3566         * WebView/WebHTMLView.mm:
3567         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
3568         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
3569
3570 2018-07-11  Dean Jackson  <dino@apple.com>
3571
3572         Allow removal of white backgrounds
3573         https://bugs.webkit.org/show_bug.cgi?id=187574
3574         <rdar://problem/41146792>
3575
3576         Reviewed by Simon Fraser.
3577
3578         Add a new WebPreference for punching out white backgrounds.
3579
3580         * WebView/WebPreferenceKeysPrivate.h:
3581         * WebView/WebPreferences.mm:
3582         (+[WebPreferences initialize]):
3583         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
3584         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
3585         * WebView/WebPreferencesPrivate.h:
3586         * WebView/WebView.mm:
3587         (-[WebView _preferencesChanged:]):
3588
3589 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
3590
3591         Ensure WebKit stack is ad-hoc signed
3592         https://bugs.webkit.org/show_bug.cgi?id=187667
3593
3594         Reviewed by Alexey Proskuryakov.
3595
3596         * Configurations/Base.xcconfig:
3597
3598 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
3599
3600         REGRESSION (231276): Attempting to copy an image fails
3601         https://bugs.webkit.org/show_bug.cgi?id=187212
3602         <rdar://problem/41540074>
3603
3604         Reviewed by Ryosuke Niwa.
3605
3606         Renamed methods to make it clear that one URL and one title are being passed in.
3607
3608         * WebCoreSupport/WebPlatformStrategies.h:
3609         * WebCoreSupport/WebPlatformStrategies.mm:
3610         (WebPlatformStrategies::setURL):
3611
3612 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
3613
3614         Disable cross-origin-window-policy by default
3615         https://bugs.webkit.org/show_bug.cgi?id=187509
3616
3617         Reviewed by Chris Dumez.
3618
3619         * WebView/WebPreferences.mm:
3620         (+[WebPreferences initialize]):
3621
3622 2018-07-09  Timothy Hatcher  <timothy@apple.com>
3623
3624         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3625         https://bugs.webkit.org/show_bug.cgi?id=187425
3626         rdar://problem/39948240
3627
3628         Reviewed by Tim Horton.
3629
3630         * WebView/WebView.mm:
3631         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3632         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3633         a call in this method to setUseDarkAppearance.
3634         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3635         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3636         (-[WebView _updateDefaultAppearance]): Deleted.
3637         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3638
3639 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
3640
3641         Shrink various loading-related enums to shrink CachedResource
3642         https://bugs.webkit.org/show_bug.cgi?id=187443
3643
3644         Reviewed by Chris Dumez.
3645
3646         * WebCoreSupport/WebFrameLoaderClient.mm:
3647         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3648         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
3649         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
3650         (WebFrameLoaderClient::dispatchWillSendRequest):
3651         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3652         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3653         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3654         (WebFrameLoaderClient::updateGlobalHistory):
3655         (WebFrameLoaderClient::canHandleRequest const):
3656         * WebView/WebDataSource.mm:
3657         (-[WebDataSource initialRequest]):
3658         (-[WebDataSource request]):
3659
3660 2018-07-09  Commit Queue  <commit-queue@webkit.org>
3661
3662         Unreviewed, rolling out r233612.
3663         https://bugs.webkit.org/show_bug.cgi?id=187475
3664
3665         Revision caused the api test LinkColorWithSystemAppearance to
3666         fail on all systems. (Requested by Truitt on #webkit).
3667
3668         Reverted changeset:
3669
3670         "Semantic colors don't update when accessibility Increase
3671         Contrast mode is enabled."
3672         https://bugs.webkit.org/show_bug.cgi?id=187425
3673         https://trac.webkit.org/changeset/233612
3674
3675 2018-07-06  Timothy Hatcher  <timothy@apple.com>
3676
3677         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
3678         https://bugs.webkit.org/show_bug.cgi?id=187425
3679         rdar://problem/39948240
3680
3681         Reviewed by Tim Horton.
3682
3683         * WebView/WebView.mm:
3684         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
3685         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
3686         a call in this method to setUseDarkAppearance.
3687         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
3688         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
3689         (-[WebView _updateDefaultAppearance]): Deleted.
3690         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
3691
3692 2018-07-05  Timothy Hatcher  <timothy@apple.com>
3693
3694         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
3695         https://bugs.webkit.org/show_bug.cgi?id=187369
3696         rdar://problem/41870420
3697
3698         Reviewed by Tim Horton.
3699
3700         * WebView/WebMediaPlaybackTargetPicker.mm:
3701         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
3702         * WebView/WebView.mm:
3703         (-[WebView _commonInitializationWithFrameName:groupName:]):
3704         (-[WebView _effectiveAppearanceIsDark]):
3705         (-[WebView _updateDefaultAppearance]):
3706         (-[WebView _defaultAppearance]): Deleted.
3707
3708 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
3709
3710         Youtube video pages crash after a couple of minutes
3711         https://bugs.webkit.org/show_bug.cgi?id=187316
3712
3713         Reviewed by Antti Koivisto.
3714
3715         * WebView/WebView.mm:
3716         (-[WebView _preferencesChanged:]):
3717
3718 2018-07-04  Tim Horton  <timothy_horton@apple.com>
3719
3720         Introduce PLATFORM(IOSMAC)
3721         https://bugs.webkit.org/show_bug.cgi?id=187315
3722
3723         Reviewed by Dan Bernstein.
3724
3725         * Configurations/Base.xcconfig:
3726         * Configurations/FeatureDefines.xcconfig:
3727
3728 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3729
3730         [iOS] DataTransfer.getData always returns the empty string when dropping text
3731         https://bugs.webkit.org/show_bug.cgi?id=187130
3732         <rdar://problem/41014117>
3733
3734         Reviewed by Ryosuke Niwa.
3735
3736         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
3737
3738         * WebCoreSupport/WebPlatformStrategies.h:
3739         * WebCoreSupport/WebPlatformStrategies.mm:
3740         (WebPlatformStrategies::allPasteboardItemInfo):
3741
3742 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
3743
3744         [Mac] AirPlay picker uses incorrect theme in Dark mode
3745         https://bugs.webkit.org/show_bug.cgi?id=187054
3746         <rdar://problem/41291093>
3747
3748         Reviewed by Timothy Hatcher.
3749
3750         * WebView/WebMediaPlaybackTargetPicker.mm:
3751         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
3752
3753 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
3754
3755         [WTF] Add user-defined literal for ASCIILiteral
3756         https://bugs.webkit.org/show_bug.cgi?id=186839
3757
3758         Reviewed by Darin Adler.
3759
3760         * DOM/ExceptionHandlers.mm:
3761         (raiseDOMErrorException):
3762         * Plugins/Hosted/ProxyInstance.mm:
3763         (WebKit::ProxyInstance::invokeMethod):
3764         * Storage/WebDatabaseProvider.mm:
3765         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
3766
3767 2018-06-22  Timothy Hatcher  <timothy@apple.com>
3768
3769         Recalc styles every time defaultAppearance changes.
3770         https://bugs.webkit.org/show_bug.cgi?id=186866
3771         rdar://problem/41309805
3772
3773         Reviewed by Tim Horton.
3774
3775         * WebView/WebView.mm:
3776         (-[WebView _updateDefaultAppearance]):
3777         (-[WebView _setUseSystemAppearance:]):
3778         (-[WebView _useSystemAppearance]):
3779
3780 2018-06-20  Darin Adler  <darin@apple.com>
3781
3782         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
3783         https://bugs.webkit.org/show_bug.cgi?id=186875
3784
3785         Reviewed by Anders Carlsson.
3786
3787         * WebView/WebHTMLView.mm:
3788         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
3789         to write te file to.
3790         * WebView/WebPreferences.mm:
3791         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
3792         * WebView/WebView.mm:
3793         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
3794
3795 2018-06-12  Darin Adler  <darin@apple.com>
3796
3797         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
3798         https://bugs.webkit.org/show_bug.cgi?id=186526
3799
3800         Reviewed by Anders Carlsson.
3801
3802         * Plugins/Hosted/NetscapePluginHostManager.mm:
3803         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
3804
3805         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3806         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
3807         assignment rather than adoptNS/leakRef.
3808         * Plugins/WebNetscapePluginView.mm:
3809         (-[WebNetscapePluginView createPlugin]): Ditto.
3810
3811         * WebCoreSupport/WebContextMenuClient.mm:
3812         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
3813         RetainPtr::autorelease; no need to autorelease just to pass something as a function
3814         argument, so use RetainPtr::get instead.
3815
3816         * WebView/WebHTMLView.mm:
3817         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
3818         No need to autorelease the result when the return type is RetainPtr.
3819
3820         * WebView/WebPDFRepresentation.mm:
3821         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
3822
3823 2018-06-13  Youenn Fablet  <youenn@apple.com>
3824
3825         Supported plugin check should be based on plugin identifier
3826         https://bugs.webkit.org/show_bug.cgi?id=186578
3827         <rdar://problem/40523828>
3828
3829         Reviewed by Darin Adler.
3830
3831         * WebCoreSupport/WebPluginInfoProvider.h:
3832         * WebCoreSupport/WebPluginInfoProvider.mm:
3833         (WebPluginInfoProvider::pluginInfo):
3834         (WebPluginInfoProvider::webVisiblePluginInfo):
3835
3836 2018-06-13  Chris Dumez  <cdumez@apple.com>
3837
3838         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
3839         https://bugs.webkit.org/show_bug.cgi?id=186545
3840
3841         Reviewed by Brady Eidson.
3842
3843         Update client delegate now that parameter type has changed.
3844
3845         * WebCoreSupport/WebFrameLoaderClient.h:
3846         * WebCoreSupport/WebFrameLoaderClient.mm:
3847         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3848
3849 2018-06-11  Tim Horton  <timothy_horton@apple.com>
3850
3851         Link drag image is inconsistently unreadable in dark mode
3852         https://bugs.webkit.org/show_bug.cgi?id=186472
3853
3854         Reviewed by Timothy Hatcher.
3855
3856         * WebView/WebView.mm:
3857         (-[WebView _defaultAppearance]):
3858         Make defaultAppearance accurate even if useSystemAppearance is false.
3859         Some parts of WebKit (like the link drag image, but also context menus)
3860         want to be able to follow the system appearance regardless of whether
3861         the view or content has opted in.
3862
3863 2018-06-11  Chris Dumez  <cdumez@apple.com>
3864
3865         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
3866         https://bugs.webkit.org/show_bug.cgi?id=186441
3867
3868         Reviewed by Brady Eidson.
3869
3870         Rename existing flag to something a bit more generic, now that it is used for
3871         more things than bypassing the navigation policy check.
3872
3873         * WebView/WebView.mm:
3874         (-[WebView _loadBackForwardListFromOtherView:]):
3875         (-[WebView goToBackForwardItem:]):
3876
3877 2018-06-09  Dan Bernstein  <mitz@apple.com>
3878
3879         [Xcode] Clean up and modernize some build setting definitions
3880         https://bugs.webkit.org/show_bug.cgi?id=186463
3881
3882         Reviewed by Sam Weinig.
3883
3884         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
3885         * Configurations/DebugRelease.xcconfig: Ditto.
3886         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
3887           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
3888         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
3889         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
3890           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
3891         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
3892
3893 2018-06-08  Darin Adler  <darin@apple.com>
3894
3895         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
3896         https://bugs.webkit.org/show_bug.cgi?id=186436
3897
3898         Reviewed by Anders Carlsson.
3899
3900         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
3901         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
3902         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
3903         (PoolCleaner): Ditto.
3904
3905         * History/WebHistory.mm:
3906         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3907         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
3908         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
3909         now hardly used if at all.
3910         * WebView/WebView.mm:
3911         (-[WebView rectsForTextMatches]): Ditto.
3912
3913 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3914
3915         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
3916         https://bugs.webkit.org/show_bug.cgi?id=186442
3917         <rdar://problem/40879364>
3918
3919         Reviewed by Tim Horton.
3920
3921         * Configurations/FeatureDefines.xcconfig:
3922
3923 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
3924
3925         [Datalist] Allow TextFieldInputType to show and hide suggestions
3926         https://bugs.webkit.org/show_bug.cgi?id=186151
3927
3928         Reviewed by Tim Horton.
3929
3930         * WebCoreSupport/WebChromeClient.h:
3931         * WebCoreSupport/WebChromeClient.mm:
3932         (WebChromeClient::createDataListSuggestionPicker):
3933
3934 2018-06-07  Chris Dumez  <cdumez@apple.com>
3935
3936         Add base class to get WeakPtrFactory member and avoid some boilerplate code
3937         https://bugs.webkit.org/show_bug.cgi?id=186407
3938
3939         Reviewed by Brent Fulgham.
3940
3941         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
3942         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
3943         This also gets rid of old-style createWeakPtr() methods in favor of the newer
3944         makeWeakPtr().
3945
3946         * WebCoreSupport/WebEditorClient.h:
3947         * WebCoreSupport/WebEditorClient.mm:
3948         (WebEditorClient::requestCandidatesForSelection):
3949
3950 2018-06-05  Chris Dumez  <cdumez@apple.com>
3951
3952         Regression(r232082): Websites get loaded inside of Messages App chat transcript
3953         https://bugs.webkit.org/show_bug.cgi?id=186331
3954         <rdar://problem/40735446>
3955
3956         Reviewed by Darin Adler.
3957
3958         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
3959         but does not call use / ignore on the listener, then we would do "use" by default.
3960         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
3961         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
3962         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
3963         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
3964         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
3965         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
3966         and Box.app is still working properly.
3967
3968         * WebCoreSupport/WebFrameLoaderClient.h:
3969         * WebCoreSupport/WebFrameLoaderClient.mm:
3970         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3971         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3972         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3973         (WebFrameLoaderClient::dispatchWillSubmitForm):
3974         (WebFrameLoaderClient::setUpPolicyListener):
3975         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
3976         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
3977         (-[WebFramePolicyListener dealloc]):
3978         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
3979         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
3980
3981 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
3982
3983         Adjust compile and runtime flags to match shippable state of features
3984         https://bugs.webkit.org/show_bug.cgi?id=186319
3985         <rdar://problem/40352045>
3986
3987         Reviewed by Maciej Stachowiak, Jon Lee, and others.
3988
3989         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
3990         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
3991         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
3992         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
3993         Cocoa builds.
3994
3995 2018-06-05  Timothy Hatcher  <timothy@apple.com>
3996
3997         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
3998
3999         https://bugs.webkit.org/show_bug.cgi?id=186323
4000         rdar://problem/38382252
4001
4002         Reviewed by Tim Horton.
4003
4004         * WebView/WebView.mm:
4005         (-[WebView _defaultAppearance]):
4006
4007 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
4008
4009         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
4010         https://bugs.webkit.org/show_bug.cgi?id=186286
4011         <rdar://problem/40782992>
4012
4013         Reviewed by Dan Bernstein.
4014
4015         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
4016         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
4017         change this flag when preparing for a production release.
4018
4019         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
4020         whether experimental features should be enabled, and use it to properly define the
4021         feature flag.
4022
4023 2018-06-03  Darin Adler  <darin@apple.com>
4024
4025         Simplify and remove some unused video element code (helpful for ARC-compatibility)
4026         https://bugs.webkit.org/show_bug.cgi?id=186258
4027
4028         Reviewed by Daniel Bates.
4029
4030         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
4031         forward declarations. Removed methods that don't need to be public.
4032
4033         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
4034         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
4035         unnamed category in here and also replaced the HUDWindowControllerDelegate
4036         with the unnamed category. Removed unused NSWindow category defining the
4037         isOnActiveSpace, which is not called anywhere in this file at this time.
4038         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
4039         into setVideoElement.
4040         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
4041         and removed unneeded typecast.
4042         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
4043         using statement at the to