Remove unused parameters from FrameLoaderClient::createFrame
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2
3         Remove unused parameters from FrameLoaderClient::createFrame
4         https://bugs.webkit.org/show_bug.cgi?id=190587
5
6         Reviewed by Chris Dumez.
7
8         * WebCoreSupport/WebFrameLoaderClient.h:
9         * WebCoreSupport/WebFrameLoaderClient.mm:
10         (WebFrameLoaderClient::createFrame):
11
12 2018-10-15  Alex Christensen  <achristensen@webkit.org>
13
14         Remove unused WebFrame._loadType
15         https://bugs.webkit.org/show_bug.cgi?id=190583
16
17         Reviewed by Chris Dumez.
18
19         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
20
21         * WebView/WebFrame.mm:
22         (toWebFrameLoadType): Deleted.
23         (-[WebFrame _loadType]): Deleted.
24         * WebView/WebFramePrivate.h:
25
26 2018-10-15  Chris Dumez  <cdumez@apple.com>
27
28         Restrict browsing context lookup by name to frames that are related to one another
29         https://bugs.webkit.org/show_bug.cgi?id=190475
30
31         Reviewed by Alex Christensen.
32
33         * WebView/WebFrame.mm:
34         (-[WebFrame findFrameNamed:]):
35
36 2018-10-15  Alex Christensen  <achristensen@webkit.org>
37
38         Remove InjectedBundle processing of back/forward lists
39         https://bugs.webkit.org/show_bug.cgi?id=190459
40
41         Reviewed by Chris Dumez.
42
43         * WebCoreSupport/WebFrameLoaderClient.h:
44         * WebCoreSupport/WebFrameLoaderClient.mm:
45         (WebFrameLoaderClient::shouldGoToHistoryItem const):
46
47 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
48
49         [JSC] Remove Option::useAsyncIterator
50         https://bugs.webkit.org/show_bug.cgi?id=190567
51
52         Reviewed by Saam Barati.
53
54         * Configurations/FeatureDefines.xcconfig:
55
56 2018-10-12  Alex Christensen  <achristensen@webkit.org>
57
58         Allow encoding of small enum classes
59         https://bugs.webkit.org/show_bug.cgi?id=190531
60
61         Reviewed by Tim Horton.
62
63         * WebCoreSupport/WebFrameLoaderClient.mm:
64         (-[WebFramePolicyListener dealloc]):
65
66 2018-10-11  Keith Rollin  <krollin@apple.com>
67
68         CURRENT_ARCH should not be used in Run Script phase.
69         https://bugs.webkit.org/show_bug.cgi?id=190407
70         <rdar://problem/45133556>
71
72         Reviewed by Alexey Proskuryakov.
73
74         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
75         CURRENT_ARCH is not well-defined during this phase (and may even have
76         the value "undefined") since this phase is run just once per build
77         rather than once per supported architecture. Migrate away from
78         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
79         performing an operation for each value, or by picking the first entry
80         in ARCHS and using that as a representative value.
81
82         * Configurations/WebKitLegacy.xcconfig: When generating
83         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
84         macosx platforms.
85
86         * MigrateHeaders.make:
87         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
88         generate one for each architecture in ARCHS.
89
90 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
91
92         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
93         https://bugs.webkit.org/show_bug.cgi?id=190429
94
95         Reviewed by Saam Barati.
96
97         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
98
99         * WebView/WebPDFRepresentation.mm:
100         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
101
102 2018-10-08  Justin Fan  <justin_fan@apple.com>
103
104         WebGPU: Rename old WebGPU prototype to WebMetal
105         https://bugs.webkit.org/show_bug.cgi?id=190325
106         <rdar://problem/44990443>
107
108         Reviewed by Dean Jackson.
109
110         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
111
112         * Configurations/FeatureDefines.xcconfig:
113         * WebView/WebPreferenceKeysPrivate.h:
114         * WebView/WebPreferences.mm:
115         (+[WebPreferences initialize]):
116         (-[WebPreferences webMetalEnabled]):
117         (-[WebPreferences setWebMetalEnabled:]):
118         (-[WebPreferences webGPUEnabled]): Deleted.
119         (-[WebPreferences setWebGPUEnabled:]): Deleted.
120         * WebView/WebPreferencesPrivate.h:
121         * WebView/WebView.mm:
122         (-[WebView _preferencesChanged:]):
123
124 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
125
126         Make <input type=color> a runtime enabled (on-by-default) feature
127         https://bugs.webkit.org/show_bug.cgi?id=189162
128
129         Reviewed by Wenson Hsieh and Tim Horton.
130
131         * Configurations/FeatureDefines.xcconfig:
132
133 2018-10-07  Dan Bernstein  <mitz@apple.com>
134
135         Fixed building with the latest macOS SDK
136
137         * Plugins/WebNetscapePluginPackage.mm:
138         (-[WebNetscapePluginPackage openResourceFile]):
139         (-[WebNetscapePluginPackage closeResourceFile:]):
140
141 2018-10-04  Dan Bernstein  <mitz@apple.com>
142
143         More Carbon build-fixing.
144
145         * Carbon/CarbonWindowAdapter.mm:
146         (-[CarbonWindowAdapter _destroyRealWindow:]):
147         (-[CarbonWindowAdapter _growBoxRect]):
148
149 2018-10-04  Dan Bernstein  <mitz@apple.com>
150
151         Retried to fix 32-bit macOS builds after r236846.
152
153         * WebView/WebHTMLView.mm:
154         (-[WebHTMLView setMarkedText:selectedRange:]):
155
156 2018-10-04  Dan Bernstein  <mitz@apple.com>
157
158         Retried to fix 32-bit macOS builds after r236846.
159
160         * Carbon/HIWebView.mm:
161         (ActiveStateChanged):
162
163 2018-10-04  Dan Bernstein  <mitz@apple.com>
164
165         Tried to fix 32-bit macOS builds after r236846.
166
167         * Carbon/HIWebView.mm:
168         (_NSSelectorForHICommand):
169
170 2018-10-04  Dan Bernstein  <mitz@apple.com>
171
172         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
173         https://bugs.webkit.org/show_bug.cgi?id=190250
174
175         Reviewed by Andy Estes.
176
177         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
178           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
179           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
180           an earlier line set it to YES.
181
182         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
183         changes below.
184
185         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
186           provides some missing method declarations.
187
188         * Misc/WebDownload.mm:
189         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
190           a deprecated method.
191
192         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
193
194         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
195           other code in the file uses a method from it.
196
197         * Plugins/WebBaseNetscapePluginView.mm:
198         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
199           a deprecated method.
200
201         * Plugins/WebPluginController.mm:
202         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
203           around use of a selector that may be present in some WebKit client.
204
205         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
206           method declarations.
207
208         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
209           from here.
210
211         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
212           missing method declarations.
213
214         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
215           from here.
216
217         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
218           call from here.
219         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
220           an obsolete delegate method for binary compatibility.
221         (pluginView): Ditto.
222
223         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
224           call from here.
225
226         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
227           WebDeviceOrientationProviderMock protocol.
228
229         * WebView/WebDeviceOrientationProviderMock.mm:
230         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
231           main @implementation.
232
233         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
234           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
235
236         * WebView/WebDynamicScrollBarsView.mm:
237         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
238           of a deprecated method.
239
240         * WebView/WebHTMLView.mm:
241         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
242           selector warning around action methods that are not declared anywhere in WebKit.
243
244         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
245           about implementing this deprecated method.
246         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
247         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
248         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
249         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
250         (-[WebHTMLView characterIndexForPoint:]): Ditto.
251         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
252         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
253         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
254         (-[WebHTMLView doCommandBySelector:]): Ditto.
255         (-[WebHTMLView insertText:]): Ditto.
256
257         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
258
259         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
260
261         * WebView/WebPDFView.h: Removed previewView ivar.
262
263         * WebView/WebPDFView.mm:
264           Removed declaration of FileInternal category and merged its implementation with the main
265           implementation.
266         (-[WebPDFView dealloc]): Removed previewView ivar.
267         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
268           exist in macOS versions we support.
269         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
270         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
271           action methods internal to PDFKit.
272         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
273         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
274
275         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
276           call on macOS, even though in r86988 we started calling different methods on iOS.
277
278         * WebView/WebView.mm:
279         - Imported headers that declare delegate methods that we call.
280         - Removed declaration of WebFileInternal category and merged its implementation with the
281           main implementation.
282         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
283           category, which made them impossible to call from the main implementation. Moved those
284           into the main implementation. One of those had to be declared in a class extension,
285           because it is called from a method implemented in the WebPrivate category, and that
286           category’s implementation appears first in the file.
287
288         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
289           around use of obsolete delegate method for binary compatibility.
290
291         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
292
293 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
294
295         Runtime flag and IDL for MediaRecorder
296         https://bugs.webkit.org/show_bug.cgi?id=190018
297
298         Reviewed by Youenn Fablet and Chris Dumez.
299
300         * WebView/WebPreferenceKeysPrivate.h:
301         * WebView/WebPreferences.mm:
302         (+[WebPreferences initialize]):
303         (-[WebPreferences mediaRecorderEnabled]):
304         (-[WebPreferences setMediaRecorderEnabled:]):
305         * WebView/WebPreferencesPrivate.h:
306         * WebView/WebView.mm:
307         (-[WebView _preferencesChanged:]):
308
309 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
310
311         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
312         https://bugs.webkit.org/show_bug.cgi?id=190238
313
314         Reviewed by Antti Koivisto.
315
316         Enabled the feature by default.
317
318         * WebView/WebPreferences.mm:
319         (+[WebPreferences initialize]):
320
321 2018-10-01  Dean Jackson  <dino@apple.com>
322
323         [macOS] Switching to discrete GPU should be done in the UI process
324         https://bugs.webkit.org/show_bug.cgi?id=189361
325         <rdar://problem/43949622>
326
327         Reviewed by Simon Fraser.
328
329         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
330         not support swapping to the discrete GPU in this configuration.
331
332         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
333         (WebKit::WebSwitchingGPUClient::singleton):
334         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
335         * WebView/WebView.mm:
336         (-[WebView _commonInitializationWithFrameName:groupName:]):
337
338 2018-10-02  Alex Christensen  <achristensen@webkit.org>
339
340         Remove ParsedURLString
341         https://bugs.webkit.org/show_bug.cgi?id=190154
342
343         Reviewed by Chris Dumez.
344
345         * WebView/WebScriptDebugger.mm:
346         (toNSURL):
347
348 2018-10-01  Dean Jackson  <dino@apple.com>
349
350         Remove CSS Animation Triggers
351         https://bugs.webkit.org/show_bug.cgi?id=190175
352         <rdar://problem/44925626>
353
354         Reviewed by Simon Fraser.
355
356         * Configurations/FeatureDefines.xcconfig:
357
358 2018-10-02  Commit Queue  <commit-queue@webkit.org>
359
360         Unreviewed, rolling out r236624 and r236671.
361         https://bugs.webkit.org/show_bug.cgi?id=190207
362
363         The change in r236624 introduced crashes on the bots
364         (Requested by ryanhaddad on #webkit).
365
366         Reverted changesets:
367
368         "Refactoring: eliminate raw pointer usage in Fullscreen code"
369         https://bugs.webkit.org/show_bug.cgi?id=188747
370         https://trac.webkit.org/changeset/236624
371
372         "Unify implementation in VideoFullscreenInterfaceAVKit"
373         https://bugs.webkit.org/show_bug.cgi?id=190091
374         https://trac.webkit.org/changeset/236671
375
376 2018-10-01  Alex Christensen  <achristensen@webkit.org>
377
378         URL should not use TextEncoding internally
379         https://bugs.webkit.org/show_bug.cgi?id=190111
380
381         Reviewed by Andy Estes.
382
383         * Misc/WebNSURLExtras.mm:
384
385 2018-09-28  Jer Noble  <jer.noble@apple.com>
386
387         Refactoring: eliminate raw pointer usage in Fullscreen code
388         https://bugs.webkit.org/show_bug.cgi?id=188747
389         <rdar://problem/43541164>
390
391         Reviewed by Alex Christensen.
392
393         PlaybackSessionInterface no longer has an invalidate() method.
394
395         * WebView/WebView.mm:
396         (-[WebView _clearPlaybackControlsManager]):
397
398 2018-09-28  Chris Dumez  <cdumez@apple.com>
399
400         Drop support for cross-origin-window-policy header
401         https://bugs.webkit.org/show_bug.cgi?id=190081
402
403         Reviewed by Ryosuke Niwa.
404
405         * WebView/WebPreferenceKeysPrivate.h:
406         * WebView/WebPreferences.mm:
407         (+[WebPreferences initialize]):
408         * WebView/WebPreferencesPrivate.h:
409         * WebView/WebView.mm:
410         (-[WebView _preferencesChanged:]):
411
412 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
413
414         Rename createMarkup to serializePreservingVisualAppearance
415         https://bugs.webkit.org/show_bug.cgi?id=190086
416
417         Reviewed by Wenson Hsieh.
418
419         * DOM/WebDOMOperations.mm:
420         (-[DOMRange markupString]):
421
422 2018-09-28  Commit Queue  <commit-queue@webkit.org>
423
424         Unreviewed, rolling out r236605.
425         https://bugs.webkit.org/show_bug.cgi?id=190087
426
427         caused three API test timeouts (Requested by jernoble on
428         #webkit).
429
430         Reverted changeset:
431
432         "Refactoring: eliminate raw pointer usage in Fullscreen code"
433         https://bugs.webkit.org/show_bug.cgi?id=188747
434         https://trac.webkit.org/changeset/236605
435
436 2018-09-28  Jer Noble  <jer.noble@apple.com>
437
438         Refactoring: eliminate raw pointer usage in Fullscreen code
439         https://bugs.webkit.org/show_bug.cgi?id=188747
440         <rdar://problem/43541164>
441
442         Reviewed by Alex Christensen.
443
444         PlaybackSessionInterface no longer has an invalidate() method.
445
446         * WebView/WebView.mm:
447         (-[WebView _clearPlaybackControlsManager]):
448
449 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
450
451         Use enum class in createMarkup arguments
452         https://bugs.webkit.org/show_bug.cgi?id=190028
453
454         Reviewed by Wenson Hsieh.
455
456         * DOM/WebDOMOperations.mm:
457         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
458         (-[DOMRange markupString]): Ditto.
459
460 2018-09-27  Antoine Quint  <graouts@apple.com>
461
462         [Web Animations] Turn Web Animations with CSS integration on
463         https://bugs.webkit.org/show_bug.cgi?id=184819
464         <rdar://problem/39597337>
465
466         Reviewed by Dean Jackson.
467
468         * WebView/WebPreferences.mm:
469         (+[WebPreferences initialize]):
470
471 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
472
473         Selection should work across shadow boundary when initiated by a mouse drag
474         https://bugs.webkit.org/show_bug.cgi?id=151380
475         <rdar://problem/24363872>
476
477         Reviewed by Wenson Hsieh.
478
479         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
480
481         * WebView/WebPreferenceKeysPrivate.h:
482         * WebView/WebPreferences.mm:
483         (+[WebPreferences initialize]):
484         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
485         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
486         * WebView/WebPreferencesPrivate.h:
487         * WebView/WebView.mm:
488         (-[WebView _preferencesChanged:]):
489
490 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
491
492         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
493         https://bugs.webkit.org/show_bug.cgi?id=189918
494         Work towards <rdar://problem/44648705>
495
496         Reviewed by Tim Horton.
497
498         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
499
500         * WebView/WebHTMLView.mm:
501         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
502         (-[WebHTMLView _updateFontPanel]):
503         * WebView/WebView.mm:
504         (-[WebView typingAttributes]):
505
506 2018-09-17  Darin Adler  <darin@apple.com>
507
508         Use OpaqueJSString rather than JSRetainPtr inside WebKit
509         https://bugs.webkit.org/show_bug.cgi?id=189652
510
511         Reviewed by Saam Barati.
512
513         * WebView/WebPDFRepresentation.mm:
514         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
515
516 2018-09-14  Jer Noble  <jer.noble@apple.com>
517
518         Turn SourceBufferChangeTypeEnabled on by default
519         https://bugs.webkit.org/show_bug.cgi?id=189527
520
521         Reviewed by Eric Carlson.
522
523         * WebView/WebPreferences.mm:
524         (+[WebPreferences initialize]):
525
526 2018-09-12  Alex Christensen  <achristensen@webkit.org>
527
528         Fix an internal build after r235935
529         https://bugs.webkit.org/show_bug.cgi?id=188996
530
531         * Carbon/HIWebView.mm:
532         (Draw):
533         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
534
535 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
536
537         Add IGNORE_WARNING_.* macros
538         https://bugs.webkit.org/show_bug.cgi?id=188996
539
540         Reviewed by Michael Catanzaro.
541
542         * Carbon/CarbonUtils.m:
543         (PoolCleaner):
544         * Carbon/CarbonWindowAdapter.mm:
545         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
546         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
547         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
548         (-[CarbonWindowAdapter _termWindowIfOwner]):
549         (-[CarbonWindowAdapter _windowMovedToRect:]):
550         (-[CarbonWindowAdapter setContentView:]):
551         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
552         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
553         * Carbon/CarbonWindowFrame.m:
554         (-[CarbonWindowFrame title]):
555         * Carbon/HIViewAdapter.m:
556         (+[HIViewAdapter getHIViewForNSView:]):
557         * Carbon/HIWebView.mm:
558         (overrideCGContext):
559         (restoreCGContext):
560         (Draw):
561         * DOM/DOM.mm:
562         * History/WebHistory.mm:
563         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
564         * History/WebHistoryItem.mm:
565         (-[WebHistoryItem icon]):
566         * Misc/WebKitNSStringExtras.mm:
567         (-[NSString _web_drawAtPoint:font:textColor:]):
568         * Misc/WebNSImageExtras.m:
569         (-[NSImage _web_scaleToMaxSize:]):
570         (-[NSImage _web_dissolveToFraction:]):
571         * Misc/WebNSPasteboardExtras.mm:
572         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
573         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
574         * Panels/WebAuthenticationPanel.m:
575         (-[WebAuthenticationPanel loadNib]):
576         * Plugins/Hosted/NetscapePluginHostManager.mm:
577         (WebKit::NetscapePluginHostManager::spawnPluginHost):
578         (WebKit::NetscapePluginHostManager::didCreateWindow):
579         * Plugins/Hosted/NetscapePluginHostProxy.mm:
580         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
581         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
582         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
583         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
584         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
585         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
586         (-[WebHostedNetscapePluginView drawRect:]):
587         * Plugins/Hosted/WebTextInputWindowController.m:
588         (-[WebTextInputPanel _interpretKeyEvent:string:]):
589         * Plugins/WebBaseNetscapePluginView.mm:
590         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
591         * Plugins/WebNetscapePluginPackage.mm:
592         (-[WebNetscapePluginPackage _tryLoad]):
593         * Plugins/WebNetscapePluginView.mm:
594         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
595         (-[WebNetscapePluginView sendDrawRectEvent:]):
596         (-[WebNetscapePluginView drawRect:]):
597         * Plugins/WebPluginController.mm:
598         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
599         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
600         * WebCoreSupport/PopupMenuMac.mm:
601         (PopupMenuMac::populate):
602         * WebCoreSupport/WebAlternativeTextClient.h:
603         * WebCoreSupport/WebDragClient.mm:
604         (WebDragClient::startDrag):
605         * WebCoreSupport/WebFrameLoaderClient.mm:
606         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
607         (webGetNSImage):
608         * WebInspector/WebNodeHighlight.mm:
609         * WebInspector/WebNodeHighlightView.mm:
610         (-[WebNodeHighlightView drawRect:]):
611         * WebView/WebClipView.mm:
612         (-[WebClipView initWithFrame:]):
613         * WebView/WebFrame.mm:
614         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
615         (-[WebFrame _drawRect:contentsOnly:]):
616         (-[WebFrame accessibilityRoot]):
617         * WebView/WebFullScreenController.mm:
618         (-[WebFullScreenController enterFullScreen:]):
619         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
620         (-[WebFullScreenController exitFullScreen]):
621         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
622         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
623         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
624         * WebView/WebHTMLView.mm:
625         (-[NSWindow _web_borderView]):
626         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
627         (-[WebHTMLView _setAsideSubviews]):
628         (-[WebHTMLView _autoscroll]):
629         (-[WebHTMLView drawRect:]):
630         (-[WebHTMLView mouseDown:]):
631         (-[WebHTMLView mouseDragged:]):
632         (-[WebHTMLView mouseUp:]):
633         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
634         (-[WebHTMLView knowsPageRange:]):
635         (-[WebHTMLView accessibilityHitTest:]):
636         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
637         (-[WebHTMLView _colorAsString:]):
638         (-[WebHTMLView copyFont:]):
639         (-[WebHTMLView _executeSavedKeypressCommands]):
640         (-[WebHTMLView attachRootLayer:]):
641         (-[WebHTMLView textStorage]):
642         (-[WebHTMLView _updateSelectionForInputManager]):
643         * WebView/WebPDFView.mm:
644         (_applicationInfoForMIMEType):
645         (-[WebPDFView centerSelectionInVisibleArea:]):
646         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
647         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
648         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
649         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
650         * WebView/WebTextCompletionController.mm:
651         (-[WebTextCompletionController _buildUI]):
652         (-[WebTextCompletionController _placePopupWindow:]):
653         * WebView/WebVideoFullscreenController.mm:
654         * WebView/WebVideoFullscreenHUDWindowController.mm:
655         (createMediaUIBackgroundView):
656         * WebView/WebView.mm:
657         (-[WebTextListTouchBarViewController initWithWebView:]):
658         (-[WebView _dispatchTileDidDraw:]):
659         (-[WebView encodeWithCoder:]):
660         (-[WebView mainFrameIcon]):
661         (LayerFlushController::flushLayers):
662         * WebView/WebWindowAnimation.mm:
663         (setScaledFrameForWindow):
664
665 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
666
667         Remove unused needsDestruction class variables from HashTraits
668         https://bugs.webkit.org/show_bug.cgi?id=189490
669
670         Reviewed by Daniel Bates.
671
672         * History/BinaryPropertyList.cpp: Removed needsDestruction.
673
674 2018-09-07  Frederic Wang  <fwang@igalia.com>
675
676         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
677         https://bugs.webkit.org/show_bug.cgi?id=182230
678
679         Reviewed by Simon Fraser.
680
681         * DOM/DOMDocument.mm:
682         (-[DOMDocument scrollingElement]): Use the new name.
683
684 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
685
686         Refactor WebCore::EditAction to be an 8-bit enum class
687         https://bugs.webkit.org/show_bug.cgi?id=189383
688
689         Reviewed by Dan Bernstein.
690
691         * WebCoreSupport/WebEditorClient.mm:
692         (undoNameForEditAction):
693         * WebView/WebHTMLView.mm:
694         (-[WebHTMLView pasteFont:]):
695         (-[WebHTMLView changeFont:]):
696         (-[WebHTMLView changeAttributes:]):
697         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
698         (-[WebHTMLView changeColor:]):
699         * WebView/WebView.mm:
700         (-[WebView setTypingStyle:]):
701
702 2018-09-06  Frederic Wang  <fwang@igalia.com>
703
704         Group options of scrollRectToVisible into a struct
705         https://bugs.webkit.org/show_bug.cgi?id=189352
706
707         Reviewed by Simon Fraser.
708
709         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
710         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
711         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
712
713 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
714
715         [macOS] Cannot change font size at selection until font panel is shown
716         https://bugs.webkit.org/show_bug.cgi?id=189295
717         <rdar://problem/35593389>
718
719         Reviewed by Ryosuke Niwa.
720
721         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
722         WebCore ChangeLog for more details.
723
724         * WebView/WebHTMLView.mm:
725         (-[WebHTMLView changeFont:]):
726         (-[WebHTMLView changeAttributes:]):
727         (-[WebHTMLView _originalFontA]): Deleted.
728         (-[WebHTMLView _originalFontB]): Deleted.
729         (fontNameForDescription): Deleted.
730         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
731         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
732         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
733
734 2018-09-05  Jer Noble  <jer.noble@apple.com>
735
736         Add MediaCapabilities as an Experimental Feature
737         https://bugs.webkit.org/show_bug.cgi?id=189209
738
739         Reviewed by Eric Carlson.
740
741         RuntimeEnabledFeature -> Setting.
742
743         * WebView/WebView.mm:
744         (-[WebView _preferencesChanged:]):
745
746 2018-09-04  Frederic Wang  <fwang@igalia.com>
747
748         Add basic support for ScrollIntoViewOptions
749         https://bugs.webkit.org/show_bug.cgi?id=189258
750
751         Reviewed by Simon Fraser.
752
753         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
754         header so that this file can build despite the new scrollIntoView function.
755
756 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
757
758         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
759         https://bugs.webkit.org/show_bug.cgi?id=188890
760         <rdar://problem/43648605>
761
762         Reviewed by Tim Horton.
763
764         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
765         more detail.
766
767         * WebCoreSupport/WebPlatformStrategies.h:
768         * WebCoreSupport/WebPlatformStrategies.mm:
769         (WebPlatformStrategies::allStringsForType):
770
771 2018-09-01  Darin Adler  <darin@apple.com>
772
773         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
774         https://bugs.webkit.org/show_bug.cgi?id=189072
775         Reviewed by Dan Bernstein.
776
777         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
778         and declarations for NSURLDownload init methods.
779
780         * Misc/WebDownloadInternal.h: Removed.
781
782         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
783         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
784         "-Wdeprecated-declarations" because the method used here is deprecated.
785
786         * WebView/WebView.mm:
787         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
788         used here is deprecated.
789
790 2018-08-31  Chris Dumez  <cdumez@apple.com>
791
792         Assertion hit in ~CompletionHandler() from ~WebFrame()
793         https://bugs.webkit.org/show_bug.cgi?id=189199
794         <rdar://problem/42657233>
795
796         Reviewed by Youenn Fablet.
797
798         * WebCoreSupport/WebFrameLoaderClient.h:
799         * WebCoreSupport/WebFrameLoaderClient.mm:
800         (WebFrameLoaderClient::dispatchWillSubmitForm):
801
802 2018-08-31  Antti Koivisto  <antti@apple.com>
803
804         Replace OptionSet |= and -= operators with add() and remove() functions
805         https://bugs.webkit.org/show_bug.cgi?id=189169
806
807         Reviewed by Anders Carlsson.
808
809         * WebView/WebFrame.mm:
810         (-[WebFrame _drawRect:contentsOnly:]):
811         * WebView/WebView.mm:
812         (coreOptions):
813
814 2018-08-31  Frederic Wang  <fwang@igalia.com>
815
816         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
817         https://bugs.webkit.org/show_bug.cgi?id=182053
818
819         Reviewed by Simon Fraser.
820
821         Add developer flag to use standard behavior for scrolling* attributes.
822
823         * WebView/WebPreferenceKeysPrivate.h:
824         * WebView/WebPreferences.mm:
825         (+[WebPreferences initialize]):
826         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
827         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
828         * WebView/WebPreferencesPrivate.h:
829         * WebView/WebView.mm:
830         (-[WebView _preferencesChanged:]):
831
832 2018-08-29  Olivia Barnett  <obarnett@apple.com>
833
834         Implement the Web Share API
835         https://bugs.webkit.org/show_bug.cgi?id=171100
836         <rdar://problem/31751734>
837
838         Reviewed by Tim Horton.
839
840         * WebCoreSupport/WebChromeClient.h:
841         * WebCoreSupport/WebChromeClient.mm:
842         (WebChromeClient::showShareSheet):
843         Empty declaration of showShareSheet.
844
845 2018-08-29  Youenn Fablet  <youenn@apple.com>
846
847         Remove WebRTC legacy API implementation
848         https://bugs.webkit.org/show_bug.cgi?id=189040
849
850         Reviewed by Eric Carlson.
851
852         * WebView/WebPreferenceKeysPrivate.h:
853         * WebView/WebPreferences.mm:
854         (+[WebPreferences initialize]):
855         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
856         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
857         * WebView/WebPreferencesPrivate.h:
858         * WebView/WebView.mm:
859         (-[WebView _preferencesChanged:]):
860
861 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
862
863         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
864         https://bugs.webkit.org/show_bug.cgi?id=189054
865
866         Reviewed by Andy Estes.
867
868         Remove the pasteboard type argument from readURLFromPasteboard.
869
870         * WebCoreSupport/WebPlatformStrategies.h:
871         * WebCoreSupport/WebPlatformStrategies.mm:
872         (WebPlatformStrategies::readURLFromPasteboard):
873
874 2018-08-27  Keith Rollin  <krollin@apple.com>
875
876         Unreviewed build fix -- disable LTO for production builds
877
878         * Configurations/Base.xcconfig:
879
880 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
881
882         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
883         https://bugs.webkit.org/show_bug.cgi?id=188931
884
885         Reviewed by Wenson Hsieh.
886
887         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
888
889 2018-08-27  Keith Rollin  <krollin@apple.com>
890
891         Build system support for LTO
892         https://bugs.webkit.org/show_bug.cgi?id=187785
893         <rdar://problem/42353132>
894
895         Reviewed by Dan Bernstein.
896
897         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
898         LTO.
899
900         * Configurations/Base.xcconfig:
901         * Configurations/DebugRelease.xcconfig:
902
903 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
904
905         Pass in IsComposed flag to Event constructors
906         https://bugs.webkit.org/show_bug.cgi?id=188720
907         <rdar://problem/43580387>
908
909         Reviewed by Simon Fraser.
910
911         * WebView/WebPDFView.mm:
912         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
913         whether it's simulated or not.
914
915 2018-08-23  Mark Lam  <mark.lam@apple.com>
916
917         Move vmEntryGlobalObject() to VM from CallFrame.
918         https://bugs.webkit.org/show_bug.cgi?id=188900
919         <rdar://problem/43655753>
920
921         Reviewed by Michael Saboff.
922
923         * WebView/WebScriptDebugger.mm:
924         (WebScriptDebugger::sourceParsed):
925
926 2018-08-23  Andy Estes  <aestes@apple.com>
927
928         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
929         https://bugs.webkit.org/show_bug.cgi?id=188829
930
931         Reviewed by Tim Horton.
932
933         * Configurations/FeatureDefines.xcconfig:
934
935 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
936
937         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
938         https://bugs.webkit.org/show_bug.cgi?id=188777
939
940         Reviewed by Simon Fraser.
941
942         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
943         being "true" before the code change.
944
945         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
946
947         * WebView/WebPDFView.mm:
948         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
949
950 2018-08-21  Daniel Bates  <dabates@apple.com>
951
952         Replace TextCheckingTypeMask with OptionSet
953         https://bugs.webkit.org/show_bug.cgi?id=188678
954
955         Reviewed by Antti Koivisto.
956
957         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
958         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
959         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
960         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
961
962         * WebCoreSupport/WebEditorClient.h:
963         * WebCoreSupport/WebEditorClient.mm:
964         (WebEditorClient::checkTextOfParagraph):
965         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
966         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
967         left as this is more readable and unncessary now that modern compilers like Clang have
968         diagnostics to catch accidental assignments when equality was intended.
969         (WebEditorClient::didCheckSucceed):
970         * WebView/WebView.mm:
971         (coreTextCheckingType):
972         (textCheckingResultFromNSTextCheckingResult):
973
974 2018-08-21  Daniel Bates  <dabates@apple.com>
975
976         [iOS][WK1] Support toggling continuous spell checking from tests
977         https://bugs.webkit.org/show_bug.cgi?id=188763
978
979         Reviewed by Simon Fraser.
980
981         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
982         spell checking from tests in iOS WebKit Legacy.
983
984         * WebCoreSupport/WebEditorClient.h:
985         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
986         * WebCoreSupport/WebEditorClient.mm:
987         * WebView/WebView.h:
988         * WebView/WebView.mm:
989         (-[WebView toggleContinuousSpellChecking:]):
990         (-[WebView toggleSmartInsertDelete:]):
991
992 2018-08-17  Alex Christensen  <achristensen@webkit.org>
993
994         Add some plumbing for safe browsing
995         https://bugs.webkit.org/show_bug.cgi?id=188709
996
997         Reviewed by Tim Horton.
998
999         * WebCoreSupport/WebFrameLoaderClient.h:
1000         * WebCoreSupport/WebFrameLoaderClient.mm:
1001         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1002
1003 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
1004
1005         Replace canBubble and cancelable booleans in Event by enum classes
1006         https://bugs.webkit.org/show_bug.cgi?id=188692
1007
1008         Reviewed by Alex Christensen.
1009
1010         * WebView/WebPDFView.mm:
1011         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1012         * WebView/WebView.mm:
1013         (-[WebView _dispatchUnloadEvent]):
1014
1015 2018-08-16  Jer Noble  <jer.noble@apple.com>
1016
1017         Add Experimental Feature support for SourceBuffer.changeType()
1018         https://bugs.webkit.org/show_bug.cgi?id=188626
1019         <rdar://problem/43356021>
1020
1021         Reviewed by Eric Carlson.
1022
1023         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
1024
1025         * WebView/WebPreferenceKeysPrivate.h:
1026         * WebView/WebPreferences.mm:
1027         (+[WebPreferences initialize]):
1028         (-[WebPreferences sourceBufferChangeTypeEnabled]):
1029         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
1030         * WebView/WebPreferencesPrivate.h:
1031         * WebView/WebView.mm:
1032         (-[WebView _preferencesChanged:]):
1033
1034 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
1035
1036         Support drag-and-drop for input[type=color]
1037         https://bugs.webkit.org/show_bug.cgi?id=188464
1038
1039         Reviewed by Wenson Hsieh.
1040
1041         * WebCoreSupport/WebPlatformStrategies.h:
1042         * WebCoreSupport/WebPlatformStrategies.mm:
1043         (WebPlatformStrategies::setColor):
1044
1045 2018-08-15  Tim Horton  <timothy_horton@apple.com>
1046
1047         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
1048         https://bugs.webkit.org/show_bug.cgi?id=188569
1049         <rdar://problem/34201095>
1050
1051         Reviewed by Megan Gardner.
1052
1053         * WebView/WebImmediateActionController.mm:
1054         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1055         Speculative fix; the crashes indicate font is null, but we just checked it,
1056         so it must be getting made null by convertFont:toSize:. Check again!
1057
1058 2018-08-13  Alex Christensen  <achristensen@webkit.org>
1059
1060         Use a 1-byte enum class for TextDirection
1061         https://bugs.webkit.org/show_bug.cgi?id=188350
1062
1063         Reviewed by Simon Fraser.
1064
1065         * WebCoreSupport/PopupMenuMac.mm:
1066         (PopupMenuMac::populate):
1067         (PopupMenuMac::show):
1068         * WebCoreSupport/WebFrameLoaderClient.mm:
1069         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1070         * WebView/WebFrame.mm:
1071         (-[WebFrame _dispatchDidReceiveTitle:]):
1072
1073 2018-08-09  Ali Juma  <ajuma@chromium.org>
1074
1075         Import WPTs for IntersectionObserver
1076         https://bugs.webkit.org/show_bug.cgi?id=188416
1077
1078         Reviewed by Simon Fraser.
1079
1080         * WebView/WebPreferencesPrivate.h:
1081
1082 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
1083
1084         Follow-up build fix for r234685
1085         https://bugs.webkit.org/show_bug.cgi?id=188245
1086
1087         Unreviewed build fix.
1088
1089         * WebCoreSupport/WebSecurityOriginPrivate.h:
1090
1091 2018-08-05  Darin Adler  <darin@apple.com>
1092
1093         [Cocoa] More tweaks and refactoring to prepare for ARC
1094         https://bugs.webkit.org/show_bug.cgi?id=188245
1095
1096         Reviewed by Dan Bernstein.
1097
1098         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
1099
1100         * Carbon/CarbonWindowFrame.m:
1101         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
1102
1103         * DOM/DOM.mm:
1104         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
1105         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
1106         garbage collection so this method isn't useful.
1107
1108         * DOM/DOMXPath.mm:
1109         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
1110         Objective-C garbage collection so this method isn't useful.
1111
1112         * History/WebHistory.mm:
1113         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
1114
1115         * Misc/WebElementDictionary.mm:
1116         (addLookupKey): Use a bridging cast.
1117         (cacheValueForKey): Ditto.
1118         (-[WebElementDictionary _fillCache]): Ditto.
1119         (-[WebElementDictionary objectForKey:]): Ditto.
1120
1121         * Misc/WebKitNSStringExtras.mm:
1122         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
1123         (-[NSString _web_widthWithFont:]): Ditto.
1124         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
1125
1126         * Misc/WebLocalizableStrings.mm:
1127         (WebLocalizedString): Use a bridging cast.
1128
1129         * Misc/WebNSDataExtras.mm:
1130         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
1131         and use CFBridgingRelease instead of calling autorelease directly.
1132         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
1133         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
1134         on the amount of explicit release and autorelease.
1135
1136         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
1137         * Misc/WebNSDictionaryExtras.m:
1138         (-[NSDictionary _webkit_intForKey:]): Deleted.
1139         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
1140         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
1141         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
1142         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
1143         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
1144         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
1145
1146         * Misc/WebStringTruncator.mm:
1147         (fontFromNSFont): Use a bridging cast.
1148
1149         * Plugins/Hosted/NetscapePluginHostManager.mm:
1150         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
1151
1152         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1153         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
1154         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
1155         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
1156         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
1157         * Plugins/Hosted/ProxyInstance.mm:
1158         (WebKit::ProxyInstance::getPropertyNames): Ditto.
1159         * Plugins/WebBasePluginPackage.mm:
1160         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
1161         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1162         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
1163         * Plugins/WebNetscapePluginPackage.mm:
1164         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
1165
1166         * Plugins/WebNetscapePluginView.mm:
1167         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
1168         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
1169         (-[WebNetscapePluginView status:]): Use a bridging cast.
1170         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
1171
1172         * Plugins/WebPluginController.mm:
1173         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
1174
1175         * Plugins/WebPluginDatabase.mm:
1176         (checkCandidate): Use explicit __strong for out argument types.
1177
1178         * Plugins/npapi.mm:
1179         (pluginViewForInstance): Use a bridging cast.
1180
1181         * Storage/WebDatabaseManager.mm:
1182         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
1183         explicit NSNumber and NSDictionary calls.
1184
1185         * WebCoreSupport/WebContextMenuClient.mm:
1186         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
1187
1188         * WebCoreSupport/WebEditorClient.mm:
1189         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
1190         (WebEditorClient::handleInputMethodKeydown): Ditto.
1191
1192         * WebCoreSupport/WebFrameNetworkingContext.mm:
1193         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
1194
1195         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
1196         as a struct rather than an Objective-C class, since that's how it's defined.
1197
1198         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
1199
1200         * WebView/WebFullScreenController.mm:
1201         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
1202         * WebView/WebHTMLView.mm:
1203         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1204         Ditto.
1205         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1206
1207         * WebView/WebImmediateActionController.mm:
1208         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
1209         go down to the document and then back to the frame.
1210         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
1211         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
1212         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
1213
1214         * WebView/WebJSPDFDoc.mm:
1215         (jsPDFDocInitialize): Removed some unneeded type casting.
1216         (jsPDFDocFinalize): Ditto.
1217         (jsPDFDocPrint): Use a bridging cast.
1218
1219         * WebView/WebPDFView.mm:
1220         (_applicationInfoForMIMEType): Use bridging casts.
1221
1222         * WebView/WebPreferences.mm:
1223         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
1224         instead of methods from WebNSDictionaryExtras.
1225         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
1226         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
1227         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
1228         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
1229         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
1230
1231         * WebView/WebView.mm:
1232         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
1233         (-[WebView _addToAllWebViewsSet]): Ditto.
1234         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
1235         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
1236         so it can be called from WebViewData methods.
1237
1238         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
1239         method, _windowVisibilityChanged:.
1240
1241         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
1242         called from WebViewData methods.
1243
1244 2018-08-06  Alex Christensen  <achristensen@webkit.org>
1245
1246         Use enum classes and OptionSets for PaintPhase and PaintBehavior
1247         https://bugs.webkit.org/show_bug.cgi?id=188323
1248
1249         Reviewed by Simon Fraser.
1250
1251         * WebCoreSupport/WebContextMenuClient.mm:
1252         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1253         * WebView/WebFrame.mm:
1254         (-[WebFrame _paintBehaviorForDestinationContext:]):
1255         (-[WebFrame _drawRect:contentsOnly:]):
1256         * WebView/WebHTMLView.mm:
1257         (imageFromRect):
1258         (selectionImage):
1259
1260 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1261
1262         Add support for microtasks in workers
1263         https://bugs.webkit.org/show_bug.cgi?id=188246
1264
1265         Reviewed by Darin Adler.
1266
1267         Rename JSMainThreadExecState.h to JSExecState.h.
1268
1269         * DOM/DOMAttr.mm:
1270         * DOM/DOMBlob.mm:
1271         * DOM/DOMCDATASection.mm:
1272         * DOM/DOMCSSCharsetRule.mm:
1273         * DOM/DOMCSSFontFaceRule.mm:
1274         * DOM/DOMCSSImportRule.mm:
1275         * DOM/DOMCSSMediaRule.mm:
1276         * DOM/DOMCSSPageRule.mm:
1277         * DOM/DOMCSSPrimitiveValue.mm:
1278         * DOM/DOMCSSRule.mm:
1279         * DOM/DOMCSSRuleList.mm:
1280         * DOM/DOMCSSStyleDeclaration.mm:
1281         * DOM/DOMCSSStyleRule.mm:
1282         * DOM/DOMCSSStyleSheet.mm:
1283         * DOM/DOMCSSUnknownRule.mm:
1284         * DOM/DOMCSSValue.mm:
1285         * DOM/DOMCSSValueList.mm:
1286         * DOM/DOMCharacterData.mm:
1287         * DOM/DOMComment.mm:
1288         * DOM/DOMCounter.mm:
1289         * DOM/DOMDocument.mm:
1290         * DOM/DOMDocumentFragment.mm:
1291         * DOM/DOMDocumentType.mm:
1292         * DOM/DOMElement.mm:
1293         * DOM/DOMEvent.mm:
1294         * DOM/DOMFile.mm:
1295         * DOM/DOMFileList.mm:
1296         * DOM/DOMHTML.mm:
1297         * DOM/DOMHTMLAnchorElement.mm:
1298         * DOM/DOMHTMLAppletElement.mm:
1299         * DOM/DOMHTMLAreaElement.mm:
1300         * DOM/DOMHTMLBRElement.mm:
1301         * DOM/DOMHTMLBaseElement.mm:
1302         * DOM/DOMHTMLBaseFontElement.mm:
1303         * DOM/DOMHTMLBodyElement.mm:
1304         * DOM/DOMHTMLButtonElement.mm:
1305         * DOM/DOMHTMLCanvasElement.mm:
1306         * DOM/DOMHTMLCollection.mm:
1307         * DOM/DOMHTMLDListElement.mm:
1308         * DOM/DOMHTMLDirectoryElement.mm:
1309         * DOM/DOMHTMLDivElement.mm:
1310         * DOM/DOMHTMLDocument.mm:
1311         * DOM/DOMHTMLElement.mm:
1312         * DOM/DOMHTMLEmbedElement.mm:
1313         * DOM/DOMHTMLFieldSetElement.mm:
1314         * DOM/DOMHTMLFontElement.mm:
1315         * DOM/DOMHTMLFormElement.mm:
1316         * DOM/DOMHTMLFrameElement.mm:
1317         * DOM/DOMHTMLFrameSetElement.mm:
1318         * DOM/DOMHTMLHRElement.mm:
1319         * DOM/DOMHTMLHeadElement.mm:
1320         * DOM/DOMHTMLHeadingElement.mm:
1321         * DOM/DOMHTMLHtmlElement.mm:
1322         * DOM/DOMHTMLIFrameElement.mm:
1323         * DOM/DOMHTMLImageElement.mm:
1324         * DOM/DOMHTMLInputElement.mm:
1325         * DOM/DOMHTMLLIElement.mm:
1326         * DOM/DOMHTMLLabelElement.mm:
1327         * DOM/DOMHTMLLegendElement.mm:
1328         * DOM/DOMHTMLLinkElement.mm:
1329         * DOM/DOMHTMLMapElement.mm:
1330         * DOM/DOMHTMLMarqueeElement.mm:
1331         * DOM/DOMHTMLMediaElement.mm:
1332         * DOM/DOMHTMLMenuElement.mm:
1333         * DOM/DOMHTMLMetaElement.mm:
1334         * DOM/DOMHTMLModElement.mm:
1335         * DOM/DOMHTMLOListElement.mm:
1336         * DOM/DOMHTMLObjectElement.mm:
1337         * DOM/DOMHTMLOptGroupElement.mm:
1338         * DOM/DOMHTMLOptionElement.mm:
1339         * DOM/DOMHTMLOptionsCollection.mm:
1340         * DOM/DOMHTMLParagraphElement.mm:
1341         * DOM/DOMHTMLParamElement.mm:
1342         * DOM/DOMHTMLPreElement.mm:
1343         * DOM/DOMHTMLQuoteElement.mm:
1344         * DOM/DOMHTMLScriptElement.mm:
1345         * DOM/DOMHTMLSelectElement.mm:
1346         * DOM/DOMHTMLStyleElement.mm:
1347         * DOM/DOMHTMLTableCaptionElement.mm:
1348         * DOM/DOMHTMLTableCellElement.mm:
1349         * DOM/DOMHTMLTableColElement.mm:
1350         * DOM/DOMHTMLTableElement.mm:
1351         * DOM/DOMHTMLTableRowElement.mm:
1352         * DOM/DOMHTMLTableSectionElement.mm:
1353         * DOM/DOMHTMLTextAreaElement.mm:
1354         * DOM/DOMHTMLTitleElement.mm:
1355         * DOM/DOMHTMLUListElement.mm:
1356         * DOM/DOMHTMLVideoElement.mm:
1357         * DOM/DOMImplementation.mm:
1358         * DOM/DOMKeyboardEvent.mm:
1359         * DOM/DOMMediaError.mm:
1360         * DOM/DOMMediaList.mm:
1361         * DOM/DOMMouseEvent.mm:
1362         * DOM/DOMMutationEvent.mm:
1363         * DOM/DOMNamedNodeMap.mm:
1364         * DOM/DOMNode.mm:
1365         * DOM/DOMNodeIterator.mm:
1366         * DOM/DOMNodeList.mm:
1367         * DOM/DOMOverflowEvent.mm:
1368         * DOM/DOMProcessingInstruction.mm:
1369         * DOM/DOMProgressEvent.mm:
1370         * DOM/DOMRGBColor.mm:
1371         * DOM/DOMRange.mm:
1372         * DOM/DOMRect.mm:
1373         * DOM/DOMStyleSheet.mm:
1374         * DOM/DOMStyleSheetList.mm:
1375         * DOM/DOMText.mm:
1376         * DOM/DOMTextEvent.mm:
1377         * DOM/DOMTimeRanges.mm:
1378         * DOM/DOMTokenList.mm:
1379         * DOM/DOMTreeWalker.mm:
1380         * DOM/DOMUIEvent.mm:
1381         * DOM/DOMWheelEvent.mm:
1382         * DOM/DOMXPathExpression.mm:
1383         * DOM/DOMXPathResult.mm:
1384         * DOM/ObjCEventListener.mm:
1385
1386 2018-08-03  Alex Christensen  <achristensen@webkit.org>
1387
1388         Fix spelling of "overridden"
1389         https://bugs.webkit.org/show_bug.cgi?id=188315
1390
1391         Reviewed by Darin Adler.
1392
1393         * Misc/WebKitVersionChecks.mm:
1394         (setWebKitLinkTimeVersion):
1395         (WebKitLinkTimeVersion):
1396         * Plugins/WebBaseNetscapePluginView.mm:
1397         (-[WebBaseNetscapePluginView handleMouseMoved:]):
1398         * WebCoreSupport/PopupMenuMac.mm:
1399         (PopupMenuMac::populate):
1400
1401 2018-08-01  Nan Wang  <n_wang@apple.com>
1402
1403         AX: AOM: Add ARIA IDL Attribute Reflection
1404         https://bugs.webkit.org/show_bug.cgi?id=184676
1405         <rdar://problem/39476882>
1406
1407         Reviewed by Chris Fleizach.
1408
1409         * WebView/WebPreferenceKeysPrivate.h:
1410         * WebView/WebPreferences.mm:
1411         (+[WebPreferences initialize]):
1412         (-[WebPreferences ariaReflectionEnabled]):
1413         (-[WebPreferences setAriaReflectionEnabled:]):
1414         * WebView/WebPreferencesPrivate.h:
1415         * WebView/WebView.mm:
1416         (-[WebView _preferencesChanged:]):
1417
1418 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
1419
1420         Shrink GraphicsLayerCA
1421         https://bugs.webkit.org/show_bug.cgi?id=188141
1422
1423         Reviewed by Zalan Bujtas.
1424
1425         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
1426         * moving all the clone-related stuff into the lazily-allocated m_layerClones
1427         * moving all the animation-related stuff into the lazily-allocated m_animations
1428         * making enums be 8-bit
1429         * re-ordering data members
1430
1431         * WebView/WebView.mm:
1432         (-[WebView _setMediaLayer:forPluginView:]):
1433
1434 2018-07-30  Rob Buis  <rbuis@igalia.com>
1435
1436         Merge PlatformCookieJar functions into NetworkStorageSession
1437         https://bugs.webkit.org/show_bug.cgi?id=188137
1438
1439         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1440
1441         Reviewed by Alex Christensen.
1442
1443         * WebCoreSupport/WebPlatformStrategies.mm:
1444         (WebPlatformStrategies::cookiesForDOM):
1445         (WebPlatformStrategies::setCookiesFromDOM):
1446         (WebPlatformStrategies::cookiesEnabled):
1447         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1448         (WebPlatformStrategies::getRawCookies):
1449         (WebPlatformStrategies::deleteCookie):
1450         * WebView/WebPreferences.mm:
1451         (+[WebPreferences _clearNetworkLoaderSession]):
1452
1453 2018-07-28  Darin Adler  <darin@apple.com>
1454
1455         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
1456         https://bugs.webkit.org/show_bug.cgi?id=188140
1457
1458         Reviewed by Sam Weinig.
1459
1460         * WebView/WebImmediateActionController.mm:
1461         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
1462         new DictionaryLookup function that returns a tuple instead of using an out argument.
1463
1464 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
1465
1466         [INTL] Remove INTL sub-feature compile flags
1467         https://bugs.webkit.org/show_bug.cgi?id=188081
1468
1469         Reviewed by Michael Catanzaro.
1470
1471         * Configurations/FeatureDefines.xcconfig:
1472
1473 2018-07-26  Commit Queue  <commit-queue@webkit.org>
1474
1475         Unreviewed, rolling out r234181 and r234189.
1476         https://bugs.webkit.org/show_bug.cgi?id=188075
1477
1478         These are not needed right now (Requested by thorton on
1479         #webkit).
1480
1481         Reverted changesets:
1482
1483         "Enable Web Content Filtering on watchOS"
1484         https://bugs.webkit.org/show_bug.cgi?id=187979
1485         https://trac.webkit.org/changeset/234181
1486
1487         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
1488         https://bugs.webkit.org/show_bug.cgi?id=187985
1489         https://trac.webkit.org/changeset/234189
1490
1491 2018-07-26  Timothy Hatcher  <timothy@apple.com>
1492
1493         Use the Page's appearance when converting pasteboard attributed strings.
1494         https://bugs.webkit.org/show_bug.cgi?id=188067
1495         rdar://problem/42632246
1496
1497         Reviewed by Wenson Hsieh.
1498
1499         * WebCoreSupport/WebEditorClient.mm:
1500         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
1501
1502 2018-07-25  Chris Dumez  <cdumez@apple.com>
1503
1504         navigator.userAgent may return outdated value after webView.customUserAgent is set
1505         https://bugs.webkit.org/show_bug.cgi?id=188009
1506         <rdar://problem/42566456>
1507
1508         Reviewed by Alex Christensen.
1509
1510         Let the page know when the user agent changes.
1511
1512         * WebView/WebView.mm:
1513         (-[WebView _preferencesChanged:]):
1514         (-[WebView setApplicationNameForUserAgent:]):
1515         (-[WebView _invalidateUserAgentCache]):
1516         (-[WebView setCustomUserAgent:]):
1517         * WebView/WebViewInternal.h:
1518
1519 2018-07-24  Tim Horton  <timothy_horton@apple.com>
1520
1521         Enable Web Content Filtering on watchOS
1522         https://bugs.webkit.org/show_bug.cgi?id=187979
1523         <rdar://problem/42559346>
1524
1525         Reviewed by Wenson Hsieh.
1526
1527         * Configurations/FeatureDefines.xcconfig:
1528
1529 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
1530
1531         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
1532         https://bugs.webkit.org/show_bug.cgi?id=187846
1533
1534         Reviewed by Simon Fraser.
1535
1536         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
1537
1538         * WebView/WebHTMLView.mm:
1539         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
1540         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
1541
1542 2018-07-11  Dean Jackson  <dino@apple.com>
1543
1544         Allow removal of white backgrounds
1545         https://bugs.webkit.org/show_bug.cgi?id=187574
1546         <rdar://problem/41146792>
1547
1548         Reviewed by Simon Fraser.
1549
1550         Add a new WebPreference for punching out white backgrounds.
1551
1552         * WebView/WebPreferenceKeysPrivate.h:
1553         * WebView/WebPreferences.mm:
1554         (+[WebPreferences initialize]):
1555         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
1556         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
1557         * WebView/WebPreferencesPrivate.h:
1558         * WebView/WebView.mm:
1559         (-[WebView _preferencesChanged:]):
1560
1561 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
1562
1563         Ensure WebKit stack is ad-hoc signed
1564         https://bugs.webkit.org/show_bug.cgi?id=187667
1565
1566         Reviewed by Alexey Proskuryakov.
1567
1568         * Configurations/Base.xcconfig:
1569
1570 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
1571
1572         REGRESSION (231276): Attempting to copy an image fails
1573         https://bugs.webkit.org/show_bug.cgi?id=187212
1574         <rdar://problem/41540074>
1575
1576         Reviewed by Ryosuke Niwa.
1577
1578         Renamed methods to make it clear that one URL and one title are being passed in.
1579
1580         * WebCoreSupport/WebPlatformStrategies.h:
1581         * WebCoreSupport/WebPlatformStrategies.mm:
1582         (WebPlatformStrategies::setURL):
1583
1584 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1585
1586         Disable cross-origin-window-policy by default
1587         https://bugs.webkit.org/show_bug.cgi?id=187509
1588
1589         Reviewed by Chris Dumez.
1590
1591         * WebView/WebPreferences.mm:
1592         (+[WebPreferences initialize]):
1593
1594 2018-07-09  Timothy Hatcher  <timothy@apple.com>
1595
1596         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
1597         https://bugs.webkit.org/show_bug.cgi?id=187425
1598         rdar://problem/39948240
1599
1600         Reviewed by Tim Horton.
1601
1602         * WebView/WebView.mm:
1603         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
1604         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
1605         a call in this method to setUseDarkAppearance.
1606         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
1607         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
1608         (-[WebView _updateDefaultAppearance]): Deleted.
1609         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
1610
1611 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
1612
1613         Shrink various loading-related enums to shrink CachedResource
1614         https://bugs.webkit.org/show_bug.cgi?id=187443
1615
1616         Reviewed by Chris Dumez.
1617
1618         * WebCoreSupport/WebFrameLoaderClient.mm:
1619         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1620         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1621         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1622         (WebFrameLoaderClient::dispatchWillSendRequest):
1623         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1624         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1625         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1626         (WebFrameLoaderClient::updateGlobalHistory):
1627         (WebFrameLoaderClient::canHandleRequest const):
1628         * WebView/WebDataSource.mm:
1629         (-[WebDataSource initialRequest]):
1630         (-[WebDataSource request]):
1631
1632 2018-07-09  Commit Queue  <commit-queue@webkit.org>
1633
1634         Unreviewed, rolling out r233612.
1635         https://bugs.webkit.org/show_bug.cgi?id=187475
1636
1637         Revision caused the api test LinkColorWithSystemAppearance to
1638         fail on all systems. (Requested by Truitt on #webkit).
1639
1640         Reverted changeset:
1641
1642         "Semantic colors don't update when accessibility Increase
1643         Contrast mode is enabled."
1644         https://bugs.webkit.org/show_bug.cgi?id=187425
1645         https://trac.webkit.org/changeset/233612
1646
1647 2018-07-06  Timothy Hatcher  <timothy@apple.com>
1648
1649         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
1650         https://bugs.webkit.org/show_bug.cgi?id=187425
1651         rdar://problem/39948240
1652
1653         Reviewed by Tim Horton.
1654
1655         * WebView/WebView.mm:
1656         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
1657         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
1658         a call in this method to setUseDarkAppearance.
1659         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
1660         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
1661         (-[WebView _updateDefaultAppearance]): Deleted.
1662         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
1663
1664 2018-07-05  Timothy Hatcher  <timothy@apple.com>
1665
1666         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
1667         https://bugs.webkit.org/show_bug.cgi?id=187369
1668         rdar://problem/41870420
1669
1670         Reviewed by Tim Horton.
1671
1672         * WebView/WebMediaPlaybackTargetPicker.mm:
1673         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
1674         * WebView/WebView.mm:
1675         (-[WebView _commonInitializationWithFrameName:groupName:]):
1676         (-[WebView _effectiveAppearanceIsDark]):
1677         (-[WebView _updateDefaultAppearance]):
1678         (-[WebView _defaultAppearance]): Deleted.
1679
1680 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
1681
1682         Youtube video pages crash after a couple of minutes
1683         https://bugs.webkit.org/show_bug.cgi?id=187316
1684
1685         Reviewed by Antti Koivisto.
1686
1687         * WebView/WebView.mm:
1688         (-[WebView _preferencesChanged:]):
1689
1690 2018-07-04  Tim Horton  <timothy_horton@apple.com>
1691
1692         Introduce PLATFORM(IOSMAC)
1693         https://bugs.webkit.org/show_bug.cgi?id=187315
1694
1695         Reviewed by Dan Bernstein.
1696
1697         * Configurations/Base.xcconfig:
1698         * Configurations/FeatureDefines.xcconfig:
1699
1700 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1701
1702         [iOS] DataTransfer.getData always returns the empty string when dropping text
1703         https://bugs.webkit.org/show_bug.cgi?id=187130
1704         <rdar://problem/41014117>
1705
1706         Reviewed by Ryosuke Niwa.
1707
1708         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
1709
1710         * WebCoreSupport/WebPlatformStrategies.h:
1711         * WebCoreSupport/WebPlatformStrategies.mm:
1712         (WebPlatformStrategies::allPasteboardItemInfo):
1713
1714 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
1715
1716         [Mac] AirPlay picker uses incorrect theme in Dark mode
1717         https://bugs.webkit.org/show_bug.cgi?id=187054
1718         <rdar://problem/41291093>
1719
1720         Reviewed by Timothy Hatcher.
1721
1722         * WebView/WebMediaPlaybackTargetPicker.mm:
1723         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
1724
1725 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1726
1727         [WTF] Add user-defined literal for ASCIILiteral
1728         https://bugs.webkit.org/show_bug.cgi?id=186839
1729
1730         Reviewed by Darin Adler.
1731
1732         * DOM/ExceptionHandlers.mm:
1733         (raiseDOMErrorException):
1734         * Plugins/Hosted/ProxyInstance.mm:
1735         (WebKit::ProxyInstance::invokeMethod):
1736         * Storage/WebDatabaseProvider.mm:
1737         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
1738
1739 2018-06-22  Timothy Hatcher  <timothy@apple.com>
1740
1741         Recalc styles every time defaultAppearance changes.
1742         https://bugs.webkit.org/show_bug.cgi?id=186866
1743         rdar://problem/41309805
1744
1745         Reviewed by Tim Horton.
1746
1747         * WebView/WebView.mm:
1748         (-[WebView _updateDefaultAppearance]):
1749         (-[WebView _setUseSystemAppearance:]):
1750         (-[WebView _useSystemAppearance]):
1751
1752 2018-06-20  Darin Adler  <darin@apple.com>
1753
1754         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
1755         https://bugs.webkit.org/show_bug.cgi?id=186875
1756
1757         Reviewed by Anders Carlsson.
1758
1759         * WebView/WebHTMLView.mm:
1760         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
1761         to write te file to.
1762         * WebView/WebPreferences.mm:
1763         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
1764         * WebView/WebView.mm:
1765         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
1766
1767 2018-06-12  Darin Adler  <darin@apple.com>
1768
1769         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
1770         https://bugs.webkit.org/show_bug.cgi?id=186526
1771
1772         Reviewed by Anders Carlsson.
1773
1774         * Plugins/Hosted/NetscapePluginHostManager.mm:
1775         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
1776
1777         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1778         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
1779         assignment rather than adoptNS/leakRef.
1780         * Plugins/WebNetscapePluginView.mm:
1781         (-[WebNetscapePluginView createPlugin]): Ditto.
1782
1783         * WebCoreSupport/WebContextMenuClient.mm:
1784         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
1785         RetainPtr::autorelease; no need to autorelease just to pass something as a function
1786         argument, so use RetainPtr::get instead.
1787
1788         * WebView/WebHTMLView.mm:
1789         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
1790         No need to autorelease the result when the return type is RetainPtr.
1791
1792         * WebView/WebPDFRepresentation.mm:
1793         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
1794
1795 2018-06-13  Youenn Fablet  <youenn@apple.com>
1796
1797         Supported plugin check should be based on plugin identifier
1798         https://bugs.webkit.org/show_bug.cgi?id=186578
1799         <rdar://problem/40523828>
1800
1801         Reviewed by Darin Adler.
1802
1803         * WebCoreSupport/WebPluginInfoProvider.h:
1804         * WebCoreSupport/WebPluginInfoProvider.mm:
1805         (WebPluginInfoProvider::pluginInfo):
1806         (WebPluginInfoProvider::webVisiblePluginInfo):
1807
1808 2018-06-13  Chris Dumez  <cdumez@apple.com>
1809
1810         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1811         https://bugs.webkit.org/show_bug.cgi?id=186545
1812
1813         Reviewed by Brady Eidson.
1814
1815         Update client delegate now that parameter type has changed.
1816
1817         * WebCoreSupport/WebFrameLoaderClient.h:
1818         * WebCoreSupport/WebFrameLoaderClient.mm:
1819         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1820
1821 2018-06-11  Tim Horton  <timothy_horton@apple.com>
1822
1823         Link drag image is inconsistently unreadable in dark mode
1824         https://bugs.webkit.org/show_bug.cgi?id=186472
1825
1826         Reviewed by Timothy Hatcher.
1827
1828         * WebView/WebView.mm:
1829         (-[WebView _defaultAppearance]):
1830         Make defaultAppearance accurate even if useSystemAppearance is false.
1831         Some parts of WebKit (like the link drag image, but also context menus)
1832         want to be able to follow the system appearance regardless of whether
1833         the view or content has opted in.
1834
1835 2018-06-11  Chris Dumez  <cdumez@apple.com>
1836
1837         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
1838         https://bugs.webkit.org/show_bug.cgi?id=186441
1839
1840         Reviewed by Brady Eidson.
1841
1842         Rename existing flag to something a bit more generic, now that it is used for
1843         more things than bypassing the navigation policy check.
1844
1845         * WebView/WebView.mm:
1846         (-[WebView _loadBackForwardListFromOtherView:]):
1847         (-[WebView goToBackForwardItem:]):
1848
1849 2018-06-09  Dan Bernstein  <mitz@apple.com>
1850
1851         [Xcode] Clean up and modernize some build setting definitions
1852         https://bugs.webkit.org/show_bug.cgi?id=186463
1853
1854         Reviewed by Sam Weinig.
1855
1856         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
1857         * Configurations/DebugRelease.xcconfig: Ditto.
1858         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
1859           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
1860         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
1861         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
1862           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
1863         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
1864
1865 2018-06-08  Darin Adler  <darin@apple.com>
1866
1867         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
1868         https://bugs.webkit.org/show_bug.cgi?id=186436
1869
1870         Reviewed by Anders Carlsson.
1871
1872         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
1873         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
1874         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
1875         (PoolCleaner): Ditto.
1876
1877         * History/WebHistory.mm:
1878         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1879         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
1880         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
1881         now hardly used if at all.
1882         * WebView/WebView.mm:
1883         (-[WebView rectsForTextMatches]): Ditto.
1884
1885 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1886
1887         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
1888         https://bugs.webkit.org/show_bug.cgi?id=186442
1889         <rdar://problem/40879364>
1890
1891         Reviewed by Tim Horton.
1892
1893         * Configurations/FeatureDefines.xcconfig:
1894
1895 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
1896
1897         [Datalist] Allow TextFieldInputType to show and hide suggestions
1898         https://bugs.webkit.org/show_bug.cgi?id=186151
1899
1900         Reviewed by Tim Horton.
1901
1902         * WebCoreSupport/WebChromeClient.h:
1903         * WebCoreSupport/WebChromeClient.mm:
1904         (WebChromeClient::createDataListSuggestionPicker):
1905
1906 2018-06-07  Chris Dumez  <cdumez@apple.com>
1907
1908         Add base class to get WeakPtrFactory member and avoid some boilerplate code
1909         https://bugs.webkit.org/show_bug.cgi?id=186407
1910
1911         Reviewed by Brent Fulgham.
1912
1913         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
1914         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
1915         This also gets rid of old-style createWeakPtr() methods in favor of the newer
1916         makeWeakPtr().
1917
1918         * WebCoreSupport/WebEditorClient.h:
1919         * WebCoreSupport/WebEditorClient.mm:
1920         (WebEditorClient::requestCandidatesForSelection):
1921
1922 2018-06-05  Chris Dumez  <cdumez@apple.com>
1923
1924         Regression(r232082): Websites get loaded inside of Messages App chat transcript
1925         https://bugs.webkit.org/show_bug.cgi?id=186331
1926         <rdar://problem/40735446>
1927
1928         Reviewed by Darin Adler.
1929
1930         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
1931         but does not call use / ignore on the listener, then we would do "use" by default.
1932         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
1933         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
1934         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
1935         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
1936         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
1937         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
1938         and Box.app is still working properly.
1939
1940         * WebCoreSupport/WebFrameLoaderClient.h:
1941         * WebCoreSupport/WebFrameLoaderClient.mm:
1942         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1943         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1944         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1945         (WebFrameLoaderClient::dispatchWillSubmitForm):
1946         (WebFrameLoaderClient::setUpPolicyListener):
1947         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
1948         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
1949         (-[WebFramePolicyListener dealloc]):
1950         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
1951         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
1952
1953 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
1954
1955         Adjust compile and runtime flags to match shippable state of features
1956         https://bugs.webkit.org/show_bug.cgi?id=186319
1957         <rdar://problem/40352045>
1958
1959         Reviewed by Maciej Stachowiak, Jon Lee, and others.
1960
1961         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
1962         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
1963         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
1964         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
1965         Cocoa builds.
1966
1967 2018-06-05  Timothy Hatcher  <timothy@apple.com>
1968
1969         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
1970
1971         https://bugs.webkit.org/show_bug.cgi?id=186323
1972         rdar://problem/38382252
1973
1974         Reviewed by Tim Horton.
1975
1976         * WebView/WebView.mm:
1977         (-[WebView _defaultAppearance]):
1978
1979 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
1980
1981         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
1982         https://bugs.webkit.org/show_bug.cgi?id=186286
1983         <rdar://problem/40782992>
1984
1985         Reviewed by Dan Bernstein.
1986
1987         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
1988         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
1989         change this flag when preparing for a production release.
1990
1991         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
1992         whether experimental features should be enabled, and use it to properly define the
1993         feature flag.
1994
1995 2018-06-03  Darin Adler  <darin@apple.com>
1996
1997         Simplify and remove some unused video element code (helpful for ARC-compatibility)
1998         https://bugs.webkit.org/show_bug.cgi?id=186258
1999
2000         Reviewed by Daniel Bates.
2001
2002         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
2003         forward declarations. Removed methods that don't need to be public.
2004
2005         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
2006         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
2007         unnamed category in here and also replaced the HUDWindowControllerDelegate
2008         with the unnamed category. Removed unused NSWindow category defining the
2009         isOnActiveSpace, which is not called anywhere in this file at this time.
2010         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
2011         into setVideoElement.
2012         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
2013         and removed unneeded typecast.
2014         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
2015         using statement at the top of the file.
2016         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
2017         the many side effects and special considerations that this method that sounds
2018         like a setter has. Updated code to use the new
2019         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
2020         HTMLVideoElement::platformMedia function. Also straightened out the logic a
2021         bit and added some FIXME comments about small problems noticed but not fixed.
2022         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
2023         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
2024         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
2025         typecast. Removed call to updatePowerAssertions method.
2026         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
2027         updatePowerAssertions method.
2028         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
2029         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
2030         else, so this was dead code that did nothing.
2031         (-[WebVideoFullscreenController rateChanged:]): Removed call to
2032         updatePowerAssertions method.
2033
2034 2018-06-04  Chris Dumez  <cdumez@apple.com>
2035
2036         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
2037         https://bugs.webkit.org/show_bug.cgi?id=186287
2038         <rdar://problem/40783352>
2039
2040         Reviewed by Youenn Fablet.
2041
2042         * WebView/WebPreferenceKeysPrivate.h:
2043         * WebView/WebPreferences.mm:
2044         (+[WebPreferences initialize]):
2045         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
2046         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
2047         * WebView/WebPreferencesPrivate.h:
2048         * WebView/WebView.mm:
2049         (-[WebView _preferencesChanged:]):
2050
2051 2018-06-02  Darin Adler  <darin@apple.com>
2052
2053         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
2054         https://bugs.webkit.org/show_bug.cgi?id=186227
2055
2056         Reviewed by Dan Bernstein.
2057
2058         * Misc/WebKitErrors.m:
2059         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
2060         * Plugins/WebPluginDatabase.mm:
2061         (-[WebPluginDatabase refresh]): Ditto.
2062         * WebCoreSupport/WebChromeClient.mm:
2063         (WebChromeClient::setStatusbarText): Ditto.
2064
2065 2018-06-01  Chris Dumez  <cdumez@apple.com>
2066
2067         REGRESSION (r231456): Colloquy is broken
2068         https://bugs.webkit.org/show_bug.cgi?id=186197
2069         <rdar://problem/40722960>
2070
2071         Reviewed by Timothy Hatcher.
2072
2073         Restore pre-r231456 behavior for Colloquy app so that it works again.
2074
2075         * WebView/WebView.mm:
2076         (-[WebView _needsFrameNameFallbackToIdQuirk]):
2077         (-[WebView _preferencesChanged:]):
2078
2079 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
2080
2081         [JSC] Pass VM& parameter as much as possible
2082         https://bugs.webkit.org/show_bug.cgi?id=186085
2083
2084         Reviewed by Saam Barati.
2085
2086         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2087         (WebKit::NetscapePluginInstanceProxy::invoke):
2088
2089 2018-05-30  Daniel Bates  <dabates@apple.com>
2090
2091         NavigationAction does not need to hold initiating DOM Event
2092         https://bugs.webkit.org/show_bug.cgi?id=185958
2093         <rdar://problem/40531539>
2094
2095         Reviewed by Simon Fraser.
2096
2097         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
2098
2099         * WebCoreSupport/WebFrameLoaderClient.mm:
2100         (WebFrameLoaderClient::actionDictionary const):
2101         (findMouseEvent): Deleted.
2102
2103 2018-05-27  Dan Bernstein  <mitz@apple.com>
2104
2105         Reverted the changes made for https://webkit.org/b/186016
2106
2107         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
2108
2109
2110 2018-05-27  David Kilzer  <ddkilzer@apple.com>
2111
2112         [iOS] Fix warnings about leaks found by clang static analyzer
2113         <https://webkit.org/b/186009>
2114         <rdar://problem/40574267>
2115
2116         Reviewed by Daniel Bates.
2117
2118         * WebView/WebHTMLView.mm:
2119         (-[WebHTMLView doCommandBySelector:]): Fix use of an
2120         uninitialized boolean variable (`eventWasHandled`) that only
2121         happened on iOS.
2122
2123 2018-05-27  Dan Bernstein  <mitz@apple.com>
2124
2125         [Cocoa] Avoid importing directly from subumbrella frameworks
2126         https://bugs.webkit.org/show_bug.cgi?id=186016
2127
2128         Reviewed by Sam Weinig.
2129
2130         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
2131         * Carbon/CarbonWindowAdapter.mm: Ditto.
2132         * Carbon/CarbonWindowFrame.m: Ditto.
2133         * Carbon/HIViewAdapter.h: Ditto.
2134         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
2135           OTHER_CPLUSPLUSFLAGS.
2136         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
2137         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
2138         * WebView/WebPDFView.h: Ditto.
2139
2140 2018-05-27  Sam Weinig  <sam@webkit.org>
2141
2142         Modernize RenderStyleConstants.h - Part 3
2143         https://bugs.webkit.org/show_bug.cgi?id=186015
2144
2145         Reviewed by Yusuke Suzuki.
2146
2147         * WebView/WebView.mm:
2148         (-[WebView updateTextTouchBar]):
2149         Update for new enum name.
2150
2151 2018-05-25  Chris Dumez  <cdumez@apple.com>
2152
2153         Minor ApplicationCacheStorage clean up
2154         https://bugs.webkit.org/show_bug.cgi?id=185984
2155
2156         Reviewed by Youenn Fablet.
2157
2158         * WebCoreSupport/WebApplicationCache.mm:
2159         (+[WebApplicationCache originsWithCache]):
2160
2161 2018-05-25  David Kilzer  <ddkilzer@apple.com>
2162
2163         Fix issues with -dealloc methods found by clang static analyzer
2164         <https://webkit.org/b/185887>
2165
2166         Reviewed by Joseph Pecoraro.
2167
2168         * WebView/WebView.mm:
2169         (-[WebUITextIndicatorData dealloc]):
2170         - Move method implementation from (WebUITextIndicatorInternal)
2171           category to the main category since this is public API.  This
2172           fixes the false positive warning about a missing -dealloc
2173           method.
2174
2175 2018-05-24  Sam Weinig  <sam@webkit.org>
2176
2177         Modernize RenderStyleConstants.h - Part 2
2178         https://bugs.webkit.org/show_bug.cgi?id=185901
2179
2180         Reviewed by Simon Fraser.
2181
2182         * WebView/WebHTMLRepresentation.mm:
2183         (searchForLabelsBeforeElement):
2184         * WebView/WebView.mm:
2185         (nsTextAlignmentFromRenderStyle):
2186         Update for new enum names.
2187
2188 2018-05-22  Chris Dumez  <cdumez@apple.com>
2189
2190         Regression(AsyncPolicyDelegates): Box.app login Window is blank
2191         https://bugs.webkit.org/show_bug.cgi?id=185832
2192         <rdar://problem/40307871>
2193
2194         Reviewed by Geoffrey Garen.
2195
2196         We used to have a bug where where we would fail to wait for the policy decision for
2197         the navigation response from the client and the load would keep going, racing with
2198         the client's policy decision. If the client did not respond in time, the behavior
2199         would be the same as "Use" policy action.
2200
2201         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
2202         but the load happened to proceed anyway due to our bug. Now that we've fixed the
2203         WebKit bug, however, the load would hang because the completion handler for the
2204         decidePolicyForNavigationResponse would never get called.
2205
2206         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
2207         instead of retaining it. If the policy listener object gets destroyed because getting
2208         resolved, we now use "Use" policy action in its dealloc function to maintain previous
2209         behavior.
2210
2211         * WebCoreSupport/WebFrameLoaderClient.h:
2212         * WebCoreSupport/WebFrameLoaderClient.mm:
2213         (WebFrameLoaderClient::cancelPolicyCheck):
2214         (WebFrameLoaderClient::setUpPolicyListener):
2215         (-[WebFramePolicyListener dealloc]):
2216
2217 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
2218
2219         Unreviewed, rolling out r232052.
2220
2221         Breaks internal builds.
2222
2223         Reverted changeset:
2224
2225         "Use more C++17"
2226         https://bugs.webkit.org/show_bug.cgi?id=185176
2227         https://trac.webkit.org/changeset/232052
2228
2229 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2230
2231         Use more C++17
2232         https://bugs.webkit.org/show_bug.cgi?id=185176
2233
2234         Reviewed by JF Bastien.
2235
2236         * Configurations/Base.xcconfig:
2237         * Configurations/WebKitLegacy.xcconfig:
2238
2239 2018-05-21  Chris Nardi  <cnardi@chromium.org>
2240
2241         Remove dead exception in MediaList.appendMedium
2242         https://bugs.webkit.org/show_bug.cgi?id=185278
2243
2244         Reviewed by Chris Dumez.
2245
2246         Remove code pertaining to an exception being thrown by appendMedium().
2247
2248         * DOM/DOMMediaList.mm:
2249         (-[DOMMediaList appendMedium:]):
2250
2251 2018-05-21  Jer Noble  <jer.noble@apple.com>
2252
2253         Complete fix for enabling modern EME by default
2254         https://bugs.webkit.org/show_bug.cgi?id=185770
2255         <rdar://problem/40368220>
2256
2257         Reviewed by Eric Carlson.
2258
2259         * Configurations/FeatureDefines.xcconfig:
2260
2261 2018-05-21  Antti Koivisto  <antti@apple.com>
2262
2263         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
2264         https://bugs.webkit.org/show_bug.cgi?id=185815
2265         <rdar://problem/40310069>
2266
2267         Reviewed by Simon Fraser.
2268
2269         User stylesheet parsing may depend on the colorFilterEnabled preference.
2270
2271         * WebView/WebView.mm:
2272         (-[WebView _preferencesChanged:]):
2273
2274 2018-05-18  Commit Queue  <commit-queue@webkit.org>
2275
2276         Unreviewed, rolling out r231982.
2277         https://bugs.webkit.org/show_bug.cgi?id=185793
2278
2279         Caused layout test failures (Requested by realdawei on
2280         #webkit).
2281
2282         Reverted changeset:
2283
2284         "Complete fix for enabling modern EME by default"
2285         https://bugs.webkit.org/show_bug.cgi?id=185770
2286         https://trac.webkit.org/changeset/231982
2287
2288 2018-05-18  Jer Noble  <jer.noble@apple.com>
2289
2290         Complete fix for enabling modern EME by default
2291         https://bugs.webkit.org/show_bug.cgi?id=185770
2292         <rdar://problem/40368220>
2293
2294         Reviewed by Eric Carlson.
2295
2296         * Configurations/FeatureDefines.xcconfig:
2297
2298 2018-05-18  Chris Dumez  <cdumez@apple.com>
2299
2300         Avoid keeping the frame alive when ref'ing a WindowProxy
2301         https://bugs.webkit.org/show_bug.cgi?id=185737
2302         <rdar://problem/40004666>
2303
2304         Reviewed by Sam Weinig.
2305
2306         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2307         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2308
2309 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
2310
2311         Add support for Intl NumberFormat formatToParts
2312         https://bugs.webkit.org/show_bug.cgi?id=185375
2313
2314         Reviewed by Yusuke Suzuki.
2315
2316         Add flag for NumberFormat formatToParts.
2317
2318         * Configurations/FeatureDefines.xcconfig:
2319
2320 2018-05-16  Chris Nardi  <cnardi@chromium.org>
2321
2322         Fixup after r231849: Do not mark Mac API methods as deprecated
2323         https://bugs.webkit.org/show_bug.cgi?id=185684
2324
2325         Reviewed by Darin Adler.
2326
2327         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
2328         as the entire class is already marked as deprecated, so it is unnecessary.
2329
2330         * DOM/DOMDocument.h:
2331
2332 2018-05-16  Chris Nardi  <cnardi@chromium.org>
2333
2334         Remove Document#selectedStylesheetSet/preferredStylesheetSet
2335         https://bugs.webkit.org/show_bug.cgi?id=185381
2336
2337         Reviewed by Darin Adler.
2338
2339         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
2340         and make them do nothing.
2341
2342         * DOM/DOMDocument.h:
2343         * DOM/DOMDocument.mm:
2344         (-[DOMDocument preferredStylesheetSet]):
2345         (-[DOMDocument selectedStylesheetSet]):
2346         (-[DOMDocument setSelectedStylesheetSet:]):
2347
2348 2018-05-15  Antoine Quint  <graouts@apple.com>
2349
2350         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2351         https://bugs.webkit.org/show_bug.cgi?id=185647
2352
2353         Reviewed by Dean Jackson.
2354
2355         Rename the Web Animations CSS integration flag.
2356
2357         * WebView/WebPreferenceKeysPrivate.h:
2358         * WebView/WebPreferences.mm:
2359         (+[WebPreferences initialize]):
2360         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
2361         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
2362         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
2363         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
2364         * WebView/WebPreferencesPrivate.h:
2365         * WebView/WebView.mm:
2366         (-[WebView _preferencesChanged:]):
2367
2368 2018-05-14  Daniel Bates  <dabates@apple.com>
2369
2370         Fix the Apple Internal build
2371
2372         See <rdar://problem/40237873> for more details.
2373
2374         * WebView/WebFullScreenController.mm:
2375         (-[WebFullScreenController enterFullScreen:]):
2376         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2377         (-[WebFullScreenController exitFullScreen]):
2378         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2379         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2380         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2381
2382 2018-05-11  Timothy Hatcher  <timothy@apple.com>
2383
2384         WebHTMLView is not setting aside subviews when drawing.
2385
2386         https://bugs.webkit.org/show_bug.cgi?id=185561
2387         rdar://problem/40172894
2388
2389         Reviewed by Simon Fraser.
2390
2391         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
2392
2393         * WebView/WebHTMLView.mm:
2394         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
2395
2396 2018-05-07  Daniel Bates  <dabates@apple.com>
2397
2398         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
2399         https://bugs.webkit.org/show_bug.cgi?id=185170
2400
2401         Reviewed by Per Arne Vollan.
2402
2403         * Misc/WebCache.mm:
2404         (+[WebCache empty]):
2405
2406 2018-05-04  Timothy Hatcher  <timothy@apple.com>
2407
2408         Deprecate legacy WebView and friends
2409         https://bugs.webkit.org/show_bug.cgi?id=185279
2410         rdar://problem/33268700
2411
2412         Reviewed by Tim Horton.
2413
2414         Added deprecation macros to all the classes, extern strings, and enums.
2415
2416         * Configurations/WebKitLegacy.xcconfig:
2417         Added BUILDING_WEBKIT define to disable the deprecation macros.
2418         * DOM/DOMAbstractView.h:
2419         * DOM/DOMAttr.h:
2420         * DOM/DOMBlob.h:
2421         * DOM/DOMCDATASection.h:
2422         * DOM/DOMCSSCharsetRule.h:
2423         * DOM/DOMCSSFontFaceRule.h:
2424         * DOM/DOMCSSImportRule.h:
2425         * DOM/DOMCSSMediaRule.h:
2426         * DOM/DOMCSSPageRule.h:
2427         * DOM/DOMCSSPrimitiveValue.h:
2428         * DOM/DOMCSSRule.h:
2429         * DOM/DOMCSSRuleList.h:
2430         * DOM/DOMCSSStyleDeclaration.h:
2431         * DOM/DOMCSSStyleRule.h:
2432         * DOM/DOMCSSStyleSheet.h:
2433         * DOM/DOMCSSUnknownRule.h:
2434         * DOM/DOMCSSValue.h:
2435         * DOM/DOMCSSValueList.h:
2436         * DOM/DOMCharacterData.h:
2437         * DOM/DOMComment.h:
2438         * DOM/DOMCounter.h:
2439         * DOM/DOMDocument.h:
2440         * DOM/DOMDocumentFragment.h:
2441         * DOM/DOMDocumentType.h:
2442         * DOM/DOMElement.h:
2443         * DOM/DOMEntity.h:
2444         * DOM/DOMEntityReference.h:
2445         * DOM/DOMEvent.h:
2446         * DOM/DOMEventException.h:
2447         * DOM/DOMEventListener.h:
2448         * DOM/DOMEventTarget.h:
2449         * DOM/DOMException.h:
2450         * DOM/DOMFile.h:
2451         * DOM/DOMFileList.h:
2452         * DOM/DOMHTMLAnchorElement.h:
2453         * DOM/DOMHTMLAppletElement.h:
2454         * DOM/DOMHTMLAreaElement.h:
2455         * DOM/DOMHTMLBRElement.h:
2456         * DOM/DOMHTMLBaseElement.h:
2457         * DOM/DOMHTMLBaseFontElement.h:
2458         * DOM/DOMHTMLBodyElement.h:
2459         * DOM/DOMHTMLButtonElement.h:
2460         * DOM/DOMHTMLCanvasElement.h:
2461         * DOM/DOMHTMLCollection.h:
2462         * DOM/DOMHTMLDListElement.h:
2463         * DOM/DOMHTMLDirectoryElement.h:
2464         * DOM/DOMHTMLDivElement.h:
2465         * DOM/DOMHTMLDocument.h:
2466         * DOM/DOMHTMLElement.h:
2467         * DOM/DOMHTMLEmbedElement.h:
2468         * DOM/DOMHTMLFieldSetElement.h:
2469         * DOM/DOMHTMLFontElement.h:
2470         * DOM/DOMHTMLFormElement.h:
2471         * DOM/DOMHTMLFrameElement.h:
2472         * DOM/DOMHTMLFrameSetElement.h:
2473         * DOM/DOMHTMLHRElement.h:
2474         * DOM/DOMHTMLHeadElement.h:
2475         * DOM/DOMHTMLHeadingElement.h:
2476         * DOM/DOMHTMLHtmlElement.h:
2477         * DOM/DOMHTMLIFrameElement.h:
2478         * DOM/DOMHTMLImageElement.h:
2479         * DOM/DOMHTMLInputElement.h:
2480         * DOM/DOMHTMLLIElement.h:
2481         * DOM/DOMHTMLLabelElement.h:
2482         * DOM/DOMHTMLLegendElement.h:
2483         * DOM/DOMHTMLLinkElement.h:
2484         * DOM/DOMHTMLMapElement.h:
2485         * DOM/DOMHTMLMarqueeElement.h:
2486         * DOM/DOMHTMLMediaElement.h:
2487         * DOM/DOMHTMLMenuElement.h:
2488         * DOM/DOMHTMLMetaElement.h:
2489         * DOM/DOMHTMLModElement.h:
2490         * DOM/DOMHTMLOListElement.h:
2491         * DOM/DOMHTMLObjectElement.h:
2492         * DOM/DOMHTMLOptGroupElement.h:
2493         * DOM/DOMHTMLOptionElement.h:
2494         * DOM/DOMHTMLOptionsCollection.h:
2495         * DOM/DOMHTMLParagraphElement.h:
2496         * DOM/DOMHTMLParamElement.h:
2497         * DOM/DOMHTMLPreElement.h:
2498         * DOM/DOMHTMLQuoteElement.h:
2499         * DOM/DOMHTMLScriptElement.h:
2500         * DOM/DOMHTMLSelectElement.h:
2501         * DOM/DOMHTMLStyleElement.h:
2502         * DOM/DOMHTMLTableCaptionElement.h:
2503         * DOM/DOMHTMLTableCellElement.h:
2504         * DOM/DOMHTMLTableColElement.h:
2505         * DOM/DOMHTMLTableElement.h:
2506         * DOM/DOMHTMLTableRowElement.h:
2507         * DOM/DOMHTMLTableSectionElement.h:
2508         * DOM/DOMHTMLTextAreaElement.h:
2509         * DOM/DOMHTMLTitleElement.h:
2510         * DOM/DOMHTMLUListElement.h:
2511         * DOM/DOMHTMLVideoElement.h:
2512         * DOM/DOMImplementation.h:
2513         * DOM/DOMKeyboardEvent.h:
2514         * DOM/DOMMediaError.h:
2515         * DOM/DOMMediaList.h:
2516         * DOM/DOMMouseEvent.h:
2517         * DOM/DOMMutationEvent.h:
2518         * DOM/DOMNamedNodeMap.h:
2519         * DOM/DOMNode.h:
2520         * DOM/DOMNodeFilter.h:
2521         * DOM/DOMNodeIterator.h:
2522         * DOM/DOMNodeList.h:
2523         * DOM/DOMObject.h:
2524         * DOM/DOMOverflowEvent.h:
2525         * DOM/DOMProcessingInstruction.h:
2526         * DOM/DOMProgressEvent.h:
2527         * DOM/DOMRGBColor.h:
2528         * DOM/DOMRange.h:
2529         * DOM/DOMRangeException.h:
2530         * DOM/DOMRect.h:
2531         * DOM/DOMStyleSheet.h:
2532         * DOM/DOMStyleSheetList.h:
2533         * DOM/DOMText.h:
2534         * DOM/DOMTextEvent.h:
2535         * DOM/DOMTimeRanges.h:
2536         * DOM/DOMTokenList.h:
2537         * DOM/DOMTreeWalker.h:
2538         * DOM/DOMUIEvent.h:
2539         * DOM/DOMWheelEvent.h:
2540         * DOM/DOMXPathException.h:
2541         * DOM/DOMXPathExpression.h:
2542         * DOM/DOMXPathNSResolver.h:
2543         * DOM/DOMXPathResult.h:
2544         * History/WebBackForwardList.h:
2545         * History/WebHistory.h:
2546         * History/WebHistoryItem.h:
2547         * Misc/WebDownload.h:
2548         * Misc/WebKitErrors.h:
2549         * Plugins/WebPluginViewFactory.h:
2550         * WebView/WebArchive.h:
2551         * WebView/WebDataSource.h:
2552         * WebView/WebDocument.h:
2553         * WebView/WebEditingDelegate.h:
2554         * WebView/WebFormDelegate.h:
2555         * WebView/WebFrame.h:
2556         * WebView/WebFrameLoadDelegate.h:
2557         * WebView/WebFrameView.h:
2558         * WebView/WebPolicyDelegate.h:
2559         * WebView/WebPreferences.h:
2560         * WebView/WebPreferencesPrivate.h:
2561         * WebView/WebResourceLoadDelegate.h:
2562         * WebView/WebUIDelegate.h:
2563         * WebView/WebUIDelegatePrivate.h:
2564         * WebView/WebView.h:
2565         * WebView/WebViewPrivate.h:
2566         * postprocess-headers.sh:
2567         Remove step that converts WEBKIT macros to NS macros.
2568         Change it to just remove the macros on iOS builds.
2569
2570 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
2571
2572         [MediaStream] remove WK1 support
2573         https://bugs.webkit.org/show_bug.cgi?id=185136
2574
2575         Reviewed by Youenn Fablet.
2576
2577         * WebCoreSupport/WebUserMediaClient.h: Removed.
2578         * WebCoreSupport/WebUserMediaClient.mm: Removed.
2579         * WebView/WebView.mm:
2580         (-[WebView _commonInitializationWithFrameName:groupName:]):
2581         (-[WebView _preferencesChanged:]):
2582         (-[WebView _setUserMediaClient:]): Deleted.
2583         (-[WebView _userMediaClient]): Deleted.
2584         * WebView/WebViewData.h:
2585         * WebView/WebViewPrivate.h:
2586
2587 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
2588
2589         WebAssembly: add support for stream APIs - JavaScript API
2590         https://bugs.webkit.org/show_bug.cgi?id=183442
2591
2592         Reviewed by Yusuke Suzuki and JF Bastien.
2593
2594         Add WEBASSEMBLY_STREAMINNG_API feature flag
2595
2596         * Configurations/FeatureDefines.xcconfig:
2597
2598 2018-04-30  JF Bastien  <jfbastien@apple.com>
2599
2600         Use some C++17 features
2601         https://bugs.webkit.org/show_bug.cgi?id=185135
2602
2603         Reviewed by Alex Christensen.
2604
2605         * Configurations/WebKitLegacy.xcconfig:
2606
2607 2018-04-27  Chris Dumez  <cdumez@apple.com>
2608
2609         Use WindowProxy instead of DOMWindow in our IDL
2610         https://bugs.webkit.org/show_bug.cgi?id=185022
2611
2612         Reviewed by Sam Weinig.
2613
2614         * DOM/DOMAbstractView.mm:
2615         (kit):
2616         (toWindowProxy):
2617         * DOM/DOMAbstractViewInternal.h:
2618         * DOM/DOMDocument.mm:
2619         (-[DOMDocument defaultView]):
2620         (-[DOMDocument getComputedStyle:pseudoElement:]):
2621         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
2622         * DOM/DOMHTMLFrameElement.mm:
2623         (-[DOMHTMLFrameElement contentWindow]):
2624         * DOM/DOMHTMLIFrameElement.mm:
2625         (-[DOMHTMLIFrameElement contentWindow]):
2626         * DOM/DOMKeyboardEvent.mm:
2627         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
2628         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
2629         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
2630         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
2631         * DOM/DOMMouseEvent.mm:
2632         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
2633         * DOM/DOMTextEvent.mm:
2634         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
2635         * DOM/DOMUIEvent.mm:
2636         (-[DOMUIEvent view]):
2637         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
2638         * DOM/DOMWheelEvent.mm:
2639         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
2640
2641 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
2642
2643         Implement rendering support for the color-filter CSS property
2644         https://bugs.webkit.org/show_bug.cgi?id=185047
2645         rdar://problem/39664967
2646
2647         Reviewed by Tim Horton.
2648         
2649         The body background should reflect the filtered color.
2650
2651         * WebView/WebFrame.mm:
2652         (-[WebFrame _bodyBackgroundColor]):
2653         * WebView/WebView.mm:
2654         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
2655
2656 2018-04-26  Jer Noble  <jer.noble@apple.com>
2657
2658         WK_COCOA_TOUCH all the things.
2659         https://bugs.webkit.org/show_bug.cgi?id=185006
2660
2661         Reviewed by Tim Horton.
2662
2663         * Configurations/WebKitLegacy.xcconfig:
2664
2665 2018-04-26  Daniel Bates  <dabates@apple.com>
2666
2667         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
2668         https://bugs.webkit.org/show_bug.cgi?id=184161
2669         <rdar://problem/39051645>
2670
2671         Reviewed by Dan Bernstein.
2672
2673         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
2674         dropping a PDF embedded using an HTML image element into the same web view.
2675
2676         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
2677         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
2678         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
2679         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
2680         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
2681         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
2682         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
2683         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
2684         image document when navigated to directly. Since we can support dragging PDF document images we need to
2685         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
2686         We need to do both such queries before falling back to using the main resource of the Web Archive as
2687         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
2688         not an image document.
2689
2690         * Misc/WebNSPasteboardExtras.mm:
2691         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2692
2693 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
2694
2695         Disable content filtering in minimal simulator mode
2696         https://bugs.webkit.org/show_bug.cgi?id=185027
2697         <rdar://problem/39736091>
2698
2699         Reviewed by Jer Noble.
2700
2701         * Configurations/FeatureDefines.xcconfig:
2702
2703 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
2704
2705         [INTL] Implement Intl.PluralRules
2706         https://bugs.webkit.org/show_bug.cgi?id=184312
2707
2708         Reviewed by JF Bastien.
2709
2710         Added Intl.PluralRules feature flag.
2711
2712         * Configurations/FeatureDefines.xcconfig:
2713
2714 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
2715
2716         Remove access to keychain from the WebContent process
2717         https://bugs.webkit.org/show_bug.cgi?id=184428
2718         <rdar://problem/13150903>
2719
2720         Reviewed by Brent Fulgham.
2721
2722         This patch does the followings:
2723         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
2724         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
2725         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
2726
2727         * WebCoreSupport/WebChromeClient.h:
2728         * WebCoreSupport/WebChromeClient.mm:
2729         (WebChromeClient::signedPublicKeyAndChallengeString const):
2730         * WebView/WebUIDelegatePrivate.h:
2731
2732 2018-04-24  Jer Noble  <jer.noble@apple.com>
2733
2734         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
2735         https://bugs.webkit.org/show_bug.cgi?id=184786
2736
2737         Reviewed by Tim Horton.
2738
2739         * Configurations/WebKitLegacy.xcconfig:
2740         * MigrateHeaders.make:
2741
2742 2018-04-23  Daniel Bates  <dabates@apple.com>
2743
2744         Implement Same-Site cookies
2745         https://bugs.webkit.org/show_bug.cgi?id=159464
2746         <rdar://problem/27196358>
2747
2748         Reviewed by Brent Fulgham.
2749
2750         Pass the Same-Site info through the strategy.
2751
2752         * WebCoreSupport/WebPlatformStrategies.h:
2753         * WebCoreSupport/WebPlatformStrategies.mm:
2754         (WebPlatformStrategies::cookiesForDOM):
2755         (WebPlatformStrategies::setCookiesFromDOM):
2756         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2757         (WebPlatformStrategies::getRawCookies):
2758
2759 2018-04-23  Zalan Bujtas  <zalan@apple.com>
2760
2761         [LayoutFormattingContext] Initial commit.
2762         https://bugs.webkit.org/show_bug.cgi?id=184896
2763
2764         Reviewed by Antti Koivisto.
2765
2766         * Configurations/FeatureDefines.xcconfig:
2767
2768 2018-04-23  Daniel Bates  <dabates@apple.com>
2769
2770         Implement Same-Site cookies
2771         https://bugs.webkit.org/show_bug.cgi?id=159464
2772         <rdar://problem/27196358>
2773
2774         Reviewed by Brent Fulgham.
2775
2776         Pass the Same-Site info through the strategy.
2777
2778         * WebCoreSupport/WebPlatformStrategies.h:
2779         * WebCoreSupport/WebPlatformStrategies.mm:
2780         (WebPlatformStrategies::cookiesForDOM):
2781         (WebPlatformStrategies::setCookiesFromDOM):
2782         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2783         (WebPlatformStrategies::getRawCookies):
2784
2785 2018-04-20  Timothy Hatcher  <timothy@apple.com>
2786
2787         NULL dereference crash sometimes under [super initWithCoder:] in WebView
2788
2789         https://bugs.webkit.org/show_bug.cgi?id=184851
2790         rdar://problem/39611236
2791
2792         Reviewed by Tim Horton.
2793
2794         * WebView/WebView.mm:
2795         (-[WebView _commonInitializationWithFrameName:groupName:]):
2796         (-[WebView effectiveAppearanceDidChange]):
2797         Added a null check and call the code later in initialization.
2798
2799 2018-04-20  Tim Horton  <timothy_horton@apple.com>
2800
2801         Adjust geolocation feature flag
2802         https://bugs.webkit.org/show_bug.cgi?id=184856
2803
2804         Reviewed by Wenson Hsieh.
2805
2806         * Configurations/FeatureDefines.xcconfig:
2807
2808 2018-04-18  Jer Noble  <jer.noble@apple.com>
2809
2810         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
2811         https://bugs.webkit.org/show_bug.cgi?id=184762
2812
2813         Reviewed by Dan Bernstein.
2814
2815         * Configurations/WebKitLegacy.xcconfig:
2816
2817 2018-04-20  Youenn Fablet  <youenn@apple.com>
2818
2819         Make PluginData cache its web visible plugins
2820         https://bugs.webkit.org/show_bug.cgi?id=184421
2821
2822         Reviewed by Chris Dumez.
2823
2824         * WebCoreSupport/WebPluginInfoProvider.h:
2825         * WebCoreSupport/WebPluginInfoProvider.mm:
2826         (WebPluginInfoProvider::pluginInfo):
2827         (WebPluginInfoProvider::webVisiblePluginInfo):
2828
2829 2018-04-19  Chris Dumez  <cdumez@apple.com>
2830
2831         Rename JSDOMWindowProxy to JSWindowProxy
2832         https://bugs.webkit.org/show_bug.cgi?id=184797
2833
2834         Reviewed by Sam Weinig.
2835
2836         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
2837
2838         * DOM/DOMUtility.mm:
2839         (createDOMWrapper):
2840         * WebView/WebFrame.mm:
2841         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2842
2843 2018-04-19  David Kilzer  <ddkilzer@apple.com>
2844
2845         Enable Objective-C weak references
2846         <https://webkit.org/b/184789>
2847         <rdar://problem/39571716>
2848
2849         Reviewed by Dan Bernstein.
2850
2851         * Configurations/Base.xcconfig:
2852         (CLANG_ENABLE_OBJC_WEAK): Enable.
2853
2854 2018-04-18  Chris Dumez  <cdumez@apple.com>
2855
2856         Rename WindowProxyController to WindowProxy
2857         https://bugs.webkit.org/show_bug.cgi?id=184756
2858
2859         Reviewed by Sam Weinig.
2860
2861         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
2862         needed use WindowProxyController type, which was a bit confusing.
2863
2864         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2865         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2866         * WebView/WebFrame.mm:
2867         (-[WebFrame _attachScriptDebugger]):
2868
2869 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2870
2871         Unreviewed rollout of r230632. Regression in memory usage.
2872
2873         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2874
2875         * WebView/WebPreferences.mm:
2876         (+[WebPreferences initialize]):
2877
2878 2018-04-17  Chris Dumez  <cdumez@apple.com>
2879
2880         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
2881         https://bugs.webkit.org/show_bug.cgi?id=184678
2882         <rdar://problem/39422122>
2883
2884         Reviewed by Alex Christensen.
2885
2886         Add new parameter to dispatchDecidePolicyForNavigationAction.
2887
2888         * WebCoreSupport/WebFrameLoaderClient.h:
2889         * WebCoreSupport/WebFrameLoaderClient.mm:
2890         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2891
2892 2018-04-13  Chris Dumez  <cdumez@apple.com>
2893
2894         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
2895         https://bugs.webkit.org/show_bug.cgi?id=184591
2896
2897         Reviewed by Sam Weinig.
2898
2899         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
2900         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
2901         This is work towards fixing Bug 184515.
2902
2903         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2904         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2905         * WebView/WebFrame.mm:
2906         (-[WebFrame _attachScriptDebugger]):
2907
2908 2018-04-12  Antoine Quint  <graouts@apple.com>
2909
2910         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
2911         https://bugs.webkit.org/show_bug.cgi?id=184569
2912         <rdar://problem/38671301>
2913
2914         Reviewed by Jon Lee.
2915
2916         * WebView/WebPreferences.mm:
2917
2918 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2919
2920         [WTF] Remove StaticLock
2921         https://bugs.webkit.org/show_bug.cgi?id=184332
2922
2923         Reviewed by Mark Lam.
2924
2925         * DOM/DOMInternal.mm:
2926         (getDOMWrapper):
2927         (addDOMWrapper):
2928         (removeDOMWrapper):
2929
2930 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
2931
2932         Failures from mach port reference handling should be fatal
2933         https://bugs.webkit.org/show_bug.cgi?id=184202
2934         <rdar://problem/37771114>
2935
2936         Reviewed by Anders Carlsson.
2937
2938         * Plugins/Hosted/NetscapePluginHostManager.mm:
2939         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
2940
2941 2018-04-03  Andy Estes  <aestes@apple.com>
2942
2943         [Mac] Prioritize file promises over filenames during drag and drop
2944         https://bugs.webkit.org/show_bug.cgi?id=184237
2945         <rdar://problem/38278076>
2946
2947         Reviewed by Wenson Hsieh.
2948
2949         * WebView/WebView.mm:
2950         (-[WebView performDragOperation:]):
2951
2952 2018-04-03  Chris Dumez  <cdumez@apple.com>
2953
2954         Drop MainFrame class
2955         https://bugs.webkit.org/show_bug.cgi?id=184191
2956
2957         Reviewed by Darin Adler.
2958
2959         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
2960         relationship between the Page and the MainFrame.
2961
2962         This is ground work for introducing LocalFrame / RemoteFrame concepts.
2963
2964         * WebCoreSupport/WebDragClient.mm:
2965         * WebCoreSupport/WebFrameLoaderClient.mm:
2966         * WebCoreSupport/WebInspectorClient.mm:
2967         * WebCoreSupport/WebPlatformStrategies.mm:
2968         * WebCoreSupport/WebPluginInfoProvider.mm:
2969         * WebView/WebFrame.mm:
2970         * WebView/WebFrameView.mm:
2971         * WebView/WebHTMLView.mm:
2972         * WebView/WebView.mm:
2973
2974 2018-04-02  Jer Noble  <jer.noble@apple.com>
2975
2976         Enable Legacy EME for all WebKit & WebKitLegacy clients
2977         https://bugs.webkit.org/show_bug.cgi?id=184018
2978         <rdar://problem/34887387>
2979
2980         Reviewed by Eric Carlson.
2981
2982         * WebView/WebPreferences.mm:
2983         (+[WebPreferences initialize]):
2984
2985 2018-03-29  JF Bastien  <jfbastien@apple.com>
2986
2987         Use Forward.h instead of forward-declaring WTF::String
2988         https://bugs.webkit.org/show_bug.cgi?id=184172
2989         <rdar://problem/39026146>
2990
2991         Reviewed by Yusuke Suzuki.
2992
2993         As part of #184164 I'm changing WTF::String, and the forward
2994         declarations are just wrong because I'm making it templated. We
2995         should use Forward.h anyways, so do that instead.
2996
2997         * WebView/WebScriptDebugger.h:
2998
2999 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
3000
3001         Protect against invalid mach ports returned by mach_port_request_notification
3002         https://bugs.webkit.org/show_bug.cgi?id=184106
3003         <rdar://problem/37865316>
3004
3005         Reviewed by Chris Dumez.
3006
3007         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3008         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
3009         and clean up if it experienced an error.
3010         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
3011
3012 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
3013
3014         Avoid uninitialized mach ports
3015         https://bugs.webkit.org/show_bug.cgi?id=184090
3016         <rdar://problem/37261129>
3017
3018         Reviewed by Chris Dumez.
3019
3020         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
3021         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
3022         there is a potential for us to try to use invalid ports.
3023
3024         We should always check return values, and ensure that the mach port variables we seek to initialize are
3025         kept in a valid state.
3026
3027         Reviewed by Chris Dumez.
3028
3029         * Plugins/Hosted/NetscapePluginHostManager.h:
3030         * Plugins/Hosted/NetscapePluginHostManager.mm:
3031         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
3032         port is passed to an API function.
3033         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
3034         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
3035         * Plugins/Hosted/NetscapePluginHostProxy.h:
3036         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3037         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
3038         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
3039         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
3040         (WKPCStatusText): Ditto.
3041         (WKPCLoadURL): Ditto.
3042         (WKPCCancelLoadURL): Ditto.
3043         (WKPCInvalidateRect): Ditto.
3044         (WKPCGetScriptableNPObjectReply): Ditto.
3045         (WKPCBooleanReply): Ditto.
3046         (WKPCBooleanAndDataReply): Ditto.
3047         (WKPCInstantiatePluginReply): Ditto.
3048         (WKPCGetWindowNPObject): Ditto.
3049         (WKPCGetPluginElementNPObject): Ditto.
3050         (WKPCForgetBrowserObject): Ditto.
3051         (WKPCEvaluate): Ditto.
3052         (WKPCGetStringIdentifier): Ditto.
3053         (WKPCGetIntIdentifier): Ditto.
3054         (WKPCInvoke): Ditto.
3055         (WKPCInvokeDefault): Ditto.
3056         (WKPCConstruct): Ditto.
3057         (WKPCGetProperty): Ditto.
3058         (WKPCSetProperty): Ditto.
3059         (WKPCRemoveProperty): Ditto.
3060         (WKPCHasProperty): Ditto.
3061         (WKPCHasMethod): Ditto.
3062         (WKPCIdentifierInfo): Ditto.
3063         (WKPCEnumerate): Ditto.
3064         (WKPCSetMenuBarVisible): Ditto.
3065         (WKPCSetFullscreenWindowIsShowing): Ditto.
3066         (WKPCSetModal): Ditto.
3067         (WKPCGetCookies): Ditto.
3068         (WKPCGetProxy): Ditto.
3069         (WKPCSetCookies): Ditto.
3070         (WKPCGetAuthenticationInfo): Ditto.
3071         (WKPCConvertPoint): Ditto.
3072         (WKPCLayerHostingModeChanged): Ditto.
3073         (WKPCSetException): Ditto.
3074
3075 2018-03-26  Tim Horton  <timothy_horton@apple.com>
3076
3077         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
3078         https://bugs.webkit.org/show_bug.cgi?id=184030
3079         <rdar://problem/38895281>
3080
3081         Reviewed by Dan Bernstein.
3082
3083         * Configurations/Base.xcconfig:
3084
3085 2018-03-26  Chris Dumez  <cdumez@apple.com>
3086
3087         Use SecurityOriginData more consistently in Service Worker code
3088         https://bugs.webkit.org/show_bug.cgi?id=183969
3089
3090         Reviewed by Darin Adler.
3091
3092         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3093
3094         * Storage/WebDatabaseManager.mm:
3095         (-[WebDatabaseManager databasesWithOrigin:]):
3096         (-[WebDatabaseManager deleteOrigin:]):
3097         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3098         * Storage/WebDatabaseQuotaManager.mm:
3099         (-[WebDatabaseQuotaManager usage]):
3100         (-[WebDatabaseQuotaManager quota]):
3101         (-[WebDatabaseQuotaManager setQuota:]):
3102         * Storage/WebStorageManager.mm:
3103         (-[WebStorageManager deleteOrigin:]):
3104         * WebCoreSupport/WebSecurityOrigin.mm:
3105         (-[WebSecurityOrigin databaseIdentifier]):
3106         (-[WebSecurityOrigin usage]):
3107         (-[WebSecurityOrigin quota]):
3108         (-[WebSecurityOrigin setQuota:]):
3109
3110 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
3111
3112         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
3113         https://bugs.webkit.org/show_bug.cgi?id=183911
3114         <rdar://problem/38762306>
3115
3116         Reviewed by Youenn Fablet.
3117
3118         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
3119
3120         * WebView/WebView.mm:
3121         (+[WebView initialize]):
3122
3123 2018-03-26  Alex Christensen  <achristensen@webkit.org>
3124
3125         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
3126         https://bugs.webkit.org/show_bug.cgi?id=183965
3127
3128         Reviewed by Chris Dumez.
3129
3130         * WebCoreSupport/WebFrameLoaderClient.h:
3131         * WebCoreSupport/WebFrameLoaderClient.mm:
3132         (WebFrameLoaderClient::willCacheResponse const):
3133
3134 2018-03-25  Commit Queue  <commit-queue@webkit.org>
3135
3136         Unreviewed, rolling out r229954.
3137         https://bugs.webkit.org/show_bug.cgi?id=184000
3138
3139         Caused many layout tests to crash on Apple High Sierra,
3140         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
3141         by dydz on #webkit).
3142
3143         Reverted changeset:
3144
3145         "Use SecurityOriginData more consistently in Service Worker
3146         code"
3147         https://bugs.webkit.org/show_bug.cgi?id=183969
3148         https://trac.webkit.org/changeset/229954
3149
3150 2018-03-24  Chris Dumez  <cdumez@apple.com>
3151
3152         Use SecurityOriginData more consistently in Service Worker code
3153         https://bugs.webkit.org/show_bug.cgi?id=183969
3154
3155         Reviewed by Darin Adler.
3156
3157         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3158
3159         * Storage/WebDatabaseManager.mm:
3160         (-[WebDatabaseManager databasesWithOrigin:]):
3161         (-[WebDatabaseManager deleteOrigin:]):
3162         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3163         * Storage/WebDatabaseQuotaManager.mm:
3164         (-[WebDatabaseQuotaManager usage]):
3165         (-[WebDatabaseQuotaManager quota]):
3166         (-[WebDatabaseQuotaManager setQuota:]):
3167         * Storage/WebStorageManager.mm:
3168         (-[WebStorageManager deleteOrigin:]):
3169         * WebCoreSupport/WebSecurityOrigin.mm:
3170         (-[WebSecurityOrigin databaseIdentifier]):
3171         (-[WebSecurityOrigin usage]):
3172         (-[WebSecurityOrigin quota]):
3173         (-[WebSecurityOrigin setQuota:]):
3174
3175 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
3176
3177         Fix the build
3178
3179         * WebView/WebView.mm:
3180
3181 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3182
3183         Fix the build with no pasteboard
3184         https://bugs.webkit.org/show_bug.cgi?id=183973
3185
3186         Reviewed by Dan Bernstein.
3187
3188         * Configurations/FeatureDefines.xcconfig:
3189         * WebView/WebView.mm:
3190         (-[WebView _requestStartDataInteraction:globalPosition:]):
3191         (-[WebView _getDataInteractionData]):
3192         (-[WebView _dataOperationTextIndicator]):
3193         (-[WebView _dragSourceAction]):
3194         (-[WebView _draggedLinkTitle]):
3195         (-[WebView _draggedLinkURL]):
3196         (-[WebView _draggedElementBounds]):
3197         (-[WebView _enteredDataInteraction:client:global:operation:]):
3198         (-[WebView _updatedDataInteraction:client:global:operation:]):
3199         (-[WebView _exitedDataInteraction:client:global:operation:]):
3200         (-[WebView _performDataInteraction:client:global:operation:]):
3201         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3202         (-[WebView _endedDataInteraction:global:]):
3203         (-[WebView _dataInteractionCaretRect]):
3204         * WebView/WebViewPrivate.h:
3205
3206 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3207
3208         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
3209         https://bugs.webkit.org/show_bug.cgi?id=183960
3210         <rdar://problem/38812356>
3211
3212         Reviewed by Dan Bernstein.
3213
3214         * Configurations/WebKitLegacy.xcconfig:
3215
3216 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3217
3218         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
3219         https://bugs.webkit.org/show_bug.cgi?id=183954
3220         <rdar://problem/38808858>
3221
3222         Reviewed by Dan Bernstein.
3223
3224         * WebView/WebPreferences.mm:
3225         (-[WebPreferences setAudioSessionCategoryOverride:]):
3226
3227 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3228
3229         Adopt WK_PLATFORM_NAME in WebKitLegacy
3230         https://bugs.webkit.org/show_bug.cgi?id=183948
3231         <rdar://problem/38803908>
3232
3233         Reviewed by Dan Bernstein.
3234
3235         * Configurations/WebKitLegacy.xcconfig:
3236         * MigrateHeaders.make:
3237         * postprocess-headers.sh:
3238
3239 2018-03-23  Brady Eidson  <beidson@apple.com>
3240
3241         Go to back/forward list items after a process-swapped navigation.
3242         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
3243
3244         Reviewed by Andy Estes.
3245
3246         * WebView/WebView.mm:
3247         (-[WebView _loadBackForwardListFromOtherView:]):
3248         (-[WebView goToBackForwardItem:]):
3249
3250 2018-03-22  Tim Horton  <timothy_horton@apple.com>
3251
3252         Improve readability of WebCore's OTHER_LDFLAGS
3253         https://bugs.webkit.org/show_bug.cgi?id=183909
3254         <rdar://problem/38760992>
3255
3256         Reviewed by Dan Bernstein.
3257
3258         * Configurations/Base.xcconfig:
3259         * Configurations/FeatureDefines.xcconfig:
3260
3261 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3262
3263         Enable the minimal simulator feature flag when appropriate
3264         https://bugs.webkit.org/show_bug.cgi?id=183807
3265
3266         Reviewed by Dan Bernstein.
3267
3268         * Configurations/FeatureDefines.xcconfig:
3269
3270 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3271
3272         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
3273         https://bugs.webkit.org/show_bug.cgi?id=183758
3274         <rdar://problem/38017644>
3275
3276         Reviewed by Dan Bernstein.
3277
3278         * Configurations/FeatureDefines.xcconfig:
3279
3280 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
3281
3282         Clear style colors when setting default appearance
3283         https://bugs.webkit.org/show_bug.cgi?id=183759
3284
3285         Reviewed by Tim Horton.
3286
3287         Colors are cached and need to be cleared and recalculated.
3288         Refactor to do all style recalcs together.
3289
3290         * WebView/WebView.mm:
3291         (-[WebView _setDefaultAppearanceAndClearStyle]):
3292         (-[WebView _setUseSystemAppearance:]):
3293         (-[WebView effectiveAppearanceDidChange]):
3294
3295 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3296
3297         Unreviewed, another quick fix for r229699
3298
3299         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
3300
3301         * Configurations/FeatureDefines.xcconfig:
3302
3303 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
3304
3305         Ensure that style is updated when the effective appearance changes
3306         https://bugs.webkit.org/show_bug.cgi?id=183690
3307         <rdar://problem/38385900>
3308
3309         Reviewed by Tim Horton and Wenson Hsieh.
3310
3311         Respond to and respect the effective appearance changing.
3312
3313         * WebView/WebView.mm:
3314         (-[WebView _setUseSystemAppearance:]):
3315         (-[WebView effectiveAppearanceDidChange]):
3316
3317 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
3318
3319         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
3320         https://bugs.webkit.org/show_bug.cgi?id=183677
3321
3322         Reviewed by Tim Horton.
3323
3324         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
3325
3326         * DOM/DOM.mm:
3327         (-[DOMHTMLLinkElement _mediaQueryMatches]):
3328
3329 2018-03-14  Tim Horton  <timothy_horton@apple.com>
3330
3331         Fix the build after r229567
3332
3333         * Configurations/FeatureDefines.xcconfig:
3334
3335 2018-03-12  Tim Horton  <timothy_horton@apple.com>
3336
3337         Stop using SDK conditionals to control feature definitions
3338         https://bugs.webkit.org/show_bug.cgi?id=183430
3339         <rdar://problem/38251619>
3340
3341         Reviewed by Dan Bernstein.
3342
3343         * Configurations/FeatureDefines.xcconfig:
3344         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
3345
3346 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
3347
3348         Runtime flag for link prefetch and remove link subresource.
3349         https://bugs.webkit.org/show_bug.cgi?id=183540
3350
3351         Reviewed by Chris Dumez.
3352
3353         Remove the LINK_PREFETCH build time flag.
3354
3355         * Configurations/FeatureDefines.xcconfig:
3356
3357 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
3358
3359         Remove GridLayout runtime flag
3360         https://bugs.webkit.org/show_bug.cgi?id=183484
3361
3362         Reviewed by Myles C. Maxfield.
3363
3364         The Grid Layout feature has been enabled by default for almost a
3365         year, so I think it's time to remove the runtime flag and the
3366
3367         * WebView/WebPreferenceKeysPrivate.h:
3368         * WebView/WebPreferences.mm:
3369         (+[WebPreferences initialize]):
3370         * WebView/WebPreferencesPrivate.h:
3371         * WebView/WebView.mm:
3372         (-[WebView _preferencesChanged:]):
3373
3374 2018-03-12  Antoine Quint  <graouts@apple.com>
3375
3376         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
3377         https://bugs.webkit.org/show_bug.cgi?id=183504
3378         <rdar://problem/38372965>
3379
3380         Reviewed by Dean Jackson and Jon Lee.
3381
3382         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
3383         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
3384
3385         * WebView/WebPreferenceKeysPrivate.h:
3386         * WebView/WebPreferences.mm:
3387         (+[WebPreferences initialize]):
3388         (-[WebPreferences setModernMediaControlsEnabled:]):
3389         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
3390         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
3391         * WebView/WebPreferencesPrivate.h:
3392         * WebView/WebView.mm:
3393         (-[WebView _preferencesChanged:]):
3394
3395 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
3396
3397         Media query for default appearance
3398         https://bugs.webkit.org/show_bug.cgi?id=183539
3399         <rdar://problem/38326388>
3400
3401         Reviewed by Tim Horton.
3402
3403         Write a media query to evaluate appearance.
3404
3405         * WebView/WebView.mm:
3406         (-[WebView _commonInitializationWithFrameName:groupName:]):
3407         (-[WebView _setUseSystemAppearance:]):
3408
3409 2018-03-09  Andy Estes  <aestes@apple.com>
3410
3411         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
3412         https://bugs.webkit.org/show_bug.cgi?id=183489
3413         <rdar://problem/38267517>
3414
3415         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
3416         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
3417         to issue a sandbox extension for this directory, but for security reasons App Sandbox
3418         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
3419         block with a nil error and a valid file URL, but no file will actually exist at that URL.
3420
3421         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
3422         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
3423         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
3424         drop destination.
3425
3426         Reviewed by Wenson Hsieh.
3427
3428         * WebView/WebView.mm:
3429         (-[WebView performDragOperation:]):
3430
3431 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
3432
3433         Allow WebViews to disable system appearance
3434         https://bugs.webkit.org/show_bug.cgi?id=183418
3435         <rdar://problem/36975642>
3436
3437         Reviewed by Tim Horton.
3438
3439         Allow webviews to choose whether or not to follow the default system appearance.
3440
3441         * WebView/WebView.mm:
3442         (-[WebView _setUseSystemAppearance:]):
3443         (-[WebView _useSystemAppearance]):
3444         * WebView/WebViewPrivate.h:
3445
3446 2018-03-08  Youenn Fablet  <youenn@apple.com>
3447
3448         libwebrtc update broke internal builds
3449         https://bugs.webkit.org/show_bug.cgi?id=183454
3450
3451         Reviewed by Eric Carlson.
3452
3453         * Configurations/WebKitLegacy.xcconfig:
3454
3455 2018-03-08  Chris Dumez  <cdumez@apple.com>
3456
3457         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
3458         https://bugs.webkit.org/show_bug.cgi?id=183455
3459         <rdar://problem/38191749>
3460
3461         Reviewed by Youenn Fablet.
3462
3463         Add a null check for the page as we have evidence from crashes that it can be null.
3464         Other functions in WebFrameNetworkingContext already null check the page as well,
3465         not just the frame so this is consistent.
3466
3467         * WebCoreSupport/WebFrameNetworkingContext.mm:
3468         (WebFrameNetworkingContext::storageSession const):
3469
3470 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3471
3472         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
3473         https://bugs.webkit.org/show_bug.cgi?id=183429
3474
3475         Reviewed by Mark Lam.
3476
3477         * DOM/DOM.mm:
3478         (+[DOMNode _nodeFromJSWrapper:]):
3479         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3480         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
3481         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
3482         * Plugins/Hosted/ProxyInstance.mm:
3483         (WebKit::ProxyInstance::invokeMethod):
3484         * WebView/WebView.mm:
3485         (aeDescFromJSValue):
3486
3487 2018-03-08  Tim Horton  <timothy_horton@apple.com>
3488
3489         Stop linking ApplicationServices directly
3490         https://bugs.webkit.org/show_bug.cgi?id=182867
3491         <rdar://problem/38252142>
3492
3493         Reviewed by Alex Christensen.
3494
3495         The frameworks that we use that live inside ApplicationServices
3496         have mostly moved out, so import them directly.
3497
3498         * Carbon/CarbonUtils.h:
3499         * WebKitPrefix.h:
3500         * WebView/WebHTMLView.mm:
3501         * WebView/WebPDFView.mm:
3502
3503 2018-03-07  Tim Horton  <timothy_horton@apple.com>
3504
3505         Sort and separate FeatureDefines.xcconfig
3506         https://bugs.webkit.org/show_bug.cgi?id=183427
3507
3508         Reviewed by Dan Bernstein.
3509
3510         * Configurations/FeatureDefines.xcconfig:
3511         Sort and split FeatureDefines into paragraphs
3512         (to make it easier to sort later).
3513
3514 2018-03-07  Youenn Fablet  <youenn@apple.com>
3515
3516         Match unsupported plugins based on domains and not origin
3517         https://bugs.webkit.org/show_bug.cgi?id=183384
3518
3519         Reviewed by Chris Dumez.
3520
3521         * WebCoreSupport/WebPluginInfoProvider.h:
3522         * WebCoreSupport/WebPluginInfoProvider.mm:
3523         (WebPluginInfoProvider::getPluginInfo):
3524         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3525
3526 2018-03-05  Andy Estes  <aestes@apple.com>
3527
3528         [Mac] Teach WebCore::Pasteboard about file promise drags
3529         https://bugs.webkit.org/show_bug.cgi?id=183314
3530         <rdar://problem/38105493>
3531
3532         Reviewed by Darin Adler.
3533
3534         Added a FIXME comment.
3535
3536         * WebView/WebView.mm:
3537         (-[WebView performDragOperation:]):
3538
3539 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3540
3541         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
3542         https://bugs.webkit.org/show_bug.cgi?id=183312
3543
3544         Reviewed by Mark Lam.
3545
3546         Remove wtf/CurrentTime.h include pragma.
3547
3548         * WebView/WebFrame.mm:
3549         * WebView/WebPDFView.mm:
3550
3551 2018-03-04  Tim Horton  <timothy_horton@apple.com>
3552
3553         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
3554         https://bugs.webkit.org/show_bug.cgi?id=183283
3555         <rdar://problem/38062148>
3556
3557         Reviewed by Sam Weinig.
3558
3559         * Configurations/FeatureDefines.xcconfig:
3560
3561 2018-02-28  Alex Christensen  <achristensen@webkit.org>
3562
3563         Reduce use of NetworkingContext in WebKit
3564         https://bugs.webkit.org/show_bug.cgi?id=183213
3565
3566         Reviewed by Brady Eidson.
3567
3568         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3569         (WebKit::NetscapePluginInstanceProxy::getProxy):
3570         * Plugins/WebNetscapePluginView.mm:
3571         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
3572
3573 2018-02-17  Darin Adler  <darin@apple.com>
3574
3575         Prepare for ExtendedColor changes (first step)
3576         https://bugs.webkit.org/show_bug.cgi?id=182904
3577
3578         Reviewed by Sam Weinig.
3579
3580         * Misc/WebKitNSStringExtras.mm:
3581         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
3582
3583 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
3584
3585         Remove currentTime() / currentTimeMS()
3586         https://bugs.webkit.org/show_bug.cgi?id=183052
3587
3588         Reviewed by Mark Lam.
3589
3590         * WebCoreSupport/WebFrameLoaderClient.h:
3591         * WebCoreSupport/WebFrameLoaderClient.mm:
3592         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
3593
3594 2018-02-16  Youenn Fablet  <youenn@apple.com>
3595
3596         Allow specifying which plug-ins are supported
3597         https://bugs.webkit.org/show_bug.cgi?id=182748
3598
3599         Reviewed by Chris Dumez.
3600
3601         * WebCoreSupport/WebPluginInfoProvider.h:
3602         * WebCoreSupport/WebPluginInfoProvider.mm:
3603         (WebPluginInfoProvider::getPluginInfo):
3604         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3605
3606 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
3607
3608         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
3609         https://bugs.webkit.org/show_bug.cgi?id=182882
3610         <rdar://problem/35672661>
3611
3612         Reviewed by Dan Bernstein.
3613
3614         Make sure the smart pointer hold the collection of subviews lives at least as
3615         long as the loop using it.
3616
3617         * WebView/WebHTMLView.mm:
3618         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
3619
3620 2018-02-14  Daniel Bates  <dabates@apple.com>
3621
3622         Disallow cross-origin subresources from asking for credentials
3623         https://bugs.webkit.org/show_bug.cgi?id=182579
3624         <rdar://problem/36162271>
3625
3626         Reviewed by Andy Estes.
3627
3628         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
3629         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
3630
3631         * WebView/WebPreferenceKeysPrivate.h:
3632         * WebView/WebPreferences.mm:
3633         (+[WebPreferences initialize]):
3634         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
3635         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
3636         * WebView/WebPreferencesPrivate.h:
3637         * WebView/WebView.mm:
3638         (-[WebView _preferencesChanged:]):
3639
3640 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3641
3642         Remove ForwardingHeaders directory from WebKitLegacy/mac.
3643         https://bugs.webkit.org/show_bug.cgi?id=182738
3644
3645         Reviewed by Darin Adler.
3646
3647         * ForwardingHeaders/collector/handles/Global.h: Removed.
3648         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
3649         * ForwardingHeaders/runtime/Completion.h: Removed.
3650         * ForwardingHeaders/runtime/Error.h: Removed.
3651         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
3652         * ForwardingHeaders/runtime/JSFunction.h: Removed.
3653         * ForwardingHeaders/runtime/JSLock.h: Removed.
3654         * ForwardingHeaders/runtime/JSObject.h: Removed.
3655         * ForwardingHeaders/runtime/JSString.h: Removed.
3656         * ForwardingHeaders/runtime/Protect.h: Removed.
3657         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
3658
3659 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
3660
3661         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
3662         https://bugs.webkit.org/show_bug.cgi?id=182641
3663
3664         Reviewed by Dan Bernstein.
3665
3666         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
3667         https://trac.webkit.org/changeset/228308.
3668
3669         * WebView/WebVideoFullscreenController.h:
3670         * WebView/WebVideoFullscreenHUDWindowController.mm:
3671         * WebView/WebWindowAnimation.h:
3672         * WebView/WebWindowAnimation.mm:
3673         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
3674         (WebCore::scaledRect): Deleted.
3675         (WebCore::squaredDistance): Deleted.
3676
3677 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
3678
3679         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
3680
3681         * WebView/WebWindowAnimation.mm:
3682         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
3683
3684 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
3685
3686         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
3687         https://bugs.webkit.org/show_bug.cgi?id=182615
3688
3689         Reviewed by Eric Carlson.
3690
3691         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
3692         Ideally, we should not reference NSApp in WebCore.
3693
3694         * WebView/WebFullScreenController.mm:
3695         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
3696         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
3697         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
3698         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
3699         * WebView/WebView.mm:
3700         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
3701         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
3702
3703 2018-01-13  Darin Adler  <darin@apple.com>
3704
3705         Event improvements
3706         https://bugs.webkit.org/show_bug.cgi?id=179591
3707
3708         Reviewed by Chris Dumez.
3709
3710         * DOM/DOMWheelEvent.mm:
3711         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
3712         Call initWebKitWheelEvent.
3713
3714         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
3715         * WebCoreSupport/WebInspectorClient.mm: Ditto.
3716         * WebView/WebFrame.mm: Ditto.
3717
3718         * WebView/WebHTMLView.mm:
3719         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
3720         underlyingPlatformEvent.
3721         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
3722
3723         * WebView/WebScriptWorld.mm:
3724         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
3725
3726         * WebView/WebView.mm: Removed include of ScriptValue.h.
3727
3728 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
3729
3730         Remove WebCore/ForwardingHeaders directory
3731         https://bugs.webkit.org/show_bug.cgi?id=182347
3732
3733         Reviewed by Keith Miller.
3734
3735         * Carbon/CarbonWindowAdapter.mm:
3736         * DOM/WebDOMOperations.mm:
3737         * History/WebBackForwardList.mm:
3738         * History/WebHistoryItem.mm:
3739         * Misc/WebCache.mm:
3740         * Misc/WebElementDictionary.mm:
3741         * Misc/WebIconDatabase.mm:
3742         * Misc/WebStringTruncator.mm:
3743         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3744         * Plugins/Hosted/ProxyInstance.mm:
3745         * Plugins/Hosted/ProxyRuntimeObject.mm:
3746         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3747         * Plugins/WebBaseNetscapePluginView.mm:
3748         * Plugins/WebBasePluginPackage.mm:
3749         * Plugins/WebNetscapePluginStream.mm:
3750         * Plugins/WebNetscapePluginView.mm:
3751         * Plugins/WebPluginController.mm:
3752         * WebCoreSupport/WebEditorClient.mm:
3753         * WebCoreSupport/WebFrameLoaderClient.mm:
3754         * WebCoreSupport/WebInspectorClient.h:
3755         * WebCoreSupport/WebInspectorClient.mm:
3756         * WebView/WebDataSource.mm:
3757         * WebView/WebFrame.mm:
3758         * WebView/WebHTMLRepresentation.mm:
3759         * WebView/WebHTMLView.mm:
3760         * WebView/WebPreferences.mm:
3761         * WebView/WebScriptDebugDelegate.mm:
3762         * WebView/WebScriptDebugger.h:
3763         * WebView/WebTextIterator.mm:
3764         * WebView/WebView.mm:
3765         * WebView/WebViewData.mm:
3766
3767 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
3768
3769         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
3770         https://bugs.webkit.org/show_bug.cgi?id=182312
3771
3772         Reviewed by Michael Catanzaro.
3773
3774         * WebKitPrefix.h:
3775
3776 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
3777
3778         [WebAuthN] Add a compile-time feature flag
3779         https://bugs.webkit.org/show_bug.cgi?id=182211
3780         <rdar://problem/36936365>
3781
3782         Reviewed by Brent Fulgham.
3783
3784         * Configurations/FeatureDefines.xcconfig:
3785
3786 2018-01-27  Dan Bernstein  <mitz@apple.com>
3787
3788         HaveInternalSDK includes should be "#include?"
3789         https://bugs.webkit.org/show_bug.cgi?id=179670
3790
3791         * Configurations/Base.xcconfig:
3792
3793 2018-01-24  Alex Christensen  <achristensen@webkit.org>
3794
3795         Remove unused QTKit preference
3796         https://bugs.webkit.org/show_bug.cgi?id=181968
3797
3798         Reviewed by Alexey Proskuryakov.
3799
3800         * WebView/WebPreferenceKeysPrivate.h:
3801         * WebView/WebPreferences.mm:
3802         (+[WebPreferences initialize]):
3803         (-[WebPreferences setQTKitEnabled:]): Deleted.
3804         (-[WebPreferences isQTKitEnabled]): Deleted.
3805         * WebView/WebPreferencesPrivate.h:
3806         * WebView/WebView.mm:
3807         (-[WebView _preferencesChanged:]):
3808
3809 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3810
3811         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
3812         https://bugs.webkit.org/show_bug.cgi?id=182037
3813         <rdar://problem/36747812>
3814
3815         Reviewed by Ryosuke Niwa.
3816
3817         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
3818         for more details.
3819
3820         * WebView/WebHTMLRepresentation.mm:
3821         (-[WebHTMLRepresentation elementWithName:inForm:]):
3822         (-[WebHTMLRepresentation controlsInForm:]):
3823
3824 2018-01-23  Alex Christensen  <achristensen@webkit.org>
3825
3826         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
3827         https://bugs.webkit.org/show_bug.cgi?id=181961
3828
3829         Reviewed by Michael Catanzaro.
3830
3831         * WebView/WebPreferences.mm:
3832
3833 2018-01-23  Commit Queue  <commit-queue@webkit.org>
3834
3835         Unreviewed, rolling out r227437.
3836         https://bugs.webkit.org/show_bug.cgi?id=182011
3837
3838         broke build (Requested by alexchristensen on #webkit).
3839
3840         Reverted changeset:
3841
3842         "Remove unused QTKit preference"
3843         https://bugs.webkit.org/show_bug.cgi?id=181968
3844         https://trac.webkit.org/changeset/227437
3845
3846 2018-01-23  Alex Christensen  <achristensen@webkit.org>
3847
3848         Remove unused QTKit preference
3849         https://bugs.webkit.org/show_bug.cgi?id=181968
3850
3851         Reviewed by Alexey Proskuryakov.
3852
3853         * WebView/WebPreferenceKeysPrivate.h:
3854         * WebView/WebPreferences.mm:
3855         (+[WebPreferences initialize]):
3856         (-[WebPreferences setQTKitEnabled:]): Deleted.
3857         (-[WebPreferences isQTKitEnabled]): Deleted.
3858         * WebView/WebPreferencesPrivate.h:
3859         * WebView/WebView.mm:
3860         (-[WebView _preferencesChanged:]):
3861
3862 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3863
3864         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
3865         https://bugs.webkit.org/show_bug.cgi?id=181960
3866         <rdar://problem/36431678>
3867
3868         Reviewed by Tim Horton.
3869
3870         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
3871         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
3872         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
3873
3874         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
3875         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
3876         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
3877
3878         * WebView/WebView.mm:
3879         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3880
3881 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
3882
3883         Turning off custom pasteboard data doesn't actually turn it off in WK2
3884         https://bugs.webkit.org/show_bug.cgi?id=181920
3885         <rdar://problem/36686429>
3886
3887         Reviewed by Wenson Hsieh.
3888
3889         Always disable custom pasteboard data in WebKit1. See r226156 for details.
3890
3891         * WebView/WebPreferences.mm:
3892         (+[WebPreferences initialize]):
3893         * WebView/WebView.mm:
3894         (-[WebView _preferencesChanged:]):
3895
3896 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3897
3898         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
3899         https://bugs.webkit.org/show_bug.cgi?id=181918
3900
3901         Reviewed by Tim Horton.
3902
3903         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
3904
3905         * Configurations/FeatureDefines.xcconfig:
3906
3907 2018-01-20  Andy Estes  <aestes@apple.com>
3908
3909         [Apple Pay] Stop eagerly loading PassKit.framework
3910         https://bugs.webkit.org/show_bug.cgi?id=181911
3911         <rdar://problem/36555369>
3912
3913         Reviewed by Tim Horton.
3914
3915         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3916         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3917         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
3918
3919         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
3920
3921 2018-01-19  Dean Jackson  <dino@apple.com>
3922
3923         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
3924         https://bugs.webkit.org/show_bug.cgi?id=181817
3925         <rdar://problem/35274055>
3926
3927         Reviewed by Simon Fraser.
3928
3929         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
3930
3931         * Misc/WebKitVersionChecks.h:
3932         * WebView/WebView.mm:
3933         (-[WebView _commonInitializationWithFrameName:groupName:]):
3934
3935 2018-01-19  Alex Christensen  <achristensen@webkit.org>
3936
3937         Remove unused WebViewPrivate _allowCookies
3938         https://bugs.webkit.org/show_bug.cgi?id=181812
3939
3940         Reviewed by Tim Horton.
3941
3942         * WebView/WebView.mm:
3943         (+[WebView _setAllowCookies:]): Deleted.
3944         (+[WebView _allowCookies]): Deleted.
3945         * WebView/WebViewPrivate.h:
3946
3947 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
3948
3949         Build fix, remove a call to -[NSWindow setOneShot:]
3950         https://bugs.webkit.org/show_bug.cgi?id=181809
3951
3952         Reviewed by Tim Horton.
3953
3954         * WebView/WebTextCompletionController.mm:
3955         (-[WebTextCompletionController _buildUI]):
3956
3957 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3958
3959         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
3960
3961         * Carbon/HIWebView.mm:
3962         (overrideCGContext):
3963         (restoreCGContext):
3964
3965 2018-01-18  Dan Bernstein  <mitz@apple.com>
3966
3967         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
3968         https://bugs.webkit.org/show_bug.cgi?id=181803
3969
3970         Reviewed by Tim Horton.
3971
3972         * Configurations/Base.xcconfig: Updated.
3973         * Configurations/DebugRelease.xcconfig: Ditto.
3974         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
3975         * Configurations/Version.xcconfig: Updated.
3976         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
3977           useful for defining settings that depend on the target macOS version.
3978
3979 2018-01-17  Youenn Fablet  <youenn@apple.com>
3980
3981         Put fetch Request.keepalive behind a runtime flag
3982         https://bugs.webkit.org/show_bug.cgi?id=181592
3983
3984         Reviewed by Chris Dumez.
3985
3986         * WebView/WebPreferenceKeysPrivate.h:
3987         * WebView/WebPreferences.mm:
3988         (+[WebPreferences initialize]):
3989         (-[WebPreferences fetchAPIKeepAliveEnabled]):
3990         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
3991         * WebView/WebPreferencesPrivate.h:
3992         * WebView/WebView.mm:
3993         (-[WebView _preferencesChanged:]):
3994
3995 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3996
3997         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
3998         https://bugs.webkit.org/show_bug.cgi?id=181637
3999         <rdar://problem/36508471>
4000
4001         Reviewed by Tim Horton.
4002
4003         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
4004
4005         * WebCoreSupport/WebEditorClient.h:
4006         * WebCoreSupport/WebEditorClient.mm:
4007         (WebEditorClient::replacementURLForResource):
4008
4009 2018-01-11  Keith Miller  <keith_miller@apple.com>
4010
4011         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
4012         https://bugs.webkit.org/show_bug.cgi?id=181573
4013
4014         Reviewed by Simon Fraser.
4015
4016         * Configurations/FeatureDefines.xcconfig:
4017
4018 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4019
4020         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
4021         https://bugs.webkit.org/show_bug.cgi?id=181497
4022
4023         Reviewed by Tim Horton.
4024
4025         See other ChangeLogs for more detail.
4026
4027         * WebCoreSupport/WebDragClient.h:
4028
4029 2018-01-11  Tim Horton  <timothy_horton@apple.com>
4030
4031         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
4032         https://bugs.webkit.org/show_bug.cgi?id=181523
4033         <rdar://problem/28959131>
4034
4035         Reviewed by Alex Christensen.
4036
4037         * WebView/WebImmediateActionController.mm:
4038         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
4039         Apply the change made in r216652 to WebKit1's immediate action controller.
4040
4041         Speculative (but successful in WebKit2) fix for non-reproducible crash when
4042         the startContainer of the range is in an anonymous node.
4043
4044 2018-01-11  Youenn Fablet  <youenn@apple.com>
4045
4046         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
4047         https://bugs.webkit.org/show_bug.cgi?id=181480
4048
4049         Reviewed by Eric Carlson.
4050
4051         * WebView/WebPreferences.mm:
4052         (+[WebPreferences initialize]):
4053
4054 2018-01-08  David Kilzer  <ddkilzer@apple.com>
4055
4056         Fix check-webkit-style issues with WebNSDataExtras.mm
4057         <https://webkit.org/b/181369>
4058
4059         Reviewed by Alex Christensen.
4060
4061         * Misc/WebNSDataExtras.mm:
4062         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
4063         (-[NSData _webkit_guessedMIMETypeForXML]):
4064         (-[NSData _webkit_guessedMIMEType]):
4065         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
4066         (_findEOL):
4067         (-[NSData _webkit_parseRFC822HeaderFields]):
4068         (-[NSData _web_locationAfterFirstBlankLine]):
4069         - Fix all the check-webkit-style warnings.