Retried to fix 32-bit macOS builds after r236846.
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-10-04  Dan Bernstein  <mitz@apple.com>
2
3         Retried to fix 32-bit macOS builds after r236846.
4
5         * WebView/WebHTMLView.mm:
6         (-[WebHTMLView setMarkedText:selectedRange:]):
7
8 2018-10-04  Dan Bernstein  <mitz@apple.com>
9
10         Retried to fix 32-bit macOS builds after r236846.
11
12         * Carbon/HIWebView.mm:
13         (ActiveStateChanged):
14
15 2018-10-04  Dan Bernstein  <mitz@apple.com>
16
17         Tried to fix 32-bit macOS builds after r236846.
18
19         * Carbon/HIWebView.mm:
20         (_NSSelectorForHICommand):
21
22 2018-10-04  Dan Bernstein  <mitz@apple.com>
23
24         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
25         https://bugs.webkit.org/show_bug.cgi?id=190250
26
27         Reviewed by Andy Estes.
28
29         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
30           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
31           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
32           an earlier line set it to YES.
33
34         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
35         changes below.
36
37         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
38           provides some missing method declarations.
39
40         * Misc/WebDownload.mm:
41         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
42           a deprecated method.
43
44         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
45
46         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
47           other code in the file uses a method from it.
48
49         * Plugins/WebBaseNetscapePluginView.mm:
50         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
51           a deprecated method.
52
53         * Plugins/WebPluginController.mm:
54         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
55           around use of a selector that may be present in some WebKit client.
56
57         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
58           method declarations.
59
60         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
61           from here.
62
63         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
64           missing method declarations.
65
66         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
67           from here.
68
69         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
70           call from here.
71         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
72           an obsolete delegate method for binary compatibility.
73         (pluginView): Ditto.
74
75         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
76           call from here.
77
78         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
79           WebDeviceOrientationProviderMock protocol.
80
81         * WebView/WebDeviceOrientationProviderMock.mm:
82         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
83           main @implementation.
84
85         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
86           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
87
88         * WebView/WebDynamicScrollBarsView.mm:
89         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
90           of a deprecated method.
91
92         * WebView/WebHTMLView.mm:
93         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
94           selector warning around action methods that are not declared anywhere in WebKit.
95
96         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
97           about implementing this deprecated method.
98         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
99         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
100         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
101         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
102         (-[WebHTMLView characterIndexForPoint:]): Ditto.
103         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
104         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
105         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
106         (-[WebHTMLView doCommandBySelector:]): Ditto.
107         (-[WebHTMLView insertText:]): Ditto.
108
109         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
110
111         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
112
113         * WebView/WebPDFView.h: Removed previewView ivar.
114
115         * WebView/WebPDFView.mm:
116           Removed declaration of FileInternal category and merged its implementation with the main
117           implementation.
118         (-[WebPDFView dealloc]): Removed previewView ivar.
119         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
120           exist in macOS versions we support.
121         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
122         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
123           action methods internal to PDFKit.
124         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
125         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
126
127         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
128           call on macOS, even though in r86988 we started calling different methods on iOS.
129
130         * WebView/WebView.mm:
131         - Imported headers that declare delegate methods that we call.
132         - Removed declaration of WebFileInternal category and merged its implementation with the
133           main implementation.
134         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
135           category, which made them impossible to call from the main implementation. Moved those
136           into the main implementation. One of those had to be declared in a class extension,
137           because it is called from a method implemented in the WebPrivate category, and that
138           category’s implementation appears first in the file.
139
140         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
141           around use of obsolete delegate method for binary compatibility.
142
143         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
144
145 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
146
147         Runtime flag and IDL for MediaRecorder
148         https://bugs.webkit.org/show_bug.cgi?id=190018
149
150         Reviewed by Youenn Fablet and Chris Dumez.
151
152         * WebView/WebPreferenceKeysPrivate.h:
153         * WebView/WebPreferences.mm:
154         (+[WebPreferences initialize]):
155         (-[WebPreferences mediaRecorderEnabled]):
156         (-[WebPreferences setMediaRecorderEnabled:]):
157         * WebView/WebPreferencesPrivate.h:
158         * WebView/WebView.mm:
159         (-[WebView _preferencesChanged:]):
160
161 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
162
163         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
164         https://bugs.webkit.org/show_bug.cgi?id=190238
165
166         Reviewed by Antti Koivisto.
167
168         Enabled the feature by default.
169
170         * WebView/WebPreferences.mm:
171         (+[WebPreferences initialize]):
172
173 2018-10-01  Dean Jackson  <dino@apple.com>
174
175         [macOS] Switching to discrete GPU should be done in the UI process
176         https://bugs.webkit.org/show_bug.cgi?id=189361
177         <rdar://problem/43949622>
178
179         Reviewed by Simon Fraser.
180
181         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
182         not support swapping to the discrete GPU in this configuration.
183
184         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
185         (WebKit::WebSwitchingGPUClient::singleton):
186         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
187         * WebView/WebView.mm:
188         (-[WebView _commonInitializationWithFrameName:groupName:]):
189
190 2018-10-02  Alex Christensen  <achristensen@webkit.org>
191
192         Remove ParsedURLString
193         https://bugs.webkit.org/show_bug.cgi?id=190154
194
195         Reviewed by Chris Dumez.
196
197         * WebView/WebScriptDebugger.mm:
198         (toNSURL):
199
200 2018-10-01  Dean Jackson  <dino@apple.com>
201
202         Remove CSS Animation Triggers
203         https://bugs.webkit.org/show_bug.cgi?id=190175
204         <rdar://problem/44925626>
205
206         Reviewed by Simon Fraser.
207
208         * Configurations/FeatureDefines.xcconfig:
209
210 2018-10-02  Commit Queue  <commit-queue@webkit.org>
211
212         Unreviewed, rolling out r236624 and r236671.
213         https://bugs.webkit.org/show_bug.cgi?id=190207
214
215         The change in r236624 introduced crashes on the bots
216         (Requested by ryanhaddad on #webkit).
217
218         Reverted changesets:
219
220         "Refactoring: eliminate raw pointer usage in Fullscreen code"
221         https://bugs.webkit.org/show_bug.cgi?id=188747
222         https://trac.webkit.org/changeset/236624
223
224         "Unify implementation in VideoFullscreenInterfaceAVKit"
225         https://bugs.webkit.org/show_bug.cgi?id=190091
226         https://trac.webkit.org/changeset/236671
227
228 2018-10-01  Alex Christensen  <achristensen@webkit.org>
229
230         URL should not use TextEncoding internally
231         https://bugs.webkit.org/show_bug.cgi?id=190111
232
233         Reviewed by Andy Estes.
234
235         * Misc/WebNSURLExtras.mm:
236
237 2018-09-28  Jer Noble  <jer.noble@apple.com>
238
239         Refactoring: eliminate raw pointer usage in Fullscreen code
240         https://bugs.webkit.org/show_bug.cgi?id=188747
241         <rdar://problem/43541164>
242
243         Reviewed by Alex Christensen.
244
245         PlaybackSessionInterface no longer has an invalidate() method.
246
247         * WebView/WebView.mm:
248         (-[WebView _clearPlaybackControlsManager]):
249
250 2018-09-28  Chris Dumez  <cdumez@apple.com>
251
252         Drop support for cross-origin-window-policy header
253         https://bugs.webkit.org/show_bug.cgi?id=190081
254
255         Reviewed by Ryosuke Niwa.
256
257         * WebView/WebPreferenceKeysPrivate.h:
258         * WebView/WebPreferences.mm:
259         (+[WebPreferences initialize]):
260         * WebView/WebPreferencesPrivate.h:
261         * WebView/WebView.mm:
262         (-[WebView _preferencesChanged:]):
263
264 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
265
266         Rename createMarkup to serializePreservingVisualAppearance
267         https://bugs.webkit.org/show_bug.cgi?id=190086
268
269         Reviewed by Wenson Hsieh.
270
271         * DOM/WebDOMOperations.mm:
272         (-[DOMRange markupString]):
273
274 2018-09-28  Commit Queue  <commit-queue@webkit.org>
275
276         Unreviewed, rolling out r236605.
277         https://bugs.webkit.org/show_bug.cgi?id=190087
278
279         caused three API test timeouts (Requested by jernoble on
280         #webkit).
281
282         Reverted changeset:
283
284         "Refactoring: eliminate raw pointer usage in Fullscreen code"
285         https://bugs.webkit.org/show_bug.cgi?id=188747
286         https://trac.webkit.org/changeset/236605
287
288 2018-09-28  Jer Noble  <jer.noble@apple.com>
289
290         Refactoring: eliminate raw pointer usage in Fullscreen code
291         https://bugs.webkit.org/show_bug.cgi?id=188747
292         <rdar://problem/43541164>
293
294         Reviewed by Alex Christensen.
295
296         PlaybackSessionInterface no longer has an invalidate() method.
297
298         * WebView/WebView.mm:
299         (-[WebView _clearPlaybackControlsManager]):
300
301 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
302
303         Use enum class in createMarkup arguments
304         https://bugs.webkit.org/show_bug.cgi?id=190028
305
306         Reviewed by Wenson Hsieh.
307
308         * DOM/WebDOMOperations.mm:
309         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
310         (-[DOMRange markupString]): Ditto.
311
312 2018-09-27  Antoine Quint  <graouts@apple.com>
313
314         [Web Animations] Turn Web Animations with CSS integration on
315         https://bugs.webkit.org/show_bug.cgi?id=184819
316         <rdar://problem/39597337>
317
318         Reviewed by Dean Jackson.
319
320         * WebView/WebPreferences.mm:
321         (+[WebPreferences initialize]):
322
323 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
324
325         Selection should work across shadow boundary when initiated by a mouse drag
326         https://bugs.webkit.org/show_bug.cgi?id=151380
327         <rdar://problem/24363872>
328
329         Reviewed by Wenson Hsieh.
330
331         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
332
333         * WebView/WebPreferenceKeysPrivate.h:
334         * WebView/WebPreferences.mm:
335         (+[WebPreferences initialize]):
336         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
337         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
338         * WebView/WebPreferencesPrivate.h:
339         * WebView/WebView.mm:
340         (-[WebView _preferencesChanged:]):
341
342 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
343
344         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
345         https://bugs.webkit.org/show_bug.cgi?id=189918
346         Work towards <rdar://problem/44648705>
347
348         Reviewed by Tim Horton.
349
350         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
351
352         * WebView/WebHTMLView.mm:
353         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
354         (-[WebHTMLView _updateFontPanel]):
355         * WebView/WebView.mm:
356         (-[WebView typingAttributes]):
357
358 2018-09-17  Darin Adler  <darin@apple.com>
359
360         Use OpaqueJSString rather than JSRetainPtr inside WebKit
361         https://bugs.webkit.org/show_bug.cgi?id=189652
362
363         Reviewed by Saam Barati.
364
365         * WebView/WebPDFRepresentation.mm:
366         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
367
368 2018-09-14  Jer Noble  <jer.noble@apple.com>
369
370         Turn SourceBufferChangeTypeEnabled on by default
371         https://bugs.webkit.org/show_bug.cgi?id=189527
372
373         Reviewed by Eric Carlson.
374
375         * WebView/WebPreferences.mm:
376         (+[WebPreferences initialize]):
377
378 2018-09-12  Alex Christensen  <achristensen@webkit.org>
379
380         Fix an internal build after r235935
381         https://bugs.webkit.org/show_bug.cgi?id=188996
382
383         * Carbon/HIWebView.mm:
384         (Draw):
385         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
386
387 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
388
389         Add IGNORE_WARNING_.* macros
390         https://bugs.webkit.org/show_bug.cgi?id=188996
391
392         Reviewed by Michael Catanzaro.
393
394         * Carbon/CarbonUtils.m:
395         (PoolCleaner):
396         * Carbon/CarbonWindowAdapter.mm:
397         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
398         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
399         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
400         (-[CarbonWindowAdapter _termWindowIfOwner]):
401         (-[CarbonWindowAdapter _windowMovedToRect:]):
402         (-[CarbonWindowAdapter setContentView:]):
403         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
404         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
405         * Carbon/CarbonWindowFrame.m:
406         (-[CarbonWindowFrame title]):
407         * Carbon/HIViewAdapter.m:
408         (+[HIViewAdapter getHIViewForNSView:]):
409         * Carbon/HIWebView.mm:
410         (overrideCGContext):
411         (restoreCGContext):
412         (Draw):
413         * DOM/DOM.mm:
414         * History/WebHistory.mm:
415         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
416         * History/WebHistoryItem.mm:
417         (-[WebHistoryItem icon]):
418         * Misc/WebKitNSStringExtras.mm:
419         (-[NSString _web_drawAtPoint:font:textColor:]):
420         * Misc/WebNSImageExtras.m:
421         (-[NSImage _web_scaleToMaxSize:]):
422         (-[NSImage _web_dissolveToFraction:]):
423         * Misc/WebNSPasteboardExtras.mm:
424         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
425         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
426         * Panels/WebAuthenticationPanel.m:
427         (-[WebAuthenticationPanel loadNib]):
428         * Plugins/Hosted/NetscapePluginHostManager.mm:
429         (WebKit::NetscapePluginHostManager::spawnPluginHost):
430         (WebKit::NetscapePluginHostManager::didCreateWindow):
431         * Plugins/Hosted/NetscapePluginHostProxy.mm:
432         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
433         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
434         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
435         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
436         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
437         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
438         (-[WebHostedNetscapePluginView drawRect:]):
439         * Plugins/Hosted/WebTextInputWindowController.m:
440         (-[WebTextInputPanel _interpretKeyEvent:string:]):
441         * Plugins/WebBaseNetscapePluginView.mm:
442         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
443         * Plugins/WebNetscapePluginPackage.mm:
444         (-[WebNetscapePluginPackage _tryLoad]):
445         * Plugins/WebNetscapePluginView.mm:
446         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
447         (-[WebNetscapePluginView sendDrawRectEvent:]):
448         (-[WebNetscapePluginView drawRect:]):
449         * Plugins/WebPluginController.mm:
450         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
451         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
452         * WebCoreSupport/PopupMenuMac.mm:
453         (PopupMenuMac::populate):
454         * WebCoreSupport/WebAlternativeTextClient.h:
455         * WebCoreSupport/WebDragClient.mm:
456         (WebDragClient::startDrag):
457         * WebCoreSupport/WebFrameLoaderClient.mm:
458         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
459         (webGetNSImage):
460         * WebInspector/WebNodeHighlight.mm:
461         * WebInspector/WebNodeHighlightView.mm:
462         (-[WebNodeHighlightView drawRect:]):
463         * WebView/WebClipView.mm:
464         (-[WebClipView initWithFrame:]):
465         * WebView/WebFrame.mm:
466         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
467         (-[WebFrame _drawRect:contentsOnly:]):
468         (-[WebFrame accessibilityRoot]):
469         * WebView/WebFullScreenController.mm:
470         (-[WebFullScreenController enterFullScreen:]):
471         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
472         (-[WebFullScreenController exitFullScreen]):
473         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
474         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
475         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
476         * WebView/WebHTMLView.mm:
477         (-[NSWindow _web_borderView]):
478         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
479         (-[WebHTMLView _setAsideSubviews]):
480         (-[WebHTMLView _autoscroll]):
481         (-[WebHTMLView drawRect:]):
482         (-[WebHTMLView mouseDown:]):
483         (-[WebHTMLView mouseDragged:]):
484         (-[WebHTMLView mouseUp:]):
485         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
486         (-[WebHTMLView knowsPageRange:]):
487         (-[WebHTMLView accessibilityHitTest:]):
488         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
489         (-[WebHTMLView _colorAsString:]):
490         (-[WebHTMLView copyFont:]):
491         (-[WebHTMLView _executeSavedKeypressCommands]):
492         (-[WebHTMLView attachRootLayer:]):
493         (-[WebHTMLView textStorage]):
494         (-[WebHTMLView _updateSelectionForInputManager]):
495         * WebView/WebPDFView.mm:
496         (_applicationInfoForMIMEType):
497         (-[WebPDFView centerSelectionInVisibleArea:]):
498         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
499         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
500         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
501         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
502         * WebView/WebTextCompletionController.mm:
503         (-[WebTextCompletionController _buildUI]):
504         (-[WebTextCompletionController _placePopupWindow:]):
505         * WebView/WebVideoFullscreenController.mm:
506         * WebView/WebVideoFullscreenHUDWindowController.mm:
507         (createMediaUIBackgroundView):
508         * WebView/WebView.mm:
509         (-[WebTextListTouchBarViewController initWithWebView:]):
510         (-[WebView _dispatchTileDidDraw:]):
511         (-[WebView encodeWithCoder:]):
512         (-[WebView mainFrameIcon]):
513         (LayerFlushController::flushLayers):
514         * WebView/WebWindowAnimation.mm:
515         (setScaledFrameForWindow):
516
517 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
518
519         Remove unused needsDestruction class variables from HashTraits
520         https://bugs.webkit.org/show_bug.cgi?id=189490
521
522         Reviewed by Daniel Bates.
523
524         * History/BinaryPropertyList.cpp: Removed needsDestruction.
525
526 2018-09-07  Frederic Wang  <fwang@igalia.com>
527
528         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
529         https://bugs.webkit.org/show_bug.cgi?id=182230
530
531         Reviewed by Simon Fraser.
532
533         * DOM/DOMDocument.mm:
534         (-[DOMDocument scrollingElement]): Use the new name.
535
536 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
537
538         Refactor WebCore::EditAction to be an 8-bit enum class
539         https://bugs.webkit.org/show_bug.cgi?id=189383
540
541         Reviewed by Dan Bernstein.
542
543         * WebCoreSupport/WebEditorClient.mm:
544         (undoNameForEditAction):
545         * WebView/WebHTMLView.mm:
546         (-[WebHTMLView pasteFont:]):
547         (-[WebHTMLView changeFont:]):
548         (-[WebHTMLView changeAttributes:]):
549         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
550         (-[WebHTMLView changeColor:]):
551         * WebView/WebView.mm:
552         (-[WebView setTypingStyle:]):
553
554 2018-09-06  Frederic Wang  <fwang@igalia.com>
555
556         Group options of scrollRectToVisible into a struct
557         https://bugs.webkit.org/show_bug.cgi?id=189352
558
559         Reviewed by Simon Fraser.
560
561         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
562         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
563         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
564
565 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
566
567         [macOS] Cannot change font size at selection until font panel is shown
568         https://bugs.webkit.org/show_bug.cgi?id=189295
569         <rdar://problem/35593389>
570
571         Reviewed by Ryosuke Niwa.
572
573         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
574         WebCore ChangeLog for more details.
575
576         * WebView/WebHTMLView.mm:
577         (-[WebHTMLView changeFont:]):
578         (-[WebHTMLView changeAttributes:]):
579         (-[WebHTMLView _originalFontA]): Deleted.
580         (-[WebHTMLView _originalFontB]): Deleted.
581         (fontNameForDescription): Deleted.
582         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
583         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
584         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
585
586 2018-09-05  Jer Noble  <jer.noble@apple.com>
587
588         Add MediaCapabilities as an Experimental Feature
589         https://bugs.webkit.org/show_bug.cgi?id=189209
590
591         Reviewed by Eric Carlson.
592
593         RuntimeEnabledFeature -> Setting.
594
595         * WebView/WebView.mm:
596         (-[WebView _preferencesChanged:]):
597
598 2018-09-04  Frederic Wang  <fwang@igalia.com>
599
600         Add basic support for ScrollIntoViewOptions
601         https://bugs.webkit.org/show_bug.cgi?id=189258
602
603         Reviewed by Simon Fraser.
604
605         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
606         header so that this file can build despite the new scrollIntoView function.
607
608 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
609
610         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
611         https://bugs.webkit.org/show_bug.cgi?id=188890
612         <rdar://problem/43648605>
613
614         Reviewed by Tim Horton.
615
616         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
617         more detail.
618
619         * WebCoreSupport/WebPlatformStrategies.h:
620         * WebCoreSupport/WebPlatformStrategies.mm:
621         (WebPlatformStrategies::allStringsForType):
622
623 2018-09-01  Darin Adler  <darin@apple.com>
624
625         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
626         https://bugs.webkit.org/show_bug.cgi?id=189072
627         Reviewed by Dan Bernstein.
628
629         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
630         and declarations for NSURLDownload init methods.
631
632         * Misc/WebDownloadInternal.h: Removed.
633
634         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
635         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
636         "-Wdeprecated-declarations" because the method used here is deprecated.
637
638         * WebView/WebView.mm:
639         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
640         used here is deprecated.
641
642 2018-08-31  Chris Dumez  <cdumez@apple.com>
643
644         Assertion hit in ~CompletionHandler() from ~WebFrame()
645         https://bugs.webkit.org/show_bug.cgi?id=189199
646         <rdar://problem/42657233>
647
648         Reviewed by Youenn Fablet.
649
650         * WebCoreSupport/WebFrameLoaderClient.h:
651         * WebCoreSupport/WebFrameLoaderClient.mm:
652         (WebFrameLoaderClient::dispatchWillSubmitForm):
653
654 2018-08-31  Antti Koivisto  <antti@apple.com>
655
656         Replace OptionSet |= and -= operators with add() and remove() functions
657         https://bugs.webkit.org/show_bug.cgi?id=189169
658
659         Reviewed by Anders Carlsson.
660
661         * WebView/WebFrame.mm:
662         (-[WebFrame _drawRect:contentsOnly:]):
663         * WebView/WebView.mm:
664         (coreOptions):
665
666 2018-08-31  Frederic Wang  <fwang@igalia.com>
667
668         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
669         https://bugs.webkit.org/show_bug.cgi?id=182053
670
671         Reviewed by Simon Fraser.
672
673         Add developer flag to use standard behavior for scrolling* attributes.
674
675         * WebView/WebPreferenceKeysPrivate.h:
676         * WebView/WebPreferences.mm:
677         (+[WebPreferences initialize]):
678         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
679         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
680         * WebView/WebPreferencesPrivate.h:
681         * WebView/WebView.mm:
682         (-[WebView _preferencesChanged:]):
683
684 2018-08-29  Olivia Barnett  <obarnett@apple.com>
685
686         Implement the Web Share API
687         https://bugs.webkit.org/show_bug.cgi?id=171100
688         <rdar://problem/31751734>
689
690         Reviewed by Tim Horton.
691
692         * WebCoreSupport/WebChromeClient.h:
693         * WebCoreSupport/WebChromeClient.mm:
694         (WebChromeClient::showShareSheet):
695         Empty declaration of showShareSheet.
696
697 2018-08-29  Youenn Fablet  <youenn@apple.com>
698
699         Remove WebRTC legacy API implementation
700         https://bugs.webkit.org/show_bug.cgi?id=189040
701
702         Reviewed by Eric Carlson.
703
704         * WebView/WebPreferenceKeysPrivate.h:
705         * WebView/WebPreferences.mm:
706         (+[WebPreferences initialize]):
707         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
708         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
709         * WebView/WebPreferencesPrivate.h:
710         * WebView/WebView.mm:
711         (-[WebView _preferencesChanged:]):
712
713 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
714
715         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
716         https://bugs.webkit.org/show_bug.cgi?id=189054
717
718         Reviewed by Andy Estes.
719
720         Remove the pasteboard type argument from readURLFromPasteboard.
721
722         * WebCoreSupport/WebPlatformStrategies.h:
723         * WebCoreSupport/WebPlatformStrategies.mm:
724         (WebPlatformStrategies::readURLFromPasteboard):
725
726 2018-08-27  Keith Rollin  <krollin@apple.com>
727
728         Unreviewed build fix -- disable LTO for production builds
729
730         * Configurations/Base.xcconfig:
731
732 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
733
734         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
735         https://bugs.webkit.org/show_bug.cgi?id=188931
736
737         Reviewed by Wenson Hsieh.
738
739         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
740
741 2018-08-27  Keith Rollin  <krollin@apple.com>
742
743         Build system support for LTO
744         https://bugs.webkit.org/show_bug.cgi?id=187785
745         <rdar://problem/42353132>
746
747         Reviewed by Dan Bernstein.
748
749         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
750         LTO.
751
752         * Configurations/Base.xcconfig:
753         * Configurations/DebugRelease.xcconfig:
754
755 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
756
757         Pass in IsComposed flag to Event constructors
758         https://bugs.webkit.org/show_bug.cgi?id=188720
759         <rdar://problem/43580387>
760
761         Reviewed by Simon Fraser.
762
763         * WebView/WebPDFView.mm:
764         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
765         whether it's simulated or not.
766
767 2018-08-23  Mark Lam  <mark.lam@apple.com>
768
769         Move vmEntryGlobalObject() to VM from CallFrame.
770         https://bugs.webkit.org/show_bug.cgi?id=188900
771         <rdar://problem/43655753>
772
773         Reviewed by Michael Saboff.
774
775         * WebView/WebScriptDebugger.mm:
776         (WebScriptDebugger::sourceParsed):
777
778 2018-08-23  Andy Estes  <aestes@apple.com>
779
780         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
781         https://bugs.webkit.org/show_bug.cgi?id=188829
782
783         Reviewed by Tim Horton.
784
785         * Configurations/FeatureDefines.xcconfig:
786
787 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
788
789         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
790         https://bugs.webkit.org/show_bug.cgi?id=188777
791
792         Reviewed by Simon Fraser.
793
794         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
795         being "true" before the code change.
796
797         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
798
799         * WebView/WebPDFView.mm:
800         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
801
802 2018-08-21  Daniel Bates  <dabates@apple.com>
803
804         Replace TextCheckingTypeMask with OptionSet
805         https://bugs.webkit.org/show_bug.cgi?id=188678
806
807         Reviewed by Antti Koivisto.
808
809         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
810         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
811         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
812         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
813
814         * WebCoreSupport/WebEditorClient.h:
815         * WebCoreSupport/WebEditorClient.mm:
816         (WebEditorClient::checkTextOfParagraph):
817         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
818         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
819         left as this is more readable and unncessary now that modern compilers like Clang have
820         diagnostics to catch accidental assignments when equality was intended.
821         (WebEditorClient::didCheckSucceed):
822         * WebView/WebView.mm:
823         (coreTextCheckingType):
824         (textCheckingResultFromNSTextCheckingResult):
825
826 2018-08-21  Daniel Bates  <dabates@apple.com>
827
828         [iOS][WK1] Support toggling continuous spell checking from tests
829         https://bugs.webkit.org/show_bug.cgi?id=188763
830
831         Reviewed by Simon Fraser.
832
833         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
834         spell checking from tests in iOS WebKit Legacy.
835
836         * WebCoreSupport/WebEditorClient.h:
837         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
838         * WebCoreSupport/WebEditorClient.mm:
839         * WebView/WebView.h:
840         * WebView/WebView.mm:
841         (-[WebView toggleContinuousSpellChecking:]):
842         (-[WebView toggleSmartInsertDelete:]):
843
844 2018-08-17  Alex Christensen  <achristensen@webkit.org>
845
846         Add some plumbing for safe browsing
847         https://bugs.webkit.org/show_bug.cgi?id=188709
848
849         Reviewed by Tim Horton.
850
851         * WebCoreSupport/WebFrameLoaderClient.h:
852         * WebCoreSupport/WebFrameLoaderClient.mm:
853         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
854
855 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
856
857         Replace canBubble and cancelable booleans in Event by enum classes
858         https://bugs.webkit.org/show_bug.cgi?id=188692
859
860         Reviewed by Alex Christensen.
861
862         * WebView/WebPDFView.mm:
863         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
864         * WebView/WebView.mm:
865         (-[WebView _dispatchUnloadEvent]):
866
867 2018-08-16  Jer Noble  <jer.noble@apple.com>
868
869         Add Experimental Feature support for SourceBuffer.changeType()
870         https://bugs.webkit.org/show_bug.cgi?id=188626
871         <rdar://problem/43356021>
872
873         Reviewed by Eric Carlson.
874
875         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
876
877         * WebView/WebPreferenceKeysPrivate.h:
878         * WebView/WebPreferences.mm:
879         (+[WebPreferences initialize]):
880         (-[WebPreferences sourceBufferChangeTypeEnabled]):
881         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
882         * WebView/WebPreferencesPrivate.h:
883         * WebView/WebView.mm:
884         (-[WebView _preferencesChanged:]):
885
886 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
887
888         Support drag-and-drop for input[type=color]
889         https://bugs.webkit.org/show_bug.cgi?id=188464
890
891         Reviewed by Wenson Hsieh.
892
893         * WebCoreSupport/WebPlatformStrategies.h:
894         * WebCoreSupport/WebPlatformStrategies.mm:
895         (WebPlatformStrategies::setColor):
896
897 2018-08-15  Tim Horton  <timothy_horton@apple.com>
898
899         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
900         https://bugs.webkit.org/show_bug.cgi?id=188569
901         <rdar://problem/34201095>
902
903         Reviewed by Megan Gardner.
904
905         * WebView/WebImmediateActionController.mm:
906         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
907         Speculative fix; the crashes indicate font is null, but we just checked it,
908         so it must be getting made null by convertFont:toSize:. Check again!
909
910 2018-08-13  Alex Christensen  <achristensen@webkit.org>
911
912         Use a 1-byte enum class for TextDirection
913         https://bugs.webkit.org/show_bug.cgi?id=188350
914
915         Reviewed by Simon Fraser.
916
917         * WebCoreSupport/PopupMenuMac.mm:
918         (PopupMenuMac::populate):
919         (PopupMenuMac::show):
920         * WebCoreSupport/WebFrameLoaderClient.mm:
921         (WebFrameLoaderClient::transitionToCommittedForNewPage):
922         * WebView/WebFrame.mm:
923         (-[WebFrame _dispatchDidReceiveTitle:]):
924
925 2018-08-09  Ali Juma  <ajuma@chromium.org>
926
927         Import WPTs for IntersectionObserver
928         https://bugs.webkit.org/show_bug.cgi?id=188416
929
930         Reviewed by Simon Fraser.
931
932         * WebView/WebPreferencesPrivate.h:
933
934 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
935
936         Follow-up build fix for r234685
937         https://bugs.webkit.org/show_bug.cgi?id=188245
938
939         Unreviewed build fix.
940
941         * WebCoreSupport/WebSecurityOriginPrivate.h:
942
943 2018-08-05  Darin Adler  <darin@apple.com>
944
945         [Cocoa] More tweaks and refactoring to prepare for ARC
946         https://bugs.webkit.org/show_bug.cgi?id=188245
947
948         Reviewed by Dan Bernstein.
949
950         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
951
952         * Carbon/CarbonWindowFrame.m:
953         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
954
955         * DOM/DOM.mm:
956         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
957         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
958         garbage collection so this method isn't useful.
959
960         * DOM/DOMXPath.mm:
961         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
962         Objective-C garbage collection so this method isn't useful.
963
964         * History/WebHistory.mm:
965         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
966
967         * Misc/WebElementDictionary.mm:
968         (addLookupKey): Use a bridging cast.
969         (cacheValueForKey): Ditto.
970         (-[WebElementDictionary _fillCache]): Ditto.
971         (-[WebElementDictionary objectForKey:]): Ditto.
972
973         * Misc/WebKitNSStringExtras.mm:
974         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
975         (-[NSString _web_widthWithFont:]): Ditto.
976         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
977
978         * Misc/WebLocalizableStrings.mm:
979         (WebLocalizedString): Use a bridging cast.
980
981         * Misc/WebNSDataExtras.mm:
982         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
983         and use CFBridgingRelease instead of calling autorelease directly.
984         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
985         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
986         on the amount of explicit release and autorelease.
987
988         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
989         * Misc/WebNSDictionaryExtras.m:
990         (-[NSDictionary _webkit_intForKey:]): Deleted.
991         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
992         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
993         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
994         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
995         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
996         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
997
998         * Misc/WebStringTruncator.mm:
999         (fontFromNSFont): Use a bridging cast.
1000
1001         * Plugins/Hosted/NetscapePluginHostManager.mm:
1002         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
1003
1004         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1005         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
1006         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
1007         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
1008         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
1009         * Plugins/Hosted/ProxyInstance.mm:
1010         (WebKit::ProxyInstance::getPropertyNames): Ditto.
1011         * Plugins/WebBasePluginPackage.mm:
1012         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
1013         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1014         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
1015         * Plugins/WebNetscapePluginPackage.mm:
1016         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
1017
1018         * Plugins/WebNetscapePluginView.mm:
1019         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
1020         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
1021         (-[WebNetscapePluginView status:]): Use a bridging cast.
1022         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
1023
1024         * Plugins/WebPluginController.mm:
1025         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
1026
1027         * Plugins/WebPluginDatabase.mm:
1028         (checkCandidate): Use explicit __strong for out argument types.
1029
1030         * Plugins/npapi.mm:
1031         (pluginViewForInstance): Use a bridging cast.
1032
1033         * Storage/WebDatabaseManager.mm:
1034         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
1035         explicit NSNumber and NSDictionary calls.
1036
1037         * WebCoreSupport/WebContextMenuClient.mm:
1038         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
1039
1040         * WebCoreSupport/WebEditorClient.mm:
1041         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
1042         (WebEditorClient::handleInputMethodKeydown): Ditto.
1043
1044         * WebCoreSupport/WebFrameNetworkingContext.mm:
1045         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
1046
1047         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
1048         as a struct rather than an Objective-C class, since that's how it's defined.
1049
1050         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
1051
1052         * WebView/WebFullScreenController.mm:
1053         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
1054         * WebView/WebHTMLView.mm:
1055         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1056         Ditto.
1057         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1058
1059         * WebView/WebImmediateActionController.mm:
1060         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
1061         go down to the document and then back to the frame.
1062         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
1063         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
1064         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
1065
1066         * WebView/WebJSPDFDoc.mm:
1067         (jsPDFDocInitialize): Removed some unneeded type casting.
1068         (jsPDFDocFinalize): Ditto.
1069         (jsPDFDocPrint): Use a bridging cast.
1070
1071         * WebView/WebPDFView.mm:
1072         (_applicationInfoForMIMEType): Use bridging casts.
1073
1074         * WebView/WebPreferences.mm:
1075         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
1076         instead of methods from WebNSDictionaryExtras.
1077         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
1078         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
1079         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
1080         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
1081         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
1082
1083         * WebView/WebView.mm:
1084         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
1085         (-[WebView _addToAllWebViewsSet]): Ditto.
1086         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
1087         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
1088         so it can be called from WebViewData methods.
1089
1090         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
1091         method, _windowVisibilityChanged:.
1092
1093         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
1094         called from WebViewData methods.
1095
1096 2018-08-06  Alex Christensen  <achristensen@webkit.org>
1097
1098         Use enum classes and OptionSets for PaintPhase and PaintBehavior
1099         https://bugs.webkit.org/show_bug.cgi?id=188323
1100
1101         Reviewed by Simon Fraser.
1102
1103         * WebCoreSupport/WebContextMenuClient.mm:
1104         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1105         * WebView/WebFrame.mm:
1106         (-[WebFrame _paintBehaviorForDestinationContext:]):
1107         (-[WebFrame _drawRect:contentsOnly:]):
1108         * WebView/WebHTMLView.mm:
1109         (imageFromRect):
1110         (selectionImage):
1111
1112 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
1113
1114         Add support for microtasks in workers
1115         https://bugs.webkit.org/show_bug.cgi?id=188246
1116
1117         Reviewed by Darin Adler.
1118
1119         Rename JSMainThreadExecState.h to JSExecState.h.
1120
1121         * DOM/DOMAttr.mm:
1122         * DOM/DOMBlob.mm:
1123         * DOM/DOMCDATASection.mm:
1124         * DOM/DOMCSSCharsetRule.mm:
1125         * DOM/DOMCSSFontFaceRule.mm:
1126         * DOM/DOMCSSImportRule.mm:
1127         * DOM/DOMCSSMediaRule.mm:
1128         * DOM/DOMCSSPageRule.mm:
1129         * DOM/DOMCSSPrimitiveValue.mm:
1130         * DOM/DOMCSSRule.mm:
1131         * DOM/DOMCSSRuleList.mm:
1132         * DOM/DOMCSSStyleDeclaration.mm:
1133         * DOM/DOMCSSStyleRule.mm:
1134         * DOM/DOMCSSStyleSheet.mm:
1135         * DOM/DOMCSSUnknownRule.mm:
1136         * DOM/DOMCSSValue.mm:
1137         * DOM/DOMCSSValueList.mm:
1138         * DOM/DOMCharacterData.mm:
1139         * DOM/DOMComment.mm:
1140         * DOM/DOMCounter.mm:
1141         * DOM/DOMDocument.mm:
1142         * DOM/DOMDocumentFragment.mm:
1143         * DOM/DOMDocumentType.mm:
1144         * DOM/DOMElement.mm:
1145         * DOM/DOMEvent.mm:
1146         * DOM/DOMFile.mm:
1147         * DOM/DOMFileList.mm:
1148         * DOM/DOMHTML.mm:
1149         * DOM/DOMHTMLAnchorElement.mm:
1150         * DOM/DOMHTMLAppletElement.mm:
1151         * DOM/DOMHTMLAreaElement.mm:
1152         * DOM/DOMHTMLBRElement.mm:
1153         * DOM/DOMHTMLBaseElement.mm:
1154         * DOM/DOMHTMLBaseFontElement.mm:
1155         * DOM/DOMHTMLBodyElement.mm:
1156         * DOM/DOMHTMLButtonElement.mm:
1157         * DOM/DOMHTMLCanvasElement.mm:
1158         * DOM/DOMHTMLCollection.mm:
1159         * DOM/DOMHTMLDListElement.mm:
1160         * DOM/DOMHTMLDirectoryElement.mm:
1161         * DOM/DOMHTMLDivElement.mm:
1162         * DOM/DOMHTMLDocument.mm:
1163         * DOM/DOMHTMLElement.mm:
1164         * DOM/DOMHTMLEmbedElement.mm:
1165         * DOM/DOMHTMLFieldSetElement.mm:
1166         * DOM/DOMHTMLFontElement.mm:
1167         * DOM/DOMHTMLFormElement.mm:
1168         * DOM/DOMHTMLFrameElement.mm:
1169         * DOM/DOMHTMLFrameSetElement.mm:
1170         * DOM/DOMHTMLHRElement.mm:
1171         * DOM/DOMHTMLHeadElement.mm:
1172         * DOM/DOMHTMLHeadingElement.mm:
1173         * DOM/DOMHTMLHtmlElement.mm:
1174         * DOM/DOMHTMLIFrameElement.mm:
1175         * DOM/DOMHTMLImageElement.mm:
1176         * DOM/DOMHTMLInputElement.mm:
1177         * DOM/DOMHTMLLIElement.mm:
1178         * DOM/DOMHTMLLabelElement.mm:
1179         * DOM/DOMHTMLLegendElement.mm:
1180         * DOM/DOMHTMLLinkElement.mm:
1181         * DOM/DOMHTMLMapElement.mm:
1182         * DOM/DOMHTMLMarqueeElement.mm:
1183         * DOM/DOMHTMLMediaElement.mm:
1184         * DOM/DOMHTMLMenuElement.mm:
1185         * DOM/DOMHTMLMetaElement.mm:
1186         * DOM/DOMHTMLModElement.mm:
1187         * DOM/DOMHTMLOListElement.mm:
1188         * DOM/DOMHTMLObjectElement.mm:
1189         * DOM/DOMHTMLOptGroupElement.mm:
1190         * DOM/DOMHTMLOptionElement.mm:
1191         * DOM/DOMHTMLOptionsCollection.mm:
1192         * DOM/DOMHTMLParagraphElement.mm:
1193         * DOM/DOMHTMLParamElement.mm:
1194         * DOM/DOMHTMLPreElement.mm:
1195         * DOM/DOMHTMLQuoteElement.mm:
1196         * DOM/DOMHTMLScriptElement.mm:
1197         * DOM/DOMHTMLSelectElement.mm:
1198         * DOM/DOMHTMLStyleElement.mm:
1199         * DOM/DOMHTMLTableCaptionElement.mm:
1200         * DOM/DOMHTMLTableCellElement.mm:
1201         * DOM/DOMHTMLTableColElement.mm:
1202         * DOM/DOMHTMLTableElement.mm:
1203         * DOM/DOMHTMLTableRowElement.mm:
1204         * DOM/DOMHTMLTableSectionElement.mm:
1205         * DOM/DOMHTMLTextAreaElement.mm:
1206         * DOM/DOMHTMLTitleElement.mm:
1207         * DOM/DOMHTMLUListElement.mm:
1208         * DOM/DOMHTMLVideoElement.mm:
1209         * DOM/DOMImplementation.mm:
1210         * DOM/DOMKeyboardEvent.mm:
1211         * DOM/DOMMediaError.mm:
1212         * DOM/DOMMediaList.mm:
1213         * DOM/DOMMouseEvent.mm:
1214         * DOM/DOMMutationEvent.mm:
1215         * DOM/DOMNamedNodeMap.mm:
1216         * DOM/DOMNode.mm:
1217         * DOM/DOMNodeIterator.mm:
1218         * DOM/DOMNodeList.mm:
1219         * DOM/DOMOverflowEvent.mm:
1220         * DOM/DOMProcessingInstruction.mm:
1221         * DOM/DOMProgressEvent.mm:
1222         * DOM/DOMRGBColor.mm:
1223         * DOM/DOMRange.mm:
1224         * DOM/DOMRect.mm:
1225         * DOM/DOMStyleSheet.mm:
1226         * DOM/DOMStyleSheetList.mm:
1227         * DOM/DOMText.mm:
1228         * DOM/DOMTextEvent.mm:
1229         * DOM/DOMTimeRanges.mm:
1230         * DOM/DOMTokenList.mm:
1231         * DOM/DOMTreeWalker.mm:
1232         * DOM/DOMUIEvent.mm:
1233         * DOM/DOMWheelEvent.mm:
1234         * DOM/DOMXPathExpression.mm:
1235         * DOM/DOMXPathResult.mm:
1236         * DOM/ObjCEventListener.mm:
1237
1238 2018-08-03  Alex Christensen  <achristensen@webkit.org>
1239
1240         Fix spelling of "overridden"
1241         https://bugs.webkit.org/show_bug.cgi?id=188315
1242
1243         Reviewed by Darin Adler.
1244
1245         * Misc/WebKitVersionChecks.mm:
1246         (setWebKitLinkTimeVersion):
1247         (WebKitLinkTimeVersion):
1248         * Plugins/WebBaseNetscapePluginView.mm:
1249         (-[WebBaseNetscapePluginView handleMouseMoved:]):
1250         * WebCoreSupport/PopupMenuMac.mm:
1251         (PopupMenuMac::populate):
1252
1253 2018-08-01  Nan Wang  <n_wang@apple.com>
1254
1255         AX: AOM: Add ARIA IDL Attribute Reflection
1256         https://bugs.webkit.org/show_bug.cgi?id=184676
1257         <rdar://problem/39476882>
1258
1259         Reviewed by Chris Fleizach.
1260
1261         * WebView/WebPreferenceKeysPrivate.h:
1262         * WebView/WebPreferences.mm:
1263         (+[WebPreferences initialize]):
1264         (-[WebPreferences ariaReflectionEnabled]):
1265         (-[WebPreferences setAriaReflectionEnabled:]):
1266         * WebView/WebPreferencesPrivate.h:
1267         * WebView/WebView.mm:
1268         (-[WebView _preferencesChanged:]):
1269
1270 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
1271
1272         Shrink GraphicsLayerCA
1273         https://bugs.webkit.org/show_bug.cgi?id=188141
1274
1275         Reviewed by Zalan Bujtas.
1276
1277         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
1278         * moving all the clone-related stuff into the lazily-allocated m_layerClones
1279         * moving all the animation-related stuff into the lazily-allocated m_animations
1280         * making enums be 8-bit
1281         * re-ordering data members
1282
1283         * WebView/WebView.mm:
1284         (-[WebView _setMediaLayer:forPluginView:]):
1285
1286 2018-07-30  Rob Buis  <rbuis@igalia.com>
1287
1288         Merge PlatformCookieJar functions into NetworkStorageSession
1289         https://bugs.webkit.org/show_bug.cgi?id=188137
1290
1291         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
1292
1293         Reviewed by Alex Christensen.
1294
1295         * WebCoreSupport/WebPlatformStrategies.mm:
1296         (WebPlatformStrategies::cookiesForDOM):
1297         (WebPlatformStrategies::setCookiesFromDOM):
1298         (WebPlatformStrategies::cookiesEnabled):
1299         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1300         (WebPlatformStrategies::getRawCookies):
1301         (WebPlatformStrategies::deleteCookie):
1302         * WebView/WebPreferences.mm:
1303         (+[WebPreferences _clearNetworkLoaderSession]):
1304
1305 2018-07-28  Darin Adler  <darin@apple.com>
1306
1307         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
1308         https://bugs.webkit.org/show_bug.cgi?id=188140
1309
1310         Reviewed by Sam Weinig.
1311
1312         * WebView/WebImmediateActionController.mm:
1313         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
1314         new DictionaryLookup function that returns a tuple instead of using an out argument.
1315
1316 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
1317
1318         [INTL] Remove INTL sub-feature compile flags
1319         https://bugs.webkit.org/show_bug.cgi?id=188081
1320
1321         Reviewed by Michael Catanzaro.
1322
1323         * Configurations/FeatureDefines.xcconfig:
1324
1325 2018-07-26  Commit Queue  <commit-queue@webkit.org>
1326
1327         Unreviewed, rolling out r234181 and r234189.
1328         https://bugs.webkit.org/show_bug.cgi?id=188075
1329
1330         These are not needed right now (Requested by thorton on
1331         #webkit).
1332
1333         Reverted changesets:
1334
1335         "Enable Web Content Filtering on watchOS"
1336         https://bugs.webkit.org/show_bug.cgi?id=187979
1337         https://trac.webkit.org/changeset/234181
1338
1339         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
1340         https://bugs.webkit.org/show_bug.cgi?id=187985
1341         https://trac.webkit.org/changeset/234189
1342
1343 2018-07-26  Timothy Hatcher  <timothy@apple.com>
1344
1345         Use the Page's appearance when converting pasteboard attributed strings.
1346         https://bugs.webkit.org/show_bug.cgi?id=188067
1347         rdar://problem/42632246
1348
1349         Reviewed by Wenson Hsieh.
1350
1351         * WebCoreSupport/WebEditorClient.mm:
1352         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
1353
1354 2018-07-25  Chris Dumez  <cdumez@apple.com>
1355
1356         navigator.userAgent may return outdated value after webView.customUserAgent is set
1357         https://bugs.webkit.org/show_bug.cgi?id=188009
1358         <rdar://problem/42566456>
1359
1360         Reviewed by Alex Christensen.
1361
1362         Let the page know when the user agent changes.
1363
1364         * WebView/WebView.mm:
1365         (-[WebView _preferencesChanged:]):
1366         (-[WebView setApplicationNameForUserAgent:]):
1367         (-[WebView _invalidateUserAgentCache]):
1368         (-[WebView setCustomUserAgent:]):
1369         * WebView/WebViewInternal.h:
1370
1371 2018-07-24  Tim Horton  <timothy_horton@apple.com>
1372
1373         Enable Web Content Filtering on watchOS
1374         https://bugs.webkit.org/show_bug.cgi?id=187979
1375         <rdar://problem/42559346>
1376
1377         Reviewed by Wenson Hsieh.
1378
1379         * Configurations/FeatureDefines.xcconfig:
1380
1381 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
1382
1383         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
1384         https://bugs.webkit.org/show_bug.cgi?id=187846
1385
1386         Reviewed by Simon Fraser.
1387
1388         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
1389
1390         * WebView/WebHTMLView.mm:
1391         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
1392         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
1393
1394 2018-07-11  Dean Jackson  <dino@apple.com>
1395
1396         Allow removal of white backgrounds
1397         https://bugs.webkit.org/show_bug.cgi?id=187574
1398         <rdar://problem/41146792>
1399
1400         Reviewed by Simon Fraser.
1401
1402         Add a new WebPreference for punching out white backgrounds.
1403
1404         * WebView/WebPreferenceKeysPrivate.h:
1405         * WebView/WebPreferences.mm:
1406         (+[WebPreferences initialize]):
1407         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
1408         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
1409         * WebView/WebPreferencesPrivate.h:
1410         * WebView/WebView.mm:
1411         (-[WebView _preferencesChanged:]):
1412
1413 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
1414
1415         Ensure WebKit stack is ad-hoc signed
1416         https://bugs.webkit.org/show_bug.cgi?id=187667
1417
1418         Reviewed by Alexey Proskuryakov.
1419
1420         * Configurations/Base.xcconfig:
1421
1422 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
1423
1424         REGRESSION (231276): Attempting to copy an image fails
1425         https://bugs.webkit.org/show_bug.cgi?id=187212
1426         <rdar://problem/41540074>
1427
1428         Reviewed by Ryosuke Niwa.
1429
1430         Renamed methods to make it clear that one URL and one title are being passed in.
1431
1432         * WebCoreSupport/WebPlatformStrategies.h:
1433         * WebCoreSupport/WebPlatformStrategies.mm:
1434         (WebPlatformStrategies::setURL):
1435
1436 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1437
1438         Disable cross-origin-window-policy by default
1439         https://bugs.webkit.org/show_bug.cgi?id=187509
1440
1441         Reviewed by Chris Dumez.
1442
1443         * WebView/WebPreferences.mm:
1444         (+[WebPreferences initialize]):
1445
1446 2018-07-09  Timothy Hatcher  <timothy@apple.com>
1447
1448         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
1449         https://bugs.webkit.org/show_bug.cgi?id=187425
1450         rdar://problem/39948240
1451
1452         Reviewed by Tim Horton.
1453
1454         * WebView/WebView.mm:
1455         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
1456         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
1457         a call in this method to setUseDarkAppearance.
1458         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
1459         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
1460         (-[WebView _updateDefaultAppearance]): Deleted.
1461         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
1462
1463 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
1464
1465         Shrink various loading-related enums to shrink CachedResource
1466         https://bugs.webkit.org/show_bug.cgi?id=187443
1467
1468         Reviewed by Chris Dumez.
1469
1470         * WebCoreSupport/WebFrameLoaderClient.mm:
1471         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1472         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1473         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1474         (WebFrameLoaderClient::dispatchWillSendRequest):
1475         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1476         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1477         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1478         (WebFrameLoaderClient::updateGlobalHistory):
1479         (WebFrameLoaderClient::canHandleRequest const):
1480         * WebView/WebDataSource.mm:
1481         (-[WebDataSource initialRequest]):
1482         (-[WebDataSource request]):
1483
1484 2018-07-09  Commit Queue  <commit-queue@webkit.org>
1485
1486         Unreviewed, rolling out r233612.
1487         https://bugs.webkit.org/show_bug.cgi?id=187475
1488
1489         Revision caused the api test LinkColorWithSystemAppearance to
1490         fail on all systems. (Requested by Truitt on #webkit).
1491
1492         Reverted changeset:
1493
1494         "Semantic colors don't update when accessibility Increase
1495         Contrast mode is enabled."
1496         https://bugs.webkit.org/show_bug.cgi?id=187425
1497         https://trac.webkit.org/changeset/233612
1498
1499 2018-07-06  Timothy Hatcher  <timothy@apple.com>
1500
1501         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
1502         https://bugs.webkit.org/show_bug.cgi?id=187425
1503         rdar://problem/39948240
1504
1505         Reviewed by Tim Horton.
1506
1507         * WebView/WebView.mm:
1508         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
1509         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
1510         a call in this method to setUseDarkAppearance.
1511         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
1512         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
1513         (-[WebView _updateDefaultAppearance]): Deleted.
1514         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
1515
1516 2018-07-05  Timothy Hatcher  <timothy@apple.com>
1517
1518         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
1519         https://bugs.webkit.org/show_bug.cgi?id=187369
1520         rdar://problem/41870420
1521
1522         Reviewed by Tim Horton.
1523
1524         * WebView/WebMediaPlaybackTargetPicker.mm:
1525         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
1526         * WebView/WebView.mm:
1527         (-[WebView _commonInitializationWithFrameName:groupName:]):
1528         (-[WebView _effectiveAppearanceIsDark]):
1529         (-[WebView _updateDefaultAppearance]):
1530         (-[WebView _defaultAppearance]): Deleted.
1531
1532 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
1533
1534         Youtube video pages crash after a couple of minutes
1535         https://bugs.webkit.org/show_bug.cgi?id=187316
1536
1537         Reviewed by Antti Koivisto.
1538
1539         * WebView/WebView.mm:
1540         (-[WebView _preferencesChanged:]):
1541
1542 2018-07-04  Tim Horton  <timothy_horton@apple.com>
1543
1544         Introduce PLATFORM(IOSMAC)
1545         https://bugs.webkit.org/show_bug.cgi?id=187315
1546
1547         Reviewed by Dan Bernstein.
1548
1549         * Configurations/Base.xcconfig:
1550         * Configurations/FeatureDefines.xcconfig:
1551
1552 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1553
1554         [iOS] DataTransfer.getData always returns the empty string when dropping text
1555         https://bugs.webkit.org/show_bug.cgi?id=187130
1556         <rdar://problem/41014117>
1557
1558         Reviewed by Ryosuke Niwa.
1559
1560         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
1561
1562         * WebCoreSupport/WebPlatformStrategies.h:
1563         * WebCoreSupport/WebPlatformStrategies.mm:
1564         (WebPlatformStrategies::allPasteboardItemInfo):
1565
1566 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
1567
1568         [Mac] AirPlay picker uses incorrect theme in Dark mode
1569         https://bugs.webkit.org/show_bug.cgi?id=187054
1570         <rdar://problem/41291093>
1571
1572         Reviewed by Timothy Hatcher.
1573
1574         * WebView/WebMediaPlaybackTargetPicker.mm:
1575         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
1576
1577 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1578
1579         [WTF] Add user-defined literal for ASCIILiteral
1580         https://bugs.webkit.org/show_bug.cgi?id=186839
1581
1582         Reviewed by Darin Adler.
1583
1584         * DOM/ExceptionHandlers.mm:
1585         (raiseDOMErrorException):
1586         * Plugins/Hosted/ProxyInstance.mm:
1587         (WebKit::ProxyInstance::invokeMethod):
1588         * Storage/WebDatabaseProvider.mm:
1589         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
1590
1591 2018-06-22  Timothy Hatcher  <timothy@apple.com>
1592
1593         Recalc styles every time defaultAppearance changes.
1594         https://bugs.webkit.org/show_bug.cgi?id=186866
1595         rdar://problem/41309805
1596
1597         Reviewed by Tim Horton.
1598
1599         * WebView/WebView.mm:
1600         (-[WebView _updateDefaultAppearance]):
1601         (-[WebView _setUseSystemAppearance:]):
1602         (-[WebView _useSystemAppearance]):
1603
1604 2018-06-20  Darin Adler  <darin@apple.com>
1605
1606         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
1607         https://bugs.webkit.org/show_bug.cgi?id=186875
1608
1609         Reviewed by Anders Carlsson.
1610
1611         * WebView/WebHTMLView.mm:
1612         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
1613         to write te file to.
1614         * WebView/WebPreferences.mm:
1615         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
1616         * WebView/WebView.mm:
1617         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
1618
1619 2018-06-12  Darin Adler  <darin@apple.com>
1620
1621         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
1622         https://bugs.webkit.org/show_bug.cgi?id=186526
1623
1624         Reviewed by Anders Carlsson.
1625
1626         * Plugins/Hosted/NetscapePluginHostManager.mm:
1627         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
1628
1629         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1630         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
1631         assignment rather than adoptNS/leakRef.
1632         * Plugins/WebNetscapePluginView.mm:
1633         (-[WebNetscapePluginView createPlugin]): Ditto.
1634
1635         * WebCoreSupport/WebContextMenuClient.mm:
1636         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
1637         RetainPtr::autorelease; no need to autorelease just to pass something as a function
1638         argument, so use RetainPtr::get instead.
1639
1640         * WebView/WebHTMLView.mm:
1641         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
1642         No need to autorelease the result when the return type is RetainPtr.
1643
1644         * WebView/WebPDFRepresentation.mm:
1645         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
1646
1647 2018-06-13  Youenn Fablet  <youenn@apple.com>
1648
1649         Supported plugin check should be based on plugin identifier
1650         https://bugs.webkit.org/show_bug.cgi?id=186578
1651         <rdar://problem/40523828>
1652
1653         Reviewed by Darin Adler.
1654
1655         * WebCoreSupport/WebPluginInfoProvider.h:
1656         * WebCoreSupport/WebPluginInfoProvider.mm:
1657         (WebPluginInfoProvider::pluginInfo):
1658         (WebPluginInfoProvider::webVisiblePluginInfo):
1659
1660 2018-06-13  Chris Dumez  <cdumez@apple.com>
1661
1662         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
1663         https://bugs.webkit.org/show_bug.cgi?id=186545
1664
1665         Reviewed by Brady Eidson.
1666
1667         Update client delegate now that parameter type has changed.
1668
1669         * WebCoreSupport/WebFrameLoaderClient.h:
1670         * WebCoreSupport/WebFrameLoaderClient.mm:
1671         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1672
1673 2018-06-11  Tim Horton  <timothy_horton@apple.com>
1674
1675         Link drag image is inconsistently unreadable in dark mode
1676         https://bugs.webkit.org/show_bug.cgi?id=186472
1677
1678         Reviewed by Timothy Hatcher.
1679
1680         * WebView/WebView.mm:
1681         (-[WebView _defaultAppearance]):
1682         Make defaultAppearance accurate even if useSystemAppearance is false.
1683         Some parts of WebKit (like the link drag image, but also context menus)
1684         want to be able to follow the system appearance regardless of whether
1685         the view or content has opted in.
1686
1687 2018-06-11  Chris Dumez  <cdumez@apple.com>
1688
1689         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
1690         https://bugs.webkit.org/show_bug.cgi?id=186441
1691
1692         Reviewed by Brady Eidson.
1693
1694         Rename existing flag to something a bit more generic, now that it is used for
1695         more things than bypassing the navigation policy check.
1696
1697         * WebView/WebView.mm:
1698         (-[WebView _loadBackForwardListFromOtherView:]):
1699         (-[WebView goToBackForwardItem:]):
1700
1701 2018-06-09  Dan Bernstein  <mitz@apple.com>
1702
1703         [Xcode] Clean up and modernize some build setting definitions
1704         https://bugs.webkit.org/show_bug.cgi?id=186463
1705
1706         Reviewed by Sam Weinig.
1707
1708         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
1709         * Configurations/DebugRelease.xcconfig: Ditto.
1710         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
1711           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
1712         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
1713         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
1714           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
1715         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
1716
1717 2018-06-08  Darin Adler  <darin@apple.com>
1718
1719         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
1720         https://bugs.webkit.org/show_bug.cgi?id=186436
1721
1722         Reviewed by Anders Carlsson.
1723
1724         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
1725         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
1726         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
1727         (PoolCleaner): Ditto.
1728
1729         * History/WebHistory.mm:
1730         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1731         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
1732         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
1733         now hardly used if at all.
1734         * WebView/WebView.mm:
1735         (-[WebView rectsForTextMatches]): Ditto.
1736
1737 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1738
1739         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
1740         https://bugs.webkit.org/show_bug.cgi?id=186442
1741         <rdar://problem/40879364>
1742
1743         Reviewed by Tim Horton.
1744
1745         * Configurations/FeatureDefines.xcconfig:
1746
1747 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
1748
1749         [Datalist] Allow TextFieldInputType to show and hide suggestions
1750         https://bugs.webkit.org/show_bug.cgi?id=186151
1751
1752         Reviewed by Tim Horton.
1753
1754         * WebCoreSupport/WebChromeClient.h:
1755         * WebCoreSupport/WebChromeClient.mm:
1756         (WebChromeClient::createDataListSuggestionPicker):
1757
1758 2018-06-07  Chris Dumez  <cdumez@apple.com>
1759
1760         Add base class to get WeakPtrFactory member and avoid some boilerplate code
1761         https://bugs.webkit.org/show_bug.cgi?id=186407
1762
1763         Reviewed by Brent Fulgham.
1764
1765         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
1766         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
1767         This also gets rid of old-style createWeakPtr() methods in favor of the newer
1768         makeWeakPtr().
1769
1770         * WebCoreSupport/WebEditorClient.h:
1771         * WebCoreSupport/WebEditorClient.mm:
1772         (WebEditorClient::requestCandidatesForSelection):
1773
1774 2018-06-05  Chris Dumez  <cdumez@apple.com>
1775
1776         Regression(r232082): Websites get loaded inside of Messages App chat transcript
1777         https://bugs.webkit.org/show_bug.cgi?id=186331
1778         <rdar://problem/40735446>
1779
1780         Reviewed by Darin Adler.
1781
1782         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
1783         but does not call use / ignore on the listener, then we would do "use" by default.
1784         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
1785         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
1786         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
1787         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
1788         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
1789         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
1790         and Box.app is still working properly.
1791
1792         * WebCoreSupport/WebFrameLoaderClient.h:
1793         * WebCoreSupport/WebFrameLoaderClient.mm:
1794         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
1795         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1796         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1797         (WebFrameLoaderClient::dispatchWillSubmitForm):
1798         (WebFrameLoaderClient::setUpPolicyListener):
1799         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
1800         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
1801         (-[WebFramePolicyListener dealloc]):
1802         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
1803         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
1804
1805 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
1806
1807         Adjust compile and runtime flags to match shippable state of features
1808         https://bugs.webkit.org/show_bug.cgi?id=186319
1809         <rdar://problem/40352045>
1810
1811         Reviewed by Maciej Stachowiak, Jon Lee, and others.
1812
1813         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
1814         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
1815         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
1816         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
1817         Cocoa builds.
1818
1819 2018-06-05  Timothy Hatcher  <timothy@apple.com>
1820
1821         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
1822
1823         https://bugs.webkit.org/show_bug.cgi?id=186323
1824         rdar://problem/38382252
1825
1826         Reviewed by Tim Horton.
1827
1828         * WebView/WebView.mm:
1829         (-[WebView _defaultAppearance]):
1830
1831 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
1832
1833         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
1834         https://bugs.webkit.org/show_bug.cgi?id=186286
1835         <rdar://problem/40782992>
1836
1837         Reviewed by Dan Bernstein.
1838
1839         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
1840         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
1841         change this flag when preparing for a production release.
1842
1843         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
1844         whether experimental features should be enabled, and use it to properly define the
1845         feature flag.
1846
1847 2018-06-03  Darin Adler  <darin@apple.com>
1848
1849         Simplify and remove some unused video element code (helpful for ARC-compatibility)
1850         https://bugs.webkit.org/show_bug.cgi?id=186258
1851
1852         Reviewed by Daniel Bates.
1853
1854         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
1855         forward declarations. Removed methods that don't need to be public.
1856
1857         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
1858         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
1859         unnamed category in here and also replaced the HUDWindowControllerDelegate
1860         with the unnamed category. Removed unused NSWindow category defining the
1861         isOnActiveSpace, which is not called anywhere in this file at this time.
1862         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
1863         into setVideoElement.
1864         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
1865         and removed unneeded typecast.
1866         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
1867         using statement at the top of the file.
1868         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
1869         the many side effects and special considerations that this method that sounds
1870         like a setter has. Updated code to use the new
1871         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
1872         HTMLVideoElement::platformMedia function. Also straightened out the logic a
1873         bit and added some FIXME comments about small problems noticed but not fixed.
1874         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
1875         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
1876         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
1877         typecast. Removed call to updatePowerAssertions method.
1878         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
1879         updatePowerAssertions method.
1880         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
1881         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
1882         else, so this was dead code that did nothing.
1883         (-[WebVideoFullscreenController rateChanged:]): Removed call to
1884         updatePowerAssertions method.
1885
1886 2018-06-04  Chris Dumez  <cdumez@apple.com>
1887
1888         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
1889         https://bugs.webkit.org/show_bug.cgi?id=186287
1890         <rdar://problem/40783352>
1891
1892         Reviewed by Youenn Fablet.
1893
1894         * WebView/WebPreferenceKeysPrivate.h:
1895         * WebView/WebPreferences.mm:
1896         (+[WebPreferences initialize]):
1897         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
1898         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
1899         * WebView/WebPreferencesPrivate.h:
1900         * WebView/WebView.mm:
1901         (-[WebView _preferencesChanged:]):
1902
1903 2018-06-02  Darin Adler  <darin@apple.com>
1904
1905         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
1906         https://bugs.webkit.org/show_bug.cgi?id=186227
1907
1908         Reviewed by Dan Bernstein.
1909
1910         * Misc/WebKitErrors.m:
1911         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
1912         * Plugins/WebPluginDatabase.mm:
1913         (-[WebPluginDatabase refresh]): Ditto.
1914         * WebCoreSupport/WebChromeClient.mm:
1915         (WebChromeClient::setStatusbarText): Ditto.
1916
1917 2018-06-01  Chris Dumez  <cdumez@apple.com>
1918
1919         REGRESSION (r231456): Colloquy is broken
1920         https://bugs.webkit.org/show_bug.cgi?id=186197
1921         <rdar://problem/40722960>
1922
1923         Reviewed by Timothy Hatcher.
1924
1925         Restore pre-r231456 behavior for Colloquy app so that it works again.
1926
1927         * WebView/WebView.mm:
1928         (-[WebView _needsFrameNameFallbackToIdQuirk]):
1929         (-[WebView _preferencesChanged:]):
1930
1931 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1932
1933         [JSC] Pass VM& parameter as much as possible
1934         https://bugs.webkit.org/show_bug.cgi?id=186085
1935
1936         Reviewed by Saam Barati.
1937
1938         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1939         (WebKit::NetscapePluginInstanceProxy::invoke):
1940
1941 2018-05-30  Daniel Bates  <dabates@apple.com>
1942
1943         NavigationAction does not need to hold initiating DOM Event
1944         https://bugs.webkit.org/show_bug.cgi?id=185958
1945         <rdar://problem/40531539>
1946
1947         Reviewed by Simon Fraser.
1948
1949         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
1950
1951         * WebCoreSupport/WebFrameLoaderClient.mm:
1952         (WebFrameLoaderClient::actionDictionary const):
1953         (findMouseEvent): Deleted.
1954
1955 2018-05-27  Dan Bernstein  <mitz@apple.com>
1956
1957         Reverted the changes made for https://webkit.org/b/186016
1958
1959         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
1960
1961
1962 2018-05-27  David Kilzer  <ddkilzer@apple.com>
1963
1964         [iOS] Fix warnings about leaks found by clang static analyzer
1965         <https://webkit.org/b/186009>
1966         <rdar://problem/40574267>
1967
1968         Reviewed by Daniel Bates.
1969
1970         * WebView/WebHTMLView.mm:
1971         (-[WebHTMLView doCommandBySelector:]): Fix use of an
1972         uninitialized boolean variable (`eventWasHandled`) that only
1973         happened on iOS.
1974
1975 2018-05-27  Dan Bernstein  <mitz@apple.com>
1976
1977         [Cocoa] Avoid importing directly from subumbrella frameworks
1978         https://bugs.webkit.org/show_bug.cgi?id=186016
1979
1980         Reviewed by Sam Weinig.
1981
1982         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1983         * Carbon/CarbonWindowAdapter.mm: Ditto.
1984         * Carbon/CarbonWindowFrame.m: Ditto.
1985         * Carbon/HIViewAdapter.h: Ditto.
1986         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
1987           OTHER_CPLUSPLUSFLAGS.
1988         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1989         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1990         * WebView/WebPDFView.h: Ditto.
1991
1992 2018-05-27  Sam Weinig  <sam@webkit.org>
1993
1994         Modernize RenderStyleConstants.h - Part 3
1995         https://bugs.webkit.org/show_bug.cgi?id=186015
1996
1997         Reviewed by Yusuke Suzuki.
1998
1999         * WebView/WebView.mm:
2000         (-[WebView updateTextTouchBar]):
2001         Update for new enum name.
2002
2003 2018-05-25  Chris Dumez  <cdumez@apple.com>
2004
2005         Minor ApplicationCacheStorage clean up
2006         https://bugs.webkit.org/show_bug.cgi?id=185984
2007
2008         Reviewed by Youenn Fablet.
2009
2010         * WebCoreSupport/WebApplicationCache.mm:
2011         (+[WebApplicationCache originsWithCache]):
2012
2013 2018-05-25  David Kilzer  <ddkilzer@apple.com>
2014
2015         Fix issues with -dealloc methods found by clang static analyzer
2016         <https://webkit.org/b/185887>
2017
2018         Reviewed by Joseph Pecoraro.
2019
2020         * WebView/WebView.mm:
2021         (-[WebUITextIndicatorData dealloc]):
2022         - Move method implementation from (WebUITextIndicatorInternal)
2023           category to the main category since this is public API.  This
2024           fixes the false positive warning about a missing -dealloc
2025           method.
2026
2027 2018-05-24  Sam Weinig  <sam@webkit.org>
2028
2029         Modernize RenderStyleConstants.h - Part 2
2030         https://bugs.webkit.org/show_bug.cgi?id=185901
2031
2032         Reviewed by Simon Fraser.
2033
2034         * WebView/WebHTMLRepresentation.mm:
2035         (searchForLabelsBeforeElement):
2036         * WebView/WebView.mm:
2037         (nsTextAlignmentFromRenderStyle):
2038         Update for new enum names.
2039
2040 2018-05-22  Chris Dumez  <cdumez@apple.com>
2041
2042         Regression(AsyncPolicyDelegates): Box.app login Window is blank
2043         https://bugs.webkit.org/show_bug.cgi?id=185832
2044         <rdar://problem/40307871>
2045
2046         Reviewed by Geoffrey Garen.
2047
2048         We used to have a bug where where we would fail to wait for the policy decision for
2049         the navigation response from the client and the load would keep going, racing with
2050         the client's policy decision. If the client did not respond in time, the behavior
2051         would be the same as "Use" policy action.
2052
2053         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
2054         but the load happened to proceed anyway due to our bug. Now that we've fixed the
2055         WebKit bug, however, the load would hang because the completion handler for the
2056         decidePolicyForNavigationResponse would never get called.
2057
2058         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
2059         instead of retaining it. If the policy listener object gets destroyed because getting
2060         resolved, we now use "Use" policy action in its dealloc function to maintain previous
2061         behavior.
2062
2063         * WebCoreSupport/WebFrameLoaderClient.h:
2064         * WebCoreSupport/WebFrameLoaderClient.mm:
2065         (WebFrameLoaderClient::cancelPolicyCheck):
2066         (WebFrameLoaderClient::setUpPolicyListener):
2067         (-[WebFramePolicyListener dealloc]):
2068
2069 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
2070
2071         Unreviewed, rolling out r232052.
2072
2073         Breaks internal builds.
2074
2075         Reverted changeset:
2076
2077         "Use more C++17"
2078         https://bugs.webkit.org/show_bug.cgi?id=185176
2079         https://trac.webkit.org/changeset/232052
2080
2081 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2082
2083         Use more C++17
2084         https://bugs.webkit.org/show_bug.cgi?id=185176
2085
2086         Reviewed by JF Bastien.
2087
2088         * Configurations/Base.xcconfig:
2089         * Configurations/WebKitLegacy.xcconfig:
2090
2091 2018-05-21  Chris Nardi  <cnardi@chromium.org>
2092
2093         Remove dead exception in MediaList.appendMedium
2094         https://bugs.webkit.org/show_bug.cgi?id=185278
2095
2096         Reviewed by Chris Dumez.
2097
2098         Remove code pertaining to an exception being thrown by appendMedium().
2099
2100         * DOM/DOMMediaList.mm:
2101         (-[DOMMediaList appendMedium:]):
2102
2103 2018-05-21  Jer Noble  <jer.noble@apple.com>
2104
2105         Complete fix for enabling modern EME by default
2106         https://bugs.webkit.org/show_bug.cgi?id=185770
2107         <rdar://problem/40368220>
2108
2109         Reviewed by Eric Carlson.
2110
2111         * Configurations/FeatureDefines.xcconfig:
2112
2113 2018-05-21  Antti Koivisto  <antti@apple.com>
2114
2115         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
2116         https://bugs.webkit.org/show_bug.cgi?id=185815
2117         <rdar://problem/40310069>
2118
2119         Reviewed by Simon Fraser.
2120
2121         User stylesheet parsing may depend on the colorFilterEnabled preference.
2122
2123         * WebView/WebView.mm:
2124         (-[WebView _preferencesChanged:]):
2125
2126 2018-05-18  Commit Queue  <commit-queue@webkit.org>
2127
2128         Unreviewed, rolling out r231982.
2129         https://bugs.webkit.org/show_bug.cgi?id=185793
2130
2131         Caused layout test failures (Requested by realdawei on
2132         #webkit).
2133
2134         Reverted changeset:
2135
2136         "Complete fix for enabling modern EME by default"
2137         https://bugs.webkit.org/show_bug.cgi?id=185770
2138         https://trac.webkit.org/changeset/231982
2139
2140 2018-05-18  Jer Noble  <jer.noble@apple.com>
2141
2142         Complete fix for enabling modern EME by default
2143         https://bugs.webkit.org/show_bug.cgi?id=185770
2144         <rdar://problem/40368220>
2145
2146         Reviewed by Eric Carlson.
2147
2148         * Configurations/FeatureDefines.xcconfig:
2149
2150 2018-05-18  Chris Dumez  <cdumez@apple.com>
2151
2152         Avoid keeping the frame alive when ref'ing a WindowProxy
2153         https://bugs.webkit.org/show_bug.cgi?id=185737
2154         <rdar://problem/40004666>
2155
2156         Reviewed by Sam Weinig.
2157
2158         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2159         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2160
2161 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
2162
2163         Add support for Intl NumberFormat formatToParts
2164         https://bugs.webkit.org/show_bug.cgi?id=185375
2165
2166         Reviewed by Yusuke Suzuki.
2167
2168         Add flag for NumberFormat formatToParts.
2169
2170         * Configurations/FeatureDefines.xcconfig:
2171
2172 2018-05-16  Chris Nardi  <cnardi@chromium.org>
2173
2174         Fixup after r231849: Do not mark Mac API methods as deprecated
2175         https://bugs.webkit.org/show_bug.cgi?id=185684
2176
2177         Reviewed by Darin Adler.
2178
2179         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
2180         as the entire class is already marked as deprecated, so it is unnecessary.
2181
2182         * DOM/DOMDocument.h:
2183
2184 2018-05-16  Chris Nardi  <cnardi@chromium.org>
2185
2186         Remove Document#selectedStylesheetSet/preferredStylesheetSet
2187         https://bugs.webkit.org/show_bug.cgi?id=185381
2188
2189         Reviewed by Darin Adler.
2190
2191         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
2192         and make them do nothing.
2193
2194         * DOM/DOMDocument.h:
2195         * DOM/DOMDocument.mm:
2196         (-[DOMDocument preferredStylesheetSet]):
2197         (-[DOMDocument selectedStylesheetSet]):
2198         (-[DOMDocument setSelectedStylesheetSet:]):
2199
2200 2018-05-15  Antoine Quint  <graouts@apple.com>
2201
2202         [Web Animations] Expose Web Animations CSS integration as an experimental feature
2203         https://bugs.webkit.org/show_bug.cgi?id=185647
2204
2205         Reviewed by Dean Jackson.
2206
2207         Rename the Web Animations CSS integration flag.
2208
2209         * WebView/WebPreferenceKeysPrivate.h:
2210         * WebView/WebPreferences.mm:
2211         (+[WebPreferences initialize]):
2212         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
2213         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
2214         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
2215         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
2216         * WebView/WebPreferencesPrivate.h:
2217         * WebView/WebView.mm:
2218         (-[WebView _preferencesChanged:]):
2219
2220 2018-05-14  Daniel Bates  <dabates@apple.com>
2221
2222         Fix the Apple Internal build
2223
2224         See <rdar://problem/40237873> for more details.
2225
2226         * WebView/WebFullScreenController.mm:
2227         (-[WebFullScreenController enterFullScreen:]):
2228         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2229         (-[WebFullScreenController exitFullScreen]):
2230         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2231         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2232         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2233
2234 2018-05-11  Timothy Hatcher  <timothy@apple.com>
2235
2236         WebHTMLView is not setting aside subviews when drawing.
2237
2238         https://bugs.webkit.org/show_bug.cgi?id=185561
2239         rdar://problem/40172894
2240
2241         Reviewed by Simon Fraser.
2242
2243         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
2244
2245         * WebView/WebHTMLView.mm:
2246         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
2247
2248 2018-05-07  Daniel Bates  <dabates@apple.com>
2249
2250         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
2251         https://bugs.webkit.org/show_bug.cgi?id=185170
2252
2253         Reviewed by Per Arne Vollan.
2254
2255         * Misc/WebCache.mm:
2256         (+[WebCache empty]):
2257
2258 2018-05-04  Timothy Hatcher  <timothy@apple.com>
2259
2260         Deprecate legacy WebView and friends
2261         https://bugs.webkit.org/show_bug.cgi?id=185279
2262         rdar://problem/33268700
2263
2264         Reviewed by Tim Horton.
2265
2266         Added deprecation macros to all the classes, extern strings, and enums.
2267
2268         * Configurations/WebKitLegacy.xcconfig:
2269         Added BUILDING_WEBKIT define to disable the deprecation macros.
2270         * DOM/DOMAbstractView.h:
2271         * DOM/DOMAttr.h:
2272         * DOM/DOMBlob.h:
2273         * DOM/DOMCDATASection.h:
2274         * DOM/DOMCSSCharsetRule.h:
2275         * DOM/DOMCSSFontFaceRule.h:
2276         * DOM/DOMCSSImportRule.h:
2277         * DOM/DOMCSSMediaRule.h:
2278         * DOM/DOMCSSPageRule.h:
2279         * DOM/DOMCSSPrimitiveValue.h:
2280         * DOM/DOMCSSRule.h:
2281         * DOM/DOMCSSRuleList.h:
2282         * DOM/DOMCSSStyleDeclaration.h:
2283         * DOM/DOMCSSStyleRule.h:
2284         * DOM/DOMCSSStyleSheet.h:
2285         * DOM/DOMCSSUnknownRule.h:
2286         * DOM/DOMCSSValue.h:
2287         * DOM/DOMCSSValueList.h:
2288         * DOM/DOMCharacterData.h:
2289         * DOM/DOMComment.h:
2290         * DOM/DOMCounter.h:
2291         * DOM/DOMDocument.h:
2292         * DOM/DOMDocumentFragment.h:
2293         * DOM/DOMDocumentType.h:
2294         * DOM/DOMElement.h:
2295         * DOM/DOMEntity.h:
2296         * DOM/DOMEntityReference.h:
2297         * DOM/DOMEvent.h:
2298         * DOM/DOMEventException.h:
2299         * DOM/DOMEventListener.h:
2300         * DOM/DOMEventTarget.h:
2301         * DOM/DOMException.h:
2302         * DOM/DOMFile.h:
2303         * DOM/DOMFileList.h:
2304         * DOM/DOMHTMLAnchorElement.h:
2305         * DOM/DOMHTMLAppletElement.h:
2306         * DOM/DOMHTMLAreaElement.h:
2307         * DOM/DOMHTMLBRElement.h:
2308         * DOM/DOMHTMLBaseElement.h:
2309         * DOM/DOMHTMLBaseFontElement.h:
2310         * DOM/DOMHTMLBodyElement.h:
2311         * DOM/DOMHTMLButtonElement.h:
2312         * DOM/DOMHTMLCanvasElement.h:
2313         * DOM/DOMHTMLCollection.h:
2314         * DOM/DOMHTMLDListElement.h:
2315         * DOM/DOMHTMLDirectoryElement.h:
2316         * DOM/DOMHTMLDivElement.h:
2317         * DOM/DOMHTMLDocument.h:
2318         * DOM/DOMHTMLElement.h:
2319         * DOM/DOMHTMLEmbedElement.h:
2320         * DOM/DOMHTMLFieldSetElement.h:
2321         * DOM/DOMHTMLFontElement.h:
2322         * DOM/DOMHTMLFormElement.h:
2323         * DOM/DOMHTMLFrameElement.h:
2324         * DOM/DOMHTMLFrameSetElement.h:
2325         * DOM/DOMHTMLHRElement.h:
2326         * DOM/DOMHTMLHeadElement.h:
2327         * DOM/DOMHTMLHeadingElement.h:
2328         * DOM/DOMHTMLHtmlElement.h:
2329         * DOM/DOMHTMLIFrameElement.h:
2330         * DOM/DOMHTMLImageElement.h:
2331         * DOM/DOMHTMLInputElement.h:
2332         * DOM/DOMHTMLLIElement.h:
2333         * DOM/DOMHTMLLabelElement.h:
2334         * DOM/DOMHTMLLegendElement.h:
2335         * DOM/DOMHTMLLinkElement.h:
2336         * DOM/DOMHTMLMapElement.h:
2337         * DOM/DOMHTMLMarqueeElement.h:
2338         * DOM/DOMHTMLMediaElement.h:
2339         * DOM/DOMHTMLMenuElement.h:
2340         * DOM/DOMHTMLMetaElement.h:
2341         * DOM/DOMHTMLModElement.h:
2342         * DOM/DOMHTMLOListElement.h:
2343         * DOM/DOMHTMLObjectElement.h:
2344         * DOM/DOMHTMLOptGroupElement.h:
2345         * DOM/DOMHTMLOptionElement.h:
2346         * DOM/DOMHTMLOptionsCollection.h:
2347         * DOM/DOMHTMLParagraphElement.h:
2348         * DOM/DOMHTMLParamElement.h:
2349         * DOM/DOMHTMLPreElement.h:
2350         * DOM/DOMHTMLQuoteElement.h:
2351         * DOM/DOMHTMLScriptElement.h:
2352         * DOM/DOMHTMLSelectElement.h:
2353         * DOM/DOMHTMLStyleElement.h:
2354         * DOM/DOMHTMLTableCaptionElement.h:
2355         * DOM/DOMHTMLTableCellElement.h:
2356         * DOM/DOMHTMLTableColElement.h:
2357         * DOM/DOMHTMLTableElement.h:
2358         * DOM/DOMHTMLTableRowElement.h:
2359         * DOM/DOMHTMLTableSectionElement.h:
2360         * DOM/DOMHTMLTextAreaElement.h:
2361         * DOM/DOMHTMLTitleElement.h:
2362         * DOM/DOMHTMLUListElement.h:
2363         * DOM/DOMHTMLVideoElement.h:
2364         * DOM/DOMImplementation.h:
2365         * DOM/DOMKeyboardEvent.h:
2366         * DOM/DOMMediaError.h:
2367         * DOM/DOMMediaList.h:
2368         * DOM/DOMMouseEvent.h:
2369         * DOM/DOMMutationEvent.h:
2370         * DOM/DOMNamedNodeMap.h:
2371         * DOM/DOMNode.h:
2372         * DOM/DOMNodeFilter.h:
2373         * DOM/DOMNodeIterator.h:
2374         * DOM/DOMNodeList.h:
2375         * DOM/DOMObject.h:
2376         * DOM/DOMOverflowEvent.h:
2377         * DOM/DOMProcessingInstruction.h:
2378         * DOM/DOMProgressEvent.h:
2379         * DOM/DOMRGBColor.h:
2380         * DOM/DOMRange.h:
2381         * DOM/DOMRangeException.h:
2382         * DOM/DOMRect.h:
2383         * DOM/DOMStyleSheet.h:
2384         * DOM/DOMStyleSheetList.h:
2385         * DOM/DOMText.h:
2386         * DOM/DOMTextEvent.h:
2387         * DOM/DOMTimeRanges.h:
2388         * DOM/DOMTokenList.h:
2389         * DOM/DOMTreeWalker.h:
2390         * DOM/DOMUIEvent.h:
2391         * DOM/DOMWheelEvent.h:
2392         * DOM/DOMXPathException.h:
2393         * DOM/DOMXPathExpression.h:
2394         * DOM/DOMXPathNSResolver.h:
2395         * DOM/DOMXPathResult.h:
2396         * History/WebBackForwardList.h:
2397         * History/WebHistory.h:
2398         * History/WebHistoryItem.h:
2399         * Misc/WebDownload.h:
2400         * Misc/WebKitErrors.h:
2401         * Plugins/WebPluginViewFactory.h:
2402         * WebView/WebArchive.h:
2403         * WebView/WebDataSource.h:
2404         * WebView/WebDocument.h:
2405         * WebView/WebEditingDelegate.h:
2406         * WebView/WebFormDelegate.h:
2407         * WebView/WebFrame.h:
2408         * WebView/WebFrameLoadDelegate.h:
2409         * WebView/WebFrameView.h:
2410         * WebView/WebPolicyDelegate.h:
2411         * WebView/WebPreferences.h:
2412         * WebView/WebPreferencesPrivate.h:
2413         * WebView/WebResourceLoadDelegate.h:
2414         * WebView/WebUIDelegate.h:
2415         * WebView/WebUIDelegatePrivate.h:
2416         * WebView/WebView.h:
2417         * WebView/WebViewPrivate.h:
2418         * postprocess-headers.sh:
2419         Remove step that converts WEBKIT macros to NS macros.
2420         Change it to just remove the macros on iOS builds.
2421
2422 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
2423
2424         [MediaStream] remove WK1 support
2425         https://bugs.webkit.org/show_bug.cgi?id=185136
2426
2427         Reviewed by Youenn Fablet.
2428
2429         * WebCoreSupport/WebUserMediaClient.h: Removed.
2430         * WebCoreSupport/WebUserMediaClient.mm: Removed.
2431         * WebView/WebView.mm:
2432         (-[WebView _commonInitializationWithFrameName:groupName:]):
2433         (-[WebView _preferencesChanged:]):
2434         (-[WebView _setUserMediaClient:]): Deleted.
2435         (-[WebView _userMediaClient]): Deleted.
2436         * WebView/WebViewData.h:
2437         * WebView/WebViewPrivate.h:
2438
2439 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
2440
2441         WebAssembly: add support for stream APIs - JavaScript API
2442         https://bugs.webkit.org/show_bug.cgi?id=183442
2443
2444         Reviewed by Yusuke Suzuki and JF Bastien.
2445
2446         Add WEBASSEMBLY_STREAMINNG_API feature flag
2447
2448         * Configurations/FeatureDefines.xcconfig:
2449
2450 2018-04-30  JF Bastien  <jfbastien@apple.com>
2451
2452         Use some C++17 features
2453         https://bugs.webkit.org/show_bug.cgi?id=185135
2454
2455         Reviewed by Alex Christensen.
2456
2457         * Configurations/WebKitLegacy.xcconfig:
2458
2459 2018-04-27  Chris Dumez  <cdumez@apple.com>
2460
2461         Use WindowProxy instead of DOMWindow in our IDL
2462         https://bugs.webkit.org/show_bug.cgi?id=185022
2463
2464         Reviewed by Sam Weinig.
2465
2466         * DOM/DOMAbstractView.mm:
2467         (kit):
2468         (toWindowProxy):
2469         * DOM/DOMAbstractViewInternal.h:
2470         * DOM/DOMDocument.mm:
2471         (-[DOMDocument defaultView]):
2472         (-[DOMDocument getComputedStyle:pseudoElement:]):
2473         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
2474         * DOM/DOMHTMLFrameElement.mm:
2475         (-[DOMHTMLFrameElement contentWindow]):
2476         * DOM/DOMHTMLIFrameElement.mm:
2477         (-[DOMHTMLIFrameElement contentWindow]):
2478         * DOM/DOMKeyboardEvent.mm:
2479         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
2480         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
2481         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
2482         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
2483         * DOM/DOMMouseEvent.mm:
2484         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
2485         * DOM/DOMTextEvent.mm:
2486         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
2487         * DOM/DOMUIEvent.mm:
2488         (-[DOMUIEvent view]):
2489         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
2490         * DOM/DOMWheelEvent.mm:
2491         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
2492
2493 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
2494
2495         Implement rendering support for the color-filter CSS property
2496         https://bugs.webkit.org/show_bug.cgi?id=185047
2497         rdar://problem/39664967
2498
2499         Reviewed by Tim Horton.
2500         
2501         The body background should reflect the filtered color.
2502
2503         * WebView/WebFrame.mm:
2504         (-[WebFrame _bodyBackgroundColor]):
2505         * WebView/WebView.mm:
2506         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
2507
2508 2018-04-26  Jer Noble  <jer.noble@apple.com>
2509
2510         WK_COCOA_TOUCH all the things.
2511         https://bugs.webkit.org/show_bug.cgi?id=185006
2512
2513         Reviewed by Tim Horton.
2514
2515         * Configurations/WebKitLegacy.xcconfig:
2516
2517 2018-04-26  Daniel Bates  <dabates@apple.com>
2518
2519         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
2520         https://bugs.webkit.org/show_bug.cgi?id=184161
2521         <rdar://problem/39051645>
2522
2523         Reviewed by Dan Bernstein.
2524
2525         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
2526         dropping a PDF embedded using an HTML image element into the same web view.
2527
2528         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
2529         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
2530         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
2531         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
2532         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
2533         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
2534         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
2535         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
2536         image document when navigated to directly. Since we can support dragging PDF document images we need to
2537         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
2538         We need to do both such queries before falling back to using the main resource of the Web Archive as
2539         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
2540         not an image document.
2541
2542         * Misc/WebNSPasteboardExtras.mm:
2543         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2544
2545 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
2546
2547         Disable content filtering in minimal simulator mode
2548         https://bugs.webkit.org/show_bug.cgi?id=185027
2549         <rdar://problem/39736091>
2550
2551         Reviewed by Jer Noble.
2552
2553         * Configurations/FeatureDefines.xcconfig:
2554
2555 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
2556
2557         [INTL] Implement Intl.PluralRules
2558         https://bugs.webkit.org/show_bug.cgi?id=184312
2559
2560         Reviewed by JF Bastien.
2561
2562         Added Intl.PluralRules feature flag.
2563
2564         * Configurations/FeatureDefines.xcconfig:
2565
2566 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
2567
2568         Remove access to keychain from the WebContent process
2569         https://bugs.webkit.org/show_bug.cgi?id=184428
2570         <rdar://problem/13150903>
2571
2572         Reviewed by Brent Fulgham.
2573
2574         This patch does the followings:
2575         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
2576         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
2577         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
2578
2579         * WebCoreSupport/WebChromeClient.h:
2580         * WebCoreSupport/WebChromeClient.mm:
2581         (WebChromeClient::signedPublicKeyAndChallengeString const):
2582         * WebView/WebUIDelegatePrivate.h:
2583
2584 2018-04-24  Jer Noble  <jer.noble@apple.com>
2585
2586         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
2587         https://bugs.webkit.org/show_bug.cgi?id=184786
2588
2589         Reviewed by Tim Horton.
2590
2591         * Configurations/WebKitLegacy.xcconfig:
2592         * MigrateHeaders.make:
2593
2594 2018-04-23  Daniel Bates  <dabates@apple.com>
2595
2596         Implement Same-Site cookies
2597         https://bugs.webkit.org/show_bug.cgi?id=159464
2598         <rdar://problem/27196358>
2599
2600         Reviewed by Brent Fulgham.
2601
2602         Pass the Same-Site info through the strategy.
2603
2604         * WebCoreSupport/WebPlatformStrategies.h:
2605         * WebCoreSupport/WebPlatformStrategies.mm:
2606         (WebPlatformStrategies::cookiesForDOM):
2607         (WebPlatformStrategies::setCookiesFromDOM):
2608         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2609         (WebPlatformStrategies::getRawCookies):
2610
2611 2018-04-23  Zalan Bujtas  <zalan@apple.com>
2612
2613         [LayoutFormattingContext] Initial commit.
2614         https://bugs.webkit.org/show_bug.cgi?id=184896
2615
2616         Reviewed by Antti Koivisto.
2617
2618         * Configurations/FeatureDefines.xcconfig:
2619
2620 2018-04-23  Daniel Bates  <dabates@apple.com>
2621
2622         Implement Same-Site cookies
2623         https://bugs.webkit.org/show_bug.cgi?id=159464
2624         <rdar://problem/27196358>
2625
2626         Reviewed by Brent Fulgham.
2627
2628         Pass the Same-Site info through the strategy.
2629
2630         * WebCoreSupport/WebPlatformStrategies.h:
2631         * WebCoreSupport/WebPlatformStrategies.mm:
2632         (WebPlatformStrategies::cookiesForDOM):
2633         (WebPlatformStrategies::setCookiesFromDOM):
2634         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2635         (WebPlatformStrategies::getRawCookies):
2636
2637 2018-04-20  Timothy Hatcher  <timothy@apple.com>
2638
2639         NULL dereference crash sometimes under [super initWithCoder:] in WebView
2640
2641         https://bugs.webkit.org/show_bug.cgi?id=184851
2642         rdar://problem/39611236
2643
2644         Reviewed by Tim Horton.
2645
2646         * WebView/WebView.mm:
2647         (-[WebView _commonInitializationWithFrameName:groupName:]):
2648         (-[WebView effectiveAppearanceDidChange]):
2649         Added a null check and call the code later in initialization.
2650
2651 2018-04-20  Tim Horton  <timothy_horton@apple.com>
2652
2653         Adjust geolocation feature flag
2654         https://bugs.webkit.org/show_bug.cgi?id=184856
2655
2656         Reviewed by Wenson Hsieh.
2657
2658         * Configurations/FeatureDefines.xcconfig:
2659
2660 2018-04-18  Jer Noble  <jer.noble@apple.com>
2661
2662         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
2663         https://bugs.webkit.org/show_bug.cgi?id=184762
2664
2665         Reviewed by Dan Bernstein.
2666
2667         * Configurations/WebKitLegacy.xcconfig:
2668
2669 2018-04-20  Youenn Fablet  <youenn@apple.com>
2670
2671         Make PluginData cache its web visible plugins
2672         https://bugs.webkit.org/show_bug.cgi?id=184421
2673
2674         Reviewed by Chris Dumez.
2675
2676         * WebCoreSupport/WebPluginInfoProvider.h:
2677         * WebCoreSupport/WebPluginInfoProvider.mm:
2678         (WebPluginInfoProvider::pluginInfo):
2679         (WebPluginInfoProvider::webVisiblePluginInfo):
2680
2681 2018-04-19  Chris Dumez  <cdumez@apple.com>
2682
2683         Rename JSDOMWindowProxy to JSWindowProxy
2684         https://bugs.webkit.org/show_bug.cgi?id=184797
2685
2686         Reviewed by Sam Weinig.
2687
2688         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
2689
2690         * DOM/DOMUtility.mm:
2691         (createDOMWrapper):
2692         * WebView/WebFrame.mm:
2693         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
2694
2695 2018-04-19  David Kilzer  <ddkilzer@apple.com>
2696
2697         Enable Objective-C weak references
2698         <https://webkit.org/b/184789>
2699         <rdar://problem/39571716>
2700
2701         Reviewed by Dan Bernstein.
2702
2703         * Configurations/Base.xcconfig:
2704         (CLANG_ENABLE_OBJC_WEAK): Enable.
2705
2706 2018-04-18  Chris Dumez  <cdumez@apple.com>
2707
2708         Rename WindowProxyController to WindowProxy
2709         https://bugs.webkit.org/show_bug.cgi?id=184756
2710
2711         Reviewed by Sam Weinig.
2712
2713         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
2714         needed use WindowProxyController type, which was a bit confusing.
2715
2716         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2717         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2718         * WebView/WebFrame.mm:
2719         (-[WebFrame _attachScriptDebugger]):
2720
2721 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
2722
2723         Unreviewed rollout of r230632. Regression in memory usage.
2724
2725         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
2726
2727         * WebView/WebPreferences.mm:
2728         (+[WebPreferences initialize]):
2729
2730 2018-04-17  Chris Dumez  <cdumez@apple.com>
2731
2732         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
2733         https://bugs.webkit.org/show_bug.cgi?id=184678
2734         <rdar://problem/39422122>
2735
2736         Reviewed by Alex Christensen.
2737
2738         Add new parameter to dispatchDecidePolicyForNavigationAction.
2739
2740         * WebCoreSupport/WebFrameLoaderClient.h:
2741         * WebCoreSupport/WebFrameLoaderClient.mm:
2742         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2743
2744 2018-04-13  Chris Dumez  <cdumez@apple.com>
2745
2746         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
2747         https://bugs.webkit.org/show_bug.cgi?id=184591
2748
2749         Reviewed by Sam Weinig.
2750
2751         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
2752         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
2753         This is work towards fixing Bug 184515.
2754
2755         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2756         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
2757         * WebView/WebFrame.mm:
2758         (-[WebFrame _attachScriptDebugger]):
2759
2760 2018-04-12  Antoine Quint  <graouts@apple.com>
2761
2762         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
2763         https://bugs.webkit.org/show_bug.cgi?id=184569
2764         <rdar://problem/38671301>
2765
2766         Reviewed by Jon Lee.
2767
2768         * WebView/WebPreferences.mm:
2769
2770 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2771
2772         [WTF] Remove StaticLock
2773         https://bugs.webkit.org/show_bug.cgi?id=184332
2774
2775         Reviewed by Mark Lam.
2776
2777         * DOM/DOMInternal.mm:
2778         (getDOMWrapper):
2779         (addDOMWrapper):
2780         (removeDOMWrapper):
2781
2782 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
2783
2784         Failures from mach port reference handling should be fatal
2785         https://bugs.webkit.org/show_bug.cgi?id=184202
2786         <rdar://problem/37771114>
2787
2788         Reviewed by Anders Carlsson.
2789
2790         * Plugins/Hosted/NetscapePluginHostManager.mm:
2791         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
2792
2793 2018-04-03  Andy Estes  <aestes@apple.com>
2794
2795         [Mac] Prioritize file promises over filenames during drag and drop
2796         https://bugs.webkit.org/show_bug.cgi?id=184237
2797         <rdar://problem/38278076>
2798
2799         Reviewed by Wenson Hsieh.
2800
2801         * WebView/WebView.mm:
2802         (-[WebView performDragOperation:]):
2803
2804 2018-04-03  Chris Dumez  <cdumez@apple.com>
2805
2806         Drop MainFrame class
2807         https://bugs.webkit.org/show_bug.cgi?id=184191
2808
2809         Reviewed by Darin Adler.
2810
2811         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
2812         relationship between the Page and the MainFrame.
2813
2814         This is ground work for introducing LocalFrame / RemoteFrame concepts.
2815
2816         * WebCoreSupport/WebDragClient.mm:
2817         * WebCoreSupport/WebFrameLoaderClient.mm:
2818         * WebCoreSupport/WebInspectorClient.mm:
2819         * WebCoreSupport/WebPlatformStrategies.mm:
2820         * WebCoreSupport/WebPluginInfoProvider.mm:
2821         * WebView/WebFrame.mm:
2822         * WebView/WebFrameView.mm:
2823         * WebView/WebHTMLView.mm:
2824         * WebView/WebView.mm:
2825
2826 2018-04-02  Jer Noble  <jer.noble@apple.com>
2827
2828         Enable Legacy EME for all WebKit & WebKitLegacy clients
2829         https://bugs.webkit.org/show_bug.cgi?id=184018
2830         <rdar://problem/34887387>
2831
2832         Reviewed by Eric Carlson.
2833
2834         * WebView/WebPreferences.mm:
2835         (+[WebPreferences initialize]):
2836
2837 2018-03-29  JF Bastien  <jfbastien@apple.com>
2838
2839         Use Forward.h instead of forward-declaring WTF::String
2840         https://bugs.webkit.org/show_bug.cgi?id=184172
2841         <rdar://problem/39026146>
2842
2843         Reviewed by Yusuke Suzuki.
2844
2845         As part of #184164 I'm changing WTF::String, and the forward
2846         declarations are just wrong because I'm making it templated. We
2847         should use Forward.h anyways, so do that instead.
2848
2849         * WebView/WebScriptDebugger.h:
2850
2851 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
2852
2853         Protect against invalid mach ports returned by mach_port_request_notification
2854         https://bugs.webkit.org/show_bug.cgi?id=184106
2855         <rdar://problem/37865316>
2856
2857         Reviewed by Chris Dumez.
2858
2859         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2860         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
2861         and clean up if it experienced an error.
2862         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
2863
2864 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
2865
2866         Avoid uninitialized mach ports
2867         https://bugs.webkit.org/show_bug.cgi?id=184090
2868         <rdar://problem/37261129>
2869
2870         Reviewed by Chris Dumez.
2871
2872         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
2873         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
2874         there is a potential for us to try to use invalid ports.
2875
2876         We should always check return values, and ensure that the mach port variables we seek to initialize are
2877         kept in a valid state.
2878
2879         Reviewed by Chris Dumez.
2880
2881         * Plugins/Hosted/NetscapePluginHostManager.h:
2882         * Plugins/Hosted/NetscapePluginHostManager.mm:
2883         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
2884         port is passed to an API function.
2885         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
2886         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
2887         * Plugins/Hosted/NetscapePluginHostProxy.h:
2888         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2889         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
2890         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
2891         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
2892         (WKPCStatusText): Ditto.
2893         (WKPCLoadURL): Ditto.
2894         (WKPCCancelLoadURL): Ditto.
2895         (WKPCInvalidateRect): Ditto.
2896         (WKPCGetScriptableNPObjectReply): Ditto.
2897         (WKPCBooleanReply): Ditto.
2898         (WKPCBooleanAndDataReply): Ditto.
2899         (WKPCInstantiatePluginReply): Ditto.
2900         (WKPCGetWindowNPObject): Ditto.
2901         (WKPCGetPluginElementNPObject): Ditto.
2902         (WKPCForgetBrowserObject): Ditto.
2903         (WKPCEvaluate): Ditto.
2904         (WKPCGetStringIdentifier): Ditto.
2905         (WKPCGetIntIdentifier): Ditto.
2906         (WKPCInvoke): Ditto.
2907         (WKPCInvokeDefault): Ditto.
2908         (WKPCConstruct): Ditto.
2909         (WKPCGetProperty): Ditto.
2910         (WKPCSetProperty): Ditto.
2911         (WKPCRemoveProperty): Ditto.
2912         (WKPCHasProperty): Ditto.
2913         (WKPCHasMethod): Ditto.
2914         (WKPCIdentifierInfo): Ditto.
2915         (WKPCEnumerate): Ditto.
2916         (WKPCSetMenuBarVisible): Ditto.
2917         (WKPCSetFullscreenWindowIsShowing): Ditto.
2918         (WKPCSetModal): Ditto.
2919         (WKPCGetCookies): Ditto.
2920         (WKPCGetProxy): Ditto.
2921         (WKPCSetCookies): Ditto.
2922         (WKPCGetAuthenticationInfo): Ditto.
2923         (WKPCConvertPoint): Ditto.
2924         (WKPCLayerHostingModeChanged): Ditto.
2925         (WKPCSetException): Ditto.
2926
2927 2018-03-26  Tim Horton  <timothy_horton@apple.com>
2928
2929         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
2930         https://bugs.webkit.org/show_bug.cgi?id=184030
2931         <rdar://problem/38895281>
2932
2933         Reviewed by Dan Bernstein.
2934
2935         * Configurations/Base.xcconfig:
2936
2937 2018-03-26  Chris Dumez  <cdumez@apple.com>
2938
2939         Use SecurityOriginData more consistently in Service Worker code
2940         https://bugs.webkit.org/show_bug.cgi?id=183969
2941
2942         Reviewed by Darin Adler.
2943
2944         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
2945
2946         * Storage/WebDatabaseManager.mm:
2947         (-[WebDatabaseManager databasesWithOrigin:]):
2948         (-[WebDatabaseManager deleteOrigin:]):
2949         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
2950         * Storage/WebDatabaseQuotaManager.mm:
2951         (-[WebDatabaseQuotaManager usage]):
2952         (-[WebDatabaseQuotaManager quota]):
2953         (-[WebDatabaseQuotaManager setQuota:]):
2954         * Storage/WebStorageManager.mm:
2955         (-[WebStorageManager deleteOrigin:]):
2956         * WebCoreSupport/WebSecurityOrigin.mm:
2957         (-[WebSecurityOrigin databaseIdentifier]):
2958         (-[WebSecurityOrigin usage]):
2959         (-[WebSecurityOrigin quota]):
2960         (-[WebSecurityOrigin setQuota:]):
2961
2962 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
2963
2964         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
2965         https://bugs.webkit.org/show_bug.cgi?id=183911
2966         <rdar://problem/38762306>
2967
2968         Reviewed by Youenn Fablet.
2969
2970         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
2971
2972         * WebView/WebView.mm:
2973         (+[WebView initialize]):
2974
2975 2018-03-26  Alex Christensen  <achristensen@webkit.org>
2976
2977         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
2978         https://bugs.webkit.org/show_bug.cgi?id=183965
2979
2980         Reviewed by Chris Dumez.
2981
2982         * WebCoreSupport/WebFrameLoaderClient.h:
2983         * WebCoreSupport/WebFrameLoaderClient.mm:
2984         (WebFrameLoaderClient::willCacheResponse const):
2985
2986 2018-03-25  Commit Queue  <commit-queue@webkit.org>
2987
2988         Unreviewed, rolling out r229954.
2989         https://bugs.webkit.org/show_bug.cgi?id=184000
2990
2991         Caused many layout tests to crash on Apple High Sierra,
2992         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
2993         by dydz on #webkit).
2994
2995         Reverted changeset:
2996
2997         "Use SecurityOriginData more consistently in Service Worker
2998         code"
2999         https://bugs.webkit.org/show_bug.cgi?id=183969
3000         https://trac.webkit.org/changeset/229954
3001
3002 2018-03-24  Chris Dumez  <cdumez@apple.com>
3003
3004         Use SecurityOriginData more consistently in Service Worker code
3005         https://bugs.webkit.org/show_bug.cgi?id=183969
3006
3007         Reviewed by Darin Adler.
3008
3009         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
3010
3011         * Storage/WebDatabaseManager.mm:
3012         (-[WebDatabaseManager databasesWithOrigin:]):
3013         (-[WebDatabaseManager deleteOrigin:]):
3014         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
3015         * Storage/WebDatabaseQuotaManager.mm:
3016         (-[WebDatabaseQuotaManager usage]):
3017         (-[WebDatabaseQuotaManager quota]):
3018         (-[WebDatabaseQuotaManager setQuota:]):
3019         * Storage/WebStorageManager.mm:
3020         (-[WebStorageManager deleteOrigin:]):
3021         * WebCoreSupport/WebSecurityOrigin.mm:
3022         (-[WebSecurityOrigin databaseIdentifier]):
3023         (-[WebSecurityOrigin usage]):
3024         (-[WebSecurityOrigin quota]):
3025         (-[WebSecurityOrigin setQuota:]):
3026
3027 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
3028
3029         Fix the build
3030
3031         * WebView/WebView.mm:
3032
3033 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3034
3035         Fix the build with no pasteboard
3036         https://bugs.webkit.org/show_bug.cgi?id=183973
3037
3038         Reviewed by Dan Bernstein.
3039
3040         * Configurations/FeatureDefines.xcconfig:
3041         * WebView/WebView.mm:
3042         (-[WebView _requestStartDataInteraction:globalPosition:]):
3043         (-[WebView _getDataInteractionData]):
3044         (-[WebView _dataOperationTextIndicator]):
3045         (-[WebView _dragSourceAction]):
3046         (-[WebView _draggedLinkTitle]):
3047         (-[WebView _draggedLinkURL]):
3048         (-[WebView _draggedElementBounds]):
3049         (-[WebView _enteredDataInteraction:client:global:operation:]):
3050         (-[WebView _updatedDataInteraction:client:global:operation:]):
3051         (-[WebView _exitedDataInteraction:client:global:operation:]):
3052         (-[WebView _performDataInteraction:client:global:operation:]):
3053         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3054         (-[WebView _endedDataInteraction:global:]):
3055         (-[WebView _dataInteractionCaretRect]):
3056         * WebView/WebViewPrivate.h:
3057
3058 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3059
3060         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
3061         https://bugs.webkit.org/show_bug.cgi?id=183960
3062         <rdar://problem/38812356>
3063
3064         Reviewed by Dan Bernstein.
3065
3066         * Configurations/WebKitLegacy.xcconfig:
3067
3068 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3069
3070         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
3071         https://bugs.webkit.org/show_bug.cgi?id=183954
3072         <rdar://problem/38808858>
3073
3074         Reviewed by Dan Bernstein.
3075
3076         * WebView/WebPreferences.mm:
3077         (-[WebPreferences setAudioSessionCategoryOverride:]):
3078
3079 2018-03-23  Tim Horton  <timothy_horton@apple.com>
3080
3081         Adopt WK_PLATFORM_NAME in WebKitLegacy
3082         https://bugs.webkit.org/show_bug.cgi?id=183948
3083         <rdar://problem/38803908>
3084
3085         Reviewed by Dan Bernstein.
3086
3087         * Configurations/WebKitLegacy.xcconfig:
3088         * MigrateHeaders.make:
3089         * postprocess-headers.sh:
3090
3091 2018-03-23  Brady Eidson  <beidson@apple.com>
3092
3093         Go to back/forward list items after a process-swapped navigation.
3094         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
3095
3096         Reviewed by Andy Estes.
3097
3098         * WebView/WebView.mm:
3099         (-[WebView _loadBackForwardListFromOtherView:]):
3100         (-[WebView goToBackForwardItem:]):
3101
3102 2018-03-22  Tim Horton  <timothy_horton@apple.com>
3103
3104         Improve readability of WebCore's OTHER_LDFLAGS
3105         https://bugs.webkit.org/show_bug.cgi?id=183909
3106         <rdar://problem/38760992>
3107
3108         Reviewed by Dan Bernstein.
3109
3110         * Configurations/Base.xcconfig:
3111         * Configurations/FeatureDefines.xcconfig:
3112
3113 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3114
3115         Enable the minimal simulator feature flag when appropriate
3116         https://bugs.webkit.org/show_bug.cgi?id=183807
3117
3118         Reviewed by Dan Bernstein.
3119
3120         * Configurations/FeatureDefines.xcconfig:
3121
3122 2018-03-20  Tim Horton  <timothy_horton@apple.com>
3123
3124         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
3125         https://bugs.webkit.org/show_bug.cgi?id=183758
3126         <rdar://problem/38017644>
3127
3128         Reviewed by Dan Bernstein.
3129
3130         * Configurations/FeatureDefines.xcconfig:
3131
3132 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
3133
3134         Clear style colors when setting default appearance
3135         https://bugs.webkit.org/show_bug.cgi?id=183759
3136
3137         Reviewed by Tim Horton.
3138
3139         Colors are cached and need to be cleared and recalculated.
3140         Refactor to do all style recalcs together.
3141
3142         * WebView/WebView.mm:
3143         (-[WebView _setDefaultAppearanceAndClearStyle]):
3144         (-[WebView _setUseSystemAppearance:]):
3145         (-[WebView effectiveAppearanceDidChange]):
3146
3147 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
3148
3149         Unreviewed, another quick fix for r229699
3150
3151         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
3152
3153         * Configurations/FeatureDefines.xcconfig:
3154
3155 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
3156
3157         Ensure that style is updated when the effective appearance changes
3158         https://bugs.webkit.org/show_bug.cgi?id=183690
3159         <rdar://problem/38385900>
3160
3161         Reviewed by Tim Horton and Wenson Hsieh.
3162
3163         Respond to and respect the effective appearance changing.
3164
3165         * WebView/WebView.mm:
3166         (-[WebView _setUseSystemAppearance:]):
3167         (-[WebView effectiveAppearanceDidChange]):
3168
3169 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
3170
3171         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
3172         https://bugs.webkit.org/show_bug.cgi?id=183677
3173
3174         Reviewed by Tim Horton.
3175
3176         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
3177
3178         * DOM/DOM.mm:
3179         (-[DOMHTMLLinkElement _mediaQueryMatches]):
3180
3181 2018-03-14  Tim Horton  <timothy_horton@apple.com>
3182
3183         Fix the build after r229567
3184
3185         * Configurations/FeatureDefines.xcconfig:
3186
3187 2018-03-12  Tim Horton  <timothy_horton@apple.com>
3188
3189         Stop using SDK conditionals to control feature definitions
3190         https://bugs.webkit.org/show_bug.cgi?id=183430
3191         <rdar://problem/38251619>
3192
3193         Reviewed by Dan Bernstein.
3194
3195         * Configurations/FeatureDefines.xcconfig:
3196         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
3197
3198 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
3199
3200         Runtime flag for link prefetch and remove link subresource.
3201         https://bugs.webkit.org/show_bug.cgi?id=183540
3202
3203         Reviewed by Chris Dumez.
3204
3205         Remove the LINK_PREFETCH build time flag.
3206
3207         * Configurations/FeatureDefines.xcconfig:
3208
3209 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
3210
3211         Remove GridLayout runtime flag
3212         https://bugs.webkit.org/show_bug.cgi?id=183484
3213
3214         Reviewed by Myles C. Maxfield.
3215
3216         The Grid Layout feature has been enabled by default for almost a
3217         year, so I think it's time to remove the runtime flag and the
3218
3219         * WebView/WebPreferenceKeysPrivate.h:
3220         * WebView/WebPreferences.mm:
3221         (+[WebPreferences initialize]):
3222         * WebView/WebPreferencesPrivate.h:
3223         * WebView/WebView.mm:
3224         (-[WebView _preferencesChanged:]):
3225
3226 2018-03-12  Antoine Quint  <graouts@apple.com>
3227
3228         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
3229         https://bugs.webkit.org/show_bug.cgi?id=183504
3230         <rdar://problem/38372965>
3231
3232         Reviewed by Dean Jackson and Jon Lee.
3233
3234         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
3235         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
3236
3237         * WebView/WebPreferenceKeysPrivate.h:
3238         * WebView/WebPreferences.mm:
3239         (+[WebPreferences initialize]):
3240         (-[WebPreferences setModernMediaControlsEnabled:]):
3241         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
3242         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
3243         * WebView/WebPreferencesPrivate.h:
3244         * WebView/WebView.mm:
3245         (-[WebView _preferencesChanged:]):
3246
3247 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
3248
3249         Media query for default appearance
3250         https://bugs.webkit.org/show_bug.cgi?id=183539
3251         <rdar://problem/38326388>
3252
3253         Reviewed by Tim Horton.
3254
3255         Write a media query to evaluate appearance.
3256
3257         * WebView/WebView.mm:
3258         (-[WebView _commonInitializationWithFrameName:groupName:]):
3259         (-[WebView _setUseSystemAppearance:]):
3260
3261 2018-03-09  Andy Estes  <aestes@apple.com>
3262
3263         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
3264         https://bugs.webkit.org/show_bug.cgi?id=183489
3265         <rdar://problem/38267517>
3266
3267         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
3268         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
3269         to issue a sandbox extension for this directory, but for security reasons App Sandbox
3270         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
3271         block with a nil error and a valid file URL, but no file will actually exist at that URL.
3272
3273         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
3274         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
3275         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
3276         drop destination.
3277
3278         Reviewed by Wenson Hsieh.
3279
3280         * WebView/WebView.mm:
3281         (-[WebView performDragOperation:]):
3282
3283 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
3284
3285         Allow WebViews to disable system appearance
3286         https://bugs.webkit.org/show_bug.cgi?id=183418
3287         <rdar://problem/36975642>
3288
3289         Reviewed by Tim Horton.
3290
3291         Allow webviews to choose whether or not to follow the default system appearance.
3292
3293         * WebView/WebView.mm:
3294         (-[WebView _setUseSystemAppearance:]):
3295         (-[WebView _useSystemAppearance]):
3296         * WebView/WebViewPrivate.h:
3297
3298 2018-03-08  Youenn Fablet  <youenn@apple.com>
3299
3300         libwebrtc update broke internal builds
3301         https://bugs.webkit.org/show_bug.cgi?id=183454
3302
3303         Reviewed by Eric Carlson.
3304
3305         * Configurations/WebKitLegacy.xcconfig:
3306
3307 2018-03-08  Chris Dumez  <cdumez@apple.com>
3308
3309         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
3310         https://bugs.webkit.org/show_bug.cgi?id=183455
3311         <rdar://problem/38191749>
3312
3313         Reviewed by Youenn Fablet.
3314
3315         Add a null check for the page as we have evidence from crashes that it can be null.
3316         Other functions in WebFrameNetworkingContext already null check the page as well,
3317         not just the frame so this is consistent.
3318
3319         * WebCoreSupport/WebFrameNetworkingContext.mm:
3320         (WebFrameNetworkingContext::storageSession const):
3321
3322 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3323
3324         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
3325         https://bugs.webkit.org/show_bug.cgi?id=183429
3326
3327         Reviewed by Mark Lam.
3328
3329         * DOM/DOM.mm:
3330         (+[DOMNode _nodeFromJSWrapper:]):
3331         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3332         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
3333         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
3334         * Plugins/Hosted/ProxyInstance.mm:
3335         (WebKit::ProxyInstance::invokeMethod):
3336         * WebView/WebView.mm:
3337         (aeDescFromJSValue):
3338
3339 2018-03-08  Tim Horton  <timothy_horton@apple.com>
3340
3341         Stop linking ApplicationServices directly
3342         https://bugs.webkit.org/show_bug.cgi?id=182867
3343         <rdar://problem/38252142>
3344
3345         Reviewed by Alex Christensen.
3346
3347         The frameworks that we use that live inside ApplicationServices
3348         have mostly moved out, so import them directly.
3349
3350         * Carbon/CarbonUtils.h:
3351         * WebKitPrefix.h:
3352         * WebView/WebHTMLView.mm:
3353         * WebView/WebPDFView.mm:
3354
3355 2018-03-07  Tim Horton  <timothy_horton@apple.com>
3356
3357         Sort and separate FeatureDefines.xcconfig
3358         https://bugs.webkit.org/show_bug.cgi?id=183427
3359
3360         Reviewed by Dan Bernstein.
3361
3362         * Configurations/FeatureDefines.xcconfig:
3363         Sort and split FeatureDefines into paragraphs
3364         (to make it easier to sort later).
3365
3366 2018-03-07  Youenn Fablet  <youenn@apple.com>
3367
3368         Match unsupported plugins based on domains and not origin
3369         https://bugs.webkit.org/show_bug.cgi?id=183384
3370
3371         Reviewed by Chris Dumez.
3372
3373         * WebCoreSupport/WebPluginInfoProvider.h:
3374         * WebCoreSupport/WebPluginInfoProvider.mm:
3375         (WebPluginInfoProvider::getPluginInfo):
3376         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3377
3378 2018-03-05  Andy Estes  <aestes@apple.com>
3379
3380         [Mac] Teach WebCore::Pasteboard about file promise drags
3381         https://bugs.webkit.org/show_bug.cgi?id=183314
3382         <rdar://problem/38105493>
3383
3384         Reviewed by Darin Adler.
3385
3386         Added a FIXME comment.
3387
3388         * WebView/WebView.mm:
3389         (-[WebView performDragOperation:]):
3390
3391 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
3392
3393         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
3394         https://bugs.webkit.org/show_bug.cgi?id=183312
3395
3396         Reviewed by Mark Lam.
3397
3398         Remove wtf/CurrentTime.h include pragma.
3399
3400         * WebView/WebFrame.mm:
3401         * WebView/WebPDFView.mm:
3402
3403 2018-03-04  Tim Horton  <timothy_horton@apple.com>
3404
3405         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
3406         https://bugs.webkit.org/show_bug.cgi?id=183283
3407         <rdar://problem/38062148>
3408
3409         Reviewed by Sam Weinig.
3410
3411         * Configurations/FeatureDefines.xcconfig:
3412
3413 2018-02-28  Alex Christensen  <achristensen@webkit.org>
3414
3415         Reduce use of NetworkingContext in WebKit
3416         https://bugs.webkit.org/show_bug.cgi?id=183213
3417
3418         Reviewed by Brady Eidson.
3419
3420         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3421         (WebKit::NetscapePluginInstanceProxy::getProxy):
3422         * Plugins/WebNetscapePluginView.mm:
3423         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
3424
3425 2018-02-17  Darin Adler  <darin@apple.com>
3426
3427         Prepare for ExtendedColor changes (first step)
3428         https://bugs.webkit.org/show_bug.cgi?id=182904
3429
3430         Reviewed by Sam Weinig.
3431
3432         * Misc/WebKitNSStringExtras.mm:
3433         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
3434
3435 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
3436
3437         Remove currentTime() / currentTimeMS()
3438         https://bugs.webkit.org/show_bug.cgi?id=183052
3439
3440         Reviewed by Mark Lam.
3441
3442         * WebCoreSupport/WebFrameLoaderClient.h:
3443         * WebCoreSupport/WebFrameLoaderClient.mm:
3444         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
3445
3446 2018-02-16  Youenn Fablet  <youenn@apple.com>
3447
3448         Allow specifying which plug-ins are supported
3449         https://bugs.webkit.org/show_bug.cgi?id=182748
3450
3451         Reviewed by Chris Dumez.
3452
3453         * WebCoreSupport/WebPluginInfoProvider.h:
3454         * WebCoreSupport/WebPluginInfoProvider.mm:
3455         (WebPluginInfoProvider::getPluginInfo):
3456         (WebPluginInfoProvider::getWebVisiblePluginInfo):
3457
3458 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
3459
3460         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
3461         https://bugs.webkit.org/show_bug.cgi?id=182882
3462         <rdar://problem/35672661>
3463
3464         Reviewed by Dan Bernstein.
3465
3466         Make sure the smart pointer hold the collection of subviews lives at least as
3467         long as the loop using it.
3468
3469         * WebView/WebHTMLView.mm:
3470         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
3471
3472 2018-02-14  Daniel Bates  <dabates@apple.com>
3473
3474         Disallow cross-origin subresources from asking for credentials
3475         https://bugs.webkit.org/show_bug.cgi?id=182579
3476         <rdar://problem/36162271>
3477
3478         Reviewed by Andy Estes.
3479
3480         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
3481         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
3482
3483         * WebView/WebPreferenceKeysPrivate.h:
3484         * WebView/WebPreferences.mm:
3485         (+[WebPreferences initialize]):
3486         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
3487         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
3488         * WebView/WebPreferencesPrivate.h:
3489         * WebView/WebView.mm:
3490         (-[WebView _preferencesChanged:]):
3491
3492 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
3493
3494         Remove ForwardingHeaders directory from WebKitLegacy/mac.
3495         https://bugs.webkit.org/show_bug.cgi?id=182738
3496
3497         Reviewed by Darin Adler.
3498
3499         * ForwardingHeaders/collector/handles/Global.h: Removed.
3500         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
3501         * ForwardingHeaders/runtime/Completion.h: Removed.
3502         * ForwardingHeaders/runtime/Error.h: Removed.
3503         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
3504         * ForwardingHeaders/runtime/JSFunction.h: Removed.
3505         * ForwardingHeaders/runtime/JSLock.h: Removed.
3506         * ForwardingHeaders/runtime/JSObject.h: Removed.
3507         * ForwardingHeaders/runtime/JSString.h: Removed.
3508         * ForwardingHeaders/runtime/Protect.h: Removed.
3509         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
3510
3511 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
3512
3513         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
3514         https://bugs.webkit.org/show_bug.cgi?id=182641
3515
3516         Reviewed by Dan Bernstein.
3517
3518         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
3519         https://trac.webkit.org/changeset/228308.
3520
3521         * WebView/WebVideoFullscreenController.h:
3522         * WebView/WebVideoFullscreenHUDWindowController.mm:
3523         * WebView/WebWindowAnimation.h:
3524         * WebView/WebWindowAnimation.mm:
3525         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
3526         (WebCore::scaledRect): Deleted.
3527         (WebCore::squaredDistance): Deleted.
3528
3529 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
3530
3531         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
3532
3533         * WebView/WebWindowAnimation.mm:
3534         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
3535
3536 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
3537
3538         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
3539         https://bugs.webkit.org/show_bug.cgi?id=182615
3540
3541         Reviewed by Eric Carlson.
3542
3543         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
3544         Ideally, we should not reference NSApp in WebCore.
3545
3546         * WebView/WebFullScreenController.mm:
3547         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
3548         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
3549         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
3550         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
3551         * WebView/WebView.mm:
3552         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
3553         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
3554
3555 2018-01-13  Darin Adler  <darin@apple.com>
3556
3557         Event improvements
3558         https://bugs.webkit.org/show_bug.cgi?id=179591
3559
3560         Reviewed by Chris Dumez.
3561
3562         * DOM/DOMWheelEvent.mm:
3563         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
3564         Call initWebKitWheelEvent.
3565
3566         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
3567         * WebCoreSupport/WebInspectorClient.mm: Ditto.
3568         * WebView/WebFrame.mm: Ditto.
3569
3570         * WebView/WebHTMLView.mm:
3571         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
3572         underlyingPlatformEvent.
3573         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
3574
3575         * WebView/WebScriptWorld.mm:
3576         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
3577
3578         * WebView/WebView.mm: Removed include of ScriptValue.h.
3579
3580 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
3581
3582         Remove WebCore/ForwardingHeaders directory
3583         https://bugs.webkit.org/show_bug.cgi?id=182347
3584
3585         Reviewed by Keith Miller.
3586
3587         * Carbon/CarbonWindowAdapter.mm:
3588         * DOM/WebDOMOperations.mm:
3589         * History/WebBackForwardList.mm:
3590         * History/WebHistoryItem.mm:
3591         * Misc/WebCache.mm:
3592         * Misc/WebElementDictionary.mm:
3593         * Misc/WebIconDatabase.mm:
3594         * Misc/WebStringTruncator.mm:
3595         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3596         * Plugins/Hosted/ProxyInstance.mm:
3597         * Plugins/Hosted/ProxyRuntimeObject.mm:
3598         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3599         * Plugins/WebBaseNetscapePluginView.mm:
3600         * Plugins/WebBasePluginPackage.mm:
3601         * Plugins/WebNetscapePluginStream.mm:
3602         * Plugins/WebNetscapePluginView.mm:
3603         * Plugins/WebPluginController.mm:
3604         * WebCoreSupport/WebEditorClient.mm:
3605         * WebCoreSupport/WebFrameLoaderClient.mm:
3606         * WebCoreSupport/WebInspectorClient.h:
3607         * WebCoreSupport/WebInspectorClient.mm:
3608         * WebView/WebDataSource.mm:
3609         * WebView/WebFrame.mm:
3610         * WebView/WebHTMLRepresentation.mm:
3611         * WebView/WebHTMLView.mm:
3612         * WebView/WebPreferences.mm:
3613         * WebView/WebScriptDebugDelegate.mm:
3614         * WebView/WebScriptDebugger.h:
3615         * WebView/WebTextIterator.mm:
3616         * WebView/WebView.mm:
3617         * WebView/WebViewData.mm:
3618
3619 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
3620
3621         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
3622         https://bugs.webkit.org/show_bug.cgi?id=182312
3623
3624         Reviewed by Michael Catanzaro.
3625
3626         * WebKitPrefix.h:
3627
3628 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
3629
3630         [WebAuthN] Add a compile-time feature flag
3631         https://bugs.webkit.org/show_bug.cgi?id=182211
3632         <rdar://problem/36936365>
3633
3634         Reviewed by Brent Fulgham.
3635
3636         * Configurations/FeatureDefines.xcconfig:
3637
3638 2018-01-27  Dan Bernstein  <mitz@apple.com>
3639
3640         HaveInternalSDK includes should be "#include?"
3641         https://bugs.webkit.org/show_bug.cgi?id=179670
3642
3643         * Configurations/Base.xcconfig:
3644
3645 2018-01-24  Alex Christensen  <achristensen@webkit.org>
3646
3647         Remove unused QTKit preference
3648         https://bugs.webkit.org/show_bug.cgi?id=181968
3649
3650         Reviewed by Alexey Proskuryakov.
3651
3652         * WebView/WebPreferenceKeysPrivate.h:
3653         * WebView/WebPreferences.mm:
3654         (+[WebPreferences initialize]):
3655         (-[WebPreferences setQTKitEnabled:]): Deleted.
3656         (-[WebPreferences isQTKitEnabled]): Deleted.
3657         * WebView/WebPreferencesPrivate.h:
3658         * WebView/WebView.mm:
3659         (-[WebView _preferencesChanged:]):
3660
3661 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3662
3663         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
3664         https://bugs.webkit.org/show_bug.cgi?id=182037
3665         <rdar://problem/36747812>
3666
3667         Reviewed by Ryosuke Niwa.
3668
3669         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
3670         for more details.
3671
3672         * WebView/WebHTMLRepresentation.mm:
3673         (-[WebHTMLRepresentation elementWithName:inForm:]):
3674         (-[WebHTMLRepresentation controlsInForm:]):
3675
3676 2018-01-23  Alex Christensen  <achristensen@webkit.org>
3677
3678         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
3679         https://bugs.webkit.org/show_bug.cgi?id=181961
3680
3681         Reviewed by Michael Catanzaro.
3682
3683         * WebView/WebPreferences.mm:
3684
3685 2018-01-23  Commit Queue  <commit-queue@webkit.org>
3686
3687         Unreviewed, rolling out r227437.
3688         https://bugs.webkit.org/show_bug.cgi?id=182011
3689
3690         broke build (Requested by alexchristensen on #webkit).
3691
3692         Reverted changeset:
3693
3694         "Remove unused QTKit preference"
3695         https://bugs.webkit.org/show_bug.cgi?id=181968
3696         https://trac.webkit.org/changeset/227437
3697
3698 2018-01-23  Alex Christensen  <achristensen@webkit.org>
3699
3700         Remove unused QTKit preference
3701         https://bugs.webkit.org/show_bug.cgi?id=181968
3702
3703         Reviewed by Alexey Proskuryakov.
3704
3705         * WebView/WebPreferenceKeysPrivate.h:
3706         * WebView/WebPreferences.mm:
3707         (+[WebPreferences initialize]):
3708         (-[WebPreferences setQTKitEnabled:]): Deleted.
3709         (-[WebPreferences isQTKitEnabled]): Deleted.
3710         * WebView/WebPreferencesPrivate.h:
3711         * WebView/WebView.mm:
3712         (-[WebView _preferencesChanged:]):
3713
3714 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3715
3716         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
3717         https://bugs.webkit.org/show_bug.cgi?id=181960
3718         <rdar://problem/36431678>
3719
3720         Reviewed by Tim Horton.
3721
3722         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
3723         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
3724         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
3725
3726         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
3727         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
3728         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
3729
3730         * WebView/WebView.mm:
3731         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3732
3733 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
3734
3735         Turning off custom pasteboard data doesn't actually turn it off in WK2
3736         https://bugs.webkit.org/show_bug.cgi?id=181920
3737         <rdar://problem/36686429>
3738
3739         Reviewed by Wenson Hsieh.
3740
3741         Always disable custom pasteboard data in WebKit1. See r226156 for details.
3742
3743         * WebView/WebPreferences.mm:
3744         (+[WebPreferences initialize]):
3745         * WebView/WebView.mm:
3746         (-[WebView _preferencesChanged:]):
3747
3748 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3749
3750         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
3751         https://bugs.webkit.org/show_bug.cgi?id=181918
3752
3753         Reviewed by Tim Horton.
3754
3755         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
3756
3757         * Configurations/FeatureDefines.xcconfig:
3758
3759 2018-01-20  Andy Estes  <aestes@apple.com>
3760
3761         [Apple Pay] Stop eagerly loading PassKit.framework
3762         https://bugs.webkit.org/show_bug.cgi?id=181911
3763         <rdar://problem/36555369>
3764
3765         Reviewed by Tim Horton.
3766
3767         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3768         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3769         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
3770
3771         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
3772
3773 2018-01-19  Dean Jackson  <dino@apple.com>
3774
3775         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
3776         https://bugs.webkit.org/show_bug.cgi?id=181817
3777         <rdar://problem/35274055>
3778
3779         Reviewed by Simon Fraser.
3780
3781         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
3782
3783         * Misc/WebKitVersionChecks.h:
3784         * WebView/WebView.mm:
3785         (-[WebView _commonInitializationWithFrameName:groupName:]):
3786
3787 2018-01-19  Alex Christensen  <achristensen@webkit.org>
3788
3789         Remove unused WebViewPrivate _allowCookies
3790         https://bugs.webkit.org/show_bug.cgi?id=181812
3791
3792         Reviewed by Tim Horton.
3793
3794         * WebView/WebView.mm:
3795         (+[WebView _setAllowCookies:]): Deleted.
3796         (+[WebView _allowCookies]): Deleted.
3797         * WebView/WebViewPrivate.h:
3798
3799 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
3800
3801         Build fix, remove a call to -[NSWindow setOneShot:]
3802         https://bugs.webkit.org/show_bug.cgi?id=181809
3803
3804         Reviewed by Tim Horton.
3805
3806         * WebView/WebTextCompletionController.mm:
3807         (-[WebTextCompletionController _buildUI]):
3808
3809 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3810
3811         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
3812
3813         * Carbon/HIWebView.mm:
3814         (overrideCGContext):
3815         (restoreCGContext):
3816
3817 2018-01-18  Dan Bernstein  <mitz@apple.com>
3818
3819         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
3820         https://bugs.webkit.org/show_bug.cgi?id=181803
3821
3822         Reviewed by Tim Horton.
3823
3824         * Configurations/Base.xcconfig: Updated.
3825         * Configurations/DebugRelease.xcconfig: Ditto.
3826         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
3827         * Configurations/Version.xcconfig: Updated.
3828         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
3829           useful for defining settings that depend on the target macOS version.
3830
3831 2018-01-17  Youenn Fablet  <youenn@apple.com>
3832
3833         Put fetch Request.keepalive behind a runtime flag
3834         https://bugs.webkit.org/show_bug.cgi?id=181592
3835
3836         Reviewed by Chris Dumez.
3837
3838         * WebView/WebPreferenceKeysPrivate.h:
3839         * WebView/WebPreferences.mm:
3840         (+[WebPreferences initialize]):
3841         (-[WebPreferences fetchAPIKeepAliveEnabled]):
3842         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
3843         * WebView/WebPreferencesPrivate.h:
3844         * WebView/WebView.mm:
3845         (-[WebView _preferencesChanged:]):
3846
3847 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3848
3849         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
3850         https://bugs.webkit.org/show_bug.cgi?id=181637
3851         <rdar://problem/36508471>
3852
3853         Reviewed by Tim Horton.
3854
3855         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
3856
3857         * WebCoreSupport/WebEditorClient.h:
3858         * WebCoreSupport/WebEditorClient.mm:
3859         (WebEditorClient::replacementURLForResource):
3860
3861 2018-01-11  Keith Miller  <keith_miller@apple.com>
3862
3863         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
3864         https://bugs.webkit.org/show_bug.cgi?id=181573
3865
3866         Reviewed by Simon Fraser.
3867
3868         * Configurations/FeatureDefines.xcconfig:
3869
3870 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3871
3872         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
3873         https://bugs.webkit.org/show_bug.cgi?id=181497
3874
3875         Reviewed by Tim Horton.
3876
3877         See other ChangeLogs for more detail.
3878
3879         * WebCoreSupport/WebDragClient.h:
3880
3881 2018-01-11  Tim Horton  <timothy_horton@apple.com>
3882
3883         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
3884         https://bugs.webkit.org/show_bug.cgi?id=181523
3885         <rdar://problem/28959131>
3886
3887         Reviewed by Alex Christensen.
3888
3889         * WebView/WebImmediateActionController.mm:
3890         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3891         Apply the change made in r216652 to WebKit1's immediate action controller.
3892
3893         Speculative (but successful in WebKit2) fix for non-reproducible crash when
3894         the startContainer of the range is in an anonymous node.
3895
3896 2018-01-11  Youenn Fablet  <youenn@apple.com>
3897
3898         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
3899         https://bugs.webkit.org/show_bug.cgi?id=181480
3900
3901         Reviewed by Eric Carlson.
3902
3903         * WebView/WebPreferences.mm:
3904         (+[WebPreferences initialize]):
3905
3906 2018-01-08  David Kilzer  <ddkilzer@apple.com>
3907
3908         Fix check-webkit-style issues with WebNSDataExtras.mm
3909         <https://webkit.org/b/181369>
3910
3911         Reviewed by Alex Christensen.
3912
3913         * Misc/WebNSDataExtras.mm:
3914         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
3915         (-[NSData _webkit_guessedMIMETypeForXML]):
3916         (-[NSData _webkit_guessedMIMEType]):
3917         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
3918         (_findEOL):
3919         (-[NSData _webkit_parseRFC822HeaderFields]):
3920         (-[NSData _web_locationAfterFirstBlankLine]):
3921         - Fix all the check-webkit-style warnings.
3922
3923 2018-01-08  David Kilzer  <ddkilzer@apple.com>
3924
3925         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
3926         <https://webkit.org/b/181256>
3927         <rdar://problem/36281730>
3928
3929         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3930         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
3931         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
3932           to avoid warnings from casting CFStringRef to NPNSString*.
3933           Note that CFMutableStringRef is the same as CFStringRef
3934           without the const modifier, hence its use in the const_cast<>
3935           above.
3936
3937 2018-01-08  David Kilzer  <ddkilzer@apple.com>
3938
3939         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
3940         <https://webkit.org/b/181256>
3941         <rdar://problem/36281730>
3942
3943         * Carbon/HIWebView.mm:
3944         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
3945         checked_cf_cast<CFRunLoopRef>() to fix warning.
3946
3947 2018-01-07  David Kilzer  <ddkilzer@apple.com>
3948
3949         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
3950         <https://webkit.org/b/181256>
3951         <rdar://problem/36281730>
3952
3953         Reviewed by Darin Adler.
3954
3955         * Carbon/CarbonUtils.m:
3956         (PoolCleaner):
3957         - Use #pragmas to ignore -Wcast-qual warnings when using a
3958           C-style cast from CFTypeRef to CFRunloopRef.
3959         * Carbon/CarbonWindowFrame.m:
3960         (-[CarbonWindowFrame title]):
3961         - Use #pragmas to ignore -Wcast-qual warnings when using a
3962           C-style cast from CFStringRef to NSString *.
3963         * Carbon/HIViewAdapter.m:
3964         (+[HIViewAdapter getHIViewForNSView:]):
3965         - Use #pragmas to ignore -Wcast-qual warnings when using a
3966           C-style cast from CFTypeRef to HIViewRef.
3967         * Configurations/Base.xcconfig:
3968         (WARNING_CFLAGS): Add -Wcast-qual.
3969         * Misc/WebElementDictionary.mm:
3970         (-[WebElementDictionary objectForKey:]):
3971         - Use static_cast<SEL>(const_cast<void*>()) to fix
3972           warning.
3973         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
3974         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
3975         (-[NSData _webkit_guessedMIMETypeForXML]):
3976         (-[NSData _webkit_guessedMIMEType]):
3977         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
3978         (_findEOL):
3979         (-[NSData _webkit_parseRFC822HeaderFields]):
3980         (-[NSData _web_startsWithBlankLine]):
3981         (-[NSData _web_locationAfterFirstBlankLine]):
3982         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
3983           type to Objective-C++.  This fixes the warnings about
3984           discarding the `const` modifier when casing from CFStringRef
3985           to NSString * because in older clang versions, -Wcast-qual was
3986           completely broken when compiling C++ and Objective-C++ source
3987           files.  In newer clang versions, discarding the `const`
3988           modifier for toll-free bridged types is ignored when compiling
3989           Objective-C++ source.
3990         - Update copyright and license header.
3991         - Use reinterpret_cast<> and static_cast<> to fix warnings
3992           unrelated to (NSString *) C-style casts.
3993         - Replace use of MIN() macro with std::min<> template functions.
3994         - Fix location of `*` for local variables modified above.
3995         * Plugins/Hosted/NetscapePluginHostManager.mm:
3996         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3997         (WebKit::NetscapePluginHostManager::initializeVendorPort):
3998         (WebKit::NetscapePluginHostManager::instantiatePlugin):
3999         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
4000           warnings.
4001         * Plugins/Hosted/NetscapePluginHostProxy.mm:
4002         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
4003         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
4004           to fix warning.
4005         * Plugins/Hosted/ProxyInstance.mm:
4006         (WebKit::ProxyInstance::invoke):
4007         - Use static_cast<char*>(const_cast<void*>()) to fix
4008           warning when using -[NSData bytes].
4009         (WebKit::ProxyInstance::fieldValue const):
4010         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
4011           to fix warning when using CFDataGetBytePtr().
4012         * Plugins/Hosted/WebTextInputWindowController.m:
4013         (-[WebTextInputPanel _interpretKeyEvent:string:]):
4014         - Use #pragma to ignore -Wcast-qual warning since there
4015           is not a good way to avoid this warning in Objective-C.
4016         * Plugins/WebNetscapePluginStream.mm:
4017         (WebNetscapePluginStream::deliverData):
4018         - Use const_cast<void*>() to fix warning when using
4019           -[NSData bytes].
4020         * Plugins/WebNetscapePluginView.mm:
4021         (-[WebNetscapePluginView _createPlugin]):
4022         - Change C-style cast to const_cast<char*>() to fix
4023           warning.
4024         * WebCoreSupport/WebChromeClient.mm:
4025         (WebChromeClient::wrapCryptoKey const):
4026         (WebChromeClient::unwrapCryptoKey const):
4027         - Change C-style cast to
4028           static_cast<uint8_t*>(const_cast<void*>() to fix
4029           warning.
4030         * WebView/WebPDFView.mm:
4031         (_applicationInfoForMIMEType):
4032         - Change local variable type from 'NSURL *' to
4033           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
4034           when calling -[NSURL path].
4035
4036 2018-01-05  Dan Bernstein  <mitz@apple.com>
4037
4038         Fixed the build following AppKit API deprecations in a recent SDKs
4039
4040         * WebView/WebFullScreenController.mm:
4041         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
4042         (-[WebFullScreenController exitFullScreen]): Ditto.
4043         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
4044         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
4045         * WebView/WebHTMLView.mm:
4046         (-[WebHTMLView drawRect:]): Ditto.
4047         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
4048         (-[WebHTMLView knowsPageRange:]): Ditto.
4049         * WebView/WebView.mm:
4050         (LayerFlushController::flushLayers): Ditto.
4051
4052 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
4053
4054         [Attachment Support] Creat