Allow pages to trigger programmatic paste from script on iOS
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Allow pages to trigger programmatic paste from script on iOS
4         https://bugs.webkit.org/show_bug.cgi?id=194271
5         <rdar://problem/47808810>
6
7         Reviewed by Ryosuke Niwa.
8
9         See WebCore and WebKit ChangeLogs for more details.
10
11         * WebCoreSupport/WebEditorClient.h:
12
13 2019-02-12  Andy Estes  <aestes@apple.com>
14
15         [iOSMac] Enable Parental Controls Content Filtering
16         https://bugs.webkit.org/show_bug.cgi?id=194521
17         <rdar://39732376>
18
19         Reviewed by Tim Horton.
20
21         * Configurations/FeatureDefines.xcconfig:
22
23 2019-02-06  Andy Estes  <aestes@apple.com>
24
25         [Payment Request] It should be possible to require a phonetic name for shipping contacts
26         https://bugs.webkit.org/show_bug.cgi?id=194311
27         <rdar://46733045>
28
29         Reviewed by Alex Christensen.
30
31         * WebCoreSupport/WebPaymentCoordinatorClient.h:
32         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
33         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
34
35 2019-02-04  Said Abou-Hallawa  <said@apple.com>
36
37         [CG] Enable setAdditionalSupportedImageTypes for WK1
38         https://bugs.webkit.org/show_bug.cgi?id=194190
39
40         Reviewed by Tim Horton.
41
42         1. Define the preferences key AdditionalSupportedImageTypes.
43         2. Add additionalSupportedImageTypes as a private preference property.
44         3. Define the setter and the getter of the property.
45         4. Add function to convert from an id to an array of strings.
46         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
47
48         * WebView/WebPreferenceKeysPrivate.h:
49         * WebView/WebPreferences.mm:
50         (-[WebPreferences _stringArrayValueForKey:]):
51         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
52         (-[WebPreferences setAdditionalSupportedImageTypes:]):
53         (-[WebPreferences additionalSupportedImageTypes]):
54         * WebView/WebPreferencesPrivate.h:
55         * WebView/WebView.mm:
56         (-[WebView _preferencesChanged:]):
57
58 2019-02-04  Timothy Hatcher  <timothy@apple.com>
59
60         Add WebView SPI to temporarily force light or dark appearance on a page.
61         https://bugs.webkit.org/show_bug.cgi?id=194230
62
63         Reviewed by Tim Horton.
64
65         * WebView/WebView.mm:
66         (-[WebView _useDarkAppearance:]): Added.
67         (-[WebView _setUseDarkAppearance:]): Added.
68         * WebView/WebViewPrivate.h:
69
70 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
71
72         PageOverlayController's layers should be created lazily
73         https://bugs.webkit.org/show_bug.cgi?id=194199
74         rdar://problem/46571593
75
76         Reviewed by Tim Horton.
77
78         * WebCoreSupport/WebChromeClient.h:
79         * WebCoreSupport/WebChromeClient.mm:
80         (WebChromeClient::attachViewOverlayGraphicsLayer):
81
82 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
83
84         Make setNeedsLayout on the root more explicitly about triggering its side-effects
85         https://bugs.webkit.org/show_bug.cgi?id=194198
86
87         Reviewed by Antti Koivisto.
88
89         Call the newly named functions.
90
91         * WebView/WebFrame.mm:
92         (-[WebFrame setNeedsLayout]):
93         * WebView/WebHTMLView.mm:
94         (-[WebHTMLView setNeedsLayout:]):
95
96 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
97
98         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
99         https://bugs.webkit.org/show_bug.cgi?id=194189
100
101         Reviewed by Geoffrey Garen.
102
103         Pass the policy check identifier around functions and store it in WebFramePolicyListener
104         so that we can send it back to WebCore with the navigation policy decision.
105
106         * WebCoreSupport/WebFrameLoaderClient.h:
107         * WebCoreSupport/WebFrameLoaderClient.mm:
108         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
109         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
110         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
111         (WebFrameLoaderClient::dispatchWillSubmitForm):
112         (WebFrameLoaderClient::setUpPolicyListener):
113         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
114         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
115         (-[WebFramePolicyListener invalidate]):
116         (-[WebFramePolicyListener dealloc]):
117         (-[WebFramePolicyListener receivedPolicyDecision:]):
118         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
119         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
120
121 2019-01-31  Alex Christensen  <achristensen@webkit.org>
122
123         Revert r238819 which is unneeded and caused a performance regression.
124         https://bugs.webkit.org/show_bug.cgi?id=192272
125         <rdar://problem/46664625>
126
127         * WebCoreSupport/WebFrameLoaderClient.h:
128         * WebCoreSupport/WebFrameLoaderClient.mm:
129         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
130
131 2019-01-28  Devin Rousso  <drousso@apple.com>
132
133         Web Inspector: provide a way to edit page WebRTC settings on a remote target
134         https://bugs.webkit.org/show_bug.cgi?id=193863
135         <rdar://problem/47572764>
136
137         Reviewed by Joseph Pecoraro.
138
139         * WebView/WebView.mm:
140         (-[WebView _preferencesChanged:]):
141         Add page-level settings for WebRTC preferences.
142
143 2019-01-28  Andy Estes  <aestes@apple.com>
144
145         [watchOS] Enable Parental Controls content filtering
146         https://bugs.webkit.org/show_bug.cgi?id=193939
147         <rdar://problem/46641912>
148
149         Reviewed by Ryosuke Niwa.
150
151         * Configurations/FeatureDefines.xcconfig:
152
153 2019-01-28  Timothy Hatcher  <timothy@apple.com>
154
155         Make it easier for non-Apple ports to enable dark mode CSS support.
156         https://bugs.webkit.org/show_bug.cgi?id=193882
157
158         Reviewed by Megan Gardner.
159
160         * WebView/WebView.mm:
161         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
162         (-[WebView _effectiveAppearanceIsDark]): Ditto.
163
164 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
165
166         AX: Introduce a static accessibility tree
167         https://bugs.webkit.org/show_bug.cgi?id=193348
168         <rdar://problem/47203295>
169
170         Reviewed by Ryosuke Niwa.
171
172         * Configurations/FeatureDefines.xcconfig:
173
174 2019-01-25  Keith Rollin  <krollin@apple.com>
175
176         Update WebKitAdditions.xcconfig with correct order of variable definitions
177         https://bugs.webkit.org/show_bug.cgi?id=193793
178         <rdar://problem/47532439>
179
180         Reviewed by Alex Christensen.
181
182         XCBuild changes the way xcconfig variables are evaluated. In short,
183         all config file assignments are now considered in part of the
184         evaluation. When using the new build system and an .xcconfig file
185         contains multiple assignments of the same build setting:
186
187         - Later assignments using $(inherited) will inherit from earlier
188           assignments in the xcconfig file.
189         - Later assignments not using $(inherited) will take precedence over
190           earlier assignments. An assignment to a more general setting will
191           mask an earlier assignment to a less general setting. For example,
192           an assignment without a condition ('FOO = bar') will completely mask
193           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
194
195         This affects some of our .xcconfig files, in that sometimes platform-
196         or sdk-specific definitions appear before the general definitions.
197         Under the new evaluations rules, the general definitions alway take
198         effect because they always overwrite the more-specific definitions. The
199         solution is to swap the order, so that the general definitions are
200         established first, and then conditionally overwritten by the
201         more-specific definitions.
202
203         * Configurations/Version.xcconfig:
204         * Configurations/WebKitLegacy.xcconfig:
205
206 2019-01-25  David Kilzer  <ddkilzer@apple.com>
207
208         Move soft-linking of Lookup.framework out of LookupSPI.h
209         <https://webkit.org/b/193815>
210
211         Reviewed by Tim Horton.
212
213         * WebView/WebImmediateActionController.mm:
214         (-[WebImmediateActionController _animationControllerForText]):
215         * WebView/WebView.mm:
216         (-[WebView _prepareForDictionaryLookup]):
217         - Move soft-linking to LookupSoftLink.{h,mm}.
218
219 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
220
221         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
222         https://bugs.webkit.org/show_bug.cgi?id=193829
223
224         Reviewed by Tim Horton.
225
226         * WebCoreSupport/WebDragClient.mm:
227         (WebDragClient::didConcludeEditDrag):
228         * WebView/WebView.mm:
229         (-[WebView _requestStartDataInteraction:globalPosition:]):
230         (-[WebView _didConcludeEditDrag]):
231         (-[WebView _didConcludeEditDataInteraction]): Deleted.
232         * WebView/WebViewInternal.h:
233
234 2019-01-24  John Wilander  <wilander@apple.com>
235
236         Add Ad Click Attribution as an internal/experimental feature
237         https://bugs.webkit.org/show_bug.cgi?id=193685
238         <rdar://problem/47450399>
239
240         Reviewed by Brent Fulgham.
241
242         * WebView/WebPreferenceKeysPrivate.h:
243         * WebView/WebPreferences.mm:
244         (+[WebPreferences initialize]):
245         (-[WebPreferences adClickAttributionEnabled]):
246         (-[WebPreferences setAdClickAttributionEnabled:]):
247             Added support for experimental ad click attribution.
248         * WebView/WebPreferencesPrivate.h:
249         * WebView/WebView.mm:
250         (-[WebView _preferencesChanged:]):
251
252 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
253
254         Move FileSystem to WTF
255         https://bugs.webkit.org/show_bug.cgi?id=193602
256
257         Reviewed by Yusuke Suzuki.
258
259         * Misc/WebNSFileManagerExtras.mm:
260         * Storage/WebDatabaseProvider.mm:
261         * WebView/WebView.mm:
262
263 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
264
265         Fix the Apple Internal build. See <rdar://problem/47491383>.
266
267         Rubber-stamped by Tim Horton.
268
269         * WebCoreSupport/WebFrameLoaderClient.mm:
270
271 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
272
273         Clean up USE(WEB_THREAD)
274         https://bugs.webkit.org/show_bug.cgi?id=193698
275
276         Rubber-stamped by Tim Horton.
277
278         * Misc/WebCache.mm:
279         (+[WebCache emptyInMemoryResources]):
280         * WebCoreSupport/WebFrameLoaderClient.mm:
281         (-[WebFramePolicyListener use]):
282         * WebCoreSupport/WebGeolocationClient.mm:
283         (-[WebGeolocationPolicyListener allow]):
284         (-[WebGeolocationPolicyListener deny]):
285         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
286         * WebView/WebFrame.mm:
287         (-[WebFrame deviceOrientationChanged]):
288         * WebView/WebHTMLView.mm:
289         (hardwareKeyboardAvailabilityChangedCallback):
290         * WebView/WebView.mm:
291         (+[WebView _releaseMemoryNow]):
292         (+[WebView willEnterBackgroundWithCompletionHandler:]):
293         (-[WebView updateLayoutIgnorePendingStyleSheets]):
294         (-[WebView _dispatchUnloadEvent]):
295         (-[WebView _close]):
296         (-[WebView _preferencesChangedNotification:]):
297         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
298         (-[WebView goBack]):
299         (-[WebView goForward]):
300         (+[WebView _cacheModelChangedNotification:]):
301         (-[WebView stopLoading:]):
302         (-[WebView stopLoadingAndClear]):
303         (-[WebView reload:]):
304         (WebInstallMemoryPressureHandler):
305
306 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
307
308         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
309         https://bugs.webkit.org/show_bug.cgi?id=193706
310         <rdar://problem/44807048>
311
312         Reviewed by Ryosuke Niwa.
313
314         Use UndoStep::label().
315
316         * WebCoreSupport/WebEditorClient.h:
317         * WebCoreSupport/WebEditorClient.mm:
318         (-[WebUndoStep initWithUndoStep:]):
319         (+[WebUndoStep stepWithUndoStep:]):
320         (WebEditorClient::registerUndoOrRedoStep):
321         (WebEditorClient::registerUndoStep):
322         (WebEditorClient::registerRedoStep):
323
324 2019-01-22  Alex Christensen  <achristensen@webkit.org>
325
326         Move NetworkStorageSession ownership to NetworkProcess
327         https://bugs.webkit.org/show_bug.cgi?id=193580
328
329         Reviewed by Geoff Garen.
330
331         * Misc/WebCache.mm:
332         (+[WebCache clearCachedCredentials]):
333         * Misc/WebDownload.mm:
334         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
335         * Plugins/WebBaseNetscapePluginView.mm:
336         (WebKit::getAuthenticationInfo):
337         * WebCoreSupport/WebFrameNetworkingContext.mm:
338         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
339         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
340         (WebFrameNetworkingContext::storageSession const):
341         * WebView/WebPreferences.mm:
342         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
343         (+[WebPreferences _clearNetworkLoaderSession]):
344         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
345
346 2019-01-22  Daniel Bates  <dabates@apple.com>
347
348         [iOS] Interpret text key commands on keydown and app key commands on keypress
349         https://bugs.webkit.org/show_bug.cgi?id=192897
350         <rdar://problem/46857378>
351
352         Reviewed by Brent Fulgham.
353
354         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
355         is false) and keypress (isCharEvent is true), respectively.
356
357         * WebView/WebHTMLView.mm:
358         (-[WebHTMLView _handleEditingKeyEvent:]):
359
360 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
361
362         [css-logical] Implement flow-relative margin, padding and border shorthands
363         https://bugs.webkit.org/show_bug.cgi?id=188697
364
365         Reviewed by Simon Fraser and Antti Koivisto.
366
367         Add CSSLogicalEnabled runtime flag.
368
369         * WebView/WebPreferenceKeysPrivate.h:
370         * WebView/WebPreferences.mm:
371         (+[WebPreferences initialize]):
372         (-[WebPreferences cssLogicalEnabled]):
373         (-[WebPreferences setCSSLogicalEnabled:]):
374         * WebView/WebPreferencesPrivate.h:
375         * WebView/WebView.mm:
376         (-[WebView _preferencesChanged:]):
377
378 2019-01-15  Darin Adler  <darin@apple.com>
379
380         Use references rather than pointers for register/unregister functions, and more
381         https://bugs.webkit.org/show_bug.cgi?id=175028
382
383         Reviewed by Daniel Bates.
384
385         * WebCoreSupport/WebKitFullScreenListener.mm:
386         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
387         functions in Document; pass a reference.
388         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
389         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
390         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
391         * WebView/WebFullScreenController.mm:
392         (-[WebFullScreenController enterFullScreen:]): Ditto.
393         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
394         (-[WebFullScreenController exitFullScreen]): Ditto.
395         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
396         * WebView/WebFullScreenController.mm:
397         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
398
399 2019-01-12  Dan Bernstein  <mitz@apple.com>
400
401         [Cocoa] Avoid importing directly from subumbrella frameworks
402         https://bugs.webkit.org/show_bug.cgi?id=186016
403         <rdar://problem/40591038>
404
405         Reviewed by Sam Weinig.
406
407         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
408         * Carbon/CarbonWindowAdapter.mm: Ditto.
409         * Carbon/CarbonWindowFrame.m: Ditto.
410         * Carbon/HIViewAdapter.h: Ditto.
411         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
412           OTHER_CFLAGS_COCOA_TOUCH_NO.
413         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
414         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
415         * WebView/WebPDFView.h: Ditto.
416
417 2019-01-20  Antoine Quint  <graouts@apple.com>
418
419         Add a POINTER_EVENTS feature flag
420         https://bugs.webkit.org/show_bug.cgi?id=193577
421         <rdar://problem/47408511>
422
423         Unreviewed. Also enable Pointer Events for iosmac.
424
425         * Configurations/FeatureDefines.xcconfig:
426
427 2019-01-19  Antoine Quint  <graouts@apple.com>
428
429         Add a POINTER_EVENTS feature flag
430         https://bugs.webkit.org/show_bug.cgi?id=193577
431
432         Reviewed by Dean Jackson.
433
434         * Configurations/FeatureDefines.xcconfig:
435
436 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
437
438         Revert r238815, it broke WK1 video fullscreen on Mac
439         https://bugs.webkit.org/show_bug.cgi?id=193586
440         <rdar://problem/47358941>
441
442         Reviewed by Jer Noble.
443
444         * WebView/WebVideoFullscreenController.h: Added.
445         * WebView/WebVideoFullscreenController.mm: Added.
446         (SOFT_LINK_CLASS):
447         (-[WebVideoFullscreenController init]):
448         (-[WebVideoFullscreenController dealloc]):
449         (-[WebVideoFullscreenController fullscreenWindow]):
450         (-[WebVideoFullscreenController windowDidLoad]):
451         (-[WebVideoFullscreenController videoElement]):
452         (-[WebVideoFullscreenController setVideoElement:]):
453         (-[WebVideoFullscreenController clearFadeAnimation]):
454         (-[WebVideoFullscreenController windowDidExitFullscreen]):
455         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
456         (-[WebVideoFullscreenController videoElementRect]):
457         (-[WebVideoFullscreenController applicationDidResignActive:]):
458         (frameExpandedToRatioOfFrame):
459         (createBackgroundFullscreenWindow):
460         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
461         (-[WebVideoFullscreenController enterFullscreen:]):
462         (-[WebVideoFullscreenController exitFullscreen]):
463         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
464         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
465         (-[WebVideoFullscreenController _requestExit]):
466         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
467         (-[WebVideoFullscreenController requestExitFullscreen]):
468         (-[WebVideoFullscreenController fadeHUDIn]):
469         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
470         (-[WebVideoFullscreenController rateChanged:]):
471         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
472         (-[WebVideoFullscreenWindow dealloc]):
473         (-[WebVideoFullscreenWindow resignFirstResponder]):
474         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
475         (-[WebVideoFullscreenWindow mouseDown:]):
476         (-[WebVideoFullscreenWindow cancelOperation:]):
477         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
478         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
479         (-[WebVideoFullscreenWindow animationDidEnd:]):
480         (-[WebVideoFullscreenWindow mouseMoved:]):
481         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
482         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
483         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
484         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
485         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
486         (-[WebVideoFullscreenHUDWindow center]):
487         (-[WebVideoFullscreenHUDWindow keyDown:]):
488         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
489         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
490         (-[WebVideoFullscreenHUDWindowController init]):
491         (-[WebVideoFullscreenHUDWindowController dealloc]):
492         (-[WebVideoFullscreenHUDWindowController setArea:]):
493         (-[WebVideoFullscreenHUDWindowController keyDown:]):
494         (-[WebVideoFullscreenHUDWindowController delegate]):
495         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
496         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
497         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
498         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
499         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
500         (-[WebVideoFullscreenHUDWindowController closeWindow]):
501         (createMediaUIControl):
502         (createControlWithMediaUIControlType):
503         (createTimeTextField):
504         (createMediaUIBackgroundView):
505         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
506         (-[WebVideoFullscreenHUDWindowController updateVolume]):
507         (-[WebVideoFullscreenHUDWindowController updateTime]):
508         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
509         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
510         (-[WebVideoFullscreenHUDWindowController currentTime]):
511         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
512         (-[WebVideoFullscreenHUDWindowController duration]):
513         (-[WebVideoFullscreenHUDWindowController maxVolume]):
514         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
515         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
516         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
517         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
518         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
519         (-[WebVideoFullscreenHUDWindowController volume]):
520         (-[WebVideoFullscreenHUDWindowController setVolume:]):
521         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
522         (-[WebVideoFullscreenHUDWindowController updateRate]):
523         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
524         (-[WebVideoFullscreenHUDWindowController playing]):
525         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
526         (timeToString):
527         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
528         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
529         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
530         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
531         (-[WebVideoFullscreenHUDWindowController rewind:]):
532         (-[WebVideoFullscreenHUDWindowController fastForward:]):
533         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
534         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
535         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
536         * WebView/WebView.mm:
537         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
538         (-[WebView _exitVideoFullscreen]):
539
540 2019-01-18  Tim Horton  <timothy_horton@apple.com>
541
542         Get rid of ADVANCED_SPELL_CHECKING
543         https://bugs.webkit.org/show_bug.cgi?id=193592
544
545         Reviewed by Wenson Hsieh.
546
547         * WebCoreSupport/WebEditorClient.mm:
548         (insertionPointFromCurrentSelection):
549         (WebEditorClient::checkTextOfParagraph):
550         (WebEditorClient::getGuessesForWord):
551         (WebEditorClient::requestCandidatesForSelection):
552         (WebEditorClient::requestCheckingOfString):
553         * WebView/WebHTMLView.mm:
554         (-[WebHTMLView insertText:]):
555
556 2019-01-18  Jer Noble  <jer.noble@apple.com>
557
558         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
559         https://bugs.webkit.org/show_bug.cgi?id=189553
560
561         Reviewed by Tim Horton.
562
563         * Configurations/Base.xcconfig:
564         * Configurations/SDKVariant.xcconfig: Added.
565         * Configurations/WebKitLegacy.xcconfig:
566
567 2019-01-18  David Kilzer  <ddkilzer@apple.com>
568
569         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
570         <https://webkit.org/b/193568>
571         <rdar://problem/47381130>
572
573         Reviewed by Alex Christensen.
574
575         * WebView/WebView.mm:
576         - Remove unused soft-linking macros.
577         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
578         (-[WebUITextIndicatorData initWithImage:scale:]):
579         - Update to use exported PAL functions.
580
581 2019-01-17  Truitt Savell  <tsavell@apple.com>
582
583         Unreviewed, rolling out r240124.
584
585         This commit broke an internal build.
586
587         Reverted changeset:
588
589         "SDK_VARIANT build destinations should be separate from non-
590         SDK_VARIANT builds"
591         https://bugs.webkit.org/show_bug.cgi?id=189553
592         https://trac.webkit.org/changeset/240124
593
594 2019-01-17  Jer Noble  <jer.noble@apple.com>
595
596         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
597         https://bugs.webkit.org/show_bug.cgi?id=189553
598
599         Reviewed by Tim Horton.
600
601         * Configurations/Base.xcconfig:
602         * Configurations/SDKVariant.xcconfig: Added.
603         * Configurations/WebKitLegacy.xcconfig:
604
605 2019-01-17  Alex Christensen  <achristensen@webkit.org>
606
607         Stop using NetworkStorageSession::storageSession in WebCore
608         https://bugs.webkit.org/show_bug.cgi?id=193529
609
610         Reviewed by Tim Horton.
611
612         * Misc/WebCache.mm:
613         (+[WebCache addImageToCache:forURL:forFrame:]):
614         * WebView/WebView.mm:
615         (-[WebView _commonInitializationWithFrameName:groupName:]):
616         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
617
618 2019-01-15  Alex Christensen  <achristensen@webkit.org>
619
620         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
621         https://bugs.webkit.org/show_bug.cgi?id=193368
622
623         Reviewed by Geoff Garen.
624
625         * Misc/WebCache.mm:
626         (+[WebCache clearCachedCredentials]):
627         * Misc/WebDownload.mm:
628         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
629         * Plugins/WebBaseNetscapePluginView.mm:
630         (WebKit::getAuthenticationInfo):
631
632 2019-01-15  Alex Christensen  <achristensen@webkit.org>
633
634         Stop using CookiesStrategy
635         https://bugs.webkit.org/show_bug.cgi?id=161106
636
637         Reviewed by Don Olmstead and Antti Koivisto.
638
639         * Misc/WebCache.mm:
640         (+[WebCache addImageToCache:forURL:forFrame:]):
641         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
642         (WebKit::NetscapePluginInstanceProxy::getCookies):
643         (WebKit::NetscapePluginInstanceProxy::setCookies):
644         * Plugins/WebNetscapePluginView.mm:
645         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
646         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
647         * WebCoreSupport/WebPlatformStrategies.h:
648         * WebCoreSupport/WebPlatformStrategies.mm:
649         (WebPlatformStrategies::createCookiesStrategy): Deleted.
650         (WebPlatformStrategies::cookiesForDOM): Deleted.
651         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
652         (WebPlatformStrategies::cookiesEnabled): Deleted.
653         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
654         (WebPlatformStrategies::getRawCookies): Deleted.
655         (WebPlatformStrategies::deleteCookie): Deleted.
656         * WebView/WebView.mm:
657         (-[WebView _commonInitializationWithFrameName:groupName:]):
658         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
659
660 2019-01-15  Tim Horton  <timothy_horton@apple.com>
661
662         Cannot tab out of WKWebView on macOS
663         https://bugs.webkit.org/show_bug.cgi?id=161448
664         <rdar://problem/28100085>
665
666         Reviewed by Dean Jackson.
667
668         * WebCoreSupport/WebChromeClient.mm:
669         * WebView/WebView.mm:
670         Make use of SPI headers.
671
672 2019-01-14  Commit Queue  <commit-queue@webkit.org>
673
674         Unreviewed, rolling out r239901, r239909, r239910, r239912,
675         r239913, and r239914.
676         https://bugs.webkit.org/show_bug.cgi?id=193407
677
678         These revisions caused an internal failure (Requested by
679         Truitt on #webkit).
680
681         Reverted changesets:
682
683         "[Cocoa] Avoid importing directly from subumbrella frameworks"
684         https://bugs.webkit.org/show_bug.cgi?id=186016
685         https://trac.webkit.org/changeset/239901
686
687         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
688         https://trac.webkit.org/changeset/239909
689
690         "Tried to fix the build."
691         https://trac.webkit.org/changeset/239910
692
693         "Fixed iOS builds after r239910."
694         https://trac.webkit.org/changeset/239912
695
696         "More build fixing."
697         https://trac.webkit.org/changeset/239913
698
699         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
700         https://trac.webkit.org/changeset/239914
701
702 2019-01-14  Mark Lam  <mark.lam@apple.com>
703
704         Re-enable ability to build --cloop builds.
705         https://bugs.webkit.org/show_bug.cgi?id=192955
706         <rdar://problem/46882363>
707
708         Reviewed by Saam barati and Keith Miller.
709
710         * Configurations/FeatureDefines.xcconfig:
711
712 2019-01-13  Dan Bernstein  <mitz@apple.com>
713
714         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
715
716         Patch by Keith Rollin.
717
718         * WebView/PDFViewSPI.h:
719
720 2019-01-12  Timothy Hatcher  <timothy@apple.com>
721
722         Have prefers-color-scheme: light always match on macOS versions before Mojave.
723         https://bugs.webkit.org/show_bug.cgi?id=191655
724         rdar://problem/46074680
725
726         Reviewed by Megan Gardner.
727
728         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
729         * WebView/WebView.mm:
730         (-[WebView _effectiveAppearanceIsDark]):
731
732 2019-01-12  Dan Bernstein  <mitz@apple.com>
733
734         [Cocoa] Avoid importing directly from subumbrella frameworks
735         https://bugs.webkit.org/show_bug.cgi?id=186016
736         <rdar://problem/40591038>
737
738         Reviewed by Sam Weinig.
739
740         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
741         * Carbon/CarbonWindowAdapter.mm: Ditto.
742         * Carbon/CarbonWindowFrame.m: Ditto.
743         * Carbon/HIViewAdapter.h: Ditto.
744         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
745           OTHER_CFLAGS_COCOA_TOUCH_NO.
746         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
747         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
748         * WebView/WebPDFView.h: Ditto.
749
750 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
751
752         Enable visual viewport API by default
753         https://bugs.webkit.org/show_bug.cgi?id=193376
754
755         Reviewed by Simon Fraser.
756
757         * WebView/WebPreferences.mm:
758         (+[WebPreferences initialize]):
759
760 2019-01-11  John Wilander  <wilander@apple.com>
761
762         Compile out Web API Statistics Collection
763         https://bugs.webkit.org/show_bug.cgi?id=193370
764         <rdar://problem/45388584>
765
766         Reviewed by Brent Fulgham.
767
768         * Configurations/FeatureDefines.xcconfig:
769             Defined ENABLE_WEB_API_STATISTICS, off by default.
770
771 2019-01-08  Alex Christensen  <achristensen@webkit.org>
772
773         Stop using NetworkStorageSession in WebProcess
774         https://bugs.webkit.org/show_bug.cgi?id=193236
775
776         Reviewed by Don Olmstead.
777
778         * WebCoreSupport/WebFrameNetworkingContext.h:
779         * WebCoreSupport/WebFrameNetworkingContext.mm:
780         (WebFrameNetworkingContext::storageSession const):
781         * WebCoreSupport/WebPlatformStrategies.h:
782         * WebCoreSupport/WebPlatformStrategies.mm:
783         (WebPlatformStrategies::cookiesForDOM):
784         (WebPlatformStrategies::setCookiesFromDOM):
785         (WebPlatformStrategies::cookiesEnabled):
786         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
787         (WebPlatformStrategies::getRawCookies):
788         (WebPlatformStrategies::deleteCookie):
789         * WebView/WebView.mm:
790         (-[WebView _cachedResponseForURL:]):
791         (-[WebView _clearCredentials]):
792
793 2019-01-08  Alex Christensen  <achristensen@webkit.org>
794
795         Unreviewed, rolling out r239727.
796
797         Broke API tests
798
799         Reverted changeset:
800
801         "Stop using NetworkStorageSession in WebProcess"
802         https://bugs.webkit.org/show_bug.cgi?id=193236
803         https://trac.webkit.org/changeset/239727
804
805 2019-01-08  Alex Christensen  <achristensen@webkit.org>
806
807         Stop using NetworkStorageSession in WebProcess
808         https://bugs.webkit.org/show_bug.cgi?id=193236
809
810         Reviewed by Don Olmstead.
811
812         * WebCoreSupport/WebFrameNetworkingContext.h:
813         * WebCoreSupport/WebFrameNetworkingContext.mm:
814         (WebFrameNetworkingContext::storageSession const):
815         * WebView/WebView.mm:
816         (-[WebView _cachedResponseForURL:]):
817         (-[WebView _clearCredentials]):
818
819 2019-01-07  David Kilzer  <ddkilzer@apple.com>
820
821         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
822         <https://webkit.org/b/193056>
823
824         Reviewed by Alex Christensen.
825
826         * Plugins/Hosted/NetscapePluginHostProxy.h:
827         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
828         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
829         (WebKit::NetscapePluginInstanceProxy::enumerate):
830         (WebKit::NetscapePluginInstanceProxy::marshalValue):
831         (WebKit::NetscapePluginInstanceProxy::marshalValues):
832         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
833         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
834         * Plugins/Hosted/ProxyInstance.mm:
835         (WebKit::ProxyInstance::invoke):
836         * WebCoreSupport/WebGeolocationClient.mm:
837         * WebView/WebDataSource.mm:
838         (-[WebDataSource _receivedData:]):
839         * WebView/WebView.mm:
840         (-[WebView _cachedResponseForURL:]):
841         - Remove '*' from RetainPtr<> type.
842
843 2019-01-04  Alex Christensen  <achristensen@webkit.org>
844
845         Progress towards fixing Mac CMake build
846         https://bugs.webkit.org/show_bug.cgi?id=193105
847
848         Reviewed by Don Olmstead.
849
850         * WebKitPrefix.h:
851
852 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
853
854         Web Inspector: Use save sheet instead of dialog where possible
855         https://bugs.webkit.org/show_bug.cgi?id=193160
856         <rdar://problem/37399759>
857
858         Reviewed by Devin Rousso.
859
860         * WebCoreSupport/WebInspectorClient.mm:
861         (WebInspectorFrontendClient::save):
862
863 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
864
865         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
866         https://bugs.webkit.org/show_bug.cgi?id=193129
867
868         Reviewed by Tim Horton.
869
870         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
871
872         * WebCoreSupport/WebEditorClient.mm:
873         (WebEditorClient::registerUndoOrRedoStep):
874         (undoNameForEditAction): Deleted.
875
876 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
877
878         Add support for using the current text selection as the find string on iOS
879         https://bugs.webkit.org/show_bug.cgi?id=193034
880         <rdar://problem/45138739>
881
882         Reviewed by Tim Horton.
883
884         Add a method stub for WebKitLegacy.
885
886         * WebCoreSupport/WebEditorClient.h:
887
888 2019-01-01  Jeff Miller  <jeffm@apple.com>
889
890         Update user-visible copyright strings to include 2019
891         https://bugs.webkit.org/show_bug.cgi?id=192811
892
893         Reviewed by Mark Lam.
894
895         * Info.plist:
896
897 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
898
899         Use Ref<> as much as possible
900         https://bugs.webkit.org/show_bug.cgi?id=192808
901
902         Reviewed by Alex Christensen.
903
904         * DOM/DOM.mm:
905         (-[DOMNode getPreviewSnapshotImage:andRects:]):
906         * Plugins/Hosted/NetscapePluginHostManager.mm:
907         (WebKit::NetscapePluginHostManager::instantiatePlugin):
908         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
909         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
910         (WebKit::NetscapePluginInstanceProxy::loadRequest):
911         * Plugins/WebNetscapePluginView.mm:
912         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
913         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
914         * WebCoreSupport/WebContextMenuClient.mm:
915         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
916         * WebCoreSupport/WebFrameLoaderClient.mm:
917         (WebFrameLoaderClient::transitionToCommittedForNewPage):
918         * WebView/WebFrame.mm:
919         (-[WebFrame getDictationResultRanges:andMetadatas:]):
920         * WebView/WebHTMLView.mm:
921         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
922         * WebView/WebView.mm:
923         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
924         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
925
926 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
927
928         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
929         https://bugs.webkit.org/show_bug.cgi?id=192821
930
931         Reviewed by Chris Dumez.
932
933         When a window becomes occluded, the window server informs the application.
934         This should be used to suspend any work that is not visible by the user.
935
936         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
937         In some cases, that lead to performance impact (see radar).
938
939         This patch adds an observer for the occlusion notification. I tried to stick
940         with the same names used by WebKit2.
941
942         * WebView/WebView.mm:
943         (-[WebView _isViewVisible]):
944         (-[WebView addWindowObserversForWindow:]):
945         (-[WebView removeWindowObservers]):
946         (-[WebView _windowDidChangeOcclusionState:]):
947
948 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
949
950         [WebAuthN] Add a runtime flag for local authenticator
951         https://bugs.webkit.org/show_bug.cgi?id=192792
952         <rdar://problem/46798738>
953
954         Reviewed by Brent Fulgham.
955
956         * WebView/WebPreferenceKeysPrivate.h:
957         * WebView/WebPreferences.mm:
958         (+[WebPreferences initialize]):
959         (-[WebPreferences webAuthenticationEnabled]): Deleted.
960         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
961         * WebView/WebPreferencesPrivate.h:
962         * WebView/WebView.mm:
963         (-[WebView _preferencesChanged:]):
964
965 2018-12-20  Chris Dumez  <cdumez@apple.com>
966
967         Use Optional::valueOr() instead of Optional::value_or()
968         https://bugs.webkit.org/show_bug.cgi?id=192933
969
970         Reviewed by Geoffrey Garen.
971
972         * WebCoreSupport/WebSecurityOrigin.mm:
973         (-[WebSecurityOrigin port]):
974
975 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
976
977         Unreviewed, rolling out r239417.
978
979         Introduced two API test failures on macOS.
980
981         Reverted changeset:
982
983         "<rdar://problem/46194315> macOS: WebKit1 does not handle
984         occlusion changes"
985         https://bugs.webkit.org/show_bug.cgi?id=192821
986         https://trac.webkit.org/changeset/239417
987
988 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
989
990         WKWebView default UA doesn't freeze the build number
991         https://bugs.webkit.org/show_bug.cgi?id=192809
992         <rdar://problem/44687185>
993
994         Reviewed by Andy Estes.
995
996         Always reports the frozen build number.
997
998         * WebView/WebView.mm:
999         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1000         actual build number through this method call.
1001         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1002
1003 2018-12-19  Chris Dumez  <cdumez@apple.com>
1004
1005         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1006         https://bugs.webkit.org/show_bug.cgi?id=192728
1007         <rdar://problem/46746779>
1008
1009         Reviewed by Geoff Garen.
1010
1011         * DOM/*:
1012         * Plugins/*:
1013         * WebCoreSupport/*:
1014         * WebView/*:
1015
1016 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1017
1018         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1019         https://bugs.webkit.org/show_bug.cgi?id=192821
1020
1021         Reviewed by Chris Dumez.
1022
1023         When a window becomes occluded, the window server informs the application.
1024         This should be used to suspend any work that is not visible by the user.
1025
1026         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1027         In some cases, that lead to performance impact (see radar).
1028
1029         This patch adds an observer for the occlusion notification. I tried to stick
1030         with the same names used by WebKit2.
1031
1032         * WebView/WebView.mm:
1033         (-[WebView _isViewVisible]):
1034         (-[WebView addWindowObserversForWindow:]):
1035         (-[WebView removeWindowObservers]):
1036         (-[WebView _windowDidChangeOcclusionState:]):
1037
1038 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1039
1040         Allow clients to set the navigator platform
1041         https://bugs.webkit.org/show_bug.cgi?id=192735
1042
1043         Reviewed by Tim Horton.
1044
1045         Add stubs to fill out the added functionality in FrameLoaderClient.
1046
1047         * WebCoreSupport/WebFrameLoaderClient.h:
1048         * WebCoreSupport/WebFrameLoaderClient.mm:
1049         (WebFrameLoaderClient::navigatorPlatform):
1050
1051 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1052
1053         offsetLeft and offsetParent should adjust across shadow boundaries
1054         https://bugs.webkit.org/show_bug.cgi?id=157437
1055         <rdar://problem/26154021>
1056
1057         Reviewed by Simon Fraser.
1058
1059         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1060
1061         * DOM/DOMElement.mm:
1062         (-[DOMElement offsetLeft]):
1063         (-[DOMElement offsetTop]):
1064         (-[DOMElement offsetParent]):
1065
1066 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1067
1068         Unreviewed build fix.
1069
1070         * WebView/WebFrame.mm:
1071         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1072
1073 2018-12-15  Darin Adler  <darin@apple.com>
1074
1075         Use warning-ignoring macros more consistently and simply
1076         https://bugs.webkit.org/show_bug.cgi?id=192743
1077
1078         Reviewed by Mark Lam.
1079
1080         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1081         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1082         compilers in Objective-C++ code.
1083
1084         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1085         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1086         accomodate non-clang compilers here. Also use #pragma once, add a missing
1087         "explicit" and fix conditionals.
1088
1089 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1090
1091         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1092         https://bugs.webkit.org/show_bug.cgi?id=192653
1093
1094         Reviewed by Wenson Hsieh.
1095
1096         * WebView/WebHTMLView.mm:
1097         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1098
1099 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1100
1101         Implement feature flag for CSS Typed OM
1102         https://bugs.webkit.org/show_bug.cgi?id=192610
1103
1104         Reviewed by Ryosuke Niwa.
1105
1106         * Configurations/FeatureDefines.xcconfig:
1107
1108 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1109
1110         WebCore shouldn't have a Objective-C class named NSCursor
1111         https://bugs.webkit.org/show_bug.cgi?id=192602
1112         <rdar://problem/46615532>
1113
1114         Reviewed by Wenson Hsieh.
1115
1116         * WebView/WebFrameView.mm:
1117         (-[WebFrameView keyDown:keyDown:]):
1118         * WebView/WebHTMLView.mm:
1119         (-[WebHTMLView keyDown:]):
1120         (-[WebHTMLView performKeyEquivalent:]):
1121         Only use NSCursor on macOS.
1122
1123 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1124
1125         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1126         https://bugs.webkit.org/show_bug.cgi?id=192573
1127
1128         Reviewed by Simon Fraser.
1129
1130         * Configurations/FeatureDefines.xcconfig:
1131
1132 2018-12-10  Antti Koivisto  <antti@apple.com>
1133
1134         Rename "forced style recalc" to "full style rebuild"
1135         https://bugs.webkit.org/show_bug.cgi?id=192572
1136
1137         Reviewed by Zalan Bujtas.
1138
1139         * WebView/WebHTMLView.mm:
1140         (-[WebHTMLView setNeedsToApplyStyles:]):
1141
1142 2018-12-10  Darin Adler  <darin@apple.com>
1143
1144         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1145         https://bugs.webkit.org/show_bug.cgi?id=192533
1146         rdar://problem/45732710
1147
1148         Reviewed by Anders Carlsson.
1149
1150         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1151         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1152
1153 2018-12-10  Darin Adler  <darin@apple.com>
1154
1155         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1156         https://bugs.webkit.org/show_bug.cgi?id=192532
1157         rdar://problem/45731047
1158
1159         Reviewed by Chris Dumez.
1160
1161         * Plugins/Hosted/NetscapePluginHostManager.mm:
1162         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1163         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1164         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1165
1166 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1167
1168         Turn WritingDirection into an enum class
1169         https://bugs.webkit.org/show_bug.cgi?id=192401
1170         Work towards <rdar://problem/42075638>
1171
1172         Reviewed by Dan Bernstein.
1173
1174         Change WritingDirection from an enum to an enum class. No change in behavior.
1175
1176         * WebView/WebHTMLView.mm:
1177         (-[WebHTMLView toggleBaseWritingDirection:]):
1178         (-[WebHTMLView changeBaseWritingDirection:]):
1179         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1180
1181 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1182
1183         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1184         https://bugs.webkit.org/show_bug.cgi?id=192272
1185
1186         Reviewed by Brady Eidson.
1187
1188         * WebCoreSupport/WebFrameLoaderClient.h:
1189         * WebCoreSupport/WebFrameLoaderClient.mm:
1190         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1191
1192 2018-12-03  Jer Noble  <jer.noble@apple.com>
1193
1194         Get rid of old, dead Mac video fullscreen code.
1195         https://bugs.webkit.org/show_bug.cgi?id=192315
1196
1197         Reviewed by Eric Carlson.
1198
1199         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1200         is no longer supported in the Mac port.
1201
1202         * WebView/WebVideoFullscreenController.h: Removed.
1203         * WebView/WebVideoFullscreenController.mm: Removed.
1204         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1205         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1206         * WebView/WebView.mm:
1207         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1208         (-[WebView _exitVideoFullscreen]):
1209
1210 2018-12-03  Daniel Bates  <dabates@apple.com>
1211
1212         [iOS] Do not handle key events that are key commands
1213         https://bugs.webkit.org/show_bug.cgi?id=191608
1214         <rdar://problem/46046013>
1215
1216         Reviewed by Ryosuke Niwa.
1217
1218         A key down event may be associated with a key command. If it is then we want to execute the
1219         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1220         event as a key command to find out.
1221
1222         * WebView/WebHTMLView.mm:
1223         (-[WebHTMLView _handleEditingKeyEvent:]):
1224
1225 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1226
1227         Add a runtime feature flag for LayoutFormattingContext.
1228         https://bugs.webkit.org/show_bug.cgi?id=192280
1229
1230         Reviewed by Simon Fraser.
1231
1232         * Configurations/FeatureDefines.xcconfig:
1233
1234 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1235
1236         Move URL from WebCore to WTF
1237         https://bugs.webkit.org/show_bug.cgi?id=190234
1238
1239         Reviewed by Keith Miller.
1240
1241         * DOM/DOMAttr.mm:
1242         * DOM/DOMBlob.mm:
1243         * DOM/DOMCSSCharsetRule.mm:
1244         * DOM/DOMCSSImportRule.mm:
1245         * DOM/DOMCSSMediaRule.mm:
1246         * DOM/DOMCSSPageRule.mm:
1247         * DOM/DOMCSSPrimitiveValue.mm:
1248         * DOM/DOMCSSRule.mm:
1249         * DOM/DOMCSSStyleDeclaration.mm:
1250         * DOM/DOMCSSStyleRule.mm:
1251         * DOM/DOMCSSStyleSheet.mm:
1252         * DOM/DOMCSSValue.mm:
1253         * DOM/DOMCharacterData.mm:
1254         * DOM/DOMCounter.mm:
1255         * DOM/DOMDocument.mm:
1256         * DOM/DOMDocumentFragment.mm:
1257         * DOM/DOMDocumentType.mm:
1258         * DOM/DOMEvent.mm:
1259         * DOM/DOMFile.mm:
1260         * DOM/DOMHTMLAnchorElement.mm:
1261         * DOM/DOMHTMLAppletElement.mm:
1262         * DOM/DOMHTMLAreaElement.mm:
1263         * DOM/DOMHTMLBRElement.mm:
1264         * DOM/DOMHTMLBaseElement.mm:
1265         * DOM/DOMHTMLBaseFontElement.mm:
1266         * DOM/DOMHTMLBodyElement.mm:
1267         * DOM/DOMHTMLButtonElement.mm:
1268         * DOM/DOMHTMLCanvasElement.mm:
1269         * DOM/DOMHTMLCollection.mm:
1270         * DOM/DOMHTMLDivElement.mm:
1271         * DOM/DOMHTMLDocument.mm:
1272         * DOM/DOMHTMLElement.mm:
1273         * DOM/DOMHTMLEmbedElement.mm:
1274         * DOM/DOMHTMLFieldSetElement.mm:
1275         * DOM/DOMHTMLFontElement.mm:
1276         * DOM/DOMHTMLFormElement.mm:
1277         * DOM/DOMHTMLFrameElement.mm:
1278         * DOM/DOMHTMLFrameSetElement.mm:
1279         * DOM/DOMHTMLHRElement.mm:
1280         * DOM/DOMHTMLHeadElement.mm:
1281         * DOM/DOMHTMLHeadingElement.mm:
1282         * DOM/DOMHTMLHtmlElement.mm:
1283         * DOM/DOMHTMLIFrameElement.mm:
1284         * DOM/DOMHTMLImageElement.mm:
1285         * DOM/DOMHTMLInputElement.mm:
1286         * DOM/DOMHTMLLIElement.mm:
1287         * DOM/DOMHTMLLabelElement.mm:
1288         * DOM/DOMHTMLLegendElement.mm:
1289         * DOM/DOMHTMLLinkElement.mm:
1290         * DOM/DOMHTMLMapElement.mm:
1291         * DOM/DOMHTMLMarqueeElement.mm:
1292         * DOM/DOMHTMLMediaElement.mm:
1293         * DOM/DOMHTMLMetaElement.mm:
1294         * DOM/DOMHTMLModElement.mm:
1295         * DOM/DOMHTMLOListElement.mm:
1296         * DOM/DOMHTMLObjectElement.mm:
1297         * DOM/DOMHTMLOptGroupElement.mm:
1298         * DOM/DOMHTMLOptionElement.mm:
1299         * DOM/DOMHTMLOptionsCollection.mm:
1300         * DOM/DOMHTMLParagraphElement.mm:
1301         * DOM/DOMHTMLParamElement.mm:
1302         * DOM/DOMHTMLQuoteElement.mm:
1303         * DOM/DOMHTMLScriptElement.mm:
1304         * DOM/DOMHTMLSelectElement.mm:
1305         * DOM/DOMHTMLStyleElement.mm:
1306         * DOM/DOMHTMLTableCaptionElement.mm:
1307         * DOM/DOMHTMLTableCellElement.mm:
1308         * DOM/DOMHTMLTableColElement.mm:
1309         * DOM/DOMHTMLTableElement.mm:
1310         * DOM/DOMHTMLTableRowElement.mm:
1311         * DOM/DOMHTMLTableSectionElement.mm:
1312         * DOM/DOMHTMLTitleElement.mm:
1313         * DOM/DOMHTMLUListElement.mm:
1314         * DOM/DOMHTMLVideoElement.mm:
1315         * DOM/DOMKeyboardEvent.mm:
1316         * DOM/DOMMediaList.mm:
1317         * DOM/DOMMouseEvent.mm:
1318         * DOM/DOMMutationEvent.mm:
1319         * DOM/DOMNamedNodeMap.mm:
1320         * DOM/DOMProcessingInstruction.mm:
1321         * DOM/DOMRange.mm:
1322         * DOM/DOMStyleSheet.mm:
1323         * DOM/DOMText.mm:
1324         * DOM/DOMTextEvent.mm:
1325         * DOM/DOMTokenList.mm:
1326         * DOM/DOMUIEvent.mm:
1327         * DOM/DOMXPathResult.mm:
1328         * History/WebHistoryItem.mm:
1329         * Misc/WebNSURLExtras.mm:
1330         (-[NSURL _web_userVisibleString]):
1331         (-[NSURL _web_URLByRemovingUserInfo]):
1332         (-[NSURL _web_dataForURLComponentType:]):
1333         (-[NSURL _web_schemeData]):
1334         (-[NSURL _web_hostData]):
1335         * Misc/WebUserContentURLPattern.mm:
1336         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1337         * Plugins/WebNetscapePluginStream.h:
1338         (WebNetscapePluginStream::setRequestURL):
1339         * WebCoreSupport/WebChromeClient.h:
1340         * WebCoreSupport/WebChromeClient.mm:
1341         (WebChromeClient::signedPublicKeyAndChallengeString const):
1342         * WebCoreSupport/WebContextMenuClient.h:
1343         * WebCoreSupport/WebContextMenuClient.mm:
1344         * WebCoreSupport/WebDragClient.h:
1345         * WebCoreSupport/WebFrameLoaderClient.h:
1346         * WebCoreSupport/WebFrameLoaderClient.mm:
1347         (WebFrameLoaderClient::updateGlobalHistory):
1348         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1349         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1350         (WebPaymentCoordinatorClient::showPaymentUI):
1351         * WebCoreSupport/WebPlatformStrategies.h:
1352         * WebCoreSupport/WebPlatformStrategies.mm:
1353         (WebPlatformStrategies::readURLFromPasteboard):
1354         * WebCoreSupport/WebPluginInfoProvider.h:
1355         * WebCoreSupport/WebPluginInfoProvider.mm:
1356         (WebPluginInfoProvider::webVisiblePluginInfo):
1357         * WebCoreSupport/WebSecurityOrigin.mm:
1358         * WebCoreSupport/WebVisitedLinkStore.h:
1359         * WebView/WebDataSource.mm:
1360         * WebView/WebFrame.mm:
1361         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1362         * WebView/WebImmediateActionController.mm:
1363         (-[WebImmediateActionController _defaultAnimationController]):
1364         * WebView/WebPDFView.mm:
1365         * WebView/WebScriptDebugger.mm:
1366         * WebView/WebViewInternal.h:
1367
1368 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1369
1370         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1371         https://bugs.webkit.org/show_bug.cgi?id=192197
1372
1373         Reviewed by Jiewen Tan.
1374
1375         * Configurations/FeatureDefines.xcconfig:
1376         * WebCoreSupport/WebChromeClient.h:
1377         * WebCoreSupport/WebChromeClient.mm:
1378
1379 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1380
1381         Remove dead code from an earlier attempt at implementing safe browsing
1382         https://bugs.webkit.org/show_bug.cgi?id=192067
1383
1384         Reviewed by Chris Dumez.
1385
1386         * WebCoreSupport/WebFrameLoaderClient.h:
1387         * WebCoreSupport/WebFrameLoaderClient.mm:
1388         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1389
1390 2018-11-27  Mark Lam  <mark.lam@apple.com>
1391
1392         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1393         https://bugs.webkit.org/show_bug.cgi?id=192055
1394         <rdar://problem/46288783>
1395
1396         Reviewed by Saam Barati.
1397
1398         * Configurations/FeatureDefines.xcconfig:
1399
1400 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1401
1402         Make it possible to insert editable images with a gesture
1403         https://bugs.webkit.org/show_bug.cgi?id=191937
1404
1405         Reviewed by Wenson Hsieh.
1406
1407         * WebCoreSupport/WebEditorClient.mm:
1408         (undoNameForEditAction):
1409         Add a undo name.
1410
1411 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1412
1413         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1414         https://bugs.webkit.org/show_bug.cgi?id=191945
1415
1416         Reviewed by Anders Carlsson.
1417
1418         * WebCoreSupport/WebEditorClient.mm:
1419         (undoNameForEditAction):
1420
1421 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1422
1423         Enable drag and drop support for iOSMac
1424         https://bugs.webkit.org/show_bug.cgi?id=191818
1425         <rdar://problem/43907454>
1426
1427         Reviewed by Dean Jackson.
1428
1429         * Configurations/FeatureDefines.xcconfig:
1430
1431 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1432
1433         Address post-review feedback after r238438
1434         https://bugs.webkit.org/show_bug.cgi?id=191913
1435
1436         Reviewed by Ryosuke Niwa.
1437
1438         * WebView/WebFrame.mm:
1439         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1440         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1441         * WebView/WebView.mm:
1442         (-[WebView setSelectedDOMRange:affinity:]):
1443
1444 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1445
1446         Web Inspector: "Reload Web Inspector" button no longer partially works
1447         https://bugs.webkit.org/show_bug.cgi?id=191773
1448         <rdar://problem/46139932>
1449
1450         Reviewed by Devin Rousso.
1451
1452         * WebCoreSupport/WebInspectorClient.h:
1453         * WebCoreSupport/WebInspectorClient.mm:
1454         (WebInspectorFrontendClient::reopen):
1455
1456 2018-11-17  Devin Rousso  <drousso@apple.com>
1457
1458         Web Inspector: Network: add button to show system certificate dialog
1459         https://bugs.webkit.org/show_bug.cgi?id=191458
1460         <rdar://problem/45977019>
1461
1462         Reviewed by Joseph Pecoraro.
1463
1464         * WebCoreSupport/WebInspectorClient.h:
1465         * WebCoreSupport/WebInspectorClient.mm:
1466         (WebInspectorFrontendClient::showCertificate): Added.
1467
1468         * Configurations/WebKitLegacy.xcconfig:
1469
1470 2018-11-15  Truitt Savell  <tsavell@apple.com>
1471
1472         Unreviewed, rolling out r238244.
1473
1474         Caused High Sierra test runs to fail early with 50 crashes and
1475         casued 25 API failures.
1476
1477         Reverted changeset:
1478
1479         "[css-logical] Implement flow-relative margin, padding and
1480         border shorthands"
1481         https://bugs.webkit.org/show_bug.cgi?id=188697
1482         https://trac.webkit.org/changeset/238244
1483
1484 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1485
1486         [css-logical] Implement flow-relative margin, padding and border shorthands
1487         https://bugs.webkit.org/show_bug.cgi?id=188697
1488
1489         Reviewed by Simon Fraser and Antti Koivisto.
1490
1491         Add CSSLogicalEnabled runtime flag.
1492
1493         * WebView/WebPreferenceKeysPrivate.h:
1494         * WebView/WebPreferences.mm:
1495         (+[WebPreferences initialize]):
1496         (-[WebPreferences cssLogicalEnabled]):
1497         (-[WebPreferences setCSSLogicalEnabled:]):
1498         * WebView/WebPreferencesPrivate.h:
1499         * WebView/WebView.mm:
1500         (-[WebView _preferencesChanged:]):
1501
1502 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1503
1504         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1505         https://bugs.webkit.org/show_bug.cgi?id=191612
1506
1507         Reviewed by Matt Baker.
1508
1509         * WebCoreSupport/WebInspectorClient.mm:
1510         (-[WebInspectorWindowController destroyInspectorView]):
1511
1512 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1513
1514         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1515         https://bugs.webkit.org/show_bug.cgi?id=191494
1516         <rdar://problem/45469854>
1517
1518         Reviewed by Devin Rousso.
1519
1520         * WebCoreSupport/WebInspectorClient.h:
1521         WebKitLegacy will still have remote inspection of the Page directly.
1522
1523 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1524
1525         Make compositing updates incremental
1526         https://bugs.webkit.org/show_bug.cgi?id=90342
1527
1528         Reviewed by Antti Koivisto.
1529
1530         Fix spelling error.
1531
1532         * WebView/WebView.mm:
1533         (-[WebView _setMediaLayer:forPluginView:]):
1534
1535 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1536
1537         Implement a new edit command to change the enclosing list type
1538         https://bugs.webkit.org/show_bug.cgi?id=191487
1539         <rdar://problem/45955922>
1540
1541         Reviewed by Ryosuke Niwa.
1542
1543         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1544
1545         * WebCoreSupport/WebEditorClient.mm:
1546         (undoNameForEditAction):
1547
1548 2018-11-11  Daniel Bates  <dabates@apple.com>
1549
1550         [iOS] Draw caps lock indicator in password fields
1551         https://bugs.webkit.org/show_bug.cgi?id=190565
1552         <rdar://problem/45262343>
1553
1554         Reviewed by Dean Jackson.
1555
1556         Update the caps lock state when a hardware keyboard is attached or detached.
1557
1558         * WebView/WebHTMLView.mm:
1559         (hardwareKeyboardAvailabilityChangedCallback): Added.
1560         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1561         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1562
1563 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1564
1565         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1566         https://bugs.webkit.org/show_bug.cgi?id=191492
1567
1568         Reviewed by Alex Christensen.
1569
1570         * Carbon/HIWebView.mm:
1571         * Misc/WebNSFileManagerExtras.mm:
1572         * Misc/WebNSURLExtras.mm:
1573         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1574         * Plugins/WebBasePluginPackage.mm:
1575         * Plugins/WebPluginContainerCheck.mm:
1576         * WebCoreSupport/WebCachedFramePlatformData.h:
1577         * WebCoreSupport/WebDeviceOrientationClient.mm:
1578         * WebView/WebDelegateImplementationCaching.mm:
1579         * WebView/WebHTMLView.mm:
1580         * WebView/WebPDFRepresentation.mm:
1581         * WebView/WebPolicyDelegate.mm:
1582         * WebView/WebView.mm:
1583
1584 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1585
1586         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1587         https://bugs.webkit.org/show_bug.cgi?id=191492
1588
1589         Reviewed by Alex Christensen.
1590
1591         * Carbon/HIWebView.mm:
1592         (UpdateCommandStatus):
1593         * Misc/WebNSFileManagerExtras.mm:
1594         * Misc/WebNSURLExtras.mm:
1595         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1596         * Plugins/WebBasePluginPackage.mm:
1597         * Plugins/WebPluginContainerCheck.mm:
1598         (-[WebPluginContainerCheck _continueWithPolicy:]):
1599         * WebCoreSupport/WebCachedFramePlatformData.h:
1600         (WebCachedFramePlatformData::clear):
1601         * WebCoreSupport/WebDeviceOrientationClient.mm:
1602         (WebDeviceOrientationClient::getProvider const):
1603         * WebView/WebDelegateImplementationCaching.mm:
1604         (CallDelegate):
1605         (CallDelegateReturningBoolean):
1606         (CallResourceLoadDelegateReturningBoolean):
1607         (CallFormDelegate):
1608         (CallFormDelegateReturningBoolean):
1609         * WebView/WebHTMLView.mm:
1610         * WebView/WebPDFRepresentation.mm:
1611         * WebView/WebPolicyDelegate.mm:
1612         (-[WebPolicyDecisionListener _usePolicy:]):
1613         * WebView/WebView.mm:
1614
1615 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1616
1617         Unreviewed, rolling out r238047.
1618
1619         Introduced layout test failures on iOS simulator.
1620
1621         Reverted changeset:
1622
1623         "[iOS] Draw caps lock indicator in password fields"
1624         https://bugs.webkit.org/show_bug.cgi?id=190565
1625         https://trac.webkit.org/changeset/238047
1626
1627 2018-11-09  Antti Koivisto  <antti@apple.com>
1628
1629         Use OptionSet for layout milestones
1630         https://bugs.webkit.org/show_bug.cgi?id=191470
1631
1632         Reviewed by Dean Jackson.
1633
1634         * WebCoreSupport/WebFrameLoaderClient.h:
1635         * WebCoreSupport/WebFrameLoaderClient.mm:
1636         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1637         * WebView/WebView.mm:
1638         (coreLayoutMilestones):
1639         (kitLayoutMilestones):
1640         (-[WebView _cacheFrameLoadDelegateImplementations]):
1641         * WebView/WebViewInternal.h:
1642
1643 2018-11-09  Daniel Bates  <dabates@apple.com>
1644
1645         [iOS] Draw caps lock indicator in password fields
1646         https://bugs.webkit.org/show_bug.cgi?id=190565
1647         <rdar://problem/45262343>
1648
1649         Reviewed by Dean Jackson.
1650
1651         Update the caps lock state when a hardware keyboard is attached or detached.
1652
1653         * WebView/WebHTMLView.mm:
1654         (hardwareKeyboardAvailabilityChangedCallback): Added.
1655         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1656         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1657
1658 2018-11-09  Daniel Bates  <dabates@apple.com>
1659
1660         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1661         action when forward delete is pressed outside a text field
1662         https://bugs.webkit.org/show_bug.cgi?id=190566
1663         <rdar://problem/45262367>
1664
1665         Reviewed by Wenson Hsieh.
1666
1667         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1668         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1669         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1670
1671         * WebView/WebHTMLView.mm:
1672         (-[WebHTMLView _handleEditingKeyEvent:]):
1673
1674 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1675
1676         Adopt Reveal Framework to replace Lookup
1677         https://bugs.webkit.org/show_bug.cgi?id=191097
1678         <rdar://problem/45924508>
1679
1680         Reviewed by Tim Horton.
1681
1682         Pass in what it needed to clear the textIndicators. This is better than
1683         the current notification structure.
1684
1685         * WebView/WebView.mm:
1686         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1687         (-[WebView _prepareForDictionaryLookup]):
1688
1689 2018-11-06  Justin Fan  <justin_fan@apple.com>
1690
1691         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1692         https://bugs.webkit.org/show_bug.cgi?id=191291
1693
1694         Reviewed by Myles Maxfield.
1695
1696         Properly disable WEBGPU on all non-Metal platforms for now.
1697
1698         * Configurations/FeatureDefines.xcconfig:
1699
1700 2018-11-02  Daniel Bates  <dabates@apple.com>
1701
1702         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1703         https://bugs.webkit.org/show_bug.cgi?id=190487
1704
1705         Reviewed by Tim Horton.
1706
1707         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1708         allow the default handling.
1709
1710         * WebView/WebHTMLView.mm:
1711         (-[WebHTMLView _handleEditingKeyEvent:]):
1712
1713 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1714
1715         Add a storage limit for IndexedDB
1716         https://bugs.webkit.org/show_bug.cgi?id=190598
1717         <rdar://problem/44654715>
1718
1719         Reviewed by Chris Dumez.
1720
1721         * Storage/WebDatabaseManager.mm:
1722         (-[WebDatabaseManager setIDBPerOriginQuota:]):
1723         * Storage/WebDatabaseManagerPrivate.h:
1724
1725 2018-10-31  Antti Koivisto  <antti@apple.com>
1726
1727         Remove LayerFlushScheduler
1728         https://bugs.webkit.org/show_bug.cgi?id=191103
1729
1730         Reviewed by Anders Carlsson.
1731
1732         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
1733         all the virtual cruft.
1734
1735         * WebView/WebViewData.h:
1736         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
1737         (): Deleted.
1738         * WebView/WebViewData.mm:
1739         (currentRunLoop):
1740         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
1741         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
1742         (WebViewLayerFlushScheduler::schedule):
1743         (WebViewLayerFlushScheduler::invalidate):
1744         (WebViewLayerFlushScheduler::layerFlushCallback):
1745
1746 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1747
1748         Enable InstallAPI for iOS unconditionally
1749         https://bugs.webkit.org/show_bug.cgi?id=191043
1750         rdar://problem/32728423
1751
1752         Reviewed by Dan Bernstein.
1753
1754         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1755         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1756         shouldn't be processed by InstallAPI.
1757         * MigrateHeaders.make: Removed an obsolete workaround.
1758         * Misc/NSURLDownloadSPI.h: Added.
1759         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1760
1761 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1762
1763         Clean up some obsolete MAX_ALLOWED macros
1764         https://bugs.webkit.org/show_bug.cgi?id=190916
1765
1766         Reviewed by Tim Horton.
1767
1768         * WebView/WebHTMLView.mm:
1769         (-[WebHTMLView pressureChangeWithEvent:]):
1770         * WebView/WebPDFView.h:
1771
1772 2018-10-30  Commit Queue  <commit-queue@webkit.org>
1773
1774         Unreviewed, rolling out r237600 and r237604.
1775         https://bugs.webkit.org/show_bug.cgi?id=191086
1776
1777         Breaks internal iOS builds (Requested by ryanhadd_ on
1778         #webkit).
1779
1780         Reverted changesets:
1781
1782         "Enable InstallAPI for iOS unconditionally"
1783         https://bugs.webkit.org/show_bug.cgi?id=191043
1784         https://trac.webkit.org/changeset/237600
1785
1786         "Build fix attempt after enabling InstallAPI for iOS."
1787         https://bugs.webkit.org/show_bug.cgi?id=191043
1788         https://trac.webkit.org/changeset/237604
1789
1790 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1791
1792         Enable InstallAPI for iOS unconditionally
1793         https://bugs.webkit.org/show_bug.cgi?id=191043
1794         rdar://problem/32728423
1795
1796         Reviewed by Dan Bernstein.
1797
1798         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
1799         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
1800         shouldn't be processed by InstallAPI.
1801         * MigrateHeaders.make: Removed an obsolete workaround.
1802         * Misc/NSURLDownloadSPI.h: Added.
1803         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
1804
1805 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1806
1807         Modernize WebKit nibs and lprojs for localization's sake
1808         https://bugs.webkit.org/show_bug.cgi?id=190911
1809         <rdar://problem/45349466>
1810
1811         Reviewed by Dan Bernstein.
1812
1813         * Misc/WebNSControlExtras.m:
1814         (-[NSControl sizeToFitAndAdjustWindowHeight]):
1815         NSWindow and its contents are both in the same scale space these days; avoid
1816         double-applying the scale factor, or you can't see the prompt.
1817
1818         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
1819         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
1820         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
1821         NIB->XIB
1822
1823 2018-10-25  Antoine Quint  <graouts@apple.com>
1824
1825         [Web Animations] Turn Web Animations CSS Integration off by default
1826         https://bugs.webkit.org/show_bug.cgi?id=190901
1827
1828         Reviewed by Dean Jackson.
1829
1830         * WebView/WebPreferences.mm:
1831         (+[WebPreferences initialize]):
1832
1833 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1834
1835         Clean up some obsolete macOS version guards
1836         https://bugs.webkit.org/show_bug.cgi?id=190887
1837
1838         Reviewed by Dan Bernstein.
1839
1840         * Misc/WebNSPasteboardExtras.mm:
1841         (+[NSPasteboard _web_dragTypesForURL]):
1842         * WebCoreSupport/PopupMenuMac.mm:
1843         (PopupMenuMac::show):
1844         * WebCoreSupport/WebEditorClient.h:
1845         * WebCoreSupport/WebEditorClient.mm:
1846         (WebEditorClient::respondToChangedSelection):
1847         * WebView/WebPDFView.mm:
1848         (-[WebPDFView _clipViewForPDFDocumentView]):
1849
1850 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1851
1852         Turn on Conic Gradients
1853         https://bugs.webkit.org/show_bug.cgi?id=190810
1854
1855         Reviewed by Tim Horton.
1856
1857         * Configurations/FeatureDefines.xcconfig:
1858
1859 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
1860
1861         Cleanup: MIMETypeRegistry functions
1862         https://bugs.webkit.org/show_bug.cgi?id=190838
1863
1864         Reviewed by Simon Fraser.
1865
1866         * Misc/WebNSPasteboardExtras.mm:
1867         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
1868         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
1869         because they were identical.
1870
1871         * WebView/WebHTMLRepresentation.mm:
1872         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
1873         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
1874         (+[WebHTMLRepresentation supportedImageMIMETypes]):
1875         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
1876         * WebView/WebView.mm:
1877         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
1878         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
1879         (+[WebView registerViewClass:representationClass:forMIMEType:]):
1880
1881 2018-10-23  David Kilzer  <ddkilzer@apple.com>
1882
1883         Fix false positive leaks when using custom -init methods that don't start with -init
1884         <https://webkit.org/b/190818>
1885         <rdar://problem/45476042>
1886
1887         Reviewed by Dan Bernstein.
1888
1889         * Misc/WebKitErrors.m: Move `descriptions` static global so that
1890         it is accessible by both categories.
1891         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
1892         NSError (WebKitInternal) category.  Add attribute to make this
1893         behave like an -init method.
1894         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
1895         NSError (WebKitInternal) category.  Modernize method.  Replace
1896         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
1897
1898 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
1899
1900         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
1901         https://bugs.webkit.org/show_bug.cgi?id=190729
1902
1903         Reviewed by Tim Horton.
1904
1905         * DOM/DOM.mm:
1906         (-[DOMNode boundingBox]):
1907         * DOM/DOMElement.mm:
1908         * DOM/DOMHTML.mm:
1909         * DOM/DOMInternal.mm:
1910         * DOM/DOMUIKitExtensions.mm:
1911         * DOM/WebDOMOperations.mm:
1912         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1913         * DefaultDelegates/WebDefaultEditingDelegate.m:
1914         * DefaultDelegates/WebDefaultPolicyDelegate.m:
1915         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1916         * DefaultDelegates/WebDefaultUIDelegate.h:
1917         * DefaultDelegates/WebDefaultUIDelegate.mm:
1918         (-[WebDefaultUIDelegate webViewClose:]):
1919         (-[WebDefaultUIDelegate webViewFocus:]):
1920         (-[WebDefaultUIDelegate webViewUnfocus:]):
1921         (-[WebDefaultUIDelegate webViewIsResizable:]):
1922         (-[WebDefaultUIDelegate webView:setResizable:]):
1923         (-[WebDefaultUIDelegate webView:setFrame:]):
1924         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1925         * History/BackForwardList.h:
1926         * History/BackForwardList.mm:
1927         * History/WebBackForwardList.mm:
1928         (+[WebBackForwardList initialize]):
1929         (bumperCarBackForwardHackNeeded):
1930         * History/WebHistory.mm:
1931         (-[WebHistoryPrivate addItem:discardDuplicate:]):
1932         (-[WebHistory _sendNotification:entries:]):
1933         (-[WebHistory loadFromURL:error:]):
1934         (-[WebHistory saveToURL:error:]):
1935         * History/WebHistoryItem.mm:
1936         (WKNotifyHistoryItemChanged):
1937         (+[WebHistoryItem initialize]):
1938         (-[WebHistoryItem initFromDictionaryRepresentation:]):
1939         * History/WebURLsWithTitles.m:
1940         * Misc/WebCache.mm:
1941         (+[WebCache initialize]):
1942         * Misc/WebDownload.mm:
1943         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1944         * Misc/WebElementDictionary.mm:
1945         (+[WebElementDictionary initialize]):
1946         (+[WebElementDictionary initializeLookupTable]):
1947         * Misc/WebIconDatabase.mm:
1948         * Misc/WebKitNSStringExtras.mm:
1949         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
1950         * Misc/WebKitVersionChecks.h:
1951         * Misc/WebKitVersionChecks.mm:
1952         (WebKitLinkedOnOrAfter):
1953         (WebKitLinkTimeVersion):
1954         * Misc/WebLocalizableStrings.mm:
1955         * Misc/WebNSControlExtras.h:
1956         * Misc/WebNSControlExtras.m:
1957         * Misc/WebNSEventExtras.m:
1958         * Misc/WebNSFileManagerExtras.mm:
1959         * Misc/WebNSImageExtras.h:
1960         * Misc/WebNSImageExtras.m:
1961         * Misc/WebNSPasteboardExtras.mm:
1962         * Misc/WebNSPrintOperationExtras.h:
1963         * Misc/WebNSPrintOperationExtras.m:
1964         * Misc/WebNSViewExtras.m:
1965         * Misc/WebNSWindowExtras.m:
1966         * Panels/WebAuthenticationPanel.h:
1967         * Panels/WebAuthenticationPanel.m:
1968         * Panels/WebPanelAuthenticationHandler.m:
1969         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1970         (+[WebHostedNetscapePluginView initialize]):
1971         * Plugins/WebBasePluginPackage.h:
1972         * Plugins/WebBasePluginPackage.mm:
1973         * Plugins/WebJavaPlugIn.h:
1974         * Plugins/WebPluginContainerCheck.mm:
1975         * Plugins/WebPluginController.h:
1976         * Plugins/WebPluginController.mm:
1977         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
1978         (-[WebPluginController addPlugin:]):
1979         (-[WebPluginController destroyPlugin:]):
1980         (-[WebPluginController destroyAllPlugins]):
1981         * Plugins/WebPluginDatabase.mm:
1982         (+[WebPluginDatabase _defaultPlugInPaths]):
1983         * Plugins/WebPluginPackage.mm:
1984         (-[WebPluginPackage initWithPath:]):
1985         * Storage/WebDatabaseManager.mm:
1986         (-[WebDatabaseManager deleteAllDatabases]):
1987         * Storage/WebDatabaseManagerClient.h:
1988         * Storage/WebDatabaseManagerClient.mm:
1989         (WebDatabaseManagerClient::WebDatabaseManagerClient):
1990         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
1991         * Storage/WebStorageManager.mm:
1992         (-[WebStorageManager deleteAllOrigins]):
1993         (WebKitInitializeStorageIfNecessary):
1994         * WebCoreSupport/WebAlternativeTextClient.h:
1995         * WebCoreSupport/WebApplicationCache.mm:
1996         (applicationCacheBundleIdentifier):
1997         * WebCoreSupport/WebChromeClient.h:
1998         * WebCoreSupport/WebChromeClient.mm:
1999         (WebChromeClient::setWindowRect):
2000         (WebChromeClient::windowRect):
2001         (WebChromeClient::takeFocus):
2002         (WebChromeClient::addMessageToConsole):
2003         (WebChromeClient::enableSuddenTermination):
2004         (WebChromeClient::disableSuddenTermination):
2005         (WebChromeClient::createPopupMenu const):
2006         (WebChromeClient::createSearchPopupMenu const):
2007         (WebChromeClient::shouldPaintEntireContents const):
2008         (WebChromeClient::supportsVideoFullscreen):
2009         (WebChromeClient::supportsFullScreenForElement):
2010         (WebChromeClient::enterFullScreenForElement):
2011         (WebChromeClient::exitFullScreenForElement):
2012         * WebCoreSupport/WebContextMenuClient.mm:
2013         * WebCoreSupport/WebDragClient.mm:
2014         * WebCoreSupport/WebEditorClient.h:
2015         * WebCoreSupport/WebEditorClient.mm:
2016         (+[WebUndoStep initialize]):
2017         (updateFontPanel):
2018         (WebEditorClient::didBeginEditing):
2019         (WebEditorClient::respondToChangedContents):
2020         (WebEditorClient::respondToChangedSelection):
2021         (WebEditorClient::canceledComposition):
2022         (WebEditorClient::didEndEditing):
2023         (WebEditorClient::didWriteSelectionToPasteboard):
2024         (attributesForAttributedStringConversion):
2025         (WebEditorClient::setInsertionPasteboard):
2026         (WebEditorClient::registerUndoOrRedoStep):
2027         (WebEditorClient::handleKeyboardEvent):
2028         (WebEditorClient::handleInputMethodKeydown):
2029         (WebEditorClient::textDidChangeInTextField):
2030         (WebEditorClient::requestCheckingOfString):
2031         * WebCoreSupport/WebFrameLoaderClient.h:
2032         * WebCoreSupport/WebFrameLoaderClient.mm:
2033         (WebFrameLoaderClient::detachedFromParent2):
2034         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2035         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2036         (WebFrameLoaderClient::dispatchWillSendRequest):
2037         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2038         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2039         (WebFrameLoaderClient::willCacheResponse const):
2040         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2041         (WebFrameLoaderClient::dispatchDidFinishLoading):
2042         (WebFrameLoaderClient::dispatchDidFailLoading):
2043         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2044         (WebFrameLoaderClient::dispatchWillClose):
2045         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2046         (WebFrameLoaderClient::dispatchDidCommitLoad):
2047         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2048         (WebFrameLoaderClient::dispatchDidFailLoad):
2049         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2050         (WebFrameLoaderClient::dispatchDidFinishLoad):
2051         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2052         (WebFrameLoaderClient::willChangeTitle):
2053         (WebFrameLoaderClient::didChangeTitle):
2054         (WebFrameLoaderClient::didReplaceMultipartContent):
2055         (WebFrameLoaderClient::updateGlobalHistory):
2056         (WebFrameLoaderClient::saveViewStateToItem):
2057         (WebFrameLoaderClient::restoreViewState):
2058         (WebFrameLoaderClient::provisionalLoadStarted):
2059         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2060         (WebFrameLoaderClient::setTitle):
2061         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2062         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2063         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2064         (WebFrameLoaderClient::didRestoreFromPageCache):
2065         (WebFrameLoaderClient::actionDictionary const):
2066         (WebFrameLoaderClient::createPlugin):
2067         (WebFrameLoaderClient::getLoadDecisionForIcons):
2068         (WebFrameLoaderClient::finishedLoadingIcon):
2069         (+[WebFramePolicyListener initialize]):
2070         * WebCoreSupport/WebFrameNetworkingContext.mm:
2071         * WebCoreSupport/WebGeolocationClient.h:
2072         * WebCoreSupport/WebGeolocationClient.mm:
2073         (WebGeolocationClient::requestPermission):
2074         * WebCoreSupport/WebInspectorClient.h:
2075         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2076         * WebCoreSupport/WebNotificationClient.mm:
2077         * WebCoreSupport/WebOpenPanelResultListener.mm:
2078         * WebCoreSupport/WebPlatformStrategies.h:
2079         * WebCoreSupport/WebPlatformStrategies.mm:
2080         * WebCoreSupport/WebProgressTrackerClient.h:
2081         * WebCoreSupport/WebProgressTrackerClient.mm:
2082         (WebProgressTrackerClient::progressStarted):
2083         (WebProgressTrackerClient::progressEstimateChanged):
2084         (WebProgressTrackerClient::progressFinished):
2085         * WebCoreSupport/WebSecurityOrigin.mm:
2086         * WebInspector/WebNodeHighlight.h:
2087         * WebInspector/WebNodeHighlight.mm:
2088         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2089         (-[WebNodeHighlight dealloc]):
2090         (-[WebNodeHighlight attach]):
2091         * WebInspector/WebNodeHighlightView.h:
2092         * WebInspector/WebNodeHighlightView.mm:
2093         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2094         (-[WebNodeHighlightView dealloc]):
2095         * WebInspector/WebNodeHighlighter.mm:
2096         (-[WebNodeHighlighter highlight]):
2097         * WebView/WebArchive.mm:
2098         (+[WebArchivePrivate initialize]):
2099         * WebView/WebClipView.h:
2100         * WebView/WebDataSource.mm:
2101         (WebDataSourcePrivate::WebDataSourcePrivate):
2102         (+[WebDataSource initialize]):
2103         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2104         (-[WebDataSource _makeRepresentation]):
2105         * WebView/WebDelegateImplementationCaching.h:
2106         * WebView/WebDelegateImplementationCaching.mm:
2107         (CallDelegate):
2108         (CallDelegateReturningFloat):
2109         (CallDelegateReturningBoolean):
2110         (CallUIDelegate):
2111         (CallUIDelegateReturningFloat):
2112         (CallUIDelegateReturningBoolean):
2113         (CallFrameLoadDelegate):
2114         (CallFrameLoadDelegateReturningBoolean):
2115         (CallResourceLoadDelegate):
2116         (CallScriptDebugDelegate):
2117         (CallFormDelegate):
2118         (CallFormDelegateReturningBoolean):
2119         * WebView/WebDeviceOrientation.mm:
2120         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2121         * WebView/WebDocumentInternal.h:
2122         * WebView/WebDocumentLoaderMac.mm:
2123         (needsDataLoadWorkaround):
2124         * WebView/WebDynamicScrollBarsViewInternal.h:
2125         * WebView/WebFormDelegate.m:
2126         * WebView/WebFrame.mm:
2127         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2128         (-[WebFrame _unmarkAllMisspellings]):
2129         (-[WebFrame _paintBehaviorForDestinationContext:]):
2130         (-[WebFrame _drawRect:contentsOnly:]):
2131         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2132         (-[WebFrame _scrollDOMRangeToVisible:]):
2133         (-[WebFrame _bodyBackgroundColor]):
2134         (-[WebFrame accessibilityRoot]):
2135         (needsMicrosoftMessengerDOMDocumentWorkaround):
2136         * WebView/WebFrameInternal.h:
2137         * WebView/WebFrameView.mm:
2138         (-[WebFrameView _setDocumentView:]):
2139         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2140         (-[WebFrameView _viewClassForMIMEType:]):
2141         (-[WebFrameView initWithFrame:]):
2142         (-[WebFrameView drawRect:]):
2143         (-[WebFrameView _firstResponderIsFormControl]):
2144         (-[WebFrameView keyDown:keyDown:]):
2145         (-[WebFrameView _isScrollable]):
2146         * WebView/WebFullScreenController.h:
2147         * WebView/WebFullScreenController.mm:
2148         * WebView/WebHTMLRepresentation.mm:
2149         * WebView/WebHTMLView.mm:
2150         (-[WebHTMLView hitTest:]):
2151         (-[WebHTMLView initWithFrame:]):
2152         (-[WebHTMLView dealloc]):
2153         (-[WebHTMLView addSubview:]):
2154         (-[WebHTMLView mouseDown:]):
2155         (-[WebHTMLView mouseUp:]):
2156         (-[WebHTMLView resignFirstResponder]):
2157         (-[WebHTMLView accessibilityHitTest:]):
2158         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2159         * WebView/WebHTMLViewInternal.h:
2160         * WebView/WebIndicateLayer.h:
2161         * WebView/WebIndicateLayer.mm:
2162         * WebView/WebMediaPlaybackTargetPicker.h:
2163         * WebView/WebMediaPlaybackTargetPicker.mm:
2164         * WebView/WebPDFDocumentExtras.h:
2165         * WebView/WebPDFDocumentExtras.mm:
2166         * WebView/WebPDFRepresentation.h:
2167         * WebView/WebPDFRepresentation.mm:
2168         * WebView/WebPDFView.h:
2169         * WebView/WebPreferences.mm:
2170         (cacheModelForMainBundle):
2171         (WebPreferencesPrivate::WebPreferencesPrivate):
2172         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2173         (-[WebPreferences encodeWithCoder:]):
2174         (+[WebPreferences standardPreferences]):
2175         (+[WebPreferences initialize]):
2176         (-[WebPreferences _valueForKey:]):
2177         (-[WebPreferences _setStringValue:forKey:]):
2178         (-[WebPreferences _setIntegerValue:forKey:]):
2179         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2180         (-[WebPreferences _setFloatValue:forKey:]):
2181         (-[WebPreferences _setBoolValue:forKey:]):
2182         (-[WebPreferences _setLongLongValue:forKey:]):
2183         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2184         (-[WebPreferences _postCacheModelChangedNotification]):
2185         (-[WebPreferences _postPreferencesChangedNotification]):
2186         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2187         (-[WebPreferences setStorageBlockingPolicy:]):
2188         * WebView/WebResource.mm:
2189         (+[WebResourcePrivate initialize]):
2190         * WebView/WebTextCompletionController.h:
2191         * WebView/WebTextIterator.mm:
2192         (+[WebTextIteratorPrivate initialize]):
2193         * WebView/WebView.mm:
2194         (shouldEnableLoadDeferring):
2195         (shouldRestrictWindowFocus):
2196         (shouldRespectPriorityInCSSAttributeSetters):
2197         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2198         (shouldAllowPictureInPictureMediaPlayback):
2199         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2200         (shouldAllowWindowOpenWithoutUserGesture):
2201         (shouldConvertInvalidURLsToBlank):
2202         (shouldRequireUserGestureToLoadVideo):
2203         (-[WebView _commonInitializationWithFrameName:groupName:]):
2204         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2205         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2206         (-[WebView _closePluginDatabases]):
2207         (-[WebView _closeWithFastTeardown]):
2208         (-[WebView _close]):
2209         (+[WebView _MIMETypeForFile:]):
2210         (-[WebView setShowingInspectorIndication:]):
2211         (-[WebView _setFormDelegate:]):
2212         (-[WebView _needsPreHTML5ParserQuirks]):
2213         (-[WebView _preferencesChangedNotification:]):
2214         (-[WebView _preferencesChanged:]):
2215         (-[WebView _cacheResourceLoadDelegateImplementations]):
2216         (-[WebView _cacheFrameLoadDelegateImplementations]):
2217         (-[WebView _policyDelegateForwarder]):
2218         (-[WebView _UIDelegateForwarder]):
2219         (-[WebView _editingDelegateForwarder]):
2220         (-[WebView _updateActiveState]):
2221         (-[_WebSafeForwarder forwardInvocation:]):
2222         (+[WebView initialize]):
2223         (-[WebView _pluginForMIMEType:]):
2224         (-[WebView _pluginForExtension:]):
2225         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2226         (+[WebView canShowMIMETypeAsHTML:]):
2227         (-[WebView _initWithArguments:]):
2228         (-[WebView initWithFrame:frameName:groupName:]):
2229         (-[WebView dealloc]):
2230         (-[WebView close]):
2231         (-[WebView viewDidMoveToWindow]):
2232         (-[WebView setUIDelegate:]):
2233         (-[WebView setResourceLoadDelegate:]):
2234         (-[WebView setPolicyDelegate:]):
2235         (-[WebView setFrameLoadDelegate:]):
2236         (-[WebView goBack]):
2237         (-[WebView goForward]):
2238         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2239         (-[WebView setHostWindow:]):
2240         (-[WebView becomeFirstResponder]):
2241         (+[WebView _cacheModelChangedNotification:]):
2242         (-[WebView _frameViewAtWindowPoint:]):
2243         (+[WebView _preflightSpellCheckerNow:]):
2244         (+[WebView _preflightSpellChecker]):
2245         (-[WebView canGoBack]):
2246         (-[WebView canGoForward]):
2247         (-[WebView stopLoading:]):
2248         (-[WebView reload:]):
2249         (-[WebView setMainFrameDocumentReady:]):
2250         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2251         (-[WebView setContinuousSpellCheckingEnabled:]):
2252         (-[WebView undoManager]):
2253         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2254         (-[WebView isAutomaticLinkDetectionEnabled]):
2255         (-[WebView isAutomaticDashSubstitutionEnabled]):
2256         (-[WebView isAutomaticTextReplacementEnabled]):
2257         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2258         (+[WebView _setCacheModel:]):
2259         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2260         (-[WebView _keyboardUIMode]):
2261         (LayerFlushController::flushLayers):
2262         (-[WebView _scheduleCompositingLayerFlush]):
2263         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2264         (-[WebView fullScreenPlaceholderView]):
2265         (WebInstallMemoryPressureHandler):
2266         * WebView/WebViewData.h:
2267         * WebView/WebViewData.mm:
2268         (+[WebViewPrivate initialize]):
2269         (-[WebViewPrivate init]):
2270         (-[WebViewPrivate dealloc]):
2271         * WebView/WebViewInternal.h:
2272
2273 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2274
2275         Clean up FrameLoader two-state enums
2276         https://bugs.webkit.org/show_bug.cgi?id=190731
2277
2278         Reviewed by Chris Dumez.
2279
2280         * WebCoreSupport/WebFrameLoaderClient.h:
2281         * WebCoreSupport/WebFrameLoaderClient.mm:
2282         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2283
2284 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2285
2286         Unreviewed, rolling out r237137.
2287
2288         SPI is actually used
2289
2290         Reverted changeset:
2291
2292         "Remove unused WebFrame._loadType"
2293         https://bugs.webkit.org/show_bug.cgi?id=190583
2294         https://trac.webkit.org/changeset/237137
2295
2296 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2297
2298         Enable the datalist element by default on iOS and macOS
2299         https://bugs.webkit.org/show_bug.cgi?id=190594
2300         <rdar://problem/45281159>
2301
2302         Reviewed by Ryosuke Niwa and Tim Horton.
2303
2304         * Configurations/FeatureDefines.xcconfig:
2305
2306 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2307
2308         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2309         https://bugs.webkit.org/show_bug.cgi?id=190675
2310
2311         Reviewed by Chris Dumez.
2312
2313         * History/BackForwardList.h:
2314         * History/BackForwardList.mm:
2315         (BackForwardList::backItem):
2316         (BackForwardList::currentItem):
2317         (BackForwardList::forwardItem):
2318         (BackForwardList::backListCount const):
2319         (BackForwardList::forwardListCount const):
2320         (BackForwardList::itemAtIndex):
2321         * History/WebBackForwardList.mm:
2322         (-[WebBackForwardList backItem]):
2323         (-[WebBackForwardList currentItem]):
2324         (-[WebBackForwardList forwardItem]):
2325         (-[WebBackForwardList itemAtIndex:]):
2326
2327 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2328
2329         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2330         https://bugs.webkit.org/show_bug.cgi?id=190526
2331         rdar://problem/45230140
2332
2333         Reviewed by Dean Jackson.
2334
2335         * WebCoreSupport/WebEditorClient.mm:
2336         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2337
2338 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2339
2340         Implement feature flag and bindings for CSS Painting API
2341         https://bugs.webkit.org/show_bug.cgi?id=190237
2342
2343         Reviewed by Ryosuke Niwa.
2344
2345         * Configurations/FeatureDefines.xcconfig:
2346
2347 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2348
2349         Replace HistoryItem* with HistoryItem& where possible
2350         https://bugs.webkit.org/show_bug.cgi?id=190617
2351
2352         Reviewed by Chris Dumez.
2353
2354         * History/BackForwardList.h:
2355         * History/BackForwardList.mm:
2356         (BackForwardList::goToItem):
2357         * History/WebBackForwardList.mm:
2358         (-[WebBackForwardList goToItem:]):
2359         * History/WebHistoryItem.mm:
2360         (WKNotifyHistoryItemChanged):
2361         * History/WebHistoryItemInternal.h:
2362
2363 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2364
2365         Remove unused WebHistoryItem._transientPropertyForKey
2366         https://bugs.webkit.org/show_bug.cgi?id=190606
2367
2368         Reviewed by Chris Dumez.
2369
2370         * History/WebHistoryItem.mm:
2371         * History/WebHistoryItemPrivate.h:
2372
2373 2018-10-15  Justin Fan  <justin_fan@apple.com>
2374
2375         Add WebGPU 2018 feature flag and experimental feature flag
2376         https://bugs.webkit.org/show_bug.cgi?id=190509
2377
2378         Reviewed by Dean Jackson.
2379
2380         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2381         for the 2018 WebGPU prototype.
2382
2383         * Configurations/FeatureDefines.xcconfig:
2384         * WebView/WebPreferenceKeysPrivate.h:
2385         * WebView/WebPreferences.mm:
2386         (+[WebPreferences initialize]):
2387         (-[WebPreferences webGPUEnabled]):
2388         (-[WebPreferences setWebGPUEnabled:]):
2389         * WebView/WebPreferencesPrivate.h:
2390         * WebView/WebView.mm:
2391         (-[WebView _preferencesChanged:]):
2392
2393 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2394
2395         Fix iOS build after r237157
2396
2397         * WebView/WebView.mm:
2398         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2399
2400 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2401
2402         Modernize BackForwardClient.h
2403         https://bugs.webkit.org/show_bug.cgi?id=190610
2404
2405         Reviewed by Chris Dumez.
2406
2407         * History/BackForwardList.h:
2408         * History/BackForwardList.mm:
2409         (BackForwardList::backListCount const):
2410         (BackForwardList::forwardListCount const):
2411         (BackForwardList::backListCount): Deleted.
2412         (BackForwardList::forwardListCount): Deleted.
2413         * History/WebBackForwardList.mm:
2414         (-[WebBackForwardList init]):
2415         * WebCoreSupport/WebFrameLoaderClient.mm:
2416         (WebFrameLoaderClient::canCachePage const):
2417         * WebView/WebFrameView.mm:
2418         (-[WebFrameView keyDown:keyDown:]):
2419         * WebView/WebView.mm:
2420         (-[WebView _commonInitializationWithFrameName:groupName:]):
2421         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2422         (-[WebView _loadBackForwardListFromOtherView:]):
2423         (-[WebView initWithCoder:]):
2424         (-[WebView encodeWithCoder:]):
2425         (-[WebView backForwardList]):
2426         (-[WebView setMaintainsBackForwardList:]):
2427
2428 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2429
2430         Add support for prefers-color-scheme media query
2431         https://bugs.webkit.org/show_bug.cgi?id=190499
2432         rdar://problem/45212025
2433
2434         Reviewed by Dean Jackson.
2435
2436         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2437
2438 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2439
2440         Remove unused WebView._globalHistoryItem
2441         https://bugs.webkit.org/show_bug.cgi?id=190601
2442
2443         Reviewed by Chris Dumez.
2444
2445         * WebCoreSupport/WebFrameLoaderClient.h:
2446         * WebCoreSupport/WebFrameLoaderClient.mm:
2447         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2448         * WebView/WebView.mm:
2449         (-[WebView _globalHistoryItem]): Deleted.
2450         (-[WebView _setGlobalHistoryItem:]): Deleted.
2451         * WebView/WebViewData.h:
2452         * WebView/WebViewInternal.h:
2453         * WebView/WebViewPrivate.h:
2454
2455 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2456
2457         Remove unused parameters from FrameLoaderClient::createFrame
2458         https://bugs.webkit.org/show_bug.cgi?id=190587
2459
2460         Reviewed by Chris Dumez.
2461
2462         * WebCoreSupport/WebFrameLoaderClient.h:
2463         * WebCoreSupport/WebFrameLoaderClient.mm:
2464         (WebFrameLoaderClient::createFrame):
2465
2466 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2467
2468         Remove unused WebFrame._loadType
2469         https://bugs.webkit.org/show_bug.cgi?id=190583
2470
2471         Reviewed by Chris Dumez.
2472
2473         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2474
2475         * WebView/WebFrame.mm:
2476         (toWebFrameLoadType): Deleted.
2477         (-[WebFrame _loadType]): Deleted.
2478         * WebView/WebFramePrivate.h:
2479
2480 2018-10-15  Chris Dumez  <cdumez@apple.com>
2481
2482         Restrict browsing context lookup by name to frames that are related to one another
2483         https://bugs.webkit.org/show_bug.cgi?id=190475
2484
2485         Reviewed by Alex Christensen.
2486
2487         * WebView/WebFrame.mm:
2488         (-[WebFrame findFrameNamed:]):
2489
2490 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2491
2492         Remove InjectedBundle processing of back/forward lists
2493         https://bugs.webkit.org/show_bug.cgi?id=190459
2494
2495         Reviewed by Chris Dumez.
2496
2497         * WebCoreSupport/WebFrameLoaderClient.h:
2498         * WebCoreSupport/WebFrameLoaderClient.mm:
2499         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2500
2501 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2502
2503         [JSC] Remove Option::useAsyncIterator
2504         https://bugs.webkit.org/show_bug.cgi?id=190567
2505
2506         Reviewed by Saam Barati.
2507
2508         * Configurations/FeatureDefines.xcconfig:
2509
2510 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2511
2512         Allow encoding of small enum classes
2513         https://bugs.webkit.org/show_bug.cgi?id=190531
2514
2515         Reviewed by Tim Horton.
2516
2517         * WebCoreSupport/WebFrameLoaderClient.mm:
2518         (-[WebFramePolicyListener dealloc]):
2519
2520 2018-10-11  Keith Rollin  <krollin@apple.com>
2521
2522         CURRENT_ARCH should not be used in Run Script phase.
2523         https://bugs.webkit.org/show_bug.cgi?id=190407
2524         <rdar://problem/45133556>
2525
2526         Reviewed by Alexey Proskuryakov.
2527
2528         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2529         CURRENT_ARCH is not well-defined during this phase (and may even have
2530         the value "undefined") since this phase is run just once per build
2531         rather than once per supported architecture. Migrate away from
2532         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2533         performing an operation for each value, or by picking the first entry
2534         in ARCHS and using that as a representative value.
2535
2536         * Configurations/WebKitLegacy.xcconfig: When generating
2537         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2538         macosx platforms.
2539
2540         * MigrateHeaders.make:
2541         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2542         generate one for each architecture in ARCHS.
2543
2544 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2545
2546         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2547         https://bugs.webkit.org/show_bug.cgi?id=190429
2548
2549         Reviewed by Saam Barati.
2550
2551         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2552
2553         * WebView/WebPDFRepresentation.mm:
2554         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2555
2556 2018-10-08  Justin Fan  <justin_fan@apple.com>
2557
2558         WebGPU: Rename old WebGPU prototype to WebMetal
2559         https://bugs.webkit.org/show_bug.cgi?id=190325
2560         <rdar://problem/44990443>
2561
2562         Reviewed by Dean Jackson.
2563
2564         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2565
2566         * Configurations/FeatureDefines.xcconfig:
2567         * WebView/WebPreferenceKeysPrivate.h:
2568         * WebView/WebPreferences.mm:
2569         (+[WebPreferences initialize]):
2570         (-[WebPreferences webMetalEnabled]):
2571         (-[WebPreferences setWebMetalEnabled:]):
2572         (-[WebPreferences webGPUEnabled]): Deleted.
2573         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2574         * WebView/WebPreferencesPrivate.h:
2575         * WebView/WebView.mm:
2576         (-[WebView _preferencesChanged:]):
2577
2578 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2579
2580         Make <input type=color> a runtime enabled (on-by-default) feature
2581         https://bugs.webkit.org/show_bug.cgi?id=189162
2582
2583         Reviewed by Wenson Hsieh and Tim Horton.
2584
2585         * Configurations/FeatureDefines.xcconfig:
2586
2587 2018-10-07  Dan Bernstein  <mitz@apple.com>
2588
2589         Fixed building with the latest macOS SDK
2590
2591         * Plugins/WebNetscapePluginPackage.mm:
2592         (-[WebNetscapePluginPackage openResourceFile]):
2593         (-[WebNetscapePluginPackage closeResourceFile:]):
2594
2595 2018-10-04  Dan Bernstein  <mitz@apple.com>
2596
2597         More Carbon build-fixing.
2598
2599         * Carbon/CarbonWindowAdapter.mm:
2600         (-[CarbonWindowAdapter _destroyRealWindow:]):
2601         (-[CarbonWindowAdapter _growBoxRect]):
2602
2603 2018-10-04  Dan Bernstein  <mitz@apple.com>
2604
2605         Retried to fix 32-bit macOS builds after r236846.
2606
2607         * WebView/WebHTMLView.mm:
2608         (-[WebHTMLView setMarkedText:selectedRange:]):
2609
2610 2018-10-04  Dan Bernstein  <mitz@apple.com>
2611
2612         Retried to fix 32-bit macOS builds after r236846.
2613
2614         * Carbon/HIWebView.mm:
2615         (ActiveStateChanged):
2616
2617 2018-10-04  Dan Bernstein  <mitz@apple.com>
2618
2619         Tried to fix 32-bit macOS builds after r236846.
2620
2621         * Carbon/HIWebView.mm:
2622         (_NSSelectorForHICommand):
2623
2624 2018-10-04  Dan Bernstein  <mitz@apple.com>
2625
2626         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2627         https://bugs.webkit.org/show_bug.cgi?id=190250
2628
2629         Reviewed by Andy Estes.
2630
2631         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2632           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2633           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2634           an earlier line set it to YES.
2635
2636         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2637         changes below.
2638
2639         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2640           provides some missing method declarations.
2641
2642         * Misc/WebDownload.mm:
2643         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2644           a deprecated method.
2645
2646         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2647
2648         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2649           other code in the file uses a method from it.
2650
2651         * Plugins/WebBaseNetscapePluginView.mm:
2652         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2653           a deprecated method.
2654
2655         * Plugins/WebPluginController.mm:
2656         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2657           around use of a selector that may be present in some WebKit client.
2658
2659         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2660           method declarations.
2661
2662         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2663           from here.
2664
2665         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2666           missing method declarations.
2667
2668         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2669           from here.
2670
2671         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2672           call from here.
2673         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2674           an obsolete delegate method for binary compatibility.
2675         (pluginView): Ditto.
2676
2677         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2678           call from here.
2679
2680         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2681           WebDeviceOrientationProviderMock protocol.
2682
2683         * WebView/WebDeviceOrientationProviderMock.mm:
2684         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2685           main @implementation.
2686
2687         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2688           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2689
2690         * WebView/WebDynamicScrollBarsView.mm:
2691         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2692           of a deprecated method.
2693
2694         * WebView/WebHTMLView.mm:
2695         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2696           selector warning around action methods that are not declared anywhere in WebKit.
2697
2698         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2699           about implementing this deprecated method.
2700         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2701         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2702         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2703         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2704         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2705         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2706         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2707         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2708         (-[WebHTMLView doCommandBySelector:]): Ditto.
2709         (-[WebHTMLView insertText:]): Ditto.
2710
2711         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
2712
2713         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
2714
2715         * WebView/WebPDFView.h: Removed previewView ivar.
2716
2717         * WebView/WebPDFView.mm:
2718           Removed declaration of FileInternal category and merged its implementation with the main
2719           implementation.
2720         (-[WebPDFView dealloc]): Removed previewView ivar.
2721         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
2722           exist in macOS versions we support.
2723         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
2724         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
2725           action methods internal to PDFKit.
2726         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
2727         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
2728
2729         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
2730           call on macOS, even though in r86988 we started calling different methods on iOS.
2731
2732         * WebView/WebView.mm:
2733         - Imported headers that declare delegate methods that we call.
2734         - Removed declaration of WebFileInternal category and merged its implementation with the
2735           main implementation.
2736         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
2737           category, which made them impossible to call from the main implementation. Moved those
2738           into the main implementation. One of those had to be declared in a class extension,
2739           because it is called from a method implemented in the WebPrivate category, and that
2740           category’s implementation appears first in the file.
2741
2742         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
2743           around use of obsolete delegate method for binary compatibility.
2744
2745         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
2746
2747 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
2748
2749         Runtime flag and IDL for MediaRecorder
2750         https://bugs.webkit.org/show_bug.cgi?id=190018
2751
2752         Reviewed by Youenn Fablet and Chris Dumez.
2753
2754         * WebView/WebPreferenceKeysPrivate.h:
2755         * WebView/WebPreferences.mm:
2756         (+[WebPreferences initialize]):
2757         (-[WebPreferences mediaRecorderEnabled]):
2758         (-[WebPreferences setMediaRecorderEnabled:]):
2759         * WebView/WebPreferencesPrivate.h:
2760         * WebView/WebView.mm:
2761         (-[WebView _preferencesChanged:]):
2762
2763 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
2764
2765         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
2766         https://bugs.webkit.org/show_bug.cgi?id=190238
2767
2768         Reviewed by Antti Koivisto.
2769
2770         Enabled the feature by default.
2771
2772         * WebView/WebPreferences.mm:
2773         (+[WebPreferences initialize]):
2774
2775 2018-10-01  Dean Jackson  <dino@apple.com>
2776
2777         [macOS] Switching to discrete GPU should be done in the UI process
2778         https://bugs.webkit.org/show_bug.cgi?id=189361
2779         <rdar://problem/43949622>
2780
2781         Reviewed by Simon Fraser.
2782
2783         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
2784         not support swapping to the discrete GPU in this configuration.
2785
2786         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
2787         (WebKit::WebSwitchingGPUClient::singleton):
2788         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
2789         * WebView/WebView.mm:
2790         (-[WebView _commonInitializationWithFrameName:groupName:]):
2791
2792 2018-10-02  Alex Christensen  <achristensen@webkit.org>
2793
2794         Remove ParsedURLString
2795         https://bugs.webkit.org/show_bug.cgi?id=190154
2796
2797         Reviewed by Chris Dumez.
2798
2799         * WebView/WebScriptDebugger.mm:
2800         (toNSURL):
2801
2802 2018-10-01  Dean Jackson  <dino@apple.com>
2803
2804         Remove CSS Animation Triggers
2805         https://bugs.webkit.org/show_bug.cgi?id=190175
2806         <rdar://problem/44925626>
2807
2808         Reviewed by Simon Fraser.
2809
2810         * Configurations/FeatureDefines.xcconfig:
2811
2812 2018-10-02  Commit Queue  <commit-queue@webkit.org>
2813
2814         Unreviewed, rolling out r236624 and r236671.
2815         https://bugs.webkit.org/show_bug.cgi?id=190207
2816
2817         The change in r236624 introduced crashes on the bots
2818         (Requested by ryanhaddad on #webkit).
2819
2820         Reverted changesets:
2821
2822         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2823         https://bugs.webkit.org/show_bug.cgi?id=188747
2824         https://trac.webkit.org/changeset/236624
2825
2826         "Unify implementation in VideoFullscreenInterfaceAVKit"
2827         https://bugs.webkit.org/show_bug.cgi?id=190091
2828         https://trac.webkit.org/changeset/236671
2829
2830 2018-10-01  Alex Christensen  <achristensen@webkit.org>
2831
2832         URL should not use TextEncoding internally
2833         https://bugs.webkit.org/show_bug.cgi?id=190111
2834
2835         Reviewed by Andy Estes.
2836
2837         * Misc/WebNSURLExtras.mm:
2838
2839 2018-09-28  Jer Noble  <jer.noble@apple.com>
2840
2841         Refactoring: eliminate raw pointer usage in Fullscreen code
2842         https://bugs.webkit.org/show_bug.cgi?id=188747
2843         <rdar://problem/43541164>
2844
2845         Reviewed by Alex Christensen.
2846
2847         PlaybackSessionInterface no longer has an invalidate() method.
2848
2849         * WebView/WebView.mm:
2850         (-[WebView _clearPlaybackControlsManager]):
2851
2852 2018-09-28  Chris Dumez  <cdumez@apple.com>
2853
2854         Drop support for cross-origin-window-policy header
2855         https://bugs.webkit.org/show_bug.cgi?id=190081
2856
2857         Reviewed by Ryosuke Niwa.
2858
2859         * WebView/WebPreferenceKeysPrivate.h:
2860         * WebView/WebPreferences.mm:
2861         (+[WebPreferences initialize]):
2862         * WebView/WebPreferencesPrivate.h:
2863         * WebView/WebView.mm:
2864         (-[WebView _preferencesChanged:]):
2865
2866 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2867
2868         Rename createMarkup to serializePreservingVisualAppearance
2869         https://bugs.webkit.org/show_bug.cgi?id=190086
2870
2871         Reviewed by Wenson Hsieh.
2872
2873         * DOM/WebDOMOperations.mm:
2874         (-[DOMRange markupString]):
2875
2876 2018-09-28  Commit Queue  <commit-queue@webkit.org>
2877
2878         Unreviewed, rolling out r236605.
2879         https://bugs.webkit.org/show_bug.cgi?id=190087
2880
2881         caused three API test timeouts (Requested by jernoble on
2882         #webkit).
2883
2884         Reverted changeset:
2885
2886         "Refactoring: eliminate raw pointer usage in Fullscreen code"
2887         https://bugs.webkit.org/show_bug.cgi?id=188747
2888         https://trac.webkit.org/changeset/236605
2889
2890 2018-09-28  Jer Noble  <jer.noble@apple.com>
2891
2892         Refactoring: eliminate raw pointer usage in Fullscreen code
2893         https://bugs.webkit.org/show_bug.cgi?id=188747
2894         <rdar://problem/43541164>
2895
2896         Reviewed by Alex Christensen.
2897
2898         PlaybackSessionInterface no longer has an invalidate() method.
2899
2900         * WebView/WebView.mm:
2901         (-[WebView _clearPlaybackControlsManager]):
2902
2903 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2904
2905         Use enum class in createMarkup arguments
2906         https://bugs.webkit.org/show_bug.cgi?id=190028
2907
2908         Reviewed by Wenson Hsieh.
2909
2910         * DOM/WebDOMOperations.mm:
2911         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
2912         (-[DOMRange markupString]): Ditto.
2913
2914 2018-09-27  Antoine Quint  <graouts@apple.com>
2915
2916         [Web Animations] Turn Web Animations with CSS integration on
2917         https://bugs.webkit.org/show_bug.cgi?id=184819
2918         <rdar://problem/39597337>
2919
2920         Reviewed by Dean Jackson.
2921
2922         * WebView/WebPreferences.mm:
2923         (+[WebPreferences initialize]):
2924
2925 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
2926
2927         Selection should work across shadow boundary when initiated by a mouse drag
2928         https://bugs.webkit.org/show_bug.cgi?id=151380
2929         <rdar://problem/24363872>
2930
2931         Reviewed by Wenson Hsieh.
2932
2933         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
2934
2935         * WebView/WebPreferenceKeysPrivate.h:
2936         * WebView/WebPreferences.mm:
2937         (+[WebPreferences initialize]):
2938         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
2939         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
2940         * WebView/WebPreferencesPrivate.h:
2941         * WebView/WebView.mm:
2942         (-[WebView _preferencesChanged:]):
2943
2944 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2945
2946         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
2947         https://bugs.webkit.org/show_bug.cgi?id=189918
2948         Work towards <rdar://problem/44648705>
2949
2950         Reviewed by Tim Horton.
2951
2952         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
2953
2954         * WebView/WebHTMLView.mm:
2955         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
2956         (-[WebHTMLView _updateFontPanel]):
2957         * WebView/WebView.mm:
2958         (-[WebView typingAttributes]):
2959
2960 2018-09-17  Darin Adler  <darin@apple.com>
2961
2962         Use OpaqueJSString rather than JSRetainPtr inside WebKit
2963         https://bugs.webkit.org/show_bug.cgi?id=189652
2964
2965         Reviewed by Saam Barati.
2966
2967         * WebView/WebPDFRepresentation.mm:
2968         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
2969
2970 2018-09-14  Jer Noble  <jer.noble@apple.com>
2971
2972         Turn SourceBufferChangeTypeEnabled on by default
2973         https://bugs.webkit.org/show_bug.cgi?id=189527
2974
2975         Reviewed by Eric Carlson.
2976
2977         * WebView/WebPreferences.mm:
2978         (+[WebPreferences initialize]):
2979
2980 2018-09-12  Alex Christensen  <achristensen@webkit.org>
2981
2982         Fix an internal build after r235935
2983         https://bugs.webkit.org/show_bug.cgi?id=188996
2984
2985         * Carbon/HIWebView.mm:
2986         (Draw):
2987         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
2988
2989 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
2990
2991         Add IGNORE_WARNING_.* macros
2992         https://bugs.webkit.org/show_bug.cgi?id=188996
2993
2994         Reviewed by Michael Catanzaro.
2995
2996         * Carbon/CarbonUtils.m:
2997         (PoolCleaner):
2998         * Carbon/CarbonWindowAdapter.mm:
2999         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3000         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3001         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3002         (-[CarbonWindowAdapter _termWindowIfOwner]):
3003         (-[CarbonWindowAdapter _windowMovedToRect:]):
3004         (-[CarbonWindowAdapter setContentView:]):
3005         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3006         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3007         * Carbon/CarbonWindowFrame.m:
3008         (-[CarbonWindowFrame title]):
3009         * Carbon/HIViewAdapter.m:
3010         (+[HIViewAdapter getHIViewForNSView:]):
3011         * Carbon/HIWebView.mm:
3012         (overrideCGContext):
3013         (restoreCGContext):
3014         (Draw):
3015         * DOM/DOM.mm:
3016         * History/WebHistory.mm:
3017         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3018         * History/WebHistoryItem.mm:
3019         (-[WebHistoryItem icon]):
3020         * Misc/WebKitNSStringExtras.mm:
3021         (-[NSString _web_drawAtPoint:font:textColor:]):
3022         * Misc/WebNSImageExtras.m:
3023         (-[NSImage _web_scaleToMaxSize:]):
3024         (-[NSImage _web_dissolveToFraction:]):
3025         * Misc/WebNSPasteboardExtras.mm:
3026         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3027         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3028         * Panels/WebAuthenticationPanel.m:
3029         (-[WebAuthenticationPanel loadNib]):
3030         * Plugins/Hosted/NetscapePluginHostManager.mm:
3031         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3032         (WebKit::NetscapePluginHostManager::didCreateWindow):
3033         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3034         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3035         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3036         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3037         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3038         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3039         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3040         (-[WebHostedNetscapePluginView drawRect:]):
3041         * Plugins/Hosted/WebTextInputWindowController.m:
3042         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3043         * Plugins/WebBaseNetscapePluginView.mm:
3044         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3045         * Plugins/WebNetscapePluginPackage.mm:
3046         (-[WebNetscapePluginPackage _tryLoad]):
3047         * Plugins/WebNetscapePluginView.mm:
3048         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3049         (-[WebNetscapePluginView sendDrawRectEvent:]):
3050         (-[WebNetscapePluginView drawRect:]):
3051         * Plugins/WebPluginController.mm:
3052         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3053         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3054         * WebCoreSupport/PopupMenuMac.mm:
3055         (PopupMenuMac::populate):
3056         * WebCoreSupport/WebAlternativeTextClient.h:
3057         * WebCoreSupport/WebDragClient.mm:
3058         (WebDragClient::startDrag):
3059         * WebCoreSupport/WebFrameLoaderClient.mm:
3060         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3061         (webGetNSImage):
3062         * WebInspector/WebNodeHighlight.mm:
3063         * WebInspector/WebNodeHighlightView.mm:
3064         (-[WebNodeHighlightView drawRect:]):
3065         * WebView/WebClipView.mm:
3066         (-[WebClipView initWithFrame:]):
3067         * WebView/WebFrame.mm:
3068         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3069         (-[WebFrame _drawRect:contentsOnly:]):
3070         (-[WebFrame accessibilityRoot]):
3071         * WebView/WebFullScreenController.mm:
3072         (-[WebFullScreenController enterFullScreen:]):
3073         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3074         (-[WebFullScreenController exitFullScreen]):
3075         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3076         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3077         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3078         * WebView/WebHTMLView.mm:
3079         (-[NSWindow _web_borderView]):
3080         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3081         (-[WebHTMLView _setAsideSubviews]):
3082         (-[WebHTMLView _autoscroll]):
3083         (-[WebHTMLView drawRect:]):
3084         (-[WebHTMLView mouseDown:]):
3085         (-[WebHTMLView mouseDragged:]):
3086         (-[WebHTMLView mouseUp:]):
3087         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3088         (-[WebHTMLView knowsPageRange:]):
3089         (-[WebHTMLView accessibilityHitTest:]):
3090         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3091         (-[WebHTMLView _colorAsString:]):
3092         (-[WebHTMLView copyFont:]):
3093         (-[WebHTMLView _executeSavedKeypressCommands]):
3094         (-[WebHTMLView attachRootLayer:]):
3095         (-[WebHTMLView textStorage]):
3096         (-[WebHTMLView _updateSelectionForInputManager]):
3097         * WebView/WebPDFView.mm:
3098         (_applicationInfoForMIMEType):
3099         (-[WebPDFView centerSelectionInVisibleArea:]):
3100         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3101         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3102         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3103         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3104         * WebView/WebTextCompletionController.mm:
3105         (-[WebTextCompletionController _buildUI]):
3106         (-[WebTextCompletionController _placePopupWindow:]):
3107         * WebView/WebVideoFullscreenController.mm:
3108         * WebView/WebVideoFullscreenHUDWindowController.mm:
3109         (createMediaUIBackgroundView):
3110         * WebView/WebView.mm:
3111         (-[WebTextListTouchBarViewController initWithWebView:]):
3112         (-[WebView _dispatchTileDidDraw:]):
3113         (-[WebView encodeWithCoder:]):
3114         (-[WebView mainFrameIcon]):
3115         (LayerFlushController::flushLayers):
3116         * WebView/WebWindowAnimation.mm:
3117         (setScaledFrameForWindow):
3118
3119 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3120
3121         Remove unused needsDestruction class variables from HashTraits
3122         https://bugs.webkit.org/show_bug.cgi?id=189490
3123
3124         Reviewed by Daniel Bates.
3125
3126         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3127
3128 2018-09-07  Frederic Wang  <fwang@igalia.com>
3129
3130         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3131         https://bugs.webkit.org/show_bug.cgi?id=182230
3132
3133         Reviewed by Simon Fraser.
3134
3135         * DOM/DOMDocument.mm:
3136         (-[DOMDocument scrollingElement]): Use the new name.
3137
3138 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3139
3140         Refactor WebCore::EditAction to be an 8-bit enum class
3141         https://bugs.webkit.org/show_bug.cgi?id=189383
3142
3143         Reviewed by Dan Bernstein.
3144
3145         * WebCoreSupport/WebEditorClient.mm:
3146         (undoNameForEditAction):
3147         * WebView/WebHTMLView.mm:
3148         (-[WebHTMLView pasteFont:]):
3149         (-[WebHTMLView changeFont:]):
3150         (-[WebHTMLView changeAttributes:]):
3151         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3152         (-[WebHTMLView changeColor:]):
3153         * WebView/WebView.mm:
3154         (-[WebView setTypingStyle:]):
3155
3156 2018-09-06  Frederic Wang  <fwang@igalia.com>
3157
3158         Group options of scrollRectToVisible into a struct
3159         https://bugs.webkit.org/show_bug.cgi?id=189352
3160
3161         Reviewed by Simon Fraser.
3162
3163         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3164         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3165         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3166
3167 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3168
3169         [macOS] Cannot change font size at selection until font panel is shown
3170         https://bugs.webkit.org/show_bug.cgi?id=189295
3171         <rdar://problem/35593389>
3172
3173         Reviewed by Ryosuke Niwa.
3174
3175         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3176         WebCore ChangeLog for more details.
3177
3178         * WebView/WebHTMLView.mm:
3179         (-[WebHTMLView changeFont:]):
3180         (-[WebHTMLView changeAttributes:]):
3181         (-[WebHTMLView _originalFontA]): Deleted.
3182         (-[WebHTMLView _originalFontB]): Deleted.
3183         (fontNameForDescription): Deleted.
3184         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3185         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3186         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3187
3188 2018-09-05  Jer Noble  <jer.noble@apple.com>
3189
3190         Add MediaCapabilities as an Experimental Feature
3191         https://bugs.webkit.org/show_bug.cgi?id=189209
3192
3193         Reviewed by Eric Carlson.
3194
3195         RuntimeEnabledFeature -> Setting.
3196
3197         * WebView/WebView.mm:
3198         (-[WebView _preferencesChanged:]):
3199
3200 2018-09-04  Frederic Wang  <fwang@igalia.com>
3201
3202         Add basic support for ScrollIntoViewOptions
3203         https://bugs.webkit.org/show_bug.cgi?id=189258
3204
3205         Reviewed by Simon Fraser.
3206
3207         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3208         header so that this file can build despite the new scrollIntoView function.
3209
3210 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3211
3212         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3213         https://bugs.webkit.org/show_bug.cgi?id=188890
3214         <rdar://problem/43648605>
3215
3216         Reviewed by Tim Horton.
3217
3218         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3219         more detail.
3220
3221         * WebCoreSupport/WebPlatformStrategies.h:
3222         * WebCoreSupport/WebPlatformStrategies.mm:
3223         (WebPlatformStrategies::allStringsForType):
3224
3225 2018-09-01  Darin Adler  <darin@apple.com>
3226
3227         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3228         https://bugs.webkit.org/show_bug.cgi?id=189072
3229         Reviewed by Dan Bernstein.
3230
3231         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3232         and declarations for NSURLDownload init methods.
3233
3234         * Misc/WebDownloadInternal.h: Removed.
3235
3236         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3237         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3238         "-Wdeprecated-declarations" because the method used here is deprecated.
3239
3240         * WebView/WebView.mm:
3241         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3242         used here is deprecated.
3243
3244 2018-08-31  Chris Dumez  <cdumez@apple.com>
3245
3246         Assertion hit in ~CompletionHandler() from ~WebFrame()
3247         https://bugs.webkit.org/show_bug.cgi?id=189199
3248         <rdar://problem/42657233>
3249
3250         Reviewed by Youenn Fablet.
3251
3252         * WebCoreSupport/WebFrameLoaderClient.h:
3253         * WebCoreSupport/WebFrameLoaderClient.mm:
3254         (WebFrameLoaderClient::dispatchWillSubmitForm):
3255
3256 2018-08-31  Antti Koivisto  <antti@apple.com>
3257
3258         Replace OptionSet |= and -= operators with add() and remove() functions
3259         https://bugs.webkit.org/show_bug.cgi?id=189169
3260
3261         Reviewed by Anders Carlsson.
3262
3263         * WebView/WebFrame.mm:
3264         (-[WebFrame _drawRect:contentsOnly:]):
3265         * WebView/WebView.mm:
3266         (coreOptions):
3267
3268 2018-08-31  Frederic Wang  <fwang@igalia.com>
3269
3270         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3271         https://bugs.webkit.org/show_bug.cgi?id=182053
3272
3273         Reviewed by Simon Fraser.
3274
3275         Add developer flag to use standard behavior for scrolling* attributes.
3276
3277         * WebView/WebPreferenceKeysPrivate.h:
3278         * WebView/WebPreferences.mm:
3279         (+[WebPreferences initialize]):
3280         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3281         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3282         * WebView/WebPreferencesPrivate.h:
3283         * WebView/WebView.mm:
3284         (-[WebView _preferencesChanged:]):
3285
3286 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3287
3288         Implement the Web Share API
3289         https://bugs.webkit.org/show_bug.cgi?id=171100
3290         <rdar://problem/31751734>
3291
3292         Reviewed by Tim Horton.
3293
3294         * WebCoreSupport/WebChromeClient.h:
3295         * WebCoreSupport/WebChromeClient.mm:
3296         (WebChromeClient::showShareSheet):
3297         Empty declaration of showShareSheet.
3298
3299 2018-08-29  Youenn Fablet  <youenn@apple.com>
3300
3301         Remove WebRTC legacy API implementation
3302         https://bugs.webkit.org/show_bug.cgi?id=189040
3303
3304         Reviewed by Eric Carlson.
3305
3306         * WebView/WebPreferenceKeysPrivate.h:
3307         * WebView/WebPreferences.mm:
3308         (+[WebPreferences initialize]):
3309         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3310         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3311         * WebView/WebPreferencesPrivate.h:
3312         * WebView/WebView.mm:
3313         (-[WebView _preferencesChanged:]):
3314
3315 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3316
3317         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3318         https://bugs.webkit.org/show_bug.cgi?id=189054
3319
3320         Reviewed by Andy Estes.
3321
3322         Remove the pasteboard type argument from readURLFromPasteboard.
3323
3324         * WebCoreSupport/WebPlatformStrategies.h:
3325         * WebCoreSupport/WebPlatformStrategies.mm:
3326         (WebPlatformStrategies::readURLFromPasteboard):
3327
3328 2018-08-27  Keith Rollin  <krollin@apple.com>
3329
3330         Unreviewed build fix -- disable LTO for production builds
3331
3332         * Configurations/Base.xcconfig:
3333
3334 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3335
3336         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3337         https://bugs.webkit.org/show_bug.cgi?id=188931
3338
3339         Reviewed by Wenson Hsieh.
3340
3341         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3342
3343 2018-08-27  Keith Rollin  <krollin@apple.com>
3344
3345         Build system support for LTO
3346         https://bugs.webkit.org/show_bug.cgi?id=187785
3347         <rdar://problem/42353132>
3348
3349         Reviewed by Dan Bernstein.
3350
3351         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3352         LTO.
3353
3354         * Configurations/Base.xcconfig:
3355         * Configurations/DebugRelease.xcconfig:
3356
3357 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3358
3359         Pass in IsComposed flag to Event constructors
3360         https://bugs.webkit.org/show_bug.cgi?id=188720
3361         <rdar://problem/43580387>
3362
3363         Reviewed by Simon Fraser.
3364
3365         * WebView/WebPDFView.mm:
3366         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3367         whether it's simulated or not.
3368
3369 2018-08-23  Mark Lam  <mark.lam@apple.com>
3370
3371         Move vmEntryGlobalObject() to VM from CallFrame.
3372         https://bugs.webkit.org/show_bug.cgi?id=188900
3373         <rdar://problem/43655753>
3374
3375         Reviewed by Michael Saboff.
3376
3377         * WebView/WebScriptDebugger.mm:
3378         (WebScriptDebugger::sourceParsed):
3379
3380 2018-08-23  Andy Estes  <aestes@apple.com>
3381
3382         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3383         https://bugs.webkit.org/show_bug.cgi?id=188829
3384
3385         Reviewed by Tim Horton.
3386
3387         * Configurations/FeatureDefines.xcconfig:
3388
3389 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3390
3391         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3392         https://bugs.webkit.org/show_bug.cgi?id=188777
3393
3394         Reviewed by Simon Fraser.
3395
3396         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3397         being "true" before the code change.
3398
3399         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3400
3401         * WebView/WebPDFView.mm:
3402         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3403
3404 2018-08-21  Daniel Bates  <dabates@apple.com>
3405
3406         Replace TextCheckingTypeMask with OptionSet
3407         https://bugs.webkit.org/show_bug.cgi?id=188678
3408
3409         Reviewed by Antti Koivisto.
3410
3411         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3412         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3413         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3414         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3415
3416         * WebCoreSupport/WebEditorClient.h:
3417         * WebCoreSupport/WebEditorClient.mm:
3418         (WebEditorClient::checkTextOfParagraph):
3419         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3420         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3421         left as this is more readable and unncessary now that modern compilers like Clang have
3422         diagnostics to catch accidental assignments when equality was intended.
3423         (WebEditorClient::didCheckSucceed):
3424         * WebView/WebView.mm:
3425         (coreTextCheckingType):
3426         (textCheckingResultFromNSTextCheckingResult):
3427
3428 2018-08-21  Daniel Bates  <dabates@apple.com>
3429
3430         [iOS][WK1] Support toggling continuous spell checking from tests
3431         https://bugs.webkit.org/show_bug.cgi?id=188763
3432
3433         Reviewed by Simon Fraser.
3434
3435         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3436         spell checking from tests in iOS WebKit Legacy.
3437
3438         * WebCoreSupport/WebEditorClient.h:
3439         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3440         * WebCoreSupport/WebEditorClient.mm:
3441         * WebView/WebView.h:
3442         * WebView/WebView.mm:
3443         (-[WebView toggleContinuousSpellChecking:]):
3444         (-[WebView toggleSmartInsertDelete:]):
3445
3446 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3447
3448         Add some plumbing for safe browsing
3449         https://bugs.webkit.org/show_bug.cgi?id=188709
3450
3451         Reviewed by Tim Horton.
3452
3453         * WebCoreSupport/WebFrameLoaderClient.h:
3454         * WebCoreSupport/WebFrameLoaderClient.mm:
3455         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3456
3457 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3458
3459         Replace canBubble and cancelable booleans in Event by enum classes
3460         https://bugs.webkit.org/show_bug.cgi?id=188692
3461
3462         Reviewed by Alex Christensen.
3463
3464         * WebView/WebPDFView.mm:
3465         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3466         * WebView/WebView.mm:
3467         (-[WebView _dispatchUnloadEvent]):
3468
3469 2018-08-16  Jer Noble  <jer.noble@apple.com>
3470
3471         Add Experimental Feature support for SourceBuffer.changeType()
3472         https://bugs.webkit.org/show_bug.cgi?id=188626
3473         <rdar://problem/43356021>
3474
3475         Reviewed by Eric Carlson.
3476
3477         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3478
3479         * WebView/WebPreferenceKeysPrivate.h:
3480         * WebView/WebPreferences.mm:
3481         (+[WebPreferences initialize]):
3482         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3483         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3484         * WebView/WebPreferencesPrivate.h:
3485         * WebView/WebView.mm:
3486         (-[WebView _preferencesChanged:]):
3487
3488 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3489
3490         Support drag-and-drop for input[type=color]
3491         https://bugs.webkit.org/show_bug.cgi?id=188464
3492
3493         Reviewed by Wenson Hsieh.
3494
3495         * WebCoreSupport/WebPlatformStrategies.h:
3496         * WebCoreSupport/WebPlatformStrategies.mm:
3497         (WebPlatformStrategies::setColor):
3498
3499 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3500
3501         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3502         https://bugs.webkit.org/show_bug.cgi?id=188569
3503         <rdar://problem/34201095>
3504
3505         Reviewed by Megan Gardner.
3506
3507         * WebView/WebImmediateActionController.mm:
3508         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3509         Speculative fix; the crashes indicate font is null, but we just checked it,
3510         so it must be getting made null by convertFont:toSize:. Check again!
3511
3512 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3513
3514         Use a 1-byte enum class for TextDirection
3515         https://bugs.webkit.org/show_bug.cgi?id=188350
3516
3517         Reviewed by Simon Fraser.
3518
3519         * WebCoreSupport/PopupMenuMac.mm:
3520         (PopupMenuMac::populate):
3521         (PopupMenuMac::show):
3522         * WebCoreSupport/WebFrameLoaderClient.mm:
3523         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3524         * WebView/WebFrame.mm:
3525         (-[WebFrame _dispatchDidReceiveTitle:]):
3526
3527 2018-08-09  Ali Juma  <ajuma@chromium.org>
3528
3529         Import WPTs for IntersectionObserver
3530         https://bugs.webkit.org/show_bug.cgi?id=188416
3531
3532         Reviewed by Simon Fraser.
3533
3534         * WebView/WebPreferencesPrivate.h:
3535
3536 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3537
3538         Follow-up build fix for r234685
3539         https://bugs.webkit.org/show_bug.cgi?id=188245
3540
3541         Unreviewed build fix.
3542
3543         * WebCoreSupport/WebSecurityOriginPrivate.h:
3544
3545 2018-08-05  Darin Adler  <darin@apple.com>
3546
3547         [Cocoa] More tweaks and refactoring to prepare for ARC
3548         https://bugs.webkit.org/show_bug.cgi?id=188245
3549
3550         Reviewed by Dan Bernstein.
3551
3552         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3553
3554         * Carbon/CarbonWindowFrame.m:
3555         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3556
3557         * DOM/DOM.mm:
3558         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3559         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3560         garbage collection so this method isn't useful.
3561
3562         * DOM/DOMXPath.mm:
3563         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3564         Objective-C garbage collection so this method isn't useful.
3565
3566         * History/WebHistory.mm:
3567         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3568
3569         * Misc/WebElementDictionary.mm:
3570         (addLookupKey): Use a bridging cast.
3571         (cacheValueForKey): Ditto.
3572         (-[WebElementDictionary _fillCache]): Ditto.
3573         (-[WebElementDictionary objectForKey:]): Ditto.
3574
3575         * Misc/WebKitNSStringExtras.mm:
3576         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3577         (-[NSString _web_widthWithFont:]): Ditto.
3578         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3579
3580         * Misc/WebLocalizableStrings.mm:
3581         (WebLocalizedString): Use a bridging cast.
3582
3583         * Misc/WebNSDataExtras.mm:
3584         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3585         and use CFBridgingRelease instead of calling autorelease directly.
3586         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3587         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3588         on the amount of explicit release and autorelease.
3589
3590         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3591         * Misc/WebNSDictionaryExtras.m:
3592         (-[NSDictionary _webkit_intForKey:]): Deleted.
3593         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3594         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3595         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3596         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3597         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3598         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3599
3600         * Misc/WebStringTruncator.mm:
3601         (fontFromNSFont): Use a bridging cast.
3602
3603         * Plugins/Hosted/NetscapePluginHostManager.mm:
3604         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3605
3606         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3607         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3608         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3609         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3610         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3611         * Plugins/Hosted/ProxyInstance.mm:
3612         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3613         * Plugins/WebBasePluginPackage.mm:
3614         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3615         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3616         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3617         * Plugins/WebNetscapePluginPackage.mm:
3618         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3619
3620         * Plugins/WebNetscapePluginView.mm:
3621         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3622         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3623         (-[WebNetscapePluginView status:]): Use a bridging cast.
3624         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3625
3626         * Plugins/WebPluginController.mm:
3627         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3628
3629         * Plugins/WebPluginDatabase.mm:
3630         (checkCandidate): Use explicit __strong for out argument types.
3631
3632         * Plugins/npapi.mm:
3633         (pluginViewForInstance): Use a bridging cast.
3634
3635         * Storage/WebDatabaseManager.mm:
3636         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3637         explicit NSNumber and NSDictionary calls.
3638
3639         * WebCoreSupport/WebContextMenuClient.mm:
3640         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3641
3642         * WebCoreSupport/WebEditorClient.mm:
3643         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3644         (WebEditorClient::handleInputMethodKeydown): Ditto.
3645
3646         * WebCoreSupport/WebFrameNetworkingContext.mm:
3647         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3648
3649         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3650         as a struct rather than an Objective-C class, since that's how it's defined.
3651
3652         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3653
3654         * WebView/WebFullScreenController.mm:
3655         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3656         * WebView/WebHTMLView.mm:
3657         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3658         Ditto.
3659         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3660
3661         * WebView/WebImmediateActionController.mm:
3662         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3663         go down to the document and then back to the frame.
3664         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3665         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3666         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3667
3668         * WebView/WebJSPDFDoc.mm:
3669         (jsPDFDocInitialize): Removed some unneeded type casting.
3670         (jsPDFDocFinalize): Ditto.
3671         (jsPDFDocPrint): Use a bridging cast.
3672
3673         * WebView/WebPDFView.mm:
3674         (_applicationInfoForMIMEType): Use bridging casts.
3675
3676         * WebView/WebPreferences.mm:
3677         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3678         instead of methods from WebNSDictionaryExtras.
3679         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3680         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3681         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3682         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3683         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3684
3685         * WebView/WebView.mm:
3686         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3687         (-[WebView _addToAllWebViewsSet]): Ditto.
3688         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3689         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3690         so it can be called from WebViewData methods.
3691
3692         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3693         method, _windowVisibilityChanged:.
3694
3695         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3696         called from WebViewData methods.
3697
3698 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3699
3700         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3701         https://bugs.webkit.org/show_bug.cgi?id=188323
3702
3703         Reviewed by Simon Fraser.
3704
3705         * WebCoreSupport/WebContextMenuClient.mm:
3706         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3707         * WebView/WebFrame.mm:
3708         (-[WebFrame _paintBehaviorForDestinationContext:]):
3709         (-[WebFrame _drawRect:contentsOnly:]):
3710         * WebView/WebHTMLView.mm:
3711         (imageFromRect):
3712         (selectionImage):
3713
3714 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3715
3716         Add support for microtasks in workers
3717         https://bugs.webkit.org/show_bug.cgi?id=188246
3718
3719         Reviewed by Darin Adler.
3720
3721         Rename JSMainThreadExecState.h to JSExecState.h.
3722
3723         * DOM/DOMAttr.mm:
3724         * DOM/DOMBlob.mm:
3725         * DOM/DOMCDATASection.mm:
3726         * DOM/DOMCSSCharsetRule.mm:
3727         * DOM/DOMCSSFontFaceRule.mm:
3728         * DOM/DOMCSSImportRule.mm:
3729         * DOM/DOMCSSMediaRule.mm:
3730         * DOM/DOMCSSPageRule.mm:
3731         * DOM/DOMCSSPrimitiveValue.mm:
3732         * DOM/DOMCSSRule.mm:
3733         * DOM/DOMCSSRuleList.mm:
3734         * DOM/DOMCSSStyleDeclaration.mm:
3735         * DOM/DOMCSSStyleRule.mm:
3736         * DOM/DOMCSSStyleSheet.mm:
3737         * DOM/DOMCSSUnknownRule.mm:
3738         * DOM/DOMCSSValue.mm:
3739         * DOM/DOMCSSValueList.mm:
3740         * DOM/DOMCharacterData.mm:
3741         * DOM/DOMComment.mm:
3742         * DOM/DOMCounter.mm:
3743         * DOM/DOMDocument.mm:
3744         * DOM/DOMDocumentFragment.mm:
3745         * DOM/DOMDocumentType.mm:
3746         * DOM/DOMElement.mm:
3747         * DOM/DOMEvent.mm:
3748         * DOM/DOMFile.mm:
3749         * DOM/DOMFileList.mm:
3750         * DOM/DOMHTML.mm:
3751         * DOM/DOMHTMLAnchorElement.mm:
3752         * DOM/DOMHTMLAppletElement.mm:
3753         * DOM/DOMHTMLAreaElement.mm:
3754         * DOM/DOMHTMLBRElement.mm:
3755         * DOM/DOMHTMLBaseElement.mm:
3756         * DOM/DOMHTMLBaseFontElement.mm:
3757         * DOM/DOMHTMLBodyElement.mm:
3758         * DOM/DOMHTMLButtonElement.mm:
3759         * DOM/DOMHTMLCanvasElement.mm:
3760         * DOM/DOMHTMLCollection.mm:
3761         * DOM/DOMHTMLDListElement.mm:
3762         * DOM/DOMHTMLDirectoryElement.mm:
3763         * DOM/DOMHTMLDivElement.mm:
3764         * DOM/DOMHTMLDocument.mm:
3765         * DOM/DOMHTMLElement.mm:
3766         * DOM/DOMHTMLEmbedElement.mm:
3767         * DOM/DOMHTMLFieldSetElement.mm:
3768         * DOM/DOMHTMLFontElement.mm:
3769         * DOM/DOMHTMLFormElement.mm:
3770         * DOM/DOMHTMLFrameElement.mm:
3771         * DOM/DOMHTMLFrameSetElement.mm:
3772         * DOM/DOMHTMLHRElement.mm:
3773         * DOM/DOMHTMLHeadElement.mm:
3774         * DOM/DOMHTMLHeadingElement.mm:
3775         * DOM/DOMHTMLHtmlElement.mm:
3776         * DOM/DOMHTMLIFrameElement.mm:
3777         * DOM/DOMHTMLImageElement.mm:
3778         * DOM/DOMHTMLInputElement.mm:
3779         * DOM/DOMHTMLLIElement.mm:
3780         * DOM/DOMHTMLLabelElement.mm:
3781         * DOM/DOMHTMLLegendElement.mm:
3782         * DOM/DOMHTMLLinkElement.mm:
3783         * DOM/DOMHTMLMapElement.mm:
3784         * DOM/DOMHTMLMarqueeElement.mm:
3785         * DOM/DOMHTMLMediaElement.mm:
3786         * DOM/DOMHTMLMenuElement.mm:
3787         * DOM/DOMHTMLMetaElement.mm:
3788         * DOM/DOMHTMLModElement.mm:
3789         * DOM/DOMHTMLOListElement.mm:
3790         * DOM/DOMHTMLObjectElement.mm:
3791         * DOM/DOMHTMLOptGroupElement.mm:
3792         * DOM/DOMHTMLOptionElement.mm:
3793         * DOM/DOMHTMLOptionsCollection.mm:
3794         * DOM/DOMHTMLParagraphElement.mm:
3795         * DOM/DOMHTMLParamElement.mm:
3796         * DOM/DOMHTMLPreElement.mm:
3797         * DOM/DOMHTMLQuoteElement.mm:
3798         * DOM/DOMHTMLScriptElement.mm:
3799         * DOM/DOMHTMLSelectElement.mm:
3800         * DOM/DOMHTMLStyleElement.mm:
3801         * DOM/DOMHTMLTableCaptionElement.mm:
3802         * DOM/DOMHTMLTableCellElement.mm:
3803         * DOM/DOMHTMLTableColElement.mm:
3804         * DOM/DOMHTMLTableElement.mm:
3805         * DOM/DOMHTMLTableRowElement.mm:
3806         * DOM/DOMHTMLTableSectionElement.mm:
3807         * DOM/DOMHTMLTextAreaElement.mm:
3808         * DOM/DOMHTMLTitleElement.mm:
3809         * DOM/DOMHTMLUListElement.mm:
3810         * DOM/DOMHTMLVideoElement.mm:
3811         * DOM/DOMImplementation.mm:
3812         * DOM/DOMKeyboardEvent.mm:
3813         * DOM/DOMMediaError.mm:
3814         * DOM/DOMMediaList.mm:
3815         * DOM/DOMMouseEvent.mm:
3816         * DOM/DOMMutationEvent.mm:
3817         * DOM/DOMNamedNodeMap.mm:
3818         * DOM/DOMNode.mm:
3819         * DOM/DOMNodeIterator.mm:
3820         * DOM/DOMNodeList.mm:
3821         * DOM/DOMOverflowEvent.mm:
3822         * DOM/DOMProcessingInstruction.mm:
3823         * DOM/DOMProgressEvent.mm:
3824         * DOM/DOMRGBColor.mm:
3825         * DOM/DOMRange.mm:
3826         * DOM/DOMRect.mm:
3827         * DOM/DOMStyleSheet.mm:
3828         * DOM/DOMStyleSheetList.mm:
3829         * DOM/DOMText.mm:
3830         * DOM/DOMTextEvent.mm:
3831         * DOM/DOMTimeRanges.mm:
3832         * DOM/DOMTokenList.mm:
3833         * DOM/DOMTreeWalker.mm:
3834         * DOM/DOMUIEvent.mm:
3835         * DOM/DOMWheelEvent.mm:
3836         * DOM/DOMXPathExpression.mm:
3837         * DOM/DOMXPathResult.mm:
3838         * DOM/ObjCEventListener.mm:
3839
3840 2018-08-03  Alex Christensen  <achristensen@webkit.org>
3841
3842         Fix spelling of "overridden"
3843         https://bugs.webkit.org/show_bug.cgi?id=188315
3844
3845         Reviewed by Darin Adler.
3846
3847         * Misc/WebKitVersionChecks.mm:
3848         (setWebKitLinkTimeVersion):
3849         (WebKitLinkTimeVersion):
3850         * Plugins/WebBaseNetscapePluginView.mm:
3851         (-[WebBaseNetscapePluginView handleMouseMoved:]):
3852         * WebCoreSupport/PopupMenuMac.mm:
3853         (PopupMenuMac::populate):
3854
3855 2018-08-01  Nan Wang  <n_wang@apple.com>
3856
3857         AX: AOM: Add ARIA IDL Attribute Reflection
3858         https://bugs.webkit.org/show_bug.cgi?id=184676
3859         <rdar://problem/39476882>
3860
3861         Reviewed by Chris Fleizach.
3862
3863         * WebView/WebPreferenceKeysPrivate.h:
3864         * WebView/WebPreferences.mm:
3865         (+[WebPreferences initialize]):
3866         (-[WebPreferences ariaReflectionEnabled]):
3867         (-[WebPreferences setAriaReflectionEnabled:]):
3868         * WebView/WebPreferencesPrivate.h:
3869         * WebView/WebView.mm:
3870         (-[WebView _preferencesChanged:]):
3871
3872 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
3873
3874         Shrink GraphicsLayerCA
3875         https://bugs.webkit.org/show_bug.cgi?id=188141
3876
3877         Reviewed by Zalan Bujtas.
3878
3879         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
3880         * moving all the clone-related stuff into the lazily-allocated m_layerClones
3881         * moving all the animation-related stuff into the lazily-allocated m_animations
3882         * making enums be 8-bit
3883         * re-ordering data members
3884
3885         * WebView/WebView.mm:
3886         (-[WebView _setMediaLayer:forPluginView:]):
3887
3888 2018-07-30  Rob Buis  <rbuis@igalia.com>
3889
3890         Merge PlatformCookieJar functions into NetworkStorageSession
3891         https://bugs.webkit.org/show_bug.cgi?id=188137
3892
3893         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
3894
3895         Reviewed by Alex Christensen.
3896
3897         * WebCoreSupport/WebPlatformStrategies.mm:
3898         (WebPlatformStrategies::cookiesForDOM):
3899         (WebPlatformStrategies::setCookiesFromDOM):
3900         (WebPlatformStrategies::cookiesEnabled):
3901         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3902         (WebPlatformStrategies::getRawCookies):
3903         (WebPlatformStrategies::deleteCookie):
3904         * WebView/WebPreferences.mm:
3905         (+[WebPreferences _clearNetworkLoaderSession]):
3906
3907 2018-07-28  Darin Adler  <darin@apple.com>
3908
3909         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
3910         https://bugs.webkit.org/show_bug.cgi?id=188140
3911
3912         Reviewed by Sam Weinig.
3913
3914         * WebView/WebImmediateActionController.mm:
3915         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
3916         new DictionaryLookup function that returns a tuple instead of using an out argument.
3917
3918 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
3919
3920         [INTL] Remove INTL sub-feature compile flags
3921         https://bugs.webkit.org/show_bug.cgi?id=188081
3922
3923         Reviewed by Michael Catanzaro.
3924
3925         * Configurations/FeatureDefines.xcconfig:
3926
3927 2018-07-26  Commit Queue  <commit-queue@webkit.org>
3928
3929         Unreviewed, rolling out r234181 and r234189.
3930         https://bugs.webkit.org/show_bug.cgi?id=188075
3931
3932         These are not needed right now (Requested by thorton on
3933         #webkit).
3934
3935         Reverted changesets:
3936
3937         "Enable Web Content Filtering on watchOS"
3938         https://bugs.webkit.org/show_bug.cgi?id=187979
3939         https://trac.webkit.org/changeset/234181
3940
3941         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
3942         https://bugs.webkit.org/show_bug.cgi?id=187985
3943         https://trac.webkit.org/changeset/234189
3944
3945 2018-07-26  Timothy Hatcher  <timothy@apple.com>
3946
3947         Use the Page's appearance when converting pasteboard attributed strings.
3948         https://bugs.webkit.org/show_bug.cgi?id=188067
3949         rdar://problem/42632246
3950
3951         Reviewed by Wenson Hsieh.
3952
3953         * WebCoreSupport/WebEditorClient.mm:
3954         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
3955
3956 2018-07-25  Chris Dumez  <cdumez@apple.com>
3957
3958         navigator.userAgent may return outdated value after webView.customUserAgent is set
3959         https://bugs.webkit.org/show_bug.cgi?id=188009
3960         <rdar://problem/42566456>
3961
3962         Reviewed by Alex Christensen.
3963
3964         Let the page know when the user agent changes.
3965
3966         * WebView/WebView.mm:
3967         (-[WebView _preferencesChanged:]):
3968         (-[WebView setApplicationNameForUserAgent:]):
3969         (-[WebView _invalidateUserAgentCache]):
3970         (-[WebView setCustomUserAgent:]):
3971         * WebView/WebViewInternal.h:
3972
3973 2018-07-24  Tim Horton  <timothy_horton@apple.com>
3974
3975         Enable Web Content Filtering on watchOS
3976         https://bugs.webkit.org/show_bug.cgi?id=187979
3977         <rdar://problem/42559346>
3978
3979         Reviewed by Wenson Hsieh.
3980
3981         * Configurations/FeatureDefines.xcconfig:
3982
3983 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
3984
3985         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
3986         https://bugs.webkit.org/show_bug.cgi?id=187846
3987
3988         Reviewed by Simon Fraser.
3989
3990         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
3991
3992         * WebView/WebHTMLView.mm:
3993         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
3994         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
3995
3996 2018-07-11  Dean Jackson  <dino@apple.com>
3997
3998         Allow removal of white backgrounds
3999         https://bugs.webkit.org/show_bug.cgi?id=187574
4000         <rdar://problem/41146792>
4001
4002         Reviewed by Simon Fraser.
4003
4004         Add a new WebPreference for punching out white backgrounds.
4005
4006         * WebView/WebPreferenceKeysPrivate.h:
4007         * WebView/WebPreferences.mm:
4008         (+[WebPreferences initialize]):
4009         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
4010         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
4011         * WebView/WebPreferencesPrivate.h:
4012         * WebView/WebView.mm:
4013         (-[WebView _preferencesChanged:]):
4014
4015 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
4016
4017         Ensure WebKit stack is ad-hoc signed
4018         https://bugs.webkit.org/show_bug.cgi?id=187667
4019
4020         Reviewed by Alexey Proskuryakov.
4021
4022         * Configurations/Base.xcconfig:
4023
4024 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
4025
4026         REGRESSION (231276): Attempting to copy an image fails
4027         https://bugs.webkit.org/show_bug.cgi?id=187212
4028         <rdar://problem/41540074>
4029
4030         Reviewed by Ryosuke Niwa.
4031
4032         Renamed methods to make it clear that one URL and one title are being passed in.
4033
4034         * WebCoreSupport/WebPlatformStrategies.h:
4035         * WebCoreSupport/WebPlatformStrategies.mm:
4036         (WebPlatformStrategies::setURL):
4037
4038 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
4039
4040         Disable cross-origin-window-policy by default
4041         https://bugs.webkit.org/show_bug.cgi?id=187509
4042
4043         Reviewed by Chris Dumez.
4044
4045         * WebView/WebPreferences.mm:
4046         (+[WebPreferences initialize]):
4047
4048 2018-07-09  Timothy Hatcher  <timothy@apple.com>
4049
4050         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
4051         https://bugs.webkit.org/show_bug.cgi?id=187425
4052         rdar://problem/39948240
4053
4054         Reviewed by Tim Horton.