Remove some more unused 32-bit code
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-03-03  Tim Horton  <timothy_horton@apple.com>
2
3         Remove some more unused 32-bit code
4         https://bugs.webkit.org/show_bug.cgi?id=195255
5
6         Reviewed by Darin Adler.
7
8         * Plugins/WebNetscapePluginEventHandler.mm:
9         (WebNetscapePluginEventHandler::create):
10         * Plugins/WebNetscapePluginView.h:
11         * Plugins/WebNetscapePluginView.mm:
12         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
13         (-[WebNetscapePluginView restorePortState:]):
14         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
15         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
16         (-[WebNetscapePluginView updateAndSetWindow]):
17         (-[WebNetscapePluginView setWindowIfNecessary]):
18         (-[WebNetscapePluginView createPlugin]):
19         (-[WebNetscapePluginView fini]):
20         (-[WebNetscapePluginView drawRect:]):
21         (-[WebNetscapePluginView invalidateRegion:]):
22         (-[WebNetscapePluginView getVariable:value:]):
23         (-[WebNetscapePluginView setVariable:value:]):
24         (isDrawingModelQuickDraw): Deleted.
25         (-[WebNetscapePluginView fixWindowPort]): Deleted.
26         (getQDPixelFormatForBitmapContext): Deleted.
27         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
28         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
29         * WebView/WebDelegateImplementationCaching.mm:
30
31 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
32
33         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
34         https://bugs.webkit.org/show_bug.cgi?id=195053
35         <rdar://problem/48134710>
36
37         Reviewed by Ryosuke Niwa.
38
39         * WebCoreSupport/WebEditorClient.h:
40
41 2019-03-01  Tim Horton  <timothy_horton@apple.com>
42
43         Remove unused code in WebKitLegacy
44         https://bugs.webkit.org/show_bug.cgi?id=189614
45
46         Reviewed by Simon Fraser.
47
48         * Carbon/CarbonUtils.h: Removed.
49         * Carbon/CarbonUtils.m: Removed.
50         * Carbon/CarbonWindowAdapter.h: Removed.
51         * Carbon/CarbonWindowAdapter.mm: Removed.
52         * Carbon/CarbonWindowContentView.h: Removed.
53         * Carbon/CarbonWindowContentView.m: Removed.
54         * Carbon/CarbonWindowFrame.h: Removed.
55         * Carbon/CarbonWindowFrame.m: Removed.
56         * Carbon/HIViewAdapter.h: Removed.
57         * Carbon/HIViewAdapter.m: Removed.
58         * Carbon/HIWebView.h: Removed.
59         * Carbon/HIWebView.mm: Removed.
60         * Configurations/WebKitLegacy.xcconfig:
61         * WebKit.mac.exp:
62
63 2019-03-01  Justin Fan  <justin_fan@apple.com>
64
65         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
66         https://bugs.webkit.org/show_bug.cgi?id=195191
67
68         Rubber-stamped by Dean Jackson.
69
70         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
71
72         * Configurations/FeatureDefines.xcconfig:
73
74 2019-02-28  Antoine Quint  <graouts@apple.com>
75
76         Enable the Pointer Events runtime flag by default
77         https://bugs.webkit.org/show_bug.cgi?id=195156
78
79         Reviewed by Dean Jackson.
80
81         * WebView/WebPreferences.mm:
82         (+[WebPreferences initialize]):
83
84 2019-02-28  Justin Fan  <justin_fan@apple.com>
85
86         [Web GPU] Enable Web GPU only on 64-bit
87         https://bugs.webkit.org/show_bug.cgi?id=195139
88
89         Because Metal is only supported on 64 bit apps.
90
91         Unreviewed build fix.
92
93         * Configurations/FeatureDefines.xcconfig:
94
95 2019-02-27  Antoine Quint  <graouts@apple.com>
96
97         Support Pointer Events on macOS
98         https://bugs.webkit.org/show_bug.cgi?id=195008
99         <rdar://problem/47454419>
100
101         Reviewed by Dean Jackson.
102
103         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
104
105         * Configurations/FeatureDefines.xcconfig:
106         * WebView/WebPreferenceKeysPrivate.h:
107         * WebView/WebPreferences.mm:
108         (+[WebPreferences initialize]):
109         (-[WebPreferences pointerEventsEnabled]):
110         (-[WebPreferences setPointerEventsEnabled:]):
111         * WebView/WebPreferencesPrivate.h:
112         * WebView/WebView.mm:
113         (-[WebView _preferencesChanged:]):
114
115 2019-02-23  Keith Miller  <keith_miller@apple.com>
116
117         Add new mac target numbers
118         https://bugs.webkit.org/show_bug.cgi?id=194955
119
120         Reviewed by Tim Horton.
121
122         * Configurations/Base.xcconfig:
123         * Configurations/DebugRelease.xcconfig:
124
125 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
126
127         Hardcode Visual Viewports on everywhere except iOS WK1
128         https://bugs.webkit.org/show_bug.cgi?id=194928
129
130         Reviewed by Zalan Bujtas.
131
132         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
133         change the default value of the Setting to 'true', and hardcode WebView on iOS to
134         set it to false. The setting has shipped for several years and there's no need to turn
135         it off now.
136
137         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
138         Visual Viewports are not enabled.
139         
140         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
141         that only runs in WK2
142
143         * WebView/WebPreferenceKeysPrivate.h:
144         * WebView/WebPreferences.mm:
145         (+[WebPreferences initialize]):
146         (-[WebPreferences visualViewportEnabled]): Deleted.
147         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
148         * WebView/WebPreferencesPrivate.h:
149         * WebView/WebView.mm:
150         (-[WebView _preferencesChanged:]):
151
152 2019-02-21  Darin Adler  <darin@apple.com>
153
154         Some refinements for Node and Document
155         https://bugs.webkit.org/show_bug.cgi?id=194764
156
157         Reviewed by Ryosuke Niwa.
158
159         * DOM/DOMDocument.mm:
160         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
161         through to WebCore or even looking at the arguments.
162         (-[DOMDocument getOverrideStyle::]): Ditto.
163
164 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
165
166         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
167         https://bugs.webkit.org/show_bug.cgi?id=194670
168         <rdar://problem/39066529>
169
170         Reviewed by Tim Horton.
171
172         * WebCoreSupport/WebEditorClient.h:
173         * WebCoreSupport/WebEditorClient.mm:
174         (WebEditorClient::replacementURLForResource): Deleted.
175         * WebCoreSupport/WebPlatformStrategies.h:
176         * WebCoreSupport/WebPlatformStrategies.mm:
177         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
178
179 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
180
181         Add MSE logging configuration
182         https://bugs.webkit.org/show_bug.cgi?id=194719
183         <rdar://problem/48122151>
184
185         Reviewed by Joseph Pecoraro.
186
187         * WebCoreSupport/WebChromeClient.mm:
188         (stringForMessageSource): Recognize the MSE message source.
189
190 2019-02-17  David Kilzer  <ddkilzer@apple.com>
191
192         Unreviewed, rolling out r241620.
193
194         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
195         (Requested by ddkilzer on #webkit.)
196
197         Reverted changeset:
198
199         "[WTF] Add environment variable helpers"
200         https://bugs.webkit.org/show_bug.cgi?id=192405
201         https://trac.webkit.org/changeset/241620
202
203 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
204
205         [WTF] Add environment variable helpers
206         https://bugs.webkit.org/show_bug.cgi?id=192405
207
208         Reviewed by Michael Catanzaro.
209
210         * WebView/WebView.mm:
211         (-[WebView _initWithFrame:frameName:groupName:]):
212         Utilize WTF::Environment where possible.
213
214 2019-02-15  Brian Burg  <bburg@apple.com>
215
216         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
217         https://bugs.webkit.org/show_bug.cgi?id=194411
218         <rdar://problem/47787614>
219
220         Reviewed by Joseph Pecoraro.
221
222         * Configurations/WebKitLegacy.xcconfig:
223         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
224
225         * WebCoreSupport/WebInspectorClient.mm:
226         (WebInspectorFrontendClient::localizedStringsURL):
227         (-[WebInspectorWindowController inspectorPagePath]):
228         (-[WebInspectorWindowController inspectorTestPagePath]):
229         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
230
231 2019-02-15  Commit Queue  <commit-queue@webkit.org>
232
233         Unreviewed, rolling out r241559 and r241566.
234         https://bugs.webkit.org/show_bug.cgi?id=194710
235
236         Causes layout test crashes under GuardMalloc (Requested by
237         ryanhaddad on #webkit).
238
239         Reverted changesets:
240
241         "[WTF] Add environment variable helpers"
242         https://bugs.webkit.org/show_bug.cgi?id=192405
243         https://trac.webkit.org/changeset/241559
244
245         "Unreviewed build fix for WinCairo Debug after r241559."
246         https://trac.webkit.org/changeset/241566
247
248 2019-02-15  Truitt Savell  <tsavell@apple.com>
249
250         Unreviewed, rolling out r241564.
251
252         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
253
254         Reverted changeset:
255
256         "[Mac] WebInspectorUI.framework does not need to be soft-
257         linked anymore"
258         https://bugs.webkit.org/show_bug.cgi?id=194411
259         https://trac.webkit.org/changeset/241564
260
261 2019-02-14  Brian Burg  <bburg@apple.com>
262
263         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
264         https://bugs.webkit.org/show_bug.cgi?id=194411
265         <rdar://problem/47787614>
266
267         Reviewed by Joseph Pecoraro.
268
269         * Configurations/WebKitLegacy.xcconfig:
270         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
271
272         * WebCoreSupport/WebInspectorClient.mm:
273         (WebInspectorFrontendClient::localizedStringsURL):
274         (-[WebInspectorWindowController inspectorPagePath]):
275         (-[WebInspectorWindowController inspectorTestPagePath]):
276         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
277
278 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
279
280         [WTF] Add environment variable helpers
281         https://bugs.webkit.org/show_bug.cgi?id=192405
282
283         Reviewed by Michael Catanzaro.
284
285         * WebView/WebView.mm:
286         (-[WebView _initWithFrame:frameName:groupName:]):
287         Utilize WTF::Environment where possible.
288
289 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
290
291         Allow pages to trigger programmatic paste from script on iOS
292         https://bugs.webkit.org/show_bug.cgi?id=194271
293         <rdar://problem/47808810>
294
295         Reviewed by Ryosuke Niwa.
296
297         See WebCore and WebKit ChangeLogs for more details.
298
299         * WebCoreSupport/WebEditorClient.h:
300
301 2019-02-12  Andy Estes  <aestes@apple.com>
302
303         [iOSMac] Enable Parental Controls Content Filtering
304         https://bugs.webkit.org/show_bug.cgi?id=194521
305         <rdar://39732376>
306
307         Reviewed by Tim Horton.
308
309         * Configurations/FeatureDefines.xcconfig:
310
311 2019-02-06  Andy Estes  <aestes@apple.com>
312
313         [Payment Request] It should be possible to require a phonetic name for shipping contacts
314         https://bugs.webkit.org/show_bug.cgi?id=194311
315         <rdar://46733045>
316
317         Reviewed by Alex Christensen.
318
319         * WebCoreSupport/WebPaymentCoordinatorClient.h:
320         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
321         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
322
323 2019-02-04  Said Abou-Hallawa  <said@apple.com>
324
325         [CG] Enable setAdditionalSupportedImageTypes for WK1
326         https://bugs.webkit.org/show_bug.cgi?id=194190
327
328         Reviewed by Tim Horton.
329
330         1. Define the preferences key AdditionalSupportedImageTypes.
331         2. Add additionalSupportedImageTypes as a private preference property.
332         3. Define the setter and the getter of the property.
333         4. Add function to convert from an id to an array of strings.
334         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
335
336         * WebView/WebPreferenceKeysPrivate.h:
337         * WebView/WebPreferences.mm:
338         (-[WebPreferences _stringArrayValueForKey:]):
339         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
340         (-[WebPreferences setAdditionalSupportedImageTypes:]):
341         (-[WebPreferences additionalSupportedImageTypes]):
342         * WebView/WebPreferencesPrivate.h:
343         * WebView/WebView.mm:
344         (-[WebView _preferencesChanged:]):
345
346 2019-02-04  Timothy Hatcher  <timothy@apple.com>
347
348         Add WebView SPI to temporarily force light or dark appearance on a page.
349         https://bugs.webkit.org/show_bug.cgi?id=194230
350
351         Reviewed by Tim Horton.
352
353         * WebView/WebView.mm:
354         (-[WebView _useDarkAppearance:]): Added.
355         (-[WebView _setUseDarkAppearance:]): Added.
356         * WebView/WebViewPrivate.h:
357
358 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
359
360         PageOverlayController's layers should be created lazily
361         https://bugs.webkit.org/show_bug.cgi?id=194199
362         rdar://problem/46571593
363
364         Reviewed by Tim Horton.
365
366         * WebCoreSupport/WebChromeClient.h:
367         * WebCoreSupport/WebChromeClient.mm:
368         (WebChromeClient::attachViewOverlayGraphicsLayer):
369
370 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
371
372         Make setNeedsLayout on the root more explicitly about triggering its side-effects
373         https://bugs.webkit.org/show_bug.cgi?id=194198
374
375         Reviewed by Antti Koivisto.
376
377         Call the newly named functions.
378
379         * WebView/WebFrame.mm:
380         (-[WebFrame setNeedsLayout]):
381         * WebView/WebHTMLView.mm:
382         (-[WebHTMLView setNeedsLayout:]):
383
384 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
385
386         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
387         https://bugs.webkit.org/show_bug.cgi?id=194189
388
389         Reviewed by Geoffrey Garen.
390
391         Pass the policy check identifier around functions and store it in WebFramePolicyListener
392         so that we can send it back to WebCore with the navigation policy decision.
393
394         * WebCoreSupport/WebFrameLoaderClient.h:
395         * WebCoreSupport/WebFrameLoaderClient.mm:
396         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
397         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
398         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
399         (WebFrameLoaderClient::dispatchWillSubmitForm):
400         (WebFrameLoaderClient::setUpPolicyListener):
401         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
402         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
403         (-[WebFramePolicyListener invalidate]):
404         (-[WebFramePolicyListener dealloc]):
405         (-[WebFramePolicyListener receivedPolicyDecision:]):
406         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
407         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
408
409 2019-01-31  Alex Christensen  <achristensen@webkit.org>
410
411         Revert r238819 which is unneeded and caused a performance regression.
412         https://bugs.webkit.org/show_bug.cgi?id=192272
413         <rdar://problem/46664625>
414
415         * WebCoreSupport/WebFrameLoaderClient.h:
416         * WebCoreSupport/WebFrameLoaderClient.mm:
417         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
418
419 2019-01-28  Devin Rousso  <drousso@apple.com>
420
421         Web Inspector: provide a way to edit page WebRTC settings on a remote target
422         https://bugs.webkit.org/show_bug.cgi?id=193863
423         <rdar://problem/47572764>
424
425         Reviewed by Joseph Pecoraro.
426
427         * WebView/WebView.mm:
428         (-[WebView _preferencesChanged:]):
429         Add page-level settings for WebRTC preferences.
430
431 2019-01-28  Andy Estes  <aestes@apple.com>
432
433         [watchOS] Enable Parental Controls content filtering
434         https://bugs.webkit.org/show_bug.cgi?id=193939
435         <rdar://problem/46641912>
436
437         Reviewed by Ryosuke Niwa.
438
439         * Configurations/FeatureDefines.xcconfig:
440
441 2019-01-28  Timothy Hatcher  <timothy@apple.com>
442
443         Make it easier for non-Apple ports to enable dark mode CSS support.
444         https://bugs.webkit.org/show_bug.cgi?id=193882
445
446         Reviewed by Megan Gardner.
447
448         * WebView/WebView.mm:
449         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
450         (-[WebView _effectiveAppearanceIsDark]): Ditto.
451
452 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
453
454         AX: Introduce a static accessibility tree
455         https://bugs.webkit.org/show_bug.cgi?id=193348
456         <rdar://problem/47203295>
457
458         Reviewed by Ryosuke Niwa.
459
460         * Configurations/FeatureDefines.xcconfig:
461
462 2019-01-25  Keith Rollin  <krollin@apple.com>
463
464         Update WebKitAdditions.xcconfig with correct order of variable definitions
465         https://bugs.webkit.org/show_bug.cgi?id=193793
466         <rdar://problem/47532439>
467
468         Reviewed by Alex Christensen.
469
470         XCBuild changes the way xcconfig variables are evaluated. In short,
471         all config file assignments are now considered in part of the
472         evaluation. When using the new build system and an .xcconfig file
473         contains multiple assignments of the same build setting:
474
475         - Later assignments using $(inherited) will inherit from earlier
476           assignments in the xcconfig file.
477         - Later assignments not using $(inherited) will take precedence over
478           earlier assignments. An assignment to a more general setting will
479           mask an earlier assignment to a less general setting. For example,
480           an assignment without a condition ('FOO = bar') will completely mask
481           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
482
483         This affects some of our .xcconfig files, in that sometimes platform-
484         or sdk-specific definitions appear before the general definitions.
485         Under the new evaluations rules, the general definitions alway take
486         effect because they always overwrite the more-specific definitions. The
487         solution is to swap the order, so that the general definitions are
488         established first, and then conditionally overwritten by the
489         more-specific definitions.
490
491         * Configurations/Version.xcconfig:
492         * Configurations/WebKitLegacy.xcconfig:
493
494 2019-01-25  David Kilzer  <ddkilzer@apple.com>
495
496         Move soft-linking of Lookup.framework out of LookupSPI.h
497         <https://webkit.org/b/193815>
498
499         Reviewed by Tim Horton.
500
501         * WebView/WebImmediateActionController.mm:
502         (-[WebImmediateActionController _animationControllerForText]):
503         * WebView/WebView.mm:
504         (-[WebView _prepareForDictionaryLookup]):
505         - Move soft-linking to LookupSoftLink.{h,mm}.
506
507 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
508
509         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
510         https://bugs.webkit.org/show_bug.cgi?id=193829
511
512         Reviewed by Tim Horton.
513
514         * WebCoreSupport/WebDragClient.mm:
515         (WebDragClient::didConcludeEditDrag):
516         * WebView/WebView.mm:
517         (-[WebView _requestStartDataInteraction:globalPosition:]):
518         (-[WebView _didConcludeEditDrag]):
519         (-[WebView _didConcludeEditDataInteraction]): Deleted.
520         * WebView/WebViewInternal.h:
521
522 2019-01-24  John Wilander  <wilander@apple.com>
523
524         Add Ad Click Attribution as an internal/experimental feature
525         https://bugs.webkit.org/show_bug.cgi?id=193685
526         <rdar://problem/47450399>
527
528         Reviewed by Brent Fulgham.
529
530         * WebView/WebPreferenceKeysPrivate.h:
531         * WebView/WebPreferences.mm:
532         (+[WebPreferences initialize]):
533         (-[WebPreferences adClickAttributionEnabled]):
534         (-[WebPreferences setAdClickAttributionEnabled:]):
535             Added support for experimental ad click attribution.
536         * WebView/WebPreferencesPrivate.h:
537         * WebView/WebView.mm:
538         (-[WebView _preferencesChanged:]):
539
540 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
541
542         Move FileSystem to WTF
543         https://bugs.webkit.org/show_bug.cgi?id=193602
544
545         Reviewed by Yusuke Suzuki.
546
547         * Misc/WebNSFileManagerExtras.mm:
548         * Storage/WebDatabaseProvider.mm:
549         * WebView/WebView.mm:
550
551 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
552
553         Fix the Apple Internal build. See <rdar://problem/47491383>.
554
555         Rubber-stamped by Tim Horton.
556
557         * WebCoreSupport/WebFrameLoaderClient.mm:
558
559 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
560
561         Clean up USE(WEB_THREAD)
562         https://bugs.webkit.org/show_bug.cgi?id=193698
563
564         Rubber-stamped by Tim Horton.
565
566         * Misc/WebCache.mm:
567         (+[WebCache emptyInMemoryResources]):
568         * WebCoreSupport/WebFrameLoaderClient.mm:
569         (-[WebFramePolicyListener use]):
570         * WebCoreSupport/WebGeolocationClient.mm:
571         (-[WebGeolocationPolicyListener allow]):
572         (-[WebGeolocationPolicyListener deny]):
573         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
574         * WebView/WebFrame.mm:
575         (-[WebFrame deviceOrientationChanged]):
576         * WebView/WebHTMLView.mm:
577         (hardwareKeyboardAvailabilityChangedCallback):
578         * WebView/WebView.mm:
579         (+[WebView _releaseMemoryNow]):
580         (+[WebView willEnterBackgroundWithCompletionHandler:]):
581         (-[WebView updateLayoutIgnorePendingStyleSheets]):
582         (-[WebView _dispatchUnloadEvent]):
583         (-[WebView _close]):
584         (-[WebView _preferencesChangedNotification:]):
585         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
586         (-[WebView goBack]):
587         (-[WebView goForward]):
588         (+[WebView _cacheModelChangedNotification:]):
589         (-[WebView stopLoading:]):
590         (-[WebView stopLoadingAndClear]):
591         (-[WebView reload:]):
592         (WebInstallMemoryPressureHandler):
593
594 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
595
596         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
597         https://bugs.webkit.org/show_bug.cgi?id=193706
598         <rdar://problem/44807048>
599
600         Reviewed by Ryosuke Niwa.
601
602         Use UndoStep::label().
603
604         * WebCoreSupport/WebEditorClient.h:
605         * WebCoreSupport/WebEditorClient.mm:
606         (-[WebUndoStep initWithUndoStep:]):
607         (+[WebUndoStep stepWithUndoStep:]):
608         (WebEditorClient::registerUndoOrRedoStep):
609         (WebEditorClient::registerUndoStep):
610         (WebEditorClient::registerRedoStep):
611
612 2019-01-22  Alex Christensen  <achristensen@webkit.org>
613
614         Move NetworkStorageSession ownership to NetworkProcess
615         https://bugs.webkit.org/show_bug.cgi?id=193580
616
617         Reviewed by Geoff Garen.
618
619         * Misc/WebCache.mm:
620         (+[WebCache clearCachedCredentials]):
621         * Misc/WebDownload.mm:
622         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
623         * Plugins/WebBaseNetscapePluginView.mm:
624         (WebKit::getAuthenticationInfo):
625         * WebCoreSupport/WebFrameNetworkingContext.mm:
626         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
627         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
628         (WebFrameNetworkingContext::storageSession const):
629         * WebView/WebPreferences.mm:
630         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
631         (+[WebPreferences _clearNetworkLoaderSession]):
632         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
633
634 2019-01-22  Daniel Bates  <dabates@apple.com>
635
636         [iOS] Interpret text key commands on keydown and app key commands on keypress
637         https://bugs.webkit.org/show_bug.cgi?id=192897
638         <rdar://problem/46857378>
639
640         Reviewed by Brent Fulgham.
641
642         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
643         is false) and keypress (isCharEvent is true), respectively.
644
645         * WebView/WebHTMLView.mm:
646         (-[WebHTMLView _handleEditingKeyEvent:]):
647
648 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
649
650         [css-logical] Implement flow-relative margin, padding and border shorthands
651         https://bugs.webkit.org/show_bug.cgi?id=188697
652
653         Reviewed by Simon Fraser and Antti Koivisto.
654
655         Add CSSLogicalEnabled runtime flag.
656
657         * WebView/WebPreferenceKeysPrivate.h:
658         * WebView/WebPreferences.mm:
659         (+[WebPreferences initialize]):
660         (-[WebPreferences cssLogicalEnabled]):
661         (-[WebPreferences setCSSLogicalEnabled:]):
662         * WebView/WebPreferencesPrivate.h:
663         * WebView/WebView.mm:
664         (-[WebView _preferencesChanged:]):
665
666 2019-01-15  Darin Adler  <darin@apple.com>
667
668         Use references rather than pointers for register/unregister functions, and more
669         https://bugs.webkit.org/show_bug.cgi?id=175028
670
671         Reviewed by Daniel Bates.
672
673         * WebCoreSupport/WebKitFullScreenListener.mm:
674         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
675         functions in Document; pass a reference.
676         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
677         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
678         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
679         * WebView/WebFullScreenController.mm:
680         (-[WebFullScreenController enterFullScreen:]): Ditto.
681         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
682         (-[WebFullScreenController exitFullScreen]): Ditto.
683         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
684         * WebView/WebFullScreenController.mm:
685         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
686
687 2019-01-12  Dan Bernstein  <mitz@apple.com>
688
689         [Cocoa] Avoid importing directly from subumbrella frameworks
690         https://bugs.webkit.org/show_bug.cgi?id=186016
691         <rdar://problem/40591038>
692
693         Reviewed by Sam Weinig.
694
695         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
696         * Carbon/CarbonWindowAdapter.mm: Ditto.
697         * Carbon/CarbonWindowFrame.m: Ditto.
698         * Carbon/HIViewAdapter.h: Ditto.
699         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
700           OTHER_CFLAGS_COCOA_TOUCH_NO.
701         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
702         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
703         * WebView/WebPDFView.h: Ditto.
704
705 2019-01-20  Antoine Quint  <graouts@apple.com>
706
707         Add a POINTER_EVENTS feature flag
708         https://bugs.webkit.org/show_bug.cgi?id=193577
709         <rdar://problem/47408511>
710
711         Unreviewed. Also enable Pointer Events for iosmac.
712
713         * Configurations/FeatureDefines.xcconfig:
714
715 2019-01-19  Antoine Quint  <graouts@apple.com>
716
717         Add a POINTER_EVENTS feature flag
718         https://bugs.webkit.org/show_bug.cgi?id=193577
719
720         Reviewed by Dean Jackson.
721
722         * Configurations/FeatureDefines.xcconfig:
723
724 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
725
726         Revert r238815, it broke WK1 video fullscreen on Mac
727         https://bugs.webkit.org/show_bug.cgi?id=193586
728         <rdar://problem/47358941>
729
730         Reviewed by Jer Noble.
731
732         * WebView/WebVideoFullscreenController.h: Added.
733         * WebView/WebVideoFullscreenController.mm: Added.
734         (SOFT_LINK_CLASS):
735         (-[WebVideoFullscreenController init]):
736         (-[WebVideoFullscreenController dealloc]):
737         (-[WebVideoFullscreenController fullscreenWindow]):
738         (-[WebVideoFullscreenController windowDidLoad]):
739         (-[WebVideoFullscreenController videoElement]):
740         (-[WebVideoFullscreenController setVideoElement:]):
741         (-[WebVideoFullscreenController clearFadeAnimation]):
742         (-[WebVideoFullscreenController windowDidExitFullscreen]):
743         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
744         (-[WebVideoFullscreenController videoElementRect]):
745         (-[WebVideoFullscreenController applicationDidResignActive:]):
746         (frameExpandedToRatioOfFrame):
747         (createBackgroundFullscreenWindow):
748         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
749         (-[WebVideoFullscreenController enterFullscreen:]):
750         (-[WebVideoFullscreenController exitFullscreen]):
751         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
752         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
753         (-[WebVideoFullscreenController _requestExit]):
754         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
755         (-[WebVideoFullscreenController requestExitFullscreen]):
756         (-[WebVideoFullscreenController fadeHUDIn]):
757         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
758         (-[WebVideoFullscreenController rateChanged:]):
759         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
760         (-[WebVideoFullscreenWindow dealloc]):
761         (-[WebVideoFullscreenWindow resignFirstResponder]):
762         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
763         (-[WebVideoFullscreenWindow mouseDown:]):
764         (-[WebVideoFullscreenWindow cancelOperation:]):
765         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
766         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
767         (-[WebVideoFullscreenWindow animationDidEnd:]):
768         (-[WebVideoFullscreenWindow mouseMoved:]):
769         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
770         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
771         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
772         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
773         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
774         (-[WebVideoFullscreenHUDWindow center]):
775         (-[WebVideoFullscreenHUDWindow keyDown:]):
776         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
777         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
778         (-[WebVideoFullscreenHUDWindowController init]):
779         (-[WebVideoFullscreenHUDWindowController dealloc]):
780         (-[WebVideoFullscreenHUDWindowController setArea:]):
781         (-[WebVideoFullscreenHUDWindowController keyDown:]):
782         (-[WebVideoFullscreenHUDWindowController delegate]):
783         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
784         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
785         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
786         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
787         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
788         (-[WebVideoFullscreenHUDWindowController closeWindow]):
789         (createMediaUIControl):
790         (createControlWithMediaUIControlType):
791         (createTimeTextField):
792         (createMediaUIBackgroundView):
793         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
794         (-[WebVideoFullscreenHUDWindowController updateVolume]):
795         (-[WebVideoFullscreenHUDWindowController updateTime]):
796         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
797         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
798         (-[WebVideoFullscreenHUDWindowController currentTime]):
799         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
800         (-[WebVideoFullscreenHUDWindowController duration]):
801         (-[WebVideoFullscreenHUDWindowController maxVolume]):
802         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
803         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
804         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
805         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
806         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
807         (-[WebVideoFullscreenHUDWindowController volume]):
808         (-[WebVideoFullscreenHUDWindowController setVolume:]):
809         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
810         (-[WebVideoFullscreenHUDWindowController updateRate]):
811         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
812         (-[WebVideoFullscreenHUDWindowController playing]):
813         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
814         (timeToString):
815         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
816         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
817         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
818         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
819         (-[WebVideoFullscreenHUDWindowController rewind:]):
820         (-[WebVideoFullscreenHUDWindowController fastForward:]):
821         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
822         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
823         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
824         * WebView/WebView.mm:
825         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
826         (-[WebView _exitVideoFullscreen]):
827
828 2019-01-18  Tim Horton  <timothy_horton@apple.com>
829
830         Get rid of ADVANCED_SPELL_CHECKING
831         https://bugs.webkit.org/show_bug.cgi?id=193592
832
833         Reviewed by Wenson Hsieh.
834
835         * WebCoreSupport/WebEditorClient.mm:
836         (insertionPointFromCurrentSelection):
837         (WebEditorClient::checkTextOfParagraph):
838         (WebEditorClient::getGuessesForWord):
839         (WebEditorClient::requestCandidatesForSelection):
840         (WebEditorClient::requestCheckingOfString):
841         * WebView/WebHTMLView.mm:
842         (-[WebHTMLView insertText:]):
843
844 2019-01-18  Jer Noble  <jer.noble@apple.com>
845
846         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
847         https://bugs.webkit.org/show_bug.cgi?id=189553
848
849         Reviewed by Tim Horton.
850
851         * Configurations/Base.xcconfig:
852         * Configurations/SDKVariant.xcconfig: Added.
853         * Configurations/WebKitLegacy.xcconfig:
854
855 2019-01-18  David Kilzer  <ddkilzer@apple.com>
856
857         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
858         <https://webkit.org/b/193568>
859         <rdar://problem/47381130>
860
861         Reviewed by Alex Christensen.
862
863         * WebView/WebView.mm:
864         - Remove unused soft-linking macros.
865         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
866         (-[WebUITextIndicatorData initWithImage:scale:]):
867         - Update to use exported PAL functions.
868
869 2019-01-17  Truitt Savell  <tsavell@apple.com>
870
871         Unreviewed, rolling out r240124.
872
873         This commit broke an internal build.
874
875         Reverted changeset:
876
877         "SDK_VARIANT build destinations should be separate from non-
878         SDK_VARIANT builds"
879         https://bugs.webkit.org/show_bug.cgi?id=189553
880         https://trac.webkit.org/changeset/240124
881
882 2019-01-17  Jer Noble  <jer.noble@apple.com>
883
884         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
885         https://bugs.webkit.org/show_bug.cgi?id=189553
886
887         Reviewed by Tim Horton.
888
889         * Configurations/Base.xcconfig:
890         * Configurations/SDKVariant.xcconfig: Added.
891         * Configurations/WebKitLegacy.xcconfig:
892
893 2019-01-17  Alex Christensen  <achristensen@webkit.org>
894
895         Stop using NetworkStorageSession::storageSession in WebCore
896         https://bugs.webkit.org/show_bug.cgi?id=193529
897
898         Reviewed by Tim Horton.
899
900         * Misc/WebCache.mm:
901         (+[WebCache addImageToCache:forURL:forFrame:]):
902         * WebView/WebView.mm:
903         (-[WebView _commonInitializationWithFrameName:groupName:]):
904         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
905
906 2019-01-15  Alex Christensen  <achristensen@webkit.org>
907
908         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
909         https://bugs.webkit.org/show_bug.cgi?id=193368
910
911         Reviewed by Geoff Garen.
912
913         * Misc/WebCache.mm:
914         (+[WebCache clearCachedCredentials]):
915         * Misc/WebDownload.mm:
916         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
917         * Plugins/WebBaseNetscapePluginView.mm:
918         (WebKit::getAuthenticationInfo):
919
920 2019-01-15  Alex Christensen  <achristensen@webkit.org>
921
922         Stop using CookiesStrategy
923         https://bugs.webkit.org/show_bug.cgi?id=161106
924
925         Reviewed by Don Olmstead and Antti Koivisto.
926
927         * Misc/WebCache.mm:
928         (+[WebCache addImageToCache:forURL:forFrame:]):
929         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
930         (WebKit::NetscapePluginInstanceProxy::getCookies):
931         (WebKit::NetscapePluginInstanceProxy::setCookies):
932         * Plugins/WebNetscapePluginView.mm:
933         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
934         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
935         * WebCoreSupport/WebPlatformStrategies.h:
936         * WebCoreSupport/WebPlatformStrategies.mm:
937         (WebPlatformStrategies::createCookiesStrategy): Deleted.
938         (WebPlatformStrategies::cookiesForDOM): Deleted.
939         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
940         (WebPlatformStrategies::cookiesEnabled): Deleted.
941         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
942         (WebPlatformStrategies::getRawCookies): Deleted.
943         (WebPlatformStrategies::deleteCookie): Deleted.
944         * WebView/WebView.mm:
945         (-[WebView _commonInitializationWithFrameName:groupName:]):
946         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
947
948 2019-01-15  Tim Horton  <timothy_horton@apple.com>
949
950         Cannot tab out of WKWebView on macOS
951         https://bugs.webkit.org/show_bug.cgi?id=161448
952         <rdar://problem/28100085>
953
954         Reviewed by Dean Jackson.
955
956         * WebCoreSupport/WebChromeClient.mm:
957         * WebView/WebView.mm:
958         Make use of SPI headers.
959
960 2019-01-14  Commit Queue  <commit-queue@webkit.org>
961
962         Unreviewed, rolling out r239901, r239909, r239910, r239912,
963         r239913, and r239914.
964         https://bugs.webkit.org/show_bug.cgi?id=193407
965
966         These revisions caused an internal failure (Requested by
967         Truitt on #webkit).
968
969         Reverted changesets:
970
971         "[Cocoa] Avoid importing directly from subumbrella frameworks"
972         https://bugs.webkit.org/show_bug.cgi?id=186016
973         https://trac.webkit.org/changeset/239901
974
975         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
976         https://trac.webkit.org/changeset/239909
977
978         "Tried to fix the build."
979         https://trac.webkit.org/changeset/239910
980
981         "Fixed iOS builds after r239910."
982         https://trac.webkit.org/changeset/239912
983
984         "More build fixing."
985         https://trac.webkit.org/changeset/239913
986
987         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
988         https://trac.webkit.org/changeset/239914
989
990 2019-01-14  Mark Lam  <mark.lam@apple.com>
991
992         Re-enable ability to build --cloop builds.
993         https://bugs.webkit.org/show_bug.cgi?id=192955
994         <rdar://problem/46882363>
995
996         Reviewed by Saam barati and Keith Miller.
997
998         * Configurations/FeatureDefines.xcconfig:
999
1000 2019-01-13  Dan Bernstein  <mitz@apple.com>
1001
1002         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1003
1004         Patch by Keith Rollin.
1005
1006         * WebView/PDFViewSPI.h:
1007
1008 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1009
1010         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1011         https://bugs.webkit.org/show_bug.cgi?id=191655
1012         rdar://problem/46074680
1013
1014         Reviewed by Megan Gardner.
1015
1016         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1017         * WebView/WebView.mm:
1018         (-[WebView _effectiveAppearanceIsDark]):
1019
1020 2019-01-12  Dan Bernstein  <mitz@apple.com>
1021
1022         [Cocoa] Avoid importing directly from subumbrella frameworks
1023         https://bugs.webkit.org/show_bug.cgi?id=186016
1024         <rdar://problem/40591038>
1025
1026         Reviewed by Sam Weinig.
1027
1028         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1029         * Carbon/CarbonWindowAdapter.mm: Ditto.
1030         * Carbon/CarbonWindowFrame.m: Ditto.
1031         * Carbon/HIViewAdapter.h: Ditto.
1032         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1033           OTHER_CFLAGS_COCOA_TOUCH_NO.
1034         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1035         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1036         * WebView/WebPDFView.h: Ditto.
1037
1038 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1039
1040         Enable visual viewport API by default
1041         https://bugs.webkit.org/show_bug.cgi?id=193376
1042
1043         Reviewed by Simon Fraser.
1044
1045         * WebView/WebPreferences.mm:
1046         (+[WebPreferences initialize]):
1047
1048 2019-01-11  John Wilander  <wilander@apple.com>
1049
1050         Compile out Web API Statistics Collection
1051         https://bugs.webkit.org/show_bug.cgi?id=193370
1052         <rdar://problem/45388584>
1053
1054         Reviewed by Brent Fulgham.
1055
1056         * Configurations/FeatureDefines.xcconfig:
1057             Defined ENABLE_WEB_API_STATISTICS, off by default.
1058
1059 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1060
1061         Stop using NetworkStorageSession in WebProcess
1062         https://bugs.webkit.org/show_bug.cgi?id=193236
1063
1064         Reviewed by Don Olmstead.
1065
1066         * WebCoreSupport/WebFrameNetworkingContext.h:
1067         * WebCoreSupport/WebFrameNetworkingContext.mm:
1068         (WebFrameNetworkingContext::storageSession const):
1069         * WebCoreSupport/WebPlatformStrategies.h:
1070         * WebCoreSupport/WebPlatformStrategies.mm:
1071         (WebPlatformStrategies::cookiesForDOM):
1072         (WebPlatformStrategies::setCookiesFromDOM):
1073         (WebPlatformStrategies::cookiesEnabled):
1074         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1075         (WebPlatformStrategies::getRawCookies):
1076         (WebPlatformStrategies::deleteCookie):
1077         * WebView/WebView.mm:
1078         (-[WebView _cachedResponseForURL:]):
1079         (-[WebView _clearCredentials]):
1080
1081 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1082
1083         Unreviewed, rolling out r239727.
1084
1085         Broke API tests
1086
1087         Reverted changeset:
1088
1089         "Stop using NetworkStorageSession in WebProcess"
1090         https://bugs.webkit.org/show_bug.cgi?id=193236
1091         https://trac.webkit.org/changeset/239727
1092
1093 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1094
1095         Stop using NetworkStorageSession in WebProcess
1096         https://bugs.webkit.org/show_bug.cgi?id=193236
1097
1098         Reviewed by Don Olmstead.
1099
1100         * WebCoreSupport/WebFrameNetworkingContext.h:
1101         * WebCoreSupport/WebFrameNetworkingContext.mm:
1102         (WebFrameNetworkingContext::storageSession const):
1103         * WebView/WebView.mm:
1104         (-[WebView _cachedResponseForURL:]):
1105         (-[WebView _clearCredentials]):
1106
1107 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1108
1109         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1110         <https://webkit.org/b/193056>
1111
1112         Reviewed by Alex Christensen.
1113
1114         * Plugins/Hosted/NetscapePluginHostProxy.h:
1115         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1116         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1117         (WebKit::NetscapePluginInstanceProxy::enumerate):
1118         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1119         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1120         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1121         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1122         * Plugins/Hosted/ProxyInstance.mm:
1123         (WebKit::ProxyInstance::invoke):
1124         * WebCoreSupport/WebGeolocationClient.mm:
1125         * WebView/WebDataSource.mm:
1126         (-[WebDataSource _receivedData:]):
1127         * WebView/WebView.mm:
1128         (-[WebView _cachedResponseForURL:]):
1129         - Remove '*' from RetainPtr<> type.
1130
1131 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1132
1133         Progress towards fixing Mac CMake build
1134         https://bugs.webkit.org/show_bug.cgi?id=193105
1135
1136         Reviewed by Don Olmstead.
1137
1138         * WebKitPrefix.h:
1139
1140 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1141
1142         Web Inspector: Use save sheet instead of dialog where possible
1143         https://bugs.webkit.org/show_bug.cgi?id=193160
1144         <rdar://problem/37399759>
1145
1146         Reviewed by Devin Rousso.
1147
1148         * WebCoreSupport/WebInspectorClient.mm:
1149         (WebInspectorFrontendClient::save):
1150
1151 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1152
1153         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1154         https://bugs.webkit.org/show_bug.cgi?id=193129
1155
1156         Reviewed by Tim Horton.
1157
1158         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1159
1160         * WebCoreSupport/WebEditorClient.mm:
1161         (WebEditorClient::registerUndoOrRedoStep):
1162         (undoNameForEditAction): Deleted.
1163
1164 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1165
1166         Add support for using the current text selection as the find string on iOS
1167         https://bugs.webkit.org/show_bug.cgi?id=193034
1168         <rdar://problem/45138739>
1169
1170         Reviewed by Tim Horton.
1171
1172         Add a method stub for WebKitLegacy.
1173
1174         * WebCoreSupport/WebEditorClient.h:
1175
1176 2019-01-01  Jeff Miller  <jeffm@apple.com>
1177
1178         Update user-visible copyright strings to include 2019
1179         https://bugs.webkit.org/show_bug.cgi?id=192811
1180
1181         Reviewed by Mark Lam.
1182
1183         * Info.plist:
1184
1185 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1186
1187         Use Ref<> as much as possible
1188         https://bugs.webkit.org/show_bug.cgi?id=192808
1189
1190         Reviewed by Alex Christensen.
1191
1192         * DOM/DOM.mm:
1193         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1194         * Plugins/Hosted/NetscapePluginHostManager.mm:
1195         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1196         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1197         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1198         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1199         * Plugins/WebNetscapePluginView.mm:
1200         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1201         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1202         * WebCoreSupport/WebContextMenuClient.mm:
1203         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1204         * WebCoreSupport/WebFrameLoaderClient.mm:
1205         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1206         * WebView/WebFrame.mm:
1207         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1208         * WebView/WebHTMLView.mm:
1209         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1210         * WebView/WebView.mm:
1211         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1212         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1213
1214 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1215
1216         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1217         https://bugs.webkit.org/show_bug.cgi?id=192821
1218
1219         Reviewed by Chris Dumez.
1220
1221         When a window becomes occluded, the window server informs the application.
1222         This should be used to suspend any work that is not visible by the user.
1223
1224         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1225         In some cases, that lead to performance impact (see radar).
1226
1227         This patch adds an observer for the occlusion notification. I tried to stick
1228         with the same names used by WebKit2.
1229
1230         * WebView/WebView.mm:
1231         (-[WebView _isViewVisible]):
1232         (-[WebView addWindowObserversForWindow:]):
1233         (-[WebView removeWindowObservers]):
1234         (-[WebView _windowDidChangeOcclusionState:]):
1235
1236 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1237
1238         [WebAuthN] Add a runtime flag for local authenticator
1239         https://bugs.webkit.org/show_bug.cgi?id=192792
1240         <rdar://problem/46798738>
1241
1242         Reviewed by Brent Fulgham.
1243
1244         * WebView/WebPreferenceKeysPrivate.h:
1245         * WebView/WebPreferences.mm:
1246         (+[WebPreferences initialize]):
1247         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1248         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1249         * WebView/WebPreferencesPrivate.h:
1250         * WebView/WebView.mm:
1251         (-[WebView _preferencesChanged:]):
1252
1253 2018-12-20  Chris Dumez  <cdumez@apple.com>
1254
1255         Use Optional::valueOr() instead of Optional::value_or()
1256         https://bugs.webkit.org/show_bug.cgi?id=192933
1257
1258         Reviewed by Geoffrey Garen.
1259
1260         * WebCoreSupport/WebSecurityOrigin.mm:
1261         (-[WebSecurityOrigin port]):
1262
1263 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1264
1265         Unreviewed, rolling out r239417.
1266
1267         Introduced two API test failures on macOS.
1268
1269         Reverted changeset:
1270
1271         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1272         occlusion changes"
1273         https://bugs.webkit.org/show_bug.cgi?id=192821
1274         https://trac.webkit.org/changeset/239417
1275
1276 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1277
1278         WKWebView default UA doesn't freeze the build number
1279         https://bugs.webkit.org/show_bug.cgi?id=192809
1280         <rdar://problem/44687185>
1281
1282         Reviewed by Andy Estes.
1283
1284         Always reports the frozen build number.
1285
1286         * WebView/WebView.mm:
1287         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1288         actual build number through this method call.
1289         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1290
1291 2018-12-19  Chris Dumez  <cdumez@apple.com>
1292
1293         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1294         https://bugs.webkit.org/show_bug.cgi?id=192728
1295         <rdar://problem/46746779>
1296
1297         Reviewed by Geoff Garen.
1298
1299         * DOM/*:
1300         * Plugins/*:
1301         * WebCoreSupport/*:
1302         * WebView/*:
1303
1304 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1305
1306         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1307         https://bugs.webkit.org/show_bug.cgi?id=192821
1308
1309         Reviewed by Chris Dumez.
1310
1311         When a window becomes occluded, the window server informs the application.
1312         This should be used to suspend any work that is not visible by the user.
1313
1314         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1315         In some cases, that lead to performance impact (see radar).
1316
1317         This patch adds an observer for the occlusion notification. I tried to stick
1318         with the same names used by WebKit2.
1319
1320         * WebView/WebView.mm:
1321         (-[WebView _isViewVisible]):
1322         (-[WebView addWindowObserversForWindow:]):
1323         (-[WebView removeWindowObservers]):
1324         (-[WebView _windowDidChangeOcclusionState:]):
1325
1326 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1327
1328         Allow clients to set the navigator platform
1329         https://bugs.webkit.org/show_bug.cgi?id=192735
1330
1331         Reviewed by Tim Horton.
1332
1333         Add stubs to fill out the added functionality in FrameLoaderClient.
1334
1335         * WebCoreSupport/WebFrameLoaderClient.h:
1336         * WebCoreSupport/WebFrameLoaderClient.mm:
1337         (WebFrameLoaderClient::navigatorPlatform):
1338
1339 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1340
1341         offsetLeft and offsetParent should adjust across shadow boundaries
1342         https://bugs.webkit.org/show_bug.cgi?id=157437
1343         <rdar://problem/26154021>
1344
1345         Reviewed by Simon Fraser.
1346
1347         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1348
1349         * DOM/DOMElement.mm:
1350         (-[DOMElement offsetLeft]):
1351         (-[DOMElement offsetTop]):
1352         (-[DOMElement offsetParent]):
1353
1354 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1355
1356         Unreviewed build fix.
1357
1358         * WebView/WebFrame.mm:
1359         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1360
1361 2018-12-15  Darin Adler  <darin@apple.com>
1362
1363         Use warning-ignoring macros more consistently and simply
1364         https://bugs.webkit.org/show_bug.cgi?id=192743
1365
1366         Reviewed by Mark Lam.
1367
1368         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1369         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1370         compilers in Objective-C++ code.
1371
1372         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1373         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1374         accomodate non-clang compilers here. Also use #pragma once, add a missing
1375         "explicit" and fix conditionals.
1376
1377 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1378
1379         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1380         https://bugs.webkit.org/show_bug.cgi?id=192653
1381
1382         Reviewed by Wenson Hsieh.
1383
1384         * WebView/WebHTMLView.mm:
1385         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1386
1387 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1388
1389         Implement feature flag for CSS Typed OM
1390         https://bugs.webkit.org/show_bug.cgi?id=192610
1391
1392         Reviewed by Ryosuke Niwa.
1393
1394         * Configurations/FeatureDefines.xcconfig:
1395
1396 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1397
1398         WebCore shouldn't have a Objective-C class named NSCursor
1399         https://bugs.webkit.org/show_bug.cgi?id=192602
1400         <rdar://problem/46615532>
1401
1402         Reviewed by Wenson Hsieh.
1403
1404         * WebView/WebFrameView.mm:
1405         (-[WebFrameView keyDown:keyDown:]):
1406         * WebView/WebHTMLView.mm:
1407         (-[WebHTMLView keyDown:]):
1408         (-[WebHTMLView performKeyEquivalent:]):
1409         Only use NSCursor on macOS.
1410
1411 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1412
1413         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1414         https://bugs.webkit.org/show_bug.cgi?id=192573
1415
1416         Reviewed by Simon Fraser.
1417
1418         * Configurations/FeatureDefines.xcconfig:
1419
1420 2018-12-10  Antti Koivisto  <antti@apple.com>
1421
1422         Rename "forced style recalc" to "full style rebuild"
1423         https://bugs.webkit.org/show_bug.cgi?id=192572
1424
1425         Reviewed by Zalan Bujtas.
1426
1427         * WebView/WebHTMLView.mm:
1428         (-[WebHTMLView setNeedsToApplyStyles:]):
1429
1430 2018-12-10  Darin Adler  <darin@apple.com>
1431
1432         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1433         https://bugs.webkit.org/show_bug.cgi?id=192533
1434         rdar://problem/45732710
1435
1436         Reviewed by Anders Carlsson.
1437
1438         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1439         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1440
1441 2018-12-10  Darin Adler  <darin@apple.com>
1442
1443         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1444         https://bugs.webkit.org/show_bug.cgi?id=192532
1445         rdar://problem/45731047
1446
1447         Reviewed by Chris Dumez.
1448
1449         * Plugins/Hosted/NetscapePluginHostManager.mm:
1450         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1451         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1452         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1453
1454 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1455
1456         Turn WritingDirection into an enum class
1457         https://bugs.webkit.org/show_bug.cgi?id=192401
1458         Work towards <rdar://problem/42075638>
1459
1460         Reviewed by Dan Bernstein.
1461
1462         Change WritingDirection from an enum to an enum class. No change in behavior.
1463
1464         * WebView/WebHTMLView.mm:
1465         (-[WebHTMLView toggleBaseWritingDirection:]):
1466         (-[WebHTMLView changeBaseWritingDirection:]):
1467         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1468
1469 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1470
1471         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1472         https://bugs.webkit.org/show_bug.cgi?id=192272
1473
1474         Reviewed by Brady Eidson.
1475
1476         * WebCoreSupport/WebFrameLoaderClient.h:
1477         * WebCoreSupport/WebFrameLoaderClient.mm:
1478         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1479
1480 2018-12-03  Jer Noble  <jer.noble@apple.com>
1481
1482         Get rid of old, dead Mac video fullscreen code.
1483         https://bugs.webkit.org/show_bug.cgi?id=192315
1484
1485         Reviewed by Eric Carlson.
1486
1487         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1488         is no longer supported in the Mac port.
1489
1490         * WebView/WebVideoFullscreenController.h: Removed.
1491         * WebView/WebVideoFullscreenController.mm: Removed.
1492         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1493         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1494         * WebView/WebView.mm:
1495         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1496         (-[WebView _exitVideoFullscreen]):
1497
1498 2018-12-03  Daniel Bates  <dabates@apple.com>
1499
1500         [iOS] Do not handle key events that are key commands
1501         https://bugs.webkit.org/show_bug.cgi?id=191608
1502         <rdar://problem/46046013>
1503
1504         Reviewed by Ryosuke Niwa.
1505
1506         A key down event may be associated with a key command. If it is then we want to execute the
1507         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1508         event as a key command to find out.
1509
1510         * WebView/WebHTMLView.mm:
1511         (-[WebHTMLView _handleEditingKeyEvent:]):
1512
1513 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1514
1515         Add a runtime feature flag for LayoutFormattingContext.
1516         https://bugs.webkit.org/show_bug.cgi?id=192280
1517
1518         Reviewed by Simon Fraser.
1519
1520         * Configurations/FeatureDefines.xcconfig:
1521
1522 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1523
1524         Move URL from WebCore to WTF
1525         https://bugs.webkit.org/show_bug.cgi?id=190234
1526
1527         Reviewed by Keith Miller.
1528
1529         * DOM/DOMAttr.mm:
1530         * DOM/DOMBlob.mm:
1531         * DOM/DOMCSSCharsetRule.mm:
1532         * DOM/DOMCSSImportRule.mm:
1533         * DOM/DOMCSSMediaRule.mm:
1534         * DOM/DOMCSSPageRule.mm:
1535         * DOM/DOMCSSPrimitiveValue.mm:
1536         * DOM/DOMCSSRule.mm:
1537         * DOM/DOMCSSStyleDeclaration.mm:
1538         * DOM/DOMCSSStyleRule.mm:
1539         * DOM/DOMCSSStyleSheet.mm:
1540         * DOM/DOMCSSValue.mm:
1541         * DOM/DOMCharacterData.mm:
1542         * DOM/DOMCounter.mm:
1543         * DOM/DOMDocument.mm:
1544         * DOM/DOMDocumentFragment.mm:
1545         * DOM/DOMDocumentType.mm:
1546         * DOM/DOMEvent.mm:
1547         * DOM/DOMFile.mm:
1548         * DOM/DOMHTMLAnchorElement.mm:
1549         * DOM/DOMHTMLAppletElement.mm:
1550         * DOM/DOMHTMLAreaElement.mm:
1551         * DOM/DOMHTMLBRElement.mm:
1552         * DOM/DOMHTMLBaseElement.mm:
1553         * DOM/DOMHTMLBaseFontElement.mm:
1554         * DOM/DOMHTMLBodyElement.mm:
1555         * DOM/DOMHTMLButtonElement.mm:
1556         * DOM/DOMHTMLCanvasElement.mm:
1557         * DOM/DOMHTMLCollection.mm:
1558         * DOM/DOMHTMLDivElement.mm:
1559         * DOM/DOMHTMLDocument.mm:
1560         * DOM/DOMHTMLElement.mm:
1561         * DOM/DOMHTMLEmbedElement.mm:
1562         * DOM/DOMHTMLFieldSetElement.mm:
1563         * DOM/DOMHTMLFontElement.mm:
1564         * DOM/DOMHTMLFormElement.mm:
1565         * DOM/DOMHTMLFrameElement.mm:
1566         * DOM/DOMHTMLFrameSetElement.mm:
1567         * DOM/DOMHTMLHRElement.mm:
1568         * DOM/DOMHTMLHeadElement.mm:
1569         * DOM/DOMHTMLHeadingElement.mm:
1570         * DOM/DOMHTMLHtmlElement.mm:
1571         * DOM/DOMHTMLIFrameElement.mm:
1572         * DOM/DOMHTMLImageElement.mm:
1573         * DOM/DOMHTMLInputElement.mm:
1574         * DOM/DOMHTMLLIElement.mm:
1575         * DOM/DOMHTMLLabelElement.mm:
1576         * DOM/DOMHTMLLegendElement.mm:
1577         * DOM/DOMHTMLLinkElement.mm:
1578         * DOM/DOMHTMLMapElement.mm:
1579         * DOM/DOMHTMLMarqueeElement.mm:
1580         * DOM/DOMHTMLMediaElement.mm:
1581         * DOM/DOMHTMLMetaElement.mm:
1582         * DOM/DOMHTMLModElement.mm:
1583         * DOM/DOMHTMLOListElement.mm:
1584         * DOM/DOMHTMLObjectElement.mm:
1585         * DOM/DOMHTMLOptGroupElement.mm:
1586         * DOM/DOMHTMLOptionElement.mm:
1587         * DOM/DOMHTMLOptionsCollection.mm:
1588         * DOM/DOMHTMLParagraphElement.mm:
1589         * DOM/DOMHTMLParamElement.mm:
1590         * DOM/DOMHTMLQuoteElement.mm:
1591         * DOM/DOMHTMLScriptElement.mm:
1592         * DOM/DOMHTMLSelectElement.mm:
1593         * DOM/DOMHTMLStyleElement.mm:
1594         * DOM/DOMHTMLTableCaptionElement.mm:
1595         * DOM/DOMHTMLTableCellElement.mm:
1596         * DOM/DOMHTMLTableColElement.mm:
1597         * DOM/DOMHTMLTableElement.mm:
1598         * DOM/DOMHTMLTableRowElement.mm:
1599         * DOM/DOMHTMLTableSectionElement.mm:
1600         * DOM/DOMHTMLTitleElement.mm:
1601         * DOM/DOMHTMLUListElement.mm:
1602         * DOM/DOMHTMLVideoElement.mm:
1603         * DOM/DOMKeyboardEvent.mm:
1604         * DOM/DOMMediaList.mm:
1605         * DOM/DOMMouseEvent.mm:
1606         * DOM/DOMMutationEvent.mm:
1607         * DOM/DOMNamedNodeMap.mm:
1608         * DOM/DOMProcessingInstruction.mm:
1609         * DOM/DOMRange.mm:
1610         * DOM/DOMStyleSheet.mm:
1611         * DOM/DOMText.mm:
1612         * DOM/DOMTextEvent.mm:
1613         * DOM/DOMTokenList.mm:
1614         * DOM/DOMUIEvent.mm:
1615         * DOM/DOMXPathResult.mm:
1616         * History/WebHistoryItem.mm:
1617         * Misc/WebNSURLExtras.mm:
1618         (-[NSURL _web_userVisibleString]):
1619         (-[NSURL _web_URLByRemovingUserInfo]):
1620         (-[NSURL _web_dataForURLComponentType:]):
1621         (-[NSURL _web_schemeData]):
1622         (-[NSURL _web_hostData]):
1623         * Misc/WebUserContentURLPattern.mm:
1624         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1625         * Plugins/WebNetscapePluginStream.h:
1626         (WebNetscapePluginStream::setRequestURL):
1627         * WebCoreSupport/WebChromeClient.h:
1628         * WebCoreSupport/WebChromeClient.mm:
1629         (WebChromeClient::signedPublicKeyAndChallengeString const):
1630         * WebCoreSupport/WebContextMenuClient.h:
1631         * WebCoreSupport/WebContextMenuClient.mm:
1632         * WebCoreSupport/WebDragClient.h:
1633         * WebCoreSupport/WebFrameLoaderClient.h:
1634         * WebCoreSupport/WebFrameLoaderClient.mm:
1635         (WebFrameLoaderClient::updateGlobalHistory):
1636         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1637         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1638         (WebPaymentCoordinatorClient::showPaymentUI):
1639         * WebCoreSupport/WebPlatformStrategies.h:
1640         * WebCoreSupport/WebPlatformStrategies.mm:
1641         (WebPlatformStrategies::readURLFromPasteboard):
1642         * WebCoreSupport/WebPluginInfoProvider.h:
1643         * WebCoreSupport/WebPluginInfoProvider.mm:
1644         (WebPluginInfoProvider::webVisiblePluginInfo):
1645         * WebCoreSupport/WebSecurityOrigin.mm:
1646         * WebCoreSupport/WebVisitedLinkStore.h:
1647         * WebView/WebDataSource.mm:
1648         * WebView/WebFrame.mm:
1649         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1650         * WebView/WebImmediateActionController.mm:
1651         (-[WebImmediateActionController _defaultAnimationController]):
1652         * WebView/WebPDFView.mm:
1653         * WebView/WebScriptDebugger.mm:
1654         * WebView/WebViewInternal.h:
1655
1656 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1657
1658         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1659         https://bugs.webkit.org/show_bug.cgi?id=192197
1660
1661         Reviewed by Jiewen Tan.
1662
1663         * Configurations/FeatureDefines.xcconfig:
1664         * WebCoreSupport/WebChromeClient.h:
1665         * WebCoreSupport/WebChromeClient.mm:
1666
1667 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1668
1669         Remove dead code from an earlier attempt at implementing safe browsing
1670         https://bugs.webkit.org/show_bug.cgi?id=192067
1671
1672         Reviewed by Chris Dumez.
1673
1674         * WebCoreSupport/WebFrameLoaderClient.h:
1675         * WebCoreSupport/WebFrameLoaderClient.mm:
1676         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1677
1678 2018-11-27  Mark Lam  <mark.lam@apple.com>
1679
1680         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1681         https://bugs.webkit.org/show_bug.cgi?id=192055
1682         <rdar://problem/46288783>
1683
1684         Reviewed by Saam Barati.
1685
1686         * Configurations/FeatureDefines.xcconfig:
1687
1688 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1689
1690         Make it possible to insert editable images with a gesture
1691         https://bugs.webkit.org/show_bug.cgi?id=191937
1692
1693         Reviewed by Wenson Hsieh.
1694
1695         * WebCoreSupport/WebEditorClient.mm:
1696         (undoNameForEditAction):
1697         Add a undo name.
1698
1699 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1700
1701         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1702         https://bugs.webkit.org/show_bug.cgi?id=191945
1703
1704         Reviewed by Anders Carlsson.
1705
1706         * WebCoreSupport/WebEditorClient.mm:
1707         (undoNameForEditAction):
1708
1709 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1710
1711         Enable drag and drop support for iOSMac
1712         https://bugs.webkit.org/show_bug.cgi?id=191818
1713         <rdar://problem/43907454>
1714
1715         Reviewed by Dean Jackson.
1716
1717         * Configurations/FeatureDefines.xcconfig:
1718
1719 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1720
1721         Address post-review feedback after r238438
1722         https://bugs.webkit.org/show_bug.cgi?id=191913
1723
1724         Reviewed by Ryosuke Niwa.
1725
1726         * WebView/WebFrame.mm:
1727         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1728         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1729         * WebView/WebView.mm:
1730         (-[WebView setSelectedDOMRange:affinity:]):
1731
1732 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1733
1734         Web Inspector: "Reload Web Inspector" button no longer partially works
1735         https://bugs.webkit.org/show_bug.cgi?id=191773
1736         <rdar://problem/46139932>
1737
1738         Reviewed by Devin Rousso.
1739
1740         * WebCoreSupport/WebInspectorClient.h:
1741         * WebCoreSupport/WebInspectorClient.mm:
1742         (WebInspectorFrontendClient::reopen):
1743
1744 2018-11-17  Devin Rousso  <drousso@apple.com>
1745
1746         Web Inspector: Network: add button to show system certificate dialog
1747         https://bugs.webkit.org/show_bug.cgi?id=191458
1748         <rdar://problem/45977019>
1749
1750         Reviewed by Joseph Pecoraro.
1751
1752         * WebCoreSupport/WebInspectorClient.h:
1753         * WebCoreSupport/WebInspectorClient.mm:
1754         (WebInspectorFrontendClient::showCertificate): Added.
1755
1756         * Configurations/WebKitLegacy.xcconfig:
1757
1758 2018-11-15  Truitt Savell  <tsavell@apple.com>
1759
1760         Unreviewed, rolling out r238244.
1761
1762         Caused High Sierra test runs to fail early with 50 crashes and
1763         casued 25 API failures.
1764
1765         Reverted changeset:
1766
1767         "[css-logical] Implement flow-relative margin, padding and
1768         border shorthands"
1769         https://bugs.webkit.org/show_bug.cgi?id=188697
1770         https://trac.webkit.org/changeset/238244
1771
1772 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1773
1774         [css-logical] Implement flow-relative margin, padding and border shorthands
1775         https://bugs.webkit.org/show_bug.cgi?id=188697
1776
1777         Reviewed by Simon Fraser and Antti Koivisto.
1778
1779         Add CSSLogicalEnabled runtime flag.
1780
1781         * WebView/WebPreferenceKeysPrivate.h:
1782         * WebView/WebPreferences.mm:
1783         (+[WebPreferences initialize]):
1784         (-[WebPreferences cssLogicalEnabled]):
1785         (-[WebPreferences setCSSLogicalEnabled:]):
1786         * WebView/WebPreferencesPrivate.h:
1787         * WebView/WebView.mm:
1788         (-[WebView _preferencesChanged:]):
1789
1790 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1791
1792         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1793         https://bugs.webkit.org/show_bug.cgi?id=191612
1794
1795         Reviewed by Matt Baker.
1796
1797         * WebCoreSupport/WebInspectorClient.mm:
1798         (-[WebInspectorWindowController destroyInspectorView]):
1799
1800 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1801
1802         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1803         https://bugs.webkit.org/show_bug.cgi?id=191494
1804         <rdar://problem/45469854>
1805
1806         Reviewed by Devin Rousso.
1807
1808         * WebCoreSupport/WebInspectorClient.h:
1809         WebKitLegacy will still have remote inspection of the Page directly.
1810
1811 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1812
1813         Make compositing updates incremental
1814         https://bugs.webkit.org/show_bug.cgi?id=90342
1815
1816         Reviewed by Antti Koivisto.
1817
1818         Fix spelling error.
1819
1820         * WebView/WebView.mm:
1821         (-[WebView _setMediaLayer:forPluginView:]):
1822
1823 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1824
1825         Implement a new edit command to change the enclosing list type
1826         https://bugs.webkit.org/show_bug.cgi?id=191487
1827         <rdar://problem/45955922>
1828
1829         Reviewed by Ryosuke Niwa.
1830
1831         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1832
1833         * WebCoreSupport/WebEditorClient.mm:
1834         (undoNameForEditAction):
1835
1836 2018-11-11  Daniel Bates  <dabates@apple.com>
1837
1838         [iOS] Draw caps lock indicator in password fields
1839         https://bugs.webkit.org/show_bug.cgi?id=190565
1840         <rdar://problem/45262343>
1841
1842         Reviewed by Dean Jackson.
1843
1844         Update the caps lock state when a hardware keyboard is attached or detached.
1845
1846         * WebView/WebHTMLView.mm:
1847         (hardwareKeyboardAvailabilityChangedCallback): Added.
1848         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1849         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1850
1851 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1852
1853         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1854         https://bugs.webkit.org/show_bug.cgi?id=191492
1855
1856         Reviewed by Alex Christensen.
1857
1858         * Carbon/HIWebView.mm:
1859         * Misc/WebNSFileManagerExtras.mm:
1860         * Misc/WebNSURLExtras.mm:
1861         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1862         * Plugins/WebBasePluginPackage.mm:
1863         * Plugins/WebPluginContainerCheck.mm:
1864         * WebCoreSupport/WebCachedFramePlatformData.h:
1865         * WebCoreSupport/WebDeviceOrientationClient.mm:
1866         * WebView/WebDelegateImplementationCaching.mm:
1867         * WebView/WebHTMLView.mm:
1868         * WebView/WebPDFRepresentation.mm:
1869         * WebView/WebPolicyDelegate.mm:
1870         * WebView/WebView.mm:
1871
1872 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1873
1874         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1875         https://bugs.webkit.org/show_bug.cgi?id=191492
1876
1877         Reviewed by Alex Christensen.
1878
1879         * Carbon/HIWebView.mm:
1880         (UpdateCommandStatus):
1881         * Misc/WebNSFileManagerExtras.mm:
1882         * Misc/WebNSURLExtras.mm:
1883         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1884         * Plugins/WebBasePluginPackage.mm:
1885         * Plugins/WebPluginContainerCheck.mm:
1886         (-[WebPluginContainerCheck _continueWithPolicy:]):
1887         * WebCoreSupport/WebCachedFramePlatformData.h:
1888         (WebCachedFramePlatformData::clear):
1889         * WebCoreSupport/WebDeviceOrientationClient.mm:
1890         (WebDeviceOrientationClient::getProvider const):
1891         * WebView/WebDelegateImplementationCaching.mm:
1892         (CallDelegate):
1893         (CallDelegateReturningBoolean):
1894         (CallResourceLoadDelegateReturningBoolean):
1895         (CallFormDelegate):
1896         (CallFormDelegateReturningBoolean):
1897         * WebView/WebHTMLView.mm:
1898         * WebView/WebPDFRepresentation.mm:
1899         * WebView/WebPolicyDelegate.mm:
1900         (-[WebPolicyDecisionListener _usePolicy:]):
1901         * WebView/WebView.mm:
1902
1903 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1904
1905         Unreviewed, rolling out r238047.
1906
1907         Introduced layout test failures on iOS simulator.
1908
1909         Reverted changeset:
1910
1911         "[iOS] Draw caps lock indicator in password fields"
1912         https://bugs.webkit.org/show_bug.cgi?id=190565
1913         https://trac.webkit.org/changeset/238047
1914
1915 2018-11-09  Antti Koivisto  <antti@apple.com>
1916
1917         Use OptionSet for layout milestones
1918         https://bugs.webkit.org/show_bug.cgi?id=191470
1919
1920         Reviewed by Dean Jackson.
1921
1922         * WebCoreSupport/WebFrameLoaderClient.h:
1923         * WebCoreSupport/WebFrameLoaderClient.mm:
1924         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1925         * WebView/WebView.mm:
1926         (coreLayoutMilestones):
1927         (kitLayoutMilestones):
1928         (-[WebView _cacheFrameLoadDelegateImplementations]):
1929         * WebView/WebViewInternal.h:
1930
1931 2018-11-09  Daniel Bates  <dabates@apple.com>
1932
1933         [iOS] Draw caps lock indicator in password fields
1934         https://bugs.webkit.org/show_bug.cgi?id=190565
1935         <rdar://problem/45262343>
1936
1937         Reviewed by Dean Jackson.
1938
1939         Update the caps lock state when a hardware keyboard is attached or detached.
1940
1941         * WebView/WebHTMLView.mm:
1942         (hardwareKeyboardAvailabilityChangedCallback): Added.
1943         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1944         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1945
1946 2018-11-09  Daniel Bates  <dabates@apple.com>
1947
1948         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1949         action when forward delete is pressed outside a text field
1950         https://bugs.webkit.org/show_bug.cgi?id=190566
1951         <rdar://problem/45262367>
1952
1953         Reviewed by Wenson Hsieh.
1954
1955         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1956         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1957         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1958
1959         * WebView/WebHTMLView.mm:
1960         (-[WebHTMLView _handleEditingKeyEvent:]):
1961
1962 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1963
1964         Adopt Reveal Framework to replace Lookup
1965         https://bugs.webkit.org/show_bug.cgi?id=191097
1966         <rdar://problem/45924508>
1967
1968         Reviewed by Tim Horton.
1969
1970         Pass in what it needed to clear the textIndicators. This is better than
1971         the current notification structure.
1972
1973         * WebView/WebView.mm:
1974         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
1975         (-[WebView _prepareForDictionaryLookup]):
1976
1977 2018-11-06  Justin Fan  <justin_fan@apple.com>
1978
1979         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
1980         https://bugs.webkit.org/show_bug.cgi?id=191291
1981
1982         Reviewed by Myles Maxfield.
1983
1984         Properly disable WEBGPU on all non-Metal platforms for now.
1985
1986         * Configurations/FeatureDefines.xcconfig:
1987
1988 2018-11-02  Daniel Bates  <dabates@apple.com>
1989
1990         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1991         https://bugs.webkit.org/show_bug.cgi?id=190487
1992
1993         Reviewed by Tim Horton.
1994
1995         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
1996         allow the default handling.
1997
1998         * WebView/WebHTMLView.mm:
1999         (-[WebHTMLView _handleEditingKeyEvent:]):
2000
2001 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2002
2003         Add a storage limit for IndexedDB
2004         https://bugs.webkit.org/show_bug.cgi?id=190598
2005         <rdar://problem/44654715>
2006
2007         Reviewed by Chris Dumez.
2008
2009         * Storage/WebDatabaseManager.mm:
2010         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2011         * Storage/WebDatabaseManagerPrivate.h:
2012
2013 2018-10-31  Antti Koivisto  <antti@apple.com>
2014
2015         Remove LayerFlushScheduler
2016         https://bugs.webkit.org/show_bug.cgi?id=191103
2017
2018         Reviewed by Anders Carlsson.
2019
2020         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2021         all the virtual cruft.
2022
2023         * WebView/WebViewData.h:
2024         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2025         (): Deleted.
2026         * WebView/WebViewData.mm:
2027         (currentRunLoop):
2028         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2029         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2030         (WebViewLayerFlushScheduler::schedule):
2031         (WebViewLayerFlushScheduler::invalidate):
2032         (WebViewLayerFlushScheduler::layerFlushCallback):
2033
2034 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2035
2036         Enable InstallAPI for iOS unconditionally
2037         https://bugs.webkit.org/show_bug.cgi?id=191043
2038         rdar://problem/32728423
2039
2040         Reviewed by Dan Bernstein.
2041
2042         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2043         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2044         shouldn't be processed by InstallAPI.
2045         * MigrateHeaders.make: Removed an obsolete workaround.
2046         * Misc/NSURLDownloadSPI.h: Added.
2047         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2048
2049 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2050
2051         Clean up some obsolete MAX_ALLOWED macros
2052         https://bugs.webkit.org/show_bug.cgi?id=190916
2053
2054         Reviewed by Tim Horton.
2055
2056         * WebView/WebHTMLView.mm:
2057         (-[WebHTMLView pressureChangeWithEvent:]):
2058         * WebView/WebPDFView.h:
2059
2060 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2061
2062         Unreviewed, rolling out r237600 and r237604.
2063         https://bugs.webkit.org/show_bug.cgi?id=191086
2064
2065         Breaks internal iOS builds (Requested by ryanhadd_ on
2066         #webkit).
2067
2068         Reverted changesets:
2069
2070         "Enable InstallAPI for iOS unconditionally"
2071         https://bugs.webkit.org/show_bug.cgi?id=191043
2072         https://trac.webkit.org/changeset/237600
2073
2074         "Build fix attempt after enabling InstallAPI for iOS."
2075         https://bugs.webkit.org/show_bug.cgi?id=191043
2076         https://trac.webkit.org/changeset/237604
2077
2078 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2079
2080         Enable InstallAPI for iOS unconditionally
2081         https://bugs.webkit.org/show_bug.cgi?id=191043
2082         rdar://problem/32728423
2083
2084         Reviewed by Dan Bernstein.
2085
2086         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2087         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2088         shouldn't be processed by InstallAPI.
2089         * MigrateHeaders.make: Removed an obsolete workaround.
2090         * Misc/NSURLDownloadSPI.h: Added.
2091         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2092
2093 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2094
2095         Modernize WebKit nibs and lprojs for localization's sake
2096         https://bugs.webkit.org/show_bug.cgi?id=190911
2097         <rdar://problem/45349466>
2098
2099         Reviewed by Dan Bernstein.
2100
2101         * Misc/WebNSControlExtras.m:
2102         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2103         NSWindow and its contents are both in the same scale space these days; avoid
2104         double-applying the scale factor, or you can't see the prompt.
2105
2106         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2107         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2108         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2109         NIB->XIB
2110
2111 2018-10-25  Antoine Quint  <graouts@apple.com>
2112
2113         [Web Animations] Turn Web Animations CSS Integration off by default
2114         https://bugs.webkit.org/show_bug.cgi?id=190901
2115
2116         Reviewed by Dean Jackson.
2117
2118         * WebView/WebPreferences.mm:
2119         (+[WebPreferences initialize]):
2120
2121 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2122
2123         Clean up some obsolete macOS version guards
2124         https://bugs.webkit.org/show_bug.cgi?id=190887
2125
2126         Reviewed by Dan Bernstein.
2127
2128         * Misc/WebNSPasteboardExtras.mm:
2129         (+[NSPasteboard _web_dragTypesForURL]):
2130         * WebCoreSupport/PopupMenuMac.mm:
2131         (PopupMenuMac::show):
2132         * WebCoreSupport/WebEditorClient.h:
2133         * WebCoreSupport/WebEditorClient.mm:
2134         (WebEditorClient::respondToChangedSelection):
2135         * WebView/WebPDFView.mm:
2136         (-[WebPDFView _clipViewForPDFDocumentView]):
2137
2138 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2139
2140         Turn on Conic Gradients
2141         https://bugs.webkit.org/show_bug.cgi?id=190810
2142
2143         Reviewed by Tim Horton.
2144
2145         * Configurations/FeatureDefines.xcconfig:
2146
2147 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2148
2149         Cleanup: MIMETypeRegistry functions
2150         https://bugs.webkit.org/show_bug.cgi?id=190838
2151
2152         Reviewed by Simon Fraser.
2153
2154         * Misc/WebNSPasteboardExtras.mm:
2155         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2156         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2157         because they were identical.
2158
2159         * WebView/WebHTMLRepresentation.mm:
2160         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2161         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2162         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2163         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2164         * WebView/WebView.mm:
2165         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2166         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2167         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2168
2169 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2170
2171         Fix false positive leaks when using custom -init methods that don't start with -init
2172         <https://webkit.org/b/190818>
2173         <rdar://problem/45476042>
2174
2175         Reviewed by Dan Bernstein.
2176
2177         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2178         it is accessible by both categories.
2179         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2180         NSError (WebKitInternal) category.  Add attribute to make this
2181         behave like an -init method.
2182         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2183         NSError (WebKitInternal) category.  Modernize method.  Replace
2184         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2185
2186 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2187
2188         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2189         https://bugs.webkit.org/show_bug.cgi?id=190729
2190
2191         Reviewed by Tim Horton.
2192
2193         * DOM/DOM.mm:
2194         (-[DOMNode boundingBox]):
2195         * DOM/DOMElement.mm:
2196         * DOM/DOMHTML.mm:
2197         * DOM/DOMInternal.mm:
2198         * DOM/DOMUIKitExtensions.mm:
2199         * DOM/WebDOMOperations.mm:
2200         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2201         * DefaultDelegates/WebDefaultEditingDelegate.m:
2202         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2203         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2204         * DefaultDelegates/WebDefaultUIDelegate.h:
2205         * DefaultDelegates/WebDefaultUIDelegate.mm:
2206         (-[WebDefaultUIDelegate webViewClose:]):
2207         (-[WebDefaultUIDelegate webViewFocus:]):
2208         (-[WebDefaultUIDelegate webViewUnfocus:]):
2209         (-[WebDefaultUIDelegate webViewIsResizable:]):
2210         (-[WebDefaultUIDelegate webView:setResizable:]):
2211         (-[WebDefaultUIDelegate webView:setFrame:]):
2212         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2213         * History/BackForwardList.h:
2214         * History/BackForwardList.mm:
2215         * History/WebBackForwardList.mm:
2216         (+[WebBackForwardList initialize]):
2217         (bumperCarBackForwardHackNeeded):
2218         * History/WebHistory.mm:
2219         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2220         (-[WebHistory _sendNotification:entries:]):
2221         (-[WebHistory loadFromURL:error:]):
2222         (-[WebHistory saveToURL:error:]):
2223         * History/WebHistoryItem.mm:
2224         (WKNotifyHistoryItemChanged):
2225         (+[WebHistoryItem initialize]):
2226         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2227         * History/WebURLsWithTitles.m:
2228         * Misc/WebCache.mm:
2229         (+[WebCache initialize]):
2230         * Misc/WebDownload.mm:
2231         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2232         * Misc/WebElementDictionary.mm:
2233         (+[WebElementDictionary initialize]):
2234         (+[WebElementDictionary initializeLookupTable]):
2235         * Misc/WebIconDatabase.mm:
2236         * Misc/WebKitNSStringExtras.mm:
2237         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2238         * Misc/WebKitVersionChecks.h:
2239         * Misc/WebKitVersionChecks.mm:
2240         (WebKitLinkedOnOrAfter):
2241         (WebKitLinkTimeVersion):
2242         * Misc/WebLocalizableStrings.mm:
2243         * Misc/WebNSControlExtras.h:
2244         * Misc/WebNSControlExtras.m:
2245         * Misc/WebNSEventExtras.m:
2246         * Misc/WebNSFileManagerExtras.mm:
2247         * Misc/WebNSImageExtras.h:
2248         * Misc/WebNSImageExtras.m:
2249         * Misc/WebNSPasteboardExtras.mm:
2250         * Misc/WebNSPrintOperationExtras.h:
2251         * Misc/WebNSPrintOperationExtras.m:
2252         * Misc/WebNSViewExtras.m:
2253         * Misc/WebNSWindowExtras.m:
2254         * Panels/WebAuthenticationPanel.h:
2255         * Panels/WebAuthenticationPanel.m:
2256         * Panels/WebPanelAuthenticationHandler.m:
2257         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2258         (+[WebHostedNetscapePluginView initialize]):
2259         * Plugins/WebBasePluginPackage.h:
2260         * Plugins/WebBasePluginPackage.mm:
2261         * Plugins/WebJavaPlugIn.h:
2262         * Plugins/WebPluginContainerCheck.mm:
2263         * Plugins/WebPluginController.h:
2264         * Plugins/WebPluginController.mm:
2265         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2266         (-[WebPluginController addPlugin:]):
2267         (-[WebPluginController destroyPlugin:]):
2268         (-[WebPluginController destroyAllPlugins]):
2269         * Plugins/WebPluginDatabase.mm:
2270         (+[WebPluginDatabase _defaultPlugInPaths]):
2271         * Plugins/WebPluginPackage.mm:
2272         (-[WebPluginPackage initWithPath:]):
2273         * Storage/WebDatabaseManager.mm:
2274         (-[WebDatabaseManager deleteAllDatabases]):
2275         * Storage/WebDatabaseManagerClient.h:
2276         * Storage/WebDatabaseManagerClient.mm:
2277         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2278         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2279         * Storage/WebStorageManager.mm:
2280         (-[WebStorageManager deleteAllOrigins]):
2281         (WebKitInitializeStorageIfNecessary):
2282         * WebCoreSupport/WebAlternativeTextClient.h:
2283         * WebCoreSupport/WebApplicationCache.mm:
2284         (applicationCacheBundleIdentifier):
2285         * WebCoreSupport/WebChromeClient.h:
2286         * WebCoreSupport/WebChromeClient.mm:
2287         (WebChromeClient::setWindowRect):
2288         (WebChromeClient::windowRect):
2289         (WebChromeClient::takeFocus):
2290         (WebChromeClient::addMessageToConsole):
2291         (WebChromeClient::enableSuddenTermination):
2292         (WebChromeClient::disableSuddenTermination):
2293         (WebChromeClient::createPopupMenu const):
2294         (WebChromeClient::createSearchPopupMenu const):
2295         (WebChromeClient::shouldPaintEntireContents const):
2296         (WebChromeClient::supportsVideoFullscreen):
2297         (WebChromeClient::supportsFullScreenForElement):
2298         (WebChromeClient::enterFullScreenForElement):
2299         (WebChromeClient::exitFullScreenForElement):
2300         * WebCoreSupport/WebContextMenuClient.mm:
2301         * WebCoreSupport/WebDragClient.mm:
2302         * WebCoreSupport/WebEditorClient.h:
2303         * WebCoreSupport/WebEditorClient.mm:
2304         (+[WebUndoStep initialize]):
2305         (updateFontPanel):
2306         (WebEditorClient::didBeginEditing):
2307         (WebEditorClient::respondToChangedContents):
2308         (WebEditorClient::respondToChangedSelection):
2309         (WebEditorClient::canceledComposition):
2310         (WebEditorClient::didEndEditing):
2311         (WebEditorClient::didWriteSelectionToPasteboard):
2312         (attributesForAttributedStringConversion):
2313         (WebEditorClient::setInsertionPasteboard):
2314         (WebEditorClient::registerUndoOrRedoStep):
2315         (WebEditorClient::handleKeyboardEvent):
2316         (WebEditorClient::handleInputMethodKeydown):
2317         (WebEditorClient::textDidChangeInTextField):
2318         (WebEditorClient::requestCheckingOfString):
2319         * WebCoreSupport/WebFrameLoaderClient.h:
2320         * WebCoreSupport/WebFrameLoaderClient.mm:
2321         (WebFrameLoaderClient::detachedFromParent2):
2322         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2323         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2324         (WebFrameLoaderClient::dispatchWillSendRequest):
2325         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2326         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2327         (WebFrameLoaderClient::willCacheResponse const):
2328         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2329         (WebFrameLoaderClient::dispatchDidFinishLoading):
2330         (WebFrameLoaderClient::dispatchDidFailLoading):
2331         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2332         (WebFrameLoaderClient::dispatchWillClose):
2333         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2334         (WebFrameLoaderClient::dispatchDidCommitLoad):
2335         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2336         (WebFrameLoaderClient::dispatchDidFailLoad):
2337         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2338         (WebFrameLoaderClient::dispatchDidFinishLoad):
2339         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2340         (WebFrameLoaderClient::willChangeTitle):
2341         (WebFrameLoaderClient::didChangeTitle):
2342         (WebFrameLoaderClient::didReplaceMultipartContent):
2343         (WebFrameLoaderClient::updateGlobalHistory):
2344         (WebFrameLoaderClient::saveViewStateToItem):
2345         (WebFrameLoaderClient::restoreViewState):
2346         (WebFrameLoaderClient::provisionalLoadStarted):
2347         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2348         (WebFrameLoaderClient::setTitle):
2349         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2350         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2351         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2352         (WebFrameLoaderClient::didRestoreFromPageCache):
2353         (WebFrameLoaderClient::actionDictionary const):
2354         (WebFrameLoaderClient::createPlugin):
2355         (WebFrameLoaderClient::getLoadDecisionForIcons):
2356         (WebFrameLoaderClient::finishedLoadingIcon):
2357         (+[WebFramePolicyListener initialize]):
2358         * WebCoreSupport/WebFrameNetworkingContext.mm:
2359         * WebCoreSupport/WebGeolocationClient.h:
2360         * WebCoreSupport/WebGeolocationClient.mm:
2361         (WebGeolocationClient::requestPermission):
2362         * WebCoreSupport/WebInspectorClient.h:
2363         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2364         * WebCoreSupport/WebNotificationClient.mm:
2365         * WebCoreSupport/WebOpenPanelResultListener.mm:
2366         * WebCoreSupport/WebPlatformStrategies.h:
2367         * WebCoreSupport/WebPlatformStrategies.mm:
2368         * WebCoreSupport/WebProgressTrackerClient.h:
2369         * WebCoreSupport/WebProgressTrackerClient.mm:
2370         (WebProgressTrackerClient::progressStarted):
2371         (WebProgressTrackerClient::progressEstimateChanged):
2372         (WebProgressTrackerClient::progressFinished):
2373         * WebCoreSupport/WebSecurityOrigin.mm:
2374         * WebInspector/WebNodeHighlight.h:
2375         * WebInspector/WebNodeHighlight.mm:
2376         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2377         (-[WebNodeHighlight dealloc]):
2378         (-[WebNodeHighlight attach]):
2379         * WebInspector/WebNodeHighlightView.h:
2380         * WebInspector/WebNodeHighlightView.mm:
2381         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2382         (-[WebNodeHighlightView dealloc]):
2383         * WebInspector/WebNodeHighlighter.mm:
2384         (-[WebNodeHighlighter highlight]):
2385         * WebView/WebArchive.mm:
2386         (+[WebArchivePrivate initialize]):
2387         * WebView/WebClipView.h:
2388         * WebView/WebDataSource.mm:
2389         (WebDataSourcePrivate::WebDataSourcePrivate):
2390         (+[WebDataSource initialize]):
2391         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2392         (-[WebDataSource _makeRepresentation]):
2393         * WebView/WebDelegateImplementationCaching.h:
2394         * WebView/WebDelegateImplementationCaching.mm:
2395         (CallDelegate):
2396         (CallDelegateReturningFloat):
2397         (CallDelegateReturningBoolean):
2398         (CallUIDelegate):
2399         (CallUIDelegateReturningFloat):
2400         (CallUIDelegateReturningBoolean):
2401         (CallFrameLoadDelegate):
2402         (CallFrameLoadDelegateReturningBoolean):
2403         (CallResourceLoadDelegate):
2404         (CallScriptDebugDelegate):
2405         (CallFormDelegate):
2406         (CallFormDelegateReturningBoolean):
2407         * WebView/WebDeviceOrientation.mm:
2408         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2409         * WebView/WebDocumentInternal.h:
2410         * WebView/WebDocumentLoaderMac.mm:
2411         (needsDataLoadWorkaround):
2412         * WebView/WebDynamicScrollBarsViewInternal.h:
2413         * WebView/WebFormDelegate.m:
2414         * WebView/WebFrame.mm:
2415         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2416         (-[WebFrame _unmarkAllMisspellings]):
2417         (-[WebFrame _paintBehaviorForDestinationContext:]):
2418         (-[WebFrame _drawRect:contentsOnly:]):
2419         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2420         (-[WebFrame _scrollDOMRangeToVisible:]):
2421         (-[WebFrame _bodyBackgroundColor]):
2422         (-[WebFrame accessibilityRoot]):
2423         (needsMicrosoftMessengerDOMDocumentWorkaround):
2424         * WebView/WebFrameInternal.h:
2425         * WebView/WebFrameView.mm:
2426         (-[WebFrameView _setDocumentView:]):
2427         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2428         (-[WebFrameView _viewClassForMIMEType:]):
2429         (-[WebFrameView initWithFrame:]):
2430         (-[WebFrameView drawRect:]):
2431         (-[WebFrameView _firstResponderIsFormControl]):
2432         (-[WebFrameView keyDown:keyDown:]):
2433         (-[WebFrameView _isScrollable]):
2434         * WebView/WebFullScreenController.h:
2435         * WebView/WebFullScreenController.mm:
2436         * WebView/WebHTMLRepresentation.mm:
2437         * WebView/WebHTMLView.mm:
2438         (-[WebHTMLView hitTest:]):
2439         (-[WebHTMLView initWithFrame:]):
2440         (-[WebHTMLView dealloc]):
2441         (-[WebHTMLView addSubview:]):
2442         (-[WebHTMLView mouseDown:]):
2443         (-[WebHTMLView mouseUp:]):
2444         (-[WebHTMLView resignFirstResponder]):
2445         (-[WebHTMLView accessibilityHitTest:]):
2446         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2447         * WebView/WebHTMLViewInternal.h:
2448         * WebView/WebIndicateLayer.h:
2449         * WebView/WebIndicateLayer.mm:
2450         * WebView/WebMediaPlaybackTargetPicker.h:
2451         * WebView/WebMediaPlaybackTargetPicker.mm:
2452         * WebView/WebPDFDocumentExtras.h:
2453         * WebView/WebPDFDocumentExtras.mm:
2454         * WebView/WebPDFRepresentation.h:
2455         * WebView/WebPDFRepresentation.mm:
2456         * WebView/WebPDFView.h:
2457         * WebView/WebPreferences.mm:
2458         (cacheModelForMainBundle):
2459         (WebPreferencesPrivate::WebPreferencesPrivate):
2460         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2461         (-[WebPreferences encodeWithCoder:]):
2462         (+[WebPreferences standardPreferences]):
2463         (+[WebPreferences initialize]):
2464         (-[WebPreferences _valueForKey:]):
2465         (-[WebPreferences _setStringValue:forKey:]):
2466         (-[WebPreferences _setIntegerValue:forKey:]):
2467         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2468         (-[WebPreferences _setFloatValue:forKey:]):
2469         (-[WebPreferences _setBoolValue:forKey:]):
2470         (-[WebPreferences _setLongLongValue:forKey:]):
2471         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2472         (-[WebPreferences _postCacheModelChangedNotification]):
2473         (-[WebPreferences _postPreferencesChangedNotification]):
2474         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2475         (-[WebPreferences setStorageBlockingPolicy:]):
2476         * WebView/WebResource.mm:
2477         (+[WebResourcePrivate initialize]):
2478         * WebView/WebTextCompletionController.h:
2479         * WebView/WebTextIterator.mm:
2480         (+[WebTextIteratorPrivate initialize]):
2481         * WebView/WebView.mm:
2482         (shouldEnableLoadDeferring):
2483         (shouldRestrictWindowFocus):
2484         (shouldRespectPriorityInCSSAttributeSetters):
2485         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2486         (shouldAllowPictureInPictureMediaPlayback):
2487         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2488         (shouldAllowWindowOpenWithoutUserGesture):
2489         (shouldConvertInvalidURLsToBlank):
2490         (shouldRequireUserGestureToLoadVideo):
2491         (-[WebView _commonInitializationWithFrameName:groupName:]):
2492         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2493         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2494         (-[WebView _closePluginDatabases]):
2495         (-[WebView _closeWithFastTeardown]):
2496         (-[WebView _close]):
2497         (+[WebView _MIMETypeForFile:]):
2498         (-[WebView setShowingInspectorIndication:]):
2499         (-[WebView _setFormDelegate:]):
2500         (-[WebView _needsPreHTML5ParserQuirks]):
2501         (-[WebView _preferencesChangedNotification:]):
2502         (-[WebView _preferencesChanged:]):
2503         (-[WebView _cacheResourceLoadDelegateImplementations]):
2504         (-[WebView _cacheFrameLoadDelegateImplementations]):
2505         (-[WebView _policyDelegateForwarder]):
2506         (-[WebView _UIDelegateForwarder]):
2507         (-[WebView _editingDelegateForwarder]):
2508         (-[WebView _updateActiveState]):
2509         (-[_WebSafeForwarder forwardInvocation:]):
2510         (+[WebView initialize]):
2511         (-[WebView _pluginForMIMEType:]):
2512         (-[WebView _pluginForExtension:]):
2513         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2514         (+[WebView canShowMIMETypeAsHTML:]):
2515         (-[WebView _initWithArguments:]):
2516         (-[WebView initWithFrame:frameName:groupName:]):
2517         (-[WebView dealloc]):
2518         (-[WebView close]):
2519         (-[WebView viewDidMoveToWindow]):
2520         (-[WebView setUIDelegate:]):
2521         (-[WebView setResourceLoadDelegate:]):
2522         (-[WebView setPolicyDelegate:]):
2523         (-[WebView setFrameLoadDelegate:]):
2524         (-[WebView goBack]):
2525         (-[WebView goForward]):
2526         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2527         (-[WebView setHostWindow:]):
2528         (-[WebView becomeFirstResponder]):
2529         (+[WebView _cacheModelChangedNotification:]):
2530         (-[WebView _frameViewAtWindowPoint:]):
2531         (+[WebView _preflightSpellCheckerNow:]):
2532         (+[WebView _preflightSpellChecker]):
2533         (-[WebView canGoBack]):
2534         (-[WebView canGoForward]):
2535         (-[WebView stopLoading:]):
2536         (-[WebView reload:]):
2537         (-[WebView setMainFrameDocumentReady:]):
2538         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2539         (-[WebView setContinuousSpellCheckingEnabled:]):
2540         (-[WebView undoManager]):
2541         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2542         (-[WebView isAutomaticLinkDetectionEnabled]):
2543         (-[WebView isAutomaticDashSubstitutionEnabled]):
2544         (-[WebView isAutomaticTextReplacementEnabled]):
2545         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2546         (+[WebView _setCacheModel:]):
2547         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2548         (-[WebView _keyboardUIMode]):
2549         (LayerFlushController::flushLayers):
2550         (-[WebView _scheduleCompositingLayerFlush]):
2551         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2552         (-[WebView fullScreenPlaceholderView]):
2553         (WebInstallMemoryPressureHandler):
2554         * WebView/WebViewData.h:
2555         * WebView/WebViewData.mm:
2556         (+[WebViewPrivate initialize]):
2557         (-[WebViewPrivate init]):
2558         (-[WebViewPrivate dealloc]):
2559         * WebView/WebViewInternal.h:
2560
2561 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2562
2563         Clean up FrameLoader two-state enums
2564         https://bugs.webkit.org/show_bug.cgi?id=190731
2565
2566         Reviewed by Chris Dumez.
2567
2568         * WebCoreSupport/WebFrameLoaderClient.h:
2569         * WebCoreSupport/WebFrameLoaderClient.mm:
2570         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2571
2572 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2573
2574         Unreviewed, rolling out r237137.
2575
2576         SPI is actually used
2577
2578         Reverted changeset:
2579
2580         "Remove unused WebFrame._loadType"
2581         https://bugs.webkit.org/show_bug.cgi?id=190583
2582         https://trac.webkit.org/changeset/237137
2583
2584 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2585
2586         Enable the datalist element by default on iOS and macOS
2587         https://bugs.webkit.org/show_bug.cgi?id=190594
2588         <rdar://problem/45281159>
2589
2590         Reviewed by Ryosuke Niwa and Tim Horton.
2591
2592         * Configurations/FeatureDefines.xcconfig:
2593
2594 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2595
2596         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2597         https://bugs.webkit.org/show_bug.cgi?id=190675
2598
2599         Reviewed by Chris Dumez.
2600
2601         * History/BackForwardList.h:
2602         * History/BackForwardList.mm:
2603         (BackForwardList::backItem):
2604         (BackForwardList::currentItem):
2605         (BackForwardList::forwardItem):
2606         (BackForwardList::backListCount const):
2607         (BackForwardList::forwardListCount const):
2608         (BackForwardList::itemAtIndex):
2609         * History/WebBackForwardList.mm:
2610         (-[WebBackForwardList backItem]):
2611         (-[WebBackForwardList currentItem]):
2612         (-[WebBackForwardList forwardItem]):
2613         (-[WebBackForwardList itemAtIndex:]):
2614
2615 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2616
2617         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2618         https://bugs.webkit.org/show_bug.cgi?id=190526
2619         rdar://problem/45230140
2620
2621         Reviewed by Dean Jackson.
2622
2623         * WebCoreSupport/WebEditorClient.mm:
2624         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2625
2626 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2627
2628         Implement feature flag and bindings for CSS Painting API
2629         https://bugs.webkit.org/show_bug.cgi?id=190237
2630
2631         Reviewed by Ryosuke Niwa.
2632
2633         * Configurations/FeatureDefines.xcconfig:
2634
2635 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2636
2637         Replace HistoryItem* with HistoryItem& where possible
2638         https://bugs.webkit.org/show_bug.cgi?id=190617
2639
2640         Reviewed by Chris Dumez.
2641
2642         * History/BackForwardList.h:
2643         * History/BackForwardList.mm:
2644         (BackForwardList::goToItem):
2645         * History/WebBackForwardList.mm:
2646         (-[WebBackForwardList goToItem:]):
2647         * History/WebHistoryItem.mm:
2648         (WKNotifyHistoryItemChanged):
2649         * History/WebHistoryItemInternal.h:
2650
2651 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2652
2653         Remove unused WebHistoryItem._transientPropertyForKey
2654         https://bugs.webkit.org/show_bug.cgi?id=190606
2655
2656         Reviewed by Chris Dumez.
2657
2658         * History/WebHistoryItem.mm:
2659         * History/WebHistoryItemPrivate.h:
2660
2661 2018-10-15  Justin Fan  <justin_fan@apple.com>
2662
2663         Add WebGPU 2018 feature flag and experimental feature flag
2664         https://bugs.webkit.org/show_bug.cgi?id=190509
2665
2666         Reviewed by Dean Jackson.
2667
2668         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2669         for the 2018 WebGPU prototype.
2670
2671         * Configurations/FeatureDefines.xcconfig:
2672         * WebView/WebPreferenceKeysPrivate.h:
2673         * WebView/WebPreferences.mm:
2674         (+[WebPreferences initialize]):
2675         (-[WebPreferences webGPUEnabled]):
2676         (-[WebPreferences setWebGPUEnabled:]):
2677         * WebView/WebPreferencesPrivate.h:
2678         * WebView/WebView.mm:
2679         (-[WebView _preferencesChanged:]):
2680
2681 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2682
2683         Fix iOS build after r237157
2684
2685         * WebView/WebView.mm:
2686         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2687
2688 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2689
2690         Modernize BackForwardClient.h
2691         https://bugs.webkit.org/show_bug.cgi?id=190610
2692
2693         Reviewed by Chris Dumez.
2694
2695         * History/BackForwardList.h:
2696         * History/BackForwardList.mm:
2697         (BackForwardList::backListCount const):
2698         (BackForwardList::forwardListCount const):
2699         (BackForwardList::backListCount): Deleted.
2700         (BackForwardList::forwardListCount): Deleted.
2701         * History/WebBackForwardList.mm:
2702         (-[WebBackForwardList init]):
2703         * WebCoreSupport/WebFrameLoaderClient.mm:
2704         (WebFrameLoaderClient::canCachePage const):
2705         * WebView/WebFrameView.mm:
2706         (-[WebFrameView keyDown:keyDown:]):
2707         * WebView/WebView.mm:
2708         (-[WebView _commonInitializationWithFrameName:groupName:]):
2709         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2710         (-[WebView _loadBackForwardListFromOtherView:]):
2711         (-[WebView initWithCoder:]):
2712         (-[WebView encodeWithCoder:]):
2713         (-[WebView backForwardList]):
2714         (-[WebView setMaintainsBackForwardList:]):
2715
2716 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2717
2718         Add support for prefers-color-scheme media query
2719         https://bugs.webkit.org/show_bug.cgi?id=190499
2720         rdar://problem/45212025
2721
2722         Reviewed by Dean Jackson.
2723
2724         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2725
2726 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2727
2728         Remove unused WebView._globalHistoryItem
2729         https://bugs.webkit.org/show_bug.cgi?id=190601
2730
2731         Reviewed by Chris Dumez.
2732
2733         * WebCoreSupport/WebFrameLoaderClient.h:
2734         * WebCoreSupport/WebFrameLoaderClient.mm:
2735         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2736         * WebView/WebView.mm:
2737         (-[WebView _globalHistoryItem]): Deleted.
2738         (-[WebView _setGlobalHistoryItem:]): Deleted.
2739         * WebView/WebViewData.h:
2740         * WebView/WebViewInternal.h:
2741         * WebView/WebViewPrivate.h:
2742
2743 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2744
2745         Remove unused parameters from FrameLoaderClient::createFrame
2746         https://bugs.webkit.org/show_bug.cgi?id=190587
2747
2748         Reviewed by Chris Dumez.
2749
2750         * WebCoreSupport/WebFrameLoaderClient.h:
2751         * WebCoreSupport/WebFrameLoaderClient.mm:
2752         (WebFrameLoaderClient::createFrame):
2753
2754 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2755
2756         Remove unused WebFrame._loadType
2757         https://bugs.webkit.org/show_bug.cgi?id=190583
2758
2759         Reviewed by Chris Dumez.
2760
2761         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2762
2763         * WebView/WebFrame.mm:
2764         (toWebFrameLoadType): Deleted.
2765         (-[WebFrame _loadType]): Deleted.
2766         * WebView/WebFramePrivate.h:
2767
2768 2018-10-15  Chris Dumez  <cdumez@apple.com>
2769
2770         Restrict browsing context lookup by name to frames that are related to one another
2771         https://bugs.webkit.org/show_bug.cgi?id=190475
2772
2773         Reviewed by Alex Christensen.
2774
2775         * WebView/WebFrame.mm:
2776         (-[WebFrame findFrameNamed:]):
2777
2778 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2779
2780         Remove InjectedBundle processing of back/forward lists
2781         https://bugs.webkit.org/show_bug.cgi?id=190459
2782
2783         Reviewed by Chris Dumez.
2784
2785         * WebCoreSupport/WebFrameLoaderClient.h:
2786         * WebCoreSupport/WebFrameLoaderClient.mm:
2787         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2788
2789 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2790
2791         [JSC] Remove Option::useAsyncIterator
2792         https://bugs.webkit.org/show_bug.cgi?id=190567
2793
2794         Reviewed by Saam Barati.
2795
2796         * Configurations/FeatureDefines.xcconfig:
2797
2798 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2799
2800         Allow encoding of small enum classes
2801         https://bugs.webkit.org/show_bug.cgi?id=190531
2802
2803         Reviewed by Tim Horton.
2804
2805         * WebCoreSupport/WebFrameLoaderClient.mm:
2806         (-[WebFramePolicyListener dealloc]):
2807
2808 2018-10-11  Keith Rollin  <krollin@apple.com>
2809
2810         CURRENT_ARCH should not be used in Run Script phase.
2811         https://bugs.webkit.org/show_bug.cgi?id=190407
2812         <rdar://problem/45133556>
2813
2814         Reviewed by Alexey Proskuryakov.
2815
2816         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2817         CURRENT_ARCH is not well-defined during this phase (and may even have
2818         the value "undefined") since this phase is run just once per build
2819         rather than once per supported architecture. Migrate away from
2820         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2821         performing an operation for each value, or by picking the first entry
2822         in ARCHS and using that as a representative value.
2823
2824         * Configurations/WebKitLegacy.xcconfig: When generating
2825         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2826         macosx platforms.
2827
2828         * MigrateHeaders.make:
2829         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2830         generate one for each architecture in ARCHS.
2831
2832 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2833
2834         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2835         https://bugs.webkit.org/show_bug.cgi?id=190429
2836
2837         Reviewed by Saam Barati.
2838
2839         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2840
2841         * WebView/WebPDFRepresentation.mm:
2842         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2843
2844 2018-10-08  Justin Fan  <justin_fan@apple.com>
2845
2846         WebGPU: Rename old WebGPU prototype to WebMetal
2847         https://bugs.webkit.org/show_bug.cgi?id=190325
2848         <rdar://problem/44990443>
2849
2850         Reviewed by Dean Jackson.
2851
2852         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2853
2854         * Configurations/FeatureDefines.xcconfig:
2855         * WebView/WebPreferenceKeysPrivate.h:
2856         * WebView/WebPreferences.mm:
2857         (+[WebPreferences initialize]):
2858         (-[WebPreferences webMetalEnabled]):
2859         (-[WebPreferences setWebMetalEnabled:]):
2860         (-[WebPreferences webGPUEnabled]): Deleted.
2861         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2862         * WebView/WebPreferencesPrivate.h:
2863         * WebView/WebView.mm:
2864         (-[WebView _preferencesChanged:]):
2865
2866 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2867
2868         Make <input type=color> a runtime enabled (on-by-default) feature
2869         https://bugs.webkit.org/show_bug.cgi?id=189162
2870
2871         Reviewed by Wenson Hsieh and Tim Horton.
2872
2873         * Configurations/FeatureDefines.xcconfig:
2874
2875 2018-10-07  Dan Bernstein  <mitz@apple.com>
2876
2877         Fixed building with the latest macOS SDK
2878
2879         * Plugins/WebNetscapePluginPackage.mm:
2880         (-[WebNetscapePluginPackage openResourceFile]):
2881         (-[WebNetscapePluginPackage closeResourceFile:]):
2882
2883 2018-10-04  Dan Bernstein  <mitz@apple.com>
2884
2885         More Carbon build-fixing.
2886
2887         * Carbon/CarbonWindowAdapter.mm:
2888         (-[CarbonWindowAdapter _destroyRealWindow:]):
2889         (-[CarbonWindowAdapter _growBoxRect]):
2890
2891 2018-10-04  Dan Bernstein  <mitz@apple.com>
2892
2893         Retried to fix 32-bit macOS builds after r236846.
2894
2895         * WebView/WebHTMLView.mm:
2896         (-[WebHTMLView setMarkedText:selectedRange:]):
2897
2898 2018-10-04  Dan Bernstein  <mitz@apple.com>
2899
2900         Retried to fix 32-bit macOS builds after r236846.
2901
2902         * Carbon/HIWebView.mm:
2903         (ActiveStateChanged):
2904
2905 2018-10-04  Dan Bernstein  <mitz@apple.com>
2906
2907         Tried to fix 32-bit macOS builds after r236846.
2908
2909         * Carbon/HIWebView.mm:
2910         (_NSSelectorForHICommand):
2911
2912 2018-10-04  Dan Bernstein  <mitz@apple.com>
2913
2914         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2915         https://bugs.webkit.org/show_bug.cgi?id=190250
2916
2917         Reviewed by Andy Estes.
2918
2919         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2920           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2921           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2922           an earlier line set it to YES.
2923
2924         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2925         changes below.
2926
2927         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2928           provides some missing method declarations.
2929
2930         * Misc/WebDownload.mm:
2931         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2932           a deprecated method.
2933
2934         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2935
2936         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2937           other code in the file uses a method from it.
2938
2939         * Plugins/WebBaseNetscapePluginView.mm:
2940         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2941           a deprecated method.
2942
2943         * Plugins/WebPluginController.mm:
2944         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2945           around use of a selector that may be present in some WebKit client.
2946
2947         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2948           method declarations.
2949
2950         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2951           from here.
2952
2953         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2954           missing method declarations.
2955
2956         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2957           from here.
2958
2959         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2960           call from here.
2961         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2962           an obsolete delegate method for binary compatibility.
2963         (pluginView): Ditto.
2964
2965         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2966           call from here.
2967
2968         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
2969           WebDeviceOrientationProviderMock protocol.
2970
2971         * WebView/WebDeviceOrientationProviderMock.mm:
2972         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
2973           main @implementation.
2974
2975         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
2976           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
2977
2978         * WebView/WebDynamicScrollBarsView.mm:
2979         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
2980           of a deprecated method.
2981
2982         * WebView/WebHTMLView.mm:
2983         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
2984           selector warning around action methods that are not declared anywhere in WebKit.
2985
2986         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
2987           about implementing this deprecated method.
2988         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
2989         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
2990         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
2991         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
2992         (-[WebHTMLView characterIndexForPoint:]): Ditto.
2993         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
2994         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
2995         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
2996         (-[WebHTMLView doCommandBySelector:]): Ditto.
2997         (-[WebHTMLView insertText:]): Ditto.
2998
2999         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
3000
3001         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
3002
3003         * WebView/WebPDFView.h: Removed previewView ivar.
3004
3005         * WebView/WebPDFView.mm:
3006           Removed declaration of FileInternal category and merged its implementation with the main
3007           implementation.
3008         (-[WebPDFView dealloc]): Removed previewView ivar.
3009         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
3010           exist in macOS versions we support.
3011         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
3012         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
3013           action methods internal to PDFKit.
3014         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
3015         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
3016
3017         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
3018           call on macOS, even though in r86988 we started calling different methods on iOS.
3019
3020         * WebView/WebView.mm:
3021         - Imported headers that declare delegate methods that we call.
3022         - Removed declaration of WebFileInternal category and merged its implementation with the
3023           main implementation.
3024         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
3025           category, which made them impossible to call from the main implementation. Moved those
3026           into the main implementation. One of those had to be declared in a class extension,
3027           because it is called from a method implemented in the WebPrivate category, and that
3028           category’s implementation appears first in the file.
3029
3030         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
3031           around use of obsolete delegate method for binary compatibility.
3032
3033         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
3034
3035 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3036
3037         Runtime flag and IDL for MediaRecorder
3038         https://bugs.webkit.org/show_bug.cgi?id=190018
3039
3040         Reviewed by Youenn Fablet and Chris Dumez.
3041
3042         * WebView/WebPreferenceKeysPrivate.h:
3043         * WebView/WebPreferences.mm:
3044         (+[WebPreferences initialize]):
3045         (-[WebPreferences mediaRecorderEnabled]):
3046         (-[WebPreferences setMediaRecorderEnabled:]):
3047         * WebView/WebPreferencesPrivate.h:
3048         * WebView/WebView.mm:
3049         (-[WebView _preferencesChanged:]):
3050
3051 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3052
3053         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3054         https://bugs.webkit.org/show_bug.cgi?id=190238
3055
3056         Reviewed by Antti Koivisto.
3057
3058         Enabled the feature by default.
3059
3060         * WebView/WebPreferences.mm:
3061         (+[WebPreferences initialize]):
3062
3063 2018-10-01  Dean Jackson  <dino@apple.com>
3064
3065         [macOS] Switching to discrete GPU should be done in the UI process
3066         https://bugs.webkit.org/show_bug.cgi?id=189361
3067         <rdar://problem/43949622>
3068
3069         Reviewed by Simon Fraser.
3070
3071         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
3072         not support swapping to the discrete GPU in this configuration.
3073
3074         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
3075         (WebKit::WebSwitchingGPUClient::singleton):
3076         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
3077         * WebView/WebView.mm:
3078         (-[WebView _commonInitializationWithFrameName:groupName:]):
3079
3080 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3081
3082         Remove ParsedURLString
3083         https://bugs.webkit.org/show_bug.cgi?id=190154
3084
3085         Reviewed by Chris Dumez.
3086
3087         * WebView/WebScriptDebugger.mm:
3088         (toNSURL):
3089
3090 2018-10-01  Dean Jackson  <dino@apple.com>
3091
3092         Remove CSS Animation Triggers
3093         https://bugs.webkit.org/show_bug.cgi?id=190175
3094         <rdar://problem/44925626>
3095
3096         Reviewed by Simon Fraser.
3097
3098         * Configurations/FeatureDefines.xcconfig:
3099
3100 2018-10-02  Commit Queue  <commit-queue@webkit.org>
3101
3102         Unreviewed, rolling out r236624 and r236671.
3103         https://bugs.webkit.org/show_bug.cgi?id=190207
3104
3105         The change in r236624 introduced crashes on the bots
3106         (Requested by ryanhaddad on #webkit).
3107
3108         Reverted changesets:
3109
3110         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3111         https://bugs.webkit.org/show_bug.cgi?id=188747
3112         https://trac.webkit.org/changeset/236624
3113
3114         "Unify implementation in VideoFullscreenInterfaceAVKit"
3115         https://bugs.webkit.org/show_bug.cgi?id=190091
3116         https://trac.webkit.org/changeset/236671
3117
3118 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3119
3120         URL should not use TextEncoding internally
3121         https://bugs.webkit.org/show_bug.cgi?id=190111
3122
3123         Reviewed by Andy Estes.
3124
3125         * Misc/WebNSURLExtras.mm:
3126
3127 2018-09-28  Jer Noble  <jer.noble@apple.com>
3128
3129         Refactoring: eliminate raw pointer usage in Fullscreen code
3130         https://bugs.webkit.org/show_bug.cgi?id=188747
3131         <rdar://problem/43541164>
3132
3133         Reviewed by Alex Christensen.
3134
3135         PlaybackSessionInterface no longer has an invalidate() method.
3136
3137         * WebView/WebView.mm:
3138         (-[WebView _clearPlaybackControlsManager]):
3139
3140 2018-09-28  Chris Dumez  <cdumez@apple.com>
3141
3142         Drop support for cross-origin-window-policy header
3143         https://bugs.webkit.org/show_bug.cgi?id=190081
3144
3145         Reviewed by Ryosuke Niwa.
3146
3147         * WebView/WebPreferenceKeysPrivate.h:
3148         * WebView/WebPreferences.mm:
3149         (+[WebPreferences initialize]):
3150         * WebView/WebPreferencesPrivate.h:
3151         * WebView/WebView.mm:
3152         (-[WebView _preferencesChanged:]):
3153
3154 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3155
3156         Rename createMarkup to serializePreservingVisualAppearance
3157         https://bugs.webkit.org/show_bug.cgi?id=190086
3158
3159         Reviewed by Wenson Hsieh.
3160
3161         * DOM/WebDOMOperations.mm:
3162         (-[DOMRange markupString]):
3163
3164 2018-09-28  Commit Queue  <commit-queue@webkit.org>
3165
3166         Unreviewed, rolling out r236605.
3167         https://bugs.webkit.org/show_bug.cgi?id=190087
3168
3169         caused three API test timeouts (Requested by jernoble on
3170         #webkit).
3171
3172         Reverted changeset:
3173
3174         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3175         https://bugs.webkit.org/show_bug.cgi?id=188747
3176         https://trac.webkit.org/changeset/236605
3177
3178 2018-09-28  Jer Noble  <jer.noble@apple.com>
3179
3180         Refactoring: eliminate raw pointer usage in Fullscreen code
3181         https://bugs.webkit.org/show_bug.cgi?id=188747
3182         <rdar://problem/43541164>
3183
3184         Reviewed by Alex Christensen.
3185
3186         PlaybackSessionInterface no longer has an invalidate() method.
3187
3188         * WebView/WebView.mm:
3189         (-[WebView _clearPlaybackControlsManager]):
3190
3191 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3192
3193         Use enum class in createMarkup arguments
3194         https://bugs.webkit.org/show_bug.cgi?id=190028
3195
3196         Reviewed by Wenson Hsieh.
3197
3198         * DOM/WebDOMOperations.mm:
3199         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
3200         (-[DOMRange markupString]): Ditto.
3201
3202 2018-09-27  Antoine Quint  <graouts@apple.com>
3203
3204         [Web Animations] Turn Web Animations with CSS integration on
3205         https://bugs.webkit.org/show_bug.cgi?id=184819
3206         <rdar://problem/39597337>
3207
3208         Reviewed by Dean Jackson.
3209
3210         * WebView/WebPreferences.mm:
3211         (+[WebPreferences initialize]):
3212
3213 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3214
3215         Selection should work across shadow boundary when initiated by a mouse drag
3216         https://bugs.webkit.org/show_bug.cgi?id=151380
3217         <rdar://problem/24363872>
3218
3219         Reviewed by Wenson Hsieh.
3220
3221         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
3222
3223         * WebView/WebPreferenceKeysPrivate.h:
3224         * WebView/WebPreferences.mm:
3225         (+[WebPreferences initialize]):
3226         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
3227         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
3228         * WebView/WebPreferencesPrivate.h:
3229         * WebView/WebView.mm:
3230         (-[WebView _preferencesChanged:]):
3231
3232 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3233
3234         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3235         https://bugs.webkit.org/show_bug.cgi?id=189918
3236         Work towards <rdar://problem/44648705>
3237
3238         Reviewed by Tim Horton.
3239
3240         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3241
3242         * WebView/WebHTMLView.mm:
3243         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3244         (-[WebHTMLView _updateFontPanel]):
3245         * WebView/WebView.mm:
3246         (-[WebView typingAttributes]):
3247
3248 2018-09-17  Darin Adler  <darin@apple.com>
3249
3250         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3251         https://bugs.webkit.org/show_bug.cgi?id=189652
3252
3253         Reviewed by Saam Barati.
3254
3255         * WebView/WebPDFRepresentation.mm:
3256         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3257
3258 2018-09-14  Jer Noble  <jer.noble@apple.com>
3259
3260         Turn SourceBufferChangeTypeEnabled on by default
3261         https://bugs.webkit.org/show_bug.cgi?id=189527
3262
3263         Reviewed by Eric Carlson.
3264
3265         * WebView/WebPreferences.mm:
3266         (+[WebPreferences initialize]):
3267
3268 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3269
3270         Fix an internal build after r235935
3271         https://bugs.webkit.org/show_bug.cgi?id=188996
3272
3273         * Carbon/HIWebView.mm:
3274         (Draw):
3275         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3276
3277 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3278
3279         Add IGNORE_WARNING_.* macros
3280         https://bugs.webkit.org/show_bug.cgi?id=188996
3281
3282         Reviewed by Michael Catanzaro.
3283
3284         * Carbon/CarbonUtils.m:
3285         (PoolCleaner):
3286         * Carbon/CarbonWindowAdapter.mm:
3287         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3288         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3289         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3290         (-[CarbonWindowAdapter _termWindowIfOwner]):
3291         (-[CarbonWindowAdapter _windowMovedToRect:]):
3292         (-[CarbonWindowAdapter setContentView:]):
3293         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3294         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3295         * Carbon/CarbonWindowFrame.m:
3296         (-[CarbonWindowFrame title]):
3297         * Carbon/HIViewAdapter.m:
3298         (+[HIViewAdapter getHIViewForNSView:]):
3299         * Carbon/HIWebView.mm:
3300         (overrideCGContext):
3301         (restoreCGContext):
3302         (Draw):
3303         * DOM/DOM.mm:
3304         * History/WebHistory.mm:
3305         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3306         * History/WebHistoryItem.mm:
3307         (-[WebHistoryItem icon]):
3308         * Misc/WebKitNSStringExtras.mm:
3309         (-[NSString _web_drawAtPoint:font:textColor:]):
3310         * Misc/WebNSImageExtras.m:
3311         (-[NSImage _web_scaleToMaxSize:]):
3312         (-[NSImage _web_dissolveToFraction:]):
3313         * Misc/WebNSPasteboardExtras.mm:
3314         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3315         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3316         * Panels/WebAuthenticationPanel.m:
3317         (-[WebAuthenticationPanel loadNib]):
3318         * Plugins/Hosted/NetscapePluginHostManager.mm:
3319         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3320         (WebKit::NetscapePluginHostManager::didCreateWindow):
3321         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3322         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3323         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3324         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3325         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3326         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3327         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3328         (-[WebHostedNetscapePluginView drawRect:]):
3329         * Plugins/Hosted/WebTextInputWindowController.m:
3330         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3331         * Plugins/WebBaseNetscapePluginView.mm:
3332         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3333         * Plugins/WebNetscapePluginPackage.mm:
3334         (-[WebNetscapePluginPackage _tryLoad]):
3335         * Plugins/WebNetscapePluginView.mm:
3336         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3337         (-[WebNetscapePluginView sendDrawRectEvent:]):
3338         (-[WebNetscapePluginView drawRect:]):
3339         * Plugins/WebPluginController.mm:
3340         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3341         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3342         * WebCoreSupport/PopupMenuMac.mm:
3343         (PopupMenuMac::populate):
3344         * WebCoreSupport/WebAlternativeTextClient.h:
3345         * WebCoreSupport/WebDragClient.mm:
3346         (WebDragClient::startDrag):
3347         * WebCoreSupport/WebFrameLoaderClient.mm:
3348         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3349         (webGetNSImage):
3350         * WebInspector/WebNodeHighlight.mm:
3351         * WebInspector/WebNodeHighlightView.mm:
3352         (-[WebNodeHighlightView drawRect:]):
3353         * WebView/WebClipView.mm:
3354         (-[WebClipView initWithFrame:]):
3355         * WebView/WebFrame.mm:
3356         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3357         (-[WebFrame _drawRect:contentsOnly:]):
3358         (-[WebFrame accessibilityRoot]):
3359         * WebView/WebFullScreenController.mm:
3360         (-[WebFullScreenController enterFullScreen:]):
3361         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3362         (-[WebFullScreenController exitFullScreen]):
3363         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3364         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3365         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3366         * WebView/WebHTMLView.mm:
3367         (-[NSWindow _web_borderView]):
3368         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3369         (-[WebHTMLView _setAsideSubviews]):
3370         (-[WebHTMLView _autoscroll]):
3371         (-[WebHTMLView drawRect:]):
3372         (-[WebHTMLView mouseDown:]):
3373         (-[WebHTMLView mouseDragged:]):
3374         (-[WebHTMLView mouseUp:]):
3375         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3376         (-[WebHTMLView knowsPageRange:]):
3377         (-[WebHTMLView accessibilityHitTest:]):
3378         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3379         (-[WebHTMLView _colorAsString:]):
3380         (-[WebHTMLView copyFont:]):
3381         (-[WebHTMLView _executeSavedKeypressCommands]):
3382         (-[WebHTMLView attachRootLayer:]):
3383         (-[WebHTMLView textStorage]):
3384         (-[WebHTMLView _updateSelectionForInputManager]):
3385         * WebView/WebPDFView.mm:
3386         (_applicationInfoForMIMEType):
3387         (-[WebPDFView centerSelectionInVisibleArea:]):
3388         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3389         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3390         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3391         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3392         * WebView/WebTextCompletionController.mm:
3393         (-[WebTextCompletionController _buildUI]):
3394         (-[WebTextCompletionController _placePopupWindow:]):
3395         * WebView/WebVideoFullscreenController.mm:
3396         * WebView/WebVideoFullscreenHUDWindowController.mm:
3397         (createMediaUIBackgroundView):
3398         * WebView/WebView.mm:
3399         (-[WebTextListTouchBarViewController initWithWebView:]):
3400         (-[WebView _dispatchTileDidDraw:]):
3401         (-[WebView encodeWithCoder:]):
3402         (-[WebView mainFrameIcon]):
3403         (LayerFlushController::flushLayers):
3404         * WebView/WebWindowAnimation.mm:
3405         (setScaledFrameForWindow):
3406
3407 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3408
3409         Remove unused needsDestruction class variables from HashTraits
3410         https://bugs.webkit.org/show_bug.cgi?id=189490
3411
3412         Reviewed by Daniel Bates.
3413
3414         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3415
3416 2018-09-07  Frederic Wang  <fwang@igalia.com>
3417
3418         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3419         https://bugs.webkit.org/show_bug.cgi?id=182230
3420
3421         Reviewed by Simon Fraser.
3422
3423         * DOM/DOMDocument.mm:
3424         (-[DOMDocument scrollingElement]): Use the new name.
3425
3426 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3427
3428         Refactor WebCore::EditAction to be an 8-bit enum class
3429         https://bugs.webkit.org/show_bug.cgi?id=189383
3430
3431         Reviewed by Dan Bernstein.
3432
3433         * WebCoreSupport/WebEditorClient.mm:
3434         (undoNameForEditAction):
3435         * WebView/WebHTMLView.mm:
3436         (-[WebHTMLView pasteFont:]):
3437         (-[WebHTMLView changeFont:]):
3438         (-[WebHTMLView changeAttributes:]):
3439         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3440         (-[WebHTMLView changeColor:]):
3441         * WebView/WebView.mm:
3442         (-[WebView setTypingStyle:]):
3443
3444 2018-09-06  Frederic Wang  <fwang@igalia.com>
3445
3446         Group options of scrollRectToVisible into a struct
3447         https://bugs.webkit.org/show_bug.cgi?id=189352
3448
3449         Reviewed by Simon Fraser.
3450
3451         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3452         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3453         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3454
3455 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3456
3457         [macOS] Cannot change font size at selection until font panel is shown
3458         https://bugs.webkit.org/show_bug.cgi?id=189295
3459         <rdar://problem/35593389>
3460
3461         Reviewed by Ryosuke Niwa.
3462
3463         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3464         WebCore ChangeLog for more details.
3465
3466         * WebView/WebHTMLView.mm:
3467         (-[WebHTMLView changeFont:]):
3468         (-[WebHTMLView changeAttributes:]):
3469         (-[WebHTMLView _originalFontA]): Deleted.
3470         (-[WebHTMLView _originalFontB]): Deleted.
3471         (fontNameForDescription): Deleted.
3472         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3473         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3474         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3475
3476 2018-09-05  Jer Noble  <jer.noble@apple.com>
3477
3478         Add MediaCapabilities as an Experimental Feature
3479         https://bugs.webkit.org/show_bug.cgi?id=189209
3480
3481         Reviewed by Eric Carlson.
3482
3483         RuntimeEnabledFeature -> Setting.
3484
3485         * WebView/WebView.mm:
3486         (-[WebView _preferencesChanged:]):
3487
3488 2018-09-04  Frederic Wang  <fwang@igalia.com>
3489
3490         Add basic support for ScrollIntoViewOptions
3491         https://bugs.webkit.org/show_bug.cgi?id=189258
3492
3493         Reviewed by Simon Fraser.
3494
3495         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3496         header so that this file can build despite the new scrollIntoView function.
3497
3498 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3499
3500         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3501         https://bugs.webkit.org/show_bug.cgi?id=188890
3502         <rdar://problem/43648605>
3503
3504         Reviewed by Tim Horton.
3505
3506         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3507         more detail.
3508
3509         * WebCoreSupport/WebPlatformStrategies.h:
3510         * WebCoreSupport/WebPlatformStrategies.mm:
3511         (WebPlatformStrategies::allStringsForType):
3512
3513 2018-09-01  Darin Adler  <darin@apple.com>
3514
3515         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3516         https://bugs.webkit.org/show_bug.cgi?id=189072
3517         Reviewed by Dan Bernstein.
3518
3519         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3520         and declarations for NSURLDownload init methods.
3521
3522         * Misc/WebDownloadInternal.h: Removed.
3523
3524         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3525         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3526         "-Wdeprecated-declarations" because the method used here is deprecated.
3527
3528         * WebView/WebView.mm:
3529         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3530         used here is deprecated.
3531
3532 2018-08-31  Chris Dumez  <cdumez@apple.com>
3533
3534         Assertion hit in ~CompletionHandler() from ~WebFrame()
3535         https://bugs.webkit.org/show_bug.cgi?id=189199
3536         <rdar://problem/42657233>
3537
3538         Reviewed by Youenn Fablet.
3539
3540         * WebCoreSupport/WebFrameLoaderClient.h:
3541         * WebCoreSupport/WebFrameLoaderClient.mm:
3542         (WebFrameLoaderClient::dispatchWillSubmitForm):
3543
3544 2018-08-31  Antti Koivisto  <antti@apple.com>
3545
3546         Replace OptionSet |= and -= operators with add() and remove() functions
3547         https://bugs.webkit.org/show_bug.cgi?id=189169
3548
3549         Reviewed by Anders Carlsson.
3550
3551         * WebView/WebFrame.mm:
3552         (-[WebFrame _drawRect:contentsOnly:]):
3553         * WebView/WebView.mm:
3554         (coreOptions):
3555
3556 2018-08-31  Frederic Wang  <fwang@igalia.com>
3557
3558         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3559         https://bugs.webkit.org/show_bug.cgi?id=182053
3560
3561         Reviewed by Simon Fraser.
3562
3563         Add developer flag to use standard behavior for scrolling* attributes.
3564
3565         * WebView/WebPreferenceKeysPrivate.h:
3566         * WebView/WebPreferences.mm:
3567         (+[WebPreferences initialize]):
3568         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3569         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3570         * WebView/WebPreferencesPrivate.h:
3571         * WebView/WebView.mm:
3572         (-[WebView _preferencesChanged:]):
3573
3574 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3575
3576         Implement the Web Share API
3577         https://bugs.webkit.org/show_bug.cgi?id=171100
3578         <rdar://problem/31751734>
3579
3580         Reviewed by Tim Horton.
3581
3582         * WebCoreSupport/WebChromeClient.h:
3583         * WebCoreSupport/WebChromeClient.mm:
3584         (WebChromeClient::showShareSheet):
3585         Empty declaration of showShareSheet.
3586
3587 2018-08-29  Youenn Fablet  <youenn@apple.com>
3588
3589         Remove WebRTC legacy API implementation
3590         https://bugs.webkit.org/show_bug.cgi?id=189040
3591
3592         Reviewed by Eric Carlson.
3593
3594         * WebView/WebPreferenceKeysPrivate.h:
3595         * WebView/WebPreferences.mm:
3596         (+[WebPreferences initialize]):
3597         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3598         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3599         * WebView/WebPreferencesPrivate.h:
3600         * WebView/WebView.mm:
3601         (-[WebView _preferencesChanged:]):
3602
3603 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3604
3605         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3606         https://bugs.webkit.org/show_bug.cgi?id=189054
3607
3608         Reviewed by Andy Estes.
3609
3610         Remove the pasteboard type argument from readURLFromPasteboard.
3611
3612         * WebCoreSupport/WebPlatformStrategies.h:
3613         * WebCoreSupport/WebPlatformStrategies.mm:
3614         (WebPlatformStrategies::readURLFromPasteboard):
3615
3616 2018-08-27  Keith Rollin  <krollin@apple.com>
3617
3618         Unreviewed build fix -- disable LTO for production builds
3619
3620         * Configurations/Base.xcconfig:
3621
3622 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3623
3624         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3625         https://bugs.webkit.org/show_bug.cgi?id=188931
3626
3627         Reviewed by Wenson Hsieh.
3628
3629         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3630
3631 2018-08-27  Keith Rollin  <krollin@apple.com>
3632
3633         Build system support for LTO
3634         https://bugs.webkit.org/show_bug.cgi?id=187785
3635         <rdar://problem/42353132>
3636
3637         Reviewed by Dan Bernstein.
3638
3639         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3640         LTO.
3641
3642         * Configurations/Base.xcconfig:
3643         * Configurations/DebugRelease.xcconfig:
3644
3645 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3646
3647         Pass in IsComposed flag to Event constructors
3648         https://bugs.webkit.org/show_bug.cgi?id=188720
3649         <rdar://problem/43580387>
3650
3651         Reviewed by Simon Fraser.
3652
3653         * WebView/WebPDFView.mm:
3654         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3655         whether it's simulated or not.
3656
3657 2018-08-23  Mark Lam  <mark.lam@apple.com>
3658
3659         Move vmEntryGlobalObject() to VM from CallFrame.
3660         https://bugs.webkit.org/show_bug.cgi?id=188900
3661         <rdar://problem/43655753>
3662
3663         Reviewed by Michael Saboff.
3664
3665         * WebView/WebScriptDebugger.mm:
3666         (WebScriptDebugger::sourceParsed):
3667
3668 2018-08-23  Andy Estes  <aestes@apple.com>
3669
3670         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3671         https://bugs.webkit.org/show_bug.cgi?id=188829
3672
3673         Reviewed by Tim Horton.
3674
3675         * Configurations/FeatureDefines.xcconfig:
3676
3677 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3678
3679         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3680         https://bugs.webkit.org/show_bug.cgi?id=188777
3681
3682         Reviewed by Simon Fraser.
3683
3684         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3685         being "true" before the code change.
3686
3687         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3688
3689         * WebView/WebPDFView.mm:
3690         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3691
3692 2018-08-21  Daniel Bates  <dabates@apple.com>
3693
3694         Replace TextCheckingTypeMask with OptionSet
3695         https://bugs.webkit.org/show_bug.cgi?id=188678
3696
3697         Reviewed by Antti Koivisto.
3698
3699         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3700         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3701         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3702         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3703
3704         * WebCoreSupport/WebEditorClient.h:
3705         * WebCoreSupport/WebEditorClient.mm:
3706         (WebEditorClient::checkTextOfParagraph):
3707         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3708         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3709         left as this is more readable and unncessary now that modern compilers like Clang have
3710         diagnostics to catch accidental assignments when equality was intended.
3711         (WebEditorClient::didCheckSucceed):
3712         * WebView/WebView.mm:
3713         (coreTextCheckingType):
3714         (textCheckingResultFromNSTextCheckingResult):
3715
3716 2018-08-21  Daniel Bates  <dabates@apple.com>
3717
3718         [iOS][WK1] Support toggling continuous spell checking from tests
3719         https://bugs.webkit.org/show_bug.cgi?id=188763
3720
3721         Reviewed by Simon Fraser.
3722
3723         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3724         spell checking from tests in iOS WebKit Legacy.
3725
3726         * WebCoreSupport/WebEditorClient.h:
3727         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3728         * WebCoreSupport/WebEditorClient.mm:
3729         * WebView/WebView.h:
3730         * WebView/WebView.mm:
3731         (-[WebView toggleContinuousSpellChecking:]):
3732         (-[WebView toggleSmartInsertDelete:]):
3733
3734 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3735
3736         Add some plumbing for safe browsing
3737         https://bugs.webkit.org/show_bug.cgi?id=188709
3738
3739         Reviewed by Tim Horton.
3740
3741         * WebCoreSupport/WebFrameLoaderClient.h:
3742         * WebCoreSupport/WebFrameLoaderClient.mm:
3743         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3744
3745 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3746
3747         Replace canBubble and cancelable booleans in Event by enum classes
3748         https://bugs.webkit.org/show_bug.cgi?id=188692
3749
3750         Reviewed by Alex Christensen.
3751
3752         * WebView/WebPDFView.mm:
3753         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3754         * WebView/WebView.mm:
3755         (-[WebView _dispatchUnloadEvent]):
3756
3757 2018-08-16  Jer Noble  <jer.noble@apple.com>
3758
3759         Add Experimental Feature support for SourceBuffer.changeType()
3760         https://bugs.webkit.org/show_bug.cgi?id=188626
3761         <rdar://problem/43356021>
3762
3763         Reviewed by Eric Carlson.
3764
3765         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3766
3767         * WebView/WebPreferenceKeysPrivate.h:
3768         * WebView/WebPreferences.mm:
3769         (+[WebPreferences initialize]):
3770         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3771         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3772         * WebView/WebPreferencesPrivate.h:
3773         * WebView/WebView.mm:
3774         (-[WebView _preferencesChanged:]):
3775
3776 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3777
3778         Support drag-and-drop for input[type=color]
3779         https://bugs.webkit.org/show_bug.cgi?id=188464
3780
3781         Reviewed by Wenson Hsieh.
3782
3783         * WebCoreSupport/WebPlatformStrategies.h:
3784         * WebCoreSupport/WebPlatformStrategies.mm:
3785         (WebPlatformStrategies::setColor):
3786
3787 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3788
3789         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3790         https://bugs.webkit.org/show_bug.cgi?id=188569
3791         <rdar://problem/34201095>
3792
3793         Reviewed by Megan Gardner.
3794
3795         * WebView/WebImmediateActionController.mm:
3796         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3797         Speculative fix; the crashes indicate font is null, but we just checked it,
3798         so it must be getting made null by convertFont:toSize:. Check again!
3799
3800 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3801
3802         Use a 1-byte enum class for TextDirection
3803         https://bugs.webkit.org/show_bug.cgi?id=188350
3804
3805         Reviewed by Simon Fraser.
3806
3807         * WebCoreSupport/PopupMenuMac.mm:
3808         (PopupMenuMac::populate):
3809         (PopupMenuMac::show):
3810         * WebCoreSupport/WebFrameLoaderClient.mm:
3811         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3812         * WebView/WebFrame.mm:
3813         (-[WebFrame _dispatchDidReceiveTitle:]):
3814
3815 2018-08-09  Ali Juma  <ajuma@chromium.org>
3816
3817         Import WPTs for IntersectionObserver
3818         https://bugs.webkit.org/show_bug.cgi?id=188416
3819
3820         Reviewed by Simon Fraser.
3821
3822         * WebView/WebPreferencesPrivate.h:
3823
3824 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3825
3826         Follow-up build fix for r234685
3827         https://bugs.webkit.org/show_bug.cgi?id=188245
3828
3829         Unreviewed build fix.
3830
3831         * WebCoreSupport/WebSecurityOriginPrivate.h:
3832
3833 2018-08-05  Darin Adler  <darin@apple.com>
3834
3835         [Cocoa] More tweaks and refactoring to prepare for ARC
3836         https://bugs.webkit.org/show_bug.cgi?id=188245
3837
3838         Reviewed by Dan Bernstein.
3839
3840         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3841
3842         * Carbon/CarbonWindowFrame.m:
3843         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3844
3845         * DOM/DOM.mm:
3846         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3847         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3848         garbage collection so this method isn't useful.
3849
3850         * DOM/DOMXPath.mm:
3851         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3852         Objective-C garbage collection so this method isn't useful.
3853
3854         * History/WebHistory.mm:
3855         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3856
3857         * Misc/WebElementDictionary.mm:
3858         (addLookupKey): Use a bridging cast.
3859         (cacheValueForKey): Ditto.
3860         (-[WebElementDictionary _fillCache]): Ditto.
3861         (-[WebElementDictionary objectForKey:]): Ditto.
3862
3863         * Misc/WebKitNSStringExtras.mm:
3864         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3865         (-[NSString _web_widthWithFont:]): Ditto.
3866         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3867
3868         * Misc/WebLocalizableStrings.mm:
3869         (WebLocalizedString): Use a bridging cast.
3870
3871         * Misc/WebNSDataExtras.mm:
3872         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3873         and use CFBridgingRelease instead of calling autorelease directly.
3874         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3875         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3876         on the amount of explicit release and autorelease.
3877
3878         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3879         * Misc/WebNSDictionaryExtras.m:
3880         (-[NSDictionary _webkit_intForKey:]): Deleted.
3881         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3882         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3883         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3884         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3885         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3886         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3887
3888         * Misc/WebStringTruncator.mm:
3889         (fontFromNSFont): Use a bridging cast.
3890
3891         * Plugins/Hosted/NetscapePluginHostManager.mm:
3892         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3893
3894         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3895         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3896         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3897         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3898         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3899         * Plugins/Hosted/ProxyInstance.mm:
3900         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3901         * Plugins/WebBasePluginPackage.mm:
3902         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3903         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3904         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3905         * Plugins/WebNetscapePluginPackage.mm:
3906         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3907
3908         * Plugins/WebNetscapePluginView.mm:
3909         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3910         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3911         (-[WebNetscapePluginView status:]): Use a bridging cast.
3912         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3913
3914         * Plugins/WebPluginController.mm:
3915         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3916
3917         * Plugins/WebPluginDatabase.mm:
3918         (checkCandidate): Use explicit __strong for out argument types.
3919
3920         * Plugins/npapi.mm:
3921         (pluginViewForInstance): Use a bridging cast.
3922
3923         * Storage/WebDatabaseManager.mm:
3924         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3925         explicit NSNumber and NSDictionary calls.
3926
3927         * WebCoreSupport/WebContextMenuClient.mm:
3928         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3929
3930         * WebCoreSupport/WebEditorClient.mm:
3931         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3932         (WebEditorClient::handleInputMethodKeydown): Ditto.
3933
3934         * WebCoreSupport/WebFrameNetworkingContext.mm:
3935         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3936
3937         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3938         as a struct rather than an Objective-C class, since that's how it's defined.
3939
3940         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3941
3942         * WebView/WebFullScreenController.mm:
3943         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3944         * WebView/WebHTMLView.mm:
3945         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3946         Ditto.
3947         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3948
3949         * WebView/WebImmediateActionController.mm:
3950         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3951         go down to the document and then back to the frame.
3952         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3953         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3954         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3955
3956         * WebView/WebJSPDFDoc.mm:
3957         (jsPDFDocInitialize): Removed some unneeded type casting.
3958         (jsPDFDocFinalize): Ditto.
3959         (jsPDFDocPrint): Use a bridging cast.
3960
3961         * WebView/WebPDFView.mm:
3962         (_applicationInfoForMIMEType): Use bridging casts.
3963
3964         * WebView/WebPreferences.mm:
3965         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3966         instead of methods from WebNSDictionaryExtras.
3967         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
3968         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
3969         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
3970         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
3971         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
3972
3973         * WebView/WebView.mm:
3974         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
3975         (-[WebView _addToAllWebViewsSet]): Ditto.
3976         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
3977         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
3978         so it can be called from WebViewData methods.
3979
3980         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
3981         method, _windowVisibilityChanged:.
3982
3983         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
3984         called from WebViewData methods.
3985
3986 2018-08-06  Alex Christensen  <achristensen@webkit.org>
3987
3988         Use enum classes and OptionSets for PaintPhase and PaintBehavior
3989         https://bugs.webkit.org/show_bug.cgi?id=188323
3990
3991         Reviewed by Simon Fraser.
3992
3993         * WebCoreSupport/WebContextMenuClient.mm:
3994         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
3995         * WebView/WebFrame.mm:
3996         (-[WebFrame _paintBehaviorForDestinationContext:]):
3997         (-[WebFrame _drawRect:contentsOnly:]):
3998         * WebView/WebHTMLView.mm:
3999         (imageFromRect):
4000         (selectionImage):
4001
4002 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
4003
4004         Add support for microtasks in workers
4005         https://bugs.webkit.org/show_bug.cgi?id=188246
4006
4007         Reviewed by Darin Adler.
4008
4009         Rename JSMainThreadExecState.h to JSExecState.h.
4010
4011         * DOM/DOMAttr.mm:
4012         * DOM/DOMBlob.mm:
4013         * DOM/DOMCDATASection.mm:
4014         * DOM/DOMCSSCharsetRule.mm:
4015         * DOM/DOMCSSFontFaceRule.mm:
4016         * DOM/DOMCSSImportRule.mm:
4017         * DOM/DOMCSSMediaRule.mm:
4018         * DOM/DOMCSSPageRule.mm:
4019         * DOM/DOMCSSPrimitiveValue.mm:
4020         * DOM/DOMCSSRule.mm:
4021         * DOM/DOMCSSRuleList.mm:
4022         * DOM/DOMCSSStyleDeclaration.mm:
4023         * DOM/DOMCSSStyleRule.mm:
4024         * DOM/DOMCSSStyleSheet.mm:
4025         * DOM/DOMCSSUnknownRule.mm:
4026         * DOM/DOMCSSValue.mm:
4027         * DOM/DOMCSSValueList.mm:
4028         * DOM/DOMCharacterData.mm:
4029         * DOM/DOMComment.mm:
4030         * DOM/DOMCounter.mm:
4031         * DOM/DOMDocument.mm:
4032         * DOM/DOMDocumentFragment.mm:
4033         * DOM/DOMDocumentType.mm:
4034         * DOM/DOMElement.mm:
4035         * DOM/DOMEvent.mm:
4036         * DOM/DOMFile.mm:
4037         * DOM/DOMFileList.mm:
4038         * DOM/DOMHTML.mm:
4039         * DOM/DOMHTMLAnchorElement.mm:
4040         * DOM/DOMHTMLAppletElement.mm:
4041         * DOM/DOMHTMLAreaElement.mm:
4042         * DOM/DOMHTMLBRElement.mm:
4043         * DOM/DOMHTMLBaseElement.mm:
4044         * DOM/DOMHTMLBaseFontElement.mm:
4045         * DOM/DOMHTMLBodyElement.mm:
4046         * DOM/DOMHTMLButtonElement.mm:
4047         * DOM/DOMHTMLCanvasElement.mm:
4048         * DOM/DOMHTMLCollection.mm:
4049         * DOM/DOMHTMLDListElement.mm:
4050         * DOM/DOMHTMLDirectoryElement.mm:
4051         * DOM/DOMHTMLDivElement.mm:
4052         * DOM/DOMHTMLDocument.mm:
4053         * DOM/DOMHTMLElement.mm:
4054 &n