Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote...
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2
3         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
4         https://bugs.webkit.org/show_bug.cgi?id=191494
5         <rdar://problem/45469854>
6
7         Reviewed by Devin Rousso.
8
9         * WebCoreSupport/WebInspectorClient.h:
10         WebKitLegacy will still have remote inspection of the Page directly.
11
12 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
13
14         Make compositing updates incremental
15         https://bugs.webkit.org/show_bug.cgi?id=90342
16
17         Reviewed by Antti Koivisto.
18
19         Fix spelling error.
20
21         * WebView/WebView.mm:
22         (-[WebView _setMediaLayer:forPluginView:]):
23
24 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
25
26         Implement a new edit command to change the enclosing list type
27         https://bugs.webkit.org/show_bug.cgi?id=191487
28         <rdar://problem/45955922>
29
30         Reviewed by Ryosuke Niwa.
31
32         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
33
34         * WebCoreSupport/WebEditorClient.mm:
35         (undoNameForEditAction):
36
37 2018-11-11  Daniel Bates  <dabates@apple.com>
38
39         [iOS] Draw caps lock indicator in password fields
40         https://bugs.webkit.org/show_bug.cgi?id=190565
41         <rdar://problem/45262343>
42
43         Reviewed by Dean Jackson.
44
45         Update the caps lock state when a hardware keyboard is attached or detached.
46
47         * WebView/WebHTMLView.mm:
48         (hardwareKeyboardAvailabilityChangedCallback): Added.
49         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
50         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
51
52 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
53
54         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
55         https://bugs.webkit.org/show_bug.cgi?id=191492
56
57         Reviewed by Alex Christensen.
58
59         * Carbon/HIWebView.mm:
60         * Misc/WebNSFileManagerExtras.mm:
61         * Misc/WebNSURLExtras.mm:
62         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
63         * Plugins/WebBasePluginPackage.mm:
64         * Plugins/WebPluginContainerCheck.mm:
65         * WebCoreSupport/WebCachedFramePlatformData.h:
66         * WebCoreSupport/WebDeviceOrientationClient.mm:
67         * WebView/WebDelegateImplementationCaching.mm:
68         * WebView/WebHTMLView.mm:
69         * WebView/WebPDFRepresentation.mm:
70         * WebView/WebPolicyDelegate.mm:
71         * WebView/WebView.mm:
72
73 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
74
75         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
76         https://bugs.webkit.org/show_bug.cgi?id=191492
77
78         Reviewed by Alex Christensen.
79
80         * Carbon/HIWebView.mm:
81         (UpdateCommandStatus):
82         * Misc/WebNSFileManagerExtras.mm:
83         * Misc/WebNSURLExtras.mm:
84         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
85         * Plugins/WebBasePluginPackage.mm:
86         * Plugins/WebPluginContainerCheck.mm:
87         (-[WebPluginContainerCheck _continueWithPolicy:]):
88         * WebCoreSupport/WebCachedFramePlatformData.h:
89         (WebCachedFramePlatformData::clear):
90         * WebCoreSupport/WebDeviceOrientationClient.mm:
91         (WebDeviceOrientationClient::getProvider const):
92         * WebView/WebDelegateImplementationCaching.mm:
93         (CallDelegate):
94         (CallDelegateReturningBoolean):
95         (CallResourceLoadDelegateReturningBoolean):
96         (CallFormDelegate):
97         (CallFormDelegateReturningBoolean):
98         * WebView/WebHTMLView.mm:
99         * WebView/WebPDFRepresentation.mm:
100         * WebView/WebPolicyDelegate.mm:
101         (-[WebPolicyDecisionListener _usePolicy:]):
102         * WebView/WebView.mm:
103
104 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
105
106         Unreviewed, rolling out r238047.
107
108         Introduced layout test failures on iOS simulator.
109
110         Reverted changeset:
111
112         "[iOS] Draw caps lock indicator in password fields"
113         https://bugs.webkit.org/show_bug.cgi?id=190565
114         https://trac.webkit.org/changeset/238047
115
116 2018-11-09  Antti Koivisto  <antti@apple.com>
117
118         Use OptionSet for layout milestones
119         https://bugs.webkit.org/show_bug.cgi?id=191470
120
121         Reviewed by Dean Jackson.
122
123         * WebCoreSupport/WebFrameLoaderClient.h:
124         * WebCoreSupport/WebFrameLoaderClient.mm:
125         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
126         * WebView/WebView.mm:
127         (coreLayoutMilestones):
128         (kitLayoutMilestones):
129         (-[WebView _cacheFrameLoadDelegateImplementations]):
130         * WebView/WebViewInternal.h:
131
132 2018-11-09  Daniel Bates  <dabates@apple.com>
133
134         [iOS] Draw caps lock indicator in password fields
135         https://bugs.webkit.org/show_bug.cgi?id=190565
136         <rdar://problem/45262343>
137
138         Reviewed by Dean Jackson.
139
140         Update the caps lock state when a hardware keyboard is attached or detached.
141
142         * WebView/WebHTMLView.mm:
143         (hardwareKeyboardAvailabilityChangedCallback): Added.
144         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
145         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
146
147 2018-11-09  Daniel Bates  <dabates@apple.com>
148
149         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
150         action when forward delete is pressed outside a text field
151         https://bugs.webkit.org/show_bug.cgi?id=190566
152         <rdar://problem/45262367>
153
154         Reviewed by Wenson Hsieh.
155
156         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
157         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
158         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
159
160         * WebView/WebHTMLView.mm:
161         (-[WebHTMLView _handleEditingKeyEvent:]):
162
163 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
164
165         Adopt Reveal Framework to replace Lookup
166         https://bugs.webkit.org/show_bug.cgi?id=191097
167         <rdar://problem/45924508>
168
169         Reviewed by Tim Horton.
170
171         Pass in what it needed to clear the textIndicators. This is better than
172         the current notification structure.
173
174         * WebView/WebView.mm:
175         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
176         (-[WebView _prepareForDictionaryLookup]):
177
178 2018-11-06  Justin Fan  <justin_fan@apple.com>
179
180         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
181         https://bugs.webkit.org/show_bug.cgi?id=191291
182
183         Reviewed by Myles Maxfield.
184
185         Properly disable WEBGPU on all non-Metal platforms for now.
186
187         * Configurations/FeatureDefines.xcconfig:
188
189 2018-11-02  Daniel Bates  <dabates@apple.com>
190
191         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
192         https://bugs.webkit.org/show_bug.cgi?id=190487
193
194         Reviewed by Tim Horton.
195
196         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
197         allow the default handling.
198
199         * WebView/WebHTMLView.mm:
200         (-[WebHTMLView _handleEditingKeyEvent:]):
201
202 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
203
204         Add a storage limit for IndexedDB
205         https://bugs.webkit.org/show_bug.cgi?id=190598
206         <rdar://problem/44654715>
207
208         Reviewed by Chris Dumez.
209
210         * Storage/WebDatabaseManager.mm:
211         (-[WebDatabaseManager setIDBPerOriginQuota:]):
212         * Storage/WebDatabaseManagerPrivate.h:
213
214 2018-10-31  Antti Koivisto  <antti@apple.com>
215
216         Remove LayerFlushScheduler
217         https://bugs.webkit.org/show_bug.cgi?id=191103
218
219         Reviewed by Anders Carlsson.
220
221         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
222         all the virtual cruft.
223
224         * WebView/WebViewData.h:
225         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
226         (): Deleted.
227         * WebView/WebViewData.mm:
228         (currentRunLoop):
229         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
230         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
231         (WebViewLayerFlushScheduler::schedule):
232         (WebViewLayerFlushScheduler::invalidate):
233         (WebViewLayerFlushScheduler::layerFlushCallback):
234
235 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
236
237         Enable InstallAPI for iOS unconditionally
238         https://bugs.webkit.org/show_bug.cgi?id=191043
239         rdar://problem/32728423
240
241         Reviewed by Dan Bernstein.
242
243         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
244         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
245         shouldn't be processed by InstallAPI.
246         * MigrateHeaders.make: Removed an obsolete workaround.
247         * Misc/NSURLDownloadSPI.h: Added.
248         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
249
250 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
251
252         Clean up some obsolete MAX_ALLOWED macros
253         https://bugs.webkit.org/show_bug.cgi?id=190916
254
255         Reviewed by Tim Horton.
256
257         * WebView/WebHTMLView.mm:
258         (-[WebHTMLView pressureChangeWithEvent:]):
259         * WebView/WebPDFView.h:
260
261 2018-10-30  Commit Queue  <commit-queue@webkit.org>
262
263         Unreviewed, rolling out r237600 and r237604.
264         https://bugs.webkit.org/show_bug.cgi?id=191086
265
266         Breaks internal iOS builds (Requested by ryanhadd_ on
267         #webkit).
268
269         Reverted changesets:
270
271         "Enable InstallAPI for iOS unconditionally"
272         https://bugs.webkit.org/show_bug.cgi?id=191043
273         https://trac.webkit.org/changeset/237600
274
275         "Build fix attempt after enabling InstallAPI for iOS."
276         https://bugs.webkit.org/show_bug.cgi?id=191043
277         https://trac.webkit.org/changeset/237604
278
279 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
280
281         Enable InstallAPI for iOS unconditionally
282         https://bugs.webkit.org/show_bug.cgi?id=191043
283         rdar://problem/32728423
284
285         Reviewed by Dan Bernstein.
286
287         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
288         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
289         shouldn't be processed by InstallAPI.
290         * MigrateHeaders.make: Removed an obsolete workaround.
291         * Misc/NSURLDownloadSPI.h: Added.
292         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
293
294 2018-10-29  Tim Horton  <timothy_horton@apple.com>
295
296         Modernize WebKit nibs and lprojs for localization's sake
297         https://bugs.webkit.org/show_bug.cgi?id=190911
298         <rdar://problem/45349466>
299
300         Reviewed by Dan Bernstein.
301
302         * Misc/WebNSControlExtras.m:
303         (-[NSControl sizeToFitAndAdjustWindowHeight]):
304         NSWindow and its contents are both in the same scale space these days; avoid
305         double-applying the scale factor, or you can't see the prompt.
306
307         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
308         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
309         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
310         NIB->XIB
311
312 2018-10-25  Antoine Quint  <graouts@apple.com>
313
314         [Web Animations] Turn Web Animations CSS Integration off by default
315         https://bugs.webkit.org/show_bug.cgi?id=190901
316
317         Reviewed by Dean Jackson.
318
319         * WebView/WebPreferences.mm:
320         (+[WebPreferences initialize]):
321
322 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
323
324         Clean up some obsolete macOS version guards
325         https://bugs.webkit.org/show_bug.cgi?id=190887
326
327         Reviewed by Dan Bernstein.
328
329         * Misc/WebNSPasteboardExtras.mm:
330         (+[NSPasteboard _web_dragTypesForURL]):
331         * WebCoreSupport/PopupMenuMac.mm:
332         (PopupMenuMac::show):
333         * WebCoreSupport/WebEditorClient.h:
334         * WebCoreSupport/WebEditorClient.mm:
335         (WebEditorClient::respondToChangedSelection):
336         * WebView/WebPDFView.mm:
337         (-[WebPDFView _clipViewForPDFDocumentView]):
338
339 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
340
341         Turn on Conic Gradients
342         https://bugs.webkit.org/show_bug.cgi?id=190810
343
344         Reviewed by Tim Horton.
345
346         * Configurations/FeatureDefines.xcconfig:
347
348 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
349
350         Cleanup: MIMETypeRegistry functions
351         https://bugs.webkit.org/show_bug.cgi?id=190838
352
353         Reviewed by Simon Fraser.
354
355         * Misc/WebNSPasteboardExtras.mm:
356         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
357         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
358         because they were identical.
359
360         * WebView/WebHTMLRepresentation.mm:
361         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
362         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
363         (+[WebHTMLRepresentation supportedImageMIMETypes]):
364         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
365         * WebView/WebView.mm:
366         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
367         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
368         (+[WebView registerViewClass:representationClass:forMIMEType:]):
369
370 2018-10-23  David Kilzer  <ddkilzer@apple.com>
371
372         Fix false positive leaks when using custom -init methods that don't start with -init
373         <https://webkit.org/b/190818>
374         <rdar://problem/45476042>
375
376         Reviewed by Dan Bernstein.
377
378         * Misc/WebKitErrors.m: Move `descriptions` static global so that
379         it is accessible by both categories.
380         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
381         NSError (WebKitInternal) category.  Add attribute to make this
382         behave like an -init method.
383         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
384         NSError (WebKitInternal) category.  Modernize method.  Replace
385         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
386
387 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
388
389         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
390         https://bugs.webkit.org/show_bug.cgi?id=190729
391
392         Reviewed by Tim Horton.
393
394         * DOM/DOM.mm:
395         (-[DOMNode boundingBox]):
396         * DOM/DOMElement.mm:
397         * DOM/DOMHTML.mm:
398         * DOM/DOMInternal.mm:
399         * DOM/DOMUIKitExtensions.mm:
400         * DOM/WebDOMOperations.mm:
401         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
402         * DefaultDelegates/WebDefaultEditingDelegate.m:
403         * DefaultDelegates/WebDefaultPolicyDelegate.m:
404         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
405         * DefaultDelegates/WebDefaultUIDelegate.h:
406         * DefaultDelegates/WebDefaultUIDelegate.mm:
407         (-[WebDefaultUIDelegate webViewClose:]):
408         (-[WebDefaultUIDelegate webViewFocus:]):
409         (-[WebDefaultUIDelegate webViewUnfocus:]):
410         (-[WebDefaultUIDelegate webViewIsResizable:]):
411         (-[WebDefaultUIDelegate webView:setResizable:]):
412         (-[WebDefaultUIDelegate webView:setFrame:]):
413         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
414         * History/BackForwardList.h:
415         * History/BackForwardList.mm:
416         * History/WebBackForwardList.mm:
417         (+[WebBackForwardList initialize]):
418         (bumperCarBackForwardHackNeeded):
419         * History/WebHistory.mm:
420         (-[WebHistoryPrivate addItem:discardDuplicate:]):
421         (-[WebHistory _sendNotification:entries:]):
422         (-[WebHistory loadFromURL:error:]):
423         (-[WebHistory saveToURL:error:]):
424         * History/WebHistoryItem.mm:
425         (WKNotifyHistoryItemChanged):
426         (+[WebHistoryItem initialize]):
427         (-[WebHistoryItem initFromDictionaryRepresentation:]):
428         * History/WebURLsWithTitles.m:
429         * Misc/WebCache.mm:
430         (+[WebCache initialize]):
431         * Misc/WebDownload.mm:
432         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
433         * Misc/WebElementDictionary.mm:
434         (+[WebElementDictionary initialize]):
435         (+[WebElementDictionary initializeLookupTable]):
436         * Misc/WebIconDatabase.mm:
437         * Misc/WebKitNSStringExtras.mm:
438         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
439         * Misc/WebKitVersionChecks.h:
440         * Misc/WebKitVersionChecks.mm:
441         (WebKitLinkedOnOrAfter):
442         (WebKitLinkTimeVersion):
443         * Misc/WebLocalizableStrings.mm:
444         * Misc/WebNSControlExtras.h:
445         * Misc/WebNSControlExtras.m:
446         * Misc/WebNSEventExtras.m:
447         * Misc/WebNSFileManagerExtras.mm:
448         * Misc/WebNSImageExtras.h:
449         * Misc/WebNSImageExtras.m:
450         * Misc/WebNSPasteboardExtras.mm:
451         * Misc/WebNSPrintOperationExtras.h:
452         * Misc/WebNSPrintOperationExtras.m:
453         * Misc/WebNSViewExtras.m:
454         * Misc/WebNSWindowExtras.m:
455         * Panels/WebAuthenticationPanel.h:
456         * Panels/WebAuthenticationPanel.m:
457         * Panels/WebPanelAuthenticationHandler.m:
458         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
459         (+[WebHostedNetscapePluginView initialize]):
460         * Plugins/WebBasePluginPackage.h:
461         * Plugins/WebBasePluginPackage.mm:
462         * Plugins/WebJavaPlugIn.h:
463         * Plugins/WebPluginContainerCheck.mm:
464         * Plugins/WebPluginController.h:
465         * Plugins/WebPluginController.mm:
466         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
467         (-[WebPluginController addPlugin:]):
468         (-[WebPluginController destroyPlugin:]):
469         (-[WebPluginController destroyAllPlugins]):
470         * Plugins/WebPluginDatabase.mm:
471         (+[WebPluginDatabase _defaultPlugInPaths]):
472         * Plugins/WebPluginPackage.mm:
473         (-[WebPluginPackage initWithPath:]):
474         * Storage/WebDatabaseManager.mm:
475         (-[WebDatabaseManager deleteAllDatabases]):
476         * Storage/WebDatabaseManagerClient.h:
477         * Storage/WebDatabaseManagerClient.mm:
478         (WebDatabaseManagerClient::WebDatabaseManagerClient):
479         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
480         * Storage/WebStorageManager.mm:
481         (-[WebStorageManager deleteAllOrigins]):
482         (WebKitInitializeStorageIfNecessary):
483         * WebCoreSupport/WebAlternativeTextClient.h:
484         * WebCoreSupport/WebApplicationCache.mm:
485         (applicationCacheBundleIdentifier):
486         * WebCoreSupport/WebChromeClient.h:
487         * WebCoreSupport/WebChromeClient.mm:
488         (WebChromeClient::setWindowRect):
489         (WebChromeClient::windowRect):
490         (WebChromeClient::takeFocus):
491         (WebChromeClient::addMessageToConsole):
492         (WebChromeClient::enableSuddenTermination):
493         (WebChromeClient::disableSuddenTermination):
494         (WebChromeClient::createPopupMenu const):
495         (WebChromeClient::createSearchPopupMenu const):
496         (WebChromeClient::shouldPaintEntireContents const):
497         (WebChromeClient::supportsVideoFullscreen):
498         (WebChromeClient::supportsFullScreenForElement):
499         (WebChromeClient::enterFullScreenForElement):
500         (WebChromeClient::exitFullScreenForElement):
501         * WebCoreSupport/WebContextMenuClient.mm:
502         * WebCoreSupport/WebDragClient.mm:
503         * WebCoreSupport/WebEditorClient.h:
504         * WebCoreSupport/WebEditorClient.mm:
505         (+[WebUndoStep initialize]):
506         (updateFontPanel):
507         (WebEditorClient::didBeginEditing):
508         (WebEditorClient::respondToChangedContents):
509         (WebEditorClient::respondToChangedSelection):
510         (WebEditorClient::canceledComposition):
511         (WebEditorClient::didEndEditing):
512         (WebEditorClient::didWriteSelectionToPasteboard):
513         (attributesForAttributedStringConversion):
514         (WebEditorClient::setInsertionPasteboard):
515         (WebEditorClient::registerUndoOrRedoStep):
516         (WebEditorClient::handleKeyboardEvent):
517         (WebEditorClient::handleInputMethodKeydown):
518         (WebEditorClient::textDidChangeInTextField):
519         (WebEditorClient::requestCheckingOfString):
520         * WebCoreSupport/WebFrameLoaderClient.h:
521         * WebCoreSupport/WebFrameLoaderClient.mm:
522         (WebFrameLoaderClient::detachedFromParent2):
523         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
524         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
525         (WebFrameLoaderClient::dispatchWillSendRequest):
526         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
527         (WebFrameLoaderClient::dispatchDidReceiveResponse):
528         (WebFrameLoaderClient::willCacheResponse const):
529         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
530         (WebFrameLoaderClient::dispatchDidFinishLoading):
531         (WebFrameLoaderClient::dispatchDidFailLoading):
532         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
533         (WebFrameLoaderClient::dispatchWillClose):
534         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
535         (WebFrameLoaderClient::dispatchDidCommitLoad):
536         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
537         (WebFrameLoaderClient::dispatchDidFailLoad):
538         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
539         (WebFrameLoaderClient::dispatchDidFinishLoad):
540         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
541         (WebFrameLoaderClient::willChangeTitle):
542         (WebFrameLoaderClient::didChangeTitle):
543         (WebFrameLoaderClient::didReplaceMultipartContent):
544         (WebFrameLoaderClient::updateGlobalHistory):
545         (WebFrameLoaderClient::saveViewStateToItem):
546         (WebFrameLoaderClient::restoreViewState):
547         (WebFrameLoaderClient::provisionalLoadStarted):
548         (WebFrameLoaderClient::prepareForDataSourceReplacement):
549         (WebFrameLoaderClient::setTitle):
550         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
551         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
552         (WebFrameLoaderClient::transitionToCommittedForNewPage):
553         (WebFrameLoaderClient::didRestoreFromPageCache):
554         (WebFrameLoaderClient::actionDictionary const):
555         (WebFrameLoaderClient::createPlugin):
556         (WebFrameLoaderClient::getLoadDecisionForIcons):
557         (WebFrameLoaderClient::finishedLoadingIcon):
558         (+[WebFramePolicyListener initialize]):
559         * WebCoreSupport/WebFrameNetworkingContext.mm:
560         * WebCoreSupport/WebGeolocationClient.h:
561         * WebCoreSupport/WebGeolocationClient.mm:
562         (WebGeolocationClient::requestPermission):
563         * WebCoreSupport/WebInspectorClient.h:
564         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
565         * WebCoreSupport/WebNotificationClient.mm:
566         * WebCoreSupport/WebOpenPanelResultListener.mm:
567         * WebCoreSupport/WebPlatformStrategies.h:
568         * WebCoreSupport/WebPlatformStrategies.mm:
569         * WebCoreSupport/WebProgressTrackerClient.h:
570         * WebCoreSupport/WebProgressTrackerClient.mm:
571         (WebProgressTrackerClient::progressStarted):
572         (WebProgressTrackerClient::progressEstimateChanged):
573         (WebProgressTrackerClient::progressFinished):
574         * WebCoreSupport/WebSecurityOrigin.mm:
575         * WebInspector/WebNodeHighlight.h:
576         * WebInspector/WebNodeHighlight.mm:
577         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
578         (-[WebNodeHighlight dealloc]):
579         (-[WebNodeHighlight attach]):
580         * WebInspector/WebNodeHighlightView.h:
581         * WebInspector/WebNodeHighlightView.mm:
582         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
583         (-[WebNodeHighlightView dealloc]):
584         * WebInspector/WebNodeHighlighter.mm:
585         (-[WebNodeHighlighter highlight]):
586         * WebView/WebArchive.mm:
587         (+[WebArchivePrivate initialize]):
588         * WebView/WebClipView.h:
589         * WebView/WebDataSource.mm:
590         (WebDataSourcePrivate::WebDataSourcePrivate):
591         (+[WebDataSource initialize]):
592         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
593         (-[WebDataSource _makeRepresentation]):
594         * WebView/WebDelegateImplementationCaching.h:
595         * WebView/WebDelegateImplementationCaching.mm:
596         (CallDelegate):
597         (CallDelegateReturningFloat):
598         (CallDelegateReturningBoolean):
599         (CallUIDelegate):
600         (CallUIDelegateReturningFloat):
601         (CallUIDelegateReturningBoolean):
602         (CallFrameLoadDelegate):
603         (CallFrameLoadDelegateReturningBoolean):
604         (CallResourceLoadDelegate):
605         (CallScriptDebugDelegate):
606         (CallFormDelegate):
607         (CallFormDelegateReturningBoolean):
608         * WebView/WebDeviceOrientation.mm:
609         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
610         * WebView/WebDocumentInternal.h:
611         * WebView/WebDocumentLoaderMac.mm:
612         (needsDataLoadWorkaround):
613         * WebView/WebDynamicScrollBarsViewInternal.h:
614         * WebView/WebFormDelegate.m:
615         * WebView/WebFrame.mm:
616         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
617         (-[WebFrame _unmarkAllMisspellings]):
618         (-[WebFrame _paintBehaviorForDestinationContext:]):
619         (-[WebFrame _drawRect:contentsOnly:]):
620         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
621         (-[WebFrame _scrollDOMRangeToVisible:]):
622         (-[WebFrame _bodyBackgroundColor]):
623         (-[WebFrame accessibilityRoot]):
624         (needsMicrosoftMessengerDOMDocumentWorkaround):
625         * WebView/WebFrameInternal.h:
626         * WebView/WebFrameView.mm:
627         (-[WebFrameView _setDocumentView:]):
628         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
629         (-[WebFrameView _viewClassForMIMEType:]):
630         (-[WebFrameView initWithFrame:]):
631         (-[WebFrameView drawRect:]):
632         (-[WebFrameView _firstResponderIsFormControl]):
633         (-[WebFrameView keyDown:keyDown:]):
634         (-[WebFrameView _isScrollable]):
635         * WebView/WebFullScreenController.h:
636         * WebView/WebFullScreenController.mm:
637         * WebView/WebHTMLRepresentation.mm:
638         * WebView/WebHTMLView.mm:
639         (-[WebHTMLView hitTest:]):
640         (-[WebHTMLView initWithFrame:]):
641         (-[WebHTMLView dealloc]):
642         (-[WebHTMLView addSubview:]):
643         (-[WebHTMLView mouseDown:]):
644         (-[WebHTMLView mouseUp:]):
645         (-[WebHTMLView resignFirstResponder]):
646         (-[WebHTMLView accessibilityHitTest:]):
647         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
648         * WebView/WebHTMLViewInternal.h:
649         * WebView/WebIndicateLayer.h:
650         * WebView/WebIndicateLayer.mm:
651         * WebView/WebMediaPlaybackTargetPicker.h:
652         * WebView/WebMediaPlaybackTargetPicker.mm:
653         * WebView/WebPDFDocumentExtras.h:
654         * WebView/WebPDFDocumentExtras.mm:
655         * WebView/WebPDFRepresentation.h:
656         * WebView/WebPDFRepresentation.mm:
657         * WebView/WebPDFView.h:
658         * WebView/WebPreferences.mm:
659         (cacheModelForMainBundle):
660         (WebPreferencesPrivate::WebPreferencesPrivate):
661         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
662         (-[WebPreferences encodeWithCoder:]):
663         (+[WebPreferences standardPreferences]):
664         (+[WebPreferences initialize]):
665         (-[WebPreferences _valueForKey:]):
666         (-[WebPreferences _setStringValue:forKey:]):
667         (-[WebPreferences _setIntegerValue:forKey:]):
668         (-[WebPreferences _setUnsignedIntValue:forKey:]):
669         (-[WebPreferences _setFloatValue:forKey:]):
670         (-[WebPreferences _setBoolValue:forKey:]):
671         (-[WebPreferences _setLongLongValue:forKey:]):
672         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
673         (-[WebPreferences _postCacheModelChangedNotification]):
674         (-[WebPreferences _postPreferencesChangedNotification]):
675         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
676         (-[WebPreferences setStorageBlockingPolicy:]):
677         * WebView/WebResource.mm:
678         (+[WebResourcePrivate initialize]):
679         * WebView/WebTextCompletionController.h:
680         * WebView/WebTextIterator.mm:
681         (+[WebTextIteratorPrivate initialize]):
682         * WebView/WebView.mm:
683         (shouldEnableLoadDeferring):
684         (shouldRestrictWindowFocus):
685         (shouldRespectPriorityInCSSAttributeSetters):
686         (shouldUseLegacyBackgroundSizeShorthandBehavior):
687         (shouldAllowPictureInPictureMediaPlayback):
688         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
689         (shouldAllowWindowOpenWithoutUserGesture):
690         (shouldConvertInvalidURLsToBlank):
691         (shouldRequireUserGestureToLoadVideo):
692         (-[WebView _commonInitializationWithFrameName:groupName:]):
693         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
694         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
695         (-[WebView _closePluginDatabases]):
696         (-[WebView _closeWithFastTeardown]):
697         (-[WebView _close]):
698         (+[WebView _MIMETypeForFile:]):
699         (-[WebView setShowingInspectorIndication:]):
700         (-[WebView _setFormDelegate:]):
701         (-[WebView _needsPreHTML5ParserQuirks]):
702         (-[WebView _preferencesChangedNotification:]):
703         (-[WebView _preferencesChanged:]):
704         (-[WebView _cacheResourceLoadDelegateImplementations]):
705         (-[WebView _cacheFrameLoadDelegateImplementations]):
706         (-[WebView _policyDelegateForwarder]):
707         (-[WebView _UIDelegateForwarder]):
708         (-[WebView _editingDelegateForwarder]):
709         (-[WebView _updateActiveState]):
710         (-[_WebSafeForwarder forwardInvocation:]):
711         (+[WebView initialize]):
712         (-[WebView _pluginForMIMEType:]):
713         (-[WebView _pluginForExtension:]):
714         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
715         (+[WebView canShowMIMETypeAsHTML:]):
716         (-[WebView _initWithArguments:]):
717         (-[WebView initWithFrame:frameName:groupName:]):
718         (-[WebView dealloc]):
719         (-[WebView close]):
720         (-[WebView viewDidMoveToWindow]):
721         (-[WebView setUIDelegate:]):
722         (-[WebView setResourceLoadDelegate:]):
723         (-[WebView setPolicyDelegate:]):
724         (-[WebView setFrameLoadDelegate:]):
725         (-[WebView goBack]):
726         (-[WebView goForward]):
727         (-[WebView stringByEvaluatingJavaScriptFromString:]):
728         (-[WebView setHostWindow:]):
729         (-[WebView becomeFirstResponder]):
730         (+[WebView _cacheModelChangedNotification:]):
731         (-[WebView _frameViewAtWindowPoint:]):
732         (+[WebView _preflightSpellCheckerNow:]):
733         (+[WebView _preflightSpellChecker]):
734         (-[WebView canGoBack]):
735         (-[WebView canGoForward]):
736         (-[WebView stopLoading:]):
737         (-[WebView reload:]):
738         (-[WebView setMainFrameDocumentReady:]):
739         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
740         (-[WebView setContinuousSpellCheckingEnabled:]):
741         (-[WebView undoManager]):
742         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
743         (-[WebView isAutomaticLinkDetectionEnabled]):
744         (-[WebView isAutomaticDashSubstitutionEnabled]):
745         (-[WebView isAutomaticTextReplacementEnabled]):
746         (-[WebView isAutomaticSpellingCorrectionEnabled]):
747         (+[WebView _setCacheModel:]):
748         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
749         (-[WebView _keyboardUIMode]):
750         (LayerFlushController::flushLayers):
751         (-[WebView _scheduleCompositingLayerFlush]):
752         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
753         (-[WebView fullScreenPlaceholderView]):
754         (WebInstallMemoryPressureHandler):
755         * WebView/WebViewData.h:
756         * WebView/WebViewData.mm:
757         (+[WebViewPrivate initialize]):
758         (-[WebViewPrivate init]):
759         (-[WebViewPrivate dealloc]):
760         * WebView/WebViewInternal.h:
761
762 2018-10-18  Alex Christensen  <achristensen@webkit.org>
763
764         Clean up FrameLoader two-state enums
765         https://bugs.webkit.org/show_bug.cgi?id=190731
766
767         Reviewed by Chris Dumez.
768
769         * WebCoreSupport/WebFrameLoaderClient.h:
770         * WebCoreSupport/WebFrameLoaderClient.mm:
771         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
772
773 2018-10-18  Alex Christensen  <achristensen@webkit.org>
774
775         Unreviewed, rolling out r237137.
776
777         SPI is actually used
778
779         Reverted changeset:
780
781         "Remove unused WebFrame._loadType"
782         https://bugs.webkit.org/show_bug.cgi?id=190583
783         https://trac.webkit.org/changeset/237137
784
785 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
786
787         Enable the datalist element by default on iOS and macOS
788         https://bugs.webkit.org/show_bug.cgi?id=190594
789         <rdar://problem/45281159>
790
791         Reviewed by Ryosuke Niwa and Tim Horton.
792
793         * Configurations/FeatureDefines.xcconfig:
794
795 2018-10-17  Alex Christensen  <achristensen@webkit.org>
796
797         BackForwardClient needs to be able to support UIProcess-only back/forward lists
798         https://bugs.webkit.org/show_bug.cgi?id=190675
799
800         Reviewed by Chris Dumez.
801
802         * History/BackForwardList.h:
803         * History/BackForwardList.mm:
804         (BackForwardList::backItem):
805         (BackForwardList::currentItem):
806         (BackForwardList::forwardItem):
807         (BackForwardList::backListCount const):
808         (BackForwardList::forwardListCount const):
809         (BackForwardList::itemAtIndex):
810         * History/WebBackForwardList.mm:
811         (-[WebBackForwardList backItem]):
812         (-[WebBackForwardList currentItem]):
813         (-[WebBackForwardList forwardItem]):
814         (-[WebBackForwardList itemAtIndex:]):
815
816 2018-10-16  Timothy Hatcher  <timothy@apple.com>
817
818         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
819         https://bugs.webkit.org/show_bug.cgi?id=190526
820         rdar://problem/45230140
821
822         Reviewed by Dean Jackson.
823
824         * WebCoreSupport/WebEditorClient.mm:
825         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
826
827 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
828
829         Implement feature flag and bindings for CSS Painting API
830         https://bugs.webkit.org/show_bug.cgi?id=190237
831
832         Reviewed by Ryosuke Niwa.
833
834         * Configurations/FeatureDefines.xcconfig:
835
836 2018-10-16  Alex Christensen  <achristensen@webkit.org>
837
838         Replace HistoryItem* with HistoryItem& where possible
839         https://bugs.webkit.org/show_bug.cgi?id=190617
840
841         Reviewed by Chris Dumez.
842
843         * History/BackForwardList.h:
844         * History/BackForwardList.mm:
845         (BackForwardList::goToItem):
846         * History/WebBackForwardList.mm:
847         (-[WebBackForwardList goToItem:]):
848         * History/WebHistoryItem.mm:
849         (WKNotifyHistoryItemChanged):
850         * History/WebHistoryItemInternal.h:
851
852 2018-10-16  Alex Christensen  <achristensen@webkit.org>
853
854         Remove unused WebHistoryItem._transientPropertyForKey
855         https://bugs.webkit.org/show_bug.cgi?id=190606
856
857         Reviewed by Chris Dumez.
858
859         * History/WebHistoryItem.mm:
860         * History/WebHistoryItemPrivate.h:
861
862 2018-10-15  Justin Fan  <justin_fan@apple.com>
863
864         Add WebGPU 2018 feature flag and experimental feature flag
865         https://bugs.webkit.org/show_bug.cgi?id=190509
866
867         Reviewed by Dean Jackson.
868
869         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
870         for the 2018 WebGPU prototype.
871
872         * Configurations/FeatureDefines.xcconfig:
873         * WebView/WebPreferenceKeysPrivate.h:
874         * WebView/WebPreferences.mm:
875         (+[WebPreferences initialize]):
876         (-[WebPreferences webGPUEnabled]):
877         (-[WebPreferences setWebGPUEnabled:]):
878         * WebView/WebPreferencesPrivate.h:
879         * WebView/WebView.mm:
880         (-[WebView _preferencesChanged:]):
881
882 2018-10-15  Alex Christensen  <achristensen@webkit.org>
883
884         Fix iOS build after r237157
885
886         * WebView/WebView.mm:
887         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
888
889 2018-10-15  Alex Christensen  <achristensen@webkit.org>
890
891         Modernize BackForwardClient.h
892         https://bugs.webkit.org/show_bug.cgi?id=190610
893
894         Reviewed by Chris Dumez.
895
896         * History/BackForwardList.h:
897         * History/BackForwardList.mm:
898         (BackForwardList::backListCount const):
899         (BackForwardList::forwardListCount const):
900         (BackForwardList::backListCount): Deleted.
901         (BackForwardList::forwardListCount): Deleted.
902         * History/WebBackForwardList.mm:
903         (-[WebBackForwardList init]):
904         * WebCoreSupport/WebFrameLoaderClient.mm:
905         (WebFrameLoaderClient::canCachePage const):
906         * WebView/WebFrameView.mm:
907         (-[WebFrameView keyDown:keyDown:]):
908         * WebView/WebView.mm:
909         (-[WebView _commonInitializationWithFrameName:groupName:]):
910         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
911         (-[WebView _loadBackForwardListFromOtherView:]):
912         (-[WebView initWithCoder:]):
913         (-[WebView encodeWithCoder:]):
914         (-[WebView backForwardList]):
915         (-[WebView setMaintainsBackForwardList:]):
916
917 2018-10-15  Timothy Hatcher  <timothy@apple.com>
918
919         Add support for prefers-color-scheme media query
920         https://bugs.webkit.org/show_bug.cgi?id=190499
921         rdar://problem/45212025
922
923         Reviewed by Dean Jackson.
924
925         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
926
927 2018-10-15  Alex Christensen  <achristensen@webkit.org>
928
929         Remove unused WebView._globalHistoryItem
930         https://bugs.webkit.org/show_bug.cgi?id=190601
931
932         Reviewed by Chris Dumez.
933
934         * WebCoreSupport/WebFrameLoaderClient.h:
935         * WebCoreSupport/WebFrameLoaderClient.mm:
936         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
937         * WebView/WebView.mm:
938         (-[WebView _globalHistoryItem]): Deleted.
939         (-[WebView _setGlobalHistoryItem:]): Deleted.
940         * WebView/WebViewData.h:
941         * WebView/WebViewInternal.h:
942         * WebView/WebViewPrivate.h:
943
944 2018-10-15  Alex Christensen  <achristensen@webkit.org>
945
946         Remove unused parameters from FrameLoaderClient::createFrame
947         https://bugs.webkit.org/show_bug.cgi?id=190587
948
949         Reviewed by Chris Dumez.
950
951         * WebCoreSupport/WebFrameLoaderClient.h:
952         * WebCoreSupport/WebFrameLoaderClient.mm:
953         (WebFrameLoaderClient::createFrame):
954
955 2018-10-15  Alex Christensen  <achristensen@webkit.org>
956
957         Remove unused WebFrame._loadType
958         https://bugs.webkit.org/show_bug.cgi?id=190583
959
960         Reviewed by Chris Dumez.
961
962         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
963
964         * WebView/WebFrame.mm:
965         (toWebFrameLoadType): Deleted.
966         (-[WebFrame _loadType]): Deleted.
967         * WebView/WebFramePrivate.h:
968
969 2018-10-15  Chris Dumez  <cdumez@apple.com>
970
971         Restrict browsing context lookup by name to frames that are related to one another
972         https://bugs.webkit.org/show_bug.cgi?id=190475
973
974         Reviewed by Alex Christensen.
975
976         * WebView/WebFrame.mm:
977         (-[WebFrame findFrameNamed:]):
978
979 2018-10-15  Alex Christensen  <achristensen@webkit.org>
980
981         Remove InjectedBundle processing of back/forward lists
982         https://bugs.webkit.org/show_bug.cgi?id=190459
983
984         Reviewed by Chris Dumez.
985
986         * WebCoreSupport/WebFrameLoaderClient.h:
987         * WebCoreSupport/WebFrameLoaderClient.mm:
988         (WebFrameLoaderClient::shouldGoToHistoryItem const):
989
990 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
991
992         [JSC] Remove Option::useAsyncIterator
993         https://bugs.webkit.org/show_bug.cgi?id=190567
994
995         Reviewed by Saam Barati.
996
997         * Configurations/FeatureDefines.xcconfig:
998
999 2018-10-12  Alex Christensen  <achristensen@webkit.org>
1000
1001         Allow encoding of small enum classes
1002         https://bugs.webkit.org/show_bug.cgi?id=190531
1003
1004         Reviewed by Tim Horton.
1005
1006         * WebCoreSupport/WebFrameLoaderClient.mm:
1007         (-[WebFramePolicyListener dealloc]):
1008
1009 2018-10-11  Keith Rollin  <krollin@apple.com>
1010
1011         CURRENT_ARCH should not be used in Run Script phase.
1012         https://bugs.webkit.org/show_bug.cgi?id=190407
1013         <rdar://problem/45133556>
1014
1015         Reviewed by Alexey Proskuryakov.
1016
1017         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
1018         CURRENT_ARCH is not well-defined during this phase (and may even have
1019         the value "undefined") since this phase is run just once per build
1020         rather than once per supported architecture. Migrate away from
1021         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
1022         performing an operation for each value, or by picking the first entry
1023         in ARCHS and using that as a representative value.
1024
1025         * Configurations/WebKitLegacy.xcconfig: When generating
1026         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
1027         macosx platforms.
1028
1029         * MigrateHeaders.make:
1030         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
1031         generate one for each architecture in ARCHS.
1032
1033 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1034
1035         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
1036         https://bugs.webkit.org/show_bug.cgi?id=190429
1037
1038         Reviewed by Saam Barati.
1039
1040         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
1041
1042         * WebView/WebPDFRepresentation.mm:
1043         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
1044
1045 2018-10-08  Justin Fan  <justin_fan@apple.com>
1046
1047         WebGPU: Rename old WebGPU prototype to WebMetal
1048         https://bugs.webkit.org/show_bug.cgi?id=190325
1049         <rdar://problem/44990443>
1050
1051         Reviewed by Dean Jackson.
1052
1053         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
1054
1055         * Configurations/FeatureDefines.xcconfig:
1056         * WebView/WebPreferenceKeysPrivate.h:
1057         * WebView/WebPreferences.mm:
1058         (+[WebPreferences initialize]):
1059         (-[WebPreferences webMetalEnabled]):
1060         (-[WebPreferences setWebMetalEnabled:]):
1061         (-[WebPreferences webGPUEnabled]): Deleted.
1062         (-[WebPreferences setWebGPUEnabled:]): Deleted.
1063         * WebView/WebPreferencesPrivate.h:
1064         * WebView/WebView.mm:
1065         (-[WebView _preferencesChanged:]):
1066
1067 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
1068
1069         Make <input type=color> a runtime enabled (on-by-default) feature
1070         https://bugs.webkit.org/show_bug.cgi?id=189162
1071
1072         Reviewed by Wenson Hsieh and Tim Horton.
1073
1074         * Configurations/FeatureDefines.xcconfig:
1075
1076 2018-10-07  Dan Bernstein  <mitz@apple.com>
1077
1078         Fixed building with the latest macOS SDK
1079
1080         * Plugins/WebNetscapePluginPackage.mm:
1081         (-[WebNetscapePluginPackage openResourceFile]):
1082         (-[WebNetscapePluginPackage closeResourceFile:]):
1083
1084 2018-10-04  Dan Bernstein  <mitz@apple.com>
1085
1086         More Carbon build-fixing.
1087
1088         * Carbon/CarbonWindowAdapter.mm:
1089         (-[CarbonWindowAdapter _destroyRealWindow:]):
1090         (-[CarbonWindowAdapter _growBoxRect]):
1091
1092 2018-10-04  Dan Bernstein  <mitz@apple.com>
1093
1094         Retried to fix 32-bit macOS builds after r236846.
1095
1096         * WebView/WebHTMLView.mm:
1097         (-[WebHTMLView setMarkedText:selectedRange:]):
1098
1099 2018-10-04  Dan Bernstein  <mitz@apple.com>
1100
1101         Retried to fix 32-bit macOS builds after r236846.
1102
1103         * Carbon/HIWebView.mm:
1104         (ActiveStateChanged):
1105
1106 2018-10-04  Dan Bernstein  <mitz@apple.com>
1107
1108         Tried to fix 32-bit macOS builds after r236846.
1109
1110         * Carbon/HIWebView.mm:
1111         (_NSSelectorForHICommand):
1112
1113 2018-10-04  Dan Bernstein  <mitz@apple.com>
1114
1115         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
1116         https://bugs.webkit.org/show_bug.cgi?id=190250
1117
1118         Reviewed by Andy Estes.
1119
1120         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
1121           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
1122           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
1123           an earlier line set it to YES.
1124
1125         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
1126         changes below.
1127
1128         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
1129           provides some missing method declarations.
1130
1131         * Misc/WebDownload.mm:
1132         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
1133           a deprecated method.
1134
1135         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
1136
1137         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
1138           other code in the file uses a method from it.
1139
1140         * Plugins/WebBaseNetscapePluginView.mm:
1141         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
1142           a deprecated method.
1143
1144         * Plugins/WebPluginController.mm:
1145         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
1146           around use of a selector that may be present in some WebKit client.
1147
1148         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
1149           method declarations.
1150
1151         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
1152           from here.
1153
1154         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
1155           missing method declarations.
1156
1157         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
1158           from here.
1159
1160         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
1161           call from here.
1162         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
1163           an obsolete delegate method for binary compatibility.
1164         (pluginView): Ditto.
1165
1166         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
1167           call from here.
1168
1169         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
1170           WebDeviceOrientationProviderMock protocol.
1171
1172         * WebView/WebDeviceOrientationProviderMock.mm:
1173         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
1174           main @implementation.
1175
1176         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
1177           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
1178
1179         * WebView/WebDynamicScrollBarsView.mm:
1180         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
1181           of a deprecated method.
1182
1183         * WebView/WebHTMLView.mm:
1184         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
1185           selector warning around action methods that are not declared anywhere in WebKit.
1186
1187         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
1188           about implementing this deprecated method.
1189         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
1190         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
1191         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
1192         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
1193         (-[WebHTMLView characterIndexForPoint:]): Ditto.
1194         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
1195         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
1196         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
1197         (-[WebHTMLView doCommandBySelector:]): Ditto.
1198         (-[WebHTMLView insertText:]): Ditto.
1199
1200         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
1201
1202         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
1203
1204         * WebView/WebPDFView.h: Removed previewView ivar.
1205
1206         * WebView/WebPDFView.mm:
1207           Removed declaration of FileInternal category and merged its implementation with the main
1208           implementation.
1209         (-[WebPDFView dealloc]): Removed previewView ivar.
1210         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
1211           exist in macOS versions we support.
1212         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
1213         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
1214           action methods internal to PDFKit.
1215         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
1216         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
1217
1218         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
1219           call on macOS, even though in r86988 we started calling different methods on iOS.
1220
1221         * WebView/WebView.mm:
1222         - Imported headers that declare delegate methods that we call.
1223         - Removed declaration of WebFileInternal category and merged its implementation with the
1224           main implementation.
1225         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
1226           category, which made them impossible to call from the main implementation. Moved those
1227           into the main implementation. One of those had to be declared in a class extension,
1228           because it is called from a method implemented in the WebPrivate category, and that
1229           category’s implementation appears first in the file.
1230
1231         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
1232           around use of obsolete delegate method for binary compatibility.
1233
1234         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
1235
1236 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
1237
1238         Runtime flag and IDL for MediaRecorder
1239         https://bugs.webkit.org/show_bug.cgi?id=190018
1240
1241         Reviewed by Youenn Fablet and Chris Dumez.
1242
1243         * WebView/WebPreferenceKeysPrivate.h:
1244         * WebView/WebPreferences.mm:
1245         (+[WebPreferences initialize]):
1246         (-[WebPreferences mediaRecorderEnabled]):
1247         (-[WebPreferences setMediaRecorderEnabled:]):
1248         * WebView/WebPreferencesPrivate.h:
1249         * WebView/WebView.mm:
1250         (-[WebView _preferencesChanged:]):
1251
1252 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1253
1254         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
1255         https://bugs.webkit.org/show_bug.cgi?id=190238
1256
1257         Reviewed by Antti Koivisto.
1258
1259         Enabled the feature by default.
1260
1261         * WebView/WebPreferences.mm:
1262         (+[WebPreferences initialize]):
1263
1264 2018-10-01  Dean Jackson  <dino@apple.com>
1265
1266         [macOS] Switching to discrete GPU should be done in the UI process
1267         https://bugs.webkit.org/show_bug.cgi?id=189361
1268         <rdar://problem/43949622>
1269
1270         Reviewed by Simon Fraser.
1271
1272         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
1273         not support swapping to the discrete GPU in this configuration.
1274
1275         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
1276         (WebKit::WebSwitchingGPUClient::singleton):
1277         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
1278         * WebView/WebView.mm:
1279         (-[WebView _commonInitializationWithFrameName:groupName:]):
1280
1281 2018-10-02  Alex Christensen  <achristensen@webkit.org>
1282
1283         Remove ParsedURLString
1284         https://bugs.webkit.org/show_bug.cgi?id=190154
1285
1286         Reviewed by Chris Dumez.
1287
1288         * WebView/WebScriptDebugger.mm:
1289         (toNSURL):
1290
1291 2018-10-01  Dean Jackson  <dino@apple.com>
1292
1293         Remove CSS Animation Triggers
1294         https://bugs.webkit.org/show_bug.cgi?id=190175
1295         <rdar://problem/44925626>
1296
1297         Reviewed by Simon Fraser.
1298
1299         * Configurations/FeatureDefines.xcconfig:
1300
1301 2018-10-02  Commit Queue  <commit-queue@webkit.org>
1302
1303         Unreviewed, rolling out r236624 and r236671.
1304         https://bugs.webkit.org/show_bug.cgi?id=190207
1305
1306         The change in r236624 introduced crashes on the bots
1307         (Requested by ryanhaddad on #webkit).
1308
1309         Reverted changesets:
1310
1311         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1312         https://bugs.webkit.org/show_bug.cgi?id=188747
1313         https://trac.webkit.org/changeset/236624
1314
1315         "Unify implementation in VideoFullscreenInterfaceAVKit"
1316         https://bugs.webkit.org/show_bug.cgi?id=190091
1317         https://trac.webkit.org/changeset/236671
1318
1319 2018-10-01  Alex Christensen  <achristensen@webkit.org>
1320
1321         URL should not use TextEncoding internally
1322         https://bugs.webkit.org/show_bug.cgi?id=190111
1323
1324         Reviewed by Andy Estes.
1325
1326         * Misc/WebNSURLExtras.mm:
1327
1328 2018-09-28  Jer Noble  <jer.noble@apple.com>
1329
1330         Refactoring: eliminate raw pointer usage in Fullscreen code
1331         https://bugs.webkit.org/show_bug.cgi?id=188747
1332         <rdar://problem/43541164>
1333
1334         Reviewed by Alex Christensen.
1335
1336         PlaybackSessionInterface no longer has an invalidate() method.
1337
1338         * WebView/WebView.mm:
1339         (-[WebView _clearPlaybackControlsManager]):
1340
1341 2018-09-28  Chris Dumez  <cdumez@apple.com>
1342
1343         Drop support for cross-origin-window-policy header
1344         https://bugs.webkit.org/show_bug.cgi?id=190081
1345
1346         Reviewed by Ryosuke Niwa.
1347
1348         * WebView/WebPreferenceKeysPrivate.h:
1349         * WebView/WebPreferences.mm:
1350         (+[WebPreferences initialize]):
1351         * WebView/WebPreferencesPrivate.h:
1352         * WebView/WebView.mm:
1353         (-[WebView _preferencesChanged:]):
1354
1355 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
1356
1357         Rename createMarkup to serializePreservingVisualAppearance
1358         https://bugs.webkit.org/show_bug.cgi?id=190086
1359
1360         Reviewed by Wenson Hsieh.
1361
1362         * DOM/WebDOMOperations.mm:
1363         (-[DOMRange markupString]):
1364
1365 2018-09-28  Commit Queue  <commit-queue@webkit.org>
1366
1367         Unreviewed, rolling out r236605.
1368         https://bugs.webkit.org/show_bug.cgi?id=190087
1369
1370         caused three API test timeouts (Requested by jernoble on
1371         #webkit).
1372
1373         Reverted changeset:
1374
1375         "Refactoring: eliminate raw pointer usage in Fullscreen code"
1376         https://bugs.webkit.org/show_bug.cgi?id=188747
1377         https://trac.webkit.org/changeset/236605
1378
1379 2018-09-28  Jer Noble  <jer.noble@apple.com>
1380
1381         Refactoring: eliminate raw pointer usage in Fullscreen code
1382         https://bugs.webkit.org/show_bug.cgi?id=188747
1383         <rdar://problem/43541164>
1384
1385         Reviewed by Alex Christensen.
1386
1387         PlaybackSessionInterface no longer has an invalidate() method.
1388
1389         * WebView/WebView.mm:
1390         (-[WebView _clearPlaybackControlsManager]):
1391
1392 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1393
1394         Use enum class in createMarkup arguments
1395         https://bugs.webkit.org/show_bug.cgi?id=190028
1396
1397         Reviewed by Wenson Hsieh.
1398
1399         * DOM/WebDOMOperations.mm:
1400         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
1401         (-[DOMRange markupString]): Ditto.
1402
1403 2018-09-27  Antoine Quint  <graouts@apple.com>
1404
1405         [Web Animations] Turn Web Animations with CSS integration on
1406         https://bugs.webkit.org/show_bug.cgi?id=184819
1407         <rdar://problem/39597337>
1408
1409         Reviewed by Dean Jackson.
1410
1411         * WebView/WebPreferences.mm:
1412         (+[WebPreferences initialize]):
1413
1414 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
1415
1416         Selection should work across shadow boundary when initiated by a mouse drag
1417         https://bugs.webkit.org/show_bug.cgi?id=151380
1418         <rdar://problem/24363872>
1419
1420         Reviewed by Wenson Hsieh.
1421
1422         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
1423
1424         * WebView/WebPreferenceKeysPrivate.h:
1425         * WebView/WebPreferences.mm:
1426         (+[WebPreferences initialize]):
1427         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
1428         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
1429         * WebView/WebPreferencesPrivate.h:
1430         * WebView/WebView.mm:
1431         (-[WebView _preferencesChanged:]):
1432
1433 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1434
1435         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
1436         https://bugs.webkit.org/show_bug.cgi?id=189918
1437         Work towards <rdar://problem/44648705>
1438
1439         Reviewed by Tim Horton.
1440
1441         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
1442
1443         * WebView/WebHTMLView.mm:
1444         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
1445         (-[WebHTMLView _updateFontPanel]):
1446         * WebView/WebView.mm:
1447         (-[WebView typingAttributes]):
1448
1449 2018-09-17  Darin Adler  <darin@apple.com>
1450
1451         Use OpaqueJSString rather than JSRetainPtr inside WebKit
1452         https://bugs.webkit.org/show_bug.cgi?id=189652
1453
1454         Reviewed by Saam Barati.
1455
1456         * WebView/WebPDFRepresentation.mm:
1457         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
1458
1459 2018-09-14  Jer Noble  <jer.noble@apple.com>
1460
1461         Turn SourceBufferChangeTypeEnabled on by default
1462         https://bugs.webkit.org/show_bug.cgi?id=189527
1463
1464         Reviewed by Eric Carlson.
1465
1466         * WebView/WebPreferences.mm:
1467         (+[WebPreferences initialize]):
1468
1469 2018-09-12  Alex Christensen  <achristensen@webkit.org>
1470
1471         Fix an internal build after r235935
1472         https://bugs.webkit.org/show_bug.cgi?id=188996
1473
1474         * Carbon/HIWebView.mm:
1475         (Draw):
1476         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
1477
1478 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
1479
1480         Add IGNORE_WARNING_.* macros
1481         https://bugs.webkit.org/show_bug.cgi?id=188996
1482
1483         Reviewed by Michael Catanzaro.
1484
1485         * Carbon/CarbonUtils.m:
1486         (PoolCleaner):
1487         * Carbon/CarbonWindowAdapter.mm:
1488         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1489         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1490         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1491         (-[CarbonWindowAdapter _termWindowIfOwner]):
1492         (-[CarbonWindowAdapter _windowMovedToRect:]):
1493         (-[CarbonWindowAdapter setContentView:]):
1494         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1495         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1496         * Carbon/CarbonWindowFrame.m:
1497         (-[CarbonWindowFrame title]):
1498         * Carbon/HIViewAdapter.m:
1499         (+[HIViewAdapter getHIViewForNSView:]):
1500         * Carbon/HIWebView.mm:
1501         (overrideCGContext):
1502         (restoreCGContext):
1503         (Draw):
1504         * DOM/DOM.mm:
1505         * History/WebHistory.mm:
1506         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
1507         * History/WebHistoryItem.mm:
1508         (-[WebHistoryItem icon]):
1509         * Misc/WebKitNSStringExtras.mm:
1510         (-[NSString _web_drawAtPoint:font:textColor:]):
1511         * Misc/WebNSImageExtras.m:
1512         (-[NSImage _web_scaleToMaxSize:]):
1513         (-[NSImage _web_dissolveToFraction:]):
1514         * Misc/WebNSPasteboardExtras.mm:
1515         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1516         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1517         * Panels/WebAuthenticationPanel.m:
1518         (-[WebAuthenticationPanel loadNib]):
1519         * Plugins/Hosted/NetscapePluginHostManager.mm:
1520         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1521         (WebKit::NetscapePluginHostManager::didCreateWindow):
1522         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1523         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
1524         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
1525         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
1526         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1527         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
1528         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1529         (-[WebHostedNetscapePluginView drawRect:]):
1530         * Plugins/Hosted/WebTextInputWindowController.m:
1531         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1532         * Plugins/WebBaseNetscapePluginView.mm:
1533         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
1534         * Plugins/WebNetscapePluginPackage.mm:
1535         (-[WebNetscapePluginPackage _tryLoad]):
1536         * Plugins/WebNetscapePluginView.mm:
1537         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1538         (-[WebNetscapePluginView sendDrawRectEvent:]):
1539         (-[WebNetscapePluginView drawRect:]):
1540         * Plugins/WebPluginController.mm:
1541         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
1542         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
1543         * WebCoreSupport/PopupMenuMac.mm:
1544         (PopupMenuMac::populate):
1545         * WebCoreSupport/WebAlternativeTextClient.h:
1546         * WebCoreSupport/WebDragClient.mm:
1547         (WebDragClient::startDrag):
1548         * WebCoreSupport/WebFrameLoaderClient.mm:
1549         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1550         (webGetNSImage):
1551         * WebInspector/WebNodeHighlight.mm:
1552         * WebInspector/WebNodeHighlightView.mm:
1553         (-[WebNodeHighlightView drawRect:]):
1554         * WebView/WebClipView.mm:
1555         (-[WebClipView initWithFrame:]):
1556         * WebView/WebFrame.mm:
1557         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1558         (-[WebFrame _drawRect:contentsOnly:]):
1559         (-[WebFrame accessibilityRoot]):
1560         * WebView/WebFullScreenController.mm:
1561         (-[WebFullScreenController enterFullScreen:]):
1562         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1563         (-[WebFullScreenController exitFullScreen]):
1564         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1565         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1566         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1567         * WebView/WebHTMLView.mm:
1568         (-[NSWindow _web_borderView]):
1569         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
1570         (-[WebHTMLView _setAsideSubviews]):
1571         (-[WebHTMLView _autoscroll]):
1572         (-[WebHTMLView drawRect:]):
1573         (-[WebHTMLView mouseDown:]):
1574         (-[WebHTMLView mouseDragged:]):
1575         (-[WebHTMLView mouseUp:]):
1576         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
1577         (-[WebHTMLView knowsPageRange:]):
1578         (-[WebHTMLView accessibilityHitTest:]):
1579         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1580         (-[WebHTMLView _colorAsString:]):
1581         (-[WebHTMLView copyFont:]):
1582         (-[WebHTMLView _executeSavedKeypressCommands]):
1583         (-[WebHTMLView attachRootLayer:]):
1584         (-[WebHTMLView textStorage]):
1585         (-[WebHTMLView _updateSelectionForInputManager]):
1586         * WebView/WebPDFView.mm:
1587         (_applicationInfoForMIMEType):
1588         (-[WebPDFView centerSelectionInVisibleArea:]):
1589         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1590         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1591         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1592         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
1593         * WebView/WebTextCompletionController.mm:
1594         (-[WebTextCompletionController _buildUI]):
1595         (-[WebTextCompletionController _placePopupWindow:]):
1596         * WebView/WebVideoFullscreenController.mm:
1597         * WebView/WebVideoFullscreenHUDWindowController.mm:
1598         (createMediaUIBackgroundView):
1599         * WebView/WebView.mm:
1600         (-[WebTextListTouchBarViewController initWithWebView:]):
1601         (-[WebView _dispatchTileDidDraw:]):
1602         (-[WebView encodeWithCoder:]):
1603         (-[WebView mainFrameIcon]):
1604         (LayerFlushController::flushLayers):
1605         * WebView/WebWindowAnimation.mm:
1606         (setScaledFrameForWindow):
1607
1608 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1609
1610         Remove unused needsDestruction class variables from HashTraits
1611         https://bugs.webkit.org/show_bug.cgi?id=189490
1612
1613         Reviewed by Daniel Bates.
1614
1615         * History/BinaryPropertyList.cpp: Removed needsDestruction.
1616
1617 2018-09-07  Frederic Wang  <fwang@igalia.com>
1618
1619         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
1620         https://bugs.webkit.org/show_bug.cgi?id=182230
1621
1622         Reviewed by Simon Fraser.
1623
1624         * DOM/DOMDocument.mm:
1625         (-[DOMDocument scrollingElement]): Use the new name.
1626
1627 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1628
1629         Refactor WebCore::EditAction to be an 8-bit enum class
1630         https://bugs.webkit.org/show_bug.cgi?id=189383
1631
1632         Reviewed by Dan Bernstein.
1633
1634         * WebCoreSupport/WebEditorClient.mm:
1635         (undoNameForEditAction):
1636         * WebView/WebHTMLView.mm:
1637         (-[WebHTMLView pasteFont:]):
1638         (-[WebHTMLView changeFont:]):
1639         (-[WebHTMLView changeAttributes:]):
1640         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
1641         (-[WebHTMLView changeColor:]):
1642         * WebView/WebView.mm:
1643         (-[WebView setTypingStyle:]):
1644
1645 2018-09-06  Frederic Wang  <fwang@igalia.com>
1646
1647         Group options of scrollRectToVisible into a struct
1648         https://bugs.webkit.org/show_bug.cgi?id=189352
1649
1650         Reviewed by Simon Fraser.
1651
1652         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
1653         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
1654         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
1655
1656 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1657
1658         [macOS] Cannot change font size at selection until font panel is shown
1659         https://bugs.webkit.org/show_bug.cgi?id=189295
1660         <rdar://problem/35593389>
1661
1662         Reviewed by Ryosuke Niwa.
1663
1664         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
1665         WebCore ChangeLog for more details.
1666
1667         * WebView/WebHTMLView.mm:
1668         (-[WebHTMLView changeFont:]):
1669         (-[WebHTMLView changeAttributes:]):
1670         (-[WebHTMLView _originalFontA]): Deleted.
1671         (-[WebHTMLView _originalFontB]): Deleted.
1672         (fontNameForDescription): Deleted.
1673         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
1674         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
1675         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
1676
1677 2018-09-05  Jer Noble  <jer.noble@apple.com>
1678
1679         Add MediaCapabilities as an Experimental Feature
1680         https://bugs.webkit.org/show_bug.cgi?id=189209
1681
1682         Reviewed by Eric Carlson.
1683
1684         RuntimeEnabledFeature -> Setting.
1685
1686         * WebView/WebView.mm:
1687         (-[WebView _preferencesChanged:]):
1688
1689 2018-09-04  Frederic Wang  <fwang@igalia.com>
1690
1691         Add basic support for ScrollIntoViewOptions
1692         https://bugs.webkit.org/show_bug.cgi?id=189258
1693
1694         Reviewed by Simon Fraser.
1695
1696         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
1697         header so that this file can build despite the new scrollIntoView function.
1698
1699 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1700
1701         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
1702         https://bugs.webkit.org/show_bug.cgi?id=188890
1703         <rdar://problem/43648605>
1704
1705         Reviewed by Tim Horton.
1706
1707         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
1708         more detail.
1709
1710         * WebCoreSupport/WebPlatformStrategies.h:
1711         * WebCoreSupport/WebPlatformStrategies.mm:
1712         (WebPlatformStrategies::allStringsForType):
1713
1714 2018-09-01  Darin Adler  <darin@apple.com>
1715
1716         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
1717         https://bugs.webkit.org/show_bug.cgi?id=189072
1718         Reviewed by Dan Bernstein.
1719
1720         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
1721         and declarations for NSURLDownload init methods.
1722
1723         * Misc/WebDownloadInternal.h: Removed.
1724
1725         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
1726         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
1727         "-Wdeprecated-declarations" because the method used here is deprecated.
1728
1729         * WebView/WebView.mm:
1730         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
1731         used here is deprecated.
1732
1733 2018-08-31  Chris Dumez  <cdumez@apple.com>
1734
1735         Assertion hit in ~CompletionHandler() from ~WebFrame()
1736         https://bugs.webkit.org/show_bug.cgi?id=189199
1737         <rdar://problem/42657233>
1738
1739         Reviewed by Youenn Fablet.
1740
1741         * WebCoreSupport/WebFrameLoaderClient.h:
1742         * WebCoreSupport/WebFrameLoaderClient.mm:
1743         (WebFrameLoaderClient::dispatchWillSubmitForm):
1744
1745 2018-08-31  Antti Koivisto  <antti@apple.com>
1746
1747         Replace OptionSet |= and -= operators with add() and remove() functions
1748         https://bugs.webkit.org/show_bug.cgi?id=189169
1749
1750         Reviewed by Anders Carlsson.
1751
1752         * WebView/WebFrame.mm:
1753         (-[WebFrame _drawRect:contentsOnly:]):
1754         * WebView/WebView.mm:
1755         (coreOptions):
1756
1757 2018-08-31  Frederic Wang  <fwang@igalia.com>
1758
1759         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
1760         https://bugs.webkit.org/show_bug.cgi?id=182053
1761
1762         Reviewed by Simon Fraser.
1763
1764         Add developer flag to use standard behavior for scrolling* attributes.
1765
1766         * WebView/WebPreferenceKeysPrivate.h:
1767         * WebView/WebPreferences.mm:
1768         (+[WebPreferences initialize]):
1769         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
1770         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
1771         * WebView/WebPreferencesPrivate.h:
1772         * WebView/WebView.mm:
1773         (-[WebView _preferencesChanged:]):
1774
1775 2018-08-29  Olivia Barnett  <obarnett@apple.com>
1776
1777         Implement the Web Share API
1778         https://bugs.webkit.org/show_bug.cgi?id=171100
1779         <rdar://problem/31751734>
1780
1781         Reviewed by Tim Horton.
1782
1783         * WebCoreSupport/WebChromeClient.h:
1784         * WebCoreSupport/WebChromeClient.mm:
1785         (WebChromeClient::showShareSheet):
1786         Empty declaration of showShareSheet.
1787
1788 2018-08-29  Youenn Fablet  <youenn@apple.com>
1789
1790         Remove WebRTC legacy API implementation
1791         https://bugs.webkit.org/show_bug.cgi?id=189040
1792
1793         Reviewed by Eric Carlson.
1794
1795         * WebView/WebPreferenceKeysPrivate.h:
1796         * WebView/WebPreferences.mm:
1797         (+[WebPreferences initialize]):
1798         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
1799         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
1800         * WebView/WebPreferencesPrivate.h:
1801         * WebView/WebView.mm:
1802         (-[WebView _preferencesChanged:]):
1803
1804 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1805
1806         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
1807         https://bugs.webkit.org/show_bug.cgi?id=189054
1808
1809         Reviewed by Andy Estes.
1810
1811         Remove the pasteboard type argument from readURLFromPasteboard.
1812
1813         * WebCoreSupport/WebPlatformStrategies.h:
1814         * WebCoreSupport/WebPlatformStrategies.mm:
1815         (WebPlatformStrategies::readURLFromPasteboard):
1816
1817 2018-08-27  Keith Rollin  <krollin@apple.com>
1818
1819         Unreviewed build fix -- disable LTO for production builds
1820
1821         * Configurations/Base.xcconfig:
1822
1823 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
1824
1825         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
1826         https://bugs.webkit.org/show_bug.cgi?id=188931
1827
1828         Reviewed by Wenson Hsieh.
1829
1830         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
1831
1832 2018-08-27  Keith Rollin  <krollin@apple.com>
1833
1834         Build system support for LTO
1835         https://bugs.webkit.org/show_bug.cgi?id=187785
1836         <rdar://problem/42353132>
1837
1838         Reviewed by Dan Bernstein.
1839
1840         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
1841         LTO.
1842
1843         * Configurations/Base.xcconfig:
1844         * Configurations/DebugRelease.xcconfig:
1845
1846 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
1847
1848         Pass in IsComposed flag to Event constructors
1849         https://bugs.webkit.org/show_bug.cgi?id=188720
1850         <rdar://problem/43580387>
1851
1852         Reviewed by Simon Fraser.
1853
1854         * WebView/WebPDFView.mm:
1855         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
1856         whether it's simulated or not.
1857
1858 2018-08-23  Mark Lam  <mark.lam@apple.com>
1859
1860         Move vmEntryGlobalObject() to VM from CallFrame.
1861         https://bugs.webkit.org/show_bug.cgi?id=188900
1862         <rdar://problem/43655753>
1863
1864         Reviewed by Michael Saboff.
1865
1866         * WebView/WebScriptDebugger.mm:
1867         (WebScriptDebugger::sourceParsed):
1868
1869 2018-08-23  Andy Estes  <aestes@apple.com>
1870
1871         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
1872         https://bugs.webkit.org/show_bug.cgi?id=188829
1873
1874         Reviewed by Tim Horton.
1875
1876         * Configurations/FeatureDefines.xcconfig:
1877
1878 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
1879
1880         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
1881         https://bugs.webkit.org/show_bug.cgi?id=188777
1882
1883         Reviewed by Simon Fraser.
1884
1885         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
1886         being "true" before the code change.
1887
1888         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
1889
1890         * WebView/WebPDFView.mm:
1891         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1892
1893 2018-08-21  Daniel Bates  <dabates@apple.com>
1894
1895         Replace TextCheckingTypeMask with OptionSet
1896         https://bugs.webkit.org/show_bug.cgi?id=188678
1897
1898         Reviewed by Antti Koivisto.
1899
1900         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
1901         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
1902         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
1903         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
1904
1905         * WebCoreSupport/WebEditorClient.h:
1906         * WebCoreSupport/WebEditorClient.mm:
1907         (WebEditorClient::checkTextOfParagraph):
1908         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
1909         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
1910         left as this is more readable and unncessary now that modern compilers like Clang have
1911         diagnostics to catch accidental assignments when equality was intended.
1912         (WebEditorClient::didCheckSucceed):
1913         * WebView/WebView.mm:
1914         (coreTextCheckingType):
1915         (textCheckingResultFromNSTextCheckingResult):
1916
1917 2018-08-21  Daniel Bates  <dabates@apple.com>
1918
1919         [iOS][WK1] Support toggling continuous spell checking from tests
1920         https://bugs.webkit.org/show_bug.cgi?id=188763
1921
1922         Reviewed by Simon Fraser.
1923
1924         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
1925         spell checking from tests in iOS WebKit Legacy.
1926
1927         * WebCoreSupport/WebEditorClient.h:
1928         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
1929         * WebCoreSupport/WebEditorClient.mm:
1930         * WebView/WebView.h:
1931         * WebView/WebView.mm:
1932         (-[WebView toggleContinuousSpellChecking:]):
1933         (-[WebView toggleSmartInsertDelete:]):
1934
1935 2018-08-17  Alex Christensen  <achristensen@webkit.org>
1936
1937         Add some plumbing for safe browsing
1938         https://bugs.webkit.org/show_bug.cgi?id=188709
1939
1940         Reviewed by Tim Horton.
1941
1942         * WebCoreSupport/WebFrameLoaderClient.h:
1943         * WebCoreSupport/WebFrameLoaderClient.mm:
1944         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1945
1946 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
1947
1948         Replace canBubble and cancelable booleans in Event by enum classes
1949         https://bugs.webkit.org/show_bug.cgi?id=188692
1950
1951         Reviewed by Alex Christensen.
1952
1953         * WebView/WebPDFView.mm:
1954         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1955         * WebView/WebView.mm:
1956         (-[WebView _dispatchUnloadEvent]):
1957
1958 2018-08-16  Jer Noble  <jer.noble@apple.com>
1959
1960         Add Experimental Feature support for SourceBuffer.changeType()
1961         https://bugs.webkit.org/show_bug.cgi?id=188626
1962         <rdar://problem/43356021>
1963
1964         Reviewed by Eric Carlson.
1965
1966         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
1967
1968         * WebView/WebPreferenceKeysPrivate.h:
1969         * WebView/WebPreferences.mm:
1970         (+[WebPreferences initialize]):
1971         (-[WebPreferences sourceBufferChangeTypeEnabled]):
1972         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
1973         * WebView/WebPreferencesPrivate.h:
1974         * WebView/WebView.mm:
1975         (-[WebView _preferencesChanged:]):
1976
1977 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
1978
1979         Support drag-and-drop for input[type=color]
1980         https://bugs.webkit.org/show_bug.cgi?id=188464
1981
1982         Reviewed by Wenson Hsieh.
1983
1984         * WebCoreSupport/WebPlatformStrategies.h:
1985         * WebCoreSupport/WebPlatformStrategies.mm:
1986         (WebPlatformStrategies::setColor):
1987
1988 2018-08-15  Tim Horton  <timothy_horton@apple.com>
1989
1990         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
1991         https://bugs.webkit.org/show_bug.cgi?id=188569
1992         <rdar://problem/34201095>
1993
1994         Reviewed by Megan Gardner.
1995
1996         * WebView/WebImmediateActionController.mm:
1997         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1998         Speculative fix; the crashes indicate font is null, but we just checked it,
1999         so it must be getting made null by convertFont:toSize:. Check again!
2000
2001 2018-08-13  Alex Christensen  <achristensen@webkit.org>
2002
2003         Use a 1-byte enum class for TextDirection
2004         https://bugs.webkit.org/show_bug.cgi?id=188350
2005
2006         Reviewed by Simon Fraser.
2007
2008         * WebCoreSupport/PopupMenuMac.mm:
2009         (PopupMenuMac::populate):
2010         (PopupMenuMac::show):
2011         * WebCoreSupport/WebFrameLoaderClient.mm:
2012         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2013         * WebView/WebFrame.mm:
2014         (-[WebFrame _dispatchDidReceiveTitle:]):
2015
2016 2018-08-09  Ali Juma  <ajuma@chromium.org>
2017
2018         Import WPTs for IntersectionObserver
2019         https://bugs.webkit.org/show_bug.cgi?id=188416
2020
2021         Reviewed by Simon Fraser.
2022
2023         * WebView/WebPreferencesPrivate.h:
2024
2025 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
2026
2027         Follow-up build fix for r234685
2028         https://bugs.webkit.org/show_bug.cgi?id=188245
2029
2030         Unreviewed build fix.
2031
2032         * WebCoreSupport/WebSecurityOriginPrivate.h:
2033
2034 2018-08-05  Darin Adler  <darin@apple.com>
2035
2036         [Cocoa] More tweaks and refactoring to prepare for ARC
2037         https://bugs.webkit.org/show_bug.cgi?id=188245
2038
2039         Reviewed by Dan Bernstein.
2040
2041         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
2042
2043         * Carbon/CarbonWindowFrame.m:
2044         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
2045
2046         * DOM/DOM.mm:
2047         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
2048         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
2049         garbage collection so this method isn't useful.
2050
2051         * DOM/DOMXPath.mm:
2052         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
2053         Objective-C garbage collection so this method isn't useful.
2054
2055         * History/WebHistory.mm:
2056         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
2057
2058         * Misc/WebElementDictionary.mm:
2059         (addLookupKey): Use a bridging cast.
2060         (cacheValueForKey): Ditto.
2061         (-[WebElementDictionary _fillCache]): Ditto.
2062         (-[WebElementDictionary objectForKey:]): Ditto.
2063
2064         * Misc/WebKitNSStringExtras.mm:
2065         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
2066         (-[NSString _web_widthWithFont:]): Ditto.
2067         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
2068
2069         * Misc/WebLocalizableStrings.mm:
2070         (WebLocalizedString): Use a bridging cast.
2071
2072         * Misc/WebNSDataExtras.mm:
2073         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
2074         and use CFBridgingRelease instead of calling autorelease directly.
2075         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
2076         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
2077         on the amount of explicit release and autorelease.
2078
2079         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
2080         * Misc/WebNSDictionaryExtras.m:
2081         (-[NSDictionary _webkit_intForKey:]): Deleted.
2082         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
2083         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
2084         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
2085         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
2086         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
2087         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
2088
2089         * Misc/WebStringTruncator.mm:
2090         (fontFromNSFont): Use a bridging cast.
2091
2092         * Plugins/Hosted/NetscapePluginHostManager.mm:
2093         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
2094
2095         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2096         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
2097         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
2098         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
2099         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
2100         * Plugins/Hosted/ProxyInstance.mm:
2101         (WebKit::ProxyInstance::getPropertyNames): Ditto.
2102         * Plugins/WebBasePluginPackage.mm:
2103         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
2104         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2105         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
2106         * Plugins/WebNetscapePluginPackage.mm:
2107         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
2108
2109         * Plugins/WebNetscapePluginView.mm:
2110         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
2111         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
2112         (-[WebNetscapePluginView status:]): Use a bridging cast.
2113         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
2114
2115         * Plugins/WebPluginController.mm:
2116         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
2117
2118         * Plugins/WebPluginDatabase.mm:
2119         (checkCandidate): Use explicit __strong for out argument types.
2120
2121         * Plugins/npapi.mm:
2122         (pluginViewForInstance): Use a bridging cast.
2123
2124         * Storage/WebDatabaseManager.mm:
2125         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
2126         explicit NSNumber and NSDictionary calls.
2127
2128         * WebCoreSupport/WebContextMenuClient.mm:
2129         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
2130
2131         * WebCoreSupport/WebEditorClient.mm:
2132         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
2133         (WebEditorClient::handleInputMethodKeydown): Ditto.
2134
2135         * WebCoreSupport/WebFrameNetworkingContext.mm:
2136         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
2137
2138         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
2139         as a struct rather than an Objective-C class, since that's how it's defined.
2140
2141         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
2142
2143         * WebView/WebFullScreenController.mm:
2144         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
2145         * WebView/WebHTMLView.mm:
2146         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2147         Ditto.
2148         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2149
2150         * WebView/WebImmediateActionController.mm:
2151         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
2152         go down to the document and then back to the frame.
2153         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
2154         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
2155         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
2156
2157         * WebView/WebJSPDFDoc.mm:
2158         (jsPDFDocInitialize): Removed some unneeded type casting.
2159         (jsPDFDocFinalize): Ditto.
2160         (jsPDFDocPrint): Use a bridging cast.
2161
2162         * WebView/WebPDFView.mm:
2163         (_applicationInfoForMIMEType): Use bridging casts.
2164
2165         * WebView/WebPreferences.mm:
2166         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
2167         instead of methods from WebNSDictionaryExtras.
2168         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
2169         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
2170         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
2171         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
2172         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
2173
2174         * WebView/WebView.mm:
2175         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
2176         (-[WebView _addToAllWebViewsSet]): Ditto.
2177         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
2178         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
2179         so it can be called from WebViewData methods.
2180
2181         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
2182         method, _windowVisibilityChanged:.
2183
2184         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
2185         called from WebViewData methods.
2186
2187 2018-08-06  Alex Christensen  <achristensen@webkit.org>
2188
2189         Use enum classes and OptionSets for PaintPhase and PaintBehavior
2190         https://bugs.webkit.org/show_bug.cgi?id=188323
2191
2192         Reviewed by Simon Fraser.
2193
2194         * WebCoreSupport/WebContextMenuClient.mm:
2195         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
2196         * WebView/WebFrame.mm:
2197         (-[WebFrame _paintBehaviorForDestinationContext:]):
2198         (-[WebFrame _drawRect:contentsOnly:]):
2199         * WebView/WebHTMLView.mm:
2200         (imageFromRect):
2201         (selectionImage):
2202
2203 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2204
2205         Add support for microtasks in workers
2206         https://bugs.webkit.org/show_bug.cgi?id=188246
2207
2208         Reviewed by Darin Adler.
2209
2210         Rename JSMainThreadExecState.h to JSExecState.h.
2211
2212         * DOM/DOMAttr.mm:
2213         * DOM/DOMBlob.mm:
2214         * DOM/DOMCDATASection.mm:
2215         * DOM/DOMCSSCharsetRule.mm:
2216         * DOM/DOMCSSFontFaceRule.mm:
2217         * DOM/DOMCSSImportRule.mm:
2218         * DOM/DOMCSSMediaRule.mm:
2219         * DOM/DOMCSSPageRule.mm:
2220         * DOM/DOMCSSPrimitiveValue.mm:
2221         * DOM/DOMCSSRule.mm:
2222         * DOM/DOMCSSRuleList.mm:
2223         * DOM/DOMCSSStyleDeclaration.mm:
2224         * DOM/DOMCSSStyleRule.mm:
2225         * DOM/DOMCSSStyleSheet.mm:
2226         * DOM/DOMCSSUnknownRule.mm:
2227         * DOM/DOMCSSValue.mm:
2228         * DOM/DOMCSSValueList.mm:
2229         * DOM/DOMCharacterData.mm:
2230         * DOM/DOMComment.mm:
2231         * DOM/DOMCounter.mm:
2232         * DOM/DOMDocument.mm:
2233         * DOM/DOMDocumentFragment.mm:
2234         * DOM/DOMDocumentType.mm:
2235         * DOM/DOMElement.mm:
2236         * DOM/DOMEvent.mm:
2237         * DOM/DOMFile.mm:
2238         * DOM/DOMFileList.mm:
2239         * DOM/DOMHTML.mm:
2240         * DOM/DOMHTMLAnchorElement.mm:
2241         * DOM/DOMHTMLAppletElement.mm:
2242         * DOM/DOMHTMLAreaElement.mm:
2243         * DOM/DOMHTMLBRElement.mm:
2244         * DOM/DOMHTMLBaseElement.mm:
2245         * DOM/DOMHTMLBaseFontElement.mm:
2246         * DOM/DOMHTMLBodyElement.mm:
2247         * DOM/DOMHTMLButtonElement.mm:
2248         * DOM/DOMHTMLCanvasElement.mm:
2249         * DOM/DOMHTMLCollection.mm:
2250         * DOM/DOMHTMLDListElement.mm:
2251         * DOM/DOMHTMLDirectoryElement.mm:
2252         * DOM/DOMHTMLDivElement.mm:
2253         * DOM/DOMHTMLDocument.mm:
2254         * DOM/DOMHTMLElement.mm:
2255         * DOM/DOMHTMLEmbedElement.mm:
2256         * DOM/DOMHTMLFieldSetElement.mm:
2257         * DOM/DOMHTMLFontElement.mm:
2258         * DOM/DOMHTMLFormElement.mm:
2259         * DOM/DOMHTMLFrameElement.mm:
2260         * DOM/DOMHTMLFrameSetElement.mm:
2261         * DOM/DOMHTMLHRElement.mm:
2262         * DOM/DOMHTMLHeadElement.mm:
2263         * DOM/DOMHTMLHeadingElement.mm:
2264         * DOM/DOMHTMLHtmlElement.mm:
2265         * DOM/DOMHTMLIFrameElement.mm:
2266         * DOM/DOMHTMLImageElement.mm:
2267         * DOM/DOMHTMLInputElement.mm:
2268         * DOM/DOMHTMLLIElement.mm:
2269         * DOM/DOMHTMLLabelElement.mm:
2270         * DOM/DOMHTMLLegendElement.mm:
2271         * DOM/DOMHTMLLinkElement.mm:
2272         * DOM/DOMHTMLMapElement.mm:
2273         * DOM/DOMHTMLMarqueeElement.mm:
2274         * DOM/DOMHTMLMediaElement.mm:
2275         * DOM/DOMHTMLMenuElement.mm:
2276         * DOM/DOMHTMLMetaElement.mm:
2277         * DOM/DOMHTMLModElement.mm:
2278         * DOM/DOMHTMLOListElement.mm:
2279         * DOM/DOMHTMLObjectElement.mm:
2280         * DOM/DOMHTMLOptGroupElement.mm:
2281         * DOM/DOMHTMLOptionElement.mm:
2282         * DOM/DOMHTMLOptionsCollection.mm:
2283         * DOM/DOMHTMLParagraphElement.mm:
2284         * DOM/DOMHTMLParamElement.mm:
2285         * DOM/DOMHTMLPreElement.mm:
2286         * DOM/DOMHTMLQuoteElement.mm:
2287         * DOM/DOMHTMLScriptElement.mm:
2288         * DOM/DOMHTMLSelectElement.mm:
2289         * DOM/DOMHTMLStyleElement.mm:
2290         * DOM/DOMHTMLTableCaptionElement.mm:
2291         * DOM/DOMHTMLTableCellElement.mm:
2292         * DOM/DOMHTMLTableColElement.mm:
2293         * DOM/DOMHTMLTableElement.mm:
2294         * DOM/DOMHTMLTableRowElement.mm:
2295         * DOM/DOMHTMLTableSectionElement.mm:
2296         * DOM/DOMHTMLTextAreaElement.mm:
2297         * DOM/DOMHTMLTitleElement.mm:
2298         * DOM/DOMHTMLUListElement.mm:
2299         * DOM/DOMHTMLVideoElement.mm:
2300         * DOM/DOMImplementation.mm:
2301         * DOM/DOMKeyboardEvent.mm:
2302         * DOM/DOMMediaError.mm:
2303         * DOM/DOMMediaList.mm:
2304         * DOM/DOMMouseEvent.mm:
2305         * DOM/DOMMutationEvent.mm:
2306         * DOM/DOMNamedNodeMap.mm:
2307         * DOM/DOMNode.mm:
2308         * DOM/DOMNodeIterator.mm:
2309         * DOM/DOMNodeList.mm:
2310         * DOM/DOMOverflowEvent.mm:
2311         * DOM/DOMProcessingInstruction.mm:
2312         * DOM/DOMProgressEvent.mm:
2313         * DOM/DOMRGBColor.mm:
2314         * DOM/DOMRange.mm:
2315         * DOM/DOMRect.mm:
2316         * DOM/DOMStyleSheet.mm:
2317         * DOM/DOMStyleSheetList.mm:
2318         * DOM/DOMText.mm:
2319         * DOM/DOMTextEvent.mm:
2320         * DOM/DOMTimeRanges.mm:
2321         * DOM/DOMTokenList.mm:
2322         * DOM/DOMTreeWalker.mm:
2323         * DOM/DOMUIEvent.mm:
2324         * DOM/DOMWheelEvent.mm:
2325         * DOM/DOMXPathExpression.mm:
2326         * DOM/DOMXPathResult.mm:
2327         * DOM/ObjCEventListener.mm:
2328
2329 2018-08-03  Alex Christensen  <achristensen@webkit.org>
2330
2331         Fix spelling of "overridden"
2332         https://bugs.webkit.org/show_bug.cgi?id=188315
2333
2334         Reviewed by Darin Adler.
2335
2336         * Misc/WebKitVersionChecks.mm:
2337         (setWebKitLinkTimeVersion):
2338         (WebKitLinkTimeVersion):
2339         * Plugins/WebBaseNetscapePluginView.mm:
2340         (-[WebBaseNetscapePluginView handleMouseMoved:]):
2341         * WebCoreSupport/PopupMenuMac.mm:
2342         (PopupMenuMac::populate):
2343
2344 2018-08-01  Nan Wang  <n_wang@apple.com>
2345
2346         AX: AOM: Add ARIA IDL Attribute Reflection
2347         https://bugs.webkit.org/show_bug.cgi?id=184676
2348         <rdar://problem/39476882>
2349
2350         Reviewed by Chris Fleizach.
2351
2352         * WebView/WebPreferenceKeysPrivate.h:
2353         * WebView/WebPreferences.mm:
2354         (+[WebPreferences initialize]):
2355         (-[WebPreferences ariaReflectionEnabled]):
2356         (-[WebPreferences setAriaReflectionEnabled:]):
2357         * WebView/WebPreferencesPrivate.h:
2358         * WebView/WebView.mm:
2359         (-[WebView _preferencesChanged:]):
2360
2361 2018-07-30  Simon Fraser  <simon.fraser@apple.com>
2362
2363         Shrink GraphicsLayerCA
2364         https://bugs.webkit.org/show_bug.cgi?id=188141
2365
2366         Reviewed by Zalan Bujtas.
2367
2368         Shrink GraphicsLayerCA from 1040 to 880 bytes by:
2369         * moving all the clone-related stuff into the lazily-allocated m_layerClones
2370         * moving all the animation-related stuff into the lazily-allocated m_animations
2371         * making enums be 8-bit
2372         * re-ordering data members
2373
2374         * WebView/WebView.mm:
2375         (-[WebView _setMediaLayer:forPluginView:]):
2376
2377 2018-07-30  Rob Buis  <rbuis@igalia.com>
2378
2379         Merge PlatformCookieJar functions into NetworkStorageSession
2380         https://bugs.webkit.org/show_bug.cgi?id=188137
2381
2382         Adapt callsites to use NetworkStorageSession instead of CookieJar functions.
2383
2384         Reviewed by Alex Christensen.
2385
2386         * WebCoreSupport/WebPlatformStrategies.mm:
2387         (WebPlatformStrategies::cookiesForDOM):
2388         (WebPlatformStrategies::setCookiesFromDOM):
2389         (WebPlatformStrategies::cookiesEnabled):
2390         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2391         (WebPlatformStrategies::getRawCookies):
2392         (WebPlatformStrategies::deleteCookie):
2393         * WebView/WebPreferences.mm:
2394         (+[WebPreferences _clearNetworkLoaderSession]):
2395
2396 2018-07-28  Darin Adler  <darin@apple.com>
2397
2398         [Cocoa] Update more WebCore Objective-C code to be ARC compatible
2399         https://bugs.webkit.org/show_bug.cgi?id=188140
2400
2401         Reviewed by Sam Weinig.
2402
2403         * WebView/WebImmediateActionController.mm:
2404         (-[WebImmediateActionController _animationControllerForText]): Updated to use the
2405         new DictionaryLookup function that returns a tuple instead of using an out argument.
2406
2407 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
2408
2409         [INTL] Remove INTL sub-feature compile flags
2410         https://bugs.webkit.org/show_bug.cgi?id=188081
2411
2412         Reviewed by Michael Catanzaro.
2413
2414         * Configurations/FeatureDefines.xcconfig:
2415
2416 2018-07-26  Commit Queue  <commit-queue@webkit.org>
2417
2418         Unreviewed, rolling out r234181 and r234189.
2419         https://bugs.webkit.org/show_bug.cgi?id=188075
2420
2421         These are not needed right now (Requested by thorton on
2422         #webkit).
2423
2424         Reverted changesets:
2425
2426         "Enable Web Content Filtering on watchOS"
2427         https://bugs.webkit.org/show_bug.cgi?id=187979
2428         https://trac.webkit.org/changeset/234181
2429
2430         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
2431         https://bugs.webkit.org/show_bug.cgi?id=187985
2432         https://trac.webkit.org/changeset/234189
2433
2434 2018-07-26  Timothy Hatcher  <timothy@apple.com>
2435
2436         Use the Page's appearance when converting pasteboard attributed strings.
2437         https://bugs.webkit.org/show_bug.cgi?id=188067
2438         rdar://problem/42632246
2439
2440         Reviewed by Wenson Hsieh.
2441
2442         * WebCoreSupport/WebEditorClient.mm:
2443         (_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
2444
2445 2018-07-25  Chris Dumez  <cdumez@apple.com>
2446
2447         navigator.userAgent may return outdated value after webView.customUserAgent is set
2448         https://bugs.webkit.org/show_bug.cgi?id=188009
2449         <rdar://problem/42566456>
2450
2451         Reviewed by Alex Christensen.
2452
2453         Let the page know when the user agent changes.
2454
2455         * WebView/WebView.mm:
2456         (-[WebView _preferencesChanged:]):
2457         (-[WebView setApplicationNameForUserAgent:]):
2458         (-[WebView _invalidateUserAgentCache]):
2459         (-[WebView setCustomUserAgent:]):
2460         * WebView/WebViewInternal.h:
2461
2462 2018-07-24  Tim Horton  <timothy_horton@apple.com>
2463
2464         Enable Web Content Filtering on watchOS
2465         https://bugs.webkit.org/show_bug.cgi?id=187979
2466         <rdar://problem/42559346>
2467
2468         Reviewed by Wenson Hsieh.
2469
2470         * Configurations/FeatureDefines.xcconfig:
2471
2472 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
2473
2474         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
2475         https://bugs.webkit.org/show_bug.cgi?id=187846
2476
2477         Reviewed by Simon Fraser.
2478
2479         Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
2480
2481         * WebView/WebHTMLView.mm:
2482         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection.
2483         (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
2484
2485 2018-07-11  Dean Jackson  <dino@apple.com>
2486
2487         Allow removal of white backgrounds
2488         https://bugs.webkit.org/show_bug.cgi?id=187574
2489         <rdar://problem/41146792>
2490
2491         Reviewed by Simon Fraser.
2492
2493         Add a new WebPreference for punching out white backgrounds.
2494
2495         * WebView/WebPreferenceKeysPrivate.h:
2496         * WebView/WebPreferences.mm:
2497         (+[WebPreferences initialize]):
2498         (-[WebPreferences punchOutWhiteBackgroundsInDarkMode]):
2499         (-[WebPreferences setPunchOutWhiteBackgroundsInDarkMode:]):
2500         * WebView/WebPreferencesPrivate.h:
2501         * WebView/WebView.mm:
2502         (-[WebView _preferencesChanged:]):
2503
2504 2018-07-14  Kocsen Chung  <kocsen_chung@apple.com>
2505
2506         Ensure WebKit stack is ad-hoc signed
2507         https://bugs.webkit.org/show_bug.cgi?id=187667
2508
2509         Reviewed by Alexey Proskuryakov.
2510
2511         * Configurations/Base.xcconfig:
2512
2513 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
2514
2515         REGRESSION (231276): Attempting to copy an image fails
2516         https://bugs.webkit.org/show_bug.cgi?id=187212
2517         <rdar://problem/41540074>
2518
2519         Reviewed by Ryosuke Niwa.
2520
2521         Renamed methods to make it clear that one URL and one title are being passed in.
2522
2523         * WebCoreSupport/WebPlatformStrategies.h:
2524         * WebCoreSupport/WebPlatformStrategies.mm:
2525         (WebPlatformStrategies::setURL):
2526
2527 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
2528
2529         Disable cross-origin-window-policy by default
2530         https://bugs.webkit.org/show_bug.cgi?id=187509
2531
2532         Reviewed by Chris Dumez.
2533
2534         * WebView/WebPreferences.mm:
2535         (+[WebPreferences initialize]):
2536
2537 2018-07-09  Timothy Hatcher  <timothy@apple.com>
2538
2539         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2540         https://bugs.webkit.org/show_bug.cgi?id=187425
2541         rdar://problem/39948240
2542
2543         Reviewed by Tim Horton.
2544
2545         * WebView/WebView.mm:
2546         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
2547         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
2548         a call in this method to setUseDarkAppearance.
2549         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
2550         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
2551         (-[WebView _updateDefaultAppearance]): Deleted.
2552         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
2553
2554 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
2555
2556         Shrink various loading-related enums to shrink CachedResource
2557         https://bugs.webkit.org/show_bug.cgi?id=187443
2558
2559         Reviewed by Chris Dumez.
2560
2561         * WebCoreSupport/WebFrameLoaderClient.mm:
2562         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2563         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2564         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2565         (WebFrameLoaderClient::dispatchWillSendRequest):
2566         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2567         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2568         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2569         (WebFrameLoaderClient::updateGlobalHistory):
2570         (WebFrameLoaderClient::canHandleRequest const):
2571         * WebView/WebDataSource.mm:
2572         (-[WebDataSource initialRequest]):
2573         (-[WebDataSource request]):
2574
2575 2018-07-09  Commit Queue  <commit-queue@webkit.org>
2576
2577         Unreviewed, rolling out r233612.
2578         https://bugs.webkit.org/show_bug.cgi?id=187475
2579
2580         Revision caused the api test LinkColorWithSystemAppearance to
2581         fail on all systems. (Requested by Truitt on #webkit).
2582
2583         Reverted changeset:
2584
2585         "Semantic colors don't update when accessibility Increase
2586         Contrast mode is enabled."
2587         https://bugs.webkit.org/show_bug.cgi?id=187425
2588         https://trac.webkit.org/changeset/233612
2589
2590 2018-07-06  Timothy Hatcher  <timothy@apple.com>
2591
2592         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2593         https://bugs.webkit.org/show_bug.cgi?id=187425
2594         rdar://problem/39948240
2595
2596         Reviewed by Tim Horton.
2597
2598         * WebView/WebView.mm:
2599         (-[WebView _commonInitializationWithFrameName:groupName:]): Removed call to
2600         _updateDefaultAppearance, which called setUseDarkAppearance. There is already
2601         a call in this method to setUseDarkAppearance.
2602         (-[WebView _setUseSystemAppearance:]): Just call the page, not setUseDarkAppearance.
2603         (-[WebView viewDidChangeEffectiveAppearance]): Added. This is the proper NSView method to use.
2604         (-[WebView _updateDefaultAppearance]): Deleted.
2605         (-[WebView effectiveAppearanceDidChange]): Deleted. This method is a deprecated name.
2606
2607 2018-07-05  Timothy Hatcher  <timothy@apple.com>
2608
2609         Rename and flip the meaning of defaultAppearance to be useDarkAppearance.
2610         https://bugs.webkit.org/show_bug.cgi?id=187369
2611         rdar://problem/41870420
2612
2613         Reviewed by Tim Horton.
2614
2615         * WebView/WebMediaPlaybackTargetPicker.mm:
2616         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker):
2617         * WebView/WebView.mm:
2618         (-[WebView _commonInitializationWithFrameName:groupName:]):
2619         (-[WebView _effectiveAppearanceIsDark]):
2620         (-[WebView _updateDefaultAppearance]):
2621         (-[WebView _defaultAppearance]): Deleted.
2622
2623 2018-07-04  Ryosuke Niwa  <rniwa@webkit.org>
2624
2625         Youtube video pages crash after a couple of minutes
2626         https://bugs.webkit.org/show_bug.cgi?id=187316
2627
2628         Reviewed by Antti Koivisto.
2629
2630         * WebView/WebView.mm:
2631         (-[WebView _preferencesChanged:]):
2632
2633 2018-07-04  Tim Horton  <timothy_horton@apple.com>
2634
2635         Introduce PLATFORM(IOSMAC)
2636         https://bugs.webkit.org/show_bug.cgi?id=187315
2637
2638         Reviewed by Dan Bernstein.
2639
2640         * Configurations/Base.xcconfig:
2641         * Configurations/FeatureDefines.xcconfig:
2642
2643 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
2644
2645         [iOS] DataTransfer.getData always returns the empty string when dropping text
2646         https://bugs.webkit.org/show_bug.cgi?id=187130
2647         <rdar://problem/41014117>
2648
2649         Reviewed by Ryosuke Niwa.
2650
2651         Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
2652
2653         * WebCoreSupport/WebPlatformStrategies.h:
2654         * WebCoreSupport/WebPlatformStrategies.mm:
2655         (WebPlatformStrategies::allPasteboardItemInfo):
2656
2657 2018-06-26  Eric Carlson  <eric.carlson@apple.com>
2658
2659         [Mac] AirPlay picker uses incorrect theme in Dark mode
2660         https://bugs.webkit.org/show_bug.cgi?id=187054
2661         <rdar://problem/41291093>
2662
2663         Reviewed by Timothy Hatcher.
2664
2665         * WebView/WebMediaPlaybackTargetPicker.mm:
2666         (WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
2667
2668 2018-06-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2669
2670         [WTF] Add user-defined literal for ASCIILiteral
2671         https://bugs.webkit.org/show_bug.cgi?id=186839
2672
2673         Reviewed by Darin Adler.
2674
2675         * DOM/ExceptionHandlers.mm:
2676         (raiseDOMErrorException):
2677         * Plugins/Hosted/ProxyInstance.mm:
2678         (WebKit::ProxyInstance::invokeMethod):
2679         * Storage/WebDatabaseProvider.mm:
2680         (WebDatabaseProvider::indexedDatabaseDirectoryPath):
2681
2682 2018-06-22  Timothy Hatcher  <timothy@apple.com>
2683
2684         Recalc styles every time defaultAppearance changes.
2685         https://bugs.webkit.org/show_bug.cgi?id=186866
2686         rdar://problem/41309805
2687
2688         Reviewed by Tim Horton.
2689
2690         * WebView/WebView.mm:
2691         (-[WebView _updateDefaultAppearance]):
2692         (-[WebView _setUseSystemAppearance:]):
2693         (-[WebView _useSystemAppearance]):
2694
2695 2018-06-20  Darin Adler  <darin@apple.com>
2696
2697         [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
2698         https://bugs.webkit.org/show_bug.cgi?id=186875
2699
2700         Reviewed by Anders Carlsson.
2701
2702         * WebView/WebHTMLView.mm:
2703         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
2704         to write te file to.
2705         * WebView/WebPreferences.mm:
2706         (-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.
2707         * WebView/WebView.mm:
2708         (-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.
2709
2710 2018-06-12  Darin Adler  <darin@apple.com>
2711
2712         [Cocoa] Make some RetainPtr refinements to get more ready for ARC
2713         https://bugs.webkit.org/show_bug.cgi?id=186526
2714
2715         Reviewed by Anders Carlsson.
2716
2717         * Plugins/Hosted/NetscapePluginHostManager.mm:
2718         (WebKit::preferredBundleLocalizationName): Use bridgingAutorelease.
2719
2720         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2721         (-[WebHostedNetscapePluginView createPluginLayer]): Use move
2722         assignment rather than adoptNS/leakRef.
2723         * Plugins/WebNetscapePluginView.mm:
2724         (-[WebNetscapePluginView createPlugin]): Ditto.
2725
2726         * WebCoreSupport/WebContextMenuClient.mm:
2727         (WebContextMenuClient::contextMenuForEvent): Get rid of unnecessary use of
2728         RetainPtr::autorelease; no need to autorelease just to pass something as a function
2729         argument, so use RetainPtr::get instead.
2730
2731         * WebView/WebHTMLView.mm:
2732         (customMenuFromDefaultItems): Get rid of of unnecessary use of RetainPtr::autorelease.
2733         No need to autorelease the result when the return type is RetainPtr.
2734
2735         * WebView/WebPDFRepresentation.mm:
2736         (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Use bridgingAutorelease.
2737
2738 2018-06-13  Youenn Fablet  <youenn@apple.com>
2739
2740         Supported plugin check should be based on plugin identifier
2741         https://bugs.webkit.org/show_bug.cgi?id=186578
2742         <rdar://problem/40523828>
2743
2744         Reviewed by Darin Adler.
2745
2746         * WebCoreSupport/WebPluginInfoProvider.h:
2747         * WebCoreSupport/WebPluginInfoProvider.mm:
2748         (WebPluginInfoProvider::pluginInfo):
2749         (WebPluginInfoProvider::webVisiblePluginInfo):
2750
2751 2018-06-13  Chris Dumez  <cdumez@apple.com>
2752
2753         PSON: http/tests/resourceLoadStatistics/classify-as-prevalent-based-on-top-frame-redirect-collusion.html ASSERTS with process swap enabled
2754         https://bugs.webkit.org/show_bug.cgi?id=186545
2755
2756         Reviewed by Brady Eidson.
2757
2758         Update client delegate now that parameter type has changed.
2759
2760         * WebCoreSupport/WebFrameLoaderClient.h:
2761         * WebCoreSupport/WebFrameLoaderClient.mm:
2762         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2763
2764 2018-06-11  Tim Horton  <timothy_horton@apple.com>
2765
2766         Link drag image is inconsistently unreadable in dark mode
2767         https://bugs.webkit.org/show_bug.cgi?id=186472
2768
2769         Reviewed by Timothy Hatcher.
2770
2771         * WebView/WebView.mm:
2772         (-[WebView _defaultAppearance]):
2773         Make defaultAppearance accurate even if useSystemAppearance is false.
2774         Some parts of WebKit (like the link drag image, but also context menus)
2775         want to be able to follow the system appearance regardless of whether
2776         the view or content has opted in.
2777
2778 2018-06-11  Chris Dumez  <cdumez@apple.com>
2779
2780         http/tests/security/cors-post-redirect-307.html fails with PSON enabled
2781         https://bugs.webkit.org/show_bug.cgi?id=186441
2782
2783         Reviewed by Brady Eidson.
2784
2785         Rename existing flag to something a bit more generic, now that it is used for
2786         more things than bypassing the navigation policy check.
2787
2788         * WebView/WebView.mm:
2789         (-[WebView _loadBackForwardListFromOtherView:]):
2790         (-[WebView goToBackForwardItem:]):
2791
2792 2018-06-09  Dan Bernstein  <mitz@apple.com>
2793
2794         [Xcode] Clean up and modernize some build setting definitions
2795         https://bugs.webkit.org/show_bug.cgi?id=186463
2796
2797         Reviewed by Sam Weinig.
2798
2799         * Configurations/Base.xcconfig: Removed definition for macOS 10.11.
2800         * Configurations/DebugRelease.xcconfig: Ditto.
2801         * Configurations/FeatureDefines.xcconfig: Simplified the definitions of ENABLE_APPLE_PAY and
2802           ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest supported version.
2803         * Configurations/Version.xcconfig: Removed definition for macOS 10.11.
2804         * Configurations/WebKitLegacy.xcconfig: Simplified the definition of WK_PRIVATE_FRAMEWORKS_DIR
2805           now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
2806         * Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for macOS 10.11.
2807
2808 2018-06-08  Darin Adler  <darin@apple.com>
2809
2810         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
2811         https://bugs.webkit.org/show_bug.cgi?id=186436
2812
2813         Reviewed by Anders Carlsson.
2814
2815         * Carbon/CarbonUtils.m: Updated include location of FoundationSPI.h.
2816         (getNSAutoreleasePoolCount): Use objc_autoreleasePoolPush/Pop.
2817         (WebInitForCarbon): Use objc_autoreleasePoolPush/Pop instead of NSAutoreleasePool object.
2818         (PoolCleaner): Ditto.
2819
2820         * History/WebHistory.mm:
2821         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
2822         Use @autoreleasepool instead of NSAutoreleasePool object. No need to do the "drain pool only
2823         every 50 times"; the -[WebHistory loadFromURL] family of methods were once used by Safari, and
2824         now hardly used if at all.
2825         * WebView/WebView.mm:
2826         (-[WebView rectsForTextMatches]): Ditto.
2827
2828 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2829
2830         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
2831         https://bugs.webkit.org/show_bug.cgi?id=186442
2832         <rdar://problem/40879364>
2833
2834         Reviewed by Tim Horton.
2835
2836         * Configurations/FeatureDefines.xcconfig:
2837
2838 2018-06-08  Aditya Keerthi  <akeerthi@apple.com>
2839
2840         [Datalist] Allow TextFieldInputType to show and hide suggestions
2841         https://bugs.webkit.org/show_bug.cgi?id=186151
2842
2843         Reviewed by Tim Horton.
2844
2845         * WebCoreSupport/WebChromeClient.h:
2846         * WebCoreSupport/WebChromeClient.mm:
2847         (WebChromeClient::createDataListSuggestionPicker):
2848
2849 2018-06-07  Chris Dumez  <cdumez@apple.com>
2850
2851         Add base class to get WeakPtrFactory member and avoid some boilerplate code
2852         https://bugs.webkit.org/show_bug.cgi?id=186407
2853
2854         Reviewed by Brent Fulgham.
2855
2856         Add CanMakeWeakPtr base class to get WeakPtrFactory member and its getter, in
2857         order to avoid some boilerplate code in every class needing a WeakPtrFactory.
2858         This also gets rid of old-style createWeakPtr() methods in favor of the newer
2859         makeWeakPtr().
2860
2861         * WebCoreSupport/WebEditorClient.h:
2862         * WebCoreSupport/WebEditorClient.mm:
2863         (WebEditorClient::requestCandidatesForSelection):
2864
2865 2018-06-05  Chris Dumez  <cdumez@apple.com>
2866
2867         Regression(r232082): Websites get loaded inside of Messages App chat transcript
2868         https://bugs.webkit.org/show_bug.cgi?id=186331
2869         <rdar://problem/40735446>
2870
2871         Reviewed by Darin Adler.
2872
2873         r232082 made it so that if the client implements decidePolicyForMIMEType / decidePolicyForNavigationAction
2874         but does not call use / ignore on the listener, then we would do "use" by default.
2875         The intention was to restore pre-AsyncPolicyDelegates behavior and unbreak Box.app. However,
2876         the pre-AsyncPolicyDelegates behavior was only to "use" by default for decidePolicyForMIMEType,
2877         not decidePolicyForNavigationAction. Doing "use" by default for decidePolicyForNavigationAction
2878         is new behavior and it breaks Messages.app. This patch updates r232082 so that we now do call
2879         "use" by default on the listener for decidePolicyForMIMEType and "ignore" by default for other
2880         policy decisions. This should restore pre-AsyncPolicyDelegates behavior. This fixes Messages.app
2881         and Box.app is still working properly.
2882
2883         * WebCoreSupport/WebFrameLoaderClient.h:
2884         * WebCoreSupport/WebFrameLoaderClient.mm:
2885         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
2886         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2887         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2888         (WebFrameLoaderClient::dispatchWillSubmitForm):
2889         (WebFrameLoaderClient::setUpPolicyListener):
2890         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]):
2891         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]):
2892         (-[WebFramePolicyListener dealloc]):
2893         (-[WebFramePolicyListener initWithFrame:policyFunction:]): Deleted.
2894         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]): Deleted.
2895
2896 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2897
2898         Adjust compile and runtime flags to match shippable state of features
2899         https://bugs.webkit.org/show_bug.cgi?id=186319
2900         <rdar://problem/40352045>
2901
2902         Reviewed by Maciej Stachowiak, Jon Lee, and others.
2903
2904         * Configurations/DebugRelease.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
2905         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
2906         * Configurations/FeatureDefines.xcconfig: Update to match WebKit definition of
2907         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
2908         Cocoa builds.
2909
2910 2018-06-05  Timothy Hatcher  <timothy@apple.com>
2911
2912         Clean up LocalDefaultSystemAppearance and prefers-dark-interface media query
2913
2914         https://bugs.webkit.org/show_bug.cgi?id=186323
2915         rdar://problem/38382252
2916
2917         Reviewed by Tim Horton.
2918
2919         * WebView/WebView.mm:
2920         (-[WebView _defaultAppearance]):
2921
2922 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
2923
2924         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
2925         https://bugs.webkit.org/show_bug.cgi?id=186286
2926         <rdar://problem/40782992>
2927
2928         Reviewed by Dan Bernstein.
2929
2930         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
2931         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
2932         change this flag when preparing for a production release.
2933
2934         * Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to determine
2935         whether experimental features should be enabled, and use it to properly define the
2936         feature flag.
2937
2938 2018-06-03  Darin Adler  <darin@apple.com>
2939
2940         Simplify and remove some unused video element code (helpful for ARC-compatibility)
2941         https://bugs.webkit.org/show_bug.cgi?id=186258
2942
2943         Reviewed by Daniel Bates.
2944
2945         * WebView/WebVideoFullscreenController.h: Removed some unneeded includes and
2946         forward declarations. Removed methods that don't need to be public.
2947
2948         * WebView/WebVideoFullscreenController.mm: Added additional includes. Removed
2949         #if COMPILER(CLANG) since that's all we use on Mac. Moved fields into an
2950         unnamed category in here and also replaced the HUDWindowControllerDelegate
2951         with the unnamed category. Removed unused NSWindow category defining the
2952         isOnActiveSpace, which is not called anywhere in this file at this time.
2953         (-[WebVideoFullscreenController setupVideoOverlay:]): Deleted. Moved the code
2954         into setVideoElement.
2955         (-[WebVideoFullscreenController windowDidLoad]): Slightly rearranged the code
2956         and removed unneeded typecast.
2957         (-[WebVideoFullscreenController videoElement]): Updated to not rely on a
2958         using statement at the top of the file.
2959         (-[WebVideoFullscreenController setVideoElement:]): Added a comment about
2960         the many side effects and special considerations that this method that sounds
2961         like a setter has. Updated code to use the new
2962         MediaPlayer::objCAVFoundationAVPlayer function instead of the old
2963         HTMLVideoElement::platformMedia function. Also straightened out the logic a
2964         bit and added some FIXME comments about small problems noticed but not fixed.
2965         (-[WebVideoFullscreenController delegate]): Deleted. Was never called.
2966         (-[WebVideoFullscreenController setDelegate:]): Deleted. Was never called.
2967         (-[WebVideoFullscreenController windowDidExitFullscreen]): Removed unneeded
2968         typecast. Removed call to updatePowerAssertions method.
2969         (-[WebVideoFullscreenController windowDidEnterFullscreen]): Removed call to
2970         updatePowerAssertions method.
2971         (-[WebVideoFullscreenController updatePowerAssertions]): Deleted. This method
2972         set _displaySleepEnabler to nullptr, but nothing was ever setting it to anything
2973         else, so this was dead code that did nothing.
2974         (-[WebVideoFullscreenController rateChanged:]): Removed call to
2975         updatePowerAssertions method.
2976
2977 2018-06-04  Chris Dumez  <cdumez@apple.com>
2978
2979         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
2980         https://bugs.webkit.org/show_bug.cgi?id=186287
2981         <rdar://problem/40783352>
2982
2983         Reviewed by Youenn Fablet.
2984
2985         * WebView/WebPreferenceKeysPrivate.h:
2986         * WebView/WebPreferences.mm:
2987         (+[WebPreferences initialize]):
2988         (-[WebPreferences crossOriginWindowPolicySupportEnabled]):
2989         (-[WebPreferences setCrossOriginWindowPolicySupportEnabled:]):
2990         * WebView/WebPreferencesPrivate.h:
2991         * WebView/WebView.mm:
2992         (-[WebView _preferencesChanged:]):
2993
2994 2018-06-02  Darin Adler  <darin@apple.com>
2995
2996         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
2997         https://bugs.webkit.org/show_bug.cgi?id=186227
2998
2999         Reviewed by Dan Bernstein.
3000
3001         * Misc/WebKitErrors.m:
3002         (+[NSError _registerWebKitErrors]): Use @autoreleasepool instead of NSAutoreleasePool.
3003         * Plugins/WebPluginDatabase.mm:
3004         (-[WebPluginDatabase refresh]): Ditto.
3005         * WebCoreSupport/WebChromeClient.mm:
3006         (WebChromeClient::setStatusbarText): Ditto.
3007
3008 2018-06-01  Chris Dumez  <cdumez@apple.com>
3009
3010         REGRESSION (r231456): Colloquy is broken
3011         https://bugs.webkit.org/show_bug.cgi?id=186197
3012         <rdar://problem/40722960>
3013
3014         Reviewed by Timothy Hatcher.
3015
3016         Restore pre-r231456 behavior for Colloquy app so that it works again.
3017
3018         * WebView/WebView.mm:
3019         (-[WebView _needsFrameNameFallbackToIdQuirk]):
3020         (-[WebView _preferencesChanged:]):
3021
3022 2018-05-30  Yusuke Suzuki  <utatane.tea@gmail.com>
3023
3024         [JSC] Pass VM& parameter as much as possible
3025         https://bugs.webkit.org/show_bug.cgi?id=186085
3026
3027         Reviewed by Saam Barati.
3028
3029         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3030         (WebKit::NetscapePluginInstanceProxy::invoke):
3031
3032 2018-05-30  Daniel Bates  <dabates@apple.com>
3033
3034         NavigationAction does not need to hold initiating DOM Event
3035         https://bugs.webkit.org/show_bug.cgi?id=185958
3036         <rdar://problem/40531539>
3037
3038         Reviewed by Simon Fraser.
3039
3040         Write in terms of NavigationAction::{keyStateEventData, mouseEventDataForFirstMouseEvent}().
3041
3042         * WebCoreSupport/WebFrameLoaderClient.mm:
3043         (WebFrameLoaderClient::actionDictionary const):
3044         (findMouseEvent): Deleted.
3045
3046 2018-05-27  Dan Bernstein  <mitz@apple.com>
3047
3048         Reverted the changes made for https://webkit.org/b/186016
3049
3050         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
3051
3052
3053 2018-05-27  David Kilzer  <ddkilzer@apple.com>
3054
3055         [iOS] Fix warnings about leaks found by clang static analyzer
3056         <https://webkit.org/b/186009>
3057         <rdar://problem/40574267>
3058
3059         Reviewed by Daniel Bates.
3060
3061         * WebView/WebHTMLView.mm:
3062         (-[WebHTMLView doCommandBySelector:]): Fix use of an
3063         uninitialized boolean variable (`eventWasHandled`) that only
3064         happened on iOS.
3065
3066 2018-05-27  Dan Bernstein  <mitz@apple.com>
3067
3068         [Cocoa] Avoid importing directly from subumbrella frameworks
3069         https://bugs.webkit.org/show_bug.cgi?id=186016
3070
3071         Reviewed by Sam Weinig.
3072
3073         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
3074         * Carbon/CarbonWindowAdapter.mm: Ditto.
3075         * Carbon/CarbonWindowFrame.m: Ditto.
3076         * Carbon/HIViewAdapter.h: Ditto.
3077         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from OTHER_CFLAGS and
3078           OTHER_CPLUSPLUSFLAGS.
3079         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
3080         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
3081         * WebView/WebPDFView.h: Ditto.
3082
3083 2018-05-27  Sam Weinig  <sam@webkit.org>
3084
3085         Modernize RenderStyleConstants.h - Part 3
3086         https://bugs.webkit.org/show_bug.cgi?id=186015
3087
3088         Reviewed by Yusuke Suzuki.
3089
3090         * WebView/WebView.mm:
3091         (-[WebView updateTextTouchBar]):
3092         Update for new enum name.
3093
3094 2018-05-25  Chris Dumez  <cdumez@apple.com>
3095
3096         Minor ApplicationCacheStorage clean up
3097         https://bugs.webkit.org/show_bug.cgi?id=185984
3098
3099         Reviewed by Youenn Fablet.
3100
3101         * WebCoreSupport/WebApplicationCache.mm:
3102         (+[WebApplicationCache originsWithCache]):
3103
3104 2018-05-25  David Kilzer  <ddkilzer@apple.com>
3105
3106         Fix issues with -dealloc methods found by clang static analyzer
3107         <https://webkit.org/b/185887>
3108
3109         Reviewed by Joseph Pecoraro.
3110
3111         * WebView/WebView.mm:
3112         (-[WebUITextIndicatorData dealloc]):
3113         - Move method implementation from (WebUITextIndicatorInternal)
3114           category to the main category since this is public API.  This
3115           fixes the false positive warning about a missing -dealloc
3116           method.
3117
3118 2018-05-24  Sam Weinig  <sam@webkit.org>
3119
3120         Modernize RenderStyleConstants.h - Part 2
3121         https://bugs.webkit.org/show_bug.cgi?id=185901
3122
3123         Reviewed by Simon Fraser.
3124
3125         * WebView/WebHTMLRepresentation.mm:
3126         (searchForLabelsBeforeElement):
3127         * WebView/WebView.mm:
3128         (nsTextAlignmentFromRenderStyle):
3129         Update for new enum names.
3130
3131 2018-05-22  Chris Dumez  <cdumez@apple.com>
3132
3133         Regression(AsyncPolicyDelegates): Box.app login Window is blank
3134         https://bugs.webkit.org/show_bug.cgi?id=185832
3135         <rdar://problem/40307871>
3136
3137         Reviewed by Geoffrey Garen.
3138
3139         We used to have a bug where where we would fail to wait for the policy decision for
3140         the navigation response from the client and the load would keep going, racing with
3141         the client's policy decision. If the client did not respond in time, the behavior
3142         would be the same as "Use" policy action.
3143
3144         Box.app fails to make any policy decision in its decidePolicyForMIMEType delegate
3145         but the load happened to proceed anyway due to our bug. Now that we've fixed the
3146         WebKit bug, however, the load would hang because the completion handler for the
3147         decidePolicyForNavigationResponse would never get called.
3148
3149         To work around the issue, I made the policy listener weak on the WebFrameLoaderClient
3150         instead of retaining it. If the policy listener object gets destroyed because getting
3151         resolved, we now use "Use" policy action in its dealloc function to maintain previous
3152         behavior.
3153
3154         * WebCoreSupport/WebFrameLoaderClient.h:
3155         * WebCoreSupport/WebFrameLoaderClient.mm:
3156         (WebFrameLoaderClient::cancelPolicyCheck):
3157         (WebFrameLoaderClient::setUpPolicyListener):
3158         (-[WebFramePolicyListener dealloc]):
3159
3160 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
3161
3162         Unreviewed, rolling out r232052.
3163
3164         Breaks internal builds.
3165
3166         Reverted changeset:
3167
3168         "Use more C++17"
3169         https://bugs.webkit.org/show_bug.cgi?id=185176
3170         https://trac.webkit.org/changeset/232052
3171
3172 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
3173
3174         Use more C++17
3175         https://bugs.webkit.org/show_bug.cgi?id=185176
3176
3177         Reviewed by JF Bastien.
3178
3179         * Configurations/Base.xcconfig:
3180         * Configurations/WebKitLegacy.xcconfig:
3181
3182 2018-05-21  Chris Nardi  <cnardi@chromium.org>
3183
3184         Remove dead exception in MediaList.appendMedium
3185         https://bugs.webkit.org/show_bug.cgi?id=185278
3186
3187         Reviewed by Chris Dumez.
3188
3189         Remove code pertaining to an exception being thrown by appendMedium().
3190
3191         * DOM/DOMMediaList.mm:
3192         (-[DOMMediaList appendMedium:]):
3193
3194 2018-05-21  Jer Noble  <jer.noble@apple.com>
3195
3196         Complete fix for enabling modern EME by default
3197         https://bugs.webkit.org/show_bug.cgi?id=185770
3198         <rdar://problem/40368220>
3199
3200         Reviewed by Eric Carlson.
3201
3202         * Configurations/FeatureDefines.xcconfig:
3203
3204 2018-05-21  Antti Koivisto  <antti@apple.com>
3205
3206         WebView._preferencesChanged should apply colorFilterEnabled preference before parsing user stylesheet
3207         https://bugs.webkit.org/show_bug.cgi?id=185815
3208         <rdar://problem/40310069>
3209
3210         Reviewed by Simon Fraser.
3211
3212         User stylesheet parsing may depend on the colorFilterEnabled preference.
3213
3214         * WebView/WebView.mm:
3215         (-[WebView _preferencesChanged:]):
3216
3217 2018-05-18  Commit Queue  <commit-queue@webkit.org>
3218
3219         Unreviewed, rolling out r231982.
3220         https://bugs.webkit.org/show_bug.cgi?id=185793
3221
3222         Caused layout test failures (Requested by realdawei on
3223         #webkit).
3224
3225         Reverted changeset:
3226
3227         "Complete fix for enabling modern EME by default"
3228         https://bugs.webkit.org/show_bug.cgi?id=185770
3229         https://trac.webkit.org/changeset/231982
3230
3231 2018-05-18  Jer Noble  <jer.noble@apple.com>
3232
3233         Complete fix for enabling modern EME by default
3234         https://bugs.webkit.org/show_bug.cgi?id=185770
3235         <rdar://problem/40368220>
3236
3237         Reviewed by Eric Carlson.
3238
3239         * Configurations/FeatureDefines.xcconfig:
3240
3241 2018-05-18  Chris Dumez  <cdumez@apple.com>
3242
3243         Avoid keeping the frame alive when ref'ing a WindowProxy
3244         https://bugs.webkit.org/show_bug.cgi?id=185737
3245         <rdar://problem/40004666>
3246
3247         Reviewed by Sam Weinig.
3248
3249         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3250         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3251
3252 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
3253
3254         Add support for Intl NumberFormat formatToParts
3255         https://bugs.webkit.org/show_bug.cgi?id=185375
3256
3257         Reviewed by Yusuke Suzuki.
3258
3259         Add flag for NumberFormat formatToParts.
3260
3261         * Configurations/FeatureDefines.xcconfig:
3262
3263 2018-05-16  Chris Nardi  <cnardi@chromium.org>
3264
3265         Fixup after r231849: Do not mark Mac API methods as deprecated
3266         https://bugs.webkit.org/show_bug.cgi?id=185684
3267
3268         Reviewed by Darin Adler.
3269
3270         Do not mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
3271         as the entire class is already marked as deprecated, so it is unnecessary.
3272
3273         * DOM/DOMDocument.h:
3274
3275 2018-05-16  Chris Nardi  <cnardi@chromium.org>
3276
3277         Remove Document#selectedStylesheetSet/preferredStylesheetSet
3278         https://bugs.webkit.org/show_bug.cgi?id=185381
3279
3280         Reviewed by Darin Adler.
3281
3282         Mark API methods for Document#selectedStylesheetSet/preferredStylesheetSet as deprecated
3283         and make them do nothing.
3284
3285         * DOM/DOMDocument.h:
3286         * DOM/DOMDocument.mm:
3287         (-[DOMDocument preferredStylesheetSet]):
3288         (-[DOMDocument selectedStylesheetSet]):
3289         (-[DOMDocument setSelectedStylesheetSet:]):
3290
3291 2018-05-15  Antoine Quint  <graouts@apple.com>
3292
3293         [Web Animations] Expose Web Animations CSS integration as an experimental feature
3294         https://bugs.webkit.org/show_bug.cgi?id=185647
3295
3296         Reviewed by Dean Jackson.
3297
3298         Rename the Web Animations CSS integration flag.
3299
3300         * WebView/WebPreferenceKeysPrivate.h:
3301         * WebView/WebPreferences.mm:
3302         (+[WebPreferences initialize]):
3303         (-[WebPreferences webAnimationsCSSIntegrationEnabled]):
3304         (-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]):
3305         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]): Deleted.
3306         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]): Deleted.
3307         * WebView/WebPreferencesPrivate.h:
3308         * WebView/WebView.mm:
3309         (-[WebView _preferencesChanged:]):
3310
3311 2018-05-14  Daniel Bates  <dabates@apple.com>
3312
3313         Fix the Apple Internal build
3314
3315         See <rdar://problem/40237873> for more details.
3316
3317         * WebView/WebFullScreenController.mm:
3318         (-[WebFullScreenController enterFullScreen:]):
3319         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3320         (-[WebFullScreenController exitFullScreen]):
3321         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3322         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3323         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3324
3325 2018-05-11  Timothy Hatcher  <timothy@apple.com>
3326
3327         WebHTMLView is not setting aside subviews when drawing.
3328
3329         https://bugs.webkit.org/show_bug.cgi?id=185561
3330         rdar://problem/40172894
3331
3332         Reviewed by Simon Fraser.
3333
3334         Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.
3335
3336         * WebView/WebHTMLView.mm:
3337         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.
3338
3339 2018-05-07  Daniel Bates  <dabates@apple.com>
3340
3341         Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
3342         https://bugs.webkit.org/show_bug.cgi?id=185170
3343
3344         Reviewed by Per Arne Vollan.
3345
3346         * Misc/WebCache.mm:
3347         (+[WebCache empty]):
3348
3349 2018-05-04  Timothy Hatcher  <timothy@apple.com>
3350
3351         Deprecate legacy WebView and friends
3352         https://bugs.webkit.org/show_bug.cgi?id=185279
3353         rdar://problem/33268700
3354
3355         Reviewed by Tim Horton.
3356
3357         Added deprecation macros to all the classes, extern strings, and enums.
3358
3359         * Configurations/WebKitLegacy.xcconfig:
3360         Added BUILDING_WEBKIT define to disable the deprecation macros.
3361         * DOM/DOMAbstractView.h:
3362         * DOM/DOMAttr.h:
3363         * DOM/DOMBlob.h:
3364         * DOM/DOMCDATASection.h:
3365         * DOM/DOMCSSCharsetRule.h:
3366         * DOM/DOMCSSFontFaceRule.h:
3367         * DOM/DOMCSSImportRule.h:
3368         * DOM/DOMCSSMediaRule.h:
3369         * DOM/DOMCSSPageRule.h:
3370         * DOM/DOMCSSPrimitiveValue.h:
3371         * DOM/DOMCSSRule.h:
3372         * DOM/DOMCSSRuleList.h:
3373         * DOM/DOMCSSStyleDeclaration.h:
3374         * DOM/DOMCSSStyleRule.h:
3375         * DOM/DOMCSSStyleSheet.h:
3376         * DOM/DOMCSSUnknownRule.h:
3377         * DOM/DOMCSSValue.h:
3378         * DOM/DOMCSSValueList.h:
3379         * DOM/DOMCharacterData.h:
3380         * DOM/DOMComment.h:
3381         * DOM/DOMCounter.h:
3382         * DOM/DOMDocument.h:
3383         * DOM/DOMDocumentFragment.h:
3384         * DOM/DOMDocumentType.h:
3385         * DOM/DOMElement.h:
3386         * DOM/DOMEntity.h:
3387         * DOM/DOMEntityReference.h:
3388         * DOM/DOMEvent.h:
3389         * DOM/DOMEventException.h:
3390         * DOM/DOMEventListener.h:
3391         * DOM/DOMEventTarget.h:
3392         * DOM/DOMException.h:
3393         * DOM/DOMFile.h:
3394         * DOM/DOMFileList.h:
3395         * DOM/DOMHTMLAnchorElement.h:
3396         * DOM/DOMHTMLAppletElement.h:
3397         * DOM/DOMHTMLAreaElement.h:
3398         * DOM/DOMHTMLBRElement.h:
3399         * DOM/DOMHTMLBaseElement.h:
3400         * DOM/DOMHTMLBaseFontElement.h:
3401         * DOM/DOMHTMLBodyElement.h:
3402         * DOM/DOMHTMLButtonElement.h:
3403         * DOM/DOMHTMLCanvasElement.h:
3404         * DOM/DOMHTMLCollection.h:
3405         * DOM/DOMHTMLDListElement.h:
3406         * DOM/DOMHTMLDirectoryElement.h:
3407         * DOM/DOMHTMLDivElement.h:
3408         * DOM/DOMHTMLDocument.h:
3409         * DOM/DOMHTMLElement.h:
3410         * DOM/DOMHTMLEmbedElement.h:
3411         * DOM/DOMHTMLFieldSetElement.h:
3412         * DOM/DOMHTMLFontElement.h:
3413         * DOM/DOMHTMLFormElement.h:
3414         * DOM/DOMHTMLFrameElement.h:
3415         * DOM/DOMHTMLFrameSetElement.h:
3416         * DOM/DOMHTMLHRElement.h:
3417         * DOM/DOMHTMLHeadElement.h:
3418         * DOM/DOMHTMLHeadingElement.h:
3419         * DOM/DOMHTMLHtmlElement.h:
3420         * DOM/DOMHTMLIFrameElement.h:
3421         * DOM/DOMHTMLImageElement.h:
3422         * DOM/DOMHTMLInputElement.h:
3423         * DOM/DOMHTMLLIElement.h:
3424         * DOM/DOMHTMLLabelElement.h:
3425         * DOM/DOMHTMLLegendElement.h:
3426         * DOM/DOMHTMLLinkElement.h:
3427         * DOM/DOMHTMLMapElement.h:
3428         * DOM/DOMHTMLMarqueeElement.h:
3429         * DOM/DOMHTMLMediaElement.h:
3430         * DOM/DOMHTMLMenuElement.h:
3431         * DOM/DOMHTMLMetaElement.h:
3432         * DOM/DOMHTMLModElement.h:
3433         * DOM/DOMHTMLOListElement.h:
3434         * DOM/DOMHTMLObjectElement.h:
3435         * DOM/DOMHTMLOptGroupElement.h:
3436         * DOM/DOMHTMLOptionElement.h:
3437         * DOM/DOMHTMLOptionsCollection.h:
3438         * DOM/DOMHTMLParagraphElement.h:
3439         * DOM/DOMHTMLParamElement.h:
3440         * DOM/DOMHTMLPreElement.h:
3441         * DOM/DOMHTMLQuoteElement.h:
3442         * DOM/DOMHTMLScriptElement.h:
3443         * DOM/DOMHTMLSelectElement.h:
3444         * DOM/DOMHTMLStyleElement.h:
3445         * DOM/DOMHTMLTableCaptionElement.h:
3446         * DOM/DOMHTMLTableCellElement.h:
3447         * DOM/DOMHTMLTableColElement.h:
3448         * DOM/DOMHTMLTableElement.h:
3449         * DOM/DOMHTMLTableRowElement.h:
3450         * DOM/DOMHTMLTableSectionElement.h:
3451         * DOM/DOMHTMLTextAreaElement.h:
3452         * DOM/DOMHTMLTitleElement.h:
3453         * DOM/DOMHTMLUListElement.h:
3454         * DOM/DOMHTMLVideoElement.h:
3455         * DOM/DOMImplementation.h:
3456         * DOM/DOMKeyboardEvent.h:
3457         * DOM/DOMMediaError.h:
3458         * DOM/DOMMediaList.h:
3459         * DOM/DOMMouseEvent.h:
3460         * DOM/DOMMutationEvent.h:
3461         * DOM/DOMNamedNodeMap.h:
3462         * DOM/DOMNode.h:
3463         * DOM/DOMNodeFilter.h:
3464         * DOM/DOMNodeIterator.h:
3465         * DOM/DOMNodeList.h:
3466         * DOM/DOMObject.h:
3467         * DOM/DOMOverflowEvent.h:
3468         * DOM/DOMProcessingInstruction.h:
3469         * DOM/DOMProgressEvent.h:
3470         * DOM/DOMRGBColor.h:
3471         * DOM/DOMRange.h:
3472         * DOM/DOMRangeException.h:
3473         * DOM/DOMRect.h:
3474         * DOM/DOMStyleSheet.h:
3475         * DOM/DOMStyleSheetList.h:
3476         * DOM/DOMText.h:
3477         * DOM/DOMTextEvent.h:
3478         * DOM/DOMTimeRanges.h:
3479         * DOM/DOMTokenList.h:
3480         * DOM/DOMTreeWalker.h:
3481         * DOM/DOMUIEvent.h:
3482         * DOM/DOMWheelEvent.h:
3483         * DOM/DOMXPathException.h:
3484         * DOM/DOMXPathExpression.h:
3485         * DOM/DOMXPathNSResolver.h:
3486         * DOM/DOMXPathResult.h:
3487         * History/WebBackForwardList.h:
3488         * History/WebHistory.h:
3489         * History/WebHistoryItem.h:
3490         * Misc/WebDownload.h:
3491         * Misc/WebKitErrors.h:
3492         * Plugins/WebPluginViewFactory.h:
3493         * WebView/WebArchive.h:
3494         * WebView/WebDataSource.h:
3495         * WebView/WebDocument.h:
3496         * WebView/WebEditingDelegate.h:
3497         * WebView/WebFormDelegate.h:
3498         * WebView/WebFrame.h:
3499         * WebView/WebFrameLoadDelegate.h:
3500         * WebView/WebFrameView.h:
3501         * WebView/WebPolicyDelegate.h:
3502         * WebView/WebPreferences.h:
3503         * WebView/WebPreferencesPrivate.h:
3504         * WebView/WebResourceLoadDelegate.h:
3505         * WebView/WebUIDelegate.h:
3506         * WebView/WebUIDelegatePrivate.h:
3507         * WebView/WebView.h:
3508         * WebView/WebViewPrivate.h:
3509         * postprocess-headers.sh:
3510         Remove step that converts WEBKIT macros to NS macros.
3511         Change it to just remove the macros on iOS builds.
3512
3513 2018-05-01  Eric Carlson  <eric.carlson@apple.com>
3514
3515         [MediaStream] remove WK1 support
3516         https://bugs.webkit.org/show_bug.cgi?id=185136
3517
3518         Reviewed by Youenn Fablet.
3519
3520         * WebCoreSupport/WebUserMediaClient.h: Removed.
3521         * WebCoreSupport/WebUserMediaClient.mm: Removed.
3522         * WebView/WebView.mm:
3523         (-[WebView _commonInitializationWithFrameName:groupName:]):
3524         (-[WebView _preferencesChanged:]):
3525         (-[WebView _setUserMediaClient:]): Deleted.
3526         (-[WebView _userMediaClient]): Deleted.
3527         * WebView/WebViewData.h:
3528         * WebView/WebViewPrivate.h:
3529
3530 2018-05-01  Oleksandr Skachkov  <gskachkov@gmail.com>
3531
3532         WebAssembly: add support for stream APIs - JavaScript API
3533         https://bugs.webkit.org/show_bug.cgi?id=183442
3534
3535         Reviewed by Yusuke Suzuki and JF Bastien.
3536
3537         Add WEBASSEMBLY_STREAMINNG_API feature flag
3538
3539         * Configurations/FeatureDefines.xcconfig:
3540
3541 2018-04-30  JF Bastien  <jfbastien@apple.com>
3542
3543         Use some C++17 features
3544         https://bugs.webkit.org/show_bug.cgi?id=185135
3545
3546         Reviewed by Alex Christensen.
3547
3548         * Configurations/WebKitLegacy.xcconfig:
3549
3550 2018-04-27  Chris Dumez  <cdumez@apple.com>
3551
3552         Use WindowProxy instead of DOMWindow in our IDL
3553         https://bugs.webkit.org/show_bug.cgi?id=185022
3554
3555         Reviewed by Sam Weinig.
3556
3557         * DOM/DOMAbstractView.mm:
3558         (kit):
3559         (toWindowProxy):
3560         * DOM/DOMAbstractViewInternal.h:
3561         * DOM/DOMDocument.mm:
3562         (-[DOMDocument defaultView]):
3563         (-[DOMDocument getComputedStyle:pseudoElement:]):
3564         (-[DOMDocument getMatchedCSSRules:pseudoElement:authorOnly:]):
3565         * DOM/DOMHTMLFrameElement.mm:
3566         (-[DOMHTMLFrameElement contentWindow]):
3567         * DOM/DOMHTMLIFrameElement.mm:
3568         (-[DOMHTMLIFrameElement contentWindow]):
3569         * DOM/DOMKeyboardEvent.mm:
3570         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
3571         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:location:ctrlKey:altKey:shiftKey:metaKey:]):
3572         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:altGraphKey:]):
3573         (-[DOMKeyboardEvent initKeyboardEvent:canBubble:cancelable:view:keyIdentifier:keyLocation:ctrlKey:altKey:shiftKey:metaKey:]):
3574         * DOM/DOMMouseEvent.mm:
3575         (-[DOMMouseEvent initMouseEvent:canBubble:cancelable:view:detail:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:button:relatedTarget:]):
3576         * DOM/DOMTextEvent.mm:
3577         (-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):
3578         * DOM/DOMUIEvent.mm:
3579         (-[DOMUIEvent view]):
3580         (-[DOMUIEvent initUIEvent:canBubble:cancelable:view:detail:]):
3581         * DOM/DOMWheelEvent.mm:
3582         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
3583
3584 2018-04-26  Simon Fraser  <simon.fraser@apple.com>
3585
3586         Implement rendering support for the color-filter CSS property
3587         https://bugs.webkit.org/show_bug.cgi?id=185047
3588         rdar://problem/39664967
3589
3590         Reviewed by Tim Horton.
3591         
3592         The body background should reflect the filtered color.
3593
3594         * WebView/WebFrame.mm:
3595         (-[WebFrame _bodyBackgroundColor]):
3596         * WebView/WebView.mm:
3597         (-[WebView updateTextTouchBar]): No logic change, just cleanup.
3598
3599 2018-04-26  Jer Noble  <jer.noble@apple.com>
3600
3601         WK_COCOA_TOUCH all the things.
3602         https://bugs.webkit.org/show_bug.cgi?id=185006
3603
3604         Reviewed by Tim Horton.
3605
3606         * Configurations/WebKitLegacy.xcconfig:
3607
3608 2018-04-26  Daniel Bates  <dabates@apple.com>
3609
3610         ASSERTION FAILED: ASSERT(!containsImage || MIMETypeRegistry::isSupportedImageResourceMIMEType([resource MIMEType])) in -[NSPasteboard(WebExtras) _web_writePromisedRTFDFromArchive:containsImage:]
3611         https://bugs.webkit.org/show_bug.cgi?id=184161
3612         <rdar://problem/39051645>
3613
3614         Reviewed by Dan Bernstein.
3615
3616         Fixes an assertion failure when quitting an app that uses a Legacy WebKit web view after dragging-and-
3617         dropping a PDF embedded using an HTML image element into the same web view.
3618
3619         When performing a drag-and-drop of a PDF document image (WebCore::PDFDocumentImage) we create a WebArchive
3620         from the main frame's WebHTMLView and promise AppKit that we will provide a Rich Text Format (RTF) document
3621         from this archive if needed. For some reason, on app termination AppKit requests that the WebHTMLView
3622         fulfill its RTF document promise for the WebArchive created at the start of the drag operation. To do this,
3623         we need to extract the image resource from the Web Archive. Currently we query MIMETypeRegistry::isSupportedImageResourceMIMEType()
3624         to see if the contained image is one that we can handle. However MIMETypeRegistry::isSupportedImageResourceMIMEType()
3625         only returns true if WebKit supports creating an image document for the specified MIME type. Disregarding
3626         the iOS motivated setting Settings::useImageDocumentForSubframePDF, PDFs and PostScripts do not create an
3627         image document when navigated to directly. Since we can support dragging PDF document images we need to
3628         query if MIMETypeRegistry::isPDFOrPostScriptMIMEType() in addition to querying MIMETypeRegistry::isSupportedImageResourceMIMEType().
3629         We need to do both such queries before falling back to using the main resource of the Web Archive as
3630         the image. Otherwise, we will cause an assertion failure if the main resource of the Web Archive is
3631         not an image document.
3632
3633         * Misc/WebNSPasteboardExtras.mm:
3634         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
3635
3636 2018-04-26  Per Arne Vollan  <pvollan@apple.com>
3637
3638         Disable content filtering in minimal simulator mode
3639         https://bugs.webkit.org/show_bug.cgi?id=185027
3640         <rdar://problem/39736091>
3641
3642         Reviewed by Jer Noble.
3643
3644         * Configurations/FeatureDefines.xcconfig:
3645
3646 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
3647
3648         [INTL] Implement Intl.PluralRules
3649         https://bugs.webkit.org/show_bug.cgi?id=184312
3650
3651         Reviewed by JF Bastien.
3652
3653         Added Intl.PluralRules feature flag.
3654
3655         * Configurations/FeatureDefines.xcconfig:
3656
3657 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
3658
3659         Remove access to keychain from the WebContent process
3660         https://bugs.webkit.org/show_bug.cgi?id=184428
3661         <rdar://problem/13150903>
3662
3663         Reviewed by Brent Fulgham.
3664
3665         This patch does the followings:
3666         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
3667         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
3668         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
3669
3670         * WebCoreSupport/WebChromeClient.h:
3671         * WebCoreSupport/WebChromeClient.mm:
3672         (WebChromeClient::signedPublicKeyAndChallengeString const):
3673         * WebView/WebUIDelegatePrivate.h:
3674
3675 2018-04-24  Jer Noble  <jer.noble@apple.com>
3676
3677         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
3678         https://bugs.webkit.org/show_bug.cgi?id=184786
3679
3680         Reviewed by Tim Horton.
3681
3682         * Configurations/WebKitLegacy.xcconfig:
3683         * MigrateHeaders.make:
3684
3685 2018-04-23  Daniel Bates  <dabates@apple.com>
3686
3687         Implement Same-Site cookies
3688         https://bugs.webkit.org/show_bug.cgi?id=159464
3689         <rdar://problem/27196358>
3690
3691         Reviewed by Brent Fulgham.
3692
3693         Pass the Same-Site info through the strategy.
3694
3695         * WebCoreSupport/WebPlatformStrategies.h:
3696         * WebCoreSupport/WebPlatformStrategies.mm:
3697         (WebPlatformStrategies::cookiesForDOM):
3698         (WebPlatformStrategies::setCookiesFromDOM):
3699         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3700         (WebPlatformStrategies::getRawCookies):
3701
3702 2018-04-23  Zalan Bujtas  <zalan@apple.com>
3703
3704         [LayoutFormattingContext] Initial commit.
3705         https://bugs.webkit.org/show_bug.cgi?id=184896
3706
3707         Reviewed by Antti Koivisto.
3708
3709         * Configurations/FeatureDefines.xcconfig:
3710
3711 2018-04-23  Daniel Bates  <dabates@apple.com>
3712
3713         Implement Same-Site cookies
3714         https://bugs.webkit.org/show_bug.cgi?id=159464
3715         <rdar://problem/27196358>
3716
3717         Reviewed by Brent Fulgham.
3718
3719         Pass the Same-Site info through the strategy.
3720
3721         * WebCoreSupport/WebPlatformStrategies.h:
3722         * WebCoreSupport/WebPlatformStrategies.mm:
3723         (WebPlatformStrategies::cookiesForDOM):
3724         (WebPlatformStrategies::setCookiesFromDOM):
3725         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3726         (WebPlatformStrategies::getRawCookies):
3727
3728 2018-04-20  Timothy Hatcher  <timothy@apple.com>
3729
3730         NULL dereference crash sometimes under [super initWithCoder:] in WebView
3731
3732         https://bugs.webkit.org/show_bug.cgi?id=184851
3733         rdar://problem/39611236
3734
3735         Reviewed by Tim Horton.
3736
3737         * WebView/WebView.mm:
3738         (-[WebView _commonInitializationWithFrameName:groupName:]):
3739         (-[WebView effectiveAppearanceDidChange]):
3740         Added a null check and call the code later in initialization.
3741
3742 2018-04-20  Tim Horton  <timothy_horton@apple.com>
3743
3744         Adjust geolocation feature flag
3745         https://bugs.webkit.org/show_bug.cgi?id=184856
3746
3747         Reviewed by Wenson Hsieh.
3748
3749         * Configurations/FeatureDefines.xcconfig:
3750
3751 2018-04-18  Jer Noble  <jer.noble@apple.com>
3752
3753         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
3754         https://bugs.webkit.org/show_bug.cgi?id=184762
3755
3756         Reviewed by Dan Bernstein.
3757
3758         * Configurations/WebKitLegacy.xcconfig:
3759
3760 2018-04-20  Youenn Fablet  <youenn@apple.com>
3761
3762         Make PluginData cache its web visible plugins
3763         https://bugs.webkit.org/show_bug.cgi?id=184421
3764
3765         Reviewed by Chris Dumez.
3766
3767         * WebCoreSupport/WebPluginInfoProvider.h:
3768         * WebCoreSupport/WebPluginInfoProvider.mm:
3769         (WebPluginInfoProvider::pluginInfo):
3770         (WebPluginInfoProvider::webVisiblePluginInfo):
3771
3772 2018-04-19  Chris Dumez  <cdumez@apple.com>
3773
3774         Rename JSDOMWindowProxy to JSWindowProxy
3775         https://bugs.webkit.org/show_bug.cgi?id=184797
3776
3777         Reviewed by Sam Weinig.
3778
3779         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
3780
3781         * DOM/DOMUtility.mm:
3782         (createDOMWrapper):
3783         * WebView/WebFrame.mm:
3784         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3785
3786 2018-04-19  David Kilzer  <ddkilzer@apple.com>
3787
3788         Enable Objective-C weak references
3789         <https://webkit.org/b/184789>
3790         <rdar://problem/39571716>
3791
3792         Reviewed by Dan Bernstein.
3793
3794         * Configurations/Base.xcconfig:
3795         (CLANG_ENABLE_OBJC_WEAK): Enable.
3796
3797 2018-04-18  Chris Dumez  <cdumez@apple.com>
3798
3799         Rename WindowProxyController to WindowProxy
3800         https://bugs.webkit.org/show_bug.cgi?id=184756
3801
3802         Reviewed by Sam Weinig.
3803
3804         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
3805         needed use WindowProxyController type, which was a bit confusing.
3806
3807         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3808         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3809         * WebView/WebFrame.mm:
3810         (-[WebFrame _attachScriptDebugger]):
3811
3812 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
3813
3814         Unreviewed rollout of r230632. Regression in memory usage.
3815
3816         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
3817
3818         * WebView/WebPreferences.mm:
3819         (+[WebPreferences initialize]):
3820
3821 2018-04-17  Chris Dumez  <cdumez@apple.com>
3822
3823         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
3824         https://bugs.webkit.org/show_bug.cgi?id=184678
3825         <rdar://problem/39422122>
3826
3827         Reviewed by Alex Christensen.
3828
3829         Add new parameter to dispatchDecidePolicyForNavigationAction.
3830
3831         * WebCoreSupport/WebFrameLoaderClient.h:
3832         * WebCoreSupport/WebFrameLoaderClient.mm:
3833         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3834
3835 2018-04-13  Chris Dumez  <cdumez@apple.com>
3836
3837         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
3838         https://bugs.webkit.org/show_bug.cgi?id=184591
3839
3840         Reviewed by Sam Weinig.
3841
3842         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
3843         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
3844         This is work towards fixing Bug 184515.
3845
3846         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3847         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3848         * WebView/WebFrame.mm:
3849         (-[WebFrame _attachScriptDebugger]):
3850
3851 2018-04-12  Antoine Quint  <graouts@apple.com>
3852
3853         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
3854         https://bugs.webkit.org/show_bug.cgi?id=184569
3855         <rdar://problem/38671301>
3856
3857         Reviewed by Jon Lee.
3858
3859         * WebView/WebPreferences.mm:
3860
3861 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3862
3863         [WTF] Remove StaticLock
3864         https://bugs.webkit.org/show_bug.cgi?id=184332
3865
3866         Reviewed by Mark Lam.
3867
3868         * DOM/DOMInternal.mm:
3869         (getDOMWrapper):
3870         (addDOMWrapper):
3871         (removeDOMWrapper):
3872
3873 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
3874
3875         Failures from mach port reference handling should be fatal
3876         https://bugs.webkit.org/show_bug.cgi?id=184202
3877         <rdar://problem/37771114>
3878
3879         Reviewed by Anders Carlsson.
3880
3881         * Plugins/Hosted/NetscapePluginHostManager.mm:
3882         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
3883
3884 2018-04-03  Andy Estes  <aestes@apple.com>
3885
3886         [Mac] Prioritize file promises over filenames during drag and drop
3887         https://bugs.webkit.org/show_bug.cgi?id=184237
3888         <rdar://problem/38278076>
3889
3890         Reviewed by Wenson Hsieh.
3891
3892         * WebView/WebView.mm:
3893         (-[WebView performDragOperation:]):
3894
3895 2018-04-03  Chris Dumez  <cdumez@apple.com>
3896
3897         Drop MainFrame class
3898         https://bugs.webkit.org/show_bug.cgi?id=184191
3899
3900         Reviewed by Darin Adler.
3901
3902         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
3903         relationship between the Page and the MainFrame.
3904
3905         This is ground work for introducing LocalFrame / RemoteFrame concepts.
3906
3907         * WebCoreSupport/WebDragClient.mm:
3908         * WebCoreSupport/WebFrameLoaderClient.mm:
3909         * WebCoreSupport/WebInspectorClient.mm:
3910         * WebCoreSupport/WebPlatformStrategies.mm:
3911         * WebCoreSupport/WebPluginInfoProvider.mm:
3912         * WebView/WebFrame.mm:
3913         * WebView/WebFrameView.mm:
3914         * WebView/WebHTMLView.mm:
3915         * WebView/WebView.mm:
3916
3917 2018-04-02  Jer Noble  <jer.noble@apple.com>
3918
3919         Enable Legacy EME for all WebKit & WebKitLegacy clients
3920         https://bugs.webkit.org/show_bug.cgi?id=184018
3921         <rdar://problem/34887387>
3922
3923         Reviewed by Eric Carlson.
3924
3925         * WebView/WebPreferences.mm:
3926         (+[WebPreferences initialize]):
3927
3928 2018-03-29  JF Bastien  <jfbastien@apple.com>
3929
3930         Use Forward.h instead of forward-declaring WTF::String
3931         https://bugs.webkit.org/show_bug.cgi?id=184172
3932         <rdar://problem/39026146>
3933
3934         Reviewed by Yusuke Suzuki.
3935
3936         As part of #184164 I'm changing WTF::String, and the forward
3937         declarations are just wrong because I'm making it templated. We
3938         should use Forward.h anyways, so do that instead.
3939
3940         * WebView/WebScriptDebugger.h:
3941
3942 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
3943
3944         Protect against invalid mach ports returned by mach_port_request_notification
3945         https://bugs.webkit.org/show_bug.cgi?id=184106
3946         <rdar://problem/37865316>
3947
3948         Reviewed by Chris Dumez.
3949
3950         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3951         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
3952         and clean up if it experienced an error.
3953         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
3954
3955 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
3956
3957         Avoid uninitialized mach ports
3958         https://bugs.webkit.org/show_bug.cgi?id=184090
3959         <rdar://problem/37261129>
3960
3961         Reviewed by Chris Dumez.
3962
3963         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
3964         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
3965         there is a potential for us to try to use invalid ports.
3966
3967         We should always check return values, and ensure that the mach port variables we seek to initialize are
3968         kept in a valid state.
3969
3970         Reviewed by Chris Dumez.
3971
3972         * Plugins/Hosted/NetscapePluginHostManager.h:
3973         * Plugins/Hosted/NetscapePluginHostManager.mm:
3974         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
3975         port is passed to an API function.
3976         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
3977         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
3978         * Plugins/Hosted/NetscapePluginHostProxy.h:
3979         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3980         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
3981         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
3982         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
3983         (WKPCStatusText): Ditto.
3984         (WKPCLoadURL): Ditto.
3985         (WKPCCancelLoadURL): Ditto.
3986         (WKPCInvalidateRect): Ditto.
3987         (WKPCGetScriptableNPObjectReply): Ditto.
3988         (WKPCBooleanReply): Ditto.
3989         (WKPCBooleanAndDataReply): Ditto.
3990         (WKPCInstantiatePluginReply): Ditto.
3991         (WKPCGetWindowNPObject): Ditto.
3992         (WKPCGetPluginElementNPObject): Ditto.
3993         (WKPCForgetBrowserObject): Ditto.
3994         (WKPCEvaluate): Ditto.
3995         (WKPCGetStringIdentifier): Ditto.
3996         (WKPCGetIntIdentifier): Ditto.
3997         (WKPCInvoke): Ditto.
3998         (WKPCInvokeDefault): Ditto.
3999         (WKPCConstruct): Ditto.
4000         (WKPCGetProperty): Ditto.
4001         (WKPCSetProperty): Ditto.
4002         (WKPCRemoveProperty): Ditto.
4003         (WKPCHasProperty): Ditto.
4004         (WKPCHasMethod): Ditto.
4005         (WKPCIdentifierInfo): Ditto.
4006         (WKPCEnumerate): Ditto.
4007         (WKPCSetMenuBarVisible): Ditto.
4008         (WKPCSetFullscreenWindowIsShowing): Ditto.
4009         (WKPCSetModal): Ditto.
4010         (WKPCGetCookies): Ditto.
4011         (WKPCGetProxy): Ditto.
4012         (WKPCSetCookies): Ditto.
4013         (WKPCGetAuthenticationInfo): Ditto.
4014         (WKPCConvertPoint): Ditto.
4015         (WKPCLayerHostingModeChanged): Ditto.
4016         (WKPCSetException): Ditto.
4017
4018 2018-03-26  Tim Horton  <timothy_horton@apple.com>
4019
4020         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
4021         https://bugs.webkit.org/show_bug.cgi?id=184030
4022         <rdar://problem/38895281>
4023
4024         Reviewed by Dan Bernstein.
4025
4026         * Configurations/Base.xcconfig:
4027
4028 2018-03-26  Chris Dumez  <cdumez@apple.com>
4029
4030         Use SecurityOriginData more consistently in Service Worker code
4031         https://bugs.webkit.org/show_bug.cgi?id=183969
4032
4033         Reviewed by Darin Adler.
4034
4035         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
4036
4037         * Storage/WebDatabaseManager.mm:
4038         (-[WebDatabaseManager databasesWithOrigin:]):