[INTL] Implement Intl.PluralRules
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-04-26  Andy VanWagoner  <thetalecrafter@gmail.com>
2
3         [INTL] Implement Intl.PluralRules
4         https://bugs.webkit.org/show_bug.cgi?id=184312
5
6         Reviewed by JF Bastien.
7
8         Added Intl.PluralRules feature flag.
9
10         * Configurations/FeatureDefines.xcconfig:
11
12 2018-04-25  Jiewen Tan  <jiewen_tan@apple.com>
13
14         Remove access to keychain from the WebContent process
15         https://bugs.webkit.org/show_bug.cgi?id=184428
16         <rdar://problem/13150903>
17
18         Reviewed by Brent Fulgham.
19
20         This patch does the followings:
21         1. Added necessary support to move HTMLKeygenElement's operation from WebCore space to Client space.
22         2. Craft new SPI signedPublicKeyAndChallengeStringForWebView to supply HTMLKeygenElement with dummy data
23         such that DumpRenderTree tests will not modify the underlying key store (e.g., the macOS Keychain).
24
25         * WebCoreSupport/WebChromeClient.h:
26         * WebCoreSupport/WebChromeClient.mm:
27         (WebChromeClient::signedPublicKeyAndChallengeString const):
28         * WebView/WebUIDelegatePrivate.h:
29
30 2018-04-24  Jer Noble  <jer.noble@apple.com>
31
32         Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
33         https://bugs.webkit.org/show_bug.cgi?id=184786
34
35         Reviewed by Tim Horton.
36
37         * Configurations/WebKitLegacy.xcconfig:
38         * MigrateHeaders.make:
39
40 2018-04-23  Daniel Bates  <dabates@apple.com>
41
42         Implement Same-Site cookies
43         https://bugs.webkit.org/show_bug.cgi?id=159464
44         <rdar://problem/27196358>
45
46         Reviewed by Brent Fulgham.
47
48         Pass the Same-Site info through the strategy.
49
50         * WebCoreSupport/WebPlatformStrategies.h:
51         * WebCoreSupport/WebPlatformStrategies.mm:
52         (WebPlatformStrategies::cookiesForDOM):
53         (WebPlatformStrategies::setCookiesFromDOM):
54         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
55         (WebPlatformStrategies::getRawCookies):
56
57 2018-04-23  Zalan Bujtas  <zalan@apple.com>
58
59         [LayoutFormattingContext] Initial commit.
60         https://bugs.webkit.org/show_bug.cgi?id=184896
61
62         Reviewed by Antti Koivisto.
63
64         * Configurations/FeatureDefines.xcconfig:
65
66 2018-04-23  Daniel Bates  <dabates@apple.com>
67
68         Implement Same-Site cookies
69         https://bugs.webkit.org/show_bug.cgi?id=159464
70         <rdar://problem/27196358>
71
72         Reviewed by Brent Fulgham.
73
74         Pass the Same-Site info through the strategy.
75
76         * WebCoreSupport/WebPlatformStrategies.h:
77         * WebCoreSupport/WebPlatformStrategies.mm:
78         (WebPlatformStrategies::cookiesForDOM):
79         (WebPlatformStrategies::setCookiesFromDOM):
80         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
81         (WebPlatformStrategies::getRawCookies):
82
83 2018-04-20  Timothy Hatcher  <timothy@apple.com>
84
85         NULL dereference crash sometimes under [super initWithCoder:] in WebView
86
87         https://bugs.webkit.org/show_bug.cgi?id=184851
88         rdar://problem/39611236
89
90         Reviewed by Tim Horton.
91
92         * WebView/WebView.mm:
93         (-[WebView _commonInitializationWithFrameName:groupName:]):
94         (-[WebView effectiveAppearanceDidChange]):
95         Added a null check and call the code later in initialization.
96
97 2018-04-20  Tim Horton  <timothy_horton@apple.com>
98
99         Adjust geolocation feature flag
100         https://bugs.webkit.org/show_bug.cgi?id=184856
101
102         Reviewed by Wenson Hsieh.
103
104         * Configurations/FeatureDefines.xcconfig:
105
106 2018-04-18  Jer Noble  <jer.noble@apple.com>
107
108         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
109         https://bugs.webkit.org/show_bug.cgi?id=184762
110
111         Reviewed by Dan Bernstein.
112
113         * Configurations/WebKitLegacy.xcconfig:
114
115 2018-04-20  Youenn Fablet  <youenn@apple.com>
116
117         Make PluginData cache its web visible plugins
118         https://bugs.webkit.org/show_bug.cgi?id=184421
119
120         Reviewed by Chris Dumez.
121
122         * WebCoreSupport/WebPluginInfoProvider.h:
123         * WebCoreSupport/WebPluginInfoProvider.mm:
124         (WebPluginInfoProvider::pluginInfo):
125         (WebPluginInfoProvider::webVisiblePluginInfo):
126
127 2018-04-19  Chris Dumez  <cdumez@apple.com>
128
129         Rename JSDOMWindowProxy to JSWindowProxy
130         https://bugs.webkit.org/show_bug.cgi?id=184797
131
132         Reviewed by Sam Weinig.
133
134         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
135
136         * DOM/DOMUtility.mm:
137         (createDOMWrapper):
138         * WebView/WebFrame.mm:
139         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
140
141 2018-04-19  David Kilzer  <ddkilzer@apple.com>
142
143         Enable Objective-C weak references
144         <https://webkit.org/b/184789>
145         <rdar://problem/39571716>
146
147         Reviewed by Dan Bernstein.
148
149         * Configurations/Base.xcconfig:
150         (CLANG_ENABLE_OBJC_WEAK): Enable.
151
152 2018-04-18  Chris Dumez  <cdumez@apple.com>
153
154         Rename WindowProxyController to WindowProxy
155         https://bugs.webkit.org/show_bug.cgi?id=184756
156
157         Reviewed by Sam Weinig.
158
159         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
160         needed use WindowProxyController type, which was a bit confusing.
161
162         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
163         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
164         * WebView/WebFrame.mm:
165         (-[WebFrame _attachScriptDebugger]):
166
167 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
168
169         Unreviewed rollout of r230632. Regression in memory usage.
170
171         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
172
173         * WebView/WebPreferences.mm:
174         (+[WebPreferences initialize]):
175
176 2018-04-17  Chris Dumez  <cdumez@apple.com>
177
178         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
179         https://bugs.webkit.org/show_bug.cgi?id=184678
180         <rdar://problem/39422122>
181
182         Reviewed by Alex Christensen.
183
184         Add new parameter to dispatchDecidePolicyForNavigationAction.
185
186         * WebCoreSupport/WebFrameLoaderClient.h:
187         * WebCoreSupport/WebFrameLoaderClient.mm:
188         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
189
190 2018-04-13  Chris Dumez  <cdumez@apple.com>
191
192         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
193         https://bugs.webkit.org/show_bug.cgi?id=184591
194
195         Reviewed by Sam Weinig.
196
197         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
198         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
199         This is work towards fixing Bug 184515.
200
201         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
202         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
203         * WebView/WebFrame.mm:
204         (-[WebFrame _attachScriptDebugger]):
205
206 2018-04-12  Antoine Quint  <graouts@apple.com>
207
208         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
209         https://bugs.webkit.org/show_bug.cgi?id=184569
210         <rdar://problem/38671301>
211
212         Reviewed by Jon Lee.
213
214         * WebView/WebPreferences.mm:
215
216 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
217
218         [WTF] Remove StaticLock
219         https://bugs.webkit.org/show_bug.cgi?id=184332
220
221         Reviewed by Mark Lam.
222
223         * DOM/DOMInternal.mm:
224         (getDOMWrapper):
225         (addDOMWrapper):
226         (removeDOMWrapper):
227
228 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
229
230         Failures from mach port reference handling should be fatal
231         https://bugs.webkit.org/show_bug.cgi?id=184202
232         <rdar://problem/37771114>
233
234         Reviewed by Anders Carlsson.
235
236         * Plugins/Hosted/NetscapePluginHostManager.mm:
237         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
238
239 2018-04-03  Andy Estes  <aestes@apple.com>
240
241         [Mac] Prioritize file promises over filenames during drag and drop
242         https://bugs.webkit.org/show_bug.cgi?id=184237
243         <rdar://problem/38278076>
244
245         Reviewed by Wenson Hsieh.
246
247         * WebView/WebView.mm:
248         (-[WebView performDragOperation:]):
249
250 2018-04-03  Chris Dumez  <cdumez@apple.com>
251
252         Drop MainFrame class
253         https://bugs.webkit.org/show_bug.cgi?id=184191
254
255         Reviewed by Darin Adler.
256
257         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
258         relationship between the Page and the MainFrame.
259
260         This is ground work for introducing LocalFrame / RemoteFrame concepts.
261
262         * WebCoreSupport/WebDragClient.mm:
263         * WebCoreSupport/WebFrameLoaderClient.mm:
264         * WebCoreSupport/WebInspectorClient.mm:
265         * WebCoreSupport/WebPlatformStrategies.mm:
266         * WebCoreSupport/WebPluginInfoProvider.mm:
267         * WebView/WebFrame.mm:
268         * WebView/WebFrameView.mm:
269         * WebView/WebHTMLView.mm:
270         * WebView/WebView.mm:
271
272 2018-04-02  Jer Noble  <jer.noble@apple.com>
273
274         Enable Legacy EME for all WebKit & WebKitLegacy clients
275         https://bugs.webkit.org/show_bug.cgi?id=184018
276         <rdar://problem/34887387>
277
278         Reviewed by Eric Carlson.
279
280         * WebView/WebPreferences.mm:
281         (+[WebPreferences initialize]):
282
283 2018-03-29  JF Bastien  <jfbastien@apple.com>
284
285         Use Forward.h instead of forward-declaring WTF::String
286         https://bugs.webkit.org/show_bug.cgi?id=184172
287         <rdar://problem/39026146>
288
289         Reviewed by Yusuke Suzuki.
290
291         As part of #184164 I'm changing WTF::String, and the forward
292         declarations are just wrong because I'm making it templated. We
293         should use Forward.h anyways, so do that instead.
294
295         * WebView/WebScriptDebugger.h:
296
297 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
298
299         Protect against invalid mach ports returned by mach_port_request_notification
300         https://bugs.webkit.org/show_bug.cgi?id=184106
301         <rdar://problem/37865316>
302
303         Reviewed by Chris Dumez.
304
305         * Plugins/Hosted/NetscapePluginHostProxy.mm:
306         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
307         and clean up if it experienced an error.
308         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
309
310 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
311
312         Avoid uninitialized mach ports
313         https://bugs.webkit.org/show_bug.cgi?id=184090
314         <rdar://problem/37261129>
315
316         Reviewed by Chris Dumez.
317
318         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
319         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
320         there is a potential for us to try to use invalid ports.
321
322         We should always check return values, and ensure that the mach port variables we seek to initialize are
323         kept in a valid state.
324
325         Reviewed by Chris Dumez.
326
327         * Plugins/Hosted/NetscapePluginHostManager.h:
328         * Plugins/Hosted/NetscapePluginHostManager.mm:
329         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
330         port is passed to an API function.
331         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
332         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
333         * Plugins/Hosted/NetscapePluginHostProxy.h:
334         * Plugins/Hosted/NetscapePluginHostProxy.mm:
335         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
336         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
337         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
338         (WKPCStatusText): Ditto.
339         (WKPCLoadURL): Ditto.
340         (WKPCCancelLoadURL): Ditto.
341         (WKPCInvalidateRect): Ditto.
342         (WKPCGetScriptableNPObjectReply): Ditto.
343         (WKPCBooleanReply): Ditto.
344         (WKPCBooleanAndDataReply): Ditto.
345         (WKPCInstantiatePluginReply): Ditto.
346         (WKPCGetWindowNPObject): Ditto.
347         (WKPCGetPluginElementNPObject): Ditto.
348         (WKPCForgetBrowserObject): Ditto.
349         (WKPCEvaluate): Ditto.
350         (WKPCGetStringIdentifier): Ditto.
351         (WKPCGetIntIdentifier): Ditto.
352         (WKPCInvoke): Ditto.
353         (WKPCInvokeDefault): Ditto.
354         (WKPCConstruct): Ditto.
355         (WKPCGetProperty): Ditto.
356         (WKPCSetProperty): Ditto.
357         (WKPCRemoveProperty): Ditto.
358         (WKPCHasProperty): Ditto.
359         (WKPCHasMethod): Ditto.
360         (WKPCIdentifierInfo): Ditto.
361         (WKPCEnumerate): Ditto.
362         (WKPCSetMenuBarVisible): Ditto.
363         (WKPCSetFullscreenWindowIsShowing): Ditto.
364         (WKPCSetModal): Ditto.
365         (WKPCGetCookies): Ditto.
366         (WKPCGetProxy): Ditto.
367         (WKPCSetCookies): Ditto.
368         (WKPCGetAuthenticationInfo): Ditto.
369         (WKPCConvertPoint): Ditto.
370         (WKPCLayerHostingModeChanged): Ditto.
371         (WKPCSetException): Ditto.
372
373 2018-03-26  Tim Horton  <timothy_horton@apple.com>
374
375         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
376         https://bugs.webkit.org/show_bug.cgi?id=184030
377         <rdar://problem/38895281>
378
379         Reviewed by Dan Bernstein.
380
381         * Configurations/Base.xcconfig:
382
383 2018-03-26  Chris Dumez  <cdumez@apple.com>
384
385         Use SecurityOriginData more consistently in Service Worker code
386         https://bugs.webkit.org/show_bug.cgi?id=183969
387
388         Reviewed by Darin Adler.
389
390         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
391
392         * Storage/WebDatabaseManager.mm:
393         (-[WebDatabaseManager databasesWithOrigin:]):
394         (-[WebDatabaseManager deleteOrigin:]):
395         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
396         * Storage/WebDatabaseQuotaManager.mm:
397         (-[WebDatabaseQuotaManager usage]):
398         (-[WebDatabaseQuotaManager quota]):
399         (-[WebDatabaseQuotaManager setQuota:]):
400         * Storage/WebStorageManager.mm:
401         (-[WebStorageManager deleteOrigin:]):
402         * WebCoreSupport/WebSecurityOrigin.mm:
403         (-[WebSecurityOrigin databaseIdentifier]):
404         (-[WebSecurityOrigin usage]):
405         (-[WebSecurityOrigin quota]):
406         (-[WebSecurityOrigin setQuota:]):
407
408 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
409
410         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
411         https://bugs.webkit.org/show_bug.cgi?id=183911
412         <rdar://problem/38762306>
413
414         Reviewed by Youenn Fablet.
415
416         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
417
418         * WebView/WebView.mm:
419         (+[WebView initialize]):
420
421 2018-03-26  Alex Christensen  <achristensen@webkit.org>
422
423         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
424         https://bugs.webkit.org/show_bug.cgi?id=183965
425
426         Reviewed by Chris Dumez.
427
428         * WebCoreSupport/WebFrameLoaderClient.h:
429         * WebCoreSupport/WebFrameLoaderClient.mm:
430         (WebFrameLoaderClient::willCacheResponse const):
431
432 2018-03-25  Commit Queue  <commit-queue@webkit.org>
433
434         Unreviewed, rolling out r229954.
435         https://bugs.webkit.org/show_bug.cgi?id=184000
436
437         Caused many layout tests to crash on Apple High Sierra,
438         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
439         by dydz on #webkit).
440
441         Reverted changeset:
442
443         "Use SecurityOriginData more consistently in Service Worker
444         code"
445         https://bugs.webkit.org/show_bug.cgi?id=183969
446         https://trac.webkit.org/changeset/229954
447
448 2018-03-24  Chris Dumez  <cdumez@apple.com>
449
450         Use SecurityOriginData more consistently in Service Worker code
451         https://bugs.webkit.org/show_bug.cgi?id=183969
452
453         Reviewed by Darin Adler.
454
455         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
456
457         * Storage/WebDatabaseManager.mm:
458         (-[WebDatabaseManager databasesWithOrigin:]):
459         (-[WebDatabaseManager deleteOrigin:]):
460         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
461         * Storage/WebDatabaseQuotaManager.mm:
462         (-[WebDatabaseQuotaManager usage]):
463         (-[WebDatabaseQuotaManager quota]):
464         (-[WebDatabaseQuotaManager setQuota:]):
465         * Storage/WebStorageManager.mm:
466         (-[WebStorageManager deleteOrigin:]):
467         * WebCoreSupport/WebSecurityOrigin.mm:
468         (-[WebSecurityOrigin databaseIdentifier]):
469         (-[WebSecurityOrigin usage]):
470         (-[WebSecurityOrigin quota]):
471         (-[WebSecurityOrigin setQuota:]):
472
473 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
474
475         Fix the build
476
477         * WebView/WebView.mm:
478
479 2018-03-23  Tim Horton  <timothy_horton@apple.com>
480
481         Fix the build with no pasteboard
482         https://bugs.webkit.org/show_bug.cgi?id=183973
483
484         Reviewed by Dan Bernstein.
485
486         * Configurations/FeatureDefines.xcconfig:
487         * WebView/WebView.mm:
488         (-[WebView _requestStartDataInteraction:globalPosition:]):
489         (-[WebView _getDataInteractionData]):
490         (-[WebView _dataOperationTextIndicator]):
491         (-[WebView _dragSourceAction]):
492         (-[WebView _draggedLinkTitle]):
493         (-[WebView _draggedLinkURL]):
494         (-[WebView _draggedElementBounds]):
495         (-[WebView _enteredDataInteraction:client:global:operation:]):
496         (-[WebView _updatedDataInteraction:client:global:operation:]):
497         (-[WebView _exitedDataInteraction:client:global:operation:]):
498         (-[WebView _performDataInteraction:client:global:operation:]):
499         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
500         (-[WebView _endedDataInteraction:global:]):
501         (-[WebView _dataInteractionCaretRect]):
502         * WebView/WebViewPrivate.h:
503
504 2018-03-23  Tim Horton  <timothy_horton@apple.com>
505
506         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
507         https://bugs.webkit.org/show_bug.cgi?id=183960
508         <rdar://problem/38812356>
509
510         Reviewed by Dan Bernstein.
511
512         * Configurations/WebKitLegacy.xcconfig:
513
514 2018-03-23  Tim Horton  <timothy_horton@apple.com>
515
516         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
517         https://bugs.webkit.org/show_bug.cgi?id=183954
518         <rdar://problem/38808858>
519
520         Reviewed by Dan Bernstein.
521
522         * WebView/WebPreferences.mm:
523         (-[WebPreferences setAudioSessionCategoryOverride:]):
524
525 2018-03-23  Tim Horton  <timothy_horton@apple.com>
526
527         Adopt WK_PLATFORM_NAME in WebKitLegacy
528         https://bugs.webkit.org/show_bug.cgi?id=183948
529         <rdar://problem/38803908>
530
531         Reviewed by Dan Bernstein.
532
533         * Configurations/WebKitLegacy.xcconfig:
534         * MigrateHeaders.make:
535         * postprocess-headers.sh:
536
537 2018-03-23  Brady Eidson  <beidson@apple.com>
538
539         Go to back/forward list items after a process-swapped navigation.
540         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
541
542         Reviewed by Andy Estes.
543
544         * WebView/WebView.mm:
545         (-[WebView _loadBackForwardListFromOtherView:]):
546         (-[WebView goToBackForwardItem:]):
547
548 2018-03-22  Tim Horton  <timothy_horton@apple.com>
549
550         Improve readability of WebCore's OTHER_LDFLAGS
551         https://bugs.webkit.org/show_bug.cgi?id=183909
552         <rdar://problem/38760992>
553
554         Reviewed by Dan Bernstein.
555
556         * Configurations/Base.xcconfig:
557         * Configurations/FeatureDefines.xcconfig:
558
559 2018-03-20  Tim Horton  <timothy_horton@apple.com>
560
561         Enable the minimal simulator feature flag when appropriate
562         https://bugs.webkit.org/show_bug.cgi?id=183807
563
564         Reviewed by Dan Bernstein.
565
566         * Configurations/FeatureDefines.xcconfig:
567
568 2018-03-20  Tim Horton  <timothy_horton@apple.com>
569
570         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
571         https://bugs.webkit.org/show_bug.cgi?id=183758
572         <rdar://problem/38017644>
573
574         Reviewed by Dan Bernstein.
575
576         * Configurations/FeatureDefines.xcconfig:
577
578 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
579
580         Clear style colors when setting default appearance
581         https://bugs.webkit.org/show_bug.cgi?id=183759
582
583         Reviewed by Tim Horton.
584
585         Colors are cached and need to be cleared and recalculated.
586         Refactor to do all style recalcs together.
587
588         * WebView/WebView.mm:
589         (-[WebView _setDefaultAppearanceAndClearStyle]):
590         (-[WebView _setUseSystemAppearance:]):
591         (-[WebView effectiveAppearanceDidChange]):
592
593 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
594
595         Unreviewed, another quick fix for r229699
596
597         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
598
599         * Configurations/FeatureDefines.xcconfig:
600
601 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
602
603         Ensure that style is updated when the effective appearance changes
604         https://bugs.webkit.org/show_bug.cgi?id=183690
605         <rdar://problem/38385900>
606
607         Reviewed by Tim Horton and Wenson Hsieh.
608
609         Respond to and respect the effective appearance changing.
610
611         * WebView/WebView.mm:
612         (-[WebView _setUseSystemAppearance:]):
613         (-[WebView effectiveAppearanceDidChange]):
614
615 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
616
617         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
618         https://bugs.webkit.org/show_bug.cgi?id=183677
619
620         Reviewed by Tim Horton.
621
622         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
623
624         * DOM/DOM.mm:
625         (-[DOMHTMLLinkElement _mediaQueryMatches]):
626
627 2018-03-14  Tim Horton  <timothy_horton@apple.com>
628
629         Fix the build after r229567
630
631         * Configurations/FeatureDefines.xcconfig:
632
633 2018-03-12  Tim Horton  <timothy_horton@apple.com>
634
635         Stop using SDK conditionals to control feature definitions
636         https://bugs.webkit.org/show_bug.cgi?id=183430
637         <rdar://problem/38251619>
638
639         Reviewed by Dan Bernstein.
640
641         * Configurations/FeatureDefines.xcconfig:
642         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
643
644 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
645
646         Runtime flag for link prefetch and remove link subresource.
647         https://bugs.webkit.org/show_bug.cgi?id=183540
648
649         Reviewed by Chris Dumez.
650
651         Remove the LINK_PREFETCH build time flag.
652
653         * Configurations/FeatureDefines.xcconfig:
654
655 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
656
657         Remove GridLayout runtime flag
658         https://bugs.webkit.org/show_bug.cgi?id=183484
659
660         Reviewed by Myles C. Maxfield.
661
662         The Grid Layout feature has been enabled by default for almost a
663         year, so I think it's time to remove the runtime flag and the
664
665         * WebView/WebPreferenceKeysPrivate.h:
666         * WebView/WebPreferences.mm:
667         (+[WebPreferences initialize]):
668         * WebView/WebPreferencesPrivate.h:
669         * WebView/WebView.mm:
670         (-[WebView _preferencesChanged:]):
671
672 2018-03-12  Antoine Quint  <graouts@apple.com>
673
674         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
675         https://bugs.webkit.org/show_bug.cgi?id=183504
676         <rdar://problem/38372965>
677
678         Reviewed by Dean Jackson and Jon Lee.
679
680         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
681         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
682
683         * WebView/WebPreferenceKeysPrivate.h:
684         * WebView/WebPreferences.mm:
685         (+[WebPreferences initialize]):
686         (-[WebPreferences setModernMediaControlsEnabled:]):
687         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
688         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
689         * WebView/WebPreferencesPrivate.h:
690         * WebView/WebView.mm:
691         (-[WebView _preferencesChanged:]):
692
693 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
694
695         Media query for default appearance
696         https://bugs.webkit.org/show_bug.cgi?id=183539
697         <rdar://problem/38326388>
698
699         Reviewed by Tim Horton.
700
701         Write a media query to evaluate appearance.
702
703         * WebView/WebView.mm:
704         (-[WebView _commonInitializationWithFrameName:groupName:]):
705         (-[WebView _setUseSystemAppearance:]):
706
707 2018-03-09  Andy Estes  <aestes@apple.com>
708
709         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
710         https://bugs.webkit.org/show_bug.cgi?id=183489
711         <rdar://problem/38267517>
712
713         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
714         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
715         to issue a sandbox extension for this directory, but for security reasons App Sandbox
716         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
717         block with a nil error and a valid file URL, but no file will actually exist at that URL.
718
719         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
720         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
721         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
722         drop destination.
723
724         Reviewed by Wenson Hsieh.
725
726         * WebView/WebView.mm:
727         (-[WebView performDragOperation:]):
728
729 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
730
731         Allow WebViews to disable system appearance
732         https://bugs.webkit.org/show_bug.cgi?id=183418
733         <rdar://problem/36975642>
734
735         Reviewed by Tim Horton.
736
737         Allow webviews to choose whether or not to follow the default system appearance.
738
739         * WebView/WebView.mm:
740         (-[WebView _setUseSystemAppearance:]):
741         (-[WebView _useSystemAppearance]):
742         * WebView/WebViewPrivate.h:
743
744 2018-03-08  Youenn Fablet  <youenn@apple.com>
745
746         libwebrtc update broke internal builds
747         https://bugs.webkit.org/show_bug.cgi?id=183454
748
749         Reviewed by Eric Carlson.
750
751         * Configurations/WebKitLegacy.xcconfig:
752
753 2018-03-08  Chris Dumez  <cdumez@apple.com>
754
755         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
756         https://bugs.webkit.org/show_bug.cgi?id=183455
757         <rdar://problem/38191749>
758
759         Reviewed by Youenn Fablet.
760
761         Add a null check for the page as we have evidence from crashes that it can be null.
762         Other functions in WebFrameNetworkingContext already null check the page as well,
763         not just the frame so this is consistent.
764
765         * WebCoreSupport/WebFrameNetworkingContext.mm:
766         (WebFrameNetworkingContext::storageSession const):
767
768 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
769
770         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
771         https://bugs.webkit.org/show_bug.cgi?id=183429
772
773         Reviewed by Mark Lam.
774
775         * DOM/DOM.mm:
776         (+[DOMNode _nodeFromJSWrapper:]):
777         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
778         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
779         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
780         * Plugins/Hosted/ProxyInstance.mm:
781         (WebKit::ProxyInstance::invokeMethod):
782         * WebView/WebView.mm:
783         (aeDescFromJSValue):
784
785 2018-03-08  Tim Horton  <timothy_horton@apple.com>
786
787         Stop linking ApplicationServices directly
788         https://bugs.webkit.org/show_bug.cgi?id=182867
789         <rdar://problem/38252142>
790
791         Reviewed by Alex Christensen.
792
793         The frameworks that we use that live inside ApplicationServices
794         have mostly moved out, so import them directly.
795
796         * Carbon/CarbonUtils.h:
797         * WebKitPrefix.h:
798         * WebView/WebHTMLView.mm:
799         * WebView/WebPDFView.mm:
800
801 2018-03-07  Tim Horton  <timothy_horton@apple.com>
802
803         Sort and separate FeatureDefines.xcconfig
804         https://bugs.webkit.org/show_bug.cgi?id=183427
805
806         Reviewed by Dan Bernstein.
807
808         * Configurations/FeatureDefines.xcconfig:
809         Sort and split FeatureDefines into paragraphs
810         (to make it easier to sort later).
811
812 2018-03-07  Youenn Fablet  <youenn@apple.com>
813
814         Match unsupported plugins based on domains and not origin
815         https://bugs.webkit.org/show_bug.cgi?id=183384
816
817         Reviewed by Chris Dumez.
818
819         * WebCoreSupport/WebPluginInfoProvider.h:
820         * WebCoreSupport/WebPluginInfoProvider.mm:
821         (WebPluginInfoProvider::getPluginInfo):
822         (WebPluginInfoProvider::getWebVisiblePluginInfo):
823
824 2018-03-05  Andy Estes  <aestes@apple.com>
825
826         [Mac] Teach WebCore::Pasteboard about file promise drags
827         https://bugs.webkit.org/show_bug.cgi?id=183314
828         <rdar://problem/38105493>
829
830         Reviewed by Darin Adler.
831
832         Added a FIXME comment.
833
834         * WebView/WebView.mm:
835         (-[WebView performDragOperation:]):
836
837 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
838
839         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
840         https://bugs.webkit.org/show_bug.cgi?id=183312
841
842         Reviewed by Mark Lam.
843
844         Remove wtf/CurrentTime.h include pragma.
845
846         * WebView/WebFrame.mm:
847         * WebView/WebPDFView.mm:
848
849 2018-03-04  Tim Horton  <timothy_horton@apple.com>
850
851         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
852         https://bugs.webkit.org/show_bug.cgi?id=183283
853         <rdar://problem/38062148>
854
855         Reviewed by Sam Weinig.
856
857         * Configurations/FeatureDefines.xcconfig:
858
859 2018-02-28  Alex Christensen  <achristensen@webkit.org>
860
861         Reduce use of NetworkingContext in WebKit
862         https://bugs.webkit.org/show_bug.cgi?id=183213
863
864         Reviewed by Brady Eidson.
865
866         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
867         (WebKit::NetscapePluginInstanceProxy::getProxy):
868         * Plugins/WebNetscapePluginView.mm:
869         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
870
871 2018-02-17  Darin Adler  <darin@apple.com>
872
873         Prepare for ExtendedColor changes (first step)
874         https://bugs.webkit.org/show_bug.cgi?id=182904
875
876         Reviewed by Sam Weinig.
877
878         * Misc/WebKitNSStringExtras.mm:
879         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
880
881 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
882
883         Remove currentTime() / currentTimeMS()
884         https://bugs.webkit.org/show_bug.cgi?id=183052
885
886         Reviewed by Mark Lam.
887
888         * WebCoreSupport/WebFrameLoaderClient.h:
889         * WebCoreSupport/WebFrameLoaderClient.mm:
890         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
891
892 2018-02-16  Youenn Fablet  <youenn@apple.com>
893
894         Allow specifying which plug-ins are supported
895         https://bugs.webkit.org/show_bug.cgi?id=182748
896
897         Reviewed by Chris Dumez.
898
899         * WebCoreSupport/WebPluginInfoProvider.h:
900         * WebCoreSupport/WebPluginInfoProvider.mm:
901         (WebPluginInfoProvider::getPluginInfo):
902         (WebPluginInfoProvider::getWebVisiblePluginInfo):
903
904 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
905
906         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
907         https://bugs.webkit.org/show_bug.cgi?id=182882
908         <rdar://problem/35672661>
909
910         Reviewed by Dan Bernstein.
911
912         Make sure the smart pointer hold the collection of subviews lives at least as
913         long as the loop using it.
914
915         * WebView/WebHTMLView.mm:
916         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
917
918 2018-02-14  Daniel Bates  <dabates@apple.com>
919
920         Disallow cross-origin subresources from asking for credentials
921         https://bugs.webkit.org/show_bug.cgi?id=182579
922         <rdar://problem/36162271>
923
924         Reviewed by Andy Estes.
925
926         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
927         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
928
929         * WebView/WebPreferenceKeysPrivate.h:
930         * WebView/WebPreferences.mm:
931         (+[WebPreferences initialize]):
932         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
933         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
934         * WebView/WebPreferencesPrivate.h:
935         * WebView/WebView.mm:
936         (-[WebView _preferencesChanged:]):
937
938 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
939
940         Remove ForwardingHeaders directory from WebKitLegacy/mac.
941         https://bugs.webkit.org/show_bug.cgi?id=182738
942
943         Reviewed by Darin Adler.
944
945         * ForwardingHeaders/collector/handles/Global.h: Removed.
946         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
947         * ForwardingHeaders/runtime/Completion.h: Removed.
948         * ForwardingHeaders/runtime/Error.h: Removed.
949         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
950         * ForwardingHeaders/runtime/JSFunction.h: Removed.
951         * ForwardingHeaders/runtime/JSLock.h: Removed.
952         * ForwardingHeaders/runtime/JSObject.h: Removed.
953         * ForwardingHeaders/runtime/JSString.h: Removed.
954         * ForwardingHeaders/runtime/Protect.h: Removed.
955         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
956
957 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
958
959         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
960         https://bugs.webkit.org/show_bug.cgi?id=182641
961
962         Reviewed by Dan Bernstein.
963
964         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
965         https://trac.webkit.org/changeset/228308.
966
967         * WebView/WebVideoFullscreenController.h:
968         * WebView/WebVideoFullscreenHUDWindowController.mm:
969         * WebView/WebWindowAnimation.h:
970         * WebView/WebWindowAnimation.mm:
971         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
972         (WebCore::scaledRect): Deleted.
973         (WebCore::squaredDistance): Deleted.
974
975 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
976
977         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
978
979         * WebView/WebWindowAnimation.mm:
980         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
981
982 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
983
984         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
985         https://bugs.webkit.org/show_bug.cgi?id=182615
986
987         Reviewed by Eric Carlson.
988
989         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
990         Ideally, we should not reference NSApp in WebCore.
991
992         * WebView/WebFullScreenController.mm:
993         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
994         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
995         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
996         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
997         * WebView/WebView.mm:
998         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
999         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
1000
1001 2018-01-13  Darin Adler  <darin@apple.com>
1002
1003         Event improvements
1004         https://bugs.webkit.org/show_bug.cgi?id=179591
1005
1006         Reviewed by Chris Dumez.
1007
1008         * DOM/DOMWheelEvent.mm:
1009         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
1010         Call initWebKitWheelEvent.
1011
1012         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
1013         * WebCoreSupport/WebInspectorClient.mm: Ditto.
1014         * WebView/WebFrame.mm: Ditto.
1015
1016         * WebView/WebHTMLView.mm:
1017         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
1018         underlyingPlatformEvent.
1019         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
1020
1021         * WebView/WebScriptWorld.mm:
1022         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
1023
1024         * WebView/WebView.mm: Removed include of ScriptValue.h.
1025
1026 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
1027
1028         Remove WebCore/ForwardingHeaders directory
1029         https://bugs.webkit.org/show_bug.cgi?id=182347
1030
1031         Reviewed by Keith Miller.
1032
1033         * Carbon/CarbonWindowAdapter.mm:
1034         * DOM/WebDOMOperations.mm:
1035         * History/WebBackForwardList.mm:
1036         * History/WebHistoryItem.mm:
1037         * Misc/WebCache.mm:
1038         * Misc/WebElementDictionary.mm:
1039         * Misc/WebIconDatabase.mm:
1040         * Misc/WebStringTruncator.mm:
1041         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1042         * Plugins/Hosted/ProxyInstance.mm:
1043         * Plugins/Hosted/ProxyRuntimeObject.mm:
1044         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1045         * Plugins/WebBaseNetscapePluginView.mm:
1046         * Plugins/WebBasePluginPackage.mm:
1047         * Plugins/WebNetscapePluginStream.mm:
1048         * Plugins/WebNetscapePluginView.mm:
1049         * Plugins/WebPluginController.mm:
1050         * WebCoreSupport/WebEditorClient.mm:
1051         * WebCoreSupport/WebFrameLoaderClient.mm:
1052         * WebCoreSupport/WebInspectorClient.h:
1053         * WebCoreSupport/WebInspectorClient.mm:
1054         * WebView/WebDataSource.mm:
1055         * WebView/WebFrame.mm:
1056         * WebView/WebHTMLRepresentation.mm:
1057         * WebView/WebHTMLView.mm:
1058         * WebView/WebPreferences.mm:
1059         * WebView/WebScriptDebugDelegate.mm:
1060         * WebView/WebScriptDebugger.h:
1061         * WebView/WebTextIterator.mm:
1062         * WebView/WebView.mm:
1063         * WebView/WebViewData.mm:
1064
1065 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
1066
1067         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
1068         https://bugs.webkit.org/show_bug.cgi?id=182312
1069
1070         Reviewed by Michael Catanzaro.
1071
1072         * WebKitPrefix.h:
1073
1074 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
1075
1076         [WebAuthN] Add a compile-time feature flag
1077         https://bugs.webkit.org/show_bug.cgi?id=182211
1078         <rdar://problem/36936365>
1079
1080         Reviewed by Brent Fulgham.
1081
1082         * Configurations/FeatureDefines.xcconfig:
1083
1084 2018-01-27  Dan Bernstein  <mitz@apple.com>
1085
1086         HaveInternalSDK includes should be "#include?"
1087         https://bugs.webkit.org/show_bug.cgi?id=179670
1088
1089         * Configurations/Base.xcconfig:
1090
1091 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1092
1093         Remove unused QTKit preference
1094         https://bugs.webkit.org/show_bug.cgi?id=181968
1095
1096         Reviewed by Alexey Proskuryakov.
1097
1098         * WebView/WebPreferenceKeysPrivate.h:
1099         * WebView/WebPreferences.mm:
1100         (+[WebPreferences initialize]):
1101         (-[WebPreferences setQTKitEnabled:]): Deleted.
1102         (-[WebPreferences isQTKitEnabled]): Deleted.
1103         * WebView/WebPreferencesPrivate.h:
1104         * WebView/WebView.mm:
1105         (-[WebView _preferencesChanged:]):
1106
1107 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1108
1109         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
1110         https://bugs.webkit.org/show_bug.cgi?id=182037
1111         <rdar://problem/36747812>
1112
1113         Reviewed by Ryosuke Niwa.
1114
1115         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
1116         for more details.
1117
1118         * WebView/WebHTMLRepresentation.mm:
1119         (-[WebHTMLRepresentation elementWithName:inForm:]):
1120         (-[WebHTMLRepresentation controlsInForm:]):
1121
1122 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1123
1124         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
1125         https://bugs.webkit.org/show_bug.cgi?id=181961
1126
1127         Reviewed by Michael Catanzaro.
1128
1129         * WebView/WebPreferences.mm:
1130
1131 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1132
1133         Unreviewed, rolling out r227437.
1134         https://bugs.webkit.org/show_bug.cgi?id=182011
1135
1136         broke build (Requested by alexchristensen on #webkit).
1137
1138         Reverted changeset:
1139
1140         "Remove unused QTKit preference"
1141         https://bugs.webkit.org/show_bug.cgi?id=181968
1142         https://trac.webkit.org/changeset/227437
1143
1144 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1145
1146         Remove unused QTKit preference
1147         https://bugs.webkit.org/show_bug.cgi?id=181968
1148
1149         Reviewed by Alexey Proskuryakov.
1150
1151         * WebView/WebPreferenceKeysPrivate.h:
1152         * WebView/WebPreferences.mm:
1153         (+[WebPreferences initialize]):
1154         (-[WebPreferences setQTKitEnabled:]): Deleted.
1155         (-[WebPreferences isQTKitEnabled]): Deleted.
1156         * WebView/WebPreferencesPrivate.h:
1157         * WebView/WebView.mm:
1158         (-[WebView _preferencesChanged:]):
1159
1160 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1161
1162         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
1163         https://bugs.webkit.org/show_bug.cgi?id=181960
1164         <rdar://problem/36431678>
1165
1166         Reviewed by Tim Horton.
1167
1168         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
1169         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
1170         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
1171
1172         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
1173         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
1174         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
1175
1176         * WebView/WebView.mm:
1177         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1178
1179 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
1180
1181         Turning off custom pasteboard data doesn't actually turn it off in WK2
1182         https://bugs.webkit.org/show_bug.cgi?id=181920
1183         <rdar://problem/36686429>
1184
1185         Reviewed by Wenson Hsieh.
1186
1187         Always disable custom pasteboard data in WebKit1. See r226156 for details.
1188
1189         * WebView/WebPreferences.mm:
1190         (+[WebPreferences initialize]):
1191         * WebView/WebView.mm:
1192         (-[WebView _preferencesChanged:]):
1193
1194 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1195
1196         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1197         https://bugs.webkit.org/show_bug.cgi?id=181918
1198
1199         Reviewed by Tim Horton.
1200
1201         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1202
1203         * Configurations/FeatureDefines.xcconfig:
1204
1205 2018-01-20  Andy Estes  <aestes@apple.com>
1206
1207         [Apple Pay] Stop eagerly loading PassKit.framework
1208         https://bugs.webkit.org/show_bug.cgi?id=181911
1209         <rdar://problem/36555369>
1210
1211         Reviewed by Tim Horton.
1212
1213         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1214         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1215         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1216
1217         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1218
1219 2018-01-19  Dean Jackson  <dino@apple.com>
1220
1221         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1222         https://bugs.webkit.org/show_bug.cgi?id=181817
1223         <rdar://problem/35274055>
1224
1225         Reviewed by Simon Fraser.
1226
1227         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1228
1229         * Misc/WebKitVersionChecks.h:
1230         * WebView/WebView.mm:
1231         (-[WebView _commonInitializationWithFrameName:groupName:]):
1232
1233 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1234
1235         Remove unused WebViewPrivate _allowCookies
1236         https://bugs.webkit.org/show_bug.cgi?id=181812
1237
1238         Reviewed by Tim Horton.
1239
1240         * WebView/WebView.mm:
1241         (+[WebView _setAllowCookies:]): Deleted.
1242         (+[WebView _allowCookies]): Deleted.
1243         * WebView/WebViewPrivate.h:
1244
1245 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1246
1247         Build fix, remove a call to -[NSWindow setOneShot:]
1248         https://bugs.webkit.org/show_bug.cgi?id=181809
1249
1250         Reviewed by Tim Horton.
1251
1252         * WebView/WebTextCompletionController.mm:
1253         (-[WebTextCompletionController _buildUI]):
1254
1255 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1256
1257         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1258
1259         * Carbon/HIWebView.mm:
1260         (overrideCGContext):
1261         (restoreCGContext):
1262
1263 2018-01-18  Dan Bernstein  <mitz@apple.com>
1264
1265         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1266         https://bugs.webkit.org/show_bug.cgi?id=181803
1267
1268         Reviewed by Tim Horton.
1269
1270         * Configurations/Base.xcconfig: Updated.
1271         * Configurations/DebugRelease.xcconfig: Ditto.
1272         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1273         * Configurations/Version.xcconfig: Updated.
1274         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1275           useful for defining settings that depend on the target macOS version.
1276
1277 2018-01-17  Youenn Fablet  <youenn@apple.com>
1278
1279         Put fetch Request.keepalive behind a runtime flag
1280         https://bugs.webkit.org/show_bug.cgi?id=181592
1281
1282         Reviewed by Chris Dumez.
1283
1284         * WebView/WebPreferenceKeysPrivate.h:
1285         * WebView/WebPreferences.mm:
1286         (+[WebPreferences initialize]):
1287         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1288         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1289         * WebView/WebPreferencesPrivate.h:
1290         * WebView/WebView.mm:
1291         (-[WebView _preferencesChanged:]):
1292
1293 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1294
1295         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1296         https://bugs.webkit.org/show_bug.cgi?id=181637
1297         <rdar://problem/36508471>
1298
1299         Reviewed by Tim Horton.
1300
1301         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1302
1303         * WebCoreSupport/WebEditorClient.h:
1304         * WebCoreSupport/WebEditorClient.mm:
1305         (WebEditorClient::replacementURLForResource):
1306
1307 2018-01-11  Keith Miller  <keith_miller@apple.com>
1308
1309         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1310         https://bugs.webkit.org/show_bug.cgi?id=181573
1311
1312         Reviewed by Simon Fraser.
1313
1314         * Configurations/FeatureDefines.xcconfig:
1315
1316 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1317
1318         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1319         https://bugs.webkit.org/show_bug.cgi?id=181497
1320
1321         Reviewed by Tim Horton.
1322
1323         See other ChangeLogs for more detail.
1324
1325         * WebCoreSupport/WebDragClient.h:
1326
1327 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1328
1329         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1330         https://bugs.webkit.org/show_bug.cgi?id=181523
1331         <rdar://problem/28959131>
1332
1333         Reviewed by Alex Christensen.
1334
1335         * WebView/WebImmediateActionController.mm:
1336         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1337         Apply the change made in r216652 to WebKit1's immediate action controller.
1338
1339         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1340         the startContainer of the range is in an anonymous node.
1341
1342 2018-01-11  Youenn Fablet  <youenn@apple.com>
1343
1344         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1345         https://bugs.webkit.org/show_bug.cgi?id=181480
1346
1347         Reviewed by Eric Carlson.
1348
1349         * WebView/WebPreferences.mm:
1350         (+[WebPreferences initialize]):
1351
1352 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1353
1354         Fix check-webkit-style issues with WebNSDataExtras.mm
1355         <https://webkit.org/b/181369>
1356
1357         Reviewed by Alex Christensen.
1358
1359         * Misc/WebNSDataExtras.mm:
1360         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1361         (-[NSData _webkit_guessedMIMETypeForXML]):
1362         (-[NSData _webkit_guessedMIMEType]):
1363         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1364         (_findEOL):
1365         (-[NSData _webkit_parseRFC822HeaderFields]):
1366         (-[NSData _web_locationAfterFirstBlankLine]):
1367         - Fix all the check-webkit-style warnings.
1368
1369 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1370
1371         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1372         <https://webkit.org/b/181256>
1373         <rdar://problem/36281730>
1374
1375         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1376         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1377         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1378           to avoid warnings from casting CFStringRef to NPNSString*.
1379           Note that CFMutableStringRef is the same as CFStringRef
1380           without the const modifier, hence its use in the const_cast<>
1381           above.
1382
1383 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1384
1385         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1386         <https://webkit.org/b/181256>
1387         <rdar://problem/36281730>
1388
1389         * Carbon/HIWebView.mm:
1390         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1391         checked_cf_cast<CFRunLoopRef>() to fix warning.
1392
1393 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1394
1395         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1396         <https://webkit.org/b/181256>
1397         <rdar://problem/36281730>
1398
1399         Reviewed by Darin Adler.
1400
1401         * Carbon/CarbonUtils.m:
1402         (PoolCleaner):
1403         - Use #pragmas to ignore -Wcast-qual warnings when using a
1404           C-style cast from CFTypeRef to CFRunloopRef.
1405         * Carbon/CarbonWindowFrame.m:
1406         (-[CarbonWindowFrame title]):
1407         - Use #pragmas to ignore -Wcast-qual warnings when using a
1408           C-style cast from CFStringRef to NSString *.
1409         * Carbon/HIViewAdapter.m:
1410         (+[HIViewAdapter getHIViewForNSView:]):
1411         - Use #pragmas to ignore -Wcast-qual warnings when using a
1412           C-style cast from CFTypeRef to HIViewRef.
1413         * Configurations/Base.xcconfig:
1414         (WARNING_CFLAGS): Add -Wcast-qual.
1415         * Misc/WebElementDictionary.mm:
1416         (-[WebElementDictionary objectForKey:]):
1417         - Use static_cast<SEL>(const_cast<void*>()) to fix
1418           warning.
1419         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1420         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1421         (-[NSData _webkit_guessedMIMETypeForXML]):
1422         (-[NSData _webkit_guessedMIMEType]):
1423         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1424         (_findEOL):
1425         (-[NSData _webkit_parseRFC822HeaderFields]):
1426         (-[NSData _web_startsWithBlankLine]):
1427         (-[NSData _web_locationAfterFirstBlankLine]):
1428         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1429           type to Objective-C++.  This fixes the warnings about
1430           discarding the `const` modifier when casing from CFStringRef
1431           to NSString * because in older clang versions, -Wcast-qual was
1432           completely broken when compiling C++ and Objective-C++ source
1433           files.  In newer clang versions, discarding the `const`
1434           modifier for toll-free bridged types is ignored when compiling
1435           Objective-C++ source.
1436         - Update copyright and license header.
1437         - Use reinterpret_cast<> and static_cast<> to fix warnings
1438           unrelated to (NSString *) C-style casts.
1439         - Replace use of MIN() macro with std::min<> template functions.
1440         - Fix location of `*` for local variables modified above.
1441         * Plugins/Hosted/NetscapePluginHostManager.mm:
1442         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1443         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1444         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1445         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1446           warnings.
1447         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1448         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1449         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1450           to fix warning.
1451         * Plugins/Hosted/ProxyInstance.mm:
1452         (WebKit::ProxyInstance::invoke):
1453         - Use static_cast<char*>(const_cast<void*>()) to fix
1454           warning when using -[NSData bytes].
1455         (WebKit::ProxyInstance::fieldValue const):
1456         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1457           to fix warning when using CFDataGetBytePtr().
1458         * Plugins/Hosted/WebTextInputWindowController.m:
1459         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1460         - Use #pragma to ignore -Wcast-qual warning since there
1461           is not a good way to avoid this warning in Objective-C.
1462         * Plugins/WebNetscapePluginStream.mm:
1463         (WebNetscapePluginStream::deliverData):
1464         - Use const_cast<void*>() to fix warning when using
1465           -[NSData bytes].
1466         * Plugins/WebNetscapePluginView.mm:
1467         (-[WebNetscapePluginView _createPlugin]):
1468         - Change C-style cast to const_cast<char*>() to fix
1469           warning.
1470         * WebCoreSupport/WebChromeClient.mm:
1471         (WebChromeClient::wrapCryptoKey const):
1472         (WebChromeClient::unwrapCryptoKey const):
1473         - Change C-style cast to
1474           static_cast<uint8_t*>(const_cast<void*>() to fix
1475           warning.
1476         * WebView/WebPDFView.mm:
1477         (_applicationInfoForMIMEType):
1478         - Change local variable type from 'NSURL *' to
1479           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1480           when calling -[NSURL path].
1481
1482 2018-01-05  Dan Bernstein  <mitz@apple.com>
1483
1484         Fixed the build following AppKit API deprecations in a recent SDKs
1485
1486         * WebView/WebFullScreenController.mm:
1487         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1488         (-[WebFullScreenController exitFullScreen]): Ditto.
1489         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1490         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1491         * WebView/WebHTMLView.mm:
1492         (-[WebHTMLView drawRect:]): Ditto.
1493         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1494         (-[WebHTMLView knowsPageRange:]): Ditto.
1495         * WebView/WebView.mm:
1496         (LayerFlushController::flushLayers): Ditto.
1497
1498 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1499
1500         [Attachment Support] Create attachment elements when dropping files on iOS
1501         https://bugs.webkit.org/show_bug.cgi?id=181192
1502         <rdar://problem/36280945>
1503
1504         Reviewed by Tim Horton.
1505
1506         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1507
1508         * WebCoreSupport/WebPlatformStrategies.h:
1509         * WebCoreSupport/WebPlatformStrategies.mm:
1510         (WebPlatformStrategies::informationForItemAtIndex):
1511         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1512
1513 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1514
1515         [Attachment Support] Add plumbing for starting a drag with promised blob data
1516         https://bugs.webkit.org/show_bug.cgi?id=181201
1517
1518         Reviewed by Tim Horton.
1519
1520         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1521
1522         * WebCoreSupport/WebDragClient.h:
1523
1524 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1525
1526         Add a WebAuthentication runtime feature flag
1527         https://bugs.webkit.org/show_bug.cgi?id=181220
1528         <rdar://problem/36055305>
1529
1530         Reviewed by Brent Fulgham.
1531
1532         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1533
1534         * WebView/WebPreferenceKeysPrivate.h:
1535         * WebView/WebPreferences.mm:
1536         (+[WebPreferences initialize]):
1537         (-[WebPreferences webAuthenticationEnabled]):
1538         (-[WebPreferences setWebAuthenticationEnabled:]):
1539         (-[WebPreferences credentialManagementEnabled]): Deleted.
1540         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1541         * WebView/WebPreferencesPrivate.h:
1542         * WebView/WebView.mm:
1543         (-[WebView _preferencesChanged:]):
1544
1545 2017-12-22  Jeff Miller  <jeffm@apple.com>
1546
1547         Update user-visible copyright strings to include 2018
1548         https://bugs.webkit.org/show_bug.cgi?id=181141
1549
1550         Reviewed by Dan Bernstein.
1551
1552         * Info.plist:
1553
1554 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1555
1556         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1557         https://bugs.webkit.org/show_bug.cgi?id=181188
1558
1559         Reviewed by Dan Bernstein.
1560
1561         See WebCore/ChangeLog for more detail.
1562
1563         * WebCoreSupport/WebDragClient.h:
1564         * WebCoreSupport/WebDragClient.mm:
1565         (WebDragClient::declareAndWriteAttachment): Deleted.
1566         * WebView/WebHTMLView.mm:
1567         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1568
1569 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1570
1571         Unreviewed, continue to fix build failures due to AppKit API deprecation
1572
1573         Wraps more code in -Wdeprecated-declarations.
1574
1575         * Carbon/HIWebView.mm:
1576         (overrideCGContext):
1577
1578 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1579
1580         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1581
1582         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1583
1584         * Carbon/CarbonWindowAdapter.mm:
1585         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1586         * Plugins/WebNetscapePluginView.mm:
1587         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1588         (-[WebNetscapePluginView sendDrawRectEvent:]):
1589         (-[WebNetscapePluginView drawRect:]):
1590
1591 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1592
1593         Fix build failures due to using deprecated AppKit symbols
1594         https://bugs.webkit.org/show_bug.cgi?id=181110
1595         <rdar://problem/36162865>
1596
1597         Reviewed by Dan Bernstein and Tim Horton.
1598
1599         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1600
1601         * Misc/WebKitNSStringExtras.mm:
1602         (-[NSString _web_drawAtPoint:font:textColor:]):
1603         * Misc/WebNSPasteboardExtras.h:
1604         * Misc/WebNSPasteboardExtras.mm:
1605         (+[NSPasteboard _web_writableTypesForURL]):
1606         (_createWritableTypesForImageWithoutArchive):
1607         (_createWritableTypesForImageWithArchive):
1608         (+[NSPasteboard _web_dragTypesForURL]):
1609         (-[NSPasteboard _web_bestURL]):
1610         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1611         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1612         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1613         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1614         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1615         * Panels/WebAuthenticationPanel.m:
1616         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1617         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1618         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1619         (-[WebHostedNetscapePluginView drawRect:]):
1620         * WebInspector/WebNodeHighlightView.mm:
1621         (-[WebNodeHighlightView drawRect:]):
1622         * WebView/WebFrame.mm:
1623         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1624         (-[WebFrame _drawRect:contentsOnly:]):
1625         * WebView/WebHTMLView.mm:
1626         (kit):
1627         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1628         (-[WebHTMLView _plainTextFromPasteboard:]):
1629         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1630         (+[WebHTMLView _insertablePasteboardTypes]):
1631         (+[WebHTMLView _selectionPasteboardTypes]):
1632         (-[WebHTMLView pasteboard:provideDataForType:]):
1633         (-[WebHTMLView _writeSelectionToPasteboard:]):
1634         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1635         (-[WebHTMLView validRequestorForSendType:returnType:]):
1636         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1637         (createMenuItem):
1638         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1639         (-[WebHTMLView _colorAsString:]):
1640         (-[WebHTMLView copyFont:]):
1641         * WebView/WebPDFView.mm:
1642         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1643         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1644         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1645         (-[WebPDFView pasteboardTypesForSelection]):
1646         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1647         * WebView/WebView.h:
1648         * WebView/WebView.mm:
1649         (-[WebView performDragOperation:]):
1650         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1651         (-[WebView _searchWithGoogleFromMenu:]):
1652
1653 2017-12-21  Youenn Fablet  <youenn@apple.com>
1654
1655         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1656         https://bugs.webkit.org/show_bug.cgi?id=181000
1657
1658         Reviewed by Chris Dumez.
1659
1660         * Misc/WebCache.mm:
1661         (+[WebCache addImageToCache:forURL:forFrame:]):
1662
1663 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1664
1665         Update FULLSCREEN_API feature defines.
1666         https://bugs.webkit.org/show_bug.cgi?id=181015
1667
1668         Reviewed by Tim Horton.
1669
1670         Change enabled iphone sdk for FULLSCREEN_API.
1671
1672         * Configurations/FeatureDefines.xcconfig:
1673
1674 2017-12-21  Jer Noble  <jer.noble@apple.com>
1675
1676         Add initial DOM support for Media Capabilities
1677         https://bugs.webkit.org/show_bug.cgi?id=181064
1678
1679         Reviewed by Eric Carlson.
1680
1681         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1682
1683         * WebView/WebPreferenceKeysPrivate.h:
1684         * WebView/WebPreferences.mm:
1685         (+[WebPreferences initialize]):
1686         (-[WebPreferences mediaCapabilitiesEnabled]):
1687         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1688         * WebView/WebPreferencesPrivate.h:
1689         * WebView/WebView.mm:
1690         (-[WebView _preferencesChanged:]):
1691
1692 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1693
1694         Enable picture-in-picture from inline element on suspend.
1695         https://bugs.webkit.org/show_bug.cgi?id=180942
1696         rdar://problem/34745234
1697
1698         Reviewed by Jer Noble.
1699
1700         Update signature of enterVideoFullscreenForVideoElement().
1701
1702         * WebCoreSupport/WebChromeClient.h:
1703         * WebCoreSupport/WebChromeClient.mm:
1704         (WebChromeClient::enterVideoFullscreenForVideoElement):
1705
1706 2017-12-20  Daniel Bates  <dabates@apple.com>
1707
1708         Remove Alternative Presentation Button
1709         https://bugs.webkit.org/show_bug.cgi?id=180500
1710         <rdar://problem/35891047>
1711
1712         Reviewed by Simon Fraser.
1713
1714         We no longer need the alternative presentation button.
1715
1716         * Configurations/FeatureDefines.xcconfig:
1717
1718 2017-12-19  Jer Noble  <jer.noble@apple.com>
1719
1720         Playing media elements which call "pause(); play()" will have the play promise rejected.
1721         https://bugs.webkit.org/show_bug.cgi?id=180781
1722         <rdar://problem/33191377>
1723
1724         Reviewed by Eric Carlson.
1725
1726         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1727
1728         * WebView/WebView.mm:
1729         (shouldRequireUserGestureToLoadVideo):
1730
1731 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1732
1733         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1734         https://bugs.webkit.org/show_bug.cgi?id=180977
1735
1736         Reviewed by Tim Horton.
1737
1738         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1739         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1740         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1741
1742         * WebCoreSupport/WebEditorClient.mm:
1743         (attributesForAttributedStringConversion):
1744         * WebView/WebHTMLView.mm:
1745         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1746
1747 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1748
1749         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1750
1751         Attempt to fix the following warnings:
1752
1753             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1754
1755         For the following instance variables:
1756
1757             _borderView
1758             _contentView
1759             _frame
1760             _wFlags
1761
1762         * Carbon/CarbonWindowAdapter.mm:
1763         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1764         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1765         (-[CarbonWindowAdapter _termWindowIfOwner]):
1766         (-[CarbonWindowAdapter _windowMovedToRect:]):
1767         (-[CarbonWindowAdapter setContentView:]):
1768         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1769         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1770
1771 2017-12-16  Dan Bernstein  <mitz@apple.com>
1772
1773         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1774         https://bugs.webkit.org/show_bug.cgi?id=180613
1775         <rdar://problem/35946124>
1776
1777         Reviewed by Geoff Garen.
1778
1779         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1780           clients.
1781         * WebView/WebDynamicScrollBarsView.h: Ditto.
1782         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1783
1784 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1785
1786         Enable -Wstrict-prototypes for WebKit
1787         <https://webkit.org/b/180757>
1788         <rdar://problem/36024132>
1789
1790         Rubber-stamped by Joseph Pecoraro.
1791
1792         * Configurations/Base.xcconfig:
1793         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1794
1795 2017-12-14  John Wilander  <wilander@apple.com>
1796
1797         Storage Access API: Implement frame-specific access in the document.cookie layer
1798         https://bugs.webkit.org/show_bug.cgi?id=180682
1799         <rdar://problem/35982257>
1800
1801         Reviewed by Alex Christensen.
1802
1803         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1804         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1805         CookiesStrategy::getRawCookies() now take optional parameters for
1806         frameID and pageID to allow frame-specific scoping of cookies.
1807
1808         This change makes the return values of FrameLoaderClient::frameID()
1809         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1810         WebCore can call those getters and get the right return values in
1811         WebKit and std:nullopt in WebKitLegacy.
1812
1813         * WebCoreSupport/WebFrameLoaderClient.h:
1814         * WebCoreSupport/WebFrameLoaderClient.mm:
1815         (WebFrameLoaderClient::pageID const):
1816         (WebFrameLoaderClient::frameID const):
1817         * WebCoreSupport/WebPlatformStrategies.h:
1818         * WebCoreSupport/WebPlatformStrategies.mm:
1819         (WebPlatformStrategies::cookiesForDOM):
1820         (WebPlatformStrategies::setCookiesFromDOM):
1821         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1822         (WebPlatformStrategies::getRawCookies):
1823
1824 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1825
1826         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1827         https://bugs.webkit.org/show_bug.cgi?id=180689
1828
1829         Reviewed by Tim Horton.
1830
1831         Use sRGBColorSpaceRef() from WebCore.
1832
1833         * WebView/WebHTMLView.mm:
1834         (imageFromRect):
1835
1836 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1837
1838         Stop using deprecated target conditional for simulator builds
1839         https://bugs.webkit.org/show_bug.cgi?id=180662
1840         <rdar://problem/35136156>
1841
1842         Reviewed by Simon Fraser.
1843
1844         * postprocess-headers.sh:
1845
1846 2017-12-11  David Quesada  <david_quesada@apple.com>
1847
1848         Turn on ENABLE_APPLICATION_MANIFEST
1849         https://bugs.webkit.org/show_bug.cgi?id=180562
1850         rdar://problem/35924737
1851
1852         Reviewed by Geoffrey Garen.
1853
1854         * Configurations/FeatureDefines.xcconfig:
1855
1856 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1857
1858         Remove pthread_once in favor of dispatch_once
1859         https://bugs.webkit.org/show_bug.cgi?id=180591
1860
1861         Reviewed by Saam Barati.
1862
1863         * Misc/WebKitErrors.m:
1864         (+[NSError _registerWebKitErrors]):
1865         (registerErrors): Deleted.
1866         * Storage/WebStorageManager.mm:
1867         (+[WebStorageManager _storageDirectoryPath]):
1868         (initializeLocalStoragePath): Deleted.
1869
1870 2017-12-07  Darin Adler  <darin@apple.com>
1871
1872         Remove some unused code from WebKitLegacy
1873         https://bugs.webkit.org/show_bug.cgi?id=180567
1874
1875         Reviewed by Anders Carlsson.
1876
1877         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1878         macOS (back a few versions) and iOS and removed unused
1879         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1880         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1881         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1882         _webkit_stringByCollapsingNonPrintingCharacters,
1883         _webkit_stringByCollapsingWhitespaceCharacters,
1884         _web_stringWithData:textEncodingName:, and
1885         _webkit_localStorageDirectoryWithBundleIdentifier:.
1886
1887         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1888         this source file.
1889         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1890         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1891         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1892         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1893         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1894         handle font smoothing options.
1895         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1896         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1897         from header and made it a little clearer.
1898         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1899         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1900         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1901         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1902         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1903         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1904         implementation a bit and used whole words instead of abbreviations.
1905         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1906
1907         * Misc/WebNSFileManagerExtras.mm:
1908         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1909         filenameByFixingIllegalCharacters function from WebCore directly instead of
1910         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1911
1912         * Plugins/WebBaseNetscapePluginView.mm:
1913         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1914         string replacements instead of _web_stringByStrippingReturnCharacters
1915         and to use NSString methods instead of CFString functions.
1916
1917 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1918
1919         Ignore deprecation warnings.
1920
1921         * WebView/WebHTMLView.mm:
1922         (-[NSWindow _web_borderView]):
1923         (-[WebHTMLView _setAsideSubviews]):
1924         * WebView/WebView.mm:
1925         (-[WebView encodeWithCoder:]):
1926
1927 2017-12-02  Darin Adler  <darin@apple.com>
1928
1929         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1930         https://bugs.webkit.org/show_bug.cgi?id=180009
1931
1932         Reviewed by Alex Christensen.
1933
1934         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1935
1936         * Plugins/WebBaseNetscapePluginView.mm:
1937         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1938         of strcasecmp.
1939
1940         * WebView/WebPreferences.mm:
1941         (contains): Ditto. Also made this a template so it's easier to call on an array.
1942         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1943
1944 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1945
1946         Limit user agent versioning to an upper bound
1947         https://bugs.webkit.org/show_bug.cgi?id=180365
1948         <rdar://problem/34550617>
1949
1950         Reviewed by Joseph Pecoraro.
1951
1952         * WebView/WebView.mm:
1953         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1954         creating the User Agent string.
1955         (webKitBundleVersionString): Deleted.
1956
1957 2017-12-05  Andy Estes  <aestes@apple.com>
1958
1959         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1960         https://bugs.webkit.org/show_bug.cgi?id=180457
1961         <rdar://problem/35143007>
1962
1963         Reviewed by Tim Horton.
1964
1965         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1966         check for this macro during post-processing.
1967
1968         * postprocess-headers.sh:
1969
1970 2017-12-04  David Quesada  <david_quesada@apple.com>
1971
1972         Add a class for parsing application manifests
1973         https://bugs.webkit.org/show_bug.cgi?id=177973
1974         rdar://problem/34747949
1975
1976         Reviewed by Geoffrey Garen.
1977
1978         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1979
1980 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1981
1982         Make LegacyCustomProtocolManager optional for network process
1983         https://bugs.webkit.org/show_bug.cgi?id=176230
1984
1985         Reviewed by Alex Christensen.
1986
1987         * Configurations/FeatureDefines.xcconfig:
1988
1989 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1990
1991         Fix some NSOperationQueue leaks
1992         https://bugs.webkit.org/show_bug.cgi?id=180221
1993
1994         Reviewed by Wenson Hsieh.
1995
1996         * WebView/WebView.mm:
1997         (-[WebView performDragOperation:]):
1998
1999 2017-11-30  Darin Adler  <darin@apple.com>
2000
2001         [Mac] remove unneeded RetainPtr use introduced in r225142
2002         https://bugs.webkit.org/show_bug.cgi?id=180202
2003
2004         Reviewed by Tim Horton.
2005
2006         * WebView/WebImmediateActionController.mm:
2007         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
2008         RetainPtr.
2009
2010 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
2011
2012         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
2013         https://bugs.webkit.org/show_bug.cgi?id=175595
2014
2015         Reviewed by Darin Adler.
2016
2017         * WebView/WebPreferences.mm:
2018
2019 2017-11-27  Tim Horton  <timothy_horton@apple.com>
2020
2021         One too many zeroes in macOS version number in FeatureDefines
2022         https://bugs.webkit.org/show_bug.cgi?id=180011
2023
2024         Reviewed by Dan Bernstein.
2025
2026         * Configurations/FeatureDefines.xcconfig:
2027
2028 2017-11-23  Darin Adler  <darin@apple.com>
2029
2030         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
2031         https://bugs.webkit.org/show_bug.cgi?id=179981
2032
2033         Reviewed by Sam Weinig.
2034
2035         * WebView/WebImmediateActionController.mm:
2036         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
2037         * WebView/WebView.mm:
2038         (coreOptions): Use |= instead of | to build up FindOptions.
2039
2040 2017-11-23  Sam Weinig  <sam@webkit.org>
2041
2042         Remove unneeded ScriptController::processingUserGesture() forwarding functions
2043         https://bugs.webkit.org/show_bug.cgi?id=179954
2044
2045         Reviewed by Darin Adler.
2046
2047         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
2048         with direct calls to the corresponding UserGestureIndicator functions.
2049
2050         * Plugins/WebPluginController.mm:
2051         (-[WebPluginController processingUserGesture]):
2052         * WebView/WebView.mm:
2053         (-[WebView _isProcessingUserGesture]):
2054
2055 2017-11-23  Darin Adler  <darin@apple.com>
2056
2057         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2058         https://bugs.webkit.org/show_bug.cgi?id=179907
2059
2060         Reviewed by Sam Weinig.
2061
2062         * History/BinaryPropertyList.cpp:
2063         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
2064         (BinaryPropertyListSerializer::appendStringObject): Ditto.
2065         * WebView/WebHTMLRepresentation.mm:
2066         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
2067         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
2068
2069 2017-11-22  Ali Juma  <ajuma@chromium.org>
2070
2071         Implement VisualViewport API attributes
2072         https://bugs.webkit.org/show_bug.cgi?id=179385
2073
2074         Reviewed by Frédéric Wang.
2075
2076         Add a VisualViewportAPI preference.
2077
2078         * WebView/WebPreferenceKeysPrivate.h:
2079         * WebView/WebPreferences.mm:
2080         (+[WebPreferences initialize]):
2081         (-[WebPreferences visualViewportAPIEnabled]):
2082         (-[WebPreferences setVisualViewportAPIEnabled:]):
2083         * WebView/WebPreferencesPrivate.h:
2084         * WebView/WebView.mm:
2085         (-[WebView _preferencesChanged:]):
2086
2087 2017-11-22  Christopher Reid  <chris.reid@sony.com>
2088
2089         WebCoreObjCExtras.h is being included in too many places
2090         https://bugs.webkit.org/show_bug.cgi?id=179931
2091
2092         Reviewed by Darin Adler.
2093
2094         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2095         * Plugins/WebBaseNetscapePluginView.mm:
2096         * Plugins/WebBasePluginPackage.mm:
2097         * Plugins/WebNetscapePluginStream.mm:
2098         * Plugins/WebNetscapePluginView.mm:
2099         * WebView/WebTextIterator.mm:
2100         * WebView/WebViewData.mm:
2101
2102 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2103
2104         Unreviewed, rolling out r225093.
2105         https://bugs.webkit.org/show_bug.cgi?id=179938
2106
2107         Compilation failed on WinCairo 64-bit Release (Requested by
2108         fredw on #webkit).
2109
2110         Reverted changeset:
2111
2112         "Implement VisualViewport API attributes"
2113         https://bugs.webkit.org/show_bug.cgi?id=179385
2114         https://trac.webkit.org/changeset/225093
2115
2116 2017-11-21  Ali Juma  <ajuma@chromium.org>
2117
2118         Implement VisualViewport API attributes
2119         https://bugs.webkit.org/show_bug.cgi?id=179385
2120
2121         Reviewed by Frédéric Wang.
2122
2123         Add a VisualViewportAPI preference.
2124
2125         * WebView/WebPreferenceKeysPrivate.h:
2126         * WebView/WebPreferences.mm:
2127         (+[WebPreferences initialize]):
2128         (-[WebPreferences visualViewportAPIEnabled]):
2129         (-[WebPreferences setVisualViewportAPIEnabled:]):
2130         * WebView/WebPreferencesPrivate.h:
2131         * WebView/WebView.mm:
2132         (-[WebView _preferencesChanged:]):
2133
2134 2017-11-21  Christopher Reid  <chris.reid@sony.com>
2135
2136         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
2137         https://bugs.webkit.org/show_bug.cgi?id=179504
2138
2139         Reviewed by Darin Adler.
2140
2141         * Misc/WebKitNSStringExtras.mm:
2142         * Plugins/Hosted/NetscapePluginHostManager.mm:
2143         * Plugins/WebBasePluginPackage.mm:
2144
2145 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2146
2147         Remove unused TOUCH_ICON_LOADING feature flag
2148         https://bugs.webkit.org/show_bug.cgi?id=179873
2149
2150         Reviewed by Simon Fraser.
2151
2152         * Configurations/FeatureDefines.xcconfig:
2153
2154 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2155
2156         Remove unused LEGACY_VENDOR_PREFIXES feature flag
2157         https://bugs.webkit.org/show_bug.cgi?id=179872
2158
2159         Reviewed by Darin Adler.
2160
2161         * Configurations/FeatureDefines.xcconfig:
2162
2163 2017-11-16  Daniel Bates  <dabates@apple.com>
2164
2165         Add feature define for alternative presentation button element
2166         https://bugs.webkit.org/show_bug.cgi?id=179692
2167         Part of <rdar://problem/34917108>
2168
2169         Reviewed by Andy Estes.
2170
2171         Only enabled on Cocoa platforms by default.
2172
2173         * Configurations/FeatureDefines.xcconfig:
2174
2175 2017-11-14  Nan Wang  <n_wang@apple.com>
2176
2177         AX: AOM: Implement AccessibleNode class and support label and role attributes
2178         https://bugs.webkit.org/show_bug.cgi?id=179494
2179
2180         Reviewed by Ryosuke Niwa.
2181
2182         * WebView/WebPreferenceKeysPrivate.h:
2183         * WebView/WebPreferences.mm:
2184         (+[WebPreferences initialize]):
2185         (-[WebPreferences accessibilityObjectModelEnabled]):
2186         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
2187         * WebView/WebPreferencesPrivate.h:
2188         * WebView/WebView.mm:
2189         (-[WebView _preferencesChanged:]):
2190
2191 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2192
2193         Remove Cocoa CFURLConnection loading code
2194         https://bugs.webkit.org/show_bug.cgi?id=179688
2195
2196         Reviewed by Antti Koivisto.
2197
2198         * Misc/WebDownload.mm:
2199         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2200         * Misc/WebDownloadInternal.h:
2201         * Plugins/WebBaseNetscapePluginView.mm:
2202         * WebCoreSupport/WebFrameLoaderClient.mm:
2203         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2204         * WebView/WebView.mm:
2205         (-[WebView scheduleInRunLoop:forMode:]):
2206         (-[WebView unscheduleFromRunLoop:forMode:]):
2207
2208 2017-11-14  Daniel Bates  <dabates@apple.com>
2209
2210         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
2211         for feature defines
2212
2213         Following r195498 and r201917 the Visual Studio property files for feature defines have
2214         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2215         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2216         files.
2217
2218         * Configurations/FeatureDefines.xcconfig:
2219
2220 2017-11-14  Jer Noble  <jer.noble@apple.com>
2221
2222         Enable Modern EME tests in DumpRenderTree
2223         https://bugs.webkit.org/show_bug.cgi?id=179544
2224
2225         Reviewed by Alex Christensen.
2226
2227         Add a WebPreferences property to enable the (modern) EME API.
2228
2229         * WebView/WebPreferenceKeysPrivate.h:
2230         * WebView/WebPreferences.mm:
2231         (+[WebPreferences initialize]):
2232         (-[WebPreferences encryptedMediaAPIEnabled]):
2233         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2234         * WebView/WebPreferencesPrivate.h:
2235         * WebView/WebView.mm:
2236         (-[WebView _preferencesChanged:]):
2237
2238 2017-11-14  Antti Koivisto  <antti@apple.com>
2239
2240         Enable display:contents by default
2241         https://bugs.webkit.org/show_bug.cgi?id=179655
2242
2243         Reviewed by Sam Weinig.
2244
2245         * WebView/WebPreferences.mm:
2246         (+[WebPreferences initialize]):
2247
2248 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2249
2250         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2251         https://bugs.webkit.org/show_bug.cgi?id=178751
2252
2253         Reviewed by Brady Eidson.
2254
2255         * WebCoreSupport/WebFrameNetworkingContext.mm:
2256         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2257
2258 2017-11-08  Keith Miller  <keith_miller@apple.com>
2259
2260         Async iteration should only fetch the next method once and add feature flag
2261         https://bugs.webkit.org/show_bug.cgi?id=179451
2262
2263         Reviewed by Geoffrey Garen.
2264
2265         Add feature flag for Async iteration.
2266
2267         * Configurations/FeatureDefines.xcconfig:
2268
2269 2017-11-13  Mark Lam  <mark.lam@apple.com>
2270
2271         Add more overflow check book-keeping for MarkedArgumentBuffer.
2272         https://bugs.webkit.org/show_bug.cgi?id=179634
2273         <rdar://problem/35492517>
2274
2275         Reviewed by Saam Barati.
2276
2277         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2278         (WebKit::NetscapePluginInstanceProxy::invoke):
2279         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2280         (WebKit::NetscapePluginInstanceProxy::construct):
2281
2282 2017-11-12  Darin Adler  <darin@apple.com>
2283
2284         More is<> and downcast<>, less static_cast<>
2285         https://bugs.webkit.org/show_bug.cgi?id=179600
2286
2287         Reviewed by Chris Dumez.
2288
2289         * DOM/DOM.mm:
2290         (kit): Use is/downcast.
2291         * WebCoreSupport/WebEditorClient.mm:
2292         (WebEditorClient::handleKeyboardEvent): Ditto.
2293         (WebEditorClient::handleInputMethodKeydown): Ditto.
2294         * WebView/WebHTMLView.mm:
2295         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2296
2297 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2298
2299         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2300         https://bugs.webkit.org/show_bug.cgi?id=179397
2301
2302         Reviewed by Wenson Hsieh.
2303
2304         * DOM/DOMHTMLInputElement.mm:
2305         (-[DOMHTMLInputElement insertTextSuggestion:]):
2306
2307 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2308
2309         HTMLMediaElement should not use element fullscreen on iOS
2310         https://bugs.webkit.org/show_bug.cgi?id=179418
2311         rdar://problem/35409277
2312
2313         Reviewed by Eric Carlson.
2314
2315         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2316
2317         * Configurations/FeatureDefines.xcconfig:
2318
2319 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2320
2321         Make ResourceLoader::willSendRequestInternal asynchronous
2322         https://bugs.webkit.org/show_bug.cgi?id=179251
2323
2324         Reviewed by Andy Estes.
2325
2326         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2327         (WebKit::HostedNetscapePluginStream::start):
2328         * Plugins/WebNetscapePluginStream.mm:
2329         (WebNetscapePluginStream::start):
2330
2331 2017-11-01  Darin Adler  <darin@apple.com>
2332
2333         Simplify event dispatch code and make it a bit more consistent
2334         https://bugs.webkit.org/show_bug.cgi?id=178991
2335
2336         Reviewed by Chris Dumez.
2337
2338         * DOM/DOMEvent.mm:
2339         (-[DOMEvent srcElement]): Call target instead of srcElement.
2340
2341 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2342
2343         [Touch Bar Web API] Add support for menuitem tag
2344         https://bugs.webkit.org/show_bug.cgi?id=179020
2345
2346         Reviewed by Ryosuke Niwa.
2347
2348         Adds in properties and methods that allow the menuitem runtime feature
2349         to be enabled or disabled.
2350
2351         * WebView/WebPreferenceKeysPrivate.h:
2352         * WebView/WebPreferences.mm:
2353         (-[WebPreferences menuItemElementEnabled]):
2354         (-[WebPreferences setMenuItemElementEnabled:]):
2355         * WebView/WebPreferencesPrivate.h:
2356         * WebView/WebView.mm:
2357         (-[WebView _preferencesChanged:]):
2358
2359 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2360
2361         Use CompletionHandlers for redirects
2362         https://bugs.webkit.org/show_bug.cgi?id=179163
2363
2364         Reviewed by Tim Horton.
2365
2366         * Plugins/Hosted/HostedNetscapePluginStream.h:
2367         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2368         (WebKit::HostedNetscapePluginStream::willSendRequest):
2369         * Plugins/WebNetscapePluginStream.h:
2370         * Plugins/WebNetscapePluginStream.mm:
2371         (WebNetscapePluginStream::willSendRequest):
2372
2373 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2374
2375         Add a FileSystem namespace to FileSystem.cpp
2376         https://bugs.webkit.org/show_bug.cgi?id=179063
2377
2378         Reviewed by Darin Adler.
2379
2380         * Misc/WebNSFileManagerExtras.mm:
2381         * Storage/WebDatabaseProvider.mm:
2382
2383 2017-11-02  Frederic Wang  <fwang@igalia.com>
2384
2385         Add references to bug 179167 in FIXME comments
2386         https://bugs.webkit.org/show_bug.cgi?id=179168
2387
2388         Reviewed by Daniel Bates.
2389
2390         * Configurations/FeatureDefines.xcconfig:
2391
2392 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2393
2394         Implement WKFullscreenWindowController for iOS.
2395         https://bugs.webkit.org/show_bug.cgi?id=178924
2396         rdar://problem/34697120
2397
2398         Reviewed by Simon Fraser.
2399
2400         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2401
2402         * Configurations/FeatureDefines.xcconfig:
2403         * WebView/WebView.mm:
2404         (-[WebView fullScreenPlaceholderView]):
2405
2406 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2407
2408         Clean up some drag and drop feature flags
2409         https://bugs.webkit.org/show_bug.cgi?id=179082
2410
2411         Reviewed by Simon Fraser.
2412
2413         * Configurations/FeatureDefines.xcconfig:
2414
2415 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2416
2417         Make it possible to test rubber-banding in overflow scroll
2418         https://bugs.webkit.org/show_bug.cgi?id=179078
2419
2420         Reviewed by Sam Weinig.
2421
2422         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2423         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2424
2425         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2426         functions, since most callers want clamped.
2427
2428         * DOM/DOMHTML.mm:
2429         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2430
2431 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2432
2433         Fix up some content filtering feature flags
2434         https://bugs.webkit.org/show_bug.cgi?id=179079
2435
2436         Reviewed by Simon Fraser.
2437
2438         * Configurations/FeatureDefines.xcconfig:
2439
2440 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2441
2442         [FrameView::layout cleanup] Move core layout logic to a separate class.
2443         https://bugs.webkit.org/show_bug.cgi?id=178771
2444         <rdar://problem/35166542>
2445
2446         Reviewed by Simon Fraser.
2447
2448         Move layout code out from FrameView to LayoutContext.
2449
2450         * WebView/WebClipView.mm:
2451         (-[WebClipView _immediateScrollToPoint:]):
2452         * WebView/WebFrame.mm:
2453         (-[WebFrame layoutCount]):
2454
2455 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2456
2457         Fix issues with WebView subframe painting
2458         https://bugs.webkit.org/show_bug.cgi?id=178842
2459         rdar://problem/34072253
2460
2461         Reviewed by Daniel Bates.
2462         
2463         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2464         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2465         High Sierra, so match the new signature.
2466
2467         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2468
2469         * WebView/WebHTMLView.mm:
2470         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2471         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2472
2473 2017-10-25  Youenn Fablet  <youenn@apple.com>
2474
2475         Enable ServiceWorker to fetch resources
2476         https://bugs.webkit.org/show_bug.cgi?id=178673
2477
2478         Reviewed by Brady Eidson.
2479
2480         * WebCoreSupport/WebFrameLoaderClient.mm:
2481         (WebFrameLoaderClient::pageID const):
2482         (WebFrameLoaderClient::frameID const):
2483         (WebFrameLoaderClient::sessionID const):
2484
2485         Added implementation to the new getters.
2486         They are noop in the context of WK1.
2487
2488 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2489
2490         Web Inspector: Enable WebKit logging configuration and display
2491         https://bugs.webkit.org/show_bug.cgi?id=177027
2492         <rdar://problem/33964767>
2493
2494         Reviewed by Joseph Pecoraro.
2495
2496         * WebCoreSupport/WebChromeClient.mm:
2497         (stringForMessageSource): Deal with Media and WebRTC message sources.
2498
2499 2017-10-20  Antoine Quint  <graouts@apple.com>
2500
2501         [Web Animations] Provide basic timeline and animation interfaces
2502         https://bugs.webkit.org/show_bug.cgi?id=178526
2503
2504         Reviewed by Dean Jackson.
2505
2506         Remove the WEB_ANIMATIONS compile-time flag.
2507
2508         * Configurations/FeatureDefines.xcconfig:
2509         * WebView/WebPreferences.mm:
2510         (+[WebPreferences initialize]):
2511         * WebView/WebView.mm:
2512         (-[WebView _preferencesChanged:]):
2513
2514 2017-10-19  Sam Weinig  <sam@webkit.org>
2515
2516         [Settings] Move global settings into their own file
2517         https://bugs.webkit.org/show_bug.cgi?id=178512
2518
2519         Reviewed by Darin Adler.
2520
2521         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2522
2523         * WebCoreSupport/WebChromeClient.mm:
2524         (WebChromeClient::supportsVideoFullscreen):
2525         * WebView/WebDynamicScrollBarsView.mm:
2526         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2527         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2528         * WebView/WebPreferences.mm:
2529         (+[WebPreferences initialize]):
2530         * WebView/WebView.mm:
2531         (-[WebView _commonInitializationWithFrameName:groupName:]):
2532         (-[WebView _preferencesChanged:]):
2533         (+[WebView _doNotStartObservingNetworkReachability]):
2534
2535 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2536
2537         Replace some stack raw pointers with RefPtrs within WebCore/html
2538         https://bugs.webkit.org/show_bug.cgi?id=178201
2539         <rdar://problem/34841692>
2540
2541         Reviewed by Ryosuke Niwa.
2542
2543         * DOM/DOM.mm:
2544         (kit):
2545         Change the type of node as toNode() is changed to return RefPtr.
2546
2547 2017-10-18  Chris Dumez  <cdumez@apple.com>
2548
2549         [Service Worker] Add stubs for Client / WindowClient / Clients
2550         https://bugs.webkit.org/show_bug.cgi?id=178469
2551
2552         Reviewed by Youenn Fablet.
2553
2554         Rename PageVisiblityState to VisibilityState.
2555
2556         * WebView/WebView.mm:
2557         (kit):
2558
2559 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2560
2561         Unreviewed, rolling out r223291.
2562
2563         See WebCore ChangeLog for more detail.
2564
2565         Reverted changeset:
2566
2567         "Remove Editor::simplifyMarkup"
2568         https://bugs.webkit.org/show_bug.cgi?id=178271
2569         https://trac.webkit.org/changeset/223291
2570
2571 2017-10-17  Keith Miller  <keith_miller@apple.com>
2572
2573         Change WebCore sources to work with unified source builds
2574         https://bugs.webkit.org/show_bug.cgi?id=178229
2575
2576         Rubber stamped by Tim Horton.
2577
2578         * Configurations/FeatureDefines.xcconfig:
2579
2580 2017-10-16  Sam Weinig  <sam@webkit.org>
2581
2582         [Settings] Remove all custom code from Settings.h/cpp
2583         https://bugs.webkit.org/show_bug.cgi?id=178330
2584
2585         Reviewed by Simon Fraser.
2586
2587         * WebView/WebPreferences.mm:
2588         (+[WebPreferences initialize]):
2589         
2590             Update for naming changes of FrameFlattening now that it is an enum class.
2591
2592 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2593
2594         Remove Editor::simplifyMarkup
2595         https://bugs.webkit.org/show_bug.cgi?id=178271
2596
2597         Reviewed by Wenson Hsieh.
2598
2599         * WebView/WebView.mm:
2600         (-[WebView _simplifyMarkup:endNode:]):
2601
2602 2017-10-12  Chris Dumez  <cdumez@apple.com>
2603
2604         [Mac] Add support for MouseEvent.buttons
2605         https://bugs.webkit.org/show_bug.cgi?id=178214
2606
2607         Reviewed by Ryosuke Niwa.
2608
2609         * WebView/WebPDFView.mm:
2610         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2611
2612 2017-10-11  Sam Weinig  <sam@webkit.org>
2613
2614         Remove out-parameter variants of copyToVector
2615         https://bugs.webkit.org/show_bug.cgi?id=178155
2616
2617         Reviewed by Tim Horton.
2618
2619         * Plugins/WebNetscapePluginView.mm:
2620         (-[WebNetscapePluginView destroyPlugin]):
2621         * WebView/WebHTMLRepresentation.mm:
2622         (newArrayWithStrings):
2623
2624             Replace out-parameter based copyToVector, with one that returns a Vector.
2625
2626 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2627
2628         Sanitize URL in pasteboard for other applications and cross origin content
2629         https://bugs.webkit.org/show_bug.cgi?id=178060
2630         <rdar://problem/34874518>
2631
2632         Reviewed by Wenson Hsieh.
2633
2634         * WebCoreSupport/WebPlatformStrategies.h:
2635         * WebCoreSupport/WebPlatformStrategies.mm:
2636         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2637
2638 2017-10-11  Chris Dumez  <cdumez@apple.com>
2639
2640         Modernize Geolocation code
2641         https://bugs.webkit.org/show_bug.cgi?id=178148
2642
2643         Reviewed by Ryosuke Niwa.
2644
2645         * WebCoreSupport/WebGeolocationClient.h:
2646         * WebCoreSupport/WebGeolocationClient.mm:
2647         (WebGeolocationClient::lastPosition):
2648         * WebView/WebGeolocationPosition.mm:
2649         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2650         (core):
2651         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2652         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2653         * WebView/WebGeolocationPositionInternal.h:
2654
2655 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2656
2657         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2658         https://bugs.webkit.org/show_bug.cgi?id=178154
2659
2660         Reviewed by Wenson Hsieh.
2661
2662         Enable custom pasteboard data by default.
2663
2664         * WebView/WebPreferenceKeysPrivate.h:
2665         * WebView/WebPreferences.mm:
2666         (+[WebPreferences initialize]):
2667         (-[WebPreferences customPasteboardDataEnabled]): Added.
2668         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2669         * WebView/WebPreferencesPrivate.h:
2670         * WebView/WebView.mm:
2671         (-[WebView _preferencesChanged:]):
2672
2673 2017-10-10  Sam Weinig  <sam@webkit.org>
2674
2675         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2676         https://bugs.webkit.org/show_bug.cgi?id=178102
2677
2678         Reviewed by Tim Horton.
2679
2680         * History/WebHistory.mm:
2681         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2682         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2683         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2684         * WebCoreSupport/WebUserMediaClient.mm:
2685         (WebUserMediaClient::pageDestroyed):
2686
2687 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2688
2689         Make the names of the options consistent
2690         https://bugs.webkit.org/show_bug.cgi?id=177933
2691
2692         Reviewed by Saam Barati.
2693
2694         * WebView/WebFrame.h:
2695         * WebView/WebHTMLView.mm:
2696         (-[WebHTMLView setMarkedText:selectedRange:]):
2697         * WebView/WebView.h:
2698
2699 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2700
2701         [iOS] Tweak support for classifying form controls (followup to r222487)
2702         https://bugs.webkit.org/show_bug.cgi?id=177917
2703         <rdar://problem/34820122>
2704
2705         Reviewed by Dean Jackson.
2706
2707         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2708
2709         * DOM/DOMHTMLInputElement.mm:
2710         (-[DOMHTMLInputElement _autofillContext]):
2711         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2712         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2713
2714 2017-10-05  Keith Miller  <keith_miller@apple.com>
2715
2716         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2717
2718         * Configurations/WebKitLegacy.xcconfig:
2719
2720 2017-10-05  Jer Noble  <jer.noble@apple.com>
2721
2722         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2723         https://bugs.webkit.org/show_bug.cgi?id=177261
2724
2725         Reviewed by Eric Carlson.
2726
2727         * Configurations/FeatureDefines.xcconfig:
2728
2729 2017-10-05  Chris Dumez  <cdumez@apple.com>
2730
2731         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2732         https://bugs.webkit.org/show_bug.cgi?id=177957
2733
2734         Reviewed by Alex Christensen.
2735
2736         * WebCoreSupport/WebPlatformStrategies.h:
2737         * WebCoreSupport/WebPlatformStrategies.mm:
2738         (WebPlatformStrategies::cookiesEnabled):
2739
2740 2017-10-05  Youenn Fablet  <youenn@apple.com>
2741
2742         Make LibWebRTCProvider port agnostic
2743         https://bugs.webkit.org/show_bug.cgi?id=177747
2744
2745         Reviewed by Alex Christensen & Alex Garcia.
2746
2747         * WebView/WebView.mm:
2748         (-[WebView _commonInitializationWithFrameName:groupName:]):
2749         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2750
2751 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2752
2753         Stop linking with WebKitSystemInterface
2754         https://bugs.webkit.org/show_bug.cgi?id=177915
2755
2756         Reviewed by Antti Koivisto.
2757
2758         * Configurations/DebugRelease.xcconfig:
2759         * Configurations/WebKitLegacy.xcconfig:
2760
2761 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2762
2763         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2764         https://bugs.webkit.org/show_bug.cgi?id=177912
2765
2766         Reviewed by Saam Barati.
2767
2768         * Carbon/CarbonUtils.m:
2769         * Carbon/CarbonWindowAdapter.mm:
2770         * Carbon/HIWebView.mm:
2771         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2772         * Misc/WebNSFileManagerExtras.mm:
2773         * Misc/WebNSPasteboardExtras.mm:
2774         * Misc/WebNSURLExtras.mm:
2775         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2776         * Plugins/Hosted/NetscapePluginHostManager.mm:
2777         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2778         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2779         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2780         * Plugins/Hosted/WebTextInputWindowController.m:
2781         * Plugins/WebBaseNetscapePluginView.mm:
2782         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2783         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2784         * Plugins/WebNetscapePluginStream.mm:
2785         * Plugins/WebNetscapePluginView.mm:
2786         * Plugins/WebPluginDatabase.mm:
2787         * WebCoreSupport/PopupMenuMac.mm:
2788         * WebCoreSupport/WebChromeClient.mm:
2789         * WebCoreSupport/WebFrameLoaderClient.mm:
2790         * WebCoreSupport/WebInspectorClient.mm:
2791         * WebCoreSupport/WebPlatformStrategies.mm:
2792         * WebCoreSupport/WebSystemInterface.mm:
2793         * WebView/WebDynamicScrollBarsView.mm:
2794         * WebView/WebFrame.mm:
2795         * WebView/WebFrameView.mm:
2796         * WebView/WebFullScreenController.mm:
2797         * WebView/WebHTMLView.mm:
2798         * WebView/WebPreferences.mm:
2799         * WebView/WebView.mm:
2800
2801 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2802
2803         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2804         rdar://problem/34705779
2805
2806         Addressing review comments that I somehow landed without.
2807
2808         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2809
2810 2017-09-29  Chris Dumez  <cdumez@apple.com>
2811
2812         Split some logic out of VisitedLinkStore and make it reusable
2813         https://bugs.webkit.org/show_bug.cgi?id=177575
2814
2815         Reviewed by Alex Christensen.
2816
2817         * WebCoreSupport/WebVisitedLinkStore.h:
2818         * WebCoreSupport/WebVisitedLinkStore.mm:
2819         (WebVisitedLinkStore::addVisitedLink):
2820         (WebVisitedLinkStore::removeVisitedLink):
2821         (WebVisitedLinkStore::isLinkVisited):
2822         (WebVisitedLinkStore::addVisitedLinkHash):
2823
2824 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2825
2826         Build fix for High Sierra 32 bit Mac
2827         https://bugs.webkit.org/show_bug.cgi?id=177551
2828         <rdar://problem/34690283>
2829
2830         Reviewed by Alexey Proskuryakov.
2831
2832         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2833         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2834         also made.
2835
2836         * Carbon/CarbonWindowAdapter.mm:
2837         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2838         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2839         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2840         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2841         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2842         (-[CarbonWindowAdapter dealloc]):
2843         (-[CarbonWindowAdapter windowRef]):
2844         (-[CarbonWindowAdapter _hasWindowRef]):
2845         (-[CarbonWindowAdapter _managesWindowRef]):
2846         (-[CarbonWindowAdapter _removeWindowRef]):
2847         (-[CarbonWindowAdapter _carbonWindowClass]):
2848         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2849         (-[CarbonWindowAdapter sendSuperEvent:]):
2850         (-[CarbonWindowAdapter relinquishFocus]):
2851         (-[CarbonWindowAdapter _cancelKey:]):
2852         (-[CarbonWindowAdapter _commonAwake]):
2853         (-[CarbonWindowAdapter _destroyRealWindow:]):
2854         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2855         (-[CarbonWindowAdapter _termWindowIfOwner]):
2856         (-[CarbonWindowAdapter _windowMovedToRect:]):
2857         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2858         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2859         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2860         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2861         (-[CarbonWindowAdapter canBecomeMainWindow]):
2862         (-[CarbonWindowAdapter encodeWithCoder:]):
2863         (-[CarbonWindowAdapter initWithCoder:]):
2864         (-[CarbonWindowAdapter setContentView:]):
2865         (-[CarbonWindowAdapter worksWhenModal]):
2866         (-[CarbonWindowAdapter _setModalWindowLevel]):
2867         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2868         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2869         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2870         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2871         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2872         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2873         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2874         (NSCarbonWindowHandleEvent):
2875         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2876         (-[CarbonWindowAdapter _growBoxRect]):
2877         * Carbon/HIWebView.mm:
2878         (HIWebViewGetWebView):
2879         (HIWebViewConstructor):
2880         (HIWebViewDestructor):
2881         (HIWebViewRegisterClass):
2882         (GetBehaviors):
2883         (Draw):
2884         (HitTest):
2885         (GetRegion):
2886         (GetWindowRef):
2887         (CreateNSEventAdoptingCGEvent):
2888         (CopyEventCGEvent):
2889         (CreateNSEventWithCarbonClickEvent):
2890         (Click):
2891         (CreateNSEventWithCarbonEvent):
2892         (MouseUp):
2893         (CreateNSEventWithCarbonMouseMoveEvent):
2894         (MouseMoved):
2895         (MouseDragged):
2896         (MouseWheelMoved):
2897         (ContextMenuClick):
2898         (GetKind):
2899         (BoundsChanged):
2900         (OwningWindowChanged):
2901         (WindowHandler):
2902         (SyncFrame):
2903         (SetFocusPart):
2904         (AdvanceFocus):
2905         (RelinquishFocus):
2906         (ActiveStateChanged):
2907         (ProcessCommand):
2908         (UpdateCommandStatus):
2909         (_NSSelectorForHICommand):
2910         (HIWebViewEventHandler):
2911         (StartUpdateObserver):
2912         (StopUpdateObserver):
2913         (UpdateObserver):
2914
2915 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2916
2917         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2918         https://bugs.webkit.org/show_bug.cgi?id=172526
2919         <rdar://problem/32396081>
2920
2921         Reviewed by Ryosuke Niwa.
2922
2923         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2924
2925         * WebCoreSupport/WebPlatformStrategies.h:
2926         * WebCoreSupport/WebPlatformStrategies.mm:
2927         (WebPlatformStrategies::webExposedTypes):
2928         (WebPlatformStrategies::writeCustomData):
2929
2930 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2931
2932         Unreviewed, rolling out r222567.
2933
2934         This broke and internal build.
2935
2936         Reverted changeset:
2937
2938         "Build fix for High Sierra 32 bit Mac"
2939         https://bugs.webkit.org/show_bug.cgi?id=177551
2940         http://trac.webkit.org/changeset/222567
2941
2942 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2943
2944         Build fix for High Sierra 32 bit Mac
2945         https://bugs.webkit.org/show_bug.cgi?id=177551
2946         <rdar://problem/34690283>
2947
2948         Reviewed by Alexey Proskuryakov.
2949
2950         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2951         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2952         also made.
2953
2954         * Carbon/CarbonWindowAdapter.mm:
2955         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2956         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2957         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2958         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2959         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2960         (-[CarbonWindowAdapter dealloc]):
2961         (-[CarbonWindowAdapter windowRef]):
2962         (-[CarbonWindowAdapter _hasWindowRef]):
2963         (-[CarbonWindowAdapter _managesWindowRef]):
2964         (-[CarbonWindowAdapter _removeWindowRef]):
2965         (-[CarbonWindowAdapter _carbonWindowClass]):
2966         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2967         (-[CarbonWindowAdapter sendSuperEvent:]):
2968         (-[CarbonWindowAdapter relinquishFocus]):
2969         (-[CarbonWindowAdapter _cancelKey:]):
2970         (-[CarbonWindowAdapter _commonAwake]):
2971         (-[CarbonWindowAdapter _destroyRealWindow:]):
2972         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2973         (-[CarbonWindowAdapter _termWindowIfOwner]):
2974         (-[CarbonWindowAdapter _windowMovedToRect:]):
2975         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2976         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2977         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2978         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2979         (-[CarbonWindowAdapter canBecomeMainWindow]):
2980         (-[CarbonWindowAdapter encodeWithCoder:]):
2981         (-[CarbonWindowAdapter initWithCoder:]):
2982         (-[CarbonWindowAdapter setContentView:]):
2983         (-[CarbonWindowAdapter worksWhenModal]):
2984         (-[CarbonWindowAdapter _setModalWindowLevel]):
2985         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2986         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2987         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2988         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2989         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2990         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2991         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2992         (NSCarbonWindowHandleEvent):
2993         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2994         (-[CarbonWindowAdapter _growBoxRect]):
2995         * Carbon/HIWebView.mm:
2996         (HIWebViewGetWebView):
2997         (HIWebViewConstructor):
2998         (HIWebViewDestructor):
2999         (HIWebViewRegisterClass):
3000         (GetBehaviors):
3001         (Draw):
3002         (HitTest):
3003         (GetRegion):
3004         (GetWindowRef):
3005         (CreateNSEventAdoptingCGEvent):
3006         (CopyEventCGEvent):
3007         (CreateNSEventWithCarbonClickEvent):
3008         (Click):
3009         (CreateNSEventWithCarbonEvent):
3010         (MouseUp):
3011         (CreateNSEventWithCarbonMouseMoveEvent):
3012         (MouseMoved):
3013         (MouseDragged):
3014         (MouseWheelMoved):
3015         (ContextMenuClick):
3016         (GetKind):
3017         (BoundsChanged):
3018         (OwningWindowChanged):
3019         (WindowHandler):
3020         (SyncFrame):
3021         (SetFocusPart):
3022         (AdvanceFocus):
3023         (RelinquishFocus):
3024         (ActiveStateChanged):
3025         (ProcessCommand):
3026         (UpdateCommandStatus):
3027         (_NSSelectorForHICommand):
3028         (HIWebViewEventHandler):
3029         (StartUpdateObserver):
3030         (StopUpdateObserver):
3031         (UpdateObserver):
3032
3033 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3034
3035         Make PolicyAction an encodable enum class
3036         https://bugs.webkit.org/show_bug.cgi?id=177480
3037
3038         Reviewed by Antti Koivisto.
3039
3040         * Plugins/WebPluginContainerCheck.mm:
3041         (-[WebPluginContainerCheck _continueWithPolicy:]):
3042         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
3043         * WebCoreSupport/WebFrameLoaderClient.mm:
3044         (-[WebFramePolicyListener invalidate]):
3045         (-[WebFramePolicyListener ignore]):
3046         (-[WebFramePolicyListener download]):
3047         (-[WebFramePolicyListener use]):
3048         (-[WebFramePolicyListener continue]):
3049         * WebView/WebPolicyDelegate.mm:
3050         (-[WebPolicyDecisionListener use]):
3051         (-[WebPolicyDecisionListener ignore]):
3052         (-[WebPolicyDecisionListener download]):
3053
3054 2017-09-25  Frederik Riedel  <riedel@apple.com>
3055
3056         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
3057         https://bugs.webkit.org/show_bug.cgi?id=174394
3058         <rdar://problem/33183504>
3059
3060         Reviewed by Ryosuke Niwa.
3061
3062         * DOM/DOMHTMLInputElement.h:
3063         * DOM/DOMHTMLInputElement.mm:
3064         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
3065         Determines if this HTMLInputElement is part of a login screen.
3066         (-[DOMHTMLInputElement representingPageUrl]):
3067         Returns the webpage's URL that is currently displayed in the Web View.
3068         (-[DOMHTMLInputElement insertTextSuggestion:]):
3069         Inserts login credentials into the Web View.
3070
3071 2017-09-25  Sam Weinig  <sam@webkit.org>
3072
3073         Remove unused EditorClient functions
3074         https://bugs.webkit.org/show_bug.cgi?id=177463
3075
3076         Reviewed by Alex Christensen.
3077
3078         Remove unused EditorClient functions.
3079
3080         * WebCoreSupport/WebEditorClient.h:
3081         * WebCoreSupport/WebEditorClient.mm:
3082         (WebEditorClient::canonicalizeURL): Deleted.
3083         (WebEditorClient::canonicalizeURLString): Deleted.
3084         (WebEditorClient::writeDataToPasteboard): Deleted.
3085         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
3086         (WebEditorClient::readDataFromPasteboard): Deleted.
3087         (WebEditorClient::pasteboardChangeCount): Deleted.
3088
3089 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3090
3091         Stop using PolicyCallback
3092         https://bugs.webkit.org/show_bug.cgi?id=176088
3093
3094         Reviewed by Andy Estes.
3095
3096         * WebCoreSupport/WebFrameLoaderClient.mm:
3097         (-[WebFramePolicyListener invalidate]):
3098         (-[WebFramePolicyListener receivedPolicyDecision:]):
3099
3100 2017-09-25  Sam Weinig  <sam@webkit.org>
3101
3102         Remove unnecessary userVisibleString EditorClient function
3103         https://bugs.webkit.org/show_bug.cgi?id=177456
3104
3105         Reviewed by Dan Bernstein.
3106
3107         * WebCoreSupport/WebEditorClient.h:
3108         * WebCoreSupport/WebEditorClient.mm:
3109         (WebEditorClient::userVisibleString): Deleted.
3110
3111             Remove userVisibleString client function.
3112
3113 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3114
3115         Separate form submission from PolicyChecker infrastructure
3116         https://bugs.webkit.org/show_bug.cgi?id=177396
3117
3118         Reviewed by Geoffrey Garen.
3119
3120         * WebCoreSupport/WebFrameLoaderClient.h:
3121         * WebCoreSupport/WebFrameLoaderClient.mm:
3122         (WebFrameLoaderClient::dispatchWillSubmitForm):
3123
3124 2017-09-22  Zalan Bujtas  <zalan@apple.com>
3125
3126         WeakPtrFactory should populate m_ref lazily.
3127         https://bugs.webkit.org/show_bug.cgi?id=177375
3128
3129         Reviewed by Geoffrey Garen.
3130
3131         * WebCoreSupport/WebEditorClient.mm:
3132         (WebEditorClient::WebEditorClient):
3133         (WebEditorClient::requestCandidatesForSelection):
3134
3135 2017-09-22  Chris Dumez  <cdumez@apple.com>
3136
3137         Use high resolution timestamp for event time
3138         https://bugs.webkit.org/show_bug.cgi?id=154246
3139         <rdar://problem/34333304>
3140
3141         Reviewed by Ryosuke Niwa.
3142
3143         Use WallTime / MonotonicTime instead of double type for clarity.
3144
3145         * DOM/DOMEvent.mm:
3146         (-[DOMEvent timeStamp]):
3147         * WebView/WebFrame.mm:
3148         (-[WebFrame _dragSourceEndedAt:operation:]):
3149         * WebView/WebPDFView.mm:
3150         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3151
3152 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3153
3154         Enable dataTransfer.items on macOS and iOS
3155         https://bugs.webkit.org/show_bug.cgi?id=177335
3156
3157         Reviewed by Sam Weinig.
3158
3159         * WebView/WebPreferences.mm:
3160         (+[WebPreferences initialize]):
3161
3162 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
3163
3164         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
3165         https://bugs.webkit.org/show_bug.cgi?id=177101
3166         <rdar://problem/34500648>
3167
3168         Reviewed by Brian Burg.
3169
3170         * WebInspector/WebNodeHighlight.mm:
3171         Ensure we close the window that we have just removed.
3172
3173 2017-09-20  Antti Koivisto  <antti@apple.com>
3174
3175         Remove DOM and styling support for CSS Regions
3176         https://bugs.webkit.org/show_bug.cgi?id=177221
3177
3178         Reviewed by Andreas Kling.
3179
3180         * Configurations/FeatureDefines.xcconfig:
3181         * DOM/DOMCSS.mm:
3182         (kitClass):
3183         * DOM/DOMElement.mm:
3184         (-[DOMElement webkitRegionOverset]): Deleted.
3185
3186 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
3187
3188         Layering violation in Editor::createFragment
3189         https://bugs.webkit.org/show_bug.cgi?id=176123
3190
3191         Reviewed by Darin Adler.
3192
3193         * Misc/WebNSURLExtras.h:
3194         * Misc/WebNSURLExtras.mm:
3195         * WebView/WebFrame.mm:
3196         * WebView/WebHTMLView.mm:
3197         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
3198
3199         * WebCoreSupport/WebEditorClient.mm:
3200         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
3201         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
3202         way to avoid exporting the symbol just on newer OSes.
3203
3204 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
3205
3206         On iOS, getData can't get text set by setData during copy event
3207         https://bugs.webkit.org/show_bug.cgi?id=176980
3208         <rdar://problem/34453915>
3209
3210         Reviewed by Darin Adler.
3211
3212         * WebCoreSupport/WebPlatformStrategies.h:
3213         * WebCoreSupport/WebPlatformStrategies.mm:
3214         (WebPlatformStrategies::copy): Deleted.
3215
3216 2017-09-18  Andy Estes  <aestes@apple.com>
3217
3218         [Mac] Upstream miscellaneous WebKitSystemInterface functions
3219         https://bugs.webkit.org/show_bug.cgi?id=177029
3220
3221         Reviewed by Alex Christensen.
3222
3223         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3224         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3225         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3226         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3227         * WebCoreSupport/PopupMenuMac.mm:
3228         (PopupMenuMac::show):
3229         * WebCoreSupport/WebSystemInterface.mm:
3230         (InitWebCoreSystemInterface):
3231         * WebView/WebHTMLView.mm:
3232         (-[WebHTMLView setDataSource:]):
3233         (-[WebHTMLView attachRootLayer:]):
3234         * WebView/WebView.mm:
3235         (-[WebView _needsAdobeFrameReloadingQuirk]):
3236         (-[WebView _needsLinkElementTextCSSQuirk]):
3237         (-[WebView _needsIsLoadingInAPISenseQuirk]):
3238         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
3239         (-[WebView _preferencesChanged:]):
3240
3241 2017-09-15  Andy Estes  <aestes@apple.com>
3242
3243         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
3244         https://bugs.webkit.org/show_bug.cgi?id=176953
3245
3246         Reviewed by Eric Carlson.
3247
3248         * WebCoreSupport/WebSystemInterface.mm:
3249         (InitWebCoreSystemInterface):
3250
3251 2017-09-14  Andy Estes  <aestes@apple.com>
3252
3253         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
3254         https://bugs.webkit.org/show_bug.cgi?id=176931
3255
3256         Reviewed by Joseph Pecoraro.
3257
3258         * WebCoreSupport/WebSystemInterface.mm:
3259         (InitWebCoreSystemInterface):
3260
3261 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3262
3263         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
3264         https://bugs.webkit.org/show_bug.cgi?id=176867
3265
3266         Reviewed by Sam Weinig.
3267
3268         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3269         (WebKit::NetscapePluginInstanceProxy::enumerate):
3270
3271 2017-09-13  Andy Estes  <aestes@apple.com>
3272
3273         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
3274         https://bugs.webkit.org/show_bug.cgi?id=176729
3275
3276         Reviewed by Alex Christensen.
3277
3278         * WebCoreSupport/WebSystemInterface.mm:
3279         (InitWebCoreSystemInterface):
3280         * WebView/WebView.mm:
3281         (+[WebView _setCacheModel:]):
3282
3283 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3284
3285         Refactor WebContentReader out of EditorMac and EditorIOS
3286         https://bugs.webkit.org/show_bug.cgi?id=176770
3287
3288         Reviewed by Sam Weinig.
3289
3290         * WebCoreSupport/WebEditorClient.mm:
3291
3292 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3293
3294         Dragging & dropping a file creates an attachment element even when it's disabled
3295         https://bugs.webkit.org/show_bug.cgi?id=176769
3296
3297         Reviewed by Tim Horton.
3298
3299         * WebView/WebView.mm:
3300         (-[WebView _preferencesChanged:]):
3301
3302 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3303
3304         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3305         https://bugs.webkit.org/show_bug.cgi?id=176721
3306         <rdar://problem/34373660>
3307
3308         Reviewed by Tim Horton.
3309
3310         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3311         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3312
3313         * WebView/WebView.mm:
3314         (-[WebView _startDrag:]):
3315         (-[WebView _draggedElementBounds]):
3316         (-[WebView _endedDataInteraction:global:]):
3317         * WebView/WebViewData.h:
3318
3319 2017-09-11  Andy Estes  <aestes@apple.com>
3320
3321         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3322         https://bugs.webkit.org/show_bug.cgi?id=176472
3323
3324         Reviewed by Eric Carlson.
3325
3326         * WebCoreSupport/WebSystemInterface.mm:
3327         (InitWebCoreSystemInterface):
3328
3329 2017-09-09  Mark Lam  <mark.lam@apple.com>
3330
3331         Avoid duplicate computations of ExecState::vm().
3332         https://bugs.webkit.org/show_bug.cgi?id=176647
3333
3334         Reviewed by Saam Barati.
3335
3336         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3337         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3338         (WebKit::NetscapePluginInstanceProxy::construct):
3339         (WebKit::NetscapePluginInstanceProxy::setProperty):
3340         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3341         (WebKit::NetscapePluginInstanceProxy::enumerate):
3342         * Plugins/Hosted/ProxyInstance.mm:
3343         (WebKit::ProxyRuntimeMethod::create):
3344
3345 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3346
3347         Unreviewed, rolling out r221773.
3348         https://bugs.webkit.org/show_bug.cgi?id=176614
3349
3350         This caused build failures. (Requested by mlewis13 on
3351         #webkit).
3352
3353         Reverted changeset:
3354
3355         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3356         https://bugs.webkit.org/show_bug.cgi?id=176472
3357         http://trac.webkit.org/changeset/221773
3358
3359 2017-09-07  Andy Estes  <aestes@apple.com>
3360
3361         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3362         https://bugs.webkit.org/show_bug.cgi?id=176472
3363
3364         Reviewed by Eric Carlson.
3365
3366         * WebCoreSupport/WebSystemInterface.mm:
3367         (InitWebCoreSystemInterface):
3368
3369 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3370
3371         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3372         https://bugs.webkit.org/show_bug.cgi?id=176561
3373
3374         Reviewed by Brent Fulgham.
3375
3376         * Misc/WebNSUserDefaultsExtras.mm:
3377
3378 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3379
3380         Modernize Geolocation code
3381         https://bugs.webkit.org/show_bug.cgi?id=176496
3382
3383         Reviewed by Andy Estes.
3384
3385         * WebCoreSupport/WebGeolocationClient.h:
3386         * WebCoreSupport/WebGeolocationClient.mm:
3387         (WebGeolocationClient::requestPermission):
3388         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3389         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3390         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3391         * WebView/WebView.mm:
3392         (-[WebView _commonInitializationWithFrameName:groupName:]):
3393         (-[WebView _geolocationDidFailWithMessage:]):
3394
3395 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3396
3397         Remove some unused bits of code and resources
3398         https://bugs.webkit.org/show_bug.cgi?id=176275
3399
3400         Reviewed by Dan Bernstein.
3401
3402         * Misc/WebNSFileManagerExtras.mm:
3403         Include FileSystem instead of FileSystemIOS.
3404
3405 2017-09-03  Darin Adler  <darin@apple.com>
3406
3407         [Cocoa] Tidy a few things in legacy WebHTMLView
3408         https://bugs.webkit.org/show_bug.cgi?id=176280
3409
3410         Reviewed by Dan Bernstein.
3411
3412         * WebCoreSupport/WebChromeClient.mm:
3413         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3414         methods it calls on WebHTMLView were doing nothing on iOS.
3415
3416         * WebView/WebFrame.mm:
3417         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3418         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3419
3420         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3421         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3422         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3423         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3424         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3425         Use RetainPtr instead of writing retain/release wherever possible.
3426         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3427         initialization for it. Removed various unused methods and declarations of methods.
3428         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3429         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3430         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3431         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3432         and remove CFRetain no longer needed since we don't support garbage collection any more.
3433         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3434         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3435         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3436         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3437         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3438         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3439         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3440         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3441         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3442         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3443         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3444         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3445         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3446         debug flag; we haven't used it for years and it's not clearly helpful.
3447         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3448         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3449         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3450         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3451         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3452         two additional methods in the WebPrivate category and still be called by the two
3453         methods in the WebInternal category that were already using it.
3454         (-[WebHTMLView didAddSubview:]): Deleted.
3455         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3456         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3457         place this was called, the close method.
3458         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3459         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3460         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3461         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3462         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3463         Added helper method to make the one below simpler.
3464         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3465         Compared pasteboard type strings using isEqualToString: rather than using == since
3466         we want to actually compare the string contents. Also updated to use modern for loop,
3467         renamed a local variable from "s" to "localSubresources", and factored out the handling
3468         of three image types to use the helper method above.
3469         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3470         _web_makePluginSubviewsPerformSelector:withObject: method.
3471         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3472         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3473         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3474         not call the -[NSView subviews] method to make this identical on both platforms and used
3475         a modern for loop.
3476         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3477         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3478         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3479         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3480         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3481         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3482         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3483         of it is Mac-only.
3484         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3485         method did was call itself on the main thread, and do nothing if called on main thread.
3486         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3487         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3488         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3489         half of this method.
3490         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3491         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3492         Simplified using a modern for loop and RetainPtr.
3493         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3494         (-[WebHTMLView keyDown:]): Ditto.
3495         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3496         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3497         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3498         (-[WebHTMLView complete:]): Ditto.
3499         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3500         now macOS-only.
3501         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3502         iOS since that is now macOS-only.
3503         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3504         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3505         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3506         and reorganized to use early return.
3507         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3508         on iOS, but kept there so we don't have to do #if at every call site.
3509         (-[WebHTMLView _pluginController]): Moved into internal category.
3510         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3511         there only for GC, using C++ initialization, removing obsolete comment.
3512         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3513         peculiar iOS-only comment.
3514         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3515
3516         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3517         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3518         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3519         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3520         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3521
3522         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3523         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3524         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3525         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3526         them at this time.
3527
3528 2017-09-03  Sam Weinig  <sam@webkit.org>
3529
3530         Remove CanvasProxy
3531         https://bugs.webkit.org/show_bug.cgi?id=176288
3532
3533         Reviewed by Yusuke Suzuki.
3534
3535         CanvasProxy does not appear to be in any current HTML spec
3536         and was disabled and unimplemented in our tree. Time to 
3537         get rid of it.
3538
3539         * Configurations/FeatureDefines.xcconfig:
3540
3541 2017-09-02  Andy Estes  <aestes@apple.com>
3542
3543         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3544         https://bugs.webkit.org/show_bug.cgi?id=176270
3545
3546         Reviewed by Tim Horton.
3547
3548         * Plugins/Hosted/NetscapePluginHostManager.mm:
3549         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3550         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3551         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3552         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3553         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3554         (WebKit::SoftwareCARenderer::context const):
3555         (WebKit::SoftwareCARenderer::renderContext const):
3556         (WebKit::SoftwareCARenderer::render):
3557         (-[WebHostedNetscapePluginView createPlugin]):
3558         (-[WebHostedNetscapePluginView createPluginLayer]):
3559         (-[WebHostedNetscapePluginView destroyPlugin]):
3560         (-[WebHostedNetscapePluginView drawRect:]):
3561         * WebCoreSupport/WebSystemInterface.mm:
3562         (InitWebCoreSystemInterface):
3563
3564 2017-09-01  Andy Estes  <aestes@apple.com>
3565
3566         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3567         https://bugs.webkit.org/show_bug.cgi?id=176200
3568
3569         Reviewed by Tim Horton.
3570
3571         * Carbon/HIWebView.mm:
3572         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3573         (overrideCGContext):
3574         (restoreCGContext):
3575         (Draw):
3576         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3577         (+[WebHostedNetscapePluginView initialize]):
3578         * Plugins/WebBaseNetscapePluginView.h:
3579         * Plugins/WebBaseNetscapePluginView.mm:
3580         (WebKit::sendUserChangeNotifications):
3581         * Plugins/WebNetscapePluginView.mm:
3582         (+[WebNetscapePluginView initialize]):
3583         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3584         * WebCoreSupport/WebSystemInterface.mm:
3585         (InitWebCoreSystemInterface):
3586         * WebView/WebFrame.mm:
3587         (-[WebFrame _paintBehaviorForDestinationContext:]):
3588         * WebView/WebFullScreenController.mm:
3589         (setClipRectForWindow):
3590         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3591         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3592         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3593         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3594
3595 2017-08-31  Andy Estes  <aestes@apple.com>
3596
3597         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3598         https://bugs.webkit.org/show_bug.cgi?id=176175
3599
3600         Reviewed by Brady Eidson.
3601
3602         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3603         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3604         * Plugins/Hosted/WebTextInputWindowController.m:
3605         (-[WebTextInputPanel init]):
3606         * WebCoreSupport/WebSystemInterface.mm:
3607         (InitWebCoreSystemInterface):
3608         * WebView/WebDynamicScrollBarsView.mm:
3609         (-[WebDynamicScrollBarsView scrollWheel:]):
3610         * WebView/WebHTMLView.mm:
3611         (-[WebHTMLView _removeWindowObservers]):
3612         (-[WebHTMLView addWindowObservers]):
3613         * WebView/WebView.mm:
3614         (-[WebView addWindowObserversForWindow:]):
3615         (-[WebView removeWindowObservers]):
3616         (-[WebView viewWillMoveToWindow:]):
3617
3618 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3619
3620         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3621         https://bugs.webkit.org/show_bug.cgi?id=175779
3622         <rdar://problem/22367975>
3623
3624         Reviewed by Tim Horton.
3625
3626         * WebCoreSupport/WebFrameLoaderClient.h:
3627         * WebCoreSupport/WebFrameLoaderClient.mm:
3628         (WebFrameLoaderClient::webGLPolicyForURL const):
3629         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3630
3631 2017-08-30  Andy Estes  <aestes@apple.com>
3632
3633         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3634         https://bugs.webkit.org/show_bug.cgi?id=176093
3635
3636         Reviewed by Eric Carlson.
3637
3638         * WebCoreSupport/WebSystemInterface.mm:
3639         (InitWebCoreSystemInterface):
3640
3641 2017-08-30  Andy Estes  <aestes@apple.com>
3642
3643         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3644         https://bugs.webkit.org/show_bug.cgi?id=176087
3645
3646         Reviewed by Alex Christensen.
3647
3648         * Carbon/CarbonUtils.m:
3649         (getNSAutoreleasePoolCount):
3650         (WebInitForCarbon):
3651         (PoolCleaner):
3652         * Carbon/CarbonWindowAdapter.mm:
3653         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3654         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3655         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3656         (-[CarbonWindowAdapter _windowMovedToRect:]):
3657         * Carbon/HIViewAdapter.m:
3658         * Carbon/HIWebView.mm:
3659         (Draw):
3660         (CreateNSEventAdoptingCGEvent):
3661         (CopyEventCGEvent):
3662         (CreateNSEventWithCarbonClickEvent):
3663         (Click):
3664         (CreateNSEventWithCarbonEvent):
3665         (MouseUp):
3666         (CreateNSEventWithCarbonMouseMoveEvent):
3667         (MouseMoved):
3668         (MouseDragged):
3669         (MouseWheelMoved):
3670         (WindowHandler):
3671         (HIWebViewEventHandler):
3672         * Misc/QuickDrawCompatibility.h: Removed.
3673         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3674         (getCarbonEvent):
3675         (WebNetscapePluginEventHandlerCarbon::keyDown):
3676         (WebNetscapePluginEventHandlerCarbon::keyUp):
3677         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3678         (WebNetscapePluginEventHandlerCocoa::keyDown):
3679         * Plugins/WebNetscapePluginView.mm:
3680         (-[WebNetscapePluginView tellQuickTimeToChill]):
3681
3682 2017-08-29  Andy Estes  <aestes@apple.com>
3683
3684         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3685         https://bugs.webkit.org/show_bug.cgi?id=176046
3686
3687         Reviewed by Alex Christensen.
3688
3689         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3690         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3691
3692         * Misc/WebNSFileManagerExtras.mm:
3693         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3694         (setMetaData): Deleted.
3695         * WebCoreSupport/WebSystemInterface.mm:
3696         (InitWebCoreSystemInterface):
3697
3698 2017-08-28  Andy Estes  <aestes@apple.com>
3699
3700         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3701         https://bugs.webkit.org/show_bug.cgi?id=176039
3702
3703         Reviewed by Alex Christensen.
3704
3705         * WebCoreSupport/WebSystemInterface.mm:
3706         (InitWebCoreSystemInterface):
3707         * WebView/WebPreferences.mm:
3708         (+[WebPreferences _systemCFStringEncoding]):
3709
3710 2017-08-28  Andy Estes  <aestes@apple.com>
3711
3712         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3713         https://bugs.webkit.org/show_bug.cgi?id=176032
3714
3715         Reviewed by Alex Christensen.
3716
3717         * WebCoreSupport/WebSystemInterface.mm:
3718         (InitWebCoreSystemInterface):
3719         * WebView/WebView.mm:
3720         (-[WebView _cachedResponseForURL:]):
3721
3722 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3723
3724         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3725         https://bugs.webkit.org/show_bug.cgi?id=175992
3726         <rdar://problem/34086613>
3727
3728         Reviewed by Daniel Bates.
3729
3730         * WebCoreSupport/WebPlatformStrategies.h:
3731         * WebCoreSupport/WebPlatformStrategies.mm:
3732         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3733         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3734         indicating if secure cookies were accessed.
3735
3736 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3737
3738         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3739         https://bugs.webkit.org/show_bug.cgi?id=170955
3740         <rdar://problem/31697653>
3741
3742         Reviewed by Ryosuke Niwa.
3743
3744         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3745         text is being replaced.
3746
3747         * WebView/WebHTMLView.mm:
3748         (-[WebHTMLView insertText:]):
3749
3750 2017-08-24  Chris Dumez  <cdumez@apple.com>
3751
3752         [Directory Upload] Add basic support for input.webkitdirectory
3753         https://bugs.webkit.org/show_bug.cgi?id=175950
3754         <rdar://problem/33951915>
3755
3756         Reviewed by Geoffrey Garen.
3757
3758         Add private API to toggle Directory Upload support on Mac WebKit1.
3759
3760         * WebView/WebPreferenceKeysPrivate.h:
3761         * WebView/WebPreferences.mm:
3762         (+[WebPreferences initialize]):
3763         (-[WebPreferences setDirectoryUploadEnabled:]):
3764         (-[WebPreferences directoryUploadEnabled]):
3765         * WebView/WebPreferencesPrivate.h:
3766         * WebView/WebView.mm:
3767         (-[WebView _preferencesChanged:]):
3768
3769 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3770
3771         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3772         https://bugs.webkit.org/show_bug.cgi?id=175370
3773         <rdar://problem/33799806>
3774
3775         Reviewed by Ryosuke Niwa.
3776
3777         Adjust WebEditorClient for interface changes.
3778
3779         * WebCoreSupport/WebEditorClient.h:
3780
3781 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3782
3783         Remove ChromeClient::scrollbarsModeDidChange
3784         https://bugs.webkit.org/show_bug.cgi?id=175805
3785
3786         Reviewed by Daniel Bates.
3787
3788         * WebCoreSupport/WebChromeClient.h:
3789
3790 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3791
3792         Remove ChromeClient::hasOpenedPopup
3793         https://bugs.webkit.org/show_bug.cgi?id=175804
3794
3795         Reviewed by Sam Weinig.
3796
3797         * WebCoreSupport/WebChromeClient.h:
3798         * WebCoreSupport/WebChromeClient.mm:
3799         (WebChromeClient::hasOpenedPopup const): Deleted.
3800
3801 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3802
3803         Disable access to secure cookies if an HTTPS site loads mixed content
3804         https://bugs.webkit.org/show_bug.cgi?id=157053
3805         <rdar://problem/11290808>
3806
3807         Reviewed by Dan Bates.
3808
3809         * WebCoreSupport/WebPlatformStrategies.h:
3810         * WebCoreSupport/WebPlatformStrategies.mm:
3811         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3812         indicating whether secure cookies should be included in the response.
3813
3814 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3815
3816         [PAL] Move spi/mac directory into PAL
3817         https://bugs.webkit.org/show_bug.cgi?id=175649
3818
3819         Reviewed by Myles C. Maxfield.
3820
3821         * Misc/WebSharingServicePickerController.h:
3822         * WebCoreSupport/WebContextMenuClient.mm:
3823         * WebCoreSupport/WebEditorClient.mm:
3824         * WebCoreSupport/WebSelectionServiceController.mm:
3825         * WebView/WebHTMLView.mm:
3826         * WebView/WebImmediateActionController.h:
3827         * WebView/WebImmediateActionController.mm:
3828         * WebView/WebView.mm:
3829
3830 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3831
3832         [PAL] Relocate SessionID to root
3833         https://bugs.webkit.org/show_bug.cgi?id=175684
3834
3835         Reviewed by Alex Christensen.
3836
3837         * WebCoreSupport/WebFrameNetworkingContext.mm:
3838
3839 2017-08-17  Andreas Kling  <akling@apple.com>
3840
3841         Disable CSS regions at compile time
3842         https://bugs.webkit.org/show_bug.cgi?id=175630
3843
3844         Reviewed by Antti Koivisto.
3845
3846         * Configurations/FeatureDefines.xcconfig:
3847
3848 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3849
3850         [PAL] Move SessionID into PAL
3851         https://bugs.webkit.org/show_bug.cgi?id=174192
3852
3853         Reviewed by Antti Koivisto.
3854
3855         * Misc/WebCache.mm:
3856         (+[WebCache imageForURL:]):
3857         * WebCoreSupport/WebFrameLoaderClient.h:
3858         * WebCoreSupport/WebFrameLoaderClient.mm:
3859         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3860         * WebCoreSupport/WebFrameNetworkingContext.mm:
3861         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3862         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3863         (WebFrameNetworkingContext::storageSession const):
3864         * WebCoreSupport/WebPlatformStrategies.h:
3865         * WebCoreSupport/WebPlatformStrategies.mm:
3866         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3867         * WebKitPrefix.h:
3868
3869 2017-08-16  Andy Estes  <aestes@apple.com>
3870
3871         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3872         https://bugs.webkit.org/show_bug.cgi?id=175648
3873
3874         Reviewed by Tim Horton.
3875
3876         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3877         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3878         (WebPaymentCoordinatorClient::showPaymentUI):
3879
3880 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3881
3882         [PAL] Move spi/ios and spi/win directories into PAL
3883         https://bugs.webkit.org/show_bug.cgi?id=175171
3884
3885         Reviewed by Antti Koivisto.
3886
3887         * WebCoreSupport/WebFrameLoaderClient.mm:
3888         * WebView/WebView.mm:
3889
3890 2017-08-16  Andy Estes  <aestes@apple.com>
3891
3892         [Payment Request] Add an ENABLE flag and an experimental feature preference
3893         https://bugs.webkit.org/show_bug.cgi?id=175622
3894
3895         Reviewed by Tim Horton.
3896
3897         * Configurations/FeatureDefines.xcconfig:
3898
3899 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3900
3901         [PAL] Move Sleep classes into PAL
3902         https://bugs.webkit.org/show_bug.cgi?id=175456
3903
3904         Reviewed by Ryosuke Niwa.
3905
3906         * WebView/WebFullScreenController.h:
3907
3908 2017-08-15  Youenn Fablet  <youenn@apple.com>
3909
3910         [Cache API] Adding generic support for CacheStorage and Cache methods
3911         https://bugs.webkit.org/show_bug.cgi?id=175455
3912
3913         Reviewed by Chris Dumez.
3914
3915         * WebView/WebView.mm:
3916         (-[WebView _commonInitializationWithFrameName:groupName:]):
3917
3918 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3919
3920         Remove Proximity Events and related code
3921         https://bugs.webkit.org/show_bug.cgi?id=175545
3922
3923         Reviewed by Daniel Bates.
3924
3925         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3926         and other related code.
3927
3928         * Configurations/FeatureDefines.xcconfig:
3929
3930 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3931
3932         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3933         https://bugs.webkit.org/show_bug.cgi?id=175504
3934
3935         Reviewed by Sam Weinig.
3936
3937         * Configurations/FeatureDefines.xcconfig:
3938         * DOM/DOMHTMLFormElement.mm:
3939         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3940         * WebCoreSupport/WebFrameLoaderClient.h:
3941
3942 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3943
3944         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3945         https://bugs.webkit.org/show_bug.cgi?id=175557
3946
3947         Reviewed by Jon Lee.
3948
3949         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3950
3951         * Configurations/FeatureDefines.xcconfig:
3952
3953 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3954
3955         Composition underline color is always black
3956         https://bugs.webkit.org/show_bug.cgi?id=174675
3957
3958         Reviewed by Ryosuke Niwa.
3959
3960         * WebView/WebHTMLView.mm:
3961         (extractUnderlines): If NSUnderlineColorAttributeName
3962         is not present use text color for composition underline.
3963         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3964         for composition underline in the plain text case.
3965
3966 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3967
3968         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3969         https://bugs.webkit.org/show_bug.cgi?id=175474
3970         <rdar://problem/33844628>
3971
3972         Reviewed by Wenson Hsieh.
3973
3974         Replaced the build flag by a runtime flag and disabled the feature by default.
3975
3976         * Configurations/FeatureDefines.xcconfig:
3977         * WebView/WebPreferenceKeysPrivate.h:
3978         * WebView/WebPreferences.mm:
3979         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3980         (-[WebPreferences dataTransferItemsEnabled]): Added.
3981         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3982         * WebView/WebPreferencesPrivate.h:
3983         * WebView/WebView.mm:
3984         (-[WebView _preferencesChanged:]):
3985
3986 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3987
3988         Remove ENABLE_GAMEPAD_DEPRECATED
3989         https://bugs.webkit.org/show_bug.cgi?id=175361
3990
3991         Reviewed by Carlos Garcia Campos.
3992
3993         * Configurations/FeatureDefines.xcconfig:
3994
3995 2017-08-09  Chris Dumez  <cdumez@apple.com>
3996
3997         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3998         https://bugs.webkit.org/show_bug.cgi?id=175401
3999
4000         Reviewed by Brady Eidson.
4001
4002         * WebView/WebPreferenceKeysPrivate.h:
4003         * WebView/WebPreferences.mm:
4004         (+[WebPreferences initialize]):
4005         (-[WebPreferences beaconAPIEnabled]): Deleted.
4006         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
4007         * WebView/WebPreferencesPrivate.h:
4008         * WebView/WebView.mm:
4009         (-[WebView _preferencesChanged:]):
4010
4011 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
4012
4013         [PAL] Move spi/cocoa and spi/cg directories into PAL
4014         https://bugs.webkit.org/show_bug.cgi?id=175175
4015
4016         Reviewed by Myles C. Maxfield.
4017
4018         * History/WebHistory.mm:
4019         * Misc/WebDownload.mm:
4020         * Misc/WebKitNSStringExtras.mm:
4021         * Plugins/Hosted/NetscapePluginHostManager.mm:
4022         * Plugins/WebPluginDatabase.mm:
4023         * WebCoreSupport/WebFrameLoaderClient.mm:
4024         * WebInspector/WebNodeHighlight.mm:
4025         * WebView/WebHTMLView.mm:
4026         * WebView/WebIndicateLayer.mm:
4027         * WebView/WebView.mm:
4028         * WebView/WebViewData.h:
4029
4030 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
4031
4032         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
4033         https://bugs.webkit.org/show_bug.cgi?id=175392
4034         <rdar://problem/33783207>
4035
4036         Reviewed by Tim Horton and Megan Gardner.
4037
4038         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
4039
4040         * Configurations/FeatureDefines.xcconfig:
4041
4042 2017-08-09  Daniel Bates  <dabates@apple.com>
4043
4044         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
4045         https://bugs.webkit.org/show_bug.cgi?id=175247
4046         <rdar://problem/33679804>
4047
4048         Reviewed by Brady Eidson.
4049
4050         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
4051         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
4052         clients that need to make use of this information at this time. If such a needs comes up
4053         then we can expose API/SPI similar to what we do for WebKit.
4054
4055         * WebCoreSupport/WebFrameLoaderClient.h:
4056         * WebCoreSupport/WebFrameLoaderClient.mm:
4057         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
4058
4059 2017-08-08  Brady Eidson  <beidson@apple.com>
4060
4061         Don't enable default icon loading in WK1 for apps linked against old SDKs.
4062         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
4063
4064         Reviewed by Andy Estes.
4065
4066         * Misc/WebKitVersionChecks.h:
4067         * WebCoreSupport/WebFrameLoaderClient.mm:
4068         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
4069           the app is linked against new WebKit with the new behavior.
4070
4071 2017-08-07  Devin Rousso  <drousso@apple.com>
4072
4073         Web Inspector: Preview Canvas path when viewing a recording
4074         https://bugs.webkit.org/show_bug.cgi?id=174967
4075
4076         Reviewed by Brian Burg.
4077
4078         * WebView/WebPreferenceKeysPrivate.h:
4079         * WebView/WebPreferences.mm:
4080         (+[WebPreferences initialize]):
4081         (-[WebPreferences inspectorAdditionsEnabled]):
4082         (-[WebPreferences setInspectorAdditionsEnabled:]):
4083         * WebView/WebPreferencesPrivate.h:
4084         * WebView/WebView.mm:
4085         (-[WebView _preference