[LayoutFormattingContext] Initial commit.
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-04-23  Zalan Bujtas  <zalan@apple.com>
2
3         [LayoutFormattingContext] Initial commit.
4         https://bugs.webkit.org/show_bug.cgi?id=184896
5
6         Reviewed by Antti Koivisto.
7
8         * Configurations/FeatureDefines.xcconfig:
9
10 2018-04-23  Daniel Bates  <dabates@apple.com>
11
12         Implement Same-Site cookies
13         https://bugs.webkit.org/show_bug.cgi?id=159464
14         <rdar://problem/27196358>
15
16         Reviewed by Brent Fulgham.
17
18         Pass the Same-Site info through the strategy.
19
20         * WebCoreSupport/WebPlatformStrategies.h:
21         * WebCoreSupport/WebPlatformStrategies.mm:
22         (WebPlatformStrategies::cookiesForDOM):
23         (WebPlatformStrategies::setCookiesFromDOM):
24         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
25         (WebPlatformStrategies::getRawCookies):
26
27 2018-04-20  Timothy Hatcher  <timothy@apple.com>
28
29         NULL dereference crash sometimes under [super initWithCoder:] in WebView
30
31         https://bugs.webkit.org/show_bug.cgi?id=184851
32         rdar://problem/39611236
33
34         Reviewed by Tim Horton.
35
36         * WebView/WebView.mm:
37         (-[WebView _commonInitializationWithFrameName:groupName:]):
38         (-[WebView effectiveAppearanceDidChange]):
39         Added a null check and call the code later in initialization.
40
41 2018-04-20  Tim Horton  <timothy_horton@apple.com>
42
43         Adjust geolocation feature flag
44         https://bugs.webkit.org/show_bug.cgi?id=184856
45
46         Reviewed by Wenson Hsieh.
47
48         * Configurations/FeatureDefines.xcconfig:
49
50 2018-04-18  Jer Noble  <jer.noble@apple.com>
51
52         Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
53         https://bugs.webkit.org/show_bug.cgi?id=184762
54
55         Reviewed by Dan Bernstein.
56
57         * Configurations/WebKitLegacy.xcconfig:
58
59 2018-04-20  Youenn Fablet  <youenn@apple.com>
60
61         Make PluginData cache its web visible plugins
62         https://bugs.webkit.org/show_bug.cgi?id=184421
63
64         Reviewed by Chris Dumez.
65
66         * WebCoreSupport/WebPluginInfoProvider.h:
67         * WebCoreSupport/WebPluginInfoProvider.mm:
68         (WebPluginInfoProvider::pluginInfo):
69         (WebPluginInfoProvider::webVisiblePluginInfo):
70
71 2018-04-19  Chris Dumez  <cdumez@apple.com>
72
73         Rename JSDOMWindowProxy to JSWindowProxy
74         https://bugs.webkit.org/show_bug.cgi?id=184797
75
76         Reviewed by Sam Weinig.
77
78         Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.
79
80         * DOM/DOMUtility.mm:
81         (createDOMWrapper):
82         * WebView/WebFrame.mm:
83         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
84
85 2018-04-19  David Kilzer  <ddkilzer@apple.com>
86
87         Enable Objective-C weak references
88         <https://webkit.org/b/184789>
89         <rdar://problem/39571716>
90
91         Reviewed by Dan Bernstein.
92
93         * Configurations/Base.xcconfig:
94         (CLANG_ENABLE_OBJC_WEAK): Enable.
95
96 2018-04-18  Chris Dumez  <cdumez@apple.com>
97
98         Rename WindowProxyController to WindowProxy
99         https://bugs.webkit.org/show_bug.cgi?id=184756
100
101         Reviewed by Sam Weinig.
102
103         Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation
104         needed use WindowProxyController type, which was a bit confusing.
105
106         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
107         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
108         * WebView/WebFrame.mm:
109         (-[WebFrame _attachScriptDebugger]):
110
111 2018-04-17  Jonathan Bedard  <jbedard@apple.com>
112
113         Unreviewed rollout of r230632. Regression in memory usage.
114
115         That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=184569.
116
117         * WebView/WebPreferences.mm:
118         (+[WebPreferences initialize]):
119
120 2018-04-17  Chris Dumez  <cdumez@apple.com>
121
122         REGRESSION (r229831): CMD-clicking an iCloud web app link unexpectedly opens that link in a new tab and the current tab
123         https://bugs.webkit.org/show_bug.cgi?id=184678
124         <rdar://problem/39422122>
125
126         Reviewed by Alex Christensen.
127
128         Add new parameter to dispatchDecidePolicyForNavigationAction.
129
130         * WebCoreSupport/WebFrameLoaderClient.h:
131         * WebCoreSupport/WebFrameLoaderClient.mm:
132         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
133
134 2018-04-13  Chris Dumez  <cdumez@apple.com>
135
136         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
137         https://bugs.webkit.org/show_bug.cgi?id=184591
138
139         Reviewed by Sam Weinig.
140
141         Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
142         RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
143         This is work towards fixing Bug 184515.
144
145         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
146         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
147         * WebView/WebFrame.mm:
148         (-[WebFrame _attachScriptDebugger]):
149
150 2018-04-12  Antoine Quint  <graouts@apple.com>
151
152         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
153         https://bugs.webkit.org/show_bug.cgi?id=184569
154         <rdar://problem/38671301>
155
156         Reviewed by Jon Lee.
157
158         * WebView/WebPreferences.mm:
159
160 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
161
162         [WTF] Remove StaticLock
163         https://bugs.webkit.org/show_bug.cgi?id=184332
164
165         Reviewed by Mark Lam.
166
167         * DOM/DOMInternal.mm:
168         (getDOMWrapper):
169         (addDOMWrapper):
170         (removeDOMWrapper):
171
172 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
173
174         Failures from mach port reference handling should be fatal
175         https://bugs.webkit.org/show_bug.cgi?id=184202
176         <rdar://problem/37771114>
177
178         Reviewed by Anders Carlsson.
179
180         * Plugins/Hosted/NetscapePluginHostManager.mm:
181         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
182
183 2018-04-03  Andy Estes  <aestes@apple.com>
184
185         [Mac] Prioritize file promises over filenames during drag and drop
186         https://bugs.webkit.org/show_bug.cgi?id=184237
187         <rdar://problem/38278076>
188
189         Reviewed by Wenson Hsieh.
190
191         * WebView/WebView.mm:
192         (-[WebView performDragOperation:]):
193
194 2018-04-03  Chris Dumez  <cdumez@apple.com>
195
196         Drop MainFrame class
197         https://bugs.webkit.org/show_bug.cgi?id=184191
198
199         Reviewed by Darin Adler.
200
201         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
202         relationship between the Page and the MainFrame.
203
204         This is ground work for introducing LocalFrame / RemoteFrame concepts.
205
206         * WebCoreSupport/WebDragClient.mm:
207         * WebCoreSupport/WebFrameLoaderClient.mm:
208         * WebCoreSupport/WebInspectorClient.mm:
209         * WebCoreSupport/WebPlatformStrategies.mm:
210         * WebCoreSupport/WebPluginInfoProvider.mm:
211         * WebView/WebFrame.mm:
212         * WebView/WebFrameView.mm:
213         * WebView/WebHTMLView.mm:
214         * WebView/WebView.mm:
215
216 2018-04-02  Jer Noble  <jer.noble@apple.com>
217
218         Enable Legacy EME for all WebKit & WebKitLegacy clients
219         https://bugs.webkit.org/show_bug.cgi?id=184018
220         <rdar://problem/34887387>
221
222         Reviewed by Eric Carlson.
223
224         * WebView/WebPreferences.mm:
225         (+[WebPreferences initialize]):
226
227 2018-03-29  JF Bastien  <jfbastien@apple.com>
228
229         Use Forward.h instead of forward-declaring WTF::String
230         https://bugs.webkit.org/show_bug.cgi?id=184172
231         <rdar://problem/39026146>
232
233         Reviewed by Yusuke Suzuki.
234
235         As part of #184164 I'm changing WTF::String, and the forward
236         declarations are just wrong because I'm making it templated. We
237         should use Forward.h anyways, so do that instead.
238
239         * WebView/WebScriptDebugger.h:
240
241 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
242
243         Protect against invalid mach ports returned by mach_port_request_notification
244         https://bugs.webkit.org/show_bug.cgi?id=184106
245         <rdar://problem/37865316>
246
247         Reviewed by Chris Dumez.
248
249         * Plugins/Hosted/NetscapePluginHostProxy.mm:
250         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
251         and clean up if it experienced an error.
252         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
253
254 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
255
256         Avoid uninitialized mach ports
257         https://bugs.webkit.org/show_bug.cgi?id=184090
258         <rdar://problem/37261129>
259
260         Reviewed by Chris Dumez.
261
262         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
263         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
264         there is a potential for us to try to use invalid ports.
265
266         We should always check return values, and ensure that the mach port variables we seek to initialize are
267         kept in a valid state.
268
269         Reviewed by Chris Dumez.
270
271         * Plugins/Hosted/NetscapePluginHostManager.h:
272         * Plugins/Hosted/NetscapePluginHostManager.mm:
273         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
274         port is passed to an API function.
275         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
276         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
277         * Plugins/Hosted/NetscapePluginHostProxy.h:
278         * Plugins/Hosted/NetscapePluginHostProxy.mm:
279         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
280         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
281         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
282         (WKPCStatusText): Ditto.
283         (WKPCLoadURL): Ditto.
284         (WKPCCancelLoadURL): Ditto.
285         (WKPCInvalidateRect): Ditto.
286         (WKPCGetScriptableNPObjectReply): Ditto.
287         (WKPCBooleanReply): Ditto.
288         (WKPCBooleanAndDataReply): Ditto.
289         (WKPCInstantiatePluginReply): Ditto.
290         (WKPCGetWindowNPObject): Ditto.
291         (WKPCGetPluginElementNPObject): Ditto.
292         (WKPCForgetBrowserObject): Ditto.
293         (WKPCEvaluate): Ditto.
294         (WKPCGetStringIdentifier): Ditto.
295         (WKPCGetIntIdentifier): Ditto.
296         (WKPCInvoke): Ditto.
297         (WKPCInvokeDefault): Ditto.
298         (WKPCConstruct): Ditto.
299         (WKPCGetProperty): Ditto.
300         (WKPCSetProperty): Ditto.
301         (WKPCRemoveProperty): Ditto.
302         (WKPCHasProperty): Ditto.
303         (WKPCHasMethod): Ditto.
304         (WKPCIdentifierInfo): Ditto.
305         (WKPCEnumerate): Ditto.
306         (WKPCSetMenuBarVisible): Ditto.
307         (WKPCSetFullscreenWindowIsShowing): Ditto.
308         (WKPCSetModal): Ditto.
309         (WKPCGetCookies): Ditto.
310         (WKPCGetProxy): Ditto.
311         (WKPCSetCookies): Ditto.
312         (WKPCGetAuthenticationInfo): Ditto.
313         (WKPCConvertPoint): Ditto.
314         (WKPCLayerHostingModeChanged): Ditto.
315         (WKPCSetException): Ditto.
316
317 2018-03-26  Tim Horton  <timothy_horton@apple.com>
318
319         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
320         https://bugs.webkit.org/show_bug.cgi?id=184030
321         <rdar://problem/38895281>
322
323         Reviewed by Dan Bernstein.
324
325         * Configurations/Base.xcconfig:
326
327 2018-03-26  Chris Dumez  <cdumez@apple.com>
328
329         Use SecurityOriginData more consistently in Service Worker code
330         https://bugs.webkit.org/show_bug.cgi?id=183969
331
332         Reviewed by Darin Adler.
333
334         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
335
336         * Storage/WebDatabaseManager.mm:
337         (-[WebDatabaseManager databasesWithOrigin:]):
338         (-[WebDatabaseManager deleteOrigin:]):
339         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
340         * Storage/WebDatabaseQuotaManager.mm:
341         (-[WebDatabaseQuotaManager usage]):
342         (-[WebDatabaseQuotaManager quota]):
343         (-[WebDatabaseQuotaManager setQuota:]):
344         * Storage/WebStorageManager.mm:
345         (-[WebStorageManager deleteOrigin:]):
346         * WebCoreSupport/WebSecurityOrigin.mm:
347         (-[WebSecurityOrigin databaseIdentifier]):
348         (-[WebSecurityOrigin usage]):
349         (-[WebSecurityOrigin quota]):
350         (-[WebSecurityOrigin setQuota:]):
351
352 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
353
354         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
355         https://bugs.webkit.org/show_bug.cgi?id=183911
356         <rdar://problem/38762306>
357
358         Reviewed by Youenn Fablet.
359
360         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
361
362         * WebView/WebView.mm:
363         (+[WebView initialize]):
364
365 2018-03-26  Alex Christensen  <achristensen@webkit.org>
366
367         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
368         https://bugs.webkit.org/show_bug.cgi?id=183965
369
370         Reviewed by Chris Dumez.
371
372         * WebCoreSupport/WebFrameLoaderClient.h:
373         * WebCoreSupport/WebFrameLoaderClient.mm:
374         (WebFrameLoaderClient::willCacheResponse const):
375
376 2018-03-25  Commit Queue  <commit-queue@webkit.org>
377
378         Unreviewed, rolling out r229954.
379         https://bugs.webkit.org/show_bug.cgi?id=184000
380
381         Caused many layout tests to crash on Apple High Sierra,
382         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
383         by dydz on #webkit).
384
385         Reverted changeset:
386
387         "Use SecurityOriginData more consistently in Service Worker
388         code"
389         https://bugs.webkit.org/show_bug.cgi?id=183969
390         https://trac.webkit.org/changeset/229954
391
392 2018-03-24  Chris Dumez  <cdumez@apple.com>
393
394         Use SecurityOriginData more consistently in Service Worker code
395         https://bugs.webkit.org/show_bug.cgi?id=183969
396
397         Reviewed by Darin Adler.
398
399         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
400
401         * Storage/WebDatabaseManager.mm:
402         (-[WebDatabaseManager databasesWithOrigin:]):
403         (-[WebDatabaseManager deleteOrigin:]):
404         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
405         * Storage/WebDatabaseQuotaManager.mm:
406         (-[WebDatabaseQuotaManager usage]):
407         (-[WebDatabaseQuotaManager quota]):
408         (-[WebDatabaseQuotaManager setQuota:]):
409         * Storage/WebStorageManager.mm:
410         (-[WebStorageManager deleteOrigin:]):
411         * WebCoreSupport/WebSecurityOrigin.mm:
412         (-[WebSecurityOrigin databaseIdentifier]):
413         (-[WebSecurityOrigin usage]):
414         (-[WebSecurityOrigin quota]):
415         (-[WebSecurityOrigin setQuota:]):
416
417 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
418
419         Fix the build
420
421         * WebView/WebView.mm:
422
423 2018-03-23  Tim Horton  <timothy_horton@apple.com>
424
425         Fix the build with no pasteboard
426         https://bugs.webkit.org/show_bug.cgi?id=183973
427
428         Reviewed by Dan Bernstein.
429
430         * Configurations/FeatureDefines.xcconfig:
431         * WebView/WebView.mm:
432         (-[WebView _requestStartDataInteraction:globalPosition:]):
433         (-[WebView _getDataInteractionData]):
434         (-[WebView _dataOperationTextIndicator]):
435         (-[WebView _dragSourceAction]):
436         (-[WebView _draggedLinkTitle]):
437         (-[WebView _draggedLinkURL]):
438         (-[WebView _draggedElementBounds]):
439         (-[WebView _enteredDataInteraction:client:global:operation:]):
440         (-[WebView _updatedDataInteraction:client:global:operation:]):
441         (-[WebView _exitedDataInteraction:client:global:operation:]):
442         (-[WebView _performDataInteraction:client:global:operation:]):
443         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
444         (-[WebView _endedDataInteraction:global:]):
445         (-[WebView _dataInteractionCaretRect]):
446         * WebView/WebViewPrivate.h:
447
448 2018-03-23  Tim Horton  <timothy_horton@apple.com>
449
450         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
451         https://bugs.webkit.org/show_bug.cgi?id=183960
452         <rdar://problem/38812356>
453
454         Reviewed by Dan Bernstein.
455
456         * Configurations/WebKitLegacy.xcconfig:
457
458 2018-03-23  Tim Horton  <timothy_horton@apple.com>
459
460         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
461         https://bugs.webkit.org/show_bug.cgi?id=183954
462         <rdar://problem/38808858>
463
464         Reviewed by Dan Bernstein.
465
466         * WebView/WebPreferences.mm:
467         (-[WebPreferences setAudioSessionCategoryOverride:]):
468
469 2018-03-23  Tim Horton  <timothy_horton@apple.com>
470
471         Adopt WK_PLATFORM_NAME in WebKitLegacy
472         https://bugs.webkit.org/show_bug.cgi?id=183948
473         <rdar://problem/38803908>
474
475         Reviewed by Dan Bernstein.
476
477         * Configurations/WebKitLegacy.xcconfig:
478         * MigrateHeaders.make:
479         * postprocess-headers.sh:
480
481 2018-03-23  Brady Eidson  <beidson@apple.com>
482
483         Go to back/forward list items after a process-swapped navigation.
484         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
485
486         Reviewed by Andy Estes.
487
488         * WebView/WebView.mm:
489         (-[WebView _loadBackForwardListFromOtherView:]):
490         (-[WebView goToBackForwardItem:]):
491
492 2018-03-22  Tim Horton  <timothy_horton@apple.com>
493
494         Improve readability of WebCore's OTHER_LDFLAGS
495         https://bugs.webkit.org/show_bug.cgi?id=183909
496         <rdar://problem/38760992>
497
498         Reviewed by Dan Bernstein.
499
500         * Configurations/Base.xcconfig:
501         * Configurations/FeatureDefines.xcconfig:
502
503 2018-03-20  Tim Horton  <timothy_horton@apple.com>
504
505         Enable the minimal simulator feature flag when appropriate
506         https://bugs.webkit.org/show_bug.cgi?id=183807
507
508         Reviewed by Dan Bernstein.
509
510         * Configurations/FeatureDefines.xcconfig:
511
512 2018-03-20  Tim Horton  <timothy_horton@apple.com>
513
514         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
515         https://bugs.webkit.org/show_bug.cgi?id=183758
516         <rdar://problem/38017644>
517
518         Reviewed by Dan Bernstein.
519
520         * Configurations/FeatureDefines.xcconfig:
521
522 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
523
524         Clear style colors when setting default appearance
525         https://bugs.webkit.org/show_bug.cgi?id=183759
526
527         Reviewed by Tim Horton.
528
529         Colors are cached and need to be cleared and recalculated.
530         Refactor to do all style recalcs together.
531
532         * WebView/WebView.mm:
533         (-[WebView _setDefaultAppearanceAndClearStyle]):
534         (-[WebView _setUseSystemAppearance:]):
535         (-[WebView effectiveAppearanceDidChange]):
536
537 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
538
539         Unreviewed, another quick fix for r229699
540
541         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
542
543         * Configurations/FeatureDefines.xcconfig:
544
545 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
546
547         Ensure that style is updated when the effective appearance changes
548         https://bugs.webkit.org/show_bug.cgi?id=183690
549         <rdar://problem/38385900>
550
551         Reviewed by Tim Horton and Wenson Hsieh.
552
553         Respond to and respect the effective appearance changing.
554
555         * WebView/WebView.mm:
556         (-[WebView _setUseSystemAppearance:]):
557         (-[WebView effectiveAppearanceDidChange]):
558
559 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
560
561         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
562         https://bugs.webkit.org/show_bug.cgi?id=183677
563
564         Reviewed by Tim Horton.
565
566         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
567
568         * DOM/DOM.mm:
569         (-[DOMHTMLLinkElement _mediaQueryMatches]):
570
571 2018-03-14  Tim Horton  <timothy_horton@apple.com>
572
573         Fix the build after r229567
574
575         * Configurations/FeatureDefines.xcconfig:
576
577 2018-03-12  Tim Horton  <timothy_horton@apple.com>
578
579         Stop using SDK conditionals to control feature definitions
580         https://bugs.webkit.org/show_bug.cgi?id=183430
581         <rdar://problem/38251619>
582
583         Reviewed by Dan Bernstein.
584
585         * Configurations/FeatureDefines.xcconfig:
586         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
587
588 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
589
590         Runtime flag for link prefetch and remove link subresource.
591         https://bugs.webkit.org/show_bug.cgi?id=183540
592
593         Reviewed by Chris Dumez.
594
595         Remove the LINK_PREFETCH build time flag.
596
597         * Configurations/FeatureDefines.xcconfig:
598
599 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
600
601         Remove GridLayout runtime flag
602         https://bugs.webkit.org/show_bug.cgi?id=183484
603
604         Reviewed by Myles C. Maxfield.
605
606         The Grid Layout feature has been enabled by default for almost a
607         year, so I think it's time to remove the runtime flag and the
608
609         * WebView/WebPreferenceKeysPrivate.h:
610         * WebView/WebPreferences.mm:
611         (+[WebPreferences initialize]):
612         * WebView/WebPreferencesPrivate.h:
613         * WebView/WebView.mm:
614         (-[WebView _preferencesChanged:]):
615
616 2018-03-12  Antoine Quint  <graouts@apple.com>
617
618         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
619         https://bugs.webkit.org/show_bug.cgi?id=183504
620         <rdar://problem/38372965>
621
622         Reviewed by Dean Jackson and Jon Lee.
623
624         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
625         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
626
627         * WebView/WebPreferenceKeysPrivate.h:
628         * WebView/WebPreferences.mm:
629         (+[WebPreferences initialize]):
630         (-[WebPreferences setModernMediaControlsEnabled:]):
631         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
632         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
633         * WebView/WebPreferencesPrivate.h:
634         * WebView/WebView.mm:
635         (-[WebView _preferencesChanged:]):
636
637 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
638
639         Media query for default appearance
640         https://bugs.webkit.org/show_bug.cgi?id=183539
641         <rdar://problem/38326388>
642
643         Reviewed by Tim Horton.
644
645         Write a media query to evaluate appearance.
646
647         * WebView/WebView.mm:
648         (-[WebView _commonInitializationWithFrameName:groupName:]):
649         (-[WebView _setUseSystemAppearance:]):
650
651 2018-03-09  Andy Estes  <aestes@apple.com>
652
653         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
654         https://bugs.webkit.org/show_bug.cgi?id=183489
655         <rdar://problem/38267517>
656
657         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
658         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
659         to issue a sandbox extension for this directory, but for security reasons App Sandbox
660         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
661         block with a nil error and a valid file URL, but no file will actually exist at that URL.
662
663         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
664         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
665         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
666         drop destination.
667
668         Reviewed by Wenson Hsieh.
669
670         * WebView/WebView.mm:
671         (-[WebView performDragOperation:]):
672
673 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
674
675         Allow WebViews to disable system appearance
676         https://bugs.webkit.org/show_bug.cgi?id=183418
677         <rdar://problem/36975642>
678
679         Reviewed by Tim Horton.
680
681         Allow webviews to choose whether or not to follow the default system appearance.
682
683         * WebView/WebView.mm:
684         (-[WebView _setUseSystemAppearance:]):
685         (-[WebView _useSystemAppearance]):
686         * WebView/WebViewPrivate.h:
687
688 2018-03-08  Youenn Fablet  <youenn@apple.com>
689
690         libwebrtc update broke internal builds
691         https://bugs.webkit.org/show_bug.cgi?id=183454
692
693         Reviewed by Eric Carlson.
694
695         * Configurations/WebKitLegacy.xcconfig:
696
697 2018-03-08  Chris Dumez  <cdumez@apple.com>
698
699         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
700         https://bugs.webkit.org/show_bug.cgi?id=183455
701         <rdar://problem/38191749>
702
703         Reviewed by Youenn Fablet.
704
705         Add a null check for the page as we have evidence from crashes that it can be null.
706         Other functions in WebFrameNetworkingContext already null check the page as well,
707         not just the frame so this is consistent.
708
709         * WebCoreSupport/WebFrameNetworkingContext.mm:
710         (WebFrameNetworkingContext::storageSession const):
711
712 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
713
714         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
715         https://bugs.webkit.org/show_bug.cgi?id=183429
716
717         Reviewed by Mark Lam.
718
719         * DOM/DOM.mm:
720         (+[DOMNode _nodeFromJSWrapper:]):
721         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
722         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
723         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
724         * Plugins/Hosted/ProxyInstance.mm:
725         (WebKit::ProxyInstance::invokeMethod):
726         * WebView/WebView.mm:
727         (aeDescFromJSValue):
728
729 2018-03-08  Tim Horton  <timothy_horton@apple.com>
730
731         Stop linking ApplicationServices directly
732         https://bugs.webkit.org/show_bug.cgi?id=182867
733         <rdar://problem/38252142>
734
735         Reviewed by Alex Christensen.
736
737         The frameworks that we use that live inside ApplicationServices
738         have mostly moved out, so import them directly.
739
740         * Carbon/CarbonUtils.h:
741         * WebKitPrefix.h:
742         * WebView/WebHTMLView.mm:
743         * WebView/WebPDFView.mm:
744
745 2018-03-07  Tim Horton  <timothy_horton@apple.com>
746
747         Sort and separate FeatureDefines.xcconfig
748         https://bugs.webkit.org/show_bug.cgi?id=183427
749
750         Reviewed by Dan Bernstein.
751
752         * Configurations/FeatureDefines.xcconfig:
753         Sort and split FeatureDefines into paragraphs
754         (to make it easier to sort later).
755
756 2018-03-07  Youenn Fablet  <youenn@apple.com>
757
758         Match unsupported plugins based on domains and not origin
759         https://bugs.webkit.org/show_bug.cgi?id=183384
760
761         Reviewed by Chris Dumez.
762
763         * WebCoreSupport/WebPluginInfoProvider.h:
764         * WebCoreSupport/WebPluginInfoProvider.mm:
765         (WebPluginInfoProvider::getPluginInfo):
766         (WebPluginInfoProvider::getWebVisiblePluginInfo):
767
768 2018-03-05  Andy Estes  <aestes@apple.com>
769
770         [Mac] Teach WebCore::Pasteboard about file promise drags
771         https://bugs.webkit.org/show_bug.cgi?id=183314
772         <rdar://problem/38105493>
773
774         Reviewed by Darin Adler.
775
776         Added a FIXME comment.
777
778         * WebView/WebView.mm:
779         (-[WebView performDragOperation:]):
780
781 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
782
783         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
784         https://bugs.webkit.org/show_bug.cgi?id=183312
785
786         Reviewed by Mark Lam.
787
788         Remove wtf/CurrentTime.h include pragma.
789
790         * WebView/WebFrame.mm:
791         * WebView/WebPDFView.mm:
792
793 2018-03-04  Tim Horton  <timothy_horton@apple.com>
794
795         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
796         https://bugs.webkit.org/show_bug.cgi?id=183283
797         <rdar://problem/38062148>
798
799         Reviewed by Sam Weinig.
800
801         * Configurations/FeatureDefines.xcconfig:
802
803 2018-02-28  Alex Christensen  <achristensen@webkit.org>
804
805         Reduce use of NetworkingContext in WebKit
806         https://bugs.webkit.org/show_bug.cgi?id=183213
807
808         Reviewed by Brady Eidson.
809
810         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
811         (WebKit::NetscapePluginInstanceProxy::getProxy):
812         * Plugins/WebNetscapePluginView.mm:
813         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
814
815 2018-02-17  Darin Adler  <darin@apple.com>
816
817         Prepare for ExtendedColor changes (first step)
818         https://bugs.webkit.org/show_bug.cgi?id=182904
819
820         Reviewed by Sam Weinig.
821
822         * Misc/WebKitNSStringExtras.mm:
823         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
824
825 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
826
827         Remove currentTime() / currentTimeMS()
828         https://bugs.webkit.org/show_bug.cgi?id=183052
829
830         Reviewed by Mark Lam.
831
832         * WebCoreSupport/WebFrameLoaderClient.h:
833         * WebCoreSupport/WebFrameLoaderClient.mm:
834         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
835
836 2018-02-16  Youenn Fablet  <youenn@apple.com>
837
838         Allow specifying which plug-ins are supported
839         https://bugs.webkit.org/show_bug.cgi?id=182748
840
841         Reviewed by Chris Dumez.
842
843         * WebCoreSupport/WebPluginInfoProvider.h:
844         * WebCoreSupport/WebPluginInfoProvider.mm:
845         (WebPluginInfoProvider::getPluginInfo):
846         (WebPluginInfoProvider::getWebVisiblePluginInfo):
847
848 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
849
850         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
851         https://bugs.webkit.org/show_bug.cgi?id=182882
852         <rdar://problem/35672661>
853
854         Reviewed by Dan Bernstein.
855
856         Make sure the smart pointer hold the collection of subviews lives at least as
857         long as the loop using it.
858
859         * WebView/WebHTMLView.mm:
860         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
861
862 2018-02-14  Daniel Bates  <dabates@apple.com>
863
864         Disallow cross-origin subresources from asking for credentials
865         https://bugs.webkit.org/show_bug.cgi?id=182579
866         <rdar://problem/36162271>
867
868         Reviewed by Andy Estes.
869
870         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
871         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
872
873         * WebView/WebPreferenceKeysPrivate.h:
874         * WebView/WebPreferences.mm:
875         (+[WebPreferences initialize]):
876         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
877         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
878         * WebView/WebPreferencesPrivate.h:
879         * WebView/WebView.mm:
880         (-[WebView _preferencesChanged:]):
881
882 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
883
884         Remove ForwardingHeaders directory from WebKitLegacy/mac.
885         https://bugs.webkit.org/show_bug.cgi?id=182738
886
887         Reviewed by Darin Adler.
888
889         * ForwardingHeaders/collector/handles/Global.h: Removed.
890         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
891         * ForwardingHeaders/runtime/Completion.h: Removed.
892         * ForwardingHeaders/runtime/Error.h: Removed.
893         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
894         * ForwardingHeaders/runtime/JSFunction.h: Removed.
895         * ForwardingHeaders/runtime/JSLock.h: Removed.
896         * ForwardingHeaders/runtime/JSObject.h: Removed.
897         * ForwardingHeaders/runtime/JSString.h: Removed.
898         * ForwardingHeaders/runtime/Protect.h: Removed.
899         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
900
901 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
902
903         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
904         https://bugs.webkit.org/show_bug.cgi?id=182641
905
906         Reviewed by Dan Bernstein.
907
908         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
909         https://trac.webkit.org/changeset/228308.
910
911         * WebView/WebVideoFullscreenController.h:
912         * WebView/WebVideoFullscreenHUDWindowController.mm:
913         * WebView/WebWindowAnimation.h:
914         * WebView/WebWindowAnimation.mm:
915         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
916         (WebCore::scaledRect): Deleted.
917         (WebCore::squaredDistance): Deleted.
918
919 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
920
921         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
922
923         * WebView/WebWindowAnimation.mm:
924         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
925
926 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
927
928         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
929         https://bugs.webkit.org/show_bug.cgi?id=182615
930
931         Reviewed by Eric Carlson.
932
933         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
934         Ideally, we should not reference NSApp in WebCore.
935
936         * WebView/WebFullScreenController.mm:
937         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
938         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
939         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
940         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
941         * WebView/WebView.mm:
942         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
943         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
944
945 2018-01-13  Darin Adler  <darin@apple.com>
946
947         Event improvements
948         https://bugs.webkit.org/show_bug.cgi?id=179591
949
950         Reviewed by Chris Dumez.
951
952         * DOM/DOMWheelEvent.mm:
953         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
954         Call initWebKitWheelEvent.
955
956         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
957         * WebCoreSupport/WebInspectorClient.mm: Ditto.
958         * WebView/WebFrame.mm: Ditto.
959
960         * WebView/WebHTMLView.mm:
961         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
962         underlyingPlatformEvent.
963         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
964
965         * WebView/WebScriptWorld.mm:
966         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
967
968         * WebView/WebView.mm: Removed include of ScriptValue.h.
969
970 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
971
972         Remove WebCore/ForwardingHeaders directory
973         https://bugs.webkit.org/show_bug.cgi?id=182347
974
975         Reviewed by Keith Miller.
976
977         * Carbon/CarbonWindowAdapter.mm:
978         * DOM/WebDOMOperations.mm:
979         * History/WebBackForwardList.mm:
980         * History/WebHistoryItem.mm:
981         * Misc/WebCache.mm:
982         * Misc/WebElementDictionary.mm:
983         * Misc/WebIconDatabase.mm:
984         * Misc/WebStringTruncator.mm:
985         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
986         * Plugins/Hosted/ProxyInstance.mm:
987         * Plugins/Hosted/ProxyRuntimeObject.mm:
988         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
989         * Plugins/WebBaseNetscapePluginView.mm:
990         * Plugins/WebBasePluginPackage.mm:
991         * Plugins/WebNetscapePluginStream.mm:
992         * Plugins/WebNetscapePluginView.mm:
993         * Plugins/WebPluginController.mm:
994         * WebCoreSupport/WebEditorClient.mm:
995         * WebCoreSupport/WebFrameLoaderClient.mm:
996         * WebCoreSupport/WebInspectorClient.h:
997         * WebCoreSupport/WebInspectorClient.mm:
998         * WebView/WebDataSource.mm:
999         * WebView/WebFrame.mm:
1000         * WebView/WebHTMLRepresentation.mm:
1001         * WebView/WebHTMLView.mm:
1002         * WebView/WebPreferences.mm:
1003         * WebView/WebScriptDebugDelegate.mm:
1004         * WebView/WebScriptDebugger.h:
1005         * WebView/WebTextIterator.mm:
1006         * WebView/WebView.mm:
1007         * WebView/WebViewData.mm:
1008
1009 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
1010
1011         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
1012         https://bugs.webkit.org/show_bug.cgi?id=182312
1013
1014         Reviewed by Michael Catanzaro.
1015
1016         * WebKitPrefix.h:
1017
1018 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
1019
1020         [WebAuthN] Add a compile-time feature flag
1021         https://bugs.webkit.org/show_bug.cgi?id=182211
1022         <rdar://problem/36936365>
1023
1024         Reviewed by Brent Fulgham.
1025
1026         * Configurations/FeatureDefines.xcconfig:
1027
1028 2018-01-27  Dan Bernstein  <mitz@apple.com>
1029
1030         HaveInternalSDK includes should be "#include?"
1031         https://bugs.webkit.org/show_bug.cgi?id=179670
1032
1033         * Configurations/Base.xcconfig:
1034
1035 2018-01-24  Alex Christensen  <achristensen@webkit.org>
1036
1037         Remove unused QTKit preference
1038         https://bugs.webkit.org/show_bug.cgi?id=181968
1039
1040         Reviewed by Alexey Proskuryakov.
1041
1042         * WebView/WebPreferenceKeysPrivate.h:
1043         * WebView/WebPreferences.mm:
1044         (+[WebPreferences initialize]):
1045         (-[WebPreferences setQTKitEnabled:]): Deleted.
1046         (-[WebPreferences isQTKitEnabled]): Deleted.
1047         * WebView/WebPreferencesPrivate.h:
1048         * WebView/WebView.mm:
1049         (-[WebView _preferencesChanged:]):
1050
1051 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1052
1053         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
1054         https://bugs.webkit.org/show_bug.cgi?id=182037
1055         <rdar://problem/36747812>
1056
1057         Reviewed by Ryosuke Niwa.
1058
1059         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
1060         for more details.
1061
1062         * WebView/WebHTMLRepresentation.mm:
1063         (-[WebHTMLRepresentation elementWithName:inForm:]):
1064         (-[WebHTMLRepresentation controlsInForm:]):
1065
1066 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1067
1068         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
1069         https://bugs.webkit.org/show_bug.cgi?id=181961
1070
1071         Reviewed by Michael Catanzaro.
1072
1073         * WebView/WebPreferences.mm:
1074
1075 2018-01-23  Commit Queue  <commit-queue@webkit.org>
1076
1077         Unreviewed, rolling out r227437.
1078         https://bugs.webkit.org/show_bug.cgi?id=182011
1079
1080         broke build (Requested by alexchristensen on #webkit).
1081
1082         Reverted changeset:
1083
1084         "Remove unused QTKit preference"
1085         https://bugs.webkit.org/show_bug.cgi?id=181968
1086         https://trac.webkit.org/changeset/227437
1087
1088 2018-01-23  Alex Christensen  <achristensen@webkit.org>
1089
1090         Remove unused QTKit preference
1091         https://bugs.webkit.org/show_bug.cgi?id=181968
1092
1093         Reviewed by Alexey Proskuryakov.
1094
1095         * WebView/WebPreferenceKeysPrivate.h:
1096         * WebView/WebPreferences.mm:
1097         (+[WebPreferences initialize]):
1098         (-[WebPreferences setQTKitEnabled:]): Deleted.
1099         (-[WebPreferences isQTKitEnabled]): Deleted.
1100         * WebView/WebPreferencesPrivate.h:
1101         * WebView/WebView.mm:
1102         (-[WebView _preferencesChanged:]):
1103
1104 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1105
1106         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
1107         https://bugs.webkit.org/show_bug.cgi?id=181960
1108         <rdar://problem/36431678>
1109
1110         Reviewed by Tim Horton.
1111
1112         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
1113         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
1114         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
1115
1116         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
1117         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
1118         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
1119
1120         * WebView/WebView.mm:
1121         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1122
1123 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
1124
1125         Turning off custom pasteboard data doesn't actually turn it off in WK2
1126         https://bugs.webkit.org/show_bug.cgi?id=181920
1127         <rdar://problem/36686429>
1128
1129         Reviewed by Wenson Hsieh.
1130
1131         Always disable custom pasteboard data in WebKit1. See r226156 for details.
1132
1133         * WebView/WebPreferences.mm:
1134         (+[WebPreferences initialize]):
1135         * WebView/WebView.mm:
1136         (-[WebView _preferencesChanged:]):
1137
1138 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1139
1140         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
1141         https://bugs.webkit.org/show_bug.cgi?id=181918
1142
1143         Reviewed by Tim Horton.
1144
1145         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
1146
1147         * Configurations/FeatureDefines.xcconfig:
1148
1149 2018-01-20  Andy Estes  <aestes@apple.com>
1150
1151         [Apple Pay] Stop eagerly loading PassKit.framework
1152         https://bugs.webkit.org/show_bug.cgi?id=181911
1153         <rdar://problem/36555369>
1154
1155         Reviewed by Tim Horton.
1156
1157         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1158         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1159         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1160
1161         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1162
1163 2018-01-19  Dean Jackson  <dino@apple.com>
1164
1165         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1166         https://bugs.webkit.org/show_bug.cgi?id=181817
1167         <rdar://problem/35274055>
1168
1169         Reviewed by Simon Fraser.
1170
1171         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1172
1173         * Misc/WebKitVersionChecks.h:
1174         * WebView/WebView.mm:
1175         (-[WebView _commonInitializationWithFrameName:groupName:]):
1176
1177 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1178
1179         Remove unused WebViewPrivate _allowCookies
1180         https://bugs.webkit.org/show_bug.cgi?id=181812
1181
1182         Reviewed by Tim Horton.
1183
1184         * WebView/WebView.mm:
1185         (+[WebView _setAllowCookies:]): Deleted.
1186         (+[WebView _allowCookies]): Deleted.
1187         * WebView/WebViewPrivate.h:
1188
1189 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1190
1191         Build fix, remove a call to -[NSWindow setOneShot:]
1192         https://bugs.webkit.org/show_bug.cgi?id=181809
1193
1194         Reviewed by Tim Horton.
1195
1196         * WebView/WebTextCompletionController.mm:
1197         (-[WebTextCompletionController _buildUI]):
1198
1199 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1200
1201         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1202
1203         * Carbon/HIWebView.mm:
1204         (overrideCGContext):
1205         (restoreCGContext):
1206
1207 2018-01-18  Dan Bernstein  <mitz@apple.com>
1208
1209         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1210         https://bugs.webkit.org/show_bug.cgi?id=181803
1211
1212         Reviewed by Tim Horton.
1213
1214         * Configurations/Base.xcconfig: Updated.
1215         * Configurations/DebugRelease.xcconfig: Ditto.
1216         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1217         * Configurations/Version.xcconfig: Updated.
1218         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1219           useful for defining settings that depend on the target macOS version.
1220
1221 2018-01-17  Youenn Fablet  <youenn@apple.com>
1222
1223         Put fetch Request.keepalive behind a runtime flag
1224         https://bugs.webkit.org/show_bug.cgi?id=181592
1225
1226         Reviewed by Chris Dumez.
1227
1228         * WebView/WebPreferenceKeysPrivate.h:
1229         * WebView/WebPreferences.mm:
1230         (+[WebPreferences initialize]):
1231         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1232         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1233         * WebView/WebPreferencesPrivate.h:
1234         * WebView/WebView.mm:
1235         (-[WebView _preferencesChanged:]):
1236
1237 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1238
1239         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1240         https://bugs.webkit.org/show_bug.cgi?id=181637
1241         <rdar://problem/36508471>
1242
1243         Reviewed by Tim Horton.
1244
1245         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1246
1247         * WebCoreSupport/WebEditorClient.h:
1248         * WebCoreSupport/WebEditorClient.mm:
1249         (WebEditorClient::replacementURLForResource):
1250
1251 2018-01-11  Keith Miller  <keith_miller@apple.com>
1252
1253         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1254         https://bugs.webkit.org/show_bug.cgi?id=181573
1255
1256         Reviewed by Simon Fraser.
1257
1258         * Configurations/FeatureDefines.xcconfig:
1259
1260 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1261
1262         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1263         https://bugs.webkit.org/show_bug.cgi?id=181497
1264
1265         Reviewed by Tim Horton.
1266
1267         See other ChangeLogs for more detail.
1268
1269         * WebCoreSupport/WebDragClient.h:
1270
1271 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1272
1273         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1274         https://bugs.webkit.org/show_bug.cgi?id=181523
1275         <rdar://problem/28959131>
1276
1277         Reviewed by Alex Christensen.
1278
1279         * WebView/WebImmediateActionController.mm:
1280         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1281         Apply the change made in r216652 to WebKit1's immediate action controller.
1282
1283         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1284         the startContainer of the range is in an anonymous node.
1285
1286 2018-01-11  Youenn Fablet  <youenn@apple.com>
1287
1288         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1289         https://bugs.webkit.org/show_bug.cgi?id=181480
1290
1291         Reviewed by Eric Carlson.
1292
1293         * WebView/WebPreferences.mm:
1294         (+[WebPreferences initialize]):
1295
1296 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1297
1298         Fix check-webkit-style issues with WebNSDataExtras.mm
1299         <https://webkit.org/b/181369>
1300
1301         Reviewed by Alex Christensen.
1302
1303         * Misc/WebNSDataExtras.mm:
1304         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1305         (-[NSData _webkit_guessedMIMETypeForXML]):
1306         (-[NSData _webkit_guessedMIMEType]):
1307         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1308         (_findEOL):
1309         (-[NSData _webkit_parseRFC822HeaderFields]):
1310         (-[NSData _web_locationAfterFirstBlankLine]):
1311         - Fix all the check-webkit-style warnings.
1312
1313 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1314
1315         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1316         <https://webkit.org/b/181256>
1317         <rdar://problem/36281730>
1318
1319         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1320         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1321         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1322           to avoid warnings from casting CFStringRef to NPNSString*.
1323           Note that CFMutableStringRef is the same as CFStringRef
1324           without the const modifier, hence its use in the const_cast<>
1325           above.
1326
1327 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1328
1329         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1330         <https://webkit.org/b/181256>
1331         <rdar://problem/36281730>
1332
1333         * Carbon/HIWebView.mm:
1334         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1335         checked_cf_cast<CFRunLoopRef>() to fix warning.
1336
1337 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1338
1339         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1340         <https://webkit.org/b/181256>
1341         <rdar://problem/36281730>
1342
1343         Reviewed by Darin Adler.
1344
1345         * Carbon/CarbonUtils.m:
1346         (PoolCleaner):
1347         - Use #pragmas to ignore -Wcast-qual warnings when using a
1348           C-style cast from CFTypeRef to CFRunloopRef.
1349         * Carbon/CarbonWindowFrame.m:
1350         (-[CarbonWindowFrame title]):
1351         - Use #pragmas to ignore -Wcast-qual warnings when using a
1352           C-style cast from CFStringRef to NSString *.
1353         * Carbon/HIViewAdapter.m:
1354         (+[HIViewAdapter getHIViewForNSView:]):
1355         - Use #pragmas to ignore -Wcast-qual warnings when using a
1356           C-style cast from CFTypeRef to HIViewRef.
1357         * Configurations/Base.xcconfig:
1358         (WARNING_CFLAGS): Add -Wcast-qual.
1359         * Misc/WebElementDictionary.mm:
1360         (-[WebElementDictionary objectForKey:]):
1361         - Use static_cast<SEL>(const_cast<void*>()) to fix
1362           warning.
1363         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1364         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1365         (-[NSData _webkit_guessedMIMETypeForXML]):
1366         (-[NSData _webkit_guessedMIMEType]):
1367         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1368         (_findEOL):
1369         (-[NSData _webkit_parseRFC822HeaderFields]):
1370         (-[NSData _web_startsWithBlankLine]):
1371         (-[NSData _web_locationAfterFirstBlankLine]):
1372         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1373           type to Objective-C++.  This fixes the warnings about
1374           discarding the `const` modifier when casing from CFStringRef
1375           to NSString * because in older clang versions, -Wcast-qual was
1376           completely broken when compiling C++ and Objective-C++ source
1377           files.  In newer clang versions, discarding the `const`
1378           modifier for toll-free bridged types is ignored when compiling
1379           Objective-C++ source.
1380         - Update copyright and license header.
1381         - Use reinterpret_cast<> and static_cast<> to fix warnings
1382           unrelated to (NSString *) C-style casts.
1383         - Replace use of MIN() macro with std::min<> template functions.
1384         - Fix location of `*` for local variables modified above.
1385         * Plugins/Hosted/NetscapePluginHostManager.mm:
1386         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1387         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1388         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1389         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1390           warnings.
1391         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1392         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1393         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1394           to fix warning.
1395         * Plugins/Hosted/ProxyInstance.mm:
1396         (WebKit::ProxyInstance::invoke):
1397         - Use static_cast<char*>(const_cast<void*>()) to fix
1398           warning when using -[NSData bytes].
1399         (WebKit::ProxyInstance::fieldValue const):
1400         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1401           to fix warning when using CFDataGetBytePtr().
1402         * Plugins/Hosted/WebTextInputWindowController.m:
1403         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1404         - Use #pragma to ignore -Wcast-qual warning since there
1405           is not a good way to avoid this warning in Objective-C.
1406         * Plugins/WebNetscapePluginStream.mm:
1407         (WebNetscapePluginStream::deliverData):
1408         - Use const_cast<void*>() to fix warning when using
1409           -[NSData bytes].
1410         * Plugins/WebNetscapePluginView.mm:
1411         (-[WebNetscapePluginView _createPlugin]):
1412         - Change C-style cast to const_cast<char*>() to fix
1413           warning.
1414         * WebCoreSupport/WebChromeClient.mm:
1415         (WebChromeClient::wrapCryptoKey const):
1416         (WebChromeClient::unwrapCryptoKey const):
1417         - Change C-style cast to
1418           static_cast<uint8_t*>(const_cast<void*>() to fix
1419           warning.
1420         * WebView/WebPDFView.mm:
1421         (_applicationInfoForMIMEType):
1422         - Change local variable type from 'NSURL *' to
1423           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1424           when calling -[NSURL path].
1425
1426 2018-01-05  Dan Bernstein  <mitz@apple.com>
1427
1428         Fixed the build following AppKit API deprecations in a recent SDKs
1429
1430         * WebView/WebFullScreenController.mm:
1431         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1432         (-[WebFullScreenController exitFullScreen]): Ditto.
1433         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1434         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1435         * WebView/WebHTMLView.mm:
1436         (-[WebHTMLView drawRect:]): Ditto.
1437         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1438         (-[WebHTMLView knowsPageRange:]): Ditto.
1439         * WebView/WebView.mm:
1440         (LayerFlushController::flushLayers): Ditto.
1441
1442 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1443
1444         [Attachment Support] Create attachment elements when dropping files on iOS
1445         https://bugs.webkit.org/show_bug.cgi?id=181192
1446         <rdar://problem/36280945>
1447
1448         Reviewed by Tim Horton.
1449
1450         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1451
1452         * WebCoreSupport/WebPlatformStrategies.h:
1453         * WebCoreSupport/WebPlatformStrategies.mm:
1454         (WebPlatformStrategies::informationForItemAtIndex):
1455         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1456
1457 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1458
1459         [Attachment Support] Add plumbing for starting a drag with promised blob data
1460         https://bugs.webkit.org/show_bug.cgi?id=181201
1461
1462         Reviewed by Tim Horton.
1463
1464         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1465
1466         * WebCoreSupport/WebDragClient.h:
1467
1468 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1469
1470         Add a WebAuthentication runtime feature flag
1471         https://bugs.webkit.org/show_bug.cgi?id=181220
1472         <rdar://problem/36055305>
1473
1474         Reviewed by Brent Fulgham.
1475
1476         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1477
1478         * WebView/WebPreferenceKeysPrivate.h:
1479         * WebView/WebPreferences.mm:
1480         (+[WebPreferences initialize]):
1481         (-[WebPreferences webAuthenticationEnabled]):
1482         (-[WebPreferences setWebAuthenticationEnabled:]):
1483         (-[WebPreferences credentialManagementEnabled]): Deleted.
1484         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1485         * WebView/WebPreferencesPrivate.h:
1486         * WebView/WebView.mm:
1487         (-[WebView _preferencesChanged:]):
1488
1489 2017-12-22  Jeff Miller  <jeffm@apple.com>
1490
1491         Update user-visible copyright strings to include 2018
1492         https://bugs.webkit.org/show_bug.cgi?id=181141
1493
1494         Reviewed by Dan Bernstein.
1495
1496         * Info.plist:
1497
1498 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1499
1500         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1501         https://bugs.webkit.org/show_bug.cgi?id=181188
1502
1503         Reviewed by Dan Bernstein.
1504
1505         See WebCore/ChangeLog for more detail.
1506
1507         * WebCoreSupport/WebDragClient.h:
1508         * WebCoreSupport/WebDragClient.mm:
1509         (WebDragClient::declareAndWriteAttachment): Deleted.
1510         * WebView/WebHTMLView.mm:
1511         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1512
1513 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1514
1515         Unreviewed, continue to fix build failures due to AppKit API deprecation
1516
1517         Wraps more code in -Wdeprecated-declarations.
1518
1519         * Carbon/HIWebView.mm:
1520         (overrideCGContext):
1521
1522 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1523
1524         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1525
1526         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1527
1528         * Carbon/CarbonWindowAdapter.mm:
1529         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1530         * Plugins/WebNetscapePluginView.mm:
1531         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1532         (-[WebNetscapePluginView sendDrawRectEvent:]):
1533         (-[WebNetscapePluginView drawRect:]):
1534
1535 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1536
1537         Fix build failures due to using deprecated AppKit symbols
1538         https://bugs.webkit.org/show_bug.cgi?id=181110
1539         <rdar://problem/36162865>
1540
1541         Reviewed by Dan Bernstein and Tim Horton.
1542
1543         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1544
1545         * Misc/WebKitNSStringExtras.mm:
1546         (-[NSString _web_drawAtPoint:font:textColor:]):
1547         * Misc/WebNSPasteboardExtras.h:
1548         * Misc/WebNSPasteboardExtras.mm:
1549         (+[NSPasteboard _web_writableTypesForURL]):
1550         (_createWritableTypesForImageWithoutArchive):
1551         (_createWritableTypesForImageWithArchive):
1552         (+[NSPasteboard _web_dragTypesForURL]):
1553         (-[NSPasteboard _web_bestURL]):
1554         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1555         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1556         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1557         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1558         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1559         * Panels/WebAuthenticationPanel.m:
1560         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1561         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1562         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1563         (-[WebHostedNetscapePluginView drawRect:]):
1564         * WebInspector/WebNodeHighlightView.mm:
1565         (-[WebNodeHighlightView drawRect:]):
1566         * WebView/WebFrame.mm:
1567         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1568         (-[WebFrame _drawRect:contentsOnly:]):
1569         * WebView/WebHTMLView.mm:
1570         (kit):
1571         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1572         (-[WebHTMLView _plainTextFromPasteboard:]):
1573         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1574         (+[WebHTMLView _insertablePasteboardTypes]):
1575         (+[WebHTMLView _selectionPasteboardTypes]):
1576         (-[WebHTMLView pasteboard:provideDataForType:]):
1577         (-[WebHTMLView _writeSelectionToPasteboard:]):
1578         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1579         (-[WebHTMLView validRequestorForSendType:returnType:]):
1580         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1581         (createMenuItem):
1582         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1583         (-[WebHTMLView _colorAsString:]):
1584         (-[WebHTMLView copyFont:]):
1585         * WebView/WebPDFView.mm:
1586         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1587         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1588         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1589         (-[WebPDFView pasteboardTypesForSelection]):
1590         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1591         * WebView/WebView.h:
1592         * WebView/WebView.mm:
1593         (-[WebView performDragOperation:]):
1594         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1595         (-[WebView _searchWithGoogleFromMenu:]):
1596
1597 2017-12-21  Youenn Fablet  <youenn@apple.com>
1598
1599         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1600         https://bugs.webkit.org/show_bug.cgi?id=181000
1601
1602         Reviewed by Chris Dumez.
1603
1604         * Misc/WebCache.mm:
1605         (+[WebCache addImageToCache:forURL:forFrame:]):
1606
1607 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1608
1609         Update FULLSCREEN_API feature defines.
1610         https://bugs.webkit.org/show_bug.cgi?id=181015
1611
1612         Reviewed by Tim Horton.
1613
1614         Change enabled iphone sdk for FULLSCREEN_API.
1615
1616         * Configurations/FeatureDefines.xcconfig:
1617
1618 2017-12-21  Jer Noble  <jer.noble@apple.com>
1619
1620         Add initial DOM support for Media Capabilities
1621         https://bugs.webkit.org/show_bug.cgi?id=181064
1622
1623         Reviewed by Eric Carlson.
1624
1625         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1626
1627         * WebView/WebPreferenceKeysPrivate.h:
1628         * WebView/WebPreferences.mm:
1629         (+[WebPreferences initialize]):
1630         (-[WebPreferences mediaCapabilitiesEnabled]):
1631         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1632         * WebView/WebPreferencesPrivate.h:
1633         * WebView/WebView.mm:
1634         (-[WebView _preferencesChanged:]):
1635
1636 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1637
1638         Enable picture-in-picture from inline element on suspend.
1639         https://bugs.webkit.org/show_bug.cgi?id=180942
1640         rdar://problem/34745234
1641
1642         Reviewed by Jer Noble.
1643
1644         Update signature of enterVideoFullscreenForVideoElement().
1645
1646         * WebCoreSupport/WebChromeClient.h:
1647         * WebCoreSupport/WebChromeClient.mm:
1648         (WebChromeClient::enterVideoFullscreenForVideoElement):
1649
1650 2017-12-20  Daniel Bates  <dabates@apple.com>
1651
1652         Remove Alternative Presentation Button
1653         https://bugs.webkit.org/show_bug.cgi?id=180500
1654         <rdar://problem/35891047>
1655
1656         Reviewed by Simon Fraser.
1657
1658         We no longer need the alternative presentation button.
1659
1660         * Configurations/FeatureDefines.xcconfig:
1661
1662 2017-12-19  Jer Noble  <jer.noble@apple.com>
1663
1664         Playing media elements which call "pause(); play()" will have the play promise rejected.
1665         https://bugs.webkit.org/show_bug.cgi?id=180781
1666         <rdar://problem/33191377>
1667
1668         Reviewed by Eric Carlson.
1669
1670         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1671
1672         * WebView/WebView.mm:
1673         (shouldRequireUserGestureToLoadVideo):
1674
1675 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1676
1677         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1678         https://bugs.webkit.org/show_bug.cgi?id=180977
1679
1680         Reviewed by Tim Horton.
1681
1682         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1683         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1684         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1685
1686         * WebCoreSupport/WebEditorClient.mm:
1687         (attributesForAttributedStringConversion):
1688         * WebView/WebHTMLView.mm:
1689         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1690
1691 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1692
1693         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1694
1695         Attempt to fix the following warnings:
1696
1697             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1698
1699         For the following instance variables:
1700
1701             _borderView
1702             _contentView
1703             _frame
1704             _wFlags
1705
1706         * Carbon/CarbonWindowAdapter.mm:
1707         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1708         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1709         (-[CarbonWindowAdapter _termWindowIfOwner]):
1710         (-[CarbonWindowAdapter _windowMovedToRect:]):
1711         (-[CarbonWindowAdapter setContentView:]):
1712         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1713         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1714
1715 2017-12-16  Dan Bernstein  <mitz@apple.com>
1716
1717         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1718         https://bugs.webkit.org/show_bug.cgi?id=180613
1719         <rdar://problem/35946124>
1720
1721         Reviewed by Geoff Garen.
1722
1723         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1724           clients.
1725         * WebView/WebDynamicScrollBarsView.h: Ditto.
1726         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1727
1728 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1729
1730         Enable -Wstrict-prototypes for WebKit
1731         <https://webkit.org/b/180757>
1732         <rdar://problem/36024132>
1733
1734         Rubber-stamped by Joseph Pecoraro.
1735
1736         * Configurations/Base.xcconfig:
1737         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1738
1739 2017-12-14  John Wilander  <wilander@apple.com>
1740
1741         Storage Access API: Implement frame-specific access in the document.cookie layer
1742         https://bugs.webkit.org/show_bug.cgi?id=180682
1743         <rdar://problem/35982257>
1744
1745         Reviewed by Alex Christensen.
1746
1747         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1748         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1749         CookiesStrategy::getRawCookies() now take optional parameters for
1750         frameID and pageID to allow frame-specific scoping of cookies.
1751
1752         This change makes the return values of FrameLoaderClient::frameID()
1753         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1754         WebCore can call those getters and get the right return values in
1755         WebKit and std:nullopt in WebKitLegacy.
1756
1757         * WebCoreSupport/WebFrameLoaderClient.h:
1758         * WebCoreSupport/WebFrameLoaderClient.mm:
1759         (WebFrameLoaderClient::pageID const):
1760         (WebFrameLoaderClient::frameID const):
1761         * WebCoreSupport/WebPlatformStrategies.h:
1762         * WebCoreSupport/WebPlatformStrategies.mm:
1763         (WebPlatformStrategies::cookiesForDOM):
1764         (WebPlatformStrategies::setCookiesFromDOM):
1765         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1766         (WebPlatformStrategies::getRawCookies):
1767
1768 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1769
1770         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1771         https://bugs.webkit.org/show_bug.cgi?id=180689
1772
1773         Reviewed by Tim Horton.
1774
1775         Use sRGBColorSpaceRef() from WebCore.
1776
1777         * WebView/WebHTMLView.mm:
1778         (imageFromRect):
1779
1780 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1781
1782         Stop using deprecated target conditional for simulator builds
1783         https://bugs.webkit.org/show_bug.cgi?id=180662
1784         <rdar://problem/35136156>
1785
1786         Reviewed by Simon Fraser.
1787
1788         * postprocess-headers.sh:
1789
1790 2017-12-11  David Quesada  <david_quesada@apple.com>
1791
1792         Turn on ENABLE_APPLICATION_MANIFEST
1793         https://bugs.webkit.org/show_bug.cgi?id=180562
1794         rdar://problem/35924737
1795
1796         Reviewed by Geoffrey Garen.
1797
1798         * Configurations/FeatureDefines.xcconfig:
1799
1800 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1801
1802         Remove pthread_once in favor of dispatch_once
1803         https://bugs.webkit.org/show_bug.cgi?id=180591
1804
1805         Reviewed by Saam Barati.
1806
1807         * Misc/WebKitErrors.m:
1808         (+[NSError _registerWebKitErrors]):
1809         (registerErrors): Deleted.
1810         * Storage/WebStorageManager.mm:
1811         (+[WebStorageManager _storageDirectoryPath]):
1812         (initializeLocalStoragePath): Deleted.
1813
1814 2017-12-07  Darin Adler  <darin@apple.com>
1815
1816         Remove some unused code from WebKitLegacy
1817         https://bugs.webkit.org/show_bug.cgi?id=180567
1818
1819         Reviewed by Anders Carlsson.
1820
1821         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1822         macOS (back a few versions) and iOS and removed unused
1823         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1824         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1825         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1826         _webkit_stringByCollapsingNonPrintingCharacters,
1827         _webkit_stringByCollapsingWhitespaceCharacters,
1828         _web_stringWithData:textEncodingName:, and
1829         _webkit_localStorageDirectoryWithBundleIdentifier:.
1830
1831         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1832         this source file.
1833         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1834         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1835         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1836         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1837         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1838         handle font smoothing options.
1839         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1840         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1841         from header and made it a little clearer.
1842         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1843         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1844         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1845         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1846         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1847         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1848         implementation a bit and used whole words instead of abbreviations.
1849         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1850
1851         * Misc/WebNSFileManagerExtras.mm:
1852         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1853         filenameByFixingIllegalCharacters function from WebCore directly instead of
1854         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1855
1856         * Plugins/WebBaseNetscapePluginView.mm:
1857         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1858         string replacements instead of _web_stringByStrippingReturnCharacters
1859         and to use NSString methods instead of CFString functions.
1860
1861 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1862
1863         Ignore deprecation warnings.
1864
1865         * WebView/WebHTMLView.mm:
1866         (-[NSWindow _web_borderView]):
1867         (-[WebHTMLView _setAsideSubviews]):
1868         * WebView/WebView.mm:
1869         (-[WebView encodeWithCoder:]):
1870
1871 2017-12-02  Darin Adler  <darin@apple.com>
1872
1873         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1874         https://bugs.webkit.org/show_bug.cgi?id=180009
1875
1876         Reviewed by Alex Christensen.
1877
1878         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1879
1880         * Plugins/WebBaseNetscapePluginView.mm:
1881         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1882         of strcasecmp.
1883
1884         * WebView/WebPreferences.mm:
1885         (contains): Ditto. Also made this a template so it's easier to call on an array.
1886         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1887
1888 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1889
1890         Limit user agent versioning to an upper bound
1891         https://bugs.webkit.org/show_bug.cgi?id=180365
1892         <rdar://problem/34550617>
1893
1894         Reviewed by Joseph Pecoraro.
1895
1896         * WebView/WebView.mm:
1897         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1898         creating the User Agent string.
1899         (webKitBundleVersionString): Deleted.
1900
1901 2017-12-05  Andy Estes  <aestes@apple.com>
1902
1903         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1904         https://bugs.webkit.org/show_bug.cgi?id=180457
1905         <rdar://problem/35143007>
1906
1907         Reviewed by Tim Horton.
1908
1909         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1910         check for this macro during post-processing.
1911
1912         * postprocess-headers.sh:
1913
1914 2017-12-04  David Quesada  <david_quesada@apple.com>
1915
1916         Add a class for parsing application manifests
1917         https://bugs.webkit.org/show_bug.cgi?id=177973
1918         rdar://problem/34747949
1919
1920         Reviewed by Geoffrey Garen.
1921
1922         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1923
1924 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1925
1926         Make LegacyCustomProtocolManager optional for network process
1927         https://bugs.webkit.org/show_bug.cgi?id=176230
1928
1929         Reviewed by Alex Christensen.
1930
1931         * Configurations/FeatureDefines.xcconfig:
1932
1933 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1934
1935         Fix some NSOperationQueue leaks
1936         https://bugs.webkit.org/show_bug.cgi?id=180221
1937
1938         Reviewed by Wenson Hsieh.
1939
1940         * WebView/WebView.mm:
1941         (-[WebView performDragOperation:]):
1942
1943 2017-11-30  Darin Adler  <darin@apple.com>
1944
1945         [Mac] remove unneeded RetainPtr use introduced in r225142
1946         https://bugs.webkit.org/show_bug.cgi?id=180202
1947
1948         Reviewed by Tim Horton.
1949
1950         * WebView/WebImmediateActionController.mm:
1951         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1952         RetainPtr.
1953
1954 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1955
1956         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1957         https://bugs.webkit.org/show_bug.cgi?id=175595
1958
1959         Reviewed by Darin Adler.
1960
1961         * WebView/WebPreferences.mm:
1962
1963 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1964
1965         One too many zeroes in macOS version number in FeatureDefines
1966         https://bugs.webkit.org/show_bug.cgi?id=180011
1967
1968         Reviewed by Dan Bernstein.
1969
1970         * Configurations/FeatureDefines.xcconfig:
1971
1972 2017-11-23  Darin Adler  <darin@apple.com>
1973
1974         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1975         https://bugs.webkit.org/show_bug.cgi?id=179981
1976
1977         Reviewed by Sam Weinig.
1978
1979         * WebView/WebImmediateActionController.mm:
1980         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1981         * WebView/WebView.mm:
1982         (coreOptions): Use |= instead of | to build up FindOptions.
1983
1984 2017-11-23  Sam Weinig  <sam@webkit.org>
1985
1986         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1987         https://bugs.webkit.org/show_bug.cgi?id=179954
1988
1989         Reviewed by Darin Adler.
1990
1991         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1992         with direct calls to the corresponding UserGestureIndicator functions.
1993
1994         * Plugins/WebPluginController.mm:
1995         (-[WebPluginController processingUserGesture]):
1996         * WebView/WebView.mm:
1997         (-[WebView _isProcessingUserGesture]):
1998
1999 2017-11-23  Darin Adler  <darin@apple.com>
2000
2001         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
2002         https://bugs.webkit.org/show_bug.cgi?id=179907
2003
2004         Reviewed by Sam Weinig.
2005
2006         * History/BinaryPropertyList.cpp:
2007         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
2008         (BinaryPropertyListSerializer::appendStringObject): Ditto.
2009         * WebView/WebHTMLRepresentation.mm:
2010         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
2011         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
2012
2013 2017-11-22  Ali Juma  <ajuma@chromium.org>
2014
2015         Implement VisualViewport API attributes
2016         https://bugs.webkit.org/show_bug.cgi?id=179385
2017
2018         Reviewed by Frédéric Wang.
2019
2020         Add a VisualViewportAPI preference.
2021
2022         * WebView/WebPreferenceKeysPrivate.h:
2023         * WebView/WebPreferences.mm:
2024         (+[WebPreferences initialize]):
2025         (-[WebPreferences visualViewportAPIEnabled]):
2026         (-[WebPreferences setVisualViewportAPIEnabled:]):
2027         * WebView/WebPreferencesPrivate.h:
2028         * WebView/WebView.mm:
2029         (-[WebView _preferencesChanged:]):
2030
2031 2017-11-22  Christopher Reid  <chris.reid@sony.com>
2032
2033         WebCoreObjCExtras.h is being included in too many places
2034         https://bugs.webkit.org/show_bug.cgi?id=179931
2035
2036         Reviewed by Darin Adler.
2037
2038         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2039         * Plugins/WebBaseNetscapePluginView.mm:
2040         * Plugins/WebBasePluginPackage.mm:
2041         * Plugins/WebNetscapePluginStream.mm:
2042         * Plugins/WebNetscapePluginView.mm:
2043         * WebView/WebTextIterator.mm:
2044         * WebView/WebViewData.mm:
2045
2046 2017-11-22  Commit Queue  <commit-queue@webkit.org>
2047
2048         Unreviewed, rolling out r225093.
2049         https://bugs.webkit.org/show_bug.cgi?id=179938
2050
2051         Compilation failed on WinCairo 64-bit Release (Requested by
2052         fredw on #webkit).
2053
2054         Reverted changeset:
2055
2056         "Implement VisualViewport API attributes"
2057         https://bugs.webkit.org/show_bug.cgi?id=179385
2058         https://trac.webkit.org/changeset/225093
2059
2060 2017-11-21  Ali Juma  <ajuma@chromium.org>
2061
2062         Implement VisualViewport API attributes
2063         https://bugs.webkit.org/show_bug.cgi?id=179385
2064
2065         Reviewed by Frédéric Wang.
2066
2067         Add a VisualViewportAPI preference.
2068
2069         * WebView/WebPreferenceKeysPrivate.h:
2070         * WebView/WebPreferences.mm:
2071         (+[WebPreferences initialize]):
2072         (-[WebPreferences visualViewportAPIEnabled]):
2073         (-[WebPreferences setVisualViewportAPIEnabled:]):
2074         * WebView/WebPreferencesPrivate.h:
2075         * WebView/WebView.mm:
2076         (-[WebView _preferencesChanged:]):
2077
2078 2017-11-21  Christopher Reid  <chris.reid@sony.com>
2079
2080         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
2081         https://bugs.webkit.org/show_bug.cgi?id=179504
2082
2083         Reviewed by Darin Adler.
2084
2085         * Misc/WebKitNSStringExtras.mm:
2086         * Plugins/Hosted/NetscapePluginHostManager.mm:
2087         * Plugins/WebBasePluginPackage.mm:
2088
2089 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2090
2091         Remove unused TOUCH_ICON_LOADING feature flag
2092         https://bugs.webkit.org/show_bug.cgi?id=179873
2093
2094         Reviewed by Simon Fraser.
2095
2096         * Configurations/FeatureDefines.xcconfig:
2097
2098 2017-11-19  Tim Horton  <timothy_horton@apple.com>
2099
2100         Remove unused LEGACY_VENDOR_PREFIXES feature flag
2101         https://bugs.webkit.org/show_bug.cgi?id=179872
2102
2103         Reviewed by Darin Adler.
2104
2105         * Configurations/FeatureDefines.xcconfig:
2106
2107 2017-11-16  Daniel Bates  <dabates@apple.com>
2108
2109         Add feature define for alternative presentation button element
2110         https://bugs.webkit.org/show_bug.cgi?id=179692
2111         Part of <rdar://problem/34917108>
2112
2113         Reviewed by Andy Estes.
2114
2115         Only enabled on Cocoa platforms by default.
2116
2117         * Configurations/FeatureDefines.xcconfig:
2118
2119 2017-11-14  Nan Wang  <n_wang@apple.com>
2120
2121         AX: AOM: Implement AccessibleNode class and support label and role attributes
2122         https://bugs.webkit.org/show_bug.cgi?id=179494
2123
2124         Reviewed by Ryosuke Niwa.
2125
2126         * WebView/WebPreferenceKeysPrivate.h:
2127         * WebView/WebPreferences.mm:
2128         (+[WebPreferences initialize]):
2129         (-[WebPreferences accessibilityObjectModelEnabled]):
2130         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
2131         * WebView/WebPreferencesPrivate.h:
2132         * WebView/WebView.mm:
2133         (-[WebView _preferencesChanged:]):
2134
2135 2017-11-14  Alex Christensen  <achristensen@webkit.org>
2136
2137         Remove Cocoa CFURLConnection loading code
2138         https://bugs.webkit.org/show_bug.cgi?id=179688
2139
2140         Reviewed by Antti Koivisto.
2141
2142         * Misc/WebDownload.mm:
2143         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
2144         * Misc/WebDownloadInternal.h:
2145         * Plugins/WebBaseNetscapePluginView.mm:
2146         * WebCoreSupport/WebFrameLoaderClient.mm:
2147         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2148         * WebView/WebView.mm:
2149         (-[WebView scheduleInRunLoop:forMode:]):
2150         (-[WebView unscheduleFromRunLoop:forMode:]):
2151
2152 2017-11-14  Daniel Bates  <dabates@apple.com>
2153
2154         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
2155         for feature defines
2156
2157         Following r195498 and r201917 the Visual Studio property files for feature defines have
2158         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2159         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2160         files.
2161
2162         * Configurations/FeatureDefines.xcconfig:
2163
2164 2017-11-14  Jer Noble  <jer.noble@apple.com>
2165
2166         Enable Modern EME tests in DumpRenderTree
2167         https://bugs.webkit.org/show_bug.cgi?id=179544
2168
2169         Reviewed by Alex Christensen.
2170
2171         Add a WebPreferences property to enable the (modern) EME API.
2172
2173         * WebView/WebPreferenceKeysPrivate.h:
2174         * WebView/WebPreferences.mm:
2175         (+[WebPreferences initialize]):
2176         (-[WebPreferences encryptedMediaAPIEnabled]):
2177         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2178         * WebView/WebPreferencesPrivate.h:
2179         * WebView/WebView.mm:
2180         (-[WebView _preferencesChanged:]):
2181
2182 2017-11-14  Antti Koivisto  <antti@apple.com>
2183
2184         Enable display:contents by default
2185         https://bugs.webkit.org/show_bug.cgi?id=179655
2186
2187         Reviewed by Sam Weinig.
2188
2189         * WebView/WebPreferences.mm:
2190         (+[WebPreferences initialize]):
2191
2192 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2193
2194         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2195         https://bugs.webkit.org/show_bug.cgi?id=178751
2196
2197         Reviewed by Brady Eidson.
2198
2199         * WebCoreSupport/WebFrameNetworkingContext.mm:
2200         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2201
2202 2017-11-08  Keith Miller  <keith_miller@apple.com>
2203
2204         Async iteration should only fetch the next method once and add feature flag
2205         https://bugs.webkit.org/show_bug.cgi?id=179451
2206
2207         Reviewed by Geoffrey Garen.
2208
2209         Add feature flag for Async iteration.
2210
2211         * Configurations/FeatureDefines.xcconfig:
2212
2213 2017-11-13  Mark Lam  <mark.lam@apple.com>
2214
2215         Add more overflow check book-keeping for MarkedArgumentBuffer.
2216         https://bugs.webkit.org/show_bug.cgi?id=179634
2217         <rdar://problem/35492517>
2218
2219         Reviewed by Saam Barati.
2220
2221         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2222         (WebKit::NetscapePluginInstanceProxy::invoke):
2223         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2224         (WebKit::NetscapePluginInstanceProxy::construct):
2225
2226 2017-11-12  Darin Adler  <darin@apple.com>
2227
2228         More is<> and downcast<>, less static_cast<>
2229         https://bugs.webkit.org/show_bug.cgi?id=179600
2230
2231         Reviewed by Chris Dumez.
2232
2233         * DOM/DOM.mm:
2234         (kit): Use is/downcast.
2235         * WebCoreSupport/WebEditorClient.mm:
2236         (WebEditorClient::handleKeyboardEvent): Ditto.
2237         (WebEditorClient::handleInputMethodKeydown): Ditto.
2238         * WebView/WebHTMLView.mm:
2239         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2240
2241 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2242
2243         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2244         https://bugs.webkit.org/show_bug.cgi?id=179397
2245
2246         Reviewed by Wenson Hsieh.
2247
2248         * DOM/DOMHTMLInputElement.mm:
2249         (-[DOMHTMLInputElement insertTextSuggestion:]):
2250
2251 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2252
2253         HTMLMediaElement should not use element fullscreen on iOS
2254         https://bugs.webkit.org/show_bug.cgi?id=179418
2255         rdar://problem/35409277
2256
2257         Reviewed by Eric Carlson.
2258
2259         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2260
2261         * Configurations/FeatureDefines.xcconfig:
2262
2263 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2264
2265         Make ResourceLoader::willSendRequestInternal asynchronous
2266         https://bugs.webkit.org/show_bug.cgi?id=179251
2267
2268         Reviewed by Andy Estes.
2269
2270         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2271         (WebKit::HostedNetscapePluginStream::start):
2272         * Plugins/WebNetscapePluginStream.mm:
2273         (WebNetscapePluginStream::start):
2274
2275 2017-11-01  Darin Adler  <darin@apple.com>
2276
2277         Simplify event dispatch code and make it a bit more consistent
2278         https://bugs.webkit.org/show_bug.cgi?id=178991
2279
2280         Reviewed by Chris Dumez.
2281
2282         * DOM/DOMEvent.mm:
2283         (-[DOMEvent srcElement]): Call target instead of srcElement.
2284
2285 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2286
2287         [Touch Bar Web API] Add support for menuitem tag
2288         https://bugs.webkit.org/show_bug.cgi?id=179020
2289
2290         Reviewed by Ryosuke Niwa.
2291
2292         Adds in properties and methods that allow the menuitem runtime feature
2293         to be enabled or disabled.
2294
2295         * WebView/WebPreferenceKeysPrivate.h:
2296         * WebView/WebPreferences.mm:
2297         (-[WebPreferences menuItemElementEnabled]):
2298         (-[WebPreferences setMenuItemElementEnabled:]):
2299         * WebView/WebPreferencesPrivate.h:
2300         * WebView/WebView.mm:
2301         (-[WebView _preferencesChanged:]):
2302
2303 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2304
2305         Use CompletionHandlers for redirects
2306         https://bugs.webkit.org/show_bug.cgi?id=179163
2307
2308         Reviewed by Tim Horton.
2309
2310         * Plugins/Hosted/HostedNetscapePluginStream.h:
2311         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2312         (WebKit::HostedNetscapePluginStream::willSendRequest):
2313         * Plugins/WebNetscapePluginStream.h:
2314         * Plugins/WebNetscapePluginStream.mm:
2315         (WebNetscapePluginStream::willSendRequest):
2316
2317 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2318
2319         Add a FileSystem namespace to FileSystem.cpp
2320         https://bugs.webkit.org/show_bug.cgi?id=179063
2321
2322         Reviewed by Darin Adler.
2323
2324         * Misc/WebNSFileManagerExtras.mm:
2325         * Storage/WebDatabaseProvider.mm:
2326
2327 2017-11-02  Frederic Wang  <fwang@igalia.com>
2328
2329         Add references to bug 179167 in FIXME comments
2330         https://bugs.webkit.org/show_bug.cgi?id=179168
2331
2332         Reviewed by Daniel Bates.
2333
2334         * Configurations/FeatureDefines.xcconfig:
2335
2336 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2337
2338         Implement WKFullscreenWindowController for iOS.
2339         https://bugs.webkit.org/show_bug.cgi?id=178924
2340         rdar://problem/34697120
2341
2342         Reviewed by Simon Fraser.
2343
2344         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2345
2346         * Configurations/FeatureDefines.xcconfig:
2347         * WebView/WebView.mm:
2348         (-[WebView fullScreenPlaceholderView]):
2349
2350 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2351
2352         Clean up some drag and drop feature flags
2353         https://bugs.webkit.org/show_bug.cgi?id=179082
2354
2355         Reviewed by Simon Fraser.
2356
2357         * Configurations/FeatureDefines.xcconfig:
2358
2359 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2360
2361         Make it possible to test rubber-banding in overflow scroll
2362         https://bugs.webkit.org/show_bug.cgi?id=179078
2363
2364         Reviewed by Sam Weinig.
2365
2366         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2367         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2368
2369         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2370         functions, since most callers want clamped.
2371
2372         * DOM/DOMHTML.mm:
2373         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2374
2375 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2376
2377         Fix up some content filtering feature flags
2378         https://bugs.webkit.org/show_bug.cgi?id=179079
2379
2380         Reviewed by Simon Fraser.
2381
2382         * Configurations/FeatureDefines.xcconfig:
2383
2384 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2385
2386         [FrameView::layout cleanup] Move core layout logic to a separate class.
2387         https://bugs.webkit.org/show_bug.cgi?id=178771
2388         <rdar://problem/35166542>
2389
2390         Reviewed by Simon Fraser.
2391
2392         Move layout code out from FrameView to LayoutContext.
2393
2394         * WebView/WebClipView.mm:
2395         (-[WebClipView _immediateScrollToPoint:]):
2396         * WebView/WebFrame.mm:
2397         (-[WebFrame layoutCount]):
2398
2399 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2400
2401         Fix issues with WebView subframe painting
2402         https://bugs.webkit.org/show_bug.cgi?id=178842
2403         rdar://problem/34072253
2404
2405         Reviewed by Daniel Bates.
2406         
2407         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2408         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2409         High Sierra, so match the new signature.
2410
2411         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2412
2413         * WebView/WebHTMLView.mm:
2414         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2415         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2416
2417 2017-10-25  Youenn Fablet  <youenn@apple.com>
2418
2419         Enable ServiceWorker to fetch resources
2420         https://bugs.webkit.org/show_bug.cgi?id=178673
2421
2422         Reviewed by Brady Eidson.
2423
2424         * WebCoreSupport/WebFrameLoaderClient.mm:
2425         (WebFrameLoaderClient::pageID const):
2426         (WebFrameLoaderClient::frameID const):
2427         (WebFrameLoaderClient::sessionID const):
2428
2429         Added implementation to the new getters.
2430         They are noop in the context of WK1.
2431
2432 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2433
2434         Web Inspector: Enable WebKit logging configuration and display
2435         https://bugs.webkit.org/show_bug.cgi?id=177027
2436         <rdar://problem/33964767>
2437
2438         Reviewed by Joseph Pecoraro.
2439
2440         * WebCoreSupport/WebChromeClient.mm:
2441         (stringForMessageSource): Deal with Media and WebRTC message sources.
2442
2443 2017-10-20  Antoine Quint  <graouts@apple.com>
2444
2445         [Web Animations] Provide basic timeline and animation interfaces
2446         https://bugs.webkit.org/show_bug.cgi?id=178526
2447
2448         Reviewed by Dean Jackson.
2449
2450         Remove the WEB_ANIMATIONS compile-time flag.
2451
2452         * Configurations/FeatureDefines.xcconfig:
2453         * WebView/WebPreferences.mm:
2454         (+[WebPreferences initialize]):
2455         * WebView/WebView.mm:
2456         (-[WebView _preferencesChanged:]):
2457
2458 2017-10-19  Sam Weinig  <sam@webkit.org>
2459
2460         [Settings] Move global settings into their own file
2461         https://bugs.webkit.org/show_bug.cgi?id=178512
2462
2463         Reviewed by Darin Adler.
2464
2465         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2466
2467         * WebCoreSupport/WebChromeClient.mm:
2468         (WebChromeClient::supportsVideoFullscreen):
2469         * WebView/WebDynamicScrollBarsView.mm:
2470         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2471         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2472         * WebView/WebPreferences.mm:
2473         (+[WebPreferences initialize]):
2474         * WebView/WebView.mm:
2475         (-[WebView _commonInitializationWithFrameName:groupName:]):
2476         (-[WebView _preferencesChanged:]):
2477         (+[WebView _doNotStartObservingNetworkReachability]):
2478
2479 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2480
2481         Replace some stack raw pointers with RefPtrs within WebCore/html
2482         https://bugs.webkit.org/show_bug.cgi?id=178201
2483         <rdar://problem/34841692>
2484
2485         Reviewed by Ryosuke Niwa.
2486
2487         * DOM/DOM.mm:
2488         (kit):
2489         Change the type of node as toNode() is changed to return RefPtr.
2490
2491 2017-10-18  Chris Dumez  <cdumez@apple.com>
2492
2493         [Service Worker] Add stubs for Client / WindowClient / Clients
2494         https://bugs.webkit.org/show_bug.cgi?id=178469
2495
2496         Reviewed by Youenn Fablet.
2497
2498         Rename PageVisiblityState to VisibilityState.
2499
2500         * WebView/WebView.mm:
2501         (kit):
2502
2503 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2504
2505         Unreviewed, rolling out r223291.
2506
2507         See WebCore ChangeLog for more detail.
2508
2509         Reverted changeset:
2510
2511         "Remove Editor::simplifyMarkup"
2512         https://bugs.webkit.org/show_bug.cgi?id=178271
2513         https://trac.webkit.org/changeset/223291
2514
2515 2017-10-17  Keith Miller  <keith_miller@apple.com>
2516
2517         Change WebCore sources to work with unified source builds
2518         https://bugs.webkit.org/show_bug.cgi?id=178229
2519
2520         Rubber stamped by Tim Horton.
2521
2522         * Configurations/FeatureDefines.xcconfig:
2523
2524 2017-10-16  Sam Weinig  <sam@webkit.org>
2525
2526         [Settings] Remove all custom code from Settings.h/cpp
2527         https://bugs.webkit.org/show_bug.cgi?id=178330
2528
2529         Reviewed by Simon Fraser.
2530
2531         * WebView/WebPreferences.mm:
2532         (+[WebPreferences initialize]):
2533         
2534             Update for naming changes of FrameFlattening now that it is an enum class.
2535
2536 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2537
2538         Remove Editor::simplifyMarkup
2539         https://bugs.webkit.org/show_bug.cgi?id=178271
2540
2541         Reviewed by Wenson Hsieh.
2542
2543         * WebView/WebView.mm:
2544         (-[WebView _simplifyMarkup:endNode:]):
2545
2546 2017-10-12  Chris Dumez  <cdumez@apple.com>
2547
2548         [Mac] Add support for MouseEvent.buttons
2549         https://bugs.webkit.org/show_bug.cgi?id=178214
2550
2551         Reviewed by Ryosuke Niwa.
2552
2553         * WebView/WebPDFView.mm:
2554         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2555
2556 2017-10-11  Sam Weinig  <sam@webkit.org>
2557
2558         Remove out-parameter variants of copyToVector
2559         https://bugs.webkit.org/show_bug.cgi?id=178155
2560
2561         Reviewed by Tim Horton.
2562
2563         * Plugins/WebNetscapePluginView.mm:
2564         (-[WebNetscapePluginView destroyPlugin]):
2565         * WebView/WebHTMLRepresentation.mm:
2566         (newArrayWithStrings):
2567
2568             Replace out-parameter based copyToVector, with one that returns a Vector.
2569
2570 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2571
2572         Sanitize URL in pasteboard for other applications and cross origin content
2573         https://bugs.webkit.org/show_bug.cgi?id=178060
2574         <rdar://problem/34874518>
2575
2576         Reviewed by Wenson Hsieh.
2577
2578         * WebCoreSupport/WebPlatformStrategies.h:
2579         * WebCoreSupport/WebPlatformStrategies.mm:
2580         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2581
2582 2017-10-11  Chris Dumez  <cdumez@apple.com>
2583
2584         Modernize Geolocation code
2585         https://bugs.webkit.org/show_bug.cgi?id=178148
2586
2587         Reviewed by Ryosuke Niwa.
2588
2589         * WebCoreSupport/WebGeolocationClient.h:
2590         * WebCoreSupport/WebGeolocationClient.mm:
2591         (WebGeolocationClient::lastPosition):
2592         * WebView/WebGeolocationPosition.mm:
2593         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2594         (core):
2595         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2596         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2597         * WebView/WebGeolocationPositionInternal.h:
2598
2599 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2600
2601         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2602         https://bugs.webkit.org/show_bug.cgi?id=178154
2603
2604         Reviewed by Wenson Hsieh.
2605
2606         Enable custom pasteboard data by default.
2607
2608         * WebView/WebPreferenceKeysPrivate.h:
2609         * WebView/WebPreferences.mm:
2610         (+[WebPreferences initialize]):
2611         (-[WebPreferences customPasteboardDataEnabled]): Added.
2612         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2613         * WebView/WebPreferencesPrivate.h:
2614         * WebView/WebView.mm:
2615         (-[WebView _preferencesChanged:]):
2616
2617 2017-10-10  Sam Weinig  <sam@webkit.org>
2618
2619         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2620         https://bugs.webkit.org/show_bug.cgi?id=178102
2621
2622         Reviewed by Tim Horton.
2623
2624         * History/WebHistory.mm:
2625         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2626         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2627         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2628         * WebCoreSupport/WebUserMediaClient.mm:
2629         (WebUserMediaClient::pageDestroyed):
2630
2631 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2632
2633         Make the names of the options consistent
2634         https://bugs.webkit.org/show_bug.cgi?id=177933
2635
2636         Reviewed by Saam Barati.
2637
2638         * WebView/WebFrame.h:
2639         * WebView/WebHTMLView.mm:
2640         (-[WebHTMLView setMarkedText:selectedRange:]):
2641         * WebView/WebView.h:
2642
2643 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2644
2645         [iOS] Tweak support for classifying form controls (followup to r222487)
2646         https://bugs.webkit.org/show_bug.cgi?id=177917
2647         <rdar://problem/34820122>
2648
2649         Reviewed by Dean Jackson.
2650
2651         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2652
2653         * DOM/DOMHTMLInputElement.mm:
2654         (-[DOMHTMLInputElement _autofillContext]):
2655         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2656         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2657
2658 2017-10-05  Keith Miller  <keith_miller@apple.com>
2659
2660         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2661
2662         * Configurations/WebKitLegacy.xcconfig:
2663
2664 2017-10-05  Jer Noble  <jer.noble@apple.com>
2665
2666         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2667         https://bugs.webkit.org/show_bug.cgi?id=177261
2668
2669         Reviewed by Eric Carlson.
2670
2671         * Configurations/FeatureDefines.xcconfig:
2672
2673 2017-10-05  Chris Dumez  <cdumez@apple.com>
2674
2675         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2676         https://bugs.webkit.org/show_bug.cgi?id=177957
2677
2678         Reviewed by Alex Christensen.
2679
2680         * WebCoreSupport/WebPlatformStrategies.h:
2681         * WebCoreSupport/WebPlatformStrategies.mm:
2682         (WebPlatformStrategies::cookiesEnabled):
2683
2684 2017-10-05  Youenn Fablet  <youenn@apple.com>
2685
2686         Make LibWebRTCProvider port agnostic
2687         https://bugs.webkit.org/show_bug.cgi?id=177747
2688
2689         Reviewed by Alex Christensen & Alex Garcia.
2690
2691         * WebView/WebView.mm:
2692         (-[WebView _commonInitializationWithFrameName:groupName:]):
2693         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2694
2695 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2696
2697         Stop linking with WebKitSystemInterface
2698         https://bugs.webkit.org/show_bug.cgi?id=177915
2699
2700         Reviewed by Antti Koivisto.
2701
2702         * Configurations/DebugRelease.xcconfig:
2703         * Configurations/WebKitLegacy.xcconfig:
2704
2705 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2706
2707         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2708         https://bugs.webkit.org/show_bug.cgi?id=177912
2709
2710         Reviewed by Saam Barati.
2711
2712         * Carbon/CarbonUtils.m:
2713         * Carbon/CarbonWindowAdapter.mm:
2714         * Carbon/HIWebView.mm:
2715         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2716         * Misc/WebNSFileManagerExtras.mm:
2717         * Misc/WebNSPasteboardExtras.mm:
2718         * Misc/WebNSURLExtras.mm:
2719         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2720         * Plugins/Hosted/NetscapePluginHostManager.mm:
2721         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2722         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2723         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2724         * Plugins/Hosted/WebTextInputWindowController.m:
2725         * Plugins/WebBaseNetscapePluginView.mm:
2726         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2727         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2728         * Plugins/WebNetscapePluginStream.mm:
2729         * Plugins/WebNetscapePluginView.mm:
2730         * Plugins/WebPluginDatabase.mm:
2731         * WebCoreSupport/PopupMenuMac.mm:
2732         * WebCoreSupport/WebChromeClient.mm:
2733         * WebCoreSupport/WebFrameLoaderClient.mm:
2734         * WebCoreSupport/WebInspectorClient.mm:
2735         * WebCoreSupport/WebPlatformStrategies.mm:
2736         * WebCoreSupport/WebSystemInterface.mm:
2737         * WebView/WebDynamicScrollBarsView.mm:
2738         * WebView/WebFrame.mm:
2739         * WebView/WebFrameView.mm:
2740         * WebView/WebFullScreenController.mm:
2741         * WebView/WebHTMLView.mm:
2742         * WebView/WebPreferences.mm:
2743         * WebView/WebView.mm:
2744
2745 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2746
2747         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2748         rdar://problem/34705779
2749
2750         Addressing review comments that I somehow landed without.
2751
2752         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2753
2754 2017-09-29  Chris Dumez  <cdumez@apple.com>
2755
2756         Split some logic out of VisitedLinkStore and make it reusable
2757         https://bugs.webkit.org/show_bug.cgi?id=177575
2758
2759         Reviewed by Alex Christensen.
2760
2761         * WebCoreSupport/WebVisitedLinkStore.h:
2762         * WebCoreSupport/WebVisitedLinkStore.mm:
2763         (WebVisitedLinkStore::addVisitedLink):
2764         (WebVisitedLinkStore::removeVisitedLink):
2765         (WebVisitedLinkStore::isLinkVisited):
2766         (WebVisitedLinkStore::addVisitedLinkHash):
2767
2768 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2769
2770         Build fix for High Sierra 32 bit Mac
2771         https://bugs.webkit.org/show_bug.cgi?id=177551
2772         <rdar://problem/34690283>
2773
2774         Reviewed by Alexey Proskuryakov.
2775
2776         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2777         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2778         also made.
2779
2780         * Carbon/CarbonWindowAdapter.mm:
2781         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2782         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2783         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2784         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2785         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2786         (-[CarbonWindowAdapter dealloc]):
2787         (-[CarbonWindowAdapter windowRef]):
2788         (-[CarbonWindowAdapter _hasWindowRef]):
2789         (-[CarbonWindowAdapter _managesWindowRef]):
2790         (-[CarbonWindowAdapter _removeWindowRef]):
2791         (-[CarbonWindowAdapter _carbonWindowClass]):
2792         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2793         (-[CarbonWindowAdapter sendSuperEvent:]):
2794         (-[CarbonWindowAdapter relinquishFocus]):
2795         (-[CarbonWindowAdapter _cancelKey:]):
2796         (-[CarbonWindowAdapter _commonAwake]):
2797         (-[CarbonWindowAdapter _destroyRealWindow:]):
2798         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2799         (-[CarbonWindowAdapter _termWindowIfOwner]):
2800         (-[CarbonWindowAdapter _windowMovedToRect:]):
2801         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2802         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2803         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2804         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2805         (-[CarbonWindowAdapter canBecomeMainWindow]):
2806         (-[CarbonWindowAdapter encodeWithCoder:]):
2807         (-[CarbonWindowAdapter initWithCoder:]):
2808         (-[CarbonWindowAdapter setContentView:]):
2809         (-[CarbonWindowAdapter worksWhenModal]):
2810         (-[CarbonWindowAdapter _setModalWindowLevel]):
2811         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2812         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2813         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2814         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2815         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2816         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2817         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2818         (NSCarbonWindowHandleEvent):
2819         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2820         (-[CarbonWindowAdapter _growBoxRect]):
2821         * Carbon/HIWebView.mm:
2822         (HIWebViewGetWebView):
2823         (HIWebViewConstructor):
2824         (HIWebViewDestructor):
2825         (HIWebViewRegisterClass):
2826         (GetBehaviors):
2827         (Draw):
2828         (HitTest):
2829         (GetRegion):
2830         (GetWindowRef):
2831         (CreateNSEventAdoptingCGEvent):
2832         (CopyEventCGEvent):
2833         (CreateNSEventWithCarbonClickEvent):
2834         (Click):
2835         (CreateNSEventWithCarbonEvent):
2836         (MouseUp):
2837         (CreateNSEventWithCarbonMouseMoveEvent):
2838         (MouseMoved):
2839         (MouseDragged):
2840         (MouseWheelMoved):
2841         (ContextMenuClick):
2842         (GetKind):
2843         (BoundsChanged):
2844         (OwningWindowChanged):
2845         (WindowHandler):
2846         (SyncFrame):
2847         (SetFocusPart):
2848         (AdvanceFocus):
2849         (RelinquishFocus):
2850         (ActiveStateChanged):
2851         (ProcessCommand):
2852         (UpdateCommandStatus):
2853         (_NSSelectorForHICommand):
2854         (HIWebViewEventHandler):
2855         (StartUpdateObserver):
2856         (StopUpdateObserver):
2857         (UpdateObserver):
2858
2859 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2860
2861         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2862         https://bugs.webkit.org/show_bug.cgi?id=172526
2863         <rdar://problem/32396081>
2864
2865         Reviewed by Ryosuke Niwa.
2866
2867         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2868
2869         * WebCoreSupport/WebPlatformStrategies.h:
2870         * WebCoreSupport/WebPlatformStrategies.mm:
2871         (WebPlatformStrategies::webExposedTypes):
2872         (WebPlatformStrategies::writeCustomData):
2873
2874 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2875
2876         Unreviewed, rolling out r222567.
2877
2878         This broke and internal build.
2879
2880         Reverted changeset:
2881
2882         "Build fix for High Sierra 32 bit Mac"
2883         https://bugs.webkit.org/show_bug.cgi?id=177551
2884         http://trac.webkit.org/changeset/222567
2885
2886 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2887
2888         Build fix for High Sierra 32 bit Mac
2889         https://bugs.webkit.org/show_bug.cgi?id=177551
2890         <rdar://problem/34690283>
2891
2892         Reviewed by Alexey Proskuryakov.
2893
2894         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2895         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2896         also made.
2897
2898         * Carbon/CarbonWindowAdapter.mm:
2899         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2900         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2901         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2902         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2903         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2904         (-[CarbonWindowAdapter dealloc]):
2905         (-[CarbonWindowAdapter windowRef]):
2906         (-[CarbonWindowAdapter _hasWindowRef]):
2907         (-[CarbonWindowAdapter _managesWindowRef]):
2908         (-[CarbonWindowAdapter _removeWindowRef]):
2909         (-[CarbonWindowAdapter _carbonWindowClass]):
2910         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2911         (-[CarbonWindowAdapter sendSuperEvent:]):
2912         (-[CarbonWindowAdapter relinquishFocus]):
2913         (-[CarbonWindowAdapter _cancelKey:]):
2914         (-[CarbonWindowAdapter _commonAwake]):
2915         (-[CarbonWindowAdapter _destroyRealWindow:]):
2916         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2917         (-[CarbonWindowAdapter _termWindowIfOwner]):
2918         (-[CarbonWindowAdapter _windowMovedToRect:]):
2919         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2920         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2921         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2922         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2923         (-[CarbonWindowAdapter canBecomeMainWindow]):
2924         (-[CarbonWindowAdapter encodeWithCoder:]):
2925         (-[CarbonWindowAdapter initWithCoder:]):
2926         (-[CarbonWindowAdapter setContentView:]):
2927         (-[CarbonWindowAdapter worksWhenModal]):
2928         (-[CarbonWindowAdapter _setModalWindowLevel]):
2929         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2930         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2931         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2932         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2933         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2934         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2935         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2936         (NSCarbonWindowHandleEvent):
2937         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2938         (-[CarbonWindowAdapter _growBoxRect]):
2939         * Carbon/HIWebView.mm:
2940         (HIWebViewGetWebView):
2941         (HIWebViewConstructor):
2942         (HIWebViewDestructor):
2943         (HIWebViewRegisterClass):
2944         (GetBehaviors):
2945         (Draw):
2946         (HitTest):
2947         (GetRegion):
2948         (GetWindowRef):
2949         (CreateNSEventAdoptingCGEvent):
2950         (CopyEventCGEvent):
2951         (CreateNSEventWithCarbonClickEvent):
2952         (Click):
2953         (CreateNSEventWithCarbonEvent):
2954         (MouseUp):
2955         (CreateNSEventWithCarbonMouseMoveEvent):
2956         (MouseMoved):
2957         (MouseDragged):
2958         (MouseWheelMoved):
2959         (ContextMenuClick):
2960         (GetKind):
2961         (BoundsChanged):
2962         (OwningWindowChanged):
2963         (WindowHandler):
2964         (SyncFrame):
2965         (SetFocusPart):
2966         (AdvanceFocus):
2967         (RelinquishFocus):
2968         (ActiveStateChanged):
2969         (ProcessCommand):
2970         (UpdateCommandStatus):
2971         (_NSSelectorForHICommand):
2972         (HIWebViewEventHandler):
2973         (StartUpdateObserver):
2974         (StopUpdateObserver):
2975         (UpdateObserver):
2976
2977 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2978
2979         Make PolicyAction an encodable enum class
2980         https://bugs.webkit.org/show_bug.cgi?id=177480
2981
2982         Reviewed by Antti Koivisto.
2983
2984         * Plugins/WebPluginContainerCheck.mm:
2985         (-[WebPluginContainerCheck _continueWithPolicy:]):
2986         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2987         * WebCoreSupport/WebFrameLoaderClient.mm:
2988         (-[WebFramePolicyListener invalidate]):
2989         (-[WebFramePolicyListener ignore]):
2990         (-[WebFramePolicyListener download]):
2991         (-[WebFramePolicyListener use]):
2992         (-[WebFramePolicyListener continue]):
2993         * WebView/WebPolicyDelegate.mm:
2994         (-[WebPolicyDecisionListener use]):
2995         (-[WebPolicyDecisionListener ignore]):
2996         (-[WebPolicyDecisionListener download]):
2997
2998 2017-09-25  Frederik Riedel  <riedel@apple.com>
2999
3000         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
3001         https://bugs.webkit.org/show_bug.cgi?id=174394
3002         <rdar://problem/33183504>
3003
3004         Reviewed by Ryosuke Niwa.
3005
3006         * DOM/DOMHTMLInputElement.h:
3007         * DOM/DOMHTMLInputElement.mm:
3008         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
3009         Determines if this HTMLInputElement is part of a login screen.
3010         (-[DOMHTMLInputElement representingPageUrl]):
3011         Returns the webpage's URL that is currently displayed in the Web View.
3012         (-[DOMHTMLInputElement insertTextSuggestion:]):
3013         Inserts login credentials into the Web View.
3014
3015 2017-09-25  Sam Weinig  <sam@webkit.org>
3016
3017         Remove unused EditorClient functions
3018         https://bugs.webkit.org/show_bug.cgi?id=177463
3019
3020         Reviewed by Alex Christensen.
3021
3022         Remove unused EditorClient functions.
3023
3024         * WebCoreSupport/WebEditorClient.h:
3025         * WebCoreSupport/WebEditorClient.mm:
3026         (WebEditorClient::canonicalizeURL): Deleted.
3027         (WebEditorClient::canonicalizeURLString): Deleted.
3028         (WebEditorClient::writeDataToPasteboard): Deleted.
3029         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
3030         (WebEditorClient::readDataFromPasteboard): Deleted.
3031         (WebEditorClient::pasteboardChangeCount): Deleted.
3032
3033 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3034
3035         Stop using PolicyCallback
3036         https://bugs.webkit.org/show_bug.cgi?id=176088
3037
3038         Reviewed by Andy Estes.
3039
3040         * WebCoreSupport/WebFrameLoaderClient.mm:
3041         (-[WebFramePolicyListener invalidate]):
3042         (-[WebFramePolicyListener receivedPolicyDecision:]):
3043
3044 2017-09-25  Sam Weinig  <sam@webkit.org>
3045
3046         Remove unnecessary userVisibleString EditorClient function
3047         https://bugs.webkit.org/show_bug.cgi?id=177456
3048
3049         Reviewed by Dan Bernstein.
3050
3051         * WebCoreSupport/WebEditorClient.h:
3052         * WebCoreSupport/WebEditorClient.mm:
3053         (WebEditorClient::userVisibleString): Deleted.
3054
3055             Remove userVisibleString client function.
3056
3057 2017-09-25  Alex Christensen  <achristensen@webkit.org>
3058
3059         Separate form submission from PolicyChecker infrastructure
3060         https://bugs.webkit.org/show_bug.cgi?id=177396
3061
3062         Reviewed by Geoffrey Garen.
3063
3064         * WebCoreSupport/WebFrameLoaderClient.h:
3065         * WebCoreSupport/WebFrameLoaderClient.mm:
3066         (WebFrameLoaderClient::dispatchWillSubmitForm):
3067
3068 2017-09-22  Zalan Bujtas  <zalan@apple.com>
3069
3070         WeakPtrFactory should populate m_ref lazily.
3071         https://bugs.webkit.org/show_bug.cgi?id=177375
3072
3073         Reviewed by Geoffrey Garen.
3074
3075         * WebCoreSupport/WebEditorClient.mm:
3076         (WebEditorClient::WebEditorClient):
3077         (WebEditorClient::requestCandidatesForSelection):
3078
3079 2017-09-22  Chris Dumez  <cdumez@apple.com>
3080
3081         Use high resolution timestamp for event time
3082         https://bugs.webkit.org/show_bug.cgi?id=154246
3083         <rdar://problem/34333304>
3084
3085         Reviewed by Ryosuke Niwa.
3086
3087         Use WallTime / MonotonicTime instead of double type for clarity.
3088
3089         * DOM/DOMEvent.mm:
3090         (-[DOMEvent timeStamp]):
3091         * WebView/WebFrame.mm:
3092         (-[WebFrame _dragSourceEndedAt:operation:]):
3093         * WebView/WebPDFView.mm:
3094         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3095
3096 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
3097
3098         Enable dataTransfer.items on macOS and iOS
3099         https://bugs.webkit.org/show_bug.cgi?id=177335
3100
3101         Reviewed by Sam Weinig.
3102
3103         * WebView/WebPreferences.mm:
3104         (+[WebPreferences initialize]):
3105
3106 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
3107
3108         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
3109         https://bugs.webkit.org/show_bug.cgi?id=177101
3110         <rdar://problem/34500648>
3111
3112         Reviewed by Brian Burg.
3113
3114         * WebInspector/WebNodeHighlight.mm:
3115         Ensure we close the window that we have just removed.
3116
3117 2017-09-20  Antti Koivisto  <antti@apple.com>
3118
3119         Remove DOM and styling support for CSS Regions
3120         https://bugs.webkit.org/show_bug.cgi?id=177221
3121
3122         Reviewed by Andreas Kling.
3123
3124         * Configurations/FeatureDefines.xcconfig:
3125         * DOM/DOMCSS.mm:
3126         (kitClass):
3127         * DOM/DOMElement.mm:
3128         (-[DOMElement webkitRegionOverset]): Deleted.
3129
3130 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
3131
3132         Layering violation in Editor::createFragment
3133         https://bugs.webkit.org/show_bug.cgi?id=176123
3134
3135         Reviewed by Darin Adler.
3136
3137         * Misc/WebNSURLExtras.h:
3138         * Misc/WebNSURLExtras.mm:
3139         * WebView/WebFrame.mm:
3140         * WebView/WebHTMLView.mm:
3141         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
3142
3143         * WebCoreSupport/WebEditorClient.mm:
3144         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
3145         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
3146         way to avoid exporting the symbol just on newer OSes.
3147
3148 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
3149
3150         On iOS, getData can't get text set by setData during copy event
3151         https://bugs.webkit.org/show_bug.cgi?id=176980
3152         <rdar://problem/34453915>
3153
3154         Reviewed by Darin Adler.
3155
3156         * WebCoreSupport/WebPlatformStrategies.h:
3157         * WebCoreSupport/WebPlatformStrategies.mm:
3158         (WebPlatformStrategies::copy): Deleted.
3159
3160 2017-09-18  Andy Estes  <aestes@apple.com>
3161
3162         [Mac] Upstream miscellaneous WebKitSystemInterface functions
3163         https://bugs.webkit.org/show_bug.cgi?id=177029
3164
3165         Reviewed by Alex Christensen.
3166
3167         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3168         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3169         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3170         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3171         * WebCoreSupport/PopupMenuMac.mm:
3172         (PopupMenuMac::show):
3173         * WebCoreSupport/WebSystemInterface.mm:
3174         (InitWebCoreSystemInterface):
3175         * WebView/WebHTMLView.mm:
3176         (-[WebHTMLView setDataSource:]):
3177         (-[WebHTMLView attachRootLayer:]):
3178         * WebView/WebView.mm:
3179         (-[WebView _needsAdobeFrameReloadingQuirk]):
3180         (-[WebView _needsLinkElementTextCSSQuirk]):
3181         (-[WebView _needsIsLoadingInAPISenseQuirk]):
3182         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
3183         (-[WebView _preferencesChanged:]):
3184
3185 2017-09-15  Andy Estes  <aestes@apple.com>
3186
3187         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
3188         https://bugs.webkit.org/show_bug.cgi?id=176953
3189
3190         Reviewed by Eric Carlson.
3191
3192         * WebCoreSupport/WebSystemInterface.mm:
3193         (InitWebCoreSystemInterface):
3194
3195 2017-09-14  Andy Estes  <aestes@apple.com>
3196
3197         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
3198         https://bugs.webkit.org/show_bug.cgi?id=176931
3199
3200         Reviewed by Joseph Pecoraro.
3201
3202         * WebCoreSupport/WebSystemInterface.mm:
3203         (InitWebCoreSystemInterface):
3204
3205 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3206
3207         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
3208         https://bugs.webkit.org/show_bug.cgi?id=176867
3209
3210         Reviewed by Sam Weinig.
3211
3212         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3213         (WebKit::NetscapePluginInstanceProxy::enumerate):
3214
3215 2017-09-13  Andy Estes  <aestes@apple.com>
3216
3217         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
3218         https://bugs.webkit.org/show_bug.cgi?id=176729
3219
3220         Reviewed by Alex Christensen.
3221
3222         * WebCoreSupport/WebSystemInterface.mm:
3223         (InitWebCoreSystemInterface):
3224         * WebView/WebView.mm:
3225         (+[WebView _setCacheModel:]):
3226
3227 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3228
3229         Refactor WebContentReader out of EditorMac and EditorIOS
3230         https://bugs.webkit.org/show_bug.cgi?id=176770
3231
3232         Reviewed by Sam Weinig.
3233
3234         * WebCoreSupport/WebEditorClient.mm:
3235
3236 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3237
3238         Dragging & dropping a file creates an attachment element even when it's disabled
3239         https://bugs.webkit.org/show_bug.cgi?id=176769
3240
3241         Reviewed by Tim Horton.
3242
3243         * WebView/WebView.mm:
3244         (-[WebView _preferencesChanged:]):
3245
3246 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3247
3248         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3249         https://bugs.webkit.org/show_bug.cgi?id=176721
3250         <rdar://problem/34373660>
3251
3252         Reviewed by Tim Horton.
3253
3254         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3255         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3256
3257         * WebView/WebView.mm:
3258         (-[WebView _startDrag:]):
3259         (-[WebView _draggedElementBounds]):
3260         (-[WebView _endedDataInteraction:global:]):
3261         * WebView/WebViewData.h:
3262
3263 2017-09-11  Andy Estes  <aestes@apple.com>
3264
3265         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3266         https://bugs.webkit.org/show_bug.cgi?id=176472
3267
3268         Reviewed by Eric Carlson.
3269
3270         * WebCoreSupport/WebSystemInterface.mm:
3271         (InitWebCoreSystemInterface):
3272
3273 2017-09-09  Mark Lam  <mark.lam@apple.com>
3274
3275         Avoid duplicate computations of ExecState::vm().
3276         https://bugs.webkit.org/show_bug.cgi?id=176647
3277
3278         Reviewed by Saam Barati.
3279
3280         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3281         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3282         (WebKit::NetscapePluginInstanceProxy::construct):
3283         (WebKit::NetscapePluginInstanceProxy::setProperty):
3284         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3285         (WebKit::NetscapePluginInstanceProxy::enumerate):
3286         * Plugins/Hosted/ProxyInstance.mm:
3287         (WebKit::ProxyRuntimeMethod::create):
3288
3289 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3290
3291         Unreviewed, rolling out r221773.
3292         https://bugs.webkit.org/show_bug.cgi?id=176614
3293
3294         This caused build failures. (Requested by mlewis13 on
3295         #webkit).
3296
3297         Reverted changeset:
3298
3299         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3300         https://bugs.webkit.org/show_bug.cgi?id=176472
3301         http://trac.webkit.org/changeset/221773
3302
3303 2017-09-07  Andy Estes  <aestes@apple.com>
3304
3305         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3306         https://bugs.webkit.org/show_bug.cgi?id=176472
3307
3308         Reviewed by Eric Carlson.
3309
3310         * WebCoreSupport/WebSystemInterface.mm:
3311         (InitWebCoreSystemInterface):
3312
3313 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3314
3315         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3316         https://bugs.webkit.org/show_bug.cgi?id=176561
3317
3318         Reviewed by Brent Fulgham.
3319
3320         * Misc/WebNSUserDefaultsExtras.mm:
3321
3322 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3323
3324         Modernize Geolocation code
3325         https://bugs.webkit.org/show_bug.cgi?id=176496
3326
3327         Reviewed by Andy Estes.
3328
3329         * WebCoreSupport/WebGeolocationClient.h:
3330         * WebCoreSupport/WebGeolocationClient.mm:
3331         (WebGeolocationClient::requestPermission):
3332         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3333         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3334         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3335         * WebView/WebView.mm:
3336         (-[WebView _commonInitializationWithFrameName:groupName:]):
3337         (-[WebView _geolocationDidFailWithMessage:]):
3338
3339 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3340
3341         Remove some unused bits of code and resources
3342         https://bugs.webkit.org/show_bug.cgi?id=176275
3343
3344         Reviewed by Dan Bernstein.
3345
3346         * Misc/WebNSFileManagerExtras.mm:
3347         Include FileSystem instead of FileSystemIOS.
3348
3349 2017-09-03  Darin Adler  <darin@apple.com>
3350
3351         [Cocoa] Tidy a few things in legacy WebHTMLView
3352         https://bugs.webkit.org/show_bug.cgi?id=176280
3353
3354         Reviewed by Dan Bernstein.
3355
3356         * WebCoreSupport/WebChromeClient.mm:
3357         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3358         methods it calls on WebHTMLView were doing nothing on iOS.
3359
3360         * WebView/WebFrame.mm:
3361         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3362         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3363
3364         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3365         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3366         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3367         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3368         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3369         Use RetainPtr instead of writing retain/release wherever possible.
3370         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3371         initialization for it. Removed various unused methods and declarations of methods.
3372         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3373         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3374         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3375         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3376         and remove CFRetain no longer needed since we don't support garbage collection any more.
3377         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3378         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3379         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3380         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3381         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3382         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3383         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3384         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3385         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3386         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3387         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3388         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3389         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3390         debug flag; we haven't used it for years and it's not clearly helpful.
3391         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3392         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3393         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3394         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3395         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3396         two additional methods in the WebPrivate category and still be called by the two
3397         methods in the WebInternal category that were already using it.
3398         (-[WebHTMLView didAddSubview:]): Deleted.
3399         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3400         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3401         place this was called, the close method.
3402         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3403         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3404         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3405         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3406         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3407         Added helper method to make the one below simpler.
3408         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3409         Compared pasteboard type strings using isEqualToString: rather than using == since
3410         we want to actually compare the string contents. Also updated to use modern for loop,
3411         renamed a local variable from "s" to "localSubresources", and factored out the handling
3412         of three image types to use the helper method above.
3413         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3414         _web_makePluginSubviewsPerformSelector:withObject: method.
3415         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3416         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3417         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3418         not call the -[NSView subviews] method to make this identical on both platforms and used
3419         a modern for loop.
3420         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3421         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3422         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3423         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3424         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3425         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3426         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3427         of it is Mac-only.
3428         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3429         method did was call itself on the main thread, and do nothing if called on main thread.
3430         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3431         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3432         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3433         half of this method.
3434         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3435         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3436         Simplified using a modern for loop and RetainPtr.
3437         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3438         (-[WebHTMLView keyDown:]): Ditto.
3439         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3440         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3441         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3442         (-[WebHTMLView complete:]): Ditto.
3443         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3444         now macOS-only.
3445         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3446         iOS since that is now macOS-only.
3447         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3448         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3449         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3450         and reorganized to use early return.
3451         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3452         on iOS, but kept there so we don't have to do #if at every call site.
3453         (-[WebHTMLView _pluginController]): Moved into internal category.
3454         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3455         there only for GC, using C++ initialization, removing obsolete comment.
3456         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3457         peculiar iOS-only comment.
3458         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3459
3460         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3461         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3462         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3463         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3464         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3465
3466         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3467         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3468         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3469         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3470         them at this time.
3471
3472 2017-09-03  Sam Weinig  <sam@webkit.org>
3473
3474         Remove CanvasProxy
3475         https://bugs.webkit.org/show_bug.cgi?id=176288
3476
3477         Reviewed by Yusuke Suzuki.
3478
3479         CanvasProxy does not appear to be in any current HTML spec
3480         and was disabled and unimplemented in our tree. Time to 
3481         get rid of it.
3482
3483         * Configurations/FeatureDefines.xcconfig:
3484
3485 2017-09-02  Andy Estes  <aestes@apple.com>
3486
3487         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3488         https://bugs.webkit.org/show_bug.cgi?id=176270
3489
3490         Reviewed by Tim Horton.
3491
3492         * Plugins/Hosted/NetscapePluginHostManager.mm:
3493         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3494         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3495         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3496         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3497         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3498         (WebKit::SoftwareCARenderer::context const):
3499         (WebKit::SoftwareCARenderer::renderContext const):
3500         (WebKit::SoftwareCARenderer::render):
3501         (-[WebHostedNetscapePluginView createPlugin]):
3502         (-[WebHostedNetscapePluginView createPluginLayer]):
3503         (-[WebHostedNetscapePluginView destroyPlugin]):
3504         (-[WebHostedNetscapePluginView drawRect:]):
3505         * WebCoreSupport/WebSystemInterface.mm:
3506         (InitWebCoreSystemInterface):
3507
3508 2017-09-01  Andy Estes  <aestes@apple.com>
3509
3510         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3511         https://bugs.webkit.org/show_bug.cgi?id=176200
3512
3513         Reviewed by Tim Horton.
3514
3515         * Carbon/HIWebView.mm:
3516         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3517         (overrideCGContext):
3518         (restoreCGContext):
3519         (Draw):
3520         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3521         (+[WebHostedNetscapePluginView initialize]):
3522         * Plugins/WebBaseNetscapePluginView.h:
3523         * Plugins/WebBaseNetscapePluginView.mm:
3524         (WebKit::sendUserChangeNotifications):
3525         * Plugins/WebNetscapePluginView.mm:
3526         (+[WebNetscapePluginView initialize]):
3527         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3528         * WebCoreSupport/WebSystemInterface.mm:
3529         (InitWebCoreSystemInterface):
3530         * WebView/WebFrame.mm:
3531         (-[WebFrame _paintBehaviorForDestinationContext:]):
3532         * WebView/WebFullScreenController.mm:
3533         (setClipRectForWindow):
3534         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3535         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3536         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3537         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3538
3539 2017-08-31  Andy Estes  <aestes@apple.com>
3540
3541         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3542         https://bugs.webkit.org/show_bug.cgi?id=176175
3543
3544         Reviewed by Brady Eidson.
3545
3546         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3547         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3548         * Plugins/Hosted/WebTextInputWindowController.m:
3549         (-[WebTextInputPanel init]):
3550         * WebCoreSupport/WebSystemInterface.mm:
3551         (InitWebCoreSystemInterface):
3552         * WebView/WebDynamicScrollBarsView.mm:
3553         (-[WebDynamicScrollBarsView scrollWheel:]):
3554         * WebView/WebHTMLView.mm:
3555         (-[WebHTMLView _removeWindowObservers]):
3556         (-[WebHTMLView addWindowObservers]):
3557         * WebView/WebView.mm:
3558         (-[WebView addWindowObserversForWindow:]):
3559         (-[WebView removeWindowObservers]):
3560         (-[WebView viewWillMoveToWindow:]):
3561
3562 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3563
3564         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3565         https://bugs.webkit.org/show_bug.cgi?id=175779
3566         <rdar://problem/22367975>
3567
3568         Reviewed by Tim Horton.
3569
3570         * WebCoreSupport/WebFrameLoaderClient.h:
3571         * WebCoreSupport/WebFrameLoaderClient.mm:
3572         (WebFrameLoaderClient::webGLPolicyForURL const):
3573         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3574
3575 2017-08-30  Andy Estes  <aestes@apple.com>
3576
3577         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3578         https://bugs.webkit.org/show_bug.cgi?id=176093
3579
3580         Reviewed by Eric Carlson.
3581
3582         * WebCoreSupport/WebSystemInterface.mm:
3583         (InitWebCoreSystemInterface):
3584
3585 2017-08-30  Andy Estes  <aestes@apple.com>
3586
3587         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3588         https://bugs.webkit.org/show_bug.cgi?id=176087
3589
3590         Reviewed by Alex Christensen.
3591
3592         * Carbon/CarbonUtils.m:
3593         (getNSAutoreleasePoolCount):
3594         (WebInitForCarbon):
3595         (PoolCleaner):
3596         * Carbon/CarbonWindowAdapter.mm:
3597         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3598         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3599         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3600         (-[CarbonWindowAdapter _windowMovedToRect:]):
3601         * Carbon/HIViewAdapter.m:
3602         * Carbon/HIWebView.mm:
3603         (Draw):
3604         (CreateNSEventAdoptingCGEvent):
3605         (CopyEventCGEvent):
3606         (CreateNSEventWithCarbonClickEvent):
3607         (Click):
3608         (CreateNSEventWithCarbonEvent):
3609         (MouseUp):
3610         (CreateNSEventWithCarbonMouseMoveEvent):
3611         (MouseMoved):
3612         (MouseDragged):
3613         (MouseWheelMoved):
3614         (WindowHandler):
3615         (HIWebViewEventHandler):
3616         * Misc/QuickDrawCompatibility.h: Removed.
3617         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3618         (getCarbonEvent):
3619         (WebNetscapePluginEventHandlerCarbon::keyDown):
3620         (WebNetscapePluginEventHandlerCarbon::keyUp):
3621         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3622         (WebNetscapePluginEventHandlerCocoa::keyDown):
3623         * Plugins/WebNetscapePluginView.mm:
3624         (-[WebNetscapePluginView tellQuickTimeToChill]):
3625
3626 2017-08-29  Andy Estes  <aestes@apple.com>
3627
3628         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3629         https://bugs.webkit.org/show_bug.cgi?id=176046
3630
3631         Reviewed by Alex Christensen.
3632
3633         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3634         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3635
3636         * Misc/WebNSFileManagerExtras.mm:
3637         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3638         (setMetaData): Deleted.
3639         * WebCoreSupport/WebSystemInterface.mm:
3640         (InitWebCoreSystemInterface):
3641
3642 2017-08-28  Andy Estes  <aestes@apple.com>
3643
3644         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3645         https://bugs.webkit.org/show_bug.cgi?id=176039
3646
3647         Reviewed by Alex Christensen.
3648
3649         * WebCoreSupport/WebSystemInterface.mm:
3650         (InitWebCoreSystemInterface):
3651         * WebView/WebPreferences.mm:
3652         (+[WebPreferences _systemCFStringEncoding]):
3653
3654 2017-08-28  Andy Estes  <aestes@apple.com>
3655
3656         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3657         https://bugs.webkit.org/show_bug.cgi?id=176032
3658
3659         Reviewed by Alex Christensen.
3660
3661         * WebCoreSupport/WebSystemInterface.mm:
3662         (InitWebCoreSystemInterface):
3663         * WebView/WebView.mm:
3664         (-[WebView _cachedResponseForURL:]):
3665
3666 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3667
3668         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3669         https://bugs.webkit.org/show_bug.cgi?id=175992
3670         <rdar://problem/34086613>
3671
3672         Reviewed by Daniel Bates.
3673
3674         * WebCoreSupport/WebPlatformStrategies.h:
3675         * WebCoreSupport/WebPlatformStrategies.mm:
3676         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3677         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3678         indicating if secure cookies were accessed.
3679
3680 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3681
3682         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3683         https://bugs.webkit.org/show_bug.cgi?id=170955
3684         <rdar://problem/31697653>
3685
3686         Reviewed by Ryosuke Niwa.
3687
3688         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3689         text is being replaced.
3690
3691         * WebView/WebHTMLView.mm:
3692         (-[WebHTMLView insertText:]):
3693
3694 2017-08-24  Chris Dumez  <cdumez@apple.com>
3695
3696         [Directory Upload] Add basic support for input.webkitdirectory
3697         https://bugs.webkit.org/show_bug.cgi?id=175950
3698         <rdar://problem/33951915>
3699
3700         Reviewed by Geoffrey Garen.
3701
3702         Add private API to toggle Directory Upload support on Mac WebKit1.
3703
3704         * WebView/WebPreferenceKeysPrivate.h:
3705         * WebView/WebPreferences.mm:
3706         (+[WebPreferences initialize]):
3707         (-[WebPreferences setDirectoryUploadEnabled:]):
3708         (-[WebPreferences directoryUploadEnabled]):
3709         * WebView/WebPreferencesPrivate.h:
3710         * WebView/WebView.mm:
3711         (-[WebView _preferencesChanged:]):
3712
3713 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3714
3715         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3716         https://bugs.webkit.org/show_bug.cgi?id=175370
3717         <rdar://problem/33799806>
3718
3719         Reviewed by Ryosuke Niwa.
3720
3721         Adjust WebEditorClient for interface changes.
3722
3723         * WebCoreSupport/WebEditorClient.h:
3724
3725 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3726
3727         Remove ChromeClient::scrollbarsModeDidChange
3728         https://bugs.webkit.org/show_bug.cgi?id=175805
3729
3730         Reviewed by Daniel Bates.
3731
3732         * WebCoreSupport/WebChromeClient.h:
3733
3734 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3735
3736         Remove ChromeClient::hasOpenedPopup
3737         https://bugs.webkit.org/show_bug.cgi?id=175804
3738
3739         Reviewed by Sam Weinig.
3740
3741         * WebCoreSupport/WebChromeClient.h:
3742         * WebCoreSupport/WebChromeClient.mm:
3743         (WebChromeClient::hasOpenedPopup const): Deleted.
3744
3745 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3746
3747         Disable access to secure cookies if an HTTPS site loads mixed content
3748         https://bugs.webkit.org/show_bug.cgi?id=157053
3749         <rdar://problem/11290808>
3750
3751         Reviewed by Dan Bates.
3752
3753         * WebCoreSupport/WebPlatformStrategies.h:
3754         * WebCoreSupport/WebPlatformStrategies.mm:
3755         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3756         indicating whether secure cookies should be included in the response.
3757
3758 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3759
3760         [PAL] Move spi/mac directory into PAL
3761         https://bugs.webkit.org/show_bug.cgi?id=175649
3762
3763         Reviewed by Myles C. Maxfield.
3764
3765         * Misc/WebSharingServicePickerController.h:
3766         * WebCoreSupport/WebContextMenuClient.mm:
3767         * WebCoreSupport/WebEditorClient.mm:
3768         * WebCoreSupport/WebSelectionServiceController.mm:
3769         * WebView/WebHTMLView.mm:
3770         * WebView/WebImmediateActionController.h:
3771         * WebView/WebImmediateActionController.mm:
3772         * WebView/WebView.mm:
3773
3774 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3775
3776         [PAL] Relocate SessionID to root
3777         https://bugs.webkit.org/show_bug.cgi?id=175684
3778
3779         Reviewed by Alex Christensen.
3780
3781         * WebCoreSupport/WebFrameNetworkingContext.mm:
3782
3783 2017-08-17  Andreas Kling  <akling@apple.com>
3784
3785         Disable CSS regions at compile time
3786         https://bugs.webkit.org/show_bug.cgi?id=175630
3787
3788         Reviewed by Antti Koivisto.
3789
3790         * Configurations/FeatureDefines.xcconfig:
3791
3792 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3793
3794         [PAL] Move SessionID into PAL
3795         https://bugs.webkit.org/show_bug.cgi?id=174192
3796
3797         Reviewed by Antti Koivisto.
3798
3799         * Misc/WebCache.mm:
3800         (+[WebCache imageForURL:]):
3801         * WebCoreSupport/WebFrameLoaderClient.h:
3802         * WebCoreSupport/WebFrameLoaderClient.mm:
3803         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3804         * WebCoreSupport/WebFrameNetworkingContext.mm:
3805         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3806         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3807         (WebFrameNetworkingContext::storageSession const):
3808         * WebCoreSupport/WebPlatformStrategies.h:
3809         * WebCoreSupport/WebPlatformStrategies.mm:
3810         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3811         * WebKitPrefix.h:
3812
3813 2017-08-16  Andy Estes  <aestes@apple.com>
3814
3815         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3816         https://bugs.webkit.org/show_bug.cgi?id=175648
3817
3818         Reviewed by Tim Horton.
3819
3820         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3821         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3822         (WebPaymentCoordinatorClient::showPaymentUI):
3823
3824 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3825
3826         [PAL] Move spi/ios and spi/win directories into PAL
3827         https://bugs.webkit.org/show_bug.cgi?id=175171
3828
3829         Reviewed by Antti Koivisto.
3830
3831         * WebCoreSupport/WebFrameLoaderClient.mm:
3832         * WebView/WebView.mm:
3833
3834 2017-08-16  Andy Estes  <aestes@apple.com>
3835
3836         [Payment Request] Add an ENABLE flag and an experimental feature preference
3837         https://bugs.webkit.org/show_bug.cgi?id=175622
3838
3839         Reviewed by Tim Horton.
3840
3841         * Configurations/FeatureDefines.xcconfig:
3842
3843 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3844
3845         [PAL] Move Sleep classes into PAL
3846         https://bugs.webkit.org/show_bug.cgi?id=175456
3847
3848         Reviewed by Ryosuke Niwa.
3849
3850         * WebView/WebFullScreenController.h:
3851
3852 2017-08-15  Youenn Fablet  <youenn@apple.com>
3853
3854         [Cache API] Adding generic support for CacheStorage and Cache methods
3855         https://bugs.webkit.org/show_bug.cgi?id=175455
3856
3857         Reviewed by Chris Dumez.
3858
3859         * WebView/WebView.mm:
3860         (-[WebView _commonInitializationWithFrameName:groupName:]):
3861
3862 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3863
3864         Remove Proximity Events and related code
3865         https://bugs.webkit.org/show_bug.cgi?id=175545
3866
3867         Reviewed by Daniel Bates.
3868
3869         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3870         and other related code.
3871
3872         * Configurations/FeatureDefines.xcconfig:
3873
3874 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3875
3876         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3877         https://bugs.webkit.org/show_bug.cgi?id=175504
3878
3879         Reviewed by Sam Weinig.
3880
3881         * Configurations/FeatureDefines.xcconfig:
3882         * DOM/DOMHTMLFormElement.mm:
3883         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3884         * WebCoreSupport/WebFrameLoaderClient.h:
3885
3886 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3887
3888         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3889         https://bugs.webkit.org/show_bug.cgi?id=175557
3890
3891         Reviewed by Jon Lee.
3892
3893         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3894
3895         * Configurations/FeatureDefines.xcconfig:
3896
3897 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3898
3899         Composition underline color is always black
3900         https://bugs.webkit.org/show_bug.cgi?id=174675
3901
3902         Reviewed by Ryosuke Niwa.
3903
3904         * WebView/WebHTMLView.mm:
3905         (extractUnderlines): If NSUnderlineColorAttributeName
3906         is not present use text color for composition underline.
3907         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3908         for composition underline in the plain text case.
3909
3910 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3911
3912         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3913         https://bugs.webkit.org/show_bug.cgi?id=175474
3914         <rdar://problem/33844628>
3915
3916         Reviewed by Wenson Hsieh.
3917
3918         Replaced the build flag by a runtime flag and disabled the feature by default.
3919
3920         * Configurations/FeatureDefines.xcconfig:
3921         * WebView/WebPreferenceKeysPrivate.h:
3922         * WebView/WebPreferences.mm:
3923         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3924         (-[WebPreferences dataTransferItemsEnabled]): Added.
3925         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3926         * WebView/WebPreferencesPrivate.h:
3927         * WebView/WebView.mm:
3928         (-[WebView _preferencesChanged:]):
3929
3930 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3931
3932         Remove ENABLE_GAMEPAD_DEPRECATED
3933         https://bugs.webkit.org/show_bug.cgi?id=175361
3934
3935         Reviewed by Carlos Garcia Campos.
3936
3937         * Configurations/FeatureDefines.xcconfig:
3938
3939 2017-08-09  Chris Dumez  <cdumez@apple.com>
3940
3941         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3942         https://bugs.webkit.org/show_bug.cgi?id=175401
3943
3944         Reviewed by Brady Eidson.
3945
3946         * WebView/WebPreferenceKeysPrivate.h:
3947         * WebView/WebPreferences.mm:
3948         (+[WebPreferences initialize]):
3949         (-[WebPreferences beaconAPIEnabled]): Deleted.
3950         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3951         * WebView/WebPreferencesPrivate.h:
3952         * WebView/WebView.mm:
3953         (-[WebView _preferencesChanged:]):
3954
3955 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3956
3957         [PAL] Move spi/cocoa and spi/cg directories into PAL
3958         https://bugs.webkit.org/show_bug.cgi?id=175175
3959
3960         Reviewed by Myles C. Maxfield.
3961
3962         * History/WebHistory.mm:
3963         * Misc/WebDownload.mm:
3964         * Misc/WebKitNSStringExtras.mm:
3965         * Plugins/Hosted/NetscapePluginHostManager.mm:
3966         * Plugins/WebPluginDatabase.mm:
3967         * WebCoreSupport/WebFrameLoaderClient.mm:
3968         * WebInspector/WebNodeHighlight.mm:
3969         * WebView/WebHTMLView.mm:
3970         * WebView/WebIndicateLayer.mm:
3971         * WebView/WebView.mm:
3972         * WebView/WebViewData.h:
3973
3974 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3975
3976         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3977         https://bugs.webkit.org/show_bug.cgi?id=175392
3978         <rdar://problem/33783207>
3979
3980         Reviewed by Tim Horton and Megan Gardner.
3981
3982         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3983
3984         * Configurations/FeatureDefines.xcconfig:
3985
3986 2017-08-09  Daniel Bates  <dabates@apple.com>
3987
3988         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3989         https://bugs.webkit.org/show_bug.cgi?id=175247
3990         <rdar://problem/33679804>
3991
3992         Reviewed by Brady Eidson.
3993
3994         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3995         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3996         clients that need to make use of this information at this time. If such a needs comes up
3997         then we can expose API/SPI similar to what we do for WebKit.
3998
3999         * WebCoreSupport/WebFrameLoaderClient.h:
4000         * WebCoreSupport/WebFrameLoaderClient.mm:
4001         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
4002
4003 2017-08-08  Brady Eidson  <beidson@apple.com>
4004
4005         Don't enable default icon loading in WK1 for apps linked against old SDKs.
4006         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
4007
4008         Reviewed by Andy Estes.
4009
4010         * Misc/WebKitVersionChecks.h:
4011         * WebCoreSupport/WebFrameLoaderClient.mm:
4012         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
4013           the app is linked against new WebKit with the new behavior.
4014
4015 2017-08-07  Devin Rousso  <drousso@apple.com>
4016
4017         Web Inspector: Preview Canvas path when viewing a recording
4018         https://bugs.webkit.org/show_bug.cgi?id=174967
4019
4020         Reviewed by Brian Burg.
4021
4022         * WebView/WebPreferenceKeysPrivate.h:
4023         * WebView/WebPreferences.mm:
4024         (+[WebPreferences initialize]):
4025         (-[WebPreferences inspectorAdditionsEnabled]):
4026         (-[WebPreferences setInspectorAdditionsEnabled:]):
4027         * WebView/WebPreferencesPrivate.h:
4028         * WebView/WebView.mm:
4029         (-[WebView _preferencesChanged:]):
4030         Add plumbing for new InspectorAdditions runtime flag.
4031
4032 2017-08-07  Brian Burg  <bburg@apple.com>
4033
4034         Remove CANVAS_PATH compilation guard
4035         https://bugs.webkit.org/show_bug.cgi?id=175207
4036
4037         Reviewed by Sam Weinig.
4038
4039         * Configurations/FeatureDefines.xcconfig:
4040
4041 2017-08-04  Youenn Fablet  <youenn@apple.com>
4042
4043         [Cache API] Add Cache and CacheStorage IDL definitions
4044         https://bugs.webkit.org/show_bug.cgi?id=175201
4045
4046         Reviewed by Brady Eidson.
4047
4048         * WebView/WebPreferenceKeysPrivate.h:
4049         * WebView/WebPreferences.mm:
4050         (+[WebPreferences initialize]):
4051         (-[WebPreferences cacheAPIEnabled]):
4052         (-[WebPreferences setCacheAPIEnabled:]):
4053         * WebView/WebPreferencesPrivate.h:
4054         * WebView/WebView.mm:
4055         (-[WebView _preferencesChanged:]):
4056
4057 2017-08-04  Matt Lewis  <jlewis3@apple.com>
4058
4059         Unreviewed, rolling out r220271.
4060
4061         Rolling out due to Layout Test failing on iOS Simulator.
4062
4063         Reverted changeset:
4064
4065         "Remove STREAMS_API compilation guard"
4066         https://bugs.webkit.org/show_bug.cgi?id=175165
4067         http://trac.webkit.org/changeset/220271
4068
4069 2017-08-04  Youenn Fablet  <youenn@apple.com>
4070
4071         Remove STREAMS_API compilation guard
4072         https://bugs.webkit.org/show_bug.cgi?id=175165
4073
4074         Reviewed by Darin Adler.
4075
4076         * Configurations/FeatureDefines.xcconfig:
4077         * WebView/WebPreferences.mm:
4078         (+[WebPreferences initialize]):
4079         * WebView/WebView.mm:
4080         (-[WebView _preferencesChanged:]):
4081
4082 2017-08-03  Brian Burg  <bburg@apple.com>
4083
4084         Remove ENABLE(WEB_SOCKET) guards
4085         https://bugs.webkit.org/show_bug.cgi?id=167044
4086
4087