Unreviewed, continue to fix build failures due to AppKit API deprecation
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Unreviewed, continue to fix build failures due to AppKit API deprecation
4
5         Wraps more code in -Wdeprecated-declarations.
6
7         * Carbon/HIWebView.mm:
8         (overrideCGContext):
9
10 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
11
12         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
13
14         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
15
16         * Carbon/CarbonWindowAdapter.mm:
17         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
18         * Plugins/WebNetscapePluginView.mm:
19         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
20         (-[WebNetscapePluginView sendDrawRectEvent:]):
21         (-[WebNetscapePluginView drawRect:]):
22
23 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
24
25         Fix build failures due to using deprecated AppKit symbols
26         https://bugs.webkit.org/show_bug.cgi?id=181110
27         <rdar://problem/36162865>
28
29         Reviewed by Dan Bernstein and Tim Horton.
30
31         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
32
33         * Misc/WebKitNSStringExtras.mm:
34         (-[NSString _web_drawAtPoint:font:textColor:]):
35         * Misc/WebNSPasteboardExtras.h:
36         * Misc/WebNSPasteboardExtras.mm:
37         (+[NSPasteboard _web_writableTypesForURL]):
38         (_createWritableTypesForImageWithoutArchive):
39         (_createWritableTypesForImageWithArchive):
40         (+[NSPasteboard _web_dragTypesForURL]):
41         (-[NSPasteboard _web_bestURL]):
42         (-[NSPasteboard _web_writeURL:andTitle:types:]):
43         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
44         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
45         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
46         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
47         * Panels/WebAuthenticationPanel.m:
48         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
49         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
50         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
51         (-[WebHostedNetscapePluginView drawRect:]):
52         * WebInspector/WebNodeHighlightView.mm:
53         (-[WebNodeHighlightView drawRect:]):
54         * WebView/WebFrame.mm:
55         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
56         (-[WebFrame _drawRect:contentsOnly:]):
57         * WebView/WebHTMLView.mm:
58         (kit):
59         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
60         (-[WebHTMLView _plainTextFromPasteboard:]):
61         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
62         (+[WebHTMLView _insertablePasteboardTypes]):
63         (+[WebHTMLView _selectionPasteboardTypes]):
64         (-[WebHTMLView pasteboard:provideDataForType:]):
65         (-[WebHTMLView _writeSelectionToPasteboard:]):
66         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
67         (-[WebHTMLView validRequestorForSendType:returnType:]):
68         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
69         (createMenuItem):
70         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
71         (-[WebHTMLView _colorAsString:]):
72         (-[WebHTMLView copyFont:]):
73         * WebView/WebPDFView.mm:
74         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
75         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
76         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
77         (-[WebPDFView pasteboardTypesForSelection]):
78         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
79         * WebView/WebView.h:
80         * WebView/WebView.mm:
81         (-[WebView performDragOperation:]):
82         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
83         (-[WebView _searchWithGoogleFromMenu:]):
84
85 2017-12-21  Youenn Fablet  <youenn@apple.com>
86
87         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
88         https://bugs.webkit.org/show_bug.cgi?id=181000
89
90         Reviewed by Chris Dumez.
91
92         * Misc/WebCache.mm:
93         (+[WebCache addImageToCache:forURL:forFrame:]):
94
95 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
96
97         Update FULLSCREEN_API feature defines.
98         https://bugs.webkit.org/show_bug.cgi?id=181015
99
100         Reviewed by Tim Horton.
101
102         Change enabled iphone sdk for FULLSCREEN_API.
103
104         * Configurations/FeatureDefines.xcconfig:
105
106 2017-12-21  Jer Noble  <jer.noble@apple.com>
107
108         Add initial DOM support for Media Capabilities
109         https://bugs.webkit.org/show_bug.cgi?id=181064
110
111         Reviewed by Eric Carlson.
112
113         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
114
115         * WebView/WebPreferenceKeysPrivate.h:
116         * WebView/WebPreferences.mm:
117         (+[WebPreferences initialize]):
118         (-[WebPreferences mediaCapabilitiesEnabled]):
119         (-[WebPreferences setMediaCapabilitiesEnabled:]):
120         * WebView/WebPreferencesPrivate.h:
121         * WebView/WebView.mm:
122         (-[WebView _preferencesChanged:]):
123
124 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
125
126         Enable picture-in-picture from inline element on suspend.
127         https://bugs.webkit.org/show_bug.cgi?id=180942
128         rdar://problem/34745234
129
130         Reviewed by Jer Noble.
131
132         Update signature of enterVideoFullscreenForVideoElement().
133
134         * WebCoreSupport/WebChromeClient.h:
135         * WebCoreSupport/WebChromeClient.mm:
136         (WebChromeClient::enterVideoFullscreenForVideoElement):
137
138 2017-12-20  Daniel Bates  <dabates@apple.com>
139
140         Remove Alternative Presentation Button
141         https://bugs.webkit.org/show_bug.cgi?id=180500
142         <rdar://problem/35891047>
143
144         Reviewed by Simon Fraser.
145
146         We no longer need the alternative presentation button.
147
148         * Configurations/FeatureDefines.xcconfig:
149
150 2017-12-19  Jer Noble  <jer.noble@apple.com>
151
152         Playing media elements which call "pause(); play()" will have the play promise rejected.
153         https://bugs.webkit.org/show_bug.cgi?id=180781
154         <rdar://problem/33191377>
155
156         Reviewed by Eric Carlson.
157
158         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
159
160         * WebView/WebView.mm:
161         (shouldRequireUserGestureToLoadVideo):
162
163 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
164
165         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
166         https://bugs.webkit.org/show_bug.cgi?id=180977
167
168         Reviewed by Tim Horton.
169
170         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
171         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
172         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
173
174         * WebCoreSupport/WebEditorClient.mm:
175         (attributesForAttributedStringConversion):
176         * WebView/WebHTMLView.mm:
177         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
178
179 2017-12-18  David Kilzer  <ddkilzer@apple.com>
180
181         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
182
183         Attempt to fix the following warnings:
184
185             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
186
187         For the following instance variables:
188
189             _borderView
190             _contentView
191             _frame
192             _wFlags
193
194         * Carbon/CarbonWindowAdapter.mm:
195         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
196         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
197         (-[CarbonWindowAdapter _termWindowIfOwner]):
198         (-[CarbonWindowAdapter _windowMovedToRect:]):
199         (-[CarbonWindowAdapter setContentView:]):
200         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
201         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
202
203 2017-12-16  Dan Bernstein  <mitz@apple.com>
204
205         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
206         https://bugs.webkit.org/show_bug.cgi?id=180613
207         <rdar://problem/35946124>
208
209         Reviewed by Geoff Garen.
210
211         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
212           clients.
213         * WebView/WebDynamicScrollBarsView.h: Ditto.
214         * WebView/WebDynamicScrollBarsView.mm: Ditto.
215
216 2017-12-14  David Kilzer  <ddkilzer@apple.com>
217
218         Enable -Wstrict-prototypes for WebKit
219         <https://webkit.org/b/180757>
220         <rdar://problem/36024132>
221
222         Rubber-stamped by Joseph Pecoraro.
223
224         * Configurations/Base.xcconfig:
225         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
226
227 2017-12-14  John Wilander  <wilander@apple.com>
228
229         Storage Access API: Implement frame-specific access in the document.cookie layer
230         https://bugs.webkit.org/show_bug.cgi?id=180682
231         <rdar://problem/35982257>
232
233         Reviewed by Alex Christensen.
234
235         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
236         CookiesStrategy::cookieRequestHeaderFieldValue(), and
237         CookiesStrategy::getRawCookies() now take optional parameters for
238         frameID and pageID to allow frame-specific scoping of cookies.
239
240         This change makes the return values of FrameLoaderClient::frameID()
241         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
242         WebCore can call those getters and get the right return values in
243         WebKit and std:nullopt in WebKitLegacy.
244
245         * WebCoreSupport/WebFrameLoaderClient.h:
246         * WebCoreSupport/WebFrameLoaderClient.mm:
247         (WebFrameLoaderClient::pageID const):
248         (WebFrameLoaderClient::frameID const):
249         * WebCoreSupport/WebPlatformStrategies.h:
250         * WebCoreSupport/WebPlatformStrategies.mm:
251         (WebPlatformStrategies::cookiesForDOM):
252         (WebPlatformStrategies::setCookiesFromDOM):
253         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
254         (WebPlatformStrategies::getRawCookies):
255
256 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
257
258         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
259         https://bugs.webkit.org/show_bug.cgi?id=180689
260
261         Reviewed by Tim Horton.
262
263         Use sRGBColorSpaceRef() from WebCore.
264
265         * WebView/WebHTMLView.mm:
266         (imageFromRect):
267
268 2017-12-11  Tim Horton  <timothy_horton@apple.com>
269
270         Stop using deprecated target conditional for simulator builds
271         https://bugs.webkit.org/show_bug.cgi?id=180662
272         <rdar://problem/35136156>
273
274         Reviewed by Simon Fraser.
275
276         * postprocess-headers.sh:
277
278 2017-12-11  David Quesada  <david_quesada@apple.com>
279
280         Turn on ENABLE_APPLICATION_MANIFEST
281         https://bugs.webkit.org/show_bug.cgi?id=180562
282         rdar://problem/35924737
283
284         Reviewed by Geoffrey Garen.
285
286         * Configurations/FeatureDefines.xcconfig:
287
288 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
289
290         Remove pthread_once in favor of dispatch_once
291         https://bugs.webkit.org/show_bug.cgi?id=180591
292
293         Reviewed by Saam Barati.
294
295         * Misc/WebKitErrors.m:
296         (+[NSError _registerWebKitErrors]):
297         (registerErrors): Deleted.
298         * Storage/WebStorageManager.mm:
299         (+[WebStorageManager _storageDirectoryPath]):
300         (initializeLocalStoragePath): Deleted.
301
302 2017-12-07  Darin Adler  <darin@apple.com>
303
304         Remove some unused code from WebKitLegacy
305         https://bugs.webkit.org/show_bug.cgi?id=180567
306
307         Reviewed by Anders Carlsson.
308
309         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
310         macOS (back a few versions) and iOS and removed unused
311         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
312         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
313         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
314         _webkit_stringByCollapsingNonPrintingCharacters,
315         _webkit_stringByCollapsingWhitespaceCharacters,
316         _web_stringWithData:textEncodingName:, and
317         _webkit_localStorageDirectoryWithBundleIdentifier:.
318
319         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
320         this source file.
321         (canUseFastRenderer): Made this faster by not calling u_charDirection for
322         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
323         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
324         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
325         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
326         handle font smoothing options.
327         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
328         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
329         from header and made it a little clearer.
330         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
331         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
332         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
333         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
334         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
335         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
336         implementation a bit and used whole words instead of abbreviations.
337         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
338
339         * Misc/WebNSFileManagerExtras.mm:
340         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
341         filenameByFixingIllegalCharacters function from WebCore directly instead of
342         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
343
344         * Plugins/WebBaseNetscapePluginView.mm:
345         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
346         string replacements instead of _web_stringByStrippingReturnCharacters
347         and to use NSString methods instead of CFString functions.
348
349 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
350
351         Ignore deprecation warnings.
352
353         * WebView/WebHTMLView.mm:
354         (-[NSWindow _web_borderView]):
355         (-[WebHTMLView _setAsideSubviews]):
356         * WebView/WebView.mm:
357         (-[WebView encodeWithCoder:]):
358
359 2017-12-02  Darin Adler  <darin@apple.com>
360
361         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
362         https://bugs.webkit.org/show_bug.cgi?id=180009
363
364         Reviewed by Alex Christensen.
365
366         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
367
368         * Plugins/WebBaseNetscapePluginView.mm:
369         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
370         of strcasecmp.
371
372         * WebView/WebPreferences.mm:
373         (contains): Ditto. Also made this a template so it's easier to call on an array.
374         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
375
376 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
377
378         Limit user agent versioning to an upper bound
379         https://bugs.webkit.org/show_bug.cgi?id=180365
380         <rdar://problem/34550617>
381
382         Reviewed by Joseph Pecoraro.
383
384         * WebView/WebView.mm:
385         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
386         creating the User Agent string.
387         (webKitBundleVersionString): Deleted.
388
389 2017-12-05  Andy Estes  <aestes@apple.com>
390
391         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
392         https://bugs.webkit.org/show_bug.cgi?id=180457
393         <rdar://problem/35143007>
394
395         Reviewed by Tim Horton.
396
397         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
398         check for this macro during post-processing.
399
400         * postprocess-headers.sh:
401
402 2017-12-04  David Quesada  <david_quesada@apple.com>
403
404         Add a class for parsing application manifests
405         https://bugs.webkit.org/show_bug.cgi?id=177973
406         rdar://problem/34747949
407
408         Reviewed by Geoffrey Garen.
409
410         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
411
412 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
413
414         Make LegacyCustomProtocolManager optional for network process
415         https://bugs.webkit.org/show_bug.cgi?id=176230
416
417         Reviewed by Alex Christensen.
418
419         * Configurations/FeatureDefines.xcconfig:
420
421 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
422
423         Fix some NSOperationQueue leaks
424         https://bugs.webkit.org/show_bug.cgi?id=180221
425
426         Reviewed by Wenson Hsieh.
427
428         * WebView/WebView.mm:
429         (-[WebView performDragOperation:]):
430
431 2017-11-30  Darin Adler  <darin@apple.com>
432
433         [Mac] remove unneeded RetainPtr use introduced in r225142
434         https://bugs.webkit.org/show_bug.cgi?id=180202
435
436         Reviewed by Tim Horton.
437
438         * WebView/WebImmediateActionController.mm:
439         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
440         RetainPtr.
441
442 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
443
444         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
445         https://bugs.webkit.org/show_bug.cgi?id=175595
446
447         Reviewed by Darin Adler.
448
449         * WebView/WebPreferences.mm:
450
451 2017-11-27  Tim Horton  <timothy_horton@apple.com>
452
453         One too many zeroes in macOS version number in FeatureDefines
454         https://bugs.webkit.org/show_bug.cgi?id=180011
455
456         Reviewed by Dan Bernstein.
457
458         * Configurations/FeatureDefines.xcconfig:
459
460 2017-11-23  Darin Adler  <darin@apple.com>
461
462         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
463         https://bugs.webkit.org/show_bug.cgi?id=179981
464
465         Reviewed by Sam Weinig.
466
467         * WebView/WebImmediateActionController.mm:
468         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
469         * WebView/WebView.mm:
470         (coreOptions): Use |= instead of | to build up FindOptions.
471
472 2017-11-23  Sam Weinig  <sam@webkit.org>
473
474         Remove unneeded ScriptController::processingUserGesture() forwarding functions
475         https://bugs.webkit.org/show_bug.cgi?id=179954
476
477         Reviewed by Darin Adler.
478
479         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
480         with direct calls to the corresponding UserGestureIndicator functions.
481
482         * Plugins/WebPluginController.mm:
483         (-[WebPluginController processingUserGesture]):
484         * WebView/WebView.mm:
485         (-[WebView _isProcessingUserGesture]):
486
487 2017-11-23  Darin Adler  <darin@apple.com>
488
489         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
490         https://bugs.webkit.org/show_bug.cgi?id=179907
491
492         Reviewed by Sam Weinig.
493
494         * History/BinaryPropertyList.cpp:
495         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
496         (BinaryPropertyListSerializer::appendStringObject): Ditto.
497         * WebView/WebHTMLRepresentation.mm:
498         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
499         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
500
501 2017-11-22  Ali Juma  <ajuma@chromium.org>
502
503         Implement VisualViewport API attributes
504         https://bugs.webkit.org/show_bug.cgi?id=179385
505
506         Reviewed by Frédéric Wang.
507
508         Add a VisualViewportAPI preference.
509
510         * WebView/WebPreferenceKeysPrivate.h:
511         * WebView/WebPreferences.mm:
512         (+[WebPreferences initialize]):
513         (-[WebPreferences visualViewportAPIEnabled]):
514         (-[WebPreferences setVisualViewportAPIEnabled:]):
515         * WebView/WebPreferencesPrivate.h:
516         * WebView/WebView.mm:
517         (-[WebView _preferencesChanged:]):
518
519 2017-11-22  Christopher Reid  <chris.reid@sony.com>
520
521         WebCoreObjCExtras.h is being included in too many places
522         https://bugs.webkit.org/show_bug.cgi?id=179931
523
524         Reviewed by Darin Adler.
525
526         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
527         * Plugins/WebBaseNetscapePluginView.mm:
528         * Plugins/WebBasePluginPackage.mm:
529         * Plugins/WebNetscapePluginStream.mm:
530         * Plugins/WebNetscapePluginView.mm:
531         * WebView/WebTextIterator.mm:
532         * WebView/WebViewData.mm:
533
534 2017-11-22  Commit Queue  <commit-queue@webkit.org>
535
536         Unreviewed, rolling out r225093.
537         https://bugs.webkit.org/show_bug.cgi?id=179938
538
539         Compilation failed on WinCairo 64-bit Release (Requested by
540         fredw on #webkit).
541
542         Reverted changeset:
543
544         "Implement VisualViewport API attributes"
545         https://bugs.webkit.org/show_bug.cgi?id=179385
546         https://trac.webkit.org/changeset/225093
547
548 2017-11-21  Ali Juma  <ajuma@chromium.org>
549
550         Implement VisualViewport API attributes
551         https://bugs.webkit.org/show_bug.cgi?id=179385
552
553         Reviewed by Frédéric Wang.
554
555         Add a VisualViewportAPI preference.
556
557         * WebView/WebPreferenceKeysPrivate.h:
558         * WebView/WebPreferences.mm:
559         (+[WebPreferences initialize]):
560         (-[WebPreferences visualViewportAPIEnabled]):
561         (-[WebPreferences setVisualViewportAPIEnabled:]):
562         * WebView/WebPreferencesPrivate.h:
563         * WebView/WebView.mm:
564         (-[WebView _preferencesChanged:]):
565
566 2017-11-21  Christopher Reid  <chris.reid@sony.com>
567
568         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
569         https://bugs.webkit.org/show_bug.cgi?id=179504
570
571         Reviewed by Darin Adler.
572
573         * Misc/WebKitNSStringExtras.mm:
574         * Plugins/Hosted/NetscapePluginHostManager.mm:
575         * Plugins/WebBasePluginPackage.mm:
576
577 2017-11-19  Tim Horton  <timothy_horton@apple.com>
578
579         Remove unused TOUCH_ICON_LOADING feature flag
580         https://bugs.webkit.org/show_bug.cgi?id=179873
581
582         Reviewed by Simon Fraser.
583
584         * Configurations/FeatureDefines.xcconfig:
585
586 2017-11-19  Tim Horton  <timothy_horton@apple.com>
587
588         Remove unused LEGACY_VENDOR_PREFIXES feature flag
589         https://bugs.webkit.org/show_bug.cgi?id=179872
590
591         Reviewed by Darin Adler.
592
593         * Configurations/FeatureDefines.xcconfig:
594
595 2017-11-16  Daniel Bates  <dabates@apple.com>
596
597         Add feature define for alternative presentation button element
598         https://bugs.webkit.org/show_bug.cgi?id=179692
599         Part of <rdar://problem/34917108>
600
601         Reviewed by Andy Estes.
602
603         Only enabled on Cocoa platforms by default.
604
605         * Configurations/FeatureDefines.xcconfig:
606
607 2017-11-14  Nan Wang  <n_wang@apple.com>
608
609         AX: AOM: Implement AccessibleNode class and support label and role attributes
610         https://bugs.webkit.org/show_bug.cgi?id=179494
611
612         Reviewed by Ryosuke Niwa.
613
614         * WebView/WebPreferenceKeysPrivate.h:
615         * WebView/WebPreferences.mm:
616         (+[WebPreferences initialize]):
617         (-[WebPreferences accessibilityObjectModelEnabled]):
618         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
619         * WebView/WebPreferencesPrivate.h:
620         * WebView/WebView.mm:
621         (-[WebView _preferencesChanged:]):
622
623 2017-11-14  Alex Christensen  <achristensen@webkit.org>
624
625         Remove Cocoa CFURLConnection loading code
626         https://bugs.webkit.org/show_bug.cgi?id=179688
627
628         Reviewed by Antti Koivisto.
629
630         * Misc/WebDownload.mm:
631         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
632         * Misc/WebDownloadInternal.h:
633         * Plugins/WebBaseNetscapePluginView.mm:
634         * WebCoreSupport/WebFrameLoaderClient.mm:
635         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
636         * WebView/WebView.mm:
637         (-[WebView scheduleInRunLoop:forMode:]):
638         (-[WebView unscheduleFromRunLoop:forMode:]):
639
640 2017-11-14  Daniel Bates  <dabates@apple.com>
641
642         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
643         for feature defines
644
645         Following r195498 and r201917 the Visual Studio property files for feature defines have
646         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
647         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
648         files.
649
650         * Configurations/FeatureDefines.xcconfig:
651
652 2017-11-14  Jer Noble  <jer.noble@apple.com>
653
654         Enable Modern EME tests in DumpRenderTree
655         https://bugs.webkit.org/show_bug.cgi?id=179544
656
657         Reviewed by Alex Christensen.
658
659         Add a WebPreferences property to enable the (modern) EME API.
660
661         * WebView/WebPreferenceKeysPrivate.h:
662         * WebView/WebPreferences.mm:
663         (+[WebPreferences initialize]):
664         (-[WebPreferences encryptedMediaAPIEnabled]):
665         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
666         * WebView/WebPreferencesPrivate.h:
667         * WebView/WebView.mm:
668         (-[WebView _preferencesChanged:]):
669
670 2017-11-14  Antti Koivisto  <antti@apple.com>
671
672         Enable display:contents by default
673         https://bugs.webkit.org/show_bug.cgi?id=179655
674
675         Reviewed by Sam Weinig.
676
677         * WebView/WebPreferences.mm:
678         (+[WebPreferences initialize]):
679
680 2017-11-13  Alex Christensen  <achristensen@webkit.org>
681
682         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
683         https://bugs.webkit.org/show_bug.cgi?id=178751
684
685         Reviewed by Brady Eidson.
686
687         * WebCoreSupport/WebFrameNetworkingContext.mm:
688         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
689
690 2017-11-08  Keith Miller  <keith_miller@apple.com>
691
692         Async iteration should only fetch the next method once and add feature flag
693         https://bugs.webkit.org/show_bug.cgi?id=179451
694
695         Reviewed by Geoffrey Garen.
696
697         Add feature flag for Async iteration.
698
699         * Configurations/FeatureDefines.xcconfig:
700
701 2017-11-13  Mark Lam  <mark.lam@apple.com>
702
703         Add more overflow check book-keeping for MarkedArgumentBuffer.
704         https://bugs.webkit.org/show_bug.cgi?id=179634
705         <rdar://problem/35492517>
706
707         Reviewed by Saam Barati.
708
709         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
710         (WebKit::NetscapePluginInstanceProxy::invoke):
711         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
712         (WebKit::NetscapePluginInstanceProxy::construct):
713
714 2017-11-12  Darin Adler  <darin@apple.com>
715
716         More is<> and downcast<>, less static_cast<>
717         https://bugs.webkit.org/show_bug.cgi?id=179600
718
719         Reviewed by Chris Dumez.
720
721         * DOM/DOM.mm:
722         (kit): Use is/downcast.
723         * WebCoreSupport/WebEditorClient.mm:
724         (WebEditorClient::handleKeyboardEvent): Ditto.
725         (WebEditorClient::handleInputMethodKeydown): Ditto.
726         * WebView/WebHTMLView.mm:
727         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
728
729 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
730
731         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
732         https://bugs.webkit.org/show_bug.cgi?id=179397
733
734         Reviewed by Wenson Hsieh.
735
736         * DOM/DOMHTMLInputElement.mm:
737         (-[DOMHTMLInputElement insertTextSuggestion:]):
738
739 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
740
741         HTMLMediaElement should not use element fullscreen on iOS
742         https://bugs.webkit.org/show_bug.cgi?id=179418
743         rdar://problem/35409277
744
745         Reviewed by Eric Carlson.
746
747         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
748
749         * Configurations/FeatureDefines.xcconfig:
750
751 2017-11-06  Alex Christensen  <achristensen@webkit.org>
752
753         Make ResourceLoader::willSendRequestInternal asynchronous
754         https://bugs.webkit.org/show_bug.cgi?id=179251
755
756         Reviewed by Andy Estes.
757
758         * Plugins/Hosted/HostedNetscapePluginStream.mm:
759         (WebKit::HostedNetscapePluginStream::start):
760         * Plugins/WebNetscapePluginStream.mm:
761         (WebNetscapePluginStream::start):
762
763 2017-11-01  Darin Adler  <darin@apple.com>
764
765         Simplify event dispatch code and make it a bit more consistent
766         https://bugs.webkit.org/show_bug.cgi?id=178991
767
768         Reviewed by Chris Dumez.
769
770         * DOM/DOMEvent.mm:
771         (-[DOMEvent srcElement]): Call target instead of srcElement.
772
773 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
774
775         [Touch Bar Web API] Add support for menuitem tag
776         https://bugs.webkit.org/show_bug.cgi?id=179020
777
778         Reviewed by Ryosuke Niwa.
779
780         Adds in properties and methods that allow the menuitem runtime feature
781         to be enabled or disabled.
782
783         * WebView/WebPreferenceKeysPrivate.h:
784         * WebView/WebPreferences.mm:
785         (-[WebPreferences menuItemElementEnabled]):
786         (-[WebPreferences setMenuItemElementEnabled:]):
787         * WebView/WebPreferencesPrivate.h:
788         * WebView/WebView.mm:
789         (-[WebView _preferencesChanged:]):
790
791 2017-11-02  Alex Christensen  <achristensen@webkit.org>
792
793         Use CompletionHandlers for redirects
794         https://bugs.webkit.org/show_bug.cgi?id=179163
795
796         Reviewed by Tim Horton.
797
798         * Plugins/Hosted/HostedNetscapePluginStream.h:
799         * Plugins/Hosted/HostedNetscapePluginStream.mm:
800         (WebKit::HostedNetscapePluginStream::willSendRequest):
801         * Plugins/WebNetscapePluginStream.h:
802         * Plugins/WebNetscapePluginStream.mm:
803         (WebNetscapePluginStream::willSendRequest):
804
805 2017-11-02  Christopher Reid  <chris.reid@sony.com>
806
807         Add a FileSystem namespace to FileSystem.cpp
808         https://bugs.webkit.org/show_bug.cgi?id=179063
809
810         Reviewed by Darin Adler.
811
812         * Misc/WebNSFileManagerExtras.mm:
813         * Storage/WebDatabaseProvider.mm:
814
815 2017-11-02  Frederic Wang  <fwang@igalia.com>
816
817         Add references to bug 179167 in FIXME comments
818         https://bugs.webkit.org/show_bug.cgi?id=179168
819
820         Reviewed by Daniel Bates.
821
822         * Configurations/FeatureDefines.xcconfig:
823
824 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
825
826         Implement WKFullscreenWindowController for iOS.
827         https://bugs.webkit.org/show_bug.cgi?id=178924
828         rdar://problem/34697120
829
830         Reviewed by Simon Fraser.
831
832         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
833
834         * Configurations/FeatureDefines.xcconfig:
835         * WebView/WebView.mm:
836         (-[WebView fullScreenPlaceholderView]):
837
838 2017-10-31  Tim Horton  <timothy_horton@apple.com>
839
840         Clean up some drag and drop feature flags
841         https://bugs.webkit.org/show_bug.cgi?id=179082
842
843         Reviewed by Simon Fraser.
844
845         * Configurations/FeatureDefines.xcconfig:
846
847 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
848
849         Make it possible to test rubber-banding in overflow scroll
850         https://bugs.webkit.org/show_bug.cgi?id=179078
851
852         Reviewed by Sam Weinig.
853
854         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
855         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
856
857         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
858         functions, since most callers want clamped.
859
860         * DOM/DOMHTML.mm:
861         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
862
863 2017-10-31  Tim Horton  <timothy_horton@apple.com>
864
865         Fix up some content filtering feature flags
866         https://bugs.webkit.org/show_bug.cgi?id=179079
867
868         Reviewed by Simon Fraser.
869
870         * Configurations/FeatureDefines.xcconfig:
871
872 2017-10-28  Zalan Bujtas  <zalan@apple.com>
873
874         [FrameView::layout cleanup] Move core layout logic to a separate class.
875         https://bugs.webkit.org/show_bug.cgi?id=178771
876         <rdar://problem/35166542>
877
878         Reviewed by Simon Fraser.
879
880         Move layout code out from FrameView to LayoutContext.
881
882         * WebView/WebClipView.mm:
883         (-[WebClipView _immediateScrollToPoint:]):
884         * WebView/WebFrame.mm:
885         (-[WebFrame layoutCount]):
886
887 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
888
889         Fix issues with WebView subframe painting
890         https://bugs.webkit.org/show_bug.cgi?id=178842
891         rdar://problem/34072253
892
893         Reviewed by Daniel Bates.
894         
895         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
896         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
897         High Sierra, so match the new signature.
898
899         Also rename the 'rect' param to 'displayRect' to match AppKit code.
900
901         * WebView/WebHTMLView.mm:
902         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
903         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
904
905 2017-10-25  Youenn Fablet  <youenn@apple.com>
906
907         Enable ServiceWorker to fetch resources
908         https://bugs.webkit.org/show_bug.cgi?id=178673
909
910         Reviewed by Brady Eidson.
911
912         * WebCoreSupport/WebFrameLoaderClient.mm:
913         (WebFrameLoaderClient::pageID const):
914         (WebFrameLoaderClient::frameID const):
915         (WebFrameLoaderClient::sessionID const):
916
917         Added implementation to the new getters.
918         They are noop in the context of WK1.
919
920 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
921
922         Web Inspector: Enable WebKit logging configuration and display
923         https://bugs.webkit.org/show_bug.cgi?id=177027
924         <rdar://problem/33964767>
925
926         Reviewed by Joseph Pecoraro.
927
928         * WebCoreSupport/WebChromeClient.mm:
929         (stringForMessageSource): Deal with Media and WebRTC message sources.
930
931 2017-10-20  Antoine Quint  <graouts@apple.com>
932
933         [Web Animations] Provide basic timeline and animation interfaces
934         https://bugs.webkit.org/show_bug.cgi?id=178526
935
936         Reviewed by Dean Jackson.
937
938         Remove the WEB_ANIMATIONS compile-time flag.
939
940         * Configurations/FeatureDefines.xcconfig:
941         * WebView/WebPreferences.mm:
942         (+[WebPreferences initialize]):
943         * WebView/WebView.mm:
944         (-[WebView _preferencesChanged:]):
945
946 2017-10-19  Sam Weinig  <sam@webkit.org>
947
948         [Settings] Move global settings into their own file
949         https://bugs.webkit.org/show_bug.cgi?id=178512
950
951         Reviewed by Darin Adler.
952
953         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
954
955         * WebCoreSupport/WebChromeClient.mm:
956         (WebChromeClient::supportsVideoFullscreen):
957         * WebView/WebDynamicScrollBarsView.mm:
958         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
959         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
960         * WebView/WebPreferences.mm:
961         (+[WebPreferences initialize]):
962         * WebView/WebView.mm:
963         (-[WebView _commonInitializationWithFrameName:groupName:]):
964         (-[WebView _preferencesChanged:]):
965         (+[WebView _doNotStartObservingNetworkReachability]):
966
967 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
968
969         Replace some stack raw pointers with RefPtrs within WebCore/html
970         https://bugs.webkit.org/show_bug.cgi?id=178201
971         <rdar://problem/34841692>
972
973         Reviewed by Ryosuke Niwa.
974
975         * DOM/DOM.mm:
976         (kit):
977         Change the type of node as toNode() is changed to return RefPtr.
978
979 2017-10-18  Chris Dumez  <cdumez@apple.com>
980
981         [Service Worker] Add stubs for Client / WindowClient / Clients
982         https://bugs.webkit.org/show_bug.cgi?id=178469
983
984         Reviewed by Youenn Fablet.
985
986         Rename PageVisiblityState to VisibilityState.
987
988         * WebView/WebView.mm:
989         (kit):
990
991 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
992
993         Unreviewed, rolling out r223291.
994
995         See WebCore ChangeLog for more detail.
996
997         Reverted changeset:
998
999         "Remove Editor::simplifyMarkup"
1000         https://bugs.webkit.org/show_bug.cgi?id=178271
1001         https://trac.webkit.org/changeset/223291
1002
1003 2017-10-17  Keith Miller  <keith_miller@apple.com>
1004
1005         Change WebCore sources to work with unified source builds
1006         https://bugs.webkit.org/show_bug.cgi?id=178229
1007
1008         Rubber stamped by Tim Horton.
1009
1010         * Configurations/FeatureDefines.xcconfig:
1011
1012 2017-10-16  Sam Weinig  <sam@webkit.org>
1013
1014         [Settings] Remove all custom code from Settings.h/cpp
1015         https://bugs.webkit.org/show_bug.cgi?id=178330
1016
1017         Reviewed by Simon Fraser.
1018
1019         * WebView/WebPreferences.mm:
1020         (+[WebPreferences initialize]):
1021         
1022             Update for naming changes of FrameFlattening now that it is an enum class.
1023
1024 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1025
1026         Remove Editor::simplifyMarkup
1027         https://bugs.webkit.org/show_bug.cgi?id=178271
1028
1029         Reviewed by Wenson Hsieh.
1030
1031         * WebView/WebView.mm:
1032         (-[WebView _simplifyMarkup:endNode:]):
1033
1034 2017-10-12  Chris Dumez  <cdumez@apple.com>
1035
1036         [Mac] Add support for MouseEvent.buttons
1037         https://bugs.webkit.org/show_bug.cgi?id=178214
1038
1039         Reviewed by Ryosuke Niwa.
1040
1041         * WebView/WebPDFView.mm:
1042         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1043
1044 2017-10-11  Sam Weinig  <sam@webkit.org>
1045
1046         Remove out-parameter variants of copyToVector
1047         https://bugs.webkit.org/show_bug.cgi?id=178155
1048
1049         Reviewed by Tim Horton.
1050
1051         * Plugins/WebNetscapePluginView.mm:
1052         (-[WebNetscapePluginView destroyPlugin]):
1053         * WebView/WebHTMLRepresentation.mm:
1054         (newArrayWithStrings):
1055
1056             Replace out-parameter based copyToVector, with one that returns a Vector.
1057
1058 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1059
1060         Sanitize URL in pasteboard for other applications and cross origin content
1061         https://bugs.webkit.org/show_bug.cgi?id=178060
1062         <rdar://problem/34874518>
1063
1064         Reviewed by Wenson Hsieh.
1065
1066         * WebCoreSupport/WebPlatformStrategies.h:
1067         * WebCoreSupport/WebPlatformStrategies.mm:
1068         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
1069
1070 2017-10-11  Chris Dumez  <cdumez@apple.com>
1071
1072         Modernize Geolocation code
1073         https://bugs.webkit.org/show_bug.cgi?id=178148
1074
1075         Reviewed by Ryosuke Niwa.
1076
1077         * WebCoreSupport/WebGeolocationClient.h:
1078         * WebCoreSupport/WebGeolocationClient.mm:
1079         (WebGeolocationClient::lastPosition):
1080         * WebView/WebGeolocationPosition.mm:
1081         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1082         (core):
1083         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
1084         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1085         * WebView/WebGeolocationPositionInternal.h:
1086
1087 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1088
1089         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
1090         https://bugs.webkit.org/show_bug.cgi?id=178154
1091
1092         Reviewed by Wenson Hsieh.
1093
1094         Enable custom pasteboard data by default.
1095
1096         * WebView/WebPreferenceKeysPrivate.h:
1097         * WebView/WebPreferences.mm:
1098         (+[WebPreferences initialize]):
1099         (-[WebPreferences customPasteboardDataEnabled]): Added.
1100         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
1101         * WebView/WebPreferencesPrivate.h:
1102         * WebView/WebView.mm:
1103         (-[WebView _preferencesChanged:]):
1104
1105 2017-10-10  Sam Weinig  <sam@webkit.org>
1106
1107         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
1108         https://bugs.webkit.org/show_bug.cgi?id=178102
1109
1110         Reviewed by Tim Horton.
1111
1112         * History/WebHistory.mm:
1113         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1114         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1115         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1116         * WebCoreSupport/WebUserMediaClient.mm:
1117         (WebUserMediaClient::pageDestroyed):
1118
1119 2017-10-09  Robin Morisset  <rmorisset@apple.com>
1120
1121         Make the names of the options consistent
1122         https://bugs.webkit.org/show_bug.cgi?id=177933
1123
1124         Reviewed by Saam Barati.
1125
1126         * WebView/WebFrame.h:
1127         * WebView/WebHTMLView.mm:
1128         (-[WebHTMLView setMarkedText:selectedRange:]):
1129         * WebView/WebView.h:
1130
1131 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1132
1133         [iOS] Tweak support for classifying form controls (followup to r222487)
1134         https://bugs.webkit.org/show_bug.cgi?id=177917
1135         <rdar://problem/34820122>
1136
1137         Reviewed by Dean Jackson.
1138
1139         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
1140
1141         * DOM/DOMHTMLInputElement.mm:
1142         (-[DOMHTMLInputElement _autofillContext]):
1143         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
1144         (-[DOMHTMLInputElement representingPageURL]): Deleted.
1145
1146 2017-10-05  Keith Miller  <keith_miller@apple.com>
1147
1148         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
1149
1150         * Configurations/WebKitLegacy.xcconfig:
1151
1152 2017-10-05  Jer Noble  <jer.noble@apple.com>
1153
1154         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1155         https://bugs.webkit.org/show_bug.cgi?id=177261
1156
1157         Reviewed by Eric Carlson.
1158
1159         * Configurations/FeatureDefines.xcconfig:
1160
1161 2017-10-05  Chris Dumez  <cdumez@apple.com>
1162
1163         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1164         https://bugs.webkit.org/show_bug.cgi?id=177957
1165
1166         Reviewed by Alex Christensen.
1167
1168         * WebCoreSupport/WebPlatformStrategies.h:
1169         * WebCoreSupport/WebPlatformStrategies.mm:
1170         (WebPlatformStrategies::cookiesEnabled):
1171
1172 2017-10-05  Youenn Fablet  <youenn@apple.com>
1173
1174         Make LibWebRTCProvider port agnostic
1175         https://bugs.webkit.org/show_bug.cgi?id=177747
1176
1177         Reviewed by Alex Christensen & Alex Garcia.
1178
1179         * WebView/WebView.mm:
1180         (-[WebView _commonInitializationWithFrameName:groupName:]):
1181         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1182
1183 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1184
1185         Stop linking with WebKitSystemInterface
1186         https://bugs.webkit.org/show_bug.cgi?id=177915
1187
1188         Reviewed by Antti Koivisto.
1189
1190         * Configurations/DebugRelease.xcconfig:
1191         * Configurations/WebKitLegacy.xcconfig:
1192
1193 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1194
1195         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
1196         https://bugs.webkit.org/show_bug.cgi?id=177912
1197
1198         Reviewed by Saam Barati.
1199
1200         * Carbon/CarbonUtils.m:
1201         * Carbon/CarbonWindowAdapter.mm:
1202         * Carbon/HIWebView.mm:
1203         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1204         * Misc/WebNSFileManagerExtras.mm:
1205         * Misc/WebNSPasteboardExtras.mm:
1206         * Misc/WebNSURLExtras.mm:
1207         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1208         * Plugins/Hosted/NetscapePluginHostManager.mm:
1209         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1210         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1211         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1212         * Plugins/Hosted/WebTextInputWindowController.m:
1213         * Plugins/WebBaseNetscapePluginView.mm:
1214         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1215         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1216         * Plugins/WebNetscapePluginStream.mm:
1217         * Plugins/WebNetscapePluginView.mm:
1218         * Plugins/WebPluginDatabase.mm:
1219         * WebCoreSupport/PopupMenuMac.mm:
1220         * WebCoreSupport/WebChromeClient.mm:
1221         * WebCoreSupport/WebFrameLoaderClient.mm:
1222         * WebCoreSupport/WebInspectorClient.mm:
1223         * WebCoreSupport/WebPlatformStrategies.mm:
1224         * WebCoreSupport/WebSystemInterface.mm:
1225         * WebView/WebDynamicScrollBarsView.mm:
1226         * WebView/WebFrame.mm:
1227         * WebView/WebFrameView.mm:
1228         * WebView/WebFullScreenController.mm:
1229         * WebView/WebHTMLView.mm:
1230         * WebView/WebPreferences.mm:
1231         * WebView/WebView.mm:
1232
1233 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
1234
1235         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
1236         rdar://problem/34705779
1237
1238         Addressing review comments that I somehow landed without.
1239
1240         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
1241
1242 2017-09-29  Chris Dumez  <cdumez@apple.com>
1243
1244         Split some logic out of VisitedLinkStore and make it reusable
1245         https://bugs.webkit.org/show_bug.cgi?id=177575
1246
1247         Reviewed by Alex Christensen.
1248
1249         * WebCoreSupport/WebVisitedLinkStore.h:
1250         * WebCoreSupport/WebVisitedLinkStore.mm:
1251         (WebVisitedLinkStore::addVisitedLink):
1252         (WebVisitedLinkStore::removeVisitedLink):
1253         (WebVisitedLinkStore::isLinkVisited):
1254         (WebVisitedLinkStore::addVisitedLinkHash):
1255
1256 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
1257
1258         Build fix for High Sierra 32 bit Mac
1259         https://bugs.webkit.org/show_bug.cgi?id=177551
1260         <rdar://problem/34690283>
1261
1262         Reviewed by Alexey Proskuryakov.
1263
1264         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1265         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1266         also made.
1267
1268         * Carbon/CarbonWindowAdapter.mm:
1269         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1270         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1271         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1272         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1273         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1274         (-[CarbonWindowAdapter dealloc]):
1275         (-[CarbonWindowAdapter windowRef]):
1276         (-[CarbonWindowAdapter _hasWindowRef]):
1277         (-[CarbonWindowAdapter _managesWindowRef]):
1278         (-[CarbonWindowAdapter _removeWindowRef]):
1279         (-[CarbonWindowAdapter _carbonWindowClass]):
1280         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1281         (-[CarbonWindowAdapter sendSuperEvent:]):
1282         (-[CarbonWindowAdapter relinquishFocus]):
1283         (-[CarbonWindowAdapter _cancelKey:]):
1284         (-[CarbonWindowAdapter _commonAwake]):
1285         (-[CarbonWindowAdapter _destroyRealWindow:]):
1286         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1287         (-[CarbonWindowAdapter _termWindowIfOwner]):
1288         (-[CarbonWindowAdapter _windowMovedToRect:]):
1289         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1290         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1291         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1292         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1293         (-[CarbonWindowAdapter canBecomeMainWindow]):
1294         (-[CarbonWindowAdapter encodeWithCoder:]):
1295         (-[CarbonWindowAdapter initWithCoder:]):
1296         (-[CarbonWindowAdapter setContentView:]):
1297         (-[CarbonWindowAdapter worksWhenModal]):
1298         (-[CarbonWindowAdapter _setModalWindowLevel]):
1299         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1300         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1301         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1302         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1303         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1304         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1305         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1306         (NSCarbonWindowHandleEvent):
1307         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1308         (-[CarbonWindowAdapter _growBoxRect]):
1309         * Carbon/HIWebView.mm:
1310         (HIWebViewGetWebView):
1311         (HIWebViewConstructor):
1312         (HIWebViewDestructor):
1313         (HIWebViewRegisterClass):
1314         (GetBehaviors):
1315         (Draw):
1316         (HitTest):
1317         (GetRegion):
1318         (GetWindowRef):
1319         (CreateNSEventAdoptingCGEvent):
1320         (CopyEventCGEvent):
1321         (CreateNSEventWithCarbonClickEvent):
1322         (Click):
1323         (CreateNSEventWithCarbonEvent):
1324         (MouseUp):
1325         (CreateNSEventWithCarbonMouseMoveEvent):
1326         (MouseMoved):
1327         (MouseDragged):
1328         (MouseWheelMoved):
1329         (ContextMenuClick):
1330         (GetKind):
1331         (BoundsChanged):
1332         (OwningWindowChanged):
1333         (WindowHandler):
1334         (SyncFrame):
1335         (SetFocusPart):
1336         (AdvanceFocus):
1337         (RelinquishFocus):
1338         (ActiveStateChanged):
1339         (ProcessCommand):
1340         (UpdateCommandStatus):
1341         (_NSSelectorForHICommand):
1342         (HIWebViewEventHandler):
1343         (StartUpdateObserver):
1344         (StopUpdateObserver):
1345         (UpdateObserver):
1346
1347 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1348
1349         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
1350         https://bugs.webkit.org/show_bug.cgi?id=172526
1351         <rdar://problem/32396081>
1352
1353         Reviewed by Ryosuke Niwa.
1354
1355         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
1356
1357         * WebCoreSupport/WebPlatformStrategies.h:
1358         * WebCoreSupport/WebPlatformStrategies.mm:
1359         (WebPlatformStrategies::webExposedTypes):
1360         (WebPlatformStrategies::writeCustomData):
1361
1362 2017-09-27  Matt Lewis  <jlewis3@apple.com>
1363
1364         Unreviewed, rolling out r222567.
1365
1366         This broke and internal build.
1367
1368         Reverted changeset:
1369
1370         "Build fix for High Sierra 32 bit Mac"
1371         https://bugs.webkit.org/show_bug.cgi?id=177551
1372         http://trac.webkit.org/changeset/222567
1373
1374 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
1375
1376         Build fix for High Sierra 32 bit Mac
1377         https://bugs.webkit.org/show_bug.cgi?id=177551
1378         <rdar://problem/34690283>
1379
1380         Reviewed by Alexey Proskuryakov.
1381
1382         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1383         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1384         also made.
1385
1386         * Carbon/CarbonWindowAdapter.mm:
1387         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1388         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1389         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1390         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1391         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1392         (-[CarbonWindowAdapter dealloc]):
1393         (-[CarbonWindowAdapter windowRef]):
1394         (-[CarbonWindowAdapter _hasWindowRef]):
1395         (-[CarbonWindowAdapter _managesWindowRef]):
1396         (-[CarbonWindowAdapter _removeWindowRef]):
1397         (-[CarbonWindowAdapter _carbonWindowClass]):
1398         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1399         (-[CarbonWindowAdapter sendSuperEvent:]):
1400         (-[CarbonWindowAdapter relinquishFocus]):
1401         (-[CarbonWindowAdapter _cancelKey:]):
1402         (-[CarbonWindowAdapter _commonAwake]):
1403         (-[CarbonWindowAdapter _destroyRealWindow:]):
1404         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1405         (-[CarbonWindowAdapter _termWindowIfOwner]):
1406         (-[CarbonWindowAdapter _windowMovedToRect:]):
1407         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1408         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1409         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1410         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1411         (-[CarbonWindowAdapter canBecomeMainWindow]):
1412         (-[CarbonWindowAdapter encodeWithCoder:]):
1413         (-[CarbonWindowAdapter initWithCoder:]):
1414         (-[CarbonWindowAdapter setContentView:]):
1415         (-[CarbonWindowAdapter worksWhenModal]):
1416         (-[CarbonWindowAdapter _setModalWindowLevel]):
1417         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1418         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1419         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1420         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1421         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1422         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1423         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1424         (NSCarbonWindowHandleEvent):
1425         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1426         (-[CarbonWindowAdapter _growBoxRect]):
1427         * Carbon/HIWebView.mm:
1428         (HIWebViewGetWebView):
1429         (HIWebViewConstructor):
1430         (HIWebViewDestructor):
1431         (HIWebViewRegisterClass):
1432         (GetBehaviors):
1433         (Draw):
1434         (HitTest):
1435         (GetRegion):
1436         (GetWindowRef):
1437         (CreateNSEventAdoptingCGEvent):
1438         (CopyEventCGEvent):
1439         (CreateNSEventWithCarbonClickEvent):
1440         (Click):
1441         (CreateNSEventWithCarbonEvent):
1442         (MouseUp):
1443         (CreateNSEventWithCarbonMouseMoveEvent):
1444         (MouseMoved):
1445         (MouseDragged):
1446         (MouseWheelMoved):
1447         (ContextMenuClick):
1448         (GetKind):
1449         (BoundsChanged):
1450         (OwningWindowChanged):
1451         (WindowHandler):
1452         (SyncFrame):
1453         (SetFocusPart):
1454         (AdvanceFocus):
1455         (RelinquishFocus):
1456         (ActiveStateChanged):
1457         (ProcessCommand):
1458         (UpdateCommandStatus):
1459         (_NSSelectorForHICommand):
1460         (HIWebViewEventHandler):
1461         (StartUpdateObserver):
1462         (StopUpdateObserver):
1463         (UpdateObserver):
1464
1465 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1466
1467         Make PolicyAction an encodable enum class
1468         https://bugs.webkit.org/show_bug.cgi?id=177480
1469
1470         Reviewed by Antti Koivisto.
1471
1472         * Plugins/WebPluginContainerCheck.mm:
1473         (-[WebPluginContainerCheck _continueWithPolicy:]):
1474         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
1475         * WebCoreSupport/WebFrameLoaderClient.mm:
1476         (-[WebFramePolicyListener invalidate]):
1477         (-[WebFramePolicyListener ignore]):
1478         (-[WebFramePolicyListener download]):
1479         (-[WebFramePolicyListener use]):
1480         (-[WebFramePolicyListener continue]):
1481         * WebView/WebPolicyDelegate.mm:
1482         (-[WebPolicyDecisionListener use]):
1483         (-[WebPolicyDecisionListener ignore]):
1484         (-[WebPolicyDecisionListener download]):
1485
1486 2017-09-25  Frederik Riedel  <riedel@apple.com>
1487
1488         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
1489         https://bugs.webkit.org/show_bug.cgi?id=174394
1490         <rdar://problem/33183504>
1491
1492         Reviewed by Ryosuke Niwa.
1493
1494         * DOM/DOMHTMLInputElement.h:
1495         * DOM/DOMHTMLInputElement.mm:
1496         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
1497         Determines if this HTMLInputElement is part of a login screen.
1498         (-[DOMHTMLInputElement representingPageUrl]):
1499         Returns the webpage's URL that is currently displayed in the Web View.
1500         (-[DOMHTMLInputElement insertTextSuggestion:]):
1501         Inserts login credentials into the Web View.
1502
1503 2017-09-25  Sam Weinig  <sam@webkit.org>
1504
1505         Remove unused EditorClient functions
1506         https://bugs.webkit.org/show_bug.cgi?id=177463
1507
1508         Reviewed by Alex Christensen.
1509
1510         Remove unused EditorClient functions.
1511
1512         * WebCoreSupport/WebEditorClient.h:
1513         * WebCoreSupport/WebEditorClient.mm:
1514         (WebEditorClient::canonicalizeURL): Deleted.
1515         (WebEditorClient::canonicalizeURLString): Deleted.
1516         (WebEditorClient::writeDataToPasteboard): Deleted.
1517         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
1518         (WebEditorClient::readDataFromPasteboard): Deleted.
1519         (WebEditorClient::pasteboardChangeCount): Deleted.
1520
1521 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1522
1523         Stop using PolicyCallback
1524         https://bugs.webkit.org/show_bug.cgi?id=176088
1525
1526         Reviewed by Andy Estes.
1527
1528         * WebCoreSupport/WebFrameLoaderClient.mm:
1529         (-[WebFramePolicyListener invalidate]):
1530         (-[WebFramePolicyListener receivedPolicyDecision:]):
1531
1532 2017-09-25  Sam Weinig  <sam@webkit.org>
1533
1534         Remove unnecessary userVisibleString EditorClient function
1535         https://bugs.webkit.org/show_bug.cgi?id=177456
1536
1537         Reviewed by Dan Bernstein.
1538
1539         * WebCoreSupport/WebEditorClient.h:
1540         * WebCoreSupport/WebEditorClient.mm:
1541         (WebEditorClient::userVisibleString): Deleted.
1542
1543             Remove userVisibleString client function.
1544
1545 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1546
1547         Separate form submission from PolicyChecker infrastructure
1548         https://bugs.webkit.org/show_bug.cgi?id=177396
1549
1550         Reviewed by Geoffrey Garen.
1551
1552         * WebCoreSupport/WebFrameLoaderClient.h:
1553         * WebCoreSupport/WebFrameLoaderClient.mm:
1554         (WebFrameLoaderClient::dispatchWillSubmitForm):
1555
1556 2017-09-22  Zalan Bujtas  <zalan@apple.com>
1557
1558         WeakPtrFactory should populate m_ref lazily.
1559         https://bugs.webkit.org/show_bug.cgi?id=177375
1560
1561         Reviewed by Geoffrey Garen.
1562
1563         * WebCoreSupport/WebEditorClient.mm:
1564         (WebEditorClient::WebEditorClient):
1565         (WebEditorClient::requestCandidatesForSelection):
1566
1567 2017-09-22  Chris Dumez  <cdumez@apple.com>
1568
1569         Use high resolution timestamp for event time
1570         https://bugs.webkit.org/show_bug.cgi?id=154246
1571         <rdar://problem/34333304>
1572
1573         Reviewed by Ryosuke Niwa.
1574
1575         Use WallTime / MonotonicTime instead of double type for clarity.
1576
1577         * DOM/DOMEvent.mm:
1578         (-[DOMEvent timeStamp]):
1579         * WebView/WebFrame.mm:
1580         (-[WebFrame _dragSourceEndedAt:operation:]):
1581         * WebView/WebPDFView.mm:
1582         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1583
1584 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
1585
1586         Enable dataTransfer.items on macOS and iOS
1587         https://bugs.webkit.org/show_bug.cgi?id=177335
1588
1589         Reviewed by Sam Weinig.
1590
1591         * WebView/WebPreferences.mm:
1592         (+[WebPreferences initialize]):
1593
1594 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
1595
1596         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
1597         https://bugs.webkit.org/show_bug.cgi?id=177101
1598         <rdar://problem/34500648>
1599
1600         Reviewed by Brian Burg.
1601
1602         * WebInspector/WebNodeHighlight.mm:
1603         Ensure we close the window that we have just removed.
1604
1605 2017-09-20  Antti Koivisto  <antti@apple.com>
1606
1607         Remove DOM and styling support for CSS Regions
1608         https://bugs.webkit.org/show_bug.cgi?id=177221
1609
1610         Reviewed by Andreas Kling.
1611
1612         * Configurations/FeatureDefines.xcconfig:
1613         * DOM/DOMCSS.mm:
1614         (kitClass):
1615         * DOM/DOMElement.mm:
1616         (-[DOMElement webkitRegionOverset]): Deleted.
1617
1618 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
1619
1620         Layering violation in Editor::createFragment
1621         https://bugs.webkit.org/show_bug.cgi?id=176123
1622
1623         Reviewed by Darin Adler.
1624
1625         * Misc/WebNSURLExtras.h:
1626         * Misc/WebNSURLExtras.mm:
1627         * WebView/WebFrame.mm:
1628         * WebView/WebHTMLView.mm:
1629         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
1630
1631         * WebCoreSupport/WebEditorClient.mm:
1632         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
1633         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
1634         way to avoid exporting the symbol just on newer OSes.
1635
1636 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
1637
1638         On iOS, getData can't get text set by setData during copy event
1639         https://bugs.webkit.org/show_bug.cgi?id=176980
1640         <rdar://problem/34453915>
1641
1642         Reviewed by Darin Adler.
1643
1644         * WebCoreSupport/WebPlatformStrategies.h:
1645         * WebCoreSupport/WebPlatformStrategies.mm:
1646         (WebPlatformStrategies::copy): Deleted.
1647
1648 2017-09-18  Andy Estes  <aestes@apple.com>
1649
1650         [Mac] Upstream miscellaneous WebKitSystemInterface functions
1651         https://bugs.webkit.org/show_bug.cgi?id=177029
1652
1653         Reviewed by Alex Christensen.
1654
1655         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1656         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
1657         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1658         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1659         * WebCoreSupport/PopupMenuMac.mm:
1660         (PopupMenuMac::show):
1661         * WebCoreSupport/WebSystemInterface.mm:
1662         (InitWebCoreSystemInterface):
1663         * WebView/WebHTMLView.mm:
1664         (-[WebHTMLView setDataSource:]):
1665         (-[WebHTMLView attachRootLayer:]):
1666         * WebView/WebView.mm:
1667         (-[WebView _needsAdobeFrameReloadingQuirk]):
1668         (-[WebView _needsLinkElementTextCSSQuirk]):
1669         (-[WebView _needsIsLoadingInAPISenseQuirk]):
1670         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
1671         (-[WebView _preferencesChanged:]):
1672
1673 2017-09-15  Andy Estes  <aestes@apple.com>
1674
1675         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
1676         https://bugs.webkit.org/show_bug.cgi?id=176953
1677
1678         Reviewed by Eric Carlson.
1679
1680         * WebCoreSupport/WebSystemInterface.mm:
1681         (InitWebCoreSystemInterface):
1682
1683 2017-09-14  Andy Estes  <aestes@apple.com>
1684
1685         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
1686         https://bugs.webkit.org/show_bug.cgi?id=176931
1687
1688         Reviewed by Joseph Pecoraro.
1689
1690         * WebCoreSupport/WebSystemInterface.mm:
1691         (InitWebCoreSystemInterface):
1692
1693 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1694
1695         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
1696         https://bugs.webkit.org/show_bug.cgi?id=176867
1697
1698         Reviewed by Sam Weinig.
1699
1700         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1701         (WebKit::NetscapePluginInstanceProxy::enumerate):
1702
1703 2017-09-13  Andy Estes  <aestes@apple.com>
1704
1705         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
1706         https://bugs.webkit.org/show_bug.cgi?id=176729
1707
1708         Reviewed by Alex Christensen.
1709
1710         * WebCoreSupport/WebSystemInterface.mm:
1711         (InitWebCoreSystemInterface):
1712         * WebView/WebView.mm:
1713         (+[WebView _setCacheModel:]):
1714
1715 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1716
1717         Refactor WebContentReader out of EditorMac and EditorIOS
1718         https://bugs.webkit.org/show_bug.cgi?id=176770
1719
1720         Reviewed by Sam Weinig.
1721
1722         * WebCoreSupport/WebEditorClient.mm:
1723
1724 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
1725
1726         Dragging & dropping a file creates an attachment element even when it's disabled
1727         https://bugs.webkit.org/show_bug.cgi?id=176769
1728
1729         Reviewed by Tim Horton.
1730
1731         * WebView/WebView.mm:
1732         (-[WebView _preferencesChanged:]):
1733
1734 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1735
1736         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
1737         https://bugs.webkit.org/show_bug.cgi?id=176721
1738         <rdar://problem/34373660>
1739
1740         Reviewed by Tim Horton.
1741
1742         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
1743         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
1744
1745         * WebView/WebView.mm:
1746         (-[WebView _startDrag:]):
1747         (-[WebView _draggedElementBounds]):
1748         (-[WebView _endedDataInteraction:global:]):
1749         * WebView/WebViewData.h:
1750
1751 2017-09-11  Andy Estes  <aestes@apple.com>
1752
1753         [Mac] Upstream QTKit-related WebKitSystemInterface functions
1754         https://bugs.webkit.org/show_bug.cgi?id=176472
1755
1756         Reviewed by Eric Carlson.
1757
1758         * WebCoreSupport/WebSystemInterface.mm:
1759         (InitWebCoreSystemInterface):
1760
1761 2017-09-09  Mark Lam  <mark.lam@apple.com>
1762
1763         Avoid duplicate computations of ExecState::vm().
1764         https://bugs.webkit.org/show_bug.cgi?id=176647
1765
1766         Reviewed by Saam Barati.
1767
1768         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1769         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1770         (WebKit::NetscapePluginInstanceProxy::construct):
1771         (WebKit::NetscapePluginInstanceProxy::setProperty):
1772         (WebKit::NetscapePluginInstanceProxy::removeProperty):
1773         (WebKit::NetscapePluginInstanceProxy::enumerate):
1774         * Plugins/Hosted/ProxyInstance.mm:
1775         (WebKit::ProxyRuntimeMethod::create):
1776
1777 2017-09-08  Commit Queue  <commit-queue@webkit.org>
1778
1779         Unreviewed, rolling out r221773.
1780         https://bugs.webkit.org/show_bug.cgi?id=176614
1781
1782         This caused build failures. (Requested by mlewis13 on
1783         #webkit).
1784
1785         Reverted changeset:
1786
1787         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
1788         https://bugs.webkit.org/show_bug.cgi?id=176472
1789         http://trac.webkit.org/changeset/221773
1790
1791 2017-09-07  Andy Estes  <aestes@apple.com>
1792
1793         [Mac] Upstream QTKit-related WebKitSystemInterface functions
1794         https://bugs.webkit.org/show_bug.cgi?id=176472
1795
1796         Reviewed by Eric Carlson.
1797
1798         * WebCoreSupport/WebSystemInterface.mm:
1799         (InitWebCoreSystemInterface):
1800
1801 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
1802
1803         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
1804         https://bugs.webkit.org/show_bug.cgi?id=176561
1805
1806         Reviewed by Brent Fulgham.
1807
1808         * Misc/WebNSUserDefaultsExtras.mm:
1809
1810 2017-09-07  Alex Christensen  <achristensen@webkit.org>
1811
1812         Modernize Geolocation code
1813         https://bugs.webkit.org/show_bug.cgi?id=176496
1814
1815         Reviewed by Andy Estes.
1816
1817         * WebCoreSupport/WebGeolocationClient.h:
1818         * WebCoreSupport/WebGeolocationClient.mm:
1819         (WebGeolocationClient::requestPermission):
1820         (-[WebGeolocationPolicyListener initWithGeolocation:]):
1821         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
1822         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
1823         * WebView/WebView.mm:
1824         (-[WebView _commonInitializationWithFrameName:groupName:]):
1825         (-[WebView _geolocationDidFailWithMessage:]):
1826
1827 2017-09-05  Tim Horton  <timothy_horton@apple.com>
1828
1829         Remove some unused bits of code and resources
1830         https://bugs.webkit.org/show_bug.cgi?id=176275
1831
1832         Reviewed by Dan Bernstein.
1833
1834         * Misc/WebNSFileManagerExtras.mm:
1835         Include FileSystem instead of FileSystemIOS.
1836
1837 2017-09-03  Darin Adler  <darin@apple.com>
1838
1839         [Cocoa] Tidy a few things in legacy WebHTMLView
1840         https://bugs.webkit.org/show_bug.cgi?id=176280
1841
1842         Reviewed by Dan Bernstein.
1843
1844         * WebCoreSupport/WebChromeClient.mm:
1845         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
1846         methods it calls on WebHTMLView were doing nothing on iOS.
1847
1848         * WebView/WebFrame.mm:
1849         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
1850         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
1851
1852         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
1853         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
1854         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
1855         order. Removed all sorts of unused things. Made more code and fields Mac-only where
1856         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
1857         Use RetainPtr instead of writing retain/release wherever possible.
1858         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
1859         initialization for it. Removed various unused methods and declarations of methods.
1860         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
1861         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
1862         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
1863         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
1864         and remove CFRetain no longer needed since we don't support garbage collection any more.
1865         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
1866         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
1867         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
1868         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
1869         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
1870         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
1871         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
1872         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1873         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
1874         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
1875         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
1876         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
1877         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
1878         debug flag; we haven't used it for years and it's not clearly helpful.
1879         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
1880         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
1881         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
1882         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
1883         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
1884         two additional methods in the WebPrivate category and still be called by the two
1885         methods in the WebInternal category that were already using it.
1886         (-[WebHTMLView didAddSubview:]): Deleted.
1887         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
1888         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
1889         place this was called, the close method.
1890         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
1891         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1892         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
1893         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
1894         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
1895         Added helper method to make the one below simpler.
1896         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1897         Compared pasteboard type strings using isEqualToString: rather than using == since
1898         we want to actually compare the string contents. Also updated to use modern for loop,
1899         renamed a local variable from "s" to "localSubresources", and factored out the handling
1900         of three image types to use the helper method above.
1901         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
1902         _web_makePluginSubviewsPerformSelector:withObject: method.
1903         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
1904         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
1905         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
1906         not call the -[NSView subviews] method to make this identical on both platforms and used
1907         a modern for loop.
1908         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
1909         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
1910         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
1911         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
1912         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
1913         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
1914         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
1915         of it is Mac-only.
1916         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
1917         method did was call itself on the main thread, and do nothing if called on main thread.
1918         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
1919         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
1920         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
1921         half of this method.
1922         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
1923         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1924         Simplified using a modern for loop and RetainPtr.
1925         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
1926         (-[WebHTMLView keyDown:]): Ditto.
1927         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
1928         (-[WebHTMLView performKeyEquivalent:]): Ditto.
1929         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
1930         (-[WebHTMLView complete:]): Ditto.
1931         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
1932         now macOS-only.
1933         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
1934         iOS since that is now macOS-only.
1935         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
1936         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
1937         a private one because it is not used or needed outside WebKit. Also made it macOS-only
1938         and reorganized to use early return.
1939         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
1940         on iOS, but kept there so we don't have to do #if at every call site.
1941         (-[WebHTMLView _pluginController]): Moved into internal category.
1942         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
1943         there only for GC, using C++ initialization, removing obsolete comment.
1944         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
1945         peculiar iOS-only comment.
1946         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
1947
1948         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
1949         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
1950         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
1951         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
1952         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
1953
1954         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
1955         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
1956         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
1957         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
1958         them at this time.
1959
1960 2017-09-03  Sam Weinig  <sam@webkit.org>
1961
1962         Remove CanvasProxy
1963         https://bugs.webkit.org/show_bug.cgi?id=176288
1964
1965         Reviewed by Yusuke Suzuki.
1966
1967         CanvasProxy does not appear to be in any current HTML spec
1968         and was disabled and unimplemented in our tree. Time to 
1969         get rid of it.
1970
1971         * Configurations/FeatureDefines.xcconfig:
1972
1973 2017-09-02  Andy Estes  <aestes@apple.com>
1974
1975         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
1976         https://bugs.webkit.org/show_bug.cgi?id=176270
1977
1978         Reviewed by Tim Horton.
1979
1980         * Plugins/Hosted/NetscapePluginHostManager.mm:
1981         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1982         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1983         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1984         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
1985         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
1986         (WebKit::SoftwareCARenderer::context const):
1987         (WebKit::SoftwareCARenderer::renderContext const):
1988         (WebKit::SoftwareCARenderer::render):
1989         (-[WebHostedNetscapePluginView createPlugin]):
1990         (-[WebHostedNetscapePluginView createPluginLayer]):
1991         (-[WebHostedNetscapePluginView destroyPlugin]):
1992         (-[WebHostedNetscapePluginView drawRect:]):
1993         * WebCoreSupport/WebSystemInterface.mm:
1994         (InitWebCoreSystemInterface):
1995
1996 2017-09-01  Andy Estes  <aestes@apple.com>
1997
1998         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
1999         https://bugs.webkit.org/show_bug.cgi?id=176200
2000
2001         Reviewed by Tim Horton.
2002
2003         * Carbon/HIWebView.mm:
2004         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2005         (overrideCGContext):
2006         (restoreCGContext):
2007         (Draw):
2008         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2009         (+[WebHostedNetscapePluginView initialize]):
2010         * Plugins/WebBaseNetscapePluginView.h:
2011         * Plugins/WebBaseNetscapePluginView.mm:
2012         (WebKit::sendUserChangeNotifications):
2013         * Plugins/WebNetscapePluginView.mm:
2014         (+[WebNetscapePluginView initialize]):
2015         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2016         * WebCoreSupport/WebSystemInterface.mm:
2017         (InitWebCoreSystemInterface):
2018         * WebView/WebFrame.mm:
2019         (-[WebFrame _paintBehaviorForDestinationContext:]):
2020         * WebView/WebFullScreenController.mm:
2021         (setClipRectForWindow):
2022         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2023         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2024         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2025         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2026
2027 2017-08-31  Andy Estes  <aestes@apple.com>
2028
2029         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2030         https://bugs.webkit.org/show_bug.cgi?id=176175
2031
2032         Reviewed by Brady Eidson.
2033
2034         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2035         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2036         * Plugins/Hosted/WebTextInputWindowController.m:
2037         (-[WebTextInputPanel init]):
2038         * WebCoreSupport/WebSystemInterface.mm:
2039         (InitWebCoreSystemInterface):
2040         * WebView/WebDynamicScrollBarsView.mm:
2041         (-[WebDynamicScrollBarsView scrollWheel:]):
2042         * WebView/WebHTMLView.mm:
2043         (-[WebHTMLView _removeWindowObservers]):
2044         (-[WebHTMLView addWindowObservers]):
2045         * WebView/WebView.mm:
2046         (-[WebView addWindowObserversForWindow:]):
2047         (-[WebView removeWindowObservers]):
2048         (-[WebView viewWillMoveToWindow:]):
2049
2050 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2051
2052         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2053         https://bugs.webkit.org/show_bug.cgi?id=175779
2054         <rdar://problem/22367975>
2055
2056         Reviewed by Tim Horton.
2057
2058         * WebCoreSupport/WebFrameLoaderClient.h:
2059         * WebCoreSupport/WebFrameLoaderClient.mm:
2060         (WebFrameLoaderClient::webGLPolicyForURL const):
2061         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2062
2063 2017-08-30  Andy Estes  <aestes@apple.com>
2064
2065         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
2066         https://bugs.webkit.org/show_bug.cgi?id=176093
2067
2068         Reviewed by Eric Carlson.
2069
2070         * WebCoreSupport/WebSystemInterface.mm:
2071         (InitWebCoreSystemInterface):
2072
2073 2017-08-30  Andy Estes  <aestes@apple.com>
2074
2075         [Mac] Upstream Carbon-related WebKitSystemInterface functions
2076         https://bugs.webkit.org/show_bug.cgi?id=176087
2077
2078         Reviewed by Alex Christensen.
2079
2080         * Carbon/CarbonUtils.m:
2081         (getNSAutoreleasePoolCount):
2082         (WebInitForCarbon):
2083         (PoolCleaner):
2084         * Carbon/CarbonWindowAdapter.mm:
2085         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2086         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2087         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2088         (-[CarbonWindowAdapter _windowMovedToRect:]):
2089         * Carbon/HIViewAdapter.m:
2090         * Carbon/HIWebView.mm:
2091         (Draw):
2092         (CreateNSEventAdoptingCGEvent):
2093         (CopyEventCGEvent):
2094         (CreateNSEventWithCarbonClickEvent):
2095         (Click):
2096         (CreateNSEventWithCarbonEvent):
2097         (MouseUp):
2098         (CreateNSEventWithCarbonMouseMoveEvent):
2099         (MouseMoved):
2100         (MouseDragged):
2101         (MouseWheelMoved):
2102         (WindowHandler):
2103         (HIWebViewEventHandler):
2104         * Misc/QuickDrawCompatibility.h: Removed.
2105         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2106         (getCarbonEvent):
2107         (WebNetscapePluginEventHandlerCarbon::keyDown):
2108         (WebNetscapePluginEventHandlerCarbon::keyUp):
2109         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2110         (WebNetscapePluginEventHandlerCocoa::keyDown):
2111         * Plugins/WebNetscapePluginView.mm:
2112         (-[WebNetscapePluginView tellQuickTimeToChill]):
2113
2114 2017-08-29  Andy Estes  <aestes@apple.com>
2115
2116         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
2117         https://bugs.webkit.org/show_bug.cgi?id=176046
2118
2119         Reviewed by Alex Christensen.
2120
2121         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
2122         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
2123
2124         * Misc/WebNSFileManagerExtras.mm:
2125         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2126         (setMetaData): Deleted.
2127         * WebCoreSupport/WebSystemInterface.mm:
2128         (InitWebCoreSystemInterface):
2129
2130 2017-08-28  Andy Estes  <aestes@apple.com>
2131
2132         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
2133         https://bugs.webkit.org/show_bug.cgi?id=176039
2134
2135         Reviewed by Alex Christensen.
2136
2137         * WebCoreSupport/WebSystemInterface.mm:
2138         (InitWebCoreSystemInterface):
2139         * WebView/WebPreferences.mm:
2140         (+[WebPreferences _systemCFStringEncoding]):
2141
2142 2017-08-28  Andy Estes  <aestes@apple.com>
2143
2144         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
2145         https://bugs.webkit.org/show_bug.cgi?id=176032
2146
2147         Reviewed by Alex Christensen.
2148
2149         * WebCoreSupport/WebSystemInterface.mm:
2150         (InitWebCoreSystemInterface):
2151         * WebView/WebView.mm:
2152         (-[WebView _cachedResponseForURL:]):
2153
2154 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2155
2156         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
2157         https://bugs.webkit.org/show_bug.cgi?id=175992
2158         <rdar://problem/34086613>
2159
2160         Reviewed by Daniel Bates.
2161
2162         * WebCoreSupport/WebPlatformStrategies.h:
2163         * WebCoreSupport/WebPlatformStrategies.mm:
2164         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
2165         cookies should be included, and return a pair containing the resulting cookie string and a boolean
2166         indicating if secure cookies were accessed.
2167
2168 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2169
2170         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
2171         https://bugs.webkit.org/show_bug.cgi?id=170955
2172         <rdar://problem/31697653>
2173
2174         Reviewed by Ryosuke Niwa.
2175
2176         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
2177         text is being replaced.
2178
2179         * WebView/WebHTMLView.mm:
2180         (-[WebHTMLView insertText:]):
2181
2182 2017-08-24  Chris Dumez  <cdumez@apple.com>
2183
2184         [Directory Upload] Add basic support for input.webkitdirectory
2185         https://bugs.webkit.org/show_bug.cgi?id=175950
2186         <rdar://problem/33951915>
2187
2188         Reviewed by Geoffrey Garen.
2189
2190         Add private API to toggle Directory Upload support on Mac WebKit1.
2191
2192         * WebView/WebPreferenceKeysPrivate.h:
2193         * WebView/WebPreferences.mm:
2194         (+[WebPreferences initialize]):
2195         (-[WebPreferences setDirectoryUploadEnabled:]):
2196         (-[WebPreferences directoryUploadEnabled]):
2197         * WebView/WebPreferencesPrivate.h:
2198         * WebView/WebView.mm:
2199         (-[WebView _preferencesChanged:]):
2200
2201 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2202
2203         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2204         https://bugs.webkit.org/show_bug.cgi?id=175370
2205         <rdar://problem/33799806>
2206
2207         Reviewed by Ryosuke Niwa.
2208
2209         Adjust WebEditorClient for interface changes.
2210
2211         * WebCoreSupport/WebEditorClient.h:
2212
2213 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2214
2215         Remove ChromeClient::scrollbarsModeDidChange
2216         https://bugs.webkit.org/show_bug.cgi?id=175805
2217
2218         Reviewed by Daniel Bates.
2219
2220         * WebCoreSupport/WebChromeClient.h:
2221
2222 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2223
2224         Remove ChromeClient::hasOpenedPopup
2225         https://bugs.webkit.org/show_bug.cgi?id=175804
2226
2227         Reviewed by Sam Weinig.
2228
2229         * WebCoreSupport/WebChromeClient.h:
2230         * WebCoreSupport/WebChromeClient.mm:
2231         (WebChromeClient::hasOpenedPopup const): Deleted.
2232
2233 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
2234
2235         Disable access to secure cookies if an HTTPS site loads mixed content
2236         https://bugs.webkit.org/show_bug.cgi?id=157053
2237         <rdar://problem/11290808>
2238
2239         Reviewed by Dan Bates.
2240
2241         * WebCoreSupport/WebPlatformStrategies.h:
2242         * WebCoreSupport/WebPlatformStrategies.mm:
2243         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
2244         indicating whether secure cookies should be included in the response.
2245
2246 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2247
2248         [PAL] Move spi/mac directory into PAL
2249         https://bugs.webkit.org/show_bug.cgi?id=175649
2250
2251         Reviewed by Myles C. Maxfield.
2252
2253         * Misc/WebSharingServicePickerController.h:
2254         * WebCoreSupport/WebContextMenuClient.mm:
2255         * WebCoreSupport/WebEditorClient.mm:
2256         * WebCoreSupport/WebSelectionServiceController.mm:
2257         * WebView/WebHTMLView.mm:
2258         * WebView/WebImmediateActionController.h:
2259         * WebView/WebImmediateActionController.mm:
2260         * WebView/WebView.mm:
2261
2262 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2263
2264         [PAL] Relocate SessionID to root
2265         https://bugs.webkit.org/show_bug.cgi?id=175684
2266
2267         Reviewed by Alex Christensen.
2268
2269         * WebCoreSupport/WebFrameNetworkingContext.mm:
2270
2271 2017-08-17  Andreas Kling  <akling@apple.com>
2272
2273         Disable CSS regions at compile time
2274         https://bugs.webkit.org/show_bug.cgi?id=175630
2275
2276         Reviewed by Antti Koivisto.
2277
2278         * Configurations/FeatureDefines.xcconfig:
2279
2280 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2281
2282         [PAL] Move SessionID into PAL
2283         https://bugs.webkit.org/show_bug.cgi?id=174192
2284
2285         Reviewed by Antti Koivisto.
2286
2287         * Misc/WebCache.mm:
2288         (+[WebCache imageForURL:]):
2289         * WebCoreSupport/WebFrameLoaderClient.h:
2290         * WebCoreSupport/WebFrameLoaderClient.mm:
2291         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2292         * WebCoreSupport/WebFrameNetworkingContext.mm:
2293         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2294         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2295         (WebFrameNetworkingContext::storageSession const):
2296         * WebCoreSupport/WebPlatformStrategies.h:
2297         * WebCoreSupport/WebPlatformStrategies.mm:
2298         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2299         * WebKitPrefix.h:
2300
2301 2017-08-16  Andy Estes  <aestes@apple.com>
2302
2303         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
2304         https://bugs.webkit.org/show_bug.cgi?id=175648
2305
2306         Reviewed by Tim Horton.
2307
2308         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2309         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2310         (WebPaymentCoordinatorClient::showPaymentUI):
2311
2312 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2313
2314         [PAL] Move spi/ios and spi/win directories into PAL
2315         https://bugs.webkit.org/show_bug.cgi?id=175171
2316
2317         Reviewed by Antti Koivisto.
2318
2319         * WebCoreSupport/WebFrameLoaderClient.mm:
2320         * WebView/WebView.mm:
2321
2322 2017-08-16  Andy Estes  <aestes@apple.com>
2323
2324         [Payment Request] Add an ENABLE flag and an experimental feature preference
2325         https://bugs.webkit.org/show_bug.cgi?id=175622
2326
2327         Reviewed by Tim Horton.
2328
2329         * Configurations/FeatureDefines.xcconfig:
2330
2331 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
2332
2333         [PAL] Move Sleep classes into PAL
2334         https://bugs.webkit.org/show_bug.cgi?id=175456
2335
2336         Reviewed by Ryosuke Niwa.
2337
2338         * WebView/WebFullScreenController.h:
2339
2340 2017-08-15  Youenn Fablet  <youenn@apple.com>
2341
2342         [Cache API] Adding generic support for CacheStorage and Cache methods
2343         https://bugs.webkit.org/show_bug.cgi?id=175455
2344
2345         Reviewed by Chris Dumez.
2346
2347         * WebView/WebView.mm:
2348         (-[WebView _commonInitializationWithFrameName:groupName:]):
2349
2350 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2351
2352         Remove Proximity Events and related code
2353         https://bugs.webkit.org/show_bug.cgi?id=175545
2354
2355         Reviewed by Daniel Bates.
2356
2357         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
2358         and other related code.
2359
2360         * Configurations/FeatureDefines.xcconfig:
2361
2362 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2363
2364         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
2365         https://bugs.webkit.org/show_bug.cgi?id=175504
2366
2367         Reviewed by Sam Weinig.
2368
2369         * Configurations/FeatureDefines.xcconfig:
2370         * DOM/DOMHTMLFormElement.mm:
2371         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
2372         * WebCoreSupport/WebFrameLoaderClient.h:
2373
2374 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2375
2376         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
2377         https://bugs.webkit.org/show_bug.cgi?id=175557
2378
2379         Reviewed by Jon Lee.
2380
2381         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
2382
2383         * Configurations/FeatureDefines.xcconfig:
2384
2385 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2386
2387         Composition underline color is always black
2388         https://bugs.webkit.org/show_bug.cgi?id=174675
2389
2390         Reviewed by Ryosuke Niwa.
2391
2392         * WebView/WebHTMLView.mm:
2393         (extractUnderlines): If NSUnderlineColorAttributeName
2394         is not present use text color for composition underline.
2395         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
2396         for composition underline in the plain text case.
2397
2398 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
2399
2400         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
2401         https://bugs.webkit.org/show_bug.cgi?id=175474
2402         <rdar://problem/33844628>
2403
2404         Reviewed by Wenson Hsieh.
2405
2406         Replaced the build flag by a runtime flag and disabled the feature by default.
2407
2408         * Configurations/FeatureDefines.xcconfig:
2409         * WebView/WebPreferenceKeysPrivate.h:
2410         * WebView/WebPreferences.mm:
2411         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
2412         (-[WebPreferences dataTransferItemsEnabled]): Added.
2413         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
2414         * WebView/WebPreferencesPrivate.h:
2415         * WebView/WebView.mm:
2416         (-[WebView _preferencesChanged:]):
2417
2418 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2419
2420         Remove ENABLE_GAMEPAD_DEPRECATED
2421         https://bugs.webkit.org/show_bug.cgi?id=175361
2422
2423         Reviewed by Carlos Garcia Campos.
2424
2425         * Configurations/FeatureDefines.xcconfig:
2426
2427 2017-08-09  Chris Dumez  <cdumez@apple.com>
2428
2429         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
2430         https://bugs.webkit.org/show_bug.cgi?id=175401
2431
2432         Reviewed by Brady Eidson.
2433
2434         * WebView/WebPreferenceKeysPrivate.h:
2435         * WebView/WebPreferences.mm:
2436         (+[WebPreferences initialize]):
2437         (-[WebPreferences beaconAPIEnabled]): Deleted.
2438         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
2439         * WebView/WebPreferencesPrivate.h:
2440         * WebView/WebView.mm:
2441         (-[WebView _preferencesChanged:]):
2442
2443 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2444
2445         [PAL] Move spi/cocoa and spi/cg directories into PAL
2446         https://bugs.webkit.org/show_bug.cgi?id=175175
2447
2448         Reviewed by Myles C. Maxfield.
2449
2450         * History/WebHistory.mm:
2451         * Misc/WebDownload.mm:
2452         * Misc/WebKitNSStringExtras.mm:
2453         * Plugins/Hosted/NetscapePluginHostManager.mm:
2454         * Plugins/WebPluginDatabase.mm:
2455         * WebCoreSupport/WebFrameLoaderClient.mm:
2456         * WebInspector/WebNodeHighlight.mm:
2457         * WebView/WebHTMLView.mm:
2458         * WebView/WebIndicateLayer.mm:
2459         * WebView/WebView.mm:
2460         * WebView/WebViewData.h:
2461
2462 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2463
2464         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
2465         https://bugs.webkit.org/show_bug.cgi?id=175392
2466         <rdar://problem/33783207>
2467
2468         Reviewed by Tim Horton and Megan Gardner.
2469
2470         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
2471
2472         * Configurations/FeatureDefines.xcconfig:
2473
2474 2017-08-09  Daniel Bates  <dabates@apple.com>
2475
2476         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2477         https://bugs.webkit.org/show_bug.cgi?id=175247
2478         <rdar://problem/33679804>
2479
2480         Reviewed by Brady Eidson.
2481
2482         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2483         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2484         clients that need to make use of this information at this time. If such a needs comes up
2485         then we can expose API/SPI similar to what we do for WebKit.
2486
2487         * WebCoreSupport/WebFrameLoaderClient.h:
2488         * WebCoreSupport/WebFrameLoaderClient.mm:
2489         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2490
2491 2017-08-08  Brady Eidson  <beidson@apple.com>
2492
2493         Don't enable default icon loading in WK1 for apps linked against old SDKs.
2494         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
2495
2496         Reviewed by Andy Estes.
2497
2498         * Misc/WebKitVersionChecks.h:
2499         * WebCoreSupport/WebFrameLoaderClient.mm:
2500         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
2501           the app is linked against new WebKit with the new behavior.
2502
2503 2017-08-07  Devin Rousso  <drousso@apple.com>
2504
2505         Web Inspector: Preview Canvas path when viewing a recording
2506         https://bugs.webkit.org/show_bug.cgi?id=174967
2507
2508         Reviewed by Brian Burg.
2509
2510         * WebView/WebPreferenceKeysPrivate.h:
2511         * WebView/WebPreferences.mm:
2512         (+[WebPreferences initialize]):
2513         (-[WebPreferences inspectorAdditionsEnabled]):
2514         (-[WebPreferences setInspectorAdditionsEnabled:]):
2515         * WebView/WebPreferencesPrivate.h:
2516         * WebView/WebView.mm:
2517         (-[WebView _preferencesChanged:]):
2518         Add plumbing for new InspectorAdditions runtime flag.
2519
2520 2017-08-07  Brian Burg  <bburg@apple.com>
2521
2522         Remove CANVAS_PATH compilation guard
2523         https://bugs.webkit.org/show_bug.cgi?id=175207
2524
2525         Reviewed by Sam Weinig.
2526
2527         * Configurations/FeatureDefines.xcconfig:
2528
2529 2017-08-04  Youenn Fablet  <youenn@apple.com>
2530
2531         [Cache API] Add Cache and CacheStorage IDL definitions
2532         https://bugs.webkit.org/show_bug.cgi?id=175201
2533
2534         Reviewed by Brady Eidson.
2535
2536         * WebView/WebPreferenceKeysPrivate.h:
2537         * WebView/WebPreferences.mm:
2538         (+[WebPreferences initialize]):
2539         (-[WebPreferences cacheAPIEnabled]):
2540         (-[WebPreferences setCacheAPIEnabled:]):
2541         * WebView/WebPreferencesPrivate.h:
2542         * WebView/WebView.mm:
2543         (-[WebView _preferencesChanged:]):
2544
2545 2017-08-04  Matt Lewis  <jlewis3@apple.com>
2546
2547         Unreviewed, rolling out r220271.
2548
2549         Rolling out due to Layout Test failing on iOS Simulator.
2550
2551         Reverted changeset:
2552
2553         "Remove STREAMS_API compilation guard"
2554         https://bugs.webkit.org/show_bug.cgi?id=175165
2555         http://trac.webkit.org/changeset/220271
2556
2557 2017-08-04  Youenn Fablet  <youenn@apple.com>
2558
2559         Remove STREAMS_API compilation guard
2560         https://bugs.webkit.org/show_bug.cgi?id=175165
2561
2562         Reviewed by Darin Adler.
2563
2564         * Configurations/FeatureDefines.xcconfig:
2565         * WebView/WebPreferences.mm:
2566         (+[WebPreferences initialize]):
2567         * WebView/WebView.mm:
2568         (-[WebView _preferencesChanged:]):
2569
2570 2017-08-03  Brian Burg  <bburg@apple.com>
2571
2572         Remove ENABLE(WEB_SOCKET) guards
2573         https://bugs.webkit.org/show_bug.cgi?id=167044
2574
2575         Reviewed by Joseph Pecoraro.
2576
2577         * Configurations/FeatureDefines.xcconfig:
2578         * WebView/WebPreferencesPrivate.h:
2579
2580 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
2581
2582         [PAL] Move spi/cf directory into PAL
2583         https://bugs.webkit.org/show_bug.cgi?id=175057
2584
2585         Reviewed by Antti Koivisto.
2586
2587         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2588         * Plugins/WebNetscapePluginStream.mm:
2589         * WebCoreSupport/WebFrameNetworkingContext.mm:
2590         * WebView/WebPreferences.mm:
2591         * WebView/WebView.mm:
2592
2593 2017-08-03  Youenn Fablet  <youenn@apple.com>
2594
2595         Remove FETCH_API compilation guard
2596         https://bugs.webkit.org/show_bug.cgi?id=175154
2597
2598         Reviewed by Chris Dumez.
2599
2600         * Configurations/FeatureDefines.xcconfig:
2601         * WebView/WebPreferences.mm:
2602         (+[WebPreferences initialize]):
2603         * WebView/WebView.mm:
2604         (-[WebView _preferencesChanged:]):
2605
2606 2017-08-03  Brady Eidson  <beidson@apple.com>
2607
2608         Add SW IDLs and stub out basic functionality.
2609         https://bugs.webkit.org/show_bug.cgi?id=175115
2610
2611         Reviewed by Chris Dumez.
2612
2613         * Configurations/FeatureDefines.xcconfig:
2614
2615 2017-08-02  Sam Weinig  <sam@webkit.org>
2616
2617         [WebIDL] Convert MutationCallback to be a normal generated callback
2618         https://bugs.webkit.org/show_bug.cgi?id=174140
2619
2620         Reviewed by Darin Adler.
2621
2622         * DOM/DOMDocument.mm:
2623         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
2624         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
2625         Pass, now necessary, Document to NativeNodeFilter constructor.
2626
2627 2017-08-01  Chris Dumez  <cdumez@apple.com>
2628
2629         Add initial support for navigator.sendBeacon
2630         https://bugs.webkit.org/show_bug.cgi?id=175007
2631         <rdar://problem/33547728>
2632
2633         Reviewed by Sam Weinig.
2634
2635         Add setting to toggle support for the Beacon API (it is disabled by default).
2636
2637         * WebView/WebPreferenceKeysPrivate.h:
2638         * WebView/WebPreferences.mm:
2639         (+[WebPreferences initialize]):
2640         (-[WebPreferences beaconAPIEnabled]):
2641         (-[WebPreferences setBeaconAPIEnabled:]):
2642         * WebView/WebPreferencesPrivate.h:
2643         * WebView/WebView.mm:
2644         (-[WebView _preferencesChanged:]):
2645
2646 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
2647
2648         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
2649         https://bugs.webkit.org/show_bug.cgi?id=174437
2650
2651         Reviewed by Darin Adler.
2652
2653         Remove redundant Web- prefix from classes in WebKit namespace.
2654
2655         * WebView/WebView.mm:
2656         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
2657         * WebView/WebViewData.h:
2658         * WebView/WebViewData.mm:
2659
2660 2017-07-26  Brian Burg  <bburg@apple.com>
2661
2662         Remove WEB_TIMING feature flag
2663         https://bugs.webkit.org/show_bug.cgi?id=174795
2664
2665         Reviewed by Alex Christensen.
2666
2667         * Configurations/FeatureDefines.xcconfig:
2668
2669 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
2670
2671         Async image decoding for large images should be disabled after the first time a tile is painted
2672         https://bugs.webkit.org/show_bug.cgi?id=174451
2673         <rdar://problem/31246421>
2674
2675         Reviewed by Simon Fraser.
2676
2677         * WebView/WebFrame.mm:
2678         (-[WebFrame _paintBehaviorForDestinationContext:]):
2679         (-[WebFrame _drawRect:contentsOnly:]):
2680         * WebView/WebHTMLView.mm:
2681         (imageFromRect):
2682
2683 2017-07-23  Darin Adler  <darin@apple.com>
2684
2685         More NeverDestroyed and related cleanup
2686         https://bugs.webkit.org/show_bug.cgi?id=174745
2687
2688         Reviewed by Alex Christensen.
2689
2690         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
2691         for names that aren't even used in this file.
2692         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
2693         -[NSArray arrayWithObject:].
2694         (-[DOMNode absoluteQuads]): Ditto.
2695         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
2696         of writing out various types.
2697         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
2698         syntax instea of -[NSArray arrayWithObject:].
2699         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
2700         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
2701         of writing out various types.
2702         (-[DOMHTMLImageElement mimeType]): Ditto.
2703
2704 2017-07-24  Chris Dumez  <cdumez@apple.com>
2705
2706         ExceptionCode enumeration should use modern exception names
2707         https://bugs.webkit.org/show_bug.cgi?id=174794
2708
2709         Reviewed by Geoffrey Garen.
2710
2711         * DOM/ExceptionHandlers.mm:
2712         (raiseNotSupportedErrorException):
2713
2714 2017-07-23  Chris Dumez  <cdumez@apple.com>
2715
2716         Drop ExceptionCodeDescription class
2717         https://bugs.webkit.org/show_bug.cgi?id=174757
2718
2719         Reviewed by Darin Adler.
2720
2721         Stop using ExceptionCodeDescription.
2722
2723         * DOM/ExceptionHandlers.mm:
2724         (raiseDOMErrorException):
2725
2726 2017-07-21  Andreas Kling  <akling@apple.com>
2727
2728         Use more references in event dispatch code
2729         https://bugs.webkit.org/show_bug.cgi?id=174681
2730
2731         Reviewed by Geoffrey Garen.
2732
2733         * DOM/ObjCEventListener.h:
2734         * DOM/ObjCEventListener.mm:
2735         (WebCore::ObjCEventListener::handleEvent):
2736         * WebCoreSupport/WebFrameLoaderClient.mm:
2737         (NetscapePluginWidget::handleEvent):
2738
2739 2017-07-21  Brady Eidson  <beidson@apple.com>
2740
2741         Get rid of WebCore IconDatabase code.
2742         https://bugs.webkit.org/show_bug.cgi?id=174700
2743
2744         Reviewed by Tim Horton.
2745
2746         * Misc/WebCoreStatistics.mm:
2747         (+[WebCoreStatistics iconPageURLMappingCount]):
2748         (+[WebCoreStatistics iconRetainedPageURLCount]):
2749         (+[WebCoreStatistics iconRecordCount]):
2750         (+[WebCoreStatistics iconsWithDataCount]):
2751         * WebCoreSupport/WebFrameLoaderClient.h:
2752         * WebCoreSupport/WebFrameLoaderClient.mm:
2753         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
2754         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
2755         * WebView/WebView.mm:
2756         (-[WebView mainFrameIconURL]):
2757
2758 2017-07-20  Chris Dumez  <cdumez@apple.com>
2759
2760         Drop legacy XPathException type
2761         https://bugs.webkit.org/show_bug.cgi?id=174679
2762
2763         Reviewed by Sam Weinig.
2764
2765         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
2766         no longer expose XPathException.
2767
2768         * DOM/ExceptionHandlers.mm:
2769         (raiseDOMErrorException):
2770
2771 2017-07-20  Chris Dumez  <cdumez@apple.com>
2772
2773         Unreviewed, rolling out r219706.
2774
2775         Broke iOS build
2776
2777         Reverted changeset:
2778
2779         "Drop legacy XPathException type"
2780         https://bugs.webkit.org/show_bug.cgi?id=174679
2781         http://trac.webkit.org/changeset/219706
2782
2783 2017-07-20  Chris Dumez  <cdumez@apple.com>
2784
2785         Drop legacy XPathException type
2786         https://bugs.webkit.org/show_bug.cgi?id=174679
2787
2788         Reviewed by Sam Weinig.
2789
2790         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
2791         no longer expose XPathException.
2792
2793         * DOM/ExceptionHandlers.mm:
2794         (raiseDOMErrorException):
2795         * WebKit.exp:
2796
2797 2017-07-20  Chris Dumez  <cdumez@apple.com>
2798
2799         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
2800         https://bugs.webkit.org/show_bug.cgi?id=174660
2801
2802         Reviewed by Geoffrey Garen.
2803
2804         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
2805         This essentially replaces a branch to figure out if the new size is less or greater than the
2806         current size by an assertion.
2807
2808         * Plugins/WebNetscapePluginView.mm:
2809         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2810
2811 2017-07-20  Brady Eidson  <beidson@apple.com>
2812
2813         Deprecate WebIconDatabase in WebKitLegacy/mac.
2814         https://bugs.webkit.org/show_bug.cgi?id=174607
2815
2816         Reviewed by Alex Christensen.
2817
2818         This patch:
2819         1 - Formally deprecates WebIconDatabase (which was never API anyways)
2820         2 - Guts the class to where it can only return the default icon at the small size
2821         3 - Reworks other parts of WebKitLegacy that used it for anything to either
2822             use something else or to not do anything.
2823         
2824         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
2825         and that patch will remove all of the last remnants of WebIconDatabase.
2826         
2827         * History/WebHistoryItem.mm:
2828         (-[WebHistoryItem icon]):
2829
2830         * Misc/WebIconDatabase.h:
2831         * Misc/WebIconDatabase.mm:
2832         (-[WebIconDatabase init]):
2833         (-[WebIconDatabase iconForURL:withSize:cache:]):
2834         (-[WebIconDatabase iconForURL:withSize:]):
2835         (-[WebIconDatabase defaultIconWithSize:]):
2836         (-[WebIconDatabase defaultIconForURL:withSize:]):
2837         (-[WebIconDatabase iconURLForURL:]):
2838         (-[WebIconDatabase retainIconForURL:]):
2839         (-[WebIconDatabase releaseIconForURL:]):
2840         (+[WebIconDatabase delayDatabaseCleanup]):
2841         (+[WebIconDatabase allowDatabaseCleanup]):
2842         (-[WebIconDatabase setDelegate:]):
2843         (-[WebIconDatabase delegate]):
2844         (+[WebIconDatabase initialize]): Deleted.
2845         (-[WebIconDatabase isEnabled]): Deleted.
2846         (-[WebIconDatabase setEnabled:]): Deleted.
2847         (-[WebIconDatabase removeAllIcons]): Deleted.
2848         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
2849         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
2850         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
2851         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
2852         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
2853         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
2854         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
2855         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
2856         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
2857         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
2858         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
2859         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
2860         (-[WebIconDatabase _databaseDirectory]): Deleted.
2861         (webGetNSImage): Deleted.
2862
2863         * Misc/WebIconDatabaseDelegate.h: Removed.
2864         * Misc/WebIconDatabaseInternal.h: Removed.
2865         * Misc/WebIconDatabasePrivate.h: Removed.
2866
2867         * WebCoreSupport/WebFrameLoaderClient.mm:
2868         (webGetNSImage):
2869
2870         * WebCoreSupport/WebIconDatabaseClient.mm:
2871         (WebIconDatabaseClient::didRemoveAllIcons):
2872         (WebIconDatabaseClient::didImportIconURLForPageURL):
2873
2874         * WebView/WebView.mm:
2875         (-[WebView setFrameLoadDelegate:]):
2876         (-[WebView mainFrameIcon]):
2877
2878 2017-07-18  Andy Estes  <aestes@apple.com>
2879
2880         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2881         https://bugs.webkit.org/show_bug.cgi?id=174631
2882
2883         Reviewed by Tim Horton.
2884
2885         * Configurations/Base.xcconfig:
2886
2887 2017-07-18  Andy Estes  <aestes@apple.com>
2888
2889         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2890         https://bugs.webkit.org/show_bug.cgi?id=174631
2891
2892         Reviewed by Sam Weinig.
2893
2894         * Configurations/Base.xcconfig:
2895
2896 2017-07-18  Andy Estes  <aestes@apple.com>
2897
2898         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
2899         https://bugs.webkit.org/show_bug.cgi?id=174631
2900
2901         Reviewed by Dan Bernstein.
2902
2903         * Configurations/Base.xcconfig:
2904
2905 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2906
2907         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
2908         https://bugs.webkit.org/show_bug.cgi?id=174640
2909         <rdar://problem/33297400>
2910
2911         Reviewed by Tim Horton.
2912
2913         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
2914         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
2915         web thread here, to match the other WebView drag and drop SPI methods.
2916
2917         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
2918         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
2919         should make this robust against future UIKit changes that could make this no longer the case.
2920
2921         * WebView/WebView.mm:
2922         (-[WebView _requestStartDataInteraction:globalPosition:]):
2923         (-[WebView _dataInteractionCaretRect]):
2924
2925 2017-07-18  Andy Estes  <aestes@apple.com>
2926
2927         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2928         https://bugs.webkit.org/show_bug.cgi?id=174631
2929
2930         Reviewed by Darin Adler.
2931
2932         * Configurations/Base.xcconfig:
2933
2934 2017-07-17  Sam Weinig  <sam@webkit.org>
2935
2936         [WebIDL] Remove custom bindings that require non-caching JS strings
2937         https://bugs.webkit.org/show_bug.cgi?id=174552
2938
2939         Reviewed by Darin Adler.
2940
2941         * DOM/DOMHTMLCanvasElement.mm:
2942         (-[DOMHTMLCanvasElement toDataURL:]):
2943         Update to account for implementation now returning an UncachedString.
2944
2945 2017-07-17  Darin Adler  <darin@apple.com>
2946
2947         Improve use of NeverDestroyed
2948         https://bugs.webkit.org/show_bug.cgi?id=174348
2949
2950         Reviewed by Sam Weinig.
2951
2952         * Misc/WebStringTruncator.mm:
2953         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
2954         NeverDestroyed<RetainPtr> with just an NSFont * global.
2955
2956         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
2957         NeverDestroyed.h.
2958         * Storage/WebDatabaseManager.mm: Ditto.
2959         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
2960         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
2961
2962         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
2963         (aeDescFromJSValue): Removed double hashing by using the return value from
2964         add rather than calling contains before calling add.
2965
2966 2017-07-14  Jer Noble  <jer.noble@apple.com>
2967
2968         Allow clients to override their own hardware media requirements where no fallback media exists.
2969         https://bugs.webkit.org/show_bug.cgi?id=174426
2970         <rdar://problem/32537704>
2971
2972         Reviewed by Eric Carlson.
2973
2974         Add a new WebPreferences property to control WebCore's new
2975         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
2976
2977         * WebView/WebPreferenceKeysPrivate.h:
2978         * WebView/WebPreferences.mm:
2979         (+[WebPreferences initialize]):
2980         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
2981         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
2982         * WebView/WebPreferencesPrivate.h:
2983         * WebView/WebView.mm:
2984         (-[WebView _preferencesChanged:]):
2985
2986 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
2987
2988         Async image decoding for large images should be disabled by default
2989         https://bugs.webkit.org/show_bug.cgi?id=174432
2990
2991         Reviewed by Simon Fraser.
2992
2993         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
2994         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
2995         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
2996            a child view instead of propagating PaintBehaviorSnapshotting.
2997         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
2998            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
2999
3000         * WebView/WebFrame.mm:
3001         (-[WebFrame _paintBehaviorForDestinationContext:]):
3002         (-[WebFrame _drawRect:contentsOnly:]):
3003         * WebView/WebHTMLView.mm:
3004         (imageFromRect):
3005
3006 2017-07-12  Daniel Bates  <dabates@apple.com>
3007
3008         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3009         https://bugs.webkit.org/show_bug.cgi?id=174427
3010
3011         Rubber-stamped by Brady Eidson.
3012
3013         * WebView/WebPDFView.mm:
3014         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3015
3016 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3017
3018         Unreviewed, rolling out r219401.
3019
3020         This revision rolled out the previous patch, but after talking
3021         with reviewer, a rebaseline is what was needed.Rolling back in
3022         before rebaseline.
3023
3024         Reverted changeset:
3025
3026         "Unreviewed, rolling out r219379."
3027         https://bugs.webkit.org/show_bug.cgi?id=174400
3028         http://trac.webkit.org/changeset/219401
3029
3030 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3031
3032         Unreviewed, rolling out r219379.
3033
3034         This revision caused a consistent failure in the test
3035         fast/dom/Window/property-access-on-cached-window-after-frame-
3036         removed.html.
3037
3038         Reverted changeset:
3039
3040         "Remove NAVIGATOR_HWCONCURRENCY"
3041         https://bugs.webkit.org/show_bug.cgi?id=174400
3042         http://trac.webkit.org/changeset/219379
3043
3044 2017-07-11  Dean Jackson  <dino@apple.com>
3045
3046         Remove NAVIGATOR_HWCONCURRENCY
3047         https://bugs.webkit.org/show_bug.cgi?id=174400
3048
3049         * Configurations/FeatureDefines.xcconfig:
3050
3051 2017-07-11  Dean Jackson  <dino@apple.com>
3052
3053         Rolling out r219372.
3054
3055         * Configurations/FeatureDefines.xcconfig:
3056
3057 2017-07-11  Dean Jackson  <dino@apple.com>
3058
3059         Remove NAVIGATOR_HWCONCURRENCY
3060         https://bugs.webkit.org/show_bug.cgi?id=174400
3061
3062         * Configurations/FeatureDefines.xcconfig:
3063
3064 2017-07-03  Brian Burg  <bburg@apple.com>
3065
3066         Web Replay: remove some unused code
3067         https://bugs.webkit.org/show_bug.cgi?id=173903
3068
3069         Rubber-stamped by Joseph Pecoraro.
3070
3071         * Configurations/FeatureDefines.xcconfig:
3072
3073 2017-07-09  Brady Eidson  <beidson@apple.com>
3074
3075         Remove some obsolete WebKitVersionChecks.
3076         https://bugs.webkit.org/show_bug.cgi?id=174294
3077
3078         Reviewed by Dan Bernstein.
3079
3080         * Misc/WebKitVersionChecks.h:
3081
3082         * WebView/WebHTMLView.mm:
3083         (-[WebHTMLView hitTest:]):
3084
3085         * WebView/WebView.mm:
3086         (shouldRespectPriorityInCSSAttributeSetters):
3087         (-[WebView _commonInitializationWithFrameName:groupName:]):
3088         (-[WebView _preferencesChanged:]):
3089         (shouldTransformsAffectOverflow): Deleted.
3090         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
3091
3092 2017-07-08  Brady Eidson  <beidson@apple.com>
3093
3094         Remove some obsolete RuntimeApplicationChecks.
3095         https://bugs.webkit.org/show_bug.cgi?id=174293
3096
3097         Reviewed by Dan Bernstein.
3098
3099         * Misc/WebKitVersionChecks.h:
3100         * WebView/WebView.mm:
3101         (+[WebView enableWebThread]):
3102         (-[WebView _needsPreHTML5ParserQuirks]):
3103
3104 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3105
3106         Drop NOSNIFF compile flag
3107         https://bugs.webkit.org/show_bug.cgi?id=174289
3108
3109         Reviewed by Michael Catanzaro.
3110
3111         * Configurations/FeatureDefines.xcconfig:
3112
3113 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3114
3115         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3116         https://bugs.webkit.org/show_bug.cgi?id=174150
3117
3118         Reviewed by Mark Lam.
3119
3120         * DOM/DOM.mm:
3121         (lookupElementClass):
3122
3123 2017-07-06  Brady Eidson  <beidson@apple.com>
3124
3125         Add logging to first attempt to use the WebIconDatabase class.
3126         https://bugs.webkit.org/show_bug.cgi?id=174190
3127
3128         Reviewed by Andy Estes.
3129
3130         * Misc/WebIconDatabase.mm:
3131         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
3132         * Misc/WebKitVersionChecks.h:
3133
3134 2017-07-06  Matt Lewis  <jlewis3@apple.com>
3135
3136         Unreviewed, rolling out r219178.
3137
3138         This caused a consistent failure with the API test
3139         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
3140
3141         Reverted changeset:
3142
3143         "[WTF] Clean up StringStatics.cpp by using
3144         LazyNeverDestroyed<> for Atoms"
3145         https://bugs.webkit.org/show_bug.cgi?id=174150
3146         http://trac.webkit.org/changeset/219178
3147
3148 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3149
3150         [WTF] Move SoftLinking.h into WTF
3151         https://bugs.webkit.org/show_bug.cgi?id=174000
3152
3153         Reviewed by Alex Christensen.
3154
3155         * Plugins/WebNetscapePluginView.mm:
3156         * Plugins/WebPluginController.mm:
3157         * WebCoreSupport/WebInspectorClient.mm:
3158         * WebView/WebFullScreenController.mm:
3159         * WebView/WebImmediateActionController.mm:
3160         * WebView/WebView.mm:
3161
3162 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3163
3164         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3165         https://bugs.webkit.org/show_bug.cgi?id=174150
3166
3167         Reviewed by Mark Lam.
3168
3169         * DOM/DOM.mm:
3170         (lookupElementClass):
3171
3172 2017-07-05  Brady Eidson  <beidson@apple.com>
3173
3174         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3175         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3176
3177         Reviewed by Alex Christensen.
3178
3179         Adopt to the new constructor for FrameLoadRequest.
3180
3181         * WebView/WebPDFView.mm:
3182         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3183
3184 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3185
3186         Make WebKit's public headers on Mac and iOS C++ module safe
3187         https://bugs.webkit.org/show_bug.cgi?id=174175
3188
3189         Reviewed by Alex Christensen.
3190
3191         Fixed the header files.
3192
3193         * Misc/WebDownload.h:
3194         * Misc/WebKitErrors.h:
3195         * Plugins/WebPluginContainer.h:
3196         * WebView/WebResourceLoadDelegate.h:
3197
3198 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3199
3200         Remove copy of ICU headers from WebKit
3201         https://bugs.webkit.org/show_bug.cgi?id=116407
3202
3203         Reviewed by Alex Christensen.
3204
3205         Use WTF's copy of ICU headers.
3206
3207         * Configurations/WebKitLegacy.xcconfig:
3208         * icu/unicode/localpointer.h: Removed.
3209         * icu/unicode/parseerr.h: Removed.
3210         * icu/unicode/platform.h: Removed.
3211         * icu/unicode/ptypes.h: Removed.
3212         * icu/unicode/putil.h: Removed.
3213         * icu/unicode/uchar.h: Removed.
3214         * icu/unicode/uconfig.h: Removed.
3215         * icu/unicode/ucurr.h: Removed.
3216         * icu/unicode/uidna.h: Removed.
3217         * icu/unicode/uiter.h: Removed.
3218         * icu/unicode/umachine.h: Removed.
3219         * icu/unicode/unorm.h: Removed.
3220         * icu/unicode/unorm2.h: Removed.
3221         * icu/unicode/urename.h: Removed.
3222         * icu/unicode/uscript.h: Removed.
3223         * icu/unicode/ustring.h: Removed.
3224         * icu/unicode/utf.h: Removed.
3225         * icu/unicode/utf16.h: Removed.
3226         * icu/unicode/utf8.h: Removed.
3227         * icu/unicode/utf_old.h: Removed.
3228         * icu/unicode/utypes.h: Removed.
3229         * icu/unicode/uvernum.h: Removed.
3230         * icu/unicode/uversion.h: Removed.
3231
3232 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3233
3234         Add WebKitPrivateFrameworkStubs for iOS 11
3235         https://bugs.webkit.org/show_bug.cgi?id=173988
3236
3237         Reviewed by David Kilzer.
3238
3239         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
3240         use the same directory for private framework stubs.
3241
3242 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3243
3244         Unreviewed, rolling out r219103.
3245
3246         Caused multiple build failures.
3247
3248         Reverted changeset:
3249
3250         "Remove copy of ICU headers from WebKit"
3251         https://bugs.webkit.org/show_bug.cgi?id=116407
3252         http://trac.webkit.org/changeset/219103
3253
3254 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3255
3256         Remove copy of ICU headers from WebKit
3257         https://bugs.webkit.org/show_bug.cgi?id=116407
3258
3259         Reviewed by Alex Christensen.
3260
3261         Use WTF's copy of ICU headers.
3262
3263         * Configurations/WebKitLegacy.xcconfig:
3264         * icu/unicode/localpointer.h: Removed.
3265         * icu/unicode/parseerr.h: Removed.
3266         * icu/unicode/platform.h: Removed.
3267         * icu/unicode/ptypes.h: Removed.
3268         * icu/unicode/putil.h: Removed.
3269         * icu/unicode/uchar.h: Removed.
3270         * icu/unicode/uconfig.h: Removed.
3271         * icu/unicode/ucurr.h: Removed.
3272         * icu/unicode/uidna.h: Removed.
3273         * icu/unicode/uiter.h: Removed.
3274         * icu/unicode/umachine.h: Removed.
3275         * icu/unicode/unorm.h: Removed.
3276         * icu/unicode/unorm2.h: Removed.
3277         * icu/unicode/urename.h: Removed.
3278         * icu/unicode/uscript.h: Removed.
3279         * icu/unicode/ustring.h: Removed.
3280         * icu/unicode/utf.h: Removed.
3281         * icu/unicode/utf16.h: Removed.
3282         * icu/unicode/utf8.h: Removed.
3283         * icu/unicode/utf_old.h: Removed.
3284         * icu/unicode/utypes.h: Removed.
3285         * icu/unicode/uvernum.h: Removed.
3286         * icu/unicode/uversion.h: Removed.
3287
3288 2017-07-03  Brady Eidson  <beidson@apple.com>
3289
3290         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3291         https://bugs.webkit.org/show_bug.cgi?id=174073
3292
3293         Reviewed by Andy Estes.
3294
3295         WebView now keeps a direct copy of its main frame icon as a member variable.
3296         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
3297         
3298         This change causes a progression in KVO observation of the mainFrameIcon property as we now
3299         have both the old icon and new icon at the time it changes.
3300
3301         * WebCoreSupport/WebFrameLoaderClient.h:
3302         * WebCoreSupport/WebFrameLoaderClient.mm:
3303         (WebFrameLoaderClient::prepareForDataSourceReplacement):
3304         (WebFrameLoaderClient::getLoadDecisionForIcons):
3305         (WebFrameLoaderClient::finishedLoadingIcon):
3306         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3307         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3308
3309         * WebView/WebView.mm:
3310         (+[WebView _setIconLoadingEnabled:]):
3311         (+[WebView _isIconLoadingEnabled]):
3312         (-[WebView mainFrameIcon]):
3313         (-[WebView _setMainFrameIcon:]):
3314         (-[WebView _receivedIconChangedNotification:]): Deleted.
3315         (-[WebView _registerForIconNotification:]): Deleted.
3316         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
3317         * WebView/WebViewData.h:
3318         * WebView/WebViewInternal.h:
3319         * WebView/WebViewPrivate.h:
3320
3321 2017-07-03  Sam Weinig  <sam@webkit.org>
3322
3323         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
3324         https://bugs.webkit.org/show_bug.cgi?id=174083
3325
3326         Reviewed by Alex Christensen.
3327
3328         * Configurations/FeatureDefines.xcconfig:
3329         Add ENABLE_NAVIGATOR_STANDALONE.
3330
3331 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3332
3333         Expose unobscuredSafeAreaInsets on WebView
3334         https://bugs.webkit.org/show_bug.cgi?id=174075
3335         <rdar://problem/33096997>
3336
3337         Reviewed by Beth Dakin.
3338
3339         * WebView/WebView.mm:
3340         (-[WebView _setUnobscuredSafeAreaInsets:]):
3341         (-[WebView _unobscuredSafeAreaInsets]):
3342         * WebView/WebViewPrivate.h:
3343         Expose unobscuredSafeAreaInsets as a new private property on WebView,
3344         similar to how it is exposed in WebKit2.
3345
3346 2017-07-03  Andy Estes  <aestes@apple.com>
3347
3348         [Xcode] Add an experimental setting to build with ccache
3349         https://bugs.webkit.org/show_bug.cgi?id=173875
3350
3351         Reviewed by Tim Horton.
3352
3353         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3354
3355 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3356
3357         Expose WebPreferences for viewport-fit and constant() properties
3358         https://bugs.webkit.org/show_bug.cgi?id=174072
3359         <rdar://problem/33096639>
3360
3361         Reviewed by Ryosuke Niwa.
3362
3363         * WebView/WebPreferenceKeysPrivate.h:
3364         * WebView/WebPreferences.mm:
3365         (-[WebPreferences viewportFitEnabled]):
3366         (-[WebPreferences setViewportFitEnabled:]):
3367         (-[WebPreferences constantPropertiesEnabled]):
3368         (-[WebPreferences setConstantPropertiesEnabled:]):
3369         * WebView/WebPreferencesPrivate.h:
3370         * WebView/WebView.mm:
3371         (-[WebView _preferencesChanged:]):
3372
3373 2017-07-01  Tim Horton  <timothy_horton@apple.com>
3374
3375         Expose viewport-fit value to UIKit via viewport arguments dictionary
3376         https://bugs.webkit.org/show_bug.cgi?id=174071
3377         <rdar://problem/33096620>
3378
3379         Reviewed by Wenson Hsieh.
3380
3381         * History/WebHistoryItem.mm:
3382         * History/WebHistoryItemPrivate.h:
3383         Add another dictionary key and three values.
3384
3385 2017-07-01  Dan Bernstein  <mitz@apple.com>
3386
3387         [iOS] Remove code only needed when building for iOS 9.x
3388         https://bugs.webkit.org/show_bug.cgi?id=174068
3389
3390         Reviewed by Tim Horton.
3391
3392         * Configurations/FeatureDefines.xcconfig:
3393
3394 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3395
3396         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3397         https://bugs.webkit.org/show_bug.cgi?id=174004
3398
3399         Reviewed by Simon Fraser.
3400
3401         * WebCoreSupport/WebPluginInfoProvider.mm:
3402
3403 2017-07-01  Dan Bernstein  <mitz@apple.com>
3404
3405         [macOS] Remove code only needed when building for OS X Yosemite
3406         https://bugs.webkit.org/show_bug.cgi?id=174067
3407
3408         Reviewed by Tim Horton.
3409
3410         * Configurations/Base.xcconfig:
3411         * Configurations/DebugRelease.xcconfig:
3412         * Configurations/FeatureDefines.xcconfig:
3413         * Configurations/Version.xcconfig:
3414         * Plugins/WebBasePluginPackage.mm:
3415         (-[WebBasePluginPackage getPluginInfoFromPLists]):
3416         * WebCoreSupport/PopupMenuMac.mm:
3417         (PopupMenuMac::show):
3418         * WebCoreSupport/WebInspectorClient.mm:
3419         (WebInspectorFrontendClient::startWindowDrag):
3420         (-[WebInspectorWindowController window]):
3421         * WebView/WebView.mm:
3422         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3423
3424 2017-06-30  Daniel Bates  <dabates@apple.com>
3425
3426         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3427         https://bugs.webkit.org/show_bug.cgi?id=165160
3428         <rdar://problem/29451999>
3429
3430         Reviewed by Brady Eidson.
3431
3432         Pass the document that is requesting the load to the loader.
3433
3434         * WebView/WebPDFView.mm:
3435         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3436
3437 2017-06-29  Jer Noble  <jer.noble@apple.com>
3438
3439         Make Legacy EME API controlled by RuntimeEnabled setting.
3440         https://bugs.webkit.org/show_bug.cgi?id=173994
3441
3442         Reviewed by Sam Weinig.
3443
3444         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
3445
3446         * Configurations/FeatureDefines.xcconfig:
3447         * WebView/WebPreferenceKeysPrivate.h:
3448         * WebView/WebPreferences.mm:
3449         (+[WebPreferences initialize]):
3450         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
3451         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
3452         * WebView/WebPreferencesPrivate.h:
3453         * WebView/WebView.mm:
3454         (-[WebView _preferencesChanged:]):
3455
3456 2017-06-30  Chris Dumez  <cdumez@apple.com>
3457
3458         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
3459         https://bugs.webkit.org/show_bug.cgi?id=174013
3460
3461         Reviewed by Brent Fulgham.
3462
3463         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
3464         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
3465
3466         * WebView/WebView.mm:
3467         (-[WebView _commonInitializationWithFrameName:groupName:]):
3468
3469 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3470
3471         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3472         https://bugs.webkit.org/show_bug.cgi?id=174017
3473         <rdar://problem/32959782>
3474
3475         Reviewed by Simon Fraser.
3476
3477         Use root view coordinates when computing the drag caret rect.
3478
3479         * WebView/WebView.mm:
3480         (-[WebView _dataInteractionCaretRect]):
3481
3482 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
3483
3484         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
3485         https://bugs.webkit.org/show_bug.cgi?id=173899
3486         rdar://problem/32994474
3487
3488         Reviewed by Tim Horton.
3489
3490         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
3491         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
3492         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
3493
3494         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
3495         documentView is a WebHTMLView.
3496
3497         * WebView/WebFrame.mm:
3498         (-[WebFrame _webHTMLDocumentView]):
3499         (-[WebFrame _paintBehaviorForDestinationContext:]):
3500         (-[WebFrame _drawRect:contentsOnly:]):
3501         (-[WebFrame setTimeoutsPaused:]):
3502         (-[WebFrame prepareForPause]):
3503         (-[WebFrame resumeFromPause]):
3504         (-[WebFrame resetTextAutosizingBeforeLayout]):
3505         * WebView/WebHTMLView.mm:
3506         (-[WebHTMLView drawLayer:inContext:]):
3507         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
3508         * WebView/WebHTMLViewInternal.h:
3509
3510 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3511
3512         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
3513         https://bugs.webkit.org/show_bug.cgi?id=173854
3514         <rdar://problem/32236827>
3515
3516         Reviewed by Ryosuke Niwa and Tim Horton.
3517
3518         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
3519         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
3520
3521         * WebView/WebView.mm:
3522         (-[WebView _startDrag:]):
3523         (-[WebView _dragSourceAction]):
3524         (-[WebView _draggedLinkTitle]):
3525         (-[WebView _draggedLinkURL]):
3526         (-[WebView _draggedElementBounds]):
3527         (-[WebView _endedDataInteraction:global:]):
3528         * WebView/WebViewData.h:
3529         * WebView/WebViewPrivate.h:
3530
3531 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3532
3533         Refactor drag start codepaths to plumb a DragItem to client layers
3534         https://bugs.webkit.org/show_bug.cgi?id=173832
3535         Work towards <rdar://problem/32236827>
3536
3537         Reviewed by Ryosuke Niwa and Tim Horton.
3538
3539         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
3540         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
3541         to _startDrag: to match logic used to start a drag on other platforms.
3542
3543         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
3544         through the DragItem struct.
3545
3546         * WebCoreSupport/WebDragClient.h:
3547         * WebCoreSupport/WebDragClient.mm:
3548         (WebDragClient::startDrag):
3549         (WebDragClient::dragSourceActionMaskForPoint):
3550         (WebDragClient::willPerformDragSourceAction):
3551         (WebDragClient::beginDrag):
3552         * WebView/WebView.mm:
3553         (-[WebView _startDrag:]):
3554         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
3555         * WebView/WebViewInternal.h:
3556
3557 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3558
3559         Remove excessive headers from JavaScriptCore
3560         https://bugs.webkit.org/show_bug.cgi?id=173812
3561
3562         Reviewed by Darin Adler.
3563
3564         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3565         * WebView/WebView.mm:
3566
3567 2017-06-23  Tim Horton  <timothy_horton@apple.com>
3568
3569         Remove an unused typedef from WebFrameLoaderClient
3570         https://bugs.webkit.org/show_bug.cgi?id=173795
3571
3572         Reviewed by Simon Fraser.
3573
3574         * WebCoreSupport/WebFrameLoaderClient.h:
3575         This unused typedef in the global namespace conflicts with one in a macOS system header.
3576         Also... it's unused.
3577         Remove it.
3578
3579 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3580
3581         Remove excessive headers from WebCore/{bindings,css,dom}
3582         https://bugs.webkit.org/show_bug.cgi?id=173766
3583
3584         Reviewed by Simon Fraser.
3585
3586         * DOM/DOMInternal.mm:
3587
3588 2017-06-22  Daniel Bates  <dabates@apple.com>
3589
3590         Make FrameLoadRequest a move-only type
3591         https://bugs.webkit.org/show_bug.cgi?id=173682
3592
3593         Reviewed by Alex Christensen and Darin Adler.
3594
3595         A FrameLoadRequest groups together the information to perform a load into a single object
3596         that is more manageable to pass around than its constituent parts. Code that receives a
3597         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3598         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3599         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
3600
3601         * Plugins/WebPluginController.mm:
3602         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
3603         * WebView/WebPDFView.mm:
3604         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3605
3606 2017-06-21  Antoine Quint  <graouts@apple.com>
3607
3608         Ensure DRT always logs rAF suspension debugging code
3609         https://bugs.webkit.org/show_bug.cgi?id=173681
3610
3611         Reviewed by Tim "Mr. T" Horton.
3612
3613         * WebView/WebPreferenceKeysPrivate.h:
3614         * WebView/WebPreferences.mm:
3615         (+[WebPreferences initialize]):
3616         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
3617         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
3618         * WebView/WebPreferencesPrivate.h:
3619         * WebView/WebView.mm:
3620         (-[WebView _preferencesChanged:]):
3621
3622 2017-06-21  Daniel Bates  <dabates@apple.com>
3623
3624         Cleanup FrameLoadRequest
3625         https://bugs.webkit.org/show_bug.cgi?id=173564
3626         <rdar://problem/32903570>
3627
3628         Reviewed by Brent Fulgham.
3629
3630         * WebView/WebPDFView.mm:
3631         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
3632         into a local variable and use C++11 brace initialization syntax to make it easier to identify
3633         the arguments passed to FrameLoader::loadFrameRequest().
3634
3635 2017-06-21  Antoine Quint  <graouts@apple.com>
3636
3637         Add logging to identify when the Page suspends scripted animations
3638         https://bugs.webkit.org/show_bug.cgi?id=173626
3639
3640         Reviewed by Tim Horton.
3641
3642         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
3643         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
3644
3645         * WebView/WebPreferenceKeysPrivate.h:
3646         * WebView/WebPreferences.mm:
3647         (+[WebPreferences initialize]):
3648         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
3649         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
3650         * WebView/WebPreferencesPrivate.h:
3651         * WebView/WebView.mm:
3652         (-[WebView _preferencesChanged:]):
3653
3654 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
3655
3656         Disable font variations on macOS Sierra and iOS 10
3657         https://bugs.webkit.org/show_bug.cgi?id=173618
3658         <rdar://problem/32879164>
3659
3660         Reviewed by Jon Lee.
3661
3662         * Configurations/FeatureDefines.xcconfig:
3663
3664 2017-06-20  Daniel Bates  <dabates@apple.com>
3665
3666         Have FrameLoadRequest takes a Frame& instead of a Frame*
3667         https://bugs.webkit.org/show_bug.cgi?id=173614
3668         <rdar://problem/32884890>
3669
3670         Reviewed by Brent Fulgham.
3671
3672         * Plugins/WebPluginController.mm:
3673         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
3674         * WebView/WebFrame.mm:
3675         (-[WebFrame loadRequest:]):
3676         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
3677
3678 2017-06-19  Frederic Wang  <fwang@igalia.com>
3679
3680         [Mac] Add an experimental feature setting for async frame scrolling
3681         https://bugs.webkit.org/show_bug.cgi?id=173359
3682
3683         Reviewed by Simon Fraser.
3684
3685         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
3686         * WebView/WebPreferences.mm:
3687         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
3688         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
3689         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
3690         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
3691         * WebView/WebView.mm:
3692         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
3693         scrolling.
3694
3695 2017-06-19  Chris Dumez  <cdumez@apple.com>
3696
3697         Use WTF::Function instead of std::function in more places in WebCore/
3698         https://bugs.webkit.org/show_bug.cgi?id=173535
3699
3700         Reviewed by Antti Koivisto.
3701
3702         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
3703
3704         * WebCoreSupport/WebFrameLoaderClient.h:
3705         * WebCoreSupport/WebFrameLoaderClient.mm:
3706         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3707         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3708         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3709         (WebFrameLoaderClient::dispatchWillSubmitForm):
3710         (WebFrameLoaderClient::setUpPolicyListener):
3711         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
3712         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
3713
3714 2017-05-14 Frederic Wang  <fwang@igalia.com>
3715
3716         Add heuristic to avoid flattening "fullscreen" iframes
3717         https://bugs.webkit.org/show_bug.cgi?id=171914
3718
3719         Reviewed by Simon Fraser.
3720
3721         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
3722
3723         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
3724         * WebView/WebPreferences.mm:
3725         (+[WebPreferences initialize]): Handle frame flattening as an enum.
3726         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
3727         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
3728         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
3729         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
3730         * WebView/WebPreferencesPrivate.h: Ditto.
3731         * WebView/WebView.mm:
3732         (-[WebView _preferencesChanged:]): Ditto.
3733         * WebView/WebPreferencesPrivate.h: Add new enum definition.
3734
3735 2017-06-17  Chris Dumez  <cdumez@apple.com>
3736
3737         Use WTF::Function instead of std::function in WebKit2/
3738         https://bugs.webkit.org/show_bug.cgi?id=173504
3739
3740         Reviewed by Darin Adler.
3741
3742         Use WTF::Function instead of std::function in WebKit2/ to avoid
3743         unnecessary copying.
3744
3745         * Plugins/Hosted/HostedNetscapePluginStream.h:
3746         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3747         (WebKit::HostedNetscapePluginStream::willSendRequest):
3748         * Plugins/WebNetscapePluginStream.h:
3749         * Plugins/WebNetscapePluginStream.mm:
3750         (WebNetscapePluginStream::willSendRequest):
3751         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3752         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3753         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
3754         (WebPaymentCoordinatorClient::openPaymentSetup):
3755
3756 2017-06-16  Sam Weinig  <sam@webkit.org>
3757
3758         [WebIDL] Remove custom bindings for HTMLDocument
3759         https://bugs.webkit.org/show_bug.cgi?id=173444
3760
3761         Reviewed by Darin Adler.
3762
3763         * DOM/DOMHTMLDocument.mm:
3764         (-[DOMHTMLDocument linkColor]):
3765         (-[DOMHTMLDocument setLinkColor:]):
3766         (-[DOMHTMLDocument write:]):
3767         (-[DOMHTMLDocument writeln:]):
3768         Update for new signature of write/writeln and rename of linkColor to linkColorForBindings.
3769
3770 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3771
3772         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
3773         https://bugs.webkit.org/show_bug.cgi?id=173366
3774         <rdar://problem/32767014>
3775
3776         Reviewed by Tim Horton.
3777
3778         Move pieces of iOS WebKit1 drag and drop implementation into OpenSource. No change in behavior.
3779
3780         * Configurations/FeatureDefines.xcconfig:
3781         * WebCoreSupport/WebDragClient.mm:
3782         (WebDragClient::useLegacyDragClient):
3783         (WebDragClient::willPerformDragDestinationAction):
3784         (WebDragClient::dragSourceActionMaskForPoint):
3785         (WebDragClient::willPerformDragSourceAction):
3786         (WebDragClient::startDrag):
3787         (WebDragClient::beginDrag):
3788         (WebDragClient::declareAndWriteDragImage):
3789         (WebDragClient::declareAndWriteAttachment):
3790         (WebDragClient::didConcludeEditDrag):
3791         * WebView/WebView.mm:
3792         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
3793         (-[WebView _getDataInteractionData]):
3794         (-[WebView dragDataForSession:client:global:operation:]):
3795         (-[WebView _enteredDataInteraction:client:global:operation:]):
3796         (-[WebView _updatedDataInteraction:client:global:operation:]):
3797         (-[WebView _exitedDataInteraction:client:global:operation:]):
3798         (-[WebView _performDataInteraction:client:global:operation:]):
3799         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3800         (-[WebView _endedDataInteraction:global:]):
3801         (-[WebView _didConcludeEditDataInteraction]):
3802         (floatRectsForCGRectArray): Deleted.
3803         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]): Deleted.
3804         * WebView/WebViewData.h:
3805         * WebView/WebViewData.mm:
3806         (-[WebViewPrivate dealloc]):
3807         * WebView/WebViewPrivate.h:
3808
3809 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3810
3811         [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default
3812         https://bugs.webkit.org/show_bug.cgi?id=173454
3813         <rdar://problem/31720671>
3814
3815         Reviewed by Tim Horton.
3816
3817         Adds -webView:dragDestinationActionMaskForSession: as SPI to WebUIDelegate.
3818         If unimplemented, the default UI delegate allows all actions except for URL loading.
3819
3820         * DefaultDelegates/WebDefaultUIDelegate.mm:
3821         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForSession:]):
3822         * WebView/WebUIDelegatePrivate.h:
3823         * WebView/WebView.mm:
3824         (-[WebView dragDestinationActionMaskForSession:]):
3825
3826 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3827
3828         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
3829         https://bugs.webkit.org/show_bug.cgi?id=173338
3830         <rdar://problem/32777720>
3831
3832         Reviewed by Tim Horton.
3833
3834         Rename updatePreferredTypeIdentifiers to updateSupportedTypeIdentifiers.
3835
3836         * WebCoreSupport/WebPlatformStrategies.h:
3837         * WebCoreSupport/WebPlatformStrategies.mm:
3838         (WebPlatformStrategies::updateSupportedTypeIdentifiers):
3839         (WebPlatformStrategies::updatePreferredTypeIdentifiers): Deleted.
3840
3841 2017-06-13  Daniel Bates  <dabates@apple.com>
3842
3843         Implement W3C Secure Contexts Draft Specification
3844         https://bugs.webkit.org/show_bug.cgi?id=158121
3845         <rdar://problem/26012994>
3846
3847         Reviewed by Brent Fulgham.
3848
3849         Part 4
3850
3851         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3852
3853         * WebView/WebPreferenceKeysPrivate.h:
3854         * WebView/WebPreferences.mm:
3855         (+[WebPreferences initialize]):
3856         (-[WebPreferences isSecureContextAttributeEnabled]):
3857         (-[WebPreferences setIsSecureContextAttributeEnabled:]):
3858         * WebView/WebPreferencesPrivate.h:
3859         * WebView/WebView.mm:
3860         (-[WebView _preferencesChanged:]):
3861
3862 2017-06-13  Sam Weinig  <sam@webkit.org>
3863
3864         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
3865         https://bugs.webkit.org/show_bug.cgi?id=80733
3866
3867         Reviewed by Chris Dumez.
3868
3869         * DOM/DOMUtility.mm:
3870         (createDOMWrapper):
3871         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3872         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3873         * WebView/WebFrame.mm:
3874         (-[WebFrame _attachScriptDebugger]):
3875         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3876
3877 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
3878
3879         [WebCrypto] Remove experimental feature flag of SubtleCrypto
3880         https://bugs.webkit.org/show_bug.cgi?id=173197
3881         <rdar://problem/32688148>
3882
3883         Reviewed by Brent Fulgham.
3884
3885         * WebView/WebPreferences.mm:
3886         (+[WebPreferences initialize]):
3887         (-[WebPreferences subtleCryptoEnabled]): Deleted.
3888         (-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
3889         * WebView/WebPreferencesPrivate.h:
3890         * WebView/WebView.mm:
3891         (-[WebView _preferencesChanged:]):
3892
3893 2017-06-10  Dan Bernstein  <mitz@apple.com>
3894
3895         Reverted r218056 because it made the IDE reindex constantly.
3896
3897         * Configurations/DebugRelease.xcconfig:
3898
3899 2017-06-10  Dan Bernstein  <mitz@apple.com>
3900
3901         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
3902         https://bugs.webkit.org/show_bug.cgi?id=173223
3903
3904         Reviewed by Sam Weinig.
3905
3906         The rebuilds were happening due to a difference in the compiler options that the IDE and
3907         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
3908         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
3909         specify an appropriate path in CLANG_INDEX_STORE_PATH.
3910
3911         * Configurations/DebugRelease.xcconfig:
3912
3913 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3914
3915         [iOS DnD] Add a hook to perform two-step drops in editable content
3916         https://bugs.webkit.org/show_bug.cgi?id=172992
3917         <rdar://problem/32590174>
3918
3919         Reviewed by Tim Horton.
3920
3921         Adds a new SPI to WebUIKitDelegate to allow WK1 clients to override default drop behavior. Returning YES from
3922         -performTwoStepDrop:atDestination:isMove: will prevent content from being inserted on drop in WebKit; otherwise,
3923         returning NO will continue with default WebKit behavior.
3924
3925         * WebCoreSupport/WebEditorClient.h:
3926         * WebCoreSupport/WebEditorClient.mm:
3927         (WebEditorClient::performTwoStepDrop):
3928
3929 2017-06-08  Jer Noble  <jer.noble@apple.com>
3930
3931         Clients of the WK2 C-API don't have their mediaContentTypesRequiringHardwareSupport setting initialized correctly.
3932         https://bugs.webkit.org/show_bug.cgi?id=173091
3933
3934         Reviewed by Eric Carlson.
3935
3936         * WebView/WebPreferences.mm:
3937         (+[WebPreferences initialize]):
3938
3939 2017-06-07  Jer Noble  <jer.noble@apple.com>
3940
3941         Clean-up: RenderElement.h includes headers it doesn't use
3942         https://bugs.webkit.org/show_bug.cgi?id=173046
3943
3944         Reviewed by Andy Estes.
3945
3946         * WebView/WebImmediateActionController.mm:
3947
3948 2017-06-07  Zalan Bujtas  <zalan@apple.com>
3949
3950         [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
3951         https://bugs.webkit.org/show_bug.cgi?id=173044
3952         <rdar://problem/32449338>
3953
3954         Reviewed by Tim Horton.
3955
3956         Cache the current device orientation so that we don't have to lift the WebThread lock
3957         to collect it.
3958
3959         * WebView/WebFrame.mm:
3960         (-[WebFrame deviceOrientationChanged]):
3961         * WebView/WebView.mm:
3962         (-[WebView _commonInitializationWithFrameName:groupName:]):
3963         (-[WebView _setDeviceOrientation:]):
3964         (-[WebView _deviceOrientation]):
3965         * WebView/WebViewData.h:
3966         * WebView/WebViewInternal.h:
3967
3968 2017-06-06  Jer Noble  <jer.noble@apple.com>
3969
3970         [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
3971         https://bugs.webkit.org/show_bug.cgi?id=173008
3972
3973         Reviewed by Eric Carlson.
3974
3975         Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
3976
3977         * WebView/WebPreferenceKeysPrivate.h:
3978         * WebView/WebPreferences.mm:
3979         (+[WebPreferences initialize]):
3980         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
3981         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
3982         * WebView/WebPreferencesPrivate.h:
3983         * WebView/WebView.mm:
3984         (-[WebView _preferencesChanged:]):
3985
3986 2017-06-06  Youenn Fablet  <youenn@apple.com>
3987
3988         Add an option to disable getUserMedia prompt in case of mock capture sources
3989         https://bugs.webkit.org/show_bug.cgi?id=172981
3990         <rdar://problem/32580325>
3991
3992         Reviewed by Eric Carlson.
3993
3994         Defining the option, getter and setter.
3995
3996         * WebView/WebPreferences.mm:
3997         (+[WebPreferences initialize]):
3998         (-[WebPreferences mockCaptureDevicesPromptEnabled]):
3999         (-[WebPreferences setMockCaptureDevicesPromptEnabled:]):
4000         * WebView/WebPreferencesPrivate.h:
4001
4002 2017-06-05  Dan Bernstein  <mitz@apple.com>
4003
4004         Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.
4005
4006         * WebView/WebView.mm:
4007         (-[WebView updateMediaTouchBar]):
4008         * WebView/WebViewData.h:
4009
4010 2017-06-03  Darin Adler  <darin@apple.com>
4011
4012         Streamline handling of attributes, using references as much as possible
4013         https://bugs.webkit.org/show_bug.cgi?id=172899
4014
4015         Reviewed by Chris Dumez.
4016
4017         * WebView/WebHTMLRepresentation.mm:
4018         (matchLabelsAgainstElement): Added handling of nullptr since nothing guarantees the
4019         passed in element can't be null. Removed unnecessary conversion from NSString to String
4020         and then back to NSString.
4021
4022 2017-06-01  Andy Estes  <aestes@apple.com>
4023
4024         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
4025         https://bugs.webkit.org/show_bug.cgi?id=172828
4026
4027         Reviewed by Beth Dakin.
4028
4029         * Configurations/FeatureDefines.xcconfig:
4030
4031 2017-05-31  Andy Estes  <aestes@apple.com>
4032
4033         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
4034         https://bugs.webkit.org/show_bug.cgi?id=172366
4035
4036         Reviewed by Daniel Bates.
4037
4038         * Configurations/FeatureDefines.xcconfig:
4039
4040 2017-05-30  Ryosuke Niwa  <rniwa@webkit.org>
4041
4042         Only include DataDetectorsUI headers in iOS
4043         https://bugs.webkit.org/show_bug.cgi?id=172633
4044
4045         Reviewed by David Kilzer.
4046
4047         Enable data detectors only on iOS and not other variants of iOS.
4048
4049         * WebCoreSupport/WebFrameLoaderClient.mm:
4050
4051 2017-05-30  Alex Christensen  <achristensen@webkit.org>
4052
4053         Update libwebrtc configuration
4054         https://bugs.webkit.org/show_bug.cgi?id=172727
4055
4056         Reviewed by Geoffrey Garen.
4057
4058         * Configurations/FeatureDefines.xcconfig:
4059
4060 2017-05-28  Dan Bernstein  <mitz@apple.com>
4061
4062         [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
4063         https://bugs.webkit.org/show_bug.cgi?id=172691
4064
4065         Reviewed by Tim Horton.
4066
4067         * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
4068
4069 2017-05-26  Brent Fulgham  <bfulgham@apple.com>
4070
4071         [WK2] Address thread safety issues with ResourceLoadStatistics
4072         https://bugs.webkit.org/show_bug.cgi?id=172519
4073         <rdar://problem/31707642>
4074
4075         Reviewed by Chris Dumez.
4076
4077         Create a new WorkQueue for the ResourceLoadStatistics store to use for processing data.
4078
4079         * WebView/WebView.mm:
4080         (WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Pass WorkQueue to the observer.
4081
4082 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
4083
4084         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
4085         https://bugs.webkit.org/show_bug.cgi?id=172554