[Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by...
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-04-12  Antoine Quint  <graouts@apple.com>
2
3         [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
4         https://bugs.webkit.org/show_bug.cgi?id=184569
5         <rdar://problem/38671301>
6
7         Reviewed by Jon Lee.
8
9         * WebView/WebPreferences.mm:
10
11 2018-04-05  Yusuke Suzuki  <utatane.tea@gmail.com>
12
13         [WTF] Remove StaticLock
14         https://bugs.webkit.org/show_bug.cgi?id=184332
15
16         Reviewed by Mark Lam.
17
18         * DOM/DOMInternal.mm:
19         (getDOMWrapper):
20         (addDOMWrapper):
21         (removeDOMWrapper):
22
23 2018-04-04  Brent Fulgham  <bfulgham@apple.com>
24
25         Failures from mach port reference handling should be fatal
26         https://bugs.webkit.org/show_bug.cgi?id=184202
27         <rdar://problem/37771114>
28
29         Reviewed by Anders Carlsson.
30
31         * Plugins/Hosted/NetscapePluginHostManager.mm:
32         (WebKit::NetscapePluginHostManager::spawnPluginHost): Adopt new 'safe mach_port_t deallocation' function.
33
34 2018-04-03  Andy Estes  <aestes@apple.com>
35
36         [Mac] Prioritize file promises over filenames during drag and drop
37         https://bugs.webkit.org/show_bug.cgi?id=184237
38         <rdar://problem/38278076>
39
40         Reviewed by Wenson Hsieh.
41
42         * WebView/WebView.mm:
43         (-[WebView performDragOperation:]):
44
45 2018-04-03  Chris Dumez  <cdumez@apple.com>
46
47         Drop MainFrame class
48         https://bugs.webkit.org/show_bug.cgi?id=184191
49
50         Reviewed by Darin Adler.
51
52         Drop MainFrame class and move contents into Page / Frame since there is a 1:1
53         relationship between the Page and the MainFrame.
54
55         This is ground work for introducing LocalFrame / RemoteFrame concepts.
56
57         * WebCoreSupport/WebDragClient.mm:
58         * WebCoreSupport/WebFrameLoaderClient.mm:
59         * WebCoreSupport/WebInspectorClient.mm:
60         * WebCoreSupport/WebPlatformStrategies.mm:
61         * WebCoreSupport/WebPluginInfoProvider.mm:
62         * WebView/WebFrame.mm:
63         * WebView/WebFrameView.mm:
64         * WebView/WebHTMLView.mm:
65         * WebView/WebView.mm:
66
67 2018-04-02  Jer Noble  <jer.noble@apple.com>
68
69         Enable Legacy EME for all WebKit & WebKitLegacy clients
70         https://bugs.webkit.org/show_bug.cgi?id=184018
71         <rdar://problem/34887387>
72
73         Reviewed by Eric Carlson.
74
75         * WebView/WebPreferences.mm:
76         (+[WebPreferences initialize]):
77
78 2018-03-29  JF Bastien  <jfbastien@apple.com>
79
80         Use Forward.h instead of forward-declaring WTF::String
81         https://bugs.webkit.org/show_bug.cgi?id=184172
82         <rdar://problem/39026146>
83
84         Reviewed by Yusuke Suzuki.
85
86         As part of #184164 I'm changing WTF::String, and the forward
87         declarations are just wrong because I'm making it templated. We
88         should use Forward.h anyways, so do that instead.
89
90         * WebView/WebScriptDebugger.h:
91
92 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
93
94         Protect against invalid mach ports returned by mach_port_request_notification
95         https://bugs.webkit.org/show_bug.cgi?id=184106
96         <rdar://problem/37865316>
97
98         Reviewed by Chris Dumez.
99
100         * Plugins/Hosted/NetscapePluginHostProxy.mm:
101         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Check return value from 'mach_port_request_notification'
102         and clean up if it experienced an error.
103         (WebKit::NetscapePluginHostProxy::processRequests): Drive-by-fix: Include formatted mach error message in logging.
104
105 2018-03-28  Brent Fulgham  <bfulgham@apple.com>
106
107         Avoid uninitialized mach ports
108         https://bugs.webkit.org/show_bug.cgi?id=184090
109         <rdar://problem/37261129>
110
111         Reviewed by Chris Dumez.
112
113         It is possible for mach_port_allocate to return an error, but we rarely check its return value. The value
114         of the argument passed to mach_port_allocate is not guaranteed to be valid when it returns an error, so
115         there is a potential for us to try to use invalid ports.
116
117         We should always check return values, and ensure that the mach port variables we seek to initialize are
118         kept in a valid state.
119
120         Reviewed by Chris Dumez.
121
122         * Plugins/Hosted/NetscapePluginHostManager.h:
123         * Plugins/Hosted/NetscapePluginHostManager.mm:
124         (WebKit::NetscapePluginHostManager::hostForPlugin): Initialize port to a valid state, ASSERT if an invalid
125         port is passed to an API function.
126         (WebKit::NetscapePluginHostManager::spawnPluginHost): Ditto.
127         (WebKit::NetscapePluginHostManager::initializeVendorPort): Ditto.
128         * Plugins/Hosted/NetscapePluginHostProxy.h:
129         * Plugins/Hosted/NetscapePluginHostProxy.mm:
130         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Ditto.
131         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
132         (WebKit::NetscapePluginHostProxy::processRequests): Ditto.
133         (WKPCStatusText): Ditto.
134         (WKPCLoadURL): Ditto.
135         (WKPCCancelLoadURL): Ditto.
136         (WKPCInvalidateRect): Ditto.
137         (WKPCGetScriptableNPObjectReply): Ditto.
138         (WKPCBooleanReply): Ditto.
139         (WKPCBooleanAndDataReply): Ditto.
140         (WKPCInstantiatePluginReply): Ditto.
141         (WKPCGetWindowNPObject): Ditto.
142         (WKPCGetPluginElementNPObject): Ditto.
143         (WKPCForgetBrowserObject): Ditto.
144         (WKPCEvaluate): Ditto.
145         (WKPCGetStringIdentifier): Ditto.
146         (WKPCGetIntIdentifier): Ditto.
147         (WKPCInvoke): Ditto.
148         (WKPCInvokeDefault): Ditto.
149         (WKPCConstruct): Ditto.
150         (WKPCGetProperty): Ditto.
151         (WKPCSetProperty): Ditto.
152         (WKPCRemoveProperty): Ditto.
153         (WKPCHasProperty): Ditto.
154         (WKPCHasMethod): Ditto.
155         (WKPCIdentifierInfo): Ditto.
156         (WKPCEnumerate): Ditto.
157         (WKPCSetMenuBarVisible): Ditto.
158         (WKPCSetFullscreenWindowIsShowing): Ditto.
159         (WKPCSetModal): Ditto.
160         (WKPCGetCookies): Ditto.
161         (WKPCGetProxy): Ditto.
162         (WKPCSetCookies): Ditto.
163         (WKPCGetAuthenticationInfo): Ditto.
164         (WKPCConvertPoint): Ditto.
165         (WKPCLayerHostingModeChanged): Ditto.
166         (WKPCSetException): Ditto.
167
168 2018-03-26  Tim Horton  <timothy_horton@apple.com>
169
170         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKit
171         https://bugs.webkit.org/show_bug.cgi?id=184030
172         <rdar://problem/38895281>
173
174         Reviewed by Dan Bernstein.
175
176         * Configurations/Base.xcconfig:
177
178 2018-03-26  Chris Dumez  <cdumez@apple.com>
179
180         Use SecurityOriginData more consistently in Service Worker code
181         https://bugs.webkit.org/show_bug.cgi?id=183969
182
183         Reviewed by Darin Adler.
184
185         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
186
187         * Storage/WebDatabaseManager.mm:
188         (-[WebDatabaseManager databasesWithOrigin:]):
189         (-[WebDatabaseManager deleteOrigin:]):
190         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
191         * Storage/WebDatabaseQuotaManager.mm:
192         (-[WebDatabaseQuotaManager usage]):
193         (-[WebDatabaseQuotaManager quota]):
194         (-[WebDatabaseQuotaManager setQuota:]):
195         * Storage/WebStorageManager.mm:
196         (-[WebStorageManager deleteOrigin:]):
197         * WebCoreSupport/WebSecurityOrigin.mm:
198         (-[WebSecurityOrigin databaseIdentifier]):
199         (-[WebSecurityOrigin usage]):
200         (-[WebSecurityOrigin quota]):
201         (-[WebSecurityOrigin setQuota:]):
202
203 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
204
205         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
206         https://bugs.webkit.org/show_bug.cgi?id=183911
207         <rdar://problem/38762306>
208
209         Reviewed by Youenn Fablet.
210
211         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
212
213         * WebView/WebView.mm:
214         (+[WebView initialize]):
215
216 2018-03-26  Alex Christensen  <achristensen@webkit.org>
217
218         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
219         https://bugs.webkit.org/show_bug.cgi?id=183965
220
221         Reviewed by Chris Dumez.
222
223         * WebCoreSupport/WebFrameLoaderClient.h:
224         * WebCoreSupport/WebFrameLoaderClient.mm:
225         (WebFrameLoaderClient::willCacheResponse const):
226
227 2018-03-25  Commit Queue  <commit-queue@webkit.org>
228
229         Unreviewed, rolling out r229954.
230         https://bugs.webkit.org/show_bug.cgi?id=184000
231
232         Caused many layout tests to crash on Apple High Sierra,
233         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
234         by dydz on #webkit).
235
236         Reverted changeset:
237
238         "Use SecurityOriginData more consistently in Service Worker
239         code"
240         https://bugs.webkit.org/show_bug.cgi?id=183969
241         https://trac.webkit.org/changeset/229954
242
243 2018-03-24  Chris Dumez  <cdumez@apple.com>
244
245         Use SecurityOriginData more consistently in Service Worker code
246         https://bugs.webkit.org/show_bug.cgi?id=183969
247
248         Reviewed by Darin Adler.
249
250         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
251
252         * Storage/WebDatabaseManager.mm:
253         (-[WebDatabaseManager databasesWithOrigin:]):
254         (-[WebDatabaseManager deleteOrigin:]):
255         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
256         * Storage/WebDatabaseQuotaManager.mm:
257         (-[WebDatabaseQuotaManager usage]):
258         (-[WebDatabaseQuotaManager quota]):
259         (-[WebDatabaseQuotaManager setQuota:]):
260         * Storage/WebStorageManager.mm:
261         (-[WebStorageManager deleteOrigin:]):
262         * WebCoreSupport/WebSecurityOrigin.mm:
263         (-[WebSecurityOrigin databaseIdentifier]):
264         (-[WebSecurityOrigin usage]):
265         (-[WebSecurityOrigin quota]):
266         (-[WebSecurityOrigin setQuota:]):
267
268 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
269
270         Fix the build
271
272         * WebView/WebView.mm:
273
274 2018-03-23  Tim Horton  <timothy_horton@apple.com>
275
276         Fix the build with no pasteboard
277         https://bugs.webkit.org/show_bug.cgi?id=183973
278
279         Reviewed by Dan Bernstein.
280
281         * Configurations/FeatureDefines.xcconfig:
282         * WebView/WebView.mm:
283         (-[WebView _requestStartDataInteraction:globalPosition:]):
284         (-[WebView _getDataInteractionData]):
285         (-[WebView _dataOperationTextIndicator]):
286         (-[WebView _dragSourceAction]):
287         (-[WebView _draggedLinkTitle]):
288         (-[WebView _draggedLinkURL]):
289         (-[WebView _draggedElementBounds]):
290         (-[WebView _enteredDataInteraction:client:global:operation:]):
291         (-[WebView _updatedDataInteraction:client:global:operation:]):
292         (-[WebView _exitedDataInteraction:client:global:operation:]):
293         (-[WebView _performDataInteraction:client:global:operation:]):
294         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
295         (-[WebView _endedDataInteraction:global:]):
296         (-[WebView _dataInteractionCaretRect]):
297         * WebView/WebViewPrivate.h:
298
299 2018-03-23  Tim Horton  <timothy_horton@apple.com>
300
301         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
302         https://bugs.webkit.org/show_bug.cgi?id=183960
303         <rdar://problem/38812356>
304
305         Reviewed by Dan Bernstein.
306
307         * Configurations/WebKitLegacy.xcconfig:
308
309 2018-03-23  Tim Horton  <timothy_horton@apple.com>
310
311         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
312         https://bugs.webkit.org/show_bug.cgi?id=183954
313         <rdar://problem/38808858>
314
315         Reviewed by Dan Bernstein.
316
317         * WebView/WebPreferences.mm:
318         (-[WebPreferences setAudioSessionCategoryOverride:]):
319
320 2018-03-23  Tim Horton  <timothy_horton@apple.com>
321
322         Adopt WK_PLATFORM_NAME in WebKitLegacy
323         https://bugs.webkit.org/show_bug.cgi?id=183948
324         <rdar://problem/38803908>
325
326         Reviewed by Dan Bernstein.
327
328         * Configurations/WebKitLegacy.xcconfig:
329         * MigrateHeaders.make:
330         * postprocess-headers.sh:
331
332 2018-03-23  Brady Eidson  <beidson@apple.com>
333
334         Go to back/forward list items after a process-swapped navigation.
335         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
336
337         Reviewed by Andy Estes.
338
339         * WebView/WebView.mm:
340         (-[WebView _loadBackForwardListFromOtherView:]):
341         (-[WebView goToBackForwardItem:]):
342
343 2018-03-22  Tim Horton  <timothy_horton@apple.com>
344
345         Improve readability of WebCore's OTHER_LDFLAGS
346         https://bugs.webkit.org/show_bug.cgi?id=183909
347         <rdar://problem/38760992>
348
349         Reviewed by Dan Bernstein.
350
351         * Configurations/Base.xcconfig:
352         * Configurations/FeatureDefines.xcconfig:
353
354 2018-03-20  Tim Horton  <timothy_horton@apple.com>
355
356         Enable the minimal simulator feature flag when appropriate
357         https://bugs.webkit.org/show_bug.cgi?id=183807
358
359         Reviewed by Dan Bernstein.
360
361         * Configurations/FeatureDefines.xcconfig:
362
363 2018-03-20  Tim Horton  <timothy_horton@apple.com>
364
365         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
366         https://bugs.webkit.org/show_bug.cgi?id=183758
367         <rdar://problem/38017644>
368
369         Reviewed by Dan Bernstein.
370
371         * Configurations/FeatureDefines.xcconfig:
372
373 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
374
375         Clear style colors when setting default appearance
376         https://bugs.webkit.org/show_bug.cgi?id=183759
377
378         Reviewed by Tim Horton.
379
380         Colors are cached and need to be cleared and recalculated.
381         Refactor to do all style recalcs together.
382
383         * WebView/WebView.mm:
384         (-[WebView _setDefaultAppearanceAndClearStyle]):
385         (-[WebView _setUseSystemAppearance:]):
386         (-[WebView effectiveAppearanceDidChange]):
387
388 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
389
390         Unreviewed, another quick fix for r229699
391
392         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
393
394         * Configurations/FeatureDefines.xcconfig:
395
396 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
397
398         Ensure that style is updated when the effective appearance changes
399         https://bugs.webkit.org/show_bug.cgi?id=183690
400         <rdar://problem/38385900>
401
402         Reviewed by Tim Horton and Wenson Hsieh.
403
404         Respond to and respect the effective appearance changing.
405
406         * WebView/WebView.mm:
407         (-[WebView _setUseSystemAppearance:]):
408         (-[WebView effectiveAppearanceDidChange]):
409
410 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
411
412         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
413         https://bugs.webkit.org/show_bug.cgi?id=183677
414
415         Reviewed by Tim Horton.
416
417         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
418
419         * DOM/DOM.mm:
420         (-[DOMHTMLLinkElement _mediaQueryMatches]):
421
422 2018-03-14  Tim Horton  <timothy_horton@apple.com>
423
424         Fix the build after r229567
425
426         * Configurations/FeatureDefines.xcconfig:
427
428 2018-03-12  Tim Horton  <timothy_horton@apple.com>
429
430         Stop using SDK conditionals to control feature definitions
431         https://bugs.webkit.org/show_bug.cgi?id=183430
432         <rdar://problem/38251619>
433
434         Reviewed by Dan Bernstein.
435
436         * Configurations/FeatureDefines.xcconfig:
437         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
438
439 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
440
441         Runtime flag for link prefetch and remove link subresource.
442         https://bugs.webkit.org/show_bug.cgi?id=183540
443
444         Reviewed by Chris Dumez.
445
446         Remove the LINK_PREFETCH build time flag.
447
448         * Configurations/FeatureDefines.xcconfig:
449
450 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
451
452         Remove GridLayout runtime flag
453         https://bugs.webkit.org/show_bug.cgi?id=183484
454
455         Reviewed by Myles C. Maxfield.
456
457         The Grid Layout feature has been enabled by default for almost a
458         year, so I think it's time to remove the runtime flag and the
459
460         * WebView/WebPreferenceKeysPrivate.h:
461         * WebView/WebPreferences.mm:
462         (+[WebPreferences initialize]):
463         * WebView/WebPreferencesPrivate.h:
464         * WebView/WebView.mm:
465         (-[WebView _preferencesChanged:]):
466
467 2018-03-12  Antoine Quint  <graouts@apple.com>
468
469         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
470         https://bugs.webkit.org/show_bug.cgi?id=183504
471         <rdar://problem/38372965>
472
473         Reviewed by Dean Jackson and Jon Lee.
474
475         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
476         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
477
478         * WebView/WebPreferenceKeysPrivate.h:
479         * WebView/WebPreferences.mm:
480         (+[WebPreferences initialize]):
481         (-[WebPreferences setModernMediaControlsEnabled:]):
482         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
483         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
484         * WebView/WebPreferencesPrivate.h:
485         * WebView/WebView.mm:
486         (-[WebView _preferencesChanged:]):
487
488 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
489
490         Media query for default appearance
491         https://bugs.webkit.org/show_bug.cgi?id=183539
492         <rdar://problem/38326388>
493
494         Reviewed by Tim Horton.
495
496         Write a media query to evaluate appearance.
497
498         * WebView/WebView.mm:
499         (-[WebView _commonInitializationWithFrameName:groupName:]):
500         (-[WebView _setUseSystemAppearance:]):
501
502 2018-03-09  Andy Estes  <aestes@apple.com>
503
504         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
505         https://bugs.webkit.org/show_bug.cgi?id=183489
506         <rdar://problem/38267517>
507
508         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
509         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
510         to issue a sandbox extension for this directory, but for security reasons App Sandbox
511         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
512         block with a nil error and a valid file URL, but no file will actually exist at that URL.
513
514         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
515         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
516         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
517         drop destination.
518
519         Reviewed by Wenson Hsieh.
520
521         * WebView/WebView.mm:
522         (-[WebView performDragOperation:]):
523
524 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
525
526         Allow WebViews to disable system appearance
527         https://bugs.webkit.org/show_bug.cgi?id=183418
528         <rdar://problem/36975642>
529
530         Reviewed by Tim Horton.
531
532         Allow webviews to choose whether or not to follow the default system appearance.
533
534         * WebView/WebView.mm:
535         (-[WebView _setUseSystemAppearance:]):
536         (-[WebView _useSystemAppearance]):
537         * WebView/WebViewPrivate.h:
538
539 2018-03-08  Youenn Fablet  <youenn@apple.com>
540
541         libwebrtc update broke internal builds
542         https://bugs.webkit.org/show_bug.cgi?id=183454
543
544         Reviewed by Eric Carlson.
545
546         * Configurations/WebKitLegacy.xcconfig:
547
548 2018-03-08  Chris Dumez  <cdumez@apple.com>
549
550         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
551         https://bugs.webkit.org/show_bug.cgi?id=183455
552         <rdar://problem/38191749>
553
554         Reviewed by Youenn Fablet.
555
556         Add a null check for the page as we have evidence from crashes that it can be null.
557         Other functions in WebFrameNetworkingContext already null check the page as well,
558         not just the frame so this is consistent.
559
560         * WebCoreSupport/WebFrameNetworkingContext.mm:
561         (WebFrameNetworkingContext::storageSession const):
562
563 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
564
565         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
566         https://bugs.webkit.org/show_bug.cgi?id=183429
567
568         Reviewed by Mark Lam.
569
570         * DOM/DOM.mm:
571         (+[DOMNode _nodeFromJSWrapper:]):
572         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
573         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
574         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
575         * Plugins/Hosted/ProxyInstance.mm:
576         (WebKit::ProxyInstance::invokeMethod):
577         * WebView/WebView.mm:
578         (aeDescFromJSValue):
579
580 2018-03-08  Tim Horton  <timothy_horton@apple.com>
581
582         Stop linking ApplicationServices directly
583         https://bugs.webkit.org/show_bug.cgi?id=182867
584         <rdar://problem/38252142>
585
586         Reviewed by Alex Christensen.
587
588         The frameworks that we use that live inside ApplicationServices
589         have mostly moved out, so import them directly.
590
591         * Carbon/CarbonUtils.h:
592         * WebKitPrefix.h:
593         * WebView/WebHTMLView.mm:
594         * WebView/WebPDFView.mm:
595
596 2018-03-07  Tim Horton  <timothy_horton@apple.com>
597
598         Sort and separate FeatureDefines.xcconfig
599         https://bugs.webkit.org/show_bug.cgi?id=183427
600
601         Reviewed by Dan Bernstein.
602
603         * Configurations/FeatureDefines.xcconfig:
604         Sort and split FeatureDefines into paragraphs
605         (to make it easier to sort later).
606
607 2018-03-07  Youenn Fablet  <youenn@apple.com>
608
609         Match unsupported plugins based on domains and not origin
610         https://bugs.webkit.org/show_bug.cgi?id=183384
611
612         Reviewed by Chris Dumez.
613
614         * WebCoreSupport/WebPluginInfoProvider.h:
615         * WebCoreSupport/WebPluginInfoProvider.mm:
616         (WebPluginInfoProvider::getPluginInfo):
617         (WebPluginInfoProvider::getWebVisiblePluginInfo):
618
619 2018-03-05  Andy Estes  <aestes@apple.com>
620
621         [Mac] Teach WebCore::Pasteboard about file promise drags
622         https://bugs.webkit.org/show_bug.cgi?id=183314
623         <rdar://problem/38105493>
624
625         Reviewed by Darin Adler.
626
627         Added a FIXME comment.
628
629         * WebView/WebView.mm:
630         (-[WebView performDragOperation:]):
631
632 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
633
634         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
635         https://bugs.webkit.org/show_bug.cgi?id=183312
636
637         Reviewed by Mark Lam.
638
639         Remove wtf/CurrentTime.h include pragma.
640
641         * WebView/WebFrame.mm:
642         * WebView/WebPDFView.mm:
643
644 2018-03-04  Tim Horton  <timothy_horton@apple.com>
645
646         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
647         https://bugs.webkit.org/show_bug.cgi?id=183283
648         <rdar://problem/38062148>
649
650         Reviewed by Sam Weinig.
651
652         * Configurations/FeatureDefines.xcconfig:
653
654 2018-02-28  Alex Christensen  <achristensen@webkit.org>
655
656         Reduce use of NetworkingContext in WebKit
657         https://bugs.webkit.org/show_bug.cgi?id=183213
658
659         Reviewed by Brady Eidson.
660
661         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
662         (WebKit::NetscapePluginInstanceProxy::getProxy):
663         * Plugins/WebNetscapePluginView.mm:
664         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
665
666 2018-02-17  Darin Adler  <darin@apple.com>
667
668         Prepare for ExtendedColor changes (first step)
669         https://bugs.webkit.org/show_bug.cgi?id=182904
670
671         Reviewed by Sam Weinig.
672
673         * Misc/WebKitNSStringExtras.mm:
674         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
675
676 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
677
678         Remove currentTime() / currentTimeMS()
679         https://bugs.webkit.org/show_bug.cgi?id=183052
680
681         Reviewed by Mark Lam.
682
683         * WebCoreSupport/WebFrameLoaderClient.h:
684         * WebCoreSupport/WebFrameLoaderClient.mm:
685         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
686
687 2018-02-16  Youenn Fablet  <youenn@apple.com>
688
689         Allow specifying which plug-ins are supported
690         https://bugs.webkit.org/show_bug.cgi?id=182748
691
692         Reviewed by Chris Dumez.
693
694         * WebCoreSupport/WebPluginInfoProvider.h:
695         * WebCoreSupport/WebPluginInfoProvider.mm:
696         (WebPluginInfoProvider::getPluginInfo):
697         (WebPluginInfoProvider::getWebVisiblePluginInfo):
698
699 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
700
701         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
702         https://bugs.webkit.org/show_bug.cgi?id=182882
703         <rdar://problem/35672661>
704
705         Reviewed by Dan Bernstein.
706
707         Make sure the smart pointer hold the collection of subviews lives at least as
708         long as the loop using it.
709
710         * WebView/WebHTMLView.mm:
711         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
712
713 2018-02-14  Daniel Bates  <dabates@apple.com>
714
715         Disallow cross-origin subresources from asking for credentials
716         https://bugs.webkit.org/show_bug.cgi?id=182579
717         <rdar://problem/36162271>
718
719         Reviewed by Andy Estes.
720
721         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
722         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
723
724         * WebView/WebPreferenceKeysPrivate.h:
725         * WebView/WebPreferences.mm:
726         (+[WebPreferences initialize]):
727         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
728         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
729         * WebView/WebPreferencesPrivate.h:
730         * WebView/WebView.mm:
731         (-[WebView _preferencesChanged:]):
732
733 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
734
735         Remove ForwardingHeaders directory from WebKitLegacy/mac.
736         https://bugs.webkit.org/show_bug.cgi?id=182738
737
738         Reviewed by Darin Adler.
739
740         * ForwardingHeaders/collector/handles/Global.h: Removed.
741         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
742         * ForwardingHeaders/runtime/Completion.h: Removed.
743         * ForwardingHeaders/runtime/Error.h: Removed.
744         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
745         * ForwardingHeaders/runtime/JSFunction.h: Removed.
746         * ForwardingHeaders/runtime/JSLock.h: Removed.
747         * ForwardingHeaders/runtime/JSObject.h: Removed.
748         * ForwardingHeaders/runtime/JSString.h: Removed.
749         * ForwardingHeaders/runtime/Protect.h: Removed.
750         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
751
752 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
753
754         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
755         https://bugs.webkit.org/show_bug.cgi?id=182641
756
757         Reviewed by Dan Bernstein.
758
759         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
760         https://trac.webkit.org/changeset/228308.
761
762         * WebView/WebVideoFullscreenController.h:
763         * WebView/WebVideoFullscreenHUDWindowController.mm:
764         * WebView/WebWindowAnimation.h:
765         * WebView/WebWindowAnimation.mm:
766         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
767         (WebCore::scaledRect): Deleted.
768         (WebCore::squaredDistance): Deleted.
769
770 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
771
772         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
773
774         * WebView/WebWindowAnimation.mm:
775         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
776
777 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
778
779         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
780         https://bugs.webkit.org/show_bug.cgi?id=182615
781
782         Reviewed by Eric Carlson.
783
784         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
785         Ideally, we should not reference NSApp in WebCore.
786
787         * WebView/WebFullScreenController.mm:
788         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
789         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
790         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
791         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
792         * WebView/WebView.mm:
793         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
794         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
795
796 2018-01-13  Darin Adler  <darin@apple.com>
797
798         Event improvements
799         https://bugs.webkit.org/show_bug.cgi?id=179591
800
801         Reviewed by Chris Dumez.
802
803         * DOM/DOMWheelEvent.mm:
804         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
805         Call initWebKitWheelEvent.
806
807         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
808         * WebCoreSupport/WebInspectorClient.mm: Ditto.
809         * WebView/WebFrame.mm: Ditto.
810
811         * WebView/WebHTMLView.mm:
812         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
813         underlyingPlatformEvent.
814         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
815
816         * WebView/WebScriptWorld.mm:
817         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
818
819         * WebView/WebView.mm: Removed include of ScriptValue.h.
820
821 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
822
823         Remove WebCore/ForwardingHeaders directory
824         https://bugs.webkit.org/show_bug.cgi?id=182347
825
826         Reviewed by Keith Miller.
827
828         * Carbon/CarbonWindowAdapter.mm:
829         * DOM/WebDOMOperations.mm:
830         * History/WebBackForwardList.mm:
831         * History/WebHistoryItem.mm:
832         * Misc/WebCache.mm:
833         * Misc/WebElementDictionary.mm:
834         * Misc/WebIconDatabase.mm:
835         * Misc/WebStringTruncator.mm:
836         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
837         * Plugins/Hosted/ProxyInstance.mm:
838         * Plugins/Hosted/ProxyRuntimeObject.mm:
839         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
840         * Plugins/WebBaseNetscapePluginView.mm:
841         * Plugins/WebBasePluginPackage.mm:
842         * Plugins/WebNetscapePluginStream.mm:
843         * Plugins/WebNetscapePluginView.mm:
844         * Plugins/WebPluginController.mm:
845         * WebCoreSupport/WebEditorClient.mm:
846         * WebCoreSupport/WebFrameLoaderClient.mm:
847         * WebCoreSupport/WebInspectorClient.h:
848         * WebCoreSupport/WebInspectorClient.mm:
849         * WebView/WebDataSource.mm:
850         * WebView/WebFrame.mm:
851         * WebView/WebHTMLRepresentation.mm:
852         * WebView/WebHTMLView.mm:
853         * WebView/WebPreferences.mm:
854         * WebView/WebScriptDebugDelegate.mm:
855         * WebView/WebScriptDebugger.h:
856         * WebView/WebTextIterator.mm:
857         * WebView/WebView.mm:
858         * WebView/WebViewData.mm:
859
860 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
861
862         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
863         https://bugs.webkit.org/show_bug.cgi?id=182312
864
865         Reviewed by Michael Catanzaro.
866
867         * WebKitPrefix.h:
868
869 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
870
871         [WebAuthN] Add a compile-time feature flag
872         https://bugs.webkit.org/show_bug.cgi?id=182211
873         <rdar://problem/36936365>
874
875         Reviewed by Brent Fulgham.
876
877         * Configurations/FeatureDefines.xcconfig:
878
879 2018-01-27  Dan Bernstein  <mitz@apple.com>
880
881         HaveInternalSDK includes should be "#include?"
882         https://bugs.webkit.org/show_bug.cgi?id=179670
883
884         * Configurations/Base.xcconfig:
885
886 2018-01-24  Alex Christensen  <achristensen@webkit.org>
887
888         Remove unused QTKit preference
889         https://bugs.webkit.org/show_bug.cgi?id=181968
890
891         Reviewed by Alexey Proskuryakov.
892
893         * WebView/WebPreferenceKeysPrivate.h:
894         * WebView/WebPreferences.mm:
895         (+[WebPreferences initialize]):
896         (-[WebPreferences setQTKitEnabled:]): Deleted.
897         (-[WebPreferences isQTKitEnabled]): Deleted.
898         * WebView/WebPreferencesPrivate.h:
899         * WebView/WebView.mm:
900         (-[WebView _preferencesChanged:]):
901
902 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
903
904         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
905         https://bugs.webkit.org/show_bug.cgi?id=182037
906         <rdar://problem/36747812>
907
908         Reviewed by Ryosuke Niwa.
909
910         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
911         for more details.
912
913         * WebView/WebHTMLRepresentation.mm:
914         (-[WebHTMLRepresentation elementWithName:inForm:]):
915         (-[WebHTMLRepresentation controlsInForm:]):
916
917 2018-01-23  Alex Christensen  <achristensen@webkit.org>
918
919         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
920         https://bugs.webkit.org/show_bug.cgi?id=181961
921
922         Reviewed by Michael Catanzaro.
923
924         * WebView/WebPreferences.mm:
925
926 2018-01-23  Commit Queue  <commit-queue@webkit.org>
927
928         Unreviewed, rolling out r227437.
929         https://bugs.webkit.org/show_bug.cgi?id=182011
930
931         broke build (Requested by alexchristensen on #webkit).
932
933         Reverted changeset:
934
935         "Remove unused QTKit preference"
936         https://bugs.webkit.org/show_bug.cgi?id=181968
937         https://trac.webkit.org/changeset/227437
938
939 2018-01-23  Alex Christensen  <achristensen@webkit.org>
940
941         Remove unused QTKit preference
942         https://bugs.webkit.org/show_bug.cgi?id=181968
943
944         Reviewed by Alexey Proskuryakov.
945
946         * WebView/WebPreferenceKeysPrivate.h:
947         * WebView/WebPreferences.mm:
948         (+[WebPreferences initialize]):
949         (-[WebPreferences setQTKitEnabled:]): Deleted.
950         (-[WebPreferences isQTKitEnabled]): Deleted.
951         * WebView/WebPreferencesPrivate.h:
952         * WebView/WebView.mm:
953         (-[WebView _preferencesChanged:]):
954
955 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
956
957         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
958         https://bugs.webkit.org/show_bug.cgi?id=181960
959         <rdar://problem/36431678>
960
961         Reviewed by Tim Horton.
962
963         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
964         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
965         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
966
967         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
968         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
969         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
970
971         * WebView/WebView.mm:
972         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
973
974 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
975
976         Turning off custom pasteboard data doesn't actually turn it off in WK2
977         https://bugs.webkit.org/show_bug.cgi?id=181920
978         <rdar://problem/36686429>
979
980         Reviewed by Wenson Hsieh.
981
982         Always disable custom pasteboard data in WebKit1. See r226156 for details.
983
984         * WebView/WebPreferences.mm:
985         (+[WebPreferences initialize]):
986         * WebView/WebView.mm:
987         (-[WebView _preferencesChanged:]):
988
989 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
990
991         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
992         https://bugs.webkit.org/show_bug.cgi?id=181918
993
994         Reviewed by Tim Horton.
995
996         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
997
998         * Configurations/FeatureDefines.xcconfig:
999
1000 2018-01-20  Andy Estes  <aestes@apple.com>
1001
1002         [Apple Pay] Stop eagerly loading PassKit.framework
1003         https://bugs.webkit.org/show_bug.cgi?id=181911
1004         <rdar://problem/36555369>
1005
1006         Reviewed by Tim Horton.
1007
1008         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1009         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1010         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
1011
1012         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
1013
1014 2018-01-19  Dean Jackson  <dino@apple.com>
1015
1016         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
1017         https://bugs.webkit.org/show_bug.cgi?id=181817
1018         <rdar://problem/35274055>
1019
1020         Reviewed by Simon Fraser.
1021
1022         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
1023
1024         * Misc/WebKitVersionChecks.h:
1025         * WebView/WebView.mm:
1026         (-[WebView _commonInitializationWithFrameName:groupName:]):
1027
1028 2018-01-19  Alex Christensen  <achristensen@webkit.org>
1029
1030         Remove unused WebViewPrivate _allowCookies
1031         https://bugs.webkit.org/show_bug.cgi?id=181812
1032
1033         Reviewed by Tim Horton.
1034
1035         * WebView/WebView.mm:
1036         (+[WebView _setAllowCookies:]): Deleted.
1037         (+[WebView _allowCookies]): Deleted.
1038         * WebView/WebViewPrivate.h:
1039
1040 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
1041
1042         Build fix, remove a call to -[NSWindow setOneShot:]
1043         https://bugs.webkit.org/show_bug.cgi?id=181809
1044
1045         Reviewed by Tim Horton.
1046
1047         * WebView/WebTextCompletionController.mm:
1048         (-[WebTextCompletionController _buildUI]):
1049
1050 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1051
1052         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
1053
1054         * Carbon/HIWebView.mm:
1055         (overrideCGContext):
1056         (restoreCGContext):
1057
1058 2018-01-18  Dan Bernstein  <mitz@apple.com>
1059
1060         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
1061         https://bugs.webkit.org/show_bug.cgi?id=181803
1062
1063         Reviewed by Tim Horton.
1064
1065         * Configurations/Base.xcconfig: Updated.
1066         * Configurations/DebugRelease.xcconfig: Ditto.
1067         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
1068         * Configurations/Version.xcconfig: Updated.
1069         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
1070           useful for defining settings that depend on the target macOS version.
1071
1072 2018-01-17  Youenn Fablet  <youenn@apple.com>
1073
1074         Put fetch Request.keepalive behind a runtime flag
1075         https://bugs.webkit.org/show_bug.cgi?id=181592
1076
1077         Reviewed by Chris Dumez.
1078
1079         * WebView/WebPreferenceKeysPrivate.h:
1080         * WebView/WebPreferences.mm:
1081         (+[WebPreferences initialize]):
1082         (-[WebPreferences fetchAPIKeepAliveEnabled]):
1083         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
1084         * WebView/WebPreferencesPrivate.h:
1085         * WebView/WebView.mm:
1086         (-[WebView _preferencesChanged:]):
1087
1088 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1089
1090         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
1091         https://bugs.webkit.org/show_bug.cgi?id=181637
1092         <rdar://problem/36508471>
1093
1094         Reviewed by Tim Horton.
1095
1096         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
1097
1098         * WebCoreSupport/WebEditorClient.h:
1099         * WebCoreSupport/WebEditorClient.mm:
1100         (WebEditorClient::replacementURLForResource):
1101
1102 2018-01-11  Keith Miller  <keith_miller@apple.com>
1103
1104         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
1105         https://bugs.webkit.org/show_bug.cgi?id=181573
1106
1107         Reviewed by Simon Fraser.
1108
1109         * Configurations/FeatureDefines.xcconfig:
1110
1111 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1112
1113         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
1114         https://bugs.webkit.org/show_bug.cgi?id=181497
1115
1116         Reviewed by Tim Horton.
1117
1118         See other ChangeLogs for more detail.
1119
1120         * WebCoreSupport/WebDragClient.h:
1121
1122 2018-01-11  Tim Horton  <timothy_horton@apple.com>
1123
1124         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
1125         https://bugs.webkit.org/show_bug.cgi?id=181523
1126         <rdar://problem/28959131>
1127
1128         Reviewed by Alex Christensen.
1129
1130         * WebView/WebImmediateActionController.mm:
1131         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
1132         Apply the change made in r216652 to WebKit1's immediate action controller.
1133
1134         Speculative (but successful in WebKit2) fix for non-reproducible crash when
1135         the startContainer of the range is in an anonymous node.
1136
1137 2018-01-11  Youenn Fablet  <youenn@apple.com>
1138
1139         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
1140         https://bugs.webkit.org/show_bug.cgi?id=181480
1141
1142         Reviewed by Eric Carlson.
1143
1144         * WebView/WebPreferences.mm:
1145         (+[WebPreferences initialize]):
1146
1147 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1148
1149         Fix check-webkit-style issues with WebNSDataExtras.mm
1150         <https://webkit.org/b/181369>
1151
1152         Reviewed by Alex Christensen.
1153
1154         * Misc/WebNSDataExtras.mm:
1155         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1156         (-[NSData _webkit_guessedMIMETypeForXML]):
1157         (-[NSData _webkit_guessedMIMEType]):
1158         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1159         (_findEOL):
1160         (-[NSData _webkit_parseRFC822HeaderFields]):
1161         (-[NSData _web_locationAfterFirstBlankLine]):
1162         - Fix all the check-webkit-style warnings.
1163
1164 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1165
1166         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1167         <https://webkit.org/b/181256>
1168         <rdar://problem/36281730>
1169
1170         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1171         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
1172         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
1173           to avoid warnings from casting CFStringRef to NPNSString*.
1174           Note that CFMutableStringRef is the same as CFStringRef
1175           without the const modifier, hence its use in the const_cast<>
1176           above.
1177
1178 2018-01-08  David Kilzer  <ddkilzer@apple.com>
1179
1180         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1181         <https://webkit.org/b/181256>
1182         <rdar://problem/36281730>
1183
1184         * Carbon/HIWebView.mm:
1185         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
1186         checked_cf_cast<CFRunLoopRef>() to fix warning.
1187
1188 2018-01-07  David Kilzer  <ddkilzer@apple.com>
1189
1190         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
1191         <https://webkit.org/b/181256>
1192         <rdar://problem/36281730>
1193
1194         Reviewed by Darin Adler.
1195
1196         * Carbon/CarbonUtils.m:
1197         (PoolCleaner):
1198         - Use #pragmas to ignore -Wcast-qual warnings when using a
1199           C-style cast from CFTypeRef to CFRunloopRef.
1200         * Carbon/CarbonWindowFrame.m:
1201         (-[CarbonWindowFrame title]):
1202         - Use #pragmas to ignore -Wcast-qual warnings when using a
1203           C-style cast from CFStringRef to NSString *.
1204         * Carbon/HIViewAdapter.m:
1205         (+[HIViewAdapter getHIViewForNSView:]):
1206         - Use #pragmas to ignore -Wcast-qual warnings when using a
1207           C-style cast from CFTypeRef to HIViewRef.
1208         * Configurations/Base.xcconfig:
1209         (WARNING_CFLAGS): Add -Wcast-qual.
1210         * Misc/WebElementDictionary.mm:
1211         (-[WebElementDictionary objectForKey:]):
1212         - Use static_cast<SEL>(const_cast<void*>()) to fix
1213           warning.
1214         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1215         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1216         (-[NSData _webkit_guessedMIMETypeForXML]):
1217         (-[NSData _webkit_guessedMIMEType]):
1218         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1219         (_findEOL):
1220         (-[NSData _webkit_parseRFC822HeaderFields]):
1221         (-[NSData _web_startsWithBlankLine]):
1222         (-[NSData _web_locationAfterFirstBlankLine]):
1223         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1224           type to Objective-C++.  This fixes the warnings about
1225           discarding the `const` modifier when casing from CFStringRef
1226           to NSString * because in older clang versions, -Wcast-qual was
1227           completely broken when compiling C++ and Objective-C++ source
1228           files.  In newer clang versions, discarding the `const`
1229           modifier for toll-free bridged types is ignored when compiling
1230           Objective-C++ source.
1231         - Update copyright and license header.
1232         - Use reinterpret_cast<> and static_cast<> to fix warnings
1233           unrelated to (NSString *) C-style casts.
1234         - Replace use of MIN() macro with std::min<> template functions.
1235         - Fix location of `*` for local variables modified above.
1236         * Plugins/Hosted/NetscapePluginHostManager.mm:
1237         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1238         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1239         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1240         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1241           warnings.
1242         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1243         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1244         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1245           to fix warning.
1246         * Plugins/Hosted/ProxyInstance.mm:
1247         (WebKit::ProxyInstance::invoke):
1248         - Use static_cast<char*>(const_cast<void*>()) to fix
1249           warning when using -[NSData bytes].
1250         (WebKit::ProxyInstance::fieldValue const):
1251         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1252           to fix warning when using CFDataGetBytePtr().
1253         * Plugins/Hosted/WebTextInputWindowController.m:
1254         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1255         - Use #pragma to ignore -Wcast-qual warning since there
1256           is not a good way to avoid this warning in Objective-C.
1257         * Plugins/WebNetscapePluginStream.mm:
1258         (WebNetscapePluginStream::deliverData):
1259         - Use const_cast<void*>() to fix warning when using
1260           -[NSData bytes].
1261         * Plugins/WebNetscapePluginView.mm:
1262         (-[WebNetscapePluginView _createPlugin]):
1263         - Change C-style cast to const_cast<char*>() to fix
1264           warning.
1265         * WebCoreSupport/WebChromeClient.mm:
1266         (WebChromeClient::wrapCryptoKey const):
1267         (WebChromeClient::unwrapCryptoKey const):
1268         - Change C-style cast to
1269           static_cast<uint8_t*>(const_cast<void*>() to fix
1270           warning.
1271         * WebView/WebPDFView.mm:
1272         (_applicationInfoForMIMEType):
1273         - Change local variable type from 'NSURL *' to
1274           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1275           when calling -[NSURL path].
1276
1277 2018-01-05  Dan Bernstein  <mitz@apple.com>
1278
1279         Fixed the build following AppKit API deprecations in a recent SDKs
1280
1281         * WebView/WebFullScreenController.mm:
1282         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1283         (-[WebFullScreenController exitFullScreen]): Ditto.
1284         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1285         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1286         * WebView/WebHTMLView.mm:
1287         (-[WebHTMLView drawRect:]): Ditto.
1288         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1289         (-[WebHTMLView knowsPageRange:]): Ditto.
1290         * WebView/WebView.mm:
1291         (LayerFlushController::flushLayers): Ditto.
1292
1293 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1294
1295         [Attachment Support] Create attachment elements when dropping files on iOS
1296         https://bugs.webkit.org/show_bug.cgi?id=181192
1297         <rdar://problem/36280945>
1298
1299         Reviewed by Tim Horton.
1300
1301         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1302
1303         * WebCoreSupport/WebPlatformStrategies.h:
1304         * WebCoreSupport/WebPlatformStrategies.mm:
1305         (WebPlatformStrategies::informationForItemAtIndex):
1306         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1307
1308 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1309
1310         [Attachment Support] Add plumbing for starting a drag with promised blob data
1311         https://bugs.webkit.org/show_bug.cgi?id=181201
1312
1313         Reviewed by Tim Horton.
1314
1315         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1316
1317         * WebCoreSupport/WebDragClient.h:
1318
1319 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1320
1321         Add a WebAuthentication runtime feature flag
1322         https://bugs.webkit.org/show_bug.cgi?id=181220
1323         <rdar://problem/36055305>
1324
1325         Reviewed by Brent Fulgham.
1326
1327         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1328
1329         * WebView/WebPreferenceKeysPrivate.h:
1330         * WebView/WebPreferences.mm:
1331         (+[WebPreferences initialize]):
1332         (-[WebPreferences webAuthenticationEnabled]):
1333         (-[WebPreferences setWebAuthenticationEnabled:]):
1334         (-[WebPreferences credentialManagementEnabled]): Deleted.
1335         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1336         * WebView/WebPreferencesPrivate.h:
1337         * WebView/WebView.mm:
1338         (-[WebView _preferencesChanged:]):
1339
1340 2017-12-22  Jeff Miller  <jeffm@apple.com>
1341
1342         Update user-visible copyright strings to include 2018
1343         https://bugs.webkit.org/show_bug.cgi?id=181141
1344
1345         Reviewed by Dan Bernstein.
1346
1347         * Info.plist:
1348
1349 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1350
1351         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1352         https://bugs.webkit.org/show_bug.cgi?id=181188
1353
1354         Reviewed by Dan Bernstein.
1355
1356         See WebCore/ChangeLog for more detail.
1357
1358         * WebCoreSupport/WebDragClient.h:
1359         * WebCoreSupport/WebDragClient.mm:
1360         (WebDragClient::declareAndWriteAttachment): Deleted.
1361         * WebView/WebHTMLView.mm:
1362         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1363
1364 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1365
1366         Unreviewed, continue to fix build failures due to AppKit API deprecation
1367
1368         Wraps more code in -Wdeprecated-declarations.
1369
1370         * Carbon/HIWebView.mm:
1371         (overrideCGContext):
1372
1373 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1374
1375         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1376
1377         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1378
1379         * Carbon/CarbonWindowAdapter.mm:
1380         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1381         * Plugins/WebNetscapePluginView.mm:
1382         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1383         (-[WebNetscapePluginView sendDrawRectEvent:]):
1384         (-[WebNetscapePluginView drawRect:]):
1385
1386 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1387
1388         Fix build failures due to using deprecated AppKit symbols
1389         https://bugs.webkit.org/show_bug.cgi?id=181110
1390         <rdar://problem/36162865>
1391
1392         Reviewed by Dan Bernstein and Tim Horton.
1393
1394         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1395
1396         * Misc/WebKitNSStringExtras.mm:
1397         (-[NSString _web_drawAtPoint:font:textColor:]):
1398         * Misc/WebNSPasteboardExtras.h:
1399         * Misc/WebNSPasteboardExtras.mm:
1400         (+[NSPasteboard _web_writableTypesForURL]):
1401         (_createWritableTypesForImageWithoutArchive):
1402         (_createWritableTypesForImageWithArchive):
1403         (+[NSPasteboard _web_dragTypesForURL]):
1404         (-[NSPasteboard _web_bestURL]):
1405         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1406         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1407         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1408         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1409         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1410         * Panels/WebAuthenticationPanel.m:
1411         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1412         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1413         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1414         (-[WebHostedNetscapePluginView drawRect:]):
1415         * WebInspector/WebNodeHighlightView.mm:
1416         (-[WebNodeHighlightView drawRect:]):
1417         * WebView/WebFrame.mm:
1418         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1419         (-[WebFrame _drawRect:contentsOnly:]):
1420         * WebView/WebHTMLView.mm:
1421         (kit):
1422         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1423         (-[WebHTMLView _plainTextFromPasteboard:]):
1424         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1425         (+[WebHTMLView _insertablePasteboardTypes]):
1426         (+[WebHTMLView _selectionPasteboardTypes]):
1427         (-[WebHTMLView pasteboard:provideDataForType:]):
1428         (-[WebHTMLView _writeSelectionToPasteboard:]):
1429         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1430         (-[WebHTMLView validRequestorForSendType:returnType:]):
1431         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1432         (createMenuItem):
1433         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1434         (-[WebHTMLView _colorAsString:]):
1435         (-[WebHTMLView copyFont:]):
1436         * WebView/WebPDFView.mm:
1437         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1438         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1439         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1440         (-[WebPDFView pasteboardTypesForSelection]):
1441         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1442         * WebView/WebView.h:
1443         * WebView/WebView.mm:
1444         (-[WebView performDragOperation:]):
1445         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1446         (-[WebView _searchWithGoogleFromMenu:]):
1447
1448 2017-12-21  Youenn Fablet  <youenn@apple.com>
1449
1450         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1451         https://bugs.webkit.org/show_bug.cgi?id=181000
1452
1453         Reviewed by Chris Dumez.
1454
1455         * Misc/WebCache.mm:
1456         (+[WebCache addImageToCache:forURL:forFrame:]):
1457
1458 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1459
1460         Update FULLSCREEN_API feature defines.
1461         https://bugs.webkit.org/show_bug.cgi?id=181015
1462
1463         Reviewed by Tim Horton.
1464
1465         Change enabled iphone sdk for FULLSCREEN_API.
1466
1467         * Configurations/FeatureDefines.xcconfig:
1468
1469 2017-12-21  Jer Noble  <jer.noble@apple.com>
1470
1471         Add initial DOM support for Media Capabilities
1472         https://bugs.webkit.org/show_bug.cgi?id=181064
1473
1474         Reviewed by Eric Carlson.
1475
1476         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1477
1478         * WebView/WebPreferenceKeysPrivate.h:
1479         * WebView/WebPreferences.mm:
1480         (+[WebPreferences initialize]):
1481         (-[WebPreferences mediaCapabilitiesEnabled]):
1482         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1483         * WebView/WebPreferencesPrivate.h:
1484         * WebView/WebView.mm:
1485         (-[WebView _preferencesChanged:]):
1486
1487 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1488
1489         Enable picture-in-picture from inline element on suspend.
1490         https://bugs.webkit.org/show_bug.cgi?id=180942
1491         rdar://problem/34745234
1492
1493         Reviewed by Jer Noble.
1494
1495         Update signature of enterVideoFullscreenForVideoElement().
1496
1497         * WebCoreSupport/WebChromeClient.h:
1498         * WebCoreSupport/WebChromeClient.mm:
1499         (WebChromeClient::enterVideoFullscreenForVideoElement):
1500
1501 2017-12-20  Daniel Bates  <dabates@apple.com>
1502
1503         Remove Alternative Presentation Button
1504         https://bugs.webkit.org/show_bug.cgi?id=180500
1505         <rdar://problem/35891047>
1506
1507         Reviewed by Simon Fraser.
1508
1509         We no longer need the alternative presentation button.
1510
1511         * Configurations/FeatureDefines.xcconfig:
1512
1513 2017-12-19  Jer Noble  <jer.noble@apple.com>
1514
1515         Playing media elements which call "pause(); play()" will have the play promise rejected.
1516         https://bugs.webkit.org/show_bug.cgi?id=180781
1517         <rdar://problem/33191377>
1518
1519         Reviewed by Eric Carlson.
1520
1521         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1522
1523         * WebView/WebView.mm:
1524         (shouldRequireUserGestureToLoadVideo):
1525
1526 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1527
1528         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1529         https://bugs.webkit.org/show_bug.cgi?id=180977
1530
1531         Reviewed by Tim Horton.
1532
1533         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1534         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1535         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1536
1537         * WebCoreSupport/WebEditorClient.mm:
1538         (attributesForAttributedStringConversion):
1539         * WebView/WebHTMLView.mm:
1540         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1541
1542 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1543
1544         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1545
1546         Attempt to fix the following warnings:
1547
1548             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1549
1550         For the following instance variables:
1551
1552             _borderView
1553             _contentView
1554             _frame
1555             _wFlags
1556
1557         * Carbon/CarbonWindowAdapter.mm:
1558         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1559         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1560         (-[CarbonWindowAdapter _termWindowIfOwner]):
1561         (-[CarbonWindowAdapter _windowMovedToRect:]):
1562         (-[CarbonWindowAdapter setContentView:]):
1563         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1564         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1565
1566 2017-12-16  Dan Bernstein  <mitz@apple.com>
1567
1568         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1569         https://bugs.webkit.org/show_bug.cgi?id=180613
1570         <rdar://problem/35946124>
1571
1572         Reviewed by Geoff Garen.
1573
1574         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1575           clients.
1576         * WebView/WebDynamicScrollBarsView.h: Ditto.
1577         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1578
1579 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1580
1581         Enable -Wstrict-prototypes for WebKit
1582         <https://webkit.org/b/180757>
1583         <rdar://problem/36024132>
1584
1585         Rubber-stamped by Joseph Pecoraro.
1586
1587         * Configurations/Base.xcconfig:
1588         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1589
1590 2017-12-14  John Wilander  <wilander@apple.com>
1591
1592         Storage Access API: Implement frame-specific access in the document.cookie layer
1593         https://bugs.webkit.org/show_bug.cgi?id=180682
1594         <rdar://problem/35982257>
1595
1596         Reviewed by Alex Christensen.
1597
1598         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1599         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1600         CookiesStrategy::getRawCookies() now take optional parameters for
1601         frameID and pageID to allow frame-specific scoping of cookies.
1602
1603         This change makes the return values of FrameLoaderClient::frameID()
1604         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1605         WebCore can call those getters and get the right return values in
1606         WebKit and std:nullopt in WebKitLegacy.
1607
1608         * WebCoreSupport/WebFrameLoaderClient.h:
1609         * WebCoreSupport/WebFrameLoaderClient.mm:
1610         (WebFrameLoaderClient::pageID const):
1611         (WebFrameLoaderClient::frameID const):
1612         * WebCoreSupport/WebPlatformStrategies.h:
1613         * WebCoreSupport/WebPlatformStrategies.mm:
1614         (WebPlatformStrategies::cookiesForDOM):
1615         (WebPlatformStrategies::setCookiesFromDOM):
1616         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1617         (WebPlatformStrategies::getRawCookies):
1618
1619 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1620
1621         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1622         https://bugs.webkit.org/show_bug.cgi?id=180689
1623
1624         Reviewed by Tim Horton.
1625
1626         Use sRGBColorSpaceRef() from WebCore.
1627
1628         * WebView/WebHTMLView.mm:
1629         (imageFromRect):
1630
1631 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1632
1633         Stop using deprecated target conditional for simulator builds
1634         https://bugs.webkit.org/show_bug.cgi?id=180662
1635         <rdar://problem/35136156>
1636
1637         Reviewed by Simon Fraser.
1638
1639         * postprocess-headers.sh:
1640
1641 2017-12-11  David Quesada  <david_quesada@apple.com>
1642
1643         Turn on ENABLE_APPLICATION_MANIFEST
1644         https://bugs.webkit.org/show_bug.cgi?id=180562
1645         rdar://problem/35924737
1646
1647         Reviewed by Geoffrey Garen.
1648
1649         * Configurations/FeatureDefines.xcconfig:
1650
1651 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1652
1653         Remove pthread_once in favor of dispatch_once
1654         https://bugs.webkit.org/show_bug.cgi?id=180591
1655
1656         Reviewed by Saam Barati.
1657
1658         * Misc/WebKitErrors.m:
1659         (+[NSError _registerWebKitErrors]):
1660         (registerErrors): Deleted.
1661         * Storage/WebStorageManager.mm:
1662         (+[WebStorageManager _storageDirectoryPath]):
1663         (initializeLocalStoragePath): Deleted.
1664
1665 2017-12-07  Darin Adler  <darin@apple.com>
1666
1667         Remove some unused code from WebKitLegacy
1668         https://bugs.webkit.org/show_bug.cgi?id=180567
1669
1670         Reviewed by Anders Carlsson.
1671
1672         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1673         macOS (back a few versions) and iOS and removed unused
1674         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1675         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1676         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1677         _webkit_stringByCollapsingNonPrintingCharacters,
1678         _webkit_stringByCollapsingWhitespaceCharacters,
1679         _web_stringWithData:textEncodingName:, and
1680         _webkit_localStorageDirectoryWithBundleIdentifier:.
1681
1682         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1683         this source file.
1684         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1685         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1686         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1687         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1688         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1689         handle font smoothing options.
1690         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1691         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1692         from header and made it a little clearer.
1693         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1694         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1695         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1696         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1697         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1698         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1699         implementation a bit and used whole words instead of abbreviations.
1700         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1701
1702         * Misc/WebNSFileManagerExtras.mm:
1703         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1704         filenameByFixingIllegalCharacters function from WebCore directly instead of
1705         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1706
1707         * Plugins/WebBaseNetscapePluginView.mm:
1708         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1709         string replacements instead of _web_stringByStrippingReturnCharacters
1710         and to use NSString methods instead of CFString functions.
1711
1712 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1713
1714         Ignore deprecation warnings.
1715
1716         * WebView/WebHTMLView.mm:
1717         (-[NSWindow _web_borderView]):
1718         (-[WebHTMLView _setAsideSubviews]):
1719         * WebView/WebView.mm:
1720         (-[WebView encodeWithCoder:]):
1721
1722 2017-12-02  Darin Adler  <darin@apple.com>
1723
1724         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1725         https://bugs.webkit.org/show_bug.cgi?id=180009
1726
1727         Reviewed by Alex Christensen.
1728
1729         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1730
1731         * Plugins/WebBaseNetscapePluginView.mm:
1732         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1733         of strcasecmp.
1734
1735         * WebView/WebPreferences.mm:
1736         (contains): Ditto. Also made this a template so it's easier to call on an array.
1737         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1738
1739 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1740
1741         Limit user agent versioning to an upper bound
1742         https://bugs.webkit.org/show_bug.cgi?id=180365
1743         <rdar://problem/34550617>
1744
1745         Reviewed by Joseph Pecoraro.
1746
1747         * WebView/WebView.mm:
1748         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1749         creating the User Agent string.
1750         (webKitBundleVersionString): Deleted.
1751
1752 2017-12-05  Andy Estes  <aestes@apple.com>
1753
1754         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1755         https://bugs.webkit.org/show_bug.cgi?id=180457
1756         <rdar://problem/35143007>
1757
1758         Reviewed by Tim Horton.
1759
1760         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1761         check for this macro during post-processing.
1762
1763         * postprocess-headers.sh:
1764
1765 2017-12-04  David Quesada  <david_quesada@apple.com>
1766
1767         Add a class for parsing application manifests
1768         https://bugs.webkit.org/show_bug.cgi?id=177973
1769         rdar://problem/34747949
1770
1771         Reviewed by Geoffrey Garen.
1772
1773         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1774
1775 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1776
1777         Make LegacyCustomProtocolManager optional for network process
1778         https://bugs.webkit.org/show_bug.cgi?id=176230
1779
1780         Reviewed by Alex Christensen.
1781
1782         * Configurations/FeatureDefines.xcconfig:
1783
1784 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1785
1786         Fix some NSOperationQueue leaks
1787         https://bugs.webkit.org/show_bug.cgi?id=180221
1788
1789         Reviewed by Wenson Hsieh.
1790
1791         * WebView/WebView.mm:
1792         (-[WebView performDragOperation:]):
1793
1794 2017-11-30  Darin Adler  <darin@apple.com>
1795
1796         [Mac] remove unneeded RetainPtr use introduced in r225142
1797         https://bugs.webkit.org/show_bug.cgi?id=180202
1798
1799         Reviewed by Tim Horton.
1800
1801         * WebView/WebImmediateActionController.mm:
1802         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1803         RetainPtr.
1804
1805 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1806
1807         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1808         https://bugs.webkit.org/show_bug.cgi?id=175595
1809
1810         Reviewed by Darin Adler.
1811
1812         * WebView/WebPreferences.mm:
1813
1814 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1815
1816         One too many zeroes in macOS version number in FeatureDefines
1817         https://bugs.webkit.org/show_bug.cgi?id=180011
1818
1819         Reviewed by Dan Bernstein.
1820
1821         * Configurations/FeatureDefines.xcconfig:
1822
1823 2017-11-23  Darin Adler  <darin@apple.com>
1824
1825         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1826         https://bugs.webkit.org/show_bug.cgi?id=179981
1827
1828         Reviewed by Sam Weinig.
1829
1830         * WebView/WebImmediateActionController.mm:
1831         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1832         * WebView/WebView.mm:
1833         (coreOptions): Use |= instead of | to build up FindOptions.
1834
1835 2017-11-23  Sam Weinig  <sam@webkit.org>
1836
1837         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1838         https://bugs.webkit.org/show_bug.cgi?id=179954
1839
1840         Reviewed by Darin Adler.
1841
1842         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1843         with direct calls to the corresponding UserGestureIndicator functions.
1844
1845         * Plugins/WebPluginController.mm:
1846         (-[WebPluginController processingUserGesture]):
1847         * WebView/WebView.mm:
1848         (-[WebView _isProcessingUserGesture]):
1849
1850 2017-11-23  Darin Adler  <darin@apple.com>
1851
1852         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1853         https://bugs.webkit.org/show_bug.cgi?id=179907
1854
1855         Reviewed by Sam Weinig.
1856
1857         * History/BinaryPropertyList.cpp:
1858         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1859         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1860         * WebView/WebHTMLRepresentation.mm:
1861         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1862         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1863
1864 2017-11-22  Ali Juma  <ajuma@chromium.org>
1865
1866         Implement VisualViewport API attributes
1867         https://bugs.webkit.org/show_bug.cgi?id=179385
1868
1869         Reviewed by Frédéric Wang.
1870
1871         Add a VisualViewportAPI preference.
1872
1873         * WebView/WebPreferenceKeysPrivate.h:
1874         * WebView/WebPreferences.mm:
1875         (+[WebPreferences initialize]):
1876         (-[WebPreferences visualViewportAPIEnabled]):
1877         (-[WebPreferences setVisualViewportAPIEnabled:]):
1878         * WebView/WebPreferencesPrivate.h:
1879         * WebView/WebView.mm:
1880         (-[WebView _preferencesChanged:]):
1881
1882 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1883
1884         WebCoreObjCExtras.h is being included in too many places
1885         https://bugs.webkit.org/show_bug.cgi?id=179931
1886
1887         Reviewed by Darin Adler.
1888
1889         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1890         * Plugins/WebBaseNetscapePluginView.mm:
1891         * Plugins/WebBasePluginPackage.mm:
1892         * Plugins/WebNetscapePluginStream.mm:
1893         * Plugins/WebNetscapePluginView.mm:
1894         * WebView/WebTextIterator.mm:
1895         * WebView/WebViewData.mm:
1896
1897 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1898
1899         Unreviewed, rolling out r225093.
1900         https://bugs.webkit.org/show_bug.cgi?id=179938
1901
1902         Compilation failed on WinCairo 64-bit Release (Requested by
1903         fredw on #webkit).
1904
1905         Reverted changeset:
1906
1907         "Implement VisualViewport API attributes"
1908         https://bugs.webkit.org/show_bug.cgi?id=179385
1909         https://trac.webkit.org/changeset/225093
1910
1911 2017-11-21  Ali Juma  <ajuma@chromium.org>
1912
1913         Implement VisualViewport API attributes
1914         https://bugs.webkit.org/show_bug.cgi?id=179385
1915
1916         Reviewed by Frédéric Wang.
1917
1918         Add a VisualViewportAPI preference.
1919
1920         * WebView/WebPreferenceKeysPrivate.h:
1921         * WebView/WebPreferences.mm:
1922         (+[WebPreferences initialize]):
1923         (-[WebPreferences visualViewportAPIEnabled]):
1924         (-[WebPreferences setVisualViewportAPIEnabled:]):
1925         * WebView/WebPreferencesPrivate.h:
1926         * WebView/WebView.mm:
1927         (-[WebView _preferencesChanged:]):
1928
1929 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1930
1931         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1932         https://bugs.webkit.org/show_bug.cgi?id=179504
1933
1934         Reviewed by Darin Adler.
1935
1936         * Misc/WebKitNSStringExtras.mm:
1937         * Plugins/Hosted/NetscapePluginHostManager.mm:
1938         * Plugins/WebBasePluginPackage.mm:
1939
1940 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1941
1942         Remove unused TOUCH_ICON_LOADING feature flag
1943         https://bugs.webkit.org/show_bug.cgi?id=179873
1944
1945         Reviewed by Simon Fraser.
1946
1947         * Configurations/FeatureDefines.xcconfig:
1948
1949 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1950
1951         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1952         https://bugs.webkit.org/show_bug.cgi?id=179872
1953
1954         Reviewed by Darin Adler.
1955
1956         * Configurations/FeatureDefines.xcconfig:
1957
1958 2017-11-16  Daniel Bates  <dabates@apple.com>
1959
1960         Add feature define for alternative presentation button element
1961         https://bugs.webkit.org/show_bug.cgi?id=179692
1962         Part of <rdar://problem/34917108>
1963
1964         Reviewed by Andy Estes.
1965
1966         Only enabled on Cocoa platforms by default.
1967
1968         * Configurations/FeatureDefines.xcconfig:
1969
1970 2017-11-14  Nan Wang  <n_wang@apple.com>
1971
1972         AX: AOM: Implement AccessibleNode class and support label and role attributes
1973         https://bugs.webkit.org/show_bug.cgi?id=179494
1974
1975         Reviewed by Ryosuke Niwa.
1976
1977         * WebView/WebPreferenceKeysPrivate.h:
1978         * WebView/WebPreferences.mm:
1979         (+[WebPreferences initialize]):
1980         (-[WebPreferences accessibilityObjectModelEnabled]):
1981         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1982         * WebView/WebPreferencesPrivate.h:
1983         * WebView/WebView.mm:
1984         (-[WebView _preferencesChanged:]):
1985
1986 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1987
1988         Remove Cocoa CFURLConnection loading code
1989         https://bugs.webkit.org/show_bug.cgi?id=179688
1990
1991         Reviewed by Antti Koivisto.
1992
1993         * Misc/WebDownload.mm:
1994         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1995         * Misc/WebDownloadInternal.h:
1996         * Plugins/WebBaseNetscapePluginView.mm:
1997         * WebCoreSupport/WebFrameLoaderClient.mm:
1998         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1999         * WebView/WebView.mm:
2000         (-[WebView scheduleInRunLoop:forMode:]):
2001         (-[WebView unscheduleFromRunLoop:forMode:]):
2002
2003 2017-11-14  Daniel Bates  <dabates@apple.com>
2004
2005         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
2006         for feature defines
2007
2008         Following r195498 and r201917 the Visual Studio property files for feature defines have
2009         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
2010         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
2011         files.
2012
2013         * Configurations/FeatureDefines.xcconfig:
2014
2015 2017-11-14  Jer Noble  <jer.noble@apple.com>
2016
2017         Enable Modern EME tests in DumpRenderTree
2018         https://bugs.webkit.org/show_bug.cgi?id=179544
2019
2020         Reviewed by Alex Christensen.
2021
2022         Add a WebPreferences property to enable the (modern) EME API.
2023
2024         * WebView/WebPreferenceKeysPrivate.h:
2025         * WebView/WebPreferences.mm:
2026         (+[WebPreferences initialize]):
2027         (-[WebPreferences encryptedMediaAPIEnabled]):
2028         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
2029         * WebView/WebPreferencesPrivate.h:
2030         * WebView/WebView.mm:
2031         (-[WebView _preferencesChanged:]):
2032
2033 2017-11-14  Antti Koivisto  <antti@apple.com>
2034
2035         Enable display:contents by default
2036         https://bugs.webkit.org/show_bug.cgi?id=179655
2037
2038         Reviewed by Sam Weinig.
2039
2040         * WebView/WebPreferences.mm:
2041         (+[WebPreferences initialize]):
2042
2043 2017-11-13  Alex Christensen  <achristensen@webkit.org>
2044
2045         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
2046         https://bugs.webkit.org/show_bug.cgi?id=178751
2047
2048         Reviewed by Brady Eidson.
2049
2050         * WebCoreSupport/WebFrameNetworkingContext.mm:
2051         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2052
2053 2017-11-08  Keith Miller  <keith_miller@apple.com>
2054
2055         Async iteration should only fetch the next method once and add feature flag
2056         https://bugs.webkit.org/show_bug.cgi?id=179451
2057
2058         Reviewed by Geoffrey Garen.
2059
2060         Add feature flag for Async iteration.
2061
2062         * Configurations/FeatureDefines.xcconfig:
2063
2064 2017-11-13  Mark Lam  <mark.lam@apple.com>
2065
2066         Add more overflow check book-keeping for MarkedArgumentBuffer.
2067         https://bugs.webkit.org/show_bug.cgi?id=179634
2068         <rdar://problem/35492517>
2069
2070         Reviewed by Saam Barati.
2071
2072         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2073         (WebKit::NetscapePluginInstanceProxy::invoke):
2074         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2075         (WebKit::NetscapePluginInstanceProxy::construct):
2076
2077 2017-11-12  Darin Adler  <darin@apple.com>
2078
2079         More is<> and downcast<>, less static_cast<>
2080         https://bugs.webkit.org/show_bug.cgi?id=179600
2081
2082         Reviewed by Chris Dumez.
2083
2084         * DOM/DOM.mm:
2085         (kit): Use is/downcast.
2086         * WebCoreSupport/WebEditorClient.mm:
2087         (WebEditorClient::handleKeyboardEvent): Ditto.
2088         (WebEditorClient::handleInputMethodKeydown): Ditto.
2089         * WebView/WebHTMLView.mm:
2090         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
2091
2092 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
2093
2094         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
2095         https://bugs.webkit.org/show_bug.cgi?id=179397
2096
2097         Reviewed by Wenson Hsieh.
2098
2099         * DOM/DOMHTMLInputElement.mm:
2100         (-[DOMHTMLInputElement insertTextSuggestion:]):
2101
2102 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
2103
2104         HTMLMediaElement should not use element fullscreen on iOS
2105         https://bugs.webkit.org/show_bug.cgi?id=179418
2106         rdar://problem/35409277
2107
2108         Reviewed by Eric Carlson.
2109
2110         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
2111
2112         * Configurations/FeatureDefines.xcconfig:
2113
2114 2017-11-06  Alex Christensen  <achristensen@webkit.org>
2115
2116         Make ResourceLoader::willSendRequestInternal asynchronous
2117         https://bugs.webkit.org/show_bug.cgi?id=179251
2118
2119         Reviewed by Andy Estes.
2120
2121         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2122         (WebKit::HostedNetscapePluginStream::start):
2123         * Plugins/WebNetscapePluginStream.mm:
2124         (WebNetscapePluginStream::start):
2125
2126 2017-11-01  Darin Adler  <darin@apple.com>
2127
2128         Simplify event dispatch code and make it a bit more consistent
2129         https://bugs.webkit.org/show_bug.cgi?id=178991
2130
2131         Reviewed by Chris Dumez.
2132
2133         * DOM/DOMEvent.mm:
2134         (-[DOMEvent srcElement]): Call target instead of srcElement.
2135
2136 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
2137
2138         [Touch Bar Web API] Add support for menuitem tag
2139         https://bugs.webkit.org/show_bug.cgi?id=179020
2140
2141         Reviewed by Ryosuke Niwa.
2142
2143         Adds in properties and methods that allow the menuitem runtime feature
2144         to be enabled or disabled.
2145
2146         * WebView/WebPreferenceKeysPrivate.h:
2147         * WebView/WebPreferences.mm:
2148         (-[WebPreferences menuItemElementEnabled]):
2149         (-[WebPreferences setMenuItemElementEnabled:]):
2150         * WebView/WebPreferencesPrivate.h:
2151         * WebView/WebView.mm:
2152         (-[WebView _preferencesChanged:]):
2153
2154 2017-11-02  Alex Christensen  <achristensen@webkit.org>
2155
2156         Use CompletionHandlers for redirects
2157         https://bugs.webkit.org/show_bug.cgi?id=179163
2158
2159         Reviewed by Tim Horton.
2160
2161         * Plugins/Hosted/HostedNetscapePluginStream.h:
2162         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2163         (WebKit::HostedNetscapePluginStream::willSendRequest):
2164         * Plugins/WebNetscapePluginStream.h:
2165         * Plugins/WebNetscapePluginStream.mm:
2166         (WebNetscapePluginStream::willSendRequest):
2167
2168 2017-11-02  Christopher Reid  <chris.reid@sony.com>
2169
2170         Add a FileSystem namespace to FileSystem.cpp
2171         https://bugs.webkit.org/show_bug.cgi?id=179063
2172
2173         Reviewed by Darin Adler.
2174
2175         * Misc/WebNSFileManagerExtras.mm:
2176         * Storage/WebDatabaseProvider.mm:
2177
2178 2017-11-02  Frederic Wang  <fwang@igalia.com>
2179
2180         Add references to bug 179167 in FIXME comments
2181         https://bugs.webkit.org/show_bug.cgi?id=179168
2182
2183         Reviewed by Daniel Bates.
2184
2185         * Configurations/FeatureDefines.xcconfig:
2186
2187 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
2188
2189         Implement WKFullscreenWindowController for iOS.
2190         https://bugs.webkit.org/show_bug.cgi?id=178924
2191         rdar://problem/34697120
2192
2193         Reviewed by Simon Fraser.
2194
2195         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
2196
2197         * Configurations/FeatureDefines.xcconfig:
2198         * WebView/WebView.mm:
2199         (-[WebView fullScreenPlaceholderView]):
2200
2201 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2202
2203         Clean up some drag and drop feature flags
2204         https://bugs.webkit.org/show_bug.cgi?id=179082
2205
2206         Reviewed by Simon Fraser.
2207
2208         * Configurations/FeatureDefines.xcconfig:
2209
2210 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2211
2212         Make it possible to test rubber-banding in overflow scroll
2213         https://bugs.webkit.org/show_bug.cgi?id=179078
2214
2215         Reviewed by Sam Weinig.
2216
2217         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2218         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2219
2220         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2221         functions, since most callers want clamped.
2222
2223         * DOM/DOMHTML.mm:
2224         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2225
2226 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2227
2228         Fix up some content filtering feature flags
2229         https://bugs.webkit.org/show_bug.cgi?id=179079
2230
2231         Reviewed by Simon Fraser.
2232
2233         * Configurations/FeatureDefines.xcconfig:
2234
2235 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2236
2237         [FrameView::layout cleanup] Move core layout logic to a separate class.
2238         https://bugs.webkit.org/show_bug.cgi?id=178771
2239         <rdar://problem/35166542>
2240
2241         Reviewed by Simon Fraser.
2242
2243         Move layout code out from FrameView to LayoutContext.
2244
2245         * WebView/WebClipView.mm:
2246         (-[WebClipView _immediateScrollToPoint:]):
2247         * WebView/WebFrame.mm:
2248         (-[WebFrame layoutCount]):
2249
2250 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2251
2252         Fix issues with WebView subframe painting
2253         https://bugs.webkit.org/show_bug.cgi?id=178842
2254         rdar://problem/34072253
2255
2256         Reviewed by Daniel Bates.
2257         
2258         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2259         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2260         High Sierra, so match the new signature.
2261
2262         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2263
2264         * WebView/WebHTMLView.mm:
2265         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2266         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2267
2268 2017-10-25  Youenn Fablet  <youenn@apple.com>
2269
2270         Enable ServiceWorker to fetch resources
2271         https://bugs.webkit.org/show_bug.cgi?id=178673
2272
2273         Reviewed by Brady Eidson.
2274
2275         * WebCoreSupport/WebFrameLoaderClient.mm:
2276         (WebFrameLoaderClient::pageID const):
2277         (WebFrameLoaderClient::frameID const):
2278         (WebFrameLoaderClient::sessionID const):
2279
2280         Added implementation to the new getters.
2281         They are noop in the context of WK1.
2282
2283 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2284
2285         Web Inspector: Enable WebKit logging configuration and display
2286         https://bugs.webkit.org/show_bug.cgi?id=177027
2287         <rdar://problem/33964767>
2288
2289         Reviewed by Joseph Pecoraro.
2290
2291         * WebCoreSupport/WebChromeClient.mm:
2292         (stringForMessageSource): Deal with Media and WebRTC message sources.
2293
2294 2017-10-20  Antoine Quint  <graouts@apple.com>
2295
2296         [Web Animations] Provide basic timeline and animation interfaces
2297         https://bugs.webkit.org/show_bug.cgi?id=178526
2298
2299         Reviewed by Dean Jackson.
2300
2301         Remove the WEB_ANIMATIONS compile-time flag.
2302
2303         * Configurations/FeatureDefines.xcconfig:
2304         * WebView/WebPreferences.mm:
2305         (+[WebPreferences initialize]):
2306         * WebView/WebView.mm:
2307         (-[WebView _preferencesChanged:]):
2308
2309 2017-10-19  Sam Weinig  <sam@webkit.org>
2310
2311         [Settings] Move global settings into their own file
2312         https://bugs.webkit.org/show_bug.cgi?id=178512
2313
2314         Reviewed by Darin Adler.
2315
2316         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2317
2318         * WebCoreSupport/WebChromeClient.mm:
2319         (WebChromeClient::supportsVideoFullscreen):
2320         * WebView/WebDynamicScrollBarsView.mm:
2321         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2322         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2323         * WebView/WebPreferences.mm:
2324         (+[WebPreferences initialize]):
2325         * WebView/WebView.mm:
2326         (-[WebView _commonInitializationWithFrameName:groupName:]):
2327         (-[WebView _preferencesChanged:]):
2328         (+[WebView _doNotStartObservingNetworkReachability]):
2329
2330 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2331
2332         Replace some stack raw pointers with RefPtrs within WebCore/html
2333         https://bugs.webkit.org/show_bug.cgi?id=178201
2334         <rdar://problem/34841692>
2335
2336         Reviewed by Ryosuke Niwa.
2337
2338         * DOM/DOM.mm:
2339         (kit):
2340         Change the type of node as toNode() is changed to return RefPtr.
2341
2342 2017-10-18  Chris Dumez  <cdumez@apple.com>
2343
2344         [Service Worker] Add stubs for Client / WindowClient / Clients
2345         https://bugs.webkit.org/show_bug.cgi?id=178469
2346
2347         Reviewed by Youenn Fablet.
2348
2349         Rename PageVisiblityState to VisibilityState.
2350
2351         * WebView/WebView.mm:
2352         (kit):
2353
2354 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2355
2356         Unreviewed, rolling out r223291.
2357
2358         See WebCore ChangeLog for more detail.
2359
2360         Reverted changeset:
2361
2362         "Remove Editor::simplifyMarkup"
2363         https://bugs.webkit.org/show_bug.cgi?id=178271
2364         https://trac.webkit.org/changeset/223291
2365
2366 2017-10-17  Keith Miller  <keith_miller@apple.com>
2367
2368         Change WebCore sources to work with unified source builds
2369         https://bugs.webkit.org/show_bug.cgi?id=178229
2370
2371         Rubber stamped by Tim Horton.
2372
2373         * Configurations/FeatureDefines.xcconfig:
2374
2375 2017-10-16  Sam Weinig  <sam@webkit.org>
2376
2377         [Settings] Remove all custom code from Settings.h/cpp
2378         https://bugs.webkit.org/show_bug.cgi?id=178330
2379
2380         Reviewed by Simon Fraser.
2381
2382         * WebView/WebPreferences.mm:
2383         (+[WebPreferences initialize]):
2384         
2385             Update for naming changes of FrameFlattening now that it is an enum class.
2386
2387 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2388
2389         Remove Editor::simplifyMarkup
2390         https://bugs.webkit.org/show_bug.cgi?id=178271
2391
2392         Reviewed by Wenson Hsieh.
2393
2394         * WebView/WebView.mm:
2395         (-[WebView _simplifyMarkup:endNode:]):
2396
2397 2017-10-12  Chris Dumez  <cdumez@apple.com>
2398
2399         [Mac] Add support for MouseEvent.buttons
2400         https://bugs.webkit.org/show_bug.cgi?id=178214
2401
2402         Reviewed by Ryosuke Niwa.
2403
2404         * WebView/WebPDFView.mm:
2405         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2406
2407 2017-10-11  Sam Weinig  <sam@webkit.org>
2408
2409         Remove out-parameter variants of copyToVector
2410         https://bugs.webkit.org/show_bug.cgi?id=178155
2411
2412         Reviewed by Tim Horton.
2413
2414         * Plugins/WebNetscapePluginView.mm:
2415         (-[WebNetscapePluginView destroyPlugin]):
2416         * WebView/WebHTMLRepresentation.mm:
2417         (newArrayWithStrings):
2418
2419             Replace out-parameter based copyToVector, with one that returns a Vector.
2420
2421 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2422
2423         Sanitize URL in pasteboard for other applications and cross origin content
2424         https://bugs.webkit.org/show_bug.cgi?id=178060
2425         <rdar://problem/34874518>
2426
2427         Reviewed by Wenson Hsieh.
2428
2429         * WebCoreSupport/WebPlatformStrategies.h:
2430         * WebCoreSupport/WebPlatformStrategies.mm:
2431         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2432
2433 2017-10-11  Chris Dumez  <cdumez@apple.com>
2434
2435         Modernize Geolocation code
2436         https://bugs.webkit.org/show_bug.cgi?id=178148
2437
2438         Reviewed by Ryosuke Niwa.
2439
2440         * WebCoreSupport/WebGeolocationClient.h:
2441         * WebCoreSupport/WebGeolocationClient.mm:
2442         (WebGeolocationClient::lastPosition):
2443         * WebView/WebGeolocationPosition.mm:
2444         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2445         (core):
2446         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2447         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2448         * WebView/WebGeolocationPositionInternal.h:
2449
2450 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2451
2452         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2453         https://bugs.webkit.org/show_bug.cgi?id=178154
2454
2455         Reviewed by Wenson Hsieh.
2456
2457         Enable custom pasteboard data by default.
2458
2459         * WebView/WebPreferenceKeysPrivate.h:
2460         * WebView/WebPreferences.mm:
2461         (+[WebPreferences initialize]):
2462         (-[WebPreferences customPasteboardDataEnabled]): Added.
2463         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2464         * WebView/WebPreferencesPrivate.h:
2465         * WebView/WebView.mm:
2466         (-[WebView _preferencesChanged:]):
2467
2468 2017-10-10  Sam Weinig  <sam@webkit.org>
2469
2470         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2471         https://bugs.webkit.org/show_bug.cgi?id=178102
2472
2473         Reviewed by Tim Horton.
2474
2475         * History/WebHistory.mm:
2476         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2477         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2478         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2479         * WebCoreSupport/WebUserMediaClient.mm:
2480         (WebUserMediaClient::pageDestroyed):
2481
2482 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2483
2484         Make the names of the options consistent
2485         https://bugs.webkit.org/show_bug.cgi?id=177933
2486
2487         Reviewed by Saam Barati.
2488
2489         * WebView/WebFrame.h:
2490         * WebView/WebHTMLView.mm:
2491         (-[WebHTMLView setMarkedText:selectedRange:]):
2492         * WebView/WebView.h:
2493
2494 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2495
2496         [iOS] Tweak support for classifying form controls (followup to r222487)
2497         https://bugs.webkit.org/show_bug.cgi?id=177917
2498         <rdar://problem/34820122>
2499
2500         Reviewed by Dean Jackson.
2501
2502         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2503
2504         * DOM/DOMHTMLInputElement.mm:
2505         (-[DOMHTMLInputElement _autofillContext]):
2506         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2507         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2508
2509 2017-10-05  Keith Miller  <keith_miller@apple.com>
2510
2511         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2512
2513         * Configurations/WebKitLegacy.xcconfig:
2514
2515 2017-10-05  Jer Noble  <jer.noble@apple.com>
2516
2517         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2518         https://bugs.webkit.org/show_bug.cgi?id=177261
2519
2520         Reviewed by Eric Carlson.
2521
2522         * Configurations/FeatureDefines.xcconfig:
2523
2524 2017-10-05  Chris Dumez  <cdumez@apple.com>
2525
2526         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2527         https://bugs.webkit.org/show_bug.cgi?id=177957
2528
2529         Reviewed by Alex Christensen.
2530
2531         * WebCoreSupport/WebPlatformStrategies.h:
2532         * WebCoreSupport/WebPlatformStrategies.mm:
2533         (WebPlatformStrategies::cookiesEnabled):
2534
2535 2017-10-05  Youenn Fablet  <youenn@apple.com>
2536
2537         Make LibWebRTCProvider port agnostic
2538         https://bugs.webkit.org/show_bug.cgi?id=177747
2539
2540         Reviewed by Alex Christensen & Alex Garcia.
2541
2542         * WebView/WebView.mm:
2543         (-[WebView _commonInitializationWithFrameName:groupName:]):
2544         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2545
2546 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2547
2548         Stop linking with WebKitSystemInterface
2549         https://bugs.webkit.org/show_bug.cgi?id=177915
2550
2551         Reviewed by Antti Koivisto.
2552
2553         * Configurations/DebugRelease.xcconfig:
2554         * Configurations/WebKitLegacy.xcconfig:
2555
2556 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2557
2558         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2559         https://bugs.webkit.org/show_bug.cgi?id=177912
2560
2561         Reviewed by Saam Barati.
2562
2563         * Carbon/CarbonUtils.m:
2564         * Carbon/CarbonWindowAdapter.mm:
2565         * Carbon/HIWebView.mm:
2566         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2567         * Misc/WebNSFileManagerExtras.mm:
2568         * Misc/WebNSPasteboardExtras.mm:
2569         * Misc/WebNSURLExtras.mm:
2570         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2571         * Plugins/Hosted/NetscapePluginHostManager.mm:
2572         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2573         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2574         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2575         * Plugins/Hosted/WebTextInputWindowController.m:
2576         * Plugins/WebBaseNetscapePluginView.mm:
2577         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2578         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2579         * Plugins/WebNetscapePluginStream.mm:
2580         * Plugins/WebNetscapePluginView.mm:
2581         * Plugins/WebPluginDatabase.mm:
2582         * WebCoreSupport/PopupMenuMac.mm:
2583         * WebCoreSupport/WebChromeClient.mm:
2584         * WebCoreSupport/WebFrameLoaderClient.mm:
2585         * WebCoreSupport/WebInspectorClient.mm:
2586         * WebCoreSupport/WebPlatformStrategies.mm:
2587         * WebCoreSupport/WebSystemInterface.mm:
2588         * WebView/WebDynamicScrollBarsView.mm:
2589         * WebView/WebFrame.mm:
2590         * WebView/WebFrameView.mm:
2591         * WebView/WebFullScreenController.mm:
2592         * WebView/WebHTMLView.mm:
2593         * WebView/WebPreferences.mm:
2594         * WebView/WebView.mm:
2595
2596 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2597
2598         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2599         rdar://problem/34705779
2600
2601         Addressing review comments that I somehow landed without.
2602
2603         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2604
2605 2017-09-29  Chris Dumez  <cdumez@apple.com>
2606
2607         Split some logic out of VisitedLinkStore and make it reusable
2608         https://bugs.webkit.org/show_bug.cgi?id=177575
2609
2610         Reviewed by Alex Christensen.
2611
2612         * WebCoreSupport/WebVisitedLinkStore.h:
2613         * WebCoreSupport/WebVisitedLinkStore.mm:
2614         (WebVisitedLinkStore::addVisitedLink):
2615         (WebVisitedLinkStore::removeVisitedLink):
2616         (WebVisitedLinkStore::isLinkVisited):
2617         (WebVisitedLinkStore::addVisitedLinkHash):
2618
2619 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2620
2621         Build fix for High Sierra 32 bit Mac
2622         https://bugs.webkit.org/show_bug.cgi?id=177551
2623         <rdar://problem/34690283>
2624
2625         Reviewed by Alexey Proskuryakov.
2626
2627         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2628         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2629         also made.
2630
2631         * Carbon/CarbonWindowAdapter.mm:
2632         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2633         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2634         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2635         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2636         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2637         (-[CarbonWindowAdapter dealloc]):
2638         (-[CarbonWindowAdapter windowRef]):
2639         (-[CarbonWindowAdapter _hasWindowRef]):
2640         (-[CarbonWindowAdapter _managesWindowRef]):
2641         (-[CarbonWindowAdapter _removeWindowRef]):
2642         (-[CarbonWindowAdapter _carbonWindowClass]):
2643         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2644         (-[CarbonWindowAdapter sendSuperEvent:]):
2645         (-[CarbonWindowAdapter relinquishFocus]):
2646         (-[CarbonWindowAdapter _cancelKey:]):
2647         (-[CarbonWindowAdapter _commonAwake]):
2648         (-[CarbonWindowAdapter _destroyRealWindow:]):
2649         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2650         (-[CarbonWindowAdapter _termWindowIfOwner]):
2651         (-[CarbonWindowAdapter _windowMovedToRect:]):
2652         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2653         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2654         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2655         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2656         (-[CarbonWindowAdapter canBecomeMainWindow]):
2657         (-[CarbonWindowAdapter encodeWithCoder:]):
2658         (-[CarbonWindowAdapter initWithCoder:]):
2659         (-[CarbonWindowAdapter setContentView:]):
2660         (-[CarbonWindowAdapter worksWhenModal]):
2661         (-[CarbonWindowAdapter _setModalWindowLevel]):
2662         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2663         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2664         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2665         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2666         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2667         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2668         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2669         (NSCarbonWindowHandleEvent):
2670         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2671         (-[CarbonWindowAdapter _growBoxRect]):
2672         * Carbon/HIWebView.mm:
2673         (HIWebViewGetWebView):
2674         (HIWebViewConstructor):
2675         (HIWebViewDestructor):
2676         (HIWebViewRegisterClass):
2677         (GetBehaviors):
2678         (Draw):
2679         (HitTest):
2680         (GetRegion):
2681         (GetWindowRef):
2682         (CreateNSEventAdoptingCGEvent):
2683         (CopyEventCGEvent):
2684         (CreateNSEventWithCarbonClickEvent):
2685         (Click):
2686         (CreateNSEventWithCarbonEvent):
2687         (MouseUp):
2688         (CreateNSEventWithCarbonMouseMoveEvent):
2689         (MouseMoved):
2690         (MouseDragged):
2691         (MouseWheelMoved):
2692         (ContextMenuClick):
2693         (GetKind):
2694         (BoundsChanged):
2695         (OwningWindowChanged):
2696         (WindowHandler):
2697         (SyncFrame):
2698         (SetFocusPart):
2699         (AdvanceFocus):
2700         (RelinquishFocus):
2701         (ActiveStateChanged):
2702         (ProcessCommand):
2703         (UpdateCommandStatus):
2704         (_NSSelectorForHICommand):
2705         (HIWebViewEventHandler):
2706         (StartUpdateObserver):
2707         (StopUpdateObserver):
2708         (UpdateObserver):
2709
2710 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2711
2712         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2713         https://bugs.webkit.org/show_bug.cgi?id=172526
2714         <rdar://problem/32396081>
2715
2716         Reviewed by Ryosuke Niwa.
2717
2718         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2719
2720         * WebCoreSupport/WebPlatformStrategies.h:
2721         * WebCoreSupport/WebPlatformStrategies.mm:
2722         (WebPlatformStrategies::webExposedTypes):
2723         (WebPlatformStrategies::writeCustomData):
2724
2725 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2726
2727         Unreviewed, rolling out r222567.
2728
2729         This broke and internal build.
2730
2731         Reverted changeset:
2732
2733         "Build fix for High Sierra 32 bit Mac"
2734         https://bugs.webkit.org/show_bug.cgi?id=177551
2735         http://trac.webkit.org/changeset/222567
2736
2737 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2738
2739         Build fix for High Sierra 32 bit Mac
2740         https://bugs.webkit.org/show_bug.cgi?id=177551
2741         <rdar://problem/34690283>
2742
2743         Reviewed by Alexey Proskuryakov.
2744
2745         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2746         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2747         also made.
2748
2749         * Carbon/CarbonWindowAdapter.mm:
2750         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2751         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2752         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2753         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2754         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2755         (-[CarbonWindowAdapter dealloc]):
2756         (-[CarbonWindowAdapter windowRef]):
2757         (-[CarbonWindowAdapter _hasWindowRef]):
2758         (-[CarbonWindowAdapter _managesWindowRef]):
2759         (-[CarbonWindowAdapter _removeWindowRef]):
2760         (-[CarbonWindowAdapter _carbonWindowClass]):
2761         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2762         (-[CarbonWindowAdapter sendSuperEvent:]):
2763         (-[CarbonWindowAdapter relinquishFocus]):
2764         (-[CarbonWindowAdapter _cancelKey:]):
2765         (-[CarbonWindowAdapter _commonAwake]):
2766         (-[CarbonWindowAdapter _destroyRealWindow:]):
2767         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2768         (-[CarbonWindowAdapter _termWindowIfOwner]):
2769         (-[CarbonWindowAdapter _windowMovedToRect:]):
2770         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2771         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2772         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2773         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2774         (-[CarbonWindowAdapter canBecomeMainWindow]):
2775         (-[CarbonWindowAdapter encodeWithCoder:]):
2776         (-[CarbonWindowAdapter initWithCoder:]):
2777         (-[CarbonWindowAdapter setContentView:]):
2778         (-[CarbonWindowAdapter worksWhenModal]):
2779         (-[CarbonWindowAdapter _setModalWindowLevel]):
2780         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2781         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2782         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2783         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2784         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2785         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2786         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2787         (NSCarbonWindowHandleEvent):
2788         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2789         (-[CarbonWindowAdapter _growBoxRect]):
2790         * Carbon/HIWebView.mm:
2791         (HIWebViewGetWebView):
2792         (HIWebViewConstructor):
2793         (HIWebViewDestructor):
2794         (HIWebViewRegisterClass):
2795         (GetBehaviors):
2796         (Draw):
2797         (HitTest):
2798         (GetRegion):
2799         (GetWindowRef):
2800         (CreateNSEventAdoptingCGEvent):
2801         (CopyEventCGEvent):
2802         (CreateNSEventWithCarbonClickEvent):
2803         (Click):
2804         (CreateNSEventWithCarbonEvent):
2805         (MouseUp):
2806         (CreateNSEventWithCarbonMouseMoveEvent):
2807         (MouseMoved):
2808         (MouseDragged):
2809         (MouseWheelMoved):
2810         (ContextMenuClick):
2811         (GetKind):
2812         (BoundsChanged):
2813         (OwningWindowChanged):
2814         (WindowHandler):
2815         (SyncFrame):
2816         (SetFocusPart):
2817         (AdvanceFocus):
2818         (RelinquishFocus):
2819         (ActiveStateChanged):
2820         (ProcessCommand):
2821         (UpdateCommandStatus):
2822         (_NSSelectorForHICommand):
2823         (HIWebViewEventHandler):
2824         (StartUpdateObserver):
2825         (StopUpdateObserver):
2826         (UpdateObserver):
2827
2828 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2829
2830         Make PolicyAction an encodable enum class
2831         https://bugs.webkit.org/show_bug.cgi?id=177480
2832
2833         Reviewed by Antti Koivisto.
2834
2835         * Plugins/WebPluginContainerCheck.mm:
2836         (-[WebPluginContainerCheck _continueWithPolicy:]):
2837         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2838         * WebCoreSupport/WebFrameLoaderClient.mm:
2839         (-[WebFramePolicyListener invalidate]):
2840         (-[WebFramePolicyListener ignore]):
2841         (-[WebFramePolicyListener download]):
2842         (-[WebFramePolicyListener use]):
2843         (-[WebFramePolicyListener continue]):
2844         * WebView/WebPolicyDelegate.mm:
2845         (-[WebPolicyDecisionListener use]):
2846         (-[WebPolicyDecisionListener ignore]):
2847         (-[WebPolicyDecisionListener download]):
2848
2849 2017-09-25  Frederik Riedel  <riedel@apple.com>
2850
2851         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2852         https://bugs.webkit.org/show_bug.cgi?id=174394
2853         <rdar://problem/33183504>
2854
2855         Reviewed by Ryosuke Niwa.
2856
2857         * DOM/DOMHTMLInputElement.h:
2858         * DOM/DOMHTMLInputElement.mm:
2859         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2860         Determines if this HTMLInputElement is part of a login screen.
2861         (-[DOMHTMLInputElement representingPageUrl]):
2862         Returns the webpage's URL that is currently displayed in the Web View.
2863         (-[DOMHTMLInputElement insertTextSuggestion:]):
2864         Inserts login credentials into the Web View.
2865
2866 2017-09-25  Sam Weinig  <sam@webkit.org>
2867
2868         Remove unused EditorClient functions
2869         https://bugs.webkit.org/show_bug.cgi?id=177463
2870
2871         Reviewed by Alex Christensen.
2872
2873         Remove unused EditorClient functions.
2874
2875         * WebCoreSupport/WebEditorClient.h:
2876         * WebCoreSupport/WebEditorClient.mm:
2877         (WebEditorClient::canonicalizeURL): Deleted.
2878         (WebEditorClient::canonicalizeURLString): Deleted.
2879         (WebEditorClient::writeDataToPasteboard): Deleted.
2880         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2881         (WebEditorClient::readDataFromPasteboard): Deleted.
2882         (WebEditorClient::pasteboardChangeCount): Deleted.
2883
2884 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2885
2886         Stop using PolicyCallback
2887         https://bugs.webkit.org/show_bug.cgi?id=176088
2888
2889         Reviewed by Andy Estes.
2890
2891         * WebCoreSupport/WebFrameLoaderClient.mm:
2892         (-[WebFramePolicyListener invalidate]):
2893         (-[WebFramePolicyListener receivedPolicyDecision:]):
2894
2895 2017-09-25  Sam Weinig  <sam@webkit.org>
2896
2897         Remove unnecessary userVisibleString EditorClient function
2898         https://bugs.webkit.org/show_bug.cgi?id=177456
2899
2900         Reviewed by Dan Bernstein.
2901
2902         * WebCoreSupport/WebEditorClient.h:
2903         * WebCoreSupport/WebEditorClient.mm:
2904         (WebEditorClient::userVisibleString): Deleted.
2905
2906             Remove userVisibleString client function.
2907
2908 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2909
2910         Separate form submission from PolicyChecker infrastructure
2911         https://bugs.webkit.org/show_bug.cgi?id=177396
2912
2913         Reviewed by Geoffrey Garen.
2914
2915         * WebCoreSupport/WebFrameLoaderClient.h:
2916         * WebCoreSupport/WebFrameLoaderClient.mm:
2917         (WebFrameLoaderClient::dispatchWillSubmitForm):
2918
2919 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2920
2921         WeakPtrFactory should populate m_ref lazily.
2922         https://bugs.webkit.org/show_bug.cgi?id=177375
2923
2924         Reviewed by Geoffrey Garen.
2925
2926         * WebCoreSupport/WebEditorClient.mm:
2927         (WebEditorClient::WebEditorClient):
2928         (WebEditorClient::requestCandidatesForSelection):
2929
2930 2017-09-22  Chris Dumez  <cdumez@apple.com>
2931
2932         Use high resolution timestamp for event time
2933         https://bugs.webkit.org/show_bug.cgi?id=154246
2934         <rdar://problem/34333304>
2935
2936         Reviewed by Ryosuke Niwa.
2937
2938         Use WallTime / MonotonicTime instead of double type for clarity.
2939
2940         * DOM/DOMEvent.mm:
2941         (-[DOMEvent timeStamp]):
2942         * WebView/WebFrame.mm:
2943         (-[WebFrame _dragSourceEndedAt:operation:]):
2944         * WebView/WebPDFView.mm:
2945         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2946
2947 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2948
2949         Enable dataTransfer.items on macOS and iOS
2950         https://bugs.webkit.org/show_bug.cgi?id=177335
2951
2952         Reviewed by Sam Weinig.
2953
2954         * WebView/WebPreferences.mm:
2955         (+[WebPreferences initialize]):
2956
2957 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2958
2959         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2960         https://bugs.webkit.org/show_bug.cgi?id=177101
2961         <rdar://problem/34500648>
2962
2963         Reviewed by Brian Burg.
2964
2965         * WebInspector/WebNodeHighlight.mm:
2966         Ensure we close the window that we have just removed.
2967
2968 2017-09-20  Antti Koivisto  <antti@apple.com>
2969
2970         Remove DOM and styling support for CSS Regions
2971         https://bugs.webkit.org/show_bug.cgi?id=177221
2972
2973         Reviewed by Andreas Kling.
2974
2975         * Configurations/FeatureDefines.xcconfig:
2976         * DOM/DOMCSS.mm:
2977         (kitClass):
2978         * DOM/DOMElement.mm:
2979         (-[DOMElement webkitRegionOverset]): Deleted.
2980
2981 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2982
2983         Layering violation in Editor::createFragment
2984         https://bugs.webkit.org/show_bug.cgi?id=176123
2985
2986         Reviewed by Darin Adler.
2987
2988         * Misc/WebNSURLExtras.h:
2989         * Misc/WebNSURLExtras.mm:
2990         * WebView/WebFrame.mm:
2991         * WebView/WebHTMLView.mm:
2992         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2993
2994         * WebCoreSupport/WebEditorClient.mm:
2995         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2996         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2997         way to avoid exporting the symbol just on newer OSes.
2998
2999 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
3000
3001         On iOS, getData can't get text set by setData during copy event
3002         https://bugs.webkit.org/show_bug.cgi?id=176980
3003         <rdar://problem/34453915>
3004
3005         Reviewed by Darin Adler.
3006
3007         * WebCoreSupport/WebPlatformStrategies.h:
3008         * WebCoreSupport/WebPlatformStrategies.mm:
3009         (WebPlatformStrategies::copy): Deleted.
3010
3011 2017-09-18  Andy Estes  <aestes@apple.com>
3012
3013         [Mac] Upstream miscellaneous WebKitSystemInterface functions
3014         https://bugs.webkit.org/show_bug.cgi?id=177029
3015
3016         Reviewed by Alex Christensen.
3017
3018         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
3019         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
3020         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3021         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
3022         * WebCoreSupport/PopupMenuMac.mm:
3023         (PopupMenuMac::show):
3024         * WebCoreSupport/WebSystemInterface.mm:
3025         (InitWebCoreSystemInterface):
3026         * WebView/WebHTMLView.mm:
3027         (-[WebHTMLView setDataSource:]):
3028         (-[WebHTMLView attachRootLayer:]):
3029         * WebView/WebView.mm:
3030         (-[WebView _needsAdobeFrameReloadingQuirk]):
3031         (-[WebView _needsLinkElementTextCSSQuirk]):
3032         (-[WebView _needsIsLoadingInAPISenseQuirk]):
3033         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
3034         (-[WebView _preferencesChanged:]):
3035
3036 2017-09-15  Andy Estes  <aestes@apple.com>
3037
3038         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
3039         https://bugs.webkit.org/show_bug.cgi?id=176953
3040
3041         Reviewed by Eric Carlson.
3042
3043         * WebCoreSupport/WebSystemInterface.mm:
3044         (InitWebCoreSystemInterface):
3045
3046 2017-09-14  Andy Estes  <aestes@apple.com>
3047
3048         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
3049         https://bugs.webkit.org/show_bug.cgi?id=176931
3050
3051         Reviewed by Joseph Pecoraro.
3052
3053         * WebCoreSupport/WebSystemInterface.mm:
3054         (InitWebCoreSystemInterface):
3055
3056 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3057
3058         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
3059         https://bugs.webkit.org/show_bug.cgi?id=176867
3060
3061         Reviewed by Sam Weinig.
3062
3063         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3064         (WebKit::NetscapePluginInstanceProxy::enumerate):
3065
3066 2017-09-13  Andy Estes  <aestes@apple.com>
3067
3068         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
3069         https://bugs.webkit.org/show_bug.cgi?id=176729
3070
3071         Reviewed by Alex Christensen.
3072
3073         * WebCoreSupport/WebSystemInterface.mm:
3074         (InitWebCoreSystemInterface):
3075         * WebView/WebView.mm:
3076         (+[WebView _setCacheModel:]):
3077
3078 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3079
3080         Refactor WebContentReader out of EditorMac and EditorIOS
3081         https://bugs.webkit.org/show_bug.cgi?id=176770
3082
3083         Reviewed by Sam Weinig.
3084
3085         * WebCoreSupport/WebEditorClient.mm:
3086
3087 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3088
3089         Dragging & dropping a file creates an attachment element even when it's disabled
3090         https://bugs.webkit.org/show_bug.cgi?id=176769
3091
3092         Reviewed by Tim Horton.
3093
3094         * WebView/WebView.mm:
3095         (-[WebView _preferencesChanged:]):
3096
3097 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3098
3099         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
3100         https://bugs.webkit.org/show_bug.cgi?id=176721
3101         <rdar://problem/34373660>
3102
3103         Reviewed by Tim Horton.
3104
3105         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
3106         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
3107
3108         * WebView/WebView.mm:
3109         (-[WebView _startDrag:]):
3110         (-[WebView _draggedElementBounds]):
3111         (-[WebView _endedDataInteraction:global:]):
3112         * WebView/WebViewData.h:
3113
3114 2017-09-11  Andy Estes  <aestes@apple.com>
3115
3116         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3117         https://bugs.webkit.org/show_bug.cgi?id=176472
3118
3119         Reviewed by Eric Carlson.
3120
3121         * WebCoreSupport/WebSystemInterface.mm:
3122         (InitWebCoreSystemInterface):
3123
3124 2017-09-09  Mark Lam  <mark.lam@apple.com>
3125
3126         Avoid duplicate computations of ExecState::vm().
3127         https://bugs.webkit.org/show_bug.cgi?id=176647
3128
3129         Reviewed by Saam Barati.
3130
3131         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3132         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
3133         (WebKit::NetscapePluginInstanceProxy::construct):
3134         (WebKit::NetscapePluginInstanceProxy::setProperty):
3135         (WebKit::NetscapePluginInstanceProxy::removeProperty):
3136         (WebKit::NetscapePluginInstanceProxy::enumerate):
3137         * Plugins/Hosted/ProxyInstance.mm:
3138         (WebKit::ProxyRuntimeMethod::create):
3139
3140 2017-09-08  Commit Queue  <commit-queue@webkit.org>
3141
3142         Unreviewed, rolling out r221773.
3143         https://bugs.webkit.org/show_bug.cgi?id=176614
3144
3145         This caused build failures. (Requested by mlewis13 on
3146         #webkit).
3147
3148         Reverted changeset:
3149
3150         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
3151         https://bugs.webkit.org/show_bug.cgi?id=176472
3152         http://trac.webkit.org/changeset/221773
3153
3154 2017-09-07  Andy Estes  <aestes@apple.com>
3155
3156         [Mac] Upstream QTKit-related WebKitSystemInterface functions
3157         https://bugs.webkit.org/show_bug.cgi?id=176472
3158
3159         Reviewed by Eric Carlson.
3160
3161         * WebCoreSupport/WebSystemInterface.mm:
3162         (InitWebCoreSystemInterface):
3163
3164 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
3165
3166         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
3167         https://bugs.webkit.org/show_bug.cgi?id=176561
3168
3169         Reviewed by Brent Fulgham.
3170
3171         * Misc/WebNSUserDefaultsExtras.mm:
3172
3173 2017-09-07  Alex Christensen  <achristensen@webkit.org>
3174
3175         Modernize Geolocation code
3176         https://bugs.webkit.org/show_bug.cgi?id=176496
3177
3178         Reviewed by Andy Estes.
3179
3180         * WebCoreSupport/WebGeolocationClient.h:
3181         * WebCoreSupport/WebGeolocationClient.mm:
3182         (WebGeolocationClient::requestPermission):
3183         (-[WebGeolocationPolicyListener initWithGeolocation:]):
3184         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
3185         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
3186         * WebView/WebView.mm:
3187         (-[WebView _commonInitializationWithFrameName:groupName:]):
3188         (-[WebView _geolocationDidFailWithMessage:]):
3189
3190 2017-09-05  Tim Horton  <timothy_horton@apple.com>
3191
3192         Remove some unused bits of code and resources
3193         https://bugs.webkit.org/show_bug.cgi?id=176275
3194
3195         Reviewed by Dan Bernstein.
3196
3197         * Misc/WebNSFileManagerExtras.mm:
3198         Include FileSystem instead of FileSystemIOS.
3199
3200 2017-09-03  Darin Adler  <darin@apple.com>
3201
3202         [Cocoa] Tidy a few things in legacy WebHTMLView
3203         https://bugs.webkit.org/show_bug.cgi?id=176280
3204
3205         Reviewed by Dan Bernstein.
3206
3207         * WebCoreSupport/WebChromeClient.mm:
3208         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3209         methods it calls on WebHTMLView were doing nothing on iOS.
3210
3211         * WebView/WebFrame.mm:
3212         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3213         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3214
3215         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3216         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3217         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3218         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3219         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3220         Use RetainPtr instead of writing retain/release wherever possible.
3221         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3222         initialization for it. Removed various unused methods and declarations of methods.
3223         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3224         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3225         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3226         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3227         and remove CFRetain no longer needed since we don't support garbage collection any more.
3228         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3229         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3230         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3231         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3232         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3233         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3234         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3235         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3236         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3237         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3238         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3239         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3240         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3241         debug flag; we haven't used it for years and it's not clearly helpful.
3242         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3243         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3244         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3245         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3246         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3247         two additional methods in the WebPrivate category and still be called by the two
3248         methods in the WebInternal category that were already using it.
3249         (-[WebHTMLView didAddSubview:]): Deleted.
3250         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3251         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3252         place this was called, the close method.
3253         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3254         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3255         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3256         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3257         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3258         Added helper method to make the one below simpler.
3259         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3260         Compared pasteboard type strings using isEqualToString: rather than using == since
3261         we want to actually compare the string contents. Also updated to use modern for loop,
3262         renamed a local variable from "s" to "localSubresources", and factored out the handling
3263         of three image types to use the helper method above.
3264         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3265         _web_makePluginSubviewsPerformSelector:withObject: method.
3266         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3267         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3268         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3269         not call the -[NSView subviews] method to make this identical on both platforms and used
3270         a modern for loop.
3271         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3272         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3273         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3274         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3275         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3276         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3277         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3278         of it is Mac-only.
3279         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3280         method did was call itself on the main thread, and do nothing if called on main thread.
3281         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3282         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3283         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3284         half of this method.
3285         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3286         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3287         Simplified using a modern for loop and RetainPtr.
3288         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3289         (-[WebHTMLView keyDown:]): Ditto.
3290         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3291         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3292         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3293         (-[WebHTMLView complete:]): Ditto.
3294         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3295         now macOS-only.
3296         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3297         iOS since that is now macOS-only.
3298         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3299         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3300         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3301         and reorganized to use early return.
3302         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3303         on iOS, but kept there so we don't have to do #if at every call site.
3304         (-[WebHTMLView _pluginController]): Moved into internal category.
3305         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3306         there only for GC, using C++ initialization, removing obsolete comment.
3307         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3308         peculiar iOS-only comment.
3309         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3310
3311         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3312         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3313         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3314         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3315         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3316
3317         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3318         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3319         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3320         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3321         them at this time.
3322
3323 2017-09-03  Sam Weinig  <sam@webkit.org>
3324
3325         Remove CanvasProxy
3326         https://bugs.webkit.org/show_bug.cgi?id=176288
3327
3328         Reviewed by Yusuke Suzuki.
3329
3330         CanvasProxy does not appear to be in any current HTML spec
3331         and was disabled and unimplemented in our tree. Time to 
3332         get rid of it.
3333
3334         * Configurations/FeatureDefines.xcconfig:
3335
3336 2017-09-02  Andy Estes  <aestes@apple.com>
3337
3338         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3339         https://bugs.webkit.org/show_bug.cgi?id=176270
3340
3341         Reviewed by Tim Horton.
3342
3343         * Plugins/Hosted/NetscapePluginHostManager.mm:
3344         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3345         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3346         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3347         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3348         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3349         (WebKit::SoftwareCARenderer::context const):
3350         (WebKit::SoftwareCARenderer::renderContext const):
3351         (WebKit::SoftwareCARenderer::render):
3352         (-[WebHostedNetscapePluginView createPlugin]):
3353         (-[WebHostedNetscapePluginView createPluginLayer]):
3354         (-[WebHostedNetscapePluginView destroyPlugin]):
3355         (-[WebHostedNetscapePluginView drawRect:]):
3356         * WebCoreSupport/WebSystemInterface.mm:
3357         (InitWebCoreSystemInterface):
3358
3359 2017-09-01  Andy Estes  <aestes@apple.com>
3360
3361         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3362         https://bugs.webkit.org/show_bug.cgi?id=176200
3363
3364         Reviewed by Tim Horton.
3365
3366         * Carbon/HIWebView.mm:
3367         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3368         (overrideCGContext):
3369         (restoreCGContext):
3370         (Draw):
3371         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3372         (+[WebHostedNetscapePluginView initialize]):
3373         * Plugins/WebBaseNetscapePluginView.h:
3374         * Plugins/WebBaseNetscapePluginView.mm:
3375         (WebKit::sendUserChangeNotifications):
3376         * Plugins/WebNetscapePluginView.mm:
3377         (+[WebNetscapePluginView initialize]):
3378         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3379         * WebCoreSupport/WebSystemInterface.mm:
3380         (InitWebCoreSystemInterface):
3381         * WebView/WebFrame.mm:
3382         (-[WebFrame _paintBehaviorForDestinationContext:]):
3383         * WebView/WebFullScreenController.mm:
3384         (setClipRectForWindow):
3385         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3386         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3387         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3388         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3389
3390 2017-08-31  Andy Estes  <aestes@apple.com>
3391
3392         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3393         https://bugs.webkit.org/show_bug.cgi?id=176175
3394
3395         Reviewed by Brady Eidson.
3396
3397         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3398         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3399         * Plugins/Hosted/WebTextInputWindowController.m:
3400         (-[WebTextInputPanel init]):
3401         * WebCoreSupport/WebSystemInterface.mm:
3402         (InitWebCoreSystemInterface):
3403         * WebView/WebDynamicScrollBarsView.mm:
3404         (-[WebDynamicScrollBarsView scrollWheel:]):
3405         * WebView/WebHTMLView.mm:
3406         (-[WebHTMLView _removeWindowObservers]):
3407         (-[WebHTMLView addWindowObservers]):
3408         * WebView/WebView.mm:
3409         (-[WebView addWindowObserversForWindow:]):
3410         (-[WebView removeWindowObservers]):
3411         (-[WebView viewWillMoveToWindow:]):
3412
3413 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3414
3415         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3416         https://bugs.webkit.org/show_bug.cgi?id=175779
3417         <rdar://problem/22367975>
3418
3419         Reviewed by Tim Horton.
3420
3421         * WebCoreSupport/WebFrameLoaderClient.h:
3422         * WebCoreSupport/WebFrameLoaderClient.mm:
3423         (WebFrameLoaderClient::webGLPolicyForURL const):
3424         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3425
3426 2017-08-30  Andy Estes  <aestes@apple.com>
3427
3428         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3429         https://bugs.webkit.org/show_bug.cgi?id=176093
3430
3431         Reviewed by Eric Carlson.
3432
3433         * WebCoreSupport/WebSystemInterface.mm:
3434         (InitWebCoreSystemInterface):
3435
3436 2017-08-30  Andy Estes  <aestes@apple.com>
3437
3438         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3439         https://bugs.webkit.org/show_bug.cgi?id=176087
3440
3441         Reviewed by Alex Christensen.
3442
3443         * Carbon/CarbonUtils.m:
3444         (getNSAutoreleasePoolCount):
3445         (WebInitForCarbon):
3446         (PoolCleaner):
3447         * Carbon/CarbonWindowAdapter.mm:
3448         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3449         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3450         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3451         (-[CarbonWindowAdapter _windowMovedToRect:]):
3452         * Carbon/HIViewAdapter.m:
3453         * Carbon/HIWebView.mm:
3454         (Draw):
3455         (CreateNSEventAdoptingCGEvent):
3456         (CopyEventCGEvent):
3457         (CreateNSEventWithCarbonClickEvent):
3458         (Click):
3459         (CreateNSEventWithCarbonEvent):
3460         (MouseUp):
3461         (CreateNSEventWithCarbonMouseMoveEvent):
3462         (MouseMoved):
3463         (MouseDragged):
3464         (MouseWheelMoved):
3465         (WindowHandler):
3466         (HIWebViewEventHandler):
3467         * Misc/QuickDrawCompatibility.h: Removed.
3468         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3469         (getCarbonEvent):
3470         (WebNetscapePluginEventHandlerCarbon::keyDown):
3471         (WebNetscapePluginEventHandlerCarbon::keyUp):
3472         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3473         (WebNetscapePluginEventHandlerCocoa::keyDown):
3474         * Plugins/WebNetscapePluginView.mm:
3475         (-[WebNetscapePluginView tellQuickTimeToChill]):
3476
3477 2017-08-29  Andy Estes  <aestes@apple.com>
3478
3479         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3480         https://bugs.webkit.org/show_bug.cgi?id=176046
3481
3482         Reviewed by Alex Christensen.
3483
3484         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3485         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3486
3487         * Misc/WebNSFileManagerExtras.mm:
3488         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3489         (setMetaData): Deleted.
3490         * WebCoreSupport/WebSystemInterface.mm:
3491         (InitWebCoreSystemInterface):
3492
3493 2017-08-28  Andy Estes  <aestes@apple.com>
3494
3495         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3496         https://bugs.webkit.org/show_bug.cgi?id=176039
3497
3498         Reviewed by Alex Christensen.
3499
3500         * WebCoreSupport/WebSystemInterface.mm:
3501         (InitWebCoreSystemInterface):
3502         * WebView/WebPreferences.mm:
3503         (+[WebPreferences _systemCFStringEncoding]):
3504
3505 2017-08-28  Andy Estes  <aestes@apple.com>
3506
3507         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3508         https://bugs.webkit.org/show_bug.cgi?id=176032
3509
3510         Reviewed by Alex Christensen.
3511
3512         * WebCoreSupport/WebSystemInterface.mm:
3513         (InitWebCoreSystemInterface):
3514         * WebView/WebView.mm:
3515         (-[WebView _cachedResponseForURL:]):
3516
3517 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3518
3519         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3520         https://bugs.webkit.org/show_bug.cgi?id=175992
3521         <rdar://problem/34086613>
3522
3523         Reviewed by Daniel Bates.
3524
3525         * WebCoreSupport/WebPlatformStrategies.h:
3526         * WebCoreSupport/WebPlatformStrategies.mm:
3527         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3528         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3529         indicating if secure cookies were accessed.
3530
3531 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3532
3533         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3534         https://bugs.webkit.org/show_bug.cgi?id=170955
3535         <rdar://problem/31697653>
3536
3537         Reviewed by Ryosuke Niwa.
3538
3539         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3540         text is being replaced.
3541
3542         * WebView/WebHTMLView.mm:
3543         (-[WebHTMLView insertText:]):
3544
3545 2017-08-24  Chris Dumez  <cdumez@apple.com>
3546
3547         [Directory Upload] Add basic support for input.webkitdirectory
3548         https://bugs.webkit.org/show_bug.cgi?id=175950
3549         <rdar://problem/33951915>
3550
3551         Reviewed by Geoffrey Garen.
3552
3553         Add private API to toggle Directory Upload support on Mac WebKit1.
3554
3555         * WebView/WebPreferenceKeysPrivate.h:
3556         * WebView/WebPreferences.mm:
3557         (+[WebPreferences initialize]):
3558         (-[WebPreferences setDirectoryUploadEnabled:]):
3559         (-[WebPreferences directoryUploadEnabled]):
3560         * WebView/WebPreferencesPrivate.h:
3561         * WebView/WebView.mm:
3562         (-[WebView _preferencesChanged:]):
3563
3564 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3565
3566         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3567         https://bugs.webkit.org/show_bug.cgi?id=175370
3568         <rdar://problem/33799806>
3569
3570         Reviewed by Ryosuke Niwa.
3571
3572         Adjust WebEditorClient for interface changes.
3573
3574         * WebCoreSupport/WebEditorClient.h:
3575
3576 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3577
3578         Remove ChromeClient::scrollbarsModeDidChange
3579         https://bugs.webkit.org/show_bug.cgi?id=175805
3580
3581         Reviewed by Daniel Bates.
3582
3583         * WebCoreSupport/WebChromeClient.h:
3584
3585 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3586
3587         Remove ChromeClient::hasOpenedPopup
3588         https://bugs.webkit.org/show_bug.cgi?id=175804
3589
3590         Reviewed by Sam Weinig.
3591
3592         * WebCoreSupport/WebChromeClient.h:
3593         * WebCoreSupport/WebChromeClient.mm:
3594         (WebChromeClient::hasOpenedPopup const): Deleted.
3595
3596 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3597
3598         Disable access to secure cookies if an HTTPS site loads mixed content
3599         https://bugs.webkit.org/show_bug.cgi?id=157053
3600         <rdar://problem/11290808>
3601
3602         Reviewed by Dan Bates.
3603
3604         * WebCoreSupport/WebPlatformStrategies.h:
3605         * WebCoreSupport/WebPlatformStrategies.mm:
3606         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3607         indicating whether secure cookies should be included in the response.
3608
3609 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3610
3611         [PAL] Move spi/mac directory into PAL
3612         https://bugs.webkit.org/show_bug.cgi?id=175649
3613
3614         Reviewed by Myles C. Maxfield.
3615
3616         * Misc/WebSharingServicePickerController.h:
3617         * WebCoreSupport/WebContextMenuClient.mm:
3618         * WebCoreSupport/WebEditorClient.mm:
3619         * WebCoreSupport/WebSelectionServiceController.mm:
3620         * WebView/WebHTMLView.mm:
3621         * WebView/WebImmediateActionController.h:
3622         * WebView/WebImmediateActionController.mm:
3623         * WebView/WebView.mm:
3624
3625 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3626
3627         [PAL] Relocate SessionID to root
3628         https://bugs.webkit.org/show_bug.cgi?id=175684
3629
3630         Reviewed by Alex Christensen.
3631
3632         * WebCoreSupport/WebFrameNetworkingContext.mm:
3633
3634 2017-08-17  Andreas Kling  <akling@apple.com>
3635
3636         Disable CSS regions at compile time
3637         https://bugs.webkit.org/show_bug.cgi?id=175630
3638
3639         Reviewed by Antti Koivisto.
3640
3641         * Configurations/FeatureDefines.xcconfig:
3642
3643 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3644
3645         [PAL] Move SessionID into PAL
3646         https://bugs.webkit.org/show_bug.cgi?id=174192
3647
3648         Reviewed by Antti Koivisto.
3649
3650         * Misc/WebCache.mm:
3651         (+[WebCache imageForURL:]):
3652         * WebCoreSupport/WebFrameLoaderClient.h:
3653         * WebCoreSupport/WebFrameLoaderClient.mm:
3654         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3655         * WebCoreSupport/WebFrameNetworkingContext.mm:
3656         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3657         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3658         (WebFrameNetworkingContext::storageSession const):
3659         * WebCoreSupport/WebPlatformStrategies.h:
3660         * WebCoreSupport/WebPlatformStrategies.mm:
3661         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3662         * WebKitPrefix.h:
3663
3664 2017-08-16  Andy Estes  <aestes@apple.com>
3665
3666         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3667         https://bugs.webkit.org/show_bug.cgi?id=175648
3668
3669         Reviewed by Tim Horton.
3670
3671         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3672         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3673         (WebPaymentCoordinatorClient::showPaymentUI):
3674
3675 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3676
3677         [PAL] Move spi/ios and spi/win directories into PAL
3678         https://bugs.webkit.org/show_bug.cgi?id=175171
3679
3680         Reviewed by Antti Koivisto.
3681
3682         * WebCoreSupport/WebFrameLoaderClient.mm:
3683         * WebView/WebView.mm:
3684
3685 2017-08-16  Andy Estes  <aestes@apple.com>
3686
3687         [Payment Request] Add an ENABLE flag and an experimental feature preference
3688         https://bugs.webkit.org/show_bug.cgi?id=175622
3689
3690         Reviewed by Tim Horton.
3691
3692         * Configurations/FeatureDefines.xcconfig:
3693
3694 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3695
3696         [PAL] Move Sleep classes into PAL
3697         https://bugs.webkit.org/show_bug.cgi?id=175456
3698
3699         Reviewed by Ryosuke Niwa.
3700
3701         * WebView/WebFullScreenController.h:
3702
3703 2017-08-15  Youenn Fablet  <youenn@apple.com>
3704
3705         [Cache API] Adding generic support for CacheStorage and Cache methods
3706         https://bugs.webkit.org/show_bug.cgi?id=175455
3707
3708         Reviewed by Chris Dumez.
3709
3710         * WebView/WebView.mm:
3711         (-[WebView _commonInitializationWithFrameName:groupName:]):
3712
3713 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3714
3715         Remove Proximity Events and related code
3716         https://bugs.webkit.org/show_bug.cgi?id=175545
3717
3718         Reviewed by Daniel Bates.
3719
3720         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3721         and other related code.
3722
3723         * Configurations/FeatureDefines.xcconfig:
3724
3725 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3726
3727         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3728         https://bugs.webkit.org/show_bug.cgi?id=175504
3729
3730         Reviewed by Sam Weinig.
3731
3732         * Configurations/FeatureDefines.xcconfig:
3733         * DOM/DOMHTMLFormElement.mm:
3734         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3735         * WebCoreSupport/WebFrameLoaderClient.h:
3736
3737 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3738
3739         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3740         https://bugs.webkit.org/show_bug.cgi?id=175557
3741
3742         Reviewed by Jon Lee.
3743
3744         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3745
3746         * Configurations/FeatureDefines.xcconfig:
3747
3748 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3749
3750         Composition underline color is always black
3751         https://bugs.webkit.org/show_bug.cgi?id=174675
3752
3753         Reviewed by Ryosuke Niwa.
3754
3755         * WebView/WebHTMLView.mm:
3756         (extractUnderlines): If NSUnderlineColorAttributeName
3757         is not present use text color for composition underline.
3758         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3759         for composition underline in the plain text case.
3760
3761 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3762
3763         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3764         https://bugs.webkit.org/show_bug.cgi?id=175474
3765         <rdar://problem/33844628>
3766
3767         Reviewed by Wenson Hsieh.
3768
3769         Replaced the build flag by a runtime flag and disabled the feature by default.
3770
3771         * Configurations/FeatureDefines.xcconfig:
3772         * WebView/WebPreferenceKeysPrivate.h:
3773         * WebView/WebPreferences.mm:
3774         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3775         (-[WebPreferences dataTransferItemsEnabled]): Added.
3776         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3777         * WebView/WebPreferencesPrivate.h:
3778         * WebView/WebView.mm:
3779         (-[WebView _preferencesChanged:]):
3780
3781 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3782
3783         Remove ENABLE_GAMEPAD_DEPRECATED
3784         https://bugs.webkit.org/show_bug.cgi?id=175361
3785
3786         Reviewed by Carlos Garcia Campos.
3787
3788         * Configurations/FeatureDefines.xcconfig:
3789
3790 2017-08-09  Chris Dumez  <cdumez@apple.com>
3791
3792         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3793         https://bugs.webkit.org/show_bug.cgi?id=175401
3794
3795         Reviewed by Brady Eidson.
3796
3797         * WebView/WebPreferenceKeysPrivate.h:
3798         * WebView/WebPreferences.mm:
3799         (+[WebPreferences initialize]):
3800         (-[WebPreferences beaconAPIEnabled]): Deleted.
3801         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3802         * WebView/WebPreferencesPrivate.h:
3803         * WebView/WebView.mm:
3804         (-[WebView _preferencesChanged:]):
3805
3806 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3807
3808         [PAL] Move spi/cocoa and spi/cg directories into PAL
3809         https://bugs.webkit.org/show_bug.cgi?id=175175
3810
3811         Reviewed by Myles C. Maxfield.
3812
3813         * History/WebHistory.mm:
3814         * Misc/WebDownload.mm:
3815         * Misc/WebKitNSStringExtras.mm:
3816         * Plugins/Hosted/NetscapePluginHostManager.mm:
3817         * Plugins/WebPluginDatabase.mm:
3818         * WebCoreSupport/WebFrameLoaderClient.mm:
3819         * WebInspector/WebNodeHighlight.mm:
3820         * WebView/WebHTMLView.mm:
3821         * WebView/WebIndicateLayer.mm:
3822         * WebView/WebView.mm:
3823         * WebView/WebViewData.h:
3824
3825 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3826
3827         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3828         https://bugs.webkit.org/show_bug.cgi?id=175392
3829         <rdar://problem/33783207>
3830
3831         Reviewed by Tim Horton and Megan Gardner.
3832
3833         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3834
3835         * Configurations/FeatureDefines.xcconfig:
3836
3837 2017-08-09  Daniel Bates  <dabates@apple.com>
3838
3839         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3840         https://bugs.webkit.org/show_bug.cgi?id=175247
3841         <rdar://problem/33679804>
3842
3843         Reviewed by Brady Eidson.
3844
3845         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3846         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3847         clients that need to make use of this information at this time. If such a needs comes up
3848         then we can expose API/SPI similar to what we do for WebKit.
3849
3850         * WebCoreSupport/WebFrameLoaderClient.h:
3851         * WebCoreSupport/WebFrameLoaderClient.mm:
3852         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3853
3854 2017-08-08  Brady Eidson  <beidson@apple.com>
3855
3856         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3857         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3858
3859         Reviewed by Andy Estes.
3860
3861         * Misc/WebKitVersionChecks.h:
3862         * WebCoreSupport/WebFrameLoaderClient.mm:
3863         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3864           the app is linked against new WebKit with the new behavior.
3865
3866 2017-08-07  Devin Rousso  <drousso@apple.com>
3867
3868         Web Inspector: Preview Canvas path when viewing a recording
3869         https://bugs.webkit.org/show_bug.cgi?id=174967
3870
3871         Reviewed by Brian Burg.
3872
3873         * WebView/WebPreferenceKeysPrivate.h:
3874         * WebView/WebPreferences.mm:
3875         (+[WebPreferences initialize]):
3876         (-[WebPreferences inspectorAdditionsEnabled]):
3877         (-[WebPreferences setInspectorAdditionsEnabled:]):
3878         * WebView/WebPreferencesPrivate.h:
3879         * WebView/WebView.mm:
3880         (-[WebView _preferencesChanged:]):
3881         Add plumbing for new InspectorAdditions runtime flag.
3882
3883 2017-08-07  Brian Burg  <bburg@apple.com>
3884
3885         Remove CANVAS_PATH compilation guard
3886         https://bugs.webkit.org/show_bug.cgi?id=175207
3887
3888         Reviewed by Sam Weinig.
3889
3890         * Configurations/FeatureDefines.xcconfig:
3891
3892 2017-08-04  Youenn Fablet  <youenn@apple.com>
3893
3894         [Cache API] Add Cache and CacheStorage IDL definitions
3895         https://bugs.webkit.org/show_bug.cgi?id=175201
3896
3897         Reviewed by Brady Eidson.
3898
3899         * WebView/WebPreferenceKeysPrivate.h:
3900         * WebView/WebPreferences.mm:
3901         (+[WebPreferences initialize]):
3902         (-[WebPreferences cacheAPIEnabled]):
3903         (-[WebPreferences setCacheAPIEnabled:]):
3904         * WebView/WebPreferencesPrivate.h:
3905         * WebView/WebView.mm:
3906         (-[WebView _preferencesChanged:]):
3907
3908 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3909
3910         Unreviewed, rolling out r220271.
3911
3912         Rolling out due to Layout Test failing on iOS Simulator.
3913
3914         Reverted changeset:
3915
3916         "Remove STREAMS_API compilation guard"
3917         https://bugs.webkit.org/show_bug.cgi?id=175165
3918         http://trac.webkit.org/changeset/220271
3919
3920 2017-08-04  Youenn Fablet  <youenn@apple.com>
3921
3922         Remove STREAMS_API compilation guard
3923         https://bugs.webkit.org/show_bug.cgi?id=175165
3924
3925         Reviewed by Darin Adler.
3926
3927         * Configurations/FeatureDefines.xcconfig:
3928         * WebView/WebPreferences.mm:
3929         (+[WebPreferences initialize]):
3930         * WebView/WebView.mm:
3931         (-[WebView _preferencesChanged:]):
3932
3933 2017-08-03  Brian Burg  <bburg@apple.com>
3934
3935         Remove ENABLE(WEB_SOCKET) guards
3936         https://bugs.webkit.org/show_bug.cgi?id=167044
3937
3938         Reviewed by Joseph Pecoraro.
3939
3940         * Configurations/FeatureDefines.xcconfig:
3941         * WebView/WebPreferencesPrivate.h:
3942
3943 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3944
3945         [PAL] Move spi/cf directory into PAL
3946         https://bugs.webkit.org/show_bug.cgi?id=175057
3947
3948         Reviewed by Antti Koivisto.
3949
3950         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3951         * Plugins/WebNetscapePluginStream.mm:
3952         * WebCoreSupport/WebFrameNetworkingContext.mm:
3953         * WebView/WebPreferences.mm:
3954         * WebView/WebView.mm:
3955
3956 2017-08-03  Youenn Fablet  <youenn@apple.com>
3957
3958         Remove FETCH_API compilation guard
3959         https://bugs.webkit.org/show_bug.cgi?id=175154
3960
3961         Reviewed by Chris Dumez.
3962
3963         * Configurations/FeatureDefines.xcconfig:
3964         * WebView/WebPreferences.mm:
3965         (+[WebPreferences initialize]):
3966         * WebView/WebView.mm:
3967         (-[WebView _preferencesChanged:]):
3968
3969 2017-08-03  Brady Eidson  <beidson@apple.com>
3970
3971         Add SW IDLs and stub out basic functionality.
3972         https://bugs.webkit.org/show_bug.cgi?id=175115
3973
3974         Reviewed by Chris Dumez.
3975
3976         * Configurations/FeatureDefines.xcconfig:
3977
3978 2017-08-02  Sam Weinig  <sam@webkit.org>
3979
3980         [WebIDL] Convert MutationCallback to be a normal generated callback
3981         https://bugs.webkit.org/show_bug.cgi?id=174140
3982
3983         Reviewed by Darin Adler.
3984
3985         * DOM/DOMDocument.mm:
3986         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3987         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3988         Pass, now necessary, Document to NativeNodeFilter constructor.
3989
3990 2017-08-01  Chris Dumez  <cdumez@apple.com>
3991
3992         Add initial support for navigator.sendBeacon
3993         https://bugs.webkit.org/show_bug.cgi?id=175007
3994         <rdar://problem/33547728>
3995
3996         Reviewed by Sam Weinig.
3997
3998         Add setting to toggle support for the Beacon API (it is disabled by default).
3999
4000         * WebView/WebPreferenceKeysPrivate.h:
4001         * WebView/WebPreferences.mm:
4002         (+[WebPreferences initialize]):
4003         (-[WebPreferences beaconAPIEnabled]):
4004         (-[WebPreferences setBeaconAPIEnabled:]):
4005         * WebView/WebPreferencesPrivate.h:
4006         * WebView/WebView.mm:
4007         (-[WebView _preferencesChanged:]):
4008
4009 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
4010
4011         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
4012         https://bugs.webkit.org/show_bug.cgi?id=174437
4013
4014         Reviewed by Darin Adler.
4015
4016         Remove redundant Web- prefix from classes in WebKit namespace.
4017
4018         * WebView/WebView.mm:
4019         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
4020         * WebView/WebViewData.h:
4021         * WebView/WebViewData.mm:
4022
4023 2017-07-26  Brian Burg  <bburg@apple.com>
4024
4025         Remove WEB_TIMING feature flag
4026         https://bugs.webkit.org/show_bug.cgi?id=174795
4027
4028         Reviewed by Alex Christensen.
4029
4030         * Configurations/FeatureDefines.xcconfig:
4031
4032 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
4033
4034         Async image decoding for large images should be disabled after the first time a tile is painted
4035         https://bugs.webkit.org/show_bug.cgi?id=174451
4036         <rdar://problem/31246421>
4037
4038         Reviewed by Simon Fraser.
4039
4040         * WebView/WebFrame.mm:
4041         (-[WebFrame _paintBehaviorForDestinationContext:]):
4042         (-[WebFrame _drawRect:contentsOnly:]):
4043         * WebView/WebHTMLView.mm:
4044         (imageFromRect):
4045
4046 2017-07-23  Darin Adler  <darin@apple.com>
4047
4048         More NeverDestroyed and related cleanup
4049         https://bugs.webkit.org/show_bug.cgi?id=174745
4050
4051         Reviewed by Alex Christensen.
4052
4053         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
4054         for names that aren't even used in this file.
4055         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
4056         -[NSArray arrayWithObject:].
4057         (-[DOMNode absoluteQuads]): Ditto.
4058         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
4059         of writing out various types.
4060         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
4061         syntax instea of -[NSArray arrayWithObject:].
4062         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
4063         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
4064         of writing out various types.
4065         (-[DOMHTMLImageElement mimeType]): Ditto.
4066
4067 2017-07-24  Chris Dumez  <cdumez@apple.com>
4068
4069         ExceptionCode enumeration should use modern exception names
4070         https://bugs.webkit.org/show_bug.cgi?id=174794
4071
4072         Reviewed by Geoffrey Garen.
4073
4074         * DOM/ExceptionHandlers.mm:
4075         (raiseNotSupportedErrorException):
4076
4077 2017-07-23  Chris Dumez  <cdumez@apple.com>
4078
4079         Drop ExceptionCodeDescription class
4080         https://bugs.webkit.org/show_bug.cgi?id=174757
4081
4082         Reviewed by Darin Adler.
4083
4084         Stop using ExceptionCodeDescription.
4085
4086         * DOM/ExceptionHandlers.mm:
<