-apple-trailing-word is needed for browser detection
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         -apple-trailing-word is needed for browser detection
4         https://bugs.webkit.org/show_bug.cgi?id=196575
5
6         Unreviewed.
7
8         * Configurations/FeatureDefines.xcconfig:
9
10 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
11
12         Remove support for -apple-trailing-word
13         https://bugs.webkit.org/show_bug.cgi?id=196525
14
15         Reviewed by Zalan Bujtas.
16
17         This CSS property is nonstandard and not used.
18
19         * Configurations/FeatureDefines.xcconfig:
20
21 2019-04-01  Alex Christensen  <achristensen@webkit.org>
22
23         Add SPI to canonicalize NSURLs with WTF::URL
24         https://bugs.webkit.org/show_bug.cgi?id=196415
25         <rdar://problem/44980271>
26
27         Reviewed by Darin Adler.
28
29         * Misc/WebNSURLExtras.h:
30         * Misc/WebNSURLExtras.mm:
31         (-[NSURL _webkit_canonicalize_with_wtf]):
32         _webkit_canonicalize is old and changing it causes strange bugs like rdar://problem/5315926
33         Instead, make a new version that uses WTF::URL to canonicalize an NSURL.
34
35 2019-03-31  Sam Weinig  <weinig@apple.com>
36
37         Remove more i386 specific configurations
38         https://bugs.webkit.org/show_bug.cgi?id=196430
39
40         Reviewed by Alexey Proskuryakov.
41
42         * Configurations/FeatureDefines.xcconfig:
43         ENABLE_WEB_AUTHN_macosx can now be enabled unconditionally on macOS.
44
45 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
46
47         Delete WebMetal implementation in favor of WebGPU
48         https://bugs.webkit.org/show_bug.cgi?id=195418
49
50         Reviewed by Dean Jackson.
51
52         * Configurations/FeatureDefines.xcconfig:
53         * WebView/WebPreferenceKeysPrivate.h:
54         * WebView/WebPreferences.mm:
55         (+[WebPreferences initialize]):
56         (-[WebPreferences webMetalEnabled]): Deleted.
57         (-[WebPreferences setWebMetalEnabled:]): Deleted.
58         * WebView/WebPreferencesPrivate.h:
59         * WebView/WebView.mm:
60         (-[WebView _preferencesChanged:]):
61
62 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
63
64         Implement ResizeObserver.
65         https://bugs.webkit.org/show_bug.cgi?id=157743
66
67         Reviewed by Simon Fraser.
68
69         * Configurations/FeatureDefines.xcconfig:
70         * WebView/WebPreferenceKeysPrivate.h:
71         * WebView/WebPreferences.mm:
72         (+[WebPreferences initialize]):
73         (-[WebPreferences resizeObserverEnabled]):
74         (-[WebPreferences setResizeObserverEnabled:]):
75         * WebView/WebPreferencesPrivate.h:
76         * WebView/WebView.mm:
77         (-[WebView _preferencesChanged:]):
78         (-[WebView _flushCompositingChanges]): checkResizeObservations() in the begining.
79
80 2019-03-27  Ryosuke Niwa  <rniwa@webkit.org>
81
82         [macOS] Select element doesn't show popup if select element had lost focus while popup was previosuly shown
83         https://bugs.webkit.org/show_bug.cgi?id=196336
84
85         Reviewed by Tim Horton.
86
87         Fixed the bug that we were not actually dismissing the popup in PopupMenuMac::hide as done in WebKit2.
88
89         Unfortunately no new tests since intenals.isSelectPopupVisible would always return false in WebKit1.
90
91         * WebCoreSupport/PopupMenuMac.mm:
92         (PopupMenuMac::hide):
93
94 2019-03-25  Andy Estes  <aestes@apple.com>
95
96         [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
97         https://bugs.webkit.org/show_bug.cgi?id=194964
98         <rdar://problem/48279441>
99
100         Reviewed by Alex Christensen.
101
102         The WebDataSource._quickLookContent SPI accidentally relied on PreviewLoaders being leaked
103         to keep the temporary file referenced by WebQuickLookFileNameKey in existence. Since
104         PreviewLoaders are now being deleted properly, we teach WebDataSource to keep the
105         PreviewLoaderClient alive for its lifetime. This ensures that as long as
106         WebDataSource._quickLookContent can be called, the associated temp file will not be deleted
107         by WebKit.
108
109         * WebCoreSupport/WebFrameLoaderClient.mm:
110         (WebFrameLoaderClient::createPreviewLoaderClient):
111         * WebView/WebDataSource.mm:
112         (-[WebDataSource _quickLookPreviewLoaderClient]):
113         (-[WebDataSource _setQuickLookPreviewLoaderClient:]):
114         * WebView/WebDataSourceInternal.h:
115
116 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
117
118         Remove NavigatorContentUtils in WebCore/Modules
119         https://bugs.webkit.org/show_bug.cgi?id=196070
120
121         Reviewed by Alex Christensen.
122
123         NavigatorContentUtils was to support the custom scheme spec [1].
124         However, in WebKit side, no port has supported the feature in
125         WebKit layer after EFL port was removed. So there has been the
126         only IDL implementation of the NavigatorContentUtils in WebCore.
127         So we don't need to keep the implementation in WebKit.
128
129         * Configurations/FeatureDefines.xcconfig:
130
131 2019-03-22  Keith Rollin  <krollin@apple.com>
132
133         Enable ThinLTO support in Production builds
134         https://bugs.webkit.org/show_bug.cgi?id=190758
135         <rdar://problem/45413233>
136
137         Reviewed by Daniel Bates.
138
139         Enable building with Thin LTO in Production when using Xcode 10.2 or
140         later. This change results in a 1.45% progression in PLT5. Full
141         Production build times increase about 2-3%. Incremental build times
142         are more severely affected, and so LTO is not enabled for local
143         engineering builds.
144
145         LTO is enabled only on macOS for now, until rdar://problem/49013399,
146         which affects ARM builds, is fixed.
147
148         To change the LTO setting when building locally:
149
150         - If building with `make`, specify WK_LTO_MODE={none,thin,full} on the
151           command line.
152         - If building with `build-webkit`, specify --lto-mode={none,thin,full}
153           on the command line.
154         - If building with `build-root`, specify --lto={none,thin,full} on the
155           command line.
156         - If building with Xcode, create a LocalOverrides.xcconfig file at the
157           top level of your repository directory (if needed) and define
158           WK_LTO_MODE to full, thin, or none.
159
160         * Configurations/Base.xcconfig:
161
162 2019-03-21  Andy Estes  <aestes@apple.com>
163
164         [iOS] Apple Pay should be available in documents with no user agent scripts
165         https://bugs.webkit.org/show_bug.cgi?id=196061
166         <rdar://problem/48649391>
167
168         Reviewed by Brady Eidson.
169
170         * WebView/WebFrame.mm:
171         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
172
173 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
174
175         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
176         https://bugs.webkit.org/show_bug.cgi?id=196049
177
178         Reviewed by Tim Horton.
179
180         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
181         overflow scrolling in general, so rename it.
182
183         * Configurations/FeatureDefines.xcconfig:
184
185 2019-03-13  Dean Jackson  <dino@apple.com>
186
187         Block all plugins smaller than 5x5px
188         https://bugs.webkit.org/show_bug.cgi?id=195702
189         <rdar://problem/28435204>
190
191         Reviewed by Sam Weinig.
192
193         Removed a function that was never being called.
194
195         * WebCoreSupport/WebFrameLoaderClient.h:
196         * WebCoreSupport/WebFrameLoaderClient.mm:
197         (WebFrameLoaderClient::recreatePlugin): Deleted.
198
199 2019-03-13  Keith Rollin  <krollin@apple.com>
200
201         Add support for new StagedFrameworks layout
202         https://bugs.webkit.org/show_bug.cgi?id=195543
203
204         Reviewed by Alexey Proskuryakov.
205
206         When creating the WebKit layout for out-of-band Safari/WebKit updates,
207         use an optional path prefix when called for.
208
209         * Configurations/WebKitLegacy.xcconfig:
210
211 2019-03-12  Ryosuke Niwa  <rniwa@webkit.org>
212
213         Remove a site specific hack for AppleConnect plugin
214         https://bugs.webkit.org/show_bug.cgi?id=195643
215
216         Reviewed by Simon Fraser.
217
218         r66437 added a workaround for AppleConnect plugin.
219
220         Remove this code since Safari doesn't even use WebKitLegacy anymore,
221         and other WebKit clients support AppleConnect plugins.
222
223         * WebCoreSupport/WebFrameLoaderClient.mm:
224         (WebFrameLoaderClient::createPlugin):
225
226 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
227
228         Unreviewed, rolling out r242688, r242643, r242624.
229
230         Caused multiple layout test failures and crashes on iOS and macOS.
231
232         Reverted changeset:
233
234         "requestAnimationFrame should execute before the next frame"
235         https://bugs.webkit.org/show_bug.cgi?id=177484
236         https://trac.webkit.org/changeset/242624/webkit
237
238         * WebView/WebView.mm:
239         (-[WebView _viewWillDrawInternal]):
240
241 2019-03-09  Andy Estes  <aestes@apple.com>
242
243         [Apple Pay] CanMakePaymentsWithActiveCard and OpenPaymentSetup should be async messages
244         https://bugs.webkit.org/show_bug.cgi?id=195526
245         <rdar://problem/48745636>
246
247         Reviewed by Chris Dumez.
248
249         * WebCoreSupport/WebPaymentCoordinatorClient.h:
250         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
251         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
252         (WebPaymentCoordinatorClient::openPaymentSetup):
253
254 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
255
256         requestAnimationFrame should execute before the next frame
257         https://bugs.webkit.org/show_bug.cgi?id=177484
258
259         Reviewed by Simon Fraser.
260
261         * WebView/WebView.mm:
262         (-[WebView _viewWillDrawInternal]):
263         Call Page::renderingUpdate() which implements  "Update the rendering"
264         step of the HTML Event Loop specification.
265
266 2019-03-07  Zalan Bujtas  <zalan@apple.com>
267
268         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
269         https://bugs.webkit.org/show_bug.cgi?id=195353
270         <rdar://problem/48626394>
271
272         Reviewed by Simon Fraser.
273
274         * WebView/WebPreferenceKeysPrivate.h:
275         * WebView/WebPreferences.mm:
276         (+[WebPreferences initialize]):
277         (-[WebPreferences contentChangeObserverEnabled]):
278         (-[WebPreferences setContentChangeObserverEnabled:]):
279         * WebView/WebPreferencesPrivate.h:
280         * WebView/WebView.mm:
281         (-[WebView _preferencesChanged:]):
282
283 2019-03-06  Sam Weinig  <sam@webkit.org>
284
285         WebKitLegacy does not need to generate an export file for i386 anymore
286         https://bugs.webkit.org/show_bug.cgi?id=195380
287
288         Reviewed by Dan Bernstein.
289
290         * Configurations/WebKitLegacy.xcconfig:
291         Simplify EXPORTED_SYMBOLS_FILE down to just a single path to a generated file.
292         It still needs to be generated, since we are concatenating the shared exports
293         file with a macOS or iOS specific one.
294
295         * WebKit.mac.exp:
296         Remove i386 specific symbols that we were previously stripping.
297
298 2019-03-06  Rob Buis  <rbuis@igalia.com>
299
300         Consider supporting the `referrerpolicy` attribute.
301         https://bugs.webkit.org/show_bug.cgi?id=179053
302
303         Reviewed by Darin Adler.
304
305         Add a runtime flag for referrerpolicy attribute.
306
307         * WebView/WebPreferenceKeysPrivate.h:
308         * WebView/WebPreferences.mm:
309         (+[WebPreferences initialize]):
310         (-[WebPreferences referrerPolicyAttributeEnabled]):
311         (-[WebPreferences setReferrerPolicyAttributeEnabled:]):
312         * WebView/WebPreferencesPrivate.h:
313         * WebView/WebView.mm:
314         (-[WebView _preferencesChanged:]):
315
316 2019-03-03  Tim Horton  <timothy_horton@apple.com>
317
318         Remove some more unused 32-bit code
319         https://bugs.webkit.org/show_bug.cgi?id=195255
320
321         Reviewed by Darin Adler.
322
323         * Plugins/WebNetscapePluginEventHandler.mm:
324         (WebNetscapePluginEventHandler::create):
325         * Plugins/WebNetscapePluginView.h:
326         * Plugins/WebNetscapePluginView.mm:
327         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
328         (-[WebNetscapePluginView restorePortState:]):
329         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
330         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
331         (-[WebNetscapePluginView updateAndSetWindow]):
332         (-[WebNetscapePluginView setWindowIfNecessary]):
333         (-[WebNetscapePluginView createPlugin]):
334         (-[WebNetscapePluginView fini]):
335         (-[WebNetscapePluginView drawRect:]):
336         (-[WebNetscapePluginView invalidateRegion:]):
337         (-[WebNetscapePluginView getVariable:value:]):
338         (-[WebNetscapePluginView setVariable:value:]):
339         (isDrawingModelQuickDraw): Deleted.
340         (-[WebNetscapePluginView fixWindowPort]): Deleted.
341         (getQDPixelFormatForBitmapContext): Deleted.
342         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
343         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
344         * WebView/WebDelegateImplementationCaching.mm:
345
346 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
347
348         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
349         https://bugs.webkit.org/show_bug.cgi?id=195053
350         <rdar://problem/48134710>
351
352         Reviewed by Ryosuke Niwa.
353
354         * WebCoreSupport/WebEditorClient.h:
355
356 2019-03-01  Tim Horton  <timothy_horton@apple.com>
357
358         Remove unused code in WebKitLegacy
359         https://bugs.webkit.org/show_bug.cgi?id=189614
360
361         Reviewed by Simon Fraser.
362
363         * Carbon/CarbonUtils.h: Removed.
364         * Carbon/CarbonUtils.m: Removed.
365         * Carbon/CarbonWindowAdapter.h: Removed.
366         * Carbon/CarbonWindowAdapter.mm: Removed.
367         * Carbon/CarbonWindowContentView.h: Removed.
368         * Carbon/CarbonWindowContentView.m: Removed.
369         * Carbon/CarbonWindowFrame.h: Removed.
370         * Carbon/CarbonWindowFrame.m: Removed.
371         * Carbon/HIViewAdapter.h: Removed.
372         * Carbon/HIViewAdapter.m: Removed.
373         * Carbon/HIWebView.h: Removed.
374         * Carbon/HIWebView.mm: Removed.
375         * Configurations/WebKitLegacy.xcconfig:
376         * WebKit.mac.exp:
377
378 2019-03-01  Justin Fan  <justin_fan@apple.com>
379
380         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
381         https://bugs.webkit.org/show_bug.cgi?id=195191
382
383         Rubber-stamped by Dean Jackson.
384
385         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
386
387         * Configurations/FeatureDefines.xcconfig:
388
389 2019-02-28  Antoine Quint  <graouts@apple.com>
390
391         Enable the Pointer Events runtime flag by default
392         https://bugs.webkit.org/show_bug.cgi?id=195156
393
394         Reviewed by Dean Jackson.
395
396         * WebView/WebPreferences.mm:
397         (+[WebPreferences initialize]):
398
399 2019-02-28  Justin Fan  <justin_fan@apple.com>
400
401         [Web GPU] Enable Web GPU only on 64-bit
402         https://bugs.webkit.org/show_bug.cgi?id=195139
403
404         Because Metal is only supported on 64 bit apps.
405
406         Unreviewed build fix.
407
408         * Configurations/FeatureDefines.xcconfig:
409
410 2019-02-27  Antoine Quint  <graouts@apple.com>
411
412         Support Pointer Events on macOS
413         https://bugs.webkit.org/show_bug.cgi?id=195008
414         <rdar://problem/47454419>
415
416         Reviewed by Dean Jackson.
417
418         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
419
420         * Configurations/FeatureDefines.xcconfig:
421         * WebView/WebPreferenceKeysPrivate.h:
422         * WebView/WebPreferences.mm:
423         (+[WebPreferences initialize]):
424         (-[WebPreferences pointerEventsEnabled]):
425         (-[WebPreferences setPointerEventsEnabled:]):
426         * WebView/WebPreferencesPrivate.h:
427         * WebView/WebView.mm:
428         (-[WebView _preferencesChanged:]):
429
430 2019-02-23  Keith Miller  <keith_miller@apple.com>
431
432         Add new mac target numbers
433         https://bugs.webkit.org/show_bug.cgi?id=194955
434
435         Reviewed by Tim Horton.
436
437         * Configurations/Base.xcconfig:
438         * Configurations/DebugRelease.xcconfig:
439
440 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
441
442         Hardcode Visual Viewports on everywhere except iOS WK1
443         https://bugs.webkit.org/show_bug.cgi?id=194928
444
445         Reviewed by Zalan Bujtas.
446
447         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
448         change the default value of the Setting to 'true', and hardcode WebView on iOS to
449         set it to false. The setting has shipped for several years and there's no need to turn
450         it off now.
451
452         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
453         Visual Viewports are not enabled.
454         
455         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
456         that only runs in WK2
457
458         * WebView/WebPreferenceKeysPrivate.h:
459         * WebView/WebPreferences.mm:
460         (+[WebPreferences initialize]):
461         (-[WebPreferences visualViewportEnabled]): Deleted.
462         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
463         * WebView/WebPreferencesPrivate.h:
464         * WebView/WebView.mm:
465         (-[WebView _preferencesChanged:]):
466
467 2019-02-21  Darin Adler  <darin@apple.com>
468
469         Some refinements for Node and Document
470         https://bugs.webkit.org/show_bug.cgi?id=194764
471
472         Reviewed by Ryosuke Niwa.
473
474         * DOM/DOMDocument.mm:
475         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
476         through to WebCore or even looking at the arguments.
477         (-[DOMDocument getOverrideStyle::]): Ditto.
478
479 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
480
481         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
482         https://bugs.webkit.org/show_bug.cgi?id=194670
483         <rdar://problem/39066529>
484
485         Reviewed by Tim Horton.
486
487         * WebCoreSupport/WebEditorClient.h:
488         * WebCoreSupport/WebEditorClient.mm:
489         (WebEditorClient::replacementURLForResource): Deleted.
490         * WebCoreSupport/WebPlatformStrategies.h:
491         * WebCoreSupport/WebPlatformStrategies.mm:
492         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
493
494 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
495
496         Add MSE logging configuration
497         https://bugs.webkit.org/show_bug.cgi?id=194719
498         <rdar://problem/48122151>
499
500         Reviewed by Joseph Pecoraro.
501
502         * WebCoreSupport/WebChromeClient.mm:
503         (stringForMessageSource): Recognize the MSE message source.
504
505 2019-02-17  David Kilzer  <ddkilzer@apple.com>
506
507         Unreviewed, rolling out r241620.
508
509         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
510         (Requested by ddkilzer on #webkit.)
511
512         Reverted changeset:
513
514         "[WTF] Add environment variable helpers"
515         https://bugs.webkit.org/show_bug.cgi?id=192405
516         https://trac.webkit.org/changeset/241620
517
518 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
519
520         [WTF] Add environment variable helpers
521         https://bugs.webkit.org/show_bug.cgi?id=192405
522
523         Reviewed by Michael Catanzaro.
524
525         * WebView/WebView.mm:
526         (-[WebView _initWithFrame:frameName:groupName:]):
527         Utilize WTF::Environment where possible.
528
529 2019-02-15  Brian Burg  <bburg@apple.com>
530
531         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
532         https://bugs.webkit.org/show_bug.cgi?id=194411
533         <rdar://problem/47787614>
534
535         Reviewed by Joseph Pecoraro.
536
537         * Configurations/WebKitLegacy.xcconfig:
538         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
539
540         * WebCoreSupport/WebInspectorClient.mm:
541         (WebInspectorFrontendClient::localizedStringsURL):
542         (-[WebInspectorWindowController inspectorPagePath]):
543         (-[WebInspectorWindowController inspectorTestPagePath]):
544         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
545
546 2019-02-15  Commit Queue  <commit-queue@webkit.org>
547
548         Unreviewed, rolling out r241559 and r241566.
549         https://bugs.webkit.org/show_bug.cgi?id=194710
550
551         Causes layout test crashes under GuardMalloc (Requested by
552         ryanhaddad on #webkit).
553
554         Reverted changesets:
555
556         "[WTF] Add environment variable helpers"
557         https://bugs.webkit.org/show_bug.cgi?id=192405
558         https://trac.webkit.org/changeset/241559
559
560         "Unreviewed build fix for WinCairo Debug after r241559."
561         https://trac.webkit.org/changeset/241566
562
563 2019-02-15  Truitt Savell  <tsavell@apple.com>
564
565         Unreviewed, rolling out r241564.
566
567         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
568
569         Reverted changeset:
570
571         "[Mac] WebInspectorUI.framework does not need to be soft-
572         linked anymore"
573         https://bugs.webkit.org/show_bug.cgi?id=194411
574         https://trac.webkit.org/changeset/241564
575
576 2019-02-14  Brian Burg  <bburg@apple.com>
577
578         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
579         https://bugs.webkit.org/show_bug.cgi?id=194411
580         <rdar://problem/47787614>
581
582         Reviewed by Joseph Pecoraro.
583
584         * Configurations/WebKitLegacy.xcconfig:
585         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
586
587         * WebCoreSupport/WebInspectorClient.mm:
588         (WebInspectorFrontendClient::localizedStringsURL):
589         (-[WebInspectorWindowController inspectorPagePath]):
590         (-[WebInspectorWindowController inspectorTestPagePath]):
591         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
592
593 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
594
595         [WTF] Add environment variable helpers
596         https://bugs.webkit.org/show_bug.cgi?id=192405
597
598         Reviewed by Michael Catanzaro.
599
600         * WebView/WebView.mm:
601         (-[WebView _initWithFrame:frameName:groupName:]):
602         Utilize WTF::Environment where possible.
603
604 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
605
606         Allow pages to trigger programmatic paste from script on iOS
607         https://bugs.webkit.org/show_bug.cgi?id=194271
608         <rdar://problem/47808810>
609
610         Reviewed by Ryosuke Niwa.
611
612         See WebCore and WebKit ChangeLogs for more details.
613
614         * WebCoreSupport/WebEditorClient.h:
615
616 2019-02-12  Andy Estes  <aestes@apple.com>
617
618         [iOSMac] Enable Parental Controls Content Filtering
619         https://bugs.webkit.org/show_bug.cgi?id=194521
620         <rdar://39732376>
621
622         Reviewed by Tim Horton.
623
624         * Configurations/FeatureDefines.xcconfig:
625
626 2019-02-06  Andy Estes  <aestes@apple.com>
627
628         [Payment Request] It should be possible to require a phonetic name for shipping contacts
629         https://bugs.webkit.org/show_bug.cgi?id=194311
630         <rdar://46733045>
631
632         Reviewed by Alex Christensen.
633
634         * WebCoreSupport/WebPaymentCoordinatorClient.h:
635         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
636         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
637
638 2019-02-04  Said Abou-Hallawa  <said@apple.com>
639
640         [CG] Enable setAdditionalSupportedImageTypes for WK1
641         https://bugs.webkit.org/show_bug.cgi?id=194190
642
643         Reviewed by Tim Horton.
644
645         1. Define the preferences key AdditionalSupportedImageTypes.
646         2. Add additionalSupportedImageTypes as a private preference property.
647         3. Define the setter and the getter of the property.
648         4. Add function to convert from an id to an array of strings.
649         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
650
651         * WebView/WebPreferenceKeysPrivate.h:
652         * WebView/WebPreferences.mm:
653         (-[WebPreferences _stringArrayValueForKey:]):
654         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
655         (-[WebPreferences setAdditionalSupportedImageTypes:]):
656         (-[WebPreferences additionalSupportedImageTypes]):
657         * WebView/WebPreferencesPrivate.h:
658         * WebView/WebView.mm:
659         (-[WebView _preferencesChanged:]):
660
661 2019-02-04  Timothy Hatcher  <timothy@apple.com>
662
663         Add WebView SPI to temporarily force light or dark appearance on a page.
664         https://bugs.webkit.org/show_bug.cgi?id=194230
665
666         Reviewed by Tim Horton.
667
668         * WebView/WebView.mm:
669         (-[WebView _useDarkAppearance:]): Added.
670         (-[WebView _setUseDarkAppearance:]): Added.
671         * WebView/WebViewPrivate.h:
672
673 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
674
675         PageOverlayController's layers should be created lazily
676         https://bugs.webkit.org/show_bug.cgi?id=194199
677         rdar://problem/46571593
678
679         Reviewed by Tim Horton.
680
681         * WebCoreSupport/WebChromeClient.h:
682         * WebCoreSupport/WebChromeClient.mm:
683         (WebChromeClient::attachViewOverlayGraphicsLayer):
684
685 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
686
687         Make setNeedsLayout on the root more explicitly about triggering its side-effects
688         https://bugs.webkit.org/show_bug.cgi?id=194198
689
690         Reviewed by Antti Koivisto.
691
692         Call the newly named functions.
693
694         * WebView/WebFrame.mm:
695         (-[WebFrame setNeedsLayout]):
696         * WebView/WebHTMLView.mm:
697         (-[WebHTMLView setNeedsLayout:]):
698
699 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
700
701         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
702         https://bugs.webkit.org/show_bug.cgi?id=194189
703
704         Reviewed by Geoffrey Garen.
705
706         Pass the policy check identifier around functions and store it in WebFramePolicyListener
707         so that we can send it back to WebCore with the navigation policy decision.
708
709         * WebCoreSupport/WebFrameLoaderClient.h:
710         * WebCoreSupport/WebFrameLoaderClient.mm:
711         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
712         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
713         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
714         (WebFrameLoaderClient::dispatchWillSubmitForm):
715         (WebFrameLoaderClient::setUpPolicyListener):
716         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
717         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
718         (-[WebFramePolicyListener invalidate]):
719         (-[WebFramePolicyListener dealloc]):
720         (-[WebFramePolicyListener receivedPolicyDecision:]):
721         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
722         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
723
724 2019-01-31  Alex Christensen  <achristensen@webkit.org>
725
726         Revert r238819 which is unneeded and caused a performance regression.
727         https://bugs.webkit.org/show_bug.cgi?id=192272
728         <rdar://problem/46664625>
729
730         * WebCoreSupport/WebFrameLoaderClient.h:
731         * WebCoreSupport/WebFrameLoaderClient.mm:
732         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
733
734 2019-01-28  Devin Rousso  <drousso@apple.com>
735
736         Web Inspector: provide a way to edit page WebRTC settings on a remote target
737         https://bugs.webkit.org/show_bug.cgi?id=193863
738         <rdar://problem/47572764>
739
740         Reviewed by Joseph Pecoraro.
741
742         * WebView/WebView.mm:
743         (-[WebView _preferencesChanged:]):
744         Add page-level settings for WebRTC preferences.
745
746 2019-01-28  Andy Estes  <aestes@apple.com>
747
748         [watchOS] Enable Parental Controls content filtering
749         https://bugs.webkit.org/show_bug.cgi?id=193939
750         <rdar://problem/46641912>
751
752         Reviewed by Ryosuke Niwa.
753
754         * Configurations/FeatureDefines.xcconfig:
755
756 2019-01-28  Timothy Hatcher  <timothy@apple.com>
757
758         Make it easier for non-Apple ports to enable dark mode CSS support.
759         https://bugs.webkit.org/show_bug.cgi?id=193882
760
761         Reviewed by Megan Gardner.
762
763         * WebView/WebView.mm:
764         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
765         (-[WebView _effectiveAppearanceIsDark]): Ditto.
766
767 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
768
769         AX: Introduce a static accessibility tree
770         https://bugs.webkit.org/show_bug.cgi?id=193348
771         <rdar://problem/47203295>
772
773         Reviewed by Ryosuke Niwa.
774
775         * Configurations/FeatureDefines.xcconfig:
776
777 2019-01-25  Keith Rollin  <krollin@apple.com>
778
779         Update WebKitAdditions.xcconfig with correct order of variable definitions
780         https://bugs.webkit.org/show_bug.cgi?id=193793
781         <rdar://problem/47532439>
782
783         Reviewed by Alex Christensen.
784
785         XCBuild changes the way xcconfig variables are evaluated. In short,
786         all config file assignments are now considered in part of the
787         evaluation. When using the new build system and an .xcconfig file
788         contains multiple assignments of the same build setting:
789
790         - Later assignments using $(inherited) will inherit from earlier
791           assignments in the xcconfig file.
792         - Later assignments not using $(inherited) will take precedence over
793           earlier assignments. An assignment to a more general setting will
794           mask an earlier assignment to a less general setting. For example,
795           an assignment without a condition ('FOO = bar') will completely mask
796           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
797
798         This affects some of our .xcconfig files, in that sometimes platform-
799         or sdk-specific definitions appear before the general definitions.
800         Under the new evaluations rules, the general definitions alway take
801         effect because they always overwrite the more-specific definitions. The
802         solution is to swap the order, so that the general definitions are
803         established first, and then conditionally overwritten by the
804         more-specific definitions.
805
806         * Configurations/Version.xcconfig:
807         * Configurations/WebKitLegacy.xcconfig:
808
809 2019-01-25  David Kilzer  <ddkilzer@apple.com>
810
811         Move soft-linking of Lookup.framework out of LookupSPI.h
812         <https://webkit.org/b/193815>
813
814         Reviewed by Tim Horton.
815
816         * WebView/WebImmediateActionController.mm:
817         (-[WebImmediateActionController _animationControllerForText]):
818         * WebView/WebView.mm:
819         (-[WebView _prepareForDictionaryLookup]):
820         - Move soft-linking to LookupSoftLink.{h,mm}.
821
822 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
823
824         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
825         https://bugs.webkit.org/show_bug.cgi?id=193829
826
827         Reviewed by Tim Horton.
828
829         * WebCoreSupport/WebDragClient.mm:
830         (WebDragClient::didConcludeEditDrag):
831         * WebView/WebView.mm:
832         (-[WebView _requestStartDataInteraction:globalPosition:]):
833         (-[WebView _didConcludeEditDrag]):
834         (-[WebView _didConcludeEditDataInteraction]): Deleted.
835         * WebView/WebViewInternal.h:
836
837 2019-01-24  John Wilander  <wilander@apple.com>
838
839         Add Ad Click Attribution as an internal/experimental feature
840         https://bugs.webkit.org/show_bug.cgi?id=193685
841         <rdar://problem/47450399>
842
843         Reviewed by Brent Fulgham.
844
845         * WebView/WebPreferenceKeysPrivate.h:
846         * WebView/WebPreferences.mm:
847         (+[WebPreferences initialize]):
848         (-[WebPreferences adClickAttributionEnabled]):
849         (-[WebPreferences setAdClickAttributionEnabled:]):
850             Added support for experimental ad click attribution.
851         * WebView/WebPreferencesPrivate.h:
852         * WebView/WebView.mm:
853         (-[WebView _preferencesChanged:]):
854
855 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
856
857         Move FileSystem to WTF
858         https://bugs.webkit.org/show_bug.cgi?id=193602
859
860         Reviewed by Yusuke Suzuki.
861
862         * Misc/WebNSFileManagerExtras.mm:
863         * Storage/WebDatabaseProvider.mm:
864         * WebView/WebView.mm:
865
866 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
867
868         Fix the Apple Internal build. See <rdar://problem/47491383>.
869
870         Rubber-stamped by Tim Horton.
871
872         * WebCoreSupport/WebFrameLoaderClient.mm:
873
874 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
875
876         Clean up USE(WEB_THREAD)
877         https://bugs.webkit.org/show_bug.cgi?id=193698
878
879         Rubber-stamped by Tim Horton.
880
881         * Misc/WebCache.mm:
882         (+[WebCache emptyInMemoryResources]):
883         * WebCoreSupport/WebFrameLoaderClient.mm:
884         (-[WebFramePolicyListener use]):
885         * WebCoreSupport/WebGeolocationClient.mm:
886         (-[WebGeolocationPolicyListener allow]):
887         (-[WebGeolocationPolicyListener deny]):
888         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
889         * WebView/WebFrame.mm:
890         (-[WebFrame deviceOrientationChanged]):
891         * WebView/WebHTMLView.mm:
892         (hardwareKeyboardAvailabilityChangedCallback):
893         * WebView/WebView.mm:
894         (+[WebView _releaseMemoryNow]):
895         (+[WebView willEnterBackgroundWithCompletionHandler:]):
896         (-[WebView updateLayoutIgnorePendingStyleSheets]):
897         (-[WebView _dispatchUnloadEvent]):
898         (-[WebView _close]):
899         (-[WebView _preferencesChangedNotification:]):
900         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
901         (-[WebView goBack]):
902         (-[WebView goForward]):
903         (+[WebView _cacheModelChangedNotification:]):
904         (-[WebView stopLoading:]):
905         (-[WebView stopLoadingAndClear]):
906         (-[WebView reload:]):
907         (WebInstallMemoryPressureHandler):
908
909 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
910
911         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
912         https://bugs.webkit.org/show_bug.cgi?id=193706
913         <rdar://problem/44807048>
914
915         Reviewed by Ryosuke Niwa.
916
917         Use UndoStep::label().
918
919         * WebCoreSupport/WebEditorClient.h:
920         * WebCoreSupport/WebEditorClient.mm:
921         (-[WebUndoStep initWithUndoStep:]):
922         (+[WebUndoStep stepWithUndoStep:]):
923         (WebEditorClient::registerUndoOrRedoStep):
924         (WebEditorClient::registerUndoStep):
925         (WebEditorClient::registerRedoStep):
926
927 2019-01-22  Alex Christensen  <achristensen@webkit.org>
928
929         Move NetworkStorageSession ownership to NetworkProcess
930         https://bugs.webkit.org/show_bug.cgi?id=193580
931
932         Reviewed by Geoff Garen.
933
934         * Misc/WebCache.mm:
935         (+[WebCache clearCachedCredentials]):
936         * Misc/WebDownload.mm:
937         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
938         * Plugins/WebBaseNetscapePluginView.mm:
939         (WebKit::getAuthenticationInfo):
940         * WebCoreSupport/WebFrameNetworkingContext.mm:
941         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
942         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
943         (WebFrameNetworkingContext::storageSession const):
944         * WebView/WebPreferences.mm:
945         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
946         (+[WebPreferences _clearNetworkLoaderSession]):
947         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
948
949 2019-01-22  Daniel Bates  <dabates@apple.com>
950
951         [iOS] Interpret text key commands on keydown and app key commands on keypress
952         https://bugs.webkit.org/show_bug.cgi?id=192897
953         <rdar://problem/46857378>
954
955         Reviewed by Brent Fulgham.
956
957         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
958         is false) and keypress (isCharEvent is true), respectively.
959
960         * WebView/WebHTMLView.mm:
961         (-[WebHTMLView _handleEditingKeyEvent:]):
962
963 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
964
965         [css-logical] Implement flow-relative margin, padding and border shorthands
966         https://bugs.webkit.org/show_bug.cgi?id=188697
967
968         Reviewed by Simon Fraser and Antti Koivisto.
969
970         Add CSSLogicalEnabled runtime flag.
971
972         * WebView/WebPreferenceKeysPrivate.h:
973         * WebView/WebPreferences.mm:
974         (+[WebPreferences initialize]):
975         (-[WebPreferences cssLogicalEnabled]):
976         (-[WebPreferences setCSSLogicalEnabled:]):
977         * WebView/WebPreferencesPrivate.h:
978         * WebView/WebView.mm:
979         (-[WebView _preferencesChanged:]):
980
981 2019-01-15  Darin Adler  <darin@apple.com>
982
983         Use references rather than pointers for register/unregister functions, and more
984         https://bugs.webkit.org/show_bug.cgi?id=175028
985
986         Reviewed by Daniel Bates.
987
988         * WebCoreSupport/WebKitFullScreenListener.mm:
989         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
990         functions in Document; pass a reference.
991         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
992         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
993         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
994         * WebView/WebFullScreenController.mm:
995         (-[WebFullScreenController enterFullScreen:]): Ditto.
996         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
997         (-[WebFullScreenController exitFullScreen]): Ditto.
998         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
999         * WebView/WebFullScreenController.mm:
1000         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
1001
1002 2019-01-12  Dan Bernstein  <mitz@apple.com>
1003
1004         [Cocoa] Avoid importing directly from subumbrella frameworks
1005         https://bugs.webkit.org/show_bug.cgi?id=186016
1006         <rdar://problem/40591038>
1007
1008         Reviewed by Sam Weinig.
1009
1010         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1011         * Carbon/CarbonWindowAdapter.mm: Ditto.
1012         * Carbon/CarbonWindowFrame.m: Ditto.
1013         * Carbon/HIViewAdapter.h: Ditto.
1014         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1015           OTHER_CFLAGS_COCOA_TOUCH_NO.
1016         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1017         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1018         * WebView/WebPDFView.h: Ditto.
1019
1020 2019-01-20  Antoine Quint  <graouts@apple.com>
1021
1022         Add a POINTER_EVENTS feature flag
1023         https://bugs.webkit.org/show_bug.cgi?id=193577
1024         <rdar://problem/47408511>
1025
1026         Unreviewed. Also enable Pointer Events for iosmac.
1027
1028         * Configurations/FeatureDefines.xcconfig:
1029
1030 2019-01-19  Antoine Quint  <graouts@apple.com>
1031
1032         Add a POINTER_EVENTS feature flag
1033         https://bugs.webkit.org/show_bug.cgi?id=193577
1034
1035         Reviewed by Dean Jackson.
1036
1037         * Configurations/FeatureDefines.xcconfig:
1038
1039 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
1040
1041         Revert r238815, it broke WK1 video fullscreen on Mac
1042         https://bugs.webkit.org/show_bug.cgi?id=193586
1043         <rdar://problem/47358941>
1044
1045         Reviewed by Jer Noble.
1046
1047         * WebView/WebVideoFullscreenController.h: Added.
1048         * WebView/WebVideoFullscreenController.mm: Added.
1049         (SOFT_LINK_CLASS):
1050         (-[WebVideoFullscreenController init]):
1051         (-[WebVideoFullscreenController dealloc]):
1052         (-[WebVideoFullscreenController fullscreenWindow]):
1053         (-[WebVideoFullscreenController windowDidLoad]):
1054         (-[WebVideoFullscreenController videoElement]):
1055         (-[WebVideoFullscreenController setVideoElement:]):
1056         (-[WebVideoFullscreenController clearFadeAnimation]):
1057         (-[WebVideoFullscreenController windowDidExitFullscreen]):
1058         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
1059         (-[WebVideoFullscreenController videoElementRect]):
1060         (-[WebVideoFullscreenController applicationDidResignActive:]):
1061         (frameExpandedToRatioOfFrame):
1062         (createBackgroundFullscreenWindow):
1063         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
1064         (-[WebVideoFullscreenController enterFullscreen:]):
1065         (-[WebVideoFullscreenController exitFullscreen]):
1066         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
1067         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
1068         (-[WebVideoFullscreenController _requestExit]):
1069         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
1070         (-[WebVideoFullscreenController requestExitFullscreen]):
1071         (-[WebVideoFullscreenController fadeHUDIn]):
1072         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
1073         (-[WebVideoFullscreenController rateChanged:]):
1074         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
1075         (-[WebVideoFullscreenWindow dealloc]):
1076         (-[WebVideoFullscreenWindow resignFirstResponder]):
1077         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
1078         (-[WebVideoFullscreenWindow mouseDown:]):
1079         (-[WebVideoFullscreenWindow cancelOperation:]):
1080         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
1081         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
1082         (-[WebVideoFullscreenWindow animationDidEnd:]):
1083         (-[WebVideoFullscreenWindow mouseMoved:]):
1084         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
1085         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
1086         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
1087         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
1088         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
1089         (-[WebVideoFullscreenHUDWindow center]):
1090         (-[WebVideoFullscreenHUDWindow keyDown:]):
1091         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
1092         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
1093         (-[WebVideoFullscreenHUDWindowController init]):
1094         (-[WebVideoFullscreenHUDWindowController dealloc]):
1095         (-[WebVideoFullscreenHUDWindowController setArea:]):
1096         (-[WebVideoFullscreenHUDWindowController keyDown:]):
1097         (-[WebVideoFullscreenHUDWindowController delegate]):
1098         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
1099         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
1100         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
1101         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
1102         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
1103         (-[WebVideoFullscreenHUDWindowController closeWindow]):
1104         (createMediaUIControl):
1105         (createControlWithMediaUIControlType):
1106         (createTimeTextField):
1107         (createMediaUIBackgroundView):
1108         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
1109         (-[WebVideoFullscreenHUDWindowController updateVolume]):
1110         (-[WebVideoFullscreenHUDWindowController updateTime]):
1111         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
1112         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
1113         (-[WebVideoFullscreenHUDWindowController currentTime]):
1114         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
1115         (-[WebVideoFullscreenHUDWindowController duration]):
1116         (-[WebVideoFullscreenHUDWindowController maxVolume]):
1117         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
1118         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
1119         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
1120         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
1121         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
1122         (-[WebVideoFullscreenHUDWindowController volume]):
1123         (-[WebVideoFullscreenHUDWindowController setVolume:]):
1124         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
1125         (-[WebVideoFullscreenHUDWindowController updateRate]):
1126         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
1127         (-[WebVideoFullscreenHUDWindowController playing]):
1128         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
1129         (timeToString):
1130         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
1131         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
1132         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
1133         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
1134         (-[WebVideoFullscreenHUDWindowController rewind:]):
1135         (-[WebVideoFullscreenHUDWindowController fastForward:]):
1136         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
1137         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
1138         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
1139         * WebView/WebView.mm:
1140         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1141         (-[WebView _exitVideoFullscreen]):
1142
1143 2019-01-18  Tim Horton  <timothy_horton@apple.com>
1144
1145         Get rid of ADVANCED_SPELL_CHECKING
1146         https://bugs.webkit.org/show_bug.cgi?id=193592
1147
1148         Reviewed by Wenson Hsieh.
1149
1150         * WebCoreSupport/WebEditorClient.mm:
1151         (insertionPointFromCurrentSelection):
1152         (WebEditorClient::checkTextOfParagraph):
1153         (WebEditorClient::getGuessesForWord):
1154         (WebEditorClient::requestCandidatesForSelection):
1155         (WebEditorClient::requestCheckingOfString):
1156         * WebView/WebHTMLView.mm:
1157         (-[WebHTMLView insertText:]):
1158
1159 2019-01-18  Jer Noble  <jer.noble@apple.com>
1160
1161         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1162         https://bugs.webkit.org/show_bug.cgi?id=189553
1163
1164         Reviewed by Tim Horton.
1165
1166         * Configurations/Base.xcconfig:
1167         * Configurations/SDKVariant.xcconfig: Added.
1168         * Configurations/WebKitLegacy.xcconfig:
1169
1170 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1171
1172         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1173         <https://webkit.org/b/193568>
1174         <rdar://problem/47381130>
1175
1176         Reviewed by Alex Christensen.
1177
1178         * WebView/WebView.mm:
1179         - Remove unused soft-linking macros.
1180         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1181         (-[WebUITextIndicatorData initWithImage:scale:]):
1182         - Update to use exported PAL functions.
1183
1184 2019-01-17  Truitt Savell  <tsavell@apple.com>
1185
1186         Unreviewed, rolling out r240124.
1187
1188         This commit broke an internal build.
1189
1190         Reverted changeset:
1191
1192         "SDK_VARIANT build destinations should be separate from non-
1193         SDK_VARIANT builds"
1194         https://bugs.webkit.org/show_bug.cgi?id=189553
1195         https://trac.webkit.org/changeset/240124
1196
1197 2019-01-17  Jer Noble  <jer.noble@apple.com>
1198
1199         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1200         https://bugs.webkit.org/show_bug.cgi?id=189553
1201
1202         Reviewed by Tim Horton.
1203
1204         * Configurations/Base.xcconfig:
1205         * Configurations/SDKVariant.xcconfig: Added.
1206         * Configurations/WebKitLegacy.xcconfig:
1207
1208 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1209
1210         Stop using NetworkStorageSession::storageSession in WebCore
1211         https://bugs.webkit.org/show_bug.cgi?id=193529
1212
1213         Reviewed by Tim Horton.
1214
1215         * Misc/WebCache.mm:
1216         (+[WebCache addImageToCache:forURL:forFrame:]):
1217         * WebView/WebView.mm:
1218         (-[WebView _commonInitializationWithFrameName:groupName:]):
1219         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1220
1221 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1222
1223         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1224         https://bugs.webkit.org/show_bug.cgi?id=193368
1225
1226         Reviewed by Geoff Garen.
1227
1228         * Misc/WebCache.mm:
1229         (+[WebCache clearCachedCredentials]):
1230         * Misc/WebDownload.mm:
1231         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1232         * Plugins/WebBaseNetscapePluginView.mm:
1233         (WebKit::getAuthenticationInfo):
1234
1235 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1236
1237         Stop using CookiesStrategy
1238         https://bugs.webkit.org/show_bug.cgi?id=161106
1239
1240         Reviewed by Don Olmstead and Antti Koivisto.
1241
1242         * Misc/WebCache.mm:
1243         (+[WebCache addImageToCache:forURL:forFrame:]):
1244         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1245         (WebKit::NetscapePluginInstanceProxy::getCookies):
1246         (WebKit::NetscapePluginInstanceProxy::setCookies):
1247         * Plugins/WebNetscapePluginView.mm:
1248         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1249         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1250         * WebCoreSupport/WebPlatformStrategies.h:
1251         * WebCoreSupport/WebPlatformStrategies.mm:
1252         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1253         (WebPlatformStrategies::cookiesForDOM): Deleted.
1254         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1255         (WebPlatformStrategies::cookiesEnabled): Deleted.
1256         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1257         (WebPlatformStrategies::getRawCookies): Deleted.
1258         (WebPlatformStrategies::deleteCookie): Deleted.
1259         * WebView/WebView.mm:
1260         (-[WebView _commonInitializationWithFrameName:groupName:]):
1261         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1262
1263 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1264
1265         Cannot tab out of WKWebView on macOS
1266         https://bugs.webkit.org/show_bug.cgi?id=161448
1267         <rdar://problem/28100085>
1268
1269         Reviewed by Dean Jackson.
1270
1271         * WebCoreSupport/WebChromeClient.mm:
1272         * WebView/WebView.mm:
1273         Make use of SPI headers.
1274
1275 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1276
1277         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1278         r239913, and r239914.
1279         https://bugs.webkit.org/show_bug.cgi?id=193407
1280
1281         These revisions caused an internal failure (Requested by
1282         Truitt on #webkit).
1283
1284         Reverted changesets:
1285
1286         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1287         https://bugs.webkit.org/show_bug.cgi?id=186016
1288         https://trac.webkit.org/changeset/239901
1289
1290         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1291         https://trac.webkit.org/changeset/239909
1292
1293         "Tried to fix the build."
1294         https://trac.webkit.org/changeset/239910
1295
1296         "Fixed iOS builds after r239910."
1297         https://trac.webkit.org/changeset/239912
1298
1299         "More build fixing."
1300         https://trac.webkit.org/changeset/239913
1301
1302         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1303         https://trac.webkit.org/changeset/239914
1304
1305 2019-01-14  Mark Lam  <mark.lam@apple.com>
1306
1307         Re-enable ability to build --cloop builds.
1308         https://bugs.webkit.org/show_bug.cgi?id=192955
1309         <rdar://problem/46882363>
1310
1311         Reviewed by Saam barati and Keith Miller.
1312
1313         * Configurations/FeatureDefines.xcconfig:
1314
1315 2019-01-13  Dan Bernstein  <mitz@apple.com>
1316
1317         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1318
1319         Patch by Keith Rollin.
1320
1321         * WebView/PDFViewSPI.h:
1322
1323 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1324
1325         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1326         https://bugs.webkit.org/show_bug.cgi?id=191655
1327         rdar://problem/46074680
1328
1329         Reviewed by Megan Gardner.
1330
1331         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1332         * WebView/WebView.mm:
1333         (-[WebView _effectiveAppearanceIsDark]):
1334
1335 2019-01-12  Dan Bernstein  <mitz@apple.com>
1336
1337         [Cocoa] Avoid importing directly from subumbrella frameworks
1338         https://bugs.webkit.org/show_bug.cgi?id=186016
1339         <rdar://problem/40591038>
1340
1341         Reviewed by Sam Weinig.
1342
1343         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1344         * Carbon/CarbonWindowAdapter.mm: Ditto.
1345         * Carbon/CarbonWindowFrame.m: Ditto.
1346         * Carbon/HIViewAdapter.h: Ditto.
1347         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1348           OTHER_CFLAGS_COCOA_TOUCH_NO.
1349         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1350         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1351         * WebView/WebPDFView.h: Ditto.
1352
1353 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1354
1355         Enable visual viewport API by default
1356         https://bugs.webkit.org/show_bug.cgi?id=193376
1357
1358         Reviewed by Simon Fraser.
1359
1360         * WebView/WebPreferences.mm:
1361         (+[WebPreferences initialize]):
1362
1363 2019-01-11  John Wilander  <wilander@apple.com>
1364
1365         Compile out Web API Statistics Collection
1366         https://bugs.webkit.org/show_bug.cgi?id=193370
1367         <rdar://problem/45388584>
1368
1369         Reviewed by Brent Fulgham.
1370
1371         * Configurations/FeatureDefines.xcconfig:
1372             Defined ENABLE_WEB_API_STATISTICS, off by default.
1373
1374 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1375
1376         Stop using NetworkStorageSession in WebProcess
1377         https://bugs.webkit.org/show_bug.cgi?id=193236
1378
1379         Reviewed by Don Olmstead.
1380
1381         * WebCoreSupport/WebFrameNetworkingContext.h:
1382         * WebCoreSupport/WebFrameNetworkingContext.mm:
1383         (WebFrameNetworkingContext::storageSession const):
1384         * WebCoreSupport/WebPlatformStrategies.h:
1385         * WebCoreSupport/WebPlatformStrategies.mm:
1386         (WebPlatformStrategies::cookiesForDOM):
1387         (WebPlatformStrategies::setCookiesFromDOM):
1388         (WebPlatformStrategies::cookiesEnabled):
1389         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1390         (WebPlatformStrategies::getRawCookies):
1391         (WebPlatformStrategies::deleteCookie):
1392         * WebView/WebView.mm:
1393         (-[WebView _cachedResponseForURL:]):
1394         (-[WebView _clearCredentials]):
1395
1396 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1397
1398         Unreviewed, rolling out r239727.
1399
1400         Broke API tests
1401
1402         Reverted changeset:
1403
1404         "Stop using NetworkStorageSession in WebProcess"
1405         https://bugs.webkit.org/show_bug.cgi?id=193236
1406         https://trac.webkit.org/changeset/239727
1407
1408 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1409
1410         Stop using NetworkStorageSession in WebProcess
1411         https://bugs.webkit.org/show_bug.cgi?id=193236
1412
1413         Reviewed by Don Olmstead.
1414
1415         * WebCoreSupport/WebFrameNetworkingContext.h:
1416         * WebCoreSupport/WebFrameNetworkingContext.mm:
1417         (WebFrameNetworkingContext::storageSession const):
1418         * WebView/WebView.mm:
1419         (-[WebView _cachedResponseForURL:]):
1420         (-[WebView _clearCredentials]):
1421
1422 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1423
1424         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1425         <https://webkit.org/b/193056>
1426
1427         Reviewed by Alex Christensen.
1428
1429         * Plugins/Hosted/NetscapePluginHostProxy.h:
1430         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1431         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1432         (WebKit::NetscapePluginInstanceProxy::enumerate):
1433         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1434         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1435         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1436         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1437         * Plugins/Hosted/ProxyInstance.mm:
1438         (WebKit::ProxyInstance::invoke):
1439         * WebCoreSupport/WebGeolocationClient.mm:
1440         * WebView/WebDataSource.mm:
1441         (-[WebDataSource _receivedData:]):
1442         * WebView/WebView.mm:
1443         (-[WebView _cachedResponseForURL:]):
1444         - Remove '*' from RetainPtr<> type.
1445
1446 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1447
1448         Progress towards fixing Mac CMake build
1449         https://bugs.webkit.org/show_bug.cgi?id=193105
1450
1451         Reviewed by Don Olmstead.
1452
1453         * WebKitPrefix.h:
1454
1455 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1456
1457         Web Inspector: Use save sheet instead of dialog where possible
1458         https://bugs.webkit.org/show_bug.cgi?id=193160
1459         <rdar://problem/37399759>
1460
1461         Reviewed by Devin Rousso.
1462
1463         * WebCoreSupport/WebInspectorClient.mm:
1464         (WebInspectorFrontendClient::save):
1465
1466 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1467
1468         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1469         https://bugs.webkit.org/show_bug.cgi?id=193129
1470
1471         Reviewed by Tim Horton.
1472
1473         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1474
1475         * WebCoreSupport/WebEditorClient.mm:
1476         (WebEditorClient::registerUndoOrRedoStep):
1477         (undoNameForEditAction): Deleted.
1478
1479 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1480
1481         Add support for using the current text selection as the find string on iOS
1482         https://bugs.webkit.org/show_bug.cgi?id=193034
1483         <rdar://problem/45138739>
1484
1485         Reviewed by Tim Horton.
1486
1487         Add a method stub for WebKitLegacy.
1488
1489         * WebCoreSupport/WebEditorClient.h:
1490
1491 2019-01-01  Jeff Miller  <jeffm@apple.com>
1492
1493         Update user-visible copyright strings to include 2019
1494         https://bugs.webkit.org/show_bug.cgi?id=192811
1495
1496         Reviewed by Mark Lam.
1497
1498         * Info.plist:
1499
1500 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1501
1502         Use Ref<> as much as possible
1503         https://bugs.webkit.org/show_bug.cgi?id=192808
1504
1505         Reviewed by Alex Christensen.
1506
1507         * DOM/DOM.mm:
1508         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1509         * Plugins/Hosted/NetscapePluginHostManager.mm:
1510         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1511         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1512         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1513         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1514         * Plugins/WebNetscapePluginView.mm:
1515         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1516         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1517         * WebCoreSupport/WebContextMenuClient.mm:
1518         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1519         * WebCoreSupport/WebFrameLoaderClient.mm:
1520         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1521         * WebView/WebFrame.mm:
1522         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1523         * WebView/WebHTMLView.mm:
1524         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1525         * WebView/WebView.mm:
1526         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1527         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1528
1529 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1530
1531         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1532         https://bugs.webkit.org/show_bug.cgi?id=192821
1533
1534         Reviewed by Chris Dumez.
1535
1536         When a window becomes occluded, the window server informs the application.
1537         This should be used to suspend any work that is not visible by the user.
1538
1539         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1540         In some cases, that lead to performance impact (see radar).
1541
1542         This patch adds an observer for the occlusion notification. I tried to stick
1543         with the same names used by WebKit2.
1544
1545         * WebView/WebView.mm:
1546         (-[WebView _isViewVisible]):
1547         (-[WebView addWindowObserversForWindow:]):
1548         (-[WebView removeWindowObservers]):
1549         (-[WebView _windowDidChangeOcclusionState:]):
1550
1551 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1552
1553         [WebAuthN] Add a runtime flag for local authenticator
1554         https://bugs.webkit.org/show_bug.cgi?id=192792
1555         <rdar://problem/46798738>
1556
1557         Reviewed by Brent Fulgham.
1558
1559         * WebView/WebPreferenceKeysPrivate.h:
1560         * WebView/WebPreferences.mm:
1561         (+[WebPreferences initialize]):
1562         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1563         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1564         * WebView/WebPreferencesPrivate.h:
1565         * WebView/WebView.mm:
1566         (-[WebView _preferencesChanged:]):
1567
1568 2018-12-20  Chris Dumez  <cdumez@apple.com>
1569
1570         Use Optional::valueOr() instead of Optional::value_or()
1571         https://bugs.webkit.org/show_bug.cgi?id=192933
1572
1573         Reviewed by Geoffrey Garen.
1574
1575         * WebCoreSupport/WebSecurityOrigin.mm:
1576         (-[WebSecurityOrigin port]):
1577
1578 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1579
1580         Unreviewed, rolling out r239417.
1581
1582         Introduced two API test failures on macOS.
1583
1584         Reverted changeset:
1585
1586         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1587         occlusion changes"
1588         https://bugs.webkit.org/show_bug.cgi?id=192821
1589         https://trac.webkit.org/changeset/239417
1590
1591 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1592
1593         WKWebView default UA doesn't freeze the build number
1594         https://bugs.webkit.org/show_bug.cgi?id=192809
1595         <rdar://problem/44687185>
1596
1597         Reviewed by Andy Estes.
1598
1599         Always reports the frozen build number.
1600
1601         * WebView/WebView.mm:
1602         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1603         actual build number through this method call.
1604         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1605
1606 2018-12-19  Chris Dumez  <cdumez@apple.com>
1607
1608         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1609         https://bugs.webkit.org/show_bug.cgi?id=192728
1610         <rdar://problem/46746779>
1611
1612         Reviewed by Geoff Garen.
1613
1614         * DOM/*:
1615         * Plugins/*:
1616         * WebCoreSupport/*:
1617         * WebView/*:
1618
1619 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1620
1621         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1622         https://bugs.webkit.org/show_bug.cgi?id=192821
1623
1624         Reviewed by Chris Dumez.
1625
1626         When a window becomes occluded, the window server informs the application.
1627         This should be used to suspend any work that is not visible by the user.
1628
1629         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1630         In some cases, that lead to performance impact (see radar).
1631
1632         This patch adds an observer for the occlusion notification. I tried to stick
1633         with the same names used by WebKit2.
1634
1635         * WebView/WebView.mm:
1636         (-[WebView _isViewVisible]):
1637         (-[WebView addWindowObserversForWindow:]):
1638         (-[WebView removeWindowObservers]):
1639         (-[WebView _windowDidChangeOcclusionState:]):
1640
1641 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1642
1643         Allow clients to set the navigator platform
1644         https://bugs.webkit.org/show_bug.cgi?id=192735
1645
1646         Reviewed by Tim Horton.
1647
1648         Add stubs to fill out the added functionality in FrameLoaderClient.
1649
1650         * WebCoreSupport/WebFrameLoaderClient.h:
1651         * WebCoreSupport/WebFrameLoaderClient.mm:
1652         (WebFrameLoaderClient::navigatorPlatform):
1653
1654 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1655
1656         offsetLeft and offsetParent should adjust across shadow boundaries
1657         https://bugs.webkit.org/show_bug.cgi?id=157437
1658         <rdar://problem/26154021>
1659
1660         Reviewed by Simon Fraser.
1661
1662         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1663
1664         * DOM/DOMElement.mm:
1665         (-[DOMElement offsetLeft]):
1666         (-[DOMElement offsetTop]):
1667         (-[DOMElement offsetParent]):
1668
1669 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1670
1671         Unreviewed build fix.
1672
1673         * WebView/WebFrame.mm:
1674         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1675
1676 2018-12-15  Darin Adler  <darin@apple.com>
1677
1678         Use warning-ignoring macros more consistently and simply
1679         https://bugs.webkit.org/show_bug.cgi?id=192743
1680
1681         Reviewed by Mark Lam.
1682
1683         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1684         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1685         compilers in Objective-C++ code.
1686
1687         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1688         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1689         accomodate non-clang compilers here. Also use #pragma once, add a missing
1690         "explicit" and fix conditionals.
1691
1692 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1693
1694         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1695         https://bugs.webkit.org/show_bug.cgi?id=192653
1696
1697         Reviewed by Wenson Hsieh.
1698
1699         * WebView/WebHTMLView.mm:
1700         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1701
1702 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1703
1704         Implement feature flag for CSS Typed OM
1705         https://bugs.webkit.org/show_bug.cgi?id=192610
1706
1707         Reviewed by Ryosuke Niwa.
1708
1709         * Configurations/FeatureDefines.xcconfig:
1710
1711 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1712
1713         WebCore shouldn't have a Objective-C class named NSCursor
1714         https://bugs.webkit.org/show_bug.cgi?id=192602
1715         <rdar://problem/46615532>
1716
1717         Reviewed by Wenson Hsieh.
1718
1719         * WebView/WebFrameView.mm:
1720         (-[WebFrameView keyDown:keyDown:]):
1721         * WebView/WebHTMLView.mm:
1722         (-[WebHTMLView keyDown:]):
1723         (-[WebHTMLView performKeyEquivalent:]):
1724         Only use NSCursor on macOS.
1725
1726 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1727
1728         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1729         https://bugs.webkit.org/show_bug.cgi?id=192573
1730
1731         Reviewed by Simon Fraser.
1732
1733         * Configurations/FeatureDefines.xcconfig:
1734
1735 2018-12-10  Antti Koivisto  <antti@apple.com>
1736
1737         Rename "forced style recalc" to "full style rebuild"
1738         https://bugs.webkit.org/show_bug.cgi?id=192572
1739
1740         Reviewed by Zalan Bujtas.
1741
1742         * WebView/WebHTMLView.mm:
1743         (-[WebHTMLView setNeedsToApplyStyles:]):
1744
1745 2018-12-10  Darin Adler  <darin@apple.com>
1746
1747         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1748         https://bugs.webkit.org/show_bug.cgi?id=192533
1749         rdar://problem/45732710
1750
1751         Reviewed by Anders Carlsson.
1752
1753         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1754         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1755
1756 2018-12-10  Darin Adler  <darin@apple.com>
1757
1758         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1759         https://bugs.webkit.org/show_bug.cgi?id=192532
1760         rdar://problem/45731047
1761
1762         Reviewed by Chris Dumez.
1763
1764         * Plugins/Hosted/NetscapePluginHostManager.mm:
1765         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1766         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1767         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1768
1769 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1770
1771         Turn WritingDirection into an enum class
1772         https://bugs.webkit.org/show_bug.cgi?id=192401
1773         Work towards <rdar://problem/42075638>
1774
1775         Reviewed by Dan Bernstein.
1776
1777         Change WritingDirection from an enum to an enum class. No change in behavior.
1778
1779         * WebView/WebHTMLView.mm:
1780         (-[WebHTMLView toggleBaseWritingDirection:]):
1781         (-[WebHTMLView changeBaseWritingDirection:]):
1782         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1783
1784 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1785
1786         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1787         https://bugs.webkit.org/show_bug.cgi?id=192272
1788
1789         Reviewed by Brady Eidson.
1790
1791         * WebCoreSupport/WebFrameLoaderClient.h:
1792         * WebCoreSupport/WebFrameLoaderClient.mm:
1793         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1794
1795 2018-12-03  Jer Noble  <jer.noble@apple.com>
1796
1797         Get rid of old, dead Mac video fullscreen code.
1798         https://bugs.webkit.org/show_bug.cgi?id=192315
1799
1800         Reviewed by Eric Carlson.
1801
1802         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1803         is no longer supported in the Mac port.
1804
1805         * WebView/WebVideoFullscreenController.h: Removed.
1806         * WebView/WebVideoFullscreenController.mm: Removed.
1807         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1808         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1809         * WebView/WebView.mm:
1810         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1811         (-[WebView _exitVideoFullscreen]):
1812
1813 2018-12-03  Daniel Bates  <dabates@apple.com>
1814
1815         [iOS] Do not handle key events that are key commands
1816         https://bugs.webkit.org/show_bug.cgi?id=191608
1817         <rdar://problem/46046013>
1818
1819         Reviewed by Ryosuke Niwa.
1820
1821         A key down event may be associated with a key command. If it is then we want to execute the
1822         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1823         event as a key command to find out.
1824
1825         * WebView/WebHTMLView.mm:
1826         (-[WebHTMLView _handleEditingKeyEvent:]):
1827
1828 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1829
1830         Add a runtime feature flag for LayoutFormattingContext.
1831         https://bugs.webkit.org/show_bug.cgi?id=192280
1832
1833         Reviewed by Simon Fraser.
1834
1835         * Configurations/FeatureDefines.xcconfig:
1836
1837 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1838
1839         Move URL from WebCore to WTF
1840         https://bugs.webkit.org/show_bug.cgi?id=190234
1841
1842         Reviewed by Keith Miller.
1843
1844         * DOM/DOMAttr.mm:
1845         * DOM/DOMBlob.mm:
1846         * DOM/DOMCSSCharsetRule.mm:
1847         * DOM/DOMCSSImportRule.mm:
1848         * DOM/DOMCSSMediaRule.mm:
1849         * DOM/DOMCSSPageRule.mm:
1850         * DOM/DOMCSSPrimitiveValue.mm:
1851         * DOM/DOMCSSRule.mm:
1852         * DOM/DOMCSSStyleDeclaration.mm:
1853         * DOM/DOMCSSStyleRule.mm:
1854         * DOM/DOMCSSStyleSheet.mm:
1855         * DOM/DOMCSSValue.mm:
1856         * DOM/DOMCharacterData.mm:
1857         * DOM/DOMCounter.mm:
1858         * DOM/DOMDocument.mm:
1859         * DOM/DOMDocumentFragment.mm:
1860         * DOM/DOMDocumentType.mm:
1861         * DOM/DOMEvent.mm:
1862         * DOM/DOMFile.mm:
1863         * DOM/DOMHTMLAnchorElement.mm:
1864         * DOM/DOMHTMLAppletElement.mm:
1865         * DOM/DOMHTMLAreaElement.mm:
1866         * DOM/DOMHTMLBRElement.mm:
1867         * DOM/DOMHTMLBaseElement.mm:
1868         * DOM/DOMHTMLBaseFontElement.mm:
1869         * DOM/DOMHTMLBodyElement.mm:
1870         * DOM/DOMHTMLButtonElement.mm:
1871         * DOM/DOMHTMLCanvasElement.mm:
1872         * DOM/DOMHTMLCollection.mm:
1873         * DOM/DOMHTMLDivElement.mm:
1874         * DOM/DOMHTMLDocument.mm:
1875         * DOM/DOMHTMLElement.mm:
1876         * DOM/DOMHTMLEmbedElement.mm:
1877         * DOM/DOMHTMLFieldSetElement.mm:
1878         * DOM/DOMHTMLFontElement.mm:
1879         * DOM/DOMHTMLFormElement.mm:
1880         * DOM/DOMHTMLFrameElement.mm:
1881         * DOM/DOMHTMLFrameSetElement.mm:
1882         * DOM/DOMHTMLHRElement.mm:
1883         * DOM/DOMHTMLHeadElement.mm:
1884         * DOM/DOMHTMLHeadingElement.mm:
1885         * DOM/DOMHTMLHtmlElement.mm:
1886         * DOM/DOMHTMLIFrameElement.mm:
1887         * DOM/DOMHTMLImageElement.mm:
1888         * DOM/DOMHTMLInputElement.mm:
1889         * DOM/DOMHTMLLIElement.mm:
1890         * DOM/DOMHTMLLabelElement.mm:
1891         * DOM/DOMHTMLLegendElement.mm:
1892         * DOM/DOMHTMLLinkElement.mm:
1893         * DOM/DOMHTMLMapElement.mm:
1894         * DOM/DOMHTMLMarqueeElement.mm:
1895         * DOM/DOMHTMLMediaElement.mm:
1896         * DOM/DOMHTMLMetaElement.mm:
1897         * DOM/DOMHTMLModElement.mm:
1898         * DOM/DOMHTMLOListElement.mm:
1899         * DOM/DOMHTMLObjectElement.mm:
1900         * DOM/DOMHTMLOptGroupElement.mm:
1901         * DOM/DOMHTMLOptionElement.mm:
1902         * DOM/DOMHTMLOptionsCollection.mm:
1903         * DOM/DOMHTMLParagraphElement.mm:
1904         * DOM/DOMHTMLParamElement.mm:
1905         * DOM/DOMHTMLQuoteElement.mm:
1906         * DOM/DOMHTMLScriptElement.mm:
1907         * DOM/DOMHTMLSelectElement.mm:
1908         * DOM/DOMHTMLStyleElement.mm:
1909         * DOM/DOMHTMLTableCaptionElement.mm:
1910         * DOM/DOMHTMLTableCellElement.mm:
1911         * DOM/DOMHTMLTableColElement.mm:
1912         * DOM/DOMHTMLTableElement.mm:
1913         * DOM/DOMHTMLTableRowElement.mm:
1914         * DOM/DOMHTMLTableSectionElement.mm:
1915         * DOM/DOMHTMLTitleElement.mm:
1916         * DOM/DOMHTMLUListElement.mm:
1917         * DOM/DOMHTMLVideoElement.mm:
1918         * DOM/DOMKeyboardEvent.mm:
1919         * DOM/DOMMediaList.mm:
1920         * DOM/DOMMouseEvent.mm:
1921         * DOM/DOMMutationEvent.mm:
1922         * DOM/DOMNamedNodeMap.mm:
1923         * DOM/DOMProcessingInstruction.mm:
1924         * DOM/DOMRange.mm:
1925         * DOM/DOMStyleSheet.mm:
1926         * DOM/DOMText.mm:
1927         * DOM/DOMTextEvent.mm:
1928         * DOM/DOMTokenList.mm:
1929         * DOM/DOMUIEvent.mm:
1930         * DOM/DOMXPathResult.mm:
1931         * History/WebHistoryItem.mm:
1932         * Misc/WebNSURLExtras.mm:
1933         (-[NSURL _web_userVisibleString]):
1934         (-[NSURL _web_URLByRemovingUserInfo]):
1935         (-[NSURL _web_dataForURLComponentType:]):
1936         (-[NSURL _web_schemeData]):
1937         (-[NSURL _web_hostData]):
1938         * Misc/WebUserContentURLPattern.mm:
1939         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1940         * Plugins/WebNetscapePluginStream.h:
1941         (WebNetscapePluginStream::setRequestURL):
1942         * WebCoreSupport/WebChromeClient.h:
1943         * WebCoreSupport/WebChromeClient.mm:
1944         (WebChromeClient::signedPublicKeyAndChallengeString const):
1945         * WebCoreSupport/WebContextMenuClient.h:
1946         * WebCoreSupport/WebContextMenuClient.mm:
1947         * WebCoreSupport/WebDragClient.h:
1948         * WebCoreSupport/WebFrameLoaderClient.h:
1949         * WebCoreSupport/WebFrameLoaderClient.mm:
1950         (WebFrameLoaderClient::updateGlobalHistory):
1951         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1952         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1953         (WebPaymentCoordinatorClient::showPaymentUI):
1954         * WebCoreSupport/WebPlatformStrategies.h:
1955         * WebCoreSupport/WebPlatformStrategies.mm:
1956         (WebPlatformStrategies::readURLFromPasteboard):
1957         * WebCoreSupport/WebPluginInfoProvider.h:
1958         * WebCoreSupport/WebPluginInfoProvider.mm:
1959         (WebPluginInfoProvider::webVisiblePluginInfo):
1960         * WebCoreSupport/WebSecurityOrigin.mm:
1961         * WebCoreSupport/WebVisitedLinkStore.h:
1962         * WebView/WebDataSource.mm:
1963         * WebView/WebFrame.mm:
1964         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1965         * WebView/WebImmediateActionController.mm:
1966         (-[WebImmediateActionController _defaultAnimationController]):
1967         * WebView/WebPDFView.mm:
1968         * WebView/WebScriptDebugger.mm:
1969         * WebView/WebViewInternal.h:
1970
1971 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1972
1973         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1974         https://bugs.webkit.org/show_bug.cgi?id=192197
1975
1976         Reviewed by Jiewen Tan.
1977
1978         * Configurations/FeatureDefines.xcconfig:
1979         * WebCoreSupport/WebChromeClient.h:
1980         * WebCoreSupport/WebChromeClient.mm:
1981
1982 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1983
1984         Remove dead code from an earlier attempt at implementing safe browsing
1985         https://bugs.webkit.org/show_bug.cgi?id=192067
1986
1987         Reviewed by Chris Dumez.
1988
1989         * WebCoreSupport/WebFrameLoaderClient.h:
1990         * WebCoreSupport/WebFrameLoaderClient.mm:
1991         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1992
1993 2018-11-27  Mark Lam  <mark.lam@apple.com>
1994
1995         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1996         https://bugs.webkit.org/show_bug.cgi?id=192055
1997         <rdar://problem/46288783>
1998
1999         Reviewed by Saam Barati.
2000
2001         * Configurations/FeatureDefines.xcconfig:
2002
2003 2018-11-25  Tim Horton  <timothy_horton@apple.com>
2004
2005         Make it possible to insert editable images with a gesture
2006         https://bugs.webkit.org/show_bug.cgi?id=191937
2007
2008         Reviewed by Wenson Hsieh.
2009
2010         * WebCoreSupport/WebEditorClient.mm:
2011         (undoNameForEditAction):
2012         Add a undo name.
2013
2014 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2015
2016         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
2017         https://bugs.webkit.org/show_bug.cgi?id=191945
2018
2019         Reviewed by Anders Carlsson.
2020
2021         * WebCoreSupport/WebEditorClient.mm:
2022         (undoNameForEditAction):
2023
2024 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2025
2026         Enable drag and drop support for iOSMac
2027         https://bugs.webkit.org/show_bug.cgi?id=191818
2028         <rdar://problem/43907454>
2029
2030         Reviewed by Dean Jackson.
2031
2032         * Configurations/FeatureDefines.xcconfig:
2033
2034 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2035
2036         Address post-review feedback after r238438
2037         https://bugs.webkit.org/show_bug.cgi?id=191913
2038
2039         Reviewed by Ryosuke Niwa.
2040
2041         * WebView/WebFrame.mm:
2042         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
2043         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
2044         * WebView/WebView.mm:
2045         (-[WebView setSelectedDOMRange:affinity:]):
2046
2047 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
2048
2049         Web Inspector: "Reload Web Inspector" button no longer partially works
2050         https://bugs.webkit.org/show_bug.cgi?id=191773
2051         <rdar://problem/46139932>
2052
2053         Reviewed by Devin Rousso.
2054
2055         * WebCoreSupport/WebInspectorClient.h:
2056         * WebCoreSupport/WebInspectorClient.mm:
2057         (WebInspectorFrontendClient::reopen):
2058
2059 2018-11-17  Devin Rousso  <drousso@apple.com>
2060
2061         Web Inspector: Network: add button to show system certificate dialog
2062         https://bugs.webkit.org/show_bug.cgi?id=191458
2063         <rdar://problem/45977019>
2064
2065         Reviewed by Joseph Pecoraro.
2066
2067         * WebCoreSupport/WebInspectorClient.h:
2068         * WebCoreSupport/WebInspectorClient.mm:
2069         (WebInspectorFrontendClient::showCertificate): Added.
2070
2071         * Configurations/WebKitLegacy.xcconfig:
2072
2073 2018-11-15  Truitt Savell  <tsavell@apple.com>
2074
2075         Unreviewed, rolling out r238244.
2076
2077         Caused High Sierra test runs to fail early with 50 crashes and
2078         casued 25 API failures.
2079
2080         Reverted changeset:
2081
2082         "[css-logical] Implement flow-relative margin, padding and
2083         border shorthands"
2084         https://bugs.webkit.org/show_bug.cgi?id=188697
2085         https://trac.webkit.org/changeset/238244
2086
2087 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
2088
2089         [css-logical] Implement flow-relative margin, padding and border shorthands
2090         https://bugs.webkit.org/show_bug.cgi?id=188697
2091
2092         Reviewed by Simon Fraser and Antti Koivisto.
2093
2094         Add CSSLogicalEnabled runtime flag.
2095
2096         * WebView/WebPreferenceKeysPrivate.h:
2097         * WebView/WebPreferences.mm:
2098         (+[WebPreferences initialize]):
2099         (-[WebPreferences cssLogicalEnabled]):
2100         (-[WebPreferences setCSSLogicalEnabled:]):
2101         * WebView/WebPreferencesPrivate.h:
2102         * WebView/WebView.mm:
2103         (-[WebView _preferencesChanged:]):
2104
2105 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2106
2107         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
2108         https://bugs.webkit.org/show_bug.cgi?id=191612
2109
2110         Reviewed by Matt Baker.
2111
2112         * WebCoreSupport/WebInspectorClient.mm:
2113         (-[WebInspectorWindowController destroyInspectorView]):
2114
2115 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2116
2117         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
2118         https://bugs.webkit.org/show_bug.cgi?id=191494
2119         <rdar://problem/45469854>
2120
2121         Reviewed by Devin Rousso.
2122
2123         * WebCoreSupport/WebInspectorClient.h:
2124         WebKitLegacy will still have remote inspection of the Page directly.
2125
2126 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
2127
2128         Make compositing updates incremental
2129         https://bugs.webkit.org/show_bug.cgi?id=90342
2130
2131         Reviewed by Antti Koivisto.
2132
2133         Fix spelling error.
2134
2135         * WebView/WebView.mm:
2136         (-[WebView _setMediaLayer:forPluginView:]):
2137
2138 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2139
2140         Implement a new edit command to change the enclosing list type
2141         https://bugs.webkit.org/show_bug.cgi?id=191487
2142         <rdar://problem/45955922>
2143
2144         Reviewed by Ryosuke Niwa.
2145
2146         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
2147
2148         * WebCoreSupport/WebEditorClient.mm:
2149         (undoNameForEditAction):
2150
2151 2018-11-11  Daniel Bates  <dabates@apple.com>
2152
2153         [iOS] Draw caps lock indicator in password fields
2154         https://bugs.webkit.org/show_bug.cgi?id=190565
2155         <rdar://problem/45262343>
2156
2157         Reviewed by Dean Jackson.
2158
2159         Update the caps lock state when a hardware keyboard is attached or detached.
2160
2161         * WebView/WebHTMLView.mm:
2162         (hardwareKeyboardAvailabilityChangedCallback): Added.
2163         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2164         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2165
2166 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
2167
2168         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2169         https://bugs.webkit.org/show_bug.cgi?id=191492
2170
2171         Reviewed by Alex Christensen.
2172
2173         * Carbon/HIWebView.mm:
2174         * Misc/WebNSFileManagerExtras.mm:
2175         * Misc/WebNSURLExtras.mm:
2176         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2177         * Plugins/WebBasePluginPackage.mm:
2178         * Plugins/WebPluginContainerCheck.mm:
2179         * WebCoreSupport/WebCachedFramePlatformData.h:
2180         * WebCoreSupport/WebDeviceOrientationClient.mm:
2181         * WebView/WebDelegateImplementationCaching.mm:
2182         * WebView/WebHTMLView.mm:
2183         * WebView/WebPDFRepresentation.mm:
2184         * WebView/WebPolicyDelegate.mm:
2185         * WebView/WebView.mm:
2186
2187 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
2188
2189         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2190         https://bugs.webkit.org/show_bug.cgi?id=191492
2191
2192         Reviewed by Alex Christensen.
2193
2194         * Carbon/HIWebView.mm:
2195         (UpdateCommandStatus):
2196         * Misc/WebNSFileManagerExtras.mm:
2197         * Misc/WebNSURLExtras.mm:
2198         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2199         * Plugins/WebBasePluginPackage.mm:
2200         * Plugins/WebPluginContainerCheck.mm:
2201         (-[WebPluginContainerCheck _continueWithPolicy:]):
2202         * WebCoreSupport/WebCachedFramePlatformData.h:
2203         (WebCachedFramePlatformData::clear):
2204         * WebCoreSupport/WebDeviceOrientationClient.mm:
2205         (WebDeviceOrientationClient::getProvider const):
2206         * WebView/WebDelegateImplementationCaching.mm:
2207         (CallDelegate):
2208         (CallDelegateReturningBoolean):
2209         (CallResourceLoadDelegateReturningBoolean):
2210         (CallFormDelegate):
2211         (CallFormDelegateReturningBoolean):
2212         * WebView/WebHTMLView.mm:
2213         * WebView/WebPDFRepresentation.mm:
2214         * WebView/WebPolicyDelegate.mm:
2215         (-[WebPolicyDecisionListener _usePolicy:]):
2216         * WebView/WebView.mm:
2217
2218 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
2219
2220         Unreviewed, rolling out r238047.
2221
2222         Introduced layout test failures on iOS simulator.
2223
2224         Reverted changeset:
2225
2226         "[iOS] Draw caps lock indicator in password fields"
2227         https://bugs.webkit.org/show_bug.cgi?id=190565
2228         https://trac.webkit.org/changeset/238047
2229
2230 2018-11-09  Antti Koivisto  <antti@apple.com>
2231
2232         Use OptionSet for layout milestones
2233         https://bugs.webkit.org/show_bug.cgi?id=191470
2234
2235         Reviewed by Dean Jackson.
2236
2237         * WebCoreSupport/WebFrameLoaderClient.h:
2238         * WebCoreSupport/WebFrameLoaderClient.mm:
2239         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2240         * WebView/WebView.mm:
2241         (coreLayoutMilestones):
2242         (kitLayoutMilestones):
2243         (-[WebView _cacheFrameLoadDelegateImplementations]):
2244         * WebView/WebViewInternal.h:
2245
2246 2018-11-09  Daniel Bates  <dabates@apple.com>
2247
2248         [iOS] Draw caps lock indicator in password fields
2249         https://bugs.webkit.org/show_bug.cgi?id=190565
2250         <rdar://problem/45262343>
2251
2252         Reviewed by Dean Jackson.
2253
2254         Update the caps lock state when a hardware keyboard is attached or detached.
2255
2256         * WebView/WebHTMLView.mm:
2257         (hardwareKeyboardAvailabilityChangedCallback): Added.
2258         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2259         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2260
2261 2018-11-09  Daniel Bates  <dabates@apple.com>
2262
2263         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
2264         action when forward delete is pressed outside a text field
2265         https://bugs.webkit.org/show_bug.cgi?id=190566
2266         <rdar://problem/45262367>
2267
2268         Reviewed by Wenson Hsieh.
2269
2270         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
2271         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
2272         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
2273
2274         * WebView/WebHTMLView.mm:
2275         (-[WebHTMLView _handleEditingKeyEvent:]):
2276
2277 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
2278
2279         Adopt Reveal Framework to replace Lookup
2280         https://bugs.webkit.org/show_bug.cgi?id=191097
2281         <rdar://problem/45924508>
2282
2283         Reviewed by Tim Horton.
2284
2285         Pass in what it needed to clear the textIndicators. This is better than
2286         the current notification structure.
2287
2288         * WebView/WebView.mm:
2289         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2290         (-[WebView _prepareForDictionaryLookup]):
2291
2292 2018-11-06  Justin Fan  <justin_fan@apple.com>
2293
2294         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2295         https://bugs.webkit.org/show_bug.cgi?id=191291
2296
2297         Reviewed by Myles Maxfield.
2298
2299         Properly disable WEBGPU on all non-Metal platforms for now.
2300
2301         * Configurations/FeatureDefines.xcconfig:
2302
2303 2018-11-02  Daniel Bates  <dabates@apple.com>
2304
2305         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2306         https://bugs.webkit.org/show_bug.cgi?id=190487
2307
2308         Reviewed by Tim Horton.
2309
2310         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
2311         allow the default handling.
2312
2313         * WebView/WebHTMLView.mm:
2314         (-[WebHTMLView _handleEditingKeyEvent:]):
2315
2316 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2317
2318         Add a storage limit for IndexedDB
2319         https://bugs.webkit.org/show_bug.cgi?id=190598
2320         <rdar://problem/44654715>
2321
2322         Reviewed by Chris Dumez.
2323
2324         * Storage/WebDatabaseManager.mm:
2325         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2326         * Storage/WebDatabaseManagerPrivate.h:
2327
2328 2018-10-31  Antti Koivisto  <antti@apple.com>
2329
2330         Remove LayerFlushScheduler
2331         https://bugs.webkit.org/show_bug.cgi?id=191103
2332
2333         Reviewed by Anders Carlsson.
2334
2335         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2336         all the virtual cruft.
2337
2338         * WebView/WebViewData.h:
2339         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2340         (): Deleted.
2341         * WebView/WebViewData.mm:
2342         (currentRunLoop):
2343         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2344         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2345         (WebViewLayerFlushScheduler::schedule):
2346         (WebViewLayerFlushScheduler::invalidate):
2347         (WebViewLayerFlushScheduler::layerFlushCallback):
2348
2349 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2350
2351         Enable InstallAPI for iOS unconditionally
2352         https://bugs.webkit.org/show_bug.cgi?id=191043
2353         rdar://problem/32728423
2354
2355         Reviewed by Dan Bernstein.
2356
2357         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2358         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2359         shouldn't be processed by InstallAPI.
2360         * MigrateHeaders.make: Removed an obsolete workaround.
2361         * Misc/NSURLDownloadSPI.h: Added.
2362         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2363
2364 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2365
2366         Clean up some obsolete MAX_ALLOWED macros
2367         https://bugs.webkit.org/show_bug.cgi?id=190916
2368
2369         Reviewed by Tim Horton.
2370
2371         * WebView/WebHTMLView.mm:
2372         (-[WebHTMLView pressureChangeWithEvent:]):
2373         * WebView/WebPDFView.h:
2374
2375 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2376
2377         Unreviewed, rolling out r237600 and r237604.
2378         https://bugs.webkit.org/show_bug.cgi?id=191086
2379
2380         Breaks internal iOS builds (Requested by ryanhadd_ on
2381         #webkit).
2382
2383         Reverted changesets:
2384
2385         "Enable InstallAPI for iOS unconditionally"
2386         https://bugs.webkit.org/show_bug.cgi?id=191043
2387         https://trac.webkit.org/changeset/237600
2388
2389         "Build fix attempt after enabling InstallAPI for iOS."
2390         https://bugs.webkit.org/show_bug.cgi?id=191043
2391         https://trac.webkit.org/changeset/237604
2392
2393 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2394
2395         Enable InstallAPI for iOS unconditionally
2396         https://bugs.webkit.org/show_bug.cgi?id=191043
2397         rdar://problem/32728423
2398
2399         Reviewed by Dan Bernstein.
2400
2401         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2402         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2403         shouldn't be processed by InstallAPI.
2404         * MigrateHeaders.make: Removed an obsolete workaround.
2405         * Misc/NSURLDownloadSPI.h: Added.
2406         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2407
2408 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2409
2410         Modernize WebKit nibs and lprojs for localization's sake
2411         https://bugs.webkit.org/show_bug.cgi?id=190911
2412         <rdar://problem/45349466>
2413
2414         Reviewed by Dan Bernstein.
2415
2416         * Misc/WebNSControlExtras.m:
2417         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2418         NSWindow and its contents are both in the same scale space these days; avoid
2419         double-applying the scale factor, or you can't see the prompt.
2420
2421         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2422         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2423         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2424         NIB->XIB
2425
2426 2018-10-25  Antoine Quint  <graouts@apple.com>
2427
2428         [Web Animations] Turn Web Animations CSS Integration off by default
2429         https://bugs.webkit.org/show_bug.cgi?id=190901
2430
2431         Reviewed by Dean Jackson.
2432
2433         * WebView/WebPreferences.mm:
2434         (+[WebPreferences initialize]):
2435
2436 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2437
2438         Clean up some obsolete macOS version guards
2439         https://bugs.webkit.org/show_bug.cgi?id=190887
2440
2441         Reviewed by Dan Bernstein.
2442
2443         * Misc/WebNSPasteboardExtras.mm:
2444         (+[NSPasteboard _web_dragTypesForURL]):
2445         * WebCoreSupport/PopupMenuMac.mm:
2446         (PopupMenuMac::show):
2447         * WebCoreSupport/WebEditorClient.h:
2448         * WebCoreSupport/WebEditorClient.mm:
2449         (WebEditorClient::respondToChangedSelection):
2450         * WebView/WebPDFView.mm:
2451         (-[WebPDFView _clipViewForPDFDocumentView]):
2452
2453 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2454
2455         Turn on Conic Gradients
2456         https://bugs.webkit.org/show_bug.cgi?id=190810
2457
2458         Reviewed by Tim Horton.
2459
2460         * Configurations/FeatureDefines.xcconfig:
2461
2462 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2463
2464         Cleanup: MIMETypeRegistry functions
2465         https://bugs.webkit.org/show_bug.cgi?id=190838
2466
2467         Reviewed by Simon Fraser.
2468
2469         * Misc/WebNSPasteboardExtras.mm:
2470         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2471         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2472         because they were identical.
2473
2474         * WebView/WebHTMLRepresentation.mm:
2475         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2476         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2477         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2478         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2479         * WebView/WebView.mm:
2480         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2481         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2482         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2483
2484 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2485
2486         Fix false positive leaks when using custom -init methods that don't start with -init
2487         <https://webkit.org/b/190818>
2488         <rdar://problem/45476042>
2489
2490         Reviewed by Dan Bernstein.
2491
2492         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2493         it is accessible by both categories.
2494         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2495         NSError (WebKitInternal) category.  Add attribute to make this
2496         behave like an -init method.
2497         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2498         NSError (WebKitInternal) category.  Modernize method.  Replace
2499         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2500
2501 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2502
2503         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2504         https://bugs.webkit.org/show_bug.cgi?id=190729
2505
2506         Reviewed by Tim Horton.
2507
2508         * DOM/DOM.mm:
2509         (-[DOMNode boundingBox]):
2510         * DOM/DOMElement.mm:
2511         * DOM/DOMHTML.mm:
2512         * DOM/DOMInternal.mm:
2513         * DOM/DOMUIKitExtensions.mm:
2514         * DOM/WebDOMOperations.mm:
2515         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2516         * DefaultDelegates/WebDefaultEditingDelegate.m:
2517         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2518         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2519         * DefaultDelegates/WebDefaultUIDelegate.h:
2520         * DefaultDelegates/WebDefaultUIDelegate.mm:
2521         (-[WebDefaultUIDelegate webViewClose:]):
2522         (-[WebDefaultUIDelegate webViewFocus:]):
2523         (-[WebDefaultUIDelegate webViewUnfocus:]):
2524         (-[WebDefaultUIDelegate webViewIsResizable:]):
2525         (-[WebDefaultUIDelegate webView:setResizable:]):
2526         (-[WebDefaultUIDelegate webView:setFrame:]):
2527         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2528         * History/BackForwardList.h:
2529         * History/BackForwardList.mm:
2530         * History/WebBackForwardList.mm:
2531         (+[WebBackForwardList initialize]):
2532         (bumperCarBackForwardHackNeeded):
2533         * History/WebHistory.mm:
2534         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2535         (-[WebHistory _sendNotification:entries:]):
2536         (-[WebHistory loadFromURL:error:]):
2537         (-[WebHistory saveToURL:error:]):
2538         * History/WebHistoryItem.mm:
2539         (WKNotifyHistoryItemChanged):
2540         (+[WebHistoryItem initialize]):
2541         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2542         * History/WebURLsWithTitles.m:
2543         * Misc/WebCache.mm:
2544         (+[WebCache initialize]):
2545         * Misc/WebDownload.mm:
2546         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2547         * Misc/WebElementDictionary.mm:
2548         (+[WebElementDictionary initialize]):
2549         (+[WebElementDictionary initializeLookupTable]):
2550         * Misc/WebIconDatabase.mm:
2551         * Misc/WebKitNSStringExtras.mm:
2552         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2553         * Misc/WebKitVersionChecks.h:
2554         * Misc/WebKitVersionChecks.mm:
2555         (WebKitLinkedOnOrAfter):
2556         (WebKitLinkTimeVersion):
2557         * Misc/WebLocalizableStrings.mm:
2558         * Misc/WebNSControlExtras.h:
2559         * Misc/WebNSControlExtras.m:
2560         * Misc/WebNSEventExtras.m:
2561         * Misc/WebNSFileManagerExtras.mm:
2562         * Misc/WebNSImageExtras.h:
2563         * Misc/WebNSImageExtras.m:
2564         * Misc/WebNSPasteboardExtras.mm:
2565         * Misc/WebNSPrintOperationExtras.h:
2566         * Misc/WebNSPrintOperationExtras.m:
2567         * Misc/WebNSViewExtras.m:
2568         * Misc/WebNSWindowExtras.m:
2569         * Panels/WebAuthenticationPanel.h:
2570         * Panels/WebAuthenticationPanel.m:
2571         * Panels/WebPanelAuthenticationHandler.m:
2572         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2573         (+[WebHostedNetscapePluginView initialize]):
2574         * Plugins/WebBasePluginPackage.h:
2575         * Plugins/WebBasePluginPackage.mm:
2576         * Plugins/WebJavaPlugIn.h:
2577         * Plugins/WebPluginContainerCheck.mm:
2578         * Plugins/WebPluginController.h:
2579         * Plugins/WebPluginController.mm:
2580         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2581         (-[WebPluginController addPlugin:]):
2582         (-[WebPluginController destroyPlugin:]):
2583         (-[WebPluginController destroyAllPlugins]):
2584         * Plugins/WebPluginDatabase.mm:
2585         (+[WebPluginDatabase _defaultPlugInPaths]):
2586         * Plugins/WebPluginPackage.mm:
2587         (-[WebPluginPackage initWithPath:]):
2588         * Storage/WebDatabaseManager.mm:
2589         (-[WebDatabaseManager deleteAllDatabases]):
2590         * Storage/WebDatabaseManagerClient.h:
2591         * Storage/WebDatabaseManagerClient.mm:
2592         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2593         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2594         * Storage/WebStorageManager.mm:
2595         (-[WebStorageManager deleteAllOrigins]):
2596         (WebKitInitializeStorageIfNecessary):
2597         * WebCoreSupport/WebAlternativeTextClient.h:
2598         * WebCoreSupport/WebApplicationCache.mm:
2599         (applicationCacheBundleIdentifier):
2600         * WebCoreSupport/WebChromeClient.h:
2601         * WebCoreSupport/WebChromeClient.mm:
2602         (WebChromeClient::setWindowRect):
2603         (WebChromeClient::windowRect):
2604         (WebChromeClient::takeFocus):
2605         (WebChromeClient::addMessageToConsole):
2606         (WebChromeClient::enableSuddenTermination):
2607         (WebChromeClient::disableSuddenTermination):
2608         (WebChromeClient::createPopupMenu const):
2609         (WebChromeClient::createSearchPopupMenu const):
2610         (WebChromeClient::shouldPaintEntireContents const):
2611         (WebChromeClient::supportsVideoFullscreen):
2612         (WebChromeClient::supportsFullScreenForElement):
2613         (WebChromeClient::enterFullScreenForElement):
2614         (WebChromeClient::exitFullScreenForElement):
2615         * WebCoreSupport/WebContextMenuClient.mm:
2616         * WebCoreSupport/WebDragClient.mm:
2617         * WebCoreSupport/WebEditorClient.h:
2618         * WebCoreSupport/WebEditorClient.mm:
2619         (+[WebUndoStep initialize]):
2620         (updateFontPanel):
2621         (WebEditorClient::didBeginEditing):
2622         (WebEditorClient::respondToChangedContents):
2623         (WebEditorClient::respondToChangedSelection):
2624         (WebEditorClient::canceledComposition):
2625         (WebEditorClient::didEndEditing):
2626         (WebEditorClient::didWriteSelectionToPasteboard):
2627         (attributesForAttributedStringConversion):
2628         (WebEditorClient::setInsertionPasteboard):
2629         (WebEditorClient::registerUndoOrRedoStep):
2630         (WebEditorClient::handleKeyboardEvent):
2631         (WebEditorClient::handleInputMethodKeydown):
2632         (WebEditorClient::textDidChangeInTextField):
2633         (WebEditorClient::requestCheckingOfString):
2634         * WebCoreSupport/WebFrameLoaderClient.h:
2635         * WebCoreSupport/WebFrameLoaderClient.mm:
2636         (WebFrameLoaderClient::detachedFromParent2):
2637         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2638         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2639         (WebFrameLoaderClient::dispatchWillSendRequest):
2640         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2641         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2642         (WebFrameLoaderClient::willCacheResponse const):
2643         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2644         (WebFrameLoaderClient::dispatchDidFinishLoading):
2645         (WebFrameLoaderClient::dispatchDidFailLoading):
2646         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2647         (WebFrameLoaderClient::dispatchWillClose):
2648         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2649         (WebFrameLoaderClient::dispatchDidCommitLoad):
2650         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2651         (WebFrameLoaderClient::dispatchDidFailLoad):
2652         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2653         (WebFrameLoaderClient::dispatchDidFinishLoad):
2654         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2655         (WebFrameLoaderClient::willChangeTitle):
2656         (WebFrameLoaderClient::didChangeTitle):
2657         (WebFrameLoaderClient::didReplaceMultipartContent):
2658         (WebFrameLoaderClient::updateGlobalHistory):
2659         (WebFrameLoaderClient::saveViewStateToItem):
2660         (WebFrameLoaderClient::restoreViewState):
2661         (WebFrameLoaderClient::provisionalLoadStarted):
2662         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2663         (WebFrameLoaderClient::setTitle):
2664         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2665         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2666         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2667         (WebFrameLoaderClient::didRestoreFromPageCache):
2668         (WebFrameLoaderClient::actionDictionary const):
2669         (WebFrameLoaderClient::createPlugin):
2670         (WebFrameLoaderClient::getLoadDecisionForIcons):
2671         (WebFrameLoaderClient::finishedLoadingIcon):
2672         (+[WebFramePolicyListener initialize]):
2673         * WebCoreSupport/WebFrameNetworkingContext.mm:
2674         * WebCoreSupport/WebGeolocationClient.h:
2675         * WebCoreSupport/WebGeolocationClient.mm:
2676         (WebGeolocationClient::requestPermission):
2677         * WebCoreSupport/WebInspectorClient.h:
2678         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2679         * WebCoreSupport/WebNotificationClient.mm:
2680         * WebCoreSupport/WebOpenPanelResultListener.mm:
2681         * WebCoreSupport/WebPlatformStrategies.h:
2682         * WebCoreSupport/WebPlatformStrategies.mm:
2683         * WebCoreSupport/WebProgressTrackerClient.h:
2684         * WebCoreSupport/WebProgressTrackerClient.mm:
2685         (WebProgressTrackerClient::progressStarted):
2686         (WebProgressTrackerClient::progressEstimateChanged):
2687         (WebProgressTrackerClient::progressFinished):
2688         * WebCoreSupport/WebSecurityOrigin.mm:
2689         * WebInspector/WebNodeHighlight.h:
2690         * WebInspector/WebNodeHighlight.mm:
2691         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2692         (-[WebNodeHighlight dealloc]):
2693         (-[WebNodeHighlight attach]):
2694         * WebInspector/WebNodeHighlightView.h:
2695         * WebInspector/WebNodeHighlightView.mm:
2696         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2697         (-[WebNodeHighlightView dealloc]):
2698         * WebInspector/WebNodeHighlighter.mm:
2699         (-[WebNodeHighlighter highlight]):
2700         * WebView/WebArchive.mm:
2701         (+[WebArchivePrivate initialize]):
2702         * WebView/WebClipView.h:
2703         * WebView/WebDataSource.mm:
2704         (WebDataSourcePrivate::WebDataSourcePrivate):
2705         (+[WebDataSource initialize]):
2706         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2707         (-[WebDataSource _makeRepresentation]):
2708         * WebView/WebDelegateImplementationCaching.h:
2709         * WebView/WebDelegateImplementationCaching.mm:
2710         (CallDelegate):
2711         (CallDelegateReturningFloat):
2712         (CallDelegateReturningBoolean):
2713         (CallUIDelegate):
2714         (CallUIDelegateReturningFloat):
2715         (CallUIDelegateReturningBoolean):
2716         (CallFrameLoadDelegate):
2717         (CallFrameLoadDelegateReturningBoolean):
2718         (CallResourceLoadDelegate):
2719         (CallScriptDebugDelegate):
2720         (CallFormDelegate):
2721         (CallFormDelegateReturningBoolean):
2722         * WebView/WebDeviceOrientation.mm:
2723         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2724         * WebView/WebDocumentInternal.h:
2725         * WebView/WebDocumentLoaderMac.mm:
2726         (needsDataLoadWorkaround):
2727         * WebView/WebDynamicScrollBarsViewInternal.h:
2728         * WebView/WebFormDelegate.m:
2729         * WebView/WebFrame.mm:
2730         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2731         (-[WebFrame _unmarkAllMisspellings]):
2732         (-[WebFrame _paintBehaviorForDestinationContext:]):
2733         (-[WebFrame _drawRect:contentsOnly:]):
2734         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2735         (-[WebFrame _scrollDOMRangeToVisible:]):
2736         (-[WebFrame _bodyBackgroundColor]):
2737         (-[WebFrame accessibilityRoot]):
2738         (needsMicrosoftMessengerDOMDocumentWorkaround):
2739         * WebView/WebFrameInternal.h:
2740         * WebView/WebFrameView.mm:
2741         (-[WebFrameView _setDocumentView:]):
2742         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2743         (-[WebFrameView _viewClassForMIMEType:]):
2744         (-[WebFrameView initWithFrame:]):
2745         (-[WebFrameView drawRect:]):
2746         (-[WebFrameView _firstResponderIsFormControl]):
2747         (-[WebFrameView keyDown:keyDown:]):
2748         (-[WebFrameView _isScrollable]):
2749         * WebView/WebFullScreenController.h:
2750         * WebView/WebFullScreenController.mm:
2751         * WebView/WebHTMLRepresentation.mm:
2752         * WebView/WebHTMLView.mm:
2753         (-[WebHTMLView hitTest:]):
2754         (-[WebHTMLView initWithFrame:]):
2755         (-[WebHTMLView dealloc]):
2756         (-[WebHTMLView addSubview:]):
2757         (-[WebHTMLView mouseDown:]):
2758         (-[WebHTMLView mouseUp:]):
2759         (-[WebHTMLView resignFirstResponder]):
2760         (-[WebHTMLView accessibilityHitTest:]):
2761         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2762         * WebView/WebHTMLViewInternal.h:
2763         * WebView/WebIndicateLayer.h:
2764         * WebView/WebIndicateLayer.mm:
2765         * WebView/WebMediaPlaybackTargetPicker.h:
2766         * WebView/WebMediaPlaybackTargetPicker.mm:
2767         * WebView/WebPDFDocumentExtras.h:
2768         * WebView/WebPDFDocumentExtras.mm:
2769         * WebView/WebPDFRepresentation.h:
2770         * WebView/WebPDFRepresentation.mm:
2771         * WebView/WebPDFView.h:
2772         * WebView/WebPreferences.mm:
2773         (cacheModelForMainBundle):
2774         (WebPreferencesPrivate::WebPreferencesPrivate):
2775         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2776         (-[WebPreferences encodeWithCoder:]):
2777         (+[WebPreferences standardPreferences]):
2778         (+[WebPreferences initialize]):
2779         (-[WebPreferences _valueForKey:]):
2780         (-[WebPreferences _setStringValue:forKey:]):
2781         (-[WebPreferences _setIntegerValue:forKey:]):
2782         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2783         (-[WebPreferences _setFloatValue:forKey:]):
2784         (-[WebPreferences _setBoolValue:forKey:]):
2785         (-[WebPreferences _setLongLongValue:forKey:]):
2786         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2787         (-[WebPreferences _postCacheModelChangedNotification]):
2788         (-[WebPreferences _postPreferencesChangedNotification]):
2789         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2790         (-[WebPreferences setStorageBlockingPolicy:]):
2791         * WebView/WebResource.mm:
2792         (+[WebResourcePrivate initialize]):
2793         * WebView/WebTextCompletionController.h:
2794         * WebView/WebTextIterator.mm:
2795         (+[WebTextIteratorPrivate initialize]):
2796         * WebView/WebView.mm:
2797         (shouldEnableLoadDeferring):
2798         (shouldRestrictWindowFocus):
2799         (shouldRespectPriorityInCSSAttributeSetters):
2800         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2801         (shouldAllowPictureInPictureMediaPlayback):
2802         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2803         (shouldAllowWindowOpenWithoutUserGesture):
2804         (shouldConvertInvalidURLsToBlank):
2805         (shouldRequireUserGestureToLoadVideo):
2806         (-[WebView _commonInitializationWithFrameName:groupName:]):
2807         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2808         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2809         (-[WebView _closePluginDatabases]):
2810         (-[WebView _closeWithFastTeardown]):
2811         (-[WebView _close]):
2812         (+[WebView _MIMETypeForFile:]):
2813         (-[WebView setShowingInspectorIndication:]):
2814         (-[WebView _setFormDelegate:]):
2815         (-[WebView _needsPreHTML5ParserQuirks]):
2816         (-[WebView _preferencesChangedNotification:]):
2817         (-[WebView _preferencesChanged:]):
2818         (-[WebView _cacheResourceLoadDelegateImplementations]):
2819         (-[WebView _cacheFrameLoadDelegateImplementations]):
2820         (-[WebView _policyDelegateForwarder]):
2821         (-[WebView _UIDelegateForwarder]):
2822         (-[WebView _editingDelegateForwarder]):
2823         (-[WebView _updateActiveState]):
2824         (-[_WebSafeForwarder forwardInvocation:]):
2825         (+[WebView initialize]):
2826         (-[WebView _pluginForMIMEType:]):
2827         (-[WebView _pluginForExtension:]):
2828         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2829         (+[WebView canShowMIMETypeAsHTML:]):
2830         (-[WebView _initWithArguments:]):
2831         (-[WebView initWithFrame:frameName:groupName:]):
2832         (-[WebView dealloc]):
2833         (-[WebView close]):
2834         (-[WebView viewDidMoveToWindow]):
2835         (-[WebView setUIDelegate:]):
2836         (-[WebView setResourceLoadDelegate:]):
2837         (-[WebView setPolicyDelegate:]):
2838         (-[WebView setFrameLoadDelegate:]):
2839         (-[WebView goBack]):
2840         (-[WebView goForward]):
2841         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2842         (-[WebView setHostWindow:]):
2843         (-[WebView becomeFirstResponder]):
2844         (+[WebView _cacheModelChangedNotification:]):
2845         (-[WebView _frameViewAtWindowPoint:]):
2846         (+[WebView _preflightSpellCheckerNow:]):
2847         (+[WebView _preflightSpellChecker]):
2848         (-[WebView canGoBack]):
2849         (-[WebView canGoForward]):
2850         (-[WebView stopLoading:]):
2851         (-[WebView reload:]):
2852         (-[WebView setMainFrameDocumentReady:]):
2853         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2854         (-[WebView setContinuousSpellCheckingEnabled:]):
2855         (-[WebView undoManager]):
2856         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2857         (-[WebView isAutomaticLinkDetectionEnabled]):
2858         (-[WebView isAutomaticDashSubstitutionEnabled]):
2859         (-[WebView isAutomaticTextReplacementEnabled]):
2860         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2861         (+[WebView _setCacheModel:]):
2862         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2863         (-[WebView _keyboardUIMode]):
2864         (LayerFlushController::flushLayers):
2865         (-[WebView _scheduleCompositingLayerFlush]):
2866         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2867         (-[WebView fullScreenPlaceholderView]):
2868         (WebInstallMemoryPressureHandler):
2869         * WebView/WebViewData.h:
2870         * WebView/WebViewData.mm:
2871         (+[WebViewPrivate initialize]):
2872         (-[WebViewPrivate init]):
2873         (-[WebViewPrivate dealloc]):
2874         * WebView/WebViewInternal.h:
2875
2876 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2877
2878         Clean up FrameLoader two-state enums
2879         https://bugs.webkit.org/show_bug.cgi?id=190731
2880
2881         Reviewed by Chris Dumez.
2882
2883         * WebCoreSupport/WebFrameLoaderClient.h:
2884         * WebCoreSupport/WebFrameLoaderClient.mm:
2885         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2886
2887 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2888
2889         Unreviewed, rolling out r237137.
2890
2891         SPI is actually used
2892
2893         Reverted changeset:
2894
2895         "Remove unused WebFrame._loadType"
2896         https://bugs.webkit.org/show_bug.cgi?id=190583
2897         https://trac.webkit.org/changeset/237137
2898
2899 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2900
2901         Enable the datalist element by default on iOS and macOS
2902         https://bugs.webkit.org/show_bug.cgi?id=190594
2903         <rdar://problem/45281159>
2904
2905         Reviewed by Ryosuke Niwa and Tim Horton.
2906
2907         * Configurations/FeatureDefines.xcconfig:
2908
2909 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2910
2911         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2912         https://bugs.webkit.org/show_bug.cgi?id=190675
2913
2914         Reviewed by Chris Dumez.
2915
2916         * History/BackForwardList.h:
2917         * History/BackForwardList.mm:
2918         (BackForwardList::backItem):
2919         (BackForwardList::currentItem):
2920         (BackForwardList::forwardItem):
2921         (BackForwardList::backListCount const):
2922         (BackForwardList::forwardListCount const):
2923         (BackForwardList::itemAtIndex):
2924         * History/WebBackForwardList.mm:
2925         (-[WebBackForwardList backItem]):
2926         (-[WebBackForwardList currentItem]):
2927         (-[WebBackForwardList forwardItem]):
2928         (-[WebBackForwardList itemAtIndex:]):
2929
2930 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2931
2932         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2933         https://bugs.webkit.org/show_bug.cgi?id=190526
2934         rdar://problem/45230140
2935
2936         Reviewed by Dean Jackson.
2937
2938         * WebCoreSupport/WebEditorClient.mm:
2939         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2940
2941 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2942
2943         Implement feature flag and bindings for CSS Painting API
2944         https://bugs.webkit.org/show_bug.cgi?id=190237
2945
2946         Reviewed by Ryosuke Niwa.
2947
2948         * Configurations/FeatureDefines.xcconfig:
2949
2950 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2951
2952         Replace HistoryItem* with HistoryItem& where possible
2953         https://bugs.webkit.org/show_bug.cgi?id=190617
2954
2955         Reviewed by Chris Dumez.
2956
2957         * History/BackForwardList.h:
2958         * History/BackForwardList.mm:
2959         (BackForwardList::goToItem):
2960         * History/WebBackForwardList.mm:
2961         (-[WebBackForwardList goToItem:]):
2962         * History/WebHistoryItem.mm:
2963         (WKNotifyHistoryItemChanged):
2964         * History/WebHistoryItemInternal.h:
2965
2966 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2967
2968         Remove unused WebHistoryItem._transientPropertyForKey
2969         https://bugs.webkit.org/show_bug.cgi?id=190606
2970
2971         Reviewed by Chris Dumez.
2972
2973         * History/WebHistoryItem.mm:
2974         * History/WebHistoryItemPrivate.h:
2975
2976 2018-10-15  Justin Fan  <justin_fan@apple.com>
2977
2978         Add WebGPU 2018 feature flag and experimental feature flag
2979         https://bugs.webkit.org/show_bug.cgi?id=190509
2980
2981         Reviewed by Dean Jackson.
2982
2983         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2984         for the 2018 WebGPU prototype.
2985
2986         * Configurations/FeatureDefines.xcconfig:
2987         * WebView/WebPreferenceKeysPrivate.h:
2988         * WebView/WebPreferences.mm:
2989         (+[WebPreferences initialize]):
2990         (-[WebPreferences webGPUEnabled]):
2991         (-[WebPreferences setWebGPUEnabled:]):
2992         * WebView/WebPreferencesPrivate.h:
2993         * WebView/WebView.mm:
2994         (-[WebView _preferencesChanged:]):
2995
2996 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2997
2998         Fix iOS build after r237157
2999
3000         * WebView/WebView.mm:
3001         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3002
3003 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3004
3005         Modernize BackForwardClient.h
3006         https://bugs.webkit.org/show_bug.cgi?id=190610
3007
3008         Reviewed by Chris Dumez.
3009
3010         * History/BackForwardList.h:
3011         * History/BackForwardList.mm:
3012         (BackForwardList::backListCount const):
3013         (BackForwardList::forwardListCount const):
3014         (BackForwardList::backListCount): Deleted.
3015         (BackForwardList::forwardListCount): Deleted.
3016         * History/WebBackForwardList.mm:
3017         (-[WebBackForwardList init]):
3018         * WebCoreSupport/WebFrameLoaderClient.mm:
3019         (WebFrameLoaderClient::canCachePage const):
3020         * WebView/WebFrameView.mm:
3021         (-[WebFrameView keyDown:keyDown:]):
3022         * WebView/WebView.mm:
3023         (-[WebView _commonInitializationWithFrameName:groupName:]):
3024         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
3025         (-[WebView _loadBackForwardListFromOtherView:]):
3026         (-[WebView initWithCoder:]):
3027         (-[WebView encodeWithCoder:]):
3028         (-[WebView backForwardList]):
3029         (-[WebView setMaintainsBackForwardList:]):
3030
3031 2018-10-15  Timothy Hatcher  <timothy@apple.com>
3032
3033         Add support for prefers-color-scheme media query
3034         https://bugs.webkit.org/show_bug.cgi?id=190499
3035         rdar://problem/45212025
3036
3037         Reviewed by Dean Jackson.
3038
3039         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
3040
3041 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3042
3043         Remove unused WebView._globalHistoryItem
3044         https://bugs.webkit.org/show_bug.cgi?id=190601
3045
3046         Reviewed by Chris Dumez.
3047
3048         * WebCoreSupport/WebFrameLoaderClient.h:
3049         * WebCoreSupport/WebFrameLoaderClient.mm:
3050         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
3051         * WebView/WebView.mm:
3052         (-[WebView _globalHistoryItem]): Deleted.
3053         (-[WebView _setGlobalHistoryItem:]): Deleted.
3054         * WebView/WebViewData.h:
3055         * WebView/WebViewInternal.h:
3056         * WebView/WebViewPrivate.h:
3057
3058 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3059
3060         Remove unused parameters from FrameLoaderClient::createFrame
3061         https://bugs.webkit.org/show_bug.cgi?id=190587
3062
3063         Reviewed by Chris Dumez.
3064
3065         * WebCoreSupport/WebFrameLoaderClient.h:
3066         * WebCoreSupport/WebFrameLoaderClient.mm:
3067         (WebFrameLoaderClient::createFrame):
3068
3069 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3070
3071         Remove unused WebFrame._loadType
3072         https://bugs.webkit.org/show_bug.cgi?id=190583
3073
3074         Reviewed by Chris Dumez.
3075
3076         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
3077
3078         * WebView/WebFrame.mm:
3079         (toWebFrameLoadType): Deleted.
3080         (-[WebFrame _loadType]): Deleted.
3081         * WebView/WebFramePrivate.h:
3082
3083 2018-10-15  Chris Dumez  <cdumez@apple.com>
3084
3085         Restrict browsing context lookup by name to frames that are related to one another
3086         https://bugs.webkit.org/show_bug.cgi?id=190475
3087
3088         Reviewed by Alex Christensen.
3089
3090         * WebView/WebFrame.mm:
3091         (-[WebFrame findFrameNamed:]):
3092
3093 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3094
3095         Remove InjectedBundle processing of back/forward lists
3096         https://bugs.webkit.org/show_bug.cgi?id=190459
3097
3098         Reviewed by Chris Dumez.
3099
3100         * WebCoreSupport/WebFrameLoaderClient.h:
3101         * WebCoreSupport/WebFrameLoaderClient.mm:
3102         (WebFrameLoaderClient::shouldGoToHistoryItem const):
3103
3104 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3105
3106         [JSC] Remove Option::useAsyncIterator
3107         https://bugs.webkit.org/show_bug.cgi?id=190567
3108
3109         Reviewed by Saam Barati.
3110
3111         * Configurations/FeatureDefines.xcconfig:
3112
3113 2018-10-12  Alex Christensen  <achristensen@webkit.org>
3114
3115         Allow encoding of small enum classes
3116         https://bugs.webkit.org/show_bug.cgi?id=190531
3117
3118         Reviewed by Tim Horton.
3119
3120         * WebCoreSupport/WebFrameLoaderClient.mm:
3121         (-[WebFramePolicyListener dealloc]):
3122
3123 2018-10-11  Keith Rollin  <krollin@apple.com>
3124
3125         CURRENT_ARCH should not be used in Run Script phase.
3126         https://bugs.webkit.org/show_bug.cgi?id=190407
3127         <rdar://problem/45133556>
3128
3129         Reviewed by Alexey Proskuryakov.
3130
3131         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
3132         CURRENT_ARCH is not well-defined during this phase (and may even have
3133         the value "undefined") since this phase is run just once per build
3134         rather than once per supported architecture. Migrate away from
3135         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
3136         performing an operation for each value, or by picking the first entry
3137         in ARCHS and using that as a representative value.
3138
3139         * Configurations/WebKitLegacy.xcconfig: When generating
3140         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
3141         macosx platforms.
3142
3143         * MigrateHeaders.make:
3144         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
3145         generate one for each architecture in ARCHS.
3146
3147 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3148
3149         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3150         https://bugs.webkit.org/show_bug.cgi?id=190429
3151
3152         Reviewed by Saam Barati.
3153
3154         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
3155
3156         * WebView/WebPDFRepresentation.mm:
3157         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
3158
3159 2018-10-08  Justin Fan  <justin_fan@apple.com>
3160
3161         WebGPU: Rename old WebGPU prototype to WebMetal
3162         https://bugs.webkit.org/show_bug.cgi?id=190325
3163         <rdar://problem/44990443>
3164
3165         Reviewed by Dean Jackson.
3166
3167         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3168
3169         * Configurations/FeatureDefines.xcconfig:
3170         * WebView/WebPreferenceKeysPrivate.h:
3171         * WebView/WebPreferences.mm:
3172         (+[WebPreferences initialize]):
3173         (-[WebPreferences webMetalEnabled]):
3174         (-[WebPreferences setWebMetalEnabled:]):
3175         (-[WebPreferences webGPUEnabled]): Deleted.
3176         (-[WebPreferences setWebGPUEnabled:]): Deleted.
3177         * WebView/WebPreferencesPrivate.h:
3178         * WebView/WebView.mm:
3179         (-[WebView _preferencesChanged:]):
3180
3181 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3182
3183         Make <input type=color> a runtime enabled (on-by-default) feature
3184         https://bugs.webkit.org/show_bug.cgi?id=189162
3185
3186         Reviewed by Wenson Hsieh and Tim Horton.
3187
3188         * Configurations/FeatureDefines.xcconfig:
3189
3190 2018-10-07  Dan Bernstein  <mitz@apple.com>
3191
3192         Fixed building with the latest macOS SDK
3193
3194         * Plugins/WebNetscapePluginPackage.mm:
3195         (-[WebNetscapePluginPackage openResourceFile]):
3196         (-[WebNetscapePluginPackage closeResourceFile:]):
3197
3198 2018-10-04  Dan Bernstein  <mitz@apple.com>
3199
3200         More Carbon build-fixing.
3201
3202         * Carbon/CarbonWindowAdapter.mm:
3203         (-[CarbonWindowAdapter _destroyRealWindow:]):
3204         (-[CarbonWindowAdapter _growBoxRect]):
3205
3206 2018-10-04  Dan Bernstein  <mitz@apple.com>
3207
3208         Retried to fix 32-bit macOS builds after r236846.
3209
3210         * WebView/WebHTMLView.mm:
3211         (-[WebHTMLView setMarkedText:selectedRange:]):
3212
3213 2018-10-04  Dan Bernstein  <mitz@apple.com>
3214
3215         Retried to fix 32-bit macOS builds after r236846.
3216
3217         * Carbon/HIWebView.mm:
3218         (ActiveStateChanged):
3219
3220 2018-10-04  Dan Bernstein  <mitz@apple.com>
3221
3222         Tried to fix 32-bit macOS builds after r236846.
3223
3224         * Carbon/HIWebView.mm:
3225         (_NSSelectorForHICommand):
3226
3227 2018-10-04  Dan Bernstein  <mitz@apple.com>
3228
3229         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
3230         https://bugs.webkit.org/show_bug.cgi?id=190250
3231
3232         Reviewed by Andy Estes.
3233
3234         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
3235           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3236           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
3237           an earlier line set it to YES.
3238
3239         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
3240         changes below.
3241
3242         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
3243           provides some missing method declarations.
3244
3245         * Misc/WebDownload.mm:
3246         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
3247           a deprecated method.
3248
3249         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
3250
3251         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
3252           other code in the file uses a method from it.
3253
3254         * Plugins/WebBaseNetscapePluginView.mm:
3255         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
3256           a deprecated method.
3257
3258         * Plugins/WebPluginController.mm:
3259         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
3260           around use of a selector that may be present in some WebKit client.
3261
3262         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
3263           method declarations.
3264
3265         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
3266           from here.
3267
3268         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
3269           missing method declarations.
3270
3271         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
3272           from here.
3273
3274         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
3275           call from here.
3276         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
3277           an obsolete delegate method for binary compatibility.
3278         (pluginView): Ditto.
3279
3280         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
3281           call from here.
3282
3283         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
3284           WebDeviceOrientationProviderMock protocol.
3285
3286         * WebView/WebDeviceOrientationProviderMock.mm:
3287         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
3288           main @implementation.
3289
3290         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
3291           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
3292
3293         * WebView/WebDynamicScrollBarsView.mm:
3294         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
3295           of a deprecated method.
3296
3297         * WebView/WebHTMLView.mm:
3298         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
3299           selector warning around action methods that are not declared anywhere in WebKit.
3300
3301         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
3302           about implementing this deprecated method.
3303         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
3304         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3305         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3306         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3307         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3308         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3309         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3310         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3311         (-[WebHTMLView doCommandBySelector:]): Ditto.
3312         (-[WebHTMLView insertText:]): Ditto.
3313
3314         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
3315
3316         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
3317
3318         * WebView/WebPDFView.h: Removed previewView ivar.
3319
3320         * WebView/WebPDFView.mm:
3321           Removed declaration of FileInternal category and merged its implementation with the main
3322           implementation.
3323         (-[WebPDFView dealloc]): Removed previewView ivar.
3324         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
3325           exist in macOS versions we support.
3326         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
3327         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
3328           action methods internal to PDFKit.
3329         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
3330         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
3331
3332         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
3333           call on macOS, even though in r86988 we started calling different methods on iOS.
3334
3335         * WebView/WebView.mm:
3336         - Imported headers that declare delegate methods that we call.
3337         - Removed declaration of WebFileInternal category and merged its implementation with the
3338           main implementation.
3339         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
3340           category, which made them impossible to call from the main implementation. Moved those
3341           into the main implementation. One of those had to be declared in a class extension,
3342           because it is called from a method implemented in the WebPrivate category, and that
3343           category’s implementation appears first in the file.
3344
3345         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
3346           around use of obsolete delegate method for binary compatibility.
3347
3348         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
3349
3350 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3351
3352         Runtime flag and IDL for MediaRecorder
3353         https://bugs.webkit.org/show_bug.cgi?id=190018
3354
3355         Reviewed by Youenn Fablet and Chris Dumez.
3356
3357         * WebView/WebPreferenceKeysPrivate.h:
3358         * WebView/WebPreferences.mm:
3359         (+[WebPreferences initialize]):
3360         (-[WebPreferences mediaRecorderEnabled]):
3361         (-[WebPreferences setMediaRecorderEnabled:]):
3362         * WebView/WebPreferencesPrivate.h:
3363         * WebView/WebView.mm:
3364         (-[WebView _preferencesChanged:]):
3365
3366 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3367
3368         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3369         https://bugs.webkit.org/show_bug.cgi?id=190238
3370
3371         Reviewed by Antti Koivisto.
3372
3373         Enabled the feature by default.
3374
3375         * WebView/WebPreferences.mm:
3376         (+[WebPreferences initialize]):
3377
3378 2018-10-01  Dean Jackson  <dino@apple.com>
3379
3380         [macOS] Switching to discrete GPU should be done in the UI process
3381         https://bugs.webkit.org/show_bug.cgi?id=189361
3382         <rdar://problem/43949622>
3383
3384         Reviewed by Simon Fraser.
3385
3386         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
3387         not support swapping to the discrete GPU in this configuration.
3388
3389         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
3390         (WebKit::WebSwitchingGPUClient::singleton):
3391         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
3392         * WebView/WebView.mm:
3393         (-[WebView _commonInitializationWithFrameName:groupName:]):
3394
3395 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3396
3397         Remove ParsedURLString
3398         https://bugs.webkit.org/show_bug.cgi?id=190154
3399
3400         Reviewed by Chris Dumez.
3401
3402         * WebView/WebScriptDebugger.mm:
3403         (toNSURL):
3404
3405 2018-10-01  Dean Jackson  <dino@apple.com>
3406
3407         Remove CSS Animation Triggers
3408         https://bugs.webkit.org/show_bug.cgi?id=190175
3409         <rdar://problem/44925626>
3410
3411         Reviewed by Simon Fraser.
3412
3413         * Configurations/FeatureDefines.xcconfig:
3414
3415 2018-10-02  Commit Queue  <commit-queue@webkit.org>
3416
3417         Unreviewed, rolling out r236624 and r236671.
3418         https://bugs.webkit.org/show_bug.cgi?id=190207
3419
3420         The change in r236624 introduced crashes on the bots
3421         (Requested by ryanhaddad on #webkit).
3422
3423         Reverted changesets:
3424
3425         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3426         https://bugs.webkit.org/show_bug.cgi?id=188747
3427         https://trac.webkit.org/changeset/236624
3428
3429         "Unify implementation in VideoFullscreenInterfaceAVKit"
3430         https://bugs.webkit.org/show_bug.cgi?id=190091
3431         https://trac.webkit.org/changeset/236671
3432
3433 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3434
3435         URL should not use TextEncoding internally
3436         https://bugs.webkit.org/show_bug.cgi?id=190111
3437
3438         Reviewed by Andy Estes.
3439
3440         * Misc/WebNSURLExtras.mm:
3441
3442 2018-09-28  Jer Noble  <jer.noble@apple.com>
3443
3444         Refactoring: eliminate raw pointer usage in Fullscreen code
3445         https://bugs.webkit.org/show_bug.cgi?id=188747
3446         <rdar://problem/43541164>
3447
3448         Reviewed by Alex Christensen.
3449
3450         PlaybackSessionInterface no longer has an invalidate() method.
3451
3452         * WebView/WebView.mm:
3453         (-[WebView _clearPlaybackControlsManager]):
3454
3455 2018-09-28  Chris Dumez  <cdumez@apple.com>
3456
3457         Drop support for cross-origin-window-policy header
3458         https://bugs.webkit.org/show_bug.cgi?id=190081
3459
3460         Reviewed by Ryosuke Niwa.
3461
3462         * WebView/WebPreferenceKeysPrivate.h:
3463         * WebView/WebPreferences.mm:
3464         (+[WebPreferences initialize]):
3465         * WebView/WebPreferencesPrivate.h:
3466         * WebView/WebView.mm:
3467         (-[WebView _preferencesChanged:]):
3468
3469 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3470
3471         Rename createMarkup to serializePreservingVisualAppearance
3472         https://bugs.webkit.org/show_bug.cgi?id=190086
3473
3474         Reviewed by Wenson Hsieh.
3475
3476         * DOM/WebDOMOperations.mm:
3477         (-[DOMRange markupString]):
3478
3479 2018-09-28  Commit Queue  <commit-queue@webkit.org>
3480
3481         Unreviewed, rolling out r236605.
3482         https://bugs.webkit.org/show_bug.cgi?id=190087
3483
3484         caused three API test timeouts (Requested by jernoble on
3485         #webkit).
3486
3487         Reverted changeset:
3488
3489         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3490         https://bugs.webkit.org/show_bug.cgi?id=188747
3491         https://trac.webkit.org/changeset/236605
3492
3493 2018-09-28  Jer Noble  <jer.noble@apple.com>
3494
3495         Refactoring: eliminate raw pointer usage in Fullscreen code
3496         https://bugs.webkit.org/show_bug.cgi?id=188747
3497         <rdar://problem/43541164>
3498
3499         Reviewed by Alex Christensen.
3500
3501         PlaybackSessionInterface no longer has an invalidate() method.
3502
3503         * WebView/WebView.mm:
3504         (-[WebView _clearPlaybackControlsManager]):
3505
3506 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3507
3508         Use enum class in createMarkup arguments
3509         https://bugs.webkit.org/show_bug.cgi?id=190028
3510
3511         Reviewed by Wenson Hsieh.
3512
3513         * DOM/WebDOMOperations.mm:
3514         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
3515         (-[DOMRange markupString]): Ditto.
3516
3517 2018-09-27  Antoine Quint  <graouts@apple.com>
3518
3519         [Web Animations] Turn Web Animations with CSS integration on
3520         https://bugs.webkit.org/show_bug.cgi?id=184819
3521         <rdar://problem/39597337>
3522
3523         Reviewed by Dean Jackson.
3524
3525         * WebView/WebPreferences.mm:
3526         (+[WebPreferences initialize]):
3527
3528 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3529
3530         Selection should work across shadow boundary when initiated by a mouse drag
3531         https://bugs.webkit.org/show_bug.cgi?id=151380
3532         <rdar://problem/24363872>
3533
3534         Reviewed by Wenson Hsieh.
3535
3536         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
3537
3538         * WebView/WebPreferenceKeysPrivate.h:
3539         * WebView/WebPreferences.mm:
3540         (+[WebPreferences initialize]):
3541         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
3542         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
3543         * WebView/WebPreferencesPrivate.h:
3544         * WebView/WebView.mm:
3545         (-[WebView _preferencesChanged:]):
3546
3547 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3548
3549         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3550         https://bugs.webkit.org/show_bug.cgi?id=189918
3551         Work towards <rdar://problem/44648705>
3552
3553         Reviewed by Tim Horton.
3554
3555         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3556
3557         * WebView/WebHTMLView.mm:
3558         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3559         (-[WebHTMLView _updateFontPanel]):
3560         * WebView/WebView.mm:
3561         (-[WebView typingAttributes]):
3562
3563 2018-09-17  Darin Adler  <darin@apple.com>
3564
3565         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3566         https://bugs.webkit.org/show_bug.cgi?id=189652
3567
3568         Reviewed by Saam Barati.
3569
3570         * WebView/WebPDFRepresentation.mm:
3571         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3572
3573 2018-09-14  Jer Noble  <jer.noble@apple.com>
3574
3575         Turn SourceBufferChangeTypeEnabled on by default
3576         https://bugs.webkit.org/show_bug.cgi?id=189527
3577
3578         Reviewed by Eric Carlson.
3579
3580         * WebView/WebPreferences.mm:
3581         (+[WebPreferences initialize]):
3582
3583 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3584
3585         Fix an internal build after r235935
3586         https://bugs.webkit.org/show_bug.cgi?id=188996
3587
3588         * Carbon/HIWebView.mm:
3589         (Draw):
3590         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3591
3592 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3593
3594         Add IGNORE_WARNING_.* macros
3595         https://bugs.webkit.org/show_bug.cgi?id=188996
3596
3597         Reviewed by Michael Catanzaro.
3598
3599         * Carbon/CarbonUtils.m:
3600         (PoolCleaner):
3601         * Carbon/CarbonWindowAdapter.mm:
3602         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3603         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3604         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3605         (-[CarbonWindowAdapter _termWindowIfOwner]):
3606         (-[CarbonWindowAdapter _windowMovedToRect:]):
3607         (-[CarbonWindowAdapter setContentView:]):
3608         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3609         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3610         * Carbon/CarbonWindowFrame.m:
3611         (-[CarbonWindowFrame title]):
3612         * Carbon/HIViewAdapter.m:
3613         (+[HIViewAdapter getHIViewForNSView:]):
3614         * Carbon/HIWebView.mm:
3615         (overrideCGContext):
3616         (restoreCGContext):
3617         (Draw):
3618         * DOM/DOM.mm:
3619         * History/WebHistory.mm:
3620         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3621         * History/WebHistoryItem.mm:
3622         (-[WebHistoryItem icon]):
3623         * Misc/WebKitNSStringExtras.mm:
3624         (-[NSString _web_drawAtPoint:font:textColor:]):
3625         * Misc/WebNSImageExtras.m:
3626         (-[NSImage _web_scaleToMaxSize:]):
3627         (-[NSImage _web_dissolveToFraction:]):
3628         * Misc/WebNSPasteboardExtras.mm:
3629         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3630         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3631         * Panels/WebAuthenticationPanel.m:
3632         (-[WebAuthenticationPanel loadNib]):
3633         * Plugins/Hosted/NetscapePluginHostManager.mm:
3634         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3635         (WebKit::NetscapePluginHostManager::didCreateWindow):
3636         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3637         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3638         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3639         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3640         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3641         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3642         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3643         (-[WebHostedNetscapePluginView drawRect:]):
3644         * Plugins/Hosted/WebTextInputWindowController.m:
3645         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3646         * Plugins/WebBaseNetscapePluginView.mm:
3647         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3648         * Plugins/WebNetscapePluginPackage.mm:
3649         (-[WebNetscapePluginPackage _tryLoad]):
3650         * Plugins/WebNetscapePluginView.mm:
3651         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3652         (-[WebNetscapePluginView sendDrawRectEvent:]):
3653         (-[WebNetscapePluginView drawRect:]):
3654         * Plugins/WebPluginController.mm:
3655         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3656         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3657         * WebCoreSupport/PopupMenuMac.mm:
3658         (PopupMenuMac::populate):
3659         * WebCoreSupport/WebAlternativeTextClient.h:
3660         * WebCoreSupport/WebDragClient.mm:
3661         (WebDragClient::startDrag):
3662         * WebCoreSupport/WebFrameLoaderClient.mm:
3663         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3664         (webGetNSImage):
3665         * WebInspector/WebNodeHighlight.mm:
3666         * WebInspector/WebNodeHighlightView.mm:
3667         (-[WebNodeHighlightView drawRect:]):
3668         * WebView/WebClipView.mm:
3669         (-[WebClipView initWithFrame:]):
3670         * WebView/WebFrame.mm:
3671         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3672         (-[WebFrame _drawRect:contentsOnly:]):
3673         (-[WebFrame accessibilityRoot]):
3674         * WebView/WebFullScreenController.mm:
3675         (-[WebFullScreenController enterFullScreen:]):
3676         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3677         (-[WebFullScreenController exitFullScreen]):
3678         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3679         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3680         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3681         * WebView/WebHTMLView.mm:
3682         (-[NSWindow _web_borderView]):
3683         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3684         (-[WebHTMLView _setAsideSubviews]):
3685         (-[WebHTMLView _autoscroll]):
3686         (-[WebHTMLView drawRect:]):
3687         (-[WebHTMLView mouseDown:]):
3688         (-[WebHTMLView mouseDragged:]):
3689         (-[WebHTMLView mouseUp:]):
3690         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3691         (-[WebHTMLView knowsPageRange:]):
3692         (-[WebHTMLView accessibilityHitTest:]):
3693         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3694         (-[WebHTMLView _colorAsString:]):
3695         (-[WebHTMLView copyFont:]):
3696         (-[WebHTMLView _executeSavedKeypressCommands]):
3697         (-[WebHTMLView attachRootLayer:]):
3698         (-[WebHTMLView textStorage]):
3699         (-[WebHTMLView _updateSelectionForInputManager]):
3700         * WebView/WebPDFView.mm:
3701         (_applicationInfoForMIMEType):
3702         (-[WebPDFView centerSelectionInVisibleArea:]):
3703         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3704         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3705         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3706         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3707         * WebView/WebTextCompletionController.mm:
3708         (-[WebTextCompletionController _buildUI]):
3709         (-[WebTextCompletionController _placePopupWindow:]):
3710         * WebView/WebVideoFullscreenController.mm:
3711         * WebView/WebVideoFullscreenHUDWindowController.mm:
3712         (createMediaUIBackgroundView):
3713         * WebView/WebView.mm:
3714         (-[WebTextListTouchBarViewController initWithWebView:]):
3715         (-[WebView _dispatchTileDidDraw:]):
3716         (-[WebView encodeWithCoder:]):
3717         (-[WebView mainFrameIcon]):
3718         (LayerFlushController::flushLayers):
3719         * WebView/WebWindowAnimation.mm:
3720         (setScaledFrameForWindow):
3721
3722 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3723
3724         Remove unused needsDestruction class variables from HashTraits
3725         https://bugs.webkit.org/show_bug.cgi?id=189490
3726
3727         Reviewed by Daniel Bates.
3728
3729         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3730
3731 2018-09-07  Frederic Wang  <fwang@igalia.com>
3732
3733         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3734         https://bugs.webkit.org/show_bug.cgi?id=182230
3735
3736         Reviewed by Simon Fraser.
3737
3738         * DOM/DOMDocument.mm:
3739         (-[DOMDocument scrollingElement]): Use the new name.
3740
3741 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3742
3743         Refactor WebCore::EditAction to be an 8-bit enum class
3744         https://bugs.webkit.org/show_bug.cgi?id=189383
3745
3746         Reviewed by Dan Bernstein.
3747
3748         * WebCoreSupport/WebEditorClient.mm:
3749         (undoNameForEditAction):
3750         * WebView/WebHTMLView.mm:
3751         (-[WebHTMLView pasteFont:]):
3752         (-[WebHTMLView changeFont:]):
3753         (-[WebHTMLView changeAttributes:]):
3754         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3755         (-[WebHTMLView changeColor:]):
3756         * WebView/WebView.mm:
3757         (-[WebView setTypingStyle:]):
3758
3759 2018-09-06  Frederic Wang  <fwang@igalia.com>
3760
3761         Group options of scrollRectToVisible into a struct
3762         https://bugs.webkit.org/show_bug.cgi?id=189352
3763
3764         Reviewed by Simon Fraser.
3765
3766         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3767         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3768         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3769
3770 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3771
3772         [macOS] Cannot change font size at selection until font panel is shown
3773         https://bugs.webkit.org/show_bug.cgi?id=189295
3774         <rdar://problem/35593389>
3775
3776         Reviewed by Ryosuke Niwa.
3777
3778         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3779         WebCore ChangeLog for more details.
3780
3781         * WebView/WebHTMLView.mm:
3782         (-[WebHTMLView changeFont:]):
3783         (-[WebHTMLView changeAttributes:]):
3784         (-[WebHTMLView _originalFontA]): Deleted.
3785         (-[WebHTMLView _originalFontB]): Deleted.
3786         (fontNameForDescription): Deleted.
3787         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3788         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3789         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3790
3791 2018-09-05  Jer Noble  <jer.noble@apple.com>
3792
3793         Add MediaCapabilities as an Experimental Feature
3794         https://bugs.webkit.org/show_bug.cgi?id=189209
3795
3796         Reviewed by Eric Carlson.
3797
3798         RuntimeEnabledFeature -> Setting.
3799
3800         * WebView/WebView.mm:
3801         (-[WebView _preferencesChanged:]):
3802
3803 2018-09-04  Frederic Wang  <fwang@igalia.com>
3804
3805         Add basic support for ScrollIntoViewOptions
3806         https://bugs.webkit.org/show_bug.cgi?id=189258
3807
3808         Reviewed by Simon Fraser.
3809
3810         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3811         header so that this file can build despite the new scrollIntoView function.
3812
3813 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3814
3815         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3816         https://bugs.webkit.org/show_bug.cgi?id=188890
3817         <rdar://problem/43648605>
3818
3819         Reviewed by Tim Horton.
3820
3821         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3822         more detail.
3823
3824         * WebCoreSupport/WebPlatformStrategies.h:
3825         * WebCoreSupport/WebPlatformStrategies.mm:
3826         (WebPlatformStrategies::allStringsForType):
3827
3828 2018-09-01  Darin Adler  <darin@apple.com>
3829
3830         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3831         https://bugs.webkit.org/show_bug.cgi?id=189072
3832         Reviewed by Dan Bernstein.
3833
3834         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3835         and declarations for NSURLDownload init methods.
3836
3837         * Misc/WebDownloadInternal.h: Removed.
3838
3839         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3840         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3841         "-Wdeprecated-declarations" because the method used here is deprecated.
3842
3843         * WebView/WebView.mm:
3844         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3845         used here is deprecated.
3846
3847 2018-08-31  Chris Dumez  <cdumez@apple.com>
3848
3849         Assertion hit in ~CompletionHandler() from ~WebFrame()
3850         https://bugs.webkit.org/show_bug.cgi?id=189199
3851         <rdar://problem/42657233>
3852
3853         Reviewed by Youenn Fablet.
3854
3855         * WebCoreSupport/WebFrameLoaderClient.h:
3856         * WebCoreSupport/WebFrameLoaderClient.mm:
3857         (WebFrameLoaderClient::dispatchWillSubmitForm):
3858
3859 2018-08-31  Antti Koivisto  <antti@apple.com>
3860
3861         Replace OptionSet |= and -= operators with add() and remove() functions
3862         https://bugs.webkit.org/show_bug.cgi?id=189169
3863
3864         Reviewed by Anders Carlsson.
3865
3866         * WebView/WebFrame.mm:
3867         (-[WebFrame _drawRect:contentsOnly:]):
3868         * WebView/WebView.mm:
3869         (coreOptions):
3870
3871 2018-08-31  Frederic Wang  <fwang@igalia.com>
3872
3873         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3874         https://bugs.webkit.org/show_bug.cgi?id=182053
3875
3876         Reviewed by Simon Fraser.
3877
3878         Add developer flag to use standard behavior for scrolling* attributes.
3879
3880         * WebView/WebPreferenceKeysPrivate.h:
3881         * WebView/WebPreferences.mm:
3882         (+[WebPreferences initialize]):
3883         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3884         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3885         * WebView/WebPreferencesPrivate.h:
3886         * WebView/WebView.mm:
3887         (-[WebView _preferencesChanged:]):
3888
3889 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3890
3891         Implement the Web Share API
3892         https://bugs.webkit.org/show_bug.cgi?id=171100
3893         <rdar://problem/31751734>
3894
3895         Reviewed by Tim Horton.
3896
3897         * WebCoreSupport/WebChromeClient.h:
3898         * WebCoreSupport/WebChromeClient.mm:
3899         (WebChromeClient::showShareSheet):
3900         Empty declaration of showShareSheet.
3901
3902 2018-08-29  Youenn Fablet  <youenn@apple.com>
3903
3904         Remove WebRTC legacy API implementation
3905         https://bugs.webkit.org/show_bug.cgi?id=189040
3906
3907         Reviewed by Eric Carlson.
3908
3909         * WebView/WebPreferenceKeysPrivate.h:
3910         * WebView/WebPreferences.mm:
3911         (+[WebPreferences initialize]):
3912         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3913         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3914         * WebView/WebPreferencesPrivate.h:
3915         * WebView/WebView.mm:
3916         (-[WebView _preferencesChanged:]):
3917
3918 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3919
3920         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3921         https://bugs.webkit.org/show_bug.cgi?id=189054
3922
3923         Reviewed by Andy Estes.
3924
3925         Remove the pasteboard type argument from readURLFromPasteboard.
3926
3927         * WebCoreSupport/WebPlatformStrategies.h:
3928         * WebCoreSupport/WebPlatformStrategies.mm:
3929         (WebPlatformStrategies::readURLFromPasteboard):
3930
3931 2018-08-27  Keith Rollin  <krollin@apple.com>
3932
3933         Unreviewed build fix -- disable LTO for production builds
3934
3935         * Configurations/Base.xcconfig:
3936
3937 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3938
3939         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3940         https://bugs.webkit.org/show_bug.cgi?id=188931
3941
3942         Reviewed by Wenson Hsieh.
3943
3944         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3945
3946 2018-08-27  Keith Rollin  <krollin@apple.com>
3947
3948         Build system support for LTO
3949         https://bugs.webkit.org/show_bug.cgi?id=187785
3950         <rdar://problem/42353132>
3951
3952         Reviewed by Dan Bernstein.
3953
3954         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3955         LTO.
3956
3957         * Configurations/Base.xcconfig:
3958         * Configurations/DebugRelease.xcconfig:
3959
3960 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3961
3962         Pass in IsComposed flag to Event constructors
3963         https://bugs.webkit.org/show_bug.cgi?id=188720
3964         <rdar://problem/43580387>
3965
3966         Reviewed by Simon Fraser.
3967
3968         * WebView/WebPDFView.mm:
3969         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3970         whether it's simulated or not.
3971
3972 2018-08-23  Mark Lam  <mark.lam@apple.com>
3973
3974         Move vmEntryGlobalObject() to VM from CallFrame.
3975         https://bugs.webkit.org/show_bug.cgi?id=188900
3976         <rdar://problem/43655753>
3977
3978         Reviewed by Michael Saboff.
3979
3980         * WebView/WebScriptDebugger.mm:
3981         (WebScriptDebugger::sourceParsed):
3982
3983 2018-08-23  Andy Estes  <aestes@apple.com>
3984
3985         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3986         https://bugs.webkit.org/show_bug.cgi?id=188829
3987
3988         Reviewed by Tim Horton.
3989
3990         * Configurations/FeatureDefines.xcconfig:
3991
3992 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3993
3994         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3995         https://bugs.webkit.org/show_bug.cgi?id=188777
3996
3997         Reviewed by Simon Fraser.
3998
3999         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
4000         being "true" before the code change.
4001
4002         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
4003
4004         * WebView/WebPDFView.mm:
4005         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4006
4007 2018-08-21  Daniel Bates  <dabates@apple.com>
4008
4009         Replace TextCheckingTypeMask with OptionSet
4010         https://bugs.webkit.org/show_bug.cgi?id=188678
4011
4012         Reviewed by Antti Koivisto.
4013
4014         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
4015         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
4016         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
4017         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
4018
4019         * WebCoreSupport/WebEditorClient.h:
4020         * WebCoreSupport/WebEditorClient.mm:
4021         (WebEditorClient::checkTextOfParagraph):
4022         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
4023         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
4024         left as this is more readable and unncessary now that modern compilers like Clang have
4025         diagnostics to catch accidental assignments when equality was intended.
4026         (WebEditorClient::didCheckSucceed):
4027         * WebView/WebView.mm:
4028         (coreTextCheckingType):
4029         (textCheckingResultFromNSTextCheckingResult):
4030
4031 2018-08-21  Daniel Bates  <dabates@apple.com>
4032
4033         [iOS][WK1] Support toggling continuous spell checking from tests
4034         https://bugs.webkit.org/show_bug.cgi?id=188763
4035
4036         Reviewed by Simon Fraser.
4037
4038         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
4039         spell checking from tests in iOS WebKit Legacy.
4040
4041         * WebCoreSupport/WebEditorClient.h:
4042         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
4043         * WebCoreSupport/WebEditorClient.mm:
4044         * WebView/WebView.h:
4045         * WebView/WebView.mm:
4046         (-[WebView toggleContinuousSpellChecking:]):
4047         (-[WebView toggleSmartInsertDelete:]):
4048
4049 2018-08-17  Alex Christensen  <achristensen@webkit.org>
4050
4051         Add some plumbing for safe browsing
4052         https://bugs.webkit.org/show_bug.cgi?id=188709
4053
4054         Reviewed by Tim Horton.
4055
4056         * WebCoreSupport/WebFrameLoaderClient.h:
4057         * WebCoreSupport/WebFrameLoaderClient.mm:
4058         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
4059
4060 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
4061
4062         Repla