Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
4         https://bugs.webkit.org/show_bug.cgi?id=181918
5
6         Reviewed by Tim Horton.
7
8         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
9
10         * Configurations/FeatureDefines.xcconfig:
11
12 2018-01-20  Andy Estes  <aestes@apple.com>
13
14         [Apple Pay] Stop eagerly loading PassKit.framework
15         https://bugs.webkit.org/show_bug.cgi?id=181911
16         <rdar://problem/36555369>
17
18         Reviewed by Tim Horton.
19
20         * WebCoreSupport/WebPaymentCoordinatorClient.h:
21         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
22         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
23
24         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
25
26 2018-01-19  Dean Jackson  <dino@apple.com>
27
28         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
29         https://bugs.webkit.org/show_bug.cgi?id=181817
30         <rdar://problem/35274055>
31
32         Reviewed by Simon Fraser.
33
34         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
35
36         * Misc/WebKitVersionChecks.h:
37         * WebView/WebView.mm:
38         (-[WebView _commonInitializationWithFrameName:groupName:]):
39
40 2018-01-19  Alex Christensen  <achristensen@webkit.org>
41
42         Remove unused WebViewPrivate _allowCookies
43         https://bugs.webkit.org/show_bug.cgi?id=181812
44
45         Reviewed by Tim Horton.
46
47         * WebView/WebView.mm:
48         (+[WebView _setAllowCookies:]): Deleted.
49         (+[WebView _allowCookies]): Deleted.
50         * WebView/WebViewPrivate.h:
51
52 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
53
54         Build fix, remove a call to -[NSWindow setOneShot:]
55         https://bugs.webkit.org/show_bug.cgi?id=181809
56
57         Reviewed by Tim Horton.
58
59         * WebView/WebTextCompletionController.mm:
60         (-[WebTextCompletionController _buildUI]):
61
62 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
63
64         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
65
66         * Carbon/HIWebView.mm:
67         (overrideCGContext):
68         (restoreCGContext):
69
70 2018-01-18  Dan Bernstein  <mitz@apple.com>
71
72         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
73         https://bugs.webkit.org/show_bug.cgi?id=181803
74
75         Reviewed by Tim Horton.
76
77         * Configurations/Base.xcconfig: Updated.
78         * Configurations/DebugRelease.xcconfig: Ditto.
79         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
80         * Configurations/Version.xcconfig: Updated.
81         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
82           useful for defining settings that depend on the target macOS version.
83
84 2018-01-17  Youenn Fablet  <youenn@apple.com>
85
86         Put fetch Request.keepalive behind a runtime flag
87         https://bugs.webkit.org/show_bug.cgi?id=181592
88
89         Reviewed by Chris Dumez.
90
91         * WebView/WebPreferenceKeysPrivate.h:
92         * WebView/WebPreferences.mm:
93         (+[WebPreferences initialize]):
94         (-[WebPreferences fetchAPIKeepAliveEnabled]):
95         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
96         * WebView/WebPreferencesPrivate.h:
97         * WebView/WebView.mm:
98         (-[WebView _preferencesChanged:]):
99
100 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
101
102         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
103         https://bugs.webkit.org/show_bug.cgi?id=181637
104         <rdar://problem/36508471>
105
106         Reviewed by Tim Horton.
107
108         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
109
110         * WebCoreSupport/WebEditorClient.h:
111         * WebCoreSupport/WebEditorClient.mm:
112         (WebEditorClient::replacementURLForResource):
113
114 2018-01-11  Keith Miller  <keith_miller@apple.com>
115
116         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
117         https://bugs.webkit.org/show_bug.cgi?id=181573
118
119         Reviewed by Simon Fraser.
120
121         * Configurations/FeatureDefines.xcconfig:
122
123 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
124
125         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
126         https://bugs.webkit.org/show_bug.cgi?id=181497
127
128         Reviewed by Tim Horton.
129
130         See other ChangeLogs for more detail.
131
132         * WebCoreSupport/WebDragClient.h:
133
134 2018-01-11  Tim Horton  <timothy_horton@apple.com>
135
136         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
137         https://bugs.webkit.org/show_bug.cgi?id=181523
138         <rdar://problem/28959131>
139
140         Reviewed by Alex Christensen.
141
142         * WebView/WebImmediateActionController.mm:
143         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
144         Apply the change made in r216652 to WebKit1's immediate action controller.
145
146         Speculative (but successful in WebKit2) fix for non-reproducible crash when
147         the startContainer of the range is in an anonymous node.
148
149 2018-01-11  Youenn Fablet  <youenn@apple.com>
150
151         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
152         https://bugs.webkit.org/show_bug.cgi?id=181480
153
154         Reviewed by Eric Carlson.
155
156         * WebView/WebPreferences.mm:
157         (+[WebPreferences initialize]):
158
159 2018-01-08  David Kilzer  <ddkilzer@apple.com>
160
161         Fix check-webkit-style issues with WebNSDataExtras.mm
162         <https://webkit.org/b/181369>
163
164         Reviewed by Alex Christensen.
165
166         * Misc/WebNSDataExtras.mm:
167         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
168         (-[NSData _webkit_guessedMIMETypeForXML]):
169         (-[NSData _webkit_guessedMIMEType]):
170         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
171         (_findEOL):
172         (-[NSData _webkit_parseRFC822HeaderFields]):
173         (-[NSData _web_locationAfterFirstBlankLine]):
174         - Fix all the check-webkit-style warnings.
175
176 2018-01-08  David Kilzer  <ddkilzer@apple.com>
177
178         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
179         <https://webkit.org/b/181256>
180         <rdar://problem/36281730>
181
182         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
183         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
184         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
185           to avoid warnings from casting CFStringRef to NPNSString*.
186           Note that CFMutableStringRef is the same as CFStringRef
187           without the const modifier, hence its use in the const_cast<>
188           above.
189
190 2018-01-08  David Kilzer  <ddkilzer@apple.com>
191
192         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
193         <https://webkit.org/b/181256>
194         <rdar://problem/36281730>
195
196         * Carbon/HIWebView.mm:
197         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
198         checked_cf_cast<CFRunLoopRef>() to fix warning.
199
200 2018-01-07  David Kilzer  <ddkilzer@apple.com>
201
202         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
203         <https://webkit.org/b/181256>
204         <rdar://problem/36281730>
205
206         Reviewed by Darin Adler.
207
208         * Carbon/CarbonUtils.m:
209         (PoolCleaner):
210         - Use #pragmas to ignore -Wcast-qual warnings when using a
211           C-style cast from CFTypeRef to CFRunloopRef.
212         * Carbon/CarbonWindowFrame.m:
213         (-[CarbonWindowFrame title]):
214         - Use #pragmas to ignore -Wcast-qual warnings when using a
215           C-style cast from CFStringRef to NSString *.
216         * Carbon/HIViewAdapter.m:
217         (+[HIViewAdapter getHIViewForNSView:]):
218         - Use #pragmas to ignore -Wcast-qual warnings when using a
219           C-style cast from CFTypeRef to HIViewRef.
220         * Configurations/Base.xcconfig:
221         (WARNING_CFLAGS): Add -Wcast-qual.
222         * Misc/WebElementDictionary.mm:
223         (-[WebElementDictionary objectForKey:]):
224         - Use static_cast<SEL>(const_cast<void*>()) to fix
225           warning.
226         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
227         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
228         (-[NSData _webkit_guessedMIMETypeForXML]):
229         (-[NSData _webkit_guessedMIMEType]):
230         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
231         (_findEOL):
232         (-[NSData _webkit_parseRFC822HeaderFields]):
233         (-[NSData _web_startsWithBlankLine]):
234         (-[NSData _web_locationAfterFirstBlankLine]):
235         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
236           type to Objective-C++.  This fixes the warnings about
237           discarding the `const` modifier when casing from CFStringRef
238           to NSString * because in older clang versions, -Wcast-qual was
239           completely broken when compiling C++ and Objective-C++ source
240           files.  In newer clang versions, discarding the `const`
241           modifier for toll-free bridged types is ignored when compiling
242           Objective-C++ source.
243         - Update copyright and license header.
244         - Use reinterpret_cast<> and static_cast<> to fix warnings
245           unrelated to (NSString *) C-style casts.
246         - Replace use of MIN() macro with std::min<> template functions.
247         - Fix location of `*` for local variables modified above.
248         * Plugins/Hosted/NetscapePluginHostManager.mm:
249         (WebKit::NetscapePluginHostManager::spawnPluginHost):
250         (WebKit::NetscapePluginHostManager::initializeVendorPort):
251         (WebKit::NetscapePluginHostManager::instantiatePlugin):
252         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
253           warnings.
254         * Plugins/Hosted/NetscapePluginHostProxy.mm:
255         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
256         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
257           to fix warning.
258         * Plugins/Hosted/ProxyInstance.mm:
259         (WebKit::ProxyInstance::invoke):
260         - Use static_cast<char*>(const_cast<void*>()) to fix
261           warning when using -[NSData bytes].
262         (WebKit::ProxyInstance::fieldValue const):
263         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
264           to fix warning when using CFDataGetBytePtr().
265         * Plugins/Hosted/WebTextInputWindowController.m:
266         (-[WebTextInputPanel _interpretKeyEvent:string:]):
267         - Use #pragma to ignore -Wcast-qual warning since there
268           is not a good way to avoid this warning in Objective-C.
269         * Plugins/WebNetscapePluginStream.mm:
270         (WebNetscapePluginStream::deliverData):
271         - Use const_cast<void*>() to fix warning when using
272           -[NSData bytes].
273         * Plugins/WebNetscapePluginView.mm:
274         (-[WebNetscapePluginView _createPlugin]):
275         - Change C-style cast to const_cast<char*>() to fix
276           warning.
277         * WebCoreSupport/WebChromeClient.mm:
278         (WebChromeClient::wrapCryptoKey const):
279         (WebChromeClient::unwrapCryptoKey const):
280         - Change C-style cast to
281           static_cast<uint8_t*>(const_cast<void*>() to fix
282           warning.
283         * WebView/WebPDFView.mm:
284         (_applicationInfoForMIMEType):
285         - Change local variable type from 'NSURL *' to
286           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
287           when calling -[NSURL path].
288
289 2018-01-05  Dan Bernstein  <mitz@apple.com>
290
291         Fixed the build following AppKit API deprecations in a recent SDKs
292
293         * WebView/WebFullScreenController.mm:
294         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
295         (-[WebFullScreenController exitFullScreen]): Ditto.
296         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
297         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
298         * WebView/WebHTMLView.mm:
299         (-[WebHTMLView drawRect:]): Ditto.
300         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
301         (-[WebHTMLView knowsPageRange:]): Ditto.
302         * WebView/WebView.mm:
303         (LayerFlushController::flushLayers): Ditto.
304
305 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
306
307         [Attachment Support] Create attachment elements when dropping files on iOS
308         https://bugs.webkit.org/show_bug.cgi?id=181192
309         <rdar://problem/36280945>
310
311         Reviewed by Tim Horton.
312
313         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
314
315         * WebCoreSupport/WebPlatformStrategies.h:
316         * WebCoreSupport/WebPlatformStrategies.mm:
317         (WebPlatformStrategies::informationForItemAtIndex):
318         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
319
320 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
321
322         [Attachment Support] Add plumbing for starting a drag with promised blob data
323         https://bugs.webkit.org/show_bug.cgi?id=181201
324
325         Reviewed by Tim Horton.
326
327         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
328
329         * WebCoreSupport/WebDragClient.h:
330
331 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
332
333         Add a WebAuthentication runtime feature flag
334         https://bugs.webkit.org/show_bug.cgi?id=181220
335         <rdar://problem/36055305>
336
337         Reviewed by Brent Fulgham.
338
339         Renames the CredentialManagement runtime feature flag into WebAuthentication.
340
341         * WebView/WebPreferenceKeysPrivate.h:
342         * WebView/WebPreferences.mm:
343         (+[WebPreferences initialize]):
344         (-[WebPreferences webAuthenticationEnabled]):
345         (-[WebPreferences setWebAuthenticationEnabled:]):
346         (-[WebPreferences credentialManagementEnabled]): Deleted.
347         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
348         * WebView/WebPreferencesPrivate.h:
349         * WebView/WebView.mm:
350         (-[WebView _preferencesChanged:]):
351
352 2017-12-22  Jeff Miller  <jeffm@apple.com>
353
354         Update user-visible copyright strings to include 2018
355         https://bugs.webkit.org/show_bug.cgi?id=181141
356
357         Reviewed by Dan Bernstein.
358
359         * Info.plist:
360
361 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
362
363         [Attachment Support] Remove current macOS support for dragging file-backed attachments
364         https://bugs.webkit.org/show_bug.cgi?id=181188
365
366         Reviewed by Dan Bernstein.
367
368         See WebCore/ChangeLog for more detail.
369
370         * WebCoreSupport/WebDragClient.h:
371         * WebCoreSupport/WebDragClient.mm:
372         (WebDragClient::declareAndWriteAttachment): Deleted.
373         * WebView/WebHTMLView.mm:
374         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
375
376 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
377
378         Unreviewed, continue to fix build failures due to AppKit API deprecation
379
380         Wraps more code in -Wdeprecated-declarations.
381
382         * Carbon/HIWebView.mm:
383         (overrideCGContext):
384
385 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
386
387         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
388
389         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
390
391         * Carbon/CarbonWindowAdapter.mm:
392         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
393         * Plugins/WebNetscapePluginView.mm:
394         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
395         (-[WebNetscapePluginView sendDrawRectEvent:]):
396         (-[WebNetscapePluginView drawRect:]):
397
398 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
399
400         Fix build failures due to using deprecated AppKit symbols
401         https://bugs.webkit.org/show_bug.cgi?id=181110
402         <rdar://problem/36162865>
403
404         Reviewed by Dan Bernstein and Tim Horton.
405
406         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
407
408         * Misc/WebKitNSStringExtras.mm:
409         (-[NSString _web_drawAtPoint:font:textColor:]):
410         * Misc/WebNSPasteboardExtras.h:
411         * Misc/WebNSPasteboardExtras.mm:
412         (+[NSPasteboard _web_writableTypesForURL]):
413         (_createWritableTypesForImageWithoutArchive):
414         (_createWritableTypesForImageWithArchive):
415         (+[NSPasteboard _web_dragTypesForURL]):
416         (-[NSPasteboard _web_bestURL]):
417         (-[NSPasteboard _web_writeURL:andTitle:types:]):
418         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
419         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
420         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
421         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
422         * Panels/WebAuthenticationPanel.m:
423         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
424         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
425         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
426         (-[WebHostedNetscapePluginView drawRect:]):
427         * WebInspector/WebNodeHighlightView.mm:
428         (-[WebNodeHighlightView drawRect:]):
429         * WebView/WebFrame.mm:
430         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
431         (-[WebFrame _drawRect:contentsOnly:]):
432         * WebView/WebHTMLView.mm:
433         (kit):
434         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
435         (-[WebHTMLView _plainTextFromPasteboard:]):
436         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
437         (+[WebHTMLView _insertablePasteboardTypes]):
438         (+[WebHTMLView _selectionPasteboardTypes]):
439         (-[WebHTMLView pasteboard:provideDataForType:]):
440         (-[WebHTMLView _writeSelectionToPasteboard:]):
441         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
442         (-[WebHTMLView validRequestorForSendType:returnType:]):
443         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
444         (createMenuItem):
445         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
446         (-[WebHTMLView _colorAsString:]):
447         (-[WebHTMLView copyFont:]):
448         * WebView/WebPDFView.mm:
449         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
450         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
451         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
452         (-[WebPDFView pasteboardTypesForSelection]):
453         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
454         * WebView/WebView.h:
455         * WebView/WebView.mm:
456         (-[WebView performDragOperation:]):
457         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
458         (-[WebView _searchWithGoogleFromMenu:]):
459
460 2017-12-21  Youenn Fablet  <youenn@apple.com>
461
462         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
463         https://bugs.webkit.org/show_bug.cgi?id=181000
464
465         Reviewed by Chris Dumez.
466
467         * Misc/WebCache.mm:
468         (+[WebCache addImageToCache:forURL:forFrame:]):
469
470 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
471
472         Update FULLSCREEN_API feature defines.
473         https://bugs.webkit.org/show_bug.cgi?id=181015
474
475         Reviewed by Tim Horton.
476
477         Change enabled iphone sdk for FULLSCREEN_API.
478
479         * Configurations/FeatureDefines.xcconfig:
480
481 2017-12-21  Jer Noble  <jer.noble@apple.com>
482
483         Add initial DOM support for Media Capabilities
484         https://bugs.webkit.org/show_bug.cgi?id=181064
485
486         Reviewed by Eric Carlson.
487
488         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
489
490         * WebView/WebPreferenceKeysPrivate.h:
491         * WebView/WebPreferences.mm:
492         (+[WebPreferences initialize]):
493         (-[WebPreferences mediaCapabilitiesEnabled]):
494         (-[WebPreferences setMediaCapabilitiesEnabled:]):
495         * WebView/WebPreferencesPrivate.h:
496         * WebView/WebView.mm:
497         (-[WebView _preferencesChanged:]):
498
499 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
500
501         Enable picture-in-picture from inline element on suspend.
502         https://bugs.webkit.org/show_bug.cgi?id=180942
503         rdar://problem/34745234
504
505         Reviewed by Jer Noble.
506
507         Update signature of enterVideoFullscreenForVideoElement().
508
509         * WebCoreSupport/WebChromeClient.h:
510         * WebCoreSupport/WebChromeClient.mm:
511         (WebChromeClient::enterVideoFullscreenForVideoElement):
512
513 2017-12-20  Daniel Bates  <dabates@apple.com>
514
515         Remove Alternative Presentation Button
516         https://bugs.webkit.org/show_bug.cgi?id=180500
517         <rdar://problem/35891047>
518
519         Reviewed by Simon Fraser.
520
521         We no longer need the alternative presentation button.
522
523         * Configurations/FeatureDefines.xcconfig:
524
525 2017-12-19  Jer Noble  <jer.noble@apple.com>
526
527         Playing media elements which call "pause(); play()" will have the play promise rejected.
528         https://bugs.webkit.org/show_bug.cgi?id=180781
529         <rdar://problem/33191377>
530
531         Reviewed by Eric Carlson.
532
533         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
534
535         * WebView/WebView.mm:
536         (shouldRequireUserGestureToLoadVideo):
537
538 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
539
540         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
541         https://bugs.webkit.org/show_bug.cgi?id=180977
542
543         Reviewed by Tim Horton.
544
545         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
546         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
547         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
548
549         * WebCoreSupport/WebEditorClient.mm:
550         (attributesForAttributedStringConversion):
551         * WebView/WebHTMLView.mm:
552         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
553
554 2017-12-18  David Kilzer  <ddkilzer@apple.com>
555
556         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
557
558         Attempt to fix the following warnings:
559
560             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
561
562         For the following instance variables:
563
564             _borderView
565             _contentView
566             _frame
567             _wFlags
568
569         * Carbon/CarbonWindowAdapter.mm:
570         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
571         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
572         (-[CarbonWindowAdapter _termWindowIfOwner]):
573         (-[CarbonWindowAdapter _windowMovedToRect:]):
574         (-[CarbonWindowAdapter setContentView:]):
575         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
576         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
577
578 2017-12-16  Dan Bernstein  <mitz@apple.com>
579
580         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
581         https://bugs.webkit.org/show_bug.cgi?id=180613
582         <rdar://problem/35946124>
583
584         Reviewed by Geoff Garen.
585
586         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
587           clients.
588         * WebView/WebDynamicScrollBarsView.h: Ditto.
589         * WebView/WebDynamicScrollBarsView.mm: Ditto.
590
591 2017-12-14  David Kilzer  <ddkilzer@apple.com>
592
593         Enable -Wstrict-prototypes for WebKit
594         <https://webkit.org/b/180757>
595         <rdar://problem/36024132>
596
597         Rubber-stamped by Joseph Pecoraro.
598
599         * Configurations/Base.xcconfig:
600         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
601
602 2017-12-14  John Wilander  <wilander@apple.com>
603
604         Storage Access API: Implement frame-specific access in the document.cookie layer
605         https://bugs.webkit.org/show_bug.cgi?id=180682
606         <rdar://problem/35982257>
607
608         Reviewed by Alex Christensen.
609
610         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
611         CookiesStrategy::cookieRequestHeaderFieldValue(), and
612         CookiesStrategy::getRawCookies() now take optional parameters for
613         frameID and pageID to allow frame-specific scoping of cookies.
614
615         This change makes the return values of FrameLoaderClient::frameID()
616         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
617         WebCore can call those getters and get the right return values in
618         WebKit and std:nullopt in WebKitLegacy.
619
620         * WebCoreSupport/WebFrameLoaderClient.h:
621         * WebCoreSupport/WebFrameLoaderClient.mm:
622         (WebFrameLoaderClient::pageID const):
623         (WebFrameLoaderClient::frameID const):
624         * WebCoreSupport/WebPlatformStrategies.h:
625         * WebCoreSupport/WebPlatformStrategies.mm:
626         (WebPlatformStrategies::cookiesForDOM):
627         (WebPlatformStrategies::setCookiesFromDOM):
628         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
629         (WebPlatformStrategies::getRawCookies):
630
631 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
632
633         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
634         https://bugs.webkit.org/show_bug.cgi?id=180689
635
636         Reviewed by Tim Horton.
637
638         Use sRGBColorSpaceRef() from WebCore.
639
640         * WebView/WebHTMLView.mm:
641         (imageFromRect):
642
643 2017-12-11  Tim Horton  <timothy_horton@apple.com>
644
645         Stop using deprecated target conditional for simulator builds
646         https://bugs.webkit.org/show_bug.cgi?id=180662
647         <rdar://problem/35136156>
648
649         Reviewed by Simon Fraser.
650
651         * postprocess-headers.sh:
652
653 2017-12-11  David Quesada  <david_quesada@apple.com>
654
655         Turn on ENABLE_APPLICATION_MANIFEST
656         https://bugs.webkit.org/show_bug.cgi?id=180562
657         rdar://problem/35924737
658
659         Reviewed by Geoffrey Garen.
660
661         * Configurations/FeatureDefines.xcconfig:
662
663 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
664
665         Remove pthread_once in favor of dispatch_once
666         https://bugs.webkit.org/show_bug.cgi?id=180591
667
668         Reviewed by Saam Barati.
669
670         * Misc/WebKitErrors.m:
671         (+[NSError _registerWebKitErrors]):
672         (registerErrors): Deleted.
673         * Storage/WebStorageManager.mm:
674         (+[WebStorageManager _storageDirectoryPath]):
675         (initializeLocalStoragePath): Deleted.
676
677 2017-12-07  Darin Adler  <darin@apple.com>
678
679         Remove some unused code from WebKitLegacy
680         https://bugs.webkit.org/show_bug.cgi?id=180567
681
682         Reviewed by Anders Carlsson.
683
684         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
685         macOS (back a few versions) and iOS and removed unused
686         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
687         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
688         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
689         _webkit_stringByCollapsingNonPrintingCharacters,
690         _webkit_stringByCollapsingWhitespaceCharacters,
691         _web_stringWithData:textEncodingName:, and
692         _webkit_localStorageDirectoryWithBundleIdentifier:.
693
694         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
695         this source file.
696         (canUseFastRenderer): Made this faster by not calling u_charDirection for
697         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
698         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
699         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
700         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
701         handle font smoothing options.
702         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
703         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
704         from header and made it a little clearer.
705         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
706         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
707         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
708         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
709         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
710         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
711         implementation a bit and used whole words instead of abbreviations.
712         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
713
714         * Misc/WebNSFileManagerExtras.mm:
715         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
716         filenameByFixingIllegalCharacters function from WebCore directly instead of
717         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
718
719         * Plugins/WebBaseNetscapePluginView.mm:
720         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
721         string replacements instead of _web_stringByStrippingReturnCharacters
722         and to use NSString methods instead of CFString functions.
723
724 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
725
726         Ignore deprecation warnings.
727
728         * WebView/WebHTMLView.mm:
729         (-[NSWindow _web_borderView]):
730         (-[WebHTMLView _setAsideSubviews]):
731         * WebView/WebView.mm:
732         (-[WebView encodeWithCoder:]):
733
734 2017-12-02  Darin Adler  <darin@apple.com>
735
736         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
737         https://bugs.webkit.org/show_bug.cgi?id=180009
738
739         Reviewed by Alex Christensen.
740
741         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
742
743         * Plugins/WebBaseNetscapePluginView.mm:
744         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
745         of strcasecmp.
746
747         * WebView/WebPreferences.mm:
748         (contains): Ditto. Also made this a template so it's easier to call on an array.
749         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
750
751 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
752
753         Limit user agent versioning to an upper bound
754         https://bugs.webkit.org/show_bug.cgi?id=180365
755         <rdar://problem/34550617>
756
757         Reviewed by Joseph Pecoraro.
758
759         * WebView/WebView.mm:
760         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
761         creating the User Agent string.
762         (webKitBundleVersionString): Deleted.
763
764 2017-12-05  Andy Estes  <aestes@apple.com>
765
766         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
767         https://bugs.webkit.org/show_bug.cgi?id=180457
768         <rdar://problem/35143007>
769
770         Reviewed by Tim Horton.
771
772         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
773         check for this macro during post-processing.
774
775         * postprocess-headers.sh:
776
777 2017-12-04  David Quesada  <david_quesada@apple.com>
778
779         Add a class for parsing application manifests
780         https://bugs.webkit.org/show_bug.cgi?id=177973
781         rdar://problem/34747949
782
783         Reviewed by Geoffrey Garen.
784
785         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
786
787 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
788
789         Make LegacyCustomProtocolManager optional for network process
790         https://bugs.webkit.org/show_bug.cgi?id=176230
791
792         Reviewed by Alex Christensen.
793
794         * Configurations/FeatureDefines.xcconfig:
795
796 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
797
798         Fix some NSOperationQueue leaks
799         https://bugs.webkit.org/show_bug.cgi?id=180221
800
801         Reviewed by Wenson Hsieh.
802
803         * WebView/WebView.mm:
804         (-[WebView performDragOperation:]):
805
806 2017-11-30  Darin Adler  <darin@apple.com>
807
808         [Mac] remove unneeded RetainPtr use introduced in r225142
809         https://bugs.webkit.org/show_bug.cgi?id=180202
810
811         Reviewed by Tim Horton.
812
813         * WebView/WebImmediateActionController.mm:
814         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
815         RetainPtr.
816
817 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
818
819         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
820         https://bugs.webkit.org/show_bug.cgi?id=175595
821
822         Reviewed by Darin Adler.
823
824         * WebView/WebPreferences.mm:
825
826 2017-11-27  Tim Horton  <timothy_horton@apple.com>
827
828         One too many zeroes in macOS version number in FeatureDefines
829         https://bugs.webkit.org/show_bug.cgi?id=180011
830
831         Reviewed by Dan Bernstein.
832
833         * Configurations/FeatureDefines.xcconfig:
834
835 2017-11-23  Darin Adler  <darin@apple.com>
836
837         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
838         https://bugs.webkit.org/show_bug.cgi?id=179981
839
840         Reviewed by Sam Weinig.
841
842         * WebView/WebImmediateActionController.mm:
843         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
844         * WebView/WebView.mm:
845         (coreOptions): Use |= instead of | to build up FindOptions.
846
847 2017-11-23  Sam Weinig  <sam@webkit.org>
848
849         Remove unneeded ScriptController::processingUserGesture() forwarding functions
850         https://bugs.webkit.org/show_bug.cgi?id=179954
851
852         Reviewed by Darin Adler.
853
854         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
855         with direct calls to the corresponding UserGestureIndicator functions.
856
857         * Plugins/WebPluginController.mm:
858         (-[WebPluginController processingUserGesture]):
859         * WebView/WebView.mm:
860         (-[WebView _isProcessingUserGesture]):
861
862 2017-11-23  Darin Adler  <darin@apple.com>
863
864         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
865         https://bugs.webkit.org/show_bug.cgi?id=179907
866
867         Reviewed by Sam Weinig.
868
869         * History/BinaryPropertyList.cpp:
870         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
871         (BinaryPropertyListSerializer::appendStringObject): Ditto.
872         * WebView/WebHTMLRepresentation.mm:
873         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
874         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
875
876 2017-11-22  Ali Juma  <ajuma@chromium.org>
877
878         Implement VisualViewport API attributes
879         https://bugs.webkit.org/show_bug.cgi?id=179385
880
881         Reviewed by Frédéric Wang.
882
883         Add a VisualViewportAPI preference.
884
885         * WebView/WebPreferenceKeysPrivate.h:
886         * WebView/WebPreferences.mm:
887         (+[WebPreferences initialize]):
888         (-[WebPreferences visualViewportAPIEnabled]):
889         (-[WebPreferences setVisualViewportAPIEnabled:]):
890         * WebView/WebPreferencesPrivate.h:
891         * WebView/WebView.mm:
892         (-[WebView _preferencesChanged:]):
893
894 2017-11-22  Christopher Reid  <chris.reid@sony.com>
895
896         WebCoreObjCExtras.h is being included in too many places
897         https://bugs.webkit.org/show_bug.cgi?id=179931
898
899         Reviewed by Darin Adler.
900
901         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
902         * Plugins/WebBaseNetscapePluginView.mm:
903         * Plugins/WebBasePluginPackage.mm:
904         * Plugins/WebNetscapePluginStream.mm:
905         * Plugins/WebNetscapePluginView.mm:
906         * WebView/WebTextIterator.mm:
907         * WebView/WebViewData.mm:
908
909 2017-11-22  Commit Queue  <commit-queue@webkit.org>
910
911         Unreviewed, rolling out r225093.
912         https://bugs.webkit.org/show_bug.cgi?id=179938
913
914         Compilation failed on WinCairo 64-bit Release (Requested by
915         fredw on #webkit).
916
917         Reverted changeset:
918
919         "Implement VisualViewport API attributes"
920         https://bugs.webkit.org/show_bug.cgi?id=179385
921         https://trac.webkit.org/changeset/225093
922
923 2017-11-21  Ali Juma  <ajuma@chromium.org>
924
925         Implement VisualViewport API attributes
926         https://bugs.webkit.org/show_bug.cgi?id=179385
927
928         Reviewed by Frédéric Wang.
929
930         Add a VisualViewportAPI preference.
931
932         * WebView/WebPreferenceKeysPrivate.h:
933         * WebView/WebPreferences.mm:
934         (+[WebPreferences initialize]):
935         (-[WebPreferences visualViewportAPIEnabled]):
936         (-[WebPreferences setVisualViewportAPIEnabled:]):
937         * WebView/WebPreferencesPrivate.h:
938         * WebView/WebView.mm:
939         (-[WebView _preferencesChanged:]):
940
941 2017-11-21  Christopher Reid  <chris.reid@sony.com>
942
943         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
944         https://bugs.webkit.org/show_bug.cgi?id=179504
945
946         Reviewed by Darin Adler.
947
948         * Misc/WebKitNSStringExtras.mm:
949         * Plugins/Hosted/NetscapePluginHostManager.mm:
950         * Plugins/WebBasePluginPackage.mm:
951
952 2017-11-19  Tim Horton  <timothy_horton@apple.com>
953
954         Remove unused TOUCH_ICON_LOADING feature flag
955         https://bugs.webkit.org/show_bug.cgi?id=179873
956
957         Reviewed by Simon Fraser.
958
959         * Configurations/FeatureDefines.xcconfig:
960
961 2017-11-19  Tim Horton  <timothy_horton@apple.com>
962
963         Remove unused LEGACY_VENDOR_PREFIXES feature flag
964         https://bugs.webkit.org/show_bug.cgi?id=179872
965
966         Reviewed by Darin Adler.
967
968         * Configurations/FeatureDefines.xcconfig:
969
970 2017-11-16  Daniel Bates  <dabates@apple.com>
971
972         Add feature define for alternative presentation button element
973         https://bugs.webkit.org/show_bug.cgi?id=179692
974         Part of <rdar://problem/34917108>
975
976         Reviewed by Andy Estes.
977
978         Only enabled on Cocoa platforms by default.
979
980         * Configurations/FeatureDefines.xcconfig:
981
982 2017-11-14  Nan Wang  <n_wang@apple.com>
983
984         AX: AOM: Implement AccessibleNode class and support label and role attributes
985         https://bugs.webkit.org/show_bug.cgi?id=179494
986
987         Reviewed by Ryosuke Niwa.
988
989         * WebView/WebPreferenceKeysPrivate.h:
990         * WebView/WebPreferences.mm:
991         (+[WebPreferences initialize]):
992         (-[WebPreferences accessibilityObjectModelEnabled]):
993         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
994         * WebView/WebPreferencesPrivate.h:
995         * WebView/WebView.mm:
996         (-[WebView _preferencesChanged:]):
997
998 2017-11-14  Alex Christensen  <achristensen@webkit.org>
999
1000         Remove Cocoa CFURLConnection loading code
1001         https://bugs.webkit.org/show_bug.cgi?id=179688
1002
1003         Reviewed by Antti Koivisto.
1004
1005         * Misc/WebDownload.mm:
1006         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1007         * Misc/WebDownloadInternal.h:
1008         * Plugins/WebBaseNetscapePluginView.mm:
1009         * WebCoreSupport/WebFrameLoaderClient.mm:
1010         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1011         * WebView/WebView.mm:
1012         (-[WebView scheduleInRunLoop:forMode:]):
1013         (-[WebView unscheduleFromRunLoop:forMode:]):
1014
1015 2017-11-14  Daniel Bates  <dabates@apple.com>
1016
1017         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1018         for feature defines
1019
1020         Following r195498 and r201917 the Visual Studio property files for feature defines have
1021         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1022         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1023         files.
1024
1025         * Configurations/FeatureDefines.xcconfig:
1026
1027 2017-11-14  Jer Noble  <jer.noble@apple.com>
1028
1029         Enable Modern EME tests in DumpRenderTree
1030         https://bugs.webkit.org/show_bug.cgi?id=179544
1031
1032         Reviewed by Alex Christensen.
1033
1034         Add a WebPreferences property to enable the (modern) EME API.
1035
1036         * WebView/WebPreferenceKeysPrivate.h:
1037         * WebView/WebPreferences.mm:
1038         (+[WebPreferences initialize]):
1039         (-[WebPreferences encryptedMediaAPIEnabled]):
1040         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1041         * WebView/WebPreferencesPrivate.h:
1042         * WebView/WebView.mm:
1043         (-[WebView _preferencesChanged:]):
1044
1045 2017-11-14  Antti Koivisto  <antti@apple.com>
1046
1047         Enable display:contents by default
1048         https://bugs.webkit.org/show_bug.cgi?id=179655
1049
1050         Reviewed by Sam Weinig.
1051
1052         * WebView/WebPreferences.mm:
1053         (+[WebPreferences initialize]):
1054
1055 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1056
1057         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1058         https://bugs.webkit.org/show_bug.cgi?id=178751
1059
1060         Reviewed by Brady Eidson.
1061
1062         * WebCoreSupport/WebFrameNetworkingContext.mm:
1063         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1064
1065 2017-11-08  Keith Miller  <keith_miller@apple.com>
1066
1067         Async iteration should only fetch the next method once and add feature flag
1068         https://bugs.webkit.org/show_bug.cgi?id=179451
1069
1070         Reviewed by Geoffrey Garen.
1071
1072         Add feature flag for Async iteration.
1073
1074         * Configurations/FeatureDefines.xcconfig:
1075
1076 2017-11-13  Mark Lam  <mark.lam@apple.com>
1077
1078         Add more overflow check book-keeping for MarkedArgumentBuffer.
1079         https://bugs.webkit.org/show_bug.cgi?id=179634
1080         <rdar://problem/35492517>
1081
1082         Reviewed by Saam Barati.
1083
1084         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1085         (WebKit::NetscapePluginInstanceProxy::invoke):
1086         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1087         (WebKit::NetscapePluginInstanceProxy::construct):
1088
1089 2017-11-12  Darin Adler  <darin@apple.com>
1090
1091         More is<> and downcast<>, less static_cast<>
1092         https://bugs.webkit.org/show_bug.cgi?id=179600
1093
1094         Reviewed by Chris Dumez.
1095
1096         * DOM/DOM.mm:
1097         (kit): Use is/downcast.
1098         * WebCoreSupport/WebEditorClient.mm:
1099         (WebEditorClient::handleKeyboardEvent): Ditto.
1100         (WebEditorClient::handleInputMethodKeydown): Ditto.
1101         * WebView/WebHTMLView.mm:
1102         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1103
1104 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1105
1106         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1107         https://bugs.webkit.org/show_bug.cgi?id=179397
1108
1109         Reviewed by Wenson Hsieh.
1110
1111         * DOM/DOMHTMLInputElement.mm:
1112         (-[DOMHTMLInputElement insertTextSuggestion:]):
1113
1114 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1115
1116         HTMLMediaElement should not use element fullscreen on iOS
1117         https://bugs.webkit.org/show_bug.cgi?id=179418
1118         rdar://problem/35409277
1119
1120         Reviewed by Eric Carlson.
1121
1122         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1123
1124         * Configurations/FeatureDefines.xcconfig:
1125
1126 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1127
1128         Make ResourceLoader::willSendRequestInternal asynchronous
1129         https://bugs.webkit.org/show_bug.cgi?id=179251
1130
1131         Reviewed by Andy Estes.
1132
1133         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1134         (WebKit::HostedNetscapePluginStream::start):
1135         * Plugins/WebNetscapePluginStream.mm:
1136         (WebNetscapePluginStream::start):
1137
1138 2017-11-01  Darin Adler  <darin@apple.com>
1139
1140         Simplify event dispatch code and make it a bit more consistent
1141         https://bugs.webkit.org/show_bug.cgi?id=178991
1142
1143         Reviewed by Chris Dumez.
1144
1145         * DOM/DOMEvent.mm:
1146         (-[DOMEvent srcElement]): Call target instead of srcElement.
1147
1148 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1149
1150         [Touch Bar Web API] Add support for menuitem tag
1151         https://bugs.webkit.org/show_bug.cgi?id=179020
1152
1153         Reviewed by Ryosuke Niwa.
1154
1155         Adds in properties and methods that allow the menuitem runtime feature
1156         to be enabled or disabled.
1157
1158         * WebView/WebPreferenceKeysPrivate.h:
1159         * WebView/WebPreferences.mm:
1160         (-[WebPreferences menuItemElementEnabled]):
1161         (-[WebPreferences setMenuItemElementEnabled:]):
1162         * WebView/WebPreferencesPrivate.h:
1163         * WebView/WebView.mm:
1164         (-[WebView _preferencesChanged:]):
1165
1166 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1167
1168         Use CompletionHandlers for redirects
1169         https://bugs.webkit.org/show_bug.cgi?id=179163
1170
1171         Reviewed by Tim Horton.
1172
1173         * Plugins/Hosted/HostedNetscapePluginStream.h:
1174         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1175         (WebKit::HostedNetscapePluginStream::willSendRequest):
1176         * Plugins/WebNetscapePluginStream.h:
1177         * Plugins/WebNetscapePluginStream.mm:
1178         (WebNetscapePluginStream::willSendRequest):
1179
1180 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1181
1182         Add a FileSystem namespace to FileSystem.cpp
1183         https://bugs.webkit.org/show_bug.cgi?id=179063
1184
1185         Reviewed by Darin Adler.
1186
1187         * Misc/WebNSFileManagerExtras.mm:
1188         * Storage/WebDatabaseProvider.mm:
1189
1190 2017-11-02  Frederic Wang  <fwang@igalia.com>
1191
1192         Add references to bug 179167 in FIXME comments
1193         https://bugs.webkit.org/show_bug.cgi?id=179168
1194
1195         Reviewed by Daniel Bates.
1196
1197         * Configurations/FeatureDefines.xcconfig:
1198
1199 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1200
1201         Implement WKFullscreenWindowController for iOS.
1202         https://bugs.webkit.org/show_bug.cgi?id=178924
1203         rdar://problem/34697120
1204
1205         Reviewed by Simon Fraser.
1206
1207         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1208
1209         * Configurations/FeatureDefines.xcconfig:
1210         * WebView/WebView.mm:
1211         (-[WebView fullScreenPlaceholderView]):
1212
1213 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1214
1215         Clean up some drag and drop feature flags
1216         https://bugs.webkit.org/show_bug.cgi?id=179082
1217
1218         Reviewed by Simon Fraser.
1219
1220         * Configurations/FeatureDefines.xcconfig:
1221
1222 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
1223
1224         Make it possible to test rubber-banding in overflow scroll
1225         https://bugs.webkit.org/show_bug.cgi?id=179078
1226
1227         Reviewed by Sam Weinig.
1228
1229         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
1230         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
1231
1232         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
1233         functions, since most callers want clamped.
1234
1235         * DOM/DOMHTML.mm:
1236         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
1237
1238 2017-10-31  Tim Horton  <timothy_horton@apple.com>
1239
1240         Fix up some content filtering feature flags
1241         https://bugs.webkit.org/show_bug.cgi?id=179079
1242
1243         Reviewed by Simon Fraser.
1244
1245         * Configurations/FeatureDefines.xcconfig:
1246
1247 2017-10-28  Zalan Bujtas  <zalan@apple.com>
1248
1249         [FrameView::layout cleanup] Move core layout logic to a separate class.
1250         https://bugs.webkit.org/show_bug.cgi?id=178771
1251         <rdar://problem/35166542>
1252
1253         Reviewed by Simon Fraser.
1254
1255         Move layout code out from FrameView to LayoutContext.
1256
1257         * WebView/WebClipView.mm:
1258         (-[WebClipView _immediateScrollToPoint:]):
1259         * WebView/WebFrame.mm:
1260         (-[WebFrame layoutCount]):
1261
1262 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
1263
1264         Fix issues with WebView subframe painting
1265         https://bugs.webkit.org/show_bug.cgi?id=178842
1266         rdar://problem/34072253
1267
1268         Reviewed by Daniel Bates.
1269         
1270         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
1271         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
1272         High Sierra, so match the new signature.
1273
1274         Also rename the 'rect' param to 'displayRect' to match AppKit code.
1275
1276         * WebView/WebHTMLView.mm:
1277         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
1278         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
1279
1280 2017-10-25  Youenn Fablet  <youenn@apple.com>
1281
1282         Enable ServiceWorker to fetch resources
1283         https://bugs.webkit.org/show_bug.cgi?id=178673
1284
1285         Reviewed by Brady Eidson.
1286
1287         * WebCoreSupport/WebFrameLoaderClient.mm:
1288         (WebFrameLoaderClient::pageID const):
1289         (WebFrameLoaderClient::frameID const):
1290         (WebFrameLoaderClient::sessionID const):
1291
1292         Added implementation to the new getters.
1293         They are noop in the context of WK1.
1294
1295 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
1296
1297         Web Inspector: Enable WebKit logging configuration and display
1298         https://bugs.webkit.org/show_bug.cgi?id=177027
1299         <rdar://problem/33964767>
1300
1301         Reviewed by Joseph Pecoraro.
1302
1303         * WebCoreSupport/WebChromeClient.mm:
1304         (stringForMessageSource): Deal with Media and WebRTC message sources.
1305
1306 2017-10-20  Antoine Quint  <graouts@apple.com>
1307
1308         [Web Animations] Provide basic timeline and animation interfaces
1309         https://bugs.webkit.org/show_bug.cgi?id=178526
1310
1311         Reviewed by Dean Jackson.
1312
1313         Remove the WEB_ANIMATIONS compile-time flag.
1314
1315         * Configurations/FeatureDefines.xcconfig:
1316         * WebView/WebPreferences.mm:
1317         (+[WebPreferences initialize]):
1318         * WebView/WebView.mm:
1319         (-[WebView _preferencesChanged:]):
1320
1321 2017-10-19  Sam Weinig  <sam@webkit.org>
1322
1323         [Settings] Move global settings into their own file
1324         https://bugs.webkit.org/show_bug.cgi?id=178512
1325
1326         Reviewed by Darin Adler.
1327
1328         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
1329
1330         * WebCoreSupport/WebChromeClient.mm:
1331         (WebChromeClient::supportsVideoFullscreen):
1332         * WebView/WebDynamicScrollBarsView.mm:
1333         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
1334         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
1335         * WebView/WebPreferences.mm:
1336         (+[WebPreferences initialize]):
1337         * WebView/WebView.mm:
1338         (-[WebView _commonInitializationWithFrameName:groupName:]):
1339         (-[WebView _preferencesChanged:]):
1340         (+[WebView _doNotStartObservingNetworkReachability]):
1341
1342 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
1343
1344         Replace some stack raw pointers with RefPtrs within WebCore/html
1345         https://bugs.webkit.org/show_bug.cgi?id=178201
1346         <rdar://problem/34841692>
1347
1348         Reviewed by Ryosuke Niwa.
1349
1350         * DOM/DOM.mm:
1351         (kit):
1352         Change the type of node as toNode() is changed to return RefPtr.
1353
1354 2017-10-18  Chris Dumez  <cdumez@apple.com>
1355
1356         [Service Worker] Add stubs for Client / WindowClient / Clients
1357         https://bugs.webkit.org/show_bug.cgi?id=178469
1358
1359         Reviewed by Youenn Fablet.
1360
1361         Rename PageVisiblityState to VisibilityState.
1362
1363         * WebView/WebView.mm:
1364         (kit):
1365
1366 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1367
1368         Unreviewed, rolling out r223291.
1369
1370         See WebCore ChangeLog for more detail.
1371
1372         Reverted changeset:
1373
1374         "Remove Editor::simplifyMarkup"
1375         https://bugs.webkit.org/show_bug.cgi?id=178271
1376         https://trac.webkit.org/changeset/223291
1377
1378 2017-10-17  Keith Miller  <keith_miller@apple.com>
1379
1380         Change WebCore sources to work with unified source builds
1381         https://bugs.webkit.org/show_bug.cgi?id=178229
1382
1383         Rubber stamped by Tim Horton.
1384
1385         * Configurations/FeatureDefines.xcconfig:
1386
1387 2017-10-16  Sam Weinig  <sam@webkit.org>
1388
1389         [Settings] Remove all custom code from Settings.h/cpp
1390         https://bugs.webkit.org/show_bug.cgi?id=178330
1391
1392         Reviewed by Simon Fraser.
1393
1394         * WebView/WebPreferences.mm:
1395         (+[WebPreferences initialize]):
1396         
1397             Update for naming changes of FrameFlattening now that it is an enum class.
1398
1399 2017-10-13  Alex Christensen  <achristensen@webkit.org>
1400
1401         Remove Editor::simplifyMarkup
1402         https://bugs.webkit.org/show_bug.cgi?id=178271
1403
1404         Reviewed by Wenson Hsieh.
1405
1406         * WebView/WebView.mm:
1407         (-[WebView _simplifyMarkup:endNode:]):
1408
1409 2017-10-12  Chris Dumez  <cdumez@apple.com>
1410
1411         [Mac] Add support for MouseEvent.buttons
1412         https://bugs.webkit.org/show_bug.cgi?id=178214
1413
1414         Reviewed by Ryosuke Niwa.
1415
1416         * WebView/WebPDFView.mm:
1417         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1418
1419 2017-10-11  Sam Weinig  <sam@webkit.org>
1420
1421         Remove out-parameter variants of copyToVector
1422         https://bugs.webkit.org/show_bug.cgi?id=178155
1423
1424         Reviewed by Tim Horton.
1425
1426         * Plugins/WebNetscapePluginView.mm:
1427         (-[WebNetscapePluginView destroyPlugin]):
1428         * WebView/WebHTMLRepresentation.mm:
1429         (newArrayWithStrings):
1430
1431             Replace out-parameter based copyToVector, with one that returns a Vector.
1432
1433 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
1434
1435         Sanitize URL in pasteboard for other applications and cross origin content
1436         https://bugs.webkit.org/show_bug.cgi?id=178060
1437         <rdar://problem/34874518>
1438
1439         Reviewed by Wenson Hsieh.
1440
1441         * WebCoreSupport/WebPlatformStrategies.h:
1442         * WebCoreSupport/WebPlatformStrategies.mm:
1443         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
1444
1445 2017-10-11  Chris Dumez  <cdumez@apple.com>
1446
1447         Modernize Geolocation code
1448         https://bugs.webkit.org/show_bug.cgi?id=178148
1449
1450         Reviewed by Ryosuke Niwa.
1451
1452         * WebCoreSupport/WebGeolocationClient.h:
1453         * WebCoreSupport/WebGeolocationClient.mm:
1454         (WebGeolocationClient::lastPosition):
1455         * WebView/WebGeolocationPosition.mm:
1456         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
1457         (core):
1458         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
1459         (-[WebGeolocationPosition initWithGeolocationPosition:]):
1460         * WebView/WebGeolocationPositionInternal.h:
1461
1462 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
1463
1464         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
1465         https://bugs.webkit.org/show_bug.cgi?id=178154
1466
1467         Reviewed by Wenson Hsieh.
1468
1469         Enable custom pasteboard data by default.
1470
1471         * WebView/WebPreferenceKeysPrivate.h:
1472         * WebView/WebPreferences.mm:
1473         (+[WebPreferences initialize]):
1474         (-[WebPreferences customPasteboardDataEnabled]): Added.
1475         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
1476         * WebView/WebPreferencesPrivate.h:
1477         * WebView/WebView.mm:
1478         (-[WebView _preferencesChanged:]):
1479
1480 2017-10-10  Sam Weinig  <sam@webkit.org>
1481
1482         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
1483         https://bugs.webkit.org/show_bug.cgi?id=178102
1484
1485         Reviewed by Tim Horton.
1486
1487         * History/WebHistory.mm:
1488         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
1489         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1490         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
1491         * WebCoreSupport/WebUserMediaClient.mm:
1492         (WebUserMediaClient::pageDestroyed):
1493
1494 2017-10-09  Robin Morisset  <rmorisset@apple.com>
1495
1496         Make the names of the options consistent
1497         https://bugs.webkit.org/show_bug.cgi?id=177933
1498
1499         Reviewed by Saam Barati.
1500
1501         * WebView/WebFrame.h:
1502         * WebView/WebHTMLView.mm:
1503         (-[WebHTMLView setMarkedText:selectedRange:]):
1504         * WebView/WebView.h:
1505
1506 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
1507
1508         [iOS] Tweak support for classifying form controls (followup to r222487)
1509         https://bugs.webkit.org/show_bug.cgi?id=177917
1510         <rdar://problem/34820122>
1511
1512         Reviewed by Dean Jackson.
1513
1514         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
1515
1516         * DOM/DOMHTMLInputElement.mm:
1517         (-[DOMHTMLInputElement _autofillContext]):
1518         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
1519         (-[DOMHTMLInputElement representingPageURL]): Deleted.
1520
1521 2017-10-05  Keith Miller  <keith_miller@apple.com>
1522
1523         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
1524
1525         * Configurations/WebKitLegacy.xcconfig:
1526
1527 2017-10-05  Jer Noble  <jer.noble@apple.com>
1528
1529         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
1530         https://bugs.webkit.org/show_bug.cgi?id=177261
1531
1532         Reviewed by Eric Carlson.
1533
1534         * Configurations/FeatureDefines.xcconfig:
1535
1536 2017-10-05  Chris Dumez  <cdumez@apple.com>
1537
1538         Drop unused parameters for CookiesStrategy::cookiesEnabled()
1539         https://bugs.webkit.org/show_bug.cgi?id=177957
1540
1541         Reviewed by Alex Christensen.
1542
1543         * WebCoreSupport/WebPlatformStrategies.h:
1544         * WebCoreSupport/WebPlatformStrategies.mm:
1545         (WebPlatformStrategies::cookiesEnabled):
1546
1547 2017-10-05  Youenn Fablet  <youenn@apple.com>
1548
1549         Make LibWebRTCProvider port agnostic
1550         https://bugs.webkit.org/show_bug.cgi?id=177747
1551
1552         Reviewed by Alex Christensen & Alex Garcia.
1553
1554         * WebView/WebView.mm:
1555         (-[WebView _commonInitializationWithFrameName:groupName:]):
1556         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1557
1558 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1559
1560         Stop linking with WebKitSystemInterface
1561         https://bugs.webkit.org/show_bug.cgi?id=177915
1562
1563         Reviewed by Antti Koivisto.
1564
1565         * Configurations/DebugRelease.xcconfig:
1566         * Configurations/WebKitLegacy.xcconfig:
1567
1568 2017-10-04  Alex Christensen  <achristensen@webkit.org>
1569
1570         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
1571         https://bugs.webkit.org/show_bug.cgi?id=177912
1572
1573         Reviewed by Saam Barati.
1574
1575         * Carbon/CarbonUtils.m:
1576         * Carbon/CarbonWindowAdapter.mm:
1577         * Carbon/HIWebView.mm:
1578         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
1579         * Misc/WebNSFileManagerExtras.mm:
1580         * Misc/WebNSPasteboardExtras.mm:
1581         * Misc/WebNSURLExtras.mm:
1582         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1583         * Plugins/Hosted/NetscapePluginHostManager.mm:
1584         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1585         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1586         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1587         * Plugins/Hosted/WebTextInputWindowController.m:
1588         * Plugins/WebBaseNetscapePluginView.mm:
1589         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1590         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1591         * Plugins/WebNetscapePluginStream.mm:
1592         * Plugins/WebNetscapePluginView.mm:
1593         * Plugins/WebPluginDatabase.mm:
1594         * WebCoreSupport/PopupMenuMac.mm:
1595         * WebCoreSupport/WebChromeClient.mm:
1596         * WebCoreSupport/WebFrameLoaderClient.mm:
1597         * WebCoreSupport/WebInspectorClient.mm:
1598         * WebCoreSupport/WebPlatformStrategies.mm:
1599         * WebCoreSupport/WebSystemInterface.mm:
1600         * WebView/WebDynamicScrollBarsView.mm:
1601         * WebView/WebFrame.mm:
1602         * WebView/WebFrameView.mm:
1603         * WebView/WebFullScreenController.mm:
1604         * WebView/WebHTMLView.mm:
1605         * WebView/WebPreferences.mm:
1606         * WebView/WebView.mm:
1607
1608 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
1609
1610         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
1611         rdar://problem/34705779
1612
1613         Addressing review comments that I somehow landed without.
1614
1615         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
1616
1617 2017-09-29  Chris Dumez  <cdumez@apple.com>
1618
1619         Split some logic out of VisitedLinkStore and make it reusable
1620         https://bugs.webkit.org/show_bug.cgi?id=177575
1621
1622         Reviewed by Alex Christensen.
1623
1624         * WebCoreSupport/WebVisitedLinkStore.h:
1625         * WebCoreSupport/WebVisitedLinkStore.mm:
1626         (WebVisitedLinkStore::addVisitedLink):
1627         (WebVisitedLinkStore::removeVisitedLink):
1628         (WebVisitedLinkStore::isLinkVisited):
1629         (WebVisitedLinkStore::addVisitedLinkHash):
1630
1631 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
1632
1633         Build fix for High Sierra 32 bit Mac
1634         https://bugs.webkit.org/show_bug.cgi?id=177551
1635         <rdar://problem/34690283>
1636
1637         Reviewed by Alexey Proskuryakov.
1638
1639         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1640         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1641         also made.
1642
1643         * Carbon/CarbonWindowAdapter.mm:
1644         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1645         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1646         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1647         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1648         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1649         (-[CarbonWindowAdapter dealloc]):
1650         (-[CarbonWindowAdapter windowRef]):
1651         (-[CarbonWindowAdapter _hasWindowRef]):
1652         (-[CarbonWindowAdapter _managesWindowRef]):
1653         (-[CarbonWindowAdapter _removeWindowRef]):
1654         (-[CarbonWindowAdapter _carbonWindowClass]):
1655         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1656         (-[CarbonWindowAdapter sendSuperEvent:]):
1657         (-[CarbonWindowAdapter relinquishFocus]):
1658         (-[CarbonWindowAdapter _cancelKey:]):
1659         (-[CarbonWindowAdapter _commonAwake]):
1660         (-[CarbonWindowAdapter _destroyRealWindow:]):
1661         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1662         (-[CarbonWindowAdapter _termWindowIfOwner]):
1663         (-[CarbonWindowAdapter _windowMovedToRect:]):
1664         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1665         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1666         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1667         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1668         (-[CarbonWindowAdapter canBecomeMainWindow]):
1669         (-[CarbonWindowAdapter encodeWithCoder:]):
1670         (-[CarbonWindowAdapter initWithCoder:]):
1671         (-[CarbonWindowAdapter setContentView:]):
1672         (-[CarbonWindowAdapter worksWhenModal]):
1673         (-[CarbonWindowAdapter _setModalWindowLevel]):
1674         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1675         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1676         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1677         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1678         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1679         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1680         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1681         (NSCarbonWindowHandleEvent):
1682         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1683         (-[CarbonWindowAdapter _growBoxRect]):
1684         * Carbon/HIWebView.mm:
1685         (HIWebViewGetWebView):
1686         (HIWebViewConstructor):
1687         (HIWebViewDestructor):
1688         (HIWebViewRegisterClass):
1689         (GetBehaviors):
1690         (Draw):
1691         (HitTest):
1692         (GetRegion):
1693         (GetWindowRef):
1694         (CreateNSEventAdoptingCGEvent):
1695         (CopyEventCGEvent):
1696         (CreateNSEventWithCarbonClickEvent):
1697         (Click):
1698         (CreateNSEventWithCarbonEvent):
1699         (MouseUp):
1700         (CreateNSEventWithCarbonMouseMoveEvent):
1701         (MouseMoved):
1702         (MouseDragged):
1703         (MouseWheelMoved):
1704         (ContextMenuClick):
1705         (GetKind):
1706         (BoundsChanged):
1707         (OwningWindowChanged):
1708         (WindowHandler):
1709         (SyncFrame):
1710         (SetFocusPart):
1711         (AdvanceFocus):
1712         (RelinquishFocus):
1713         (ActiveStateChanged):
1714         (ProcessCommand):
1715         (UpdateCommandStatus):
1716         (_NSSelectorForHICommand):
1717         (HIWebViewEventHandler):
1718         (StartUpdateObserver):
1719         (StopUpdateObserver):
1720         (UpdateObserver):
1721
1722 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1723
1724         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
1725         https://bugs.webkit.org/show_bug.cgi?id=172526
1726         <rdar://problem/32396081>
1727
1728         Reviewed by Ryosuke Niwa.
1729
1730         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
1731
1732         * WebCoreSupport/WebPlatformStrategies.h:
1733         * WebCoreSupport/WebPlatformStrategies.mm:
1734         (WebPlatformStrategies::webExposedTypes):
1735         (WebPlatformStrategies::writeCustomData):
1736
1737 2017-09-27  Matt Lewis  <jlewis3@apple.com>
1738
1739         Unreviewed, rolling out r222567.
1740
1741         This broke and internal build.
1742
1743         Reverted changeset:
1744
1745         "Build fix for High Sierra 32 bit Mac"
1746         https://bugs.webkit.org/show_bug.cgi?id=177551
1747         http://trac.webkit.org/changeset/222567
1748
1749 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
1750
1751         Build fix for High Sierra 32 bit Mac
1752         https://bugs.webkit.org/show_bug.cgi?id=177551
1753         <rdar://problem/34690283>
1754
1755         Reviewed by Alexey Proskuryakov.
1756
1757         Some assertions have been removed from the SDK. Replace these assertions with equivalent
1758         WTF assert code.  Since the files in this patch are using tabs, some style changes were
1759         also made.
1760
1761         * Carbon/CarbonWindowAdapter.mm:
1762         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1763         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
1764         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1765         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1766         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
1767         (-[CarbonWindowAdapter dealloc]):
1768         (-[CarbonWindowAdapter windowRef]):
1769         (-[CarbonWindowAdapter _hasWindowRef]):
1770         (-[CarbonWindowAdapter _managesWindowRef]):
1771         (-[CarbonWindowAdapter _removeWindowRef]):
1772         (-[CarbonWindowAdapter _carbonWindowClass]):
1773         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1774         (-[CarbonWindowAdapter sendSuperEvent:]):
1775         (-[CarbonWindowAdapter relinquishFocus]):
1776         (-[CarbonWindowAdapter _cancelKey:]):
1777         (-[CarbonWindowAdapter _commonAwake]):
1778         (-[CarbonWindowAdapter _destroyRealWindow:]):
1779         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1780         (-[CarbonWindowAdapter _termWindowIfOwner]):
1781         (-[CarbonWindowAdapter _windowMovedToRect:]):
1782         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
1783         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
1784         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
1785         (-[CarbonWindowAdapter canBecomeKeyWindow]):
1786         (-[CarbonWindowAdapter canBecomeMainWindow]):
1787         (-[CarbonWindowAdapter encodeWithCoder:]):
1788         (-[CarbonWindowAdapter initWithCoder:]):
1789         (-[CarbonWindowAdapter setContentView:]):
1790         (-[CarbonWindowAdapter worksWhenModal]):
1791         (-[CarbonWindowAdapter _setModalWindowLevel]):
1792         (-[CarbonWindowAdapter _clearModalWindowLevel]):
1793         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
1794         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
1795         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
1796         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1797         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1798         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
1799         (NSCarbonWindowHandleEvent):
1800         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
1801         (-[CarbonWindowAdapter _growBoxRect]):
1802         * Carbon/HIWebView.mm:
1803         (HIWebViewGetWebView):
1804         (HIWebViewConstructor):
1805         (HIWebViewDestructor):
1806         (HIWebViewRegisterClass):
1807         (GetBehaviors):
1808         (Draw):
1809         (HitTest):
1810         (GetRegion):
1811         (GetWindowRef):
1812         (CreateNSEventAdoptingCGEvent):
1813         (CopyEventCGEvent):
1814         (CreateNSEventWithCarbonClickEvent):
1815         (Click):
1816         (CreateNSEventWithCarbonEvent):
1817         (MouseUp):
1818         (CreateNSEventWithCarbonMouseMoveEvent):
1819         (MouseMoved):
1820         (MouseDragged):
1821         (MouseWheelMoved):
1822         (ContextMenuClick):
1823         (GetKind):
1824         (BoundsChanged):
1825         (OwningWindowChanged):
1826         (WindowHandler):
1827         (SyncFrame):
1828         (SetFocusPart):
1829         (AdvanceFocus):
1830         (RelinquishFocus):
1831         (ActiveStateChanged):
1832         (ProcessCommand):
1833         (UpdateCommandStatus):
1834         (_NSSelectorForHICommand):
1835         (HIWebViewEventHandler):
1836         (StartUpdateObserver):
1837         (StopUpdateObserver):
1838         (UpdateObserver):
1839
1840 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1841
1842         Make PolicyAction an encodable enum class
1843         https://bugs.webkit.org/show_bug.cgi?id=177480
1844
1845         Reviewed by Antti Koivisto.
1846
1847         * Plugins/WebPluginContainerCheck.mm:
1848         (-[WebPluginContainerCheck _continueWithPolicy:]):
1849         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
1850         * WebCoreSupport/WebFrameLoaderClient.mm:
1851         (-[WebFramePolicyListener invalidate]):
1852         (-[WebFramePolicyListener ignore]):
1853         (-[WebFramePolicyListener download]):
1854         (-[WebFramePolicyListener use]):
1855         (-[WebFramePolicyListener continue]):
1856         * WebView/WebPolicyDelegate.mm:
1857         (-[WebPolicyDecisionListener use]):
1858         (-[WebPolicyDecisionListener ignore]):
1859         (-[WebPolicyDecisionListener download]):
1860
1861 2017-09-25  Frederik Riedel  <riedel@apple.com>
1862
1863         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
1864         https://bugs.webkit.org/show_bug.cgi?id=174394
1865         <rdar://problem/33183504>
1866
1867         Reviewed by Ryosuke Niwa.
1868
1869         * DOM/DOMHTMLInputElement.h:
1870         * DOM/DOMHTMLInputElement.mm:
1871         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
1872         Determines if this HTMLInputElement is part of a login screen.
1873         (-[DOMHTMLInputElement representingPageUrl]):
1874         Returns the webpage's URL that is currently displayed in the Web View.
1875         (-[DOMHTMLInputElement insertTextSuggestion:]):
1876         Inserts login credentials into the Web View.
1877
1878 2017-09-25  Sam Weinig  <sam@webkit.org>
1879
1880         Remove unused EditorClient functions
1881         https://bugs.webkit.org/show_bug.cgi?id=177463
1882
1883         Reviewed by Alex Christensen.
1884
1885         Remove unused EditorClient functions.
1886
1887         * WebCoreSupport/WebEditorClient.h:
1888         * WebCoreSupport/WebEditorClient.mm:
1889         (WebEditorClient::canonicalizeURL): Deleted.
1890         (WebEditorClient::canonicalizeURLString): Deleted.
1891         (WebEditorClient::writeDataToPasteboard): Deleted.
1892         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
1893         (WebEditorClient::readDataFromPasteboard): Deleted.
1894         (WebEditorClient::pasteboardChangeCount): Deleted.
1895
1896 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1897
1898         Stop using PolicyCallback
1899         https://bugs.webkit.org/show_bug.cgi?id=176088
1900
1901         Reviewed by Andy Estes.
1902
1903         * WebCoreSupport/WebFrameLoaderClient.mm:
1904         (-[WebFramePolicyListener invalidate]):
1905         (-[WebFramePolicyListener receivedPolicyDecision:]):
1906
1907 2017-09-25  Sam Weinig  <sam@webkit.org>
1908
1909         Remove unnecessary userVisibleString EditorClient function
1910         https://bugs.webkit.org/show_bug.cgi?id=177456
1911
1912         Reviewed by Dan Bernstein.
1913
1914         * WebCoreSupport/WebEditorClient.h:
1915         * WebCoreSupport/WebEditorClient.mm:
1916         (WebEditorClient::userVisibleString): Deleted.
1917
1918             Remove userVisibleString client function.
1919
1920 2017-09-25  Alex Christensen  <achristensen@webkit.org>
1921
1922         Separate form submission from PolicyChecker infrastructure
1923         https://bugs.webkit.org/show_bug.cgi?id=177396
1924
1925         Reviewed by Geoffrey Garen.
1926
1927         * WebCoreSupport/WebFrameLoaderClient.h:
1928         * WebCoreSupport/WebFrameLoaderClient.mm:
1929         (WebFrameLoaderClient::dispatchWillSubmitForm):
1930
1931 2017-09-22  Zalan Bujtas  <zalan@apple.com>
1932
1933         WeakPtrFactory should populate m_ref lazily.
1934         https://bugs.webkit.org/show_bug.cgi?id=177375
1935
1936         Reviewed by Geoffrey Garen.
1937
1938         * WebCoreSupport/WebEditorClient.mm:
1939         (WebEditorClient::WebEditorClient):
1940         (WebEditorClient::requestCandidatesForSelection):
1941
1942 2017-09-22  Chris Dumez  <cdumez@apple.com>
1943
1944         Use high resolution timestamp for event time
1945         https://bugs.webkit.org/show_bug.cgi?id=154246
1946         <rdar://problem/34333304>
1947
1948         Reviewed by Ryosuke Niwa.
1949
1950         Use WallTime / MonotonicTime instead of double type for clarity.
1951
1952         * DOM/DOMEvent.mm:
1953         (-[DOMEvent timeStamp]):
1954         * WebView/WebFrame.mm:
1955         (-[WebFrame _dragSourceEndedAt:operation:]):
1956         * WebView/WebPDFView.mm:
1957         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1958
1959 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
1960
1961         Enable dataTransfer.items on macOS and iOS
1962         https://bugs.webkit.org/show_bug.cgi?id=177335
1963
1964         Reviewed by Sam Weinig.
1965
1966         * WebView/WebPreferences.mm:
1967         (+[WebPreferences initialize]):
1968
1969 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
1970
1971         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
1972         https://bugs.webkit.org/show_bug.cgi?id=177101
1973         <rdar://problem/34500648>
1974
1975         Reviewed by Brian Burg.
1976
1977         * WebInspector/WebNodeHighlight.mm:
1978         Ensure we close the window that we have just removed.
1979
1980 2017-09-20  Antti Koivisto  <antti@apple.com>
1981
1982         Remove DOM and styling support for CSS Regions
1983         https://bugs.webkit.org/show_bug.cgi?id=177221
1984
1985         Reviewed by Andreas Kling.
1986
1987         * Configurations/FeatureDefines.xcconfig:
1988         * DOM/DOMCSS.mm:
1989         (kitClass):
1990         * DOM/DOMElement.mm:
1991         (-[DOMElement webkitRegionOverset]): Deleted.
1992
1993 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
1994
1995         Layering violation in Editor::createFragment
1996         https://bugs.webkit.org/show_bug.cgi?id=176123
1997
1998         Reviewed by Darin Adler.
1999
2000         * Misc/WebNSURLExtras.h:
2001         * Misc/WebNSURLExtras.mm:
2002         * WebView/WebFrame.mm:
2003         * WebView/WebHTMLView.mm:
2004         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2005
2006         * WebCoreSupport/WebEditorClient.mm:
2007         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2008         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2009         way to avoid exporting the symbol just on newer OSes.
2010
2011 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2012
2013         On iOS, getData can't get text set by setData during copy event
2014         https://bugs.webkit.org/show_bug.cgi?id=176980
2015         <rdar://problem/34453915>
2016
2017         Reviewed by Darin Adler.
2018
2019         * WebCoreSupport/WebPlatformStrategies.h:
2020         * WebCoreSupport/WebPlatformStrategies.mm:
2021         (WebPlatformStrategies::copy): Deleted.
2022
2023 2017-09-18  Andy Estes  <aestes@apple.com>
2024
2025         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2026         https://bugs.webkit.org/show_bug.cgi?id=177029
2027
2028         Reviewed by Alex Christensen.
2029
2030         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2031         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2032         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2033         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2034         * WebCoreSupport/PopupMenuMac.mm:
2035         (PopupMenuMac::show):
2036         * WebCoreSupport/WebSystemInterface.mm:
2037         (InitWebCoreSystemInterface):
2038         * WebView/WebHTMLView.mm:
2039         (-[WebHTMLView setDataSource:]):
2040         (-[WebHTMLView attachRootLayer:]):
2041         * WebView/WebView.mm:
2042         (-[WebView _needsAdobeFrameReloadingQuirk]):
2043         (-[WebView _needsLinkElementTextCSSQuirk]):
2044         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2045         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2046         (-[WebView _preferencesChanged:]):
2047
2048 2017-09-15  Andy Estes  <aestes@apple.com>
2049
2050         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2051         https://bugs.webkit.org/show_bug.cgi?id=176953
2052
2053         Reviewed by Eric Carlson.
2054
2055         * WebCoreSupport/WebSystemInterface.mm:
2056         (InitWebCoreSystemInterface):
2057
2058 2017-09-14  Andy Estes  <aestes@apple.com>
2059
2060         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2061         https://bugs.webkit.org/show_bug.cgi?id=176931
2062
2063         Reviewed by Joseph Pecoraro.
2064
2065         * WebCoreSupport/WebSystemInterface.mm:
2066         (InitWebCoreSystemInterface):
2067
2068 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2069
2070         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2071         https://bugs.webkit.org/show_bug.cgi?id=176867
2072
2073         Reviewed by Sam Weinig.
2074
2075         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2076         (WebKit::NetscapePluginInstanceProxy::enumerate):
2077
2078 2017-09-13  Andy Estes  <aestes@apple.com>
2079
2080         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2081         https://bugs.webkit.org/show_bug.cgi?id=176729
2082
2083         Reviewed by Alex Christensen.
2084
2085         * WebCoreSupport/WebSystemInterface.mm:
2086         (InitWebCoreSystemInterface):
2087         * WebView/WebView.mm:
2088         (+[WebView _setCacheModel:]):
2089
2090 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2091
2092         Refactor WebContentReader out of EditorMac and EditorIOS
2093         https://bugs.webkit.org/show_bug.cgi?id=176770
2094
2095         Reviewed by Sam Weinig.
2096
2097         * WebCoreSupport/WebEditorClient.mm:
2098
2099 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2100
2101         Dragging & dropping a file creates an attachment element even when it's disabled
2102         https://bugs.webkit.org/show_bug.cgi?id=176769
2103
2104         Reviewed by Tim Horton.
2105
2106         * WebView/WebView.mm:
2107         (-[WebView _preferencesChanged:]):
2108
2109 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2110
2111         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2112         https://bugs.webkit.org/show_bug.cgi?id=176721
2113         <rdar://problem/34373660>
2114
2115         Reviewed by Tim Horton.
2116
2117         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2118         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2119
2120         * WebView/WebView.mm:
2121         (-[WebView _startDrag:]):
2122         (-[WebView _draggedElementBounds]):
2123         (-[WebView _endedDataInteraction:global:]):
2124         * WebView/WebViewData.h:
2125
2126 2017-09-11  Andy Estes  <aestes@apple.com>
2127
2128         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2129         https://bugs.webkit.org/show_bug.cgi?id=176472
2130
2131         Reviewed by Eric Carlson.
2132
2133         * WebCoreSupport/WebSystemInterface.mm:
2134         (InitWebCoreSystemInterface):
2135
2136 2017-09-09  Mark Lam  <mark.lam@apple.com>
2137
2138         Avoid duplicate computations of ExecState::vm().
2139         https://bugs.webkit.org/show_bug.cgi?id=176647
2140
2141         Reviewed by Saam Barati.
2142
2143         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2144         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2145         (WebKit::NetscapePluginInstanceProxy::construct):
2146         (WebKit::NetscapePluginInstanceProxy::setProperty):
2147         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2148         (WebKit::NetscapePluginInstanceProxy::enumerate):
2149         * Plugins/Hosted/ProxyInstance.mm:
2150         (WebKit::ProxyRuntimeMethod::create):
2151
2152 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2153
2154         Unreviewed, rolling out r221773.
2155         https://bugs.webkit.org/show_bug.cgi?id=176614
2156
2157         This caused build failures. (Requested by mlewis13 on
2158         #webkit).
2159
2160         Reverted changeset:
2161
2162         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2163         https://bugs.webkit.org/show_bug.cgi?id=176472
2164         http://trac.webkit.org/changeset/221773
2165
2166 2017-09-07  Andy Estes  <aestes@apple.com>
2167
2168         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2169         https://bugs.webkit.org/show_bug.cgi?id=176472
2170
2171         Reviewed by Eric Carlson.
2172
2173         * WebCoreSupport/WebSystemInterface.mm:
2174         (InitWebCoreSystemInterface):
2175
2176 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2177
2178         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2179         https://bugs.webkit.org/show_bug.cgi?id=176561
2180
2181         Reviewed by Brent Fulgham.
2182
2183         * Misc/WebNSUserDefaultsExtras.mm:
2184
2185 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2186
2187         Modernize Geolocation code
2188         https://bugs.webkit.org/show_bug.cgi?id=176496
2189
2190         Reviewed by Andy Estes.
2191
2192         * WebCoreSupport/WebGeolocationClient.h:
2193         * WebCoreSupport/WebGeolocationClient.mm:
2194         (WebGeolocationClient::requestPermission):
2195         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2196         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2197         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2198         * WebView/WebView.mm:
2199         (-[WebView _commonInitializationWithFrameName:groupName:]):
2200         (-[WebView _geolocationDidFailWithMessage:]):
2201
2202 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2203
2204         Remove some unused bits of code and resources
2205         https://bugs.webkit.org/show_bug.cgi?id=176275
2206
2207         Reviewed by Dan Bernstein.
2208
2209         * Misc/WebNSFileManagerExtras.mm:
2210         Include FileSystem instead of FileSystemIOS.
2211
2212 2017-09-03  Darin Adler  <darin@apple.com>
2213
2214         [Cocoa] Tidy a few things in legacy WebHTMLView
2215         https://bugs.webkit.org/show_bug.cgi?id=176280
2216
2217         Reviewed by Dan Bernstein.
2218
2219         * WebCoreSupport/WebChromeClient.mm:
2220         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
2221         methods it calls on WebHTMLView were doing nothing on iOS.
2222
2223         * WebView/WebFrame.mm:
2224         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
2225         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
2226
2227         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
2228         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
2229         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
2230         order. Removed all sorts of unused things. Made more code and fields Mac-only where
2231         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
2232         Use RetainPtr instead of writing retain/release wherever possible.
2233         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
2234         initialization for it. Removed various unused methods and declarations of methods.
2235         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
2236         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
2237         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
2238         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
2239         and remove CFRetain no longer needed since we don't support garbage collection any more.
2240         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
2241         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
2242         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
2243         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
2244         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
2245         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2246         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
2247         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
2248         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
2249         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
2250         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
2251         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
2252         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
2253         debug flag; we haven't used it for years and it's not clearly helpful.
2254         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
2255         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
2256         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
2257         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
2258         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
2259         two additional methods in the WebPrivate category and still be called by the two
2260         methods in the WebInternal category that were already using it.
2261         (-[WebHTMLView didAddSubview:]): Deleted.
2262         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
2263         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
2264         place this was called, the close method.
2265         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
2266         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
2267         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
2268         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
2269         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
2270         Added helper method to make the one below simpler.
2271         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
2272         Compared pasteboard type strings using isEqualToString: rather than using == since
2273         we want to actually compare the string contents. Also updated to use modern for loop,
2274         renamed a local variable from "s" to "localSubresources", and factored out the handling
2275         of three image types to use the helper method above.
2276         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
2277         _web_makePluginSubviewsPerformSelector:withObject: method.
2278         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
2279         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
2280         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
2281         not call the -[NSView subviews] method to make this identical on both platforms and used
2282         a modern for loop.
2283         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
2284         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
2285         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
2286         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
2287         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
2288         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
2289         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
2290         of it is Mac-only.
2291         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
2292         method did was call itself on the main thread, and do nothing if called on main thread.
2293         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
2294         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
2295         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
2296         half of this method.
2297         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
2298         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
2299         Simplified using a modern for loop and RetainPtr.
2300         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
2301         (-[WebHTMLView keyDown:]): Ditto.
2302         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
2303         (-[WebHTMLView performKeyEquivalent:]): Ditto.
2304         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
2305         (-[WebHTMLView complete:]): Ditto.
2306         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
2307         now macOS-only.
2308         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
2309         iOS since that is now macOS-only.
2310         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
2311         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
2312         a private one because it is not used or needed outside WebKit. Also made it macOS-only
2313         and reorganized to use early return.
2314         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
2315         on iOS, but kept there so we don't have to do #if at every call site.
2316         (-[WebHTMLView _pluginController]): Moved into internal category.
2317         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
2318         there only for GC, using C++ initialization, removing obsolete comment.
2319         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
2320         peculiar iOS-only comment.
2321         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
2322
2323         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
2324         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
2325         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
2326         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
2327         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
2328
2329         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
2330         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
2331         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
2332         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
2333         them at this time.
2334
2335 2017-09-03  Sam Weinig  <sam@webkit.org>
2336
2337         Remove CanvasProxy
2338         https://bugs.webkit.org/show_bug.cgi?id=176288
2339
2340         Reviewed by Yusuke Suzuki.
2341
2342         CanvasProxy does not appear to be in any current HTML spec
2343         and was disabled and unimplemented in our tree. Time to 
2344         get rid of it.
2345
2346         * Configurations/FeatureDefines.xcconfig:
2347
2348 2017-09-02  Andy Estes  <aestes@apple.com>
2349
2350         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
2351         https://bugs.webkit.org/show_bug.cgi?id=176270
2352
2353         Reviewed by Tim Horton.
2354
2355         * Plugins/Hosted/NetscapePluginHostManager.mm:
2356         (WebKit::NetscapePluginHostManager::spawnPluginHost):
2357         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2358         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2359         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
2360         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
2361         (WebKit::SoftwareCARenderer::context const):
2362         (WebKit::SoftwareCARenderer::renderContext const):
2363         (WebKit::SoftwareCARenderer::render):
2364         (-[WebHostedNetscapePluginView createPlugin]):
2365         (-[WebHostedNetscapePluginView createPluginLayer]):
2366         (-[WebHostedNetscapePluginView destroyPlugin]):
2367         (-[WebHostedNetscapePluginView drawRect:]):
2368         * WebCoreSupport/WebSystemInterface.mm:
2369         (InitWebCoreSystemInterface):
2370
2371 2017-09-01  Andy Estes  <aestes@apple.com>
2372
2373         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
2374         https://bugs.webkit.org/show_bug.cgi?id=176200
2375
2376         Reviewed by Tim Horton.
2377
2378         * Carbon/HIWebView.mm:
2379         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
2380         (overrideCGContext):
2381         (restoreCGContext):
2382         (Draw):
2383         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2384         (+[WebHostedNetscapePluginView initialize]):
2385         * Plugins/WebBaseNetscapePluginView.h:
2386         * Plugins/WebBaseNetscapePluginView.mm:
2387         (WebKit::sendUserChangeNotifications):
2388         * Plugins/WebNetscapePluginView.mm:
2389         (+[WebNetscapePluginView initialize]):
2390         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2391         * WebCoreSupport/WebSystemInterface.mm:
2392         (InitWebCoreSystemInterface):
2393         * WebView/WebFrame.mm:
2394         (-[WebFrame _paintBehaviorForDestinationContext:]):
2395         * WebView/WebFullScreenController.mm:
2396         (setClipRectForWindow):
2397         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
2398         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
2399         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
2400         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
2401
2402 2017-08-31  Andy Estes  <aestes@apple.com>
2403
2404         [Mac] Upstream AppKit-related WebKitSystemInterface functions
2405         https://bugs.webkit.org/show_bug.cgi?id=176175
2406
2407         Reviewed by Brady Eidson.
2408
2409         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2410         (WebKit::NetscapePluginInstanceProxy::keyEvent):
2411         * Plugins/Hosted/WebTextInputWindowController.m:
2412         (-[WebTextInputPanel init]):
2413         * WebCoreSupport/WebSystemInterface.mm:
2414         (InitWebCoreSystemInterface):
2415         * WebView/WebDynamicScrollBarsView.mm:
2416         (-[WebDynamicScrollBarsView scrollWheel:]):
2417         * WebView/WebHTMLView.mm:
2418         (-[WebHTMLView _removeWindowObservers]):
2419         (-[WebHTMLView addWindowObservers]):
2420         * WebView/WebView.mm:
2421         (-[WebView addWindowObserversForWindow:]):
2422         (-[WebView removeWindowObservers]):
2423         (-[WebView viewWillMoveToWindow:]):
2424
2425 2017-08-31  Alex Christensen  <achristensen@webkit.org>
2426
2427         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
2428         https://bugs.webkit.org/show_bug.cgi?id=175779
2429         <rdar://problem/22367975>
2430
2431         Reviewed by Tim Horton.
2432
2433         * WebCoreSupport/WebFrameLoaderClient.h:
2434         * WebCoreSupport/WebFrameLoaderClient.mm:
2435         (WebFrameLoaderClient::webGLPolicyForURL const):
2436         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
2437
2438 2017-08-30  Andy Estes  <aestes@apple.com>
2439
2440         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
2441         https://bugs.webkit.org/show_bug.cgi?id=176093
2442
2443         Reviewed by Eric Carlson.
2444
2445         * WebCoreSupport/WebSystemInterface.mm:
2446         (InitWebCoreSystemInterface):
2447
2448 2017-08-30  Andy Estes  <aestes@apple.com>
2449
2450         [Mac] Upstream Carbon-related WebKitSystemInterface functions
2451         https://bugs.webkit.org/show_bug.cgi?id=176087
2452
2453         Reviewed by Alex Christensen.
2454
2455         * Carbon/CarbonUtils.m:
2456         (getNSAutoreleasePoolCount):
2457         (WebInitForCarbon):
2458         (PoolCleaner):
2459         * Carbon/CarbonWindowAdapter.mm:
2460         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2461         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2462         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2463         (-[CarbonWindowAdapter _windowMovedToRect:]):
2464         * Carbon/HIViewAdapter.m:
2465         * Carbon/HIWebView.mm:
2466         (Draw):
2467         (CreateNSEventAdoptingCGEvent):
2468         (CopyEventCGEvent):
2469         (CreateNSEventWithCarbonClickEvent):
2470         (Click):
2471         (CreateNSEventWithCarbonEvent):
2472         (MouseUp):
2473         (CreateNSEventWithCarbonMouseMoveEvent):
2474         (MouseMoved):
2475         (MouseDragged):
2476         (MouseWheelMoved):
2477         (WindowHandler):
2478         (HIWebViewEventHandler):
2479         * Misc/QuickDrawCompatibility.h: Removed.
2480         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2481         (getCarbonEvent):
2482         (WebNetscapePluginEventHandlerCarbon::keyDown):
2483         (WebNetscapePluginEventHandlerCarbon::keyUp):
2484         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2485         (WebNetscapePluginEventHandlerCocoa::keyDown):
2486         * Plugins/WebNetscapePluginView.mm:
2487         (-[WebNetscapePluginView tellQuickTimeToChill]):
2488
2489 2017-08-29  Andy Estes  <aestes@apple.com>
2490
2491         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
2492         https://bugs.webkit.org/show_bug.cgi?id=176046
2493
2494         Reviewed by Alex Christensen.
2495
2496         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
2497         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
2498
2499         * Misc/WebNSFileManagerExtras.mm:
2500         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
2501         (setMetaData): Deleted.
2502         * WebCoreSupport/WebSystemInterface.mm:
2503         (InitWebCoreSystemInterface):
2504
2505 2017-08-28  Andy Estes  <aestes@apple.com>
2506
2507         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
2508         https://bugs.webkit.org/show_bug.cgi?id=176039
2509
2510         Reviewed by Alex Christensen.
2511
2512         * WebCoreSupport/WebSystemInterface.mm:
2513         (InitWebCoreSystemInterface):
2514         * WebView/WebPreferences.mm:
2515         (+[WebPreferences _systemCFStringEncoding]):
2516
2517 2017-08-28  Andy Estes  <aestes@apple.com>
2518
2519         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
2520         https://bugs.webkit.org/show_bug.cgi?id=176032
2521
2522         Reviewed by Alex Christensen.
2523
2524         * WebCoreSupport/WebSystemInterface.mm:
2525         (InitWebCoreSystemInterface):
2526         * WebView/WebView.mm:
2527         (-[WebView _cachedResponseForURL:]):
2528
2529 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
2530
2531         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
2532         https://bugs.webkit.org/show_bug.cgi?id=175992
2533         <rdar://problem/34086613>
2534
2535         Reviewed by Daniel Bates.
2536
2537         * WebCoreSupport/WebPlatformStrategies.h:
2538         * WebCoreSupport/WebPlatformStrategies.mm:
2539         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
2540         cookies should be included, and return a pair containing the resulting cookie string and a boolean
2541         indicating if secure cookies were accessed.
2542
2543 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2544
2545         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
2546         https://bugs.webkit.org/show_bug.cgi?id=170955
2547         <rdar://problem/31697653>
2548
2549         Reviewed by Ryosuke Niwa.
2550
2551         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
2552         text is being replaced.
2553
2554         * WebView/WebHTMLView.mm:
2555         (-[WebHTMLView insertText:]):
2556
2557 2017-08-24  Chris Dumez  <cdumez@apple.com>
2558
2559         [Directory Upload] Add basic support for input.webkitdirectory
2560         https://bugs.webkit.org/show_bug.cgi?id=175950
2561         <rdar://problem/33951915>
2562
2563         Reviewed by Geoffrey Garen.
2564
2565         Add private API to toggle Directory Upload support on Mac WebKit1.
2566
2567         * WebView/WebPreferenceKeysPrivate.h:
2568         * WebView/WebPreferences.mm:
2569         (+[WebPreferences initialize]):
2570         (-[WebPreferences setDirectoryUploadEnabled:]):
2571         (-[WebPreferences directoryUploadEnabled]):
2572         * WebView/WebPreferencesPrivate.h:
2573         * WebView/WebView.mm:
2574         (-[WebView _preferencesChanged:]):
2575
2576 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2577
2578         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
2579         https://bugs.webkit.org/show_bug.cgi?id=175370
2580         <rdar://problem/33799806>
2581
2582         Reviewed by Ryosuke Niwa.
2583
2584         Adjust WebEditorClient for interface changes.
2585
2586         * WebCoreSupport/WebEditorClient.h:
2587
2588 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2589
2590         Remove ChromeClient::scrollbarsModeDidChange
2591         https://bugs.webkit.org/show_bug.cgi?id=175805
2592
2593         Reviewed by Daniel Bates.
2594
2595         * WebCoreSupport/WebChromeClient.h:
2596
2597 2017-08-22  Alex Christensen  <achristensen@webkit.org>
2598
2599         Remove ChromeClient::hasOpenedPopup
2600         https://bugs.webkit.org/show_bug.cgi?id=175804
2601
2602         Reviewed by Sam Weinig.
2603
2604         * WebCoreSupport/WebChromeClient.h:
2605         * WebCoreSupport/WebChromeClient.mm:
2606         (WebChromeClient::hasOpenedPopup const): Deleted.
2607
2608 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
2609
2610         Disable access to secure cookies if an HTTPS site loads mixed content
2611         https://bugs.webkit.org/show_bug.cgi?id=157053
2612         <rdar://problem/11290808>
2613
2614         Reviewed by Dan Bates.
2615
2616         * WebCoreSupport/WebPlatformStrategies.h:
2617         * WebCoreSupport/WebPlatformStrategies.mm:
2618         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
2619         indicating whether secure cookies should be included in the response.
2620
2621 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2622
2623         [PAL] Move spi/mac directory into PAL
2624         https://bugs.webkit.org/show_bug.cgi?id=175649
2625
2626         Reviewed by Myles C. Maxfield.
2627
2628         * Misc/WebSharingServicePickerController.h:
2629         * WebCoreSupport/WebContextMenuClient.mm:
2630         * WebCoreSupport/WebEditorClient.mm:
2631         * WebCoreSupport/WebSelectionServiceController.mm:
2632         * WebView/WebHTMLView.mm:
2633         * WebView/WebImmediateActionController.h:
2634         * WebView/WebImmediateActionController.mm:
2635         * WebView/WebView.mm:
2636
2637 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2638
2639         [PAL] Relocate SessionID to root
2640         https://bugs.webkit.org/show_bug.cgi?id=175684
2641
2642         Reviewed by Alex Christensen.
2643
2644         * WebCoreSupport/WebFrameNetworkingContext.mm:
2645
2646 2017-08-17  Andreas Kling  <akling@apple.com>
2647
2648         Disable CSS regions at compile time
2649         https://bugs.webkit.org/show_bug.cgi?id=175630
2650
2651         Reviewed by Antti Koivisto.
2652
2653         * Configurations/FeatureDefines.xcconfig:
2654
2655 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
2656
2657         [PAL] Move SessionID into PAL
2658         https://bugs.webkit.org/show_bug.cgi?id=174192
2659
2660         Reviewed by Antti Koivisto.
2661
2662         * Misc/WebCache.mm:
2663         (+[WebCache imageForURL:]):
2664         * WebCoreSupport/WebFrameLoaderClient.h:
2665         * WebCoreSupport/WebFrameLoaderClient.mm:
2666         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
2667         * WebCoreSupport/WebFrameNetworkingContext.mm:
2668         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
2669         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
2670         (WebFrameNetworkingContext::storageSession const):
2671         * WebCoreSupport/WebPlatformStrategies.h:
2672         * WebCoreSupport/WebPlatformStrategies.mm:
2673         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
2674         * WebKitPrefix.h:
2675
2676 2017-08-16  Andy Estes  <aestes@apple.com>
2677
2678         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
2679         https://bugs.webkit.org/show_bug.cgi?id=175648
2680
2681         Reviewed by Tim Horton.
2682
2683         * WebCoreSupport/WebPaymentCoordinatorClient.h:
2684         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
2685         (WebPaymentCoordinatorClient::showPaymentUI):
2686
2687 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2688
2689         [PAL] Move spi/ios and spi/win directories into PAL
2690         https://bugs.webkit.org/show_bug.cgi?id=175171
2691
2692         Reviewed by Antti Koivisto.
2693
2694         * WebCoreSupport/WebFrameLoaderClient.mm:
2695         * WebView/WebView.mm:
2696
2697 2017-08-16  Andy Estes  <aestes@apple.com>
2698
2699         [Payment Request] Add an ENABLE flag and an experimental feature preference
2700         https://bugs.webkit.org/show_bug.cgi?id=175622
2701
2702         Reviewed by Tim Horton.
2703
2704         * Configurations/FeatureDefines.xcconfig:
2705
2706 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
2707
2708         [PAL] Move Sleep classes into PAL
2709         https://bugs.webkit.org/show_bug.cgi?id=175456
2710
2711         Reviewed by Ryosuke Niwa.
2712
2713         * WebView/WebFullScreenController.h:
2714
2715 2017-08-15  Youenn Fablet  <youenn@apple.com>
2716
2717         [Cache API] Adding generic support for CacheStorage and Cache methods
2718         https://bugs.webkit.org/show_bug.cgi?id=175455
2719
2720         Reviewed by Chris Dumez.
2721
2722         * WebView/WebView.mm:
2723         (-[WebView _commonInitializationWithFrameName:groupName:]):
2724
2725 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2726
2727         Remove Proximity Events and related code
2728         https://bugs.webkit.org/show_bug.cgi?id=175545
2729
2730         Reviewed by Daniel Bates.
2731
2732         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
2733         and other related code.
2734
2735         * Configurations/FeatureDefines.xcconfig:
2736
2737 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2738
2739         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
2740         https://bugs.webkit.org/show_bug.cgi?id=175504
2741
2742         Reviewed by Sam Weinig.
2743
2744         * Configurations/FeatureDefines.xcconfig:
2745         * DOM/DOMHTMLFormElement.mm:
2746         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
2747         * WebCoreSupport/WebFrameLoaderClient.h:
2748
2749 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
2750
2751         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
2752         https://bugs.webkit.org/show_bug.cgi?id=175557
2753
2754         Reviewed by Jon Lee.
2755
2756         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
2757
2758         * Configurations/FeatureDefines.xcconfig:
2759
2760 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
2761
2762         Composition underline color is always black
2763         https://bugs.webkit.org/show_bug.cgi?id=174675
2764
2765         Reviewed by Ryosuke Niwa.
2766
2767         * WebView/WebHTMLView.mm:
2768         (extractUnderlines): If NSUnderlineColorAttributeName
2769         is not present use text color for composition underline.
2770         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
2771         for composition underline in the plain text case.
2772
2773 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
2774
2775         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
2776         https://bugs.webkit.org/show_bug.cgi?id=175474
2777         <rdar://problem/33844628>
2778
2779         Reviewed by Wenson Hsieh.
2780
2781         Replaced the build flag by a runtime flag and disabled the feature by default.
2782
2783         * Configurations/FeatureDefines.xcconfig:
2784         * WebView/WebPreferenceKeysPrivate.h:
2785         * WebView/WebPreferences.mm:
2786         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
2787         (-[WebPreferences dataTransferItemsEnabled]): Added.
2788         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
2789         * WebView/WebPreferencesPrivate.h:
2790         * WebView/WebView.mm:
2791         (-[WebView _preferencesChanged:]):
2792
2793 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2794
2795         Remove ENABLE_GAMEPAD_DEPRECATED
2796         https://bugs.webkit.org/show_bug.cgi?id=175361
2797
2798         Reviewed by Carlos Garcia Campos.
2799
2800         * Configurations/FeatureDefines.xcconfig:
2801
2802 2017-08-09  Chris Dumez  <cdumez@apple.com>
2803
2804         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
2805         https://bugs.webkit.org/show_bug.cgi?id=175401
2806
2807         Reviewed by Brady Eidson.
2808
2809         * WebView/WebPreferenceKeysPrivate.h:
2810         * WebView/WebPreferences.mm:
2811         (+[WebPreferences initialize]):
2812         (-[WebPreferences beaconAPIEnabled]): Deleted.
2813         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
2814         * WebView/WebPreferencesPrivate.h:
2815         * WebView/WebView.mm:
2816         (-[WebView _preferencesChanged:]):
2817
2818 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
2819
2820         [PAL] Move spi/cocoa and spi/cg directories into PAL
2821         https://bugs.webkit.org/show_bug.cgi?id=175175
2822
2823         Reviewed by Myles C. Maxfield.
2824
2825         * History/WebHistory.mm:
2826         * Misc/WebDownload.mm:
2827         * Misc/WebKitNSStringExtras.mm:
2828         * Plugins/Hosted/NetscapePluginHostManager.mm:
2829         * Plugins/WebPluginDatabase.mm:
2830         * WebCoreSupport/WebFrameLoaderClient.mm:
2831         * WebInspector/WebNodeHighlight.mm:
2832         * WebView/WebHTMLView.mm:
2833         * WebView/WebIndicateLayer.mm:
2834         * WebView/WebView.mm:
2835         * WebView/WebViewData.h:
2836
2837 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2838
2839         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
2840         https://bugs.webkit.org/show_bug.cgi?id=175392
2841         <rdar://problem/33783207>
2842
2843         Reviewed by Tim Horton and Megan Gardner.
2844
2845         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
2846
2847         * Configurations/FeatureDefines.xcconfig:
2848
2849 2017-08-09  Daniel Bates  <dabates@apple.com>
2850
2851         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
2852         https://bugs.webkit.org/show_bug.cgi?id=175247
2853         <rdar://problem/33679804>
2854
2855         Reviewed by Brady Eidson.
2856
2857         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
2858         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
2859         clients that need to make use of this information at this time. If such a needs comes up
2860         then we can expose API/SPI similar to what we do for WebKit.
2861
2862         * WebCoreSupport/WebFrameLoaderClient.h:
2863         * WebCoreSupport/WebFrameLoaderClient.mm:
2864         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2865
2866 2017-08-08  Brady Eidson  <beidson@apple.com>
2867
2868         Don't enable default icon loading in WK1 for apps linked against old SDKs.
2869         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
2870
2871         Reviewed by Andy Estes.
2872
2873         * Misc/WebKitVersionChecks.h:
2874         * WebCoreSupport/WebFrameLoaderClient.mm:
2875         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
2876           the app is linked against new WebKit with the new behavior.
2877
2878 2017-08-07  Devin Rousso  <drousso@apple.com>
2879
2880         Web Inspector: Preview Canvas path when viewing a recording
2881         https://bugs.webkit.org/show_bug.cgi?id=174967
2882
2883         Reviewed by Brian Burg.
2884
2885         * WebView/WebPreferenceKeysPrivate.h:
2886         * WebView/WebPreferences.mm:
2887         (+[WebPreferences initialize]):
2888         (-[WebPreferences inspectorAdditionsEnabled]):
2889         (-[WebPreferences setInspectorAdditionsEnabled:]):
2890         * WebView/WebPreferencesPrivate.h:
2891         * WebView/WebView.mm:
2892         (-[WebView _preferencesChanged:]):
2893         Add plumbing for new InspectorAdditions runtime flag.
2894
2895 2017-08-07  Brian Burg  <bburg@apple.com>
2896
2897         Remove CANVAS_PATH compilation guard
2898         https://bugs.webkit.org/show_bug.cgi?id=175207
2899
2900         Reviewed by Sam Weinig.
2901
2902         * Configurations/FeatureDefines.xcconfig:
2903
2904 2017-08-04  Youenn Fablet  <youenn@apple.com>
2905
2906         [Cache API] Add Cache and CacheStorage IDL definitions
2907         https://bugs.webkit.org/show_bug.cgi?id=175201
2908
2909         Reviewed by Brady Eidson.
2910
2911         * WebView/WebPreferenceKeysPrivate.h:
2912         * WebView/WebPreferences.mm:
2913         (+[WebPreferences initialize]):
2914         (-[WebPreferences cacheAPIEnabled]):
2915         (-[WebPreferences setCacheAPIEnabled:]):
2916         * WebView/WebPreferencesPrivate.h:
2917         * WebView/WebView.mm:
2918         (-[WebView _preferencesChanged:]):
2919
2920 2017-08-04  Matt Lewis  <jlewis3@apple.com>
2921
2922         Unreviewed, rolling out r220271.
2923
2924         Rolling out due to Layout Test failing on iOS Simulator.
2925
2926         Reverted changeset:
2927
2928         "Remove STREAMS_API compilation guard"
2929         https://bugs.webkit.org/show_bug.cgi?id=175165
2930         http://trac.webkit.org/changeset/220271
2931
2932 2017-08-04  Youenn Fablet  <youenn@apple.com>
2933
2934         Remove STREAMS_API compilation guard
2935         https://bugs.webkit.org/show_bug.cgi?id=175165
2936
2937         Reviewed by Darin Adler.
2938
2939         * Configurations/FeatureDefines.xcconfig:
2940         * WebView/WebPreferences.mm:
2941         (+[WebPreferences initialize]):
2942         * WebView/WebView.mm:
2943         (-[WebView _preferencesChanged:]):
2944
2945 2017-08-03  Brian Burg  <bburg@apple.com>
2946
2947         Remove ENABLE(WEB_SOCKET) guards
2948         https://bugs.webkit.org/show_bug.cgi?id=167044
2949
2950         Reviewed by Joseph Pecoraro.
2951
2952         * Configurations/FeatureDefines.xcconfig:
2953         * WebView/WebPreferencesPrivate.h:
2954
2955 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
2956
2957         [PAL] Move spi/cf directory into PAL
2958         https://bugs.webkit.org/show_bug.cgi?id=175057
2959
2960         Reviewed by Antti Koivisto.
2961
2962         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2963         * Plugins/WebNetscapePluginStream.mm:
2964         * WebCoreSupport/WebFrameNetworkingContext.mm:
2965         * WebView/WebPreferences.mm:
2966         * WebView/WebView.mm:
2967
2968 2017-08-03  Youenn Fablet  <youenn@apple.com>
2969
2970         Remove FETCH_API compilation guard
2971         https://bugs.webkit.org/show_bug.cgi?id=175154
2972
2973         Reviewed by Chris Dumez.
2974
2975         * Configurations/FeatureDefines.xcconfig:
2976         * WebView/WebPreferences.mm:
2977         (+[WebPreferences initialize]):
2978         * WebView/WebView.mm:
2979         (-[WebView _preferencesChanged:]):
2980
2981 2017-08-03  Brady Eidson  <beidson@apple.com>
2982
2983         Add SW IDLs and stub out basic functionality.
2984         https://bugs.webkit.org/show_bug.cgi?id=175115
2985
2986         Reviewed by Chris Dumez.
2987
2988         * Configurations/FeatureDefines.xcconfig:
2989
2990 2017-08-02  Sam Weinig  <sam@webkit.org>
2991
2992         [WebIDL] Convert MutationCallback to be a normal generated callback
2993         https://bugs.webkit.org/show_bug.cgi?id=174140
2994
2995         Reviewed by Darin Adler.
2996
2997         * DOM/DOMDocument.mm:
2998         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
2999         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3000         Pass, now necessary, Document to NativeNodeFilter constructor.
3001
3002 2017-08-01  Chris Dumez  <cdumez@apple.com>
3003
3004         Add initial support for navigator.sendBeacon
3005         https://bugs.webkit.org/show_bug.cgi?id=175007
3006         <rdar://problem/33547728>
3007
3008         Reviewed by Sam Weinig.
3009
3010         Add setting to toggle support for the Beacon API (it is disabled by default).
3011
3012         * WebView/WebPreferenceKeysPrivate.h:
3013         * WebView/WebPreferences.mm:
3014         (+[WebPreferences initialize]):
3015         (-[WebPreferences beaconAPIEnabled]):
3016         (-[WebPreferences setBeaconAPIEnabled:]):
3017         * WebView/WebPreferencesPrivate.h:
3018         * WebView/WebView.mm:
3019         (-[WebView _preferencesChanged:]):
3020
3021 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3022
3023         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3024         https://bugs.webkit.org/show_bug.cgi?id=174437
3025
3026         Reviewed by Darin Adler.
3027
3028         Remove redundant Web- prefix from classes in WebKit namespace.
3029
3030         * WebView/WebView.mm:
3031         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3032         * WebView/WebViewData.h:
3033         * WebView/WebViewData.mm:
3034
3035 2017-07-26  Brian Burg  <bburg@apple.com>
3036
3037         Remove WEB_TIMING feature flag
3038         https://bugs.webkit.org/show_bug.cgi?id=174795
3039
3040         Reviewed by Alex Christensen.
3041
3042         * Configurations/FeatureDefines.xcconfig:
3043
3044 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3045
3046         Async image decoding for large images should be disabled after the first time a tile is painted
3047         https://bugs.webkit.org/show_bug.cgi?id=174451
3048         <rdar://problem/31246421>
3049
3050         Reviewed by Simon Fraser.
3051
3052         * WebView/WebFrame.mm:
3053         (-[WebFrame _paintBehaviorForDestinationContext:]):
3054         (-[WebFrame _drawRect:contentsOnly:]):
3055         * WebView/WebHTMLView.mm:
3056         (imageFromRect):
3057
3058 2017-07-23  Darin Adler  <darin@apple.com>
3059
3060         More NeverDestroyed and related cleanup
3061         https://bugs.webkit.org/show_bug.cgi?id=174745
3062
3063         Reviewed by Alex Christensen.
3064
3065         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3066         for names that aren't even used in this file.
3067         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3068         -[NSArray arrayWithObject:].
3069         (-[DOMNode absoluteQuads]): Ditto.
3070         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3071         of writing out various types.
3072         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3073         syntax instea of -[NSArray arrayWithObject:].
3074         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3075         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3076         of writing out various types.
3077         (-[DOMHTMLImageElement mimeType]): Ditto.
3078
3079 2017-07-24  Chris Dumez  <cdumez@apple.com>
3080
3081         ExceptionCode enumeration should use modern exception names
3082         https://bugs.webkit.org/show_bug.cgi?id=174794
3083
3084         Reviewed by Geoffrey Garen.
3085
3086         * DOM/ExceptionHandlers.mm:
3087         (raiseNotSupportedErrorException):
3088
3089 2017-07-23  Chris Dumez  <cdumez@apple.com>
3090
3091         Drop ExceptionCodeDescription class
3092         https://bugs.webkit.org/show_bug.cgi?id=174757
3093
3094         Reviewed by Darin Adler.
3095
3096         Stop using ExceptionCodeDescription.
3097
3098         * DOM/ExceptionHandlers.mm:
3099         (raiseDOMErrorException):
3100
3101 2017-07-21  Andreas Kling  <akling@apple.com>
3102
3103         Use more references in event dispatch code
3104         https://bugs.webkit.org/show_bug.cgi?id=174681
3105
3106         Reviewed by Geoffrey Garen.
3107
3108         * DOM/ObjCEventListener.h:
3109         * DOM/ObjCEventListener.mm:
3110         (WebCore::ObjCEventListener::handleEvent):
3111         * WebCoreSupport/WebFrameLoaderClient.mm:
3112         (NetscapePluginWidget::handleEvent):
3113
3114 2017-07-21  Brady Eidson  <beidson@apple.com>
3115
3116         Get rid of WebCore IconDatabase code.
3117         https://bugs.webkit.org/show_bug.cgi?id=174700
3118
3119         Reviewed by Tim Horton.
3120
3121         * Misc/WebCoreStatistics.mm:
3122         (+[WebCoreStatistics iconPageURLMappingCount]):
3123         (+[WebCoreStatistics iconRetainedPageURLCount]):
3124         (+[WebCoreStatistics iconRecordCount]):
3125         (+[WebCoreStatistics iconsWithDataCount]):
3126         * WebCoreSupport/WebFrameLoaderClient.h:
3127         * WebCoreSupport/WebFrameLoaderClient.mm:
3128         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
3129         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
3130         * WebView/WebView.mm:
3131         (-[WebView mainFrameIconURL]):
3132
3133 2017-07-20  Chris Dumez  <cdumez@apple.com>
3134
3135         Drop legacy XPathException type
3136         https://bugs.webkit.org/show_bug.cgi?id=174679
3137
3138         Reviewed by Sam Weinig.
3139
3140         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3141         no longer expose XPathException.
3142
3143         * DOM/ExceptionHandlers.mm:
3144         (raiseDOMErrorException):
3145
3146 2017-07-20  Chris Dumez  <cdumez@apple.com>
3147
3148         Unreviewed, rolling out r219706.
3149
3150         Broke iOS build
3151
3152         Reverted changeset:
3153
3154         "Drop legacy XPathException type"
3155         https://bugs.webkit.org/show_bug.cgi?id=174679
3156         http://trac.webkit.org/changeset/219706
3157
3158 2017-07-20  Chris Dumez  <cdumez@apple.com>
3159
3160         Drop legacy XPathException type
3161         https://bugs.webkit.org/show_bug.cgi?id=174679
3162
3163         Reviewed by Sam Weinig.
3164
3165         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3166         no longer expose XPathException.
3167
3168         * DOM/ExceptionHandlers.mm:
3169         (raiseDOMErrorException):
3170         * WebKit.exp:
3171
3172 2017-07-20  Chris Dumez  <cdumez@apple.com>
3173
3174         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
3175         https://bugs.webkit.org/show_bug.cgi?id=174660
3176
3177         Reviewed by Geoffrey Garen.
3178
3179         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
3180         This essentially replaces a branch to figure out if the new size is less or greater than the
3181         current size by an assertion.
3182
3183         * Plugins/WebNetscapePluginView.mm:
3184         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3185
3186 2017-07-20  Brady Eidson  <beidson@apple.com>
3187
3188         Deprecate WebIconDatabase in WebKitLegacy/mac.
3189         https://bugs.webkit.org/show_bug.cgi?id=174607
3190
3191         Reviewed by Alex Christensen.
3192
3193         This patch:
3194         1 - Formally deprecates WebIconDatabase (which was never API anyways)
3195         2 - Guts the class to where it can only return the default icon at the small size
3196         3 - Reworks other parts of WebKitLegacy that used it for anything to either
3197             use something else or to not do anything.
3198         
3199         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
3200         and that patch will remove all of the last remnants of WebIconDatabase.
3201         
3202         * History/WebHistoryItem.mm:
3203         (-[WebHistoryItem icon]):
3204
3205         * Misc/WebIconDatabase.h:
3206         * Misc/WebIconDatabase.mm:
3207         (-[WebIconDatabase init]):
3208         (-[WebIconDatabase iconForURL:withSize:cache:]):
3209         (-[WebIconDatabase iconForURL:withSize:]):
3210         (-[WebIconDatabase defaultIconWithSize:]):
3211         (-[WebIconDatabase defaultIconForURL:withSize:]):
3212         (-[WebIconDatabase iconURLForURL:]):
3213         (-[WebIconDatabase retainIconForURL:]):
3214         (-[WebIconDatabase releaseIconForURL:]):
3215         (+[WebIconDatabase delayDatabaseCleanup]):
3216         (+[WebIconDatabase allowDatabaseCleanup]):
3217         (-[WebIconDatabase setDelegate:]):
3218         (-[WebIconDatabase delegate]):
3219         (+[WebIconDatabase initialize]): Deleted.
3220         (-[WebIconDatabase isEnabled]): Deleted.
3221         (-[WebIconDatabase setEnabled:]): Deleted.
3222         (-[WebIconDatabase removeAllIcons]): Deleted.
3223         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
3224         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
3225         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
3226         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
3227         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
3228         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
3229         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
3230         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
3231         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
3232         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
3233         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
3234         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
3235         (-[WebIconDatabase _databaseDirectory]): Deleted.
3236         (webGetNSImage): Deleted.
3237
3238         * Misc/WebIconDatabaseDelegate.h: Removed.
3239         * Misc/WebIconDatabaseInternal.h: Removed.
3240         * Misc/WebIconDatabasePrivate.h: Removed.
3241
3242         * WebCoreSupport/WebFrameLoaderClient.mm:
3243         (webGetNSImage):
3244
3245         * WebCoreSupport/WebIconDatabaseClient.mm:
3246         (WebIconDatabaseClient::didRemoveAllIcons):
3247         (WebIconDatabaseClient::didImportIconURLForPageURL):
3248
3249         * WebView/WebView.mm:
3250         (-[WebView setFrameLoadDelegate:]):
3251         (-[WebView mainFrameIcon]):
3252
3253 2017-07-18  Andy Estes  <aestes@apple.com>
3254
3255         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
3256         https://bugs.webkit.org/show_bug.cgi?id=174631
3257
3258         Reviewed by Tim Horton.
3259
3260         * Configurations/Base.xcconfig:
3261
3262 2017-07-18  Andy Estes  <aestes@apple.com>
3263
3264         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
3265         https://bugs.webkit.org/show_bug.cgi?id=174631
3266
3267         Reviewed by Sam Weinig.
3268
3269         * Configurations/Base.xcconfig:
3270
3271 2017-07-18  Andy Estes  <aestes@apple.com>
3272
3273         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
3274         https://bugs.webkit.org/show_bug.cgi?id=174631
3275
3276         Reviewed by Dan Bernstein.
3277
3278         * Configurations/Base.xcconfig:
3279
3280 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3281
3282         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
3283         https://bugs.webkit.org/show_bug.cgi?id=174640
3284         <rdar://problem/33297400>
3285
3286         Reviewed by Tim Horton.
3287
3288         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
3289         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
3290         web thread here, to match the other WebView drag and drop SPI methods.
3291
3292         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
3293         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
3294         should make this robust against future UIKit changes that could make this no longer the case.
3295
3296         * WebView/WebView.mm:
3297         (-[WebView _requestStartDataInteraction:globalPosition:]):
3298         (-[WebView _dataInteractionCaretRect]):
3299
3300 2017-07-18  Andy Estes  <aestes@apple.com>
3301
3302         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
3303         https://bugs.webkit.org/show_bug.cgi?id=174631
3304
3305         Reviewed by Darin Adler.
3306
3307         * Configurations/Base.xcconfig:
3308
3309 2017-07-17  Sam Weinig  <sam@webkit.org>
3310
3311         [WebIDL] Remove custom bindings that require non-caching JS strings
3312         https://bugs.webkit.org/show_bug.cgi?id=174552
3313
3314         Reviewed by Darin Adler.
3315
3316         * DOM/DOMHTMLCanvasElement.mm:
3317         (-[DOMHTMLCanvasElement toDataURL:]):
3318         Update to account for implementation now returning an UncachedString.
3319
3320 2017-07-17  Darin Adler  <darin@apple.com>
3321
3322         Improve use of NeverDestroyed
3323         https://bugs.webkit.org/show_bug.cgi?id=174348
3324
3325         Reviewed by Sam Weinig.
3326
3327         * Misc/WebStringTruncator.mm:
3328         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
3329         NeverDestroyed<RetainPtr> with just an NSFont * global.
3330
3331         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
3332         NeverDestroyed.h.
3333         * Storage/WebDatabaseManager.mm: Ditto.
3334         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
3335         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
3336
3337         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
3338         (aeDescFromJSValue): Removed double hashing by using the return value from
3339         add rather than calling contains before calling add.
3340
3341 2017-07-14  Jer Noble  <jer.noble@apple.com>
3342
3343         Allow clients to override their own hardware media requirements where no fallback media exists.
3344         https://bugs.webkit.org/show_bug.cgi?id=174426
3345         <rdar://problem/32537704>
3346
3347         Reviewed by Eric Carlson.
3348
3349         Add a new WebPreferences property to control WebCore's new
3350         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
3351
3352         * WebView/WebPreferenceKeysPrivate.h:
3353         * WebView/WebPreferences.mm:
3354         (+[WebPreferences initialize]):
3355         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
3356         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
3357         * WebView/WebPreferencesPrivate.h:
3358         * WebView/WebView.mm:
3359         (-[WebView _preferencesChanged:]):
3360
3361 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
3362
3363         Async image decoding for large images should be disabled by default
3364         https://bugs.webkit.org/show_bug.cgi?id=174432
3365
3366         Reviewed by Simon Fraser.
3367
3368         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
3369         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
3370         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
3371            a child view instead of propagating PaintBehaviorSnapshotting.
3372         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
3373            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
3374
3375         * WebView/WebFrame.mm:
3376         (-[WebFrame _paintBehaviorForDestinationContext:]):
3377         (-[WebFrame _drawRect:contentsOnly:]):
3378         * WebView/WebHTMLView.mm:
3379         (imageFromRect):
3380
3381 2017-07-12  Daniel Bates  <dabates@apple.com>
3382
3383         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
3384         https://bugs.webkit.org/show_bug.cgi?id=174427
3385
3386         Rubber-stamped by Brady Eidson.
3387
3388         * WebView/WebPDFView.mm:
3389         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3390
3391 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3392
3393         Unreviewed, rolling out r219401.
3394
3395         This revision rolled out the previous patch, but after talking
3396         with reviewer, a rebaseline is what was needed.Rolling back in
3397         before rebaseline.
3398
3399         Reverted changeset:
3400
3401         "Unreviewed, rolling out r219379."
3402         https://bugs.webkit.org/show_bug.cgi?id=174400
3403         http://trac.webkit.org/changeset/219401
3404
3405 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3406
3407         Unreviewed, rolling out r219379.
3408
3409         This revision caused a consistent failure in the test
3410         fast/dom/Window/property-access-on-cached-window-after-frame-
3411         removed.html.
3412
3413         Reverted changeset:
3414
3415         "Remove NAVIGATOR_HWCONCURRENCY"
3416         https://bugs.webkit.org/show_bug.cgi?id=174400
3417         http://trac.webkit.org/changeset/219379
3418
3419 2017-07-11  Dean Jackson  <dino@apple.com>
3420
3421         Remove NAVIGATOR_HWCONCURRENCY
3422         https://bugs.webkit.org/show_bug.cgi?id=174400
3423
3424         * Configurations/FeatureDefines.xcconfig:
3425
3426 2017-07-11  Dean Jackson  <dino@apple.com>
3427
3428         Rolling out r219372.
3429
3430         * Configurations/FeatureDefines.xcconfig:
3431
3432 2017-07-11  Dean Jackson  <dino@apple.com>
3433
3434         Remove NAVIGATOR_HWCONCURRENCY
3435         https://bugs.webkit.org/show_bug.cgi?id=174400
3436
3437         * Configurations/FeatureDefines.xcconfig:
3438
3439 2017-07-03  Brian Burg  <bburg@apple.com>
3440
3441         Web Replay: remove some unused code
3442         https://bugs.webkit.org/show_bug.cgi?id=173903
3443
3444         Rubber-stamped by Joseph Pecoraro.
3445
3446         * Configurations/FeatureDefines.xcconfig:
3447
3448 2017-07-09  Brady Eidson  <beidson@apple.com>
3449
3450         Remove some obsolete WebKitVersionChecks.
3451         https://bugs.webkit.org/show_bug.cgi?id=174294
3452
3453         Reviewed by Dan Bernstein.
3454
3455         * Misc/WebKitVersionChecks.h:
3456
3457         * WebView/WebHTMLView.mm:
3458         (-[WebHTMLView hitTest:]):
3459
3460         * WebView/WebView.mm:
3461         (shouldRespectPriorityInCSSAttributeSetters):
3462         (-[WebView _commonInitializationWithFrameName:groupName:]):
3463         (-[WebView _preferencesChanged:]):
3464         (shouldTransformsAffectOverflow): Deleted.
3465         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
3466
3467 2017-07-08  Brady Eidson  <beidson@apple.com>
3468
3469         Remove some obsolete RuntimeApplicationChecks.
3470         https://bugs.webkit.org/show_bug.cgi?id=174293
3471
3472         Reviewed by Dan Bernstein.
3473
3474         * Misc/WebKitVersionChecks.h:
3475         * WebView/WebView.mm:
3476         (+[WebView enableWebThread]):
3477         (-[WebView _needsPreHTML5ParserQuirks]):
3478
3479 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
3480
3481         Drop NOSNIFF compile flag
3482         https://bugs.webkit.org/show_bug.cgi?id=174289
3483
3484         Reviewed by Michael Catanzaro.
3485
3486         * Configurations/FeatureDefines.xcconfig:
3487
3488 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3489
3490         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3491         https://bugs.webkit.org/show_bug.cgi?id=174150
3492
3493         Reviewed by Mark Lam.
3494
3495         * DOM/DOM.mm:
3496         (lookupElementClass):
3497
3498 2017-07-06  Brady Eidson  <beidson@apple.com>
3499
3500         Add logging to first attempt to use the WebIconDatabase class.
3501         https://bugs.webkit.org/show_bug.cgi?id=174190
3502
3503         Reviewed by Andy Estes.
3504
3505         * Misc/WebIconDatabase.mm:
3506         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
3507         * Misc/WebKitVersionChecks.h:
3508
3509 2017-07-06  Matt Lewis  <jlewis3@apple.com>
3510
3511         Unreviewed, rolling out r219178.
3512
3513         This caused a consistent failure with the API test
3514         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
3515
3516         Reverted changeset:
3517
3518         "[WTF] Clean up StringStatics.cpp by using
3519         LazyNeverDestroyed<> for Atoms"
3520         https://bugs.webkit.org/show_bug.cgi?id=174150
3521         http://trac.webkit.org/changeset/219178
3522
3523 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
3524
3525         [WTF] Move SoftLinking.h into WTF
3526         https://bugs.webkit.org/show_bug.cgi?id=174000
3527
3528         Reviewed by Alex Christensen.
3529
3530         * Plugins/WebNetscapePluginView.mm:
3531         * Plugins/WebPluginController.mm:
3532         * WebCoreSupport/WebInspectorClient.mm:
3533         * WebView/WebFullScreenController.mm:
3534         * WebView/WebImmediateActionController.mm:
3535         * WebView/WebView.mm:
3536
3537 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3538
3539         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
3540         https://bugs.webkit.org/show_bug.cgi?id=174150
3541
3542         Reviewed by Mark Lam.
3543
3544         * DOM/DOM.mm:
3545         (lookupElementClass):
3546
3547 2017-07-05  Brady Eidson  <beidson@apple.com>
3548
3549         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
3550         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
3551
3552         Reviewed by Alex Christensen.
3553
3554         Adopt to the new constructor for FrameLoadRequest.
3555
3556         * WebView/WebPDFView.mm:
3557         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3558
3559 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
3560
3561         Make WebKit's public headers on Mac and iOS C++ module safe
3562         https://bugs.webkit.org/show_bug.cgi?id=174175
3563
3564         Reviewed by Alex Christensen.
3565
3566         Fixed the header files.
3567
3568         * Misc/WebDownload.h:
3569         * Misc/WebKitErrors.h:
3570         * Plugins/WebPluginContainer.h:
3571         * WebView/WebResourceLoadDelegate.h:
3572
3573 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3574
3575         Remove copy of ICU headers from WebKit
3576         https://bugs.webkit.org/show_bug.cgi?id=116407
3577
3578         Reviewed by Alex Christensen.
3579
3580         Use WTF's copy of ICU headers.
3581
3582         * Configurations/WebKitLegacy.xcconfig:
3583         * icu/unicode/localpointer.h: Removed.
3584         * icu/unicode/parseerr.h: Removed.
3585         * icu/unicode/platform.h: Removed.
3586         * icu/unicode/ptypes.h: Removed.
3587         * icu/unicode/putil.h: Removed.
3588         * icu/unicode/uchar.h: Removed.
3589         * icu/unicode/uconfig.h: Removed.
3590         * icu/unicode/ucurr.h: Removed.
3591         * icu/unicode/uidna.h: Removed.
3592         * icu/unicode/uiter.h: Removed.
3593         * icu/unicode/umachine.h: Removed.
3594         * icu/unicode/unorm.h: Removed.
3595         * icu/unicode/unorm2.h: Removed.
3596         * icu/unicode/urename.h: Removed.
3597         * icu/unicode/uscript.h: Removed.
3598         * icu/unicode/ustring.h: Removed.
3599         * icu/unicode/utf.h: Removed.
3600         * icu/unicode/utf16.h: Removed.
3601         * icu/unicode/utf8.h: Removed.
3602         * icu/unicode/utf_old.h: Removed.
3603         * icu/unicode/utypes.h: Removed.
3604         * icu/unicode/uvernum.h: Removed.
3605         * icu/unicode/uversion.h: Removed.
3606
3607 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
3608
3609         Add WebKitPrivateFrameworkStubs for iOS 11
3610         https://bugs.webkit.org/show_bug.cgi?id=173988
3611
3612         Reviewed by David Kilzer.
3613
3614         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
3615         use the same directory for private framework stubs.
3616
3617 2017-07-03  Matt Lewis  <jlewis3@apple.com>
3618
3619         Unreviewed, rolling out r219103.
3620
3621         Caused multiple build failures.
3622
3623         Reverted changeset:
3624
3625         "Remove copy of ICU headers from WebKit"
3626         https://bugs.webkit.org/show_bug.cgi?id=116407
3627         http://trac.webkit.org/changeset/219103
3628
3629 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
3630
3631         Remove copy of ICU headers from WebKit
3632         https://bugs.webkit.org/show_bug.cgi?id=116407
3633
3634         Reviewed by Alex Christensen.
3635
3636         Use WTF's copy of ICU headers.
3637
3638         * Configurations/WebKitLegacy.xcconfig:
3639         * icu/unicode/localpointer.h: Removed.
3640         * icu/unicode/parseerr.h: Removed.
3641         * icu/unicode/platform.h: Removed.
3642         * icu/unicode/ptypes.h: Removed.
3643         * icu/unicode/putil.h: Removed.
3644         * icu/unicode/uchar.h: Removed.
3645         * icu/unicode/uconfig.h: Removed.
3646         * icu/unicode/ucurr.h: Removed.
3647         * icu/unicode/uidna.h: Removed.
3648         * icu/unicode/uiter.h: Removed.
3649         * icu/unicode/umachine.h: Removed.
3650         * icu/unicode/unorm.h: Removed.
3651         * icu/unicode/unorm2.h: Removed.
3652         * icu/unicode/urename.h: Removed.
3653         * icu/unicode/uscript.h: Removed.
3654         * icu/unicode/ustring.h: Removed.
3655         * icu/unicode/utf.h: Removed.
3656         * icu/unicode/utf16.h: Removed.
3657         * icu/unicode/utf8.h: Removed.
3658         * icu/unicode/utf_old.h: Removed.
3659         * icu/unicode/utypes.h: Removed.
3660         * icu/unicode/uvernum.h: Removed.
3661         * icu/unicode/uversion.h: Removed.
3662
3663 2017-07-03  Brady Eidson  <beidson@apple.com>
3664
3665         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
3666         https://bugs.webkit.org/show_bug.cgi?id=174073
3667
3668         Reviewed by Andy Estes.
3669
3670         WebView now keeps a direct copy of its main frame icon as a member variable.
3671         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
3672         
3673         This change causes a progression in KVO observation of the mainFrameIcon property as we now
3674         have both the old icon and new icon at the time it changes.
3675
3676         * WebCoreSupport/WebFrameLoaderClient.h:
3677         * WebCoreSupport/WebFrameLoaderClient.mm:
3678         (WebFrameLoaderClient::prepareForDataSourceReplacement):
3679         (WebFrameLoaderClient::getLoadDecisionForIcons):
3680         (WebFrameLoaderClient::finishedLoadingIcon):
3681         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
3682         (WebFrameLoaderClient::registerForIconNotification): Deleted.
3683
3684         * WebView/WebView.mm:
3685         (+[WebView _setIconLoadingEnabled:]):
3686         (+[WebView _isIconLoadingEnabled]):
3687         (-[WebView mainFrameIcon]):
3688         (-[WebView _setMainFrameIcon:]):
3689         (-[WebView _receivedIconChangedNotification:]): Deleted.
3690         (-[WebView _registerForIconNotification:]): Deleted.
3691         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
3692         * WebView/WebViewData.h:
3693         * WebView/WebViewInternal.h:
3694         * WebView/WebViewPrivate.h:
3695
3696 2017-07-03  Sam Weinig  <sam@webkit.org>
3697
3698         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
3699         https://bugs.webkit.org/show_bug.cgi?id=174083
3700
3701         Reviewed by Alex Christensen.
3702
3703         * Configurations/FeatureDefines.xcconfig:
3704         Add ENABLE_NAVIGATOR_STANDALONE.
3705
3706 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3707
3708         Expose unobscuredSafeAreaInsets on WebView
3709         https://bugs.webkit.org/show_bug.cgi?id=174075
3710         <rdar://problem/33096997>
3711
3712         Reviewed by Beth Dakin.
3713
3714         * WebView/WebView.mm:
3715         (-[WebView _setUnobscuredSafeAreaInsets:]):
3716         (-[WebView _unobscuredSafeAreaInsets]):
3717         * WebView/WebViewPrivate.h:
3718         Expose unobscuredSafeAreaInsets as a new private property on WebView,
3719         similar to how it is exposed in WebKit2.
3720
3721 2017-07-03  Andy Estes  <aestes@apple.com>
3722
3723         [Xcode] Add an experimental setting to build with ccache
3724         https://bugs.webkit.org/show_bug.cgi?id=173875
3725
3726         Reviewed by Tim Horton.
3727
3728         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
3729
3730 2017-07-03  Tim Horton  <timothy_horton@apple.com>
3731
3732         Expose WebPreferences for viewport-fit and constant() properties
3733         https://bugs.webkit.org/show_bug.cgi?id=174072
3734         <rdar://problem/33096639>
3735
3736         Reviewed by Ryosuke Niwa.
3737
3738         * WebView/WebPreferenceKeysPrivate.h:
3739         * WebView/WebPreferences.mm:
3740         (-[WebPreferences viewportFitEnabled]):
3741         (-[WebPreferences setViewportFitEnabled:]):
3742         (-[WebPreferences constantPropertiesEnabled]):
3743         (-[WebPreferences setConstantPropertiesEnabled:]):
3744         * WebView/WebPreferencesPrivate.h:
3745         * WebView/WebView.mm:
3746         (-[WebView _preferencesChanged:]):
3747
3748 2017-07-01  Tim Horton  <timothy_horton@apple.com>
3749
3750         Expose viewport-fit value to UIKit via viewport arguments dictionary
3751         https://bugs.webkit.org/show_bug.cgi?id=174071
3752         <rdar://problem/33096620>
3753
3754         Reviewed by Wenson Hsieh.
3755
3756         * History/WebHistoryItem.mm:
3757         * History/WebHistoryItemPrivate.h:
3758         Add another dictionary key and three values.
3759
3760 2017-07-01  Dan Bernstein  <mitz@apple.com>
3761
3762         [iOS] Remove code only needed when building for iOS 9.x
3763         https://bugs.webkit.org/show_bug.cgi?id=174068
3764
3765         Reviewed by Tim Horton.
3766
3767         * Configurations/FeatureDefines.xcconfig:
3768
3769 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
3770
3771         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
3772         https://bugs.webkit.org/show_bug.cgi?id=174004
3773
3774         Reviewed by Simon Fraser.
3775
3776         * WebCoreSupport/WebPluginInfoProvider.mm:
3777
3778 2017-07-01  Dan Bernstein  <mitz@apple.com>
3779
3780         [macOS] Remove code only needed when building for OS X Yosemite
3781         https://bugs.webkit.org/show_bug.cgi?id=174067
3782
3783         Reviewed by Tim Horton.
3784
3785         * Configurations/Base.xcconfig:
3786         * Configurations/DebugRelease.xcconfig:
3787         * Configurations/FeatureDefines.xcconfig:
3788         * Configurations/Version.xcconfig:
3789         * Plugins/WebBasePluginPackage.mm:
3790         (-[WebBasePluginPackage getPluginInfoFromPLists]):
3791         * WebCoreSupport/PopupMenuMac.mm:
3792         (PopupMenuMac::show):
3793         * WebCoreSupport/WebInspectorClient.mm:
3794         (WebInspectorFrontendClient::startWindowDrag):
3795         (-[WebInspectorWindowController window]):
3796         * WebView/WebView.mm:
3797         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
3798
3799 2017-06-30  Daniel Bates  <dabates@apple.com>
3800
3801         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
3802         https://bugs.webkit.org/show_bug.cgi?id=165160
3803         <rdar://problem/29451999>
3804
3805         Reviewed by Brady Eidson.
3806
3807         Pass the document that is requesting the load to the loader.
3808
3809         * WebView/WebPDFView.mm:
3810         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3811
3812 2017-06-29  Jer Noble  <jer.noble@apple.com>
3813
3814         Make Legacy EME API controlled by RuntimeEnabled setting.
3815         https://bugs.webkit.org/show_bug.cgi?id=173994
3816
3817         Reviewed by Sam Weinig.
3818
3819         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
3820
3821         * Configurations/FeatureDefines.xcconfig:
3822         * WebView/WebPreferenceKeysPrivate.h:
3823         * WebView/WebPreferences.mm:
3824         (+[WebPreferences initialize]):
3825         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
3826         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
3827         * WebView/WebPreferencesPrivate.h:
3828         * WebView/WebView.mm:
3829         (-[WebView _preferencesChanged:]):
3830
3831 2017-06-30  Chris Dumez  <cdumez@apple.com>
3832
3833         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
3834         https://bugs.webkit.org/show_bug.cgi?id=174013
3835
3836         Reviewed by Brent Fulgham.
3837
3838         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
3839         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
3840
3841         * WebView/WebView.mm:
3842         (-[WebView _commonInitializationWithFrameName:groupName:]):
3843
3844 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
3845
3846         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
3847         https://bugs.webkit.org/show_bug.cgi?id=174017
3848         <rdar://problem/32959782>
3849
3850         Reviewed by Simon Fraser.
3851
3852         Use root view coordinates when computing the drag caret rect.
3853
3854         * WebView/WebView.mm:
3855         (-[WebView _dataInteractionCaretRect]):
3856
3857 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
3858
3859         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
3860         https://bugs.webkit.org/show_bug.cgi?id=173899
3861         rdar://problem/32994474
3862
3863         Reviewed by Tim Horton.
3864
3865         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
3866         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
3867         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
3868
3869         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
3870         documentView is a WebHTMLView.
3871
3872         * WebView/WebFrame.mm:
3873         (-[WebFrame _webHTMLDocumentView]):
3874         (-[WebFrame _paintBehaviorForDestinationContext:]):
3875         (-[WebFrame _drawRect:contentsOnly:]):
3876         (-[WebFrame setTimeoutsPaused:]):
3877         (-[WebFrame prepareForPause]):
3878         (-[WebFrame resumeFromPause]):
3879         (-[WebFrame resetTextAutosizingBeforeLayout]):
3880         * WebView/WebHTMLView.mm:
3881         (-[WebHTMLView drawLayer:inContext:]):
3882         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
3883         * WebView/WebHTMLViewInternal.h:
3884
3885 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3886
3887         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
3888         https://bugs.webkit.org/show_bug.cgi?id=173854
3889         <rdar://problem/32236827>
3890
3891         Reviewed by Ryosuke Niwa and Tim Horton.
3892
3893         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
3894         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
3895
3896         * WebView/WebView.mm:
3897         (-[WebView _startDrag:]):
3898         (-[WebView _dragSourceAction]):
3899         (-[WebView _draggedLinkTitle]):
3900         (-[WebView _draggedLinkURL]):
3901         (-[WebView _draggedElementBounds]):
3902         (-[WebView _endedDataInteraction:global:]):
3903         * WebView/WebViewData.h:
3904         * WebView/WebViewPrivate.h:
3905
3906 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3907
3908         Refactor drag start codepaths to plumb a DragItem to client layers
3909         https://bugs.webkit.org/show_bug.cgi?id=173832
3910         Work towards <rdar://problem/32236827>
3911
3912         Reviewed by Ryosuke Niwa and Tim Horton.
3913
3914         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
3915         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
3916         to _startDrag: to match logic used to start a drag on other platforms.
3917
3918         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
3919         through the DragItem struct.
3920
3921         * WebCoreSupport/WebDragClient.h:
3922         * WebCoreSupport/WebDragClient.mm:
3923         (WebDragClient::startDrag):
3924         (WebDragClient::dragSourceActionMaskForPoint):
3925         (WebDragClient::willPerformDragSourceAction):
3926         (WebDragClient::beginDrag):
3927         * WebView/WebView.mm:
3928         (-[WebView _startDrag:]):
3929         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
3930         * WebView/WebViewInternal.h:
3931
3932 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
3933
3934         Remove excessive headers from JavaScriptCore
3935         https://bugs.webkit.org/show_bug.cgi?id=173812
3936
3937         Reviewed by Darin Adler.
3938
3939         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3940         * WebView/WebView.mm:
3941
3942 2017-06-23  Tim Horton  <timothy_horton@apple.com>
3943
3944         Remove an unused typedef from WebFrameLoaderClient
3945         https://bugs.webkit.org/show_bug.cgi?id=173795
3946
3947         Reviewed by Simon Fraser.
3948
3949         * WebCoreSupport/WebFrameLoaderClient.h:
3950         This unused typedef in the global namespace conflicts with one in a macOS system header.
3951         Also... it's unused.
3952         Remove it.
3953
3954 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
3955
3956         Remove excessive headers from WebCore/{bindings,css,dom}
3957         https://bugs.webkit.org/show_bug.cgi?id=173766
3958
3959         Reviewed by Simon Fraser.
3960
3961         * DOM/DOMInternal.mm:
3962
3963 2017-06-22  Daniel Bates  <dabates@apple.com>
3964
3965         Make FrameLoadRequest a move-only type
3966         https://bugs.webkit.org/show_bug.cgi?id=173682
3967
3968         Reviewed by Alex Christensen and Darin Adler.
3969
3970         A FrameLoadRequest groups together the information to perform a load into a single object
3971         that is more manageable to pass around than its constituent parts. Code that receives a
3972         FrameLoadRequest is expected to extract out the information it needs to complete its task.
3973         And it does not make sense to re-use the same FrameLoadRequest object for more than one
3974         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
3975
3976         * Plugins/WebPluginController.mm:
3977         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
3978         * WebView/WebPDFView.mm:
3979         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3980
3981 2017-06-21  Antoine Quint  <graouts@apple.com>
3982
3983         Ensure DRT always logs rAF suspension debugging code
3984         https://bugs.webkit.org/show_bug.cgi?id=173681
3985
3986         Reviewed by Tim "Mr. T" Horton.
3987
3988         * WebView/WebPreferenceKeysPrivate.h:
3989         * WebView/WebPreferences.mm:
3990         (+[WebPreferences initialize]):
3991         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
3992         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
3993         * WebView/WebPreferencesPrivate.h:
3994         * WebView/WebView.mm:
3995         (-[WebView _preferencesChanged:]):
3996
3997 2017-06-21  Daniel Bates  <dabates@apple.com>
3998
3999         Cleanup FrameLoadRequest
4000         https://bugs.webkit.org/show_bug.cgi?id=173564
4001         <rdar://problem/32903570>
4002
4003         Reviewed by Brent Fulgham.
4004
4005         * WebView/WebPDFView.mm:
4006         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
4007         into a local variable and use C++11 brace initialization syntax to make it easier to identify
4008         the arguments passed to FrameLoader::loadFrameRequest().
4009
4010 2017-06-21  Antoine Quint  <graouts@apple.com>
4011
4012         Add logging to identify when the Page suspends scripted animations
4013         https://bugs.webkit.org/show_bug.cgi?id=173626
4014
4015         Reviewed by Tim Horton.
4016
4017         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
4018         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
4019
4020         * WebView/WebPreferenceKeysPrivate.h:
4021         * WebView/WebPreferences.mm:
4022         (+[WebPreferences initialize]):
4023         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
4024         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
4025         * WebView/WebPreferencesPrivate.h:
4026         * WebView/WebView.mm:
4027         (-[WebView _preferencesChanged:]):
4028
4029 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
4030
4031         Disable font variations on macOS Sierra and iOS 10
4032         https://bugs.webkit.org/show_bug.cgi?id=173618
4033         <rdar://problem/32879164>
4034
4035         Reviewed by Jon Lee.
4036
4037         * Configurations/FeatureDefines.xcconfig:
4038
4039 2017-06-20  Daniel Bates  <dabates@apple.com>
4040
4041         Have FrameLoadRequest takes a Frame& instead of a Frame*
4042         https://bugs.webkit.org/show_bug.cgi?id=173614
4043         <rdar://problem/32884890>
4044
4045         Reviewed by Brent Fulgham.
4046
4047         * Plugins/WebPluginController.mm:
4048         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
4049         * WebView/WebFrame.mm:
4050         (-[WebFrame loadRequest:]):
4051         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
4052
4053 2017-06-19  Frederic Wang  <fwang@igalia.com>
4054
4055         [Mac] Add an experimental feature setting for async frame scrolling
4056         https://bugs.webkit.org/show_bug.cgi?id=173359
4057
4058         Reviewed by Simon Fraser.
4059
4060         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
4061         * WebView/WebPreferences.mm:
4062         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
4063         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
4064         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
4065         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
4066         * WebView/WebView.mm:
4067         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
4068         scrolling.
4069
4070 2017-06-19  Chris Dumez  <cdumez@apple.com>
4071
4072         Use WTF::Function instead of std::function in more places in WebCore/
4073         https://bugs.webkit.org/show_bug.cgi?id=173535
4074
4075         Reviewed by Antti Koivisto.
4076
4077         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
4078