Warn against cookie access in the WebContent process using ProcessPrivilege assertions
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2018-03-26  Brent Fulgham  <bfulgham@apple.com>
2
3         Warn against cookie access in the WebContent process using ProcessPrivilege assertions
4         https://bugs.webkit.org/show_bug.cgi?id=183911
5         <rdar://problem/38762306>
6
7         Reviewed by Youenn Fablet.
8
9         Initialize the ProcessPrivilege and Cookie API access levels for single-process use.
10
11         * WebView/WebView.mm:
12         (+[WebView initialize]):
13
14 2018-03-26  Alex Christensen  <achristensen@webkit.org>
15
16         Merge ResourceHandleClient::willCacheResponseAsync with ResourceHandleClient::willCacheResponse
17         https://bugs.webkit.org/show_bug.cgi?id=183965
18
19         Reviewed by Chris Dumez.
20
21         * WebCoreSupport/WebFrameLoaderClient.h:
22         * WebCoreSupport/WebFrameLoaderClient.mm:
23         (WebFrameLoaderClient::willCacheResponse const):
24
25 2018-03-25  Commit Queue  <commit-queue@webkit.org>
26
27         Unreviewed, rolling out r229954.
28         https://bugs.webkit.org/show_bug.cgi?id=184000
29
30         Caused many layout tests to crash on Apple High Sierra,
31         Sierra, iOS Simulator and GTK Linux Debug test bots (Requested
32         by dydz on #webkit).
33
34         Reverted changeset:
35
36         "Use SecurityOriginData more consistently in Service Worker
37         code"
38         https://bugs.webkit.org/show_bug.cgi?id=183969
39         https://trac.webkit.org/changeset/229954
40
41 2018-03-24  Chris Dumez  <cdumez@apple.com>
42
43         Use SecurityOriginData more consistently in Service Worker code
44         https://bugs.webkit.org/show_bug.cgi?id=183969
45
46         Reviewed by Darin Adler.
47
48         Use SecurityOrigin::data() instead of SecurityOriginData::fromSecurityOrigin().
49
50         * Storage/WebDatabaseManager.mm:
51         (-[WebDatabaseManager databasesWithOrigin:]):
52         (-[WebDatabaseManager deleteOrigin:]):
53         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
54         * Storage/WebDatabaseQuotaManager.mm:
55         (-[WebDatabaseQuotaManager usage]):
56         (-[WebDatabaseQuotaManager quota]):
57         (-[WebDatabaseQuotaManager setQuota:]):
58         * Storage/WebStorageManager.mm:
59         (-[WebStorageManager deleteOrigin:]):
60         * WebCoreSupport/WebSecurityOrigin.mm:
61         (-[WebSecurityOrigin databaseIdentifier]):
62         (-[WebSecurityOrigin usage]):
63         (-[WebSecurityOrigin quota]):
64         (-[WebSecurityOrigin setQuota:]):
65
66 2018-03-24  Timothy Horton  <timothy_horton@apple.com>
67
68         Fix the build
69
70         * WebView/WebView.mm:
71
72 2018-03-23  Tim Horton  <timothy_horton@apple.com>
73
74         Fix the build with no pasteboard
75         https://bugs.webkit.org/show_bug.cgi?id=183973
76
77         Reviewed by Dan Bernstein.
78
79         * Configurations/FeatureDefines.xcconfig:
80         * WebView/WebView.mm:
81         (-[WebView _requestStartDataInteraction:globalPosition:]):
82         (-[WebView _getDataInteractionData]):
83         (-[WebView _dataOperationTextIndicator]):
84         (-[WebView _dragSourceAction]):
85         (-[WebView _draggedLinkTitle]):
86         (-[WebView _draggedLinkURL]):
87         (-[WebView _draggedElementBounds]):
88         (-[WebView _enteredDataInteraction:client:global:operation:]):
89         (-[WebView _updatedDataInteraction:client:global:operation:]):
90         (-[WebView _exitedDataInteraction:client:global:operation:]):
91         (-[WebView _performDataInteraction:client:global:operation:]):
92         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
93         (-[WebView _endedDataInteraction:global:]):
94         (-[WebView _dataInteractionCaretRect]):
95         * WebView/WebViewPrivate.h:
96
97 2018-03-23  Tim Horton  <timothy_horton@apple.com>
98
99         Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebKitLegacy and update install name
100         https://bugs.webkit.org/show_bug.cgi?id=183960
101         <rdar://problem/38812356>
102
103         Reviewed by Dan Bernstein.
104
105         * Configurations/WebKitLegacy.xcconfig:
106
107 2018-03-23  Tim Horton  <timothy_horton@apple.com>
108
109         Introduce and adopt HAVE(AUDIO_TOOLBOX_AUDIO_SESSION)
110         https://bugs.webkit.org/show_bug.cgi?id=183954
111         <rdar://problem/38808858>
112
113         Reviewed by Dan Bernstein.
114
115         * WebView/WebPreferences.mm:
116         (-[WebPreferences setAudioSessionCategoryOverride:]):
117
118 2018-03-23  Tim Horton  <timothy_horton@apple.com>
119
120         Adopt WK_PLATFORM_NAME in WebKitLegacy
121         https://bugs.webkit.org/show_bug.cgi?id=183948
122         <rdar://problem/38803908>
123
124         Reviewed by Dan Bernstein.
125
126         * Configurations/WebKitLegacy.xcconfig:
127         * MigrateHeaders.make:
128         * postprocess-headers.sh:
129
130 2018-03-23  Brady Eidson  <beidson@apple.com>
131
132         Go to back/forward list items after a process-swapped navigation.
133         <rdar://problem/38690544> and https://bugs.webkit.org/show_bug.cgi?id=183920
134
135         Reviewed by Andy Estes.
136
137         * WebView/WebView.mm:
138         (-[WebView _loadBackForwardListFromOtherView:]):
139         (-[WebView goToBackForwardItem:]):
140
141 2018-03-22  Tim Horton  <timothy_horton@apple.com>
142
143         Improve readability of WebCore's OTHER_LDFLAGS
144         https://bugs.webkit.org/show_bug.cgi?id=183909
145         <rdar://problem/38760992>
146
147         Reviewed by Dan Bernstein.
148
149         * Configurations/Base.xcconfig:
150         * Configurations/FeatureDefines.xcconfig:
151
152 2018-03-20  Tim Horton  <timothy_horton@apple.com>
153
154         Enable the minimal simulator feature flag when appropriate
155         https://bugs.webkit.org/show_bug.cgi?id=183807
156
157         Reviewed by Dan Bernstein.
158
159         * Configurations/FeatureDefines.xcconfig:
160
161 2018-03-20  Tim Horton  <timothy_horton@apple.com>
162
163         Add and adopt WK_PLATFORM_NAME and adjust default feature defines
164         https://bugs.webkit.org/show_bug.cgi?id=183758
165         <rdar://problem/38017644>
166
167         Reviewed by Dan Bernstein.
168
169         * Configurations/FeatureDefines.xcconfig:
170
171 2018-03-19  Megan Gardner  <megan_gardner@apple.com>
172
173         Clear style colors when setting default appearance
174         https://bugs.webkit.org/show_bug.cgi?id=183759
175
176         Reviewed by Tim Horton.
177
178         Colors are cached and need to be cleared and recalculated.
179         Refactor to do all style recalcs together.
180
181         * WebView/WebView.mm:
182         (-[WebView _setDefaultAppearanceAndClearStyle]):
183         (-[WebView _setUseSystemAppearance:]):
184         (-[WebView effectiveAppearanceDidChange]):
185
186 2018-03-19  Jiewen Tan  <jiewen_tan@apple.com>
187
188         Unreviewed, another quick fix for r229699
189
190         Restricts ENABLE_WEB_AUTHN to only macOS and iOS.
191
192         * Configurations/FeatureDefines.xcconfig:
193
194 2018-03-16  Megan Gardner  <megan_gardner@apple.com>
195
196         Ensure that style is updated when the effective appearance changes
197         https://bugs.webkit.org/show_bug.cgi?id=183690
198         <rdar://problem/38385900>
199
200         Reviewed by Tim Horton and Wenson Hsieh.
201
202         Respond to and respect the effective appearance changing.
203
204         * WebView/WebView.mm:
205         (-[WebView _setUseSystemAppearance:]):
206         (-[WebView effectiveAppearanceDidChange]):
207
208 2018-03-15  Megan Gardner  <megan_gardner@apple.com>
209
210         Create MediaQueryParserContext to provide additional context for the evaluation of media queries
211         https://bugs.webkit.org/show_bug.cgi?id=183677
212
213         Reviewed by Tim Horton.
214
215         We need additional context for parsing media queries to make sure they are parsed correctly and valid.
216
217         * DOM/DOM.mm:
218         (-[DOMHTMLLinkElement _mediaQueryMatches]):
219
220 2018-03-14  Tim Horton  <timothy_horton@apple.com>
221
222         Fix the build after r229567
223
224         * Configurations/FeatureDefines.xcconfig:
225
226 2018-03-12  Tim Horton  <timothy_horton@apple.com>
227
228         Stop using SDK conditionals to control feature definitions
229         https://bugs.webkit.org/show_bug.cgi?id=183430
230         <rdar://problem/38251619>
231
232         Reviewed by Dan Bernstein.
233
234         * Configurations/FeatureDefines.xcconfig:
235         * Configurations/WebKitTargetConditionals.xcconfig: Renamed.
236
237 2018-03-12  Yoav Weiss  <yoav@yoav.ws>
238
239         Runtime flag for link prefetch and remove link subresource.
240         https://bugs.webkit.org/show_bug.cgi?id=183540
241
242         Reviewed by Chris Dumez.
243
244         Remove the LINK_PREFETCH build time flag.
245
246         * Configurations/FeatureDefines.xcconfig:
247
248 2018-03-12  Javier Fernandez  <jfernandez@igalia.com>
249
250         Remove GridLayout runtime flag
251         https://bugs.webkit.org/show_bug.cgi?id=183484
252
253         Reviewed by Myles C. Maxfield.
254
255         The Grid Layout feature has been enabled by default for almost a
256         year, so I think it's time to remove the runtime flag and the
257
258         * WebView/WebPreferenceKeysPrivate.h:
259         * WebView/WebPreferences.mm:
260         (+[WebPreferences initialize]):
261         * WebView/WebPreferencesPrivate.h:
262         * WebView/WebView.mm:
263         (-[WebView _preferencesChanged:]):
264
265 2018-03-12  Antoine Quint  <graouts@apple.com>
266
267         [Web Animations] Implement CSS Animations and CSS Transitions as Web Animations
268         https://bugs.webkit.org/show_bug.cgi?id=183504
269         <rdar://problem/38372965>
270
271         Reviewed by Dean Jackson and Jon Lee.
272
273         Add the missing WebKitLegacy support the cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled flag
274         which is required for the matching <!-- webkit-test-runner --> flag to work in DumpRenderTree.
275
276         * WebView/WebPreferenceKeysPrivate.h:
277         * WebView/WebPreferences.mm:
278         (+[WebPreferences initialize]):
279         (-[WebPreferences setModernMediaControlsEnabled:]):
280         (-[WebPreferences cssAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled]):
281         (-[WebPreferences setCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled:]):
282         * WebView/WebPreferencesPrivate.h:
283         * WebView/WebView.mm:
284         (-[WebView _preferencesChanged:]):
285
286 2018-03-10  Megan Gardner  <megan_gardner@apple.com>
287
288         Media query for default appearance
289         https://bugs.webkit.org/show_bug.cgi?id=183539
290         <rdar://problem/38326388>
291
292         Reviewed by Tim Horton.
293
294         Write a media query to evaluate appearance.
295
296         * WebView/WebView.mm:
297         (-[WebView _commonInitializationWithFrameName:groupName:]):
298         (-[WebView _setUseSystemAppearance:]):
299
300 2018-03-09  Andy Estes  <aestes@apple.com>
301
302         [Mac] WebKit fails to receive file promises when the embedding app is sandboxed
303         https://bugs.webkit.org/show_bug.cgi?id=183489
304         <rdar://problem/38267517>
305
306         WebKitLegacy calls -[NSFilePromiseReceiver receivePromisedFilesAtDestination:...] with
307         NSTemporaryDirectory() as the destination for receiving file promise drops. AppKit attempts
308         to issue a sandbox extension for this directory, but for security reasons App Sandbox
309         refuses to do so for NSTemporaryDirectory() itself. As a result, AppKit will call our reader
310         block with a nil error and a valid file URL, but no file will actually exist at that URL.
311
312         In order for App Sandbox to grant issuing the sandbox extension needed by AppKit, we need to
313         use some other destination directory. This patch uses FileSystem::createTemporaryDirectory()
314         to securely create a unique temporary directory inside NSTemporaryDirectory() for use as the
315         drop destination.
316
317         Reviewed by Wenson Hsieh.
318
319         * WebView/WebView.mm:
320         (-[WebView performDragOperation:]):
321
322 2018-03-08  Megan Gardner  <megan_gardner@apple.com>
323
324         Allow WebViews to disable system appearance
325         https://bugs.webkit.org/show_bug.cgi?id=183418
326         <rdar://problem/36975642>
327
328         Reviewed by Tim Horton.
329
330         Allow webviews to choose whether or not to follow the default system appearance.
331
332         * WebView/WebView.mm:
333         (-[WebView _setUseSystemAppearance:]):
334         (-[WebView _useSystemAppearance]):
335         * WebView/WebViewPrivate.h:
336
337 2018-03-08  Youenn Fablet  <youenn@apple.com>
338
339         libwebrtc update broke internal builds
340         https://bugs.webkit.org/show_bug.cgi?id=183454
341
342         Reviewed by Eric Carlson.
343
344         * Configurations/WebKitLegacy.xcconfig:
345
346 2018-03-08  Chris Dumez  <cdumez@apple.com>
347
348         Possible null dereference of the page under WebFrameNetworkingContext::storageSession()
349         https://bugs.webkit.org/show_bug.cgi?id=183455
350         <rdar://problem/38191749>
351
352         Reviewed by Youenn Fablet.
353
354         Add a null check for the page as we have evidence from crashes that it can be null.
355         Other functions in WebFrameNetworkingContext already null check the page as well,
356         not just the frame so this is consistent.
357
358         * WebCoreSupport/WebFrameNetworkingContext.mm:
359         (WebFrameNetworkingContext::storageSession const):
360
361 2018-03-08  Yusuke Suzuki  <utatane.tea@gmail.com>
362
363         [JSC] Add inherits<T>(VM&) leveraging JSCast fast path
364         https://bugs.webkit.org/show_bug.cgi?id=183429
365
366         Reviewed by Mark Lam.
367
368         * DOM/DOM.mm:
369         (+[DOMNode _nodeFromJSWrapper:]):
370         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
371         (WebKit::NetscapePluginInstanceProxy::retainLocalObject):
372         (WebKit::NetscapePluginInstanceProxy::releaseLocalObject):
373         * Plugins/Hosted/ProxyInstance.mm:
374         (WebKit::ProxyInstance::invokeMethod):
375         * WebView/WebView.mm:
376         (aeDescFromJSValue):
377
378 2018-03-08  Tim Horton  <timothy_horton@apple.com>
379
380         Stop linking ApplicationServices directly
381         https://bugs.webkit.org/show_bug.cgi?id=182867
382         <rdar://problem/38252142>
383
384         Reviewed by Alex Christensen.
385
386         The frameworks that we use that live inside ApplicationServices
387         have mostly moved out, so import them directly.
388
389         * Carbon/CarbonUtils.h:
390         * WebKitPrefix.h:
391         * WebView/WebHTMLView.mm:
392         * WebView/WebPDFView.mm:
393
394 2018-03-07  Tim Horton  <timothy_horton@apple.com>
395
396         Sort and separate FeatureDefines.xcconfig
397         https://bugs.webkit.org/show_bug.cgi?id=183427
398
399         Reviewed by Dan Bernstein.
400
401         * Configurations/FeatureDefines.xcconfig:
402         Sort and split FeatureDefines into paragraphs
403         (to make it easier to sort later).
404
405 2018-03-07  Youenn Fablet  <youenn@apple.com>
406
407         Match unsupported plugins based on domains and not origin
408         https://bugs.webkit.org/show_bug.cgi?id=183384
409
410         Reviewed by Chris Dumez.
411
412         * WebCoreSupport/WebPluginInfoProvider.h:
413         * WebCoreSupport/WebPluginInfoProvider.mm:
414         (WebPluginInfoProvider::getPluginInfo):
415         (WebPluginInfoProvider::getWebVisiblePluginInfo):
416
417 2018-03-05  Andy Estes  <aestes@apple.com>
418
419         [Mac] Teach WebCore::Pasteboard about file promise drags
420         https://bugs.webkit.org/show_bug.cgi?id=183314
421         <rdar://problem/38105493>
422
423         Reviewed by Darin Adler.
424
425         Added a FIXME comment.
426
427         * WebView/WebView.mm:
428         (-[WebView performDragOperation:]):
429
430 2018-03-04  Yusuke Suzuki  <utatane.tea@gmail.com>
431
432         [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
433         https://bugs.webkit.org/show_bug.cgi?id=183312
434
435         Reviewed by Mark Lam.
436
437         Remove wtf/CurrentTime.h include pragma.
438
439         * WebView/WebFrame.mm:
440         * WebView/WebPDFView.mm:
441
442 2018-03-04  Tim Horton  <timothy_horton@apple.com>
443
444         Make !ENABLE(DATA_DETECTION) iOS build actually succeed
445         https://bugs.webkit.org/show_bug.cgi?id=183283
446         <rdar://problem/38062148>
447
448         Reviewed by Sam Weinig.
449
450         * Configurations/FeatureDefines.xcconfig:
451
452 2018-02-28  Alex Christensen  <achristensen@webkit.org>
453
454         Reduce use of NetworkingContext in WebKit
455         https://bugs.webkit.org/show_bug.cgi?id=183213
456
457         Reviewed by Brady Eidson.
458
459         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
460         (WebKit::NetscapePluginInstanceProxy::getProxy):
461         * Plugins/WebNetscapePluginView.mm:
462         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
463
464 2018-02-17  Darin Adler  <darin@apple.com>
465
466         Prepare for ExtendedColor changes (first step)
467         https://bugs.webkit.org/show_bug.cgi?id=182904
468
469         Reviewed by Sam Weinig.
470
471         * Misc/WebKitNSStringExtras.mm:
472         (-[NSString _web_drawAtPoint:font:textColor:]): Use colorFromNSColor.
473
474 2018-02-22  Yusuke Suzuki  <utatane.tea@gmail.com>
475
476         Remove currentTime() / currentTimeMS()
477         https://bugs.webkit.org/show_bug.cgi?id=183052
478
479         Reviewed by Mark Lam.
480
481         * WebCoreSupport/WebFrameLoaderClient.h:
482         * WebCoreSupport/WebFrameLoaderClient.mm:
483         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
484
485 2018-02-16  Youenn Fablet  <youenn@apple.com>
486
487         Allow specifying which plug-ins are supported
488         https://bugs.webkit.org/show_bug.cgi?id=182748
489
490         Reviewed by Chris Dumez.
491
492         * WebCoreSupport/WebPluginInfoProvider.h:
493         * WebCoreSupport/WebPluginInfoProvider.mm:
494         (WebPluginInfoProvider::getPluginInfo):
495         (WebPluginInfoProvider::getWebVisiblePluginInfo):
496
497 2018-02-16  Brent Fulgham  <bfulgham@apple.com>
498
499         [Cocoa][WebKitLegacy] REGRESSION(r221559): Coda 2 crashes when switching views
500         https://bugs.webkit.org/show_bug.cgi?id=182882
501         <rdar://problem/35672661>
502
503         Reviewed by Dan Bernstein.
504
505         Make sure the smart pointer hold the collection of subviews lives at least as
506         long as the loop using it.
507
508         * WebView/WebHTMLView.mm:
509         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
510
511 2018-02-14  Daniel Bates  <dabates@apple.com>
512
513         Disallow cross-origin subresources from asking for credentials
514         https://bugs.webkit.org/show_bug.cgi?id=182579
515         <rdar://problem/36162271>
516
517         Reviewed by Andy Estes.
518
519         Add a private preference to toggle allowing non-mixed content cross-origin subresources to load.
520         DumpRenderTree toggles this preference when it sees the test option allowCrossOriginSubresourcesToAskForCredential.
521
522         * WebView/WebPreferenceKeysPrivate.h:
523         * WebView/WebPreferences.mm:
524         (+[WebPreferences initialize]):
525         (-[WebPreferences allowCrossOriginSubresourcesToAskForCredentials]):
526         (-[WebPreferences setAllowCrossOriginSubresourcesToAskForCredentials:]):
527         * WebView/WebPreferencesPrivate.h:
528         * WebView/WebView.mm:
529         (-[WebView _preferencesChanged:]):
530
531 2018-02-14  Ross Kirsling  <ross.kirsling@sony.com>
532
533         Remove ForwardingHeaders directory from WebKitLegacy/mac.
534         https://bugs.webkit.org/show_bug.cgi?id=182738
535
536         Reviewed by Darin Adler.
537
538         * ForwardingHeaders/collector/handles/Global.h: Removed.
539         * ForwardingHeaders/debugger/DebuggerCallFrame.h: Removed.
540         * ForwardingHeaders/runtime/Completion.h: Removed.
541         * ForwardingHeaders/runtime/Error.h: Removed.
542         * ForwardingHeaders/runtime/JSCJSValue.h: Removed.
543         * ForwardingHeaders/runtime/JSFunction.h: Removed.
544         * ForwardingHeaders/runtime/JSLock.h: Removed.
545         * ForwardingHeaders/runtime/JSObject.h: Removed.
546         * ForwardingHeaders/runtime/JSString.h: Removed.
547         * ForwardingHeaders/runtime/Protect.h: Removed.
548         * ForwardingHeaders/runtime/SymbolTable.h: Removed.
549
550 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
551
552         Follow-up fixes after moving WebVideoFullscreenController from WebCore to WebKitLegacy.
553         https://bugs.webkit.org/show_bug.cgi?id=182641
554
555         Reviewed by Dan Bernstein.
556
557         Remove incorrect use of WEBCORE_EXPORT and namespace WebCore after the files were moved in
558         https://trac.webkit.org/changeset/228308.
559
560         * WebView/WebVideoFullscreenController.h:
561         * WebView/WebVideoFullscreenHUDWindowController.mm:
562         * WebView/WebWindowAnimation.h:
563         * WebView/WebWindowAnimation.mm:
564         (WebCore::WebWindowAnimationDurationFromDuration): Deleted.
565         (WebCore::scaledRect): Deleted.
566         (WebCore::squaredDistance): Deleted.
567
568 2018-02-09  Per Arne Vollan  <pvollan@apple.com>
569
570         Unreviewed 32-bit build fix after <https://trac.webkit.org/changeset/228308>.
571
572         * WebView/WebWindowAnimation.mm:
573         (-[WebWindowScaleAnimation additionalDurationNeededToReachFinalFrame]):
574
575 2018-02-08  Per Arne Vollan  <pvollan@apple.com>
576
577         Move WebVideoFullscreenController from WebCore to WebKitLegacy.
578         https://bugs.webkit.org/show_bug.cgi?id=182615
579
580         Reviewed by Eric Carlson.
581
582         It is only used by WK1. Also there are a few references to NSApp in WebVideoFullscreenController.mm.
583         Ideally, we should not reference NSApp in WebCore.
584
585         * WebView/WebFullScreenController.mm:
586         * WebView/WebVideoFullscreenController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.h.
587         * WebView/WebVideoFullscreenController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenController.mm.
588         * WebView/WebVideoFullscreenHUDWindowController.h: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h.
589         * WebView/WebVideoFullscreenHUDWindowController.mm: Copied from Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm.
590         * WebView/WebView.mm:
591         * WebView/WebWindowAnimation.h: Copied from Source/WebCore/platform/mac/WebWindowAnimation.h.
592         * WebView/WebWindowAnimation.mm: Copied from Source/WebCore/platform/mac/WebWindowAnimation.mm.
593
594 2018-01-13  Darin Adler  <darin@apple.com>
595
596         Event improvements
597         https://bugs.webkit.org/show_bug.cgi?id=179591
598
599         Reviewed by Chris Dumez.
600
601         * DOM/DOMWheelEvent.mm:
602         (-[DOMWheelEvent initWheelEvent:wheelDeltaY:view:screenX:screenY:clientX:clientY:ctrlKey:altKey:shiftKey:metaKey:]):
603         Call initWebKitWheelEvent.
604
605         * Plugins/Hosted/NetscapePluginInstanceProxy.mm: Removed include of ScriptValue.h.
606         * WebCoreSupport/WebInspectorClient.mm: Ditto.
607         * WebView/WebFrame.mm: Ditto.
608
609         * WebView/WebHTMLView.mm:
610         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Updated for name change from keyEvent to
611         underlyingPlatformEvent.
612         (-[WebHTMLView _handleEditingKeyEvent:]): Ditto.
613
614         * WebView/WebScriptWorld.mm:
615         (+[WebScriptWorld scriptWorldForGlobalContext:]): Pass reference to currentWorld function.
616
617         * WebView/WebView.mm: Removed include of ScriptValue.h.
618
619 2018-02-06  Don Olmstead  <don.olmstead@sony.com>
620
621         Remove WebCore/ForwardingHeaders directory
622         https://bugs.webkit.org/show_bug.cgi?id=182347
623
624         Reviewed by Keith Miller.
625
626         * Carbon/CarbonWindowAdapter.mm:
627         * DOM/WebDOMOperations.mm:
628         * History/WebBackForwardList.mm:
629         * History/WebHistoryItem.mm:
630         * Misc/WebCache.mm:
631         * Misc/WebElementDictionary.mm:
632         * Misc/WebIconDatabase.mm:
633         * Misc/WebStringTruncator.mm:
634         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
635         * Plugins/Hosted/ProxyInstance.mm:
636         * Plugins/Hosted/ProxyRuntimeObject.mm:
637         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
638         * Plugins/WebBaseNetscapePluginView.mm:
639         * Plugins/WebBasePluginPackage.mm:
640         * Plugins/WebNetscapePluginStream.mm:
641         * Plugins/WebNetscapePluginView.mm:
642         * Plugins/WebPluginController.mm:
643         * WebCoreSupport/WebEditorClient.mm:
644         * WebCoreSupport/WebFrameLoaderClient.mm:
645         * WebCoreSupport/WebInspectorClient.h:
646         * WebCoreSupport/WebInspectorClient.mm:
647         * WebView/WebDataSource.mm:
648         * WebView/WebFrame.mm:
649         * WebView/WebHTMLRepresentation.mm:
650         * WebView/WebHTMLView.mm:
651         * WebView/WebPreferences.mm:
652         * WebView/WebScriptDebugDelegate.mm:
653         * WebView/WebScriptDebugger.h:
654         * WebView/WebTextIterator.mm:
655         * WebView/WebView.mm:
656         * WebView/WebViewData.mm:
657
658 2018-01-30  Don Olmstead  <don.olmstead@sony.com>
659
660         JSExports.h should be included as <JavaScriptCore/JSExportMacros.h>
661         https://bugs.webkit.org/show_bug.cgi?id=182312
662
663         Reviewed by Michael Catanzaro.
664
665         * WebKitPrefix.h:
666
667 2018-01-29  Jiewen Tan  <jiewen_tan@apple.com>
668
669         [WebAuthN] Add a compile-time feature flag
670         https://bugs.webkit.org/show_bug.cgi?id=182211
671         <rdar://problem/36936365>
672
673         Reviewed by Brent Fulgham.
674
675         * Configurations/FeatureDefines.xcconfig:
676
677 2018-01-27  Dan Bernstein  <mitz@apple.com>
678
679         HaveInternalSDK includes should be "#include?"
680         https://bugs.webkit.org/show_bug.cgi?id=179670
681
682         * Configurations/Base.xcconfig:
683
684 2018-01-24  Alex Christensen  <achristensen@webkit.org>
685
686         Remove unused QTKit preference
687         https://bugs.webkit.org/show_bug.cgi?id=181968
688
689         Reviewed by Alexey Proskuryakov.
690
691         * WebView/WebPreferenceKeysPrivate.h:
692         * WebView/WebPreferences.mm:
693         (+[WebPreferences initialize]):
694         (-[WebPreferences setQTKitEnabled:]): Deleted.
695         (-[WebPreferences isQTKitEnabled]): Deleted.
696         * WebView/WebPreferencesPrivate.h:
697         * WebView/WebView.mm:
698         (-[WebView _preferencesChanged:]):
699
700 2018-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
701
702         Harden against layout passes triggered when iterating through HTMLFormElement::associatedElements
703         https://bugs.webkit.org/show_bug.cgi?id=182037
704         <rdar://problem/36747812>
705
706         Reviewed by Ryosuke Niwa.
707
708         Rename associatedElements() to unsafeAssociatedElements(), and add ScriptDisallowedScopes. See WebCore ChangeLog
709         for more details.
710
711         * WebView/WebHTMLRepresentation.mm:
712         (-[WebHTMLRepresentation elementWithName:inForm:]):
713         (-[WebHTMLRepresentation controlsInForm:]):
714
715 2018-01-23  Alex Christensen  <achristensen@webkit.org>
716
717         Use CompletionHandlers for ResourceHandleClient::didReceiveResponseAsync
718         https://bugs.webkit.org/show_bug.cgi?id=181961
719
720         Reviewed by Michael Catanzaro.
721
722         * WebView/WebPreferences.mm:
723
724 2018-01-23  Commit Queue  <commit-queue@webkit.org>
725
726         Unreviewed, rolling out r227437.
727         https://bugs.webkit.org/show_bug.cgi?id=182011
728
729         broke build (Requested by alexchristensen on #webkit).
730
731         Reverted changeset:
732
733         "Remove unused QTKit preference"
734         https://bugs.webkit.org/show_bug.cgi?id=181968
735         https://trac.webkit.org/changeset/227437
736
737 2018-01-23  Alex Christensen  <achristensen@webkit.org>
738
739         Remove unused QTKit preference
740         https://bugs.webkit.org/show_bug.cgi?id=181968
741
742         Reviewed by Alexey Proskuryakov.
743
744         * WebView/WebPreferenceKeysPrivate.h:
745         * WebView/WebPreferences.mm:
746         (+[WebPreferences initialize]):
747         (-[WebPreferences setQTKitEnabled:]): Deleted.
748         (-[WebPreferences isQTKitEnabled]): Deleted.
749         * WebView/WebPreferencesPrivate.h:
750         * WebView/WebView.mm:
751         (-[WebView _preferencesChanged:]):
752
753 2018-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
754
755         WebViews created via -initSimpleHTMLDocumentWithStyle: don't propagate attachmentElementEnabled state
756         https://bugs.webkit.org/show_bug.cgi?id=181960
757         <rdar://problem/36431678>
758
759         Reviewed by Tim Horton.
760
761         Mail's compose view is initialized via the -initSimpleHTMLDocumentWithStyle: codepath. This is intended to be
762         a fast path for initializing WebViews, which bypasses certain initialization steps present in the regular -init
763         path, such as calling -_preferencesChanged: to sync RuntimeEnabledFeatures with WebPreferences.
764
765         This means that even though we set -[WebPreferences attachmentElementEnabled] to YES for Mail, the value of the
766         RuntimeEnabledFeature isn't updated to match. To fix this, we explicitly invoke
767         RuntimeEnabledFeatures::setAttachmentElementEnabled here to make sure the value is in sync with WebPreferences.
768
769         * WebView/WebView.mm:
770         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
771
772 2018-01-21  Ryosuke Niwa  <rniwa@webkit.org>
773
774         Turning off custom pasteboard data doesn't actually turn it off in WK2
775         https://bugs.webkit.org/show_bug.cgi?id=181920
776         <rdar://problem/36686429>
777
778         Reviewed by Wenson Hsieh.
779
780         Always disable custom pasteboard data in WebKit1. See r226156 for details.
781
782         * WebView/WebPreferences.mm:
783         (+[WebPreferences initialize]):
784         * WebView/WebView.mm:
785         (-[WebView _preferencesChanged:]):
786
787 2018-01-21  Wenson Hsieh  <wenson_hsieh@apple.com>
788
789         Add a new feature flag for EXTRA_ZOOM_MODE and reintroduce AdditionalFeatureDefines.h
790         https://bugs.webkit.org/show_bug.cgi?id=181918
791
792         Reviewed by Tim Horton.
793
794         Add EXTRA_ZOOM_MODE to FeatureDefines.xconfig (off by default).
795
796         * Configurations/FeatureDefines.xcconfig:
797
798 2018-01-20  Andy Estes  <aestes@apple.com>
799
800         [Apple Pay] Stop eagerly loading PassKit.framework
801         https://bugs.webkit.org/show_bug.cgi?id=181911
802         <rdar://problem/36555369>
803
804         Reviewed by Tim Horton.
805
806         * WebCoreSupport/WebPaymentCoordinatorClient.h:
807         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
808         (WebPaymentCoordinatorClient::validatedPaymentNetwork):
809
810         Implemented PaymentCoordinatorClient::validatedPaymentNetwork().
811
812 2018-01-19  Dean Jackson  <dino@apple.com>
813
814         REGRESSION (r221092): Swipe actions are hard to perform in FastMail app
815         https://bugs.webkit.org/show_bug.cgi?id=181817
816         <rdar://problem/35274055>
817
818         Reviewed by Simon Fraser.
819
820         Add a linked-on-or-after check to set passive touch listeners on document in WebCore.
821
822         * Misc/WebKitVersionChecks.h:
823         * WebView/WebView.mm:
824         (-[WebView _commonInitializationWithFrameName:groupName:]):
825
826 2018-01-19  Alex Christensen  <achristensen@webkit.org>
827
828         Remove unused WebViewPrivate _allowCookies
829         https://bugs.webkit.org/show_bug.cgi?id=181812
830
831         Reviewed by Tim Horton.
832
833         * WebView/WebView.mm:
834         (+[WebView _setAllowCookies:]): Deleted.
835         (+[WebView _allowCookies]): Deleted.
836         * WebView/WebViewPrivate.h:
837
838 2018-01-18  Alexey Proskuryakov  <ap@apple.com>
839
840         Build fix, remove a call to -[NSWindow setOneShot:]
841         https://bugs.webkit.org/show_bug.cgi?id=181809
842
843         Reviewed by Tim Horton.
844
845         * WebView/WebTextCompletionController.mm:
846         (-[WebTextCompletionController _buildUI]):
847
848 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
849
850         Unreviewed, suppress deprecation warnings to fix the build with a newer SDK.
851
852         * Carbon/HIWebView.mm:
853         (overrideCGContext):
854         (restoreCGContext):
855
856 2018-01-18  Dan Bernstein  <mitz@apple.com>
857
858         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
859         https://bugs.webkit.org/show_bug.cgi?id=181803
860
861         Reviewed by Tim Horton.
862
863         * Configurations/Base.xcconfig: Updated.
864         * Configurations/DebugRelease.xcconfig: Ditto.
865         * Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals helpers.
866         * Configurations/Version.xcconfig: Updated.
867         * Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build settings
868           useful for defining settings that depend on the target macOS version.
869
870 2018-01-17  Youenn Fablet  <youenn@apple.com>
871
872         Put fetch Request.keepalive behind a runtime flag
873         https://bugs.webkit.org/show_bug.cgi?id=181592
874
875         Reviewed by Chris Dumez.
876
877         * WebView/WebPreferenceKeysPrivate.h:
878         * WebView/WebPreferences.mm:
879         (+[WebPreferences initialize]):
880         (-[WebPreferences fetchAPIKeepAliveEnabled]):
881         (-[WebPreferences setFetchAPIKeepAliveEnabled:]):
882         * WebView/WebPreferencesPrivate.h:
883         * WebView/WebView.mm:
884         (-[WebView _preferencesChanged:]):
885
886 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
887
888         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
889         https://bugs.webkit.org/show_bug.cgi?id=181637
890         <rdar://problem/36508471>
891
892         Reviewed by Tim Horton.
893
894         Add a stub implementation of replacementURLForResource. See WebCore and WebKit ChangeLogs for more detail.
895
896         * WebCoreSupport/WebEditorClient.h:
897         * WebCoreSupport/WebEditorClient.mm:
898         (WebEditorClient::replacementURLForResource):
899
900 2018-01-11  Keith Miller  <keith_miller@apple.com>
901
902         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
903         https://bugs.webkit.org/show_bug.cgi?id=181573
904
905         Reviewed by Simon Fraser.
906
907         * Configurations/FeatureDefines.xcconfig:
908
909 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
910
911         Send PromisedBlobInfo to the client through DragItem instead of DragClient::prepareToDragPromisedBlob
912         https://bugs.webkit.org/show_bug.cgi?id=181497
913
914         Reviewed by Tim Horton.
915
916         See other ChangeLogs for more detail.
917
918         * WebCoreSupport/WebDragClient.h:
919
920 2018-01-11  Tim Horton  <timothy_horton@apple.com>
921
922         Null deref in WebImmediateActionController _dictionaryPopupInfoForRange
923         https://bugs.webkit.org/show_bug.cgi?id=181523
924         <rdar://problem/28959131>
925
926         Reviewed by Alex Christensen.
927
928         * WebView/WebImmediateActionController.mm:
929         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
930         Apply the change made in r216652 to WebKit1's immediate action controller.
931
932         Speculative (but successful in WebKit2) fix for non-reproducible crash when
933         the startContainer of the range is in an anonymous node.
934
935 2018-01-11  Youenn Fablet  <youenn@apple.com>
936
937         Replace WebRTCLegacyAPIDisabled by WebRTCLegacyAPIEnabled and switch off WebRTC legacy flag by default
938         https://bugs.webkit.org/show_bug.cgi?id=181480
939
940         Reviewed by Eric Carlson.
941
942         * WebView/WebPreferences.mm:
943         (+[WebPreferences initialize]):
944
945 2018-01-08  David Kilzer  <ddkilzer@apple.com>
946
947         Fix check-webkit-style issues with WebNSDataExtras.mm
948         <https://webkit.org/b/181369>
949
950         Reviewed by Alex Christensen.
951
952         * Misc/WebNSDataExtras.mm:
953         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
954         (-[NSData _webkit_guessedMIMETypeForXML]):
955         (-[NSData _webkit_guessedMIMEType]):
956         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
957         (_findEOL):
958         (-[NSData _webkit_parseRFC822HeaderFields]):
959         (-[NSData _web_locationAfterFirstBlankLine]):
960         - Fix all the check-webkit-style warnings.
961
962 2018-01-08  David Kilzer  <ddkilzer@apple.com>
963
964         Build fix #2: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
965         <https://webkit.org/b/181256>
966         <rdar://problem/36281730>
967
968         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
969         (WebNetscapePluginEventHandlerCocoa::handleTSMEvent):
970         - Use reinterpret_cast<NPNSString*>(const_cast<CFMutableStringRef>())
971           to avoid warnings from casting CFStringRef to NPNSString*.
972           Note that CFMutableStringRef is the same as CFStringRef
973           without the const modifier, hence its use in the const_cast<>
974           above.
975
976 2018-01-08  David Kilzer  <ddkilzer@apple.com>
977
978         Build fix: Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
979         <https://webkit.org/b/181256>
980         <rdar://problem/36281730>
981
982         * Carbon/HIWebView.mm:
983         (StartUpdateObserver): Include TypeCastsCF.h from WTF, and use
984         checked_cf_cast<CFRunLoopRef>() to fix warning.
985
986 2018-01-07  David Kilzer  <ddkilzer@apple.com>
987
988         Enable -Wcast-qual for WebInspectorUI, WebKitLegacy, WebKit projects
989         <https://webkit.org/b/181256>
990         <rdar://problem/36281730>
991
992         Reviewed by Darin Adler.
993
994         * Carbon/CarbonUtils.m:
995         (PoolCleaner):
996         - Use #pragmas to ignore -Wcast-qual warnings when using a
997           C-style cast from CFTypeRef to CFRunloopRef.
998         * Carbon/CarbonWindowFrame.m:
999         (-[CarbonWindowFrame title]):
1000         - Use #pragmas to ignore -Wcast-qual warnings when using a
1001           C-style cast from CFStringRef to NSString *.
1002         * Carbon/HIViewAdapter.m:
1003         (+[HIViewAdapter getHIViewForNSView:]):
1004         - Use #pragmas to ignore -Wcast-qual warnings when using a
1005           C-style cast from CFTypeRef to HIViewRef.
1006         * Configurations/Base.xcconfig:
1007         (WARNING_CFLAGS): Add -Wcast-qual.
1008         * Misc/WebElementDictionary.mm:
1009         (-[WebElementDictionary objectForKey:]):
1010         - Use static_cast<SEL>(const_cast<void*>()) to fix
1011           warning.
1012         * Misc/WebNSDataExtras.mm: Renamed from Source/WebKitLegacy/mac/Misc/WebNSDataExtras.m.
1013         (-[NSString _web_capitalizeRFC822HeaderFieldName]):
1014         (-[NSData _webkit_guessedMIMETypeForXML]):
1015         (-[NSData _webkit_guessedMIMEType]):
1016         (-[NSData _web_isCaseInsensitiveEqualToCString:]):
1017         (_findEOL):
1018         (-[NSData _webkit_parseRFC822HeaderFields]):
1019         (-[NSData _web_startsWithBlankLine]):
1020         (-[NSData _web_locationAfterFirstBlankLine]):
1021         - Rename WebNSDataExtras.m to WebNSDataExtras.mm and change file
1022           type to Objective-C++.  This fixes the warnings about
1023           discarding the `const` modifier when casing from CFStringRef
1024           to NSString * because in older clang versions, -Wcast-qual was
1025           completely broken when compiling C++ and Objective-C++ source
1026           files.  In newer clang versions, discarding the `const`
1027           modifier for toll-free bridged types is ignored when compiling
1028           Objective-C++ source.
1029         - Update copyright and license header.
1030         - Use reinterpret_cast<> and static_cast<> to fix warnings
1031           unrelated to (NSString *) C-style casts.
1032         - Replace use of MIN() macro with std::min<> template functions.
1033         - Fix location of `*` for local variables modified above.
1034         * Plugins/Hosted/NetscapePluginHostManager.mm:
1035         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1036         (WebKit::NetscapePluginHostManager::initializeVendorPort):
1037         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1038         - Use static_cast<uint8_t*>(const_cast<void*>()) to fix
1039           warnings.
1040         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1041         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
1042         - Use reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>())
1043           to fix warning.
1044         * Plugins/Hosted/ProxyInstance.mm:
1045         (WebKit::ProxyInstance::invoke):
1046         - Use static_cast<char*>(const_cast<void*>()) to fix
1047           warning when using -[NSData bytes].
1048         (WebKit::ProxyInstance::fieldValue const):
1049         - Use reinterpret_cast<char*>(const_cast<unsigned char*>())
1050           to fix warning when using CFDataGetBytePtr().
1051         * Plugins/Hosted/WebTextInputWindowController.m:
1052         (-[WebTextInputPanel _interpretKeyEvent:string:]):
1053         - Use #pragma to ignore -Wcast-qual warning since there
1054           is not a good way to avoid this warning in Objective-C.
1055         * Plugins/WebNetscapePluginStream.mm:
1056         (WebNetscapePluginStream::deliverData):
1057         - Use const_cast<void*>() to fix warning when using
1058           -[NSData bytes].
1059         * Plugins/WebNetscapePluginView.mm:
1060         (-[WebNetscapePluginView _createPlugin]):
1061         - Change C-style cast to const_cast<char*>() to fix
1062           warning.
1063         * WebCoreSupport/WebChromeClient.mm:
1064         (WebChromeClient::wrapCryptoKey const):
1065         (WebChromeClient::unwrapCryptoKey const):
1066         - Change C-style cast to
1067           static_cast<uint8_t*>(const_cast<void*>() to fix
1068           warning.
1069         * WebView/WebPDFView.mm:
1070         (_applicationInfoForMIMEType):
1071         - Change local variable type from 'NSURL *' to
1072           'CFURLRef' to fix warning.  Cast back to 'NSURL *'
1073           when calling -[NSURL path].
1074
1075 2018-01-05  Dan Bernstein  <mitz@apple.com>
1076
1077         Fixed the build following AppKit API deprecations in a recent SDKs
1078
1079         * WebView/WebFullScreenController.mm:
1080         (-[WebFullScreenController enterFullScreen:]): Suppressed deprecation warnings.
1081         (-[WebFullScreenController exitFullScreen]): Ditto.
1082         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]): Ditto.
1083         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]): Ditto.
1084         * WebView/WebHTMLView.mm:
1085         (-[WebHTMLView drawRect:]): Ditto.
1086         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]): Ditto.
1087         (-[WebHTMLView knowsPageRange:]): Ditto.
1088         * WebView/WebView.mm:
1089         (LayerFlushController::flushLayers): Ditto.
1090
1091 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1092
1093         [Attachment Support] Create attachment elements when dropping files on iOS
1094         https://bugs.webkit.org/show_bug.cgi?id=181192
1095         <rdar://problem/36280945>
1096
1097         Reviewed by Tim Horton.
1098
1099         Make some minor adjustments for changes to the pasteboard in WebCore. See WebCore/ChangeLog for more detail.
1100
1101         * WebCoreSupport/WebPlatformStrategies.h:
1102         * WebCoreSupport/WebPlatformStrategies.mm:
1103         (WebPlatformStrategies::informationForItemAtIndex):
1104         (WebPlatformStrategies::getFilenamesForDataInteraction): Deleted.
1105
1106 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1107
1108         [Attachment Support] Add plumbing for starting a drag with promised blob data
1109         https://bugs.webkit.org/show_bug.cgi?id=181201
1110
1111         Reviewed by Tim Horton.
1112
1113         Minor adjustment to account for a DragClient interface change. See WebCore ChangeLog for more details.
1114
1115         * WebCoreSupport/WebDragClient.h:
1116
1117 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1118
1119         Add a WebAuthentication runtime feature flag
1120         https://bugs.webkit.org/show_bug.cgi?id=181220
1121         <rdar://problem/36055305>
1122
1123         Reviewed by Brent Fulgham.
1124
1125         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1126
1127         * WebView/WebPreferenceKeysPrivate.h:
1128         * WebView/WebPreferences.mm:
1129         (+[WebPreferences initialize]):
1130         (-[WebPreferences webAuthenticationEnabled]):
1131         (-[WebPreferences setWebAuthenticationEnabled:]):
1132         (-[WebPreferences credentialManagementEnabled]): Deleted.
1133         (-[WebPreferences setCredentialManagementEnabled:]): Deleted.
1134         * WebView/WebPreferencesPrivate.h:
1135         * WebView/WebView.mm:
1136         (-[WebView _preferencesChanged:]):
1137
1138 2017-12-22  Jeff Miller  <jeffm@apple.com>
1139
1140         Update user-visible copyright strings to include 2018
1141         https://bugs.webkit.org/show_bug.cgi?id=181141
1142
1143         Reviewed by Dan Bernstein.
1144
1145         * Info.plist:
1146
1147 2017-12-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1148
1149         [Attachment Support] Remove current macOS support for dragging file-backed attachments
1150         https://bugs.webkit.org/show_bug.cgi?id=181188
1151
1152         Reviewed by Dan Bernstein.
1153
1154         See WebCore/ChangeLog for more detail.
1155
1156         * WebCoreSupport/WebDragClient.h:
1157         * WebCoreSupport/WebDragClient.mm:
1158         (WebDragClient::declareAndWriteAttachment): Deleted.
1159         * WebView/WebHTMLView.mm:
1160         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
1161
1162 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1163
1164         Unreviewed, continue to fix build failures due to AppKit API deprecation
1165
1166         Wraps more code in -Wdeprecated-declarations.
1167
1168         * Carbon/HIWebView.mm:
1169         (overrideCGContext):
1170
1171 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1172
1173         Unreviewed, fix build failures due to using deprecated AppKit symbols when building 32-bit
1174
1175         Wrap some more code in -Wdeprecated-declarations to try and fix the 32-bit build using the newest SDK.
1176
1177         * Carbon/CarbonWindowAdapter.mm:
1178         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
1179         * Plugins/WebNetscapePluginView.mm:
1180         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1181         (-[WebNetscapePluginView sendDrawRectEvent:]):
1182         (-[WebNetscapePluginView drawRect:]):
1183
1184 2017-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1185
1186         Fix build failures due to using deprecated AppKit symbols
1187         https://bugs.webkit.org/show_bug.cgi?id=181110
1188         <rdar://problem/36162865>
1189
1190         Reviewed by Dan Bernstein and Tim Horton.
1191
1192         See WebCore ChangeLog for more details. Additionally makes a few minor adjustments to pass our style checker.
1193
1194         * Misc/WebKitNSStringExtras.mm:
1195         (-[NSString _web_drawAtPoint:font:textColor:]):
1196         * Misc/WebNSPasteboardExtras.h:
1197         * Misc/WebNSPasteboardExtras.mm:
1198         (+[NSPasteboard _web_writableTypesForURL]):
1199         (_createWritableTypesForImageWithoutArchive):
1200         (_createWritableTypesForImageWithArchive):
1201         (+[NSPasteboard _web_dragTypesForURL]):
1202         (-[NSPasteboard _web_bestURL]):
1203         (-[NSPasteboard _web_writeURL:andTitle:types:]):
1204         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
1205         (-[NSPasteboard _web_writeFileWrapperAsRTFDAttachment:]):
1206         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]):
1207         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
1208         * Panels/WebAuthenticationPanel.m:
1209         (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
1210         (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
1211         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1212         (-[WebHostedNetscapePluginView drawRect:]):
1213         * WebInspector/WebNodeHighlightView.mm:
1214         (-[WebNodeHighlightView drawRect:]):
1215         * WebView/WebFrame.mm:
1216         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
1217         (-[WebFrame _drawRect:contentsOnly:]):
1218         * WebView/WebHTMLView.mm:
1219         (kit):
1220         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]):
1221         (-[WebHTMLView _plainTextFromPasteboard:]):
1222         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1223         (+[WebHTMLView _insertablePasteboardTypes]):
1224         (+[WebHTMLView _selectionPasteboardTypes]):
1225         (-[WebHTMLView pasteboard:provideDataForType:]):
1226         (-[WebHTMLView _writeSelectionToPasteboard:]):
1227         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1228         (-[WebHTMLView validRequestorForSendType:returnType:]):
1229         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1230         (createMenuItem):
1231         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
1232         (-[WebHTMLView _colorAsString:]):
1233         (-[WebHTMLView copyFont:]):
1234         * WebView/WebPDFView.mm:
1235         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
1236         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
1237         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
1238         (-[WebPDFView pasteboardTypesForSelection]):
1239         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1240         * WebView/WebView.h:
1241         * WebView/WebView.mm:
1242         (-[WebView performDragOperation:]):
1243         (-[WebView validateUserInterfaceItemWithoutDelegate:]):
1244         (-[WebView _searchWithGoogleFromMenu:]):
1245
1246 2017-12-21  Youenn Fablet  <youenn@apple.com>
1247
1248         ServiceWorkerThreadProxy should set the correct cookie and cache partitioning options
1249         https://bugs.webkit.org/show_bug.cgi?id=181000
1250
1251         Reviewed by Chris Dumez.
1252
1253         * Misc/WebCache.mm:
1254         (+[WebCache addImageToCache:forURL:forFrame:]):
1255
1256 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1257
1258         Update FULLSCREEN_API feature defines.
1259         https://bugs.webkit.org/show_bug.cgi?id=181015
1260
1261         Reviewed by Tim Horton.
1262
1263         Change enabled iphone sdk for FULLSCREEN_API.
1264
1265         * Configurations/FeatureDefines.xcconfig:
1266
1267 2017-12-21  Jer Noble  <jer.noble@apple.com>
1268
1269         Add initial DOM support for Media Capabilities
1270         https://bugs.webkit.org/show_bug.cgi?id=181064
1271
1272         Reviewed by Eric Carlson.
1273
1274         Add a new preference to enable the (disabled-by-default) Media Capabilities API.
1275
1276         * WebView/WebPreferenceKeysPrivate.h:
1277         * WebView/WebPreferences.mm:
1278         (+[WebPreferences initialize]):
1279         (-[WebPreferences mediaCapabilitiesEnabled]):
1280         (-[WebPreferences setMediaCapabilitiesEnabled:]):
1281         * WebView/WebPreferencesPrivate.h:
1282         * WebView/WebView.mm:
1283         (-[WebView _preferencesChanged:]):
1284
1285 2017-12-21  Jeremy Jones  <jeremyj@apple.com>
1286
1287         Enable picture-in-picture from inline element on suspend.
1288         https://bugs.webkit.org/show_bug.cgi?id=180942
1289         rdar://problem/34745234
1290
1291         Reviewed by Jer Noble.
1292
1293         Update signature of enterVideoFullscreenForVideoElement().
1294
1295         * WebCoreSupport/WebChromeClient.h:
1296         * WebCoreSupport/WebChromeClient.mm:
1297         (WebChromeClient::enterVideoFullscreenForVideoElement):
1298
1299 2017-12-20  Daniel Bates  <dabates@apple.com>
1300
1301         Remove Alternative Presentation Button
1302         https://bugs.webkit.org/show_bug.cgi?id=180500
1303         <rdar://problem/35891047>
1304
1305         Reviewed by Simon Fraser.
1306
1307         We no longer need the alternative presentation button.
1308
1309         * Configurations/FeatureDefines.xcconfig:
1310
1311 2017-12-19  Jer Noble  <jer.noble@apple.com>
1312
1313         Playing media elements which call "pause(); play()" will have the play promise rejected.
1314         https://bugs.webkit.org/show_bug.cgi?id=180781
1315         <rdar://problem/33191377>
1316
1317         Reviewed by Eric Carlson.
1318
1319         shouldRequireUserGestureToLoadVideo() should default to false on Mac.
1320
1321         * WebView/WebView.mm:
1322         (shouldRequireUserGestureToLoadVideo):
1323
1324 2017-12-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1325
1326         API test WKAttachmentTests.InsertPastedAttributedStringContainingMultipleAttachments is failing on El Capitan and Sierra
1327         https://bugs.webkit.org/show_bug.cgi?id=180977
1328
1329         Reviewed by Tim Horton.
1330
1331         Fixes a failing API test by updating markup deserialization codepaths in WebKitLegacy to behave like the modern
1332         WebCore counterpart. When determining element tags to exclude when generating markup from an attributed string,
1333         don't add "object" as an element to exclude if the attachment element runtime feature is enabled.
1334
1335         * WebCoreSupport/WebEditorClient.mm:
1336         (attributesForAttributedStringConversion):
1337         * WebView/WebHTMLView.mm:
1338         (+[WebHTMLView _excludedElementsForAttributedStringConversion]):
1339
1340 2017-12-18  David Kilzer  <ddkilzer@apple.com>
1341
1342         BUILD FIX: Ignore NSWindow deprecation warnings from the mysterious future
1343
1344         Attempt to fix the following warnings:
1345
1346             AppKit instance variables are private, and the ability to access them will be removed in a future release. [-Werror,-Wdeprecated-declarations]
1347
1348         For the following instance variables:
1349
1350             _borderView
1351             _contentView
1352             _frame
1353             _wFlags
1354
1355         * Carbon/CarbonWindowAdapter.mm:
1356         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1357         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
1358         (-[CarbonWindowAdapter _termWindowIfOwner]):
1359         (-[CarbonWindowAdapter _windowMovedToRect:]):
1360         (-[CarbonWindowAdapter setContentView:]):
1361         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
1362         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
1363
1364 2017-12-16  Dan Bernstein  <mitz@apple.com>
1365
1366         WKWebView has no equivalent of -[WebView setAlwaysShowVerticalScroller:]
1367         https://bugs.webkit.org/show_bug.cgi?id=180613
1368         <rdar://problem/35946124>
1369
1370         Reviewed by Geoff Garen.
1371
1372         * WebKit.mac.exp: Removed WebCoreScrollbarAlwaysOn, which is no longer being used by any
1373           clients.
1374         * WebView/WebDynamicScrollBarsView.h: Ditto.
1375         * WebView/WebDynamicScrollBarsView.mm: Ditto.
1376
1377 2017-12-14  David Kilzer  <ddkilzer@apple.com>
1378
1379         Enable -Wstrict-prototypes for WebKit
1380         <https://webkit.org/b/180757>
1381         <rdar://problem/36024132>
1382
1383         Rubber-stamped by Joseph Pecoraro.
1384
1385         * Configurations/Base.xcconfig:
1386         (CLANG_WARN_STRICT_PROTOTYPES): Add. Set to YES.
1387
1388 2017-12-14  John Wilander  <wilander@apple.com>
1389
1390         Storage Access API: Implement frame-specific access in the document.cookie layer
1391         https://bugs.webkit.org/show_bug.cgi?id=180682
1392         <rdar://problem/35982257>
1393
1394         Reviewed by Alex Christensen.
1395
1396         CookiesStrategy::cookiesForDOM(), CookiesStrategy::setCookiesFromDOM(),
1397         CookiesStrategy::cookieRequestHeaderFieldValue(), and
1398         CookiesStrategy::getRawCookies() now take optional parameters for
1399         frameID and pageID to allow frame-specific scoping of cookies.
1400
1401         This change makes the return values of FrameLoaderClient::frameID()
1402         and FrameLoaderClient::pageID() std::optional<uint64_t> so that
1403         WebCore can call those getters and get the right return values in
1404         WebKit and std:nullopt in WebKitLegacy.
1405
1406         * WebCoreSupport/WebFrameLoaderClient.h:
1407         * WebCoreSupport/WebFrameLoaderClient.mm:
1408         (WebFrameLoaderClient::pageID const):
1409         (WebFrameLoaderClient::frameID const):
1410         * WebCoreSupport/WebPlatformStrategies.h:
1411         * WebCoreSupport/WebPlatformStrategies.mm:
1412         (WebPlatformStrategies::cookiesForDOM):
1413         (WebPlatformStrategies::setCookiesFromDOM):
1414         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1415         (WebPlatformStrategies::getRawCookies):
1416
1417 2017-12-12  Simon Fraser  <simon.fraser@apple.com>
1418
1419         Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
1420         https://bugs.webkit.org/show_bug.cgi?id=180689
1421
1422         Reviewed by Tim Horton.
1423
1424         Use sRGBColorSpaceRef() from WebCore.
1425
1426         * WebView/WebHTMLView.mm:
1427         (imageFromRect):
1428
1429 2017-12-11  Tim Horton  <timothy_horton@apple.com>
1430
1431         Stop using deprecated target conditional for simulator builds
1432         https://bugs.webkit.org/show_bug.cgi?id=180662
1433         <rdar://problem/35136156>
1434
1435         Reviewed by Simon Fraser.
1436
1437         * postprocess-headers.sh:
1438
1439 2017-12-11  David Quesada  <david_quesada@apple.com>
1440
1441         Turn on ENABLE_APPLICATION_MANIFEST
1442         https://bugs.webkit.org/show_bug.cgi?id=180562
1443         rdar://problem/35924737
1444
1445         Reviewed by Geoffrey Garen.
1446
1447         * Configurations/FeatureDefines.xcconfig:
1448
1449 2017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
1450
1451         Remove pthread_once in favor of dispatch_once
1452         https://bugs.webkit.org/show_bug.cgi?id=180591
1453
1454         Reviewed by Saam Barati.
1455
1456         * Misc/WebKitErrors.m:
1457         (+[NSError _registerWebKitErrors]):
1458         (registerErrors): Deleted.
1459         * Storage/WebStorageManager.mm:
1460         (+[WebStorageManager _storageDirectoryPath]):
1461         (initializeLocalStoragePath): Deleted.
1462
1463 2017-12-07  Darin Adler  <darin@apple.com>
1464
1465         Remove some unused code from WebKitLegacy
1466         https://bugs.webkit.org/show_bug.cgi?id=180567
1467
1468         Reviewed by Anders Carlsson.
1469
1470         * Misc/WebKitNSStringExtras.h: Researched which of these functions are used in
1471         macOS (back a few versions) and iOS and removed unused
1472         _web_drawAtPoint:font:textColor:allowingFontSmoothing:,
1473         _web_drawDoubledAtPoint:withTopColor:bottomColor:font:,
1474         _web_stringByStrippingReturnCharacters, _webkit_hasCaseInsensitiveSubstring:,
1475         _webkit_stringByCollapsingNonPrintingCharacters,
1476         _webkit_stringByCollapsingWhitespaceCharacters,
1477         _web_stringWithData:textEncodingName:, and
1478         _webkit_localStorageDirectoryWithBundleIdentifier:.
1479
1480         * Misc/WebKitNSStringExtras.mm: Made WebKitLocalCacheDefaultsKey private to
1481         this source file.
1482         (canUseFastRenderer): Made this faster by not calling u_charDirection for
1483         Latin-1 characters, and also added special cases for U_DIR_NON_SPACING_MARK
1484         and U_BOUNDARY_NEUTRAL, which should not prevent use of the fast renderer.
1485         (-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
1486         (-[NSString _web_drawAtPoint:font:textColor:]): Removed unneeded code to
1487         handle font smoothing options.
1488         (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]): Deleted.
1489         (-[NSString _web_stringByAbbreviatingWithTildeInPath]): Moved comment here
1490         from header and made it a little clearer.
1491         (-[NSString _web_stringByStrippingReturnCharacters]): Deleted.
1492         (-[NSString _webkit_hasCaseInsensitiveSubstring:]): Deleted.
1493         (-[NSString _webkit_stringByCollapsingNonPrintingCharacters]): Deleted.
1494         (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): Deleted.
1495         (+[NSString _web_stringWithData:textEncodingName:]): Deleted.
1496         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]): Streamlined
1497         implementation a bit and used whole words instead of abbreviations.
1498         (+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Deleted.
1499
1500         * Misc/WebNSFileManagerExtras.mm:
1501         (-[NSFileManager _webkit_pathWithUniqueFilenameForPath:]): Use the
1502         filenameByFixingIllegalCharacters function from WebCore directly instead of
1503         indirectly through the method _webkit_filenameByFixingIllegalCharacters.
1504
1505         * Plugins/WebBaseNetscapePluginView.mm:
1506         (-[WebBaseNetscapePluginView URLWithCString:]): Rewrote to use simple
1507         string replacements instead of _web_stringByStrippingReturnCharacters
1508         and to use NSString methods instead of CFString functions.
1509
1510 2017-12-07  Jessie Berlin  <jberlin@webkit.org>
1511
1512         Ignore deprecation warnings.
1513
1514         * WebView/WebHTMLView.mm:
1515         (-[NSWindow _web_borderView]):
1516         (-[WebHTMLView _setAsideSubviews]):
1517         * WebView/WebView.mm:
1518         (-[WebView encodeWithCoder:]):
1519
1520 2017-12-02  Darin Adler  <darin@apple.com>
1521
1522         Modernize some aspects of text codecs, eliminate WebKit use of strcasecmp
1523         https://bugs.webkit.org/show_bug.cgi?id=180009
1524
1525         Reviewed by Alex Christensen.
1526
1527         * History/HistoryPropertyList.mm: Removed include of StringExtras.h.
1528
1529         * Plugins/WebBaseNetscapePluginView.mm:
1530         (WebKit::getAuthenticationInfo): Use equalLettersIgnoringASCIICase instead
1531         of strcasecmp.
1532
1533         * WebView/WebPreferences.mm:
1534         (contains): Ditto. Also made this a template so it's easier to call on an array.
1535         (cacheModelForMainBundle): Take advantage of the above to make it cleaner.
1536
1537 2017-12-05  Brent Fulgham  <bfulgham@apple.com>
1538
1539         Limit user agent versioning to an upper bound
1540         https://bugs.webkit.org/show_bug.cgi?id=180365
1541         <rdar://problem/34550617>
1542
1543         Reviewed by Joseph Pecoraro.
1544
1545         * WebView/WebView.mm:
1546         (+[WebView _standardUserAgentWithApplicationName:]): Don't pass the WebKit bundle version when
1547         creating the User Agent string.
1548         (webKitBundleVersionString): Deleted.
1549
1550 2017-12-05  Andy Estes  <aestes@apple.com>
1551
1552         [Cocoa] Stop specifying TARGET_OS_EMBEDDED in postprocess-headers.sh's unifdef options
1553         https://bugs.webkit.org/show_bug.cgi?id=180457
1554         <rdar://problem/35143007>
1555
1556         Reviewed by Tim Horton.
1557
1558         None of WebKitLegacy's framework headers mention TARGET_OS_EMBEDDED, so there's no need to
1559         check for this macro during post-processing.
1560
1561         * postprocess-headers.sh:
1562
1563 2017-12-04  David Quesada  <david_quesada@apple.com>
1564
1565         Add a class for parsing application manifests
1566         https://bugs.webkit.org/show_bug.cgi?id=177973
1567         rdar://problem/34747949
1568
1569         Reviewed by Geoffrey Garen.
1570
1571         * Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
1572
1573 2017-11-30  Stephan Szabo  <stephan.szabo@sony.com>
1574
1575         Make LegacyCustomProtocolManager optional for network process
1576         https://bugs.webkit.org/show_bug.cgi?id=176230
1577
1578         Reviewed by Alex Christensen.
1579
1580         * Configurations/FeatureDefines.xcconfig:
1581
1582 2017-11-30  Joseph Pecoraro  <pecoraro@apple.com>
1583
1584         Fix some NSOperationQueue leaks
1585         https://bugs.webkit.org/show_bug.cgi?id=180221
1586
1587         Reviewed by Wenson Hsieh.
1588
1589         * WebView/WebView.mm:
1590         (-[WebView performDragOperation:]):
1591
1592 2017-11-30  Darin Adler  <darin@apple.com>
1593
1594         [Mac] remove unneeded RetainPtr use introduced in r225142
1595         https://bugs.webkit.org/show_bug.cgi?id=180202
1596
1597         Reviewed by Tim Horton.
1598
1599         * WebView/WebImmediateActionController.mm:
1600         (-[WebImmediateActionController _animationControllerForText]): Got rid of unnecessary
1601         RetainPtr.
1602
1603 2017-11-29  Said Abou-Hallawa  <sabouhallawa@apple.com>
1604
1605         Remove the ImageSource from the class hierarchy that connects BitmapImage to ImageFrame
1606         https://bugs.webkit.org/show_bug.cgi?id=175595
1607
1608         Reviewed by Darin Adler.
1609
1610         * WebView/WebPreferences.mm:
1611
1612 2017-11-27  Tim Horton  <timothy_horton@apple.com>
1613
1614         One too many zeroes in macOS version number in FeatureDefines
1615         https://bugs.webkit.org/show_bug.cgi?id=180011
1616
1617         Reviewed by Dan Bernstein.
1618
1619         * Configurations/FeatureDefines.xcconfig:
1620
1621 2017-11-23  Darin Adler  <darin@apple.com>
1622
1623         Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
1624         https://bugs.webkit.org/show_bug.cgi?id=179981
1625
1626         Reviewed by Sam Weinig.
1627
1628         * WebView/WebImmediateActionController.mm:
1629         (-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.
1630         * WebView/WebView.mm:
1631         (coreOptions): Use |= instead of | to build up FindOptions.
1632
1633 2017-11-23  Sam Weinig  <sam@webkit.org>
1634
1635         Remove unneeded ScriptController::processingUserGesture() forwarding functions
1636         https://bugs.webkit.org/show_bug.cgi?id=179954
1637
1638         Reviewed by Darin Adler.
1639
1640         Replace ScriptController::processingUserGesture() and ScriptController::processingUserGestureForMedia()
1641         with direct calls to the corresponding UserGestureIndicator functions.
1642
1643         * Plugins/WebPluginController.mm:
1644         (-[WebPluginController processingUserGesture]):
1645         * WebView/WebView.mm:
1646         (-[WebView _isProcessingUserGesture]):
1647
1648 2017-11-23  Darin Adler  <darin@apple.com>
1649
1650         Reduce WTF::String operations that do unnecessary Unicode operations instead of ASCII
1651         https://bugs.webkit.org/show_bug.cgi?id=179907
1652
1653         Reviewed by Sam Weinig.
1654
1655         * History/BinaryPropertyList.cpp:
1656         (BinaryPropertyListPlan::writeStringObject): Use isAllASCII.
1657         (BinaryPropertyListSerializer::appendStringObject): Ditto.
1658         * WebView/WebHTMLRepresentation.mm:
1659         (regExpForLabels): Removed TextCaseSensitive since it is now the default.
1660         (matchLabelsAgainstString): Use JSC::Yarr::TextCaseInsensitive.
1661
1662 2017-11-22  Ali Juma  <ajuma@chromium.org>
1663
1664         Implement VisualViewport API attributes
1665         https://bugs.webkit.org/show_bug.cgi?id=179385
1666
1667         Reviewed by Frédéric Wang.
1668
1669         Add a VisualViewportAPI preference.
1670
1671         * WebView/WebPreferenceKeysPrivate.h:
1672         * WebView/WebPreferences.mm:
1673         (+[WebPreferences initialize]):
1674         (-[WebPreferences visualViewportAPIEnabled]):
1675         (-[WebPreferences setVisualViewportAPIEnabled:]):
1676         * WebView/WebPreferencesPrivate.h:
1677         * WebView/WebView.mm:
1678         (-[WebView _preferencesChanged:]):
1679
1680 2017-11-22  Christopher Reid  <chris.reid@sony.com>
1681
1682         WebCoreObjCExtras.h is being included in too many places
1683         https://bugs.webkit.org/show_bug.cgi?id=179931
1684
1685         Reviewed by Darin Adler.
1686
1687         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1688         * Plugins/WebBaseNetscapePluginView.mm:
1689         * Plugins/WebBasePluginPackage.mm:
1690         * Plugins/WebNetscapePluginStream.mm:
1691         * Plugins/WebNetscapePluginView.mm:
1692         * WebView/WebTextIterator.mm:
1693         * WebView/WebViewData.mm:
1694
1695 2017-11-22  Commit Queue  <commit-queue@webkit.org>
1696
1697         Unreviewed, rolling out r225093.
1698         https://bugs.webkit.org/show_bug.cgi?id=179938
1699
1700         Compilation failed on WinCairo 64-bit Release (Requested by
1701         fredw on #webkit).
1702
1703         Reverted changeset:
1704
1705         "Implement VisualViewport API attributes"
1706         https://bugs.webkit.org/show_bug.cgi?id=179385
1707         https://trac.webkit.org/changeset/225093
1708
1709 2017-11-21  Ali Juma  <ajuma@chromium.org>
1710
1711         Implement VisualViewport API attributes
1712         https://bugs.webkit.org/show_bug.cgi?id=179385
1713
1714         Reviewed by Frédéric Wang.
1715
1716         Add a VisualViewportAPI preference.
1717
1718         * WebView/WebPreferenceKeysPrivate.h:
1719         * WebView/WebPreferences.mm:
1720         (+[WebPreferences initialize]):
1721         (-[WebPreferences visualViewportAPIEnabled]):
1722         (-[WebPreferences setVisualViewportAPIEnabled:]):
1723         * WebView/WebPreferencesPrivate.h:
1724         * WebView/WebView.mm:
1725         (-[WebView _preferencesChanged:]):
1726
1727 2017-11-21  Christopher Reid  <chris.reid@sony.com>
1728
1729         [PAL] Remove FileSystem's dependency on WebCoreNSStringExtras
1730         https://bugs.webkit.org/show_bug.cgi?id=179504
1731
1732         Reviewed by Darin Adler.
1733
1734         * Misc/WebKitNSStringExtras.mm:
1735         * Plugins/Hosted/NetscapePluginHostManager.mm:
1736         * Plugins/WebBasePluginPackage.mm:
1737
1738 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1739
1740         Remove unused TOUCH_ICON_LOADING feature flag
1741         https://bugs.webkit.org/show_bug.cgi?id=179873
1742
1743         Reviewed by Simon Fraser.
1744
1745         * Configurations/FeatureDefines.xcconfig:
1746
1747 2017-11-19  Tim Horton  <timothy_horton@apple.com>
1748
1749         Remove unused LEGACY_VENDOR_PREFIXES feature flag
1750         https://bugs.webkit.org/show_bug.cgi?id=179872
1751
1752         Reviewed by Darin Adler.
1753
1754         * Configurations/FeatureDefines.xcconfig:
1755
1756 2017-11-16  Daniel Bates  <dabates@apple.com>
1757
1758         Add feature define for alternative presentation button element
1759         https://bugs.webkit.org/show_bug.cgi?id=179692
1760         Part of <rdar://problem/34917108>
1761
1762         Reviewed by Andy Estes.
1763
1764         Only enabled on Cocoa platforms by default.
1765
1766         * Configurations/FeatureDefines.xcconfig:
1767
1768 2017-11-14  Nan Wang  <n_wang@apple.com>
1769
1770         AX: AOM: Implement AccessibleNode class and support label and role attributes
1771         https://bugs.webkit.org/show_bug.cgi?id=179494
1772
1773         Reviewed by Ryosuke Niwa.
1774
1775         * WebView/WebPreferenceKeysPrivate.h:
1776         * WebView/WebPreferences.mm:
1777         (+[WebPreferences initialize]):
1778         (-[WebPreferences accessibilityObjectModelEnabled]):
1779         (-[WebPreferences setAccessibilityObjectModelEnabled:]):
1780         * WebView/WebPreferencesPrivate.h:
1781         * WebView/WebView.mm:
1782         (-[WebView _preferencesChanged:]):
1783
1784 2017-11-14  Alex Christensen  <achristensen@webkit.org>
1785
1786         Remove Cocoa CFURLConnection loading code
1787         https://bugs.webkit.org/show_bug.cgi?id=179688
1788
1789         Reviewed by Antti Koivisto.
1790
1791         * Misc/WebDownload.mm:
1792         (-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
1793         * Misc/WebDownloadInternal.h:
1794         * Plugins/WebBaseNetscapePluginView.mm:
1795         * WebCoreSupport/WebFrameLoaderClient.mm:
1796         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1797         * WebView/WebView.mm:
1798         (-[WebView scheduleInRunLoop:forMode:]):
1799         (-[WebView unscheduleFromRunLoop:forMode:]):
1800
1801 2017-11-14  Daniel Bates  <dabates@apple.com>
1802
1803         Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
1804         for feature defines
1805
1806         Following r195498 and r201917 the Visual Studio property files for feature defines have
1807         moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
1808         Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
1809         files.
1810
1811         * Configurations/FeatureDefines.xcconfig:
1812
1813 2017-11-14  Jer Noble  <jer.noble@apple.com>
1814
1815         Enable Modern EME tests in DumpRenderTree
1816         https://bugs.webkit.org/show_bug.cgi?id=179544
1817
1818         Reviewed by Alex Christensen.
1819
1820         Add a WebPreferences property to enable the (modern) EME API.
1821
1822         * WebView/WebPreferenceKeysPrivate.h:
1823         * WebView/WebPreferences.mm:
1824         (+[WebPreferences initialize]):
1825         (-[WebPreferences encryptedMediaAPIEnabled]):
1826         (-[WebPreferences setEncryptedMediaAPIEnabled:]):
1827         * WebView/WebPreferencesPrivate.h:
1828         * WebView/WebView.mm:
1829         (-[WebView _preferencesChanged:]):
1830
1831 2017-11-14  Antti Koivisto  <antti@apple.com>
1832
1833         Enable display:contents by default
1834         https://bugs.webkit.org/show_bug.cgi?id=179655
1835
1836         Reviewed by Sam Weinig.
1837
1838         * WebView/WebPreferences.mm:
1839         (+[WebPreferences initialize]):
1840
1841 2017-11-13  Alex Christensen  <achristensen@webkit.org>
1842
1843         Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
1844         https://bugs.webkit.org/show_bug.cgi?id=178751
1845
1846         Reviewed by Brady Eidson.
1847
1848         * WebCoreSupport/WebFrameNetworkingContext.mm:
1849         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1850
1851 2017-11-08  Keith Miller  <keith_miller@apple.com>
1852
1853         Async iteration should only fetch the next method once and add feature flag
1854         https://bugs.webkit.org/show_bug.cgi?id=179451
1855
1856         Reviewed by Geoffrey Garen.
1857
1858         Add feature flag for Async iteration.
1859
1860         * Configurations/FeatureDefines.xcconfig:
1861
1862 2017-11-13  Mark Lam  <mark.lam@apple.com>
1863
1864         Add more overflow check book-keeping for MarkedArgumentBuffer.
1865         https://bugs.webkit.org/show_bug.cgi?id=179634
1866         <rdar://problem/35492517>
1867
1868         Reviewed by Saam Barati.
1869
1870         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1871         (WebKit::NetscapePluginInstanceProxy::invoke):
1872         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1873         (WebKit::NetscapePluginInstanceProxy::construct):
1874
1875 2017-11-12  Darin Adler  <darin@apple.com>
1876
1877         More is<> and downcast<>, less static_cast<>
1878         https://bugs.webkit.org/show_bug.cgi?id=179600
1879
1880         Reviewed by Chris Dumez.
1881
1882         * DOM/DOM.mm:
1883         (kit): Use is/downcast.
1884         * WebCoreSupport/WebEditorClient.mm:
1885         (WebEditorClient::handleKeyboardEvent): Ditto.
1886         (WebEditorClient::handleInputMethodKeydown): Ditto.
1887         * WebView/WebHTMLView.mm:
1888         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
1889
1890 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
1891
1892         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
1893         https://bugs.webkit.org/show_bug.cgi?id=179397
1894
1895         Reviewed by Wenson Hsieh.
1896
1897         * DOM/DOMHTMLInputElement.mm:
1898         (-[DOMHTMLInputElement insertTextSuggestion:]):
1899
1900 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
1901
1902         HTMLMediaElement should not use element fullscreen on iOS
1903         https://bugs.webkit.org/show_bug.cgi?id=179418
1904         rdar://problem/35409277
1905
1906         Reviewed by Eric Carlson.
1907
1908         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
1909
1910         * Configurations/FeatureDefines.xcconfig:
1911
1912 2017-11-06  Alex Christensen  <achristensen@webkit.org>
1913
1914         Make ResourceLoader::willSendRequestInternal asynchronous
1915         https://bugs.webkit.org/show_bug.cgi?id=179251
1916
1917         Reviewed by Andy Estes.
1918
1919         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1920         (WebKit::HostedNetscapePluginStream::start):
1921         * Plugins/WebNetscapePluginStream.mm:
1922         (WebNetscapePluginStream::start):
1923
1924 2017-11-01  Darin Adler  <darin@apple.com>
1925
1926         Simplify event dispatch code and make it a bit more consistent
1927         https://bugs.webkit.org/show_bug.cgi?id=178991
1928
1929         Reviewed by Chris Dumez.
1930
1931         * DOM/DOMEvent.mm:
1932         (-[DOMEvent srcElement]): Call target instead of srcElement.
1933
1934 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
1935
1936         [Touch Bar Web API] Add support for menuitem tag
1937         https://bugs.webkit.org/show_bug.cgi?id=179020
1938
1939         Reviewed by Ryosuke Niwa.
1940
1941         Adds in properties and methods that allow the menuitem runtime feature
1942         to be enabled or disabled.
1943
1944         * WebView/WebPreferenceKeysPrivate.h:
1945         * WebView/WebPreferences.mm:
1946         (-[WebPreferences menuItemElementEnabled]):
1947         (-[WebPreferences setMenuItemElementEnabled:]):
1948         * WebView/WebPreferencesPrivate.h:
1949         * WebView/WebView.mm:
1950         (-[WebView _preferencesChanged:]):
1951
1952 2017-11-02  Alex Christensen  <achristensen@webkit.org>
1953
1954         Use CompletionHandlers for redirects
1955         https://bugs.webkit.org/show_bug.cgi?id=179163
1956
1957         Reviewed by Tim Horton.
1958
1959         * Plugins/Hosted/HostedNetscapePluginStream.h:
1960         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1961         (WebKit::HostedNetscapePluginStream::willSendRequest):
1962         * Plugins/WebNetscapePluginStream.h:
1963         * Plugins/WebNetscapePluginStream.mm:
1964         (WebNetscapePluginStream::willSendRequest):
1965
1966 2017-11-02  Christopher Reid  <chris.reid@sony.com>
1967
1968         Add a FileSystem namespace to FileSystem.cpp
1969         https://bugs.webkit.org/show_bug.cgi?id=179063
1970
1971         Reviewed by Darin Adler.
1972
1973         * Misc/WebNSFileManagerExtras.mm:
1974         * Storage/WebDatabaseProvider.mm:
1975
1976 2017-11-02  Frederic Wang  <fwang@igalia.com>
1977
1978         Add references to bug 179167 in FIXME comments
1979         https://bugs.webkit.org/show_bug.cgi?id=179168
1980
1981         Reviewed by Daniel Bates.
1982
1983         * Configurations/FeatureDefines.xcconfig:
1984
1985 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
1986
1987         Implement WKFullscreenWindowController for iOS.
1988         https://bugs.webkit.org/show_bug.cgi?id=178924
1989         rdar://problem/34697120
1990
1991         Reviewed by Simon Fraser.
1992
1993         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
1994
1995         * Configurations/FeatureDefines.xcconfig:
1996         * WebView/WebView.mm:
1997         (-[WebView fullScreenPlaceholderView]):
1998
1999 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2000
2001         Clean up some drag and drop feature flags
2002         https://bugs.webkit.org/show_bug.cgi?id=179082
2003
2004         Reviewed by Simon Fraser.
2005
2006         * Configurations/FeatureDefines.xcconfig:
2007
2008 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
2009
2010         Make it possible to test rubber-banding in overflow scroll
2011         https://bugs.webkit.org/show_bug.cgi?id=179078
2012
2013         Reviewed by Sam Weinig.
2014
2015         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
2016         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
2017
2018         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
2019         functions, since most callers want clamped.
2020
2021         * DOM/DOMHTML.mm:
2022         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
2023
2024 2017-10-31  Tim Horton  <timothy_horton@apple.com>
2025
2026         Fix up some content filtering feature flags
2027         https://bugs.webkit.org/show_bug.cgi?id=179079
2028
2029         Reviewed by Simon Fraser.
2030
2031         * Configurations/FeatureDefines.xcconfig:
2032
2033 2017-10-28  Zalan Bujtas  <zalan@apple.com>
2034
2035         [FrameView::layout cleanup] Move core layout logic to a separate class.
2036         https://bugs.webkit.org/show_bug.cgi?id=178771
2037         <rdar://problem/35166542>
2038
2039         Reviewed by Simon Fraser.
2040
2041         Move layout code out from FrameView to LayoutContext.
2042
2043         * WebView/WebClipView.mm:
2044         (-[WebClipView _immediateScrollToPoint:]):
2045         * WebView/WebFrame.mm:
2046         (-[WebFrame layoutCount]):
2047
2048 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
2049
2050         Fix issues with WebView subframe painting
2051         https://bugs.webkit.org/show_bug.cgi?id=178842
2052         rdar://problem/34072253
2053
2054         Reviewed by Daniel Bates.
2055         
2056         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
2057         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
2058         High Sierra, so match the new signature.
2059
2060         Also rename the 'rect' param to 'displayRect' to match AppKit code.
2061
2062         * WebView/WebHTMLView.mm:
2063         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
2064         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
2065
2066 2017-10-25  Youenn Fablet  <youenn@apple.com>
2067
2068         Enable ServiceWorker to fetch resources
2069         https://bugs.webkit.org/show_bug.cgi?id=178673
2070
2071         Reviewed by Brady Eidson.
2072
2073         * WebCoreSupport/WebFrameLoaderClient.mm:
2074         (WebFrameLoaderClient::pageID const):
2075         (WebFrameLoaderClient::frameID const):
2076         (WebFrameLoaderClient::sessionID const):
2077
2078         Added implementation to the new getters.
2079         They are noop in the context of WK1.
2080
2081 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
2082
2083         Web Inspector: Enable WebKit logging configuration and display
2084         https://bugs.webkit.org/show_bug.cgi?id=177027
2085         <rdar://problem/33964767>
2086
2087         Reviewed by Joseph Pecoraro.
2088
2089         * WebCoreSupport/WebChromeClient.mm:
2090         (stringForMessageSource): Deal with Media and WebRTC message sources.
2091
2092 2017-10-20  Antoine Quint  <graouts@apple.com>
2093
2094         [Web Animations] Provide basic timeline and animation interfaces
2095         https://bugs.webkit.org/show_bug.cgi?id=178526
2096
2097         Reviewed by Dean Jackson.
2098
2099         Remove the WEB_ANIMATIONS compile-time flag.
2100
2101         * Configurations/FeatureDefines.xcconfig:
2102         * WebView/WebPreferences.mm:
2103         (+[WebPreferences initialize]):
2104         * WebView/WebView.mm:
2105         (-[WebView _preferencesChanged:]):
2106
2107 2017-10-19  Sam Weinig  <sam@webkit.org>
2108
2109         [Settings] Move global settings into their own file
2110         https://bugs.webkit.org/show_bug.cgi?id=178512
2111
2112         Reviewed by Darin Adler.
2113
2114         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
2115
2116         * WebCoreSupport/WebChromeClient.mm:
2117         (WebChromeClient::supportsVideoFullscreen):
2118         * WebView/WebDynamicScrollBarsView.mm:
2119         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
2120         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
2121         * WebView/WebPreferences.mm:
2122         (+[WebPreferences initialize]):
2123         * WebView/WebView.mm:
2124         (-[WebView _commonInitializationWithFrameName:groupName:]):
2125         (-[WebView _preferencesChanged:]):
2126         (+[WebView _doNotStartObservingNetworkReachability]):
2127
2128 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
2129
2130         Replace some stack raw pointers with RefPtrs within WebCore/html
2131         https://bugs.webkit.org/show_bug.cgi?id=178201
2132         <rdar://problem/34841692>
2133
2134         Reviewed by Ryosuke Niwa.
2135
2136         * DOM/DOM.mm:
2137         (kit):
2138         Change the type of node as toNode() is changed to return RefPtr.
2139
2140 2017-10-18  Chris Dumez  <cdumez@apple.com>
2141
2142         [Service Worker] Add stubs for Client / WindowClient / Clients
2143         https://bugs.webkit.org/show_bug.cgi?id=178469
2144
2145         Reviewed by Youenn Fablet.
2146
2147         Rename PageVisiblityState to VisibilityState.
2148
2149         * WebView/WebView.mm:
2150         (kit):
2151
2152 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2153
2154         Unreviewed, rolling out r223291.
2155
2156         See WebCore ChangeLog for more detail.
2157
2158         Reverted changeset:
2159
2160         "Remove Editor::simplifyMarkup"
2161         https://bugs.webkit.org/show_bug.cgi?id=178271
2162         https://trac.webkit.org/changeset/223291
2163
2164 2017-10-17  Keith Miller  <keith_miller@apple.com>
2165
2166         Change WebCore sources to work with unified source builds
2167         https://bugs.webkit.org/show_bug.cgi?id=178229
2168
2169         Rubber stamped by Tim Horton.
2170
2171         * Configurations/FeatureDefines.xcconfig:
2172
2173 2017-10-16  Sam Weinig  <sam@webkit.org>
2174
2175         [Settings] Remove all custom code from Settings.h/cpp
2176         https://bugs.webkit.org/show_bug.cgi?id=178330
2177
2178         Reviewed by Simon Fraser.
2179
2180         * WebView/WebPreferences.mm:
2181         (+[WebPreferences initialize]):
2182         
2183             Update for naming changes of FrameFlattening now that it is an enum class.
2184
2185 2017-10-13  Alex Christensen  <achristensen@webkit.org>
2186
2187         Remove Editor::simplifyMarkup
2188         https://bugs.webkit.org/show_bug.cgi?id=178271
2189
2190         Reviewed by Wenson Hsieh.
2191
2192         * WebView/WebView.mm:
2193         (-[WebView _simplifyMarkup:endNode:]):
2194
2195 2017-10-12  Chris Dumez  <cdumez@apple.com>
2196
2197         [Mac] Add support for MouseEvent.buttons
2198         https://bugs.webkit.org/show_bug.cgi?id=178214
2199
2200         Reviewed by Ryosuke Niwa.
2201
2202         * WebView/WebPDFView.mm:
2203         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2204
2205 2017-10-11  Sam Weinig  <sam@webkit.org>
2206
2207         Remove out-parameter variants of copyToVector
2208         https://bugs.webkit.org/show_bug.cgi?id=178155
2209
2210         Reviewed by Tim Horton.
2211
2212         * Plugins/WebNetscapePluginView.mm:
2213         (-[WebNetscapePluginView destroyPlugin]):
2214         * WebView/WebHTMLRepresentation.mm:
2215         (newArrayWithStrings):
2216
2217             Replace out-parameter based copyToVector, with one that returns a Vector.
2218
2219 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
2220
2221         Sanitize URL in pasteboard for other applications and cross origin content
2222         https://bugs.webkit.org/show_bug.cgi?id=178060
2223         <rdar://problem/34874518>
2224
2225         Reviewed by Wenson Hsieh.
2226
2227         * WebCoreSupport/WebPlatformStrategies.h:
2228         * WebCoreSupport/WebPlatformStrategies.mm:
2229         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
2230
2231 2017-10-11  Chris Dumez  <cdumez@apple.com>
2232
2233         Modernize Geolocation code
2234         https://bugs.webkit.org/show_bug.cgi?id=178148
2235
2236         Reviewed by Ryosuke Niwa.
2237
2238         * WebCoreSupport/WebGeolocationClient.h:
2239         * WebCoreSupport/WebGeolocationClient.mm:
2240         (WebGeolocationClient::lastPosition):
2241         * WebView/WebGeolocationPosition.mm:
2242         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
2243         (core):
2244         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
2245         (-[WebGeolocationPosition initWithGeolocationPosition:]):
2246         * WebView/WebGeolocationPositionInternal.h:
2247
2248 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
2249
2250         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
2251         https://bugs.webkit.org/show_bug.cgi?id=178154
2252
2253         Reviewed by Wenson Hsieh.
2254
2255         Enable custom pasteboard data by default.
2256
2257         * WebView/WebPreferenceKeysPrivate.h:
2258         * WebView/WebPreferences.mm:
2259         (+[WebPreferences initialize]):
2260         (-[WebPreferences customPasteboardDataEnabled]): Added.
2261         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
2262         * WebView/WebPreferencesPrivate.h:
2263         * WebView/WebView.mm:
2264         (-[WebView _preferencesChanged:]):
2265
2266 2017-10-10  Sam Weinig  <sam@webkit.org>
2267
2268         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
2269         https://bugs.webkit.org/show_bug.cgi?id=178102
2270
2271         Reviewed by Tim Horton.
2272
2273         * History/WebHistory.mm:
2274         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
2275         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2276         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
2277         * WebCoreSupport/WebUserMediaClient.mm:
2278         (WebUserMediaClient::pageDestroyed):
2279
2280 2017-10-09  Robin Morisset  <rmorisset@apple.com>
2281
2282         Make the names of the options consistent
2283         https://bugs.webkit.org/show_bug.cgi?id=177933
2284
2285         Reviewed by Saam Barati.
2286
2287         * WebView/WebFrame.h:
2288         * WebView/WebHTMLView.mm:
2289         (-[WebHTMLView setMarkedText:selectedRange:]):
2290         * WebView/WebView.h:
2291
2292 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2293
2294         [iOS] Tweak support for classifying form controls (followup to r222487)
2295         https://bugs.webkit.org/show_bug.cgi?id=177917
2296         <rdar://problem/34820122>
2297
2298         Reviewed by Dean Jackson.
2299
2300         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
2301
2302         * DOM/DOMHTMLInputElement.mm:
2303         (-[DOMHTMLInputElement _autofillContext]):
2304         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
2305         (-[DOMHTMLInputElement representingPageURL]): Deleted.
2306
2307 2017-10-05  Keith Miller  <keith_miller@apple.com>
2308
2309         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
2310
2311         * Configurations/WebKitLegacy.xcconfig:
2312
2313 2017-10-05  Jer Noble  <jer.noble@apple.com>
2314
2315         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
2316         https://bugs.webkit.org/show_bug.cgi?id=177261
2317
2318         Reviewed by Eric Carlson.
2319
2320         * Configurations/FeatureDefines.xcconfig:
2321
2322 2017-10-05  Chris Dumez  <cdumez@apple.com>
2323
2324         Drop unused parameters for CookiesStrategy::cookiesEnabled()
2325         https://bugs.webkit.org/show_bug.cgi?id=177957
2326
2327         Reviewed by Alex Christensen.
2328
2329         * WebCoreSupport/WebPlatformStrategies.h:
2330         * WebCoreSupport/WebPlatformStrategies.mm:
2331         (WebPlatformStrategies::cookiesEnabled):
2332
2333 2017-10-05  Youenn Fablet  <youenn@apple.com>
2334
2335         Make LibWebRTCProvider port agnostic
2336         https://bugs.webkit.org/show_bug.cgi?id=177747
2337
2338         Reviewed by Alex Christensen & Alex Garcia.
2339
2340         * WebView/WebView.mm:
2341         (-[WebView _commonInitializationWithFrameName:groupName:]):
2342         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2343
2344 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2345
2346         Stop linking with WebKitSystemInterface
2347         https://bugs.webkit.org/show_bug.cgi?id=177915
2348
2349         Reviewed by Antti Koivisto.
2350
2351         * Configurations/DebugRelease.xcconfig:
2352         * Configurations/WebKitLegacy.xcconfig:
2353
2354 2017-10-04  Alex Christensen  <achristensen@webkit.org>
2355
2356         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
2357         https://bugs.webkit.org/show_bug.cgi?id=177912
2358
2359         Reviewed by Saam Barati.
2360
2361         * Carbon/CarbonUtils.m:
2362         * Carbon/CarbonWindowAdapter.mm:
2363         * Carbon/HIWebView.mm:
2364         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2365         * Misc/WebNSFileManagerExtras.mm:
2366         * Misc/WebNSPasteboardExtras.mm:
2367         * Misc/WebNSURLExtras.mm:
2368         * Plugins/Hosted/HostedNetscapePluginStream.mm:
2369         * Plugins/Hosted/NetscapePluginHostManager.mm:
2370         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2371         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2372         * Plugins/Hosted/WebHostedNetscapePluginView.h:
2373         * Plugins/Hosted/WebTextInputWindowController.m:
2374         * Plugins/WebBaseNetscapePluginView.mm:
2375         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
2376         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
2377         * Plugins/WebNetscapePluginStream.mm:
2378         * Plugins/WebNetscapePluginView.mm:
2379         * Plugins/WebPluginDatabase.mm:
2380         * WebCoreSupport/PopupMenuMac.mm:
2381         * WebCoreSupport/WebChromeClient.mm:
2382         * WebCoreSupport/WebFrameLoaderClient.mm:
2383         * WebCoreSupport/WebInspectorClient.mm:
2384         * WebCoreSupport/WebPlatformStrategies.mm:
2385         * WebCoreSupport/WebSystemInterface.mm:
2386         * WebView/WebDynamicScrollBarsView.mm:
2387         * WebView/WebFrame.mm:
2388         * WebView/WebFrameView.mm:
2389         * WebView/WebFullScreenController.mm:
2390         * WebView/WebHTMLView.mm:
2391         * WebView/WebPreferences.mm:
2392         * WebView/WebView.mm:
2393
2394 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
2395
2396         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
2397         rdar://problem/34705779
2398
2399         Addressing review comments that I somehow landed without.
2400
2401         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
2402
2403 2017-09-29  Chris Dumez  <cdumez@apple.com>
2404
2405         Split some logic out of VisitedLinkStore and make it reusable
2406         https://bugs.webkit.org/show_bug.cgi?id=177575
2407
2408         Reviewed by Alex Christensen.
2409
2410         * WebCoreSupport/WebVisitedLinkStore.h:
2411         * WebCoreSupport/WebVisitedLinkStore.mm:
2412         (WebVisitedLinkStore::addVisitedLink):
2413         (WebVisitedLinkStore::removeVisitedLink):
2414         (WebVisitedLinkStore::isLinkVisited):
2415         (WebVisitedLinkStore::addVisitedLinkHash):
2416
2417 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
2418
2419         Build fix for High Sierra 32 bit Mac
2420         https://bugs.webkit.org/show_bug.cgi?id=177551
2421         <rdar://problem/34690283>
2422
2423         Reviewed by Alexey Proskuryakov.
2424
2425         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2426         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2427         also made.
2428
2429         * Carbon/CarbonWindowAdapter.mm:
2430         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2431         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2432         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2433         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2434         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2435         (-[CarbonWindowAdapter dealloc]):
2436         (-[CarbonWindowAdapter windowRef]):
2437         (-[CarbonWindowAdapter _hasWindowRef]):
2438         (-[CarbonWindowAdapter _managesWindowRef]):
2439         (-[CarbonWindowAdapter _removeWindowRef]):
2440         (-[CarbonWindowAdapter _carbonWindowClass]):
2441         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2442         (-[CarbonWindowAdapter sendSuperEvent:]):
2443         (-[CarbonWindowAdapter relinquishFocus]):
2444         (-[CarbonWindowAdapter _cancelKey:]):
2445         (-[CarbonWindowAdapter _commonAwake]):
2446         (-[CarbonWindowAdapter _destroyRealWindow:]):
2447         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2448         (-[CarbonWindowAdapter _termWindowIfOwner]):
2449         (-[CarbonWindowAdapter _windowMovedToRect:]):
2450         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2451         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2452         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2453         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2454         (-[CarbonWindowAdapter canBecomeMainWindow]):
2455         (-[CarbonWindowAdapter encodeWithCoder:]):
2456         (-[CarbonWindowAdapter initWithCoder:]):
2457         (-[CarbonWindowAdapter setContentView:]):
2458         (-[CarbonWindowAdapter worksWhenModal]):
2459         (-[CarbonWindowAdapter _setModalWindowLevel]):
2460         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2461         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2462         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2463         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2464         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2465         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2466         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2467         (NSCarbonWindowHandleEvent):
2468         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2469         (-[CarbonWindowAdapter _growBoxRect]):
2470         * Carbon/HIWebView.mm:
2471         (HIWebViewGetWebView):
2472         (HIWebViewConstructor):
2473         (HIWebViewDestructor):
2474         (HIWebViewRegisterClass):
2475         (GetBehaviors):
2476         (Draw):
2477         (HitTest):
2478         (GetRegion):
2479         (GetWindowRef):
2480         (CreateNSEventAdoptingCGEvent):
2481         (CopyEventCGEvent):
2482         (CreateNSEventWithCarbonClickEvent):
2483         (Click):
2484         (CreateNSEventWithCarbonEvent):
2485         (MouseUp):
2486         (CreateNSEventWithCarbonMouseMoveEvent):
2487         (MouseMoved):
2488         (MouseDragged):
2489         (MouseWheelMoved):
2490         (ContextMenuClick):
2491         (GetKind):
2492         (BoundsChanged):
2493         (OwningWindowChanged):
2494         (WindowHandler):
2495         (SyncFrame):
2496         (SetFocusPart):
2497         (AdvanceFocus):
2498         (RelinquishFocus):
2499         (ActiveStateChanged):
2500         (ProcessCommand):
2501         (UpdateCommandStatus):
2502         (_NSSelectorForHICommand):
2503         (HIWebViewEventHandler):
2504         (StartUpdateObserver):
2505         (StopUpdateObserver):
2506         (UpdateObserver):
2507
2508 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2509
2510         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
2511         https://bugs.webkit.org/show_bug.cgi?id=172526
2512         <rdar://problem/32396081>
2513
2514         Reviewed by Ryosuke Niwa.
2515
2516         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
2517
2518         * WebCoreSupport/WebPlatformStrategies.h:
2519         * WebCoreSupport/WebPlatformStrategies.mm:
2520         (WebPlatformStrategies::webExposedTypes):
2521         (WebPlatformStrategies::writeCustomData):
2522
2523 2017-09-27  Matt Lewis  <jlewis3@apple.com>
2524
2525         Unreviewed, rolling out r222567.
2526
2527         This broke and internal build.
2528
2529         Reverted changeset:
2530
2531         "Build fix for High Sierra 32 bit Mac"
2532         https://bugs.webkit.org/show_bug.cgi?id=177551
2533         http://trac.webkit.org/changeset/222567
2534
2535 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
2536
2537         Build fix for High Sierra 32 bit Mac
2538         https://bugs.webkit.org/show_bug.cgi?id=177551
2539         <rdar://problem/34690283>
2540
2541         Reviewed by Alexey Proskuryakov.
2542
2543         Some assertions have been removed from the SDK. Replace these assertions with equivalent
2544         WTF assert code.  Since the files in this patch are using tabs, some style changes were
2545         also made.
2546
2547         * Carbon/CarbonWindowAdapter.mm:
2548         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
2549         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
2550         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
2551         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
2552         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
2553         (-[CarbonWindowAdapter dealloc]):
2554         (-[CarbonWindowAdapter windowRef]):
2555         (-[CarbonWindowAdapter _hasWindowRef]):
2556         (-[CarbonWindowAdapter _managesWindowRef]):
2557         (-[CarbonWindowAdapter _removeWindowRef]):
2558         (-[CarbonWindowAdapter _carbonWindowClass]):
2559         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
2560         (-[CarbonWindowAdapter sendSuperEvent:]):
2561         (-[CarbonWindowAdapter relinquishFocus]):
2562         (-[CarbonWindowAdapter _cancelKey:]):
2563         (-[CarbonWindowAdapter _commonAwake]):
2564         (-[CarbonWindowAdapter _destroyRealWindow:]):
2565         (-[CarbonWindowAdapter _oldPlaceWindow:]):
2566         (-[CarbonWindowAdapter _termWindowIfOwner]):
2567         (-[CarbonWindowAdapter _windowMovedToRect:]):
2568         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
2569         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
2570         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
2571         (-[CarbonWindowAdapter canBecomeKeyWindow]):
2572         (-[CarbonWindowAdapter canBecomeMainWindow]):
2573         (-[CarbonWindowAdapter encodeWithCoder:]):
2574         (-[CarbonWindowAdapter initWithCoder:]):
2575         (-[CarbonWindowAdapter setContentView:]):
2576         (-[CarbonWindowAdapter worksWhenModal]):
2577         (-[CarbonWindowAdapter _setModalWindowLevel]):
2578         (-[CarbonWindowAdapter _clearModalWindowLevel]):
2579         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
2580         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
2581         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
2582         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
2583         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
2584         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
2585         (NSCarbonWindowHandleEvent):
2586         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
2587         (-[CarbonWindowAdapter _growBoxRect]):
2588         * Carbon/HIWebView.mm:
2589         (HIWebViewGetWebView):
2590         (HIWebViewConstructor):
2591         (HIWebViewDestructor):
2592         (HIWebViewRegisterClass):
2593         (GetBehaviors):
2594         (Draw):
2595         (HitTest):
2596         (GetRegion):
2597         (GetWindowRef):
2598         (CreateNSEventAdoptingCGEvent):
2599         (CopyEventCGEvent):
2600         (CreateNSEventWithCarbonClickEvent):
2601         (Click):
2602         (CreateNSEventWithCarbonEvent):
2603         (MouseUp):
2604         (CreateNSEventWithCarbonMouseMoveEvent):
2605         (MouseMoved):
2606         (MouseDragged):
2607         (MouseWheelMoved):
2608         (ContextMenuClick):
2609         (GetKind):
2610         (BoundsChanged):
2611         (OwningWindowChanged):
2612         (WindowHandler):
2613         (SyncFrame):
2614         (SetFocusPart):
2615         (AdvanceFocus):
2616         (RelinquishFocus):
2617         (ActiveStateChanged):
2618         (ProcessCommand):
2619         (UpdateCommandStatus):
2620         (_NSSelectorForHICommand):
2621         (HIWebViewEventHandler):
2622         (StartUpdateObserver):
2623         (StopUpdateObserver):
2624         (UpdateObserver):
2625
2626 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2627
2628         Make PolicyAction an encodable enum class
2629         https://bugs.webkit.org/show_bug.cgi?id=177480
2630
2631         Reviewed by Antti Koivisto.
2632
2633         * Plugins/WebPluginContainerCheck.mm:
2634         (-[WebPluginContainerCheck _continueWithPolicy:]):
2635         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2636         * WebCoreSupport/WebFrameLoaderClient.mm:
2637         (-[WebFramePolicyListener invalidate]):
2638         (-[WebFramePolicyListener ignore]):
2639         (-[WebFramePolicyListener download]):
2640         (-[WebFramePolicyListener use]):
2641         (-[WebFramePolicyListener continue]):
2642         * WebView/WebPolicyDelegate.mm:
2643         (-[WebPolicyDecisionListener use]):
2644         (-[WebPolicyDecisionListener ignore]):
2645         (-[WebPolicyDecisionListener download]):
2646
2647 2017-09-25  Frederik Riedel  <riedel@apple.com>
2648
2649         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
2650         https://bugs.webkit.org/show_bug.cgi?id=174394
2651         <rdar://problem/33183504>
2652
2653         Reviewed by Ryosuke Niwa.
2654
2655         * DOM/DOMHTMLInputElement.h:
2656         * DOM/DOMHTMLInputElement.mm:
2657         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
2658         Determines if this HTMLInputElement is part of a login screen.
2659         (-[DOMHTMLInputElement representingPageUrl]):
2660         Returns the webpage's URL that is currently displayed in the Web View.
2661         (-[DOMHTMLInputElement insertTextSuggestion:]):
2662         Inserts login credentials into the Web View.
2663
2664 2017-09-25  Sam Weinig  <sam@webkit.org>
2665
2666         Remove unused EditorClient functions
2667         https://bugs.webkit.org/show_bug.cgi?id=177463
2668
2669         Reviewed by Alex Christensen.
2670
2671         Remove unused EditorClient functions.
2672
2673         * WebCoreSupport/WebEditorClient.h:
2674         * WebCoreSupport/WebEditorClient.mm:
2675         (WebEditorClient::canonicalizeURL): Deleted.
2676         (WebEditorClient::canonicalizeURLString): Deleted.
2677         (WebEditorClient::writeDataToPasteboard): Deleted.
2678         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
2679         (WebEditorClient::readDataFromPasteboard): Deleted.
2680         (WebEditorClient::pasteboardChangeCount): Deleted.
2681
2682 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2683
2684         Stop using PolicyCallback
2685         https://bugs.webkit.org/show_bug.cgi?id=176088
2686
2687         Reviewed by Andy Estes.
2688
2689         * WebCoreSupport/WebFrameLoaderClient.mm:
2690         (-[WebFramePolicyListener invalidate]):
2691         (-[WebFramePolicyListener receivedPolicyDecision:]):
2692
2693 2017-09-25  Sam Weinig  <sam@webkit.org>
2694
2695         Remove unnecessary userVisibleString EditorClient function
2696         https://bugs.webkit.org/show_bug.cgi?id=177456
2697
2698         Reviewed by Dan Bernstein.
2699
2700         * WebCoreSupport/WebEditorClient.h:
2701         * WebCoreSupport/WebEditorClient.mm:
2702         (WebEditorClient::userVisibleString): Deleted.
2703
2704             Remove userVisibleString client function.
2705
2706 2017-09-25  Alex Christensen  <achristensen@webkit.org>
2707
2708         Separate form submission from PolicyChecker infrastructure
2709         https://bugs.webkit.org/show_bug.cgi?id=177396
2710
2711         Reviewed by Geoffrey Garen.
2712
2713         * WebCoreSupport/WebFrameLoaderClient.h:
2714         * WebCoreSupport/WebFrameLoaderClient.mm:
2715         (WebFrameLoaderClient::dispatchWillSubmitForm):
2716
2717 2017-09-22  Zalan Bujtas  <zalan@apple.com>
2718
2719         WeakPtrFactory should populate m_ref lazily.
2720         https://bugs.webkit.org/show_bug.cgi?id=177375
2721
2722         Reviewed by Geoffrey Garen.
2723
2724         * WebCoreSupport/WebEditorClient.mm:
2725         (WebEditorClient::WebEditorClient):
2726         (WebEditorClient::requestCandidatesForSelection):
2727
2728 2017-09-22  Chris Dumez  <cdumez@apple.com>
2729
2730         Use high resolution timestamp for event time
2731         https://bugs.webkit.org/show_bug.cgi?id=154246
2732         <rdar://problem/34333304>
2733
2734         Reviewed by Ryosuke Niwa.
2735
2736         Use WallTime / MonotonicTime instead of double type for clarity.
2737
2738         * DOM/DOMEvent.mm:
2739         (-[DOMEvent timeStamp]):
2740         * WebView/WebFrame.mm:
2741         (-[WebFrame _dragSourceEndedAt:operation:]):
2742         * WebView/WebPDFView.mm:
2743         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2744
2745 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
2746
2747         Enable dataTransfer.items on macOS and iOS
2748         https://bugs.webkit.org/show_bug.cgi?id=177335
2749
2750         Reviewed by Sam Weinig.
2751
2752         * WebView/WebPreferences.mm:
2753         (+[WebPreferences initialize]):
2754
2755 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
2756
2757         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
2758         https://bugs.webkit.org/show_bug.cgi?id=177101
2759         <rdar://problem/34500648>
2760
2761         Reviewed by Brian Burg.
2762
2763         * WebInspector/WebNodeHighlight.mm:
2764         Ensure we close the window that we have just removed.
2765
2766 2017-09-20  Antti Koivisto  <antti@apple.com>
2767
2768         Remove DOM and styling support for CSS Regions
2769         https://bugs.webkit.org/show_bug.cgi?id=177221
2770
2771         Reviewed by Andreas Kling.
2772
2773         * Configurations/FeatureDefines.xcconfig:
2774         * DOM/DOMCSS.mm:
2775         (kitClass):
2776         * DOM/DOMElement.mm:
2777         (-[DOMElement webkitRegionOverset]): Deleted.
2778
2779 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
2780
2781         Layering violation in Editor::createFragment
2782         https://bugs.webkit.org/show_bug.cgi?id=176123
2783
2784         Reviewed by Darin Adler.
2785
2786         * Misc/WebNSURLExtras.h:
2787         * Misc/WebNSURLExtras.mm:
2788         * WebView/WebFrame.mm:
2789         * WebView/WebHTMLView.mm:
2790         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
2791
2792         * WebCoreSupport/WebEditorClient.mm:
2793         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
2794         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
2795         way to avoid exporting the symbol just on newer OSes.
2796
2797 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2798
2799         On iOS, getData can't get text set by setData during copy event
2800         https://bugs.webkit.org/show_bug.cgi?id=176980
2801         <rdar://problem/34453915>
2802
2803         Reviewed by Darin Adler.
2804
2805         * WebCoreSupport/WebPlatformStrategies.h:
2806         * WebCoreSupport/WebPlatformStrategies.mm:
2807         (WebPlatformStrategies::copy): Deleted.
2808
2809 2017-09-18  Andy Estes  <aestes@apple.com>
2810
2811         [Mac] Upstream miscellaneous WebKitSystemInterface functions
2812         https://bugs.webkit.org/show_bug.cgi?id=177029
2813
2814         Reviewed by Alex Christensen.
2815
2816         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2817         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
2818         * Plugins/Hosted/NetscapePluginHostProxy.mm:
2819         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
2820         * WebCoreSupport/PopupMenuMac.mm:
2821         (PopupMenuMac::show):
2822         * WebCoreSupport/WebSystemInterface.mm:
2823         (InitWebCoreSystemInterface):
2824         * WebView/WebHTMLView.mm:
2825         (-[WebHTMLView setDataSource:]):
2826         (-[WebHTMLView attachRootLayer:]):
2827         * WebView/WebView.mm:
2828         (-[WebView _needsAdobeFrameReloadingQuirk]):
2829         (-[WebView _needsLinkElementTextCSSQuirk]):
2830         (-[WebView _needsIsLoadingInAPISenseQuirk]):
2831         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
2832         (-[WebView _preferencesChanged:]):
2833
2834 2017-09-15  Andy Estes  <aestes@apple.com>
2835
2836         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
2837         https://bugs.webkit.org/show_bug.cgi?id=176953
2838
2839         Reviewed by Eric Carlson.
2840
2841         * WebCoreSupport/WebSystemInterface.mm:
2842         (InitWebCoreSystemInterface):
2843
2844 2017-09-14  Andy Estes  <aestes@apple.com>
2845
2846         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
2847         https://bugs.webkit.org/show_bug.cgi?id=176931
2848
2849         Reviewed by Joseph Pecoraro.
2850
2851         * WebCoreSupport/WebSystemInterface.mm:
2852         (InitWebCoreSystemInterface):
2853
2854 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2855
2856         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
2857         https://bugs.webkit.org/show_bug.cgi?id=176867
2858
2859         Reviewed by Sam Weinig.
2860
2861         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2862         (WebKit::NetscapePluginInstanceProxy::enumerate):
2863
2864 2017-09-13  Andy Estes  <aestes@apple.com>
2865
2866         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
2867         https://bugs.webkit.org/show_bug.cgi?id=176729
2868
2869         Reviewed by Alex Christensen.
2870
2871         * WebCoreSupport/WebSystemInterface.mm:
2872         (InitWebCoreSystemInterface):
2873         * WebView/WebView.mm:
2874         (+[WebView _setCacheModel:]):
2875
2876 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
2877
2878         Refactor WebContentReader out of EditorMac and EditorIOS
2879         https://bugs.webkit.org/show_bug.cgi?id=176770
2880
2881         Reviewed by Sam Weinig.
2882
2883         * WebCoreSupport/WebEditorClient.mm:
2884
2885 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
2886
2887         Dragging & dropping a file creates an attachment element even when it's disabled
2888         https://bugs.webkit.org/show_bug.cgi?id=176769
2889
2890         Reviewed by Tim Horton.
2891
2892         * WebView/WebView.mm:
2893         (-[WebView _preferencesChanged:]):
2894
2895 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2896
2897         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
2898         https://bugs.webkit.org/show_bug.cgi?id=176721
2899         <rdar://problem/34373660>
2900
2901         Reviewed by Tim Horton.
2902
2903         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
2904         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
2905
2906         * WebView/WebView.mm:
2907         (-[WebView _startDrag:]):
2908         (-[WebView _draggedElementBounds]):
2909         (-[WebView _endedDataInteraction:global:]):
2910         * WebView/WebViewData.h:
2911
2912 2017-09-11  Andy Estes  <aestes@apple.com>
2913
2914         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2915         https://bugs.webkit.org/show_bug.cgi?id=176472
2916
2917         Reviewed by Eric Carlson.
2918
2919         * WebCoreSupport/WebSystemInterface.mm:
2920         (InitWebCoreSystemInterface):
2921
2922 2017-09-09  Mark Lam  <mark.lam@apple.com>
2923
2924         Avoid duplicate computations of ExecState::vm().
2925         https://bugs.webkit.org/show_bug.cgi?id=176647
2926
2927         Reviewed by Saam Barati.
2928
2929         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2930         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
2931         (WebKit::NetscapePluginInstanceProxy::construct):
2932         (WebKit::NetscapePluginInstanceProxy::setProperty):
2933         (WebKit::NetscapePluginInstanceProxy::removeProperty):
2934         (WebKit::NetscapePluginInstanceProxy::enumerate):
2935         * Plugins/Hosted/ProxyInstance.mm:
2936         (WebKit::ProxyRuntimeMethod::create):
2937
2938 2017-09-08  Commit Queue  <commit-queue@webkit.org>
2939
2940         Unreviewed, rolling out r221773.
2941         https://bugs.webkit.org/show_bug.cgi?id=176614
2942
2943         This caused build failures. (Requested by mlewis13 on
2944         #webkit).
2945
2946         Reverted changeset:
2947
2948         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
2949         https://bugs.webkit.org/show_bug.cgi?id=176472
2950         http://trac.webkit.org/changeset/221773
2951
2952 2017-09-07  Andy Estes  <aestes@apple.com>
2953
2954         [Mac] Upstream QTKit-related WebKitSystemInterface functions
2955         https://bugs.webkit.org/show_bug.cgi?id=176472
2956
2957         Reviewed by Eric Carlson.
2958
2959         * WebCoreSupport/WebSystemInterface.mm:
2960         (InitWebCoreSystemInterface):
2961
2962 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
2963
2964         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
2965         https://bugs.webkit.org/show_bug.cgi?id=176561
2966
2967         Reviewed by Brent Fulgham.
2968
2969         * Misc/WebNSUserDefaultsExtras.mm:
2970
2971 2017-09-07  Alex Christensen  <achristensen@webkit.org>
2972
2973         Modernize Geolocation code
2974         https://bugs.webkit.org/show_bug.cgi?id=176496
2975
2976         Reviewed by Andy Estes.
2977
2978         * WebCoreSupport/WebGeolocationClient.h:
2979         * WebCoreSupport/WebGeolocationClient.mm:
2980         (WebGeolocationClient::requestPermission):
2981         (-[WebGeolocationPolicyListener initWithGeolocation:]):
2982         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
2983         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
2984         * WebView/WebView.mm:
2985         (-[WebView _commonInitializationWithFrameName:groupName:]):
2986         (-[WebView _geolocationDidFailWithMessage:]):
2987
2988 2017-09-05  Tim Horton  <timothy_horton@apple.com>
2989
2990         Remove some unused bits of code and resources
2991         https://bugs.webkit.org/show_bug.cgi?id=176275
2992
2993         Reviewed by Dan Bernstein.
2994
2995         * Misc/WebNSFileManagerExtras.mm:
2996         Include FileSystem instead of FileSystemIOS.
2997
2998 2017-09-03  Darin Adler  <darin@apple.com>
2999
3000         [Cocoa] Tidy a few things in legacy WebHTMLView
3001         https://bugs.webkit.org/show_bug.cgi?id=176280
3002
3003         Reviewed by Dan Bernstein.
3004
3005         * WebCoreSupport/WebChromeClient.mm:
3006         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
3007         methods it calls on WebHTMLView were doing nothing on iOS.
3008
3009         * WebView/WebFrame.mm:
3010         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
3011         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
3012
3013         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
3014         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
3015         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
3016         order. Removed all sorts of unused things. Made more code and fields Mac-only where
3017         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
3018         Use RetainPtr instead of writing retain/release wherever possible.
3019         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
3020         initialization for it. Removed various unused methods and declarations of methods.
3021         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
3022         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
3023         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
3024         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
3025         and remove CFRetain no longer needed since we don't support garbage collection any more.
3026         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
3027         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
3028         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
3029         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
3030         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
3031         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3032         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
3033         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3034         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
3035         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
3036         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
3037         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
3038         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
3039         debug flag; we haven't used it for years and it's not clearly helpful.
3040         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
3041         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
3042         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
3043         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
3044         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
3045         two additional methods in the WebPrivate category and still be called by the two
3046         methods in the WebInternal category that were already using it.
3047         (-[WebHTMLView didAddSubview:]): Deleted.
3048         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
3049         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
3050         place this was called, the close method.
3051         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
3052         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3053         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
3054         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
3055         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
3056         Added helper method to make the one below simpler.
3057         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
3058         Compared pasteboard type strings using isEqualToString: rather than using == since
3059         we want to actually compare the string contents. Also updated to use modern for loop,
3060         renamed a local variable from "s" to "localSubresources", and factored out the handling
3061         of three image types to use the helper method above.
3062         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
3063         _web_makePluginSubviewsPerformSelector:withObject: method.
3064         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
3065         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
3066         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
3067         not call the -[NSView subviews] method to make this identical on both platforms and used
3068         a modern for loop.
3069         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
3070         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
3071         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
3072         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
3073         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
3074         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
3075         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
3076         of it is Mac-only.
3077         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
3078         method did was call itself on the main thread, and do nothing if called on main thread.
3079         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
3080         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
3081         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
3082         half of this method.
3083         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
3084         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
3085         Simplified using a modern for loop and RetainPtr.
3086         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
3087         (-[WebHTMLView keyDown:]): Ditto.
3088         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
3089         (-[WebHTMLView performKeyEquivalent:]): Ditto.
3090         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
3091         (-[WebHTMLView complete:]): Ditto.
3092         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
3093         now macOS-only.
3094         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
3095         iOS since that is now macOS-only.
3096         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
3097         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
3098         a private one because it is not used or needed outside WebKit. Also made it macOS-only
3099         and reorganized to use early return.
3100         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
3101         on iOS, but kept there so we don't have to do #if at every call site.
3102         (-[WebHTMLView _pluginController]): Moved into internal category.
3103         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
3104         there only for GC, using C++ initialization, removing obsolete comment.
3105         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
3106         peculiar iOS-only comment.
3107         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
3108
3109         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
3110         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
3111         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
3112         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
3113         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
3114
3115         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
3116         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
3117         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
3118         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
3119         them at this time.
3120
3121 2017-09-03  Sam Weinig  <sam@webkit.org>
3122
3123         Remove CanvasProxy
3124         https://bugs.webkit.org/show_bug.cgi?id=176288
3125
3126         Reviewed by Yusuke Suzuki.
3127
3128         CanvasProxy does not appear to be in any current HTML spec
3129         and was disabled and unimplemented in our tree. Time to 
3130         get rid of it.
3131
3132         * Configurations/FeatureDefines.xcconfig:
3133
3134 2017-09-02  Andy Estes  <aestes@apple.com>
3135
3136         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
3137         https://bugs.webkit.org/show_bug.cgi?id=176270
3138
3139         Reviewed by Tim Horton.
3140
3141         * Plugins/Hosted/NetscapePluginHostManager.mm:
3142         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3143         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3144         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3145         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
3146         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
3147         (WebKit::SoftwareCARenderer::context const):
3148         (WebKit::SoftwareCARenderer::renderContext const):
3149         (WebKit::SoftwareCARenderer::render):
3150         (-[WebHostedNetscapePluginView createPlugin]):
3151         (-[WebHostedNetscapePluginView createPluginLayer]):
3152         (-[WebHostedNetscapePluginView destroyPlugin]):
3153         (-[WebHostedNetscapePluginView drawRect:]):
3154         * WebCoreSupport/WebSystemInterface.mm:
3155         (InitWebCoreSystemInterface):
3156
3157 2017-09-01  Andy Estes  <aestes@apple.com>
3158
3159         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
3160         https://bugs.webkit.org/show_bug.cgi?id=176200
3161
3162         Reviewed by Tim Horton.
3163
3164         * Carbon/HIWebView.mm:
3165         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
3166         (overrideCGContext):
3167         (restoreCGContext):
3168         (Draw):
3169         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3170         (+[WebHostedNetscapePluginView initialize]):
3171         * Plugins/WebBaseNetscapePluginView.h:
3172         * Plugins/WebBaseNetscapePluginView.mm:
3173         (WebKit::sendUserChangeNotifications):
3174         * Plugins/WebNetscapePluginView.mm:
3175         (+[WebNetscapePluginView initialize]):
3176         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3177         * WebCoreSupport/WebSystemInterface.mm:
3178         (InitWebCoreSystemInterface):
3179         * WebView/WebFrame.mm:
3180         (-[WebFrame _paintBehaviorForDestinationContext:]):
3181         * WebView/WebFullScreenController.mm:
3182         (setClipRectForWindow):
3183         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3184         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3185         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3186         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3187
3188 2017-08-31  Andy Estes  <aestes@apple.com>
3189
3190         [Mac] Upstream AppKit-related WebKitSystemInterface functions
3191         https://bugs.webkit.org/show_bug.cgi?id=176175
3192
3193         Reviewed by Brady Eidson.
3194
3195         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3196         (WebKit::NetscapePluginInstanceProxy::keyEvent):
3197         * Plugins/Hosted/WebTextInputWindowController.m:
3198         (-[WebTextInputPanel init]):
3199         * WebCoreSupport/WebSystemInterface.mm:
3200         (InitWebCoreSystemInterface):
3201         * WebView/WebDynamicScrollBarsView.mm:
3202         (-[WebDynamicScrollBarsView scrollWheel:]):
3203         * WebView/WebHTMLView.mm:
3204         (-[WebHTMLView _removeWindowObservers]):
3205         (-[WebHTMLView addWindowObservers]):
3206         * WebView/WebView.mm:
3207         (-[WebView addWindowObserversForWindow:]):
3208         (-[WebView removeWindowObservers]):
3209         (-[WebView viewWillMoveToWindow:]):
3210
3211 2017-08-31  Alex Christensen  <achristensen@webkit.org>
3212
3213         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
3214         https://bugs.webkit.org/show_bug.cgi?id=175779
3215         <rdar://problem/22367975>
3216
3217         Reviewed by Tim Horton.
3218
3219         * WebCoreSupport/WebFrameLoaderClient.h:
3220         * WebCoreSupport/WebFrameLoaderClient.mm:
3221         (WebFrameLoaderClient::webGLPolicyForURL const):
3222         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
3223
3224 2017-08-30  Andy Estes  <aestes@apple.com>
3225
3226         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
3227         https://bugs.webkit.org/show_bug.cgi?id=176093
3228
3229         Reviewed by Eric Carlson.
3230
3231         * WebCoreSupport/WebSystemInterface.mm:
3232         (InitWebCoreSystemInterface):
3233
3234 2017-08-30  Andy Estes  <aestes@apple.com>
3235
3236         [Mac] Upstream Carbon-related WebKitSystemInterface functions
3237         https://bugs.webkit.org/show_bug.cgi?id=176087
3238
3239         Reviewed by Alex Christensen.
3240
3241         * Carbon/CarbonUtils.m:
3242         (getNSAutoreleasePoolCount):
3243         (WebInitForCarbon):
3244         (PoolCleaner):
3245         * Carbon/CarbonWindowAdapter.mm:
3246         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
3247         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3248         (-[CarbonWindowAdapter _oldPlaceWindow:]):
3249         (-[CarbonWindowAdapter _windowMovedToRect:]):
3250         * Carbon/HIViewAdapter.m:
3251         * Carbon/HIWebView.mm:
3252         (Draw):
3253         (CreateNSEventAdoptingCGEvent):
3254         (CopyEventCGEvent):
3255         (CreateNSEventWithCarbonClickEvent):
3256         (Click):
3257         (CreateNSEventWithCarbonEvent):
3258         (MouseUp):
3259         (CreateNSEventWithCarbonMouseMoveEvent):
3260         (MouseMoved):
3261         (MouseDragged):
3262         (MouseWheelMoved):
3263         (WindowHandler):
3264         (HIWebViewEventHandler):
3265         * Misc/QuickDrawCompatibility.h: Removed.
3266         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
3267         (getCarbonEvent):
3268         (WebNetscapePluginEventHandlerCarbon::keyDown):
3269         (WebNetscapePluginEventHandlerCarbon::keyUp):
3270         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3271         (WebNetscapePluginEventHandlerCocoa::keyDown):
3272         * Plugins/WebNetscapePluginView.mm:
3273         (-[WebNetscapePluginView tellQuickTimeToChill]):
3274
3275 2017-08-29  Andy Estes  <aestes@apple.com>
3276
3277         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
3278         https://bugs.webkit.org/show_bug.cgi?id=176046
3279
3280         Reviewed by Alex Christensen.
3281
3282         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
3283         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
3284
3285         * Misc/WebNSFileManagerExtras.mm:
3286         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
3287         (setMetaData): Deleted.
3288         * WebCoreSupport/WebSystemInterface.mm:
3289         (InitWebCoreSystemInterface):
3290
3291 2017-08-28  Andy Estes  <aestes@apple.com>
3292
3293         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
3294         https://bugs.webkit.org/show_bug.cgi?id=176039
3295
3296         Reviewed by Alex Christensen.
3297
3298         * WebCoreSupport/WebSystemInterface.mm:
3299         (InitWebCoreSystemInterface):
3300         * WebView/WebPreferences.mm:
3301         (+[WebPreferences _systemCFStringEncoding]):
3302
3303 2017-08-28  Andy Estes  <aestes@apple.com>
3304
3305         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
3306         https://bugs.webkit.org/show_bug.cgi?id=176032
3307
3308         Reviewed by Alex Christensen.
3309
3310         * WebCoreSupport/WebSystemInterface.mm:
3311         (InitWebCoreSystemInterface):
3312         * WebView/WebView.mm:
3313         (-[WebView _cachedResponseForURL:]):
3314
3315 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
3316
3317         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
3318         https://bugs.webkit.org/show_bug.cgi?id=175992
3319         <rdar://problem/34086613>
3320
3321         Reviewed by Daniel Bates.
3322
3323         * WebCoreSupport/WebPlatformStrategies.h:
3324         * WebCoreSupport/WebPlatformStrategies.mm:
3325         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
3326         cookies should be included, and return a pair containing the resulting cookie string and a boolean
3327         indicating if secure cookies were accessed.
3328
3329 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3330
3331         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
3332         https://bugs.webkit.org/show_bug.cgi?id=170955
3333         <rdar://problem/31697653>
3334
3335         Reviewed by Ryosuke Niwa.
3336
3337         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
3338         text is being replaced.
3339
3340         * WebView/WebHTMLView.mm:
3341         (-[WebHTMLView insertText:]):
3342
3343 2017-08-24  Chris Dumez  <cdumez@apple.com>
3344
3345         [Directory Upload] Add basic support for input.webkitdirectory
3346         https://bugs.webkit.org/show_bug.cgi?id=175950
3347         <rdar://problem/33951915>
3348
3349         Reviewed by Geoffrey Garen.
3350
3351         Add private API to toggle Directory Upload support on Mac WebKit1.
3352
3353         * WebView/WebPreferenceKeysPrivate.h:
3354         * WebView/WebPreferences.mm:
3355         (+[WebPreferences initialize]):
3356         (-[WebPreferences setDirectoryUploadEnabled:]):
3357         (-[WebPreferences directoryUploadEnabled]):
3358         * WebView/WebPreferencesPrivate.h:
3359         * WebView/WebView.mm:
3360         (-[WebView _preferencesChanged:]):
3361
3362 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3363
3364         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
3365         https://bugs.webkit.org/show_bug.cgi?id=175370
3366         <rdar://problem/33799806>
3367
3368         Reviewed by Ryosuke Niwa.
3369
3370         Adjust WebEditorClient for interface changes.
3371
3372         * WebCoreSupport/WebEditorClient.h:
3373
3374 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3375
3376         Remove ChromeClient::scrollbarsModeDidChange
3377         https://bugs.webkit.org/show_bug.cgi?id=175805
3378
3379         Reviewed by Daniel Bates.
3380
3381         * WebCoreSupport/WebChromeClient.h:
3382
3383 2017-08-22  Alex Christensen  <achristensen@webkit.org>
3384
3385         Remove ChromeClient::hasOpenedPopup
3386         https://bugs.webkit.org/show_bug.cgi?id=175804
3387
3388         Reviewed by Sam Weinig.
3389
3390         * WebCoreSupport/WebChromeClient.h:
3391         * WebCoreSupport/WebChromeClient.mm:
3392         (WebChromeClient::hasOpenedPopup const): Deleted.
3393
3394 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
3395
3396         Disable access to secure cookies if an HTTPS site loads mixed content
3397         https://bugs.webkit.org/show_bug.cgi?id=157053
3398         <rdar://problem/11290808>
3399
3400         Reviewed by Dan Bates.
3401
3402         * WebCoreSupport/WebPlatformStrategies.h:
3403         * WebCoreSupport/WebPlatformStrategies.mm:
3404         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
3405         indicating whether secure cookies should be included in the response.
3406
3407 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3408
3409         [PAL] Move spi/mac directory into PAL
3410         https://bugs.webkit.org/show_bug.cgi?id=175649
3411
3412         Reviewed by Myles C. Maxfield.
3413
3414         * Misc/WebSharingServicePickerController.h:
3415         * WebCoreSupport/WebContextMenuClient.mm:
3416         * WebCoreSupport/WebEditorClient.mm:
3417         * WebCoreSupport/WebSelectionServiceController.mm:
3418         * WebView/WebHTMLView.mm:
3419         * WebView/WebImmediateActionController.h:
3420         * WebView/WebImmediateActionController.mm:
3421         * WebView/WebView.mm:
3422
3423 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3424
3425         [PAL] Relocate SessionID to root
3426         https://bugs.webkit.org/show_bug.cgi?id=175684
3427
3428         Reviewed by Alex Christensen.
3429
3430         * WebCoreSupport/WebFrameNetworkingContext.mm:
3431
3432 2017-08-17  Andreas Kling  <akling@apple.com>
3433
3434         Disable CSS regions at compile time
3435         https://bugs.webkit.org/show_bug.cgi?id=175630
3436
3437         Reviewed by Antti Koivisto.
3438
3439         * Configurations/FeatureDefines.xcconfig:
3440
3441 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
3442
3443         [PAL] Move SessionID into PAL
3444         https://bugs.webkit.org/show_bug.cgi?id=174192
3445
3446         Reviewed by Antti Koivisto.
3447
3448         * Misc/WebCache.mm:
3449         (+[WebCache imageForURL:]):
3450         * WebCoreSupport/WebFrameLoaderClient.h:
3451         * WebCoreSupport/WebFrameLoaderClient.mm:
3452         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3453         * WebCoreSupport/WebFrameNetworkingContext.mm:
3454         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
3455         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
3456         (WebFrameNetworkingContext::storageSession const):
3457         * WebCoreSupport/WebPlatformStrategies.h:
3458         * WebCoreSupport/WebPlatformStrategies.mm:
3459         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
3460         * WebKitPrefix.h:
3461
3462 2017-08-16  Andy Estes  <aestes@apple.com>
3463
3464         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
3465         https://bugs.webkit.org/show_bug.cgi?id=175648
3466
3467         Reviewed by Tim Horton.
3468
3469         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3470         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3471         (WebPaymentCoordinatorClient::showPaymentUI):
3472
3473 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3474
3475         [PAL] Move spi/ios and spi/win directories into PAL
3476         https://bugs.webkit.org/show_bug.cgi?id=175171
3477
3478         Reviewed by Antti Koivisto.
3479
3480         * WebCoreSupport/WebFrameLoaderClient.mm:
3481         * WebView/WebView.mm:
3482
3483 2017-08-16  Andy Estes  <aestes@apple.com>
3484
3485         [Payment Request] Add an ENABLE flag and an experimental feature preference
3486         https://bugs.webkit.org/show_bug.cgi?id=175622
3487
3488         Reviewed by Tim Horton.
3489
3490         * Configurations/FeatureDefines.xcconfig:
3491
3492 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
3493
3494         [PAL] Move Sleep classes into PAL
3495         https://bugs.webkit.org/show_bug.cgi?id=175456
3496
3497         Reviewed by Ryosuke Niwa.
3498
3499         * WebView/WebFullScreenController.h:
3500
3501 2017-08-15  Youenn Fablet  <youenn@apple.com>
3502
3503         [Cache API] Adding generic support for CacheStorage and Cache methods
3504         https://bugs.webkit.org/show_bug.cgi?id=175455
3505
3506         Reviewed by Chris Dumez.
3507
3508         * WebView/WebView.mm:
3509         (-[WebView _commonInitializationWithFrameName:groupName:]):
3510
3511 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3512
3513         Remove Proximity Events and related code
3514         https://bugs.webkit.org/show_bug.cgi?id=175545
3515
3516         Reviewed by Daniel Bates.
3517
3518         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
3519         and other related code.
3520
3521         * Configurations/FeatureDefines.xcconfig:
3522
3523 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3524
3525         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
3526         https://bugs.webkit.org/show_bug.cgi?id=175504
3527
3528         Reviewed by Sam Weinig.
3529
3530         * Configurations/FeatureDefines.xcconfig:
3531         * DOM/DOMHTMLFormElement.mm:
3532         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
3533         * WebCoreSupport/WebFrameLoaderClient.h:
3534
3535 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
3536
3537         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
3538         https://bugs.webkit.org/show_bug.cgi?id=175557
3539
3540         Reviewed by Jon Lee.
3541
3542         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
3543
3544         * Configurations/FeatureDefines.xcconfig:
3545
3546 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
3547
3548         Composition underline color is always black
3549         https://bugs.webkit.org/show_bug.cgi?id=174675
3550
3551         Reviewed by Ryosuke Niwa.
3552
3553         * WebView/WebHTMLView.mm:
3554         (extractUnderlines): If NSUnderlineColorAttributeName
3555         is not present use text color for composition underline.
3556         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
3557         for composition underline in the plain text case.
3558
3559 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
3560
3561         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
3562         https://bugs.webkit.org/show_bug.cgi?id=175474
3563         <rdar://problem/33844628>
3564
3565         Reviewed by Wenson Hsieh.
3566
3567         Replaced the build flag by a runtime flag and disabled the feature by default.
3568
3569         * Configurations/FeatureDefines.xcconfig:
3570         * WebView/WebPreferenceKeysPrivate.h:
3571         * WebView/WebPreferences.mm:
3572         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
3573         (-[WebPreferences dataTransferItemsEnabled]): Added.
3574         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
3575         * WebView/WebPreferencesPrivate.h:
3576         * WebView/WebView.mm:
3577         (-[WebView _preferencesChanged:]):
3578
3579 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3580
3581         Remove ENABLE_GAMEPAD_DEPRECATED
3582         https://bugs.webkit.org/show_bug.cgi?id=175361
3583
3584         Reviewed by Carlos Garcia Campos.
3585
3586         * Configurations/FeatureDefines.xcconfig:
3587
3588 2017-08-09  Chris Dumez  <cdumez@apple.com>
3589
3590         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
3591         https://bugs.webkit.org/show_bug.cgi?id=175401
3592
3593         Reviewed by Brady Eidson.
3594
3595         * WebView/WebPreferenceKeysPrivate.h:
3596         * WebView/WebPreferences.mm:
3597         (+[WebPreferences initialize]):
3598         (-[WebPreferences beaconAPIEnabled]): Deleted.
3599         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
3600         * WebView/WebPreferencesPrivate.h:
3601         * WebView/WebView.mm:
3602         (-[WebView _preferencesChanged:]):
3603
3604 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3605
3606         [PAL] Move spi/cocoa and spi/cg directories into PAL
3607         https://bugs.webkit.org/show_bug.cgi?id=175175
3608
3609         Reviewed by Myles C. Maxfield.
3610
3611         * History/WebHistory.mm:
3612         * Misc/WebDownload.mm:
3613         * Misc/WebKitNSStringExtras.mm:
3614         * Plugins/Hosted/NetscapePluginHostManager.mm:
3615         * Plugins/WebPluginDatabase.mm:
3616         * WebCoreSupport/WebFrameLoaderClient.mm:
3617         * WebInspector/WebNodeHighlight.mm:
3618         * WebView/WebHTMLView.mm:
3619         * WebView/WebIndicateLayer.mm:
3620         * WebView/WebView.mm:
3621         * WebView/WebViewData.h:
3622
3623 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3624
3625         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
3626         https://bugs.webkit.org/show_bug.cgi?id=175392
3627         <rdar://problem/33783207>
3628
3629         Reviewed by Tim Horton and Megan Gardner.
3630
3631         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
3632
3633         * Configurations/FeatureDefines.xcconfig:
3634
3635 2017-08-09  Daniel Bates  <dabates@apple.com>
3636
3637         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
3638         https://bugs.webkit.org/show_bug.cgi?id=175247
3639         <rdar://problem/33679804>
3640
3641         Reviewed by Brady Eidson.
3642
3643         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
3644         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
3645         clients that need to make use of this information at this time. If such a needs comes up
3646         then we can expose API/SPI similar to what we do for WebKit.
3647
3648         * WebCoreSupport/WebFrameLoaderClient.h:
3649         * WebCoreSupport/WebFrameLoaderClient.mm:
3650         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3651
3652 2017-08-08  Brady Eidson  <beidson@apple.com>
3653
3654         Don't enable default icon loading in WK1 for apps linked against old SDKs.
3655         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
3656
3657         Reviewed by Andy Estes.
3658
3659         * Misc/WebKitVersionChecks.h:
3660         * WebCoreSupport/WebFrameLoaderClient.mm:
3661         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
3662           the app is linked against new WebKit with the new behavior.
3663
3664 2017-08-07  Devin Rousso  <drousso@apple.com>
3665
3666         Web Inspector: Preview Canvas path when viewing a recording
3667         https://bugs.webkit.org/show_bug.cgi?id=174967
3668
3669         Reviewed by Brian Burg.
3670
3671         * WebView/WebPreferenceKeysPrivate.h:
3672         * WebView/WebPreferences.mm:
3673         (+[WebPreferences initialize]):
3674         (-[WebPreferences inspectorAdditionsEnabled]):
3675         (-[WebPreferences setInspectorAdditionsEnabled:]):
3676         * WebView/WebPreferencesPrivate.h:
3677         * WebView/WebView.mm:
3678         (-[WebView _preferencesChanged:]):
3679         Add plumbing for new InspectorAdditions runtime flag.
3680
3681 2017-08-07  Brian Burg  <bburg@apple.com>
3682
3683         Remove CANVAS_PATH compilation guard
3684         https://bugs.webkit.org/show_bug.cgi?id=175207
3685
3686         Reviewed by Sam Weinig.
3687
3688         * Configurations/FeatureDefines.xcconfig:
3689
3690 2017-08-04  Youenn Fablet  <youenn@apple.com>
3691
3692         [Cache API] Add Cache and CacheStorage IDL definitions
3693         https://bugs.webkit.org/show_bug.cgi?id=175201
3694
3695         Reviewed by Brady Eidson.
3696
3697         * WebView/WebPreferenceKeysPrivate.h:
3698         * WebView/WebPreferences.mm:
3699         (+[WebPreferences initialize]):
3700         (-[WebPreferences cacheAPIEnabled]):
3701         (-[WebPreferences setCacheAPIEnabled:]):
3702         * WebView/WebPreferencesPrivate.h:
3703         * WebView/WebView.mm:
3704         (-[WebView _preferencesChanged:]):
3705
3706 2017-08-04  Matt Lewis  <jlewis3@apple.com>
3707
3708         Unreviewed, rolling out r220271.
3709
3710         Rolling out due to Layout Test failing on iOS Simulator.
3711
3712         Reverted changeset:
3713
3714         "Remove STREAMS_API compilation guard"
3715         https://bugs.webkit.org/show_bug.cgi?id=175165
3716         http://trac.webkit.org/changeset/220271
3717
3718 2017-08-04  Youenn Fablet  <youenn@apple.com>
3719
3720         Remove STREAMS_API compilation guard
3721         https://bugs.webkit.org/show_bug.cgi?id=175165
3722
3723         Reviewed by Darin Adler.
3724
3725         * Configurations/FeatureDefines.xcconfig:
3726         * WebView/WebPreferences.mm:
3727         (+[WebPreferences initialize]):
3728         * WebView/WebView.mm:
3729         (-[WebView _preferencesChanged:]):
3730
3731 2017-08-03  Brian Burg  <bburg@apple.com>
3732
3733         Remove ENABLE(WEB_SOCKET) guards
3734         https://bugs.webkit.org/show_bug.cgi?id=167044
3735
3736         Reviewed by Joseph Pecoraro.
3737
3738         * Configurations/FeatureDefines.xcconfig:
3739         * WebView/WebPreferencesPrivate.h:
3740
3741 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
3742
3743         [PAL] Move spi/cf directory into PAL
3744         https://bugs.webkit.org/show_bug.cgi?id=175057
3745
3746         Reviewed by Antti Koivisto.
3747
3748         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3749         * Plugins/WebNetscapePluginStream.mm:
3750         * WebCoreSupport/WebFrameNetworkingContext.mm:
3751         * WebView/WebPreferences.mm:
3752         * WebView/WebView.mm:
3753
3754 2017-08-03  Youenn Fablet  <youenn@apple.com>
3755
3756         Remove FETCH_API compilation guard
3757         https://bugs.webkit.org/show_bug.cgi?id=175154
3758
3759         Reviewed by Chris Dumez.
3760
3761         * Configurations/FeatureDefines.xcconfig:
3762         * WebView/WebPreferences.mm:
3763         (+[WebPreferences initialize]):
3764         * WebView/WebView.mm:
3765         (-[WebView _preferencesChanged:]):
3766
3767 2017-08-03  Brady Eidson  <beidson@apple.com>
3768
3769         Add SW IDLs and stub out basic functionality.
3770         https://bugs.webkit.org/show_bug.cgi?id=175115
3771
3772         Reviewed by Chris Dumez.
3773
3774         * Configurations/FeatureDefines.xcconfig:
3775
3776 2017-08-02  Sam Weinig  <sam@webkit.org>
3777
3778         [WebIDL] Convert MutationCallback to be a normal generated callback
3779         https://bugs.webkit.org/show_bug.cgi?id=174140
3780
3781         Reviewed by Darin Adler.
3782
3783         * DOM/DOMDocument.mm:
3784         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
3785         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
3786         Pass, now necessary, Document to NativeNodeFilter constructor.
3787
3788 2017-08-01  Chris Dumez  <cdumez@apple.com>
3789
3790         Add initial support for navigator.sendBeacon
3791         https://bugs.webkit.org/show_bug.cgi?id=175007
3792         <rdar://problem/33547728>
3793
3794         Reviewed by Sam Weinig.
3795
3796         Add setting to toggle support for the Beacon API (it is disabled by default).
3797
3798         * WebView/WebPreferenceKeysPrivate.h:
3799         * WebView/WebPreferences.mm:
3800         (+[WebPreferences initialize]):
3801         (-[WebPreferences beaconAPIEnabled]):
3802         (-[WebPreferences setBeaconAPIEnabled:]):
3803         * WebView/WebPreferencesPrivate.h:
3804         * WebView/WebView.mm:
3805         (-[WebView _preferencesChanged:]):
3806
3807 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
3808
3809         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
3810         https://bugs.webkit.org/show_bug.cgi?id=174437
3811
3812         Reviewed by Darin Adler.
3813
3814         Remove redundant Web- prefix from classes in WebKit namespace.
3815
3816         * WebView/WebView.mm:
3817         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
3818         * WebView/WebViewData.h:
3819         * WebView/WebViewData.mm:
3820
3821 2017-07-26  Brian Burg  <bburg@apple.com>
3822
3823         Remove WEB_TIMING feature flag
3824         https://bugs.webkit.org/show_bug.cgi?id=174795
3825
3826         Reviewed by Alex Christensen.
3827
3828         * Configurations/FeatureDefines.xcconfig:
3829
3830 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
3831
3832         Async image decoding for large images should be disabled after the first time a tile is painted
3833         https://bugs.webkit.org/show_bug.cgi?id=174451
3834         <rdar://problem/31246421>
3835
3836         Reviewed by Simon Fraser.
3837
3838         * WebView/WebFrame.mm:
3839         (-[WebFrame _paintBehaviorForDestinationContext:]):
3840         (-[WebFrame _drawRect:contentsOnly:]):
3841         * WebView/WebHTMLView.mm:
3842         (imageFromRect):
3843
3844 2017-07-23  Darin Adler  <darin@apple.com>
3845
3846         More NeverDestroyed and related cleanup
3847         https://bugs.webkit.org/show_bug.cgi?id=174745
3848
3849         Reviewed by Alex Christensen.
3850
3851         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
3852         for names that aren't even used in this file.
3853         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
3854         -[NSArray arrayWithObject:].
3855         (-[DOMNode absoluteQuads]): Ditto.
3856         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
3857         of writing out various types.
3858         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
3859         syntax instea of -[NSArray arrayWithObject:].
3860         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
3861         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
3862         of writing out various types.
3863         (-[DOMHTMLImageElement mimeType]): Ditto.
3864
3865 2017-07-24  Chris Dumez  <cdumez@apple.com>
3866
3867         ExceptionCode enumeration should use modern exception names
3868         https://bugs.webkit.org/show_bug.cgi?id=174794
3869
3870         Reviewed by Geoffrey Garen.
3871
3872         * DOM/ExceptionHandlers.mm:
3873         (raiseNotSupportedErrorException):
3874
3875 2017-07-23  Chris Dumez  <cdumez@apple.com>
3876
3877         Drop ExceptionCodeDescription class
3878         https://bugs.webkit.org/show_bug.cgi?id=174757
3879
3880         Reviewed by Darin Adler.
3881
3882         Stop using ExceptionCodeDescription.
3883
3884         * DOM/ExceptionHandlers.mm:
3885         (raiseDOMErrorException):
3886
3887 2017-07-21  Andreas Kling  <akling@apple.com>
3888
3889         Use more references in event dispatch code
3890         https://bugs.webkit.org/show_bug.cgi?id=174681
3891
3892         Reviewed by Geoffrey Garen.
3893
3894         * DOM/ObjCEventListener.h:
3895         * DOM/ObjCEventListener.mm:
3896         (WebCore::ObjCEventListener::handleEvent):
3897         * WebCoreSupport/WebFrameLoaderClient.mm:
3898         (NetscapePluginWidget::handleEvent):
3899
3900 2017-07-21  Brady Eidson  <beidson@apple.com>
3901
3902         Get rid of WebCore IconDatabase code.
3903         https://bugs.webkit.org/show_bug.cgi?id=174700
3904
3905         Reviewed by Tim Horton.
3906
3907         * Misc/WebCoreStatistics.mm:
3908         (+[WebCoreStatistics iconPageURLMappingCount]):
3909         (+[WebCoreStatistics iconRetainedPageURLCount]):
3910         (+[WebCoreStatistics iconRecordCount]):
3911         (+[WebCoreStatistics iconsWithDataCount]):
3912         * WebCoreSupport/WebFrameLoaderClient.h:
3913         * WebCoreSupport/WebFrameLoaderClient.mm:
3914         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
3915         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
3916         * WebView/WebView.mm:
3917         (-[WebView mainFrameIconURL]):
3918
3919 2017-07-20  Chris Dumez  <cdumez@apple.com>
3920
3921         Drop legacy XPathException type
3922         https://bugs.webkit.org/show_bug.cgi?id=174679
3923
3924         Reviewed by Sam Weinig.
3925
3926         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3927         no longer expose XPathException.
3928
3929         * DOM/ExceptionHandlers.mm:
3930         (raiseDOMErrorException):
3931
3932 2017-07-20  Chris Dumez  <cdumez@apple.com>
3933
3934         Unreviewed, rolling out r219706.
3935
3936         Broke iOS build
3937
3938         Reverted changeset:
3939
3940         "Drop legacy XPathException type"
3941         https://bugs.webkit.org/show_bug.cgi?id=174679
3942         http://trac.webkit.org/changeset/219706
3943
3944 2017-07-20  Chris Dumez  <cdumez@apple.com>
3945
3946         Drop legacy XPathException type
3947         https://bugs.webkit.org/show_bug.cgi?id=174679
3948
3949         Reviewed by Sam Weinig.
3950
3951         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
3952         no longer expose XPathException.
3953
3954         * DOM/ExceptionHandlers.mm:
3955         (raiseDOMErrorException):
3956         * WebKit.exp:
3957
3958 2017-07-20  Chris Dumez  <cdumez@apple.com>
3959
3960         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
3961         https://bugs.webkit.org/show_bug.cgi?id=174660
3962
3963         Reviewed by Geoffrey Garen.
3964
3965         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
3966         This essentially replaces a branch to figure out if the new size is less or greater than the
3967         current size by an assertion.
3968
3969         * Plugins/WebNetscapePluginView.mm:
3970         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3971
3972 2017-07-20  Brady Eidson  <beidson@apple.com>
3973
3974         Deprecate WebIconDatabase in WebKitLegacy/mac.
3975         https://bugs.webkit.org/show_bug.cgi?id=174607
3976
3977         Reviewed by Alex Christensen.
3978
3979         This patch:
3980         1 - Formally deprecates WebIconDatabase (which was never API anyways)
3981         2 - Guts the class to where it can only return the default icon at the small size
3982         3 - Reworks other parts of WebKitLegacy that used it for anything to either
3983             use something else or to not do anything.
3984         
3985         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
3986         and that patch will remove all of the last remnants of WebIconDatabase.
3987         
3988         * History/WebHistoryItem.mm:
3989         (-[WebHistoryItem icon]):
3990
3991         * Misc/WebIconDatabase.h:
3992         * Misc/WebIconDatabase.mm:
3993         (-[WebIconDatabase init]):
3994         (-[WebIconDatabase iconForURL:withSize:cache:]):
3995         (-[WebIconDatabase iconForURL:withSize:]):
3996         (-[WebIconDatabase defaultIconWithSize:]):
3997         (-[WebIconDatabase defaultIconForURL:withSize:]):
3998         (-[WebIconDatabase iconURLForURL:]):
3999         (-[WebIconDatabase retainIconForURL:]):
4000         (-[WebIconDatabase releaseIconForURL:]):
4001         (+[WebIconDatabase delayDatabaseCleanup]):
4002         (+[WebIconDatabase allowDatabaseCleanup]):
4003         (-[WebIconDatabase setDelegate:]):
4004         (-[WebIconDatabase delegate]):
4005         (+[WebIconDatabase initialize]): Deleted.
4006         (-[WebIconDatabase isEnabled]): Deleted.
4007         (-[WebIconDatabase setEnabled:]): Deleted.
4008         (-[WebIconDatabase removeAllIcons]): Deleted.
4009         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
4010         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
4011         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
4012         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
4013         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
4014         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
4015         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
4016         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
4017         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
4018         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
4019         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
4020         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
4021         (-[WebIconDatabase _databaseDirectory]): Deleted.
4022         (webGetNSImage): Deleted.
4023
4024         * Misc/WebIconDatabaseDelegate.h: Removed.
4025         * Misc/WebIconDatabaseInternal.h: Removed.
4026         * Misc/WebIconDatabasePrivate.h: Removed.
4027
4028         * WebCoreSupport/WebFrameLoaderClient.mm:
4029         (webGetNSImage):
4030
4031         * WebCoreSupport/WebIconDatabaseClient.mm:
4032         (WebIconDatabaseClient::didRemoveAllIcons):
4033         (WebIconDatabaseClient::didImportIconURLForPageURL):
4034
4035         * WebView/WebView.mm:
4036         (-[WebView setFrameLoadDelegate:]):
4037         (-[WebView mainFrameIcon]):
4038
4039 2017-07-18  Andy Estes  <aestes@apple.com>
4040
4041         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
4042         https://bugs.webkit.org/show_bug.cgi?id=174631
4043
4044         Reviewed by Tim Horton.
4045
4046         * Configurations/Base.xcconfig:
4047
4048 2017-07-18  Andy Estes  <aestes@apple.com>
4049
4050         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
4051         https://bugs.webkit.org/show_bug.cgi?id=174631
4052
4053         Reviewed by Sam Weinig.
4054
4055         * Configurations/Base.xcconfig:
4056
4057 2017-07-18  Andy Estes  <aestes@apple.com>
4058
4059         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
4060         https://bugs.webkit.org/show_bug.cgi?id=174631
4061
4062         Reviewed by Dan Bernstein.
4063
4064         * Configurations/Base.xcconfig:
4065
4066 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4067
4068         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
4069         https://bugs.webkit.org/show_bug.cgi?id=174640
4070         <rdar://problem/33297400>
4071
4072         Reviewed by Tim Horton.
4073
4074         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
4075         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
4076         web thread here, to match the other WebView drag and drop SPI methods.
4077
4078         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
4079         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
4080         should make this robust against future UIKit changes that could make this no longer the case.
4081
4082         * WebView/WebView.mm:
4083         (-[WebView _requestStartDataInteraction:globalPosition:]):
4084         (-[WebView _dataInteractionCaretRect]):