WebKitLegacy does not need to generate an export file for i386 anymore
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-03-06  Sam Weinig  <sam@webkit.org>
2
3         WebKitLegacy does not need to generate an export file for i386 anymore
4         https://bugs.webkit.org/show_bug.cgi?id=195380
5
6         Reviewed by Dan Bernstein.
7
8         * Configurations/WebKitLegacy.xcconfig:
9         Simplify EXPORTED_SYMBOLS_FILE down to just a single path to a generated file.
10         It still needs to be generated, since we are concatenating the shared exports
11         file with a macOS or iOS specific one.
12
13         * WebKit.mac.exp:
14         Remove i386 specific symbols that we were previously stripping.
15
16 2019-03-06  Rob Buis  <rbuis@igalia.com>
17
18         Consider supporting the `referrerpolicy` attribute.
19         https://bugs.webkit.org/show_bug.cgi?id=179053
20
21         Reviewed by Darin Adler.
22
23         Add a runtime flag for referrerpolicy attribute.
24
25         * WebView/WebPreferenceKeysPrivate.h:
26         * WebView/WebPreferences.mm:
27         (+[WebPreferences initialize]):
28         (-[WebPreferences referrerPolicyAttributeEnabled]):
29         (-[WebPreferences setReferrerPolicyAttributeEnabled:]):
30         * WebView/WebPreferencesPrivate.h:
31         * WebView/WebView.mm:
32         (-[WebView _preferencesChanged:]):
33
34 2019-03-03  Tim Horton  <timothy_horton@apple.com>
35
36         Remove some more unused 32-bit code
37         https://bugs.webkit.org/show_bug.cgi?id=195255
38
39         Reviewed by Darin Adler.
40
41         * Plugins/WebNetscapePluginEventHandler.mm:
42         (WebNetscapePluginEventHandler::create):
43         * Plugins/WebNetscapePluginView.h:
44         * Plugins/WebNetscapePluginView.mm:
45         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
46         (-[WebNetscapePluginView restorePortState:]):
47         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
48         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
49         (-[WebNetscapePluginView updateAndSetWindow]):
50         (-[WebNetscapePluginView setWindowIfNecessary]):
51         (-[WebNetscapePluginView createPlugin]):
52         (-[WebNetscapePluginView fini]):
53         (-[WebNetscapePluginView drawRect:]):
54         (-[WebNetscapePluginView invalidateRegion:]):
55         (-[WebNetscapePluginView getVariable:value:]):
56         (-[WebNetscapePluginView setVariable:value:]):
57         (isDrawingModelQuickDraw): Deleted.
58         (-[WebNetscapePluginView fixWindowPort]): Deleted.
59         (getQDPixelFormatForBitmapContext): Deleted.
60         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
61         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
62         * WebView/WebDelegateImplementationCaching.mm:
63
64 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
65
66         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
67         https://bugs.webkit.org/show_bug.cgi?id=195053
68         <rdar://problem/48134710>
69
70         Reviewed by Ryosuke Niwa.
71
72         * WebCoreSupport/WebEditorClient.h:
73
74 2019-03-01  Tim Horton  <timothy_horton@apple.com>
75
76         Remove unused code in WebKitLegacy
77         https://bugs.webkit.org/show_bug.cgi?id=189614
78
79         Reviewed by Simon Fraser.
80
81         * Carbon/CarbonUtils.h: Removed.
82         * Carbon/CarbonUtils.m: Removed.
83         * Carbon/CarbonWindowAdapter.h: Removed.
84         * Carbon/CarbonWindowAdapter.mm: Removed.
85         * Carbon/CarbonWindowContentView.h: Removed.
86         * Carbon/CarbonWindowContentView.m: Removed.
87         * Carbon/CarbonWindowFrame.h: Removed.
88         * Carbon/CarbonWindowFrame.m: Removed.
89         * Carbon/HIViewAdapter.h: Removed.
90         * Carbon/HIViewAdapter.m: Removed.
91         * Carbon/HIWebView.h: Removed.
92         * Carbon/HIWebView.mm: Removed.
93         * Configurations/WebKitLegacy.xcconfig:
94         * WebKit.mac.exp:
95
96 2019-03-01  Justin Fan  <justin_fan@apple.com>
97
98         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
99         https://bugs.webkit.org/show_bug.cgi?id=195191
100
101         Rubber-stamped by Dean Jackson.
102
103         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
104
105         * Configurations/FeatureDefines.xcconfig:
106
107 2019-02-28  Antoine Quint  <graouts@apple.com>
108
109         Enable the Pointer Events runtime flag by default
110         https://bugs.webkit.org/show_bug.cgi?id=195156
111
112         Reviewed by Dean Jackson.
113
114         * WebView/WebPreferences.mm:
115         (+[WebPreferences initialize]):
116
117 2019-02-28  Justin Fan  <justin_fan@apple.com>
118
119         [Web GPU] Enable Web GPU only on 64-bit
120         https://bugs.webkit.org/show_bug.cgi?id=195139
121
122         Because Metal is only supported on 64 bit apps.
123
124         Unreviewed build fix.
125
126         * Configurations/FeatureDefines.xcconfig:
127
128 2019-02-27  Antoine Quint  <graouts@apple.com>
129
130         Support Pointer Events on macOS
131         https://bugs.webkit.org/show_bug.cgi?id=195008
132         <rdar://problem/47454419>
133
134         Reviewed by Dean Jackson.
135
136         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
137
138         * Configurations/FeatureDefines.xcconfig:
139         * WebView/WebPreferenceKeysPrivate.h:
140         * WebView/WebPreferences.mm:
141         (+[WebPreferences initialize]):
142         (-[WebPreferences pointerEventsEnabled]):
143         (-[WebPreferences setPointerEventsEnabled:]):
144         * WebView/WebPreferencesPrivate.h:
145         * WebView/WebView.mm:
146         (-[WebView _preferencesChanged:]):
147
148 2019-02-23  Keith Miller  <keith_miller@apple.com>
149
150         Add new mac target numbers
151         https://bugs.webkit.org/show_bug.cgi?id=194955
152
153         Reviewed by Tim Horton.
154
155         * Configurations/Base.xcconfig:
156         * Configurations/DebugRelease.xcconfig:
157
158 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
159
160         Hardcode Visual Viewports on everywhere except iOS WK1
161         https://bugs.webkit.org/show_bug.cgi?id=194928
162
163         Reviewed by Zalan Bujtas.
164
165         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
166         change the default value of the Setting to 'true', and hardcode WebView on iOS to
167         set it to false. The setting has shipped for several years and there's no need to turn
168         it off now.
169
170         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
171         Visual Viewports are not enabled.
172         
173         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
174         that only runs in WK2
175
176         * WebView/WebPreferenceKeysPrivate.h:
177         * WebView/WebPreferences.mm:
178         (+[WebPreferences initialize]):
179         (-[WebPreferences visualViewportEnabled]): Deleted.
180         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
181         * WebView/WebPreferencesPrivate.h:
182         * WebView/WebView.mm:
183         (-[WebView _preferencesChanged:]):
184
185 2019-02-21  Darin Adler  <darin@apple.com>
186
187         Some refinements for Node and Document
188         https://bugs.webkit.org/show_bug.cgi?id=194764
189
190         Reviewed by Ryosuke Niwa.
191
192         * DOM/DOMDocument.mm:
193         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
194         through to WebCore or even looking at the arguments.
195         (-[DOMDocument getOverrideStyle::]): Ditto.
196
197 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
198
199         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
200         https://bugs.webkit.org/show_bug.cgi?id=194670
201         <rdar://problem/39066529>
202
203         Reviewed by Tim Horton.
204
205         * WebCoreSupport/WebEditorClient.h:
206         * WebCoreSupport/WebEditorClient.mm:
207         (WebEditorClient::replacementURLForResource): Deleted.
208         * WebCoreSupport/WebPlatformStrategies.h:
209         * WebCoreSupport/WebPlatformStrategies.mm:
210         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
211
212 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
213
214         Add MSE logging configuration
215         https://bugs.webkit.org/show_bug.cgi?id=194719
216         <rdar://problem/48122151>
217
218         Reviewed by Joseph Pecoraro.
219
220         * WebCoreSupport/WebChromeClient.mm:
221         (stringForMessageSource): Recognize the MSE message source.
222
223 2019-02-17  David Kilzer  <ddkilzer@apple.com>
224
225         Unreviewed, rolling out r241620.
226
227         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
228         (Requested by ddkilzer on #webkit.)
229
230         Reverted changeset:
231
232         "[WTF] Add environment variable helpers"
233         https://bugs.webkit.org/show_bug.cgi?id=192405
234         https://trac.webkit.org/changeset/241620
235
236 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
237
238         [WTF] Add environment variable helpers
239         https://bugs.webkit.org/show_bug.cgi?id=192405
240
241         Reviewed by Michael Catanzaro.
242
243         * WebView/WebView.mm:
244         (-[WebView _initWithFrame:frameName:groupName:]):
245         Utilize WTF::Environment where possible.
246
247 2019-02-15  Brian Burg  <bburg@apple.com>
248
249         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
250         https://bugs.webkit.org/show_bug.cgi?id=194411
251         <rdar://problem/47787614>
252
253         Reviewed by Joseph Pecoraro.
254
255         * Configurations/WebKitLegacy.xcconfig:
256         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
257
258         * WebCoreSupport/WebInspectorClient.mm:
259         (WebInspectorFrontendClient::localizedStringsURL):
260         (-[WebInspectorWindowController inspectorPagePath]):
261         (-[WebInspectorWindowController inspectorTestPagePath]):
262         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
263
264 2019-02-15  Commit Queue  <commit-queue@webkit.org>
265
266         Unreviewed, rolling out r241559 and r241566.
267         https://bugs.webkit.org/show_bug.cgi?id=194710
268
269         Causes layout test crashes under GuardMalloc (Requested by
270         ryanhaddad on #webkit).
271
272         Reverted changesets:
273
274         "[WTF] Add environment variable helpers"
275         https://bugs.webkit.org/show_bug.cgi?id=192405
276         https://trac.webkit.org/changeset/241559
277
278         "Unreviewed build fix for WinCairo Debug after r241559."
279         https://trac.webkit.org/changeset/241566
280
281 2019-02-15  Truitt Savell  <tsavell@apple.com>
282
283         Unreviewed, rolling out r241564.
284
285         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
286
287         Reverted changeset:
288
289         "[Mac] WebInspectorUI.framework does not need to be soft-
290         linked anymore"
291         https://bugs.webkit.org/show_bug.cgi?id=194411
292         https://trac.webkit.org/changeset/241564
293
294 2019-02-14  Brian Burg  <bburg@apple.com>
295
296         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
297         https://bugs.webkit.org/show_bug.cgi?id=194411
298         <rdar://problem/47787614>
299
300         Reviewed by Joseph Pecoraro.
301
302         * Configurations/WebKitLegacy.xcconfig:
303         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
304
305         * WebCoreSupport/WebInspectorClient.mm:
306         (WebInspectorFrontendClient::localizedStringsURL):
307         (-[WebInspectorWindowController inspectorPagePath]):
308         (-[WebInspectorWindowController inspectorTestPagePath]):
309         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
310
311 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
312
313         [WTF] Add environment variable helpers
314         https://bugs.webkit.org/show_bug.cgi?id=192405
315
316         Reviewed by Michael Catanzaro.
317
318         * WebView/WebView.mm:
319         (-[WebView _initWithFrame:frameName:groupName:]):
320         Utilize WTF::Environment where possible.
321
322 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
323
324         Allow pages to trigger programmatic paste from script on iOS
325         https://bugs.webkit.org/show_bug.cgi?id=194271
326         <rdar://problem/47808810>
327
328         Reviewed by Ryosuke Niwa.
329
330         See WebCore and WebKit ChangeLogs for more details.
331
332         * WebCoreSupport/WebEditorClient.h:
333
334 2019-02-12  Andy Estes  <aestes@apple.com>
335
336         [iOSMac] Enable Parental Controls Content Filtering
337         https://bugs.webkit.org/show_bug.cgi?id=194521
338         <rdar://39732376>
339
340         Reviewed by Tim Horton.
341
342         * Configurations/FeatureDefines.xcconfig:
343
344 2019-02-06  Andy Estes  <aestes@apple.com>
345
346         [Payment Request] It should be possible to require a phonetic name for shipping contacts
347         https://bugs.webkit.org/show_bug.cgi?id=194311
348         <rdar://46733045>
349
350         Reviewed by Alex Christensen.
351
352         * WebCoreSupport/WebPaymentCoordinatorClient.h:
353         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
354         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
355
356 2019-02-04  Said Abou-Hallawa  <said@apple.com>
357
358         [CG] Enable setAdditionalSupportedImageTypes for WK1
359         https://bugs.webkit.org/show_bug.cgi?id=194190
360
361         Reviewed by Tim Horton.
362
363         1. Define the preferences key AdditionalSupportedImageTypes.
364         2. Add additionalSupportedImageTypes as a private preference property.
365         3. Define the setter and the getter of the property.
366         4. Add function to convert from an id to an array of strings.
367         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
368
369         * WebView/WebPreferenceKeysPrivate.h:
370         * WebView/WebPreferences.mm:
371         (-[WebPreferences _stringArrayValueForKey:]):
372         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
373         (-[WebPreferences setAdditionalSupportedImageTypes:]):
374         (-[WebPreferences additionalSupportedImageTypes]):
375         * WebView/WebPreferencesPrivate.h:
376         * WebView/WebView.mm:
377         (-[WebView _preferencesChanged:]):
378
379 2019-02-04  Timothy Hatcher  <timothy@apple.com>
380
381         Add WebView SPI to temporarily force light or dark appearance on a page.
382         https://bugs.webkit.org/show_bug.cgi?id=194230
383
384         Reviewed by Tim Horton.
385
386         * WebView/WebView.mm:
387         (-[WebView _useDarkAppearance:]): Added.
388         (-[WebView _setUseDarkAppearance:]): Added.
389         * WebView/WebViewPrivate.h:
390
391 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
392
393         PageOverlayController's layers should be created lazily
394         https://bugs.webkit.org/show_bug.cgi?id=194199
395         rdar://problem/46571593
396
397         Reviewed by Tim Horton.
398
399         * WebCoreSupport/WebChromeClient.h:
400         * WebCoreSupport/WebChromeClient.mm:
401         (WebChromeClient::attachViewOverlayGraphicsLayer):
402
403 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
404
405         Make setNeedsLayout on the root more explicitly about triggering its side-effects
406         https://bugs.webkit.org/show_bug.cgi?id=194198
407
408         Reviewed by Antti Koivisto.
409
410         Call the newly named functions.
411
412         * WebView/WebFrame.mm:
413         (-[WebFrame setNeedsLayout]):
414         * WebView/WebHTMLView.mm:
415         (-[WebHTMLView setNeedsLayout:]):
416
417 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
418
419         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
420         https://bugs.webkit.org/show_bug.cgi?id=194189
421
422         Reviewed by Geoffrey Garen.
423
424         Pass the policy check identifier around functions and store it in WebFramePolicyListener
425         so that we can send it back to WebCore with the navigation policy decision.
426
427         * WebCoreSupport/WebFrameLoaderClient.h:
428         * WebCoreSupport/WebFrameLoaderClient.mm:
429         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
430         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
431         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
432         (WebFrameLoaderClient::dispatchWillSubmitForm):
433         (WebFrameLoaderClient::setUpPolicyListener):
434         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
435         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
436         (-[WebFramePolicyListener invalidate]):
437         (-[WebFramePolicyListener dealloc]):
438         (-[WebFramePolicyListener receivedPolicyDecision:]):
439         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
440         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
441
442 2019-01-31  Alex Christensen  <achristensen@webkit.org>
443
444         Revert r238819 which is unneeded and caused a performance regression.
445         https://bugs.webkit.org/show_bug.cgi?id=192272
446         <rdar://problem/46664625>
447
448         * WebCoreSupport/WebFrameLoaderClient.h:
449         * WebCoreSupport/WebFrameLoaderClient.mm:
450         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
451
452 2019-01-28  Devin Rousso  <drousso@apple.com>
453
454         Web Inspector: provide a way to edit page WebRTC settings on a remote target
455         https://bugs.webkit.org/show_bug.cgi?id=193863
456         <rdar://problem/47572764>
457
458         Reviewed by Joseph Pecoraro.
459
460         * WebView/WebView.mm:
461         (-[WebView _preferencesChanged:]):
462         Add page-level settings for WebRTC preferences.
463
464 2019-01-28  Andy Estes  <aestes@apple.com>
465
466         [watchOS] Enable Parental Controls content filtering
467         https://bugs.webkit.org/show_bug.cgi?id=193939
468         <rdar://problem/46641912>
469
470         Reviewed by Ryosuke Niwa.
471
472         * Configurations/FeatureDefines.xcconfig:
473
474 2019-01-28  Timothy Hatcher  <timothy@apple.com>
475
476         Make it easier for non-Apple ports to enable dark mode CSS support.
477         https://bugs.webkit.org/show_bug.cgi?id=193882
478
479         Reviewed by Megan Gardner.
480
481         * WebView/WebView.mm:
482         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
483         (-[WebView _effectiveAppearanceIsDark]): Ditto.
484
485 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
486
487         AX: Introduce a static accessibility tree
488         https://bugs.webkit.org/show_bug.cgi?id=193348
489         <rdar://problem/47203295>
490
491         Reviewed by Ryosuke Niwa.
492
493         * Configurations/FeatureDefines.xcconfig:
494
495 2019-01-25  Keith Rollin  <krollin@apple.com>
496
497         Update WebKitAdditions.xcconfig with correct order of variable definitions
498         https://bugs.webkit.org/show_bug.cgi?id=193793
499         <rdar://problem/47532439>
500
501         Reviewed by Alex Christensen.
502
503         XCBuild changes the way xcconfig variables are evaluated. In short,
504         all config file assignments are now considered in part of the
505         evaluation. When using the new build system and an .xcconfig file
506         contains multiple assignments of the same build setting:
507
508         - Later assignments using $(inherited) will inherit from earlier
509           assignments in the xcconfig file.
510         - Later assignments not using $(inherited) will take precedence over
511           earlier assignments. An assignment to a more general setting will
512           mask an earlier assignment to a less general setting. For example,
513           an assignment without a condition ('FOO = bar') will completely mask
514           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
515
516         This affects some of our .xcconfig files, in that sometimes platform-
517         or sdk-specific definitions appear before the general definitions.
518         Under the new evaluations rules, the general definitions alway take
519         effect because they always overwrite the more-specific definitions. The
520         solution is to swap the order, so that the general definitions are
521         established first, and then conditionally overwritten by the
522         more-specific definitions.
523
524         * Configurations/Version.xcconfig:
525         * Configurations/WebKitLegacy.xcconfig:
526
527 2019-01-25  David Kilzer  <ddkilzer@apple.com>
528
529         Move soft-linking of Lookup.framework out of LookupSPI.h
530         <https://webkit.org/b/193815>
531
532         Reviewed by Tim Horton.
533
534         * WebView/WebImmediateActionController.mm:
535         (-[WebImmediateActionController _animationControllerForText]):
536         * WebView/WebView.mm:
537         (-[WebView _prepareForDictionaryLookup]):
538         - Move soft-linking to LookupSoftLink.{h,mm}.
539
540 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
541
542         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
543         https://bugs.webkit.org/show_bug.cgi?id=193829
544
545         Reviewed by Tim Horton.
546
547         * WebCoreSupport/WebDragClient.mm:
548         (WebDragClient::didConcludeEditDrag):
549         * WebView/WebView.mm:
550         (-[WebView _requestStartDataInteraction:globalPosition:]):
551         (-[WebView _didConcludeEditDrag]):
552         (-[WebView _didConcludeEditDataInteraction]): Deleted.
553         * WebView/WebViewInternal.h:
554
555 2019-01-24  John Wilander  <wilander@apple.com>
556
557         Add Ad Click Attribution as an internal/experimental feature
558         https://bugs.webkit.org/show_bug.cgi?id=193685
559         <rdar://problem/47450399>
560
561         Reviewed by Brent Fulgham.
562
563         * WebView/WebPreferenceKeysPrivate.h:
564         * WebView/WebPreferences.mm:
565         (+[WebPreferences initialize]):
566         (-[WebPreferences adClickAttributionEnabled]):
567         (-[WebPreferences setAdClickAttributionEnabled:]):
568             Added support for experimental ad click attribution.
569         * WebView/WebPreferencesPrivate.h:
570         * WebView/WebView.mm:
571         (-[WebView _preferencesChanged:]):
572
573 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
574
575         Move FileSystem to WTF
576         https://bugs.webkit.org/show_bug.cgi?id=193602
577
578         Reviewed by Yusuke Suzuki.
579
580         * Misc/WebNSFileManagerExtras.mm:
581         * Storage/WebDatabaseProvider.mm:
582         * WebView/WebView.mm:
583
584 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
585
586         Fix the Apple Internal build. See <rdar://problem/47491383>.
587
588         Rubber-stamped by Tim Horton.
589
590         * WebCoreSupport/WebFrameLoaderClient.mm:
591
592 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
593
594         Clean up USE(WEB_THREAD)
595         https://bugs.webkit.org/show_bug.cgi?id=193698
596
597         Rubber-stamped by Tim Horton.
598
599         * Misc/WebCache.mm:
600         (+[WebCache emptyInMemoryResources]):
601         * WebCoreSupport/WebFrameLoaderClient.mm:
602         (-[WebFramePolicyListener use]):
603         * WebCoreSupport/WebGeolocationClient.mm:
604         (-[WebGeolocationPolicyListener allow]):
605         (-[WebGeolocationPolicyListener deny]):
606         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
607         * WebView/WebFrame.mm:
608         (-[WebFrame deviceOrientationChanged]):
609         * WebView/WebHTMLView.mm:
610         (hardwareKeyboardAvailabilityChangedCallback):
611         * WebView/WebView.mm:
612         (+[WebView _releaseMemoryNow]):
613         (+[WebView willEnterBackgroundWithCompletionHandler:]):
614         (-[WebView updateLayoutIgnorePendingStyleSheets]):
615         (-[WebView _dispatchUnloadEvent]):
616         (-[WebView _close]):
617         (-[WebView _preferencesChangedNotification:]):
618         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
619         (-[WebView goBack]):
620         (-[WebView goForward]):
621         (+[WebView _cacheModelChangedNotification:]):
622         (-[WebView stopLoading:]):
623         (-[WebView stopLoadingAndClear]):
624         (-[WebView reload:]):
625         (WebInstallMemoryPressureHandler):
626
627 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
628
629         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
630         https://bugs.webkit.org/show_bug.cgi?id=193706
631         <rdar://problem/44807048>
632
633         Reviewed by Ryosuke Niwa.
634
635         Use UndoStep::label().
636
637         * WebCoreSupport/WebEditorClient.h:
638         * WebCoreSupport/WebEditorClient.mm:
639         (-[WebUndoStep initWithUndoStep:]):
640         (+[WebUndoStep stepWithUndoStep:]):
641         (WebEditorClient::registerUndoOrRedoStep):
642         (WebEditorClient::registerUndoStep):
643         (WebEditorClient::registerRedoStep):
644
645 2019-01-22  Alex Christensen  <achristensen@webkit.org>
646
647         Move NetworkStorageSession ownership to NetworkProcess
648         https://bugs.webkit.org/show_bug.cgi?id=193580
649
650         Reviewed by Geoff Garen.
651
652         * Misc/WebCache.mm:
653         (+[WebCache clearCachedCredentials]):
654         * Misc/WebDownload.mm:
655         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
656         * Plugins/WebBaseNetscapePluginView.mm:
657         (WebKit::getAuthenticationInfo):
658         * WebCoreSupport/WebFrameNetworkingContext.mm:
659         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
660         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
661         (WebFrameNetworkingContext::storageSession const):
662         * WebView/WebPreferences.mm:
663         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
664         (+[WebPreferences _clearNetworkLoaderSession]):
665         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
666
667 2019-01-22  Daniel Bates  <dabates@apple.com>
668
669         [iOS] Interpret text key commands on keydown and app key commands on keypress
670         https://bugs.webkit.org/show_bug.cgi?id=192897
671         <rdar://problem/46857378>
672
673         Reviewed by Brent Fulgham.
674
675         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
676         is false) and keypress (isCharEvent is true), respectively.
677
678         * WebView/WebHTMLView.mm:
679         (-[WebHTMLView _handleEditingKeyEvent:]):
680
681 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
682
683         [css-logical] Implement flow-relative margin, padding and border shorthands
684         https://bugs.webkit.org/show_bug.cgi?id=188697
685
686         Reviewed by Simon Fraser and Antti Koivisto.
687
688         Add CSSLogicalEnabled runtime flag.
689
690         * WebView/WebPreferenceKeysPrivate.h:
691         * WebView/WebPreferences.mm:
692         (+[WebPreferences initialize]):
693         (-[WebPreferences cssLogicalEnabled]):
694         (-[WebPreferences setCSSLogicalEnabled:]):
695         * WebView/WebPreferencesPrivate.h:
696         * WebView/WebView.mm:
697         (-[WebView _preferencesChanged:]):
698
699 2019-01-15  Darin Adler  <darin@apple.com>
700
701         Use references rather than pointers for register/unregister functions, and more
702         https://bugs.webkit.org/show_bug.cgi?id=175028
703
704         Reviewed by Daniel Bates.
705
706         * WebCoreSupport/WebKitFullScreenListener.mm:
707         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
708         functions in Document; pass a reference.
709         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
710         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
711         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
712         * WebView/WebFullScreenController.mm:
713         (-[WebFullScreenController enterFullScreen:]): Ditto.
714         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
715         (-[WebFullScreenController exitFullScreen]): Ditto.
716         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
717         * WebView/WebFullScreenController.mm:
718         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
719
720 2019-01-12  Dan Bernstein  <mitz@apple.com>
721
722         [Cocoa] Avoid importing directly from subumbrella frameworks
723         https://bugs.webkit.org/show_bug.cgi?id=186016
724         <rdar://problem/40591038>
725
726         Reviewed by Sam Weinig.
727
728         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
729         * Carbon/CarbonWindowAdapter.mm: Ditto.
730         * Carbon/CarbonWindowFrame.m: Ditto.
731         * Carbon/HIViewAdapter.h: Ditto.
732         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
733           OTHER_CFLAGS_COCOA_TOUCH_NO.
734         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
735         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
736         * WebView/WebPDFView.h: Ditto.
737
738 2019-01-20  Antoine Quint  <graouts@apple.com>
739
740         Add a POINTER_EVENTS feature flag
741         https://bugs.webkit.org/show_bug.cgi?id=193577
742         <rdar://problem/47408511>
743
744         Unreviewed. Also enable Pointer Events for iosmac.
745
746         * Configurations/FeatureDefines.xcconfig:
747
748 2019-01-19  Antoine Quint  <graouts@apple.com>
749
750         Add a POINTER_EVENTS feature flag
751         https://bugs.webkit.org/show_bug.cgi?id=193577
752
753         Reviewed by Dean Jackson.
754
755         * Configurations/FeatureDefines.xcconfig:
756
757 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
758
759         Revert r238815, it broke WK1 video fullscreen on Mac
760         https://bugs.webkit.org/show_bug.cgi?id=193586
761         <rdar://problem/47358941>
762
763         Reviewed by Jer Noble.
764
765         * WebView/WebVideoFullscreenController.h: Added.
766         * WebView/WebVideoFullscreenController.mm: Added.
767         (SOFT_LINK_CLASS):
768         (-[WebVideoFullscreenController init]):
769         (-[WebVideoFullscreenController dealloc]):
770         (-[WebVideoFullscreenController fullscreenWindow]):
771         (-[WebVideoFullscreenController windowDidLoad]):
772         (-[WebVideoFullscreenController videoElement]):
773         (-[WebVideoFullscreenController setVideoElement:]):
774         (-[WebVideoFullscreenController clearFadeAnimation]):
775         (-[WebVideoFullscreenController windowDidExitFullscreen]):
776         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
777         (-[WebVideoFullscreenController videoElementRect]):
778         (-[WebVideoFullscreenController applicationDidResignActive:]):
779         (frameExpandedToRatioOfFrame):
780         (createBackgroundFullscreenWindow):
781         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
782         (-[WebVideoFullscreenController enterFullscreen:]):
783         (-[WebVideoFullscreenController exitFullscreen]):
784         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
785         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
786         (-[WebVideoFullscreenController _requestExit]):
787         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
788         (-[WebVideoFullscreenController requestExitFullscreen]):
789         (-[WebVideoFullscreenController fadeHUDIn]):
790         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
791         (-[WebVideoFullscreenController rateChanged:]):
792         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
793         (-[WebVideoFullscreenWindow dealloc]):
794         (-[WebVideoFullscreenWindow resignFirstResponder]):
795         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
796         (-[WebVideoFullscreenWindow mouseDown:]):
797         (-[WebVideoFullscreenWindow cancelOperation:]):
798         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
799         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
800         (-[WebVideoFullscreenWindow animationDidEnd:]):
801         (-[WebVideoFullscreenWindow mouseMoved:]):
802         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
803         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
804         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
805         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
806         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
807         (-[WebVideoFullscreenHUDWindow center]):
808         (-[WebVideoFullscreenHUDWindow keyDown:]):
809         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
810         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
811         (-[WebVideoFullscreenHUDWindowController init]):
812         (-[WebVideoFullscreenHUDWindowController dealloc]):
813         (-[WebVideoFullscreenHUDWindowController setArea:]):
814         (-[WebVideoFullscreenHUDWindowController keyDown:]):
815         (-[WebVideoFullscreenHUDWindowController delegate]):
816         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
817         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
818         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
819         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
820         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
821         (-[WebVideoFullscreenHUDWindowController closeWindow]):
822         (createMediaUIControl):
823         (createControlWithMediaUIControlType):
824         (createTimeTextField):
825         (createMediaUIBackgroundView):
826         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
827         (-[WebVideoFullscreenHUDWindowController updateVolume]):
828         (-[WebVideoFullscreenHUDWindowController updateTime]):
829         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
830         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
831         (-[WebVideoFullscreenHUDWindowController currentTime]):
832         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
833         (-[WebVideoFullscreenHUDWindowController duration]):
834         (-[WebVideoFullscreenHUDWindowController maxVolume]):
835         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
836         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
837         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
838         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
839         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
840         (-[WebVideoFullscreenHUDWindowController volume]):
841         (-[WebVideoFullscreenHUDWindowController setVolume:]):
842         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
843         (-[WebVideoFullscreenHUDWindowController updateRate]):
844         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
845         (-[WebVideoFullscreenHUDWindowController playing]):
846         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
847         (timeToString):
848         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
849         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
850         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
851         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
852         (-[WebVideoFullscreenHUDWindowController rewind:]):
853         (-[WebVideoFullscreenHUDWindowController fastForward:]):
854         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
855         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
856         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
857         * WebView/WebView.mm:
858         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
859         (-[WebView _exitVideoFullscreen]):
860
861 2019-01-18  Tim Horton  <timothy_horton@apple.com>
862
863         Get rid of ADVANCED_SPELL_CHECKING
864         https://bugs.webkit.org/show_bug.cgi?id=193592
865
866         Reviewed by Wenson Hsieh.
867
868         * WebCoreSupport/WebEditorClient.mm:
869         (insertionPointFromCurrentSelection):
870         (WebEditorClient::checkTextOfParagraph):
871         (WebEditorClient::getGuessesForWord):
872         (WebEditorClient::requestCandidatesForSelection):
873         (WebEditorClient::requestCheckingOfString):
874         * WebView/WebHTMLView.mm:
875         (-[WebHTMLView insertText:]):
876
877 2019-01-18  Jer Noble  <jer.noble@apple.com>
878
879         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
880         https://bugs.webkit.org/show_bug.cgi?id=189553
881
882         Reviewed by Tim Horton.
883
884         * Configurations/Base.xcconfig:
885         * Configurations/SDKVariant.xcconfig: Added.
886         * Configurations/WebKitLegacy.xcconfig:
887
888 2019-01-18  David Kilzer  <ddkilzer@apple.com>
889
890         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
891         <https://webkit.org/b/193568>
892         <rdar://problem/47381130>
893
894         Reviewed by Alex Christensen.
895
896         * WebView/WebView.mm:
897         - Remove unused soft-linking macros.
898         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
899         (-[WebUITextIndicatorData initWithImage:scale:]):
900         - Update to use exported PAL functions.
901
902 2019-01-17  Truitt Savell  <tsavell@apple.com>
903
904         Unreviewed, rolling out r240124.
905
906         This commit broke an internal build.
907
908         Reverted changeset:
909
910         "SDK_VARIANT build destinations should be separate from non-
911         SDK_VARIANT builds"
912         https://bugs.webkit.org/show_bug.cgi?id=189553
913         https://trac.webkit.org/changeset/240124
914
915 2019-01-17  Jer Noble  <jer.noble@apple.com>
916
917         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
918         https://bugs.webkit.org/show_bug.cgi?id=189553
919
920         Reviewed by Tim Horton.
921
922         * Configurations/Base.xcconfig:
923         * Configurations/SDKVariant.xcconfig: Added.
924         * Configurations/WebKitLegacy.xcconfig:
925
926 2019-01-17  Alex Christensen  <achristensen@webkit.org>
927
928         Stop using NetworkStorageSession::storageSession in WebCore
929         https://bugs.webkit.org/show_bug.cgi?id=193529
930
931         Reviewed by Tim Horton.
932
933         * Misc/WebCache.mm:
934         (+[WebCache addImageToCache:forURL:forFrame:]):
935         * WebView/WebView.mm:
936         (-[WebView _commonInitializationWithFrameName:groupName:]):
937         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
938
939 2019-01-15  Alex Christensen  <achristensen@webkit.org>
940
941         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
942         https://bugs.webkit.org/show_bug.cgi?id=193368
943
944         Reviewed by Geoff Garen.
945
946         * Misc/WebCache.mm:
947         (+[WebCache clearCachedCredentials]):
948         * Misc/WebDownload.mm:
949         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
950         * Plugins/WebBaseNetscapePluginView.mm:
951         (WebKit::getAuthenticationInfo):
952
953 2019-01-15  Alex Christensen  <achristensen@webkit.org>
954
955         Stop using CookiesStrategy
956         https://bugs.webkit.org/show_bug.cgi?id=161106
957
958         Reviewed by Don Olmstead and Antti Koivisto.
959
960         * Misc/WebCache.mm:
961         (+[WebCache addImageToCache:forURL:forFrame:]):
962         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
963         (WebKit::NetscapePluginInstanceProxy::getCookies):
964         (WebKit::NetscapePluginInstanceProxy::setCookies):
965         * Plugins/WebNetscapePluginView.mm:
966         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
967         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
968         * WebCoreSupport/WebPlatformStrategies.h:
969         * WebCoreSupport/WebPlatformStrategies.mm:
970         (WebPlatformStrategies::createCookiesStrategy): Deleted.
971         (WebPlatformStrategies::cookiesForDOM): Deleted.
972         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
973         (WebPlatformStrategies::cookiesEnabled): Deleted.
974         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
975         (WebPlatformStrategies::getRawCookies): Deleted.
976         (WebPlatformStrategies::deleteCookie): Deleted.
977         * WebView/WebView.mm:
978         (-[WebView _commonInitializationWithFrameName:groupName:]):
979         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
980
981 2019-01-15  Tim Horton  <timothy_horton@apple.com>
982
983         Cannot tab out of WKWebView on macOS
984         https://bugs.webkit.org/show_bug.cgi?id=161448
985         <rdar://problem/28100085>
986
987         Reviewed by Dean Jackson.
988
989         * WebCoreSupport/WebChromeClient.mm:
990         * WebView/WebView.mm:
991         Make use of SPI headers.
992
993 2019-01-14  Commit Queue  <commit-queue@webkit.org>
994
995         Unreviewed, rolling out r239901, r239909, r239910, r239912,
996         r239913, and r239914.
997         https://bugs.webkit.org/show_bug.cgi?id=193407
998
999         These revisions caused an internal failure (Requested by
1000         Truitt on #webkit).
1001
1002         Reverted changesets:
1003
1004         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1005         https://bugs.webkit.org/show_bug.cgi?id=186016
1006         https://trac.webkit.org/changeset/239901
1007
1008         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1009         https://trac.webkit.org/changeset/239909
1010
1011         "Tried to fix the build."
1012         https://trac.webkit.org/changeset/239910
1013
1014         "Fixed iOS builds after r239910."
1015         https://trac.webkit.org/changeset/239912
1016
1017         "More build fixing."
1018         https://trac.webkit.org/changeset/239913
1019
1020         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1021         https://trac.webkit.org/changeset/239914
1022
1023 2019-01-14  Mark Lam  <mark.lam@apple.com>
1024
1025         Re-enable ability to build --cloop builds.
1026         https://bugs.webkit.org/show_bug.cgi?id=192955
1027         <rdar://problem/46882363>
1028
1029         Reviewed by Saam barati and Keith Miller.
1030
1031         * Configurations/FeatureDefines.xcconfig:
1032
1033 2019-01-13  Dan Bernstein  <mitz@apple.com>
1034
1035         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1036
1037         Patch by Keith Rollin.
1038
1039         * WebView/PDFViewSPI.h:
1040
1041 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1042
1043         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1044         https://bugs.webkit.org/show_bug.cgi?id=191655
1045         rdar://problem/46074680
1046
1047         Reviewed by Megan Gardner.
1048
1049         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1050         * WebView/WebView.mm:
1051         (-[WebView _effectiveAppearanceIsDark]):
1052
1053 2019-01-12  Dan Bernstein  <mitz@apple.com>
1054
1055         [Cocoa] Avoid importing directly from subumbrella frameworks
1056         https://bugs.webkit.org/show_bug.cgi?id=186016
1057         <rdar://problem/40591038>
1058
1059         Reviewed by Sam Weinig.
1060
1061         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1062         * Carbon/CarbonWindowAdapter.mm: Ditto.
1063         * Carbon/CarbonWindowFrame.m: Ditto.
1064         * Carbon/HIViewAdapter.h: Ditto.
1065         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1066           OTHER_CFLAGS_COCOA_TOUCH_NO.
1067         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1068         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1069         * WebView/WebPDFView.h: Ditto.
1070
1071 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1072
1073         Enable visual viewport API by default
1074         https://bugs.webkit.org/show_bug.cgi?id=193376
1075
1076         Reviewed by Simon Fraser.
1077
1078         * WebView/WebPreferences.mm:
1079         (+[WebPreferences initialize]):
1080
1081 2019-01-11  John Wilander  <wilander@apple.com>
1082
1083         Compile out Web API Statistics Collection
1084         https://bugs.webkit.org/show_bug.cgi?id=193370
1085         <rdar://problem/45388584>
1086
1087         Reviewed by Brent Fulgham.
1088
1089         * Configurations/FeatureDefines.xcconfig:
1090             Defined ENABLE_WEB_API_STATISTICS, off by default.
1091
1092 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1093
1094         Stop using NetworkStorageSession in WebProcess
1095         https://bugs.webkit.org/show_bug.cgi?id=193236
1096
1097         Reviewed by Don Olmstead.
1098
1099         * WebCoreSupport/WebFrameNetworkingContext.h:
1100         * WebCoreSupport/WebFrameNetworkingContext.mm:
1101         (WebFrameNetworkingContext::storageSession const):
1102         * WebCoreSupport/WebPlatformStrategies.h:
1103         * WebCoreSupport/WebPlatformStrategies.mm:
1104         (WebPlatformStrategies::cookiesForDOM):
1105         (WebPlatformStrategies::setCookiesFromDOM):
1106         (WebPlatformStrategies::cookiesEnabled):
1107         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1108         (WebPlatformStrategies::getRawCookies):
1109         (WebPlatformStrategies::deleteCookie):
1110         * WebView/WebView.mm:
1111         (-[WebView _cachedResponseForURL:]):
1112         (-[WebView _clearCredentials]):
1113
1114 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1115
1116         Unreviewed, rolling out r239727.
1117
1118         Broke API tests
1119
1120         Reverted changeset:
1121
1122         "Stop using NetworkStorageSession in WebProcess"
1123         https://bugs.webkit.org/show_bug.cgi?id=193236
1124         https://trac.webkit.org/changeset/239727
1125
1126 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1127
1128         Stop using NetworkStorageSession in WebProcess
1129         https://bugs.webkit.org/show_bug.cgi?id=193236
1130
1131         Reviewed by Don Olmstead.
1132
1133         * WebCoreSupport/WebFrameNetworkingContext.h:
1134         * WebCoreSupport/WebFrameNetworkingContext.mm:
1135         (WebFrameNetworkingContext::storageSession const):
1136         * WebView/WebView.mm:
1137         (-[WebView _cachedResponseForURL:]):
1138         (-[WebView _clearCredentials]):
1139
1140 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1141
1142         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1143         <https://webkit.org/b/193056>
1144
1145         Reviewed by Alex Christensen.
1146
1147         * Plugins/Hosted/NetscapePluginHostProxy.h:
1148         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1149         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1150         (WebKit::NetscapePluginInstanceProxy::enumerate):
1151         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1152         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1153         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1154         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1155         * Plugins/Hosted/ProxyInstance.mm:
1156         (WebKit::ProxyInstance::invoke):
1157         * WebCoreSupport/WebGeolocationClient.mm:
1158         * WebView/WebDataSource.mm:
1159         (-[WebDataSource _receivedData:]):
1160         * WebView/WebView.mm:
1161         (-[WebView _cachedResponseForURL:]):
1162         - Remove '*' from RetainPtr<> type.
1163
1164 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1165
1166         Progress towards fixing Mac CMake build
1167         https://bugs.webkit.org/show_bug.cgi?id=193105
1168
1169         Reviewed by Don Olmstead.
1170
1171         * WebKitPrefix.h:
1172
1173 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1174
1175         Web Inspector: Use save sheet instead of dialog where possible
1176         https://bugs.webkit.org/show_bug.cgi?id=193160
1177         <rdar://problem/37399759>
1178
1179         Reviewed by Devin Rousso.
1180
1181         * WebCoreSupport/WebInspectorClient.mm:
1182         (WebInspectorFrontendClient::save):
1183
1184 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1185
1186         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1187         https://bugs.webkit.org/show_bug.cgi?id=193129
1188
1189         Reviewed by Tim Horton.
1190
1191         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1192
1193         * WebCoreSupport/WebEditorClient.mm:
1194         (WebEditorClient::registerUndoOrRedoStep):
1195         (undoNameForEditAction): Deleted.
1196
1197 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1198
1199         Add support for using the current text selection as the find string on iOS
1200         https://bugs.webkit.org/show_bug.cgi?id=193034
1201         <rdar://problem/45138739>
1202
1203         Reviewed by Tim Horton.
1204
1205         Add a method stub for WebKitLegacy.
1206
1207         * WebCoreSupport/WebEditorClient.h:
1208
1209 2019-01-01  Jeff Miller  <jeffm@apple.com>
1210
1211         Update user-visible copyright strings to include 2019
1212         https://bugs.webkit.org/show_bug.cgi?id=192811
1213
1214         Reviewed by Mark Lam.
1215
1216         * Info.plist:
1217
1218 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1219
1220         Use Ref<> as much as possible
1221         https://bugs.webkit.org/show_bug.cgi?id=192808
1222
1223         Reviewed by Alex Christensen.
1224
1225         * DOM/DOM.mm:
1226         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1227         * Plugins/Hosted/NetscapePluginHostManager.mm:
1228         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1229         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1230         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1231         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1232         * Plugins/WebNetscapePluginView.mm:
1233         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1234         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1235         * WebCoreSupport/WebContextMenuClient.mm:
1236         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1237         * WebCoreSupport/WebFrameLoaderClient.mm:
1238         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1239         * WebView/WebFrame.mm:
1240         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1241         * WebView/WebHTMLView.mm:
1242         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1243         * WebView/WebView.mm:
1244         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1245         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1246
1247 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1248
1249         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1250         https://bugs.webkit.org/show_bug.cgi?id=192821
1251
1252         Reviewed by Chris Dumez.
1253
1254         When a window becomes occluded, the window server informs the application.
1255         This should be used to suspend any work that is not visible by the user.
1256
1257         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1258         In some cases, that lead to performance impact (see radar).
1259
1260         This patch adds an observer for the occlusion notification. I tried to stick
1261         with the same names used by WebKit2.
1262
1263         * WebView/WebView.mm:
1264         (-[WebView _isViewVisible]):
1265         (-[WebView addWindowObserversForWindow:]):
1266         (-[WebView removeWindowObservers]):
1267         (-[WebView _windowDidChangeOcclusionState:]):
1268
1269 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1270
1271         [WebAuthN] Add a runtime flag for local authenticator
1272         https://bugs.webkit.org/show_bug.cgi?id=192792
1273         <rdar://problem/46798738>
1274
1275         Reviewed by Brent Fulgham.
1276
1277         * WebView/WebPreferenceKeysPrivate.h:
1278         * WebView/WebPreferences.mm:
1279         (+[WebPreferences initialize]):
1280         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1281         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1282         * WebView/WebPreferencesPrivate.h:
1283         * WebView/WebView.mm:
1284         (-[WebView _preferencesChanged:]):
1285
1286 2018-12-20  Chris Dumez  <cdumez@apple.com>
1287
1288         Use Optional::valueOr() instead of Optional::value_or()
1289         https://bugs.webkit.org/show_bug.cgi?id=192933
1290
1291         Reviewed by Geoffrey Garen.
1292
1293         * WebCoreSupport/WebSecurityOrigin.mm:
1294         (-[WebSecurityOrigin port]):
1295
1296 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1297
1298         Unreviewed, rolling out r239417.
1299
1300         Introduced two API test failures on macOS.
1301
1302         Reverted changeset:
1303
1304         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1305         occlusion changes"
1306         https://bugs.webkit.org/show_bug.cgi?id=192821
1307         https://trac.webkit.org/changeset/239417
1308
1309 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1310
1311         WKWebView default UA doesn't freeze the build number
1312         https://bugs.webkit.org/show_bug.cgi?id=192809
1313         <rdar://problem/44687185>
1314
1315         Reviewed by Andy Estes.
1316
1317         Always reports the frozen build number.
1318
1319         * WebView/WebView.mm:
1320         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1321         actual build number through this method call.
1322         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1323
1324 2018-12-19  Chris Dumez  <cdumez@apple.com>
1325
1326         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1327         https://bugs.webkit.org/show_bug.cgi?id=192728
1328         <rdar://problem/46746779>
1329
1330         Reviewed by Geoff Garen.
1331
1332         * DOM/*:
1333         * Plugins/*:
1334         * WebCoreSupport/*:
1335         * WebView/*:
1336
1337 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1338
1339         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1340         https://bugs.webkit.org/show_bug.cgi?id=192821
1341
1342         Reviewed by Chris Dumez.
1343
1344         When a window becomes occluded, the window server informs the application.
1345         This should be used to suspend any work that is not visible by the user.
1346
1347         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1348         In some cases, that lead to performance impact (see radar).
1349
1350         This patch adds an observer for the occlusion notification. I tried to stick
1351         with the same names used by WebKit2.
1352
1353         * WebView/WebView.mm:
1354         (-[WebView _isViewVisible]):
1355         (-[WebView addWindowObserversForWindow:]):
1356         (-[WebView removeWindowObservers]):
1357         (-[WebView _windowDidChangeOcclusionState:]):
1358
1359 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1360
1361         Allow clients to set the navigator platform
1362         https://bugs.webkit.org/show_bug.cgi?id=192735
1363
1364         Reviewed by Tim Horton.
1365
1366         Add stubs to fill out the added functionality in FrameLoaderClient.
1367
1368         * WebCoreSupport/WebFrameLoaderClient.h:
1369         * WebCoreSupport/WebFrameLoaderClient.mm:
1370         (WebFrameLoaderClient::navigatorPlatform):
1371
1372 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1373
1374         offsetLeft and offsetParent should adjust across shadow boundaries
1375         https://bugs.webkit.org/show_bug.cgi?id=157437
1376         <rdar://problem/26154021>
1377
1378         Reviewed by Simon Fraser.
1379
1380         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1381
1382         * DOM/DOMElement.mm:
1383         (-[DOMElement offsetLeft]):
1384         (-[DOMElement offsetTop]):
1385         (-[DOMElement offsetParent]):
1386
1387 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1388
1389         Unreviewed build fix.
1390
1391         * WebView/WebFrame.mm:
1392         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1393
1394 2018-12-15  Darin Adler  <darin@apple.com>
1395
1396         Use warning-ignoring macros more consistently and simply
1397         https://bugs.webkit.org/show_bug.cgi?id=192743
1398
1399         Reviewed by Mark Lam.
1400
1401         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1402         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1403         compilers in Objective-C++ code.
1404
1405         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1406         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1407         accomodate non-clang compilers here. Also use #pragma once, add a missing
1408         "explicit" and fix conditionals.
1409
1410 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1411
1412         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1413         https://bugs.webkit.org/show_bug.cgi?id=192653
1414
1415         Reviewed by Wenson Hsieh.
1416
1417         * WebView/WebHTMLView.mm:
1418         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1419
1420 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1421
1422         Implement feature flag for CSS Typed OM
1423         https://bugs.webkit.org/show_bug.cgi?id=192610
1424
1425         Reviewed by Ryosuke Niwa.
1426
1427         * Configurations/FeatureDefines.xcconfig:
1428
1429 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1430
1431         WebCore shouldn't have a Objective-C class named NSCursor
1432         https://bugs.webkit.org/show_bug.cgi?id=192602
1433         <rdar://problem/46615532>
1434
1435         Reviewed by Wenson Hsieh.
1436
1437         * WebView/WebFrameView.mm:
1438         (-[WebFrameView keyDown:keyDown:]):
1439         * WebView/WebHTMLView.mm:
1440         (-[WebHTMLView keyDown:]):
1441         (-[WebHTMLView performKeyEquivalent:]):
1442         Only use NSCursor on macOS.
1443
1444 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1445
1446         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1447         https://bugs.webkit.org/show_bug.cgi?id=192573
1448
1449         Reviewed by Simon Fraser.
1450
1451         * Configurations/FeatureDefines.xcconfig:
1452
1453 2018-12-10  Antti Koivisto  <antti@apple.com>
1454
1455         Rename "forced style recalc" to "full style rebuild"
1456         https://bugs.webkit.org/show_bug.cgi?id=192572
1457
1458         Reviewed by Zalan Bujtas.
1459
1460         * WebView/WebHTMLView.mm:
1461         (-[WebHTMLView setNeedsToApplyStyles:]):
1462
1463 2018-12-10  Darin Adler  <darin@apple.com>
1464
1465         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1466         https://bugs.webkit.org/show_bug.cgi?id=192533
1467         rdar://problem/45732710
1468
1469         Reviewed by Anders Carlsson.
1470
1471         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1472         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1473
1474 2018-12-10  Darin Adler  <darin@apple.com>
1475
1476         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1477         https://bugs.webkit.org/show_bug.cgi?id=192532
1478         rdar://problem/45731047
1479
1480         Reviewed by Chris Dumez.
1481
1482         * Plugins/Hosted/NetscapePluginHostManager.mm:
1483         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1484         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1485         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1486
1487 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1488
1489         Turn WritingDirection into an enum class
1490         https://bugs.webkit.org/show_bug.cgi?id=192401
1491         Work towards <rdar://problem/42075638>
1492
1493         Reviewed by Dan Bernstein.
1494
1495         Change WritingDirection from an enum to an enum class. No change in behavior.
1496
1497         * WebView/WebHTMLView.mm:
1498         (-[WebHTMLView toggleBaseWritingDirection:]):
1499         (-[WebHTMLView changeBaseWritingDirection:]):
1500         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1501
1502 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1503
1504         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1505         https://bugs.webkit.org/show_bug.cgi?id=192272
1506
1507         Reviewed by Brady Eidson.
1508
1509         * WebCoreSupport/WebFrameLoaderClient.h:
1510         * WebCoreSupport/WebFrameLoaderClient.mm:
1511         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1512
1513 2018-12-03  Jer Noble  <jer.noble@apple.com>
1514
1515         Get rid of old, dead Mac video fullscreen code.
1516         https://bugs.webkit.org/show_bug.cgi?id=192315
1517
1518         Reviewed by Eric Carlson.
1519
1520         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1521         is no longer supported in the Mac port.
1522
1523         * WebView/WebVideoFullscreenController.h: Removed.
1524         * WebView/WebVideoFullscreenController.mm: Removed.
1525         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1526         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1527         * WebView/WebView.mm:
1528         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1529         (-[WebView _exitVideoFullscreen]):
1530
1531 2018-12-03  Daniel Bates  <dabates@apple.com>
1532
1533         [iOS] Do not handle key events that are key commands
1534         https://bugs.webkit.org/show_bug.cgi?id=191608
1535         <rdar://problem/46046013>
1536
1537         Reviewed by Ryosuke Niwa.
1538
1539         A key down event may be associated with a key command. If it is then we want to execute the
1540         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1541         event as a key command to find out.
1542
1543         * WebView/WebHTMLView.mm:
1544         (-[WebHTMLView _handleEditingKeyEvent:]):
1545
1546 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1547
1548         Add a runtime feature flag for LayoutFormattingContext.
1549         https://bugs.webkit.org/show_bug.cgi?id=192280
1550
1551         Reviewed by Simon Fraser.
1552
1553         * Configurations/FeatureDefines.xcconfig:
1554
1555 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1556
1557         Move URL from WebCore to WTF
1558         https://bugs.webkit.org/show_bug.cgi?id=190234
1559
1560         Reviewed by Keith Miller.
1561
1562         * DOM/DOMAttr.mm:
1563         * DOM/DOMBlob.mm:
1564         * DOM/DOMCSSCharsetRule.mm:
1565         * DOM/DOMCSSImportRule.mm:
1566         * DOM/DOMCSSMediaRule.mm:
1567         * DOM/DOMCSSPageRule.mm:
1568         * DOM/DOMCSSPrimitiveValue.mm:
1569         * DOM/DOMCSSRule.mm:
1570         * DOM/DOMCSSStyleDeclaration.mm:
1571         * DOM/DOMCSSStyleRule.mm:
1572         * DOM/DOMCSSStyleSheet.mm:
1573         * DOM/DOMCSSValue.mm:
1574         * DOM/DOMCharacterData.mm:
1575         * DOM/DOMCounter.mm:
1576         * DOM/DOMDocument.mm:
1577         * DOM/DOMDocumentFragment.mm:
1578         * DOM/DOMDocumentType.mm:
1579         * DOM/DOMEvent.mm:
1580         * DOM/DOMFile.mm:
1581         * DOM/DOMHTMLAnchorElement.mm:
1582         * DOM/DOMHTMLAppletElement.mm:
1583         * DOM/DOMHTMLAreaElement.mm:
1584         * DOM/DOMHTMLBRElement.mm:
1585         * DOM/DOMHTMLBaseElement.mm:
1586         * DOM/DOMHTMLBaseFontElement.mm:
1587         * DOM/DOMHTMLBodyElement.mm:
1588         * DOM/DOMHTMLButtonElement.mm:
1589         * DOM/DOMHTMLCanvasElement.mm:
1590         * DOM/DOMHTMLCollection.mm:
1591         * DOM/DOMHTMLDivElement.mm:
1592         * DOM/DOMHTMLDocument.mm:
1593         * DOM/DOMHTMLElement.mm:
1594         * DOM/DOMHTMLEmbedElement.mm:
1595         * DOM/DOMHTMLFieldSetElement.mm:
1596         * DOM/DOMHTMLFontElement.mm:
1597         * DOM/DOMHTMLFormElement.mm:
1598         * DOM/DOMHTMLFrameElement.mm:
1599         * DOM/DOMHTMLFrameSetElement.mm:
1600         * DOM/DOMHTMLHRElement.mm:
1601         * DOM/DOMHTMLHeadElement.mm:
1602         * DOM/DOMHTMLHeadingElement.mm:
1603         * DOM/DOMHTMLHtmlElement.mm:
1604         * DOM/DOMHTMLIFrameElement.mm:
1605         * DOM/DOMHTMLImageElement.mm:
1606         * DOM/DOMHTMLInputElement.mm:
1607         * DOM/DOMHTMLLIElement.mm:
1608         * DOM/DOMHTMLLabelElement.mm:
1609         * DOM/DOMHTMLLegendElement.mm:
1610         * DOM/DOMHTMLLinkElement.mm:
1611         * DOM/DOMHTMLMapElement.mm:
1612         * DOM/DOMHTMLMarqueeElement.mm:
1613         * DOM/DOMHTMLMediaElement.mm:
1614         * DOM/DOMHTMLMetaElement.mm:
1615         * DOM/DOMHTMLModElement.mm:
1616         * DOM/DOMHTMLOListElement.mm:
1617         * DOM/DOMHTMLObjectElement.mm:
1618         * DOM/DOMHTMLOptGroupElement.mm:
1619         * DOM/DOMHTMLOptionElement.mm:
1620         * DOM/DOMHTMLOptionsCollection.mm:
1621         * DOM/DOMHTMLParagraphElement.mm:
1622         * DOM/DOMHTMLParamElement.mm:
1623         * DOM/DOMHTMLQuoteElement.mm:
1624         * DOM/DOMHTMLScriptElement.mm:
1625         * DOM/DOMHTMLSelectElement.mm:
1626         * DOM/DOMHTMLStyleElement.mm:
1627         * DOM/DOMHTMLTableCaptionElement.mm:
1628         * DOM/DOMHTMLTableCellElement.mm:
1629         * DOM/DOMHTMLTableColElement.mm:
1630         * DOM/DOMHTMLTableElement.mm:
1631         * DOM/DOMHTMLTableRowElement.mm:
1632         * DOM/DOMHTMLTableSectionElement.mm:
1633         * DOM/DOMHTMLTitleElement.mm:
1634         * DOM/DOMHTMLUListElement.mm:
1635         * DOM/DOMHTMLVideoElement.mm:
1636         * DOM/DOMKeyboardEvent.mm:
1637         * DOM/DOMMediaList.mm:
1638         * DOM/DOMMouseEvent.mm:
1639         * DOM/DOMMutationEvent.mm:
1640         * DOM/DOMNamedNodeMap.mm:
1641         * DOM/DOMProcessingInstruction.mm:
1642         * DOM/DOMRange.mm:
1643         * DOM/DOMStyleSheet.mm:
1644         * DOM/DOMText.mm:
1645         * DOM/DOMTextEvent.mm:
1646         * DOM/DOMTokenList.mm:
1647         * DOM/DOMUIEvent.mm:
1648         * DOM/DOMXPathResult.mm:
1649         * History/WebHistoryItem.mm:
1650         * Misc/WebNSURLExtras.mm:
1651         (-[NSURL _web_userVisibleString]):
1652         (-[NSURL _web_URLByRemovingUserInfo]):
1653         (-[NSURL _web_dataForURLComponentType:]):
1654         (-[NSURL _web_schemeData]):
1655         (-[NSURL _web_hostData]):
1656         * Misc/WebUserContentURLPattern.mm:
1657         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1658         * Plugins/WebNetscapePluginStream.h:
1659         (WebNetscapePluginStream::setRequestURL):
1660         * WebCoreSupport/WebChromeClient.h:
1661         * WebCoreSupport/WebChromeClient.mm:
1662         (WebChromeClient::signedPublicKeyAndChallengeString const):
1663         * WebCoreSupport/WebContextMenuClient.h:
1664         * WebCoreSupport/WebContextMenuClient.mm:
1665         * WebCoreSupport/WebDragClient.h:
1666         * WebCoreSupport/WebFrameLoaderClient.h:
1667         * WebCoreSupport/WebFrameLoaderClient.mm:
1668         (WebFrameLoaderClient::updateGlobalHistory):
1669         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1670         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1671         (WebPaymentCoordinatorClient::showPaymentUI):
1672         * WebCoreSupport/WebPlatformStrategies.h:
1673         * WebCoreSupport/WebPlatformStrategies.mm:
1674         (WebPlatformStrategies::readURLFromPasteboard):
1675         * WebCoreSupport/WebPluginInfoProvider.h:
1676         * WebCoreSupport/WebPluginInfoProvider.mm:
1677         (WebPluginInfoProvider::webVisiblePluginInfo):
1678         * WebCoreSupport/WebSecurityOrigin.mm:
1679         * WebCoreSupport/WebVisitedLinkStore.h:
1680         * WebView/WebDataSource.mm:
1681         * WebView/WebFrame.mm:
1682         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1683         * WebView/WebImmediateActionController.mm:
1684         (-[WebImmediateActionController _defaultAnimationController]):
1685         * WebView/WebPDFView.mm:
1686         * WebView/WebScriptDebugger.mm:
1687         * WebView/WebViewInternal.h:
1688
1689 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1690
1691         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1692         https://bugs.webkit.org/show_bug.cgi?id=192197
1693
1694         Reviewed by Jiewen Tan.
1695
1696         * Configurations/FeatureDefines.xcconfig:
1697         * WebCoreSupport/WebChromeClient.h:
1698         * WebCoreSupport/WebChromeClient.mm:
1699
1700 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1701
1702         Remove dead code from an earlier attempt at implementing safe browsing
1703         https://bugs.webkit.org/show_bug.cgi?id=192067
1704
1705         Reviewed by Chris Dumez.
1706
1707         * WebCoreSupport/WebFrameLoaderClient.h:
1708         * WebCoreSupport/WebFrameLoaderClient.mm:
1709         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1710
1711 2018-11-27  Mark Lam  <mark.lam@apple.com>
1712
1713         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1714         https://bugs.webkit.org/show_bug.cgi?id=192055
1715         <rdar://problem/46288783>
1716
1717         Reviewed by Saam Barati.
1718
1719         * Configurations/FeatureDefines.xcconfig:
1720
1721 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1722
1723         Make it possible to insert editable images with a gesture
1724         https://bugs.webkit.org/show_bug.cgi?id=191937
1725
1726         Reviewed by Wenson Hsieh.
1727
1728         * WebCoreSupport/WebEditorClient.mm:
1729         (undoNameForEditAction):
1730         Add a undo name.
1731
1732 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1733
1734         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1735         https://bugs.webkit.org/show_bug.cgi?id=191945
1736
1737         Reviewed by Anders Carlsson.
1738
1739         * WebCoreSupport/WebEditorClient.mm:
1740         (undoNameForEditAction):
1741
1742 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1743
1744         Enable drag and drop support for iOSMac
1745         https://bugs.webkit.org/show_bug.cgi?id=191818
1746         <rdar://problem/43907454>
1747
1748         Reviewed by Dean Jackson.
1749
1750         * Configurations/FeatureDefines.xcconfig:
1751
1752 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1753
1754         Address post-review feedback after r238438
1755         https://bugs.webkit.org/show_bug.cgi?id=191913
1756
1757         Reviewed by Ryosuke Niwa.
1758
1759         * WebView/WebFrame.mm:
1760         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1761         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1762         * WebView/WebView.mm:
1763         (-[WebView setSelectedDOMRange:affinity:]):
1764
1765 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1766
1767         Web Inspector: "Reload Web Inspector" button no longer partially works
1768         https://bugs.webkit.org/show_bug.cgi?id=191773
1769         <rdar://problem/46139932>
1770
1771         Reviewed by Devin Rousso.
1772
1773         * WebCoreSupport/WebInspectorClient.h:
1774         * WebCoreSupport/WebInspectorClient.mm:
1775         (WebInspectorFrontendClient::reopen):
1776
1777 2018-11-17  Devin Rousso  <drousso@apple.com>
1778
1779         Web Inspector: Network: add button to show system certificate dialog
1780         https://bugs.webkit.org/show_bug.cgi?id=191458
1781         <rdar://problem/45977019>
1782
1783         Reviewed by Joseph Pecoraro.
1784
1785         * WebCoreSupport/WebInspectorClient.h:
1786         * WebCoreSupport/WebInspectorClient.mm:
1787         (WebInspectorFrontendClient::showCertificate): Added.
1788
1789         * Configurations/WebKitLegacy.xcconfig:
1790
1791 2018-11-15  Truitt Savell  <tsavell@apple.com>
1792
1793         Unreviewed, rolling out r238244.
1794
1795         Caused High Sierra test runs to fail early with 50 crashes and
1796         casued 25 API failures.
1797
1798         Reverted changeset:
1799
1800         "[css-logical] Implement flow-relative margin, padding and
1801         border shorthands"
1802         https://bugs.webkit.org/show_bug.cgi?id=188697
1803         https://trac.webkit.org/changeset/238244
1804
1805 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
1806
1807         [css-logical] Implement flow-relative margin, padding and border shorthands
1808         https://bugs.webkit.org/show_bug.cgi?id=188697
1809
1810         Reviewed by Simon Fraser and Antti Koivisto.
1811
1812         Add CSSLogicalEnabled runtime flag.
1813
1814         * WebView/WebPreferenceKeysPrivate.h:
1815         * WebView/WebPreferences.mm:
1816         (+[WebPreferences initialize]):
1817         (-[WebPreferences cssLogicalEnabled]):
1818         (-[WebPreferences setCSSLogicalEnabled:]):
1819         * WebView/WebPreferencesPrivate.h:
1820         * WebView/WebView.mm:
1821         (-[WebView _preferencesChanged:]):
1822
1823 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1824
1825         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
1826         https://bugs.webkit.org/show_bug.cgi?id=191612
1827
1828         Reviewed by Matt Baker.
1829
1830         * WebCoreSupport/WebInspectorClient.mm:
1831         (-[WebInspectorWindowController destroyInspectorView]):
1832
1833 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
1834
1835         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
1836         https://bugs.webkit.org/show_bug.cgi?id=191494
1837         <rdar://problem/45469854>
1838
1839         Reviewed by Devin Rousso.
1840
1841         * WebCoreSupport/WebInspectorClient.h:
1842         WebKitLegacy will still have remote inspection of the Page directly.
1843
1844 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
1845
1846         Make compositing updates incremental
1847         https://bugs.webkit.org/show_bug.cgi?id=90342
1848
1849         Reviewed by Antti Koivisto.
1850
1851         Fix spelling error.
1852
1853         * WebView/WebView.mm:
1854         (-[WebView _setMediaLayer:forPluginView:]):
1855
1856 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1857
1858         Implement a new edit command to change the enclosing list type
1859         https://bugs.webkit.org/show_bug.cgi?id=191487
1860         <rdar://problem/45955922>
1861
1862         Reviewed by Ryosuke Niwa.
1863
1864         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
1865
1866         * WebCoreSupport/WebEditorClient.mm:
1867         (undoNameForEditAction):
1868
1869 2018-11-11  Daniel Bates  <dabates@apple.com>
1870
1871         [iOS] Draw caps lock indicator in password fields
1872         https://bugs.webkit.org/show_bug.cgi?id=190565
1873         <rdar://problem/45262343>
1874
1875         Reviewed by Dean Jackson.
1876
1877         Update the caps lock state when a hardware keyboard is attached or detached.
1878
1879         * WebView/WebHTMLView.mm:
1880         (hardwareKeyboardAvailabilityChangedCallback): Added.
1881         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1882         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1883
1884 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
1885
1886         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1887         https://bugs.webkit.org/show_bug.cgi?id=191492
1888
1889         Reviewed by Alex Christensen.
1890
1891         * Carbon/HIWebView.mm:
1892         * Misc/WebNSFileManagerExtras.mm:
1893         * Misc/WebNSURLExtras.mm:
1894         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1895         * Plugins/WebBasePluginPackage.mm:
1896         * Plugins/WebPluginContainerCheck.mm:
1897         * WebCoreSupport/WebCachedFramePlatformData.h:
1898         * WebCoreSupport/WebDeviceOrientationClient.mm:
1899         * WebView/WebDelegateImplementationCaching.mm:
1900         * WebView/WebHTMLView.mm:
1901         * WebView/WebPDFRepresentation.mm:
1902         * WebView/WebPolicyDelegate.mm:
1903         * WebView/WebView.mm:
1904
1905 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
1906
1907         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
1908         https://bugs.webkit.org/show_bug.cgi?id=191492
1909
1910         Reviewed by Alex Christensen.
1911
1912         * Carbon/HIWebView.mm:
1913         (UpdateCommandStatus):
1914         * Misc/WebNSFileManagerExtras.mm:
1915         * Misc/WebNSURLExtras.mm:
1916         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1917         * Plugins/WebBasePluginPackage.mm:
1918         * Plugins/WebPluginContainerCheck.mm:
1919         (-[WebPluginContainerCheck _continueWithPolicy:]):
1920         * WebCoreSupport/WebCachedFramePlatformData.h:
1921         (WebCachedFramePlatformData::clear):
1922         * WebCoreSupport/WebDeviceOrientationClient.mm:
1923         (WebDeviceOrientationClient::getProvider const):
1924         * WebView/WebDelegateImplementationCaching.mm:
1925         (CallDelegate):
1926         (CallDelegateReturningBoolean):
1927         (CallResourceLoadDelegateReturningBoolean):
1928         (CallFormDelegate):
1929         (CallFormDelegateReturningBoolean):
1930         * WebView/WebHTMLView.mm:
1931         * WebView/WebPDFRepresentation.mm:
1932         * WebView/WebPolicyDelegate.mm:
1933         (-[WebPolicyDecisionListener _usePolicy:]):
1934         * WebView/WebView.mm:
1935
1936 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
1937
1938         Unreviewed, rolling out r238047.
1939
1940         Introduced layout test failures on iOS simulator.
1941
1942         Reverted changeset:
1943
1944         "[iOS] Draw caps lock indicator in password fields"
1945         https://bugs.webkit.org/show_bug.cgi?id=190565
1946         https://trac.webkit.org/changeset/238047
1947
1948 2018-11-09  Antti Koivisto  <antti@apple.com>
1949
1950         Use OptionSet for layout milestones
1951         https://bugs.webkit.org/show_bug.cgi?id=191470
1952
1953         Reviewed by Dean Jackson.
1954
1955         * WebCoreSupport/WebFrameLoaderClient.h:
1956         * WebCoreSupport/WebFrameLoaderClient.mm:
1957         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
1958         * WebView/WebView.mm:
1959         (coreLayoutMilestones):
1960         (kitLayoutMilestones):
1961         (-[WebView _cacheFrameLoadDelegateImplementations]):
1962         * WebView/WebViewInternal.h:
1963
1964 2018-11-09  Daniel Bates  <dabates@apple.com>
1965
1966         [iOS] Draw caps lock indicator in password fields
1967         https://bugs.webkit.org/show_bug.cgi?id=190565
1968         <rdar://problem/45262343>
1969
1970         Reviewed by Dean Jackson.
1971
1972         Update the caps lock state when a hardware keyboard is attached or detached.
1973
1974         * WebView/WebHTMLView.mm:
1975         (hardwareKeyboardAvailabilityChangedCallback): Added.
1976         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
1977         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
1978
1979 2018-11-09  Daniel Bates  <dabates@apple.com>
1980
1981         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
1982         action when forward delete is pressed outside a text field
1983         https://bugs.webkit.org/show_bug.cgi?id=190566
1984         <rdar://problem/45262367>
1985
1986         Reviewed by Wenson Hsieh.
1987
1988         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
1989         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
1990         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
1991
1992         * WebView/WebHTMLView.mm:
1993         (-[WebHTMLView _handleEditingKeyEvent:]):
1994
1995 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
1996
1997         Adopt Reveal Framework to replace Lookup
1998         https://bugs.webkit.org/show_bug.cgi?id=191097
1999         <rdar://problem/45924508>
2000
2001         Reviewed by Tim Horton.
2002
2003         Pass in what it needed to clear the textIndicators. This is better than
2004         the current notification structure.
2005
2006         * WebView/WebView.mm:
2007         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2008         (-[WebView _prepareForDictionaryLookup]):
2009
2010 2018-11-06  Justin Fan  <justin_fan@apple.com>
2011
2012         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2013         https://bugs.webkit.org/show_bug.cgi?id=191291
2014
2015         Reviewed by Myles Maxfield.
2016
2017         Properly disable WEBGPU on all non-Metal platforms for now.
2018
2019         * Configurations/FeatureDefines.xcconfig:
2020
2021 2018-11-02  Daniel Bates  <dabates@apple.com>
2022
2023         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2024         https://bugs.webkit.org/show_bug.cgi?id=190487
2025
2026         Reviewed by Tim Horton.
2027
2028         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
2029         allow the default handling.
2030
2031         * WebView/WebHTMLView.mm:
2032         (-[WebHTMLView _handleEditingKeyEvent:]):
2033
2034 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2035
2036         Add a storage limit for IndexedDB
2037         https://bugs.webkit.org/show_bug.cgi?id=190598
2038         <rdar://problem/44654715>
2039
2040         Reviewed by Chris Dumez.
2041
2042         * Storage/WebDatabaseManager.mm:
2043         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2044         * Storage/WebDatabaseManagerPrivate.h:
2045
2046 2018-10-31  Antti Koivisto  <antti@apple.com>
2047
2048         Remove LayerFlushScheduler
2049         https://bugs.webkit.org/show_bug.cgi?id=191103
2050
2051         Reviewed by Anders Carlsson.
2052
2053         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2054         all the virtual cruft.
2055
2056         * WebView/WebViewData.h:
2057         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2058         (): Deleted.
2059         * WebView/WebViewData.mm:
2060         (currentRunLoop):
2061         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2062         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2063         (WebViewLayerFlushScheduler::schedule):
2064         (WebViewLayerFlushScheduler::invalidate):
2065         (WebViewLayerFlushScheduler::layerFlushCallback):
2066
2067 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2068
2069         Enable InstallAPI for iOS unconditionally
2070         https://bugs.webkit.org/show_bug.cgi?id=191043
2071         rdar://problem/32728423
2072
2073         Reviewed by Dan Bernstein.
2074
2075         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2076         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2077         shouldn't be processed by InstallAPI.
2078         * MigrateHeaders.make: Removed an obsolete workaround.
2079         * Misc/NSURLDownloadSPI.h: Added.
2080         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2081
2082 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2083
2084         Clean up some obsolete MAX_ALLOWED macros
2085         https://bugs.webkit.org/show_bug.cgi?id=190916
2086
2087         Reviewed by Tim Horton.
2088
2089         * WebView/WebHTMLView.mm:
2090         (-[WebHTMLView pressureChangeWithEvent:]):
2091         * WebView/WebPDFView.h:
2092
2093 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2094
2095         Unreviewed, rolling out r237600 and r237604.
2096         https://bugs.webkit.org/show_bug.cgi?id=191086
2097
2098         Breaks internal iOS builds (Requested by ryanhadd_ on
2099         #webkit).
2100
2101         Reverted changesets:
2102
2103         "Enable InstallAPI for iOS unconditionally"
2104         https://bugs.webkit.org/show_bug.cgi?id=191043
2105         https://trac.webkit.org/changeset/237600
2106
2107         "Build fix attempt after enabling InstallAPI for iOS."
2108         https://bugs.webkit.org/show_bug.cgi?id=191043
2109         https://trac.webkit.org/changeset/237604
2110
2111 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2112
2113         Enable InstallAPI for iOS unconditionally
2114         https://bugs.webkit.org/show_bug.cgi?id=191043
2115         rdar://problem/32728423
2116
2117         Reviewed by Dan Bernstein.
2118
2119         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2120         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2121         shouldn't be processed by InstallAPI.
2122         * MigrateHeaders.make: Removed an obsolete workaround.
2123         * Misc/NSURLDownloadSPI.h: Added.
2124         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2125
2126 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2127
2128         Modernize WebKit nibs and lprojs for localization's sake
2129         https://bugs.webkit.org/show_bug.cgi?id=190911
2130         <rdar://problem/45349466>
2131
2132         Reviewed by Dan Bernstein.
2133
2134         * Misc/WebNSControlExtras.m:
2135         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2136         NSWindow and its contents are both in the same scale space these days; avoid
2137         double-applying the scale factor, or you can't see the prompt.
2138
2139         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2140         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2141         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2142         NIB->XIB
2143
2144 2018-10-25  Antoine Quint  <graouts@apple.com>
2145
2146         [Web Animations] Turn Web Animations CSS Integration off by default
2147         https://bugs.webkit.org/show_bug.cgi?id=190901
2148
2149         Reviewed by Dean Jackson.
2150
2151         * WebView/WebPreferences.mm:
2152         (+[WebPreferences initialize]):
2153
2154 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2155
2156         Clean up some obsolete macOS version guards
2157         https://bugs.webkit.org/show_bug.cgi?id=190887
2158
2159         Reviewed by Dan Bernstein.
2160
2161         * Misc/WebNSPasteboardExtras.mm:
2162         (+[NSPasteboard _web_dragTypesForURL]):
2163         * WebCoreSupport/PopupMenuMac.mm:
2164         (PopupMenuMac::show):
2165         * WebCoreSupport/WebEditorClient.h:
2166         * WebCoreSupport/WebEditorClient.mm:
2167         (WebEditorClient::respondToChangedSelection):
2168         * WebView/WebPDFView.mm:
2169         (-[WebPDFView _clipViewForPDFDocumentView]):
2170
2171 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2172
2173         Turn on Conic Gradients
2174         https://bugs.webkit.org/show_bug.cgi?id=190810
2175
2176         Reviewed by Tim Horton.
2177
2178         * Configurations/FeatureDefines.xcconfig:
2179
2180 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2181
2182         Cleanup: MIMETypeRegistry functions
2183         https://bugs.webkit.org/show_bug.cgi?id=190838
2184
2185         Reviewed by Simon Fraser.
2186
2187         * Misc/WebNSPasteboardExtras.mm:
2188         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2189         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2190         because they were identical.
2191
2192         * WebView/WebHTMLRepresentation.mm:
2193         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2194         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2195         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2196         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2197         * WebView/WebView.mm:
2198         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2199         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2200         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2201
2202 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2203
2204         Fix false positive leaks when using custom -init methods that don't start with -init
2205         <https://webkit.org/b/190818>
2206         <rdar://problem/45476042>
2207
2208         Reviewed by Dan Bernstein.
2209
2210         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2211         it is accessible by both categories.
2212         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2213         NSError (WebKitInternal) category.  Add attribute to make this
2214         behave like an -init method.
2215         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2216         NSError (WebKitInternal) category.  Modernize method.  Replace
2217         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2218
2219 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2220
2221         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2222         https://bugs.webkit.org/show_bug.cgi?id=190729
2223
2224         Reviewed by Tim Horton.
2225
2226         * DOM/DOM.mm:
2227         (-[DOMNode boundingBox]):
2228         * DOM/DOMElement.mm:
2229         * DOM/DOMHTML.mm:
2230         * DOM/DOMInternal.mm:
2231         * DOM/DOMUIKitExtensions.mm:
2232         * DOM/WebDOMOperations.mm:
2233         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2234         * DefaultDelegates/WebDefaultEditingDelegate.m:
2235         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2236         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2237         * DefaultDelegates/WebDefaultUIDelegate.h:
2238         * DefaultDelegates/WebDefaultUIDelegate.mm:
2239         (-[WebDefaultUIDelegate webViewClose:]):
2240         (-[WebDefaultUIDelegate webViewFocus:]):
2241         (-[WebDefaultUIDelegate webViewUnfocus:]):
2242         (-[WebDefaultUIDelegate webViewIsResizable:]):
2243         (-[WebDefaultUIDelegate webView:setResizable:]):
2244         (-[WebDefaultUIDelegate webView:setFrame:]):
2245         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2246         * History/BackForwardList.h:
2247         * History/BackForwardList.mm:
2248         * History/WebBackForwardList.mm:
2249         (+[WebBackForwardList initialize]):
2250         (bumperCarBackForwardHackNeeded):
2251         * History/WebHistory.mm:
2252         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2253         (-[WebHistory _sendNotification:entries:]):
2254         (-[WebHistory loadFromURL:error:]):
2255         (-[WebHistory saveToURL:error:]):
2256         * History/WebHistoryItem.mm:
2257         (WKNotifyHistoryItemChanged):
2258         (+[WebHistoryItem initialize]):
2259         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2260         * History/WebURLsWithTitles.m:
2261         * Misc/WebCache.mm:
2262         (+[WebCache initialize]):
2263         * Misc/WebDownload.mm:
2264         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2265         * Misc/WebElementDictionary.mm:
2266         (+[WebElementDictionary initialize]):
2267         (+[WebElementDictionary initializeLookupTable]):
2268         * Misc/WebIconDatabase.mm:
2269         * Misc/WebKitNSStringExtras.mm:
2270         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2271         * Misc/WebKitVersionChecks.h:
2272         * Misc/WebKitVersionChecks.mm:
2273         (WebKitLinkedOnOrAfter):
2274         (WebKitLinkTimeVersion):
2275         * Misc/WebLocalizableStrings.mm:
2276         * Misc/WebNSControlExtras.h:
2277         * Misc/WebNSControlExtras.m:
2278         * Misc/WebNSEventExtras.m:
2279         * Misc/WebNSFileManagerExtras.mm:
2280         * Misc/WebNSImageExtras.h:
2281         * Misc/WebNSImageExtras.m:
2282         * Misc/WebNSPasteboardExtras.mm:
2283         * Misc/WebNSPrintOperationExtras.h:
2284         * Misc/WebNSPrintOperationExtras.m:
2285         * Misc/WebNSViewExtras.m:
2286         * Misc/WebNSWindowExtras.m:
2287         * Panels/WebAuthenticationPanel.h:
2288         * Panels/WebAuthenticationPanel.m:
2289         * Panels/WebPanelAuthenticationHandler.m:
2290         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2291         (+[WebHostedNetscapePluginView initialize]):
2292         * Plugins/WebBasePluginPackage.h:
2293         * Plugins/WebBasePluginPackage.mm:
2294         * Plugins/WebJavaPlugIn.h:
2295         * Plugins/WebPluginContainerCheck.mm:
2296         * Plugins/WebPluginController.h:
2297         * Plugins/WebPluginController.mm:
2298         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2299         (-[WebPluginController addPlugin:]):
2300         (-[WebPluginController destroyPlugin:]):
2301         (-[WebPluginController destroyAllPlugins]):
2302         * Plugins/WebPluginDatabase.mm:
2303         (+[WebPluginDatabase _defaultPlugInPaths]):
2304         * Plugins/WebPluginPackage.mm:
2305         (-[WebPluginPackage initWithPath:]):
2306         * Storage/WebDatabaseManager.mm:
2307         (-[WebDatabaseManager deleteAllDatabases]):
2308         * Storage/WebDatabaseManagerClient.h:
2309         * Storage/WebDatabaseManagerClient.mm:
2310         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2311         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2312         * Storage/WebStorageManager.mm:
2313         (-[WebStorageManager deleteAllOrigins]):
2314         (WebKitInitializeStorageIfNecessary):
2315         * WebCoreSupport/WebAlternativeTextClient.h:
2316         * WebCoreSupport/WebApplicationCache.mm:
2317         (applicationCacheBundleIdentifier):
2318         * WebCoreSupport/WebChromeClient.h:
2319         * WebCoreSupport/WebChromeClient.mm:
2320         (WebChromeClient::setWindowRect):
2321         (WebChromeClient::windowRect):
2322         (WebChromeClient::takeFocus):
2323         (WebChromeClient::addMessageToConsole):
2324         (WebChromeClient::enableSuddenTermination):
2325         (WebChromeClient::disableSuddenTermination):
2326         (WebChromeClient::createPopupMenu const):
2327         (WebChromeClient::createSearchPopupMenu const):
2328         (WebChromeClient::shouldPaintEntireContents const):
2329         (WebChromeClient::supportsVideoFullscreen):
2330         (WebChromeClient::supportsFullScreenForElement):
2331         (WebChromeClient::enterFullScreenForElement):
2332         (WebChromeClient::exitFullScreenForElement):
2333         * WebCoreSupport/WebContextMenuClient.mm:
2334         * WebCoreSupport/WebDragClient.mm:
2335         * WebCoreSupport/WebEditorClient.h:
2336         * WebCoreSupport/WebEditorClient.mm:
2337         (+[WebUndoStep initialize]):
2338         (updateFontPanel):
2339         (WebEditorClient::didBeginEditing):
2340         (WebEditorClient::respondToChangedContents):
2341         (WebEditorClient::respondToChangedSelection):
2342         (WebEditorClient::canceledComposition):
2343         (WebEditorClient::didEndEditing):
2344         (WebEditorClient::didWriteSelectionToPasteboard):
2345         (attributesForAttributedStringConversion):
2346         (WebEditorClient::setInsertionPasteboard):
2347         (WebEditorClient::registerUndoOrRedoStep):
2348         (WebEditorClient::handleKeyboardEvent):
2349         (WebEditorClient::handleInputMethodKeydown):
2350         (WebEditorClient::textDidChangeInTextField):
2351         (WebEditorClient::requestCheckingOfString):
2352         * WebCoreSupport/WebFrameLoaderClient.h:
2353         * WebCoreSupport/WebFrameLoaderClient.mm:
2354         (WebFrameLoaderClient::detachedFromParent2):
2355         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2356         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2357         (WebFrameLoaderClient::dispatchWillSendRequest):
2358         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2359         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2360         (WebFrameLoaderClient::willCacheResponse const):
2361         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2362         (WebFrameLoaderClient::dispatchDidFinishLoading):
2363         (WebFrameLoaderClient::dispatchDidFailLoading):
2364         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2365         (WebFrameLoaderClient::dispatchWillClose):
2366         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2367         (WebFrameLoaderClient::dispatchDidCommitLoad):
2368         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2369         (WebFrameLoaderClient::dispatchDidFailLoad):
2370         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2371         (WebFrameLoaderClient::dispatchDidFinishLoad):
2372         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2373         (WebFrameLoaderClient::willChangeTitle):
2374         (WebFrameLoaderClient::didChangeTitle):
2375         (WebFrameLoaderClient::didReplaceMultipartContent):
2376         (WebFrameLoaderClient::updateGlobalHistory):
2377         (WebFrameLoaderClient::saveViewStateToItem):
2378         (WebFrameLoaderClient::restoreViewState):
2379         (WebFrameLoaderClient::provisionalLoadStarted):
2380         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2381         (WebFrameLoaderClient::setTitle):
2382         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2383         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2384         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2385         (WebFrameLoaderClient::didRestoreFromPageCache):
2386         (WebFrameLoaderClient::actionDictionary const):
2387         (WebFrameLoaderClient::createPlugin):
2388         (WebFrameLoaderClient::getLoadDecisionForIcons):
2389         (WebFrameLoaderClient::finishedLoadingIcon):
2390         (+[WebFramePolicyListener initialize]):
2391         * WebCoreSupport/WebFrameNetworkingContext.mm:
2392         * WebCoreSupport/WebGeolocationClient.h:
2393         * WebCoreSupport/WebGeolocationClient.mm:
2394         (WebGeolocationClient::requestPermission):
2395         * WebCoreSupport/WebInspectorClient.h:
2396         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2397         * WebCoreSupport/WebNotificationClient.mm:
2398         * WebCoreSupport/WebOpenPanelResultListener.mm:
2399         * WebCoreSupport/WebPlatformStrategies.h:
2400         * WebCoreSupport/WebPlatformStrategies.mm:
2401         * WebCoreSupport/WebProgressTrackerClient.h:
2402         * WebCoreSupport/WebProgressTrackerClient.mm:
2403         (WebProgressTrackerClient::progressStarted):
2404         (WebProgressTrackerClient::progressEstimateChanged):
2405         (WebProgressTrackerClient::progressFinished):
2406         * WebCoreSupport/WebSecurityOrigin.mm:
2407         * WebInspector/WebNodeHighlight.h:
2408         * WebInspector/WebNodeHighlight.mm:
2409         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2410         (-[WebNodeHighlight dealloc]):
2411         (-[WebNodeHighlight attach]):
2412         * WebInspector/WebNodeHighlightView.h:
2413         * WebInspector/WebNodeHighlightView.mm:
2414         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2415         (-[WebNodeHighlightView dealloc]):
2416         * WebInspector/WebNodeHighlighter.mm:
2417         (-[WebNodeHighlighter highlight]):
2418         * WebView/WebArchive.mm:
2419         (+[WebArchivePrivate initialize]):
2420         * WebView/WebClipView.h:
2421         * WebView/WebDataSource.mm:
2422         (WebDataSourcePrivate::WebDataSourcePrivate):
2423         (+[WebDataSource initialize]):
2424         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2425         (-[WebDataSource _makeRepresentation]):
2426         * WebView/WebDelegateImplementationCaching.h:
2427         * WebView/WebDelegateImplementationCaching.mm:
2428         (CallDelegate):
2429         (CallDelegateReturningFloat):
2430         (CallDelegateReturningBoolean):
2431         (CallUIDelegate):
2432         (CallUIDelegateReturningFloat):
2433         (CallUIDelegateReturningBoolean):
2434         (CallFrameLoadDelegate):
2435         (CallFrameLoadDelegateReturningBoolean):
2436         (CallResourceLoadDelegate):
2437         (CallScriptDebugDelegate):
2438         (CallFormDelegate):
2439         (CallFormDelegateReturningBoolean):
2440         * WebView/WebDeviceOrientation.mm:
2441         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2442         * WebView/WebDocumentInternal.h:
2443         * WebView/WebDocumentLoaderMac.mm:
2444         (needsDataLoadWorkaround):
2445         * WebView/WebDynamicScrollBarsViewInternal.h:
2446         * WebView/WebFormDelegate.m:
2447         * WebView/WebFrame.mm:
2448         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2449         (-[WebFrame _unmarkAllMisspellings]):
2450         (-[WebFrame _paintBehaviorForDestinationContext:]):
2451         (-[WebFrame _drawRect:contentsOnly:]):
2452         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2453         (-[WebFrame _scrollDOMRangeToVisible:]):
2454         (-[WebFrame _bodyBackgroundColor]):
2455         (-[WebFrame accessibilityRoot]):
2456         (needsMicrosoftMessengerDOMDocumentWorkaround):
2457         * WebView/WebFrameInternal.h:
2458         * WebView/WebFrameView.mm:
2459         (-[WebFrameView _setDocumentView:]):
2460         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2461         (-[WebFrameView _viewClassForMIMEType:]):
2462         (-[WebFrameView initWithFrame:]):
2463         (-[WebFrameView drawRect:]):
2464         (-[WebFrameView _firstResponderIsFormControl]):
2465         (-[WebFrameView keyDown:keyDown:]):
2466         (-[WebFrameView _isScrollable]):
2467         * WebView/WebFullScreenController.h:
2468         * WebView/WebFullScreenController.mm:
2469         * WebView/WebHTMLRepresentation.mm:
2470         * WebView/WebHTMLView.mm:
2471         (-[WebHTMLView hitTest:]):
2472         (-[WebHTMLView initWithFrame:]):
2473         (-[WebHTMLView dealloc]):
2474         (-[WebHTMLView addSubview:]):
2475         (-[WebHTMLView mouseDown:]):
2476         (-[WebHTMLView mouseUp:]):
2477         (-[WebHTMLView resignFirstResponder]):
2478         (-[WebHTMLView accessibilityHitTest:]):
2479         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2480         * WebView/WebHTMLViewInternal.h:
2481         * WebView/WebIndicateLayer.h:
2482         * WebView/WebIndicateLayer.mm:
2483         * WebView/WebMediaPlaybackTargetPicker.h:
2484         * WebView/WebMediaPlaybackTargetPicker.mm:
2485         * WebView/WebPDFDocumentExtras.h:
2486         * WebView/WebPDFDocumentExtras.mm:
2487         * WebView/WebPDFRepresentation.h:
2488         * WebView/WebPDFRepresentation.mm:
2489         * WebView/WebPDFView.h:
2490         * WebView/WebPreferences.mm:
2491         (cacheModelForMainBundle):
2492         (WebPreferencesPrivate::WebPreferencesPrivate):
2493         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2494         (-[WebPreferences encodeWithCoder:]):
2495         (+[WebPreferences standardPreferences]):
2496         (+[WebPreferences initialize]):
2497         (-[WebPreferences _valueForKey:]):
2498         (-[WebPreferences _setStringValue:forKey:]):
2499         (-[WebPreferences _setIntegerValue:forKey:]):
2500         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2501         (-[WebPreferences _setFloatValue:forKey:]):
2502         (-[WebPreferences _setBoolValue:forKey:]):
2503         (-[WebPreferences _setLongLongValue:forKey:]):
2504         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2505         (-[WebPreferences _postCacheModelChangedNotification]):
2506         (-[WebPreferences _postPreferencesChangedNotification]):
2507         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2508         (-[WebPreferences setStorageBlockingPolicy:]):
2509         * WebView/WebResource.mm:
2510         (+[WebResourcePrivate initialize]):
2511         * WebView/WebTextCompletionController.h:
2512         * WebView/WebTextIterator.mm:
2513         (+[WebTextIteratorPrivate initialize]):
2514         * WebView/WebView.mm:
2515         (shouldEnableLoadDeferring):
2516         (shouldRestrictWindowFocus):
2517         (shouldRespectPriorityInCSSAttributeSetters):
2518         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2519         (shouldAllowPictureInPictureMediaPlayback):
2520         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2521         (shouldAllowWindowOpenWithoutUserGesture):
2522         (shouldConvertInvalidURLsToBlank):
2523         (shouldRequireUserGestureToLoadVideo):
2524         (-[WebView _commonInitializationWithFrameName:groupName:]):
2525         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2526         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2527         (-[WebView _closePluginDatabases]):
2528         (-[WebView _closeWithFastTeardown]):
2529         (-[WebView _close]):
2530         (+[WebView _MIMETypeForFile:]):
2531         (-[WebView setShowingInspectorIndication:]):
2532         (-[WebView _setFormDelegate:]):
2533         (-[WebView _needsPreHTML5ParserQuirks]):
2534         (-[WebView _preferencesChangedNotification:]):
2535         (-[WebView _preferencesChanged:]):
2536         (-[WebView _cacheResourceLoadDelegateImplementations]):
2537         (-[WebView _cacheFrameLoadDelegateImplementations]):
2538         (-[WebView _policyDelegateForwarder]):
2539         (-[WebView _UIDelegateForwarder]):
2540         (-[WebView _editingDelegateForwarder]):
2541         (-[WebView _updateActiveState]):
2542         (-[_WebSafeForwarder forwardInvocation:]):
2543         (+[WebView initialize]):
2544         (-[WebView _pluginForMIMEType:]):
2545         (-[WebView _pluginForExtension:]):
2546         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2547         (+[WebView canShowMIMETypeAsHTML:]):
2548         (-[WebView _initWithArguments:]):
2549         (-[WebView initWithFrame:frameName:groupName:]):
2550         (-[WebView dealloc]):
2551         (-[WebView close]):
2552         (-[WebView viewDidMoveToWindow]):
2553         (-[WebView setUIDelegate:]):
2554         (-[WebView setResourceLoadDelegate:]):
2555         (-[WebView setPolicyDelegate:]):
2556         (-[WebView setFrameLoadDelegate:]):
2557         (-[WebView goBack]):
2558         (-[WebView goForward]):
2559         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2560         (-[WebView setHostWindow:]):
2561         (-[WebView becomeFirstResponder]):
2562         (+[WebView _cacheModelChangedNotification:]):
2563         (-[WebView _frameViewAtWindowPoint:]):
2564         (+[WebView _preflightSpellCheckerNow:]):
2565         (+[WebView _preflightSpellChecker]):
2566         (-[WebView canGoBack]):
2567         (-[WebView canGoForward]):
2568         (-[WebView stopLoading:]):
2569         (-[WebView reload:]):
2570         (-[WebView setMainFrameDocumentReady:]):
2571         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2572         (-[WebView setContinuousSpellCheckingEnabled:]):
2573         (-[WebView undoManager]):
2574         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2575         (-[WebView isAutomaticLinkDetectionEnabled]):
2576         (-[WebView isAutomaticDashSubstitutionEnabled]):
2577         (-[WebView isAutomaticTextReplacementEnabled]):
2578         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2579         (+[WebView _setCacheModel:]):
2580         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2581         (-[WebView _keyboardUIMode]):
2582         (LayerFlushController::flushLayers):
2583         (-[WebView _scheduleCompositingLayerFlush]):
2584         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2585         (-[WebView fullScreenPlaceholderView]):
2586         (WebInstallMemoryPressureHandler):
2587         * WebView/WebViewData.h:
2588         * WebView/WebViewData.mm:
2589         (+[WebViewPrivate initialize]):
2590         (-[WebViewPrivate init]):
2591         (-[WebViewPrivate dealloc]):
2592         * WebView/WebViewInternal.h:
2593
2594 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2595
2596         Clean up FrameLoader two-state enums
2597         https://bugs.webkit.org/show_bug.cgi?id=190731
2598
2599         Reviewed by Chris Dumez.
2600
2601         * WebCoreSupport/WebFrameLoaderClient.h:
2602         * WebCoreSupport/WebFrameLoaderClient.mm:
2603         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2604
2605 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2606
2607         Unreviewed, rolling out r237137.
2608
2609         SPI is actually used
2610
2611         Reverted changeset:
2612
2613         "Remove unused WebFrame._loadType"
2614         https://bugs.webkit.org/show_bug.cgi?id=190583
2615         https://trac.webkit.org/changeset/237137
2616
2617 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2618
2619         Enable the datalist element by default on iOS and macOS
2620         https://bugs.webkit.org/show_bug.cgi?id=190594
2621         <rdar://problem/45281159>
2622
2623         Reviewed by Ryosuke Niwa and Tim Horton.
2624
2625         * Configurations/FeatureDefines.xcconfig:
2626
2627 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2628
2629         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2630         https://bugs.webkit.org/show_bug.cgi?id=190675
2631
2632         Reviewed by Chris Dumez.
2633
2634         * History/BackForwardList.h:
2635         * History/BackForwardList.mm:
2636         (BackForwardList::backItem):
2637         (BackForwardList::currentItem):
2638         (BackForwardList::forwardItem):
2639         (BackForwardList::backListCount const):
2640         (BackForwardList::forwardListCount const):
2641         (BackForwardList::itemAtIndex):
2642         * History/WebBackForwardList.mm:
2643         (-[WebBackForwardList backItem]):
2644         (-[WebBackForwardList currentItem]):
2645         (-[WebBackForwardList forwardItem]):
2646         (-[WebBackForwardList itemAtIndex:]):
2647
2648 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2649
2650         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2651         https://bugs.webkit.org/show_bug.cgi?id=190526
2652         rdar://problem/45230140
2653
2654         Reviewed by Dean Jackson.
2655
2656         * WebCoreSupport/WebEditorClient.mm:
2657         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2658
2659 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2660
2661         Implement feature flag and bindings for CSS Painting API
2662         https://bugs.webkit.org/show_bug.cgi?id=190237
2663
2664         Reviewed by Ryosuke Niwa.
2665
2666         * Configurations/FeatureDefines.xcconfig:
2667
2668 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2669
2670         Replace HistoryItem* with HistoryItem& where possible
2671         https://bugs.webkit.org/show_bug.cgi?id=190617
2672
2673         Reviewed by Chris Dumez.
2674
2675         * History/BackForwardList.h:
2676         * History/BackForwardList.mm:
2677         (BackForwardList::goToItem):
2678         * History/WebBackForwardList.mm:
2679         (-[WebBackForwardList goToItem:]):
2680         * History/WebHistoryItem.mm:
2681         (WKNotifyHistoryItemChanged):
2682         * History/WebHistoryItemInternal.h:
2683
2684 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2685
2686         Remove unused WebHistoryItem._transientPropertyForKey
2687         https://bugs.webkit.org/show_bug.cgi?id=190606
2688
2689         Reviewed by Chris Dumez.
2690
2691         * History/WebHistoryItem.mm:
2692         * History/WebHistoryItemPrivate.h:
2693
2694 2018-10-15  Justin Fan  <justin_fan@apple.com>
2695
2696         Add WebGPU 2018 feature flag and experimental feature flag
2697         https://bugs.webkit.org/show_bug.cgi?id=190509
2698
2699         Reviewed by Dean Jackson.
2700
2701         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2702         for the 2018 WebGPU prototype.
2703
2704         * Configurations/FeatureDefines.xcconfig:
2705         * WebView/WebPreferenceKeysPrivate.h:
2706         * WebView/WebPreferences.mm:
2707         (+[WebPreferences initialize]):
2708         (-[WebPreferences webGPUEnabled]):
2709         (-[WebPreferences setWebGPUEnabled:]):
2710         * WebView/WebPreferencesPrivate.h:
2711         * WebView/WebView.mm:
2712         (-[WebView _preferencesChanged:]):
2713
2714 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2715
2716         Fix iOS build after r237157
2717
2718         * WebView/WebView.mm:
2719         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2720
2721 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2722
2723         Modernize BackForwardClient.h
2724         https://bugs.webkit.org/show_bug.cgi?id=190610
2725
2726         Reviewed by Chris Dumez.
2727
2728         * History/BackForwardList.h:
2729         * History/BackForwardList.mm:
2730         (BackForwardList::backListCount const):
2731         (BackForwardList::forwardListCount const):
2732         (BackForwardList::backListCount): Deleted.
2733         (BackForwardList::forwardListCount): Deleted.
2734         * History/WebBackForwardList.mm:
2735         (-[WebBackForwardList init]):
2736         * WebCoreSupport/WebFrameLoaderClient.mm:
2737         (WebFrameLoaderClient::canCachePage const):
2738         * WebView/WebFrameView.mm:
2739         (-[WebFrameView keyDown:keyDown:]):
2740         * WebView/WebView.mm:
2741         (-[WebView _commonInitializationWithFrameName:groupName:]):
2742         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2743         (-[WebView _loadBackForwardListFromOtherView:]):
2744         (-[WebView initWithCoder:]):
2745         (-[WebView encodeWithCoder:]):
2746         (-[WebView backForwardList]):
2747         (-[WebView setMaintainsBackForwardList:]):
2748
2749 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2750
2751         Add support for prefers-color-scheme media query
2752         https://bugs.webkit.org/show_bug.cgi?id=190499
2753         rdar://problem/45212025
2754
2755         Reviewed by Dean Jackson.
2756
2757         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2758
2759 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2760
2761         Remove unused WebView._globalHistoryItem
2762         https://bugs.webkit.org/show_bug.cgi?id=190601
2763
2764         Reviewed by Chris Dumez.
2765
2766         * WebCoreSupport/WebFrameLoaderClient.h:
2767         * WebCoreSupport/WebFrameLoaderClient.mm:
2768         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2769         * WebView/WebView.mm:
2770         (-[WebView _globalHistoryItem]): Deleted.
2771         (-[WebView _setGlobalHistoryItem:]): Deleted.
2772         * WebView/WebViewData.h:
2773         * WebView/WebViewInternal.h:
2774         * WebView/WebViewPrivate.h:
2775
2776 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2777
2778         Remove unused parameters from FrameLoaderClient::createFrame
2779         https://bugs.webkit.org/show_bug.cgi?id=190587
2780
2781         Reviewed by Chris Dumez.
2782
2783         * WebCoreSupport/WebFrameLoaderClient.h:
2784         * WebCoreSupport/WebFrameLoaderClient.mm:
2785         (WebFrameLoaderClient::createFrame):
2786
2787 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2788
2789         Remove unused WebFrame._loadType
2790         https://bugs.webkit.org/show_bug.cgi?id=190583
2791
2792         Reviewed by Chris Dumez.
2793
2794         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2795
2796         * WebView/WebFrame.mm:
2797         (toWebFrameLoadType): Deleted.
2798         (-[WebFrame _loadType]): Deleted.
2799         * WebView/WebFramePrivate.h:
2800
2801 2018-10-15  Chris Dumez  <cdumez@apple.com>
2802
2803         Restrict browsing context lookup by name to frames that are related to one another
2804         https://bugs.webkit.org/show_bug.cgi?id=190475
2805
2806         Reviewed by Alex Christensen.
2807
2808         * WebView/WebFrame.mm:
2809         (-[WebFrame findFrameNamed:]):
2810
2811 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2812
2813         Remove InjectedBundle processing of back/forward lists
2814         https://bugs.webkit.org/show_bug.cgi?id=190459
2815
2816         Reviewed by Chris Dumez.
2817
2818         * WebCoreSupport/WebFrameLoaderClient.h:
2819         * WebCoreSupport/WebFrameLoaderClient.mm:
2820         (WebFrameLoaderClient::shouldGoToHistoryItem const):
2821
2822 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2823
2824         [JSC] Remove Option::useAsyncIterator
2825         https://bugs.webkit.org/show_bug.cgi?id=190567
2826
2827         Reviewed by Saam Barati.
2828
2829         * Configurations/FeatureDefines.xcconfig:
2830
2831 2018-10-12  Alex Christensen  <achristensen@webkit.org>
2832
2833         Allow encoding of small enum classes
2834         https://bugs.webkit.org/show_bug.cgi?id=190531
2835
2836         Reviewed by Tim Horton.
2837
2838         * WebCoreSupport/WebFrameLoaderClient.mm:
2839         (-[WebFramePolicyListener dealloc]):
2840
2841 2018-10-11  Keith Rollin  <krollin@apple.com>
2842
2843         CURRENT_ARCH should not be used in Run Script phase.
2844         https://bugs.webkit.org/show_bug.cgi?id=190407
2845         <rdar://problem/45133556>
2846
2847         Reviewed by Alexey Proskuryakov.
2848
2849         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
2850         CURRENT_ARCH is not well-defined during this phase (and may even have
2851         the value "undefined") since this phase is run just once per build
2852         rather than once per supported architecture. Migrate away from
2853         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
2854         performing an operation for each value, or by picking the first entry
2855         in ARCHS and using that as a representative value.
2856
2857         * Configurations/WebKitLegacy.xcconfig: When generating
2858         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
2859         macosx platforms.
2860
2861         * MigrateHeaders.make:
2862         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
2863         generate one for each architecture in ARCHS.
2864
2865 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2866
2867         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
2868         https://bugs.webkit.org/show_bug.cgi?id=190429
2869
2870         Reviewed by Saam Barati.
2871
2872         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
2873
2874         * WebView/WebPDFRepresentation.mm:
2875         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
2876
2877 2018-10-08  Justin Fan  <justin_fan@apple.com>
2878
2879         WebGPU: Rename old WebGPU prototype to WebMetal
2880         https://bugs.webkit.org/show_bug.cgi?id=190325
2881         <rdar://problem/44990443>
2882
2883         Reviewed by Dean Jackson.
2884
2885         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
2886
2887         * Configurations/FeatureDefines.xcconfig:
2888         * WebView/WebPreferenceKeysPrivate.h:
2889         * WebView/WebPreferences.mm:
2890         (+[WebPreferences initialize]):
2891         (-[WebPreferences webMetalEnabled]):
2892         (-[WebPreferences setWebMetalEnabled:]):
2893         (-[WebPreferences webGPUEnabled]): Deleted.
2894         (-[WebPreferences setWebGPUEnabled:]): Deleted.
2895         * WebView/WebPreferencesPrivate.h:
2896         * WebView/WebView.mm:
2897         (-[WebView _preferencesChanged:]):
2898
2899 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
2900
2901         Make <input type=color> a runtime enabled (on-by-default) feature
2902         https://bugs.webkit.org/show_bug.cgi?id=189162
2903
2904         Reviewed by Wenson Hsieh and Tim Horton.
2905
2906         * Configurations/FeatureDefines.xcconfig:
2907
2908 2018-10-07  Dan Bernstein  <mitz@apple.com>
2909
2910         Fixed building with the latest macOS SDK
2911
2912         * Plugins/WebNetscapePluginPackage.mm:
2913         (-[WebNetscapePluginPackage openResourceFile]):
2914         (-[WebNetscapePluginPackage closeResourceFile:]):
2915
2916 2018-10-04  Dan Bernstein  <mitz@apple.com>
2917
2918         More Carbon build-fixing.
2919
2920         * Carbon/CarbonWindowAdapter.mm:
2921         (-[CarbonWindowAdapter _destroyRealWindow:]):
2922         (-[CarbonWindowAdapter _growBoxRect]):
2923
2924 2018-10-04  Dan Bernstein  <mitz@apple.com>
2925
2926         Retried to fix 32-bit macOS builds after r236846.
2927
2928         * WebView/WebHTMLView.mm:
2929         (-[WebHTMLView setMarkedText:selectedRange:]):
2930
2931 2018-10-04  Dan Bernstein  <mitz@apple.com>
2932
2933         Retried to fix 32-bit macOS builds after r236846.
2934
2935         * Carbon/HIWebView.mm:
2936         (ActiveStateChanged):
2937
2938 2018-10-04  Dan Bernstein  <mitz@apple.com>
2939
2940         Tried to fix 32-bit macOS builds after r236846.
2941
2942         * Carbon/HIWebView.mm:
2943         (_NSSelectorForHICommand):
2944
2945 2018-10-04  Dan Bernstein  <mitz@apple.com>
2946
2947         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
2948         https://bugs.webkit.org/show_bug.cgi?id=190250
2949
2950         Reviewed by Andy Estes.
2951
2952         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
2953           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
2954           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
2955           an earlier line set it to YES.
2956
2957         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
2958         changes below.
2959
2960         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
2961           provides some missing method declarations.
2962
2963         * Misc/WebDownload.mm:
2964         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
2965           a deprecated method.
2966
2967         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
2968
2969         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
2970           other code in the file uses a method from it.
2971
2972         * Plugins/WebBaseNetscapePluginView.mm:
2973         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
2974           a deprecated method.
2975
2976         * Plugins/WebPluginController.mm:
2977         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
2978           around use of a selector that may be present in some WebKit client.
2979
2980         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
2981           method declarations.
2982
2983         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
2984           from here.
2985
2986         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
2987           missing method declarations.
2988
2989         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
2990           from here.
2991
2992         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
2993           call from here.
2994         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
2995           an obsolete delegate method for binary compatibility.
2996         (pluginView): Ditto.
2997
2998         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
2999           call from here.
3000
3001         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
3002           WebDeviceOrientationProviderMock protocol.
3003
3004         * WebView/WebDeviceOrientationProviderMock.mm:
3005         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
3006           main @implementation.
3007
3008         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
3009           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
3010
3011         * WebView/WebDynamicScrollBarsView.mm:
3012         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
3013           of a deprecated method.
3014
3015         * WebView/WebHTMLView.mm:
3016         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
3017           selector warning around action methods that are not declared anywhere in WebKit.
3018
3019         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
3020           about implementing this deprecated method.
3021         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
3022         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3023         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3024         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3025         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3026         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3027         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3028         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3029         (-[WebHTMLView doCommandBySelector:]): Ditto.
3030         (-[WebHTMLView insertText:]): Ditto.
3031
3032         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
3033
3034         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
3035
3036         * WebView/WebPDFView.h: Removed previewView ivar.
3037
3038         * WebView/WebPDFView.mm:
3039           Removed declaration of FileInternal category and merged its implementation with the main
3040           implementation.
3041         (-[WebPDFView dealloc]): Removed previewView ivar.
3042         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
3043           exist in macOS versions we support.
3044         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
3045         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
3046           action methods internal to PDFKit.
3047         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
3048         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
3049
3050         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
3051           call on macOS, even though in r86988 we started calling different methods on iOS.
3052
3053         * WebView/WebView.mm:
3054         - Imported headers that declare delegate methods that we call.
3055         - Removed declaration of WebFileInternal category and merged its implementation with the
3056           main implementation.
3057         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
3058           category, which made them impossible to call from the main implementation. Moved those
3059           into the main implementation. One of those had to be declared in a class extension,
3060           because it is called from a method implemented in the WebPrivate category, and that
3061           category’s implementation appears first in the file.
3062
3063         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
3064           around use of obsolete delegate method for binary compatibility.
3065
3066         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
3067
3068 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3069
3070         Runtime flag and IDL for MediaRecorder
3071         https://bugs.webkit.org/show_bug.cgi?id=190018
3072
3073         Reviewed by Youenn Fablet and Chris Dumez.
3074
3075         * WebView/WebPreferenceKeysPrivate.h:
3076         * WebView/WebPreferences.mm:
3077         (+[WebPreferences initialize]):
3078         (-[WebPreferences mediaRecorderEnabled]):
3079         (-[WebPreferences setMediaRecorderEnabled:]):
3080         * WebView/WebPreferencesPrivate.h:
3081         * WebView/WebView.mm:
3082         (-[WebView _preferencesChanged:]):
3083
3084 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3085
3086         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3087         https://bugs.webkit.org/show_bug.cgi?id=190238
3088
3089         Reviewed by Antti Koivisto.
3090
3091         Enabled the feature by default.
3092
3093         * WebView/WebPreferences.mm:
3094         (+[WebPreferences initialize]):
3095
3096 2018-10-01  Dean Jackson  <dino@apple.com>
3097
3098         [macOS] Switching to discrete GPU should be done in the UI process
3099         https://bugs.webkit.org/show_bug.cgi?id=189361
3100         <rdar://problem/43949622>
3101
3102         Reviewed by Simon Fraser.
3103
3104         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
3105         not support swapping to the discrete GPU in this configuration.
3106
3107         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
3108         (WebKit::WebSwitchingGPUClient::singleton):
3109         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
3110         * WebView/WebView.mm:
3111         (-[WebView _commonInitializationWithFrameName:groupName:]):
3112
3113 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3114
3115         Remove ParsedURLString
3116         https://bugs.webkit.org/show_bug.cgi?id=190154
3117
3118         Reviewed by Chris Dumez.
3119
3120         * WebView/WebScriptDebugger.mm:
3121         (toNSURL):
3122
3123 2018-10-01  Dean Jackson  <dino@apple.com>
3124
3125         Remove CSS Animation Triggers
3126         https://bugs.webkit.org/show_bug.cgi?id=190175
3127         <rdar://problem/44925626>
3128
3129         Reviewed by Simon Fraser.
3130
3131         * Configurations/FeatureDefines.xcconfig:
3132
3133 2018-10-02  Commit Queue  <commit-queue@webkit.org>
3134
3135         Unreviewed, rolling out r236624 and r236671.
3136         https://bugs.webkit.org/show_bug.cgi?id=190207
3137
3138         The change in r236624 introduced crashes on the bots
3139         (Requested by ryanhaddad on #webkit).
3140
3141         Reverted changesets:
3142
3143         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3144         https://bugs.webkit.org/show_bug.cgi?id=188747
3145         https://trac.webkit.org/changeset/236624
3146
3147         "Unify implementation in VideoFullscreenInterfaceAVKit"
3148         https://bugs.webkit.org/show_bug.cgi?id=190091
3149         https://trac.webkit.org/changeset/236671
3150
3151 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3152
3153         URL should not use TextEncoding internally
3154         https://bugs.webkit.org/show_bug.cgi?id=190111
3155
3156         Reviewed by Andy Estes.
3157
3158         * Misc/WebNSURLExtras.mm:
3159
3160 2018-09-28  Jer Noble  <jer.noble@apple.com>
3161
3162         Refactoring: eliminate raw pointer usage in Fullscreen code
3163         https://bugs.webkit.org/show_bug.cgi?id=188747
3164         <rdar://problem/43541164>
3165
3166         Reviewed by Alex Christensen.
3167
3168         PlaybackSessionInterface no longer has an invalidate() method.
3169
3170         * WebView/WebView.mm:
3171         (-[WebView _clearPlaybackControlsManager]):
3172
3173 2018-09-28  Chris Dumez  <cdumez@apple.com>
3174
3175         Drop support for cross-origin-window-policy header
3176         https://bugs.webkit.org/show_bug.cgi?id=190081
3177
3178         Reviewed by Ryosuke Niwa.
3179
3180         * WebView/WebPreferenceKeysPrivate.h:
3181         * WebView/WebPreferences.mm:
3182         (+[WebPreferences initialize]):
3183         * WebView/WebPreferencesPrivate.h:
3184         * WebView/WebView.mm:
3185         (-[WebView _preferencesChanged:]):
3186
3187 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3188
3189         Rename createMarkup to serializePreservingVisualAppearance
3190         https://bugs.webkit.org/show_bug.cgi?id=190086
3191
3192         Reviewed by Wenson Hsieh.
3193
3194         * DOM/WebDOMOperations.mm:
3195         (-[DOMRange markupString]):
3196
3197 2018-09-28  Commit Queue  <commit-queue@webkit.org>
3198
3199         Unreviewed, rolling out r236605.
3200         https://bugs.webkit.org/show_bug.cgi?id=190087
3201
3202         caused three API test timeouts (Requested by jernoble on
3203         #webkit).
3204
3205         Reverted changeset:
3206
3207         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3208         https://bugs.webkit.org/show_bug.cgi?id=188747
3209         https://trac.webkit.org/changeset/236605
3210
3211 2018-09-28  Jer Noble  <jer.noble@apple.com>
3212
3213         Refactoring: eliminate raw pointer usage in Fullscreen code
3214         https://bugs.webkit.org/show_bug.cgi?id=188747
3215         <rdar://problem/43541164>
3216
3217         Reviewed by Alex Christensen.
3218
3219         PlaybackSessionInterface no longer has an invalidate() method.
3220
3221         * WebView/WebView.mm:
3222         (-[WebView _clearPlaybackControlsManager]):
3223
3224 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3225
3226         Use enum class in createMarkup arguments
3227         https://bugs.webkit.org/show_bug.cgi?id=190028
3228
3229         Reviewed by Wenson Hsieh.
3230
3231         * DOM/WebDOMOperations.mm:
3232         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
3233         (-[DOMRange markupString]): Ditto.
3234
3235 2018-09-27  Antoine Quint  <graouts@apple.com>
3236
3237         [Web Animations] Turn Web Animations with CSS integration on
3238         https://bugs.webkit.org/show_bug.cgi?id=184819
3239         <rdar://problem/39597337>
3240
3241         Reviewed by Dean Jackson.
3242
3243         * WebView/WebPreferences.mm:
3244         (+[WebPreferences initialize]):
3245
3246 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3247
3248         Selection should work across shadow boundary when initiated by a mouse drag
3249         https://bugs.webkit.org/show_bug.cgi?id=151380
3250         <rdar://problem/24363872>
3251
3252         Reviewed by Wenson Hsieh.
3253
3254         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
3255
3256         * WebView/WebPreferenceKeysPrivate.h:
3257         * WebView/WebPreferences.mm:
3258         (+[WebPreferences initialize]):
3259         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
3260         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
3261         * WebView/WebPreferencesPrivate.h:
3262         * WebView/WebView.mm:
3263         (-[WebView _preferencesChanged:]):
3264
3265 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3266
3267         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3268         https://bugs.webkit.org/show_bug.cgi?id=189918
3269         Work towards <rdar://problem/44648705>
3270
3271         Reviewed by Tim Horton.
3272
3273         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3274
3275         * WebView/WebHTMLView.mm:
3276         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3277         (-[WebHTMLView _updateFontPanel]):
3278         * WebView/WebView.mm:
3279         (-[WebView typingAttributes]):
3280
3281 2018-09-17  Darin Adler  <darin@apple.com>
3282
3283         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3284         https://bugs.webkit.org/show_bug.cgi?id=189652
3285
3286         Reviewed by Saam Barati.
3287
3288         * WebView/WebPDFRepresentation.mm:
3289         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3290
3291 2018-09-14  Jer Noble  <jer.noble@apple.com>
3292
3293         Turn SourceBufferChangeTypeEnabled on by default
3294         https://bugs.webkit.org/show_bug.cgi?id=189527
3295
3296         Reviewed by Eric Carlson.
3297
3298         * WebView/WebPreferences.mm:
3299         (+[WebPreferences initialize]):
3300
3301 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3302
3303         Fix an internal build after r235935
3304         https://bugs.webkit.org/show_bug.cgi?id=188996
3305
3306         * Carbon/HIWebView.mm:
3307         (Draw):
3308         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3309
3310 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3311
3312         Add IGNORE_WARNING_.* macros
3313         https://bugs.webkit.org/show_bug.cgi?id=188996
3314
3315         Reviewed by Michael Catanzaro.
3316
3317         * Carbon/CarbonUtils.m:
3318         (PoolCleaner):
3319         * Carbon/CarbonWindowAdapter.mm:
3320         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3321         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3322         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3323         (-[CarbonWindowAdapter _termWindowIfOwner]):
3324         (-[CarbonWindowAdapter _windowMovedToRect:]):
3325         (-[CarbonWindowAdapter setContentView:]):
3326         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3327         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3328         * Carbon/CarbonWindowFrame.m:
3329         (-[CarbonWindowFrame title]):
3330         * Carbon/HIViewAdapter.m:
3331         (+[HIViewAdapter getHIViewForNSView:]):
3332         * Carbon/HIWebView.mm:
3333         (overrideCGContext):
3334         (restoreCGContext):
3335         (Draw):
3336         * DOM/DOM.mm:
3337         * History/WebHistory.mm:
3338         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3339         * History/WebHistoryItem.mm:
3340         (-[WebHistoryItem icon]):
3341         * Misc/WebKitNSStringExtras.mm:
3342         (-[NSString _web_drawAtPoint:font:textColor:]):
3343         * Misc/WebNSImageExtras.m:
3344         (-[NSImage _web_scaleToMaxSize:]):
3345         (-[NSImage _web_dissolveToFraction:]):
3346         * Misc/WebNSPasteboardExtras.mm:
3347         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3348         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3349         * Panels/WebAuthenticationPanel.m:
3350         (-[WebAuthenticationPanel loadNib]):
3351         * Plugins/Hosted/NetscapePluginHostManager.mm:
3352         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3353         (WebKit::NetscapePluginHostManager::didCreateWindow):
3354         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3355         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3356         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3357         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3358         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3359         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3360         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3361         (-[WebHostedNetscapePluginView drawRect:]):
3362         * Plugins/Hosted/WebTextInputWindowController.m:
3363         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3364         * Plugins/WebBaseNetscapePluginView.mm:
3365         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3366         * Plugins/WebNetscapePluginPackage.mm:
3367         (-[WebNetscapePluginPackage _tryLoad]):
3368         * Plugins/WebNetscapePluginView.mm:
3369         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3370         (-[WebNetscapePluginView sendDrawRectEvent:]):
3371         (-[WebNetscapePluginView drawRect:]):
3372         * Plugins/WebPluginController.mm:
3373         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3374         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3375         * WebCoreSupport/PopupMenuMac.mm:
3376         (PopupMenuMac::populate):
3377         * WebCoreSupport/WebAlternativeTextClient.h:
3378         * WebCoreSupport/WebDragClient.mm:
3379         (WebDragClient::startDrag):
3380         * WebCoreSupport/WebFrameLoaderClient.mm:
3381         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3382         (webGetNSImage):
3383         * WebInspector/WebNodeHighlight.mm:
3384         * WebInspector/WebNodeHighlightView.mm:
3385         (-[WebNodeHighlightView drawRect:]):
3386         * WebView/WebClipView.mm:
3387         (-[WebClipView initWithFrame:]):
3388         * WebView/WebFrame.mm:
3389         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3390         (-[WebFrame _drawRect:contentsOnly:]):
3391         (-[WebFrame accessibilityRoot]):
3392         * WebView/WebFullScreenController.mm:
3393         (-[WebFullScreenController enterFullScreen:]):
3394         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3395         (-[WebFullScreenController exitFullScreen]):
3396         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3397         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3398         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3399         * WebView/WebHTMLView.mm:
3400         (-[NSWindow _web_borderView]):
3401         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3402         (-[WebHTMLView _setAsideSubviews]):
3403         (-[WebHTMLView _autoscroll]):
3404         (-[WebHTMLView drawRect:]):
3405         (-[WebHTMLView mouseDown:]):
3406         (-[WebHTMLView mouseDragged:]):
3407         (-[WebHTMLView mouseUp:]):
3408         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3409         (-[WebHTMLView knowsPageRange:]):
3410         (-[WebHTMLView accessibilityHitTest:]):
3411         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3412         (-[WebHTMLView _colorAsString:]):
3413         (-[WebHTMLView copyFont:]):
3414         (-[WebHTMLView _executeSavedKeypressCommands]):
3415         (-[WebHTMLView attachRootLayer:]):
3416         (-[WebHTMLView textStorage]):
3417         (-[WebHTMLView _updateSelectionForInputManager]):
3418         * WebView/WebPDFView.mm:
3419         (_applicationInfoForMIMEType):
3420         (-[WebPDFView centerSelectionInVisibleArea:]):
3421         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3422         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3423         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3424         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3425         * WebView/WebTextCompletionController.mm:
3426         (-[WebTextCompletionController _buildUI]):
3427         (-[WebTextCompletionController _placePopupWindow:]):
3428         * WebView/WebVideoFullscreenController.mm:
3429         * WebView/WebVideoFullscreenHUDWindowController.mm:
3430         (createMediaUIBackgroundView):
3431         * WebView/WebView.mm:
3432         (-[WebTextListTouchBarViewController initWithWebView:]):
3433         (-[WebView _dispatchTileDidDraw:]):
3434         (-[WebView encodeWithCoder:]):
3435         (-[WebView mainFrameIcon]):
3436         (LayerFlushController::flushLayers):
3437         * WebView/WebWindowAnimation.mm:
3438         (setScaledFrameForWindow):
3439
3440 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3441
3442         Remove unused needsDestruction class variables from HashTraits
3443         https://bugs.webkit.org/show_bug.cgi?id=189490
3444
3445         Reviewed by Daniel Bates.
3446
3447         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3448
3449 2018-09-07  Frederic Wang  <fwang@igalia.com>
3450
3451         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3452         https://bugs.webkit.org/show_bug.cgi?id=182230
3453
3454         Reviewed by Simon Fraser.
3455
3456         * DOM/DOMDocument.mm:
3457         (-[DOMDocument scrollingElement]): Use the new name.
3458
3459 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3460
3461         Refactor WebCore::EditAction to be an 8-bit enum class
3462         https://bugs.webkit.org/show_bug.cgi?id=189383
3463
3464         Reviewed by Dan Bernstein.
3465
3466         * WebCoreSupport/WebEditorClient.mm:
3467         (undoNameForEditAction):
3468         * WebView/WebHTMLView.mm:
3469         (-[WebHTMLView pasteFont:]):
3470         (-[WebHTMLView changeFont:]):
3471         (-[WebHTMLView changeAttributes:]):
3472         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3473         (-[WebHTMLView changeColor:]):
3474         * WebView/WebView.mm:
3475         (-[WebView setTypingStyle:]):
3476
3477 2018-09-06  Frederic Wang  <fwang@igalia.com>
3478
3479         Group options of scrollRectToVisible into a struct
3480         https://bugs.webkit.org/show_bug.cgi?id=189352
3481
3482         Reviewed by Simon Fraser.
3483
3484         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3485         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3486         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3487
3488 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3489
3490         [macOS] Cannot change font size at selection until font panel is shown
3491         https://bugs.webkit.org/show_bug.cgi?id=189295
3492         <rdar://problem/35593389>
3493
3494         Reviewed by Ryosuke Niwa.
3495
3496         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3497         WebCore ChangeLog for more details.
3498
3499         * WebView/WebHTMLView.mm:
3500         (-[WebHTMLView changeFont:]):
3501         (-[WebHTMLView changeAttributes:]):
3502         (-[WebHTMLView _originalFontA]): Deleted.
3503         (-[WebHTMLView _originalFontB]): Deleted.
3504         (fontNameForDescription): Deleted.
3505         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3506         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3507         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3508
3509 2018-09-05  Jer Noble  <jer.noble@apple.com>
3510
3511         Add MediaCapabilities as an Experimental Feature
3512         https://bugs.webkit.org/show_bug.cgi?id=189209
3513
3514         Reviewed by Eric Carlson.
3515
3516         RuntimeEnabledFeature -> Setting.
3517
3518         * WebView/WebView.mm:
3519         (-[WebView _preferencesChanged:]):
3520
3521 2018-09-04  Frederic Wang  <fwang@igalia.com>
3522
3523         Add basic support for ScrollIntoViewOptions
3524         https://bugs.webkit.org/show_bug.cgi?id=189258
3525
3526         Reviewed by Simon Fraser.
3527
3528         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3529         header so that this file can build despite the new scrollIntoView function.
3530
3531 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3532
3533         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3534         https://bugs.webkit.org/show_bug.cgi?id=188890
3535         <rdar://problem/43648605>
3536
3537         Reviewed by Tim Horton.
3538
3539         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3540         more detail.
3541
3542         * WebCoreSupport/WebPlatformStrategies.h:
3543         * WebCoreSupport/WebPlatformStrategies.mm:
3544         (WebPlatformStrategies::allStringsForType):
3545
3546 2018-09-01  Darin Adler  <darin@apple.com>
3547
3548         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3549         https://bugs.webkit.org/show_bug.cgi?id=189072
3550         Reviewed by Dan Bernstein.
3551
3552         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3553         and declarations for NSURLDownload init methods.
3554
3555         * Misc/WebDownloadInternal.h: Removed.
3556
3557         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3558         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3559         "-Wdeprecated-declarations" because the method used here is deprecated.
3560
3561         * WebView/WebView.mm:
3562         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3563         used here is deprecated.
3564
3565 2018-08-31  Chris Dumez  <cdumez@apple.com>
3566
3567         Assertion hit in ~CompletionHandler() from ~WebFrame()
3568         https://bugs.webkit.org/show_bug.cgi?id=189199
3569         <rdar://problem/42657233>
3570
3571         Reviewed by Youenn Fablet.
3572
3573         * WebCoreSupport/WebFrameLoaderClient.h:
3574         * WebCoreSupport/WebFrameLoaderClient.mm:
3575         (WebFrameLoaderClient::dispatchWillSubmitForm):
3576
3577 2018-08-31  Antti Koivisto  <antti@apple.com>
3578
3579         Replace OptionSet |= and -= operators with add() and remove() functions
3580         https://bugs.webkit.org/show_bug.cgi?id=189169
3581
3582         Reviewed by Anders Carlsson.
3583
3584         * WebView/WebFrame.mm:
3585         (-[WebFrame _drawRect:contentsOnly:]):
3586         * WebView/WebView.mm:
3587         (coreOptions):
3588
3589 2018-08-31  Frederic Wang  <fwang@igalia.com>
3590
3591         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3592         https://bugs.webkit.org/show_bug.cgi?id=182053
3593
3594         Reviewed by Simon Fraser.
3595
3596         Add developer flag to use standard behavior for scrolling* attributes.
3597
3598         * WebView/WebPreferenceKeysPrivate.h:
3599         * WebView/WebPreferences.mm:
3600         (+[WebPreferences initialize]):
3601         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3602         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3603         * WebView/WebPreferencesPrivate.h:
3604         * WebView/WebView.mm:
3605         (-[WebView _preferencesChanged:]):
3606
3607 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3608
3609         Implement the Web Share API
3610         https://bugs.webkit.org/show_bug.cgi?id=171100
3611         <rdar://problem/31751734>
3612
3613         Reviewed by Tim Horton.
3614
3615         * WebCoreSupport/WebChromeClient.h:
3616         * WebCoreSupport/WebChromeClient.mm:
3617         (WebChromeClient::showShareSheet):
3618         Empty declaration of showShareSheet.
3619
3620 2018-08-29  Youenn Fablet  <youenn@apple.com>
3621
3622         Remove WebRTC legacy API implementation
3623         https://bugs.webkit.org/show_bug.cgi?id=189040
3624
3625         Reviewed by Eric Carlson.
3626
3627         * WebView/WebPreferenceKeysPrivate.h:
3628         * WebView/WebPreferences.mm:
3629         (+[WebPreferences initialize]):
3630         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3631         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3632         * WebView/WebPreferencesPrivate.h:
3633         * WebView/WebView.mm:
3634         (-[WebView _preferencesChanged:]):
3635
3636 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3637
3638         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3639         https://bugs.webkit.org/show_bug.cgi?id=189054
3640
3641         Reviewed by Andy Estes.
3642
3643         Remove the pasteboard type argument from readURLFromPasteboard.
3644
3645         * WebCoreSupport/WebPlatformStrategies.h:
3646         * WebCoreSupport/WebPlatformStrategies.mm:
3647         (WebPlatformStrategies::readURLFromPasteboard):
3648
3649 2018-08-27  Keith Rollin  <krollin@apple.com>
3650
3651         Unreviewed build fix -- disable LTO for production builds
3652
3653         * Configurations/Base.xcconfig:
3654
3655 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3656
3657         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3658         https://bugs.webkit.org/show_bug.cgi?id=188931
3659
3660         Reviewed by Wenson Hsieh.
3661
3662         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3663
3664 2018-08-27  Keith Rollin  <krollin@apple.com>
3665
3666         Build system support for LTO
3667         https://bugs.webkit.org/show_bug.cgi?id=187785
3668         <rdar://problem/42353132>
3669
3670         Reviewed by Dan Bernstein.
3671
3672         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3673         LTO.
3674
3675         * Configurations/Base.xcconfig:
3676         * Configurations/DebugRelease.xcconfig:
3677
3678 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3679
3680         Pass in IsComposed flag to Event constructors
3681         https://bugs.webkit.org/show_bug.cgi?id=188720
3682         <rdar://problem/43580387>
3683
3684         Reviewed by Simon Fraser.
3685
3686         * WebView/WebPDFView.mm:
3687         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3688         whether it's simulated or not.
3689
3690 2018-08-23  Mark Lam  <mark.lam@apple.com>
3691
3692         Move vmEntryGlobalObject() to VM from CallFrame.
3693         https://bugs.webkit.org/show_bug.cgi?id=188900
3694         <rdar://problem/43655753>
3695
3696         Reviewed by Michael Saboff.
3697
3698         * WebView/WebScriptDebugger.mm:
3699         (WebScriptDebugger::sourceParsed):
3700
3701 2018-08-23  Andy Estes  <aestes@apple.com>
3702
3703         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3704         https://bugs.webkit.org/show_bug.cgi?id=188829
3705
3706         Reviewed by Tim Horton.
3707
3708         * Configurations/FeatureDefines.xcconfig:
3709
3710 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3711
3712         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3713         https://bugs.webkit.org/show_bug.cgi?id=188777
3714
3715         Reviewed by Simon Fraser.
3716
3717         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3718         being "true" before the code change.
3719
3720         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3721
3722         * WebView/WebPDFView.mm:
3723         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3724
3725 2018-08-21  Daniel Bates  <dabates@apple.com>
3726
3727         Replace TextCheckingTypeMask with OptionSet
3728         https://bugs.webkit.org/show_bug.cgi?id=188678
3729
3730         Reviewed by Antti Koivisto.
3731
3732         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3733         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3734         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3735         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3736
3737         * WebCoreSupport/WebEditorClient.h:
3738         * WebCoreSupport/WebEditorClient.mm:
3739         (WebEditorClient::checkTextOfParagraph):
3740         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3741         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3742         left as this is more readable and unncessary now that modern compilers like Clang have
3743         diagnostics to catch accidental assignments when equality was intended.
3744         (WebEditorClient::didCheckSucceed):
3745         * WebView/WebView.mm:
3746         (coreTextCheckingType):
3747         (textCheckingResultFromNSTextCheckingResult):
3748
3749 2018-08-21  Daniel Bates  <dabates@apple.com>
3750
3751         [iOS][WK1] Support toggling continuous spell checking from tests
3752         https://bugs.webkit.org/show_bug.cgi?id=188763
3753
3754         Reviewed by Simon Fraser.
3755
3756         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3757         spell checking from tests in iOS WebKit Legacy.
3758
3759         * WebCoreSupport/WebEditorClient.h:
3760         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3761         * WebCoreSupport/WebEditorClient.mm:
3762         * WebView/WebView.h:
3763         * WebView/WebView.mm:
3764         (-[WebView toggleContinuousSpellChecking:]):
3765         (-[WebView toggleSmartInsertDelete:]):
3766
3767 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3768
3769         Add some plumbing for safe browsing
3770         https://bugs.webkit.org/show_bug.cgi?id=188709
3771
3772         Reviewed by Tim Horton.
3773
3774         * WebCoreSupport/WebFrameLoaderClient.h:
3775         * WebCoreSupport/WebFrameLoaderClient.mm:
3776         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3777
3778 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3779
3780         Replace canBubble and cancelable booleans in Event by enum classes
3781         https://bugs.webkit.org/show_bug.cgi?id=188692
3782
3783         Reviewed by Alex Christensen.
3784
3785         * WebView/WebPDFView.mm:
3786         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3787         * WebView/WebView.mm:
3788         (-[WebView _dispatchUnloadEvent]):
3789
3790 2018-08-16  Jer Noble  <jer.noble@apple.com>
3791
3792         Add Experimental Feature support for SourceBuffer.changeType()
3793         https://bugs.webkit.org/show_bug.cgi?id=188626
3794         <rdar://problem/43356021>
3795
3796         Reviewed by Eric Carlson.
3797
3798         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
3799
3800         * WebView/WebPreferenceKeysPrivate.h:
3801         * WebView/WebPreferences.mm:
3802         (+[WebPreferences initialize]):
3803         (-[WebPreferences sourceBufferChangeTypeEnabled]):
3804         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
3805         * WebView/WebPreferencesPrivate.h:
3806         * WebView/WebView.mm:
3807         (-[WebView _preferencesChanged:]):
3808
3809 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
3810
3811         Support drag-and-drop for input[type=color]
3812         https://bugs.webkit.org/show_bug.cgi?id=188464
3813
3814         Reviewed by Wenson Hsieh.
3815
3816         * WebCoreSupport/WebPlatformStrategies.h:
3817         * WebCoreSupport/WebPlatformStrategies.mm:
3818         (WebPlatformStrategies::setColor):
3819
3820 2018-08-15  Tim Horton  <timothy_horton@apple.com>
3821
3822         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
3823         https://bugs.webkit.org/show_bug.cgi?id=188569
3824         <rdar://problem/34201095>
3825
3826         Reviewed by Megan Gardner.
3827
3828         * WebView/WebImmediateActionController.mm:
3829         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
3830         Speculative fix; the crashes indicate font is null, but we just checked it,
3831         so it must be getting made null by convertFont:toSize:. Check again!
3832
3833 2018-08-13  Alex Christensen  <achristensen@webkit.org>
3834
3835         Use a 1-byte enum class for TextDirection
3836         https://bugs.webkit.org/show_bug.cgi?id=188350
3837
3838         Reviewed by Simon Fraser.
3839
3840         * WebCoreSupport/PopupMenuMac.mm:
3841         (PopupMenuMac::populate):
3842         (PopupMenuMac::show):
3843         * WebCoreSupport/WebFrameLoaderClient.mm:
3844         (WebFrameLoaderClient::transitionToCommittedForNewPage):
3845         * WebView/WebFrame.mm:
3846         (-[WebFrame _dispatchDidReceiveTitle:]):
3847
3848 2018-08-09  Ali Juma  <ajuma@chromium.org>
3849
3850         Import WPTs for IntersectionObserver
3851         https://bugs.webkit.org/show_bug.cgi?id=188416
3852
3853         Reviewed by Simon Fraser.
3854
3855         * WebView/WebPreferencesPrivate.h:
3856
3857 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
3858
3859         Follow-up build fix for r234685
3860         https://bugs.webkit.org/show_bug.cgi?id=188245
3861
3862         Unreviewed build fix.
3863
3864         * WebCoreSupport/WebSecurityOriginPrivate.h:
3865
3866 2018-08-05  Darin Adler  <darin@apple.com>
3867
3868         [Cocoa] More tweaks and refactoring to prepare for ARC
3869         https://bugs.webkit.org/show_bug.cgi?id=188245
3870
3871         Reviewed by Dan Bernstein.
3872
3873         * Carbon/CarbonUtils.m: Updated include for rename: FoundationSPI.h -> objcSPI.h.
3874
3875         * Carbon/CarbonWindowFrame.m:
3876         (-[CarbonWindowFrame dealloc]): Deleted. It was empty.
3877
3878         * DOM/DOM.mm:
3879         (-[DOMElement _imageTIFFRepresentation]): Use a bridging cast.
3880         (-[DOMNodeFilter finalize]): Deleted. WebKit no longer supports Objective-C
3881         garbage collection so this method isn't useful.
3882
3883         * DOM/DOMXPath.mm:
3884         (-[DOMNativeXPathNSResolver finalize]): Deleted. WebKit no longer supports
3885         Objective-C garbage collection so this method isn't useful.
3886
3887         * History/WebHistory.mm:
3888         (-[WebHistoryPrivate data]): Allocate an NSData instead of casting from a CFData.
3889
3890         * Misc/WebElementDictionary.mm:
3891         (addLookupKey): Use a bridging cast.
3892         (cacheValueForKey): Ditto.
3893         (-[WebElementDictionary _fillCache]): Ditto.
3894         (-[WebElementDictionary objectForKey:]): Ditto.
3895
3896         * Misc/WebKitNSStringExtras.mm:
3897         (-[NSString _web_drawAtPoint:font:textColor:]): Use a bridging cast.
3898         (-[NSString _web_widthWithFont:]): Ditto.
3899         (-[NSString _webkit_stringByTrimmingWhitespace]): Ditto.
3900
3901         * Misc/WebLocalizableStrings.mm:
3902         (WebLocalizedString): Use a bridging cast.
3903
3904         * Misc/WebNSDataExtras.mm:
3905         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Use a bridging cast
3906         and use CFBridgingRelease instead of calling autorelease directly.
3907         (-[NSData _webkit_parseRFC822HeaderFields]): Use NSString methods instead
3908         of a mix of CFString and NSString. Also simplified logic a bit, and cut down
3909         on the amount of explicit release and autorelease.
3910
3911         * Misc/WebNSDictionaryExtras.h: Deleted unused methods.
3912         * Misc/WebNSDictionaryExtras.m:
3913         (-[NSDictionary _webkit_intForKey:]): Deleted.
3914         (-[NSMutableDictionary _webkit_setInt:forKey:]): Deleted.
3915         (-[NSMutableDictionary _webkit_setFloat:forKey:]): Deleted.
3916         (-[NSMutableDictionary _webkit_setBool:forKey:]): Deleted.
3917         (-[NSMutableDictionary _webkit_setLongLong:forKey:]): Deleted.
3918         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Deleted.
3919         (-[NSMutableDictionary _webkit_setUnsignedInt:forKey:]): Deleted.
3920
3921         * Misc/WebStringTruncator.mm:
3922         (fontFromNSFont): Use a bridging cast.
3923
3924         * Plugins/Hosted/NetscapePluginHostManager.mm:
3925         (WebKit::preferredBundleLocalizationName): Use a bridging cast and CFBridgingRelease.
3926
3927         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3928         (WebKit::NetscapePluginInstanceProxy::cleanup): Use a bridging cast.
3929         (WebKit::NetscapePluginInstanceProxy::status): Ditto.
3930         (WebKit::NetscapePluginInstanceProxy::loadURL): Ditto.
3931         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray): Ditto.
3932         * Plugins/Hosted/ProxyInstance.mm:
3933         (WebKit::ProxyInstance::getPropertyNames): Ditto.
3934         * Plugins/WebBasePluginPackage.mm:
3935         (-[WebBasePluginPackage _objectForInfoDictionaryKey:]): Ditto.
3936         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
3937         (WebNetscapePluginEventHandlerCocoa::platformWindow): Ditto.
3938         * Plugins/WebNetscapePluginPackage.mm:
3939         (-[WebNetscapePluginPackage _initWithPath:]): Ditto.
3940
3941         * Plugins/WebNetscapePluginView.mm:
3942         (-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
3943         Use bridging casts and use RetainPtr insteead of an explicit CFRelease.
3944         (-[WebNetscapePluginView status:]): Use a bridging cast.
3945         (-[WebNetscapePluginView popUpContextMenu:]): Ditto.
3946
3947         * Plugins/WebPluginController.mm:
3948         (-[WebPluginController _cancelOutstandingChecks]): Use a bridging cast.
3949
3950         * Plugins/WebPluginDatabase.mm:
3951         (checkCandidate): Use explicit __strong for out argument types.
3952
3953         * Plugins/npapi.mm:
3954         (pluginViewForInstance): Use a bridging cast.
3955
3956         * Storage/WebDatabaseManager.mm:
3957         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Use modern boxing instead of
3958         explicit NSNumber and NSDictionary calls.
3959
3960         * WebCoreSupport/WebContextMenuClient.mm:
3961         (WebContextMenuClient::speak): Remove an unnecessary copy/autorelease pair.
3962
3963         * WebCoreSupport/WebEditorClient.mm:
3964         (WebEditorClient::handleKeyboardEvent): Added a missing typecast.
3965         (WebEditorClient::handleInputMethodKeydown): Ditto.
3966
3967         * WebCoreSupport/WebFrameNetworkingContext.mm:
3968         (WebFrameNetworkingContext::sourceApplicationAuditData const): Use a bridging cast.
3969
3970         * WebCoreSupport/WebSecurityOriginPrivate.h: Forward declare WebSecurityOriginPrivate
3971         as a struct rather than an Objective-C class, since that's how it's defined.
3972
3973         * WebInspector/WebNodeHighlighter.mm: Added missing includes.
3974
3975         * WebView/WebFullScreenController.mm:
3976         (-[WebFullScreenController enterFullScreen:]): Use a bridging cast.
3977         * WebView/WebHTMLView.mm:
3978         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
3979         Ditto.
3980         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
3981
3982         * WebView/WebImmediateActionController.mm:
3983         (-[WebImmediateActionController performHitTestAtPoint:]): Removed redundant code to
3984         go down to the document and then back to the frame.
3985         (-[WebImmediateActionController immediateActionRecognizerDidUpdateAnimation:]): Ditto.
3986         (-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]): Ditto.
3987         (-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]): Ditto.
3988
3989         * WebView/WebJSPDFDoc.mm:
3990         (jsPDFDocInitialize): Removed some unneeded type casting.
3991         (jsPDFDocFinalize): Ditto.
3992         (jsPDFDocPrint): Use a bridging cast.
3993
3994         * WebView/WebPDFView.mm:
3995         (_applicationInfoForMIMEType): Use bridging casts.
3996
3997         * WebView/WebPreferences.mm:
3998         (-[WebPreferences _setIntegerValue:forKey:]): Use boxing and setObject directly
3999         instead of methods from WebNSDictionaryExtras.
4000         (-[WebPreferences _setUnsignedIntValue:forKey:]): Ditto.
4001         (-[WebPreferences _setFloatValue:forKey:]): Ditto.
4002         (-[WebPreferences _setBoolValue:forKey:]): Ditto.
4003         (-[WebPreferences _setLongLongValue:forKey:]): Ditto.
4004         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto.
4005
4006         * WebView/WebView.mm:
4007         (-[WebView _removeFromAllWebViewsSet]): Use bridging cast.
4008         (-[WebView _addToAllWebViewsSet]): Ditto.
4009         (+[WebView closeAllWebViews]): Use a modern for loop instead of NSEnumerator.
4010         (-[WebView _windowVisibilityChanged:]): Moved this into the internal category
4011         so it can be called from WebViewData methods.
4012
4013         * WebView/WebViewData.mm: Added an import so we can call an internal WebView
4014         method, _windowVisibilityChanged:.
4015
4016         * WebView/WebViewInternal.h: Declared _windowVisibilityChanged: so it can be
4017         called from WebViewData methods.
4018
4019 2018-08-06  Alex Christensen  <achristensen@webkit.org>
4020
4021         Use enum classes and OptionSets for PaintPhase and PaintBehavior
4022         https://bugs.webkit.org/show_bug.cgi?id=188323
4023
4024         Reviewed by Simon Fraser.
4025
4026         * WebCoreSupport/WebContextMenuClient.mm:
4027         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
4028         * WebView/WebFrame.mm:
4029         (-[WebFrame _paintBehaviorForDestinationContext:]):
4030         (-[WebFrame _drawRect:contentsOnly:]):
4031         * WebView/WebHTMLView.mm:
4032         (imageFromRect):
4033         (selectionImage):
4034
4035 2018-08-05  Yusuke Suzuki  <utatane.tea@gmail.com>
4036
4037         Add support for microtasks in workers
4038         https://bugs.webkit.org/show_bug.cgi?id=188246
4039
4040         Reviewed by Darin Adler.
4041
4042         Rename JSMainThreadExecState.h to JSExecState.h.
4043
4044         * DOM/DOMAttr.mm:
4045         * DOM/DOMBlob.mm:
4046         * DOM/DOMCDATASection.mm:
4047         * DOM/DOMCSSCharsetRule.mm:
4048         * DOM/DOMCSSFontFaceRule.mm:
4049         * DOM/DOMCSSImportRule.mm:
4050         * DOM/DOMCSSMediaRule.mm:
4051         * DOM/DOMCSSPageRule.mm:
4052         * DOM/DOMCSSPrimitiveValue.mm:
4053         * DOM/DOMCSSRule.mm:
4054         * DOM/DOMCSSRuleList.mm: