[macOS] Select element doesn't show popup if select element had lost focus while...
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2019-03-27  Ryosuke Niwa  <rniwa@webkit.org>
2
3         [macOS] Select element doesn't show popup if select element had lost focus while popup was previosuly shown
4         https://bugs.webkit.org/show_bug.cgi?id=196336
5
6         Reviewed by Tim Horton.
7
8         Fixed the bug that we were not actually dismissing the popup in PopupMenuMac::hide as done in WebKit2.
9
10         Unfortunately no new tests since intenals.isSelectPopupVisible would always return false in WebKit1.
11
12         * WebCoreSupport/PopupMenuMac.mm:
13         (PopupMenuMac::hide):
14
15 2019-03-25  Andy Estes  <aestes@apple.com>
16
17         [iOS] Break a reference cycle between PreviewLoader and ResourceLoader
18         https://bugs.webkit.org/show_bug.cgi?id=194964
19         <rdar://problem/48279441>
20
21         Reviewed by Alex Christensen.
22
23         The WebDataSource._quickLookContent SPI accidentally relied on PreviewLoaders being leaked
24         to keep the temporary file referenced by WebQuickLookFileNameKey in existence. Since
25         PreviewLoaders are now being deleted properly, we teach WebDataSource to keep the
26         PreviewLoaderClient alive for its lifetime. This ensures that as long as
27         WebDataSource._quickLookContent can be called, the associated temp file will not be deleted
28         by WebKit.
29
30         * WebCoreSupport/WebFrameLoaderClient.mm:
31         (WebFrameLoaderClient::createPreviewLoaderClient):
32         * WebView/WebDataSource.mm:
33         (-[WebDataSource _quickLookPreviewLoaderClient]):
34         (-[WebDataSource _setQuickLookPreviewLoaderClient:]):
35         * WebView/WebDataSourceInternal.h:
36
37 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
38
39         Remove NavigatorContentUtils in WebCore/Modules
40         https://bugs.webkit.org/show_bug.cgi?id=196070
41
42         Reviewed by Alex Christensen.
43
44         NavigatorContentUtils was to support the custom scheme spec [1].
45         However, in WebKit side, no port has supported the feature in
46         WebKit layer after EFL port was removed. So there has been the
47         only IDL implementation of the NavigatorContentUtils in WebCore.
48         So we don't need to keep the implementation in WebKit.
49
50         * Configurations/FeatureDefines.xcconfig:
51
52 2019-03-22  Keith Rollin  <krollin@apple.com>
53
54         Enable ThinLTO support in Production builds
55         https://bugs.webkit.org/show_bug.cgi?id=190758
56         <rdar://problem/45413233>
57
58         Reviewed by Daniel Bates.
59
60         Enable building with Thin LTO in Production when using Xcode 10.2 or
61         later. This change results in a 1.45% progression in PLT5. Full
62         Production build times increase about 2-3%. Incremental build times
63         are more severely affected, and so LTO is not enabled for local
64         engineering builds.
65
66         LTO is enabled only on macOS for now, until rdar://problem/49013399,
67         which affects ARM builds, is fixed.
68
69         To change the LTO setting when building locally:
70
71         - If building with `make`, specify WK_LTO_MODE={none,thin,full} on the
72           command line.
73         - If building with `build-webkit`, specify --lto-mode={none,thin,full}
74           on the command line.
75         - If building with `build-root`, specify --lto={none,thin,full} on the
76           command line.
77         - If building with Xcode, create a LocalOverrides.xcconfig file at the
78           top level of your repository directory (if needed) and define
79           WK_LTO_MODE to full, thin, or none.
80
81         * Configurations/Base.xcconfig:
82
83 2019-03-21  Andy Estes  <aestes@apple.com>
84
85         [iOS] Apple Pay should be available in documents with no user agent scripts
86         https://bugs.webkit.org/show_bug.cgi?id=196061
87         <rdar://problem/48649391>
88
89         Reviewed by Brady Eidson.
90
91         * WebView/WebFrame.mm:
92         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
93
94 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
95
96         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
97         https://bugs.webkit.org/show_bug.cgi?id=196049
98
99         Reviewed by Tim Horton.
100
101         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
102         overflow scrolling in general, so rename it.
103
104         * Configurations/FeatureDefines.xcconfig:
105
106 2019-03-13  Dean Jackson  <dino@apple.com>
107
108         Block all plugins smaller than 5x5px
109         https://bugs.webkit.org/show_bug.cgi?id=195702
110         <rdar://problem/28435204>
111
112         Reviewed by Sam Weinig.
113
114         Removed a function that was never being called.
115
116         * WebCoreSupport/WebFrameLoaderClient.h:
117         * WebCoreSupport/WebFrameLoaderClient.mm:
118         (WebFrameLoaderClient::recreatePlugin): Deleted.
119
120 2019-03-13  Keith Rollin  <krollin@apple.com>
121
122         Add support for new StagedFrameworks layout
123         https://bugs.webkit.org/show_bug.cgi?id=195543
124
125         Reviewed by Alexey Proskuryakov.
126
127         When creating the WebKit layout for out-of-band Safari/WebKit updates,
128         use an optional path prefix when called for.
129
130         * Configurations/WebKitLegacy.xcconfig:
131
132 2019-03-12  Ryosuke Niwa  <rniwa@webkit.org>
133
134         Remove a site specific hack for AppleConnect plugin
135         https://bugs.webkit.org/show_bug.cgi?id=195643
136
137         Reviewed by Simon Fraser.
138
139         r66437 added a workaround for AppleConnect plugin.
140
141         Remove this code since Safari doesn't even use WebKitLegacy anymore,
142         and other WebKit clients support AppleConnect plugins.
143
144         * WebCoreSupport/WebFrameLoaderClient.mm:
145         (WebFrameLoaderClient::createPlugin):
146
147 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
148
149         Unreviewed, rolling out r242688, r242643, r242624.
150
151         Caused multiple layout test failures and crashes on iOS and macOS.
152
153         Reverted changeset:
154
155         "requestAnimationFrame should execute before the next frame"
156         https://bugs.webkit.org/show_bug.cgi?id=177484
157         https://trac.webkit.org/changeset/242624/webkit
158
159         * WebView/WebView.mm:
160         (-[WebView _viewWillDrawInternal]):
161
162 2019-03-09  Andy Estes  <aestes@apple.com>
163
164         [Apple Pay] CanMakePaymentsWithActiveCard and OpenPaymentSetup should be async messages
165         https://bugs.webkit.org/show_bug.cgi?id=195526
166         <rdar://problem/48745636>
167
168         Reviewed by Chris Dumez.
169
170         * WebCoreSupport/WebPaymentCoordinatorClient.h:
171         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
172         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
173         (WebPaymentCoordinatorClient::openPaymentSetup):
174
175 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
176
177         requestAnimationFrame should execute before the next frame
178         https://bugs.webkit.org/show_bug.cgi?id=177484
179
180         Reviewed by Simon Fraser.
181
182         * WebView/WebView.mm:
183         (-[WebView _viewWillDrawInternal]):
184         Call Page::renderingUpdate() which implements  "Update the rendering"
185         step of the HTML Event Loop specification.
186
187 2019-03-07  Zalan Bujtas  <zalan@apple.com>
188
189         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
190         https://bugs.webkit.org/show_bug.cgi?id=195353
191         <rdar://problem/48626394>
192
193         Reviewed by Simon Fraser.
194
195         * WebView/WebPreferenceKeysPrivate.h:
196         * WebView/WebPreferences.mm:
197         (+[WebPreferences initialize]):
198         (-[WebPreferences contentChangeObserverEnabled]):
199         (-[WebPreferences setContentChangeObserverEnabled:]):
200         * WebView/WebPreferencesPrivate.h:
201         * WebView/WebView.mm:
202         (-[WebView _preferencesChanged:]):
203
204 2019-03-06  Sam Weinig  <sam@webkit.org>
205
206         WebKitLegacy does not need to generate an export file for i386 anymore
207         https://bugs.webkit.org/show_bug.cgi?id=195380
208
209         Reviewed by Dan Bernstein.
210
211         * Configurations/WebKitLegacy.xcconfig:
212         Simplify EXPORTED_SYMBOLS_FILE down to just a single path to a generated file.
213         It still needs to be generated, since we are concatenating the shared exports
214         file with a macOS or iOS specific one.
215
216         * WebKit.mac.exp:
217         Remove i386 specific symbols that we were previously stripping.
218
219 2019-03-06  Rob Buis  <rbuis@igalia.com>
220
221         Consider supporting the `referrerpolicy` attribute.
222         https://bugs.webkit.org/show_bug.cgi?id=179053
223
224         Reviewed by Darin Adler.
225
226         Add a runtime flag for referrerpolicy attribute.
227
228         * WebView/WebPreferenceKeysPrivate.h:
229         * WebView/WebPreferences.mm:
230         (+[WebPreferences initialize]):
231         (-[WebPreferences referrerPolicyAttributeEnabled]):
232         (-[WebPreferences setReferrerPolicyAttributeEnabled:]):
233         * WebView/WebPreferencesPrivate.h:
234         * WebView/WebView.mm:
235         (-[WebView _preferencesChanged:]):
236
237 2019-03-03  Tim Horton  <timothy_horton@apple.com>
238
239         Remove some more unused 32-bit code
240         https://bugs.webkit.org/show_bug.cgi?id=195255
241
242         Reviewed by Darin Adler.
243
244         * Plugins/WebNetscapePluginEventHandler.mm:
245         (WebNetscapePluginEventHandler::create):
246         * Plugins/WebNetscapePluginView.h:
247         * Plugins/WebNetscapePluginView.mm:
248         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
249         (-[WebNetscapePluginView restorePortState:]):
250         (-[WebNetscapePluginView sendEvent:isDrawRect:]):
251         (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
252         (-[WebNetscapePluginView updateAndSetWindow]):
253         (-[WebNetscapePluginView setWindowIfNecessary]):
254         (-[WebNetscapePluginView createPlugin]):
255         (-[WebNetscapePluginView fini]):
256         (-[WebNetscapePluginView drawRect:]):
257         (-[WebNetscapePluginView invalidateRegion:]):
258         (-[WebNetscapePluginView getVariable:value:]):
259         (-[WebNetscapePluginView setVariable:value:]):
260         (isDrawingModelQuickDraw): Deleted.
261         (-[WebNetscapePluginView fixWindowPort]): Deleted.
262         (getQDPixelFormatForBitmapContext): Deleted.
263         (-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
264         (-[WebNetscapePluginView _printedPluginBitmap]): Deleted.
265         * WebView/WebDelegateImplementationCaching.mm:
266
267 2019-03-02  Wenson Hsieh  <wenson_hsieh@apple.com>
268
269         [iOS] Programmatic paste access should be granted when copying and pasting within the same origin
270         https://bugs.webkit.org/show_bug.cgi?id=195053
271         <rdar://problem/48134710>
272
273         Reviewed by Ryosuke Niwa.
274
275         * WebCoreSupport/WebEditorClient.h:
276
277 2019-03-01  Tim Horton  <timothy_horton@apple.com>
278
279         Remove unused code in WebKitLegacy
280         https://bugs.webkit.org/show_bug.cgi?id=189614
281
282         Reviewed by Simon Fraser.
283
284         * Carbon/CarbonUtils.h: Removed.
285         * Carbon/CarbonUtils.m: Removed.
286         * Carbon/CarbonWindowAdapter.h: Removed.
287         * Carbon/CarbonWindowAdapter.mm: Removed.
288         * Carbon/CarbonWindowContentView.h: Removed.
289         * Carbon/CarbonWindowContentView.m: Removed.
290         * Carbon/CarbonWindowFrame.h: Removed.
291         * Carbon/CarbonWindowFrame.m: Removed.
292         * Carbon/HIViewAdapter.h: Removed.
293         * Carbon/HIViewAdapter.m: Removed.
294         * Carbon/HIWebView.h: Removed.
295         * Carbon/HIWebView.mm: Removed.
296         * Configurations/WebKitLegacy.xcconfig:
297         * WebKit.mac.exp:
298
299 2019-03-01  Justin Fan  <justin_fan@apple.com>
300
301         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
302         https://bugs.webkit.org/show_bug.cgi?id=195191
303
304         Rubber-stamped by Dean Jackson.
305
306         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
307
308         * Configurations/FeatureDefines.xcconfig:
309
310 2019-02-28  Antoine Quint  <graouts@apple.com>
311
312         Enable the Pointer Events runtime flag by default
313         https://bugs.webkit.org/show_bug.cgi?id=195156
314
315         Reviewed by Dean Jackson.
316
317         * WebView/WebPreferences.mm:
318         (+[WebPreferences initialize]):
319
320 2019-02-28  Justin Fan  <justin_fan@apple.com>
321
322         [Web GPU] Enable Web GPU only on 64-bit
323         https://bugs.webkit.org/show_bug.cgi?id=195139
324
325         Because Metal is only supported on 64 bit apps.
326
327         Unreviewed build fix.
328
329         * Configurations/FeatureDefines.xcconfig:
330
331 2019-02-27  Antoine Quint  <graouts@apple.com>
332
333         Support Pointer Events on macOS
334         https://bugs.webkit.org/show_bug.cgi?id=195008
335         <rdar://problem/47454419>
336
337         Reviewed by Dean Jackson.
338
339         Add a WebKitLegacy API to enable and disable the Pointer Events runtime feature.
340
341         * Configurations/FeatureDefines.xcconfig:
342         * WebView/WebPreferenceKeysPrivate.h:
343         * WebView/WebPreferences.mm:
344         (+[WebPreferences initialize]):
345         (-[WebPreferences pointerEventsEnabled]):
346         (-[WebPreferences setPointerEventsEnabled:]):
347         * WebView/WebPreferencesPrivate.h:
348         * WebView/WebView.mm:
349         (-[WebView _preferencesChanged:]):
350
351 2019-02-23  Keith Miller  <keith_miller@apple.com>
352
353         Add new mac target numbers
354         https://bugs.webkit.org/show_bug.cgi?id=194955
355
356         Reviewed by Tim Horton.
357
358         * Configurations/Base.xcconfig:
359         * Configurations/DebugRelease.xcconfig:
360
361 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
362
363         Hardcode Visual Viewports on everywhere except iOS WK1
364         https://bugs.webkit.org/show_bug.cgi?id=194928
365
366         Reviewed by Zalan Bujtas.
367
368         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
369         change the default value of the Setting to 'true', and hardcode WebView on iOS to
370         set it to false. The setting has shipped for several years and there's no need to turn
371         it off now.
372
373         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
374         Visual Viewports are not enabled.
375         
376         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
377         that only runs in WK2
378
379         * WebView/WebPreferenceKeysPrivate.h:
380         * WebView/WebPreferences.mm:
381         (+[WebPreferences initialize]):
382         (-[WebPreferences visualViewportEnabled]): Deleted.
383         (-[WebPreferences setVisualViewportEnabled:]): Deleted.
384         * WebView/WebPreferencesPrivate.h:
385         * WebView/WebView.mm:
386         (-[WebView _preferencesChanged:]):
387
388 2019-02-21  Darin Adler  <darin@apple.com>
389
390         Some refinements for Node and Document
391         https://bugs.webkit.org/show_bug.cgi?id=194764
392
393         Reviewed by Ryosuke Niwa.
394
395         * DOM/DOMDocument.mm:
396         (-[DOMDocument getOverrideStyle:pseudoElement:]): Return nil without calling
397         through to WebCore or even looking at the arguments.
398         (-[DOMDocument getOverrideStyle::]): Ditto.
399
400 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
401
402         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
403         https://bugs.webkit.org/show_bug.cgi?id=194670
404         <rdar://problem/39066529>
405
406         Reviewed by Tim Horton.
407
408         * WebCoreSupport/WebEditorClient.h:
409         * WebCoreSupport/WebEditorClient.mm:
410         (WebEditorClient::replacementURLForResource): Deleted.
411         * WebCoreSupport/WebPlatformStrategies.h:
412         * WebCoreSupport/WebPlatformStrategies.mm:
413         (WebPlatformStrategies::getTypesByFidelityForItemAtIndex): Deleted.
414
415 2019-02-18  Eric Carlson  <eric.carlson@apple.com>
416
417         Add MSE logging configuration
418         https://bugs.webkit.org/show_bug.cgi?id=194719
419         <rdar://problem/48122151>
420
421         Reviewed by Joseph Pecoraro.
422
423         * WebCoreSupport/WebChromeClient.mm:
424         (stringForMessageSource): Recognize the MSE message source.
425
426 2019-02-17  David Kilzer  <ddkilzer@apple.com>
427
428         Unreviewed, rolling out r241620.
429
430         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
431         (Requested by ddkilzer on #webkit.)
432
433         Reverted changeset:
434
435         "[WTF] Add environment variable helpers"
436         https://bugs.webkit.org/show_bug.cgi?id=192405
437         https://trac.webkit.org/changeset/241620
438
439 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
440
441         [WTF] Add environment variable helpers
442         https://bugs.webkit.org/show_bug.cgi?id=192405
443
444         Reviewed by Michael Catanzaro.
445
446         * WebView/WebView.mm:
447         (-[WebView _initWithFrame:frameName:groupName:]):
448         Utilize WTF::Environment where possible.
449
450 2019-02-15  Brian Burg  <bburg@apple.com>
451
452         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
453         https://bugs.webkit.org/show_bug.cgi?id=194411
454         <rdar://problem/47787614>
455
456         Reviewed by Joseph Pecoraro.
457
458         * Configurations/WebKitLegacy.xcconfig:
459         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
460
461         * WebCoreSupport/WebInspectorClient.mm:
462         (WebInspectorFrontendClient::localizedStringsURL):
463         (-[WebInspectorWindowController inspectorPagePath]):
464         (-[WebInspectorWindowController inspectorTestPagePath]):
465         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
466
467 2019-02-15  Commit Queue  <commit-queue@webkit.org>
468
469         Unreviewed, rolling out r241559 and r241566.
470         https://bugs.webkit.org/show_bug.cgi?id=194710
471
472         Causes layout test crashes under GuardMalloc (Requested by
473         ryanhaddad on #webkit).
474
475         Reverted changesets:
476
477         "[WTF] Add environment variable helpers"
478         https://bugs.webkit.org/show_bug.cgi?id=192405
479         https://trac.webkit.org/changeset/241559
480
481         "Unreviewed build fix for WinCairo Debug after r241559."
482         https://trac.webkit.org/changeset/241566
483
484 2019-02-15  Truitt Savell  <tsavell@apple.com>
485
486         Unreviewed, rolling out r241564.
487
488         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
489
490         Reverted changeset:
491
492         "[Mac] WebInspectorUI.framework does not need to be soft-
493         linked anymore"
494         https://bugs.webkit.org/show_bug.cgi?id=194411
495         https://trac.webkit.org/changeset/241564
496
497 2019-02-14  Brian Burg  <bburg@apple.com>
498
499         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
500         https://bugs.webkit.org/show_bug.cgi?id=194411
501         <rdar://problem/47787614>
502
503         Reviewed by Joseph Pecoraro.
504
505         * Configurations/WebKitLegacy.xcconfig:
506         Conditionalize weak linking to WebInspectorUI.framework for Mac only.
507
508         * WebCoreSupport/WebInspectorClient.mm:
509         (WebInspectorFrontendClient::localizedStringsURL):
510         (-[WebInspectorWindowController inspectorPagePath]):
511         (-[WebInspectorWindowController inspectorTestPagePath]):
512         Rewrite uses of the bundle to exit early if bundle couldn't be loaded.
513
514 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
515
516         [WTF] Add environment variable helpers
517         https://bugs.webkit.org/show_bug.cgi?id=192405
518
519         Reviewed by Michael Catanzaro.
520
521         * WebView/WebView.mm:
522         (-[WebView _initWithFrame:frameName:groupName:]):
523         Utilize WTF::Environment where possible.
524
525 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
526
527         Allow pages to trigger programmatic paste from script on iOS
528         https://bugs.webkit.org/show_bug.cgi?id=194271
529         <rdar://problem/47808810>
530
531         Reviewed by Ryosuke Niwa.
532
533         See WebCore and WebKit ChangeLogs for more details.
534
535         * WebCoreSupport/WebEditorClient.h:
536
537 2019-02-12  Andy Estes  <aestes@apple.com>
538
539         [iOSMac] Enable Parental Controls Content Filtering
540         https://bugs.webkit.org/show_bug.cgi?id=194521
541         <rdar://39732376>
542
543         Reviewed by Tim Horton.
544
545         * Configurations/FeatureDefines.xcconfig:
546
547 2019-02-06  Andy Estes  <aestes@apple.com>
548
549         [Payment Request] It should be possible to require a phonetic name for shipping contacts
550         https://bugs.webkit.org/show_bug.cgi?id=194311
551         <rdar://46733045>
552
553         Reviewed by Alex Christensen.
554
555         * WebCoreSupport/WebPaymentCoordinatorClient.h:
556         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
557         (WebPaymentCoordinatorClient::supportsVersion): Deleted.
558
559 2019-02-04  Said Abou-Hallawa  <said@apple.com>
560
561         [CG] Enable setAdditionalSupportedImageTypes for WK1
562         https://bugs.webkit.org/show_bug.cgi?id=194190
563
564         Reviewed by Tim Horton.
565
566         1. Define the preferences key AdditionalSupportedImageTypes.
567         2. Add additionalSupportedImageTypes as a private preference property.
568         3. Define the setter and the getter of the property.
569         4. Add function to convert from an id to an array of strings.
570         5. Call WebCore::setAdditionalSupportedImageTypes when preferences change.
571
572         * WebView/WebPreferenceKeysPrivate.h:
573         * WebView/WebPreferences.mm:
574         (-[WebPreferences _stringArrayValueForKey:]):
575         (-[WebPreferences _setStringArrayValueForKey:forKey:]):
576         (-[WebPreferences setAdditionalSupportedImageTypes:]):
577         (-[WebPreferences additionalSupportedImageTypes]):
578         * WebView/WebPreferencesPrivate.h:
579         * WebView/WebView.mm:
580         (-[WebView _preferencesChanged:]):
581
582 2019-02-04  Timothy Hatcher  <timothy@apple.com>
583
584         Add WebView SPI to temporarily force light or dark appearance on a page.
585         https://bugs.webkit.org/show_bug.cgi?id=194230
586
587         Reviewed by Tim Horton.
588
589         * WebView/WebView.mm:
590         (-[WebView _useDarkAppearance:]): Added.
591         (-[WebView _setUseDarkAppearance:]): Added.
592         * WebView/WebViewPrivate.h:
593
594 2019-02-04  Simon Fraser  <simon.fraser@apple.com>
595
596         PageOverlayController's layers should be created lazily
597         https://bugs.webkit.org/show_bug.cgi?id=194199
598         rdar://problem/46571593
599
600         Reviewed by Tim Horton.
601
602         * WebCoreSupport/WebChromeClient.h:
603         * WebCoreSupport/WebChromeClient.mm:
604         (WebChromeClient::attachViewOverlayGraphicsLayer):
605
606 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
607
608         Make setNeedsLayout on the root more explicitly about triggering its side-effects
609         https://bugs.webkit.org/show_bug.cgi?id=194198
610
611         Reviewed by Antti Koivisto.
612
613         Call the newly named functions.
614
615         * WebView/WebFrame.mm:
616         (-[WebFrame setNeedsLayout]):
617         * WebView/WebHTMLView.mm:
618         (-[WebHTMLView setNeedsLayout:]):
619
620 2019-02-03  Ryosuke Niwa  <rniwa@webkit.org>
621
622         Validate navigation policy decisions to avoid crashes in continueLoadAfterNavigationPolicy
623         https://bugs.webkit.org/show_bug.cgi?id=194189
624
625         Reviewed by Geoffrey Garen.
626
627         Pass the policy check identifier around functions and store it in WebFramePolicyListener
628         so that we can send it back to WebCore with the navigation policy decision.
629
630         * WebCoreSupport/WebFrameLoaderClient.h:
631         * WebCoreSupport/WebFrameLoaderClient.mm:
632         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
633         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
634         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
635         (WebFrameLoaderClient::dispatchWillSubmitForm):
636         (WebFrameLoaderClient::setUpPolicyListener):
637         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:]):
638         (-[WebFramePolicyListener initWithFrame:identifier:policyFunction:defaultPolicy:appLinkURL:]):
639         (-[WebFramePolicyListener invalidate]):
640         (-[WebFramePolicyListener dealloc]):
641         (-[WebFramePolicyListener receivedPolicyDecision:]):
642         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:]): Deleted.
643         (-[WebFramePolicyListener initWithFrame:policyFunction:defaultPolicy:appLinkURL:]): Deleted.
644
645 2019-01-31  Alex Christensen  <achristensen@webkit.org>
646
647         Revert r238819 which is unneeded and caused a performance regression.
648         https://bugs.webkit.org/show_bug.cgi?id=192272
649         <rdar://problem/46664625>
650
651         * WebCoreSupport/WebFrameLoaderClient.h:
652         * WebCoreSupport/WebFrameLoaderClient.mm:
653         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
654
655 2019-01-28  Devin Rousso  <drousso@apple.com>
656
657         Web Inspector: provide a way to edit page WebRTC settings on a remote target
658         https://bugs.webkit.org/show_bug.cgi?id=193863
659         <rdar://problem/47572764>
660
661         Reviewed by Joseph Pecoraro.
662
663         * WebView/WebView.mm:
664         (-[WebView _preferencesChanged:]):
665         Add page-level settings for WebRTC preferences.
666
667 2019-01-28  Andy Estes  <aestes@apple.com>
668
669         [watchOS] Enable Parental Controls content filtering
670         https://bugs.webkit.org/show_bug.cgi?id=193939
671         <rdar://problem/46641912>
672
673         Reviewed by Ryosuke Niwa.
674
675         * Configurations/FeatureDefines.xcconfig:
676
677 2019-01-28  Timothy Hatcher  <timothy@apple.com>
678
679         Make it easier for non-Apple ports to enable dark mode CSS support.
680         https://bugs.webkit.org/show_bug.cgi?id=193882
681
682         Reviewed by Megan Gardner.
683
684         * WebView/WebView.mm:
685         (-[WebView _commonInitializationWithFrameName:groupName:]): Fix some defines.
686         (-[WebView _effectiveAppearanceIsDark]): Ditto.
687
688 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
689
690         AX: Introduce a static accessibility tree
691         https://bugs.webkit.org/show_bug.cgi?id=193348
692         <rdar://problem/47203295>
693
694         Reviewed by Ryosuke Niwa.
695
696         * Configurations/FeatureDefines.xcconfig:
697
698 2019-01-25  Keith Rollin  <krollin@apple.com>
699
700         Update WebKitAdditions.xcconfig with correct order of variable definitions
701         https://bugs.webkit.org/show_bug.cgi?id=193793
702         <rdar://problem/47532439>
703
704         Reviewed by Alex Christensen.
705
706         XCBuild changes the way xcconfig variables are evaluated. In short,
707         all config file assignments are now considered in part of the
708         evaluation. When using the new build system and an .xcconfig file
709         contains multiple assignments of the same build setting:
710
711         - Later assignments using $(inherited) will inherit from earlier
712           assignments in the xcconfig file.
713         - Later assignments not using $(inherited) will take precedence over
714           earlier assignments. An assignment to a more general setting will
715           mask an earlier assignment to a less general setting. For example,
716           an assignment without a condition ('FOO = bar') will completely mask
717           an earlier assignment with a condition ('FOO[sdk=macos*] = quux').
718
719         This affects some of our .xcconfig files, in that sometimes platform-
720         or sdk-specific definitions appear before the general definitions.
721         Under the new evaluations rules, the general definitions alway take
722         effect because they always overwrite the more-specific definitions. The
723         solution is to swap the order, so that the general definitions are
724         established first, and then conditionally overwritten by the
725         more-specific definitions.
726
727         * Configurations/Version.xcconfig:
728         * Configurations/WebKitLegacy.xcconfig:
729
730 2019-01-25  David Kilzer  <ddkilzer@apple.com>
731
732         Move soft-linking of Lookup.framework out of LookupSPI.h
733         <https://webkit.org/b/193815>
734
735         Reviewed by Tim Horton.
736
737         * WebView/WebImmediateActionController.mm:
738         (-[WebImmediateActionController _animationControllerForText]):
739         * WebView/WebView.mm:
740         (-[WebView _prepareForDictionaryLookup]):
741         - Move soft-linking to LookupSoftLink.{h,mm}.
742
743 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
744
745         [iOS] Rename some WebKit-internal functions and variables that reference "data interaction"
746         https://bugs.webkit.org/show_bug.cgi?id=193829
747
748         Reviewed by Tim Horton.
749
750         * WebCoreSupport/WebDragClient.mm:
751         (WebDragClient::didConcludeEditDrag):
752         * WebView/WebView.mm:
753         (-[WebView _requestStartDataInteraction:globalPosition:]):
754         (-[WebView _didConcludeEditDrag]):
755         (-[WebView _didConcludeEditDataInteraction]): Deleted.
756         * WebView/WebViewInternal.h:
757
758 2019-01-24  John Wilander  <wilander@apple.com>
759
760         Add Ad Click Attribution as an internal/experimental feature
761         https://bugs.webkit.org/show_bug.cgi?id=193685
762         <rdar://problem/47450399>
763
764         Reviewed by Brent Fulgham.
765
766         * WebView/WebPreferenceKeysPrivate.h:
767         * WebView/WebPreferences.mm:
768         (+[WebPreferences initialize]):
769         (-[WebPreferences adClickAttributionEnabled]):
770         (-[WebPreferences setAdClickAttributionEnabled:]):
771             Added support for experimental ad click attribution.
772         * WebView/WebPreferencesPrivate.h:
773         * WebView/WebView.mm:
774         (-[WebView _preferencesChanged:]):
775
776 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
777
778         Move FileSystem to WTF
779         https://bugs.webkit.org/show_bug.cgi?id=193602
780
781         Reviewed by Yusuke Suzuki.
782
783         * Misc/WebNSFileManagerExtras.mm:
784         * Storage/WebDatabaseProvider.mm:
785         * WebView/WebView.mm:
786
787 2019-01-23  Conrad Shultz  <conrad_shultz@apple.com>
788
789         Fix the Apple Internal build. See <rdar://problem/47491383>.
790
791         Rubber-stamped by Tim Horton.
792
793         * WebCoreSupport/WebFrameLoaderClient.mm:
794
795 2019-01-22  Conrad Shultz  <conrad_shultz@apple.com>
796
797         Clean up USE(WEB_THREAD)
798         https://bugs.webkit.org/show_bug.cgi?id=193698
799
800         Rubber-stamped by Tim Horton.
801
802         * Misc/WebCache.mm:
803         (+[WebCache emptyInMemoryResources]):
804         * WebCoreSupport/WebFrameLoaderClient.mm:
805         (-[WebFramePolicyListener use]):
806         * WebCoreSupport/WebGeolocationClient.mm:
807         (-[WebGeolocationPolicyListener allow]):
808         (-[WebGeolocationPolicyListener deny]):
809         (-[WebGeolocationPolicyListener denyOnlyThisRequest]):
810         * WebView/WebFrame.mm:
811         (-[WebFrame deviceOrientationChanged]):
812         * WebView/WebHTMLView.mm:
813         (hardwareKeyboardAvailabilityChangedCallback):
814         * WebView/WebView.mm:
815         (+[WebView _releaseMemoryNow]):
816         (+[WebView willEnterBackgroundWithCompletionHandler:]):
817         (-[WebView updateLayoutIgnorePendingStyleSheets]):
818         (-[WebView _dispatchUnloadEvent]):
819         (-[WebView _close]):
820         (-[WebView _preferencesChangedNotification:]):
821         (-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
822         (-[WebView goBack]):
823         (-[WebView goForward]):
824         (+[WebView _cacheModelChangedNotification:]):
825         (-[WebView stopLoading:]):
826         (-[WebView stopLoadingAndClear]):
827         (-[WebView reload:]):
828         (WebInstallMemoryPressureHandler):
829
830 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
831
832         Introduce UndoStep::label() and adopt it in WebKitLegacy and WebKit
833         https://bugs.webkit.org/show_bug.cgi?id=193706
834         <rdar://problem/44807048>
835
836         Reviewed by Ryosuke Niwa.
837
838         Use UndoStep::label().
839
840         * WebCoreSupport/WebEditorClient.h:
841         * WebCoreSupport/WebEditorClient.mm:
842         (-[WebUndoStep initWithUndoStep:]):
843         (+[WebUndoStep stepWithUndoStep:]):
844         (WebEditorClient::registerUndoOrRedoStep):
845         (WebEditorClient::registerUndoStep):
846         (WebEditorClient::registerRedoStep):
847
848 2019-01-22  Alex Christensen  <achristensen@webkit.org>
849
850         Move NetworkStorageSession ownership to NetworkProcess
851         https://bugs.webkit.org/show_bug.cgi?id=193580
852
853         Reviewed by Geoff Garen.
854
855         * Misc/WebCache.mm:
856         (+[WebCache clearCachedCredentials]):
857         * Misc/WebDownload.mm:
858         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
859         * Plugins/WebBaseNetscapePluginView.mm:
860         (WebKit::getAuthenticationInfo):
861         * WebCoreSupport/WebFrameNetworkingContext.mm:
862         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
863         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
864         (WebFrameNetworkingContext::storageSession const):
865         * WebView/WebPreferences.mm:
866         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
867         (+[WebPreferences _clearNetworkLoaderSession]):
868         (+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):
869
870 2019-01-22  Daniel Bates  <dabates@apple.com>
871
872         [iOS] Interpret text key commands on keydown and app key commands on keypress
873         https://bugs.webkit.org/show_bug.cgi?id=192897
874         <rdar://problem/46857378>
875
876         Reviewed by Brent Fulgham.
877
878         Adopt SPI to interpret text key commands and app key commands independently on keydown (isCharEvent
879         is false) and keypress (isCharEvent is true), respectively.
880
881         * WebView/WebHTMLView.mm:
882         (-[WebHTMLView _handleEditingKeyEvent:]):
883
884 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
885
886         [css-logical] Implement flow-relative margin, padding and border shorthands
887         https://bugs.webkit.org/show_bug.cgi?id=188697
888
889         Reviewed by Simon Fraser and Antti Koivisto.
890
891         Add CSSLogicalEnabled runtime flag.
892
893         * WebView/WebPreferenceKeysPrivate.h:
894         * WebView/WebPreferences.mm:
895         (+[WebPreferences initialize]):
896         (-[WebPreferences cssLogicalEnabled]):
897         (-[WebPreferences setCSSLogicalEnabled:]):
898         * WebView/WebPreferencesPrivate.h:
899         * WebView/WebView.mm:
900         (-[WebView _preferencesChanged:]):
901
902 2019-01-15  Darin Adler  <darin@apple.com>
903
904         Use references rather than pointers for register/unregister functions, and more
905         https://bugs.webkit.org/show_bug.cgi?id=175028
906
907         Reviewed by Daniel Bates.
908
909         * WebCoreSupport/WebKitFullScreenListener.mm:
910         (-[WebKitFullScreenListener webkitWillEnterFullScreen]): Update for change to the
911         functions in Document; pass a reference.
912         (-[WebKitFullScreenListener webkitDidEnterFullScreen]): Ditto, don't pass the element.
913         (-[WebKitFullScreenListener webkitWillExitFullScreen]): Ditto.
914         (-[WebKitFullScreenListener webkitDidExitFullScreen]): Ditto.
915         * WebView/WebFullScreenController.mm:
916         (-[WebFullScreenController enterFullScreen:]): Ditto.
917         (-[WebFullScreenController finishedEnterFullScreenAnimation:]): Ditto.
918         (-[WebFullScreenController exitFullScreen]): Ditto.
919         (-[WebFullScreenController finishedExitFullScreenAnimation:]): Ditto.
920         * WebView/WebFullScreenController.mm:
921         (-[WebView _commonInitializationWithFrameName:groupName:]): Pass a reference.
922
923 2019-01-12  Dan Bernstein  <mitz@apple.com>
924
925         [Cocoa] Avoid importing directly from subumbrella frameworks
926         https://bugs.webkit.org/show_bug.cgi?id=186016
927         <rdar://problem/40591038>
928
929         Reviewed by Sam Weinig.
930
931         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
932         * Carbon/CarbonWindowAdapter.mm: Ditto.
933         * Carbon/CarbonWindowFrame.m: Ditto.
934         * Carbon/HIViewAdapter.h: Ditto.
935         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
936           OTHER_CFLAGS_COCOA_TOUCH_NO.
937         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
938         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
939         * WebView/WebPDFView.h: Ditto.
940
941 2019-01-20  Antoine Quint  <graouts@apple.com>
942
943         Add a POINTER_EVENTS feature flag
944         https://bugs.webkit.org/show_bug.cgi?id=193577
945         <rdar://problem/47408511>
946
947         Unreviewed. Also enable Pointer Events for iosmac.
948
949         * Configurations/FeatureDefines.xcconfig:
950
951 2019-01-19  Antoine Quint  <graouts@apple.com>
952
953         Add a POINTER_EVENTS feature flag
954         https://bugs.webkit.org/show_bug.cgi?id=193577
955
956         Reviewed by Dean Jackson.
957
958         * Configurations/FeatureDefines.xcconfig:
959
960 2019-01-18  Eric Carlson  <eric.carlson@apple.com>
961
962         Revert r238815, it broke WK1 video fullscreen on Mac
963         https://bugs.webkit.org/show_bug.cgi?id=193586
964         <rdar://problem/47358941>
965
966         Reviewed by Jer Noble.
967
968         * WebView/WebVideoFullscreenController.h: Added.
969         * WebView/WebVideoFullscreenController.mm: Added.
970         (SOFT_LINK_CLASS):
971         (-[WebVideoFullscreenController init]):
972         (-[WebVideoFullscreenController dealloc]):
973         (-[WebVideoFullscreenController fullscreenWindow]):
974         (-[WebVideoFullscreenController windowDidLoad]):
975         (-[WebVideoFullscreenController videoElement]):
976         (-[WebVideoFullscreenController setVideoElement:]):
977         (-[WebVideoFullscreenController clearFadeAnimation]):
978         (-[WebVideoFullscreenController windowDidExitFullscreen]):
979         (-[WebVideoFullscreenController windowDidEnterFullscreen]):
980         (-[WebVideoFullscreenController videoElementRect]):
981         (-[WebVideoFullscreenController applicationDidResignActive:]):
982         (frameExpandedToRatioOfFrame):
983         (createBackgroundFullscreenWindow):
984         (-[WebVideoFullscreenController setupFadeAnimationIfNeededAndFadeIn:]):
985         (-[WebVideoFullscreenController enterFullscreen:]):
986         (-[WebVideoFullscreenController exitFullscreen]):
987         (-[WebVideoFullscreenController applicationDidChangeScreenParameters:]):
988         (-[WebVideoFullscreenController updateMenuAndDockForFullscreen]):
989         (-[WebVideoFullscreenController _requestExit]):
990         (-[WebVideoFullscreenController requestExitFullscreenWithAnimation:]):
991         (-[WebVideoFullscreenController requestExitFullscreen]):
992         (-[WebVideoFullscreenController fadeHUDIn]):
993         (-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):
994         (-[WebVideoFullscreenController rateChanged:]):
995         (-[WebVideoFullscreenWindow initWithContentRect:styleMask:backing:defer:]):
996         (-[WebVideoFullscreenWindow dealloc]):
997         (-[WebVideoFullscreenWindow resignFirstResponder]):
998         (-[WebVideoFullscreenWindow canBecomeKeyWindow]):
999         (-[WebVideoFullscreenWindow mouseDown:]):
1000         (-[WebVideoFullscreenWindow cancelOperation:]):
1001         (-[WebVideoFullscreenWindow animatedResizeDidEnd]):
1002         (-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
1003         (-[WebVideoFullscreenWindow animationDidEnd:]):
1004         (-[WebVideoFullscreenWindow mouseMoved:]):
1005         * WebView/WebVideoFullscreenHUDWindowController.h: Added.
1006         * WebView/WebVideoFullscreenHUDWindowController.mm: Added.
1007         (-[WebVideoFullscreenHUDWindow initWithContentRect:styleMask:backing:defer:]):
1008         (-[WebVideoFullscreenHUDWindow canBecomeKeyWindow]):
1009         (-[WebVideoFullscreenHUDWindow cancelOperation:]):
1010         (-[WebVideoFullscreenHUDWindow center]):
1011         (-[WebVideoFullscreenHUDWindow keyDown:]):
1012         (-[WebVideoFullscreenHUDWindow resignFirstResponder]):
1013         (-[WebVideoFullscreenHUDWindow performKeyEquivalent:]):
1014         (-[WebVideoFullscreenHUDWindowController init]):
1015         (-[WebVideoFullscreenHUDWindowController dealloc]):
1016         (-[WebVideoFullscreenHUDWindowController setArea:]):
1017         (-[WebVideoFullscreenHUDWindowController keyDown:]):
1018         (-[WebVideoFullscreenHUDWindowController delegate]):
1019         (-[WebVideoFullscreenHUDWindowController setDelegate:]):
1020         (-[WebVideoFullscreenHUDWindowController scheduleTimeUpdate]):
1021         (-[WebVideoFullscreenHUDWindowController unscheduleTimeUpdate]):
1022         (-[WebVideoFullscreenHUDWindowController fadeWindowIn]):
1023         (-[WebVideoFullscreenHUDWindowController fadeWindowOut]):
1024         (-[WebVideoFullscreenHUDWindowController closeWindow]):
1025         (createMediaUIControl):
1026         (createControlWithMediaUIControlType):
1027         (createTimeTextField):
1028         (createMediaUIBackgroundView):
1029         (-[WebVideoFullscreenHUDWindowController windowDidLoad]):
1030         (-[WebVideoFullscreenHUDWindowController updateVolume]):
1031         (-[WebVideoFullscreenHUDWindowController updateTime]):
1032         (-[WebVideoFullscreenHUDWindowController endScrubbing]):
1033         (-[WebVideoFullscreenHUDWindowController timelinePositionChanged:]):
1034         (-[WebVideoFullscreenHUDWindowController currentTime]):
1035         (-[WebVideoFullscreenHUDWindowController setCurrentTime:]):
1036         (-[WebVideoFullscreenHUDWindowController duration]):
1037         (-[WebVideoFullscreenHUDWindowController maxVolume]):
1038         (-[WebVideoFullscreenHUDWindowController volumeChanged:]):
1039         (-[WebVideoFullscreenHUDWindowController setVolumeToZero:]):
1040         (-[WebVideoFullscreenHUDWindowController setVolumeToMaximum:]):
1041         (-[WebVideoFullscreenHUDWindowController decrementVolume]):
1042         (-[WebVideoFullscreenHUDWindowController incrementVolume]):
1043         (-[WebVideoFullscreenHUDWindowController volume]):
1044         (-[WebVideoFullscreenHUDWindowController setVolume:]):
1045         (-[WebVideoFullscreenHUDWindowController updatePlayButton]):
1046         (-[WebVideoFullscreenHUDWindowController updateRate]):
1047         (-[WebVideoFullscreenHUDWindowController togglePlaying:]):
1048         (-[WebVideoFullscreenHUDWindowController playing]):
1049         (-[WebVideoFullscreenHUDWindowController setPlaying:]):
1050         (timeToString):
1051         (-[WebVideoFullscreenHUDWindowController remainingTimeText]):
1052         (-[WebVideoFullscreenHUDWindowController elapsedTimeText]):
1053         (-[WebVideoFullscreenHUDWindowController mouseEntered:]):
1054         (-[WebVideoFullscreenHUDWindowController mouseExited:]):
1055         (-[WebVideoFullscreenHUDWindowController rewind:]):
1056         (-[WebVideoFullscreenHUDWindowController fastForward:]):
1057         (-[WebVideoFullscreenHUDWindowController exitFullscreen:]):
1058         (-[WebVideoFullscreenHUDWindowController windowDidExpose:]):
1059         (-[WebVideoFullscreenHUDWindowController windowDidClose:]):
1060         * WebView/WebView.mm:
1061         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1062         (-[WebView _exitVideoFullscreen]):
1063
1064 2019-01-18  Tim Horton  <timothy_horton@apple.com>
1065
1066         Get rid of ADVANCED_SPELL_CHECKING
1067         https://bugs.webkit.org/show_bug.cgi?id=193592
1068
1069         Reviewed by Wenson Hsieh.
1070
1071         * WebCoreSupport/WebEditorClient.mm:
1072         (insertionPointFromCurrentSelection):
1073         (WebEditorClient::checkTextOfParagraph):
1074         (WebEditorClient::getGuessesForWord):
1075         (WebEditorClient::requestCandidatesForSelection):
1076         (WebEditorClient::requestCheckingOfString):
1077         * WebView/WebHTMLView.mm:
1078         (-[WebHTMLView insertText:]):
1079
1080 2019-01-18  Jer Noble  <jer.noble@apple.com>
1081
1082         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1083         https://bugs.webkit.org/show_bug.cgi?id=189553
1084
1085         Reviewed by Tim Horton.
1086
1087         * Configurations/Base.xcconfig:
1088         * Configurations/SDKVariant.xcconfig: Added.
1089         * Configurations/WebKitLegacy.xcconfig:
1090
1091 2019-01-18  David Kilzer  <ddkilzer@apple.com>
1092
1093         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
1094         <https://webkit.org/b/193568>
1095         <rdar://problem/47381130>
1096
1097         Reviewed by Alex Christensen.
1098
1099         * WebView/WebView.mm:
1100         - Remove unused soft-linking macros.
1101         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
1102         (-[WebUITextIndicatorData initWithImage:scale:]):
1103         - Update to use exported PAL functions.
1104
1105 2019-01-17  Truitt Savell  <tsavell@apple.com>
1106
1107         Unreviewed, rolling out r240124.
1108
1109         This commit broke an internal build.
1110
1111         Reverted changeset:
1112
1113         "SDK_VARIANT build destinations should be separate from non-
1114         SDK_VARIANT builds"
1115         https://bugs.webkit.org/show_bug.cgi?id=189553
1116         https://trac.webkit.org/changeset/240124
1117
1118 2019-01-17  Jer Noble  <jer.noble@apple.com>
1119
1120         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
1121         https://bugs.webkit.org/show_bug.cgi?id=189553
1122
1123         Reviewed by Tim Horton.
1124
1125         * Configurations/Base.xcconfig:
1126         * Configurations/SDKVariant.xcconfig: Added.
1127         * Configurations/WebKitLegacy.xcconfig:
1128
1129 2019-01-17  Alex Christensen  <achristensen@webkit.org>
1130
1131         Stop using NetworkStorageSession::storageSession in WebCore
1132         https://bugs.webkit.org/show_bug.cgi?id=193529
1133
1134         Reviewed by Tim Horton.
1135
1136         * Misc/WebCache.mm:
1137         (+[WebCache addImageToCache:forURL:forFrame:]):
1138         * WebView/WebView.mm:
1139         (-[WebView _commonInitializationWithFrameName:groupName:]):
1140         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1141
1142 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1143
1144         Reduce use of NetworkStorageSession::defaultStorageSession in WebCore
1145         https://bugs.webkit.org/show_bug.cgi?id=193368
1146
1147         Reviewed by Geoff Garen.
1148
1149         * Misc/WebCache.mm:
1150         (+[WebCache clearCachedCredentials]):
1151         * Misc/WebDownload.mm:
1152         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
1153         * Plugins/WebBaseNetscapePluginView.mm:
1154         (WebKit::getAuthenticationInfo):
1155
1156 2019-01-15  Alex Christensen  <achristensen@webkit.org>
1157
1158         Stop using CookiesStrategy
1159         https://bugs.webkit.org/show_bug.cgi?id=161106
1160
1161         Reviewed by Don Olmstead and Antti Koivisto.
1162
1163         * Misc/WebCache.mm:
1164         (+[WebCache addImageToCache:forURL:forFrame:]):
1165         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1166         (WebKit::NetscapePluginInstanceProxy::getCookies):
1167         (WebKit::NetscapePluginInstanceProxy::setCookies):
1168         * Plugins/WebNetscapePluginView.mm:
1169         (-[WebNetscapePluginView getVariable:forURL:value:length:]):
1170         (-[WebNetscapePluginView setVariable:forURL:value:length:]):
1171         * WebCoreSupport/WebPlatformStrategies.h:
1172         * WebCoreSupport/WebPlatformStrategies.mm:
1173         (WebPlatformStrategies::createCookiesStrategy): Deleted.
1174         (WebPlatformStrategies::cookiesForDOM): Deleted.
1175         (WebPlatformStrategies::setCookiesFromDOM): Deleted.
1176         (WebPlatformStrategies::cookiesEnabled): Deleted.
1177         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Deleted.
1178         (WebPlatformStrategies::getRawCookies): Deleted.
1179         (WebPlatformStrategies::deleteCookie): Deleted.
1180         * WebView/WebView.mm:
1181         (-[WebView _commonInitializationWithFrameName:groupName:]):
1182         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
1183
1184 2019-01-15  Tim Horton  <timothy_horton@apple.com>
1185
1186         Cannot tab out of WKWebView on macOS
1187         https://bugs.webkit.org/show_bug.cgi?id=161448
1188         <rdar://problem/28100085>
1189
1190         Reviewed by Dean Jackson.
1191
1192         * WebCoreSupport/WebChromeClient.mm:
1193         * WebView/WebView.mm:
1194         Make use of SPI headers.
1195
1196 2019-01-14  Commit Queue  <commit-queue@webkit.org>
1197
1198         Unreviewed, rolling out r239901, r239909, r239910, r239912,
1199         r239913, and r239914.
1200         https://bugs.webkit.org/show_bug.cgi?id=193407
1201
1202         These revisions caused an internal failure (Requested by
1203         Truitt on #webkit).
1204
1205         Reverted changesets:
1206
1207         "[Cocoa] Avoid importing directly from subumbrella frameworks"
1208         https://bugs.webkit.org/show_bug.cgi?id=186016
1209         https://trac.webkit.org/changeset/239901
1210
1211         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
1212         https://trac.webkit.org/changeset/239909
1213
1214         "Tried to fix the build."
1215         https://trac.webkit.org/changeset/239910
1216
1217         "Fixed iOS builds after r239910."
1218         https://trac.webkit.org/changeset/239912
1219
1220         "More build fixing."
1221         https://trac.webkit.org/changeset/239913
1222
1223         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
1224         https://trac.webkit.org/changeset/239914
1225
1226 2019-01-14  Mark Lam  <mark.lam@apple.com>
1227
1228         Re-enable ability to build --cloop builds.
1229         https://bugs.webkit.org/show_bug.cgi?id=192955
1230         <rdar://problem/46882363>
1231
1232         Reviewed by Saam barati and Keith Miller.
1233
1234         * Configurations/FeatureDefines.xcconfig:
1235
1236 2019-01-13  Dan Bernstein  <mitz@apple.com>
1237
1238         Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901.
1239
1240         Patch by Keith Rollin.
1241
1242         * WebView/PDFViewSPI.h:
1243
1244 2019-01-12  Timothy Hatcher  <timothy@apple.com>
1245
1246         Have prefers-color-scheme: light always match on macOS versions before Mojave.
1247         https://bugs.webkit.org/show_bug.cgi?id=191655
1248         rdar://problem/46074680
1249
1250         Reviewed by Megan Gardner.
1251
1252         * Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
1253         * WebView/WebView.mm:
1254         (-[WebView _effectiveAppearanceIsDark]):
1255
1256 2019-01-12  Dan Bernstein  <mitz@apple.com>
1257
1258         [Cocoa] Avoid importing directly from subumbrella frameworks
1259         https://bugs.webkit.org/show_bug.cgi?id=186016
1260         <rdar://problem/40591038>
1261
1262         Reviewed by Sam Weinig.
1263
1264         * Carbon/CarbonWindowAdapter.h: Import Carbon.h instead of HIToolbox headers.
1265         * Carbon/CarbonWindowAdapter.mm: Ditto.
1266         * Carbon/CarbonWindowFrame.m: Ditto.
1267         * Carbon/HIViewAdapter.h: Ditto.
1268         * Configurations/WebKitLegacy.xcconfig: Removed -iframework options from
1269           OTHER_CFLAGS_COCOA_TOUCH_NO.
1270         * Plugins/WebNetscapePluginEventHandlerCarbon.mm: Import Carbon.h instead of CarbonEvents.h.
1271         * WebView/WebPDFDocumentExtras.mm: Import Quartz.h instead of a PDFKit header.
1272         * WebView/WebPDFView.h: Ditto.
1273
1274 2019-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1275
1276         Enable visual viewport API by default
1277         https://bugs.webkit.org/show_bug.cgi?id=193376
1278
1279         Reviewed by Simon Fraser.
1280
1281         * WebView/WebPreferences.mm:
1282         (+[WebPreferences initialize]):
1283
1284 2019-01-11  John Wilander  <wilander@apple.com>
1285
1286         Compile out Web API Statistics Collection
1287         https://bugs.webkit.org/show_bug.cgi?id=193370
1288         <rdar://problem/45388584>
1289
1290         Reviewed by Brent Fulgham.
1291
1292         * Configurations/FeatureDefines.xcconfig:
1293             Defined ENABLE_WEB_API_STATISTICS, off by default.
1294
1295 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1296
1297         Stop using NetworkStorageSession in WebProcess
1298         https://bugs.webkit.org/show_bug.cgi?id=193236
1299
1300         Reviewed by Don Olmstead.
1301
1302         * WebCoreSupport/WebFrameNetworkingContext.h:
1303         * WebCoreSupport/WebFrameNetworkingContext.mm:
1304         (WebFrameNetworkingContext::storageSession const):
1305         * WebCoreSupport/WebPlatformStrategies.h:
1306         * WebCoreSupport/WebPlatformStrategies.mm:
1307         (WebPlatformStrategies::cookiesForDOM):
1308         (WebPlatformStrategies::setCookiesFromDOM):
1309         (WebPlatformStrategies::cookiesEnabled):
1310         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1311         (WebPlatformStrategies::getRawCookies):
1312         (WebPlatformStrategies::deleteCookie):
1313         * WebView/WebView.mm:
1314         (-[WebView _cachedResponseForURL:]):
1315         (-[WebView _clearCredentials]):
1316
1317 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1318
1319         Unreviewed, rolling out r239727.
1320
1321         Broke API tests
1322
1323         Reverted changeset:
1324
1325         "Stop using NetworkStorageSession in WebProcess"
1326         https://bugs.webkit.org/show_bug.cgi?id=193236
1327         https://trac.webkit.org/changeset/239727
1328
1329 2019-01-08  Alex Christensen  <achristensen@webkit.org>
1330
1331         Stop using NetworkStorageSession in WebProcess
1332         https://bugs.webkit.org/show_bug.cgi?id=193236
1333
1334         Reviewed by Don Olmstead.
1335
1336         * WebCoreSupport/WebFrameNetworkingContext.h:
1337         * WebCoreSupport/WebFrameNetworkingContext.mm:
1338         (WebFrameNetworkingContext::storageSession const):
1339         * WebView/WebView.mm:
1340         (-[WebView _cachedResponseForURL:]):
1341         (-[WebView _clearCredentials]):
1342
1343 2019-01-07  David Kilzer  <ddkilzer@apple.com>
1344
1345         Prefer RetainPtr<NSObject> to RetainPtr<NSObject *>
1346         <https://webkit.org/b/193056>
1347
1348         Reviewed by Alex Christensen.
1349
1350         * Plugins/Hosted/NetscapePluginHostProxy.h:
1351         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
1352         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1353         (WebKit::NetscapePluginInstanceProxy::enumerate):
1354         (WebKit::NetscapePluginInstanceProxy::marshalValue):
1355         (WebKit::NetscapePluginInstanceProxy::marshalValues):
1356         (WebKit::NetscapePluginInstanceProxy::demarshalValue):
1357         (WebKit::NetscapePluginInstanceProxy::demarshalValues):
1358         * Plugins/Hosted/ProxyInstance.mm:
1359         (WebKit::ProxyInstance::invoke):
1360         * WebCoreSupport/WebGeolocationClient.mm:
1361         * WebView/WebDataSource.mm:
1362         (-[WebDataSource _receivedData:]):
1363         * WebView/WebView.mm:
1364         (-[WebView _cachedResponseForURL:]):
1365         - Remove '*' from RetainPtr<> type.
1366
1367 2019-01-04  Alex Christensen  <achristensen@webkit.org>
1368
1369         Progress towards fixing Mac CMake build
1370         https://bugs.webkit.org/show_bug.cgi?id=193105
1371
1372         Reviewed by Don Olmstead.
1373
1374         * WebKitPrefix.h:
1375
1376 2019-01-04  Joseph Pecoraro  <pecoraro@apple.com>
1377
1378         Web Inspector: Use save sheet instead of dialog where possible
1379         https://bugs.webkit.org/show_bug.cgi?id=193160
1380         <rdar://problem/37399759>
1381
1382         Reviewed by Devin Rousso.
1383
1384         * WebCoreSupport/WebInspectorClient.mm:
1385         (WebInspectorFrontendClient::save):
1386
1387 2019-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1388
1389         [Cocoa] Merge WebEditCommandProxy::nameForEditAction and undoNameForEditAction into a single function
1390         https://bugs.webkit.org/show_bug.cgi?id=193129
1391
1392         Reviewed by Tim Horton.
1393
1394         Remove undoNameForEditAction and use WebCore::nameForUndoRedo instead.
1395
1396         * WebCoreSupport/WebEditorClient.mm:
1397         (WebEditorClient::registerUndoOrRedoStep):
1398         (undoNameForEditAction): Deleted.
1399
1400 2019-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1401
1402         Add support for using the current text selection as the find string on iOS
1403         https://bugs.webkit.org/show_bug.cgi?id=193034
1404         <rdar://problem/45138739>
1405
1406         Reviewed by Tim Horton.
1407
1408         Add a method stub for WebKitLegacy.
1409
1410         * WebCoreSupport/WebEditorClient.h:
1411
1412 2019-01-01  Jeff Miller  <jeffm@apple.com>
1413
1414         Update user-visible copyright strings to include 2019
1415         https://bugs.webkit.org/show_bug.cgi?id=192811
1416
1417         Reviewed by Mark Lam.
1418
1419         * Info.plist:
1420
1421 2018-12-20  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
1422
1423         Use Ref<> as much as possible
1424         https://bugs.webkit.org/show_bug.cgi?id=192808
1425
1426         Reviewed by Alex Christensen.
1427
1428         * DOM/DOM.mm:
1429         (-[DOMNode getPreviewSnapshotImage:andRects:]):
1430         * Plugins/Hosted/NetscapePluginHostManager.mm:
1431         (WebKit::NetscapePluginHostManager::instantiatePlugin):
1432         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1433         (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
1434         (WebKit::NetscapePluginInstanceProxy::loadRequest):
1435         * Plugins/WebNetscapePluginView.mm:
1436         (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
1437         (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1438         * WebCoreSupport/WebContextMenuClient.mm:
1439         (WebContextMenuClient::imageForCurrentSharingServicePickerItem):
1440         * WebCoreSupport/WebFrameLoaderClient.mm:
1441         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1442         * WebView/WebFrame.mm:
1443         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1444         * WebView/WebHTMLView.mm:
1445         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1446         * WebView/WebView.mm:
1447         (+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
1448         (+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
1449
1450 2018-12-21  Benjamin Poulain  <benjamin@webkit.org>
1451
1452         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1453         https://bugs.webkit.org/show_bug.cgi?id=192821
1454
1455         Reviewed by Chris Dumez.
1456
1457         When a window becomes occluded, the window server informs the application.
1458         This should be used to suspend any work that is not visible by the user.
1459
1460         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1461         In some cases, that lead to performance impact (see radar).
1462
1463         This patch adds an observer for the occlusion notification. I tried to stick
1464         with the same names used by WebKit2.
1465
1466         * WebView/WebView.mm:
1467         (-[WebView _isViewVisible]):
1468         (-[WebView addWindowObserversForWindow:]):
1469         (-[WebView removeWindowObservers]):
1470         (-[WebView _windowDidChangeOcclusionState:]):
1471
1472 2018-12-20  Jiewen Tan  <jiewen_tan@apple.com>
1473
1474         [WebAuthN] Add a runtime flag for local authenticator
1475         https://bugs.webkit.org/show_bug.cgi?id=192792
1476         <rdar://problem/46798738>
1477
1478         Reviewed by Brent Fulgham.
1479
1480         * WebView/WebPreferenceKeysPrivate.h:
1481         * WebView/WebPreferences.mm:
1482         (+[WebPreferences initialize]):
1483         (-[WebPreferences webAuthenticationEnabled]): Deleted.
1484         (-[WebPreferences setWebAuthenticationEnabled:]): Deleted.
1485         * WebView/WebPreferencesPrivate.h:
1486         * WebView/WebView.mm:
1487         (-[WebView _preferencesChanged:]):
1488
1489 2018-12-20  Chris Dumez  <cdumez@apple.com>
1490
1491         Use Optional::valueOr() instead of Optional::value_or()
1492         https://bugs.webkit.org/show_bug.cgi?id=192933
1493
1494         Reviewed by Geoffrey Garen.
1495
1496         * WebCoreSupport/WebSecurityOrigin.mm:
1497         (-[WebSecurityOrigin port]):
1498
1499 2018-12-20  Ryan Haddad  <ryanhaddad@apple.com>
1500
1501         Unreviewed, rolling out r239417.
1502
1503         Introduced two API test failures on macOS.
1504
1505         Reverted changeset:
1506
1507         "<rdar://problem/46194315> macOS: WebKit1 does not handle
1508         occlusion changes"
1509         https://bugs.webkit.org/show_bug.cgi?id=192821
1510         https://trac.webkit.org/changeset/239417
1511
1512 2018-12-20  Brent Fulgham  <bfulgham@apple.com>
1513
1514         WKWebView default UA doesn't freeze the build number
1515         https://bugs.webkit.org/show_bug.cgi?id=192809
1516         <rdar://problem/44687185>
1517
1518         Reviewed by Andy Estes.
1519
1520         Always reports the frozen build number.
1521
1522         * WebView/WebView.mm:
1523         (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
1524         actual build number through this method call.
1525         (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
1526
1527 2018-12-19  Chris Dumez  <cdumez@apple.com>
1528
1529         wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
1530         https://bugs.webkit.org/show_bug.cgi?id=192728
1531         <rdar://problem/46746779>
1532
1533         Reviewed by Geoff Garen.
1534
1535         * DOM/*:
1536         * Plugins/*:
1537         * WebCoreSupport/*:
1538         * WebView/*:
1539
1540 2018-12-19  Benjamin Poulain  <benjamin@webkit.org>
1541
1542         <rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
1543         https://bugs.webkit.org/show_bug.cgi?id=192821
1544
1545         Reviewed by Chris Dumez.
1546
1547         When a window becomes occluded, the window server informs the application.
1548         This should be used to suspend any work that is not visible by the user.
1549
1550         WebKit2 handles it just fine, but WebKit1 did not handle the notification.
1551         In some cases, that lead to performance impact (see radar).
1552
1553         This patch adds an observer for the occlusion notification. I tried to stick
1554         with the same names used by WebKit2.
1555
1556         * WebView/WebView.mm:
1557         (-[WebView _isViewVisible]):
1558         (-[WebView addWindowObserversForWindow:]):
1559         (-[WebView removeWindowObservers]):
1560         (-[WebView _windowDidChangeOcclusionState:]):
1561
1562 2018-12-19  Megan Gardner  <megan_gardner@apple.com>
1563
1564         Allow clients to set the navigator platform
1565         https://bugs.webkit.org/show_bug.cgi?id=192735
1566
1567         Reviewed by Tim Horton.
1568
1569         Add stubs to fill out the added functionality in FrameLoaderClient.
1570
1571         * WebCoreSupport/WebFrameLoaderClient.h:
1572         * WebCoreSupport/WebFrameLoaderClient.mm:
1573         (WebFrameLoaderClient::navigatorPlatform):
1574
1575 2018-12-17  Ryosuke Niwa  <rniwa@webkit.org>
1576
1577         offsetLeft and offsetParent should adjust across shadow boundaries
1578         https://bugs.webkit.org/show_bug.cgi?id=157437
1579         <rdar://problem/26154021>
1580
1581         Reviewed by Simon Fraser.
1582
1583         Use *forBindings variants of offsetLeft, offsetTop, and offsetParent.
1584
1585         * DOM/DOMElement.mm:
1586         (-[DOMElement offsetLeft]):
1587         (-[DOMElement offsetTop]):
1588         (-[DOMElement offsetParent]):
1589
1590 2018-12-17  Zalan Bujtas  <zalan@apple.com>
1591
1592         Unreviewed build fix.
1593
1594         * WebView/WebFrame.mm:
1595         (-[WebFrame getDictationResultRanges:andMetadatas:]):
1596
1597 2018-12-15  Darin Adler  <darin@apple.com>
1598
1599         Use warning-ignoring macros more consistently and simply
1600         https://bugs.webkit.org/show_bug.cgi?id=192743
1601
1602         Reviewed by Mark Lam.
1603
1604         * DOM/DOM.mm: Use IGNORE_WARNINGS_BEGIN/END instead of
1605         IGNORE_CLANG_WARNINGS_BEGIN since there is no need to accomodate non-clang
1606         compilers in Objective-C++ code.
1607
1608         * WebCoreSupport/WebAlternativeTextClient.h: Use IGNORE_WARNINGS_BEGIN/END
1609         instead of IGNORE_CLANG_WARNINGS_BEGIN/END because there is no need to
1610         accomodate non-clang compilers here. Also use #pragma once, add a missing
1611         "explicit" and fix conditionals.
1612
1613 2018-12-12  Ryosuke Niwa  <rniwa@webkit.org>
1614
1615         Make TextInputController.legacyAttributedString take DOM nodes and offsets
1616         https://bugs.webkit.org/show_bug.cgi?id=192653
1617
1618         Reviewed by Wenson Hsieh.
1619
1620         * WebView/WebHTMLView.mm:
1621         (-[WebHTMLView _legacyAttributedStringFrom:offset:to:offset:]):
1622
1623 2018-12-11  Justin Michaud  <justin_michaud@apple.com>
1624
1625         Implement feature flag for CSS Typed OM
1626         https://bugs.webkit.org/show_bug.cgi?id=192610
1627
1628         Reviewed by Ryosuke Niwa.
1629
1630         * Configurations/FeatureDefines.xcconfig:
1631
1632 2018-12-11  Tim Horton  <timothy_horton@apple.com>
1633
1634         WebCore shouldn't have a Objective-C class named NSCursor
1635         https://bugs.webkit.org/show_bug.cgi?id=192602
1636         <rdar://problem/46615532>
1637
1638         Reviewed by Wenson Hsieh.
1639
1640         * WebView/WebFrameView.mm:
1641         (-[WebFrameView keyDown:keyDown:]):
1642         * WebView/WebHTMLView.mm:
1643         (-[WebHTMLView keyDown:]):
1644         (-[WebHTMLView performKeyEquivalent:]):
1645         Only use NSCursor on macOS.
1646
1647 2018-12-10  Don Olmstead  <don.olmstead@sony.com>
1648
1649         Move ENABLE_RESOURCE_LOAD_STATISTICS to FeatureDefines.xcconfig
1650         https://bugs.webkit.org/show_bug.cgi?id=192573
1651
1652         Reviewed by Simon Fraser.
1653
1654         * Configurations/FeatureDefines.xcconfig:
1655
1656 2018-12-10  Antti Koivisto  <antti@apple.com>
1657
1658         Rename "forced style recalc" to "full style rebuild"
1659         https://bugs.webkit.org/show_bug.cgi?id=192572
1660
1661         Reviewed by Zalan Bujtas.
1662
1663         * WebView/WebHTMLView.mm:
1664         (-[WebHTMLView setNeedsToApplyStyles:]):
1665
1666 2018-12-10  Darin Adler  <darin@apple.com>
1667
1668         [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
1669         https://bugs.webkit.org/show_bug.cgi?id=192533
1670         rdar://problem/45732710
1671
1672         Reviewed by Anders Carlsson.
1673
1674         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1675         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
1676
1677 2018-12-10  Darin Adler  <darin@apple.com>
1678
1679         [macOS] Use mach_port_mod_refs instead of mach_port_destroy
1680         https://bugs.webkit.org/show_bug.cgi?id=192532
1681         rdar://problem/45731047
1682
1683         Reviewed by Chris Dumez.
1684
1685         * Plugins/Hosted/NetscapePluginHostManager.mm:
1686         (WebKit::NetscapePluginHostManager::hostForPlugin): Use mach_port_mod_refs.
1687         * Plugins/Hosted/NetscapePluginHostProxy.mm:
1688         (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy): Ditto.
1689
1690 2018-12-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1691
1692         Turn WritingDirection into an enum class
1693         https://bugs.webkit.org/show_bug.cgi?id=192401
1694         Work towards <rdar://problem/42075638>
1695
1696         Reviewed by Dan Bernstein.
1697
1698         Change WritingDirection from an enum to an enum class. No change in behavior.
1699
1700         * WebView/WebHTMLView.mm:
1701         (-[WebHTMLView toggleBaseWritingDirection:]):
1702         (-[WebHTMLView changeBaseWritingDirection:]):
1703         (-[WebHTMLView _changeBaseWritingDirectionTo:]):
1704
1705 2018-12-03  Alex Christensen  <achristensen@webkit.org>
1706
1707         Add WKWebProcessPlugInLoadDelegate SPI willStartProvisionalLoadForFrame with a completion handler
1708         https://bugs.webkit.org/show_bug.cgi?id=192272
1709
1710         Reviewed by Brady Eidson.
1711
1712         * WebCoreSupport/WebFrameLoaderClient.h:
1713         * WebCoreSupport/WebFrameLoaderClient.mm:
1714         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1715
1716 2018-12-03  Jer Noble  <jer.noble@apple.com>
1717
1718         Get rid of old, dead Mac video fullscreen code.
1719         https://bugs.webkit.org/show_bug.cgi?id=192315
1720
1721         Reviewed by Eric Carlson.
1722
1723         The Mac-only WebVideoFullscreenController and WebVideoFullscreenHUDWindowController depend upon QTKit, which
1724         is no longer supported in the Mac port.
1725
1726         * WebView/WebVideoFullscreenController.h: Removed.
1727         * WebView/WebVideoFullscreenController.mm: Removed.
1728         * WebView/WebVideoFullscreenHUDWindowController.h: Removed.
1729         * WebView/WebVideoFullscreenHUDWindowController.mm: Removed.
1730         * WebView/WebView.mm:
1731         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
1732         (-[WebView _exitVideoFullscreen]):
1733
1734 2018-12-03  Daniel Bates  <dabates@apple.com>
1735
1736         [iOS] Do not handle key events that are key commands
1737         https://bugs.webkit.org/show_bug.cgi?id=191608
1738         <rdar://problem/46046013>
1739
1740         Reviewed by Ryosuke Niwa.
1741
1742         A key down event may be associated with a key command. If it is then we want to execute the
1743         key command instead of inserting or deleting text. We need to ask UIKit to handle the current
1744         event as a key command to find out.
1745
1746         * WebView/WebHTMLView.mm:
1747         (-[WebHTMLView _handleEditingKeyEvent:]):
1748
1749 2018-12-02  Zalan Bujtas  <zalan@apple.com>
1750
1751         Add a runtime feature flag for LayoutFormattingContext.
1752         https://bugs.webkit.org/show_bug.cgi?id=192280
1753
1754         Reviewed by Simon Fraser.
1755
1756         * Configurations/FeatureDefines.xcconfig:
1757
1758 2018-11-30  Alex Christensen  <achristensen@webkit.org>
1759
1760         Move URL from WebCore to WTF
1761         https://bugs.webkit.org/show_bug.cgi?id=190234
1762
1763         Reviewed by Keith Miller.
1764
1765         * DOM/DOMAttr.mm:
1766         * DOM/DOMBlob.mm:
1767         * DOM/DOMCSSCharsetRule.mm:
1768         * DOM/DOMCSSImportRule.mm:
1769         * DOM/DOMCSSMediaRule.mm:
1770         * DOM/DOMCSSPageRule.mm:
1771         * DOM/DOMCSSPrimitiveValue.mm:
1772         * DOM/DOMCSSRule.mm:
1773         * DOM/DOMCSSStyleDeclaration.mm:
1774         * DOM/DOMCSSStyleRule.mm:
1775         * DOM/DOMCSSStyleSheet.mm:
1776         * DOM/DOMCSSValue.mm:
1777         * DOM/DOMCharacterData.mm:
1778         * DOM/DOMCounter.mm:
1779         * DOM/DOMDocument.mm:
1780         * DOM/DOMDocumentFragment.mm:
1781         * DOM/DOMDocumentType.mm:
1782         * DOM/DOMEvent.mm:
1783         * DOM/DOMFile.mm:
1784         * DOM/DOMHTMLAnchorElement.mm:
1785         * DOM/DOMHTMLAppletElement.mm:
1786         * DOM/DOMHTMLAreaElement.mm:
1787         * DOM/DOMHTMLBRElement.mm:
1788         * DOM/DOMHTMLBaseElement.mm:
1789         * DOM/DOMHTMLBaseFontElement.mm:
1790         * DOM/DOMHTMLBodyElement.mm:
1791         * DOM/DOMHTMLButtonElement.mm:
1792         * DOM/DOMHTMLCanvasElement.mm:
1793         * DOM/DOMHTMLCollection.mm:
1794         * DOM/DOMHTMLDivElement.mm:
1795         * DOM/DOMHTMLDocument.mm:
1796         * DOM/DOMHTMLElement.mm:
1797         * DOM/DOMHTMLEmbedElement.mm:
1798         * DOM/DOMHTMLFieldSetElement.mm:
1799         * DOM/DOMHTMLFontElement.mm:
1800         * DOM/DOMHTMLFormElement.mm:
1801         * DOM/DOMHTMLFrameElement.mm:
1802         * DOM/DOMHTMLFrameSetElement.mm:
1803         * DOM/DOMHTMLHRElement.mm:
1804         * DOM/DOMHTMLHeadElement.mm:
1805         * DOM/DOMHTMLHeadingElement.mm:
1806         * DOM/DOMHTMLHtmlElement.mm:
1807         * DOM/DOMHTMLIFrameElement.mm:
1808         * DOM/DOMHTMLImageElement.mm:
1809         * DOM/DOMHTMLInputElement.mm:
1810         * DOM/DOMHTMLLIElement.mm:
1811         * DOM/DOMHTMLLabelElement.mm:
1812         * DOM/DOMHTMLLegendElement.mm:
1813         * DOM/DOMHTMLLinkElement.mm:
1814         * DOM/DOMHTMLMapElement.mm:
1815         * DOM/DOMHTMLMarqueeElement.mm:
1816         * DOM/DOMHTMLMediaElement.mm:
1817         * DOM/DOMHTMLMetaElement.mm:
1818         * DOM/DOMHTMLModElement.mm:
1819         * DOM/DOMHTMLOListElement.mm:
1820         * DOM/DOMHTMLObjectElement.mm:
1821         * DOM/DOMHTMLOptGroupElement.mm:
1822         * DOM/DOMHTMLOptionElement.mm:
1823         * DOM/DOMHTMLOptionsCollection.mm:
1824         * DOM/DOMHTMLParagraphElement.mm:
1825         * DOM/DOMHTMLParamElement.mm:
1826         * DOM/DOMHTMLQuoteElement.mm:
1827         * DOM/DOMHTMLScriptElement.mm:
1828         * DOM/DOMHTMLSelectElement.mm:
1829         * DOM/DOMHTMLStyleElement.mm:
1830         * DOM/DOMHTMLTableCaptionElement.mm:
1831         * DOM/DOMHTMLTableCellElement.mm:
1832         * DOM/DOMHTMLTableColElement.mm:
1833         * DOM/DOMHTMLTableElement.mm:
1834         * DOM/DOMHTMLTableRowElement.mm:
1835         * DOM/DOMHTMLTableSectionElement.mm:
1836         * DOM/DOMHTMLTitleElement.mm:
1837         * DOM/DOMHTMLUListElement.mm:
1838         * DOM/DOMHTMLVideoElement.mm:
1839         * DOM/DOMKeyboardEvent.mm:
1840         * DOM/DOMMediaList.mm:
1841         * DOM/DOMMouseEvent.mm:
1842         * DOM/DOMMutationEvent.mm:
1843         * DOM/DOMNamedNodeMap.mm:
1844         * DOM/DOMProcessingInstruction.mm:
1845         * DOM/DOMRange.mm:
1846         * DOM/DOMStyleSheet.mm:
1847         * DOM/DOMText.mm:
1848         * DOM/DOMTextEvent.mm:
1849         * DOM/DOMTokenList.mm:
1850         * DOM/DOMUIEvent.mm:
1851         * DOM/DOMXPathResult.mm:
1852         * History/WebHistoryItem.mm:
1853         * Misc/WebNSURLExtras.mm:
1854         (-[NSURL _web_userVisibleString]):
1855         (-[NSURL _web_URLByRemovingUserInfo]):
1856         (-[NSURL _web_dataForURLComponentType:]):
1857         (-[NSURL _web_schemeData]):
1858         (-[NSURL _web_hostData]):
1859         * Misc/WebUserContentURLPattern.mm:
1860         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1861         * Plugins/WebNetscapePluginStream.h:
1862         (WebNetscapePluginStream::setRequestURL):
1863         * WebCoreSupport/WebChromeClient.h:
1864         * WebCoreSupport/WebChromeClient.mm:
1865         (WebChromeClient::signedPublicKeyAndChallengeString const):
1866         * WebCoreSupport/WebContextMenuClient.h:
1867         * WebCoreSupport/WebContextMenuClient.mm:
1868         * WebCoreSupport/WebDragClient.h:
1869         * WebCoreSupport/WebFrameLoaderClient.h:
1870         * WebCoreSupport/WebFrameLoaderClient.mm:
1871         (WebFrameLoaderClient::updateGlobalHistory):
1872         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1873         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1874         (WebPaymentCoordinatorClient::showPaymentUI):
1875         * WebCoreSupport/WebPlatformStrategies.h:
1876         * WebCoreSupport/WebPlatformStrategies.mm:
1877         (WebPlatformStrategies::readURLFromPasteboard):
1878         * WebCoreSupport/WebPluginInfoProvider.h:
1879         * WebCoreSupport/WebPluginInfoProvider.mm:
1880         (WebPluginInfoProvider::webVisiblePluginInfo):
1881         * WebCoreSupport/WebSecurityOrigin.mm:
1882         * WebCoreSupport/WebVisitedLinkStore.h:
1883         * WebView/WebDataSource.mm:
1884         * WebView/WebFrame.mm:
1885         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
1886         * WebView/WebImmediateActionController.mm:
1887         (-[WebImmediateActionController _defaultAnimationController]):
1888         * WebView/WebPDFView.mm:
1889         * WebView/WebScriptDebugger.mm:
1890         * WebView/WebViewInternal.h:
1891
1892 2018-11-30  Don Olmstead  <don.olmstead@sony.com>
1893
1894         Rename ENABLE_SUBTLE_CRYPTO to ENABLE_WEB_CRYPTO
1895         https://bugs.webkit.org/show_bug.cgi?id=192197
1896
1897         Reviewed by Jiewen Tan.
1898
1899         * Configurations/FeatureDefines.xcconfig:
1900         * WebCoreSupport/WebChromeClient.h:
1901         * WebCoreSupport/WebChromeClient.mm:
1902
1903 2018-11-28  Alex Christensen  <achristensen@webkit.org>
1904
1905         Remove dead code from an earlier attempt at implementing safe browsing
1906         https://bugs.webkit.org/show_bug.cgi?id=192067
1907
1908         Reviewed by Chris Dumez.
1909
1910         * WebCoreSupport/WebFrameLoaderClient.h:
1911         * WebCoreSupport/WebFrameLoaderClient.mm:
1912         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1913
1914 2018-11-27  Mark Lam  <mark.lam@apple.com>
1915
1916         ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
1917         https://bugs.webkit.org/show_bug.cgi?id=192055
1918         <rdar://problem/46288783>
1919
1920         Reviewed by Saam Barati.
1921
1922         * Configurations/FeatureDefines.xcconfig:
1923
1924 2018-11-25  Tim Horton  <timothy_horton@apple.com>
1925
1926         Make it possible to insert editable images with a gesture
1927         https://bugs.webkit.org/show_bug.cgi?id=191937
1928
1929         Reviewed by Wenson Hsieh.
1930
1931         * WebCoreSupport/WebEditorClient.mm:
1932         (undoNameForEditAction):
1933         Add a undo name.
1934
1935 2018-11-24  Wenson Hsieh  <wenson_hsieh@apple.com>
1936
1937         [Cocoa] Fix a few localizable string descriptions in WebEditCommandProxy.cpp and WebEditorClient.mm
1938         https://bugs.webkit.org/show_bug.cgi?id=191945
1939
1940         Reviewed by Anders Carlsson.
1941
1942         * WebCoreSupport/WebEditorClient.mm:
1943         (undoNameForEditAction):
1944
1945 2018-11-23  Wenson Hsieh  <wenson_hsieh@apple.com>
1946
1947         Enable drag and drop support for iOSMac
1948         https://bugs.webkit.org/show_bug.cgi?id=191818
1949         <rdar://problem/43907454>
1950
1951         Reviewed by Dean Jackson.
1952
1953         * Configurations/FeatureDefines.xcconfig:
1954
1955 2018-11-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1956
1957         Address post-review feedback after r238438
1958         https://bugs.webkit.org/show_bug.cgi?id=191913
1959
1960         Reviewed by Ryosuke Niwa.
1961
1962         * WebView/WebFrame.mm:
1963         (-[WebFrame setSelectedDOMRange:affinity:closeTyping:]):
1964         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
1965         * WebView/WebView.mm:
1966         (-[WebView setSelectedDOMRange:affinity:]):
1967
1968 2018-11-19  Joseph Pecoraro  <pecoraro@apple.com>
1969
1970         Web Inspector: "Reload Web Inspector" button no longer partially works
1971         https://bugs.webkit.org/show_bug.cgi?id=191773
1972         <rdar://problem/46139932>
1973
1974         Reviewed by Devin Rousso.
1975
1976         * WebCoreSupport/WebInspectorClient.h:
1977         * WebCoreSupport/WebInspectorClient.mm:
1978         (WebInspectorFrontendClient::reopen):
1979
1980 2018-11-17  Devin Rousso  <drousso@apple.com>
1981
1982         Web Inspector: Network: add button to show system certificate dialog
1983         https://bugs.webkit.org/show_bug.cgi?id=191458
1984         <rdar://problem/45977019>
1985
1986         Reviewed by Joseph Pecoraro.
1987
1988         * WebCoreSupport/WebInspectorClient.h:
1989         * WebCoreSupport/WebInspectorClient.mm:
1990         (WebInspectorFrontendClient::showCertificate): Added.
1991
1992         * Configurations/WebKitLegacy.xcconfig:
1993
1994 2018-11-15  Truitt Savell  <tsavell@apple.com>
1995
1996         Unreviewed, rolling out r238244.
1997
1998         Caused High Sierra test runs to fail early with 50 crashes and
1999         casued 25 API failures.
2000
2001         Reverted changeset:
2002
2003         "[css-logical] Implement flow-relative margin, padding and
2004         border shorthands"
2005         https://bugs.webkit.org/show_bug.cgi?id=188697
2006         https://trac.webkit.org/changeset/238244
2007
2008 2018-11-15  Oriol Brufau  <obrufau@igalia.com>
2009
2010         [css-logical] Implement flow-relative margin, padding and border shorthands
2011         https://bugs.webkit.org/show_bug.cgi?id=188697
2012
2013         Reviewed by Simon Fraser and Antti Koivisto.
2014
2015         Add CSSLogicalEnabled runtime flag.
2016
2017         * WebView/WebPreferenceKeysPrivate.h:
2018         * WebView/WebPreferences.mm:
2019         (+[WebPreferences initialize]):
2020         (-[WebPreferences cssLogicalEnabled]):
2021         (-[WebPreferences setCSSLogicalEnabled:]):
2022         * WebView/WebPreferencesPrivate.h:
2023         * WebView/WebView.mm:
2024         (-[WebView _preferencesChanged:]):
2025
2026 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2027
2028         Web Inspector: Pass Inspector::FrontendChannel as a reference connect/disconnect methods
2029         https://bugs.webkit.org/show_bug.cgi?id=191612
2030
2031         Reviewed by Matt Baker.
2032
2033         * WebCoreSupport/WebInspectorClient.mm:
2034         (-[WebInspectorWindowController destroyInspectorView]):
2035
2036 2018-11-14  Joseph Pecoraro  <pecoraro@apple.com>
2037
2038         Web Inspector: Keep Web Inspector window alive across process swaps (PSON) (Remote Inspector)
2039         https://bugs.webkit.org/show_bug.cgi?id=191494
2040         <rdar://problem/45469854>
2041
2042         Reviewed by Devin Rousso.
2043
2044         * WebCoreSupport/WebInspectorClient.h:
2045         WebKitLegacy will still have remote inspection of the Page directly.
2046
2047 2018-11-12  Simon Fraser  <simon.fraser@apple.com>
2048
2049         Make compositing updates incremental
2050         https://bugs.webkit.org/show_bug.cgi?id=90342
2051
2052         Reviewed by Antti Koivisto.
2053
2054         Fix spelling error.
2055
2056         * WebView/WebView.mm:
2057         (-[WebView _setMediaLayer:forPluginView:]):
2058
2059 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2060
2061         Implement a new edit command to change the enclosing list type
2062         https://bugs.webkit.org/show_bug.cgi?id=191487
2063         <rdar://problem/45955922>
2064
2065         Reviewed by Ryosuke Niwa.
2066
2067         Add undo/redo edit action strings for ConvertToOrderedList and ConvertToUnorderedList.
2068
2069         * WebCoreSupport/WebEditorClient.mm:
2070         (undoNameForEditAction):
2071
2072 2018-11-11  Daniel Bates  <dabates@apple.com>
2073
2074         [iOS] Draw caps lock indicator in password fields
2075         https://bugs.webkit.org/show_bug.cgi?id=190565
2076         <rdar://problem/45262343>
2077
2078         Reviewed by Dean Jackson.
2079
2080         Update the caps lock state when a hardware keyboard is attached or detached.
2081
2082         * WebView/WebHTMLView.mm:
2083         (hardwareKeyboardAvailabilityChangedCallback): Added.
2084         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2085         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2086
2087 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
2088
2089         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2090         https://bugs.webkit.org/show_bug.cgi?id=191492
2091
2092         Reviewed by Alex Christensen.
2093
2094         * Carbon/HIWebView.mm:
2095         * Misc/WebNSFileManagerExtras.mm:
2096         * Misc/WebNSURLExtras.mm:
2097         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2098         * Plugins/WebBasePluginPackage.mm:
2099         * Plugins/WebPluginContainerCheck.mm:
2100         * WebCoreSupport/WebCachedFramePlatformData.h:
2101         * WebCoreSupport/WebDeviceOrientationClient.mm:
2102         * WebView/WebDelegateImplementationCaching.mm:
2103         * WebView/WebHTMLView.mm:
2104         * WebView/WebPDFRepresentation.mm:
2105         * WebView/WebPolicyDelegate.mm:
2106         * WebView/WebView.mm:
2107
2108 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
2109
2110         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
2111         https://bugs.webkit.org/show_bug.cgi?id=191492
2112
2113         Reviewed by Alex Christensen.
2114
2115         * Carbon/HIWebView.mm:
2116         (UpdateCommandStatus):
2117         * Misc/WebNSFileManagerExtras.mm:
2118         * Misc/WebNSURLExtras.mm:
2119         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2120         * Plugins/WebBasePluginPackage.mm:
2121         * Plugins/WebPluginContainerCheck.mm:
2122         (-[WebPluginContainerCheck _continueWithPolicy:]):
2123         * WebCoreSupport/WebCachedFramePlatformData.h:
2124         (WebCachedFramePlatformData::clear):
2125         * WebCoreSupport/WebDeviceOrientationClient.mm:
2126         (WebDeviceOrientationClient::getProvider const):
2127         * WebView/WebDelegateImplementationCaching.mm:
2128         (CallDelegate):
2129         (CallDelegateReturningBoolean):
2130         (CallResourceLoadDelegateReturningBoolean):
2131         (CallFormDelegate):
2132         (CallFormDelegateReturningBoolean):
2133         * WebView/WebHTMLView.mm:
2134         * WebView/WebPDFRepresentation.mm:
2135         * WebView/WebPolicyDelegate.mm:
2136         (-[WebPolicyDecisionListener _usePolicy:]):
2137         * WebView/WebView.mm:
2138
2139 2018-11-09  Ryan Haddad  <ryanhaddad@apple.com>
2140
2141         Unreviewed, rolling out r238047.
2142
2143         Introduced layout test failures on iOS simulator.
2144
2145         Reverted changeset:
2146
2147         "[iOS] Draw caps lock indicator in password fields"
2148         https://bugs.webkit.org/show_bug.cgi?id=190565
2149         https://trac.webkit.org/changeset/238047
2150
2151 2018-11-09  Antti Koivisto  <antti@apple.com>
2152
2153         Use OptionSet for layout milestones
2154         https://bugs.webkit.org/show_bug.cgi?id=191470
2155
2156         Reviewed by Dean Jackson.
2157
2158         * WebCoreSupport/WebFrameLoaderClient.h:
2159         * WebCoreSupport/WebFrameLoaderClient.mm:
2160         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2161         * WebView/WebView.mm:
2162         (coreLayoutMilestones):
2163         (kitLayoutMilestones):
2164         (-[WebView _cacheFrameLoadDelegateImplementations]):
2165         * WebView/WebViewInternal.h:
2166
2167 2018-11-09  Daniel Bates  <dabates@apple.com>
2168
2169         [iOS] Draw caps lock indicator in password fields
2170         https://bugs.webkit.org/show_bug.cgi?id=190565
2171         <rdar://problem/45262343>
2172
2173         Reviewed by Dean Jackson.
2174
2175         Update the caps lock state when a hardware keyboard is attached or detached.
2176
2177         * WebView/WebHTMLView.mm:
2178         (hardwareKeyboardAvailabilityChangedCallback): Added.
2179         (-[WebHTMLView initWithFrame:]): Register for hardware keyboard availability changed notifications.
2180         (-[WebHTMLView dealloc]): Unregister from hardware keyboard availability changed notifications.
2181
2182 2018-11-09  Daniel Bates  <dabates@apple.com>
2183
2184         [iOS] Pressing forward delete key in text field does nothing and we should not invoke an editor
2185         action when forward delete is pressed outside a text field
2186         https://bugs.webkit.org/show_bug.cgi?id=190566
2187         <rdar://problem/45262367>
2188
2189         Reviewed by Wenson Hsieh.
2190
2191         Remove dead code. UIKit ceased sending us a character string with 0xF728 for the forward delete
2192         key many years ago. We will need to fix up iOS Legacy WebKit support for the forward delete key
2193         in UIKit. We may revist this decision once <rdar://problem/45772078> is fixed.
2194
2195         * WebView/WebHTMLView.mm:
2196         (-[WebHTMLView _handleEditingKeyEvent:]):
2197
2198 2018-11-08  Megan Gardner  <megan_gardner@apple.com>
2199
2200         Adopt Reveal Framework to replace Lookup
2201         https://bugs.webkit.org/show_bug.cgi?id=191097
2202         <rdar://problem/45924508>
2203
2204         Reviewed by Tim Horton.
2205
2206         Pass in what it needed to clear the textIndicators. This is better than
2207         the current notification structure.
2208
2209         * WebView/WebView.mm:
2210         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2211         (-[WebView _prepareForDictionaryLookup]):
2212
2213 2018-11-06  Justin Fan  <justin_fan@apple.com>
2214
2215         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
2216         https://bugs.webkit.org/show_bug.cgi?id=191291
2217
2218         Reviewed by Myles Maxfield.
2219
2220         Properly disable WEBGPU on all non-Metal platforms for now.
2221
2222         * Configurations/FeatureDefines.xcconfig:
2223
2224 2018-11-02  Daniel Bates  <dabates@apple.com>
2225
2226         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
2227         https://bugs.webkit.org/show_bug.cgi?id=190487
2228
2229         Reviewed by Tim Horton.
2230
2231         Having Legacy WebKit return NO if the editing event represents a modifier flags change to
2232         allow the default handling.
2233
2234         * WebView/WebHTMLView.mm:
2235         (-[WebHTMLView _handleEditingKeyEvent:]):
2236
2237 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
2238
2239         Add a storage limit for IndexedDB
2240         https://bugs.webkit.org/show_bug.cgi?id=190598
2241         <rdar://problem/44654715>
2242
2243         Reviewed by Chris Dumez.
2244
2245         * Storage/WebDatabaseManager.mm:
2246         (-[WebDatabaseManager setIDBPerOriginQuota:]):
2247         * Storage/WebDatabaseManagerPrivate.h:
2248
2249 2018-10-31  Antti Koivisto  <antti@apple.com>
2250
2251         Remove LayerFlushScheduler
2252         https://bugs.webkit.org/show_bug.cgi?id=191103
2253
2254         Reviewed by Anders Carlsson.
2255
2256         Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
2257         all the virtual cruft.
2258
2259         * WebView/WebViewData.h:
2260         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
2261         (): Deleted.
2262         * WebView/WebViewData.mm:
2263         (currentRunLoop):
2264         (WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
2265         (WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
2266         (WebViewLayerFlushScheduler::schedule):
2267         (WebViewLayerFlushScheduler::invalidate):
2268         (WebViewLayerFlushScheduler::layerFlushCallback):
2269
2270 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2271
2272         Enable InstallAPI for iOS unconditionally
2273         https://bugs.webkit.org/show_bug.cgi?id=191043
2274         rdar://problem/32728423
2275
2276         Reviewed by Dan Bernstein.
2277
2278         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2279         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2280         shouldn't be processed by InstallAPI.
2281         * MigrateHeaders.make: Removed an obsolete workaround.
2282         * Misc/NSURLDownloadSPI.h: Added.
2283         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2284
2285 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2286
2287         Clean up some obsolete MAX_ALLOWED macros
2288         https://bugs.webkit.org/show_bug.cgi?id=190916
2289
2290         Reviewed by Tim Horton.
2291
2292         * WebView/WebHTMLView.mm:
2293         (-[WebHTMLView pressureChangeWithEvent:]):
2294         * WebView/WebPDFView.h:
2295
2296 2018-10-30  Commit Queue  <commit-queue@webkit.org>
2297
2298         Unreviewed, rolling out r237600 and r237604.
2299         https://bugs.webkit.org/show_bug.cgi?id=191086
2300
2301         Breaks internal iOS builds (Requested by ryanhadd_ on
2302         #webkit).
2303
2304         Reverted changesets:
2305
2306         "Enable InstallAPI for iOS unconditionally"
2307         https://bugs.webkit.org/show_bug.cgi?id=191043
2308         https://trac.webkit.org/changeset/237600
2309
2310         "Build fix attempt after enabling InstallAPI for iOS."
2311         https://bugs.webkit.org/show_bug.cgi?id=191043
2312         https://trac.webkit.org/changeset/237604
2313
2314 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
2315
2316         Enable InstallAPI for iOS unconditionally
2317         https://bugs.webkit.org/show_bug.cgi?id=191043
2318         rdar://problem/32728423
2319
2320         Reviewed by Dan Bernstein.
2321
2322         * Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an
2323         excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
2324         shouldn't be processed by InstallAPI.
2325         * MigrateHeaders.make: Removed an obsolete workaround.
2326         * Misc/NSURLDownloadSPI.h: Added.
2327         * Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.
2328
2329 2018-10-29  Tim Horton  <timothy_horton@apple.com>
2330
2331         Modernize WebKit nibs and lprojs for localization's sake
2332         https://bugs.webkit.org/show_bug.cgi?id=190911
2333         <rdar://problem/45349466>
2334
2335         Reviewed by Dan Bernstein.
2336
2337         * Misc/WebNSControlExtras.m:
2338         (-[NSControl sizeToFitAndAdjustWindowHeight]):
2339         NSWindow and its contents are both in the same scale space these days; avoid
2340         double-applying the scale factor, or you can't see the prompt.
2341
2342         * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Removed.
2343         * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib: Removed.
2344         * Panels/en.lproj/WebAuthenticationPanel.xib: Added.
2345         NIB->XIB
2346
2347 2018-10-25  Antoine Quint  <graouts@apple.com>
2348
2349         [Web Animations] Turn Web Animations CSS Integration off by default
2350         https://bugs.webkit.org/show_bug.cgi?id=190901
2351
2352         Reviewed by Dean Jackson.
2353
2354         * WebView/WebPreferences.mm:
2355         (+[WebPreferences initialize]):
2356
2357 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
2358
2359         Clean up some obsolete macOS version guards
2360         https://bugs.webkit.org/show_bug.cgi?id=190887
2361
2362         Reviewed by Dan Bernstein.
2363
2364         * Misc/WebNSPasteboardExtras.mm:
2365         (+[NSPasteboard _web_dragTypesForURL]):
2366         * WebCoreSupport/PopupMenuMac.mm:
2367         (PopupMenuMac::show):
2368         * WebCoreSupport/WebEditorClient.h:
2369         * WebCoreSupport/WebEditorClient.mm:
2370         (WebEditorClient::respondToChangedSelection):
2371         * WebView/WebPDFView.mm:
2372         (-[WebPDFView _clipViewForPDFDocumentView]):
2373
2374 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
2375
2376         Turn on Conic Gradients
2377         https://bugs.webkit.org/show_bug.cgi?id=190810
2378
2379         Reviewed by Tim Horton.
2380
2381         * Configurations/FeatureDefines.xcconfig:
2382
2383 2018-10-24  Said Abou-Hallawa  <sabouhallawa@apple.com>
2384
2385         Cleanup: MIMETypeRegistry functions
2386         https://bugs.webkit.org/show_bug.cgi?id=190838
2387
2388         Reviewed by Simon Fraser.
2389
2390         * Misc/WebNSPasteboardExtras.mm:
2391         (-[NSPasteboard _web_writePromisedRTFDFromArchive:containsImage:]):
2392         Replace isSupportedImageResourceMIMEType() by isSupportedImageMIMEType()
2393         because they were identical.
2394
2395         * WebView/WebHTMLRepresentation.mm:
2396         (+[WebHTMLRepresentation supportedMediaMIMETypes]):
2397         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
2398         (+[WebHTMLRepresentation supportedImageMIMETypes]):
2399         (+[WebHTMLRepresentation unsupportedTextMIMETypes]):
2400         * WebView/WebView.mm:
2401         (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
2402         (+[WebView _registerViewClass:representationClass:forURLScheme:]):
2403         (+[WebView registerViewClass:representationClass:forMIMEType:]):
2404
2405 2018-10-23  David Kilzer  <ddkilzer@apple.com>
2406
2407         Fix false positive leaks when using custom -init methods that don't start with -init
2408         <https://webkit.org/b/190818>
2409         <rdar://problem/45476042>
2410
2411         Reviewed by Dan Bernstein.
2412
2413         * Misc/WebKitErrors.m: Move `descriptions` static global so that
2414         it is accessible by both categories.
2415         (-[NSError _webkit_initWithDomain:code:URL:]): Declare new
2416         NSError (WebKitInternal) category.  Add attribute to make this
2417         behave like an -init method.
2418         (-[NSError _webkit_initWithDomain:code:URL:]): Move into new
2419         NSError (WebKitInternal) category.  Modernize method.  Replace
2420         constant NSString with `NSURLErrorFailingURLStringErrorKey`.
2421
2422 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2423
2424         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2425         https://bugs.webkit.org/show_bug.cgi?id=190729
2426
2427         Reviewed by Tim Horton.
2428
2429         * DOM/DOM.mm:
2430         (-[DOMNode boundingBox]):
2431         * DOM/DOMElement.mm:
2432         * DOM/DOMHTML.mm:
2433         * DOM/DOMInternal.mm:
2434         * DOM/DOMUIKitExtensions.mm:
2435         * DOM/WebDOMOperations.mm:
2436         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
2437         * DefaultDelegates/WebDefaultEditingDelegate.m:
2438         * DefaultDelegates/WebDefaultPolicyDelegate.m:
2439         (-[WebDefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2440         * DefaultDelegates/WebDefaultUIDelegate.h:
2441         * DefaultDelegates/WebDefaultUIDelegate.mm:
2442         (-[WebDefaultUIDelegate webViewClose:]):
2443         (-[WebDefaultUIDelegate webViewFocus:]):
2444         (-[WebDefaultUIDelegate webViewUnfocus:]):
2445         (-[WebDefaultUIDelegate webViewIsResizable:]):
2446         (-[WebDefaultUIDelegate webView:setResizable:]):
2447         (-[WebDefaultUIDelegate webView:setFrame:]):
2448         (-[WebDefaultUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2449         * History/BackForwardList.h:
2450         * History/BackForwardList.mm:
2451         * History/WebBackForwardList.mm:
2452         (+[WebBackForwardList initialize]):
2453         (bumperCarBackForwardHackNeeded):
2454         * History/WebHistory.mm:
2455         (-[WebHistoryPrivate addItem:discardDuplicate:]):
2456         (-[WebHistory _sendNotification:entries:]):
2457         (-[WebHistory loadFromURL:error:]):
2458         (-[WebHistory saveToURL:error:]):
2459         * History/WebHistoryItem.mm:
2460         (WKNotifyHistoryItemChanged):
2461         (+[WebHistoryItem initialize]):
2462         (-[WebHistoryItem initFromDictionaryRepresentation:]):
2463         * History/WebURLsWithTitles.m:
2464         * Misc/WebCache.mm:
2465         (+[WebCache initialize]):
2466         * Misc/WebDownload.mm:
2467         (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
2468         * Misc/WebElementDictionary.mm:
2469         (+[WebElementDictionary initialize]):
2470         (+[WebElementDictionary initializeLookupTable]):
2471         * Misc/WebIconDatabase.mm:
2472         * Misc/WebKitNSStringExtras.mm:
2473         (+[NSString _webkit_localCacheDirectoryWithBundleIdentifier:]):
2474         * Misc/WebKitVersionChecks.h:
2475         * Misc/WebKitVersionChecks.mm:
2476         (WebKitLinkedOnOrAfter):
2477         (WebKitLinkTimeVersion):
2478         * Misc/WebLocalizableStrings.mm:
2479         * Misc/WebNSControlExtras.h:
2480         * Misc/WebNSControlExtras.m:
2481         * Misc/WebNSEventExtras.m:
2482         * Misc/WebNSFileManagerExtras.mm:
2483         * Misc/WebNSImageExtras.h:
2484         * Misc/WebNSImageExtras.m:
2485         * Misc/WebNSPasteboardExtras.mm:
2486         * Misc/WebNSPrintOperationExtras.h:
2487         * Misc/WebNSPrintOperationExtras.m:
2488         * Misc/WebNSViewExtras.m:
2489         * Misc/WebNSWindowExtras.m:
2490         * Panels/WebAuthenticationPanel.h:
2491         * Panels/WebAuthenticationPanel.m:
2492         * Panels/WebPanelAuthenticationHandler.m:
2493         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
2494         (+[WebHostedNetscapePluginView initialize]):
2495         * Plugins/WebBasePluginPackage.h:
2496         * Plugins/WebBasePluginPackage.mm:
2497         * Plugins/WebJavaPlugIn.h:
2498         * Plugins/WebPluginContainerCheck.mm:
2499         * Plugins/WebPluginController.h:
2500         * Plugins/WebPluginController.mm:
2501         (-[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
2502         (-[WebPluginController addPlugin:]):
2503         (-[WebPluginController destroyPlugin:]):
2504         (-[WebPluginController destroyAllPlugins]):
2505         * Plugins/WebPluginDatabase.mm:
2506         (+[WebPluginDatabase _defaultPlugInPaths]):
2507         * Plugins/WebPluginPackage.mm:
2508         (-[WebPluginPackage initWithPath:]):
2509         * Storage/WebDatabaseManager.mm:
2510         (-[WebDatabaseManager deleteAllDatabases]):
2511         * Storage/WebDatabaseManagerClient.h:
2512         * Storage/WebDatabaseManagerClient.mm:
2513         (WebDatabaseManagerClient::WebDatabaseManagerClient):
2514         (WebDatabaseManagerClient::~WebDatabaseManagerClient):
2515         * Storage/WebStorageManager.mm:
2516         (-[WebStorageManager deleteAllOrigins]):
2517         (WebKitInitializeStorageIfNecessary):
2518         * WebCoreSupport/WebAlternativeTextClient.h:
2519         * WebCoreSupport/WebApplicationCache.mm:
2520         (applicationCacheBundleIdentifier):
2521         * WebCoreSupport/WebChromeClient.h:
2522         * WebCoreSupport/WebChromeClient.mm:
2523         (WebChromeClient::setWindowRect):
2524         (WebChromeClient::windowRect):
2525         (WebChromeClient::takeFocus):
2526         (WebChromeClient::addMessageToConsole):
2527         (WebChromeClient::enableSuddenTermination):
2528         (WebChromeClient::disableSuddenTermination):
2529         (WebChromeClient::createPopupMenu const):
2530         (WebChromeClient::createSearchPopupMenu const):
2531         (WebChromeClient::shouldPaintEntireContents const):
2532         (WebChromeClient::supportsVideoFullscreen):
2533         (WebChromeClient::supportsFullScreenForElement):
2534         (WebChromeClient::enterFullScreenForElement):
2535         (WebChromeClient::exitFullScreenForElement):
2536         * WebCoreSupport/WebContextMenuClient.mm:
2537         * WebCoreSupport/WebDragClient.mm:
2538         * WebCoreSupport/WebEditorClient.h:
2539         * WebCoreSupport/WebEditorClient.mm:
2540         (+[WebUndoStep initialize]):
2541         (updateFontPanel):
2542         (WebEditorClient::didBeginEditing):
2543         (WebEditorClient::respondToChangedContents):
2544         (WebEditorClient::respondToChangedSelection):
2545         (WebEditorClient::canceledComposition):
2546         (WebEditorClient::didEndEditing):
2547         (WebEditorClient::didWriteSelectionToPasteboard):
2548         (attributesForAttributedStringConversion):
2549         (WebEditorClient::setInsertionPasteboard):
2550         (WebEditorClient::registerUndoOrRedoStep):
2551         (WebEditorClient::handleKeyboardEvent):
2552         (WebEditorClient::handleInputMethodKeydown):
2553         (WebEditorClient::textDidChangeInTextField):
2554         (WebEditorClient::requestCheckingOfString):
2555         * WebCoreSupport/WebFrameLoaderClient.h:
2556         * WebCoreSupport/WebFrameLoaderClient.mm:
2557         (WebFrameLoaderClient::detachedFromParent2):
2558         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
2559         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
2560         (WebFrameLoaderClient::dispatchWillSendRequest):
2561         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2562         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2563         (WebFrameLoaderClient::willCacheResponse const):
2564         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2565         (WebFrameLoaderClient::dispatchDidFinishLoading):
2566         (WebFrameLoaderClient::dispatchDidFailLoading):
2567         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2568         (WebFrameLoaderClient::dispatchWillClose):
2569         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2570         (WebFrameLoaderClient::dispatchDidCommitLoad):
2571         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2572         (WebFrameLoaderClient::dispatchDidFailLoad):
2573         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
2574         (WebFrameLoaderClient::dispatchDidFinishLoad):
2575         (WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
2576         (WebFrameLoaderClient::willChangeTitle):
2577         (WebFrameLoaderClient::didChangeTitle):
2578         (WebFrameLoaderClient::didReplaceMultipartContent):
2579         (WebFrameLoaderClient::updateGlobalHistory):
2580         (WebFrameLoaderClient::saveViewStateToItem):
2581         (WebFrameLoaderClient::restoreViewState):
2582         (WebFrameLoaderClient::provisionalLoadStarted):
2583         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2584         (WebFrameLoaderClient::setTitle):
2585         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
2586         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
2587         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2588         (WebFrameLoaderClient::didRestoreFromPageCache):
2589         (WebFrameLoaderClient::actionDictionary const):
2590         (WebFrameLoaderClient::createPlugin):
2591         (WebFrameLoaderClient::getLoadDecisionForIcons):
2592         (WebFrameLoaderClient::finishedLoadingIcon):
2593         (+[WebFramePolicyListener initialize]):
2594         * WebCoreSupport/WebFrameNetworkingContext.mm:
2595         * WebCoreSupport/WebGeolocationClient.h:
2596         * WebCoreSupport/WebGeolocationClient.mm:
2597         (WebGeolocationClient::requestPermission):
2598         * WebCoreSupport/WebInspectorClient.h:
2599         * WebCoreSupport/WebJavaScriptTextInputPanel.m:
2600         * WebCoreSupport/WebNotificationClient.mm:
2601         * WebCoreSupport/WebOpenPanelResultListener.mm:
2602         * WebCoreSupport/WebPlatformStrategies.h:
2603         * WebCoreSupport/WebPlatformStrategies.mm:
2604         * WebCoreSupport/WebProgressTrackerClient.h:
2605         * WebCoreSupport/WebProgressTrackerClient.mm:
2606         (WebProgressTrackerClient::progressStarted):
2607         (WebProgressTrackerClient::progressEstimateChanged):
2608         (WebProgressTrackerClient::progressFinished):
2609         * WebCoreSupport/WebSecurityOrigin.mm:
2610         * WebInspector/WebNodeHighlight.h:
2611         * WebInspector/WebNodeHighlight.mm:
2612         (-[WebNodeHighlight initWithTargetView:inspectorController:]):
2613         (-[WebNodeHighlight dealloc]):
2614         (-[WebNodeHighlight attach]):
2615         * WebInspector/WebNodeHighlightView.h:
2616         * WebInspector/WebNodeHighlightView.mm:
2617         (-[WebNodeHighlightView initWithWebNodeHighlight:]):
2618         (-[WebNodeHighlightView dealloc]):
2619         * WebInspector/WebNodeHighlighter.mm:
2620         (-[WebNodeHighlighter highlight]):
2621         * WebView/WebArchive.mm:
2622         (+[WebArchivePrivate initialize]):
2623         * WebView/WebClipView.h:
2624         * WebView/WebDataSource.mm:
2625         (WebDataSourcePrivate::WebDataSourcePrivate):
2626         (+[WebDataSource initialize]):
2627         (+[WebDataSource _repTypesAllowImageTypeOmission:]):
2628         (-[WebDataSource _makeRepresentation]):
2629         * WebView/WebDelegateImplementationCaching.h:
2630         * WebView/WebDelegateImplementationCaching.mm:
2631         (CallDelegate):
2632         (CallDelegateReturningFloat):
2633         (CallDelegateReturningBoolean):
2634         (CallUIDelegate):
2635         (CallUIDelegateReturningFloat):
2636         (CallUIDelegateReturningBoolean):
2637         (CallFrameLoadDelegate):
2638         (CallFrameLoadDelegateReturningBoolean):
2639         (CallResourceLoadDelegate):
2640         (CallScriptDebugDelegate):
2641         (CallFormDelegate):
2642         (CallFormDelegateReturningBoolean):
2643         * WebView/WebDeviceOrientation.mm:
2644         (-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
2645         * WebView/WebDocumentInternal.h:
2646         * WebView/WebDocumentLoaderMac.mm:
2647         (needsDataLoadWorkaround):
2648         * WebView/WebDynamicScrollBarsViewInternal.h:
2649         * WebView/WebFormDelegate.m:
2650         * WebView/WebFrame.mm:
2651         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
2652         (-[WebFrame _unmarkAllMisspellings]):
2653         (-[WebFrame _paintBehaviorForDestinationContext:]):
2654         (-[WebFrame _drawRect:contentsOnly:]):
2655         (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
2656         (-[WebFrame _scrollDOMRangeToVisible:]):
2657         (-[WebFrame _bodyBackgroundColor]):
2658         (-[WebFrame accessibilityRoot]):
2659         (needsMicrosoftMessengerDOMDocumentWorkaround):
2660         * WebView/WebFrameInternal.h:
2661         * WebView/WebFrameView.mm:
2662         (-[WebFrameView _setDocumentView:]):
2663         (+[WebFrameView _viewTypesAllowImageTypeOmission:]):
2664         (-[WebFrameView _viewClassForMIMEType:]):
2665         (-[WebFrameView initWithFrame:]):
2666         (-[WebFrameView drawRect:]):
2667         (-[WebFrameView _firstResponderIsFormControl]):
2668         (-[WebFrameView keyDown:keyDown:]):
2669         (-[WebFrameView _isScrollable]):
2670         * WebView/WebFullScreenController.h:
2671         * WebView/WebFullScreenController.mm:
2672         * WebView/WebHTMLRepresentation.mm:
2673         * WebView/WebHTMLView.mm:
2674         (-[WebHTMLView hitTest:]):
2675         (-[WebHTMLView initWithFrame:]):
2676         (-[WebHTMLView dealloc]):
2677         (-[WebHTMLView addSubview:]):
2678         (-[WebHTMLView mouseDown:]):
2679         (-[WebHTMLView mouseUp:]):
2680         (-[WebHTMLView resignFirstResponder]):
2681         (-[WebHTMLView accessibilityHitTest:]):
2682         (-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):
2683         * WebView/WebHTMLViewInternal.h:
2684         * WebView/WebIndicateLayer.h:
2685         * WebView/WebIndicateLayer.mm:
2686         * WebView/WebMediaPlaybackTargetPicker.h:
2687         * WebView/WebMediaPlaybackTargetPicker.mm:
2688         * WebView/WebPDFDocumentExtras.h:
2689         * WebView/WebPDFDocumentExtras.mm:
2690         * WebView/WebPDFRepresentation.h:
2691         * WebView/WebPDFRepresentation.mm:
2692         * WebView/WebPDFView.h:
2693         * WebView/WebPreferences.mm:
2694         (cacheModelForMainBundle):
2695         (WebPreferencesPrivate::WebPreferencesPrivate):
2696         (-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
2697         (-[WebPreferences encodeWithCoder:]):
2698         (+[WebPreferences standardPreferences]):
2699         (+[WebPreferences initialize]):
2700         (-[WebPreferences _valueForKey:]):
2701         (-[WebPreferences _setStringValue:forKey:]):
2702         (-[WebPreferences _setIntegerValue:forKey:]):
2703         (-[WebPreferences _setUnsignedIntValue:forKey:]):
2704         (-[WebPreferences _setFloatValue:forKey:]):
2705         (-[WebPreferences _setBoolValue:forKey:]):
2706         (-[WebPreferences _setLongLongValue:forKey:]):
2707         (-[WebPreferences _setUnsignedLongLongValue:forKey:]):
2708         (-[WebPreferences _postCacheModelChangedNotification]):
2709         (-[WebPreferences _postPreferencesChangedNotification]):
2710         (+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
2711         (-[WebPreferences setStorageBlockingPolicy:]):
2712         * WebView/WebResource.mm:
2713         (+[WebResourcePrivate initialize]):
2714         * WebView/WebTextCompletionController.h:
2715         * WebView/WebTextIterator.mm:
2716         (+[WebTextIteratorPrivate initialize]):
2717         * WebView/WebView.mm:
2718         (shouldEnableLoadDeferring):
2719         (shouldRestrictWindowFocus):
2720         (shouldRespectPriorityInCSSAttributeSetters):
2721         (shouldUseLegacyBackgroundSizeShorthandBehavior):
2722         (shouldAllowPictureInPictureMediaPlayback):
2723         (shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):
2724         (shouldAllowWindowOpenWithoutUserGesture):
2725         (shouldConvertInvalidURLsToBlank):
2726         (shouldRequireUserGestureToLoadVideo):
2727         (-[WebView _commonInitializationWithFrameName:groupName:]):
2728         (+[WebView _viewClass:andRepresentationClass:forMIMEType:allowingPlugins:]):
2729         (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
2730         (-[WebView _closePluginDatabases]):
2731         (-[WebView _closeWithFastTeardown]):
2732         (-[WebView _close]):
2733         (+[WebView _MIMETypeForFile:]):
2734         (-[WebView setShowingInspectorIndication:]):
2735         (-[WebView _setFormDelegate:]):
2736         (-[WebView _needsPreHTML5ParserQuirks]):
2737         (-[WebView _preferencesChangedNotification:]):
2738         (-[WebView _preferencesChanged:]):
2739         (-[WebView _cacheResourceLoadDelegateImplementations]):
2740         (-[WebView _cacheFrameLoadDelegateImplementations]):
2741         (-[WebView _policyDelegateForwarder]):
2742         (-[WebView _UIDelegateForwarder]):
2743         (-[WebView _editingDelegateForwarder]):
2744         (-[WebView _updateActiveState]):
2745         (-[_WebSafeForwarder forwardInvocation:]):
2746         (+[WebView initialize]):
2747         (-[WebView _pluginForMIMEType:]):
2748         (-[WebView _pluginForExtension:]):
2749         (-[WebView _isMIMETypeRegisteredAsPlugin:]):
2750         (+[WebView canShowMIMETypeAsHTML:]):
2751         (-[WebView _initWithArguments:]):
2752         (-[WebView initWithFrame:frameName:groupName:]):
2753         (-[WebView dealloc]):
2754         (-[WebView close]):
2755         (-[WebView viewDidMoveToWindow]):
2756         (-[WebView setUIDelegate:]):
2757         (-[WebView setResourceLoadDelegate:]):
2758         (-[WebView setPolicyDelegate:]):
2759         (-[WebView setFrameLoadDelegate:]):
2760         (-[WebView goBack]):
2761         (-[WebView goForward]):
2762         (-[WebView stringByEvaluatingJavaScriptFromString:]):
2763         (-[WebView setHostWindow:]):
2764         (-[WebView becomeFirstResponder]):
2765         (+[WebView _cacheModelChangedNotification:]):
2766         (-[WebView _frameViewAtWindowPoint:]):
2767         (+[WebView _preflightSpellCheckerNow:]):
2768         (+[WebView _preflightSpellChecker]):
2769         (-[WebView canGoBack]):
2770         (-[WebView canGoForward]):
2771         (-[WebView stopLoading:]):
2772         (-[WebView reload:]):
2773         (-[WebView setMainFrameDocumentReady:]):
2774         (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2775         (-[WebView setContinuousSpellCheckingEnabled:]):
2776         (-[WebView undoManager]):
2777         (-[WebView isAutomaticQuoteSubstitutionEnabled]):
2778         (-[WebView isAutomaticLinkDetectionEnabled]):
2779         (-[WebView isAutomaticDashSubstitutionEnabled]):
2780         (-[WebView isAutomaticTextReplacementEnabled]):
2781         (-[WebView isAutomaticSpellingCorrectionEnabled]):
2782         (+[WebView _setCacheModel:]):
2783         (-[WebView _retrieveKeyboardUIModeFromPreferences:]):
2784         (-[WebView _keyboardUIMode]):
2785         (LayerFlushController::flushLayers):
2786         (-[WebView _scheduleCompositingLayerFlush]):
2787         (-[WebView _enterVideoFullscreenForVideoElement:mode:]):
2788         (-[WebView fullScreenPlaceholderView]):
2789         (WebInstallMemoryPressureHandler):
2790         * WebView/WebViewData.h:
2791         * WebView/WebViewData.mm:
2792         (+[WebViewPrivate initialize]):
2793         (-[WebViewPrivate init]):
2794         (-[WebViewPrivate dealloc]):
2795         * WebView/WebViewInternal.h:
2796
2797 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2798
2799         Clean up FrameLoader two-state enums
2800         https://bugs.webkit.org/show_bug.cgi?id=190731
2801
2802         Reviewed by Chris Dumez.
2803
2804         * WebCoreSupport/WebFrameLoaderClient.h:
2805         * WebCoreSupport/WebFrameLoaderClient.mm:
2806         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2807
2808 2018-10-18  Alex Christensen  <achristensen@webkit.org>
2809
2810         Unreviewed, rolling out r237137.
2811
2812         SPI is actually used
2813
2814         Reverted changeset:
2815
2816         "Remove unused WebFrame._loadType"
2817         https://bugs.webkit.org/show_bug.cgi?id=190583
2818         https://trac.webkit.org/changeset/237137
2819
2820 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2821
2822         Enable the datalist element by default on iOS and macOS
2823         https://bugs.webkit.org/show_bug.cgi?id=190594
2824         <rdar://problem/45281159>
2825
2826         Reviewed by Ryosuke Niwa and Tim Horton.
2827
2828         * Configurations/FeatureDefines.xcconfig:
2829
2830 2018-10-17  Alex Christensen  <achristensen@webkit.org>
2831
2832         BackForwardClient needs to be able to support UIProcess-only back/forward lists
2833         https://bugs.webkit.org/show_bug.cgi?id=190675
2834
2835         Reviewed by Chris Dumez.
2836
2837         * History/BackForwardList.h:
2838         * History/BackForwardList.mm:
2839         (BackForwardList::backItem):
2840         (BackForwardList::currentItem):
2841         (BackForwardList::forwardItem):
2842         (BackForwardList::backListCount const):
2843         (BackForwardList::forwardListCount const):
2844         (BackForwardList::itemAtIndex):
2845         * History/WebBackForwardList.mm:
2846         (-[WebBackForwardList backItem]):
2847         (-[WebBackForwardList currentItem]):
2848         (-[WebBackForwardList forwardItem]):
2849         (-[WebBackForwardList itemAtIndex:]):
2850
2851 2018-10-16  Timothy Hatcher  <timothy@apple.com>
2852
2853         Add <meta name="supported-color-schemes"> to control what color schemes the page supports
2854         https://bugs.webkit.org/show_bug.cgi?id=190526
2855         rdar://problem/45230140
2856
2857         Reviewed by Dean Jackson.
2858
2859         * WebCoreSupport/WebEditorClient.mm:
2860         (_WebCreateFragment): Update use of LocalDefaultSystemAppearance.
2861
2862 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2863
2864         Implement feature flag and bindings for CSS Painting API
2865         https://bugs.webkit.org/show_bug.cgi?id=190237
2866
2867         Reviewed by Ryosuke Niwa.
2868
2869         * Configurations/FeatureDefines.xcconfig:
2870
2871 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2872
2873         Replace HistoryItem* with HistoryItem& where possible
2874         https://bugs.webkit.org/show_bug.cgi?id=190617
2875
2876         Reviewed by Chris Dumez.
2877
2878         * History/BackForwardList.h:
2879         * History/BackForwardList.mm:
2880         (BackForwardList::goToItem):
2881         * History/WebBackForwardList.mm:
2882         (-[WebBackForwardList goToItem:]):
2883         * History/WebHistoryItem.mm:
2884         (WKNotifyHistoryItemChanged):
2885         * History/WebHistoryItemInternal.h:
2886
2887 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2888
2889         Remove unused WebHistoryItem._transientPropertyForKey
2890         https://bugs.webkit.org/show_bug.cgi?id=190606
2891
2892         Reviewed by Chris Dumez.
2893
2894         * History/WebHistoryItem.mm:
2895         * History/WebHistoryItemPrivate.h:
2896
2897 2018-10-15  Justin Fan  <justin_fan@apple.com>
2898
2899         Add WebGPU 2018 feature flag and experimental feature flag
2900         https://bugs.webkit.org/show_bug.cgi?id=190509
2901
2902         Reviewed by Dean Jackson.
2903
2904         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2905         for the 2018 WebGPU prototype.
2906
2907         * Configurations/FeatureDefines.xcconfig:
2908         * WebView/WebPreferenceKeysPrivate.h:
2909         * WebView/WebPreferences.mm:
2910         (+[WebPreferences initialize]):
2911         (-[WebPreferences webGPUEnabled]):
2912         (-[WebPreferences setWebGPUEnabled:]):
2913         * WebView/WebPreferencesPrivate.h:
2914         * WebView/WebView.mm:
2915         (-[WebView _preferencesChanged:]):
2916
2917 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2918
2919         Fix iOS build after r237157
2920
2921         * WebView/WebView.mm:
2922         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2923
2924 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2925
2926         Modernize BackForwardClient.h
2927         https://bugs.webkit.org/show_bug.cgi?id=190610
2928
2929         Reviewed by Chris Dumez.
2930
2931         * History/BackForwardList.h:
2932         * History/BackForwardList.mm:
2933         (BackForwardList::backListCount const):
2934         (BackForwardList::forwardListCount const):
2935         (BackForwardList::backListCount): Deleted.
2936         (BackForwardList::forwardListCount): Deleted.
2937         * History/WebBackForwardList.mm:
2938         (-[WebBackForwardList init]):
2939         * WebCoreSupport/WebFrameLoaderClient.mm:
2940         (WebFrameLoaderClient::canCachePage const):
2941         * WebView/WebFrameView.mm:
2942         (-[WebFrameView keyDown:keyDown:]):
2943         * WebView/WebView.mm:
2944         (-[WebView _commonInitializationWithFrameName:groupName:]):
2945         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
2946         (-[WebView _loadBackForwardListFromOtherView:]):
2947         (-[WebView initWithCoder:]):
2948         (-[WebView encodeWithCoder:]):
2949         (-[WebView backForwardList]):
2950         (-[WebView setMaintainsBackForwardList:]):
2951
2952 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2953
2954         Add support for prefers-color-scheme media query
2955         https://bugs.webkit.org/show_bug.cgi?id=190499
2956         rdar://problem/45212025
2957
2958         Reviewed by Dean Jackson.
2959
2960         * Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2961
2962 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2963
2964         Remove unused WebView._globalHistoryItem
2965         https://bugs.webkit.org/show_bug.cgi?id=190601
2966
2967         Reviewed by Chris Dumez.
2968
2969         * WebCoreSupport/WebFrameLoaderClient.h:
2970         * WebCoreSupport/WebFrameLoaderClient.mm:
2971         (WebFrameLoaderClient::updateGlobalHistoryItemForPage): Deleted.
2972         * WebView/WebView.mm:
2973         (-[WebView _globalHistoryItem]): Deleted.
2974         (-[WebView _setGlobalHistoryItem:]): Deleted.
2975         * WebView/WebViewData.h:
2976         * WebView/WebViewInternal.h:
2977         * WebView/WebViewPrivate.h:
2978
2979 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2980
2981         Remove unused parameters from FrameLoaderClient::createFrame
2982         https://bugs.webkit.org/show_bug.cgi?id=190587
2983
2984         Reviewed by Chris Dumez.
2985
2986         * WebCoreSupport/WebFrameLoaderClient.h:
2987         * WebCoreSupport/WebFrameLoaderClient.mm:
2988         (WebFrameLoaderClient::createFrame):
2989
2990 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2991
2992         Remove unused WebFrame._loadType
2993         https://bugs.webkit.org/show_bug.cgi?id=190583
2994
2995         Reviewed by Chris Dumez.
2996
2997         This is unused, and this concept needs to not be exposed from WebCore to WebKitLegacy for me to fix history bugs.
2998
2999         * WebView/WebFrame.mm:
3000         (toWebFrameLoadType): Deleted.
3001         (-[WebFrame _loadType]): Deleted.
3002         * WebView/WebFramePrivate.h:
3003
3004 2018-10-15  Chris Dumez  <cdumez@apple.com>
3005
3006         Restrict browsing context lookup by name to frames that are related to one another
3007         https://bugs.webkit.org/show_bug.cgi?id=190475
3008
3009         Reviewed by Alex Christensen.
3010
3011         * WebView/WebFrame.mm:
3012         (-[WebFrame findFrameNamed:]):
3013
3014 2018-10-15  Alex Christensen  <achristensen@webkit.org>
3015
3016         Remove InjectedBundle processing of back/forward lists
3017         https://bugs.webkit.org/show_bug.cgi?id=190459
3018
3019         Reviewed by Chris Dumez.
3020
3021         * WebCoreSupport/WebFrameLoaderClient.h:
3022         * WebCoreSupport/WebFrameLoaderClient.mm:
3023         (WebFrameLoaderClient::shouldGoToHistoryItem const):
3024
3025 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3026
3027         [JSC] Remove Option::useAsyncIterator
3028         https://bugs.webkit.org/show_bug.cgi?id=190567
3029
3030         Reviewed by Saam Barati.
3031
3032         * Configurations/FeatureDefines.xcconfig:
3033
3034 2018-10-12  Alex Christensen  <achristensen@webkit.org>
3035
3036         Allow encoding of small enum classes
3037         https://bugs.webkit.org/show_bug.cgi?id=190531
3038
3039         Reviewed by Tim Horton.
3040
3041         * WebCoreSupport/WebFrameLoaderClient.mm:
3042         (-[WebFramePolicyListener dealloc]):
3043
3044 2018-10-11  Keith Rollin  <krollin@apple.com>
3045
3046         CURRENT_ARCH should not be used in Run Script phase.
3047         https://bugs.webkit.org/show_bug.cgi?id=190407
3048         <rdar://problem/45133556>
3049
3050         Reviewed by Alexey Proskuryakov.
3051
3052         CURRENT_ARCH is used in a number of Xcode Run Script phases. However,
3053         CURRENT_ARCH is not well-defined during this phase (and may even have
3054         the value "undefined") since this phase is run just once per build
3055         rather than once per supported architecture. Migrate away from
3056         CURRENT_ARCH in favor of ARCHS, either by iterating over ARCHS and
3057         performing an operation for each value, or by picking the first entry
3058         in ARCHS and using that as a representative value.
3059
3060         * Configurations/WebKitLegacy.xcconfig: When generating
3061         WebKitLegacy.*.exp, generate both 32- and 64-bit versions for
3062         macosx platforms.
3063
3064         * MigrateHeaders.make:
3065         * migrate-headers.sh: When generating ReexportedWebCoreSymbols_*.exp,
3066         generate one for each architecture in ARCHS.
3067
3068 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3069
3070         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3071         https://bugs.webkit.org/show_bug.cgi?id=190429
3072
3073         Reviewed by Saam Barati.
3074
3075         Use `tryCreate` or new `create`. If we use new `create`, we can use Ref<> and remove null check.
3076
3077         * WebView/WebPDFRepresentation.mm:
3078         (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
3079
3080 2018-10-08  Justin Fan  <justin_fan@apple.com>
3081
3082         WebGPU: Rename old WebGPU prototype to WebMetal
3083         https://bugs.webkit.org/show_bug.cgi?id=190325
3084         <rdar://problem/44990443>
3085
3086         Reviewed by Dean Jackson.
3087
3088         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3089
3090         * Configurations/FeatureDefines.xcconfig:
3091         * WebView/WebPreferenceKeysPrivate.h:
3092         * WebView/WebPreferences.mm:
3093         (+[WebPreferences initialize]):
3094         (-[WebPreferences webMetalEnabled]):
3095         (-[WebPreferences setWebMetalEnabled:]):
3096         (-[WebPreferences webGPUEnabled]): Deleted.
3097         (-[WebPreferences setWebGPUEnabled:]): Deleted.
3098         * WebView/WebPreferencesPrivate.h:
3099         * WebView/WebView.mm:
3100         (-[WebView _preferencesChanged:]):
3101
3102 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3103
3104         Make <input type=color> a runtime enabled (on-by-default) feature
3105         https://bugs.webkit.org/show_bug.cgi?id=189162
3106
3107         Reviewed by Wenson Hsieh and Tim Horton.
3108
3109         * Configurations/FeatureDefines.xcconfig:
3110
3111 2018-10-07  Dan Bernstein  <mitz@apple.com>
3112
3113         Fixed building with the latest macOS SDK
3114
3115         * Plugins/WebNetscapePluginPackage.mm:
3116         (-[WebNetscapePluginPackage openResourceFile]):
3117         (-[WebNetscapePluginPackage closeResourceFile:]):
3118
3119 2018-10-04  Dan Bernstein  <mitz@apple.com>
3120
3121         More Carbon build-fixing.
3122
3123         * Carbon/CarbonWindowAdapter.mm:
3124         (-[CarbonWindowAdapter _destroyRealWindow:]):
3125         (-[CarbonWindowAdapter _growBoxRect]):
3126
3127 2018-10-04  Dan Bernstein  <mitz@apple.com>
3128
3129         Retried to fix 32-bit macOS builds after r236846.
3130
3131         * WebView/WebHTMLView.mm:
3132         (-[WebHTMLView setMarkedText:selectedRange:]):
3133
3134 2018-10-04  Dan Bernstein  <mitz@apple.com>
3135
3136         Retried to fix 32-bit macOS builds after r236846.
3137
3138         * Carbon/HIWebView.mm:
3139         (ActiveStateChanged):
3140
3141 2018-10-04  Dan Bernstein  <mitz@apple.com>
3142
3143         Tried to fix 32-bit macOS builds after r236846.
3144
3145         * Carbon/HIWebView.mm:
3146         (_NSSelectorForHICommand):
3147
3148 2018-10-04  Dan Bernstein  <mitz@apple.com>
3149
3150         WebKitLegacy part of [Xcode] Update some build settings as recommended by Xcode 10
3151         https://bugs.webkit.org/show_bug.cgi?id=190250
3152
3153         Reviewed by Andy Estes.
3154
3155         * Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
3156           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3157           Also enabled GCC_WARN_UNDECLARED_SELECTOR by deleting the line that set it to NO, which let
3158           an earlier line set it to YES.
3159
3160         Enabling -Wundeclared-selector exposed some long-standing mistakes and required the most
3161         changes below.
3162
3163         * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Imported an internal header that
3164           provides some missing method declarations.
3165
3166         * Misc/WebDownload.mm:
3167         (-[WebDownload initWithRequest:delegate:]): Suppressed warning about this implementation of
3168           a deprecated method.
3169
3170         * Misc/WebIconDatabase.mm: Suppressed warning around our implementation of a deprecated class.
3171
3172         * Misc/WebNSObjectExtras.mm: Declare a category that is implemented in this file, because
3173           other code in the file uses a method from it.
3174
3175         * Plugins/WebBaseNetscapePluginView.mm:
3176         (-[WebBaseNetscapePluginView renewGState]): Suppressed warning about this implementation of
3177           a deprecated method.
3178
3179         * Plugins/WebPluginController.mm:
3180         (installFlip4MacPlugInWorkaroundIfNecessary): Suppressed the undeclared selector warning
3181           around use of a selector that may be present in some WebKit client.
3182
3183         * Plugins/WebPluginDatabase.mm: Imported an internal header that provides some missing
3184           method declarations.
3185
3186         * WebCoreSupport/PopupMenuMac.mm: Imported a header that delcares delegate methods we call
3187           from here.
3188
3189         * WebCoreSupport/WebCachedFramePlatformData.h: Imported an internal header that provides some
3190           missing method declarations.
3191
3192         * WebCoreSupport/WebChromeClient.mm: Imported a header that declares delegate methods we call
3193           from here.
3194
3195         * WebCoreSupport/WebFrameLoaderClient.mm: Imported headers that declare delegate methods we
3196           call from here.
3197         (WebFrameLoaderClient::setTitle): Suppressed the undeclared selector warning around use of
3198           an obsolete delegate method for binary compatibility.
3199         (pluginView): Ditto.
3200
3201         * WebCoreSupport/WebVisitedLinkStore.mm: Imported a header that declares delegate methods we
3202           call from here.
3203
3204         * WebView/WebDeviceOrientationInternal.h: Declared -setController in a new
3205           WebDeviceOrientationProviderMock protocol.
3206
3207         * WebView/WebDeviceOrientationProviderMock.mm:
3208         (-[WebDeviceOrientationProviderMock setController:]): Moved from an internal category to the
3209           main @implementation.
3210
3211         * WebView/WebDeviceOrientationProviderMockInternal.h: Declared that
3212           WebDeviceOrientationProviderMock conforms to WebDeviceOrientationProviderMock.
3213
3214         * WebView/WebDynamicScrollBarsView.mm:
3215         (-[WebDynamicScrollBarsView accessibilityIsIgnored]): Suppressed warning about this implementation
3216           of a deprecated method.
3217
3218         * WebView/WebHTMLView.mm:
3219         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Suppressed the undeclared
3220           selector warning around action methods that are not declared anywhere in WebKit.
3221
3222         (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed warning
3223           about implementing this deprecated method.
3224         (-[WebHTMLView draggingSourceOperationMaskForLocal:]): Ditto.
3225         (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
3226         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
3227         (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
3228         (-[WebHTMLView characterIndexForPoint:]): Ditto.
3229         (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
3230         (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
3231         (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
3232         (-[WebHTMLView doCommandBySelector:]): Ditto.
3233         (-[WebHTMLView insertText:]): Ditto.
3234
3235         * WebView/WebHTMLViewInternal.h: Declared an internal method that’s used from another file.
3236
3237         * WebView/WebJSPDFDoc.mm: Imported a header that declares delegate methods we call from here.
3238
3239         * WebView/WebPDFView.h: Removed previewView ivar.
3240
3241         * WebView/WebPDFView.mm:
3242           Removed declaration of FileInternal category and merged its implementation with the main
3243           implementation.
3244         (-[WebPDFView dealloc]): Removed previewView ivar.
3245         (-[WebPDFView initWithFrame:]): Removed code to deal with PDFPreviewView, which doesn’t
3246           exist in macOS versions we support.
3247         (+[WebPDFView _PDFPreviewViewClass]): Deleted. PDFPreviewView doesn’t exist anymore.
3248         (-[WebPDFView _canLookUpInDictionary]): Suppressed undeclared selector warning around use of
3249           action methods internal to PDFKit.
3250         (-[WebPDFView _lookUpInDictionaryFromMenu:]): Ditto.
3251         (-[WebPDFView _menuItemsFromPDFKitForEvent:]): Ditto.
3252
3253         * WebView/WebUIDelegatePrivate.h: Restored declarations of the delegate methods we actually
3254           call on macOS, even though in r86988 we started calling different methods on iOS.
3255
3256         * WebView/WebView.mm:
3257         - Imported headers that declare delegate methods that we call.
3258         - Removed declaration of WebFileInternal category and merged its implementation with the
3259           main implementation.
3260         - Many internal methods were inexplicibly implemented as part of the WebViewEditingInMail
3261           category, which made them impossible to call from the main implementation. Moved those
3262           into the main implementation. One of those had to be declared in a class extension,
3263           because it is called from a method implemented in the WebPrivate category, and that
3264           category’s implementation appears first in the file.
3265
3266         (-[WebView _cacheHistoryDelegateImplementations]): Suppressed undeclared selector warning
3267           around use of obsolete delegate method for binary compatibility.
3268
3269         * WebView/WebViewInternal.h: Declared an internal method that’s used from another file.
3270
3271 2018-10-04  YUHAN WU  <yuhan_wu@apple.com>
3272
3273         Runtime flag and IDL for MediaRecorder
3274         https://bugs.webkit.org/show_bug.cgi?id=190018
3275
3276         Reviewed by Youenn Fablet and Chris Dumez.
3277
3278         * WebView/WebPreferenceKeysPrivate.h:
3279         * WebView/WebPreferences.mm:
3280         (+[WebPreferences initialize]):
3281         (-[WebPreferences mediaRecorderEnabled]):
3282         (-[WebPreferences setMediaRecorderEnabled:]):
3283         * WebView/WebPreferencesPrivate.h:
3284         * WebView/WebView.mm:
3285         (-[WebView _preferencesChanged:]):
3286
3287 2018-10-03  Ryosuke Niwa  <rniwa@webkit.org>
3288
3289         Enable selectionAcrossShadowBoundariesEnabled by default in WebKitLegacy
3290         https://bugs.webkit.org/show_bug.cgi?id=190238
3291
3292         Reviewed by Antti Koivisto.
3293
3294         Enabled the feature by default.
3295
3296         * WebView/WebPreferences.mm:
3297         (+[WebPreferences initialize]):
3298
3299 2018-10-01  Dean Jackson  <dino@apple.com>
3300
3301         [macOS] Switching to discrete GPU should be done in the UI process
3302         https://bugs.webkit.org/show_bug.cgi?id=189361
3303         <rdar://problem/43949622>
3304
3305         Reviewed by Simon Fraser.
3306
3307         Implement a no-op SwitchingGPUClient instance in legacy WebKit. We will
3308         not support swapping to the discrete GPU in this configuration.
3309
3310         * WebCoreSupport/WebSwitchingGPUClient.cpp: Added.
3311         (WebKit::WebSwitchingGPUClient::singleton):
3312         * WebCoreSupport/WebSwitchingGPUClient.h: Added.
3313         * WebView/WebView.mm:
3314         (-[WebView _commonInitializationWithFrameName:groupName:]):
3315
3316 2018-10-02  Alex Christensen  <achristensen@webkit.org>
3317
3318         Remove ParsedURLString
3319         https://bugs.webkit.org/show_bug.cgi?id=190154
3320
3321         Reviewed by Chris Dumez.
3322
3323         * WebView/WebScriptDebugger.mm:
3324         (toNSURL):
3325
3326 2018-10-01  Dean Jackson  <dino@apple.com>
3327
3328         Remove CSS Animation Triggers
3329         https://bugs.webkit.org/show_bug.cgi?id=190175
3330         <rdar://problem/44925626>
3331
3332         Reviewed by Simon Fraser.
3333
3334         * Configurations/FeatureDefines.xcconfig:
3335
3336 2018-10-02  Commit Queue  <commit-queue@webkit.org>
3337
3338         Unreviewed, rolling out r236624 and r236671.
3339         https://bugs.webkit.org/show_bug.cgi?id=190207
3340
3341         The change in r236624 introduced crashes on the bots
3342         (Requested by ryanhaddad on #webkit).
3343
3344         Reverted changesets:
3345
3346         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3347         https://bugs.webkit.org/show_bug.cgi?id=188747
3348         https://trac.webkit.org/changeset/236624
3349
3350         "Unify implementation in VideoFullscreenInterfaceAVKit"
3351         https://bugs.webkit.org/show_bug.cgi?id=190091
3352         https://trac.webkit.org/changeset/236671
3353
3354 2018-10-01  Alex Christensen  <achristensen@webkit.org>
3355
3356         URL should not use TextEncoding internally
3357         https://bugs.webkit.org/show_bug.cgi?id=190111
3358
3359         Reviewed by Andy Estes.
3360
3361         * Misc/WebNSURLExtras.mm:
3362
3363 2018-09-28  Jer Noble  <jer.noble@apple.com>
3364
3365         Refactoring: eliminate raw pointer usage in Fullscreen code
3366         https://bugs.webkit.org/show_bug.cgi?id=188747
3367         <rdar://problem/43541164>
3368
3369         Reviewed by Alex Christensen.
3370
3371         PlaybackSessionInterface no longer has an invalidate() method.
3372
3373         * WebView/WebView.mm:
3374         (-[WebView _clearPlaybackControlsManager]):
3375
3376 2018-09-28  Chris Dumez  <cdumez@apple.com>
3377
3378         Drop support for cross-origin-window-policy header
3379         https://bugs.webkit.org/show_bug.cgi?id=190081
3380
3381         Reviewed by Ryosuke Niwa.
3382
3383         * WebView/WebPreferenceKeysPrivate.h:
3384         * WebView/WebPreferences.mm:
3385         (+[WebPreferences initialize]):
3386         * WebView/WebPreferencesPrivate.h:
3387         * WebView/WebView.mm:
3388         (-[WebView _preferencesChanged:]):
3389
3390 2018-09-28  Ryosuke Niwa  <rniwa@webkit.org>
3391
3392         Rename createMarkup to serializePreservingVisualAppearance
3393         https://bugs.webkit.org/show_bug.cgi?id=190086
3394
3395         Reviewed by Wenson Hsieh.
3396
3397         * DOM/WebDOMOperations.mm:
3398         (-[DOMRange markupString]):
3399
3400 2018-09-28  Commit Queue  <commit-queue@webkit.org>
3401
3402         Unreviewed, rolling out r236605.
3403         https://bugs.webkit.org/show_bug.cgi?id=190087
3404
3405         caused three API test timeouts (Requested by jernoble on
3406         #webkit).
3407
3408         Reverted changeset:
3409
3410         "Refactoring: eliminate raw pointer usage in Fullscreen code"
3411         https://bugs.webkit.org/show_bug.cgi?id=188747
3412         https://trac.webkit.org/changeset/236605
3413
3414 2018-09-28  Jer Noble  <jer.noble@apple.com>
3415
3416         Refactoring: eliminate raw pointer usage in Fullscreen code
3417         https://bugs.webkit.org/show_bug.cgi?id=188747
3418         <rdar://problem/43541164>
3419
3420         Reviewed by Alex Christensen.
3421
3422         PlaybackSessionInterface no longer has an invalidate() method.
3423
3424         * WebView/WebView.mm:
3425         (-[WebView _clearPlaybackControlsManager]):
3426
3427 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3428
3429         Use enum class in createMarkup arguments
3430         https://bugs.webkit.org/show_bug.cgi?id=190028
3431
3432         Reviewed by Wenson Hsieh.
3433
3434         * DOM/WebDOMOperations.mm:
3435         (-[DOMNode markupString]): Moved the code from WebCore/editing/markup.cpp
3436         (-[DOMRange markupString]): Ditto.
3437
3438 2018-09-27  Antoine Quint  <graouts@apple.com>
3439
3440         [Web Animations] Turn Web Animations with CSS integration on
3441         https://bugs.webkit.org/show_bug.cgi?id=184819
3442         <rdar://problem/39597337>
3443
3444         Reviewed by Dean Jackson.
3445
3446         * WebView/WebPreferences.mm:
3447         (+[WebPreferences initialize]):
3448
3449 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
3450
3451         Selection should work across shadow boundary when initiated by a mouse drag
3452         https://bugs.webkit.org/show_bug.cgi?id=151380
3453         <rdar://problem/24363872>
3454
3455         Reviewed by Wenson Hsieh.
3456
3457         Added selectionAcrossShadowBoundariesEnabled as a preference to be used in DumpRenderTree.
3458
3459         * WebView/WebPreferenceKeysPrivate.h:
3460         * WebView/WebPreferences.mm:
3461         (+[WebPreferences initialize]):
3462         (-[WebPreferences selectionAcrossShadowBoundariesEnabled]):
3463         (-[WebPreferences setSelectionAcrossShadowBoundariesEnabled:]):
3464         * WebView/WebPreferencesPrivate.h:
3465         * WebView/WebView.mm:
3466         (-[WebView _preferencesChanged:]):
3467
3468 2018-09-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3469
3470         Refactor Editor::fontAttributesForSelectionStart to be platform-agnostic
3471         https://bugs.webkit.org/show_bug.cgi?id=189918
3472         Work towards <rdar://problem/44648705>
3473
3474         Reviewed by Tim Horton.
3475
3476         Replace call sites of fontAttributesForSelectionStart() to fontAttributesAtSelectionStart().createDictionary().
3477
3478         * WebView/WebHTMLView.mm:
3479         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
3480         (-[WebHTMLView _updateFontPanel]):
3481         * WebView/WebView.mm:
3482         (-[WebView typingAttributes]):
3483
3484 2018-09-17  Darin Adler  <darin@apple.com>
3485
3486         Use OpaqueJSString rather than JSRetainPtr inside WebKit
3487         https://bugs.webkit.org/show_bug.cgi?id=189652
3488
3489         Reviewed by Saam Barati.
3490
3491         * WebView/WebPDFRepresentation.mm:
3492         (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Use OpaqueJSString::create.
3493
3494 2018-09-14  Jer Noble  <jer.noble@apple.com>
3495
3496         Turn SourceBufferChangeTypeEnabled on by default
3497         https://bugs.webkit.org/show_bug.cgi?id=189527
3498
3499         Reviewed by Eric Carlson.
3500
3501         * WebView/WebPreferences.mm:
3502         (+[WebPreferences initialize]):
3503
3504 2018-09-12  Alex Christensen  <achristensen@webkit.org>
3505
3506         Fix an internal build after r235935
3507         https://bugs.webkit.org/show_bug.cgi?id=188996
3508
3509         * Carbon/HIWebView.mm:
3510         (Draw):
3511         r235935 fixed a mismatched macro with deprecated functions below it.  To quickly fix the build, I'm just going to restore the imbalance.
3512
3513 2018-09-12  Guillaume Emont  <guijemont@igalia.com>
3514
3515         Add IGNORE_WARNING_.* macros
3516         https://bugs.webkit.org/show_bug.cgi?id=188996
3517
3518         Reviewed by Michael Catanzaro.
3519
3520         * Carbon/CarbonUtils.m:
3521         (PoolCleaner):
3522         * Carbon/CarbonWindowAdapter.mm:
3523         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
3524         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
3525         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
3526         (-[CarbonWindowAdapter _termWindowIfOwner]):
3527         (-[CarbonWindowAdapter _windowMovedToRect:]):
3528         (-[CarbonWindowAdapter setContentView:]):
3529         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
3530         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
3531         * Carbon/CarbonWindowFrame.m:
3532         (-[CarbonWindowFrame title]):
3533         * Carbon/HIViewAdapter.m:
3534         (+[HIViewAdapter getHIViewForNSView:]):
3535         * Carbon/HIWebView.mm:
3536         (overrideCGContext):
3537         (restoreCGContext):
3538         (Draw):
3539         * DOM/DOM.mm:
3540         * History/WebHistory.mm:
3541         (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
3542         * History/WebHistoryItem.mm:
3543         (-[WebHistoryItem icon]):
3544         * Misc/WebKitNSStringExtras.mm:
3545         (-[NSString _web_drawAtPoint:font:textColor:]):
3546         * Misc/WebNSImageExtras.m:
3547         (-[NSImage _web_scaleToMaxSize:]):
3548         (-[NSImage _web_dissolveToFraction:]):
3549         * Misc/WebNSPasteboardExtras.mm:
3550         (+[NSPasteboard _web_setFindPasteboardString:withOwner:]):
3551         (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
3552         * Panels/WebAuthenticationPanel.m:
3553         (-[WebAuthenticationPanel loadNib]):
3554         * Plugins/Hosted/NetscapePluginHostManager.mm:
3555         (WebKit::NetscapePluginHostManager::spawnPluginHost):
3556         (WebKit::NetscapePluginHostManager::didCreateWindow):
3557         * Plugins/Hosted/NetscapePluginHostProxy.mm:
3558         (WebKit::NetscapePluginHostProxy::makeCurrentProcessFrontProcess):
3559         (WebKit::NetscapePluginHostProxy::makePluginHostProcessFrontProcess const):
3560         (WebKit::NetscapePluginHostProxy::isPluginHostProcessFrontProcess const):
3561         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3562         (WebKit::NetscapePluginInstanceProxy::mouseEvent):
3563         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3564         (-[WebHostedNetscapePluginView drawRect:]):
3565         * Plugins/Hosted/WebTextInputWindowController.m:
3566         (-[WebTextInputPanel _interpretKeyEvent:string:]):
3567         * Plugins/WebBaseNetscapePluginView.mm:
3568         (-[WebBaseNetscapePluginView convertFromX:andY:space:toX:andY:space:]):
3569         * Plugins/WebNetscapePluginPackage.mm:
3570         (-[WebNetscapePluginPackage _tryLoad]):
3571         * Plugins/WebNetscapePluginView.mm:
3572         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3573         (-[WebNetscapePluginView sendDrawRectEvent:]):
3574         (-[WebNetscapePluginView drawRect:]):
3575         * Plugins/WebPluginController.mm:
3576         (WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
3577         (WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):
3578         * WebCoreSupport/PopupMenuMac.mm:
3579         (PopupMenuMac::populate):
3580         * WebCoreSupport/WebAlternativeTextClient.h:
3581         * WebCoreSupport/WebDragClient.mm:
3582         (WebDragClient::startDrag):
3583         * WebCoreSupport/WebFrameLoaderClient.mm:
3584         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
3585         (webGetNSImage):
3586         * WebInspector/WebNodeHighlight.mm:
3587         * WebInspector/WebNodeHighlightView.mm:
3588         (-[WebNodeHighlightView drawRect:]):
3589         * WebView/WebClipView.mm:
3590         (-[WebClipView initWithFrame:]):
3591         * WebView/WebFrame.mm:
3592         (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
3593         (-[WebFrame _drawRect:contentsOnly:]):
3594         (-[WebFrame accessibilityRoot]):
3595         * WebView/WebFullScreenController.mm:
3596         (-[WebFullScreenController enterFullScreen:]):
3597         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
3598         (-[WebFullScreenController exitFullScreen]):
3599         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
3600         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
3601         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
3602         * WebView/WebHTMLView.mm:
3603         (-[NSWindow _web_borderView]):
3604         (-[WebHTMLView _updateMouseoverWithFakeEvent]):
3605         (-[WebHTMLView _setAsideSubviews]):
3606         (-[WebHTMLView _autoscroll]):
3607         (-[WebHTMLView drawRect:]):
3608         (-[WebHTMLView mouseDown:]):
3609         (-[WebHTMLView mouseDragged:]):
3610         (-[WebHTMLView mouseUp:]):
3611         (-[WebHTMLView _endPrintModeAndRestoreWindowAutodisplay]):
3612         (-[WebHTMLView knowsPageRange:]):
3613         (-[WebHTMLView accessibilityHitTest:]):
3614         (-[WebHTMLView _fontAttributesFromFontPasteboard]):
3615         (-[WebHTMLView _colorAsString:]):
3616         (-[WebHTMLView copyFont:]):
3617         (-[WebHTMLView _executeSavedKeypressCommands]):
3618         (-[WebHTMLView attachRootLayer:]):
3619         (-[WebHTMLView textStorage]):
3620         (-[WebHTMLView _updateSelectionForInputManager]):
3621         * WebView/WebPDFView.mm:
3622         (_applicationInfoForMIMEType):
3623         (-[WebPDFView centerSelectionInVisibleArea:]):
3624         (-[WebPDFView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
3625         (-[WebPDFView _recursiveDisplayAllDirtyWithLockFocus:visRect:]):
3626         (-[WebPDFView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
3627         (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
3628         * WebView/WebTextCompletionController.mm:
3629         (-[WebTextCompletionController _buildUI]):
3630         (-[WebTextCompletionController _placePopupWindow:]):
3631         * WebView/WebVideoFullscreenController.mm:
3632         * WebView/WebVideoFullscreenHUDWindowController.mm:
3633         (createMediaUIBackgroundView):
3634         * WebView/WebView.mm:
3635         (-[WebTextListTouchBarViewController initWithWebView:]):
3636         (-[WebView _dispatchTileDidDraw:]):
3637         (-[WebView encodeWithCoder:]):
3638         (-[WebView mainFrameIcon]):
3639         (LayerFlushController::flushLayers):
3640         * WebView/WebWindowAnimation.mm:
3641         (setScaledFrameForWindow):
3642
3643 2018-09-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3644
3645         Remove unused needsDestruction class variables from HashTraits
3646         https://bugs.webkit.org/show_bug.cgi?id=189490
3647
3648         Reviewed by Daniel Bates.
3649
3650         * History/BinaryPropertyList.cpp: Removed needsDestruction.
3651
3652 2018-09-07  Frederic Wang  <fwang@igalia.com>
3653
3654         [CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
3655         https://bugs.webkit.org/show_bug.cgi?id=182230
3656
3657         Reviewed by Simon Fraser.
3658
3659         * DOM/DOMDocument.mm:
3660         (-[DOMDocument scrollingElement]): Use the new name.
3661
3662 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3663
3664         Refactor WebCore::EditAction to be an 8-bit enum class
3665         https://bugs.webkit.org/show_bug.cgi?id=189383
3666
3667         Reviewed by Dan Bernstein.
3668
3669         * WebCoreSupport/WebEditorClient.mm:
3670         (undoNameForEditAction):
3671         * WebView/WebHTMLView.mm:
3672         (-[WebHTMLView pasteFont:]):
3673         (-[WebHTMLView changeFont:]):
3674         (-[WebHTMLView changeAttributes:]):
3675         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
3676         (-[WebHTMLView changeColor:]):
3677         * WebView/WebView.mm:
3678         (-[WebView setTypingStyle:]):
3679
3680 2018-09-06  Frederic Wang  <fwang@igalia.com>
3681
3682         Group options of scrollRectToVisible into a struct
3683         https://bugs.webkit.org/show_bug.cgi?id=189352
3684
3685         Reviewed by Simon Fraser.
3686
3687         * WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.
3688         (-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
3689         (-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.
3690
3691 2018-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
3692
3693         [macOS] Cannot change font size at selection until font panel is shown
3694         https://bugs.webkit.org/show_bug.cgi?id=189295
3695         <rdar://problem/35593389>
3696
3697         Reviewed by Ryosuke Niwa.
3698
3699         Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
3700         WebCore ChangeLog for more details.
3701
3702         * WebView/WebHTMLView.mm:
3703         (-[WebHTMLView changeFont:]):
3704         (-[WebHTMLView changeAttributes:]):
3705         (-[WebHTMLView _originalFontA]): Deleted.
3706         (-[WebHTMLView _originalFontB]): Deleted.
3707         (fontNameForDescription): Deleted.
3708         (-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
3709         (-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
3710         (-[WebHTMLView _styleForAttributeChange:]): Deleted.
3711
3712 2018-09-05  Jer Noble  <jer.noble@apple.com>
3713
3714         Add MediaCapabilities as an Experimental Feature
3715         https://bugs.webkit.org/show_bug.cgi?id=189209
3716
3717         Reviewed by Eric Carlson.
3718
3719         RuntimeEnabledFeature -> Setting.
3720
3721         * WebView/WebView.mm:
3722         (-[WebView _preferencesChanged:]):
3723
3724 2018-09-04  Frederic Wang  <fwang@igalia.com>
3725
3726         Add basic support for ScrollIntoViewOptions
3727         https://bugs.webkit.org/show_bug.cgi?id=189258
3728
3729         Reviewed by Simon Fraser.
3730
3731         * WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElementGtk.cpp: Add ScrollIntoViewOptions
3732         header so that this file can build despite the new scrollIntoView function.
3733
3734 2018-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3735
3736         Populate "text/uri-list" with multiple URLs when the pasteboard contains multiple URLs
3737         https://bugs.webkit.org/show_bug.cgi?id=188890
3738         <rdar://problem/43648605>
3739
3740         Reviewed by Tim Horton.
3741
3742         Add some plumbing through pasteboard classes to support `Pasteboard::readAllStrings`. See WebCore ChangeLog for
3743         more detail.
3744
3745         * WebCoreSupport/WebPlatformStrategies.h:
3746         * WebCoreSupport/WebPlatformStrategies.mm:
3747         (WebPlatformStrategies::allStringsForType):
3748
3749 2018-09-01  Darin Adler  <darin@apple.com>
3750
3751         [CFNetwork] Update CFNetwork SPI use to use CFNetworkSPI.h more consistently
3752         https://bugs.webkit.org/show_bug.cgi?id=189072
3753         Reviewed by Dan Bernstein.
3754
3755         * Misc/WebDownload.mm: Removed forward declaration of NSURLConnectionDelegateProxy
3756         and declarations for NSURLDownload init methods.
3757
3758         * Misc/WebDownloadInternal.h: Removed.
3759
3760         * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebDownloadInternal.h.
3761         (WebFrameLoaderClient::convertMainResourceLoadToDownload): Ignore
3762         "-Wdeprecated-declarations" because the method used here is deprecated.
3763
3764         * WebView/WebView.mm:
3765         (-[WebView _downloadURL:]): Ignore "-Wdeprecated-declarations" because the method
3766         used here is deprecated.
3767
3768 2018-08-31  Chris Dumez  <cdumez@apple.com>
3769
3770         Assertion hit in ~CompletionHandler() from ~WebFrame()
3771         https://bugs.webkit.org/show_bug.cgi?id=189199
3772         <rdar://problem/42657233>
3773
3774         Reviewed by Youenn Fablet.
3775
3776         * WebCoreSupport/WebFrameLoaderClient.h:
3777         * WebCoreSupport/WebFrameLoaderClient.mm:
3778         (WebFrameLoaderClient::dispatchWillSubmitForm):
3779
3780 2018-08-31  Antti Koivisto  <antti@apple.com>
3781
3782         Replace OptionSet |= and -= operators with add() and remove() functions
3783         https://bugs.webkit.org/show_bug.cgi?id=189169
3784
3785         Reviewed by Anders Carlsson.
3786
3787         * WebView/WebFrame.mm:
3788         (-[WebFrame _drawRect:contentsOnly:]):
3789         * WebView/WebView.mm:
3790         (coreOptions):
3791
3792 2018-08-31  Frederic Wang  <fwang@igalia.com>
3793
3794         Bug 182053 - [CSSOM View] Implement standard behavior for scrollingElement
3795         https://bugs.webkit.org/show_bug.cgi?id=182053
3796
3797         Reviewed by Simon Fraser.
3798
3799         Add developer flag to use standard behavior for scrolling* attributes.
3800
3801         * WebView/WebPreferenceKeysPrivate.h:
3802         * WebView/WebPreferences.mm:
3803         (+[WebPreferences initialize]):
3804         (-[WebPreferences CSSOMViewScrollingAPIEnabled]):
3805         (-[WebPreferences setCSSOMViewScrollingAPIEnabled:]):
3806         * WebView/WebPreferencesPrivate.h:
3807         * WebView/WebView.mm:
3808         (-[WebView _preferencesChanged:]):
3809
3810 2018-08-29  Olivia Barnett  <obarnett@apple.com>
3811
3812         Implement the Web Share API
3813         https://bugs.webkit.org/show_bug.cgi?id=171100
3814         <rdar://problem/31751734>
3815
3816         Reviewed by Tim Horton.
3817
3818         * WebCoreSupport/WebChromeClient.h:
3819         * WebCoreSupport/WebChromeClient.mm:
3820         (WebChromeClient::showShareSheet):
3821         Empty declaration of showShareSheet.
3822
3823 2018-08-29  Youenn Fablet  <youenn@apple.com>
3824
3825         Remove WebRTC legacy API implementation
3826         https://bugs.webkit.org/show_bug.cgi?id=189040
3827
3828         Reviewed by Eric Carlson.
3829
3830         * WebView/WebPreferenceKeysPrivate.h:
3831         * WebView/WebPreferences.mm:
3832         (+[WebPreferences initialize]):
3833         (-[WebPreferences webRTCLegacyAPIEnabled]): Deleted.
3834         (-[WebPreferences setWebRTCLegacyAPIEnabled:]): Deleted.
3835         * WebView/WebPreferencesPrivate.h:
3836         * WebView/WebView.mm:
3837         (-[WebView _preferencesChanged:]):
3838
3839 2018-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3840
3841         Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm
3842         https://bugs.webkit.org/show_bug.cgi?id=189054
3843
3844         Reviewed by Andy Estes.
3845
3846         Remove the pasteboard type argument from readURLFromPasteboard.
3847
3848         * WebCoreSupport/WebPlatformStrategies.h:
3849         * WebCoreSupport/WebPlatformStrategies.mm:
3850         (WebPlatformStrategies::readURLFromPasteboard):
3851
3852 2018-08-27  Keith Rollin  <krollin@apple.com>
3853
3854         Unreviewed build fix -- disable LTO for production builds
3855
3856         * Configurations/Base.xcconfig:
3857
3858 2018-08-27  Aditya Keerthi  <akeerthi@apple.com>
3859
3860         Consolidate ENABLE_INPUT_TYPE_COLOR and ENABLE_INPUT_TYPE_COLOR_POPOVER
3861         https://bugs.webkit.org/show_bug.cgi?id=188931
3862
3863         Reviewed by Wenson Hsieh.
3864
3865         * Configurations/FeatureDefines.xcconfig: Removed ENABLE_INPUT_TYPE_COLOR_POPOVER.
3866
3867 2018-08-27  Keith Rollin  <krollin@apple.com>
3868
3869         Build system support for LTO
3870         https://bugs.webkit.org/show_bug.cgi?id=187785
3871         <rdar://problem/42353132>
3872
3873         Reviewed by Dan Bernstein.
3874
3875         Update Base.xcconfig and DebugRelease.xcconfig to optionally enable
3876         LTO.
3877
3878         * Configurations/Base.xcconfig:
3879         * Configurations/DebugRelease.xcconfig:
3880
3881 2018-08-24  Ryosuke Niwa  <rniwa@webkit.org>
3882
3883         Pass in IsComposed flag to Event constructors
3884         https://bugs.webkit.org/show_bug.cgi?id=188720
3885         <rdar://problem/43580387>
3886
3887         Reviewed by Simon Fraser.
3888
3889         * WebView/WebPDFView.mm:
3890         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): A trusted click event is composed regardless of
3891         whether it's simulated or not.
3892
3893 2018-08-23  Mark Lam  <mark.lam@apple.com>
3894
3895         Move vmEntryGlobalObject() to VM from CallFrame.
3896         https://bugs.webkit.org/show_bug.cgi?id=188900
3897         <rdar://problem/43655753>
3898
3899         Reviewed by Michael Saboff.
3900
3901         * WebView/WebScriptDebugger.mm:
3902         (WebScriptDebugger::sourceParsed):
3903
3904 2018-08-23  Andy Estes  <aestes@apple.com>
3905
3906         [Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
3907         https://bugs.webkit.org/show_bug.cgi?id=188829
3908
3909         Reviewed by Tim Horton.
3910
3911         * Configurations/FeatureDefines.xcconfig:
3912
3913 2018-08-21  Ryosuke Niwa  <rniwa@webkit.org>
3914
3915         Replace booleans for modifier keys in UIEventWithKeyState with OptionSet<Modifier>
3916         https://bugs.webkit.org/show_bug.cgi?id=188777
3917
3918         Reviewed by Simon Fraser.
3919
3920         Create MouseEvent::create with IsSimulated set to Yes; correspoding to the last argument
3921         being "true" before the code change.
3922
3923         Use modifiersForEvent to convert [nsEvent modifierFlags] to OptionSet<Modifier>.
3924
3925         * WebView/WebPDFView.mm:
3926         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3927
3928 2018-08-21  Daniel Bates  <dabates@apple.com>
3929
3930         Replace TextCheckingTypeMask with OptionSet
3931         https://bugs.webkit.org/show_bug.cgi?id=188678
3932
3933         Reviewed by Antti Koivisto.
3934
3935         Currently we have code in WebEditorClient::checkTextOfParagraph() that incorrectly assumes
3936         that the enumerators of TextCheckingType have a one-to-one correspondence with NSTextCheckingType.
3937         (This is not the case because there is not corresponding NSTextCheckingType for TextCheckingTypeShowCorrectionPanel).
3938         We now explicitly convert from OptionSet<TextCheckingType> to NSTextCheckingTypes.
3939
3940         * WebCoreSupport/WebEditorClient.h:
3941         * WebCoreSupport/WebEditorClient.mm:
3942         (WebEditorClient::checkTextOfParagraph):
3943         (WebEditorClient::shouldEraseMarkersAfterChangeSelection const):
3944         (core): Fix up code style nits; compare resultType on the right-hand side instead of the
3945         left as this is more readable and unncessary now that modern compilers like Clang have
3946         diagnostics to catch accidental assignments when equality was intended.
3947         (WebEditorClient::didCheckSucceed):
3948         * WebView/WebView.mm:
3949         (coreTextCheckingType):
3950         (textCheckingResultFromNSTextCheckingResult):
3951
3952 2018-08-21  Daniel Bates  <dabates@apple.com>
3953
3954         [iOS][WK1] Support toggling continuous spell checking from tests
3955         https://bugs.webkit.org/show_bug.cgi?id=188763
3956
3957         Reviewed by Simon Fraser.
3958
3959         Move some more code out from under a !PLATFORM(IOS)-guard so as to support toggling continuous
3960         spell checking from tests in iOS WebKit Legacy.
3961
3962         * WebCoreSupport/WebEditorClient.h:
3963         (WebEditorClient::toggleContinuousSpellChecking): Deleted.
3964         * WebCoreSupport/WebEditorClient.mm:
3965         * WebView/WebView.h:
3966         * WebView/WebView.mm:
3967         (-[WebView toggleContinuousSpellChecking:]):
3968         (-[WebView toggleSmartInsertDelete:]):
3969
3970 2018-08-17  Alex Christensen  <achristensen@webkit.org>
3971
3972         Add some plumbing for safe browsing
3973         https://bugs.webkit.org/show_bug.cgi?id=188709
3974
3975         Reviewed by Tim Horton.
3976
3977         * WebCoreSupport/WebFrameLoaderClient.h:
3978         * WebCoreSupport/WebFrameLoaderClient.mm:
3979         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3980
3981 2018-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3982
3983         Replace canBubble and cancelable booleans in Event by enum classes
3984         https://bugs.webkit.org/show_bug.cgi?id=188692
3985
3986         Reviewed by Alex Christensen.
3987
3988         * WebView/WebPDFView.mm:
3989         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3990         * WebView/WebView.mm:
3991         (-[WebView _dispatchUnloadEvent]):
3992
3993 2018-08-16  Jer Noble  <jer.noble@apple.com>
3994
3995         Add Experimental Feature support for SourceBuffer.changeType()
3996         https://bugs.webkit.org/show_bug.cgi?id=188626
3997         <rdar://problem/43356021>
3998
3999         Reviewed by Eric Carlson.
4000
4001         Add a new WebPreference property mapping to the WebCore SourceBufferChangeTypeEnabled setting.
4002
4003         * WebView/WebPreferenceKeysPrivate.h:
4004         * WebView/WebPreferences.mm:
4005         (+[WebPreferences initialize]):
4006         (-[WebPreferences sourceBufferChangeTypeEnabled]):
4007         (-[WebPreferences setSourceBufferChangeTypeEnabled:]):
4008         * WebView/WebPreferencesPrivate.h:
4009         * WebView/WebView.mm:
4010         (-[WebView _preferencesChanged:]):
4011
4012 2018-08-16  Aditya Keerthi  <akeerthi@apple.com>
4013
4014         Support drag-and-drop for input[type=color]
4015         https://bugs.webkit.org/show_bug.cgi?id=188464
4016
4017         Reviewed by Wenson Hsieh.
4018
4019         * WebCoreSupport/WebPlatformStrategies.h:
4020         * WebCoreSupport/WebPlatformStrategies.mm:
4021         (WebPlatformStrategies::setColor):
4022
4023 2018-08-15  Tim Horton  <timothy_horton@apple.com>
4024
4025         Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
4026         https://bugs.webkit.org/show_bug.cgi?id=188569
4027         <rdar://problem/34201095>
4028
4029         Reviewed by Megan Gardner.
4030
4031         * WebView/WebImmediateActionController.mm:
4032         (+[WebImmediateActionController _dictionaryPopupInfoForRange:inFrame:withLookupOptions:indicatorOptions:transition:]):
4033         Speculative fix; the crashes indicate font is null, but we just checked it,
4034         so it must be getting made null by convertFont:toSize:. Check again!
4035
4036 2018-08-13  Alex Christensen  <achristensen@webkit.org>
4037
4038         Use a 1-byte enum class for TextDirection
4039         https://bugs.webkit.org/show_bug.cgi?id=188350
4040
4041         Reviewed by Simon Fraser.
4042
4043         * WebCoreSupport/PopupMenuMac.mm:
4044         (PopupMenuMac::populate):
4045         (PopupMenuMac::show):
4046         * WebCoreSupport/WebFrameLoaderClient.mm:
4047         (WebFrameLoaderClient::transitionToCommittedForNewPage):
4048         * WebView/WebFrame.mm:
4049         (-[WebFrame _dispatchDidReceiveTitle:]):
4050
4051 2018-08-09  Ali Juma  <ajuma@chromium.org>
4052
4053         Import WPTs for IntersectionObserver
4054         https://bugs.webkit.org/show_bug.cgi?id=188416
4055
4056         Reviewed by Simon Fraser.
4057
4058         * WebView/WebPreferencesPrivate.h:
4059
4060 2018-08-08  Jonathan Bedard  <jbedard@apple.com>
4061