Add more overflow check book-keeping for MarkedArgumentBuffer.
[WebKit-https.git] / Source / WebKitLegacy / mac / ChangeLog
1 2017-11-13  Mark Lam  <mark.lam@apple.com>
2
3         Add more overflow check book-keeping for MarkedArgumentBuffer.
4         https://bugs.webkit.org/show_bug.cgi?id=179634
5         <rdar://problem/35492517>
6
7         Reviewed by Saam Barati.
8
9         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
10         (WebKit::NetscapePluginInstanceProxy::invoke):
11         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
12         (WebKit::NetscapePluginInstanceProxy::construct):
13
14 2017-11-12  Darin Adler  <darin@apple.com>
15
16         More is<> and downcast<>, less static_cast<>
17         https://bugs.webkit.org/show_bug.cgi?id=179600
18
19         Reviewed by Chris Dumez.
20
21         * DOM/DOM.mm:
22         (kit): Use is/downcast.
23         * WebCoreSupport/WebEditorClient.mm:
24         (WebEditorClient::handleKeyboardEvent): Ditto.
25         (WebEditorClient::handleInputMethodKeydown): Ditto.
26         * WebView/WebHTMLView.mm:
27         (-[WebHTMLView _interpretKeyEvent:savingCommands:]): Ditto.
28
29 2017-11-10  Frederik Riedel  <frederik.riedel@frogg.io>
30
31         [iOS] Use new class name from UIKit when checking UITextSuggestion type for WebKitLegacy
32         https://bugs.webkit.org/show_bug.cgi?id=179397
33
34         Reviewed by Wenson Hsieh.
35
36         * DOM/DOMHTMLInputElement.mm:
37         (-[DOMHTMLInputElement insertTextSuggestion:]):
38
39 2017-11-08  Jeremy Jones  <jeremyj@apple.com>
40
41         HTMLMediaElement should not use element fullscreen on iOS
42         https://bugs.webkit.org/show_bug.cgi?id=179418
43         rdar://problem/35409277
44
45         Reviewed by Eric Carlson.
46
47         Add ENABLE_VIDEO_USES_ELEMENT_FULLSCREEN to determine if HTMLMediaElement should use element full screen or not.
48
49         * Configurations/FeatureDefines.xcconfig:
50
51 2017-11-06  Alex Christensen  <achristensen@webkit.org>
52
53         Make ResourceLoader::willSendRequestInternal asynchronous
54         https://bugs.webkit.org/show_bug.cgi?id=179251
55
56         Reviewed by Andy Estes.
57
58         * Plugins/Hosted/HostedNetscapePluginStream.mm:
59         (WebKit::HostedNetscapePluginStream::start):
60         * Plugins/WebNetscapePluginStream.mm:
61         (WebNetscapePluginStream::start):
62
63 2017-11-01  Darin Adler  <darin@apple.com>
64
65         Simplify event dispatch code and make it a bit more consistent
66         https://bugs.webkit.org/show_bug.cgi?id=178991
67
68         Reviewed by Chris Dumez.
69
70         * DOM/DOMEvent.mm:
71         (-[DOMEvent srcElement]): Call target instead of srcElement.
72
73 2017-11-04  Aishwarya Nirmal  <anirmal@apple.com>
74
75         [Touch Bar Web API] Add support for menuitem tag
76         https://bugs.webkit.org/show_bug.cgi?id=179020
77
78         Reviewed by Ryosuke Niwa.
79
80         Adds in properties and methods that allow the menuitem runtime feature
81         to be enabled or disabled.
82
83         * WebView/WebPreferenceKeysPrivate.h:
84         * WebView/WebPreferences.mm:
85         (-[WebPreferences menuItemElementEnabled]):
86         (-[WebPreferences setMenuItemElementEnabled:]):
87         * WebView/WebPreferencesPrivate.h:
88         * WebView/WebView.mm:
89         (-[WebView _preferencesChanged:]):
90
91 2017-11-02  Alex Christensen  <achristensen@webkit.org>
92
93         Use CompletionHandlers for redirects
94         https://bugs.webkit.org/show_bug.cgi?id=179163
95
96         Reviewed by Tim Horton.
97
98         * Plugins/Hosted/HostedNetscapePluginStream.h:
99         * Plugins/Hosted/HostedNetscapePluginStream.mm:
100         (WebKit::HostedNetscapePluginStream::willSendRequest):
101         * Plugins/WebNetscapePluginStream.h:
102         * Plugins/WebNetscapePluginStream.mm:
103         (WebNetscapePluginStream::willSendRequest):
104
105 2017-11-02  Christopher Reid  <chris.reid@sony.com>
106
107         Add a FileSystem namespace to FileSystem.cpp
108         https://bugs.webkit.org/show_bug.cgi?id=179063
109
110         Reviewed by Darin Adler.
111
112         * Misc/WebNSFileManagerExtras.mm:
113         * Storage/WebDatabaseProvider.mm:
114
115 2017-11-02  Frederic Wang  <fwang@igalia.com>
116
117         Add references to bug 179167 in FIXME comments
118         https://bugs.webkit.org/show_bug.cgi?id=179168
119
120         Reviewed by Daniel Bates.
121
122         * Configurations/FeatureDefines.xcconfig:
123
124 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
125
126         Implement WKFullscreenWindowController for iOS.
127         https://bugs.webkit.org/show_bug.cgi?id=178924
128         rdar://problem/34697120
129
130         Reviewed by Simon Fraser.
131
132         Enable ENABLE_FULLSCREEN_API for iOS. Fix a build error.
133
134         * Configurations/FeatureDefines.xcconfig:
135         * WebView/WebView.mm:
136         (-[WebView fullScreenPlaceholderView]):
137
138 2017-10-31  Tim Horton  <timothy_horton@apple.com>
139
140         Clean up some drag and drop feature flags
141         https://bugs.webkit.org/show_bug.cgi?id=179082
142
143         Reviewed by Simon Fraser.
144
145         * Configurations/FeatureDefines.xcconfig:
146
147 2017-10-31  Simon Fraser  <simon.fraser@apple.com>
148
149         Make it possible to test rubber-banding in overflow scroll
150         https://bugs.webkit.org/show_bug.cgi?id=179078
151
152         Reviewed by Sam Weinig.
153
154         Add internals.unconstrainedScrollTo(element, x, y) and plumb through ScrollClamping
155         (which replaces RenderLayer::ScrollOffsetClamping) to support it.
156
157         Flip the default from unclamped to clamped for various RenderLayer scrolling-related
158         functions, since most callers want clamped.
159
160         * DOM/DOMHTML.mm:
161         (-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
162
163 2017-10-31  Tim Horton  <timothy_horton@apple.com>
164
165         Fix up some content filtering feature flags
166         https://bugs.webkit.org/show_bug.cgi?id=179079
167
168         Reviewed by Simon Fraser.
169
170         * Configurations/FeatureDefines.xcconfig:
171
172 2017-10-28  Zalan Bujtas  <zalan@apple.com>
173
174         [FrameView::layout cleanup] Move core layout logic to a separate class.
175         https://bugs.webkit.org/show_bug.cgi?id=178771
176         <rdar://problem/35166542>
177
178         Reviewed by Simon Fraser.
179
180         Move layout code out from FrameView to LayoutContext.
181
182         * WebView/WebClipView.mm:
183         (-[WebClipView _immediateScrollToPoint:]):
184         * WebView/WebFrame.mm:
185         (-[WebFrame layoutCount]):
186
187 2017-10-26  Simon Fraser  <simon.fraser@apple.com>
188
189         Fix issues with WebView subframe painting
190         https://bugs.webkit.org/show_bug.cgi?id=178842
191         rdar://problem/34072253
192
193         Reviewed by Daniel Bates.
194         
195         WebHTMLView overrides some NSView internal methods to make sure that AppKit doesn't paint
196         subframes (WebKit controls subframe painting). The method signature of one of these changed in macOS
197         High Sierra, so match the new signature.
198
199         Also rename the 'rect' param to 'displayRect' to match AppKit code.
200
201         * WebView/WebHTMLView.mm:
202         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
203         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
204
205 2017-10-25  Youenn Fablet  <youenn@apple.com>
206
207         Enable ServiceWorker to fetch resources
208         https://bugs.webkit.org/show_bug.cgi?id=178673
209
210         Reviewed by Brady Eidson.
211
212         * WebCoreSupport/WebFrameLoaderClient.mm:
213         (WebFrameLoaderClient::pageID const):
214         (WebFrameLoaderClient::frameID const):
215         (WebFrameLoaderClient::sessionID const):
216
217         Added implementation to the new getters.
218         They are noop in the context of WK1.
219
220 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
221
222         Web Inspector: Enable WebKit logging configuration and display
223         https://bugs.webkit.org/show_bug.cgi?id=177027
224         <rdar://problem/33964767>
225
226         Reviewed by Joseph Pecoraro.
227
228         * WebCoreSupport/WebChromeClient.mm:
229         (stringForMessageSource): Deal with Media and WebRTC message sources.
230
231 2017-10-20  Antoine Quint  <graouts@apple.com>
232
233         [Web Animations] Provide basic timeline and animation interfaces
234         https://bugs.webkit.org/show_bug.cgi?id=178526
235
236         Reviewed by Dean Jackson.
237
238         Remove the WEB_ANIMATIONS compile-time flag.
239
240         * Configurations/FeatureDefines.xcconfig:
241         * WebView/WebPreferences.mm:
242         (+[WebPreferences initialize]):
243         * WebView/WebView.mm:
244         (-[WebView _preferencesChanged:]):
245
246 2017-10-19  Sam Weinig  <sam@webkit.org>
247
248         [Settings] Move global settings into their own file
249         https://bugs.webkit.org/show_bug.cgi?id=178512
250
251         Reviewed by Darin Adler.
252
253         Moves all global settigns out of SettingsBase and into the new DeprecatedGlobalSettings.
254
255         * WebCoreSupport/WebChromeClient.mm:
256         (WebChromeClient::supportsVideoFullscreen):
257         * WebView/WebDynamicScrollBarsView.mm:
258         (+[WebDynamicScrollBarsView _horizontalScrollerClass]):
259         (+[WebDynamicScrollBarsView _verticalScrollerClass]):
260         * WebView/WebPreferences.mm:
261         (+[WebPreferences initialize]):
262         * WebView/WebView.mm:
263         (-[WebView _commonInitializationWithFrameName:groupName:]):
264         (-[WebView _preferencesChanged:]):
265         (+[WebView _doNotStartObservingNetworkReachability]):
266
267 2017-10-17  Jiewen Tan  <jiewen_tan@apple.com>
268
269         Replace some stack raw pointers with RefPtrs within WebCore/html
270         https://bugs.webkit.org/show_bug.cgi?id=178201
271         <rdar://problem/34841692>
272
273         Reviewed by Ryosuke Niwa.
274
275         * DOM/DOM.mm:
276         (kit):
277         Change the type of node as toNode() is changed to return RefPtr.
278
279 2017-10-18  Chris Dumez  <cdumez@apple.com>
280
281         [Service Worker] Add stubs for Client / WindowClient / Clients
282         https://bugs.webkit.org/show_bug.cgi?id=178469
283
284         Reviewed by Youenn Fablet.
285
286         Rename PageVisiblityState to VisibilityState.
287
288         * WebView/WebView.mm:
289         (kit):
290
291 2017-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
292
293         Unreviewed, rolling out r223291.
294
295         See WebCore ChangeLog for more detail.
296
297         Reverted changeset:
298
299         "Remove Editor::simplifyMarkup"
300         https://bugs.webkit.org/show_bug.cgi?id=178271
301         https://trac.webkit.org/changeset/223291
302
303 2017-10-17  Keith Miller  <keith_miller@apple.com>
304
305         Change WebCore sources to work with unified source builds
306         https://bugs.webkit.org/show_bug.cgi?id=178229
307
308         Rubber stamped by Tim Horton.
309
310         * Configurations/FeatureDefines.xcconfig:
311
312 2017-10-16  Sam Weinig  <sam@webkit.org>
313
314         [Settings] Remove all custom code from Settings.h/cpp
315         https://bugs.webkit.org/show_bug.cgi?id=178330
316
317         Reviewed by Simon Fraser.
318
319         * WebView/WebPreferences.mm:
320         (+[WebPreferences initialize]):
321         
322             Update for naming changes of FrameFlattening now that it is an enum class.
323
324 2017-10-13  Alex Christensen  <achristensen@webkit.org>
325
326         Remove Editor::simplifyMarkup
327         https://bugs.webkit.org/show_bug.cgi?id=178271
328
329         Reviewed by Wenson Hsieh.
330
331         * WebView/WebView.mm:
332         (-[WebView _simplifyMarkup:endNode:]):
333
334 2017-10-12  Chris Dumez  <cdumez@apple.com>
335
336         [Mac] Add support for MouseEvent.buttons
337         https://bugs.webkit.org/show_bug.cgi?id=178214
338
339         Reviewed by Ryosuke Niwa.
340
341         * WebView/WebPDFView.mm:
342         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
343
344 2017-10-11  Sam Weinig  <sam@webkit.org>
345
346         Remove out-parameter variants of copyToVector
347         https://bugs.webkit.org/show_bug.cgi?id=178155
348
349         Reviewed by Tim Horton.
350
351         * Plugins/WebNetscapePluginView.mm:
352         (-[WebNetscapePluginView destroyPlugin]):
353         * WebView/WebHTMLRepresentation.mm:
354         (newArrayWithStrings):
355
356             Replace out-parameter based copyToVector, with one that returns a Vector.
357
358 2017-10-11  Ryosuke Niwa  <rniwa@webkit.org>
359
360         Sanitize URL in pasteboard for other applications and cross origin content
361         https://bugs.webkit.org/show_bug.cgi?id=178060
362         <rdar://problem/34874518>
363
364         Reviewed by Wenson Hsieh.
365
366         * WebCoreSupport/WebPlatformStrategies.h:
367         * WebCoreSupport/WebPlatformStrategies.mm:
368         (WebPlatformStrategies::typesSafeForDOMToReadAndWrite):
369
370 2017-10-11  Chris Dumez  <cdumez@apple.com>
371
372         Modernize Geolocation code
373         https://bugs.webkit.org/show_bug.cgi?id=178148
374
375         Reviewed by Ryosuke Niwa.
376
377         * WebCoreSupport/WebGeolocationClient.h:
378         * WebCoreSupport/WebGeolocationClient.mm:
379         (WebGeolocationClient::lastPosition):
380         * WebView/WebGeolocationPosition.mm:
381         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
382         (core):
383         (-[WebGeolocationPosition initWithTimestamp:latitude:longitude:accuracy:]):
384         (-[WebGeolocationPosition initWithGeolocationPosition:]):
385         * WebView/WebGeolocationPositionInternal.h:
386
387 2017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
388
389         Enable custom pasteboard data in DumpRenderTree and WebKitTestRunner
390         https://bugs.webkit.org/show_bug.cgi?id=178154
391
392         Reviewed by Wenson Hsieh.
393
394         Enable custom pasteboard data by default.
395
396         * WebView/WebPreferenceKeysPrivate.h:
397         * WebView/WebPreferences.mm:
398         (+[WebPreferences initialize]):
399         (-[WebPreferences customPasteboardDataEnabled]): Added.
400         (-[WebPreferences setCustomPasteboardDataEnabled:]): Added.
401         * WebView/WebPreferencesPrivate.h:
402         * WebView/WebView.mm:
403         (-[WebView _preferencesChanged:]):
404
405 2017-10-10  Sam Weinig  <sam@webkit.org>
406
407         Replace copyKeysToVector/copyValuesToVector with copyToVector(map.keys())/copyToVector(map.values())
408         https://bugs.webkit.org/show_bug.cgi?id=178102
409
410         Reviewed by Tim Horton.
411
412         * History/WebHistory.mm:
413         (-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):
414         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
415         (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
416         * WebCoreSupport/WebUserMediaClient.mm:
417         (WebUserMediaClient::pageDestroyed):
418
419 2017-10-09  Robin Morisset  <rmorisset@apple.com>
420
421         Make the names of the options consistent
422         https://bugs.webkit.org/show_bug.cgi?id=177933
423
424         Reviewed by Saam Barati.
425
426         * WebView/WebFrame.h:
427         * WebView/WebHTMLView.mm:
428         (-[WebHTMLView setMarkedText:selectedRange:]):
429         * WebView/WebView.h:
430
431 2017-10-06  Wenson Hsieh  <wenson_hsieh@apple.com>
432
433         [iOS] Tweak support for classifying form controls (followup to r222487)
434         https://bugs.webkit.org/show_bug.cgi?id=177917
435         <rdar://problem/34820122>
436
437         Reviewed by Dean Jackson.
438
439         Implement _autofillContext in legacy WebKit, and remove the two previous SPI hooks.
440
441         * DOM/DOMHTMLInputElement.mm:
442         (-[DOMHTMLInputElement _autofillContext]):
443         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]): Deleted.
444         (-[DOMHTMLInputElement representingPageURL]): Deleted.
445
446 2017-10-05  Keith Miller  <keith_miller@apple.com>
447
448         Unreviewed, tapi builds without optimization so we should have TAPI passes -DRELEASE_WITHOUT_OPTIMIZATIONS.
449
450         * Configurations/WebKitLegacy.xcconfig:
451
452 2017-10-05  Jer Noble  <jer.noble@apple.com>
453
454         [Cocoa] Enable ENABLE_ENCRYPTED_MEDIA build-time setting
455         https://bugs.webkit.org/show_bug.cgi?id=177261
456
457         Reviewed by Eric Carlson.
458
459         * Configurations/FeatureDefines.xcconfig:
460
461 2017-10-05  Chris Dumez  <cdumez@apple.com>
462
463         Drop unused parameters for CookiesStrategy::cookiesEnabled()
464         https://bugs.webkit.org/show_bug.cgi?id=177957
465
466         Reviewed by Alex Christensen.
467
468         * WebCoreSupport/WebPlatformStrategies.h:
469         * WebCoreSupport/WebPlatformStrategies.mm:
470         (WebPlatformStrategies::cookiesEnabled):
471
472 2017-10-05  Youenn Fablet  <youenn@apple.com>
473
474         Make LibWebRTCProvider port agnostic
475         https://bugs.webkit.org/show_bug.cgi?id=177747
476
477         Reviewed by Alex Christensen & Alex Garcia.
478
479         * WebView/WebView.mm:
480         (-[WebView _commonInitializationWithFrameName:groupName:]):
481         (-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
482
483 2017-10-04  Alex Christensen  <achristensen@webkit.org>
484
485         Stop linking with WebKitSystemInterface
486         https://bugs.webkit.org/show_bug.cgi?id=177915
487
488         Reviewed by Antti Koivisto.
489
490         * Configurations/DebugRelease.xcconfig:
491         * Configurations/WebKitLegacy.xcconfig:
492
493 2017-10-04  Alex Christensen  <achristensen@webkit.org>
494
495         Remove unnecessary includes of WebKitSystemInterface on Cocoa platforms
496         https://bugs.webkit.org/show_bug.cgi?id=177912
497
498         Reviewed by Saam Barati.
499
500         * Carbon/CarbonUtils.m:
501         * Carbon/CarbonWindowAdapter.mm:
502         * Carbon/HIWebView.mm:
503         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
504         * Misc/WebNSFileManagerExtras.mm:
505         * Misc/WebNSPasteboardExtras.mm:
506         * Misc/WebNSURLExtras.mm:
507         * Plugins/Hosted/HostedNetscapePluginStream.mm:
508         * Plugins/Hosted/NetscapePluginHostManager.mm:
509         * Plugins/Hosted/NetscapePluginHostProxy.mm:
510         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
511         * Plugins/Hosted/WebHostedNetscapePluginView.h:
512         * Plugins/Hosted/WebTextInputWindowController.m:
513         * Plugins/WebBaseNetscapePluginView.mm:
514         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
515         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
516         * Plugins/WebNetscapePluginStream.mm:
517         * Plugins/WebNetscapePluginView.mm:
518         * Plugins/WebPluginDatabase.mm:
519         * WebCoreSupport/PopupMenuMac.mm:
520         * WebCoreSupport/WebChromeClient.mm:
521         * WebCoreSupport/WebFrameLoaderClient.mm:
522         * WebCoreSupport/WebInspectorClient.mm:
523         * WebCoreSupport/WebPlatformStrategies.mm:
524         * WebCoreSupport/WebSystemInterface.mm:
525         * WebView/WebDynamicScrollBarsView.mm:
526         * WebView/WebFrame.mm:
527         * WebView/WebFrameView.mm:
528         * WebView/WebFullScreenController.mm:
529         * WebView/WebHTMLView.mm:
530         * WebView/WebPreferences.mm:
531         * WebView/WebView.mm:
532
533 2017-09-29  Alexey Proskuryakov  <ap@apple.com>
534
535         Follow-up to https://trac.webkit.org/r222239 to fix crashes.
536         rdar://problem/34705779
537
538         Addressing review comments that I somehow landed without.
539
540         * WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
541
542 2017-09-29  Chris Dumez  <cdumez@apple.com>
543
544         Split some logic out of VisitedLinkStore and make it reusable
545         https://bugs.webkit.org/show_bug.cgi?id=177575
546
547         Reviewed by Alex Christensen.
548
549         * WebCoreSupport/WebVisitedLinkStore.h:
550         * WebCoreSupport/WebVisitedLinkStore.mm:
551         (WebVisitedLinkStore::addVisitedLink):
552         (WebVisitedLinkStore::removeVisitedLink):
553         (WebVisitedLinkStore::isLinkVisited):
554         (WebVisitedLinkStore::addVisitedLinkHash):
555
556 2017-09-28  Jonathan Bedard  <jbedard@apple.com>
557
558         Build fix for High Sierra 32 bit Mac
559         https://bugs.webkit.org/show_bug.cgi?id=177551
560         <rdar://problem/34690283>
561
562         Reviewed by Alexey Proskuryakov.
563
564         Some assertions have been removed from the SDK. Replace these assertions with equivalent
565         WTF assert code.  Since the files in this patch are using tabs, some style changes were
566         also made.
567
568         * Carbon/CarbonWindowAdapter.mm:
569         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
570         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
571         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
572         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
573         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
574         (-[CarbonWindowAdapter dealloc]):
575         (-[CarbonWindowAdapter windowRef]):
576         (-[CarbonWindowAdapter _hasWindowRef]):
577         (-[CarbonWindowAdapter _managesWindowRef]):
578         (-[CarbonWindowAdapter _removeWindowRef]):
579         (-[CarbonWindowAdapter _carbonWindowClass]):
580         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
581         (-[CarbonWindowAdapter sendSuperEvent:]):
582         (-[CarbonWindowAdapter relinquishFocus]):
583         (-[CarbonWindowAdapter _cancelKey:]):
584         (-[CarbonWindowAdapter _commonAwake]):
585         (-[CarbonWindowAdapter _destroyRealWindow:]):
586         (-[CarbonWindowAdapter _oldPlaceWindow:]):
587         (-[CarbonWindowAdapter _termWindowIfOwner]):
588         (-[CarbonWindowAdapter _windowMovedToRect:]):
589         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
590         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
591         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
592         (-[CarbonWindowAdapter canBecomeKeyWindow]):
593         (-[CarbonWindowAdapter canBecomeMainWindow]):
594         (-[CarbonWindowAdapter encodeWithCoder:]):
595         (-[CarbonWindowAdapter initWithCoder:]):
596         (-[CarbonWindowAdapter setContentView:]):
597         (-[CarbonWindowAdapter worksWhenModal]):
598         (-[CarbonWindowAdapter _setModalWindowLevel]):
599         (-[CarbonWindowAdapter _clearModalWindowLevel]):
600         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
601         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
602         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
603         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
604         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
605         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
606         (NSCarbonWindowHandleEvent):
607         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
608         (-[CarbonWindowAdapter _growBoxRect]):
609         * Carbon/HIWebView.mm:
610         (HIWebViewGetWebView):
611         (HIWebViewConstructor):
612         (HIWebViewDestructor):
613         (HIWebViewRegisterClass):
614         (GetBehaviors):
615         (Draw):
616         (HitTest):
617         (GetRegion):
618         (GetWindowRef):
619         (CreateNSEventAdoptingCGEvent):
620         (CopyEventCGEvent):
621         (CreateNSEventWithCarbonClickEvent):
622         (Click):
623         (CreateNSEventWithCarbonEvent):
624         (MouseUp):
625         (CreateNSEventWithCarbonMouseMoveEvent):
626         (MouseMoved):
627         (MouseDragged):
628         (MouseWheelMoved):
629         (ContextMenuClick):
630         (GetKind):
631         (BoundsChanged):
632         (OwningWindowChanged):
633         (WindowHandler):
634         (SyncFrame):
635         (SetFocusPart):
636         (AdvanceFocus):
637         (RelinquishFocus):
638         (ActiveStateChanged):
639         (ProcessCommand):
640         (UpdateCommandStatus):
641         (_NSSelectorForHICommand):
642         (HIWebViewEventHandler):
643         (StartUpdateObserver):
644         (StopUpdateObserver):
645         (UpdateObserver):
646
647 2017-09-27  Wenson Hsieh  <wenson_hsieh@apple.com>
648
649         Drag event DataTransfer has unexpected types "dyn.ah62d4..."
650         https://bugs.webkit.org/show_bug.cgi?id=172526
651         <rdar://problem/32396081>
652
653         Reviewed by Ryosuke Niwa.
654
655         Adjust for changes in WebCore. See WebCore ChangeLog for more details.
656
657         * WebCoreSupport/WebPlatformStrategies.h:
658         * WebCoreSupport/WebPlatformStrategies.mm:
659         (WebPlatformStrategies::webExposedTypes):
660         (WebPlatformStrategies::writeCustomData):
661
662 2017-09-27  Matt Lewis  <jlewis3@apple.com>
663
664         Unreviewed, rolling out r222567.
665
666         This broke and internal build.
667
668         Reverted changeset:
669
670         "Build fix for High Sierra 32 bit Mac"
671         https://bugs.webkit.org/show_bug.cgi?id=177551
672         http://trac.webkit.org/changeset/222567
673
674 2017-09-27  Jonathan Bedard  <jbedard@apple.com>
675
676         Build fix for High Sierra 32 bit Mac
677         https://bugs.webkit.org/show_bug.cgi?id=177551
678         <rdar://problem/34690283>
679
680         Reviewed by Alexey Proskuryakov.
681
682         Some assertions have been removed from the SDK. Replace these assertions with equivalent
683         WTF assert code.  Since the files in this patch are using tabs, some style changes were
684         also made.
685
686         * Carbon/CarbonWindowAdapter.mm:
687         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
688         (-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
689         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
690         (-[CarbonWindowAdapter setViewsNeedDisplay:]):
691         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
692         (-[CarbonWindowAdapter dealloc]):
693         (-[CarbonWindowAdapter windowRef]):
694         (-[CarbonWindowAdapter _hasWindowRef]):
695         (-[CarbonWindowAdapter _managesWindowRef]):
696         (-[CarbonWindowAdapter _removeWindowRef]):
697         (-[CarbonWindowAdapter _carbonWindowClass]):
698         (-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
699         (-[CarbonWindowAdapter sendSuperEvent:]):
700         (-[CarbonWindowAdapter relinquishFocus]):
701         (-[CarbonWindowAdapter _cancelKey:]):
702         (-[CarbonWindowAdapter _commonAwake]):
703         (-[CarbonWindowAdapter _destroyRealWindow:]):
704         (-[CarbonWindowAdapter _oldPlaceWindow:]):
705         (-[CarbonWindowAdapter _termWindowIfOwner]):
706         (-[CarbonWindowAdapter _windowMovedToRect:]):
707         (-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
708         (-[CarbonWindowAdapter selectKeyViewFollowingView:]):
709         (-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
710         (-[CarbonWindowAdapter canBecomeKeyWindow]):
711         (-[CarbonWindowAdapter canBecomeMainWindow]):
712         (-[CarbonWindowAdapter encodeWithCoder:]):
713         (-[CarbonWindowAdapter initWithCoder:]):
714         (-[CarbonWindowAdapter setContentView:]):
715         (-[CarbonWindowAdapter worksWhenModal]):
716         (-[CarbonWindowAdapter _setModalWindowLevel]):
717         (-[CarbonWindowAdapter _clearModalWindowLevel]):
718         (-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
719         (-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
720         (-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
721         (-[CarbonWindowAdapter _handleRootBoundsChanged]):
722         (-[CarbonWindowAdapter _handleContentBoundsChanged]):
723         (-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
724         (NSCarbonWindowHandleEvent):
725         (-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
726         (-[CarbonWindowAdapter _growBoxRect]):
727         * Carbon/HIWebView.mm:
728         (HIWebViewGetWebView):
729         (HIWebViewConstructor):
730         (HIWebViewDestructor):
731         (HIWebViewRegisterClass):
732         (GetBehaviors):
733         (Draw):
734         (HitTest):
735         (GetRegion):
736         (GetWindowRef):
737         (CreateNSEventAdoptingCGEvent):
738         (CopyEventCGEvent):
739         (CreateNSEventWithCarbonClickEvent):
740         (Click):
741         (CreateNSEventWithCarbonEvent):
742         (MouseUp):
743         (CreateNSEventWithCarbonMouseMoveEvent):
744         (MouseMoved):
745         (MouseDragged):
746         (MouseWheelMoved):
747         (ContextMenuClick):
748         (GetKind):
749         (BoundsChanged):
750         (OwningWindowChanged):
751         (WindowHandler):
752         (SyncFrame):
753         (SetFocusPart):
754         (AdvanceFocus):
755         (RelinquishFocus):
756         (ActiveStateChanged):
757         (ProcessCommand):
758         (UpdateCommandStatus):
759         (_NSSelectorForHICommand):
760         (HIWebViewEventHandler):
761         (StartUpdateObserver):
762         (StopUpdateObserver):
763         (UpdateObserver):
764
765 2017-09-25  Alex Christensen  <achristensen@webkit.org>
766
767         Make PolicyAction an encodable enum class
768         https://bugs.webkit.org/show_bug.cgi?id=177480
769
770         Reviewed by Antti Koivisto.
771
772         * Plugins/WebPluginContainerCheck.mm:
773         (-[WebPluginContainerCheck _continueWithPolicy:]):
774         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
775         * WebCoreSupport/WebFrameLoaderClient.mm:
776         (-[WebFramePolicyListener invalidate]):
777         (-[WebFramePolicyListener ignore]):
778         (-[WebFramePolicyListener download]):
779         (-[WebFramePolicyListener use]):
780         (-[WebFramePolicyListener continue]):
781         * WebView/WebPolicyDelegate.mm:
782         (-[WebPolicyDecisionListener use]):
783         (-[WebPolicyDecisionListener ignore]):
784         (-[WebPolicyDecisionListener download]):
785
786 2017-09-25  Frederik Riedel  <riedel@apple.com>
787
788         Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI
789         https://bugs.webkit.org/show_bug.cgi?id=174394
790         <rdar://problem/33183504>
791
792         Reviewed by Ryosuke Niwa.
793
794         * DOM/DOMHTMLInputElement.h:
795         * DOM/DOMHTMLInputElement.mm:
796         (-[DOMHTMLInputElement acceptsAutofilledLoginCredentials]):
797         Determines if this HTMLInputElement is part of a login screen.
798         (-[DOMHTMLInputElement representingPageUrl]):
799         Returns the webpage's URL that is currently displayed in the Web View.
800         (-[DOMHTMLInputElement insertTextSuggestion:]):
801         Inserts login credentials into the Web View.
802
803 2017-09-25  Sam Weinig  <sam@webkit.org>
804
805         Remove unused EditorClient functions
806         https://bugs.webkit.org/show_bug.cgi?id=177463
807
808         Reviewed by Alex Christensen.
809
810         Remove unused EditorClient functions.
811
812         * WebCoreSupport/WebEditorClient.h:
813         * WebCoreSupport/WebEditorClient.mm:
814         (WebEditorClient::canonicalizeURL): Deleted.
815         (WebEditorClient::canonicalizeURLString): Deleted.
816         (WebEditorClient::writeDataToPasteboard): Deleted.
817         (WebEditorClient::supportedPasteboardTypesForCurrentSelection): Deleted.
818         (WebEditorClient::readDataFromPasteboard): Deleted.
819         (WebEditorClient::pasteboardChangeCount): Deleted.
820
821 2017-09-25  Alex Christensen  <achristensen@webkit.org>
822
823         Stop using PolicyCallback
824         https://bugs.webkit.org/show_bug.cgi?id=176088
825
826         Reviewed by Andy Estes.
827
828         * WebCoreSupport/WebFrameLoaderClient.mm:
829         (-[WebFramePolicyListener invalidate]):
830         (-[WebFramePolicyListener receivedPolicyDecision:]):
831
832 2017-09-25  Sam Weinig  <sam@webkit.org>
833
834         Remove unnecessary userVisibleString EditorClient function
835         https://bugs.webkit.org/show_bug.cgi?id=177456
836
837         Reviewed by Dan Bernstein.
838
839         * WebCoreSupport/WebEditorClient.h:
840         * WebCoreSupport/WebEditorClient.mm:
841         (WebEditorClient::userVisibleString): Deleted.
842
843             Remove userVisibleString client function.
844
845 2017-09-25  Alex Christensen  <achristensen@webkit.org>
846
847         Separate form submission from PolicyChecker infrastructure
848         https://bugs.webkit.org/show_bug.cgi?id=177396
849
850         Reviewed by Geoffrey Garen.
851
852         * WebCoreSupport/WebFrameLoaderClient.h:
853         * WebCoreSupport/WebFrameLoaderClient.mm:
854         (WebFrameLoaderClient::dispatchWillSubmitForm):
855
856 2017-09-22  Zalan Bujtas  <zalan@apple.com>
857
858         WeakPtrFactory should populate m_ref lazily.
859         https://bugs.webkit.org/show_bug.cgi?id=177375
860
861         Reviewed by Geoffrey Garen.
862
863         * WebCoreSupport/WebEditorClient.mm:
864         (WebEditorClient::WebEditorClient):
865         (WebEditorClient::requestCandidatesForSelection):
866
867 2017-09-22  Chris Dumez  <cdumez@apple.com>
868
869         Use high resolution timestamp for event time
870         https://bugs.webkit.org/show_bug.cgi?id=154246
871         <rdar://problem/34333304>
872
873         Reviewed by Ryosuke Niwa.
874
875         Use WallTime / MonotonicTime instead of double type for clarity.
876
877         * DOM/DOMEvent.mm:
878         (-[DOMEvent timeStamp]):
879         * WebView/WebFrame.mm:
880         (-[WebFrame _dragSourceEndedAt:operation:]):
881         * WebView/WebPDFView.mm:
882         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
883
884 2017-09-21  Ryosuke Niwa  <rniwa@webkit.org>
885
886         Enable dataTransfer.items on macOS and iOS
887         https://bugs.webkit.org/show_bug.cgi?id=177335
888
889         Reviewed by Sam Weinig.
890
891         * WebView/WebPreferences.mm:
892         (+[WebPreferences initialize]):
893
894 2017-09-20  Joseph Pecoraro  <pecoraro@apple.com>
895
896         Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
897         https://bugs.webkit.org/show_bug.cgi?id=177101
898         <rdar://problem/34500648>
899
900         Reviewed by Brian Burg.
901
902         * WebInspector/WebNodeHighlight.mm:
903         Ensure we close the window that we have just removed.
904
905 2017-09-20  Antti Koivisto  <antti@apple.com>
906
907         Remove DOM and styling support for CSS Regions
908         https://bugs.webkit.org/show_bug.cgi?id=177221
909
910         Reviewed by Andreas Kling.
911
912         * Configurations/FeatureDefines.xcconfig:
913         * DOM/DOMCSS.mm:
914         (kitClass):
915         * DOM/DOMElement.mm:
916         (-[DOMElement webkitRegionOverset]): Deleted.
917
918 2017-09-19  Alexey Proskuryakov  <ap@apple.com>
919
920         Layering violation in Editor::createFragment
921         https://bugs.webkit.org/show_bug.cgi?id=176123
922
923         Reviewed by Darin Adler.
924
925         * Misc/WebNSURLExtras.h:
926         * Misc/WebNSURLExtras.mm:
927         * WebView/WebFrame.mm:
928         * WebView/WebHTMLView.mm:
929         Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().
930
931         * WebCoreSupport/WebEditorClient.mm:
932         (_WebCreateFragment): Added a stub implementation for older OSes. This is needed
933         because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
934         way to avoid exporting the symbol just on newer OSes.
935
936 2017-09-19  Ryosuke Niwa  <rniwa@webkit.org>
937
938         On iOS, getData can't get text set by setData during copy event
939         https://bugs.webkit.org/show_bug.cgi?id=176980
940         <rdar://problem/34453915>
941
942         Reviewed by Darin Adler.
943
944         * WebCoreSupport/WebPlatformStrategies.h:
945         * WebCoreSupport/WebPlatformStrategies.mm:
946         (WebPlatformStrategies::copy): Deleted.
947
948 2017-09-18  Andy Estes  <aestes@apple.com>
949
950         [Mac] Upstream miscellaneous WebKitSystemInterface functions
951         https://bugs.webkit.org/show_bug.cgi?id=177029
952
953         Reviewed by Alex Christensen.
954
955         * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
956         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
957         * Plugins/Hosted/NetscapePluginHostProxy.mm:
958         (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
959         * WebCoreSupport/PopupMenuMac.mm:
960         (PopupMenuMac::show):
961         * WebCoreSupport/WebSystemInterface.mm:
962         (InitWebCoreSystemInterface):
963         * WebView/WebHTMLView.mm:
964         (-[WebHTMLView setDataSource:]):
965         (-[WebHTMLView attachRootLayer:]):
966         * WebView/WebView.mm:
967         (-[WebView _needsAdobeFrameReloadingQuirk]):
968         (-[WebView _needsLinkElementTextCSSQuirk]):
969         (-[WebView _needsIsLoadingInAPISenseQuirk]):
970         (-[WebView _needsFrameLoadDelegateRetainQuirk]):
971         (-[WebView _preferencesChanged:]):
972
973 2017-09-15  Andy Estes  <aestes@apple.com>
974
975         [Cocoa] Upstream MediaRemote and VideoToolbox WebKitSystemInterface functions
976         https://bugs.webkit.org/show_bug.cgi?id=176953
977
978         Reviewed by Eric Carlson.
979
980         * WebCoreSupport/WebSystemInterface.mm:
981         (InitWebCoreSystemInterface):
982
983 2017-09-14  Andy Estes  <aestes@apple.com>
984
985         [Mac] Upstream SpeechSynthesis-related WebKitSystemInterface functions
986         https://bugs.webkit.org/show_bug.cgi?id=176931
987
988         Reviewed by Joseph Pecoraro.
989
990         * WebCoreSupport/WebSystemInterface.mm:
991         (InitWebCoreSystemInterface):
992
993 2017-09-14  Yusuke Suzuki  <utatane.tea@gmail.com>
994
995         [JSC] Add PrivateSymbolMode::{Include,Exclude} for PropertyNameArray
996         https://bugs.webkit.org/show_bug.cgi?id=176867
997
998         Reviewed by Sam Weinig.
999
1000         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1001         (WebKit::NetscapePluginInstanceProxy::enumerate):
1002
1003 2017-09-13  Andy Estes  <aestes@apple.com>
1004
1005         [CF] Upstream CFNetwork-related WebKitSystemInterface functions
1006         https://bugs.webkit.org/show_bug.cgi?id=176729
1007
1008         Reviewed by Alex Christensen.
1009
1010         * WebCoreSupport/WebSystemInterface.mm:
1011         (InitWebCoreSystemInterface):
1012         * WebView/WebView.mm:
1013         (+[WebView _setCacheModel:]):
1014
1015 2017-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1016
1017         Refactor WebContentReader out of EditorMac and EditorIOS
1018         https://bugs.webkit.org/show_bug.cgi?id=176770
1019
1020         Reviewed by Sam Weinig.
1021
1022         * WebCoreSupport/WebEditorClient.mm:
1023
1024 2017-09-12  Ryosuke Niwa  <rniwa@webkit.org>
1025
1026         Dragging & dropping a file creates an attachment element even when it's disabled
1027         https://bugs.webkit.org/show_bug.cgi?id=176769
1028
1029         Reviewed by Tim Horton.
1030
1031         * WebView/WebView.mm:
1032         (-[WebView _preferencesChanged:]):
1033
1034 2017-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1035
1036         [iOS DnD] Support DataTransfer.setDragImage when starting a drag on iOS
1037         https://bugs.webkit.org/show_bug.cgi?id=176721
1038         <rdar://problem/34373660>
1039
1040         Reviewed by Tim Horton.
1041
1042         Rename elementBounds => dragPreviewFrameInRootViewCoordinates. (Note: Unfortunately, _draggedElementBounds in
1043         WebViewPrivate.h can't be renamed yet, due to binary and SDK compatibility with UIKit).
1044
1045         * WebView/WebView.mm:
1046         (-[WebView _startDrag:]):
1047         (-[WebView _draggedElementBounds]):
1048         (-[WebView _endedDataInteraction:global:]):
1049         * WebView/WebViewData.h:
1050
1051 2017-09-11  Andy Estes  <aestes@apple.com>
1052
1053         [Mac] Upstream QTKit-related WebKitSystemInterface functions
1054         https://bugs.webkit.org/show_bug.cgi?id=176472
1055
1056         Reviewed by Eric Carlson.
1057
1058         * WebCoreSupport/WebSystemInterface.mm:
1059         (InitWebCoreSystemInterface):
1060
1061 2017-09-09  Mark Lam  <mark.lam@apple.com>
1062
1063         Avoid duplicate computations of ExecState::vm().
1064         https://bugs.webkit.org/show_bug.cgi?id=176647
1065
1066         Reviewed by Saam Barati.
1067
1068         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1069         (WebKit::NetscapePluginInstanceProxy::invokeDefault):
1070         (WebKit::NetscapePluginInstanceProxy::construct):
1071         (WebKit::NetscapePluginInstanceProxy::setProperty):
1072         (WebKit::NetscapePluginInstanceProxy::removeProperty):
1073         (WebKit::NetscapePluginInstanceProxy::enumerate):
1074         * Plugins/Hosted/ProxyInstance.mm:
1075         (WebKit::ProxyRuntimeMethod::create):
1076
1077 2017-09-08  Commit Queue  <commit-queue@webkit.org>
1078
1079         Unreviewed, rolling out r221773.
1080         https://bugs.webkit.org/show_bug.cgi?id=176614
1081
1082         This caused build failures. (Requested by mlewis13 on
1083         #webkit).
1084
1085         Reverted changeset:
1086
1087         "[Mac] Upstream QTKit-related WebKitSystemInterface functions"
1088         https://bugs.webkit.org/show_bug.cgi?id=176472
1089         http://trac.webkit.org/changeset/221773
1090
1091 2017-09-07  Andy Estes  <aestes@apple.com>
1092
1093         [Mac] Upstream QTKit-related WebKitSystemInterface functions
1094         https://bugs.webkit.org/show_bug.cgi?id=176472
1095
1096         Reviewed by Eric Carlson.
1097
1098         * WebCoreSupport/WebSystemInterface.mm:
1099         (InitWebCoreSystemInterface):
1100
1101 2017-09-07  Myles C. Maxfield  <mmaxfield@apple.com>
1102
1103         [PAL] Unify PlatformUserPreferredLanguages.h with Language.h
1104         https://bugs.webkit.org/show_bug.cgi?id=176561
1105
1106         Reviewed by Brent Fulgham.
1107
1108         * Misc/WebNSUserDefaultsExtras.mm:
1109
1110 2017-09-07  Alex Christensen  <achristensen@webkit.org>
1111
1112         Modernize Geolocation code
1113         https://bugs.webkit.org/show_bug.cgi?id=176496
1114
1115         Reviewed by Andy Estes.
1116
1117         * WebCoreSupport/WebGeolocationClient.h:
1118         * WebCoreSupport/WebGeolocationClient.mm:
1119         (WebGeolocationClient::requestPermission):
1120         (-[WebGeolocationPolicyListener initWithGeolocation:]):
1121         (-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
1122         (-[WebGeolocationProviderInitializationListener initWithGeolocation:]):
1123         * WebView/WebView.mm:
1124         (-[WebView _commonInitializationWithFrameName:groupName:]):
1125         (-[WebView _geolocationDidFailWithMessage:]):
1126
1127 2017-09-05  Tim Horton  <timothy_horton@apple.com>
1128
1129         Remove some unused bits of code and resources
1130         https://bugs.webkit.org/show_bug.cgi?id=176275
1131
1132         Reviewed by Dan Bernstein.
1133
1134         * Misc/WebNSFileManagerExtras.mm:
1135         Include FileSystem instead of FileSystemIOS.
1136
1137 2017-09-03  Darin Adler  <darin@apple.com>
1138
1139         [Cocoa] Tidy a few things in legacy WebHTMLView
1140         https://bugs.webkit.org/show_bug.cgi?id=176280
1141
1142         Reviewed by Dan Bernstein.
1143
1144         * WebCoreSupport/WebChromeClient.mm:
1145         (WebChromeClient::attachRootGraphicsLayer): Made this function Mac-only, because the
1146         methods it calls on WebHTMLView were doing nothing on iOS.
1147
1148         * WebView/WebFrame.mm:
1149         (-[WebFrame _paintBehaviorForDestinationContext:]): Changed iOS code so that it no longer
1150         depends on -[WebHTMLView _web_isDrawingIntoLayer], which always returned YES on iOS.
1151
1152         * WebView/WebHTMLView.mm: Define WebEvent on both iOS and Mac so more event handling
1153         code can be shared without #if below. Use #if PLATFORM(MAC) instead of #if !PLATFORM(IOS)
1154         in a lot more places. Move many of the SPI declarations up to the top in alphabetical
1155         order. Removed all sorts of unused things. Made more code and fields Mac-only where
1156         what was compiled was doing nothing on iOS and it makes the resulting code simpler.
1157         Use RetainPtr instead of writing retain/release wherever possible.
1158         (+[WebMenuTarget sharedMenuTarget]): Moved global inside this method and used C++
1159         initialization for it. Removed various unused methods and declarations of methods.
1160         (promisedDataClient): Use NeverDestroyed instead of just doing a "new" on the heap.
1161         (-[WebHTMLView _imageExistsAtPaths:]): Deleted.
1162         (-[WebHTMLView _documentFragmentWithPaths:]): Use RetainPtr and modern for loop.
1163         (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Use C++ initialization,
1164         and remove CFRetain no longer needed since we don't support garbage collection any more.
1165         (uniqueURLWithRelativePart): Simplified using [NSUUID UUID].
1166         (-[WebHTMLView _plainTextFromPasteboard:]): Simplified with RetainPtr.
1167         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
1168         (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
1169         (-[WebHTMLView _removeWindowObservers]): Removed code dealing with empty
1170         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
1171         (-[WebHTMLView _shouldDeleteRange:]): Deleted. Was unused.
1172         (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):
1173         Simplified with stringByReplacingOccurrencesOfString and modern string literal syntax.
1174         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
1175         (-[WebHTMLView _web_setPrintingModeRecursive:adjustViewSize:]): Added. Helper method so
1176         the next three methhods can be super-simple. Used RetainPtr and a modern for loop to make
1177         this method simpler than the functions it replaced. Also got rid of the enumeratingSubviews
1178         debug flag; we haven't used it for years and it's not clearly helpful.
1179         (-[WebHTMLView _web_setPrintingModeRecursive]): Turned into a one-liner with the above.
1180         (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto.
1181         (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto.
1182         (-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]): Moved from the
1183         WebInternal category to the WebHTMLViewFileInternal category so it can be called by
1184         two additional methods in the WebPrivate category and still be called by the two
1185         methods in the WebInternal category that were already using it.
1186         (-[WebHTMLView didAddSubview:]): Deleted.
1187         (-[WebHTMLView _insideAnotherHTMLView]): Deleted.
1188         (-[WebHTMLView _clearLastHitViewIfSelf]): Deleted. Inlined the implementation in the one
1189         place this was called, the close method.
1190         (-[WebHTMLView _setToolTip:]): Simplified with RetainPtr.
1191         (-[WebHTMLView pasteboard:provideDataForType:]): Ditto.
1192         (-[WebHTMLView _autoscroll]): Simplified by making this Mac-only.
1193         (-[WebHTMLView _hasHTMLDocument]): Deleted. The one caller was removed a long time ago.
1194         (-[WebHTMLView _web_documentFragmentFromPasteboard:pasteboardType:imageMIMEType:]):
1195         Added helper method to make the one below simpler.
1196         (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
1197         Compared pasteboard type strings using isEqualToString: rather than using == since
1198         we want to actually compare the string contents. Also updated to use modern for loop,
1199         renamed a local variable from "s" to "localSubresources", and factored out the handling
1200         of three image types to use the helper method above.
1201         (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]): Rewrite using the
1202         _web_makePluginSubviewsPerformSelector:withObject: method.
1203         (-[WebHTMLView _resumeNullEventsForAllNetscapePlugins]): Ditto.
1204         (-[NSView _web_addDescendentWebHTMLViewsToArray:]): Fixed spelling to use the adjective
1205         "descendent" rather than the noun "descendant". Also removed Mac-only optimization to
1206         not call the -[NSView subviews] method to make this identical on both platforms and used
1207         a modern for loop.
1208         (-[NSMutableDictionary _web_setObjectIfNotNil:forKey:]): Deleted.
1209         (-[WebHTMLView acceptsFirstResponder]): Reduced amount of platform-specific code by
1210         defining WebEventMouseDown as a synonym for NSEventTypeLeftMouseDown on Mac.
1211         (-[WebHTMLView addWindowObservers]): Removed code dealing with empty
1212         methods windowWillOrderOnScreen: and windowWillOrderOffScreen:.
1213         (-[WebHTMLView willRemoveSubview:]): Removed the enumeratingSubviews check.
1214         (-[WebHTMLView drawSingleRect:]): Rearranged this method to make it clearer that most
1215         of it is Mac-only.
1216         (-[WebHTMLView windowWillOrderOnScreen:]): Deleted. All the current version of this
1217         method did was call itself on the main thread, and do nothing if called on main thread.
1218         (-[WebHTMLView windowWillOrderOffScreen:]): Deleted. Ditto.
1219         (-[WebHTMLView _isSelectionEvent:]): Merged macOS and iOS versions.
1220         (-[WebHTMLView resignFirstResponder]): Removed iOS-specific code in the macOS-specific
1221         half of this method.
1222         (-[WebHTMLView setDataSource:]): Simplified using RetainPtr.
1223         (-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:originalPageWidth:originalPageHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
1224         Simplified using a modern for loop and RetainPtr.
1225         (-[WebHTMLView knowsPageRange:]): Simplified using RetainPtr.
1226         (-[WebHTMLView keyDown:]): Ditto.
1227         (-[WebHTMLView _selectionStartFontAttributesAsRTF]): Ditto.
1228         (-[WebHTMLView performKeyEquivalent:]): Ditto.
1229         (-[WebHTMLView _styleForAttributeChange:]): Ditto.
1230         (-[WebHTMLView complete:]): Ditto.
1231         (-[WebHTMLView _windowChangedKeyState]): Removed iOS-specific code since this method is
1232         now macOS-only.
1233         (-[WebHTMLView _selectionChanged]): Removed call to _updateSelectionForInputManager on
1234         iOS since that is now macOS-only.
1235         (-[WebHTMLView promisedDragTIFFDataSource]): Deleted.
1236         (-[WebHTMLView _startAutoscrollTimer:]): Moved this into an internal category instead of
1237         a private one because it is not used or needed outside WebKit. Also made it macOS-only
1238         and reorganized to use early return.
1239         (-[WebHTMLView _stopAutoscrollTimer]): Moved into internal category. It remains a no-op
1240         on iOS, but kept there so we don't have to do #if at every call site.
1241         (-[WebHTMLView _pluginController]): Moved into internal category.
1242         (-[WebHTMLView validAttributesForMarkedText]): Simplified by removing CFRetain that was
1243         there only for GC, using C++ initialization, removing obsolete comment.
1244         (-[WebHTMLView _updateSelectionForInputManager]): Made this macOS-only and removed
1245         peculiar iOS-only comment.
1246         (+[NSURL _web_uniqueWebDataURL]): Simplified using [NSUUID UUID].
1247
1248         * WebView/WebHTMLViewInternal.h: Removed unused promisedDragTIFFDataSource method.
1249         Made attachRootLayer:, detachRootLayer, _web_isDrawingIntoLayer,
1250         _web_isDrawingIntoAcceleratedLayer all macOS-only. Moved _startAutoscrollTimer:,
1251         _stopAutoscrollTimer, and _pluginController here from SPI header since they aren't
1252         needed or used as SPI. And made _startAutoscrollTimer macOS-only.
1253
1254         * WebView/WebHTMLViewPrivate.h: Removed unneeded and unused SPI: _insideAnotherHTMLView,
1255         _clearLastHitViewIfSelf, _pluginController, _startAutoscrollTimer:, and _stopAutoscrollTimer.
1256         Made _transparentBackground and _setTransparentBackground: macOS-only. These probably
1257         are not needed on macOS either, but I wasn't able to make absolutely sure I could remove
1258         them at this time.
1259
1260 2017-09-03  Sam Weinig  <sam@webkit.org>
1261
1262         Remove CanvasProxy
1263         https://bugs.webkit.org/show_bug.cgi?id=176288
1264
1265         Reviewed by Yusuke Suzuki.
1266
1267         CanvasProxy does not appear to be in any current HTML spec
1268         and was disabled and unimplemented in our tree. Time to 
1269         get rid of it.
1270
1271         * Configurations/FeatureDefines.xcconfig:
1272
1273 2017-09-02  Andy Estes  <aestes@apple.com>
1274
1275         [CA] Upstream QuartzCore-related WebKitSystemInterface functions
1276         https://bugs.webkit.org/show_bug.cgi?id=176270
1277
1278         Reviewed by Tim Horton.
1279
1280         * Plugins/Hosted/NetscapePluginHostManager.mm:
1281         (WebKit::NetscapePluginHostManager::spawnPluginHost):
1282         * Plugins/Hosted/WebHostedNetscapePluginView.h:
1283         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1284         (WebKit::SoftwareCARenderer::SoftwareCARenderer):
1285         (WebKit::SoftwareCARenderer::~SoftwareCARenderer):
1286         (WebKit::SoftwareCARenderer::context const):
1287         (WebKit::SoftwareCARenderer::renderContext const):
1288         (WebKit::SoftwareCARenderer::render):
1289         (-[WebHostedNetscapePluginView createPlugin]):
1290         (-[WebHostedNetscapePluginView createPluginLayer]):
1291         (-[WebHostedNetscapePluginView destroyPlugin]):
1292         (-[WebHostedNetscapePluginView drawRect:]):
1293         * WebCoreSupport/WebSystemInterface.mm:
1294         (InitWebCoreSystemInterface):
1295
1296 2017-09-01  Andy Estes  <aestes@apple.com>
1297
1298         [CG] Upstream CoreGraphics-related WebKitSystemInterface functions
1299         https://bugs.webkit.org/show_bug.cgi?id=176200
1300
1301         Reviewed by Tim Horton.
1302
1303         * Carbon/HIWebView.mm:
1304         (-[NSWindowGraphicsContext _web_setGraphicsPort:]):
1305         (overrideCGContext):
1306         (restoreCGContext):
1307         (Draw):
1308         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
1309         (+[WebHostedNetscapePluginView initialize]):
1310         * Plugins/WebBaseNetscapePluginView.h:
1311         * Plugins/WebBaseNetscapePluginView.mm:
1312         (WebKit::sendUserChangeNotifications):
1313         * Plugins/WebNetscapePluginView.mm:
1314         (+[WebNetscapePluginView initialize]):
1315         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1316         * WebCoreSupport/WebSystemInterface.mm:
1317         (InitWebCoreSystemInterface):
1318         * WebView/WebFrame.mm:
1319         (-[WebFrame _paintBehaviorForDestinationContext:]):
1320         * WebView/WebFullScreenController.mm:
1321         (setClipRectForWindow):
1322         (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
1323         (-[WebFullScreenController finishedExitFullScreenAnimation:]):
1324         (-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
1325         (-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):
1326
1327 2017-08-31  Andy Estes  <aestes@apple.com>
1328
1329         [Mac] Upstream AppKit-related WebKitSystemInterface functions
1330         https://bugs.webkit.org/show_bug.cgi?id=176175
1331
1332         Reviewed by Brady Eidson.
1333
1334         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
1335         (WebKit::NetscapePluginInstanceProxy::keyEvent):
1336         * Plugins/Hosted/WebTextInputWindowController.m:
1337         (-[WebTextInputPanel init]):
1338         * WebCoreSupport/WebSystemInterface.mm:
1339         (InitWebCoreSystemInterface):
1340         * WebView/WebDynamicScrollBarsView.mm:
1341         (-[WebDynamicScrollBarsView scrollWheel:]):
1342         * WebView/WebHTMLView.mm:
1343         (-[WebHTMLView _removeWindowObservers]):
1344         (-[WebHTMLView addWindowObservers]):
1345         * WebView/WebView.mm:
1346         (-[WebView addWindowObserversForWindow:]):
1347         (-[WebView removeWindowObservers]):
1348         (-[WebView viewWillMoveToWindow:]):
1349
1350 2017-08-31  Alex Christensen  <achristensen@webkit.org>
1351
1352         Add ObjC SPI corresponding to WKPageLoaderClient's webGLLoadPolicy and resolveWebGLLoadPolicy
1353         https://bugs.webkit.org/show_bug.cgi?id=175779
1354         <rdar://problem/22367975>
1355
1356         Reviewed by Tim Horton.
1357
1358         * WebCoreSupport/WebFrameLoaderClient.h:
1359         * WebCoreSupport/WebFrameLoaderClient.mm:
1360         (WebFrameLoaderClient::webGLPolicyForURL const):
1361         (WebFrameLoaderClient::resolveWebGLPolicyForURL const):
1362
1363 2017-08-30  Andy Estes  <aestes@apple.com>
1364
1365         [Mac] Upstream Accessibility-related WebKitSystemInterface functions
1366         https://bugs.webkit.org/show_bug.cgi?id=176093
1367
1368         Reviewed by Eric Carlson.
1369
1370         * WebCoreSupport/WebSystemInterface.mm:
1371         (InitWebCoreSystemInterface):
1372
1373 2017-08-30  Andy Estes  <aestes@apple.com>
1374
1375         [Mac] Upstream Carbon-related WebKitSystemInterface functions
1376         https://bugs.webkit.org/show_bug.cgi?id=176087
1377
1378         Reviewed by Alex Christensen.
1379
1380         * Carbon/CarbonUtils.m:
1381         (getNSAutoreleasePoolCount):
1382         (WebInitForCarbon):
1383         (PoolCleaner):
1384         * Carbon/CarbonWindowAdapter.mm:
1385         (+[CarbonWindowAdapter frameViewClassForStyleMask:]):
1386         (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
1387         (-[CarbonWindowAdapter _oldPlaceWindow:]):
1388         (-[CarbonWindowAdapter _windowMovedToRect:]):
1389         * Carbon/HIViewAdapter.m:
1390         * Carbon/HIWebView.mm:
1391         (Draw):
1392         (CreateNSEventAdoptingCGEvent):
1393         (CopyEventCGEvent):
1394         (CreateNSEventWithCarbonClickEvent):
1395         (Click):
1396         (CreateNSEventWithCarbonEvent):
1397         (MouseUp):
1398         (CreateNSEventWithCarbonMouseMoveEvent):
1399         (MouseMoved):
1400         (MouseDragged):
1401         (MouseWheelMoved):
1402         (WindowHandler):
1403         (HIWebViewEventHandler):
1404         * Misc/QuickDrawCompatibility.h: Removed.
1405         * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
1406         (getCarbonEvent):
1407         (WebNetscapePluginEventHandlerCarbon::keyDown):
1408         (WebNetscapePluginEventHandlerCarbon::keyUp):
1409         * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
1410         (WebNetscapePluginEventHandlerCocoa::keyDown):
1411         * Plugins/WebNetscapePluginView.mm:
1412         (-[WebNetscapePluginView tellQuickTimeToChill]):
1413
1414 2017-08-29  Andy Estes  <aestes@apple.com>
1415
1416         [Mac] Upstream WKSetMetadataURL() from WebKitSystemInterface
1417         https://bugs.webkit.org/show_bug.cgi?id=176046
1418
1419         Reviewed by Alex Christensen.
1420
1421         Removed the pthread logic from -_webkit_setMetadataURL:referrer:atPath: and replaced with
1422         WebCore::setMetadataURL(), which uses dispatch_async() for the same purpose as the pthread.
1423
1424         * Misc/WebNSFileManagerExtras.mm:
1425         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]):
1426         (setMetaData): Deleted.
1427         * WebCoreSupport/WebSystemInterface.mm:
1428         (InitWebCoreSystemInterface):
1429
1430 2017-08-28  Andy Estes  <aestes@apple.com>
1431
1432         [Cocoa] Upstream WKGetWebDefaultCFStringEncoding()
1433         https://bugs.webkit.org/show_bug.cgi?id=176039
1434
1435         Reviewed by Alex Christensen.
1436
1437         * WebCoreSupport/WebSystemInterface.mm:
1438         (InitWebCoreSystemInterface):
1439         * WebView/WebPreferences.mm:
1440         (+[WebPreferences _systemCFStringEncoding]):
1441
1442 2017-08-28  Andy Estes  <aestes@apple.com>
1443
1444         [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
1445         https://bugs.webkit.org/show_bug.cgi?id=176032
1446
1447         Reviewed by Alex Christensen.
1448
1449         * WebCoreSupport/WebSystemInterface.mm:
1450         (InitWebCoreSystemInterface):
1451         * WebView/WebView.mm:
1452         (-[WebView _cachedResponseForURL:]):
1453
1454 2017-08-28  Brent Fulgham  <bfulgham@apple.com>
1455
1456         Disable access to secure cookies if an HTTPS site loads mixed content (Part 2: Header Requests)
1457         https://bugs.webkit.org/show_bug.cgi?id=175992
1458         <rdar://problem/34086613>
1459
1460         Reviewed by Daniel Bates.
1461
1462         * WebCoreSupport/WebPlatformStrategies.h:
1463         * WebCoreSupport/WebPlatformStrategies.mm:
1464         (WebPlatformStrategies::cookieRequestHeaderFieldValue): Modify to accept a flag indicating if secure
1465         cookies should be included, and return a pair containing the resulting cookie string and a boolean
1466         indicating if secure cookies were accessed.
1467
1468 2017-08-27  Wenson Hsieh  <wenson_hsieh@apple.com>
1469
1470         Picking an emoji via the emoji dialog (Ctrl+Cmd+Space) fires inconsistent beforeinput events.
1471         https://bugs.webkit.org/show_bug.cgi?id=170955
1472         <rdar://problem/31697653>
1473
1474         Reviewed by Ryosuke Niwa.
1475
1476         Tweak -insertText: to pass TextEventInputAutocompletion to Editor::insertText when inserting text, if existing
1477         text is being replaced.
1478
1479         * WebView/WebHTMLView.mm:
1480         (-[WebHTMLView insertText:]):
1481
1482 2017-08-24  Chris Dumez  <cdumez@apple.com>
1483
1484         [Directory Upload] Add basic support for input.webkitdirectory
1485         https://bugs.webkit.org/show_bug.cgi?id=175950
1486         <rdar://problem/33951915>
1487
1488         Reviewed by Geoffrey Garen.
1489
1490         Add private API to toggle Directory Upload support on Mac WebKit1.
1491
1492         * WebView/WebPreferenceKeysPrivate.h:
1493         * WebView/WebPreferences.mm:
1494         (+[WebPreferences initialize]):
1495         (-[WebPreferences setDirectoryUploadEnabled:]):
1496         (-[WebPreferences directoryUploadEnabled]):
1497         * WebView/WebPreferencesPrivate.h:
1498         * WebView/WebView.mm:
1499         (-[WebView _preferencesChanged:]):
1500
1501 2017-08-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1502
1503         [WK2] EditorState updates should be rolled into the layer update lifecycle when possible
1504         https://bugs.webkit.org/show_bug.cgi?id=175370
1505         <rdar://problem/33799806>
1506
1507         Reviewed by Ryosuke Niwa.
1508
1509         Adjust WebEditorClient for interface changes.
1510
1511         * WebCoreSupport/WebEditorClient.h:
1512
1513 2017-08-22  Alex Christensen  <achristensen@webkit.org>
1514
1515         Remove ChromeClient::scrollbarsModeDidChange
1516         https://bugs.webkit.org/show_bug.cgi?id=175805
1517
1518         Reviewed by Daniel Bates.
1519
1520         * WebCoreSupport/WebChromeClient.h:
1521
1522 2017-08-22  Alex Christensen  <achristensen@webkit.org>
1523
1524         Remove ChromeClient::hasOpenedPopup
1525         https://bugs.webkit.org/show_bug.cgi?id=175804
1526
1527         Reviewed by Sam Weinig.
1528
1529         * WebCoreSupport/WebChromeClient.h:
1530         * WebCoreSupport/WebChromeClient.mm:
1531         (WebChromeClient::hasOpenedPopup const): Deleted.
1532
1533 2017-08-22  Brent Fulgham  <bfulgham@apple.com> and Pranjal Jumde  <pjumde@apple.com>
1534
1535         Disable access to secure cookies if an HTTPS site loads mixed content
1536         https://bugs.webkit.org/show_bug.cgi?id=157053
1537         <rdar://problem/11290808>
1538
1539         Reviewed by Dan Bates.
1540
1541         * WebCoreSupport/WebPlatformStrategies.h:
1542         * WebCoreSupport/WebPlatformStrategies.mm:
1543         (WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
1544         indicating whether secure cookies should be included in the response.
1545
1546 2017-08-21  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1547
1548         [PAL] Move spi/mac directory into PAL
1549         https://bugs.webkit.org/show_bug.cgi?id=175649
1550
1551         Reviewed by Myles C. Maxfield.
1552
1553         * Misc/WebSharingServicePickerController.h:
1554         * WebCoreSupport/WebContextMenuClient.mm:
1555         * WebCoreSupport/WebEditorClient.mm:
1556         * WebCoreSupport/WebSelectionServiceController.mm:
1557         * WebView/WebHTMLView.mm:
1558         * WebView/WebImmediateActionController.h:
1559         * WebView/WebImmediateActionController.mm:
1560         * WebView/WebView.mm:
1561
1562 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
1563
1564         [PAL] Relocate SessionID to root
1565         https://bugs.webkit.org/show_bug.cgi?id=175684
1566
1567         Reviewed by Alex Christensen.
1568
1569         * WebCoreSupport/WebFrameNetworkingContext.mm:
1570
1571 2017-08-17  Andreas Kling  <akling@apple.com>
1572
1573         Disable CSS regions at compile time
1574         https://bugs.webkit.org/show_bug.cgi?id=175630
1575
1576         Reviewed by Antti Koivisto.
1577
1578         * Configurations/FeatureDefines.xcconfig:
1579
1580 2017-08-17  Don Olmstead  <don.olmstead@sony.com>
1581
1582         [PAL] Move SessionID into PAL
1583         https://bugs.webkit.org/show_bug.cgi?id=174192
1584
1585         Reviewed by Antti Koivisto.
1586
1587         * Misc/WebCache.mm:
1588         (+[WebCache imageForURL:]):
1589         * WebCoreSupport/WebFrameLoaderClient.h:
1590         * WebCoreSupport/WebFrameLoaderClient.mm:
1591         (WebFrameLoaderClient::convertMainResourceLoadToDownload):
1592         * WebCoreSupport/WebFrameNetworkingContext.mm:
1593         (WebFrameNetworkingContext::ensurePrivateBrowsingSession):
1594         (WebFrameNetworkingContext::destroyPrivateBrowsingSession):
1595         (WebFrameNetworkingContext::storageSession const):
1596         * WebCoreSupport/WebPlatformStrategies.h:
1597         * WebCoreSupport/WebPlatformStrategies.mm:
1598         (WebPlatformStrategies::cookieRequestHeaderFieldValue):
1599         * WebKitPrefix.h:
1600
1601 2017-08-16  Andy Estes  <aestes@apple.com>
1602
1603         [Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
1604         https://bugs.webkit.org/show_bug.cgi?id=175648
1605
1606         Reviewed by Tim Horton.
1607
1608         * WebCoreSupport/WebPaymentCoordinatorClient.h:
1609         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
1610         (WebPaymentCoordinatorClient::showPaymentUI):
1611
1612 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1613
1614         [PAL] Move spi/ios and spi/win directories into PAL
1615         https://bugs.webkit.org/show_bug.cgi?id=175171
1616
1617         Reviewed by Antti Koivisto.
1618
1619         * WebCoreSupport/WebFrameLoaderClient.mm:
1620         * WebView/WebView.mm:
1621
1622 2017-08-16  Andy Estes  <aestes@apple.com>
1623
1624         [Payment Request] Add an ENABLE flag and an experimental feature preference
1625         https://bugs.webkit.org/show_bug.cgi?id=175622
1626
1627         Reviewed by Tim Horton.
1628
1629         * Configurations/FeatureDefines.xcconfig:
1630
1631 2017-08-15  Don Olmstead  <don.olmstead@sony.com>
1632
1633         [PAL] Move Sleep classes into PAL
1634         https://bugs.webkit.org/show_bug.cgi?id=175456
1635
1636         Reviewed by Ryosuke Niwa.
1637
1638         * WebView/WebFullScreenController.h:
1639
1640 2017-08-15  Youenn Fablet  <youenn@apple.com>
1641
1642         [Cache API] Adding generic support for CacheStorage and Cache methods
1643         https://bugs.webkit.org/show_bug.cgi?id=175455
1644
1645         Reviewed by Chris Dumez.
1646
1647         * WebView/WebView.mm:
1648         (-[WebView _commonInitializationWithFrameName:groupName:]):
1649
1650 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1651
1652         Remove Proximity Events and related code
1653         https://bugs.webkit.org/show_bug.cgi?id=175545
1654
1655         Reviewed by Daniel Bates.
1656
1657         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
1658         and other related code.
1659
1660         * Configurations/FeatureDefines.xcconfig:
1661
1662 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1663
1664         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
1665         https://bugs.webkit.org/show_bug.cgi?id=175504
1666
1667         Reviewed by Sam Weinig.
1668
1669         * Configurations/FeatureDefines.xcconfig:
1670         * DOM/DOMHTMLFormElement.mm:
1671         (-[DOMHTMLFormElement requestAutocomplete]): Deleted.
1672         * WebCoreSupport/WebFrameLoaderClient.h:
1673
1674 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
1675
1676         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
1677         https://bugs.webkit.org/show_bug.cgi?id=175557
1678
1679         Reviewed by Jon Lee.
1680
1681         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
1682
1683         * Configurations/FeatureDefines.xcconfig:
1684
1685 2017-08-13  Manuel Rego Casasnovas  <rego@igalia.com>
1686
1687         Composition underline color is always black
1688         https://bugs.webkit.org/show_bug.cgi?id=174675
1689
1690         Reviewed by Ryosuke Niwa.
1691
1692         * WebView/WebHTMLView.mm:
1693         (extractUnderlines): If NSUnderlineColorAttributeName
1694         is not present use text color for composition underline.
1695         (-[WebHTMLView setMarkedText:selectedRange:]): Use text color
1696         for composition underline in the plain text case.
1697
1698 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
1699
1700         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
1701         https://bugs.webkit.org/show_bug.cgi?id=175474
1702         <rdar://problem/33844628>
1703
1704         Reviewed by Wenson Hsieh.
1705
1706         Replaced the build flag by a runtime flag and disabled the feature by default.
1707
1708         * Configurations/FeatureDefines.xcconfig:
1709         * WebView/WebPreferenceKeysPrivate.h:
1710         * WebView/WebPreferences.mm:
1711         (+[WebPreferences initialize]): Disables dataTransfer.items by default.
1712         (-[WebPreferences dataTransferItemsEnabled]): Added.
1713         (-[WebPreferences setDataTransferItemsEnabled:]): Added.
1714         * WebView/WebPreferencesPrivate.h:
1715         * WebView/WebView.mm:
1716         (-[WebView _preferencesChanged:]):
1717
1718 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1719
1720         Remove ENABLE_GAMEPAD_DEPRECATED
1721         https://bugs.webkit.org/show_bug.cgi?id=175361
1722
1723         Reviewed by Carlos Garcia Campos.
1724
1725         * Configurations/FeatureDefines.xcconfig:
1726
1727 2017-08-09  Chris Dumez  <cdumez@apple.com>
1728
1729         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
1730         https://bugs.webkit.org/show_bug.cgi?id=175401
1731
1732         Reviewed by Brady Eidson.
1733
1734         * WebView/WebPreferenceKeysPrivate.h:
1735         * WebView/WebPreferences.mm:
1736         (+[WebPreferences initialize]):
1737         (-[WebPreferences beaconAPIEnabled]): Deleted.
1738         (-[WebPreferences setBeaconAPIEnabled:]): Deleted.
1739         * WebView/WebPreferencesPrivate.h:
1740         * WebView/WebView.mm:
1741         (-[WebView _preferencesChanged:]):
1742
1743 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1744
1745         [PAL] Move spi/cocoa and spi/cg directories into PAL
1746         https://bugs.webkit.org/show_bug.cgi?id=175175
1747
1748         Reviewed by Myles C. Maxfield.
1749
1750         * History/WebHistory.mm:
1751         * Misc/WebDownload.mm:
1752         * Misc/WebKitNSStringExtras.mm:
1753         * Plugins/Hosted/NetscapePluginHostManager.mm:
1754         * Plugins/WebPluginDatabase.mm:
1755         * WebCoreSupport/WebFrameLoaderClient.mm:
1756         * WebInspector/WebNodeHighlight.mm:
1757         * WebView/WebHTMLView.mm:
1758         * WebView/WebIndicateLayer.mm:
1759         * WebView/WebView.mm:
1760         * WebView/WebViewData.h:
1761
1762 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1763
1764         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
1765         https://bugs.webkit.org/show_bug.cgi?id=175392
1766         <rdar://problem/33783207>
1767
1768         Reviewed by Tim Horton and Megan Gardner.
1769
1770         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
1771
1772         * Configurations/FeatureDefines.xcconfig:
1773
1774 2017-08-09  Daniel Bates  <dabates@apple.com>
1775
1776         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
1777         https://bugs.webkit.org/show_bug.cgi?id=175247
1778         <rdar://problem/33679804>
1779
1780         Reviewed by Brady Eidson.
1781
1782         Plumb knowledge of whether a navigation was in response to receiving a redirect response.
1783         We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
1784         clients that need to make use of this information at this time. If such a needs comes up
1785         then we can expose API/SPI similar to what we do for WebKit.
1786
1787         * WebCoreSupport/WebFrameLoaderClient.h:
1788         * WebCoreSupport/WebFrameLoaderClient.mm:
1789         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1790
1791 2017-08-08  Brady Eidson  <beidson@apple.com>
1792
1793         Don't enable default icon loading in WK1 for apps linked against old SDKs.
1794         <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342
1795
1796         Reviewed by Andy Estes.
1797
1798         * Misc/WebKitVersionChecks.h:
1799         * WebCoreSupport/WebFrameLoaderClient.mm:
1800         (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless
1801           the app is linked against new WebKit with the new behavior.
1802
1803 2017-08-07  Devin Rousso  <drousso@apple.com>
1804
1805         Web Inspector: Preview Canvas path when viewing a recording
1806         https://bugs.webkit.org/show_bug.cgi?id=174967
1807
1808         Reviewed by Brian Burg.
1809
1810         * WebView/WebPreferenceKeysPrivate.h:
1811         * WebView/WebPreferences.mm:
1812         (+[WebPreferences initialize]):
1813         (-[WebPreferences inspectorAdditionsEnabled]):
1814         (-[WebPreferences setInspectorAdditionsEnabled:]):
1815         * WebView/WebPreferencesPrivate.h:
1816         * WebView/WebView.mm:
1817         (-[WebView _preferencesChanged:]):
1818         Add plumbing for new InspectorAdditions runtime flag.
1819
1820 2017-08-07  Brian Burg  <bburg@apple.com>
1821
1822         Remove CANVAS_PATH compilation guard
1823         https://bugs.webkit.org/show_bug.cgi?id=175207
1824
1825         Reviewed by Sam Weinig.
1826
1827         * Configurations/FeatureDefines.xcconfig:
1828
1829 2017-08-04  Youenn Fablet  <youenn@apple.com>
1830
1831         [Cache API] Add Cache and CacheStorage IDL definitions
1832         https://bugs.webkit.org/show_bug.cgi?id=175201
1833
1834         Reviewed by Brady Eidson.
1835
1836         * WebView/WebPreferenceKeysPrivate.h:
1837         * WebView/WebPreferences.mm:
1838         (+[WebPreferences initialize]):
1839         (-[WebPreferences cacheAPIEnabled]):
1840         (-[WebPreferences setCacheAPIEnabled:]):
1841         * WebView/WebPreferencesPrivate.h:
1842         * WebView/WebView.mm:
1843         (-[WebView _preferencesChanged:]):
1844
1845 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1846
1847         Unreviewed, rolling out r220271.
1848
1849         Rolling out due to Layout Test failing on iOS Simulator.
1850
1851         Reverted changeset:
1852
1853         "Remove STREAMS_API compilation guard"
1854         https://bugs.webkit.org/show_bug.cgi?id=175165
1855         http://trac.webkit.org/changeset/220271
1856
1857 2017-08-04  Youenn Fablet  <youenn@apple.com>
1858
1859         Remove STREAMS_API compilation guard
1860         https://bugs.webkit.org/show_bug.cgi?id=175165
1861
1862         Reviewed by Darin Adler.
1863
1864         * Configurations/FeatureDefines.xcconfig:
1865         * WebView/WebPreferences.mm:
1866         (+[WebPreferences initialize]):
1867         * WebView/WebView.mm:
1868         (-[WebView _preferencesChanged:]):
1869
1870 2017-08-03  Brian Burg  <bburg@apple.com>
1871
1872         Remove ENABLE(WEB_SOCKET) guards
1873         https://bugs.webkit.org/show_bug.cgi?id=167044
1874
1875         Reviewed by Joseph Pecoraro.
1876
1877         * Configurations/FeatureDefines.xcconfig:
1878         * WebView/WebPreferencesPrivate.h:
1879
1880 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1881
1882         [PAL] Move spi/cf directory into PAL
1883         https://bugs.webkit.org/show_bug.cgi?id=175057
1884
1885         Reviewed by Antti Koivisto.
1886
1887         * Plugins/Hosted/HostedNetscapePluginStream.mm:
1888         * Plugins/WebNetscapePluginStream.mm:
1889         * WebCoreSupport/WebFrameNetworkingContext.mm:
1890         * WebView/WebPreferences.mm:
1891         * WebView/WebView.mm:
1892
1893 2017-08-03  Youenn Fablet  <youenn@apple.com>
1894
1895         Remove FETCH_API compilation guard
1896         https://bugs.webkit.org/show_bug.cgi?id=175154
1897
1898         Reviewed by Chris Dumez.
1899
1900         * Configurations/FeatureDefines.xcconfig:
1901         * WebView/WebPreferences.mm:
1902         (+[WebPreferences initialize]):
1903         * WebView/WebView.mm:
1904         (-[WebView _preferencesChanged:]):
1905
1906 2017-08-03  Brady Eidson  <beidson@apple.com>
1907
1908         Add SW IDLs and stub out basic functionality.
1909         https://bugs.webkit.org/show_bug.cgi?id=175115
1910
1911         Reviewed by Chris Dumez.
1912
1913         * Configurations/FeatureDefines.xcconfig:
1914
1915 2017-08-02  Sam Weinig  <sam@webkit.org>
1916
1917         [WebIDL] Convert MutationCallback to be a normal generated callback
1918         https://bugs.webkit.org/show_bug.cgi?id=174140
1919
1920         Reviewed by Darin Adler.
1921
1922         * DOM/DOMDocument.mm:
1923         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
1924         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
1925         Pass, now necessary, Document to NativeNodeFilter constructor.
1926
1927 2017-08-01  Chris Dumez  <cdumez@apple.com>
1928
1929         Add initial support for navigator.sendBeacon
1930         https://bugs.webkit.org/show_bug.cgi?id=175007
1931         <rdar://problem/33547728>
1932
1933         Reviewed by Sam Weinig.
1934
1935         Add setting to toggle support for the Beacon API (it is disabled by default).
1936
1937         * WebView/WebPreferenceKeysPrivate.h:
1938         * WebView/WebPreferences.mm:
1939         (+[WebPreferences initialize]):
1940         (-[WebPreferences beaconAPIEnabled]):
1941         (-[WebPreferences setBeaconAPIEnabled:]):
1942         * WebView/WebPreferencesPrivate.h:
1943         * WebView/WebView.mm:
1944         (-[WebView _preferencesChanged:]):
1945
1946 2017-07-28  Jeremy Jones  <jeremyj@apple.com>
1947
1948         Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
1949         https://bugs.webkit.org/show_bug.cgi?id=174437
1950
1951         Reviewed by Darin Adler.
1952
1953         Remove redundant Web- prefix from classes in WebKit namespace.
1954
1955         * WebView/WebView.mm:
1956         (-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
1957         * WebView/WebViewData.h:
1958         * WebView/WebViewData.mm:
1959
1960 2017-07-26  Brian Burg  <bburg@apple.com>
1961
1962         Remove WEB_TIMING feature flag
1963         https://bugs.webkit.org/show_bug.cgi?id=174795
1964
1965         Reviewed by Alex Christensen.
1966
1967         * Configurations/FeatureDefines.xcconfig:
1968
1969 2017-07-25  Said Abou-Hallawa  <sabouhallawa@apple.com>
1970
1971         Async image decoding for large images should be disabled after the first time a tile is painted
1972         https://bugs.webkit.org/show_bug.cgi?id=174451
1973         <rdar://problem/31246421>
1974
1975         Reviewed by Simon Fraser.
1976
1977         * WebView/WebFrame.mm:
1978         (-[WebFrame _paintBehaviorForDestinationContext:]):
1979         (-[WebFrame _drawRect:contentsOnly:]):
1980         * WebView/WebHTMLView.mm:
1981         (imageFromRect):
1982
1983 2017-07-23  Darin Adler  <darin@apple.com>
1984
1985         More NeverDestroyed and related cleanup
1986         https://bugs.webkit.org/show_bug.cgi?id=174745
1987
1988         Reviewed by Alex Christensen.
1989
1990         * DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
1991         for names that aren't even used in this file.
1992         (-[DOMNode boundingBoxes]): Use @[] syntax instead of
1993         -[NSArray arrayWithObject:].
1994         (-[DOMNode absoluteQuads]): Ditto.
1995         (-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
1996         of writing out various types.
1997         (-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
1998         syntax instea of -[NSArray arrayWithObject:].
1999         (-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
2000         (-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
2001         of writing out various types.
2002         (-[DOMHTMLImageElement mimeType]): Ditto.
2003
2004 2017-07-24  Chris Dumez  <cdumez@apple.com>
2005
2006         ExceptionCode enumeration should use modern exception names
2007         https://bugs.webkit.org/show_bug.cgi?id=174794
2008
2009         Reviewed by Geoffrey Garen.
2010
2011         * DOM/ExceptionHandlers.mm:
2012         (raiseNotSupportedErrorException):
2013
2014 2017-07-23  Chris Dumez  <cdumez@apple.com>
2015
2016         Drop ExceptionCodeDescription class
2017         https://bugs.webkit.org/show_bug.cgi?id=174757
2018
2019         Reviewed by Darin Adler.
2020
2021         Stop using ExceptionCodeDescription.
2022
2023         * DOM/ExceptionHandlers.mm:
2024         (raiseDOMErrorException):
2025
2026 2017-07-21  Andreas Kling  <akling@apple.com>
2027
2028         Use more references in event dispatch code
2029         https://bugs.webkit.org/show_bug.cgi?id=174681
2030
2031         Reviewed by Geoffrey Garen.
2032
2033         * DOM/ObjCEventListener.h:
2034         * DOM/ObjCEventListener.mm:
2035         (WebCore::ObjCEventListener::handleEvent):
2036         * WebCoreSupport/WebFrameLoaderClient.mm:
2037         (NetscapePluginWidget::handleEvent):
2038
2039 2017-07-21  Brady Eidson  <beidson@apple.com>
2040
2041         Get rid of WebCore IconDatabase code.
2042         https://bugs.webkit.org/show_bug.cgi?id=174700
2043
2044         Reviewed by Tim Horton.
2045
2046         * Misc/WebCoreStatistics.mm:
2047         (+[WebCoreStatistics iconPageURLMappingCount]):
2048         (+[WebCoreStatistics iconRetainedPageURLCount]):
2049         (+[WebCoreStatistics iconRecordCount]):
2050         (+[WebCoreStatistics iconsWithDataCount]):
2051         * WebCoreSupport/WebFrameLoaderClient.h:
2052         * WebCoreSupport/WebFrameLoaderClient.mm:
2053         * WebCoreSupport/WebIconDatabaseClient.h: Removed.
2054         * WebCoreSupport/WebIconDatabaseClient.mm: Removed.
2055         * WebView/WebView.mm:
2056         (-[WebView mainFrameIconURL]):
2057
2058 2017-07-20  Chris Dumez  <cdumez@apple.com>
2059
2060         Drop legacy XPathException type
2061         https://bugs.webkit.org/show_bug.cgi?id=174679
2062
2063         Reviewed by Sam Weinig.
2064
2065         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
2066         no longer expose XPathException.
2067
2068         * DOM/ExceptionHandlers.mm:
2069         (raiseDOMErrorException):
2070
2071 2017-07-20  Chris Dumez  <cdumez@apple.com>
2072
2073         Unreviewed, rolling out r219706.
2074
2075         Broke iOS build
2076
2077         Reverted changeset:
2078
2079         "Drop legacy XPathException type"
2080         https://bugs.webkit.org/show_bug.cgi?id=174679
2081         http://trac.webkit.org/changeset/219706
2082
2083 2017-07-20  Chris Dumez  <cdumez@apple.com>
2084
2085         Drop legacy XPathException type
2086         https://bugs.webkit.org/show_bug.cgi?id=174679
2087
2088         Reviewed by Sam Weinig.
2089
2090         Drop legacy XPathException type and use DOMException instead. Both Firefox and Chrome
2091         no longer expose XPathException.
2092
2093         * DOM/ExceptionHandlers.mm:
2094         (raiseDOMErrorException):
2095         * WebKit.exp:
2096
2097 2017-07-20  Chris Dumez  <cdumez@apple.com>
2098
2099         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable
2100         https://bugs.webkit.org/show_bug.cgi?id=174660
2101
2102         Reviewed by Geoffrey Garen.
2103
2104         Replace calls to Vector::resize() with calls to more efficient shrink() / grow() when applicable.
2105         This essentially replaces a branch to figure out if the new size is less or greater than the
2106         current size by an assertion.
2107
2108         * Plugins/WebNetscapePluginView.mm:
2109         (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2110
2111 2017-07-20  Brady Eidson  <beidson@apple.com>
2112
2113         Deprecate WebIconDatabase in WebKitLegacy/mac.
2114         https://bugs.webkit.org/show_bug.cgi?id=174607
2115
2116         Reviewed by Alex Christensen.
2117
2118         This patch:
2119         1 - Formally deprecates WebIconDatabase (which was never API anyways)
2120         2 - Guts the class to where it can only return the default icon at the small size
2121         3 - Reworks other parts of WebKitLegacy that used it for anything to either
2122             use something else or to not do anything.
2123         
2124         This patch *could* go much farther. A future patch is what will remove WebCore/IconDatabase
2125         and that patch will remove all of the last remnants of WebIconDatabase.
2126         
2127         * History/WebHistoryItem.mm:
2128         (-[WebHistoryItem icon]):
2129
2130         * Misc/WebIconDatabase.h:
2131         * Misc/WebIconDatabase.mm:
2132         (-[WebIconDatabase init]):
2133         (-[WebIconDatabase iconForURL:withSize:cache:]):
2134         (-[WebIconDatabase iconForURL:withSize:]):
2135         (-[WebIconDatabase defaultIconWithSize:]):
2136         (-[WebIconDatabase defaultIconForURL:withSize:]):
2137         (-[WebIconDatabase iconURLForURL:]):
2138         (-[WebIconDatabase retainIconForURL:]):
2139         (-[WebIconDatabase releaseIconForURL:]):
2140         (+[WebIconDatabase delayDatabaseCleanup]):
2141         (+[WebIconDatabase allowDatabaseCleanup]):
2142         (-[WebIconDatabase setDelegate:]):
2143         (-[WebIconDatabase delegate]):
2144         (+[WebIconDatabase initialize]): Deleted.
2145         (-[WebIconDatabase isEnabled]): Deleted.
2146         (-[WebIconDatabase setEnabled:]): Deleted.
2147         (-[WebIconDatabase removeAllIcons]): Deleted.
2148         (+[WebIconDatabase _checkIntegrityBeforeOpening]): Deleted.
2149         (-[WebIconDatabase _sendNotificationForURL:]): Deleted.
2150         (-[WebIconDatabase _sendDidRemoveAllIconsNotification]): Deleted.
2151         (-[WebIconDatabase _startUpIconDatabase]): Deleted.
2152         (-[WebIconDatabase _shutDownIconDatabase]): Deleted.
2153         (-[WebIconDatabase _applicationWillTerminate:]): Deleted.
2154         (-[WebIconDatabase _iconForFileURL:withSize:]): Deleted.
2155         (-[WebIconDatabase _resetCachedWebPreferences:]): Deleted.
2156         (-[WebIconDatabase _largestIconFromDictionary:]): Deleted.
2157         (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): Deleted.
2158         (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): Deleted.
2159         (-[WebIconDatabase _scaleIcon:toSize:]): Deleted.
2160         (-[WebIconDatabase _databaseDirectory]): Deleted.
2161         (webGetNSImage): Deleted.
2162
2163         * Misc/WebIconDatabaseDelegate.h: Removed.
2164         * Misc/WebIconDatabaseInternal.h: Removed.
2165         * Misc/WebIconDatabasePrivate.h: Removed.
2166
2167         * WebCoreSupport/WebFrameLoaderClient.mm:
2168         (webGetNSImage):
2169
2170         * WebCoreSupport/WebIconDatabaseClient.mm:
2171         (WebIconDatabaseClient::didRemoveAllIcons):
2172         (WebIconDatabaseClient::didImportIconURLForPageURL):
2173
2174         * WebView/WebView.mm:
2175         (-[WebView setFrameLoadDelegate:]):
2176         (-[WebView mainFrameIcon]):
2177
2178 2017-07-18  Andy Estes  <aestes@apple.com>
2179
2180         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2181         https://bugs.webkit.org/show_bug.cgi?id=174631
2182
2183         Reviewed by Tim Horton.
2184
2185         * Configurations/Base.xcconfig:
2186
2187 2017-07-18  Andy Estes  <aestes@apple.com>
2188
2189         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2190         https://bugs.webkit.org/show_bug.cgi?id=174631
2191
2192         Reviewed by Sam Weinig.
2193
2194         * Configurations/Base.xcconfig:
2195
2196 2017-07-18  Andy Estes  <aestes@apple.com>
2197
2198         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
2199         https://bugs.webkit.org/show_bug.cgi?id=174631
2200
2201         Reviewed by Dan Bernstein.
2202
2203         * Configurations/Base.xcconfig:
2204
2205 2017-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
2206
2207         [iOS DnD] [WK1] Add missing calls to WebThreadLock() in some WebView drag-and-drop SPIs
2208         https://bugs.webkit.org/show_bug.cgi?id=174640
2209         <rdar://problem/33297400>
2210
2211         Reviewed by Tim Horton.
2212
2213         Adds a missing call to WebThreadLock() in -_requestStartDataInteraction:globalPosition:. Previously, this was
2214         invoked at the call site in UIKit, but was removed after some refactoring in UIKit. Instead, we should lock the
2215         web thread here, to match the other WebView drag and drop SPI methods.
2216
2217         This patch also adds a WebThreadLock() call in -_dataInteractionCaretRect. While this is fine today, since all
2218         existing callers of _dataInteractionCaretRect already invoke other methods that WebThreadLock() beforehand, we
2219         should make this robust against future UIKit changes that could make this no longer the case.
2220
2221         * WebView/WebView.mm:
2222         (-[WebView _requestStartDataInteraction:globalPosition:]):
2223         (-[WebView _dataInteractionCaretRect]):
2224
2225 2017-07-18  Andy Estes  <aestes@apple.com>
2226
2227         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2228         https://bugs.webkit.org/show_bug.cgi?id=174631
2229
2230         Reviewed by Darin Adler.
2231
2232         * Configurations/Base.xcconfig:
2233
2234 2017-07-17  Sam Weinig  <sam@webkit.org>
2235
2236         [WebIDL] Remove custom bindings that require non-caching JS strings
2237         https://bugs.webkit.org/show_bug.cgi?id=174552
2238
2239         Reviewed by Darin Adler.
2240
2241         * DOM/DOMHTMLCanvasElement.mm:
2242         (-[DOMHTMLCanvasElement toDataURL:]):
2243         Update to account for implementation now returning an UncachedString.
2244
2245 2017-07-17  Darin Adler  <darin@apple.com>
2246
2247         Improve use of NeverDestroyed
2248         https://bugs.webkit.org/show_bug.cgi?id=174348
2249
2250         Reviewed by Sam Weinig.
2251
2252         * Misc/WebStringTruncator.mm:
2253         (+[WebStringTruncator centerTruncateString:toWidth:]): Replace
2254         NeverDestroyed<RetainPtr> with just an NSFont * global.
2255
2256         * Plugins/Hosted/NetscapePluginHostManager.h: Removed unneeded include of
2257         NeverDestroyed.h.
2258         * Storage/WebDatabaseManager.mm: Ditto.
2259         * WebCoreSupport/WebFrameNetworkingContext.mm: Ditto.
2260         * WebCoreSupport/WebPlatformStrategies.mm: Ditto.
2261
2262         * WebView/WebView.mm: Removed unneeded include of NetworkStateNotifier.h.
2263         (aeDescFromJSValue): Removed double hashing by using the return value from
2264         add rather than calling contains before calling add.
2265
2266 2017-07-14  Jer Noble  <jer.noble@apple.com>
2267
2268         Allow clients to override their own hardware media requirements where no fallback media exists.
2269         https://bugs.webkit.org/show_bug.cgi?id=174426
2270         <rdar://problem/32537704>
2271
2272         Reviewed by Eric Carlson.
2273
2274         Add a new WebPreferences property to control WebCore's new
2275         allowMediaContentTypesRequiringHardwareSupportAsFallback setting.
2276
2277         * WebView/WebPreferenceKeysPrivate.h:
2278         * WebView/WebPreferences.mm:
2279         (+[WebPreferences initialize]):
2280         (-[WebPreferences allowMediaContentTypesRequiringHardwareSupportAsFallback]):
2281         (-[WebPreferences setAllowMediaContentTypesRequiringHardwareSupportAsFallback:]):
2282         * WebView/WebPreferencesPrivate.h:
2283         * WebView/WebView.mm:
2284         (-[WebView _preferencesChanged:]):
2285
2286 2017-07-12  Said Abou-Hallawa  <sabouhallawa@apple.com>
2287
2288         Async image decoding for large images should be disabled by default
2289         https://bugs.webkit.org/show_bug.cgi?id=174432
2290
2291         Reviewed by Simon Fraser.
2292
2293         -- Remove setting the bit PaintBehaviorSnapshotting in any new PaintBehavoir.
2294         -- Return PaintBehaviorAllowAsyncImageDecoding when the return value was 0.
2295         -- Propagate PaintBehaviorAllowAsyncImageDecoding from a parent view to 
2296            a child view instead of propagating PaintBehaviorSnapshotting.
2297         -- Replace setting the bit PaintBehaviorSnapshotting in an existing PaintBehavoir
2298            by resetting the bit PaintBehaviorAllowAsyncImageDecoding.
2299
2300         * WebView/WebFrame.mm:
2301         (-[WebFrame _paintBehaviorForDestinationContext:]):
2302         (-[WebFrame _drawRect:contentsOnly:]):
2303         * WebView/WebHTMLView.mm:
2304         (imageFromRect):
2305
2306 2017-07-12  Daniel Bates  <dabates@apple.com>
2307
2308         Rename NavigationInitiatedByMainFrame to InitiatedByMainFrame
2309         https://bugs.webkit.org/show_bug.cgi?id=174427
2310
2311         Rubber-stamped by Brady Eidson.
2312
2313         * WebView/WebPDFView.mm:
2314         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2315
2316 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2317
2318         Unreviewed, rolling out r219401.
2319
2320         This revision rolled out the previous patch, but after talking
2321         with reviewer, a rebaseline is what was needed.Rolling back in
2322         before rebaseline.
2323
2324         Reverted changeset:
2325
2326         "Unreviewed, rolling out r219379."
2327         https://bugs.webkit.org/show_bug.cgi?id=174400
2328         http://trac.webkit.org/changeset/219401
2329
2330 2017-07-12  Matt Lewis  <jlewis3@apple.com>
2331
2332         Unreviewed, rolling out r219379.
2333
2334         This revision caused a consistent failure in the test
2335         fast/dom/Window/property-access-on-cached-window-after-frame-
2336         removed.html.
2337
2338         Reverted changeset:
2339
2340         "Remove NAVIGATOR_HWCONCURRENCY"
2341         https://bugs.webkit.org/show_bug.cgi?id=174400
2342         http://trac.webkit.org/changeset/219379
2343
2344 2017-07-11  Dean Jackson  <dino@apple.com>
2345
2346         Remove NAVIGATOR_HWCONCURRENCY
2347         https://bugs.webkit.org/show_bug.cgi?id=174400
2348
2349         * Configurations/FeatureDefines.xcconfig:
2350
2351 2017-07-11  Dean Jackson  <dino@apple.com>
2352
2353         Rolling out r219372.
2354
2355         * Configurations/FeatureDefines.xcconfig:
2356
2357 2017-07-11  Dean Jackson  <dino@apple.com>
2358
2359         Remove NAVIGATOR_HWCONCURRENCY
2360         https://bugs.webkit.org/show_bug.cgi?id=174400
2361
2362         * Configurations/FeatureDefines.xcconfig:
2363
2364 2017-07-03  Brian Burg  <bburg@apple.com>
2365
2366         Web Replay: remove some unused code
2367         https://bugs.webkit.org/show_bug.cgi?id=173903
2368
2369         Rubber-stamped by Joseph Pecoraro.
2370
2371         * Configurations/FeatureDefines.xcconfig:
2372
2373 2017-07-09  Brady Eidson  <beidson@apple.com>
2374
2375         Remove some obsolete WebKitVersionChecks.
2376         https://bugs.webkit.org/show_bug.cgi?id=174294
2377
2378         Reviewed by Dan Bernstein.
2379
2380         * Misc/WebKitVersionChecks.h:
2381
2382         * WebView/WebHTMLView.mm:
2383         (-[WebHTMLView hitTest:]):
2384
2385         * WebView/WebView.mm:
2386         (shouldRespectPriorityInCSSAttributeSetters):
2387         (-[WebView _commonInitializationWithFrameName:groupName:]):
2388         (-[WebView _preferencesChanged:]):
2389         (shouldTransformsAffectOverflow): Deleted.
2390         (shouldDispatchJavaScriptWindowOnErrorEvents): Deleted.
2391
2392 2017-07-08  Brady Eidson  <beidson@apple.com>
2393
2394         Remove some obsolete RuntimeApplicationChecks.
2395         https://bugs.webkit.org/show_bug.cgi?id=174293
2396
2397         Reviewed by Dan Bernstein.
2398
2399         * Misc/WebKitVersionChecks.h:
2400         * WebView/WebView.mm:
2401         (+[WebView enableWebThread]):
2402         (-[WebView _needsPreHTML5ParserQuirks]):
2403
2404 2017-07-08  Yusuke Suzuki  <utatane.tea@gmail.com>
2405
2406         Drop NOSNIFF compile flag
2407         https://bugs.webkit.org/show_bug.cgi?id=174289
2408
2409         Reviewed by Michael Catanzaro.
2410
2411         * Configurations/FeatureDefines.xcconfig:
2412
2413 2017-07-06  Yusuke Suzuki  <utatane.tea@gmail.com>
2414
2415         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2416         https://bugs.webkit.org/show_bug.cgi?id=174150
2417
2418         Reviewed by Mark Lam.
2419
2420         * DOM/DOM.mm:
2421         (lookupElementClass):
2422
2423 2017-07-06  Brady Eidson  <beidson@apple.com>
2424
2425         Add logging to first attempt to use the WebIconDatabase class.
2426         https://bugs.webkit.org/show_bug.cgi?id=174190
2427
2428         Reviewed by Andy Estes.
2429
2430         * Misc/WebIconDatabase.mm:
2431         (+[WebIconDatabase sharedIconDatabase]): On first call, log a warning of the bleak future of this non-API.
2432         * Misc/WebKitVersionChecks.h:
2433
2434 2017-07-06  Matt Lewis  <jlewis3@apple.com>
2435
2436         Unreviewed, rolling out r219178.
2437
2438         This caused a consistent failure with the API test
2439         StringBuilderTest.ToAtomicStringOnEmpty on all Debug testers.
2440
2441         Reverted changeset:
2442
2443         "[WTF] Clean up StringStatics.cpp by using
2444         LazyNeverDestroyed<> for Atoms"
2445         https://bugs.webkit.org/show_bug.cgi?id=174150
2446         http://trac.webkit.org/changeset/219178
2447
2448 2017-07-05  Don Olmstead  <don.olmstead@sony.com>
2449
2450         [WTF] Move SoftLinking.h into WTF
2451         https://bugs.webkit.org/show_bug.cgi?id=174000
2452
2453         Reviewed by Alex Christensen.
2454
2455         * Plugins/WebNetscapePluginView.mm:
2456         * Plugins/WebPluginController.mm:
2457         * WebCoreSupport/WebInspectorClient.mm:
2458         * WebView/WebFullScreenController.mm:
2459         * WebView/WebImmediateActionController.mm:
2460         * WebView/WebView.mm:
2461
2462 2017-07-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2463
2464         [WTF] Clean up StringStatics.cpp by using LazyNeverDestroyed<> for Atoms
2465         https://bugs.webkit.org/show_bug.cgi?id=174150
2466
2467         Reviewed by Mark Lam.
2468
2469         * DOM/DOM.mm:
2470         (lookupElementClass):
2471
2472 2017-07-05  Brady Eidson  <beidson@apple.com>
2473
2474         Allow navigations in subframes to get a ShouldOpenExternalURLsPolicy of "ShouldAllow".
2475         <rdar://problem/22485589> and https://bugs.webkit.org/show_bug.cgi?id=174178
2476
2477         Reviewed by Alex Christensen.
2478
2479         Adopt to the new constructor for FrameLoadRequest.
2480
2481         * WebView/WebPDFView.mm:
2482         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2483
2484 2017-07-05  Ryosuke Niwa  <rniwa@webkit.org>
2485
2486         Make WebKit's public headers on Mac and iOS C++ module safe
2487         https://bugs.webkit.org/show_bug.cgi?id=174175
2488
2489         Reviewed by Alex Christensen.
2490
2491         Fixed the header files.
2492
2493         * Misc/WebDownload.h:
2494         * Misc/WebKitErrors.h:
2495         * Plugins/WebPluginContainer.h:
2496         * WebView/WebResourceLoadDelegate.h:
2497
2498 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2499
2500         Remove copy of ICU headers from WebKit
2501         https://bugs.webkit.org/show_bug.cgi?id=116407
2502
2503         Reviewed by Alex Christensen.
2504
2505         Use WTF's copy of ICU headers.
2506
2507         * Configurations/WebKitLegacy.xcconfig:
2508         * icu/unicode/localpointer.h: Removed.
2509         * icu/unicode/parseerr.h: Removed.
2510         * icu/unicode/platform.h: Removed.
2511         * icu/unicode/ptypes.h: Removed.
2512         * icu/unicode/putil.h: Removed.
2513         * icu/unicode/uchar.h: Removed.
2514         * icu/unicode/uconfig.h: Removed.
2515         * icu/unicode/ucurr.h: Removed.
2516         * icu/unicode/uidna.h: Removed.
2517         * icu/unicode/uiter.h: Removed.
2518         * icu/unicode/umachine.h: Removed.
2519         * icu/unicode/unorm.h: Removed.
2520         * icu/unicode/unorm2.h: Removed.
2521         * icu/unicode/urename.h: Removed.
2522         * icu/unicode/uscript.h: Removed.
2523         * icu/unicode/ustring.h: Removed.
2524         * icu/unicode/utf.h: Removed.
2525         * icu/unicode/utf16.h: Removed.
2526         * icu/unicode/utf8.h: Removed.
2527         * icu/unicode/utf_old.h: Removed.
2528         * icu/unicode/utypes.h: Removed.
2529         * icu/unicode/uvernum.h: Removed.
2530         * icu/unicode/uversion.h: Removed.
2531
2532 2017-07-05  Jonathan Bedard  <jbedard@apple.com>
2533
2534         Add WebKitPrivateFrameworkStubs for iOS 11
2535         https://bugs.webkit.org/show_bug.cgi?id=173988
2536
2537         Reviewed by David Kilzer.
2538
2539         * Configurations/WebKitLegacy.xcconfig: iphoneos and iphonesimulator should
2540         use the same directory for private framework stubs.
2541
2542 2017-07-03  Matt Lewis  <jlewis3@apple.com>
2543
2544         Unreviewed, rolling out r219103.
2545
2546         Caused multiple build failures.
2547
2548         Reverted changeset:
2549
2550         "Remove copy of ICU headers from WebKit"
2551         https://bugs.webkit.org/show_bug.cgi?id=116407
2552         http://trac.webkit.org/changeset/219103
2553
2554 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
2555
2556         Remove copy of ICU headers from WebKit
2557         https://bugs.webkit.org/show_bug.cgi?id=116407
2558
2559         Reviewed by Alex Christensen.
2560
2561         Use WTF's copy of ICU headers.
2562
2563         * Configurations/WebKitLegacy.xcconfig:
2564         * icu/unicode/localpointer.h: Removed.
2565         * icu/unicode/parseerr.h: Removed.
2566         * icu/unicode/platform.h: Removed.
2567         * icu/unicode/ptypes.h: Removed.
2568         * icu/unicode/putil.h: Removed.
2569         * icu/unicode/uchar.h: Removed.
2570         * icu/unicode/uconfig.h: Removed.
2571         * icu/unicode/ucurr.h: Removed.
2572         * icu/unicode/uidna.h: Removed.
2573         * icu/unicode/uiter.h: Removed.
2574         * icu/unicode/umachine.h: Removed.
2575         * icu/unicode/unorm.h: Removed.
2576         * icu/unicode/unorm2.h: Removed.
2577         * icu/unicode/urename.h: Removed.
2578         * icu/unicode/uscript.h: Removed.
2579         * icu/unicode/ustring.h: Removed.
2580         * icu/unicode/utf.h: Removed.
2581         * icu/unicode/utf16.h: Removed.
2582         * icu/unicode/utf8.h: Removed.
2583         * icu/unicode/utf_old.h: Removed.
2584         * icu/unicode/utypes.h: Removed.
2585         * icu/unicode/uvernum.h: Removed.
2586         * icu/unicode/uversion.h: Removed.
2587
2588 2017-07-03  Brady Eidson  <beidson@apple.com>
2589
2590         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
2591         https://bugs.webkit.org/show_bug.cgi?id=174073
2592
2593         Reviewed by Andy Estes.
2594
2595         WebView now keeps a direct copy of its main frame icon as a member variable.
2596         It populates that variable by finding exactly one Favicon LinkIcon from WebCore and loading it.
2597         
2598         This change causes a progression in KVO observation of the mainFrameIcon property as we now
2599         have both the old icon and new icon at the time it changes.
2600
2601         * WebCoreSupport/WebFrameLoaderClient.h:
2602         * WebCoreSupport/WebFrameLoaderClient.mm:
2603         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2604         (WebFrameLoaderClient::getLoadDecisionForIcons):
2605         (WebFrameLoaderClient::finishedLoadingIcon):
2606         (WebFrameLoaderClient::dispatchDidReceiveIcon): Deleted.
2607         (WebFrameLoaderClient::registerForIconNotification): Deleted.
2608
2609         * WebView/WebView.mm:
2610         (+[WebView _setIconLoadingEnabled:]):
2611         (+[WebView _isIconLoadingEnabled]):
2612         (-[WebView mainFrameIcon]):
2613         (-[WebView _setMainFrameIcon:]):
2614         (-[WebView _receivedIconChangedNotification:]): Deleted.
2615         (-[WebView _registerForIconNotification:]): Deleted.
2616         (-[WebView _dispatchDidReceiveIconFromWebFrame:]): Deleted.
2617         * WebView/WebViewData.h:
2618         * WebView/WebViewInternal.h:
2619         * WebView/WebViewPrivate.h:
2620
2621 2017-07-03  Sam Weinig  <sam@webkit.org>
2622
2623         [WebIDL] Remove more unnecessary uses of the preprocessor in idl files
2624         https://bugs.webkit.org/show_bug.cgi?id=174083
2625
2626         Reviewed by Alex Christensen.
2627
2628         * Configurations/FeatureDefines.xcconfig:
2629         Add ENABLE_NAVIGATOR_STANDALONE.
2630
2631 2017-07-03  Tim Horton  <timothy_horton@apple.com>
2632
2633         Expose unobscuredSafeAreaInsets on WebView
2634         https://bugs.webkit.org/show_bug.cgi?id=174075
2635         <rdar://problem/33096997>
2636
2637         Reviewed by Beth Dakin.
2638
2639         * WebView/WebView.mm:
2640         (-[WebView _setUnobscuredSafeAreaInsets:]):
2641         (-[WebView _unobscuredSafeAreaInsets]):
2642         * WebView/WebViewPrivate.h:
2643         Expose unobscuredSafeAreaInsets as a new private property on WebView,
2644         similar to how it is exposed in WebKit2.
2645
2646 2017-07-03  Andy Estes  <aestes@apple.com>
2647
2648         [Xcode] Add an experimental setting to build with ccache
2649         https://bugs.webkit.org/show_bug.cgi?id=173875
2650
2651         Reviewed by Tim Horton.
2652
2653         * Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
2654
2655 2017-07-03  Tim Horton  <timothy_horton@apple.com>
2656
2657         Expose WebPreferences for viewport-fit and constant() properties
2658         https://bugs.webkit.org/show_bug.cgi?id=174072
2659         <rdar://problem/33096639>
2660
2661         Reviewed by Ryosuke Niwa.
2662
2663         * WebView/WebPreferenceKeysPrivate.h:
2664         * WebView/WebPreferences.mm:
2665         (-[WebPreferences viewportFitEnabled]):
2666         (-[WebPreferences setViewportFitEnabled:]):
2667         (-[WebPreferences constantPropertiesEnabled]):
2668         (-[WebPreferences setConstantPropertiesEnabled:]):
2669         * WebView/WebPreferencesPrivate.h:
2670         * WebView/WebView.mm:
2671         (-[WebView _preferencesChanged:]):
2672
2673 2017-07-01  Tim Horton  <timothy_horton@apple.com>
2674
2675         Expose viewport-fit value to UIKit via viewport arguments dictionary
2676         https://bugs.webkit.org/show_bug.cgi?id=174071
2677         <rdar://problem/33096620>
2678
2679         Reviewed by Wenson Hsieh.
2680
2681         * History/WebHistoryItem.mm:
2682         * History/WebHistoryItemPrivate.h:
2683         Add another dictionary key and three values.
2684
2685 2017-07-01  Dan Bernstein  <mitz@apple.com>
2686
2687         [iOS] Remove code only needed when building for iOS 9.x
2688         https://bugs.webkit.org/show_bug.cgi?id=174068
2689
2690         Reviewed by Tim Horton.
2691
2692         * Configurations/FeatureDefines.xcconfig:
2693
2694 2017-07-01  Ryosuke Niwa  <rniwa@webkit.org>
2695
2696         Frame.h doesn't need to include FrameLoader.h, IntRect.h, and NavigationScheduler.h
2697         https://bugs.webkit.org/show_bug.cgi?id=174004
2698
2699         Reviewed by Simon Fraser.
2700
2701         * WebCoreSupport/WebPluginInfoProvider.mm:
2702
2703 2017-07-01  Dan Bernstein  <mitz@apple.com>
2704
2705         [macOS] Remove code only needed when building for OS X Yosemite
2706         https://bugs.webkit.org/show_bug.cgi?id=174067
2707
2708         Reviewed by Tim Horton.
2709
2710         * Configurations/Base.xcconfig:
2711         * Configurations/DebugRelease.xcconfig:
2712         * Configurations/FeatureDefines.xcconfig:
2713         * Configurations/Version.xcconfig:
2714         * Plugins/WebBasePluginPackage.mm:
2715         (-[WebBasePluginPackage getPluginInfoFromPLists]):
2716         * WebCoreSupport/PopupMenuMac.mm:
2717         (PopupMenuMac::show):
2718         * WebCoreSupport/WebInspectorClient.mm:
2719         (WebInspectorFrontendClient::startWindowDrag):
2720         (-[WebInspectorWindowController window]):
2721         * WebView/WebView.mm:
2722         (-[WebView _animationControllerForDictionaryLookupPopupInfo:]):
2723
2724 2017-06-30  Daniel Bates  <dabates@apple.com>
2725
2726         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
2727         https://bugs.webkit.org/show_bug.cgi?id=165160
2728         <rdar://problem/29451999>
2729
2730         Reviewed by Brady Eidson.
2731
2732         Pass the document that is requesting the load to the loader.
2733
2734         * WebView/WebPDFView.mm:
2735         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2736
2737 2017-06-29  Jer Noble  <jer.noble@apple.com>
2738
2739         Make Legacy EME API controlled by RuntimeEnabled setting.
2740         https://bugs.webkit.org/show_bug.cgi?id=173994
2741
2742         Reviewed by Sam Weinig.
2743
2744         Add a new preference used to control WebCore's new RuntimeEnabledFeature setting.
2745
2746         * Configurations/FeatureDefines.xcconfig:
2747         * WebView/WebPreferenceKeysPrivate.h:
2748         * WebView/WebPreferences.mm:
2749         (+[WebPreferences initialize]):
2750         (-[WebPreferences legacyEncryptedMediaAPIEnabled]):
2751         (-[WebPreferences setLegacyEncryptedMediaAPIEnabled:]):
2752         * WebView/WebPreferencesPrivate.h:
2753         * WebView/WebView.mm:
2754         (-[WebView _preferencesChanged:]):
2755
2756 2017-06-30  Chris Dumez  <cdumez@apple.com>
2757
2758         ResourceLoadObserver does not need a ResourceLoadStatisticsStore
2759         https://bugs.webkit.org/show_bug.cgi?id=174013
2760
2761         Reviewed by Brent Fulgham.
2762
2763         ResourceLoadObserver does not need a ResourceLoadStatisticsStore. ResourceLoadStatisticsStore is too complicated for its needs.
2764         ResourceLoadStatisticsStore can then be moved to WebKit2/UIProcess in a follow-up.
2765
2766         * WebView/WebView.mm:
2767         (-[WebView _commonInitializationWithFrameName:groupName:]):
2768
2769 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
2770
2771         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
2772         https://bugs.webkit.org/show_bug.cgi?id=174017
2773         <rdar://problem/32959782>
2774
2775         Reviewed by Simon Fraser.
2776
2777         Use root view coordinates when computing the drag caret rect.
2778
2779         * WebView/WebView.mm:
2780         (-[WebView _dataInteractionCaretRect]):
2781
2782 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
2783
2784         Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
2785         https://bugs.webkit.org/show_bug.cgi?id=173899
2786         rdar://problem/32994474
2787
2788         Reviewed by Tim Horton.
2789
2790         When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
2791         then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
2792         that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
2793
2794         Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
2795         documentView is a WebHTMLView.
2796
2797         * WebView/WebFrame.mm:
2798         (-[WebFrame _webHTMLDocumentView]):
2799         (-[WebFrame _paintBehaviorForDestinationContext:]):
2800         (-[WebFrame _drawRect:contentsOnly:]):
2801         (-[WebFrame setTimeoutsPaused:]):
2802         (-[WebFrame prepareForPause]):
2803         (-[WebFrame resumeFromPause]):
2804         (-[WebFrame resetTextAutosizingBeforeLayout]):
2805         * WebView/WebHTMLView.mm:
2806         (-[WebHTMLView drawLayer:inContext:]):
2807         (-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
2808         * WebView/WebHTMLViewInternal.h:
2809
2810 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
2811
2812         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
2813         https://bugs.webkit.org/show_bug.cgi?id=173854
2814         <rdar://problem/32236827>
2815
2816         Reviewed by Ryosuke Niwa and Tim Horton.
2817
2818         Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
2819         WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
2820
2821         * WebView/WebView.mm:
2822         (-[WebView _startDrag:]):
2823         (-[WebView _dragSourceAction]):
2824         (-[WebView _draggedLinkTitle]):
2825         (-[WebView _draggedLinkURL]):
2826         (-[WebView _draggedElementBounds]):
2827         (-[WebView _endedDataInteraction:global:]):
2828         * WebView/WebViewData.h:
2829         * WebView/WebViewPrivate.h:
2830
2831 2017-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
2832
2833         Refactor drag start codepaths to plumb a DragItem to client layers
2834         https://bugs.webkit.org/show_bug.cgi?id=173832
2835         Work towards <rdar://problem/32236827>
2836
2837         Reviewed by Ryosuke Niwa and Tim Horton.
2838
2839         Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
2840         in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
2841         to _startDrag: to match logic used to start a drag on other platforms.
2842
2843         No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
2844         through the DragItem struct.
2845
2846         * WebCoreSupport/WebDragClient.h:
2847         * WebCoreSupport/WebDragClient.mm:
2848         (WebDragClient::startDrag):
2849         (WebDragClient::dragSourceActionMaskForPoint):
2850         (WebDragClient::willPerformDragSourceAction):
2851         (WebDragClient::beginDrag):
2852         * WebView/WebView.mm:
2853         (-[WebView _startDrag:]):
2854         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
2855         * WebView/WebViewInternal.h:
2856
2857 2017-06-25  Konstantin Tokarev  <annulen@yandex.ru>
2858
2859         Remove excessive headers from JavaScriptCore
2860         https://bugs.webkit.org/show_bug.cgi?id=173812
2861
2862         Reviewed by Darin Adler.
2863
2864         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
2865         * WebView/WebView.mm:
2866
2867 2017-06-23  Tim Horton  <timothy_horton@apple.com>
2868
2869         Remove an unused typedef from WebFrameLoaderClient
2870         https://bugs.webkit.org/show_bug.cgi?id=173795
2871
2872         Reviewed by Simon Fraser.
2873
2874         * WebCoreSupport/WebFrameLoaderClient.h:
2875         This unused typedef in the global namespace conflicts with one in a macOS system header.
2876         Also... it's unused.
2877         Remove it.
2878
2879 2017-06-23  Konstantin Tokarev  <annulen@yandex.ru>
2880
2881         Remove excessive headers from WebCore/{bindings,css,dom}
2882         https://bugs.webkit.org/show_bug.cgi?id=173766
2883
2884         Reviewed by Simon Fraser.
2885
2886         * DOM/DOMInternal.mm:
2887
2888 2017-06-22  Daniel Bates  <dabates@apple.com>
2889
2890         Make FrameLoadRequest a move-only type
2891         https://bugs.webkit.org/show_bug.cgi?id=173682
2892
2893         Reviewed by Alex Christensen and Darin Adler.
2894
2895         A FrameLoadRequest groups together the information to perform a load into a single object
2896         that is more manageable to pass around than its constituent parts. Code that receives a
2897         FrameLoadRequest is expected to extract out the information it needs to complete its task.
2898         And it does not make sense to re-use the same FrameLoadRequest object for more than one
2899         load. Therefore, it is sufficient to make FrameLoadRequest a move-only type.
2900
2901         * Plugins/WebPluginController.mm:
2902         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
2903         * WebView/WebPDFView.mm:
2904         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2905
2906 2017-06-21  Antoine Quint  <graouts@apple.com>
2907
2908         Ensure DRT always logs rAF suspension debugging code
2909         https://bugs.webkit.org/show_bug.cgi?id=173681
2910
2911         Reviewed by Tim "Mr. T" Horton.
2912
2913         * WebView/WebPreferenceKeysPrivate.h:
2914         * WebView/WebPreferences.mm:
2915         (+[WebPreferences initialize]):
2916         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]): Deleted.
2917         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]): Deleted.
2918         * WebView/WebPreferencesPrivate.h:
2919         * WebView/WebView.mm:
2920         (-[WebView _preferencesChanged:]):
2921
2922 2017-06-21  Daniel Bates  <dabates@apple.com>
2923
2924         Cleanup FrameLoadRequest
2925         https://bugs.webkit.org/show_bug.cgi?id=173564
2926         <rdar://problem/32903570>
2927
2928         Reviewed by Brent Fulgham.
2929
2930         * WebView/WebPDFView.mm:
2931         (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Move FrameLoadRequest instantiation
2932         into a local variable and use C++11 brace initialization syntax to make it easier to identify
2933         the arguments passed to FrameLoader::loadFrameRequest().
2934
2935 2017-06-21  Antoine Quint  <graouts@apple.com>
2936
2937         Add logging to identify when the Page suspends scripted animations
2938         https://bugs.webkit.org/show_bug.cgi?id=173626
2939
2940         Reviewed by Tim Horton.
2941
2942         Add a new preference to control the new shouldLogScriptedAnimationControllerSuspensionChange settings
2943         through WebKit. This is specific to WK1 since the issue we're trying to pinpoint only occurs on WK1 bots.
2944
2945         * WebView/WebPreferenceKeysPrivate.h:
2946         * WebView/WebPreferences.mm:
2947         (+[WebPreferences initialize]):
2948         (-[WebPreferences shouldLogScriptedAnimationControllerSuspensionChange]):
2949         (-[WebPreferences setShouldLogScriptedAnimationControllerSuspensionChange:]):
2950         * WebView/WebPreferencesPrivate.h:
2951         * WebView/WebView.mm:
2952         (-[WebView _preferencesChanged:]):
2953
2954 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
2955
2956         Disable font variations on macOS Sierra and iOS 10
2957         https://bugs.webkit.org/show_bug.cgi?id=173618
2958         <rdar://problem/32879164>
2959
2960         Reviewed by Jon Lee.
2961
2962         * Configurations/FeatureDefines.xcconfig:
2963
2964 2017-06-20  Daniel Bates  <dabates@apple.com>
2965
2966         Have FrameLoadRequest takes a Frame& instead of a Frame*
2967         https://bugs.webkit.org/show_bug.cgi?id=173614
2968         <rdar://problem/32884890>
2969
2970         Reviewed by Brent Fulgham.
2971
2972         * Plugins/WebPluginController.mm:
2973         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
2974         * WebView/WebFrame.mm:
2975         (-[WebFrame loadRequest:]):
2976         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
2977
2978 2017-06-19  Frederic Wang  <fwang@igalia.com>
2979
2980         [Mac] Add an experimental feature setting for async frame scrolling
2981         https://bugs.webkit.org/show_bug.cgi?id=173359
2982
2983         Reviewed by Simon Fraser.
2984
2985         * WebView/WebPreferenceKeysPrivate.h: Declare key for async frame scrolling preference.
2986         * WebView/WebPreferences.mm:
2987         (+[WebPreferences initialize]): Initialize async frame scrolling preference to false.
2988         (-[WebPreferences asyncFrameScrollingEnabled]): Define getter for async frame scrolling.
2989         (-[WebPreferences setAsyncFrameScrollingEnabled:]): Define setter for async frame scrolling.
2990         * WebView/WebPreferencesPrivate.h: Declare setter and getter.
2991         * WebView/WebView.mm:
2992         (-[WebView _preferencesChanged:]): Take into account preference update for async frame
2993         scrolling.
2994
2995 2017-06-19  Chris Dumez  <cdumez@apple.com>
2996
2997         Use WTF::Function instead of std::function in more places in WebCore/
2998         https://bugs.webkit.org/show_bug.cgi?id=173535
2999
3000         Reviewed by Antti Koivisto.
3001
3002         Use WTF::Function instead of std::function in more places in WebCore/ to avoid copying.
3003
3004         * WebCoreSupport/WebFrameLoaderClient.h:
3005         * WebCoreSupport/WebFrameLoaderClient.mm:
3006         (WebFrameLoaderClient::dispatchDecidePolicyForResponse):
3007         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3008         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3009         (WebFrameLoaderClient::dispatchWillSubmitForm):
3010         (WebFrameLoaderClient::setUpPolicyListener):
3011         (-[WebFramePolicyListener initWithFrame:policyFunction:]):
3012         (-[WebFramePolicyListener initWithFrame:policyFunction:appLinkURL:]):
3013
3014 2017-05-14 Frederic Wang  <fwang@igalia.com>
3015
3016         Add heuristic to avoid flattening "fullscreen" iframes
3017         https://bugs.webkit.org/show_bug.cgi?id=171914
3018
3019         Reviewed by Simon Fraser.
3020
3021         This commit adjusts the mac/ios preference interface to treat frame flattening as an enum.
3022
3023         * WebView/WebPreferenceKeysPrivate.h: Rename the key.
3024         * WebView/WebPreferences.mm:
3025         (+[WebPreferences initialize]): Handle frame flattening as an enum.
3026         (-[WebPreferences isFrameFlatteningEnabled]): Ditto.
3027         (-[WebPreferences setFrameFlatteningEnabled:]): Ditto.
3028         (-[WebPreferences frameFlattening]): New function to get frame flattening as an enum.
3029         (-[WebPreferences setFrameFlattening:]): New function to set frame flattening as an enum.
3030         * WebView/WebPreferencesPrivate.h: Ditto.
3031         * WebView/WebView.mm:
3032         (-[WebView _preferencesChanged:]): Ditto.
3033         * WebView/WebPreferencesPrivate.h: Add new enum definition.
3034
3035 2017-06-17  Chris Dumez  <cdumez@apple.com>
3036
3037         Use WTF::Function instead of std::function in WebKit2/
3038         https://bugs.webkit.org/show_bug.cgi?id=173504
3039
3040         Reviewed by Darin Adler.
3041
3042         Use WTF::Function instead of std::function in WebKit2/ to avoid
3043         unnecessary copying.
3044
3045         * Plugins/Hosted/HostedNetscapePluginStream.h:
3046         * Plugins/Hosted/HostedNetscapePluginStream.mm:
3047         (WebKit::HostedNetscapePluginStream::willSendRequest):
3048         * Plugins/WebNetscapePluginStream.h:
3049         * Plugins/WebNetscapePluginStream.mm:
3050         (WebNetscapePluginStream::willSendRequest):
3051         * WebCoreSupport/WebPaymentCoordinatorClient.h:
3052         * WebCoreSupport/WebPaymentCoordinatorClient.mm:
3053         (WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
3054         (WebPaymentCoordinatorClient::openPaymentSetup):
3055
3056 2017-06-16  Sam Weinig  <sam@webkit.org>
3057
3058         [WebIDL] Remove custom bindings for HTMLDocument
3059         https://bugs.webkit.org/show_bug.cgi?id=173444
3060
3061         Reviewed by Darin Adler.
3062
3063         * DOM/DOMHTMLDocument.mm:
3064         (-[DOMHTMLDocument linkColor]):
3065         (-[DOMHTMLDocument setLinkColor:]):
3066         (-[DOMHTMLDocument write:]):
3067         (-[DOMHTMLDocument writeln:]):
3068         Update for new signature of write/writeln and rename of linkColor to linkColorForBindings.
3069
3070 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3071
3072         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
3073         https://bugs.webkit.org/show_bug.cgi?id=173366
3074         <rdar://problem/32767014>
3075
3076         Reviewed by Tim Horton.
3077
3078         Move pieces of iOS WebKit1 drag and drop implementation into OpenSource. No change in behavior.
3079
3080         * Configurations/FeatureDefines.xcconfig:
3081         * WebCoreSupport/WebDragClient.mm:
3082         (WebDragClient::useLegacyDragClient):
3083         (WebDragClient::willPerformDragDestinationAction):
3084         (WebDragClient::dragSourceActionMaskForPoint):
3085         (WebDragClient::willPerformDragSourceAction):
3086         (WebDragClient::startDrag):
3087         (WebDragClient::beginDrag):
3088         (WebDragClient::declareAndWriteDragImage):
3089         (WebDragClient::declareAndWriteAttachment):
3090         (WebDragClient::didConcludeEditDrag):
3091         * WebView/WebView.mm:
3092         (-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]):
3093         (-[WebView _getDataInteractionData]):
3094         (-[WebView dragDataForSession:client:global:operation:]):
3095         (-[WebView _enteredDataInteraction:client:global:operation:]):
3096         (-[WebView _updatedDataInteraction:client:global:operation:]):
3097         (-[WebView _exitedDataInteraction:client:global:operation:]):
3098         (-[WebView _performDataInteraction:client:global:operation:]):
3099         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
3100         (-[WebView _endedDataInteraction:global:]):
3101         (-[WebView _didConcludeEditDataInteraction]):
3102         (floatRectsForCGRectArray): Deleted.
3103         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]): Deleted.
3104         * WebView/WebViewData.h:
3105         * WebView/WebViewData.mm:
3106         (-[WebViewPrivate dealloc]):
3107         * WebView/WebViewPrivate.h:
3108
3109 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3110
3111         [iOS DnD] [WK1] Dropping links onto UIWebViews should not trigger navigation by default
3112         https://bugs.webkit.org/show_bug.cgi?id=173454
3113         <rdar://problem/31720671>
3114
3115         Reviewed by Tim Horton.
3116
3117         Adds -webView:dragDestinationActionMaskForSession: as SPI to WebUIDelegate.
3118         If unimplemented, the default UI delegate allows all actions except for URL loading.
3119
3120         * DefaultDelegates/WebDefaultUIDelegate.mm:
3121         (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForSession:]):
3122         * WebView/WebUIDelegatePrivate.h:
3123         * WebView/WebView.mm:
3124         (-[WebView dragDestinationActionMaskForSession:]):
3125
3126 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3127
3128         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
3129         https://bugs.webkit.org/show_bug.cgi?id=173338
3130         <rdar://problem/32777720>
3131
3132         Reviewed by Tim Horton.
3133
3134         Rename updatePreferredTypeIdentifiers to updateSupportedTypeIdentifiers.
3135
3136         * WebCoreSupport/WebPlatformStrategies.h:
3137         * WebCoreSupport/WebPlatformStrategies.mm:
3138         (WebPlatformStrategies::updateSupportedTypeIdentifiers):
3139         (WebPlatformStrategies::updatePreferredTypeIdentifiers): Deleted.
3140
3141 2017-06-13  Daniel Bates  <dabates@apple.com>
3142
3143         Implement W3C Secure Contexts Draft Specification
3144         https://bugs.webkit.org/show_bug.cgi?id=158121
3145         <rdar://problem/26012994>
3146
3147         Reviewed by Brent Fulgham.
3148
3149         Part 4
3150
3151         Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
3152
3153         * WebView/WebPreferenceKeysPrivate.h:
3154         * WebView/WebPreferences.mm:
3155         (+[WebPreferences initialize]):
3156         (-[WebPreferences isSecureContextAttributeEnabled]):
3157         (-[WebPreferences setIsSecureContextAttributeEnabled:]):
3158         * WebView/WebPreferencesPrivate.h:
3159         * WebView/WebView.mm:
3160         (-[WebView _preferencesChanged:]):
3161
3162 2017-06-13  Sam Weinig  <sam@webkit.org>
3163
3164         Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
3165         https://bugs.webkit.org/show_bug.cgi?id=80733
3166
3167         Reviewed by Chris Dumez.
3168
3169         * DOM/DOMUtility.mm:
3170         (createDOMWrapper):
3171         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3172         (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
3173         * WebView/WebFrame.mm:
3174         (-[WebFrame _attachScriptDebugger]):
3175         (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
3176
3177 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
3178
3179         [WebCrypto] Remove experimental feature flag of SubtleCrypto
3180         https://bugs.webkit.org/show_bug.cgi?id=173197
3181         <rdar://problem/32688148>
3182
3183         Reviewed by Brent Fulgham.
3184
3185         * WebView/WebPreferences.mm:
3186         (+[WebPreferences initialize]):
3187         (-[WebPreferences subtleCryptoEnabled]): Deleted.
3188         (-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
3189         * WebView/WebPreferencesPrivate.h:
3190         * WebView/WebView.mm:
3191         (-[WebView _preferencesChanged:]):
3192
3193 2017-06-10  Dan Bernstein  <mitz@apple.com>
3194
3195         Reverted r218056 because it made the IDE reindex constantly.
3196
3197         * Configurations/DebugRelease.xcconfig:
3198
3199 2017-06-10  Dan Bernstein  <mitz@apple.com>
3200
3201         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
3202         https://bugs.webkit.org/show_bug.cgi?id=173223
3203
3204         Reviewed by Sam Weinig.
3205
3206         The rebuilds were happening due to a difference in the compiler options that the IDE and
3207         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
3208         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
3209         specify an appropriate path in CLANG_INDEX_STORE_PATH.
3210
3211         * Configurations/DebugRelease.xcconfig:
3212
3213 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3214
3215         [iOS DnD] Add a hook to perform two-step drops in editable content
3216         https://bugs.webkit.org/show_bug.cgi?id=172992
3217         <rdar://problem/32590174>
3218
3219         Reviewed by Tim Horton.
3220
3221         Adds a new SPI to WebUIKitDelegate to allow WK1 clients to override default drop behavior. Returning YES from
3222         -performTwoStepDrop:atDestination:isMove: will prevent content from being inserted on drop in WebKit; otherwise,
3223         returning NO will continue with default WebKit behavior.
3224
3225         * WebCoreSupport/WebEditorClient.h:
3226         * WebCoreSupport/WebEditorClient.mm:
3227         (WebEditorClient::performTwoStepDrop):
3228
3229 2017-06-08  Jer Noble  <jer.noble@apple.com>
3230
3231         Clients of the WK2 C-API don't have their mediaContentTypesRequiringHardwareSupport setting initialized correctly.
3232         https://bugs.webkit.org/show_bug.cgi?id=173091
3233
3234         Reviewed by Eric Carlson.
3235
3236         * WebView/WebPreferences.mm:
3237         (+[WebPreferences initialize]):
3238
3239 2017-06-07  Jer Noble  <jer.noble@apple.com>
3240
3241         Clean-up: RenderElement.h includes headers it doesn't use
3242         https://bugs.webkit.org/show_bug.cgi?id=173046
3243
3244         Reviewed by Andy Estes.
3245
3246         * WebView/WebImmediateActionController.mm:
3247
3248 2017-06-07  Zalan Bujtas  <zalan@apple.com>
3249
3250         [iOS WK1 WebThread] Do not call out to the main thread for device orientation.
3251         https://bugs.webkit.org/show_bug.cgi?id=173044
3252         <rdar://problem/32449338>
3253
3254         Reviewed by Tim Horton.
3255
3256         Cache the current device orientation so that we don't have to lift the WebThread lock
3257         to collect it.
3258
3259         * WebView/WebFrame.mm:
3260         (-[WebFrame deviceOrientationChanged]):
3261         * WebView/WebView.mm:
3262         (-[WebView _commonInitializationWithFrameName:groupName:]):
3263         (-[WebView _setDeviceOrientation:]):
3264         (-[WebView _deviceOrientation]):
3265         * WebView/WebViewData.h:
3266         * WebView/WebViewInternal.h:
3267
3268 2017-06-06  Jer Noble  <jer.noble@apple.com>
3269
3270         [Cocoa] Set defaults for mediaContentTypesRequiringHardwareSupport setting
3271         https://bugs.webkit.org/show_bug.cgi?id=173008
3272
3273         Reviewed by Eric Carlson.
3274
3275         Add a private preference (with default) for the mediaContentTypesRequiringHardwareSupport WebCore setting.
3276
3277         * WebView/WebPreferenceKeysPrivate.h:
3278         * WebView/WebPreferences.mm:
3279         (+[WebPreferences initialize]):
3280         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
3281         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
3282         * WebView/WebPreferencesPrivate.h:
3283         * WebView/WebView.mm:
3284         (-[WebView _preferencesChanged:]):
3285
3286 2017-06-06  Youenn Fablet  <youenn@apple.com>
3287
3288         Add an option to disable getUserMedia prompt in case of mock capture sources
3289         https://bugs.webkit.org/show_bug.cgi?id=172981
3290         <rdar://problem/32580325>
3291
3292         Reviewed by Eric Carlson.
3293
3294         Defining the option, getter and setter.
3295
3296         * WebView/WebPreferences.mm:
3297         (+[WebPreferences initialize]):
3298         (-[WebPreferences mockCaptureDevicesPromptEnabled]):
3299         (-[WebPreferences setMockCaptureDevicesPromptEnabled:]):
3300         * WebView/WebPreferencesPrivate.h:
3301
3302 2017-06-05  Dan Bernstein  <mitz@apple.com>
3303
3304         Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.
3305
3306         * WebView/WebView.mm:
3307         (-[WebView updateMediaTouchBar]):
3308         * WebView/WebViewData.h:
3309
3310 2017-06-03  Darin Adler  <darin@apple.com>
3311
3312         Streamline handling of attributes, using references as much as possible
3313         https://bugs.webkit.org/show_bug.cgi?id=172899
3314
3315         Reviewed by Chris Dumez.
3316
3317         * WebView/WebHTMLRepresentation.mm:
3318         (matchLabelsAgainstElement): Added handling of nullptr since nothing guarantees the
3319         passed in element can't be null. Removed unnecessary conversion from NSString to String
3320         and then back to NSString.
3321
3322 2017-06-01  Andy Estes  <aestes@apple.com>
3323
3324         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
3325         https://bugs.webkit.org/show_bug.cgi?id=172828
3326
3327         Reviewed by Beth Dakin.
3328
3329         * Configurations/FeatureDefines.xcconfig:
3330
3331 2017-05-31  Andy Estes  <aestes@apple.com>
3332
3333         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
3334         https://bugs.webkit.org/show_bug.cgi?id=172366
3335
3336         Reviewed by Daniel Bates.
3337
3338         * Configurations/FeatureDefines.xcconfig:
3339
3340 2017-05-30  Ryosuke Niwa  <rniwa@webkit.org>
3341
3342         Only include DataDetectorsUI headers in iOS
3343         https://bugs.webkit.org/show_bug.cgi?id=172633
3344
3345         Reviewed by David Kilzer.
3346
3347         Enable data detectors only on iOS and not other variants of iOS.
3348
3349         * WebCoreSupport/WebFrameLoaderClient.mm:
3350
3351 2017-05-30  Alex Christensen  <achristensen@webkit.org>
3352
3353         Update libwebrtc configuration
3354         https://bugs.webkit.org/show_bug.cgi?id=172727
3355
3356         Reviewed by Geoffrey Garen.
3357
3358         * Configurations/FeatureDefines.xcconfig:
3359
3360 2017-05-28  Dan Bernstein  <mitz@apple.com>
3361
3362         [Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
3363         https://bugs.webkit.org/show_bug.cgi?id=172691
3364
3365         Reviewed by Tim Horton.
3366
3367         * Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
3368
3369 2017-05-26  Brent Fulgham  <bfulgham@apple.com>
3370
3371         [WK2] Address thread safety issues with ResourceLoadStatistics
3372         https://bugs.webkit.org/show_bug.cgi?id=172519
3373         <rdar://problem/31707642>
3374
3375         Reviewed by Chris Dumez.
3376
3377         Create a new WorkQueue for the ResourceLoadStatistics store to use for processing data.
3378
3379         * WebView/WebView.mm:
3380         (WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Pass WorkQueue to the observer.
3381
3382 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
3383
3384         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
3385         https://bugs.webkit.org/show_bug.cgi?id=172554
3386         <rdar://problem/31247133>
3387
3388         Reviewed by Simon Fraser.
3389
3390         Update an overridden internal AppKit function to the new signature.
3391
3392         * WebView/WebHTMLView.mm:
3393         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inContext:topView:]):
3394         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:shouldChangeFontReferenceColor:_recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]):
3395         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Deleted.
3396         (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inGraphicsContext:CGContext:topView:shouldChangeFontReferenceColor:]): Deleted.
3397
3398 2017-05-24  Jer Noble  <jer.noble@apple.com>
3399
3400         Rename DisplaySleepDisabler -> SleepDisabler
3401         https://bugs.webkit.org/show_bug.cgi?id=172478
3402
3403         Reviewed by Sam Weinig.
3404
3405         * WebView/WebFullScreenController.h:
3406
3407 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
3408
3409         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
3410         https://bugs.webkit.org/show_bug.cgi?id=172522
3411         rdar://problem/31071812
3412
3413         Reviewed by Tim Horton.
3414
3415         There's no need to consult -[NSWindow viewsNeedDisplay] on newer OSes. It was
3416         added in r58623, and modified in r61204 for Carbon apps, but with more recent AppKit
3417         versions this synchronization is no longer required.
3418
3419         * WebView/WebView.mm:
3420         (LayerFlushController::flushLayers):
3421
3422 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
3423
3424         Snapshotting via -renderInContext: should do synchronous image decodes
3425         https://bugs.webkit.org/show_bug.cgi?id=172485
3426         rdar://problem/32276146
3427
3428         Reviewed by Tim Horton.
3429
3430         Remove the _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap: SPI that no longer
3431         has any callers.
3432
3433         * Plugins/WebBaseNetscapePluginView.h:
3434         * Plugins/WebBaseNetscapePluginView.mm:
3435         (-[WebBaseNetscapePluginView inFlatteningPaint]): Deleted.
3436         * WebView/WebFrame.mm:
3437         (-[WebFrame _paintBehaviorForDestinationContext:]):
3438         (-[WebFrame _drawRect:contentsOnly:]):
3439         (-[WebFrame _shouldFlattenCompositingLayers:]): Deleted.
3440         * WebView/WebHTMLView.mm:
3441         (imageFromRect):
3442         * WebView/WebView.mm:
3443         (-[WebView _commonInitializationWithFrameName:groupName:]):
3444         (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): Deleted.
3445         (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]): Deleted.
3446         * WebView/WebViewData.h:
3447         * WebView/WebViewPrivate.h:
3448
3449 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
3450
3451         Remove dead ENABLE(FONT_LOAD_EVENTS) code
3452         https://bugs.webkit.org/show_bug.cgi?id=172517
3453
3454         Rubber-stamped by Simon Fraser.
3455
3456         * Configurations/FeatureDefines.xcconfig:
3457
3458 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
3459
3460         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
3461         https://bugs.webkit.org/show_bug.cgi?id=171984
3462
3463         Reviewed by Antti Koivisto.
3464
3465         * WebView/WebPreferenceKeysPrivate.h:
3466         * WebView/WebPreferences.mm:
3467         (+[WebPreferences initialize]):
3468         (-[WebPreferences displayContentsEnabled]):
3469         (-[WebPreferences setDisplayContentsEnabled:]):
3470         * WebView/WebPreferencesPrivate.h:
3471         * WebView/WebView.mm:
3472         (-[WebView _preferencesChanged:]):
3473
3474 2017-05-22  Youenn Fablet  <youenn@apple.com>
3475
3476         Remove AVAudioCaptureSource
3477         https://bugs.webkit.org/show_bug.cgi?id=172360
3478
3479         Reviewed by Sam Weinig.
3480
3481         Removing the handling of AVAudio/CoreAudio capture source dynamic switch.
3482
3483         * WebView/WebPreferenceKeysPrivate.h:
3484         * WebView/WebPreferences.mm:
3485         (+[WebPreferences initialize]):
3486         (-[WebPreferences useAVFoundationAudioCapture]): Deleted.
3487         (-[WebPreferences setUseAVFoundationAudioCapture:]): Deleted.
3488         * WebView/WebPreferencesPrivate.h:
3489         * WebView/WebView.mm:
3490         (-[WebView _preferencesChanged:]):
3491
3492 2017-05-22  Sam Weinig  <sam@webkit.org>
3493
3494         [WebIDL] Support callbacks with arbitrary return types
3495         https://bugs.webkit.org/show_bug.cgi?id=172407
3496
3497         Reviewed by Chris Dumez.
3498
3499         * DOM/DOM.mm:
3500         (-[DOMNodeFilter acceptNode:]):
3501         Update for CallbackResult adoption in the base class.
3502
3503         * DOM/DOMNodeIterator.mm:
3504         * DOM/DOMTreeWalker.mm:
3505         Update to account for new WebCore implementation return types. We return nil
3506         if there was an exception, since retains the existing behavior if a javascript
3507         NodeFilter had been used (an exception would cause all nodes to be rejected,
3508         thus returning nullptr).
3509
3510         * DOM/ObjCNodeFilterCondition.h:
3511         * DOM/ObjCNodeFilterCondition.mm:
3512         Update to match new interface of NodeFilterCondition.
3513
3514 2017-05-18  Sam Weinig  <sam@webkit.org>
3515
3516         [WebIDL] Remove the need for the generator to know about native type mapping
3517         https://bugs.webkit.org/show_bug.cgi?id=172310
3518
3519         Reviewed by Darin Adler.
3520
3521         * DOM/DOM.mm:
3522         (-[DOMNodeFilter acceptNode:]):
3523         Update to pass Node by reference.
3524
3525 2017-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3526
3527         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
3528         https://bugs.webkit.org/show_bug.cgi?id=172098
3529
3530         Reviewed by Saam Barati.
3531
3532         * Plugins/Hosted/ProxyInstance.mm:
3533         * Plugins/Hosted/ProxyRuntimeObject.mm:
3534
3535 2017-05-18  Andy Estes  <aestes@apple.com>
3536
3537         ENABLE(APPLE_PAY_DELEGATE) should be NO on macOS Sierra and earlier
3538         https://bugs.webkit.org/show_bug.cgi?id=172305
3539
3540         Reviewed by Anders Carlsson.
3541
3542         * Configurations/FeatureDefines.xcconfig:
3543
3544 2017-05-18  Commit Queue  <commit-queue@webkit.org>
3545
3546         Unreviewed, rolling out r217031, r217032, and r217037.
3547         https://bugs.webkit.org/show_bug.cgi?id=172293
3548
3549         cause linking errors in Windows (Requested by yusukesuzuki on
3550         #webkit).
3551
3552         Reverted changesets:
3553
3554         "[JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass"
3555         https://bugs.webkit.org/show_bug.cgi?id=172098
3556         http://trac.webkit.org/changeset/217031
3557
3558         "Unreviewed, rebaseline for newly added ClassInfo"
3559         https://bugs.webkit.org/show_bug.cgi?id=172098
3560         http://trac.webkit.org/changeset/217032
3561
3562         "Unreviewed, fix debug and non-JIT build"
3563         https://bugs.webkit.org/show_bug.cgi?id=172098
3564         http://trac.webkit.org/changeset/217037
3565
3566 2017-05-16  Yusuke Suzuki  <utatane.tea@gmail.com>
3567
3568         [JSC][DFG][DOMJIT] Extend CheckDOM to CheckSubClass
3569         https://bugs.webkit.org/show_bug.cgi?id=172098
3570
3571         Reviewed by Saam Barati.
3572
3573         * Plugins/Hosted/ProxyInstance.mm:
3574         * Plugins/Hosted/ProxyRuntimeObject.mm:
3575
3576 2017-05-17  Matt Lewis  <jlewis3@apple.com>
3577
3578         Unreviewed, rolling out r216974.
3579
3580         Revision caused consistent timeouts on all platforms.
3581
3582         Reverted changeset:
3583
3584         "Add a RuntimeEnabledFeature for display: contents, defaulted
3585         to false."
3586         https://bugs.webkit.org/show_bug.cgi?id=171984
3587         http://trac.webkit.org/changeset/216974
3588
3589 2017-05-17  Emilio Cobos Álvarez  <ecobos@igalia.com>
3590
3591         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
3592         https://bugs.webkit.org/show_bug.cgi?id=171984
3593
3594         Reviewed by Antti Koivisto.
3595
3596         * WebView/WebPreferenceKeysPrivate.h:
3597         * WebView/WebPreferences.mm:
3598         (+[WebPreferences initialize]):
3599         (-[WebPreferences displayContentsEnabled]):
3600         (-[WebPreferences setDisplayContentsEnabled:]):
3601         * WebView/WebPreferencesPrivate.h:
3602         * WebView/WebView.mm:
3603         (-[WebView _preferencesChanged:]):
3604
3605 2017-05-16  Sam Weinig  <sam@webkit.org>
3606
3607         Bring Notification.idl up to spec
3608         https://bugs.webkit.org/show_bug.cgi?id=172156
3609
3610         Reviewed by Chris Dumez.
3611
3612         * WebCoreSupport/WebNotificationClient.h:
3613         * WebCoreSupport/WebNotificationClient.mm:
3614         (generateNotificationID):
3615         (WebNotificationClient::show):
3616         (WebNotificationClient::cancel):
3617         (WebNotificationClient::clearNotifications):
3618         (WebNotificationClient::notificationObjectDestroyed):
3619         (WebNotificationClient::requestPermission):
3620         (WebNotificationClient::hasPendingPermissionRequests):
3621         (WebNotificationClient::checkPermission):
3622         (-[WebNotificationPolicyListener allow]):
3623         (-[WebNotificationPolicyListener deny]):
3624         * WebView/WebNotification.mm:
3625         (-[WebNotification iconURL]):
3626         (-[WebNotification dir]):
3627         Simplify #ifdefs and update for enum vs String usage.
3628
3629 2017-05-15  Said Abou-Hallawa  <sabouhallawa@apple.com>
3630
3631         Do not delete asynchronously decoded frames for large images if their clients are in the viewport
3632         https://bugs.webkit.org/show_bug.cgi?id=170640
3633
3634         Reviewed by Simon Fraser.
3635
3636         Enable the async decoding for large images.
3637
3638         * WebView/WebView.mm:
3639         (-[WebView _preferencesChanged:]):
3640
3641 2017-05-15  Jer Noble  <jer.noble@apple.com>
3642
3643         Add experimental setting to allow document gesture interaction to fulfill media playback gesture requirement
3644         https://bugs.webkit.org/show_bug.cgi?id=172131
3645
3646         Reviewed by Eric Carlson.
3647
3648         * WebView/WebPreferenceKeysPrivate.h:
3649         * WebView/WebPreferences.mm:
3650         (+[WebPreferences initialize]):
3651         (-[WebPreferences mediaUserGestureInheritsFromDocument]):
3652         (-[WebPreferences setMediaUserGestureInheritsFromDocument:]):
3653         * WebView/WebPreferencesPrivate.h:
3654
3655 2017-05-12  Chris Dumez  <cdumez@apple.com>
3656
3657         Drop uses of PassRefPtr in WebKit/mac
3658         https://bugs.webkit.org/show_bug.cgi?id=172066
3659
3660         Reviewed by Sam Weinig.
3661
3662         * History/WebBackForwardListInternal.h:
3663         * History/WebHistoryItem.mm:
3664         (kit):
3665         (-[WebHistoryItem initWithWebCoreHistoryItem:]):
3666         * History/WebHistoryItemInternal.h:
3667         * Plugins/Hosted/HostedNetscapePluginStream.h:
3668         (WebKit::HostedNetscapePluginStream::create):
3669         * Plugins/Hosted/NetscapePluginHostManager.h:
3670         * Plugins/Hosted/NetscapePluginHostManager.mm:
3671         (WebKit::NetscapePluginHostManager::instantiatePlugin):
3672         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3673         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3674         (WebKit::NetscapePluginInstanceProxy::PluginRequest::create):
3675         (WebKit::NetscapePluginInstanceProxy::create):
3676         (WebKit::NetscapePluginInstanceProxy::setManualStream):
3677         * Plugins/Hosted/ProxyInstance.h:
3678         (WebKit::ProxyInstance::create):
3679         * Plugins/Hosted/ProxyInstance.mm:
3680         (WebKit::ProxyInstance::ProxyInstance):
3681         (WebKit::ProxyInstance::newRuntimeObject):
3682         * Plugins/Hosted/ProxyRuntimeObject.h:
3683         (WebKit::ProxyRuntimeObject::create):
3684         * Plugins/Hosted/ProxyRuntimeObject.mm:
3685         (WebKit::ProxyRuntimeObject::ProxyRuntimeObject):
3686         * Plugins/Hosted/WebHostedNetscapePluginView.h:
3687         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3688         (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
3689         * Plugins/WebBaseNetscapePluginView.h:
3690         * Plugins/WebBaseNetscapePluginView.mm:
3691         (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
3692         * Plugins/WebNetscapePluginStream.h:
3693         (WebNetscapePluginStream::create):
3694         * Plugins/WebNetscapePluginView.h:
3695         * Plugins/WebNetscapePluginView.mm:
3696         (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):
3697         * WebCoreSupport/WebChromeClient.mm:
3698         * WebCoreSupport/WebEditorClient.mm:
3699         * WebCoreSupport/WebNotificationClient.mm:
3700         (WebNotificationClient::requestPermission):
3701         (-[WebNotificationPolicyListener initWithCallback:]):
3702         * WebCoreSupport/WebOpenPanelResultListener.mm:
3703         * WebCoreSupport/WebUserMediaClient.mm:
3704         (WebUserMediaClient::requestUserMediaAccess):
3705         (WebUserMediaClient::enumerateMediaDevices):
3706         (-[WebUserMediaPolicyListener initWithUserMediaRequest:]):
3707         (-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):
3708         * WebView/WebArchive.mm:
3709         (-[WebArchivePrivate initWithCoreArchive:]):
3710         (-[WebArchivePrivate setCoreArchive:]):
3711         (-[WebArchive initWithData:]):
3712         (-[WebArchive subframeArchives]):
3713         (-[WebArchive _initWithCoreLegacyWebArchive:]):
3714         * WebView/WebArchiveInternal.h:
3715         * WebView/WebDataSource.mm:
3716         (WebDataSourcePrivate::WebDataSourcePrivate):
3717         (WebDataSourcePrivate::~WebDataSourcePrivate):
3718         (-[WebDataSource _initWithDocumentLoader:]):
3719         * WebView/WebDataSourceInternal.h:
3720         * WebView/WebDeviceOrientation.mm:
3721         (-[WebDeviceOrientation initWithCoreDeviceOrientation:]):
3722         * WebView/WebDeviceOrientationInternal.h:
3723         * WebView/WebFrame.mm:
3724         (-[WebFrame _convertToDOMRange:]):
3725         (-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):
3726         * WebView/WebFrameInternal.h:
3727         * WebView/WebFullScreenController.h:
3728         * WebView/WebFullScreenController.mm:
3729         (-[WebFullScreenController setElement:]):
3730         * WebView/WebGeolocationPosition.mm:
3731         (-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
3732         (-[WebGeolocationPosition initWithGeolocationPosition:]):
3733         * WebView/WebHTMLView.mm:
3734         (currentKeyboardEvent):
3735         * WebView/WebResource.mm:
3736         * WebView/WebScriptWorld.mm:
3737         (-[WebScriptWorld initWithWorld:]):
3738         (+[WebScriptWorld standardWorld]):
3739         (+[WebScriptWorld findOrCreateWorld:]):
3740         * WebView/WebViewData.h:
3741         (LayerFlushController::create):
3742
3743 2017-05-11  Chris Dumez  <cdumez@apple.com>
3744
3745         Drop remaining uses of PassRefPtr in WebCore
3746         https://bugs.webkit.org/show_bug.cgi?id=172013
3747
3748         Reviewed by Yusuke Suzuki.
3749
3750         * Plugins/Hosted/NetscapePluginInstanceProxy.h:
3751         * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
3752         (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
3753         (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
3754         * Plugins/Hosted/WebHostedNetscapePluginView.mm:
3755         (-[WebHostedNetscapePluginView createPluginBindingsInstance:]):
3756
3757 2017-05-11  Tim Horton  <timothy_horton@apple.com>
3758
3759         Mail spins launching spell checker when typing
3760         https://bugs.webkit.org/show_bug.cgi?id=171986
3761         <rdar://problem/26305327>
3762
3763         Reviewed by Beth Dakin.
3764
3765         * WebView/WebView.mm:
3766         (-[WebView setEditable:]):
3767         Asynchronously pre-warm the spell checker when a WebView becomes editable.
3768
3769 2017-05-09  Sam Weinig  <sam@webkit.org>
3770
3771         Remove support for legacy Notifications
3772         https://bugs.webkit.org/show_bug.cgi?id=171487
3773
3774         Reviewed by Jon Lee.
3775
3776         * Configurations/FeatureDefines.xcconfig:
3777         * WebCoreSupport/WebNotificationClient.h:
3778         * WebCoreSupport/WebNotificationClient.mm:
3779         * WebView/WebNotification.mm:
3780         * WebView/WebNotificationInternal.h:
3781         * WebView/WebView.mm:
3782         (-[WebView _commonInitializationWithFrameName:groupName:]):
3783         (-[WebView _notificationIDForTesting:]):
3784         Remove legacy notification specific code.
3785
3786 2017-05-10  Chris Dumez  <cdumez@apple.com>
3787
3788         Simplify relationship between Attr and Element now that Attr is childless
3789         https://bugs.webkit.org/show_bug.cgi?id=171909
3790
3791         Reviewed by Ryosuke Niwa.
3792
3793         Build fix.
3794
3795         * DOM/DOMAttr.mm:
3796         (-[DOMAttr value]):
3797         (-[DOMAttr setValue:]):
3798
3799 2017-05-08  Chris Dumez  <cdumez@apple.com>
3800
3801         Move 'style' from Element to HTMLElement / SVGElement and make it settable
3802         https://bugs.webkit.org/show_bug.cgi?id=171795
3803
3804         Reviewed by Alex Christensen.
3805
3806         Build fix.
3807
3808         * DOM/DOMElement.mm:
3809         (-[DOMElement style]):
3810         * WebCoreSupport/WebEditorClient.mm:
3811         (WebEditorClient::shouldApplyStyle):
3812         * WebView/WebFrame.mm:
3813         (-[WebFrame _typingStyle]):
3814
3815 2017-05-06  Chris Dumez  <cdumez@apple.com>
3816
3817         Align our IDL files with the latest DOM specification
3818         https://bugs.webkit.org/show_bug.cgi?id=171777
3819
3820         Reviewed by Sam Weinig.
3821
3822         Build fix.
3823
3824         * DOM/DOMDocument.mm:
3825         (-[DOMDocument readyState]):
3826
3827 2017-05-05  Jeremy Jones  <jeremyj@apple.com>
3828
3829         REGRESSION (r215951): LayoutTest media/modern-media-controls/placard-support/placard-support-pip.html is a flaky crash
3830         https://bugs.webkit.org/show_bug.cgi?id=171610
3831         <rdar://problem/31976820>
3832
3833         Reviewed by Eric Carlson.
3834
3835         Fullscreen state gets confused because WK1 WebChromeClient doesn't implement exitVideoFullscreenToModeWithoutAnimation.
3836
3837         * WebCoreSupport/WebChromeClient.h:
3838         * WebCoreSupport/WebChromeClient.mm:
3839         (WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):
3840
3841 2017-05-04  Commit Queue  <commit-queue@webkit.org>
3842
3843         Unreviewed, rolling out r216206.
3844         https://bugs.webkit.org/show_bug.cgi?id=171714
3845
3846         Multiple LayoutTests crashing in Document::page() (Requested
3847         by ap on #webkit).
3848
3849         Reverted changeset:
3850
3851         "Remove support for legacy Notifications"
3852         https://bugs.webkit.org/show_bug.cgi?id=171487
3853         http://trac.webkit.org/changeset/216206
3854
3855 2017-05-04  Jeremy Jones  <jeremyj@apple.com>
3856
3857         UIColor +whiteColor and +clearColor are ambiguous and need to be casted when soft linked.
3858         https://bugs.webkit.org/show_bug.cgi?id=171704
3859
3860         Reviewed by Jer Noble.
3861
3862         Fix build by casting result of +whiteColor to UIColor.
3863
3864         * WebView/WebView.mm:
3865         (-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):
3866
3867 2017-05-04  Sam Weinig  <sam@webkit.org>
3868
3869         Remove support for legacy Notifications
3870         https://bugs.webkit.org/show_bug.cgi?id=171487
3871
3872         Reviewed by Jon Lee.
3873
3874         * Configurations/FeatureDefines.xcconfig:
3875         * WebCoreSupport/WebNotificationClient.h:
3876         * WebCoreSupport/WebNotificationClient.mm:
3877         * WebView/WebNotification.mm:
3878         * WebView/WebNotificationInternal.h:
3879         * WebView/WebView.mm:
3880         (-[WebView _commonInitializationWithFrameName:groupName:]):
3881         (-[WebView _notificationIDForTesting:]):
3882         Remove legacy notification specific code.
3883
3884 2017-05-03  Joseph Pecoraro  <pecoraro@apple.com>
3885
3886         [Cocoa] Stop exporting symbols for ivars that were made private
3887         https://bugs.webkit.org/show_bug.cgi?id=171631
3888
3889         Reviewed by Dan Bernstein.
3890
3891         * WebKit.exp:
3892
3893 2017-05-01  Chris Dumez  <cdumez@apple.com>
3894
3895         Remove some usage of PassRefPtr in editing code
3896         https://bugs.webkit.org/show_bug.cgi?id=171490
3897
3898         Reviewed by Darin Adler.
3899
3900         * WebView/WebFrame.mm:
3901         (-[WebFrame dictationResultMetadataForRange:]):
3902         (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3903
3904 2017-05-01  Beth Dakin  <bdakin@apple.com>
3905
3906         On-screen panel for candidate bar is in the wrong place when the caret is at the 
3907         start of a paragraph
3908         https://bugs.webkit.org/show_bug.cgi?id=171453
3909         -and corresponding-
3910         rdar://problem/29779764
3911
3912         Reviewed by Tim Horton.
3913
3914         This bug only happens when the caret is at the beginning of the paragraph, and it 
3915         is because Range::absoluteTextQuads() returns no quads in this case. I think it 
3916         might be correct that absoluteTextQuads() returns no quads in this case, so this 
3917         patch fixes the bug at the call site by using absoluteCaretBounds() in this case.
3918
3919         * WebCoreSupport/WebEditorClient.mm:
3920         (WebEditorClient::handleRequestedCandidates):
3921
3922 2017-04-30  Dan Bernstein  <mitz@apple.com>
3923
3924         [Cocoa] Replaces uses of [get…() alloc] with alloc…Instance()
3925         https://bugs.webkit.org/show_bug.cgi?id=171485
3926
3927         Reviewed by Geoffrey Garen.
3928
3929         * WebView/WebView.mm:
3930         (-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
3931         (-[WebUITextIndicatorData initWithImage:scale:]):
3932
3933 2017-04-28  Youenn Fablet  <youenn@apple.com>
3934
3935         Adding a runtime flag specific to MediaDevices
3936         https://bugs.webkit.org/show_bug.cgi?id=171433
3937
3938         Reviewed by Geoffrey Garen.
3939
3940         Adding a preference for MediaDevices.
3941         Setting media devices runtime flag to false by default.
3942         Setting peer connection and media stream flags to true by default.
3943
3944         * WebView/WebPreferenceKeysPrivate.h:
3945         * WebView/WebPreferences.mm:
3946         (+[WebPreferences initialize]):
3947         (-[WebPreferences mediaDevicesEnabled]):
3948         (-[WebPreferences setMediaDevicesEnabled:]):
3949         * WebView/WebPreferencesPrivate.h:
3950         * WebView/WebView.mm:
3951         (-[WebView _preferencesChanged:]):
3952
3953 2017-04-27  Chris Dumez  <cdumez@apple.com>
3954
3955         Align colspan/rowspan limits with the latest HTML specification
3956         https://bugs.webkit.org/show_bug.cgi?id=171322
3957
3958         Reviewed by Darin Adler.
3959
3960         ObjC bindings build fix.
3961
3962         * DOM/DOMHTMLTableCellElement.mm:
3963         (-[DOMHTMLTableCellElement colSpan]):
3964         (-[DOMHTMLTableCellElement setColSpan:]):
3965
3966 2017-04-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
3967
3968         REGRESSION(r213764): Async decoding of animated images is disabled for ImageDocument
3969         https://bugs.webkit.org/show_bug.cgi?id=170333
3970
3971         Reviewed by Simon Fraser.
3972
3973         Disbale the async decoding for large images for now.
3974
3975         * WebView/WebView.mm:
3976         (-[WebView _preferencesChanged:]):
3977
3978 2017-04-27  Alex Christensen  <achristensen@webkit.org>
3979
3980         Modernize Frame.h
3981         https://bugs.webkit.org/show_bug.cgi?id=171357
3982
3983         Reviewed by Andy Estes.
3984
3985         * WebCoreSupport/WebEditorClient.h:
3986         * WebCoreSupport/WebEditorClient.mm:
3987         (WebEditorClient::isSelectTrailingWhitespaceEnabled):
3988
3989 2017-04-27  Wenson Hsieh  <wenson_hsieh@apple.com>
3990
3991         [WK1] Tweak the data interaction SPI to indicate whether or not a data interaction was handled
3992         https://bugs.webkit.org/show_bug.cgi?id=171369
3993         <rdar://problem/31858853>
3994
3995         Reviewed by Dan Bernstein.
3996
3997         Introduce a new SPI hook intended to replace performDataInteraction:client:global:operation: that
3998         returns whether or not the data interaction was handled. Due to the difference only in return type
3999         and some staging constraints, this version is prefixed with "_tryTo".
4000
4001         * WebView/WebView.mm:
4002         (-[WebView _tryToPerformDataInteraction:client:global:operation:]):
4003         * WebView/WebViewPrivate.h:
4004
4005 2017-04-26  Wenson Hsieh  <wenson_hsieh@apple.com>
4006
4007         WebItemProviderPasteboard should not synchronously load provided data
4008         https://bugs.webkit.org/show_bug.cgi?id=171341
4009         <rdar://problem/31614010>
4010
4011         Reviewed by Tim Horton.
4012
4013         Adds client-layer plumbing for updatePreferredTypeIdentifiers. See WebCore ChangeLog for more details.
4014
4015         * WebCoreSupport/WebPlatformStrategies.h:
4016         * WebCoreSupport/WebPlatformStrategies.mm:
4017         (WebPlatformStrategies::updatePreferredTypeIdentifiers):
4018
4019 2017-04-26  Zalan Bujtas  <zalan@apple.com>
4020
4021         RTL: recent searches popover is displayed in incorrect location
4022         https://bugs.webkit.org/show_bug.cgi?id=171338
4023         <rdar://problem/31377807>
4024
4025         Reviewed by Dean Jackson.
4026
4027         Add RTL support for the pop-under branch.
4028
4029         * WebCoreSupport/PopupMenuMac.mm:
4030         (PopupMenuMac::show):
4031
4032 2017-04-25  Brent Fulgham  <bfulgham@apple.com>
4033
4034         Limit allowed size of document.title to avoid locking WebKit clients
4035         https://bugs.webkit.org/show_bug.cgi?id=165113
4036         <rdar://problem/28324389>
4037
4038         Reviewed by Darin Adler.
4039
4040         When a web application attempts to set an extremely long title, truncate the
4041         title to a more reasonable size.
4042
4043         We do this at at the presentation layer, rather than in the DOM, so that we do
4044         not affect script function. Instead, we merely limit display to a level that is
4045         reasonable for normal GUI widgets. Anything else needs to be truncated in the UI
4046         layer, so it is a waste of effort to send across IPC.
4047
4048         * WebCoreSupport/WebFrameLoaderClient.h:
4049         * WebCoreSupport/WebFrameLoaderClient.mm:
4050         (WebFrameLoaderClient::dispatchDidReceiveTitle):
4051
4052 2017-04-25  Daniel Bates  <dabates@apple.com>
4053
4054         [Cocoa][Win] Enable of X-Content-Type-Options: nosniff header
4055         https://bugs.webkit.org/show_bug.cgi?id=136452
4056         <rdar://problem/23412620>
4057
4058         Reviewed by Brent Fulgham.
4059
4060         Enable X-Content-Type-Options: nosniff on Mac, iOS and Windows platforms.
4061
4062         * Configurations/FeatureDefines.xcconfig:
4063
4064 2017-04-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4065
4066         Support reading NSURL titles from the pasteboard when performing data interaction
4067         https://bugs.webkit.org/show_bug.cgi?id=171156
4068         <rdar://problem/31356937>
4069
4070         Reviewed by Tim Horton.
4071
4072         Add a new WK1 SPI property, -[WebFrame hasRichlyEditableDragCaret].
4073
4074         * WebCoreSupport/WebPlatformStrategies.h:
4075         * WebCoreSupport/WebPlatformStrategies.mm:
4076         (WebPlatformStrategies::readURLFromPasteboard):
4077         * WebView/WebFrame.mm:
4078         (-[WebFrame hasRichlyEditableDragCaret]):
4079         * WebView/WebFramePrivate.h:
4080
4081 2017-04-24  Andy VanWagoner  <thetalecrafter@gmail.com>
4082
4083         Clean up ICU headers
4084         https://bugs.webkit.org/show_bug.cgi?id=170997
4085
4086         Reviewed by JF Bastien.